From xen-devel-bounces@lists.xenproject.org Wed Jul 01 06:22:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 06:22:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349515.1607248 (Exim 4.92) (envelope-from ) id 1weoLA-0003gf-9w; Wed, 01 Jul 2026 06:22:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349515.1607248; Wed, 01 Jul 2026 06:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weoLA-0003gX-4r; Wed, 01 Jul 2026 06:22:32 +0000 Received: by outflank-mailman (input) for mailman id 1349515; Wed, 01 Jul 2026 06:22:31 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weoL9-0003gN-CO for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 06:22:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1weoL8-0078bg-0t for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 08:22:30 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44b219-bab6-0a2a0a5309dd-0a2a450899fc-42 for ; Wed, 01 Jul 2026 08:22:29 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44b220-edec-0a2a45080019-d155dd2cbdea-3 for ; Wed, 01 Jul 2026 08:22:24 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-472a14c9965so163164f8f.1 for ; Tue, 30 Jun 2026 23:22:24 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475643cd85dsm13504749f8f.15.2026.06.30.23.22.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 23:22:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782886944; x=1783491744; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=VERsjxAe7q+yFAlos0PXWjPHKVOpuLdwRRRHZYD0o0M=; b=CGAcoxa2uaVv3b+9gpK6HqIzr+BXbMmD6Bz8crt+kYsdIaXepk1cq7cD8AHs4vSzIG +gC8qwiv5Ppec5VNNTR4tDvSeVXJmoMX0phobIBxW7UHK4a+i669kNmhjteuRf60Cnak YGIv5WwNwpAsw6j2tZX5UTzG7ScLMFMBYkm6ckAV2ZfHM8/mxKOKlE3EI5OXaPorciTu 1aApVBDuFYGdRXcNuDLuOMiMCE6suGUJVNJYygFu3gdu1zTsFOqX7GUas4fFRh1a4J4N WapT7CGiR8E220TdiJpCpUvHa01NU8hmQLikRYfSldBGLQjYhQL22XdtTUriBMKmKqIa hORQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782886944; x=1783491744; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VERsjxAe7q+yFAlos0PXWjPHKVOpuLdwRRRHZYD0o0M=; b=Rcf6N39F+Bn8upRLR1w3Mn6w1c/DSwwTy3tx3miAEbFxqYn7Lr6RS9UIBWR+0wZWYo Jojw/41ipWgT/Xx5Wyh4SKJV5ogjPCqMsG7SMM921LbTNBgDA5skKULZ5MFS3MYZf8iL kt4b3Dixvz2+rMc0xEwy8yOlVLevgALrxW9ZAjhmXkrjMB8cxww8ma8SGfAcN9bUuGlP O3q41tLB7K6Va8sHbnlLQZyA+GzTo+jlvsFMGUC9I7hd8Qn7PlFK9eKi9ZRnVRByRxhT lTMUudnmVugG4Vr95k61f9vapghuWdHb+z4lu8qosNNRE3XZBkO1D0LMlXV6hocMYc74 uI4g== X-Forwarded-Encrypted: i=1; AFNElJ/KwPgxa/Uq4fhFruCL7fR24kctmRfwOMweiqE8fUtfM1vtDmxIn9tDlO4QY4YlcH/8P2SIBG3dms0=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzm3NwuS7hvWESQyRAPhvKixexo5g2ZUgj1Mp7ZrjMV663aDTmG lDp0msnDGWT4TvngFpFphkmUzI0IwlluLZrfQZt2XoCbvIdJtTWxCUcaCoLej0DTeQ== X-Gm-Gg: AfdE7clSYgvgCxsasxB3DhZUJAubc4V/SLQYrFCibGYNcPyO4mjvOZgygZns2xQUwse iGJODwiq9wLZMIaIkbBUXB+6zoFaaIojaPfU1rBlmLA0TC2bRny67/HcDwM+ZnUvuVfush8rNKA m+SjgaIKrEdP+KbKDTZeB0Bz10jVfD6QoKIwiUEoI73eXHs+cTLdqJqm3rJyJewCeFIjBoD0v6v ndoe41u82lGbZEH4Jc6cp2J5DpsPyDUyrjokoBamZFgncQHhLkpkJXCfylbaqdKpI/e5LazloZg imC/PmvYqtMMeRtNUknCLkokYu4SuGLt3jHqObMV67Hxom5QJjlpudqb2EBQWRlLXWRwNVdELbg DubWmmtnBm4T20cQSHHd1ig+sN+CzEuuLeXm52QSjGAFFQIBxrV1Ejtj//BmtsLAcS1qgQsMcA7 5XA04aK02bEDOljtg4EvaAgt0jEMACcWa/PSu9oEjQbt9Alvv2UF+bNGlJ5wUonMhJxdd0KHOf5 Pb2 X-Received: by 2002:a05:600c:6a96:b0:493:b750:b565 with SMTP id 5b1f17b1804b1-493c2ba9d58mr2175655e9.35.1782886944372; Tue, 30 Jun 2026 23:22:24 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 08:22:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/25] xen/riscv: introduce guest riscv,isa string To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <9d082182-394d-40cd-9afe-35369d7bc4bc@suse.com> <20740b98-bdc0-4098-afda-45b09dc07ca3@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20740b98-bdc0-4098-afda-45b09dc07ca3@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c1860d/1782886949-48C6F3FC-E1378722/0/0 X-purgate-type: clean X-purgate-size: 2694 On 30.06.2026 18:06, Oleksii Kurochko wrote: > On 6/29/26 4:46 PM, Jan Beulich wrote: >> On 26.06.2026 17:46, Oleksii Kurochko wrote: >>> +static void __init init_guest_unsupp(void) >>> +{ >>> + __set_bit(RISCV_ISA_EXT_f, guest_unsupp); >>> + __set_bit(RISCV_ISA_EXT_d, guest_unsupp); >>> + __set_bit(RISCV_ISA_EXT_q, guest_unsupp); >>> + __set_bit(RISCV_ISA_EXT_v, guest_unsupp); >>> + __set_bit(RISCV_ISA_EXT_h, guest_unsupp); >>> + __set_bit(RISCV_ISA_EXT_sstc, guest_unsupp); >>> + __set_bit(RISCV_ISA_EXT_svade, guest_unsupp); >>> + __set_bit(RISCV_ISA_EXT_svpbmt, guest_unsupp); >>> +} >> >> Wouldn't riscv_isa_ext[] better get a prominent reminder that additions there >> may need mirroring here (unless guest support is implemented at the same time)? >> (As before, yet better would of course be to make sure this is consistent >> right from build time, i.e. without the need to have this separate function. >> Or minimally have the info right in that array, so that while adding one needs >> to think how to set that separate field.) > > How about making the field mandatory at the call site instead, so it > can't be silently forgotten: > > #define RISCV_ISA_EXT_DATA(ext_name, guest_supp) \ > { \ > .id = RISCV_ISA_EXT_ ## ext_name, \ > .name = #ext_name, \ > .guest_supported = guest_supp, \ > } > > Every entry in riscv_isa_ext[] would then need an explicit true/false > argument, e.g. RISCV_ISA_EXT_DATA(f, false). That forces whoever adds a > new extension to make the decision right there, rather than relying on a > separate init_guest_unsupp() to be remembered. We'd drop guest_unsupp > and init_guest_unsupp(), and build d->arch.isa directly from the array > in init_guest_isa(). This is what I meant with "Or minimally ...". >>> @@ -94,6 +95,9 @@ struct arch_domain { >>> struct p2m_domain p2m; >>> >>> struct paging_domain paging; >>> + >>> + DECLARE_BITMAP(isa, RISCV_ISA_EXT_MAX); >>> + char *isa_str; >>> }; >> >> Why is it again that both the bitmap and its string representation need >> storing? In the end they provide two different sources of truth, as there's >> no guarantee that they'll remain in sync. > > isa_str is needed to guest device tree to tell which extensions are > supported. Sure, but does that need storing over the lifetime of the domain? Can't that string be allocated, built, used, and then freed while DT is being built? Would that string be used at all for toolstack-created domains? Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 01 07:05:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 07:05:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349527.1607258 (Exim 4.92) (envelope-from ) id 1wep0y-000326-Dz; Wed, 01 Jul 2026 07:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349527.1607258; Wed, 01 Jul 2026 07:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wep0y-00031y-A1; Wed, 01 Jul 2026 07:05:44 +0000 Received: by outflank-mailman (input) for mailman id 1349527; Wed, 01 Jul 2026 07:05:43 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wep0w-00031q-27 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 07:05:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wep0v-008YJK-BR for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:05:41 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44bc3f-2eae-0a2a0a5409dd-0a2a4502da62-26 for ; Wed, 01 Jul 2026 09:05:40 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44bc43-5a27-0a2a45020019-5a9b3222db76-3 for ; Wed, 01 Jul 2026 09:05:39 +0200 Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wep0n-00000006Avt-1h6e; Wed, 01 Jul 2026 07:05:33 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id ECCFA30035C; Wed, 01 Jul 2026 09:05:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+AaYpDAuxo7H4NIsCnNAZDJ/up1aHckwKckTsZUvyYo=; b=obljbhuiEFfUuQG2puQ/PkbnJB ObvbkN3jtXxrgtWidSkKLpIFrJAhoSkE0ln3nU9mr8U/s6eVLGJ3wgVZE8OqsfGTjooaeg/G1q0Bx 4ykvNq3SVgHh1vZGY7LQyVu+cJwysZH/AAayjUiEuDzqqlHKusFT0kOfmcjqEYfAVSrhjYoo/ALlN eDOtGEALQpKWr8R+L6fOm2nhZ/X04WVjwDX15RQsFxk+5sT62z2LjJ/ohPAf6WnBh3i2BJ4e5YSFk ZvmTMJW/gH/cz4XaFf28ftNCy6xI6xFAw48J2trogdaLMXogw0JaXN+VhndNhW4UY1f5oe60hJl86 9HZxYVNg==; Date: Wed, 1 Jul 2026 09:05:31 +0200 From: Peter Zijlstra To: Mauricio Faria de Oliveira Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp Message-ID: <20260701070531.GK48970@noisy.programming.kicks-ass.net> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> X-purgate-ID: tlsNG-720697/1782889540-4D3037C5-3C8A4052/0/0 X-purgate-type: clean X-purgate-size: 3069 On Tue, Jun 30, 2026 at 02:21:46PM -0300, Mauricio Faria de Oliveira wrote: > Move the inline memcmp function currently only available in 'boot/string.c' > into the shared string function header to be reused. > > This is not done through to avoid pulling unnecessary code > in 'boot/string.c' that causes build errors in 'boot/compressed/string.c' > and 'purgatory/purgatory.ro'. > > Note that the inline memcmp() returns 0/1, not -1/0/1 as regular memcmp() > (reported by David Laight ). > > Signed-off-by: Mauricio Faria de Oliveira > --- > arch/x86/boot/string.c | 6 ++---- > arch/x86/include/asm/shared/string.h | 16 ++++++++++++++++ > arch/x86/include/asm/string.h | 1 + > 3 files changed, 19 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c > index ac0f900ebc47efa81c92e1bb2010ea41677899c4..be454a6864225f3a972c3e81826b77ed4e8a57fe 100644 > --- a/arch/x86/boot/string.c > +++ b/arch/x86/boot/string.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include "ctype.h" > #include "string.h" > > @@ -31,10 +32,7 @@ > > int memcmp(const void *s1, const void *s2, size_t len) > { > - bool diff; > - asm("repe cmpsb" > - : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); > - return diff; > + return __inline_memcmp(s1, s2, len); > } > > /* > diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h > new file mode 100644 > index 0000000000000000000000000000000000000000..422952152f533ad75b98f3873297b39c4f5e2477 > --- /dev/null > +++ b/arch/x86/include/asm/shared/string.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_X86_SHARED_STRING_H > +#define _ASM_X86_SHARED_STRING_H > + > +/* Note: this memcmp() returns 0/1, not -1/0/1 as regular memcmp(). */ > +static __always_inline int __inline_memcmp(const void *s1, const void *s2, size_t len) > +{ > + bool diff; > + > + asm("repe cmpsb" > + : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); > + > + return diff; > +} > + > +#endif /* _ASM_X86_SHARED_STRING_H */ > diff --git a/arch/x86/include/asm/string.h b/arch/x86/include/asm/string.h > index 9cb5aae7fba9ffcf0f5af8f939d30467750ccaa9..f0f4fd8227bf992e78c69209efb31f0a9a0cc3b1 100644 > --- a/arch/x86/include/asm/string.h > +++ b/arch/x86/include/asm/string.h > @@ -7,6 +7,7 @@ > #else > # include > #endif > +#include > > static __always_inline void *__inline_memcpy(void *to, const void *from, size_t len) > { It seems weird to have __inline_mem{cpy,set}() in a different header than __inline_memcmp(). I'm assuming this is because boot cannot include the normal string thing? Perhaps make inline_string.h or somesuch to carry all three of them and include that from the relevant places? From xen-devel-bounces@lists.xenproject.org Wed Jul 01 07:45:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 07:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349545.1607267 (Exim 4.92) (envelope-from ) id 1wepcu-0001li-6v; Wed, 01 Jul 2026 07:44:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349545.1607267; Wed, 01 Jul 2026 07:44:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wepcu-0001lb-2n; Wed, 01 Jul 2026 07:44:56 +0000 Received: by outflank-mailman (input) for mailman id 1349545; Wed, 01 Jul 2026 07:44:55 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wepct-0001lV-42 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 07:44:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wepcr-009ztH-DF for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:44:53 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44c56b-bab6-0a2a0a5309dd-0a2a450cdf7c-32 for ; Wed, 01 Jul 2026 09:44:53 +0200 Received: from [209.85.167.53] (helo=mail-lf1-f53.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44c575-f399-0a2a450c0019-d155a735c968-3 for ; Wed, 01 Jul 2026 09:44:53 +0200 Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5aeae771c49so306206e87.3 for ; Wed, 01 Jul 2026 00:44:53 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aec5eaed8esm160558e87.6.2026.07.01.00.44.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 00:44:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782891893; x=1783496693; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vlHQ/fvs5m+gF3nR5deR9QkQTOr+VSn7/u3q6MKLMBY=; b=NLIlUc1NcEkVsGbbgjspSrmmoVKQiqBBgLywJxa5Z//9XW2K2lHseOxoGesy0dqElT 4+06GbGeh/hAYv3n0BJu4vZr2oyJsEIQmYkhPVWQSXsYvxWwlABArczIv1ww5hEc2E0i vPpIFDiR/uDXTdvUsK7LPxWL/NojdQoA0+kpKcgI32nGcihj74bf3Tp05ez5yz1x1pF+ Liy1e051OPvH59mjrLcinFQbIe8n9zw6g6K12jyR27uakWvauXyGRNuV8OWe/myvqUcS ZYYXcpSp0CV+wznXHNxwqdDOfWs75pJTkKw8IS0q2MLi/KQ5hhTss90foRQQ7bGJi6Ia fykw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782891893; x=1783496693; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vlHQ/fvs5m+gF3nR5deR9QkQTOr+VSn7/u3q6MKLMBY=; b=ifj7CHkB2yeUlm7NRWj+4s6hsDzStwr7TO2qZGRVx+lah3jYIGzpkvi9EApU5V1eni n82vPSipccUWdacaC95lLpKkiGYWgHozd9HzN/GZNxeHD/Bc7aajiG+NSwObCO1DtuOr J852wVpfEvrjPIcF20TI+A5kNaHY3a0e0GGq18joVmbrcsIAVMn9tjqTeB0eMeWGGNGA DgJTZ/DjM2K0/w30sPFzL/mTCy/c6TtuttnetgL4y7EE1xGlG8HgIFYmUi/sLYymAwnd BYErUhitOc9vKcH53TvES4szEhKZLU6nSsogco9xcvAGpLcgqOVde1736SwLHijrmn8N +PRw== X-Forwarded-Encrypted: i=1; AHgh+Rpfj89hlWAXpNWlCqyqSJriFE2XV1+1KqxMhzlUsCQYdDLDenwge5XotxlKZMsbYnatJBcBYI8s/vQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YxeD0QbeLiq0GPpReVvxFFK43DRsNPntGkl76//F++CCcEtbzA3 p6dI6z8CEoifjaHnTqgmGmjHkGl8hYTk1KVEM0g+pRhff3VrztM5J834 X-Gm-Gg: AfdE7cnd+pYAMe0TCEftiSiu9JkeZfpjKcC398shVEnCmgxA66Asn5yf3r6jxwB9vde p4wcYpLHmvFKG+sjd+GTxXV93/9xw2o1MOcVV5jvRCUwDoDGP/nOdT2C5BOR9cE/9R255aEebLX /uFceGCCxbTj2hnoFKWuw9ZWMDWhKCQhKZogjR5MMRD81DEIkJlB5r4IyFCGeF4RAVQppN+uvUd nUkL5815Wl0mn9TP+Dk8KFMKw/8vu8ZGQ69M9XfIA/MV2+bCzSsMcjyYhcDamQwqQuXG8j6ymka PtVc1SYr31y6ryAyd8MmoZjg2lHgDHT3+21FrSw9bfvcox/sodFOCsZ/HRyIOvjpz3Ha9h6gxwH AHRpYJNPb5dyUXCjKNjcNgRtmWUU3WSvBaM9Ro+NRwDjQz+YwAoc9Qs8NMf5n+tGGkMMmj8O3dn OiypDEnN6e4+V81tKleGGoYu4WskTc0ELc5m75S4rmQxWwJkoXKTJDiBVknjvl34Oa35Q= X-Received: by 2002:a05:6512:230e:b0:5ae:b88f:3126 with SMTP id 2adb3069b0e04-5aec67a5c18mr110488e87.26.1782891892365; Wed, 01 Jul 2026 00:44:52 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 09:44:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/25] xen/riscv: introduce guest riscv,isa string To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <9d082182-394d-40cd-9afe-35369d7bc4bc@suse.com> <20740b98-bdc0-4098-afda-45b09dc07ca3@gmail.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1782891893-0F737D51-71E7065B/10/73395122804 X-purgate-type: spam X-purgate-size: 1061 On 7/1/26 8:22 AM, Jan Beulich wrote: >>>> @@ -94,6 +95,9 @@ struct arch_domain { >>>> struct p2m_domain p2m; >>>> >>>> struct paging_domain paging; >>>> + >>>> + DECLARE_BITMAP(isa, RISCV_ISA_EXT_MAX); >>>> + char *isa_str; >>>> }; >>> Why is it again that both the bitmap and its string representation need >>> storing? In the end they provide two different sources of truth, as there's >>> no guarantee that they'll remain in sync. >> isa_str is needed to guest device tree to tell which extensions are >> supported. > Sure, but does that need storing over the lifetime of the domain? Considering my answer to you last question here ... then there is no such need. Can't > that string be allocated, built, used, and then freed while DT is being > built? Agree, it could be done in this way. Would that string be used at all for toolstack-created domains? ... No, it won't. This string will be created by toolstack. So it could really be dropped from arch_domain. Thasnk. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 07:52:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 07:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349556.1607275 (Exim 4.92) (envelope-from ) id 1wepka-000458-Vq; Wed, 01 Jul 2026 07:52:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349556.1607275; Wed, 01 Jul 2026 07:52:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wepka-000451-TH; Wed, 01 Jul 2026 07:52:52 +0000 Received: by outflank-mailman (input) for mailman id 1349556; Wed, 01 Jul 2026 07:52:51 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wepkZ-00044t-Kq for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 07:52:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wepkY-002QIu-Hr for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:52:50 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44c747-2eae-0a2a0a5409dd-0a2a45059a16-42 for ; Wed, 01 Jul 2026 09:52:50 +0200 Received: from [209.85.208.52] (helo=mail-ed1-f52.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44c752-3cb2-0a2a45050019-d155d034a948-3 for ; Wed, 01 Jul 2026 09:52:50 +0200 Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-697e96dd8d2so2277302a12.1 for ; Wed, 01 Jul 2026 00:52:50 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288d1efdcsm227749466b.5.2026.07.01.00.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 00:52:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782892370; x=1783497170; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=mZWrvIJM0XRvfijSg2/E1oscXfW4ZZBxskay/5yhox4=; b=WvH00+m5KJ7DZttDMgG+CVvWaL7z9iN3aqyuvg+okA3j0REwDSBmhxEzuDfWpPD6bE MYbmW6WqE3Me3QWV2L7YpZebIdZLhqHyicBIfCuTS2zEBSrZPveelJcnU6kd050FBGrk uIxdPHB1piqj8p2aOgyhukfzNKodM6UHv6OPuqQWyqz3jvBWlPa5qc72k5KXwZDed8My kPTuoMjSOitLCQV8FCOD2KY44WQUV01f1rcai+3KZP9IQLggvtlwOsKHktBDAPnL5rXy efUKJ4btuK6+MFaj/0nxJe4MRc8ThqVyenhbZ6T9szpElTq0JovS5QvCL2NyVQ/q2YWW BP1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782892370; x=1783497170; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZWrvIJM0XRvfijSg2/E1oscXfW4ZZBxskay/5yhox4=; b=DUGHBklKVvE+RTDKMu7IjoJKPFDZUzW9QMb2VSlzfKp95NVFnX/ME5LYcAOJRAbeDa +zM2d6+uaMzC2FHxLzj6MpNUOrm0JZvUS1b7Ft6BrmdjKY7aDONq5b71j/63UIOz02OY otRW2HvX2OkT7teT4M5/2NekJt4KCbje750MY13i4LXxF1hXrFoOJbVwKwkKcSy5B4Q4 h+W1ZE+5cM00YwXVqQyuixerLH2wkCUAHqjUq9+MxFPfHFSn5QY98T79qC2PCcjNOJa/ Cd/52p8VGd5bgRGv9siANuVmgNErALRoQZk8o+98JZZA6i0T3E45G9Qk15v+SUbRWqzF 0cFQ== X-Gm-Message-State: AOJu0YyR/6fJAVNM5qnIM2P7DXG+xs61kL0J4wwktPcOm1bGrEjI35zk +Vj9g8QnfCYrG+3LVX8bNe0gFK6rjfLDKPDzDS+f03RHYWFiCIpOtv2mvK8cMWNo0c0= X-Gm-Gg: AfdE7ckJq78qTGV4UqcSqh0UcBh3aDNbRZ1aoqkqPMq9YpywkJMEe4MEbMsNm9R+0P6 Qjy1P+jSPhVtr7h6ObAAxrIjHoCsiBKEed+HAkMWhuLwbVUGym3KRyOcifDfVoaeVhjrj6D47dS ZTbyjZA1G/vDrukoe8vGSsPEo19851//BQh9ExfQwysfuylYm0GTEA2qwU0i5OMF1AEduuJE2mQ aV1eMlxDddUadY1sAgUT+tyX62rZFCvBf9F71eXm6UeGfSH5TypTx9AG8t0vFVTFUvh4xsSheEb g+JksrYKekaBLDSKAFane2CmacaXsFCbJGp1levDRlOAvuZNAJ2bfqjnXMkM66onyAb/vDdTAD+ oQ18QGqluxS50Uh8riYIDj7cRIOltJw/EaR3i5//3IjHvos6M7KlipJnYNuhzy/ETeSVu5vV+Ir Q0mpv0lOXJgedTqrJ3KSC4qCnxffO2Uq/q3pIumnppXciAUnVb+hu+2c75pYhXwlU4CMJD6hnkV ixknR6+3h9/4JLjI+v6KOYAeVE8IZLbIHah1z6CVAQ= X-Received: by 2002:a17:907:c706:b0:c10:10c9:6d8c with SMTP id a640c23a62f3a-c129056e30emr213977366b.28.1782892369578; Wed, 01 Jul 2026 00:52:49 -0700 (PDT) Message-ID: <5bedb3af-57ed-423b-ac84-e539cace8002@suse.com> Date: Wed, 1 Jul 2026 09:52:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] xen/gntalloc: make grant counters unsigned To: Yousef Alhouseen , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260624124745.10073-1-alhouseenyousef@gmail.com> <20260626223805.43781-1-alhouseenyousef@gmail.com> <20260626223805.43781-2-alhouseenyousef@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260626223805.43781-2-alhouseenyousef@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------J755ZkPsuEdx67MzsZ4kRs51" X-purgate-ID: tlsNG-c201ff/1782892370-559EA2B8-50857495/0/0 X-purgate-type: clean X-purgate-size: 6725 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------J755ZkPsuEdx67MzsZ4kRs51 Content-Type: multipart/mixed; boundary="------------YjNmNxwb7UREts0lSX9QxItC"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Yousef Alhouseen , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <5bedb3af-57ed-423b-ac84-e539cace8002@suse.com> Subject: Re: [PATCH v2 1/2] xen/gntalloc: make grant counters unsigned References: <20260624124745.10073-1-alhouseenyousef@gmail.com> <20260626223805.43781-1-alhouseenyousef@gmail.com> <20260626223805.43781-2-alhouseenyousef@gmail.com> In-Reply-To: <20260626223805.43781-2-alhouseenyousef@gmail.com> --------------YjNmNxwb7UREts0lSX9QxItC Content-Type: multipart/mixed; boundary="------------XL9Ki31xgEYNA12S7ROL0akl" --------------XL9Ki31xgEYNA12S7ROL0akl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDYuMjYgMDA6MzgsIFlvdXNlZiBBbGhvdXNlZW4gd3JvdGU6DQo+IFRoZSBtb2R1 bGUgbGltaXQgYW5kIGN1cnJlbnQgYWxsb2NhdGlvbiBjb3VudCBjYW5ub3QgdmFsaWRseSBi ZQ0KPiBuZWdhdGl2ZS4gR2l2ZSBib3RoIHZhcmlhYmxlcyB1bnNpZ25lZCB0eXBlcyBzbyB0 aGVpciByZXByZXNlbnRhdGlvbg0KPiBtYXRjaGVzIHRoZSB1MzIgZ3JhbnQgY291bnQgc3Vw cGxpZWQgdGhyb3VnaCB0aGUgaW9jdGwgYW5kIG5lZ2F0aXZlDQo+IG1vZHVsZSBwYXJhbWV0 ZXIgdmFsdWVzIGFyZSByZWplY3RlZCBieSBwYXJhbWV0ZXIgcGFyc2luZy4NCj4gDQo+IFRo aXMgYWxzbyBwcmVwYXJlcyB0aGUgbGltaXQgY2hlY2sgZm9yIG92ZXJmbG93LXNhZmUgdW5z aWduZWQNCj4gYXJpdGhtZXRpYy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFlvdXNlZiBBbGhv dXNlZW4gPGFsaG91c2VlbnlvdXNlZkBnbWFpbC5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K --------------XL9Ki31xgEYNA12S7ROL0akl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------XL9Ki31xgEYNA12S7ROL0akl-- --------------YjNmNxwb7UREts0lSX9QxItC-- --------------J755ZkPsuEdx67MzsZ4kRs51 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpEx1AFAwAAAAAACgkQsN6d1ii/Ey8t dgf/dnSo53jGULeig40sjRDw5aNG6FdMeh2UOHsJNFUPJims+WFjbPE2QJGeh29dGABTl0gKN6ph x6p4XkR2cdxOgHVpIrfJsniFXcpve4ni951+4X8z5FDHcPlYlZu+238C3vpdt9QVR1AEiSoOz2n+ 0XHYiTXGI4g2YpKjuRLbbLlna1dZAm7JW7UgoazlMU4qpuq8JoHRZKSSa2FHYNC0B5DhydIRCV/2 qUm95j3xHd7Jl/IbE1dLlx8lzw3U1KoeZrrQKC4HTxI7rpj4ps+642nQLmUc+kod000lrMhfHdmN XkM+LwgRWV5hw5UFpoSzb+/nrHGg+VjGcxGWgyux2A== =tsDo -----END PGP SIGNATURE----- --------------J755ZkPsuEdx67MzsZ4kRs51-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 07:53:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 07:53:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349563.1607284 (Exim 4.92) (envelope-from ) id 1weplA-0004Yc-84; Wed, 01 Jul 2026 07:53:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349563.1607284; Wed, 01 Jul 2026 07:53:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weplA-0004YV-52; Wed, 01 Jul 2026 07:53:28 +0000 Received: by outflank-mailman (input) for mailman id 1349563; Wed, 01 Jul 2026 07:53:27 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wepl9-0004YJ-DM for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 07:53:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wepl8-002gAr-CF for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:53:26 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44c772-5cb7-0a2a0a5109dd-0a2a450c9014-20 for ; Wed, 01 Jul 2026 09:53:26 +0200 Received: from [209.85.218.47] (helo=mail-ej1-f47.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44c775-f399-0a2a450c0019-d155da2fe813-3 for ; Wed, 01 Jul 2026 09:53:26 +0200 Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-c0e124d2a21so48228866b.2 for ; Wed, 01 Jul 2026 00:53:25 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288dbd47asm226809266b.27.2026.07.01.00.53.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 00:53:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782892405; x=1783497205; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ynNEEoise1PwQ5IFgWasop74gCeOXQ28S+d1Y2f3vRs=; b=flqrvB9eW1UkOSHrLVMSgYUXjPlHHEPx1HOTRGhYDUtm8achcNL3PHHaCcvdQ0PUcG /ihu+R+mGxUXWqFtSnVhzjKt35v66B9oS9rRkPjetEQ9OK0VSw45NrIMbbqZ89shCBc6 hrhnKoqoyl3kY72CcXV01XmWbXojBIUjfMeCn8LjdQkFYHwH/onYHGQE15MdOO/ahR8b MaTjQ9NHLmayihbNkFwk7qKp24dhx0EyCAtAx1bd6fuVVBFvJ5wSNH+6WxcC4+UZSCNK UVhdH+E1hqjS760wGCXeSrLPNGcDco2ORAmqhPH6gyt4NhV5D6U5LTxqOPilYbL/F4DZ 0ZHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782892405; x=1783497205; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ynNEEoise1PwQ5IFgWasop74gCeOXQ28S+d1Y2f3vRs=; b=lFRaLdqv0DgFDiIPK8r5OnV6224YRFDbkdfG1uVotIS7INl64TO9jTyXn8ezuzms0/ pclzMkwxVLZl8qTI+P41Ti6tGtCflb1Ocqsod+U6oMh+VgYJj7r2KBwOGoJ/mYxPfD+M m1MSFItOZa+fMDw5XzPB0xgsHdnUTCEC3dPDoiGvUj9Waeb8z73jm8Agu/AtYK34FSxW xZnlpVMnn3TXVXKNGsfIXoWnbZIGdvkO+KzZbleTHOJprSW0Heghc/dgS9dPNEUBS15B B5h4tZ5Jyo/yc86433Xi0y/zWp1LOC1YTxJ7VJtGW2XWldcNzesOAxrR2UmPr3vQ5tLS BTdA== X-Gm-Message-State: AOJu0Yw4GWQYp6tJlukWO9WbM/zEfXT44PC2CeNTLp9fO2J49ku3B3xq J7o9hOk0+KRLLgB0QegpELFetX3+//HywQChN3IGFNf50XvD3uZiLXvEXeoNEwiDswg= X-Gm-Gg: AfdE7cmLyuvoBpBRoRer3w4TYkcwImJQi/3gKsxM9uKcva4YxZ/37O3rwyEnJHCbI+M qAGDvhGhuxyicnySEmqupQEGY2H0RnKqER6lsJQrnFuMZo86ZQCPnT5xAj6rWi071igJaE/5Rec BTP9Zne2e3kvwg/ZKwDEEuic93KBBR5GKoXg6kx9VLk+qZ2V2T+N2KI0qOqsKoMafbf+IPCj9TI B0PDRD0CYurDL/E+J4BfD2W/iigNqfrrMY7+b8h+qe2f6Iv5UkHDJjVSYFzik7Aczq2vEifwL/y C6Hh+ALxrCi58C/l4B1nWxTo1XVUsFOgKzVMDr1ja6KcWLE5j3JG1RsIOMNOC2nEOMCrEqX692F g70V2NZ+04zxRQdOZbP5J28JYmR3j2YgwD6TgqQH8O7x63pUpkzqOfTmxf3G4dhJub1W8rFVncw tGQF8wySV+3pSIBwj19X7vp07S3Qt58HyMZ9rJt/JjWBdlMdNXFx1plvc9VlCCwTq5nHUlE1t1t W1WnCo3kLx0OPIFju9xDg/jmFbYLacU2ZmZIcjR5ZM= X-Received: by 2002:a17:906:ad7:b0:c0b:81d7:51be with SMTP id a640c23a62f3a-c12aa1412cfmr14752266b.43.1782892405413; Wed, 01 Jul 2026 00:53:25 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 09:53:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] xen/gntalloc: validate grant count before allocation To: Yousef Alhouseen , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260624124745.10073-1-alhouseenyousef@gmail.com> <20260626223805.43781-1-alhouseenyousef@gmail.com> <20260626223805.43781-3-alhouseenyousef@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260626223805.43781-3-alhouseenyousef@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------c2N6S0bmSZEJJAjkd5fv7yQI" X-purgate-ID: tlsNG-d25034/1782892406-9273FD51-B383B1D8/0/0 X-purgate-type: clean X-purgate-size: 6927 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------c2N6S0bmSZEJJAjkd5fv7yQI Content-Type: multipart/mixed; boundary="------------6b8KZc9ZXC5nIjEmhLEUSxPd"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Yousef Alhouseen , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v2 2/2] xen/gntalloc: validate grant count before allocation References: <20260624124745.10073-1-alhouseenyousef@gmail.com> <20260626223805.43781-1-alhouseenyousef@gmail.com> <20260626223805.43781-3-alhouseenyousef@gmail.com> In-Reply-To: <20260626223805.43781-3-alhouseenyousef@gmail.com> --------------6b8KZc9ZXC5nIjEmhLEUSxPd Content-Type: multipart/mixed; boundary="------------1W1gAI0xWQkegOsYmTYkJh5t" --------------1W1gAI0xWQkegOsYmTYkJh5t Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDYuMjYgMDA6MzgsIFlvdXNlZiBBbGhvdXNlZW4gd3JvdGU6DQo+IGdudGFsbG9j X2lvY3RsX2FsbG9jKCkgYWxsb2NhdGVzIHRoZSBncmFudC1pZCBhcnJheSBiZWZvcmUgY2hl Y2tpbmcNCj4gd2hldGhlciB0aGUgcmVxdWVzdGVkIGNvdW50IGZpdHMgd2l0aGluIHRoZSBn bG9iYWwgZ3JhbnQgbGltaXQuIENvdW50cw0KPiBhYm92ZSB0aGF0IGxpbWl0IGNhbm5vdCBz dWNjZWVkLCBzbyByZWplY3QgdGhlbSBiZWZvcmUgdGhlDQo+IHVzZXItY29udHJvbGxlZCBh bGxvY2F0aW9uIHJlYWNoZXMga2NhbGxvYygpLg0KPiANCj4gVXNlIGEgc3VidHJhY3Rpb24t YmFzZWQgY2hlY2sgd2hpbGUgaG9sZGluZyBncmVmX211dGV4IHNvIGFkZGluZyB0aGUNCj4g cmVxdWVzdGVkIGNvdW50IGNhbm5vdCB3cmFwLiBBbHNvIGNhc3QgdGhlIGNvdW50IGJlZm9y ZSBhZHZhbmNpbmcgdGhlDQo+IHBlci1maWxlIGluZGV4IHNvIHRoZSBwYWdlLXNpemUgbXVs dGlwbGljYXRpb24gaXMgcGVyZm9ybWVkIGluIDY0LWJpdA0KPiBhcml0aG1ldGljLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogWW91c2VmIEFsaG91c2VlbiA8YWxob3VzZWVueW91c2VmQGdt YWlsLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNv bT4NCg0KDQpKdWVyZ2VuDQo= --------------1W1gAI0xWQkegOsYmTYkJh5t Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------1W1gAI0xWQkegOsYmTYkJh5t-- --------------6b8KZc9ZXC5nIjEmhLEUSxPd-- --------------c2N6S0bmSZEJJAjkd5fv7yQI Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpEx3QFAwAAAAAACgkQsN6d1ii/Ey+G Bgf+N4NL9+mLMo+V7/vLXxzGE/VZYlm6ov6LM73ofNLN5hI6EJhhje18t6HqhgSnWiquH9j2VW4W fOwHM9Ajb/xGhelS6C8c7T56hLO0VkTLcX77cY/ylgJ2r0tvtdEo9NF4hDJBO/0wkcyCi7OTwkTB olEZGLd48XSYhvy5dmUqOWCZCSTDLfr6LnfntFGqc+sW68ivyWMFnOccGds4lxiLcNDXTgX7XWvb 7jS11d1FJ9C1vgjZjgdCvIvYpueiqaI6pQuIbB93Iah22aJ5pKvi5BAXNeB+qbVOD1QdjAqco5fm O/VW7di0VtZaQ8Lt24OjNYvKUm2OiN4L0aoP/e9R/Q== =PlyJ -----END PGP SIGNATURE----- --------------c2N6S0bmSZEJJAjkd5fv7yQI-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 07:59:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 07:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349575.1607293 (Exim 4.92) (envelope-from ) id 1wepqy-0005MA-S1; Wed, 01 Jul 2026 07:59:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349575.1607293; Wed, 01 Jul 2026 07:59:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wepqy-0005M3-PG; Wed, 01 Jul 2026 07:59:28 +0000 Received: by outflank-mailman (input) for mailman id 1349575; Wed, 01 Jul 2026 07:59:27 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wepqx-0005Lx-Aw for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 07:59:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wepqw-002i7t-KI for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:59:26 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44c8d1-5cb7-0a2a0a5109dd-0a2a4508adec-44 for ; Wed, 01 Jul 2026 09:59:26 +0200 Received: from [209.85.218.54] (helo=mail-ej1-f54.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44c8de-edec-0a2a45080019-d155da36e89a-3 for ; Wed, 01 Jul 2026 09:59:26 +0200 Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c0e124d2a21so48916966b.2 for ; Wed, 01 Jul 2026 00:59:26 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6987c3a3d9bsm2239236a12.4.2026.07.01.00.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 00:59:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782892766; x=1783497566; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=4nbNkASKhTIlBPmQlRNUkJ6qH3MiYyvXeGCcasQsAI0=; b=Sd+JiGdqyeQSXYSphNozl1iUkWmxZE/77Xan+D3ksaZL8UIvVrieAL+Qy1iAoUcoin 3LbWQexfGH6xNAunn4NDPRPvcRi/s4u3lIj97FHh8YGgvTzu8rZ+G8WN1CM48LsPr1qF z5HXUFSE3OkYUyMahMZzacgMfpyCzuRfSAMaiEZZ09FqeK3rTbqgIxSnVEE7yuSN1uy6 uU7omgGtX/S3EsFGxNW/1yMq+kb8GzL/dpyl8BLgbVEjIGcJdkjKuBhnu33vJ+UxH3ps SmxhqBZH2ogVCHRlqATNRtZKA6Z8CI2tPfFbtzw4PYTp2GrBf649WDaoWmAfne2vFsen U58g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782892766; x=1783497566; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4nbNkASKhTIlBPmQlRNUkJ6qH3MiYyvXeGCcasQsAI0=; b=J0pQx84QMN1Fi7WL+vfjmkk1p0EW3WaCGXBgwLJeOU4H00lXi5Ldd7/4PWgBKBE8iF 2AA4+OOqM4eW+mT9Zr/3ec/cp9oENkb6gbX5MVUjZqFQespljQBwtz6U3rdJvxWj8pJh TckvNaqgvPuJI3jpajK/1xU32NQpgBdr3/i812ShHqsHCmzJ8hLHCn+XXlLVDSZj9TsH SqwPoNMW1lo4pjZKNiQg/sUtnyubOSI+zcuO7P63y+Tv/Wgm3lHnAHEszIkeJEy17Ujp /+CfosxptBIeef6SsW8itEHYhpv9DEjVBw5QfSqkpfB5NhQ0Q9NBabcnijyAGPvolMUT Wn/g== X-Gm-Message-State: AOJu0YyELtXuxmlExw/xFiFlA41DDcoXyaIAQpYUDAwfKCZ+wrPy8acs l96LUFwip6C27Kn/z6IodmziJcxELLC1xqirTIHnk5kgiAY8YQtBAImC82wN/sNfIO0= X-Gm-Gg: AfdE7ckz+vMt4j8sFfryjKanWNv6XmIs4j9q3RhT7sIjYykzbym8mm4do3MxGoF2YPd L32kUiMJaU+8tZ+sl1XDqEeiAIPO8CPussYHAyxW0m2tAVlJwvzgsLMacIwxpieQeQpng4pkcte a4w2wlPnygFTZdigdfphHw7QzyVQGAJsI51g8eB1esdoSKEuTW5R7tOWJ78KO4HRu0m7DKwn2Wq asAn2ZomcHJ4QfdAr1/2xN7tQCdl0b/QchYNWRpR/hR9a4zKic+C5jfNmYSCT857Zg5UwE490KW siay9XI6Go4syOHdgFEPh6dDm2Bke5QHlkZusBXps4vRSWa4fNW98mJER1L/uwkyswAHmzde7jy PvxNuPybK/hEonM/3iqme9cHlfF5tscm1DyiUb34Mszb3kYsALhcpFZwfHYb+n0/C4rzU5SDgaB Z+xSSrMRX7skzNmyz4RPb+Fv17xODLf6wkPyPVa8f6IMgax7p8m/TBIgIF9F3jfSCUlxD+Uc/1+ vaBGIxxDP4Wxd9Hzi2Cd6qqPRERF/kufT2Dc7U1sQaDp/s4IQzQEA== X-Received: by 2002:a17:906:e10d:20b0:c12:7512:18cb with SMTP id a640c23a62f3a-c12aa184c6cmr15283466b.58.1782892765663; Wed, 01 Jul 2026 00:59:25 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 09:59:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] xenbus: reject unterminated directory replies To: Yousef Alhouseen , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260624124242.9160-1-alhouseenyousef@gmail.com> <20260626223738.43742-1-alhouseenyousef@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260626223738.43742-1-alhouseenyousef@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Rx8KxrJ07uxXf9wNvhXWzk7Z" X-purgate-ID: tlsNG-c1860d/1782892766-A253F3FC-33819FE0/0/0 X-purgate-type: clean X-purgate-size: 6712 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Rx8KxrJ07uxXf9wNvhXWzk7Z Content-Type: multipart/mixed; boundary="------------4vUdhZNEHihnn0uY9xxS0MzH"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Yousef Alhouseen , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v2] xenbus: reject unterminated directory replies References: <20260624124242.9160-1-alhouseenyousef@gmail.com> <20260626223738.43742-1-alhouseenyousef@gmail.com> In-Reply-To: <20260626223738.43742-1-alhouseenyousef@gmail.com> --------------4vUdhZNEHihnn0uY9xxS0MzH Content-Type: multipart/mixed; boundary="------------hdg6x8htzENYRNr5sEtTzpry" --------------hdg6x8htzENYRNr5sEtTzpry Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDYuMjYgMDA6MzcsIFlvdXNlZiBBbGhvdXNlZW4gd3JvdGU6DQo+IHNwbGl0X3N0 cmluZ3MoKSB3YWxrcyBlYWNoIGRpcmVjdG9yeSBlbnRyeSB3aXRoIHN0cmxlbigpLiBBbHRo b3VnaCB0aGUNCj4gdHJhbnNwb3J0IGFkZHMgYSB0ZXJtaW5hdG9yIGFmdGVyIHRoZSByZXBs eSBidWZmZXIsIGEgbWFsZm9ybWVkIHJlcGx5DQo+IHdpdGhvdXQgYSBmaW5hbCBOVUwgaW5z aWRlIGl0cyBhZHZlcnRpc2VkIGxlbmd0aCB3b3VsZCBsZXQgdGhhdCB3YWxrDQo+IGNyb3Nz IHRoZSBwcm90b2NvbCBwYXlsb2FkIGJvdW5kYXJ5Lg0KPiANCj4gUmVqZWN0IHN1Y2ggcmVw bGllcyBiZWZvcmUgY291bnRpbmcgdGhlIHN0cmluZ3MuIFJlcG9ydCB0aGUgcHJvdG9jb2wN Cj4gdmlvbGF0aW9uIG9uY2UgYW5kIHJldHVybiAtRUlPIHRvIHRoZSBjYWxsZXIuDQo+IA0K PiBTaWduZWQtb2ZmLWJ5OiBZb3VzZWYgQWxob3VzZWVuIDxhbGhvdXNlZW55b3VzZWZAZ21h aWwuY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t Pg0KDQoNCkp1ZXJnZW4NCg== --------------hdg6x8htzENYRNr5sEtTzpry Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------hdg6x8htzENYRNr5sEtTzpry-- --------------4vUdhZNEHihnn0uY9xxS0MzH-- --------------Rx8KxrJ07uxXf9wNvhXWzk7Z Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpEyN0FAwAAAAAACgkQsN6d1ii/Ey/L yQf9EUlGzOa4UNI7dN7EtJJoZFRzGCnjBW9ROiKQaeVCrktn9vewn7E9al8uCIhPpU5YXylF4LY5 Cdw3UqewfAW7+2j8J0ga8l5krmnL73YfuHnyYgTR9X4AxyLN+eM3eP1CrZN/iKeJrSZGb7w6VXAG QOIXZR1zxClUpaxNZP/qydKwWK4lz76LPGTY+c3H979nXBAsjatdMgnraThuACURBiLipspT3/qU TqgYnFGO5HrmKCvsyWZvQo08qQiACgoc8vYLDf/FTTezxl/nAhZDRWHObpI8LFzkj/d/ifM2h10Q e8u3FPAU7SuK0AzYmc5zRa9u9dZ3RPTdncNCH1Bkrw== =3KWH -----END PGP SIGNATURE----- --------------Rx8KxrJ07uxXf9wNvhXWzk7Z-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 08:33:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 08:33:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349602.1607302 (Exim 4.92) (envelope-from ) id 1weqNx-0003Sz-SP; Wed, 01 Jul 2026 08:33:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349602.1607302; Wed, 01 Jul 2026 08:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weqNx-0003Sr-PG; Wed, 01 Jul 2026 08:33:33 +0000 Received: by outflank-mailman (input) for mailman id 1349602; Wed, 01 Jul 2026 08:33:32 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weqNw-0003Sj-4s for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 08:33:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1weqNu-001xNF-PG for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 10:33:30 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44d0d7-bab6-0a2a0a5309dd-0a2a45068b5c-10 for ; Wed, 01 Jul 2026 10:33:30 +0200 Received: from [209.85.208.53] (helo=mail-ed1-f53.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44d0da-08de-0a2a45060019-d155d035e009-3 for ; Wed, 01 Jul 2026 10:33:30 +0200 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-6974a6e54dbso708106a12.2 for ; Wed, 01 Jul 2026 01:33:30 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6987c21f123sm2359277a12.0.2026.07.01.01.33.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 01:33:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782894810; x=1783499610; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=vjpi9gDuzwwRM7WLjI09X9TThOB1p5PHgz+55yL6rYs=; b=IvHQIHGvkP07FZB3kpQJGPZHrajiwchh5OL+k2cThWD8tgcU1ONetGUnmoa29kGzZf GrGbQTZPUdees6DuL/B2u/fpyw9nUMeXDZEk9Kzdkd3mG7wDFOvzqonBjE9hAnHeUYhf FjdbURtW7nXNJghZwcGqITUzAfERE1yc47+FF7wjI6KZGD9CcGpmTs4y5xuwY22aCPEq Hp8Z0aOjnFPy+itxLLHPRVo5KMpqtujZFfBSRhBwSXpO47SFp1E/FJsN3+0paWlFgaUL TCSADeL/cJIzJOegqAV+kpgbLBo+wAVcLsz8ABtZAq5Eu/EVa5yg8ug5/8PA3mHrAYVa S/rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782894810; x=1783499610; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vjpi9gDuzwwRM7WLjI09X9TThOB1p5PHgz+55yL6rYs=; b=lvz0QZfwHedPlnQARcjx5O96a9aeGOrwV0jiI07SGyxUWNwxr1MWmTBShgdgjXzWe3 VMZxTWNokZGW+CAwGIQnbcduBxzwFO4iJCdbPdondsD40iAPhXoahwoTa2FT6ZmdLLdq flFYrOGLuVqRzbjO1hrcJdX8b1h1sqiWyQnSH/5egTdJiozk7eq79SOHOcD50nmIc6h6 yodAKTg0atllSmKrNlCQASNxShmeJ4TXnEiPhwOHMyeOWr73cLs+/JfDmG9ACkbDfIIh zBrPC94OPWshdKPQyp3GjRKKRGdNLIMADROn9Ifj2yw/UCxyDtBvi6UmSmubQylQhWVE VPpA== X-Forwarded-Encrypted: i=1; AHgh+Rq2YyNE/QU3C+OrXg55AAst2nVNnfXFUH6rt6a2wn4rEvTgwAJe7Y2sBjmb7CXgmOyOVPThF3mm0fw=@lists.xenproject.org X-Gm-Message-State: AOJu0YzHD/4Jz4pIFI+wVyG5gHaJ5j/lrI0R1X+r6LJubcOUpe4UZ6yU q3xcXSRgjfAOhAU2/2XdVjuJMsTeQ8jWiB5W/2SzaLdqkhGJCoG5rtvaRPOEwsTSpfs= X-Gm-Gg: AfdE7clWUCAxahRQq0cpzEl8GzO8UCsgNT2a3moVaIEZ2iG2aBWcC/Mb9ixktFCh3Ei QHyaJh5fvUYueG6ckxGuA7UmQOOc+w0WG3ej8BPuUNunsXptDtiOvUkCKG6M/GWfvR6Eh8ZJfSA qPy3aTq3cazhXDJPUlWq4NJUFDYXgCzmp3Og6LpenaAXYXItTkJkq7PlAjpoZ56EGeXsXAWUqgT +QhaOXkUDKCqmhr0ROVHEVCTh4vVhBPPtnDhauikoPLqfeb4Sv2lq/QXcGvhEGObDu1+mGidwxn TM2NZ/y2d548TmafFXTqGXjrLDF5CYDIn2Dbh87NBdGodEolQqK7fBYT8RvHtShL9w1CaI6AjNg f3wPCeW/LbsCqySdsrh4b3kVP6MEVG7OFIg0xdkgcpA8I0ecUlFbHw8Vx02E+RT3pmpQUgwPgek 7kLa3bS8E2lTzLU5fekNu3+0AM7dAUGtRnD7anY5GlindX14ISSLajzGNlkHjUl3El37pblxHQT nFPqC8ogHdoNEl0IHseYl/PD5764Y47LaTE97ucsM7lYCFzQMwsrw== X-Received: by 2002:a05:6402:4146:b0:698:99be:29d6 with SMTP id 4fb4d7f45d1cf-6989f38e868mr343446a12.29.1782894809526; Wed, 01 Jul 2026 01:33:29 -0700 (PDT) Message-ID: <0c5e4515-b51e-4b19-8389-a76cabc88042@suse.com> Date: Wed, 1 Jul 2026 10:33:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces To: Sean Christopherson , Ingo Molnar Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-edac@vger.kernel.org" , x86@kernel.org, linux-acpi@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, linux-ide@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-crypto@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-hyperv@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , "lukasz.luba@arm.com" , Jason Baron , Borislav Petkov , Tony Luck , Yazen Ghannam , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , "Kirill A. Shutemov" , Rick Edgecombe , Pu Wen , Bjorn Helgaas , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Viresh Kumar , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Tony W Wang-oc , Damien Le Moal , Niklas Cassel , Dave Airlie , Helge Deller , linux-geode@lists.infradead.org, Olivia Mackall , Herbert Xu , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Guenter Roeck , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Josh Poimboeuf , Pawan Gupta , Vitaly Kuznetsov , Andy Lutomirski , Boris Ostrovsky , Huang Rui , Mario Limonciello , Perry Yuan , K Prateek Nayak , "srinivas.pandruvada@linux.intel.com" , Artem Bityutskiy , Artem Bityutskiy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Ashok Raj , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Rajneesh Bhardwaj , David E Box , xen-devel@lists.xenproject.org References: <20260629060526.3638272-1-jgross@suse.com> <7332feff-2649-496c-8e49-b0a19eb54a32@app.fastmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yR0aQa1Dp38FRBSVbM28PBR6" X-purgate-ID: tlsNG-16d1c6/1782894810-C5D3D68D-E7E04925/0/0 X-purgate-type: clean X-purgate-size: 11660 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yR0aQa1Dp38FRBSVbM28PBR6 Content-Type: multipart/mixed; boundary="------------vD8700IqVizDT0GQTpFiBkTP"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Sean Christopherson , Ingo Molnar Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-edac@vger.kernel.org" , x86@kernel.org, linux-acpi@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, linux-ide@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-crypto@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-hyperv@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , "lukasz.luba@arm.com" , Jason Baron , Borislav Petkov , Tony Luck , Yazen Ghannam , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , "Kirill A. Shutemov" , Rick Edgecombe , Pu Wen , Bjorn Helgaas , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Viresh Kumar , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Tony W Wang-oc , Damien Le Moal , Niklas Cassel , Dave Airlie , Helge Deller , linux-geode@lists.infradead.org, Olivia Mackall , Herbert Xu , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Guenter Roeck , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Josh Poimboeuf , Pawan Gupta , Vitaly Kuznetsov , Andy Lutomirski , Boris Ostrovsky , Huang Rui , Mario Limonciello , Perry Yuan , K Prateek Nayak , "srinivas.pandruvada@linux.intel.com" , Artem Bityutskiy , Artem Bityutskiy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Ashok Raj , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Rajneesh Bhardwaj , David E Box , xen-devel@lists.xenproject.org Message-ID: <0c5e4515-b51e-4b19-8389-a76cabc88042@suse.com> Subject: Re: [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces References: <20260629060526.3638272-1-jgross@suse.com> <7332feff-2649-496c-8e49-b0a19eb54a32@app.fastmail.com> In-Reply-To: --------------vD8700IqVizDT0GQTpFiBkTP Content-Type: multipart/mixed; boundary="------------jBK7pBe03sqwPCAFbkx06T5B" --------------jBK7pBe03sqwPCAFbkx06T5B Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMDYuMjYgMjA6NTksIFNlYW4gQ2hyaXN0b3BoZXJzb24gd3JvdGU6DQo+IE9uIE1v biwgSnVuIDI5LCAyMDI2LCBJbmdvIE1vbG5hciB3cm90ZToNCj4+ICogQXJuZCBCZXJnbWFu biA8YXJuZEBhcm5kYi5kZT4gd3JvdGU6DQo+Pg0KPj4+Pj4+IE5vdGUgdGhhdCBtb3N0IHBh dGNoZXMgb2YgdGhpcyBzZXJpZXMgYXJlIGluZGVwZW5kZW50IGZyb20gZWFjaCBvdGhlci4N Cj4+Pj4+PiBPbmx5IHRoZSBwYXRjaGVzIHJlbW92aW5nIGEgc3BlY2lmaWMgaW50ZXJmYWNl IChwYXRjaGVzIDcsIDE1LCAyNiBhbmQNCj4+Pj4+PiAzMCkgYW5kIHRoZSBsYXN0IHR3byBw YXRjaGVzIG9mIHRoZSBzZXJpZXMgZGVwZW5kIG9uIGFsbCBwcmV2aW91cw0KPj4+Pj4+IHBh dGNoZXMuDQo+Pj4+Pg0KPj4+Pj4gSXQgbG9va3MgbGlrZSB5b3UgYXJlIHRvdWNoaW5nIG1v c3QgZmlsZXMgdHdpY2Ugb3IgbW9yZSBoZXJlLCB0bw0KPj4+Pj4gZmlyc3QgY29udmVydCBm cm9tIHJkbXNyIHRvIHJkbXNycSBhbmQgdGhlbiB0byBjaGFuZ2UgdGhlDQo+Pj4+PiB0d28t YXJndW1lbnQgcmRtc3JxKCkgbWFjcm8gdG8gYSBzaW5nbGUtYXJndW1lbnQgaW5saW5lLiBJ ZiB5b3UNCj4+Pj4+IGludHJvZHVjZSB0aGUgaW5saW5lIHZlcnNpb24gb2YgcmRtc3JxKCkg Zmlyc3QsIHlvdSBzaG91bGQgYmUNCj4+Pj4+IGFibGUgdG8gc2tpcCB0aGUgc2Vjb25kIHN0 ZXAgKHBhdGNoIDMxKSBhcyB0aGV5IGNvdWxkIGJlIGFibGUNCj4+Pj4+IHRvIGNvZXhpc3Qu DQo+Pj4+DQo+Pj4+IEkndmUgZGlzY3Vzc2VkIGhvdyB0byBzdHJ1Y3R1cmUgdGhlIHNlcmll cyB3aXRoIEluZ28gTW9sbmFyIGJlZm9yZSBbMV0uIFRoZQ0KPj4+PiBjdXJyZW50IGFwcHJv YWNoIHdhcyBoaXMgcHJlZmVyZW5jZS4NCj4+Pg0KPj4+IE9rLg0KPj4NCj4+IE5vdGUgdGhh dCB0aGUgaW5kaXZpZHVhbCBwYXRjaGVzIGFyZSBJTU8gc2lnbmlmaWNhbnRseSBlYXNpZXIg dG8gcmV2aWV3DQo+PiB0aHJvdWdoIHRoZSBhY3R1YWwgMzItYml0ID0+IDY0LWJpdCB2YXJp YWJsZSBhc3NpZ25tZW50IGNoYW5nZXMgZG9uZQ0KPj4gaW4gaXNvbGF0aW9uICh3aGljaCBz b21ldGltZXMgaW5jbHVkZSBtaW5vciBjbGVhbnVwcyksIHdoaWxlDQo+PiB0aGUgQ29jY2lu ZWxsZSBzZW1hbnRpYyBwYXRjaDoNCj4+DQo+PiAgICAgeyBhKGIsYykgPT4gYyA9IGEoYikg fQ0KPj4NCj4+IHdoaWNoIGNoYW5nZXMgYm90aCB0aGUgZnVuY3Rpb24gc2lnbmF0dXJlIGFu ZCB0aGUgb3JkZXIgb2YgdGVybXMgYXMNCj4+IHdlbGwsIGlzIGp1c3QgYSBzaW5nbGUgYWRk LW9uIHRyZWV3aWRlIHBhdGNoLg0KPiANCj4gSXMgdGhlIHBsYW4gZm9yIHN1YnN5c3RlbSBt YWludGFpbmVycyB0byBwaWNrIHVwIHRoZSByZWxldmFudCBwYXRjaGVzLCBhbmQgdGhlbg0K PiBkbyB0aGUgdHJlZXdpZGUgY2hhbmdlIG9uZSByZWxlYXNlIGN5Y2xlIGxhdGVyPw0KDQpZ ZXMsIHBsZWFzZS4NCg0KDQpKdWVyZ2VuDQo= --------------jBK7pBe03sqwPCAFbkx06T5B Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------jBK7pBe03sqwPCAFbkx06T5B-- --------------vD8700IqVizDT0GQTpFiBkTP-- --------------yR0aQa1Dp38FRBSVbM28PBR6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpE0NcFAwAAAAAACgkQsN6d1ii/Ey+4 VQf5ARTTFZkvO/RB1pgLA5pxpW3UUS3uxxV7SopNU0hZc/AzNq9az9lJfyH7jPZ8QBmU9IKulebG ITlyXQQs6UjK+gdS9lqvVR/gt7jXQo56BFaXUZQwHSt8ln7k9LhUmdEaBj2m305DZnpb9SGilWTg FU/0xAyiM++MkxazBUebIsHavKxiZg3dIjZQ6L7GCivFopHxm59Fg0dv+E0OzaQGPmtrz/oR7sNP AkYiOzz84cF2fQXnHTlKAU02RMhfJ2YDp/KAdwPaf1hFwAZsNFL3usH2Ku34Q0ARJoRpUockNhfc G3t+JspAVbLH9NBe6jFF+6eWh86FKPsmtwZt0e9tvQ== =ng7t -----END PGP SIGNATURE----- --------------yR0aQa1Dp38FRBSVbM28PBR6-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 09:09:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 09:09:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349625.1607310 (Exim 4.92) (envelope-from ) id 1weqwY-0001AO-HQ; Wed, 01 Jul 2026 09:09:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349625.1607310; Wed, 01 Jul 2026 09:09:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weqwY-0001AH-E9; Wed, 01 Jul 2026 09:09:18 +0000 Received: by outflank-mailman (input) for mailman id 1349625; Wed, 01 Jul 2026 09:09:17 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weqwW-0001A9-CP for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:09:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1weqwV-003ivO-2a for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:09:15 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44d931-bab6-0a2a0a5309dd-0a2a4508d926-38 for ; Wed, 01 Jul 2026 11:09:14 +0200 Received: from [52.101.229.79] (helo=TY3P286CU002.outbound.protection.outlook.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44d938-edec-0a2a45080019-3465e54fd3b1-3 for ; Wed, 01 Jul 2026 11:09:14 +0200 Received: from TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:30e::6) by OS7P286MB5474.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:398::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 1 Jul 2026 09:09:09 +0000 Received: from TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM ([fe80::a377:45d3:a376:f515]) by TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM ([fe80::a377:45d3:a376:f515%3]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 09:09:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-Id:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AChEHSED0qwvNe9Hj5P+9lF8hpcZu/yUI3CSKFi2dtXLxd8Zt8Z6eWL1CU618cpmmi1ujra5+Fvt1waJMxJ4u60KChhmyGwEwudHT+If5Y9vWAC291nvYXVWcxZL7BPosTF8VB+vyN1/eKukyhK0reRKOuv3FNhJ5NoWLhKpVXkpJCvmx1Uxwehi8Y615M6/BAArXZJGNtKLYBdEhSmPEDJRxgNa0K3prmfaVKjIks1WA9qsKD5Dhj+/T18Mc3y2Fb5kdLYkSKon5ylLUvjdWyAP+zZWHE1Ib2XjS3+ucNH2YGbcRJOCOEn7hPA5cRzh/9C0RIxSJXgXEKESO6IS9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7eThDqmoZ82RG4QueS3fK1meunY7Ib+jRa572ZdCK0=; b=r0xsZ58OaK/5AhjOzEQhMnjiqJ28tNMxXIqHNTQuAdhBLJI4s9zwRz+QXouU/ttvGcAo/9Xs7sHWHNUqlVX2XlceeNn4R7O8W8YwpSTax5j+imzzTbrs7tjwcq9s7BBIdeFAx5IcgL5hd4V3hZf5ljPG/aMFW+T+OWvXoBzWGwUhl8hh2mdqVsolCSudZRtNScl6p2Da6JECv7ng+NEKfOfrC4vcszEvHGvvVEr0WDUEVTkVrLndiPDc6Bw1NXElAiW94k0Cb71jfeNcjcYV9LJ1A5f31f7d7tw8aJtr4LDPMP5qlaSa9FCvCLzIl6DqeeE9xSqp93DLs6/FSEyQBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X7eThDqmoZ82RG4QueS3fK1meunY7Ib+jRa572ZdCK0=; b=O5w3a4NYfn+tyvpyMoZMh7x2GvDi5ckpEHKFBHEzPk8QEAHyvbYYOUUMC5hojvJspokMEUUvBcYJn5rRlrGhRVSNBXzXUO4gQTYnXU2jLLbKTqfGBswAo77+4TvfW0xNmLyFZ34i5wffFCWzKd9OjiVhZPixJ5gzZNNyLNvuxWw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Ryo Takakura To: andrew.cooper3@citrix.com, roger.pau@citrix.com Cc: xen-devel@lists.xenproject.org, ross.lagerwall@citrix.com, sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, anthony.perard@vates.tech, jbeulich@suse.com, taka@valinux.co.jp, den@valinux.co.jp Subject: Re: [RFC] xen/arm64: livepatch: enable attaching callbacks Date: Wed, 1 Jul 2026 18:09:08 +0900 Message-Id: <20260701090908.15204-1-takakura@valinux.co.jp> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: TY4P301CA0054.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36b::14) To TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:30e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYYP286MB2946:EE_|OS7P286MB5474:EE_ X-MS-Office365-Filtering-Correlation-Id: c7fd92e2-50fa-4545-6768-08ded750691a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|23010399003|3023799007|6133799003|56012099006|5023799004|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 3Ysr9j7mrAyrlgR9WlWqu3qCx8k+/hhD1TJJdPAI5lt+CqW7NDJeL1aCcXN8kP9h0DdyC4NuLZiGmeu8C0FeMKGHlnvGnfuQa7fhzNGs5p28JXUXBAaNwkHQByoxJDtlu3QnDt/4jJ2Wf7sRoQoErrnEercVP2KxzdIVrYFz9Pn6f8wtJhkwYpb0N/bMmg2qXfUxOS6iX9/69+2tyTTB3WjX0hEpnaM8bCb13qUiSlkLfgOTPkODVqr5JVPya+w2OmlXus4gvZ7gpI8CJKWhBdN8js7xMrj+c8e5e3JbBRR6a9J0NqnvLm4DB5kuWx9kfua2q4qz7Q9URyE+mXzIEQd1KmWdmXzgPPdmWH+Jywc3JAG/FSxVL03Vhep0cF4D/TCi4HkTahNJTEVOrhyyM47uyNlBPAuPOBz7a3jvyhSbexesKrwMNxkmyIbRnyo135e49RHBqKLrIBc41Q8NDz/dBZ4Ik+I88F4aTyRxMb2FZ64W26NZB7lgZD0UR3ALKguWpi4YdWKITMjCIYFmZBuhvVvVaWyvX7Ge8QLqVsyaBabVv9yB52+B9zGVV6MgEXxmwlNnDMi7I4Pp858MGlNIzzgqEEpZNRLE9Dfc401sXpq/fz20i67JdjHd9Dhk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(23010399003)(3023799007)(6133799003)(56012099006)(5023799004)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2lUaUJ4K2tFSDh4MTQ0UkR2Q2NaRVByMlp6T2dMTmdlM2FZRTZkU0xLdS9z?= =?utf-8?B?TWRqTmJNVnJUUXV1MWdpQ2xTa1pYdW9ZMTRHRHpsaUQ0bUwxdkxKS09nUy9x?= =?utf-8?B?QUtidzF3WmhOQzhLbDRadFJFRHpGeVZYQWoreXBxSmxzSHgrSTRXUjBYUHE0?= =?utf-8?B?R3VycUZtY2VjdCtjLzlnM1lDdjREV2FLVG1BaExEalI3Zk5uRmh5emxFWHAy?= =?utf-8?B?aWlVQnVOeWxRZ0g4Y09IQ09oOGYxdUMyV25oa0JTL0liY2lXaThkZnp5enhG?= =?utf-8?B?U0hhTFg1V21KNGRsQkVQeDdDS0NrSUFZN2FENDF5eFRmcURYaEJ0eS9ITzg5?= =?utf-8?B?WWtCN3ZoWm9TSUs4NFBzOVVPMndINWUvNjI1MGhtS0RSV01hb0ZaUDVHcVRT?= =?utf-8?B?K0xEb2Fzb0tPTmM3SkpHR3pjRUNpSFQxdytsb2NXck8zQ05JRWFrbkRqQ2xx?= =?utf-8?B?Y3VQS20zWU1pL0RlSVNISmltYWJxaktQMHg4Z1JLanFZTVJPZFdXUFZUOExY?= =?utf-8?B?YWlwYXdPYm00K1RKTjBiTTRTM3g4TWs5eEV5ZlUwQS94anVzdFkxMXFucmwx?= =?utf-8?B?aDhjU1Blc1ExcElNVk9WeE8yTjgzTjV5WC9sdFJ2SnFNRjVuTmxLaHNTcE1k?= =?utf-8?B?dW52dlZicnhFTlU1WjBVdVNML0Z6NHZTM3BIVlVjaDhkQWNmVjREUXFFV08x?= =?utf-8?B?RDBNNW1QSWhoU3QrUk12b0NKTkpmUEVpVWxBejNNZVhyUmxMNXVzWW8vb1Rz?= =?utf-8?B?SWNESVhnT1krckp4ejgwMGQ5czlVeVNDN3pNd2czQVNtTWdDNDJyd3lCSkNP?= =?utf-8?B?UElXYytkc244Y2dZU2czR2VzaytlLzRoQU9vL0pWU3Z0ZGRTTXdoR0NURGdK?= =?utf-8?B?b1BmVm4vOXZIOU1HN3ltQ1hHNmNFdzd3VW1mci9aNzVjdTNsKytTQVVPSnMr?= =?utf-8?B?QU55ZXhycExpbkM5TjZZWWtVbkEwSnpiUmN4ZXFHc1J2bzVKQVNrelhob1ZD?= =?utf-8?B?Zmg0UmlpOCtjRnRQcG0xYlYvUGtHWHRJb2tHQzViU213czlWdE55L1dLVFZS?= =?utf-8?B?b3dkb1dDZnlVK1p3dkpyTXlyUXNKZTNvZkxnNFhrYVh3V3VGcG1vNkJDbFNE?= =?utf-8?B?K01JT3B1NmlDM2IzWnlNM2c1SXFsRVkxWUJ3SGtZRzVGUXM3d0JrYTUxenJ1?= =?utf-8?B?VDhpL3lOUS9GcU5yTDRLN3Y1ekFxTWlRTkFlZUQ2ZEtUWVRMSzFXaVNFcE1L?= =?utf-8?B?K1dHTzQvWTJOc3VWVit6a0c5Qy8vOXNuV0dlc1MrbnNaN0dySzlKT0NISjMz?= =?utf-8?B?RGFoZlFNTE5ocDFkYm9KSjlvRXJRVEJWSmF2cXRqNHdLdmxqUW1Gd2tZUmpR?= =?utf-8?B?UFl4Tk94bTdSaUQ3amhQQkVxOVo3NDY4WEJ0UlkyTllHMndEcXFLZzdEMjhL?= =?utf-8?B?Q01oMWorU2tlMWdYNDdCMklCUHNTTURqNExPRjZyYzhaQmZlV1dkZkozbUJT?= =?utf-8?B?L3pHK2hqWU5sb2hNaWxxZkxJQ3RoNWUza1JHTFFYS3RldFNaSFFzcElJdEVa?= =?utf-8?B?cHc3a0dhUXE0RERGV2NyTWJVS0ZmVE5OUzNFdFQ4eUdYMUtYaCtoUGxseXdu?= =?utf-8?B?NGo2MER5a1AxbWhlQ012M1BxUXNyTG16VlNpTlIySFY4V2NPRXJleTVpc09x?= =?utf-8?B?NUI0WEpyZlpKNTc0ek1PUEdFNnZYSGhEQlQwcTRiaDd1UWFjWFdld1A2cGxS?= =?utf-8?B?dTNwQVI1TUdDbXhKdG13K1V5Q0RWSWt2WCtoM0ZNa3BuS1dURmxVeHVObVli?= =?utf-8?B?czc2TFM3VGRTMWYyTnBXZlkrMjhtOHh5dmRIM2FTakRxNVhEOCs0VTg4Mytt?= =?utf-8?B?L3IvZUxFMGVwWG9CVTNOVjRja3FRTTZuWVdDOWU2dlROWTBGM0huV29BSUw3?= =?utf-8?B?RXBxV3lCOTc4RytTeDJSZVVtM0k5VXo5cG1neVVBR3RBcnFEQlpUSnpKdTk2?= =?utf-8?B?Q01nWExPYW5WMTdWdXpZRmN2VE9OUExtVW9yZnFUM09kV3pjVWFLaEtHUlNi?= =?utf-8?B?OURlWU1STitVd2grNWNiSUxMc0F0RWttYmhSOXFWaWUvdnFLUEpXQkhqS2Fm?= =?utf-8?B?UG9ZYXo0NnIydi9QOEYrbzh4ODRFWXEzYVlNQTFMWGd5TmZjK0NPblZ5NjNo?= =?utf-8?B?QkRUMEx2ckxuU01ZYnZ0MFJIZDZ1dk1NL2RWV0k1Q3RwNVI0NVcvWDFZUzZH?= =?utf-8?B?dlFEQVpQYkZHdmFRNmszTSt6cTBZcUxUcm9TcGx6Z3RmQlBpWWNoR1RDN3pu?= =?utf-8?B?Tk1DNW4zT2J4NTl5Wmo1a2JOeVpMMDExaTBSNUhNNHZBdDNMQTg3QT09?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: c7fd92e2-50fa-4545-6768-08ded750691a X-MS-Exchange-CrossTenant-AuthSource: TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 09:09:09.6301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FsD0O3LqTjpoWzQU5k3dypzcbuaruT+RG6RgMzo0hLyN0qOiTxRRsiTl8OW6fX/rTeIDxOqb+55cl8FrDc7DbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS7P286MB5474 X-purgate-ID: tlsNG-c1860d/1782896954-A39353FC-B4FD0D71/0/0 X-purgate-type: clean X-purgate-size: 16799 Hi Roger and Andrew, On Tue, 30 Jun 2026 08:47:14 +0000, Roger Pau Monné wrote: >On Mon, Jun 29, 2026 at 11:01:28AM +0900, Ryo Takakura wrote: >> Linux ftrace allows registering callbacks which is useful >> for debugging and tracing events. On Linux, it is done by >> reserving function entry points at compile time which can >> later be patched to branch to a trampoline. >> >> This patch implements similar callback feature, but with >> different approach using existing livepatch infrastructure. >> Instead of reserving function entry points at compile time, >> the traced function will be livepatched so that it branches >> to the trampoline. > >While this is an interesting usage of the livepatch logic in new ways, >may I ask why not do as Linux and add an empty function preamble that >can be replaced at run-time with calls to hooks? > >You could still re-use most of the livepatch logic for handling the >addition of the hook calls, but it would be nicer in that we won't >need to move the original function. I agree that we can reuse a lot of livepatch logic. >> The role of the trampoline(illustrated below) is to preserve >> the context while jumping to the tracer function, and return >> back to the traced function with its context restored. > >Alternatively - why not use livepatch-build-tools against a build with >the added hooks to generate a proper livepatch? This looks a bit >fragile to me (see the question from Andrew about fixing up >instruction pointer relative references). Yes, I think proper livepatching would still be preferred given all the concerns Andrew and Roger raised. >On x86 at least we would also need to adjust the bug frames and >exception table contents, and the contents of the symbol table to >account for the function being moved. > >IOW: it looks like overall this is a lot more work than possibly >reserving a function preamble to add hook calls? Yes, I agree. (I wasn't aware of this additional work when I replied to Andrew yesterday, thanks!) And if I were to summarize the discussion so far, assuming we still want to add a tracing-feature, I think we are in agreement adding an empty function preamble like Linux. (I personally would still like to see a framework on Xen that is more convenient and tracing-friendly which can be used reliably at the same time) If this sounds reasonable, I will try preparing one based on the feedbacks I was given so far: - Use of Linux-like reserved function preamble - Use of __attribute__((no_caller_saved_registers)) - Split replacement and preamble-hook handling in common code Let me know your thoughts! >> trampoline: >> Save regs >> Call tracer function >> Restore regs >> old_addr >> return old_addr + 4 >> >> One can request the feature by setting @trampoline_buf to 1 >> which will allocate a buffer for trampoline. >> >> Signed-off-by: Ryo Takakura >> --- >> >> Hi! >> >> For the future, I'm thinking of linux-like extensions >> which help tracing and debugging by passing: >> - saved registers >> - caller information >> - private data >> - and so on ... >> >> I would appreciate any advice or suggestion. >> Thanks! >> >> Example payload file: >> >> #include >> #include >> >> static void my_tracer(void) >> { >> printk("livepatch: do_domctl was called\n"); >> } >> >> static struct livepatch_func funcs[] >> __attribute__((section(".livepatch.funcs"))) = >> { >> { >> .name = "do_domctl", >> .old_size = 4572, >> .new_addr = my_tracer, >> .new_size = 32, >> .trampoline_buf = (void *)1, >> .version = LIVEPATCH_PAYLOAD_VERSION, >> } >> }; >> >> Sample output: >> >> $ tools/misc/xen-livepatch list >> ID | status | metadata >> ----------------------------------------+------------+--------------- >> trace_do_domctl | APPLIED | >> $ xl vcpu-list Domain-0 >> Name ID VCPU CPU State Time(s) Affinity >> (Hard / Soft) >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> (XEN) livepatch: do_domctl was called >> Domain-0 0 0 1 -b- 67.7 all / all >> Domain-0 0 1 3 -b- 457.2 all / all >> Domain-0 0 2 2 -b- 42.4 all / all >> Domain-0 0 3 0 r-- 32.4 all / all >> >> Sincerely, >> Ryo Takakura >> >> --- >> xen/arch/arm/arm64/livepatch.c | 104 +++++++++++++++++++++++++++- >> xen/common/livepatch.c | 40 +++++++++-- >> xen/include/public/sysctl.h | 3 +- >> xen/include/xen/livepatch.h | 13 +++- >> xen/include/xen/livepatch_payload.h | 2 + >> 5 files changed, 150 insertions(+), 12 deletions(-) >> >> diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c >> index e135bd5bf9..b7c9aba94e 100644 >> --- a/xen/arch/arm/arm64/livepatch.c >> +++ b/xen/arch/arm/arm64/livepatch.c >> @@ -15,6 +15,29 @@ >> #include >> #include >> >> + >> +#define AARCH64_REG_SP 31 >> + >> +static uint32_t aarch64_insn_gen_stp_pre(unsigned int rt, >> + unsigned int rt2) >> +{ >> + return 0xa9800000 | >> + (((-16 / 8) & 0x7f) << 15) | >> + (rt2 << 10) | >> + (AARCH64_REG_SP << 5) | >> + rt; >> +} >> + >> +static uint32_t aarch64_insn_gen_ldp_post(unsigned int rt, >> + unsigned int rt2) >> +{ >> + return 0xa8c00000 | >> + (((16 / 8) & 0x7f) << 15) | >> + (rt2 << 10) | >> + (AARCH64_REG_SP << 5) | >> + rt; >> +} >> + >> void arch_livepatch_apply(const struct livepatch_func *func, >> struct livepatch_fstate *state) >> { >> @@ -34,12 +57,87 @@ void arch_livepatch_apply(const struct livepatch_func >> *func, >> /* Save old ones. */ >> memcpy(state->insn_buffer, func->old_addr, len); >> >> - if ( func->new_addr ) >> + if ( !func->new_addr ) >> + { >> + insn = aarch64_insn_gen_nop(); >> + } >> + else if ( func->trampoline_buf ) >> + { >> + int rc; >> + uint32_t *trampoline = func->trampoline_buf; >> + uint32_t *tp = trampoline; >> + void *orig_cont_addr = (void *)func->old_addr + len; >> + unsigned int trampoline_code_size = len + 12 * ARCH_PATCH_INSN_SIZE; >> + unsigned long trampoline_start = (unsigned long)trampoline & >> PAGE_MASK; >> + unsigned long trampoline_end = >> + PAGE_ALIGN((unsigned long)trampoline + trampoline_code_size); >> + >> + /* >> + * Make the payload text area writeable while generating >> + * the trampoline instructions. >> + */ >> + rc = modify_xen_mappings(trampoline_start, trampoline_end, >> + PAGE_HYPERVISOR); >> + if ( rc ) >> + { >> + printk(XENLOG_ERR LIVEPATCH >> + "Failed to make trampoline writable: %d\n", rc); >> + return; >> + } >> + >> + /* Save state before calling the tracer. */ >> + *tp++ = aarch64_insn_gen_stp_pre(0, 1); >> + *tp++ = aarch64_insn_gen_stp_pre(2, 3); >> + *tp++ = aarch64_insn_gen_stp_pre(4, 5); >> + *tp++ = aarch64_insn_gen_stp_pre(6, 7); >> + *tp++ = aarch64_insn_gen_stp_pre(29, 30); >> + >> + /* Call user's tracing function. */ >> + insn = aarch64_insn_gen_branch_imm( >> + (unsigned long)tp, >> + (unsigned long)func->new_addr, >> + AARCH64_INSN_BRANCH_LINK); >> + *tp++ = insn; >> + >> + /* Restore state before continuing original function. */ >> + *tp++ = aarch64_insn_gen_ldp_post(29, 30); >> + *tp++ = aarch64_insn_gen_ldp_post(6, 7); >> + *tp++ = aarch64_insn_gen_ldp_post(4, 5); >> + *tp++ = aarch64_insn_gen_ldp_post(2, 3); >> + *tp++ = aarch64_insn_gen_ldp_post(0, 1); >> + >> + /* Original instruction. */ >> + memcpy(tp, state->insn_buffer, len); >> + tp += len / ARCH_PATCH_INSN_SIZE; >> + >> + /* Branch back to original function. */ >> + insn = aarch64_insn_gen_branch_imm( >> + (unsigned long)tp, >> + (unsigned long)orig_cont_addr, >> + AARCH64_INSN_BRANCH_NOLINK); >> + *tp++ = insn; >> + >> + clean_and_invalidate_dcache_va_range(trampoline, >> trampoline_code_size); >> + >> + rc = modify_xen_mappings(trampoline_start, trampoline_end, >> + PAGE_HYPERVISOR_RX); >> + if ( rc ) >> + { >> + printk(XENLOG_ERR LIVEPATCH >> + "Failed to restore trampoline RX mapping: %d\n", rc); >> + return; >> + } >> + >> + /* Branch from original function to trampoline. */ >> + insn = aarch64_insn_gen_branch_imm( >> + (unsigned long)func->old_addr, >> + (unsigned long)func->trampoline_buf, >> + AARCH64_INSN_BRANCH_NOLINK); >> + } >> + else if ( func->new_addr ) >> insn = aarch64_insn_gen_branch_imm((unsigned long)func->old_addr, >> (unsigned long)func->new_addr, >> AARCH64_INSN_BRANCH_NOLINK); >> - else >> - insn = aarch64_insn_gen_nop(); > >If we want to go this route, and use livepatching for this purpose, we >need to branch the use-cases in common code, and have arches provide >both a replacement and a preface addition hooks IMO. I think that is a good idea. I'll take this into account for the next. >> >> /* Verified in livepatch_verify_distance. */ >> ASSERT(insn != AARCH64_BREAK_FAULT); >> diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c >> index 7515a040ad..8863ad5ca3 100644 >> --- a/xen/common/livepatch.c >> +++ b/xen/common/livepatch.c >> @@ -280,10 +280,30 @@ static int move_payload(struct payload *payload, struct >> livepatch_elf *elf) >> { >> void *text_buf, *ro_buf, *rw_buf; >> unsigned int i, rw_buf_sec, rw_buf_cnt = 0; >> - size_t size = 0; >> + const struct livepatch_elf_sec *sec; >> + const struct livepatch_func *funcs; >> + unsigned int nfuncs, trampolines_needed = 0; >> + size_t size = 0, trampoline_size = 0; >> unsigned int *offset; >> int rc = 0; >> >> + sec = livepatch_elf_sec_by_name(elf, ELF_LIVEPATCH_FUNC); >> + if ( sec ) >> + { >> + funcs = sec->addr; >> + nfuncs = sec->sec->sh_size / sizeof(*funcs); >> + >> + for ( i = 0; i < nfuncs; ++i ) >> + if ( funcs[i].trampoline_buf == (void *)1 ) >> + trampolines_needed++; >> + >> + if ( trampolines_needed ) >> + { >> + payload->n_trampolines = trampolines_needed; >> + trampoline_size = trampolines_needed * LIVEPATCH_TRAMPOLINE_SIZE; >> + } >> + } >> + >> offset = xmalloc_array(unsigned int, elf->hdr->e_shnum); >> if ( !offset ) >> return -ENOMEM; >> @@ -323,8 +343,8 @@ static int move_payload(struct payload *payload, struct >> livepatch_elf *elf) >> * them on separate pages. The last one will by default fall on its >> * own page. >> */ >> - size = PAGE_ALIGN(payload->text_size) + PAGE_ALIGN(payload->rw_size) + >> - payload->ro_size; >> + size = PAGE_ALIGN(payload->text_size + trampoline_size) + >> + PAGE_ALIGN(payload->rw_size) + payload->ro_size; >> >> size = PFN_UP(size); /* Nr of pages. */ >> text_buf = vmalloc_xen(size * PAGE_SIZE); >> @@ -335,9 +355,12 @@ static int move_payload(struct payload *payload, struct >> livepatch_elf *elf) >> rc = -ENOMEM; >> goto out; >> } >> - rw_buf = text_buf + PAGE_ALIGN(payload->text_size); >> + rw_buf = text_buf + PAGE_ALIGN(payload->text_size + trampoline_size); >> ro_buf = rw_buf + PAGE_ALIGN(payload->rw_size); >> >> + if ( trampoline_size ) >> + payload->trampoline_addr = text_buf + payload->text_size; >> + >> payload->pages = size; >> payload->text_addr = text_buf; >> payload->rw_addr = rw_buf; >> @@ -690,7 +713,7 @@ static int prepare_payload(struct payload *payload, >> { >> const struct livepatch_elf_sec *sec; >> const struct payload *data; >> - unsigned int i; >> + unsigned int i, trampoline_idx = 0; >> struct livepatch_func *funcs; >> struct livepatch_func *f; >> struct virtual_region *region; >> @@ -737,6 +760,13 @@ static int prepare_payload(struct payload *payload, >> if ( rc ) >> return rc; >> >> + if ( f->trampoline_buf == (void *)1 ) >> + { >> + f->trampoline_buf = (char *)payload->trampoline_addr + > >You don't need to cast to char *, the type of trampoline_addr is void >*, and we use the GNU extension to allow void pointer arithmetic by >treating the size of a void or of a function as 1. Oh, thanks for the advice! I'll keep it in mind. >> + trampoline_idx * >> LIVEPATCH_TRAMPOLINE_SIZE; >> + trampoline_idx++; >> + } >> + >> rc = livepatch_verify_distance(f); >> if ( rc ) >> return rc; >> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h >> index c7cd9b4eb0..e79615d7c9 100644 >> --- a/xen/include/public/sysctl.h >> +++ b/xen/include/public/sysctl.h >> @@ -1010,10 +1010,11 @@ struct livepatch_func { >> const char *name; /* Name of function to be patched. */ >> void *new_addr; >> void *old_addr; >> + void *trampoline_buf; /* Trampoline buffer when set to (void *)1. */ >> uint32_t new_size; >> uint32_t old_size; >> uint8_t version; /* MUST be LIVEPATCH_PAYLOAD_VERSION. */ >> - uint8_t _pad[39]; >> + uint8_t _pad[31]; > >New fields should be preferably added at the tail of the structure, >and the change here needs to be propagated into livepatch-build-tools >livepatch_patch_func structure. See: > >https://xenbits.xen.org/gitweb/?p=livepatch-build-tools.git;a=blob;f=common.h;h=7f3a82ffdb29d2d1d117c1ccb20cc328bdb0529a;hb=HEAD#l135 > >This is sadly all very fragile. Thanks. I will make sure to update livepatch-build-tools if needed. (But I believe the change here won't be needed as pointed by Andrew [1]) >> livepatch_expectation_t expect; >> }; >> typedef struct livepatch_func livepatch_func_t; >> diff --git a/xen/include/xen/livepatch.h b/xen/include/xen/livepatch.h >> index 45c8924f34..7a81763cf2 100644 >> --- a/xen/include/xen/livepatch.h >> +++ b/xen/include/xen/livepatch.h >> @@ -48,6 +48,8 @@ struct xen_sysctl_livepatch_op; >> #define ELF_LIVEPATCH_POSTREVERT_HOOK ".livepatch.hooks.postrevert" >> /* Arbitrary limit for payload size and .bss section size. */ >> #define LIVEPATCH_MAX_SIZE MB(2) >> +/* Size of a trampoline used for function tracing */ >> +#define LIVEPATCH_TRAMPOLINE_SIZE 128 >> >> struct livepatch_symbol { >> const char *name; >> @@ -109,13 +111,18 @@ unsigned int livepatch_insn_len(const struct >> livepatch_func *func, >> >> static inline int livepatch_verify_distance(const struct livepatch_func >> *func) >> { >> + const void *target; >> long offset; >> long range = ARCH_LIVEPATCH_RANGE; >> >> - if ( !func->new_addr ) /* Ignore NOPs. */ >> - return 0; >> + if ( func->trampoline_buf ) >> + target = func->trampoline_buf; >> + else if ( func->new_addr ) >> + target = func->new_addr; >> + else >> + return 0; /* Ignore NOPs. */ > >FWIW, indentation is wrong here, you are adding hard tabs. My mistake. I'll fix this. Sincerely, Ryo Takakura [1] https://lists.xen.org/archives/html/xen-devel/2026-06/msg01583.html >Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Jul 01 09:11:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 09:11:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349634.1607319 (Exim 4.92) (envelope-from ) id 1weqyg-0002fe-W1; Wed, 01 Jul 2026 09:11:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349634.1607319; Wed, 01 Jul 2026 09:11:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weqyg-0002fX-TH; Wed, 01 Jul 2026 09:11:30 +0000 Received: by outflank-mailman (input) for mailman id 1349634; Wed, 01 Jul 2026 09:11:29 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weqyf-0002fR-Kb for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:11:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1weqyf-0021Y8-1E for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:11:29 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44d9bd-e002-0a2a0a5209dd-0a2a4504d59e-18 for ; Wed, 01 Jul 2026 11:11:28 +0200 Received: from [52.101.125.81] (helo=TYVP286CU001.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44d9be-a01d-0a2a45040019-34657d51ff28-3 for ; Wed, 01 Jul 2026 11:11:28 +0200 Received: from TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:30e::6) by OS7P286MB5474.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:398::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 1 Jul 2026 09:11:24 +0000 Received: from TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM ([fe80::a377:45d3:a376:f515]) by TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM ([fe80::a377:45d3:a376:f515%3]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 09:11:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-Id:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CT41lXqD5OHiVwGeebk41nIfKTrw3JOzr0a5uPthT5RTrIflG6rH1oF4P846KWM0iRhkGUoXLqKy0/5495GQfdD9vJR15XG9KZAbx5rQJJJmhhbA1l/OXFQa3IfR/0UWKaPPebFcSEMQLgUQHAIEdn1z14xlJvmiixRIq6+E5l4vgpFzxgUcEpNGWKImJyrg24rfYJdONiEaeP1vqXtQR5ruY1z5JScRWoClNo1kmj74aVvx3dVzIdUyl8o/xAtb7wjIJTP5SfJcYwqjbqLDPCmerF/2bb1562pkt7PBH1l5vcPVohOvZtzKDzIGBDig1uOuMyPFYlqOi9ZjEsMk/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lw8adwinFUP4ZxnfUnxkGTnsKQin0zV3wPPajUUvSSg=; b=raONHWeUjfgxZ62CoEVSV7DmipmNjMtvoRxoCU+oCaFyWY0yRgPuq6QsNGgmJz7mvfxVOefSi5lDn8IiyBs3Nx8vGCxpFVBMqmlbhjq8aqn2dV8y/fPFwZFk1FCColZSiNaISYAPtWhevSO2R9E3ukiXW7rrwd5xepSeHt9qmsw1hkFEwWem3G4R7EOXOTSXBKIdCJOVeHsWV8Zwvtla2fXtNxvBak2qTuefF1ImSxOdp5es8d4RrTM471znX8xB9g8lRG1+xMBPOie01QTwbkJhTtqzBS0aPmL77KdFqdjFc5TjaNrDsztUMIujjd39Q930vmBh+drNBB8atimu5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lw8adwinFUP4ZxnfUnxkGTnsKQin0zV3wPPajUUvSSg=; b=Khh4FD0pTO2LxHuhADw7S/gcYIbdTKtOnaXujBk/zk1VUbvkybEw3VjHnMscplqMsXZVvUGt/8L1WS47m17wNGD7R8GBQm9gUW/IIYNm20ynnf3VnNwzCs0lp5fBXTIlUov3udPbgAzAfBcxt63UX+3rU6OBWBhOgSTHPo4xNpE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Ryo Takakura To: andrew.cooper3@citrix.com Cc: roger.pau@citrix.com, xen-devel@lists.xenproject.org, ross.lagerwall@citrix.com, sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, anthony.perard@vates.tech, jbeulich@suse.com, taka@valinux.co.jp, den@valinux.co.jp Subject: Re: [RFC] xen/arm64: livepatch: enable attaching callbacks Date: Wed, 1 Jul 2026 18:11:23 +0900 Message-Id: <20260701091123.15791-1-takakura@valinux.co.jp> X-Mailer: git-send-email 2.34.1 In-Reply-To: <64e7c58b-a12e-4b29-9d5a-f8a66e77a221@citrix.com> References: <64e7c58b-a12e-4b29-9d5a-f8a66e77a221@citrix.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TY6P286CA0002.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:3b8::16) To TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:30e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYYP286MB2946:EE_|OS7P286MB5474:EE_ X-MS-Office365-Filtering-Correlation-Id: 014a5c0d-1d51-492c-9b5e-08ded750b9c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|23010399003|3023799007|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: fwlkoyjdso/p/q+Y3N7GHGj1uOD2MJ2KAg+cYdE/t7+af/FSgMtHhOyMgEf5fwdlJT7q1OqhI/r28t6ywZgmmqyJV9BenyIFTIp0CDyiTecU2SnOwWQIZY+AG1Mh5RthksgLtWC5KfzbKrgdU5BTkIdCUqYWB+UheSmdKBA7xW4PJiFiDh3nyDIPK2h497r0tcNSbec6/TzOW7T1g15GoVN5grwuJbDvBeZO5TM+tALwk3QN9pX1u0zf100Cd4ShJGg9z5Lui7/LVRLi3E/Pb0eq7inmc9gEm2GiCKa7NLWg93RomuYDkwQ2UpT8a0Js43J0YQareZzR+MAu3BpM+c79qpPXbulMLC+Y5Psq1zCIutTPQuMxQJOI4VbRnI8KUpRWOG+uB0dGypWYyQFpc8rZF1/9+Ik0AX2XtgvZPkrbccVXtaqiNrE4+GxG8l9ePFeTBemr6IJWQGecyicT9GditOZYPYbjwu6yRqMX7g93XTgguEuQxchszBzxRNknw6yt38dkuEwtbxEbwTavnuygFee9Zq9bTNvy26fXr+0MkpM9O1RGkrsoqmaskSVi+x3ynSWDTTxJBQkxOUzRsu7p3pTdDNuLp0uWw2uFyn9oiGWXHmtPcuW4w58JG8BJKnfGk9ZsZt0vHLYh/RYclkF5MExgLfkxnOVLGkdX10c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(23010399003)(3023799007)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z1TY7+bWc0+xeQ0b36x7rge716RE0+Y+zdBedr9mN+T+H5HZlIDmuFGb+XFg?= =?us-ascii?Q?lXqeiYuO9ohjU6qwLlWbdYmHZiUxWKeVv4xOry1b7K8ZLdlxViYVNKF5ab8l?= =?us-ascii?Q?dpmyW641KlF5zmowQn0kTejK+FLBGnrqON9laPz6qtTfjQPpxrw0uQavWWrv?= =?us-ascii?Q?bp33EkFe6o4wDOOJhHhG6exjf/Prr8JdZrHXKkGCEPGQsRrAvlS69fPdaNj6?= =?us-ascii?Q?REQhK380dtYo2YF54RUxfUIQS4AskZYAyXzsQkdv5jmsc3gw+duyFyBXfVVw?= =?us-ascii?Q?ZQ+p1CUY2UBxOo3UQph3ISkvHso0jnvIpFIJVmBzplLJg8znGTHtQdZCL+Ib?= =?us-ascii?Q?K1EGv+lsWn5ZUsnVEfWDS3DNG8i+GMoo83AYapw5YdZeNYWCCtmtQrcLODbp?= =?us-ascii?Q?GzTG6CaBFlagjtSa7xXZP8GO1xZNZ8rb48njlFJavMN8MSzjT4ggSiDF7d1Q?= =?us-ascii?Q?6js1rUlISvvwwbj0c4JqOfZ7HvM9i5toUBE29CCj4CWNpP6K4ew3pwNHXjdq?= =?us-ascii?Q?6OdC/FYHRoFKYD36+uGQAKLPHwZhxlcD0JWpiHmhXYSt32zjIzFkvQcmibP8?= =?us-ascii?Q?GoCHPFCl1VctEuz5ssdySCiCeRq6mJ+zC7BE7Aesqk6zFMNoVA+aerJjHdKR?= =?us-ascii?Q?HhiCr2x96iSeLwUo6HSG0ynIn+K/Y4IrCieQj3x7FJ0M/0b1U1omEtfb+HNr?= =?us-ascii?Q?OJI3dGhjZw4VEVrBa2Muvp4ilVBLW81mOl+muitOzntyMlls6AfRJX29+BXD?= =?us-ascii?Q?IX9/Y0uSq1erZupX50Rgjz/MhSr2R78YW3BEobQHNlUQUBoJwkxqkVab5+Wr?= =?us-ascii?Q?oujvwJNwml7iouH7a9DaXWrIvQbkMJrQyD6pzV/3DEvKob6xr8ieiqdBalJN?= =?us-ascii?Q?rURS9eSwP9hI3SdQYBs/equ66x76qvXLsbmAHgyT4nW7oDrmFbGxDQuzPedp?= =?us-ascii?Q?zweiTyemoKpUZeIUqewsadvR+WbjGyQggPgLhQMvXJ++B1TjG7Q7z4AqIJUy?= =?us-ascii?Q?2YaOYj3mYtGojcCOsxs8oS1H6LHJu8adQDaBWejh3OkOx748+GFNrOIWVUna?= =?us-ascii?Q?kxDvJbzWtew1prYGkvSP0LXZyhgo+a+6n7yykY/5j8AQKuEOy3p+vj4yfD+E?= =?us-ascii?Q?808WRVfawd2sf4yC+HdSom5J8ZgnQyr96aA+SfRf3EfuyXlMNzVmZTqBhHGY?= =?us-ascii?Q?zcW3Lxhcdw4MlP57vAVfSgtD9uWU15SxzAsjxizv5XkusxoB8pRb9JeZah+s?= =?us-ascii?Q?k8Ow9JRspPYComndEdVn94/d6f6ybtaqrbLBon2r8oZNvgBJkUI614bAjR5Y?= =?us-ascii?Q?0SlPlsSEh2bwtsxXIjVttpoG7w506B6BdhHIKtgOId4xZhwOjLP7P/cYtuWN?= =?us-ascii?Q?EqYkzO58ulCSzA+DVpHhhl1wKF2pRdEqE4mqcqVChK6QuBUNSGGfI3+RG+zp?= =?us-ascii?Q?Z+aIVbX31prhL1RrwoluOyin6WCIdIJ5fkcZ4HN/gbjsEU1co9DKWWRAjOUf?= =?us-ascii?Q?Ge9HUcZbrgk/drrz8+S/iU8rJe7A8ZLWWWJzH3xb8/UHYduexHF6SX5iT6pk?= =?us-ascii?Q?huzJGN80NmfYocpiw/TTV8i5DcdxNOPJaNV+3kZ5rAW26im39mcVoMx/fYgM?= =?us-ascii?Q?pHXQu7A3J+deldfc4jyg0tDdyf8LGTsRONoDU48ImdYQliXQAbjmBzA+LUbk?= =?us-ascii?Q?H7QFbVe8WOO4DhPMiIEqoIXTLB8QtIIr+0NDLhH287alH3Wy3niu7drsmCOo?= =?us-ascii?Q?+esnuc8o3A=3D=3D?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 014a5c0d-1d51-492c-9b5e-08ded750b9c8 X-MS-Exchange-CrossTenant-AuthSource: TYYP286MB2946.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 09:11:24.8678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TtzjY3Cl4zWFijyfqfqac9SVpC7MuiWCBFUN8YxVcVR3MqOkN29v7T4N8aGqvkaCR2xlLu0d2kiEMERj2ERRBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS7P286MB5474 X-purgate-ID: tlsNG-ebf023/1782897088-2E7A61CC-B16322A2/0/0 X-purgate-type: clean X-purgate-size: 2553 Hi Andrew, On Tue, 30 Jun 2026 10:57:38 +0000, Andrew Cooper wrote: >On 30/06/2026 11:43 am, Ryo Takakura wrote: >>>> diff --git a/xen/arch/arm/arm64/livepatch.c b/xen/arch/arm/arm64/livepatch.c >>>> index e135bd5bf9..b7c9aba94e 100644 >>>> --- a/xen/arch/arm/arm64/livepatch.c >>>> +++ b/xen/arch/arm/arm64/livepatch.c >>>> @@ -34,12 +57,87 @@ void arch_livepatch_apply(const struct livepatch_func >>>> *func, >>>> /* Save old ones. */ >>>> memcpy(state->insn_buffer, func->old_addr, len); >>>> >>>> - if ( func->new_addr ) >>>> + if ( !func->new_addr ) >>>> + { >>>> + insn = aarch64_insn_gen_nop(); >>>> + } >>>> + else if ( func->trampoline_buf ) >>>> + { >>>> + int rc; >>>> + uint32_t *trampoline = func->trampoline_buf; >>>> + uint32_t *tp = trampoline; >>>> + void *orig_cont_addr = (void *)func->old_addr + len; >>>> + unsigned int trampoline_code_size = len + 12 * >>>> ARCH_PATCH_INSN_SIZE; >>>> + unsigned long trampoline_start = (unsigned long)trampoline & >>>> PAGE_MASK; >>>> + unsigned long trampoline_end = >>>> + PAGE_ALIGN((unsigned long)trampoline + trampoline_code_size); >>>> + >>>> + /* >>>> + * Make the payload text area writeable while generating >>>> + * the trampoline instructions. >>>> + */ >>>> + rc = modify_xen_mappings(trampoline_start, trampoline_end, >>>> + PAGE_HYPERVISOR); >>>> + if ( rc ) >>>> + { >>>> + printk(XENLOG_ERR LIVEPATCH >>>> + "Failed to make trampoline writable: %d\n", rc); >>>> + return; >>>> + } >>> This ought not to be necessary. >>> >>> The trampoline is executable code, so should have space reserved for it >>> in .text of the livepatch. >>> >>> Then, you can identify it simply by references in a new section, without >>> having to have a pointer with a sentinel value (void *)1 in (which MISRA >>> will have a fit at). >> I like this idea as well! I'll try this together with the earlier >> suggestion using __attribute__((no_caller_saved_registers)). > >If you reserve space in the function preamble, and use >__attribute__((no_caller_saved_registers)), then you don't need >trampolines at all. > >The preamble just needs to turn into `call newfunc` when the callback >function is attached, and then it's regular return will do the right thing. Understood! Sincerely, Ryo Takakura >~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 01 09:25:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 09:25:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349646.1607329 (Exim 4.92) (envelope-from ) id 1werCH-0004l9-5d; Wed, 01 Jul 2026 09:25:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349646.1607329; Wed, 01 Jul 2026 09:25:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werCH-0004l2-2f; Wed, 01 Jul 2026 09:25:33 +0000 Received: by outflank-mailman (input) for mailman id 1349646; Wed, 01 Jul 2026 09:25:31 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werCF-0004kw-0R for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:25:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1werCE-00AMwU-D2 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:25:30 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44dd04-2eae-0a2a0a5409dd-0a2a450bbb34-20 for ; Wed, 01 Jul 2026 11:25:30 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44dd09-ac48-0a2a450b0019-b9ff1c22b30b-3 for ; Wed, 01 Jul 2026 11:25:29 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f1cff582700080a8.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 01 Jul 2026 09:25:24 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 6623286596; Wed, 1 Jul 2026 11:25:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=GfP310Kpdhr5fXTgBNrFPw8Ym4NNFGjbXcVTj6pOR0c=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=H21TdT0tcMuCVnr0FeOW/Kxv30RMncF5D50w4EYh5sNMGqpjFZubpt+51r5sUchij2XrfpRzj 7SasK9/vgDGZXAmhiPi+3/nNGipO/FCG02Ohucps5fr/NXD7tPPBePXURD2qDkIEX08tyzv0dz4 OTIQ+Gzg1nBvVxK3DhEqmsxtDzb06baveqqfu1O8cIWaIHFOulUAvoglVDkcSkaKhngeu7z6iQu M8ok1t0zvcwk5QFM4OthCI1Q69E1rhOU1AhQuN2Sn/I4PKUtueUVMiuT7O3xoymZb3Vx3P/ssre /1opEl2XZO3wEgQ0AaPbf0ha3DVwvHycEa/GUh3HmL2A== X-Zone-Loop: fb28e5638b9af2533d1de6c05be2a0bb672ba81daa1e x-campaign-type: default x-transaction-id: e4c81be3-4b9d-4cc5-9b91-f77009e839ef x-swg-uid: 01-4a0fa403-ac9b-440c-9a53-ce443b45485c X-Mailer: Sweego Message-ID: <1782897924.8631fc262581453bbf619ec5b2062170.19f1cff582700080a8@vates.tech> x-swg-bid: 1782897924.8631fc262581453bbf619ec5b2062170.19f1cff582700080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Wed, 1 Jul 2026 11:25:23 +0200 From: Anthony PERARD To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Juergen Gross , Daniel Smith , Marek Marczykowski Subject: Re: [PATCH 2/4] libxc: drop size parameter from xc_flask_context_to_sid() References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.9cc.84bee03019fb7e8c.19f1cff55cb.ade99102f6e41f7b=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1782897923532 X-purgate-ID: tlsNG-42698a/1782897930-3854C220-9FB4A023/0/0 X-purgate-type: clean X-purgate-size: 835 ---=Part.9cc.84bee03019fb7e8c.19f1cff55cb.ade99102f6e41f7b=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jun 16, 2026 at 11:01:41AM +0200, Jan Beulich wrote: > --- a/tools/libs/light/libxl_flask=2Ec > +++ b/tools/libs/light/libxl_flask=2Ec > @@ -21,7 +21,8 @@ int libxl_flask_context_to_sid(libxl_ctx > { > int rc; > =20 > - rc =3D xc_flask_context_to_sid(ctx->xch, buf, len, ssidref); > + assert(len =3D=3D strlen(buf)); Could you return ERROR_INVAL instead? Just in case this is used by something else than libxl, I'd rather not crash the application=2E Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.9cc.84bee03019fb7e8c.19f1cff55cb.ade99102f6e41f7b=--- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 09:27:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 09:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349655.1607338 (Exim 4.92) (envelope-from ) id 1werE9-0005IR-FJ; Wed, 01 Jul 2026 09:27:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349655.1607338; Wed, 01 Jul 2026 09:27:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werE9-0005IK-CO; Wed, 01 Jul 2026 09:27:29 +0000 Received: by outflank-mailman (input) for mailman id 1349655; Wed, 01 Jul 2026 09:27:27 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werE7-0005IB-HJ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:27:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1werE6-0029pA-U0 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:27:26 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44dd7e-2eae-0a2a0a5409dd-0a2a4508cdf8-0 for ; Wed, 01 Jul 2026 11:27:26 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44dd7e-edec-0a2a45080019-b9ff1c239a1d-3 for ; Wed, 01 Jul 2026 11:27:26 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f1d012af000080a8.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 01 Jul 2026 09:27:23 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id EFC1E86596; Wed, 1 Jul 2026 11:27:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=v0Oq/0medtw3sWIFv4AgOKqcwlN1SFd1sf3+cKdknjY=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=GjF3DCLlULwNymzJpERSpOOgla89r2GwhwyxthuCdbtU643ZLgESThjgkInB2jKBliR1k1/CU 1Qsia0oxdx/kBSQof11vZ28FMva/zfCF08mVc7AxSli7jOTrEIE2AnF6+FON3b096PTzX/zpGTI Upmu3S05gDV9PaicCEd7hv+tBW+OMm4kxOUZhVrV3Aw85xu8gxYRAr0CKOZmtjIjeqbQMpMnQb7 B0O2I0o5FB6p+lP9xNpKulLySOBetZRsYmLibLUwnCa9IV0hsFPtX/LMBq0Y3PE4W/QtItJJoCX Hs+0ToARv4dGUaKkxvMP0pgyv0Uox1S5zYXvg27dhNqQ== X-Zone-Loop: 001b24ec1a56cdabcbb35d61b228e048446220dfc4e7 x-campaign-type: default x-transaction-id: 88ad89b4-7bce-43fb-9c7e-74acc0c48aab x-swg-uid: 01-a0298d41-4b52-4b98-93a6-fccb53e33bf5 X-Mailer: Sweego Message-ID: <1782898043.8631fc262581453bbf619ec5b2062170.19f1d012af000080a8@vates.tech> x-swg-bid: 1782898043.8631fc262581453bbf619ec5b2062170.19f1d012af000080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Wed, 1 Jul 2026 11:27:22 +0200 From: Anthony PERARD To: Jan Beulich Cc: =?iso-8859-1?Q?J=FCrgen_Gro=DF?= , Daniel Smith , Marek Marczykowski , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/4] libxc: drop size parameter from xc_flask_context_to_sid() References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> <33cc1e9d-38c5-44b4-b25b-0f38b625d279@suse.com> <2cc83d7a-1e22-4c2f-85ff-7e9daa0876ab@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2cc83d7a-1e22-4c2f-85ff-7e9daa0876ab@suse.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.9ce.c7b59d80fda33320.19f1d0128c0.cdb4581bb1eb246f=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1782898043073 X-purgate-ID: tlsNG-c1860d/1782898046-40D2B3FC-9334E5B5/0/0 X-purgate-type: clean X-purgate-size: 1212 ---=Part.9ce.c7b59d80fda33320.19f1d0128c0.cdb4581bb1eb246f=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jun 16, 2026 at 12:00:29PM +0200, Jan Beulich wrote: > On 16=2E06=2E2026 11:19, J=C3=BCrgen Gro=C3=9F wrote: > > On 16=2E06=2E26 11:01, Jan Beulich wrote: > >> Nul-terminated strings are passed in all cases, so the strlen() can v= ery > >> well be invoked by the function itself=2E In preparation for a hyperv= isor > >> change also include the nul terminator in the size calculation=2E > >> > >> Signed-off-by: Jan Beulich > >> --- > >> Ideally libxl_flask_context_to_sid() would follow suit, but aiui doin= g so > >> would break its (stable) ABI=2E > >=20 > > You could use LIBXL_API_VERSION in libxl=2Eh to modify the interface f= or new > > libxl versions=2E See how it is done e=2Eg=2E for libxl_domain_create_= restore()=2E >=20 > Question being - is this worth the effort? I don't feel like it is=2E Cheers, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.9ce.c7b59d80fda33320.19f1d0128c0.cdb4581bb1eb246f=--- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 09:40:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 09:40:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349668.1607347 (Exim 4.92) (envelope-from ) id 1werQY-0001J2-Gk; Wed, 01 Jul 2026 09:40:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349668.1607347; Wed, 01 Jul 2026 09:40:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werQY-0001Iv-Dd; Wed, 01 Jul 2026 09:40:18 +0000 Received: by outflank-mailman (input) for mailman id 1349668; Wed, 01 Jul 2026 09:40:16 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werQW-0001Hk-QV for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:40:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1werQW-002CCk-3M for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:40:16 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44e07a-5cb7-0a2a0a5109dd-0a2a450ab64a-32 for ; Wed, 01 Jul 2026 11:40:15 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44e07f-e40e-0a2a450a0019-b9ff1c22858d-3 for ; Wed, 01 Jul 2026 11:40:15 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f1d0ce08600080a8.002 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 01 Jul 2026 09:40:11 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 5E2A886A8B; Wed, 1 Jul 2026 11:40:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=Q0NZ86XoEQtDgO/Bt6pmVawK/ef9zc1X8PA/DIOIMKE=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=HaQ77viuXXBjKc2BLSozESKbLUkbLYrabP9ZdxwVYiAqXaRmg8NGD+OkXnMDdd5GY0Zv6Y/w9 kR8FqOtw6X68E12RU3V/qDojwkUvoCHsng2b3Ceqwm44y1FdJXxtWvGGqe3d5hFpWMclL/Gy5p5 2RjcdUcBNS8AueK29kFWTFtCO+ADVm4YX5qxAif2HwB/0jMlcq1x56buG/ymc8FGUILfNYob2Ds NgOpexUPqOpEyzjR0+DmK/gb17qe9OsRvVethrAxd+88AXRpGnLB7BRihNWkQeUiXvywpb3/5Of ISERp94C/xWEygyDP0Y8/4o2YbGCe3xjU/txdyFULcUg== X-Zone-Loop: 206e6eefd26d04786358331b3173087080d9c93beb76 x-campaign-type: default x-transaction-id: eebc37a5-1370-44d7-bc73-1b6af16bd31b x-swg-uid: 01-1e69a379-7318-4429-9dc9-7375d65692a2 X-Mailer: Sweego Message-ID: <1782898811.8631fc262581453bbf619ec5b2062170.19f1d0ce08600080a8@vates.tech> x-swg-bid: 1782898811.8631fc262581453bbf619ec5b2062170.19f1d0ce08600080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Wed, 1 Jul 2026 11:40:10 +0200 From: Anthony PERARD To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Juergen Gross , Daniel Smith Subject: Re: [PATCH 3/4] libxc: adjust string size calculations in xc_flask_{getbool_byname,setbool}() References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> <83af338a-3ef2-4be3-99f0-cfe38a09cda0@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <83af338a-3ef2-4be3-99f0-cfe38a09cda0@suse.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.9f4.89d32d950e70d08e.19f1d0cde6d.b2f2c93736bd6d53=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1782898810477 X-purgate-ID: tlsNG-4011c0/1782898815-D7537DDE-8EFE99C2/0/0 X-purgate-type: clean X-purgate-size: 794 ---=Part.9f4.89d32d950e70d08e.19f1d0cde6d.b2f2c93736bd6d53=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jun 16, 2026 at 11:02:26AM +0200, Jan Beulich wrote: > In preparation for a hypervisor change also include the nul terminator i= n > the size calculations=2E (Note that xc_flask_getbool_byid() doesn't supp= ort > FLASK_GETBOOL's "ID being -1" variant of operation, and hence doesn't ne= ed > fiddling with=2E >=20 > Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.9f4.89d32d950e70d08e.19f1d0cde6d.b2f2c93736bd6d53=--- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 09:56:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 09:56:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349685.1607356 (Exim 4.92) (envelope-from ) id 1werfg-0003Of-PH; Wed, 01 Jul 2026 09:55:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349685.1607356; Wed, 01 Jul 2026 09:55:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werfg-0003OY-M6; Wed, 01 Jul 2026 09:55:56 +0000 Received: by outflank-mailman (input) for mailman id 1349685; Wed, 01 Jul 2026 09:55:55 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werff-0003OO-61 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 09:55:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1werfe-002rpI-J4 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:55:54 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44e429-2eae-0a2a0a5409dd-0a2a45048970-4 for ; Wed, 01 Jul 2026 11:55:54 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44e42a-a01d-0a2a45040019-d155802ac476-3 for ; Wed, 01 Jul 2026 11:55:54 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-493bfe9f886so2326925e9.0 for ; Wed, 01 Jul 2026 02:55:54 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756636ce7esm16871279f8f.23.2026.07.01.02.55.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 02:55:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Subject:From:Cc:To:Content-Language:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782899754; x=1783504554; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=W6zK63DKcNYjOuOCWSCbY08PInPJq39y+zntVNCWUd8=; b=bb1HvOu8lyeFAPBrVRBrC3trbLYdmzWitWi2wE9bJEEMTysfrgnOjJCMJ1f25nq9BB LlJwq5E24WDD/nh9dy2z/g8adzPWucaKbD2pH+FSPVusZ9WerYEXELYPa5Gc8t/c8P5J LWlyi4rqerdFk+pxIJJyGU2aqfpyjWaFzgCWnJtlH0zE/PUYV05A7MqJl38dzNKhbwU2 pGd6MOnD1BaWYlf/vbOrEI2awlQ7e4K2/I9ccX8CTlekRkf3xfX7wOkLoSpaJF8+3wpm ZqNCj/7q8FlqRvGAVtv6cGaVqOKaivW08bLZUubcp2Zv0toD9kXFuE4Vrtx/uwqyu89W VlUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782899754; x=1783504554; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W6zK63DKcNYjOuOCWSCbY08PInPJq39y+zntVNCWUd8=; b=gJoAvz/NBZA1hmiaC6CgnKGI2X7lTXYSdmgBJJVR9R1Bb3uiT9tMZ1Dn3naDHvXLZi IBkGqmu3APMyysTN279tx/QcKtvTP1G4EnFt+ICp8ltKITBf0lADejcaMnDYMtVDEBsz XE44zsJMcpV8F74o0P8e7l+KfMEsXoIQDS6PitHYj+5I/IyVN4lVNDEfh5xDYKIpysUM t99fwRFRvxbZqcBHwhGr75p9nb2lKTaRCKdgH2geB/xgsIIE/TZzkQKcaw3cjKQXqZRA pq6Buati4hblr9y2FcMpBi5t+cbd+fB1X4iMG+u0hzTYsoEnsSKqo2FtlIBTSx55QJ7O SIcg== X-Gm-Message-State: AOJu0YyYU3Wp+uMhpsTW+0h7RJKT/UaidIm0BQSjPUIpmx9Xms2ynFnn cq5qGxv5HGjulL5cs1S83f9/cBfAgcwo3A++f5lghS8pyua25Xg8wBjnMXpG0Oc+On9UD/Pd9cf /JuQ/wA== X-Gm-Gg: AfdE7cncOdyJ/mJtQTkkjQPeJfFvG3OoN2rBfPlEyjLH0VmNQhL95wq8nRl/tRfJaPR 88zJAIOpVt8FQwr2L1xErX/AFxdW6w5b9jMTsUTJam9ATf+5snhaR0rxTvQqR2bdQKYZ4ZryRZs Nygu5anun4MFyikXJPQB8ie9lQ1RVGOFEJg/XshQ+tSjzW5jg8lvA46q4PoZB2AwkLEtHmmbKxo VRjbAEmiI0IY4FmoBgYW8IqBm1TdSh6lNTI+ASeYzEJTrh4pXvLrKJvrGYAZ4xuh+vtIa0ahzAO rT+9UUmsXGpYmjhIlbtIu8+AqXcr6nMIJBCDijVEzD2eXEu3KVB7SXHVpj9ZaTIQ2id9DOEaC0W fNqc7b1g0pM4Gl2+ooHweMmII1ddI7cKnABaS+5tPUdJN+SbYZGRbAUPsJ9xfEwKjxwzApt613y sd2MDy2bMv7AqlMyHOBtWkM7pzuzIcQF34FkNQRkQNqrriSYMHX2PbxLMCvm45BVJnEkDku5PvP TsJDdXPmPlgq/M= X-Received: by 2002:a05:600c:5010:b0:490:b0e0:3de2 with SMTP id 5b1f17b1804b1-493c2ba5866mr12321355e9.33.1782899753698; Wed, 01 Jul 2026 02:55:53 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 11:55:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Boris Ostrovsky From: Jan Beulich Subject: [PATCH] x86/Xen: correct commentary and parameter naming of xen_exchange_memory() Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1782899754-ADF351CC-00CA4BD9/0/0 X-purgate-type: clean X-purgate-size: 1913 As documented in comments in struct xen_memory_exchange, the input to the hypercall is a set of MFNs which are to be removed from the domain, plus a set of PFNs where the newly allocated MFNs are to appear. Present comment and parameter naming don't correctly reflect that. Signed-off-by: Jan Beulich --- Should "fns_out" maybe be "fns_inout" to further emphasize the dual purpose? --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -2291,18 +2291,19 @@ static void xen_remap_exchanged_ptes(uns } /* - * Perform the hypercall to exchange a region of our pfns to point to - * memory with the required contiguous alignment. Takes the pfns as - * input, and populates mfns as output. + * Perform the hypercall to exchange a region of our pages to point to memory + * with the required contiguous alignment. Takes as input the mfns to trade + * in and the pfns where the new pages are to appear, and populates mfns as + * output. * * Returns a success code indicating whether the hypervisor was able to * satisfy the request or not. */ static int xen_exchange_memory(unsigned long extents_in, unsigned int order_in, - unsigned long *pfns_in, + unsigned long *mfns_in, unsigned long extents_out, unsigned int order_out, - unsigned long *mfns_out, + unsigned long *fns_out, unsigned int address_bits) { long rc; @@ -2312,13 +2313,13 @@ static int xen_exchange_memory(unsigned .in = { .nr_extents = extents_in, .extent_order = order_in, - .extent_start = pfns_in, + .extent_start = mfns_in, .domid = DOMID_SELF }, .out = { .nr_extents = extents_out, .extent_order = order_out, - .extent_start = mfns_out, + .extent_start = fns_out, .address_bits = address_bits, .domid = DOMID_SELF } From xen-devel-bounces@lists.xenproject.org Wed Jul 01 10:05:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 10:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349698.1607366 (Exim 4.92) (envelope-from ) id 1weroo-0005Mv-QW; Wed, 01 Jul 2026 10:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349698.1607366; Wed, 01 Jul 2026 10:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weroo-0005Mo-LL; Wed, 01 Jul 2026 10:05:22 +0000 Received: by outflank-mailman (input) for mailman id 1349698; Wed, 01 Jul 2026 10:05:21 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1werom-0005Mg-WA for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 10:05:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1werol-002CwG-Pc for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 12:05:19 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44e65e-e002-0a2a0a5209dd-0a2a4509b6f2-4 for ; Wed, 01 Jul 2026 12:05:18 +0200 Received: from [40.107.74.130] (helo=OS0P286CU010.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44e65c-97e6-0a2a45090019-286b4a82beb2-3 for ; Wed, 01 Jul 2026 12:05:18 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TYTP286MB3916.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:185::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 1 Jul 2026 10:05:12 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 10:05:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yiBl/Dloq9oZDTvzCf1+nSS30GxMqjQSBGRCdtXDS1Q3BiawWOd58BW5HYlci4JJu9bc2F8VASm/5dGwvq8pUQVufB/aLaMZoiacVLmiibfdUu/e3K2wXlva/ClHsolyWnH7rPYshqx6tQh1MMnStY4wfVqzChhssTm3QvYkqmWEcwrWwuSFPKSZfgAK05R+VwR3nc3jKW4pPFGZmUyty84qHm9LxJ9UE7bXnEMg6eKli7eYLM0XxR0j3966hhSierkhalCRmEdi98ZsgNn/tLgsD1IR1thiLnx8dZmSPcc//ZoDnz3uEhe++sN01BZLbeN+fnKOOOQonNUHWeB9PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s1OEba/foWvHV8Jxg24W6nhI4wu2y86LTQFkMfB1zKg=; b=OQHhxza+OXSN/GF9UA4NhO7+9ZlCSVxtTJ0bSgzivAz7T/iFbCcTwrV7EZWeUZwLU1o2rWguCnXsYFqoTMPyfl5cnLKEI+u6rMxDyw/pFOC9d5yDf7Ii+XNwpCxD0rQ2ql5Epocfl3YDS+yAEQ9P7AWlILQNHOgB14EtT2NRVNP0lj8KxW0xeC39fJW9ylAg2dFjltPwOVLulf8g2lOVfsWo0WnjJNYw84fmqgi2BaMSJu+5SSOO/BKPPasvAR7Av65gf3Ge/22ZrDR3Pum3JHhgHkxQPtddMn41FR8CEV2qTyBiADkscpQgbtq5J9mucNsJNNAw5wiK8roky/4Psg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s1OEba/foWvHV8Jxg24W6nhI4wu2y86LTQFkMfB1zKg=; b=Ocve/AbpErYR94pkCrOloF4BacZMMJ/43+mdX/wQZv6MlyaIo9v2KdJvEknjNtBM2+iauu4ttcCeTZNgDA49bwygnKLWLQS7MCDil/S/d7GaF/d5mPAGTV3l2//i6ieY/yK+BW6Vy2KCEmcyD+k6OPdTg1CJJntIU/PIKqw0sB4= From: Hirokazu Takahashi To: Jan Beulich CC: "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 0/3] xen/arm: Device Tree based CPU topology support Thread-Topic: [PATCH v3 0/3] xen/arm: Device Tree based CPU topology support Thread-Index: AQHdCBJft4D5Ks1pD0WlbKl0kB83Y7ZWrjwAgAHDICA= Date: Wed, 1 Jul 2026 10:05:11 +0000 Message-ID: References: <20260629215806.11610-1-taka@valinux.co.jp> <7b0be62a-879b-4fd2-b1aa-5fa8448c7288@suse.com> In-Reply-To: <7b0be62a-879b-4fd2-b1aa-5fa8448c7288@suse.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS9P286MB7222:EE_|TYTP286MB3916:EE_ x-ms-office365-filtering-correlation-id: a5f72e40-8e6b-4c95-2698-08ded7583cf5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|56012099006|4143699003|18002099003|22082099003|5023799004|38070700021; x-microsoft-antispam-message-info: AtU+RuocoDTguFtA6jpB58TUBZoakLwtuCmbgIvoNUKb/J3K2ryE+Mndd4HK5kIjUmcCNLxdXSJ8RdNZl7Qzpd4NpNNfx/re7N2q6BTx7jN0TkiIQIkAT+ZxPgzUFR252EtU9kJSiP+5RBviYmOkZDUUS13QdAyMspRxefrIlnI784tPKg5xHjDHa7bwdTeosrDv42Y7Efi5WAVwGWI8d4zOz9kv+iPckAca1RDiGwwPooAIyPNP+qo4272zH4JPuWu9enWEm/gyZJO3Fc0C5ERmVOkAlTnC3PaqNEqQWDcn12OpdBMBK9kGYe3QLHtqnU9qcchLI04eDjjS5dw+375RLlxpcCTx/bsfHl9CbFPPBWEXm3GQN/lg61VLXVWBoDiM5nNjnwzu25mewdgdZztA0m446Mux5DteJX0Ew8EFm8ePdeVl9+1hOsHUDwXvi7f5i1CT4AcnA7j+Zf++O56fzfuRs22wkkpk/JDeoDJvCvGcQjpzWHd63T4F6ssshEFQrEx0x3RyUDx0Iup9zsRjh9w4aONSK/jesyKVPweT6gz4FIa2thcsEWSfVM2pSVN+R8yakdwrYQKkdVvWVvLxiIGtJ8WHv5m5qwPM7Ot4mV2+UDdbhjI6piT1ZzzUtx5cf5B3ebsbrv6TW/YLFZSfIvlIOW10cHeDr8tEOUmCQdr37qEJgyw7XH7OotPo6prlKSLLu1sdmKdz2xxlxCFFdWYacCTr13b1mCj2D2Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(56012099006)(4143699003)(18002099003)(22082099003)(5023799004)(38070700021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R1VWYVVmUDQrUjkrKzg2ZU42azFKU1I0TVE2Y1N6bVNucCtOK1YvKy96TWdD?= =?utf-8?B?aGFldTBUMmNoRlhYWlU2SnMxWk1JOTdpRXl4UVMyVXlGbllrVjJsU3N2ZzRR?= =?utf-8?B?d2RKWWRiNTRUK3FhV3NrTllZQWtPamJHRzErSCtmOE9wMUl5bXM4WnlIMmlo?= =?utf-8?B?ZzRzbmdneGVLTVFHdWdPVCtWcmRVSkRnMlgyZ0tmNkR1TFBqMzNIbHNITkJM?= =?utf-8?B?TmtvWGhDVTNscDNaT1ZJY05HV1pyMGdMVCswSk1LMkt0bmx1WHhkWGNUeFc3?= =?utf-8?B?b1BOeUZBam5UZGI2azY2KzlrWTByc29xVHF6QUJKUW13cTVEcFlPNmpRODdI?= =?utf-8?B?ZGJsbUJQaVNmZFdhTWtkWXpFeWVnRXJBVFVUZzl2SldudEpodUVjMmZnazZO?= =?utf-8?B?YXhrMTI3YWFPTWsvTEZZOEczeXBxK3Y2RGxTMFNwb0lSc0E1cm5nZENUbUUw?= =?utf-8?B?bnZGV3FJQXNYc2NmL09kcS9ZL1JVNmJqWStoa1Z0d2Y0K1lwTWh4eGUyTmFy?= =?utf-8?B?MkE2OWhYOS9rY2JhNVVuQy9kL3NDNVgxKzJtcEdoUHJMRCtBeHN0VWZ5cGVF?= =?utf-8?B?Y3hGTEJXY3dscEpxaXNTMzlHZzlsKzY4OE1CdXc5cnNyY3A2SVV0OElDTC8y?= =?utf-8?B?VmxmNFlzY2p0MkllVVJkald0UkJTbk1uM1hVWXhRUm1WeHNnVVUxTFFmNkox?= =?utf-8?B?MHB2Wk4zOVd5SEZmUVRNeklWWnBrcFE4dEtWWVArMlp6OWJGQ0JCZ0JydkIx?= =?utf-8?B?ZWRXVmFDSzcySUdTbFZSc05ZYzRKOEZmQVRBd1p3ekhUTXJKRlhqOEVYQ2ZQ?= =?utf-8?B?Y211a1VXbjRuOW9MNk9BWnV2VmFaWXdpb0VCWnZoaDRjSlFtT2kzcUpGbmZj?= =?utf-8?B?Y1l6aG9jblRPWGxKcjhUMU05VEJzU2pHajFmcENTN1lKWEdHeWNOd2dJZGl4?= =?utf-8?B?NzV0M2dHMVJ3b3ppaUYvbjgycEhuRnpSTmhmU0I1bDQ3MnVrbER4QkR0S3c4?= =?utf-8?B?R0tianZmOEhIQnNQRktlM3pVcjBCNy9pZGZ5ZldCdnhkeEpwZm5aNXhJdC9V?= =?utf-8?B?N05FVjVjMVJBaGliVlg1S3RSR3hFbHdqVjNyckZTeTA4YS9MN0dxQlhRY2lY?= =?utf-8?B?dzlNTDE5eDdIYng2RmFIM3pqNHNFSlBSMCs4MnRoZXRqTFpqVHVkdWxUS1NT?= =?utf-8?B?dkVyUEZJSHJBQ3p6VmF5MlZ5M2V0NE1rZjR2d29ydTBYLzJidTlmVjUrL2E1?= =?utf-8?B?cUhwRUNRQkoyalBCdXhYdWFQWno1ZHlObElxMm16L1dvZ2lXRkR1WTBDTDlX?= =?utf-8?B?Ny9HUzBISWg0a2QwS21PbzdpQ3BzUXpWZjNGcjc0U1RRRU1BNzh2WWJCWmJE?= =?utf-8?B?aWc3QWhmdnYzWGZpWS9VbkJobUNPa05XS002M2FMT0NYcXQwTDMyRVlwMFQv?= =?utf-8?B?dXFxdVFmbE1LcWRMM1NOdmRFWEh6VEtOcW54Q0t6ZVBWemZMK09DQlVwWVR3?= =?utf-8?B?MUdFdHRPZ01rNTNXdjhwRkhraWxzV0hFejh1YjUrd3Q2Q2RNd0FLM1pkVzVr?= =?utf-8?B?UkhlZ051eTBRNWdSUGxNb09pVHVIT3c3cmxWSzJYdXhRUmRDeXA0enNQdFZ0?= =?utf-8?B?S0FMeFRjN1dCT1V0RXlIU1VyT3d4YnB0NVBheUx6TExjbzFVeHRGaXdzM2lY?= =?utf-8?B?V1BEMStQZHRETHdvRkNVeG1EV3pwMGNUdzY0aHZNSCtXVHJhOC9ZbVJyMkFF?= =?utf-8?B?Skx3T0JsWjJ4VE40K1hrVTNPWGhmeHZianVJUVNTL2ZPajZJWHhmQi9hakdq?= =?utf-8?B?TWpwQnJ6NHZXNDVLbUZ4RE9COWt5YUJRVjdKcVFlNURBTVRLSGs3UVdjNEZi?= =?utf-8?B?T3J6cWFFL21OMUFxcWNHRWdtSTMwYW0rTUNCMTN4d1pnTXp0N1UxOUQ1eTh1?= =?utf-8?B?YlZRck45OG42UXVTcXhrdjVJUmFYeXJ1c3YxZUovbnp1eW9mNDhTbUsva1BC?= =?utf-8?B?VmRqZVZzc3U1cDhSVFE2eHdqSFBRb2x2emsxMlNkWDUxWUttLzFIQVYxMmRs?= =?utf-8?B?ZjYvbVZ4MTc4blhWWW5WWko1TEtPMmVGeUl2aUttN29nS2dTaEUxZlB5VUpD?= =?utf-8?B?WjltM2tDTGxaYytQeW1URGkrR1MwdkNKb2I0ditZZ0RVSlBPUHI2NktQMUJC?= =?utf-8?B?dXhxbEtVd2M4MmRSTjdWR1I2VGtZZW1JYlFWSzUzOG9VTHhieHNSaXhiU2Nq?= =?utf-8?B?bVhzR2F0dHd3TnhJUkJsWkMzOUYwdm5IZUtYNHpSTlcyTGRmTEtTcFdmUGdT?= =?utf-8?Q?llxLnPcxKfyW7B1pBV?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: a5f72e40-8e6b-4c95-2698-08ded7583cf5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2026 10:05:11.2437 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tsCHrKV6U+yB4ZXtSRkY7KiU5fAbZnJVvTdCcOsVVe604p8n6lrKJpfp7H/bpkbibSdb/NEi2K4idN5cDNOAPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYTP286MB3916 X-purgate-ID: tlsNG-bad1c0/1782900318-47731986-F196BA0F/0/0 X-purgate-type: clean X-purgate-size: 2066 SGVsbG8sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUdWVzZGF5LCBKdW5lIDMwLCAyMDI2IDQ6 MDggUE0NCj4gVG86IEhpcm9rYXp1IFRha2FoYXNoaSA8dGFrYUB2YWxpbnV4LmNvLmpwPg0KPiBD YzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg djMgMC8zXSB4ZW4vYXJtOiBEZXZpY2UgVHJlZSBiYXNlZCBDUFUgdG9wb2xvZ3kgc3VwcG9ydA0K PiANCj4gT24gMjkuMDYuMjAyNiAyMzo1OCwgSGlyb2thenUgVGFrYWhhc2hpIHdyb3RlOg0KPiA+ IENoYW5nZXMgaW4gdjM6DQo+ID4gIC0gVXNlIChucl9jcHVfaWRzIC0gMSkgYXMgdGhlIG1heGlt dW0gQ1BVIElEIGhlcmUuIFRoZSBmaXggZm9yIHRoZSBzcGFyc2UNCj4gPiAgICBtYXAgbWlzbWF0 Y2ggaXNzdWUgb24gQVJNIFhlbiBoYXMgYmVlbiBzcGxpdCBvdXQgaW50byBhIHNlcGFyYXRlDQo+ IHBhdGNoLg0KPiA+ICAtIFN3aXRjaCB0b3BvbG9neSBzaWJsaW5nIG1hc2tzIHRvIGNwdW1hc2tf dmFyX3QgZm9yIGR5bmFtaWMgYWxsb2NhdGlvbi4NCj4gPiAgLSBBbGxvdyB0aGUgc3lzdGVtIHRv IGtlZXAgcnVubmluZyB3aXRoIGEgZGVncmFkZWQgZmFsbGJhY2sgZXZlbiBpZg0KPiA+ICAgIHRo ZSB0b3BvbG9neSB0YWJsZSBhbGxvY2F0aW9uIGZhaWxzLg0KPiA+ICAtIFJlbW92ZSB0aGUgdGVt cG9yYXJ5IGRlZmluaXRpb25zIG9mIGNwdV90b19jb3JlKCkgYW5kIGNwdV90b19zb2NrZXQoKQ0K PiA+ICAgIGZyb20gUklTQy1WIGFuZCBQUEMgcHJvY2Vzc29yLmguDQo+ID4gIC0gTWluaW1pemUg dGhlIHVzZSBvZiAjaWZkZWYgYmxvY2tzLCBsZXZlcmFnaW5nIGNvbXBpbGVyIERlYWQgQ29kZQ0K PiA+ICAgIEVsaW1pbmF0aW9uIChEQ0UpIHdoZXJlIHBvc3NpYmxlLg0KPiA+ICAtIENsZWFuIHVw IHRoZSBjb2RlIHRvIGZvbGxvdyB0aGUgWGVuIGNvZGluZyBzdHlsZS4gUGxlYXNlIGxldCBtZSBr bm93DQo+ID4gICAgaWYgSSBtaXNzZWQgYW55IHN0eWxlIG5pdHMhDQo+ID4gIC0gVmVyaWZ5IHN1 Y2Nlc3NmdWwgYnVpbGRzIGFjcm9zcyB4ODYsIFJJU0MtViwgYW5kIFBQQyBlbnZpcm9ubWVudHMu DQo+IA0KPiBIYXZpbmcgdGhpcyBoZXJlIGlzIGJldHRlciB0aGFuIG5vdGhpbmcsIGJ1dCBtYXkg SSBwbGVhc2UgYXNrIHRoYXQgcmV2bG9nDQo+IGluZm9ybWF0aW9uIGJlIHBlci1wYXRjaD8gSXQn cyB0aGVyZSB3aGVyZSB5b3UgbG9vayB3aGVuIHJldmlld2luZw0KPiBpbmRpdmlkdWFsIHBhdGNo ZXMsIGFuZCBoYXZpbmcgaXQgc2VwYXJhdGVkIGFsc28gaGVscHMgdW5kZXJzdGFuZCB3aGljaA0K PiBpdGVtIGFwcGxpZXMgdG8gd2hpY2ggcGF0Y2guDQoNClVuZGVyc3Rvb2QuIEkgd2lsbCBzcGxp dCB0aGUgY2hhbmdlbG9nL3JldmxvZyBlbnRyaWVzLg0KDQpUaGFuayB5b3UgZm9yIHlvdXIgYWR2 aWNlLg0KSGlyb2thenUgVGFrYWhhc2hpLg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 01 10:24:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 10:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349714.1607373 (Exim 4.92) (envelope-from ) id 1wes7A-00007J-4T; Wed, 01 Jul 2026 10:24:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349714.1607373; Wed, 01 Jul 2026 10:24:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wes7A-00007B-1u; Wed, 01 Jul 2026 10:24:20 +0000 Received: by outflank-mailman (input) for mailman id 1349714; Wed, 01 Jul 2026 10:24:18 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wes78-000075-9t for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 10:24:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wes77-009LD7-5V for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 12:24:17 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44eac0-2eae-0a2a0a5409dd-0a2a45048c86-34 for ; Wed, 01 Jul 2026 12:24:17 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44ead0-a01d-0a2a45040019-d1558035e4d3-3 for ; Wed, 01 Jul 2026 12:24:17 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493bc8fda98so4110065e9.0 for ; Wed, 01 Jul 2026 03:24:16 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4fc1ddsm71386625e9.14.2026.07.01.03.24.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 03:24:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782901456; x=1783506256; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qm/QOIEGH/EybngvDt4pUFu9qHLWWoz/mlh4VsVX9Mg=; b=JCl077maBKOP5XsWK7mk73OIZ0JWKCgahd/dEH9eqOi9F2tPn9wEHxd5Wxrph8LJkJ aHEB16cVRHOBcTNE/ZyZQLp8hEWMSAzrp+kcA6TiFcAVDz9Np64XoGmGGvHZHPIezcN0 bG6gkOSCmui2wC3H6uigdzRLJV/+VgFH7gN2BMw7pOwazezRfvveMC6KArjgexK6qvyf rqqmDSuNGvMnXUkBaJiCREbqFjpO4F2ZXTAEebJmEMwc6jMIY53g0HYvuEI3t+w2eUpM 8BYjQpDBBfeG85NRQVNObAcHKk1j8Q68O1wLij+8KSuFjjrsVnQaH5A8bYOYALr9/fkQ ZIcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782901456; x=1783506256; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qm/QOIEGH/EybngvDt4pUFu9qHLWWoz/mlh4VsVX9Mg=; b=jAn16HvdkKy4zW4zQcb+ch3o6Vzzt75JIzfBSLbFAJMNasw9PB9gJWosBxa2y2KYnX t16SV6XbQKU4kA00aSHlEAcTBCcj+7CsmteDnJlEtAM+hfrRcW0CTSv4Ll/1kmKUwsCS qvatwBFs5YBvXdMXGpZ5DTv0Ksg0w+OAE2SQ39CdQLi910Ll7S/vuWnxZ6TW1pK97Q7W GdktkmLs/lXuLl7v1xHMAouKzldfH4Uji6ZWlIZLw1cBq+m4A7ZPyw5chVHbtFE32uUr kPU+G4x+kKsaZJyls2au0sBMQGAQlM1aGif+VKgqwPPB772XEeB47IyFDYHQtWXmfD9E nsUQ== X-Forwarded-Encrypted: i=1; AFNElJ/xUmG5Earn69QbkvJp4TTJ6DBn+G1b9QlQd9QWG0cJ4BRNUCWgEb8RCNFAM4ABsvj33pwatFns2bc=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx2BjM0aNRc/Fm+2NkBNlMaCO3fWvv7tTNpPR/KIkCr3qjo+xZn ntLBoSOfi5sbNnu4j34N0Mi+ObqvNn+ybWDI6kmRJFcgO2rGAzDWyxj7 X-Gm-Gg: AfdE7cnGtnwM4lpx7eQoHY5SaWIHAaE/tR16hglkTsg6AbpOWAwA3SZbhG4rQpqJ6TA uh4PxpN/cIb4kS2G6otAV6UqiMDCb1ZPkwlBXIlJr4su4/zJv7xYSoM8RX1x2UJYt/Pxl1Js0eT Hh4CdouPXpUmNtuMaeDU23+na4YacQ/LDPpNteyr0a6z6lyu+i3U6giaYyY/FgjFhlK9rBS+QJS YV3G4GGR+6HkXlMox1p3c5LCd0UjsETdKFDn21usjUSw0WJ6wfqd2SQ1yQ/4rldCoW41vQZ6RVL OrbzbuKxA7XQww+HgbENeQZNLbhOhzFvGG4giriMjZ/TI+rcMDSY8bnsuBUfOrxZz6yZ3LF9dWH dPWI8kGKIsGos6sjST9/VULtvgLRhzI4QWFQGXU2x5zj4ia2gYpx3c156M51fL6ofJdmfjT+oOW cWdYqcEYskSGqydjR2slBmCAaQhC7/jnyIT4z+6BHJpoCNDa+dT+vqURB/hGb715/Z54I= X-Received: by 2002:a05:600c:8117:b0:493:b9cd:1272 with SMTP id 5b1f17b1804b1-493c2b96e36mr14998635e9.23.1782901456304; Wed, 01 Jul 2026 03:24:16 -0700 (PDT) Message-ID: <015bb3d7-ef55-401b-902b-ddcd14a1c7ab@gmail.com> Date: Wed, 1 Jul 2026 12:24:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 16/25] xen/riscv: introduce minimal virtual APLIC (vAPLIC) infrastructure To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <61603c1548b7c685fb92e1b687445fc1b6a95c35.1782487661.git.oleksii.kurochko@gmail.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1782901457-ACB3B1CC-BB5D87BB/10/73395122804 X-purgate-type: spam X-purgate-size: 3637 On 6/29/26 5:02 PM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> Changes in v4: >> - Change subject of the commit. >> - s/APLIC_DOMAINCFG_RO80/APLIC_DOMAINCFG_RO + added a comment above definition. >> - Drop unnessary blank lines. > > Did you? What about ... > >> --- a/xen/arch/riscv/include/asm/aplic.h >> +++ b/xen/arch/riscv/include/asm/aplic.h >> @@ -15,6 +15,9 @@ >> >> #include >> >> + >> +/* domaincfg bits 31:24 are read-only 0x80 */ >> +#define APLIC_DOMAINCFG_RO (0x80U << 24) >> #define APLIC_DOMAINCFG_IE BIT(8, U) >> #define APLIC_DOMAINCFG_DM BIT(2, U) > > ... the one you pointlessly add here? > I think it is newly introduced... Anyway, I will drop it. >> --- a/xen/arch/riscv/include/asm/intc.h >> +++ b/xen/arch/riscv/include/asm/intc.h >> @@ -15,6 +15,7 @@ enum intc_version { >> struct cpu_user_regs; >> struct irq_desc; >> struct kernel_info; >> +struct vcpu; >> >> struct intc_info { >> enum intc_version hw_version; >> @@ -51,8 +52,17 @@ struct vintc_init_ops { >> int (*make_domu_dt_node)(struct kernel_info *kinfo); >> }; >> >> +struct vintc_ops { >> + /* Initialize some vINTC-related stuff for a vCPU */ >> + int (*vcpu_init)(struct vcpu *v); >> + >> + /* Deinitialize some vINTC-related stuff for a vCPU */ >> + void (*vcpu_deinit)(struct vcpu *v); >> +}; >> + >> struct vintc { >> const struct vintc_init_ops *init_ops; >> + const struct vintc_ops *ops; >> }; > > I may have asked before: Why two distinct structures, next to each other > (and without any comment guiding what is to go where)? I will add the comments: /* Used during domain build only; dropped afterwards. */ const struct vintc_init_ops *init_ops; /* Runtime callbacks used for the lifetime of the guest. */ const struct vintc_ops *ops; > Plus you only set > ... > >> --- /dev/null >> +++ b/xen/arch/riscv/vaplic.c >> @@ -0,0 +1,63 @@ >> +/* SPDX-License-Identifier: MIT */ >> +/* >> + * xen/arch/riscv/vaplic.c >> + * >> + * Virtual RISC-V Advanced Platform-Level Interrupt Controller support >> + * >> + * Copyright (c) Microchip. >> + * Copyright (c) Vates >> + */ >> + >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> + >> +#include "aplic-priv.h" >> + >> +static int cf_check vaplic_init(struct vcpu *v) >> +{ >> + return vcpu_imsic_init(v); >> +} >> + >> +static void cf_check vaplic_deinit(struct vcpu *v) >> +{ >> + return vcpu_imsic_deinit(v); >> +} >> + >> +static const struct vintc_ops vintc_ops = { >> + .vcpu_init = vaplic_init, >> + .vcpu_deinit = vaplic_deinit, >> +}; >> + >> +int domain_vaplic_init(struct domain *d) >> +{ >> + struct vaplic *vaplic = xvzalloc(struct vaplic); >> + >> + if ( !vaplic ) >> + return -ENOMEM; >> + >> + d->arch.vintc = &vaplic->vintc; >> + d->arch.vintc->ops = &vintc_ops; >> + >> + vaplic->regs.domaincfg = APLIC_DOMAINCFG_IE | APLIC_DOMAINCFG_DM | >> + APLIC_DOMAINCFG_RO; >> + >> + return 0; >> +} > > ... ->ops here, leaving ->init_ops at NULL (prone to a deref that'll crash). It is init-ed in [PATCH v4 20/25] xen/riscv: create APLIC DT node for guest domains and nothing between this patches could use ->ops. I will update the commit message to point that. Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 10:33:06 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 10:33:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349726.1607382 (Exim 4.92) (envelope-from ) id 1wesFZ-0001y4-Ti; Wed, 01 Jul 2026 10:33:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349726.1607382; Wed, 01 Jul 2026 10:33:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesFZ-0001xx-RA; Wed, 01 Jul 2026 10:33:01 +0000 Received: by outflank-mailman (input) for mailman id 1349726; Wed, 01 Jul 2026 10:33:00 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wesFY-0001xr-Oc for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 10:33:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesFY-002K3H-5R for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 12:33:00 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44ecd4-bab6-0a2a0a5309dd-0a2a4508850a-16 for ; Wed, 01 Jul 2026 12:33:00 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44ecda-edec-0a2a45080019-d155802ae54b-3 for ; Wed, 01 Jul 2026 12:32:58 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-493ae59eca6so3611575e9.1 for ; Wed, 01 Jul 2026 03:32:58 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c0e92687sm31842285e9.0.2026.07.01.03.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 03:32:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782901978; x=1783506778; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Nspqi0L/FvaaEelw0vLuhfkp8XgCfb5VdSEDQnxQXI=; b=AcL9rL8xP0AC5H6jotR1kA76UJQrXLQdKPmURzl+l94Yr1EvX21MxTStSTEOed/Mxx 661ZQgwJs+t86v82lbFEXbMmZx1JpPyveqTSuApJYMvTIAjNHqpjFsRDNOiRgKyfEZTx C1Un8dlHWJds0b+t0C5j0AHwSkUeU0r+2M4e5j9D/p4JTwqzPs7kkZSpLyD/N7yR4+p2 pw6nTMOKTsliI4SlxRB/lp1Plp10pPq/8vPGOQ7539v2baUCBuyRum4oGYCQd/fpegQc BzFskz7xBGn15De0FBOKzc0G52fxuvXqnx/ahFzO0gNNkGGN21gBDh2I/tOcAMBGWdjq 7ZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782901978; x=1783506778; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Nspqi0L/FvaaEelw0vLuhfkp8XgCfb5VdSEDQnxQXI=; b=PjcRNH5uEePYHVMPKXGWrk1m1+Sjx0Ybu4/O1JPGCA4QDovqokKzXFAbk+9/PUK4Vt bCnXH2X0cTUh/u5upxm8inFXqpoO3AgPEcHblmKrWRICmvndLVIQ1I1LH6KLsBYJuSr0 qcZCsqzTBWKV+xNyB/h4l7u5p7zG/4ALj+RB+lDkISxVefJ5sGieWfeBZwsrrqM/fN6X jbt6Ksj09//NDZIKuDYbtOe4vuyUtCQawk8f0szrkWBectP+iMUkr144Rw8mbniRbjy6 ptfN5c/FYjbZf8wyL4OqQiQJQ1Z2aOsOS/YTacaHc/Ieo38fos7W0lW69tONEiZcH4Dj IrDQ== X-Forwarded-Encrypted: i=1; AFNElJ+GgFU6PWsn+eciTKRf2A4WdA68+S27lOZSMpevy2VFlVJ3wnXm353yX/70dda3cg7JZf40nf5+xLw=@lists.xenproject.org X-Gm-Message-State: AOJu0YzN1ugwCid4ak89s1fj2IN5NpvhEMbwVvvRTR5n0ysbsiSsO8Ok X0G5T/U7TAwbeIINUTHvUJ9Xd1yB44l/c2VIhWil/G7kgR/HsL/KrnUz X-Gm-Gg: AfdE7clmLxVa6cJ03d3Unm5cKSWBT46uLvgGFhIEIVT5vC1YtvI9NDnzKhvO9qrEy8x YJJr6+TVGaTRjY3cQNXv8TQr/qZGs6hV0VBCeRiXy/LJ6d9IAUEXGeAZFhrky29BoWfKlr8JW6m wvsTIqcHTl7ywDkXZYwD+0DhbIw6imTSGe8o9VGR/G+1QEqu0XTigeFF9rBU4RsRqMazyR6Luy/ NzTPnD28qNy5PTpyVfli93E8r1CCEGsyfAorDHyrKV5HumkycEm6frLDUTZNletlO4XB/0UzvAr e07E4qLfgWmEaWDoMctTcX/NLvBWxvE4EP2s9yQT+YW+KbPxJSndMR3E1QQ6CSB4fE60K+IbVun 8FxxBhCrO9EGvN6k2huz6jlzuidKmthQYAu5f8TnranTALky1Xxj8psUkTD4gHQgr/79di57DGN 7CDmni+WOY1e8B9y2bzCaFdwDX529ceyQWpCGWlwI16Z7CFRtaQkGHdmbBbuIMuCy1GS0= X-Received: by 2002:a05:600c:3b05:b0:493:c337:db18 with SMTP id 5b1f17b1804b1-493c337dc47mr10143765e9.16.1782901978196; Wed, 01 Jul 2026 03:32:58 -0700 (PDT) Message-ID: <8b1180b3-a165-409b-93e3-400b0aeb7039@gmail.com> Date: Wed, 1 Jul 2026 12:32:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 17/25] xen/riscv: rename enum intc_version to intc_variant To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <542b22adf7bfb2a60baba201ef89df260d9bfd1c.1782487661.git.oleksii.kurochko@gmail.com> <8ccc2b52-ede8-4eb4-9056-49f1aad5e08e@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <8ccc2b52-ede8-4eb4-9056-49f1aad5e08e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c1860d/1782901978-4293D3FC-A15FF1D8/10/73395122804 X-purgate-type: spam X-purgate-size: 797 On 6/29/26 5:04 PM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> Rename the enum to intc_variant and the structure member from hw_version >> to hw_variant to better reflect that these values select between >> different controller variants, not versions of the same one. >> >> Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich Thanks. > (perhaps also Requested.by: or Suggested-by:) Sure, I will add one of the tag. > > It looks as if this might be independent of earlier patches, and could go > in soon after branching? Yes, it is fully independent. If at the momemnt of posting of v5 it won't be committed I will just move this patch to the start of patch series. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 10:52:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 10:52:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349739.1607392 (Exim 4.92) (envelope-from ) id 1wesYa-00054o-Dz; Wed, 01 Jul 2026 10:52:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349739.1607392; Wed, 01 Jul 2026 10:52:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesYa-00054h-BR; Wed, 01 Jul 2026 10:52:40 +0000 Received: by outflank-mailman (input) for mailman id 1349739; Wed, 01 Jul 2026 10:52:39 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wesYZ-00054b-31 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 10:52:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesYY-008DJG-Fv for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 12:52:38 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f176-e002-0a2a0a5209dd-0a2a4501ba36-0 for ; Wed, 01 Jul 2026 12:52:38 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f176-400f-0a2a45010019-d1558035b871-3 for ; Wed, 01 Jul 2026 12:52:38 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493c2b3dc8bso2449635e9.2 for ; Wed, 01 Jul 2026 03:52:38 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47566fe448dsm16010183f8f.27.2026.07.01.03.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 03:52:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782903158; x=1783507958; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZcE6jBxr6nihgfqAzS4ZqpmQQYuTZk3PkpqYA/Nt5TU=; b=IGSdwTtF9RLZgaPaPA+2hvfZl8+1xHTv4uLZFzv4w9C86CyHd3OVI3ZxWw9hAXnEtl Tt+WLD1PmjkLVpoMjcngffWRgul2v5o2ntLNv3+bBkYvpMLnfmOp4IbdDr2Oonh2hQsa qlY6PZQ2XvGJZxhxH1b+KH36SFarmvYUJAUvIHsSmBILrd2+kVs32PDUTQfuT2HYu3TN 7p1m/XbuveKkeeS78djaSQ3wcOJun5NxaIkx13RVVhqjLJJQE4byA0C9f7WkxebCLgdh nn3CUKLhLiSwEANYmJLoah7SeQ7OdYlXhILK1o4MvzXVKh1QIdXJ/qZ9Hw6D/Azqho/X OzcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782903158; x=1783507958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZcE6jBxr6nihgfqAzS4ZqpmQQYuTZk3PkpqYA/Nt5TU=; b=TNNJwY6fXsyiXHwPidV3DAM5ca/WbBXfscltyoHlNZYqe5XuXVtOY+7UAPtvpJS8sG vB5LmNStwjT93UJIdieWUvqgZJyuSkPTMIwcRCy/TM9YarI5+QnTzLz/uxDxovPc5WBz lUPTZMAbq5JpR+gmamxzUxikyKYsFfsMB8CeD6JEf88T0aAlC/rRUAK/M2QVG/8fSO95 cRjsNHLUFCohaAWv+C+KtuczY8U5YaXYIhJmM0rTToy1gyyOuncHcxQ71x8owaWra4/x M+SVW3CaUXMgSHx/OwHSXtREcdL7IXpEQiLquWV7pJIg2XJUOd0CNnzc21i9iD58cIxG gBwA== X-Forwarded-Encrypted: i=1; AFNElJ9tqEh5zw/uTUvObD8lUBmRrTcynVsipsoM3QBinjPVmyVZ6SQ7Px+m9kGWKqWO0G4qM5LPYr0FXmA=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy0tbuMUF+S/c0p/mY9L0a5bKAmZ91xWFxnVi51mcM/LL+MNCjJ rH6N/8nwJdaPkLqUVN4qVNtLxyywpFntS0AvXnAhfzoNeM6BhYyylLuO X-Gm-Gg: AfdE7ckbzunoEc/qEZ+pcSn+NMO0pde7QjHN+2riRkYsOpvBDMgo4cnIau1OukvFp/2 di4lzaqmhTo2H2pd1i2x9eJWHT+NMmWkewD3p7YRAyyuSBLLTLsdPN7tZmxNJ319ipXRtVppJtR U4RloBa9UPrDTv+sYXMHmkzSK5HANUXjF9GdIosTsv7fNgGlOiw8PZ4Hj+J8ioqtEo7v4lnjUgL wmrcyKSAqSgoFgJi11cVCJm0YGFKwNS3OlEDsbMYWjJHJ7/+/xuQVkBBzbFyENtWnywqoIduEuE sFFN7F5mKTh0tfESjlk5eealw7Bl3xZLA1n8d/41dK2clAolkD5qYWjQtU+qlx6P9e972yTEgbP pgA/PTmcpTV6HjpjjPKLIweyi1AkCbbgfMtx8LCXWqWn7wfpO89BCKY8sN7ajoqEhQAMJYyAaKk EPX0+tBNoey3OS3tLhxzLMWSDvniISncNidQYGAhexnxVBSTC7hDjQNDVEuVQ9cfImirU= X-Received: by 2002:a05:600d:c:b0:493:8391:919a with SMTP id 5b1f17b1804b1-493c2b433dbmr16095845e9.16.1782903157864; Wed, 01 Jul 2026 03:52:37 -0700 (PDT) Message-ID: <05173913-e6e0-4602-a75d-96ce134bd2ec@gmail.com> Date: Wed, 1 Jul 2026 12:52:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 18/25] xen/riscv: introduce (de)initialization helpers for vINTC To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <109135cb-7ad6-49f4-88c7-49ffb33e0068@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <109135cb-7ad6-49f4-88c7-49ffb33e0068@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1782903158-826C31E0-C7E57116/10/73395122804 X-purgate-type: spam X-purgate-size: 1234 On 6/29/26 5:07 PM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> Add common helpers domain_vintc_init() and domain_vintc_deinit() to >> allocate and deallocate a virtual interrupt controller (vINTC) >> structure and initialize basic virtual interrupt controller registers. >> >> domain_vintc_deinit() isn't called at the moment as arch_domain_destroy() >> is implemented as stub at the moment. >> >> Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich Thanks. > with one more suggestion: > >> @@ -83,3 +84,37 @@ int __init make_intc_domU_node(struct kernel_info *kinfo) >> >> return vintc->init_ops->make_domu_dt_node(kinfo); >> } >> + >> +int domain_vintc_init(struct domain *d) >> +{ >> + int ret = -EOPNOTSUPP; >> + const enum intc_variant variant = intc_hw_ops->info->hw_variant; >> + >> + switch ( variant ) >> + { >> + case INTC_APLIC: >> + ret = domain_vaplic_init(d); >> + break; >> + >> + default: >> + printk("vintc (variant:%d) isn't implemented\n", variant); > > printk_once() maybe? It makes sense. I will apply your suggestions. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:11:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:11:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349759.1607401 (Exim 4.92) (envelope-from ) id 1wesr5-0000DH-V0; Wed, 01 Jul 2026 11:11:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349759.1607401; Wed, 01 Jul 2026 11:11:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesr5-0000DA-Rc; Wed, 01 Jul 2026 11:11:47 +0000 Received: by outflank-mailman (input) for mailman id 1349759; Wed, 01 Jul 2026 11:11:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesr4-0000D4-CT for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:11:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesr3-0035Nn-PN for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:11:45 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f5e4-5cb7-0a2a0a5109dd-0a2a4503e6fe-32 for ; Wed, 01 Jul 2026 13:11:44 +0200 Received: from [40.107.74.91] (helo=OS0P286CU010.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f5ed-ec1a-0a2a45030019-286b4a5b4f16-3 for ; Wed, 01 Jul 2026 13:11:43 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TYCP286MB3533.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3a8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Wed, 1 Jul 2026 11:11:38 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 11:11:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pdn9aueWxvzjqgdflqG6X8OklWM7Cwg7zzDgrwF18YORjGx6KhaIW9+0fRIKcIS/n2cfYMylK8gqkNbaJQm92VrhYAvW0+2amSiHSFDjmH1uayoaxfuW9TIQrVKJ3pwy8HdGExH+2joUP7zDGx6On6eZLgLxg2Nex/co0ZVDfoqeR/IQ7E0JRKOozO9V2sMOXFoKRFpBrmrCq2CJ+OKhhDkPEnTs10FRbYOwGubc05bx+QKboVphsqISHSTR3AzfhMpWmakqIPB7hZfKi1lGxXgyR1veUTB5ujRUTaDZAAKBMZwcJwauLlEFgup63qyFXAHcoZHMapVN3qUJ87wOFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXBgle9xM1cKViHVNR6Q0Rw1ntSnR4KBBogbLDaQwBY=; b=C0iosgc/GOGIYCm9rwVc1/aA1WYtyBSCAu6rSiStSWHQ5/xfmdjNkwM05QFhMexesMygr1iOm7sDD1GNxc4yJgrvkaXtVQNUybyyCckfVelCyD9V1WFzdx+E9KoWnWMUZSM7FZhQ8V9PGR0zcnTNT1LUowiNBEC9DQUBvD1ii7gH1iNjr2itnkv/VY8xETzMpljSQlCWsEKUTLxWDxLO+3STrdJyfE3rS4VTjKaTuqtU3OHUylnfWJW/0ZUe/L3jkcIiBZka6keFJFKjvWYyj5/z5fZNxYy1u6DeOOv5o2p041ClP05/nAXFDXutHcZYa4KSwcRlT6KctNACETGVCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iXBgle9xM1cKViHVNR6Q0Rw1ntSnR4KBBogbLDaQwBY=; b=eUi0ttREDM1JZLZmxBRmqV2MsZkum02jB2BeGBzlxeAVplXwQaHBOxobXiS6ZeGh3k+YoUdXO8s8Xkpq7k6xteF99s5WfOFwyN68dFS/rKSrsU4wZfglifknhqkhNeRQ6mpLt7FYf4BmrxRmXH+HqFej62WKPWDtXzOGizNNRAA= From: Hirokazu Takahashi To: Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Thread-Topic: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Thread-Index: AQHdCBJguMZzJpb/JEe22XtErI4LcbZWqjWAgAHISeA= Date: Wed, 1 Jul 2026 11:11:37 +0000 Message-ID: References: <20260629215806.11610-1-taka@valinux.co.jp> <20260629215806.11610-2-taka@valinux.co.jp> <97dd9fd5-c0de-4125-a40a-b7f6e1aed27d@suse.com> In-Reply-To: <97dd9fd5-c0de-4125-a40a-b7f6e1aed27d@suse.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS9P286MB7222:EE_|TYCP286MB3533:EE_ x-ms-office365-filtering-correlation-id: 9e597f31-4aef-4ace-2785-08ded7618521 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|23010399003|366016|7416014|376014|1800799024|38070700021|6133799003|22082099003|18002099003|56012099006|4143699003; x-microsoft-antispam-message-info: 4ZvOd0AYVR74yf3KobE+6u+Dw8s+7O5t9QLyL00US1X1Y8QnZhvsBWzBCkSzSeE8PrwBfICVlyEg7ar6s/xxzv8SBTKsiYH/HVLlUcwkQh/7MiRu63pmQFp8Idp2pCMye32lcLnKZYQpQVzzBUv1IA+exgMrdfjN9u1wmfXzlBT9/gItXx6I7Vj+RpAHRwFFmj5rq0fUz9jMlCTPyenCAa+eLwbJjGURmIvgIW35EU/iopAaz/T4LXz+jTE1+57qavvd7O4Sqia0gJs5hqmtna3fm/nuxmlZ6ofdDX7WTdFRodsV6BtNVeTT3t1nhgk9bCCvuF72mVRIpB5ngqL0wHiwDj/AMjBlXEvKMKadZI2BVI031uag9XkdToQQEUcPPM5b6fChM1l5uSQWpf+czj7EnEaNVJ/doQagbIqMyA/ng4rhVAv5f39ByGnQPphVQ0MJec34zTwC+YDNXR2u64uS7U8p5r7u/5cawxzAzgr5FnURnfvgRyYBGCeNxzrK7Gqc2YDJ2R7zhkppk6k7XIhOwin4iH3tDf4u52VdHUauOVGEEpu6ARlsboxqP/SF1nrRmVQtv+NZ6P3HP0CjqostMfJYYS1SD/Mv5ArkVHTjdNNxhPNRR710kwOL/tE3X/E+vvhaM3wNDLoGsyN1uCynZ+dyMtxe3VW0+PDGvkg4RuOIqlABgDcVNMSnmjDNwnvpIXFyzbeK1VgVUHWsxZvqDNXlVCZUiQCWgqbuvZs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(7416014)(376014)(1800799024)(38070700021)(6133799003)(22082099003)(18002099003)(56012099006)(4143699003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WTlZZStSNEhjL3RrQU5pTFZaV1Q1QzBNZlRyS1oxcDBPWnh5Z3ZpdE1Hdklo?= =?utf-8?B?VXlSWUF2UGh2cis4cytGSHJXbG9XTmkxL2Q2dFBEWFlmVSt2YTVrSFd6b3V2?= =?utf-8?B?RjFqQmd1eGdQZWdFRmJJb2dSR3hIT0VqT01HbFcvTENhL1lYNm82MGdqdVJT?= =?utf-8?B?K085ZEtDczZTVmhzajVvTU41cFR6bS90YytiOThlWlNYcWhpY1NjelhjN1FF?= =?utf-8?B?SzE4cm5qUkdiY0FXR25BZUl0MWpWU0YxWVV2V0p0TmZybmRLNUxCU3NpaEtC?= =?utf-8?B?L3lnWTBVRXlPQkJXd051UXpVWmZOQWUwKzBqYjM1Z2d1SUh0WjVWTUNLd2tR?= =?utf-8?B?Y1ZSQmczcUgzWEZqd0d5b3JOSDE3TWJYdExnemR6ZDluOGYyT3dMV09rK284?= =?utf-8?B?ZU1RMzlJNVYxR2JrQmZ5eG1uOUI2cndhOHk1a2JPeWlmQVlyN0lDd1p3YVV4?= =?utf-8?B?T0pGUHJvOEowd1Mxb09TK1ZHYXpvcGZRdmV0allSNGdwNUFzYWxIQ082QTNP?= =?utf-8?B?M2NmZkNvdEs0ZGJubzdFZlcrRElOOVFReVFGZmNtY2VJeEsxWE5VVXVPSU9N?= =?utf-8?B?VktKWm0rdUhHY0pKZVhtTTFwM1BQKzdEdUdBU24wM1VlZVpQUVF6aTFTd3M2?= =?utf-8?B?VUJkOGJYajhJRFRTbzZoUE8yZjhmUVZtdmErQ3I3VlV3dWdZSCt5aGtXNS93?= =?utf-8?B?b1NraUVqdmtpUjB4SUhkRHFqN3VFMGJwcHlGZHhYRExRV2VVSVc2OThTVklt?= =?utf-8?B?aE1tb3BvN25EVStCeGowNGZQenllT1Q2d1pSSHgxNDFQMHhnTWNiRFBTYUlF?= =?utf-8?B?elc3L2gvK2lMMDlpMk8xSGY1TUJ1TU1HU01ya1R4emJ4RXM3cmtTSjhmRXFz?= =?utf-8?B?cDh5clh2djdXT3lxczFURHdqdWlqNG9rTHY3SldoOTVmTnFEMndjMWFJSWJj?= =?utf-8?B?VGplb1JUK2JYVEpUQzJScjVHL3p3MnJaUU9DZ0FsN0hseHFlTVpjM0c5QjZV?= =?utf-8?B?WG5sMUE1R1FINmVKeXk0cXpnbVBLSEFpQnVyTzVFYVZibTNQMUw1T3ZSa2NE?= =?utf-8?B?NWZFMFdqb2JUUWtLbWgySHlNdkwxTWYzZ1J5WmxMV0owMTRZZlNaaTByMmNt?= =?utf-8?B?WDFpM2V5cEJ4TENMaUtVOE43T0tBamZwSHRKdVpaaXlYZS9LZi84cmkyN1hY?= =?utf-8?B?NHhoSVVsZDBKQUgzdGFJV1FIbWNBWWJQcWlYYlJJYzJzUHZXRkJhU3VPWXUz?= =?utf-8?B?d2liSFltWFhPU3QxVzRTRzRsQXBya0taL1k0bWMxank0ajBwOW9mVTc1aU0v?= =?utf-8?B?MjBBY1dNMnRtSm9qSDNKL296Sm1pWkkrWmRIKyt0TnJsNjBRNkV3SDA4RnVI?= =?utf-8?B?bURML0d2Nmt0NC92WDhJbmZvYWNNUkphU3pGTHVHSlZHaGw5a3JMTGtkMGNE?= =?utf-8?B?cllvb0cxamFWcTcvWjBvcGowMVZqdHFJaWl2QXpoNVhxazV2OHdNRThrU05W?= =?utf-8?B?cHBja01SWkgxdzJsRFNHbVJPME11dTJSN25pU0dmZGE5R05SRG1LK2dsMnBr?= =?utf-8?B?WTNLemk1Ty9KM0hqWTRqRklyWThEM0VUNm5pc2JMRVIvV2EyUSt6RDJlb0x2?= =?utf-8?B?MUhweFlnSnp2eXd0RkZGZU0vTHQwYlhLRTBnUmkvam5uRGxKdXl2U0taQ3V3?= =?utf-8?B?YWpNNXg2bmNzWkJEMFQxanN1LzNqeTFsWFpDZ3VMU0h1K1d2NEdWak1YTlNY?= =?utf-8?B?RExkVmRlZ2hqRkd4M2JDVzFNNG0xNmh1VHl1bGpSTVAyQU16Vkd2eEVCUi9x?= =?utf-8?B?S0o5RzUzbEVaSHBaUEFEMmc3ZEJ3WVduU0dSY3dOcXI3UTdueVZTME4rbXJ3?= =?utf-8?B?WGZqVElnVEVzNTN2anRXc1ppOHhsV0diZ0J4ODJxRVBpVzlOS09CV08zNnNC?= =?utf-8?B?Szk4TUNxSGI0SEhlTEExa1RNTDc4Z1YrSXZ0ejlLL2dieDVjdjIvM1UrVXdZ?= =?utf-8?B?bU1lTUxWZHJQZFFOOU1RcG9YbWxudjYzRjdZZzdpRzNjSUFGc0JzRG9CNk5j?= =?utf-8?B?RzB4NUhBMzlNU0JTQkZWMHZRb3p5aUw2YlU3Sm5IcWsvNTljNi9OeW1IdllE?= =?utf-8?B?dTczU0g3cktseXRObHByb3hGWGZVTFc4K01mRG83NkdFbzBRR0FBTlNFOUxM?= =?utf-8?B?eEhCRVpqL0NURmZGZ2VIQm5acURqN3kySkVyWTVGWWV2RG1RWmhobm9ITnRM?= =?utf-8?B?UXdPaGVkajNBdEtEL2tIRk4yNktMaHRmWkY1WFNaT3FPVXVwN0hxTXlxazkr?= =?utf-8?Q?rwnRgNtrMGGglpYLfQ?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 9e597f31-4aef-4ace-2785-08ded7618521 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2026 11:11:37.8441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WVvU5/6fBB5rLXa5fE743EgQ4Vx+Mbu8+atKNemn/02RPxe/6RxRzkuueN3s3KaQVsfvy8vd1rISgW179bqyrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB3533 X-purgate-ID: tlsNG-33051d/1782904304-BC7875D1-A664816E/0/0 X-purgate-type: clean X-purgate-size: 15748 SGVsbG8sDQoNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiA+ICsrKyBiL3hlbi9h cmNoL2FybS9LY29uZmlnDQo+ID4gQEAgLTEwMSw2ICsxMDEsMTYgQEAgZW5kY2hvaWNlDQo+ID4N Cj4gPiAgc291cmNlICJhcmNoL0tjb25maWciDQo+ID4NCj4gPiArY29uZmlnIEFSTV9DUFVfVE9Q T0xPR1kNCj4gPiArCWJvb2wgIkNQVSB0b3BvbG9neSBzdXBwb3J0IChVTlNVUFBPUlRFRCkiIGlm IFVOU1VQUE9SVEVEDQo+ID4gKwlzZWxlY3QgQ1BVX1RPUE9MT0dZDQo+ID4gKwloZWxwDQo+ID4g KwkgIFJldHJpZXZlIENQVSB0b3BvbG9neSBpbmZvcm1hdGlvbiBmcm9tIHRoZSBkZXZpY2UgdHJl ZSB0byBvcHRpbWl6ZQ0KPiA+ICsJICB2aXJ0dWFsIENQVSBzY2hlZHVsaW5nLg0KPiA+ICsNCj4g PiArCSAgTm90ZTogSW1wbGVtZW50YXRpb24gZm9yIHBhcnNpbmcgQ1BVIHRvcG9sb2d5IGZyb20g dGhlIEFDUEkgUFBUVA0KPiA+ICsJICBpcyBjdXJyZW50bHkgbWlzc2luZy4NCj4gDQo+IFRoaXMg b3B0aW9uIGlzbid0IGl0c2VsZiB1c2VkIGFueXdoZXJlOyBpdCBleGlzdHMgc29sZWx5IGZvciBp dHMgInNlbGVjdCINCj4gZWZmZWN0LiBTaW5jZSB0b3BvbG9neSBpcyBhbiBhcmNoLWluZGVwZW5k ZW50IGNvbmNlcHQsIEknZCBzdWdnZXN0DQo+IENQVV9UT1BPTE9HWSB0byBoYXZlIHRoZSBwcm9t cHQgYW5kIGhlbHAgdGV4dCwgYW5kIHRoZXJlIGJlaW5nIGEgcGVyLWFyY2gNCj4gSEFTX0NQVV9U T1BPTE9HWSAob3IgbWF5YmUgSEFTX0dFTkVSSUNfQ1BVX1RPUE9MT0dZLCB0byBhdm9pZCB0aGUg ZmFsc2UNCj4gaW1wcmVzc2lvbiB0aGF0IHg4NiBkb2Vzbid0IGRlYWwgd2l0aCB0b3BvbG9neSkg d2hpY2ggQ1BVX1RPUE9MT0dZIHRoZW4NCj4gZGVwZW5kcyBvbi4NCg0KVGhhdCBpcyBhIGdvb2Qg aWRlYS4NCkkgd2lsbCB1c2UgdGhpcyBhcHByb2FjaC4NCg0KPiA+IC0tLSBhL3hlbi9jb21tb24v S2NvbmZpZw0KPiA+ICsrKyBiL3hlbi9jb21tb24vS2NvbmZpZw0KPiA+IEBAIC0xODgsNiArMTg4 LDE0IEBAIGNvbmZpZyBWTV9FVkVOVA0KPiA+ICBjb25maWcgTkVFRFNfTElCRUxGDQo+ID4gIAli b29sDQo+ID4NCj4gPiArY29uZmlnIERUX0NQVV9UT1BPTE9HWQ0KPiA+ICsJYm9vbA0KPiA+ICsN Cj4gPiArY29uZmlnIENQVV9UT1BPTE9HWQ0KPiA+ICsJYm9vbA0KPiA+ICsJc2VsZWN0IERUX0NQ VV9UT1BPTE9HWSBpZiBERVZJQ0VfVFJFRV9QQVJTRQ0KPiA+ICsJc2VsZWN0IEFDUElfQ1BVX1RP UE9MT0dZIGlmIEFDUEkNCj4gDQo+IEFzIHBlciBwYXJ0IG9mIHdoYXQgSSBzYWlkIGFib3ZlLCB0 aGlzIG1heSBhbHNvIHdhbnQgdG8gYmUNCj4gR0VORVJJQ19DUFVfVE9QT0xPR1kNCj4gb3Igc29t ZSBzdWNoLiBPdGhlciBtYWludGFpbmVycycgaW5wdXQgbWF5IGJlIHdhbnRlZCBoZXJlLg0KDQpP a2F5Lg0KDQo+ID4gLS0tIGEveGVuL2NvbW1vbi9NYWtlZmlsZQ0KPiA+ICsrKyBiL3hlbi9jb21t b24vTWFrZWZpbGUNCj4gPiBAQCAtNSw2ICs1LDcgQEAgb2JqLSQoQ09ORklHX0dFTkVSSUNfQlVH X0ZSQU1FKSArPSBidWcubw0KPiA+ICBvYmotJChDT05GSUdfSFlQRlNfQ09ORklHKSArPSBjb25m aWdfZGF0YS5vDQo+ID4gIG9iai0kKENPTkZJR19DT1JFX1BBUktJTkcpICs9IGNvcmVfcGFya2lu Zy5vDQo+ID4gIG9iai15ICs9IGNwdS5vDQo+ID4gK29iai0kKENPTkZJR19DUFVfVE9QT0xPR1kp ICs9IGNwdS10b3BvbG9neS5vDQo+IA0KPiBBcyBsZWFzdCBmb3Igbm93IHRoaXMgbWF5IHdhbnQg dG8gYmUNCj4gDQo+IG9iai1iaW4tJChDT05GSUdfQ1BVX1RPUE9MT0dZKSArPSBjcHUtdG9wb2xv Z3kuaW5pdC5vDQoNCk9rYXkuDQoNCj4gc2VlaW5nIHRoYXQgLi4uDQo+IA0KPiA+IC0tLSAvZGV2 L251bGwNCj4gPiArKysgYi94ZW4vY29tbW9uL2NwdS10b3BvbG9neS5jDQo+ID4gQEAgLTAsMCAr MSw1OSBAQA0KPiA+ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1vci1sYXRl ciAqLw0KPiA+ICsNCj4gPiArI2luY2x1ZGUgPHhlbi9hY3BpLmg+DQo+ID4gKyNpbmNsdWRlIDx4 ZW4vY3B1LXRvcG9sb2d5Lmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vY3B1bWFzay5oPg0KPiA+ICsj aW5jbHVkZSA8eGVuL2luaXQuaD4NCj4gPiArDQo+ID4gK3N0YXRpYyB2b2lkIF9faW5pdCBmcmVl X3RvcG9sb2d5X3RhYmxlKHZvaWQpDQo+ID4gK3sNCj4gPiArICAgIHVuc2lnbmVkIGludCBjcHU7 DQo+ID4gKw0KPiA+ICsgICAgZm9yICggY3B1ID0gMDsgY3B1IDwgbnJfY3B1X2lkczsgY3B1Kysg KQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGZyZWVfY3B1bWFza192YXIoY3B1X3RvcG9sb2d5 W2NwdV0udGhyZWFkX3NpYmxpbmcpOw0KPiA+ICsgICAgICAgIGZyZWVfY3B1bWFza192YXIoY3B1 X3RvcG9sb2d5W2NwdV0uY29yZV9zaWJsaW5nKTsNCj4gPiArICAgICAgICBmcmVlX2NwdW1hc2tf dmFyKGNwdV90b3BvbG9neVtjcHVdLmNsdXN0ZXJfc2libGluZyk7DQo+ID4gKyAgICB9DQo+ID4g Kw0KPiA+ICsgICAgWEZSRUUoY3B1X3RvcG9sb2d5KTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArdm9p ZCBfX2luaXQgaW5pdF9jcHVfdG9wb2xvZ3kodm9pZCkNCj4gPiArew0KPiA+ICsgICAgdW5zaWdu ZWQgaW50IGNwdTsNCj4gPiArDQo+ID4gKyAgICBjcHVfdG9wb2xvZ3kgPSB4emFsbG9jX2FycmF5 KHN0cnVjdCBjcHVfdG9wb2xvZ3ksIG5yX2NwdV9pZHMpOw0KPiA+ICsgICAgaWYgKCAhY3B1X3Rv cG9sb2d5ICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiRmFp bGVkIHRvIGFsbG9jYXRlIG1lbW9yeSBmb3IgY3B1X3RvcG9sb2d5IHRhYmxlXG4iKTsNCj4gPiAr ICAgICAgICByZXR1cm47DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgZm9yICggY3B1ID0g MDsgY3B1IDwgbnJfY3B1X2lkczsgY3B1KysgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGlm ICggIXphbGxvY19jcHVtYXNrX3ZhcigmY3B1X3RvcG9sb2d5W2NwdV0udGhyZWFkX3NpYmxpbmcp IHx8DQo+ID4gKyAgICAgICAgICAgICAhemFsbG9jX2NwdW1hc2tfdmFyKCZjcHVfdG9wb2xvZ3lb Y3B1XS5jb3JlX3NpYmxpbmcpIHx8DQo+ID4gKyAgICAgICAgICAgICAhemFsbG9jX2NwdW1hc2tf dmFyKCZjcHVfdG9wb2xvZ3lbY3B1XS5jbHVzdGVyX3NpYmxpbmcpICkNCj4gPiArICAgICAgICB7 DQo+ID4gKyAgICAgICAgICAgIGZyZWVfdG9wb2xvZ3lfdGFibGUoKTsNCj4gPiArICAgICAgICAg ICAgcHJpbnRrKFhFTkxPR19FUlIgIkZhaWxlZCB0byBhbGxvY2F0ZSBtZW1vcnkgZm9yIGNwdV90 b3BvbG9neSB0YWJsZVxuIik7DQo+ID4gKyAgICAgICAgICAgIHJldHVybjsNCj4gPiArICAgICAg ICB9DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgaWYgKCBhY3BpX2Rpc2FibGVkICkNCj4g PiArICAgICAgICBkdF9pbml0X2NwdV90b3BvbG9neSgpOw0KPiA+ICsgICAgZWxzZQ0KPiA+ICsg ICAgICAgIGFjcGlfaW5pdF9jcHVfdG9wb2xvZ3koKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArLyoN Cj4gPiArICogTG9jYWwgdmFyaWFibGVzOg0KPiA+ICsgKiBtb2RlOiBDDQo+ID4gKyAqIGMtZmls ZS1zdHlsZTogIkJTRCINCj4gPiArICogYy1iYXNpYy1vZmZzZXQ6IDQNCj4gPiArICogdGFiLXdp ZHRoOiA0DQo+ID4gKyAqIGluZGVudC10YWJzLW1vZGU6IG5pbA0KPiA+ICsgKiBFbmQ6DQo+ID4g KyAqLw0KPiANCj4gLi4uIHRoZXJlIGFyZSBvbmx5IF9faW5pdCBmdW5jdGlvbnMgaGVyZS4NCj4g DQo+ID4gLS0tIGEveGVuL2NvbW1vbi9kZXZpY2UtdHJlZS9NYWtlZmlsZQ0KPiA+ICsrKyBiL3hl bi9jb21tb24vZGV2aWNlLXRyZWUvTWFrZWZpbGUNCj4gPiBAQCAtMSw2ICsxLDcgQEANCj4gPiAg b2JqLXkgKz0gYm9vdGZkdC5pbml0Lm8NCj4gPiAgb2JqLSQoQ09ORklHX0hBU19ERVZJQ0VfVFJF RV9ESVNDT1ZFUlkpICs9IGJvb3RpbmZvLWZkdC5pbml0Lm8NCj4gPiAgb2JqLSQoQ09ORklHX0hB U19ERVZJQ0VfVFJFRV9ESVNDT1ZFUlkpICs9IGJvb3RpbmZvLmluaXQubw0KPiA+ICtvYmotJChD T05GSUdfRFRfQ1BVX1RPUE9MT0dZKSArPSBjcHUtdG9wb2xvZ3kubw0KPiANCj4gU2FtZSBoZXJl LCBhbGJlaXQgcmVxdWlyaW5nIC4uLg0KDQpPa2F5LiANCg0KPiA+IC0tLSAvZGV2L251bGwNCj4g PiArKysgYi94ZW4vY29tbW9uL2RldmljZS10cmVlL2NwdS10b3BvbG9neS5jDQo+ID4gQEAgLTAs MCArMSwzNTIgQEANCj4gPiArLyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb3It bGF0ZXIgKi8NCj4gPiArLyoNCj4gPiArICogRGVyaXZlZCBmcm9tIExpbnV4IGtlcm5lbCA3LjAn cyAkZHJpdmVycy9iYXNlL2FyY2hfdG9wb2xvZ3kuYw0KPiA+ICsgKiBQYXJzZSBjcHUgdG9wb2xv Z3kgaW5mb3JtYXRpb24uDQo+ID4gKyAqLw0KPiA+ICsNCj4gPiArI2luY2x1ZGUgPHhlbi9hY3Bp Lmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vY3B1LXRvcG9sb2d5Lmg+DQo+ID4gKyNpbmNsdWRlIDx4 ZW4vY3B1bWFzay5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL2RldmljZV90cmVlLmg+DQo+ID4gKyNp bmNsdWRlIDx4ZW4vZXJybm8uaD4NCj4gPiArI2luY2x1ZGUgPHhlbi9pbml0Lmg+DQo+ID4gKyNp bmNsdWRlIDx4ZW4vbnVtYS5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL3h2bWFsbG9jLmg+DQo+ID4g Kw0KPiA+ICtzdHJ1Y3QgY3B1X21hcCB7DQo+ID4gKyAgICB1bnNpZ25lZCBpbnQgdGhyZWFkX2lk Ow0KPiA+ICsgICAgdW5zaWduZWQgaW50IGNvcmVfaWQ7DQo+ID4gKyAgICB1bnNpZ25lZCBpbnQg Y2x1c3Rlcl9pZDsNCj4gPiArICAgIHVuc2lnbmVkIGludCBwYWNrYWdlX2lkOw0KPiA+ICt9Ow0K PiA+ICsNCj4gPiArc3RydWN0IGNwdV90b3BvbG9neSAqY3B1X3RvcG9sb2d5Ow0KPiANCj4gLi4u IHRoaXMgKHdoaWNoIG91Z2h0IHRvIGJlIF9fcm9fYWZ0ZXJfaW5pdCBhbnl3YXkpIHRvIGJlIG1v dmVkIGVsc2V3aGVyZS4NCj4gDQo+ID4gK3N0YXRpYyBjb25zdCB1bnNpZ25lZCBpbnQgX19pbml0 ZGF0YSBpbnZhbGlkX3RvcG9faWQgPSAofjBVKTsNCj4gDQo+IE5pdDogV2hhdCB1c2UgYXJlIHRo ZSBwYXJlbnRoZXNlcyBoZXJlPyBUaGlzIG1heSB3YW50IHRvIGJlIGEgI2RlZmluZSAod2l0aA0K PiB0aGUgaWRlbnRpZmllciBhbGwgdXBwZXJjYXNlKSwgaW4gd2hpY2ggY2FzZSB0aGUgcGFyZW50 aGVzZXMgbmVlZCBrZWVwaW5nLg0KDQpPa2F5Lg0KDQo+ID4gK3ZvaWQgX19pbml0IG1hcF9jcHVp ZF90b19ub2RlKHVuc2lnbmVkIGludCBjcHVpZCwNCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc3RydWN0IGR0X2RldmljZV9ub2RlICpjcHVfbm9kZSkNCj4gPiArew0KPiA+ICsg ICAgaWYgKCBjcHVpZCA8IE5SX0NQVVMgKQ0KPiANCj4gQmV0dGVyIHVzZSBBUlJBWV9TSVpFKCkg d2hlbiAuLi4NCg0KT2theS4NCg0KPiA+ICsgICAgICAgIGR0X2NwdV90YWJsZVtjcHVpZF0gPSBj cHVfbm9kZTsNCj4gDQo+IC4uLiBhbiBhcnJheSBhY2Nlc3MgaXMgZ3VhcmRlZC4NCj4gDQo+IEp1 c3QgZm9yIG15IG93biB1bmRlcnN0YW5kaW5nOiBJdCBpcyBkZWxpYmVyYXRlIGZvciBjcHVpZCA+ PSBOUl9DUFVTIHRvIGdvDQo+IGVudGlyZWx5IHNpbGVudGx5IGhlcmU/DQoNCkkgd2lsbCBhZGQg cHJpbnRrIHRvIHJlcG9ydCB0aGUgZXJyb3IuDQoNCj4gQXMgdG8gImNwdWlkIiAtIHBsZWFzZSBj YW4gdGhpcyBiZSAiY3B1IiwgYXMgeW91IGhhdmUgaXQgZWxzZXdoZXJlLiAiY3B1aWQiDQo+IGlz IGEgbWlzbGVhZGluZyB0ZXJtIGhlcmUgd2hlbiB4ODYgY29tZXMgaW50byBwbGF5Lg0KDQpPa2F5 Lg0KDQo+ID4gK3N0YXRpYyB1bnNpZ25lZCBpbnQgX19pbml0IGNwdV9ub2RlX3RvX2lkKHN0cnVj dCBkdF9kZXZpY2Vfbm9kZSAqY3B1X25vZGUpDQo+ID4gK3sNCj4gPiArICAgIHVuc2lnbmVkIGlu dCBjcHU7DQo+ID4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7DQo+IA0KPiBQb2ludGxlc3MgaW5p dGlhbGl6ZXI7IGluIGZhY3QgLi4uDQo+IA0KPiA+ICsgICAgZm9yX2VhY2hfcG9zc2libGVfY3B1 KGNwdSkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBmb3VuZCA9IChjcHVfbm9kZSA9PSBkdF9j cHVfdGFibGVbY3B1XSk7DQo+IA0KPiAuLi4gdGhlIGRlY2xhcmF0aW9uIGNvdWxkIG1vdmUgaGVy ZSwgb3IgLSBiZXR0ZXIgeWV0IC0gY291bGQgYmUgb21pdHRlZA0KPiBhbHRvZ2V0aGVyLCBhcyB0 aGUgdmFyaWFibGUgaXMgdXNlZCAuLi4NCj4gDQo+ID4gKyAgICAgICAgaWYgKCBmb3VuZCApDQo+ IA0KPiAuLi4gZXhhY2x5IG9uY2UuDQoNCk9rYXksIEkgd2lsbCByZW1vdmUgdGhpcyB2YXJpYWJs ZS4NCiANCj4gPiArLyoNCj4gPiArICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIHRoZSBsb2dpYyBj cHUgbnVtYmVyIG9mIHRoZSBub2RlLg0KPiANCj4gTml0OiAibG9naWNhbCI/IEFsc28gIm9mIHRo ZSBub2RlIiBpcyBtaXNsZWFkaW5nICh0b3dhcmRzIE5VTUEpLCAib2YgdGhlIERUDQo+IG5vZGUi IHdvdWxkIGJlIHVuYW1iaWd1b3VzLg0KDQpPa2F5Lg0KIA0KPiA+ICsgKi8NCj4gPiArc3RhdGlj IHVuc2lnbmVkIGludCBfX2luaXQgZ2V0X2NwdV9mb3Jfbm9kZShzdHJ1Y3QgZHRfZGV2aWNlX25v ZGUgKm5vZGUpDQo+IA0KPiBQb2ludGVyLXRvLWNvbnN0Pw0KDQpEbyB5b3UgbWVhbiB0aGlzIHNo b3VsZCBiZSByZXBsYWNlZCB3aXRoIHRoZSBmb2xsb3dpbmcgbGluZT8NCnN0YXRpYyB1bnNpZ25l ZCBpbnQgX19pbml0IGdldF9jcHVfZm9yX25vZGUoc3RydWN0IGR0X2RldmljZV9ub2RlICpjb25z dCBub2RlKQ0KIA0KPiA+ICt7DQo+ID4gKyAgICBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmNwdV9u b2RlID0gZHRfcGFyc2VfcGhhbmRsZShub2RlLCAiY3B1IiwgMCk7DQo+IA0KPiBBZ2Fpbj8gR2Vu ZXJhbGx5IGV2ZXJ5d2hlcmUgdGhhdCBpdCBpcyBwb3NzaWJsZSBhbmQgc2Vuc2libGUuDQoNCk9r YXkuIEkgd2lsbCBjaGVjayBpZiBvdGhlciBjb2RlcyBoYXZlIHBvaW50ZXJzIHRoYXQgY2FuIGJl IGNvbnN0Lg0KDQo+ID4gKyAgICBpZiAoICFjcHVfbm9kZSApDQo+ID4gKyAgICAgICAgcmV0dXJu IGludmFsaWRfdG9wb19pZDsNCj4gPiArDQo+ID4gKyAgICByZXR1cm4gY3B1X25vZGVfdG9faWQo Y3B1X25vZGUpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9j b3JlKHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqY29yZSwNCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB1bnNpZ25lZCBpbnQgcGFja2FnZV9pZCwNCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgY2x1c3Rlcl9pZCwNCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgY29yZV9pZCkNCj4gPiArew0KPiA+ICsgICAg Y2hhciBuYW1lWzIwXTsNCj4gDQo+IE1vdmUgdG8gdGhlIG1vcmUgbmFycm93IHNjb3BlIGl0J3Mg dXNlZCBpbj8gKEFnYWluIHBsZWFzZSB0YWtlIGFzIGEgZ2VuZXJhbCByZW1hcmsuKQ0KDQpPa2F5 Lg0KDQo+ID4gKyAgICBib29sIGxlYWYgPSB0cnVlOw0KPiA+ICsgICAgdW5zaWduZWQgaW50IGkg PSAwOw0KPiA+ICsgICAgdW5zaWduZWQgaW50IGNwdTsNCj4gPiArDQo+ID4gKyAgICBkbyB7DQo+ ID4gKyAgICAgICAgc3RydWN0IGR0X2RldmljZV9ub2RlICp0Ow0KPiA+ICsNCj4gPiArICAgICAg ICBzbnByaW50ZihuYW1lLCBzaXplb2YobmFtZSksICJ0aHJlYWQldSIsIGkpOw0KPiA+ICsgICAg ICAgIHQgPSBkdF9maW5kX2NoaWxkX25vZGVfYnlfbmFtZShjb3JlLCBuYW1lKTsNCj4gPiArDQo+ ID4gKyAgICAgICAgaWYgKCAhdCApDQo+ID4gKyAgICAgICAgICAgIGJyZWFrOw0KPiA+ICsNCj4g PiArICAgICAgICBsZWFmID0gZmFsc2U7DQo+ID4gKyAgICAgICAgY3B1ID0gZ2V0X2NwdV9mb3Jf bm9kZSh0KTsNCj4gPiArICAgICAgICBpZiAoIGNwdSAhPSBpbnZhbGlkX3RvcG9faWQgKQ0KPiA+ ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgY3B1X21hcFtjcHVdLnBhY2thZ2VfaWQgPSBw YWNrYWdlX2lkOw0KPiA+ICsgICAgICAgICAgICBjcHVfbWFwW2NwdV0uY2x1c3Rlcl9pZCA9IGNs dXN0ZXJfaWQ7DQo+ID4gKyAgICAgICAgICAgIGNwdV9tYXBbY3B1XS5jb3JlX2lkID0gY29yZV9p ZDsNCj4gPiArICAgICAgICAgICAgY3B1X21hcFtjcHVdLnRocmVhZF9pZCA9IGk7DQo+ID4gKyAg ICAgICAgfQ0KPiA+ICsgICAgICAgIGVsc2UNCj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAg ICAgIHByaW50ayhYRU5MT0dfRVJSICJFUlJPUjogJXBPRjogQ2FuJ3QgZ2V0IENQVSBmb3IgdGhy ZWFkXG4iLCB0KTsNCj4gDQo+IEkgZG9uJ3QgdGhpbmsgd2Ugc3VwcG9ydCAlcE9GIChqdXN0IHll dCkuDQoNCkkgd2lsbCB1c2UgZHRfbm9kZV9uYW1lKCkgaW5zdGVhZC4NCiANCj4gPiAtLS0gYS94 ZW4vZHJpdmVycy9hY3BpL01ha2VmaWxlDQo+ID4gKysrIGIveGVuL2RyaXZlcnMvYWNwaS9NYWtl ZmlsZQ0KPiA+IEBAIC0xMCwzICsxMCw1IEBAIG9iai0kKENPTkZJR19QTV9PUCkgKz0gcG0tb3Au bw0KPiA+DQo+ID4gIG9iai0kKENPTkZJR19YODYpICs9IGh3cmVncy5vDQo+ID4gIG9iai0kKENP TkZJR19YODYpICs9IHJlYm9vdC5vDQo+ID4gKw0KPiA+ICtvYmotJChDT05GSUdfQUNQSV9DUFVf VE9QT0xPR1kpICs9IHRvcG9sb2d5Lm8NCj4gDQo+IFNlZSBlYXJsaWVyIHJlbWFya3MgYXMgdG8g b2JqZWN0IGNvbnRhaW5pbmcgb25seSBfX2luaXQgY29kZS4gQWxzbyB0aGlzIG1heQ0KPiBiZXR0 ZXIgYmUgYXBwZW5kZWQgKHdpdGhvdXQgYSBibGFuayBsaW5lKSB0byB0aGUgZWFybGllciBibG9j ayBvZiBvYmplY3RzLg0KDQpPa2F5Lg0KIA0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi94 ZW4vaW5jbHVkZS94ZW4vY3B1LXRvcG9sb2d5LmgNCj4gPiBAQCAtMCwwICsxLDM1IEBADQo+ID4g Ky8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wLW9ubHkgKi8NCj4gPiArDQo+ID4g KyNpZm5kZWYgWEVOX0NQVV9UT1BPTE9HWV9IDQo+ID4gKyNkZWZpbmUgWEVOX0NQVV9UT1BPTE9H WV9IDQo+ID4gKw0KPiA+ICsjaW5jbHVkZSA8eGVuL2R0LWNwdS10b3BvbG9neS5oPg0KPiA+ICsN Cj4gPiArc3RydWN0IGNwdV90b3BvbG9neSB7DQo+ID4gKyAgICBjcHVtYXNrX3Zhcl90IHRocmVh ZF9zaWJsaW5nOw0KPiA+ICsgICAgY3B1bWFza192YXJfdCBjb3JlX3NpYmxpbmc7DQo+ID4gKyAg ICBjcHVtYXNrX3Zhcl90IGNsdXN0ZXJfc2libGluZzsNCj4gDQo+IEZvciB0aGVzZSB0byBjb21w aWxlIGluZGVwZW5kZW50IG9mIHdoYXQgI2luY2x1ZGUtcyBvY2N1cnJlZCBlYXJsaWVyIGluIHRo ZQ0KPiB0b3AtbGV2ZWwgLmMgZmlsZSwgZG9uJ3QgeW91IG5lZWQgdG8gYWxzbyAiI2luY2x1ZGUg PHhlbi9jcHVtYXNrLmg+Ij8gT3RvaA0KPiBJIGNhbid0IHF1aXRlIHNwb3Qgd2h5IHlvdSAjaW5j bHVkZSB4ZW4vZHQtY3B1LXRvcG9sb2d5LmggaGVyZS4NCg0KT2theS4NCg0KPiBGdXJ0aGVyIHNo b3VsZG4ndCB0aGlzIG1vdmUgLi4uDQo+IA0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArI2lmZGVmIENP TkZJR19DUFVfVE9QT0xPR1kNCj4gDQo+IC4uLiBoZXJlPw0KDQpPa2F5Lg0KDQo+ID4gK2V4dGVy biBzdHJ1Y3QgY3B1X3RvcG9sb2d5ICpjcHVfdG9wb2xvZ3k7DQo+ID4gK3ZvaWQgaW5pdF9jcHVf dG9wb2xvZ3kodm9pZCk7DQo+ID4gKw0KPiA+ICsjZWxzZSAvKiBDT05GSUdfQ1BVX1RPUE9MT0dZ ICovDQo+ID4gKw0KPiA+ICsjZGVmaW5lIGNwdV90b3BvbG9neSAoKHN0cnVjdCBjcHVfdG9wb2xv Z3kgKilOVUxMKQ0KPiANCj4gV2h5IGV4YWN0bHkgaXMgdGhpcyBuZWVkZWQ/IEl0IHZlcnkgbXVj aCBsb29rcyBhcyBpZiBpdHMgcHJlc2VuY2UgbWF5IGhpZGUgYnVncy4NCg0KSW4gdGhlIGN1cnJl bnQgY29kZSwgdGhlIGNvbmRpdGlvbiBpZiAoIGNwdV90b3BvbG9neSApIGlzIHVzZWQgdG8gY292 ZXIgYm90aCBjYXNlczoNCndoZW4gQ09ORklHX0NQVV9UT1BPTE9HWSBpcyBkaXNhYmxlZCwgYW5k IHdoZW4gbWVtb3J5IGFsbG9jYXRpb24gZm9yDQp0b3BvbG9neSB0YWJsZSBmYWlscy4gDQoNClRo ZSBuZXh0IHBhdGNoIHVzZXMgaWYgKCBjcHVfdG9wb2xvZ3kgKS4NCg0Kc3RhdGljIGludCBzZXR1 cF9jcHVfc2libGluZ19tYXAoaW50IGNwdSkNCnsNCiAgICBpZiAoICF6YWxsb2NfY3B1bWFza192 YXIoJnBlcl9jcHUoY3B1X3NpYmxpbmdfbWFzaywgY3B1KSkgfHwNCiAgICAgICAgICF6YWxsb2Nf Y3B1bWFza192YXIoJnBlcl9jcHUoY3B1X2NvcmVfbWFzaywgY3B1KSkgKQ0KICAgICAgICByZXR1 cm4gLUVOT01FTTsNCg0KICAgIGlmICggY3B1X3RvcG9sb2d5ICkNCiAgICB7DQogICAgICAgIGNw dW1hc2tfY29weShwZXJfY3B1KGNwdV9zaWJsaW5nX21hc2ssIGNwdSksDQogICAgICAgICAgICAg ICAgICAgICBjcHVfdG9wb2xvZ3lbY3B1XS50aHJlYWRfc2libGluZyk7DQogICAgICAgIGNwdW1h c2tfY29weShwZXJfY3B1KGNwdV9jb3JlX21hc2ssIGNwdSksDQogICAgICAgICAgICAgICAgICAg ICBjcHVfdG9wb2xvZ3lbY3B1XS5jb3JlX3NpYmxpbmcpOw0KICAgIH0NCiAgICBlbHNlDQogICAg ew0KICAgICAgICAvKg0KICAgICAgICAgKiBJZiBDT05GSUdfQ1BVX1RPUE9MT0dZIGlzIGRpc2Fi bGVkLCBpdCBpcyBhc3N1bWVkIHRoYXQNCiAgICAgICAgICogYWxsIENQVXMgcmVzaWRlIGluIHRo ZSBzYW1lIHNvY2tldCBhbmQgdGhhdCBTTVQgaXMgbm90IHVzZWQuDQogICAgICAgICAqLw0KICAg ICAgICBjcHVtYXNrX3NldF9jcHUoY3B1LCBwZXJfY3B1KGNwdV9zaWJsaW5nX21hc2ssIGNwdSkp Ow0KICAgICAgICBjcHVtYXNrX2NvcHkocGVyX2NwdShjcHVfY29yZV9tYXNrLCBjcHUpLCAmY3B1 X3Bvc3NpYmxlX21hcCk7DQogICAgfQ0KDQogICAgcmV0dXJuIDA7DQp9DQoNCj4gPiAtLS0gL2Rl di9udWxsDQo+ID4gKysrIGIveGVuL2luY2x1ZGUveGVuL2R0LWNwdS10b3BvbG9neS5oDQo+ID4g QEAgLTAsMCArMSwyOSBAQA0KPiA+ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIu MC1vbmx5ICovDQo+ID4gKw0KPiA+ICsjaWZuZGVmIFhFTl9EVF9DUFVfVE9QT0xPR1lfSA0KPiA+ ICsjZGVmaW5lIFhFTl9EVF9DUFVfVE9QT0xPR1lfSA0KPiA+ICsNCj4gPiArI2luY2x1ZGUgPHhl bi9kZXZpY2VfdHJlZS5oPg0KPiANCj4gQWdhaW4gSSBjYW4ndCBxdWl0ZSBzZWUgd2h5IHRoaXMg d291bGQgYmUgbmVlZGVkLiBZb3UgbmVlZCBhIGZvcndhcmQtZGVjbCBvZiAuLi4NCj4gDQo+ID4g KyNpZmRlZiBDT05GSUdfRFRfQ1BVX1RPUE9MT0dZDQo+ID4gKw0KPiA+ICt2b2lkIG1hcF9jcHVp ZF90b19ub2RlKHVuc2lnbmVkIGludCBjcHVpZCwgc3RydWN0IGR0X2RldmljZV9ub2RlICpjcHVf bm9kZSk7DQo+IA0KPiAuLi4gc3RydWN0IGR0X2RldmljZV9ub2RlLCB5ZXMsIGJ1dCB0aGF0J3Mg YWxsLg0KDQpPa2F5Lg0KDQpUaGFuayB5b3UsDQpIaXJva2F6dSBUYWthaGFzaGkuDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:16:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:16:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349770.1607410 (Exim 4.92) (envelope-from ) id 1wesvM-0000ms-EQ; Wed, 01 Jul 2026 11:16:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349770.1607410; Wed, 01 Jul 2026 11:16:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesvM-0000ml-Bh; Wed, 01 Jul 2026 11:16:12 +0000 Received: by outflank-mailman (input) for mailman id 1349770; Wed, 01 Jul 2026 11:16:11 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesvL-0000mf-5l for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:16:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesvK-00AYiY-Ib for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:16:10 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f6f8-bab6-0a2a0a5309dd-0a2a450adfe2-10 for ; Wed, 01 Jul 2026 13:16:10 +0200 Received: from [195.135.223.130] (helo=smtp-out1.suse.de) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f6f9-e40e-0a2a450a0019-c387df82b2c6-3 for ; Wed, 01 Jul 2026 13:16:09 +0200 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0BC0C73A64; Wed, 1 Jul 2026 11:16:09 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B0FF2779AA; Wed, 1 Jul 2026 11:16:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GjmxKfj2RGrOAQAAD6G6ig (envelope-from ); Wed, 01 Jul 2026 11:16:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JT7iBznZB9hYtU2hmcIVCoEf5jUDxb+Rih533/5awsQ=; b=qrFnZYoGs8bV/t9bkf3xiq/puwOmeYoEQXCcihKDLtmLaarzPkD+wQXK/2ZU5jng0Y7yip lWCjyWJNEausYb8DgjP7PxznkT4S6BkFza9PHXUAXmzHzfLee6OjfK+BOd4WG4tv24fbBU ImFKa65Yl0ozvK5sp3lFzrVc6z2Af1A= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=qrFnZYoG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JT7iBznZB9hYtU2hmcIVCoEf5jUDxb+Rih533/5awsQ=; b=qrFnZYoGs8bV/t9bkf3xiq/puwOmeYoEQXCcihKDLtmLaarzPkD+wQXK/2ZU5jng0Y7yip lWCjyWJNEausYb8DgjP7PxznkT4S6BkFza9PHXUAXmzHzfLee6OjfK+BOd4WG4tv24fbBU ImFKa65Yl0ozvK5sp3lFzrVc6z2Af1A= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface Date: Wed, 1 Jul 2026 13:16:03 +0200 Message-ID: <20260701111606.4063972-1-jgross@suse.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:mid,suse.com:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 0BC0C73A64 X-Spam-Score: -3.01 X-purgate-ID: tlsNG-4011c0/1782904569-D7D33DDE-8163BA14/0/0 X-purgate-type: clean X-purgate-size: 1184 Today the XEN_DOMCTL_setvcpuaffinity hypercall will not only change the affinity settings of a vcpu, it will return the new effective settings, too. In case an error happens during this hypercall, the expectation of the caller is that the affinity of the vcpu didn't change. This isn't true, however, if passing the new effective affinity back to the user is failing. Instead of making error handling in the hypervisor even more complex, just change the interface by NOT passing back the new affinity. It can easily be obtained by another XEN_DOMCTL_getvcpuaffinity call if needed. Juergen Gross (3): tools/libxl: don't rely on xc_vcpu_setaffinity() returned cpumaps xen: don't let XEN_DOMCTL_setvcpuaffinity return the new affinities tools/libxenctrl: rename parameters of xc_vcpu_setaffinity() tools/include/xenctrl.h | 26 +++++----------------- tools/libs/ctrl/xc_domain.c | 26 ++++++++++------------ tools/libs/light/libxl_sched.c | 9 ++++++++ xen/common/sched/core.c | 40 ++++++++-------------------------- xen/include/public/domctl.h | 9 ++------ 5 files changed, 38 insertions(+), 72 deletions(-) -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:16:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:16:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349771.1607420 (Exim 4.92) (envelope-from ) id 1wesvQ-00011j-RT; Wed, 01 Jul 2026 11:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349771.1607420; Wed, 01 Jul 2026 11:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesvQ-00011c-NC; Wed, 01 Jul 2026 11:16:16 +0000 Received: by outflank-mailman (input) for mailman id 1349771; Wed, 01 Jul 2026 11:16:15 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesvP-00010r-Ns for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:16:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesvP-00AhOL-4G for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:16:15 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f6f4-e002-0a2a0a5209dd-0a2a450c89fa-44 for ; Wed, 01 Jul 2026 13:16:15 +0200 Received: from [195.135.223.130] (helo=smtp-out1.suse.de) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f6fe-f399-0a2a450c0019-c387df82dc56-3 for ; Wed, 01 Jul 2026 13:16:14 +0200 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 84EC273A63; Wed, 1 Jul 2026 11:16:14 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 62023779AA; Wed, 1 Jul 2026 11:16:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8NijFv72RGrZAQAAD6G6ig (envelope-from ); Wed, 01 Jul 2026 11:16:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zaxfdhd/2xyg/xgn5cvnR+sq5s7uLGSyRRwH/Mnptzo=; b=JhVt65x1JsQycqKDgFnCPOiZKlZvFyiIG+Yag8Eg2mF0F/RPNqYvuM3CoqLPktKDgc8RUh sWkv/C0Pu55RkUH+1tuE0R6syoBBdpE23T3/7GOrhi9yi6ugkKaOkudPF0ZQawwpR97Vw3 qQJrINcEdbhfiM8UIHMqIu6ZUgUaUjk= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=JhVt65x1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zaxfdhd/2xyg/xgn5cvnR+sq5s7uLGSyRRwH/Mnptzo=; b=JhVt65x1JsQycqKDgFnCPOiZKlZvFyiIG+Yag8Eg2mF0F/RPNqYvuM3CoqLPktKDgc8RUh sWkv/C0Pu55RkUH+1tuE0R6syoBBdpE23T3/7GOrhi9yi6ugkKaOkudPF0ZQawwpR97Vw3 qQJrINcEdbhfiM8UIHMqIu6ZUgUaUjk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Anthony PERARD Subject: [PATCH 1/3] tools/libxl: don't rely on xc_vcpu_setaffinity() returned cpumaps Date: Wed, 1 Jul 2026 13:16:04 +0200 Message-ID: <20260701111606.4063972-2-jgross@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260701111606.4063972-1-jgross@suse.com> References: <20260701111606.4063972-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.com:+]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_THREE(0.00)[3]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.com:email,suse.com:dkim,suse.com:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 84EC273A63 X-Spam-Score: -3.01 X-purgate-ID: tlsNG-d25034/1782904574-A8AA8D51-0726AD08/0/0 X-purgate-type: clean X-purgate-size: 1341 In order to prepare for XEN_DOMCTL_setvcpuaffinity no longer returning the effective affinity settings, use xc_vcpu_getaffinity() for getting the effective affinities after having set them. Signed-off-by: Juergen Gross --- tools/libs/light/libxl_sched.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/libs/light/libxl_sched.c b/tools/libs/light/libxl_sched.c index 2d6635dae7..2f6a70aef5 100644 --- a/tools/libs/light/libxl_sched.c +++ b/tools/libs/light/libxl_sched.c @@ -69,6 +69,15 @@ static int libxl__set_vcpuaffinity(libxl_ctx *ctx, uint32_t domid, * is possible that Xen will use something different from what we asked * for various reasons. If that's the case, report it. */ + if ((cpumap_hard || cpumap_soft) && + xc_vcpu_getaffinity(ctx->xch, domid, vcpuid, + cpumap_hard ? hard.map : NULL, + cpumap_soft ? soft.map : NULL, + flags & ~XEN_VCPUAFFINITY_FORCE)) { + LOGED(ERROR, domid, "Checking vcpu affinity"); + rc = ERROR_FAIL; + goto out; + } if (cpumap_hard && !libxl_bitmap_equal(cpumap_hard, &hard, 0)) LOGD(DEBUG, domid, "New hard affinity for vcpu %d has unreachable cpus", vcpuid); -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:16:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:16:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349772.1607429 (Exim 4.92) (envelope-from ) id 1wesvX-0001KB-3E; Wed, 01 Jul 2026 11:16:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349772.1607429; Wed, 01 Jul 2026 11:16:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesvW-0001Jx-U2; Wed, 01 Jul 2026 11:16:22 +0000 Received: by outflank-mailman (input) for mailman id 1349772; Wed, 01 Jul 2026 11:16:21 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesvV-0001IA-9O for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:16:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesvU-008Ib4-MO for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:16:20 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f6ff-bab6-0a2a0a5309dd-0a2a45038504-8 for ; Wed, 01 Jul 2026 13:16:20 +0200 Received: from [195.135.223.130] (helo=smtp-out1.suse.de) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f704-ec1a-0a2a45030019-c387df82da78-3 for ; Wed, 01 Jul 2026 13:16:20 +0200 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3062C73A63; Wed, 1 Jul 2026 11:16:20 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D9B40779AA; Wed, 1 Jul 2026 11:16:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8F7cMwP3RGrhAQAAD6G6ig (envelope-from ); Wed, 01 Jul 2026 11:16:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eHLTBeGgYNLdb9o5EF92sUCLA1iLOlkHRzk4jz8IGiQ=; b=WxgOEtUNI3sdwzFIUTtXShDsriBbBzUldTOXEQxT0sH5yfsbtNS151iYxQJw4wyTY5fSQW 5nqcg5yOupZe9vzqagQDrVOmRMU66WA1FVqoxEcdfGj5MYsadumODIwmR2FnxPWpkamYY1 bQbJW+2PFdIZgeg1XMS4ah3gNsOse8M= Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=WxgOEtUN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904580; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eHLTBeGgYNLdb9o5EF92sUCLA1iLOlkHRzk4jz8IGiQ=; b=WxgOEtUNI3sdwzFIUTtXShDsriBbBzUldTOXEQxT0sH5yfsbtNS151iYxQJw4wyTY5fSQW 5nqcg5yOupZe9vzqagQDrVOmRMU66WA1FVqoxEcdfGj5MYsadumODIwmR2FnxPWpkamYY1 bQbJW+2PFdIZgeg1XMS4ah3gNsOse8M= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Dario Faggioli , George Dunlap , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 2/3] xen: don't let XEN_DOMCTL_setvcpuaffinity return the new affinities Date: Wed, 1 Jul 2026 13:16:05 +0200 Message-ID: <20260701111606.4063972-3-jgross@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260701111606.4063972-1-jgross@suse.com> References: <20260701111606.4063972-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.com:email,suse.com:dkim,suse.com:mid]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 3062C73A63 X-Spam-Score: -3.01 X-purgate-ID: tlsNG-33051d/1782904580-BDFBB5D1-DAD606B7/0/0 X-purgate-type: clean X-purgate-size: 5760 There is no in-tree user of XEN_DOMCTL_setvcpuaffinity left relying on the returned effective affinity settings. Drop returning the new affinities, as any error occurring for that will be reported to the user, while the affinities won't be changed back to what they were. This would result in the caller believing that the affinity was not modified, while it might have been. Fix a comment typo while modifying vcpu_affinity_domctl(). Signed-off-by: Juergen Gross --- xen/common/sched/core.c | 40 +++++++++---------------------------- xen/include/public/domctl.h | 9 ++------- 2 files changed, 11 insertions(+), 38 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 3609721426..1611e60020 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1708,7 +1708,7 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd, { struct vcpu *v; const struct sched_unit *unit; - int ret = 0, hret = 0; + int ret = 0; if ( vcpuaff->vcpu >= d->max_vcpus ) return -EINVAL; @@ -1724,12 +1724,11 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd, if ( cmd == XEN_DOMCTL_setvcpuaffinity ) { cpumask_var_t new_affinity, old_affinity; - cpumask_t *online = cpupool_domain_master_cpumask(v->domain); /* * We want to be able to restore hard affinity if we are trying * setting both and changing soft affinity (which happens later, - * when hard affinity has been succesfully chaged already) fails. + * when hard affinity has been successfully changed already) fails. */ if ( !alloc_cpumask_var(&old_affinity) ) return -ENOMEM; @@ -1746,25 +1745,14 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd, if ( vcpuaff->flags & XEN_VCPUAFFINITY_FORCE ) vcpu_temporary_affinity(v, NR_CPUS, VCPU_AFFINITY_OVERRIDE); - /* - * We both set a new affinity and report back to the caller what - * the scheduler will be effectively using. - */ if ( vcpuaff->flags & XEN_VCPUAFFINITY_HARD ) { - hret = xenctl_bitmap_to_bitmap(cpumask_bits(new_affinity), + ret = xenctl_bitmap_to_bitmap(cpumask_bits(new_affinity), &vcpuaff->cpumap_hard, nr_cpu_ids); - if ( !hret ) - hret = vcpu_set_hard_affinity(v, new_affinity); - if ( hret ) + if ( !ret ) + ret = vcpu_set_hard_affinity(v, new_affinity); + if ( ret ) goto setvcpuaffinity_out; - - /* - * For hard affinity, what we return is the intersection of - * cpupool's online mask and the new hard affinity. - */ - cpumask_and(new_affinity, online, unit->cpu_hard_affinity); - hret = cpumask_to_xenctl_bitmap(&vcpuaff->cpumap_hard, new_affinity); } if ( vcpuaff->flags & XEN_VCPUAFFINITY_SOFT ) { @@ -1782,17 +1770,7 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd, */ if ( vcpuaff->flags & XEN_VCPUAFFINITY_HARD ) vcpu_set_hard_affinity(v, old_affinity); - goto setvcpuaffinity_out; } - - /* - * For soft affinity, we return the intersection between the - * new soft affinity, the cpupool's online map and the (new) - * hard affinity. - */ - cpumask_and(new_affinity, new_affinity, online); - cpumask_and(new_affinity, new_affinity, unit->cpu_hard_affinity); - ret = cpumask_to_xenctl_bitmap(&vcpuaff->cpumap_soft, new_affinity); } setvcpuaffinity_out: @@ -1802,14 +1780,14 @@ int vcpu_affinity_domctl(struct domain *d, uint32_t cmd, else { if ( vcpuaff->flags & XEN_VCPUAFFINITY_HARD ) - hret = cpumask_to_xenctl_bitmap(&vcpuaff->cpumap_hard, + ret = cpumask_to_xenctl_bitmap(&vcpuaff->cpumap_hard, unit->cpu_hard_affinity); - if ( vcpuaff->flags & XEN_VCPUAFFINITY_SOFT ) + if ( !ret && vcpuaff->flags & XEN_VCPUAFFINITY_SOFT ) ret = cpumask_to_xenctl_bitmap(&vcpuaff->cpumap_soft, unit->cpu_soft_affinity); } - return hret ?: ret; + return ret; } bool alloc_affinity_masks(struct affinity_masks *affinity) diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index cdf350a290..906d2c59d0 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -357,13 +357,8 @@ struct xen_domctl_vcpuaffinity { /* * IN/OUT variables. * - * Both are IN/OUT for XEN_DOMCTL_setvcpuaffinity, in which case they - * contain effective hard or/and soft affinity. That is, upon successful - * return, cpumap_soft, contains the intersection of the soft affinity, - * hard affinity and the cpupool's online CPUs for the domain (if - * XEN_VCPUAFFINITY_SOFT was set in flags). cpumap_hard contains the - * intersection between hard affinity and the cpupool's online CPUs (if - * XEN_VCPUAFFINITY_HARD was set in flags). + * Both are IN-only for XEN_DOMCTL_setvcpuaffinity, in which case they + * contain effective hard or/and soft affinity. * * Both are OUT-only for XEN_DOMCTL_getvcpuaffinity, in which case they * contain the plain hard and/or soft affinity masks that were set during -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:16:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:16:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349775.1607437 (Exim 4.92) (envelope-from ) id 1wesvc-0001eE-7N; Wed, 01 Jul 2026 11:16:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349775.1607437; Wed, 01 Jul 2026 11:16:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesvc-0001e6-4W; Wed, 01 Jul 2026 11:16:28 +0000 Received: by outflank-mailman (input) for mailman id 1349775; Wed, 01 Jul 2026 11:16:26 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesva-0001bA-Pd for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:16:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesva-003663-65 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:16:26 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f709-2eae-0a2a0a5409dd-0a2a4506d3e8-6 for ; Wed, 01 Jul 2026 13:16:26 +0200 Received: from [195.135.223.131] (helo=smtp-out2.suse.de) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f709-08de-0a2a45060019-c387df83d738-3 for ; Wed, 01 Jul 2026 13:16:25 +0200 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A685F75C3A; Wed, 1 Jul 2026 11:16:25 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 83C02779AA; Wed, 1 Jul 2026 11:16:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PYjUHgn3RGoEAgAAD6G6ig (envelope-from ); Wed, 01 Jul 2026 11:16:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2t/WHu9BiecxDO+oBqpdeXwPpVi0SCaRQ5V3xF2p+VU=; b=hs6TvoaspCKSX7Q68ECL2s4YoFqNJJpwoirSRZaZJ8PDAIRTZ3cBdhlPSb2ONon782l5V7 wWPvKg1xpVYJR1aVKk3RmIVM9HYL3sk/eNhDR/UNJJB9QM2wo0badB11Xt8OU1xI7CiECa 0git7o0hLtQykU2ffHn+9qTPgBhsJ3o= Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=hs6Tvoas DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782904585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2t/WHu9BiecxDO+oBqpdeXwPpVi0SCaRQ5V3xF2p+VU=; b=hs6TvoaspCKSX7Q68ECL2s4YoFqNJJpwoirSRZaZJ8PDAIRTZ3cBdhlPSb2ONon782l5V7 wWPvKg1xpVYJR1aVKk3RmIVM9HYL3sk/eNhDR/UNJJB9QM2wo0badB11Xt8OU1xI7CiECa 0git7o0hLtQykU2ffHn+9qTPgBhsJ3o= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Anthony PERARD Subject: [PATCH 3/3] tools/libxenctrl: rename parameters of xc_vcpu_setaffinity() Date: Wed, 1 Jul 2026 13:16:06 +0200 Message-ID: <20260701111606.4063972-4-jgross@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260701111606.4063972-1-jgross@suse.com> References: <20260701111606.4063972-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: A685F75C3A X-Spam-Flag: NO X-Spam-Score: -4.01 X-Spam-Level: X-Spamd-Result: default: False [-4.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; DWL_DNSWL_LOW(-1.00)[suse.com:dkim]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:dkim,suse.com:email,suse.com:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.com:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-purgate-ID: tlsNG-16d1c6/1782904585-C5B3A68D-500FB331/0/0 X-purgate-type: clean X-purgate-size: 5707 The cpumaps passed to xc_vcpu_setaffinity() are input-only now, so drop the "_inout" suffix from their names and make them const. Signed-off-by: Juergen Gross --- tools/include/xenctrl.h | 26 ++++++-------------------- tools/libs/ctrl/xc_domain.c | 26 ++++++++++++-------------- 2 files changed, 18 insertions(+), 34 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index d5dbf69c89..96fb0cc81f 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -590,37 +590,23 @@ int xc_domain_node_getaffinity(xc_interface *xch, * There are two kinds of affinity. Soft affinity is on what CPUs a vcpu * prefers to run. Hard affinity is on what CPUs a vcpu is allowed to run. * If flags contains XEN_VCPUAFFINITY_SOFT, the soft affinity it is set to - * what cpumap_soft_inout contains. If flags contains XEN_VCPUAFFINITY_HARD, - * the hard affinity is set to what cpumap_hard_inout contains. Both flags + * what cpumap_soft contains. If flags contains XEN_VCPUAFFINITY_HARD, + * the hard affinity is set to what cpumap_hard contains. Both flags * can be set at the same time, in which case both soft and hard affinity are * set to what the respective parameter contains. * - * The function also returns the effective hard or/and soft affinity, still - * via the cpumap_soft_inout and cpumap_hard_inout parameters. Effective - * affinity is, in case of soft affinity, the intersection of soft affinity, - * hard affinity and the cpupool's online CPUs for the domain, and is returned - * in cpumap_soft_inout, if XEN_VCPUAFFINITY_SOFT is set in flags. In case of - * hard affinity, it is the intersection between hard affinity and the - * cpupool's online CPUs, and is returned in cpumap_hard_inout, if - * XEN_VCPUAFFINITY_HARD is set in flags. If both flags are set, both soft - * and hard affinity are returned in the respective parameter. - * - * We do report it back as effective affinity is what the Xen scheduler will - * actually use, and we thus allow checking whether or not that matches with, - * or at least is good enough for, the caller's purposes. - * * @param xch a handle to an open hypervisor interface. * @param domid the id of the domain to which the vcpu belongs * @param vcpu the vcpu id wihin the domain - * @param cpumap_hard_inout specifies(/returns) the (effective) hard affinity - * @param cpumap_soft_inout specifies(/returns) the (effective) soft affinity + * @param cpumap_hard specifies the hard affinity + * @param cpumap_soft specifies the soft affinity * @param flags what we want to set */ int xc_vcpu_setaffinity(xc_interface *xch, uint32_t domid, int vcpu, - xc_cpumap_t cpumap_hard_inout, - xc_cpumap_t cpumap_soft_inout, + const xc_cpumap_t cpumap_hard, + const xc_cpumap_t cpumap_soft, uint32_t flags); /** diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index 01c0669c88..3ee0e43ea5 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -199,15 +199,13 @@ int xc_domain_node_getaffinity(xc_interface *xch, int xc_vcpu_setaffinity(xc_interface *xch, uint32_t domid, int vcpu, - xc_cpumap_t cpumap_hard_inout, - xc_cpumap_t cpumap_soft_inout, + const xc_cpumap_t cpumap_hard, + const xc_cpumap_t cpumap_soft, uint32_t flags) { struct xen_domctl domctl = {}; - DECLARE_HYPERCALL_BOUNCE(cpumap_hard_inout, 0, - XC_HYPERCALL_BUFFER_BOUNCE_BOTH); - DECLARE_HYPERCALL_BOUNCE(cpumap_soft_inout, 0, - XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + DECLARE_HYPERCALL_BOUNCE(cpumap_hard, 0, XC_HYPERCALL_BUFFER_BOUNCE_IN); + DECLARE_HYPERCALL_BOUNCE(cpumap_soft, 0, XC_HYPERCALL_BUFFER_BOUNCE_IN); int ret = -1; int cpusize; @@ -218,11 +216,11 @@ int xc_vcpu_setaffinity(xc_interface *xch, return -1; } - HYPERCALL_BOUNCE_SET_SIZE(cpumap_hard_inout, cpusize); - HYPERCALL_BOUNCE_SET_SIZE(cpumap_soft_inout, cpusize); + HYPERCALL_BOUNCE_SET_SIZE(cpumap_hard, cpusize); + HYPERCALL_BOUNCE_SET_SIZE(cpumap_soft, cpusize); - if ( xc_hypercall_bounce_pre(xch, cpumap_hard_inout) || - xc_hypercall_bounce_pre(xch, cpumap_soft_inout) ) + if ( xc_hypercall_bounce_pre(xch, cpumap_hard) || + xc_hypercall_bounce_pre(xch, cpumap_soft) ) { PERROR("Could not allocate hcall buffers for DOMCTL_setvcpuaffinity"); goto out; @@ -234,17 +232,17 @@ int xc_vcpu_setaffinity(xc_interface *xch, domctl.u.vcpuaffinity.flags = flags; set_xen_guest_handle(domctl.u.vcpuaffinity.cpumap_hard.bitmap, - cpumap_hard_inout); + cpumap_hard); domctl.u.vcpuaffinity.cpumap_hard.nr_bits = cpusize * 8; set_xen_guest_handle(domctl.u.vcpuaffinity.cpumap_soft.bitmap, - cpumap_soft_inout); + cpumap_soft); domctl.u.vcpuaffinity.cpumap_soft.nr_bits = cpusize * 8; ret = do_domctl(xch, &domctl); out: - xc_hypercall_bounce_post(xch, cpumap_hard_inout); - xc_hypercall_bounce_post(xch, cpumap_soft_inout); + xc_hypercall_bounce_post(xch, cpumap_hard); + xc_hypercall_bounce_post(xch, cpumap_soft); return ret; } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:21:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349807.1607446 (Exim 4.92) (envelope-from ) id 1wet0Z-000456-PZ; Wed, 01 Jul 2026 11:21:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349807.1607446; Wed, 01 Jul 2026 11:21:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wet0Z-00044z-Ma; Wed, 01 Jul 2026 11:21:35 +0000 Received: by outflank-mailman (input) for mailman id 1349807; Wed, 01 Jul 2026 11:21:35 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wet0Z-00044t-4X for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:21:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wet0Y-008Jx0-0h for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:21:34 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f838-bab6-0a2a0a5309dd-0a2a4506ad4a-28 for ; Wed, 01 Jul 2026 13:21:33 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f83d-08de-0a2a45060019-d1558036b1ce-3 for ; Wed, 01 Jul 2026 13:21:33 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493b7612475so4175865e9.3 for ; Wed, 01 Jul 2026 04:21:33 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bfe7427dsm30066585e9.2.2026.07.01.04.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:21:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782904893; x=1783509693; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yYqd0TQWneNELNrgVFcNFC5RMvVEYdbDE3gPcNnxkYg=; b=rAiEnPkE1WoQgGlw/THW13s+1Z15Omo5RxLlADdvewcaHrBpx0zNtfWYb6KpWGmoVb L46RdnBLFSrfRKIhZAeAiAAjADo9LDEYZzE6TjlKg2EsxZnPu97BqT7mCoKcubvg4Bzp GmNPy8KxXOurKKtxBv7CMm0ee4OFygj0yhziClbV6XLxj06UEGzcIH8+dTYIpCzcg0pe SauiNG4EqBPISQ1m4jTTnFeRzGajjd3x9SJ6Qcb3vai6ypfvEfEAi8Z59WzAKNlWFU1C zupAW2VK5kYARy9T6gbhO8419PeY/5YerqHJVi89XZE/yjkmPNFJQkfP/1am+5KHE6uo WTvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782904893; x=1783509693; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yYqd0TQWneNELNrgVFcNFC5RMvVEYdbDE3gPcNnxkYg=; b=mIMNBC1fICVhJmIMRWETPMN1PIGv39QRw6gDefG9Q6OxVrpa5X+/s6ojY6K4zvltic LCUNoUblrRYDhj3HspcgTi7H67x6cuDtOjkwURP/kWpKHJ/Wvt3N10v/yCIKIBZhc+jb S7xic9JQTECgC8C4bABV8aB9NrnOZ9FlpqK+V9w6UC+TbeZxMkunfo6TYgBoWiHkqagq GDka/PWnZ3IAoUTsvVcSNmsOMyxDNn03tdUGhJQn+Poc53fF7uyJxNs739pkYj8bboJv 1JJXvEsQZDLgfvw5P9vqrK5y3c9FadLrmUCRoyUqlsKKWH6yjsAVyCqUP+HRR8FYo+S+ uUuA== X-Forwarded-Encrypted: i=1; AFNElJ8VEl2BEmJ4C0xND0jKlND2JUJXzOCZ4JVaQFwSn5ZqnVMVjWIyBLw0NpEkqPESzJeeoLtIMUZP6M0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxD0fbwfFY6k1hzVKyl4zG1/YzXvux+w1HhAe+e5gHd4K5zMBFR KhwGkuJIIkVILByvY2nTx+MlkZxSB2Ca2HEqiwE+N9Xs8o6mFmnLxweQ X-Gm-Gg: AfdE7ck3FRxABGDa0dCcyRqiSyrV2Y49Z1sXMFixpKZsoELWRwptmOLrqQbW+BQZXvs 2ze8dOECUQ283WnK/OQ/Dh4B1k024XKiEhpyQ96eAZKynIY8MylQTlx6ou5jEWLY2EPbJurM7w6 cIdio37vj4F8JZIpLIAKh87V7j97q4DpevkAtn053TgvdUILAVjqNhzN8aWE9lFEdAblA9qeT7J iPeNCJFxBRqXPj3M27/QfUFlSpZnlWKRubooEpYTNhZLDXqjPXWVkWXqVHhuH4pHBmupzx7nKKg z8+qUSOi1zL/7BL3vtutifYyhpcOacTw8+vgT1AVKgaPLctf8e/reZ/HAl//HmEI0Q0vFvL8H5U W672Y6ENRiA4Ycq0QRo87Cq4rp/18DVe2CdqPVoF1dTtmuKHjdpC6A8B2jaWUGcw+lFVN363nAh z3nMZWF9zDwdvmD+b7ioqtHzUJ88X/o5DvYIG8uZKL8+tPAcagG2229JnhyWvr5P1FUZ8= X-Received: by 2002:a05:600c:6692:b0:490:d354:bd00 with SMTP id 5b1f17b1804b1-493c2b90632mr18178965e9.25.1782904893118; Wed, 01 Jul 2026 04:21:33 -0700 (PDT) Message-ID: <018771c4-043d-4b29-ac40-284ee8692334@gmail.com> Date: Wed, 1 Jul 2026 13:21:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/25] xen/riscv: generate IMSIC DT node for guest domains To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <424c223b97e9d27aa4ef4e05e2d5c8d0c426324c.1782487661.git.oleksii.kurochko@gmail.com> <77d3cf2c-3ed7-45f8-8e76-72520e71306b@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <77d3cf2c-3ed7-45f8-8e76-72520e71306b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1782904893-C553968D-055D0C2C/10/73395122804 X-purgate-type: spam X-purgate-size: 4806 On 6/29/26 5:19 PM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> --- a/xen/arch/riscv/imsic.c >> +++ b/xen/arch/riscv/imsic.c >> @@ -13,8 +13,12 @@ >> #include >> #include >> #include >> +#include >> #include >> +#include >> +#include >> #include >> +#include >> #include >> #include >> #include >> @@ -34,6 +38,16 @@ static struct imsic_config imsic_cfg = { >> .lock = SPIN_LOCK_UNLOCKED, >> }; >> >> +/* >> + * Number of MSIs available to a guest. Determined by the host interrupt >> + * controller, so it is identical for every domain -- hence a single global >> + * rather than a per-domain value. >> + */ >> +static unsigned int __read_mostly guest_num_msis; >> + >> +#define GUEST_IMSIC_COMPATIBLE "riscv,imsics" >> +#define GUEST_IMSIC_NUM_MSIS 255 > > Considering its use this isn't named correctly - it's not the number of MSIs > guests get to use. I will rename to GUEST_IMSIC_NUM_IDS then it will be fully aligned with dts property name. Then it makes sense to rename guest_num_msis to guest_num_ids. > >> @@ -285,6 +299,11 @@ static int imsic_parse_node(const struct dt_device_node *node, >> return -ENOENT; >> } >> >> + if ( dt_property_read_u32(node, "riscv,num-guest-ids", &tmp) ) >> + guest_num_msis = tmp; >> + else >> + guest_num_msis = IMSIC_MAX_ID; > > Why is guest_num_msis __read_mostly, not __ro_after_init? Merely because the > function here (wrongly) isn't __init? Yes, because of the function isn't __init what I can agree is wrong. I will change that and s/__read_mostly/__ro_after_init for guest_num_msis. > >> @@ -522,3 +541,121 @@ int __init imsic_init(const struct dt_device_node *node) >> >> return rc; >> } >> + >> +static int __init guest_imsic_make_reg_property(struct domain *d, void *fdt) >> +{ >> + paddr_t size = IMSIC_MMIO_PAGE_SZ * d->max_vcpus; >> + __be32 regs[4] = { >> + cpu_to_be32(GUEST_IMSIC_S_BASE >> 32), >> + cpu_to_be32(GUEST_IMSIC_S_BASE), >> + cpu_to_be32(size >> 32), >> + cpu_to_be32(size), >> + }; >> + >> + return fdt_property(fdt, "reg", regs, sizeof(regs)); >> +} >> + >> +static int __init guest_imsic_set_interrupt_extended_prop(struct domain *d, >> + void *fdt) >> +{ >> + unsigned int cpu, pos = 0; >> + __be32 *irq_ext; >> + int res; >> + >> + irq_ext = xvzalloc_array(__be32, d->max_vcpus * 2); >> + if ( !irq_ext ) >> + return -ENOMEM; >> + >> + for ( cpu = 0; cpu < d->max_vcpus; cpu++ ) >> + { >> + char buf[64]; >> + uint32_t phandle; >> + >> + snprintf(buf, sizeof(buf), "/cpus/cpu@%u/interrupt-controller", cpu); > > May I, btw, suggest you get into the habit of using ARRAY_SIZE() in favor of > sizeof() with snprintf()? That's because sizeof() isn't correct to use if > wide strings (and hence swnprintf()) come into play. Oh, right with wchar_t buf[64] sizeof(buf) won't return 64... I will apply your suggestion and use ARRAY_SIZE() here instead. > >> +int __init vimsic_make_domu_dt_node(struct kernel_info *kinfo, >> + unsigned int *phandle) >> +{ >> + int res; >> + void *fdt = kinfo->fdt; >> + char vimsic_name[32]; >> + unsigned int vimsic_phandle; >> + unsigned int num_msis = min(GUEST_IMSIC_NUM_MSIS + 0U, guest_num_msis); > > As guest_num_msis (supposedly) doesn't change anymore after it was set, why > would this need calculating again for each call here? Can't you apply the > upper bound right in imsic_parse_node()? Agree, I will add the following to imsic_parse_node() after guest_num_msis is init-ed: guest_num_msis = min(GUEST_IMSIC_NUM_MSIS + 0U, guest_num_msis); > >> --- a/xen/arch/riscv/include/asm/guest-layout.h >> +++ b/xen/arch/riscv/include/asm/guest-layout.h >> @@ -3,6 +3,12 @@ >> >> #include >> >> +/* >> + * Base address of the guest's supervisor-mode IMSIC. The value is the address >> + * typically used for IMSIC by QEMU. >> + */ >> +#define GUEST_IMSIC_S_BASE _UL(0x28000000) > > As you mention it explicitly: Is there also a user-mode IMSIC? I am not aware of such. I mention it explicitly as machine mode IMSIC exists and it is a separate DT node for that. Out of scope: there is a reserved bit in MISA register for user-level interrupts but I don't see that AIA uses that bit. Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:34:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:34:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349820.1607454 (Exim 4.92) (envelope-from ) id 1wetCu-00062y-Tv; Wed, 01 Jul 2026 11:34:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349820.1607454; Wed, 01 Jul 2026 11:34:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetCu-00062r-R3; Wed, 01 Jul 2026 11:34:20 +0000 Received: by outflank-mailman (input) for mailman id 1349820; Wed, 01 Jul 2026 11:34:19 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetCt-00062l-4N for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:34:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetCs-009c0c-Ga for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:34:18 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44fb36-e002-0a2a0a5209dd-0a2a450682de-24 for ; Wed, 01 Jul 2026 13:34:18 +0200 Received: from [52.101.56.7] (helo=BN1PR04CU002.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44fb38-08de-0a2a45060019-346538075e3b-3 for ; Wed, 01 Jul 2026 13:34:17 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by LV4PR03MB8356.namprd03.prod.outlook.com (2603:10b6:408:2de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Wed, 1 Jul 2026 11:34:15 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Wed, 1 Jul 2026 11:34:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ebCvYSWL0OI4LV6cns9tdyQ9HP0SDXCarU26GQkrW18PRMO/8LwtFfWCWx243JOTEEIl08Co+c3T//12++PI+5BN6qmf4lvoFK2F2+m9Lxx8RpiOs6Ap4rYkvBysoXIoK4e+V3x2TfkaP9jUDdRLVM+pP+Owbhcc0hzwdiGxtkgeZybE6wA5fc5kyVdkBKSspSJ33dhhTePf/k7hwJ8ipehOaJygVDM6rSKlDyez1AvrP/+PlVspKSBQ1V9COCbqX6mUch4TTkU67EkaQ8fnlnVEw8rQtQFLF+se5mYq9tu/8KIVxVW+4dLHW8Kq3xeSjX1x9h8I4QZZMvfOcfADlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ap7FD2WZLt2K+DThBlbMj7O+NP6IwDUgnGaQtYDhBks=; b=s8xlHbINMNDyLMkf1YrlgSf1ETxjMChHn0+zexZRM85xFjrUMl1ukt1wWPJ1OAWPzt1hG2Y/++Ja/0N4emeiiGOqPVmeiclWR9o44pRl6Ykr3jUlMxeuGJW8jbnnr27ywjFNrSwrCHmxWzcbL6ifN91zNAWhIzLrSkOmYOHQBOpmPPjvG5KhGbX2Z+0FDZ0ZvpDW2UXMU36dkm/kGScXYByaSA9Rfu02tuaoSLFNbtsOmrLXuNOlhYqsUz12RDli8onbWA/yFCFQ8ALzCfffXJEgG0plwU4GsyqEJTOh958MVMcCLOHIout4GO83CHl0cgJhg/x28xwHdKf+MVp1CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ap7FD2WZLt2K+DThBlbMj7O+NP6IwDUgnGaQtYDhBks=; b=BaizO17sGMgiLtBF11n4ma9ZUEfojtnvutwEvIzFQePVwGRWPzUf0EJAUs/MsBvFSfFyhxqHnUQD6bmMYcAmS6rLyojKVVJb1QoxXbnTfoSZwzL0DqzNPoG9dQOTA8dfIldk3Eu2ffSQwnMd+inCSEshfG8iHcfd5NwjepoeJpQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3c7ef127-83cb-4498-b4b9-c998a9ea96b9@citrix.com> Date: Wed, 1 Jul 2026 12:34:11 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross , Frediano Ziglio Subject: Re: [PATCH v6 05/16] libs/guest: allocate various migration arrays just once To: Frediano Ziglio , xen-devel@lists.xenproject.org References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-6-frediano.ziglio@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260619130501.272832-6-frediano.ziglio@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0091.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::6) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|LV4PR03MB8356:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ac4a882-b144-4775-1719-08ded764ae2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|366016|56012099006|4143699003|11063799006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: DCRM7mX51iB4S68ObTgYZ3pUeZ5LwwTEE4xLOE4X+FGogR/94R9fy4P0nKiuOLpcKeHkus+cy6BbgArOofJsY/p9bbVO2S9YntmJXb9ibPmoufIo5WsYaCKphFQfaPsuLH1WjGxcEI1iwbrwlIpu9zZo94tPSi7PjGLkibawrbOrUPV5Hj5qimCBELVixLFGf5m4V0Q9d9pXbN8vDJjKj8A1vbFywpBr+i7rAxGCp+ORHBFTWcOEDnFKCGME6Qs5wMEBYaBIbAVWEMaYDOR7Rjj+fOJXjwPLglKmOoJkLCtEGEgtrF168EPS3QGyvans3P0XRtEdfbPSlWGjUvsQgy83F7oNGXqKcjBQ6zJXW8/C9mVpCjebLB9pBG7A3XkDXtpinU4AQx/Ue4H0kpgFhx/7jlg2MS+1W4XDwc4L9fzEESqNjcH0fVMKoXTdgtzOL0N87fD2SP45zh99/kbQsJnUMDntGYlZv9jCLgd5dmADnZY20cTodbMGSQ7w9zbykVG3/qJURlRD4FVq6/3lOi0YblEtIXZoi5g+dkmyREsDdeGfkGdsc7gNLk4reN8+4kBNKIWnZjWxP4txLoCJJnb6TY71XxRX8BWHSjxPo+9k7wnvY67pmSj7RKAC+aEZ8bR9UIvX1kTRVI2IeW7OCPb64rvrgXmEt7Xq7QkwSms= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(56012099006)(4143699003)(11063799006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWlVSHZoRHArOFN3KzhhQW5TTUN2by8vR2wxdStXYXFXR29VSm1udkZ5d3gx?= =?utf-8?B?TFFRc2NIZFFha3RYMWMzdFhKekJaS2NUTnVyZm9rbHZWeERmNURwVzZlTmJF?= =?utf-8?B?RGlSWDRVR3dCcmdrS3NRVTVJWW9EUVpiQ2xFeDVLR1NnRmV1aGYvYlBRS0xE?= =?utf-8?B?UzdmdTZlRndhV3phMkhiYXkwRUI2enVlaDR4cmh5WEZkanUreHU3Zmw4R0E1?= =?utf-8?B?SngzS2JpMWVsd2pUT0dRMnhBWHpzTGVhUnJmbElYc2REV05QSW9DMjB4MSs5?= =?utf-8?B?LzduazkvbjJmQTVaWk9WdU1hNnBtRWkxc201NlVkTkUwWjEyQytpZXZWWUYy?= =?utf-8?B?SmpsbW5uY3ErRUVnK3ZYekowMnhuSlBmM1RwODY2NFBhakZpbkhrTXc3ZGVR?= =?utf-8?B?ZEI4aHlDSXZZcEU5WXphdEZ0cUhsSmNlbFNrYWpnM21SbUxwQUZmenZCN29o?= =?utf-8?B?ZE1aMmpNc0F0VDZBV0xidzF0bjJ6a2diSnU5REV3YWQvMjZKU29aNUxHakpx?= =?utf-8?B?TlFTbnNwYjBGQWV6VnZtS0pmL3NYczFBcWttMlVGYnpRdmRYenQvZ0czY3l3?= =?utf-8?B?SnMrRTFMSGs1eWVDK1RxMms1LzBFenB6aFhIOTA1bjc3eFdXL3pGTlpIQmxG?= =?utf-8?B?cFBYV0syaGwvT0dMOXQvNVdTWGIrZGlkbWIzb0MrSXdIbEt0MGdPZ3lZT2J0?= =?utf-8?B?aEE4eGJ2Smw5Y0hDVnRmd0FsMllJeXVISkJLTUhSb2ZibFptNmJKMDRPWWx6?= =?utf-8?B?UGFzdlJ2RTZHYXZDSEtKd3lTMmpzendnS3FUUFJpa3d0VkxZWnY0WUlXZjNz?= =?utf-8?B?NS9TdnlRMzhFeEx1ZENSQUpHMVhiMG9sNHlxR3IzOGtuR2EwK1VOZnUraVQx?= =?utf-8?B?bUo3Q0dWQWZrUDJSWktTNURPc2dqL0phckM5aEc5a09oeDFQUkxxcE9ZaGRh?= =?utf-8?B?U2Rhd3crenhTSGJURmpWelRFdTYwMWw1cG0vSHZqYjFLVm02U3J1Um13RlZw?= =?utf-8?B?RGhRSktBNU43UEV2anJvSzE5SWhwV2Y5L3I1eldTeGlpMFY3cVRXeklGdlNq?= =?utf-8?B?VCsxMW96aVZ6U2J2NWFaUk0zQUdYeC9SVlJGRDdRTStMSXZYTko5UG9vZklF?= =?utf-8?B?WlVkQ0NjL1FUYllXRThLT3pPK1haSXlnSnFVUERYVVdIbHJBMkNRUFJTTUFG?= =?utf-8?B?ZlkxYTduSnpNdzhVZ3kxTmxkUUlhSzFWL2UxTmsvZ3BVZS9NR3VPVGRiYlFN?= =?utf-8?B?YUVtazZCMkpIU3BMNUhJLzl6MHh1aHIwZFRwK1RLTi9HK1NSNGpqdStZdjla?= =?utf-8?B?ZFNYMHVwZmpndC9mTkh4TVFVWGFYQk1hdW4xdFpCVHJvd1dPWTd3cUxpaFBZ?= =?utf-8?B?MXN0YlNqUzdNNDVxTU81Z1Q2K3Q5ZVEvcXlUQnRwMVVUeEs4WTFJMkdRYUpY?= =?utf-8?B?a2l0S0gwQ1NuVnN5TE92ZWlQMzBtVm9wVkVxbUZCNGJDWWNuYWIxSXVWK0dE?= =?utf-8?B?UE44VHJpVWM2S05WaUtnSHlsZS9XaXRlR3JDaFB2NTRYa21iZ08xbHp1SEh1?= =?utf-8?B?WW9veHI1b00zSlBBTmQ4SlFBWllRV25RMS9FS3RvQmlRck5jb2JDMkw2SC80?= =?utf-8?B?c2d6bXN2RzZqdk54MTg5TklKbjJLdkNtYTA5V0hMZTRXUVUrSU1LS0poNTBU?= =?utf-8?B?VFY4WDFtWThqTm5lVlJnNStMbWdTVjdveEE3SVJGR0JMZmdxM21HSkIvbitG?= =?utf-8?B?Z1cwUGhWMEdGWXVEV0l6aU1UMHE0VDlFMkZlL3E2ZllNZ1F4UjVhNHJBeW1M?= =?utf-8?B?UVBxRDR1TWJhcXhucWhmRGlBVXRvZ1pib0V0Mk5weE5odG1OYXpBNWwxZzlz?= =?utf-8?B?a1ljWkJGdUkzSUozZ09Pa3U4Kzh4R0xYWDVkR2J4cGIvUnVzKzRCYXFKRmR2?= =?utf-8?B?SWVldHRCVmNHbmw5VjBQbkx5MDlxaDQ0RUpjSFA3K1p5NTRLZE9ocXg1VVdU?= =?utf-8?B?REdaSkZSbTA4U2J4cUFlYnNZV0NrZlZZbWlqL0U4RVY4NmVDNzlPbWozZjk0?= =?utf-8?B?NFhLUHo4YXcvWUNGRGZQeW1JTVpWZ1pUT1V2STZBTU1HMnpEdDlIUmNhRHR3?= =?utf-8?B?cVR4V2RrL2Y3MkoxWlZwemg2ZmZkSlhLU3Z1a2J0N2R1cUVSd08xcm5UdVp1?= =?utf-8?B?YWtjb1BZNnlwSzVwSEVSWDIzd2dwbU83M1lLdTQ4R3VrRDZrRkhBV28zS3Nv?= =?utf-8?B?M2xHcDNHdE5FVkhEQS9iMmdaUUVxalM2bWRWeUN1MDZiQTBUL29qZjhXNHhX?= =?utf-8?B?dGNQZHEwbjBzdGZVVWdkZ2xqbm5OYW5pN0lKOUIyMHdKdC9TZFA4UkxxWXNv?= =?utf-8?Q?ArYQ5lOSnNzfBb5Q=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ac4a882-b144-4775-1719-08ded764ae2f X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 11:34:15.3638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cJ5IjyFf0egS/jwycfYCG9U+fN3E/Q13JH4OAmJhls3sFD1Ja8YFvWkAnzl/f2v01Z0HLXIzgDn3DgrDf5VaFl7Una3AWq9lBds/5ewgOUM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV4PR03MB8356 X-purgate-ID: tlsNG-16d1c6/1782905657-C533668D-054898D8/0/0 X-purgate-type: clean X-purgate-size: 8336 On 19/06/2026 2:04 pm, Frediano Ziglio wrote: > From: Edwin Török > > Allocate these array just once at the start of migration, > using the maximum batch size, and free them at the end. > > Signed-off-by: Edwin Török > Signed-off-by: Frediano Ziglio The reason why these are allocated and freed on every iteration is so they show up as uninitialised to valgrind or ASAN. Maybe that's overly cautious, and maybe we can relax it, but it's also not as if these allocations/frees are anywhere but in the noise on this path. > -- > Changes since v2: > - change prefix in subject. > > Changes since v3: > - fix comment style > > Changes since v4: > - change order of fields in structure. > --- > tools/libs/guest/xg_sr_common.h | 13 +++++++ > tools/libs/guest/xg_sr_save.c | 66 +++++++++++++-------------------- > 2 files changed, 39 insertions(+), 40 deletions(-) > > diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h > index f1573aefcb..95b0564e5c 100644 > --- a/tools/libs/guest/xg_sr_common.h > +++ b/tools/libs/guest/xg_sr_common.h > @@ -209,6 +209,18 @@ static inline int update_blob(struct xc_sr_blob *blob, > return 0; > } > > +struct xc_sr_context_save_buffers > +{ > + xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; > + xen_pfn_t mfns[MAX_BATCH_SIZE]; > + xen_pfn_t types[MAX_BATCH_SIZE]; > + void *guest_data[MAX_BATCH_SIZE]; > + void *local_pages[MAX_BATCH_SIZE]; > + struct iovec iov[MAX_BATCH_SIZE + 2]; /* Headers + data. */ > + uint64_t rec_pfns[MAX_BATCH_SIZE]; > + int errors[MAX_BATCH_SIZE]; > +}; > + > struct xc_sr_context > { > xc_interface *xch; > @@ -244,6 +256,7 @@ struct xc_sr_context > unsigned long *deferred_pages; > unsigned long nr_deferred_pages; > xc_hypercall_buffer_t dirty_bitmap_hbuf; > + struct xc_sr_context_save_buffers *buffers; Please move the higher hunk down here, as:     struct xc_sr_context_safe_buffers {         ...     } *buffers; This helps keep related content together. (I'm half tempted to say they don't even need a second memory allocation, but right now xc_sr_context is 538 bytes, and this buffer object is nearly 16k which we don't really want to be adding as overhead to the restore side.) > } save; > > struct /* Restore data. */ > diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c > index 8c31f9f86c..4988d8040b 100644 > --- a/tools/libs/guest/xg_sr_save.c > +++ b/tools/libs/guest/xg_sr_save.c > @@ -86,16 +86,16 @@ static int write_checkpoint_record(struct xc_sr_context *ctx) > static int write_batch(struct xc_sr_context *ctx) > { > xc_interface *xch = ctx->xch; > - xen_pfn_t *mfns = NULL, *types = NULL; > + xen_pfn_t *mfns, *types; > void *guest_mapping = NULL; > - void **guest_data = NULL; > - void **local_pages = NULL; > - int *errors = NULL, rc = -1; > + void **guest_data; > + void **local_pages; > + int *errors, rc = -1; > unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; > unsigned int nr_pfns = ctx->save.nr_batch_pfns; > void *page, *orig_page; > - uint64_t *rec_pfns = NULL; > - struct iovec *iov = NULL; int iovcnt = 0; > + uint64_t *rec_pfns; > + struct iovec *iov; int iovcnt = 0; > struct { > struct xc_sr_rhdr rec; > struct xc_sr_rec_page_data_header page_data; > @@ -104,26 +104,24 @@ static int write_batch(struct xc_sr_context *ctx) > }; > > assert(nr_pfns != 0); > + assert(nr_pfns <= MAX_BATCH_SIZE); > + assert(ctx->save.buffers); > > /* Mfns of the batch pfns. */ > - mfns = malloc(nr_pfns * sizeof(*mfns)); > + mfns = ctx->save.buffers->mfns; > /* Types of the batch pfns. */ > - types = malloc(nr_pfns * sizeof(*types)); > + types = ctx->save.buffers->types; > /* Errors from attempting to map the gfns. */ > - errors = malloc(nr_pfns * sizeof(*errors)); > + errors = ctx->save.buffers->errors; > /* Pointers to page data to send. Mapped gfns or local allocations. */ > - guest_data = calloc(nr_pfns, sizeof(*guest_data)); > + guest_data = ctx->save.buffers->guest_data; > + memset(guest_data, 0, sizeof(*guest_data) * nr_pfns); > /* Pointers to locally allocated pages. Need freeing. */ > - local_pages = calloc(nr_pfns, sizeof(*local_pages)); > + local_pages = ctx->save.buffers->local_pages; > + memset(local_pages, 0, sizeof(*local_pages) * nr_pfns); > /* iovec[] for writev(). */ > - iov = malloc((nr_pfns + 2) * sizeof(*iov)); > - > - if ( !mfns || !types || !errors || !guest_data || !local_pages || !iov ) > - { > - ERROR("Unable to allocate arrays for a batch of %u pages", > - nr_pfns); > - goto err; > - } > + iov = ctx->save.buffers->iov; > + rec_pfns = ctx->save.buffers->rec_pfns; These two hunks are rather messy.  You don't actually need the first hunk at all; the pointers can all start initialised to NULL. Alternatively, if you want to avoid the redundant assignments, then split the variable block in half and list the second half as /* shorthand names for the buffers */ or somesuch.  This will need to come ahead of the asserts(). But if you're going to try cleaning this up, please do it in a separate patch. > > for ( i = 0; i < nr_pfns; ++i ) > { > @@ -209,14 +207,6 @@ static int write_batch(struct xc_sr_context *ctx) > } > } > > - rec_pfns = malloc(nr_pfns * sizeof(*rec_pfns)); > - if ( !rec_pfns ) > - { > - ERROR("Unable to allocate %zu bytes of memory for page data pfn list", > - nr_pfns * sizeof(*rec_pfns)); > - goto err; > - } > - > hdrs.rec.length = sizeof(hdrs.page_data); > hdrs.rec.length += nr_pfns * sizeof(*rec_pfns); > hdrs.rec.length += nr_pages * PAGE_SIZE; > @@ -267,17 +257,13 @@ static int write_batch(struct xc_sr_context *ctx) > rc = ctx->save.nr_batch_pfns = 0; > > err: > - free(rec_pfns); > if ( guest_mapping ) > xenforeignmemory_unmap(xch->fmem, guest_mapping, nr_pages_mapped); > for ( i = 0; local_pages && i < nr_pfns; ++i ) > + { > free(local_pages[i]); > - free(iov); > - free(local_pages); > - free(guest_data); > - free(errors); > - free(types); > - free(mfns); > + local_pages[i] = NULL; > + } Given this NULL-ing, the memset earlier shouldn't be needed. Along with a memset() over guest_mapping, that gets rid of all the early memset()'s I think. > > return rc; > } > @@ -806,18 +792,18 @@ static int setup(struct xc_sr_context *ctx) > > dirty_bitmap = xc_hypercall_buffer_alloc_pages( > xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); > - ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE * > - sizeof(*ctx->save.batch_pfns)); > ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); > + ctx->save.buffers = calloc(1, sizeof(*ctx->save.buffers)); > > - if ( !ctx->save.batch_pfns || !dirty_bitmap || !ctx->save.deferred_pages ) > + if ( !dirty_bitmap || !ctx->save.deferred_pages || !ctx->save.buffers) > { > - ERROR("Unable to allocate memory for dirty bitmaps, batch pfns and" > - " deferred pages"); > + ERROR("Unable to allocate memory for dirty bitmaps, deferred pages" > + " and various batch buffers"); > rc = -1; > errno = ENOMEM; > goto err; > } > + ctx->save.batch_pfns = ctx->save.buffers->batch_pfns; This is wonky.  As far as I can tell, you've included batch_pfns in the buffers struct, but left it's old pointer in place, meaning it becomes dangling when the allocation is freed. This wants splitting into two patches.  First introduce the buffers struct with batch_pfns moved only, and sort out the allocation here.  Then in the subsequent patch, move the contents of write_batch() into the buffers struct. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:40:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349828.1607464 (Exim 4.92) (envelope-from ) id 1wetIQ-00076p-GO; Wed, 01 Jul 2026 11:40:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349828.1607464; Wed, 01 Jul 2026 11:40:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetIQ-00076G-Bq; Wed, 01 Jul 2026 11:40:02 +0000 Received: by outflank-mailman (input) for mailman id 1349828; Wed, 01 Jul 2026 11:40:01 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetIP-0006su-Jh for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:40:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetIO-002VSd-AA for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:40:00 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44fc87-bab6-0a2a0a5309dd-0a2a4503bf78-18 for ; Wed, 01 Jul 2026 13:40:00 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44fc90-ec1a-0a2a45030019-d155802ee5e2-3 for ; Wed, 01 Jul 2026 13:40:00 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-493ae59eca6so4128385e9.1 for ; Wed, 01 Jul 2026 04:40:00 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef183e7sm65447665e9.2.2026.07.01.04.39.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:39:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782905999; x=1783510799; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=rYKAVaQuo8eKKWDrMgIyL4y5Aht7RlfTqBfK1xy4GQY=; b=Ep6++e/yG73TEZHMv10k5+vFmPgLdOGkkkG/KClO+U4ozE+0bfNy7+dfnp+pormJKy Q3VGxJezZ0JyHNTOx7KQj9fwrubz/iqiqQtkNxLjvrP6S4LPkIoaFY4nSIAfYu9+FJbw RKTjBC/henvZQV8vE5NLEqBXlUAm6x9SX/goT6Fb/iSJ9qXi3KrmFZE+zSo0XgR8tHYF qBu3J7LpgEiSMBn3UU+kKd591cLH+K5ha3YKePMKap+4uCX42khhQXF0K0qVpKlr9Fed 6lPav/hcPgpmEF1AckesVAOhK3M6YCfkdaRN+gK3WyYvc397K2k/up2VhH5f2rLqmPTU sDzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782905999; x=1783510799; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rYKAVaQuo8eKKWDrMgIyL4y5Aht7RlfTqBfK1xy4GQY=; b=ni2adiMDXxkQLlwsCby6hQC5pYEpd1ZkQUU3ouek6bKnxKCYDkK8CBC3Z1THPSKI5W M8AFzyEyTkYisXrF2fUvG0tnGWBd35Ngz0Cc01cKwvS82L8kvIbzfi0y8YTEx7V8mstH CUke2ahYDq/RmUv1uZHwl5QmRt8T/eHvsyJP+4eJtafDbsF1VID2DFzKmhTwvvCTUQlG exbWaL8Xlr9RDse2K2EjXw+xLXGwdw61uck9CeparoKwacydGR/+EcwJ1Y5zFAQ7kniB 7SRv2MPAhNeVAltO6ZktLPUTIlISIB39GnQNBihTT+wlA9PV+EbWmzT8goWN5ZGxsaak fbww== X-Forwarded-Encrypted: i=1; AFNElJ/bMryzsC63Q3y6V2ZXQRN4quTwJ7Sf1eZYK43EW/PQTt4ybrNEpbwhHqi7+Fu345QCtiuBMdvTPkk=@lists.xenproject.org X-Gm-Message-State: AOJu0YwwW0AEBMJe9FG7RF0xZ0vrr/F5DBdjMOeC559Ri0PUsEv/Efan Delcto62BVOGsfdibwo1kBsv3GGs5jKdrCrxwn4n7FPRUPol0rt3I0x5IVw/IgInqw== X-Gm-Gg: AfdE7ckDjSfByPs03F5+L/2BqzhrBaqQz67KUSsBhLvh3wKabCHLF7ACkUcJGloNfth PmrKxFAiKmKoLK/fZ9fOfnD4sGOwOWFMw35mHNZm78nR0hRYrZ6qGrtAlVAl5d2XthTv8vsHU/8 ibhHofuuzVvJxndnQV7pmBJ5Lss7Yq0MnYZmlnn6cp/JkMQGNpbhQOay641dayrhATGOL16G7Xw G0EU3FzSH1o2Un22FNmocDLrNfYJOZId3csuvWmbxNkUpabr0CDNYCuSuom1PBBivkAMxw5Xe/J xuaReWuZQ8yHnmVn8niq4LNB5yaoZMk9cmkplA97EpYehqfh6ugSiZbMPZ+nvKa3toULvQPJuc+ xN7dKBfQk509cnezq6/vJGz4C7+pg1lkBvx3VoHneCb9bhK/qExLSGSdA2lnKgdPPkdbnUJDAch ieHV3l8T6PXx92mpLG0TrHoCJS/pGSLy1mMbHf5zWh5KGpZbJwX15+movcY+USP3GFcux1XfZRo VWy X-Received: by 2002:a05:600c:5292:b0:492:3754:15f2 with SMTP id 5b1f17b1804b1-493c3cfbc7amr2855425e9.32.1782905999644; Wed, 01 Jul 2026 04:39:59 -0700 (PDT) Message-ID: <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Date: Wed, 1 Jul 2026 13:39:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Juergen Gross Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260701111606.4063972-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1782906000-0672E5D1-AE22DE4B/0/0 X-purgate-type: clean X-purgate-size: 1140 On 01.07.2026 13:16, Juergen Gross wrote: > Today the XEN_DOMCTL_setvcpuaffinity hypercall will not only change the > affinity settings of a vcpu, it will return the new effective settings, > too. > > In case an error happens during this hypercall, the expectation of the > caller is that the affinity of the vcpu didn't change. This isn't true, > however, if passing the new effective affinity back to the user is > failing. That'll be the caller's fault though. Any -EFAULT coming back are an indication that the caller needs fixing. > Instead of making error handling in the hypervisor even more complex, > just change the interface by NOT passing back the new affinity. It can > easily be obtained by another XEN_DOMCTL_getvcpuaffinity call if > needed. At the expense of further increasing the pressure on the domctl lock. When making the recent error code change in this area, I was actually wondering in how far these two sub-ops might also be candidates for moving out of the locked region. Yet with vcpu_affinity_domctl() not using any locking that didn't look entirely straightforward to answer. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:45:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:45:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349838.1607473 (Exim 4.92) (envelope-from ) id 1wetNr-0008SW-1i; Wed, 01 Jul 2026 11:45:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349838.1607473; Wed, 01 Jul 2026 11:45:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetNq-0008SP-UL; Wed, 01 Jul 2026 11:45:38 +0000 Received: by outflank-mailman (input) for mailman id 1349838; Wed, 01 Jul 2026 11:45:38 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetNp-0008SJ-Sj for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:45:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetNo-008PFT-Tw for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:45:36 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44fdda-5cb7-0a2a0a5109dd-0a2a4502b166-24 for ; Wed, 01 Jul 2026 13:45:36 +0200 Received: from [209.85.221.48] (helo=mail-wr1-f48.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44fde0-5a27-0a2a45020019-d155dd30e5f1-3 for ; Wed, 01 Jul 2026 13:45:36 +0200 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-4759b4f0897so427502f8f.1 for ; Wed, 01 Jul 2026 04:45:36 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47566743895sm17461760f8f.25.2026.07.01.04.45.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:45:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782906336; x=1783511136; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=5hrIydMOAiTB5cTAwAIR2dJyjPbp8ikRcPYLGTbOWX8=; b=OsK1Rr49K/rq0vVG+p1SJL6K9HXhLm8bd/S8LWDLkMgrk0FdlTT58NiJco5w6/IyW7 yMjCSYwG/uSB+U4snYVDGVBzw+a0vqkuvXFe1GsMQiRPsQUF/G4FHzhFpTSoWMYqQ7uP DgzKf2EmPuyYUK8q/dFsV1CURYlON1RjaVrpgdsnSwjKDywH2uElOGtWpqWlYzrHEERu 4fufTV4NRLME5zOCaIf0FDjv0mRVuQvSoA3WesSp3adLem/tpMd5lzk0QyQMcXVzgF/y JLVOYrUZeCda2S0zBpJakUym78Gb3WHEsImx7Ajbcm7YXGKQmJInbVdaGEQSPqs72B8A uqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782906336; x=1783511136; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5hrIydMOAiTB5cTAwAIR2dJyjPbp8ikRcPYLGTbOWX8=; b=YQ3nppLZkl1GbhQ26inqchzGq92IR8l4Fa9oh1rm6GvaVH9bs4iggfvksSFtxvOVHo I03IZZCMiGcOZNstiuQ2s2gwQzFrYc+sqywMYGdPwKriAX4c62dQ6ududG5knT2x7EJQ 9bDaThFndXzKLJGIRa4/pXv9PX35KJnDFVNZX30mzx7R6q4QAvI3N3AzBixBSdK/jJGs VVv7HG+Hkne/XKVuLXbf9fdB5TnEsXN7fzQCIjpYhPRyfpHaeDbnAQrVeUovx8guaZVw L6+8RXFkcke2HT6AmbIonmKvpZ90MaK5t4gUAP4YPNfVwJfIoKMQ1RtYdqZmNFQE9utO b1Zg== X-Forwarded-Encrypted: i=1; AHgh+RqtD7a5OxvfaQNPbtnhJKmc4ev2O99dDUl5rnSASGND8RMopXqFH4ux9s/r4qDdKcaqP3bqtDgMo0o=@lists.xenproject.org X-Gm-Message-State: AOJu0YxztIpUN29V18Sel8O7W7V8xi7LQkPixuJTM0pawcJ92lxe4Jfs b2PVwz/a41skHVJ83Av7z0qNjvlDjuvjPhgLBXKC33jFACsgS7xO7pGDDXnS9G4Z0g== X-Gm-Gg: AfdE7cl0axcjVmBzha9AP8tQhBQB4AhKi44ytFTQdzBybN5zAvj3WiZ8QpfMCObAeNC tyTJ3vhvjccHIn6LpJNPOstaHdpbHSaz75mLGrcdmEZhfVbipLbken65eIChoUqRJKltNyyL9NO fJnpJ47RR1JSbM4cWcZCN8G4R2m2K8PPLLAKHOs5Z25iNgXRsNxcT3+h/VsFopQIeb/m4tZoLQi wmPGOsDJO57OIsYt9OausuLmWqHqxVypJZ2kY7RtcWhyG9GuKUah2M3nDT0hesm5niTVVMm6e1p 0ATaefjIjRpQZTdntakJIrBCgA7QvM9jwX3wdIEUVqaT1IR6WcRNnxhIUtxqXuZOmMML4wV4cAO v9Q0XbbLsl85O1JFSSEkvtxi1JYd7HoD8p1885sVFR7fXgN+JASYMJ+wAZDg8FEG7u6H483dZC3 RnVzAUU5ESCxm2Hu5kNG/rbHntTKRq5SW2bnWfHjcuWFvLOqprzMAV/6o/aucUX1ZZ7O9rUxqgm MDl X-Received: by 2002:a05:6000:40db:b0:476:d13f:bb74 with SMTP id ffacd0b85a97d-477b3889836mr224557f8f.15.1782906336158; Wed, 01 Jul 2026 04:45:36 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 13:45:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration To: Hirokazu Takahashi Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <20260629215806.11610-1-taka@valinux.co.jp> <20260629215806.11610-2-taka@valinux.co.jp> <97dd9fd5-c0de-4125-a40a-b7f6e1aed27d@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1782906336-545187C5-066B2D5A/0/0 X-purgate-type: clean X-purgate-size: 1164 On 01.07.2026 13:11, Hirokazu Takahashi wrote: >>> +static unsigned int __init get_cpu_for_node(struct dt_device_node *node) >> >> Pointer-to-const? > > Do you mean this should be replaced with the following line? > static unsigned int __init get_cpu_for_node(struct dt_device_node *const node) No, that's a const pointer-to-something. static unsigned int __init get_cpu_for_node(const struct dt_device_node *node) >>> +#else /* CONFIG_CPU_TOPOLOGY */ >>> + >>> +#define cpu_topology ((struct cpu_topology *)NULL) >> >> Why exactly is this needed? It very much looks as if its presence may hide bugs. > > In the current code, the condition if ( cpu_topology ) is used to cover both cases: > when CONFIG_CPU_TOPOLOGY is disabled, and when memory allocation for > topology table fails. > > The next patch uses if ( cpu_topology ). > > static int setup_cpu_sibling_map(int cpu) > { > if ( !zalloc_cpumask_var(&per_cpu(cpu_sibling_mask, cpu)) || > !zalloc_cpumask_var(&per_cpu(cpu_core_mask, cpu)) ) > return -ENOMEM; > > if ( cpu_topology ) if ( IS_ENABLED(CONFIG_GENERIC_CPU_TOPOLOGY) ) Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:45:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:45:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349840.1607481 (Exim 4.92) (envelope-from ) id 1wetOB-0000MT-Bl; Wed, 01 Jul 2026 11:45:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349840.1607481; Wed, 01 Jul 2026 11:45:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetOB-0000MK-8n; Wed, 01 Jul 2026 11:45:59 +0000 Received: by outflank-mailman (input) for mailman id 1349840; Wed, 01 Jul 2026 11:45:57 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetO9-0000Ki-BJ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:45:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetO8-008PKA-O8 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:45:56 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44fdef-5cb7-0a2a0a5109dd-0a2a4502c3b6-12 for ; Wed, 01 Jul 2026 13:45:56 +0200 Received: from [52.101.52.30] (helo=BL2PR02CU003.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44fdf3-5a27-0a2a45020019-3465341e313a-3 for ; Wed, 01 Jul 2026 13:45:56 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by PH7PR03MB7046.namprd03.prod.outlook.com (2603:10b6:510:2b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.14; Wed, 1 Jul 2026 11:45:52 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Wed, 1 Jul 2026 11:45:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QJzSbWKGWhvITfFOAs179X3pp2NBtZDxe3KNlK+Ythw9J9n4e0Gn1iVIKuMUfU639os20dTfB26y/C1DPTnYm8sZgLd00J70PwueE06st7npLMNzgJ4fxWyT79j46g/iaX8GpDndOzE4h00yJhoFTEA+C8NQxTR80GdFJ+MswAeunoDzVytjRmw4bqw5ysmoQqOabm0C/osbFgshiUMSmJMIZGDaY08WBfZ9o5UKD2MdH3ClZunjPTOyo2qmeqDg4V/zwNKrtx1U0hH9HXRvMCZhyA06mcPoj63NEHaef6c96Vl8GABOKSGfrC+nGVAf+2fOpuz7wd0xUcodwjHk3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WueZbxSu5EcZz33Apb7DEOQvnEy4dTm+LqS2QV4IlrI=; b=j9HhHSXPlnGDgRpZrTwi3izVYvnFWEJyfBwWf5gwR5xhsgHPQ+NBuA2iLrvFiWE5gue3nTn5TDd+z2z84V0KA0sbsWkbH0nQnAl52B0hIUutTpIyOqj9MAtbrD40oRdrrzQV9Hq4qefGhHPS0u8GRG7g6q54f6Xrx5stY0O+c0bpbmrNN9u3STpZc0E5E+eTXl6qtj9XS5UULQnw8qPj7thp3lEdP8GmhoL8oy3v9f4mt3eVwAcOYHlSx6/NskRL3g4Bi+l3F6wSVSbDwb/vCZRJua3agRyR2OWDEjAFbcPGqfjQR11dql4YNgCjFiHk0nAKLpl7fx5K3x0jk71Kmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WueZbxSu5EcZz33Apb7DEOQvnEy4dTm+LqS2QV4IlrI=; b=wrZgnpiNc7MamjcHyTfqzlu/WRXhizOumvOyOCn1VIxRd3XWZPHNBdOdIlE+mATqqoLdtdVee6D0FhvGyBdOegsF4r/8vxvYde6GSsDNkzb1k7qoHIE1/wNat+GS7SyNXhFVTxmhHmKzuUA7vb/cLeQIM5W3/iMLkWEQfnBLoM8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <4524812f-b9ee-4ef5-b5c6-7583815e859b@citrix.com> Date: Wed, 1 Jul 2026 12:45:48 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Anthony PERARD , Dario Faggioli , George Dunlap , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Jan Beulich , Juergen Gross References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0615.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::17) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|PH7PR03MB7046:EE_ X-MS-Office365-Filtering-Correlation-Id: 4986ef8b-c074-45fd-72e5-08ded7664dc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|4143699003|6133799003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 5VyJYrGJAoDB0ON/XCfXr4uUpA2USPuoKMPZJlQiqajkNoFE4LvGN7Rv8Zo6iWxLb5zKhXITWhdO+gJRZxtOJRm0LtT5zPmPyNKk5zy1heT6LjGp0XQt4+ETUAmDVzh6cOWWnU5tqMGHjcVqhWLoMnR7S1oac6ABv8J4HTCxtr/WfLuQwSYXsubNiDItnoFA8xta7cJ8J6ZasPeX6voXfxPbpbzFjncPPai2lEyUSKCq1eqRZV0I/cpoXwEK5I7Jb91Mdkz9Bi/V/6ESos8/dJAbwVKwW2hBvc6xeQj/SUx7R9YEeRbNzW4emGhuL5Dk4owSl+6gdh4X9mRB0s3CO7kbdSO7V/l06zVQjTt++QqRJ2G3WnzPo3nTZQqjauXF8FixCXBhlMUMfC90+P1lph68keCO8mu0K1YbegDoQUa+7d7ivfN3sGiHVx4y2Xpw3nuyw4i6/z0rDn2YSc30jh9gDOVKFMoYnoOYAZS0/ZDHIbPkm8oYlVo/w1lHv2axDxGgDVXC0n2yjoNZjDPsLYbkeb/QZyibZVA9SWlhlltHbnogk+YjpIl/xw8+d3QmvwdvPtNEHMFefiAQuMK14c1SA8iSyQrlB9yDC9IRh7bM9/15bvdBr+SeTEsQvniG/7jEzon6zrawGRcevbo44cDU/7RVKh4Cj2DGwpyvLVs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(4143699003)(6133799003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXZlZll3L2dlZXhRMjNpRCs2RlpWckcvL1ZMdS94ejM3bnpkYzlteW9ybmJr?= =?utf-8?B?dGl2MkxJamFjS2NOZVF0KytoekFaeURNMjUzRGZWQjZlZjJDbk5Td3JKcUJY?= =?utf-8?B?cUptZm9yZjJIZk1USFY4bkhveEJ5dGQ5UEJTb2xHRWZ6VVJhYmc2S2Q5Z1ZK?= =?utf-8?B?ZVpucjQ0UXhSa1BQN3pIUjA1eGN2NzdjWWM1eVRYbzJ2emdKcUlUMkdDWUR2?= =?utf-8?B?aDRabUdDUVFvMXBibGV1SjYxQTl4NlJoUHY1dUs3YUo2V3VPQURPRkJhckhx?= =?utf-8?B?TEN5WGpVaFkyUE55RkhKUEN5MnNhcVpubzVNdmRXQ3l6MGR3cThFNEl5TEY3?= =?utf-8?B?ek9NMTJOWEp1c08rdmxDVDBmN1drQ2xuNjN4dmc4cUF1VkVLZHZBL1YxbEFv?= =?utf-8?B?TFZQWVlpb0RSK0lSUnNPNnd0THFHYW5Tb2dYeWJ6V3ZpdzQ2Ly9xZXJUdTVG?= =?utf-8?B?UWZKRTdyMXhVWm1BVWc4RGtranA3UWp4d2FueGxGREFsbHRyZjdBNExLQ0Q2?= =?utf-8?B?TGtNeCtvdGUrdmFqR25MVi9sVUVITkJUZVY4UzFqZ0l4dVhaRFNVOWhET0Rw?= =?utf-8?B?OFJNeVpUMHFsZnQxS00zQ2twQlkzc2N6dmsxcHJVbk82bktjeW1jSlFiSXUw?= =?utf-8?B?eUx1UjYvbzB1MGg4Zll0b1VUdTEwMjNUK2FhZmJqZUIyVEdGa2FESW9nNnV5?= =?utf-8?B?ejRoUS9rL3ZkNmJmUmVhcFk2dkJPZnVybUVVYlRMaW56NVR0NDF6dVlteGtJ?= =?utf-8?B?VFF3UW1XWjR0YVE4VWdFNkl0cFlmWlR6aC9kdFJ1ZUhZK2hoRlFPangweENY?= =?utf-8?B?QWtYc293Q1JxTUNmYWJSZllUeWxJL3kwcjFiOWVVZVlpRU9CMjA3bENtYUlV?= =?utf-8?B?NmhWY2RPTkRKWGJQbTM3MUxoeFFCdDJJWlRRR2YvQnNxY1FiT3U4YlRWUnVI?= =?utf-8?B?MFdsbU56TmtKUzI1SXpIQ2hsbnVwNG9TVEU3cXQ0eExQQURWOW1OZ1o3UmdS?= =?utf-8?B?eFJnWmdNUEtCWk1GTTMzQWk2WStjdkVFbStwaFdnclNKL0dsTkd1S3ZRZk5t?= =?utf-8?B?ODlQMFpITHRtNmhrVGNJYnJzMXZncXdJYVZVWGoycDExb2NKNEdiK2FjT0tI?= =?utf-8?B?MGt4Q0RVSStNcUFYTXdIY2JhRVUxZUt4U0RVbGdXNnQrYVV0Mk5BSmJxT1VQ?= =?utf-8?B?NU81QitmcnlWcnUzZzkrZUs2VlovejZSdWtsclRLZzBWdGZpNjdNVCtRQWJO?= =?utf-8?B?emNjb0hiR0NoS1dVWFpKWDV0MGxLRys0bFV4dG9aMEJRbWFTczVJWUVaNG1v?= =?utf-8?B?S0hySVh3QVFpMjg4UmRCamw4VHo1azExVU1wVDZ3Nkh0MDlIUExPUkIrR3Jl?= =?utf-8?B?Rkt0elllYS9KVGZWTDlwdXgzMXZoWHptL25WMjl4M2FKSElNcXZ3b1JrOXRE?= =?utf-8?B?USs0SS9aOGttdWN4U3dwWDQwamNwSEI2VU0zY2s5K2pNUEk3d25LTU5lMk9U?= =?utf-8?B?dFRhV0J1cnp6dllpNm0wQ0tSSHY5NjV3dzVvRUlUckVJUjZUNWZsUFl0UzdT?= =?utf-8?B?bDNqbGl4MDd5djhaZmRISllMb2phaklQMTZOZGx0djkzZEtUSGQ4S0I2N0xt?= =?utf-8?B?UmQ1ZVNtRENIK2hJemJ3VDRIdmRUSWZEOTUrYm9rb01qWElJNlJ5QjBkZmZ6?= =?utf-8?B?OXBmVm1BT3JVcVptbWRVVHUzK214dDJNVlJnNS9KMHRGNGY5R09Ib1Fjd01W?= =?utf-8?B?TGJPSFBKS2RUNXVwaHI3emlsV25ReTBtNjlBWTczOEZhYXRzQlNNbEVrM05l?= =?utf-8?B?K3F0VjlydUZZdzZKM0hka2lPWExMTkV0L2JuWkxDQVhFR3duNGdTMTJPYVZD?= =?utf-8?B?c29mdTcvcXIrcE1kdG1SNjVpME1BMWRQTk1mN0xXemNGb2JpS2Rrei81b2lK?= =?utf-8?B?eE1XQjBiYTVSdldOSnpRMEtQTnZiTEdaL0dOQjdlc1pvNWdOMm5uWC84WFAz?= =?utf-8?B?SjFiN1loMWQ0YXhTUTQ5U0JpYTBhZTBhNE93NkI3cng4ejk4b0hFZkdDT0Nw?= =?utf-8?B?SXdQelhoVGRFc0F6MmhuUkU2bHZRTnFXMXVOSmx6OVNVb1orNFB4M0ZUWHNm?= =?utf-8?B?UUh2c05sUGpOSEpKVmhjTnRvK2hWbkVXWERXZ1l6YXhad3BBWllablVUa3g2?= =?utf-8?B?M3liYmxwQnlFWGFPbXlWZFo4dFRRaVNjK1lLVEFWNnVuUmRnZkovVDFzVzlr?= =?utf-8?B?bnBrYXFTcnVzMlZQejJaeXFBZWFsb3E2cnBHLzErUERRaHkyMHNKN051ZXVu?= =?utf-8?B?QjkxZXdYek9KU3YvOUdMeXYwOXB6NEVMY1FnYURWUVhYODlId1I3cnd6WGtV?= =?utf-8?Q?0xIXZdVwvZHrhtQM=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4986ef8b-c074-45fd-72e5-08ded7664dc2 X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 11:45:52.4960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dYOsnaYYPiZd4tfGUxUUjqmGAcxbmvphEbwLBxqxoKoouxfyyySroTiDpIdZLKELOHq1D5U1Vd5Q+RrG/Y8sH58rpSYCMbu3Cntvh0Pjdmo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7046 X-purgate-ID: tlsNG-720697/1782906356-4F3137C5-23569715/0/0 X-purgate-type: clean X-purgate-size: 1575 On 01/07/2026 12:39 pm, Jan Beulich wrote: > On 01.07.2026 13:16, Juergen Gross wrote: >> Today the XEN_DOMCTL_setvcpuaffinity hypercall will not only change the >> affinity settings of a vcpu, it will return the new effective settings, >> too. >> >> In case an error happens during this hypercall, the expectation of the >> caller is that the affinity of the vcpu didn't change. This isn't true, >> however, if passing the new effective affinity back to the user is >> failing. > That'll be the caller's fault though. Any -EFAULT coming back are an > indication that the caller needs fixing. > >> Instead of making error handling in the hypervisor even more complex, >> just change the interface by NOT passing back the new affinity. It can >> easily be obtained by another XEN_DOMCTL_getvcpuaffinity call if >> needed. > At the expense of further increasing the pressure on the domctl lock. > When making the recent error code change in this area, I was actually > wondering in how far these two sub-ops might also be candidates for > moving out of the locked region. Yet with vcpu_affinity_domctl() not > using any locking that didn't look entirely straightforward to answer. How does the effective setting differ from what's passed in? I hadn't even realised that we pass data out of the set op, and it does smell of bad API design. While we do care about the domctl lock, I don't consider "extra pressure on it" as a valid argument to be used here.  It's an internal detail, whereas the hypercall API is an external detail. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:47:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:47:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349855.1607490 (Exim 4.92) (envelope-from ) id 1wetPW-00012g-MR; Wed, 01 Jul 2026 11:47:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349855.1607490; Wed, 01 Jul 2026 11:47:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetPW-00012Z-Jb; Wed, 01 Jul 2026 11:47:22 +0000 Received: by outflank-mailman (input) for mailman id 1349855; Wed, 01 Jul 2026 11:47:21 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetPV-00012P-47 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:47:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetPU-00Amoy-HG for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:47:20 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44fe42-5cb7-0a2a0a5109dd-0a2a4508de3a-34 for ; Wed, 01 Jul 2026 13:47:20 +0200 Received: from [40.93.201.38] (helo=CY3PR05CU001.outbound.protection.outlook.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44fe46-edec-0a2a45080019-285dc926ec90-4 for ; Wed, 01 Jul 2026 13:47:20 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by PH7PR03MB7046.namprd03.prod.outlook.com (2603:10b6:510:2b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.14; Wed, 1 Jul 2026 11:47:16 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Wed, 1 Jul 2026 11:47:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZnZuBgRKmk9wnAttSHvXEUNc/Zw+81XGTOoIuFiW+rnV9nx7cpb/wtvL26u/P+thGr/Rr9zyPr4f5ZMHHe/k04Bf4cz2sn4+IUcXwNV0VitcRg8GbO0G/rITzmjWlkQCwK8MYVnVRbJzYrzIoRAsqMU20tMH5qkPxSH+1ZbZcJd/afIJFxUEeO62iaOnMc9bA1NvYOJBlIRB7SMdFbWxW+BX7YhenPMzSdu0bZygE8ZUR6rd32k3bDU774u1aH+Mm08OVNNZ8b9AZnzDByBg0dvqeVohTz2D8kw6WoTEqrvivCukhwD+3ykWE1mcTA7wKu5r6UgI/YxWJfIQf5ESeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rXjQ95t2lfcDtpe47bRxVISFPg4U+DnFnDalVW391eQ=; b=bQ6AESssJ0o61uZdXia/cNatm88u4pk8CtRx9o5V9F6Otlll9iym4RTBRKrtR4SxaDeE8IQyLow/8dWBvgwPXBLruhpTfApXXVfC6Qi+v20WDIQGfRZi9i3U967fMsVparXNhvA8nZmTti2T8GI0gmps/FlsuoUPGy484rt8CP2NED/e8ZiAHe5xdsN19/DFV8kjPMUG/rvbubQVGl1GIOTdjYorn6q9FOKOq3IdPFEv3l4kLFjk8nLVZ64fgL01DVyVvR0SVl7p+VEbbzBbY4Jc+ZTaxSETrTfIjpl7HYwVXbkdJgf3IAOLN03k042C12g9LaXyFC8W3+cK6JPRzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rXjQ95t2lfcDtpe47bRxVISFPg4U+DnFnDalVW391eQ=; b=XsFlseGop5aJpFTpu9uxHrjoDPFJpDmgWsfMD0katQwSKn0SicBBL86WfAUKypWqvkCTZk41ra8DlBj9/iSBpZzp5/mIqtnej3qEnIBcbrDQg/Ikuvly2U68az5iUAyC9r3vPavKTZOdDjzkziyZRUg82Y4U1i9U8oZLOknnZ1M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7ae3b2d9-3455-49e3-ac37-cb85d1e043da@citrix.com> Date: Wed, 1 Jul 2026 12:47:13 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Frediano Ziglio , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: Re: [PATCH v6 08/16] libs/guest: fill directly iov structure To: Frediano Ziglio , xen-devel@lists.xenproject.org References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-9-frediano.ziglio@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260619130501.272832-9-frediano.ziglio@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0611.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::10) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|PH7PR03MB7046:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cd3e53d-c311-4d72-eaa9-08ded7667fad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|4143699003|6133799003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: eUz/Syqc54wr7COrUFVDM2qadCLMAGzQbJl4GGlGwb88p2Gfr28V0ebBBCZOwkDdZAWcQj38uJ++lzxSwDg5LBFCuSZ/1yxIhR5n62BorGQ0YcPFmtWkLqzzqQaxhAasMgDcN6tnv0kg8bsqjRL0RMNshcYxqLoGvSinQJ27ce4PDGmZgCXGhT17EO8TzkuictLkLFb42l1I5QL18WBArjq0UgFa6GUSZYc9qALac2Cq1k2XV2Z8TzGVOx3y9SFoXOBGmxW3WIM3FEei3371Z9op7jTPLq0KgGHxii8eMJzI8t0qEFdyn5QgjGiBK2RlutTEWvPzIfIdoQYh9kPrvsAi1weCeVWijF6fSN/FOD33H4BKKJhietk1x1We7wbVWhiG2qJZuMDDkmP0c8oSJUXGxtH0SRJtaxARUvPGffobEOj3AVdMtqVBaaA4flC2y2SUIOBP+LiWBmJBqNRaW2MViqSpjoooCTyzYxUWbIC0TUn9xlZZ171X8U5g9F8tEGtIw+lK+NpEc5ZIDn1pg4sRWZakQjTjOWGQaUqx8ocdYdjWvtWUvfZfWuZTxvjvrpc1C+rtRYsvgTvEkHYQmjW+ZjYt3cmWKoMxfXigdxh2G2SWYTNBmwd9XSUZkLNv0T+6/ha6jHKDR59u3GZ9Fm9pl2f40mAsUXmgT3vNY5Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(4143699003)(6133799003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWh1aGNRMVh4Z1Y5YmNqNlBvdlpRVTY4NTVTS3l3RldzVm9iWFNIMDFCNTF4?= =?utf-8?B?b1FETERqcm54TWhTTmh1bVVaZFlESGRMdnpjamhxdm5SQlE1d01ZWVZVbXNP?= =?utf-8?B?b0dqWnM5VWM2aDdaUmRFNERzU000SjdSa0tsbUpiWHREdWI4VGlNaXEvTUts?= =?utf-8?B?T3NEOWlwNkJSazNTZ2JmWkVMMWhoaUFkdWh6cUVJZjQ0cFhIaVpReTl6bDJm?= =?utf-8?B?Qi8vUllzQUd4VjhyRVUrdFlHaXFFWWVoemJ5RTV5emRvQlk2K2FkcDdXN1FI?= =?utf-8?B?VU1tN2M5aGNRV3doRitMa2xTRDB1ZDh1UHBHR1FFVnFBcXBBQS9lZCsxTTAy?= =?utf-8?B?cHdQRmlFajN3TTFlZWRyeGE4bnU0amQ0bjZscEViVEtsRTR6QW1Jc1VTL1BW?= =?utf-8?B?WmRSdXlDVDFKTk8zNUZ5VlVaNFk4REg0alRCNktqMFBqdTQ3L2w0RFlUT2RZ?= =?utf-8?B?d05EbWdObFExUk50WUpuNlJnanBLODc2ZXB5UmZtN3VPNHE2akVkNU83WS9x?= =?utf-8?B?L3Z0VHRnOHp4Z082N1ExS3NCUzFHMTRxMnc4Z0lCcmROY2N5OUNybjE2dGo1?= =?utf-8?B?U2NrenJMQndidi9sempLQVNjQnE0OXgyc1o3NHgzZGRKRjZSdXN2eHo2eTlp?= =?utf-8?B?bC8xalcvazlyR0Rsbm1GQnFxQzgyRkpLK0t0dzBPSmVlVk5xU1VDSkRncVp0?= =?utf-8?B?eEhkaFhNbzF5VThGNENFWW14cXMvcWFVM0RWa0hEaUljRTJXSExTRGdjT0Zi?= =?utf-8?B?V3BPQmx3aW1sNnFJVW9qT3NBUDQ1ODdYL21rYVFZWmhGVEZOdHJTY0lpYWZx?= =?utf-8?B?czM4TFBkOG1uMG1wdkNJVGszRlZrWEtqUlpXU0hLa21jTDlPcmR6ZDRPMmJ6?= =?utf-8?B?ZEF2WlBtRXI2RjJzNWFyckNpVS9yWE5veEU2STQvcE9yVXZDSHNYekVxRTlt?= =?utf-8?B?K2lLMndDRW82cTNVUlNvSW1FcmRMT0ZNUDd5V3N3MGRQSjNoTmhSS1k0TWkz?= =?utf-8?B?K1E0SmpLNFRhQXhVaFZiK2hrVXhRVFRMdHBLOTc0ejBXMEFGcjJsdGlKVmVk?= =?utf-8?B?UDRncm82Y1JOKzRpYTY0SDVicnBnZi9SL1VkS2NocTNtWGVBckRVSDJEQ0xp?= =?utf-8?B?QXE0aklEUUJqdlF6QWFVYlRaVmdPcGtMWTZnRlF4Zm1UcThOWFY5WVNKclUr?= =?utf-8?B?b0l4elhOZ2N4UHBFV2JDdmp2eldKWXRRNWsyTm0wKzgreFgvbHN0c242eFRz?= =?utf-8?B?QTRPQnZ4RjZKMnBvTHpjczBvOEdpbEdOeFZnQXZ5Z3lEK1ZIWDU1bkZvU0xr?= =?utf-8?B?QmRrWm1rYUtLTE5jTVJOTXh6UWVMTklXN0NTS2JCcDV1alFqUFoxNllJZzh4?= =?utf-8?B?TXlFcm5NOXRLVGFhcXBIUW1CcEdYdGNvYXgrYm1YUkNiam1HQVhaZk1WbGM2?= =?utf-8?B?N2R5UUhHS3ltdGxmQ053NXV4ZGVqd2JOWWN3OHZkemQ3UHk3U1kvUGcra3hR?= =?utf-8?B?eXoycE9Nc21mM2liOFFMMGlrOFIvN1liMS9vWS9XelJOMjUySFpZekowSnVi?= =?utf-8?B?U2Rad2NaQXNPYVpidHZqMURWNCtDZGJRMmhiQ21GK2VTMkNqaWFRTENIYTFo?= =?utf-8?B?OXo3V3R5cmV3dnpCZkxXZlI0TGhGMXBSSFplZGFkRDRGbDZ6UUs1OTJwbjRZ?= =?utf-8?B?L04vOUo0OWlxaWF0WHFiekx0Vm9KQ1BWOEltRUEyOTNPOGhCNXpUajN2R2RL?= =?utf-8?B?c2ZXNldSVXkzdFpGZ3lwWlBMZCtBdy92OEp6eVBXR29aWE94YUt6REd3MXRy?= =?utf-8?B?ditnWnpGV1FMS1ZXZUwyMk5sdlZTR0ZWOUZBRnBIVnNYZDlUWUJNa2l3OVRz?= =?utf-8?B?UjYyV2lrTmVRNkY0WDZYZkk3ZEJBekpUTEFWYjZQVjNycUNrc2huSGltVUNj?= =?utf-8?B?T3J6enVPSm1FMmlHaVJGbmg1aWY5Q0pwd1o5ZTdzbktzNVV4azNidldNWEFl?= =?utf-8?B?bWVXelZjQmc5clpKUSswcnJQVWVyRlV0SkJnTURMbWFLc2hKMllNR1Rkc0d3?= =?utf-8?B?U2d0ZG1xRE9LT2xKVzRWYWhac0tqeWpvWXBBbGQzaVY4WDNJN3hzWHRDT0Ja?= =?utf-8?B?VWUvSVlqbStQM2hiQVI0V3lBTnZia1BWUzJVSjB1L1lYaGs0blo0V2R0MVJ2?= =?utf-8?B?NE1LZVZ5NWhxRmxZRW0zQXNScFh0c0hXYTBHVHRZUEFRdlQvTWdrbEhwWWVk?= =?utf-8?B?N3g3b0JVMUlsNGY3YzU5bXBJS3QxRktDNGMwa2hBWUJ2SDlpTFgvL2I3WFR5?= =?utf-8?B?TWJwcG9WU1pnT0dxUDlmS3BYMFFyOTJoWWkzTWw2WDNLSjdFQnZKZ1ZUZ3h5?= =?utf-8?Q?VdpiU3zpRgGRQ24A=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cd3e53d-c311-4d72-eaa9-08ded7667fad X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 11:47:16.2531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cpewHvgBiRSXcsbKUqSdW8PyrTVVr26rEpj4Qh/gFI0Wsv+6y7zFJPLgAdFIdu3GBKaxE64oJDk2j7OjrOg8L4CY3M13TO9a8M5X+oSiNAI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7046 X-purgate-ID: tlsNG-c1860d/1782906440-A3F323FC-4720F598/0/0 X-purgate-type: clean X-purgate-size: 5189 On 19/06/2026 2:04 pm, Frediano Ziglio wrote: > Instead of storing page pointers into an array and lately adding to > iov vector add the pages directly to iov to avoid "guest_data" > array. > > Signed-off-by: Frediano Ziglio > --- > tools/libs/guest/xg_sr_common.h | 1 - > tools/libs/guest/xg_sr_save.c | 64 ++++++++++++--------------------- > 2 files changed, 23 insertions(+), 42 deletions(-) > > diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h > index 95b0564e5c..b2c441b644 100644 > --- a/tools/libs/guest/xg_sr_common.h > +++ b/tools/libs/guest/xg_sr_common.h > @@ -214,7 +214,6 @@ struct xc_sr_context_save_buffers > xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; > xen_pfn_t mfns[MAX_BATCH_SIZE]; > xen_pfn_t types[MAX_BATCH_SIZE]; > - void *guest_data[MAX_BATCH_SIZE]; > void *local_pages[MAX_BATCH_SIZE]; > struct iovec iov[MAX_BATCH_SIZE + 2]; /* Headers + data. */ > uint64_t rec_pfns[MAX_BATCH_SIZE]; > diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c > index 4988d8040b..8a22267fdf 100644 > --- a/tools/libs/guest/xg_sr_save.c > +++ b/tools/libs/guest/xg_sr_save.c > @@ -88,7 +88,6 @@ static int write_batch(struct xc_sr_context *ctx) > xc_interface *xch = ctx->xch; > xen_pfn_t *mfns, *types; > void *guest_mapping = NULL; > - void **guest_data; > void **local_pages; > int *errors, rc = -1; > unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; > @@ -113,9 +112,6 @@ static int write_batch(struct xc_sr_context *ctx) > types = ctx->save.buffers->types; > /* Errors from attempting to map the gfns. */ > errors = ctx->save.buffers->errors; > - /* Pointers to page data to send. Mapped gfns or local allocations. */ > - guest_data = ctx->save.buffers->guest_data; > - memset(guest_data, 0, sizeof(*guest_data) * nr_pfns); > /* Pointers to locally allocated pages. Need freeing. */ > local_pages = ctx->save.buffers->local_pages; > memset(local_pages, 0, sizeof(*local_pages) * nr_pfns); > @@ -158,6 +154,19 @@ static int write_batch(struct xc_sr_context *ctx) > mfns[nr_pages++] = mfns[i]; > } > > + hdrs.rec.length = sizeof(hdrs.page_data); > + hdrs.rec.length += nr_pfns * sizeof(*rec_pfns); > + > + hdrs.page_data.count = nr_pfns; > + > + iov[0].iov_base = &hdrs; > + iov[0].iov_len = sizeof(hdrs); > + > + iov[1].iov_base = rec_pfns; > + iov[1].iov_len = nr_pfns * sizeof(*rec_pfns); > + > + iovcnt = 2; > + > if ( nr_pages > 0 ) > { > guest_mapping = xenforeignmemory_map( > @@ -199,61 +208,34 @@ static int write_batch(struct xc_sr_context *ctx) > else > goto err; > } > + else if ( iov[iovcnt - 1].iov_base + iov[iovcnt - 1].iov_len != > + page ) > + { > + iov[iovcnt].iov_base = page; > + iov[iovcnt].iov_len = PAGE_SIZE; > + iovcnt++; > + } > else > - guest_data[i] = page; > + { > + iov[iovcnt - 1].iov_len += PAGE_SIZE; > + } > > rc = -1; > ++p; > } > } > > - hdrs.rec.length = sizeof(hdrs.page_data); > - hdrs.rec.length += nr_pfns * sizeof(*rec_pfns); > hdrs.rec.length += nr_pages * PAGE_SIZE; > > - hdrs.page_data.count = nr_pfns; > - > for ( i = 0; i < nr_pfns; ++i ) > rec_pfns[i] = ((uint64_t)(types[i]) << 32) | ctx->save.batch_pfns[i]; > > - iov[0].iov_base = &hdrs; > - iov[0].iov_len = sizeof(hdrs); > - > - iov[1].iov_base = rec_pfns; > - iov[1].iov_len = nr_pfns * sizeof(*rec_pfns); > - > - iovcnt = 2; > - > - if ( nr_pages ) > - { > - for ( i = 0; i < nr_pfns; ++i ) > - { > - if ( !guest_data[i] ) > - continue; > - > - if ( iov[iovcnt - 1].iov_base + iov[iovcnt - 1].iov_len != > - guest_data[i] ) > - { > - iov[iovcnt].iov_base = guest_data[i]; > - iov[iovcnt].iov_len = PAGE_SIZE; > - iovcnt++; > - } > - else > - { > - iov[iovcnt - 1].iov_len += PAGE_SIZE; > - } > - --nr_pages; > - } > - } > - > if ( writev_exact(ctx->fd, iov, iovcnt) ) > { > PERROR("Failed to write page data to stream"); > goto err; > } > > - /* Sanity check we have sent all the pages we expected to. */ > - assert(nr_pages == 0); > rc = ctx->save.nr_batch_pfns = 0; > > err: Looking at this patch, I think it wants merging with patch 3 and bringing ahead of patch 5. You're undoing/redoing work in both of those patches, where I think it would be simpler to drop guest_data rather than convert it then drop. Moving hdrs.rec.* can be done in patch 1 (which will probably simplify it's diff too). ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:55:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:55:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349870.1607500 (Exim 4.92) (envelope-from ) id 1wetXd-000341-HX; Wed, 01 Jul 2026 11:55:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349870.1607500; Wed, 01 Jul 2026 11:55:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetXd-00033u-Eh; Wed, 01 Jul 2026 11:55:45 +0000 Received: by outflank-mailman (input) for mailman id 1349870; Wed, 01 Jul 2026 11:55:44 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wetXc-00033m-3N for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:55:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetXb-00Ahh0-CO for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:55:43 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a450027-5cb7-0a2a0a5109dd-0a2a4507a2a6-48 for ; Wed, 01 Jul 2026 13:55:43 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a45003d-9c8e-0a2a45070019-d1558029c1fb-3 for ; Wed, 01 Jul 2026 13:55:42 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-493b779003fso2744145e9.3 for ; Wed, 01 Jul 2026 04:55:42 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be810be8sm66929875e9.9.2026.07.01.04.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:55:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782906941; x=1783511741; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MoQ03rLQTdgsOEta0q/3tkgEBYC0ycfrpVzP3Ye92u4=; b=cuk5KihaeGk4FnoZCufOPUXjf+BwbZt/ppv6ikSxFtRlAvr7W64c9SU96xU3XrlI9N PVgCtMKbTAy/vUOJN/DjGMOng1iYzDxo6p6rmFGkXiaak9WNczxcu9rBs5sOAmHsfBkZ dY0RZNCDm8w2wV6YqFy9MKYS6rvwjt4zSYz4u79Al1szkMEK0CdZTP0ed5aKsHom0Mss +PvHWzH4Xyx3RgQY/PesLQEO2tPJ6NbHslA0FST1QfFs1ZFmPMKtyoEDNd0R8dLruOU3 W3S1v9uD+0p+QsC2XIPJXMF3ZOL8P4DKTUWWa80FV5d0r1llGXuRhOmIkBOsae4UaNuq BBcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782906941; x=1783511741; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MoQ03rLQTdgsOEta0q/3tkgEBYC0ycfrpVzP3Ye92u4=; b=YLe7XTZkHPQOT9giXCi/1usSxaeDuG05L+Y0hspslJaTKnxJjD9NGGh2FcknMAWn6b 6vSnJLrmuUQpLLT6ph5FgmEHq83rqObQv12hqN8kAHnTA2twkAx3Y0bxUsRnrPkt48WJ xzJQGuwmFIYnD90cALftximd9h5zjuHjy9KooHrYVW3Ek9b/OddZO1wcxtP/uozUo46n //mxwSL8WGy5MAvrTCW4o4A0OzPlq2wc32QTgQqPjQb9SvhR0qR+B8iIsXZTjfiVTQez 7pzpFT7AdYuYgV+RBWLZK81xnYaLT+oGFdcATHXlqMR/58HLHDc1TQnh98z7LLfwKAVO ir3g== X-Forwarded-Encrypted: i=1; AFNElJ/ciguDN8bSPv9lih1k+ybCPlfRRPgNQ+FyJNvk45ZhqNTCoJ+fuIQ5zZw7POPDkoodG+KkGOZ+ayc=@lists.xenproject.org X-Gm-Message-State: AOJu0YyAFuqLURPpM2cLm2z3uzF/QeM9/a82p2MYLzVgYNGP3UAbnVhT Tb5t/6qUVK8ugAlXMdrflKUcjaOXq+WreksCBqBIZbOmBc4CDbak1nUs X-Gm-Gg: AfdE7cksPtXsUQFJ+r44n/ob0iegShqiBc4738LR6usn9xvNlXrThOI0t9IicNLz+H+ MgxFtXtdDNSo2J/Q8khH08cp8UxqSfXJgqJ8uTa2rUKQD+RbOSdqFMam7dvMat/d1qlTiodA4se gVUPo8L2nXeOhCaGLa1H7xkp4jxfVfzpstlKYgqlE2jnjyZzS2aIGVCKbFTo4qXz6/6IFc+tJN1 RKUX+fBrtQoUGjpZP2uuuARh/nFCPqNDoPOGis1YwkL4fc4/CfR5aC5oMqj5rCwg7TawpKM9t0+ S7duATrmX+IgtKFspOUt6RH23e2aAHhmKp79+5imsjCPgGgmpnc5E/gXqzlPXHDe/ddCfgUa9T8 uozwCnoh5U4/OXJJyU0FvBTBmnwUGzMCTUdgjbsraGADqh6QEvrjkQAokD5KkKVj+phR255pYFu OLtV7m1XjhJVYfd06UnxW6Rl2Wxor5baYOsEBGWZX+VC5OFR4RbHHjDpC8HMrqnkUJAMI= X-Received: by 2002:a05:600c:620a:b0:492:58d6:2565 with SMTP id 5b1f17b1804b1-493c2b90815mr17550175e9.25.1782906941508; Wed, 01 Jul 2026 04:55:41 -0700 (PDT) Message-ID: <7d007b0d-d246-45aa-8ce2-579f36f6d8bf@gmail.com> Date: Wed, 1 Jul 2026 13:55:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 20/25] xen/riscv: create APLIC DT node for guest domains To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <2bab716741ae436c7b92989d7613dac620166b89.1782487661.git.oleksii.kurochko@gmail.com> <76b16195-43a8-40cc-9d22-7b9c21e4c8f1@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <76b16195-43a8-40cc-9d22-7b9c21e4c8f1@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1782906942-FD12E25E-A0EA1295/10/73395122804 X-purgate-type: spam X-purgate-size: 3106 On 6/29/26 5:26 PM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> --- a/xen/arch/riscv/include/asm/imsic.h >> +++ b/xen/arch/riscv/include/asm/imsic.h >> @@ -78,6 +78,7 @@ struct vimsic_state { >> }; >> >> struct dt_device_node; >> +struct kernel_info; >> struct vcpu; >> >> int imsic_init(const struct dt_device_node *node); >> @@ -93,4 +94,6 @@ int vcpu_imsic_init(struct vcpu *v); >> void vcpu_imsic_deinit(struct vcpu *v); >> unsigned int vcpu_guest_file_id(const struct vcpu *v); >> >> +int vimsic_make_domu_dt_node(struct kernel_info *kinfo, unsigned int *phandle); > > Doesn't this belong in the earlier patch? Yes, it should be in the earlier patch. I will move this decl. to prev patch. > >> --- a/xen/arch/riscv/vaplic.c >> +++ b/xen/arch/riscv/vaplic.c >> @@ -9,6 +9,8 @@ >> */ >> >> #include >> +#include >> +#include >> #include >> #include >> >> @@ -19,6 +21,11 @@ >> >> #include "aplic-priv.h" >> >> +#define VAPLIC_COMPATIBLE "riscv,aplic" >> +#define VAPLIC_NUM_SOURCES 96 > > So for the IMSIC the host value is relevant, but for the APLIC the count is > an arbitrary(?) compile time constant? Why? If you are referring to the number of IMSIC interrupt identities, the IMSIC node has separate properties for the host and guest: ```yaml riscv,num-ids: $ref: /schemas/types.yaml#/definitions/uint32 minimum: 63 maximum: 2047 description: Number of interrupt identities supported by the IMSIC interrupt file. riscv,num-guest-ids: $ref: /schemas/types.yaml#/definitions/uint32 minimum: 63 maximum: 2047 description: Number of interrupt identities supported by the IMSIC guest interrupt file. If not specified, it is assumed to be the same as the value of the `riscv,num-ids` property. ``` Therefore, if `riscv,num-guest-ids` is not explicitly specified, the predefined value `GUEST_IMSIC_NUM_IDS` is used. No equivalent property exists for APLIC, which is why the value is explicitly hardcoded here. To some extent, the chosen number is arbitrary, but I used the same value that QEMU uses when creating the APLIC node. It probably makes sense to limit this value in a similar way to IMSIC, at least for now, since the case where the number of VAPLIC sources exceeds the number of host APLIC sources is not supported (assuming that configuration is even valid). In other words, we could use: min(VAPLIC_NUM_SOURCES, host_num_sources) Would that make sense? > >> @@ -29,6 +36,74 @@ static void cf_check vaplic_deinit(struct vcpu *v) >> return vcpu_imsic_deinit(v); >> } >> >> +static int __init cf_check vaplic_make_domu_dt_node(struct kernel_info *kinfo) >> +{ >> + struct domain *d = kinfo->bd.d; >> + int res = 0; > > I'm pretty sure I did point out this (or a very similar) pointless initializer > before. > I will drop initializer. Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:56:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:56:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349875.1607510 (Exim 4.92) (envelope-from ) id 1wetY5-0003SZ-Qz; Wed, 01 Jul 2026 11:56:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349875.1607510; Wed, 01 Jul 2026 11:56:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetY5-0003SS-NO; Wed, 01 Jul 2026 11:56:13 +0000 Received: by outflank-mailman (input) for mailman id 1349875; Wed, 01 Jul 2026 11:56:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetY4-0003S8-3h for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:56:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetY3-008Rnf-GU for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:56:11 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a450051-5cb7-0a2a0a5109dd-0a2a4502beac-16 for ; Wed, 01 Jul 2026 13:56:06 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a450056-5a27-0a2a45020019-d155dd2dd8aa-3 for ; Wed, 01 Jul 2026 13:56:06 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-472055b0efaso353776f8f.2 for ; Wed, 01 Jul 2026 04:56:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475674af239sm15057499f8f.30.2026.07.01.04.55.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:55:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782906966; x=1783511766; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=2ILDaRNTeZo5u0FIEIEa4IBQ8JWXbZOhNQFsEyvANNQ=; b=Z8geJSq+uFFrC1vzYc/xJjOK1rWggXmvVmDg0m643YeCSrx+Y66y4hkjaXpWzXZbgm +khJMF59aSNk37z17XgbFWz7Vr2jDAgIbC/6rS7tuijd8DuGsr9cTOJaEL5/16A6zAAo 2a7xszjbb/E60QVVJ2kZ5u6iYU7LF3qIBRNfsLRcks1/SJ+Syednl7HafRMC1LH5LDKy 3JMAADuGiPcWwVu2ahS/XO5B1PlMbaLeDaR9ERsjWKUFenTJJpBz8M2c3EDUPuE8E/Cp tnutyQbZ3qutH1ifHdTiKPpq8VtppPo9MY/Fd/nyKa13F8W82IfllMpAwq8kFVqxlyr7 qzkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782906966; x=1783511766; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2ILDaRNTeZo5u0FIEIEa4IBQ8JWXbZOhNQFsEyvANNQ=; b=PBeC/eCzzR94+iwJ9DRXgBkdBrq+7N+3Ud4NKlfN11Jn1ewLzBT9xvGWkLP1R2l0HW UVeUS6o7jPzog5gN651PEB9/GADE94cDkk0EpQBjOiPDlLKl2mPp9cO0YYakl2/wzFVB Sv06rdaXLTxDOlUdE/simeNDaNr15SZKuORofyISO79tMhIEE7InaOfFdWfb09LcMDMD SCPGLdoFAVeZAGoQXIkqFOs8dgSBfPDnQYINX3bsQb8eCwk9K1tRjTjYBRt2sNrfH5eh pBzRQpRpED74wDoyZ7Ok+91KTkd8f/uFhyAuzCrem3A1M3du+CgSTjDDowtPh7Rcuvjn bxdg== X-Forwarded-Encrypted: i=1; AHgh+Rqxg7V3bcN/RQ1gTerUJ7YG4WHCkfbSRpGclI4Go3yu1ql3SnJozCL/d8y6IJgcucuSX/IUh/Eqn2E=@lists.xenproject.org X-Gm-Message-State: AOJu0YwJff7wgI9rlKK8Lt9iGSjkClEScsFUNuP7aYWMuWItvBgw6r4j 5fSwLt0wFWg0k8oE3Wb10akrfvEkwCT2067YJbRQSPblQZIVFdt4t+xfiHk3T/nlig== X-Gm-Gg: AfdE7clZiDrjXDbvZMPD1RNXZQtYK70yU9cLKXomuZhl7vbfuL+xW+Vv0kRRr9TNofz lbkbfT4xCg7A6Ve4/mL8joBjENets8yS+uS58PIcfSuDWvwyQz5npNvUMIQiC3PaScAA7i9WIBj XPB/dbCSQITG0gpUjpSmQ0x2YeIRogM92h9aaJfGKEb72IA4lWfp+jIol+VTjNCkfqQ2QmvN2df TaNvGxDtIwyg+0mqqQcP4JOLLff42Pi4ygtTj+KAfP7E0EoNLSiog9OfEntOri/9u6Mc1IGfode 2xGoLhscJaOQjys9MQy0nYD1aBC4dN8v7EjweO7U5VeaXL5cPzHL6S/sLA1NP0YzUCn04IeqHNR JkP5mE4U1MCakPfGBXN3Cj4xJ0oR+I3yeTw3W/Dft/cYFc+rR8EJbj4HJXsmG6cQV8n7UcFW9v6 WKW9j1+/VDr0yFIHsPsj97GHlrdGBkEr/I/XF8scIk4BSeRAcH2tNioCVT/o7soqJzoattVO1C+ VYX X-Received: by 2002:a05:6000:2203:b0:473:1089:154f with SMTP id ffacd0b85a97d-4775466f2a2mr2405684f8f.0.1782906965667; Wed, 01 Jul 2026 04:56:05 -0700 (PDT) Message-ID: <3c672ea8-3dc9-468d-9ca4-d6ceaf6c8cb3@suse.com> Date: Wed, 1 Jul 2026 13:55:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/25] xen/riscv: generate IMSIC DT node for guest domains To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <424c223b97e9d27aa4ef4e05e2d5c8d0c426324c.1782487661.git.oleksii.kurochko@gmail.com> <77d3cf2c-3ed7-45f8-8e76-72520e71306b@suse.com> <018771c4-043d-4b29-ac40-284ee8692334@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <018771c4-043d-4b29-ac40-284ee8692334@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1782906966-4EB177C5-C78C79F4/0/0 X-purgate-type: clean X-purgate-size: 3212 On 01.07.2026 13:21, Oleksii Kurochko wrote: > On 6/29/26 5:19 PM, Jan Beulich wrote: >> On 26.06.2026 17:46, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/imsic.c >>> +++ b/xen/arch/riscv/imsic.c >>> @@ -13,8 +13,12 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> +#include >>> +#include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -34,6 +38,16 @@ static struct imsic_config imsic_cfg = { >>> .lock = SPIN_LOCK_UNLOCKED, >>> }; >>> >>> +/* >>> + * Number of MSIs available to a guest. Determined by the host interrupt >>> + * controller, so it is identical for every domain -- hence a single global >>> + * rather than a per-domain value. >>> + */ >>> +static unsigned int __read_mostly guest_num_msis; >>> + >>> +#define GUEST_IMSIC_COMPATIBLE "riscv,imsics" >>> +#define GUEST_IMSIC_NUM_MSIS 255 >> >> Considering its use this isn't named correctly - it's not the number of MSIs >> guests get to use. > > I will rename to GUEST_IMSIC_NUM_IDS then it will be fully aligned with > dts property name. > > Then it makes sense to rename guest_num_msis to guest_num_ids. That's not going to help address my remark. I specifically referred to ... >>> +int __init vimsic_make_domu_dt_node(struct kernel_info *kinfo, >>> + unsigned int *phandle) >>> +{ >>> + int res; >>> + void *fdt = kinfo->fdt; >>> + char vimsic_name[32]; >>> + unsigned int vimsic_phandle; >>> + unsigned int num_msis = min(GUEST_IMSIC_NUM_MSIS + 0U, guest_num_msis); >> >> As guest_num_msis (supposedly) doesn't change anymore after it was set, why >> would this need calculating again for each call here? Can't you apply the >> upper bound right in imsic_parse_node()? > > Agree, I will add the following to imsic_parse_node() after > guest_num_msis is init-ed: > > guest_num_msis = min(GUEST_IMSIC_NUM_MSIS + 0U, guest_num_msis); ... the sole use of the constant (here). The number of MSIs (or IDs or whatever else) isn't GUEST_IMSIC_NUM_MSIS; that's merely an upper bound (which in turn is there for an unknown to me reason). >>> --- a/xen/arch/riscv/include/asm/guest-layout.h >>> +++ b/xen/arch/riscv/include/asm/guest-layout.h >>> @@ -3,6 +3,12 @@ >>> >>> #include >>> >>> +/* >>> + * Base address of the guest's supervisor-mode IMSIC. The value is the address >>> + * typically used for IMSIC by QEMU. >>> + */ >>> +#define GUEST_IMSIC_S_BASE _UL(0x28000000) >> >> As you mention it explicitly: Is there also a user-mode IMSIC? > > I am not aware of such. > > I mention it explicitly as machine mode IMSIC exists and it is a > separate DT node for that. Ah, okay. Then maybe keep the comment as is. It's not quite clear to me whether, from an abstract perspective, "machine mode" could make sense for guests. If it can't, "supervisor-mode" would be redundant with "guest's". Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 01 11:58:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 11:58:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349887.1607517 (Exim 4.92) (envelope-from ) id 1wetad-0004Ru-65; Wed, 01 Jul 2026 11:58:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349887.1607517; Wed, 01 Jul 2026 11:58:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetad-0004Rn-3F; Wed, 01 Jul 2026 11:58:51 +0000 Received: by outflank-mailman (input) for mailman id 1349887; Wed, 01 Jul 2026 11:58:49 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetab-0004Rh-BH for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 11:58:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetaa-00AiHv-GG for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:58:48 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4500f1-2eae-0a2a0a5409dd-0a2a4508b5d6-32 for ; Wed, 01 Jul 2026 13:58:48 +0200 Received: from [209.85.221.51] (helo=mail-wr1-f51.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4500f8-edec-0a2a45080019-d155dd33c89e-3 for ; Wed, 01 Jul 2026 13:58:48 +0200 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-475417f010dso358136f8f.2 for ; Wed, 01 Jul 2026 04:58:48 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756636d2cfsm18350828f8f.17.2026.07.01.04.58.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:58:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782907128; x=1783511928; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=VCBBlBIZ2fRRtURovQCiNJjBxSs2iUUYs/xeLtP2pSs=; b=Ji54BCgi9FyjrWIeSbS78GcgMXzS9dq43gTruqg8EZBxVQ0pW/6QOXkNUYZrWzOC2C lAiBIF40cWzOwbhNBLskr/yW8nggf4/UJPz6qTF9xU+pMyaIeiaEzl8FhPeNOKRZ/Suu B4hJc4uS1/0mCn0uOjoTXrkKpwWz2Kz5co/cqRr1FnsEsTPHyw9/eUB58GbwGpsVkgkW yRAD802iDvKP9rVY5fbJMYG/Y6K8loTaGRGEznP0BmBFhbs48+tAkSVRl3WjrbkW75pF TUk+GWNdrfUnBRjOlEON0yzGh+1F8pmi/D4r92V5tLP0XmJ465vWHUYkCAr7GIhOerBk fqQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782907128; x=1783511928; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VCBBlBIZ2fRRtURovQCiNJjBxSs2iUUYs/xeLtP2pSs=; b=BWPcrytAgkt3uTVxofQb8U521+TPERwB3vkubFDoH5+7anLS5I0copAZR5fX/ugNJp K0ezPw7/ADhmVnxFQPpCXrQe9BuaQE5K5DLVC2T8c1gt2Cero8p3F5qXmChroBKKywQM Cx4BNMB00KLk9dfLaIj1Di/Fe/plvkt+DyBjlit39B3auueSAeY3UklZAfp04fMHYopo PAOlGrCp5gQfT0GcESALpuFROZwg7HpqV1mIav89StvT3pf1Q5bUfsZjw5nTNIfRyzWc oQuiQ9KvKJyPvunlpZdI7X4+vFO9O4bXsMwEpT6zB7/BDgu++2apVP+9TpYHtY+THlYX fMMA== X-Forwarded-Encrypted: i=1; AHgh+RogWqQUwvIOdvJK14ErAIrjn4yZ9tYxOOFbUAsfi9QuWYxHrvgw1WlSX+Hhi93zooMyyxBMYP3OjTI=@lists.xenproject.org X-Gm-Message-State: AOJu0YwktVK0OEEGlojT71TxaXez+Dud0gI7++Ro2ZZd4Uav7JtjIQ3Z +guV/JjaeaTNBDrsxDTEFyUCXrgjv8YWt3MEKfyjcu5WIc8JZKoJpHen4zRHI4/BlA== X-Gm-Gg: AfdE7clmlxEguagdXZhG+cGERqz5NFjOfmrFlQ0EA0GX0iYkx8zjeatZjvPhWEnT259 LLHKODSGHt6hyt4vz+IbcmFte70oqu34HFOx8algOnR1CclqXK2CoQ2FhJ74MMDhAcr4HM+KwWZ 5bIR6p4ikfiVBpr8HpKPZL2CVgpZxCPRpJe3hi6NQwgdWfgxL/80VpqXK7tFI3qw5YxCQSWmyJD jzUq11VLIsk/ZrUVrd6VmlQ8Ucg732aLQnrnmNkOJQQcjuIBN5F+LLK2UixovDHwhH+UyiZjkwY zk/zhGPCHGKrLYu6tK3j+sAVyxaMs4z94H1m9yXKxjrcdIx7MdYi8PVZf77FSRURqTPVSejJpe2 bdfQMNHiB/oPiIWtFIAL4LE0aALenr8LdaJnNxlDjWMmGiOKcCTJVC5eUiSS4MLQi+LGtXbPk/o RsHt70VdPPYiTRs1wEsbp8kZJwpavV/dnwKVvG4knwO+fSoWwgctFRrziQryQaGkvi8leQNdAk+ CjmPuzOySqLb6w= X-Received: by 2002:a5d:64c3:0:b0:473:da43:44ba with SMTP id ffacd0b85a97d-47757798020mr2295215f8f.22.1782907127866; Wed, 01 Jul 2026 04:58:47 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 13:58:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 20/25] xen/riscv: create APLIC DT node for guest domains To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <2bab716741ae436c7b92989d7613dac620166b89.1782487661.git.oleksii.kurochko@gmail.com> <76b16195-43a8-40cc-9d22-7b9c21e4c8f1@suse.com> <7d007b0d-d246-45aa-8ce2-579f36f6d8bf@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <7d007b0d-d246-45aa-8ce2-579f36f6d8bf@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c1860d/1782907128-4293D3FC-65BDD623/0/0 X-purgate-type: clean X-purgate-size: 2244 On 01.07.2026 13:55, Oleksii Kurochko wrote: > On 6/29/26 5:26 PM, Jan Beulich wrote: >> On 26.06.2026 17:46, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/vaplic.c >>> +++ b/xen/arch/riscv/vaplic.c >>> @@ -9,6 +9,8 @@ >>> */ >>> >>> #include >>> +#include >>> +#include >>> #include >>> #include >>> >>> @@ -19,6 +21,11 @@ >>> >>> #include "aplic-priv.h" >>> >>> +#define VAPLIC_COMPATIBLE "riscv,aplic" >>> +#define VAPLIC_NUM_SOURCES 96 >> >> So for the IMSIC the host value is relevant, but for the APLIC the count is >> an arbitrary(?) compile time constant? Why? > If you are referring to the number of IMSIC interrupt identities, the > IMSIC node has separate properties for the host and guest: > > ```yaml > riscv,num-ids: > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 63 > maximum: 2047 > description: > Number of interrupt identities supported by the IMSIC interrupt file. > > riscv,num-guest-ids: > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 63 > maximum: 2047 > description: > Number of interrupt identities supported by the IMSIC guest > interrupt file. If not specified, it is assumed to be the same as the > value of the `riscv,num-ids` property. > ``` > > Therefore, if `riscv,num-guest-ids` is not explicitly specified, the > predefined value `GUEST_IMSIC_NUM_IDS` is used. > > No equivalent property exists for APLIC, which is why the value is > explicitly hardcoded here. To some extent, the chosen number is > arbitrary, but I used the same value that QEMU uses when creating the > APLIC node. > > It probably makes sense to limit this value in a similar way to IMSIC, > at least for now, since the case where the number of VAPLIC sources > exceeds the number of host APLIC sources is not supported (assuming that > configuration is even valid). In other words, we could use: > min(VAPLIC_NUM_SOURCES, host_num_sources) > > Would that make sense? Perhaps, yes. Just with the constant again named appropriately for its purpose (see comments on an earlier patch). Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 01 12:04:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 12:04:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349899.1607528 (Exim 4.92) (envelope-from ) id 1wetgT-00067n-Tq; Wed, 01 Jul 2026 12:04:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349899.1607528; Wed, 01 Jul 2026 12:04:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wetgT-00067g-Pr; Wed, 01 Jul 2026 12:04:53 +0000 Received: by outflank-mailman (input) for mailman id 1349899; Wed, 01 Jul 2026 12:04:51 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wetgR-00067a-Mx for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 12:04:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wetgQ-008U4k-JD for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:04:50 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a450252-2eae-0a2a0a5409dd-0a2a450cd102-44 for ; Wed, 01 Jul 2026 14:04:50 +0200 Received: from [209.85.221.43] (helo=mail-wr1-f43.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a450262-f399-0a2a450c0019-d155dd2bddee-3 for ; Wed, 01 Jul 2026 14:04:50 +0200 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4720d22c94aso527466f8f.1 for ; Wed, 01 Jul 2026 05:04:50 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47566fe448dsm16477635f8f.27.2026.07.01.05.04.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 05:04:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782907490; x=1783512290; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z+JcKImV4auOMkQdRkBPApred79ZOAtYJ15Hd+TGU04=; b=QVi9oN+PtDtJxldXMhhGVmPkw1tcY6lJ+7MzQPjWgUCfZY81xgPqyeFqsRJbynscdq Ox3WtiIdF4Mlwhcv+zNpFr7YaPN+huj3Mh+kUt2mQICNfJfowOhvgParBGebkx8dzlVi X1msZiWGRSvUm7iYRjApFi1sLAxOyJVykqn2SZbEBKr2Sv0uOLaxzwnGLMOo4VANEXSu z8cml8YHsQ0LgoWmG8tdN/d+axJtKEXevPSLIeGRDuY+FKrPG6uvX08UnUPQhIR3pqyX GjTT+eVqml2bWqkroMwTDEEUgVd49txDCj3RbwHl/kASaatSlzNs2/0KIKckANyaQmYI arIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782907490; x=1783512290; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z+JcKImV4auOMkQdRkBPApred79ZOAtYJ15Hd+TGU04=; b=WIMEFfOa1UnXCwg9Efd5PYZ2HGxl+r9iUJKe17XNRVkNdIpv93VyjvqCZViw2pLXSc eACiuMWwWb3Z+iFxcwdzz4aw+qVKDU07Ygn9TR2dkai9ReCeJhbWvcbmjShsldIAzK7m HLWmCUOCubxHjQ/246PDsBkCYG9XBK7P09SBiCefuB+ps3MwwuMnDB74Sc2gntqL2D1n IWIPzlOhrnALJGQAQ8tDVFgNu5iCQSWT0okaJPWEsdBZMFHu1S0r6HZ3y4AuX+Wk5WLc l+vUzWiXGlhtgFASRPt5T+WGBf+dU0GiZ53Bz2/4n2eac+l2sYj6zEQLWMC7kMYMGRr8 6eLw== X-Forwarded-Encrypted: i=1; AHgh+Rp1waa3cR4NOOkN/b2dNMzJ1JIpgnQ+zhzu7JNLNr2ny6sZxzXX6bPxGDAuVEpo73/zj6TXdWLHHpQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YwR9IkMt9H3tNE5pzHr4pXIx71IhBc7y7zh5+ntxDfzPr2SbMQZ FWwkoWb4N6AXQJFIpeYiuUWxi0eDsS3m8Le7Mg4fnrF37+hUsf98rfq1 X-Gm-Gg: AfdE7ckQBxyArQbONJC/Vu2zbcYTk3jUA8aDxaI3kTfcsGoJhKU6KpToYRVgbvIdTWL qYD2Ax0vzTnFDsEPMU3T09KymHb1r2+kA1dWWLuCOzXfHTPHLXMgYyjc6WRHeqtdwSg9OAUykAD jf8GM9+CzhXrDrJTf8p1p5wrxkS6iCTe2u2XsBo9JuSH0rJ4HUR8ZJotNqUpyu7Fw/zxbaf1Q4y 1A5epi6YNANyfuAezq09wAryv38stGc322TygC86Wgu/udWRGwg8ObFHZsHlipcPbQIb0pXyFL7 m4SFsC9+6LokxmvbS0nO8zVFjCoqmyjIs3oF7hSVu78c83o+UMMMm5ABBQhBeG6fpuJ3k6TPQtp QIPLqQ95DF3ngu/0OHFMx7Z2k63/Z0i87dMrdDVseMt42mQCZDAhkcJ7oeS56QUPuDPUzh4GDhb TtXdevYypRII5S19Ha9qPLcE+SCL2OBEZJeioTMC4kFmM/2cfI+sZkrL5a5+r0qXe3YMQ= X-Received: by 2002:adf:fc8a:0:b0:475:f0d1:eb61 with SMTP id ffacd0b85a97d-477b2254b18mr290312f8f.60.1782907489911; Wed, 01 Jul 2026 05:04:49 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 14:04:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/25] xen/riscv: generate IMSIC DT node for guest domains To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <424c223b97e9d27aa4ef4e05e2d5c8d0c426324c.1782487661.git.oleksii.kurochko@gmail.com> <77d3cf2c-3ed7-45f8-8e76-72520e71306b@suse.com> <018771c4-043d-4b29-ac40-284ee8692334@gmail.com> <3c672ea8-3dc9-468d-9ca4-d6ceaf6c8cb3@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <3c672ea8-3dc9-468d-9ca4-d6ceaf6c8cb3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1782907490-93536D51-47D40B05/10/73395122804 X-purgate-type: spam X-purgate-size: 2565 On 7/1/26 1:55 PM, Jan Beulich wrote: > On 01.07.2026 13:21, Oleksii Kurochko wrote: >> On 6/29/26 5:19 PM, Jan Beulich wrote: >>> On 26.06.2026 17:46, Oleksii Kurochko wrote: >>>> --- a/xen/arch/riscv/imsic.c >>>> +++ b/xen/arch/riscv/imsic.c >>>> @@ -13,8 +13,12 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> #include >>>> +#include >>>> +#include >>>> #include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> @@ -34,6 +38,16 @@ static struct imsic_config imsic_cfg = { >>>> .lock = SPIN_LOCK_UNLOCKED, >>>> }; >>>> >>>> +/* >>>> + * Number of MSIs available to a guest. Determined by the host interrupt >>>> + * controller, so it is identical for every domain -- hence a single global >>>> + * rather than a per-domain value. >>>> + */ >>>> +static unsigned int __read_mostly guest_num_msis; >>>> + >>>> +#define GUEST_IMSIC_COMPATIBLE "riscv,imsics" >>>> +#define GUEST_IMSIC_NUM_MSIS 255 >>> Considering its use this isn't named correctly - it's not the number of MSIs >>> guests get to use. >> I will rename to GUEST_IMSIC_NUM_IDS then it will be fully aligned with >> dts property name. >> >> Then it makes sense to rename guest_num_msis to guest_num_ids. > That's not going to help address my remark. I specifically referred to ... > >>>> +int __init vimsic_make_domu_dt_node(struct kernel_info *kinfo, >>>> + unsigned int *phandle) >>>> +{ >>>> + int res; >>>> + void *fdt = kinfo->fdt; >>>> + char vimsic_name[32]; >>>> + unsigned int vimsic_phandle; >>>> + unsigned int num_msis = min(GUEST_IMSIC_NUM_MSIS + 0U, guest_num_msis); >>> As guest_num_msis (supposedly) doesn't change anymore after it was set, why >>> would this need calculating again for each call here? Can't you apply the >>> upper bound right in imsic_parse_node()? >> Agree, I will add the following to imsic_parse_node() after >> guest_num_msis is init-ed: >> >> guest_num_msis = min(GUEST_IMSIC_NUM_MSIS + 0U, guest_num_msis); > ... the sole use of the constant (here). The number of MSIs (or IDs or > whatever else) isn't GUEST_IMSIC_NUM_MSIS; that's merely an upper bound > (which in turn is there for an unknown to me reason). Then GUEST_IMSIC_MAX_IDS (or *_MSIS) would be better. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 13:01:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 13:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349928.1607536 (Exim 4.92) (envelope-from ) id 1weuYe-0006no-NX; Wed, 01 Jul 2026 13:00:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349928.1607536; Wed, 01 Jul 2026 13:00:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weuYe-0006nh-K9; Wed, 01 Jul 2026 13:00:52 +0000 Received: by outflank-mailman (input) for mailman id 1349928; Wed, 01 Jul 2026 13:00:51 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weuYd-0006nb-Cz for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:00:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1weuYc-00Auiz-IY for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:00:50 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a450f7e-bab6-0a2a0a5309dd-0a2a450aa4c4-20 for ; Wed, 01 Jul 2026 15:00:50 +0200 Received: from [209.85.218.47] (helo=mail-ej1-f47.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a450f81-e40e-0a2a450a0019-d155da2fd994-3 for ; Wed, 01 Jul 2026 15:00:49 +0200 Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-c12629c937eso76023566b.3 for ; Wed, 01 Jul 2026 06:00:49 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1296b1f9cesm182606666b.16.2026.07.01.06.00.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 06:00:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782910849; x=1783515649; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=XGP3Qh8vro3qsOU3zbt5oj9XZUQ7ke15MmykYN9Mi/w=; b=bk5Lbh79u0Hk8mLYimLQ8CJu5Zgs0t2zBneW/N0mI/GGwHKcD+pcVS7OTCVLjqmfll xnThAzzXHq64u0tln1ByrA+P8t9s9PGs95UDh2eGiy8LiGbK+s8i8BpCslhw+i96fuvf z5k+5fiFhp9kLwiQpM2sinNXsmHSMnWFipqpnL8BaupyL+dCqTelgyPo/wSLS9XCMSVy 0cuHUNcNVCETgwTZrbRg5e5UpkhekH2yHPG9Wndke7j3k1MztQ4UHlx+Shc/XQ2eRXHk pUvkuz7z76QbBrpU0jnfxjUvOaXajY862LBO4HOp2xKoj6r2ecbC7DbrP+9uo+ZK+yNu f/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782910849; x=1783515649; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XGP3Qh8vro3qsOU3zbt5oj9XZUQ7ke15MmykYN9Mi/w=; b=ktiZz5Ybfi8kZ3B870d9X1pHkj0pR15YRGRi7BYUUOtDn+89gImF3wClmXeL6tpFEN 43rLK3uoqFV/LX79l10qMc6CKFerZnvvbrRCHXim8+liU2Jd+JBuNR3gRNhuIcEX/han ceqREwq7EiPvblV4u5q2riPwOk5bSoYq/19BImstUxxxvVfTlIZx2Qh0U5rFDraAO/bv DPoyCa22ot/IBUpg0UHoUdF7jLsnbseqsGy+6erKNRIe12/upbx58BHZ59RwtGIrxVSB U6bZunW9S5RI8Ms03F/nflxxdfICh+OUdzmNHXlHn9927HZtVqUqbogL3pSIjjrPEgRc /YMw== X-Forwarded-Encrypted: i=1; AHgh+Ro4ggXV9P91jSyDbK/HU49ER2XA0x1tMBiFW6vxN9DS4IaYqwFH+gBxEIYE4t6AUbEK1MJxvk8eqJ0=@lists.xenproject.org X-Gm-Message-State: AOJu0YwpP0zFHmHYS0uozz8Kj6Tl6bK60ew4mGz09WPOqGLcgU1hSRMf QyXAc1tFDbsBC+KwYcXLl6+wJkFJMkHWXBvkXS8o6PrRpUdtmaMBFRETFM6u5s73cSo= X-Gm-Gg: AfdE7cm+mazFr3ON0L0mcB/d9NLP+9WwT/DolP3CpZa/7XYUbvvFZplB/P8NnV7uwU8 XCUcUF88aoKBrwZR11DsA6rCO9Hv/pvoGHP3bLWOYOix/n7Vl8bhRVrb7kfabyXzNJXt5McVYoQ 6ZN7ukme1IyU0+LHJGaTXsHbgz/4PEIrHRsPglSHveR8PsFHB8IZk7lBn5ON/9ezKoXrKwS63e9 9jmVEJOa3rXi6f6iUz6+HVTClZOKeN2fXA180D6WQWK8Bwwa8rGp4DkT+kcLhXgz34VSm+7sh7a OcsXN5bI93sQw6V20+ZfjQ/fwlDWMZbSnQQ1NvVAUbMWCJyZdKoKXIXdFb2xhtjrb9EVwVtAgL9 UjN4LC1fA8RTFDxVJM9OY+aWqyu0isNTHBGrnHOh9fb5PsaZxKbRy4BG5HULLVQeXL2l2FyFqyf Xdy8E22XfGdS3xSq7j0TVm7eVlnPjIPTNs5KrgbWF2lZ4GYvjloDJjSseUvjGkhscPVktzYjfnP RIiM8IAW6Wz2UcQRdur21gaKrkGs3nXkMHx0MCZmO4= X-Received: by 2002:a17:906:6a27:b0:c12:34ed:e0f9 with SMTP id a640c23a62f3a-c12aa1b0d39mr84914366b.55.1782910848946; Wed, 01 Jul 2026 06:00:48 -0700 (PDT) Message-ID: <3c05b2b0-6a83-4046-9de3-c7e3478c2958@suse.com> Date: Wed, 1 Jul 2026 15:00:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Andrew Cooper , Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> <4524812f-b9ee-4ef5-b5c6-7583815e859b@citrix.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <4524812f-b9ee-4ef5-b5c6-7583815e859b@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------D8Dk0SUKGVgnZWk0UYIUxY3D" X-purgate-ID: tlsNG-4011c0/1782910849-3C876DDE-A7941F31/0/0 X-purgate-type: clean X-purgate-size: 10528 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------D8Dk0SUKGVgnZWk0UYIUxY3D Content-Type: multipart/mixed; boundary="------------znGHoX2KsgMD0EpG2Du8uocr"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Andrew Cooper , Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Message-ID: <3c05b2b0-6a83-4046-9de3-c7e3478c2958@suse.com> Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> <4524812f-b9ee-4ef5-b5c6-7583815e859b@citrix.com> In-Reply-To: <4524812f-b9ee-4ef5-b5c6-7583815e859b@citrix.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------znGHoX2KsgMD0EpG2Du8uocr Content-Type: multipart/mixed; boundary="------------8eJqjVbKDosdQe3AGtdAnLta" --------------8eJqjVbKDosdQe3AGtdAnLta Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDcuMjYgMTM6NDUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDAxLzA3LzIw MjYgMTI6MzkgcG0sIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMDEuMDcuMjAyNiAxMzox NiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+PiBUb2RheSB0aGUgWEVOX0RPTUNUTF9zZXR2 Y3B1YWZmaW5pdHkgaHlwZXJjYWxsIHdpbGwgbm90IG9ubHkgY2hhbmdlIHRoZQ0KPj4+IGFm ZmluaXR5IHNldHRpbmdzIG9mIGEgdmNwdSwgaXQgd2lsbCByZXR1cm4gdGhlIG5ldyBlZmZl Y3RpdmUgc2V0dGluZ3MsDQo+Pj4gdG9vLg0KPj4+DQo+Pj4gSW4gY2FzZSBhbiBlcnJvciBo YXBwZW5zIGR1cmluZyB0aGlzIGh5cGVyY2FsbCwgdGhlIGV4cGVjdGF0aW9uIG9mIHRoZQ0K Pj4+IGNhbGxlciBpcyB0aGF0IHRoZSBhZmZpbml0eSBvZiB0aGUgdmNwdSBkaWRuJ3QgY2hh bmdlLiBUaGlzIGlzbid0IHRydWUsDQo+Pj4gaG93ZXZlciwgaWYgcGFzc2luZyB0aGUgbmV3 IGVmZmVjdGl2ZSBhZmZpbml0eSBiYWNrIHRvIHRoZSB1c2VyIGlzDQo+Pj4gZmFpbGluZy4N Cj4+IFRoYXQnbGwgYmUgdGhlIGNhbGxlcidzIGZhdWx0IHRob3VnaC4gQW55IC1FRkFVTFQg Y29taW5nIGJhY2sgYXJlIGFuDQo+PiBpbmRpY2F0aW9uIHRoYXQgdGhlIGNhbGxlciBuZWVk cyBmaXhpbmcuDQo+Pg0KPj4+IEluc3RlYWQgb2YgbWFraW5nIGVycm9yIGhhbmRsaW5nIGlu IHRoZSBoeXBlcnZpc29yIGV2ZW4gbW9yZSBjb21wbGV4LA0KPj4+IGp1c3QgY2hhbmdlIHRo ZSBpbnRlcmZhY2UgYnkgTk9UIHBhc3NpbmcgYmFjayB0aGUgbmV3IGFmZmluaXR5LiBJdCBj YW4NCj4+PiBlYXNpbHkgYmUgb2J0YWluZWQgYnkgYW5vdGhlciBYRU5fRE9NQ1RMX2dldHZj cHVhZmZpbml0eSBjYWxsIGlmDQo+Pj4gbmVlZGVkLg0KPj4gQXQgdGhlIGV4cGVuc2Ugb2Yg ZnVydGhlciBpbmNyZWFzaW5nIHRoZSBwcmVzc3VyZSBvbiB0aGUgZG9tY3RsIGxvY2suDQo+ PiBXaGVuIG1ha2luZyB0aGUgcmVjZW50IGVycm9yIGNvZGUgY2hhbmdlIGluIHRoaXMgYXJl YSwgSSB3YXMgYWN0dWFsbHkNCj4+IHdvbmRlcmluZyBpbiBob3cgZmFyIHRoZXNlIHR3byBz dWItb3BzIG1pZ2h0IGFsc28gYmUgY2FuZGlkYXRlcyBmb3INCj4+IG1vdmluZyBvdXQgb2Yg dGhlIGxvY2tlZCByZWdpb24uIFlldCB3aXRoIHZjcHVfYWZmaW5pdHlfZG9tY3RsKCkgbm90 DQo+PiB1c2luZyBhbnkgbG9ja2luZyB0aGF0IGRpZG4ndCBsb29rIGVudGlyZWx5IHN0cmFp Z2h0Zm9yd2FyZCB0byBhbnN3ZXIuDQo+IA0KPiBIb3cgZG9lcyB0aGUgZWZmZWN0aXZlIHNl dHRpbmcgZGlmZmVyIGZyb20gd2hhdCdzIHBhc3NlZCBpbj8NCg0KVGhlIGhhcmQgYWZmaW5p dHkgbWlnaHQgZGlmZmVyIGluIGNhc2UgdGhlIHRhcmdldCBkb21haW4gaXMgaW4gYSBjcHVw b29sDQpub3QgY292ZXJpbmcgdGhlIHdob2xlIG1hY2hpbmUgYW5kIGUuZy4gImFsbCIgaXMg cGFzc2VkIG9uIGlucHV0LiBUaGUNCmVmZmVjdGl2ZSBzZXR0aW5nIHdpbGwgaGF2ZSBvbmx5 IHRoZSBDUFVzIG9mIHRoZSBjcHVwb29sIHNldC4NCg0KPiBJIGhhZG4ndCBldmVuIHJlYWxp c2VkIHRoYXQgd2UgcGFzcyBkYXRhIG91dCBvZiB0aGUgc2V0IG9wLCBhbmQgaXQgZG9lcw0K PiBzbWVsbCBvZiBiYWQgQVBJIGRlc2lnbi4NCg0KWWVzLCBlc3BlY2lhbGx5IGFzIHRoZSBk YXRhIGlzIHVzZWQgb25seSBieSBvbmUgY2FsbGVyIGZvciB2ZXJpZmljYXRpb24uDQoNCj4g V2hpbGUgd2UgZG8gY2FyZSBhYm91dCB0aGUgZG9tY3RsIGxvY2ssIEkgZG9uJ3QgY29uc2lk ZXIgImV4dHJhIHByZXNzdXJlDQo+IG9uIGl0IiBhcyBhIHZhbGlkIGFyZ3VtZW50IHRvIGJl IHVzZWQgaGVyZS7CoCBJdCdzIGFuIGludGVybmFsIGRldGFpbCwNCj4gd2hlcmVhcyB0aGUg aHlwZXJjYWxsIEFQSSBpcyBhbiBleHRlcm5hbCBkZXRhaWwuDQoNCg0KSnVlcmdlbg0K --------------8eJqjVbKDosdQe3AGtdAnLta Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------8eJqjVbKDosdQe3AGtdAnLta-- --------------znGHoX2KsgMD0EpG2Du8uocr-- --------------D8Dk0SUKGVgnZWk0UYIUxY3D Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpFD4AFAwAAAAAACgkQsN6d1ii/Ey+M kwf/SWInyPW89P95ELLY/48zP6HEFuTsDDmDC0HRthkslpClMORJnn/+0ZcWeCPhz3duFm3nOWN+ UL+fwrnpo7mdXkyQM0FOhyt+L4t44/epCHhrUjnSQCqTSD6eNRXFRtLP3L6fwr8tfbhRoXh+2Oye NIhbT7UyKwwjF2ApIcKVfeOTDuNq0K3AZi4NL0tTtJeGzd5TGv0xgSR7bjhXuY1joYPnpKbp/moK 30/Ookh/79+pWB66TtI+0w1SLInyPgs5BrTPoCSnDTpzOlsOkX9FvhmLBkHFbxPjnvkTg0gwa+/f DFBWYzoPX3yacglDZsVWwGOpZICI+29+UyjH8IXaNw== =bCS/ -----END PGP SIGNATURE----- --------------D8Dk0SUKGVgnZWk0UYIUxY3D-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 13:09:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 13:09:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349938.1607545 (Exim 4.92) (envelope-from ) id 1weugT-0007gA-F8; Wed, 01 Jul 2026 13:08:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349938.1607545; Wed, 01 Jul 2026 13:08:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weugT-0007g3-CT; Wed, 01 Jul 2026 13:08:57 +0000 Received: by outflank-mailman (input) for mailman id 1349938; Wed, 01 Jul 2026 13:08:56 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1weugS-0007fu-47 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:08:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1weugR-00AxJM-Dc for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:08:55 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a451159-e002-0a2a0a5209dd-0a2a4504998e-32 for ; Wed, 01 Jul 2026 15:08:55 +0200 Received: from [209.85.218.53] (helo=mail-ej1-f53.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a451167-a01d-0a2a45040019-d155da35ec64-3 for ; Wed, 01 Jul 2026 15:08:55 +0200 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-c12a1a3cdb9so58552466b.0 for ; Wed, 01 Jul 2026 06:08:55 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f4771csm270046666b.42.2026.07.01.06.08.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 06:08:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782911335; x=1783516135; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=QvWdkHra12plO1MEg4iyy5k+8TYQ9q3UWHLtfiJmLXU=; b=QP3Qc26rKOwnkmDvzY6u8UlKLdmyoenavJ0mPeVH5BMS+RzjchKxMHL78UKc5jZRyK Y/MklDtt8XUZhCKm+qtqi2yhzJmMg64QFvNzPossp7P8NxyMGrgGMt+pK8VRXmoYSzom ia91SwuU+efzbyTQKDrEZgNnXCP8JQ7SPBRv/zh4EwF4GxPHkTGXZPeTSpdTz/GEcihK X3TWcCR5o4JgYLiscri6bCrT+hcFFiMamUqG406UKD6lUUoLKPBD2G3G+buxm0BQjWh/ eIyLlQX/IkumLubOp1+IGfZg7w9ifr3uWY1vn3HjxGmmsMvu5DJ9cN1FLsZvBILrQGd0 qWpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782911335; x=1783516135; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QvWdkHra12plO1MEg4iyy5k+8TYQ9q3UWHLtfiJmLXU=; b=W3DMlnlUih4vDIcjZD/65750r/Pj16qI25R0lAXiswItImE01d4rgersgoNPSCmMBl GOvrvbbpFdGEFnvErYMCsbLeZq7VernNTXq/QQL/KJdHFzFw8ESRusJ5a+i0K2Yz1Rkt qLW7e6M8rChwy4sX5gPNE4mLf5iMQ3qlHlgaDbrj5XyNPBBe2J21z8ieoxmNmlz2gKDI LgA7R7pcxtErM5ekrw2UpeiBeFDnZzLg4XwtjWW7d/qrlcUTE3HMOdo4aMiLNhcOKfjD svmV2DUP3yjcq2xF42TdITmWBffbIs2bzgPBpXuD+zMv+baCdmheB+SpWv1BkxqgzZf3 LM+w== X-Forwarded-Encrypted: i=1; AHgh+RrAREmTzzp6g7e+mJfG6rk2zwOFJJAXr0JAapFhBWcGRdqe+Dy5HwevJUV5Sl7yZ5rkAuK7ppFAQv0=@lists.xenproject.org X-Gm-Message-State: AOJu0YyRGL7KzwhlZqDiEKMLjne8EwHUtdxoRx1VAF7UJqZ9fMPPIMaY Hj66BRcTCvnCUZyyImcXonFXAnIPqDO8UNn0WHwvtlJZTyFRZQmm1wmTZoCK2JaKA1+YyWWzhs9 mjVW145X7tw== X-Gm-Gg: AfdE7ck2u/eLCeEEunGDFe+9wy4mIjZjP7pCz5aecDM4yS3MqlHCCntsXHx80nWbyWw xttff63/qlkewJ2chh7SAcknqQXiW8IiVrnlbgwhd0rVNQI3N8NLNt1G+t8QFBR5q/NUZ57vmY/ oLE1e/U9SqYQs+ZdGEsKPp+3Z5SPxoeOiNmjhdAaVa8kVX8hLYuofPFBn+p9I66Ly6k8J/2wZH9 UtCYsSOjOmkJNrhPC2TjgjVw4OcQ/aVRO4ymbNz5xbOFaM14PuMY9pkN6zMr1ksQ+gtkaNDpUDG VuL81s6pn+ZLbvHeO7mzzNIk9CCUQemQJxfjH70UFdtciIyKgPqpTeWs1pHOUylWkadv8arcmEZ 8J02l6W9DQ6t7pIqzTQVSL+NDm6AnwPGsCR1l5i4leF7HDc5LPy5PF9WVGTQEAsXcqiS0opJupj wfTH2MS+WBpdTM/v9pGa8GJKYSGaDkQJju53FN3zOaDIquuuxcutXSQ8ksa7KWSbyi4mVULOxkH lykpDuVvizo+9sc8DjzTnMJtOZ2nk9pvXUqQWR757Iuwgx82Kf4jQ== X-Received: by 2002:a17:907:e117:b0:c12:70e8:6025 with SMTP id a640c23a62f3a-c12ae4089bdmr37842166b.21.1782911334685; Wed, 01 Jul 2026 06:08:54 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 15:08:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------A67jv0t704UZ8WCDSEngQCm7" X-purgate-ID: tlsNG-ebf023/1782911335-AF12E1CC-FA0E12CC/0/0 X-purgate-type: clean X-purgate-size: 9976 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------A67jv0t704UZ8WCDSEngQCm7 Content-Type: multipart/mixed; boundary="------------PiSQMyb4xi4gPyoUxUulCir1"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> In-Reply-To: <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------PiSQMyb4xi4gPyoUxUulCir1 Content-Type: multipart/mixed; boundary="------------Gnwb3UE1GbMejCumxeW4QdQq" --------------Gnwb3UE1GbMejCumxeW4QdQq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDcuMjYgMTM6MzksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMS4wNy4yMDI2 IDEzOjE2LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVG9kYXkgdGhlIFhFTl9ET01DVExf c2V0dmNwdWFmZmluaXR5IGh5cGVyY2FsbCB3aWxsIG5vdCBvbmx5IGNoYW5nZSB0aGUNCj4+ IGFmZmluaXR5IHNldHRpbmdzIG9mIGEgdmNwdSwgaXQgd2lsbCByZXR1cm4gdGhlIG5ldyBl ZmZlY3RpdmUgc2V0dGluZ3MsDQo+PiB0b28uDQo+Pg0KPj4gSW4gY2FzZSBhbiBlcnJvciBo YXBwZW5zIGR1cmluZyB0aGlzIGh5cGVyY2FsbCwgdGhlIGV4cGVjdGF0aW9uIG9mIHRoZQ0K Pj4gY2FsbGVyIGlzIHRoYXQgdGhlIGFmZmluaXR5IG9mIHRoZSB2Y3B1IGRpZG4ndCBjaGFu Z2UuIFRoaXMgaXNuJ3QgdHJ1ZSwNCj4+IGhvd2V2ZXIsIGlmIHBhc3NpbmcgdGhlIG5ldyBl ZmZlY3RpdmUgYWZmaW5pdHkgYmFjayB0byB0aGUgdXNlciBpcw0KPj4gZmFpbGluZy4NCj4g DQo+IFRoYXQnbGwgYmUgdGhlIGNhbGxlcidzIGZhdWx0IHRob3VnaC4gQW55IC1FRkFVTFQg Y29taW5nIGJhY2sgYXJlIGFuDQo+IGluZGljYXRpb24gdGhhdCB0aGUgY2FsbGVyIG5lZWRz IGZpeGluZy4NCj4gDQo+PiBJbnN0ZWFkIG9mIG1ha2luZyBlcnJvciBoYW5kbGluZyBpbiB0 aGUgaHlwZXJ2aXNvciBldmVuIG1vcmUgY29tcGxleCwNCj4+IGp1c3QgY2hhbmdlIHRoZSBp bnRlcmZhY2UgYnkgTk9UIHBhc3NpbmcgYmFjayB0aGUgbmV3IGFmZmluaXR5LiBJdCBjYW4N Cj4+IGVhc2lseSBiZSBvYnRhaW5lZCBieSBhbm90aGVyIFhFTl9ET01DVExfZ2V0dmNwdWFm ZmluaXR5IGNhbGwgaWYNCj4+IG5lZWRlZC4NCj4gDQo+IEF0IHRoZSBleHBlbnNlIG9mIGZ1 cnRoZXIgaW5jcmVhc2luZyB0aGUgcHJlc3N1cmUgb24gdGhlIGRvbWN0bCBsb2NrLg0KPiBX aGVuIG1ha2luZyB0aGUgcmVjZW50IGVycm9yIGNvZGUgY2hhbmdlIGluIHRoaXMgYXJlYSwg SSB3YXMgYWN0dWFsbHkNCj4gd29uZGVyaW5nIGluIGhvdyBmYXIgdGhlc2UgdHdvIHN1Yi1v cHMgbWlnaHQgYWxzbyBiZSBjYW5kaWRhdGVzIGZvcg0KPiBtb3Zpbmcgb3V0IG9mIHRoZSBs b2NrZWQgcmVnaW9uLiBZZXQgd2l0aCB2Y3B1X2FmZmluaXR5X2RvbWN0bCgpIG5vdA0KPiB1 c2luZyBhbnkgbG9ja2luZyB0aGF0IGRpZG4ndCBsb29rIGVudGlyZWx5IHN0cmFpZ2h0Zm9y d2FyZCB0byBhbnN3ZXIuDQoNClRoZSBjYWxsaW5nIGhpZXJhcmNoeSBmb3IgdGhlIFhFTl9E T01DVExfc2V0dmNwdWFmZmluaXR5IGNhc2UgaXM6DQoNCnZjcHVfYWZmaW5pdHlfZG9tY3Rs KCkNCiAgIHZjcHVfc2V0X2hhcmRfYWZmaW5pdHkoKQ0KICAgICB2Y3B1X3NldF9hZmZpbml0 eSgpDQogICB2Y3B1X3NldF9hZmZpbml0eSgpDQoNCnZjcHVfc2V0X2FmZmluaXR5KCkgZG9l cyB0aGUgY29ycmVjdCBsb2NraW5nICh0YWtlcyB0aGUgdW5pdCBsb2NrKS4NCg0KRm9yIG5v dCBuZWVkaW5nIHRoZSBkb21jdGwgbG9jayB0aGUgWEVOX0RPTUNUTF9nZXR2Y3B1YWZmaW5p dHkgcGF0aA0Kd291bGQgbmVlZCB0byB0YWtlIHRoZSB1bml0IGxvY2ssIHRvby4NCg0KDQpK dWVyZ2VuDQo= --------------Gnwb3UE1GbMejCumxeW4QdQq Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------Gnwb3UE1GbMejCumxeW4QdQq-- --------------PiSQMyb4xi4gPyoUxUulCir1-- --------------A67jv0t704UZ8WCDSEngQCm7 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpFEWYFAwAAAAAACgkQsN6d1ii/Ey+R hQgAiFcQL1/BexzltyBKpcNqde3m58V3k66enVf924PZisyIWKt5uR5o7SSudOG0CAlPd7ZxMwaJ q9pwx3BN72wok+1m5jS6ZoiRm19FBb3gCYx6XtAB2mxRSH4I4nVNiBociGALbeCOGyIxaFD69ZQ/ jsKVEVUyH7U7fehoqkeIxYJKWzTPsE9+jaI0wmbgyHGo5Uw5A7FH/oxCBPpTuue3eAS5fwUcoT0t 6DHn/r1UiWDS6SXfiVzL7KnaRtrVvidZAF9qFV+bgAPWpPvaC7JvORfKTpds3ej2BcSUdPmfJs56 C4hkty5BejF0aMvjJgAcqeWILU3W9+eJj8jr4GlcYg== =aag2 -----END PGP SIGNATURE----- --------------A67jv0t704UZ8WCDSEngQCm7-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 13:48:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 13:48:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349970.1607553 (Exim 4.92) (envelope-from ) id 1wevIt-0005Gr-Ew; Wed, 01 Jul 2026 13:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349970.1607553; Wed, 01 Jul 2026 13:48:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevIt-0005Gk-Bp; Wed, 01 Jul 2026 13:48:39 +0000 Received: by outflank-mailman (input) for mailman id 1349970; Wed, 01 Jul 2026 13:48:38 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevIs-0005GZ-Bc for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:48:38 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wevIr-003xrh-C9 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:48:37 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a451ab1-5cb7-0a2a0a5109dd-0a2a4505ba8e-14 for ; Wed, 01 Jul 2026 15:48:37 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a451ab4-3cb2-0a2a45050019-d1558036dcae-3 for ; Wed, 01 Jul 2026 15:48:36 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493a97fad2fso6087765e9.0 for ; Wed, 01 Jul 2026 06:48:36 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d1f1asm83687285e9.7.2026.07.01.06.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 06:48:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782913716; x=1783518516; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=FZJ7FVfbTz+w5KSCQNEAopHFenppAWwmNKWbesF+99g=; b=KJ2WNXdZN9npSCi74F/z7yJeslgTUv4kHRDRD/4FakqmyqvbTUkR8vnM2Y0+XmvZpy GnGYmtULYo1gZYG/R99ANm6up95MqidKrhFI7JzbN7mBSjJ/jXqqeCseRc76ZbWJgOlq WR9pXjla4J2/MDEnl9fy9Fqcc3DRzeZEwa9cP6qHV6ivU4aSHcPaavKcdYDNCs04RWUM jlWKwti3mABtyt4TtT/l/JkVsK6oYq7uyA3BE4yWwV2B9Mu39GanhIX4eXZSIiuda6jh r4RxszjL6hYyB1EJxSfX7xcQ6fNR+poIw1OrDBrE90Rnp0W70e174xH6BzATlZa8CNKW yeDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782913716; x=1783518516; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FZJ7FVfbTz+w5KSCQNEAopHFenppAWwmNKWbesF+99g=; b=nJViyERRfG0ySt5QFu5Ehzd17BOFXoWrc1hs56MtyWEjyow6H7ryxP9mrdlV00pPr8 zoE7hThnb0JRbmBnjLIndeMxlPzA+cjL21sBtzirXzkSyE6HTm0PiDatIZK60GXlZ7NO b66OvMuqdLAEGsbGHBr14ioPeo0pvgQMEmGlDdwwq5HVo6OZm4w5RS+8JhNMEhZIV1Es RRzqHkZsZxClmLph5aw/gwRixIPCfawmAHzwMXw8dS1GrMq7Y0ci6EnmQQQUOljkGhDq E/G2Yiz2SYNikpBUdpq5Eo4zeX+Oi0KxEB1x/jmoqLFCT3ZPrbjv2IyRNflgEcVGYqHM 09lw== X-Forwarded-Encrypted: i=1; AFNElJ/03R8LOymGd+iDzy+O8REA+rJem8ERJLcoQvZeJpu9KfduHwimuTd0aemH9PgJELbqzrgLpVBos9s=@lists.xenproject.org X-Gm-Message-State: AOJu0YyCNDw+oi30emjFHH7me8b8s2L7E1GQ9wooIFS6VZYzkEvxd+aD eabc8d6eirmg8KMHAXk07HmqudgJXDW9PT/WNMI2xOVc9rSjmiMcQFYUKcbZANt+sg== X-Gm-Gg: AfdE7cnYPQ91jG6EYP2r31ZW07EDxNaCfrsBsniksEmRTL0iPAOCVFIgFQU8nFuD7q0 jjhPZqFTjXBN1X/bMdoe+e+lDJS8oo5yxKOz+3wBeCNuraxTKBfK/bBZAQEb1+6GzZvidzoj6+c nTKbFCBd++ZWRI1mDllw21FnfY9igblO06SaEHMvHnpma2qwFrJUD+SI7UQDhBCQ1OGdAzYY1F7 Vy383Mi/j5fg3h2emYFNn0qZNh/l7wHZnUVb3MoWwWB7xwDzVMQMXyEMioR70K2eWF1XdLUryWT nOFPsnz5j1HO7g1syYYsdPfwMry2iVTZHVYBL44YNwetXQhQT8CrXVPz6W9o2UHn0i4r5GqJaOC CAIYrZwCF3/r8Zssrdo9FKjbW5hGfi9LN/upLq2JqjA8k+sPP5SUYzwnGdyf3CSwUlVypvRWuOg ZJWu9WNyklhCjMXG5JfNQb9Qv6wtjww9j8fvaRFA8LRF0dCgXlGlIXeXqSJc4XOzAn0NFsK7aVV M6q X-Received: by 2002:a05:600c:c093:b0:493:bb4d:4dfe with SMTP id 5b1f17b1804b1-493c3cf0d10mr11006325e9.23.1782913716355; Wed, 01 Jul 2026 06:48:36 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 15:48:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1782913716-14B012B8-335149DC/0/0 X-purgate-type: clean X-purgate-size: 1672 On 01.07.2026 15:08, Jürgen Groß wrote: > On 01.07.26 13:39, Jan Beulich wrote: >> On 01.07.2026 13:16, Juergen Gross wrote: >>> Today the XEN_DOMCTL_setvcpuaffinity hypercall will not only change the >>> affinity settings of a vcpu, it will return the new effective settings, >>> too. >>> >>> In case an error happens during this hypercall, the expectation of the >>> caller is that the affinity of the vcpu didn't change. This isn't true, >>> however, if passing the new effective affinity back to the user is >>> failing. >> >> That'll be the caller's fault though. Any -EFAULT coming back are an >> indication that the caller needs fixing. >> >>> Instead of making error handling in the hypervisor even more complex, >>> just change the interface by NOT passing back the new affinity. It can >>> easily be obtained by another XEN_DOMCTL_getvcpuaffinity call if >>> needed. >> >> At the expense of further increasing the pressure on the domctl lock. >> When making the recent error code change in this area, I was actually >> wondering in how far these two sub-ops might also be candidates for >> moving out of the locked region. Yet with vcpu_affinity_domctl() not >> using any locking that didn't look entirely straightforward to answer. > > The calling hierarchy for the XEN_DOMCTL_setvcpuaffinity case is: > > vcpu_affinity_domctl() > vcpu_set_hard_affinity() > vcpu_set_affinity() > vcpu_set_affinity() > > vcpu_set_affinity() does the correct locking (takes the unit lock). But that's not sufficient: The two involved vcpu_set_affinity() calls want to stay together, i.e. not race with another domctl. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 01 13:51:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 13:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349980.1607563 (Exim 4.92) (envelope-from ) id 1wevLJ-0006mL-QO; Wed, 01 Jul 2026 13:51:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349980.1607563; Wed, 01 Jul 2026 13:51:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevLJ-0006mE-NZ; Wed, 01 Jul 2026 13:51:09 +0000 Received: by outflank-mailman (input) for mailman id 1349980; Wed, 01 Jul 2026 13:51:08 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevLI-0006m8-F1 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:51:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wevLH-008vKN-K2 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:51:07 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a451b47-5cb7-0a2a0a5109dd-0a2a450ba0ae-24 for ; Wed, 01 Jul 2026 15:51:07 +0200 Received: from [52.101.57.61] (helo=BN8PR05CU002.outbound.protection.outlook.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a451b49-ac48-0a2a450b0019-3465393d69cf-3 for ; Wed, 01 Jul 2026 15:51:07 +0200 Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by SA1PR03MB8120.namprd03.prod.outlook.com (2603:10b6:806:45a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 1 Jul 2026 13:51:03 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 13:51:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oR7vbjoLDE55bkscEN2SWhuDBR6tLMevZYgh2NVYlPh/e05AG+OcR+HCjEPc22IS9cDgpVxAOGTrlJwGSi6g9kDPWYoNKDpMVwX1PB0KQzV/e0Dk/xrRZtnhLsAiJauf1wXh3VdFxx9gQ+CfQ5PYOkOkMaadPaN49WRXeMRVLIT741NPCiE/kxME9JpXZiyf+MnzxlRm2xEeX7qDdqz50/8PHYksHQ+dhiCZncroasyugzjY60azbaJGvlMWB0gC/ctvyjqe0iWRPjEaxPbMNaeglaB2bwRL2JYeBmIGj8TKixFmoriGjaZqDn+wWyWq/Bjlg2IMuHn1TCp3DV1okw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DeFYD1itcvvrOkUoVVS10szFH4+dabBDBCG+OcqW+/I=; b=SqRBDmh5mr2NQ/KITe0aDb5ufrFkh7qEPWOOIMJlF69jp8E+/Olvd73ZvNeWHYM3Mg1F/aH1Obc0S3oxgpiuQW85OiJb7MjyNHk1XiJCUT/AdjLqjbuG3uZvowQJAOEq3KH2mlCWPGv9AXUFp4lp5K0hdQJOW86F+hpZH+GSZrJz3gvmekcHHFr9/I/0QK2g9Cx5TUpa5wOJ59WzraJT4KnQMiwvWx2mD6aAakypk4NSLn5EYxyG9AaRTw3F8S2ENj5MoWJTjLn8Sn/0wyrzkSEwGbJHH4d09PbjTr65q/Ca2yL3axs3LxNk41RGA7yom96kzhds/an4VmjScGczBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DeFYD1itcvvrOkUoVVS10szFH4+dabBDBCG+OcqW+/I=; b=AF+eaWzJQ6aXozJd6G21R0z7I0O3JfO6FZJKV8EolNlvF1OE5mWlFSsfgks0UU0wW5Unat3iaQ0VKoUmvoAxku4b/56if15kEfwa7DXc/cA5EPWxBFy1HBnHCdXcLmyLVNSEx33Z+P/z1pSzoN3En1f8aig9GrtpohMiGOKneZA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 1 Jul 2026 15:50:59 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ryo Takakura Cc: andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org, ross.lagerwall@citrix.com, sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, anthony.perard@vates.tech, jbeulich@suse.com, taka@valinux.co.jp, den@valinux.co.jp Subject: Re: [RFC] xen/arm64: livepatch: enable attaching callbacks Message-ID: References: <20260701090908.15204-1-takakura@valinux.co.jp> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260701090908.15204-1-takakura@valinux.co.jp> X-ClientProxiedBy: MR1P264CA0144.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:51::8) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|SA1PR03MB8120:EE_ X-MS-Office365-Filtering-Correlation-Id: 34c2f12c-37fa-4587-9dc6-08ded777ca77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|23010399003|22082099003|18002099003|6133799003|3023799007|5023799004|11063799006|56012099006|4143699003; X-Microsoft-Antispam-Message-Info: w+tTTEZZHxxx6RNU7TZCCWefMOlamR2//8fFurf7bKsgq976e064Gd9QHzpDv0bddFp0yJztDNfRDmGGf0G7qzTDbnD0BxJB3NZy9A7KW76fNwtSRLVqydZXhemDyDOxppFXSeL7D3itUHWfa9xd+cLMxgtHCl6r1EHJlM05XynAN4v6mL+hPLryx7z1xbPyyEj0dTFwCQ2SR5Q8LYU9/ReWvC1sNxdixCeIG+zW4Z8zvmKQbxXqGQxFqTK0ki6ycEqyRfIKLLgtKUwd1oX/sZvkfrhrlCCPf6ZmdgOilMNUkGTZjJbabu/DCNuFKcDVzYsjIJ9Vtm74tODKTb5Dmdt5QOjAh3OeMszNxOAjh7vXByFuVNzC8rZIUMVKKLQrrm3wHDncKb6aPlfBv2siWVs97DTUW8i1BHNoa4J55tbIyy4cuQ78FzV7LLC+PEH246KOjDn9TSHzRjNFlbnNOYLc0BiCE1kDZ+gyPr0GpXyoe2NaACUIzBSqNfasRK8CqWYM1A/hrYxyyR+XQSdpnfcPaVAqIfgDrhh81C4oM7jbZPFgefGpbm1ZhJX13TgeuQnuBWqf0fYT2pjbAHDMiMF/nRDYiAoXBhPbWAKgHeE/gJcgRy5uTDrVrLPd/t9PG7tI9F754dfE3cRxvIw/M3fejS4aCiQAvixzF4S5Qjk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(23010399003)(22082099003)(18002099003)(6133799003)(3023799007)(5023799004)(11063799006)(56012099006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG8vMEpweHpVQXd3UVNoaXVFZ3Btbjh2SURWSWMrSjRaekU2Y2diOWhTWDVU?= =?utf-8?B?dDM0T2JsZm1yUmNOV0E2eUhlaWNjSThNaGYyeFJCb2lINTFHTVRuQnZmcEVO?= =?utf-8?B?N3RQMkpFYnNNRG1hejJVNWdGeS9pWEZvSjF1Y0l1K3ZvNWdhY0VGb3hGWTdL?= =?utf-8?B?RzRLaU9BNDhYV0hrclhVamtsellBTURzREd1bDUxODkydEtydEc1T0VHRjZ1?= =?utf-8?B?V0lzbXpNS3lYb3UvQnh4cFp3aUswZTBMSFlhRFhSWitYOGlGWGd5Um1obUdK?= =?utf-8?B?VzJLdDkrejZ4bmlybVkvTitBWXY5dFR4SEZOdmV6WHNCd0NtNjMwTk9weElD?= =?utf-8?B?UFYxSExpUUU3Y0twUVpZSFJiMGNHd2dnREROMG4raStEUWxsMGdZVmEybzVH?= =?utf-8?B?T2Q0VTRzVHpiWlQ3UTRIV0FSYk4rMGpIbmtPdEYvemtubkRLREwvaktIL2VB?= =?utf-8?B?cUQ0bUdFdjhiZ0Z4bWt1TmpFbzA5d1FLZ1c5VzByZktaQXJlSUgrMUM5UFg2?= =?utf-8?B?K1lhdjdYRVFKUCs3Z2JkSkRRYjVEVGM0bUZaQnREV0oydXprb3VRT1Fleitx?= =?utf-8?B?UWw2RldneUtOVmJwWmpQTVljbnZIdmJVUFN6VzROWjJ5MDRRVWtsb0VWaW1G?= =?utf-8?B?N05zU0VOK0JCQ0g2angwaVpyVXd1UG1HaSt6ZVdNd250TkUxR3JrVmRWcE5v?= =?utf-8?B?SFl2SXdrc3MwdzFiMDBkeG9kU1F1WXBCWWZ3aDc5LzJ6dXFPWTYyYjhvTDRC?= =?utf-8?B?R0ZSek84MzQyeHV3WGc0S3hsYzNQY0hTeEtrc2JibjFhc3c1dzVDUWk2cVNo?= =?utf-8?B?YytuL1pKV3pRdjBPc0pTeExPdU5OUnRmakZFRnlPdmI3V0lVNFZSRzZCVDFh?= =?utf-8?B?V3phTTYyOGNMWHhJMjFFK09KdEgwdFRjUEJhbjBZSXlXQUhKMkp4SXZHNXhn?= =?utf-8?B?bnkyVGlwSkh5WXI2MVU3YlBIbmVURFhLakp1d2JNK1c1b1ZSQmp2N01LN0RO?= =?utf-8?B?aHFKcUxpc01hTmUxNjlpdGl1VWdQMmFZZVc4TElqUzdSTmJkcFE2WTRqQys2?= =?utf-8?B?UnFRc1ZmRzdCeEVZSjFBWDczVTNHUDVROWpDWFNTdDdnVWNpWlNOUzQxOGM1?= =?utf-8?B?czcvbXlGcklTbjN2YXZWaTlza2lndDM0NDJjeWd1d2IyeG95Tkc1Z3o0SytR?= =?utf-8?B?Q2VoUUw2NEpaWm52cWc4NlV4bEsrOUNQNjkybkNRZVovalFBS2VDQ1JESXE5?= =?utf-8?B?TC9BZGs4enUwaWhpdW1lS24zM0RiNzhjRjF3c3FnUFU1VkEzZk5vbnQwa2cw?= =?utf-8?B?bVNCNFcvZzRNaXdFa0E5NW1XQ0krVTlaVXNKRlQwOUVHWFJMVmlWaU9wSHJm?= =?utf-8?B?VHhPdzJ2Rm9NdHZYTjA0U1hBd1Y4U2tSS0lDUVJyTHgvMW1vZFZGQ1h5Rjl3?= =?utf-8?B?a1J2N2RBWjJ3V3VCVEo0OVE5U0dZa0hqb0JycldwV21UTHlKS3B1V1RVcXJo?= =?utf-8?B?U1FEZzFiWDc4WWQxaGdBUWxmUmE3ZHNLeGd3MXJlL2hNZSswU1pOM1pNdk1J?= =?utf-8?B?L2I0VDhRZExLeTFSTXU3NmNUMXJYQ1puTWQyd0FmVExDbmIweTJra1lORC9a?= =?utf-8?B?QjVKMnRIWHhLK2NKdEVIbkZCZVM4bllYeEd4QzJ2emNGU0pxcXBnSUMxcUxz?= =?utf-8?B?cTRUK0E5ZGdlMS9hWlpKbU9ZY3lqKy93WTVaSDRwN2w0WndxNU1JRTFwNkVr?= =?utf-8?B?dVREZ0VHZ0YwVnM3eUhaeGJTRTl2RjQ4SmVXQXhmamgvMnVnek9Sb1VBdGdZ?= =?utf-8?B?ellzNDk4TlFvcllOS1Jma0g5YSsvcU9ZMmNTSWRYOGYyNzhpdTkzR0NXNmg5?= =?utf-8?B?SlZFdDVCeGdUdUZ2SUw5NitzYTZPa0pwVWFFcmp4TWxGcW14cXdZUjQ2UDB2?= =?utf-8?B?QStvbzYxSVhrZ1pOcHoxeElqRjFVTjBmdnBpc1JMSFpzMlVnSVpXTFRkRGRm?= =?utf-8?B?dTB6d3V0K1RPQ1NMZC9xSWZmVldxbzBJWk4wc1NIOTUxRDhyL290WjdLelpX?= =?utf-8?B?bmpiTEZaZ1p3d084OHNsZFVWdU5ySWhIZWhjUWVIdHVRamlJVTlYK21UNUNi?= =?utf-8?B?aW1paWtBR2RkaldLZjQ5elo0VWVCWkx0ZzhmZDBUSFlxTHFLalB2ZTlGdCtQ?= =?utf-8?B?L2xmREttK3JSWk9HWTVibjcxOWdENzdBSDRBdkFuZU02eHBKMytSU29UczN6?= =?utf-8?B?bUd2ZVVnRDZkVFlQZkNNaktqRXlPaS8yeEJ1L24rT1RLSFhpeHNXQ21tSjFo?= =?utf-8?B?UmI2ZG9uV09yYzR2TXM4VUFDZFZlNmdCTzRJMGltaWJuQ2FyOTlSZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34c2f12c-37fa-4587-9dc6-08ded777ca77 X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 13:51:03.2481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ddo1rZeHbuFoxkclOtiRDvj6jo3JPk6CCHWgifMc7dnzZUSuE3FpsuCQkl12F/iFB5BH9mhEMMIxBfLZHzaysA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB8120 X-purgate-ID: tlsNG-42698a/1782913867-A7F36220-668E85D5/0/0 X-purgate-type: clean X-purgate-size: 3118 On Wed, Jul 01, 2026 at 06:09:08PM +0900, Ryo Takakura wrote: > Hi Roger and Andrew, > > On Tue, 30 Jun 2026 08:47:14 +0000, Roger Pau Monné wrote: > >On Mon, Jun 29, 2026 at 11:01:28AM +0900, Ryo Takakura wrote: > >> Linux ftrace allows registering callbacks which is useful > >> for debugging and tracing events. On Linux, it is done by > >> reserving function entry points at compile time which can > >> later be patched to branch to a trampoline. > >> > >> This patch implements similar callback feature, but with > >> different approach using existing livepatch infrastructure. > >> Instead of reserving function entry points at compile time, > >> the traced function will be livepatched so that it branches > >> to the trampoline. > > > >While this is an interesting usage of the livepatch logic in new ways, > >may I ask why not do as Linux and add an empty function preamble that > >can be replaced at run-time with calls to hooks? > > > >You could still re-use most of the livepatch logic for handling the > >addition of the hook calls, but it would be nicer in that we won't > >need to move the original function. > > I agree that we can reuse a lot of livepatch logic. > > >> The role of the trampoline(illustrated below) is to preserve > >> the context while jumping to the tracer function, and return > >> back to the traced function with its context restored. > > > >Alternatively - why not use livepatch-build-tools against a build with > >the added hooks to generate a proper livepatch? This looks a bit > >fragile to me (see the question from Andrew about fixing up > >instruction pointer relative references). > > Yes, I think proper livepatching would still be preferred > given all the concerns Andrew and Roger raised. > > >On x86 at least we would also need to adjust the bug frames and > >exception table contents, and the contents of the symbol table to > >account for the function being moved. > > > >IOW: it looks like overall this is a lot more work than possibly > >reserving a function preamble to add hook calls? > > Yes, I agree. > (I wasn't aware of this additional work when I replied > to Andrew yesterday, thanks!) > > And if I were to summarize the discussion so far, assuming we > still want to add a tracing-feature, I think we are in agreement > adding an empty function preamble like Linux. > (I personally would still like to see a framework on Xen > that is more convenient and tracing-friendly which can be used > reliably at the same time) > > If this sounds reasonable, I will try preparing one based on > the feedbacks I was given so far: > - Use of Linux-like reserved function preamble > - Use of __attribute__((no_caller_saved_registers)) > - Split replacement and preamble-hook handling in common code > > Let me know your thoughts! I think the above approach is easier to implement, and more reliable than the current proposal. Do you also have the intention to integrate this with existing tracing tools used by Linux or other OSes? That would be very useful IMO. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Jul 01 13:52:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 13:52:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1349989.1607573 (Exim 4.92) (envelope-from ) id 1wevMi-0007I8-4H; Wed, 01 Jul 2026 13:52:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349989.1607573; Wed, 01 Jul 2026 13:52:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevMi-0007I1-0D; Wed, 01 Jul 2026 13:52:36 +0000 Received: by outflank-mailman (input) for mailman id 1349989; Wed, 01 Jul 2026 13:52:34 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevMg-0007Hs-SP for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:52:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wevMg-00B58B-5Z for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:52:34 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a451b9f-2eae-0a2a0a5409dd-0a2a45088f56-6 for ; Wed, 01 Jul 2026 15:52:34 +0200 Received: from [209.85.221.46] (helo=mail-wr1-f46.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a451ba1-edec-0a2a45080019-d155dd2ef026-3 for ; Wed, 01 Jul 2026 15:52:33 +0200 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4763b0c1dcdso798018f8f.2 for ; Wed, 01 Jul 2026 06:52:33 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4756636ce7esm18672970f8f.23.2026.07.01.06.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 06:52:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1782913953; x=1783518753; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xl3e4suKSPl7CWk+sb8bPatN3ANB8eUSjC46flYftEE=; b=DknmK2MOxsjafHEumZJq0pswxDGKZal8eKAmaAM6Kh+0PPVO8c+VKgALVXbT3Kjx+3 UkoO5E+XfDUsdt4jCTEAK/nA3YyRYzWHcRPP9WYWXc9rWRzEB8ijM5+FXR9WIzjxG5wU Qn4mWx2Um0+nx0w1uFYdm7upvJtPrftqqrSIY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782913953; x=1783518753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xl3e4suKSPl7CWk+sb8bPatN3ANB8eUSjC46flYftEE=; b=DipnSc9Mz/vVvPnMj/QpRqmaUAWIh+v1g0J4CaeDmRKc1+lDglYVdFVAF0pgcX0szP 5ugHrHrZa4BRriAeOA+Jbuvjy29FEgR8XCXZXr5KrBDZif1+aAW/x2rgpx77KxDbPysR tE2trzBFoTjTOon4JRe57g3AKISIQjqBFI9tFupAqEJt0ut1uAoCko9phKs938jILWLJ Ugo9ax11HEZzwANh65G+809TmuNbHsSU4sR0mwaf3tPEcxmLCFZVLB5EysO0Ij1bs538 zMPp2015B8v1cf4dv+txeZ0gae0/9TzLQi3amhowVnwocVnmfUMWOJZPNsbHYYS2BUdb LDAQ== X-Gm-Message-State: AOJu0Yy7JsPgpWEWZM8HMimZv4reNnLEc86KDQBA4luE/7chSPwNQiyx FSxjuBTXAkWOvIWFxz0hcecAjtmxnUrvJgt9gBl7Uncp46gTeTgnMK85CEfwY9bDT+FG1G4nFiA NAQB1 X-Gm-Gg: AfdE7cm1A2pEIVp1KfLTg26BeFk4DReA8wBmxoi/fG5t8kHo/T88Wnje93SGDqEqzuH HhXt7JpQa/FYlS5/y0u+T9YsDg1N9nfbs1tFbefUtlOiSBndHUp9y0Gl5N1r62FK8psziU0Pnyr 6YTFBpN3jYjFLTSf2OrmkGxx4Izc6cYT99k9wf9jk4D9bHjxL3E1PPA2a3lNWnzi6UQs/KlwHJw sR60CFD2ZsCGwhqMGySKOzC2joYUEHDIQJK900IyUw1h06EcUAO+xdq7yqyGvbTFiBUBQCCz+5g NeVtnBD5rqV8jYO9JAJyWKParS/OTYdGrJC2iXG7sY2awa9JYBq2m4fXOe3jENhqSFSCyLAfIT9 KmjT1t2ZAQw8DLJ2p3KfvLTmye+IeRYF9nnYY+jXJl5SwFFBMrt7pRJcT+W+1Swz2Z/4eOS1RRD eW5q6FVv+Nsn1VbV0qwz+q4jgxR21kq9KgsdKGN8A9vyl7K4dhFJtf1u04bLUMb9ixluKtU0AcH Q== X-Received: by 2002:adf:ed42:0:b0:477:80fa:f44d with SMTP id ffacd0b85a97d-477b5677843mr793528f8f.40.1782913952815; Wed, 01 Jul 2026 06:52:32 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Frediano Ziglio Subject: [PATCH v6 1.9/16] libs/guest: Allocate rec_pfns earlier in write_batch() Date: Wed, 1 Jul 2026 14:52:30 +0100 Message-Id: <20260701135230.794306-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260619130501.272832-3-frediano.ziglio@citrix.com> References: <20260619130501.272832-3-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1782913954-A2D3B3FC-A57FC2C9/0/0 X-purgate-type: clean X-purgate-size: 2133 For reasons which escape me, rec_pfns are allocated separately to the rest of the batch allocations. Allocate them all together. This will allow for future simplifications to be performed in an incremental mannor. No functional change. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Frediano Ziglio --- tools/libs/guest/xg_sr_save.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index fdbceab52e46..69fe991a8113 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -116,8 +116,10 @@ static int write_batch(struct xc_sr_context *ctx) local_pages = calloc(nr_pfns, sizeof(*local_pages)); /* iovec[] for writev(). */ iov = malloc((nr_pfns + 4) * sizeof(*iov)); + /* page_data record PFNs list */ + rec_pfns = malloc(nr_pfns * sizeof(*rec_pfns)); - if ( !mfns || !types || !errors || !guest_data || !local_pages || !iov ) + if ( !mfns || !types || !errors || !guest_data || !local_pages || !iov || !rec_pfns ) { ERROR("Unable to allocate arrays for a batch of %u pages", nr_pfns); @@ -208,14 +210,6 @@ static int write_batch(struct xc_sr_context *ctx) } } - rec_pfns = malloc(nr_pfns * sizeof(*rec_pfns)); - if ( !rec_pfns ) - { - ERROR("Unable to allocate %zu bytes of memory for page data pfn list", - nr_pfns * sizeof(*rec_pfns)); - goto err; - } - hdr.count = nr_pfns; rec.length = sizeof(hdr); @@ -264,11 +258,11 @@ static int write_batch(struct xc_sr_context *ctx) rc = ctx->save.nr_batch_pfns = 0; err: - free(rec_pfns); if ( guest_mapping ) xenforeignmemory_unmap(xch->fmem, guest_mapping, nr_pages_mapped); for ( i = 0; local_pages && i < nr_pfns; ++i ) free(local_pages[i]); + free(rec_pfns); free(iov); free(local_pages); free(guest_data); -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 13:58:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 13:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350000.1607580 (Exim 4.92) (envelope-from ) id 1wevRr-0007wE-K5; Wed, 01 Jul 2026 13:57:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350000.1607580; Wed, 01 Jul 2026 13:57:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevRr-0007w7-HN; Wed, 01 Jul 2026 13:57:55 +0000 Received: by outflank-mailman (input) for mailman id 1350000; Wed, 01 Jul 2026 13:57:54 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevRp-0007w1-Vv for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 13:57:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wevRo-0030IK-3w for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:57:52 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a451cd0-e002-0a2a0a5209dd-0a2a450bd6d4-30 for ; Wed, 01 Jul 2026 15:57:52 +0200 Received: from [209.85.221.43] (helo=mail-wr1-f43.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a451cdf-ac48-0a2a450b0019-d155dd2bdd3f-3 for ; Wed, 01 Jul 2026 15:57:52 +0200 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4720d22c94aso625467f8f.1 for ; Wed, 01 Jul 2026 06:57:51 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d1f1asm84305675e9.7.2026.07.01.06.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 06:57:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1782914271; x=1783519071; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BIJgGOMFkoaNlmHYqWSEkGMrKi3GrI6JuJgk0+8+tmY=; b=GlKi1BpXNfmsh5TXb2Duo2Mdv1teFK6sO8VLvRaa8dtb2wIyjEkY/3sd30su1d3KVy HwUWvuONyGQqPBPZBlR1y8Ubs8hSjcIKOD8/Us+67+kqOClOa+lIg3R38Q8xJ2NwJoER nPDOO3G92LscE6+Wg0LMU4+kkU58gI1fXh3bY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782914271; x=1783519071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BIJgGOMFkoaNlmHYqWSEkGMrKi3GrI6JuJgk0+8+tmY=; b=exR/otGYjuPieRvrC3+ILeHPhpcVAKNBf14Ooy1T2mXlrLXSwkcph8drEoC2DDqIsq 1xwfm21yp9IcZRnbawGW+SuvpdxuWrSpOIJFWgvclEPoDfs+MhxrC43Am+jSvUvnN6UI UozvCVbzJxi0JtuCTOajiy3wjIPQhxEDLarIpWpHpfgvGSUHbIli1W1lrhuYI79qKkYu 4DwHAXktBqHteR84ujNYRHalj/GTqKaVGtkwyOqxwZOIuVFLNFWKX/1KEgvjZtdQtXDY jkoUNJu1E1uz33RakeGtbDKlqTGW2jrodpqpALFaBTdGNYE9tOJkVymBptS7zAXhDlz2 luzw== X-Gm-Message-State: AOJu0YwWJlny5/JSLZSt+8fzYrM+r528C8FWoOxeUYKJwBu18yDQmXOb Cy1JReA/2s6yO+t9Q52jomVDl7Tf+z6yYbpVIGiGKjIWodDfF0Nq4QIHeCItZdG7Shw82/miBZw wZQaP X-Gm-Gg: AfdE7cmErdC9+xMaft4gQ2LQmi/Co13tCqFV4GS9A5wo0jhEjrSFB3nGVZb9WdjAVRt ajgp+6x+g0Ml+5MPdk/xL8Uh0DjuQxIG0Iur5/1MUR9whuQhCZkCTRClXhAXlxBvNMN5SA0bLW1 9k6ussISLazP+qBWUbzDt8c7yPccFmBYOYnhr27XrW9hMr6DWRnsAmYcGbUIRk5pKtMWQsPvcHz l3Zc3ttYnpaLhPRaJQa+iRUst1VDetASZBru7e9fEfu57y1tjPvc2cuTG5GNNKd5JQo/mE04T4u JT0U6tFZjQTpHF395lOrelAB5cpyMn2mF/Zb6mMBD1yvwQTzjF7Y24IUgvY9srDKNGAEdWNXivp SwpKmJTXpXEgrSOVajmfT9aiPo51lz5hsZp3TVash34iWLgfg7cIE9adBDNA7I355cO04JF16JR Rzz/zdACkr292esY//EquTeQ+4HBFid7jdHWz1hNou+7rmcry77Z9vHo34PelLwUs0CxeV7VwFP g== X-Received: by 2002:a05:600c:c093:b0:493:bb4d:4dfe with SMTP id 5b1f17b1804b1-493c3cf0d10mr11552475e9.23.1782914270976; Wed, 01 Jul 2026 06:57:50 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Frediano Ziglio , Frediano Ziglio , Andrew Cooper , Anthony PERARD Subject: [PATCH v6.1 02/16] libs/guest: Reduce number of iovecs in write_batch() Date: Wed, 1 Jul 2026 14:57:47 +0100 Message-Id: <20260701135747.797083-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260619130501.272832-3-frediano.ziglio@citrix.com> References: <20260619130501.272832-3-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1782914272-A673A220-E3FC135F/0/0 X-purgate-type: clean X-purgate-size: 3256 From: Frediano Ziglio Construct all of the headers together in one block, rather than a field at a time. Initialise as many of the fields as possible at declaration time. Start filling in iov[] earlier, to allow for future simplifications. No practical change. Signed-off-by: Frediano Ziglio Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Frediano Ziglio --- tools/libs/guest/xg_sr_save.c | 45 +++++++++++++++++------------------ 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 69fe991a8113..7736f4a055e0 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -97,9 +97,18 @@ static int write_batch(struct xc_sr_context *ctx) void *page, *orig_page; uint64_t *rec_pfns = NULL; struct iovec *iov = NULL; int iovcnt = 0; - struct xc_sr_rec_page_data_header hdr = { 0 }; - struct xc_sr_record rec = { - .type = REC_TYPE_PAGE_DATA, + struct { + struct xc_sr_rhdr rec; + struct xc_sr_rec_page_data_header page_data; + } hdrs = { + .rec = { + .type = REC_TYPE_PAGE_DATA, + .length = offsetof(struct xc_sr_rec_page_data_header, + pfn[nr_pfns]), /* + the pages to send */ + }, + .page_data = { + .count = nr_pfns, + }, }; assert(nr_pfns != 0); @@ -115,7 +124,7 @@ static int write_batch(struct xc_sr_context *ctx) /* Pointers to locally allocated pages. Need freeing. */ local_pages = calloc(nr_pfns, sizeof(*local_pages)); /* iovec[] for writev(). */ - iov = malloc((nr_pfns + 4) * sizeof(*iov)); + iov = malloc((nr_pfns + 2) * sizeof(*iov)); /* page_data record PFNs list */ rec_pfns = malloc(nr_pfns * sizeof(*rec_pfns)); @@ -126,6 +135,14 @@ static int write_batch(struct xc_sr_context *ctx) goto err; } + iov[0].iov_base = &hdrs; + iov[0].iov_len = sizeof(hdrs); + + iov[1].iov_base = rec_pfns; + iov[1].iov_len = nr_pfns * sizeof(*rec_pfns); + + iovcnt = 2; + for ( i = 0; i < nr_pfns; ++i ) { types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, @@ -210,29 +227,11 @@ static int write_batch(struct xc_sr_context *ctx) } } - hdr.count = nr_pfns; - - rec.length = sizeof(hdr); - rec.length += nr_pfns * sizeof(*rec_pfns); - rec.length += nr_pages * PAGE_SIZE; + hdrs.rec.length += nr_pages * PAGE_SIZE; for ( i = 0; i < nr_pfns; ++i ) rec_pfns[i] = ((uint64_t)(types[i]) << 32) | ctx->save.batch_pfns[i]; - iov[0].iov_base = &rec.type; - iov[0].iov_len = sizeof(rec.type); - - iov[1].iov_base = &rec.length; - iov[1].iov_len = sizeof(rec.length); - - iov[2].iov_base = &hdr; - iov[2].iov_len = sizeof(hdr); - - iov[3].iov_base = rec_pfns; - iov[3].iov_len = nr_pfns * sizeof(*rec_pfns); - - iovcnt = 4; - if ( nr_pages ) { for ( i = 0; i < nr_pfns; ++i ) -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 14:20:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 14:20:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350023.1607589 (Exim 4.92) (envelope-from ) id 1wevn1-0003TF-Cr; Wed, 01 Jul 2026 14:19:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350023.1607589; Wed, 01 Jul 2026 14:19:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevn1-0003T8-A8; Wed, 01 Jul 2026 14:19:47 +0000 Received: by outflank-mailman (input) for mailman id 1350023; Wed, 01 Jul 2026 14:19:46 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wevn0-0003T2-NS for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:19:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wevn0-002zaz-3s for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:19:46 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a452200-2eae-0a2a0a5409dd-0a2a450bea26-4 for ; Wed, 01 Jul 2026 16:19:45 +0200 Received: from [209.85.208.49] (helo=mail-ed1-f49.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a452201-ac48-0a2a450b0019-d155d031bdfc-3 for ; Wed, 01 Jul 2026 16:19:45 +0200 Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6983f20a8bfso1375854a12.1 for ; Wed, 01 Jul 2026 07:19:45 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f0d68asm289584066b.31.2026.07.01.07.19.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 07:19:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782915585; x=1783520385; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=l8fT8el2oFfYGyvxnweVFg4qecD61F7QfiQTC10goyo=; b=KCPjR5XoMJBjmVyW/9SPdujFFlr22P4Ft3ql0iTzRDCdGMO+kB6gggKC/JjA4q5K06 7D0tM4RGM3scHVcrwBIbH61DAh8TMyP4MUKgTnzVbZ3WvPuwGgYdzKyZePWSuX8NqG3v exWwzmN46DSCVI7dS42pYIXA3WMSppAAqqi6pcK2D1qPzpaguHpfuFPunLBA2L5kosvD NyFOjzZD8X3teQ2GmBqF5QmrqmEp7BkcfoinGNJLmr12qJJ88sPGdi1/zv39KAo6w/Ta 0RfdDa5ortoCgTue5E+LP/YvaY9vzb6z6qbzNUr8shNl/HIsWvDPpLo0sJwpDaePFOZT g16g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782915585; x=1783520385; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l8fT8el2oFfYGyvxnweVFg4qecD61F7QfiQTC10goyo=; b=dKSS0I2HgziCnHONFIVf5/KZSmvvDHiJYo3wPOqA5NsPvXolK/okaZf3Y5E+N28xoo 2TxEYMAizNaY5WAtU7drsMVaZXNaU8WO5k2vBJRKvoqyu2QU9RDB8StICUqNFzWQHXn0 gZEsztsx5MRTf2olF/WraDJn6PSpIFTvbZ0w4cl1E7Go/aG3S7ZInEKsAmwmDpVDd6UX t/FTznh24WGUqC29ezosHd3cAXbPA17usDT6f2etV8eix0GtivAb+sd9EPWo+9CD6WEr 1hjnqnlELWtffipqjJbjyrXLRU9caVwAe6aE+avtZg1wOkSyrO7W/MrIQyQAoCpYgYQI uIXg== X-Forwarded-Encrypted: i=1; AHgh+RpoWbW5Bnh6UeCSbKhydp3k2n7SywPr1H+kpOiMXwKQEuFVG+oqCFkDASGx6ITkWvcwV8yCSl1wTcs=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzf1ADdFNC8iVJwprouodvHGsUCGQdOk9808vujmVhoQnwvG32x qHj6x0IbjzB5JkEkfFyWVNpvVo4UeKy3CYyv7jMd9xALfoIoU1gjiLZavU4oK3oQx3c= X-Gm-Gg: AfdE7cm0jQqgthdvBPb/omQX6t20LwRzfThza4JZjiG6Llium71BWCCan1+3cLvreas rPelAPlbK2ATdNJ7hs5WOpLgWTQcF3jThlWc7TlneKEAcd6o+JnBH3lQ1Z8ZfL1csi9Ozm2X2fw W5cj297izPRaJZmz65cde8zcE2YN3hHCwjpOJCq2ZsjYR3JnY61dIPt6f3+K2qr4NfDOg8Ntdo9 JrpbfT0MS07UZGcAShMDcsfjHbv1U6Cfu+zd0XaejfbsPjpRjFi4hkMuhIS6oXVF/73nqfCzU38 eIhJJHt066ZSsPpL/EMio5dby+/7+CPSTPjJ0/j+zfd6Uruayz0RYNEhywPprnkqhG82Dz+bhdI MbIRfWmajN7WyfkoQif/jGWbKa9GeuL6sM5o/vIjNAy8zCfLlzWS9byPDEK8FpNJd2dZdUF0bDw E1QCEZDOU4EyzpDEqUdNQ26P3eBVaGJVaoGhoy4/+6072ztWq14cObIs06oxv4BqDFQUCt38Zqq USIc16rgU7fnxJQAeRjU9Gjdjn4mqA3v+4wWN6VpS4= X-Received: by 2002:a17:907:a704:b0:bff:334:1fe1 with SMTP id a640c23a62f3a-c12a9dc50c4mr111586266b.12.1782915585326; Wed, 01 Jul 2026 07:19:45 -0700 (PDT) Message-ID: <8bff241e-c4c3-4ffd-b358-9ab1bb0f8a9e@suse.com> Date: Wed, 1 Jul 2026 16:19:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0p0xN5eaHpuatzKkU9YY4nTZ" X-purgate-ID: tlsNG-42698a/1782915585-3A73A220-A8AE3B41/0/0 X-purgate-type: clean X-purgate-size: 11316 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0p0xN5eaHpuatzKkU9YY4nTZ Content-Type: multipart/mixed; boundary="------------5dglv8sBPRTbNKuf8j0W90pC"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Message-ID: <8bff241e-c4c3-4ffd-b358-9ab1bb0f8a9e@suse.com> Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> In-Reply-To: Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------5dglv8sBPRTbNKuf8j0W90pC Content-Type: multipart/mixed; boundary="------------TH1xNPsNt3QwZwU0jwwtMT98" --------------TH1xNPsNt3QwZwU0jwwtMT98 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDcuMjYgMTU6NDgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMS4wNy4yMDI2 IDE1OjA4LCBKw7xyZ2VuIEdyb8OfIHdyb3RlOg0KPj4gT24gMDEuMDcuMjYgMTM6MzksIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAxLjA3LjIwMjYgMTM6MTYsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IFRvZGF5IHRoZSBYRU5fRE9NQ1RMX3NldHZjcHVhZmZpbml0eSBo eXBlcmNhbGwgd2lsbCBub3Qgb25seSBjaGFuZ2UgdGhlDQo+Pj4+IGFmZmluaXR5IHNldHRp bmdzIG9mIGEgdmNwdSwgaXQgd2lsbCByZXR1cm4gdGhlIG5ldyBlZmZlY3RpdmUgc2V0dGlu Z3MsDQo+Pj4+IHRvby4NCj4+Pj4NCj4+Pj4gSW4gY2FzZSBhbiBlcnJvciBoYXBwZW5zIGR1 cmluZyB0aGlzIGh5cGVyY2FsbCwgdGhlIGV4cGVjdGF0aW9uIG9mIHRoZQ0KPj4+PiBjYWxs ZXIgaXMgdGhhdCB0aGUgYWZmaW5pdHkgb2YgdGhlIHZjcHUgZGlkbid0IGNoYW5nZS4gVGhp cyBpc24ndCB0cnVlLA0KPj4+PiBob3dldmVyLCBpZiBwYXNzaW5nIHRoZSBuZXcgZWZmZWN0 aXZlIGFmZmluaXR5IGJhY2sgdG8gdGhlIHVzZXIgaXMNCj4+Pj4gZmFpbGluZy4NCj4+Pg0K Pj4+IFRoYXQnbGwgYmUgdGhlIGNhbGxlcidzIGZhdWx0IHRob3VnaC4gQW55IC1FRkFVTFQg Y29taW5nIGJhY2sgYXJlIGFuDQo+Pj4gaW5kaWNhdGlvbiB0aGF0IHRoZSBjYWxsZXIgbmVl ZHMgZml4aW5nLg0KPj4+DQo+Pj4+IEluc3RlYWQgb2YgbWFraW5nIGVycm9yIGhhbmRsaW5n IGluIHRoZSBoeXBlcnZpc29yIGV2ZW4gbW9yZSBjb21wbGV4LA0KPj4+PiBqdXN0IGNoYW5n ZSB0aGUgaW50ZXJmYWNlIGJ5IE5PVCBwYXNzaW5nIGJhY2sgdGhlIG5ldyBhZmZpbml0eS4g SXQgY2FuDQo+Pj4+IGVhc2lseSBiZSBvYnRhaW5lZCBieSBhbm90aGVyIFhFTl9ET01DVExf Z2V0dmNwdWFmZmluaXR5IGNhbGwgaWYNCj4+Pj4gbmVlZGVkLg0KPj4+DQo+Pj4gQXQgdGhl IGV4cGVuc2Ugb2YgZnVydGhlciBpbmNyZWFzaW5nIHRoZSBwcmVzc3VyZSBvbiB0aGUgZG9t Y3RsIGxvY2suDQo+Pj4gV2hlbiBtYWtpbmcgdGhlIHJlY2VudCBlcnJvciBjb2RlIGNoYW5n ZSBpbiB0aGlzIGFyZWEsIEkgd2FzIGFjdHVhbGx5DQo+Pj4gd29uZGVyaW5nIGluIGhvdyBm YXIgdGhlc2UgdHdvIHN1Yi1vcHMgbWlnaHQgYWxzbyBiZSBjYW5kaWRhdGVzIGZvcg0KPj4+ IG1vdmluZyBvdXQgb2YgdGhlIGxvY2tlZCByZWdpb24uIFlldCB3aXRoIHZjcHVfYWZmaW5p dHlfZG9tY3RsKCkgbm90DQo+Pj4gdXNpbmcgYW55IGxvY2tpbmcgdGhhdCBkaWRuJ3QgbG9v ayBlbnRpcmVseSBzdHJhaWdodGZvcndhcmQgdG8gYW5zd2VyLg0KPj4NCj4+IFRoZSBjYWxs aW5nIGhpZXJhcmNoeSBmb3IgdGhlIFhFTl9ET01DVExfc2V0dmNwdWFmZmluaXR5IGNhc2Ug aXM6DQo+Pg0KPj4gdmNwdV9hZmZpbml0eV9kb21jdGwoKQ0KPj4gICAgIHZjcHVfc2V0X2hh cmRfYWZmaW5pdHkoKQ0KPj4gICAgICAgdmNwdV9zZXRfYWZmaW5pdHkoKQ0KPj4gICAgIHZj cHVfc2V0X2FmZmluaXR5KCkNCj4+DQo+PiB2Y3B1X3NldF9hZmZpbml0eSgpIGRvZXMgdGhl IGNvcnJlY3QgbG9ja2luZyAodGFrZXMgdGhlIHVuaXQgbG9jaykuDQo+IA0KPiBCdXQgdGhh dCdzIG5vdCBzdWZmaWNpZW50OiBUaGUgdHdvIGludm9sdmVkIHZjcHVfc2V0X2FmZmluaXR5 KCkgY2FsbHMNCj4gd2FudCB0byBzdGF5IHRvZ2V0aGVyLCBpLmUuIG5vdCByYWNlIHdpdGgg YW5vdGhlciBkb21jdGwuDQoNCkhtbSwgd2hpbGUgSSB1bmRlcnN0YW5kIHdoeSB0aGlzIHdv dWxkIGJlIG5pY2UsIEknbSBoYXZpbmcgYSBoYXJkIHRpbWUNCmltYWdpbmluZyBhIHNhbmUg c2NlbmFyaW8gd2hlcmUgdHdvIG9yIG1vcmUgaW5zdGFuY2VzIGFyZSBpc3N1aW5nDQpoeXBl cmNhbGxzIGZvciBjaGFuZ2luZyBhZmZpbml0aWVzLiBBdCBsZWFzdCBvbmUgb2YgdGhvc2Ug aW5zdGFuY2VzIHdpbGwNCm5vdCBiZSBoYXBweSBhZnRlcndhcmRzLCBpbiBjYXNlIHRoZSBs b2NrIGlzIHNwbGl0IGJvdGggbWlnaHQgYnkgdW5oYXBweS4NCg0KSSBkb24ndCBzZWUgdGhp cyBiZWluZyBhIHN1YnN0YW50aWFsIGRvd25zaWRlLCBhcyB0aGUgbWFpbiBwcm9ibGVtIHdv dWxkDQpiZSBvbiB0aGUgdXNlciBzaWRlIGFsbG93aW5nIG11bHRpcGxlIGNvbmN1cnJlbnQg YWZmaW5pdHkgY2hhbmdlcyBmb3INCnRoZSBzYW1lIHZjcHUocykuDQoNCk9UT0ggaXQgd291 bGQgYmUgcXVpdGUgZWFzeSB0byBtZXJnZSBib3RoIGFmZmluaXR5IHNldHRpbmdzIGludG8g b25lDQpsb2NrZWQgcmVnaW9uLCBhcyB0aGUgdW5kZXJseWluZyBmdW5jdGlvbiBzY2hlZF9z ZXRfYWZmaW5pdHkoKSBjYW4gYmUNCmNhbGxlZCB3aXRoIGJvdGggYWZmaW5pdHkgbWFza3Mg b3Igd2l0aCBvbmx5IG9uZSBvZiB0aGVtLiBUaGlzIHdvdWxkDQpyZXF1aXJlIG9ubHkgYSBt aW5vciByZW9yZyBvZiB0aGUgYWZmaW5pdHkgaGVscGVycy4NCg0KDQpKdWVyZ2VuDQo= --------------TH1xNPsNt3QwZwU0jwwtMT98 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------TH1xNPsNt3QwZwU0jwwtMT98-- --------------5dglv8sBPRTbNKuf8j0W90pC-- --------------0p0xN5eaHpuatzKkU9YY4nTZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpFIf8FAwAAAAAACgkQsN6d1ii/Ey9Z bgf/Wu8DTEd5olwQOtmqjH7ZwdPWG1MLjpuhS1lIBeMEoHMua+PYUDuS9rz61qJSTTdEJeJBujum OZ7ZN29kKbruI6WeYBAGUxUcKlkafRHCFWr3SyITZzwc30nIoV8fQFdGYzpUvs6n7sgBTkA2qlqG k4xqQ21z6OzZR+d5ENdJIdNgpACiR9oYRvBB2+m9sh6SWgfHjnhcDc5HziHmkX8Q8RVM9eqM8Hc1 OL3Sx8Yo62I8yvEmlsR+1G8rVr6rzLJeM6OxoMhOTUeXUjaC2NG6LoR+W1i9sXiMAY510Y8j/32U WtBY9L2tvb0Pw8DyjOOpIhJbYXsyHQfYsWdlenzB0w== =rEQ7 -----END PGP SIGNATURE----- --------------0p0xN5eaHpuatzKkU9YY4nTZ-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 14:43:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 14:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350041.1607599 (Exim 4.92) (envelope-from ) id 1wew9b-0008Sa-5h; Wed, 01 Jul 2026 14:43:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350041.1607599; Wed, 01 Jul 2026 14:43:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wew9b-0008ST-1n; Wed, 01 Jul 2026 14:43:07 +0000 Received: by outflank-mailman (input) for mailman id 1350041; Wed, 01 Jul 2026 14:43:05 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wew9Z-0008SM-KJ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:43:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wew9Y-0049NV-I0 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:43:04 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a452778-e002-0a2a0a5209dd-0a2a4505baea-0 for ; Wed, 01 Jul 2026 16:43:04 +0200 Received: from [195.135.223.131] (helo=smtp-out2.suse.de) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a452778-3cb2-0a2a45050019-c387df8389ec-3 for ; Wed, 01 Jul 2026 16:43:04 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CAEBF76059; Wed, 1 Jul 2026 14:43:02 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A2F2F779AA; Wed, 1 Jul 2026 14:43:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id k69xJnYnRWrRUwAAD6G6ig (envelope-from ); Wed, 01 Jul 2026 14:43:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782916984; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=xGF2+lZzYIrDrm427lt7ssQD3mGyRMVR8LXNsjrebZg=; b=peSBuBHedet+PH3Kzhne5hX9O4XePlG5fkEi42h4Asv4h0PbzLDZC4j1G/GlSobbnFuLkN Eg7xPgkQjKEJw5QyTPk9fiMVp9RzsRtjbS2emNCAhzd3XAqQXoFDq3nC/AJkzFwOnlBEaT bOR1ZNgbsh9vR9V/XcU8YFfTctd+63Y= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1782916982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=xGF2+lZzYIrDrm427lt7ssQD3mGyRMVR8LXNsjrebZg=; b=ur25LJ2ATm6nrtBkHBwiT1Zyl46mc8OpB6GO3c6fyd0l+LOWbJfYs7XblAbJaGw9on0EUL ayREc5dxcRnJWnceosDvuWGrHNzEY1b8LZL9Y0okTOHrsNG99Bg9p7gI5LXkzxUdSmAMpZ L2LpEmnrjOAXaHpUYcIM9BSBAJTJq3w= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Anthony PERARD , Samuel Thibault Subject: [PATCH] stubdom: remove c-stubdom Date: Wed, 1 Jul 2026 16:42:59 +0200 Message-ID: <20260701144259.4077884-1-jgross@suse.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,suse.com:mid,imap1.dmz-prg2.suse.org:helo]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-purgate-ID: tlsNG-c201ff/1782916984-17D1E2B8-2E324319/0/0 X-purgate-type: clean X-purgate-size: 5963 C-stubdom was meant as a base for building new Mini-OS based stubdoms. It hasn't seen any work for many years now and creating new stubdoms should use UNIKRAFT instead of Mini-OS. So remove c-stubdom. Signed-off-by: Juergen Gross --- stubdom/Makefile | 19 ------------------- stubdom/c/Makefile | 13 ------------- stubdom/c/main.c | 8 -------- stubdom/c/minios.cfg | 2 -- stubdom/configure | 44 -------------------------------------------- stubdom/configure.ac | 1 - 6 files changed, 87 deletions(-) delete mode 100644 stubdom/c/Makefile delete mode 100644 stubdom/c/main.c delete mode 100644 stubdom/c/minios.cfg diff --git a/stubdom/Makefile b/stubdom/Makefile index 9aa0d3dee4..acd5e56f16 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -339,17 +339,6 @@ $(TARGETS_MINIOS): mini-os-%: mkdir -p $@/$$i ; \ done -### -# C -### - -c-minios-config.mk: $(CURDIR)/c/minios.cfg - MINIOS_CONFIG="$<" CONFIG_FILE="$(CURDIR)/$@" $(MAKE) DESTDIR= -C $(MINI_OS) config - -.PHONY: c -c: $(CROSS_ROOT) c-minios-config.mk - CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat c-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C $@ LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) - ###### # VTPM ###### @@ -432,10 +421,6 @@ xenstorepvh: $(CROSS_ROOT) xenstorepvh-minios-config.mk # minios ######## -.PHONY: c-stubdom -c-stubdom: mini-os-$(XEN_TARGET_ARCH)-c lwip-$(XEN_TARGET_ARCH) libxenguest c - DEF_CPPFLAGS="$(TARGET_CPPFLAGS)" DEF_CFLAGS="$(TARGET_CFLAGS)" DEF_LDFLAGS="$(TARGET_LDFLAGS)" MINIOS_CONFIG="$(CURDIR)/c/minios.cfg" $(MAKE) DESTDIR= -C $(MINI_OS) OBJ_DIR=$(CURDIR)/$< LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) APP_OBJS=$(CURDIR)/c/main.a - .PHONY: vtpm-stubdom vtpm-stubdom: mini-os-$(XEN_TARGET_ARCH)-vtpm vtpm DEF_CPPFLAGS="$(TARGET_CPPFLAGS)" DEF_CFLAGS="$(TARGET_CFLAGS)" DEF_LDFLAGS="$(TARGET_LDFLAGS)" MINIOS_CONFIG="$(CURDIR)/vtpm/minios.cfg" $(MAKE) -C $(MINI_OS) OBJ_DIR=$(CURDIR)/$< APP_OBJS="$(CURDIR)/vtpm/vtpm.a" APP_LDLIBS="-ltpm -ltpm_crypto -lgmp -lpolarssl" @@ -485,8 +470,6 @@ else install-grub-if-enabled: endif -install-c: c-stubdom - install-xenstore: xenstore-stubdom $(INSTALL_DIR) "$(DESTDIR)$(XENFIRMWAREDIR)" $(INSTALL_DATA) mini-os-$(XEN_TARGET_ARCH)-xenstore/mini-os.gz "$(DESTDIR)$(XENFIRMWAREDIR)/xenstore-stubdom.gz" @@ -540,13 +523,11 @@ uninstall-vtpmmgr: .PHONY: clean clean: $(foreach lib,$(STUB_LIBS),clean-libxen$(lib)) clean: - rm -fr mini-os-$(XEN_TARGET_ARCH)-c rm -fr mini-os-$(XEN_TARGET_ARCH)-grub rm -fr mini-os-$(XEN_TARGET_ARCH)-xenstore rm -fr mini-os-$(XEN_TARGET_ARCH)-xenstorepvh rm -fr mini-os-$(XEN_TARGET_ARCH)-vtpm rm -fr mini-os-$(XEN_TARGET_ARCH)-vtpmmgr - $(MAKE) DESTDIR= -C c clean $(MAKE) -C vtpm clean $(MAKE) -C vtpmmgr clean rm -fr grub-$(XEN_TARGET_ARCH) diff --git a/stubdom/c/Makefile b/stubdom/c/Makefile deleted file mode 100644 index b252dcad0b..0000000000 --- a/stubdom/c/Makefile +++ /dev/null @@ -1,13 +0,0 @@ -XEN_ROOT = $(CURDIR)/../.. - -ifeq (,$(findstring clean,$(MAKECMDGOALS))) -include $(XEN_ROOT)/Config.mk -endif - -all: main.a - -main.a: main.o - $(AR) cr $@ $^ - -clean: - rm -f *.a *.o diff --git a/stubdom/c/main.c b/stubdom/c/main.c deleted file mode 100644 index f97a0f72d4..0000000000 --- a/stubdom/c/main.c +++ /dev/null @@ -1,8 +0,0 @@ -#include -#include - -int main(void) { - sleep(2); - printf("Hello, world!\n"); - return 0; -} diff --git a/stubdom/c/minios.cfg b/stubdom/c/minios.cfg deleted file mode 100644 index 56d65510cd..0000000000 --- a/stubdom/c/minios.cfg +++ /dev/null @@ -1,2 +0,0 @@ -CONFIG_LIBC=y -CONFIG_LWIP=y diff --git a/stubdom/configure b/stubdom/configure index e127ef44eb..8a0a798bd2 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -661,7 +661,6 @@ debug xenstorepvh xenstore grub -c host_os host_vendor host_cpu @@ -712,7 +711,6 @@ SHELL' ac_subst_files='' ac_user_opts=' enable_option_checking -enable_c_stubdom enable_pv_grub enable_xenstore_stubdom enable_xenstorepvh_stubdom @@ -1360,7 +1358,6 @@ Optional Features: --disable-option-checking ignore unrecognized --enable/--with options --disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no) --enable-FEATURE[=ARG] include FEATURE [ARG=yes] - --enable-c-stubdom Build and install c-stubdom (default is DISABLED) --enable-pv-grub Build and install pv-grub (default is DISABLED) --disable-xenstore-stubdom Build and install xenstore-stubdom (default is @@ -2406,47 +2403,6 @@ case $host_os in *\ *) host_os=`echo "$host_os" | sed 's/ /-/g'`;; esac # Enable/disable stub domains -# Check whether --enable-c-stubdom was given. -if test ${enable_c_stubdom+y} -then : - enableval=$enable_c_stubdom; - -if test "x$enableval" = "xyes" -then : - - -c=y -STUBDOM_TARGETS="$STUBDOM_TARGETS c" -STUBDOM_BUILD="$STUBDOM_BUILD c-stubdom" -STUBDOM_INSTALL="$STUBDOM_INSTALL install-c" -STUBDOM_UNINSTALL="$STUBDOM_UNINSTALL install-c" - - -else $as_nop - -if test "x$enableval" = "xno" -then : - - -c=n - - -fi - -fi - - -else $as_nop - - -c=n - - -fi - - - - # Check whether --enable-pv-grub was given. if test ${enable_pv_grub+y} then : diff --git a/stubdom/configure.ac b/stubdom/configure.ac index f07b08c5b3..33f170144e 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -18,7 +18,6 @@ m4_include([../m4/depends.m4]) m4_include([../m4/fetcher.m4]) # Enable/disable stub domains -AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c]) AX_STUBDOM_DEFAULT_DISABLE([pv-grub], [grub]) AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore]) AX_STUBDOM_DEFAULT_ENABLE([xenstorepvh-stubdom], [xenstorepvh]) -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 14:45:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 14:45:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350054.1607635 (Exim 4.92) (envelope-from ) id 1wewC7-0000nY-N5; Wed, 01 Jul 2026 14:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350054.1607635; Wed, 01 Jul 2026 14:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewC7-0000nR-KO; Wed, 01 Jul 2026 14:45:43 +0000 Received: by outflank-mailman (input) for mailman id 1350054; Wed, 01 Jul 2026 14:45:42 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewC6-0000mG-FC for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:45:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewC5-003l9Q-Dz for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:45:41 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a452803-2eae-0a2a0a5409dd-0a2a450be7a6-32 for ; Wed, 01 Jul 2026 16:45:41 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a452815-ac48-0a2a450b0019-d155dd2cb49a-3 for ; Wed, 01 Jul 2026 16:45:41 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-476d8e647e9so709657f8f.0 for ; Wed, 01 Jul 2026 07:45:41 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a450bsm390780f8f.10.2026.07.01.07.45.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 07:45:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Content-Language:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782917141; x=1783521941; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=irMRNbgKvuqITnobG7iDWOXfBogQaMWuiiyBaILdGAQ=; b=ACry/BGewSTOVcBOT1L21q4RoFjtXYIqYeZUJGUNjUY/Gy9/wklliU3OZaqsfu2g4B xtmcogaaIJq2TawIJAPskuZNjrESwzErnHQ1P3d92pNyfHBSnKkp4dTgJJjsqZnjcXRt NerTPJ9wS9DO6j7wA9xDmr/SFbabZRdduMaVF2lW+2wMXHlptFjWSsfAODCY7ON6MH+u QU5iTSs4jFUyI+lbldC/hJS8WaCllSAeTLKX/kKlKeY2G5RwsXXG4XdoR/aCkzg9e+gx BTCpBFtw1rEAzCIzYDertiYZMBbt6+XmYe3+WKRQZvYYE+PQAaIj5TNMft+Na23dqNk+ 7PUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782917141; x=1783521941; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=irMRNbgKvuqITnobG7iDWOXfBogQaMWuiiyBaILdGAQ=; b=gTtay7kt2dI582wH6XEZRIfMKYPzTDXiKI9QhF1kzA99B7/Tml+fEVjm+taL8jKv/o JEj+9ON7TTDE4cBdArrhG54vntM1CDWiqaRt7aF/vhQytgUdInfSGkeRfClu5keau1+Q YMRA+2kEgtJzbBRrPx3Bv4LVA/wuFS8KEe4UBCqq3R+oh2jzONXHYvplv6zVMyPhXkyx 65U7r6W2+sAEqdHTHmiD8/ZIns54HMqYxnr5MtAd7Li03qpVMbyFpUaPeldaUAOl5nkB wjNjVcy4AfzZNYzOE2R/dnnQJOldZ3HrHjZkUDSCl+FlbdOeclBxV+Amfwdp1L/YCAA/ t1Og== X-Gm-Message-State: AOJu0Yw3lcNbbsewqeNLFcE4nN58asq3sGkti7U/xbPgXJMdbRqGCq+l V1Xk4o3TkZNyYkHAwT1B4Xs+FbdQiY8x/PHGrLxWd56c2gTRzq1fLbbRq8rX8akgL81sE0J5cMy D4NTO+w== X-Gm-Gg: AfdE7ckdN5nEq1iBR3pcukPUNqpiPywXwoGA9v83sTO96jYVjMegAa0A/EynzDK1JJq C9IHOxy/wejNieR8fRCj2KT3mbmfLgkfGxPeJN++/YcwwJGdCS+cSDCE1s4W4vuB2Z+6PRPZZik TrFlNmrXNZT0u76PS8bCoQSoM45ADvPTRwHQjKq/OktLxMzw7/xSJSQmbWeiDoay9EsMGHmi/Xb VTyjjBWXfkrkUuwjfnH8eJCTqmdP521WGxXbiv/XqcDHAIoMf9EyLBQMrkyBo0k6wgc2hM/NCv4 oj4kehBEJL5do+mGpjysGtKfG0LTOO8m9XjdRWEIFm0FKr9CvScZOim38sjxu4Tk+HNzsb0xWzz YwFFcMB34WmeUTWs2QK2Vf9SmzWnncAtheUfDV7wBEDB6TVhO9UwH0N/sXVQVO23+sLZOOtH/xv TrWiMcm4oiqGp+lSGYlFqAxSFqg4CfZj9fUcA5WQvO8n261uvKlsUWNlq5x0clPg+GaIaCvn0zw +aAorMyTUuph0c= X-Received: by 2002:a05:600c:570f:b0:493:ad1b:b38d with SMTP id 5b1f17b1804b1-493c2ba7db3mr22090225e9.37.1782917140681; Wed, 01 Jul 2026 07:45:40 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 16:45:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v2 0/2] hypercall string inputs To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Juergen Gross , Daniel Smith Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1782917141-3A125220-A9F24B94/0/0 X-purgate-type: clean X-purgate-size: 573 While doing the XSA-492 work I further noticed an inefficiency with safe_copy_string_from_guest(). All callers pass PAGE_SIZE as the maximum buffer size, and with the function adding 1 to append a nul terminator the resulting allocations are all order-1 ones. Which we'd better avoid. Require respective callers of hypercalls to nul-terminate the strings within the buffer supplied. While an ABI change, I think it's an acceptable one. 1: libxc: drop size parameter from xc_flask_context_to_sid() 2: lib: make safe_copy_string_from_guest() validate input Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 01 14:48:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 14:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350065.1607646 (Exim 4.92) (envelope-from ) id 1wewEG-0001VM-7D; Wed, 01 Jul 2026 14:47:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350065.1607646; Wed, 01 Jul 2026 14:47:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewEG-0001VF-3L; Wed, 01 Jul 2026 14:47:56 +0000 Received: by outflank-mailman (input) for mailman id 1350065; Wed, 01 Jul 2026 14:47:54 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewEE-0001V9-M4 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:47:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewEE-004ARY-2x for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:47:54 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a452890-bab6-0a2a0a5309dd-0a2a4507e8e2-14 for ; Wed, 01 Jul 2026 16:47:54 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a452899-9c8e-0a2a45070019-d155802ec593-3 for ; Wed, 01 Jul 2026 16:47:54 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4924593f45dso6460585e9.1 for ; Wed, 01 Jul 2026 07:47:53 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d2bc5sm84365595e9.5.2026.07.01.07.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 07:47:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782917273; x=1783522073; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=5H9FOEbTGuPSoUgzC/ynnLScGlyG4PkeuQTpFvOsYGs=; b=N/UxYgEL+JoCAYj/5G8LUkWxpQSzl9wbLYZQEt6mK8qzc6TvyDtAhkXGE6C94GefQD SYKVfBbXMifkbAhxYMbDqrtRvHCXsNb9Ec2PJZf+shu7pAjxaRYL+zrZfk1xb/aTPGLX XdJqn/+LFndJ45U3ao/QHjKznPZAPeiudrk4yjQUJ4D3JPYOkKP/u9p0awKYVShD0YFC /QXRIfQl0fY5as4i7Sh8ZO/3LzO7lbPJMGEO3tCu3jI+TSj8a5s8Cs31z5Fb7J0HC/M6 BmvZxQ7x+65GCMO0IjVgy/HKPUYhSKHZ5iDktFfNhKKlBfODn3/BED1f4q9KButC/8kV FSQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782917273; x=1783522073; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5H9FOEbTGuPSoUgzC/ynnLScGlyG4PkeuQTpFvOsYGs=; b=eMaTG86YEP6gANfUR75d6ETBIhvTiznsjBCZy66OuZ6YbBPpF19PXvMMHPRSjkag7Z fO3cMSOmdb7Ov2pCEu+IEw1QBUEqAX5bZ1XRZtmut0YQ8hJ8KrpuTUmbqLpQGALEuHU9 4nucRgdCCoj2JNjPWuEi/SQlMkPr1gI52Y8F8ytkKE3kbKXmKdGvGQNV0Migr26DYRG8 HXIPJ8yVINda+/ujK3/7vDt7umN/tDfMfVBr4uwbMPUaoVNnhQf2nrJntfvk9oeUZkQt mF4d/xtkAu2FaS2NpOL2cVCvreyjwigKPZ9yLuhzoragCCmHpl6pV1xcy+TqcfnxNKbd A6EQ== X-Gm-Message-State: AOJu0YycWKNFN1xxGjYv2CpxadBzZTY9OxIHO4cLcUqpsS69hH89nhqF to0cEJJo7Tp5SOwJ0weu/XSQIQGY3NeYVijHl8C+wyEtildFbGp4OSd66jTwhgJ8R1ipbDV6uct kw/Kzqg== X-Gm-Gg: AfdE7cmaKJK9uAux0wiCKUBb663gAOsQVb1amVctd5fJtg3EbbB18rur05eqG1WN3K0 gdcQaH29cnKcQ/N5DdlDKbJPFY9LlPUdHq9EvtJBPXzwxCPMRpf4JX/rHKQSOI1K+AXdjiKutZX pTzg7RJT5yQr9oOLEao72pCpfkbynR06jfQzGBpF9cL5L0SlZc5Dc1XueZi4FebHdF1Ekwr4Y7Y dD7r5Vdilh8Fl6NJT5OC7x9EVNHbw7Tv9S6daSappVOlKQlC6pRyJGQGG9rQ13e9lXiRcny3ril FZVWFTYennKPbVVH9Cbq/+fo0vqmDuhTzwrqyIE4vBr9gqjpUbrhAHgNGeGxACEZYk3UgLbq/V5 rtbqOzYPXx/cVF0YYfGha3dXMGZqwsYe0UUoq5CVI4xs+L/sjmuus9ODLl6DP5Buo5gUohT8eR2 9utbE/sloRHvLoAx/KGnYCdjcuuOqxucFlw0IlGZJDQ1O1UfH2CfDGQCWntFO7ocKetu6zlEAOm 3wv4/o5y46++0A= X-Received: by 2002:a05:600d:644f:10b0:493:bc4a:d5f4 with SMTP id 5b1f17b1804b1-493c2bb226bmr23916745e9.38.1782917273336; Wed, 01 Jul 2026 07:47:53 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 16:47:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/2] libxc: drop size parameter from xc_flask_context_to_sid() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony PERARD , Juergen Gross , Daniel Smith , Marek Marczykowski References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1782917274-7D92225E-99338FD6/0/0 X-purgate-type: clean X-purgate-size: 3695 Nul-terminated strings are passed in all cases, so the strlen() can very well be invoked by the function itself. In preparation for a hypervisor change also include the nul terminator in the size calculation. Signed-off-by: Jan Beulich Acked-by: Marek Marczykowski-Górecki --- Ideally libxl_flask_context_to_sid() would follow suit, but aiui doing so would break its (stable) API. Of course the casts in xc_flask_access() are suspicious. --- v2: Avoid assert() use in libxl. --- a/tools/helpers/init-xenstore-domain.c +++ b/tools/helpers/init-xenstore-domain.c @@ -108,7 +108,7 @@ static int build(xc_interface *xch) if ( flask ) { - rv = xc_flask_context_to_sid(xch, flask, strlen(flask), &config.ssidref); + rv = xc_flask_context_to_sid(xch, flask, &config.ssidref); if ( rv ) { fprintf(stderr, "xc_flask_context_to_sid failed\n"); --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2372,7 +2372,7 @@ long xc_sharing_used_frames(xc_interface /*** End sharing interface ***/ int xc_flask_load(xc_interface *xc_handle, char *buf, uint32_t size); -int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t size, uint32_t *sid); +int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t *sid); int xc_flask_sid_to_context(xc_interface *xc_handle, int sid, char *buf, uint32_t size); int xc_flask_getenforce(xc_interface *xc_handle); int xc_flask_setenforce(xc_interface *xc_handle, int mode); --- a/tools/libs/ctrl/xc_flask.c +++ b/tools/libs/ctrl/xc_flask.c @@ -83,10 +83,11 @@ int xc_flask_load(xc_interface *xch, cha return err; } -int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t size, uint32_t *sid) +int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t *sid) { int err; struct xen_flask_op op = {}; + size_t size = strlen(buf) + 1; DECLARE_HYPERCALL_BOUNCE(buf, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); if ( xc_hypercall_bounce_pre(xch, buf) ) @@ -249,7 +250,7 @@ static int xc_flask_add(xc_interface *xc int err; struct xen_flask_op op = {}; - err = xc_flask_context_to_sid(xch, scontext, strlen(scontext), &sid); + err = xc_flask_context_to_sid(xch, scontext, &sid); if ( err ) return err; @@ -325,10 +326,10 @@ int xc_flask_access(xc_interface *xch, c struct xen_flask_op op = {}; int err; - err = xc_flask_context_to_sid(xch, (char*)scon, strlen(scon), &op.u.access.ssid); + err = xc_flask_context_to_sid(xch, (char*)scon, &op.u.access.ssid); if ( err ) return err; - err = xc_flask_context_to_sid(xch, (char*)tcon, strlen(tcon), &op.u.access.tsid); + err = xc_flask_context_to_sid(xch, (char*)tcon, &op.u.access.tsid); if ( err ) return err; --- a/tools/libs/light/libxl_flask.c +++ b/tools/libs/light/libxl_flask.c @@ -21,7 +21,10 @@ int libxl_flask_context_to_sid(libxl_ctx { int rc; - rc = xc_flask_context_to_sid(ctx->xch, buf, len, ssidref); + if (len != strlen(buf)) + return ERROR_INVAL; + + rc = xc_flask_context_to_sid(ctx->xch, buf, ssidref); return rc; } --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -1754,7 +1754,7 @@ static PyObject *pyflask_context_to_sid( return PyErr_SetFromErrno(xc_error_obj); } - ret = xc_flask_context_to_sid(xc_handle, ctx, strlen(ctx), &sid); + ret = xc_flask_context_to_sid(xc_handle, ctx, &sid); xc_interface_close(xc_handle); From xen-devel-bounces@lists.xenproject.org Wed Jul 01 14:48:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 14:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350073.1607654 (Exim 4.92) (envelope-from ) id 1wewEv-000261-E7; Wed, 01 Jul 2026 14:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350073.1607654; Wed, 01 Jul 2026 14:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewEv-00025t-BA; Wed, 01 Jul 2026 14:48:37 +0000 Received: by outflank-mailman (input) for mailman id 1350073; Wed, 01 Jul 2026 14:48:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewEu-000251-G3 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:48:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewEt-003lr9-Og for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:48:35 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4528aa-bab6-0a2a0a5309dd-0a2a450ae036-36 for ; Wed, 01 Jul 2026 16:48:35 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4528c3-e40e-0a2a450a0019-d1558035c921-3 for ; Wed, 01 Jul 2026 16:48:35 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493b966dd74so3200155e9.3 for ; Wed, 01 Jul 2026 07:48:35 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4f76a7sm79269095e9.13.2026.07.01.07.48.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 07:48:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782917315; x=1783522115; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=f6RRyZm2oHP9FW10uig6BZI7qLTDrMsOg0vt+/wGgiA=; b=TonPrCXw+myyYio+xjGg4zuxR0Fa4fllVBXiP/GdtgxNLxmniwcde/HvHwUCuEBtai bj6AzYTWB3ZqBW6s41qbTgqeSRlSD3lF/Kggp9zukWvJ8AnZN7rs9434V9mUkGMaa9hI 76ETSf0P05K6EZGhkkj/tfxb5vT0nVVynNi8wvza1HGypIX7uOcwZqfPXEgK8b9r9Hnp 9ukJWV43yqT71qRK4szNNn181QCg1zuVtAEtItT+sonGFsEvKwGX748OjUF6JNeU8eRt ElkL/cbUcgkQw0uVAcQPUXMO7ihKszfkO1i9gGhNiSf897uISgFR2bfVwb3mJlyWcjZR 7rgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782917315; x=1783522115; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f6RRyZm2oHP9FW10uig6BZI7qLTDrMsOg0vt+/wGgiA=; b=OYPJ6Ld0ejdAYiBBTleb//xsn+VLCWQsv1Q7H8AVznV1pJ0/sGeLTdCFJtgKLC9DFU L2LnBrU5jkAAkUo55HKwdKjfdoD0lMhjQgIu7qZn3liCIMrRNTUF4dLf0h+lATkSMFxL 44zKTkzQFJ7kzCEPrBYwDLATV2lGBAkVuP4ZC2uVh0zAtu7PI4HKCQgQG5zDcEgxBoR9 yLChhQkV1UYwOYb2mYJc8wXBOwPISKR4PHvmgnBdFi2HcGfWU61Npf1ZJhwNtl5ZB1I2 vSPk4wrLCFtvvGOnoBliQqHhyumAQbhKgyCGziRy2Po17vHhtoMSmydpA4ZwFNi++p/V hDmg== X-Gm-Message-State: AOJu0YwyR/rswohA06LUfZyYA83QJDBYSvy+ZLhuioKMpi6FWC2NSPSW FaerZNWsciWfs1YAzRJX2ml3V5z0i6vxyDXpKFJSuTxS3F0ce/3MjUReQhnAAGFtE426/FI/4Hq JxXgYiA== X-Gm-Gg: AfdE7cn46AZwmehu0s88Inn1DXdATYibQSlxQ7gDS4wpidji/nsDA9/v/qrvktm29PT bWQqTw9ue2grTxBYznvI7cD9A78noySMSuWYO8oSySs4snCrQQQu+apMjE7bJ++U7s6bmAuFaKa bkhIBlXKp5g4D8PbHCFFQg7MRknGmRoE+w0PCvw7t5xTPK1q+QRDGF+S49QmpYLdSgaWzb8hoOi zPq/pOyE10l66A7g9MEZylWT5ulhq1qEMyUwCD1r69FFTeYQ8/gvHn1ZIP7p9pq4E9KVuHhlSSa ym0RJJBirfO9oDplrupkrWvQGaQzV3sGHOHdcSmEAlecwq46hPyfN9npIINztaJ4+nJ4Ji9kXky /tqUQmSE/WFsF8aOiofDdpTSkSe6tH8rmU1LBzOhFI8iMbToqXcVIwZD6Sjf3T+6daKanQTq1Ip in556SKesIuwJcR85wYPETj9gR4Pcu/AN+DpXIlWCL2vy0kyXqB3KYkBMuemz2XNoKz2y9fB1b3 e2XvJ1RRg2DDHE= X-Received: by 2002:a05:600c:8590:b0:492:6487:a87 with SMTP id 5b1f17b1804b1-493c2ba1f4dmr25417315e9.32.1782917315064; Wed, 01 Jul 2026 07:48:35 -0700 (PDT) Message-ID: <80bc4e83-b767-4692-9ce1-0ebf68d7ab26@suse.com> Date: Wed, 1 Jul 2026 16:48:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/2] lib: make safe_copy_string_from_guest() validate input From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Daniel Smith , Oleksii Kurochko References: Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1782917315-D492DDDE-00F26FA8/0/0 X-purgate-type: clean X-purgate-size: 3769 ... rather than papering over guest flaws: Strings passed ought to be nul- terminated (yet sadly libxc hasn't been doing so thus far). This way we also avoid order-1 allocations, seeing that all present callers pass PAGE_SIZE for max_size. Signed-off-by: Jan Beulich --- I can't spot any caller side use of FLASK_DEVICETREE_LABEL, hence there's no corresponding prereq patch. --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ The format is based on [Keep a Changelog ## [4.23.0 UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD ### Changed + - XEN_DOMCTL_DEV_DT's, FLASK_[GS]ETBOOL's, and FLASK_DEVICETREE_LABEL's input + string sizes need to include the nul terminator. ### Added --- a/xen/lib/guest-strcpy.c +++ b/xen/lib/guest-strcpy.c @@ -3,8 +3,8 @@ #include /* - * The function copies a string from the guest and adds a NUL to - * make sure the string is correctly terminated. + * The function copies a string from the guest and checks there's a NUL + * terminating the string. */ char *safe_copy_string_from_guest(XEN_GUEST_HANDLE(char) u_buf, size_t size, size_t max_size) @@ -14,8 +14,7 @@ char *safe_copy_string_from_guest(XEN_GU if ( size > max_size ) return ERR_PTR(-ENOBUFS); - /* Add an extra +1 to append \0 */ - tmp = xmalloc_array(char, size + 1); + tmp = xmalloc_array(char, size); if ( !tmp ) return ERR_PTR(-ENOMEM); @@ -24,7 +23,12 @@ char *safe_copy_string_from_guest(XEN_GU xfree(tmp); return ERR_PTR(-EFAULT); } - tmp[size] = '\0'; + + if ( !memchr(tmp, 0, size) ) + { + xfree(tmp); + return ERR_PTR(-EMSGSIZE); + } return tmp; } --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -574,7 +574,7 @@ struct xen_domctl_assign_device { uint32_t machine_sbdf; /* machine PCI ID of assigned device */ } pci; struct { - uint32_t size; /* Length of the path */ + uint32_t size; /* Length of the path, including nul terminator */ XEN_GUEST_HANDLE_64(char) path; /* Path to the device tree node */ #ifdef __XEN__ struct dt_device_node *dev; /* Resolved device node of the above */ --- a/xen/include/public/xsm/flask_op.h +++ b/xen/include/public/xsm/flask_op.h @@ -26,7 +26,8 @@ typedef struct xen_flask_setenforce xen_ struct xen_flask_sid_context { /* IN/OUT: sid to convert to/from string */ uint32_t sid; - /* IN: size of the context buffer + /* + * IN: size of the context buffer, including nul terminator * OUT: actual size of the output context string */ uint32_t size; @@ -86,8 +87,11 @@ struct xen_flask_boolean { uint8_t new_value; /* IN: commit new value instead of only setting pending [SET] */ uint8_t commit; - /* IN: size of boolean name buffer [GET/SET] - * OUT: actual size of name [GET only] */ + /* + * IN: size of boolean name buffer [GET/SET]; must cover nul terminator + * if "name" (below) is an input + * OUT: actual size of name [GET only] + */ uint32_t size; /* IN: if bool_id is -1, used to find boolean [GET/SET] * OUT: textual name of boolean [GET only] @@ -150,7 +154,7 @@ typedef struct xen_flask_relabel xen_fla struct xen_flask_devicetree_label { /* IN */ uint32_t sid; - uint32_t length; + uint32_t length; /* length of the path, including nul terminator */ XEN_GUEST_HANDLE(char) path; }; typedef struct xen_flask_devicetree_label xen_flask_devicetree_label_t; From xen-devel-bounces@lists.xenproject.org Wed Jul 01 14:50:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 14:50:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350082.1607663 (Exim 4.92) (envelope-from ) id 1wewGE-0002ee-N8; Wed, 01 Jul 2026 14:49:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350082.1607663; Wed, 01 Jul 2026 14:49:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewGE-0002eX-KD; Wed, 01 Jul 2026 14:49:58 +0000 Received: by outflank-mailman (input) for mailman id 1350082; Wed, 01 Jul 2026 14:49:57 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wewGD-0002eM-DO for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:49:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewGC-00BKFF-QW for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:49:56 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a452907-2eae-0a2a0a5409dd-0a2a450ce92a-28 for ; Wed, 01 Jul 2026 16:49:56 +0200 Received: from [209.85.221.52] (helo=mail-wr1-f52.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a452914-f399-0a2a450c0019-d155dd34ed8a-3 for ; Wed, 01 Jul 2026 16:49:56 +0200 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47231f1f8f3so939119f8f.1 for ; Wed, 01 Jul 2026 07:49:56 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4a09sm369712f8f.13.2026.07.01.07.49.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 07:49:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782917396; x=1783522196; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BhomrUxY6p8P6yVy0jlqXNfKQuZ1YGtwLW+fYV1vUCM=; b=OTt87HKBGdi413QIBNhjj1PSweJ3BO2mOFNoJVzUKW8dag58W17dEtKqsT9o4FnXh+ f87n5tktzFlTl+eEcKuvyXvcF/Es0A7xnqi85eNRqEaUfSNDazu4vMoezudsbd5uu1Cz g9vY7kyHON46XmlCHbcK2cmmeX8PBQGGCgR9qgTT7WTTI9Ko2rxsPW7aujkg5QvrFF3f 9oZX+srKf3I+pGXeIncTp3vNioK4fEm5BC7Ad+YgV3E19KwVD/POY/RcAGySoIi09Qae jjSO9IPyXfB3jYXhmWhM6nihPCvnP3/1++MNi+oLs2XwcqpPi2NodEPLJKcuiNLarf2a 9e9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782917396; x=1783522196; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BhomrUxY6p8P6yVy0jlqXNfKQuZ1YGtwLW+fYV1vUCM=; b=VoK4Qs1S5RjkgBMRzDbPYmGPjJUkb5lJcGs2XUIw2QrdJd72yPsZszioiMUiBd01/J 4beevRNrq20B/6daDC8yX61N3j26EeLUiXOrbwRxayDfcgwSIkiApvkqG2/tgRj6rblG VvOw/8Vkaxti4YAhWFPHY8wLf6J9eH9xMm+M38zuAEWGQKNZHqyO1TEkTyGHlKHoRjvw QZFgAHIGVwMzaZuure25KwvxhTfeP7+C9vOwQ7Jm0v2OvIXmGhuSZanWIrwM7Ftxdmdw qIRFA1zj/clVo1ykBS6hPxN3Refw1gwT+ewk3yZZkZV3fZbY/2mreIGWPIkX2738QAC2 mPUw== X-Forwarded-Encrypted: i=1; AHgh+RrwOYRAAqUNd7vzghMj08q9QFNt/QD2AUr6tyjXfj8cqNBLcqfXtE79jQ8x8iGAHHDNpC2a7tKK8E0=@lists.xenproject.org X-Gm-Message-State: AOJu0YwaVSe0K1QZacKlT5vioNwz3dtbMimKqoI6HHxDI7T6pYs7dRov e3ticokTeZgWqVcj0masZaxu8kV/TiLkuzyGBdVv+Vy+Kb6TDHQPdF5X X-Gm-Gg: AfdE7cl/pwvk6M9HHiDjKqFMlAoaPXJHsAOCmQ3f6x47KdgS4ATjRSi6JtVywTSL3QO cn405PlpPlAJbxQF162SEF8RAvD0UkoKNzwtPNaW7zNT8kvaAHFpllNOAcR0KurLGhgdb29/nRG A4cjAh/nMPtIDRQ1g/4JCjFJ7o3sUqGlWJTPXXC15U0BwSka0a2ZPlok+c0eAz2eZJ8tjr37GqM ijcu4W8Fe4vhyJEAqUB8MuxDuckmGpNUQzwO7ZiSRALwA7ci0+7c7/+bVI1cXyOABF1s8FuJ1VC h5SmAspOcwqfuNH6eo9Q1lAJkcWy3Utkp5jizNu4D35qms83algAUNggA5qoQwCbQ3WD6D0dNj9 B7UE6d/Dnatf1v+1ysiCIWvskQO39Svhc3kmX7o6xu/F7vH+P6D8+carx0b1GV5rITx7TlO/2BY HkrnzOMbhLC09QKHDY4C/OEkzEy5t02ZDZBO9pxyQqfZfwcPH4ICBuDLiac6e2+2WOKO0= X-Received: by 2002:a05:6000:4a09:b0:46f:3046:2bf1 with SMTP id ffacd0b85a97d-477b3982ce5mr1395687f8f.13.1782917395894; Wed, 01 Jul 2026 07:49:55 -0700 (PDT) Message-ID: <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> Date: Wed, 1 Jul 2026 16:49:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/25] xen/riscv: implement IRQ routing for device passthrough To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <472a77604d35a0bc2a75b71f250fd67b63afde4c.1782487661.git.oleksii.kurochko@gmail.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1782917396-0D329D51-F8B1046D/10/73395122804 X-purgate-type: spam X-purgate-size: 10845 On 6/29/26 5:55 PM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> dom0less device passthrough requires granting guest domains access to >> device interrupts. Introduce map_device_irqs_to_domain() to enumerate >> a DT node's interrupt properties, skipping those not owned by >> the primary interrupt controller (as at the moment I haven't seen usages >> of it), and map_irq_to_domain() to grant domain access and configure >> Xen's interrupt descriptor accordingly. Sharing IRQ between domains is >> rejected. >> >> Both map_irq_to_domain() and map_device_irqs_to_domain() are marked >> __overlay_init, mirroring Arm: without CONFIG_OVERLAY_DTB this expands to >> __init, so the functions are init-only and need no XSM check; with >> CONFIG_OVERLAY_DTB they become runtime-callable, but the only runtime >> entry point is dt_overlay_domctl(), which performs the XSM checks at the >> domctl layer. RISC-V does not wire up DT overlay yet, so today these are >> strictly __init; if/when overlay support is added, the domctl-level XSM >> gating must be added together with it, as on Arm. >> >> route_irq_to_guest() and release_irq() manage irq_desc ownership for >> guest-assigned interrupts. Each assignment carries a small irq_guest >> structure as irqaction::dev_id, recording the owning domain and virtual >> IRQ number which is 1:1 mapped to physical IRQ number. A per-domain >> vIRQ allocation bitmap (used_irqs in struct vintc), managed by >> vintc_reserve_virq(), prevents the same vIRQ being claimed twice. >> >> Host and guest interrupts may differ in some operations (EOI timing in >> particular, possibly others): a host IRQ is completed once Xen's handler >> runs, whereas a passthrough IRQ must defer the physical completion until >> the guest issues its own EOI, otherwise a still-asserted level line would >> immediately retrigger and storm. This affects only the .end callback; >> the rest of hw_interrupt_type is shared, hence the separate host and >> guest hw_interrupt_type instances. >> >> With APLIC+IMSIC, guest interrupts are delivered directly by hardware >> through the IMSIC, bypassing do_IRQ(). The _IRQ_GUEST branch in >> do_IRQ() is therefore left as BUG() until a platform without direct >> IMSIC delivery is encountered. > > And this is secure, i.e. one guest (by mishandling things, e.g. simply > never claiming / servicing an interrupt) cannot affect another guest? It will be just affect this specific interrupt which isn't claimed/serviced. > >> +int __overlay_init map_device_irqs_to_domain(struct domain *d, >> + struct dt_device_node *dev, >> + bool need_mapping, >> + struct rangeset *irq_ranges) >> +{ >> + unsigned int i, nirq = dt_number_of_irq(dev); >> + >> + if ( irq_ranges ) >> + return -EOPNOTSUPP; >> + >> + /* Give permission and map IRQs */ >> + for ( i = 0; i < nirq; i++ ) >> + { >> + int res, irq; >> + struct dt_raw_irq rirq; >> + >> + res = dt_device_get_raw_irq(dev, i, &rirq); >> + if ( res ) >> + { >> + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", >> + i, dt_node_full_name(dev)); >> + return res; >> + } >> + >> + /* >> + * Don't map IRQs that have no physical meaning >> + * ie: IRQs whose controller is not APLIC/IMSIC/PLIC. >> + */ >> + if ( rirq.controller != dt_interrupt_controller ) >> + { >> + dt_dprintk("irq %u not connected to primary controller." >> + "Connected to %s\n", i, > > Nit: By splitting a format string like this, you pretty effectively hide > that there's a blank missing after the full stop. > > Further after an already wrapped function argument there shouldn't follow > another one, to maintain visual clarity. I would be okay to have a format string a little bit long. I would change that line to (if you are okay with that): ...("irq %u not connected to primary controller. Connected to %s\n", i, dt_node_full_name(rirq.controller)); > >> @@ -101,12 +119,28 @@ int domain_vintc_init(struct domain *d) >> break; >> } >> >> + if ( !ret ) >> + { >> + d->arch.vintc->used_irqs = >> + xvzalloc_array(unsigned long, BITS_TO_LONGS(d->arch.vintc->nr_virqs)); > > Nit: Overlong line. > I will reformat that in the following way: d->arch.vintc->used_irqs = xvzalloc_array(unsigned long, BITS_TO_LONGS(d->arch.vintc->nr_virqs)); >> + if ( !d->arch.vintc->used_irqs ) >> + ret = -ENOMEM; >> + } >> + >> return ret; >> } >> >> void domain_vintc_deinit(struct domain *d) >> { >> const enum intc_variant variant = intc_hw_ops->info->hw_variant; >> + unsigned int virq; >> + >> + if ( !d->arch.vintc ) >> + return; > > Seeing this and ... > >> + for ( virq = 0; virq < d->arch.vintc->nr_virqs; virq++ ) >> + if ( test_bit(virq, d->arch.vintc->used_irqs) ) >> + release_guest_irq(d, virq); >> >> switch ( variant ) >> { >> @@ -117,4 +151,14 @@ void domain_vintc_deinit(struct domain *d) >> default: >> break; >> } >> + >> + XVFREE(d->arch.vintc->used_irqs); > > ... this, ... > >> +} > > ... where is d->arch.vintc being freed? That would logically look to > belong into this function. Right, it is an issue: d->arch.vintc is being NULLed inside domain_vaplic_deinit(), which are called from domain_vintc_deinit(), so XVFREE(d->arch.vintc->used_irqs) must be moved to just after the for() loop (before the switch). As for d->arch.vintc itself, it should only be NULLed and not freed, since it is a pointer to &vaplic->vintc which is embedded in the vaplic struct and not separately allocated. > >> --- a/xen/arch/riscv/irq.c >> +++ b/xen/arch/riscv/irq.c >> @@ -12,11 +12,20 @@ >> #include >> #include >> #include >> +#include >> #include >> +#include >> >> #include >> #include >> >> +/* Describe an IRQ assigned to a guest */ >> +struct irq_guest >> +{ >> + struct domain *d; >> + unsigned int virq; >> +}; >> + >> static irq_desc_t irq_desc[NR_IRQS]; >> >> static bool irq_validate_new_type(unsigned int curr, unsigned int new) >> @@ -192,6 +201,15 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq) >> if ( desc->handler->ack ) >> desc->handler->ack(desc); >> >> + if ( desc->status & IRQ_GUEST ) >> + /* >> + * As at the moment APLIC + IMSIC is used for guest interrupts will >> + * be directly passed to guest. But if/when IMSIC won't be available >> + * all interrupts will go through Xenand here an irq injection >> + * will be necessary to do. >> + */ >> + panic("unimplemented"); > > The first comment sentence doesn't parse for me. In the 2nd there's a blank > missing between "Xen" and "and". I will rephrase it for clarity: /* * With APLIC + IMSIC, guest interrupts bypass Xen and are delivered * directly to the guest. Without IMSIC, interrupts would be trapped * by Xen and would need injecting into the guest here. */ It looks more clearer to me. > >> @@ -221,3 +239,215 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq) >> spin_unlock(&desc->lock); >> irq_exit(); >> } >> + >> +static inline struct irq_guest *irq_get_guest_info(struct irq_desc *desc) >> +{ >> + ASSERT(spin_is_locked(&desc->lock)); >> + ASSERT(test_bit(_IRQ_GUEST, &desc->status)); >> + ASSERT(desc->action != NULL); >> + >> + return desc->action->dev_id; >> +} >> + >> +static inline struct domain *irq_get_domain(struct irq_desc *desc) >> +{ >> + return irq_get_guest_info(desc)->d; >> +} > > Does this really need a separate helper? (You effectively open-code it > anyway in release_guest_irq().) Considering that I used irq_get_domain() once at all (even in downstream) I will drop that. > > For both functions: "inline" generally wants limiting to header files. Regarding inline I think that I don't understand, it isn't in the header file as irq_get_guest_info() is used only in this file. Do I understand you correctly and it is needed just to drop "inline" for irq_get_guest_info()? > >> +int release_guest_irq(struct domain *d, unsigned int virq) >> +{ >> + struct irq_desc *desc = irq_to_desc(virq); >> + struct irq_guest *info; >> + unsigned long flags; >> + >> + spin_lock_irqsave(&desc->lock, flags); >> + >> + if ( !test_bit(_IRQ_GUEST, &desc->status) ) >> + goto unlock_err; >> + >> + info = irq_get_guest_info(desc); >> + if ( d != info->d ) >> + goto unlock_err; >> + >> + /* >> + * Live IRQ unrouting from a running domain is not supported: the tear-down >> + * drops desc->lock across release_irq()/xvfree() and relies on no >> + * concurrent route_irq_to_guest() being issued for this domain. Only permit >> + * it for a dying domain, where assignment is frozen and no new routes can >> + * appear. >> + */ >> + if ( !d->is_dying ) >> + { >> + spin_unlock_irqrestore(&desc->lock, flags); >> + return -EBUSY; >> + } > > Yet route_irq_to_guest() looks to happily act on dying guests. IOW assignment > doesn't look to be frozen, despite the comment saying so. Right, it is needed to add: if ( d->is_dying ) return -EINVAL; at the top of route_irq_to_guest(). > >> + /* >> + * Clear _IRQ_GUEST while still holding the lock so that a concurrent >> + * release_guest_irq() for the same IRQ observes it and bails out, rather >> + * than capturing the same 'info' and double-freeing it below. >> + */ >> + clear_bit(_IRQ_GUEST, &desc->status); > > You use __set_bit() / __clear_bit() elsewhere - why not here? As it is under spinlock it could __clear_bit here. > >> + spin_unlock_irqrestore(&desc->lock, flags); >> + >> + release_irq(desc->irq, info); >> + xvfree(info); > > If, in release_irq(), action isn't freed, it's ->dev_id field will now have > a dangling pointer. (I think I did point this out before.) It should freed in release_irq() as route_irq_to_guest() always set action->free_on_release = true; Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 14:59:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 14:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350095.1607671 (Exim 4.92) (envelope-from ) id 1wewP0-0004pt-Kh; Wed, 01 Jul 2026 14:59:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350095.1607671; Wed, 01 Jul 2026 14:59:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewP0-0004pm-HU; Wed, 01 Jul 2026 14:59:02 +0000 Received: by outflank-mailman (input) for mailman id 1350095; Wed, 01 Jul 2026 14:59:01 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewOy-0004p4-Mb for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 14:59:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewOx-009Bxm-I3 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:58:59 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a452b2d-e002-0a2a0a5209dd-0a2a450a99f4-2 for ; Wed, 01 Jul 2026 16:58:58 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a452b31-e40e-0a2a450a0019-d561b338a1fe-3 for ; Wed, 01 Jul 2026 16:58:58 +0200 Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine2.igalia.com with esmtps (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wewOT-007byj-B1; Wed, 01 Jul 2026 16:58:29 +0200 Received: from webmail.service.igalia.com ([192.168.21.45]) by mail.igalia.com with esmtp (Exim) id 1wewOQ-00841m-SR; Wed, 01 Jul 2026 16:58:29 +0200 Received: from localhost ([127.0.0.1] helo=webmail.igalia.com) by webmail.service.igalia.com with esmtp (Exim 4.98.2) (envelope-from ) id 1wewOQ-0000000DnWw-2mEJ; Wed, 01 Jul 2026 16:58:26 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Content-Transfer-Encoding:Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date:MIME-Version" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BZbTYczaqR+mc0JSoafl6QcdAzR5SvJPdrKk020zPEg=; b=PVy1HSQLMkQpFi7ZTp853RG96b F2mF12VBmD1hT/zcrqto++UkCFfRWhhxRJ8mlk5lnCU1HMZ9w9MSTXUCDJJxTL464QIi5fLKqe53P hQWAUxmAxLJKfvrZoGTRDyyvP0Rz5BFSu1uRa4rGqFFLGyMdIYEk7QE359FXCSzpWrixldz1LYPsG Y6ug4IkBhv1nKfxHNt62cYIL3DC+ySS+M8Sq49/nhmGYCeVMGwLqvXJO9VzNJxjdKVEV9fSEu+CMe VFT9FcR4vkE9tQI3/rsi9C/rCdhcT6wDhaKgo+P6UC5pznSJ6pe1cata4EyIIgqE+hM58kzVi9uOw PC7GOjjQ==; MIME-Version: 1.0 Date: Wed, 01 Jul 2026 11:58:26 -0300 From: Mauricio Faria de Oliveira To: Peter Zijlstra , Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp In-Reply-To: <20260701070531.GK48970@noisy.programming.kicks-ass.net> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701070531.GK48970@noisy.programming.kicks-ass.net> Message-ID: X-Sender: mfo@igalia.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Report: NO, Score=-2.2, Tests=ALL_TRUSTED=-3,BAYES_50=0.8,URIBL_BLOCKED=0.001 X-Spam-Score: -21 X-Spam-Bar: -- X-purgate-ID: tlsNG-4011c0/1782917938-D5129DDE-38EB2725/0/0 X-purgate-type: clean X-purgate-size: 3568 On 2026-07-01 04:05, Peter Zijlstra wrote: > On Tue, Jun 30, 2026 at 02:21:46PM -0300, Mauricio Faria de Oliveira wrote: >> Move the inline memcmp function currently only available in 'boot/string.c' >> into the shared string function header to be reused. >> >> This is not done through to avoid pulling unnecessary code >> in 'boot/string.c' that causes build errors in 'boot/compressed/string.c' >> and 'purgatory/purgatory.ro'. >> >> Note that the inline memcmp() returns 0/1, not -1/0/1 as regular memcmp() >> (reported by David Laight ). >> >> Signed-off-by: Mauricio Faria de Oliveira >> --- >> arch/x86/boot/string.c | 6 ++---- >> arch/x86/include/asm/shared/string.h | 16 ++++++++++++++++ >> arch/x86/include/asm/string.h | 1 + >> 3 files changed, 19 insertions(+), 4 deletions(-) >> >> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c >> index ac0f900ebc47efa81c92e1bb2010ea41677899c4..be454a6864225f3a972c3e81826b77ed4e8a57fe 100644 >> --- a/arch/x86/boot/string.c >> +++ b/arch/x86/boot/string.c >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include >> #include "ctype.h" >> #include "string.h" >> >> @@ -31,10 +32,7 @@ >> >> int memcmp(const void *s1, const void *s2, size_t len) >> { >> - bool diff; >> - asm("repe cmpsb" >> - : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); >> - return diff; >> + return __inline_memcmp(s1, s2, len); >> } >> >> /* >> diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h >> new file mode 100644 >> index 0000000000000000000000000000000000000000..422952152f533ad75b98f3873297b39c4f5e2477 >> --- /dev/null >> +++ b/arch/x86/include/asm/shared/string.h >> @@ -0,0 +1,16 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef _ASM_X86_SHARED_STRING_H >> +#define _ASM_X86_SHARED_STRING_H >> + >> +/* Note: this memcmp() returns 0/1, not -1/0/1 as regular memcmp(). */ >> +static __always_inline int __inline_memcmp(const void *s1, const void *s2, size_t len) >> +{ >> + bool diff; >> + >> + asm("repe cmpsb" >> + : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); >> + >> + return diff; >> +} >> + >> +#endif /* _ASM_X86_SHARED_STRING_H */ >> diff --git a/arch/x86/include/asm/string.h b/arch/x86/include/asm/string.h >> index 9cb5aae7fba9ffcf0f5af8f939d30467750ccaa9..f0f4fd8227bf992e78c69209efb31f0a9a0cc3b1 100644 >> --- a/arch/x86/include/asm/string.h >> +++ b/arch/x86/include/asm/string.h >> @@ -7,6 +7,7 @@ >> #else >> # include >> #endif >> +#include >> >> static __always_inline void *__inline_memcpy(void *to, const void *from, size_t len) >> { > > It seems weird to have __inline_mem{cpy,set}() in a different header than > __inline_memcmp(). I'm assuming this is because boot cannot include the > normal string thing? > > Perhaps make inline_string.h or somesuch to carry all three of them and > include that from the relevant places? Thanks for looking into this. Yes, your question and suggestion above are essentially patch 1 in v4 [1]. Borislav Petkov requested a clean header in arch/x86/include/asm/shared/ for this (without other code), which is patch 1 in v5. cheers, [1] https://lore.kernel.org/all/20260526-pvh-kasan-inline-v4-1-a310e6a25ecd@igalia.com/ -- Mauricio From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:21:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:21:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350117.1607691 (Exim 4.92) (envelope-from ) id 1wewkh-0001rd-IT; Wed, 01 Jul 2026 15:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350117.1607691; Wed, 01 Jul 2026 15:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewkh-0001rV-EA; Wed, 01 Jul 2026 15:21:27 +0000 Received: by outflank-mailman (input) for mailman id 1350117; Wed, 01 Jul 2026 15:21:26 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewkf-0001qs-Ub for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:21:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewkf-004tW0-BG for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 17:21:25 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a45305d-e002-0a2a0a5209dd-0a2a4501cb5a-44 for ; Wed, 01 Jul 2026 17:21:25 +0200 Received: from [209.85.218.54] (helo=mail-ej1-f54.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a453075-400f-0a2a45010019-d155da36ed42-3 for ; Wed, 01 Jul 2026 17:21:25 +0200 Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c12758e75afso140455166b.1 for ; Wed, 01 Jul 2026 08:21:25 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288d1efdcsm294023766b.5.2026.07.01.08.21.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 08:21:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782919285; x=1783524085; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Fvkn+Q1lRbCuR/PD1NZRPzvfxPN8W8yFaRbTgCBwedA=; b=AiWsQUcgfVn2bDKtej22qhwCRaz3ToSmlzLRfkHX/MUisZIYCxiC8/S+ao1KY4v8y1 VmulbuJeGN/EzxFU3YHCZupNTs0u055T2rNrJ3rWe9TEUtOpiU4sifcNx53S8aEQAuh0 fi619ohfWD+v2a1IknOjmABBpzNjHTP+jzLRzGGnB4JVx98ZxECpBT3nJZB+0se+e0A4 SI8dvYk2g3SN0SJGh+aHkfyBULHYpw4/lp9Jw11ETv9ZwKbwhTmam0XYVCObusoTpV1b 404j0WEDwIvDnut9plmvrGTbSq4lmyfLK6GxJ/nZdY+fPfV9t26wZ4M3T+Cd9A/zg+sm QLZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782919285; x=1783524085; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Fvkn+Q1lRbCuR/PD1NZRPzvfxPN8W8yFaRbTgCBwedA=; b=ix27ZO7y9pu1VQTFGRjdk8CMOvzYHQCTbkNuv2NiKbpbZywdT1T1//OzAFHFvvO1oR rvjicK6JTYTol7mL4APMjI8wmysmJ0tKOsZMGYn2C3m9qlXQMg2MeKLI8k/d1163jvjA tFM3QDfBH5hg3drMcwKildpu6v2BBmEiFx4Ie9mt0NfhyP/WNs/49ELmQaPDmTQ5e38F Qa+bwqMTvHvmIU6BEAG+GTGIl4b30wPrVgdRniH5j3sQlMqTvDQ4DtL6XDRG/X8DdrzX ElTQFLBaj5vYafp9jpX3wmDPQJ/z+TxpXIAZWsyz2yO/H6sWMYGWTXeMj6SQAdwjwVhb NmfA== X-Forwarded-Encrypted: i=1; AHgh+Rp0nmGOsYuidb/GCYODHkLO6G1gGM9K3NoqYWd9RmyXnv40qWZGIHABA8L0EF7iV76nQXLVIiJ7uzA=@lists.xenproject.org X-Gm-Message-State: AOJu0YyJMZdn5Den8WVuOS9lkFQZ+unjFjw5we7M+x098IFWEyMLvkVP 1EW5tmiVmGRzABVcRpnXF+EZEwvEz1AIICVkC5jciXcu5hXPt+Yq8IdJugBFzACDOTQ= X-Gm-Gg: AfdE7clXH6gU9TqW0389qTHklCsLXXs4XgBw9kRO+me2PRnH1cw7fMk4fm9DXwD7LA0 3R9qU0t9ereSLN8JiBwsgC7Y+JIxAZmFzoaTWc8oheCzVUChRs1RiE6fFhHi+zflRV6Oj1E0rDD 7iqzq7jppGEDbVJX99eybRqn6Zxp/2HzhlHdO+vP5nNY5EF768BL1o+rXUzwwMv48LaGhHGu6bF ctJnCP860IrfVF1El3E4lMJZ/KBPhXpjjsIHZ0WaP0JX723CzYMTzZhjq7bDL6URUuPcxrf1utN eFxYSpOl1OJGloXrZFU2FS93zd8ePsWgpYznBCSPZjww7PPQOic+taKr9RwNq9uQNYfgY/gJjaP LhnpYGYIocCaDzD9/+qGT/cyOC8IXi18feUzspEw2vqEC8RDhQThTBjOJpiNWYF4wpRcwlN69yP x/rrYw0SRirGoqSGsJi9P+iQMdAtd0RcsmtQvIjB0bUCv/N9WsWJInhAgkrbowd5Jr75/OkYXMw R4GddClmPds1jBXbtvHr9QVrQrRNPi+yWRXd9Kzh4g= X-Received: by 2002:a17:907:da02:b0:c12:840a:364 with SMTP id a640c23a62f3a-c12ae3acd8fmr66792866b.10.1782919284620; Wed, 01 Jul 2026 08:21:24 -0700 (PDT) Message-ID: <305e0bea-cea8-4260-be84-4e844979987f@suse.com> Date: Wed, 1 Jul 2026 17:21:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/Xen: correct commentary and parameter naming of xen_exchange_memory() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky References: Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------nQgv1Bqlnnr0TaSVOpwNNn6l" X-purgate-ID: tlsNG-d62444/1782919285-FFECF1E0-E8AEA266/0/0 X-purgate-type: clean X-purgate-size: 9492 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------nQgv1Bqlnnr0TaSVOpwNNn6l Content-Type: multipart/mixed; boundary="------------gwj4yeI9S5JHpZF7F4xM6WWE"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky Message-ID: <305e0bea-cea8-4260-be84-4e844979987f@suse.com> Subject: Re: [PATCH] x86/Xen: correct commentary and parameter naming of xen_exchange_memory() References: In-Reply-To: Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------gwj4yeI9S5JHpZF7F4xM6WWE Content-Type: multipart/mixed; boundary="------------sHJZ0Ia0uoWyY5r3zY0h0Gg6" --------------sHJZ0Ia0uoWyY5r3zY0h0Gg6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDcuMjYgMTE6NTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBBcyBkb2N1bWVudGVk IGluIGNvbW1lbnRzIGluIHN0cnVjdCB4ZW5fbWVtb3J5X2V4Y2hhbmdlLCB0aGUgaW5wdXQg dG8gdGhlDQo+IGh5cGVyY2FsbCBpcyBhIHNldCBvZiBNRk5zIHdoaWNoIGFyZSB0byBiZSBy ZW1vdmVkIGZyb20gdGhlIGRvbWFpbiwgcGx1cyBhDQo+IHNldCBvZiBQRk5zIHdoZXJlIHRo ZSBuZXdseSBhbGxvY2F0ZWQgTUZOcyBhcmUgdG8gYXBwZWFyLiBQcmVzZW50IGNvbW1lbnQN Cj4gYW5kIHBhcmFtZXRlciBuYW1pbmcgZG9uJ3QgY29ycmVjdGx5IHJlZmxlY3QgdGhhdC4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4N Cj4gLS0tDQo+IFNob3VsZCAiZm5zX291dCIgbWF5YmUgYmUgImZuc19pbm91dCIgdG8gZnVy dGhlciBlbXBoYXNpemUgdGhlIGR1YWwNCj4gcHVycG9zZT8NCg0KSSB0aGluayBzbywgeWVz LiBBbmQgSSdkIGxpa2UgdG8gaGF2ZSB0aGF0IHJlZmxlY3RlZCBpbiB0aGUgY29tbWVudCB5 b3UgYXJlDQptb2RpZnlpbmcgLi4uDQoNCj4gDQo+IC0tLSBhL2FyY2gveDg2L3hlbi9tbXVf cHYuYw0KPiArKysgYi9hcmNoL3g4Ni94ZW4vbW11X3B2LmMNCj4gQEAgLTIyOTEsMTggKzIy OTEsMTkgQEAgc3RhdGljIHZvaWQgeGVuX3JlbWFwX2V4Y2hhbmdlZF9wdGVzKHVucw0KPiAg IH0NCj4gICANCj4gICAvKg0KPiAtICogUGVyZm9ybSB0aGUgaHlwZXJjYWxsIHRvIGV4Y2hh bmdlIGEgcmVnaW9uIG9mIG91ciBwZm5zIHRvIHBvaW50IHRvDQo+IC0gKiBtZW1vcnkgd2l0 aCB0aGUgcmVxdWlyZWQgY29udGlndW91cyBhbGlnbm1lbnQuICBUYWtlcyB0aGUgcGZucyBh cw0KPiAtICogaW5wdXQsIGFuZCBwb3B1bGF0ZXMgbWZucyBhcyBvdXRwdXQuDQo+ICsgKiBQ ZXJmb3JtIHRoZSBoeXBlcmNhbGwgdG8gZXhjaGFuZ2UgYSByZWdpb24gb2Ygb3VyIHBhZ2Vz IHRvIHBvaW50IHRvIG1lbW9yeQ0KPiArICogd2l0aCB0aGUgcmVxdWlyZWQgY29udGlndW91 cyBhbGlnbm1lbnQuICBUYWtlcyBhcyBpbnB1dCB0aGUgbWZucyB0byB0cmFkZQ0KPiArICog aW4gYW5kIHRoZSBwZm5zIHdoZXJlIHRoZSBuZXcgcGFnZXMgYXJlIHRvIGFwcGVhciwgYW5k IHBvcHVsYXRlcyBtZm5zIGFzDQo+ICsgKiBvdXRwdXQuDQoNCi4uLiBsaWtlOg0KDQogICBb Li4uXSBUYWtlcyBhcyBpbnB1dCB0aGUgbWZucyB0byB0cmFkZSBpbiAobWZuc19pbikgYW5k IHRoZSBwZm5zIHdoZXJlIHRoZSBuZXcNCiAgIHBhZ2VzIGFyZSB0byBhcHBlYXIgKGZuc19p bm91dCksIGFuZCBwb3B1bGF0ZXMgbWZucyBhcyBvdXRwdXQgKGZuc19pbm91dCkuDQoNCldp dGggdGhhdDoNCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNv bT4NCg0KDQpKdWVyZ2VuDQo= --------------sHJZ0Ia0uoWyY5r3zY0h0Gg6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------sHJZ0Ia0uoWyY5r3zY0h0Gg6-- --------------gwj4yeI9S5JHpZF7F4xM6WWE-- --------------nQgv1Bqlnnr0TaSVOpwNNn6l Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpFMHMFAwAAAAAACgkQsN6d1ii/Ey/2 jwf8C4Ir62V2ZdCImI/molyOq+JPPLJRySa8FvIy9Gut7SM4zDwslPkhZQPqimKudUVIqKSeRdzw ExEm7PWvMaVHQ0MbwbZUerrLWph6kMfoYiEPP1Fbne6Tm8TX/AnSgMEi7oeM1V0e474JQZVezj13 yPpzOLuRCOTrjTELUUi/9PuhmagIVEe2959UBQ07L2OMrJtn2bjekgur5Kwgh6S+6n2GIwtfm+q+ vLWXGMwH2DknizAVtEA9etD7EmYHGImhywo5eaJhX8kaqzjMcqOJbZFeh3EnkCUalffMdMU6SvHK ED1BF2QF0gKaj8r2Y3d/cT0SgBgxofrXLorCakMwYQ== =Hxhx -----END PGP SIGNATURE----- --------------nQgv1Bqlnnr0TaSVOpwNNn6l-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:21:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:21:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350116.1607681 (Exim 4.92) (envelope-from ) id 1wewkV-0001cI-AS; Wed, 01 Jul 2026 15:21:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350116.1607681; Wed, 01 Jul 2026 15:21:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewkV-0001cB-7c; Wed, 01 Jul 2026 15:21:15 +0000 Received: by outflank-mailman (input) for mailman id 1350116; Wed, 01 Jul 2026 15:21:13 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewkT-0001az-KC for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:21:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewkS-004tRH-T0 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 17:21:12 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a453058-bab6-0a2a0a5309dd-0a2a450988c8-46 for ; Wed, 01 Jul 2026 17:21:12 +0200 Received: from [40.107.209.18] (helo=PH8PR06CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a453067-97e6-0a2a45090019-286bd1127110-3 for ; Wed, 01 Jul 2026 17:21:12 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by PH9PR03MB767167.namprd03.prod.outlook.com (2603:10b6:510:3e8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Wed, 1 Jul 2026 15:21:09 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Wed, 1 Jul 2026 15:21:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VQKCFizZRfdDmZcfUKJXOAg6ApNqkrpTVNn1FRMZFKFSXX4SDXN5EV08heIOa+O3dGIEhTg50VWYXMgg2sm/EF8hmEqiE7yABv0F1juQUrgiEkLwFMPE9IF+CTJEljcFT4O8hKdrNjDHBlEL2eHeAhs/3FbpmZv73mx8Ilsvt1S0o7OExpIpPWTxyU6UoQlrQpmqHJi1VcWJ9jWj0XhQsPF4BxW+Y24YLqEt9shIVMJdaP45w4yTfRNNFVj+LWgyobDpoqS+PiIm6kDPqBw3iMqbQjwba4xJzP9cxKq8AL6pWqEoc+9szYEjwTqAhXViHryDTHh7qPwI+S4WdJMpSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FAzW1JgJSGu5uCsBpSgF0sIhfKeZU1U9S6FwoWB2HCE=; b=xs2FgaDIVGba/3rngiI1BZk/HAWUXCwtQZ8xTdOHKEUr9l28fUYssLYSa/EOlEQJYubKS/1Ad5S3pWJDW9LUPXQ1IF6mTPP4WjeaE1mor60afkALHs3UrxRn96HdFufbngmGSWfc9Ficiwu7m2YUEAma+3f+oUUPnNm3cjzqJ+Mli6ky6bfBHiCnQk9N+atVHmaf57s0GlBlPgDwVUB5Qszxdt4yo/7Ay6wXhg26xNBXJI9buhekCjpUaubnhlaCP9RV+zUOy6KSM0dvEXEOQyPMXLP7+EEtfUFPgg0hBdZmePvhjJNiUEtGrKUl50+XfML5TG82dkr7+nGGlFYbag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAzW1JgJSGu5uCsBpSgF0sIhfKeZU1U9S6FwoWB2HCE=; b=oiI7wOumGxq404/1nQRFf9wlYPtW/omRoa8/4VZzuVlS1MVZ+0XS/EPqZIcKssB/UYnzVbjeHjGyWFQe9VqNmycwGtzBPvvIYJYOaAGA+nKUtxZLoPoGOJdK94JymT0di9kK2m8WiPpVWXeQIT872K3q7kFXH9pYbKFI37AHjos= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <53018bb5-0ad4-449e-adda-6b2d94a0935e@citrix.com> Date: Wed, 1 Jul 2026 16:21:06 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski Subject: Re: [PATCH] x86/cpu-policy: set up host policy earlier To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <6dccae5f-fe09-4f35-9e4a-7a38fb21e8d1@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <6dccae5f-fe09-4f35-9e4a-7a38fb21e8d1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0576.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::23) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|PH9PR03MB767167:EE_ X-MS-Office365-Filtering-Correlation-Id: 4bcfc8b2-4edc-4ab5-f82f-08ded7846099 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|366016|18002099003|22082099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: gydi3p13ADVaFomIlvVoLfgtM3t8qrf9VkQGJrhIRk+YC+cI9loRkjZEisujRwXETct5ra6+Xkq6FndTyt+eL5wAw1oM6bj5InOCTuMt1spyO2PF4FlUDPXwzQfRMvCIgTy0rrw9C7hj3/gRu2ttZmDRwPnsVyhm5WTv0MuIwFQanGtvVBNHFGcKrD0KLRdqZapiNniWXoyEAxlsmfOFWCNC1GQOM8OphzI3FD2SZNJSV2HCiFfEOg8HeweU+Xymw3d009qnEtQI0Gc9BYeXhTBH3CCVGlJwBOZlEDG37AQMAnuYfR/GxJm1PO7jw85uuC+dJ/W0BammZd1J6FpdE+sN8PmQiN6EkWF+9zFirrRraIkptqEDadjSOfp1zhW8oxouyL7pwrYe51D0ELu1RLp8J2wwbZTDTQr5RUAOFt4+11C6sAc9rjuNZDKW7V+SK72vi0phBLzGl7A4dH688185XxOQhk67kdw1c4EtmtyjkdvoquhMxgZzVDHDZ9wXrSaQWziqmmCpPdISAOrpjnUJ7199M1SBnIIw7X4mXJFuGvyRZDMNz227oH5ZQ5uvWYgJ9NPbwJ98WWUHREM9JC+Aq//iLrZL/VT6yr3K7YRUB+f4Ghg1RDakt+72T7Bve1QarSU31HaZwQeootmsX6rbiDEF1Pagb0c+pYeB+do= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(18002099003)(22082099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anhWVlpzbzQ4Wmhjcm02MStCUUgrVDRtbFd2NEhsNkgyVVlZRWNNNWE2Q2xy?= =?utf-8?B?eTQ3WGVDb1VicThVODgwaU9OTnVUbU1lNlgzd29SNlJPc0lVaWxFMGM0Vnp1?= =?utf-8?B?ZndGTE8zNEsxM3NVdmMrWU1kZWV2cWlMUStBcVJ3djNKKzZ3eTZxZ3RCRzlx?= =?utf-8?B?VTJBYnRrYm1CR2ViSFVDMUhicXdDdmxJR01ZTEl5bkUxbzZhZTFzdk5kU2Zj?= =?utf-8?B?ajZ4bTZybDR5TFg5b3M4VGwweHQ2NXdNZjRhZzN3bmprYUpXVlJjSEdWSEZ2?= =?utf-8?B?VncxMjlrU3NmT3VVSXVIOUQ4QUw4dEgycStKODgrMTAxeTJ2MXhQQmFrSzdI?= =?utf-8?B?eWVVOTdKN3M3ZEZQdko4RXNnYnNNMXl5TVE0VXVuOEJudEVBNkxlNSsvdHJP?= =?utf-8?B?bmNmRHpORFFHa2xBYWVvMzgreUliQlhtMlJodlZ5QTNzVzBBbUhMcnR5eERW?= =?utf-8?B?OFdDSUhubk1YdWh0U1l0Tm5kVktPSU0ydEtmOWdoZHhxbVdVRmp1ajhaMmxR?= =?utf-8?B?TEVveTZMMVhlbU42b3ZGL0x5M082WmsrUC9FWUVMNEhRak0wYWJwemFiYVNn?= =?utf-8?B?Vm03TjltS3BoNWZ5ak1rd285S1RRaVZWcDkwamxncittUVF4Wkw3N3RaWlBh?= =?utf-8?B?OWhTRkpKeGFzdGdVZGZPelNPRmxyTUZCSllXelVSVFc2QThQTWxkTlhOR00w?= =?utf-8?B?UGI1cmtEdlRxNUJkNitzWi9kSjhBbEJ6OWw1MW1ZSEZIVEVVRzNoQlNTL3Vr?= =?utf-8?B?TXlCL05Ua2E1TUZMK1pRS24xOXJMRk9YTVNkVjdpQkRGZjFpQW1OZUdFWHZN?= =?utf-8?B?NnZ4WkJDZ1RDY0VvQlhtN1Y3b1JMcThIRWsxR1dseGRTYmpqVE11NnFGR29D?= =?utf-8?B?S2lNYlg3YnhIYTNKdW5oNzlNYmxPRTZlY3N2YzFXRkd6alk5SzRuN1ZycEdT?= =?utf-8?B?ZWl2RU1nVVlaS1NJK25sRkMyeS9oSktLZmZraFFXZUhNMmJnQTZ2ZVB2eVNT?= =?utf-8?B?d2ZreVdHSjgzRFhSMzhFZjhIa0pzWTF0T1lTNUl3NlNzWXY0ZFdlWndGR2dQ?= =?utf-8?B?OEplT2pKK0R3c0JnaTlZUFUwSmUrRFROSGJTRDRYOTU1VW9SQWZmSlhlSFVl?= =?utf-8?B?RWU1aEdTcy9vRnNYSTBSQ1kzdnU4MFZYVENWUXc3cktGektzaFA1V1JDKzFs?= =?utf-8?B?NWtsRjJSWDcwbFQ1WDlHNUhOYTJOSVJValBMWGNyU3d1SlZXVUlscGJvSG91?= =?utf-8?B?ZXpsQlNFMjB5c3gvMlc2Uy9ETWJ0eG1XVCtxYUcwaDl2VSttZllkUXQ5Vi9Q?= =?utf-8?B?VG9ka2RuYXNwMnVUR0h2SEhUdzhBcUVxR09uYzBSWXBUK21Cbi9PR25CaFlG?= =?utf-8?B?T1hsZVdFeU1ST3hqSEVySXlmampyekw2QVJRdTZVc2JXLzl1QW1CaXBIQWxR?= =?utf-8?B?U1ZnaThCb2tYazJDY0QwMTBoMnVwQmdVODgzbmNQR1QvSWlkTHlpK2VHYnlx?= =?utf-8?B?dTBVUlpGYUVEcmlpNUMwSmhnTXBHMGRyZ3JLaG80M3N3YVBiT29ET005NEd3?= =?utf-8?B?R0NOYm5QeklTTThkVzY5bkhibWpGTkxMOXdCZUxhZ2RFbmdxNGVITzA2QzV5?= =?utf-8?B?WFowRStJSWFBUWViNFZzRm1Sb1VBM3pGSVMwVE5RNlJUS2M3VXlQb1JEU2V4?= =?utf-8?B?eU1uQkdtdVdEYUFZOFdocmdUZ0x3dGFsSmY2alJ0cE1sQnBRYUVmZS9JWGZ1?= =?utf-8?B?anp6QjB6WDNaUk1oelY2MmsyTlNMamVDK2wwTGljbTN5d1BnSi9uNUR2UXZZ?= =?utf-8?B?T0RaWWIzM2d3V0lxTXB6QlprN0hCT0YyYjdKWk5tZitaUk1RaXNxK2NjTFFi?= =?utf-8?B?ZnlubFhUaXNnNndEVXo2Mk1uSkY1RUlwY052Q1ZpRElURjBnN2JHUUlVSHhS?= =?utf-8?B?Ui91YTJzdmlIYVc2Uk01T0dRSVZYRmxwdksxR2QzdkJPZFJ5Wkh6LzFvUVVi?= =?utf-8?B?VENmaWZSejZzeGRlQzFaMDdsU2U2TE84YXNsYmhqeENKVE42c1BEd0dFb0sx?= =?utf-8?B?RmlCMHg2eHM3cDZrazBjZ0FoZFVJNEpVbkJOdUtDREd3SW1PcDE3UEduNi9n?= =?utf-8?B?M2ZJb3VCRzZtQW9vMVdRM3hDbGRndWdNRG9tN3pGTWxCMVNpcXZiQ0JtRUd1?= =?utf-8?B?OFVxN3Ztd093ZXd5a01tejhJcXcxZkI1Ymw0ekNWNXFNU2VPSFAxUEdjL01X?= =?utf-8?B?cm9QUUorbUdzd3cvN3FLV0Q5TmY5ckJ3cHlFRUdIK3NLQ0dzMEtaMWtPa0FW?= =?utf-8?B?dU1SZ1Jqa3lKUnBGdko5aS9qZ2JWeWNPVEMxdEdZZlcwNXE4aDNkTzNmYndQ?= =?utf-8?Q?upw22urUBHGtPvXU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bcfc8b2-4edc-4ab5-f82f-08ded7846099 X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 15:21:09.0184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vd6Q1GVGAHf1ORCKVSetd87NwrCLE67HS/vO1nvif+5SUJWEyroMAnCy3mVlgByx3h7urjN8v5I3KuEWvZXt3sumTCyQIOVYuO9072S0FU8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH9PR03MB767167 X-purgate-ID: tlsNG-bad1c0/1782919272-4693A986-4B85F7DD/0/0 X-purgate-type: clean X-purgate-size: 2755 On 07/04/2026 7:46 am, Jan Beulich wrote: > In order to use cpu_has_* expanding to host_cpu_policy.*, the host policy > needs setting up alongside boot_cpu_data.x86_capability[]. Arrange for > that towards the end of identify_cpu(). > > Fixes: 894bd7617924 ("x86/Intel: use host CPU policy for ARAT checking") > Reported-by: Marek Marczykowski-Górecki > Signed-off-by: Jan Beulich > --- > In the longer run we may need to (also) update the host policy from > setup_{force,clear}_cpu_cap(). > > This really was part of one of the XSTATE cleanup patches at the head of > the AMX series. This explains the specific placement ahead of the call to > xstate_init()). Likely anything from there downwards shouldn't really > live in identify_cpu() anyway. > > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -586,6 +586,8 @@ void identify_cpu(struct cpuinfo_x86 *c) > } > > /* Now the feature flags better reflect actual CPU features! */ > + if (c == &boot_cpu_data) > + calculate_host_policy(); calculate_host_cpu_policy() now it's not local to cpu-policy.c > > xstate_init(c); > > --- a/xen/arch/x86/cpu-policy.c > +++ b/xen/arch/x86/cpu-policy.c > @@ -359,7 +359,7 @@ void calculate_raw_cpu_policy(void) > /* Was already added by probe_cpuid_faulting() */ > } > > -static void __init calculate_host_policy(void) > +void __init calculate_host_policy(void) > { > struct cpu_policy *p = &host_cpu_policy; > unsigned int max_extd_leaf; > @@ -904,6 +904,7 @@ static void __init calculate_hvm_def_pol > > void __init init_guest_cpu_policies(void) > { > + /* Do this a 2nd time to account for setup_{clear,force}_cpu_cap() uses. */ > calculate_host_policy(); I'm sorry, but no.  The cleanup work to CPUID handling is in an attempt to purge this antipattern. Double-initialising data structures *is* the entire reason we have order-of-boot problems in the first place.  Having a structure which is initialised but wrong is itself wrong. Really, I should insist on a revert of switching cpu_has_* to use host_policy.  It was not adequately tested and is not compatible with how Xen starts up. But as I expect you're going to object to that feedback, I'll tolerate setup_*_cpu_cap() keeping the host policy correct as they're called.  The easy option is to call x86_cpu_featureset_to_policy() each time.  The lower overhead option would be to have a table similar to cpu_user_regs_gpr_offsets[] and use that to locate the feature word in a policy object as it's being edited, although it's yet another thing to remember to keep in sync when adding new words. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:24:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:24:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350141.1607700 (Exim 4.92) (envelope-from ) id 1wewnS-0002lA-2q; Wed, 01 Jul 2026 15:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350141.1607700; Wed, 01 Jul 2026 15:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewnR-0002l3-VH; Wed, 01 Jul 2026 15:24:17 +0000 Received: by outflank-mailman (input) for mailman id 1350141; Wed, 01 Jul 2026 15:24:16 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wewnQ-0002kx-Pp for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:24:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewnP-00ASPr-Qr for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 17:24:15 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a45310e-e002-0a2a0a5209dd-0a2a4508d0c6-30 for ; Wed, 01 Jul 2026 17:24:15 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a45311f-edec-0a2a45080019-d155802bf0bd-3 for ; Wed, 01 Jul 2026 17:24:15 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493b77b150aso7061995e9.2 for ; Wed, 01 Jul 2026 08:24:15 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4d9daasm87438345e9.9.2026.07.01.08.24.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 08:24:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782919455; x=1783524255; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EzAlXR1UrnSnynnOL2U7ASX4RUa5MGuJNSO2hUFkhrY=; b=N/ptbj7jwA5HCcah8ZmrrQ7PCrieYRzw44ujr50Z4Iho0JTzhjh2PmVsf/Mv+jecK8 TrCTVvwZePLcU1P5aOzZW09CcqHCeUXhWsTQQBGbBjOo8qZnhOaAfE+QnUSmEeWqPav6 6FsW76o6qBJtYsnFfE7G7+vPiF66VqScyYlkNjQJYMTTCsKapy4/y/aUXsEgcEdTG8cO BlOejJxTezq7uZWZ1IUJCtxp8qElH/PibBJih4JJedqmUFZE/UTrBQlkh7xZ9egdnsbR jY5izydwN64AHb4oYE6K/YCEZbRMyqDg6/HgK4hkbaP6KlsVeogQjXv313IIwqXDTQ38 /dTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782919455; x=1783524255; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EzAlXR1UrnSnynnOL2U7ASX4RUa5MGuJNSO2hUFkhrY=; b=pEVKJQzqAscHAKZwvr0q1wQTorLw6nYxyZFKMauf+4BAKfpwQt8CraCW/SV7yE41Ea ta7LF7TCen0w6J0jiZ+AtoejUh7NSZA1WVJiRJClLESLlgA+yJqQA1oTinMYGcS/P5kp rhZmFtAAHtwZQE6RLBHnXZ4SWddgX644LJJnCYsDKyBIkwJiyHp8R6/QdZ7yHrd7Qov3 IJEvwmfq304NGRNak8uDXXWp4oqYqhvRPbmdtdx1eSeDqcf5ceSsjbG/XhZf2+jqrdaR 1yxq0ztcYMfBReLij3KHcCE4VsBK+GZpXqJ2nFosMtKT32GYHXzSoQAHhsq5HMEUkxwq mszg== X-Forwarded-Encrypted: i=1; AFNElJ/mT/5OpAsp4N04p3s97mkiXEfM0nGYTi6Ne79yJKjgu+QEwVYqNcoFLcoo7qmXoUzlxsvTj5rSgLg=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy1ENGHcMmw+bAgF4GsIVkoeZmLA0fapSo5BHw6s6grQscYlF43 BueLT4cFY8+UtC+Z3hZbP5e3uh2wYDV9Q9m6pDCMKQqaKtZjIdo7ua7t X-Gm-Gg: AfdE7cmJrqZjBHA4bIqAedJbxkGIsb+6lTro3sqkrAhCZubTxjAHTiFkGYnh2Xyz3bW JXkdQDxgyxdNpgO/DV1GkDHwq8R94qqAXxJx1ITH8+0O+n9FXvds19kDTPcOGOF5YOYJ6h/OZA+ Oyze3XLfP82msQfXj0s3Gs/29+ZGlNYNzZOaKT1WLVomvJbi5oN8esfucL0fDCKurM71Fn2ZhRB 0vWrZ4i4/7dNxEK4db13unTQw8yZO+WUD0ej2GMhTA2pljhOcao7r7J/GEhtcH/LbtJqRsUfen1 6nT7zpKApPTjrCCpyGH2sjjIEWJsia9BJopeyQIwoKA8mwGltrhJ5F/BElbsaZYvNzyJ2SWObFt s4aUX0p/L8G1UfEig4BgpNYibduaVMyBsg3ybV4p90WYJDhv464hIU9A4kgn38Ub2LlRbW0jm+L HuNTiVnJMU5lQIhHwLhlPxcp/yXGC/L0d7d8+0YT60CaBpv2TDLSmpSYcsjddWi27wVWA= X-Received: by 2002:a05:600c:35d2:b0:493:c3f9:65a2 with SMTP id 5b1f17b1804b1-493c3f9664bmr16518835e9.5.1782919454882; Wed, 01 Jul 2026 08:24:14 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 17:24:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 25/25] xen/riscv: add initial dom0less infrastructure support To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <131fc20c-1353-49fc-8f77-1ca13628ff17@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <131fc20c-1353-49fc-8f77-1ca13628ff17@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c1860d/1782919455-A11293FC-C6D416F6/10/73395122804 X-purgate-type: spam X-purgate-size: 3629 On 6/30/26 9:28 AM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> Enable dom0less support for RISC-V by selecting HAS_DOM0LESS and >> providing the minimal architecture hooks required by the common >> dom0less infrastructure. >> >> Add stub implementations for architecture-specific helpers used when >> building domains from the device tree. These allow the generic >> dom0less code to build and let a basic DomU be constructed on RISC-V. >> construct_hwdom() and make_hypervisor_node() are still stubs returning >> an error: Dom0/hwdom construction isn't supported yet, and the >> hypervisor node generation (needed by domains with >> DOM0LESS_ENHANCED_NO_XS set) is not implemented. Both are marked with >> a TODO and are not reached by the currently supported configurations. >> >> Provide missing helpers and definitions required by the domain >> construction code, including domain bitness helpers and the >> p2m_set_allocation() prototype. >> >> Additionally define the guest magic memory region (GUEST_MAGIC_BASE / >> GUEST_MAGIC_SIZE) in asm/guest-layout.h. The base is arbitrary; the >> only constraint is that the region must not overlap guest RAM or the >> emulated device regions. It is placed in the unused gap below >> GUEST_RAM0_BASE (0x80000000); the constraints are documented next to >> the #define-s. >> >> Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich Thanks. > > Nevertheless, ... > >> --- a/xen/arch/riscv/include/asm/guest-layout.h >> +++ b/xen/arch/riscv/include/asm/guest-layout.h >> @@ -32,4 +32,16 @@ >> #define GUEST_RAM_BANK_BASES { GUEST_RAM0_BASE, GUEST_RAM1_BASE } >> #define GUEST_RAM_BANK_SIZES { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE } >> >> +/* >> + * The guest magic region holds Xen-reserved pages mapped into the guest's >> + * physical address space (shared info, grant table, etc.). The only real >> + * constraint is that the GUEST_MAGIC_SIZE-byte region must not overlap >> + * guest RAM (the GUEST_RAMx banks) or the emulated device regions defined >> + * above; the exact base is otherwise arbitrary. Here it is placed in the >> + * unused gap below GUEST_RAM0_BASE (0x80000000), but a hole after a RAM >> + * bank would work equally well. >> + */ >> +#define GUEST_MAGIC_BASE _UL(0x79000000) >> +#define GUEST_MAGIC_SIZE _UL(0x01000000) > > ... while 16Mb may seem a lot, it feels pretty little for 64-bit guests. > Even in just Sv39 mode they have ample VA space to map a bigger region. > (As iirc indicated before, a static upper bound looks questionable to me > anyway.) I think the comment should be updated as for grants will be separate region. For all others, it looks like 16MB is more then enough. For example, Arm has only 4 used pages (CONSOLE=0, XENSTORE=1, MEMACCESS=2, VUART=3). So will you be okay with reworking of the comment to: /* * The guest magic region holds the Xen-reserved pages mapped into the * guest's physical address space. The only real constraint on * GUEST_MAGIC_BASE/SIZE is that the region must not overlap guest RAM * (the GUEST_RAMx banks) or the emulated device regions defined above; * the exact base is otherwise arbitrary. Here it is placed in the unused gap * below GUEST_RAM0_BASE (0x80000000), but a hole after a RAM bank would work * equally well. */ And add to the commit message that: ``` A separate region for grant tables will be introduced at the same time as the introduction of the grant table for RISC-V. ``` ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:25:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:25:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350153.1607708 (Exim 4.92) (envelope-from ) id 1wewou-0003NG-Dw; Wed, 01 Jul 2026 15:25:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350153.1607708; Wed, 01 Jul 2026 15:25:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewou-0003N8-AW; Wed, 01 Jul 2026 15:25:48 +0000 Received: by outflank-mailman (input) for mailman id 1350153; Wed, 01 Jul 2026 15:25:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wewot-0003N2-LM for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:25:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewot-003rfm-2C for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 17:25:47 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a453176-2eae-0a2a0a5409dd-0a2a450ab4a4-26 for ; Wed, 01 Jul 2026 17:25:46 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a45317a-e40e-0a2a450a0019-d155802fdc23-3 for ; Wed, 01 Jul 2026 17:25:46 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493a97fad2fso6933105e9.0 for ; Wed, 01 Jul 2026 08:25:46 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4540aesm85628905e9.0.2026.07.01.08.25.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 08:25:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:Content-Language:References:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782919546; x=1783524346; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=5Uiv/so1XThRNUVtMm9zvCb2kbxp7wSDqrL4nXO2GtM=; b=rmxzl/zzMx6Ok5x6ag6T3OqE7Mia388mtheh2CwYclO0SeBVljTM+66H9xvy0EpfYH XTQyWTNoVHPv1VspIM0aTMFcbIWDZjObQphz8hC8LCEVj/SB+adf0M8Z0Yd1WjLkKPht dsOwERX1DaScBlb0RseKSisr2bWt/heyquudTeGG3MMTS2swqXSDpAKt1thyECnJrnt+ emlmUkE3Qciu/xRMjNpIuWGfo9OEsAkpe5cyd7GUTF3BXTpLQCxogsPfgqmLDr10703Z EaOmuiEfvsp+bdYpJ0Fj0p2W7dADrW/U9iXSA0+9eWhJnPMAxxE4umefcHJU2PZLBc7w vRiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782919546; x=1783524346; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5Uiv/so1XThRNUVtMm9zvCb2kbxp7wSDqrL4nXO2GtM=; b=UbzPmd+Jq3rVBH/ouVgEh0j8LahxXdm/9JcsU5B+kYjyhfngx5U2GYK/5nLz5QowQI ttCkZBkd3Xo2nrSOVJGnlN012QIMCmEtSUVtdJpuDFqJ6lqWNi9ycOzM2kgOmjgbcnbm HBvtp0yfZKyYMHJhnUqczSncSyQCRJLFdNhoEoWqrAsUNtdWyWw4F0GsOb4HNC2Unoyi XnTJ5sAh3siduFpEEJVNBoMrQI+YX7C5w/xFIsie/qvp1sIAyf3t4fmmwXh9fsW4wCBr TjJTOIPe3l2adQcZvQ700xvDeGU8d/Udcb9wmTs0EWPa9ljV+AbdXb8bcA21a7VKdN8b weLg== X-Forwarded-Encrypted: i=1; AFNElJ/QT5sEVjIbLz6VM7Qf8aVbc8oQoF/otW66ssg4S+PbLmKB8tsO3QtyQ2PFy39Ru5zl3Dppcy475yE=@lists.xenproject.org X-Gm-Message-State: AOJu0YyCbKuFMCv0+sdRFq8l97DCGGTYdH8JsxTElJi3n6lBgqMXMX7w wvyg8WtYGWkyXFnbgK74puul3BcKs3pfP6W2abmtFPsXEuGirB9ZH528 X-Gm-Gg: AfdE7cmWpkrs1lGrlCcza7JMfU2VPA6R27TSr9Xv3p3H+n/8ZduG31CX8iAltqioIpp zWcDCucx4R9JaeeEIb6MvOhr8rU8MWFIV1SIOfHqGTonRG21gq0ABvrrScQCnpTvVXj4n/1AjeD XF8rzq8PGbnZmeNQgKCjmJfNXtxtjpxfR/5l2OVxlpiyltkNKzHOtwZaBuGXMpjMZAtzOljMMJ5 Thb7ZV1VgodelBbIE7TLsrpnF9B1L8qqsCvufWpznUDkcfu0ONedNbGYWOoK8yz9KlQIa3hna1i io2o8GE20iXbn1bElKt9jOVo9X+qweEMzOqcL0FtGfMqnMx8qiV3M/AEf2WeiGnamhT8HBzZpFm 7cp//grGF3BjEjPnDhBju3GpfafiRpRAIbsrUyaXCIt5BreCZbB1cB7U8DJk4iuTEbS99/j+7OT qqhD1UwPsA+ghOIxRlvsOd6NGLD9E5UVsHx4obFUnG2dX007Go7Kyj10cgf5UvlDx8e60= X-Received: by 2002:a05:600d:844f:20b0:492:5bb6:6d4b with SMTP id 5b1f17b1804b1-493c3df77eamr14662535e9.34.1782919546278; Wed, 01 Jul 2026 08:25:46 -0700 (PDT) Message-ID: <2093dd4c-c80d-4b65-998f-c90796dc4a88@gmail.com> Date: Wed, 1 Jul 2026 17:25:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Oleksii Kurochko Subject: Re: [PATCH v4] xen: introduce CONFIG_HAS_SHARED_INFO for archs without a shared page To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , xen-devel@lists.xenproject.org References: <775c88457e5ec7fc7889002c6f9829669f9bce97.1782388193.git.oleksii.kurochko@gmail.com> <5d344cec-bb97-4d3b-87ff-e7175772fd45@suse.com> Content-Language: en-US In-Reply-To: <5d344cec-bb97-4d3b-87ff-e7175772fd45@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1782919546-3C07ADDE-910CBC35/10/73395122804 X-purgate-type: spam X-purgate-size: 6251 On 6/29/26 4:26 PM, Jan Beulich wrote: > On 25.06.2026 18:02, Oleksii Kurochko wrote: >> On architectures that run guests in dom0less mode without the PV ABI >> (currently RISC-V), no shared_info page is allocated and d->shared_info >> remains NULL throughout the domain lifetime. Several places in common >> code access d->shared_info through the shared_info() macro or directly, >> causing UBSAN null-pointer errors on such architectures. >> >> Rather than adding runtime NULL guards that are logically unreachable >> on x86 and Arm (where shared_info is always allocated), introduce a new >> Kconfig symbol CONFIG_HAS_SHARED_INFO selected by x86 and Arm. >> >> On !HAS_SHARED_INFO the shared_info() macro expands to a dereference >> of a pointer returned by shared_info_absent(), which is declared but >> intentionally never defined. > > This looks to need updating. I will update it to: On !HAS_SHARED_INFO the shared_info() macro expands to a dereference of shared_info_absent, an extern pointer that is declared but intentionally never defined. > >> Any use of shared_info() that is not >> dead-code-eliminated will therefore cause a link-time failure, making >> missed guards impossible to overlook. >> >> The 2L event-channel ops call shared_info() and must not be compiled on >> architectures without a shared_info page, so event_2l.o is gated on >> CONFIG_HAS_SHARED_INFO. On such architectures evtchn_init() installs >> the FIFO ops as a placeholder instead; evtchn_fifo_word_from_port() is >> guarded against uninitialised d->evtchn_fifo so the FIFO ops are safe >> before evtchn_fifo_init_control() is called by the guest. >> >> With CONFIG_HAS_SHARED_INFO=n all vCPUs fall back to the global >> dummy_vcpu_info, so writes through vcpu_info() could leak data between >> vCPUs. Reviewing the write paths in common code: the write in >> map_guest_area() stores the constant ~0 so nothing serious would happen >> if it were leaked; the event_2l.c paths are unreachable because the >> preceding shared_info() call would trap first; > > Why "trap"? You can't build an image that way, can you? "trap" was shorthand for the link-time failure. I will changed that part to: ... leaked; the event_2l.c paths are not compiled on !HAS_SHARED_INFO, as event_2l.o is gated on CONFIG_HAS_SHARED_INFO; ... > >> @@ -1624,7 +1626,11 @@ void evtchn_check_pollers(struct domain *d, unsigned int port) >> >> int evtchn_init(struct domain *d, unsigned int max_port) >> { >> - evtchn_2l_init(d); >> + if ( IS_ENABLED(CONFIG_HAS_SHARED_INFO) ) >> + evtchn_2l_init(d); > > For this to build when !HAS_SHARED_INFO, all you need is a declaration of > the function. The compiler will DCE the call. Hence ... > >> --- a/xen/common/event_channel.h >> +++ b/xen/common/event_channel.h >> @@ -44,7 +44,11 @@ static inline void evtchn_port_print_state(struct domain *d, >> >> /* 2-level */ >> >> +#ifdef CONFIG_HAS_SHARED_INFO >> void evtchn_2l_init(struct domain *d); >> +#else >> +static inline void evtchn_2l_init(struct domain *d) {} >> +#endif >> >> /* FIFO */ >> > > ... this hunk should be unnecessary? Looks like you are right, I will double-check that. > >> @@ -55,6 +59,7 @@ struct evtchn_expand_array; >> int evtchn_fifo_init_control(struct evtchn_init_control *init_control); >> int evtchn_fifo_expand_array(const struct evtchn_expand_array *expand_array); >> void evtchn_fifo_destroy(struct domain *d); >> +void evtchn_fifo_init_ops(struct domain *d); >> #else >> static inline int evtchn_fifo_init_control(struct evtchn_init_control *init_control) >> { >> @@ -68,6 +73,7 @@ static inline void evtchn_fifo_destroy(struct domain *d) >> { >> return; >> } >> +static inline void evtchn_fifo_init_ops(struct domain *d) {} >> #endif /* CONFIG_EVTCHN_FIFO */ > > Unlike these two. Which raise a different question though: What will be the > behavior when EVTCHN_FIFO=n and HAS_SHARED_INFO=n? Taking > evtchn_alloc_unbound() as example, afaict evtchn_port_init() will stumble > over a NULL pointer. Looks like for that (and only that) case we still need > your earlier dummy fallback. I will introduce dummy fallback (I will shrunk some stubs in final version): +#ifndef CONFIG_HAS_SHARED_INFO +static void cf_check evtchn_none_set_pending( + struct vcpu *v, struct evtchn *evtchn) {} +static void cf_check evtchn_none_clear_pending( + struct domain *d, struct evtchn *evtchn) {} +static void cf_check evtchn_none_unmask( + struct domain *d, struct evtchn *evtchn) {} +static bool cf_check evtchn_none_is_pending( + const struct domain *d, const struct evtchn *evtchn) { return false; } +static bool cf_check evtchn_none_is_masked( + const struct domain *d, const struct evtchn *evtchn) { return true; } +static void cf_check evtchn_none_print_state( + struct domain *d, const struct evtchn *evtchn) {} + +static const struct evtchn_port_ops evtchn_port_ops_none = { + .set_pending = evtchn_none_set_pending, + .clear_pending = evtchn_none_clear_pending, + .unmask = evtchn_none_unmask, + .is_pending = evtchn_none_is_pending, + .is_masked = evtchn_none_is_masked, + .print_state = evtchn_none_print_state, +}; + +static void evtchn_none_init(struct domain *d) +{ + d->evtchn_port_ops = &evtchn_port_ops_none; +} +#endif > >> @@ -420,6 +423,11 @@ static const struct evtchn_port_ops evtchn_port_ops_fifo = >> .print_state = evtchn_fifo_print_state, >> }; >> >> +void evtchn_fifo_init_ops(struct domain *d) >> +{ >> + d->evtchn_port_ops = &evtchn_port_ops_fifo; >> +} > > Isn't this unreachable code when HAS_SHARED_INFO=y, violating Misra rule 2.1? I think if we are going to return back to dummy fallback I think that we could drop evtchn_fifo_init_ops() as d->evtchn_port_ops will be initialized later for FIFO. And then in evtchn_init: int evtchn_init(struct domain *d, unsigned int max_port) { if ( IS_ENABLED(CONFIG_HAS_SHARED_INFO) ) evtchn_2l_init(d); else evtchn_none_init(d); Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:30:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:30:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350163.1607716 (Exim 4.92) (envelope-from ) id 1wewt7-0005Rh-Su; Wed, 01 Jul 2026 15:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350163.1607716; Wed, 01 Jul 2026 15:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewt7-0005Ra-QA; Wed, 01 Jul 2026 15:30:09 +0000 Received: by outflank-mailman (input) for mailman id 1350163; Wed, 01 Jul 2026 15:30:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewt6-0005RD-Hx for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:30:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wewt6-0028zg-2D for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:30:08 +0000 Received: from mail-lj1-f172.google.com ([209.85.208.172]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wewt6-002mTL-11 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:30:08 +0000 Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-39957d210f4so8123511fa.0 for ; Wed, 01 Jul 2026 08:30:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Type:To:Subject:Message-ID:Date: From:MIME-Version; bh=T6mw+mMJOdl5hUTkEqale/uYDzDG6vIcz1q3yNEIq9k=; b=A0yH3+i Fo/3RuANBIEMnvgCvZgEAPYHUWKStFQdK/9paXjJ/4us6M7Vjf++z7KU7l7i03FsByDkfRQJfABDt 4zP/HIkHGD2/eD5cFSdc7kbD7RGvUvMXDC6QW2tmdnHrjEKy/8m4dwzi6VxxcNGJqnhfmdh9hg+qC orOk5leqDY=; X-Gm-Message-State: AOJu0Yxm4mJzaxthf6mgu/1TKKGWtb9a5YAIpzhd8VZMbq0CNokVauf4 UhNoTU7sCwEn4miAuaV3PLunwALpMwd6LJdYcmgyAR3JeyY1LjKeZsrPyBNrZiQZDbFBl/Oz9bI KiM5Vk+c+4s7OlprJuD9jTOGRCaDjIoA= X-Received: by 2002:a2e:b891:0:b0:39a:e3c7:6649 with SMTP id 38308e7fff4ca-39b3406b5f9mr5869941fa.28.1782919807185; Wed, 01 Jul 2026 08:30:07 -0700 (PDT) MIME-Version: 1.0 From: Cody Zuschlag Date: Wed, 1 Jul 2026 17:29:54 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AVVi8Ce0T2c5gcTJQjHKfTk87pywHalYs-RoggO2ZWB09IhznD0KZAlbcYRlb2E Message-ID: Subject: [ANNOUNCE] - Call for agenda items for July 2 Xen Community Call @ 15:00 UTC To: xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000c5384706558e5d83" --000000000000c5384706558e5d83 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi everyone, It=E2=80=99s time for the July Xen Project Community Call, happening tomorr= ow, Thursday, 2 July at 15:00 UTC. We=E2=80=99d love to have you join. Whether you have updates to share or ju= st want to listen in, it's a great opportunity to hear what the community has been working on and discuss ongoing project activities. *Preparation:*=F0=9F=91=89 Please take a moment to review and update the ag= enda ahead of the call: https://cryptpad.fr/pad/#/2/pad/edit/JItQI8jtCjrs3eM1SWSgjDgv/ Feel free to: - Add topics or project updates - Suggest anything we can drop or defer - Include links to patches, threads, or documentation where helpful The agenda also includes the meeting link and additional call details. *Call Details:*Date: Thursday, 2 July 2026 Time: 15:00 UTC (agenda starts at 15:05 UTC) Join: https://meet.jit.si/XenProjectCommunityCall We'll open the room at 15:00 UTC and begin the agenda at 15:05 UTC to give everyone a few minutes to join. Want to be CC'd on future calls? Add or remove yourself from our sign-up sheet: https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ See you tomorrow! Best regards, Cody Zuschlag Xen Project - Community Manager --000000000000c5384706558e5d83 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi everyone,

It=E2=80=99s time for the July Xe= n Project Community Call, happening tomorrow, Thursday, 2 July at 15:00 UTC= .

We=E2=80=99d love to have you join. Whether you have updates to sh= are or just want to listen in, it's a great opportunity to hear what th= e community has been working on and discuss ongoing project activities.
=
Preparation:
=F0=9F=91=89 Please take a moment to review and = update the agenda ahead of the call:
https://cryptpad.fr/pad/#/2/pad/edi= t/JItQI8jtCjrs3eM1SWSgjDgv/

Feel free to:
- Add topics or pro= ject updates
- Suggest anything we can drop or defer
- Include links = to patches, threads, or documentation where helpful

The agenda also = includes the meeting link and additional call details.

Call Detai= ls:
Date: Thursday, 2 July 2026
Time: 15:00 UTC (agenda starts at= 15:05 UTC)
Join: https://meet.jit.si/XenProjectCommunityCall

We'll open the= room at 15:00 UTC and begin the agenda at 15:05 UTC to give everyone a few= minutes to join.

Want to be CC'd on future calls?

Add or= remove yourself from our sign-up sheet:
https://cryptpad.fr/pad/#/2/pad= /edit/D9vGzihPxxAOe6RFPz0sRCf+/

See you tomorrow!

Best re= gards,

Cody Zuschlag
Xen Project - Community Manager
=
--000000000000c5384706558e5d83-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:30:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:30:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350174.1607725 (Exim 4.92) (envelope-from ) id 1wewtr-0005uy-45; Wed, 01 Jul 2026 15:30:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350174.1607725; Wed, 01 Jul 2026 15:30:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewtr-0005ur-1H; Wed, 01 Jul 2026 15:30:55 +0000 Received: by outflank-mailman (input) for mailman id 1350174; Wed, 01 Jul 2026 15:30:54 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wewtp-0005uj-Rn for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:30:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewto-003GHH-TZ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 17:30:52 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4532ac-e002-0a2a0a5209dd-0a2a4501c9a6-4 for ; Wed, 01 Jul 2026 17:30:52 +0200 Received: from [209.85.221.41] (helo=mail-wr1-f41.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4532a1-400f-0a2a45010019-d155dd29dc8c-3 for ; Wed, 01 Jul 2026 17:30:41 +0200 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-474560436c3so758602f8f.0 for ; Wed, 01 Jul 2026 08:30:41 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477de3dd0b1sm571782f8f.35.2026.07.01.08.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 08:30:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782919841; x=1783524641; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=PzuFWwDhr1bgrcQW7srPgbk5rjVNeVot/73Z7hmNgIk=; b=EWVz2g0yTOm8/wlDb485/3HpqO2VOmWmzK5rwdCQ5xKPSqe9UT4qZOcgp6FhLIHB3s 1IgPlBNaRi9x1UhZ8gn2YurydmgOOpBf5B2Ho+/WGMmti3eYrGFIZyO3rwbnLXaiqElp 9/URhg2vSyj7wO1v8Yp3ZyqRp9XxMwNSOodAq5DE8/WtIDmdtEWF45OmfEPptcW0AeKO fONNSuEzp6hXrUdSz0okIpRF0nceWVEpWv1WUezP3pIGBQoMmm4x3AtwAao4ss2sOEu6 srK6l5QT/BwwmCazV9dokerTe5kZLEQ9UR2dGNEQ6iUqMnPStkG16mC63eTTgfgeue6u mnbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782919841; x=1783524641; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PzuFWwDhr1bgrcQW7srPgbk5rjVNeVot/73Z7hmNgIk=; b=bEoe930Y5Dzfnz3YsnJr8+anc87bTUpWXzp2QTN27/USuxMV5IbOR4frtTEcaFpqGh IXvr/bCt93m6PgZKcgfUjVyaf5CWxMXuYtvwZWcLmsAM2w/RHtJHDRhBItHJ/vtn6EIs lV+J9zssx+BBSkFLpLUlKapRykKDL5JATZBiDwN0Ikg1/+g4m6gG45bLZxagsorBCasL nPh/KtmclDyrOH2dgUkDimJ2+1rG1Z09HAuDXFl7mlhpMgdFN9npJd9epAvTV/Q10FOo NOoippAthyQX14vASO3M5GepoRFjEpKEAiMjx47Ou5ik8ainYH1sFkRqoPJ0xTY8GdDn Yt/w== X-Forwarded-Encrypted: i=1; AHgh+Rr7yBKrIGTHK0JiqB0KoafMgAmzGL69fttQ5HW2arQrZcMDDrbYL+gLFnXVVxk9flUgmaIC0uV7ZBE=@lists.xenproject.org X-Gm-Message-State: AOJu0YyVku1FSpqgGVjn46nkNgpCO1YJ7P8QNHJpBTy+xyXjYNW8G3aq r5WueGQFvut+lelB1H7KcYhCDGe1j9yl3L3fRWgFm/ifV4gmU9qGVS8P X-Gm-Gg: AfdE7cmQPb6h6A3ZDAYBV5r9SCrNCF3aVYYRzWgpdW57uAkVBR3fsATTdceobJQXsvn BP6ka6Rn2EkNXj3XWZFWRCEsw1DGVoRQgRH0lM4e4X3HLItev49I7W4bLcQPkS5Id2JvPbMRigZ ph4a92vw7Tu/JNGC49fzEd9qRcKA3Sf8mjPvj/4rLU9MHSyr9utv3U4/nxgP2FvJxOC/dpQ+3X0 b9uxDf6NHIZb8iIRbjoP2/wHsCKZV6velgCyeZcRIz5oLq4Xe/7va1NMNIZJEjaFjqHS5RRwnJB B6eG9I3IPfDRldcJ5+mIernbPLXhFFcvgASHusYEDj8BMx1yIfGRWpO1Y5N/zcjynY0jGlwhNuy 737oz3b/nSpDYzuchMEL5vp/PXRPNGnXpOPjacR33Oeeqdfwy3NLd+C9E5mJr1cKYyjjN+xj45R FzqaCnTh+RnTJt8dA31+qpr99FzNZRggUXgrX+SS8XCLyNzuEAbJEo9VuVhhZmPt0yvkQ= X-Received: by 2002:a05:6000:18af:b0:475:f0d1:eb55 with SMTP id ffacd0b85a97d-477b1aa2fefmr1804109f8f.48.1782919840832; Wed, 01 Jul 2026 08:30:40 -0700 (PDT) Message-ID: <8808a658-0172-4af6-a6dc-6c975d0e5c34@gmail.com> Date: Wed, 1 Jul 2026 17:30:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] xen: introduce CONFIG_HAS_SHARED_INFO for archs without a shared page From: Oleksii Kurochko To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , xen-devel@lists.xenproject.org References: <775c88457e5ec7fc7889002c6f9829669f9bce97.1782388193.git.oleksii.kurochko@gmail.com> <5d344cec-bb97-4d3b-87ff-e7175772fd45@suse.com> <0e2a8eab-366f-4384-a467-43f051d047ec@gmail.com> Content-Language: en-US In-Reply-To: <0e2a8eab-366f-4384-a467-43f051d047ec@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1782919841-80CD61E0-70DF2864/10/73395122804 X-purgate-type: spam X-purgate-size: 3614 On 6/30/26 5:02 PM, Oleksii Kurochko wrote: > >> >>> @@ -55,6 +59,7 @@ struct evtchn_expand_array; >>>   int evtchn_fifo_init_control(struct evtchn_init_control >>> *init_control); >>>   int evtchn_fifo_expand_array(const struct evtchn_expand_array >>> *expand_array); >>>   void evtchn_fifo_destroy(struct domain *d); >>> +void evtchn_fifo_init_ops(struct domain *d); >>>   #else >>>   static inline int evtchn_fifo_init_control(struct >>> evtchn_init_control *init_control) >>>   { >>> @@ -68,6 +73,7 @@ static inline void evtchn_fifo_destroy(struct >>> domain *d) >>>   { >>>       return; >>>   } >>> +static inline void evtchn_fifo_init_ops(struct domain *d) {} >>>   #endif /* CONFIG_EVTCHN_FIFO */ >> >> Unlike these two. Which raise a different question though: What will >> be the >> behavior when EVTCHN_FIFO=n and HAS_SHARED_INFO=n? Taking >> evtchn_alloc_unbound() as example, afaict evtchn_port_init() will stumble >> over a NULL pointer. Looks like for that (and only that) case we still >> need >> your earlier dummy fallback. > > I will introduce dummy fallback (I will shrunk some stubs in final > version): > > +#ifndef CONFIG_HAS_SHARED_INFO > +static void cf_check evtchn_none_set_pending( > +    struct vcpu *v, struct evtchn *evtchn) {} > +static void cf_check evtchn_none_clear_pending( > +    struct domain *d, struct evtchn *evtchn) {} > +static void cf_check evtchn_none_unmask( > +    struct domain *d, struct evtchn *evtchn) {} > +static bool cf_check evtchn_none_is_pending( > +    const struct domain *d, const struct evtchn *evtchn) { return false; } > +static bool cf_check evtchn_none_is_masked( > +    const struct domain *d, const struct evtchn *evtchn) { return true; } > +static void cf_check evtchn_none_print_state( > +    struct domain *d, const struct evtchn *evtchn) {} > + > +static const struct evtchn_port_ops evtchn_port_ops_none = { > +    .set_pending   = evtchn_none_set_pending, > +    .clear_pending = evtchn_none_clear_pending, > +    .unmask        = evtchn_none_unmask, > +    .is_pending    = evtchn_none_is_pending, > +    .is_masked     = evtchn_none_is_masked, > +    .print_state   = evtchn_none_print_state, > +}; > + > +static void evtchn_none_init(struct domain *d) > +{ > +    d->evtchn_port_ops = &evtchn_port_ops_none; > +} > +#endif I will shrink it to:: #ifndef CONFIG_HAS_SHARED_INFO /* * Placeholder ops for domains with neither a shared_info page nor (yet) * a FIFO control block. None of these are ever reachable in practice; * they only exist to keep d->evtchn_port_ops non-NULL. */ static void cf_check evtchn_none_set_pending( struct vcpu *v, struct evtchn *evtchn) {} static void cf_check evtchn_none_noop( struct domain *d, struct evtchn *evtchn) {} static bool cf_check evtchn_none_false( const struct domain *d, const struct evtchn *evtchn) { return false; } static void cf_check evtchn_none_print_state( struct domain *d, const struct evtchn *evtchn) {} static const struct evtchn_port_ops evtchn_port_ops_none = { .set_pending = evtchn_none_set_pending, .clear_pending = evtchn_none_noop, .unmask = evtchn_none_noop, .is_pending = evtchn_none_false, .is_masked = evtchn_none_false, .print_state = evtchn_none_print_state, }; void evtchn_none_init(struct domain *d) { d->evtchn_port_ops = &evtchn_port_ops_none; } #endif /* CONFIG_HAS_SHARED_INFO */ ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:34:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350184.1607735 (Exim 4.92) (envelope-from ) id 1wewx0-0006dt-K6; Wed, 01 Jul 2026 15:34:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350184.1607735; Wed, 01 Jul 2026 15:34:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewx0-0006dm-HO; Wed, 01 Jul 2026 15:34:10 +0000 Received: by outflank-mailman (input) for mailman id 1350184; Wed, 01 Jul 2026 15:34:09 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wewwz-0006dN-4z for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:34:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wewwy-003t4z-Hy for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 17:34:08 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a453368-5cb7-0a2a0a5109dd-0a2a450ba044-24 for ; Wed, 01 Jul 2026 17:34:08 +0200 Received: from [209.85.218.53] (helo=mail-ej1-f53.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a453370-ac48-0a2a450b0019-d155da35f0b4-3 for ; Wed, 01 Jul 2026 17:34:08 +0200 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-c12788a75abso163290566b.2 for ; Wed, 01 Jul 2026 08:34:08 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f4771csm292906366b.42.2026.07.01.08.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 08:34:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782920048; x=1783524848; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=P6tGDWGopQmmnMhTuYZl5huHumnoFIX3aXzPovHMf/M=; b=B+16iffabuuHCREjjK3jBiLoBEQqDuz2qx1CX7UgAa4rjz9867bBk0RtYpG2AOwe9W y2qOpspFNJWUxMMJmtxk/ZAhK1prYjmke9a5d+h9cIS+ZYJW4VMpx+O/umJSNTebjY1j wfcmO2e3Tz9ZaT9PNOFWs+gVe9/+BhMVboo4il7jBLHR/+Jk8STyoShaj74Bit9ojP3v JUjaJMgYulO9eLtdzWeCKblQ1vuzwqe0yhgdLXZSYzxIEct7+rQcQVS55+EkuX1nv5po FrM5emqO/sF6OofqXH0CJwa7ZodNdT1HEW3l52bbkwSR9GBXvEcnU+PRB6/6kA+E6g8W tDIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782920048; x=1783524848; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=P6tGDWGopQmmnMhTuYZl5huHumnoFIX3aXzPovHMf/M=; b=pFd+gfDqCOjFUmM4Sy/p//hWLFHzQu8Ch4dv6iCuDCx6KBbWS4vAxrGof1D32EIdHt 7fG3xzZWcqag8FMaaUmzolgSij6idbhAiiM5OFLp4QdNulSKJ7Rxs6pQ13S/2CWwjU98 Ptxg+wEW2OK81A260vounEvG6m/SmFUZLLH7y126/FJHAYIgB9vgy2QIOQmhMRXBEsLP nFD6K93A8UaQH4TM7cT+LGDVJEpt5p1sH623/5qHLtFySLUwUaniyqaOUb29De19/kwC 8j7gmIgqbnFFDgwyjKRCxkj2oSmeJzl+iBh3X1uXyPql4N956gq3YMImm53VETakpiRF 5U7Q== X-Forwarded-Encrypted: i=1; AHgh+RqkJIBUXc94LvRUuPP3e74x05TakncXkKyN3dmbNeg3C1TJVfbupqkjaUSLYv+OLRYh5a3vY+v83LE=@lists.xenproject.org X-Gm-Message-State: AOJu0YwEM7Ae0aeybnamrozYVoMbHqoTsi81kJU5baWADykaJR3ynyqj vag4s7CgQCROPCrpltwVoLLIjd79pfCOLN1ToxHAQasD1aD3QWVs9OC1sF2Tc+l/tjw= X-Gm-Gg: AfdE7cnLqAxR48NGe8BLFVRjnaNwKcAUqO9D2HlCsOEJiRuzEdSsYD3UxoMNbDoVkEE Jp1L3xYjX/8atal+7YeAlXqlpP8KVogeNe1bJ6cyTKEXTOXrDvr6bTY2DliLbtcrDaxPU5aoroT oxLe+q/miIlcBK2ekFlSD5qGyy1BdnHmv4eFKx6rrHv7iro6/+B90ZPnfwbam3jxIYojTepq6ir cEATkObsCmaaROio6KFyFmFtQB13Q4TRafKftbT6/qQyQgt1GzPsHHpO2eVYMb0fV8ItdGFVJ3m OHhnDrbwTvdekFzsaz/ZfsEpJzznr5/w/n56HAwpDGdEjc0GvJxBrl719gfpbTXNaLOZNZPqvjp lrZ8RSg6f3R4vzpz1udbZm0aWMYERJ+bAZE9AlTM6SyPcXBORJKHyJ8wv5B9rsQABlrJCIJuliE ScKAMqKsTvWmXBFiTrFRsHCRrL5dod2cvqIPhAB02rpnslwta0Tvdy1otbIz+0prwquSnxE0R0+ LK1fv242NPQEpH9SIUCKeYsVkyNKeLENa+DKQEN0D8= X-Received: by 2002:a17:906:f8cf:b0:c12:34f0:f7bf with SMTP id a640c23a62f3a-c12ae798209mr50864066b.62.1782920047863; Wed, 01 Jul 2026 08:34:07 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 17:34:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------sPrRxO3j4RhjJxr3HW9iP0V5" X-purgate-ID: tlsNG-42698a/1782920048-A7732220-7BFC841F/0/0 X-purgate-type: clean X-purgate-size: 8723 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------sPrRxO3j4RhjJxr3HW9iP0V5 Content-Type: multipart/mixed; boundary="------------yE7QNpFhXJ3EXiiZ6MI7lST4"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> In-Reply-To: <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------yE7QNpFhXJ3EXiiZ6MI7lST4 Content-Type: multipart/mixed; boundary="------------JmJaX0lAzmNAk3fszHAkFwwL" --------------JmJaX0lAzmNAk3fszHAkFwwL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDcuMjYgMTM6MzksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMS4wNy4yMDI2 IDEzOjE2LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVG9kYXkgdGhlIFhFTl9ET01DVExf c2V0dmNwdWFmZmluaXR5IGh5cGVyY2FsbCB3aWxsIG5vdCBvbmx5IGNoYW5nZSB0aGUNCj4+ IGFmZmluaXR5IHNldHRpbmdzIG9mIGEgdmNwdSwgaXQgd2lsbCByZXR1cm4gdGhlIG5ldyBl ZmZlY3RpdmUgc2V0dGluZ3MsDQo+PiB0b28uDQo+Pg0KPj4gSW4gY2FzZSBhbiBlcnJvciBo YXBwZW5zIGR1cmluZyB0aGlzIGh5cGVyY2FsbCwgdGhlIGV4cGVjdGF0aW9uIG9mIHRoZQ0K Pj4gY2FsbGVyIGlzIHRoYXQgdGhlIGFmZmluaXR5IG9mIHRoZSB2Y3B1IGRpZG4ndCBjaGFu Z2UuIFRoaXMgaXNuJ3QgdHJ1ZSwNCj4+IGhvd2V2ZXIsIGlmIHBhc3NpbmcgdGhlIG5ldyBl ZmZlY3RpdmUgYWZmaW5pdHkgYmFjayB0byB0aGUgdXNlciBpcw0KPj4gZmFpbGluZy4NCj4g DQo+IFRoYXQnbGwgYmUgdGhlIGNhbGxlcidzIGZhdWx0IHRob3VnaC4gQW55IC1FRkFVTFQg Y29taW5nIGJhY2sgYXJlIGFuDQo+IGluZGljYXRpb24gdGhhdCB0aGUgY2FsbGVyIG5lZWRz IGZpeGluZy4NCg0KVGhlIHBvc3NpYmxlIC1FTk9NRU0gaXNuJ3QgdGhlIGNhbGxlcnMgZmF1 bHQsIHRob3VnaC4NCg0KDQpKdWVyZ2VuDQo= --------------JmJaX0lAzmNAk3fszHAkFwwL Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------JmJaX0lAzmNAk3fszHAkFwwL-- --------------yE7QNpFhXJ3EXiiZ6MI7lST4-- --------------sPrRxO3j4RhjJxr3HW9iP0V5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpFM28FAwAAAAAACgkQsN6d1ii/Ey+d NQf+JC6prGWZ8sKBbSJnnBE/Wr7ccMwmGCGrQja5wKtxWKGc94IeyuGRI4WQ3jiaXideyuR/Eump c2TETtVFEljYaN5C1WadK3RtIrq/TfrMMyALOZYso2MPt+ndcvoAlEkcccFSKblQZhT/ifjnZBOi 8rKH9jD8edYFDgGRoqZYwi+h1H3hr0cGpOEIKGgiv6U8x47D2klV4mU33Axgh3f2EjnCBkXq/sUA sE0F1/P48BAU4V61mprOPwFePhvB1QNNi2TRyV5uen9vKfCHNjMC7Dos2kxN4YaztO8SJDXnXZrZ MDuj/crts80EpM+ubzs+Ic0FOy0pZTrYpmBvHqVCPw== =1zOU -----END PGP SIGNATURE----- --------------sPrRxO3j4RhjJxr3HW9iP0V5-- From xen-devel-bounces@lists.xenproject.org Wed Jul 01 15:49:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 15:49:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350205.1607744 (Exim 4.92) (envelope-from ) id 1wexC8-0001N2-Tn; Wed, 01 Jul 2026 15:49:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350205.1607744; Wed, 01 Jul 2026 15:49:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wexC8-0001Mv-QY; Wed, 01 Jul 2026 15:49:48 +0000 Received: by outflank-mailman (input) for mailman id 1350205; Wed, 01 Jul 2026 15:49:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wexC7-0001Mp-JZ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 15:49:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wexC6-003vPF-Ca for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 17:49:46 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a453711-e002-0a2a0a5209dd-0a2a4501e270-16 for ; Wed, 01 Jul 2026 17:49:46 +0200 Received: from [40.107.208.19] (helo=PH0PR06CU001.outbound.protection.outlook.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a453717-400f-0a2a45010019-286bd0138a9f-3 for ; Wed, 01 Jul 2026 17:49:44 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by SJ0PR03MB5805.namprd03.prod.outlook.com (2603:10b6:a03:2df::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 1 Jul 2026 15:49:41 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Wed, 1 Jul 2026 15:49:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G+LNIGdI8DRjVTkNwH9lCZtkEQKHauUXSnxgtw01x0+CLEyIsfV78D5UFutBMKz4sUc+ZeXSiUwqF9yJyereYVUDvwwVkzVPfrQLasc15UrxRGZYfal8Z4rrnrKDjkTbhRgZo5EHmVglR3VNyI6ZiJdT3XCxejAWt4LWvwtm5XmBHmXtP+paANkcAEEUOSS9U2nq8vTn+KY00ef6/AWWTBEh35yRuZU9nR6qkKJwpV1o1IrXEDUJS6798VDV7DsBACcMdQaJF56PGuzFOZm7snpNG0cuBHo5FO9WlpvoUxL6hEu9T+fBiCNvN27JR+cMmyt6tyEtITwlDPqjG03tvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1gKsCNQ5LpJgewCViFf6a2Fi0hn7CDK6/H43Ro6vcjc=; b=LMlZmxay5Pf8Gfh86EzR8wt6xstyAge9AXm0EJb8Zpr5RPWILwA8GHDfHPreGm33Nv18cc/JJn2+xaUwKbZhYy4fCDkxEDSYjiXcS3TxXQRizZtqsV5tp91NI0KS7dwPr3xZaKVpsCCbf7PBgAwRhKhJnATNiMCshDvE8tAjmHpvDse8F/MA+8/8HhFWW2qnM8ZvXpDNKRja+eWkOu3d6Xr93ZYKJ/EtW9fUzOGdGmoKtWm8V5EE2tsjron5W59Rdo5wrwMuWUEXEC7sMutzDwhGL2IpwDc+GcA+AG8Z+HTv9yOlkFy3A1M1Sr5tYxa6kGR/iOHzfFkiIADiOlM2Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1gKsCNQ5LpJgewCViFf6a2Fi0hn7CDK6/H43Ro6vcjc=; b=qeWvOLGMBY1xq7EQDZB+CHgDJyTBq9lZFh3XBDb8QHK28kV2KS2exzGNg9NAJJsajODLr0XHQTpiMzyXKokK1g+Eb//olGx0WagLeL5rpnt+8SvZmfvBuqe2qcyZxA/pdQ6L/gDj6tsgjakQ+4/qKC8faILwnTphoxR0/5GcQC0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 1 Jul 2026 16:49:38 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Anthony PERARD , Samuel Thibault Subject: Re: [PATCH] stubdom: remove c-stubdom To: Juergen Gross , xen-devel@lists.xenproject.org References: <20260701144259.4077884-1-jgross@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260701144259.4077884-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0254.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::18) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|SJ0PR03MB5805:EE_ X-MS-Office365-Filtering-Correlation-Id: 9333feeb-00a1-4c72-ca10-08ded7885d4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: T3NHbcjUug2ONyrzNeycljCaHaa2Ed2ab7JWJ/izKx6ByUax7E4dxZUZawl/h/3xf/oD0sKxW7/R6j5CMftGk6UzD5NQ7+zAGjdM5d3Zw88F4vijEaMfmoq6umIdUH1LmH2C7XkfsZyZ4I6n3N45jWejqMJd1DvmWD4l+ASnHiPhmBIkNs6qX/kXRht6RuwIu3oUv6Zn7QSqS2TcuZkCQym4SG5LEhY7WL6MxYwiS5UvPQjPFadzic+yByt/0Hucpv6twNR61mcK5iFdc50bnhmIj00JtEBQY4dfREtcXhKctljc84bcUrsGqFT1OQAqHP4eIZlXU7W6fljhpwMhgFseRP+VilygILmQZFjGQ7VDZGn1XJwGqxt9HC3Ks4whbK9nK7eSuuAbGSjZ7EvU6Az8RqTk4rTO7NOXDnqM1ytiReg4sK0Fpnk/Ryu8b1Ohe0WEukNZTHTDuSM6DuAHrL8BRfXMi5F1xwCNLzeSSfDa8tBQ0bp8831QUPO0eTbSGs/hpw3LrRkNxKin7fnARyl4X74i7WHbSj0XqADK8QfhMpr9l3hzwvpTi1rTz4F1R/5B26NaFnentuBSSLoZ4OoBef9SYROJGhdHS1wD3/B42NAy0WwGHamE5x7NhJSkg74KoqpnljtN9v8SV6rmVOuC4y4gS0bQ4V2CymBBcEA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blROMmx1RS90Zkl1NzFlM0FyKzdtTnkwRGRXQTR3ZGRNMm1WekV3YmhFY0o0?= =?utf-8?B?QU9kRmZsOHVVQ1pVL1c2cERRV0lzd01oVHk5Z3FQNW55WjBWNXp6RDUvVXVx?= =?utf-8?B?WE1JWGZ0SDdibUJNcHQ4ZUhUaWNTT3N0cDJCWHRMUHZCeTBuenpJRlBjVERa?= =?utf-8?B?V3QxWHp5bk9TS3NsNEVJY2NzL05WOXZCOGh4ZmI2dG9vTjZVUTdiRklVc0hr?= =?utf-8?B?MHM4UzNyd3hiem1KQ2d1ajl0MGFPY1d6azZhQWxoanJPVTlPazMvTUgzSHl6?= =?utf-8?B?RDU4QmIxWXY2N2M0WjNSNERZNjliRU5pUG1ZTm9XTHE0Lzc1clhITS94MmtO?= =?utf-8?B?b2xOVGNrTVk5emNrUDB3WkJZU3UxaCsxMnN3TzNOdFc4RkNkcTN0c0VxMU00?= =?utf-8?B?OU5iS1dTMXpQUWpocXNOMmhaYXFDVHF1NWQzdlJpOVk5RWZCN3JZRm1kc3Rq?= =?utf-8?B?cFE5bFJvU2FUaTc2QTVYTnZnKzJGWUZnV0xXc2pscFp1TytsRUpjbEI2a3g4?= =?utf-8?B?T3hKQkRBUjdXOFdYUlg5QUtFN3JjMEpjMVhDZWNmY28wM3JLRTJEQnVnblpY?= =?utf-8?B?ZXhmVm5EcjQzTnowdi9ZMUtoTmRHaGJnRU1IbzF5eWpxM2svYWFPREFzMm4v?= =?utf-8?B?ZEFYemF6cXMraSt5WnBrWmp3aWcvK2lCUVJ4OXRjcVMzOWFQRnQ4V3hseUNq?= =?utf-8?B?V1ptcHY0UXg5b2RSbWlWcUhvOWNSbTNidFdRaVlHaGxuMUhSbXlna0pvMWRZ?= =?utf-8?B?SEVFd0ZrUDNQL3ErWVhsRTFlcXVsNlpVcmlsZSs4amtvWDY4VTNQSWFabjhm?= =?utf-8?B?WWpMdXllckRYL09pVEtmU2lVR0dlc1lCbzZSalNLdU5FTUZDLzViR1FsYkVS?= =?utf-8?B?WGtCTTExNS8xczI0cG5DbXpLeE5pNEFPaURNdXZIdDhvY1Y3ek5QT3hlVkVZ?= =?utf-8?B?b1Ayc1QvZjhCQjdwbWgxbVZqM3RMOHJUU2J5akRpeXJZc2RWbDArRVU5WEdR?= =?utf-8?B?dkxNaG90V29TVTUyVmpRS0NaNEl6VjgxWWtPZG5UU1ZwVFQyRTZmaEJRUUt3?= =?utf-8?B?SnJ4NXk2TWdHV2plVzk0RTZvaFdhZUZkSENRSzlBN2NTc21sWExNNFJ2Umxs?= =?utf-8?B?OWYzdzdOV1dxRGtBT1E0TmhKb0lEQ2swWTNsUTRJVHNKeFlneE5SQkxGNzFz?= =?utf-8?B?UlJjdXNDYUFZWUNScmZuU29lRkY4T0NMclFDZnBCdmNSMDNKNGVvRW10c1BU?= =?utf-8?B?T01mZXIxd2pqTjI2MzlVU2RZZzg2ZXFZVmh6ZW81RTZ3YVRUMG9xemVVSURh?= =?utf-8?B?WkNJVGtXaVJkdW5YUzZ4MjJadk1FblZ5S2FHSlZyNGRzY3hhN0c3YWdPZ2ww?= =?utf-8?B?dDVvd0h0Q2pqZHNrRGZOWlFycDRYNk9jaDFISUJJN3RqeFMzbWEzbVBJc2Zv?= =?utf-8?B?dXRwWkQrR0ZmU3YvS3pLNVZqelAxS1JQS3FGSHRhbE10NTBidDJidnJxdXh5?= =?utf-8?B?OC9Xa0FPWDc1UUtqd3NZVm9FU2lIMmFva1VUTWJjUlp4dXZ2Z2hSUjZNZmtj?= =?utf-8?B?eFR1K2p2ZjlIRWEzcUtKU3ZzZlJVai9RL2xWYTloZXd1SUtKSnlER3M3NDhQ?= =?utf-8?B?L0h6cXVPSG5pSys3c1QyQjE2RlNKcklidjcxYkNLUk8xUGc0K01PYnVnZVB2?= =?utf-8?B?Nkp2eEV4WkdBdHFKT3hlT0VIMDlTZ0RXalVJdGxaZmordUwxVTJTcXlOTmZx?= =?utf-8?B?VXJDOHFYZEpWbUkxUnZBTXU5cVFTR29aS0FKSGhjblFpaTRQbUVxVTE3Ump1?= =?utf-8?B?OEVVU0JsVnZrOHF4ZVZHd0FRbnJLSzJEdnppaGlXMnEwQnhFWWtuemc4T2My?= =?utf-8?B?cDFJRlptcHZXVzdEVEYyRTNJN1VKYitnNGlvbXhiNnRzMFdmanlCeWxhbSs4?= =?utf-8?B?Sjd6WDZDYTJyTXdEcnhqZXZYei9HWVEzUTRLczZqVlFMMVR2ZFhsTmxlYjE5?= =?utf-8?B?dFdRS2RwQUNSQWZhbnpjNzRKbm9jVmdyaTUzUGhFbFZMaHpUS1FmcFZPYVVO?= =?utf-8?B?OGcydWpaVnVHZVc5R0JySmdSUTh4KzM4M09JTGgrclVSbmdmcFlkZEFTenY4?= =?utf-8?B?Wi82bkxuQmNHWldLQUZNcDZIRllLRjA3U3dqdGNQMkhvQ2QvS0FqdzNSanNO?= =?utf-8?B?TGRLYmh2OVREUEhEZlhLODdJandLcXVXZnM3TVRKaTBlK3FpQVZrZFhWcXYr?= =?utf-8?B?SEJqazR0VFdBTFg1R0E4Q0RRN0FEcU1IdVlhbFMvVEFyMm5lU2UzMFBtcUpy?= =?utf-8?B?Q3J6TDNYSVdiZVBmdFo5YUVubkhyODRENkJSa3pNQy80L1N3U1N6cFZrc1FM?= =?utf-8?Q?2G8haQwhYfOFa6NA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9333feeb-00a1-4c72-ca10-08ded7885d4c X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 15:49:41.5046 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uaEi7DFk0yB6fkSCJ4jhGTrz1nAM0u+J7mJLEUsErTpN5o6I1ksARzs0ubteyP/vnFIwUO3KXig9Z4X6pMUjiC2oPZYykaM7XE0boOKSKJQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5805 X-purgate-ID: tlsNG-d62444/1782920985-D04D51E0-38BF478C/0/0 X-purgate-type: clean X-purgate-size: 894 On 01/07/2026 3:42 pm, Juergen Gross wrote: > C-stubdom was meant as a base for building new Mini-OS based stubdoms. > It hasn't seen any work for many years now and creating new stubdoms > should use UNIKRAFT instead of Mini-OS. > > So remove c-stubdom. > > Signed-off-by: Juergen Gross I didn't even realise we had one of these... Acked-by: Andrew Cooper > --- > stubdom/Makefile | 19 ------------------- > stubdom/c/Makefile | 13 ------------- > stubdom/c/main.c | 8 -------- > stubdom/c/minios.cfg | 2 -- > stubdom/configure | 44 -------------------------------------------- > stubdom/configure.ac | 1 - > 6 files changed, 87 deletions(-) > delete mode 100644 stubdom/c/Makefile > delete mode 100644 stubdom/c/main.c > delete mode 100644 stubdom/c/minios.cfg CHANGELOG.md too. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 01 16:09:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 16:09:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350222.1607752 (Exim 4.92) (envelope-from ) id 1wexVT-0006Js-De; Wed, 01 Jul 2026 16:09:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350222.1607752; Wed, 01 Jul 2026 16:09:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wexVT-0006Jl-Ax; Wed, 01 Jul 2026 16:09:47 +0000 Received: by outflank-mailman (input) for mailman id 1350222; Wed, 01 Jul 2026 16:09:46 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wexVR-0006Je-48 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:09:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wexVP-004NWc-Q4 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 18:09:43 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a453bc5-2eae-0a2a0a5409dd-0a2a4501ad46-6 for ; Wed, 01 Jul 2026 18:09:43 +0200 Received: from [91.218.175.177] (helo=out-177.mta0.migadu.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a453bc6-400f-0a2a45010019-5bdaafb14fbb-3 for ; Wed, 01 Jul 2026 18:09:42 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782922180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=32k3xy2qoDs5v558QiIXDOBJrw4XcLaI228zHYcvJQI=; b=GKsigi9jw5iEZkRAOu0U35OCwwNX+WFYQBJnw1VnjqCFwAV1xkeG5HVPPXjVerUIFCpvkl 1sYFG/+4cZNO5RnH+3ZGNEajZyzEn2vDXqeNcTTch6ZM0ZT3P4Eo/8D1DaouN8eSB+B2FA bvbtO9Gx6J4K8rZ0y4m06I1Z9Hu4ibM= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 12/13] mm/mprotect: convert mprotect code to use vma_flags_t Date: Thu, 2 Jul 2026 00:09:17 +0800 Message-Id: <20260701160917.91435-1-lance.yang@linux.dev> In-Reply-To: <7ef626d8a12dc742cfc09d080be5dc09850e873a.1782760670.git.ljs@kernel.org> References: <7ef626d8a12dc742cfc09d080be5dc09850e873a.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-d62444/1782922183-816DB1E0-514658A3/0/0 X-purgate-type: clean X-purgate-size: 4048 On Mon, Jun 29, 2026 at 08:25:35PM +0100, Lorenzo Stoakes wrote: >Replace use of the legacy vm_flags_t flags with vma_flags_t values >throughout the mprotect logic. > >Note that we retain the legacy vm_flags_t bit shifting code in >do_mprotect_key(), deferring a vma_flags_t approach to this for the time >being. > >Additionally update comments to reflect the changes to be consistent. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- > mm/mprotect.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/mm/mprotect.c b/mm/mprotect.c >index 9cbf932b028c..c9504b2a2525 100644 >--- a/mm/mprotect.c >+++ b/mm/mprotect.c >@@ -40,7 +40,7 @@ > > static bool maybe_change_pte_writable(struct vm_area_struct *vma, pte_t pte) > { >- if (WARN_ON_ONCE(!(vma->vm_flags & VM_WRITE))) >+ if (WARN_ON_ONCE(!vma_test(vma, VMA_WRITE_BIT))) > return false; > > /* Don't touch entries that are not even readable. */ >@@ -97,7 +97,7 @@ static bool can_change_shared_pte_writable(struct vm_area_struct *vma, > bool can_change_pte_writable(struct vm_area_struct *vma, unsigned long addr, > pte_t pte) > { >- if (!(vma->vm_flags & VM_SHARED)) >+ if (!vma_test(vma, VMA_SHARED_BIT)) > return can_change_private_pte_writable(vma, addr, pte); > > return can_change_shared_pte_writable(vma, pte); >@@ -194,7 +194,7 @@ static __always_inline void set_write_prot_commit_flush_ptes(struct vm_area_stru > { > bool set_write; > >- if (vma->vm_flags & VM_SHARED) { >+ if (vma_test(vma, VMA_SHARED_BIT)) { > set_write = can_change_shared_pte_writable(vma, ptent); > prot_commit_flush_ptes(vma, addr, ptep, oldpte, ptent, nr_ptes, > /* idx = */ 0, set_write, tlb); >@@ -811,8 +811,8 @@ mprotect_fixup(struct vma_iterator *vmi, struct mmu_gather *tlb, > vm_unacct_memory(nrpages); > > /* >- * Private VM_LOCKED VMA becoming writable: trigger COW to avoid major >- * fault on access. >+ * Private VMA_LOCKED_BIT VMA becoming writable: trigger COW to avoid >+ * major fault on access. > */ > if (vma_flags_test(&new_vma_flags, VMA_WRITE_BIT) && > vma_flags_test(&old_vma_flags, VMA_LOCKED_BIT) && >@@ -886,7 +886,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > goto out; > start = vma->vm_start; > error = -EINVAL; >- if (!(vma->vm_flags & VM_GROWSDOWN)) >+ if (!vma_test(vma, VMA_GROWSDOWN_BIT)) > goto out; > } else { > if (vma->vm_start > start) >@@ -894,7 +894,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > if (unlikely(grows & PROT_GROWSUP)) { > end = vma->vm_end; > error = -EINVAL; >- if (!(vma->vm_flags & VM_GROWSUP)) >+ if (!vma_test(vma, VMA_GROWSUP_BIT)) IIUC, should this be if (!vma_test_single_mask(vma, VMA_GROWSUP)) instead? #elif defined(CONFIG_PARISC) #define VM_GROWSUP INIT_VM_FLAG(GROWSUP) ... #ifndef VM_GROWSUP #define VM_GROWSUP VM_NONE ... VM_GROWSUP is only defined as GROWSUP on parisc and becomes VM_NONE elsewhere. But VMA_GROWSUP_BIT is the raw ARCH_1 bit, which is also used for other arch-specific VMA flags: DECLARE_VMA_BIT_ALIAS(SAO, ARCH_1), /* Strong Access Ordering (powerpc) */ DECLARE_VMA_BIT_ALIAS(GROWSUP, ARCH_1), /* parisc */ DECLARE_VMA_BIT_ALIAS(SPARC_ADI, ARCH_1), /* sparc64 */ DECLARE_VMA_BIT_ALIAS(ARM64_BTI, ARCH_1), /* arm64 */ DECLARE_VMA_BIT_ALIAS(ARCH_CLEAR, ARCH_1), /* sparc64, arm64 */ DECLARE_VMA_BIT_ALIAS(MAPPED_COPY, ARCH_1), /* !CONFIG_MMU */ Other vma_test() changes look fine to me: just fixed INIT_VM_FLAG() masks matching their VMA_*_BIT :) Cheers, Lance > goto out; > } > } >@@ -918,7 +918,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > } > > /* Does the application expect PROT_READ to imply PROT_EXEC */ >- if (rier && (vma->vm_flags & VM_MAYEXEC)) >+ if (rier && vma_test(vma, VMA_MAYEXEC_BIT)) > prot |= PROT_EXEC; > > /* >-- >2.54.0 > > From xen-devel-bounces@lists.xenproject.org Wed Jul 01 16:21:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 16:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350242.1607762 (Exim 4.92) (envelope-from ) id 1wexgk-0001OD-G6; Wed, 01 Jul 2026 16:21:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350242.1607762; Wed, 01 Jul 2026 16:21:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wexgk-0001O6-CD; Wed, 01 Jul 2026 16:21:26 +0000 Received: by outflank-mailman (input) for mailman id 1350242; Wed, 01 Jul 2026 16:21:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wexgj-0001Nz-IC for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 16:21:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wexgi-002ATM-2p; Wed, 01 Jul 2026 16:21:24 +0000 Received: from [2a01:cb15:80c2:5100:ab28:926e:d542:4784] (helo=l14.home) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wexgi-004Str-0r; Wed, 01 Jul 2026 16:21:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From; bh=1G8TPQ9nlhomp1gZxwftFAjMBKP13Qts8muVskspAPk=; b=3t3vfSSzcJ3uaQy3gSX087FhJM 0Ja44iWmuunYrVmkFzHpnOhfPx6EcnE7wUBv2/lmhG88Rahugenw8wUmTaEH49CXW0H8nqZtZYLKC Vt4psi5W8JZ6jBr39Nl6roVKS5XNztAnKFlrAWrTm1Cg6OmJKvpp1xj8B/u2RwWdxHhU=; From: Anthony PERARD To: xen-devel@lists.xenproject.org Cc: Anthony PERARD , Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [XEN PATCH] get_maintainer: Add maintainers based on keyword after removing THE REST Date: Wed, 1 Jul 2026 18:20:22 +0200 Message-ID: <20260701162022.30265-1-anthony@xenproject.org> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Anthony PERARD There's some logic to avoid CC committers (THE REST section) when a file is fully maintained by a list of maintainers. There's also some logic to add maintainers if a patch or file contains some keywords. We do add maintainers based on keyword to the list of $email_to before checking if we can remove emails from THE REST. And at the time when checking if we can drop THE REST, we've lost the information which tell if the maintainers was added because of a keyword of because they maintain the file. Reorder the logic, add maintainers based on keywords only after checking if we can drop THE REST. For example, if we have a file covered by a sections with only reviewers, but this file also contains the keyword "XSM", then: scripts/get_maintainer.pl -f $file would suppress THE REST without this patch. Signed-off-by: Anthony PERARD --- scripts/get_maintainer.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 533d0df72ac1..b788665c08b2 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -720,13 +720,6 @@ sub get_maintainers { $suppress_the_rest = 0 if $file_maintained_by_the_rest; } - if ($keywords) { - @keyword_tvi = sort_and_uniq(@keyword_tvi); - foreach my $line (@keyword_tvi) { - add_categories($line); - } - } - if ($email_drop_the_rest_supporter_if_supporter_found && $suppress_the_rest && $#email_to > 0) { my @email_new; @@ -748,6 +741,13 @@ sub get_maintainers { if $do_replace; } + if ($keywords) { + @keyword_tvi = sort_and_uniq(@keyword_tvi); + foreach my $line (@keyword_tvi) { + add_categories($line); + } + } + foreach my $email (@email_to, @list_to) { $email->[0] = deduplicate_email($email->[0]); } -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jul 01 18:41:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 18:41:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350332.1607799 (Exim 4.92) (envelope-from ) id 1wezrZ-0008RP-2w; Wed, 01 Jul 2026 18:40:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350332.1607799; Wed, 01 Jul 2026 18:40:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wezrY-0008R6-Ts; Wed, 01 Jul 2026 18:40:44 +0000 Received: by outflank-mailman (input) for mailman id 1350332; Wed, 01 Jul 2026 18:40:43 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wezrW-0008Qy-OY for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 18:40:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wezrW-003hhu-5a for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 20:40:42 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a455f0e-5cb7-0a2a0a5109dd-0a2a4507c504-32 for ; Wed, 01 Jul 2026 20:40:42 +0200 Received: from [65.109.113.108] (helo=mail.alien8.de) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a455f29-9c8e-0a2a45070019-416d716cb4c0-3 for ; Wed, 01 Jul 2026 20:40:41 +0200 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id EEC0B40E00BA; Wed, 1 Jul 2026 18:40:40 +0000 (UTC) Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 19fnkjO55P1L; Wed, 1 Jul 2026 18:40:31 +0000 (UTC) Received: from stx.tnic (unknown [IPv6:2600:1700:38ca:c00::1a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 18D6840E01B4; Wed, 1 Jul 2026 18:40:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=alien8 header.d=alien8.de header.i="@alien8.de" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1782931229; bh=weptln60tMwwD122PJFo5tc1DKGFh3noLSr54y5FDM0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dqyuEsjEVT9gyPjvdK0gB5x8udKkER2yawHRi+UQEK+nSKtnQR7DqxnnysUwrhZ4y GEGQkqI5XAFvG1t8U2Y0yVX0X96Dkhmh5EwnBm0uCgn64X5pR8kizQhepQrg5RJVfx qUeJHxhUmgPresH3hRbZyZh0kueU1Ju5NETJbOfwZhSqElniJL1AEnSpbjasfSFiE9 v/o+NI29PkbYU+rfKXFOWwxZXCYPQYqqGAQWQXhtRsJ1cTf+sfy2hx0FR9pco10cly DO6HZ62yBAjyi9FZFFsJKBYyglK/BjgeznIdmPdc5rFCzPqbQQcdKeQ5UGCYbMWjrG oHXEh4L4uZa6zbt8QFVTJ4hJ1YeAnJdvjaVt294z3OfoLJX6/uIbjQtwAnpz9MnYtl xiCxqS5jRHRFEfGjp25M4NiMFdoi9hguJiOpozhjTXhYeT+bnTVAeFzmnURNuvDo/3 SJT7xXGuQNk62DwNud+YNzMxR2um9INkkbFGvejhVA/Z95R+NSbczIl3Xr3lZ9NwvV saYsDBqdR4cu3TmYaZniJ6Vt2dYtVgh9o7L/WEgwSWqU1Xot15YB3RErxX11EJCFYC wSrHRfjccElKOiCbInvfFhymOEbedF0htWOg3udYoD9+y+m8vZWCrLx0sGwnZTKB1X eXAePUQovsvmfd1bdtheCQ+Y= Date: Wed, 1 Jul 2026 11:40:14 -0700 From: Borislav Petkov To: Mauricio Faria de Oliveira Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp Message-ID: <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> X-purgate-ID: tlsNG-ef75cf/1782931242-7C92A25E-D19B88E0/0/0 X-purgate-type: clean X-purgate-size: 2418 On Tue, Jun 30, 2026 at 02:21:46PM -0300, Mauricio Faria de Oliveira wrote: > Move the inline memcmp function currently only available in 'boot/string.c' > into the shared string function header to be reused. > > This is not done through to avoid pulling unnecessary code > in 'boot/string.c' that causes build errors in 'boot/compressed/string.c' > and 'purgatory/purgatory.ro'. > > Note that the inline memcmp() returns 0/1, not -1/0/1 as regular memcmp() > (reported by David Laight ). This belongs ... > > Signed-off-by: Mauricio Faria de Oliveira > --- ... here, if anywhere. > arch/x86/boot/string.c | 6 ++---- > arch/x86/include/asm/shared/string.h | 16 ++++++++++++++++ > arch/x86/include/asm/string.h | 1 + > 3 files changed, 19 insertions(+), 4 deletions(-) Also, PeterZ has a point - we should group all __inline_ functions into shared/string.h and say why that is the case at the top of the header. > diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c > index ac0f900ebc47efa81c92e1bb2010ea41677899c4..be454a6864225f3a972c3e81826b77ed4e8a57fe 100644 > --- a/arch/x86/boot/string.c > +++ b/arch/x86/boot/string.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include "ctype.h" > #include "string.h" > > @@ -31,10 +32,7 @@ > > int memcmp(const void *s1, const void *s2, size_t len) > { > - bool diff; > - asm("repe cmpsb" > - : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); > - return diff; > + return __inline_memcmp(s1, s2, len); > } > > /* > diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h > new file mode 100644 > index 0000000000000000000000000000000000000000..422952152f533ad75b98f3873297b39c4f5e2477 > --- /dev/null > +++ b/arch/x86/include/asm/shared/string.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_X86_SHARED_STRING_H > +#define _ASM_X86_SHARED_STRING_H > + > +/* Note: this memcmp() returns 0/1, not -1/0/1 as regular memcmp(). */ Please document it properly - what does 0 mean as a return value and what 1. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350366.1607835 (Exim 4.92) (envelope-from ) id 1wf0fh-0008Dw-EV; Wed, 01 Jul 2026 19:32:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350366.1607835; Wed, 01 Jul 2026 19:32:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fh-0008Dp-Bj; Wed, 01 Jul 2026 19:32:33 +0000 Received: by outflank-mailman (input) for mailman id 1350366; Wed, 01 Jul 2026 19:32:31 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3TGtFagYKCZEDzv84x19916z.x97Iz8-yzGz663DED.Iz8AC94zxE.9C1@flex--seanjc.bounces.google.com>) id 1wf0ff-0007zs-N1 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0ff-009wmK-3z for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:31 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3TGtFagYKCZEDzv84x19916z.x97Iz8-yzGz663DED.Iz8AC94zxE.9C1@flex--seanjc.bounces.google.com>) id 6a456b4a-e002-0a2a0a5209dd-0a2a45049d7c-14 for ; Wed, 01 Jul 2026 21:32:31 +0200 Received: from [209.85.215.201] (helo=mail-pg1-f201.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3TGtFagYKCZEDzv84x19916z.x97Iz8-yzGz663DED.Iz8AC94zxE.9C1@flex--seanjc.bounces.google.com>) id 6a456b4d-a01d-0a2a45040019-d155d7c9d5d3-3 for ; Wed, 01 Jul 2026 21:32:30 +0200 Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c890bac374eso1130211a12.1 for ; Wed, 01 Jul 2026 12:32:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934349; x=1783539149; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=LIZd+3O3352vjgCRNr7RtXOU8moEkEwJFa5rPF13Bys=; b=fWhuJTSH9F0LxNXwM51JmmDSaGne7DlthsbIvNEuy/j2XdAyRqR9wfSwo+I21iBh7l alzYdN+y9DKLhH4EMvZYYukJZ/Vxq1cOkBSLeC38n59EE4/lK049AJ+i4N9htV+rwsZj vxlkywhlNrYUhnFqumIktWVjxpdWQg+qBF2AID7v8n+Dz9M9BlE3Vr1VmJa2rTaAmZRD cJaHNPNG1PJhUfdGbfyChZbNQu+9u36XEc0z3YzNByewonYC7pib9kIrlyBYdNp8beYM mbn0oZGkDyE8Iby0HjeuRUMUfZ53hZDsoUx/t6MSTmxDKdkohSSkJoeNWGgl3IUTfX/B bNJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934349; x=1783539149; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LIZd+3O3352vjgCRNr7RtXOU8moEkEwJFa5rPF13Bys=; b=LT4edtyzfzfmyUJMZIzFuqrjURWffKZIRhvVTzsEmMynQ3z9gYSWRLw33W1Ca1p6YK 2EPnA8lc0mM7LDNSDN+ySO2v6Rnevc3p9XyU7kLvqXOBkJIR/2NDQgebUJIozzESCOYg S8qGFC5Ibsv9Qy5jy5TaJz14Kfw1dMO4PArR65IKUFiHVKKdRvyQmt8p7myyQ2perG2N 7ZsWTPLH1/nSC+FJI+UaWH0xaDjAw020vmsBnqjqgqXq3onYU5pwmoXKTnBy27XQlAge q6dnHR6m/oK/7xcv5xXn/aqg0L0BnVWJoZTupXwr+gvvJQDv256qO2Z5EqGU93CvkyhX LDTQ== X-Forwarded-Encrypted: i=1; AFNElJ9JhS2s1rzK5nRoIedvWNbWj5X9WFe6zdnKzFCFRo+kxYLfp1rT6y2Rp0ivjb3cvU2U8YcKw6uJSdA=@lists.xenproject.org X-Gm-Message-State: AOJu0YxfXHD9ClkzEbDct+vo+SXrq5AtVVi+9zrCpykad+EkTdFzOT+i DzkNQJQDIYsUMf/I9GGlb4ojJGZFZ9Yp3vlLqIlonstvTn0bBbGlCLkj6C1n7JK2+wOdZOvrnQ5 4Jcglpw== X-Received: from pgbcx9.prod.google.com ([2002:a05:6a02:2209:b0:c9a:eb48:4a8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:e196:b0:3bf:8604:9a3c with SMTP id adf61e73a8af0-3bfed3e9622mr3622600637.28.1782934348718; Wed, 01 Jul 2026 12:32:28 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:24 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-4-seanjc@google.com> Subject: [PATCH v5 03/51] x86/tsc: Ensure that TSC recalibration doesn't run if TSC frequency is known From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934351-AEB2B1CC-6C7722F5/0/0 X-purgate-type: clean X-purgate-size: 1418 When attempting TSC recalibration post-boot, which is only done for ancient CPUS (P4 and K7) on SMP=n kernels, assert that the TSC frequency isn't known (explicitly provided by hardware) by way of MSR or CPUID, and bail if the impossible happens. In practice, recalibration and TSC_KNOWN_FREQ are mutually exclusive, as TSC_KNOWN_FREQ will only be set when running on hardware that was released decades after recalibration was obsoleted, but but it's hard to see that, especially when looking at just the TSC code. Note, the WARN can likely be tripped by running in a virtual machine and concocting an impossible CPU model, e.g. by combining a P4 signature with CPUID 0x15. This is working as intended, as such a virtual CPU model is wildly out-of-spec and is not supported. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 4d6a446645c0..4393902c0ddd 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -930,6 +930,9 @@ void recalibrate_cpu_khz(void) if (!boot_cpu_has(X86_FEATURE_TSC)) return; + if (WARN_ON_ONCE(cpu_feature_enabled(X86_FEATURE_TSC_KNOWN_FREQ))) + return; + cpu_khz = x86_platform.calibrate_cpu(); tsc_khz = x86_platform.calibrate_tsc(); if (tsc_khz == 0) -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350364.1607817 (Exim 4.92) (envelope-from ) id 1wf0fd-0007mb-Tw; Wed, 01 Jul 2026 19:32:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350364.1607817; Wed, 01 Jul 2026 19:32:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fd-0007mU-Qo; Wed, 01 Jul 2026 19:32:29 +0000 Received: by outflank-mailman (input) for mailman id 1350364; Wed, 01 Jul 2026 19:32:29 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3SWtFagYKCY4Aws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 1wf0fc-0007Zv-SD for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fc-00Bw10-95 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:28 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3SWtFagYKCY4Aws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 6a456b35-bab6-0a2a0a5309dd-0a2a450a9d4e-16 for ; Wed, 01 Jul 2026 21:32:28 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3SWtFagYKCY4Aws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 6a456b4a-e40e-0a2a450a0019-d155d6cac001-3 for ; Wed, 01 Jul 2026 21:32:28 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c80f89b64bso15742295ad.2 for ; Wed, 01 Jul 2026 12:32:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934346; x=1783539146; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=esF5eJj/7ACJs9NShhG3o0+XzSBpzRsvPz4C7FhhKMM=; b=gbdGjLPvfSHGpnVGpCwK7ucojnV45lSdH+Lk6BO1No0nRwZavh8NOnaS9xwxrVSUXE UKdqxnMsYhWoqj/nIUbM9LSUjZ0iXgvN6d/qN0MkU6plvKrkwJ4wp3nao5phv+y9Gtsn cG8Z10qjKoBfQ+9fgdAD5mE9NsvU2uDW0eLnKvprKI6k7XSaw663hdOJgSZnKS2LddGx 7kvQJGJN9QsIeMcKg67ceih1NTnAdBvpkmPscJlI6AAI5l+XDXtdZgUjyhBAsp8pN1cQ 2h7fCh6OGZbg5aYcJLv1Ddeal1uJkTMMo4wLZx1fkyv8t9wPDl8kq2pWG8Y2JFthJQat /W0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934346; x=1783539146; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=esF5eJj/7ACJs9NShhG3o0+XzSBpzRsvPz4C7FhhKMM=; b=VXCxBsF8BhG427lMR8CuLR+esaGE2ZK+mJWQGnU8g5jrR23Xr80zf23ZH8Oh/4sXjv Jx0f/2pNMnrCn66oxcarM5g50p2ZfoFdXgmH5z5Bm33yiEHPdStbGdnhJJ66W/t45aRE bbvqdNPagI9VeufmOWxHlvJ0ImoVawJ39yRaDBajGPvvqR2GdpuE8pyoCEyQaLAfcCXq Wy6nZZJvL0ZN8DmcnsvJN93uc9YNMcD2EVPcX3xwy4Au2QrS3ZCYNY1HzcsUAcOqig1S VBP3/DNfun1TlPJYjoyOluR2lzjXKG4ByOfdPeY4e23DWdmCbMYzHD8qRddJ0nAxWmxS ymhA== X-Forwarded-Encrypted: i=1; AHgh+RpgXwACTmF8tJwt8dHwWZiyay5TdhXGy38D3TjidMjVh32Bua/YRlxakYOI8rjbvV1eCp1s2K7LZeM=@lists.xenproject.org X-Gm-Message-State: AOJu0YzVZd4amDY+iqn7uZFCZiGjL09wCReGjZI6Y6fa5bV+vaaQd7jk 8w0jKmHVT47MqgmQc5gwnjOcaf7tdP2AJinoLnhJsAFhKaGgiZuqrIjJMZj/tRiaQbvTntYIU21 Iev8rEg== X-Received: from plfz4.prod.google.com ([2002:a17:902:d544:b0:2c7:f3dc:ae29]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e811:b0:2c9:f73d:4b38 with SMTP id d9443c01a7336-2ca7e6db91bmr32521425ad.19.1782934345724; Wed, 01 Jul 2026 12:32:25 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:22 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-2-seanjc@google.com> Subject: [PATCH v5 01/51] x86/apic: Provide helpers to set local APIC timer period in hz and khz From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1782934348-D7935DDE-2F08127A/0/0 X-purgate-type: clean X-purgate-size: 5605 Add and use APIs to set the local APIC timer period instead of open coding the subtle HZ math in a all external callers, and make lapic_timer_period local to apic.c. Provide APIs to specify the frequency in both hertz and kilohertz so that Hyper-V and VMware code aren't forced to lose precision. Opportunistically use mul_u64_u32_div() to harden against the possibility that the period in Khz is greater than 4294967, i.e. if the APIC timer runs at ~4.29 GHz. As pointed out by Sashiko, 4294968 * 1000 == 0x1_000002c0, and thus a Khz period of 4294968 would silently overflow the 32-bit unsigned integer used by most callers. Signed-off-by: Sean Christopherson --- arch/x86/include/asm/apic.h | 3 ++- arch/x86/kernel/apic/apic.c | 12 +++++++++++- arch/x86/kernel/cpu/mshyperv.c | 5 +---- arch/x86/kernel/cpu/vmware.c | 4 +--- arch/x86/kernel/jailhouse.c | 2 +- arch/x86/kernel/tsc.c | 2 +- arch/x86/kernel/tsc_msr.c | 2 +- 7 files changed, 18 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index 9cd493d467d4..cd84a94688a2 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -63,7 +63,6 @@ extern int apic_verbosity; extern int local_apic_timer_c2_ok; extern bool apic_is_disabled; -extern unsigned int lapic_timer_period; extern enum apic_intr_mode_id apic_intr_mode; enum apic_intr_mode_id { @@ -138,6 +137,8 @@ void register_lapic_address(unsigned long address); extern void setup_boot_APIC_clock(void); extern void setup_secondary_APIC_clock(void); extern void lapic_update_tsc_freq(void); +extern void apic_set_timer_period_hz(u64 period_hz, const char *source); +extern void apic_set_timer_period_khz(u64 period_khz, const char *source); #ifdef CONFIG_X86_64 static inline bool apic_force_enable(unsigned long addr) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index aa1e19979aa8..8d3d930576fd 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -176,7 +176,7 @@ static struct resource lapic_resource = { }; /* Measured in ticks per HZ. */ -unsigned int lapic_timer_period = 0; +static unsigned int lapic_timer_period; static void apic_pm_activate(void); @@ -796,6 +796,16 @@ bool __init apic_needs_pit(void) return lapic_timer_period == 0; } +void apic_set_timer_period_khz(u64 period_khz, const char *source) +{ + lapic_timer_period = mul_u64_u32_div(period_khz, 1000, HZ); +} + +void apic_set_timer_period_hz(u64 period_hz, const char *source) +{ + lapic_timer_period = div_u64(period_hz, HZ); +} + static int __init calibrate_APIC_clock(void) { struct clock_event_device *levt = this_cpu_ptr(&lapic_events); diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 185d4f677ec0..87beecec76f0 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -646,10 +646,7 @@ static void __init ms_hyperv_init_platform(void) u64 hv_lapic_frequency; rdmsrq(HV_X64_MSR_APIC_FREQUENCY, hv_lapic_frequency); - hv_lapic_frequency = div_u64(hv_lapic_frequency, HZ); - lapic_timer_period = hv_lapic_frequency; - pr_info("Hyper-V: LAPIC Timer Frequency: %#x\n", - lapic_timer_period); + apic_set_timer_period_hz(hv_lapic_frequency, "Hyper-V hypervisor"); } register_nmi_handler(NMI_UNKNOWN, hv_nmi_unknown, NMI_FLAG_FIRST, diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 34b73573b108..36f779dd311d 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -424,9 +424,7 @@ static void __init vmware_platform_setup(void) #ifdef CONFIG_X86_LOCAL_APIC /* Skip lapic calibration since we know the bus frequency. */ - lapic_timer_period = ecx / HZ; - pr_info("Host bus clock speed read from hypervisor : %u Hz\n", - ecx); + apic_set_timer_period_hz(ecx, "VMware hypervisor"); #endif } else { pr_warn("Failed to get TSC freq from the hypervisor\n"); diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c index f58ce9220e0f..f2d4ef89c085 100644 --- a/arch/x86/kernel/jailhouse.c +++ b/arch/x86/kernel/jailhouse.c @@ -65,7 +65,7 @@ static void jailhouse_get_wallclock(struct timespec64 *now) static void __init jailhouse_timer_init(void) { - lapic_timer_period = setup_data.v1.apic_khz * (1000 / HZ); + apic_set_timer_period_khz(setup_data.v1.apic_khz, "Jailhouse hypervisor"); } static unsigned long jailhouse_get_tsc(void) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index ce10ae4b298b..f9ecc9256863 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -717,7 +717,7 @@ unsigned long native_calibrate_tsc(void) * lapic_timer_period here to avoid having to calibrate the APIC * timer later. */ - lapic_timer_period = crystal_khz * 1000 / HZ; + apic_set_timer_period_khz(crystal_khz, "CPUID 0x15/0x16"); #endif return crystal_khz * ebx_numerator / eax_denominator; diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c index 48e6cc1cb017..7e990871e041 100644 --- a/arch/x86/kernel/tsc_msr.c +++ b/arch/x86/kernel/tsc_msr.c @@ -211,7 +211,7 @@ unsigned long cpu_khz_from_msr(void) pr_err("Error MSR_FSB_FREQ index %d is unknown\n", index); #ifdef CONFIG_X86_LOCAL_APIC - lapic_timer_period = (freq * 1000) / HZ; + apic_set_timer_period_khz(freq, "MSR_FSB_FREQ"); #endif /* -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350363.1607808 (Exim 4.92) (envelope-from ) id 1wf0fc-0007Zr-MV; Wed, 01 Jul 2026 19:32:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350363.1607808; Wed, 01 Jul 2026 19:32:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fc-0007Zk-Jr; Wed, 01 Jul 2026 19:32:28 +0000 Received: by outflank-mailman (input) for mailman id 1350363; Wed, 01 Jul 2026 19:32:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3SGtFagYKCY09vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 1wf0fc-0007Ze-26 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fb-004o0g-BE for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:27 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3SGtFagYKCY09vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a456b44-2eae-0a2a0a5409dd-0a2a4509ddee-18 for ; Wed, 01 Jul 2026 21:32:27 +0200 Received: from [209.85.215.201] (helo=mail-pg1-f201.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3SGtFagYKCY09vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a456b49-97e6-0a2a45090019-d155d7c9f06b-3 for ; Wed, 01 Jul 2026 21:32:26 +0200 Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c88da04b719so795266a12.2 for ; Wed, 01 Jul 2026 12:32:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:Mime-Version:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934345; x=1783539145; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:mime-version:date :reply-to:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Q5DLB1BjKje3f1c5FruZIw3+wsrQVQC55+bIjsMSwHk=; b=JpFMN4mPtJD46ArcdgAMsPMZlVGQOXA/fBCFWCnpab2xVVaxbSRGfH698Hzdy9fYY7 tv7IhdyQEPk971zAuAnJU0bEFM5X13FjqXwNDT1ucHNOym2K4ceo/V6Manl5LaH3UBUv DXljgQnXZ954da359zQWS0/oo6J1JPPjb45HBiPrfYNfuvZFrCttGDGvS4CknwKmBWkb ZQP9CX4zTid60oPIoSRTvHvBxFENVcnwFhS4P6C8s0dR5pRy7IcQDAWp2g2AlyyadiuJ yytp0UHh/81RZshdHrbX0g3bLXTBba1xbyvEE7pQAsUQjMZOIngmKczqCjJYgIXg4KVE xO8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934345; x=1783539145; h=content-type:cc:to:from:subject:message-id:mime-version:date :reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Q5DLB1BjKje3f1c5FruZIw3+wsrQVQC55+bIjsMSwHk=; b=hWvW1Ie0z9yqMFYUV8LNxK54w/y9Mi4JV9AkL52CDVeJGgi/XnETGMOlG4/8hBgtKJ EUR9rNCM5gykoSuro9twlNbBXukrqjS/hW7rB5a/Hyf8QrUqg8Qkik1qqX7opj6SW/hx qVjMBQR8BtXzG84mj1xMC4yZMmBfPD5GtpMD7/0REd9dxHJIPAQ6Y4ZbHskPNEh+rTt0 YXoFq9wXCcWkrIElXlAt4B0V4mXyCzeqMwhkJbmnD78QaWn2JiEsGuaII47hX1M1USjm YncIYzGGYv3rcBDfDUb9U/tTme0PJqZ/mrnNdWUe36+OwOIocbsv937jvvelmQSaYMz+ uSfQ== X-Forwarded-Encrypted: i=1; AHgh+RoCmppyAUWlHpTmiymMlVOS1CxYP1DQLTMZUbp8rdMx94yiiUUSj0jVQOwmiy9EE1FfA7Ad7hNYZnE=@lists.xenproject.org X-Gm-Message-State: AOJu0YytNaNWf8YtTac8Ctw6AWnE8dHb6oOvs31dgbgZh/8Egy7Fm72b feiQZF9dI6I6zsRFBw43hc9ZNm0JwocAquN5ZsjVVOqRGsFQa54u7/0NFu+6SU5N5CWEQaZmOVt MsydxTw== X-Received: from pjtl15.prod.google.com ([2002:a17:90a:c58f:b0:380:5553:77a7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:52:b0:37f:9ce1:735e with SMTP id 98e67ed59e1d1-380ba94a46bmr2041513a91.31.1782934344390; Wed, 01 Jul 2026 12:32:24 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:21 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-1-seanjc@google.com> Subject: [PATCH v5 00/51] x86: Try to wrangle PV clocks vs. TSC From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934347-44528986-E2D4D8F7/0/0 X-purgate-type: clean X-purgate-size: 11040 The primary goal of this series to fix flaws with SNP and TDX guests where a PV clock provided by the untrusted hypervisor is used instead of the secure TSC that is controlled by trusted firmware. The secondary goal is modernize running under KVM. Currently, KVM guests will use TSC for clocksource, but not sched_clock. And Linux-as-a-KVM-guest doesn't support paravirt enumeration of the TSC/APIC frequencies, even though QEMU provides that information by default. The tertiary goal is to clean up the PV clock code to deduplicate logic across hypervisors, and to hopefully make it all easier to maintain going forward. The quaternary goal is to clean up the TSC calibration code, which was made stupidly hard to follow by hypervisor code mixing in with the native calibration routines, instead of being implemented as a pure alternative. Note, the VMware and Xen changes still probably should get acks from those maintainers, as my understanding of what they're trying to do may be flawed. Lots more background on the SNP/TDX motiviation: https://lore.kernel.org/all/20250106124633.1418972-13-nikunj@amd.com As before, I deliberately omitted jailhouse-dev@googlegroups.com from the To/Cc, as those emails bounced on v1, AFAICT nothing has changed. v5: - Use cpu_feature_enabled() instead of boot_cpu_has(). [Boris] - WARN if recalibrate_cpu_khz() runs on a system with TSC_KNOWN_FREQ. [Thomas] - Opportunistically drop a line break in native_calibrate_tsc(). [Thomas] - Rely on callers of cpuid_get_tsc_info() to check the result instead of unnecessarily zeroing the structure. [Boris] - Ignore tsc_early_khz if the TSC frequency is provided by trusted firmware or by the hypervisor. [Thomas, Sashiko] - Cache CPUID output in acrn_init_platform() to avoid introducing a transient bug where TSC_KNOWN_FREQ could be set even if the ACRN hypervisor didn't actually provide the frequency. [Sashiko] - Drop kvmclock's useless/dead check_tsc_unstable() call (it occurs before the command line parameter is parsed). [Sashiko] - Add helpers to set lapic_timer_period, to fix not-so-theoretical overflow in the various "khz * 1000 / HZ" patterns. [Sashiko] - Drop the "x86/xen: Obtain TSC frequency from CPUID if present" patch as it doesn't have any dependencies/conflicts on/with this series, and Sashiko had concerns about the assumptions it was making. [Sashiko] - Collect reviews. [David] (Kirill's got dropped because the patch he reviewed got completely rewritten). v4: - Use x86_init_noop() to skip save/restore on VMware and Xen instead of nullifying x86_platform.{save,restore}_sched_clock_state. [Sashiko] - Use '0' to indicate "failure" when getting the CPU frequency from CPUID, to avoid using an out-param and thus make it all but impossible to unintentionally clobber the global cpu_khz (which v3 did). [Sashiko] - Rename cpuid_get_cpu_freq() => __cpu_khz_from_cpuid() to capture its relationship with cpu_khz_from_cpuid(). - Compute lapic_timer_period in units of ticks, not Khz. [Sashiko] - Kill off x86_platform_ops.calibrate_{cpu,tsc}(), and instead use dedicated hooks for hypervisor code, and direct calls for TDX and SNP. [David, loosely] - Drop SNP's secure TSC override of _CPU_ calibration, as there's zero evidence it's justified or a net positive. - Collect reviews/acks. [David, Wei] - Decouple getting TSC/APIC frequencies from KVM PV CPUID from kvmclock. [David] - Fix an amusing number of Opportunistically misspellings. [David] - Set kvm_sched_clock_offset _before_ registering kvmclock as sched_clock, and add a comment to guard against future goofs. [Sashiko] - Keep "setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE)" in Hyper-V's handling of HV_ACCESS_TSC_INVARIANT, as it's technically possible to have a VM with HV_ACCESS_TSC_INVARIANT but not HV_ACCESS_FREQUENCY_MSRS. Though as a _very_ nice side effect of using dedicated sequencing for selecting the TSC frequency source, this would have naturally happened anyways. [Sashiko] v3: - https://lore.kernel.org/all/20260515191942.1892718-1-seanjc@google.com - Collect reviews. [Michael, Thomas] - Use Hyper-V reference counter / refcounter instead of Hyper-V timer. [Michael] - Use the paravirt CPUID interface first proposed by VMware for KVM's "official" mechanism for communicating frequency to KVM-aware guests, instead of abusing Intel's CPUID leafs. [David] - Deal with paravirt code being moved into asm/timers.h and arch/x86/kernel/tsc.c. v2: - https://lore.kernel.org/all/Z8YWttWDtvkyCtdJ@google.com - Add struct to hold the TSC CPUID output. [Boris] - Don't pointlessly inline the TSC CPUID helpers. [Boris] - Fix a variable goof in a helper, hopefully for real this time. [Dan] - Collect reviews. [Nikunj] - Override the sched_clock save/restore hooks if and only if a PV clock is successfully registered. - During resome, restore clocksources before reading persistent time. - Clean up more warts created by kvmclock. - Fix more bugs in kvmclock's suspend/resume handling. - Try to harden kvmclock against future bugs. v1: https://lore.kernel.org/all/20250201021718.699411-1-seanjc@google.com David Woodhouse (2): KVM: x86: Officially define CPUID 0x40000010 as PV Timing Info (TSC and Bus) x86/kvm: Obtain TSC frequency from PV CPUID if present Sean Christopherson (49): x86/apic: Provide helpers to set local APIC timer period in hz and khz x86/apic: Add CONFIG_X86_LOCAL_APIC=n stubs for apic_set_timer_period_{,k}hz() x86/tsc: Ensure that TSC recalibration doesn't run if TSC frequency is known x86/tsc: Restrict recalibrate_cpu_khz() export to p4-clockmod and powernow-k7 x86/sev: Mark TSC as reliable when configuring Secure TSC x86/sev: Don't override CPU frequency calibration for SNP's Secure TSC x86/sev: Move check for SNP Secure TSC support to tsc_early_init() x86/sev: Shove SNP's secure/trusted TSC frequency directly into "calibration" x86/tsc: Add a standalone helper for getting TSC info from CPUID.0x15 x86/tdx: Force TSC frequency with CPUID-based info provided by the TDX-Module x86/tsc: Add dedicated hypervisor hooks for getting known TSC/CPU frequencies x86/acrn: Register TSC/CPU frequency callbacks iff frequency is actually in CPUID x86/acrn: Mark TSC frequency as known when using ACRN for calibration x86/tsc: Consolidate forcing of X86_FEATURE_TSC_KNOWN_FREQ for PV code x86/tsc: Kill off x86_platform_ops.calibrate_{cpu,tsc}() hooks x86/tsc: Rename pit_hpet_ptimer_calibrate_cpu() => native_calibrate_cpu_late() x86/tsc: Fold native_calibrate_cpu() into recalibrate_cpu_khz() x86/kvmclock: Rename kvm_get_tsc_khz() to kvmclock_get_tsc_khz() x86/kvmclock: Drop dead check on TSC being unstable during kvmclock_init() x86/kvm: Mark TSC as reliable when it's constant and nonstop x86/tsc: Add standalone helper for getting CPU frequency from CPUID x86/kvm: Get CPU base frequency from CPUID when it's available clocksource: hyper-v: Register sched_clock save/restore iff it's necessary clocksource: hyper-v: Drop wrappers to sched_clock save/restore helpers clocksource: hyper-v: Don't save/restore TSC offset when using HV sched_clock x86/kvmclock: Setup kvmclock for secondary CPUs iff CONFIG_SMP=y x86/kvm: Don't disable kvmclock on BSP in syscore_suspend() x86/paravirt: Remove unnecessary PARAVIRT=n stub for paravirt_set_sched_clock() x86/paravirt: Move handling of unstable PV clocks into paravirt_set_sched_clock() x86/kvmclock: Move sched_clock save/restore helpers up in kvmclock.c x86/xen/time: NOP-ify x86_platform's sched_clock save/restore hooks x86/vmware: NOP-ify save/restore hooks when using VMware's sched_clock x86/tsc: WARN if TSC sched_clock save/restore used with PV sched_clock x86/paravirt: Pass sched_clock save/restore helpers during registration x86/kvmclock: Move kvm_sched_clock_init() down in kvmclock.c x86/xen/time: Mark xen_setup_vsyscall_time_info() as __init x86/pvclock: Mark setup helpers and related various as __init/__ro_after_init x86/pvclock: WARN if pvclock's valid_flags are overwritten x86/kvmclock: Refactor handling of PVCLOCK_TSC_STABLE_BIT during kvmclock_init() timekeeping: Resume clocksources before reading persistent clock x86/kvmclock: Hook clocksource.suspend/resume when kvmclock isn't sched_clock x86/kvmclock: WARN if wall clock is read while kvmclock is suspended x86/paravirt: Mark __paravirt_set_sched_clock() as __init x86/paravirt: Plumb a return code into __paravirt_set_sched_clock() x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC x86/kvmclock: Use TSC for sched_clock if it's constant and non-stop x86/kvmclock: Plumb in AP-online and BSP-resume to kvmlock, for documentation x86/paravirt: Move using_native_sched_clock() stub into timer.h x86/kvm: Get local APIC bus frequency from PV CPUID Timing Info .../admin-guide/kernel-parameters.txt | 5 + Documentation/virt/kvm/x86/cpuid.rst | 12 + arch/x86/coco/sev/core.c | 21 +- arch/x86/coco/tdx/tdx.c | 19 +- arch/x86/include/asm/acrn.h | 5 - arch/x86/include/asm/apic.h | 5 +- arch/x86/include/asm/kvm_para.h | 12 +- arch/x86/include/asm/sev.h | 4 +- arch/x86/include/asm/tdx.h | 2 + arch/x86/include/asm/timer.h | 15 +- arch/x86/include/asm/tsc.h | 10 +- arch/x86/include/asm/x86_init.h | 8 +- arch/x86/include/uapi/asm/kvm_para.h | 11 + arch/x86/kernel/apic/apic.c | 12 +- arch/x86/kernel/cpu/acrn.c | 14 +- arch/x86/kernel/cpu/mshyperv.c | 70 +----- arch/x86/kernel/cpu/vmware.c | 19 +- arch/x86/kernel/jailhouse.c | 9 +- arch/x86/kernel/kvm.c | 101 ++++++-- arch/x86/kernel/kvmclock.c | 208 +++++++++++------ arch/x86/kernel/pvclock.c | 9 +- arch/x86/kernel/tsc.c | 218 +++++++++++------- arch/x86/kernel/tsc_msr.c | 4 +- arch/x86/kernel/x86_init.c | 2 - arch/x86/mm/mem_encrypt_amd.c | 3 - arch/x86/xen/time.c | 14 +- drivers/clocksource/hyperv_timer.c | 38 ++- include/clocksource/hyperv_timer.h | 2 - kernel/time/timekeeping.c | 9 +- 29 files changed, 540 insertions(+), 321 deletions(-) base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350365.1607825 (Exim 4.92) (envelope-from ) id 1wf0fg-00080K-7V; Wed, 01 Jul 2026 19:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350365.1607825; Wed, 01 Jul 2026 19:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fg-00080D-4O; Wed, 01 Jul 2026 19:32:32 +0000 Received: by outflank-mailman (input) for mailman id 1350365; Wed, 01 Jul 2026 19:32:30 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3S2tFagYKCZACyu73w08805y.w86Hy7-xyFy552CDC.Hy79B83ywD.8B0@flex--seanjc.bounces.google.com>) id 1wf0fe-0007vn-Nh for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fe-004o0g-4Z for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:30 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3S2tFagYKCZACyu73w08805y.w86Hy7-xyFy552CDC.Hy79B83ywD.8B0@flex--seanjc.bounces.google.com>) id 6a456b30-2eae-0a2a0a5409dd-0a2a4503b1b4-16 for ; Wed, 01 Jul 2026 21:32:30 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3S2tFagYKCZACyu73w08805y.w86Hy7-xyFy552CDC.Hy79B83ywD.8B0@flex--seanjc.bounces.google.com>) id 6a456b4c-ec1a-0a2a45030019-d155d6cab929-3 for ; Wed, 01 Jul 2026 21:32:29 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c9960cf96cso12682655ad.3 for ; Wed, 01 Jul 2026 12:32:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934348; x=1783539148; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=t7xFvhsXyUl34us7SMoRDgC7NN8K9lGkg6/G6zp7sLk=; b=uDgtrHaJ6ZBuPOkMrZLDVdCcpygN6+1xPMKD3qnf9JAU3vNFS69xLZDPEfT4C9CAcO roT0NWYcs0n7KfI2EZ08ijqTEcDfrg2PwATjpdwThh8Xg/wnN135gQUlrS3GDWaRTVt0 9D6BzSm1dfKTTRixyGbg3k803jhT2S0u+AKdMTe7K9vuiabe4OriVJeX4l3HB3QpWAYn b/H9scq8Ehlir0V4F3eUMUINw9YN4K2jtOm1mW7oQccLpg8eDwD0tX3fX5UjSLOm9MeF Hk9ZdaHnMJ1KOGh2taskaqQIqEv7tlSdENbIJEdySWQp9OtcK8SMtzntmc6eMivgjHz0 fsvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934348; x=1783539148; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t7xFvhsXyUl34us7SMoRDgC7NN8K9lGkg6/G6zp7sLk=; b=YrKSEftd2pq4hZQF6oK10bBwzKyGcbIb7seO/9ZELyhb05GP6eoymYhoC/vA6epTec 7QFdlvJNrSbjPOJoEdWjhk6Y1Q6MGC3JA+myKzQl+Lu9AL5nt5LlcY6MZyxE1ax02xrI XQgU54aN74ut01hb9+xAhEw+OKMxxOjli+FregI29yahh1zALVvqi4ETFqwQusW5IhKM jk5pGe/AYEgYgOV2RR5vMvz6Xjmu74Km70YTynBBTTYBZU4RcTVDrHqtvgcB1RHjUl0F TtxEPV+WeugNPhfBjXfnvc3ugoXLhjDAZzktLBXs1gJjkB/yCaVFkiq8CDH8Pi1jIfT7 vEkA== X-Forwarded-Encrypted: i=1; AHgh+RqbFCEdd8JhaoUSuo3/AZ9XGNgbxk+oJyckGBf7zxXw34Bx4SCttxfCe/sBYgDokLglKIIgROwEQek=@lists.xenproject.org X-Gm-Message-State: AOJu0YwPTlOK5mplBXHpBWw8KApJZ+oDIjKvj21VX/g4T2Myy5eIXR92 3fqLNPiqisX3wd+s/hvTRKaBJwUK2Ilg3jGdhjauiWraxpUevsh7YAdprCaA8QobnUmu0TYn0Yj Hi/3aBg== X-Received: from plbmk12.prod.google.com ([2002:a17:903:2bcc:b0:2c8:219a:17e8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:19d0:b0:2ca:53e9:1277 with SMTP id d9443c01a7336-2ca7e714f7fmr32655485ad.1.1782934347423; Wed, 01 Jul 2026 12:32:27 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:23 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-3-seanjc@google.com> Subject: [PATCH v5 02/51] x86/apic: Add CONFIG_X86_LOCAL_APIC=n stubs for apic_set_timer_period_{,k}hz() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1782934350-077265D1-D715471B/0/0 X-purgate-type: clean X-purgate-size: 3082 Add stubs for the apic_set_timer_period_{,k}hz() APIs when the kernel is built without support for a local APIC, and drop #ifdefs in callers that don't need to check CONFIG_X86_LOCAL_APIC for other reasons. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/include/asm/apic.h | 2 ++ arch/x86/kernel/cpu/vmware.c | 2 -- arch/x86/kernel/tsc.c | 2 -- arch/x86/kernel/tsc_msr.c | 2 -- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index cd84a94688a2..035998555e99 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -189,6 +189,8 @@ static inline void disable_local_APIC(void) { } # define setup_boot_APIC_clock x86_init_noop # define setup_secondary_APIC_clock x86_init_noop static inline void lapic_update_tsc_freq(void) { } +static inline void apic_set_timer_period_hz(u64 period_hz, const char *source) { } +static inline void apic_set_timer_period_khz(u64 period_khz, const char *source) { } static inline void init_bsp_APIC(void) { } static inline void apic_intr_mode_select(void) { } static inline void apic_intr_mode_init(void) { } diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 36f779dd311d..13b97265c535 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -422,10 +422,8 @@ static void __init vmware_platform_setup(void) x86_platform.calibrate_tsc = vmware_get_tsc_khz; x86_platform.calibrate_cpu = vmware_get_tsc_khz; -#ifdef CONFIG_X86_LOCAL_APIC /* Skip lapic calibration since we know the bus frequency. */ apic_set_timer_period_hz(ecx, "VMware hypervisor"); -#endif } else { pr_warn("Failed to get TSC freq from the hypervisor\n"); } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index f9ecc9256863..4d6a446645c0 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -710,7 +710,6 @@ unsigned long native_calibrate_tsc(void) if (boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT) setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); -#ifdef CONFIG_X86_LOCAL_APIC /* * The local APIC appears to be fed by the core crystal clock * (which sounds entirely sensible). We can set the global @@ -718,7 +717,6 @@ unsigned long native_calibrate_tsc(void) * timer later. */ apic_set_timer_period_khz(crystal_khz, "CPUID 0x15/0x16"); -#endif return crystal_khz * ebx_numerator / eax_denominator; } diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c index 7e990871e041..aece062aee7e 100644 --- a/arch/x86/kernel/tsc_msr.c +++ b/arch/x86/kernel/tsc_msr.c @@ -210,9 +210,7 @@ unsigned long cpu_khz_from_msr(void) if (freq == 0) pr_err("Error MSR_FSB_FREQ index %d is unknown\n", index); -#ifdef CONFIG_X86_LOCAL_APIC apic_set_timer_period_khz(freq, "MSR_FSB_FREQ"); -#endif /* * TSC frequency determined by MSR is always considered "known" -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:36 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350367.1607844 (Exim 4.92) (envelope-from ) id 1wf0fk-0008W3-L6; Wed, 01 Jul 2026 19:32:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350367.1607844; Wed, 01 Jul 2026 19:32:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fk-0008Vs-Hl; Wed, 01 Jul 2026 19:32:36 +0000 Received: by outflank-mailman (input) for mailman id 1350367; Wed, 01 Jul 2026 19:32:34 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3T2tFagYKCZQG2yB704CC492.0CAL2B-12J2996GHG.L2BDFC720H.CF4@flex--seanjc.bounces.google.com>) id 1wf0fi-0008Qn-Jj for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fi-004o0g-0k for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:34 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3T2tFagYKCZQG2yB704CC492.0CAL2B-12J2996GHG.L2BDFC720H.CF4@flex--seanjc.bounces.google.com>) id 6a456b30-2eae-0a2a0a5409dd-0a2a4503b1b4-28 for ; Wed, 01 Jul 2026 21:32:34 +0200 Received: from [209.85.210.202] (helo=mail-pf1-f202.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3T2tFagYKCZQG2yB704CC492.0CAL2B-12J2996GHG.L2BDFC720H.CF4@flex--seanjc.bounces.google.com>) id 6a456b50-ec1a-0a2a45030019-d155d2caa8c0-3 for ; Wed, 01 Jul 2026 21:32:33 +0200 Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-8478e603285so1932638b3a.0 for ; Wed, 01 Jul 2026 12:32:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934352; x=1783539152; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=s/QSbcUaf8Mr1OX5FYkbnza8ilhhfuHPZoXwnM4X05U=; b=Vu7hJsLUEeYgH9PkViNQa5T4fMdukUhG9CkXMzhozwgwQPGZsGUrs07H4nnKkHcy82 cfrd6TO/1M9j1+36W8ACqO6SsM4id9SmQnb5zESEPNDQaMjKqe3V8yww1vVva8+jc2y2 1b7mksdfCcWHu4+kSNIzCe2TXb9yniEbfgL6C3Mq7gT8d9dcSiaGLqYCYYbbr0w10OdU PreOoqHxI9Uux959TBO8MeA4sI3sj6EG+n/BYhimwYZ7/NEtmmI0PRMk2FayybAyFYrA aiWARAhQ0t7oZSh4QKptv/T12oQEKUX/FsjJ5h8Rh+z4ruzE7zbhWtc5xSMFbX+vHgly 7z5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934352; x=1783539152; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s/QSbcUaf8Mr1OX5FYkbnza8ilhhfuHPZoXwnM4X05U=; b=bzMtHaFNoIy5thsL3yi8dxljExlfzF9B+Fv228qMP+SNNv30jR03cW+RheYvkQbikQ 9BmH5JsvtssYA457At3wPniSKrNAVjRgCULfGz2zENVnWGRvS0046LAZ4rshWD8U5hVc vgPazRzeYouBomZHCGSxvT/weOxkoWX8Dt7137zLB/1M6cCadWaaadtnGjOFCnecOEhs QzPCetS+WZGdi2m1IWFzcga5JGli+4ybHh6K8D81ige/uU87/U9grhL5dVFq8RMOXCay djNstwAJo1reOCRifa/OkX6cFv9dUkA9BDQ9yEBREjDAOFlnoCI66pVv5NyPnQPtEARN 9sFA== X-Forwarded-Encrypted: i=1; AHgh+Rp2Ad7W+rHkajwkWikFdLRfAa1MlwggctIE6f6BG+pF7RyPpAqblHDjLzuP4NUuGA6uSCQyqZ1pdCA=@lists.xenproject.org X-Gm-Message-State: AOJu0YyWlh6Sv0Y3uE1wisMamqpBvXFlpJ2FZcETAY/lUvT+x3M24zkl Uojq+fDWjxhL0+Yq9p/AX4klboIUnoX5RSTgu8UXiVUrIDCTw9SNLABBzqJXmWDNq0KTbvanBhl kN/78PQ== X-Received: from pfbhc3.prod.google.com ([2002:a05:6a00:6503:b0:846:aff8:5614]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3e10:b0:842:499d:450e with SMTP id d2e1a72fcca58-847a82d978dmr5886277b3a.20.1782934351240; Wed, 01 Jul 2026 12:32:31 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:25 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-5-seanjc@google.com> Subject: [PATCH v5 04/51] x86/tsc: Restrict recalibrate_cpu_khz() export to p4-clockmod and powernow-k7 From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1782934353-B4D805D1-24BC8097/0/0 X-purgate-type: clean X-purgate-size: 837 Export recalibrate_cpu_khz() only for its two users, p4-clockmod.ko and powernow-k7.ko, to help document that recalibration is relevant only to ancient CPUs. For all intents and purposes, no functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 4393902c0ddd..482cc3a8999a 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -943,7 +943,7 @@ void recalibrate_cpu_khz(void) cpu_khz_old, cpu_khz); #endif } -EXPORT_SYMBOL_GPL(recalibrate_cpu_khz); +EXPORT_SYMBOL_FOR_MODULES(recalibrate_cpu_khz, "p4-clockmod,powernow-k7"); static unsigned long long cyc2ns_suspend; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350368.1607853 (Exim 4.92) (envelope-from ) id 1wf0fm-0000Kp-0C; Wed, 01 Jul 2026 19:32:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350368.1607853; Wed, 01 Jul 2026 19:32:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fl-0000KQ-P8; Wed, 01 Jul 2026 19:32:37 +0000 Received: by outflank-mailman (input) for mailman id 1350368; Wed, 01 Jul 2026 19:32:35 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3UGtFagYKCZUH3zC815DD5A3.1DBM3C-23K3AA7HIH.M3CEGD831I.DG5@flex--seanjc.bounces.google.com>) id 1wf0fj-0008Ts-It for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fi-00Bw10-Vq for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:34 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3UGtFagYKCZUH3zC815DD5A3.1DBM3C-23K3AA7HIH.M3CEGD831I.DG5@flex--seanjc.bounces.google.com>) id 6a456b21-bab6-0a2a0a5309dd-0a2a45079628-28 for ; Wed, 01 Jul 2026 21:32:34 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3UGtFagYKCZUH3zC815DD5A3.1DBM3C-23K3AA7HIH.M3CEGD831I.DG5@flex--seanjc.bounces.google.com>) id 6a456b51-9c8e-0a2a45070019-d155d84ac9d3-3 for ; Wed, 01 Jul 2026 21:32:34 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-37e1f96b248so1287066a91.3 for ; Wed, 01 Jul 2026 12:32:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934353; x=1783539153; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=a+o8BZyrs+hCKgt2M2jOo1gfN0drsi4lQngccMqCRwE=; b=h/Rm6+y+Pp6Q/agCeGZC28rgA/WNNn+KFwWOBczsonXYZxxbOglKeUDl8rVU6mp9dq bpcZvMl6TcU3iyWNBysRkfFMMYhVdzpmzKhXAtjdfBhFCb5guvHVl6tI/Rd1umioqdVx rT9d1I671tujKR6Rn+MKWTJLAmwQntPo87sc2BjrhWdNxnFs+Doo3cBQZ2gNDiLIgwJr aNWgwYqDLGARM14sEwXYkjrinje3PDdppFMh5bXU79RWKUt6KQLz9gVugGN/1SYwny2b 7JvrPp93YdIk3j1qewZoDzYtw77pak/3q+RKC9i9VgDoY2K2943kQAokTMQkV1pXoAeP 7VFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934353; x=1783539153; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a+o8BZyrs+hCKgt2M2jOo1gfN0drsi4lQngccMqCRwE=; b=tB5nSITjOEpCepPJ/T5vfguIjdGSL1L4z+7LjAFCDrQK9D8yn6OKdHrg/hHrl+Hjbn 6jyYSprIgnsjwEowDwGnn0Eajtr2S/PIMQi/DoG6NMuOikaxMQySmZ9NvlMLESXArXs3 rhCam/j9LMsKP+Wi2xcCVR8nQ5T007i/VKcKMGR7TTzxO9DZ3RMDPDiUu/cTux8ywTN2 9g8LKz7w5xOrET7v0h6SugpkIRf1dgLnNP5m+UAXdfSQ/ZQpBPWisuiuGkYPX3dG/7oA OK5JsJIa50NDMBzVxXgbQqvJhTFWqRLeOZF/tLgOKMx6FfZV+QgREuxNpIHprjqv5VgC c+Qg== X-Forwarded-Encrypted: i=1; AHgh+RpOgmX5Stjop8s46m/IcD84h4QN3N/AC/ssOc17knfsum2bj/Aaq1dAPi8K50J38PB8z10FuTp0Fo0=@lists.xenproject.org X-Gm-Message-State: AOJu0Ywn0kTAkcrf7T2E/ykUKg/spNHwXOqO0Rnej8/idcR9d8lm86uU YnUIRmzcr8NKlYBEdsxb7n5roM4jE+GUV8PcLGrLxKlycIirXApWnx7EhjKfalXHndKBaBWt2+Z OXgGkQQ== X-Received: from pja11.prod.google.com ([2002:a17:90b:548b:b0:37e:1dd6:f70c]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:28c4:b0:37f:9ce0:af32 with SMTP id 98e67ed59e1d1-380aa204608mr2862792a91.29.1782934352462; Wed, 01 Jul 2026 12:32:32 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:26 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-6-seanjc@google.com> Subject: [PATCH v5 05/51] x86/sev: Mark TSC as reliable when configuring Secure TSC From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1782934354-FF93225E-91BC0049/0/0 X-purgate-type: clean X-purgate-size: 1727 Move the code to mark the TSC as reliable from sme_early_init() to snp_secure_tsc_init(). The only reader of TSC_RELIABLE is the aptly named check_system_tsc_reliable(), which runs in tsc_init(), i.e. after snp_secure_tsc_init(). This will allow consolidating the handling of TSC_KNOWN_FREQ and TSC_RELIABLE when overriding the TSC calibration routine. Cc: Tom Lendacky Reviewed-by: Nikunj A Dadhania Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 2 ++ arch/x86/mm/mem_encrypt_amd.c | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index ecd77d3217f3..ed0ac52a765e 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2037,6 +2037,8 @@ void __init snp_secure_tsc_init(void) secrets = (__force struct snp_secrets_page *)mem; setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); + setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); + rdmsrq(MSR_AMD64_GUEST_TSC_FREQ, tsc_freq_mhz); /* Extract the GUEST TSC MHZ from BIT[17:0], rest is reserved space */ diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c index 2f8c32173972..6c3af974c7c2 100644 --- a/arch/x86/mm/mem_encrypt_amd.c +++ b/arch/x86/mm/mem_encrypt_amd.c @@ -535,9 +535,6 @@ void __init sme_early_init(void) */ x86_init.resources.dmi_setup = snp_dmi_setup; } - - if (sev_status & MSR_AMD64_SNP_SECURE_TSC) - setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); } void __init mem_encrypt_free_decrypted_mem(void) -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350370.1607858 (Exim 4.92) (envelope-from ) id 1wf0fm-0000Pg-IU; Wed, 01 Jul 2026 19:32:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350370.1607858; Wed, 01 Jul 2026 19:32:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fm-0000Nv-AK; Wed, 01 Jul 2026 19:32:38 +0000 Received: by outflank-mailman (input) for mailman id 1350370; Wed, 01 Jul 2026 19:32:36 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3UWtFagYKCZYI40D926EE6B4.2ECN4D-34L4BB8IJI.N4DFHE942J.EH6@flex--seanjc.bounces.google.com>) id 1wf0fk-0008Vj-MH for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fk-004o0g-38 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:36 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3UWtFagYKCZYI40D926EE6B4.2ECN4D-34L4BB8IJI.N4DFHE942J.EH6@flex--seanjc.bounces.google.com>) id 6a456b44-2eae-0a2a0a5409dd-0a2a4509ddee-42 for ; Wed, 01 Jul 2026 21:32:36 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3UWtFagYKCZYI40D926EE6B4.2ECN4D-34L4BB8IJI.N4DFHE942J.EH6@flex--seanjc.bounces.google.com>) id 6a456b52-97e6-0a2a45090019-d155d6cab14e-3 for ; Wed, 01 Jul 2026 21:32:35 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2ca0d4fb061so13562385ad.3 for ; Wed, 01 Jul 2026 12:32:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934354; x=1783539154; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=evwxLM71EsC76xUKnJUsM6sZDhf4kmGP6xo/jdNLobw=; b=lxUVIHgq8AO7SvMwRCNuRvewFIS2NKjniwRvFBiMfw0yUR0tAHTzcVH1C7PzXzWBXI +YK8tgKQmr8tCHCMYtmPWDFpwp0Op673LizsMvi6kXAOROZGlAb54h/NStk8yxuIw0Ca noUGaNHSz+vcxkQAZDVTNz/GsYFoVDukSR0Vycg8GjlWimY+meKsFyuHjZiK2JF+QXkG S7p6Sygfgqrh1E534KDf11rDel7r8iLHn+yO7MZNxtvyxe+PiwiqOvm2DgQMxGl8hxuW x9smr1AAGmtTM64SWNQ3pnv4SrihYzgfz2yc1Mq5gHfcI2U5KXq2QyAnMS039xVUyJ7N xGfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934354; x=1783539154; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=evwxLM71EsC76xUKnJUsM6sZDhf4kmGP6xo/jdNLobw=; b=hPYRXzSMQTZ0iW8Myo3EIm6UaoXCMqzwJPSDDkhSRQZ3/2Cq+ZN+9KY089shlIdvXx tPURrKNtn1OU1ReMlHfl1Z+YfoxbyWofYhWkpw+Q9y/Fx7TY8jdfCDAz6hQ/OrExctoc HgE81m7wqyKbc7GiwNxiXAewiRfmaCu+IenlpYlJDXIp5nIYwvWQ62MplWTZL5Oyc54r uRiLXW6+nHXlqgFrHb+0rSxHEmO6RKMQFLvGbQlD4IjBY+z8Akq6pkY4GW6nr0T48ZZS muXc7XtNa77dScJnJVLXgdfuolpePjF1RZ3f6+Sdzt2Mkd3hHxW20I9BuIpsUjFKpMpE ATBQ== X-Forwarded-Encrypted: i=1; AHgh+Ro1+1VaaBmBh+bPkzfdBrxHVtWnCPwUNtjEUWvMJHIOHHg8ETNAm5ZTYx1QCgo/ubo0HzH8J4OCP7s=@lists.xenproject.org X-Gm-Message-State: AOJu0YzR+TorBNVTaCe05tRk4CSoTfXmnhUHsyTx3cRkpEHEdFAYxXsw 7tTSKTQWGpZ/KRxZVSubrv7niTWSFNLNyX3LGyAPE0upT7IE4p4D+21itQGmE7fXH+pT+vvvldR gUQEK2g== X-Received: from plha8.prod.google.com ([2002:a17:902:ecc8:b0:2c6:a75b:2129]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:f8c:b0:2c7:d603:117f with SMTP id d9443c01a7336-2ca7e754b82mr34808385ad.26.1782934353608; Wed, 01 Jul 2026 12:32:33 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:27 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-7-seanjc@google.com> Subject: [PATCH v5 06/51] x86/sev: Don't override CPU frequency calibration for SNP's Secure TSC From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934356-4512E986-3CC5EFD8/0/0 X-purgate-type: clean X-purgate-size: 1458 Don't override the kernel's CPU frequency calibration routine when registering SNP's Secure TSC calibration routine. SNP (the architecture) provides zero guarantees that the CPU runs at the same frequency as the TSC. The justification for clobbering the CPU routine was: Since the difference between CPU base and TSC frequency does not apply in this case, the same callback is being used. but that's simply not true. E.g. if APERF/MPERF is exposed to the VM, then the CPU frequency absolutely does matter. While relying on heuristics and/or the untrusted hypervisor to provide the CPU frequency isn't ideal, it's at least not outright wrong. Fixes: 73bbf3b0fbba ("x86/tsc: Init the TSC for Secure TSC guests") Cc: Nikunj A Dadhania Cc: Tom Lendacky Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index ed0ac52a765e..665de1aea0ee 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2046,7 +2046,6 @@ void __init snp_secure_tsc_init(void) snp_tsc_freq_khz = SNP_SCALE_TSC_FREQ(tsc_freq_mhz * 1000, secrets->tsc_factor); - x86_platform.calibrate_cpu = securetsc_get_tsc_khz; x86_platform.calibrate_tsc = securetsc_get_tsc_khz; early_memunmap(mem, PAGE_SIZE); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350372.1607870 (Exim 4.92) (envelope-from ) id 1wf0fn-0000l7-Q3; Wed, 01 Jul 2026 19:32:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350372.1607870; Wed, 01 Jul 2026 19:32:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fn-0000kc-Kq; Wed, 01 Jul 2026 19:32:39 +0000 Received: by outflank-mailman (input) for mailman id 1350372; Wed, 01 Jul 2026 19:32:38 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3UmtFagYKCZcJ51EA37FF7C5.3FDO5E-45M5CC9JKJ.O5EGIFA53K.FI7@flex--seanjc.bounces.google.com>) id 1wf0fm-0000Ks-1X for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:38 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fl-00B3ua-Eq for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:37 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3UmtFagYKCZcJ51EA37FF7C5.3FDO5E-45M5CC9JKJ.O5EGIFA53K.FI7@flex--seanjc.bounces.google.com>) id 6a456b3e-5cb7-0a2a0a5109dd-0a2a4506aae4-24 for ; Wed, 01 Jul 2026 21:32:37 +0200 Received: from [209.85.215.201] (helo=mail-pg1-f201.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3UmtFagYKCZcJ51EA37FF7C5.3FDO5E-45M5CC9JKJ.O5EGIFA53K.FI7@flex--seanjc.bounces.google.com>) id 6a456b53-08de-0a2a45060019-d155d7c9e100-3 for ; Wed, 01 Jul 2026 21:32:37 +0200 Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c96b4f58ddcso763901a12.3 for ; Wed, 01 Jul 2026 12:32:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934355; x=1783539155; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=IPCn9toL5FYXOHslttK0Lqj/45O4+f3kFotppLV6+ls=; b=fKuzCDImPpzNTZoIiyIzudIzmp7PizB2cS8gFCEMti89zInSppOOer90Uaa3SlUzVV TRIthsiBEGLm12JGRsIU9nJIW/LfY56kg8MBtOURzSTW90lUkv0Ejcz3ChZsMTSWH6pR JI1T+Q4oj/LzZjRh3aW8eh9WXQjYd4OLyeIbB3iVSmA8y3M6Qllwy7WbNhdRlAJt+B94 P6EQnNVIY550MiHy9Vmd91gMFBh4xiUrCyObX19Lmdqa6KhAPrgX8rdT4esUZT93Y6L6 VlOK249Sz/OMf0Xa/RmEbO40q9YBKSMnvgCd1+PzUTf3B7vCJtucCwW5Q7kZQUEl/0Fi wNbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934355; x=1783539155; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IPCn9toL5FYXOHslttK0Lqj/45O4+f3kFotppLV6+ls=; b=SOBTWvg56CoQgyRzIhniFsTz4keq1x2/LYn9EvdXsT5IgY5bTnjaWxltYHMovEykAA 4Dufgv+iYDR/s7ClK3bUndhlw/XwDUfpyCCFTuBwkv8G2cJP0LhuxlWkvQTtCKhe2Lc3 Fv0aYsM1eQWIKcRDi4VZUuZGBwhhIBKnqEFU68Ox6MjRh+5oN9ybox0KnIZ9n1qQF8Kf Ea8QDh3vWRGp93HM+YkNXqJSeBfYhO8v46Z65lFrcdbVq9Tl9OGPWNPDbSj7vwsUWHl0 imEwysStr+z9mSMWhsxLOuBNEkHyJ7nmKUqEdAkDz4QZTkfRBn6+nexFZwDT/ij7MBmZ pmUw== X-Forwarded-Encrypted: i=1; AFNElJ+heBJCj2AD8Rb7gJ+D+Abu1qjQvyjNrHuV2KKPYMrujOlHU9XrVt6vezUchnyce6veMhhXjFUxMMo=@lists.xenproject.org X-Gm-Message-State: AOJu0YwVijIU1K4KX+vsX4ayrCN8pb2PkGZTVj4Ej82V2uhMl6akEI9T +5Julx7rKgGTlIVu6l4w/18hlutYBnRqCx8JOMmNSNyNhvanJlzTMcmVs6XZeT5/ZHG9lP6OsuD XvYvaIg== X-Received: from pgll126.prod.google.com ([2002:a63:2584:0:b0:c85:1159:ffb2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6300:6705:b0:3bf:7bf7:7913 with SMTP id adf61e73a8af0-3bff40c93d7mr2592804637.14.1782934354816; Wed, 01 Jul 2026 12:32:34 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:28 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-8-seanjc@google.com> Subject: [PATCH v5 07/51] x86/sev: Move check for SNP Secure TSC support to tsc_early_init() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934357-C5D3D68D-E6CE8521/0/0 X-purgate-type: clean X-purgate-size: 1587 Move the check on having a Secure TSC to the common tsc_early_init() so that it's obvious that having a Secure TSC is conditional, and to prepare for adding TDX to the mix (blindly initializing *both* SNP and TDX TSC logic looks especially weird). No functional change intended. Cc: Tom Lendacky Reviewed-by: Nikunj A Dadhania Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 3 --- arch/x86/kernel/tsc.c | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 665de1aea0ee..403dcea86452 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2025,9 +2025,6 @@ void __init snp_secure_tsc_init(void) unsigned long tsc_freq_mhz; void *mem; - if (!cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) - return; - mem = early_memremap_encrypted(sev_secrets_pa, PAGE_SIZE); if (!mem) { pr_err("Unable to get TSC_FACTOR: failed to map the SNP secrets page.\n"); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 482cc3a8999a..8f1604ffe986 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1509,7 +1509,8 @@ void __init tsc_early_init(void) if (is_early_uv_system()) return; - snp_secure_tsc_init(); + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) + snp_secure_tsc_init(); if (!determine_cpu_tsc_frequencies(true)) return; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350373.1607880 (Exim 4.92) (envelope-from ) id 1wf0fp-00015w-7L; Wed, 01 Jul 2026 19:32:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350373.1607880; Wed, 01 Jul 2026 19:32:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fp-000153-1o; Wed, 01 Jul 2026 19:32:41 +0000 Received: by outflank-mailman (input) for mailman id 1350373; Wed, 01 Jul 2026 19:32:39 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3U2tFagYKCZgK62FB48GG8D6.4GEP6F-56N6DDAKLK.P6FHJGB64L.GJ8@flex--seanjc.bounces.google.com>) id 1wf0fm-0000VF-Sj for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:38 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fm-004o0g-9V for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:38 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3U2tFagYKCZgK62FB48GG8D6.4GEP6F-56N6DDAKLK.P6FHJGB64L.GJ8@flex--seanjc.bounces.google.com>) id 6a456b1f-2eae-0a2a0a5409dd-0a2a4502c3a4-20 for ; Wed, 01 Jul 2026 21:32:38 +0200 Received: from [209.85.210.202] (helo=mail-pf1-f202.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3U2tFagYKCZgK62FB48GG8D6.4GEP6F-56N6DDAKLK.P6FHJGB64L.GJ8@flex--seanjc.bounces.google.com>) id 6a456b54-5a27-0a2a45020019-d155d2caed0c-3 for ; Wed, 01 Jul 2026 21:32:38 +0200 Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-8478e9c4bd2so997146b3a.1 for ; Wed, 01 Jul 2026 12:32:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934356; x=1783539156; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=02bcXtHfI4JvUWCbZ/FGUqsIhMJvDsaJ6tKyxXO+eMA=; b=r89e7hTquq3IsNKcNxsGOucbtQYJTM88FLrRCZYryO9pfn7x/SSJ5VcDpzJgLLJ6dG qETHvw5ZGp9fIsh9Dy6YpXVk7lAKBYcSs7N6diHXxulw31DlcbgJtDE5JMwgTGW1b9XW YGWBLUDu0Cx8icF1YTxcwNg0QIxA2UJBF55PRfFnKCKLnJOMnRHA2PeaajktUlej2+OP Y451paGiTeZlVC5AIh4TG7J2NOs3dIYvMeiUloHP/wJ2Z0Lo0x19ht7qUfopfEympmyJ qfDGBFmFByZUnADRjlYEqPzDSRUl87JfQpb1z9oXBCM6nVebYT2xIYlTlDGdbG7dSmg3 L2Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934356; x=1783539156; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=02bcXtHfI4JvUWCbZ/FGUqsIhMJvDsaJ6tKyxXO+eMA=; b=J1ZDSUiKS8FPpbPgxzRGokTzEq/B4iW8NcdFf7dTZTKgxDZJewwcnq+1VNEEM4YDH5 NIzhOVLQ8jwzo7CdomfvoAgGahKaquAwNs80aVXr+wHGB4/+rjgIE3BXQgYFylic2ldj sdDaBrb1ff9Sn7o52HcxtR0zhuqRqoilpk6ARf/w6c0soqr1Z1Uq2TWsHs4t1bHiWVgx nS1GImr+sOMv/TB5/tg6cibBCWTt5+WtipkDE1gJSGTkLZcg94fMJLcbeJrAxfFBUtsI wPEzwIFvoRM9hw51ietJ7+jXqbwMGZWqZC5YOapOb1PUUez/m9c1nPn+tslSc1Jydkz4 cz3Q== X-Forwarded-Encrypted: i=1; AFNElJ+m/qOqVTrrAr5Q9eLbuHs9Y3gD8decZF97jgt5e3d0CN0Vyw2c8uEkv3GpxoEfMfilMNM+W84m5tU=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw1t+bYrGT/s5JH6uVGEhkuStP3CeoTcwP/V6+Wg86n51Isstwb Cqijeim+EaIYXdo23kx1y/n6llX39rts5ZB8j8oLGBb78pzFNIZR7fXD2P4zP8n7wlFIV9wFsPm L3cVSKw== X-Received: from pgko8.prod.google.com ([2002:a63:f148:0:b0:c99:aff5:708f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:d807:b0:3bf:9a30:3a20 with SMTP id adf61e73a8af0-3bff40a18cemr2476915637.16.1782934355934; Wed, 01 Jul 2026 12:32:35 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:29 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-9-seanjc@google.com> Subject: [PATCH v5 08/51] x86/sev: Shove SNP's secure/trusted TSC frequency directly into "calibration" From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-720697/1782934358-564E97C5-FFECAC6D/0/0 X-purgate-type: clean X-purgate-size: 7153 As a first step towards dropping .calibrate_{cpu,tsc}() and explicitly defining precedence/priority for "calibration" routines, pass the secure TSC frequency obtained from SNP firmware directly to determine_cpu_tsc_frequencies() instead of overriding the .calibrate_tsc() hook. Unlike the native calibration routines, all of the paravirtual overrides, including SNP and TDX, are constant in the sense that the frequency provided by the hypervisor or trusted firmware is fixed, known, and always available during early boot. More importantly, for CoCo (SNP and TDX) VMs, it's imperative that the kernel uses the frequency provided by the trusted firmware, not by the untrusted hypervisor. Enforcing the priority between sources by carefully ordering seemingly unrelated init calls, so that the trusted override "wins", is brittle and all but impossible to follow. Explicitly ignore tsc_early_khz if the exact TSC frequency was obtained from trusted firmware, as per commit bd35c77e32e4 ("x86/tsc: Add tsc_early_khz command line parameter"), the goal of the param is to play nice with setups that provide partial frequency information in CPUID, i.e. is NOT intended to be a hard override. Neither SNP's secure TSC nor TDX was supported when commit bd35c77e32e4 landed back in 2020, i.e. lack of consideration for the interaction was purely due to oversight when SNP and TDX support came along. Signed-off-by: Sean Christopherson --- .../admin-guide/kernel-parameters.txt | 4 +++ arch/x86/coco/sev/core.c | 14 +++-------- arch/x86/include/asm/sev.h | 4 +-- arch/x86/kernel/tsc.c | 25 ++++++++++++++----- 4 files changed, 29 insertions(+), 18 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index b5493a7f8f22..181149f633c3 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -7946,6 +7946,10 @@ Kernel parameters with CPUID.16h support and partial CPUID.15h support. Format: + Note, tsc_early_khz is ignored if the TSC frequency is + provided by trusted firmware when running as an SNP + guest. + tsx= [X86] Control Transactional Synchronization Extensions (TSX) feature in Intel processors that support TSX control. diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 403dcea86452..bc5ae9ef74da 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -99,7 +99,6 @@ static const char * const sev_status_feat_names[] = { */ static u64 snp_tsc_scale __ro_after_init; static u64 snp_tsc_offset __ro_after_init; -static unsigned long snp_tsc_freq_khz __ro_after_init; DEFINE_PER_CPU(struct sev_es_runtime_data*, runtime_data); DEFINE_PER_CPU(struct sev_es_save_area *, sev_vmsa); @@ -2014,15 +2013,10 @@ void __init snp_secure_tsc_prepare(void) pr_debug("SecureTSC enabled"); } -static unsigned long securetsc_get_tsc_khz(void) -{ - return snp_tsc_freq_khz; -} - -void __init snp_secure_tsc_init(void) +unsigned int __init snp_secure_tsc_init(void) { + unsigned long snp_tsc_freq_khz, tsc_freq_mhz; struct snp_secrets_page *secrets; - unsigned long tsc_freq_mhz; void *mem; mem = early_memremap_encrypted(sev_secrets_pa, PAGE_SIZE); @@ -2043,7 +2037,7 @@ void __init snp_secure_tsc_init(void) snp_tsc_freq_khz = SNP_SCALE_TSC_FREQ(tsc_freq_mhz * 1000, secrets->tsc_factor); - x86_platform.calibrate_tsc = securetsc_get_tsc_khz; - early_memunmap(mem, PAGE_SIZE); + + return snp_tsc_freq_khz; } diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h index 594cfa19cbd4..05ebf0b73ef4 100644 --- a/arch/x86/include/asm/sev.h +++ b/arch/x86/include/asm/sev.h @@ -530,7 +530,7 @@ int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_req *req int snp_svsm_vtpm_send_command(u8 *buffer); void __init snp_secure_tsc_prepare(void); -void __init snp_secure_tsc_init(void); +unsigned int snp_secure_tsc_init(void); enum es_result savic_register_gpa(u64 gpa); enum es_result savic_unregister_gpa(u64 *gpa); u64 savic_ghcb_msr_read(u32 reg); @@ -637,7 +637,7 @@ static inline int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_req *req) { return -ENODEV; } static inline int snp_svsm_vtpm_send_command(u8 *buffer) { return -ENODEV; } static inline void __init snp_secure_tsc_prepare(void) { } -static inline void __init snp_secure_tsc_init(void) { } +static inline unsigned int __init snp_secure_tsc_init(void) { return 0; } static inline void sev_evict_cache(void *va, int npages) {} static inline enum es_result savic_register_gpa(u64 gpa) { return ES_UNSUPPORTED; } static inline enum es_result savic_unregister_gpa(u64 *gpa) { return ES_UNSUPPORTED; } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 8f1604ffe986..f049c126e47c 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1440,15 +1440,16 @@ static int __init init_tsc_clocksource(void) */ device_initcall(init_tsc_clocksource); -static bool __init determine_cpu_tsc_frequencies(bool early) +static bool __init determine_cpu_tsc_frequencies(bool early, + unsigned int known_tsc_khz) { /* Make sure that cpu and tsc are not already calibrated */ WARN_ON(cpu_khz || tsc_khz); if (early) { cpu_khz = x86_platform.calibrate_cpu(); - if (tsc_early_khz) - tsc_khz = tsc_early_khz; + if (known_tsc_khz) + tsc_khz = known_tsc_khz; else tsc_khz = x86_platform.calibrate_tsc(); } else { @@ -1503,6 +1504,8 @@ static void __init tsc_enable_sched_clock(void) void __init tsc_early_init(void) { + unsigned int known_tsc_khz = 0; + if (!boot_cpu_has(X86_FEATURE_TSC)) return; /* Don't change UV TSC multi-chassis synchronization */ @@ -1510,9 +1513,19 @@ void __init tsc_early_init(void) return; if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) - snp_secure_tsc_init(); + known_tsc_khz = snp_secure_tsc_init(); - if (!determine_cpu_tsc_frequencies(true)) + /* + * Ignore the user-provided TSC frequency if the exact frequency was + * obtained from trusted firmware, as the user-provided frequency is + * intended as a "starting point", not a known, guaranteed frequency. + */ + if (!known_tsc_khz) + known_tsc_khz = tsc_early_khz; + else if (tsc_early_khz) + pr_err("Ignoring 'tsc_early_khz' in favor of trusted firmware.\n"); + + if (!determine_cpu_tsc_frequencies(true, known_tsc_khz)) return; tsc_enable_sched_clock(); } @@ -1533,7 +1546,7 @@ void __init tsc_init(void) if (!tsc_khz) { /* We failed to determine frequencies earlier, try again */ - if (!determine_cpu_tsc_frequencies(false)) { + if (!determine_cpu_tsc_frequencies(false, 0)) { mark_tsc_unstable("could not calculate TSC khz"); setup_clear_cpu_cap(X86_FEATURE_TSC_DEADLINE_TIMER); return; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350374.1607885 (Exim 4.92) (envelope-from ) id 1wf0fp-0001Bg-T1; Wed, 01 Jul 2026 19:32:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350374.1607885; Wed, 01 Jul 2026 19:32:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fp-0001B4-JM; Wed, 01 Jul 2026 19:32:41 +0000 Received: by outflank-mailman (input) for mailman id 1350374; Wed, 01 Jul 2026 19:32:40 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3VGtFagYKCZkL73GC59HH9E7.5HFQ7G-67O7EEBLML.Q7GIKHC75M.HK9@flex--seanjc.bounces.google.com>) id 1wf0fo-0000nC-2S for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fn-009wqs-FV for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:39 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3VGtFagYKCZkL73GC59HH9E7.5HFQ7G-67O7EEBLML.Q7GIKHC75M.HK9@flex--seanjc.bounces.google.com>) id 6a456b4a-e002-0a2a0a5209dd-0a2a45049d7c-34 for ; Wed, 01 Jul 2026 21:32:39 +0200 Received: from [209.85.210.202] (helo=mail-pf1-f202.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3VGtFagYKCZkL73GC59HH9E7.5HFQ7G-67O7EEBLML.Q7GIKHC75M.HK9@flex--seanjc.bounces.google.com>) id 6a456b55-a01d-0a2a45040019-d155d2cacc45-3 for ; Wed, 01 Jul 2026 21:32:39 +0200 Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-847a90cc5e2so1364488b3a.0 for ; Wed, 01 Jul 2026 12:32:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934357; x=1783539157; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=f4XM+SKEbnv+9fV8zEMQX/tlhGFDki//v0QnInqZVcA=; b=LjMGxlcZe9/21PnqsFCidISoH4+TMUcyJBOijy9FCEn+u+0iZHcoMUmLqKUX6y5ZVO bo/FOer8XdjdunOfT2tDkjFHI/4cYysJzS7AfiiZshQ2pyPXtzD9bRSdVrwFjWIeBGWa zWdQLFDf8gX+oju+QhL7tjFIm06VymrFj9u/jpKT2e/j4QcQ/oM0SKfGujWY7NmrtfWh 9KSNxIXRU5PAvNqFxoPxtqu5q+vnNyAHK6bDrnFdvqDdzEGcQPzxzWUKrxs0xfO3RFaH XNn8qIrCGefoV2ShdQsEjf2vilAXwO1P9Dzm1R0B6l7imZtTPqn53YTswxBshs32Sqfx dAww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934357; x=1783539157; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f4XM+SKEbnv+9fV8zEMQX/tlhGFDki//v0QnInqZVcA=; b=Q8OSZ9uifmUQn+HDwKLhSOABeql6O22F3E0diz1pcD4K4WOthfbj4WSXX2Zjk81IDj 3L6ibpEqu+up8R4EhitEkDhWNjTTGPwxVvFEVg1A+MWrmOYOTyROW7Gxl9Q1h4aRPqAd FTBMJUH2u50aqmNRLxgSql+D32aWj/W5dkvK5CUCHWy/h48K+HCiT7DJ95akNMfePEzk AsBJ9lKqDpuZXKQi8pOGMK8jHA4k0UIGsEq+gdvu9HhAFiIRoWq7d1coKM8+wDomybNO an4OJN31miTq6RWkJCxt0KV3kjLv1JWt3IvRbM3ap/dtVGHups8qqG4hDJUiPDdvr4MF s52A== X-Forwarded-Encrypted: i=1; AFNElJ9Jeq2UUfbQ5qImPL1HZ9SpkY1q5ORzNYn9P98mIkeluIHeBhU9gY/H4Gm9Q9R7bbuhAmHI8bTfskM=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy0Tk3Vch6lKIZH57XDngi5mQqcHCQx/E24KTdnnMpD3I0n8mrT jrDsJkMMR78Sl0Acauu01HhdJpMSeyr15eeusjYnHwcGi6vrmPtO+NWoLttUmST93ke/hcBFwll sIgvk9A== X-Received: from pgge10.prod.google.com ([2002:a63:db0a:0:b0:c8c:b193:3b13]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:a104:b0:3bf:6c08:fb81 with SMTP id adf61e73a8af0-3bfed44c700mr3262662637.49.1782934356969; Wed, 01 Jul 2026 12:32:36 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:30 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-10-seanjc@google.com> Subject: [PATCH v5 09/51] x86/tsc: Add a standalone helper for getting TSC info from CPUID.0x15 From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934359-ACB3B1CC-91C33C96/0/0 X-purgate-type: clean X-purgate-size: 4244 Extract retrieval of TSC frequency information from CPUID into a standalone helper so that TDX guest support can reuse the logic. Opportunistically drop native_calibrate_tsc()'s "== 0" and "!= 0" checks in favor of the kernel's preferred style. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 61 +++++++++++++++++++++++++++---------------- 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index f049c126e47c..12043812c8f5 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -645,46 +645,62 @@ static unsigned long quick_pit_calibrate(void) return delta; } +struct cpuid_tsc_info { + unsigned int denominator; + unsigned int numerator; + unsigned int crystal_khz; +}; + +static int cpuid_get_tsc_info(struct cpuid_tsc_info *info) +{ + unsigned int ecx_hz, edx; + + if (boot_cpu_data.cpuid_level < CPUID_LEAF_TSC) + return -ENOENT; + + /* CPUID 15H TSC/Crystal ratio, plus optionally Crystal Hz */ + cpuid(CPUID_LEAF_TSC, &info->denominator, &info->numerator, &ecx_hz, &edx); + + if (!info->denominator || !info->numerator) + return -ENOENT; + + /* + * Note: some CPUs provide the multiplier information, but not the core + * crystal frequency. The multiplier information is still useful for + * such CPUs, as the crystal frequency can be gleaned from CPUID.0x16. + */ + info->crystal_khz = ecx_hz / 1000; + return 0; +} + /** * native_calibrate_tsc - determine TSC frequency * Determine TSC frequency via CPUID, else return 0. */ unsigned long native_calibrate_tsc(void) { - unsigned int eax_denominator, ebx_numerator, ecx_hz, edx; - unsigned int crystal_khz; + struct cpuid_tsc_info info; if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) return 0; - if (boot_cpu_data.cpuid_level < CPUID_LEAF_TSC) + if (cpuid_get_tsc_info(&info)) return 0; - eax_denominator = ebx_numerator = ecx_hz = edx = 0; - - /* CPUID 15H TSC/Crystal ratio, plus optionally Crystal Hz */ - cpuid(CPUID_LEAF_TSC, &eax_denominator, &ebx_numerator, &ecx_hz, &edx); - - if (ebx_numerator == 0 || eax_denominator == 0) - return 0; - - crystal_khz = ecx_hz / 1000; - /* * Denverton SoCs don't report crystal clock, and also don't support * CPUID_LEAF_FREQ for the calculation below, so hardcode the 25MHz * crystal clock. */ - if (crystal_khz == 0 && - boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT_D) - crystal_khz = 25000; + if (!info.crystal_khz && boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT_D) + info.crystal_khz = 25000; /* * TSC frequency reported directly by CPUID is a "hardware reported" * frequency and is the most accurate one so far we have. This * is considered a known frequency. */ - if (crystal_khz != 0) + if (info.crystal_khz) setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); /* @@ -692,15 +708,14 @@ unsigned long native_calibrate_tsc(void) * clock, but we can easily calculate it to a high degree of accuracy * by considering the crystal ratio and the CPU speed. */ - if (crystal_khz == 0 && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) { + if (!info.crystal_khz && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) { unsigned int eax_base_mhz, ebx, ecx, edx; cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx, &ecx, &edx); - crystal_khz = eax_base_mhz * 1000 * - eax_denominator / ebx_numerator; + info.crystal_khz = eax_base_mhz * 1000 * info.denominator / info.numerator; } - if (crystal_khz == 0) + if (!info.crystal_khz) return 0; /* @@ -716,9 +731,9 @@ unsigned long native_calibrate_tsc(void) * lapic_timer_period here to avoid having to calibrate the APIC * timer later. */ - apic_set_timer_period_khz(crystal_khz, "CPUID 0x15/0x16"); + apic_set_timer_period_khz(info.crystal_khz, "CPUID 0x15/0x16"); - return crystal_khz * ebx_numerator / eax_denominator; + return info.crystal_khz * info.numerator / info.denominator; } static unsigned long cpu_khz_from_cpuid(void) -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350375.1607896 (Exim 4.92) (envelope-from ) id 1wf0fr-0001bV-Hh; Wed, 01 Jul 2026 19:32:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350375.1607896; Wed, 01 Jul 2026 19:32:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fr-0001a3-AW; Wed, 01 Jul 2026 19:32:43 +0000 Received: by outflank-mailman (input) for mailman id 1350375; Wed, 01 Jul 2026 19:32:41 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3VmtFagYKCZsN95IE7BJJBG9.7JHS9I-89Q9GGDNON.S9IKMJE97O.JMB@flex--seanjc.bounces.google.com>) id 1wf0fp-00014U-4i for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fo-00B3ua-Ho for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:40 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3VmtFagYKCZsN95IE7BJJBG9.7JHS9I-89Q9GGDNON.S9IKMJE97O.JMB@flex--seanjc.bounces.google.com>) id 6a456b2a-5cb7-0a2a0a5109dd-0a2a450184e4-20 for ; Wed, 01 Jul 2026 21:32:40 +0200 Received: from [209.85.215.202] (helo=mail-pg1-f202.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3VmtFagYKCZsN95IE7BJJBG9.7JHS9I-89Q9GGDNON.S9IKMJE97O.JMB@flex--seanjc.bounces.google.com>) id 6a456b57-400f-0a2a45010019-d155d7cabc2b-3 for ; Wed, 01 Jul 2026 21:32:40 +0200 Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c89704da8c7so1485718a12.0 for ; Wed, 01 Jul 2026 12:32:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934358; x=1783539158; darn=lists.xenproject.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:from:to:cc:subject:date :message-id:reply-to; bh=5dPlSt+N6Lt/Y9ZvBDGnN+olGzf3s7mk8869JKIa0HY=; b=MkWv0KXC4MXx6lGf//onmiIqh4yNwvQDXfcA2irvSslqrWxpkVO2AQG2SHgvRLeKND xKFW4TMiXR4aqkmmS70BFTQW1muy4PT2/9/m6M3sff8IMcfGI2XJaZy+k+Ne3p3M172d JBWpgEqqipqXxNyS+aTPrdHrkqkvLfXKcOx+28orrpACwbKyKAnecDI9pcjAFA0j6Bcd XcAt7M6irExNt8aKY8sajLYg+ABjTJtyLkLYZVZUfoaF+1QUFL0anBbz/aRktlytvkmK MFDyKvV6CJuU68aStM+KniqZJcyL2C7KCd7qNRugVucRoQyfp0dU69HfuZOt//EhVCIB NZfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934358; x=1783539158; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5dPlSt+N6Lt/Y9ZvBDGnN+olGzf3s7mk8869JKIa0HY=; b=I4V4xejZrMqrJoxpos/IBM65flAzDyv8iYUNX9XS4sGa9Bd/1WgWZastUdNm2/KQ2e ETfvwrrSY+kVRxVicBjTufXHQXhcWdRfPEq35Xq7xFDCuI4WHKWdF+AJuu4N34eW6Grt BxfzZoRvaNcE/wUj54549Kyb7BmG4uHMD7Ud4nYZPXu+rwGFAAIuPw3SKSeXXzLNlemv SZmaYZ9WiEooff02STzeD/GvaiSQj1bODEzCfjI+E+snNuPGWM5p4xmrkYpGaEFYg9jH dWmjb39daaVq684qW8lChgulMIh5OFbKBWQounbPoh3oU6jpIiUWbVj1V3jTs5PFPl2v d2XA== X-Forwarded-Encrypted: i=1; AFNElJ9ySgVDKW+YAMoOb2KW2j7br4eTbdCtDSYDYaFogGwtP99q48iCWzFzN5dZfKO7CBiHbGyoGcw/e+A=@lists.xenproject.org X-Gm-Message-State: AOJu0YyQb73iRe7wwEhIR1iwOmot+KvcigpGVIo5ILwVU7ZjE/sppkaj Z5uFeNC7ri8TwfOgQYS0zz1lPTRVR3icU8Iz8rUJsBD0CMEDRNvEED/vLph57p35v4RgsYPsqY6 ISYQjiw== X-Received: from pgmo11.prod.google.com ([2002:a63:5d4b:0:b0:c9e:63b8:11b5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:d10e:b0:3b4:61f:1fec with SMTP id adf61e73a8af0-3bfed1c323amr3402841637.2.1782934358113; Wed, 01 Jul 2026 12:32:38 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:31 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-11-seanjc@google.com> Subject: [PATCH v5 10/51] x86/tdx: Force TSC frequency with CPUID-based info provided by the TDX-Module From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d62444/1782934360-800EC1E0-D0B58536/0/0 X-purgate-type: clean X-purgate-size: 6605 When running as a TDX guest, explicitly set the TSC frequency to a known value, using CPUID-based information, instead of potentially relying on a hypervisor-controlled PV routine. For TDX guests, CPUID.0x15 is always emulated by the TDX-Module, i.e. the information from CPUID is more trustworthy than the information provided by the hypervisor. To maintain backwards compatibility with TDX guest kernels that use native calibration, and because it's the least awful option, retain native_calibrate_tsc()'s stuffing of the local APIC bus period using the core crystal frequency. While it's entirely possible for the hypervisor to emulate the APIC timer at a different frequency than the core crystal frequency, the commonly accepted interpretation of Intel's SDM is that APIC timer runs at the core crystal frequency when that latter is enumerated via CPUID: The APIC timer frequency will be the processor=E2=80=99s bus clock or cor= e crystal clock frequency (when TSC/core crystal clock ratio is enumerated in CPUID leaf 0x15). If the hypervisor is malicious and deliberately runs the APIC timer at the wrong frequency, nothing would stop the hypervisor from modifying the frequency at any time, i.e. attempting to manually calibrate the frequency out of paranoia would be futile. Deliberately leave CPU frequency calibration as is, since the TDX-Module doesn't provide any guarantees with respect to CPUID.0x16. Expose and use cpuid_get_tsc_info() instead of providing a wrapper to get the TSC and core crystal frequency, as TDX is the only anticipated user outside of the TSC code, i.e. adding a helper to dedup the math won't actually dedup anything. Having TDX use "struct cpuid_tsc_info" also avoids the temptation of declaring a local "tsc_khz" variable and thus unintentionally creating a shadow of the global "tsc_khz". Cc: Kiryl Shutsemau (Meta) Signed-off-by: Sean Christopherson --- .../admin-guide/kernel-parameters.txt | 4 ++-- arch/x86/coco/tdx/tdx.c | 20 ++++++++++++++++--- arch/x86/include/asm/tdx.h | 2 ++ arch/x86/include/asm/tsc.h | 7 +++++++ arch/x86/kernel/tsc.c | 11 ++++------ 5 files changed, 32 insertions(+), 12 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentatio= n/admin-guide/kernel-parameters.txt index 181149f633c3..490e6aa72fc2 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -7947,8 +7947,8 @@ Kernel parameters Format: =20 Note, tsc_early_khz is ignored if the TSC frequency is - provided by trusted firmware when running as an SNP - guest. + provided by trusted firmware when running as an SNP or + TDX guest. =20 tsx=3D [X86] Control Transactional Synchronization Extensions (TSX) feature in Intel processors that diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c index 29b6f1ed59ec..ae2d35f2ef33 100644 --- a/arch/x86/coco/tdx/tdx.c +++ b/arch/x86/coco/tdx/tdx.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -1123,9 +1124,6 @@ void __init tdx_early_init(void) =20 setup_force_cpu_cap(X86_FEATURE_TDX_GUEST); =20 - /* TSC is the only reliable clock in TDX guest */ - setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); - cc_vendor =3D CC_VENDOR_INTEL; =20 /* Configure the TD */ @@ -1195,3 +1193,19 @@ void __init tdx_early_init(void) =20 tdx_announce(); } + +unsigned int __init tdx_tsc_init(void) +{ + struct cpuid_tsc_info info; + + if (WARN_ON_ONCE(cpuid_get_tsc_info(&info) || !info.crystal_khz)) + return 0; + + apic_set_timer_period_khz(info.crystal_khz, "TDX-Module via CPUID"); + + /* TSC is the only reliable clock in TDX guest */ + setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); + setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); + + return info.crystal_khz * info.numerator / info.denominator; +} diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h index 89e97d5761d8..d23ff06db41a 100644 --- a/arch/x86/include/asm/tdx.h +++ b/arch/x86/include/asm/tdx.h @@ -68,6 +68,7 @@ struct ve_info { #ifdef CONFIG_INTEL_TDX_GUEST =20 void __init tdx_early_init(void); +unsigned int __init tdx_tsc_init(void); =20 void tdx_get_ve_info(struct ve_info *ve); =20 @@ -89,6 +90,7 @@ void __init tdx_dump_td_ctls(u64 td_ctls); #else =20 static inline void tdx_early_init(void) { }; +static inline unsigned int tdx_tsc_init(void) { return 0; } static inline void tdx_halt(void) { }; =20 static inline bool tdx_early_handle_ve(struct pt_regs *regs) { return fals= e; } diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h index 4d2d2f21ff06..b6b86e24e1bf 100644 --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -82,6 +82,13 @@ static inline cycles_t get_cycles(void) } #define get_cycles get_cycles =20 +struct cpuid_tsc_info { + unsigned int denominator; + unsigned int numerator; + unsigned int crystal_khz; +}; +extern int cpuid_get_tsc_info(struct cpuid_tsc_info *info); + extern void tsc_early_init(void); extern void tsc_init(void); extern void mark_tsc_unstable(char *reason); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 12043812c8f5..86384a83a5f6 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -34,6 +34,7 @@ #include #include #include +#include =20 unsigned int __read_mostly cpu_khz; /* TSC clocks / usec, not used here */ EXPORT_SYMBOL(cpu_khz); @@ -645,13 +646,7 @@ static unsigned long quick_pit_calibrate(void) return delta; } =20 -struct cpuid_tsc_info { - unsigned int denominator; - unsigned int numerator; - unsigned int crystal_khz; -}; - -static int cpuid_get_tsc_info(struct cpuid_tsc_info *info) +int cpuid_get_tsc_info(struct cpuid_tsc_info *info) { unsigned int ecx_hz, edx; =20 @@ -1529,6 +1524,8 @@ void __init tsc_early_init(void) =20 if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) known_tsc_khz =3D snp_secure_tsc_init(); + else if (boot_cpu_has(X86_FEATURE_TDX_GUEST)) + known_tsc_khz =3D tdx_tsc_init(); =20 /* * Ignore the user-provided TSC frequency if the exact frequency was --=20 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350377.1607903 (Exim 4.92) (envelope-from ) id 1wf0fs-0001jc-F9; Wed, 01 Jul 2026 19:32:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350377.1607903; Wed, 01 Jul 2026 19:32:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fs-0001iD-1e; Wed, 01 Jul 2026 19:32:44 +0000 Received: by outflank-mailman (input) for mailman id 1350377; Wed, 01 Jul 2026 19:32:42 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3V2tFagYKCZwOA6JF8CKKCHA.8KITAJ-9ARAHHEOPO.TAJLNKFA8P.KNC@flex--seanjc.bounces.google.com>) id 1wf0fq-0001Fn-9L for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fp-009wqs-M6 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:41 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3V2tFagYKCZwOA6JF8CKKCHA.8KITAJ-9ARAHHEOPO.TAJLNKFA8P.KNC@flex--seanjc.bounces.google.com>) id 6a456b4a-e002-0a2a0a5209dd-0a2a45049d7c-42 for ; Wed, 01 Jul 2026 21:32:41 +0200 Received: from [209.85.210.201] (helo=mail-pf1-f201.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3V2tFagYKCZwOA6JF8CKKCHA.8KITAJ-9ARAHHEOPO.TAJLNKFA8P.KNC@flex--seanjc.bounces.google.com>) id 6a456b58-a01d-0a2a45040019-d155d2c9d57f-3 for ; Wed, 01 Jul 2026 21:32:41 +0200 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-847b8d76e3dso1507200b3a.1 for ; Wed, 01 Jul 2026 12:32:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934359; x=1783539159; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=ITMoYQtDH7A346RlpjwfIOo+apTMWXSUo7by9rtr/s0=; b=elMQXmi/uZp73fGpzW1TvkyH6kOqmlf7TCafzSjAm4JoN7qEuRomA/ALPOVha7FivA JsIN0xqEuUA1LqYUwh429soCyPcVvGAPC+GPUkgTzVvtlFD+eS+wgdQHk74xyZeeRUnv Uz9pgnslWMazLKZbD00CHcZbpQ9rXrHRdMKAjdcfA+wbzdlm/jnRrnkkDCXylHu+PX+4 +RkWXRswmof2EUpJMd1sx2EC7WUGLS1JZIB+RE2ODO67z8IOw70Abyb0N3GT+vHbFFua L4iw89U2QfYDYVgiKE/E88+U1Qwiq05VLdCrN+0oXpjyEgACCRTHM9e1IyD69mk80udt S3Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934359; x=1783539159; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ITMoYQtDH7A346RlpjwfIOo+apTMWXSUo7by9rtr/s0=; b=d/jwqXO8DyMyCQF+uA5I9KfepmlOCqRre3GVVAsvpMiXgtvvbarf0IMzWlNxUsblb4 S1Ebx7JcYft6DWY3ZrO3jmWcKKMuK6dkhlDF+qz34bpesDAz5d53SPD6Ut1QtLxywXRs uqa7b3uB/A+KbfZ8Ys9YIKZK0BbBBQlmg82Fxb7mFmT41LiivAOdT8SLDu8GXF1uv1qW FbXk/68Oo91BEKXGP+mafu37QnXSls8876dFJh8AwF7xo9qZHV1JNB9FnsyMB+slIAE3 J65FsE/0ECVn1X+00udYLfRsN4oPIYOAzvUFRRjy1iqNs6x65qutCkTPmdoruxc0+bvq thXA== X-Forwarded-Encrypted: i=1; AFNElJ8LFuPXt2tuHrV6Af7KsAj4kVx9gGJw467ZPpFvhweNnLs5m9xTh4HzgDnKwHZlaXzIcF+5uwwU+i8=@lists.xenproject.org X-Gm-Message-State: AOJu0YxNEOYDV5KVaPJqk5RJr9y3sGcxpxm2gZu2Hy5tKG9HMmNUjU3M JkRcBQINOeuqgcRtRAT/PvLnn8faiLrcrD4nqSSadtOLVJHLy+3IZHCmH5iu9YAIAAyytuyKLwg OjHKheA== X-Received: from pgaf14.prod.google.com ([2002:a63:380e:0:b0:c98:2639:852e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:b93:b0:842:57e8:1bdb with SMTP id d2e1a72fcca58-847c07be445mr3013550b3a.20.1782934359203; Wed, 01 Jul 2026 12:32:39 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:32 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-12-seanjc@google.com> Subject: [PATCH v5 11/51] x86/tsc: Add dedicated hypervisor hooks for getting known TSC/CPU frequencies From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934361-2E1A71CC-4FA4A416/0/0 X-purgate-type: clean X-purgate-size: 12591 Add dedicated hypervisor hooks for getting known TSC/CPU frequencies instead of overriding seemingly generic platform hooks, and explicitly priotize hypervisor-provided frequencies over native methods, but do NOT clobber the frequency obtained from trusted firmware. While shuffling the hooks around is arguably "six of one, half dozen of the other", scoping them to x86_hyper_init makes their purpose more obvious, and allows for explicitly defining the priority of sources (as is done here). As is already done when trusted firmware provides the TSC frequency, ignore ignore tsc_early_khz if the exact TSC frequency was obtained from the hypervisor, as attempting to refine the TSC frequency when running in a VM is all but guaranteed to cause problems sooner or later due to the calibration sources being emulated devices in the vast majority of setups. Cc: David Woodhouse Signed-off-by: Sean Christopherson --- .../admin-guide/kernel-parameters.txt | 3 +- arch/x86/include/asm/acrn.h | 5 ---- arch/x86/include/asm/x86_init.h | 4 +++ arch/x86/kernel/cpu/acrn.c | 10 +++++-- arch/x86/kernel/cpu/mshyperv.c | 6 ++-- arch/x86/kernel/cpu/vmware.c | 8 ++--- arch/x86/kernel/jailhouse.c | 6 ++-- arch/x86/kernel/kvmclock.c | 6 ++-- arch/x86/kernel/tsc.c | 29 ++++++++++++++----- arch/x86/xen/time.c | 4 +-- 10 files changed, 50 insertions(+), 31 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 490e6aa72fc2..a387bb2c47e2 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -7948,7 +7948,8 @@ Kernel parameters Note, tsc_early_khz is ignored if the TSC frequency is provided by trusted firmware when running as an SNP or - TDX guest. + TDX guest, or when the hypervisor provides the exact + frequency via a paravirtual interface. tsx= [X86] Control Transactional Synchronization Extensions (TSX) feature in Intel processors that diff --git a/arch/x86/include/asm/acrn.h b/arch/x86/include/asm/acrn.h index db42b477c41d..a892179c61c6 100644 --- a/arch/x86/include/asm/acrn.h +++ b/arch/x86/include/asm/acrn.h @@ -32,11 +32,6 @@ static inline u32 acrn_cpuid_base(void) return 0; } -static inline unsigned long acrn_get_tsc_khz(void) -{ - return cpuid_eax(ACRN_CPUID_TIMING_INFO); -} - /* * Hypercalls for ACRN * diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 953d3199408a..0c89bf40f507 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -123,6 +123,8 @@ struct x86_init_pci { * @msi_ext_dest_id: MSI supports 15-bit APIC IDs * @init_mem_mapping: setup early mappings during init_mem_mapping() * @init_after_bootmem: guest init after boot allocator is finished + * @get_tsc_khz: get the TSC frequency (returns 0 if frequency is unknown) + * @get_cpu_khz: get the CPU frequency (returns 0 if frequency is unknown) */ struct x86_hyper_init { void (*init_platform)(void); @@ -131,6 +133,8 @@ struct x86_hyper_init { bool (*msi_ext_dest_id)(void); void (*init_mem_mapping)(void); void (*init_after_bootmem)(void); + unsigned int (*get_tsc_khz)(void); + unsigned int (*get_cpu_khz)(void); }; /** diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index dc119af83524..ad8f2da8003b 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -24,13 +24,15 @@ static u32 __init acrn_detect(void) return acrn_cpuid_base(); } +static unsigned int __init acrn_get_tsc_khz(void) +{ + return cpuid_eax(ACRN_CPUID_TIMING_INFO); +} + static void __init acrn_init_platform(void) { /* Install system interrupt handler for ACRN hypervisor callback */ sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); - - x86_platform.calibrate_tsc = acrn_get_tsc_khz; - x86_platform.calibrate_cpu = acrn_get_tsc_khz; } static bool acrn_x2apic_available(void) @@ -78,4 +80,6 @@ const __initconst struct hypervisor_x86 x86_hyper_acrn = { .type = X86_HYPER_ACRN, .init.init_platform = acrn_init_platform, .init.x2apic_available = acrn_x2apic_available, + .init.get_tsc_khz = acrn_get_tsc_khz, + .init.get_cpu_khz = acrn_get_tsc_khz, }; diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 87beecec76f0..f9bc1c2d8c93 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -395,7 +395,7 @@ static int hv_nmi_unknown(unsigned int val, struct pt_regs *regs) } #endif -static unsigned long hv_get_tsc_khz(void) +static unsigned int __init hv_get_tsc_khz(void) { unsigned long freq; @@ -573,8 +573,8 @@ static void __init ms_hyperv_init_platform(void) if (ms_hyperv.features & HV_ACCESS_FREQUENCY_MSRS && ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) { - x86_platform.calibrate_tsc = hv_get_tsc_khz; - x86_platform.calibrate_cpu = hv_get_tsc_khz; + x86_init.hyper.get_tsc_khz = hv_get_tsc_khz; + x86_init.hyper.get_cpu_khz = hv_get_tsc_khz; setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 13b97265c535..3cb473cae462 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -64,7 +64,7 @@ struct vmware_steal_time { u64 reserved[7]; }; -static unsigned long vmware_tsc_khz __ro_after_init; +static unsigned long vmware_tsc_khz __initdata; static u8 vmware_hypercall_mode __ro_after_init; unsigned long vmware_hypercall_slow(unsigned long cmd, @@ -137,7 +137,7 @@ static inline int __vmware_platform(void) return eax != UINT_MAX && ebx == VMWARE_HYPERVISOR_MAGIC; } -static unsigned long vmware_get_tsc_khz(void) +static unsigned int __init vmware_get_tsc_khz(void) { return vmware_tsc_khz; } @@ -419,8 +419,8 @@ static void __init vmware_platform_setup(void) } vmware_tsc_khz = tsc_khz; - x86_platform.calibrate_tsc = vmware_get_tsc_khz; - x86_platform.calibrate_cpu = vmware_get_tsc_khz; + x86_init.hyper.get_tsc_khz = vmware_get_tsc_khz; + x86_init.hyper.get_cpu_khz = vmware_get_tsc_khz; /* Skip lapic calibration since we know the bus frequency. */ apic_set_timer_period_hz(ecx, "VMware hypervisor"); diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c index f2d4ef89c085..e24c05ab4fae 100644 --- a/arch/x86/kernel/jailhouse.c +++ b/arch/x86/kernel/jailhouse.c @@ -68,7 +68,7 @@ static void __init jailhouse_timer_init(void) apic_set_timer_period_khz(setup_data.v1.apic_khz, "Jailhouse hypervisor"); } -static unsigned long jailhouse_get_tsc(void) +static unsigned int __init jailhouse_get_tsc(void) { return precalibrated_tsc_khz; } @@ -210,8 +210,6 @@ static void __init jailhouse_init_platform(void) x86_init.mpparse.parse_smp_cfg = jailhouse_parse_smp_config; x86_init.pci.arch_init = jailhouse_pci_arch_init; - x86_platform.calibrate_cpu = jailhouse_get_tsc; - x86_platform.calibrate_tsc = jailhouse_get_tsc; x86_platform.get_wallclock = jailhouse_get_wallclock; x86_platform.legacy.rtc = 0; x86_platform.legacy.warm_reset = 0; @@ -293,5 +291,7 @@ const struct hypervisor_x86 x86_hyper_jailhouse __refconst = { .detect = jailhouse_detect, .init.init_platform = jailhouse_init_platform, .init.x2apic_available = jailhouse_x2apic_available, + .init.get_tsc_khz = jailhouse_get_tsc, + .init.get_cpu_khz = jailhouse_get_tsc, .ignore_nopv = true, }; diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index cb3d0ca1fa22..4f8299303a19 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -136,7 +136,7 @@ static inline void kvm_sched_clock_init(bool stable) * poll of guests can be running and trouble each other. So we preset * lpj here */ -static unsigned long kvm_get_tsc_khz(void) +static unsigned int __init kvm_get_tsc_khz(void) { setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return pvclock_tsc_khz(this_cpu_pvti()); @@ -343,8 +343,8 @@ void __init kvmclock_init(void) flags = pvclock_read_flags(&hv_clock_boot[0].pvti); kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); - x86_platform.calibrate_tsc = kvm_get_tsc_khz; - x86_platform.calibrate_cpu = kvm_get_tsc_khz; + x86_init.hyper.get_tsc_khz = kvm_get_tsc_khz; + x86_init.hyper.get_cpu_khz = kvm_get_tsc_khz; x86_platform.get_wallclock = kvm_get_wallclock; x86_platform.set_wallclock = kvm_set_wallclock; #ifdef CONFIG_X86_LOCAL_APIC diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 86384a83a5f6..1dca9464b41c 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1451,13 +1451,17 @@ static int __init init_tsc_clocksource(void) device_initcall(init_tsc_clocksource); static bool __init determine_cpu_tsc_frequencies(bool early, + unsigned int known_cpu_khz, unsigned int known_tsc_khz) { /* Make sure that cpu and tsc are not already calibrated */ WARN_ON(cpu_khz || tsc_khz); if (early) { - cpu_khz = x86_platform.calibrate_cpu(); + if (known_cpu_khz) + cpu_khz = known_cpu_khz; + else + cpu_khz = x86_platform.calibrate_cpu(); if (known_tsc_khz) tsc_khz = known_tsc_khz; else @@ -1514,7 +1518,7 @@ static void __init tsc_enable_sched_clock(void) void __init tsc_early_init(void) { - unsigned int known_tsc_khz = 0; + unsigned int known_cpu_khz = 0, known_tsc_khz = 0; if (!boot_cpu_has(X86_FEATURE_TSC)) return; @@ -1522,22 +1526,33 @@ void __init tsc_early_init(void) if (is_early_uv_system()) return; + if (x86_init.hyper.get_cpu_khz) + known_cpu_khz = x86_init.hyper.get_cpu_khz(); + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) known_tsc_khz = snp_secure_tsc_init(); else if (boot_cpu_has(X86_FEATURE_TDX_GUEST)) known_tsc_khz = tdx_tsc_init(); + /* + * If the TSC frequency wasn't provided by trusted firmware, try to get + * it from the hypervisor (which is untrusted when running as a CoCo guest). + */ + if (!known_tsc_khz && x86_init.hyper.get_tsc_khz) + known_tsc_khz = x86_init.hyper.get_tsc_khz(); + /* * Ignore the user-provided TSC frequency if the exact frequency was - * obtained from trusted firmware, as the user-provided frequency is - * intended as a "starting point", not a known, guaranteed frequency. + * obtained from trusted firmware or the hypervisor, as the user- + * provided frequency is intended as a "starting point", not a known, + * guaranteed frequency. */ if (!known_tsc_khz) known_tsc_khz = tsc_early_khz; else if (tsc_early_khz) - pr_err("Ignoring 'tsc_early_khz' in favor of trusted firmware.\n"); + pr_err("Ignoring 'tsc_early_khz' in favor of firmware/hypervisor.\n"); - if (!determine_cpu_tsc_frequencies(true, known_tsc_khz)) + if (!determine_cpu_tsc_frequencies(true, known_cpu_khz, known_tsc_khz)) return; tsc_enable_sched_clock(); } @@ -1558,7 +1573,7 @@ void __init tsc_init(void) if (!tsc_khz) { /* We failed to determine frequencies earlier, try again */ - if (!determine_cpu_tsc_frequencies(false, 0)) { + if (!determine_cpu_tsc_frequencies(false, 0, 0)) { mark_tsc_unstable("could not calculate TSC khz"); setup_clear_cpu_cap(X86_FEATURE_TSC_DEADLINE_TIMER); return; diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index d62c14334b35..1adb44fdddb2 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -38,7 +38,7 @@ static u64 xen_sched_clock_offset __read_mostly; /* Get the TSC speed from Xen */ -static unsigned long xen_tsc_khz(void) +static unsigned int __init xen_tsc_khz(void) { struct pvclock_vcpu_time_info *info = &HYPERVISOR_shared_info->vcpu_info[0].time; @@ -569,7 +569,7 @@ static void __init xen_init_time_common(void) static_call_update(pv_steal_clock, xen_steal_clock); paravirt_set_sched_clock(xen_sched_clock); - x86_platform.calibrate_tsc = xen_tsc_khz; + x86_init.hyper.get_tsc_khz = xen_tsc_khz; x86_platform.get_wallclock = xen_get_wallclock; } -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350378.1607908 (Exim 4.92) (envelope-from ) id 1wf0ft-0001yQ-J0; Wed, 01 Jul 2026 19:32:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350378.1607908; Wed, 01 Jul 2026 19:32:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0ft-0001xO-90; Wed, 01 Jul 2026 19:32:45 +0000 Received: by outflank-mailman (input) for mailman id 1350378; Wed, 01 Jul 2026 19:32:43 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3WGtFagYKCZ0PB7KG9DLLDIB.9LJUBK-ABSBIIFPQP.UBKMOLGB9Q.LOD@flex--seanjc.bounces.google.com>) id 1wf0fr-0001aG-GD for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fq-009wqs-TH for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:42 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3WGtFagYKCZ0PB7KG9DLLDIB.9LJUBK-ABSBIIFPQP.UBKMOLGB9Q.LOD@flex--seanjc.bounces.google.com>) id 6a456b38-e002-0a2a0a5209dd-0a2a450cae0a-46 for ; Wed, 01 Jul 2026 21:32:42 +0200 Received: from [209.85.210.201] (helo=mail-pf1-f201.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3WGtFagYKCZ0PB7KG9DLLDIB.9LJUBK-ABSBIIFPQP.UBKMOLGB9Q.LOD@flex--seanjc.bounces.google.com>) id 6a456b59-f399-0a2a450c0019-d155d2c9dd31-3 for ; Wed, 01 Jul 2026 21:32:42 +0200 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-84622d6102dso1270894b3a.1 for ; Wed, 01 Jul 2026 12:32:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934361; x=1783539161; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=ReYT3wow7KWZM4WGFuJpCOGL6Ebh0IHq2felz3Yetls=; b=l9Lhx9UESF570Gz6ewNRjf8oOGu5ypXjoNYsvbTHNvSxUGSQXCJCjHnpBiIPNCGNNJ +7HCGa9bvp9YY8xxYH/UXHEgyN6mvCtBq5kqvcNcvvOWKnkpJvtRyjn4M200bM12rCie XBXAzBP82IosoWBuq62LXvUCjt3XMQgKT34OR4oDAoVJ5HhVBno5gGXGN5wrFGSt+23E N154zg3ixOX+PUSAkJcf4R2zc7qb516dG1oO+1Qtw1T275+V7tahqaBbN6eTxAyJzoIx uRuJs2zrhsf9YQYhXMV16F7zN7XWcbRRG8HHPcGS7ihFQIuIcueH1ITuvh0B+0CjquY2 hGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934361; x=1783539161; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ReYT3wow7KWZM4WGFuJpCOGL6Ebh0IHq2felz3Yetls=; b=fZ2NW0hKGfQChF7anEk8dibRbQ7jgVSQSx0wC32E+mQmiegrs1gzD3Xpmtao67LfP6 Jq4vIk/QoOKpXHmTZ9KvGVPZRyzvpkdpViLkNpsCt2Rksd27jjxXpvUR3jdrppv4LpZf PtGPtxO/ahBSv6eVtRg+wC4t4dUVPFkP9KKCssCvppmQsyIrzd3wCx4oq9/y1vm9pjxe H4zHDmlG1FdVHBD5ExLZ2Bx4DUrjC434j1FCsDUrRv2spL64jb8CeWE3QRRGClg7s0V8 wFq51563Oa8uVCNP2kUlDl/XMa0IO6iZ/zcJf8lwmf8aznkT7ILhzU7bI/oxetwMoyyi VgsA== X-Forwarded-Encrypted: i=1; AFNElJ+3wMICgmC7CG6fIRA0LgC3r/cnLo18/A7EdpwRuu2J9nfIfJW6qmaAbt/tWB/x3uWPPbSHRggdQtw=@lists.xenproject.org X-Gm-Message-State: AOJu0YxiWnhOOW2TeRL197MMAKwQQoFcx1kZNOTo+Pbmi+g4XBabT6Q7 aFjGPGbeXEhL9kGuIqxiQnl7feOPX1UNftTy8AzgmZIaF3sWutoXrtNBrUrCux1LdCupKYyCvfj cFVyqSA== X-Received: from pfwy27.prod.google.com ([2002:a05:6a00:1c9b:b0:842:8af7:db0d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:9a6:b0:845:ccf1:49b6 with SMTP id d2e1a72fcca58-847c51b72d4mr2049167b3a.45.1782934360386; Wed, 01 Jul 2026 12:32:40 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:33 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-13-seanjc@google.com> Subject: [PATCH v5 12/51] x86/acrn: Register TSC/CPU frequency callbacks iff frequency is actually in CPUID From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d25034/1782934362-A84A9D51-78A097DD/0/0 X-purgate-type: clean X-purgate-size: 1816 Register ACRN's TSC/CPU frequency overrides if and only if the exact TSC frequency is actually provided in CPUID. This will allow marking the TSC as reliable as appropriate, and avoids relying on the caller to handle "failure". For all intents and purposes, no functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/acrn.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index ad8f2da8003b..dc71a6fdd461 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -19,6 +19,8 @@ #include #include +static unsigned int acrn_tsc_khz_cpuid __initdata; + static u32 __init acrn_detect(void) { return acrn_cpuid_base(); @@ -26,13 +28,19 @@ static u32 __init acrn_detect(void) static unsigned int __init acrn_get_tsc_khz(void) { - return cpuid_eax(ACRN_CPUID_TIMING_INFO); + return acrn_tsc_khz_cpuid; } static void __init acrn_init_platform(void) { /* Install system interrupt handler for ACRN hypervisor callback */ sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); + + acrn_tsc_khz_cpuid = cpuid_eax(ACRN_CPUID_TIMING_INFO); + if (acrn_tsc_khz_cpuid) { + x86_init.hyper.get_tsc_khz = acrn_get_tsc_khz; + x86_init.hyper.get_cpu_khz = acrn_get_tsc_khz; + } } static bool acrn_x2apic_available(void) @@ -80,6 +88,4 @@ const __initconst struct hypervisor_x86 x86_hyper_acrn = { .type = X86_HYPER_ACRN, .init.init_platform = acrn_init_platform, .init.x2apic_available = acrn_x2apic_available, - .init.get_tsc_khz = acrn_get_tsc_khz, - .init.get_cpu_khz = acrn_get_tsc_khz, }; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350383.1607919 (Exim 4.92) (envelope-from ) id 1wf0fv-0002NJ-Ax; Wed, 01 Jul 2026 19:32:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350383.1607919; Wed, 01 Jul 2026 19:32:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fu-0002LA-Uc; Wed, 01 Jul 2026 19:32:46 +0000 Received: by outflank-mailman (input) for mailman id 1350383; Wed, 01 Jul 2026 19:32:45 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3WmtFagYKCZ8RD9MIBFNNFKD.BNLWDM-CDUDKKHRSR.WDMOQNIDBS.NQF@flex--seanjc.bounces.google.com>) id 1wf0ft-0001tg-2q for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fs-004o0g-FF for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:44 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3WmtFagYKCZ8RD9MIBFNNFKD.BNLWDM-CDUDKKHRSR.WDMOQNIDBS.NQF@flex--seanjc.bounces.google.com>) id 6a456b58-2eae-0a2a0a5409dd-0a2a450882ba-4 for ; Wed, 01 Jul 2026 21:32:44 +0200 Received: from [209.85.210.202] (helo=mail-pf1-f202.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3WmtFagYKCZ8RD9MIBFNNFKD.BNLWDM-CDUDKKHRSR.WDMOQNIDBS.NQF@flex--seanjc.bounces.google.com>) id 6a456b5a-edec-0a2a45080019-d155d2caad9e-3 for ; Wed, 01 Jul 2026 21:32:44 +0200 Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-847a2509456so1135787b3a.1 for ; Wed, 01 Jul 2026 12:32:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934362; x=1783539162; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=FaUjTU3QKJy+ktbmudl/+1GzmAqwQnS7of3spvtM7gQ=; b=OauO9YQj8/DIduPXV9LtGQlmHJnxfKxLMXTbb/WZ+PMTU+rJkiMniiSHaCWYrb91SZ GOqSfHDBqVviFJ86XJxg/n3bYKhiR9NO3qT3qyrbBypQPCZAxdflrI0xW4olETsjVicp DbfPBIbmDz457EmmWwSHHD6hJoYX8BX0dgwY2J/PpWfiEN+Vp8WeJOL0zxgvdRUPpeRL SVetb3GFTFP2UQR0tHaJUE29AvEnq/J+kJnbMnanmddgbnrdzcHiD8TDxgCfoF3kGxBT Flb0xgFvOLE6OGnb8/8xp57AG+AfGMKKwPuL5A38Ylx1gE28yRj3u2jshwVq2OmQqSGL iUEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934362; x=1783539162; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FaUjTU3QKJy+ktbmudl/+1GzmAqwQnS7of3spvtM7gQ=; b=c+Z5x/52goRc5BE6Ua8dI24LduCwtN/R07BVOv0lL0xXQL8m/7ipSDDDI6yn1AnG5D RWFb9JSQxwxqvzJEYlyuoN/sGmLE/5321McCpB51MrN7azJ4NFvPrtKYRmsx6qAr3qyW eorqeq+bDXUnmtjBjq7Exa9A4GqB3rNF/7RNNbE9tSfaCrwdprI7cvJyccB1A471H/zV LsIabfyfPf4qkDU+oq+tbSU78BohsoksLtY4hiRonN64vJ6rd4hBQkIl5bUnY1anOA7e ri5WOjyuxK0/k62g/phLSJKZitwvvQrFM/VfzBmTgcae1QA7gBSuQHWWlJLhd75suOcr P1Zg== X-Forwarded-Encrypted: i=1; AFNElJ+viXaHJtNx77uDc7JxnQRT+5IfKkwW2hemedZomEQkQqU663KuEBPmpQWmJc4IYF2VwAfud5/hZ/o=@lists.xenproject.org X-Gm-Message-State: AOJu0YwjlbG21uC59fl37RTvgkMH9iF67yq4cjNWS+jNKB0xsLhnJqzh cJh/Z7+hXTzLCSyWHCJYrNz/reySadf6PUxZJGNoDz6r3seSo6FqUW4yKtrBwrmq4vd2GUr2vTR lR/lUVg== X-Received: from pghx17.prod.google.com ([2002:a63:f711:0:b0:c9a:53ea:434a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:1b84:b0:398:9b42:69f7 with SMTP id adf61e73a8af0-3bfed3b19b0mr3536321637.39.1782934362055; Wed, 01 Jul 2026 12:32:42 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:34 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-14-seanjc@google.com> Subject: [PATCH v5 13/51] x86/acrn: Mark TSC frequency as known when using ACRN for calibration From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c1860d/1782934364-A0D2B3FC-5AFC5710/0/0 X-purgate-type: clean X-purgate-size: 816 Mark the TSC frequency as known when using ACRN's PV CPUID information. Per commit 81a71f51b89e ("x86/acrn: Set up timekeeping") and common sense, the TSC freq is explicitly provided by the hypervisor. Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/acrn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index dc71a6fdd461..3818f6ae0629 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -40,6 +40,7 @@ static void __init acrn_init_platform(void) if (acrn_tsc_khz_cpuid) { x86_init.hyper.get_tsc_khz = acrn_get_tsc_khz; x86_init.hyper.get_cpu_khz = acrn_get_tsc_khz; + setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } } -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350384.1607924 (Exim 4.92) (envelope-from ) id 1wf0fw-0002Uz-By; Wed, 01 Jul 2026 19:32:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350384.1607924; Wed, 01 Jul 2026 19:32:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fv-0002Sq-Mn; Wed, 01 Jul 2026 19:32:47 +0000 Received: by outflank-mailman (input) for mailman id 1350384; Wed, 01 Jul 2026 19:32:46 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3W2tFagYKCaASEANJCGOOGLE.COMXEN-DEVELLISTS.XENPROJECT.ORG@flex--seanjc.bounces.google.com>) id 1wf0fu-00027L-9J for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0ft-00Bw10-M1 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:45 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3W2tFagYKCaASEANJCGOOGLE.COMXEN-DEVELLISTS.XENPROJECT.ORG@flex--seanjc.bounces.google.com>) id 6a456b5c-bab6-0a2a0a5309dd-0a2a4504ab4a-2 for ; Wed, 01 Jul 2026 21:32:45 +0200 Received: from [209.85.215.202] (helo=mail-pg1-f202.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3W2tFagYKCaASEANJCGOOGLE.COMXEN-DEVELLISTS.XENPROJECT.ORG@flex--seanjc.bounces.google.com>) id 6a456b5c-a01d-0a2a45040019-d155d7caccd0-3 for ; Wed, 01 Jul 2026 21:32:45 +0200 Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c85798977dcso829847a12.0 for ; Wed, 01 Jul 2026 12:32:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934363; x=1783539163; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=JEJEfFzkyRhChopEv3/Eo+3SUmzyKJlolrUUxvPFGQs=; b=PAgkNZum8jPxRZz9+ydbw+bfUj3MHsLFJsyQaqR1J0b+EjqdM80kH2xDwCx3uAvkhW +uGmCuVpSrvmvLd+Qnr2p41NXAfeU8zuWoKSmC4+569uo7sE1/ulR1RiXglbBtI4AFRu woISm3v4ZHLsIUiCTdjAY7ZyBeDnyK+XNpe0ixP/uai40awtttk+8vvd/yZxeed1Hckt cPaumKYB6fOiUj8vWFqfSiFUslOxtyV1orulkJcxFzANEuUjfoSJKKgCVjkjC2lkUdMs Ci32VSkmh5deWRIGFgA1gYCSLUHwmQXc4wJGNHGTYlFANYiLoOHTNFzFyHFX53bwW2wU r5iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934363; x=1783539163; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JEJEfFzkyRhChopEv3/Eo+3SUmzyKJlolrUUxvPFGQs=; b=lVAomjB5FkP0QcXTTdn3NXHXRtDLRmUAzdMQaOy1zsHpwIOosi+1sBPbmzli2qZM6w 181Av7X0c0WaONtUwv/05TH/NgkP1pqgLQ7tvo9PHR73AlrMrMoGv1qq6rIiCsr8RGxC 8OiD0VMJSEAqfDjrSTfDdHAfbLBh54Dha2rt9LTG/eDdXMUz/id8UPbpzOjUITa/O5u5 02zOahZy/3HL2whTY+euCNIp7jR2vVqcn9Rc+L35nUcEhcHo3SYItcC08BuAVWyO29uK PvW/eeVcz5FpY6Oz84KoCMm/Yg74qHWSZ3QHyIJSki2FoxVdxC+96h9Oqg3M4xFf2Tx0 1gvA== X-Forwarded-Encrypted: i=1; AFNElJ82qQUj5LXqbK0G65tIjNSRqr69qKA6I/N82+fMQqo7cSFBmyTO+/aQIsBJ5el/9wUWlbzPzwTE2Rw=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzd60iw5S7N9f6tETp+RxLJVak2vsKee/mM8VB5YBy9k9RBkC8D SGAhkapTHCtAPRGfnkJjCWbqVxnToRaCWZpcsQ1e0Qjm4a4ZzJPh0nOWbcOh4bOR/DPoh436HEL dIpQeSA== X-Received: from pgbda6.prod.google.com ([2002:a05:6a02:2386:b0:c99:7baf:125f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7288:b0:3bf:b1f4:747b with SMTP id adf61e73a8af0-3bfed0e2904mr3197752637.12.1782934363113; Wed, 01 Jul 2026 12:32:43 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:35 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-15-seanjc@google.com> Subject: [PATCH v5 14/51] x86/tsc: Consolidate forcing of X86_FEATURE_TSC_KNOWN_FREQ for PV code From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934365-AFD241CC-914DEE1A/0/0 X-purgate-type: clean X-purgate-size: 5872 Now that all paravirt code that explicitly specifies the TSC frequency also sets X86_FEATURE_TSC_KNOWN_FREQ, replace all of the one-off code and simply set X86_FEATURE_TSC_KNOWN_FREQ if the TSC frequency is known. Do NOT force set TSC_KNOWN_FREQ if the "known" TSC frequency was provided by the user. Per commit bd35c77e32e4 ("x86/tsc: Add tsc_early_khz command line parameter"), one of the goals of the param is to allow the refined calibration work "to do meaningful error checking". No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 1 - arch/x86/coco/tdx/tdx.c | 1 - arch/x86/kernel/cpu/acrn.c | 1 - arch/x86/kernel/cpu/mshyperv.c | 1 - arch/x86/kernel/cpu/vmware.c | 2 -- arch/x86/kernel/jailhouse.c | 1 - arch/x86/kernel/kvmclock.c | 1 - arch/x86/kernel/tsc.c | 13 ++++++++++--- arch/x86/xen/time.c | 1 - 9 files changed, 10 insertions(+), 12 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index bc5ae9ef74da..72313b36b6f5 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2027,7 +2027,6 @@ unsigned int __init snp_secure_tsc_init(void) secrets = (__force struct snp_secrets_page *)mem; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); rdmsrq(MSR_AMD64_GUEST_TSC_FREQ, tsc_freq_mhz); diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c index ae2d35f2ef33..94682aca188b 100644 --- a/arch/x86/coco/tdx/tdx.c +++ b/arch/x86/coco/tdx/tdx.c @@ -1205,7 +1205,6 @@ unsigned int __init tdx_tsc_init(void) /* TSC is the only reliable clock in TDX guest */ setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return info.crystal_khz * info.numerator / info.denominator; } diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index 3818f6ae0629..dc71a6fdd461 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -40,7 +40,6 @@ static void __init acrn_init_platform(void) if (acrn_tsc_khz_cpuid) { x86_init.hyper.get_tsc_khz = acrn_get_tsc_khz; x86_init.hyper.get_cpu_khz = acrn_get_tsc_khz; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } } diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index f9bc1c2d8c93..e03c69a4db33 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -575,7 +575,6 @@ static void __init ms_hyperv_init_platform(void) ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) { x86_init.hyper.get_tsc_khz = hv_get_tsc_khz; x86_init.hyper.get_cpu_khz = hv_get_tsc_khz; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } if (ms_hyperv.priv_high & HV_ISOLATION) { diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 3cb473cae462..0a3bd90576d4 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -390,8 +390,6 @@ static void __init vmware_set_capabilities(void) { setup_force_cpu_cap(X86_FEATURE_CONSTANT_TSC); setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); - if (vmware_tsc_khz) - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); if (vmware_hypercall_mode == CPUID_VMWARE_FEATURES_ECX_VMCALL) setup_force_cpu_cap(X86_FEATURE_VMCALL); else if (vmware_hypercall_mode == CPUID_VMWARE_FEATURES_ECX_VMMCALL) diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c index e24c05ab4fae..ff173052cdce 100644 --- a/arch/x86/kernel/jailhouse.c +++ b/arch/x86/kernel/jailhouse.c @@ -255,7 +255,6 @@ static void __init jailhouse_init_platform(void) pr_debug("Jailhouse: PM-Timer IO Port: %#x\n", pmtmr_ioport); precalibrated_tsc_khz = setup_data.v1.tsc_khz; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); pci_probe = 0; diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 4f8299303a19..35a879d33e9e 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -138,7 +138,6 @@ static inline void kvm_sched_clock_init(bool stable) */ static unsigned int __init kvm_get_tsc_khz(void) { - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return pvclock_tsc_khz(this_cpu_pvti()); } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 1dca9464b41c..676910292af7 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1541,11 +1541,18 @@ void __init tsc_early_init(void) if (!known_tsc_khz && x86_init.hyper.get_tsc_khz) known_tsc_khz = x86_init.hyper.get_tsc_khz(); + /* + * Mark the TSC frequency as known if it was obtained from a hypervisor + * or trusted firmware. + */ + if (known_tsc_khz) + setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); + /* * Ignore the user-provided TSC frequency if the exact frequency was - * obtained from trusted firmware or the hypervisor, as the user- - * provided frequency is intended as a "starting point", not a known, - * guaranteed frequency. + * obtained from trusted firmware or the hypervisor, and don't mark the + * frequency as known, as the user-provided frequency is intended as a + * "starting point", not a known, guaranteed frequency */ if (!known_tsc_khz) known_tsc_khz = tsc_early_khz; diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 1adb44fdddb2..487ad838c441 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -43,7 +43,6 @@ static unsigned int __init xen_tsc_khz(void) struct pvclock_vcpu_time_info *info = &HYPERVISOR_shared_info->vcpu_info[0].time; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return pvclock_tsc_khz(info); } -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350389.1607938 (Exim 4.92) (envelope-from ) id 1wf0fz-0003Cg-C8; Wed, 01 Jul 2026 19:32:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350389.1607938; Wed, 01 Jul 2026 19:32:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fy-00039B-QU; Wed, 01 Jul 2026 19:32:50 +0000 Received: by outflank-mailman (input) for mailman id 1350389; Wed, 01 Jul 2026 19:32:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3XGtFagYKCaETFBOKDHPPHMF.DPNYFO-EFWFMMJTUT.YFOQSPKFDU.PSH@flex--seanjc.bounces.google.com>) id 1wf0fv-0002Qu-J6 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fu-004o0g-VO for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:46 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3XGtFagYKCaETFBOKDHPPHMF.DPNYFO-EFWFMMJTUT.YFOQSPKFDU.PSH@flex--seanjc.bounces.google.com>) id 6a456b1f-2eae-0a2a0a5409dd-0a2a4502c3a4-28 for ; Wed, 01 Jul 2026 21:32:46 +0200 Received: from [209.85.210.201] (helo=mail-pf1-f201.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3XGtFagYKCaETFBOKDHPPHMF.DPNYFO-EFWFMMJTUT.YFOQSPKFDU.PSH@flex--seanjc.bounces.google.com>) id 6a456b5d-5a27-0a2a45020019-d155d2c9ac9c-3 for ; Wed, 01 Jul 2026 21:32:46 +0200 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-847a5f03ff9so1061148b3a.0 for ; Wed, 01 Jul 2026 12:32:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934365; x=1783539165; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=zvn0qgJXD+EEALhwTLcptmf75deD5j2rYJRr5T7GtTU=; b=NEPU0FvZM0tBUagTvaTXCYGo/6JaJV8OZTChxt4X67j30gOQkx+9mKzlsneZAbn9RR 1Jb4uh1+pZxuVzQw15L63HvjbLfMBkyxDFFWC21uy0W2R3MLX+YZ3cYSDBZwO6/GbkxU 2QES/GjxBOoUak/kEuLDYA8+cDKVGwsSmKOGm7iKNfc4KqlAxfxV/SR/pNqnw3x+8U96 r5nFizTbaDuUhA1Z4dH91SQRvMzd6aPAhyvQEzzG2BXbODs8l3b9kWPu9kjHzSVrXS4+ nuvbRMLQbAweoT80UHkkt6yJpp+e7T69BW+I9CgrVm8dpjpsd0ZkLghP5MQf1lmzcVu/ NESg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934365; x=1783539165; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zvn0qgJXD+EEALhwTLcptmf75deD5j2rYJRr5T7GtTU=; b=LZrOq8aec6gqVQBF5NQgElS0siD5reaVV9P2hrMqNq22/sVver1Y4486xXNJBsrLTr tBnvD8w/hcwwnUmLDCETs9PExoApv9Lbsz3EG8lkWX3yaD0MAHrkup5P3E0ChpAvaoiT Gz4yd7WGvPQSMNS3a4DFP2UlS9b99zzWp6XCu8cc2aO1Istt/KedN5v0G7+Wio9XCWMn N0YMvQwXuL+tUl5hf+wunL/TcoViW5tZtR7KQlZuKRwfJ5HbsNrBiRqgXdlav4Mx0SmK dz36uibB8pCnS+oW0gUxTARfpyghI0ksoUSB9Aopi7x/23ANMM+bqBc/67FPcbiYB+a3 Exfg== X-Forwarded-Encrypted: i=1; AHgh+RqywFmNwPL74Zw7lGYLOtpj7jVCaNzCboPO1qV5VEi5osDdMJtLNCwnaSqJ+ppJcf+YGhQG7OW8L84=@lists.xenproject.org X-Gm-Message-State: AOJu0YzqAa6FsrkQprcY48Px19ka+Picg1k4R0fuPNyq97H+BWVH1u/U Na9GK3cplCnK6zFCvo0ycWwKS2T0T7aeUsjUdth3e2Q0ovvXBGGRJl1oPOymYXOXPa6Yr3feaeR 4WoVALQ== X-Received: from pgkz20.prod.google.com ([2002:a63:a54:0:b0:c9a:8872:2a15]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:181b:b0:847:9226:e7be with SMTP id d2e1a72fcca58-847c03a60f4mr2814234b3a.0.1782934364356; Wed, 01 Jul 2026 12:32:44 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:36 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-16-seanjc@google.com> Subject: [PATCH v5 15/51] x86/tsc: Kill off x86_platform_ops.calibrate_{cpu,tsc}() hooks From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-720697/1782934366-554E17C5-8AE5A455/0/0 X-purgate-type: clean X-purgate-size: 5643 Now that getting the CPU and/or TSC frequencies from the hypervisor uses dedicated hooks, drop x86_platform_ops.calibrate_{cpu,tsc}() and instead directly invoke the correct helper at each phase of (re)calibration. In addition to eliminating unnecessary code, this makes it a bit more obvious when the "late" path invokes pit_hpet_ptimer_calibrate_cpu() instead of x86_platform_ops.calibrate_cpu(). No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/include/asm/tsc.h | 2 -- arch/x86/include/asm/x86_init.h | 4 ---- arch/x86/kernel/tsc.c | 28 ++++++++++++---------------- arch/x86/kernel/x86_init.c | 2 -- 4 files changed, 12 insertions(+), 24 deletions(-) diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h index b6b86e24e1bf..c09ec485abcd 100644 --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -95,8 +95,6 @@ extern void mark_tsc_unstable(char *reason); extern int unsynchronized_tsc(void); extern int check_tsc_unstable(void); extern void mark_tsc_async_resets(char *reason); -extern unsigned long native_calibrate_cpu_early(void); -extern unsigned long native_calibrate_tsc(void); extern unsigned long long native_sched_clock_from_tsc(u64 tsc); extern int tsc_clocksource_reliable; diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 0c89bf40f507..e879e6e83428 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -295,8 +295,6 @@ struct x86_hyper_runtime { /** * struct x86_platform_ops - platform specific runtime functions - * @calibrate_cpu: calibrate CPU - * @calibrate_tsc: calibrate TSC, if different from CPU * @get_wallclock: get time from HW clock like RTC etc. * @set_wallclock: set time back to HW clock * @iommu_shutdown: set by an IOMMU driver for shutdown if necessary @@ -320,8 +318,6 @@ struct x86_hyper_runtime { * @guest: guest incarnations callbacks */ struct x86_platform_ops { - unsigned long (*calibrate_cpu)(void); - unsigned long (*calibrate_tsc)(void); void (*get_wallclock)(struct timespec64 *ts); int (*set_wallclock)(const struct timespec64 *ts); void (*iommu_shutdown)(void); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 676910292af7..a877b82d0991 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -672,7 +672,7 @@ int cpuid_get_tsc_info(struct cpuid_tsc_info *info) * native_calibrate_tsc - determine TSC frequency * Determine TSC frequency via CPUID, else return 0. */ -unsigned long native_calibrate_tsc(void) +static unsigned long native_calibrate_tsc(void) { struct cpuid_tsc_info info; @@ -904,7 +904,7 @@ static unsigned long pit_hpet_ptimer_calibrate_cpu(void) /** * native_calibrate_cpu_early - can calibrate the cpu early in boot */ -unsigned long native_calibrate_cpu_early(void) +static unsigned long native_calibrate_cpu_early(void) { unsigned long flags, fast_calibrate = cpu_khz_from_cpuid(); @@ -918,7 +918,7 @@ unsigned long native_calibrate_cpu_early(void) return fast_calibrate; } - +#ifndef CONFIG_SMP /** * native_calibrate_cpu - calibrate the cpu */ @@ -931,6 +931,7 @@ static unsigned long native_calibrate_cpu(void) return tsc_freq; } +#endif void recalibrate_cpu_khz(void) { @@ -943,8 +944,8 @@ void recalibrate_cpu_khz(void) if (WARN_ON_ONCE(cpu_feature_enabled(X86_FEATURE_TSC_KNOWN_FREQ))) return; - cpu_khz = x86_platform.calibrate_cpu(); - tsc_khz = x86_platform.calibrate_tsc(); + cpu_khz = native_calibrate_cpu(); + tsc_khz = native_calibrate_tsc(); if (tsc_khz == 0) tsc_khz = cpu_khz; else if (abs(cpu_khz - tsc_khz) * 10 > tsc_khz) @@ -1458,17 +1459,19 @@ static bool __init determine_cpu_tsc_frequencies(bool early, WARN_ON(cpu_khz || tsc_khz); if (early) { + /* + * Early CPU calibration can only use methods that are available + * early in boot (obviously). + */ if (known_cpu_khz) cpu_khz = known_cpu_khz; else - cpu_khz = x86_platform.calibrate_cpu(); + cpu_khz = native_calibrate_cpu_early(); if (known_tsc_khz) tsc_khz = known_tsc_khz; else - tsc_khz = x86_platform.calibrate_tsc(); + tsc_khz = native_calibrate_tsc(); } else { - /* We should not be here with non-native cpu calibration */ - WARN_ON(x86_platform.calibrate_cpu != native_calibrate_cpu); cpu_khz = pit_hpet_ptimer_calibrate_cpu(); } @@ -1571,13 +1574,6 @@ void __init tsc_init(void) return; } - /* - * native_calibrate_cpu_early can only calibrate using methods that are - * available early in boot. - */ - if (x86_platform.calibrate_cpu == native_calibrate_cpu_early) - x86_platform.calibrate_cpu = native_calibrate_cpu; - if (!tsc_khz) { /* We failed to determine frequencies earlier, try again */ if (!determine_cpu_tsc_frequencies(false, 0, 0)) { diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index 252c5827d063..b7a48e622f48 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -147,8 +147,6 @@ static void enc_kexec_finish_noop(void) {} static bool is_private_mmio_noop(u64 addr) {return false; } struct x86_platform_ops x86_platform __ro_after_init = { - .calibrate_cpu = native_calibrate_cpu_early, - .calibrate_tsc = native_calibrate_tsc, .get_wallclock = mach_get_cmos_time, .set_wallclock = mach_set_cmos_time, .iommu_shutdown = iommu_shutdown_noop, -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350390.1607945 (Exim 4.92) (envelope-from ) id 1wf0g0-0003LP-MI; Wed, 01 Jul 2026 19:32:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350390.1607945; Wed, 01 Jul 2026 19:32:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0fz-0003HJ-F9; Wed, 01 Jul 2026 19:32:51 +0000 Received: by outflank-mailman (input) for mailman id 1350390; Wed, 01 Jul 2026 19:32:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3XWtFagYKCaIUGCPLEIQQING.EQOZGP-FGXGNNKUVU.ZGPRTQLGEV.QTI@flex--seanjc.bounces.google.com>) id 1wf0fw-0002Zq-Md for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fw-00Bw10-25 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:48 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3XWtFagYKCaIUGCPLEIQQING.EQOZGP-FGXGNNKUVU.ZGPRTQLGEV.QTI@flex--seanjc.bounces.google.com>) id 6a456b5c-bab6-0a2a0a5309dd-0a2a4504ab4a-6 for ; Wed, 01 Jul 2026 21:32:48 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3XWtFagYKCaIUGCPLEIQQING.EQOZGP-FGXGNNKUVU.ZGPRTQLGEV.QTI@flex--seanjc.bounces.google.com>) id 6a456b5e-a01d-0a2a45040019-d155d6cab5e3-3 for ; Wed, 01 Jul 2026 21:32:47 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2ca3b314193so12001835ad.1 for ; Wed, 01 Jul 2026 12:32:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934366; x=1783539166; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=3QmXXgqE7aLG5WH8n+yjrFm5ZX7gR61uwM9vT7lFOWU=; b=cIHGeXnNB/BmmH+GNcmRmrxqSuhPUsj4rCQu9OHYo8nq+taHAPy1A0NnRBiyLbAeLQ e8iNT/9c56Pow9zrTf45hz5c6BGBmoXg0r/6mw0PxdMSnkeP8y5hALC5mYxn7RoGvcCm HqeAg0D6sp0LEzpPOQJmIemL03OzzT8AI1UvGT9Mor66o9GA7Sr05XDEsI8ad5ZEZrYh crTA0MFmx7dQ269CIHMrJFJpgpZtUcZg7iGUIgXR7y9rGqz96JtlAJscmucRx3ma9hcA mgQpuO2aLqyFOhLbWcMRHUtE8fXdsKJS6NbHkR66LSenDnYLZcPA41yzxcqsN5nklsJn lmEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934366; x=1783539166; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3QmXXgqE7aLG5WH8n+yjrFm5ZX7gR61uwM9vT7lFOWU=; b=NMQBfi8lamVDkhs2TvQIzGfwVKIuLOvGwIUpvA5QmJjPNOjCehcN2mO1HhUKA6KEOP N9ZQn7eiLRiIeJMLjrnQ9ouEtLol2UG2dmXZYlyrDTJFXd1bOEXUN6U/KP88itBx+G9A MYIVIq2IujgXtrd8vS2fV0KiQXE9Z6n8FtarA+CWt2xj5SDnux3xgDB90avekxMwEYLU EWgZxC/EfAizAJWRjacN5zH50EMiqACrwLAzk1ryj9OdG7UMGgbwL20MhJ7ughkGiXqe FmqU6InIrqE9dZfVZ3CV2lyRGjrUXHuNnOrly9+mCB17bYNTLrHKMqoiy+IIoS5HYnKJ ymHQ== X-Forwarded-Encrypted: i=1; AHgh+Ro1UIMDcp0ekQsnvBAx3GR/985S21Zdqagjeb0vAwLGgvhK56jxSEaPPpigzw8YiRpi5d2RMjt69Yg=@lists.xenproject.org X-Gm-Message-State: AOJu0YwQX2zbiNAQArbsfq2I2DsxiIuX44AgnmBWU5CueGw2cVDnAayN QtG9QesKZPCEvbQpblRkpHq1MaaoTnovODoB9dEG3+H9sJwoLt00DSUo6y7akV4WZ3APCVuMfO/ Cq9bV1w== X-Received: from plef18.prod.google.com ([2002:a17:902:f392:b0:2c7:eb53:9c06]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:944:b0:2ca:68b1:b64c with SMTP id d9443c01a7336-2ca7e75d694mr30967275ad.20.1782934365572; Wed, 01 Jul 2026 12:32:45 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:37 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-17-seanjc@google.com> Subject: [PATCH v5 16/51] x86/tsc: Rename pit_hpet_ptimer_calibrate_cpu() => native_calibrate_cpu_late() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934368-2C9AB1CC-B8F08058/0/0 X-purgate-type: clean X-purgate-size: 1434 Rename the late CPU calibration routine so that its relationship to the early routine is more obvious and intuitive. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index a877b82d0991..9764ac758081 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -752,7 +752,7 @@ static unsigned long cpu_khz_from_cpuid(void) * calibrate cpu using pit, hpet, and ptimer methods. They are available * later in boot after acpi is initialized. */ -static unsigned long pit_hpet_ptimer_calibrate_cpu(void) +static unsigned long native_calibrate_cpu_late(void) { u64 tsc1, tsc2, delta, ref1, ref2; unsigned long tsc_pit_min = ULONG_MAX, tsc_ref_min = ULONG_MAX; @@ -927,7 +927,7 @@ static unsigned long native_calibrate_cpu(void) unsigned long tsc_freq = native_calibrate_cpu_early(); if (!tsc_freq) - tsc_freq = pit_hpet_ptimer_calibrate_cpu(); + tsc_freq = native_calibrate_cpu_late(); return tsc_freq; } @@ -1472,7 +1472,7 @@ static bool __init determine_cpu_tsc_frequencies(bool early, else tsc_khz = native_calibrate_tsc(); } else { - cpu_khz = pit_hpet_ptimer_calibrate_cpu(); + cpu_khz = native_calibrate_cpu_late(); } /* -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350392.1607950 (Exim 4.92) (envelope-from ) id 1wf0g1-0003aJ-Pa; Wed, 01 Jul 2026 19:32:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350392.1607950; Wed, 01 Jul 2026 19:32:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0g1-0003XI-64; Wed, 01 Jul 2026 19:32:53 +0000 Received: by outflank-mailman (input) for mailman id 1350392; Wed, 01 Jul 2026 19:32:50 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3XmtFagYKCaMVHDQMFJRRJOH.FRPaHQ-GHYHOOLVWV.aHQSURMHFW.RUJ@flex--seanjc.bounces.google.com>) id 1wf0fy-0002yo-3Q for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0fx-00B3ua-G0 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:49 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3XmtFagYKCaMVHDQMFJRRJOH.FRPaHQ-GHYHOOLVWV.aHQSURMHFW.RUJ@flex--seanjc.bounces.google.com>) id 6a456b3e-5cb7-0a2a0a5109dd-0a2a4506aae4-46 for ; Wed, 01 Jul 2026 21:32:49 +0200 Received: from [209.85.216.73] (helo=mail-pj1-f73.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3XmtFagYKCaMVHDQMFJRRJOH.FRPaHQ-GHYHOOLVWV.aHQSURMHFW.RUJ@flex--seanjc.bounces.google.com>) id 6a456b5f-08de-0a2a45060019-d155d849d0a8-3 for ; Wed, 01 Jul 2026 21:32:49 +0200 Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-37fa907f98eso892862a91.2 for ; Wed, 01 Jul 2026 12:32:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934367; x=1783539167; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=wWnD58giubyrEvhTS3JtzvsAOScPFFHLvCt5ZIn12HI=; b=dqIfi1MVbD/oEqcqlx8SVvWcnzIDmsXWRrDyG9v8mwxKwRM92ZiVNdFjukCehYsQ/a s62fxqlt/VGzYgYl/4xuxwlz5H70MkpV0mJt85yc+pQw7wz2nAHar9nQf5+/wGD64J63 rkDb5M+Ov06UYiyEZAn66QkQ6tu2UL6m4FX1XmjhAWSDPc0CUtFXpwo58G3MYNimCzWX 4UxKrwDhRrpDB205bOt9Md1j/8RWQ3afhlAOfl4ftxu2swE/Ndq/0ei8ewjGZBUs5Bud 4G8d7QLW3OpjXFlnrOgz4l95TzTSM0nu6RN9lWHPdOD32rJ+0Hzry6a44YuqojilP1er z7NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934367; x=1783539167; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wWnD58giubyrEvhTS3JtzvsAOScPFFHLvCt5ZIn12HI=; b=XbfBoKTpQI2LMxKivbOdQFl2+oFlpfMKTIzHWjPEOUfwSNbVzTPNpV7v6S1vaPZLns aD0gGnaPaPTuxhgNtI5v0PunteU5aosetbKkoHfEbonMEX7pRBxjWDtx2VlRg4iWjFVc fb7e3ATCeFkYVD4O6w5FIteBuRhDGp555nMV3mTTGtlFfuvpp2Z6BzFfmGcG4DfBl2jL apmH8o2zmpefB8pCglHbAxistZ1rIUyGlV4xH06JKxQazjDYujsnhydRc967va0YT15C Xvu9XE0G4aKnbmfDhCf0nUAYcBQPjjGQIem3SCLgoLXAKsxB2v8QkO/ZWP4QcuvDEst6 mTVg== X-Forwarded-Encrypted: i=1; AHgh+Roq8xjtFhE4fEIxUERyrhmA4TbeLlyiIfEAzME6jwqwnt9qm8XMSkoIgRYG0yg4NnFT3p0wcPnTjAU=@lists.xenproject.org X-Gm-Message-State: AOJu0YyNm/9ZgZxOJ+Q3JmVTBcBtnWKuJxKZeTFtlLMSQKWPSkmbnWP8 ReMY+YJ+QLchbptXocVAm5F/3+TjA8RuBTKnjFSCJmkG1YVsT6wy/sKcjwWfbfVU8YuR7Adc7XK 6NajT4A== X-Received: from pjbms18.prod.google.com ([2002:a17:90b:2352:b0:380:9651:afb9]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:e7ce:b0:37d:8426:40de with SMTP id 98e67ed59e1d1-380aa0ad396mr2721883a91.1.1782934366877; Wed, 01 Jul 2026 12:32:46 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:38 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-18-seanjc@google.com> Subject: [PATCH v5 17/51] x86/tsc: Fold native_calibrate_cpu() into recalibrate_cpu_khz() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934369-43F2C68D-85239273/0/0 X-purgate-type: clean X-purgate-size: 1497 Fold the guts of native_calibrate_cpu() into its sole remaining caller, recalibrate_cpu_khz() to eliminate the extra SMP=n #ifdef, and so that it's more obvious that directly invoking the early vs. late calibration routines in determine_cpu_tsc_frequencies() is intentional. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 9764ac758081..6ed6f8f012eb 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -918,21 +918,6 @@ static unsigned long native_calibrate_cpu_early(void) return fast_calibrate; } -#ifndef CONFIG_SMP -/** - * native_calibrate_cpu - calibrate the cpu - */ -static unsigned long native_calibrate_cpu(void) -{ - unsigned long tsc_freq = native_calibrate_cpu_early(); - - if (!tsc_freq) - tsc_freq = native_calibrate_cpu_late(); - - return tsc_freq; -} -#endif - void recalibrate_cpu_khz(void) { #ifndef CONFIG_SMP @@ -944,7 +929,9 @@ void recalibrate_cpu_khz(void) if (WARN_ON_ONCE(cpu_feature_enabled(X86_FEATURE_TSC_KNOWN_FREQ))) return; - cpu_khz = native_calibrate_cpu(); + cpu_khz = native_calibrate_cpu_early(); + if (!cpu_khz) + cpu_khz = native_calibrate_cpu_late(); tsc_khz = native_calibrate_tsc(); if (tsc_khz == 0) tsc_khz = cpu_khz; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:32:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:32:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350406.1607969 (Exim 4.92) (envelope-from ) id 1wf0g6-0004hT-K6; Wed, 01 Jul 2026 19:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350406.1607969; Wed, 01 Jul 2026 19:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0g6-0004gB-0Y; Wed, 01 Jul 2026 19:32:58 +0000 Received: by outflank-mailman (input) for mailman id 1350406; Wed, 01 Jul 2026 19:32:55 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3Y2tFagYKCagaMIVRKOWWOTM.KWUfMV-LMdMTTQaba.fMVXZWRMKb.WZO@flex--seanjc.bounces.google.com>) id 1wf0g2-0003uo-QV for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0g2-00B3ua-6c for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:54 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3Y2tFagYKCagaMIVRKOWWOTM.KWUfMV-LMdMTTQaba.fMVXZWRMKb.WZO@flex--seanjc.bounces.google.com>) id 6a456b66-5cb7-0a2a0a5109dd-0a2a4506dc64-2 for ; Wed, 01 Jul 2026 21:32:54 +0200 Received: from [209.85.215.202] (helo=mail-pg1-f202.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3Y2tFagYKCagaMIVRKOWWOTM.KWUfMV-LMdMTTQaba.fMVXZWRMKb.WZO@flex--seanjc.bounces.google.com>) id 6a456b64-08de-0a2a45060019-d155d7cad033-3 for ; Wed, 01 Jul 2026 21:32:53 +0200 Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c88fc985a65so945578a12.2 for ; Wed, 01 Jul 2026 12:32:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934372; x=1783539172; darn=lists.xenproject.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:from:to:cc:subject:date :message-id:reply-to; bh=YK4DO2yTgoTSHNgYS/yt/30ZUc46SVmXG9Yy1qokrf0=; b=XvpnYDD3F5OG8PmvFhBtXpjFUyiMZV46FNST5IAxcM3USRxeSg4JZVgimVFBlo8g3v +08TkZQ76Eh728YINpBm4NZzB3PziJuMMyBozDdqu348A9iUenY0AaD6QOqDJXrymu2P lBsQXdVyO1rOp04GTRQwOIdwBmkZYTN9rfxyQUC+KBOe8GUIbUU6JyU8ncyuaJpjsgCL +OEyEVP0p4YIs776thmtcnGO6kAPoFPVVH2dYnNWhcKkQR+BM3BuAnURvEZFsdFnoL83 TL11TIi5427NDvTEUgV9tqzkZ04nsvfBa2hRd9jeIUeNFGSBja6pDdhFHkJGEkxAFzyZ loKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934372; x=1783539172; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YK4DO2yTgoTSHNgYS/yt/30ZUc46SVmXG9Yy1qokrf0=; b=EvwtXZslMj9sd2x6tYhjzn04oKlM1lwEKWX90rmYlfdsC6RqfTaX8FHPEebaBUq18W W7+2VrCXG4akaqYR8ZEGpzeLgcc3Sf71gsrOwFxBVl1ZG2CigPaHaXiP8MtZJngyGZgx 2WGgQmANY+u8HS4A0paJBB3RgT7U0D9UDC3f5W+Buc+r8VtN0ywJ2Bj/Ur5cabDFcqgb t+nQclTp61tDwfKT24J7Uuh2Q/OKXD68X8pNiEVcIcil3d7AsZSx6SMJCDkWWEnWg1/D 38EBovtQs9M/lv1TT2fngq/jOr9TbYKxJiYSNtMjeizzQJWL9JK3WVi5U0lgyzqGYD1Y uiZA== X-Forwarded-Encrypted: i=1; AFNElJ8/LOlB7Uyh+BtSEW6pLH0yB4f47gInY50DaiG4pqWwrQzbXRhZSbNVXFx9IB/TqEFCueTvkY6eZ28=@lists.xenproject.org X-Gm-Message-State: AOJu0YyD/CttmOM/SP2zFWr6KHRmmacy7tQxFToQ8ussbXyph5yjdjhu z6hupi3JAyNfwBCFvpdHs+CZq1MJghm6854XMRaeKPL+Tvj4VQr1wfjLXv0wHqBzKYU+gNwXb2O LHCy3IA== X-Received: from pgam28.prod.google.com ([2002:a05:6a02:2b5c:b0:c96:bec2:5af7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7486:b0:3b4:65ac:e2e6 with SMTP id adf61e73a8af0-3bfed362212mr3320468637.36.1782934371539; Wed, 01 Jul 2026 12:32:51 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:42 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-22-seanjc@google.com> Subject: [PATCH v5 21/51] x86/kvm: Obtain TSC frequency from PV CPUID if present From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-16d1c6/1782934374-F999168D-5FAF1F8C/0/0 X-purgate-type: clean X-purgate-size: 5049 From: David Woodhouse In https://lkml.org/lkml/2008/10/1/246 a proposal was made for generic CPUID conventions across hypervisors. It was mostly shot down in flames, but the leaf at 0x40000010 containing timing information didn't die. It's used by XNU and FreeBSD guests under all hypervisors=C2=B9=C2=B2 to de= termine the TSC frequency, and also exposed by the EC2 Nitro hypervisor (as well as, presumably, VMware). FreeBSD's Bhyve is probably just about to start exposing it too. Use it under KVM to obtain the TSC frequency more accurately, instead of reverse-calculating the frequency from the mul/shift values in the KVM clock. Use the information to get the CPU frequency as well (kvmclock feeds in kvm_get_tsc_khz() for both TSC and CPU calibration), as the info from CPUID is superior in every way; whether or not kvmclock should be overriding CPU calibration in the first place is an entirely different question. Use the info from CPUID even if the user explicitly disables kvmclock, or if it's unsupported. The PV CPUID leaf has no dependency on kvmclock, and is in fact more useful if kvmclock is disabled since the kernel won't be able to use kvmclock to derive a derive the TSC frequency. Before: [ 0.000020] tsc: Detected 2900.014 MHz processor After: [ 0.000020] tsc: Detected 2900.015 MHz processor $ cpuid -1 -l 0x40000010 CPU: hypervisor generic timing information (0x40000010): TSC frequency (Hz) =3D 2900015 bus frequency (Hz) =3D 1000000 Note! *Independently* query for non-null get_{cpu,tsc}_khz() overrides so that kvmclock doesn't clobber x86_init.hyper.get_cpu_khz() if/when KVM adds support for getting the CPU frequency separately from the TSC frequency. =C2=B9 https://github.com/apple/darwin-xnu/blob/main/osfmk/i386/cpuid.c =C2=B2 https://github.com/freebsd/freebsd-src/commit/4a432614f68 Signed-off-by: David Woodhouse Co-developed-by: Sean Christopherson Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvm.c | 33 +++++++++++++++++++++++++++++++++ arch/x86/kernel/kvmclock.c | 6 ++++-- 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index dcef84da304b..909d3e5e5bcd 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -49,6 +49,8 @@ #include #include =20 +static unsigned int kvm_tsc_khz_cpuid __initdata; + DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled); =20 static int kvmapf =3D 1; @@ -911,6 +913,21 @@ bool kvm_para_available(void) } EXPORT_SYMBOL_GPL(kvm_para_available); =20 +static u32 __init kvm_cpuid_timing_info_leaf(void) +{ + u32 base =3D kvm_cpuid_base(); + + if (!base || cpuid_eax(base) < (base | KVM_CPUID_TIMING_INFO)) + return 0; + + return base | KVM_CPUID_TIMING_INFO; +} + +static unsigned int __init kvm_get_tsc_khz(void) +{ + return kvm_tsc_khz_cpuid; +} + unsigned int kvm_arch_para_features(void) { return cpuid_eax(kvm_cpuid_base() | KVM_CPUID_FEATURES); @@ -960,6 +977,7 @@ static void __init kvm_init_platform(void) .mask_lo =3D (u32)(~(SZ_4G - tolud - 1)) | MTRR_PHYSMASK_V, .mask_hi =3D (BIT_ULL(boot_cpu_data.x86_phys_bits) - 1) >> 32, }; + u32 timing_info_leaf; =20 if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) && kvm_para_has_feature(KVM_FEATURE_MIGRATION_CONTROL)) { @@ -1007,6 +1025,21 @@ static void __init kvm_init_platform(void) wrmsrq(MSR_KVM_MIGRATION_CONTROL, KVM_MIGRATION_READY); } + + /* + * If KVM advertises the frequency directly in CPUID, use that instead + * of reverse-calculating it from the KVM clock data, or worse, trying + * to calibratate the TSC using an emulated device. + */ + timing_info_leaf =3D kvm_cpuid_timing_info_leaf(); + if (timing_info_leaf) { + kvm_tsc_khz_cpuid =3D cpuid_eax(timing_info_leaf); + if (kvm_tsc_khz_cpuid) { + x86_init.hyper.get_tsc_khz =3D kvm_get_tsc_khz; + x86_init.hyper.get_cpu_khz =3D kvm_get_tsc_khz; + } + } + kvmclock_init(); x86_platform.apic_post_init =3D kvm_apic_init; =20 diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 29ca37e9a3bc..f55d0305d1f3 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -342,8 +342,10 @@ void __init kvmclock_init(void) flags =3D pvclock_read_flags(&hv_clock_boot[0].pvti); kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); =20 - x86_init.hyper.get_tsc_khz =3D kvmclock_get_tsc_khz; - x86_init.hyper.get_cpu_khz =3D kvmclock_get_tsc_khz; + if (!x86_init.hyper.get_tsc_khz) + x86_init.hyper.get_tsc_khz =3D kvmclock_get_tsc_khz; + if (!x86_init.hyper.get_cpu_khz) + x86_init.hyper.get_cpu_khz =3D kvmclock_get_tsc_khz; x86_platform.get_wallclock =3D kvm_get_wallclock; x86_platform.set_wallclock =3D kvm_set_wallclock; #ifdef CONFIG_X86_LOCAL_APIC --=20 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:33:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350417.1607974 (Exim 4.92) (envelope-from ) id 1wf0g7-0004v2-PG; Wed, 01 Jul 2026 19:32:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350417.1607974; Wed, 01 Jul 2026 19:32:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0g7-0004rz-2f; Wed, 01 Jul 2026 19:32:59 +0000 Received: by outflank-mailman (input) for mailman id 1350417; Wed, 01 Jul 2026 19:32:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3ZWtFagYKCaocOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 1wf0g4-0004MT-PW for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0g4-00B3ua-5r for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:56 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3ZWtFagYKCaocOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 6a456b66-5cb7-0a2a0a5109dd-0a2a4506dc64-4 for ; Wed, 01 Jul 2026 21:32:56 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3ZWtFagYKCaocOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 6a456b66-08de-0a2a45060019-d155d6cab971-3 for ; Wed, 01 Jul 2026 21:32:55 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c9960cf96cso12691805ad.3 for ; Wed, 01 Jul 2026 12:32:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934374; x=1783539174; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=h0seWmgtqawiMKFH9SI3lPf42xnOLUsMbO7m+HkPiqQ=; b=eZKpDRRbIXRxpJ1l4xvUHXk2fBB3j8zllqvdZ/jRD61RfZ8tl8sEGy7SCOt/DwyYV+ a/hwLYCZFj9Ng/rRT06g5L9Thot6ucxjIOoB0vTNT5Er6t9Z3JD7siPB3ejIBLlV78ME GhRgURfUt0ACNR5/xzfnFLjyvoe+dw1KrufNTHKBRjYMWmns/04M+vKL8svXtD1Djjq+ dMPgSF0T1VbWCMuhvj6lSYq5zPydSbV9pGNzL4PdXw5wejNR8o/rLcxpzeA6ns5w/1xt nRbqdjurbJmsUZP6xBClp1xsd45J5jAds8ruJ6qwnjipZNb8X7QCsxT0Ms8oMIIqYXj8 kufA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934374; x=1783539174; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h0seWmgtqawiMKFH9SI3lPf42xnOLUsMbO7m+HkPiqQ=; b=iPGvGeAqtsmJMBsEQ0GDqKZGV9ZdRO/jj9fCBIJsKMpipADU/tEKdIsQrwsiPmtyKx jhSF7DJDKFhKxizIbkF6ODwsbqLRto7mIvs0+yTLjWVkAI5UkifoahcSEYZJy694VAL/ naE4dpSddnZDPkF+0KtMEwMFUFTpN4lgUONcE/Mf1MSUL/i7nKTkiPzkNGRwRT3Uxoe2 rTJbbZxp8pFaFuZJSQ2wipUuacFftMyRvyCuG1xE1r4AOIpGwqrzVa8YhKn6LlOMfnFi chDumqGGnoTbi5vDPkU5hDhpzeBZfFllR5ljd3QS+3CWnIkV/N7NrLBqPANItwTnmp1R jS+w== X-Forwarded-Encrypted: i=1; AHgh+RrdAN5/25dWIQTHYh69IKlgg22f6s6L+N3BT/V4oeAMDm47p21gHQl/7f+I3wVaoEICIPl/3/iUtH0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxbOlqNbCUsE2vPCgYvP5BHt2s0oiVzfAstMsxZ69x8rTlQ7CPR lygURhPxMyTTWAADje+KJrZ5ERmcf+hB3HwhrupEWs8BKfKJfl/qMT2HpjI2NUmh7bvYV/A7SUb v4YIdeQ== X-Received: from plll3.prod.google.com ([2002:a17:902:d043:b0:2c7:ed23:f47c]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d4cd:b0:2c8:1f58:55dd with SMTP id d9443c01a7336-2ca7e710f10mr31641185ad.9.1782934373673; Wed, 01 Jul 2026 12:32:53 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:43 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-23-seanjc@google.com> Subject: [PATCH v5 22/51] x86/kvm: Mark TSC as reliable when it's constant and nonstop From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934376-F89E968D-6525BB46/0/0 X-purgate-type: clean X-purgate-size: 3796 Mark the TSC as reliable if the hypervisor (KVM) has enumerated the TSC as constant and nonstop. Like most (all?) virtualization setups, any secondary clocksource that's used as a watchdog is guaranteed to be less reliable than a constant, nonstop TSC, as all clocksources the kernel uses as a watchdog are all but guaranteed to be emulated when running as a KVM guest. I.e. any observed discrepancies between the TSC and watchdog will be due to jitter in the watchdog. This is especially true for KVM, as the watchdog clocksource is usually emulated in host userspace, i.e. reading the clock incurs a roundtrip cost of thousands of cycles. Marking the TSC reliable addresses a flaw where the TSC will occasionally be marked unstable if the host is under moderate/heavy load. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_para.h | 2 +- arch/x86/kernel/kvm.c | 12 +++++++++++- arch/x86/kernel/kvmclock.c | 14 +++++--------- 3 files changed, 17 insertions(+), 11 deletions(-) diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h index 4a47c16e2df8..4a49fc286b4c 100644 --- a/arch/x86/include/asm/kvm_para.h +++ b/arch/x86/include/asm/kvm_para.h @@ -118,7 +118,7 @@ static inline long kvm_sev_hypercall3(unsigned int nr, unsigned long p1, } #ifdef CONFIG_KVM_GUEST -void kvmclock_init(void); +void kvmclock_init(bool prefer_tsc); void kvmclock_disable(void); bool kvm_para_available(void); unsigned int kvm_arch_para_features(void); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 909d3e5e5bcd..1cef54e1e7d9 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -978,6 +978,7 @@ static void __init kvm_init_platform(void) .mask_hi = (BIT_ULL(boot_cpu_data.x86_phys_bits) - 1) >> 32, }; u32 timing_info_leaf; + bool tsc_is_reliable; if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) && kvm_para_has_feature(KVM_FEATURE_MIGRATION_CONTROL)) { @@ -1040,7 +1041,16 @@ static void __init kvm_init_platform(void) } } - kvmclock_init(); + /* + * If the TSC counts at a constant frequency across P/T states and in + * deep C-states, treat the TSC reliable, as guaranteed by KVM. + */ + tsc_is_reliable = boot_cpu_has(X86_FEATURE_CONSTANT_TSC) && + boot_cpu_has(X86_FEATURE_NONSTOP_TSC); + if (tsc_is_reliable) + setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); + + kvmclock_init(tsc_is_reliable); x86_platform.apic_post_init = kvm_apic_init; /* diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index f55d0305d1f3..2e7ab54cb9dc 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -307,7 +307,7 @@ static int kvmclock_setup_percpu(unsigned int cpu) return p ? 0 : -ENOMEM; } -void __init kvmclock_init(void) +void __init kvmclock_init(bool prefer_tsc) { u8 flags; @@ -356,15 +356,11 @@ void __init kvmclock_init(void) kvm_get_preset_lpj(); /* - * X86_FEATURE_NONSTOP_TSC is TSC runs at constant rate - * with P/T states and does not stop in deep C-states. - * - * Invariant TSC exposed by host means kvmclock is not necessary: - * can use TSC as clocksource. - * + * If TSC is preferred over kvmlock, drop kvmclock's rating so that TSC + * is chosen as the clocksource (but still register kvmclock in case + * the kernel doesn't want to use TSC for whatever reason). */ - if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC) && - boot_cpu_has(X86_FEATURE_NONSTOP_TSC)) + if (prefer_tsc) kvm_clock.rating = 299; clocksource_register_hz(&kvm_clock, NSEC_PER_SEC); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:33:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:33:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350423.1607984 (Exim 4.92) (envelope-from ) id 1wf0g9-0005Il-EP; Wed, 01 Jul 2026 19:33:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350423.1607984; Wed, 01 Jul 2026 19:33:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0g8-0005HZ-Vh; Wed, 01 Jul 2026 19:33:00 +0000 Received: by outflank-mailman (input) for mailman id 1350423; Wed, 01 Jul 2026 19:32:59 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3Z2tFagYKCaweQMZVOSaaSXQ.OaYjQZ-PQhQXXUefe.jQZbdaVQOf.adS@flex--seanjc.bounces.google.com>) id 1wf0g6-0004kx-P4 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:32:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0g6-00B3ua-4v for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:32:58 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3Z2tFagYKCaweQMZVOSaaSXQ.OaYjQZ-PQhQXXUefe.jQZbdaVQOf.adS@flex--seanjc.bounces.google.com>) id 6a456b66-5cb7-0a2a0a5109dd-0a2a4506dc64-10 for ; Wed, 01 Jul 2026 21:32:58 +0200 Received: from [209.85.215.202] (helo=mail-pg1-f202.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3Z2tFagYKCaweQMZVOSaaSXQ.OaYjQZ-PQhQXXUefe.jQZbdaVQOf.adS@flex--seanjc.bounces.google.com>) id 6a456b68-08de-0a2a45060019-d155d7cabd77-3 for ; Wed, 01 Jul 2026 21:32:57 +0200 Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c88d7a75507so1270513a12.1 for ; Wed, 01 Jul 2026 12:32:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934376; x=1783539176; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=3ZuhwNx9YXpitDLlgZzJCjWGiYgYUv+Ggq0FniuPOLw=; b=lxViW8WAJLXW6fMwttCfBrvJau12GH0yFmxR3UbXxuiFGU96fiEtXlscE74f+R07WE lOhlDvbXsKo/qw/Pc4zPtWO6sRS+YPeUtMgA8yKHXicnQ0OArimn24MxhzRlTSIJ27oC 1V9D+8cbZTWYAZu3SBz5nfMzYVYJjMl23hLDeR4ZLCV0R+6gFT4dkkE7uVZexeRw4naU T/1+tSlVELR60wesaF+Jesfw4vkNb2Zvr68vakCLdahpH4ZgWUH8EifVOtWD9J+9skOx hXSSpTUP9NmD0izmzISOz84bkNiVLSd2ueF9QQW+e2+So5rvS1IQCcurWwHagmqz52P9 MnpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934376; x=1783539176; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3ZuhwNx9YXpitDLlgZzJCjWGiYgYUv+Ggq0FniuPOLw=; b=k8vy7BY1tyIgE2nAztY3G1w39a9vo1OdTg+rcOtZXD9SPP0RMLBvi+yZRCadIFVO9R UCylPxrqFk5rJxjNwi00k/g4WobgsrHjlr2qXQNNQLoA1/9h3lXNmvr29LrMyAEsh4T1 llWMsHJAdnq/fRBNKwBJTYJbPSzfSBD2dke4+1pgDudB1vhe2UUFbwFyJcr92ccJbiGg L+kzQQlgmnKOyjMjsqvyK4cWWQ9y9969tkTmlhhBgsvg7KR2GZ3Vi32Kr5Zse7R8dUT1 sHeVFCZ3DMkL6Tl8/v732QLHNDw4kqXbk77Xnn+Zdy2lXRHKPJd58+mZdIAj+gHBMYA/ Y8Tg== X-Forwarded-Encrypted: i=1; AFNElJ9FhIlk1G5iIAk9Gchk4MbQDEbfi30zXL3PgfyB+w7IjAgp4wNAqyC6B3oYV2eqb2Kx6rHvuQBio5c=@lists.xenproject.org X-Gm-Message-State: AOJu0YyTOqWjB5ezIPJWmvIMshp73BuQwMX+foOzfpFzqO7L8B4EUI67 6WMaB6e+xwyhv71x1kVdNkVdo7ptplCGbLg/WmOQcMiRxdF8XwfDMu+3gTx6VD99AQMqAEHENiw h0V2Jng== X-Received: from pglx30.prod.google.com ([2002:a63:171e:0:b0:c9e:a22d:15c4]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:6e8f:b0:3bf:d0c8:2aa4 with SMTP id adf61e73a8af0-3bfed1c3990mr3189645637.8.1782934375853; Wed, 01 Jul 2026 12:32:55 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:45 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-25-seanjc@google.com> Subject: [PATCH v5 24/51] x86/kvm: Get CPU base frequency from CPUID when it's available From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934378-41F3C68D-88305DC7/0/0 X-purgate-type: clean X-purgate-size: 1781 If CPUID.0x16 is present and valid, use the CPU frequency provided by CPUID instead of assuming that the virtual CPU runs at the same frequency as TSC and/or kvmclock. Back before constant TSCs were a thing, treating the TSC and CPU frequencies as one and the same was somewhat reasonable, but now it's nonsensical, especially if the hypervisor explicitly enumerates the CPU frequency. Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvm.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 1cef54e1e7d9..6c7011ff7bd1 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -50,6 +50,7 @@ #include static unsigned int kvm_tsc_khz_cpuid __initdata; +static unsigned int kvm_cpu_khz_cpuid __initdata; DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled); @@ -928,6 +929,11 @@ static unsigned int __init kvm_get_tsc_khz(void) return kvm_tsc_khz_cpuid; } +static unsigned int __init kvm_get_cpu_khz(void) +{ + return kvm_cpu_khz_cpuid; +} + unsigned int kvm_arch_para_features(void) { return cpuid_eax(kvm_cpuid_base() | KVM_CPUID_FEATURES); @@ -1041,6 +1047,14 @@ static void __init kvm_init_platform(void) } } + /* + * Prefer CPUID.0x16 over KVM's PV CPUID when possible, as the base CPU + * frequency isn't necessarily the same as the TSC frequency. + */ + kvm_cpu_khz_cpuid = __cpu_khz_from_cpuid(); + if (kvm_cpu_khz_cpuid) + x86_init.hyper.get_cpu_khz = kvm_get_cpu_khz; + /* * If the TSC counts at a constant frequency across P/T states and in * deep C-states, treat the TSC reliable, as guaranteed by KVM. -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:33:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350471.1607996 (Exim 4.92) (envelope-from ) id 1wf0gN-0007DJ-Hx; Wed, 01 Jul 2026 19:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350471.1607996; Wed, 01 Jul 2026 19:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0gN-0007DC-EU; Wed, 01 Jul 2026 19:33:15 +0000 Received: by outflank-mailman (input) for mailman id 1350471; Wed, 01 Jul 2026 19:33:14 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3dmtFagYKCbstfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 1wf0gM-00077Q-5r for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:33:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0gL-00B3zO-J2 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:33:13 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3dmtFagYKCbstfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 6a456b79-5cb7-0a2a0a5109dd-0a2a4504c410-0 for ; Wed, 01 Jul 2026 21:33:13 +0200 Received: from [209.85.210.201] (helo=mail-pf1-f201.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3dmtFagYKCbstfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 6a456b77-a01d-0a2a45040019-d155d2c9e504-3 for ; Wed, 01 Jul 2026 21:33:13 +0200 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-8423f1fe39eso1388375b3a.1 for ; Wed, 01 Jul 2026 12:33:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934391; x=1783539191; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=V+q3+pR5470wsF5QmCXBVWy55xlVZlxhghTF4iDuO4s=; b=k/jTfYAXzhYkYwJe2JoqeSZsue0Bv+f08tun5UaL/5Ytz5h2e0lkBz1mRhR5qWkDjZ qewBBvuv7qCJ5QBWztC+B9uUv1G+defKU3U+99BCzBD5DWcW1/wfh6HedKpK+fJLIoNW vly2dFFRvk3+diZLZi6Goqht29p1tPS666bOMs6uRYFLGGgYMvw8VbR3Trqcpnmo3S/f 0fvoxxKtc1Px5IlCtscD5NkRCSa0Tx1SoypmQVHQNu3V4r9cTqVWaU6uBUenGN2ef2Cw +plK28ccWd1Fw/qdEJzuRaQcvfRgP3RkCCOoRLv4TmZFvCZJ+CcXn5DY6Fni2Ez1Jwvx 0Dwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934391; x=1783539191; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V+q3+pR5470wsF5QmCXBVWy55xlVZlxhghTF4iDuO4s=; b=DhV56l2G4NT6wV7U3bSzKp41bhVvBNAn3Jd1gkMfOtfvPCveWJbRUYnn0YCsV3CyFp HoAXrsYeM8sKSvUq2hUyQe4fq0Tnb23u08jpk7YfJJi2mjlnCTpe//YzB7x9hnDzXk3y eZ67JVtsN6c1Lf6H9pQ4ev+Aa656Uu/39mvGsxPE7etT4C9uFuXTrX/FUk+lQO1TmoU2 w1nFZr6WbyG2jXGxgPBWqPiQvSh+kuMfSvPdyL43u4hbZHXtb2pdy1uArsW8DrIJ5SHr kmlv+6pMqTRaxcFb+m2MQtoFYImUketSTtgw7cDeOHTo4o5eJuEujFRkMJcpMTeHeIIs A6sQ== X-Forwarded-Encrypted: i=1; AFNElJ8gxUfFUT6Z9+J18d0Fgq03EVQ7dd/jta98mspO7G4DZnbZwFsUiA/fksQMr9sWV1OdQCFM7wSIik4=@lists.xenproject.org X-Gm-Message-State: AOJu0YzYkIPehdpksCBvAYJggMRBNgh+asMawGM2UR2ahtZAcCUMhzt3 Tw+ecLsqZOzfjtLkrlP6gLyc0b2pzprZqHe0db0SSZAy8LmEIMF89+kmqkSiGXWTF0UrnE5zNI5 1vj7/Eg== X-Received: from pfblh19.prod.google.com ([2002:a05:6a00:7113:b0:847:926b:dc16]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2d0e:b0:845:d284:9e11 with SMTP id d2e1a72fcca58-847c51d242emr1964528b3a.56.1782934390999; Wed, 01 Jul 2026 12:33:10 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:57 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-37-seanjc@google.com> Subject: [PATCH v5 36/51] x86/paravirt: Pass sched_clock save/restore helpers during registration From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934393-2E95B1CC-BFF08E8F/0/0 X-purgate-type: clean X-purgate-size: 5719 Pass in a PV clock's save/restore helpers when configuring sched_clock instead of relying on each PV clock to manually set the save/restore hooks. In addition to bringing sanity to the code, this will allow gracefully "rejecting" a PV sched_clock, e.g. when running as a CoCo guest that has access to a "secure" TSC. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 9 ++++++--- arch/x86/kernel/cpu/vmware.c | 8 +++----- arch/x86/kernel/kvmclock.c | 6 +++--- arch/x86/kernel/tsc.c | 5 ++++- arch/x86/xen/time.c | 5 ++--- drivers/clocksource/hyperv_timer.c | 6 ++---- 6 files changed, 20 insertions(+), 19 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index fe41d40a9ae6..e97cd1ae03d1 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,11 +14,14 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable); +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)); -static inline void paravirt_set_sched_clock(u64 (*func)(void)) +static inline void paravirt_set_sched_clock(u64 (*func)(void), + void (*save)(void), + void (*restore)(void)) { - __paravirt_set_sched_clock(func, true); + __paravirt_set_sched_clock(func, true, save, restore); } #endif diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 5c1ccaf4a25e..232255279a6e 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -347,11 +347,9 @@ static void __init vmware_paravirt_ops_setup(void) vmware_cyc2ns_setup(); - if (vmw_sched_clock) { - paravirt_set_sched_clock(vmware_sched_clock); - x86_platform.save_sched_clock_state = x86_init_noop; - x86_platform.restore_sched_clock_state = x86_init_noop; - } + if (vmw_sched_clock) + paravirt_set_sched_clock(vmware_sched_clock, + x86_init_noop, x86_init_noop); if (vmware_is_stealclock_available()) { has_steal_clock = true; diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 07e875738c39..5b9955343199 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -158,7 +158,9 @@ static void kvm_restore_sched_clock_state(void) static inline void kvm_sched_clock_init(bool stable) { kvm_sched_clock_offset = kvm_clock_read(); - __paravirt_set_sched_clock(kvm_sched_clock_read, stable); + __paravirt_set_sched_clock(kvm_sched_clock_read, stable, + kvm_save_sched_clock_state, + kvm_restore_sched_clock_state); pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); @@ -367,8 +369,6 @@ void __init kvmclock_init(bool prefer_tsc) #ifdef CONFIG_SMP x86_cpuinit.early_percpu_clock_init = kvm_setup_secondary_clock; #endif - x86_platform.save_sched_clock_state = kvm_save_sched_clock_state; - x86_platform.restore_sched_clock_state = kvm_restore_sched_clock_state; kvm_get_preset_lpj(); /* diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 7473dcab4775..83353d643150 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,12 +280,15 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable) +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)) { if (!stable) clear_sched_clock_stable(); static_call_update(pv_sched_clock, func); + x86_platform.save_sched_clock_state = save; + x86_platform.restore_sched_clock_state = restore; } #else u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 477441752f40..8cd8bfaf1320 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -566,13 +566,12 @@ static void __init xen_init_time_common(void) { xen_sched_clock_offset = xen_clocksource_read(); static_call_update(pv_steal_clock, xen_steal_clock); - paravirt_set_sched_clock(xen_sched_clock); + /* * Xen has paravirtualized suspend/resume and so doesn't use the common * x86 sched_clock save/restore hooks. */ - x86_platform.save_sched_clock_state = x86_init_noop; - x86_platform.restore_sched_clock_state = x86_init_noop; + paravirt_set_sched_clock(xen_sched_clock, x86_init_noop, x86_init_noop); x86_init.hyper.get_tsc_khz = xen_tsc_khz; x86_platform.get_wallclock = xen_get_wallclock; diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index 220668207d19..8ee7a9de0f4f 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -570,10 +570,8 @@ static void hv_restore_sched_clock_state(void) static __always_inline void hv_setup_sched_clock(void *sched_clock) { /* We're on x86/x64 *and* using PV ops */ - paravirt_set_sched_clock(sched_clock); - - x86_platform.save_sched_clock_state = hv_save_sched_clock_state; - x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; + paravirt_set_sched_clock(sched_clock, hv_save_sched_clock_state, + hv_restore_sched_clock_state); } #else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */ static __always_inline void hv_setup_sched_clock(void *sched_clock) {} -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:33:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350487.1608006 (Exim 4.92) (envelope-from ) id 1wf0gT-0007wi-Pj; Wed, 01 Jul 2026 19:33:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350487.1608006; Wed, 01 Jul 2026 19:33:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0gT-0007wZ-Mp; Wed, 01 Jul 2026 19:33:21 +0000 Received: by outflank-mailman (input) for mailman id 1350487; Wed, 01 Jul 2026 19:33:19 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3fGtFagYKCcEzlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 1wf0gR-0007pp-Sl for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:33:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0gR-00BwAh-9l for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:33:19 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3fGtFagYKCcEzlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 6a456b5d-e002-0a2a0a5209dd-0a2a450cb9fc-38 for ; Wed, 01 Jul 2026 21:33:19 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3fGtFagYKCcEzlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 6a456b7d-f399-0a2a450c0019-d155d84acd57-3 for ; Wed, 01 Jul 2026 21:33:19 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-37c9127e316so1038123a91.1 for ; Wed, 01 Jul 2026 12:33:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934397; x=1783539197; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=UQI87jJDSOF5xYM7+FYJ7P3rXlAyaoExltyOrt00Pyo=; b=ika9TgK0rkbiNzrK4gMAB5TRAB71i6Og/pR24Qe4F088Y8IvCifB+gBdHsfNjjfLJ1 i34osTpGwqcI0ls+jptQQbviO8TZ1NVekH6qz4F7RZJ1VNvD55PKzktUxOxqzsI7INkK hxhygHM8zBZs89G7jRPdYiPIgN7iiXX6R/e+P82w1AdFMLxFq9aTdHxcav8Zyy/HvGA0 dvN/Dm91RhhpgGbpNOrNjVnZzMvf2gQqGBjRcSFQH0nZatY+3NximtvQ739RjRwSkv95 wVhKpE1Mvp8qzM71ZegMdkliA1UAM8hP4BHRBuxzMCiCKIJKZFXDpDuDYVXiM0wFlGyK r34w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934397; x=1783539197; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UQI87jJDSOF5xYM7+FYJ7P3rXlAyaoExltyOrt00Pyo=; b=i7Z5IPdAJQy/XfTUi/BkCQLj/34G9cENs64DMQ2yuXTWawWsw8y6odZ8yKdfmfjObO o2bPFQakgNkyhFNuQaeXj7gkcv3wQS2r0v6oKNjh8ts3O54qPRicAjgJVYwhxLgSUV17 nmEv1S2A9fnuk0XBrz41uaMV9Xq9R7K9+kGXIinTghUZW/TQb3+Bx3Ggijjg/MmJNOZ/ EcvqPybkdswQw1GvQeJ/0MhiuxUDEYNpd1e6lmFMjZy91YPp0eGE6RwPx/qaOzISQ6QI gUpa/2pL7GtO4XJw5/T7Ul+x/6THPn0g2ctjwNWrCO1BRii79TkiWh2twzmXQXSnWv0A sGAg== X-Forwarded-Encrypted: i=1; AHgh+RopvbsKRY2mNXcOLdJndcbuLLn83T9YJaopL3D4bsxqCntGzrFdT96vCYu8I3TeMgfjiw2043fN5bY=@lists.xenproject.org X-Gm-Message-State: AOJu0YytHUUScqb4EBDS+rfTHD41QovF7Pmg2L0ZGaWnKK8+hjflqePV 1B/x3b27kYmY7K6yMZLVLQg8bTIa32KEpwFDyjjFUy9LuPWBXcF5q/ckeIRv7Fk1dX7lqj/K14l 3PgMHYw== X-Received: from pjbcv6.prod.google.com ([2002:a17:90a:fd06:b0:37d:de2f:3ddf]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4e84:b0:37f:eda5:5169 with SMTP id 98e67ed59e1d1-380aa127da8mr2911601a91.13.1782934396852; Wed, 01 Jul 2026 12:33:16 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:02 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-42-seanjc@google.com> Subject: [PATCH v5 41/51] x86/kvmclock: Refactor handling of PVCLOCK_TSC_STABLE_BIT during kvmclock_init() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d25034/1782934399-93737D51-E8DF9952/0/0 X-purgate-type: clean X-purgate-size: 1898 Clean up the setting of PVCLOCK_TSC_STABLE_BIT during kvmclock init to make it somewhat obvious that pvclock_read_flags() must be called *after* pvclock_set_flags(). Note, in theory, a different PV clock could have set PVCLOCK_TSC_STABLE_BIT in the supported flags, i.e. reading flags only if KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is set could very, very theoretically result in a change in behavior. In practice, the kernel only supports a single PV clock. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 5220d205abc7..61d4d943fe74 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -327,7 +327,7 @@ static __init void kvm_sched_clock_init(bool stable) void __init kvmclock_init(bool prefer_tsc) { - u8 flags; + bool stable = false; if (!kvm_para_available() || !kvmclock) return; @@ -354,11 +354,18 @@ void __init kvmclock_init(bool prefer_tsc) kvm_register_clock("primary cpu clock"); pvclock_set_pvti_cpu0_va(hv_clock_boot); - if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT)) + if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT)) { pvclock_set_flags(PVCLOCK_TSC_STABLE_BIT); - flags = pvclock_read_flags(&hv_clock_boot[0].pvti); - kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); + /* + * Check if the clock is stable *after* marking TSC_STABLE as a + * valid flag. + */ + stable = pvclock_read_flags(&hv_clock_boot[0].pvti) & + PVCLOCK_TSC_STABLE_BIT; + } + + kvm_sched_clock_init(stable); if (!x86_init.hyper.get_tsc_khz) x86_init.hyper.get_tsc_khz = kvmclock_get_tsc_khz; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:33:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:33:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350501.1608015 (Exim 4.92) (envelope-from ) id 1wf0gY-000075-6V; Wed, 01 Jul 2026 19:33:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350501.1608015; Wed, 01 Jul 2026 19:33:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0gY-00006l-1u; Wed, 01 Jul 2026 19:33:26 +0000 Received: by outflank-mailman (input) for mailman id 1350501; Wed, 01 Jul 2026 19:33:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3gmtFagYKCcc5rn0wpt11tyr.p1zAr0-qr8ryyv565.Ar0241wrp6.14t@flex--seanjc.bounces.google.com>) id 1wf0gX-0008Vk-Ga for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:33:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0gW-00B3zO-To for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:33:24 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3gmtFagYKCcc5rn0wpt11tyr.p1zAr0-qr8ryyv565.Ar0241wrp6.14t@flex--seanjc.bounces.google.com>) id 6a456b79-5cb7-0a2a0a5109dd-0a2a4504c410-16 for ; Wed, 01 Jul 2026 21:33:24 +0200 Received: from [209.85.210.201] (helo=mail-pf1-f201.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3gmtFagYKCcc5rn0wpt11tyr.p1zAr0-qr8ryyv565.Ar0241wrp6.14t@flex--seanjc.bounces.google.com>) id 6a456b83-a01d-0a2a45040019-d155d2c9adc0-3 for ; Wed, 01 Jul 2026 21:33:24 +0200 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-847a2509456so1136966b3a.1 for ; Wed, 01 Jul 2026 12:33:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934403; x=1783539203; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=4/M1D57lssm/A6RYRKDqaCs4EQpgkZGCf/uDo3WK1sI=; b=wfMBPqMjP87Bz44fHELq8qviF5v6Gytxq5XFD8N/7Y8mzyjiAUvgOCxF2ZBVRBp/Av IvsQsfjPu0ZbzepH2FnezRhq0oux8Cl6MMaVInWmk2Ab3++7OQ+xn8goHbkGBgKcWMbQ wJBM+k2WxcmC54nGWFSYnItTMC0n3Vf2aIATS5DN2sJBUrO0fUBnHU90EBdXY95M7KPB RPQhJk9tnUxGoAuAkPNiqT4TUe3odr30dudeyO3EqG4CeXuFIK/hr694q4fNeAWqRXTw 7ALlIJrkL9Fik8a+oOu+EuklROkCbFrAMDLOxpQJFsPKdEwDEzE9KKOGv4AGI/bilEUt 8L5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934403; x=1783539203; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4/M1D57lssm/A6RYRKDqaCs4EQpgkZGCf/uDo3WK1sI=; b=p7Iv5dKEz+O7Cbx8W5EX+naq/DizaYkMXwEQrKH1lb6HEKNahQDTPuCfwccTbI/0Q2 FxrG+ZQ3yQW4r/YDWS3hK+xcf6kCknGLXqRKWC8u2MptnBMeGtMxSFI79j2rjfVLKGvp Cmx3CMsRELjLOKddgy+qZox2PYcU/JIlf5+DNIZLUCSZnjlqwkGy9wr5cOYyv1iD6Xly 7QJr/GXBhlRpbNPT35jNFOKv5GLKAvOw2FfnbyBmNhlxarSQ1a5Q9NR4pq2bFgLz5XYS MubWWIVmEdPDyugYX2SkfXkBlhMBeJ8J2ucLUFhCHFFdcO70zyyvoV3+N4KJslhOBN+x R48Q== X-Forwarded-Encrypted: i=1; AFNElJ/A/LQJGzCm5eRSn7PgoUdV/oK70m0T9dWmv+lXSVKwreLlYEvLsDZftiFniKnv+xkVRqzE4J4vykI=@lists.xenproject.org X-Gm-Message-State: AOJu0YwpTZX315N6b/Ty2HRvN0FO8gd5U80WkvfAimjmO8GYrhGkvTJO w1fHQoE8apZY2lAZkSOMaI8dJGhg2jwxKVHjAOAysbS2HguqJxE4TOYLLSdiLuujDYcZmedo4Mz ed1IQTQ== X-Received: from pgal188.prod.google.com ([2002:a63:3ec5:0:b0:c98:a4cf:469b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:62cc:b0:3aa:c964:3c27 with SMTP id adf61e73a8af0-3bfed49ea64mr3435408637.46.1782934402561; Wed, 01 Jul 2026 12:33:22 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:07 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-47-seanjc@google.com> Subject: [PATCH v5 46/51] x86/paravirt: Plumb a return code into __paravirt_set_sched_clock() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934404-77F251CC-CF0FB594/0/0 X-purgate-type: clean X-purgate-size: 3369 Add a return code to __paravirt_set_sched_clock() so that the kernel can reject attempts to use a PV sched_clock without breaking the caller. E.g. when running as a CoCo VM with a secure TSC, using a PV clock is generally undesirable. Note, kvmclock is the only PV clock that does anything "extra" beyond simply registering itself as sched_clock, i.e. is the only caller that needs to check the new return value. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 6 +++--- arch/x86/kernel/kvmclock.c | 9 ++++++--- arch/x86/kernel/tsc.c | 5 +++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index 96ae7feac47c..ca5c95d48c03 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,14 +14,14 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)); +int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)); static __always_inline void paravirt_set_sched_clock(u64 (*func)(void), void (*save)(void), void (*restore)(void)) { - __paravirt_set_sched_clock(func, true, save, restore); + (void)__paravirt_set_sched_clock(func, true, save, restore); } #endif diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 2cc3dd2ba355..22e8855fcd4d 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -332,10 +332,13 @@ static int kvmclock_setup_percpu(unsigned int cpu) static __init void kvm_sched_clock_init(bool stable) { + /* Ensure the offset is configured before making kvmclock visible! */ kvm_sched_clock_offset = kvm_clock_read(); - __paravirt_set_sched_clock(kvm_sched_clock_read, stable, - kvm_save_sched_clock_state, - kvm_restore_sched_clock_state); + + if (__paravirt_set_sched_clock(kvm_sched_clock_read, stable, + kvm_save_sched_clock_state, + kvm_restore_sched_clock_state)) + return; /* * The BSP's clock is managed via dedicated sched_clock save/restore diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 0f92b29adecc..012321fed5e5 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,8 +280,8 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)) +int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)) { if (!stable) clear_sched_clock_stable(); @@ -289,6 +289,7 @@ void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, static_call_update(pv_sched_clock, func); x86_platform.save_sched_clock_state = save; x86_platform.restore_sched_clock_state = restore; + return 0; } #else u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:33:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:33:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350544.1608033 (Exim 4.92) (envelope-from ) id 1wf0h0-0001ms-Od; Wed, 01 Jul 2026 19:33:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350544.1608033; Wed, 01 Jul 2026 19:33:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0h0-0001mi-LT; Wed, 01 Jul 2026 19:33:54 +0000 Received: by outflank-mailman (input) for mailman id 1350544; Wed, 01 Jul 2026 19:33:53 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3YmtFagYKCacZLHUQJNVVNSL.JVTeLU-KLcLSSPZaZ.eLUWYVQLJa.VYN@flex--seanjc.bounces.google.com>) id 1wf0gz-0001Z7-GL for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:33:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0gy-004oBL-TW for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:33:52 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3YmtFagYKCacZLHUQJNVVNSL.JVTeLU-KLcLSSPZaZ.eLUWYVQLJa.VYN@flex--seanjc.bounces.google.com>) id 6a456b9c-2eae-0a2a0a5409dd-0a2a4509e6b8-6 for ; Wed, 01 Jul 2026 21:33:52 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3YmtFagYKCacZLHUQJNVVNSL.JVTeLU-KLcLSSPZaZ.eLUWYVQLJa.VYN@flex--seanjc.bounces.google.com>) id 6a456b63-97e6-0a2a45090019-d155d6cab8da-3 for ; Wed, 01 Jul 2026 21:32:52 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c9f452d260so14902225ad.2 for ; Wed, 01 Jul 2026 12:32:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934371; x=1783539171; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=UfbO84e0Sh/RDtmtar1VNwA0GsKq34HNdlIOIT+krtA=; b=AMRXTX9RbUJm6EZTMErtVm2SOxZxGNRMbsJeTYXz1MSKJZdeUpfr3oYsmz+pV5WqgW HRVba+crviIXfXkCo4r5FBnNAbWF9x9OBnJgnmUO/QmV2EVI2z6zzOMK2dCV/J2hjvQa zQkn7X/oyW4Q2jemRPb5y0fY+NA40WiahJeSMlEgTcJ4fdRaM9rMplbzXP9c9dYk4gxq Oz9jJWrvA5gxsPkWojGP3sflAkI886i79+XOhYtAX5dXCEoPR0yyLGrX9AdMsHEqpHKQ akaae/pdc+sS8gLlHZdS0PEnic6dTOPaoAT9dkFH4r8LskqOfNfSyVDYy/24tV8eU1SG 8o4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934371; x=1783539171; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UfbO84e0Sh/RDtmtar1VNwA0GsKq34HNdlIOIT+krtA=; b=CfZwskGBmQ6jg1Ug52r5uRHuibGs7iTXKeCcQqpROuup/36U8rP4iAv1yxiBteyYbk 2cTqkwHzMA4K5zj7OV/J/Y5BuHhTN5DfjbcWef3SO5MBAHP53lHWZycr0Yjj3/M63TDt iS+mulqY80MCqhgp+6EaaG1E+EU/c5a+DXs8VpiMu6BA+XCpcO/+zwJq3CW67Azbqs5W It+F01p+nRhLrbTJMqOSb8DKlJg4GC56APZyBtL6FhyZeVFkbdWqmgReozDDvcijjfeq PkcsUMocXGXzRjFNuCOXStHzEnVT3VbyC24OZG2GOLnp/zzK7hckf4y5IyKMH3yud7vs f3DA== X-Forwarded-Encrypted: i=1; AFNElJ87yIacb93KF2ygwoQ+urKAAD6QL/3dFb4jn8eqJPVXtvaH8J6lXxZ+RwlseH+bunboXSMP7DXTpZY=@lists.xenproject.org X-Gm-Message-State: AOJu0YxLcXiWLg7uJNU+ZKVfIFo3yha69vEUQBGUV7uJYbIEgn4YsAfs x8XB+sXWM5CZvhwQBS9H38QqdAon9W7vqP7iarKNX5omg6nXpw5WLVG9I6W2TXklLYCSCymLL/5 RoP0A5g== X-Received: from pgkm12.prod.google.com ([2002:a63:ed4c:0:b0:c9e:1056:de15]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:b7a7:b0:3bf:6011:53b with SMTP id adf61e73a8af0-3bfed47e0eamr2900412637.38.1782934370392; Wed, 01 Jul 2026 12:32:50 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:41 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-21-seanjc@google.com> Subject: [PATCH v5 20/51] KVM: x86: Officially define CPUID 0x40000010 as PV Timing Info (TSC and Bus) From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934372-46327986-DD399FFD/13/0 X-purgate-type: clean X-purgate-size: 3773 From: David Woodhouse Formally define and document CPUID 0x40000010 as providing TSC and local APIC bus frequency information for KVM's PV CPUID range. Way back in 2008, VMware proposed (https://lkml.org/lkml/2008/10/1/246) carving out a range of CPUID leaves for use by hypervisors. While the broader proposal from VMware was mostly shot down in flames, use of CPUID 0x40000010 to provide TSC and local APIC bus frequency information survived and made it's way into multiple guest operating systems. XNU unconditionally assumes CPUID 0x40000010 contains the frequency information, if it's present on any hypervisor: https://github.com/apple/darwin-xnu/blob/main/osfmk/i386/cpuid.c As does FreeBSD: https://github.com/freebsd/freebsd-src/commit/4a432614f68 More importantly, QEMU (the de facto "reference" VMM for KVM) has conditionally provided timing information in CPUID 0x40000010 for almost 9 years, since commit 9954a1582e ("x86-KVM: Supply TSC and APIC clock rates to guest like VMWare"). So at this point it would be daft for KVM (or any hypervisor) to expose 0x40000010 for any *other* content. Officially carve out and define the CPUID leaf so that Linux-as-a-guest can follow suit and pull TSC and Local APIC Bus frequency information from CPUID. Defer providing userspace with the necessary information needed to precisely and accurately enumerate the _actual_ configured TSC frequency to the guest (that exact information, along with the scaled ratio, isn't exposed to userspace). As evidenced by QEMU, providing CPUID 0x40000010 without help from KVM is entirely possible, just not ideal. Link: https://lore.kernel.org/all/ea0d7f43d910cee9600b254e303f468722fa355b.camel@infradead.org Signed-off-by: David Woodhouse [sean: drop KVM filling of CPUID, add documentation, massage changelog] Signed-off-by: Sean Christopherson --- Documentation/virt/kvm/x86/cpuid.rst | 12 ++++++++++++ arch/x86/include/uapi/asm/kvm_para.h | 11 +++++++++++ 2 files changed, 23 insertions(+) diff --git a/Documentation/virt/kvm/x86/cpuid.rst b/Documentation/virt/kvm/x86/cpuid.rst index bda3e3e737d7..a5ee8ff052ce 100644 --- a/Documentation/virt/kvm/x86/cpuid.rst +++ b/Documentation/virt/kvm/x86/cpuid.rst @@ -122,3 +122,15 @@ KVM_HINTS_REALTIME 0 guest checks this feature bit to preempted for an unlimited time allowing optimizations ================== ============ ================================= + +function: KVM_CPUID_TIMING_INFO (0x40000010) + +returns:: + + eax = (Virtual) TSC frequency in kHz + ebx = (Virtual) Bus (local APIC timer) frequency in kHz + ecx = 0 (Reserved) + edx = 0 (Reserved) + +Note, KVM only defines the semantics of KVM_CPUID_TIMING_INFO; KVM does NOT +advertise support via KVM_GET_SUPPORTED_CPUID. diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h index a1efa7907a0b..c3a384711f3a 100644 --- a/arch/x86/include/uapi/asm/kvm_para.h +++ b/arch/x86/include/uapi/asm/kvm_para.h @@ -44,6 +44,17 @@ */ #define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 24 +/* + * The timing information leaf provides TSC and local APIC timer frequency + * information to the guest. Note, userspace is responsible for filling the + * leaf with the correct information. + * + * # EAX: (Virtual) TSC frequency in kHz. + * # EBX: (Virtual) Bus (local APIC timer) frequency in kHz. + * # ECX, EDX: Reserved (must be zero). + */ +#define KVM_CPUID_TIMING_INFO 0x40000010 + #define MSR_KVM_WALL_CLOCK 0x11 #define MSR_KVM_SYSTEM_TIME 0x12 -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:33:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:33:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350543.1608024 (Exim 4.92) (envelope-from ) id 1wf0gz-0001ZM-G3; Wed, 01 Jul 2026 19:33:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350543.1608024; Wed, 01 Jul 2026 19:33:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0gz-0001ZA-Cq; Wed, 01 Jul 2026 19:33:53 +0000 Received: by outflank-mailman (input) for mailman id 1350543; Wed, 01 Jul 2026 19:33:52 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3YWtFagYKCaYYKGTPIMUUMRK.IUSdKT-JKbKRROYZY.dKTVXUPKIZ.UXM@flex--seanjc.bounces.google.com>) id 1wf0gy-0001Ye-GL for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:33:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0gx-00BwAh-TJ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:33:51 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3YWtFagYKCaYYKGTPIMUUMRK.IUSdKT-JKbKRROYZY.dKTVXUPKIZ.UXM@flex--seanjc.bounces.google.com>) id 6a456b82-e002-0a2a0a5209dd-0a2a4505e1fc-30 for ; Wed, 01 Jul 2026 21:33:51 +0200 Received: from [209.85.214.201] (helo=mail-pl1-f201.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3YWtFagYKCaYYKGTPIMUUMRK.IUSdKT-JKbKRROYZY.dKTVXUPKIZ.UXM@flex--seanjc.bounces.google.com>) id 6a456b62-3cb2-0a2a45050019-d155d6c9b4b3-3 for ; Wed, 01 Jul 2026 21:32:51 +0200 Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2c81db324caso14283025ad.0 for ; Wed, 01 Jul 2026 12:32:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934370; x=1783539170; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=/Hl8ESM1aN3u3Me6yWngcHpVlzQnDyaS4TqcnFx8YJ8=; b=VQj2JxN+3YFPhUYrmSA270jfRpU/GHRI7DfClXRzUXP+WdhkWC9qg/NjaRWstwm82Q rEQGdC33vJb4CA93TUSvTvLlxsfmjUcdRzTY6akA8VjRiE3YRQbrKAtcEB3hXq2MLPsu bXaXvo0kN7tpuTqKS60FV4QTTTbg84OsaGY1rbd5yeCmBVfP8BUvJyxyE8bYueAx9bhT LxK7GQAlIbOR4eXdAoSLuVgSaAu6qxla1sz9ukbBMgcoSqprMtQUzYfwuduwELWkzP01 4/KRrvZOFfJ61j805QHe3E94sPt6t/3tE6eUqilESODPizVCVy12vKfIBqm6EEcUN+Ft WY6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934370; x=1783539170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/Hl8ESM1aN3u3Me6yWngcHpVlzQnDyaS4TqcnFx8YJ8=; b=fHFle+5MN2daAPW28kh3PHyvXbfzikLghKuyLWmfNqr0ArPow5YWp2vZkWElp20SVs eHpCgW78X37Os9IFBbC/n0gA1EeLOfp03cVfqrGrAj01ZdJyoYBpD+TVelIjatxhyZ7+ 0auoKzdv1iOQX0pjO1HNKIH7YdYs0qF2j1osNenv4+5uEOraMYWl2+hBNljuqR6Sdq21 UW4z5olg3mxksSs4WgBo18fgNq0QoiIMh4EAHYuWcrSc4yOfY93OJj9Go65vLP72ej5g xT6bXH4zA+ZEsDsfHAFyKLlNk2giYSetr0lGUTktHHGDe+lfNm50tLrLoBdMLb4/xI7w HQ2g== X-Forwarded-Encrypted: i=1; AHgh+RoMjuI05Os2CDcGZkY2hsPA9kArUEgbt2cgF0gzUrpj1ZqD0IiyO8pF3AEvfiIh57QcDE6xdPG67rM=@lists.xenproject.org X-Gm-Message-State: AOJu0YweffcS0pMXu56bn8J/gwQGCYRhApdIsYCfN6aZZoCfQi3oh5eq /bMLKnSS3sSJLNOzgYcW3ioiynp2Xh+KWPX6VYhrFT78rPhp/OJgz4rUzQXd6PHnzTx6SjjJbFh /IVF5Tw== X-Received: from plrx15.prod.google.com ([2002:a17:902:b40f:b0:2c0:bd65:1a98]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:18e:b0:2c9:e86e:a9f5 with SMTP id d9443c01a7336-2ca7e73cbd7mr31240015ad.18.1782934369266; Wed, 01 Jul 2026 12:32:49 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:40 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-20-seanjc@google.com> Subject: [PATCH v5 19/51] x86/kvmclock: Drop dead check on TSC being unstable during kvmclock_init() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c201ff/1782934371-0FD1E2B8-D85D69C5/13/0 X-purgate-type: clean X-purgate-size: 1733 As pointed out by Sashiko[*], kvmclock_init() runs before __setup() and thus before notsc_setup() or tsc_setup() can mark the TSC unstable. kvmclock_init() also runs well before tsc_init(), and even before tsc_early_init(). Simply delete the check, as it's been dead code since it was introduced. Note, odds are good the check_tsc_unstable() call was copied from Xen's xen_time_init()+xen_tsc_safe_clocksource() logic (as so much of KVM's PV code was). However, xen_time_init() runs via x86_init.timers.timer_init(), which is invoke from x86_late_time_init(), and thus after params have been parsed. Alternatively, kvmclock could register itself later on, or tsc_setup() could be parsed as an early param. Given that there's zero evidence there was any meaningful intent or need to actually check for an unstable TSC, go with the simplest option. Fixes: 7539b174aef4 ("x86: kvmguest: use TSC clocksource if invariant TSC is exposed") Link: https://lore.kernel.org/all/20260529181213.0B27A1F00893@smtp.kernel.org [*] Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 061a22d31dea..29ca37e9a3bc 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -362,8 +362,7 @@ void __init kvmclock_init(void) * */ if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC) && - boot_cpu_has(X86_FEATURE_NONSTOP_TSC) && - !check_tsc_unstable()) + boot_cpu_has(X86_FEATURE_NONSTOP_TSC)) kvm_clock.rating = 299; clocksource_register_hz(&kvm_clock, NSEC_PER_SEC); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350546.1608042 (Exim 4.92) (envelope-from ) id 1wf0h5-00029f-VQ; Wed, 01 Jul 2026 19:33:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350546.1608042; Wed, 01 Jul 2026 19:33:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0h5-00029V-Sj; Wed, 01 Jul 2026 19:33:59 +0000 Received: by outflank-mailman (input) for mailman id 1350546; Wed, 01 Jul 2026 19:33:57 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3ZmtFagYKCasdPLYUNRZZRWP.NZXiPY-OPgPWWTded.iPYacZUPNe.ZcR@flex--seanjc.bounces.google.com>) id 1wf0h3-00024S-P7 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:33:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0h3-004oBL-5t for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:33:57 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3ZmtFagYKCasdPLYUNRZZRWP.NZXiPY-OPgPWWTded.iPYacZUPNe.ZcR@flex--seanjc.bounces.google.com>) id 6a456b9c-2eae-0a2a0a5409dd-0a2a4509e6b8-10 for ; Wed, 01 Jul 2026 21:33:57 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3ZmtFagYKCasdPLYUNRZZRWP.NZXiPY-OPgPWWTded.iPYacZUPNe.ZcR@flex--seanjc.bounces.google.com>) id 6a456b67-97e6-0a2a45090019-d155d6cad1f5-3 for ; Wed, 01 Jul 2026 21:32:56 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c9b1b608e2so14564545ad.3 for ; Wed, 01 Jul 2026 12:32:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934375; x=1783539175; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=XQAPpCEE/BDkXN3dIWP18HQMEopEl3zLKZ2PUcc2V5o=; b=jJD3qt1qn8jrOaa+zPI23+YU6E5Ch1uvWC+U9lDfIxEqSklZd7D9q9F6kuofM9NR47 aaUHOLhQcG5vJHqLU9pPCb0QDmenV+S0HQtdKB4XSezidMRC4UcpCDQb3clabMEjlhxz o3jjT9/d8btZ9pAScMkpgK+g2yiHaTHAqCBBfZjMZ3iZVkI6hgwn0oqbEQtwuNLZU76w KH+1cv+3ZqNR5baOn7/OqMSs+WCqSoHMBm6Qo5FwRHdKxT8DbziVaEjLMZs5sghf6eiR heHt2SMc9E2S1E/N1rDXE+a9UR+3oQN9+/hFCALfPDV6OvdYNwxnMgOEla2qDP7wI7Ds JyVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934375; x=1783539175; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XQAPpCEE/BDkXN3dIWP18HQMEopEl3zLKZ2PUcc2V5o=; b=cS4iezeTRToYY+0red1zCSzUNFVNt6zMu3UVif4Pr0AZodpbHiEXUr0+TpCZ1QWNpm PuIegVGgDmAJhqpya1iRICm6eJ4Fu/clAjovzsJyPhWqz9rGlHhZhI7fFuax0FzB5WpG AdTHhTHFylcZXbbqJzkCE/5WuPPr9s483gnVuABbJBZVPBm+3AevwosSXhXPQsXviQPi T5o+v+wo9Pz4CeN/aS5Gb/rFiVB/0mFSmMv0zKvbjRg5NggN0eYEDTOsX5/Tb8Posd8a Y1yfpqyl5ODuFaHanwVyRADyrVbnmBHjGkPauXZDyfPOGinxZePJPwEE+mPEqIsGEQsX eR6w== X-Forwarded-Encrypted: i=1; AHgh+RqipQhwvE+c8CsMstcL5yNhNac64b1w7iolx/lh3cpFcw8FyHY351rBCGCxzJ+VoNcAIzDEmuZANhM=@lists.xenproject.org X-Gm-Message-State: AOJu0YzMPYBMlJlD76URF+ySm1mTUmA6rwUQ8Sydu7O40YbduI/kl+2a U4VFiqdt34s5lcGPAskmN0yQLE0HBE8btmaxkIqW6Rq0dSFakdP8gw53w/hOP/8Snrpe9GSRPZb EmrvO+w== X-Received: from plpl11.prod.google.com ([2002:a17:903:3dcb:b0:2b0:46bd:4fe5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ce02:b0:2ca:62e:cc4f with SMTP id d9443c01a7336-2ca7e7645d1mr34535395ad.23.1782934374801; Wed, 01 Jul 2026 12:32:54 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:44 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-24-seanjc@google.com> Subject: [PATCH v5 23/51] x86/tsc: Add standalone helper for getting CPU frequency from CPUID From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934377-55D90986-6A5EA88F/13/0 X-purgate-type: clean X-purgate-size: 2818 Extract the guts of cpu_khz_from_cpuid() to a standalone helper that doesn't restrict the usage to Intel CPUs. This will allow sharing the core logic with KVM-as-a-guest, as KVM generally doesn't restrict CPUID based on vendor. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/tsc.h | 1 + arch/x86/kernel/tsc.c | 31 +++++++++++++++---------------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h index c09ec485abcd..cb682f097ea7 100644 --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -88,6 +88,7 @@ struct cpuid_tsc_info { unsigned int crystal_khz; }; extern int cpuid_get_tsc_info(struct cpuid_tsc_info *info); +extern unsigned int __cpu_khz_from_cpuid(void); extern void tsc_early_init(void); extern void tsc_init(void); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 6ed6f8f012eb..56e73e96920a 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -668,6 +668,18 @@ int cpuid_get_tsc_info(struct cpuid_tsc_info *info) return 0; } +unsigned int __cpu_khz_from_cpuid(void) +{ + unsigned int eax_base_mhz, ebx, ecx, edx; + + if (boot_cpu_data.cpuid_level < CPUID_LEAF_FREQ) + return 0; + + cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx, &ecx, &edx); + + return eax_base_mhz * 1000; +} + /** * native_calibrate_tsc - determine TSC frequency * Determine TSC frequency via CPUID, else return 0. @@ -703,12 +715,8 @@ static unsigned long native_calibrate_tsc(void) * clock, but we can easily calculate it to a high degree of accuracy * by considering the crystal ratio and the CPU speed. */ - if (!info.crystal_khz && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) { - unsigned int eax_base_mhz, ebx, ecx, edx; - - cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx, &ecx, &edx); - info.crystal_khz = eax_base_mhz * 1000 * info.denominator / info.numerator; - } + if (!info.crystal_khz) + info.crystal_khz = __cpu_khz_from_cpuid() * info.denominator / info.numerator; if (!info.crystal_khz) return 0; @@ -733,19 +741,10 @@ static unsigned long native_calibrate_tsc(void) static unsigned long cpu_khz_from_cpuid(void) { - unsigned int eax_base_mhz, ebx_max_mhz, ecx_bus_mhz, edx; - if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) return 0; - if (boot_cpu_data.cpuid_level < CPUID_LEAF_FREQ) - return 0; - - eax_base_mhz = ebx_max_mhz = ecx_bus_mhz = edx = 0; - - cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx_max_mhz, &ecx_bus_mhz, &edx); - - return eax_base_mhz * 1000; + return __cpu_khz_from_cpuid(); } /* -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350548.1608051 (Exim 4.92) (envelope-from ) id 1wf0h7-0002Oj-Bs; Wed, 01 Jul 2026 19:34:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350548.1608051; Wed, 01 Jul 2026 19:34:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0h7-0002OX-7M; Wed, 01 Jul 2026 19:34:01 +0000 Received: by outflank-mailman (input) for mailman id 1350548; Wed, 01 Jul 2026 19:34:00 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3aGtFagYKCa0fRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 1wf0h6-00029t-6I for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0h5-003oMF-JB for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:33:59 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3aGtFagYKCa0fRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 6a456b9c-2eae-0a2a0a5409dd-0a2a4509e6b8-18 for ; Wed, 01 Jul 2026 21:33:59 +0200 Received: from [209.85.215.202] (helo=mail-pg1-f202.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3aGtFagYKCa0fRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 6a456b69-97e6-0a2a45090019-d155d7cab074-3 for ; Wed, 01 Jul 2026 21:32:59 +0200 Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c891ed872ddso919055a12.2 for ; Wed, 01 Jul 2026 12:32:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934377; x=1783539177; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=uJ3m/TrNbE4SFzRsHKX+8uSq+s8U3KdnfXDvnqXCgWk=; b=EqcKxy9LijNW5TOqgFn7ZLTojtCinJRrqyx2RWIR+TWzn5eGPRCcuYV2FiAfiaSJkU 4QEbq8yOzaQgwhIekJZ3uTBYEeuRL+BUuvNgRHUhGM+/e+OvAkz9SX14z7hCAvBW9o/a m9MPeZzOxJ8Elo3XbVEeU6YRc98ZZRZ5oNm3QkAZIfRgvhP2+oYaDwzNe54NY3Z3LE6P 3LdygURw7xJOADrNuWCL9aEf28t3xNCiMVO0/WGMdBHqEDez1vqqrgm3F2a8sSJRkqSy gEC8nya3OzLWaMlzPW9kfTFzL5xrk4soB4ImEBai/h4yGDqm8m5WLPnT21/PwceKd/9m fNyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934377; x=1783539177; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uJ3m/TrNbE4SFzRsHKX+8uSq+s8U3KdnfXDvnqXCgWk=; b=nsLYrAtvTk8WNj746MbeD4r5gGWNsMNtrU75LOAC/i2yuFwxAWCGtj7zu01FMA/y6Q k6Ir0CUugQ6wIWbQ+3Bz38ZOulRU3bafYhRI6GrxFujMg+eO04yL2jElsMszX7ELZFvV lIwJSyNz7ZxeQmzS93+cESrvgifitc+ggVeFQguImnhH00/OFX0FMV63AFgxVTvphWLG LvJlWDKQPm3TGOuGGHwwMS/H0M3mloQ38s1wLiUzzxK5jwP9yvwx8k6EPYV/Atzp8ltL OgARaPF6wklw+WpC69eDkOU/+6pVC+0Axib3hycGDx8SXjhxtibCM9/rTmH/eUpk2bT4 +TQA== X-Forwarded-Encrypted: i=1; AFNElJ8XAEnkk0NeaXIMpRoM+xlsGYnhKPnV2SavL6geqlW94hq2Yrf7X+OlQ4jZ3xjgmkCaKGZ28oVoV24=@lists.xenproject.org X-Gm-Message-State: AOJu0YxB3lr9HRy0e8cvZH7GzTM0gxuvjWvune9wZUo6iG5gW78knNX1 pLKdHWp7IrEbuEdL4UhbA1iUQ+bFKJ9y+bBTnUWJvAFeyQnOw2DQmcIlnTAtkgHzudoMS0uiN06 BDjVSIQ== X-Received: from pgwa12.prod.google.com ([2002:a65:654c:0:b0:c8a:eb2c:4d63]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:1b84:b0:398:9b42:69f7 with SMTP id adf61e73a8af0-3bfed3b19b0mr3537498637.39.1782934376998; Wed, 01 Jul 2026 12:32:56 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:46 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-26-seanjc@google.com> Subject: [PATCH v5 25/51] clocksource: hyper-v: Register sched_clock save/restore iff it's necessary From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934379-56B97986-478C3F8D/13/0 X-purgate-type: clean X-purgate-size: 6607 Register the Hyper-V reference counter (refcounter) callbacks for saving and restoring its PV sched_clock, if and only if the refcounter is actually being used for sched_clock. Currently, Hyper-V overrides the save/restore hooks if the reference TSC available, whereas the Hyper-V refcounter code only overrides sched_clock if the reference TSC is available *and* it's not invariant. The flaw is effectively papered over by invoking the "old" save/restore callbacks as part of save/restore, but that's unnecessary and fragile. To avoid introducing more complexity, and to allow for additional cleanups of the PV sched_clock code, move the save/restore hooks and logic into hyperv_timer.c and simply wire up the hooks when overriding sched_clock itself. Note, while the Hyper-V refcounter code is intended to be architecture neutral, CONFIG_PARAVIRT is firmly x86-only, i.e. adding a small amount of x86 specific code (which will be reduced in future cleanups) doesn't meaningfully pollute generic code. Reviewed-by: Michael Kelley Tested-by: Michael Kelley Acked-by: Wei Liu Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/mshyperv.c | 58 ------------------------------ drivers/clocksource/hyperv_timer.c | 50 ++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 58 deletions(-) diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index e03c69a4db33..c4da8e35319a 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -275,63 +275,6 @@ static void hv_guest_crash_shutdown(struct pt_regs *regs) } #endif /* CONFIG_CRASH_DUMP */ -static u64 hv_ref_counter_at_suspend; -static void (*old_save_sched_clock_state)(void); -static void (*old_restore_sched_clock_state)(void); - -/* - * Hyper-V clock counter resets during hibernation. Save and restore clock - * offset during suspend/resume, while also considering the time passed - * before suspend. This is to make sure that sched_clock using hv tsc page - * based clocksource, proceeds from where it left off during suspend and - * it shows correct time for the timestamps of kernel messages after resume. - */ -static void save_hv_clock_tsc_state(void) -{ - hv_ref_counter_at_suspend = hv_read_reference_counter(); -} - -static void restore_hv_clock_tsc_state(void) -{ - /* - * Adjust the offsets used by hv tsc clocksource to - * account for the time spent before hibernation. - * adjusted value = reference counter (time) at suspend - * - reference counter (time) now. - */ - hv_adj_sched_clock_offset(hv_ref_counter_at_suspend - hv_read_reference_counter()); -} - -/* - * Functions to override save_sched_clock_state and restore_sched_clock_state - * functions of x86_platform. The Hyper-V clock counter is reset during - * suspend-resume and the offset used to measure time needs to be - * corrected, post resume. - */ -static void hv_save_sched_clock_state(void) -{ - old_save_sched_clock_state(); - save_hv_clock_tsc_state(); -} - -static void hv_restore_sched_clock_state(void) -{ - restore_hv_clock_tsc_state(); - old_restore_sched_clock_state(); -} - -static void __init x86_setup_ops_for_tsc_pg_clock(void) -{ - if (!(ms_hyperv.features & HV_MSR_REFERENCE_TSC_AVAILABLE)) - return; - - old_save_sched_clock_state = x86_platform.save_sched_clock_state; - x86_platform.save_sched_clock_state = hv_save_sched_clock_state; - - old_restore_sched_clock_state = x86_platform.restore_sched_clock_state; - x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; -} - #ifdef CONFIG_X86_64 DEFINE_STATIC_CALL(hv_hypercall, hv_std_hypercall); EXPORT_STATIC_CALL_TRAMP_GPL(hv_hypercall); @@ -736,7 +679,6 @@ static void __init ms_hyperv_init_platform(void) /* Register Hyper-V specific clocksource */ hv_init_clocksource(); - x86_setup_ops_for_tsc_pg_clock(); hv_vtl_init_platform(); #endif /* diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index df567795d175..4293173c3a27 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -554,10 +554,60 @@ static __always_inline void hv_setup_sched_clock(void *sched_clock) #elif defined CONFIG_PARAVIRT #include +static u64 hv_ref_counter_at_suspend; +static void (*old_save_sched_clock_state)(void); +static void (*old_restore_sched_clock_state)(void); + +/* + * Hyper-V clock counter resets during hibernation. Save and restore clock + * offset during suspend/resume, while also considering the time passed + * before suspend. This is to make sure that sched_clock using hv tsc page + * based clocksource, proceeds from where it left off during suspend and + * it shows correct time for the timestamps of kernel messages after resume. + */ +static void save_hv_clock_tsc_state(void) +{ + hv_ref_counter_at_suspend = hv_read_reference_counter(); +} + +static void restore_hv_clock_tsc_state(void) +{ + /* + * Adjust the offsets used by hv tsc clocksource to + * account for the time spent before hibernation. + * adjusted value = reference counter (time) at suspend + * - reference counter (time) now. + */ + hv_adj_sched_clock_offset(hv_ref_counter_at_suspend - hv_read_reference_counter()); +} +/* + * Functions to override save_sched_clock_state and restore_sched_clock_state + * functions of x86_platform. The Hyper-V clock counter is reset during + * suspend-resume and the offset used to measure time needs to be + * corrected, post resume. + */ +static void hv_save_sched_clock_state(void) +{ + old_save_sched_clock_state(); + save_hv_clock_tsc_state(); +} + +static void hv_restore_sched_clock_state(void) +{ + restore_hv_clock_tsc_state(); + old_restore_sched_clock_state(); +} + static __always_inline void hv_setup_sched_clock(void *sched_clock) { /* We're on x86/x64 *and* using PV ops */ paravirt_set_sched_clock(sched_clock); + + old_save_sched_clock_state = x86_platform.save_sched_clock_state; + x86_platform.save_sched_clock_state = hv_save_sched_clock_state; + + old_restore_sched_clock_state = x86_platform.restore_sched_clock_state; + x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; } #else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */ static __always_inline void hv_setup_sched_clock(void *sched_clock) {} -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350549.1608060 (Exim 4.92) (envelope-from ) id 1wf0h8-0002eq-QP; Wed, 01 Jul 2026 19:34:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350549.1608060; Wed, 01 Jul 2026 19:34:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0h8-0002ej-MC; Wed, 01 Jul 2026 19:34:02 +0000 Received: by outflank-mailman (input) for mailman id 1350549; Wed, 01 Jul 2026 19:34:01 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3amtFagYKCa8hTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 1wf0h7-0002MV-4b for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0h6-003oMF-Hz for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:00 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3amtFagYKCa8hTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 6a456b8a-2eae-0a2a0a5409dd-0a2a4506ddcc-24 for ; Wed, 01 Jul 2026 21:34:00 +0200 Received: from [209.85.215.201] (helo=mail-pg1-f201.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3amtFagYKCa8hTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 6a456b6a-08de-0a2a45060019-d155d7c9c056-3 for ; Wed, 01 Jul 2026 21:33:00 +0200 Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c88ad1558f4so1256399a12.2 for ; Wed, 01 Jul 2026 12:32:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934378; x=1783539178; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=m4IxRx7fOhcWBmMrJhtIUc/shJhrGyqdre87YRmUR5M=; b=oTg6PAOC/FL6P0Upjw8OG+i0hWOQe8Eia4QqrupxR/mEFB6T6kGZ8IRaGwPIFwKYj6 8UCF4ZJFUWTZZXMbCVF8qnNqCIgkdYMSPFXNHAcnRkpOu1uDgNJottZqIGbF4ZdC0ZFd MrPF3T2siWeIjDF8rNKE+TB6/2OredC+ywVa2shfxM53U/utPGQJjlblpUn8697v1kjj 4HfBVG35L7xwO7xmOqA+FDmmJmqPHDNHbYrtm0ZNdMVu5OcH9cSCneHyOStzcbVM0qjc fc/vLOTWAAPR7uH5fj6fPDXe4qlT4An5tYnZMPJ+0NZ3qSr2z6YpJkeog1/NQ8HirvY/ sL6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934378; x=1783539178; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m4IxRx7fOhcWBmMrJhtIUc/shJhrGyqdre87YRmUR5M=; b=aVpfSRmBDciU6EXBDSOxr9wg+NebSDvukWgXoJwkC3i8X1gvUXQMndGwv2ssDpTg65 gyoTqWmGhrptP1sbI4x4gGFEX5io2SQME3XiGneJOUiqrtYZz7Ev354RGt840By5gyuw GwDnN1A3DVzBPdNw9gqgb4NUrVxiBtRzZsaOG1EO+LvZ5fxRcOZvn8TL/h6nZ0S6m7Z5 ZQA5+1Mw03BucKnVfI64jyHbzym8hkYNmrfOdd8wxjvtwv7g7H3bp0N/HaNksqSHREsp rSWOqDbU5q5SYUAzO2JqARj0Uduh1NtK9jOm+GcJf0Voixbx4dwTSQL0GXwaQMR4NAsW DjWQ== X-Forwarded-Encrypted: i=1; AFNElJ+8SWoT77RS7zoiOmHl9gLOoesJlm0K5RDpGzkYmAoF362d+JbVXntSXytLW7XP1apwHsrhZd6itV4=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxtzj6ksoubWSesilwJR5pXUb1XAWymfsqjW6rVKRLUFx9HOZOs /NCTDqIO1cmFqjVaz9LlvGZsYe7KryOW3H7W70ei5VdhRlUkcENp/5hpVZWpuaJuS3MmiBLXlbu KtQEcpg== X-Received: from pgbda6.prod.google.com ([2002:a05:6a02:2386:b0:c99:7baf:126d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:6b01:b0:3b4:931c:3c7c with SMTP id adf61e73a8af0-3bfed50b68fmr3305567637.44.1782934378058; Wed, 01 Jul 2026 12:32:58 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:47 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-27-seanjc@google.com> Subject: [PATCH v5 26/51] clocksource: hyper-v: Drop wrappers to sched_clock save/restore helpers From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934380-C7D2D68D-25AF23C0/13/0 X-purgate-type: clean X-purgate-size: 3436 Now that all of the Hyper-V reference counter sched_clock code is located in a single file, drop the superfluous wrappers for the save/restore flows. No functional change intended. Reviewed-by: Michael Kelley Tested-by: Michael Kelley Acked-by: Wei Liu Signed-off-by: Sean Christopherson --- drivers/clocksource/hyperv_timer.c | 34 +++++------------------------- include/clocksource/hyperv_timer.h | 2 -- 2 files changed, 5 insertions(+), 31 deletions(-) diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index 4293173c3a27..daa8cbfe61ee 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -488,17 +488,6 @@ static void resume_hv_clock_tsc(struct clocksource *arg) hv_set_msr(HV_MSR_REFERENCE_TSC, tsc_msr.as_uint64); } -/* - * Called during resume from hibernation, from overridden - * x86_platform.restore_sched_clock_state routine. This is to adjust offsets - * used to calculate time for hv tsc page based sched_clock, to account for - * time spent before hibernation. - */ -void hv_adj_sched_clock_offset(u64 offset) -{ - hv_sched_clock_offset -= offset; -} - #ifdef HAVE_VDSO_CLOCKMODE_HVCLOCK static int hv_cs_enable(struct clocksource *cs) { @@ -565,12 +554,14 @@ static void (*old_restore_sched_clock_state)(void); * based clocksource, proceeds from where it left off during suspend and * it shows correct time for the timestamps of kernel messages after resume. */ -static void save_hv_clock_tsc_state(void) +static void hv_save_sched_clock_state(void) { + old_save_sched_clock_state(); + hv_ref_counter_at_suspend = hv_read_reference_counter(); } -static void restore_hv_clock_tsc_state(void) +static void hv_restore_sched_clock_state(void) { /* * Adjust the offsets used by hv tsc clocksource to @@ -578,23 +569,8 @@ static void restore_hv_clock_tsc_state(void) * adjusted value = reference counter (time) at suspend * - reference counter (time) now. */ - hv_adj_sched_clock_offset(hv_ref_counter_at_suspend - hv_read_reference_counter()); -} -/* - * Functions to override save_sched_clock_state and restore_sched_clock_state - * functions of x86_platform. The Hyper-V clock counter is reset during - * suspend-resume and the offset used to measure time needs to be - * corrected, post resume. - */ -static void hv_save_sched_clock_state(void) -{ - old_save_sched_clock_state(); - save_hv_clock_tsc_state(); -} + hv_sched_clock_offset -= (hv_ref_counter_at_suspend - hv_read_reference_counter()); -static void hv_restore_sched_clock_state(void) -{ - restore_hv_clock_tsc_state(); old_restore_sched_clock_state(); } diff --git a/include/clocksource/hyperv_timer.h b/include/clocksource/hyperv_timer.h index d48dd4176fd3..a4c81a60f53d 100644 --- a/include/clocksource/hyperv_timer.h +++ b/include/clocksource/hyperv_timer.h @@ -38,8 +38,6 @@ extern void hv_remap_tsc_clocksource(void); extern unsigned long hv_get_tsc_pfn(void); extern struct ms_hyperv_tsc_page *hv_get_tsc_page(void); -extern void hv_adj_sched_clock_offset(u64 offset); - static __always_inline bool hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page *tsc_pg, u64 *cur_tsc, u64 *time) -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350551.1608068 (Exim 4.92) (envelope-from ) id 1wf0hA-0002uw-46; Wed, 01 Jul 2026 19:34:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350551.1608068; Wed, 01 Jul 2026 19:34:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0h9-0002tl-W7; Wed, 01 Jul 2026 19:34:03 +0000 Received: by outflank-mailman (input) for mailman id 1350551; Wed, 01 Jul 2026 19:34:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3a2tFagYKCbAiUQdZSWeeWbU.SecnUd-TUlUbbYiji.nUdfheZUSj.ehW@flex--seanjc.bounces.google.com>) id 1wf0h8-0002Y4-54 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0h7-00B44A-IH for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:01 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3a2tFagYKCbAiUQdZSWeeWbU.SecnUd-TUlUbbYiji.nUdfheZUSj.ehW@flex--seanjc.bounces.google.com>) id 6a456b9b-5cb7-0a2a0a5109dd-0a2a450ad372-32 for ; Wed, 01 Jul 2026 21:34:01 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3a2tFagYKCbAiUQdZSWeeWbU.SecnUd-TUlUbbYiji.nUdfheZUSj.ehW@flex--seanjc.bounces.google.com>) id 6a456b6c-e40e-0a2a450a0019-d155d6caed15-3 for ; Wed, 01 Jul 2026 21:33:01 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c6a20348ceso13515645ad.1 for ; Wed, 01 Jul 2026 12:33:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934379; x=1783539179; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=D8RMEeRf8IO60ymrjMFeZrqFOqn/98Ma8JhKdrpIeKM=; b=TMNivoOfhimJCECmLDLcAOqwk2S7M8O0behC/qBKtXSqXv7ysQc3mfbhAojGDc5rO7 4iMgQkBHinu+GNDXJGf6hSwe45qGOID5CKQlscgk4AaDqlaQ6cOrtRkOflN37DX85RSU mL1Xy7fiRBi/Y7NE7aZtofm5QxWRSmmQ/E7b5f4+g4BJ9/ScbW88igyuvEjp0oEvRqDu L5WyVvZMnBcwpmT4NGyU/xUyYa1N/qW3mLN/XAwJO9tKQNCsNhR3Df8liWtxtwpVMv4S PKMdqKSRq+uhcbCyHaRPQPkKPXiBv68dHqAf1UZJ1pribvuZKldSmLBVcZA7JHtnMRF/ m3xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934379; x=1783539179; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=D8RMEeRf8IO60ymrjMFeZrqFOqn/98Ma8JhKdrpIeKM=; b=ZTmxfRsLy0gWTeUvlvGOx1OW9M/ntIxQ8cZfUfrb0SBhU0CYhVRHAjhlorc016xl6D 5EHqjHoctjKOC5GPhN3XZzMOSYhQzPTiZJGTgtHFD7GCS6WgFgA3m9piJld7Yp6hXh+4 nkkmMkQWJOQK2H/e/kFrpgzD4ryysQaGuZzlyKcGDPyBLBvZaqftGs4AAUA6U7m2ZHii Hqx3DzVQI1/GONXBsL8g2dB8jEwyWYkLS9Z1LwKDXaFuIGyDc7okkjK6UvawaSwH8RLu 5bemxdIvcnT/YVj5PURaIlabahO1g9JivU14gS04w5gixiK8Z5NiI+KXHBKSfsDyDuWL HHfg== X-Forwarded-Encrypted: i=1; AHgh+RplLpkp15SioDmyGN/vkaHFGQWEJ6HNtLrfO/9vLn8qwLhPg60jkcmrEAkDRneUQYgBq8TBi+Wbnh0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxiO9od9iNAKoy/gyyudX3xeveCmAdkZU86T1PFRhavpUhLHI4m X73eafca4DSJS8YoY0JgMAmgd/7qqvG7de1a4BOh8JZqJb5Do0YOABj4DNnx6lbgm36++Hs96+N X9RiU2Q== X-Received: from plkp8.prod.google.com ([2002:a17:902:6b88:b0:2c7:ebed:f6e8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3ba4:b0:2c1:ee75:56bb with SMTP id d9443c01a7336-2ca9117aa06mr20678475ad.20.1782934379169; Wed, 01 Jul 2026 12:32:59 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:48 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-28-seanjc@google.com> Subject: [PATCH v5 27/51] clocksource: hyper-v: Don't save/restore TSC offset when using HV sched_clock From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1782934381-3C07ADDE-E9F45FBF/13/0 X-purgate-type: clean X-purgate-size: 2767 Now that Hyper-V overrides the sched_clock save/restore hooks if and only sched_clock itself is set to the Hyper-V reference counter, drop the invocation of the "old" save/restore callbacks. When the registration of the PV sched_clock was done separately from overriding the save/restore hooks, it was possible for Hyper-V to clobber the TSC save/restore callbacks without actually switching to the Hyper-V refcounter. Enabling a PV sched_clock is a one-way street, i.e. the kernel will never revert to using TSC for sched_clock, and so there is no need to invoke the TSC save/restore hooks (and if there was, it belongs in common PV code). Reviewed-by: Michael Kelley Tested-by: Michael Kelley Reviewed-by: David Woodhouse Acked-by: Wei Liu Signed-off-by: Sean Christopherson --- drivers/clocksource/hyperv_timer.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index daa8cbfe61ee..220668207d19 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -544,9 +544,6 @@ static __always_inline void hv_setup_sched_clock(void *sched_clock) #include static u64 hv_ref_counter_at_suspend; -static void (*old_save_sched_clock_state)(void); -static void (*old_restore_sched_clock_state)(void); - /* * Hyper-V clock counter resets during hibernation. Save and restore clock * offset during suspend/resume, while also considering the time passed @@ -556,8 +553,6 @@ static void (*old_restore_sched_clock_state)(void); */ static void hv_save_sched_clock_state(void) { - old_save_sched_clock_state(); - hv_ref_counter_at_suspend = hv_read_reference_counter(); } @@ -570,8 +565,6 @@ static void hv_restore_sched_clock_state(void) * - reference counter (time) now. */ hv_sched_clock_offset -= (hv_ref_counter_at_suspend - hv_read_reference_counter()); - - old_restore_sched_clock_state(); } static __always_inline void hv_setup_sched_clock(void *sched_clock) @@ -579,10 +572,7 @@ static __always_inline void hv_setup_sched_clock(void *sched_clock) /* We're on x86/x64 *and* using PV ops */ paravirt_set_sched_clock(sched_clock); - old_save_sched_clock_state = x86_platform.save_sched_clock_state; x86_platform.save_sched_clock_state = hv_save_sched_clock_state; - - old_restore_sched_clock_state = x86_platform.restore_sched_clock_state; x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; } #else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */ -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350553.1608079 (Exim 4.92) (envelope-from ) id 1wf0hB-0003Ai-F4; Wed, 01 Jul 2026 19:34:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350553.1608079; Wed, 01 Jul 2026 19:34:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0hB-0003AY-AC; Wed, 01 Jul 2026 19:34:05 +0000 Received: by outflank-mailman (input) for mailman id 1350553; Wed, 01 Jul 2026 19:34:03 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3bGtFagYKCbEjVReaTXffXcV.TfdoVe-UVmVccZjkj.oVegifaVTk.fiX@flex--seanjc.bounces.google.com>) id 1wf0h9-0002qQ-RC for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0h9-00BqNS-7n for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:03 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3bGtFagYKCbEjVReaTXffXcV.TfdoVe-UVmVccZjkj.oVegifaVTk.fiX@flex--seanjc.bounces.google.com>) id 6a456b8d-bab6-0a2a0a5309dd-0a2a450b89ee-26 for ; Wed, 01 Jul 2026 21:34:03 +0200 Received: from [209.85.214.201] (helo=mail-pl1-f201.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3bGtFagYKCbEjVReaTXffXcV.TfdoVe-UVmVccZjkj.oVegifaVTk.fiX@flex--seanjc.bounces.google.com>) id 6a456b6d-ac48-0a2a450b0019-d155d6c9d195-3 for ; Wed, 01 Jul 2026 21:33:02 +0200 Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2c9b1b608e2so14566935ad.3 for ; Wed, 01 Jul 2026 12:33:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934381; x=1783539181; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=IHAlzrllQ2SIWnv0fCfBsaTBNv7ymljQujJZvblLIYE=; b=AzWY3OVNP78CtrQ1weYyrQkWHNF2kdCX/dbIZYAddU0sCq7xvy0glzsszuj8qaLiS9 bYXxOfNTGccLoze3wU7SSua/ZpDk/kUHusvWujSw7BewLd/VW1+vmQ2Nt7Bti/31UjZX Qyarxg3lfsxdz/d7YoilWSRNQRCtNf6JnEBEdGKx2YxeVPSmQGmdUWZziSA1fWyXCQJP iK7OBe2NoSD0SLYKe4JFWcbN7C08/ulon0ZrIcOzGMTVYo04gOg7ix/VeH+3QCCvdbyq /CtMkROfVC1/olmOdzCaDj3CbStmAr+7cgmFHCIDr5HKwG96a0dUn3uvLmxo47BLfJXs 7gdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934381; x=1783539181; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IHAlzrllQ2SIWnv0fCfBsaTBNv7ymljQujJZvblLIYE=; b=UMqRtpm8WrmxsC3lvv6k98GzK45gm7/h7bMDj3XBaVrolaHMDx7HXy0+l/h5naTTa/ 6LyWMrzpoNQFLPa0CwAypq9cBw2FIYTChLhT6jHuENwxb43Znk7UhaSN6vvuEpSh7N54 5QTcnlZot+bAKvcvLZwlUIx5TqUJG/hgRcoEeS0MqauSoXG09Rqee8kaZpjt1OJDTN+i 9qr8xeQP2JIGBnU8IePXbC+6XTmUyG0k+YvZcRAMad9SoP6NIP4nQntL0EsmuEohgSU7 1a9G27eQThhfPzPAaHP9jpOEbKlDVfwM5pCRe2+LqMGXvSX87VPlqUqLZtEjd5Ix213j svBw== X-Forwarded-Encrypted: i=1; AHgh+RrnR/GoumYciHhx/RIv13WvSBcBUPrCqsAOuR/R4b4Wy0CGEQ9+oPGD0CErPQWxtquREH0TbE1akdo=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxa8G+2KWgdM9VRVFFxOOqCp74XnyQE4ZH88PMcszbtWAVHIznu WLgSkNK2qEPYHQ6jECify4aDY3gX4sm3ZWddLfvP5LpXKj6HaGitu8iDtGTjXfwrz766sD/qbFM yzOF1pQ== X-Received: from plblk15.prod.google.com ([2002:a17:903:8cf:b0:2c7:f338:5690]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:41c7:b0:2ca:de3:15e2 with SMTP id d9443c01a7336-2ca7e561189mr31594705ad.0.1782934380474; Wed, 01 Jul 2026 12:33:00 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:49 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-29-seanjc@google.com> Subject: [PATCH v5 28/51] x86/kvmclock: Setup kvmclock for secondary CPUs iff CONFIG_SMP=y From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-42698a/1782934382-3814E220-7C5918BB/13/0 X-purgate-type: clean X-purgate-size: 1442 Gate kvmclock's secondary CPU code on CONFIG_SMP, not CONFIG_X86_LOCAL_APIC. Originally, kvmclock piggybacked PV APIC ops to setup secondary CPUs. When that wart was fixed by commit df156f90a0f9 ("x86: Introduce x86_cpuinit.early_percpu_clock_init hook"), the dependency on a local APIC got carried forward unnecessarily. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 2e7ab54cb9dc..b0c871ba8232 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -208,7 +208,7 @@ static void kvm_restore_sched_clock_state(void) kvm_register_clock("primary cpu clock, resume"); } -#ifdef CONFIG_X86_LOCAL_APIC +#ifdef CONFIG_SMP static void kvm_setup_secondary_clock(void) { kvm_register_clock("secondary cpu clock"); @@ -348,7 +348,7 @@ void __init kvmclock_init(bool prefer_tsc) x86_init.hyper.get_cpu_khz = kvmclock_get_tsc_khz; x86_platform.get_wallclock = kvm_get_wallclock; x86_platform.set_wallclock = kvm_set_wallclock; -#ifdef CONFIG_X86_LOCAL_APIC +#ifdef CONFIG_SMP x86_cpuinit.early_percpu_clock_init = kvm_setup_secondary_clock; #endif x86_platform.save_sched_clock_state = kvm_save_sched_clock_state; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350557.1608087 (Exim 4.92) (envelope-from ) id 1wf0hE-0003Y0-MZ; Wed, 01 Jul 2026 19:34:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350557.1608087; Wed, 01 Jul 2026 19:34:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0hE-0003Xq-IM; Wed, 01 Jul 2026 19:34:08 +0000 Received: by outflank-mailman (input) for mailman id 1350557; Wed, 01 Jul 2026 19:34:07 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3cGtFagYKCbUnZVieXbjjbgZ.XjhsZi-YZqZggdnon.sZikmjeZXo.jmb@flex--seanjc.bounces.google.com>) id 1wf0hD-0003ST-9u for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0hC-003oMF-N4 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:06 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3cGtFagYKCbUnZVieXbjjbgZ.XjhsZi-YZqZggdnon.sZikmjeZXo.jmb@flex--seanjc.bounces.google.com>) id 6a456b8a-2eae-0a2a0a5409dd-0a2a4506ddcc-30 for ; Wed, 01 Jul 2026 21:34:06 +0200 Received: from [209.85.214.201] (helo=mail-pl1-f201.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3cGtFagYKCbUnZVieXbjjbgZ.XjhsZi-YZqZggdnon.sZikmjeZXo.jmb@flex--seanjc.bounces.google.com>) id 6a456b71-08de-0a2a45060019-d155d6c9e039-3 for ; Wed, 01 Jul 2026 21:33:06 +0200 Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2c9e9cb6a44so8480265ad.2 for ; Wed, 01 Jul 2026 12:33:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934384; x=1783539184; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=FLdcwKjpeRYfRUJ5L0VC2fjzpWNaPddOoI275jwJM8U=; b=LpaxJwt01QnGB9s/FJttE5dmx825dvyOlzYnjhqm7jCNYW5a6JqneWgmIhY6lIs+mw En9N/ho0rTu1mCeoLIh6EVe81vK9ZP0BAFHhhnyfJm+QuBCBmUL9+e8PkklvzmUH5Ado OnAP2KcuxKkAwF5WYx4aLSvL24/fHepkF+YMTIwWi3snl8fxSu2qSgaIhfcG9RATNZq8 7GkjOwKe523lGqG8FbceEGTjrF9uL65tlldyLQd4wESF5twQB28KT9l5ptAoDKrfG7K1 mCLdlOY2H1waicOx519ewlvk5xHWtt/O3hKkk02CLKbXmY6z9ww+L5YYX2hSEVGjPJ9K yIVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934384; x=1783539184; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FLdcwKjpeRYfRUJ5L0VC2fjzpWNaPddOoI275jwJM8U=; b=Ma3K6fZ6NDJdxinc7WMywPMdeSvTxfdqtsBpokX/vNojCf1RtDR6rTz2lJ1WVnwEwS iaqM5hjFwNhjaLCD7WGMgi617X12Owj6KZDBXSb7BrvO1owBvfEVvRbXUIQxoCFCMSuR V5wBIX0IyVtu2fY+nMg/mMF/y1Fa771cyEnTpNJ4gOzpzHcoNZXE00tsdfm+AnUYQ126 t3l2IW9VoaYEx6bp4mBg1PBhZ0vx8EkUs+fT1fk1DtHuPmzKPISdFSe2aDNuQOJvvWOq phH+3RZQCkP+r+ozpAdIwlQq9bkbS4U36F2/tS0MenzFHBWUrHiVzdgHNYpQ4Adsn5yD 8g+Q== X-Forwarded-Encrypted: i=1; AHgh+Rqk52QtUw7XaYbupYmTvkiBzg7oWdr+10ToXR1SviLJBMTUsPodKZXtHPByVVwWLG2oPZDpADy0aXA=@lists.xenproject.org X-Gm-Message-State: AOJu0YxeRis6UYlxY1J3g4SL/qULo0lsEf+CZpW6rU5r2J0nUvlNpzqW 8wRzDLRlYEZ2JJT8vmBb3HqCJrUNv0N520nMYaA6bEqrgb7lmOb193ARuiEbQrNOCCIOb0IbG/N A69+KLg== X-Received: from plsq11.prod.google.com ([2002:a17:902:bd8b:b0:2c9:dc0d:6834]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f551:b0:2bf:7b62:a038 with SMTP id d9443c01a7336-2ca9112b126mr20357335ad.9.1782934384220; Wed, 01 Jul 2026 12:33:04 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:51 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-31-seanjc@google.com> Subject: [PATCH v5 30/51] x86/paravirt: Remove unnecessary PARAVIRT=n stub for paravirt_set_sched_clock() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934386-C732668D-EC08C5D9/13/0 X-purgate-type: clean X-purgate-size: 1574 Remove the unnecessary paravirt_set_sched_clock() stub for PARAVIRT=n, as all callers are gated by PARAVIRT=y. Eliminating the stub will avoid a pile of pointless churn as the "real" implementation evolves. No functional change intended. Fixes: 39965afb1151 ("x86/paravirt: Move paravirt_sched_clock() related code into tsc.c") Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 3 +++ arch/x86/kernel/tsc.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index fda18bcb19b4..c71b466d6ace 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -12,7 +12,10 @@ extern void recalibrate_cpu_khz(void); extern int no_timer_check; extern bool using_native_sched_clock(void); + +#ifdef CONFIG_PARAVIRT void paravirt_set_sched_clock(u64 (*func)(void)); +#endif /* * We use the full linear equation: f(x) = a + b*x, in order to allow diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 56e73e96920a..375b0279df66 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -288,7 +288,6 @@ void paravirt_set_sched_clock(u64 (*func)(void)) u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); bool using_native_sched_clock(void) { return true; } -void paravirt_set_sched_clock(u64 (*func)(void)) { } #endif notrace u64 sched_clock(void) -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350559.1608096 (Exim 4.92) (envelope-from ) id 1wf0hG-0003qx-Bs; Wed, 01 Jul 2026 19:34:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350559.1608096; Wed, 01 Jul 2026 19:34:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0hG-0003po-5l; Wed, 01 Jul 2026 19:34:10 +0000 Received: by outflank-mailman (input) for mailman id 1350559; Wed, 01 Jul 2026 19:34:08 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3cWtFagYKCbYoaWjfYckkcha.Ykitaj-Zarahheopo.tajlnkfaYp.knc@flex--seanjc.bounces.google.com>) id 1wf0hE-0003WA-GG for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0hD-00BqTu-TS for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:07 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3cWtFagYKCbYoaWjfYckkcha.Ykitaj-Zarahheopo.tajlnkfaYp.knc@flex--seanjc.bounces.google.com>) id 6a456b8d-bab6-0a2a0a5309dd-0a2a450b89ee-34 for ; Wed, 01 Jul 2026 21:34:07 +0200 Received: from [209.85.214.201] (helo=mail-pl1-f201.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3cWtFagYKCbYoaWjfYckkcha.Ykitaj-Zarahheopo.tajlnkfaYp.knc@flex--seanjc.bounces.google.com>) id 6a456b72-ac48-0a2a450b0019-d155d6c9e4d6-3 for ; Wed, 01 Jul 2026 21:33:07 +0200 Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2c81c7421abso19964455ad.0 for ; Wed, 01 Jul 2026 12:33:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934386; x=1783539186; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=E6ig/L0f6Bi8iYQ5fSK4jpuHUho56x4PQqpcZJJeUg4=; b=k6si1nXEP9jsax29d2Ai1DzSnZ1UEnEv9lA0DySdekTMnbxH3lXtKcN94ls48mbuwp dDT37+rzjj8M0AD4U7S08OPDZfkQ6YFjvd7WV4hmMy3Y+8JSFlVqFqJ6kjgq0ysdvWP0 bjxZvCIDZC066TP7K//HtwE3eJXerHg24iFc+FJr4LZqAGncglB9OCYuzPHZ/VCHYlpE nkVMQOzEN/no9grl31LFMTLf8y+20LMJVWLWuTaJ8rppIL8iWg1VnP/SXh3WiclDUGaf eaXL9jA/uGJvMHJVx3aaoNtKL5DWdMWNwTMHOSG9hxddsqaA6tClbOTqh00FRuXqfxrZ H19g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934386; x=1783539186; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E6ig/L0f6Bi8iYQ5fSK4jpuHUho56x4PQqpcZJJeUg4=; b=ZKrnDZp9gV724NqNspv2N0UAwSZhL/sVDmpFBNnSANh+1dG39d/sHKtBsBQER7rkhH PZZ6OoA6RI6luS1qjflDa5GnwJ7j90ARY3eM3JsVmpBQzF9hO41Yl7y99A/QL4FhlSxD l4B+RCtkobOtEsuJJg8JfeASxZAsxIG/Gbutak8z1u1fVawVHhNo0CItuqDnUoBFtToM M4TZXSeM2jV9bYYqldYk40il4ssftnxI2UBBi6bq7yrHLj3ybheAE+CGTWj6dk8waxES o3FgNH1Xd5sz+kyLnetnEJfsPMUKEiGE3/qWpalUiejyGYW5VMdorixDdahj5T+pWMSL oW+A== X-Forwarded-Encrypted: i=1; AHgh+RrquGFB+Q8e3cM9oVqB7+W4o1xIsNRRuO7KPEUEgP2ztQTS9+d8EXWZ7Lh2Lmes3tsf1aB6z+TRz5w=@lists.xenproject.org X-Gm-Message-State: AOJu0YymyOF5vXAivBOmblT5dMuWvbUQwo4j+izQs4jVYxpUlHVvKvQn JNhpK/1UEpaWbRIBybkapQiEDwtQQWCm4bPuezKsGRADILwCCiZest5A83RibYCzwHvos2KvCDM 1BIcTWg== X-Received: from plbmt13.prod.google.com ([2002:a17:903:b0d:b0:2c6:b7bd:4804]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1acb:b0:2c9:c54a:7915 with SMTP id d9443c01a7336-2ca91140306mr23508775ad.14.1782934385462; Wed, 01 Jul 2026 12:33:05 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:52 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-32-seanjc@google.com> Subject: [PATCH v5 31/51] x86/paravirt: Move handling of unstable PV clocks into paravirt_set_sched_clock() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-42698a/1782934387-A6B38220-66DF81F0/13/0 X-purgate-type: clean X-purgate-size: 2573 Move the handling of unstable PV clocks, of which kvmclock is the only example, into paravirt_set_sched_clock(). This will allow modifying paravirt_set_sched_clock() to keep using the TSC for sched_clock in certain scenarios without unintentionally marking the TSC-based clock as unstable. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 7 ++++++- arch/x86/kernel/kvmclock.c | 5 +---- arch/x86/kernel/tsc.c | 5 ++++- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index c71b466d6ace..fe41d40a9ae6 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,7 +14,12 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void paravirt_set_sched_clock(u64 (*func)(void)); +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable); + +static inline void paravirt_set_sched_clock(u64 (*func)(void)) +{ + __paravirt_set_sched_clock(func, true); +} #endif /* diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index a3ec298d56d7..4bc0495f1f9e 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -115,10 +114,8 @@ static noinstr u64 kvm_sched_clock_read(void) static inline void kvm_sched_clock_init(bool stable) { - if (!stable) - clear_sched_clock_stable(); kvm_sched_clock_offset = kvm_clock_read(); - paravirt_set_sched_clock(kvm_sched_clock_read); + __paravirt_set_sched_clock(kvm_sched_clock_read, stable); pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 375b0279df66..a762cb5cec0f 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,8 +280,11 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void paravirt_set_sched_clock(u64 (*func)(void)) +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable) { + if (!stable) + clear_sched_clock_stable(); + static_call_update(pv_sched_clock, func); } #else -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350582.1608104 (Exim 4.92) (envelope-from ) id 1wf0hR-0004wl-PM; Wed, 01 Jul 2026 19:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350582.1608104; Wed, 01 Jul 2026 19:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0hR-0004wE-L4; Wed, 01 Jul 2026 19:34:21 +0000 Received: by outflank-mailman (input) for mailman id 1350582; Wed, 01 Jul 2026 19:34:21 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3fmtFagYKCcM1njwslpxxpun.lxv6nw-mn4nuur121.6nwy0xsnl2.x0p@flex--seanjc.bounces.google.com>) id 1wf0hR-0004tu-79 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0hQ-003oMF-Jj for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:20 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3fmtFagYKCcM1njwslpxxpun.lxv6nw-mn4nuur121.6nwy0xsnl2.x0p@flex--seanjc.bounces.google.com>) id 6a456b8a-2eae-0a2a0a5409dd-0a2a4506ddcc-40 for ; Wed, 01 Jul 2026 21:34:20 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3fmtFagYKCcM1njwslpxxpun.lxv6nw-mn4nuur121.6nwy0xsnl2.x0p@flex--seanjc.bounces.google.com>) id 6a456b7f-08de-0a2a45060019-d155d6cadd4e-3 for ; Wed, 01 Jul 2026 21:33:20 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c8284701c2so12109495ad.1 for ; Wed, 01 Jul 2026 12:33:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934398; x=1783539198; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=E0Ky72UXh2AIoPVqIZkO5elKJbkXgXhRlg1eH2WcetI=; b=GFyGpFcTx6NJOCSfhaCac676LFfEbVdEv79OwSkQ2jclux4tFeJxL6d3KzgbMyRsjd 49bqjq9n+xk2O7dzT0el3Ms1dsvq9Eaj/3wE78OPVH8M74nHYDfCF6rKTvBsERWj1Tqx pW3ao0CApqyFTeIMh9y3+4U5KgZ3oIXu37n3gPEXCxGFaXyP9+UuP73XbkonS24hT1O6 +PbmjtTJo/kFgqDBt4PImShS+LfnGF7HccQSCbOtvD3lmEtPvBBHT0WR7pzqA7P0CuAr QyyVj+rAlg7Av2os5MvmWEFuHg//aYeeJUFCLwla2q0idtBmh6DruMQSAY+4Di/OlCmN DrLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934398; x=1783539198; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E0Ky72UXh2AIoPVqIZkO5elKJbkXgXhRlg1eH2WcetI=; b=rGwPa1leg52sdn3/t0fIsf73bSJ0h3c0n/lr9Cu3/vpy1zEPGlbdtkyDv7tLviV53O PMghVcWeCk2GBXtA40GrdZTUXVaB0yPA9VVU7tpRT0Say1g5A6Rs94Uhtk1JSbIOOLgK renkl7iiUEsGDsBNRyOmPDuqMz9V9o/Xme9F64I4t76JOwsfvGrfSglhIqxjpp6C3I1Z Hk29ZlKL1f+Ne2RBqmniPfHsKq5nvOlWuNl6YG/ctgzDuOfySiOlm4iq8g7qtrl9W/Pu TnR6cxPqPptmk8xNd9TqsqqJURJgNNH1aiwfsuDd2pZ7NdpCYnlJEB6drgoorDkkPi+J Mi5A== X-Forwarded-Encrypted: i=1; AHgh+RpJOViCMPufv0+d3RkhHqSLkHfZIqJsVD4tjqKLnb3HC5O85ebUvxSYIWL+GOvC8CVsm3EydRTJjsM=@lists.xenproject.org X-Gm-Message-State: AOJu0YwkcTVCLzod+8wLbTn9S7xWo5dUdBRBoQEnrnYCDsDn4p6HWPZ7 ulDwhP/tOPKOHUOIHiqieSRITajGyxaYJSc1UunEHbzWodhsfzrBc8dKxg38ghcH1iNFnD7FvUc H2UOdew== X-Received: from pleu6.prod.google.com ([2002:a17:903:41c6:b0:2c8:5a:8056]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3885:b0:2ca:17a8:cfce with SMTP id d9443c01a7336-2ca911d341fmr20775345ad.29.1782934398119; Wed, 01 Jul 2026 12:33:18 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:03 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-43-seanjc@google.com> Subject: [PATCH v5 42/51] timekeeping: Resume clocksources before reading persistent clock From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934400-F9B9068D-CC4BD5CC/13/0 X-purgate-type: clean X-purgate-size: 1671 When resuming timekeeping after suspend, restore clocksources prior to reading the persistent clock. Paravirt clocks, e.g. kvmclock, tie the validity of a PV persistent clock to a clocksource, i.e. reading the PV persistent clock will return garbage if the underlying PV clocksource hasn't been enabled. The flaw has gone unnoticed because kvmclock is a mess and uses its own suspend/resume hooks instead of the clocksource suspend/resume hooks, which happens to work by sheer dumb luck (the kvmclock resume hook runs before timekeeping_resume()). Note, there is no evidence that any clocksource supported by the kernel depends on a persistent clock. Reviewed-by: Thomas Gleixner Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- kernel/time/timekeeping.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index b1b5ec43c0f2..5bc77d36c7a3 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -2180,11 +2180,16 @@ void timekeeping_resume(void) u64 cycle_now, nsec; unsigned long flags; - read_persistent_clock64(&ts_new); - clockevents_resume(); clocksource_resume(); + /* + * Read persistent time after clocksources have been resumed. Paravirt + * clocks have a nasty habit of piggybacking a persistent clock on a + * system clock, and may return garbage if the system clock is suspended. + */ + read_persistent_clock64(&ts_new); + raw_spin_lock_irqsave(&tk_core.lock, flags); /* -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350588.1608114 (Exim 4.92) (envelope-from ) id 1wf0hW-0005O6-0q; Wed, 01 Jul 2026 19:34:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350588.1608114; Wed, 01 Jul 2026 19:34:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0hV-0005Ns-Ts; Wed, 01 Jul 2026 19:34:25 +0000 Received: by outflank-mailman (input) for mailman id 1350588; Wed, 01 Jul 2026 19:34:24 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3gWtFagYKCcY4qmzvos00sxq.o0y9qz-pq7qxxu454.9qz130vqo5.03s@flex--seanjc.bounces.google.com>) id 1wf0hU-0005JX-Kx for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0hU-00BwNp-1w for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:24 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3gWtFagYKCcY4qmzvos00sxq.o0y9qz-pq7qxxu454.9qz130vqo5.03s@flex--seanjc.bounces.google.com>) id 6a456bbb-5cb7-0a2a0a5109dd-0a2a4501a4e0-4 for ; Wed, 01 Jul 2026 21:34:24 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3gWtFagYKCcY4qmzvos00sxq.o0y9qz-pq7qxxu454.9qz130vqo5.03s@flex--seanjc.bounces.google.com>) id 6a456b82-400f-0a2a45010019-d155d6cad0e4-3 for ; Wed, 01 Jul 2026 21:33:23 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2ca1f16e391so11756865ad.2 for ; Wed, 01 Jul 2026 12:33:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934402; x=1783539202; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=Z1gCn97n2OaQgcF7BGVq6zaJwKJkpkAfWBIFdTpXq3s=; b=pozOzSJLoc5jVrymvIlGZ+a248PS57+TW0DwhxsQ5STxQbqd4tT4FxlPteDgj+UsIp 1NEffh7bxJXwKUqdnwW0NUfs6Z2Xm1da4GBFEcVDkZGlxAFJxXpBlroYnHK25OdeTX+q B/3OwwGsrQ+g4Q92kU0CENdHECh7lxpO6vKfMBwiezeL+dFxtKjgfdBz5caJi2fKACdA gCRezNyCyZhTOjwO1JdxHYedzrnlQ5AhBjMthGLk+ogYgsZVRHTFfvy8Mw/o66Kzecqx p71JkKEQ85B62Y1pAeX3BOB+p28Plv2gwKGVQjcKuppcOTZB2vNSA55QLlp+F22NIv5u Vowg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934402; x=1783539202; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z1gCn97n2OaQgcF7BGVq6zaJwKJkpkAfWBIFdTpXq3s=; b=fTpfrTH5RSN7Lw0FdZBascD4SAmD4583+ubd2PsnXai/G5iWtpmyAO5y+6f6IIkuZx PNy2LAJhMqCUsN242Q2KVZn6NiFOZx7YOdtJpGhk3ZoKFLZRgEQE7lhB4rmZufIpSMQ5 bRFeR8RquQfJ7XE28UOuvIobSU1eOSXtpu0sbbSgJ9eUZaDOsQfYrHXruNueMnZpMmT2 hjZqtSAtiySB16teLSOGC5qNeKuG23xomFvp494akbs6/GJew4DRpXT5x3rxrHU19x4d QAIBuvUw3g9zg53xlXU2i2XoJUqcesNNRzy1Om5Mb4mjQbEBtCgmjfFBvnljuusolXzg Ql1w== X-Forwarded-Encrypted: i=1; AHgh+Rr8+QKdUHd0H9rL8UY8A51AIL0RGqscgQW3iTb5+tsgY0AL+uidI5fUiWaDIoc4M/PN15NB5sz09Y8=@lists.xenproject.org X-Gm-Message-State: AOJu0YwpDyqqjIuFoayMGI0m13Vi6zEVZQ+pEt8cxfhA9C12o3Fbrwq8 b0mmGB9uTOhu2cYJ4jxc6N8IQ0EAtIux0kZiKX4IAXI670NGMAU3JeLcuLraMoClPqdZhIOMH2K Qiqb5QQ== X-Received: from plgo7.prod.google.com ([2002:a17:902:d4c7:b0:2c0:b770:dcd7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1245:b0:2c9:fd62:a709 with SMTP id d9443c01a7336-2ca7e6838d3mr33515195ad.10.1782934401463; Wed, 01 Jul 2026 12:33:21 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:06 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-46-seanjc@google.com> Subject: [PATCH v5 45/51] x86/paravirt: Mark __paravirt_set_sched_clock() as __init From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1782934403-D26C61E0-E0A81572/13/0 X-purgate-type: clean X-purgate-size: 2072 Annotate __paravirt_set_sched_clock() as __init, and make its wrapper __always_inline to ensure sanitizers don't result in a non-inline version hanging around. All callers run during __init, and changing sched_clock after boot would be all kinds of crazy. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 10 +++++----- arch/x86/kernel/tsc.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index e97cd1ae03d1..96ae7feac47c 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,12 +14,12 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)); +void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)); -static inline void paravirt_set_sched_clock(u64 (*func)(void), - void (*save)(void), - void (*restore)(void)) +static __always_inline void paravirt_set_sched_clock(u64 (*func)(void), + void (*save)(void), + void (*restore)(void)) { __paravirt_set_sched_clock(func, true, save, restore); } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 83353d643150..0f92b29adecc 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,8 +280,8 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)) +void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)) { if (!stable) clear_sched_clock_stable(); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350590.1608123 (Exim 4.92) (envelope-from ) id 1wf0hY-0005mf-9e; Wed, 01 Jul 2026 19:34:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350590.1608123; Wed, 01 Jul 2026 19:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0hY-0005mU-5E; Wed, 01 Jul 2026 19:34:28 +0000 Received: by outflank-mailman (input) for mailman id 1350590; Wed, 01 Jul 2026 19:34:26 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3g2tFagYKCcg6so1xqu22uzs.q20Bs1-rs9szzw676.Bs1352xsq7.25u@flex--seanjc.bounces.google.com>) id 1wf0hW-0005aj-UO for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0hW-00BqTu-BP for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:26 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3g2tFagYKCcg6so1xqu22uzs.q20Bs1-rs9szzw676.Bs1352xsq7.25u@flex--seanjc.bounces.google.com>) id 6a456bb3-bab6-0a2a0a5309dd-0a2a45098636-18 for ; Wed, 01 Jul 2026 21:34:26 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3g2tFagYKCcg6so1xqu22uzs.q20Bs1-rs9szzw676.Bs1352xsq7.25u@flex--seanjc.bounces.google.com>) id 6a456b84-97e6-0a2a45090019-d155d6cacdc6-3 for ; Wed, 01 Jul 2026 21:33:26 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2ca3b3141a6so13440615ad.1 for ; Wed, 01 Jul 2026 12:33:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934404; x=1783539204; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=KILxImADtcVlkoacCtqYmxEGcZEGxD9ytdtd9JfAHyU=; b=ncRycgCj5OPlbhp+ae2uH2ajcL9c9iwIOIwLxgbN3tnrXCBjsFksgkDjy/gneFlbag o2hsOMCxFo38XVzjhixcCVKfoICFrRVH7xcpJ6e8xdMiC6848r0O3W8fBOxIrFjF0bTI lnbj9brXTP1UeE1ThWI3nYTjrj0JWMS9NLeVzJHfxw9gC6R531Q9MEtbmmXfjcQ0Sw/9 Z8TkLabQjzAMg1wLmhlydWWIVuUOW4q6IM+ZpxWk2G+M7nABgRxg1NfImqZxtceS+hMw 631qfCSHDIpaG7MJm44QvxcfRnaL5VPKB2rHhzWNxFZIQzWktxxFB8iZ5b8s2fZWVOy5 DM1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934404; x=1783539204; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KILxImADtcVlkoacCtqYmxEGcZEGxD9ytdtd9JfAHyU=; b=aEwfw/nznqYlzYLTadi5NaF/TioDylMwM0W9zK/N0n1QiA29K5GbJVi8tFBSqQm/16 Xc0qoTHcs2lCcne8Rel6VX7iLWwVGkvny3ix53tIBIWsSOs1SEIl1kxoRWvtNzadtBBj bZkjYrovdKo9LqKxEbHd4I+FYUezdn9l4wa6MP25XEtIITy2OSwsJotK2caauOP89nLP 2xCO2yKcgaADBn1enLTFkBkb5teQ3+6A9tr7aXlNY9TlVBOPzHPudXl0VRHak3YdL9Cb vrOASLWPWiQk6chUzExPanKc8wUENTWRMJ30zJbc5chP6YSX7UsUXLuYAMdk3dX9QXJN lW4Q== X-Forwarded-Encrypted: i=1; AHgh+Rr/UVqL+sLYIdYEsfK4XzMrv5nafd266eaI/tpHs5eg5EdBZaKT+H2BGu8ojLIX1DnNwRwR9TeD/5s=@lists.xenproject.org X-Gm-Message-State: AOJu0YyomWv/aFH4qOQCW9JSJbRHe3+IOs77zlpYsMCeuxY9aArn07X1 8EOlOvzO/EBk7Gm+l/rKi8rV9iWvE/IlJP6v0107Xi213DYxqZRvCqwiOMLLQXlH838JalCEdye FHePRag== X-Received: from pltf1.prod.google.com ([2002:a17:902:74c1:b0:2c7:5af7:37a3]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:c952:b0:2c9:c169:7483 with SMTP id d9443c01a7336-2ca7e87dc6bmr34187285ad.37.1782934403691; Wed, 01 Jul 2026 12:33:23 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:08 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-48-seanjc@google.com> Subject: [PATCH v5 47/51] x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934406-5519A986-4C00B53B/13/0 X-purgate-type: clean X-purgate-size: 1339 Silently ignore attempts to switch to a paravirt sched_clock when running as a CoCo guest with trusted TSC. In hand-wavy theory, a misbehaving hypervisor could attack the guest by manipulating the PV clock to affect guest scheduling in some weird and/or predictable way. More importantly, reading TSC on such platforms is faster than any PV clock, and sched_clock is all about speed. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 012321fed5e5..a146fc7b5e74 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -283,6 +283,15 @@ bool using_native_sched_clock(void) int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, void (*save)(void), void (*restore)(void)) { + /* + * Don't replace TSC with a PV clock when running as a CoCo guest and + * the TSC is secure/trusted; PV clocks are emulated by the hypervisor, + * which isn't in the guest's TCB. + */ + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC) || + boot_cpu_has(X86_FEATURE_TDX_GUEST)) + return -EPERM; + if (!stable) clear_sched_clock_stable(); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350602.1608132 (Exim 4.92) (envelope-from ) id 1wf0ha-0006DJ-Q7; Wed, 01 Jul 2026 19:34:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350602.1608132; Wed, 01 Jul 2026 19:34:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0ha-0006Bo-LT; Wed, 01 Jul 2026 19:34:30 +0000 Received: by outflank-mailman (input) for mailman id 1350602; Wed, 01 Jul 2026 19:34:29 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3hWtFagYKCco8uq3zsw44w1u.s42Du3-tuBu11y898.Du3574zus9.47w@flex--seanjc.bounces.google.com>) id 1wf0hZ-0005zw-1S for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0hY-00BqTu-EQ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:28 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3hWtFagYKCco8uq3zsw44w1u.s42Du3-tuBu11y898.Du3574zus9.47w@flex--seanjc.bounces.google.com>) id 6a456bbe-bab6-0a2a0a5309dd-0a2a45079ec8-2 for ; Wed, 01 Jul 2026 21:34:28 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3hWtFagYKCco8uq3zsw44w1u.s42Du3-tuBu11y898.Du3574zus9.47w@flex--seanjc.bounces.google.com>) id 6a456b86-9c8e-0a2a45070019-d155d6cacda5-3 for ; Wed, 01 Jul 2026 21:33:28 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2ca3b3141a6so13441585ad.1 for ; Wed, 01 Jul 2026 12:33:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934406; x=1783539206; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=TVQraC4E63kxSjnR08hIOoNSz/X8YqL1FfZb6Oo6qbM=; b=kbNroxJS4oquznaG/Cm/xwshcv9E29EvJpRNbSNN46mx0UiJIvmsq9HfN61p5wzTt2 w9WeJ+u7pMFTYtG1RXDS8Uo+f3e5f1ajMKaztSFokOSjYbpLhCSdZcJoomuEv667NhRb OIvfeoMWkEP5JaoNs8G6nki6RnKPnpK3bAsUdPYRUC3+siGgbr9RBvTGzldGYL09i9TP DWUDPI8LCnLvqnRIfYDIe0EibRbfG3P2OXivBZU4E7+8Ycrp7kfWtJzSndw9VI+Cm0D1 fuIK2ERG2W2M+3n7RffSx5dNPv/WCKM8Xq10QYY9W7nk1+BWp9xPFveDAvwcFx26vVpx 8AfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934406; x=1783539206; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TVQraC4E63kxSjnR08hIOoNSz/X8YqL1FfZb6Oo6qbM=; b=pEeCVBg0lBo1givmMVOV/FSxpI+nnTsQo9oOPjqLTNID1H3hXifpL/6q/OLb2Ej71l oBAjPnTtoqASGPhEuctkSbuSfAQZEbMM77Ga9kR/pdP3Xx4q+yZAZAYFbQsD37LcCoFs zEAvlMPEfiXzc4yQ9YXVRWySVEXtlULV/dHBh14zp/ToweyOYymnrgN54BkXonaokvC1 jq1qerF7jQTonkdIsKS7UrDZGgkY6jIOMD0n0muRQacXgDWWms2tEx1+OQZpFBT2hGGm CFKoPSz0HBV4VMnVAB3cyt0xeVY1qessgyktQyUE/GS/1PC8P/eehYJGy+anUnQXRPWR eqMA== X-Forwarded-Encrypted: i=1; AHgh+Rr/HCTnhXLQg226/ahJEF5EZa7yGhmm7y8nOBEdkYO/ATcLPmjc4dM6nOLQx0onfKriiM6fuypWI+M=@lists.xenproject.org X-Gm-Message-State: AOJu0YyjssMBu1Ob+Ung3XmZXUZjX+FEWbZeJb4e5vOSeoUOE6+kUgek 5oPvcnZ2XPB9GBfvxDKtreiUVwGTkCRr554dihaDmomcQ7coQ7CjILeVOQMyjAH28ndwJ+OIMUp pNijOLQ== X-Received: from plkg7.prod.google.com ([2002:a17:903:19c7:b0:2c6:a4ed:efee]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:c94c:b0:2c9:c97e:71cf with SMTP id d9443c01a7336-2ca7e683909mr35659695ad.6.1782934405912; Wed, 01 Jul 2026 12:33:25 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:10 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-50-seanjc@google.com> Subject: [PATCH v5 49/51] x86/kvmclock: Plumb in AP-online and BSP-resume to kvmlock, for documentation From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1782934408-7F33F25E-79D991A1/13/0 X-purgate-type: clean X-purgate-size: 4593 Invoke kvmclock_cpu_action() with AP_ONLINE and BSP_RESUME, even though kvmclock doesn't need to do anything in either case, so that the asymmetry of kvmclock is a detail buried in kvmclock, and to explicitly document that doing nothing during those phases is intentional and correct. For all intents and purposes, no functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_para.h | 2 ++ arch/x86/kernel/kvm.c | 22 +++++++++++++------- arch/x86/kernel/kvmclock.c | 37 ++++++++++++++++++++++++++------- 3 files changed, 45 insertions(+), 16 deletions(-) diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h index 08686ff19caa..763ed017738a 100644 --- a/arch/x86/include/asm/kvm_para.h +++ b/arch/x86/include/asm/kvm_para.h @@ -120,6 +120,8 @@ static inline long kvm_sev_hypercall3(unsigned int nr, unsigned long p1, #ifdef CONFIG_KVM_GUEST enum kvm_guest_cpu_action { KVM_GUEST_BSP_SUSPEND, + KVM_GUEST_BSP_RESUME, + KVM_GUEST_AP_ONLINE, KVM_GUEST_AP_OFFLINE, KVM_GUEST_SHUTDOWN, }; diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 604b52f233aa..f9a6346077b0 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -474,18 +474,24 @@ static void kvm_guest_cpu_offline(enum kvm_guest_cpu_action action) kvmclock_cpu_action(action); } +static void __kvm_cpu_online(unsigned int cpu, enum kvm_guest_cpu_action action) +{ + unsigned long flags; + + local_irq_save(flags); + kvmclock_cpu_action(action); + kvm_guest_cpu_init(); + local_irq_restore(flags); +} + +#ifdef CONFIG_SMP + static int kvm_cpu_online(unsigned int cpu) { - unsigned long flags; - - local_irq_save(flags); - kvm_guest_cpu_init(); - local_irq_restore(flags); + __kvm_cpu_online(cpu, KVM_GUEST_AP_ONLINE); return 0; } -#ifdef CONFIG_SMP - static DEFINE_PER_CPU(cpumask_var_t, __pv_cpu_mask); static bool pv_tlb_flush_supported(void) @@ -750,7 +756,7 @@ static int kvm_suspend(void *data) static void kvm_resume(void *data) { - kvm_cpu_online(raw_smp_processor_id()); + __kvm_cpu_online(raw_smp_processor_id(), KVM_GUEST_BSP_RESUME); #ifdef CONFIG_ARCH_CPUIDLE_HALTPOLL if (kvm_para_has_feature(KVM_FEATURE_POLL_CONTROL) && has_guest_poll) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index bc98ebb8587d..842f38c5f6ca 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -150,7 +150,7 @@ static void kvm_save_sched_clock_state(void) #ifdef CONFIG_SMP static void kvm_setup_secondary_clock(void) { - kvm_register_clock("secondary cpu clock"); + kvm_register_clock("secondary cpu, startup"); } #endif @@ -174,13 +174,34 @@ static void kvmclock_resume(struct clocksource *cs) void kvmclock_cpu_action(enum kvm_guest_cpu_action action) { - /* - * Don't disable kvmclock on the BSP during suspend. If kvmclock is - * being used for sched_clock, then it needs to be kept alive until the - * last minute, and restored as quickly as possible after resume. - */ - if (action != KVM_GUEST_BSP_SUSPEND) + switch (action) { + /* + * The BSP's clock is managed via clocksource suspend/resume, + * to ensure it's enabled/disabled when timekeeping needs it + * to be, e.g. before reading wallclock (which uses kvmclock). + */ + case KVM_GUEST_BSP_SUSPEND: + case KVM_GUEST_BSP_RESUME: + break; + case KVM_GUEST_AP_ONLINE: + /* + * Secondary CPUs use a dedicated hook to enable kvmclock early + * during bringup, there's nothing to be done during CPU online + * (which runs at CPUHP_AP_ONLINE_DYN). When kvmclock is being + * used as sched_clock, kvmclock must be enabled *very* early, + * and even when kvmclock is "only" being used for the main + * clocksource, it still needs to be enabled long before the + * dynamic CPUHP calls are made. + */ + break; + case KVM_GUEST_AP_OFFLINE: + case KVM_GUEST_SHUTDOWN: kvmclock_disable(); + break; + default: + WARN_ON_ONCE(1); + break; + } } /* @@ -382,7 +403,7 @@ void __init kvmclock_init(bool prefer_tsc) msr_kvm_system_time, msr_kvm_wall_clock); this_cpu_write(hv_clock_per_cpu, &hv_clock_boot[0]); - kvm_register_clock("primary cpu clock"); + kvm_register_clock("primary cpu, online"); pvclock_set_pvti_cpu0_va(hv_clock_boot); if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT)) { -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:34:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:34:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350605.1608141 (Exim 4.92) (envelope-from ) id 1wf0hc-0006SN-25; Wed, 01 Jul 2026 19:34:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350605.1608141; Wed, 01 Jul 2026 19:34:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0hb-0006SC-Up; Wed, 01 Jul 2026 19:34:31 +0000 Received: by outflank-mailman (input) for mailman id 1350605; Wed, 01 Jul 2026 19:34:31 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3iGtFagYKCc0Bxt62vz77z4x.v75Gx6-wxEx441BCB.Gx68A72xvC.7Az@flex--seanjc.bounces.google.com>) id 1wf0hb-0006GX-7D for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:34:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0ha-00BqTu-KD for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:34:30 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3iGtFagYKCc0Bxt62vz77z4x.v75Gx6-wxEx441BCB.Gx68A72xvC.7Az@flex--seanjc.bounces.google.com>) id 6a456bb3-bab6-0a2a0a5309dd-0a2a45098636-22 for ; Wed, 01 Jul 2026 21:34:30 +0200 Received: from [209.85.215.202] (helo=mail-pg1-f202.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3iGtFagYKCc0Bxt62vz77z4x.v75Gx6-wxEx441BCB.Gx68A72xvC.7Az@flex--seanjc.bounces.google.com>) id 6a456b89-97e6-0a2a45090019-d155d7cab537-3 for ; Wed, 01 Jul 2026 21:33:30 +0200 Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c9d5a5b63c5so883487a12.1 for ; Wed, 01 Jul 2026 12:33:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934408; x=1783539208; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=ukYnz5D3jEol4z1WUeRHDVtFiLPopAappLYurzMw/rI=; b=fai+YAy4/7XjQOg3T8VNf8nCwAkpKElDiQdCM9h3UBYGCGvjbht5/BdJjeFGt5ysz7 vLMS3DAE+EGnvGfMDBlPXTQxld0qa0u6BH1I1arGeiu0r2r/NYtI/gFcG7mXE9XOnpSa lqrZUMDdR4HVILaEcjZqpKgNy6h/w4OZSRehvzLK23wDu3rBVAqvKd1r2X9KndCJF6/y NA5/cvl/hiXdt2DaY3D+JADpMA+FNH6xJUud8G4b2JU6MBbA/Ah56kAiNGh6HnZMqmMb RZi8ymrgF97UCOYLkwg8mLYJig0tyT/5Cs6W3XWTrn2PE14inMcFDXJtChXZBRV6a4b/ A1iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934408; x=1783539208; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ukYnz5D3jEol4z1WUeRHDVtFiLPopAappLYurzMw/rI=; b=Hl0RSSTB3URgFDmsQtWequubqha1EK+6xHg+AknTLEK9g6L+iAz0FtzLoJtB2/OI83 jWBt7DjRHABICIQV8/YSiwwZXdoordc4okBVHikEebdgHBcesKgBojKj/1QqQFFKGuTl tdSSEr950RT9pDKjVPwWgDOqQEl2ZFywSGAk7F5dSuznTUbjKgdzCE7HLG/3tMJ3Qsi7 FFNzn8D/f71MOJNHCQCuX5XCRr6he8KM5gxuzjflgGh1q7UxJYvqCUE3kn10o6A1BHfB b2thaPVTd7aD5N03CLmdG/y0J5lsZDyBp/7sdL9Ok6Pzg5vA8kkT/9U0rZH0zadXl3fe bOgg== X-Forwarded-Encrypted: i=1; AFNElJ8YGL7eepovLa53nGRecguAEe17BztJFT3tteTX1yDuh4g6qeOoDzlUjGbRXv9l8KE7B6kBDaJnDNo=@lists.xenproject.org X-Gm-Message-State: AOJu0YyV/fAM+w31TVEFAhJRlbWNJQiLP0QY3JJsxSi1WtCrwptfExE+ AV/3muG3qRwPw55ChrwPkr+QLvmFiTMlaa6TQc3rkoOHp/Aa+mO/TDY7uMrzhBhdod9h3BrYD3H sKOdP6g== X-Received: from pgad26.prod.google.com ([2002:a05:6a02:4f5a:b0:c99:d21a:f6b7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:748b:b0:3bf:d1f9:b1db with SMTP id adf61e73a8af0-3bfed5e1001mr3530009637.52.1782934408107; Wed, 01 Jul 2026 12:33:28 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:12 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-52-seanjc@google.com> Subject: [PATCH v5 51/51] x86/kvm: Get local APIC bus frequency from PV CPUID Timing Info From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934410-46327986-871ED5DB/13/0 X-purgate-type: clean X-purgate-size: 1407 When running as a KVM guest with PV timing info provided by the host, stuff the APIC timer period/frequency with the local APIC bus frequency reported in CPUID.0x40000010.EBX instead of trying to calibrate/guess the frequency. See Documentation/virt/kvm/x86/cpuid.rst for details. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index f9a6346077b0..beea0b6aa78e 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -990,7 +990,7 @@ static void __init kvm_init_platform(void) .mask_lo = (u32)(~(SZ_4G - tolud - 1)) | MTRR_PHYSMASK_V, .mask_hi = (BIT_ULL(boot_cpu_data.x86_phys_bits) - 1) >> 32, }; - u32 timing_info_leaf; + u32 timing_info_leaf, apic_khz; bool tsc_is_reliable; if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) && @@ -1052,6 +1052,11 @@ static void __init kvm_init_platform(void) x86_init.hyper.get_tsc_khz = kvm_get_tsc_khz; x86_init.hyper.get_cpu_khz = kvm_get_tsc_khz; } + + /* The leaf also includes the local APIC bus/timer frequency.*/ + apic_khz = cpuid_ebx(timing_info_leaf); + if (apic_khz) + apic_set_timer_period_khz(apic_khz, "KVM hypervisor"); } /* -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350651.1608150 (Exim 4.92) (envelope-from ) id 1wf0iF-0007yl-BT; Wed, 01 Jul 2026 19:35:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350651.1608150; Wed, 01 Jul 2026 19:35:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iF-0007yc-8n; Wed, 01 Jul 2026 19:35:11 +0000 Received: by outflank-mailman (input) for mailman id 1350651; Wed, 01 Jul 2026 19:35:10 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3c2tFagYKCbgqcYlhaemmejc.amkvcl-bctcjjgqrq.vclnpmhcar.mpe@flex--seanjc.bounces.google.com>) id 1wf0iE-0007yG-Mf for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iE-00BwWE-3I for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:10 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3c2tFagYKCbgqcYlhaemmejc.amkvcl-bctcjjgqrq.vclnpmhcar.mpe@flex--seanjc.bounces.google.com>) id 6a456be5-5cb7-0a2a0a5109dd-0a2a4509a272-8 for ; Wed, 01 Jul 2026 21:35:10 +0200 Received: from [209.85.210.202] (helo=mail-pf1-f202.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3c2tFagYKCbgqcYlhaemmejc.amkvcl-bctcjjgqrq.vclnpmhcar.mpe@flex--seanjc.bounces.google.com>) id 6a456b74-97e6-0a2a45090019-d155d2cae192-3 for ; Wed, 01 Jul 2026 21:33:09 +0200 Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-8423f544944so787918b3a.3 for ; Wed, 01 Jul 2026 12:33:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934388; x=1783539188; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=qFfbhUmYyCU6tRW/uev50JnnPJRuq59CtmTnO4qaTps=; b=AxzzU/WWBFxM1ih4hQFfuPffcBmt54/E4Kri07Z6dfJKSxnSX+PHuSwRkaGbNDkoe+ d582W/KvOKR4aBCwT0fXAySLmEgSilaZx6pXyZBUBFGthUTmPVIQQb+X7tWsd1B7Wpuk wcTi+rD1R2ZgAAOzcujS6adKUVZc9GRRTQ8rDbmaRFapTcNi73hthu58AY9HLVjSg/YF eXb+luqEa0sBliPLHhY6tcamIWAcEJnCwV8cnt4MiIInlIM0Kkuy+Zf4DF30Co/73E1v RxwwLNaqDwP6QSwHlpm2FFIu0tfGJMIcSPIoxCsJNt/cNW8Or0Bke6UXs1fKlrjozu0W hpGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934388; x=1783539188; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qFfbhUmYyCU6tRW/uev50JnnPJRuq59CtmTnO4qaTps=; b=ZbklHBViHJf7CrpuJhfV26iz2sGbSIL9N4VOG4qtdNVDkDESp0xfTiYMu5zKCJmdfT 6uAczrwWFdGUoLPw+Zun8WPROnLSVfcionVqO65QlcFNXMoisah0snJIGx78Nr6pm2ey e3EYriSyEsN6jIWRDSfEvQcg0j4GLH0LdAUIIiQEnoAHK/aEjdgn8aKQPbpmL1XlHneh sc/xC6bYoj+4zcQOK4Mth0jXExe1DSmCX9UxUFRy9DSrGkY59a5Q8eMDUFwtbdQ5QpEz JaKAAoTJ8/keaf0dTN3jOdAW1QJUZnKY2+2pri4lLqMdK6eL5mrsR4YYoliUeainMYGa WYew== X-Forwarded-Encrypted: i=1; AFNElJ9BBYIMutAaDQPt5oDZFqvKAKCfpX/JVjs9zn7/qSrH3VvaYV8uMR/2VVMpiPi5qw2QLxNXJ6D8xjk=@lists.xenproject.org X-Gm-Message-State: AOJu0YybiqK6h1ASpIcR0VBRfL8fzqCpAjmi94GDKBaWUnnbllmZhH3Q nWRxAQkEAoarPKVoznk8z+/EjjrQnQg0Ks0jOI45OUbVSXvwb5M51JoMZWr0eOCY92EswNi+McD +lntN2g== X-Received: from pfvx7.prod.google.com ([2002:a05:6a00:2707:b0:847:8f34:1b76]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:8f0a:b0:847:86d8:5937 with SMTP id d2e1a72fcca58-847c51e4a35mr1955201b3a.50.1782934387701; Wed, 01 Jul 2026 12:33:07 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:54 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-34-seanjc@google.com> Subject: [PATCH v5 33/51] x86/xen/time: NOP-ify x86_platform's sched_clock save/restore hooks From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934390-46739986-C55DB5E4/13/0 X-purgate-type: clean X-purgate-size: 1157 NOP-ify the x86_platform sched_clock save/restore hooks when setting up Xen's PV clock to make it somewhat obvious the hooks aren't used when running as a Xen guest (Xen uses a paravirtualized suspend/resume flow). Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/xen/time.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 487ad838c441..477441752f40 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -567,6 +567,12 @@ static void __init xen_init_time_common(void) xen_sched_clock_offset = xen_clocksource_read(); static_call_update(pv_steal_clock, xen_steal_clock); paravirt_set_sched_clock(xen_sched_clock); + /* + * Xen has paravirtualized suspend/resume and so doesn't use the common + * x86 sched_clock save/restore hooks. + */ + x86_platform.save_sched_clock_state = x86_init_noop; + x86_platform.restore_sched_clock_state = x86_init_noop; x86_init.hyper.get_tsc_khz = xen_tsc_khz; x86_platform.get_wallclock = xen_get_wallclock; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350652.1608159 (Exim 4.92) (envelope-from ) id 1wf0iH-0008DK-JB; Wed, 01 Jul 2026 19:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350652.1608159; Wed, 01 Jul 2026 19:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iH-0008D6-GF; Wed, 01 Jul 2026 19:35:13 +0000 Received: by outflank-mailman (input) for mailman id 1350652; Wed, 01 Jul 2026 19:35:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3dGtFagYKCbkrdZmibfnnfkd.bnlwdm-cdudkkhrsr.wdmoqnidbs.nqf@flex--seanjc.bounces.google.com>) id 1wf0iG-000852-7J for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iF-003oQR-9c for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:11 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3dGtFagYKCbkrdZmibfnnfkd.bnlwdm-cdudkkhrsr.wdmoqnidbs.nqf@flex--seanjc.bounces.google.com>) id 6a456bbc-2eae-0a2a0a5409dd-0a2a450aa144-36 for ; Wed, 01 Jul 2026 21:35:11 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3dGtFagYKCbkrdZmibfnnfkd.bnlwdm-cdudkkhrsr.wdmoqnidbs.nqf@flex--seanjc.bounces.google.com>) id 6a456b75-e40e-0a2a450a0019-d155d6cac1a5-3 for ; Wed, 01 Jul 2026 21:33:10 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c7cfa17fe6so22393605ad.3 for ; Wed, 01 Jul 2026 12:33:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934389; x=1783539189; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=Vvd9sO5KFA4UCvVy/DPb0p6l2OFovCFuh6GrZNkoHew=; b=rUW7+yPq06Rfq50laibByGCSRLoDu4D+V1JdWI1Xom3I5MCiPrF7SoS7xKDu5oSAg7 Og51WatP2oTdd6MGmQc3dJYfUA3Kb1IXbYXmiGmxjDhK3xyQNmn8lx0jPlr8vy39jG6U t0S9xF0RZcHAT04hMjiKvJLSGls16OVqVEOu3IiMf89HgPGqYzE/q4Xu58Vp+l3aa0mN 4Ysm2ffoQCZyZ89hh9lvrzc7Moqt/8LCiABHquzMnmQ/v1Ao1eDKrX7iUVYeuuI7RdQJ cCZntdhi534BHDMOtr/nvbqR+FJdmG2svOWlOISOhz+rckpUE0MQMckPvl8Qc1/mGjVo nrJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934389; x=1783539189; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vvd9sO5KFA4UCvVy/DPb0p6l2OFovCFuh6GrZNkoHew=; b=jjOKiEV5nX9oY6SFr88X7X1dUp1+ikoUEXQFcMp9uC9wdNBCnqLuoVttfu9qFvTX6l gRRj26a/QYED1V6uvejNoOWTCnRgMkv8Ait8v9XoSZkJ8BLAdjj8OFWgcWSYb28OydQc 7sFup02+EkSZN9pUraDRdKaJw5Er0qUQwQg6L6uJJsbRdOFVaCvvQkjbihWww6Zeoi0a tLluppF6eMWv4mmIDbVDiQKiltF0xzbLNE1QoyIuepVJyPDv1HM5dPqC0dh8vNaiNbDn OFvkeu3k2N1F8tjLAB84nWel/O5tXs+jQhg03D/yfk3fBHG/F5z3jfVl5yhrz45g7Xqu N7cw== X-Forwarded-Encrypted: i=1; AFNElJ/XdURVaByPF805H7kvNMDjghfhvxs65LHN+hTg57fZVUthHyiISwxy0/cXQ4IaC2crzmxdS4SmM9o=@lists.xenproject.org X-Gm-Message-State: AOJu0YzNAxJ+rzmDS3fJ4ePsUTiPiu2S3rHkw591TI+9+IZl3X9rlP3R DXovz1VmqlInnoauLuOJdwpW2+mpnJBp2m82nTJrkFxMeXSws3Rmvm0DD5fjvRTJXlt74lhUtRC GtgBbKg== X-Received: from plho13.prod.google.com ([2002:a17:903:23cd:b0:2bf:1274:c8f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:41c7:b0:2c9:c46b:129b with SMTP id d9443c01a7336-2ca7e67c028mr32017335ad.5.1782934388785; Wed, 01 Jul 2026 12:33:08 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:55 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-35-seanjc@google.com> Subject: [PATCH v5 34/51] x86/vmware: NOP-ify save/restore hooks when using VMware's sched_clock From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1782934391-3DA71DDE-5ECD9829/13/0 X-purgate-type: clean X-purgate-size: 1267 NOP-ify the sched_clock save/restore hooks when using VMware's version of sched_clock. This will allow extending paravirt_set_sched_clock() to set the save/restore hooks, without having to simultaneously change the behavior of VMware guests. Note, it's not at all obvious that it's safe/correct for VMware guests to do nothing on suspend/resume, but that's a pre-existing problem. Leave it for a VMware expert to sort out. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/vmware.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 0a3bd90576d4..5c1ccaf4a25e 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -347,8 +347,11 @@ static void __init vmware_paravirt_ops_setup(void) vmware_cyc2ns_setup(); - if (vmw_sched_clock) + if (vmw_sched_clock) { paravirt_set_sched_clock(vmware_sched_clock); + x86_platform.save_sched_clock_state = x86_init_noop; + x86_platform.restore_sched_clock_state = x86_init_noop; + } if (vmware_is_stealclock_available()) { has_steal_clock = true; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350654.1608168 (Exim 4.92) (envelope-from ) id 1wf0iJ-0008SC-3S; Wed, 01 Jul 2026 19:35:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350654.1608168; Wed, 01 Jul 2026 19:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iI-0008Rq-Si; Wed, 01 Jul 2026 19:35:14 +0000 Received: by outflank-mailman (input) for mailman id 1350654; Wed, 01 Jul 2026 19:35:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3dWtFagYKCboxjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 1wf0iG-0008CK-Vb for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iG-00BwWE-CE for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:12 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3dWtFagYKCboxjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a456be5-5cb7-0a2a0a5109dd-0a2a4509a272-10 for ; Wed, 01 Jul 2026 21:35:12 +0200 Received: from [209.85.210.201] (helo=mail-pf1-f201.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3dWtFagYKCboxjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a456b76-97e6-0a2a45090019-d155d2c9cc4a-3 for ; Wed, 01 Jul 2026 21:33:12 +0200 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-847a90cc5e2so1365548b3a.0 for ; Wed, 01 Jul 2026 12:33:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934390; x=1783539190; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=bEdSCU5mjiDv3GADlP0fC3hWLpC5/Jr71iPsXhxCK9Y=; b=wdevGvroHRkQ3LBPn8LO/8Q4/dbwUPa0fQHgC2hH4FLtVNFDnb9Ni99iX3z0t+mE3D qOjR17AqEyBxoqluFq6vG86t20Q06VpufcJ8psHLRCPjhOzO1VW9yCKfDGgDoH7cL2gu iX1DSW2gUu4J1cmCj7jFKRaQ4POpvv/Te6N6qO4IL03uDsedlCQMyUBZvQy0BFAkjIAT MoAG/S4oH/1gqw6RzaPXaZi7VQ04qblXZiFVV6I8BM7zgRAOxrFeDxlAYHAros/0tnsx QbPsr4vR4nsVJ/t+mBu9Khh+BirGE55G6zjjdF5i4gaWy20bEj8cKYH+fHC4ICUiVi0L H1Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934390; x=1783539190; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bEdSCU5mjiDv3GADlP0fC3hWLpC5/Jr71iPsXhxCK9Y=; b=MjB2iEASi6y3yprTDdo3iVEoD2PBItiezdrbIBmi1/DHgDkpsgrS7T3UA43/ENSQjv buO9fI1eyVX+nn0vVv28b56Di87lkf3ue58dC1nuCrw/z+uPuHDtfewv5xS7aEXbberU pCw1NSmEE9EtkdqTPh5qKVlJUpG4Pzu0bDTo3DwjWz2ZCLaO+iEciEDI7vWYUAtJqe1p HF/rClvzmboeqjUZfRchgBU88xSilL6tmqLLUDgxh3yJ627LMAFareFekKrR9gXjFAmt 9JgvIYgrEWeXVAtVhXBN7ejQB0S8QMp4h+Be6li/f34tjWRdizUMZ5yKzOaQT9awNSoL 65kw== X-Forwarded-Encrypted: i=1; AFNElJ9cCcgdlP19wYcydxmaFh88YIjaH3iij11dB49BLUEVTmv1ACuyfvdnbrjiBFuldLV5SbxB/AJ5wAM=@lists.xenproject.org X-Gm-Message-State: AOJu0YwlZXA2GV+Y7BPHtjSKsM3A2GaH0k3oqcVex5ftn48b28Zy8SiG gacIfXjZKlET5KwXOfkqEsN2m6q2ZQev+eqDmSb/g/9iafnCEQKqrmgWYYVWeGACJS01DbRhR3L LsPJu4g== X-Received: from pgh6.prod.google.com ([2002:a05:6a02:4e06:b0:c8b:19f4:6228]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:4320:b0:3bf:6c08:fb88 with SMTP id adf61e73a8af0-3bfed4b9441mr3531733637.56.1782934389876; Wed, 01 Jul 2026 12:33:09 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:56 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-36-seanjc@google.com> Subject: [PATCH v5 35/51] x86/tsc: WARN if TSC sched_clock save/restore used with PV sched_clock From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934392-573AB986-DA0568FE/13/0 X-purgate-type: clean X-purgate-size: 1426 Now that all PV clocksources override the sched_clock save/restore hooks when overriding sched_clock, WARN if the "default" TSC hooks are invoked when using a PV sched_clock, e.g. to guard against regressions. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index a762cb5cec0f..7473dcab4775 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -947,9 +947,17 @@ EXPORT_SYMBOL_FOR_MODULES(recalibrate_cpu_khz, "p4-clockmod,powernow-k7"); static unsigned long long cyc2ns_suspend; +static __always_inline bool tsc_is_save_restore_needed(void) +{ + if (WARN_ON_ONCE(!using_native_sched_clock())) + return false; + + return static_branch_likely(&__use_tsc) || sched_clock_stable(); +} + void tsc_save_sched_clock_state(void) { - if (!static_branch_likely(&__use_tsc) && !sched_clock_stable()) + if (!tsc_is_save_restore_needed()) return; cyc2ns_suspend = sched_clock(); @@ -969,7 +977,7 @@ void tsc_restore_sched_clock_state(void) unsigned long flags; int cpu; - if (!static_branch_likely(&__use_tsc) && !sched_clock_stable()) + if (!tsc_is_save_restore_needed()) return; local_irq_save(flags); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350657.1608177 (Exim 4.92) (envelope-from ) id 1wf0iL-0000IV-B0; Wed, 01 Jul 2026 19:35:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350657.1608177; Wed, 01 Jul 2026 19:35:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iL-0000IH-7E; Wed, 01 Jul 2026 19:35:17 +0000 Received: by outflank-mailman (input) for mailman id 1350657; Wed, 01 Jul 2026 19:35:16 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3eWtFagYKCb4wierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 1wf0iK-0000G4-CG for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iJ-00BwWE-PH for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:15 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3eWtFagYKCb4wierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a456bcf-5cb7-0a2a0a5109dd-0a2a4506e1aa-36 for ; Wed, 01 Jul 2026 21:35:15 +0200 Received: from [209.85.214.201] (helo=mail-pl1-f201.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3eWtFagYKCb4wierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a456b7a-08de-0a2a45060019-d155d6c9b97d-3 for ; Wed, 01 Jul 2026 21:33:15 +0200 Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2c9960cf96cso12694165ad.3 for ; Wed, 01 Jul 2026 12:33:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934393; x=1783539193; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=webyAG7YP8cSF0fuLH5JBcVLeBtJwYsS/eijECri5dU=; b=OKXqgrGZQFKq4YulmQwZSpjjqpuNeBTc1pQbh5eMBcCkxDLOqdt1oyXBOJY2rWwgEv q/1WCNCMGS5WNGCVzl0PA8i26PM7a/bICuNlzi6i+i7Xx+wEfCekH7AZZ8WbcEkYqdwQ MPiPmV1kckR8XalKjGtIRiuJUsSk98NPcjlH0sdNEtKLSkFwfb212af+uR7POKRHs7Ut JF+N8Q5PeT/t5WlAkc3jj31kLbGhuiKfBRnt0Nwh/FOK6UQRWHyQF7QoozGif1lxvHBZ bpNDmzaAtMxzOAwprG3ktdM9+aTQyNoX7SFQ2KjSpjupdpduz3f+akv2bSaF4eujo5JI IabQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934393; x=1783539193; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=webyAG7YP8cSF0fuLH5JBcVLeBtJwYsS/eijECri5dU=; b=OuRLhE2gMPVdsYMy4T1+712VmMU5LS7Oq+Dkqg7E9AWmAFETzVLVgFzP5GNQ1KRFdi nYEAI3qQ4J1pv4vxQ/g2kXBZLsuPDG14h2/kbvEIVQzryJ+uR0ldV4NAsRvxs5txGTTB FTdrkgJfAOPkldM5bcoBiVGD+BUBY5T9+FZJTDIUIIq5nEX513XR8GFgTyqob7ekhx+h vcQBksnLrv2h+ay3Kvrikm7pY/CAgOc7P3vgksqJppeNw+tpY3Jxdk6kT68H2SlqWHaS zibVelB2AJTQaOnIH5QFJxngdODj4+rfpZT7H1NNcGy/V031hcEwZK1vG6xUhYTVnI5m Ohfw== X-Forwarded-Encrypted: i=1; AHgh+Ro0g2pRXCYtn6TstVNPdRaRWIh4rpg/xu88JCfC+bSOp/uW7lQUSIDXvnkydq49kyDCA5jeX52P0f4=@lists.xenproject.org X-Gm-Message-State: AOJu0YwO7b2edzjpOridun9c53Bl16cjkxs09seqHwNx6ExKeOBqdi53 3BPTL3tBw6SjXk3baSkIz7TvkqtYE1YZYbg/otrjMP7OuzfMRo19/5oPuGczfLEOxa3vHlxhv0c p5t1MIg== X-Received: from plq6.prod.google.com ([2002:a17:903:2f86:b0:2bd:c5f9:e27b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d48b:b0:2c9:feea:4e50 with SMTP id d9443c01a7336-2ca7e71111emr31590225ad.10.1782934393274; Wed, 01 Jul 2026 12:33:13 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:59 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-39-seanjc@google.com> Subject: [PATCH v5 38/51] x86/xen/time: Mark xen_setup_vsyscall_time_info() as __init From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934395-C473068D-A2936141/13/0 X-purgate-type: clean X-purgate-size: 883 Annotate xen_setup_vsyscall_time_info() as being used only during kernel initialization; it's called only by xen_time_init(), which is already tagged __init. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/xen/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 8cd8bfaf1320..bc26f00fc53e 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -443,7 +443,7 @@ void xen_restore_time_memory_area(void) xen_sched_clock_offset = xen_clocksource_read() - xen_clock_value_saved; } -static void xen_setup_vsyscall_time_info(void) +static void __init xen_setup_vsyscall_time_info(void) { struct vcpu_register_time_memory_area t; struct pvclock_vsyscall_time_info *ti; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:18 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350659.1608186 (Exim 4.92) (envelope-from ) id 1wf0iM-0000Za-KS; Wed, 01 Jul 2026 19:35:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350659.1608186; Wed, 01 Jul 2026 19:35:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iM-0000Ye-GV; Wed, 01 Jul 2026 19:35:18 +0000 Received: by outflank-mailman (input) for mailman id 1350659; Wed, 01 Jul 2026 19:35:17 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3emtFagYKCb8xjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 1wf0iL-0000Om-RX for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iL-003oQR-8A for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:17 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3emtFagYKCb8xjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a456bbc-2eae-0a2a0a5409dd-0a2a450aa144-40 for ; Wed, 01 Jul 2026 21:35:17 +0200 Received: from [209.85.215.202] (helo=mail-pg1-f202.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3emtFagYKCb8xjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a456b7b-e40e-0a2a450a0019-d155d7cad925-3 for ; Wed, 01 Jul 2026 21:33:16 +0200 Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c916d17dd43so1230778a12.3 for ; Wed, 01 Jul 2026 12:33:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934395; x=1783539195; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=gy5b+9Ie1Ki1M0iB4wQwCtkzcjH6HRhEeykN2jC/eJ8=; b=rWmBnnBCYRZ4Oc21boEFED1J2x0B1UJGWEeE1ot96PznZdbNEtpnLmoBOMI0jvcB7O RNcuGFeG4GB2oeSiN8PhrIEkb0IyB4MDOdnOSQOPv4i3xbHFc1zZSkJN3V2T/LYOgiFx pT9GpoeQGCg1VkrFSb5zQ/q9piHFNQTeSmuVdJScsFKDSC5APEfaCnhDuYoNnguDyS7u v0g8Su8B8JZuhXzVT03s8iqrpbANsZ6xBHKaI6LQcXHElSkBD8wTdbFy2q7e+rZ2L+bE RcvoSq24554CiWE25RlIZSy+3IZVdpW/LeqE4lfvxVI5XgwbpV5LZoV3OMn8AbKl+/gZ R9ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934395; x=1783539195; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gy5b+9Ie1Ki1M0iB4wQwCtkzcjH6HRhEeykN2jC/eJ8=; b=FbNsNHdLOqmx5ZLTlBbLdYXFu2ngBRxvbxv3jdwCJ8M/6gZQE8gGfoPQHFQOr8G2OK 7bxbJF0y4F/U4aFg56oqEPFqj5JE2+ViOxKKIBBN5vh49bRb+ntjyOVomyddCJj4xiXd /dvsA/9IqwDS0uABD8GJblfre8v10bNizAgD437Oyi0lBotAhW2709RzeN6EA/+OVDl0 sjJ3+aBb2JiO9uVd2gAWrkHiKMif5hYU0r4YTAMLcpP592/FT7KgPfM0Ny8VihEjlZ42 vAEgb4T1/Mn7jo3/LXrDrCZKUsI4M44BzpQ78ii5HmZlMu6JdnkstSg/lF1T3uTfQKzA TiKA== X-Forwarded-Encrypted: i=1; AHgh+RrX2hcZbUflFUhJjV+ixfLlofW6/MBH1Z2b3EraNT5dUBcdOnPczZPMokGE9UimM1hnpJSDdCnrBaA=@lists.xenproject.org X-Gm-Message-State: AOJu0YyJLHmu5xX8EAsm11hLMbrQYCa+ToroG9ctSJWj5glGSzZIQm2E r+SaBAbfdUd8TZdd7UZ2CdLKrH6jI4laemvWo1jvn3kHxf/zUPkudfrmwcQG3g6sxIZkv4Ojauf fWL7xXA== X-Received: from pfbbk23.prod.google.com ([2002:aa7:8317:0:b0:846:7503:7350]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3d56:b0:845:36a0:9eb2 with SMTP id d2e1a72fcca58-847c096d1f0mr2944243b3a.34.1782934394416; Wed, 01 Jul 2026 12:33:14 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:00 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-40-seanjc@google.com> Subject: [PATCH v5 39/51] x86/pvclock: Mark setup helpers and related various as __init/__ro_after_init From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1782934397-D472EDDE-E6EA5604/13/0 X-purgate-type: clean X-purgate-size: 1388 Now that Xen PV clock and kvmclock explicitly do setup only during init, tag the common PV clock flags/vsyscall variables and their mutators with __init. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/pvclock.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c index b3f81379c2fc..a51adce67f92 100644 --- a/arch/x86/kernel/pvclock.c +++ b/arch/x86/kernel/pvclock.c @@ -16,10 +16,10 @@ #include #include -static u8 valid_flags __read_mostly = 0; -static struct pvclock_vsyscall_time_info *pvti_cpu0_va __read_mostly; +static u8 valid_flags __ro_after_init = 0; +static struct pvclock_vsyscall_time_info *pvti_cpu0_va __ro_after_init; -void pvclock_set_flags(u8 flags) +void __init pvclock_set_flags(u8 flags) { valid_flags = flags; } @@ -153,7 +153,7 @@ void pvclock_read_wallclock(struct pvclock_wall_clock *wall_clock, set_normalized_timespec64(ts, now.tv_sec, now.tv_nsec); } -void pvclock_set_pvti_cpu0_va(struct pvclock_vsyscall_time_info *pvti) +void __init pvclock_set_pvti_cpu0_va(struct pvclock_vsyscall_time_info *pvti) { WARN_ON(vclock_was_used(VDSO_CLOCKMODE_PVCLOCK)); pvti_cpu0_va = pvti; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350660.1608196 (Exim 4.92) (envelope-from ) id 1wf0iO-0000og-1M; Wed, 01 Jul 2026 19:35:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350660.1608196; Wed, 01 Jul 2026 19:35:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iN-0000np-Qz; Wed, 01 Jul 2026 19:35:19 +0000 Received: by outflank-mailman (input) for mailman id 1350660; Wed, 01 Jul 2026 19:35:19 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3e2tFagYKCcAykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 1wf0iM-0000bx-UJ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iM-003ap0-Az for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:18 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3e2tFagYKCcAykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 6a456bbe-bab6-0a2a0a5309dd-0a2a45079ec8-30 for ; Wed, 01 Jul 2026 21:35:18 +0200 Received: from [209.85.210.201] (helo=mail-pf1-f201.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3e2tFagYKCcAykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 6a456b7c-9c8e-0a2a45070019-d155d2c9c472-3 for ; Wed, 01 Jul 2026 21:33:18 +0200 Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-8479c6c6cbeso868238b3a.0 for ; Wed, 01 Jul 2026 12:33:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934396; x=1783539196; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=w419X+lYiD/kBIvhKaeAU2oxypXcdz+V5rg+/s/ZS+Q=; b=DjjcZzSR+k9Oz5zDcrL+fukPK1cHkSDwacxEyo8ZNr/Djo5z2qM8nZchCPU2qA65X5 O5npMzQmAxvHEc3Y8RqKWsQC/xsg+EwPZmaxRKosEmTXT2FJspDNj2FcwfN8Gst6jK52 GoNr5FJm6H1idCuYdDlPg+8WqcMlS59WVgrV0pVCxnES/7n54CQmJ50fyjIOV5+Zx/KH LIJgajKCDda02OTa8Rvpaq5TlvqMTp8iVvJH7BdFZSQPVil+QSmLPvsqC21MRLeKoW5k zGL6lcZdTmGo/Ix1JXl8kz/wfqi/l/w0qK0Nqf2ajpkL/6WEjcjpVybGyLObfYZ4mXGI hEhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934396; x=1783539196; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w419X+lYiD/kBIvhKaeAU2oxypXcdz+V5rg+/s/ZS+Q=; b=Qc4kxRR6+9YiUgBMKk3JbF62NAPp41ZNtMyabEoynrqdpnRpBV0kc0YOmK7fFO9YM3 AdbBm3JiNYTI6YFONh8IGoXw9+MPMjuQ9gI7p2wyMQ5IivWYCgXnTYbHZuiifvSNslN+ uC2Ckc7AqveBSWaG9fY8AvbzVMg7Ccl4RsZYgmkAqD3w39fSEYrem2Lex4eTTecYqg4r RNLvn0I509TpexqWWIqHGLRYb8hBAFiJtObNzTfPk8/IDbMVNFxyKnwux5l8YPp0Qecb z0cEGT6M4i7U3tKdWo/kEaqXRI9mWOxWd8utr0cC6GSlOJpo8eRFcrDp9U95/be9aAbm IPVw== X-Forwarded-Encrypted: i=1; AFNElJ940w30XK1lGfE9vlXzIub6kOzm2LMXTMe6LnhHJvq+2GBg4tETQ9izzyGrn+WvNPqnihL0qGsAIcQ=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy05ZMXNa4wZe0HvYWjTltK8OE+HVQ9tubKaSVxoVetYyz+EJ4H 4USy/NXu2LcHS/adkWeY+XeVW8tkYsGk8Zl8ZhF1gt68Fo9T8VB2hPEUWKu0AFyyIcVlH/b5yGb wQbW5uQ== X-Received: from pfbdf8.prod.google.com ([2002:a05:6a00:4708:b0:847:a13f:28e2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:a112:b0:847:8f7c:fa10 with SMTP id d2e1a72fcca58-847c0894ebamr2717987b3a.35.1782934395673; Wed, 01 Jul 2026 12:33:15 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:01 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-41-seanjc@google.com> Subject: [PATCH v5 40/51] x86/pvclock: WARN if pvclock's valid_flags are overwritten From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1782934398-7C52825E-B5FC3110/13/0 X-purgate-type: clean X-purgate-size: 784 WARN if the common PV clock valid_flags are overwritten; all PV clocks expect that they are the one and only PV clock, i.e. don't guard against another PV clock having modified the flags. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/pvclock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c index a51adce67f92..8d098841a225 100644 --- a/arch/x86/kernel/pvclock.c +++ b/arch/x86/kernel/pvclock.c @@ -21,6 +21,7 @@ static struct pvclock_vsyscall_time_info *pvti_cpu0_va __ro_after_init; void __init pvclock_set_flags(u8 flags) { + WARN_ON(valid_flags); valid_flags = flags; } -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350662.1608204 (Exim 4.92) (envelope-from ) id 1wf0iS-0001GE-9S; Wed, 01 Jul 2026 19:35:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350662.1608204; Wed, 01 Jul 2026 19:35:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iS-0001Fy-3u; Wed, 01 Jul 2026 19:35:24 +0000 Received: by outflank-mailman (input) for mailman id 1350662; Wed, 01 Jul 2026 19:35:22 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3f2tFagYKCcQ2okxtmqyyqvo.myw7ox-no5ovvs232.7oxz1ytom3.y1q@flex--seanjc.bounces.google.com>) id 1wf0iQ-0001A9-Fs for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iP-003aqt-T6 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:21 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3f2tFagYKCcQ2okxtmqyyqvo.myw7ox-no5ovvs232.7oxz1ytom3.y1q@flex--seanjc.bounces.google.com>) id 6a456bbb-5cb7-0a2a0a5109dd-0a2a4501a4e0-42 for ; Wed, 01 Jul 2026 21:35:21 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3f2tFagYKCcQ2okxtmqyyqvo.myw7ox-no5ovvs232.7oxz1ytom3.y1q@flex--seanjc.bounces.google.com>) id 6a456b80-400f-0a2a45010019-d155d84aec73-3 for ; Wed, 01 Jul 2026 21:33:21 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-380a638fb5bso818813a91.0 for ; Wed, 01 Jul 2026 12:33:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934400; x=1783539200; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=VKCobU9qtcP/hN9BlhIiU1X9DFbnjtpoNJAd58RipCc=; b=rcCjALW3koXQzp5m8P/9B2zVS6Ba8IrfVJqjqUlnREgjQ4xBbM5BeomSKrt0qc7gCk atqK2YDoqUCHl7Ev4Q666lbBu03VYsFiGFLgPQhcl+hRSBitbUq56g0/xOetPaVnlDwJ iWnMExN3UiFEioWJKzmHTYbxuwz/2wEzbnquDxz/FDPwZLHqL0gqJ8InrCVquqtcXrl1 EFYIwhbAU9yqimnaSp7dKN9yCDpS1YXQtgD+qh2VN+gpyFkcx/BswtK3OC0PS3/bKcuB H5q/M5hpLJpJMLqiTIRBYkb/mn/tXF9KJK6SMadbaQHgbcN0ZHGRLWeat/5qbLjbfpYY Le6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934400; x=1783539200; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VKCobU9qtcP/hN9BlhIiU1X9DFbnjtpoNJAd58RipCc=; b=rbxGDCUgjT9sc9dN1SkRBqMSAYoYWmxqdsFzxo4xhsweoG5QOo0SfNDPSWCO6cazz0 qEOmiMbQJKbaQOsnTgucyNRzN1FTuQdwtR7h0G5/F/o2XO3mVQzAPOta0XNgDliVfNXY WWgJz2Wim17UwB/YGoXGU7qUexq9qunJXvU0xaI1ek+e4/r4prxm/TVTySVuTE5caXg2 e/HPIfPubZrtq2VFG40rKSD8zuPIlCVXg4+SGPqDW7qO6wcLRTTwQ9Bs3tAoaGq6yMWJ nNBPNO9bA9QedvxOZf1O114JYekYUOPqQl/lVu5TSVcMC0Uy2qhbXlIh7JVFywXtq1zY YSpQ== X-Forwarded-Encrypted: i=1; AHgh+RpoqhGqxeor6cIRZ80fFlB3Uu4UXjc+/neheDDrXwy+SjOA8slSx77Hx0F22aqW1zAMroZfSmSHwD4=@lists.xenproject.org X-Gm-Message-State: AOJu0YyDuVXDpfZ4n/OEqO+GveLRVuq3+wa0e35/HKy5Pk4bvjilYUNv ljIZ7ZxXQlCo2I0I1yZhWlYuj4tsOXEgB54iGAR3uhcWF8/w+QeSEVJKWiVBeRUsd9ZdL9+Aupc qdqbzDg== X-Received: from pjqu11.prod.google.com ([2002:a17:90a:ae8b:b0:37d:8595:7a08]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:180e:b0:37f:ff9d:ad69 with SMTP id 98e67ed59e1d1-380ba80c706mr2175388a91.7.1782934399271; Wed, 01 Jul 2026 12:33:19 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:04 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-44-seanjc@google.com> Subject: [PATCH v5 43/51] x86/kvmclock: Hook clocksource.suspend/resume when kvmclock isn't sched_clock From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1782934401-83CCE1E0-426599FE/0/0 X-purgate-type: clean X-purgate-size: 2034 Save/restore kvmclock across suspend/resume via clocksource hooks when kvmclock isn't being used for sched_clock. This will allow using kvmclock as a clocksource (or for wallclock!) without also using it for sched_clock. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 61d4d943fe74..41aff709b90a 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -152,7 +152,17 @@ static void kvm_setup_secondary_clock(void) static void kvm_restore_sched_clock_state(void) { - kvm_register_clock("primary cpu clock, resume"); + kvm_register_clock("primary cpu, sched_clock resume"); +} + +static void kvmclock_suspend(struct clocksource *cs) +{ + kvmclock_disable(); +} + +static void kvmclock_resume(struct clocksource *cs) +{ + kvm_register_clock("primary cpu, clocksource resume"); } void kvmclock_cpu_action(enum kvm_guest_cpu_action action) @@ -223,6 +233,8 @@ static struct clocksource kvm_clock = { .flags = CLOCK_SOURCE_IS_CONTINUOUS, .id = CSID_X86_KVM_CLK, .enable = kvm_cs_enable, + .suspend = kvmclock_suspend, + .resume = kvmclock_resume, }; static void __init kvmclock_init_mem(void) @@ -318,6 +330,15 @@ static __init void kvm_sched_clock_init(bool stable) kvm_save_sched_clock_state, kvm_restore_sched_clock_state); + /* + * The BSP's clock is managed via dedicated sched_clock save/restore + * hooks when kvmclock is used as sched_clock, as sched_clock needs to + * be kept alive until the very end of suspend entry, and restored as + * quickly as possible after resume. + */ + kvm_clock.suspend = NULL; + kvm_clock.resume = NULL; + pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350663.1608208 (Exim 4.92) (envelope-from ) id 1wf0iT-0001Oo-2Y; Wed, 01 Jul 2026 19:35:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350663.1608208; Wed, 01 Jul 2026 19:35:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iS-0001LH-Ov; Wed, 01 Jul 2026 19:35:24 +0000 Received: by outflank-mailman (input) for mailman id 1350663; Wed, 01 Jul 2026 19:35:23 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3gGtFagYKCcU3plyunrzzrwp.nzx8py-op6pwwt343.8py02zupn4.z2r@flex--seanjc.bounces.google.com>) id 1wf0iR-0001E8-J3 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iR-004oMZ-00 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:23 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3gGtFagYKCcU3plyunrzzrwp.nzx8py-op6pwwt343.8py02zupn4.z2r@flex--seanjc.bounces.google.com>) id 6a456bbc-2eae-0a2a0a5409dd-0a2a450aa144-48 for ; Wed, 01 Jul 2026 21:35:22 +0200 Received: from [209.85.216.73] (helo=mail-pj1-f73.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3gGtFagYKCcU3plyunrzzrwp.nzx8py-op6pwwt343.8py02zupn4.z2r@flex--seanjc.bounces.google.com>) id 6a456b81-e40e-0a2a450a0019-d155d849bce7-3 for ; Wed, 01 Jul 2026 21:33:22 +0200 Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-37d4f23eb37so1673025a91.0 for ; Wed, 01 Jul 2026 12:33:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934401; x=1783539201; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=X+4LkvbZ4eCaIbae7uS/MPBNwexrDlCNdhdaInFV7cw=; b=rOlOoVJov403l+V5pxkWwqdOR9xnngUXzQkGAs4jNhh8wXSgYLpN0O8qcTZtSoCfCS jivxQqNThdTlY9aWQOtr8c0j0nssDUMw+qyoh1fgW2ef9pd8HCNId9d2fVOaSLEoyWqB Q2HtAHObtq+rWhsUz7CHwkZVTBsBAONk64nomuUv9/beBAU10k8kJbX8t30/AIQd3/bL OpuHdbZ5bZgtJOXXk1+d8AfAOe1DbIKnjqxRVJb+y+qM70YG6IruQrS3i0BJCaz8wTRD kUbPwrzS1FqouIh2ITkP+Ti1MQ+qpufbXHPMWiseaCZiq7HzrfwXLtk5O1pG3yA48Kii Bc6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934401; x=1783539201; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X+4LkvbZ4eCaIbae7uS/MPBNwexrDlCNdhdaInFV7cw=; b=Ypfk3Xhnq7NE57y/qlM5qzp9XmWI0iT62KR0jLlnE13R0djc5iQRfeITTjyhyOw2vI IwNoBkSQ2iMw3A8XVY3W547j76IY/IufxlHSLOU+bZWIzy5K2iuJAoXWQ9Q5tpGNLMVl lStDVl+y3mGF8unr/8UzVQREczGsiwSxpY0rYq15XXtHP/hwU+eqDcZwyJUtvnWHlcCO KZkv+2XDZz93hYOTRE9fCZBBnzODlwVlsfEjSHkbH6p9S1y4nFPavikwv8E8aJWNNezv yFyeHE6xemBXZ1LQFDBAWomlHeBNLWl1qcCL5KsOnqBX6bvbzE3d2ScFOWDVNv8zH/BO /eLg== X-Forwarded-Encrypted: i=1; AHgh+RoXk1rMaDA2+Ozrc4csWxF0ivnBk1UgwUjk8nyLz5j/ijL1tDU49TvD7Hgaz7JLbdQnO/Gz82/pBcc=@lists.xenproject.org X-Gm-Message-State: AOJu0YyMi4RvKYXBA2DIagG45VtZcbon+etpI9EfZGbcAe4W1UhR6Llv l9ujrZ90H+GIM6fR7nSy74cAi8izEQ80X2k+U8pefb9mbgYANjLNNCJEGm7YHS3R0775XQRYt5H vvRwElw== X-Received: from pjbms9.prod.google.com ([2002:a17:90b:2349:b0:37f:9ce0:f1f5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2c87:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-380aa0e0512mr2733682a91.14.1782934400395; Wed, 01 Jul 2026 12:33:20 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:05 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-45-seanjc@google.com> Subject: [PATCH v5 44/51] x86/kvmclock: WARN if wall clock is read while kvmclock is suspended From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1782934402-CED3BDDE-30CC84DB/0/0 X-purgate-type: clean X-purgate-size: 2069 WARN if kvmclock is still suspended when its wallclock is read, i.e. when the kernel reads its persistent clock. The wallclock subtly depends on the BSP's kvmclock being enabled, and returns garbage if kvmclock is disabled. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 41aff709b90a..2cc3dd2ba355 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -53,6 +53,8 @@ static struct pvclock_vsyscall_time_info *hvclock_mem; DEFINE_PER_CPU(struct pvclock_vsyscall_time_info *, hv_clock_per_cpu); EXPORT_PER_CPU_SYMBOL_GPL(hv_clock_per_cpu); +static bool kvmclock_suspended; + /* * The wallclock is the time of day when we booted. Since then, some time may * have elapsed since the hypervisor wrote the data. So we try to account for @@ -60,6 +62,7 @@ EXPORT_PER_CPU_SYMBOL_GPL(hv_clock_per_cpu); */ static void kvm_get_wallclock(struct timespec64 *now) { + WARN_ON_ONCE(kvmclock_suspended); wrmsrq(msr_kvm_wall_clock, slow_virt_to_phys(&wall_clock)); preempt_disable(); pvclock_read_wallclock(&wall_clock, this_cpu_pvti(), now); @@ -140,6 +143,7 @@ static void kvm_save_sched_clock_state(void) * to the old address prior to reconfiguring kvmclock would clobber * random memory. */ + kvmclock_suspended = true; kvmclock_disable(); } @@ -152,16 +156,19 @@ static void kvm_setup_secondary_clock(void) static void kvm_restore_sched_clock_state(void) { + kvmclock_suspended = false; kvm_register_clock("primary cpu, sched_clock resume"); } static void kvmclock_suspend(struct clocksource *cs) { + kvmclock_suspended = true; kvmclock_disable(); } static void kvmclock_resume(struct clocksource *cs) { + kvmclock_suspended = false; kvm_register_clock("primary cpu, clocksource resume"); } -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350668.1608221 (Exim 4.92) (envelope-from ) id 1wf0iX-0001zO-Cs; Wed, 01 Jul 2026 19:35:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350668.1608221; Wed, 01 Jul 2026 19:35:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iX-0001yo-7V; Wed, 01 Jul 2026 19:35:29 +0000 Received: by outflank-mailman (input) for mailman id 1350668; Wed, 01 Jul 2026 19:35:27 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3hGtFagYKCck7tp2yrv33v0t.r31Ct2-stAt00x787.Ct2463ytr8.36v@flex--seanjc.bounces.google.com>) id 1wf0iV-0001ta-RW for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iV-003oUT-8M for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:27 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3hGtFagYKCck7tp2yrv33v0t.r31Ct2-stAt00x787.Ct2463ytr8.36v@flex--seanjc.bounces.google.com>) id 6a456bf3-e002-0a2a0a5209dd-0a2a450484fc-26 for ; Wed, 01 Jul 2026 21:35:27 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3hGtFagYKCck7tp2yrv33v0t.r31Ct2-stAt00x787.Ct2463ytr8.36v@flex--seanjc.bounces.google.com>) id 6a456b85-a01d-0a2a45040019-d155d84ad9d1-3 for ; Wed, 01 Jul 2026 21:33:27 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-38096521198so1608365a91.3 for ; Wed, 01 Jul 2026 12:33:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934405; x=1783539205; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=sbysuOQKV7W7YbruNHYRSyCV0jaRsBQX5EoVXm1Gq/A=; b=uvoPGw+ss6c1ymsKriG1EYMp26JD7cuS6otDiI2Fleq2T8ydNxb5qBJ9WKODRmfumm A7ZmTDZPNBiU8YwNGeUnmkM3CeC2lu4Gvvni2bq+I1g5w+XcSVBYTVqOa5/uiB254XsL INgeATlHz3eq9GCXyeEkvoCaOKH53tG17TwBw7+aFqnL4pYRgtSpRHuKUqL1IlLW8pcJ eEJwF/A1sji0FZA2P/sOLTyr1CJR5YrK5//n/oc2XL1Ppip66dIgBx6OzaaJgjoaBZiH OVGCZCf7LNdrtOCIT423YN1kO9tWw413OB6pXp9H0b089qT4vGJLeWUOkC5KeEaBqMp/ TfmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934405; x=1783539205; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sbysuOQKV7W7YbruNHYRSyCV0jaRsBQX5EoVXm1Gq/A=; b=srfNoMnpYjpZdc9JlR7YFY7wFraMnMCvfVMNjjhpWROkR/nVFrPnl60ds2y/Nv/oo8 lxCbxghdFrFLZbeo/0BxEEx68gnkrC3FxbiV8Y0B29eq4kvoyiueuPfBw5pLyRx53tGz QrG4KvNXyUUP7P4NEAF7pkwwp21ncG4bwQB23PtXoxgPTfJDyiHovzw2kl4iJQ3C47BS yhSXsRgPxLU5mBZRFmll5aoYKF6pCYGAR1ZDYTNNDLXgt4qm1lOg7Yu5sUF1hJosDQh7 0c3iSvY/hqt4vknNYwcwGsX++g5D35H1jMxlcn+46+wxNxExAi4Dra8zGLp2Sl761Dht F/Bg== X-Forwarded-Encrypted: i=1; AHgh+Rru35dzXfjlXANzbpnGdGQspC+q0oXdfXTXA8hgx0F/vpJ5iO7754q1er5IrHYuthOzQZyqE445Wg4=@lists.xenproject.org X-Gm-Message-State: AOJu0YyZpz1C6gsi1K6jQQmXddcYCRsic5Om0Mc42+hOAwPAAW+gQNK8 gybwbHYnIjxt6+KlMWjd/qyemUFz9uZfY0w/i4MgUkL6xLA7D/qVnn6Cut9bB41nd9Thot/XGM+ kfO5IYw== X-Received: from pjbbf15.prod.google.com ([2002:a17:90b:b0f:b0:37d:e898:7cd8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2886:b0:36a:f612:e6a3 with SMTP id 98e67ed59e1d1-380aa18d2b1mr3062418a91.17.1782934404832; Wed, 01 Jul 2026 12:33:24 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:09 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-49-seanjc@google.com> Subject: [PATCH v5 48/51] x86/kvmclock: Use TSC for sched_clock if it's constant and non-stop From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934407-AFB231CC-E5E0692C/0/0 X-purgate-type: clean X-purgate-size: 2195 Prefer the TSC over kvmclock for sched_clock if the TSC is constant and nonstop. I.e. use the same criteria as tweaking the clocksource rating so that TSC is preferred over kvmclock. Per the below comment from native_sched_clock(), sched_clock is more tolerant of slop than clocksource; using TSC for clocksource but not sched_clock makes little to no sense, especially now that KVM CoCo guests with a trusted TSC use TSC, not kvmclock. /* * Fall back to jiffies if there's no TSC available: * ( But note that we still use it if the TSC is marked * unstable. We do this because unlike Time Of Day, * the scheduler clock tolerates small errors and it's * very important for it to be as fast as the platform * can achieve it. ) */ The only advantage of using kvmclock is that doing so allows for early and common detection of PVCLOCK_GUEST_STOPPED, but that code has been broken for over two years with nary a complaint, i.e. it can't be _that_ valuable. And as above, certain types of KVM guests are losing the functionality regardless, i.e. acknowledging PVCLOCK_GUEST_STOPPED needs to be decoupled from sched_clock() no matter what. Link: https://lore.kernel.org/all/Z4hDK27OV7wK572A@google.com Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 22e8855fcd4d..bc98ebb8587d 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -396,7 +396,6 @@ void __init kvmclock_init(bool prefer_tsc) PVCLOCK_TSC_STABLE_BIT; } - kvm_sched_clock_init(stable); if (!x86_init.hyper.get_tsc_khz) x86_init.hyper.get_tsc_khz = kvmclock_get_tsc_khz; @@ -416,6 +415,8 @@ void __init kvmclock_init(bool prefer_tsc) */ if (prefer_tsc) kvm_clock.rating = 299; + else + kvm_sched_clock_init(stable); clocksource_register_hz(&kvm_clock, NSEC_PER_SEC); pv_info.name = "KVM"; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350669.1608230 (Exim 4.92) (envelope-from ) id 1wf0iY-0002Fd-Uw; Wed, 01 Jul 2026 19:35:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350669.1608230; Wed, 01 Jul 2026 19:35:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iY-0002DX-Jx; Wed, 01 Jul 2026 19:35:30 +0000 Received: by outflank-mailman (input) for mailman id 1350669; Wed, 01 Jul 2026 19:35:30 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3hmtFagYKCcs9vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 1wf0iY-000268-1S for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0iX-003oUT-EB for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:29 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3hmtFagYKCcs9vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a456bf3-e002-0a2a0a5209dd-0a2a450484fc-28 for ; Wed, 01 Jul 2026 21:35:29 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3hmtFagYKCcs9vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a456b87-a01d-0a2a45040019-d155d84aec65-3 for ; Wed, 01 Jul 2026 21:33:29 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-380a638fb5bso818894a91.0 for ; Wed, 01 Jul 2026 12:33:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934407; x=1783539207; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=BBdglu7Hd/NWIo80QzRStfEHhLuTnQAY4zgBWN5WaBQ=; b=jc2ZPFfFL3VHNSXDjsIuCDmBbhn10cDWcvWpfI+pYjHvbJkfZE7gyuAzXDYT1MVC4B UjkmL9GD9ZW/rjozdXbOnLVYi3WKc8DHlWMDxVDhyyzQxjrasnsXleuUgGtT5bM8IXfv sAuWo3kEX6Izb++Ay7HMIvuf2wK4RvZPgGRbyvZutVd7cHSVSafYwUr5TKNrh/nMQmaV W5RvRUF1QHvUPx+e0kmX4H/jp0YsWNgb3PBQhDhQbd9PTYLsaXAZlfVykTliqhjqUJLW f7eXFMshdXDodLzDYVQ+VDhZN6rDDuUQbL8I/zj2ii6mnfq4b7g4o7+KXRrgvesXCMMn /Z2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934407; x=1783539207; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BBdglu7Hd/NWIo80QzRStfEHhLuTnQAY4zgBWN5WaBQ=; b=pQRQxRYHwLJuchGbIl34J3W+155xrW7loBMjNXC3tAgMkBHUdrezZ1kcbU12o9AR4T xaFIBXljC86gRzavp+NZQRyAi6hCQWcJBlBIk5+8vD02sla4pUCQPzrCUiHEc9//ogbJ 3ijdwdAYEDdo/qf1ND3H+weHfaoheFBi/MT6ArTbWvg3BuuUK7EJHUjZyCN4EEzB8K+l DtEzFugctEkGyznmmE5bGopo0lJGlFRONK2MmFUiw46KHDqrqVl4bhkIMUjXHl3qa7hP Fsp7n2MFCf4qIk0mwCCw1sHOQ+J2Pd7tZmXFXLm6yjEK6sNrzKl1IhG0bj/fAmk3I0Rt eBTQ== X-Forwarded-Encrypted: i=1; AHgh+RqeHtLfCthZGbujIAkUVxn+8jCsjo1bQAKh84SWIJeHnJiQxKt1IcJH/Mk/Z/g6l4SX14vA545G4NI=@lists.xenproject.org X-Gm-Message-State: AOJu0YyqOEP+5zHE/acWYEioNc3+Un/4oYk+O3ST8kkKIdYdl41S4WWk E+kxT72Y1eaI1JStWXdlLLvgTxU0gPRAroebyflg0e+aIa0EUwDrFDWqd0V+Vxl3DkIUsWl+1vd SmIAhcA== X-Received: from pjbmt23.prod.google.com ([2002:a17:90b:2317:b0:380:79f2:a916]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3a47:b0:37e:2005:6507 with SMTP id 98e67ed59e1d1-380ba84865cmr1899432a91.15.1782934406994; Wed, 01 Jul 2026 12:33:26 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:32:11 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-51-seanjc@google.com> Subject: [PATCH v5 50/51] x86/paravirt: Move using_native_sched_clock() stub into timer.h From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1782934409-ADB331CC-A683ADBA/13/0 X-purgate-type: clean X-purgate-size: 1714 Now that timer.h ended up with CONFIG_PARAVIRT #ifdeffery anyways, move the PARAVIRT=n using_native_sched_clock() stub into timer.h as a "free" optimization. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 6 ++++-- arch/x86/kernel/tsc.c | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index ca5c95d48c03..a52388af6055 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -11,9 +11,9 @@ extern void recalibrate_cpu_khz(void); extern int no_timer_check; -extern bool using_native_sched_clock(void); - #ifdef CONFIG_PARAVIRT +extern bool using_native_sched_clock(void); + int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, void (*save)(void), void (*restore)(void)); @@ -23,6 +23,8 @@ static __always_inline void paravirt_set_sched_clock(u64 (*func)(void), { (void)__paravirt_set_sched_clock(func, true, save, restore); } +#else +static inline bool using_native_sched_clock(void) { return true; } #endif /* diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index a146fc7b5e74..564be4faa5a0 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -302,8 +302,6 @@ int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, } #else u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); - -bool using_native_sched_clock(void) { return true; } #endif notrace u64 sched_clock(void) -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:35:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:35:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350719.1608240 (Exim 4.92) (envelope-from ) id 1wf0iu-0004Kw-8e; Wed, 01 Jul 2026 19:35:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350719.1608240; Wed, 01 Jul 2026 19:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0iu-0004Ko-5e; Wed, 01 Jul 2026 19:35:52 +0000 Received: by outflank-mailman (input) for mailman id 1350719; Wed, 01 Jul 2026 19:35:51 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3YGtFagYKCaUXJFSOHLTTLQJ.HTRcJS-IJaJQQNXYX.cJSUWTOJHY.TWL@flex--seanjc.bounces.google.com>) id 1wf0it-0004GA-BM for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:35:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0is-003oa2-OY for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:35:50 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3YGtFagYKCaUXJFSOHLTTLQJ.HTRcJS-IJaJQQNXYX.cJSUWTOJHY.TWL@flex--seanjc.bounces.google.com>) id 6a456bfe-bab6-0a2a0a5309dd-0a2a4509b1ae-26 for ; Wed, 01 Jul 2026 21:35:50 +0200 Received: from [209.85.216.73] (helo=mail-pj1-f73.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3YGtFagYKCaUXJFSOHLTTLQJ.HTRcJS-IJaJQQNXYX.cJSUWTOJHY.TWL@flex--seanjc.bounces.google.com>) id 6a456b61-97e6-0a2a45090019-d155d849b474-3 for ; Wed, 01 Jul 2026 21:32:50 +0200 Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-37e17ec1940so1078897a91.0 for ; Wed, 01 Jul 2026 12:32:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934368; x=1783539168; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=+CBMOnR0NQyGIEx0KnXnLe9zyF/J2rmq2NSzuBA4h88=; b=XcrJrXfzVwhbQm7arI+4S5/HMO/oIwi1vFSPuB5UxJBgmScUpoALtc3jgjZQQs+Hdx XLI4WFqfuLiHvRAAGxUY6PUHZeud93WVHymI18Fzgah7GvGGOrZSlUoSPRSuFYNiQYn0 BbxFJU31l8dWLGDvxD6j6MkJ51TEb9hAlHQNiQSR31VSDIllLI5qDFyDg4qIsnrNnLdL YXkFCr5FkFy465juiTNHMdJKCCR1vxnvzTqoPy7UJt+HZCY1ZAbyIwXZhj8k0rwwEwVu /anVp+w8uKc7en2ZkjNBHOryBqLXrT+E0eZdu9MwIKGFotLLlwrV2E9k/XTPrZ81uLHT t+0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934368; x=1783539168; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+CBMOnR0NQyGIEx0KnXnLe9zyF/J2rmq2NSzuBA4h88=; b=iMjDkFYr4IFXy0tOMp7WrhrW5Vm40695Cil9KI5rhpdTHZnNQcSC9L9tEwPr5SPsEG x7OgZ2F8aaA44iSxVorY6XdHX57Pwca7bLYTSGI1FSYfFd81j+jXu1DzAogQtbzfq0YW T4JhLZwGWj3q1W11XoVevz1ukJKs3rXKZnHeLeCWA3iWY6Pos21ccnen6sHx1zufF4Kg zXydVLtGiwbQHgPTRMJtuehbam5Z8OkGmjXPUmjuqOJC2tkfA9DzuIZwAETIjYhZbzHE Y0iF0OyQlEmX8R6b0pXp+SJ88EutDKucCi4Bo+oxDi7XbVX6s6CI2LqrVveNuQHwPnUj rDRg== X-Forwarded-Encrypted: i=1; AHgh+RooTcgGYc5mqr0Tvdk41lAt7X67dflxa9IDclZDKfUiJfkf1PQcJzrQgKiclvXDEYGLiznjFrtp/J8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzStQAgy/qXsIMFzPaxtIxbeZQMd3NVfV+FyFL229fUzRNlaygF 7v8D8EPz+sBh7otDHrJbaIJyYGPHaboLBdPvFrTKbWZlmIBG86gwzWNahX9Xkxt4pD6c/8BBaAJ jUqqAMQ== X-Received: from pjbca16.prod.google.com ([2002:a17:90a:f310:b0:37c:9369:8b75]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4acb:b0:37f:d6f3:450d with SMTP id 98e67ed59e1d1-380aa1313ecmr3162862a91.14.1782934368170; Wed, 01 Jul 2026 12:32:48 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:39 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-19-seanjc@google.com> Subject: [PATCH v5 18/51] x86/kvmclock: Rename kvm_get_tsc_khz() to kvmclock_get_tsc_khz() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934370-4532F986-E3E9FB2F/13/0 X-purgate-type: clean X-purgate-size: 1634 Rename kvm_get_tsc_khz() to kvmclock_get_tsc_khz() in anticipation of adding support for getting TSC info from PV CPUID, i.e. in a KVM specific way, but without non-kvmclock. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 35a879d33e9e..061a22d31dea 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -136,7 +136,7 @@ static inline void kvm_sched_clock_init(bool stable) * poll of guests can be running and trouble each other. So we preset * lpj here */ -static unsigned int __init kvm_get_tsc_khz(void) +static unsigned int __init kvmclock_get_tsc_khz(void) { return pvclock_tsc_khz(this_cpu_pvti()); } @@ -146,7 +146,7 @@ static void __init kvm_get_preset_lpj(void) unsigned long khz; u64 lpj; - khz = kvm_get_tsc_khz(); + khz = kvmclock_get_tsc_khz(); lpj = ((u64)khz * 1000); do_div(lpj, HZ); @@ -342,8 +342,8 @@ void __init kvmclock_init(void) flags = pvclock_read_flags(&hv_clock_boot[0].pvti); kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); - x86_init.hyper.get_tsc_khz = kvm_get_tsc_khz; - x86_init.hyper.get_cpu_khz = kvm_get_tsc_khz; + x86_init.hyper.get_tsc_khz = kvmclock_get_tsc_khz; + x86_init.hyper.get_cpu_khz = kvmclock_get_tsc_khz; x86_platform.get_wallclock = kvm_get_wallclock; x86_platform.set_wallclock = kvm_set_wallclock; #ifdef CONFIG_X86_LOCAL_APIC -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:36:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350740.1608250 (Exim 4.92) (envelope-from ) id 1wf0jB-00056V-Lu; Wed, 01 Jul 2026 19:36:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350740.1608250; Wed, 01 Jul 2026 19:36:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0jB-00056J-HW; Wed, 01 Jul 2026 19:36:09 +0000 Received: by outflank-mailman (input) for mailman id 1350740; Wed, 01 Jul 2026 19:36:08 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3b2tFagYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 1wf0jA-000535-D5 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:36:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0j9-00Bwbb-QG for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:36:07 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3b2tFagYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 6a456c14-5cb7-0a2a0a5109dd-0a2a4505baa4-32 for ; Wed, 01 Jul 2026 21:36:07 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3b2tFagYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 6a456b70-3cb2-0a2a45050019-d155d84ae8e7-3 for ; Wed, 01 Jul 2026 21:33:05 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-37fccad2b01so1710983a91.2 for ; Wed, 01 Jul 2026 12:33:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934383; x=1783539183; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=YK2zVmNLEJoBEawF7PlPSBbbkhRpzdy0apLvLWVt+lo=; b=GfPMSMmuPk3zh8O5e84EIZ6P/vKNB7Eyzg2O/pzTKiZJ5+ulRzUqGZa/OLYHl7XdB5 EKZ7abIj+8dtJJ2qh98qtNXdClw+ERNQLjGUi7NIeqikuiYmznNKa0WkypvEbWKYhq++ r2a9s75lRvNwb7YwVHyvlq44LpvZ7GKKKdHCsr49c21xXvJm16E6wTt9Zh9ogft4ty4I ItJov+7e1/dYoO1A+M3nbuz5ONeWGQt/aQscE1TRPDlZnKBOdO5SnWmCQtTmGLLsgxeJ ozpyJCFJLQ99ybhoiGWHRpxH6sckAF5WHfViZfxFcsxmtTZNBYWMUwWBetNA0zBjSBqY x54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934383; x=1783539183; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YK2zVmNLEJoBEawF7PlPSBbbkhRpzdy0apLvLWVt+lo=; b=WSAcXYIeSdEVYhKY+uGGhocrUuqskQIvJn07RYO/mdBIFyEJmDezVGHx72l/g+k+/c FDHE+nTSShGSkh4Chh9Dn+OSYBPeoLoypoctrDe1baZQrmqiZz/WkFvc0Jz0thWr//oI pZjHpT8KbWW6VQNFTOros/vRsURHEksg3AGYBdUEhBZ4F8QUZbp/u14M0d1GI9fA0Drd OMHtFwdLcH9YElQtTxDZGLR/41PaiX0iCC/qEBmACwZNY8ulcRbJc7Qz4OVRDHieIQCV MATnlQh5hlABEtZONO+LHQlSrrjIs+/4DDfZOFUWo9xMdp1LmIHfOq+i9mizpcVfES48 Bh+g== X-Forwarded-Encrypted: i=1; AFNElJ9HhiwmbRhvuJUlzwLs8YKy2CJPOcDVSWMOcaIhTVBjGo3qYB98CVA/VwZdl8horqq25gwPfhv9AZ4=@lists.xenproject.org X-Gm-Message-State: AOJu0YyeSCV+jVNKfLKoJqTOfSCQHcX552R3klRFWmTBt5zh7msYKhgb kkLwbrPq+la3pNSZNZWJRjmfGh+49J0lFdnP994tHKsIrgO1ah8+SaEetcavxImj8fMtO9z8/Ou SN0Y3Qg== X-Received: from pgwa6.prod.google.com ([2002:a65:6546:0:b0:c99:cbb4:1dcb]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:a11b:b0:3b2:924c:567d with SMTP id adf61e73a8af0-3bff42bedd3mr2415279637.46.1782934383031; Wed, 01 Jul 2026 12:33:03 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:50 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-30-seanjc@google.com> Subject: [PATCH v5 29/51] x86/kvm: Don't disable kvmclock on BSP in syscore_suspend() From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c201ff/1782934385-169102B8-DC817DCC/13/0 X-purgate-type: clean X-purgate-size: 5417 Don't disable kvmclock on the BSP during syscore_suspend(), as the BSP's clock is NOT restored during syscore_resume(), but is instead restored earlier via the sched_clock restore callback. If suspend is aborted, e.g. due to a late wakeup, the BSP will run without its clock enabled, which "works" only because KVM-the-hypervisor is kind enough to not clobber the shared memory when the clock is disabled. But over time, the BSP's view of time will drift from APs. Plumb in an "action" to KVM-as-a-guest and kvmclock code in preparation for additional cleanups to kvmclock's suspend/resume logic. Fixes: c02027b5742b ("x86/kvm: Disable kvmclock on all CPUs on shutdown") Cc: stable@vger.kernel.org Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_para.h | 8 +++++++- arch/x86/kernel/kvm.c | 15 ++++++++------- arch/x86/kernel/kvmclock.c | 31 +++++++++++++++++++++++++------ 3 files changed, 40 insertions(+), 14 deletions(-) diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h index 4a49fc286b4c..08686ff19caa 100644 --- a/arch/x86/include/asm/kvm_para.h +++ b/arch/x86/include/asm/kvm_para.h @@ -118,8 +118,14 @@ static inline long kvm_sev_hypercall3(unsigned int nr, unsigned long p1, } #ifdef CONFIG_KVM_GUEST +enum kvm_guest_cpu_action { + KVM_GUEST_BSP_SUSPEND, + KVM_GUEST_AP_OFFLINE, + KVM_GUEST_SHUTDOWN, +}; + void kvmclock_init(bool prefer_tsc); -void kvmclock_disable(void); +void kvmclock_cpu_action(enum kvm_guest_cpu_action action); bool kvm_para_available(void); unsigned int kvm_arch_para_features(void); unsigned int kvm_arch_para_hints(void); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 6c7011ff7bd1..604b52f233aa 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -460,7 +460,7 @@ static void __init sev_map_percpu_data(void) } } -static void kvm_guest_cpu_offline(bool shutdown) +static void kvm_guest_cpu_offline(enum kvm_guest_cpu_action action) { kvm_disable_steal_time(); if (kvm_para_has_feature(KVM_FEATURE_PV_EOI)) @@ -468,9 +468,10 @@ static void kvm_guest_cpu_offline(bool shutdown) if (kvm_para_has_feature(KVM_FEATURE_MIGRATION_CONTROL)) wrmsrq(MSR_KVM_MIGRATION_CONTROL, 0); kvm_pv_disable_apf(); - if (!shutdown) + if (action != KVM_GUEST_SHUTDOWN) apf_task_wake_all(); - kvmclock_disable(); + + kvmclock_cpu_action(action); } static int kvm_cpu_online(unsigned int cpu) @@ -726,7 +727,7 @@ static int kvm_cpu_down_prepare(unsigned int cpu) unsigned long flags; local_irq_save(flags); - kvm_guest_cpu_offline(false); + kvm_guest_cpu_offline(KVM_GUEST_AP_OFFLINE); local_irq_restore(flags); return 0; } @@ -737,7 +738,7 @@ static int kvm_suspend(void *data) { u64 val = 0; - kvm_guest_cpu_offline(false); + kvm_guest_cpu_offline(KVM_GUEST_BSP_SUSPEND); #ifdef CONFIG_ARCH_CPUIDLE_HALTPOLL if (kvm_para_has_feature(KVM_FEATURE_POLL_CONTROL)) @@ -768,7 +769,7 @@ static struct syscore kvm_syscore = { static void kvm_pv_guest_cpu_reboot(void *unused) { - kvm_guest_cpu_offline(true); + kvm_guest_cpu_offline(KVM_GUEST_SHUTDOWN); } static int kvm_pv_reboot_notify(struct notifier_block *nb, @@ -792,7 +793,7 @@ static struct notifier_block kvm_pv_reboot_nb = { #ifdef CONFIG_CRASH_DUMP static void kvm_crash_shutdown(struct pt_regs *regs) { - kvm_guest_cpu_offline(true); + kvm_guest_cpu_offline(KVM_GUEST_SHUTDOWN); native_machine_crash_shutdown(regs); } #endif diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index b0c871ba8232..a3ec298d56d7 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -199,8 +199,22 @@ static void kvm_register_clock(char *txt) pr_debug("kvm-clock: cpu %d, msr %llx, %s", smp_processor_id(), pa, txt); } +static void kvmclock_disable(void) +{ + if (msr_kvm_system_time) + native_write_msr(msr_kvm_system_time, 0); +} + static void kvm_save_sched_clock_state(void) { + /* + * Stop host writes to kvmclock immediately prior to suspend/hibernate. + * If the system is hibernating, then kvmclock will likely reside at a + * different physical address when the system awakens, and host writes + * to the old address prior to reconfiguring kvmclock would clobber + * random memory. + */ + kvmclock_disable(); } static void kvm_restore_sched_clock_state(void) @@ -208,6 +222,17 @@ static void kvm_restore_sched_clock_state(void) kvm_register_clock("primary cpu clock, resume"); } +void kvmclock_cpu_action(enum kvm_guest_cpu_action action) +{ + /* + * Don't disable kvmclock on the BSP during suspend. If kvmclock is + * being used for sched_clock, then it needs to be kept alive until the + * last minute, and restored as quickly as possible after resume. + */ + if (action != KVM_GUEST_BSP_SUSPEND) + kvmclock_disable(); +} + #ifdef CONFIG_SMP static void kvm_setup_secondary_clock(void) { @@ -215,12 +240,6 @@ static void kvm_setup_secondary_clock(void) } #endif -void kvmclock_disable(void) -{ - if (msr_kvm_system_time) - native_write_msr(msr_kvm_system_time, 0); -} - static void __init kvmclock_init_mem(void) { unsigned long ncpus; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:36:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:36:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350741.1608258 (Exim 4.92) (envelope-from ) id 1wf0jD-0005Le-TS; Wed, 01 Jul 2026 19:36:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350741.1608258; Wed, 01 Jul 2026 19:36:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0jD-0005LU-Pq; Wed, 01 Jul 2026 19:36:11 +0000 Received: by outflank-mailman (input) for mailman id 1350741; Wed, 01 Jul 2026 19:36:09 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3cmtFagYKCbcpbXkgZdlldib.Zljubk-absbiifpqp.ubkmolgbZq.lod@flex--seanjc.bounces.google.com>) id 1wf0jB-00056Q-ON for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:36:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0jB-00Bwg5-55 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:36:09 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3cmtFagYKCbcpbXkgZdlldib.Zljubk-absbiifpqp.ubkmolgbZq.lod@flex--seanjc.bounces.google.com>) id 6a456c00-5cb7-0a2a0a5109dd-0a2a4506ae74-46 for ; Wed, 01 Jul 2026 21:36:09 +0200 Received: from [209.85.216.73] (helo=mail-pj1-f73.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3cmtFagYKCbcpbXkgZdlldib.Zljubk-absbiifpqp.ubkmolgbZq.lod@flex--seanjc.bounces.google.com>) id 6a456b73-08de-0a2a45060019-d155d849b446-3 for ; Wed, 01 Jul 2026 21:33:08 +0200 Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-37e17ec1940so1079273a91.0 for ; Wed, 01 Jul 2026 12:33:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934387; x=1783539187; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=p58sqQbLovUVGNo0nSS6BNMoKcJfer5lPY7RvPBWYyU=; b=m7SSsnLTPrJAscY4pqjevoFfCkG+XkGqrfdH4EEeyG89fXJ4xxX0lArZTmkaZWrXIk CceEHqNV5rNv02FHxTS6FyVtiYny8dKN95OKZJ3JjcQhHz13NIjTBb0zuJpeKE+9O2Nf B7eM3nL4NQA9cUFYOjf769Zaeit+s/GciIJJFfvUc0yewjEdWwlMBs16xBf2PzE7xQ0L me4tvfvenUUIyMptj9ozuqEsomvcQeRZoJzjsJc8Q7pxjXOMN6G8wV+d+1HK0EN9NT4z Nv5MWuVIsNFnihDxH94OxTBG6VG+b081QpUVPnmYNG4hAUg7U5dZ7122U/RzF+BXWwpl o0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934387; x=1783539187; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p58sqQbLovUVGNo0nSS6BNMoKcJfer5lPY7RvPBWYyU=; b=ioiPhuWx4Y/xs95aa7GFaJpm0448Su7u0Eew3FsDscx3xcBT5ScFpPslKLgQqJ62S0 JHVtCTS8Oh93aghz1Kudk3v12QGQ3XtXm9oo1e4+W/s8o6sbl9gsKGC1kr0hLeKdXi6J 5CVVVQA11LnQrYxrQ9xl+2fmYnnm3RW/M1xMR5WjG0djYnqKqHWV5zvIVvPwJjVJ43ne J/fU8fvC1HEgQ4+jKR3MBbsg1EDLtIMjMVhPz0xjjq3xgZI93CL4sViwpv9uWWHibql6 U5w0PbtpflCFEGw6RLx6363T1AywWkOG1zbaB6OD6reSqJ1ing2IrtRltsRgYjKW3eQg kBRg== X-Forwarded-Encrypted: i=1; AHgh+RoVc8bTGChRrZIlltlGX3j9rv8SZZ+A9YuFBGfuIEsBtq9r116eRMlPG/ZjxqhlbgJBDORtV3B0c8U=@lists.xenproject.org X-Gm-Message-State: AOJu0YxvFDEP7M5W0bZK4WgCR2qb98/P2X6DXidhSZ69mci3qwJr/buv EcqJl48rkdpBX1YJhtbF9l7CX05861gGsChYV9WKW8xBgy3bp29jWPZ0xcsaibjca9d4UVuxJ8l gax467Q== X-Received: from pjbco22.prod.google.com ([2002:a17:90a:fe96:b0:36b:7f07:6fcd]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5823:b0:366:3517:1aa2 with SMTP id 98e67ed59e1d1-380a9e519bdmr3237404a91.0.1782934386500; Wed, 01 Jul 2026 12:33:06 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:53 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-33-seanjc@google.com> Subject: [PATCH v5 32/51] x86/kvmclock: Move sched_clock save/restore helpers up in kvmclock.c From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1782934388-C5D3D68D-D4C08C89/13/0 X-purgate-type: clean X-purgate-size: 4424 Move kvmclock's sched_clock save/restore helper "up" so that they can (eventually) be referenced by kvm_sched_clock_init(). No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 108 ++++++++++++++++++------------------- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 4bc0495f1f9e..07e875738c39 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -71,6 +71,25 @@ static int kvm_set_wallclock(const struct timespec64 *now) return -ENODEV; } +static void kvm_register_clock(char *txt) +{ + struct pvclock_vsyscall_time_info *src = this_cpu_hvclock(); + u64 pa; + + if (!src) + return; + + pa = slow_virt_to_phys(&src->pvti) | 0x01ULL; + wrmsrq(msr_kvm_system_time, pa); + pr_debug("kvm-clock: cpu %d, msr %llx, %s", smp_processor_id(), pa, txt); +} + +static void kvmclock_disable(void) +{ + if (msr_kvm_system_time) + native_write_msr(msr_kvm_system_time, 0); +} + static u64 kvm_clock_read(void) { u64 ret; @@ -112,6 +131,30 @@ static noinstr u64 kvm_sched_clock_read(void) return pvclock_clocksource_read_nowd(this_cpu_pvti()) - kvm_sched_clock_offset; } +static void kvm_save_sched_clock_state(void) +{ + /* + * Stop host writes to kvmclock immediately prior to suspend/hibernate. + * If the system is hibernating, then kvmclock will likely reside at a + * different physical address when the system awakens, and host writes + * to the old address prior to reconfiguring kvmclock would clobber + * random memory. + */ + kvmclock_disable(); +} + +#ifdef CONFIG_SMP +static void kvm_setup_secondary_clock(void) +{ + kvm_register_clock("secondary cpu clock"); +} +#endif + +static void kvm_restore_sched_clock_state(void) +{ + kvm_register_clock("primary cpu clock, resume"); +} + static inline void kvm_sched_clock_init(bool stable) { kvm_sched_clock_offset = kvm_clock_read(); @@ -124,6 +167,17 @@ static inline void kvm_sched_clock_init(bool stable) sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); } +void kvmclock_cpu_action(enum kvm_guest_cpu_action action) +{ + /* + * Don't disable kvmclock on the BSP during suspend. If kvmclock is + * being used for sched_clock, then it needs to be kept alive until the + * last minute, and restored as quickly as possible after resume. + */ + if (action != KVM_GUEST_BSP_SUSPEND) + kvmclock_disable(); +} + /* * If we don't do that, there is the possibility that the guest * will calibrate under heavy load - thus, getting a lower lpj - @@ -183,60 +237,6 @@ static struct clocksource kvm_clock = { .enable = kvm_cs_enable, }; -static void kvm_register_clock(char *txt) -{ - struct pvclock_vsyscall_time_info *src = this_cpu_hvclock(); - u64 pa; - - if (!src) - return; - - pa = slow_virt_to_phys(&src->pvti) | 0x01ULL; - wrmsrq(msr_kvm_system_time, pa); - pr_debug("kvm-clock: cpu %d, msr %llx, %s", smp_processor_id(), pa, txt); -} - -static void kvmclock_disable(void) -{ - if (msr_kvm_system_time) - native_write_msr(msr_kvm_system_time, 0); -} - -static void kvm_save_sched_clock_state(void) -{ - /* - * Stop host writes to kvmclock immediately prior to suspend/hibernate. - * If the system is hibernating, then kvmclock will likely reside at a - * different physical address when the system awakens, and host writes - * to the old address prior to reconfiguring kvmclock would clobber - * random memory. - */ - kvmclock_disable(); -} - -static void kvm_restore_sched_clock_state(void) -{ - kvm_register_clock("primary cpu clock, resume"); -} - -void kvmclock_cpu_action(enum kvm_guest_cpu_action action) -{ - /* - * Don't disable kvmclock on the BSP during suspend. If kvmclock is - * being used for sched_clock, then it needs to be kept alive until the - * last minute, and restored as quickly as possible after resume. - */ - if (action != KVM_GUEST_BSP_SUSPEND) - kvmclock_disable(); -} - -#ifdef CONFIG_SMP -static void kvm_setup_secondary_clock(void) -{ - kvm_register_clock("secondary cpu clock"); -} -#endif - static void __init kvmclock_init_mem(void) { unsigned long ncpus; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:36:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:36:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350745.1608266 (Exim 4.92) (envelope-from ) id 1wf0jI-0005hb-4p; Wed, 01 Jul 2026 19:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350745.1608266; Wed, 01 Jul 2026 19:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf0jI-0005hU-1y; Wed, 01 Jul 2026 19:36:16 +0000 Received: by outflank-mailman (input) for mailman id 1350745; Wed, 01 Jul 2026 19:36:15 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3eGtFagYKCb0vhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 1wf0jH-0005gb-FF for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:36:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf0jG-003oa2-SK for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:36:14 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3eGtFagYKCb0vhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 6a456bfe-bab6-0a2a0a5309dd-0a2a4509b1ae-44 for ; Wed, 01 Jul 2026 21:36:14 +0200 Received: from [209.85.216.74] (helo=mail-pj1-f74.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3eGtFagYKCb0vhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 6a456b79-97e6-0a2a45090019-d155d84ad47a-3 for ; Wed, 01 Jul 2026 21:33:14 +0200 Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-37e24235ce1so1374668a91.0 for ; Wed, 01 Jul 2026 12:33:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782934393; x=1783539193; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=aK5m/cPAf0bdBYumbExr1aJO4L8QPhhYatB0l9CbU30=; b=RFJGBZma1fonKwjoMQxVhpEy/UOIMSO+s32U36rMVRqgLIFF6HYhxZ4V4DfgMc3HIZ 8jX8ccc07Xo21pk5b39hL/z+fpammNwoWws7RFiKLMbaGXLV9WbW6lFbj9T59+oPXJYt C0K/VZEJD2NZqBuHG1LWIJTgz7BHgnobobm0ycIYesMFY5sk4PYFvzjDt/RHVK9msifi m3J8izuHSyH5ipo08L5wFyytZmH8ciI7jtU/PE1aPHgwJ/c3IwpFdXutRP4hPANMyMWE 82Q9HrgqdW15Pt4ShQ0Krbrw32ig+WQpblxNGmvIkJLxycG8qekLmy6rSQJiyAXGwseb Ouvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782934393; x=1783539193; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aK5m/cPAf0bdBYumbExr1aJO4L8QPhhYatB0l9CbU30=; b=Ih6dRLR4lQi9xbmnEzq/AlmxJERs7CygcVsJ/OkyUoffuoBMSUuSnSEFwfqMiupWAM F/qxdU14KgjgLYWjnP9ttspmg4nz5s6LsQ2nWyh8veYry7ure74MJsLdlbgSKw2jdo/w c0SKntYp9ChCEmqScIbb0HSg4K0aXhiKExdW0i2clWqTS/F9A+dvNCvIirfuy5qFsvF3 8k/LakuG20ejjywoPvOa8+88cFHsEBlo0IOUZfC/69YNzprVB9np8hHy3+5XBlSqmMXK FHLZUI9tRZWn3z7hB9ufVXcpJOuQMGxMMQpFnJgQX/bIO+hs9PZf6vGPq9f3/xrNsiSf d7Fg== X-Forwarded-Encrypted: i=1; AHgh+RrKPTvC8jPaTy6gS+tNvsTEmUXEnO/KZSUEnHztOUWsJWjotX9I8vUj3nLYi4IHbKy8hW2TAMSNADI=@lists.xenproject.org X-Gm-Message-State: AOJu0YweOnfzrwzy7IvxAEA2xIIUD4nD+G6Q2pERbZCrq7yJg/IAbLu4 zMT+1fZHLMwG2G4dg/QHDFkAq+mYk7HLULW8KIeu11qAWF8ixT5a/LZiuYG0B0AmWtqzqGuWN3X 57yLiJQ== X-Received: from pjbil4.prod.google.com ([2002:a17:90b:1644:b0:37d:ece0:dd38]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3810:b0:37f:9ce1:cdaf with SMTP id 98e67ed59e1d1-380aa1ed882mr2896319a91.29.1782934392117; Wed, 01 Jul 2026 12:33:12 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 1 Jul 2026 12:31:58 -0700 In-Reply-To: <20260701193212.749551-1-seanjc@google.com> Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701193212.749551-38-seanjc@google.com> Subject: [PATCH v5 37/51] x86/kvmclock: Move kvm_sched_clock_init() down in kvmclock.c From: Sean Christopherson To: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz Cc: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1782934394-45B23986-928943A0/13/0 X-purgate-type: clean X-purgate-size: 2301 Move kvm_sched_clock_init() "down" so that it can reference the global kvm_clock structure without needing a forward declaration. Opportunistically mark the helper as "__init" instead of "inline" to make its usage more obvious; modern compilers don't need a hint to inline a single-use function, and an extra CALL+RET pair during boot is a complete non-issue. And, if the compiler ignores the hint and does NOT inline the function, the resulting code may not get discarded after boot due lack of an __init annotation. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 5b9955343199..5220d205abc7 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -155,20 +155,6 @@ static void kvm_restore_sched_clock_state(void) kvm_register_clock("primary cpu clock, resume"); } -static inline void kvm_sched_clock_init(bool stable) -{ - kvm_sched_clock_offset = kvm_clock_read(); - __paravirt_set_sched_clock(kvm_sched_clock_read, stable, - kvm_save_sched_clock_state, - kvm_restore_sched_clock_state); - - pr_info("kvm-clock: using sched offset of %llu cycles", - kvm_sched_clock_offset); - - BUILD_BUG_ON(sizeof(kvm_sched_clock_offset) > - sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); -} - void kvmclock_cpu_action(enum kvm_guest_cpu_action action) { /* @@ -325,6 +311,20 @@ static int kvmclock_setup_percpu(unsigned int cpu) return p ? 0 : -ENOMEM; } +static __init void kvm_sched_clock_init(bool stable) +{ + kvm_sched_clock_offset = kvm_clock_read(); + __paravirt_set_sched_clock(kvm_sched_clock_read, stable, + kvm_save_sched_clock_state, + kvm_restore_sched_clock_state); + + pr_info("kvm-clock: using sched offset of %llu cycles", + kvm_sched_clock_offset); + + BUILD_BUG_ON(sizeof(kvm_sched_clock_offset) > + sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); +} + void __init kvmclock_init(bool prefer_tsc) { u8 flags; -- 2.55.0.rc0.799.gd6f94ed593-goog From xen-devel-bounces@lists.xenproject.org Wed Jul 01 19:58:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 19:58:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350841.1608275 (Exim 4.92) (envelope-from ) id 1wf14w-0001jx-0r; Wed, 01 Jul 2026 19:58:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350841.1608275; Wed, 01 Jul 2026 19:58:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf14v-0001jq-UH; Wed, 01 Jul 2026 19:58:37 +0000 Received: by outflank-mailman (input) for mailman id 1350841; Wed, 01 Jul 2026 19:58:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf14r-0001gD-T9 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 19:58:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf14r-005T2x-AB for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:58:33 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a457164-5cb7-0a2a0a5109dd-0a2a4505c012-6 for ; Wed, 01 Jul 2026 21:58:31 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a457166-3cb2-0a2a45050019-d561b338bf32-3 for ; Wed, 01 Jul 2026 21:58:30 +0200 Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine2.igalia.com with esmtps (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf14K-007jBt-Bw; Wed, 01 Jul 2026 21:58:00 +0200 Received: from webmail.service.igalia.com ([192.168.21.45]) by mail.igalia.com with esmtp (Exim) id 1wf14I-008PZ7-7c; Wed, 01 Jul 2026 21:58:00 +0200 Received: from localhost ([127.0.0.1] helo=webmail.igalia.com) by webmail.service.igalia.com with esmtp (Exim 4.98.2) (envelope-from ) id 1wf14I-0000000DrOF-026U; Wed, 01 Jul 2026 21:57:58 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Content-Transfer-Encoding:Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date:MIME-Version" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dVUHDiCCPenmpG77txOrHpZNog3IAMhNPv3S4y6Xv3I=; b=OqayeKvT0MXw8cB8Ns1EfUMh7J s9QSbqteOd0Zwx51NK2xKTgD/wxJoiuRr/zNDkqCUC+FpqsfJwDrlZDZiWZOCmvru6uekZtL1/ads qVqnNAidpHDdmgxhVZuojnbw7BfuDxTdYLrU5A5B8Pv1yfvUq+rFUnxyfzWEZgc+8fWR78Es4+mSC sFR22dLv8h7lEIAyxZpcucX6Kjw/TB31ckB2tcea+6rawvSF8Qtmcpbirc0zdevzK/tp6p1GU+h5h bIVtLs+PEr+QGcADMLMHx15QUNWgB/s+7TnIgfpPA1y43dYTpGdgkI/+slYgRKJIGRyUCg206mH5t Eor31ldg==; MIME-Version: 1.0 Date: Wed, 01 Jul 2026 16:57:57 -0300 From: Mauricio Faria de Oliveira To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp In-Reply-To: <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> Message-ID: X-Sender: mfo@igalia.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Report: NO, Score=-4.7, Tests=ALL_TRUSTED=-3,AWL=-2.551,BAYES_50=0.8,URIBL_BLOCKED=0.001,URIBL_DBL_BLOCKED_OPENDNS=0.001,URIBL_ZEN_BLOCKED_OPENDNS=0.001 X-Spam-Score: -46 X-Spam-Bar: ---- X-purgate-ID: tlsNG-c201ff/1782935911-17D1E2B8-C361D11E/0/0 X-purgate-type: clean X-purgate-size: 2816 Thanks for looking at this again. On 2026-07-01 15:40, Borislav Petkov wrote: > On Tue, Jun 30, 2026 at 02:21:46PM -0300, Mauricio Faria de Oliveira wrote: >> Move the inline memcmp function currently only available in 'boot/string.c' >> into the shared string function header to be reused. >> >> This is not done through to avoid pulling unnecessary code >> in 'boot/string.c' that causes build errors in 'boot/compressed/string.c' >> and 'purgatory/purgatory.ro'. >> >> Note that the inline memcmp() returns 0/1, not -1/0/1 as regular memcmp() >> (reported by David Laight ). > > This belongs ... > > >> >> Signed-off-by: Mauricio Faria de Oliveira >> --- > > ... here, if anywhere. I'm not sure, as Reported-by and Suggested-by mean something different. Maybe a simpler statement would do? e.g., '(Thanks to David Laight for noticing the return value difference between inline and regular memcmp())'. That gives credit while avoiding confusion with tags. > >> arch/x86/boot/string.c | 6 ++---- >> arch/x86/include/asm/shared/string.h | 16 ++++++++++++++++ >> arch/x86/include/asm/string.h | 1 + >> 3 files changed, 19 insertions(+), 4 deletions(-) > > Also, PeterZ has a point - we should group all __inline_ functions into > shared/string.h and say why that is the case at the top of the header. Ok. >> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c >> index ac0f900ebc47efa81c92e1bb2010ea41677899c4..be454a6864225f3a972c3e81826b77ed4e8a57fe 100644 >> --- a/arch/x86/boot/string.c >> +++ b/arch/x86/boot/string.c >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include >> #include "ctype.h" >> #include "string.h" >> >> @@ -31,10 +32,7 @@ >> >> int memcmp(const void *s1, const void *s2, size_t len) >> { >> - bool diff; >> - asm("repe cmpsb" >> - : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); >> - return diff; >> + return __inline_memcmp(s1, s2, len); >> } >> >> /* >> diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h >> new file mode 100644 >> index 0000000000000000000000000000000000000000..422952152f533ad75b98f3873297b39c4f5e2477 >> --- /dev/null >> +++ b/arch/x86/include/asm/shared/string.h >> @@ -0,0 +1,16 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef _ASM_X86_SHARED_STRING_H >> +#define _ASM_X86_SHARED_STRING_H >> + >> +/* Note: this memcmp() returns 0/1, not -1/0/1 as regular memcmp(). */ > > Please document it properly - what does 0 mean as a return value and what 1. Ok. cheers, > > Thx. -- Mauricio From xen-devel-bounces@lists.xenproject.org Wed Jul 01 20:03:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 20:03:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350852.1608284 (Exim 4.92) (envelope-from ) id 1wf19h-0005g0-Hi; Wed, 01 Jul 2026 20:03:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350852.1608284; Wed, 01 Jul 2026 20:03:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf19h-0005fs-Eo; Wed, 01 Jul 2026 20:03:33 +0000 Received: by outflank-mailman (input) for mailman id 1350852; Wed, 01 Jul 2026 20:03:31 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf19f-0005dR-TJ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 20:03:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf19f-003doP-6H for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 22:03:31 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a457292-bab6-0a2a0a5309dd-0a2a4501c7e4-0 for ; Wed, 01 Jul 2026 22:03:30 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a457292-400f-0a2a45010019-d561b33887a6-3 for ; Wed, 01 Jul 2026 22:03:30 +0200 Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine2.igalia.com with esmtps (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf19G-007jIE-GQ; Wed, 01 Jul 2026 22:03:06 +0200 Received: from webmail.service.igalia.com ([192.168.21.45]) by mail.igalia.com with esmtp (Exim) id 1wf19E-008PvG-Bh; Wed, 01 Jul 2026 22:03:06 +0200 Received: from localhost ([127.0.0.1] helo=webmail.igalia.com) by webmail.service.igalia.com with esmtp (Exim 4.98.2) (envelope-from ) id 1wf19E-0000000DrRf-0aWf; Wed, 01 Jul 2026 22:03:04 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Content-Transfer-Encoding:Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date:MIME-Version" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h8lMXBcYlOyRE4pQKie/bg8QzKCuakYmyioerwHH1+M=; b=eXh1+rNK/Agog1Cz9/pcvxMMW9 sokenI9OuaFH9ZytFg5ZjyaJb9ougXQkL1fK0EnDBBYg+As7+DktzNVpksHIjBLtYNE3tciRfdB+J smM6qRWJljDWQgB7Aru2gemMvxXuBjar+KMOm0Qlvya6KdDj26dKF52iVQUFGtXtH4ho1uvxfx98u NMgN6oI8Qj704OXcOvEBXc6LMDalNRKcCTEpuT3DTLaNJoVZbUcOYciV7ESsTdmVPyyk8hLoRpaLX rGE/oMpiw9F06Rz+hwRNdaL0p34gLprKVUN6E5ZSAB/0E5+U2pipMQNYsusK7IiwU4DKj9gpYrddg Sx4pRuzQ==; MIME-Version: 1.0 Date: Wed, 01 Jul 2026 17:03:04 -0300 From: Mauricio Faria de Oliveira To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp In-Reply-To: References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> Message-ID: X-Sender: mfo@igalia.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Report: NO, Score=-4.7, Tests=ALL_TRUSTED=-3,AWL=-2.551,BAYES_50=0.8,URIBL_BLOCKED=0.001,URIBL_DBL_BLOCKED_OPENDNS=0.001,URIBL_ZEN_BLOCKED_OPENDNS=0.001 X-Spam-Score: -46 X-Spam-Bar: ---- X-purgate-ID: tlsNG-d62444/1782936210-D04D51E0-18ADB142/0/0 X-purgate-type: clean X-purgate-size: 3118 On 2026-07-01 16:57, Mauricio Faria de Oliveira wrote: > Thanks for looking at this again. > > On 2026-07-01 15:40, Borislav Petkov wrote: >> On Tue, Jun 30, 2026 at 02:21:46PM -0300, Mauricio Faria de Oliveira wrote: >>> Move the inline memcmp function currently only available in 'boot/string.c' >>> into the shared string function header to be reused. >>> >>> This is not done through to avoid pulling unnecessary code >>> in 'boot/string.c' that causes build errors in 'boot/compressed/string.c' >>> and 'purgatory/purgatory.ro'. >>> >>> Note that the inline memcmp() returns 0/1, not -1/0/1 as regular memcmp() >>> (reported by David Laight ). >> >> This belongs ... >> >> >>> >>> Signed-off-by: Mauricio Faria de Oliveira >>> --- >> >> ... here, if anywhere. > > I'm not sure, as Reported-by and Suggested-by mean something different. > Oops, I missed the triple dash in your comment. That would discard the credit attribution when applied, AFAIK. So, still: > Maybe a simpler statement would do? e.g., '(Thanks to David Laight for > noticing the return value difference between inline and regular > memcmp())'. That gives credit while avoiding confusion with tags. Thanks, > >> >>> arch/x86/boot/string.c | 6 ++---- >>> arch/x86/include/asm/shared/string.h | 16 ++++++++++++++++ >>> arch/x86/include/asm/string.h | 1 + >>> 3 files changed, 19 insertions(+), 4 deletions(-) >> >> Also, PeterZ has a point - we should group all __inline_ functions into >> shared/string.h and say why that is the case at the top of the header. > > Ok. > >>> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c >>> index ac0f900ebc47efa81c92e1bb2010ea41677899c4..be454a6864225f3a972c3e81826b77ed4e8a57fe 100644 >>> --- a/arch/x86/boot/string.c >>> +++ b/arch/x86/boot/string.c >>> @@ -15,6 +15,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include "ctype.h" >>> #include "string.h" >>> >>> @@ -31,10 +32,7 @@ >>> >>> int memcmp(const void *s1, const void *s2, size_t len) >>> { >>> - bool diff; >>> - asm("repe cmpsb" >>> - : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); >>> - return diff; >>> + return __inline_memcmp(s1, s2, len); >>> } >>> >>> /* >>> diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..422952152f533ad75b98f3873297b39c4f5e2477 >>> --- /dev/null >>> +++ b/arch/x86/include/asm/shared/string.h >>> @@ -0,0 +1,16 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +#ifndef _ASM_X86_SHARED_STRING_H >>> +#define _ASM_X86_SHARED_STRING_H >>> + >>> +/* Note: this memcmp() returns 0/1, not -1/0/1 as regular memcmp(). */ >> >> Please document it properly - what does 0 mean as a return value and what 1. > > Ok. > > cheers, > >> >> Thx. -- Mauricio From xen-devel-bounces@lists.xenproject.org Wed Jul 01 20:28:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 20:28:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350888.1608294 (Exim 4.92) (envelope-from ) id 1wf1Y4-0006lj-Dg; Wed, 01 Jul 2026 20:28:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350888.1608294; Wed, 01 Jul 2026 20:28:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf1Y4-0006lc-Ai; Wed, 01 Jul 2026 20:28:44 +0000 Received: by outflank-mailman (input) for mailman id 1350888; Wed, 01 Jul 2026 20:28:42 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf1Y1-0006i3-QZ for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 20:28:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf1Y0-00BCNG-W7 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 22:28:41 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a457834-5cb7-0a2a0a5109dd-0a2a4505b3fa-38 for ; Wed, 01 Jul 2026 22:28:40 +0200 Received: from [40.107.74.122] (helo=OS0P286CU010.outbound.protection.outlook.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a457874-3cb2-0a2a45050019-286b4a7a2c73-3 for ; Wed, 01 Jul 2026 22:28:38 +0200 Received: from TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:363::12) by TY7P286MB6868.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:31e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 1 Jul 2026 20:28:33 +0000 Received: from TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM ([fe80::9caa:1ff:d16c:e15f]) by TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM ([fe80::9caa:1ff:d16c:e15f%3]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 20:28:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xjZn1xJWkSpz7WVskK1qVrCYlisHDPeFPWvt66lf4pB3++KW0z1g6sDTXiJZIWt1MzLugKPEj0gSDXzEBqo0xwwvRVwtOlOX5faHEnlRMyrSVgQ7icMAjFyfIOD9mGHPE2/fA470zbe9S08+SEECXk/bleL3xGbNNvEvFps5Lbbn8AqmEo2eZnnChexP3dqOmqNmew10su/PuUKU6LeKHnVnjwGaG56OBi94OqZy4Bca42mI2goTWWAeQVa+1WmIS/3H4HJG1yKWd4o+Rjf7QIIDy5D2tQC7Y6StQEOFa1ocQOjE7hCXHJfm0XMlvWBLLKnckaA56mlmnAF2mUInoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZS228F3QXeflNqzA5oshsUqALsaBJFHT4qC4wRbMdFw=; b=hG8xEOyLj5+1sFRCAS6wuCYa+5x87szN5phhEI32OVWECNgHqRHDt6qrAokpNOgYO8W+Z5mBPS8vrLoQBXxRCR4+Te/JQ0KdONaPtYZlLkVAgzPXN/81WsrIwlTvUOHPbo1RYfPGNFMhqo/wTjokE3DlpCnJ9KeN7mZsRujuw8nIK65z66x/KMJUKdKwsZsLcswX2YDGuaedoQMN5yLaMe28ylTCyfJriI+9ulkRI88fL+6efCagNQLOTLh3GkuGFqJRVFj68IbHYpjOkr4NPDtvwfhX3kvXRA2qdJNOtGlxFP8PcHhEzWtZvq8U3EYdb6pN8ntz59WrOIP4atHUbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZS228F3QXeflNqzA5oshsUqALsaBJFHT4qC4wRbMdFw=; b=Op7I9dWOVaQNW5as2Ii8+swXU2BGuy/DjrpoXMuOg5L0s1EXybKwNFrq8AFqZ5RiNxrgf4ihiDYm4u0G8jTRH9pMl/rrcyiQ2pfLPy73kzXhVxvCt0POJfgLOyBBN8AM5pZHvkJSlXoJYp0joWxJpPpp4fMC+sGE1C5edD+VlAY= From: Hirokazu Takahashi To: Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Thread-Topic: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Thread-Index: AQHdCBJguMZzJpb/JEe22XtErI4LcbZWqjWAgAHISeCAABufgIAAi7BQ Date: Wed, 1 Jul 2026 20:28:33 +0000 Message-ID: References: <20260629215806.11610-1-taka@valinux.co.jp> <20260629215806.11610-2-taka@valinux.co.jp> <97dd9fd5-c0de-4125-a40a-b7f6e1aed27d@suse.com> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY7P286MB7234:EE_|TY7P286MB6868:EE_ x-ms-office365-filtering-correlation-id: 091419fe-5b5c-4080-8f46-08ded7af5232 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|7416014|366016|376014|23010399003|18002099003|38070700021|56012099006|4143699003|22082099003; x-microsoft-antispam-message-info: 2zlWeQgIKBiBOlmuLs7zT0VBP1IVjymx4plA/oTpWHXAPdlWtPM74273HxHBIxjRVEqs7Adx0ZYpxzR3VtC8rSFcjlXPre9P7FwY+DcH1B/oUWuhv9jUdu9lYXFlbaTKTaQUFtrRjvuPRTN4mQqlQTpvMljUPWLo1fmnkhbXAs8XnhpIyBbR4LyKJQGmeAjr3/0FSvF8AhdeIBFLxmqVELeNJcyuvjZ/P7lL5BmATatPao6EwF8gRy2couHpWjubDRFCtVIjj7l+n4ph5U+OpmQ/ZPf1eQgsI6UHLiA4cWbRGyFoogxHBB5x7z8MftCb9YGCpuy5vxa0WHFqhYGYJjEAew9Af67ctY90ydi5axJ6QphIn6iBITcMWh5bGL4/x0aO27CqNXSBK4BgVS8j/cGJMj+XDNykW/pm1qkxV1/KvKnnPbXdbqur7OmHpww+Td0WaQvCTPVeIHbvHbM7eJpRzXASOtz/RBtMl5itqKQ0tEXCp0obABcNCCKH0TJG60pKVakHr9pp6hwDKtzbPet9YiGjQUyU+B6bDjTgz3M26kQH+Tuz4mf+8oj9cVY4685spMVVB7Iq8XyywTB1urZFAC5JK1/etMOKK0jeV0+3qv1yMRKz9zA+oKu1T55aIXy3Y+hXwRX7D9FI80S4Q0bcW31cYE1vMRMiJcSCiB3+abqKvfc2SfRwOXJgdtYcljflVgVJ+8/r4P3OCyPO7M88u55OzOxA9AMkQyhkTGs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(366016)(376014)(23010399003)(18002099003)(38070700021)(56012099006)(4143699003)(22082099003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NGlrWnhTaGMzY0J3bSttcUFNWk9MV090dTF2d0l6ZzhIOVpuaGFYTUdCaVUv?= =?utf-8?B?REtRdjBTNzNkQzRYSC91cjE5ZUI2YzRHVkYva3BBbEY2eldCZUcwb1JJaW5G?= =?utf-8?B?U2ZzNG5xcDdFam9xRmZnZWZpNTFXMi8xOXNWbUhkQlhqWXU2R1hOV3dzT2Rn?= =?utf-8?B?SHhTQlJ6UnJFQVRwSG5WbnA2NVVERnNTZkg1N2tWM1o1K01ERUUvRUR5VWY2?= =?utf-8?B?WVdHbzRoMzlwRmpCTWhoemhZd2RNQytWdE5WcTJTVUpQSHpVcVczL2V5OG41?= =?utf-8?B?d3pPaTUrSS85QkxTcUtHSmNtS2RNT3lNOEJBMGxqMzQ0Y1JleUdPOWxuTWYr?= =?utf-8?B?S1Qranc2bXRhdXpxTk4wQnFoTWYvQk5SUjd0L04zRmFmQ3Q3ZjU5VFRWWVlL?= =?utf-8?B?WWN4aVlNbUVOQ3Z3R29Bam96WVZxMTNEVnlBVnpUb3U0ZnNkVmxRa3krRVRn?= =?utf-8?B?OTlpbU1pSEdmdGVweVNqcWRETmg5TXpueFEvdkR6MVZUT1dIaU9adTVHTFk1?= =?utf-8?B?WVdmUUZZR0lqRG5hUHdPcUlOVENSNitWN3JtRDFqWTF4T2RsTmppUFRiUWhu?= =?utf-8?B?Mml5d1hMak9ZMmhiN2VjdkgxdjBlWjROZUZOTWRDTFFGTmQyL0V3eWZmWTY4?= =?utf-8?B?RU9JaVFocCtCZ05WSms4TEo0dUxDQW1RcHZmVGZDSkpxTHluUERGUkhjOExZ?= =?utf-8?B?S2k2YldFTmtBajFiZ3FrYy9tNXVRanF1eFoxdm14YkZPM2dob3NEL0NxYzQv?= =?utf-8?B?bzBpdU5Ob0Q4UCs0TmdqVGdsejRNQUNubXRTNlU2OVMwNHRJcy9VTnJLNmdS?= =?utf-8?B?TEJneU1CUDJoK3hqcjRMK0lIL0JZbFZqTVFkWG1DTHgxVWhZOHczLy9YY0ky?= =?utf-8?B?d3VNM3RLcnhJS0hpc0hWNEpYbWUzdjJkODJlVmxHWkF1ODhWQ1U2NUY0K29k?= =?utf-8?B?MHo5a1FGNE9CSGNOcERQbmZHRjNJZGVabWxFdmRlU3FyUGZyemdHVjBQbVJs?= =?utf-8?B?NHZYK0c3ZXM4OFZ4UjNoTzArRWFmR3NNV2h1Mld5bW5Sd1J6N21KazlhZG10?= =?utf-8?B?RnBoZUNhVDZkSEx3TWxNUitLeHd0aXY2TlZ4NkZPSFFSaUJrTHljRVVTeGZF?= =?utf-8?B?VktEd0UrRXMyN3pKa2FpZ01VMXhxZGJqdTkxcVYrZXB6SmNXa1h3TDEzNkJ0?= =?utf-8?B?SE9QdUczK09nM1JTVDJJZnBlZFNrTjZIaXVaZzZ0Vk5iM1cvVkFwc3JzblJE?= =?utf-8?B?THZiQzhzYW9wU2N1V05HQm5wU2lZM0tFZElCc2l6b016RVArT0ZHUm9Eamc5?= =?utf-8?B?TExwcDRPVldHWWpKNWkzaTh4TGtJam1FYWpjN1ptRU50MWJUOUZtbEtmWVF5?= =?utf-8?B?dXlZM2NzeWl2NGtiM1YzVlcvT1R6NStaMTM3M0pMOWNIeklXN2pkWjRwUVgx?= =?utf-8?B?NFQwU0pINmRQNG9PSFlHMGZtbTYwQW1jY1NEN3VxanFVK1dPdW54ekpHK2tD?= =?utf-8?B?bHV4N1d5d2FjaENrbmE0YUpIS3owOGFqS2k4MEtJbXd6bHcrOEl2Z0UybWV1?= =?utf-8?B?b1h2c25KQkRxdWxicmtaYVBvQnpEckhlaEdjMjBHVnFxdzI0ZHlVakFWRy9s?= =?utf-8?B?UmMvSlpBRjlaTDN5SUFYME1ZUUhNNHg2VkhDM0RJYWFmQzEvcEl6enQ1eCth?= =?utf-8?B?cWR4NWlzUDFFTlUxNnNxU0VaY21qSitMT2VSQ29RRlRSbGdwcFMrcVJPNlhh?= =?utf-8?B?VzMxYlhBRmJsWFVJYnN0bmNxamdVUkdabm5oVGErOVA1NkUyb3ludysrUVA2?= =?utf-8?B?LzRMQXp3cVNaamQwYmlyVUlGam1VeFVkMzBIYVZGT0VIYmJTdWdvWlJyNUho?= =?utf-8?B?OFJBVTBGTERzRkR5UTM3dTk5VGtsRnkxcWR0aVVycTVyS05QK1ZYNkc0bUNo?= =?utf-8?B?RmtscElZQjl2ZHM0Y0ttOFBOY3dVbjFwVjhwNStFZHlRcml5MmVGSHFlckNx?= =?utf-8?B?RnpHRW1RRm94ZklTbG52UmFUWlhtMXMxT1I5czl5bk1Dc3ZJL3F3azYxUllm?= =?utf-8?B?WERMeXNuY3JxMlpibUc3dzkvR1hpQnQ0M0Q1dVgwSm4yMmdQaWlMMjN0Q1RN?= =?utf-8?B?RkxoNWtXNTVaQWMxcW9tSVcrU1dBN1NtQWFicmVaY3hKWVhZNDZCeWNRc1Uv?= =?utf-8?B?YzQwbmlkQW5BT3ltVDF1SjVnSmxBMFN0N1ZwL3ZYZE5BRVBCVUZ5ZmJMWTZv?= =?utf-8?B?cXBZRitsT3RHZHk0M1FFRGcwQnlSMWNXWTNRS2hBbHQzUStmYVhTSXB6RFNp?= =?utf-8?Q?5m2wRADiYNCZD9DP6p?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 091419fe-5b5c-4080-8f46-08ded7af5232 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2026 20:28:33.0917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5T93KgGoX0qdt4pxhb5zUFnqe1ZLJO00pPZjmmr0mN1Tr2DVgCuH3itzTe5CChOq4aCakLYK2iA37OLdFb6X3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7P286MB6868 X-purgate-ID: tlsNG-c201ff/1782937720-0E5122B8-A5AECE98/0/0 X-purgate-type: clean X-purgate-size: 2538 SGVsbG8sDQoNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyAxLzNdIHhlbi9kZXZpY2UtdHJlZTog UGFyc2UgJ2NwdS1tYXAnIG5vZGUgZm9yIENQVQ0KPiB0b3BvbG9neSBleHBsb3JhdGlvbg0KPiAN Cj4gT24gMDEuMDcuMjAyNiAxMzoxMSwgSGlyb2thenUgVGFrYWhhc2hpIHdyb3RlOg0KPiA+Pj4g K3N0YXRpYyB1bnNpZ25lZCBpbnQgX19pbml0IGdldF9jcHVfZm9yX25vZGUoc3RydWN0IGR0X2Rl dmljZV9ub2RlDQo+ICpub2RlKQ0KPiA+Pg0KPiA+PiBQb2ludGVyLXRvLWNvbnN0Pw0KPiA+DQo+ ID4gRG8geW91IG1lYW4gdGhpcyBzaG91bGQgYmUgcmVwbGFjZWQgd2l0aCB0aGUgZm9sbG93aW5n IGxpbmU/DQo+ID4gc3RhdGljIHVuc2lnbmVkIGludCBfX2luaXQgZ2V0X2NwdV9mb3Jfbm9kZShz dHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmNvbnN0DQo+IG5vZGUpDQo+IA0KPiBObywgdGhhdCdzIGEg Y29uc3QgcG9pbnRlci10by1zb21ldGhpbmcuDQo+IA0KPiBzdGF0aWMgdW5zaWduZWQgaW50IF9f aW5pdCBnZXRfY3B1X2Zvcl9ub2RlKGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9kZSkN Cg0KVW5kZXJzdG9vZC4NCiANCj4gPj4+ICsjZWxzZSAvKiBDT05GSUdfQ1BVX1RPUE9MT0dZICov DQo+ID4+PiArDQo+ID4+PiArI2RlZmluZSBjcHVfdG9wb2xvZ3kgKChzdHJ1Y3QgY3B1X3RvcG9s b2d5ICopTlVMTCkNCj4gPj4NCj4gPj4gV2h5IGV4YWN0bHkgaXMgdGhpcyBuZWVkZWQ/IEl0IHZl cnkgbXVjaCBsb29rcyBhcyBpZiBpdHMgcHJlc2VuY2UgbWF5IGhpZGUNCj4gYnVncy4NCj4gPg0K PiA+IEluIHRoZSBjdXJyZW50IGNvZGUsIHRoZSBjb25kaXRpb24gaWYgKCBjcHVfdG9wb2xvZ3kg KSBpcyB1c2VkIHRvIGNvdmVyIGJvdGgNCj4gY2FzZXM6DQo+ID4gd2hlbiBDT05GSUdfQ1BVX1RP UE9MT0dZIGlzIGRpc2FibGVkLCBhbmQgd2hlbiBtZW1vcnkgYWxsb2NhdGlvbiBmb3INCj4gPiB0 b3BvbG9neSB0YWJsZSBmYWlscy4NCj4gPg0KPiA+IFRoZSBuZXh0IHBhdGNoIHVzZXMgaWYgKCBj cHVfdG9wb2xvZ3kgKS4NCj4gPg0KPiA+IHN0YXRpYyBpbnQgc2V0dXBfY3B1X3NpYmxpbmdfbWFw KGludCBjcHUpDQo+ID4gew0KPiA+ICAgICBpZiAoICF6YWxsb2NfY3B1bWFza192YXIoJnBlcl9j cHUoY3B1X3NpYmxpbmdfbWFzaywgY3B1KSkgfHwNCj4gPiAgICAgICAgICAhemFsbG9jX2NwdW1h c2tfdmFyKCZwZXJfY3B1KGNwdV9jb3JlX21hc2ssIGNwdSkpICkNCj4gPiAgICAgICAgIHJldHVy biAtRU5PTUVNOw0KPiA+DQo+ID4gICAgIGlmICggY3B1X3RvcG9sb2d5ICkNCj4gDQo+ICAgICBp ZiAoIElTX0VOQUJMRUQoQ09ORklHX0dFTkVSSUNfQ1BVX1RPUE9MT0dZKSApDQoNClRoaXMgbGlu ZSBzaG91bGQgYmUgaWYgKCBJU19FTkFCTEVEKENPTkZJR19HRU5FUklDX0NQVV9UT1BPTE9HWSkg JiYgY3B1X3RvcG9sb2d5ICkNCmJlY2F1c2UgJ2NwdV90b3BvbG9neScgY2FuIGJlIE5VTEwgZXZl biBpZiBDT05GSUdfR0VORVJJQ19DUFVfVE9QT0xPR1kgaXMgb24uDQoNCnZvaWQgX19pbml0IGlu aXRfY3B1X3RvcG9sb2d5KHZvaWQpDQp7DQogICAgdW5zaWduZWQgaW50IGNwdTsNCg0KICAgIGNw dV90b3BvbG9neSA9IHh6YWxsb2NfYXJyYXkoc3RydWN0IGNwdV90b3BvbG9neSwgbnJfY3B1X2lk cyk7DQogICAgaWYgKCAhY3B1X3RvcG9sb2d5ICkNCiAgICB7DQogICAgICAgIHByaW50ayhYRU5M T0dfRVJSICJGYWlsZWQgdG8gYWxsb2NhdGUgbWVtb3J5IGZvciBjcHVfdG9wb2xvZ3kgdGFibGVc biIpOw0KICAgICAgICByZXR1cm47DQogICAgfQ0KICAgICAgICA6DQogICAgICAgIDoNCg0KVGhh bmsgeW91LA0KSGlyb2thenUgVGFrYWhhc2hpLg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 01 20:47:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 20:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350913.1608302 (Exim 4.92) (envelope-from ) id 1wf1ps-00044Y-Ra; Wed, 01 Jul 2026 20:47:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350913.1608302; Wed, 01 Jul 2026 20:47:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf1ps-00044R-Oe; Wed, 01 Jul 2026 20:47:08 +0000 Received: by outflank-mailman (input) for mailman id 1350913; Wed, 01 Jul 2026 20:47:08 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf1ps-00044L-0V for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 20:47:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf1pr-004xLn-Da for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 22:47:07 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a457cb8-5cb7-0a2a0a5109dd-0a2a4503cece-8 for ; Wed, 01 Jul 2026 22:47:07 +0200 Received: from [65.109.113.108] (helo=mail.alien8.de) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a457cca-ec1a-0a2a45030019-416d716cace4-3 for ; Wed, 01 Jul 2026 22:47:07 +0200 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 64F4D40E00C0; Wed, 1 Jul 2026 20:47:06 +0000 (UTC) Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ADSUZm13yOCQ; Wed, 1 Jul 2026 20:46:56 +0000 (UTC) Received: from stx.tnic (unknown [IPv6:2600:1700:38ca:c00::1a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C4B3E40E00BA; Wed, 1 Jul 2026 20:46:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=alien8 header.d=alien8.de header.i="@alien8.de" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1782938816; bh=9DZRvVZl98blze4dH738SldPTBajzvNlA9enkx5HNIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C7MVCdKIQwJBnVfm7mPnS8PAwg8Y1NoZYuHElYGyAKM7fc+mxdWybKjpHwB8Mzpj7 KclOVs3gcHxvdMHsPAj8iH8SNPTWp7B0Vhab9XIHYE6emHehyMKHFp55OoI6O4whFN dZuVNgXvXHKj44a71aB1w2P2jj5RnKtz8T7bn6+qI2mIxTwc7Z6xlCDax5fC8pvB+v 2AjPuYATyrrM16xtVMFNfMedmTu1U3JSRkUc08UTlOIzC85dGDcZvdWRpQhaQevBUp Edy6Wpp7pSCohtn8TKAmSbm6+pLcyCp483eA4gItw992xn/7LkY/zhZ4qnCpaF2hfP j4TmDGAeHfgAYuUhcpHQFh9MplY5RHZKFVbjriD26bmvJqrIk1w4xEQgpwhOEId496 uAhlywQXu0lqi90BD+wQsFC8Mt+RwsVUPLQf1OiDxNAzTHUse2qefnINugWPLcA5wG mbUWK27MIqklxtgx/t/3EbeQgPVgOZHhye2doLhUjIGapdertqDCuHDj05D5NLhqHr mIbu4r68mDwYkBwBfv49iqHCCHUdYXDMdGSJHeEQzK47bM5VghW1cGgdep/P2JmfnR Rbd1lOVSWh7c904tEBDe0W4Mtv4jWb4uFGzXbkuasAvAAEs7tJluKPHfayUcPIgDEr dZ2b9K7+94deC1hVIAG0ZPjk= Date: Wed, 1 Jul 2026 13:46:40 -0700 From: Borislav Petkov To: Mauricio Faria de Oliveira Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp Message-ID: <20260701204640.GDakV8sOK1cu-0P4Bc@fat_crate.local> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-purgate-ID: tlsNG-33051d/1782938827-05F325D1-A13D5476/0/0 X-purgate-type: clean X-purgate-size: 806 On Wed, Jul 01, 2026 at 04:57:57PM -0300, Mauricio Faria de Oliveira wrote: > I'm not sure, as Reported-by and Suggested-by mean something different. > > Maybe a simpler statement would do? e.g., '(Thanks to David Laight for > noticing the return value difference between inline and regular > memcmp())'. That gives credit while avoiding confusion with tags. The Link tag already points to the review thread where we document who suggested what. We don't document who gave what review comments and suggestions for the simple reason that that would be intractable and the other simple reason is that they don't belong in the commit message. Changelog comments belong *exactly* under the "---" line. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Jul 01 21:15:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 21:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350934.1608311 (Exim 4.92) (envelope-from ) id 1wf2H4-0006fa-0c; Wed, 01 Jul 2026 21:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350934.1608311; Wed, 01 Jul 2026 21:15:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2H3-0006fT-UC; Wed, 01 Jul 2026 21:15:13 +0000 Received: by outflank-mailman (input) for mailman id 1350934; Wed, 01 Jul 2026 21:15:12 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2H2-0006dn-Ay for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:15:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf2H1-00Byh5-K2 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:15:11 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4582f2-5cb7-0a2a0a5109dd-0a2a45039ff6-44 for ; Wed, 01 Jul 2026 23:15:11 +0200 Received: from [65.109.113.108] (helo=mail.alien8.de) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a45835f-ec1a-0a2a45030019-416d716caef4-3 for ; Wed, 01 Jul 2026 23:15:11 +0200 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 70AA240E00C0; Wed, 1 Jul 2026 21:15:10 +0000 (UTC) Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fbVmubCe1ObW; Wed, 1 Jul 2026 21:15:00 +0000 (UTC) Received: from stx.tnic (unknown [IPv6:2600:1700:38ca:c00::1a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C9DD140E0140; Wed, 1 Jul 2026 21:14:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=alien8 header.d=alien8.de header.i="@alien8.de" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1782940500; bh=AP9t8vC+xALil2fXjdkfM+2rrb7oKrVXHkgSICn34hk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XrbfaOTBZHoHJ1+2gwxFQDPcXTG3kl01IxHgjkSSEEc/KUYMyUfqOwZImCZZNHdHx zxtZQkFrPz6/wBLeglc8vC4JFYqhK5itMxOR2Hz07svKN5DUDzjpzTq6lSyu7PMpg6 J0xHizV2IK6aDQff9T25xdyZbqLrGz97nxH3DoAqYS8cu6KbayS6fd7uX34anV/JH6 kStB7xY/XN0omASukknYBmF8GhOt3yAxT9R7wP0khVC8sdJq/WanITt1kqKDNavwoS po7RwS1s1alOm3PkUkd4bsLTwTcjgr+zw7dXNKAlndXa1NQ0ZgtBdT+3eY2pMc3poU gXhF9G9u0Xinm42MK80mx8+uqnB0vOUh5+4Pd2wbCGxIrummuFeSHmoQEpDTKR92ua /QQohisLTCCpL2MOyD8776HknTCWg3jcL916cb13G57enf67OFawWdt09jwZUGz8pF 1GMT+iSc7cHt2jl1SCf2jdbAnHZv4zRkKeLrHZgdhgTnThaYnkx1FJjUz/+TthAwNM 6Um+6HfAQ8mpeUGokLdYUkE0RjViVmZACbPAqrz868OJ65PMa4hyeZ9eTAbdaBjAta N+zYclQVyoZY8A9d7Q/CALnydIrZsO4oSAOI5dd5eneHWahpPSDYGyEzchcx80Jf0p G5ZX8pFv9FoaWJRurr18e5/o= Date: Wed, 1 Jul 2026 14:14:44 -0700 From: Borislav Petkov To: Mauricio Faria de Oliveira Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp Message-ID: <20260701211444.GEakWDRI0LY5o5GGM7@fat_crate.local> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-purgate-ID: tlsNG-33051d/1782940511-B692D5D1-3E8840FF/0/0 X-purgate-type: clean X-purgate-size: 263 On Wed, Jul 01, 2026 at 05:03:04PM -0300, Mauricio Faria de Oliveira wrote: > That would discard the credit attribution when applied, AFAIK. So, Read my reply again. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Jul 01 21:39:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 21:39:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350951.1608320 (Exim 4.92) (envelope-from ) id 1wf2e4-0004SW-Qp; Wed, 01 Jul 2026 21:39:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350951.1608320; Wed, 01 Jul 2026 21:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2e4-0004SP-Ns; Wed, 01 Jul 2026 21:39:00 +0000 Received: by outflank-mailman (input) for mailman id 1350951; Wed, 01 Jul 2026 21:38:59 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <38IhFagYKCXEhTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 1wf2e3-0004SJ-K9 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:38:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf2e3-005e8D-1E for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:38:59 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <38IhFagYKCXEhTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 6a4588a6-5cb7-0a2a0a5109dd-0a2a4504a638-48 for ; Wed, 01 Jul 2026 23:38:59 +0200 Received: from [209.85.215.201] (helo=mail-pg1-f201.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <38IhFagYKCXEhTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 6a4588f1-a01d-0a2a45040019-d155d7c9c8c2-3 for ; Wed, 01 Jul 2026 23:38:58 +0200 Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c8952346bb9so839563a12.2 for ; Wed, 01 Jul 2026 14:38:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782941937; x=1783546737; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=GRkq9jmjNuS5m4BJgbbAEXZCpunnA1N0v1XvrStDBgY=; b=sPbG4zjZ7nph/qSvllrKdz9+BE1npx1Z8wkgMQQkpJHImUF3kHIzZqygL1F75sXVDA fo8yegwkEByAAOSNMejvPmB+0hrgildk0lybSSXOAVjH/kwYkZNrkUs5qNOAHkn08OUI XYZtGplWzJW+5psweY8vxiC86VL48a0kyGMSJiLz8cg6JoPmxaCaSLowa5eBNi6WdiRc vA+S5smlzRQoiF5cnTSIkyISQRY6nFN2x8vEIRJmH+7z7VIiMNoYlFsF8ojmx+YYcsT0 zvz4GDnGzAKgAaBg7RSBGvqTwzcERA8iR97zj+d3txQlqSG4uYxLGFWktKlX+geSaHHX xwCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782941937; x=1783546737; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GRkq9jmjNuS5m4BJgbbAEXZCpunnA1N0v1XvrStDBgY=; b=eFx0jwTna15ovg0gEL4h+cpjCPsWLeRo3GAoJ1jAawwgVe+jdLxZ+HlVgfIsOuGXci ZJj0MZZsJMTC5eb4Wvttiuod01piKQ4bD50zYsL+LuVKN+TG0kApqQnBr1Jb3wn+4uku 4r7OgcLOMW3b07eNvIBujKRprygmlpsZ/9Yd6Kc3u0TnJE0wrEFAqESL4Is8snAcLUu5 qYUDrlq/w8Mf4pI7WAABK6Hs9Tg1irXhHu6r7yKjNzmKizhx0DYORwCRJ9jWkqo4UJeC T+U48ZCgT6QTNCHNUHGzomFAbmPNOBGa9rtjgfYP/T28zG2wlGxhLRaL8lqHNN0wM9QL Ny3g== X-Forwarded-Encrypted: i=1; AHgh+RqnUqf98PSXVqzwQXTO9eMSxnyZ7mtIPUiz1mkV/mmHAUur292KF6sB4QHWdt/gnNFZ1ek1v8xuppU=@lists.xenproject.org X-Gm-Message-State: AOJu0YwLirdRA16vLP/xDssI4VJotuU+M1d9ts+B1XuV5bSbc6COGPJW byfeS+d55xaUUnOS+yFGoms0NYSLH21VeYo1jDosH9sqojp2w5bAnqtk2MPlFGjy5ctZgck7p5A F6FjMrw== X-Received: from plbka15.prod.google.com ([2002:a17:903:334f:b0:2bd:9574:2958]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d2c2:b0:2c9:fa36:ab73 with SMTP id d9443c01a7336-2ca7e6f0b6emr36500665ad.8.1782941936636; Wed, 01 Jul 2026 14:38:56 -0700 (PDT) Date: Wed, 1 Jul 2026 14:38:55 -0700 In-Reply-To: <20260608145455.89187-7-dwmw2@infradead.org> Mime-Version: 1.0 References: <20260608145455.89187-1-dwmw2@infradead.org> <20260608145455.89187-7-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v5 06/34] KVM: x86: Explicitly disable TSC scaling without CONSTANT_TSC From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-ebf023/1782941938-2C5A91CC-7830281A/0/0 X-purgate-type: clean X-purgate-size: 2698 On Mon, Jun 08, 2026, David Woodhouse wrote: > From: David Woodhouse > > KVM does make an attempt to cope with non-constant TSC, and has > notifiers to handle host TSC frequency changes. However, it *only* > adjusts the KVM clock, and doesn't adjust TSC frequency scaling when > the host changes. > > This is presumably because non-constant TSCs were fixed in hardware > long before TSC scaling was implemented, so there should never be real > CPUs which have TSC scaling but *not* CONSTANT_TSC. > > Such a combination could potentially happen in some odd L1 nesting > environment, but it isn't worth trying to support it. Just make the > dependency explicit. > > Signed-off-by: David Woodhouse > Reviewed-by: Paul Durrant > --- > arch/x86/kvm/svm/svm.c | 3 ++- > arch/x86/kvm/vmx/vmx.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index e7fdd7a9c280..7817752533fe 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -5546,7 +5546,8 @@ static __init int svm_hardware_setup(void) > XFEATURE_MASK_BNDCSR); > > if (tsc_scaling) { > - if (!boot_cpu_has(X86_FEATURE_TSCRATEMSR)) { > + if (!boot_cpu_has(X86_FEATURE_TSCRATEMSR) || > + !boot_cpu_has(X86_FEATURE_CONSTANT_TSC)) { > tsc_scaling = false; > } else { > pr_info("TSC scaling supported\n"); > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index a29896a9ef14..ed207cc7692d 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -8672,7 +8672,7 @@ __init int vmx_hardware_setup(void) > if (!enable_apicv || !cpu_has_vmx_ipiv()) > enable_ipiv = false; > > - if (cpu_has_vmx_tsc_scaling()) > + if (cpu_has_vmx_tsc_scaling() && boot_cpu_has(X86_FEATURE_CONSTANT_TSC)) We should clear SECONDARY_EXEC_TSC_SCALING in setup_vmcs_config(). Failure to clear the vmcs_config bit will advertise the feature to L2 and allow it to be enabled in vmcs12, but KVM will ultimately not honor the scaling in vmcs02: if (kvm_caps.has_tsc_control) vmcs_write64(TSC_MULTIPLIER, vcpu->arch.tsc_scaling_ratio); This series kinda sorta gets there with "KVM: x86: Remove pvclock_gtod_data and private timekeeping code", but that change looks misplaced? And I think clearing the bit this late will lead to false failures in vmx_check_processor_compat() due to the golden config clearing the bit, but the local config having it set. > kvm_caps.has_tsc_control = true; > > kvm_caps.max_tsc_scaling_ratio = KVM_VMX_TSC_MULTIPLIER_MAX; > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Wed Jul 01 21:47:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 21:47:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350962.1608330 (Exim 4.92) (envelope-from ) id 1wf2mZ-00033y-L1; Wed, 01 Jul 2026 21:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350962.1608330; Wed, 01 Jul 2026 21:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2mZ-00033r-Hn; Wed, 01 Jul 2026 21:47:47 +0000 Received: by outflank-mailman (input) for mailman id 1350962; Wed, 01 Jul 2026 21:47:45 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3_opFagYKCYMzlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 1wf2mX-000317-Mp for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:47:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf2mW-0045QV-RX for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:47:44 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3_opFagYKCYMzlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 6a458a95-e002-0a2a0a5209dd-0a2a45049b16-42 for ; Wed, 01 Jul 2026 23:47:44 +0200 Received: from [209.85.214.202] (helo=mail-pl1-f202.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3_opFagYKCYMzlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 6a458aff-a01d-0a2a45040019-d155d6cad861-3 for ; Wed, 01 Jul 2026 23:47:44 +0200 Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2c804e38c65so21351355ad.2 for ; Wed, 01 Jul 2026 14:47:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782942463; x=1783547263; darn=lists.xenproject.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zcs7QN5Kd/BsLm+PUgFcojzf1bXkoGYIJwLkqkM7zHA=; b=rJXdqcxoOReWbjPjAvzoua4BR8NVKYONSvkt91FW4CQXEUdlRjl2ditOJ+2XQQHc3q cr8M1yBu5xnju9LfKRDYHTilGuHvHGgsRRf/yelZhI4212H9XRcCIRyh4IpduDzz0Ee0 mcDGn7cLPkkoJfu5hDerAwB/UlK4kiQLxteZlg8/LnP7xZ9NIhTRDylwB/GfhPCa98Wz bG20gvB7Ou7X/6AryzK0FbuinuyF1fs76ATjeEo6rAprvXXMBOgQ5w5M8kzvULPcRx2u TM6z70QJXd+jxsXFiIIH6XJTICDNuXIf0Ah3WR49n+uCYv3yW6y9AI0IBbHiK2CLcq65 RffQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782942463; x=1783547263; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zcs7QN5Kd/BsLm+PUgFcojzf1bXkoGYIJwLkqkM7zHA=; b=kVLANmLrXMVZghCerqzPb/34B0w8wxL1HVT756/rcA/Vj5ERkoyKOxv8E0I8irs/bE T0ELxM5DMFuPfgmlBw+dJ8QyTjgeanL85a1We1qoEw6zUTO2U6Q2w+meO661bIMgd3cq E1pS2Pxu1JIOuril3ZIv+N3S9QIo3boQxkeB6+FSeE5DL4Q/2mLdBPfTtzo5RiVyRLzj XLwgVKeFesTe+GbdmIiaPzsVa9cTiDw+3L41hwAzk8vaBtYuLGaQPypduzr/kOQyprrN vzz0ay/Bq3JnpW3d5/CrvzXVimVJ+FSV1ZHZVWUYBLim5hj3RcJCchf3M6OUP30Hwzq8 PxdA== X-Forwarded-Encrypted: i=1; AHgh+RrWuMVYkt6u0MJ295PeIhA0RB3ol40raN2lfiHQvUroQTTuV/t9JHoIlxYIXzEzeKuw5iqIcPIGn9E=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw+Ap4YY67MlkCcXtP1L+IoW5m0DxSQH7P/yR9kwhOl4ngvemx0 MrAHx078hsTfQfi2s5oGjO//ePk4+etZJ9KgPWyF98+31FSJgbgSLNKKtJazsXS86pAUI2Zt7H6 j4wu6sg== X-Received: from plzv3.prod.google.com ([2002:a17:902:b7c3:b0:2c8:7fe:29ac]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:32cc:b0:2c9:c083:cd49 with SMTP id d9443c01a7336-2ca7e69dfe3mr34635215ad.14.1782942462488; Wed, 01 Jul 2026 14:47:42 -0700 (PDT) Date: Wed, 1 Jul 2026 14:47:41 -0700 In-Reply-To: <20260608145455.89187-9-dwmw2@infradead.org> Mime-Version: 1.0 References: <20260608145455.89187-1-dwmw2@infradead.org> <20260608145455.89187-9-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v5 08/34] KVM: x86: Add KVM_VCPU_TSC_SCALE and fix the documentation on TSC migration From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-ebf023/1782942464-77B231CC-3D2A1459/0/0 X-purgate-type: clean X-purgate-size: 1638 On Mon, Jun 08, 2026, David Woodhouse wrote: > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index c1897d939da9..6337f9b9d7ac 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -5930,6 +5930,9 @@ static int kvm_arch_tsc_has_attr(struct kvm_vcpu *vcpu, > case KVM_VCPU_TSC_OFFSET: > r = 0; > break; > + case KVM_VCPU_TSC_SCALE: > + r = kvm_caps.has_tsc_control ? 0 : -ENXIO; > + break; > default: > r = -ENXIO; > } > @@ -5950,6 +5953,22 @@ static int kvm_arch_tsc_get_attr(struct kvm_vcpu *vcpu, > break; > r = 0; > break; > + case KVM_VCPU_TSC_SCALE: { > + struct kvm_vcpu_tsc_scale scale; > + > + if (!kvm_caps.has_tsc_control) { > + r = -ENXIO; > + break; > + } Uber nit. For consistency with KVM's bizarre pattern here: r = -ENXIO; if (!kvm_caps.has_tsc_control) break; > + > + scale.tsc_ratio = vcpu->arch.l1_tsc_scaling_ratio; > + scale.tsc_frac_bits = kvm_caps.tsc_scaling_ratio_frac_bits; > + r = -EFAULT; > + if (copy_to_user(uaddr, &scale, sizeof(scale))) > + break; > + r = 0; > + break; > + } > default: > r = -ENXIO; > } > @@ -5989,6 +6008,9 @@ static int kvm_arch_tsc_set_attr(struct kvm_vcpu *vcpu, > r = 0; > break; > } > + case KVM_VCPU_TSC_SCALE: Another stupid consistency nit. Probably do this? /* * TSC scaling information is read-only (it's a reflection of * the TSC frequency, which can be set by userspace). */ r = kvm_caps.has_tsc_control ? -EINVAL : -ENXIO; > + r = -EINVAL; /* Read only */ > + break; > default: > r = -ENXIO; > } From xen-devel-bounces@lists.xenproject.org Wed Jul 01 21:51:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 21:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350971.1608338 (Exim 4.92) (envelope-from ) id 1wf2pj-0006cr-0s; Wed, 01 Jul 2026 21:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350971.1608338; Wed, 01 Jul 2026 21:51:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2pi-0006ck-UP; Wed, 01 Jul 2026 21:51:02 +0000 Received: by outflank-mailman (input) for mailman id 1350971; Wed, 01 Jul 2026 21:51:00 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2pg-0006bO-Hl for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 21:51:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf2pf-0054vW-J6 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:50:59 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a458bb2-bab6-0a2a0a5309dd-0a2a450cbc7c-10 for ; Wed, 01 Jul 2026 23:50:59 +0200 Received: from [52.101.229.100] (helo=TY3P286CU002.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a458bbb-f399-0a2a450c0019-3465e5649f90-3 for ; Wed, 01 Jul 2026 23:50:53 +0200 Received: from TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:363::12) by OSOP286MB3905.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2ed::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Wed, 1 Jul 2026 21:50:48 +0000 Received: from TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM ([fe80::9caa:1ff:d16c:e15f]) by TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM ([fe80::9caa:1ff:d16c:e15f%3]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 21:50:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Apnt8DqnPB3QP1Pss7XvY9p+0kbdCP7yxn2rrucfvwj1y68FkxLlEYrg1hRhKLRVhyD6qJ6DuvnV1m8FznVx0qbUlsBKftnGQXO6Wo/V+zAqP5PZ8GXbfpNUC5qfyrsM5h60JCsd7LABTNnf5vdeLIN/8Vajq0BLZMJ3UL4qGx5+G68Pt952GHS2r1yYxERDGhqdg/TTmhtUjnc8tBMc19hwFHs36WbhFGm6DSO9p+WK0EuT9rRr+vRF5g48f8MBxt+s+C76qSknaAJY/M+hCBJRI17V3Z7F9NBv5gOhIh0qHJc8qS1XQI128AUOERHzQDbdjdB/ufIEr4h/DLwXEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wMr+iCYzj+ti+jg9ziJqWr1SMrXbZx3IfO46chyDpn4=; b=ypwaOpQDAZrqy15ukHBZ2NWTP4TXHRwj58N2XvSuxWoNtIuwSKRQzXgaCP88hkZdyuEvQEC7ECVV2WotG2ovtzWXoG/73aXh8ARHSbgGFDKUGqK2uM0x29UlONvuh9rhm4rdTMaiTLAj6sy2EzCNX//xmINYyeEZkyN0rAvO+6xpIFftuLUjHBuVhUaBVKtwfbTp4UvpazkxHRGgaK7CkpDybpahAfcc9QJkg5WG9IRfzizC2Zuxz85bIkynuNv/5G8WuQcoJJfBE+lPGmEh9AnRI/o0fPfLcoVVku41mFjgGWCAsMVV5QxjPRYfrrWMBSNglxHOZ99vwTjHcNFdXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wMr+iCYzj+ti+jg9ziJqWr1SMrXbZx3IfO46chyDpn4=; b=j+g6oOP6ZsUxfXDsGn9GbRB6ocrMsjC8b/6ahfPIdym0Bkp78ohymHbl1dcIQdYM3KO/Q+AAFAvaaaOL1g8R/SNc99kHZapTRA3CUBF5dQcSODc/Kqs4V6XtQbI8jZcw7Jfiodvmngf3ylp984IWAQ/AuUqKRg57/JubZz2UPSE= From: Hirokazu Takahashi To: Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Timothy Pearson , Alistair Francis , Connor Davis , Oleksii Kurochko , Dario Faggioli , Juergen Gross , George Dunlap , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 2/3] xen/sched: Link CPU topology to scheduler Thread-Topic: [PATCH v3 2/3] xen/sched: Link CPU topology to scheduler Thread-Index: AQHdCBJhHN8gTC0+5k6Ik1hF9MtBXrZWrIoAgAKKNXA= Date: Wed, 1 Jul 2026 21:50:47 +0000 Message-ID: References: <20260629215806.11610-1-taka@valinux.co.jp> <20260629215806.11610-3-taka@valinux.co.jp> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY7P286MB7234:EE_|OSOP286MB3905:EE_ x-ms-office365-filtering-correlation-id: 876e0c72-eb2d-4830-10f2-08ded7bacf8e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|23010399003|18002099003|22082099003|4143699003|56012099006|38070700021; x-microsoft-antispam-message-info: htXm5u4D64e1zN8SIjLm9la6UpcfLBKjUwdgmx/eAnj8mZ/BvIlfWsVykXeKC6eRh8/6Q/0LLKDd3UH0hjR+NIkyCs/9u7DnqO/Hiz3sZdtYkJmeL8ZrdIHMHX2y+CA2vwoK0DRueOG3kz3NxjomY/9O8sUtgoxp6hEzWCDQusX2SengdLoJU+Ybh2H16zMX+KAiVSaIBSS2kpymGE8H9ZKpK8BOBjMWfUe6/QCZJC7FsxhcOhYsyHYcLBRnmndEGAYfqeLXCF0GArEWQciSXi9x0VNCXOx0W8a1HTiu70Mfze/3rxzgAComtG543f5vH3eE06ooQKa6anWDyBAu296iPoqR+H9iCEL6soHZwf7bTpM7j9DVWyDSxWSp0O+gCjM6yWUhyMj4DQFQsrP1JFLl/HXN8JvI1gy4iEfjFHUCkPt+7OOcTzQzIN3KRm0JpgTCsJwTS3ttaQJxtWS/rllevBovJdJhX/SJhP8XLCEBgXbOGiTdSg8BJP4Pf+RDH/6GJAY19gljnKyngHkdCR3Y0hf0U7AaYilsEqc7UMc1FrGNFuvAIqaFzA3kEYKtr+TrCjo2RBrNAsAEbm6nL8qKsHlrFCcnheDe4ghMgo9w+MDCvznkVepXi4g60x/VOHsmPDbr7crzZsD7PzNdyQj97ogotZnQvSunX/lklTpZuU7s8LPsL0cNKxkQ5LzZMNMTlFNU5irBQJ7myhCB/g5gTEgcjxaUTkjuRoy1a04= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(23010399003)(18002099003)(22082099003)(4143699003)(56012099006)(38070700021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M0JzL1VCZzNhdDBGaDZmclRuSzBRNlJvTE9DR1pFK1p5M0F1Rmo0Q2MrWGw3?= =?utf-8?B?Zmg3TGl3R3NubnplcDZwa1VhM1J0bVJRZk9ZYVc2ZWM5QW1JVEhBWHZxQ09p?= =?utf-8?B?aC9peDFGTGpVNW90RnMrQjRhbVBhdXhtcC8vOWdDZDNUTHByempLamt2RktO?= =?utf-8?B?bU9wbVNzeStJR0daNTFyMkZQbVRYZFhCYnkzL3JnSmV1Yk00K3IxUEp1TjBs?= =?utf-8?B?WUVEY2d5cSthZGUwZ1ZGc2JzS3VyWEF1ZEpFdmhGeFllOUtjcTBQTnZMK05p?= =?utf-8?B?T2RSL3FCdnVFODZBd2p5Tk01ZEFOZlhiNWdaOHM1TVY4ZDd6K3dHQ3FrOFRF?= =?utf-8?B?cStQa1RYWW0ycFNXQldBbUkxbk1RdjFYYmcwSjVWMzFwV0RFUGRaaWt4cDhI?= =?utf-8?B?Z3pvMXk0dTQ3Q2k0SGhnc292S3RBNUNXRU96OEFvdkI2ZVhMYTZTZHpkc0g1?= =?utf-8?B?algyY1JBK0tJSHBma0Y5Si9qTHlWY1ROSkY0SGdxR2ZLZmtOdnBYcldXVDU3?= =?utf-8?B?Z3NUQVd5eThhZWZZN1BHenR1SXQxRE1JTHRvb2RBQU9GNUZQWEsrY1R5ME4w?= =?utf-8?B?eERuNmdwWkhPQ3AxRXlKd1R4dW5KYU1CUlo3cnVld1g3UW00bE10eGJLVVZZ?= =?utf-8?B?dXIweDBadVJ4Q253dDBmbzhUYytIOExMWmJWWUd1MGNlOTRxQzkwcmJkMW9i?= =?utf-8?B?UEFDREp3NXp1dExNYlRGMzAzdDNmcit6Sm1CWEduY3lSdlFqbmNaMmRtOUsx?= =?utf-8?B?RXpucGpXRURwYnZrVlhWN0xMdVRqY05aYk9ULzdFNUFZbldycDZhMnQrZTVK?= =?utf-8?B?b01uRWsrRmhjcTRFMFZ2cnBJbmFlZml5STRzL2JKYUM5NUJseG9zUFRZYUNR?= =?utf-8?B?MkVWMHNMVGxESmtGcGRjQWpWaVhhNG9zV2IrVnNRell4eFhSa1k1VSt4bTh6?= =?utf-8?B?STd4ZGYxRFBhb1h5a3ExU2Z1NkwwZndrZFJNK2o5NW5VdEl3bmdXWVVjZVVK?= =?utf-8?B?NlhrUFA5Y3VSN3VpR21RUUI0bXNPNVQvMXg3SlcyV0ltdU80K2VjNTVTY3V3?= =?utf-8?B?U0lWTDgxZ0pieHhZUExreUppM2tyRkhOUGV3b0NhblFCZ21mSWE3SkM3azIr?= =?utf-8?B?VEk0Z0o0OEplcElINVpKcVZCWkpURlRzM1MrVEJjL0FYalRidytFQ2x6a2c1?= =?utf-8?B?c1drSjA0SkluNFMxMVRxd1dRQVVzR29EN0wrYzNiM1FybElkZVdUMFZMbnFy?= =?utf-8?B?Q0JyUWJDdm42N1Zzb0o1YjZ4N0hBSGxBMkl6L1FVb1hEQVVIQnZyQ3dBVnQ2?= =?utf-8?B?OGVLZmFnU0Fmb3NyVmRYL3VBTFJUTmxjMWJ4WWpZL1V0a29ldVNHQXZyQ1dU?= =?utf-8?B?cnVaK0ZVbTRYc0xsQ0dZSFgyZ085em9xZk9xRkxFTkxyZlFWK1JzdlpqQXZ2?= =?utf-8?B?Y1BKZ2FsaGtteUNLa0NKWjJmRjRiUzJLVzhiTThsK09aYmZVOUFqaFBoUVYv?= =?utf-8?B?MHdyZU5SSHhncW1hNEQ1V055STk2b3c3Z29CYVEyVjgzT2w4QStBVVBkV01Z?= =?utf-8?B?c0VGTzBGR1VwMUdEMXlFc25iYi9EcyszOEdpdy92T1hLTGF2V2JuT0Y5WW1o?= =?utf-8?B?dUhKYVN0SEd4amxsaGNvSE5lcUdRMnB4TlVhZWdBWit4ZS9CWUZKMVlGN0Zw?= =?utf-8?B?Z0JFZkxQOE5UK2c1RGZxUitpUktxbVc0Tnl6MmdwNC9KRTVZaUEwM2VITXMx?= =?utf-8?B?NWowMWR5cXh6a3FHU1VrazNlc3d3cGlSdTd0a0hFb0xyWmZKMjc4QTMxWVJH?= =?utf-8?B?WGN0cis3VGprQzhpR3FrN3dCM3duYWNIWFpKVWNQQXJtZmZiS2tQUEExdzNt?= =?utf-8?B?VW03aXo0WFpFS1F5Rm1rRXdhK01KSlBIT2NKNXFYTmhVRFpYazhEaFZVNnR6?= =?utf-8?B?UzR3R01IRER2WnlpMG9MQnk1ZEVmeXE1bFRHOHRuMloxYkJjZnR0UUJTdXJ4?= =?utf-8?B?djBLb05YV3BraWpkcGZyb01nUDlSUEpqdStHU2hwRE1zSW12Mkd5ZUZHWlZW?= =?utf-8?B?UENOV0Jvblk5ZElJSUZrbUZTWkNkVm9od3V4eDY5WEMwVk9yV081K2Vib1Rh?= =?utf-8?B?dnorYlpscjZYVklNRDQ1TlZoVmxPZGxWdmFsZFJyZ1VPRFhlYXlmcUpseXA0?= =?utf-8?B?dGNSU2xKNUZNOVh3dFBDUFR1TVFzMEZ5RHFiQWVnMG0xLy9aOGhCaXFXSUFN?= =?utf-8?B?Z3VSWFhZZmxySmdYdkJQODNBbXJVY1Q4L1Mrc3AxVmFteUk1WlMxb0Z2SlM0?= =?utf-8?Q?Kqm3xGexICjiFCeGuJ?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY7P286MB7234.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 876e0c72-eb2d-4830-10f2-08ded7bacf8e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2026 21:50:47.9037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yRYF/KXpEep3E9PAtZ28ju9qPEGZDNLUQU00LZ7HP/884qr+0ohlx5RJTsoFNPkEosXuQjHHfVFkFs4aFcBnaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSOP286MB3905 X-purgate-ID: tlsNG-d25034/1782942659-0ED3AD51-A8ECF789/0/0 X-purgate-type: clean X-purgate-size: 3038 SGVsbG8sDQoNCj4gPiArI2luY2x1ZGUgPHhlbi9jcHUtdG9wb2xvZ3kuaD4NCj4gPiAgI2luY2x1 ZGUgPHhlbi9lcnJuby5oPg0KPiA+ICAjaW5jbHVkZSA8eGVuL2luaXQuaD4NCj4gPiAgI2luY2x1 ZGUgPHhlbi9saWIuaD4NCj4gPiBAQCAtMzcsNiArMzgsOCBAQCBzdGF0aWMgdW5zaWduZWQgaW50 IGNwdV9ucl9zaWJsaW5ncyh1bnNpZ25lZCBpbnQgY3B1KQ0KPiA+ICB7DQo+ID4gICNpZmRlZiBD T05GSUdfWDg2DQo+ID4gICAgICByZXR1cm4gY3B1X2RhdGFbY3B1XS54ODZfbnVtX3NpYmxpbmdz Ow0KPiA+ICsjZWxpZiBkZWZpbmVkKENPTkZJR19DUFVfVE9QT0xPR1kpDQo+ID4gKyAgICByZXR1 cm4gY3B1X3RvcG9sb2d5ID8gY3B1X3RvcG9sb2d5W2NwdV0ubnVtX3NpYmxpbmdzIDogMTsNCj4g DQo+IFNlZSBteSBlYXJsaWVyIHJlbWFyayByZWdhcmRpbmcgdGhlIG9yZGVyaW5nIGhlcmUuDQo+ IA0KPiA+IC0tLSBhL3hlbi9jb21tb24vc3lzY3RsLmMNCj4gPiArKysgYi94ZW4vY29tbW9uL3N5 c2N0bC5jDQo+ID4gQEAgLTI4LDYgKzI4LDcgQEANCj4gPiAgI2luY2x1ZGUgPHhlbi9wbXN0YXQu aD4NCj4gPiAgI2luY2x1ZGUgPHhlbi9saXZlcGF0Y2guaD4NCj4gPiAgI2luY2x1ZGUgPHhlbi9j b3ZlcmFnZS5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL2NwdS10b3BvbG9neS5oPg0KPiANCj4gVGFr aW5nIGUuZy4gdGhpcyAjaW5jbHVkZSwgLi4uDQo+IA0KPiA+IC0tLSBhL3hlbi9pbmNsdWRlL3hl bi9jcHUtdG9wb2xvZ3kuaA0KPiA+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9jcHUtdG9wb2xvZ3ku aA0KPiA+IEBAIC05LDYgKzksMTAgQEAgc3RydWN0IGNwdV90b3BvbG9neSB7DQo+ID4gICAgICBj cHVtYXNrX3Zhcl90IHRocmVhZF9zaWJsaW5nOw0KPiA+ICAgICAgY3B1bWFza192YXJfdCBjb3Jl X3NpYmxpbmc7DQo+ID4gICAgICBjcHVtYXNrX3Zhcl90IGNsdXN0ZXJfc2libGluZzsNCj4gPiAr ICAgIHVuc2lnbmVkIGludCBwaHlzX2NvcmVfaWQ7DQo+ID4gKyAgICB1bnNpZ25lZCBpbnQgcGh5 c19jbHVzdGVyX2lkOw0KPiA+ICsgICAgdW5zaWduZWQgaW50IHBoeXNfc29ja2V0X2lkOw0KPiA+ ICsgICAgdW5zaWduZWQgaW50IG51bV9zaWJsaW5nczsNCj4gPiAgfTsNCj4gPg0KPiA+ICAjaWZk ZWYgQ09ORklHX0NQVV9UT1BPTE9HWQ0KPiA+IEBAIC0xNiwxMSArMjAsMjIgQEAgc3RydWN0IGNw dV90b3BvbG9neSB7DQo+ID4gIGV4dGVybiBzdHJ1Y3QgY3B1X3RvcG9sb2d5ICpjcHVfdG9wb2xv Z3k7DQo+ID4gIHZvaWQgaW5pdF9jcHVfdG9wb2xvZ3kodm9pZCk7DQo+ID4NCj4gPiArI2RlZmlu ZSBjcHVfdG9fY29yZShjcHUpIChjcHVfdG9wb2xvZ3kgPw0KPiBjcHVfdG9wb2xvZ3lbY3B1XS5w aHlzX2NvcmVfaWQgOiAwKQ0KPiA+ICsjZGVmaW5lIGNwdV90b19zb2NrZXQoY3B1KSAoY3B1X3Rv cG9sb2d5ID8NCj4gY3B1X3RvcG9sb2d5W2NwdV0ucGh5c19zb2NrZXRfaWQgOiAwKQ0KPiA+ICsN Cj4gPiAgI2Vsc2UgLyogQ09ORklHX0NQVV9UT1BPTE9HWSAqLw0KPiA+DQo+ID4gICNkZWZpbmUg Y3B1X3RvcG9sb2d5ICgoc3RydWN0IGNwdV90b3BvbG9neSAqKU5VTEwpDQo+ID4gIHN0YXRpYyBp bmxpbmUgdm9pZCBpbml0X2NwdV90b3BvbG9neSh2b2lkKSB7fQ0KPiA+DQo+ID4gKyNpZm5kZWYg Y3B1X3RvX2NvcmUNCj4gPiArI2RlZmluZSBjcHVfdG9fY29yZShjcHUpICAgKDApDQo+ID4gKyNl bmRpZg0KPiA+ICsNCj4gPiArI2lmbmRlZiBjcHVfdG9fc29ja2V0DQo+ID4gKyNkZWZpbmUgY3B1 X3RvX3NvY2tldChjcHUpICgwKQ0KPiA+ICsjZW5kaWYNCj4gDQo+IC4uLiB3aGF0IGd1YXJhbnRl ZXMsIG9uIHg4NiwgdGhhdCBjcHVfdG9fY29yZSBhbmQgY3B1X3RvX3NvY2tldCBhcmUgYWxyZWFk eQ0KPiAjZGVmaW5lLWQgYnkgdGhpcyBwb2ludCwgc28gdGhhdCB0aGVzZSBmYWxsYmFja3MgZG9u J3QgdGFrZSBlZmZlY3QgdGhlcmU/DQo+IChJT1cgSSB0aGluayB5b3UgbmVlZCB0byBleHBsaWNp dGx5ICIjaW5jbHVkZSA8YXNtL3Byb2Nlc3Nvci5oPiIgYmVsb3cgdGhlDQo+ICNlbHNlIGhlcmUu IFlldCBiZXR0ZXIgbWlnaHQgYmUgdG8gbW92ZSB0aG9zZSB0d28geDg2ICNkZWZpbmUtcyB0byBh IG5ldw0KPiBhc20vdG9wb2xvZ3kuaC4pDQoNCllvdSBhcmUgY29tcGxldGVseSByaWdodC4gSSB3 aWxsIGZpeCBpdCBpbiB2NC4NCg0KVGhhbmsgeW91LA0KSGlyb2thenUgVGFrYWhhc2hpLg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 01 22:01:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 22:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1350992.1608348 (Exim 4.92) (envelope-from ) id 1wf2zO-0004xz-0s; Wed, 01 Jul 2026 22:01:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1350992.1608348; Wed, 01 Jul 2026 22:01:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2zN-0004xs-UW; Wed, 01 Jul 2026 22:01:01 +0000 Received: by outflank-mailman (input) for mailman id 1350992; Wed, 01 Jul 2026 22:01:01 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf2zM-0004xj-7l for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 22:01:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf2zL-003o8p-4H for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 00:00:59 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a458e0e-5cb7-0a2a0a5109dd-0a2a450ca3a2-26 for ; Thu, 02 Jul 2026 00:00:57 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a458e18-f399-0a2a450c0019-d561b338d27c-3 for ; Thu, 02 Jul 2026 00:00:57 +0200 Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine2.igalia.com with esmtps (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf2yt-007ljZ-Ns; Thu, 02 Jul 2026 00:00:31 +0200 Received: from webmail.service.igalia.com ([192.168.21.45]) by mail.igalia.com with esmtp (Exim) id 1wf2yr-008Wju-Lr; Thu, 02 Jul 2026 00:00:31 +0200 Received: from localhost ([127.0.0.1] helo=webmail.igalia.com) by webmail.service.igalia.com with esmtp (Exim 4.98.2) (envelope-from ) id 1wf2yr-0000000DsjJ-1ury; Thu, 02 Jul 2026 00:00:29 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Content-Transfer-Encoding:Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date:MIME-Version" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yaM2/r0nQ+KZa9DjbHwZn8AL8mGnTAI+bvsmHq0U8OI=; b=clzouy0BybVRLPyaWMiEL3ApQu zHIDnxBF5w2LC4HvrX+1geUmrI7pjYHSvksAIMFK2Mpy7+KcLOOlGutwh9F1oYiZNK9LqLopJFSUs gA6bjZoG4CsxeUYgSDVjPc7kwjqOekrEOt2PdmRHsaxjkUBZC32DTzWWxqX1scQ0XFceBVbioCZOq ycJ6ulD9ANZoBAP2Y5mhqopisw2s9RCV3DpH125RteFJV/HPHI7QAY/CP4sZ8Ci2tRuPWkywuY2NM gzkHc3Z6J+o+5cLkay+hqY9n0PhinyfJXycC2Eey4hBM7iBzFWit2DsHrHs1z9lQ7Bgucaa+qRk2f lYDUhF3w==; MIME-Version: 1.0 Date: Wed, 01 Jul 2026 19:00:29 -0300 From: Mauricio Faria de Oliveira To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp In-Reply-To: <20260701204640.GDakV8sOK1cu-0P4Bc@fat_crate.local> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> <20260701204640.GDakV8sOK1cu-0P4Bc@fat_crate.local> Message-ID: X-Sender: mfo@igalia.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Report: NO, Score=-4.7, Tests=ALL_TRUSTED=-3,AWL=-2.549,BAYES_50=0.8 X-Spam-Score: -46 X-Spam-Bar: ---- X-purgate-ID: tlsNG-d25034/1782943257-91F23D51-73567504/0/0 X-purgate-type: clean X-purgate-size: 851 On 2026-07-01 17:46, Borislav Petkov wrote: > On Wed, Jul 01, 2026 at 04:57:57PM -0300, Mauricio Faria de Oliveira wrote: >> I'm not sure, as Reported-by and Suggested-by mean something different. >> >> Maybe a simpler statement would do? e.g., '(Thanks to David Laight for >> noticing the return value difference between inline and regular >> memcmp())'. That gives credit while avoiding confusion with tags. > > The Link tag already points to the review thread where we document who > suggested what. We don't document who gave what review comments and > suggestions for the simple reason that that would be intractable and the other > simple reason is that they don't belong in the commit message. > > Changelog comments belong *exactly* under the "---" line. Ok, I'll send v6 addressing your feedback. Thanks. -- Mauricio From xen-devel-bounces@lists.xenproject.org Wed Jul 01 22:41:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 22:41:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351008.1608356 (Exim 4.92) (envelope-from ) id 1wf3ca-0001SE-Ta; Wed, 01 Jul 2026 22:41:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351008.1608356; Wed, 01 Jul 2026 22:41:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf3ca-0001S7-QE; Wed, 01 Jul 2026 22:41:32 +0000 Received: by outflank-mailman (input) for mailman id 1351008; Wed, 01 Jul 2026 22:41:31 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf3cY-0001Rz-Nj for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 22:41:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf3cX-00AMwd-VX for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 00:41:29 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a459787-5cb7-0a2a0a5109dd-0a2a450cb7d4-14 for ; Thu, 02 Jul 2026 00:41:29 +0200 Received: from [52.101.125.77] (helo=TYVP286CU001.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a459796-f399-0a2a450c0019-34657d4dfa73-3 for ; Thu, 02 Jul 2026 00:41:28 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TYYP286MB4652.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:194::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 1 Jul 2026 22:41:23 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.008; Wed, 1 Jul 2026 22:41:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tpZOys80WbxwSdxEpywkQX1JarkUqhwV8ONIGlEd7cjgiDqdputtqfIMG4W/R8zn5wnozzD4DyaUfxe5o4Y5Y33qKCiAXWuOX/tLVScqJ5WzLk/IXKdo/pnraNgWnv5A/gT8+h+8w/iKhJIBa3Z1PV5Ahq1Kv1likq01nbDgEIFwazd9j05DUfs/2zxyVMJrdM7zCqhMJlTB9MqT/FK+MyDLXbuXyA/bl8LrwIGIjypShnDAPvow3F6k6ziLOl5kn+S6Qvj31f30i/Q6hvpS7LucgfsaOOoYFjInqMDw5u4eRqWWIUQU3BYhyAoAf5zBUsKoIKhAvUcml1VnKuBIvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6tUfFRxT1O+2cz1vpN39n0rIxgr80Gv1sJ1w0nFmvPA=; b=S0vCgLdE20YidkYKhV+G2q8wPlGVm5ZFxxmYaHGOY9d+UbX2GTAs1lRyhmAmJ7hnDGpstcyV4HzPkvDzy7vgu2me0pTPceqy6Ex+IFsnbvdI8r3F5Mx5BXae6YSPJNMwkTdY7SViyGhC5OwZ6mw0GLJyxJMhXA6S5VZq/KgkwQrRmZHMyAx0EQA0NZmw+6pOLDF4uMhS3/aevUsTeCFiyc+kEUAM7Ppn1MmoIU8xeGiY0VuHB1Z+N89IevIYTy7fH8C4kH/DaftOyUm24mUDMpFPJi8x/i6i3enoYQYgysfue6UWgTx3hBl2BqMoxB/Cylyo8CLPTePfdxNy8v7emQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6tUfFRxT1O+2cz1vpN39n0rIxgr80Gv1sJ1w0nFmvPA=; b=EHlJDaF9Z50zdu2LlYUDJtZ59ezGV9XnWgV47+Ke4Qx4v3RJByVSPZJmo3Ho2bp3Pl307m7vjPVYPXvNwFAUJ52OGbEz/aOnvm6c4vkdSZztDtMMp0ogKRWy6p4E4nY+nSjC2KW7NGZza6pINBxk2tKYUt0x2hP8v99Eox1vnco= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Hirokazu Takahashi To: xen-devel@lists.xenproject.org Cc: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Hirokazu Takahashi Subject: [PATCH v3 1/1] xen/arm: fix sparse cpu_possible_map calculation on SMP boot Date: Thu, 2 Jul 2026 07:40:57 +0900 Message-ID: <20260701224057.46592-1-taka@valinux.co.jp> X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TYWPR01CA0051.jpnprd01.prod.outlook.com (2603:1096:400:17f::7) To OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9P286MB7222:EE_|TYYP286MB4652:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ca15ec8-b133-4e1e-a615-08ded7c1e0e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|10070799003|1800799024|376014|18002099003|6133799003|56012099006; X-Microsoft-Antispam-Message-Info: uCDPF+66gS3Z92FnzVDALvrvHZkeXnMuxh8n4HS6NxWU871D0PnNeEmVcKc+cKuhC3EAo6SUS6pOXg8ovgnwef4/Ddob3uGrN5zBgeYrKH1TVwK0edUglXRkGdgv3pVBCnthPf8LhNmCR4Tx3I8tdKgnL+JjX91VQv7tdbNyXwV5ygCUOotVnzBEKBs/gOlPr8VlpMVbvpgoPH0hU0PEJeC7UliooEMJIWgWuUlOeJ/E9jSSxTznHYBODEm0yQJ/5g3oRdbpVGk2DEY4mAbRI+sMieGfNe1DxmS6bRwNt8k44Yc/iIYNXiyCEh1iT2hqqMEsYgEx4mkD/ryHKNA2LmFbME6DQjEXWJHTVQi0Q5VIAVpArEEyi8G8VjY8UicXZ5nPe8+jc4p98Tq7W2xrjtHgLlFxW4r1YMyb3KghVm/RkTVT1qjhz+t7KsVbSotmqPqJaMUJw6BU618nCZ50ybgJ0T4LlVgGXLPP3vI91xUi9RnGPzwDFKA0LNEDQnwXKOXPwoZytryNdRcXoEVl9m8hLpBwr/T6Hjq4saZ2Il0yG3T2kMwyKQZLR5etsPPuCij18mqqurERdhRwKUbLm/9ja5aEZtm7uCCbmx+Erf2aHAvPxXhDoxE/hRX1V8OP6fGdA9U10BEG/sz3OeAnIUx1WUvxQ3N/+ZpwBhf/I0E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(10070799003)(1800799024)(376014)(18002099003)(6133799003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u51DIDw+1h1O7kzh0fyhpaHzL6pgjTroji5D2PXAqkk3h0j1xGmPaCSfnp73?= =?us-ascii?Q?QwhMPf3fTDSSKPl6Mn0JdamCY7vZUL0s4zo281+zQxmX609SkecPvs2p2rsf?= =?us-ascii?Q?ZKn7/VkHPtNASA2CemXHPb3U6g7WJEVlog7X62fFT9ZywjmpNIIqRQ8lay5K?= =?us-ascii?Q?zDmzuBkpAb/IM+gn494gAo/vfMqs8FR5qUGK4ru+b+7HN3qyXjIIU56eaZtI?= =?us-ascii?Q?TFJAtlyjUV4ZQ59aCyFFe8bjbptTar9FbTPvq1x6vIOegAGWYucxw9mLk1vY?= =?us-ascii?Q?GPm+ANA0FtYtSnWVtzCK+qYNeNAROnc5HHze8es3d0c3pf0TRM/NhNDpWTMp?= =?us-ascii?Q?0aC6xmUEHvkq7aBd659oO33+q7HdO/Aw72tKQbnOFHu1g7kSDKvDbqU27mjJ?= =?us-ascii?Q?upcKl62b1YRqZDaRPLnS9pM9Vw5/NwgZe2Oa4BQ/P4sYhoUmgvgcNfVNAluV?= =?us-ascii?Q?HPWbsxNvogeFEgcPkak4czkvUM0CNGLSHg4Wr7kXX9XU08BCqH/NeWq/ypWw?= =?us-ascii?Q?BT1E3E9MdZsefhrySWc1xzzjrYrBm2or5nZhlHinNmR77g0o7UGohCE0BOLU?= =?us-ascii?Q?gIfjQIL0qg/cOfHQ4y4QfD7pgwzfAmkR79Fk9I19u4LSzwxLuQjl5d+R9xLj?= =?us-ascii?Q?yg5i5cqMNix52yA1ly86tvwWmepLPLWmGsOErIjGVZ/hR/lpaF+Irz3D+6p/?= =?us-ascii?Q?8ReaAWbX68mO9Fs1EptQ00oRP+bsxwrcttpH0gtAP/jb3fW+Q553mbxcbFZI?= =?us-ascii?Q?FHp1SybjWF6+nDbbR+WZOKuWvcujD4eErScFZyIjKEvDnGXyzgR18DQ+GBcT?= =?us-ascii?Q?pvRPxA0qNjoQCL2TgrlmdGZpCIcV+7MbjZnNQjYjGLZ/pCtZIgAW0dq+gPoT?= =?us-ascii?Q?KWE4onQrRydR8dm/94W/49ZTlfWvrKAzL0Ypu8uBhu3ZcL+6KUcj89J1LKJq?= =?us-ascii?Q?2yySvGmb+TBBjMIiZqCyamn/LVOcvV18xV29QqLculhIhVVEXC7Bgd4s8iGO?= =?us-ascii?Q?AuJgs0zEiLz/QuckykU31QrkSOhTYLZOD+QjR1yjYBVISU07w1hY9f0fBUjA?= =?us-ascii?Q?qmdtnXYn4JQH0iNZFXV9lfb2m6DiTNIVd7QHsIuqI5r3HSsvWrJyB8tHhDaf?= =?us-ascii?Q?jQUIHWGItLc1hh6Wfi5MMrvjX/ODbz9zPCbxMEkNu0wUyhzZMwKBbdQ6Fwzz?= =?us-ascii?Q?KrnlMB45LC4FlqTw8j1n11zok/FqeKeSQDmLdXMREQminCGZiwD8hJFnQ126?= =?us-ascii?Q?2LBcSXwQxWQyUOk4POryl+gJvOm87o2xWg7kge8nTsi1kZRJX0lezu7nyGrZ?= =?us-ascii?Q?uKJg87DM5JV17Gt9mFdpV9pmtRXk/50GS31xodxXhOSyVq8mwfsm5X0ebd08?= =?us-ascii?Q?lkEWWHns3bI+ZUBPA+j33LSXXyZf57OrrYl0ny4FKHfjdwEdFWLEF5C7CKvz?= =?us-ascii?Q?8Yns76Kh6QCAevV5DWXeJ+Te7rOA6RnGUwyqA06U98N0pUeDHuEUhwwVeGQq?= =?us-ascii?Q?aU/V/DEStZO0Y/gwJqpAm2QEtxFYdZkbZVz59LIYPB4Z19Gp/izVKZGJJHWD?= =?us-ascii?Q?LxjaWfpCVcP0j1C01GAe2JMT70IY/gtEZuq0wV3eFdax4MKk4nmnZT6MZ6gk?= =?us-ascii?Q?uQRch/y1ribueU19LaTFl79BqNyrsMxkD43MygCDO+KXTK3ZfqGWJhHwlpMF?= =?us-ascii?Q?c2/qaZtadOVbZrzPsWypzJCIwtZHE60JATkRXvGrsUFCdtzsDC7Yea9YHySp?= =?us-ascii?Q?bgq6djNRbJHM6w+CO+Fl0uJonPkgZ8h0NgepvpJIrFdYfGKEWc/RfBzD6Qjx?= X-MS-Exchange-AntiSpam-MessageData-1: V/idVtkCyZFaQQ== X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 6ca15ec8-b133-4e1e-a615-08ded7c1e0e9 X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2026 22:41:23.6252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YxmtOy6DnknT4kUGZRvzqiYORI+ECH3qdgejKoEH95IxVwosrxzkQdVu7BrjVWOMNMEJ9Uqq1f/lH8VNer3DGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB4652 X-purgate-ID: tlsNG-d25034/1782945689-93536D51-D26E2C5F/0/0 X-purgate-type: clean X-purgate-size: 2072 Currently, during ARM Xen's SMP initialization, if there is a Device Tree error (such as an invalid 'enable-method'), cpu_possible_map can end up being sparse. The issue here is that nr_cpu_ids is calculated in a way that doesn't properly account for the maximum CPU ID when the map is sparse, causing a mismatch. For example, if cpu_possible_map is 0xff0f, nr_cpu_ids becomes 12, but the actual maximum CPU ID is 15. Xen's common code is built on the assumption that 'CPU ID < nr_cpu_ids', so this mismatch can break things. To fix this, modify dt_smp_init_cpus() so that if the arch_cpu_init() call fails, we don't consume the CPU ID slot. Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring up") Signed-off-by: Hirokazu Takahashi --- Changes in v3: Restore the NR_CPUS check to its original place to properly handle duplicate nodes. Changes in v2: Fix an issue where cpu_logical_map(0) is cleared when boot CPU initialization fails. xen/arch/arm/smpboot.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 7f3cfa812e..ba5fd2dd52 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -238,7 +238,9 @@ static void __init dt_smp_init_cpus(void) if ( (rc = arch_cpu_init(i, cpu)) < 0 ) { printk("cpu%d init failed (hwid %"PRIregister"): %d\n", i, hwid, rc); - tmp_map[i] = MPIDR_INVALID; + + if ( i != 0 ) + cpuidx--; } else tmp_map[i] = hwid; @@ -251,10 +253,9 @@ static void __init dt_smp_init_cpus(void) return; } - for ( i = 0; i < cpuidx; i++ ) + /* Skip CPU 0 as it was already initialized in smp_prepare_boot_cpu(). */ + for ( i = 1; i < cpuidx; i++ ) { - if ( tmp_map[i] == MPIDR_INVALID ) - continue; cpumask_set_cpu(i, &cpu_possible_map); cpu_logical_map(i) = tmp_map[i]; } -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 23:14:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 23:14:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351035.1608366 (Exim 4.92) (envelope-from ) id 1wf485-0002R1-93; Wed, 01 Jul 2026 23:14:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351035.1608366; Wed, 01 Jul 2026 23:14:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf485-0002Qu-60; Wed, 01 Jul 2026 23:14:05 +0000 Received: by outflank-mailman (input) for mailman id 1351035; Wed, 01 Jul 2026 23:14:03 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf483-0002Q2-J4 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:14:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf482-005FMV-W6 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 01:14:03 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a459f0d-2eae-0a2a0a5409dd-0a2a4503aa22-12 for ; Thu, 02 Jul 2026 01:14:01 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a459f38-ec1a-0a2a45030019-d561b3388d86-3 for ; Thu, 02 Jul 2026 01:14:01 +0200 Received: from 186-249-148-121.shared.desktop.com.br ([186.249.148.121] helo=[127.0.1.1]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf47v-007mwb-Nl; Thu, 02 Jul 2026 01:13:55 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Cc:To:Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KPoh5iZtQe5yjJ8BhKFDj02hpm18fz4Usa2v0aCCjdc=; b=gJU7SPkIwRAlDPLQHflFtQ7hpg uJBIUv8st2IiEmQcrpa124KakyyBu0aIOfjP9xqd2/yul6k45MUQEiFRtCTCmvmcfN0XkW32Pl9Xr b2Z2h4Rw8ppO5YNoAHQzGbNQMcTx+ay8X6pfi7iKSiNiZ/iSCzgfgiLkkrwofV8XH9zZkZzOKAFX5 omKAsq1mys1x2AGbGX6h7MRIoeofeRT12VlR8WPF46Y7VlB/GkkY1lZ5ZLZRODQTiv4c0C0L2SHGI KWGy0QFDUiQAv1aTBONRS61exqlVDFlpe3KdBNghouvUB2ecfGNOqa3fhNfJu32/SVr9bLweP/hc4 0vyyoUIw==; From: Mauricio Faria de Oliveira Subject: [PATCH v6 0/4] x86/pvh: fix unbootable VMs again (PVH + KASAN) Date: Wed, 01 Jul 2026 20:13:49 -0300 Message-Id: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAC2fRWoC/33OwW7DIAyA4VepOI8JDJhmp73H1ANxTIPWkSpMq FOVdx/tpZ0S7fhb8mdfReE5cRFvu6uYuaaSptwCX3aCxpCPLNPQWoACVBZAnusoP0MJWaZ8Spk lcgzkfdQ9eNHWzjPHdLmTH4fWYyrf0/xzv1D1bfoPVrVU0jPqzhprqYP3dAynFF5p+hI3rcKz4 DcEaAKQ8/1+oBgxrATzEByoDcE0oeeBPXaETH4l2GcBNwTbhGC0YgzgmIaV4B4Cmq0fXBMchEi d73re6z/Csiy/Ee0ZMrkBAAA= X-Change-ID: 20260422-pvh-kasan-inline-6efac77f1b27 To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mauricio Faria de Oliveira X-Mailer: b4 0.14.2 X-purgate-ID: tlsNG-33051d/1782947641-077265D1-A708DE76/0/0 X-purgate-type: clean X-purgate-size: 7218 The issue of unbootable VMs with CONFIG_PVH due to CONFIG_KASAN is back. Booting directly from vmlinux (instead of bzImage) now fails with gcc-14/15 (but works with gcc-12/13) if CONFIG_KASAN_GENERIC is set, on Ubuntu 25.10. The PVH code is required/supposed not to use the KASAN memory access check in the kernel entry point as KASAN has not yet been setup, or an exception is hit and the boot fails. This was previously described and addressed with __builtin_mem{cmp,set}(): - commit 661362e3dcab ("xen, pvh: fix unbootable VMs (PVH + KASAN - AMD_MEM_ENCRYPT)") - commit 416a33c9afce ("x86/cpu: fix unbootable VMs by inlining memcmp() in hypervisor_cpuid_base()") - commit fbe5a6dfe492 ("xen, pvh: fix unbootable VMs by inlining memset() in xen_prepare_pvh()") However, even with __builtin the compiler may decide to use the out of line function instead of the inline implementation. So, that does not really fix the issue unconditionally; see details below. In order to address this, it's required to switch to inline implementations that do not depend on the compiler. There's such a memset() in and memcmp() in 'boot/string.c'. Use them instead of builtins in PVH entry. Testing: - Booting from vmlinux (fixed) and bzImage (still works) using allnoconfig + CONFIG_PVH + CONFIG_KASAN with gcc-12/13/14/15. - Building with CONFIG_KEXEC_FILE, CONFIG_CFI and !CONFIG_KASAN with LLVM 20 (check for a build error not caught previously). Details/Debugging: - Only CONFIG_PVH (works): make allnoconfig ./scripts/config \ -e 64BIT -e HYPERVISOR_GUEST -e PVH \ -e SERIAL_8250 -e SERIAL_8250_CONSOLE make olddefconfig make -j$(nproc) vmlinux qemu-system-x86_64 \ -accel kvm -nodefaults -nographic -serial stdio \ -kernel vmlinux -append 'console=ttyS0' ... SeaBIOS (version ...) Booting from ROM... Linux version ... ... - With CONFIG_KASAN (fails) ./scripts/config -e KASAN make olddefconfig make -j$(nproc) vmlinux qemu-system-x86_64 \ -accel kvm -nodefaults -nographic -serial stdio \ -kernel vmlinux -append 'console=ttyS0' ... SeaBIOS (version ...) Booting from ROM... - Debugging: Enable debug info and rebuild. QEMU: enable and wait for GDB, stop rebooting, remain running. qemu-system-x86_64 \ -s -S -no-reboot -no-shutdown \ gdb vmlinux (gdb) target remote localhost:1234 ... (gdb) c ... Thread 2 received signal SIGQUIT, Quit. ... (gdb) info threads Id Target Id Frame 1 Thread 1.1 (CPU#0 [running]) bytes_is_nonzero ( start=0xfffffbfff031eebe , size=1) at .../linux/mm/kasan/generic.c:98 * 2 Thread 1.2 (CPU#1 [halted ]) 0x00000000000fd0a9 in ?? () ... (gdb) thr 1 ... (gdb) bt #0 bytes_is_nonzero (start=0xfffffbfff031eebe , size=1) at .../linux/mm/kasan/generic.c:98 #1 memory_is_nonzero (start=0xfffffbfff031eebe, end=0xfffffbfff031eebf) at .../linux/mm/kasan/generic.c:115 #2 memory_is_poisoned_n (addr=0xffffffff818f75f0, size=8) at .../linux/mm/kasan/generic.c:140 #3 memory_is_poisoned (addr=0xffffffff818f75f0, size=8) at .../linux/mm/kasan/generic.c:172 #4 check_region_inline (addr=0xffffffff818f75f0, size=8, write=false, ret_ip=18446744071585002062) at .../linux/mm/kasan/generic.c:191 #5 kasan_check_range (addr=addr@entry=0xffffffff818f75f0, size=size@entry=8, write=write@entry=false, ret_ip=18446744071585002062) at .../linux/mm/kasan/generic.c:200 #6 0xffffffff813eb283 in __asan_loadN (addr=addr@entry=0xffffffff818f75f0, size=size@entry=8) at .../linux/mm/kasan/generic.c:278 #7 0xffffffff815df24e in memcmp (cs=cs@entry=0xffffffff818f75f0, ct=ct@entry=0x1be2fe4, count=, count@entry=12) at .../linux/lib/string.c:683 #8 0xffffffff81ba2323 in cpuid_base_hypervisor (sig=0xffffffff818f75f0 "XenVMMXenVMM", leaves=2) at .../linux/arch/x86/include/asm/cpuid/api.h:206 #9 xen_cpuid_base () at .../linux/arch/x86/include/asm/xen/hypervisor.h:46 #10 xen_prepare_pvh () at .../linux/arch/x86/platform/pvh/enlighten.c:119 #11 0x0000000001ba2588 in ?? () #12 0x0000000000000000 in ?? () (gdb) Frames #7-#8 show the non-builtin memcmp() (lib/string.c) was called even with __builtin_memcmp() being used in cpuid_base_hypervisor(). Signed-off-by: Mauricio Faria de Oliveira --- Changes in v6: - Patch 1: - Explain the return value difference between __inline_memcmp() and memcmp(). - Patch 2 (added): - Group __inline string functions in . - Link to v5: https://lore.kernel.org/r/20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com Changes in v5: - Create a minimal separate header in instead, to be used by 'boot/setup.c' and (Borislav Petkov). - Patch 1 (in v4/v3) is no longer needed; removed. - Patch 1 (in v5): - Briefly mention there are issues with . - Remove 'Reviewed-by: Jurgen Gross' to be conservative (same code change and result, but the means changed). - Link to v4: https://lore.kernel.org/r/20260526-pvh-kasan-inline-v4-0-a310e6a25ecd@igalia.com Changes in v4: - Patch 1: address Juergen's feedback: - s/In next patch/In a future patch/. - Move footnote (Reasons not to include...) after "---". - Add 'Reviewed-by: Juergen Gross' in patches 1 and 2 as well. - Link to v3: https://lore.kernel.org/r/20260520-pvh-kasan-inline-v3-0-bede769c6ec7@igalia.com Changes in v3: - Create and use a separate header for inline string functions to fix a build error reported by kernel test robot (patch 1). - That also removes '#ifndef _SETUP/#endif' in . - Link to v2: https://lore.kernel.org/r/20260427-pvh-kasan-inline-v2-0-2c57b8dcff6a@igalia.com Changes in v2: - Add comment about the return value of __inline_memcmp() in patch 1. (v3: now 2) - Add 'Reviewed-by: Juergen Gross' in patches 2 and 3 (v3: now 3 and 4). - Link to v1: https://lore.kernel.org/r/20260422-pvh-kasan-inline-v1-0-7e6194344c92@igalia.com --- Mauricio Faria de Oliveira (4): x86/asm, x86/boot: expose inline memcmp x86/asm: group inline string functions x86/cpuid: fix unbootable VMs by really inlining memcmp() in hypervisor_cpuid_base() x86/pvh: fix unbootable VMs by really inlining memset() in xen_prepare_pvh() arch/x86/boot/string.c | 6 ++--- arch/x86/include/asm/cpuid/api.h | 2 +- arch/x86/include/asm/shared/string.h | 46 ++++++++++++++++++++++++++++++++++++ arch/x86/include/asm/string.h | 21 +--------------- arch/x86/platform/pvh/enlighten.c | 3 ++- 5 files changed, 52 insertions(+), 26 deletions(-) --- base-commit: 7de6ae9e12207ec146f2f3f1e58d1a99317e88bc change-id: 20260422-pvh-kasan-inline-6efac77f1b27 Best regards, -- Mauricio Faria de Oliveira From xen-devel-bounces@lists.xenproject.org Wed Jul 01 23:14:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 23:14:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351036.1608375 (Exim 4.92) (envelope-from ) id 1wf486-0002f3-ER; Wed, 01 Jul 2026 23:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351036.1608375; Wed, 01 Jul 2026 23:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf486-0002ew-Bm; Wed, 01 Jul 2026 23:14:06 +0000 Received: by outflank-mailman (input) for mailman id 1351036; Wed, 01 Jul 2026 23:14:04 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf483-0002PW-Ek for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:14:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf482-00ASh6-79 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 01:14:02 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a459ef1-e002-0a2a0a5209dd-0a2a450cd8fc-44 for ; Thu, 02 Jul 2026 01:14:01 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a459f38-f399-0a2a450c0019-d561b3388c7a-3 for ; Thu, 02 Jul 2026 01:14:00 +0200 Received: from 186-249-148-121.shared.desktop.com.br ([186.249.148.121] helo=[127.0.1.1]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf47z-007mwb-7e; Thu, 02 Jul 2026 01:13:59 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3Q8RixWFQd74HMuP5HaGOdYS+13SFKaeVy8ocqIumpg=; b=noPoX/XetgpOegc7HwgSefBTmJ KZDckcpZmFWNHlYHhVu5Xvnno3tKh4KgXwaHzQz+8rRdFUEXbaXEaNl79EufzCb/H8FIOPLShy6Ko 5ovjkLAdPHWkkNTKgy9aGBTj95EWKkXF9z5XesfcwxtKvShvjMogxAHmKNgHRPSvEi1K3dRhqXZFc 4ePE/HzL5Lrv9KcQP/01M4LZ/2w8TzYQVJ0Vgu7Ici7G6UE+JHrjC7vLHr/e/RdNllf2edC92wKER ownvwb2tgOvy/l2i9rEKEJEsTz1emPXlZTc/dp3bnvDazi5rEliXY5h6g1vJBCWAB/qMG2paFajNy AI19vuiA==; From: Mauricio Faria de Oliveira Date: Wed, 01 Jul 2026 20:13:50 -0300 Subject: [PATCH v6 1/4] x86/asm, x86/boot: expose inline memcmp MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260701-pvh-kasan-inline-v6-1-ba99045dfa9f@igalia.com> References: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> In-Reply-To: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mauricio Faria de Oliveira X-Mailer: b4 0.14.2 X-purgate-ID: tlsNG-d25034/1782947641-0D128D51-30478BAA/0/0 X-purgate-type: clean X-purgate-size: 2683 Move the inline memcmp function currently only available in 'boot/string.c' into the shared string function header to be reused. This is not done through to avoid pulling unnecessary code in 'boot/string.c' that causes build errors in 'boot/compressed/string.c' and 'purgatory/purgatory.ro'. Signed-off-by: Mauricio Faria de Oliveira --- Thanks to David Laight for noticing the return value difference between inline and regular memcmp(). --- arch/x86/boot/string.c | 6 ++---- arch/x86/include/asm/shared/string.h | 20 ++++++++++++++++++++ arch/x86/include/asm/string.h | 2 ++ 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c index ac0f900ebc47efa81c92e1bb2010ea41677899c4..be454a6864225f3a972c3e81826b77ed4e8a57fe 100644 --- a/arch/x86/boot/string.c +++ b/arch/x86/boot/string.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "ctype.h" #include "string.h" @@ -31,10 +32,7 @@ int memcmp(const void *s1, const void *s2, size_t len) { - bool diff; - asm("repe cmpsb" - : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); - return diff; + return __inline_memcmp(s1, s2, len); } /* diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h new file mode 100644 index 0000000000000000000000000000000000000000..02b92927553f7b8e1c87e6122bbaa70439e57ea7 --- /dev/null +++ b/arch/x86/include/asm/shared/string.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_SHARED_STRING_H +#define _ASM_X86_SHARED_STRING_H + +/* + * This inline memcmp() returns 0 (equal) or 1 (not equal). + * The regular memcmp() returns <0 (less than), 0 (equal), or >0 (greater than) + * to indicate ordering as well. + */ +static __always_inline int __inline_memcmp(const void *s1, const void *s2, size_t len) +{ + bool diff; + + asm("repe cmpsb" + : "=@ccnz" (diff), "+D" (s1), "+S" (s2), "+c" (len)); + + return diff; +} + +#endif /* _ASM_X86_SHARED_STRING_H */ diff --git a/arch/x86/include/asm/string.h b/arch/x86/include/asm/string.h index 9cb5aae7fba9ffcf0f5af8f939d30467750ccaa9..8d271a451721d97f78a84009613381414f91f2a6 100644 --- a/arch/x86/include/asm/string.h +++ b/arch/x86/include/asm/string.h @@ -8,6 +8,8 @@ # include #endif +#include + static __always_inline void *__inline_memcpy(void *to, const void *from, size_t len) { void *ret = to; -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 23:14:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 23:14:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351038.1608393 (Exim 4.92) (envelope-from ) id 1wf48A-00036b-3H; Wed, 01 Jul 2026 23:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351038.1608393; Wed, 01 Jul 2026 23:14:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf489-00036G-Vf; Wed, 01 Jul 2026 23:14:09 +0000 Received: by outflank-mailman (input) for mailman id 1351038; Wed, 01 Jul 2026 23:14:08 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf488-00035C-MA for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:14:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf488-00C8tC-37 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 01:14:08 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a459f3d-bab6-0a2a0a5309dd-0a2a4508e37a-4 for ; Thu, 02 Jul 2026 01:14:08 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a459f3f-edec-0a2a45080019-d561b338e1da-3 for ; Thu, 02 Jul 2026 01:14:07 +0200 Received: from 186-249-148-121.shared.desktop.com.br ([186.249.148.121] helo=[127.0.1.1]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf486-007mwb-7X; Thu, 02 Jul 2026 01:14:06 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=H2GAc7mtrFpKl87p+adcJZhrkVbc1evwDywNzt1ulrU=; b=XF50oGI0B1AVA0SygXsrbkAJWO MPzZrCGnsc/X6R8NUQ+rMJcfIphLSA+9BgtQUxVku1RqpDCKHq2aRByKjxjXSdH4ZnQZOhclsCQDd GWMzKLslUvsUcv1b4SSD77qASJJZ89bR5R0re7Xw7wARnZdAp22rcLDA8uCs+WoerdE7pYTGX6uzT 8pWn5T7OXnOYqZRP3jn1Lnl8hlXPjsGgF2idGEfVFVlMQUyTrsTg1iy112bvUnrC4S1gWOMHlp8Qy 2Ys8KsaGnKCxln7TSjNCrYXzyCLaSP7HY6fJS2Hr9U8NUiFfoGtSKNmQ2cc0H5BhGrhv6iu0hrPft 74vVrLig==; From: Mauricio Faria de Oliveira Date: Wed, 01 Jul 2026 20:13:52 -0300 Subject: [PATCH v6 3/4] x86/cpuid: fix unbootable VMs by really inlining memcmp() in hypervisor_cpuid_base() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260701-pvh-kasan-inline-v6-3-ba99045dfa9f@igalia.com> References: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> In-Reply-To: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mauricio Faria de Oliveira X-Mailer: b4 0.14.2 X-purgate-ID: tlsNG-c1860d/1782947647-4253F3FC-93952711/0/0 X-purgate-type: clean X-purgate-size: 1458 Even with __builtin the compiler may decide to use the out of line function instead of the inline implementation. The existing code is broken with gcc-14/15 but not gcc-12/13 (Ubuntu 25.10) and vmlinux no longer boots with CONFIG_PVH if CONFIG_KASAN_GENERIC is set. For testing purposes, if the size argument is reduced from 12 to 8 then the compiler decides to use the inline implementation; that shows results vary. Switch the builtin to the inline implementation to address it. Fixes: 416a33c9afce ("x86/cpu: fix unbootable VMs by inlining memcmp() in hypervisor_cpuid_base()") Signed-off-by: Mauricio Faria de Oliveira Reviewed-by: Juergen Gross --- arch/x86/include/asm/cpuid/api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/cpuid/api.h b/arch/x86/include/asm/cpuid/api.h index 82eddfa2347b32b76c2ea9b85f005ca5416ac71f..2d9f3d4d63de6e721f275d9e80d372edbdfedf30 100644 --- a/arch/x86/include/asm/cpuid/api.h +++ b/arch/x86/include/asm/cpuid/api.h @@ -204,7 +204,7 @@ static inline u32 cpuid_base_hypervisor(const char *sig, u32 leaves) * from PVH early boot code before instrumentation is set up * and memcmp() itself may be instrumented. */ - if (!__builtin_memcmp(sig, signature, 12) && + if (!__inline_memcmp(sig, signature, 12) && (leaves == 0 || ((eax - base) >= leaves))) return base; } -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 23:14:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 23:14:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351037.1608381 (Exim 4.92) (envelope-from ) id 1wf486-0002gp-PT; Wed, 01 Jul 2026 23:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351037.1608381; Wed, 01 Jul 2026 23:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf486-0002gO-Ia; Wed, 01 Jul 2026 23:14:06 +0000 Received: by outflank-mailman (input) for mailman id 1351037; Wed, 01 Jul 2026 23:14:05 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf485-0002Qt-6M for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:14:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf484-005FMV-IP for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 01:14:04 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a459ef7-2eae-0a2a0a5409dd-0a2a450beb0c-40 for ; Thu, 02 Jul 2026 01:14:04 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a459f3b-ac48-0a2a450b0019-d561b338e314-3 for ; Thu, 02 Jul 2026 01:14:04 +0200 Received: from 186-249-148-121.shared.desktop.com.br ([186.249.148.121] helo=[127.0.1.1]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf482-007mwb-O5; Thu, 02 Jul 2026 01:14:02 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p4ShPqNeNQJKvlIwXNQ/fHjMA+LLf6yrUxJsYTGqlvs=; b=PFNIyg8zGPfpmeT3OlZRDqCu3Y AAwjKZUy2MOLiMdV2AK7morDG9ed4p2FSwTQfDqi5BThXkqoLXG10hAzPoL8yLQwLUt/4432hZzhd Qh+zIsjlOcjK+V+cHNddjntdiKyGGhowJzTp1rOGDKLsg3k9jTzAfrLZ3p5fG8LTEWmX2M100YRcp sISsBgeikL7ZLhNgHi0O1PInn5cja+7QvmkBPAyHuNTU3yw4mhVM9w59vN0eGENOy6reUiQEwIyhi yY/leJ/Zx+5lKKGadKxxFoyMPFlIBzyR0BxCgCqTPOq99TkdY7zjBCpV013tbhvB05dWAmxkFTmCH qxa5wC+Q==; From: Mauricio Faria de Oliveira Date: Wed, 01 Jul 2026 20:13:51 -0300 Subject: [PATCH v6 2/4] x86/asm: group inline string functions MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260701-pvh-kasan-inline-v6-2-ba99045dfa9f@igalia.com> References: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> In-Reply-To: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mauricio Faria de Oliveira X-Mailer: b4 0.14.2 X-purgate-ID: tlsNG-42698a/1782947644-39D27220-FBAEA943/0/0 X-purgate-type: clean X-purgate-size: 2391 Group the __inline string functions in the same header. Use since __inline_memcmp() must remain there for use by arch/x86/boot/string.c. Signed-off-by: Mauricio Faria de Oliveira --- arch/x86/include/asm/shared/string.h | 26 ++++++++++++++++++++++++++ arch/x86/include/asm/string.h | 21 --------------------- 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/arch/x86/include/asm/shared/string.h b/arch/x86/include/asm/shared/string.h index 02b92927553f7b8e1c87e6122bbaa70439e57ea7..b1b9c93f90685c8ec4174ef9e24bc7a0e6ba9b8a 100644 --- a/arch/x86/include/asm/shared/string.h +++ b/arch/x86/include/asm/shared/string.h @@ -2,6 +2,32 @@ #ifndef _ASM_X86_SHARED_STRING_H #define _ASM_X86_SHARED_STRING_H +/* + * The __inline string functions are grouped in this file for consistency and + * for use by arch/x86/boot code due to limitations on including asm/string.h. + */ + +static __always_inline void *__inline_memcpy(void *to, const void *from, size_t len) +{ + void *ret = to; + + asm volatile("rep movsb" + : "+D" (to), "+S" (from), "+c" (len) + : : "memory"); + return ret; +} + +static __always_inline void *__inline_memset(void *s, int v, size_t n) +{ + void *ret = s; + + asm volatile("rep stosb" + : "+D" (s), "+c" (n) + : "a" ((uint8_t)v) + : "memory"); + return ret; +} + /* * This inline memcmp() returns 0 (equal) or 1 (not equal). * The regular memcmp() returns <0 (less than), 0 (equal), or >0 (greater than) diff --git a/arch/x86/include/asm/string.h b/arch/x86/include/asm/string.h index 8d271a451721d97f78a84009613381414f91f2a6..dbf59f0d4cca71e2ddce0d8764aeec8782236669 100644 --- a/arch/x86/include/asm/string.h +++ b/arch/x86/include/asm/string.h @@ -10,25 +10,4 @@ #include -static __always_inline void *__inline_memcpy(void *to, const void *from, size_t len) -{ - void *ret = to; - - asm volatile("rep movsb" - : "+D" (to), "+S" (from), "+c" (len) - : : "memory"); - return ret; -} - -static __always_inline void *__inline_memset(void *s, int v, size_t n) -{ - void *ret = s; - - asm volatile("rep stosb" - : "+D" (s), "+c" (n) - : "a" ((uint8_t)v) - : "memory"); - return ret; -} - #endif /* _ASM_X86_STRING_H */ -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Wed Jul 01 23:14:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Jul 2026 23:14:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351039.1608401 (Exim 4.92) (envelope-from ) id 1wf48D-0003OJ-8q; Wed, 01 Jul 2026 23:14:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351039.1608401; Wed, 01 Jul 2026 23:14:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf48D-0003OA-5k; Wed, 01 Jul 2026 23:14:13 +0000 Received: by outflank-mailman (input) for mailman id 1351039; Wed, 01 Jul 2026 23:14:12 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf48C-0003Ml-3z for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 23:14:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf48B-005FMV-H8 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 01:14:11 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a459f3b-2eae-0a2a0a5409dd-0a2a450cd312-8 for ; Thu, 02 Jul 2026 01:14:11 +0200 Received: from [213.97.179.56] (helo=fanzine2.igalia.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a459f42-f399-0a2a450c0019-d561b338ddee-3 for ; Thu, 02 Jul 2026 01:14:11 +0200 Received: from 186-249-148-121.shared.desktop.com.br ([186.249.148.121] helo=[127.0.1.1]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf489-007mwb-Nz; Thu, 02 Jul 2026 01:14:09 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20170329 header.d=igalia.com header.i="@igalia.com" header.h="Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zBAAE6UPiVcuOT4Hdx5zYoG+Uei+rPkEJSxQ4+nbtAc=; b=LyfYNQL68YUxAdNm6mXIXLHXvL SvZnmfL85NGTH+8BXQ9g1x52pAVD3REn6kbl/gLxrAa9MzZfNFdaQE/4w2v7l+TxDwVIQWG4xsmW/ 7yx1UeqoPM4ju5/4ZCtDx2Bb1QeeBGmPO3a0aVPJ/vmnigebk7s8GJZj8nYkpsWtceICos7DfQlF4 1et53Ds5nmFdXeP2g5X25cyfdWmPt5dSX69y9piQDvvUMhXbAXLH8M6aGpDCpDrQrJb6NhOFyUKxY 7wOkHJKIhpPAwQElHU8EL+N7D4C4QAXIWyWkPXgyLTUZCRThdOiWztw7RXThIUhUmIoS3O7CSTZCL UlaFgGaw==; From: Mauricio Faria de Oliveira Date: Wed, 01 Jul 2026 20:13:53 -0300 Subject: [PATCH v6 4/4] x86/pvh: fix unbootable VMs by really inlining memset() in xen_prepare_pvh() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260701-pvh-kasan-inline-v6-4-ba99045dfa9f@igalia.com> References: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> In-Reply-To: <20260701-pvh-kasan-inline-v6-0-ba99045dfa9f@igalia.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Mauricio Faria de Oliveira X-Mailer: b4 0.14.2 X-purgate-ID: tlsNG-d25034/1782947651-93138D51-D82128A4/0/0 X-purgate-type: clean X-purgate-size: 1416 Even with __builtin the compiler may decide to use the out of line function instead of the inline implementation. This particular one (still) generated the inline implementation as expected (at least in these compiler versions) but this is not guaranteed to remain. Switch the builtin to the inline implementation to address it. Fixes: fbe5a6dfe492 ("xen, pvh: fix unbootable VMs by inlining memset() in xen_prepare_pvh()") Signed-off-by: Mauricio Faria de Oliveira Reviewed-by: Juergen Gross --- arch/x86/platform/pvh/enlighten.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/platform/pvh/enlighten.c b/arch/x86/platform/pvh/enlighten.c index f2053cbe9b0ce3d2178938269607c652ae8f528e..cb442cbd9d828619421babb281bfe9759edbca8a 100644 --- a/arch/x86/platform/pvh/enlighten.c +++ b/arch/x86/platform/pvh/enlighten.c @@ -8,6 +8,7 @@ #include #include #include +#include #include @@ -129,7 +130,7 @@ void __init xen_prepare_pvh(void) * This must not compile to "call memset" because memset() may be * instrumented. */ - __builtin_memset(&pvh_bootparams, 0, sizeof(pvh_bootparams)); + __inline_memset(&pvh_bootparams, 0, sizeof(pvh_bootparams)); hypervisor_specific_init(xen_guest); -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 02:14:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 02:14:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351133.1608411 (Exim 4.92) (envelope-from ) id 1wf6wl-0003Zr-Tr; Thu, 02 Jul 2026 02:14:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351133.1608411; Thu, 02 Jul 2026 02:14:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf6wl-0003Zj-Pz; Thu, 02 Jul 2026 02:14:35 +0000 Received: by outflank-mailman (input) for mailman id 1351133; Thu, 02 Jul 2026 02:14:33 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wf6wi-0003Zb-Dy for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 02:14:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wf6wh-005aXr-NR for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 04:14:31 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a45c96b-bab6-0a2a0a5309dd-0a2a4506d3d6-6 for ; Thu, 02 Jul 2026 04:14:30 +0200 Received: from [40.107.74.117] (helo=OS0P286CU010.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a45c983-08de-0a2a45060019-286b4a752b29-3 for ; Thu, 02 Jul 2026 04:14:30 +0200 Received: from TYWP286MB2938.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29e::6) by OS9P286MB4880.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2be::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Thu, 2 Jul 2026 02:14:23 +0000 Received: from TYWP286MB2938.JPNP286.PROD.OUTLOOK.COM ([fe80::939a:c9f7:3b72:1ed5]) by TYWP286MB2938.JPNP286.PROD.OUTLOOK.COM ([fe80::939a:c9f7:3b72:1ed5%5]) with mapi id 15.21.0181.009; Thu, 2 Jul 2026 02:14:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-Id:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LRLVcnxTu4EsiAxj0UY1pQ22TKBvWitIEdbnqJuFLFFqmugxOeP+LS7aM6DIeQ+JqO9cELfNaWLIBPFzqhxHAnko4iJfr05qxX/AIK1tTiYRuXX6PrvfrRmuTBXsWU8GfLrlzd6k57lhtvNm3VSzeNZNNE/W23Zuar5DKTVfKwbk+7hSmJzzxqP46LzBN/s7U7xzf18HodDPsw+yPtZOOJiuHiSRNmeFL8/c3rySUmxwbdN37KNl2w/oITBPXJl8ebnwDMaLM8+QmMoHoOgudbH/OE3++zE4IXGe4rBGhD4TrOYLGx+jel7T2wBDo2Y2UeIJRhJ05qsf7vjBY5QcNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JEQYCUB/AsrZes5fX6l4h5HMkIT20KsBaBAhAmYHYJ0=; b=ZI+8zQv3pvn8roMYreM9rPaDU2KVm446+yEJo8sgxx8gTYnmluOQlI9pj/APFG/WtCJouBHPlUcOzdDrDJ4lrzomar6qvyVJyf8FZdenP0csuULtpNovhRnBiunboeXWwGXqNRbupo/oXy7ORHD9axwhRYkG+0vmyHnoDCcj7yV/5qoW43Y9CMAl6mhf0ub1ng9Q93M/+oi9AKBOR2uCKr+pOdD4rNFKclljURIXHevqiVM0z3wFDi6Y/8/GcQZzNHJM0DMjx1qielDI9giCHVc4DVM+WJjd0c5zOrVdo6B5PIYRv9OOwqfRgKVMvCUhI6naOEGf2rrdhcRQuuRbXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JEQYCUB/AsrZes5fX6l4h5HMkIT20KsBaBAhAmYHYJ0=; b=pmibQIbe9HWnlJiLLMjsnaHN9QeWX+U1/PfJMG51FtbL5QJv1c8wqqpR7v2lTbzY/FkrCEQfLaBqnuSfL7O4fKFhjP5lwVKegfvuT78N/LKXQA9aKEEuIdVEVtP3pt4fslMi1hOy8tODm8LEnoHFlrls5RRVmUzfIqJxvdmtNz0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Ryo Takakura To: roger.pau@citrix.com, andrew.cooper3@citrix.com Cc: xen-devel@lists.xenproject.org, ross.lagerwall@citrix.com, sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, michal.orzel@amd.com, Volodymyr_Babchuk@epam.com, anthony.perard@vates.tech, jbeulich@suse.com, taka@valinux.co.jp, den@valinux.co.jp Subject: Re: [RFC] xen/arm64: livepatch: enable attaching callbacks Date: Thu, 2 Jul 2026 11:14:20 +0900 Message-Id: <20260702021420.8283-1-takakura@valinux.co.jp> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: TYCP286CA0181.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:382::19) To TYWP286MB2938.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYWP286MB2938:EE_|OS9P286MB4880:EE_ X-MS-Office365-Filtering-Correlation-Id: 6566169f-088d-43e3-d306-08ded7dfa1b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|7416014|3023799007|5023799004|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 6OFmh+gV+pKKf2OWjvHuPfvJ8EzGj7/s0L3tMqEYrOIr4J4nsu1QuJRVcCrfreJMPdF9P/7z5hbaU07VZ3zVQ74exO7h+wKqncwgFP0gKYRjd4m85DmNvvltCc5TPGpV5FNbAE9EO7OqHKu2mMJI+YmDS2/YuBI1xfJ7JH6pzNYn7VyXdf5Xe4Z7WbIO5uxftldLxh8hcqcZoAIMtwZVlEoEBdXQx6u/a2iSPbGsdqIINoY0xjCElbhp4ir5ApLmpncyT1X467NUwH3dpiodOtNZAlDjmLQ9dOrCxsjHSXkb/1ce+yEdAPXyRkaBrowXwXInHXkauOBQx6i3T/V/eZJXYgzDFddJ2Buvyref57jvzOXNc1uPKo/6ZQ7qBFoL4ToVHIihKrQ8+YoA5REb1l6Gv6SJK8/mF6ymSW7I8YGQ09VtFeBZ4Z26D2HZLA4q3gRCMYzcbDu5oyiKf6YhjcomIEWT/5GhwUfcCLIinsWF6NzSuN3TLqRjy0yzyET1Mm6xnyK7XY0xQFartBCvFJ8Fs/FKF5PMnArkpdaWxo+kJo0SZwTAeJzs4sYLIdon93m/zE549CK4Sw3BzxLtK/U0X22iVMisdwW15bV+qXow0WX0IK6aDYr2fX7KiQF/hOoP8KkLHJdAwtJV4YN2lxu7rYBkpKnaBEjDyNKprTQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYWP286MB2938.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(7416014)(3023799007)(5023799004)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZStSeFBGbERBRkxDODNGR285NUdkTzNkc3p5N2wxN0YzVHVqOE96TC9ORVBG?= =?utf-8?B?TGt2SjZTQnBlcnYzWENHTmVYRXQ1WFJSM2k4NDQ0Y3N6cW1ka3VFOVdaZkxY?= =?utf-8?B?bjlOdlRsQjZaa1hNU2pIR1lwbmtDQlFUaUhLWXRiWG9nRzM1d0ppelZJRCtV?= =?utf-8?B?ZTBxWkV1S3d6V29URmZyZXh5K0NtRWdVQkJId2loa0EyNzcxNGtPOG1hM1Qx?= =?utf-8?B?alJ5eWxTalVQei8xR2ZwM05PZDJvL3lqSVJ4NWw5WDFGU1c5WURLcXpLSTNK?= =?utf-8?B?TkYremhpM01NcXFjR0hiMFRlYVlJSVJobmU4YXZ3Q0pIYzlyMlFNWE03Tmor?= =?utf-8?B?V1JGUlFSVnl6U0NzVUs2bThzWXlnNGZnQkxaRlpCTHZuclFJVWh6eS8wQWhK?= =?utf-8?B?Wmc2SmZhWEZjQXU3LzYrUWRRZ2R0aUNCeTBhLy9yT0FHd3FwMzQremVaR2dJ?= =?utf-8?B?b1JNUVBaTHd1dXhBR3ZKWWFrSW1scU82aDlnRTVYREpRTkJzZ3dyTjcyVXJv?= =?utf-8?B?eEtNaTdzNUNldzdIVDFvaGI3NGpJYXF0OGFvNzNraFdGei9EeUVyNFZJTUNo?= =?utf-8?B?RGtLSWNzNlp0VDlIUWxDQ2JtZ0t0TGhKQnQxN09KSG1uRjd6Q2VOWGdQWHVv?= =?utf-8?B?WTA5QWhSTXVYdmp6bXZ0RTB5ZnZZbVFpbnNuRVR3UWNrcXBTNi9EN3ZNbmRK?= =?utf-8?B?WVZFOEsvanh5MTlhNjZCV2Rxc3lVbzRMQ3BseG9OK050Yjk2dXVscEtSS25N?= =?utf-8?B?bVJlT3h0dFNnN05kbUdJeWZwNHg5S3ZIOUFlTkU2UHlXc2M2aXQ3QVZYaHlw?= =?utf-8?B?WTVQQVdSb2xZVGVrTlFZaHBvWWNSU3Vzc0c2QWRTRVFvdXNXRi9UYjU2M2Vu?= =?utf-8?B?eTNvS1NlWU56dnhLZDBNdzUzb0FiTEsrVWxzQVpqQ2Z6Z1AyUkduRlJiMzVL?= =?utf-8?B?OEZhQUltSS9aeTRodGcxMmhuM1RlWWVVN29xVE01dCtiRGVTT1JZSHRvWlBu?= =?utf-8?B?dG80Y0QwRC9ERHZ5bDh2VVVMbE9RRVY2MkRLaVRnQ3Fjd1VPeGVGbWp0U29G?= =?utf-8?B?WkVIcitCYmlzdWtnQmtNMi8zOVhLYXNxMXFFQ2RmVGxKQmZRZVRYeDh4cVNC?= =?utf-8?B?UEEvYTVwQ0hvelVxM1NvaHQxWElhSE5MWUlmV0l0TjNTMDhiZytmRFNQaHV1?= =?utf-8?B?eGoycTdJNWd4WFlLelc1bi9JS01MM3phS0xMQWQ4d1Yyb2tzWnVSZW5MZHU3?= =?utf-8?B?UFN6N1crd1poUGtObzRXb0RPZklzYjI1TmxGKzJNSHQvZkZwOHhaUHlqb1NS?= =?utf-8?B?Ty80RHdKYXF1ZVNvUDJrVzVHa0ExdTBPSlVyRWNteU16VmduaVpCc1MvdjBo?= =?utf-8?B?bWpDUWd1WTluSGRXQjJsSWQ0NFRuNUtYK0I1cjdJK3JUUXF2VWh5V2JIVmlD?= =?utf-8?B?SmpVcHg2aUJ3Tis0K1JXa2k1K2ViTlVCV1grdUhPQzQxT0NRMlBSUW9CbVlM?= =?utf-8?B?cjlEUE1meEVIOWs3aXh0ejBManBmbmhoSTVJcEZwR0dBUm0yN0w3amhiTUtO?= =?utf-8?B?T05zU2k0U1JYRkg2L3d3R2RwNkhlN3ZoZ29TZ3pkMVBEa1FsV2RDQnNxNU5u?= =?utf-8?B?UU1qYmIzdk5GRFdQbzMyK1Zwa1UzNWUreng0eWhSZFNCeWNDenFnVDJWdVE5?= =?utf-8?B?dVNLVmV5MThqTEZBOXNNZURWQ1JGR09yQXd5UjkvbEVWL3UwRTJJbjVOdUFh?= =?utf-8?B?Zyt2NGlBVE1VWTJoWEQyS20vSFdES0FFdXJVeW5RblRvSitpdVhwYkQ2N3c2?= =?utf-8?B?QXJvU1lHKzZja3hBdXVDRGlZY0k0OUlSN1VpR2E0blhZTFpSR3JEMGs3SGw0?= =?utf-8?B?L1Vxd2ZpbWtMOGhtRWMxNERSdXJCNSttanltcEZRZUIrN0hidExzN3lBa21s?= =?utf-8?B?NXBLTTlEWmVERnJ1RGhrZ1d2aUZkcFBSNXIyQXRvcFpWaWhTN1ArRGYzTDYr?= =?utf-8?B?QnI0MXpkSHNHeXN0Z0ozUGR5WjMvR1FTRTY4eTBUTkZUNU5lanZiakwrNmho?= =?utf-8?B?OWl1VkpsamUzZzhUYmNKWWdvYTZOZDRpTG5mSXVJanRSSjYzaHVNM0Y2cmZ0?= =?utf-8?B?Yk8rRy85SlhjSDB6dnV6MnR6ZDlKRmE5bnArTG5IZXQray9SQi9NbnRVSG9Z?= =?utf-8?B?RGNxMXdQbkIxZ2pjekYvUVFEUlRKSm9VeGpuWlU4RDVZTzRYU2d6VC9tS3R6?= =?utf-8?B?SlhEK0xwWEFQWFVrZ0xOdjFiczAyeldCeU8vQllkeW5OT2krZ2VRNmZzV1dW?= =?utf-8?B?TkhsbitCYksvek52NFJlbkYxOGJqSjV1Q1d5WkxCOXdIazFXMTlTZz09?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 6566169f-088d-43e3-d306-08ded7dfa1b7 X-MS-Exchange-CrossTenant-AuthSource: TYWP286MB2938.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 02:14:22.8251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jyndUgXI4drN6I+nXSsBGAr79fiAlTfOBQ+a3dO/iwdJPYp+SBuSnuVTqT+F1K2NdUKytAeeGpIMo9mADWZwFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB4880 X-purgate-ID: tlsNG-16d1c6/1782958470-C513768D-44D0127E/0/0 X-purgate-type: clean X-purgate-size: 3354 On Wed, 1 Jul 2026 15:50:59 +0200, Roger Pau Monné wrote: >On Wed, Jul 01, 2026 at 06:09:08PM +0900, Ryo Takakura wrote: >> On Tue, 30 Jun 2026 08:47:14 +0000, Roger Pau Monné wrote: >> >On Mon, Jun 29, 2026 at 11:01:28AM +0900, Ryo Takakura wrote: >> >> Linux ftrace allows registering callbacks which is useful >> >> for debugging and tracing events. On Linux, it is done by >> >> reserving function entry points at compile time which can >> >> later be patched to branch to a trampoline. >> >> >> >> This patch implements similar callback feature, but with >> >> different approach using existing livepatch infrastructure. >> >> Instead of reserving function entry points at compile time, >> >> the traced function will be livepatched so that it branches >> >> to the trampoline. >> > >> >While this is an interesting usage of the livepatch logic in new ways, >> >may I ask why not do as Linux and add an empty function preamble that >> >can be replaced at run-time with calls to hooks? >> > >> >You could still re-use most of the livepatch logic for handling the >> >addition of the hook calls, but it would be nicer in that we won't >> >need to move the original function. >> >> I agree that we can reuse a lot of livepatch logic. >> >> >> The role of the trampoline(illustrated below) is to preserve >> >> the context while jumping to the tracer function, and return >> >> back to the traced function with its context restored. >> > >> >Alternatively - why not use livepatch-build-tools against a build with >> >the added hooks to generate a proper livepatch? This looks a bit >> >fragile to me (see the question from Andrew about fixing up >> >instruction pointer relative references). >> >> Yes, I think proper livepatching would still be preferred >> given all the concerns Andrew and Roger raised. >> >> >On x86 at least we would also need to adjust the bug frames and >> >exception table contents, and the contents of the symbol table to >> >account for the function being moved. >> > >> >IOW: it looks like overall this is a lot more work than possibly >> >reserving a function preamble to add hook calls? >> >> Yes, I agree. >> (I wasn't aware of this additional work when I replied >> to Andrew yesterday, thanks!) >> >> And if I were to summarize the discussion so far, assuming we >> still want to add a tracing-feature, I think we are in agreement >> adding an empty function preamble like Linux. >> (I personally would still like to see a framework on Xen >> that is more convenient and tracing-friendly which can be used >> reliably at the same time) >> >> If this sounds reasonable, I will try preparing one based on >> the feedbacks I was given so far: >> - Use of Linux-like reserved function preamble >> - Use of __attribute__((no_caller_saved_registers)) >> - Split replacement and preamble-hook handling in common code >> >> Let me know your thoughts! > >I think the above approach is easier to implement, and more reliable >than the current proposal. Good! >Do you also have the intention to integrate this with existing tracing >tools used by Linux or other OSes? That would be very useful IMO. Although I don't have anything specific in mind yet, I also hope for more tools to be integrated in the future :-) Sincerely, Ryo Takakura From xen-devel-bounces@lists.xenproject.org Thu Jul 02 05:54:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 05:54:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351187.1608420 (Exim 4.92) (envelope-from ) id 1wfANH-0000U9-7S; Thu, 02 Jul 2026 05:54:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351187.1608420; Thu, 02 Jul 2026 05:54:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfANH-0000U1-2b; Thu, 02 Jul 2026 05:54:11 +0000 Received: by outflank-mailman (input) for mailman id 1351187; Thu, 02 Jul 2026 05:54:09 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfANF-0000Tr-Cn for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 05:54:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfANE-004TF7-2X for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 07:54:08 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a45fcde-5cb7-0a2a0a5109dd-0a2a4501b556-48 for ; Thu, 02 Jul 2026 07:54:07 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a45fcff-400f-0a2a45010019-d155dd2ae9fc-3 for ; Thu, 02 Jul 2026 07:54:07 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47721cd669cso254470f8f.3 for ; Wed, 01 Jul 2026 22:54:07 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dba3csm5702130f8f.3.2026.07.01.22.54.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 22:54:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782971647; x=1783576447; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=QIM/eJO+4vUuJrCujFfM+G+/xQoMdtBlBmwgL/GpSq8=; b=VenJxO7ysHJy79oeHJ5AwtjqKROQPSh43czjcgLSs4A+xypyyUanagxD6ZEA8fLwBl jvSPqvdl9wuhd1d8LJqhc3uldZq/m1i4NSU0W0qblNUulP99lcrxMXudD9N8ZQgYTkak DmGNsXV+YghjjbbkjGc/guPFNTXk1hLV1FPit+KtONc5smNSbMNHPkUML+QlEc2Svtpv EPamPEOXsS5E9fQPSRji4oeY6g+VYrW9a/76M19+I41Y1IrIaJcDWZP6V4kQgYAxnOFZ 3vkV/OwboGRQbHzc8uegSAg5WfLVgwlLTCT2aeZ/BQCnunqANNwvWtTrsn+QOqLg1hH7 QulQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782971647; x=1783576447; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QIM/eJO+4vUuJrCujFfM+G+/xQoMdtBlBmwgL/GpSq8=; b=LtyQm4nivtSzgLXeskgf0J/uyGE0/MHiueYiBlAZN+EaZ0xEjIjpJ45StNuWWkoLBI 8dW2JNdsV+EwvojP0+2l+2BpOE5jtNTQmyjBuIQI65wjaq74igE9LikdxvxIb+TmPwcP BfhosDv6rp6NOxcEV20FrZ5ojosgsly8XVJ44xlpWupLXfF1mfPWHl793UxkBep4FU8F euT3ItcUY1MLue0BU6K+UV+XkNjdZeJ0KRLcQhb+EeYhw8Q5dOLcggDPjAVgPrxvcP2T yCOGf4dNQMbrj+SNOmAZtS/fv5JzQRbXdPzQcdQBlshuV4BaPVTm8T+gmdDqmTgaI6iJ uYoA== X-Forwarded-Encrypted: i=1; AHgh+RoZxKWbFr+8MN1Om5R8+PVBOznHfpbRgkSVLFGQeODCESu3EryjFafV3ZSPgQT/3Fu0D02Bwr6Z0gU=@lists.xenproject.org X-Gm-Message-State: AOJu0YwVoghudQp5FIWyPNXwowc0/GT+ABgzGkz37woFpDSa86NbOSpr in6NSxyUeLHVvTm62N7MOixeuGv+Z2zX1I+uGktISUdDhsM18VzFAsWjdVMJMcyYBw== X-Gm-Gg: AfdE7cl3IKeuntPadU3H7lrfncZ5/DIiViDrESDpNdv9iFmRJkF6xMtWNLhTpf+sXO6 Onmik6GUCa0WPPuC8i3ybbjhkzNAQmpU6tl+f8r0UsB8Tze3UaeDicLiVNpv3iXtygzGbGHZ4l7 WN49N0kl2+JCAgsNh1Nr+bzRc6ZSDBzeV+u882zSvMJAGXZCEJwqnWsJ+31RvlsfsqpMKVfLm2M 8NRJYAcX57dgN9VKgDu8eoPkFlztBWC2sHI+2ht4FciOjQFqSlgyfO5++1ixah8omd9cc2ciHCN CmPaTGfkHDt/9UYSevHOWw8wloJxd5d67F/n19YcQmEG4pVIC7Qst8RLLoHyWJws37EhGM9f5yJ CFsjEpyKFLCfGYywliR2u1e6svbYo1xWfcEm25G+Y0Mifya00FJe7hk1E2iZXawMnESQh/st9xc Ca8YY5kP9xqp+C79x0duC453wUUX/O7wGB+efsFHnfOCU8k5hy9ty9xx/CIP5IYOahgra9/goDP 2un X-Received: by 2002:a5d:634e:0:b0:475:f0f0:9ecc with SMTP id ffacd0b85a97d-477b5d37ae9mr3638954f8f.55.1782971646961; Wed, 01 Jul 2026 22:54:06 -0700 (PDT) Message-ID: <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> Date: Thu, 2 Jul 2026 07:54:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Juergen Gross Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1782971647-800EC1E0-D12F92E0/0/0 X-purgate-type: clean X-purgate-size: 787 On 01.07.2026 17:34, Juergen Gross wrote: > On 01.07.26 13:39, Jan Beulich wrote: >> On 01.07.2026 13:16, Juergen Gross wrote: >>> Today the XEN_DOMCTL_setvcpuaffinity hypercall will not only change the >>> affinity settings of a vcpu, it will return the new effective settings, >>> too. >>> >>> In case an error happens during this hypercall, the expectation of the >>> caller is that the affinity of the vcpu didn't change. This isn't true, >>> however, if passing the new effective affinity back to the user is >>> failing. >> >> That'll be the caller's fault though. Any -EFAULT coming back are an >> indication that the caller needs fixing. > > The possible -ENOMEM isn't the callers fault, though. Yet that'll happen ahead of any changes made, won't it? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 05:58:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 05:58:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351196.1608429 (Exim 4.92) (envelope-from ) id 1wfAR0-0001TP-KD; Thu, 02 Jul 2026 05:58:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351196.1608429; Thu, 02 Jul 2026 05:58:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAR0-0001TI-HF; Thu, 02 Jul 2026 05:58:02 +0000 Received: by outflank-mailman (input) for mailman id 1351196; Thu, 02 Jul 2026 05:58:00 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAQy-0001Sm-Mr for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 05:58:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfAQx-00CPab-HF for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 07:57:59 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a45fdcc-2eae-0a2a0a5409dd-0a2a45079380-46 for ; Thu, 02 Jul 2026 07:57:59 +0200 Received: from [209.85.221.51] (helo=mail-wr1-f51.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a45fde7-9c8e-0a2a45070019-d155dd33d41d-3 for ; Thu, 02 Jul 2026 07:57:59 +0200 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-474303f3c72so908432f8f.0 for ; Wed, 01 Jul 2026 22:57:59 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477dde1ac93sm5635845f8f.28.2026.07.01.22.57.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 22:57:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782971879; x=1783576679; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/NyaO5/jf5biTznVAg/QZEVh5d7siFZRqfaOo28a5FQ=; b=REAIZwyZRreMWeL9WSLiQsTCkQVXnavNILNfavc+4oEjKK4+EhNHThMfw0XJapPUBp ezjdLewjSZHBwVhE/fygBEbCBgIW6PciNwkfavmrbFf3Q/BVmM6Iu0ci451A4241buav BGavKQcorVA9sUAFn0Q5GbPpN/K2UAi0Zpme244Jr22W4vlUNXHTBSmiYV7jQnxS4rvG Y6xM6+1T1VLmUbm/UGJ9kz4wTRQvrVRc/Wvtw7B0FmQVf3QcCl7w9d17X0ebTPHnIj9w IP1Cq3oHFqxHJ8dk/SCwkyDykDrO8Vwt1nMvBt3N1o0jeuTdfcHJmL+/FUw3dj9Wj9ve /vxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782971879; x=1783576679; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/NyaO5/jf5biTznVAg/QZEVh5d7siFZRqfaOo28a5FQ=; b=RerCjbNUJIRszgOYW+DtQh9P7vJOZbUX8PgEjImrQEb9nIAdfqmkVS2Q0s0HXOA8TI aIMOp7/9p4RFtJaIhXJnQpf9l/EUA0W81aS4LAwA1S4j2Dg94KJmL4m8Y+jzRSLt9ov/ FS6kDj8AC5/pEstHa6s0UwCVlq7cY8sDUpIdl1WjcVCnn7jncNQlXxca97LY4J2nwVuw C06wZzxXFS/mdSSCVDzoDao1CzHDHRf5NYSSjkngfMtzBQJYWCAgiuLkIdcMgWsgvtI4 lcnUMg/2ZwNylzLGfwZA+SSKxTRtaHtT2FlmKuWTk6RstAgnwL3uPvWFXpaAtzM/h0DZ OZ2g== X-Forwarded-Encrypted: i=1; AHgh+RqCwRBnIISW9wiB84wUy3eOCnIyOgOtPl7SR7bdnhxKn4s7AnFHnBmOei/BMziAuN91sRncXXoI/YY=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy8Uj3JCCyprW3DmyRqIBkFb40GNDi6RwQodFwCk3zZ4EDHpI0J FwJI1SoTOrPKyrH1X2Gf4IhqP2Esi1Q+Y6Eat9T/eXiqTKMMolW6C6NYhhyoMOUpNQ== X-Gm-Gg: AfdE7ckOpQoMUiMZEu1U8Mf27V3kM4KAH3pIgKQXyt7HQGnwqjZaP9VjHNam2rjCpn5 hxG3ojwfltd6Ivn50vwS+943ZEFpsuDb5xxu7xtcNRKWgAMYOio7gMKegaiPcnIwWMPOtOHj4xI lFzqwrX5ne/iA0dI2myMrfP2hV6SimXfsrQZHPSw65S7iQcyiRxH0CZz7vsMwIKVxhguLb9YfF4 GpvX4hcDotXgxrbngMc1OMe64sZVg2jpnPftigi93DZi9KcBL4smijcSTKeh+/cow9Q/6FFz9b4 dXEpC9Q+xMoysbv/E+TCoYZOHm1GJDuZiwHyAmEch/1JlZii03DZMkeqoQxCwUW4Lwr7Op0y0DP ON9YKmiq83MpICrS/Nf3sd2pMmdVNdzfzkVlefPIY2kgR3YEagyhDNkhOac/PnGWVMgpWucmpYj OZ3fzZxOF3ss8iI0KfwheJqGo69pLODnmYSos9T7/Xya5PLmXn1m8u5d1+TcTsgiAGgcUcP3UHR Qp3 X-Received: by 2002:a05:600c:c04f:b0:490:be14:bfda with SMTP id 5b1f17b1804b1-493c2b3a9cfmr43439565e9.6.1782971878958; Wed, 01 Jul 2026 22:57:58 -0700 (PDT) Message-ID: <52d1d0b4-6b90-4eb8-a299-7adcc7634f33@suse.com> Date: Thu, 2 Jul 2026 07:57:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration To: Hirokazu Takahashi Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <20260629215806.11610-1-taka@valinux.co.jp> <20260629215806.11610-2-taka@valinux.co.jp> <97dd9fd5-c0de-4125-a40a-b7f6e1aed27d@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1782971879-7ED3C25E-2DE92A09/0/0 X-purgate-type: clean X-purgate-size: 1427 On 01.07.2026 22:28, Hirokazu Takahashi wrote: >> On 01.07.2026 13:11, Hirokazu Takahashi wrote: >>>>> +#else /* CONFIG_CPU_TOPOLOGY */ >>>>> + >>>>> +#define cpu_topology ((struct cpu_topology *)NULL) >>>> >>>> Why exactly is this needed? It very much looks as if its presence may hide >> bugs. >>> >>> In the current code, the condition if ( cpu_topology ) is used to cover both >> cases: >>> when CONFIG_CPU_TOPOLOGY is disabled, and when memory allocation for >>> topology table fails. >>> >>> The next patch uses if ( cpu_topology ). >>> >>> static int setup_cpu_sibling_map(int cpu) >>> { >>> if ( !zalloc_cpumask_var(&per_cpu(cpu_sibling_mask, cpu)) || >>> !zalloc_cpumask_var(&per_cpu(cpu_core_mask, cpu)) ) >>> return -ENOMEM; >>> >>> if ( cpu_topology ) >> >> if ( IS_ENABLED(CONFIG_GENERIC_CPU_TOPOLOGY) ) > > This line should be if ( IS_ENABLED(CONFIG_GENERIC_CPU_TOPOLOGY) && cpu_topology ) > because 'cpu_topology' can be NULL even if CONFIG_GENERIC_CPU_TOPOLOGY is on. > > void __init init_cpu_topology(void) > { > unsigned int cpu; > > cpu_topology = xzalloc_array(struct cpu_topology, nr_cpu_ids); > if ( !cpu_topology ) > { > printk(XENLOG_ERR "Failed to allocate memory for cpu_topology table\n"); > return; > } Ah yes. The odd #define can nevertheless go away, which is the important part. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 06:11:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 06:11:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351208.1608438 (Exim 4.92) (envelope-from ) id 1wfAdz-0004sK-LV; Thu, 02 Jul 2026 06:11:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351208.1608438; Thu, 02 Jul 2026 06:11:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAdz-0004sD-Ip; Thu, 02 Jul 2026 06:11:27 +0000 Received: by outflank-mailman (input) for mailman id 1351208; Thu, 02 Jul 2026 06:11:26 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAdx-0004s7-UT for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 06:11:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfAdw-005TDF-5M for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:11:24 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a460101-5cb7-0a2a0a5109dd-0a2a4504e734-44 for ; Thu, 02 Jul 2026 08:11:23 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46010b-a01d-0a2a45040019-d1558030d0b7-3 for ; Thu, 02 Jul 2026 08:11:23 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493bf73ec2aso7873345e9.2 for ; Wed, 01 Jul 2026 23:11:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63648d7sm20787575e9.7.2026.07.01.23.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 23:11:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Content-Language:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782972683; x=1783577483; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=e0Vj9mvIyK/vkRH+VB0ecw51YmCBg+xpoBt6a2CHhJM=; b=cL5Onyrj8fE74Ytwvjsb0nDQI33i/TwFPnu1TTYw1B60jNxLejOcKnnCOM2czSSYfx tgl+y1MTJcQJZYn00FMCFzDExQMZLhtH52dIluwGlwd8FOGjwjSn7xUpueTkdV92gcP8 GsASZU953x4kCUUFcJ5yFQ3NJ5jMCkCGnMQayVEWB24/ltGRg3usq1y8oAhE6MOSJMia dRwHBWnoHOdRYvA8MyUZNY2a+zDz0KdrhL0d7+todCQf3VYVj0vbJup00rhTAQ495bkI +Tfb8OW5lFmpNHGD9nOPbfI4U4llsUSkai9nAWHcaZ5FelFZcpReqGfKmc+ccfMBAE1S 9k7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782972683; x=1783577483; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e0Vj9mvIyK/vkRH+VB0ecw51YmCBg+xpoBt6a2CHhJM=; b=X1hiQ3Orjp8dxb5syGBo2Yv3KzjeSkPppjFQJ/CsBgzLq6AtK5s2vVEV2b7PQdEVlL wl5P/fJG06jarTz+cE0dq1BgxqqFLFJpE5djqsm+vJQmiLHdMgC5VI0vkKB1SRXmgW1S s31qEdEukBUhA3Ax3WqZ5F7FKgR3ZCjGDe/YglPox+nh16NknpYi1gNnNQ7Cof+1sBr9 zoRrfykWkNGR54qn7exWD59cfY15DEGOpAdZHajkYbVqa1xPKzsegyHttvWzN83xoN5A AfZ9cVXEl7zlYyaA8ZWxqZmS3yqGY+/y0hdEXSoB5YvayBM26Ic/VRzXW3qw1wzGxHuZ Obog== X-Gm-Message-State: AOJu0Yz1oswpge4KppuK2HAj0HzAj2HnS/5uP3fxMjOhSEWQp832ln9/ dzuK5jjwrP9kdhdQae+AK7cvReKvvFQ00zdoM95XbWPN9vyCj+iuRAERFFErkEvEzRNI+j+hyJR ndd1sXA== X-Gm-Gg: AfdE7cm1I+QRyYHoTQpq8xQxQyZ6tzFN4FMMEpK9DiuOzilQbg+AsDqwfCSUzYW/cxu +dymN8d09iIvIFrGQWkVJs/9ecJL0URfw31Lll5utBAkT0KU5R7PEDQzzVsDcu9tfaxXbkBWit4 uvEJpKtHtyKOeesx3pcgyFKsEIvJGCKikA0e+s2iISTxTZXKoyR8uaIPgCxP4wnwNKAGIaWGJmj ZDF57H0B4o3YwcUyNF+n5m+yvk6Dbu6zD304vXYvqHZo/q6cxLQbhnlohlXWEcA3DiDJfcthp2G 9ykCPbMCI8IqkfwMmxktX8ePFaQ1fyuyW9APk6IY30noz2fNYmnSERk1S2el/UEgndC0aNS5YbU pqYaDiVfNPmJy2bBrSLRI8q6DpP+CQ4fIhp25tBOFqCsuKRMepk0TDa1xOG59B2l2M9yOtOFF5t WWEU9ijFuuNIw+oLCnF2Vk+ENi7Q6T2+ul9P4bF6F4C629sDRql/XVnc55UPezLVstLq/THFUk2 eTu X-Received: by 2002:a05:600c:3e06:b0:493:c548:87fb with SMTP id 5b1f17b1804b1-493c5488ce2mr21468245e9.36.1782972683334; Wed, 01 Jul 2026 23:11:23 -0700 (PDT) Message-ID: <7e0c8795-cc60-4b78-8601-6a999739467a@suse.com> Date: Thu, 2 Jul 2026 08:11:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v2] x86/Xen: correct commentary and parameter naming of xen_exchange_memory() To: "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Boris Ostrovsky Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1782972683-AF9221CC-ED16DE08/0/0 X-purgate-type: clean X-purgate-size: 1985 As documented in comments in struct xen_memory_exchange, the input to the hypercall is a set of MFNs which are to be removed from the domain, plus a set of PFNs where the newly allocated MFNs are to appear. Present comment and parameter naming don't correctly reflect that. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- v2: "fns_out" => "fns_inout". Mention parameter names in comment. --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -2291,18 +2291,19 @@ static void xen_remap_exchanged_ptes(uns } /* - * Perform the hypercall to exchange a region of our pfns to point to - * memory with the required contiguous alignment. Takes the pfns as - * input, and populates mfns as output. + * Perform the hypercall to exchange a region of our pages to point to memory + * with the required contiguous alignment. Takes as input the mfns to trade + * in (mfns_in) and the pfns where the new pages are to appear (fns_inout), + * and populates mfns as output (fns_inout). * * Returns a success code indicating whether the hypervisor was able to * satisfy the request or not. */ static int xen_exchange_memory(unsigned long extents_in, unsigned int order_in, - unsigned long *pfns_in, + unsigned long *mfns_in, unsigned long extents_out, unsigned int order_out, - unsigned long *mfns_out, + unsigned long *fns_inout, unsigned int address_bits) { long rc; @@ -2312,13 +2313,13 @@ static int xen_exchange_memory(unsigned .in = { .nr_extents = extents_in, .extent_order = order_in, - .extent_start = pfns_in, + .extent_start = mfns_in, .domid = DOMID_SELF }, .out = { .nr_extents = extents_out, .extent_order = order_out, - .extent_start = mfns_out, + .extent_start = fns_inout, .address_bits = address_bits, .domid = DOMID_SELF } From xen-devel-bounces@lists.xenproject.org Thu Jul 02 06:13:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 06:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351215.1608448 (Exim 4.92) (envelope-from ) id 1wfAg2-0005P5-2L; Thu, 02 Jul 2026 06:13:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351215.1608448; Thu, 02 Jul 2026 06:13:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAg1-0005Oy-UF; Thu, 02 Jul 2026 06:13:33 +0000 Received: by outflank-mailman (input) for mailman id 1351215; Thu, 02 Jul 2026 06:13:32 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAg0-0005Oh-LY for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 06:13:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfAfz-00DF7B-Mu for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:13:31 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46017e-e002-0a2a0a5209dd-0a2a450a95f6-36 for ; Thu, 02 Jul 2026 08:13:31 +0200 Received: from [209.85.218.41] (helo=mail-ej1-f41.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46018b-e40e-0a2a450a0019-d155da29e4dd-3 for ; Thu, 02 Jul 2026 08:13:31 +0200 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c1214350188so173775666b.0 for ; Wed, 01 Jul 2026 23:13:31 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b628efefsm70160566b.32.2026.07.01.23.13.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 23:13:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782972811; x=1783577611; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=JNAvSXx5VzlpmRToh2f/RUHc5zZ3QsDmWQT8egVqlxc=; b=W9ZwJNhsoPiOivFsBuCJl+Rjz1ziZTGpd7licUEO/lkhJsvr4FJXZN7Zmq6X2DR6nI VjrxAt+eePC3zWOc6mPEDiLCiY5Or2N+uraUMZMuRHf8+Hu/p/hVyPxTD8jsU5RWMRyY uvXDkubzcCFDK8g7ZJjQKZqXLLhUYJMkzjfATf5s1rkpFlrrsLEGf1e5GVYqkuvxmeuw kd5P478oWH9ahxfgGng07XGd+o/ZMDX1iXf3TD0bS+tzjdRtN2vApMZJ8Q3wwY9y1d1W nwr+y/vfMf6WKKi6vPCoOn+MRMRvzmMzVCAHxf1d7Un70/XmRptyAKsonjKOfhpWbPAZ RrMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782972811; x=1783577611; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JNAvSXx5VzlpmRToh2f/RUHc5zZ3QsDmWQT8egVqlxc=; b=tQ0ATyJR9gfRfq/Hdzu8Gd6LrSJH4hDDybN4X1yxVA2cLCSRUIj78KAyAfvj2gP4XN Oxgicl84kMCx5vL2lSzm3LrefPqEcoVVqlZQocfDYzrs84MHMTdHYZdjncVdTnBOSDUK TBkQuBP57mfKqJmHBWIr7/4/QQXruXjPEjP9rAieAdC7TlcmaYXMSSSiEIcnAVI5TdQR 3ULH/IoyViHIedf3pLIUeIxg6PO8VNCS2L76MYf2mB6jUbnaOT+gcYfiHjLuudu0hFFD 6wYRvRQmDoaenWqghwA3XsiydhYFMVLfb7GS8Ny4JJ8AibW133/4AyohCuQKppGR9gfL LDHA== X-Forwarded-Encrypted: i=1; AHgh+RqOoU2t5RsDlilIrXGl3xgjJM4FHov4OEHwOf84yKODX5HqPtMDZGVInGLyRRvGSpcr2FsASepe9OI=@lists.xenproject.org X-Gm-Message-State: AOJu0YwVhypasz1s/sG7aZEZfwdEu3e3A0oe3k6Afpvq27pVemfpDw9a DjJcep6bMu9ocZMsVtXassxL9eEiidHvoFS4ggIYM0t1BtsvfrNT6AQpyvMowDFoKno= X-Gm-Gg: AfdE7ckxDtCA0X6dAE9ukuDVuXRMcSI4uSlfrLCViT3JNVzm81k5Kk97ReYJN6z392a 3PtRbF3LQ94nyn1OGAkuTCn6PhD8jCQMIvr6bPqI0V1/q3YD7OHy7K2AsuHE0qr/2Y72uHfBDFg 9Uf3/9PaXSFi0UAUmkGJ/h0PnXrL6MTK6pmk5EcXn6ENc0xdubxmVugOQ7ER8AX8fN09Ym/Lhdd DWVTDP5d/+EgenthhUcX91zxXJZSQTPWIYSZWf7r5V9B36YboihQJ+jpBLXQTHHA+BxHzh12Df2 I6XFj+gR9xFl1dcdPOTlb/A+DZOUjJljdqToObMY37uM/k5cftY3Qz0obzeREECqj2cGyd0pMjy g6r38bTK4YwhIzjf2yp9i8riPiL4kQ1FIYWaQuoTwi+yQ4YYzsNP32RzYPh0rwPmSJrC4u99Q9/ HmpU9ASBaD8ANFM9wCLst47TIucrEle3j3sAjkL1BdJr2dhowoc+zvKQ+1vfLV+s9c45FSkLoCm mOsSR1QBK1Jhs0AaBy9ozjyTMmel/tjfpXA7vUQzs0= X-Received: by 2002:a17:906:7f91:b0:c0f:beeb:dbd8 with SMTP id a640c23a62f3a-c12ae4f1638mr151204566b.27.1782972811120; Wed, 01 Jul 2026 23:13:31 -0700 (PDT) Message-ID: <72ffe654-8ba0-403c-91e0-100905467970@suse.com> Date: Thu, 2 Jul 2026 08:13:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------etd25evpDdQmLPDZlUIjD9CZ" X-purgate-ID: tlsNG-4011c0/1782972811-D5D23DDE-908C7D3B/0/0 X-purgate-type: clean X-purgate-size: 9188 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------etd25evpDdQmLPDZlUIjD9CZ Content-Type: multipart/mixed; boundary="------------HTmg45iY3L0oWX3104aCGoDR"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Message-ID: <72ffe654-8ba0-403c-91e0-100905467970@suse.com> Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> In-Reply-To: <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------HTmg45iY3L0oWX3104aCGoDR Content-Type: multipart/mixed; boundary="------------WV3QJ1Fy8BP7zTnoNfE9r9gT" --------------WV3QJ1Fy8BP7zTnoNfE9r9gT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDcuMjYgMDc6NTQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMS4wNy4yMDI2 IDE3OjM0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDEuMDcuMjYgMTM6MzksIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAxLjA3LjIwMjYgMTM6MTYsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IFRvZGF5IHRoZSBYRU5fRE9NQ1RMX3NldHZjcHVhZmZpbml0eSBo eXBlcmNhbGwgd2lsbCBub3Qgb25seSBjaGFuZ2UgdGhlDQo+Pj4+IGFmZmluaXR5IHNldHRp bmdzIG9mIGEgdmNwdSwgaXQgd2lsbCByZXR1cm4gdGhlIG5ldyBlZmZlY3RpdmUgc2V0dGlu Z3MsDQo+Pj4+IHRvby4NCj4+Pj4NCj4+Pj4gSW4gY2FzZSBhbiBlcnJvciBoYXBwZW5zIGR1 cmluZyB0aGlzIGh5cGVyY2FsbCwgdGhlIGV4cGVjdGF0aW9uIG9mIHRoZQ0KPj4+PiBjYWxs ZXIgaXMgdGhhdCB0aGUgYWZmaW5pdHkgb2YgdGhlIHZjcHUgZGlkbid0IGNoYW5nZS4gVGhp cyBpc24ndCB0cnVlLA0KPj4+PiBob3dldmVyLCBpZiBwYXNzaW5nIHRoZSBuZXcgZWZmZWN0 aXZlIGFmZmluaXR5IGJhY2sgdG8gdGhlIHVzZXIgaXMNCj4+Pj4gZmFpbGluZy4NCj4+Pg0K Pj4+IFRoYXQnbGwgYmUgdGhlIGNhbGxlcidzIGZhdWx0IHRob3VnaC4gQW55IC1FRkFVTFQg Y29taW5nIGJhY2sgYXJlIGFuDQo+Pj4gaW5kaWNhdGlvbiB0aGF0IHRoZSBjYWxsZXIgbmVl ZHMgZml4aW5nLg0KPj4NCj4+IFRoZSBwb3NzaWJsZSAtRU5PTUVNIGlzbid0IHRoZSBjYWxs ZXJzIGZhdWx0LCB0aG91Z2guDQo+IA0KPiBZZXQgdGhhdCdsbCBoYXBwZW4gYWhlYWQgb2Yg YW55IGNoYW5nZXMgbWFkZSwgd29uJ3QgaXQ/DQoNCk5vLCBpdCBjYW4gaGFwcGVuIGR1cmlu ZyB0aGUgZmluYWwgY2FsbCBvZiBjcHVtYXNrX3RvX3hlbmN0bF9iaXRtYXAoKS4NCg0KDQpK dWVyZ2VuDQo= --------------WV3QJ1Fy8BP7zTnoNfE9r9gT Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------WV3QJ1Fy8BP7zTnoNfE9r9gT-- --------------HTmg45iY3L0oWX3104aCGoDR-- --------------etd25evpDdQmLPDZlUIjD9CZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpGAYoFAwAAAAAACgkQsN6d1ii/Ey9h MQf9GowKmbhWx48r2RY7a2Yv/72UdzSbjGlceufQ7u4sSqpF2tsXwO+h3J8+nQqqZK22zBdpeD2G pYUI0ItPfPqwFBNXI9jrNQgz9UIs9QypqA4fCSmn5ogYtKgfAcE4r696OlU6GHTz72bEhhDuS7G+ IwghPjJkT3QpMokUcd7/arhGr/VU29eBBLvpxSAVp/Jmny9daCssGDfwwwr0lm6o+KP/oyu2TuU5 VW3eNKJFGelS/r20tNvDqPEQTJTggSXg203gXZ1VdrQ9j2rAEFETHP2PR0n2+hQg3+Jxm/xFvln4 3YDhXYsVHIXfXvzhHuMH3LIg/XLtV2uo2OX4tS3YRA== =HmVZ -----END PGP SIGNATURE----- --------------etd25evpDdQmLPDZlUIjD9CZ-- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 06:26:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 06:26:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351236.1608457 (Exim 4.92) (envelope-from ) id 1wfAry-0007e9-4z; Thu, 02 Jul 2026 06:25:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351236.1608457; Thu, 02 Jul 2026 06:25:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAry-0007e2-2N; Thu, 02 Jul 2026 06:25:54 +0000 Received: by outflank-mailman (input) for mailman id 1351236; Thu, 02 Jul 2026 06:25:52 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfArw-0007dv-MU for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 06:25:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfArv-0069M8-Hz for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:25:51 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a460464-bab6-0a2a0a5309dd-0a2a450cb8d6-38 for ; Thu, 02 Jul 2026 08:25:51 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46046f-f399-0a2a450c0019-d155802dd8c0-3 for ; Thu, 02 Jul 2026 08:25:51 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-493b786d6c0so7052115e9.2 for ; Wed, 01 Jul 2026 23:25:51 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c636cc08sm25751895e9.11.2026.07.01.23.25.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 23:25:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782973551; x=1783578351; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Bh+uU93M/cZqqz8CprtfE0r0tVxMNI51TmT2A6VaeTE=; b=XiIL6OfSjXukQabhXDIwPXUVFQP+EMETF04+uXOXG/jsm+RkNFVQDj0SH1M/HLmGs7 U53xlo140dnbjFrGSBy1WJk6C/UziFHj4J6qTKaPaADh7JXG/NAdkfgqfPBWTwszDE7i WR7EiAyHefbVoDpwEq1dVmRvAPK2pisYjUbMSYR2rnpnwHSth1L0T/tFuGY7slf2QD7b Oapja6Jiog8QnvhIaUlwyZGQ+1x5j9TUO64UiqfF2Xs84tvkFQDeMtcbMuIyAMFTmsXb rskZam/5Y9wNCkIWurt2z8WoAxJNkZ3MFkcEkT0xMh6VuJBkq4yDwj1+ZkkDMLJonVbs mG2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782973551; x=1783578351; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bh+uU93M/cZqqz8CprtfE0r0tVxMNI51TmT2A6VaeTE=; b=NsLScLieR6Vz4yAPPWtuHtXsUQDXyeJOkbehM5EDyTi0tEqyfEtfzXREo9yg6L8WpO 2MEjrs+J+H4+h/vK+tkubm5XUcURrqKjnU4xu7jb/KUiQlATUloAEPJLDfNbBxidWbqQ iKzhX0RaysEW3mxMFhKpbqqX+R/6bKevd/RF6EsiZJ2h4jACJ0CDca357WLBDj0uKZPH HbdFX3cScIcCRBqw5gPf0SEtA0f5fa6tWPk9mAzaY6Pl0cgnPRh4XQIe3VoxoW27Fggh tzFAxmZxdPcfCVGkFDRi8Fv503xZOBAD9VR5UpX1J6yrA5tpWtTpxghWdSM/xyfXoBsS RCtQ== X-Forwarded-Encrypted: i=1; AFNElJ81b6ThQhWBsXlBILlVMxpgMrm6vH8iCFEg5mgiIqLsK0qR3IpoukUmGaRouWpuTMX6Vj/isM1qoc0=@lists.xenproject.org X-Gm-Message-State: AOJu0YwFV2qBAt1kGd2ZZht0m57fZ2qfa0TSnF7nptToUORgPogWYBkw J0XraSpzUeF2g05hKLwRj3iKLuqvijpuTcUHXmVgs1swYaj1u2kwDV/L2qtHSvIvCQ== X-Gm-Gg: AfdE7cnjHrc2qKg7fDQZPLmvcc/9rEjBrgbo0B91iaS8qzoR5qdUVNdk44lUVNLCUZU oB45F+W+w34GdUJKK7h57x9rwcF4OZiQ076jy3M/ZlHuN0wGpTC8aOdZQ2Tk5H9N8yKQfrLUOHZ pEqu+cUf7z91FHw+1Rxgcuhr2QVU/UdOUnaLBWGH6unqhb4cFeg1gYzGJ8ihQMHdS4tzNKC1HxZ omQ5dnF/IGowDJyvAAjGBp+yOHZ0HzgAWYcYS0LOgD1IqhHHCBaAeOXW5zK0Udfa07M7n/4ckHq L9LQgdR0dy+Hmtrb7ao68GGtCYeKuaY8DSvrsOHSayoqawz/0wN9GUYYOc5BuWSbF/O5Jg+nasK WVW2oSEeJ2vJFaikytwXl5yBZsKV81ONZkRCxfe3ONddF4ku17/B1EpHf1IQYInURTfQjTP5tly 5d3UqofWro1pFSPl7hOxfSIku/dDdu9tBIHfwWxLYpKNkE5y61nqoGk5U5Iyw/4TulFcqZMJdql P+l X-Received: by 2002:a05:600c:5851:b0:492:1e7f:d41e with SMTP id 5b1f17b1804b1-493c2b4e778mr50333285e9.10.1782973550953; Wed, 01 Jul 2026 23:25:50 -0700 (PDT) Message-ID: <158eeb93-dec9-4805-98c6-3ea84b235d94@suse.com> Date: Thu, 2 Jul 2026 08:25:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> <72ffe654-8ba0-403c-91e0-100905467970@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <72ffe654-8ba0-403c-91e0-100905467970@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1782973551-91128D51-8D30E5E2/0/0 X-purgate-type: clean X-purgate-size: 1153 On 02.07.2026 08:13, Jürgen Groß wrote: > On 02.07.26 07:54, Jan Beulich wrote: >> On 01.07.2026 17:34, Juergen Gross wrote: >>> On 01.07.26 13:39, Jan Beulich wrote: >>>> On 01.07.2026 13:16, Juergen Gross wrote: >>>>> Today the XEN_DOMCTL_setvcpuaffinity hypercall will not only change the >>>>> affinity settings of a vcpu, it will return the new effective settings, >>>>> too. >>>>> >>>>> In case an error happens during this hypercall, the expectation of the >>>>> caller is that the affinity of the vcpu didn't change. This isn't true, >>>>> however, if passing the new effective affinity back to the user is >>>>> failing. >>>> >>>> That'll be the caller's fault though. Any -EFAULT coming back are an >>>> indication that the caller needs fixing. >>> >>> The possible -ENOMEM isn't the callers fault, though. >> >> Yet that'll happen ahead of any changes made, won't it? > > No, it can happen during the final call of cpumask_to_xenctl_bitmap(). Only hypothetically, on a big-endian architecture (which we don't currently have support for anywhere, hence why the little endian special case was added there). Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 06:31:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 06:31:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351245.1608468 (Exim 4.92) (envelope-from ) id 1wfAww-0000jk-O5; Thu, 02 Jul 2026 06:31:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351245.1608468; Thu, 02 Jul 2026 06:31:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAww-0000jd-JO; Thu, 02 Jul 2026 06:31:02 +0000 Received: by outflank-mailman (input) for mailman id 1351245; Thu, 02 Jul 2026 06:31:01 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfAwv-0000jX-Al for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 06:31:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfAwu-006AKK-JA for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:31:00 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4605a4-bab6-0a2a0a5309dd-0a2a4504b214-0 for ; Thu, 02 Jul 2026 08:31:00 +0200 Received: from [209.85.208.49] (helo=mail-ed1-f49.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4605a4-a01d-0a2a45040019-d155d031e02f-3 for ; Thu, 02 Jul 2026 08:31:00 +0200 Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6974a6e54dbso2388087a12.2 for ; Wed, 01 Jul 2026 23:31:00 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-698acf2960dsm445491a12.9.2026.07.01.23.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 23:30:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782973860; x=1783578660; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IUIV0ytVqQJb6XNbxSnlM4HZI+CzawlU1i/LZDdxXxk=; b=Gc701dSuvswOLoJD/k9qqDJKAiWVmJ32v/uydmQoIegO7xBNaQ6XfFKfrpWZ5y94vK BgLyzO96QUqqbqXExU/RXmCjvDgutsd4toDXhS6A2uUEhfPMFucYlKhaosSJNt9Yvy15 oN88x/RzY4zUdU5WTYfAoH5ZiaKwchh15qszFSQiFpraVgxvI4gvnc73ZCSpgnn10ELW Yjg6mZ2y5HPDYPJvl4gRI6E+NLznkl+sl4DCVEHxp3+GDgY5DxIQDo7XQIQZwFKJeBGm uVKksdXPB/BFw6fFaK/s062DcjCBgPXjI8KZRrTKH2xvUFcHuburrARSDbKvqN0nh0M7 p2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782973860; x=1783578660; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IUIV0ytVqQJb6XNbxSnlM4HZI+CzawlU1i/LZDdxXxk=; b=Uaf0tyoLKwbYLSs2jr1r7TxR4627I+CnXPgvUDbdywxVhZzoyClCIJxCAs9Ruwc/ms 7tFx7bsHfltzIr0ir9AAOwZbt2puVyhscEsE7ILRZhIFJf7sfcGLggwPW/gg9tDupSq1 hh/Y2YzVJGv22B2OeI+YSPgZ3EvuSPnm5KvzSZSf76G8SkBzIkDK09Ucrqh/znieMdiy GP7Tb1AynG/Dry19ZmmzQqxPjDHSpczNuILlYf3I4wtxneAcxAOnXDMy3rjB82Sn30LZ emRTVdHdepjgFQubisGpWd/6kKLC8j20bPX6GpJZ7NHOgJ81Neh0XzpHTycJ7XnVSNUD yANw== X-Forwarded-Encrypted: i=1; AHgh+RofAWR4qHzXkGJ4Axs4FPO1pX464PA+2tLP5d+Qy5fpWKiVmPmQjzDgpaksKae8FKg6Dxli63D7kKo=@lists.xenproject.org X-Gm-Message-State: AOJu0YzHMUi+bED70J1mSUPWDyHvY/C5BiGRjZMcYcWvjIO5hqZtO+jt M1VTPdudxmnua9CH0bOfgngTuHUyPa9o7e8wSooIfQlR6OFmGXUIWU/3e0OArv9GyT4= X-Gm-Gg: AfdE7clqYgHcYG/BgFB0HKf20mH5rSe/pVyzxLRPgPel0+kf1a8Kv4nIM+nbBAOM0pr rw/oKMXTHs3nDtFVeJ5Y36F8GSDWHFFzfHWQ8WGCiHtanYk3cCLbFTI4bAlZaj+RrmGSkUGjWdQ 5/Jd9twNTKgcHfbUP53BBAQp6IC0c/MjoPGs5rgzIXvGJqaiTBRtj2TscQBcmRZ5CfxlpLshfBm GQbRoUuFyGfhRjhTGFChEwTwyPwVzDcD0DaflrkjD/BIHzOO4ggpq21hb22jcjtXkxmTk/jOFxo vZTCY7iw2uFm+TaMDGtNQ/kDjbvX+NLHlXO0koFXm3jmZzb+JkA8GuuHy6Hc8ZLuI3fML23op7t JAJ24cdY96qSouckudIxT8Xweh0jFWrmYxyP91ZXLe4IOjNyAhZu/mRU4tQjVjzwWHyW5e+KK0s RkjiJYtBsPzJYP8Y/31xwHpd4KpGIpCIBHKNI0iG1HV9z3Koah31VoI6kmxBuNXTgIvBG2k+Kzu QqL1O2TA1f6IJGw7X83aDFGrqd1LzVksU2lfN2TOSo= X-Received: by 2002:aa7:d606:0:b0:698:3b7b:e48e with SMTP id 4fb4d7f45d1cf-698a2cfd9fdmr1245352a12.36.1782973859976; Wed, 01 Jul 2026 23:30:59 -0700 (PDT) Message-ID: <31d0241a-6c08-494d-8361-e03a75bdac6f@suse.com> Date: Thu, 2 Jul 2026 08:30:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> <72ffe654-8ba0-403c-91e0-100905467970@suse.com> <158eeb93-dec9-4805-98c6-3ea84b235d94@suse.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <158eeb93-dec9-4805-98c6-3ea84b235d94@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Y1anXJiAzC9XM6ECLdW7B8LM" X-purgate-ID: tlsNG-ebf023/1782973860-AEF2D1CC-A771F0B7/0/0 X-purgate-type: clean X-purgate-size: 9705 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Y1anXJiAzC9XM6ECLdW7B8LM Content-Type: multipart/mixed; boundary="------------mJGr08yb975hK531mj5qNe7w"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Anthony PERARD , Dario Faggioli , George Dunlap , Andrew Cooper , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org Message-ID: <31d0241a-6c08-494d-8361-e03a75bdac6f@suse.com> Subject: Re: [PATCH 0/3] Change XEN_DOMCTL_setvcpuaffinity interface References: <20260701111606.4063972-1-jgross@suse.com> <4e16c1eb-e1ff-4d7a-bfa8-223d357716ee@suse.com> <0c888832-9509-4e14-977c-ff1dc37768f3@suse.com> <72ffe654-8ba0-403c-91e0-100905467970@suse.com> <158eeb93-dec9-4805-98c6-3ea84b235d94@suse.com> In-Reply-To: <158eeb93-dec9-4805-98c6-3ea84b235d94@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------mJGr08yb975hK531mj5qNe7w Content-Type: multipart/mixed; boundary="------------BdYq47Ia8wMZ2UrwocuM5LJt" --------------BdYq47Ia8wMZ2UrwocuM5LJt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDcuMjYgMDg6MjUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMi4wNy4yMDI2 IDA4OjEzLCBKw7xyZ2VuIEdyb8OfIHdyb3RlOg0KPj4gT24gMDIuMDcuMjYgMDc6NTQsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAxLjA3LjIwMjYgMTc6MzQsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IE9uIDAxLjA3LjI2IDEzOjM5LCBKYW4gQmV1bGljaCB3cm90ZToN Cj4+Pj4+IE9uIDAxLjA3LjIwMjYgMTM6MTYsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+ Pj4gVG9kYXkgdGhlIFhFTl9ET01DVExfc2V0dmNwdWFmZmluaXR5IGh5cGVyY2FsbCB3aWxs IG5vdCBvbmx5IGNoYW5nZSB0aGUNCj4+Pj4+PiBhZmZpbml0eSBzZXR0aW5ncyBvZiBhIHZj cHUsIGl0IHdpbGwgcmV0dXJuIHRoZSBuZXcgZWZmZWN0aXZlIHNldHRpbmdzLA0KPj4+Pj4+ IHRvby4NCj4+Pj4+Pg0KPj4+Pj4+IEluIGNhc2UgYW4gZXJyb3IgaGFwcGVucyBkdXJpbmcg dGhpcyBoeXBlcmNhbGwsIHRoZSBleHBlY3RhdGlvbiBvZiB0aGUNCj4+Pj4+PiBjYWxsZXIg aXMgdGhhdCB0aGUgYWZmaW5pdHkgb2YgdGhlIHZjcHUgZGlkbid0IGNoYW5nZS4gVGhpcyBp c24ndCB0cnVlLA0KPj4+Pj4+IGhvd2V2ZXIsIGlmIHBhc3NpbmcgdGhlIG5ldyBlZmZlY3Rp dmUgYWZmaW5pdHkgYmFjayB0byB0aGUgdXNlciBpcw0KPj4+Pj4+IGZhaWxpbmcuDQo+Pj4+ Pg0KPj4+Pj4gVGhhdCdsbCBiZSB0aGUgY2FsbGVyJ3MgZmF1bHQgdGhvdWdoLiBBbnkgLUVG QVVMVCBjb21pbmcgYmFjayBhcmUgYW4NCj4+Pj4+IGluZGljYXRpb24gdGhhdCB0aGUgY2Fs bGVyIG5lZWRzIGZpeGluZy4NCj4+Pj4NCj4+Pj4gVGhlIHBvc3NpYmxlIC1FTk9NRU0gaXNu J3QgdGhlIGNhbGxlcnMgZmF1bHQsIHRob3VnaC4NCj4+Pg0KPj4+IFlldCB0aGF0J2xsIGhh cHBlbiBhaGVhZCBvZiBhbnkgY2hhbmdlcyBtYWRlLCB3b24ndCBpdD8NCj4+DQo+PiBObywg aXQgY2FuIGhhcHBlbiBkdXJpbmcgdGhlIGZpbmFsIGNhbGwgb2YgY3B1bWFza190b194ZW5j dGxfYml0bWFwKCkuDQo+IA0KPiBPbmx5IGh5cG90aGV0aWNhbGx5LCBvbiBhIGJpZy1lbmRp YW4gYXJjaGl0ZWN0dXJlICh3aGljaCB3ZSBkb24ndCBjdXJyZW50bHkNCj4gaGF2ZSBzdXBw b3J0IGZvciBhbnl3aGVyZSwgaGVuY2Ugd2h5IHRoZSBsaXR0bGUgZW5kaWFuIHNwZWNpYWwg Y2FzZSB3YXMNCj4gYWRkZWQgdGhlcmUpLg0KDQpPaCwgaW5kZWVkLg0KDQoNCkp1ZXJnZW4N Cg== --------------BdYq47Ia8wMZ2UrwocuM5LJt Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------BdYq47Ia8wMZ2UrwocuM5LJt-- --------------mJGr08yb975hK531mj5qNe7w-- --------------Y1anXJiAzC9XM6ECLdW7B8LM Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpGBaMFAwAAAAAACgkQsN6d1ii/Ey8Q gAf9EMcw0RKEXA0r+rQkQGhq2xHmTbf6ZfAufbZmAf/T9X0rYQh2A5tCge03qO+5+paQzNV50g8/ IkoYhg+SGtqvEbOf3GcJx9B81g9NmDmPhRIzA+HaejfgnDIPlIFn6ve9WOjX+HQHSdPFp7lcc2CC II/GoLHMiGm/mR/wfIefHDzMZVpCB3YRYu7DmHeNNIpkgO2s01yYKQpKkkOok7Nf3cpLf6U6aS3/ qn42Dq7OTPWidNrD9mTZ4T9nr1wcu5Z659jBM/TasZwsXY5/O0mZPA1aI5bGu7zwy2Av9sLrgoA+ P9mwT8bAMcmWMsKTggZmIPSAQ85nlvv/+yeBy5D2NA== =kILW -----END PGP SIGNATURE----- --------------Y1anXJiAzC9XM6ECLdW7B8LM-- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 06:38:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 06:38:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351253.1608476 (Exim 4.92) (envelope-from ) id 1wfB4X-0002AB-Cs; Thu, 02 Jul 2026 06:38:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351253.1608476; Thu, 02 Jul 2026 06:38:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfB4X-0002A4-9m; Thu, 02 Jul 2026 06:38:53 +0000 Received: by outflank-mailman (input) for mailman id 1351253; Thu, 02 Jul 2026 06:38:51 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfB4V-00029y-N7 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 06:38:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfB4U-006Bsb-Ih for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:38:50 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a460764-5cb7-0a2a0a5109dd-0a2a45019a46-48 for ; Thu, 02 Jul 2026 08:38:50 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46077a-400f-0a2a45010019-d155802abc05-3 for ; Thu, 02 Jul 2026 08:38:50 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so9643035e9.0 for ; Wed, 01 Jul 2026 23:38:50 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6354771sm23124965e9.3.2026.07.01.23.38.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 23:38:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782974330; x=1783579130; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=tTOdo7r99vUeIh+Bzq2POYKkkUa284xP30k/bUUTVmc=; b=Ru6umzU/0upR/Q9bI2KbSz9MApTTg+VmlyE1IwhsLTImbn2ASsiZm6CdLfO7ZYPD61 AGmdv6vn2mCzJDCSurOiecM4tv7aUbIZrG+7DfsJuZPIvpeYCBvYOEQ8Pp+UGiO+eP/1 1yumUkG5YhuTG6IQ8qh4N+Gm09vbrlqJKQNr3ul0O65pSJ/jLmZNsfh2JQ/H2wN6bprV Q7eXoPXnUYfxhVvlzcwOg8qtcGYjh7S3Lq0Gkx+p/7z+yYgQjPMoJ5EnLupL623XSKIr vwdMDFjwC5cFEUbt51xe5gV9tTYsxDoytVQzEEJCq6BThCgNHDrQ14uLwZ4wIErg6Vbw aTHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782974330; x=1783579130; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tTOdo7r99vUeIh+Bzq2POYKkkUa284xP30k/bUUTVmc=; b=F60kKyMu9RUZl0KXqlE3GqabnvrkS7QhElSOZbArqNza0FE8KZPE2Er2LY8pIUmymp LxkjBD2UV8CjLQMD7i3udOZ8yuhttIMnnenqynihL7UfR+Y35UW321iwRWnyMqxrcuuL iMYpGRyB0zUKIyjwxZXNAdhNcUFilcj+i1PwMMqRG/BJ6rJJdX7DRkSGsKRV18kbaf9Y JVhwcAY1FFRxuflCc1jY6AoQ6WXr4vx1ipLbOqGxOcs8IWG3B1IR+hG95doz4XMMVHqt eY6UL53mY2MMpmGAZoQpfoYv/c0/L37SfMFVSeFfj6kLeJglnlKWV/uU/Xv4VLZmv0Qz nV8g== X-Forwarded-Encrypted: i=1; AFNElJ+Ql92VWBnIn4SuFavGvRtzIxgyT7YL5s9U6zM2bdaEFl6wO3xGShBfZ+FYZ4y1KIFvfW9XzP8TcQc=@lists.xenproject.org X-Gm-Message-State: AOJu0YxSTLovz5+cRsGjHFEMFUmluNeCWkQpAxhOluA814y0eDi/w/bX wzMHMx2OD1/nnzuzY1nUXpA0OUGKPDw4YoEqMriamH72NWzP3p/hvBqQE2jWIkYfVw== X-Gm-Gg: AfdE7ckIPzkWCVD8l1b9p/eB6Tq4hL4TIOwv/vAsJtPrkX7NT1hN8S5JaqRvz/bZ3Mx 4ERlEZeo7nwC/EKXnVPqOXEOXgPXWc4SRVQvwwpAtapYMvQEl4FNmTlMrYVqCIuR9WQqiv0fpGv JU9tve8TBIHYMORgHqci2zkrh10/6PY9xLmLaro06W3QF9POKE//Qdr37erTP2BqWWx1hSTt7fZ IS9gVuSd2hGDUpEhqQwPs3OsOFIieZmXvxUPH11piGR+JlpqejzKIbPhZP1S9bt+gA8r6BCHnZU 2xXVPvkjFkGc3IsRNi9auCtQ5WFKgSGYmPzVWWNJrdHdsz2uyhfNBlHkQZC2M2i15aGmfQ8li6z 8WpwEdOL1bW35qwjdR/6gDiZv6bpPj51iLVNTSagmg5uZ2p+fahob4gJaIhVJs+TxVznsAJFNlz +iHzKCt1MLMgaGBlO5ankBOv/qTpvZfCBRzzG0JEvSibEmfATJgxJ4hQxpoyLqR54N1/QujP3rk hUc X-Received: by 2002:a05:600c:8590:b0:492:4363:e7eb with SMTP id 5b1f17b1804b1-493c2ba4f75mr52259095e9.32.1782974329984; Wed, 01 Jul 2026 23:38:49 -0700 (PDT) Message-ID: <40bcf6b7-306a-419a-bf12-1855f9e589fe@suse.com> Date: Thu, 2 Jul 2026 08:38:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/25] xen/riscv: implement IRQ routing for device passthrough To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <472a77604d35a0bc2a75b71f250fd67b63afde4c.1782487661.git.oleksii.kurochko@gmail.com> <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1782974330-D16DE1E0-82700991/0/0 X-purgate-type: clean X-purgate-size: 1953 On 01.07.2026 16:49, Oleksii Kurochko wrote: > On 6/29/26 5:55 PM, Jan Beulich wrote: >> On 26.06.2026 17:46, Oleksii Kurochko wrote: >>> @@ -221,3 +239,215 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq) >>> spin_unlock(&desc->lock); >>> irq_exit(); >>> } >>> + >>> +static inline struct irq_guest *irq_get_guest_info(struct irq_desc *desc) >>> +{ >>> + ASSERT(spin_is_locked(&desc->lock)); >>> + ASSERT(test_bit(_IRQ_GUEST, &desc->status)); >>> + ASSERT(desc->action != NULL); >>> + >>> + return desc->action->dev_id; >>> +} >>> + >>> +static inline struct domain *irq_get_domain(struct irq_desc *desc) >>> +{ >>> + return irq_get_guest_info(desc)->d; >>> +} >> >> Does this really need a separate helper? (You effectively open-code it >> anyway in release_guest_irq().) > > Considering that I used irq_get_domain() once at all (even in > downstream) I will drop that. Good. >> For both functions: "inline" generally wants limiting to header files. > > Regarding inline I think that I don't understand, it isn't in the header > file as irq_get_guest_info() is used only in this file. Right. I didn't as it to move to a header file. > Do I understand you correctly and it is needed just to drop "inline" for > irq_get_guest_info()? Yes. It can be simply static here, and the compiler can figure out whether to inline it. >>> + spin_unlock_irqrestore(&desc->lock, flags); >>> + >>> + release_irq(desc->irq, info); >>> + xvfree(info); >> >> If, in release_irq(), action isn't freed, it's ->dev_id field will now have >> a dangling pointer. (I think I did point this out before.) > > It should freed in release_irq() as route_irq_to_guest() always set > action->free_on_release = true; Well, "free_on_release" must exits for a purpose. I.e. there must be, now or soon, cases where it's set to false. Else simply drop the field. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 06:41:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 06:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351263.1608485 (Exim 4.92) (envelope-from ) id 1wfB7I-0003ht-RM; Thu, 02 Jul 2026 06:41:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351263.1608485; Thu, 02 Jul 2026 06:41:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfB7I-0003hm-OV; Thu, 02 Jul 2026 06:41:44 +0000 Received: by outflank-mailman (input) for mailman id 1351263; Thu, 02 Jul 2026 06:41:43 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfB7G-0003hf-VJ for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 06:41:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfB7G-00Caq7-CD for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:41:42 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46081c-5cb7-0a2a0a5109dd-0a2a4507d4b6-18 for ; Thu, 02 Jul 2026 08:41:38 +0200 Received: from [209.85.221.50] (helo=mail-wr1-f50.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a460822-9c8e-0a2a45070019-d155dd32c5de-3 for ; Thu, 02 Jul 2026 08:41:38 +0200 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47640541585so864014f8f.1 for ; Wed, 01 Jul 2026 23:41:38 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dbb01sm5948452f8f.1.2026.07.01.23.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 23:41:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782974498; x=1783579298; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=C7gG1XXRUXGBnFboK8BGuq44cQ+yqBfPnKNNfXgaklg=; b=f5AIIkRG3AtRF/zcMBxzvxVxbC8PY2UjGJooqsup58Q0ifvGO/TJNYwmM37yyfj+pY iHB7GosAac2RR7Dq7+KsQbzb2UypVe/5F70F5v13Nt4HMMh2nLoXuJ3/YQvnMD4B54QB Wy4cHhTEk8PpkzZtHijJBllinb8G47LDG19c68AW67k+siaD7xylzXsVSRqUYBzqXYga GWOCgu+vyme/Q4WmGmDoc7QtsjlacnJHejaZ+h+vK/DWyGur4ZJuUCUKCb2Jl3kweOrC Mz7q/yA+mIQNNLO5EETnA/Xd1Ivl+N6kSKP620s/Q8bUhhXsSj5Y7IYywOeUTFTPOVKk v7Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782974498; x=1783579298; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C7gG1XXRUXGBnFboK8BGuq44cQ+yqBfPnKNNfXgaklg=; b=HsJ8qOjki8CXXWGkbFTCELU70qnbFZnqZ3jA3w02hUSrBLhsGEkkdZwLFgovXN7z9/ gXC5Uut0Jx+lOIiYJWvjeYQyoN8j8jndqz6iwR04czRhpAOaWAbJAe9WltfQekV3cBBZ TBW4BDhKi/tZGeGcxIELX2J8rESqP5eb5egHrnuqr3UODION18EX7+li7Bez08NdAa3T AIKufo+b08lcpR5uIAis7yjLiDtnfhVI7sp0jGSR7n3n0CAefLJym0G/5YARHtcprbtQ AA+8SO0oonza+vHIYxlHob4hOBJOnan4vog9VgCkSWv818mfZJ8qsYcnlFg0n6UWcKG4 TtIA== X-Forwarded-Encrypted: i=1; AHgh+Rpb02OwYG8QmRAwJuD758bud76CH9RQEYov5ikxqeFrM9ufq/EIF14IBAyBSWOpO3puvXvAXFVdyJ8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzI+sP2onGaGxL6nnfYBdvBaP1Ig2mxrMuCql+Uy5ebaMx517gt o5nD7HBUH9RXbx8AxgUDk9gxzuf/wZx5kWNdgmp7nN8lDrPCsYPbLHb+wGSYCmEBlQ== X-Gm-Gg: AfdE7cmOM0+yumhPljFaCeiJz151rJmMBbNuMYD2fHeXf8+3ZHa+XDZZ2Uskr296i24 mS5OS8FkJYoJ161/+nZjtoYvagvGt6Vvc4/wX7ybZi2/L5xSrgYuIehmWHCf6Id7v3lLZbXsT7n XD+h/jyuufzfaAmmnExnwh7EJPRoN7+fxA6VhkVPMQSw4TrfwI5RFY0ZcF8W+i3/nz0AwG9x83F cQYW6r8ymsKuCoDQOdYpmUjkuko2W7ulxvT+j1JIn7dyRPZ52wppgl9cWrGJBJvbojeQgZG4dh6 jpq6bgwUA2m2EdOf/CTbgDm6dCgMC275Rw3yZ0JSV577GR2oENrp3oy4OWwTQ1VzbFFxy6CQj8l 0a+vmTh3LsaI/zNfoQ0lx/tEVddLZjIvnHRmWXyhhWHec+X2lz4c02zMKcRG9WRWFfQwfEKReVd 2nqbTRXeONLxCNoWdqtGikClKB6tS/LO/UjNmLTqGx/AVDc0wmMROfqmWURiWJyWQV1yp9oUQ2G 4fc X-Received: by 2002:a05:6000:18a4:b0:475:f0f0:9f05 with SMTP id ffacd0b85a97d-4775a2f5df1mr7083019f8f.60.1782974497717; Wed, 01 Jul 2026 23:41:37 -0700 (PDT) Message-ID: <2e3d404f-8716-4d0f-b739-d1e842b5a07c@suse.com> Date: Thu, 2 Jul 2026 08:41:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 25/25] xen/riscv: add initial dom0less infrastructure support To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <131fc20c-1353-49fc-8f77-1ca13628ff17@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1782974498-7E53825E-D7ACE335/0/0 X-purgate-type: clean X-purgate-size: 2412 On 01.07.2026 17:24, Oleksii Kurochko wrote: > On 6/30/26 9:28 AM, Jan Beulich wrote: >> On 26.06.2026 17:46, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/include/asm/guest-layout.h >>> +++ b/xen/arch/riscv/include/asm/guest-layout.h >>> @@ -32,4 +32,16 @@ >>> #define GUEST_RAM_BANK_BASES { GUEST_RAM0_BASE, GUEST_RAM1_BASE } >>> #define GUEST_RAM_BANK_SIZES { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE } >>> >>> +/* >>> + * The guest magic region holds Xen-reserved pages mapped into the guest's >>> + * physical address space (shared info, grant table, etc.). The only real >>> + * constraint is that the GUEST_MAGIC_SIZE-byte region must not overlap >>> + * guest RAM (the GUEST_RAMx banks) or the emulated device regions defined >>> + * above; the exact base is otherwise arbitrary. Here it is placed in the >>> + * unused gap below GUEST_RAM0_BASE (0x80000000), but a hole after a RAM >>> + * bank would work equally well. >>> + */ >>> +#define GUEST_MAGIC_BASE _UL(0x79000000) >>> +#define GUEST_MAGIC_SIZE _UL(0x01000000) >> >> ... while 16Mb may seem a lot, it feels pretty little for 64-bit guests. >> Even in just Sv39 mode they have ample VA space to map a bigger region. >> (As iirc indicated before, a static upper bound looks questionable to me >> anyway.) > > I think the comment should be updated as for grants will be separate region. > > For all others, it looks like 16MB is more then enough. For example, Arm > has only 4 used pages (CONSOLE=0, XENSTORE=1, MEMACCESS=2, VUART=3). Then the question goes the other way around: Why 16Mb? Won't e.g. 2Mb suffice? > So will you be okay with reworking of the comment to: > /* > * The guest magic region holds the Xen-reserved pages mapped into the > * guest's physical address space. The only real constraint on > * GUEST_MAGIC_BASE/SIZE is that the region must not overlap guest RAM > * (the GUEST_RAMx banks) or the emulated device regions defined above; > * the exact base is otherwise arbitrary. Here it is placed in the > unused gap > * below GUEST_RAM0_BASE (0x80000000), but a hole after a RAM bank > would work > * equally well. > */ > > And add to the commit message that: > ``` > A separate region for grant tables will be introduced at the same time > as the introduction of the grant table for RISC-V. > ``` That's quite a bit better, yes. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 07:07:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 07:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351276.1608495 (Exim 4.92) (envelope-from ) id 1wfBVh-0007d1-MV; Thu, 02 Jul 2026 07:06:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351276.1608495; Thu, 02 Jul 2026 07:06:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBVh-0007cu-Iw; Thu, 02 Jul 2026 07:06:57 +0000 Received: by outflank-mailman (input) for mailman id 1351276; Thu, 02 Jul 2026 07:06:55 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBVf-0007cn-DG for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 07:06:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfBVe-004g8K-5Z for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:06:54 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a460dff-2eae-0a2a0a5409dd-0a2a450ad4fc-26 for ; Thu, 02 Jul 2026 09:06:54 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a460e0d-e40e-0a2a450a0019-d155dd2dc8dd-3 for ; Thu, 02 Jul 2026 09:06:54 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-475417f010dso933938f8f.2 for ; Thu, 02 Jul 2026 00:06:53 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477de3dcf59sm6614748f8f.34.2026.07.02.00.06.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 00:06:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782976013; x=1783580813; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=JIa3ZtQnmr5bzh3sgHLJgVuJFtyf3ipj2ua5AIkulis=; b=AKbG5dqwVnWcVDI3EixT0QRt2O1aPtA6Pe+lnUKP3vBUJrlCV/ocv7EX52XZesdOOg fPTy75ha7wTL+15c8wHOCmzwFkdDd49s1RZwzTE+jyjfb9nodFJu9507yQ3WKVwyWYiV TeiWMGoskf2W1jdAbQSiZNO/Jwzm1z/ufIgPoBEbgyDZBwMj+uNxDmUbuZrN4Ho5TbJj 4J7jBPd24FhMjf7jKD6OgoNSUW6PBdxb5lHY3qshpiNejhrIvYYR4fVMuiKpE3v4wWkR 6zGcU8n3CtvYH1VoWAMyfqpKP81NlUbKRLolEFflXAW69Hx4377zO4Hp2aH3SfNO8E7k yWcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782976013; x=1783580813; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JIa3ZtQnmr5bzh3sgHLJgVuJFtyf3ipj2ua5AIkulis=; b=Q2BUAaJMRIf93wqA0JWeko4AGwW9Jw6BXaVXwlPRGKT9hgtL6SsgSgpvXkt1ToAvza KXoLUYknYlmJbwALi3Pv4/zK7saA/4kPVRZdi+eXE+57VO1j8LEYpQSQd9xYxw7om/z9 ATdRK+2t56o0k61KiiRwZQz5SzeDX6/utNEGFAgRSeYzMTjkUzfHJtXlczZJGYylOBNt 7Dj+hOgmw00eS8DvuH/6pNHffEWfKm/96xNEu2Kt8ziWC8AU1drE3U8FvJcr0PEqp4AQ vQMj9NT80gvvTo6tgCFVe+PS4io08t14wdYt3Am0kvjmWCiMbQcD1Nki9+ZziCYTu7X6 Q8hQ== X-Forwarded-Encrypted: i=1; AHgh+RpX9dg+O0wWbGJfKZ8qaMX+5oIdrO4NYczMLQCHNW3WvSsiRJKxeeM5sYiHjI/z222yfNQE2SN60B4=@lists.xenproject.org X-Gm-Message-State: AOJu0YzA9Ivum01bbRGBS9+OA3a9f1XrmSYe9Ayacrn8BGUdqC7LIwBJ 5toHpJ/H5sRwcZHGTEregS97gJfV10FPVBpoT/m56YugWPQc47Y4TPwOvOEVK9pFAw== X-Gm-Gg: AfdE7ckAyn7YqKhg1AtZjPBk8RtqHz/HgAed6A6OEhw2cKkpufwJFRtVei9YjtYoBJh XX6i9b0rAA/64zR0hb6l5bJYLhbuoN/XC0Lat/U1+oieOjloU/iH1zZ345PBTcBmVJU3prsVSd4 QBX8JXnfxxd/vKrUYAlwCcqlwlmDEoZrAyBvld3W0P3GqbQWUYe/Cp9LR1Oejy4KjG3NAFdUqaC xYmvrKgqE4U1V/l7VORo6Od8YOitR6ZjmARqrz5kD03pfcCHIRBu9Ew15DNDc6lrtc+cfiVp2XP EZeel7Jmw5Zo96Tip4qs6uHMsX/TtlsO8U6RZD9AgEK6gZOAedGbio2C7ZcKnKpBf1gxjwNDidx VdRHntKma3b/W3vRa7Am7LxURQ8Xnk8vS4M10Mi3F5VGfq6oyUcKlQ63MCS1BZIF1EEu0h+qj2I bYADvCytaPuTQfF4nYeMVkw91EL2S55XfQb0ZlJs2EqMtH1xzK9SdH9SvKTB7NSPpObkMEPMBsW dV4bjF+HvFvZUg= X-Received: by 2002:a05:6000:4687:b0:474:6a5b:861d with SMTP id ffacd0b85a97d-47759568499mr5060699f8f.45.1782976013421; Thu, 02 Jul 2026 00:06:53 -0700 (PDT) Message-ID: <2a524220-72a8-422d-8571-f5111b090c1d@suse.com> Date: Thu, 2 Jul 2026 09:06:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/cpu-policy: set up host policy earlier To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski , "xen-devel@lists.xenproject.org" References: <6dccae5f-fe09-4f35-9e4a-7a38fb21e8d1@suse.com> <53018bb5-0ad4-449e-adda-6b2d94a0935e@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53018bb5-0ad4-449e-adda-6b2d94a0935e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1782976014-3C07ADDE-7DF6AF92/0/0 X-purgate-type: clean X-purgate-size: 3113 On 01.07.2026 17:21, Andrew Cooper wrote: > On 07/04/2026 7:46 am, Jan Beulich wrote: >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -586,6 +586,8 @@ void identify_cpu(struct cpuinfo_x86 *c) >> } >> >> /* Now the feature flags better reflect actual CPU features! */ >> + if (c == &boot_cpu_data) >> + calculate_host_policy(); > > calculate_host_cpu_policy() now it's not local to cpu-policy.c Sure. >> --- a/xen/arch/x86/cpu-policy.c >> +++ b/xen/arch/x86/cpu-policy.c >> @@ -359,7 +359,7 @@ void calculate_raw_cpu_policy(void) >> /* Was already added by probe_cpuid_faulting() */ >> } >> >> -static void __init calculate_host_policy(void) >> +void __init calculate_host_policy(void) >> { >> struct cpu_policy *p = &host_cpu_policy; >> unsigned int max_extd_leaf; >> @@ -904,6 +904,7 @@ static void __init calculate_hvm_def_pol >> >> void __init init_guest_cpu_policies(void) >> { >> + /* Do this a 2nd time to account for setup_{clear,force}_cpu_cap() uses. */ >> calculate_host_policy(); > > I'm sorry, but no.  The cleanup work to CPUID handling is in an attempt > to purge this antipattern. And it's not meant to stay here, once that cleanup work has further progressed. We did discuss this on one of the recent calls. I'm happy to ... > Double-initialising data structures *is* the entire reason we have > order-of-boot problems in the first place.  Having a structure which is > initialised but wrong is itself wrong. ... go further, just that I don't think what you suggest below will work. > Really, I should insist on a revert of switching cpu_has_* to use > host_policy.  It was not adequately tested and is not compatible with > how Xen starts up. You realize that there was no "switching cpu_has_* to use host_policy"? There's no representation of leaf 6 in x86_capabilities[], and it seemed awkward to introduce it when we're really moving to using the policies. > But as I expect you're going to object to that feedback, I'll tolerate > setup_*_cpu_cap() keeping the host policy correct as they're called.  > The easy option is to call x86_cpu_featureset_to_policy() each time.  Except that this isn't going to be enough. It may not need to be all of what calculate_host_policy() currently does, but at the very least recalculate_xstate() will imo need calling. Yet any cpu_has_* used there and changing value would also have a knock-on effect. Overall it then looks less error prone to me to call calculate_host_cpu_policy() from there (then very obviously eliminating the need for the call from init_guest_cpu_policies()), accepting the slight extra overhead. > The lower overhead option would be to have a table similar to > cpu_user_regs_gpr_offsets[] and use that to locate the feature word in a > policy object as it's being edited, although it's yet another thing to > remember to keep in sync when adding new words. As per above multiple feature words may be affected by a single change. Hence I think this isn't an option. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 07:13:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 07:13:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351288.1608502 (Exim 4.92) (envelope-from ) id 1wfBbl-0001PU-Bc; Thu, 02 Jul 2026 07:13:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351288.1608502; Thu, 02 Jul 2026 07:13:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBbl-0001PN-8Z; Thu, 02 Jul 2026 07:13:13 +0000 Received: by outflank-mailman (input) for mailman id 1351288; Thu, 02 Jul 2026 07:13:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBbj-0001OC-Of for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 07:13:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfBbj-006neM-5H for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:13:11 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a460f67-bab6-0a2a0a5309dd-0a2a4504924e-42 for ; Thu, 02 Jul 2026 09:13:10 +0200 Received: from [40.93.194.25] (helo=SN4PR0501CU005.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a460f85-a01d-0a2a45040019-285dc2192b28-3 for ; Thu, 02 Jul 2026 09:13:10 +0200 Received: from SJ0PR05CA0114.namprd05.prod.outlook.com (2603:10b6:a03:334::29) by SA3PR12MB9091.namprd12.prod.outlook.com (2603:10b6:806:395::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Thu, 2 Jul 2026 07:13:06 +0000 Received: from CO1PEPF00012E81.namprd03.prod.outlook.com (2603:10b6:a03:334:cafe::3b) by SJ0PR05CA0114.outlook.office365.com (2603:10b6:a03:334::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.181.8 via Frontend Transport; Thu, 2 Jul 2026 07:13:05 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by CO1PEPF00012E81.mail.protection.outlook.com (10.167.249.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Thu, 2 Jul 2026 07:13:05 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 2 Jul 2026 02:13:04 -0500 Received: from [10.252.145.116] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 2 Jul 2026 02:13:04 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hMoAy8u7BjAKeSDM3ibSBizL1Bb7b2FjZR6fh/YnBM9R+t4d9fQM4/0jSxbpaHnaf5gZBfR9knA2sapJUCQweowgCzP0Wc5IcSEwEby+7KTO0ybhcgbsh3S+aVYnzqdFVeiNy6s+5qIbVPMMAbofQBImCxFZqHk4Rs2uTWHDsEd8CyB992BhwJ41OEuZFVWn6XpC75EmvLjaLSiJdnUl5LiCeHJZobhmYyrdgnvHC5dJ0Bi55EzO/Gv77qTzWoU4PU/CSOFQd7Ls4eC23lE8GOOz4JpDOetrgqQ+XG82QNulNLCBSJm36cLkuGum2Ta0NIfUyHMUNpa29sd/EraHMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yj42o5dQa5WI3bb6qW20n8gTFcCUFB1Aw2r8frAqhX8=; b=rprn7nqeCfTgl/hqJ2Ukj+3lpEFbTQwyCAPjGcbZn6lzszcVMLIOWyb8vrWt+4EaA2V2i8Kyamt2gcTCbY90zU7uEZ+elPseUXCY31eDrbamsCpF7SCD34TmAMA4qJHAUk8tSJUAYI2m1yRt2CdpwPi0iQQZSc5HVBwVPyNtAYdjqoxxEEdO53UmtdVrG9S0OzaZkAIU+IkUNudHAcuyAz/x9D5uQK58eH81Leiwg8J3dyfE8Wma7GyUmnKZ4ILiTbIhQSjKHMIzvyJ+/sxNaVp0nJ/kBX4qGScxpF7P+3OcJebXzkKQNFToTwngtbLqgB65Pq+6rzcBNUw1rIgM+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=valinux.co.jp smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yj42o5dQa5WI3bb6qW20n8gTFcCUFB1Aw2r8frAqhX8=; b=pG59x/5WD4xpb6iaeN2foDt9SlSeCuc4nwJnPGye17BJ8M20QeL+8fCPw8Lo604dFiEfK8GCiAxhnlYRpd98tpHgXwkY8tYaijKQy8Ty8dHjQCT0OvYSOKtfY02i5AwzMQCUqwwZaM49Gj41vhLW7VfqYMnlwL35ICHcIEYo6Cs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Message-ID: <57a8d88e-c5ee-44cc-9832-c1e766fecaa7@amd.com> Date: Thu, 2 Jul 2026 09:13:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] xen/arm: fix sparse cpu_possible_map calculation on SMP boot To: Hirokazu Takahashi , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis References: <20260701224057.46592-1-taka@valinux.co.jp> From: "Orzel, Michal" Content-Language: en-US In-Reply-To: <20260701224057.46592-1-taka@valinux.co.jp> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E81:EE_|SA3PR12MB9091:EE_ X-MS-Office365-Filtering-Correlation-Id: 87f84350-f12b-4838-ae60-08ded8095ce2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|376014|1800799024|36860700016|18002099003|22082099003|11063799006|56012099006|6133799003; X-Microsoft-Antispam-Message-Info: J/tc7cryDSu0SensP+cmf7Dvv1H6y46AyRxnu9nnK4HXVS3p9bWvltm1iGfjg/Sc3TQsAxruZv7trfeUMxFEsv0xyVLGIAGEcc296zEVlWgyA4ErDik+43aApruCNVEjTQyo80woG5Kl2pYQ69INq/3ypJkbh44TPpXw7eVIaQPb77k1d8MAskvFUwoOMlN13NkpgS08tXucOiRyNwPFemzX2zBw/q7ftA8cMwYQOQclgsAUHezrsoO7SEmZGWFLbiwe2KhFqZt3QqGWaRsWO06gPRUyHAUaauHIreZEc8p5yEz3pCs2yh5Cc8WW28mob4l8zUk7DldNAmSMtRJMvHj+L/i5DAnHvOn2riu7u33nsKm8/pPsp/IJLeqhj59nJeZG4eNsNajF/2he7u23P2jZsLaoD2hrrMGfy3jwrvBRPhR/JUmq40JKb/4s1H641Hs+QXnI51S9AMeXqMmTHPpIDU4BlJniSJ8APu3qGHBq3nDHOMF4ng22Vh77BJRXs9W8a7OdXguNwQVZe02T+a9M7BArW9MaM+eokHR8WxZKuLbud8SYN/XJwfrTTivP1ydl6gDJLuiZ4JtOLb+hrSnWkPZHQbPkxb+C4j8x8rhFcFRbrPIJPciH0SfI7x34xTTffJM9L0ssr+KlTaEIvM4k8BCvs/PzQsI4J0C48d9oMUHfLNuM333h84TTfc1Nst2WVaAwLHmJhzZDhwckHQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(376014)(1800799024)(36860700016)(18002099003)(22082099003)(11063799006)(56012099006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: R5IgeScsl9Q+STCKzwgovCPLU6OmxqaVg1fwT/VhwSWvBZbMIUfcHJuVdjNf7lPWm/VnkAlcdtSbJ6kTwzsMs1qqzvhUhTaXC5aRqftYV+hdqn8rKhIeZGbwH0Vr2EvsKLlw/VDuEAM1aEOPkHrILPIROnu7oE56DkBIksC7p72aSmGkvbbDYIxXZPU/YDRrSsILqqtccDOh9tQbw9yGzbq+80OnFDGLJXu95Ihp9Ltl9smMLnAL9wEdtKDXyNT5/siOkene3dqZ/IoKj5ltJQcO9OOVaX+fRcIzgE8a1B4y0t7hPqbUJjG4RFk1veetDGjIzvq/vvKAHJJjA4SUgjI8+Dbkg6hQfaNK2M2oug9ku8PgDVvquQOiCvXmWVfdBk1kd1mj0f1wmpyHUzkvnoGY3EXm0NHaCRUC4pM7R7QLxXdoKfRwAkr+mf5aN6sx X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 07:13:05.6523 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87f84350-f12b-4838-ae60-08ded8095ce2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E81.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9091 X-purgate-ID: tlsNG-ebf023/1782976390-AC93A1CC-A099F199/0/0 X-purgate-type: clean X-purgate-size: 945 On 02-Jul-26 00:40, Hirokazu Takahashi wrote: > Currently, during ARM Xen's SMP initialization, if there is > a Device Tree error (such as an invalid 'enable-method'), > cpu_possible_map can end up being sparse. > > The issue here is that nr_cpu_ids is calculated in a way that > doesn't properly account for the maximum CPU ID when the map is > sparse, causing a mismatch. For example, if cpu_possible_map is > 0xff0f, nr_cpu_ids becomes 12, but the actual maximum CPU ID > is 15. Xen's common code is built on the assumption that > 'CPU ID < nr_cpu_ids', so this mismatch can break things. > > To fix this, modify dt_smp_init_cpus() so that if the > arch_cpu_init() call fails, we don't consume the CPU ID slot. > > Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring up") > Signed-off-by: Hirokazu Takahashi Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Jul 02 07:19:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 07:19:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351299.1608512 (Exim 4.92) (envelope-from ) id 1wfBi9-0002sv-0B; Thu, 02 Jul 2026 07:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351299.1608512; Thu, 02 Jul 2026 07:19:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBi8-0002rj-TC; Thu, 02 Jul 2026 07:19:48 +0000 Received: by outflank-mailman (input) for mailman id 1351299; Thu, 02 Jul 2026 07:19:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBi7-0002rd-LL for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 07:19:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfBi5-005hn9-W8 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:19:46 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a461111-5cb7-0a2a0a5109dd-0a2a450be308-8 for ; Thu, 02 Jul 2026 09:19:45 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a461109-ac48-0a2a450b0019-d155dd2aa430-3 for ; Thu, 02 Jul 2026 09:19:37 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4758bd3731bso178764f8f.0 for ; Thu, 02 Jul 2026 00:19:37 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477de3dcf59sm6699044f8f.34.2026.07.02.00.19.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 00:19:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782976777; x=1783581577; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=GFnEOfF4jj8cE+H+zkvtGX3ba5jqVqYD8LMd89m3nVg=; b=TA16WlQz8Sr1sOwiyEabhBNmZK3cvXPHnLy+saIFyvoFyEdBNVKCmzM7uwE6zt8cLw CAKObjnRzCaUbDbLnpaDjS3q5InpzDOEIyXw8vOniHxzWGp/WPZ+wmm/POK8iBwEvTr+ uaLrXoiHazwFnVZsmKvgHMj7CpnxWEP9K0ij82cphCJsa1YJpVl72aRSP8bc4Z9ZA/ZN h9V7Edm/MBlhIjmbgdAkV5vncvsFOgDq5nAV+FCIwwntKXJkT9mN0fz9xtAsUXAwjP7M 2QUGaALS1ZGR1k88MuCzy6y0Ab3G8RH9E4omQGPGC/w/uUccAKIcJF/gFLXKP5XPtfSS Gssw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782976777; x=1783581577; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GFnEOfF4jj8cE+H+zkvtGX3ba5jqVqYD8LMd89m3nVg=; b=gZigKKzyZmzYGCA85FH+klAdsLDOKEuIqbKQMKAgNfYVp2IobXf3KEtq5DtpgYRJrN LYvmnEu5Mb3rxdNTg9FH9A5zmi1soR65VGZ5fAErwlQQy1466X6q/XmrmKWWFhv/nQqD 55BfnKm2NjnNDGaU8X3vK2SyjivgyUskVnfGIexqy7OFe4S7OZW5RIdeRHtZ9rMvHjCF ZlQybe+l8QqLY1JzfbG3Yb241fDZE+X+1nZreAzK2dbl/TxXZEDLgLa7pF0DWrikukbh F4SBwSk08P1EhyYbgW8T5MC6QKzsjuwN2BKVVdwD7TwmTZyXPHWIhct/2OqymwFTbMxb 6Rew== X-Forwarded-Encrypted: i=1; AHgh+RrK51ZPlUYf6zhPMbp3LTIRNiVpT9I74Dmsr3iET3oz30t7pdqeOI5/NqoL9iw1ou49U3N0U6Q1+S8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzHziKUNvkWTCbEGpOFUzRwN3oL6ViduqHafD26396hprNHG+QR fK+J8Q3e23wCDkE4BIK4eGPXiBzMBiMGya58LLgCYbCg2AqX1rgOue2hnZSK7EwZfA== X-Gm-Gg: AfdE7cl3DOrJ7KRKb/Vg97Wej2JrYZMphSijZz4YPiaFR7M+OVUltw9SCr53MDTdHxb P8TLqb+wmkdwkXkvNqjtEAiXUcWG685PyNMTQZN+3OFjWW6YBnu8bjfEMDDWvkBCXH3wB4AYRQ0 QrBpWX3wL8jbyGHxiuM0YZu8081vWLyEpLOQRMyfPhHVCtTNpPUd4B1P1g+kyE7CAsVb+MdiVVm tfumrPeKne3E7rWHJUyVUymc3CAvsnmJ6DbIH0/8Ot6sPHquJ8jTwYiWJTgUuk1uNgWMeLJDW5z qLh2sETv15hmOGYdznZB57uRKwQpqzBDn0AcEV6wFFLn7/VjfJMLR3RWMmhNc2i79dtsSC0S3t0 7lWKQgCJX5V20Tvu5gDK7pAyFQEL747vfr4SBsOR51lFa2Z14PPLyWLRbU3tIk8FfPHhUCDm7AG 9JhfqcYS0BgIlCGqRpTC/0YqV3x+Xd8jMX5qSOIi6VCojrPk/uIWhnrgSIBnmvArTAzLA6Deq1B tUh X-Received: by 2002:a05:6000:468b:b0:478:3df9:5d8c with SMTP id ffacd0b85a97d-4783df95e6fmr1443116f8f.2.1782976776616; Thu, 02 Jul 2026 00:19:36 -0700 (PDT) Message-ID: <71d8cad5-50cd-41ff-b674-abac64f296e9@suse.com> Date: Thu, 2 Jul 2026 09:19:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/cpu-policy: set up host policy earlier To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski , "xen-devel@lists.xenproject.org" References: <6dccae5f-fe09-4f35-9e4a-7a38fb21e8d1@suse.com> <53018bb5-0ad4-449e-adda-6b2d94a0935e@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <53018bb5-0ad4-449e-adda-6b2d94a0935e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1782976777-A6939220-46E0A658/0/0 X-purgate-type: clean X-purgate-size: 2109 On 01.07.2026 17:21, Andrew Cooper wrote: > On 07/04/2026 7:46 am, Jan Beulich wrote: >> In order to use cpu_has_* expanding to host_cpu_policy.*, the host policy >> needs setting up alongside boot_cpu_data.x86_capability[]. Arrange for >> that towards the end of identify_cpu(). >> >> Fixes: 894bd7617924 ("x86/Intel: use host CPU policy for ARAT checking") >> Reported-by: Marek Marczykowski-Górecki >> Signed-off-by: Jan Beulich >> --- >> In the longer run we may need to (also) update the host policy from >> setup_{force,clear}_cpu_cap(). I'm noticing only while making the change that I did already suggest here what ... >> --- a/xen/arch/x86/cpu-policy.c >> +++ b/xen/arch/x86/cpu-policy.c >> @@ -359,7 +359,7 @@ void calculate_raw_cpu_policy(void) >> /* Was already added by probe_cpuid_faulting() */ >> } >> >> -static void __init calculate_host_policy(void) >> +void __init calculate_host_policy(void) >> { >> struct cpu_policy *p = &host_cpu_policy; >> unsigned int max_extd_leaf; >> @@ -904,6 +904,7 @@ static void __init calculate_hvm_def_pol >> >> void __init init_guest_cpu_policies(void) >> { >> + /* Do this a 2nd time to account for setup_{clear,force}_cpu_cap() uses. */ >> calculate_host_policy(); > > I'm sorry, but no.  The cleanup work to CPUID handling is in an attempt > to purge this antipattern. > > Double-initialising data structures *is* the entire reason we have > order-of-boot problems in the first place.  Having a structure which is > initialised but wrong is itself wrong. > > Really, I should insist on a revert of switching cpu_has_* to use > host_policy.  It was not adequately tested and is not compatible with > how Xen starts up. > > But as I expect you're going to object to that feedback, I'll tolerate > setup_*_cpu_cap() keeping the host policy correct as they're called.  > The easy option is to call x86_cpu_featureset_to_policy() each time.  ... you're effectively (see my earlier reply) asking for here. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 07:28:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 07:28:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351310.1608521 (Exim 4.92) (envelope-from ) id 1wfBqO-00053m-Rp; Thu, 02 Jul 2026 07:28:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351310.1608521; Thu, 02 Jul 2026 07:28:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBqO-00053f-PD; Thu, 02 Jul 2026 07:28:20 +0000 Received: by outflank-mailman (input) for mailman id 1351310; Thu, 02 Jul 2026 07:28:19 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfBqL-00053G-Vw for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 07:28:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfBqJ-00Cl8V-Tc for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:28:17 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a461302-bab6-0a2a0a5309dd-0a2a450aad90-28 for ; Thu, 02 Jul 2026 09:28:15 +0200 Received: from [95.215.58.176] (helo=out-176.mta1.migadu.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46130d-e40e-0a2a450a0019-5fd73ab0ee00-3 for ; Thu, 02 Jul 2026 09:28:13 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782977290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cdXAMvaGTLXZ4tRHqX+15mFjqPO5NJv7/lbzInUeZeM=; b=UUw36nfQUDO4ek5W5MoGxv/bQdNbTQycY1qQKAEoJymjql+ZXc8a2FUo9eNrafl6xDrEni 1302Z8Y+Ma+0qxdUDhBISoxry5nus7uGAN8fTkB0ZcU/zUf+14Ol9iIljWhjg5Yh/mt933 8BhSh84bNWygA1To4TaXOltx56F5hgs= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() Date: Thu, 2 Jul 2026 15:27:50 +0800 Message-Id: <20260702072750.45641-1-lance.yang@linux.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-4011c0/1782977295-3C67BDDE-C6E0EA24/0/0 X-purgate-type: clean X-purgate-size: 680 On Mon, Jun 29, 2026 at 08:25:24PM +0100, Lorenzo Stoakes wrote: >These test whether the VMA has stack sematics, i.e. is able to grow upwards >or downwards depending on the architecture. > >In order to account for arches which do not support upward-growing stacks, >introduce VMA_GROWSUP whose definition depends on the architecture >supporting it, and use vma_flags_test_single_mask() in vma_flags_can_grow() >to account for this. > >Update the VMA userland tests to reflect the changes > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- Nice cleanup! Feel free to add: Reviewed-by: Lance Yang From xen-devel-bounces@lists.xenproject.org Thu Jul 02 07:49:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 07:49:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351323.1608529 (Exim 4.92) (envelope-from ) id 1wfCAv-0001ME-F1; Thu, 02 Jul 2026 07:49:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351323.1608529; Thu, 02 Jul 2026 07:49:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCAv-0001M7-CP; Thu, 02 Jul 2026 07:49:33 +0000 Received: by outflank-mailman (input) for mailman id 1351323; Thu, 02 Jul 2026 07:49:32 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCAt-0001M1-OO for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 07:49:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfCAs-00D4wd-3v for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:49:30 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a461807-2eae-0a2a0a5409dd-0a2a45048326-4 for ; Thu, 02 Jul 2026 09:49:29 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a461809-a01d-0a2a45040019-b9ff1c22a145-3 for ; Thu, 02 Jul 2026 09:49:29 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f21cddaf000080a8.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 02 Jul 2026 07:49:26 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 2ADE08078E; Thu, 2 Jul 2026 09:49:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=z8acwMs0RoUZwSPsP//PIk2dCVY8ioVGU3CXmoXVDiw=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=LnfK1AEhWJ8lZV22XZOKslPVHAJW+wid1/K9TSYRNy6TJZgjLlBEv9kUuP1XIPLr4EvkFHGq0 5o33ymhAQZ+9b7nQlpAj3PEXMIB3w/WqPGrt2UtzkgLpIwg0IckNr1S06qgjXpL2XXCLiEaI4JK xn1e7k2AJ3hKbodmbIfH0cSM1B+BVvQ/vOSsa9XlsBpPkm+EQ8rxrwP2am8icX/zydNBB0iav3b 6LiOtCcvqTS7IN/SqZ9mf4jK65zjAl6DfEetfnS8ekwym7cGobCvYV25+FJzw6J7AeBnyy8x5OV ckKnuq3f8ItRjq/CPt1tbrJuB1Eib5Ko76Qn57A7N+DA== X-Zone-Loop: 060998b047c4324b69275eab5ebbc0ed7f7e3edfa9f9 x-campaign-type: default x-transaction-id: b86dc9e0-945d-4035-9d95-d72967eb17c3 x-swg-uid: 01-ee351179-8bfa-4446-a477-5ecbe552e781 X-Mailer: Sweego Message-ID: <1782978566.8631fc262581453bbf619ec5b2062170.19f21cddaf000080a8@vates.tech> x-swg-bid: 1782978566.8631fc262581453bbf619ec5b2062170.19f21cddaf000080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Thu, 2 Jul 2026 09:49:25 +0200 From: Anthony PERARD To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Juergen Gross , Daniel Smith , Marek Marczykowski Subject: Re: [PATCH v2 1/2] libxc: drop size parameter from xc_flask_context_to_sid() References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.e.292e58765e21126.19f21cdd88f.7002498917770ad1=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1782978566294 X-purgate-ID: tlsNG-ebf023/1782978569-2E3A41CC-2699A41C/0/0 X-purgate-type: clean X-purgate-size: 807 ---=Part.e.292e58765e21126.19f21cdd88f.7002498917770ad1=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2026 at 04:47:52PM +0200, Jan Beulich wrote: > Nul-terminated strings are passed in all cases, so the strlen() can very > well be invoked by the function itself=2E In preparation for a hyperviso= r > change also include the nul terminator in the size calculation=2E >=20 > Signed-off-by: Jan Beulich > Acked-by: Marek Marczykowski-G=C3=B3recki Reviewed-by: Anthony PERARD Thanks, -- | Vates XCP-ng & Xen Orchestra - Vates solutions web: https://vate= s=2Etech ---=Part.e.292e58765e21126.19f21cdd88f.7002498917770ad1=--- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 08:07:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 08:07:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351350.1608539 (Exim 4.92) (envelope-from ) id 1wfCSI-0005HQ-EM; Thu, 02 Jul 2026 08:07:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351350.1608539; Thu, 02 Jul 2026 08:07:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCSI-0005HJ-BZ; Thu, 02 Jul 2026 08:07:30 +0000 Received: by outflank-mailman (input) for mailman id 1351350; Thu, 02 Jul 2026 08:07:29 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCSF-0005Gx-0z for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:07:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfCSD-00Ctpl-IC for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:07:25 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a461c3d-bab6-0a2a0a5309dd-0a2a4502db44-0 for ; Thu, 02 Jul 2026 10:07:25 +0200 Received: from [40.107.74.104] (helo=OS0P286CU010.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a461c36-5a27-0a2a45020019-286b4a682f06-3 for ; Thu, 02 Jul 2026 10:07:20 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by OSOP286MB4065.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2ee::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Thu, 2 Jul 2026 08:07:15 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.008; Thu, 2 Jul 2026 08:07:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TUkYh5Y+D4G98NAg0UpiOP8AVDzft/twQmPLC2YhKR+ssLXIYyXh1a7LHafNPoAgzVzCdpFlC/0HZp+HfBTMMP6taiusMZHhAz8Tir5FT/k20c4+pPqQByeGDPUjxL5vKl5mn2SsXKFpJN8Rgg62IUAL0LCE7/5B4dSaHzhSZW4n7FsNg63gT/4HpovhKsNIUj6+gyesgGLY0Uuw/IiAm0KcjZ7GwtkPm97/tEJkJbXDoHRSQmfS8gXAcdxEBjpcfUxbQ30ZzWYKL6iRlXzWsWcsDFcQu8uzoD+VV57IuL6kSqHlAZ9mGoy7Nk57BJVtuZ0CRi72sOvCXVQQ6hVkig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lm2Xs0vJxEQMJv1GsMyDFtYzEB3g9T9GExU9KeoBEME=; b=TTfMWqQbf7ExHLGwmLHGXASOue6glenvR24HxYdWJAaa7Y1wjum7rJvrofhVuqhBQv3WTFFhuIC+nQ8wwgH/vBTwVRC5Jne99eYCnqoQQameSnTiCZwlLXFGT02U3d3v3UZ65JYa1jdmSm/j619lOnjQwYpZ+pRmzYjdeBEtyUJe+8DI8cZACGV2xQgXB/OhXvSqpOHC0WvfZYE2+fqDDO0Du+vZCdu0P+PJTRpVAaFdHePtuldT7eedFxL297dnS3AUCTZ7WrPZmVw8GIVj4SVwFFgwvfL3ABKrSDah9fpU4QxnNZE0zrg7EhY4p8g2jg86HRpKwZ4RTeoSR8kMyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lm2Xs0vJxEQMJv1GsMyDFtYzEB3g9T9GExU9KeoBEME=; b=uhfpK7UQJRnfZ4PE66it2mfE+IwSXsRo73cFEF1vVmJYgQ2zzPNlhFP0beZirxtd6ROur7wBKMKS1ISu649VLXKwiCRxfAGg8sMcu03h9ccxOZ+M0eCQLKHzdyTOiFbprRryyFYufPtS5d4yUyc+JjgB/0yyus5FRMbxsnH0DRY= From: Hirokazu Takahashi To: Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Thread-Topic: [PATCH v3 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Thread-Index: AQHdCBJguMZzJpb/JEe22XtErI4LcbZWqjWAgAHISeCAABufgIAAi7BQgAClhICAACFHIA== Date: Thu, 2 Jul 2026 08:07:14 +0000 Message-ID: References: <20260629215806.11610-1-taka@valinux.co.jp> <20260629215806.11610-2-taka@valinux.co.jp> <97dd9fd5-c0de-4125-a40a-b7f6e1aed27d@suse.com> <52d1d0b4-6b90-4eb8-a299-7adcc7634f33@suse.com> In-Reply-To: <52d1d0b4-6b90-4eb8-a299-7adcc7634f33@suse.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS9P286MB7222:EE_|OSOP286MB4065:EE_ x-ms-office365-filtering-correlation-id: 69e0d0d9-58d4-48c4-a492-08ded810ed79 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|7416014|376014|22082099003|18002099003|38070700021|6133799003|4143699003|56012099006; x-microsoft-antispam-message-info: n0/7h4MQ4qZMOroI22vBzlBi40tmSTgQQRg7ZbDdzKoZnLVIegGae8CpB+UZlFCSC1eFuqK8KjcnKUMDtcJomDZJGdEZW0P6mWG0wn6Ds3f7QxTjWCZRY2OavH5iJSvkuCrHHJ6lY7FhMgh9nG3U/zjerHPeUY2w7u3sebn+fPp5u+A1sg4MZZFV52X0UKp88SAvUwe7Eq+8b0Q6YAyEnLWASEm7PI9AYs+KqIQNLxDkFpj8Agt8AsXW2PKlNGQnJTDtYIBL3RfOE5pVxjtchBLkvEIvI8UYymP/w4KWIyQzLnhLSZ7QUJLFT9QQvN1W8Skquhk3Y1tuaRK70Tqa+OiZc/+k6m4Mx6pOyhexyH9WWa1kJ5ZQC4RuwIscWIGv2GhK2obUo4lYMf0ZVuJkBRR5uDnxxtnvheI0+ctJcEZsKRVo8z32ecBQVUI7m85cFc3hUlFYJpGt6Q34fWSgFwe5IFB3rVxJwbx7Q3vpawXjLiddwNHHR80tDYPC4/+LnvKzJdI3yHVJfkyHp/ArPumW+uCCMVoE6vCG3uhIhQ0178PrvFTaskeTRbwFR46YORMF2iGIXei/d9zK28VstFE3UUjyLLnKGhuSeI62MZdTAcCDRq+KLy0X1zROXYOGEq/mf4Alwhtx+Zh5TGhIZw6TwbSc/+VHfsNaAv23gASAd1rCbLCmiJE/mJzCBily6xwgkKtRUs4oaOr1MobiVGXefTpDn3Rfrb/9cCuJcW8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(7416014)(376014)(22082099003)(18002099003)(38070700021)(6133799003)(4143699003)(56012099006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WjBQYnN5a2xOOHlzWnNlWW9adWVoOUMwaTNsUFlLM2hLZm1iN3JHdVRvVWRx?= =?utf-8?B?OWluemhhSDBPWVpRVHVTZkx4elZkUXUrVys5QXIxOXIxYndKYWp5czRmSEVr?= =?utf-8?B?ZHFzdStJNVk4T2JTbjRvVDZCYjEyMWQvajlOMFlzSWRmb0w4SnY3OFc0T2Ux?= =?utf-8?B?dzRwNkE1YlE3QXB0UjVIbUV5UjE3eWM4Z0hoUDV2ZXlCVnZBUkUwYUFLUEpa?= =?utf-8?B?OEhrSmdLZFJSZHlDclhJVWl3TWI5YitaRFdqNSs0SUM4ZGZpUXZINXNxaXhF?= =?utf-8?B?NmFUdExsTURvT0dISEVqLzZ4SzFvalVsVksyNWwybUZhaXBsdUx3ZXVMQjFv?= =?utf-8?B?Qm1URHBvM2I3RXBlc01qemROUkZHcmZaZi9WUU9JYnZKbUV6MkEzVE0zMHpP?= =?utf-8?B?SlRCQmQycEE4SVpCU1QxZGhtb25NU2l2K1hjRDJUS0VJRnZyeEswZHkxWUVX?= =?utf-8?B?Q1Z2S1BQeDZ6SnB3S01hNjZiK0tJNHlQMXAzUGVKUzA0LzlTVTFVblRjV3Nh?= =?utf-8?B?cWF5V0lLZjB0alA3RmtJNkc5ejYwN05jYXd3R21OZ0pCOEVEV2ptYnYxRlFG?= =?utf-8?B?YnVHQlU3MDZRUE0yM2p3amNWL2xNUEw4dkNFMVBIcXJBM2c1YnBCaVMzK2xI?= =?utf-8?B?RHNyazFYdjNzUVlBSFUwb2lhSVM2Rm93UVBKZkF4SE5ZTFBMekR5SXl3d0ox?= =?utf-8?B?Ylc3SjlrYzRKODhudXpjc2dPNCtXYStMN2ZHZ1ljcXQ4WG0zc29DaUxqczV1?= =?utf-8?B?ZXlDSkhCTUJxSmhLNEgzK00vMjdYUVdIdjE4NmdTenBrOVlCU2xHZytOKzds?= =?utf-8?B?WGZJZVprdXdTMUFQMklUUTJwZS92NUk0enE2ZnQybTRXaHk1UjBualVZZlNy?= =?utf-8?B?ZlRTZ2Y1L2tPWlk2QlpDNVdwYkFBYkM4OW9RbXpVZXBJakl3R0NBN2ZDOUxJ?= =?utf-8?B?bEpEMHVwKzhwRHNUUVQ4RmxVMjgvZ1pkUk1WSHJlUzROSVhCQXcyN2hhSHRp?= =?utf-8?B?RndMMUJZMkVWSjRZY0gzWFNGT05GSEZjdGtJcS9QSjNqWVpXSHRlUzBLNStR?= =?utf-8?B?dUdCMksxRkRvRGZQRzlpUkhxbzRmL0M2RjNmVHRROXNtS3hXNS9LZU40Nzdi?= =?utf-8?B?QVFnYzVtMlpoYnBGNVlhWnVSemhSajV2dEw3OEZwRUV1a0hjYWdnSktjZlVG?= =?utf-8?B?dVlRTnNpTldWVzNvOGVTTW1FTEVDeTNHZUFsQlIwMGQxcWtRMnc0U2g1UmZL?= =?utf-8?B?dU1LaU5VeEJDSGFwZzMyWTNOeUtWalNqd1dibkliMVJWTmpmcTA0Y2tMbGpZ?= =?utf-8?B?OXFiMmpoSEZJV3pQY3B4T2dkM2Y0eGFnZFRpNU5PMlEwaTRTcEV6MWx3UUFD?= =?utf-8?B?NXV5YlFzNTMxRFUwS1A4MnRxdWNvK0NYN0xqNC9oOHZWMHBDOGh1YmNia3M5?= =?utf-8?B?MUNYWmdTeWgrRm9lcFJncUc2L0QrSURCSGk3RGxQMU52NWFLdmppWUQ0MGRu?= =?utf-8?B?Ri9oRkdYRE1maTYrZ3JkeVI3S1VZUjgzbnlERFFYak5SZTFIcUY4TXA4aTZQ?= =?utf-8?B?SXlzQUNScVJFajZQRXR0RHlVQWpDL2tyTGIvSGFZa2NnbU9LTVVEWDVZRG1t?= =?utf-8?B?cC9waHgwNUFhVHd3cnEvVXFSb1F6UVVwM21Rd0NsWWhzemQvZmFJKzlVb05x?= =?utf-8?B?MHdDd1B6M2V4WWM5SGtCU1dnelRsbUNVRHhaL0srdEcvK3N6V1dSTzVScDg5?= =?utf-8?B?VGlEcVphUGxkbG5ZOEIwTjRMeEtZRW4yUThKbjJ4ZW1HcDVqeWRpNWpIRUIr?= =?utf-8?B?V2FUcUVxTFM1UExSdE5PWGVZS0RDaVU3MGJ5VFNMQUV1Yyt4eVNkUXNGWnJX?= =?utf-8?B?ZURiT29UajQzTFdsZ2FBYngrZ3NlN3BDOS9KVmk4eTVMUXpoRUpyV2dzVnFK?= =?utf-8?B?QXhOWG42czY5YWZWQ3R6TWtuYkRybGRWR1lvSGJWSE8vdlpsQkxJTmp6QUhK?= =?utf-8?B?OG01VSt3Z2FtRVFLTEt3cG43a0I3dHBlemVHdzZ2R21mTzlpdm5nMXM0VEhX?= =?utf-8?B?RWRFcStha1NtRXVrdVhETVBFSU80N0ltZExGa3lBY1ZST0czV0RxK3M1OFNN?= =?utf-8?B?Qm9sSE1mTGZqR1dQZURnSkJ0dFViOWliTndFRUg1eUp1NC9ORWdlbHpaMnNi?= =?utf-8?B?Vkhxb1VmeUlwR29uMDZFbWtlbkttcVZpandXc3JXTDcxajJlRnc2SS9wTFNr?= =?utf-8?B?eTNYNGxIVkxaaVZtY3U1elNlV05tU1RQVzg0R1F0Mkl5RE9Va1hmQVprZ0JJ?= =?utf-8?Q?ulGNjzAO/a9YTnJvDb?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 69e0d0d9-58d4-48c4-a492-08ded810ed79 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2026 08:07:14.4600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yrbEhs0iaRbForExSyX8lC1a6BhQVSbzcFRi3U5CNR9QQEV+5W7du7YmOAagCCjfR/5l+bl30r4MyOi02KkELw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSOP286MB4065 X-purgate-ID: tlsNG-720697/1782979645-4C13A7C5-BED15EBC/0/0 X-purgate-type: clean X-purgate-size: 2366 SGVsbG8sDQoNCj4gPj4+Pj4gKyNlbHNlIC8qIENPTkZJR19DUFVfVE9QT0xPR1kgKi8NCj4gPj4+ Pj4gKw0KPiA+Pj4+PiArI2RlZmluZSBjcHVfdG9wb2xvZ3kgKChzdHJ1Y3QgY3B1X3RvcG9sb2d5 ICopTlVMTCkNCj4gPj4+Pg0KPiA+Pj4+IFdoeSBleGFjdGx5IGlzIHRoaXMgbmVlZGVkPyBJdCB2 ZXJ5IG11Y2ggbG9va3MgYXMgaWYgaXRzIHByZXNlbmNlIG1heSBoaWRlDQo+ID4+IGJ1Z3MuDQo+ ID4+Pg0KPiA+Pj4gSW4gdGhlIGN1cnJlbnQgY29kZSwgdGhlIGNvbmRpdGlvbiBpZiAoIGNwdV90 b3BvbG9neSApIGlzIHVzZWQgdG8gY292ZXIgYm90aA0KPiA+PiBjYXNlczoNCj4gPj4+IHdoZW4g Q09ORklHX0NQVV9UT1BPTE9HWSBpcyBkaXNhYmxlZCwgYW5kIHdoZW4gbWVtb3J5IGFsbG9jYXRp b24gZm9yDQo+ID4+PiB0b3BvbG9neSB0YWJsZSBmYWlscy4NCj4gPj4+DQo+ID4+PiBUaGUgbmV4 dCBwYXRjaCB1c2VzIGlmICggY3B1X3RvcG9sb2d5ICkuDQo+ID4+Pg0KPiA+Pj4gc3RhdGljIGlu dCBzZXR1cF9jcHVfc2libGluZ19tYXAoaW50IGNwdSkNCj4gPj4+IHsNCj4gPj4+ICAgICBpZiAo ICF6YWxsb2NfY3B1bWFza192YXIoJnBlcl9jcHUoY3B1X3NpYmxpbmdfbWFzaywgY3B1KSkgfHwN Cj4gPj4+ICAgICAgICAgICF6YWxsb2NfY3B1bWFza192YXIoJnBlcl9jcHUoY3B1X2NvcmVfbWFz aywgY3B1KSkgKQ0KPiA+Pj4gICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4gPj4+DQo+ID4+PiAg ICAgaWYgKCBjcHVfdG9wb2xvZ3kgKQ0KPiA+Pg0KPiA+PiAgICAgaWYgKCBJU19FTkFCTEVEKENP TkZJR19HRU5FUklDX0NQVV9UT1BPTE9HWSkgKQ0KPiA+DQo+ID4gVGhpcyBsaW5lIHNob3VsZCBi ZSBpZiAoIElTX0VOQUJMRUQoQ09ORklHX0dFTkVSSUNfQ1BVX1RPUE9MT0dZKSAmJiBjcHVfdG9w b2xvZ3kgKQ0KPiA+IGJlY2F1c2UgJ2NwdV90b3BvbG9neScgY2FuIGJlIE5VTEwgZXZlbiBpZiBD T05GSUdfR0VORVJJQ19DUFVfVE9QT0xPR1kgaXMgb24uDQo+ID4NCj4gPiB2b2lkIF9faW5pdCBp bml0X2NwdV90b3BvbG9neSh2b2lkKQ0KPiA+IHsNCj4gPiAgICAgdW5zaWduZWQgaW50IGNwdTsN Cj4gPg0KPiA+ICAgICBjcHVfdG9wb2xvZ3kgPSB4emFsbG9jX2FycmF5KHN0cnVjdCBjcHVfdG9w b2xvZ3ksIG5yX2NwdV9pZHMpOw0KPiA+ICAgICBpZiAoICFjcHVfdG9wb2xvZ3kgKQ0KPiA+ICAg ICB7DQo+ID4gICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiRmFpbGVkIHRvIGFsbG9jYXRlIG1l bW9yeSBmb3IgY3B1X3RvcG9sb2d5IHRhYmxlXG4iKTsNCj4gPiAgICAgICAgIHJldHVybjsNCj4g PiAgICAgfQ0KPiANCj4gQWggeWVzLiBUaGUgb2RkICNkZWZpbmUgY2FuIG5ldmVydGhlbGVzcyBn byBhd2F5LCB3aGljaCBpcyB0aGUgaW1wb3J0YW50IHBhcnQuDQoNCkhlcmUgaXMgbXkgY3VycmVu dCBwbGFuOg0KSW4gdGhlIGBjcHUtdG9wb2xvZ3kuaGAgaGVhZGVyLCBJIHdpbGwgcHJvdmlkZSBh biBpbml0aWFsaXphdGlvbiBmdW5jdGlvbiBmb3IgYGNwdV9zaWJsaW5nX21hc2tgDQphbmQgYGNw dV9jb3JlX21hc2tgIHdoZW4gYENPTkZJR19HRU5FUklDX0NQVV9UT1BPTE9HWWAgaXMgb24sIGFs b25nIHdpdGggYW5vdGhlcg0KZGVmaW5pdGlvbiB3aGVuIGl0IGlzIG9mZiwgYW5kIHRoZW4gY2Fs bCB0aGVtIGZyb20gYHNldHVwX2NwdV9zaWJsaW5nX21hcCgpYC4NCg0KVGhhbmsgeW91LA0KSGly b2thenUgVGFrYWhhc2hpLg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 02 08:09:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 08:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351357.1608548 (Exim 4.92) (envelope-from ) id 1wfCUL-0006BB-Pb; Thu, 02 Jul 2026 08:09:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351357.1608548; Thu, 02 Jul 2026 08:09:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCUL-0006B4-M8; Thu, 02 Jul 2026 08:09:37 +0000 Received: by outflank-mailman (input) for mailman id 1351357; Thu, 02 Jul 2026 08:09:36 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCUH-0006Aw-VE for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:09:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfCUH-00D9Bf-8P; Thu, 02 Jul 2026 10:09:33 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a461cba-bab6-0a2a0a5309dd-0a2a4501d770-4 for ; Thu, 02 Jul 2026 10:09:32 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a461cbb-400f-0a2a45010019-5a9b3222b4d4-3 for ; Thu, 02 Jul 2026 10:09:31 +0200 Received: from [2001:8b0:10b:5:5473:9ff4:cd52:8d75] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfCTx-00000008ASp-1ISn; Thu, 02 Jul 2026 08:09:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=C1JE0E2yTpRWfUkz4axn6/Dw5IWHQaOp/p6g23YXFbE=; b=q801JK05dLlH+llycjxFQ//QeS LEbRR45YFW2vz4zIwfiFSnaVtVZ0DZoh5+pxi1J3h9hQxsFNTB64UHBENmcNi8qQFtMuC0Q28yFQD JQyyoYs0N6tVzustwYmBoUpezPS/6gR8KIeyWsR6HQUDHqAeOsTnuu/7Iz1oyO2U5Ouxwe6LuAq4V wciJ79rBd0XV3JVl5jp8RQdrCwqCuwCqYINgqbBNojO9TfL+J+GHuUYDFhAPSnMGVrDF9/aMHhDM4 ggKo5lICjSzdRTDZWxcMl5jnjFBZL46js8x/g4MMDazDxcDmmSOC9ou/cua7ldgmol2aFfnQs2BZH VA6j3lEg==; Message-ID: <45a534712b398d5d3b2343a67d9855ff6980a9ae.camel@infradead.org> Subject: Re: [PATCH v5 08/34] KVM: x86: Add KVM_VCPU_TSC_SCALE and fix the documentation on TSC migration From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Thu, 02 Jul 2026 09:09:11 +0100 In-Reply-To: References: <20260608145455.89187-1-dwmw2@infradead.org> <20260608145455.89187-9-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-ha5BiPOGdolMhVL9f35m" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d62444/1782979772-D16DE1E0-0249674C/0/0 X-purgate-type: clean X-purgate-size: 9306 --=-ha5BiPOGdolMhVL9f35m Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2026-07-01 at 14:47 -0700, Sean Christopherson wrote: > On Mon, Jun 08, 2026, David Woodhouse wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index c1897d939da9..6337f9b9d7ac 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -5930,6 +5930,9 @@ static int kvm_arch_tsc_has_attr(struct > > kvm_vcpu *vcpu, > > =C2=A0 case KVM_VCPU_TSC_OFFSET: > > =C2=A0 r =3D 0; > > =C2=A0 break; > > + case KVM_VCPU_TSC_SCALE: > > + r =3D kvm_caps.has_tsc_control ? 0 : -ENXIO; > > + break; > > =C2=A0 default: > > =C2=A0 r =3D -ENXIO; > > =C2=A0 } > > @@ -5950,6 +5953,22 @@ static int kvm_arch_tsc_get_attr(struct > > kvm_vcpu *vcpu, > > =C2=A0 break; > > =C2=A0 r =3D 0; > > =C2=A0 break; > > + case KVM_VCPU_TSC_SCALE: { > > + struct kvm_vcpu_tsc_scale scale; > > + > > + if (!kvm_caps.has_tsc_control) { > > + r =3D -ENXIO; > > + break; > > + } >=20 > Uber nit.=C2=A0 For consistency with KVM's bizarre pattern here: >=20 > r =3D -ENXIO; > if (!kvm_caps.has_tsc_control) > break; Ack. > > + > > + scale.tsc_ratio =3D vcpu->arch.l1_tsc_scaling_ratio; > > + scale.tsc_frac_bits =3D > > kvm_caps.tsc_scaling_ratio_frac_bits; > > + r =3D -EFAULT; > > + if (copy_to_user(uaddr, &scale, sizeof(scale))) > > + break; > > + r =3D 0; > > + break; > > + } > > =C2=A0 default: > > =C2=A0 r =3D -ENXIO; > > =C2=A0 } > > @@ -5989,6 +6008,9 @@ static int kvm_arch_tsc_set_attr(struct > > kvm_vcpu *vcpu, > > =C2=A0 r =3D 0; > > =C2=A0 break; > > =C2=A0 } > > + case KVM_VCPU_TSC_SCALE: >=20 > Another stupid consistency nit.=C2=A0 Probably do this? >=20 > /* > * TSC scaling information is read-only (it's a > reflection of > * the TSC frequency, which can be set by > userspace). > */ > r =3D kvm_caps.has_tsc_control ? -EINVAL : -ENXIO; Hm, I'd already done that, but it ended up squashed into the final patch of the series. Putting it back in the right place for v6, along with the above. --=-ha5BiPOGdolMhVL9f35m Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCD9Aw ggSOMIIDdqADAgECAhAOmiw0ECVD4cWj5DqVrT9PMA0GCSqGSIb3DQEBCwUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBDQTAeFw0yNDAxMzAwMDAwMDBaFw0zMTEx MDkyMzU5NTlaMEExCzAJBgNVBAYTAkFVMRAwDgYDVQQKEwdWZXJva2V5MSAwHgYDVQQDExdWZXJv a2V5IFNlY3VyZSBFbWFpbCBHMjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMjvgLKj jfhCFqxYyRiW8g3cNFAvltDbK5AzcOaR7yVzVGadr4YcCVxjKrEJOgi7WEOH8rUgCNB5cTD8N/Et GfZI+LGqSv0YtNa54T9D1AWJy08ZKkWvfGGIXN9UFAPMJ6OLLH/UUEgFa+7KlrEvMUupDFGnnR06 aDJAwtycb8yXtILj+TvfhLFhafxroXrflspavejQkEiHjNjtHnwbZ+o43g0/yxjwnarGI3kgcak7 nnI9/8Lqpq79tLHYwLajotwLiGTB71AGN5xK+tzB+D4eN9lXayrjcszgbOv2ZCgzExQUAIt98mre 8EggKs9mwtEuKAhYBIP/0K6WsoMnQCcCAwEAAaOCAVwwggFYMBIGA1UdEwEB/wQIMAYBAf8CAQAw HQYDVR0OBBYEFIlICOogTndrhuWByNfhjWSEf/xwMB8GA1UdIwQYMBaAFEXroq/0ksuCMS1Ri6en IZ3zbcgPMA4GA1UdDwEB/wQEAwIBhjAdBgNVHSUEFjAUBggrBgEFBQcDBAYIKwYBBQUHAwIweQYI KwYBBQUHAQEEbTBrMCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wQwYIKwYB BQUHMAKGN2h0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRJRFJvb3RD QS5jcnQwRQYDVR0fBD4wPDA6oDigNoY0aHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0 QXNzdXJlZElEUm9vdENBLmNybDARBgNVHSAECjAIMAYGBFUdIAAwDQYJKoZIhvcNAQELBQADggEB ACiagCqvNVxOfSd0uYfJMiZsOEBXAKIR/kpqRp2YCfrP4Tz7fJogYN4fxNAw7iy/bPZcvpVCfe/H /CCcp3alXL0I8M/rnEnRlv8ItY4MEF+2T/MkdXI3u1vHy3ua8SxBM8eT9LBQokHZxGUX51cE0kwa uEOZ+PonVIOnMjuLp29kcNOVnzf8DGKiek+cT51FvGRjV6LbaxXOm2P47/aiaXrDD5O0RF5SiPo6 xD1/ClkCETyyEAE5LRJlXtx288R598koyFcwCSXijeVcRvBB1cNOLEbg7RMSw1AGq14fNe2cH1HG W7xyduY/ydQt6gv5r21mDOQ5SaZSWC/ZRfLDuEYwggWbMIIEg6ADAgECAhAH5JEPagNRXYDiRPdl c1vgMA0GCSqGSIb3DQEBCwUAMEExCzAJBgNVBAYTAkFVMRAwDgYDVQQKEwdWZXJva2V5MSAwHgYD VQQDExdWZXJva2V5IFNlY3VyZSBFbWFpbCBHMjAeFw0yNDEyMzAwMDAwMDBaFw0yODAxMDQyMzU5 NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqGSIb3DQEBAQUAA4IC DwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZeYAS/SRV6zmfXlXaZ sNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2zkC9S7/yHDYnqegqt w4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qGpgFdZEk2/c//ZvUN i12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41vav1RhZJzYan4a1gU0 kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0cvnO8FM6PTqsnSbcc 0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PWPU6zfQTOMZ9uLQRR ci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXtREF5lLXxp+CJ6KKS blPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQrlR0gO3lBzuyPPArV hvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7IqaAovAX0d+f1YjbmC VsAwjhLmveFjNwIDAQABo4IBsDCCAawwHwYDVR0jBBgwFoAUiUgI6iBOd2uG5YHI1+GNZIR//HAw HQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3bXcyQGluZnJhZGVh ZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEBMA4GA1UdDwEB/wQE AwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwewYDVR0fBHQwcjA3oDWgM4YxaHR0 cDovL2NybDMuZGlnaWNlcnQuY29tL1Zlcm9rZXlTZWN1cmVFbWFpbEcyLmNybDA3oDWgM4YxaHR0 cDovL2NybDQuZGlnaWNlcnQuY29tL1Zlcm9rZXlTZWN1cmVFbWFpbEcyLmNybDB2BggrBgEFBQcB AQRqMGgwJAYIKwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmRpZ2ljZXJ0LmNvbTBABggrBgEFBQcwAoY0 aHR0cDovL2NhY2VydHMuZGlnaWNlcnQuY29tL1Zlcm9rZXlTZWN1cmVFbWFpbEcyLmNydDANBgkq hkiG9w0BAQsFAAOCAQEAQXc4FPiPLRnTDvmOABEzkIumojfZAe5SlnuQoeFUfi+LsWCKiB8Uextv iBAvboKhLuN6eG/NC6WOzOCppn4mkQxRkOdLNThwMHW0d19jrZFEKtEG/epZ/hw/DdScTuZ2m7im 8ppItAT6GXD3aPhXkXnJpC/zTs85uNSQR64cEcBFjjoQDuSsTeJ5DAWf8EMyhMuD8pcbqx5kRvyt JPsWBQzv1Dsdv2LDPLNd/JUKhHSgr7nbUr4+aAP2PHTXGcEBh8lTeYea9p4d5k969pe0OHYMV5aL xERqTagmSetuIwolkAuBCzA9vulg8Y49Nz2zrpUGfKGOD0FMqenYxdJHgDCCBZswggSDoAMCAQIC EAfkkQ9qA1FdgOJE92VzW+AwDQYJKoZIhvcNAQELBQAwQTELMAkGA1UEBhMCQVUxEDAOBgNVBAoT B1Zlcm9rZXkxIDAeBgNVBAMTF1Zlcm9rZXkgU2VjdXJlIEVtYWlsIEcyMB4XDTI0MTIzMDAwMDAw MFoXDTI4MDEwNDIzNTk1OVowHjEcMBoGA1UEAwwTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJ KoZIhvcNAQEBBQADggIPADCCAgoCggIBANqWLse95HW2F7FhfH9bugyT/danKmmXrbMnz5GZNAfj Jl5gBL9JFXrOZ9eVdpmw04Tp6aDxZctFLoEDvSWKi367Q7Sg+ci+fH4KwwfQ8Pi0IpIKx2n5emEg nbOQL1Lv/IcNiep6Cq3DiyaSpSp/RZf+CAfUNySHS8eWmhLU6jGpSD6hxTpYKye7PmrmvMWwfGEP WoamAV1kSTb9z/9m9Q2LXa89aKmTxNwnAfD3Ohn9mtU3JukwILRMewn9QRXK7KzM+01h5hkCE4nj W9q/VGFknNhqfhrWBTSQoE9CSVylASGrjzCgS7XmKy/BaH3/7mOOHQv5g1o3Qj/+cdKnpT0I5Qb1 nRy+c7wUzo9OqydJtxzSP4ZyHA4dELto/a3m/ay1XHcpum1pgTOLgxAfGb/T4dCkwRUstSKLMmpL g9Y9TrN9BM4xn24tBFFyL5znGG0wQGzOVAM68RBzIQb6Fz758fjsr4yZnPbVsU1+gHEs/puNHrG0 9e1EQXmUtfGn4InoopJuU8p5VGD9S3Ikd4UoBlc7xl5yjtNlQxUeYrRlnUSmdlucCEoTX1n4UmtA 9CuVHSA7eUHO7I88CtWG9bGOU7tLgOZoSEvNqtaL/N7sQbBZK4jZ4Rr/zNTQg1SwYjjLB7u96lDP sipoCi8BfR35/ViNuYJWwDCOEua94WM3AgMBAAGjggGwMIIBrDAfBgNVHSMEGDAWgBSJSAjqIE53 a4blgcjX4Y1khH/8cDAdBgNVHQ4EFgQUXGIam3Bs59Y60yTmWgfDu6pZQ6cwMAYDVR0RBCkwJ4ET ZHdtdzJAaW5mcmFkZWFkLm9yZ4EQZGF2aWRAd29vZGhvdS5zZTAUBgNVHSAEDTALMAkGB2eBDAEF AQEwDgYDVR0PAQH/BAQDAgXgMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEFBQcDBDB7BgNVHR8E dDByMDegNaAzhjFodHRwOi8vY3JsMy5kaWdpY2VydC5jb20vVmVyb2tleVNlY3VyZUVtYWlsRzIu Y3JsMDegNaAzhjFodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vVmVyb2tleVNlY3VyZUVtYWlsRzIu Y3JsMHYGCCsGAQUFBwEBBGowaDAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29t MEAGCCsGAQUFBzAChjRodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vVmVyb2tleVNlY3VyZUVt YWlsRzIuY3J0MA0GCSqGSIb3DQEBCwUAA4IBAQBBdzgU+I8tGdMO+Y4AETOQi6aiN9kB7lKWe5Ch 4VR+L4uxYIqIHxR7G2+IEC9ugqEu43p4b80LpY7M4KmmfiaRDFGQ50s1OHAwdbR3X2OtkUQq0Qb9 6ln+HD8N1JxO5nabuKbymki0BPoZcPdo+FeRecmkL/NOzzm41JBHrhwRwEWOOhAO5KxN4nkMBZ/w QzKEy4PylxurHmRG/K0k+xYFDO/UOx2/YsM8s138lQqEdKCvudtSvj5oA/Y8dNcZwQGHyVN5h5r2 nh3mT3r2l7Q4dgxXlovERGpNqCZJ624jCiWQC4ELMD2+6WDxjj03PbOulQZ8oY4PQUyp6djF0keA MYIDuzCCA7cCAQEwVTBBMQswCQYDVQQGEwJBVTEQMA4GA1UEChMHVmVyb2tleTEgMB4GA1UEAxMX VmVyb2tleSBTZWN1cmUgRW1haWwgRzICEAfkkQ9qA1FdgOJE92VzW+AwDQYJYIZIAWUDBAIBBQCg ggE3MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTI2MDcwMjA4MDkx MVowLwYJKoZIhvcNAQkEMSIEIPwdk3oI52k79aKV9gIVapIy73RBxiwb4g4bB1YLBpXEMGQGCSsG AQQBgjcQBDFXMFUwQTELMAkGA1UEBhMCQVUxEDAOBgNVBAoTB1Zlcm9rZXkxIDAeBgNVBAMTF1Zl cm9rZXkgU2VjdXJlIEVtYWlsIEcyAhAH5JEPagNRXYDiRPdlc1vgMGYGCyqGSIb3DQEJEAILMVeg VTBBMQswCQYDVQQGEwJBVTEQMA4GA1UEChMHVmVyb2tleTEgMB4GA1UEAxMXVmVyb2tleSBTZWN1 cmUgRW1haWwgRzICEAfkkQ9qA1FdgOJE92VzW+AwDQYJKoZIhvcNAQEBBQAEggIA0c1d/Z60Nafu Hgfcy2RFoR+BGmEwrmgiK3gPndzXqrGSjemf0G5ZFLyOkkJVLwqtFrT5v4GsMNnBti+hAlcFAhe7 KTY4PVcGZrfwT3D9rhg9vsEzMSa0k6YhC9bybj7jdR2R8U98vtvLuyY7YcmRbNNz8PAdoUNeNGeu Jm5oSuK7GJ7Vu9gvQaF+AZ+bsL5kx8TM/Xen5p3s7tqGSTZTs5Z84XmhL3UIv0sJ1Tn4/lvJQzjd caKQt+THhWaqjpUwPV+4HDNZmS500uNSxalqR0k/eORtOXAsT5GLBefy4/GYndKqi8Og7sTcWn7q QYBoTXYZx5vUoJXU/BQisCS12NGw3C+x3ddSlZieFe38NLr4U155Rv9qsFJnPfZzaeOaI/x2JPwZ PErpag2BSEAzjhnne5QXZZLIab3+kX7pEcWU/izuy8Nsc8VKTMC/Jh0tGZWdhS5gIv+QZCfFMDje GBQWu8uCuzf6gUMKC+kDDCJZoQ03k0HLW3cJ7gwH8/h3MT0UyAA8RobKuXht/pZ+oEQCqvDTFjmf ppGeaVSNpqfTRk7D0cmamUM53P+qwT2IQ9sDJY168fvlNlFVcfOZjJKNojmLSrP+a5HfxLs2LzBN Kx65YaUxa2LfNJ930DZLOiv5R0E9W2K6cOKBAbsreDpu0u+AwnQrZfw4qZyDY/wAAAAAAAA= --=-ha5BiPOGdolMhVL9f35m-- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 08:10:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 08:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351365.1608558 (Exim 4.92) (envelope-from ) id 1wfCVE-0007ed-5r; Thu, 02 Jul 2026 08:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351365.1608558; Thu, 02 Jul 2026 08:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCVE-0007eW-2F; Thu, 02 Jul 2026 08:10:32 +0000 Received: by outflank-mailman (input) for mailman id 1351365; Thu, 02 Jul 2026 08:10:31 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCVD-0007eE-00 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:10:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfCVC-006YAq-24 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:10:30 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a461cea-e002-0a2a0a5209dd-0a2a450b8880-44 for ; Thu, 02 Jul 2026 10:10:26 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a461cf1-ac48-0a2a450b0019-b9ff1c228991-3 for ; Thu, 02 Jul 2026 10:10:25 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f21e0f0bb00080a8.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 02 Jul 2026 08:10:17 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id EA49B81185; Thu, 2 Jul 2026 10:10:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=NzjTuiIjDTo1ZZYWkpiat2ZqEEL6x3BN/uhxJFF01R8=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=Zr/oNT9XlnRlOrgPaKUQf9FbSprIFnNkWwqEEHkDDGxQy2tmwZhWG3ys5HUQj7+p2HuV51TSj 5yz9CjcPNftPUy6IQjz9EIyec+VcDoFYfuprjqiT+sfQiXiPDaKcci7MXF/gv/0CYNpIEwwNZGt c+k/ho+qEBhfIH8p7IRjqIsFCakfGXlHzK0O4Tf2FkjpwjIgHI8xFTesXcLA4Nv0eqineLtAXEe S/JdX7rtVhI5cHVeiiid11BXuR3xMsVdrxgGndWt42AnF/7dMCNUp5x3JF2qcST27IxjU/XqE6E 1QeVHNaTfNv4vJ3V9YzqxYRNr6xa+mkH3lqZuPks96UQ== X-Zone-Loop: ee71f1b68e5dcc06fe78d492b4692f29d182dab32c26 x-campaign-type: default x-transaction-id: d87f70da-4587-4978-bfa8-d0bde2e2714a x-swg-uid: 01-ba1883c0-31d7-4f8a-bd64-0c977363d851 X-Mailer: Sweego Message-ID: <1782979817.8631fc262581453bbf619ec5b2062170.19f21e0f0bb00080a8@vates.tech> x-swg-bid: 1782979817.8631fc262581453bbf619ec5b2062170.19f21e0f0bb00080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Thu, 2 Jul 2026 10:10:16 +0200 From: Anthony PERARD To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Julien Grall , Stefano Stabellini , Michal Orzel , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Daniel Smith , Oleksii Kurochko Subject: Re: [PATCH v2 2/2] lib: make safe_copy_string_from_guest() validate input References: <80bc4e83-b767-4692-9ce1-0ebf68d7ab26@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <80bc4e83-b767-4692-9ce1-0ebf68d7ab26@suse.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2f.704031f6a12d6c5e.19f21e0ee99.35cf2f2dae56525b=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1782979817114 X-purgate-ID: tlsNG-42698a/1782979826-A653B220-F8C34B4A/0/0 X-purgate-type: clean X-purgate-size: 800 ---=Part.2f.704031f6a12d6c5e.19f21e0ee99.35cf2f2dae56525b=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2026 at 04:48:33PM +0200, Jan Beulich wrote: > =2E=2E=2E rather than papering over guest flaws: Strings passed ought to= be nul- > terminated (yet sadly libxc hasn't been doing so thus far)=2E This way w= e > also avoid order-1 allocations, seeing that all present callers pass > PAGE_SIZE for max_size=2E >=20 > Signed-off-by: Jan Beulich Reviewed-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.2f.704031f6a12d6c5e.19f21e0ee99.35cf2f2dae56525b=--- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 08:27:36 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 08:27:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351390.1608567 (Exim 4.92) (envelope-from ) id 1wfClb-0001Xa-Gx; Thu, 02 Jul 2026 08:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351390.1608567; Thu, 02 Jul 2026 08:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfClb-0001XT-CN; Thu, 02 Jul 2026 08:27:27 +0000 Received: by outflank-mailman (input) for mailman id 1351390; Thu, 02 Jul 2026 08:27:26 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfClZ-0001XN-S7 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:27:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfClY-004xj1-C6 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:27:24 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4620e0-5cb7-0a2a0a5109dd-0a2a4503a562-36 for ; Thu, 02 Jul 2026 10:27:24 +0200 Received: from [209.85.221.48] (helo=mail-wr1-f48.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4620ec-ec1a-0a2a45030019-d155dd30d83a-3 for ; Thu, 02 Jul 2026 10:27:24 +0200 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-472055b0efaso1044809f8f.2 for ; Thu, 02 Jul 2026 01:27:24 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477de3dcf59sm7162237f8f.34.2026.07.02.01.27.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 01:27:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782980844; x=1783585644; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zKHg2RP9zwp0jh1QYT0fbAawl8DbSSyIAAMqCg9UC9Y=; b=AA+ky+ORzK6kJMFgse6LkMcsT3bNmfzp0C4pIdXU17/CNRO/TwLGoOc+Ud1F6PWQP9 7qPfrlM+IwrPw5p5yvKPuJWMzvg02VzxX9Sx9R1zSb5rp5d1HxL4H+cmbhIU7yPpecgW 10cfDnor3Gj4lMVq27cZuc512oMLlmy090T9rNfPcsg1toYj+XTh7L/0gXBgsYqy1QpH S6yT6MogDF7w2yQ6sXtpz7xrSNSVp24Q/URp4E7UNeXwGAiy8YfD2a6hx9O4N0R2venb a/v/hsO+Xotc/ReOidSXdYwHWzYC14SaZltt7OOGnz3BBDAEC3BAIi1sEZ04IaHtcupM Ws5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782980844; x=1783585644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zKHg2RP9zwp0jh1QYT0fbAawl8DbSSyIAAMqCg9UC9Y=; b=Zd2mVp3x8879g72SpNSMwQTr1OqpmsgQdJtK7Ods26ZiUvra+kAPxUTvpkVT9NyiWQ lj0L4shWSvW8G0JAOQ2DPq1PwkCsGSVkKjsSBAMMUjU2Y9XkkuF2mmdaGnRWPlI0U2RX 4oC4nyzQ8NMJVAln45QOdB8n7gs2MafM0N2b7J2SGclEqc8r5m/1CCJzC1h+SNLK1qeD 0Ht2QQ32lQ8C0q0yq9tNRDngVo4pXK+u2kk3+wBEg9Q4klH914HyJZTqeARtreLeJIgV t1mqiPm+V4ouxdx1gT+BQlUXCHzEgPErvvVBF6ERct7QI6tV1R7ZFz4q4DmJ6NLHa+PY +seQ== X-Forwarded-Encrypted: i=1; AHgh+RpSa2XWwRCaeim9kYng70fuCBskVdmrqDqCYo0asKrUG37cha0MLyDLAxz7PQ2NdndZc8S4B1p23eI=@lists.xenproject.org X-Gm-Message-State: AOJu0YxYHQq2Z37Z06Diukomu0qL3FVIs0usAJB2uOROETqsFFQXrzd6 K8XTLpkiG1ACl3Sgf5OXf460KSFEp8iZzuquvPjM+fcGvtEvSkrK+4Yweho78g== X-Gm-Gg: AfdE7clS5VXq+BAGVwzuGkwAAdNBLSeaYNRGBOjiF1egqmKdlsLm026nKL15oxohQYa DkmAhX2b3NdDT/cOrzayxAtxEjWk4p8IWWC5PxNha5pgjX8YHl5qsH8136I0cYi16sOiRheLhxB FLtC2h/X1Ukbb/HA5poVEmeO2/FGyde5vV+BqzFjo4NBeWQZE2HVGU66AQABAGAdf5f1FL1gdVG ywprNaKPcrFPJXEs5Xs+V5OAUfr+rIdbWaX5pgBu2xU7yrAOP07woI8jJp+ySUF140PzzIBCBsS AsC4msgTYSnQRfK1VvYPKDGFrEw1UM2CRmeLOZv95zuoRUuKLQpCpAdDEyzgrs9SksHoamwmvHi jKL/VEAIolHJvpqEV204aOAV5a/kUgQtmbIP8qWXa9suWysepw/tZXdcpBry3fY3GGYCAcxadir jyCDSwmmIQp6zDX42G1lAL0MObl3kvgXX1X7xlOkgbT+Ivdpwu58hTVpNQwFi+0gDg2MM= X-Received: by 2002:a5d:5d82:0:b0:473:fe94:9bf1 with SMTP id ffacd0b85a97d-47757f4c487mr8036896f8f.26.1782980843477; Thu, 02 Jul 2026 01:27:23 -0700 (PDT) Message-ID: <16226695-aaf9-47b7-8726-7986837c8a1e@gmail.com> Date: Thu, 2 Jul 2026 10:27:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] time: add "NOW() good" indicator To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Bertrand Marquis , Volodymyr Babchuk References: Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1782980844-B71295D1-EB1BAB7C/10/73395122804 X-purgate-type: spam X-purgate-size: 392 On 6/30/26 4:06 PM, Jan Beulich wrote: > printk_start_of_line() checks for a value of 0 right now. In order to be > able to have NOW() return at least monotonically increasing values, that > needs replacing by an explicit indicator. > > Signed-off-by: Jan Beulich LGTM: Reviewed-by: Oleksii Kurochko Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Jul 02 08:30:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 08:30:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351398.1608575 (Exim 4.92) (envelope-from ) id 1wfCoE-0003Np-TQ; Thu, 02 Jul 2026 08:30:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351398.1608575; Thu, 02 Jul 2026 08:30:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfCoE-0003Ni-Pu; Thu, 02 Jul 2026 08:30:10 +0000 Received: by outflank-mailman (input) for mailman id 1351398; Thu, 02 Jul 2026 08:30:09 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfCoD-0003Nc-Ec for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:30:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfCoC-004z4r-LQ for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:30:08 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46218f-5cb7-0a2a0a5109dd-0a2a45068e4a-12 for ; Thu, 02 Jul 2026 10:30:08 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a462190-08de-0a2a45060019-d155802bd557-3 for ; Thu, 02 Jul 2026 10:30:08 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so10148815e9.1 for ; Thu, 02 Jul 2026 01:30:08 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477ddf0f27bsm6635969f8f.30.2026.07.02.01.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 01:30:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782981008; x=1783585808; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zsk+mA5ccbSsLd2AnIRidezsIDLf8OHFe+UNICemn+8=; b=spjkFmI/R2WN3KlCYU1Kt0+/hSxpAZy2Li90UUfmqYCCJOT6uSCPwLdwmFQ7h5MEI7 NMepQQXud58RfstJovK4I0ON0n8u4/qMm5CzYoE3hL9QQFATV0jUaW2SDEVRjf9zcnV1 SotkskTBl+39pAI53cacQ3FLk6j2JUDQ1VQh3Kr17m9hTgVx7n8ZZXkmES6TzyHRuiQU LkKnfpu0yPi6b7YRChRe4YKytadxHJA8qo6hT39TPx9F4h030RgRUn1+wLMKy8r1WqAi 5zYqPCcNojqxaFT8pDRu4TTLlmGfW6ff25cPas7EbfZ9V29tJvlhXNPzD1yYKhVCM5to Dvkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782981008; x=1783585808; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zsk+mA5ccbSsLd2AnIRidezsIDLf8OHFe+UNICemn+8=; b=MTHkNQgewKUppEmSKVm2h6XtL3SUPdj80NlQiX7qGNZDNb7PAlOr8TkZ3+C9CIQPT6 FekYo0EhIBABUDsEZ+msHzxMTH4uflK7L9yxgCgzyq0+9dG3ryBz2I+yfV7L9R3hHfzr YHqpleLYhG/3jSJz47JQRNcoXVei/Kc2RxgZ9+V9IimET6UaZc12z7+5fvvOlnIfFYrN O9we15PtMuIcrplgxxzda0zbtoRc3nKystTKVUAxJUO/pv3T3fwUixTHOWhXmCzDEKhN ltzF9uY/45zkTPRNm2UKgXO2p6RlGzRZ6cKNe9Z2NUgfGTAoljs3jUrIs6YYmzN+Exn3 jm1w== X-Forwarded-Encrypted: i=1; AFNElJ9WKp/fimabQzdLRcMR8p/tF2fzyMaxrblvP3TUADzV0d8ELfFo/QFu5Q+uPYzxGaO2RumKdKSDalQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YzvgOFoaZB0oQjN/iCDrxPichxV4uu3J0104b48/YcvX0zvnBhd +l4nlezUIVSjkxnFHITCEnOKHWTqLJtR5tpZByCZtBrPUjuoZm6Ehqnw X-Gm-Gg: AfdE7cmdRSRijoIn9tYBoKPzhgM4Z1Ii73P66JPYtHz1ZFGL8p1Qh3Agromq44r/wat yhPvnhs8t+BopoOb20RvMxOQCTe1nIPsjgacIMIgJgtGjsFh2/ETHNMBNDgaezMRU4VASbRFu3N bBpg5MUJxqzaDxSZ+o58KPl7ah0dt5nnpTOqA3L6qRK+OgUzSCQvvfLfDPcpXfkvKYIMog1bEOI /+SxXNXSPJS59GV+mLE1GWIqmUaTngIOrtSGZSz5t8yRXcvhkX2YbYdzpcwBuR+5+XSgqVS/oc9 510SVYvoZVeESGnBZGW+1Ij36JlctvM0GWJ4h8hRCTD3Yev2m67SXt5OQlPpKRqqx0TKu540PRP ogdJyG4kIBgrUA7z5pZIPB/F4Xc7T2l5kxhtCnwsHZ9UPXbrZuFlRhFt+pw6Nb03uOQdPgC/IRJ ChAdnvnf9w1ivOggLXAMUVt0UFD5CSxBLDVqfpW91HS1CjZvcD63VokRmocZyxQtsGY2w= X-Received: by 2002:a05:600c:8590:b0:490:b2c9:e284 with SMTP id 5b1f17b1804b1-493c2ba2397mr59581315e9.30.1782981007928; Thu, 02 Jul 2026 01:30:07 -0700 (PDT) Message-ID: <1562ea63-7f17-4748-9380-94712dd84d1a@gmail.com> Date: Thu, 2 Jul 2026 10:30:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] lib: make safe_copy_string_from_guest() validate input To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Daniel Smith References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> <7e492b98-26d5-4d90-a703-ee25beae7e23@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <7e492b98-26d5-4d90-a703-ee25beae7e23@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1782981008-F8FEA68D-99E61713/10/73395122804 X-purgate-type: spam X-purgate-size: 684 On 6/16/26 11:03 AM, Jan Beulich wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -11,6 +11,8 @@ The format is based on [Keep a Changelog > to obtain an automatically allocated domid. The prior sentinel values (0 > since the start of Xen, and DOMID_INVALID since Xen 4.21) now no longer > represent a wildcard input. > + - XEN_DOMCTL_DEV_DT's, FLASK_[GS]ETBOOL's, and FLASK_DEVICETREE_LABEL's input > + string sizes need to include the nul terminator. The patch isn't tagged as "for 4.22", but the change in `CHANGELOG.md` makes it look like it's intended for the 4.22 release. Do you expect this patch to be included in 4.22? ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Jul 02 08:59:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 08:59:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351419.1608584 (Exim 4.92) (envelope-from ) id 1wfDG1-0007WO-Vb; Thu, 02 Jul 2026 08:58:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351419.1608584; Thu, 02 Jul 2026 08:58:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDG1-0007WH-SC; Thu, 02 Jul 2026 08:58:53 +0000 Received: by outflank-mailman (input) for mailman id 1351419; Thu, 02 Jul 2026 08:58:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDG0-0007W5-Md for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 08:58:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDG0-007AzE-3H; Thu, 02 Jul 2026 10:58:52 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46283c-5cb7-0a2a0a5109dd-0a2a4507c7b2-42 for ; Thu, 02 Jul 2026 10:58:51 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46284a-9c8e-0a2a45070019-5a9b3222e230-3 for ; Thu, 02 Jul 2026 10:58:50 +0200 Received: from [2001:8b0:10b:5:5473:9ff4:cd52:8d75] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfDFl-00000008EEz-0wPh; Thu, 02 Jul 2026 08:58:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XpVLbiwv7CDhPaB21Fa7g5kQELhviQ2VmLDVN0CcLRU=; b=kfpP2bbdJhTWOL+Az4MMKsfd1l 5EZ8i35tCGoVK2w67azj9VHb7EleLcCrZphW5BoSq5nOZ5GwjFBH7VH+VC86om9UCJlhmLT8qn/4U Vljt0coUjjo+rcNWLBEEifJk8LBtxKhKOVUQObUUZVFr+5X+wsz9b1I1rmJgs9k+ahgUp+muT3mIS ucAvDsw2EvAUGshY/7ij85GEvL+V12lOenqe04ZZoJPLRZj9v9zrl4hyrONjES3tPOCnbR/AThg5Q +R4X5j1OgAw3+OIg+qb79/R1sfOhtLstMKQqUuAP1bstNoIs4/EohMbnBNr8kcl+B/P2GcAVmndEF 1r74xXmw==; Message-ID: Subject: Re: [PATCH v5 06/34] KVM: x86: Explicitly disable TSC scaling without CONSTANT_TSC From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Thu, 02 Jul 2026 09:58:36 +0100 In-Reply-To: References: <20260608145455.89187-1-dwmw2@infradead.org> <20260608145455.89187-7-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-9bZhCjMS+rLrf3GCWE0W" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ef75cf/1782982731-7D52025E-D7625B8D/0/0 X-purgate-type: clean X-purgate-size: 8805 --=-9bZhCjMS+rLrf3GCWE0W Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2026-07-01 at 14:38 -0700, Sean Christopherson wrote: >=20 > > =C2=A0=C2=A0 pr_info("TSC scaling supported\n"); > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > > index a29896a9ef14..ed207cc7692d 100644 > > --- a/arch/x86/kvm/vmx/vmx.c > > +++ b/arch/x86/kvm/vmx/vmx.c > > @@ -8672,7 +8672,7 @@ __init int vmx_hardware_setup(void) > > =C2=A0=C2=A0 if (!enable_apicv || !cpu_has_vmx_ipiv()) > > =C2=A0=C2=A0 enable_ipiv =3D false; > > =C2=A0=20 > > - if (cpu_has_vmx_tsc_scaling()) > > + if (cpu_has_vmx_tsc_scaling() && boot_cpu_has(X86_FEATURE_CONSTANT_TS= C)) >=20 > We should clear SECONDARY_EXEC_TSC_SCALING in setup_vmcs_config().=C2=A0 = Failure to > clear the vmcs_config bit will advertise the feature to L2 and allow it t= o be > enabled in vmcs12, but KVM will ultimately not honor the scaling in vmcs0= 2: >=20 > if (kvm_caps.has_tsc_control) > vmcs_write64(TSC_MULTIPLIER, vcpu->arch.tsc_scaling_ratio); >=20 > This series kinda sorta gets there with "KVM: x86: Remove pvclock_gtod_da= ta and > private timekeeping code", but that change looks misplaced?=C2=A0 And I t= hink clearing > the bit this late will lead to false failures in vmx_check_processor_comp= at() due > to the golden config clearing the bit, but the local config having it set= . Ack. Folded into v6: https://git.infradead.org/?p=3Dusers/dwmw2/linux.git;a=3Dshortlog;h=3Drefs/= heads/kvmclock6 https://git.infradead.org/?p=3Dusers/dwmw2/linux.git;a=3Dcommitdiff;h=3D144= 587d50edf --=-9bZhCjMS+rLrf3GCWE0W Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCD9Aw ggSOMIIDdqADAgECAhAOmiw0ECVD4cWj5DqVrT9PMA0GCSqGSIb3DQEBCwUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBDQTAeFw0yNDAxMzAwMDAwMDBaFw0zMTEx MDkyMzU5NTlaMEExCzAJBgNVBAYTAkFVMRAwDgYDVQQKEwdWZXJva2V5MSAwHgYDVQQDExdWZXJv a2V5IFNlY3VyZSBFbWFpbCBHMjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMjvgLKj jfhCFqxYyRiW8g3cNFAvltDbK5AzcOaR7yVzVGadr4YcCVxjKrEJOgi7WEOH8rUgCNB5cTD8N/Et GfZI+LGqSv0YtNa54T9D1AWJy08ZKkWvfGGIXN9UFAPMJ6OLLH/UUEgFa+7KlrEvMUupDFGnnR06 aDJAwtycb8yXtILj+TvfhLFhafxroXrflspavejQkEiHjNjtHnwbZ+o43g0/yxjwnarGI3kgcak7 nnI9/8Lqpq79tLHYwLajotwLiGTB71AGN5xK+tzB+D4eN9lXayrjcszgbOv2ZCgzExQUAIt98mre 8EggKs9mwtEuKAhYBIP/0K6WsoMnQCcCAwEAAaOCAVwwggFYMBIGA1UdEwEB/wQIMAYBAf8CAQAw HQYDVR0OBBYEFIlICOogTndrhuWByNfhjWSEf/xwMB8GA1UdIwQYMBaAFEXroq/0ksuCMS1Ri6en IZ3zbcgPMA4GA1UdDwEB/wQEAwIBhjAdBgNVHSUEFjAUBggrBgEFBQcDBAYIKwYBBQUHAwIweQYI KwYBBQUHAQEEbTBrMCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wQwYIKwYB BQUHMAKGN2h0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRJRFJvb3RD QS5jcnQwRQYDVR0fBD4wPDA6oDigNoY0aHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0 QXNzdXJlZElEUm9vdENBLmNybDARBgNVHSAECjAIMAYGBFUdIAAwDQYJKoZIhvcNAQELBQADggEB ACiagCqvNVxOfSd0uYfJMiZsOEBXAKIR/kpqRp2YCfrP4Tz7fJogYN4fxNAw7iy/bPZcvpVCfe/H /CCcp3alXL0I8M/rnEnRlv8ItY4MEF+2T/MkdXI3u1vHy3ua8SxBM8eT9LBQokHZxGUX51cE0kwa uEOZ+PonVIOnMjuLp29kcNOVnzf8DGKiek+cT51FvGRjV6LbaxXOm2P47/aiaXrDD5O0RF5SiPo6 xD1/ClkCETyyEAE5LRJlXtx288R598koyFcwCSXijeVcRvBB1cNOLEbg7RMSw1AGq14fNe2cH1HG W7xyduY/ydQt6gv5r21mDOQ5SaZSWC/ZRfLDuEYwggWbMIIEg6ADAgECAhAH5JEPagNRXYDiRPdl c1vgMA0GCSqGSIb3DQEBCwUAMEExCzAJBgNVBAYTAkFVMRAwDgYDVQQKEwdWZXJva2V5MSAwHgYD VQQDExdWZXJva2V5IFNlY3VyZSBFbWFpbCBHMjAeFw0yNDEyMzAwMDAwMDBaFw0yODAxMDQyMzU5 NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqGSIb3DQEBAQUAA4IC DwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZeYAS/SRV6zmfXlXaZ sNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2zkC9S7/yHDYnqegqt w4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qGpgFdZEk2/c//ZvUN i12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41vav1RhZJzYan4a1gU0 kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0cvnO8FM6PTqsnSbcc 0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PWPU6zfQTOMZ9uLQRR ci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXtREF5lLXxp+CJ6KKS blPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQrlR0gO3lBzuyPPArV hvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7IqaAovAX0d+f1YjbmC VsAwjhLmveFjNwIDAQABo4IBsDCCAawwHwYDVR0jBBgwFoAUiUgI6iBOd2uG5YHI1+GNZIR//HAw HQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3bXcyQGluZnJhZGVh ZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEBMA4GA1UdDwEB/wQE AwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwewYDVR0fBHQwcjA3oDWgM4YxaHR0 cDovL2NybDMuZGlnaWNlcnQuY29tL1Zlcm9rZXlTZWN1cmVFbWFpbEcyLmNybDA3oDWgM4YxaHR0 cDovL2NybDQuZGlnaWNlcnQuY29tL1Zlcm9rZXlTZWN1cmVFbWFpbEcyLmNybDB2BggrBgEFBQcB AQRqMGgwJAYIKwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmRpZ2ljZXJ0LmNvbTBABggrBgEFBQcwAoY0 aHR0cDovL2NhY2VydHMuZGlnaWNlcnQuY29tL1Zlcm9rZXlTZWN1cmVFbWFpbEcyLmNydDANBgkq hkiG9w0BAQsFAAOCAQEAQXc4FPiPLRnTDvmOABEzkIumojfZAe5SlnuQoeFUfi+LsWCKiB8Uextv iBAvboKhLuN6eG/NC6WOzOCppn4mkQxRkOdLNThwMHW0d19jrZFEKtEG/epZ/hw/DdScTuZ2m7im 8ppItAT6GXD3aPhXkXnJpC/zTs85uNSQR64cEcBFjjoQDuSsTeJ5DAWf8EMyhMuD8pcbqx5kRvyt JPsWBQzv1Dsdv2LDPLNd/JUKhHSgr7nbUr4+aAP2PHTXGcEBh8lTeYea9p4d5k969pe0OHYMV5aL xERqTagmSetuIwolkAuBCzA9vulg8Y49Nz2zrpUGfKGOD0FMqenYxdJHgDCCBZswggSDoAMCAQIC EAfkkQ9qA1FdgOJE92VzW+AwDQYJKoZIhvcNAQELBQAwQTELMAkGA1UEBhMCQVUxEDAOBgNVBAoT B1Zlcm9rZXkxIDAeBgNVBAMTF1Zlcm9rZXkgU2VjdXJlIEVtYWlsIEcyMB4XDTI0MTIzMDAwMDAw MFoXDTI4MDEwNDIzNTk1OVowHjEcMBoGA1UEAwwTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJ KoZIhvcNAQEBBQADggIPADCCAgoCggIBANqWLse95HW2F7FhfH9bugyT/danKmmXrbMnz5GZNAfj Jl5gBL9JFXrOZ9eVdpmw04Tp6aDxZctFLoEDvSWKi367Q7Sg+ci+fH4KwwfQ8Pi0IpIKx2n5emEg nbOQL1Lv/IcNiep6Cq3DiyaSpSp/RZf+CAfUNySHS8eWmhLU6jGpSD6hxTpYKye7PmrmvMWwfGEP WoamAV1kSTb9z/9m9Q2LXa89aKmTxNwnAfD3Ohn9mtU3JukwILRMewn9QRXK7KzM+01h5hkCE4nj W9q/VGFknNhqfhrWBTSQoE9CSVylASGrjzCgS7XmKy/BaH3/7mOOHQv5g1o3Qj/+cdKnpT0I5Qb1 nRy+c7wUzo9OqydJtxzSP4ZyHA4dELto/a3m/ay1XHcpum1pgTOLgxAfGb/T4dCkwRUstSKLMmpL g9Y9TrN9BM4xn24tBFFyL5znGG0wQGzOVAM68RBzIQb6Fz758fjsr4yZnPbVsU1+gHEs/puNHrG0 9e1EQXmUtfGn4InoopJuU8p5VGD9S3Ikd4UoBlc7xl5yjtNlQxUeYrRlnUSmdlucCEoTX1n4UmtA 9CuVHSA7eUHO7I88CtWG9bGOU7tLgOZoSEvNqtaL/N7sQbBZK4jZ4Rr/zNTQg1SwYjjLB7u96lDP sipoCi8BfR35/ViNuYJWwDCOEua94WM3AgMBAAGjggGwMIIBrDAfBgNVHSMEGDAWgBSJSAjqIE53 a4blgcjX4Y1khH/8cDAdBgNVHQ4EFgQUXGIam3Bs59Y60yTmWgfDu6pZQ6cwMAYDVR0RBCkwJ4ET ZHdtdzJAaW5mcmFkZWFkLm9yZ4EQZGF2aWRAd29vZGhvdS5zZTAUBgNVHSAEDTALMAkGB2eBDAEF AQEwDgYDVR0PAQH/BAQDAgXgMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEFBQcDBDB7BgNVHR8E dDByMDegNaAzhjFodHRwOi8vY3JsMy5kaWdpY2VydC5jb20vVmVyb2tleVNlY3VyZUVtYWlsRzIu Y3JsMDegNaAzhjFodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vVmVyb2tleVNlY3VyZUVtYWlsRzIu Y3JsMHYGCCsGAQUFBwEBBGowaDAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29t MEAGCCsGAQUFBzAChjRodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vVmVyb2tleVNlY3VyZUVt YWlsRzIuY3J0MA0GCSqGSIb3DQEBCwUAA4IBAQBBdzgU+I8tGdMO+Y4AETOQi6aiN9kB7lKWe5Ch 4VR+L4uxYIqIHxR7G2+IEC9ugqEu43p4b80LpY7M4KmmfiaRDFGQ50s1OHAwdbR3X2OtkUQq0Qb9 6ln+HD8N1JxO5nabuKbymki0BPoZcPdo+FeRecmkL/NOzzm41JBHrhwRwEWOOhAO5KxN4nkMBZ/w QzKEy4PylxurHmRG/K0k+xYFDO/UOx2/YsM8s138lQqEdKCvudtSvj5oA/Y8dNcZwQGHyVN5h5r2 nh3mT3r2l7Q4dgxXlovERGpNqCZJ624jCiWQC4ELMD2+6WDxjj03PbOulQZ8oY4PQUyp6djF0keA MYIDuzCCA7cCAQEwVTBBMQswCQYDVQQGEwJBVTEQMA4GA1UEChMHVmVyb2tleTEgMB4GA1UEAxMX VmVyb2tleSBTZWN1cmUgRW1haWwgRzICEAfkkQ9qA1FdgOJE92VzW+AwDQYJYIZIAWUDBAIBBQCg ggE3MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTI2MDcwMjA4NTgz NlowLwYJKoZIhvcNAQkEMSIEIDksKJ3Ty3+zHNZT2D0jeM4TnA7nWmY35paDXpfxVFYyMGQGCSsG AQQBgjcQBDFXMFUwQTELMAkGA1UEBhMCQVUxEDAOBgNVBAoTB1Zlcm9rZXkxIDAeBgNVBAMTF1Zl cm9rZXkgU2VjdXJlIEVtYWlsIEcyAhAH5JEPagNRXYDiRPdlc1vgMGYGCyqGSIb3DQEJEAILMVeg VTBBMQswCQYDVQQGEwJBVTEQMA4GA1UEChMHVmVyb2tleTEgMB4GA1UEAxMXVmVyb2tleSBTZWN1 cmUgRW1haWwgRzICEAfkkQ9qA1FdgOJE92VzW+AwDQYJKoZIhvcNAQEBBQAEggIAI4R/W4erdYAu 8Z1G+6P7ejl1YmFVIMtfhjKXjUEm11rpy8bQBq6TlpSDYB8cGB1wgJC/oE4rUYC5YquCWvP9kCGG 4iSYWAwO5fJjB70ZVnc44vy75/5uOQ6vlrsPw3igyeYCvxJtEios0yJ/hJq8RvJnf8/u1vw042Rg tF+/Hgf8c10li3e96Svnqg+G3TJ0FUOIfcmtYb3nHCdh3J0qop2RY33t0Fzq6eiErjcndFQ3k8Cs lFV5lLlJ62NDooVFdRp32iACesTzHMFmQNo+mS/dxg+QunWhir8P95KZm9N3eGjO3iNNQW/WRH2W v9bYfFncoQtLB8GmyLyi1D1L7WR0gXVzKYR8dAiPNSWfOV9xfYrHMDO+wnpLp6Xf+NEsh/kwJfx9 bxUKCWMaKE9HlwN8liINOu3Vwnfbr4e7QzwZnVpEqPGqdLuKLPm94siRefRo9WP9Ct6+dwMGEmcA 4av1qcHv3Dk8Z69dcxtIW2+kCP5hIKBY3c7DKJJwRFAPq8brexPggv6a+zeD3Gtj2INaWPgf3PJo 7LaGF0bbc473/IqA6W7HIoF4/yrjYIX6GPXTv4GZjeOMXuxJiGgrGHIhDgi9WSfo7Vg6jvuxLy4Y eVMZll4vLUxJMmij0k0umLmoIQeHGsfU59WippejbdtkTIBfEToYRBuSFccA7AIAAAAAAAA= --=-9bZhCjMS+rLrf3GCWE0W-- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:25:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:25:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351444.1608608 (Exim 4.92) (envelope-from ) id 1wfDfp-0004Zj-6O; Thu, 02 Jul 2026 09:25:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351444.1608608; Thu, 02 Jul 2026 09:25:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDfp-0004Zc-3e; Thu, 02 Jul 2026 09:25:33 +0000 Received: by outflank-mailman (input) for mailman id 1351444; Thu, 02 Jul 2026 09:25:32 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDfo-0004ZW-0r for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:25:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDfn-00Dwwg-9x for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:25:31 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a462e71-e002-0a2a0a5209dd-0a2a4509d3f0-30 for ; Thu, 02 Jul 2026 11:25:31 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a462e8a-97e6-0a2a45090019-d155dd31d107-3 for ; Thu, 02 Jul 2026 11:25:31 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-471eeac43bfso1282634f8f.3 for ; Thu, 02 Jul 2026 02:25:31 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477dd94cde8sm7871441f8f.22.2026.07.02.02.25.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:25:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Content-Language:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782984330; x=1783589130; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DiRjE3SzKDTgBcvOhNeMqXfYe3N5EKCN8Jmz5cizP8U=; b=GV9xGVoinGBIHZ0Bhec0Xe8R8UGZxgViuIcjrA/rVVvdWa0DYA4SziSTztUHKiNaZI xJGrhgRZuQm0tymLFEkZKG/NDsuq87KxyTR+w+SZzW52GMnduoozdELVIaCa8Ozhc9Fp DEM11nazUrw2ljPX9uKRp8GizXJNzPLVc/l5e1d9uAWAw+AeROHw4mB5aN8rFxA0z8Mn 4MOSIzqcG7R30G/opMMifXfxWc3jheYKT3/eV4Qk6AEQTrEm3F41fylECv5T8x3maXaH 3GB0vozEey5CNs6tUIAUZgyIRhVQjTZ73wc9/xU0aYZnKNlOdkaK3/nQe3HTYcwVmbu4 6xBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984330; x=1783589130; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DiRjE3SzKDTgBcvOhNeMqXfYe3N5EKCN8Jmz5cizP8U=; b=HN575kV94hO97QqCHRT+gGi4+yM/1+ltyyuYw3Z7EUcuOTrTxWol5rKNNLkVZdAo6n MQhBTVbYU4v4gnkIWAPji8M6q3Qc6bcrZK1uA0JXLQyaxnryB3rxE2Ocqb5OduIscCXC 8ZK5/GOxz2gWVEVKha+3ZeTQJSrH2lFEuDyMFQYFcsUFo+KnuAoPE4D7JYTlxwrbRIqh XqnopPs+Xj9XTVXiWi5RvyPe8jX52FiiURIXqeQa2vdY/zXPPNu8A8s3xyIlCgRdgxh5 z4JqPyQSML4fWp7etz6o9G/HasX5K843JD4EzG9xuT50A49DJjwL1+Iq9XznVih24Nil gsIw== X-Gm-Message-State: AOJu0YxkSpr0cTVRYSwbV9Cnx6SlmIBnNQJy7MNTSchXkpyKAQua3hsX W+BcqAjmORYQNXv5gRCLGxUdGOSIagjAGUoMxkZW2R4u747CyhUTabcAkwczkU42jfKx4QldAj5 wpSl+4w== X-Gm-Gg: AfdE7cnuRdNMw0ZHXTrt4QO34KdJDQr6xwj4NoLsHNXdh1+Xow0xKaDCg97xB7OZPSG uVGSnLsrNOphXgICAYzIvmSejbpthdfC6qSjgcvbDKiwLKUIoN6kz7eR7WgG+o7yMN2VYeU8Vyq 9wjqmNHlMyMefg3Qn/JqlZZ9S2ZXMZm6fhFH6+UBVFrp+lPRYpSSYELWd1eD81NOfpMt0FqJug9 13jhA/Z3Vy4TcAFw/DourMWej1YrArsEP5ixHQKmams9jtEn/EPllYs1l6JafgFIzJ6Ml8xcCdR 9YtRsws1e1T4jZCOm/eP0nOzUAJNl8t5EVY7MX828qbjo3i4ArRPEtZ9o2G9yZfuaxzzXm90p8x WGE1WYruj81TaxVPw85X+ENjmd5wOoqCjddqYeHldwYgw65x8JGXL3hQ/tLqyYpuF2KXiSwQQcD HpPIB187MoAjflPewBOMewrGk7ZvFw7NXilrn3GNZBgAaoyDqsPioOTdj1MBmlXtSwU2K2KQ2Xo QHD X-Received: by 2002:adf:ecd0:0:b0:475:cff8:b465 with SMTP id ffacd0b85a97d-47758511955mr6667203f8f.18.1782984330614; Thu, 02 Jul 2026 02:25:30 -0700 (PDT) Message-ID: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Date: Thu, 2 Jul 2026 11:25:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v2 0/4] x86/time: CMOS RTC century byte To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1782984331-47530986-445D5707/0/0 X-purgate-type: clean X-purgate-size: 389 While meanwhile we at least consume this ourselves, I'm still surprised that we got away with also not emulating it for HVM guests. There's now some other (more or less related) cleanup here as well. 1: x86/time: CMOS RTC may run in binary mode 2: time: shorten year determination loop 3: x86/vRTC: the use_timer field is a boolean one 4: x86/vRTC: support century field Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:27:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:27:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351453.1608618 (Exim 4.92) (envelope-from ) id 1wfDhh-00059y-H3; Thu, 02 Jul 2026 09:27:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351453.1608618; Thu, 02 Jul 2026 09:27:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDhh-00059r-Dl; Thu, 02 Jul 2026 09:27:29 +0000 Received: by outflank-mailman (input) for mailman id 1351453; Thu, 02 Jul 2026 09:27:27 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDhf-00059h-Sl for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:27:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDhf-00DxRL-9L for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:27:27 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a462ef6-bab6-0a2a0a5309dd-0a2a4508d830-26 for ; Thu, 02 Jul 2026 11:27:27 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a462efe-edec-0a2a45080019-d155dd2acda5-3 for ; Thu, 02 Jul 2026 11:27:27 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-473ba028d46so1579709f8f.1 for ; Thu, 02 Jul 2026 02:27:27 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477ddf0f27bsm7055977f8f.30.2026.07.02.02.27.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:27:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782984446; x=1783589246; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=8ChJZT2uxOwOpgq3GZb2mrsTu1483VVYtw+84CX3LBQ=; b=RwdQA7fAR0pIVNk+UMxzDMhejuwDuhy87ydwhF1V24AI9+BG6drBT/DItalCMGRlLw D+pIkTiBgVXdi7bDzzoE7eiSAElqSzUcOa8eb6f9GV03ONxoA4UYp4vOt0eIPlhGfHGp KeRqETDSoxm/VtVyI6mNk/sNjUJhFWQsTgQY0kGugi+i6u62Ihu6N6Qiv5xeqTa0NT4Z m/R1WYNuZu/ss9DM5VxJbKryQoXOFWjXQJ4fe9pFyKtym3FCgRls10d66uV8Ygh+ntoC Z0kLT+CGkwkhNMbYOpwq+/eqOpweXcCWIpTL7K6oZyywxlsoMcwkejVx6UKRLq4Xi7EI upJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984446; x=1783589246; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8ChJZT2uxOwOpgq3GZb2mrsTu1483VVYtw+84CX3LBQ=; b=kur0lQ4BT390C7SfaklHIbu4QhFqvYshk4Cui3yYLROHEM3R99SUVnwchobpS3srwd B8EIc/qqL7lKrp6XkYTwKS2aY3P5dPk9hCI8hdMiHxUKxUmFgLEdoQmNZqIB3B0usg0H 45bCn7vQUHAZSbBVs/J/NJAU6aC1632KdLByi3bQnQTS12bi9cdI+kAzE57Mw97uu1bt OXX/PFIRQcHceK+ROYLBoXdzFGbl0vAq/a5lwouI5e8Uh2GV28MJLLHzu792Lvb3BbyS cp9eujJDWfOMlYdzIZ8QavC3hDRcx9S4+m4x3mVlfCZ/vHF7gAjlKx4lxHicCu0+Rdnx spFg== X-Forwarded-Encrypted: i=1; AHgh+RpDhdT7KAp+LrPq8Rp+upRSIxfJKmnEeVP6Fy/rGpZ8V8XiYx/cxQUDwKP0uoRhu0Kciz8HXeKajEI=@lists.xenproject.org X-Gm-Message-State: AOJu0YwU3DslXFGuXvZRGOTY/w1rtjyxQJsXBMbNq/oiVEifmQoKmWoT FE8U9cJ2ZdAlAMTmXsUaw4giCQ8mXchSHUtfvWaDsLFMphKf4xWodxB8n3MB2GEM6A== X-Gm-Gg: AfdE7clc0zh9EunVQ+MvMmwNw4yTA47guwFG1sSZLXUZD3nciYUAH68PmGkJBvglFXO iJZuBVq1wSFTuyAyrQVnyP7DAmOT+ABbnSwzrSjPViyzqSzyuxKkSk2rDJ108trhLPUOCuOjKW0 vU7cTdJWmn33GFW/qm7uO2WIYdroszdrt+mm+/N/QN5oOjUuBd8KE3a7LKlRqRR5RUNOcD7XZei owwKX51ycCgyND3CuuELGY5dwE1a99GQE6H1gF28fDCgidcvVmCniOC4Ahp3ohlqhS5b9P8yA9i 1r74tFThlppmGB8IW/+URGaZTPsEtGXBQgJodmjPYh/VM6pA+8mdal85osioKTk1HCcrL2srkQA q+sPlIeqQAxt4L+PRYg7tWe67CzTZqCaIlk6wwJzkzyW4uD9jxllPmhhFo6XnLzTRd5QfnfNm3D aM6L+MtCQKVKXHIonnph5sjp8qktFQ1OrLiAeyxrzhu7vcAUuF8FZGl+VmhI32Aox4d1qlVG73i Jjp X-Received: by 2002:a05:6000:2589:b0:475:f0c2:75ab with SMTP id ffacd0b85a97d-4775b176e29mr7562020f8f.60.1782984446607; Thu, 02 Jul 2026 02:27:26 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 11:27:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] lib: make safe_copy_string_from_guest() validate input To: Oleksii Kurochko Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Daniel Smith , "xen-devel@lists.xenproject.org" References: <5d242cad-d907-4321-8ac1-363c0f9b623d@suse.com> <7e492b98-26d5-4d90-a703-ee25beae7e23@suse.com> <1562ea63-7f17-4748-9380-94712dd84d1a@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1562ea63-7f17-4748-9380-94712dd84d1a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c1860d/1782984447-A11293FC-CAA0749F/0/0 X-purgate-type: clean X-purgate-size: 816 On 02.07.2026 10:30, Oleksii Kurochko wrote: > On 6/16/26 11:03 AM, Jan Beulich wrote: >> --- a/CHANGELOG.md >> +++ b/CHANGELOG.md >> @@ -11,6 +11,8 @@ The format is based on [Keep a Changelog >> to obtain an automatically allocated domid. The prior sentinel values (0 >> since the start of Xen, and DOMID_INVALID since Xen 4.21) now no longer >> represent a wildcard input. >> + - XEN_DOMCTL_DEV_DT's, FLASK_[GS]ETBOOL's, and FLASK_DEVICETREE_LABEL's input >> + string sizes need to include the nul terminator. > > The patch isn't tagged as "for 4.22", but the change in `CHANGELOG.md` > makes it look like it's intended for the 4.22 release. > > Do you expect this patch to be included in 4.22? Not anymore. See also the v2 re-posting (where I'd appreciate your ack). Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:29:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:29:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351462.1608627 (Exim 4.92) (envelope-from ) id 1wfDjO-00066v-Pu; Thu, 02 Jul 2026 09:29:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351462.1608627; Thu, 02 Jul 2026 09:29:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDjO-00066o-NA; Thu, 02 Jul 2026 09:29:14 +0000 Received: by outflank-mailman (input) for mailman id 1351462; Thu, 02 Jul 2026 09:29:14 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDjN-00066b-Uv for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:29:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDjM-005BD9-KF for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:29:12 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a462f63-e002-0a2a0a5209dd-0a2a4506c242-26 for ; Thu, 02 Jul 2026 11:29:12 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a462f68-08de-0a2a45060019-d155802dad8f-3 for ; Thu, 02 Jul 2026 11:29:12 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso8765275e9.1 for ; Thu, 02 Jul 2026 02:29:12 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c635c41dsm63880115e9.5.2026.07.02.02.29.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:29:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782984552; x=1783589352; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=rNeLuZWOoZ4GW+Y/apOrOAS/S2cqMXKJ1Ia6qOHbnNw=; b=dPTCulflmz29SUvLuAyoL9rb09+33MWaPtqhhbTXGygS2qWs+D8SssEKau4kxE2Weh 82y1NM01KcSlYbeDpX6LI98rR8Vpbo79sjvP2bOcl8Subd5vDtcMB5VNjBFZMsHsx4Qt meIT2xSEAzQmvKcBrtZA25+DvU/7mWYOQo65RDza3x5YR8MhHfKLxtBteZaFGbfRhfkF EUxzDbllchRTUNu5cSszAcJpMidkgsdAgC5RnDu0v1Z0aJvkVtCuAKW1/gBh+7/rp9ad vEUMmMdL29/LS3y2AqX72VAH2W/A5sR8BdCAOUj4Ghmb/dw0H8c6qh8ubDGKCc0jUy/a bnNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984552; x=1783589352; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rNeLuZWOoZ4GW+Y/apOrOAS/S2cqMXKJ1Ia6qOHbnNw=; b=Hzxw6qIVm5bGnoCod8G1LQ9heHJ07qnBwr1XZPffN8VSSvve2aqvj8XqQcWq+9tTDu 30AN4kejaYoM2y1wwfGxM7d0E/ljMMxZOkF/yNaLxS0cSfXaV6SNTaGYdsmfnPJNiGDa p5rSJeTJxerS7cnwGPQZq4+iedeCOLtPUapwCJdHOhdnb3u2/TjRQeWRRDtzhvbL8oNx BV1cIqRToUOv3kFk/BfUj1su1d5r5S2NQTelJfVmCKW9M/t74rcmW6ON3+6bnCQU8X/n V+6QZwk8OVmfd2ahDsMg8mcuKZ+r/GNdJQsN2vU9u1566PGnn3yRHqCa1jZfJMPl3KQE PkXw== X-Gm-Message-State: AOJu0Yx4aqNsnHYTWXPLLvxxh3N6w0iqVXtraJG0Bf1GbxcZMdwTo9PA IFPVI5255M//FK8UncNlyVQXqlwrskblrkcFy4WVN3c/NteQfHh7NO/BuIoXEvIUv/N2ogTFvjE 0IrIv2w== X-Gm-Gg: AfdE7cmzOvkoYMCifM3PsjrPV16GXdQWSmab6gywP4hFOzWy15uRcwDm/KFfGJRXQaY WNFVSj55V5lO5WUExrCxL0XUuzjebZuJYezMfvH2krJW5k+aYD6Hp2+YV6XQVDiH9Y899noFB/C 0rjkaEx72iDIJzHyxFkzjQI9SS3+d4F+Bn6p+hbpF/jvsd8w0KMpMYGHH3XVySMkwr+ZrZamZ/+ lOEKHXMBJHSnBlgrgdlWIhLTyLn9+DOgiBreHK16QW03dviyCJqYNwTiL0yx52ZObEcXlntjtTd jh4p2C2ZvWn+UyEzbMqIjpQU0QHqITdCDJ/ySu9A8hT4XgX0C5FYT2wr7SLlAbnysvHyr/iTAp9 OPE8nufsIAL598tt1ZoFWFVW0bSpq3y2l7Aa/ceSHM9KTxS+gfQ34+rBYj2+b1xFcFfS4NcpW47 wYMcftefALdTBUzZZZxZtZf1PqYSxUSeMzpPRICWJHTeRE/A9iancQ49+krzosTgEJ7Q/fkW7Sw P/DBMpjsoPW7CY= X-Received: by 2002:a05:600c:1f84:b0:492:63c3:8eeb with SMTP id 5b1f17b1804b1-493c2ba53e4mr72531165e9.35.1782984551966; Thu, 02 Jul 2026 02:29:11 -0700 (PDT) Message-ID: <5945d8f4-aece-4572-8e89-60408dd7ac32@suse.com> Date: Thu, 2 Jul 2026 11:29:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/4] x86/time: CMOS RTC may run in binary mode From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie References: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1782984552-C453168D-9984B018/0/0 X-purgate-type: clean X-purgate-size: 3621 Indicating it would always use BCD mode is just wrong (and then the comment there said the opposite). All halfway recent (and really all 64- bit capable) systems having a CMOS RTC should properly indicate the mode in control register B. Make use of the flag, but provide a fallback mechanism in case people run into systems not matching the above assumption. Additionally, when binary mode is indicated and when "cmos-rtc-probe" is in use (but "cmos-rtc-bcd" isn't), probe whether the clock really runs in binary mode. (This probing, sadly, can take up to 10 seconds.) Signed-off-by: Jan Beulich --- v2: New. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -339,6 +339,14 @@ parameter to "stable:socket". Specify the event count threshold for raising Corrected Machine Check Interrupts. Specifying zero disables CMCI handling. +### cmos-rtc-bcd (x86) +> `= ` + +> Default: `false` + +Flag to indicate the CMOS Real Time Clock uses BCD mode irrespective of +control register B indicating binary mode. + ### cmos-rtc-probe (x86) > `= ` --- a/xen/arch/x86/include/asm/mc146818rtc.h +++ b/xen/arch/x86/include/asm/mc146818rtc.h @@ -96,7 +96,6 @@ bool is_cmos_port(unsigned int port, uns #ifndef RTC_PORT #define RTC_PORT(x) (0x70 + (x)) -#define RTC_ALWAYS_BCD 1 /* RTC operates in binary mode */ #endif /* --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -1250,6 +1250,9 @@ mktime (unsigned int year, unsigned int )*60 + sec; /* finally seconds */ } +static bool __ro_after_init opt_cmos_rtc_bcd; +boolean_param("cmos-rtc-bcd", opt_cmos_rtc_bcd); + struct rtc_time { unsigned int year, mon, day, hour, min, sec; }; @@ -1285,7 +1288,7 @@ static bool __get_cmos_time(struct rtc_t if ( acpi_gbl_FADT.century && acpi_gbl_FADT.century < 0x80 ) century = CMOS_READ(acpi_gbl_FADT.century); - bcd = RTC_ALWAYS_BCD || !(CMOS_READ(RTC_CONTROL) & RTC_DM_BINARY); + bcd = opt_cmos_rtc_bcd || !(CMOS_READ(RTC_CONTROL) & RTC_DM_BINARY); spin_unlock_irqrestore(&rtc_lock, flags); @@ -1353,6 +1356,48 @@ static bool __init cmos_rtc_probe(void) return false; } +static inline bool __init attr_const is_bcd(unsigned int x) +{ + return (x & 0xf) < 10 && (x >> 4) < 10; +} + +static void __init cmos_rtc_probe_bcd(void) +{ + bool bcd; + unsigned long flags; + + if ( opt_cmos_rtc_bcd ) + return; + + spin_lock_irqsave(&rtc_lock, flags); + bcd = !(CMOS_READ(RTC_CONTROL) & RTC_DM_BINARY); + spin_unlock_irqrestore(&rtc_lock, flags); + + if ( bcd ) + return; + + for ( unsigned int seclo = 0; ; ) + { + struct rtc_time rtc; + + if ( !__get_cmos_time(&rtc) || + !is_bcd(rtc.sec) || + !is_bcd(rtc.min) || + !is_bcd(rtc.hour) || + !is_bcd(rtc.day) || + !is_bcd(rtc.mon) ) + return; + + if ( seclo > (rtc.sec & 0xf) ) + break; + + seclo = rtc.sec & 0xf; + } + + printk(XENLOG_WARNING "CMOS RTC indicates binary mode but uses BCD\n"); + + opt_cmos_rtc_bcd = true; +} static unsigned long cmos_rtc_read(void) { @@ -1614,6 +1659,10 @@ static void __init probe_wallclock(void) if ( cmos_rtc_probe() ) { wallclock_source = WALLCLOCK_CMOS; + + if ( opt_cmos_rtc_probe ) + cmos_rtc_probe_bcd(); + return; } if ( efi_enabled(EFI_RS) && efi_get_time() ) From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:30:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:30:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351469.1608637 (Exim 4.92) (envelope-from ) id 1wfDkP-0007aY-4P; Thu, 02 Jul 2026 09:30:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351469.1608637; Thu, 02 Jul 2026 09:30:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDkP-0007aN-0I; Thu, 02 Jul 2026 09:30:17 +0000 Received: by outflank-mailman (input) for mailman id 1351469; Thu, 02 Jul 2026 09:30:16 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDkO-0007aE-Ed for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:30:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDkN-005BnN-R1 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:30:15 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a462fa0-bab6-0a2a0a5309dd-0a2a4504a8e6-34 for ; Thu, 02 Jul 2026 11:30:12 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a462fa4-a01d-0a2a45040019-d155802be9da-3 for ; Thu, 02 Jul 2026 11:30:12 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493c5220cb7so6126625e9.3 for ; Thu, 02 Jul 2026 02:30:12 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477ddf0fb15sm6408144f8f.29.2026.07.02.02.30.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:30:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782984612; x=1783589412; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=jsZGfw5l+d7+WFu2XU7K4eUza6w7rx46SRYGAdrvpLc=; b=RToPEnpl+ShX+B34QkEWrW7wgJk3lnxFeiB6C/7RLRpgjo+hzITy+QrVKv2anq+ut0 kIdX6f9zk5vzoqBXRLPOvCSo3U1WPjUarTAlah6V1EI5JiHGEFmewFzMO0ddl/a/3TtC E3vXmB2k8nF695Gey3/KkdP8PvoK6NF/eIKivq7iTZFZAB8n41x3l2+Gx8lAMlh7MAvZ iXpJD1RS7TpI++Weh4Unb/Yx79nIz8KjP1HpuKCX29V9MDYN6QtbmAynJcIhbp5GVIH3 tTW/OeH8KmOE2m4j26yzZAv6ElB840ql3lVfzqoIKCa8GJZzPAqjRjKi3+nPjN+ZRllu Evhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984612; x=1783589412; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jsZGfw5l+d7+WFu2XU7K4eUza6w7rx46SRYGAdrvpLc=; b=TWrocYTEor473Qd9cwemBwbKpKesE3b4rCRTXT5dbs1V8clPslAGcbezDxOnMAea0A 3kl5djXHb8WxiVUu0ql5AP2+B0+USRwhejJVdfiTfs7Jouu9/JpteGwGU8XJCHCWxI1y mbnmdJJLfQ2NXKllAPrX4P8YFEgiJ6FeA5q+VT4fyb4Xi9Ad7nsae40LevkGVnYzh1To r8ekhkI8oVDdsO4BTCIGbrfje/bTVd1X4GDjAiKQno+wDI4EgOqwMCHyYkYDud45p9UF dajQD3WY2eMZu3AO0KBt88Qy7E1Ffaqlsvv/i9YMW25TH0ZaLq9NJnXA2cooWPWLoQM0 nGFQ== X-Gm-Message-State: AOJu0YzI3lfy4fuDrvXLKW86EBvFcZJlElamP0QUVRX1MtK9oC78Vqaf l2FDGtK/N6+xPFaeEB/iKIuP7/abbn3ZGRQu0FnMm7oJaHf/ASs/n4E67Vy8TCrbdbn0OOnep95 9EqU1jQ== X-Gm-Gg: AfdE7cl/UNXC2UXQ/FphH52xBVCWDKZhP4F2kgvb/W34dtE/PR2BI1Kdas0PfYZDTNF tnK9unBZHyIDFqSFtr5dmQPmkJQFFBqlO98gxVoxDDPx9LCgSAPG/F8+NWGsAOIih7k+jL4swG/ ogg1yB2BaTk12Qi0aqDyruh2m5SMP2snNd0jQRTp+UtZikhAI8dluGMqlHivfILqFys2Oxdj3Kc nzDoIuEJhVL2ytCCkNwDTo5df8UkSY4EI1LQB3xDLpI7SJY9nwicuFrQL7/VzoUBqD3OhGg8Q8G 32ycbMb8gXJ+VbYOioF76n4+Bo4Yf4cC529AQAm8byzc05fEEUII5HRq3q1M1TSjESQW55XQqoe ImhxPDZGut5zYi2jtVHBcufjcjWJXZLGbZenVMMVfdhpG+kQLI12iqScsvL/LXowHraYvQnxhG8 1nPGKHKpN9B9ZZPM5zte+TzPd89VOcHUWphAwJqU11XTEHwvhIR/0wSWe+q3af3lUqTS3uj0+5W 4iTS6VxKQr+yZI= X-Received: by 2002:a05:600d:15a:10b0:493:b92d:9166 with SMTP id 5b1f17b1804b1-493c3cdb264mr46373155e9.12.1782984611990; Thu, 02 Jul 2026 02:30:11 -0700 (PDT) Message-ID: <7bed7164-9a53-4e53-9fc1-7af68108bdf8@suse.com> Date: Thu, 2 Jul 2026 11:30:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/4] time: shorten year determination loop From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1782984612-AE3371CC-6FE7A245/0/0 X-purgate-type: clean X-purgate-size: 1420 For dates very far into the future (the MC146818 RTC's century byte can go up to the 99th century), the present year-wise loop would become somewhat inefficient (taking perhaps several thousand iterations). Prefix that loop with a 400-year granular calculation (somewhat like the earlier loop does for dates in the past). Signed-off-by: Jan Beulich --- v2: New. --- a/xen/common/time.c +++ b/xen/common/time.c @@ -27,6 +27,8 @@ #define __isleap(year) \ ((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0)) +#define DAYS_IN_400_YEARS (365 * 303 + 366 * 97) + /* How many days are in each month. */ static const unsigned short int __mon_lengths[2][12] = { /* Normal years. */ @@ -57,7 +59,7 @@ struct tm gmtime(unsigned long t) while ( t & (1UL<<39) ) { y -= 400; - t += ((unsigned long)(365 * 303 + 366 * 97)) * SECS_PER_DAY; + t += (unsigned long)DAYS_IN_400_YEARS * SECS_PER_DAY; } t &= (1UL << 40) - 1; #endif @@ -71,6 +73,11 @@ struct tm gmtime(unsigned long t) tbuf.tm_sec = rem % 60; /* January 1, 1970 was a Thursday. */ tbuf.tm_wday = (4 + days) % 7; + if ( days >= DAYS_IN_400_YEARS ) + { + y += (days / DAYS_IN_400_YEARS) * 400; + days %= DAYS_IN_400_YEARS; + } while ( days >= (rem = __isleap(y) ? 366 : 365) ) { ++y; From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:30:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:30:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351475.1608645 (Exim 4.92) (envelope-from ) id 1wfDkt-00085C-DP; Thu, 02 Jul 2026 09:30:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351475.1608645; Thu, 02 Jul 2026 09:30:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDkt-000855-9z; Thu, 02 Jul 2026 09:30:47 +0000 Received: by outflank-mailman (input) for mailman id 1351475; Thu, 02 Jul 2026 09:30:46 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDks-00083f-3u for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:30:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDkr-007LhY-Cd for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:30:45 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a462fc1-bab6-0a2a0a5309dd-0a2a4502b084-16 for ; Thu, 02 Jul 2026 11:30:45 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a462fc5-5a27-0a2a45020019-d1558032adc5-3 for ; Thu, 02 Jul 2026 11:30:45 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso8774945e9.1 for ; Thu, 02 Jul 2026 02:30:45 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dba3csm7260779f8f.3.2026.07.02.02.30.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:30:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782984645; x=1783589445; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=mJ8woLo45Zcyjbsvy9U/vb99ZvZrS30qykRl4pv4VUo=; b=Q4s5MUdwPvZbit11Oh/C7jQJ3+6m/gTLzOdJffKS7a8n2/PW6GAIdgb9Rr/NLoGjlf dXqTN2ne+UGxxkJNoAWSj4Z63AZJqhjdcaf4FusnalTgLwNhBwRxm5HfQoJQTroVkyZi UMRW29BTNChWQ9JH73WLCK8q7JPIcZrdUuK6GBxkV4Q5kZonHWJHQDtS3XWjWveQ6bal Xq9wMDru9EDoDALfd4zD8GfQnPbZfGbavqMkb5HwYqaqCFKBPIAfhDk2Ocryw7N3vNoO U+ywn5AVaQX/2gHTNWv1XJE71TFsyGVMCH//ftqqos8cH60xDVj84vziMloLwb85sm+B 9sDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984645; x=1783589445; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mJ8woLo45Zcyjbsvy9U/vb99ZvZrS30qykRl4pv4VUo=; b=fUspJIK95nB5LEBp2zlcIyTv1fCzE21GwwhewORGEEtHzdW3iWLlCW4xYKtJFvNM0p TPPyAUFEw8BqyLmRZe034tIpFxVImUGSCrw/lXH33mcWJ6uA5uHaFob+O7zFLvzE8a2q O3Py5NrMV4onefAYJNGgTV8SCeOGWKpNBgjxBBcXUWLxeWy8iHmyzxTriZBL8/fKqZ2O QWoAvaGQt7X/l28l4cV2oF1vXeGM0Y2EoK6H2ceThN1zsA3Uq4qFMdaoOFSQMuc6yIAm A4eItt3D3eDJyqvNxKuAnGpmlVuXR6ac09ryboP96bclhRHNHegNViGwqj5dEWC7eAy0 3kjQ== X-Gm-Message-State: AOJu0YxYuC+q01aM/HcW7P4zOrxaijUT0+NGQNjVVxYW5Uecq0F51PHm +Zwyy71G1PkIrADda0xHEecr4W4RVZze3Cmebd05Sw7MXJehR3iSQNTBYeV1lb20uG90Eph0Bf/ wVAS4Nw== X-Gm-Gg: AfdE7ck7825InuIJNxMkUjkMy0eU0mmsR5Yc9oH4JsU/RlGwrNSTgXnSXfAoS+g9LZ3 1Gb2sKWMgg/+UmRtoFOSlgvLisKrA1dC0guBrNYfF4wgUcT4lxgIVO1n7Qac3Tn6GBv0Xltk913 71P1hYvmeuOKAONbfr55wL8jivxViQ12bmDoJtp0TJTaDTsHWBGW866f5tQ388bmoe3wrSrjLFJ 7BYk5qPJzx7rSbU8MD8yvKzABjrDq8Hwk8GPo8Q3aIaS2+u9uor7rZksyHx9HUyVgUK1rvTHPhH MswHyTIgTFiVnJXuhh58r8UW5J0hZBK6FGG2J/WybfmTe2ErUw3TFAE44D12zrR2sXJLFj1esOc WK9Fhry5dOJGRwC9z/BCIvrWnF0nDAR0pxSQPqeEsV/OSXgEy2ufEZkTc0TDruGIjveqRVe3ZBH X5cfKTiDM1N6Wa2+bbbeof6Qw7esELRBoTI+XY+EMrXwLuTaF1C+nIROm8M0AuVZQJl0iJs/pfa Pz7Xs87UVGuw/g= X-Received: by 2002:a05:600d:8649:10b0:490:44eb:c1ea with SMTP id 5b1f17b1804b1-493c2b905d3mr60498205e9.24.1782984644789; Thu, 02 Jul 2026 02:30:44 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 11:30:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 3/4] x86/vRTC: the use_timer field is a boolean one From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie References: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1782984645-545187C5-63C8DB66/0/0 X-purgate-type: clean X-purgate-size: 1382 ... and hence wants to be of bool type. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -186,7 +186,7 @@ static void check_update_timer(RTCState if (!(s->hw.cmos_data[RTC_REG_C] & RTC_UF) && !(s->hw.cmos_data[RTC_REG_B] & RTC_SET)) { - s->use_timer = 1; + s->use_timer = true; guest_usec = get_localtime_us(d) % USEC_PER_SEC; if (guest_usec >= (USEC_PER_SEC - 244)) { @@ -214,7 +214,7 @@ static void check_update_timer(RTCState } } else - s->use_timer = 0; + s->use_timer = false; } static void cf_check rtc_update_timer(void *opaque) @@ -673,7 +673,7 @@ static uint32_t rtc_ioport_read(RTCState break; case RTC_REG_A: ret = s->hw.cmos_data[s->hw.cmos_index]; - if ((s->use_timer == 0) && update_in_progress(s)) + if ( !s->use_timer && update_in_progress(s) ) ret |= RTC_UIP; break; case RTC_REG_C: --- a/xen/arch/x86/include/asm/hvm/vpt.h +++ b/xen/arch/x86/include/asm/hvm/vpt.h @@ -106,7 +106,9 @@ typedef struct RTCState { s_time_t check_ticks_since; int period; uint8_t pt_dead_ticks; - uint32_t use_timer; + + bool use_timer; + spinlock_t lock; } RTCState; From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:31:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351486.1608653 (Exim 4.92) (envelope-from ) id 1wfDlO-0000Ck-L8; Thu, 02 Jul 2026 09:31:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351486.1608653; Thu, 02 Jul 2026 09:31:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDlO-0000Cd-Hw; Thu, 02 Jul 2026 09:31:18 +0000 Received: by outflank-mailman (input) for mailman id 1351486; Thu, 02 Jul 2026 09:31:17 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDlN-0000CK-5O for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:31:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDlM-007Lzy-IA for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:31:16 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a462fdd-5cb7-0a2a0a5109dd-0a2a4505d4b2-18 for ; Thu, 02 Jul 2026 11:31:16 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a462fe4-3cb2-0a2a45050019-d1558030a59c-3 for ; Thu, 02 Jul 2026 11:31:16 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4938d5f86f3so3223875e9.1 for ; Thu, 02 Jul 2026 02:31:16 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dbacbsm7498135f8f.4.2026.07.02.02.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:31:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782984676; x=1783589476; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=DyaH8jfrEj4hQ9whXJcni+qiFjc9whuT9c1Kf2l86fU=; b=XpA/o+iuXdyhPnXCCcO+7ch6FVt+jyEjvPZyqNAWDcDfcobpbka3o0RigzWSJGPWZW JieXBXo5q3v4YLqpS1YT2/109/3pSBPKmraMZEVITm+t3VBSw9s79pxAU5OGISXKCzM1 nJ3fgYdrR8Mmomg3jrlFriBO/mXuLcd8l/sc6GB+tRqB0Rh6+y3xbO7n7TMwHlsm0tao B4omRz/jKicjb5fxS9tX0VYYKp5o63Eu33u3XBe2fZKYR3B1UvqgRWzLaQZeSF087tn6 V6SSK5zMDEwxDkI3gUH6zlP5+o2rnvTzaKq13CtXUBhIttK2cSdvAhF+kQm9EJWP2qtF LaUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984676; x=1783589476; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DyaH8jfrEj4hQ9whXJcni+qiFjc9whuT9c1Kf2l86fU=; b=O+Y2hvc1SkcKxsy5SHrNBby88xs7KD+OfE6jcllmW2arFAVwHLC4gMAaaCMMwWeYfD FYfWoB1qVhb+ax4SkFppY7rEz5dyTGKjBA6GCiV/W8GxCf+sElfitkaTvuYNpa8NzDYU 2cmVEYU1/soRYh0HCIXc4Lj0YNSmPnTFj++2jrkEvo6WCY7yHU0sfOb1OFRjNhKZaYXL NTC3UNkXm5IKssO+lqsPTzB8AHWsChL6Dp+m1gjat1PDmJj+duryWH1lF6Rsuxm3qn5n mUm+InAhcB7NSOgErm7IyHaz8FwtwPgCQIs3Q2ydtMIpAl3Uf7wNiC5MkIC9APGP7oCE Qtsg== X-Gm-Message-State: AOJu0YxW29QbOA6ekOAMOE6M4oA7e0/Jg69PGsRbmJyCsmyfDplIlrWs 9GSzdELsWdNqUCl055DTKlk7CrXxKRRBJbTRx104BNkhGGaJ4iUtYGsTIU1CeSjmK9gUg7ESryV ENcY91g== X-Gm-Gg: AfdE7ck+3G8ILs6CtnYsiP/+qjZhB6/+18JkNCZWG8nlJyQZsjNBLbl9mZih/TFHea+ z9IQUjZkR9lJ+7UbjJ9U67kHaumTbUozB/3QjbY9hlVQ5bGYVMLjL42WG29PC8eU1EYFzVY2SKL 0oMeLhrf9CRzJ/i2ASAVWXVQkbsLm2MuP9L2X4295yrEoD60faxIKiBF6wG+MOJtnUHyjTXR8GD R0IaTdxf2NxoIc9M0rSPA903PW+713gIR7I0Dy+wVCNaQHHASGLnmXjNYkjjrIP81F9LTCqZ/NC xKJVIn16FVGKMZ/OSTeCl/dlWCYey+fJewJXX5kbMjwNy6dZ3u0zYhgQYHOQ7OxM5ZKCPxxr44+ Awdti1sqf/i6O8zZk0L2oZmSQHfx6oV7fG4Q4G6brWcFlmeHkF+L/Di9Yf3BF5YNDpparu/bSRH 3BTUB+QaSG1GL9UBWTk7p8clmsF7rM0I1om2ihBt/lkdczb4aQ10NfCo/ktQw6C65spxxmbQ/jd BeR X-Received: by 2002:a05:600c:3317:b0:490:55d9:149a with SMTP id 5b1f17b1804b1-493bc278166mr87474535e9.18.1782984675774; Thu, 02 Jul 2026 02:31:15 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 11:31:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 4/4] x86/vRTC: support century field From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie References: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <79d50725-3892-4643-b854-bfec9c0c0d79@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1782984676-0FF1F2B8-7CD43C0D/0/0 X-purgate-type: clean X-purgate-size: 9785 Both ROMBIOS and SeaBIOS (with CONFIG_QEMU=y, as we build it) blindly assume availability of this field (at its conventional index 0x32); OVMF at least has code to inspect FADT. Hence we ought to have supported it virtually forever. As the index is beyond RTC_CMOS_SIZE, leverage the padding field in struct hvm_hw_rtc to hold its value. Update the field only when involved values are valid BCD century specifiers. Otherwise (for VMs migrated in from an older hypervisor) leave handling to the DM. This makes the Linux rtc-cmos driver report y3k compatibility. In the new rtc_check(), besides checking the new fields also check the pre-existing pad0 field. While extending xen-hvmctx.c:dump_rtc() also add RTC offset there. Fixes: 4ca161214355 ("[HVM] Move RTC emulation into the hypervisor") Signed-off-by: Jan Beulich --- Am I overly paranoid with the checking of the field, considering that Xen 3.x post-dates year 2000 and hence all firmware nowadays usable guests have ever run with should have been aware of the field? Or am I, quite the opposite, still not strict enough? Now that we extend struct hvm_hw_rtc, should we perhaps save not only the century, but also its index? Likely more sanity checking could be added to rtc_check(), but that's for a separate patch imo. Isn't day-of-week handling flawed? If the field is brought out of sync with the other values, shouldn't it stay respectively out-of-sync? And isn't it excessive overhead to go through rtc_set_time() when the field is updated while SET is clear? Perhaps we ought to also support alarm day/month features? --- v2: Don't re-purpose pad0 field of struct hvm_hw_rtc. --- a/tools/libacpi/static_tables.c +++ b/tools/libacpi/static_tables.c @@ -33,6 +33,8 @@ struct acpi_20_facs Facs = { #define ACPI_PM_TMR_BLK_BIT_WIDTH 0x20 #define ACPI_PM_TMR_BLK_BIT_OFFSET 0x00 +#define CMOS_CENTURY 0x32 /* Conventional index used also without ACPI */ + struct acpi_fadt Fadt = { .header = { .signature = ACPI_FADT_SIGNATURE, @@ -88,7 +90,9 @@ struct acpi_fadt Fadt = { .register_bit_width = ACPI_PM_TMR_BLK_BIT_WIDTH, .register_bit_offset = ACPI_PM_TMR_BLK_BIT_OFFSET, .address = ACPI_PM_TMR_BLK_ADDRESS_V1, - } + }, + + .century = CMOS_CENTURY, }; struct acpi_20_rsdt Rsdt = { --- a/tools/misc/xen-hvmctx.c +++ b/tools/misc/xen-hvmctx.c @@ -311,7 +311,7 @@ static void dump_rtc(void) printf(" 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x, index 0x%02x\n", r.cmos_data[8], r.cmos_data[9], r.cmos_data[10], r.cmos_data[11], r.cmos_data[12], r.cmos_data[13], r.cmos_index); - + printf(" century 0x%02x offset %"PRId64"\n", r.century, r.rtc_offset); } static void dump_hpet(void) --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -482,16 +482,27 @@ static int rtc_ioport_write(void *opaque data &= 0x7f; s->hw.cmos_index = data; spin_unlock(&s->lock); - return (data < RTC_CMOS_SIZE); + return data < RTC_CMOS_SIZE || (s->has_century && data == RTC_CENTURY); } - if ( s->hw.cmos_index >= RTC_CMOS_SIZE ) + switch ( s->hw.cmos_index ) { + case 0 ... RTC_CMOS_SIZE - 1: + orig = s->hw.cmos_data[s->hw.cmos_index]; + break; + + case RTC_CENTURY: + if ( s->has_century ) + { + orig = s->hw.century; + break; + } + fallthrough; + default: spin_unlock(&s->lock); return 0; } - orig = s->hw.cmos_data[s->hw.cmos_index]; switch ( s->hw.cmos_index ) { case RTC_SECONDS_ALARM: @@ -507,6 +518,7 @@ static int rtc_ioport_write(void *opaque case RTC_DAY_OF_MONTH: case RTC_MONTH: case RTC_YEAR: + case RTC_CENTURY: /* if in set mode, just write the register */ if ( (s->hw.cmos_data[RTC_REG_B] & RTC_SET) ) s->hw.cmos_data[s->hw.cmos_index] = data; @@ -515,7 +527,10 @@ static int rtc_ioport_write(void *opaque /* Fetch the current time and update just this field. */ s->current_tm = gmtime(get_localtime(d)); rtc_copy_date(s); - s->hw.cmos_data[s->hw.cmos_index] = data; + if ( s->hw.cmos_index != RTC_CENTURY ) + s->hw.cmos_data[s->hw.cmos_index] = data; + else + s->hw.century = data; rtc_set_time(s); } alarm_timer_update(s); @@ -591,7 +606,16 @@ static void rtc_set_time(RTCState *s) tm->tm_wday = from_bcd(s, s->hw.cmos_data[RTC_DAY_OF_WEEK]); tm->tm_mday = from_bcd(s, s->hw.cmos_data[RTC_DAY_OF_MONTH]); tm->tm_mon = from_bcd(s, s->hw.cmos_data[RTC_MONTH]) - 1; - tm->tm_year = from_bcd(s, s->hw.cmos_data[RTC_YEAR]) + 100; + tm->tm_year = from_bcd(s, s->hw.cmos_data[RTC_YEAR]); + if ( s->has_century ) + { + unsigned int century = s->hw.century; + + BCD_TO_BIN(century); + tm->tm_year += century * 100 - epoch_year; + } + else + tm->tm_year += 100; after = mktime(get_year(tm->tm_year), tm->tm_mon + 1, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); @@ -629,6 +653,12 @@ static void rtc_copy_date(RTCState *s) s->hw.cmos_data[RTC_DAY_OF_MONTH] = to_bcd(s, tm->tm_mday); s->hw.cmos_data[RTC_MONTH] = to_bcd(s, tm->tm_mon + 1); s->hw.cmos_data[RTC_YEAR] = to_bcd(s, tm->tm_year % 100); + + if ( s->has_century ) + { + s->hw.century = get_year(tm->tm_year) / 100; + BIN_TO_BCD(s->hw.century); + } } static int update_in_progress(RTCState *s) @@ -663,13 +693,17 @@ static uint32_t rtc_ioport_read(RTCState case RTC_DAY_OF_MONTH: case RTC_MONTH: case RTC_YEAR: + case RTC_CENTURY: /* if not in set mode, adjust cmos before reading*/ if (!(s->hw.cmos_data[RTC_REG_B] & RTC_SET)) { s->current_tm = gmtime(get_localtime(d)); rtc_copy_date(s); } - ret = s->hw.cmos_data[s->hw.cmos_index]; + if ( s->hw.cmos_index != RTC_CENTURY ) + ret = s->hw.cmos_data[s->hw.cmos_index]; + else + ret = s->hw.century; break; case RTC_REG_A: ret = s->hw.cmos_data[s->hw.cmos_index]; @@ -718,7 +752,8 @@ static int cf_check handle_rtc_io( *val = 0xff; return X86EMUL_OKAY; } - else if ( vrtc->hw.cmos_index < RTC_CMOS_SIZE ) + else if ( vrtc->hw.cmos_index < RTC_CMOS_SIZE || + (vrtc->has_century && vrtc->hw.cmos_index == RTC_CENTURY) ) { *val = rtc_ioport_read(vrtc); return X86EMUL_OKAY; @@ -760,6 +795,32 @@ static int cf_check rtc_save(struct vcpu return rc; } +static int cf_check rtc_check(const struct domain *d, hvm_domain_context_t *h) +{ + const struct hvm_save_descriptor *desc = + (const struct hvm_save_descriptor *)&h->data[h->cur]; + struct hvm_hw_rtc s; + + if ( !has_vrtc(d) ) + return -ENODEV; + + if ( hvm_load_entry_zeroextend(RTC, h, &s) != 0 ) + return -ENODATA; + + if ( s.pad0 ) + return -EINVAL; + + for ( unsigned int i = 0; i < ARRAY_SIZE(s.pad1); ++i ) + if ( s.pad1[i] ) + return -EINVAL; + + if ( desc->length >= endof_field(struct hvm_hw_rtc, century) && + ((s.century & 0xf) >= 10 || (s.century >> 4) >= 10) ) + return -EINVAL; + + return 0; +} + /* Reload the hardware state from a saved domain */ static int cf_check rtc_load(struct domain *d, hvm_domain_context_t *h) { @@ -793,12 +854,18 @@ static int cf_check rtc_load(struct doma check_update_timer(s); alarm_timer_update(s); + if ( !s->hw.century ) + { + s->has_century = false; + s->hw.century = 0; + } + spin_unlock(&s->lock); return 0; } -HVM_REGISTER_SAVE_RESTORE(RTC, rtc_save, NULL, rtc_load, 1, HVMSR_PER_DOM); +HVM_REGISTER_SAVE_RESTORE(RTC, rtc_save, rtc_check, rtc_load, 1, HVMSR_PER_DOM); void rtc_reset(struct domain *d) { @@ -873,6 +940,12 @@ void rtc_init(struct domain *d) s->hw.cmos_data[RTC_REG_C] = 0; s->hw.cmos_data[RTC_REG_D] = RTC_VRT; + /* + * By default we make the century byte available, unless an incoming save + * record says otherwise. + */ + s->has_century = true; + s->current_tm = gmtime(get_localtime(d)); s->start_time = NOW(); --- a/xen/arch/x86/include/asm/hvm/vpt.h +++ b/xen/arch/x86/include/asm/hvm/vpt.h @@ -109,6 +109,8 @@ typedef struct RTCState { bool use_timer; + bool has_century; + spinlock_t lock; } RTCState; --- a/xen/arch/x86/include/asm/mc146818rtc.h +++ b/xen/arch/x86/include/asm/mc146818rtc.h @@ -37,6 +37,9 @@ bool is_cmos_port(unsigned int port, uns #define RTC_REG_C 12 #define RTC_REG_D 13 +/* Conventional index used without (and typically also with) ACPI. */ +#define RTC_CENTURY 0x32 + /********************************************************************** * register details **********************************************************************/ --- a/xen/include/public/arch-x86/hvm/save.h +++ b/xen/include/public/arch-x86/hvm/save.h @@ -488,6 +488,8 @@ struct hvm_hw_rtc { uint8_t pad0; /* RTC offset from host time */ int64_t rtc_offset; + uint8_t century; + uint8_t pad1[7]; }; DECLARE_HVM_SAVE_TYPE(RTC, 11, struct hvm_hw_rtc); From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:33:18 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:33:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351497.1608663 (Exim 4.92) (envelope-from ) id 1wfDnI-0000th-Vz; Thu, 02 Jul 2026 09:33:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351497.1608663; Thu, 02 Jul 2026 09:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfDnI-0000ta-SR; Thu, 02 Jul 2026 09:33:16 +0000 Received: by outflank-mailman (input) for mailman id 1351497; Thu, 02 Jul 2026 09:33:15 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfDnG-0000tU-U5 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:33:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfDnG-005Cuz-A9 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:33:14 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a463056-e002-0a2a0a5209dd-0a2a450cdfda-28 for ; Thu, 02 Jul 2026 11:33:14 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46305a-f399-0a2a450c0019-d155802abd9c-3 for ; Thu, 02 Jul 2026 11:33:14 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-493bb510ce4so11732985e9.1 for ; Thu, 02 Jul 2026 02:33:14 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dbacbsm7516228f8f.4.2026.07.02.02.33.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:33:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782984794; x=1783589594; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IY3SZailvwX528iXXlWraiO7f+IYxbdwbGQ0Wrx2rZ0=; b=hcROJ4UYxGY7e9MUcifxRDQfZiWebisIt2pS8M+k2AGsPINxrgmc358NnL8f2eG5NQ hEarK1JrW5CCHscmlH0n6Yctya5VPZZykRUzKkR02wUYNNT0PCf7nm6FLI3iT/qd6SlF dTBXiZCZ8Mib24na6NlgoSXptGU7xaXUWz6B5Un7+VJbtdgh9v8HBfPGith2kMQ51+p/ yNaHuqsk1N4DSaaG1Hc6aBLYaVMNKoHuqLbKt6vTbb+9D6oX2OBiqa0On3SJwT1CiDRR Vxe9oGeiCclDT8IJjMrIsrGtkZHoeuqUz7VkrzspLZuXQOzlwY1OuKaFRDrn/3EaJ4O5 pt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782984794; x=1783589594; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IY3SZailvwX528iXXlWraiO7f+IYxbdwbGQ0Wrx2rZ0=; b=PnOCrsvkmOPkF3mFrNe3vOLz7AZrqwBnc+9iwoarRjl6EypUlnuVlaPylzCc/fdxR1 ktZOpkq2h3dqLWaUpXfe7eppb88VqncXB2KHUb4/OFrcIC2ua9+4B66wP6Re1fIuLYvN t1CNBSJYBmpasMnFb4j9fM9Ue2SoQB65o3Vcy/XsrRlC2FQd+g7jmDuF1h27LjgrikXu 2AkY7hZJ4N/RDz73Y0lA3l7qCsr5BAaqqy6895M5Mezu2ut/sc60bIvfoJqq+nxcFnIS bSONGmLXn2Fu4XDciNxtNgG3sXMrsDFgT81t6DSsCK956U7M7VX1gRHWc8pEOxHITsLy 1pag== X-Forwarded-Encrypted: i=1; AFNElJ9npchuLFoJZyK7I4S+zf0aQ2gXHRXLSJnNT699/tdmcjJLCICi2OMcxCtX9crS4tNmcvHIjHSmFNE=@lists.xenproject.org X-Gm-Message-State: AOJu0YxcMgvkAp14sB+Pv1JlLvIYo84CBf937nTpSKO/Yzob1l1OA3DE OK5L2QJhlAjKucO8Nr5R1UFU2fqlvLsKcErvC72H86Qkbn9cptvksqGs X-Gm-Gg: AfdE7cnZ1Ut7UG2yLvMa3eK6iGXdol/mh2yarmX0BQzlWy18KIMMTiHugvfqijyUUQe +s4CBzoiC12HuC8M89f6DvEWjG3/QT8Thz+b7IQmI2ZazjE2CifenkU/oWjuP/tfJ8Q8r/ZW9+z pThHVt1bYux2yGdlQ/sdoBQPiaMzeiPJ6cH7oiHb6d65lzR/oqwaRIK7ULdpOb1M9Ef+Mx3Qrl5 JUimdbwy9dUfbWtmKr+gu1h+I6TMAXb0Pr51l/WmKoN7CPheDFKlIdpJB6awGBGCJgr8rhFwvF4 q9nCOmhgduofCav+1BXM82sQPYHCce4hdTll6L/6Yov7JHfaYIpov9+ogKyYmJpMwwUrP/zmldj sbIPyig8mVSMK6s7hphcjWJy1qs5fhft+fDv1B44bMjy+dsZ5asn5ONpM2cNayM0OoVjcxEqbNZ PmvpwRLFrydqOdCII7BSjaxex5sU3QlTySP88xJqlozjf+mAVem3eGFZpT4s6tHRmrAe1ktOo4t yxgXQ== X-Received: by 2002:a05:600c:6308:b0:493:b915:4a6f with SMTP id 5b1f17b1804b1-493c2b38138mr77225745e9.8.1782984793521; Thu, 02 Jul 2026 02:33:13 -0700 (PDT) Message-ID: <91ffc1b2-7648-4185-a2f1-12b30181c8a9@gmail.com> Date: Thu, 2 Jul 2026 11:33:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/25] xen/riscv: implement IRQ routing for device passthrough To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <472a77604d35a0bc2a75b71f250fd67b63afde4c.1782487661.git.oleksii.kurochko@gmail.com> <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> <40bcf6b7-306a-419a-bf12-1855f9e589fe@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <40bcf6b7-306a-419a-bf12-1855f9e589fe@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1782984794-91F23D51-74EF1538/10/73395122804 X-purgate-type: spam X-purgate-size: 1448 On 7/2/26 8:38 AM, Jan Beulich wrote: >>>> + spin_unlock_irqrestore(&desc->lock, flags); >>>> + >>>> + release_irq(desc->irq, info); >>>> + xvfree(info); >>> >>> If, in release_irq(), action isn't freed, it's ->dev_id field will now have >>> a dangling pointer. (I think I did point this out before.) >> >> It should freed in release_irq() as route_irq_to_guest() always set >> action->free_on_release = true; > > Well, "free_on_release" must exits for a purpose. I.e. there must be, now > or soon, cases where it's set to false. Else simply drop the field. > I can't simply remove this field because it is part of the common `struct irqaction` and is used by other arc-s. (I assume that it is not what you fully meant...) IIUC, this field is used to determine whether an irqaction is heap-allocated (and therefore should be freed) or statically allocated (and therefore should not be freed). At the moment, all IRQ actions are heap-allocated (on RISC-V), so free_on_release should always be set to true. In particular, the code snippet you asked about releases a guest interrupt, and guest interrupt actions are always heap-allocated. As a result, when release_guest_irq() calls release_irq(), the associated irqaction will be freed. So, from what I can see, the current behavior is correct and I think it should be left as it is. Do you have any concerns about this? ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:47:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351516.1608672 (Exim 4.92) (envelope-from ) id 1wfE10-0003mx-5x; Thu, 02 Jul 2026 09:47:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351516.1608672; Thu, 02 Jul 2026 09:47:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfE10-0003mq-2q; Thu, 02 Jul 2026 09:47:26 +0000 Received: by outflank-mailman (input) for mailman id 1351516; Thu, 02 Jul 2026 09:47:24 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfE0x-0003mj-Sz for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:47:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfE0x-005v0l-9U for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:47:23 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4633aa-e002-0a2a0a5209dd-0a2a4503d058-6 for ; Thu, 02 Jul 2026 11:47:23 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4633ab-ec1a-0a2a45030019-d1558036bdb0-3 for ; Thu, 02 Jul 2026 11:47:23 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493bb510ce4so11840455e9.1 for ; Thu, 02 Jul 2026 02:47:23 -0700 (PDT) Received: from RTRKN1313-LIN.domain.local ([89.216.37.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4a15sm7539152f8f.14.2026.07.02.02.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 02:47:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Cc:To:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782985643; x=1783590443; darn=lists.xenproject.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=fKC1D1OsYzhuu2T5DhZS+ayo24Iqaetkzw1OMf9jA3M=; b=PK8X7hvSC/DNLjsOvSvgMjKIJnqJ0PX7MFOKTu8pVhqSgNFflqUHh9R3T8qg3aSoX6 LWcBwMvqrSurAYPwLTr9pIUZHwCXBCsTsuEmtpwQs096eeoXcSbRGSmS+XN8hFRMf4UT dBt8fdMdWF+BhXfDa8yZ1iXbHKXkq4Y4LotnjNHVw7QIu6OLVqI4v9xE8dkNqy88FE+o x6UIeq5WuRRxSX8ztp8yQSW9pfF1pwsRV8rc0CWpda6uSWcVPG/ot+K9ETrpg38xawXU OXf05TmaAN1K/np1jwutEfok8YdfY28uOYNK9/l6AUlAq46lLQKr2oeGiJxnXN5QuS/6 NTvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782985643; x=1783590443; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fKC1D1OsYzhuu2T5DhZS+ayo24Iqaetkzw1OMf9jA3M=; b=Z0iKEbH+zZWiMjhmpFJK/8OgKy5drRZjQqiLebAN2UfrqYUh5yPvDSZdKM9LgRaQB+ eM4IGvX2SMgbqpRoEJ92lcNAajpQ6Ylr24sIFSD+wgOEOJewDY2qY2bO/nR2rc6HElFV ekRLecshxEFHAMrmA4C8YFZz1QwTdFvEWBN+3nd3rbAjoERAvlSolGDKkDcoPq2n/vJW jTcX1X96b3nm2ohuRX1pHABreWBJxGDzc7gOLLWexFAd1kVzjB4M3/XGSTCyjOZ9g5HL dCQ73OBuU1NH+1DQO3MremWOtHBkqdr8dqOXTV9qed/ByXIMHAioBqrMaxE+ALnU/sPy BYsw== X-Forwarded-Encrypted: i=1; AFNElJ84cRpXPwmO3jhXo7iiSHoN5D1wIB1n0Hqt3/bzs/akpmHFCBCEpvQeM+h7HHlm2MferiknFhOYbrw=@lists.xenproject.org X-Gm-Message-State: AOJu0YwHj0fmLbNDukEGWWLtG2GLCcJq5mfND/MZTqptqOLTv6f2KY+0 9XORYSyI9ooA0txM13SX+wYbq75udiP4rK692WT64zKxeTpx7Pf5ZHZt X-Gm-Gg: AfdE7cnx43GUJtNT0qx+LYtg/6YrAqtm9EEqBf1qZHRizu72AqXWRJDwk0yO+z+Rppk uqXf8KOIpXtw7wWANMqcCSTJPz/klGvPQUWMEh/O1XhaeXD8CB45K0DRxEohNvn+fIpq8tmqMMu nsrNyhM12wt3b1Raqn2cUXwZnRBKtLHKH8/zKDZByW2Q0xTCY8jGjOdFZmaPi+O2Q+7V3+zN7ct d5VsXApN6isxE9Zj32J6i1ubdQi0W2q4uO85in5ZF8cPs1LqYyRWbosQP/vq1QLYGt+8OhJms9K 3xazoT/o/oUhtU+2sUuDGW8JNk4Vg+c5gpmDAgRClrRZBYpA3E3MvCAT7X651aKEJ4ukT1vc3Bv saFxEzIKSp8Ya31c/Vk9bW2idm8Ng+0Wbb/JRtn/ElaaJn2G2dkxhGGvqMBmGf98z6qTiUt+O0C 2xkR7oj+KetP+2hriGGDn5rb9X+PTmqgtmnAT/ZeXJHw== X-Received: by 2002:a05:600c:8b30:b0:493:bdaf:83a7 with SMTP id 5b1f17b1804b1-493c83a5b75mr4322745e9.28.1782985642521; Thu, 02 Jul 2026 02:47:22 -0700 (PDT) From: Dusan Stojkovic Subject: [PATCH RFC v3 0/2] vhost-user: support Xen foreign memory mappings Date: Thu, 02 Jul 2026 11:46:11 +0200 Message-Id: <20260702-vhost-xen-foreign-mapping-v3-0-2b8ef913382b@rt-rk.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAGMzRmoC/43NTQqDMBAF4KtI1p2SRJNoV4VCD9Bt6cKfUUMxk USCRbx7Q1auSpdvHvO9jXh0Gj25ZBtxGLTX1sSQnzLSjrUZEHQXM+GUSypZCWG0foEVDfTWoR4 MTPU8azNAR3nelqJpFJUk/s8Oe70m+0ke9xt5xeOo/WLdJ+0Flqo/6MCAguolrSUvWKXY1S3g3 ufWTkkN/CDx6pfEo8QqLGQpUAkljtK+719pMItFEQEAAA== To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Stefano Garzarella , Stefano Stabellini , Anthony PERARD , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Viresh Kumar , Dusan Stojkovic , Nikola Jelic X-Mailer: b4 0.13.0 X-purgate-ID: tlsNG-33051d/1782985643-05B345D1-9B66165D/0/0 X-purgate-type: clean X-purgate-size: 7723 This series lets QEMU, when running as a Xen device model, drive vhost-user backends that map guest memory through the Xen foreign mapping interface, implementing the front-end side of VHOST_USER_PROTOCOL_F_XEN_MMAP. The protocol extension itself is already documented in docs/interop/vhost-user.rst (feature bit 17, extended memory region description) and implemented by rust-vmm's vhost / vm-memory crates and the vhost-device backends built on them. The problem this solves: under Xen the guest's RAM is not allocated by QEMU and is not backed by a file descriptor. memory_region_get_fd() returns -1, so vhost_section() filters out every RAM section, the vhost memory listener registers no regions, and starting any vhost-user device fails with "Failed initializing vhost-user memory map". With F_XEN_MMAP the backend maps guest memory itself. The protocol requires one file descriptor per region in SET_MEM_TABLE. Guest RAM under Xen has no backing fd, so the front-end opens /dev/xen/privcmd per region purely to satisfy that requirement; the backend derives the mapping from guest_phys_addr + domid and never reads the fd. Each fd is closed once the message has been sent. This patchset was rebased onto the new vhost_phys_vring_addr infrastructure and extends vhost_user_gpa_addresses() so that negotiated F_XEN_MMAP (bit 17), not F_GPA_ADDRESSES (bit 21, which the backend doesn't advertise), drives GPA addressing for both rings and userspace_addr. The two patches: 1/2 accept the Xen RAM section in vhost_section() 2/2 negotiate F_XEN_MMAP and build SET_MEM_TABLE from the extended region layout. Testing: Tested on Xen/ARM64 with a DomU using virtio-mmio transports created by the xenpvh machine, running vhost-device-sound (rust-vmm, built with the "xen" feature) as the backend in dom0. The device negotiates, receives the memory table and ring addresses, and the guest's virtio-snd driver probes and operates. Non-Xen / x86 KVM: vhost-user-snd backed by vhost-device-sound (null backend) on a q35/KVM guest. The device negotiates, the guest virtio-snd driver probes and runs the control and PCM paths, and the SET_MEM_TABLE and vring-address traffic is identical to a build without this series confirming the non-Xen path is unchanged. The control message exchange between the frontend and backend was tracked using sockdump as was described in: Making VirtIO sing - implementing virtio-sound in rust-vmm project |-> at FOSDEM 2024 Setup: The main part of the xl config this enables: virtio = [ 'backend=0,type=virtio,device,transport=mmio,grant_usage=false' ] device_model_args = [ ... '-chardev', 'socket,id=snd_chardev,path=/tmp/snd.sock', '-device', 'vhost-user-snd,chardev=snd_chardev,id=snd,iommu_platform=true', ... ] Xen 4.22-unstable was used with: -enable-IOREQ_SERVER -enable-EXPERT An extra patch was added to xen-tools. Namely, xen tools will request a pv device drive type for ARM64 but qemu expects pvh. This is a known issue: github.com/Xilinx/xen/commit/5f669949c9ffdb1947cb47038956b5fb8eeb072a Qemu master was used configured with the following flags: --target-list=aarch64-softmmu \ --cross-prefix=aarch64-linux-gnu- \ --enable-xen \ --enable-vhost-user \ --extra-cflags="-I$XEN-TOOLS/usr/local/include" \ --extra-ldflags="-L$XEN-TOOLS/usr/local/lib -Wl, -rpath-link,$XEN-TOOLS/usr/local/lib" \ Likewise for x86: --target-list=aarch64-softmmu \ --enable-slirp \ --enable-xen \ --enable-vhost-user \ --enable-virtfs \ Linux version 6.11.7 was used with extra configuration flags: * For enabling Xen Dom0/DomU support * For enabling virtio (mmio, snd, etc.) * For enabling sockdump features (BPF, IKHEADERS, KPROBE, etc.) * Extra debug flags (DEBUG_FS, etc.) vhost-device commit-id: c3bb658ef4fe20a2f264dbbbbc6fa19f1c08c0c5 Was used built with: --features alsa-backend,xen Importantly in vhost-device-scmi/src/vhu_scmi.rs: // QUEUE_SIZE must be apparently at least 1024 for MMIO. // There is probably a maximum size per descriptor defined in the kernel. const QUEUE_SIZE: usize = 1024; A similar change was made to make mmio work in vhost-user-sound device, bumping QUEUE_SIZE to 1024. Without this frontend and backend will fail to negotiate queue size. Scope and known limitations: * Foreign mappings only. Grant mappings are not supported: vhost's section tracking derives a host pointer for each region, which is invalid for the grant pseudo-region, and per-access grant mapping needs a different region description (GRANT | no-advance-map). Patch 1 rejects the xen.grants region explicitly. Setting grant_usage=true does not change the qemu<->backend vhost-user exchange. * VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS is suppressed under Xen: the ADD/REM_MEM_REG path has not been converted to the extended region format, and Xen guests currently expose a single RAM region, so SET_MEM_TABLE is sufficient. Multiple RAM regions are not yet exercised. Postcopy is refused. * Spec vs reference implementation: docs/interop/vhost-user.rst describes the "can not be mapped in advance" xen-mmap flag as Bit 8 (value 0x100), whereas rust-vmm's vm-memory uses 0x8 (bit 3, MmapXenFlags::NO_ADVANCE_MAP). This series uses neither, but the discrepancy probably wants resolving in the spec. Viresh, which is intended -- bit position 8 or value 0x8? * userspace_addr is carried unchanged in the region descriptor; under Xen it does not correspond to a mapping and backends do not interpret it. An alternative would be to define it (e.g. mirror guest_phys_addr). Open questions: - userspace_addr semantics under Xen: leave it unchanged, or define it? - Multi-region support: convert ADD/REM_MEM_REG to the extended layout rather than suppressing CONFIGURE_MEM_SLOTS? - Grant-mapping support: worth pursuing, and what region-description shape do backends expect? - Updating vhost-device-sound to reflect the mmio support. References: - vhost-user spec, F_XEN_MMAP / extended memory region / xen mmap flags: docs/interop/vhost-user.rst - rust-vmm vm-memory MmapXenFlags (FOREIGN=0x1, GRANT=0x2, NO_ADVANCE_MAP=0x8): src/mmap/xen.rs - Making VirtIO sing - implementing virtio-sound in rust-vmm project |-> at FOSDEM 2024 Signed-off-by: Dusan Stojkovic Signed-off-by: Nikola Jelic --- Changes in v3: - Rebased onto current master - Fixed semantic error in vhost_section comment - Link to v2: https://lore.kernel.org/qemu-devel/20260629-vhost-xen-foreign-mapping-v2-0-19e4685e7575@rt-rk.com Changes in v2: - Rebased onto current master - Cover letter: removed a rust-vmm hunk which made the git am on Patchview fail. The reference is now mentioned in a sentance. - Link to v1: https://lore.kernel.org/qemu-devel/20260618-vhost-xen-foreign-mapping-v1-0-7f60a6241971@rt-rk.com --- Dusan Stojkovic (2): vhost: accept Xen guest RAM sections for vhost-user vhost-user: implement VHOST_USER_PROTOCOL_F_XEN_MMAP hw/virtio/trace-events | 2 + hw/virtio/vhost-user.c | 120 +++++++++++++++++++++++++++++++++++++++-- hw/virtio/vhost.c | 18 +++++++ hw/xen/xen_stubs.c | 5 ++ include/hw/virtio/vhost-user.h | 2 +- 5 files changed, 143 insertions(+), 4 deletions(-) --- base-commit: 30e8a06b64aa58a3990ba39cb5d09531e7d265e0 change-id: 20260618-vhost-xen-foreign-mapping-d023c85bb706 Best regards, -- Dusan Stojkovic From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:47:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351517.1608681 (Exim 4.92) (envelope-from ) id 1wfE11-0003zg-Cr; Thu, 02 Jul 2026 09:47:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351517.1608681; Thu, 02 Jul 2026 09:47:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfE11-0003zZ-9r; Thu, 02 Jul 2026 09:47:27 +0000 Received: by outflank-mailman (input) for mailman id 1351517; Thu, 02 Jul 2026 09:47:26 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfE10-0003mp-Dq for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:47:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfE0z-00DHuU-7Z for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:47:25 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a463395-bab6-0a2a0a5309dd-0a2a4507b6fc-44 for ; Thu, 02 Jul 2026 11:47:25 +0200 Received: from [209.85.221.51] (helo=mail-wr1-f51.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4633ac-9c8e-0a2a45070019-d155dd33a968-3 for ; Thu, 02 Jul 2026 11:47:25 +0200 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4720f3bf164so186008f8f.1 for ; Thu, 02 Jul 2026 02:47:25 -0700 (PDT) Received: from RTRKN1313-LIN.domain.local ([89.216.37.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4a15sm7539152f8f.14.2026.07.02.02.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 02:47:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding:MIME-Version:Subject:Date:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782985644; x=1783590444; darn=lists.xenproject.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BHsFCClOErBCb2hCTW5Kdx5hfrAxpl2r1lI9X/xFrPM=; b=ITmOfOavKJQSNtGMR+RLZvrYCDrxTxb3AUuhd/0VvvyaHZVIqPDS9qRr/S+hLpkL9D /XO0wJKGXeJUJRZ3h3zURv77ws5Aj2iS819OLKOITpGLGbMja8lECXReJFxR/K6juqL7 3C8VlmHGQaAy7Nw5cRs0TLdinIfx3lMfdqy49G2NuaDm1Ms9Z1bNjmKOiCquRL9gFG4U LopsGbWiIRGzEEKWEjCpRwE4E5QDNkegvexGieyfJpCmyZ6Wc289J3iuWyC1/XhqQWTw sHew7LmEnN30dXv0HhWjebNxOjyaBPids0LJKEIHCPXN2vs9m0mLMQfT5ou1gPmllkVu q8Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782985644; x=1783590444; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BHsFCClOErBCb2hCTW5Kdx5hfrAxpl2r1lI9X/xFrPM=; b=eqm2ne+C41bzLTg9V7AOfq7dfHs1L41BPnbncOR58SlIA30p6IDFWNKbzgYDZEpbh3 Ai9wF5MU4ZtJ3lsSI6YcWyiYN/k02YyiqwehiANyEHaA5h9KlaqIU+3Tm2mftHYshf5X h0ZK4XG17tNe/Ah2y4c/xWDic21cu+Gcl0X9YQmN8npOLmHlQWRVLEylzk1l0cdzmFua Rhrf2/5ySIILszqXqALpx4RimN55xJZrB7Uk3aDYSQ08uWxRExPEe86eFYNEu9655t/U e1yTg5HI+BfAv4gQIds5Q6oyzZuc6wfvLVY8svWJUeCrhI4LwQ3eAGB+B0srdc76X+tF g8Vg== X-Forwarded-Encrypted: i=1; AHgh+RpkPPzCltjP74RsT8YgvqwcJGOcF/dvzNqO9+mgFk7pKnYjaZ7jqklGQLfiAyhoxrT30RMWNWdkoz8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzE+tHTkMG7uxP4ZhFNerldfUOYZob/gLY0AjCgfeII3q9TZIg5 YnNaKN0I0sWhnQVo1R1Oc+/yww/GGuE2T5W5CRxqLg9K25MLXfdD801s X-Gm-Gg: AfdE7cn5WoxBF86mu5m44DpbXiyn6SD7qVeR5uy39U1gg5VivjGJ0b9rDKLdIF7q+HE d1chUS7eVOnlO4zbggXNPEE/IImSnTZj9xG8fFvP7Pu6LVYIBD2meORvEuHfZ0mGzdk41Tb9rgd 5j0s4wtRllILB+cFFTeVygkM0UjaOjRhlBwRFIBWeM/3WscSI5jAWyNuGdqkMuFYOcOnCEqegKF rmvYdGeNMSfGV/kSZgMvLc092ts0jRJdzBsh7eSGX8RC2phiU58fh08dbustyZewZsZn5zxbIJY rHx2Trey51xDS/41dhm3I4doX28U/CoXqpobRxP7JubaJiNbIStMmbTVVZ6p3QQk52PPZK1Sw92 /5DkgjOlHSGzUhocnqAAce96ehjqLOjaK93dIrLqqdigyTzXCakFtjb5Ifdct4pJIXfg+cQVxxK VMPAf/GH/Efk4dAdZwJJVgJM2XdGjHO3mhIrQ+9FRAuQ== X-Received: by 2002:a05:6000:290f:b0:46f:9026:4971 with SMTP id ffacd0b85a97d-475de54e175mr13729534f8f.11.1782985644267; Thu, 02 Jul 2026 02:47:24 -0700 (PDT) From: Dusan Stojkovic Date: Thu, 02 Jul 2026 11:46:12 +0200 Subject: [PATCH RFC v3 1/2] vhost: accept Xen guest RAM sections for vhost-user MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260702-vhost-xen-foreign-mapping-v3-1-2b8ef913382b@rt-rk.com> References: <20260702-vhost-xen-foreign-mapping-v3-0-2b8ef913382b@rt-rk.com> In-Reply-To: <20260702-vhost-xen-foreign-mapping-v3-0-2b8ef913382b@rt-rk.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Stefano Garzarella , Stefano Stabellini , Anthony PERARD , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Viresh Kumar , Dusan Stojkovic , Nikola Jelic X-Mailer: b4 0.13.0 X-purgate-ID: tlsNG-ef75cf/1782985645-FF33F25E-264A153B/0/0 X-purgate-type: clean X-purgate-size: 3365 From: Dusan Stojkovic When QEMU runs as a Xen device model, the guest's RAM is not allocated by QEMU and is not backed by a file descriptor that could be shared with a vhost-user backend: accesses from QEMU go through the Xen mapcache and memory_region_get_fd() returns -1. vhost_section() therefore filters out every RAM section, the vhost memory listener registers no regions, and starting any vhost-user device fails with "Failed initializing vhost-user memory map". With VHOST_USER_PROTOCOL_F_XEN_MMAP the backend does not need an fd or a process-local mapping it maps guest memory itself through the Xen foreign mapping interface, using the guest physical address and domain id. Accept the Xen RAM region in vhost_section() so that it reaches the backend's memory table. The Xen grant region (xen.grants) must never be accepted: grant references can only be mapped individually on demand via address_space_map(), and deriving a host pointer for the whole region, as vhost_region_add_section() does, aborts in the Xen mapcache. Note that xen_mr_is_memory() returns true for both the RAM and the grants region, so the grants region is excluded explicitly. Because of the necessity to exlude xen.grants, the missing stub for xen_mr_is_grants is added so that it can be called from common code. Signed-off-by: Dusan Stojkovic Signed-off-by: Nikola Jelic --- hw/virtio/vhost.c | 18 ++++++++++++++++++ hw/xen/xen_stubs.c | 5 +++++ 2 files changed, 23 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index af41841b52..ffc692b3e2 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -29,6 +29,7 @@ #include "system/dma.h" #include "system/memory.h" #include "system/ramblock.h" +#include "system/xen.h" #include "trace.h" /* enabled until disconnected backend stabilizes */ @@ -657,6 +658,23 @@ static bool vhost_section(struct vhost_dev *dev, MemoryRegionSection *section) return false; } + /* + * Under Xen, the guest's RAM is not backed by an fd that + * can be passed to a vhost-user backend. The backend + * instead maps guest memory through the Xen foreign mapping + * interface, by guest physical address and domain id (see + * VHOST_USER_PROTOCOL_F_XEN_MMAP), so accept the Xen RAM + * region even though it has no fd. + */ + if (xen_enabled()) { + if (xen_mr_is_memory(mr) && !xen_mr_is_grants(mr)) { + trace_vhost_section(mr->name); + return true; + } + trace_vhost_reject_section(mr->name, 4); + return false; + } + /* * Some backends (like vhost-user) can only handle memory regions * that have an fd (can be mapped into a different process). Filter diff --git a/hw/xen/xen_stubs.c b/hw/xen/xen_stubs.c index f830768d99..7af39bceb0 100644 --- a/hw/xen/xen_stubs.c +++ b/hw/xen/xen_stubs.c @@ -29,6 +29,11 @@ bool xen_mr_is_memory(const MemoryRegion *mr) g_assert_not_reached(); } +bool xen_mr_is_grants(const MemoryRegion *mr) +{ + g_assert_not_reached(); +} + bool xen_map_cache_enabled(void) { return false; -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:47:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351518.1608690 (Exim 4.92) (envelope-from ) id 1wfE15-0004Eq-LH; Thu, 02 Jul 2026 09:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351518.1608690; Thu, 02 Jul 2026 09:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfE15-0004Ee-HL; Thu, 02 Jul 2026 09:47:31 +0000 Received: by outflank-mailman (input) for mailman id 1351518; Thu, 02 Jul 2026 09:47:30 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfE14-0004Dm-Oq for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:47:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfE14-00DI0b-4w for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:47:30 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4633ad-bab6-0a2a0a5309dd-0a2a4502a6dc-20 for ; Thu, 02 Jul 2026 11:47:30 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4633ae-5a27-0a2a45020019-d155dd2df0fe-3 for ; Thu, 02 Jul 2026 11:47:26 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4763b0c1dcdso1632335f8f.2 for ; Thu, 02 Jul 2026 02:47:26 -0700 (PDT) Received: from RTRKN1313-LIN.domain.local ([89.216.37.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4a15sm7539152f8f.14.2026.07.02.02.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 02:47:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782985646; x=1783590446; darn=lists.xenproject.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ylBpQ0bt/QK9zQ9BEMnv21TmNMn+xhUv/pb6/Do4RGs=; b=Ff1iX/hV73wsQ6BINWM9CpYruivuosCueau4Yv4HSs0BKcCQv9Y8fqJmf8964YuLhx ydu8XxV65ETj4EVw/9Zj/kFRcwGHp0r62C5jIBWaBkClP5vPtWkxXu+iLpbGwSjAMu0b tVLtszB4W6A2877XPSCCJkFrU9+5iUGEodRMeS8uWd0mKlf1cOWKv1YYE2Ms1o82DO4K MT/RTa+h6byM0cxmLuiPgmWtvWhFd4MGdukvppcZkEwNQTkKamTB1mMlAvctGrhC+ni5 Tv1cfIgqM5WD/B29p0Bt3jxFcYMiLlqslggb2X1zmb08jhHwZS9Y8yENVPr67e54nUQr Qujw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782985646; x=1783590446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ylBpQ0bt/QK9zQ9BEMnv21TmNMn+xhUv/pb6/Do4RGs=; b=AmvXrLJh+n0lOvp/ZcADQwcpy+hZL7n47uk6P6yhSPRXdhior11qpzSUwXHnLNA/0W PAz74Pu09VAMCSL28rGrpJFxqXAUMA8aK7lFVCnJ8jdwt9RzSU8YLqP/grZoQt2Q0yW0 yvNtSlkq0CQDz7jcM3t7h9SNr201nrXGNyaW/3IpObKOzzFEpWZ1b6bajnJQ8457GJin /WZgUfHcz6nZvo9n/kBbEq+esaVqd/41T4W/fK9fEUgAtjdATA3VSHBCt4P85aLvKN55 0rkz3LNoaoywpNO+CoMq8KDJ1m7d7vlfXEtoPZOSznZPVOpab9kfbKA/oBMqf8FB9pDf Utvg== X-Forwarded-Encrypted: i=1; AFNElJ8KgeDXSOkOEiJ4rkGRhOW490EsDM9kWmp/Hz+ga3AyArVjHQpTWsPpRrQvVbjtpIpqTJPXZVMch2w=@lists.xenproject.org X-Gm-Message-State: AOJu0Yysq0C9MyzdYV1+b97G0yfmVOQXdxeExJDmzYXBsvODFXnAoy+X tQx/P74YWCYJ4DJhJFUaCx5U8hvjpI1CEVW0XJJFeLbrB1t2zJEMYM0Y X-Gm-Gg: AfdE7cmVbrXD2qQeZ72FFMppTpev9cn9GUfxVOZ8VkhKh243BKGNIB2A5cKLEYlmLWL oGpUhRGRvt99n5lTjqrtW8n5GTGsQRJOI3lQL76ux7pKhloVPU1Ceh317zUnqpAZ/EqMHzIuMeI by3vRaw+Ly9BrQF5E0cBDpmbnkfnJNiOFgePvLm9jadbSznVCoZDgCxfdMd6yye+31RngIG3NwJ QE7JbmUKaYJKrT13EYQV6pV8tkes/Kmg357bzhOEITzR3KQ7ZJ/6gCNRJLj1Opc0nY67p4oS4hk PtfNDE6r1j4twEgPUx1FiHsZhaGn0yzZ03WeQs7nBC5ZrzEP/41MMY5V2siJmmearL1cNriPk39 XRvLY97Fi9MKEUjTH1INgxTNaA2d3oRI9IJkTKqGKm8+9q3YgTM/3xgJkplZOvmAo90Vuu27nhk e7e4FYbkTK+COSIyfmeGifFrtogaOW3idt+1QGPx2Nig== X-Received: by 2002:a05:600c:8286:b0:493:c42c:7e88 with SMTP id 5b1f17b1804b1-493c42c8307mr52961315e9.34.1782985646320; Thu, 02 Jul 2026 02:47:26 -0700 (PDT) From: Dusan Stojkovic Date: Thu, 02 Jul 2026 11:46:13 +0200 Subject: [PATCH RFC v3 2/2] vhost-user: implement VHOST_USER_PROTOCOL_F_XEN_MMAP MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260702-vhost-xen-foreign-mapping-v3-2-2b8ef913382b@rt-rk.com> References: <20260702-vhost-xen-foreign-mapping-v3-0-2b8ef913382b@rt-rk.com> In-Reply-To: <20260702-vhost-xen-foreign-mapping-v3-0-2b8ef913382b@rt-rk.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Stefano Garzarella , Stefano Stabellini , Anthony PERARD , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Viresh Kumar , Dusan Stojkovic , Nikola Jelic X-Mailer: b4 0.13.0 X-purgate-ID: tlsNG-720697/1782985646-4FB1F7C5-5DBB5988/0/0 X-purgate-type: clean X-purgate-size: 12093 From: Dusan Stojkovic The vhost-user specification reserves protocol feature bit 17 and documents an extended memory region description for backends that map guest memory through Xen rather than mapping a file descriptor each region carries two extra fields, "xen mmap flags" and "domid" (see docs/interop/vhost-user.rst, "Memory region description"). The layout is implemented by rust-vmm's vhost and vm-memory crates and used by Xen vhost-user device backends. Implement the front-end side for foreign mappings: - negotiate VHOST_USER_PROTOCOL_F_XEN_MMAP - when negotiated, build SET_MEM_TABLE payloads from the extended region layout, with xen_mmap_flags = FOREIGN and xen_mmap_data set to the guest's domain id. - under Xen, do not call vhost_user_get_mr_data(): guest RAM has no fd and its userspace_addr does not correspond to a valid mapping in the address space. Backends map regions through privcmd using the guest physical address and domid; the fd accompanying each region only satisfies the protocol's one-fd-per-region requirement. Pass a /dev/xen/privcmd fd and close it once the message has been sent. Tracepoints for opening and closing xen fds are added as well. - suppress VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS under Xen: Postcopy is likewise refused. The userspace_addr field is carried unchanged; Xen backends derive mappings from guest_phys_addr and domid and do not interpret it. Signed-off-by: Dusan Stojkovic Signed-off-by: Nikola Jelic --- hw/virtio/trace-events | 2 + hw/virtio/vhost-user.c | 120 +++++++++++++++++++++++++++++++++++++++-- include/hw/virtio/vhost-user.h | 2 +- 3 files changed, 120 insertions(+), 4 deletions(-) diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events index 2a57edc21e..0f3c58fd78 100644 --- a/hw/virtio/trace-events +++ b/hw/virtio/trace-events @@ -30,6 +30,8 @@ vhost_user_postcopy_fault_handler_found(int i, uint64_t region_offset, uint64_t vhost_user_postcopy_listen(void) "" vhost_user_set_mem_table_postcopy(uint64_t client_addr, uint64_t qhva, int reply_i, int region_i) "client:0x%"PRIx64" for hva: 0x%"PRIx64" reply %d region %d" vhost_user_set_mem_table_withfd(int index, const char *name, uint64_t memory_size, uint64_t guest_phys_addr, uint64_t userspace_addr, uint64_t offset) "%d:%s: size:0x%"PRIx64" GPA:0x%"PRIx64" QVA/userspace:0x%"PRIx64" RB offset:0x%"PRIx64 +vhost_user_open_region_fd(int index, int fd) "region:%d fd:%d" +vhost_user_put_region_fds(int index, int fd) "region:%d fd:%d" vhost_user_postcopy_waker(const char *rb, uint64_t rb_offset) "%s + 0x%"PRIx64 vhost_user_postcopy_waker_found(uint64_t client_addr) "0x%"PRIx64 vhost_user_postcopy_waker_nomatch(const char *rb, uint64_t rb_offset) "%s + 0x%"PRIx64 diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index d627351f45..932ead4eeb 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -30,6 +30,8 @@ #include "migration/postcopy-ram.h" #include "trace.h" #include "system/ramblock.h" +#include "system/xen.h" +#include "hw/xen/xen.h" #include #include @@ -181,12 +183,36 @@ typedef struct VhostUserMemoryRegion { uint64_t mmap_offset; } VhostUserMemoryRegion; +/* + * Memory region flags for VHOST_USER_PROTOCOL_F_XEN_MMAP, matching the + * values used by rust-vmm's vm-memory (MmapXenFlags). + */ +#define VHOST_USER_XEN_MMAP_FLAG_FOREIGN 0x1 +#define VHOST_USER_XEN_MMAP_FLAG_GRANT 0x2 + +/* + * Extended memory region description, used when + * VHOST_USER_PROTOCOL_F_XEN_MMAP has been negotiated. + */ +typedef struct VhostUserMemoryRegionXen { + VhostUserMemoryRegion region; + uint32_t xen_mmap_flags; + uint32_t xen_mmap_data; /* domain id for FOREIGN/GRANT mappings */ +} VhostUserMemoryRegionXen; + + typedef struct VhostUserMemory { uint32_t nregions; uint32_t padding; VhostUserMemoryRegion regions[VHOST_MEMORY_BASELINE_NREGIONS]; } VhostUserMemory; +typedef struct VhostUserMemoryXen { + uint32_t nregions; + uint32_t padding; + VhostUserMemoryRegionXen regions[VHOST_MEMORY_BASELINE_NREGIONS]; +} VhostUserMemoryXen; + typedef struct VhostUserMemRegMsg { uint64_t padding; VhostUserMemoryRegion region; @@ -294,6 +320,7 @@ typedef union { struct vhost_vring_state state; struct vhost_vring_addr addr; VhostUserMemory memory; + VhostUserMemoryXen memory_xen; VhostUserMemRegMsg mem_reg; VhostUserLog log; struct vhost_iotlb_msg iotlb; @@ -594,6 +621,8 @@ static MemoryRegion *vhost_user_get_mr_data(uint64_t addr, ram_addr_t *offset, static bool vhost_user_gpa_addresses(struct vhost_dev *dev) { return vhost_user_has_protocol_feature( + dev, VHOST_USER_PROTOCOL_F_XEN_MMAP) || + vhost_user_has_protocol_feature( dev, VHOST_USER_PROTOCOL_F_GPA_ADDRESSES); } @@ -612,6 +641,23 @@ static void vhost_user_fill_msg_region(struct vhost_dev *dev, dst->mmap_offset = mmap_offset; } +/* + * With VHOST_USER_PROTOCOL_F_XEN_MMAP the region fds are opened by us + * rather than owned by the RAMBlocks, so they must be closed once the + * message carrying them has been sent (or on error). + */ +static void vhost_user_put_region_fds(struct vhost_dev *dev, int *fds, + size_t fd_num) +{ + if (!vhost_user_has_protocol_feature(dev, VHOST_USER_PROTOCOL_F_XEN_MMAP)) { + return; + } + for (size_t i = 0; i < fd_num; i++) { + trace_vhost_user_put_region_fds(i, fds[i]); + close(fds[i]); + } +} + static int vhost_user_fill_set_mem_table_msg(struct vhost_user *u, struct vhost_dev *dev, VhostUserMsg *msg, @@ -623,13 +669,41 @@ static int vhost_user_fill_set_mem_table_msg(struct vhost_user *u, MemoryRegion *mr; struct vhost_memory_region *reg; VhostUserMemoryRegion region_buffer; + bool xen_mmap = vhost_user_has_protocol_feature(dev, + VHOST_USER_PROTOCOL_F_XEN_MMAP); + + if (track_ramblocks && xen_mmap) { + error_report("vhost-user: postcopy is not supported under Xen"); + return -ENOTSUP; + } msg->hdr.request = VHOST_USER_SET_MEM_TABLE; for (i = 0; i < dev->mem->nregions; ++i) { reg = dev->mem->regions + i; - mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); + if (xen_mmap) { + /* + * Under Xen the guest RAM is not mapped into our address + * space; the backend maps it through the Xen foreign + * mapping interface using the guest physical address and + * domain id carried in the region descriptor. The file + * descriptor only satisfies the one-fd-per-region + * requirement of the protocol: pass /dev/xen/privcmd and + * close it once the message has been sent. + */ + mr = NULL; + offset = 0; + fd = open("/dev/xen/privcmd", O_RDWR | O_CLOEXEC); + if (fd < 0) { + error_report("vhost-user: failed to open /dev/xen/privcmd:" + " %s", strerror(errno)); + return -errno; + } + trace_vhost_user_open_region_fd(i, fd); + } else { + mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); + } if (fd > 0) { if (track_ramblocks) { assert(*fd_num < VHOST_MEMORY_BASELINE_NREGIONS); @@ -642,10 +716,21 @@ static int vhost_user_fill_set_mem_table_msg(struct vhost_user *u, u->region_rb[i] = mr->ram_block; } else if (*fd_num == VHOST_MEMORY_BASELINE_NREGIONS) { error_report("Failed preparing vhost-user memory table msg"); + if (xen_mmap) { + close(fd); + } return -ENOBUFS; } vhost_user_fill_msg_region(dev, ®ion_buffer, reg, offset); - msg->payload.memory.regions[*fd_num] = region_buffer; + if (xen_mmap) { + msg->payload.memory_xen.regions[*fd_num].region = region_buffer; + msg->payload.memory_xen.regions[*fd_num].xen_mmap_flags = + VHOST_USER_XEN_MMAP_FLAG_FOREIGN; + msg->payload.memory_xen.regions[*fd_num].xen_mmap_data = + xen_domid; + } else { + msg->payload.memory.regions[*fd_num] = region_buffer; + } fds[(*fd_num)++] = fd; } else if (track_ramblocks) { u->region_rb_offset[i] = 0; @@ -663,7 +748,11 @@ static int vhost_user_fill_set_mem_table_msg(struct vhost_user *u, msg->hdr.size = sizeof(msg->payload.memory.nregions); msg->hdr.size += sizeof(msg->payload.memory.padding); - msg->hdr.size += *fd_num * sizeof(VhostUserMemoryRegion); + if (xen_mmap) { + msg->hdr.size += *fd_num * sizeof(VhostUserMemoryRegionXen); + } else { + msg->hdr.size += *fd_num * sizeof(VhostUserMemoryRegion); + } return 0; } @@ -1149,10 +1238,12 @@ static int vhost_user_set_mem_table(struct vhost_dev *dev, ret = vhost_user_fill_set_mem_table_msg(u, dev, &msg, fds, &fd_num, false); if (ret < 0) { + vhost_user_put_region_fds(dev, fds, fd_num); return ret; } ret = vhost_user_write(dev, &msg, fds, fd_num); + vhost_user_put_region_fds(dev, fds, fd_num); if (ret < 0) { return ret; } @@ -2551,6 +2642,29 @@ static int vhost_user_backend_init(struct vhost_dev *dev, void *opaque, VHOST_USER_PROTOCOL_F_GET_VRING_BASE_INFLIGHT); } + if (!xen_enabled()) { + /* + * Xen memory mappings only make sense when QEMU itself runs + * as a Xen device model. + */ + protocol_features &= ~(1ULL << VHOST_USER_PROTOCOL_F_XEN_MMAP); + } else { + if (!virtio_has_feature(protocol_features, + VHOST_USER_PROTOCOL_F_XEN_MMAP)) { + error_setg(errp, "vhost-user backend does not support " + "VHOST_USER_PROTOCOL_F_XEN_MMAP, which is " + "required when running under Xen"); + return -EPROTO; + } + /* + * The ADD/REM_MEM_REG message path has not been adapted to + * the Xen region format. Xen guests expose a single RAM + * region, so fall back to SET_MEM_TABLE. + */ + protocol_features &= + ~(1ULL << VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS); + } + /* final set of protocol features */ u->protocol_features = protocol_features; err = vhost_user_set_protocol_features(dev, u->protocol_features); diff --git a/include/hw/virtio/vhost-user.h b/include/hw/virtio/vhost-user.h index 06c360af18..46be9cd57c 100644 --- a/include/hw/virtio/vhost-user.h +++ b/include/hw/virtio/vhost-user.h @@ -30,7 +30,7 @@ enum VhostUserProtocolFeature { VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS = 14, VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS = 15, VHOST_USER_PROTOCOL_F_STATUS = 16, - /* Feature 17 reserved for VHOST_USER_PROTOCOL_F_XEN_MMAP. */ + VHOST_USER_PROTOCOL_F_XEN_MMAP = 17, VHOST_USER_PROTOCOL_F_SHARED_OBJECT = 18, VHOST_USER_PROTOCOL_F_DEVICE_STATE = 19, VHOST_USER_PROTOCOL_F_GET_VRING_BASE_INFLIGHT = 20, -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 09:48:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 09:48:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351539.1608699 (Exim 4.92) (envelope-from ) id 1wfE1l-0005fC-2x; Thu, 02 Jul 2026 09:48:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351539.1608699; Thu, 02 Jul 2026 09:48:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfE1k-0005f5-W6; Thu, 02 Jul 2026 09:48:12 +0000 Received: by outflank-mailman (input) for mailman id 1351539; Thu, 02 Jul 2026 09:48:11 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfE1j-0005cU-KE for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 09:48:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfE1i-006vJd-OL for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:48:10 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4633d1-e002-0a2a0a5209dd-0a2a450781e6-32 for ; Thu, 02 Jul 2026 11:48:10 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4633da-9c8e-0a2a45070019-d1558035a9ee-3 for ; Thu, 02 Jul 2026 11:48:10 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493c1950518so1949025e9.1 for ; Thu, 02 Jul 2026 02:48:10 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63ba971sm52031435e9.13.2026.07.02.02.48.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:48:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782985690; x=1783590490; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5cW6F1nZ+lIxLmSGu2x1m1g9gMm5tD08o7NGRsN9T1E=; b=Vw7Kr+JVAKumtsZzDbXf3XG8LaVJIuWDAc17vMfhub3qMc6cK5XJVsm8sJdkei844u dlsN7qKAdc6KFCxSKbmcP9uircaPwOMEyXxFp0p6ZmrcwiBKmGGy+plD3HH+yLRhW2et nxUIifvpSykN9S/z76G+fQgqnrhCno3dWNC2la+fSsQsmLKmCoq+o5pWKOsg9gyiy+fv uG9DZMK8I9BjpYNyByjQqkqwobLewAy+f5wY58jsr0Z3kBKy9KeTxCboPTYwZ0AmIPe8 P8a52yuHmwgnoxgpdcxX4gZJCFkay+3F/ctCAbQvGsrEbixgs61m8Uf/yJADrFmEhglo xRDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782985690; x=1783590490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5cW6F1nZ+lIxLmSGu2x1m1g9gMm5tD08o7NGRsN9T1E=; b=f06NAK9zKXuA9oeCFOYmr1H/DKb7OGToIsy8WeIUjRxYx9vBn5Vjw2Qq+hf4BVZrbV M/a5WgJijzZl6LHyi460gJgbXjjfcrpVK33cqdpZjFQF7hq6Yi1VBQf3lUn90hG/ItEf 9Gd+8xKu/Hja+txyrA5Sqwu63sge33E5cUtfn8QpTyG3dGb9ps2uMX67shFWojqGnsTy UR0RHCMmew/q2JqnKu6FN037mkfuHykyVGaRjcvqsZSaDxsaCKS4KL44qbt30sHdCFoe JrN1rAMrPpCOdbIqMvjsr6WU929o8YqyidlbH9I2EcVZiWovoihNfQTIP6a3JaWw676n FEsw== X-Forwarded-Encrypted: i=1; AHgh+Rr6Py9Rxmpi7zrMaZ070L27PTa3IQWA8oK1TJA9c8U7XJHycYlU7OLkn6RZZtAp2dG/h5q6yoeM6BM=@lists.xenproject.org X-Gm-Message-State: AOJu0YwRE9J5krDrLxUqo5Ru46bpvqYItIl0ttRb9xY0qeHWiVJLQjUs pvMlAUCYaPY2H14eeb2a6FCX3TtsNi3uaZePtgbZmZX5L8Njsjv8YguH X-Gm-Gg: AfdE7clvYyLtFLVYUzab5XHbW2baGOoPwp/HsDTbrcN/d1Pd+PQizYdhEZ0hU1/qtll n8QIokWY8y0OZ6JbqUiLc9wvgUVrp1nK1bvK1FQon8oqmo8iugDV8l7ZJgoW3ovvMHm1uYdmFp4 sU6TbnhA5RUJtOMaCPDE1CJ6IoS2rlkJ310ssDwb8Aoq2d7lGtJVspegs5jbamh6jOB+1uDcCWX 1+GZuVbO/hz8haM2QKc/Q4jVIhflQ3N+7mHKCfLV7+JiekLpOC8lK2vr5JOqPOas9+wgOEfjSAC y401lNf5ATOSKe799kLFixDIBG5/tHlzZTNGyhNlRlZeERfu4/108q+AYK/0AyV4I1+VwwWTT2Z DwF68/eidIdpsPoGO6aQUtR2DcxeBckJd8iB81nQ4gPCUAoxa8yQkUlwuE5QxA1A4glqgPwK5aw FbSIzJ8yQ8u/sXR4B2WsarAlwJRRg+P17+E8VP+nqMLjCCTk4IkfEfg8QfSwTA0hLSvnbrnvxp0 P4/Bw== X-Received: by 2002:a05:600c:6211:b0:493:c064:316f with SMTP id 5b1f17b1804b1-493c594ebedmr23053715e9.3.1782985689888; Thu, 02 Jul 2026 02:48:09 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 11:48:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 25/25] xen/riscv: add initial dom0less infrastructure support To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <131fc20c-1353-49fc-8f77-1ca13628ff17@suse.com> <2e3d404f-8716-4d0f-b739-d1e842b5a07c@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <2e3d404f-8716-4d0f-b739-d1e842b5a07c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1782985690-7CB2B25E-50C81BD2/10/73395122804 X-purgate-type: spam X-purgate-size: 2675 On 7/2/26 8:41 AM, Jan Beulich wrote: > On 01.07.2026 17:24, Oleksii Kurochko wrote: >> On 6/30/26 9:28 AM, Jan Beulich wrote: >>> On 26.06.2026 17:46, Oleksii Kurochko wrote: >>>> --- a/xen/arch/riscv/include/asm/guest-layout.h >>>> +++ b/xen/arch/riscv/include/asm/guest-layout.h >>>> @@ -32,4 +32,16 @@ >>>> #define GUEST_RAM_BANK_BASES { GUEST_RAM0_BASE, GUEST_RAM1_BASE } >>>> #define GUEST_RAM_BANK_SIZES { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE } >>>> >>>> +/* >>>> + * The guest magic region holds Xen-reserved pages mapped into the guest's >>>> + * physical address space (shared info, grant table, etc.). The only real >>>> + * constraint is that the GUEST_MAGIC_SIZE-byte region must not overlap >>>> + * guest RAM (the GUEST_RAMx banks) or the emulated device regions defined >>>> + * above; the exact base is otherwise arbitrary. Here it is placed in the >>>> + * unused gap below GUEST_RAM0_BASE (0x80000000), but a hole after a RAM >>>> + * bank would work equally well. >>>> + */ >>>> +#define GUEST_MAGIC_BASE _UL(0x79000000) >>>> +#define GUEST_MAGIC_SIZE _UL(0x01000000) >>> >>> ... while 16Mb may seem a lot, it feels pretty little for 64-bit guests. >>> Even in just Sv39 mode they have ample VA space to map a bigger region. >>> (As iirc indicated before, a static upper bound looks questionable to me >>> anyway.) >> >> I think the comment should be updated as for grants will be separate region. >> >> For all others, it looks like 16MB is more then enough. For example, Arm >> has only 4 used pages (CONSOLE=0, XENSTORE=1, MEMACCESS=2, VUART=3). > > Then the question goes the other way around: Why 16Mb? Won't e.g. 2Mb > suffice? I don't see any technical reason to have 16 Mb on Arm, IMO it could be shrunk to what you suggested (I will do that for RISC-V). ~ Oleksii > >> So will you be okay with reworking of the comment to: >> /* >> * The guest magic region holds the Xen-reserved pages mapped into the >> * guest's physical address space. The only real constraint on >> * GUEST_MAGIC_BASE/SIZE is that the region must not overlap guest RAM >> * (the GUEST_RAMx banks) or the emulated device regions defined above; >> * the exact base is otherwise arbitrary. Here it is placed in the >> unused gap >> * below GUEST_RAM0_BASE (0x80000000), but a hole after a RAM bank >> would work >> * equally well. >> */ >> >> And add to the commit message that: >> ``` >> A separate region for grant tables will be introduced at the same time >> as the introduction of the grant table for RISC-V. >> ``` > > That's quite a bit better, yes. > > Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:07:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:07:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351564.1608709 (Exim 4.92) (envelope-from ) id 1wfEKd-0001qs-OO; Thu, 02 Jul 2026 10:07:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351564.1608709; Thu, 02 Jul 2026 10:07:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfEKd-0001qJ-JQ; Thu, 02 Jul 2026 10:07:43 +0000 Received: by outflank-mailman (input) for mailman id 1351564; Thu, 02 Jul 2026 10:07:41 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfEKb-0001qD-Qb for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:07:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfEKb-00DXQI-6m for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:07:41 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a463862-2eae-0a2a0a5409dd-0a2a4506b782-38 for ; Thu, 02 Jul 2026 12:07:41 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46386b-08de-0a2a45060019-ac6904fee76c-3 for ; Thu, 02 Jul 2026 12:07:40 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 478A46001D; Thu, 2 Jul 2026 10:07:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D4E71F000E9; Thu, 2 Jul 2026 10:07:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782986859; bh=rYlxsT3EfvvJVMSpiElkKSMRxs3TOqthCAywxBW0128=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AUJ2SDXvs0VEdi5h/Kivbi3brTHkQLZzOc+/NAV87+f7C+JbSJugMOeorpgT3tHNL p58+v4CbXSREtEJG3hLwTa5n8p6G+p8Uf6kuVPNIUtEb3lILgd1rLCgiUeDjzt2+mZ zGpUePOrV+YiczwnsZiA+nTEa+dq7dVC2Ri5VUVSthC4z19IRHYTorV302BUc8jnc8 lzbpbbTR/gUCNSPcKQ4CL0UIE7YEz9VRE1nLkcyV3m++qYsnaX7iOq8PztYSNv6FrO w1VeEKbpH/fT7kvqY9QrCvgHPHHPFXTLBTuAr9eAkNY5WqMk3S9O4fQkBovR+Lq+yS W5zmwAV0MlSzg== Date: Thu, 2 Jul 2026 12:07:15 +0200 From: Ingo Molnar To: Sean Christopherson Cc: Arnd Bergmann , Juergen Gross , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-edac@vger.kernel.org" , x86@kernel.org, linux-acpi@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, linux-ide@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-crypto@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-hyperv@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , "lukasz.luba@arm.com" , Jason Baron , Borislav Petkov , Tony Luck , Yazen Ghannam , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , "Kirill A. Shutemov" , Rick Edgecombe , Pu Wen , Bjorn Helgaas , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Viresh Kumar , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Tony W Wang-oc , Damien Le Moal , Niklas Cassel , Dave Airlie , Helge Deller , linux-geode@lists.infradead.org, Olivia Mackall , Herbert Xu , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Guenter Roeck , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Josh Poimboeuf , Pawan Gupta , Vitaly Kuznetsov , Andy Lutomirski , Boris Ostrovsky , Huang Rui , Mario Limonciello , Perry Yuan , K Prateek Nayak , "srinivas.pandruvada@linux.intel.com" , Artem Bityutskiy , Artem Bityutskiy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Ashok Raj , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Rajneesh Bhardwaj , David E Box , xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces Message-ID: References: <20260629060526.3638272-1-jgross@suse.com> <7332feff-2649-496c-8e49-b0a19eb54a32@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-purgate-ID: tlsNG-16d1c6/1782986861-C493368D-C99CE1BD/0/0 X-purgate-type: clean X-purgate-size: 882 * Sean Christopherson wrote: > > Note that the individual patches are IMO significantly easier to review > > through the actual 32-bit => 64-bit variable assignment changes done > > in isolation (which sometimes include minor cleanups), while > > the Coccinelle semantic patch: > > > > { a(b,c) => c = a(b) } > > > > which changes both the function signature and the order of terms as > > well, is just a single add-on treewide patch. > > Is the plan for subsystem maintainers to pick up the relevant patches, > and then do the treewide change one release cycle later? I'll try to keep the patches in a single tree (tip:x86/msr) in the hope of not prolonging the pain two cycles - but it's of course fine for maintainers to pick up the patches too (most of them are standalone), we'll sort it all out in the end. Thanks, Ingo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:18:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:18:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351585.1608717 (Exim 4.92) (envelope-from ) id 1wfEUo-0004IF-MM; Thu, 02 Jul 2026 10:18:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351585.1608717; Thu, 02 Jul 2026 10:18:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfEUo-0004I8-It; Thu, 02 Jul 2026 10:18:14 +0000 Received: by outflank-mailman (input) for mailman id 1351585; Thu, 02 Jul 2026 10:18:13 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfEUn-0004Hz-CI for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:18:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfEUm-00DZBt-EL for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:18:12 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a463adf-e002-0a2a0a5209dd-0a2a4505c7e8-16 for ; Thu, 02 Jul 2026 12:18:12 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a463ae4-3cb2-0a2a45050019-d1558035ddca-3 for ; Thu, 02 Jul 2026 12:18:12 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493c2c0b9a8so10695155e9.1 for ; Thu, 02 Jul 2026 03:18:12 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef1807asm98365265e9.1.2026.07.02.03.18.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:18:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782987492; x=1783592292; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=asicmzSqEkS5SzRmJhqr3aSGxdsbzG03G4tjHfFmpH4=; b=fLJTXEAf3qxpwxXVfbVXy3b+q74oJLi1Ahbyk++jGXj9fwGAEee6Btgn4Ny0vb8snw yW58B/q+8WChiBQZ5TGJYwhamdFMoqRlHikUEQ/1u8uF0LW6IFJz8jssZzJ4S+SNZuV3 tHHVdG9zH1Y6AWf29zi7tfDEc2LDNTbf3e+Bb4mpGpMwcnWuSzLzNbTOhUob4mjPL4B2 arZwBv96mykDz70MkR806gD+ZbC0accZmsZH95LPOhmZR2zfwtLFVDhYKKVG2Gb/i++D j5zTvRTASELiW+VuVdvpCpBKVHiQ61e/7VtPaDPcyOdigqYCdv46ovh//yBh8uk9sq0p +v2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782987492; x=1783592292; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=asicmzSqEkS5SzRmJhqr3aSGxdsbzG03G4tjHfFmpH4=; b=SQU6mBj7b69DsItTNokS5LNaFp/+mey38nkKk+PC19x8xcDbep4LHjP/vCMuyOzER4 pbypRHng0eUeOgYnbT+F5Et39DurNKvmrXO4b6TzD621Sz1uQlrdagPMMXZX0i6UgOLx PVM+nNzD2rvRnppcjzNcrm1I1em5XJgXBoGAlHdfjIZq8p4Cu6aGDp0yet5II0ekF1wo UxLvBHjAlXtF7yVoN0IjIw9K7tNF6mxLe0vgkCHFm1sNGHrbaf/EQkQsaqZn9q0kkiom 92ERduibwXkGEMMupd/Z2kcDqKrk8Xdk5pujJmR/BiUP/BHudlviB8ZGAqNbp7G9OVfO JBQA== X-Forwarded-Encrypted: i=1; AFNElJ9nPwH7G37RdPnHLLfNrWxTAjqVetyu08LtiSZezz4BSIgFHWfEmNFnuVrfy8wYtVtLubqHrhrY5i0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxwdVfRSkATPCYI2FlGDCPE4ZMRJWPHG52E4oRanWQfFbIVejFI fM0/vK1HcT0LpgFyqNGiF/uxp4IPd5sGnrJwQT+tg844eJW1izTmrpNq X-Gm-Gg: AfdE7cmgnzynZF3DdTIbWcNgKxiqn+gfp1WFehtqgFXnojCVc/muoTPP2pDGTkDCfMW nMh1Z+IUQURNPEOaGoLtn/gybj3uVC9T8xy2JsELjvxV4Sxk8BQoTFoEPR0LJD1En62wsgXZt5u Ye4G/X3ZtEt9iGiHA7Y2GDVrGl45QMI4CLF82dMRGyRy7w6elMBHzRCTVzeIRLJnodSQmLcxz3U 8ReyoGsqfKkx5f4j/eZYFdxAioeyLtbXKxdjjOZc59CxAQco79GqUTsKDbV7UEg7JPnFP5f7FIW gcZ7uVdTj6VZcDOE6Djvh1YmE+5/voqUtSpkS4ybvRZqHBG2K/UJHAMX8ZDRB1rJOJHQUbp3T3g +GDoeT/6FyMRRScmUWu0hs01DLjuTRUqB5+MmrbOaYOk7zq0JDNH5QfrG13g8d/xAKwwLXAGw3R GI43bjRIoNR96byap5XPrIAqEjjQTDF7ycHoGqcKtAzdu5kjRoV9S03YHAvKQyGhvb+7U= X-Received: by 2002:a05:600c:5681:b0:493:bc92:ba9a with SMTP id 5b1f17b1804b1-493c3cd9c4cmr44809895e9.13.1782987491717; Thu, 02 Jul 2026 03:18:11 -0700 (PDT) Message-ID: <1aeabffc-0087-4e59-a8ae-7cd20be4761d@gmail.com> Date: Thu, 2 Jul 2026 12:18:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] lib: make safe_copy_string_from_guest() validate input To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Daniel Smith References: <80bc4e83-b767-4692-9ce1-0ebf68d7ab26@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <80bc4e83-b767-4692-9ce1-0ebf68d7ab26@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1782987492-0FB192B8-AAFE3081/10/73395122804 X-purgate-type: spam X-purgate-size: 4231 On 7/1/26 4:48 PM, Jan Beulich wrote: > ... rather than papering over guest flaws: Strings passed ought to be nul- > terminated (yet sadly libxc hasn't been doing so thus far). This way we > also avoid order-1 allocations, seeing that all present callers pass > PAGE_SIZE for max_size. > > Signed-off-by: Jan Beulich > --- > I can't spot any caller side use of FLASK_DEVICETREE_LABEL, hence there's > no corresponding prereq patch. > > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -7,6 +7,8 @@ The format is based on [Keep a Changelog > ## [4.23.0 UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD > > ### Changed > + - XEN_DOMCTL_DEV_DT's, FLASK_[GS]ETBOOL's, and FLASK_DEVICETREE_LABEL's input > + string sizes need to include the nul terminator. > Acked-by: Oleksii Kurochko # Changelog > ### Added > > --- a/xen/lib/guest-strcpy.c > +++ b/xen/lib/guest-strcpy.c > @@ -3,8 +3,8 @@ > #include > > /* > - * The function copies a string from the guest and adds a NUL to > - * make sure the string is correctly terminated. > + * The function copies a string from the guest and checks there's a NUL > + * terminating the string. > */ > char *safe_copy_string_from_guest(XEN_GUEST_HANDLE(char) u_buf, > size_t size, size_t max_size) > @@ -14,8 +14,7 @@ char *safe_copy_string_from_guest(XEN_GU > if ( size > max_size ) > return ERR_PTR(-ENOBUFS); > > - /* Add an extra +1 to append \0 */ > - tmp = xmalloc_array(char, size + 1); > + tmp = xmalloc_array(char, size); > if ( !tmp ) > return ERR_PTR(-ENOMEM); > > @@ -24,7 +23,12 @@ char *safe_copy_string_from_guest(XEN_GU > xfree(tmp); > return ERR_PTR(-EFAULT); > } > - tmp[size] = '\0'; > + > + if ( !memchr(tmp, 0, size) ) > + { > + xfree(tmp); > + return ERR_PTR(-EMSGSIZE); > + } > > return tmp; > } > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -574,7 +574,7 @@ struct xen_domctl_assign_device { > uint32_t machine_sbdf; /* machine PCI ID of assigned device */ > } pci; > struct { > - uint32_t size; /* Length of the path */ > + uint32_t size; /* Length of the path, including nul terminator */ > XEN_GUEST_HANDLE_64(char) path; /* Path to the device tree node */ > #ifdef __XEN__ > struct dt_device_node *dev; /* Resolved device node of the above */ > --- a/xen/include/public/xsm/flask_op.h > +++ b/xen/include/public/xsm/flask_op.h > @@ -26,7 +26,8 @@ typedef struct xen_flask_setenforce xen_ > struct xen_flask_sid_context { > /* IN/OUT: sid to convert to/from string */ > uint32_t sid; > - /* IN: size of the context buffer > + /* > + * IN: size of the context buffer, including nul terminator > * OUT: actual size of the output context string > */ > uint32_t size; > @@ -86,8 +87,11 @@ struct xen_flask_boolean { > uint8_t new_value; > /* IN: commit new value instead of only setting pending [SET] */ > uint8_t commit; > - /* IN: size of boolean name buffer [GET/SET] > - * OUT: actual size of name [GET only] */ > + /* > + * IN: size of boolean name buffer [GET/SET]; must cover nul terminator > + * if "name" (below) is an input > + * OUT: actual size of name [GET only] > + */ > uint32_t size; > /* IN: if bool_id is -1, used to find boolean [GET/SET] > * OUT: textual name of boolean [GET only] > @@ -150,7 +154,7 @@ typedef struct xen_flask_relabel xen_fla > struct xen_flask_devicetree_label { > /* IN */ > uint32_t sid; > - uint32_t length; > + uint32_t length; /* length of the path, including nul terminator */ > XEN_GUEST_HANDLE(char) path; > }; > typedef struct xen_flask_devicetree_label xen_flask_devicetree_label_t; > Reviewed-by: Oleksii Kurochko Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:22:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351601.1608726 (Exim 4.92) (envelope-from ) id 1wfEYT-0005wO-5M; Thu, 02 Jul 2026 10:22:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351601.1608726; Thu, 02 Jul 2026 10:22:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfEYT-0005wG-1R; Thu, 02 Jul 2026 10:22:01 +0000 Received: by outflank-mailman (input) for mailman id 1351601; Thu, 02 Jul 2026 10:22:00 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfEYS-0005wA-4W for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:22:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfEYR-00CSD2-Hf for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:21:59 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a463bc5-5cb7-0a2a0a5109dd-0a2a45049e16-4 for ; Thu, 02 Jul 2026 12:21:59 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a463bc5-a01d-0a2a45040019-888fbc335294-3 for ; Thu, 02 Jul 2026 12:21:58 +0200 Received: by mx.zohomail.com with SMTPS id 1782987707484235.51031824193228; Thu, 2 Jul 2026 03:21:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1782987711; cv=none; d=zohomail.com; s=zohoarc; b=Erf+OR88YGH7B33E9ch2qAhCtGGsfCsPMoEIbVC+vurj185iySuOiI3psNr3kGL5iMITufCSMpZP2klH1tAvb/hGIMHnimCp2vNOtnrEBHHENMoBqbB8g4vzIZW0ydzvOapoIZIi7MkIcooGUPTd7ppN7+1wRdCMn9v3a0UoRnY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782987711; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=vIAPMhBu82ubtuLXA6Cfj915g3ip0b/QqrhVvOeWe6s=; b=g5rt67UgzxSmQqYeFgECM7EHEEfq9iA+mWjzItyXmxH/+rLNh/cgkSLyIicAfqjAXr4AAc5gKN/52NML2kiJX9IBZhxeWnhgoemKf5T1GHsH5HXRNtrkNs5pcrGBiH1bx7zYZ4W2aCkbf0BtiLgppb3aEHDIKtthrdZaOm6ToeA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782987711; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=vIAPMhBu82ubtuLXA6Cfj915g3ip0b/QqrhVvOeWe6s=; b=CpZddfSWDo2i7vEP16AJ6GuEW+NSVFTjXoJa+uXJGfXjOKD5oVp4iQsd0zk/dVxw cF0NSMOgAiR8ASeGOnFDOsCh3pJvZ1JUDOT627wCdoviNN7P2hCVEcMGe1Fb8pQQmqP J/8+lO45Em0HzmMp0icrTXKtmLbyfA6t+KmeUc5Y= Message-ID: <70b66c05-29bb-44f3-b105-3d85aa44b032@apertussolutions.com> Date: Thu, 2 Jul 2026 06:21:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] libxc: drop size parameter from xc_flask_context_to_sid() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony PERARD , Juergen Gross , Marek Marczykowski References: Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-purgate-ID: tlsNG-ebf023/1782987719-AD13E1CC-EA2F2633/0/0 X-purgate-type: clean X-purgate-size: 4045 On 7/1/26 10:47 AM, Jan Beulich wrote: > Nul-terminated strings are passed in all cases, so the strlen() can very > well be invoked by the function itself. In preparation for a hypervisor > change also include the nul terminator in the size calculation. > > Signed-off-by: Jan Beulich > Acked-by: Marek Marczykowski-Górecki > --- > Ideally libxl_flask_context_to_sid() would follow suit, but aiui doing so > would break its (stable) API. > > Of course the casts in xc_flask_access() are suspicious. > --- > v2: Avoid assert() use in libxl. > > --- a/tools/helpers/init-xenstore-domain.c > +++ b/tools/helpers/init-xenstore-domain.c > @@ -108,7 +108,7 @@ static int build(xc_interface *xch) > > if ( flask ) > { > - rv = xc_flask_context_to_sid(xch, flask, strlen(flask), &config.ssidref); > + rv = xc_flask_context_to_sid(xch, flask, &config.ssidref); > if ( rv ) > { > fprintf(stderr, "xc_flask_context_to_sid failed\n"); > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2372,7 +2372,7 @@ long xc_sharing_used_frames(xc_interface > /*** End sharing interface ***/ > > int xc_flask_load(xc_interface *xc_handle, char *buf, uint32_t size); > -int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t size, uint32_t *sid); > +int xc_flask_context_to_sid(xc_interface *xc_handle, char *buf, uint32_t *sid); > int xc_flask_sid_to_context(xc_interface *xc_handle, int sid, char *buf, uint32_t size); > int xc_flask_getenforce(xc_interface *xc_handle); > int xc_flask_setenforce(xc_interface *xc_handle, int mode); > --- a/tools/libs/ctrl/xc_flask.c > +++ b/tools/libs/ctrl/xc_flask.c > @@ -83,10 +83,11 @@ int xc_flask_load(xc_interface *xch, cha > return err; > } > > -int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t size, uint32_t *sid) > +int xc_flask_context_to_sid(xc_interface *xch, char *buf, uint32_t *sid) > { > int err; > struct xen_flask_op op = {}; > + size_t size = strlen(buf) + 1; > DECLARE_HYPERCALL_BOUNCE(buf, size, XC_HYPERCALL_BUFFER_BOUNCE_IN); > > if ( xc_hypercall_bounce_pre(xch, buf) ) > @@ -249,7 +250,7 @@ static int xc_flask_add(xc_interface *xc > int err; > struct xen_flask_op op = {}; > > - err = xc_flask_context_to_sid(xch, scontext, strlen(scontext), &sid); > + err = xc_flask_context_to_sid(xch, scontext, &sid); > if ( err ) > return err; > > @@ -325,10 +326,10 @@ int xc_flask_access(xc_interface *xch, c > struct xen_flask_op op = {}; > int err; > > - err = xc_flask_context_to_sid(xch, (char*)scon, strlen(scon), &op.u.access.ssid); > + err = xc_flask_context_to_sid(xch, (char*)scon, &op.u.access.ssid); > if ( err ) > return err; > - err = xc_flask_context_to_sid(xch, (char*)tcon, strlen(tcon), &op.u.access.tsid); > + err = xc_flask_context_to_sid(xch, (char*)tcon, &op.u.access.tsid); > if ( err ) > return err; > > --- a/tools/libs/light/libxl_flask.c > +++ b/tools/libs/light/libxl_flask.c > @@ -21,7 +21,10 @@ int libxl_flask_context_to_sid(libxl_ctx > { > int rc; > > - rc = xc_flask_context_to_sid(ctx->xch, buf, len, ssidref); > + if (len != strlen(buf)) > + return ERROR_INVAL; > + > + rc = xc_flask_context_to_sid(ctx->xch, buf, ssidref); > > return rc; > } > --- a/tools/python/xen/lowlevel/xc/xc.c > +++ b/tools/python/xen/lowlevel/xc/xc.c > @@ -1754,7 +1754,7 @@ static PyObject *pyflask_context_to_sid( > return PyErr_SetFromErrno(xc_error_obj); > } > > - ret = xc_flask_context_to_sid(xc_handle, ctx, strlen(ctx), &sid); > + ret = xc_flask_context_to_sid(xc_handle, ctx, &sid); > > xc_interface_close(xc_handle); > > Reviewed-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:53:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:53:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351631.1608734 (Exim 4.92) (envelope-from ) id 1wfF31-0003nG-Gy; Thu, 02 Jul 2026 10:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351631.1608734; Thu, 02 Jul 2026 10:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF31-0003n9-EA; Thu, 02 Jul 2026 10:53:35 +0000 Received: by outflank-mailman (input) for mailman id 1351631; Thu, 02 Jul 2026 10:53:34 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF30-0003mx-FX for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:53:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfF2z-006AId-KE for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:53:33 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46432d-2eae-0a2a0a5409dd-0a2a450bdc78-0 for ; Thu, 02 Jul 2026 12:53:33 +0200 Received: from [209.85.221.52] (helo=mail-wr1-f52.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46432d-ac48-0a2a450b0019-d155dd34b043-3 for ; Thu, 02 Jul 2026 12:53:33 +0200 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-472326ca506so1212877f8f.2 for ; Thu, 02 Jul 2026 03:53:33 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477dd94cb64sm8013869f8f.23.2026.07.02.03.53.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:53:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Content-Language:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782989613; x=1783594413; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=WHZrdIaIr/Qonp/FQk8s4CA8XTn74JzLmvsThtsbxFU=; b=Wu8eT+cLAghd5mT98HZc/e+P5K+TTIwE1q72DVXUrj+DECscaXNY95qaoYUpXQX5qo KBI59t4b59/cZBIrh28xCg/mtBspWh9N69WWbQeiIOUEz4bI30kzF/78Pr4RUPEENyWe okGk3b42jDmu1OR9tF9Xo+LORwX0TpskeWhqLwB2Hrb47ZyteYn4AqlmEgYHFBneYrXx O37DWNBN/EpgQEC5dwdCYgcnDkDGergw8KW1ixJYaIGTdeMjuFCLvzsPC0qJQHCPSZKA 2Rfoa+R6warED4KiLEz6+oSzXuwYRU96sAVjdW81z+FeICrPOeq/luTso/NwdeGWzUWp Rcqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989613; x=1783594413; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WHZrdIaIr/Qonp/FQk8s4CA8XTn74JzLmvsThtsbxFU=; b=g6RgUlcb87E3wTBKmx7w7lgZy26TW9miWgTxfqXXZhi/Xr9FTkw33bl5Yv7kLqXV7G 7II1j2/eMFucvImtJTDuBl/TCu2MFm6fVn9YNZmOSdEU9eEQDEB/azdEycNSrS1Qr7ke 73RCmOptxbnyeVGLenh1JWWoBL6gPM6lYPOhOFoTA10ES6E6oGA4e4o0F/X/zXHVntLy eMwvvW+7x15hnCKx8nz8PSsI0t3wNuZBRooI9rRytDGgmXFo/WInGPZtMpQP8MkrBwjF aZdec2enuFxeuZ/M2BnHf3Z181ZAxJ06bFITkARSysmQoN5qhqgj5F8BXajWR31HaU7p dIDA== X-Gm-Message-State: AOJu0Yz4tMBQtrG2Fh/XHJBZ+juulHnrGcrsIFqEgenPwGuq56AjeBe1 qlTjbs8hB9lTcZUYU6iP0t9GppOT3jVHKz9l1J8zIAJiN1WKywewhGFwGzTvw80/ilgnvmjkZUp PFPfN8g== X-Gm-Gg: AfdE7ckUVeXk3JF4+C/Q3oiEldaKilAHjoJdsuXk9Df4tdq9Wr5y1L9ZTOBMbdZ/b9O rFHPCAVP2BwWsAzx9PZopQJ5wcm8WD3UFSahoLZwnH7dJdMzTKqUzPI795nCkOpst6aJhyXMmaL 9NqHyajgogGRGpJnUsGsuq2s/LH1FXqP9oSyge6D5RCPMzyVZfoVtcOz9jn5gbNckCvfVVORsku apX+9Gl4m+nWhvaiYFE6WF4iK6sxpsH034BgUrrQazrVF7vyIMQj2vo33IjQ2pvMCIS04tobzNn 6Qg34fQPtLMjLu4L3eSdCJH8xFbx2KEBbaDzoFrWhwYaBLLKh2uyU2weXKH0mt8tANc04/LhRXR hAe2i6Curd2T8y+wahr9+7O87woj6D7g1lV7OhStr998TwSzyH2nWf1fXm0Rh4Mo91FJUrHrlgQ f6Do5TPjNydbe5b94kwALoqjJxLnZ3DysE32AyJLgLhlQQfNNknGQcmzGvsA3j+06HciFIyDuDm 9BC X-Received: by 2002:a5d:5d82:0:b0:475:f0f0:9ef8 with SMTP id ffacd0b85a97d-4775b930513mr8613725f8f.61.1782989613072; Thu, 02 Jul 2026 03:53:33 -0700 (PDT) Message-ID: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Date: Thu, 2 Jul 2026 12:53:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v3 0/4] x86: CET-SS related adjustments To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1782989613-3AB38220-FB1BC830/0/0 X-purgate-type: clean X-purgate-size: 472 One might think of this as follow-on to XSA-451, but that's not quite the right order of events. There are a few open aspects; see in particular the final patch. v3 addresses review feedback, which includes one new (prereq) patch. See individual patches for details. 1: HVM: don't (almost) open-code POP_GPRS 2: record SSP at non-guest entry points 3: traps: use entry_ssp in fixup_exception_return() 4: prefer shadow stack for producing call traces Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:55:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:55:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351640.1608744 (Exim 4.92) (envelope-from ) id 1wfF4U-0004Ob-SN; Thu, 02 Jul 2026 10:55:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351640.1608744; Thu, 02 Jul 2026 10:55:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF4U-0004OU-PF; Thu, 02 Jul 2026 10:55:06 +0000 Received: by outflank-mailman (input) for mailman id 1351640; Thu, 02 Jul 2026 10:55:05 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF4T-0004OJ-8T for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:55:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfF4S-00DX1f-LM for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:55:04 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46437d-5cb7-0a2a0a5109dd-0a2a45019694-16 for ; Thu, 02 Jul 2026 12:55:04 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a464388-400f-0a2a45010019-d155802eb435-3 for ; Thu, 02 Jul 2026 12:55:04 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-493c733f15aso3068285e9.0 for ; Thu, 02 Jul 2026 03:55:04 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63648d7sm38769855e9.7.2026.07.02.03.55.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:55:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782989704; x=1783594504; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ilPQpTG0pa/hptnKJjw2or04R0MiCz+VtMpqPju/z7U=; b=MzfErFCR1KZYRbAUzlKUhQAM0yXaLQObwtOc+bf2+v83c3Ha6Ae8XM1bcJIVHBxk21 1Q7NGb7M0rCNTncidw4TfIadmZvtbWR+utHk5uMYf8S03IxCJE/bOuiYRi938KkZ/XcV X7Yn7/qKwZyM/pQt86FOwuvOg26DC+NmuIBxp+6HWV9SlQb/Lf00sXOy+Ecs9NWiCccJ bC2Z4OS7xB04k+dYCif7gpsp41TgS2gEzDendTKFdapgz0HwkZSUK8Ei+rUmW5YR5qpN h2UOF1ycRg74fUbKR/BkVQ1BmgGePwv/oR+MXHX3SWQgYb9VobNRs2k2rXPRbtih/dN0 i/rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989704; x=1783594504; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ilPQpTG0pa/hptnKJjw2or04R0MiCz+VtMpqPju/z7U=; b=R/gZai3fNVLow6ATnXWg8ysR40SFRp7CKZl2B0QW66xJr/w2NPtwo7WDFJlodUgFSF HEat85efDSgOoAZAmfx641trTLfKrft8n4bfeRh86FO+KzLrdp1yUFvjfnS12430jmr2 WLBidvu3cT50vkrnc0xybvTumlVsfW8a0UFBHP16gse0beQ5+MIx9HGvKBOpsx59Nm9q Fj5FFVAu/CvdiG2X9ZBBgGhoih1py9bNYtPptx3F7P4lPHNXcrF8Wun10FY+8e2bHaKN 5WADvzIOJ3QtXGV70TNalNe+H/6IJauQPle1qha1PdCrcS9kiDhlZvSz47WrNajSmIR0 8eUQ== X-Gm-Message-State: AOJu0Yy31TK1OfjEv4S9vYZ5rTiJom068rDXGHT27TRHPt3JbvfUKJBQ V/067eFpXmBeIhaDXOFR72/5ZCKeIhJtnm6I6r2kHWcaDLICkvUKER5PheKs5yyjNgSyHpBbK39 QcOBHuA== X-Gm-Gg: AfdE7cl49xZs/R4OBYanJILRwLBj9Mt7teveHn4OYMQrbk7sD4iGzouY1R+Fwb160R7 OFI/q8DKLYYwbN78mCKg+YELUVynVZWvPX2aG5SHYV59ST45eTfxFLbe+6CBe7NRnHi3INKOdJJ RSD2MrhbB3EDzSeVlxjaUW95S4kicR7rT6uK1l3DnQyjr8Rw/TY5S7YLf0zREwGcEq1Q4iVQ5Y2 7YWonuUVD62ZVo47TG0s79jHz64m4D6Iv7kWJynMcEClU2fFlp93ECTEsJdIe91ZSUmeL6BdC2p N2A/Xqh1Dbq+BmK5Y78wSjXTq1QSCUhWABSdeje02Msk0yffmpG24i75ZA5izaoOwLVadTsm+oO 00twBSD+n0K+VL6qET0OBJH8CK/DGg8u91xrO1yowkytF05HnWHthXYrHcgvvefPlDazZyjTU70 tP0GVpJoXEFUzCT6bBS4QnbkTlhrW0hqHLIdJkIbzl8M/D31QgBng9e8JZaovXD+aF5S3juc4st bVK X-Received: by 2002:a05:600c:19cd:b0:493:bcba:3d5f with SMTP id 5b1f17b1804b1-493c63ab8e9mr26066305e9.13.1782989703898; Thu, 02 Jul 2026 03:55:03 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 12:55:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 1/4] x86/HVM: don't (almost) open-code POP_GPRS From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1782989704-D06D61E0-A81DC4AA/0/0 X-purgate-type: clean X-purgate-size: 2268 It can be used as-is for VMX. For SVM the special treatment of %rax needs accounting for. Signed-off-by: Jan Beulich --- This is the minimum required as a prereq to the next patch (to avoid the need for custom adjustments in the two places). We could go further and switch to using PUSH_AND_CLEAR_GPRS at the same time. --- v3: New. --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -82,22 +82,8 @@ __UNLIKELY_END(nsvm_hap) */ sti - pop %r15 - pop %r14 - pop %r13 - pop %r12 - pop %rbp mov VCPU_svm_vmcb_pa(%rbx),%rax - pop %rbx - pop %r11 - pop %r10 - pop %r9 - pop %r8 - pop %rcx /* Skip %rax: restored by VMRUN. */ - pop %rcx - pop %rdx - pop %rsi - pop %rdi + POP_GPRS skip_rax=1 /* %rax restored by VMRUN. */ SPEC_CTRL_COND_VERW /* Req: %rsp=eframe Clob: efl */ --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -139,21 +139,7 @@ UNLIKELY_END(realmode) and $SCF_verw, %eax or %eax, %ecx - pop %r15 - pop %r14 - pop %r13 - pop %r12 - pop %rbp - pop %rbx - pop %r11 - pop %r10 - pop %r9 - pop %r8 - pop %rax - pop %rcx - pop %rdx - pop %rsi - pop %rdi + POP_GPRS /* Preserves flags. */ jpe .L_skip_verw /* VERW clobbers ZF, but preserves all others, including SF. */ --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -357,7 +357,7 @@ static always_inline void stac(void) /* * POP GPRs from a UREGS_* frame on the stack. Does not modify flags. */ -.macro POP_GPRS +.macro POP_GPRS skip_rax=0 pop %r15 pop %r14 pop %r13 @@ -368,7 +368,11 @@ static always_inline void stac(void) pop %r10 pop %r9 pop %r8 + .if \skip_rax + pop %rcx + .else pop %rax + .endif pop %rcx pop %rdx pop %rsi From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:55:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:55:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351643.1608753 (Exim 4.92) (envelope-from ) id 1wfF4o-0004lp-4D; Thu, 02 Jul 2026 10:55:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351643.1608753; Thu, 02 Jul 2026 10:55:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF4o-0004li-0v; Thu, 02 Jul 2026 10:55:26 +0000 Received: by outflank-mailman (input) for mailman id 1351643; Thu, 02 Jul 2026 10:55:24 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF4l-0004id-Vd for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:55:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfF4l-005SNi-Bz for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:55:23 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a464398-bab6-0a2a0a5309dd-0a2a4507b412-24 for ; Thu, 02 Jul 2026 12:55:23 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46439b-9c8e-0a2a45070019-d155dd2dace7-3 for ; Thu, 02 Jul 2026 12:55:23 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47122683cf3so1234215f8f.0 for ; Thu, 02 Jul 2026 03:55:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477ddf0f310sm7709053f8f.31.2026.07.02.03.55.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:55:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782989722; x=1783594522; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=LVZ9L1TPFh7mEp2xecv7V5O5RSUvEp2Ng8R7qCS66ME=; b=PmLNavicnZHp8i3D+d8nIzbEowiVuG2MUXaJiMrxQtk7cuWHYWWXkpvHH4BUgN9dW7 Kx23DbEk+wq91PGnjxwYLos+biErTJa91Kb4psDd7GM4NHk0GB9wF4dtxCe7FjR3bd0I OH6uFLfWB26eb+lEUbTxH7ocpeYu1GG2QFpV3w4s6cy6mVmYAcLGXLx0GjUNGKaoHLEm ZeJNrB3mcc3pYmdKryyWany7OfX26vS8wAnBjXe1zS+f9/rrCYKwd9QHVjNHJKhI+Zjj BmI7kPRbSq+M/U8PLfetVLVRiGBiVgkedGpaHek+lw28RehDL6HO85stcRP78AcNbCD8 ksdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989722; x=1783594522; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LVZ9L1TPFh7mEp2xecv7V5O5RSUvEp2Ng8R7qCS66ME=; b=cyahNBXJv6Abm+x+64YIL8+7fnDX5S1pOrFe+WTOAe7L+ZbUH4ya9zIunSWtRLIt9D XPNQ0PL7jMYQ4ie6Cwxj57SJXneY3U0VaIs4GYrUkUlEczpe2PxNgHx6NhYoEQJ6Vcdk qa3p3slzmJT0Is67GVmjdfWTJP8awr6zEX9h5i1QWA2YEjApv5o5JeJTSay/ri3rVlm5 siEg7FtydwWTYAL1Sv2LN6UFH1EE+9x0xLSJMQ7CCSAn+O2zJUmLgsZMDqtB+k5yTwvZ nge/c1FE7tf2Ot8IJoEI/dEMR/BH/U5Rpbz+ems+E6PA9mp0eA3WRGMj9j8pdtCyEVRU CrnQ== X-Gm-Message-State: AOJu0YxyNCq/1Ncoc7VRW3v0DdenPDGDAgOKIgNf0y8qXF1H+iM7GPOv gpsEuzIqu1GnaGPwbAaD2xcltOEX7pWBgkLXk3bbD01T1erzqYsCajzYJp+etT0m0a/Q9SM8jEe diJX/vA== X-Gm-Gg: AfdE7cmXcJBstqcssbxGTDzKIdoNN3nCdJdaOkOIFlF4/KqaEPucmPzsWoKeLNMtSNO w6FTXaw4LMFKKCWgu17PiLHwFmlzGN/kLRyLZOCzCFuxyK8coOZXJN0tscZ9P4fsW2SH2zDyiNL mfb+1nL/gkGy9xewWB8HlA8zjyUboONTD/C8v7iZzVvI1d4qyYuFoxNdWv6zBOR1PxSzaLvwtjy YOuU7L4YKieXlef/OX9lPxSqDCP1OJJqjJb2VGehK+6Jhh72F7U9fMeekS9ObAfpS8Qxuuxl+8B 94YzEVuQpw+VcIRUvTpJOrG5aQtmeSG52WeaO3ROPK2njyWnoSCqtmMzir0G+zmOwfo4jAFnM/c ow0keIrbgXe1Nz/kw3TplNfgzZ3I1f+PuBT/KiP9ZEl3Ni/an8gAJKA5q0jR+nwXEtKBVQeRqje 6pjJigJk+0PiJ80zUmnH9O0FC+XrkdeVWCDVEFD6KCCU5uZfu5bx/C/jF/155/RhIoVAARXZloV x1v X-Received: by 2002:a05:6000:240c:b0:46e:6210:ad4a with SMTP id ffacd0b85a97d-47757e57e77mr8219284f8f.5.1782989722576; Thu, 02 Jul 2026 03:55:22 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 12:55:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 2/4] x86: record SSP at non-guest entry points From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1782989723-FDB2325E-7A3E1B2E/0/0 X-purgate-type: clean X-purgate-size: 6838 We will want to use that value for call trace generation, and likely also to eliminate the somewhat fragile shadow stack searching done in fixup_exception_return(). For those purposes, guest-only entry points do not need to record that value. To keep the saving code simple, record our own SSP that corresponds to an exception frame, pointing to the top of the shadow stack counterpart of what the CPU has saved on the regular stack. Consuming code can then work its way from there. In SAVE_ALL / RESTORE_ALL simply drop the use of UREGS_r15. We want the full size in all cases, so what exactly the top-of-stack field is going to be (whose UREGS_* is 0 anyway) doesn't matter this much there. This way we don't need to distinguish between XEN_SHSTK=y and XEN_SHSTK=n. Signed-off-by: Jan Beulich --- v3: Put new field at the front of struct cpu_user_regs. v2: Add comment ahead of SAVE_ALL. Add comma between its parameters. Re-base. --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -89,7 +89,7 @@ __UNLIKELY_END(nsvm_hap) vmrun - SAVE_ALL + SAVE_ALL ssp=0 GET_CURRENT(bx) --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -22,7 +22,7 @@ #include FUNC(vmx_asm_vmexit_handler) - SAVE_ALL + SAVE_ALL ssp=0 mov %cr2,%rax GET_CURRENT(bx) @@ -157,7 +157,7 @@ UNLIKELY_END(realmode) .Lvmx_vmentry_fail: sti - SAVE_ALL + SAVE_ALL ssp=0 /* * SPEC_CTRL_ENTRY notes --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -219,8 +219,12 @@ static always_inline void stac(void) #endif #ifdef __ASSEMBLER__ -.macro SAVE_ALL compat=0 - addq $-(UREGS_error_code-UREGS_r15), %rsp +/* + * Use sites may override ssp to 0. It should never be overridden to 1. + * NB: compat=1 implies ssp=0. + */ +.macro SAVE_ALL compat=0, ssp=IS_ENABLED(CONFIG_XEN_SHSTK) + addq $-UREGS_error_code, %rsp cld movq %rdi,UREGS_rdi(%rsp) xor %edi, %edi @@ -233,6 +237,9 @@ static always_inline void stac(void) movq %rax,UREGS_rax(%rsp) xor %eax, %eax .if !\compat +.if \ssp + rdsspq %rcx +.endif movq %r8,UREGS_r8(%rsp) movq %r9,UREGS_r9(%rsp) movq %r10,UREGS_r10(%rsp) @@ -262,6 +269,9 @@ static always_inline void stac(void) xor %r13d, %r13d xor %r14d, %r14d xor %r15d, %r15d +#ifdef CONFIG_XEN_SHSTK + mov %rcx, UREGS_entry_ssp(%rsp) +#endif .endm #define LOAD_ONE_REG(reg, compat) \ @@ -309,13 +319,15 @@ static always_inline void stac(void) LOAD_ONE_REG(dx, \compat) LOAD_ONE_REG(si, \compat) LOAD_ONE_REG(di, \compat) - subq $-(UREGS_error_code-UREGS_r15+\adj), %rsp + subq $-(UREGS_error_code + \adj), %rsp .endm /* - * Push and clear GPRs + * Push and clear GPRs. + * + * Use sites may override ssp to 0. It should never be overridden to 1. */ -.macro PUSH_AND_CLEAR_GPRS +.macro PUSH_AND_CLEAR_GPRS ssp=IS_ENABLED(CONFIG_XEN_SHSTK) push %rdi xor %edi, %edi push %rsi @@ -326,6 +338,9 @@ static always_inline void stac(void) xor %ecx, %ecx push %rax xor %eax, %eax + .if \ssp + rdsspq %rcx + .endif push %r8 xor %r8d, %r8d push %r9 @@ -352,12 +367,18 @@ static always_inline void stac(void) xor %r14d, %r14d push %r15 xor %r15d, %r15d +#ifdef CONFIG_XEN_SHSTK + push %rcx +#endif .endm /* * POP GPRs from a UREGS_* frame on the stack. Does not modify flags. */ .macro POP_GPRS skip_rax=0 +#ifdef CONFIG_XEN_SHSTK + pop %rcx +#endif pop %r15 pop %r14 pop %r13 --- a/xen/arch/x86/include/asm/cpu-user-regs.h +++ b/xen/arch/x86/include/asm/cpu-user-regs.h @@ -11,6 +11,15 @@ */ struct cpu_user_regs { +#ifdef CONFIG_XEN_SHSTK + /* + * This points _at_ the corresponding shadow stack frame; it is _not_ the + * outer context's SSP. That, if the outer context has CET-SS enabled, + * is stored in the top slot of the pointed to shadow stack. + */ + uint64_t entry_ssp; +#endif + union { uint64_t r15; uint32_t r15d; uint16_t r15w; uint8_t r15b; }; union { uint64_t r14; uint32_t r14d; uint16_t r14w; uint8_t r14b; }; union { uint64_t r13; uint32_t r13d; uint16_t r13w; uint8_t r13b; }; --- a/xen/arch/x86/x86_64/asm-offsets.c +++ b/xen/arch/x86/x86_64/asm-offsets.c @@ -53,6 +53,9 @@ void __dummy__(void) OFFSET(UREGS_eflags, struct cpu_user_regs, rflags); OFFSET(UREGS_rsp, struct cpu_user_regs, rsp); OFFSET(UREGS_ss, struct cpu_user_regs, ss); +#ifdef CONFIG_XEN_SHSTK + OFFSET(UREGS_entry_ssp, struct cpu_user_regs, entry_ssp); +#endif DEFINE(UREGS_kernel_sizeof, sizeof(struct cpu_user_regs)); BLANK(); --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -304,7 +304,7 @@ FUNC(lstar_enter) pushq $0 BUILD_BUG_ON(TRAP_syscall & 0xff) movb $TRAP_syscall >> 8, EFRAME_entry_vector + 1(%rsp) - SAVE_ALL + SAVE_ALL ssp=0 GET_STACK_END(14) @@ -344,7 +344,7 @@ FUNC(cstar_enter) pushq $0 BUILD_BUG_ON(TRAP_syscall & 0xff) movb $TRAP_syscall >> 8, EFRAME_entry_vector + 1(%rsp) - SAVE_ALL + SAVE_ALL ssp=0 GET_STACK_END(14) @@ -388,7 +388,7 @@ LABEL(sysenter_eflags_saved, 0) pushq $0 BUILD_BUG_ON(TRAP_syscall & 0xff) movb $TRAP_syscall >> 8, EFRAME_entry_vector + 1(%rsp) - SAVE_ALL + SAVE_ALL ssp=0 GET_STACK_END(14) @@ -444,7 +444,7 @@ FUNC(entry_int80) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0 movb $0x80, EFRAME_entry_vector(%rsp) - SAVE_ALL + SAVE_ALL ssp=0 GET_STACK_END(14) --- a/xen/arch/x86/x86_64/entry-fred.S +++ b/xen/arch/x86/x86_64/entry-fred.S @@ -11,7 +11,7 @@ /* The Ring3 entry point is required to be 4k aligned. */ FUNC(entry_FRED_R3, 4096) - PUSH_AND_CLEAR_GPRS + PUSH_AND_CLEAR_GPRS ssp=0 mov %rsp, %rdi call entry_from_pv @@ -54,7 +54,7 @@ LABEL(eretu, 0) END(eretu_exit_to_guest) FUNC(eretu_error_dom_crash) - PUSH_AND_CLEAR_GPRS + PUSH_AND_CLEAR_GPRS ssp=0 sti call asm_domain_crash_synchronous /* Does not return */ END(eretu_error_dom_crash) From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:55:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:55:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351652.1608763 (Exim 4.92) (envelope-from ) id 1wfF55-0005GB-Cw; Thu, 02 Jul 2026 10:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351652.1608763; Thu, 02 Jul 2026 10:55:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF55-0005G4-8n; Thu, 02 Jul 2026 10:55:43 +0000 Received: by outflank-mailman (input) for mailman id 1351652; Thu, 02 Jul 2026 10:55:42 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF53-0005Cy-U6 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:55:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfF53-005SQm-Ai for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:55:41 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4643a0-bab6-0a2a0a5309dd-0a2a45078f00-16 for ; Thu, 02 Jul 2026 12:55:41 +0200 Received: from [209.85.221.46] (helo=mail-wr1-f46.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4643ad-9c8e-0a2a45070019-d155dd2eec47-3 for ; Thu, 02 Jul 2026 12:55:41 +0200 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-476a130c138so1548930f8f.0 for ; Thu, 02 Jul 2026 03:55:41 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477de3dcf59sm8095181f8f.34.2026.07.02.03.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:55:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782989741; x=1783594541; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=v/oOuLNsb9sp/2KN0lUVF17VXE209vMr5egGnhDKc+8=; b=QSciwZm4Sqjo8HcN3GFTnHote/Ra7qMd14YkrQLee5zAAvkTv82OUXgeuLQ7rJRHdL wUzmOc4bZu7wXpak+iKvRv7vFFt/f5gcX5I10PdQx3spqrw4nD/JVIk8XRHiwF3iSzQS BBu4ocYe4Su66/CnKhVx7C196L+lW03Odk9QkIaUpCpfRnd3oBUWBeFEPELmrbDtT1CW GHnALswW+tO5gYU8pOiYr6OtMU1A+a7/qw/YZ6Bi4565lVRn18Qo0vqTKYA4qT0bk1s1 ZRSLPzjrXwQGCNTaXmiso6n0LTwtkn3vQQ6p2h3pI1s6F65X0YOsV1Hos1sPwVph5XAs BkbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989741; x=1783594541; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=v/oOuLNsb9sp/2KN0lUVF17VXE209vMr5egGnhDKc+8=; b=gvr4Hf0JcZl53EqtnnMm8PZdWITNe6ntjQkHYK6U6AZpJNxJg0qOWY677X7Uj7HrOM PXK0bF0zWyIYNWmEewFZN7tS1qiG9/Q5Jz27mJEou6oZXdLzrK5YeExndehv1Og7pclu ggVWkLyGA0GSiooPK7KF1s/gZj2C0S5Ecfj0X4LJcT4VvvEbjHZW2KgW4dXg/8Con5xC 7ll0upuzLT9uf4JBpimxtupEUvIrl83GhrswjbMhS5xaJJAVJ4kz4Zkp+lD7FvTaZJhy 56iJ72hjimYsAcuGaLP4N6Tohi2tbMbuQlMsGZSul2lvmBGemIIidM7wNliO9PJKOPTe 1fEw== X-Gm-Message-State: AOJu0YwjR8Xyi2+PlTIaRlRAMf72VHAwlqca1pR1y5CG8V7QVvySYdkU Jm0ZYHLahvisDz0TiMOZK46JoD2+L9s5KOgm/h90nik8DWXeBXcfC2uEZw3imJV8DKX/iHqa4Jm lIczSqA== X-Gm-Gg: AfdE7ckIJ0u3oeQGE8y8wA/Ot2DGrvWEHuwWdf36xjjSqZFYBBpAN7jjaaGM+qSmMyM QAn+8yveSYSsALb7UZ5fyr6E9TrCh1UVLjFFWdfx4vro304ru3vOJFcGpoRwyFF8GCBMATEnq2N QqaWaSDxHKZ0AqkUJfSN0buj9v/xk4Yh86Uzk9inc6DuLftCKz3HygVCl+o1Eq/MFiFp6LqF11A 5J8MrZXVSplfuRUFn0E15Gzk1oAIlH+9zeVMq0Y6NY+Sr5+1AnAwoFyQQZBKON6ut/UirrPGInD vQ8piYhM/FjkniS71UzdVLJlZHia6fSqSoIjrPE1RA0Z6+VpEE7TjhYUBuhQ+72w7XE3mZv6dkI DPXTXtxjy361IybuyiLFmhfCLGiCmqPiK/L9SYbYXSKufS8RsVluCZeRM7BdNUvKyEOj65cQRLj +wc5twcX1TYLzXbdas6jawumAyIwoXXmcB9jJYhuRlur96pTqwaIwbDKlG9wnqiqThtCKmXD7yO j5c X-Received: by 2002:a5d:5f56:0:b0:470:390c:1e73 with SMTP id ffacd0b85a97d-477b39839cbmr7299589f8f.18.1782989740669; Thu, 02 Jul 2026 03:55:40 -0700 (PDT) Message-ID: <8af61c08-71f9-4d18-ba9c-952b7894c44d@suse.com> Date: Thu, 2 Jul 2026 12:55:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 3/4] x86/traps: use entry_ssp in fixup_exception_return() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1782989741-7DB2325E-58462B72/0/0 X-purgate-type: clean X-purgate-size: 5876 With the value recorded on entry there's no need anymore to go hunt for the respective exception frame on the shadow stack. By deriving "ptr" from that field (without any offset), it then ends up pointing one slot lower than before. Therefore all array indexes need incrementing, nicely doing away with all the negative ones. Signed-off-by: Jan Beulich --- Indentation of the prior inner (but not innermost) if()'s body is deliberately left untouched, to aid review. It'll be adjusted in a separate follow-on patch. --- v3: Relax the first BUG_ON(). v2: IS_ENABLED() -> #ifdef. Re-base. --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -690,19 +690,6 @@ unsigned long get_stack_trace_bottom(uns } } -static unsigned long get_shstk_bottom(unsigned long sp) -{ - /* SAF-11-safe */ - switch ( get_stack_page(sp) ) - { -#ifdef CONFIG_XEN_SHSTK - case 0: return ROUNDUP(sp, IST_SHSTK_SIZE) - sizeof(unsigned long); - case 5: return ROUNDUP(sp, PAGE_SIZE) - sizeof(unsigned long); -#endif - default: return sp - sizeof(unsigned long); - } -} - unsigned long get_stack_dump_bottom(unsigned long sp) { switch ( get_stack_page(sp) ) @@ -1187,26 +1174,29 @@ void asmlinkage noreturn do_unhandled_tr static void fixup_exception_return(struct cpu_user_regs *regs, unsigned long fixup, unsigned long stub_ra) { - if ( IS_ENABLED(CONFIG_XEN_SHSTK) ) +#ifdef CONFIG_XEN_SHSTK { - unsigned long ssp, *ptr, *base; + unsigned long ssp = rdssp(); - if ( (ssp = rdssp()) == SSP_NO_SHSTK ) - goto shstk_done; + if ( ssp != SSP_NO_SHSTK ) + { + unsigned long *ptr = _p(regs->entry_ssp); + unsigned long primary_shstk = + (ssp & ~(STACK_SIZE - 1)) + + (PRIMARY_SHSTK_SLOT + 1) * PAGE_SIZE - 8; - ptr = _p(ssp); - base = _p(get_shstk_bottom(ssp)); + BUG_ON((regs->entry_ssp ^ primary_shstk) >> + (PAGE_SHIFT + STACK_ORDER)); - for ( ; ptr < base; ++ptr ) - { /* - * Search for %rip. The shstk currently looks like this: + * The shstk currently looks like this: * * tok [Supervisor token, == &tok | BUSY, only with FRED inactive] * ... [Pointed to by SSP for most exceptions, empty in IST cases] * %cs [== regs->cs] * %rip [== regs->rip] - * SSP [Likely points to 3 slots higher, above %cs] + * SSP [Pointed to by entry_ssp; Likely points to 3 slots + * higher, above %cs] * ... [call tree to this function, likely 2/3 slots] * * and we want to overwrite %rip with fixup. There are two @@ -1219,13 +1209,10 @@ static void fixup_exception_return(struc * * Check for both regs->rip and regs->cs matching. */ - if ( ptr[0] == regs->rip && ptr[1] == regs->cs ) - { - unsigned long primary_shstk = - (ssp & ~(STACK_SIZE - 1)) + - (PRIMARY_SHSTK_SLOT + 1) * PAGE_SIZE - 8; + BUG_ON(ptr[1] != regs->rip || ptr[2] != regs->cs); - wrss(fixup, ptr); + { + wrss(fixup, &ptr[1]); if ( !stub_ra ) goto shstk_done; @@ -1242,7 +1229,7 @@ static void fixup_exception_return(struc * - if we're on an IST stack, we need to increment the * original SSP. */ - BUG_ON((ptr[-1] ^ primary_shstk) >> PAGE_SHIFT); + BUG_ON((ptr[0] ^ primary_shstk) >> PAGE_SHIFT); if ( (ssp ^ primary_shstk) >> PAGE_SHIFT ) { @@ -1251,39 +1238,30 @@ static void fixup_exception_return(struc * addresses actually match. Then increment the interrupted * context's SSP. */ - BUG_ON(stub_ra != *(unsigned long*)ptr[-1]); - wrss(ptr[-1] + 8, &ptr[-1]); + BUG_ON(stub_ra != *(unsigned long*)ptr[0]); + wrss(ptr[0] + 8, &ptr[0]); goto shstk_done; } /* Make sure the two return addresses actually match. */ - BUG_ON(stub_ra != ptr[2]); + BUG_ON(stub_ra != ptr[3]); /* Move exception frame, updating SSP there. */ - wrss(ptr[1], &ptr[2]); /* %cs */ - wrss(ptr[0], &ptr[1]); /* %rip */ - wrss(ptr[-1] + 8, &ptr[0]); /* SSP */ + wrss(ptr[2], &ptr[3]); /* %cs */ + wrss(ptr[1], &ptr[2]); /* %rip */ + wrss(ptr[0] + 8, &ptr[1]); /* SSP */ /* Move all newer entries. */ - while ( --ptr != _p(ssp) ) - wrss(ptr[-1], &ptr[0]); + while ( ptr-- != _p(ssp) ) + wrss(ptr[0], &ptr[1]); /* Finally account for our own stack having shifted up. */ asm volatile ( "incsspd %0" :: "r" (2) ); - - goto shstk_done; } } - - /* - * We failed to locate and fix up the shadow IRET frame. This could - * be due to shadow stack corruption, or bad logic above. We cannot - * continue executing the interrupted context. - */ - BUG(); - } shstk_done: +#endif /* CONFIG_XEN_SHSTK */ /* Fixup the regular stack. */ regs->rip = fixup; From xen-devel-bounces@lists.xenproject.org Thu Jul 02 10:56:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 10:56:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351659.1608770 (Exim 4.92) (envelope-from ) id 1wfF5N-0005lO-Md; Thu, 02 Jul 2026 10:56:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351659.1608770; Thu, 02 Jul 2026 10:56:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF5N-0005lF-K6; Thu, 02 Jul 2026 10:56:01 +0000 Received: by outflank-mailman (input) for mailman id 1351659; Thu, 02 Jul 2026 10:56:00 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfF5M-0005jW-6p for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 10:56:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfF5L-005SZh-J2 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:55:59 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4643ae-5cb7-0a2a0a5109dd-0a2a450bcd14-28 for ; Thu, 02 Jul 2026 12:55:59 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4643bf-ac48-0a2a450b0019-d1558030b18d-3 for ; Thu, 02 Jul 2026 12:55:59 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493b7612475so13560495e9.3 for ; Thu, 02 Jul 2026 03:55:59 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477dbe617b1sm7898518f8f.16.2026.07.02.03.55.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:55:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782989759; x=1783594559; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=y40rikzKdW41I0gcKC+jqL54qXX/dn+hAUR30HB1xyE=; b=eh7Q7K2qOy6U8kyHHoMlBLcaCpYUYEXasesUO+v22GXrh85ks2gWvTGrJxszC4uFXL U2yQm+v31PYfsVhlmRVOGTlkKnHGvWWcF9v26fatcEF+6XFeI9CNcgMHVhMELU3YXWfW 0p8kQPLzvoTQVqtcwUHOb8y2OHfcGI3EyAJI5jx7w67SxBvPACpQGKYqP7wEErXjF0Uq pG21wNG6ZcR2fD6WMdW5U1a1QT84NBYPX6Jh1JZ8Gk6BPBa/yLHwV2gOlKHamqeWEySJ JbA0hlHxHweXO9f6IKEpKGkt+c423OahOmHPFZp0dKIGK6kUf1b7NLbyPM2iDDz8HOwM wncg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989759; x=1783594559; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y40rikzKdW41I0gcKC+jqL54qXX/dn+hAUR30HB1xyE=; b=Os6dZxCuPeBPM2L5BHEiYDkNgy1rtkRsQy1xnvSFRW7CEmTsIuQue+fIh6NCzqNjkH xfjfsGQIh39T3x/O1+SAwSrHSgu94bwRSZ0RIgJvNLdI3xk7txG2ji0YAlhT6hP/iM6b Qeq+oEa3iICAPyWGnUauD6veyr6cH+zq35OWBzoNxpdjsPe7G3Vheqc2IxzVrNYYXWsM KBrs7lpP+s87sn0WhoVYwK9rMmLWc8Pict9lTn+a80CwqYAUyr4OvwPj/TfkfW1uQV0h /vTndmDHYM/3Mtx2ojg45wnanyy2+ZyDqzWwZoied/CqImBsD7bFAmy1wioU2KHz4wjo lspQ== X-Gm-Message-State: AOJu0Yyl/uTkwoLs4XJod1M43mCnEVXc1dF6LcoUtFylQFaaew0fwroJ s1jsRfLqefNkN2vmTHCJPDGxBsEg8eWjjIEaFVkK3VNCSjL7z3vN3Wg9qxSYOqNGFLlZKoXDYe4 PpmK0zg== X-Gm-Gg: AfdE7ckQhybl4zb0k61r51PansW7a85LEtgvIS2drbL1tN8dkKeYsfe0+jmjBNWkdTN letBbw5XLYgoPkrKFyNKpW2vUy+xvAYWtsL4U6h1SstVPvNBMYopaeA+C5FDflyLjHtMqqCkdRJ b9gq5u4O8JzdWdpfwyoaN1AhnNNN/VZxkIrTmm34eSZtsfq0HenTK4u2chvfNcb4DpEA3PhUf+o KcM8yAGobIiSx62CvzJxQxYn1umFcxEPsAUy4SjroUnt4HXfcp3i916OAWuLwjrZfTP2fne5ntb Mk61JYOxGDl9m7sQo82T576ffhOobjhAwbusgQ1DIkSsTV0iBvpASbNdC4QZlWKlaUQCr+uRlps b/gA+n3b3KQFlVdOJurVuI2Olo5FOt3A4rmc/gxfqcJqejtzs3r942QeSYG5OkYamwVZcQqWfM+ 3/vV6SukEB8a3avIRldWJ53/olpBJdtdJV8k0Ueu/b3AH1R9FQYoZskOtsOha2wi+0A30oenQ54 hSh X-Received: by 2002:a05:600d:c:b0:493:aa28:38ad with SMTP id 5b1f17b1804b1-493c2b4442emr58140175e9.10.1782989758979; Thu, 02 Jul 2026 03:55:58 -0700 (PDT) Message-ID: <3ed270eb-4417-4340-a3da-f06704b27047@suse.com> Date: Thu, 2 Jul 2026 12:55:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 4/4] x86: prefer shadow stack for producing call traces From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1782989759-A6939220-6047AE3A/0/0 X-purgate-type: clean X-purgate-size: 4605 Shadow stacks contain little more than return addresses, and they in particular allow precise call traces also with FRAME_POINTER=n: (XEN) Xen call trace: (XEN) [] R extable.c#search_one_extable+0x70/0x73 (XEN) [] C search_exception_table+0xc2/0x177 (XEN) [] C traps.c#extable_fixup.isra.0+0x18/0x6c (XEN) [] C do_invalid_op+0xab/0x106 (XEN) [] C x86_64/entry.S#handle_exception_saved+0x88/0xf4 (XEN) [] E ffff82d07fffe044 (XEN) [] C stub_selftest+0xd0/0x168 (XEN) [] C setup.c#init_done+0x116/0x15a as opposed to this counterpart (earlier during the same boot, before CET is enabled): (XEN) Xen call trace: (XEN) [] R extable.c#search_one_extable+0x70/0x73 (XEN) [] S search_exception_table+0xc2/0x177 (XEN) [] S traps.c#extable_fixup.isra.0+0x18/0x6c (XEN) [] S do_invalid_op+0xab/0x106 (XEN) [] S x86_64/entry.S#handle_exception_saved+0x88/0xf4 (XEN) [] S stub_selftest+0xd0/0x168 (XEN) [] S do_initcalls+0x29/0x38 (XEN) [] S __start_xen+0x1c72/0x2235 (XEN) [] S __high_start+0xb7/0xc0 (note the entirely missing entry for the stub itself [1]; sadly there are no stray entries there). [1] Arguably we could teach FRAME_POINTER=n traces to recognize stubs as well. But not FRAME_POINTER=y ones. In fact, what's missing there isn't the stub itself, but (of course) its immediate caller. Signed-off-by: Jan Beulich --- While the 'E' for exception frames is probably okay, I'm not overly happy with the 'C' (for CET). I would have preferred 'S' (for shadow), but we use that character already. As an alternative to suppressing output for the top level exception frame, adding the new code ahead of the 'R' output line (and then also ahead of the stack top read) could be considered. Quite likely a number of other uses of is_active_kernel_text() also want amending with in_stub(). --- v3: Correct "link to other shadow stack" check. Don't log a line for the (impossible) PV case. Add example stack trace to description. v2: IS_ENABLED() -> #ifdef. Re-base. --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -48,6 +48,7 @@ #include #include #include +#include #include #include #include @@ -705,6 +706,13 @@ unsigned long get_stack_dump_bottom(unsi } } +#ifdef CONFIG_XEN_SHSTK +static bool in_stub(unsigned long addr) +{ + return !((this_cpu(stubs.addr) ^ addr) >> STUB_BUF_SHIFT); +} +#endif + #if !defined(CONFIG_FRAME_POINTER) /* @@ -797,6 +805,49 @@ static void show_trace(const struct cpu_ !is_active_kernel_text(tos) ) printk(" [<%p>] R %pS\n", _p(regs->rip), _p(regs->rip)); +#ifdef CONFIG_XEN_SHSTK + if ( rdssp() != SSP_NO_SHSTK ) + { + const unsigned long *ptr = _p(regs->entry_ssp); + unsigned int n; + + for ( n = 0; (unsigned long)ptr & (PAGE_SIZE - sizeof(*ptr)); ++n ) + { + unsigned long val = *ptr; + + if ( is_active_kernel_text(val) || in_stub(val) ) + { + /* Normal return address entry. */ + printk(" [<%p>] C %pS\n", _p(val), _p(val)); + ++ptr; + } + else if ( !((val ^ (unsigned long)ptr) >> + (PAGE_SHIFT + STACK_ORDER)) ) + { + if ( val & (sizeof(val) - 1) ) + { + /* Most likely a supervisor token. */ + break; + } + + /* + * Ought to be a hypervisor interruption frame. But don't + * (re)log the current frame's %rip. + */ + if ( n || ptr[1] != regs->rip ) + printk(" [<%p>] E %pS\n", _p(ptr[1]), _p(ptr[1])); + ptr = _p(val); + } + else /* Bogus. */ + break; + } + + /* Fall back to legacy stack trace if nothing was logged at all. */ + if ( n ) + return; + } +#endif /* CONFIG_XEN_SHSTK */ + if ( fault ) { printk(" [Fault on access]\n"); From xen-devel-bounces@lists.xenproject.org Thu Jul 02 11:04:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 11:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351682.1608779 (Exim 4.92) (envelope-from ) id 1wfFD3-00087i-EH; Thu, 02 Jul 2026 11:03:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351682.1608779; Thu, 02 Jul 2026 11:03:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFD3-00087b-B4; Thu, 02 Jul 2026 11:03:57 +0000 Received: by outflank-mailman (input) for mailman id 1351682; Thu, 02 Jul 2026 11:03:55 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFD1-00087S-NU for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:03:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfFD1-00EHdV-3s for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:03:55 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46458a-5cb7-0a2a0a5109dd-0a2a4509e760-42 for ; Thu, 02 Jul 2026 13:03:55 +0200 Received: from [209.85.218.49] (helo=mail-ej1-f49.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46459a-97e6-0a2a45090019-d155da31e93c-3 for ; Thu, 02 Jul 2026 13:03:54 +0200 Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-c125bce2294so190443966b.3 for ; Thu, 02 Jul 2026 04:03:54 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-698acf25f4dsm809220a12.8.2026.07.02.04.03.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 04:03:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782990234; x=1783595034; darn=lists.xenproject.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=rLAZ6xjWSh4dBeXXx+Zm/8773z7w6ApW8uj4atG+Tbg=; b=LBiRMxWG+FZ52cMMMjq5O9hBOm2zx6eYt5u1oe+g+JmwXL1BU9K+wX7H17VW+Gu6BE YTpAVbojm1JZ7Mt3olRouHpC82UWKESg4GQ/P5h3qmlCPCSqt6yKE7bdHf5Q4IKotYnf /1aV1gbRGxnPEo6PuF+3j5UQ819kPpgz+/IPXbDjQpa1lrZquyNx6h3FWeqk9oNUF4lN sDO4+hOqVkLAkqAMZVEdUmcza2KjYE4M8afwABH3mZcGkKPY3UHRXMq12y4UzSmkz3m1 /7FcbHSJN6xmuX0IquDjBdIpnyDGZRrZ9D212gqIjx75hCxogVAbV37baepqc7ad/zU/ XrHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782990234; x=1783595034; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rLAZ6xjWSh4dBeXXx+Zm/8773z7w6ApW8uj4atG+Tbg=; b=ZTavBXcf7w4u3VvFlyUujiJAJvRb4tllbQ+nswRY7UWuE0o5B9Y5nhAmJlIujaNJ4G +HWeBovLayToUVFPoG/XVgooEopo7MOushtp060Roq6wzHEYQAH18vIiTu3IqAaoKBop M+TYc0rVnsEseKPU/sMEsCbWkMsGx12EvGlGIPwNEbS8DVDrFz1noTA+nY/JKR8kD4Rh 1qJwJp81beJIQ18eRD0V9jWXM84EVo0hw24h9Z6wrU6cmQBheTm+Vagcc1qF3U46UIRb LYc03sivr+aAEh97ZdozuIzQR9UufZ/bZJMU+b9LQk+/v7RawdwA3tshJfJ5rKyk8CF7 gt5A== X-Forwarded-Encrypted: i=1; AHgh+Rr8FUXupv15d6I5VE5DKgV9DeaHlCOkl8aBDXddzBSaEh9nnyE0yHFXP5o4puV7km0eiRq7NT04GNc=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzqmi/9rEYf5/W64FQlqoENeWd+8x/3wHIDrjlxA1Vijz6DQJPW NrrpUfDeQWspWmBZ0pIvjwyO+U8kHZMaz+vUr4FAE+leAhJRCXeL4agDlXtz+NHVzxI= X-Gm-Gg: AfdE7cnj5J87Hr4ViXkNGL1qVdWzDHUzPfqWJ7DdzSSHPoUm6gSgC3izMZkAY/WYPDW R+CB9xMli8mLSVW22JAz4y2VvwxXXLDEf2wq1MaI7WbRxbIDAYccRRKISmnqs4RU4qMO3fxmonR wnjYEvfpsXD8GB72TulWXFolA3aQukh8Y952p2h4uM6n39Ms37eVNb95iyu674rQr+maskWH1R/ p0wMizXmXc99lGbwvfE+2nZzs1LRUl8IWnCiRwnSJiGe4PSwL4VMWEokcHdQWWswnHgbdytNSif GLyVfQpIc0d0BnsxuzJGrIFfrHiwAPJKfxX5W7w+kgSelTJKNzLa53QQrJ7ILd1aRkkmbe+tWBb O8yDOFUj/lBU1hsWx+pp1K2BfYuv702uegheOk4YyjtgJVt/GnE7++Y9wUY+rJ0hkdBo4qQwMiq OnwGXbxO792lufDL+D5LkD/houd3QXNem5ioVgcdPU06ZV9AeaVzWj8Zcy4vn63Xa9hVga0oXMu PwwkArM1eA/WMPrBWuP4GsP+3WIQI1i1U8AKiHqZGY= X-Received: by 2002:a17:907:e14b:10b0:c12:3143:864f with SMTP id a640c23a62f3a-c12ae47556cmr180127966b.2.1782990234377; Thu, 02 Jul 2026 04:03:54 -0700 (PDT) Message-ID: <99228803-b8b7-47a3-b77c-6fdf3b785730@suse.com> Date: Thu, 2 Jul 2026 13:03:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces To: Ingo Molnar , Sean Christopherson Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-edac@vger.kernel.org" , x86@kernel.org, linux-acpi@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, linux-ide@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-crypto@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-hyperv@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , "lukasz.luba@arm.com" , Jason Baron , Borislav Petkov , Tony Luck , Yazen Ghannam , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , "Kirill A. Shutemov" , Rick Edgecombe , Pu Wen , Bjorn Helgaas , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Viresh Kumar , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Tony W Wang-oc , Damien Le Moal , Niklas Cassel , Dave Airlie , Helge Deller , linux-geode@lists.infradead.org, Olivia Mackall , Herbert Xu , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Guenter Roeck , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Josh Poimboeuf , Pawan Gupta , Vitaly Kuznetsov , Andy Lutomirski , Boris Ostrovsky , Huang Rui , Mario Limonciello , Perry Yuan , K Prateek Nayak , "srinivas.pandruvada@linux.intel.com" , Artem Bityutskiy , Artem Bityutskiy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Ashok Raj , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Rajneesh Bhardwaj , David E Box , xen-devel@lists.xenproject.org References: <20260629060526.3638272-1-jgross@suse.com> <7332feff-2649-496c-8e49-b0a19eb54a32@app.fastmail.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WjZXb44KsATEDkDSufWy2bKk" X-purgate-ID: tlsNG-bad1c0/1782990235-56FA9986-78970A30/0/0 X-purgate-type: clean X-purgate-size: 11511 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WjZXb44KsATEDkDSufWy2bKk Content-Type: multipart/mixed; boundary="------------o2fircZpb09tU1GMO2GxqgPd"; protected-headers="v1" From: Juergen Gross To: Ingo Molnar , Sean Christopherson Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-edac@vger.kernel.org" , x86@kernel.org, linux-acpi@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, linux-ide@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-crypto@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-hyperv@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , "lukasz.luba@arm.com" , Jason Baron , Borislav Petkov , Tony Luck , Yazen Ghannam , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , "Kirill A. Shutemov" , Rick Edgecombe , Pu Wen , Bjorn Helgaas , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Viresh Kumar , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Tony W Wang-oc , Damien Le Moal , Niklas Cassel , Dave Airlie , Helge Deller , linux-geode@lists.infradead.org, Olivia Mackall , Herbert Xu , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Guenter Roeck , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Josh Poimboeuf , Pawan Gupta , Vitaly Kuznetsov , Andy Lutomirski , Boris Ostrovsky , Huang Rui , Mario Limonciello , Perry Yuan , K Prateek Nayak , "srinivas.pandruvada@linux.intel.com" , Artem Bityutskiy , Artem Bityutskiy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Ashok Raj , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Rajneesh Bhardwaj , David E Box , xen-devel@lists.xenproject.org Message-ID: <99228803-b8b7-47a3-b77c-6fdf3b785730@suse.com> Subject: Re: [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces References: <20260629060526.3638272-1-jgross@suse.com> <7332feff-2649-496c-8e49-b0a19eb54a32@app.fastmail.com> In-Reply-To: --------------o2fircZpb09tU1GMO2GxqgPd Content-Type: multipart/mixed; boundary="------------DvT8SfkPmJRmXAYHiBwk9gCF" --------------DvT8SfkPmJRmXAYHiBwk9gCF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDcuMjYgMTI6MDcsIEluZ28gTW9sbmFyIHdyb3RlOg0KPiANCj4gKiBTZWFuIENo cmlzdG9waGVyc29uIDxzZWFuamNAZ29vZ2xlLmNvbT4gd3JvdGU6DQo+IA0KPj4+IE5vdGUg dGhhdCB0aGUgaW5kaXZpZHVhbCBwYXRjaGVzIGFyZSBJTU8gc2lnbmlmaWNhbnRseSBlYXNp ZXIgdG8gcmV2aWV3DQo+Pj4gdGhyb3VnaCB0aGUgYWN0dWFsIDMyLWJpdCA9PiA2NC1iaXQg dmFyaWFibGUgYXNzaWdubWVudCBjaGFuZ2VzIGRvbmUNCj4+PiBpbiBpc29sYXRpb24gKHdo aWNoIHNvbWV0aW1lcyBpbmNsdWRlIG1pbm9yIGNsZWFudXBzKSwgd2hpbGUNCj4+PiB0aGUg Q29jY2luZWxsZSBzZW1hbnRpYyBwYXRjaDoNCj4+Pg0KPj4+ICAgICB7IGEoYixjKSA9PiBj ID0gYShiKSB9DQo+Pj4NCj4+PiB3aGljaCBjaGFuZ2VzIGJvdGggdGhlIGZ1bmN0aW9uIHNp Z25hdHVyZSBhbmQgdGhlIG9yZGVyIG9mIHRlcm1zIGFzDQo+Pj4gd2VsbCwgaXMganVzdCBh IHNpbmdsZSBhZGQtb24gdHJlZXdpZGUgcGF0Y2guDQo+Pg0KPj4gSXMgdGhlIHBsYW4gZm9y IHN1YnN5c3RlbSBtYWludGFpbmVycyB0byBwaWNrIHVwIHRoZSByZWxldmFudCBwYXRjaGVz LA0KPj4gYW5kIHRoZW4gZG8gdGhlIHRyZWV3aWRlIGNoYW5nZSBvbmUgcmVsZWFzZSBjeWNs ZSBsYXRlcj8NCj4gDQo+IEknbGwgdHJ5IHRvIGtlZXAgdGhlIHBhdGNoZXMgaW4gYSBzaW5n bGUgdHJlZSAodGlwOng4Ni9tc3IpDQo+IGluIHRoZSBob3BlIG9mIG5vdCBwcm9sb25naW5n IHRoZSBwYWluIHR3byBjeWNsZXMgLSBidXQgaXQncw0KPiBvZiBjb3Vyc2UgZmluZSBmb3Ig bWFpbnRhaW5lcnMgdG8gcGljayB1cCB0aGUgcGF0Y2hlcyB0b28NCj4gKG1vc3Qgb2YgdGhl bSBhcmUgc3RhbmRhbG9uZSksIHdlJ2xsIHNvcnQgaXQgYWxsIG91dCBpbiB0aGUgZW5kLg0K DQpJbmdvLCB3b3VsZCB5b3UgYmUgZmluZSB3aXRoIG1lIHBvc3RpbmcgcGF0Y2ggdXBkYXRl cyBqdXN0IGFzIHJlcGxpZXMgdG8gdGhlDQpvcmlnaW5hbCBwYXRjaCBlbWFpbHM/IFRoaXMg d291bGQgc3BlZWQgdGhpbmdzIHVwLCBhcyBJIHdvdWxkbid0IG5lZWQgdG8gd2FpdA0KZm9y IG1vcmUgcmV2aWV3IGlucHV0IG9mIGFsbCB0aGUgcGF0Y2hlcyBiZWZvcmUgc2VuZGluZyBv dXQgbmV3IHZlcnNpb25zLg0KDQpBcyB0aGUgcGF0Y2hlcyBhcmUgKG1vc3RseSkgc3RhbmRh bG9uZSwgdGhpcyBzaG91bGQgbm90IGNhdXNlIGFueSB3ZWlyZA0KcHJvYmxlbXMuDQoNClRo ZSBsYXN0IHR3byBwYXRjaGVzIG1pZ2h0IG5lZWQgdXBkYXRlcywgYnV0IHRob3NlIGNhbiBi ZSBhcHBsaWVkIG9ubHkgYWZ0ZXINCnRoZSByZXN0IGhhcyBiZWVuIGFjY2VwdGVkIGFueXdh eS4NCg0KDQpKdWVyZ2VuDQo= --------------DvT8SfkPmJRmXAYHiBwk9gCF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------DvT8SfkPmJRmXAYHiBwk9gCF-- --------------o2fircZpb09tU1GMO2GxqgPd-- --------------WjZXb44KsATEDkDSufWy2bKk Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpGRZgFAwAAAAAACgkQsN6d1ii/Ey9T iQf8D4c54BGRNKMRsSJiXSFxOPiUVfGXcsH7BLGSCIbavlNKB6PC4nfBVKfvlEHUsQk3Zy7dOXCt DjWUBhqMxb+QCJKNrUGKsdDFtl1Agihz8PaRzzF6LAJL86LHnhjy30FkyEoT+wE8pfL61qKpyusy xGc+xkkzm+tcDAwQDn9wTrmDKRaa/yWjrPX2idLQ/ATrKILtNW/Ci7tbKeltRSGhWV7aNEtyEUco wq6RU91rH9miz+a9ZWCRa/bc1FU0brdudBe2pkTiDua5vzSwUx4gBoLQ98BcHb+bKidB+OS3WYBa Qfoo0sr6Uryp6mf98UcyNgyPhA4rdUuo1iUvfsGhdg== =MZUf -----END PGP SIGNATURE----- --------------WjZXb44KsATEDkDSufWy2bKk-- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 11:16:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 11:16:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351699.1608789 (Exim 4.92) (envelope-from ) id 1wfFOi-0001r6-KM; Thu, 02 Jul 2026 11:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351699.1608789; Thu, 02 Jul 2026 11:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFOi-0001qz-Gl; Thu, 02 Jul 2026 11:16:00 +0000 Received: by outflank-mailman (input) for mailman id 1351699; Thu, 02 Jul 2026 11:15:58 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFOf-0001qn-9G for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:15:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfFOd-00Dbk4-Tx for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:15:56 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46486b-bab6-0a2a0a5309dd-0a2a4509cec4-2 for ; Thu, 02 Jul 2026 13:15:55 +0200 Received: from [91.218.175.179] (helo=out-179.mta0.migadu.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46486a-97e6-0a2a45090019-5bdaafb38c25-3 for ; Thu, 02 Jul 2026 13:15:54 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782990951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MXoiAeiZxppUV0bbr36tbNoILtIVkAZHXOhXlmlq9aE=; b=SNO+TI3ysBG4+DhR3hPTF1SvhO32c4IR52yjAPmkR78MakGGmD/cQOYIcE8MmMX2BXfJ/B PngJwUk8MPDHueMWfaVQgxbOjSa6VTjHZniUa88SClGCvA5JNzJYRen32CdMAokXiIgXtC 8TVZTPLK3UhpO1X2vjoT/Jd84+uq0gc= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t Date: Thu, 2 Jul 2026 19:15:31 +0800 Message-Id: <20260702111531.64883-1-lance.yang@linux.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-bad1c0/1782990955-56594986-2BE39724/0/0 X-purgate-type: clean X-purgate-size: 3736 On Mon, Jun 29, 2026 at 08:25:25PM +0100, Lorenzo Stoakes wrote: >The core do_mmap() function accepts a vm_flags_t parameter which it then >manipulates before passing to mmap_region() to do the heavy lifting of the >memory mapping. > >Update do_mmap() to instead accept a vma_flags_t parameter, and adjust all >the logic within do_mmap() to manipulate this instead. > >This is as part of the ongoing effort to convert VMA flags from a system >word size to a bitmap type which allows us to unrestrict the number of VMA >flags, as well as gain control over how VMA flag manipulation occurs. > >We do not cascade these changes to all functions which accept vm_flags_t, >but rather use vma_flags_to_legacy() where necessary, specifically >deferring converting calc_vm_prot_bits(), calc_vm_flag_bits() and >__get_unmapped_area() to vma_flags_t. > >Also utilise the new vma_flags_can_grow() predicate which correctly handles >the case of architectures without upward growing stacks. > >As part of this change, introduce VMA_SHADOW_STACK so we can correctly >handle the case of the shadow stack not being defined. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- Not exactly a small one :) I stared at this patch for a while, hopefully don't miss anythig ... Just one tiny nit below. Overall, LGTM, feel free to add: Reviewed-by: Lance Yang [...] >diff --git a/mm/mmap.c b/mm/mmap.c >index 46174e706bbe..547352183214 100644 >--- a/mm/mmap.c >+++ b/mm/mmap.c [...] >@@ -488,23 +496,27 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > * Check to see if we are violating any seals and update VMA > * flags if necessary to avoid future seal violations. > */ >- err = memfd_check_seals_mmap(file, &vm_flags); >+ err = memfd_check_seals_mmap(file, &vma_flags); > if (err) > return (unsigned long)err; > } else { > switch (flags & MAP_TYPE) { > case MAP_SHARED: >- if (vm_flags & (VM_GROWSDOWN|VM_GROWSUP)) >+ if (vma_flags_can_grow(&vma_flags)) > return -EINVAL; > /* > * Ignore pgoff. > */ > pgoff = 0; >- vm_flags |= VM_SHARED | VM_MAYSHARE; >+ vma_flags_set(&vma_flags, VMA_SHARED_BIT, VMA_MAYSHARE_BIT); > break; >- case MAP_DROPPABLE: >- if (VM_DROPPABLE == VM_NONE) >+ case MAP_DROPPABLE: { >+ vma_flags_t droppable = VMA_DROPPABLE; >+ >+ if (vma_flags_empty(&droppable)) > return -EOPNOTSUPP; >+ vma_flags_set_mask(&vma_flags, droppable); >+ > /* > * A locked or stack area makes no sense to be droppable. > * >@@ -515,23 +527,24 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > */ > if (flags & (MAP_LOCKED | MAP_HUGETLB)) > return -EINVAL; >- if (vm_flags & (VM_GROWSDOWN | VM_GROWSUP)) >+ if (vma_flags_can_grow(&vma_flags)) > return -EINVAL; > >- vm_flags |= VM_DROPPABLE; Old code checked VM_GROWSDOWN|VM_GROWSUP before seting VM_DROPPABLE. New code flips that around. Hmm, shouldn't master, just made me look twice ;) Maybe keep old order? Cheers, Lance >- > /* > * If the pages can be dropped, then it doesn't make > * sense to reserve them. > */ >- vm_flags |= VM_NORESERVE; >+ vma_flags_set(&vma_flags, VMA_NORESERVE_BIT); > > /* > * Likewise, they're volatile enough that they > * shouldn't survive forks or coredumps. > */ >- vm_flags |= VM_WIPEONFORK | VM_DONTDUMP; >+ vma_flags_set(&vma_flags, VMA_WIPEONFORK_BIT, >+ VMA_DONTDUMP_BIT); >+ > fallthrough; >+ } > case MAP_PRIVATE: > /* > * Set pgoff according to addr for anon_vma. [...] From xen-devel-bounces@lists.xenproject.org Thu Jul 02 11:31:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 11:31:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351721.1608797 (Exim 4.92) (envelope-from ) id 1wfFdV-0005PJ-Sa; Thu, 02 Jul 2026 11:31:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351721.1608797; Thu, 02 Jul 2026 11:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFdV-0005PC-Pt; Thu, 02 Jul 2026 11:31:17 +0000 Received: by outflank-mailman (input) for mailman id 1351721; Thu, 02 Jul 2026 11:31:17 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFdU-0005P6-UE for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:31:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfFdU-00DlGH-8Y for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:31:16 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a464c04-5cb7-0a2a0a5109dd-0a2a450c952e-0 for ; Thu, 02 Jul 2026 13:31:16 +0200 Received: from [40.93.195.24] (helo=SN4PR2101CU001.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a464c02-f399-0a2a450c0019-285dc3185f3d-3 for ; Thu, 02 Jul 2026 13:31:15 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by PH0PR03MB5733.namprd03.prod.outlook.com (2603:10b6:510:39::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Thu, 2 Jul 2026 11:31:13 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Thu, 2 Jul 2026 11:31:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cR+hwX//0ZOHqcU9FxeggPNm/9QgLNOY6NqAy8f/yeOrqfIA5G4aATUR0nvDfwgVns0nyCCW/MGyd5nN1oyFKnwXkCVyzObR/74yetuK3OLypJR5iuIdCyghXZoRhDyBopvQ1BttJwnagzc2mfvRqiRYn27OfJLF46Ko9PMghDfpl9yxVJoTA60izKU9e7p8SNTFQFp3R1unSK6KxEv/L0nY3wdpmSsEe5WAN/j7j3zYFsAR+aOMYt6dTY8uvG08syieiYqYI48suF4+M47J1aInYxz8kvjYzBvQBqafCzFLJ1c5snwd6VemnvR0YfHUObeoYa4x6bVmfIFDjsFbkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8YE7qMEO+fWBMM1cuUzNhk18IMwC2N4Gohux8+fi7Ys=; b=TFF4YC6d883VYfDP5Mu5iz5pF2NKmQ8GfGhsmG07EGSA0zBtViL4rvxrT0cF5K2TBUYgh5YHizSb42EdGH8HhwETh/IOm4DjBoP2UlzFYm0+R2p7nMRsMBHBFFOqQROM3BGMQkaeSZQz5oTmSVxYjCGdLkI8KgPA07ljJoZqeF5lFPx9b/00ZBQjOlUS90T3uycMlHyt8ak9DX0iirReDaQevMgHhEBLfJPWyLAAT1lC57v1WtF7l99J04FSZRFpJYip5s8DH/1n7erBy8UXF+6+RxtMDGhpzy95uitO4IuBbNdiFeqcOyKb0+R5PgXjzSFH0fC8axLd0/vYJKZUYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8YE7qMEO+fWBMM1cuUzNhk18IMwC2N4Gohux8+fi7Ys=; b=rBvoFqFMesccSP/e/t02WT92LKeyiX9C0Z6GoOZVN7cnb31YeIY3KrZM08BKsW3sUj5WIcem+MgrxJzIOVZILbIyMNSbVbwxCQl7motyeRtfXkkqsO2ExQDpyWw7Ie4OLoxkGY6fmIp+jzlq8iQIcu2yQAMjDglug6yRhqWdjlg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6065311f-15b3-403e-b39c-f9652f0513ff@citrix.com> Date: Thu, 2 Jul 2026 12:31:09 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH v3 1/4] x86/HVM: don't (almost) open-code POP_GPRS To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0150.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::11) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|PH0PR03MB5733:EE_ X-MS-Office365-Filtering-Correlation-Id: 5db6a722-3f9c-40e7-1646-08ded82d6bae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|366016|1800799024|18002099003|22082099003|11063799006|4143699003|56012099006; X-Microsoft-Antispam-Message-Info: cJ21bNoD3ZljtzXm7GbDIMe8AFBoLAWJwt1WeSypYz/WJwI+QiAE+Fud0iL8BdINRb94tFkQ8dZZTXXgkujhaxem80aflYu5x28LTqJzqo/6962Lay1RTGSReNEzSkThvb7OW2I2VtW/sirskEbL2DtRJciQdvOlCV29xDdvxO9dm7iCMKUTTySGAMGoVeWzPuxfiEoX6hKi4s43uuNl/J+sgqRiTf1tgfY3TxGB0t0VVDYYISO5SEF0JawFx/alrzpTJYv1iiThdVhqYUws9q6HNr5lOzmpOroS3vxV+IBlDAHdYn/Q9oIG1RYXj318vRO5B+GHSAUUBVEMxzeyHJMjcU8dgxQkFzRsBwVZih9etqkxEo0JUvDwTtwjARUkH9xb9JdQa21FUi5R60IuJGkoFlKxeNJvTFVV2UAFKF66kiNwiozo9qhjwjeFiQey+YGfBXud7FY0ohWeVaBT7ymiL3ZE+bl5XuYiJIdYni7G4uueU/0f1felwnyENA8emNazb3FGS8wuWLb8+ELb1EEnDmmGNTHyBCbSYTFAs8imJbQdFds486c2SAYvvay6rCuvvv8VINXg4Tig1/0qeDWbVLtT/sU/Tj8Qx99/XuDl5q85XtTmM7VDoqpGjKP6E7hyztWJVtlebVxFx7qUOSoN5vJbxsjkXThF9Tdv/Sc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(18002099003)(22082099003)(11063799006)(4143699003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cS92S3d4YWZqUWdsQmdiZTRZSDZtR0VzdTh5eVZ1Rk5tUmxIb1FKUkFxSTZS?= =?utf-8?B?bGExcUs4Tlc1bEZmSzAyV2dvaExkU2JzTEhWeDI4WkliSXNqaVlqenBUVm1T?= =?utf-8?B?SVRsVmUrSnMvNDlITStEWDE0U2xsSEgwTC9NcG1QR2N0UjRqZ2d5ZFhVZnZX?= =?utf-8?B?NGdSMkF3VUpac2RrME8xMUVvWDBPSUF6em52aEZzbDUvZEFBVE54Z0x2b05i?= =?utf-8?B?SEczcDNMVEd6U1FLTHE3RzF0cDk4UVRDU200L0l6MkRsNHlSMlRVVDFER1ha?= =?utf-8?B?Q0lMZTFuWmN5R005Y1BVakk3UENpcnJQaFlGS3lLbFQ0d0MyNmRXR2IrZTlJ?= =?utf-8?B?K2tCbmo1UHZvVExkdDlWUVR5cjBlZ0NoaGxoWmdUd1E2S25QS1Q0eEhZSE5u?= =?utf-8?B?d1BXeU9nYkp4SVVHbWJ1RGhZKzM0dFNGdmU4VCtacWlRMGo2bEx1MXA2My92?= =?utf-8?B?NWoydUFpZ1hNaW90ckVpL3ZSa1J2UWNKM1ZEN3RsV3d1WG9ESE51RnlmcUND?= =?utf-8?B?RlpmYjZEWElhQVlwdXdaQjZTYWtBZTZMU0pTTmZ6WWlGZitIc0UrOTJZNXZz?= =?utf-8?B?cktBaGVFQWt4b3NsVkg3NjcwRVJ4Rm43ZzM2Vm5VZEdMTWJRUTNLWFdJRnQy?= =?utf-8?B?REFocUtWSkcrdW9xWVNqaHBhRUVINkxEamdXc1pnb1htdUdQUmIrMHdRZ3J1?= =?utf-8?B?WDEwZ0E2ZHFEVnRqOHp3UVpxRUdmOWo0OHJkMElQMlFiVG1yNlMzR3F1eEIw?= =?utf-8?B?cmdQM3NUMnNSWko5RTZRUDB6THpnVU1PYjFDdXhTQ1Z1aUUvdWRMUDFYRjVq?= =?utf-8?B?TFQyS1RmdklMNnZOUHN6alFVRXRyR2hBOTdEV1RqWGtHWlVkRWRQeWU1elVL?= =?utf-8?B?ZzJ0aW1lUTY2aS9xTFlEa3BxR0ZRcEd0QmhHMUYrZEcxQnlPNGFaMmhCZXBh?= =?utf-8?B?VTRGV1pNVWc2WSsrNVhVRWtJNFRRRENDSndyc2ZQYTc4cXEzM21aVTQ4M1B4?= =?utf-8?B?VGFsRDJSZ0FObVN5TzdRakczS3pIVWZoOUV1anRidTZFajVicHFVQXJ0TDBW?= =?utf-8?B?aTBxYjY2QW9ybXRDUDZYQUx2SEo4Y1d3SWZOT2RxWm1oVFZKa3IweEZzZXkx?= =?utf-8?B?QmpDa1hYNnU3djBmekhXZExKbjlEM1RjNGp3VThmVGo0Wk12b2Y5cWlqMG1x?= =?utf-8?B?MVFyNXIvVFhkZllZRGRGWWVSOCtIMjJFSGkyTjRaTlNMSG42M1lqdW92WGJG?= =?utf-8?B?L0Vhemd5Q0g4eWQ1eFBUYndocnVuQU9GR0FvMm1yaFVqQVQ3dEo4anVCOHdP?= =?utf-8?B?bXExYTlkM2ZzMHU2UlFRMk1kT084TlpGYkg0NGYwUVZZNEVLa3RPaks4T0Q2?= =?utf-8?B?ZUx6RkJFSGowMUQrYTA1ci93MU9UNlljNXE2aHJ2a3hyZkY2RFlDSWhzbVM2?= =?utf-8?B?VnRCTFNIeklHSkIyNFdYcm5COXBocVpYbDhUd2lVckFibEU0ZC9OYXJqL1ND?= =?utf-8?B?QWhxN3Ntb2p5dkMrVFhLN2tyS3Ryd2NwZEROeVVneXZRQUtYb2ZhRmc4aGJJ?= =?utf-8?B?L1BIM2ZkZUxyQ3l4VlRSc0JPSkt3MmZvUUZTSDZiWDRKbEloRlpmdUJlbENL?= =?utf-8?B?RlJDRUQ2Mk9iMEVJNkVWYkV1VGRhdDV4MCtLbmVBaThvUmxPckt2Ym9uZE9C?= =?utf-8?B?YldSejlwRE5FQWM5TE1LN2wyTXpibGMvRDdqQzA1ck5JOEk4NWw5R1p3eUlN?= =?utf-8?B?NnVHZ0JtVHkyL1piSEcwaDNxYmJKZENYbmNEK1FrYStSMVFWd0tWek1GSmFv?= =?utf-8?B?UU1HV28vc0pKUng1S2NuQ1VwSEJ0Qi9rUUxiK0t6VHM4bjRBcVd6RHpxZi9i?= =?utf-8?B?clpPS0phVzhVREVBd2xzSm1ub0hDOFhzNURuc0M0WkdlNlBLdExQUUdMWE56?= =?utf-8?B?Zmg3bjNRb1Rxa081QStwTndJTk1IK1VjMys0Ly8xSXpxSkp5SjVNS2UrWmRX?= =?utf-8?B?ZVFqZVA1ak4yMjcwclRWNE83SUhDT0FFeXRMS3kvVENUMVNETk45eFBzMUkr?= =?utf-8?B?cE5EeXF1blBSTXJUUC81cmJEZ296T1lJbzJwT0pnOE9Xczg4YWlpWUhibkNt?= =?utf-8?B?WkhlVTh2bUIrVWk4Tkh0MzNncXJOQ3lobmM2OUJUT0tFd2phMXA3clpZSUpL?= =?utf-8?B?YnE2Q01MNVRnRTRwUE9GVVZtVzlLT3U2ZTdMd3k3V2dSYU1aWUUvWmN1WVBR?= =?utf-8?B?TFhMY3RyUnRzQWZscWQ4L3dwVldUemhVVHZ0a2dVZ1Q4ejR1emNoV25ILytI?= =?utf-8?B?L1Vya2sxSVREa3lhQXVNcms3Z0NOK2c3VUpQVzFBWjZCU0UxOVRKZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5db6a722-3f9c-40e7-1646-08ded82d6bae X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 11:31:12.6269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gsd8KiC+nsmi+4XLL501rdvXkEqe6pSHj9jBx6gxGlz6RG3eIvfeQVv5hC8aIaoCBel5584GAa3oDQijLaYsp/xlaVm1oDMWCWsQupPLslU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5733 X-purgate-ID: tlsNG-d25034/1782991876-0EB3DD51-5EC61805/0/0 X-purgate-type: clean X-purgate-size: 733 On 02/07/2026 11:55 am, Jan Beulich wrote: > It can be used as-is for VMX. For SVM the special treatment of %rax needs > accounting for. > > Signed-off-by: Jan Beulich > --- > This is the minimum required as a prereq to the next patch (to avoid the > need for custom adjustments in the two places). We could go further and > switch to using PUSH_AND_CLEAR_GPRS at the same time. I've got several part-series that result in purging SAVE_ALL/RESTORE_ALL. If you want to put this patch in, then Acked-by: Andrew Cooper but I firmly want to finish my series before patch 2 adds yet-more complexity to macros which I'm wanting to remove for being too complicated already. From xen-devel-bounces@lists.xenproject.org Thu Jul 02 11:38:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 11:38:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351736.1608806 (Exim 4.92) (envelope-from ) id 1wfFjz-0006AX-Gq; Thu, 02 Jul 2026 11:37:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351736.1608806; Thu, 02 Jul 2026 11:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFjz-0006AQ-E9; Thu, 02 Jul 2026 11:37:59 +0000 Received: by outflank-mailman (input) for mailman id 1351736; Thu, 02 Jul 2026 11:37:58 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFjx-0006AK-QL for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:37:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfFjx-00EP7D-6z for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:37:57 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a464d88-5cb7-0a2a0a5109dd-0a2a4507bff4-28 for ; Thu, 02 Jul 2026 13:37:56 +0200 Received: from [95.215.58.183] (helo=out-183.mta1.migadu.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a464d93-9c8e-0a2a45070019-5fd73ab7ff0b-3 for ; Thu, 02 Jul 2026 13:37:55 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782992273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4zTiOPxPEEvh+Z2LMv+6gqe9ZZvh+3yTK3Yc5UnT/U=; b=AkD1PO3EYh/hmuzqNyG5+F4iFU+xRbougp+bY+xotWctIjwUQvMKpAwXsjPb5kG+NxyY12 mV0mEGNoe2Czu7JdCtguHySTk1KxuHzjRfZnXIBhIe71SSOqRiI6wOFZz62JhxqVX83KFA KhWu2A9hV9btjfbdFeq0dyXUttdl5PQ= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t Date: Thu, 2 Jul 2026 19:37:22 +0800 Message-Id: <20260702113722.97837-1-lance.yang@linux.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-ef75cf/1782992276-FCD2C25E-E5F13D92/0/0 X-purgate-type: clean X-purgate-size: 622 On Mon, Jun 29, 2026 at 08:25:26PM +0100, Lorenzo Stoakes wrote: >Update __get_unmapped_area() to be parameterised by vma_flags_t rather than >vm_flags_t as part of the effort to move VMA flags from a system word to a >bitmap. > >We cascade the changes up to arch_get_unmapped_area_topdown() and >arch_get_unmapped_area(), where, for now, we use vma_flags_to_legacy() in >order to propagate the VMA flags. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- Nothing suspicious that I could spot :) Feel free to add: Reviewed-by: Lance Yang From xen-devel-bounces@lists.xenproject.org Thu Jul 02 11:42:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 11:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351745.1608816 (Exim 4.92) (envelope-from ) id 1wfFnq-0007gF-Vg; Thu, 02 Jul 2026 11:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351745.1608816; Thu, 02 Jul 2026 11:41:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFnq-0007g8-T1; Thu, 02 Jul 2026 11:41:58 +0000 Received: by outflank-mailman (input) for mailman id 1351745; Thu, 02 Jul 2026 11:41:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfFnp-0007ex-Ud for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 11:41:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfFno-006YT7-8X for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:41:56 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a464e76-5cb7-0a2a0a5109dd-0a2a4503a46c-44 for ; Thu, 02 Jul 2026 13:41:55 +0200 Received: from [91.218.175.178] (helo=out-178.mta0.migadu.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a464e83-ec1a-0a2a45030019-5bdaafb22bac-3 for ; Thu, 02 Jul 2026 13:41:55 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782992513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vPHtV6pxZdlKjLiAMh+TI96h/MjbfgTMGiJB5aRI1Dw=; b=ElylzNP2HZvUF6FtGgLgsW4vT0OTcdy2XorLGs6M4jbsXqc3kVIN25VDlrp06Kwp+MnkF0 7eCUNpZQUAu53ooUNOnYLe8bcSqU2lbFmJuaAoucdQs+qEK4yKsjIpHuYOtBIHp/EvNPEl ujU0zKbwsKGW+OA8vv+O0JU4vozY/FA= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 04/13] mm: update generic_get_unmapped_area[_topdown]() to use vma_flags_t Date: Thu, 2 Jul 2026 19:41:35 +0800 Message-Id: <20260702114135.4189-1-lance.yang@linux.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-33051d/1782992515-B4F835D1-24E5BE97/0/0 X-purgate-type: clean X-purgate-size: 652 On Mon, Jun 29, 2026 at 08:25:27PM +0100, Lorenzo Stoakes wrote: >As part of the changes converting VMA flags from a system word size to a >bitmap, extend this change to generic_get_unmapped_area() and >generic_get_unmapped_area_topdown(), which also allows us to convert >stack_guard_placement() as well. > >We retain arch_get_unmapped_area() and arch_get_unmapped_area_topdown() >as-is for now, using legacy_to_vma_flags() as necessary to do so. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- Nothing jumped out at me ;) Feel free to add: Reviewed-by: Lance Yang From xen-devel-bounces@lists.xenproject.org Thu Jul 02 12:11:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 12:11:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351766.1608824 (Exim 4.92) (envelope-from ) id 1wfGG1-0003sW-86; Thu, 02 Jul 2026 12:11:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351766.1608824; Thu, 02 Jul 2026 12:11:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGG1-0003sP-5D; Thu, 02 Jul 2026 12:11:05 +0000 Received: by outflank-mailman (input) for mailman id 1351766; Thu, 02 Jul 2026 12:11:03 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGFz-0003sJ-1M for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:11:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfGFy-007PbE-0m for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:11:02 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a465551-e002-0a2a0a5209dd-0a2a4506dd26-0 for ; Thu, 02 Jul 2026 14:10:57 +0200 Received: from [91.218.175.174] (helo=out-174.mta0.migadu.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a465550-08de-0a2a45060019-5bdaafaef8e9-3 for ; Thu, 02 Jul 2026 14:10:57 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782994254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=szYxJDyUXLwpHCPYtdT5QZRTamk7ohIwjDiVPC1pzUs=; b=o2h14zEvKcQ49vaQ50LBNnbgHGGpFBTA0OsIFCWdpiUc7gYaraiUcJHgmdFM4mBzY7pBJH 3Nawgn9WkBzIHxRb3Nw1H0UdEQI7UMwMGIksMhfoUjYHvm6uqPS5csZAIdTgWkWJ0NxwiR +fbu3PSBP2IvpsY/0wNqYNag0+1ZZPU= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 05/13] mm: prefer mm->def_vma_flags in mm logic Date: Thu, 2 Jul 2026 20:10:22 +0800 Message-Id: <20260702121022.49113-1-lance.yang@linux.dev> In-Reply-To: <3b4ccdc38819b42ddc79ee5a795831208ac7986c.1782760670.git.ljs@kernel.org> References: <3b4ccdc38819b42ddc79ee5a795831208ac7986c.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-16d1c6/1782994257-42F2468D-5957A36A/0/0 X-purgate-type: clean X-purgate-size: 1399 On Mon, Jun 29, 2026 at 08:25:28PM +0100, Lorenzo Stoakes wrote: >Currently mm->def_flags (of type vm_flags_t) is union'd with >mm->def_vma_flags (of type vma_flags_t). > >As part of the effort to convert vm_flags_t usage to vma_flags_t (in order >to no longer be arbitrarily limited to a system word size for VMA flags), >prefer mm->def_vma_flags to mm->def_flags throughout the mm logic. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- > mm/debug.c | 2 +- > mm/mlock.c | 13 +++++++------ > mm/mmap.c | 11 ++++++----- > mm/vma.c | 4 ++-- > 4 files changed, 16 insertions(+), 14 deletions(-) > >diff --git a/mm/debug.c b/mm/debug.c >index 497654b36f1a..f0a354a9496a 100644 >--- a/mm/debug.c >+++ b/mm/debug.c >@@ -226,7 +226,7 @@ void dump_mm(const struct mm_struct *mm) > mm->numa_next_scan, mm->numa_scan_offset, mm->numa_scan_seq, > #endif > atomic_read(&mm->tlb_flush_pending), >- mm->def_flags, &mm->def_flags >+ vma_flags_to_legacy(mm->def_vma_flags), &mm->def_vma_flags > ); While at it, one thing for later: dump_mm() still assumes one-world VMA flags. That works today since vma_flags_t is one word. Maybe worth a BUILD_BUG_ON() here, before that stops being true? Not a big deal though. Feel free to add: Reviewed-by: Lance Yang > } > EXPORT_SYMBOL(dump_mm); [...] From xen-devel-bounces@lists.xenproject.org Thu Jul 02 12:22:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 12:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351781.1608834 (Exim 4.92) (envelope-from ) id 1wfGQY-0005jU-5r; Thu, 02 Jul 2026 12:21:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351781.1608834; Thu, 02 Jul 2026 12:21:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGQY-0005jN-2Q; Thu, 02 Jul 2026 12:21:58 +0000 Received: by outflank-mailman (input) for mailman id 1351781; Thu, 02 Jul 2026 12:21:56 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGQV-0005jH-4f for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:21:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfGQU-006Uvu-He for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:21:54 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4657e2-bab6-0a2a0a5309dd-0a2a45019d8a-0 for ; Thu, 02 Jul 2026 14:21:54 +0200 Received: from [91.218.175.173] (helo=out-173.mta0.migadu.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4657e1-400f-0a2a45010019-5bdaafad6efe-3 for ; Thu, 02 Jul 2026 14:21:53 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782994911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flDoJiJgtgGf3x2zlQX9jaS5nhFTdBgmSXvfG9PiFjA=; b=lN0+Boa2ASIcCLc47EPvtXVMZuYaw78VJ/wVLmRpCeGudutYAguuVxwIGwqQDa2oDibvGW bIpbbgc5ew0Ij3QtFyyGuneAdXTOrpkXqfYfNRMzfKjFKxKgZCy8wM/iRDCenl6trdMYJz +LOdf87J+2yAD0n3s3yNqonkzwm6x4w= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 06/13] mm/vma: convert vm_pgprot_modify() to use vma_flags_t and rename Date: Thu, 2 Jul 2026 20:21:16 +0800 Message-Id: <20260702122116.65642-1-lance.yang@linux.dev> In-Reply-To: <548ba81b2971734d4d2143237ad1465bd1b2f525.1782760670.git.ljs@kernel.org> References: <548ba81b2971734d4d2143237ad1465bd1b2f525.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-d62444/1782994914-D04D51E0-39AE9C31/0/0 X-purgate-type: clean X-purgate-size: 1521 On Mon, Jun 29, 2026 at 08:25:29PM +0100, Lorenzo Stoakes wrote: >Update vm_pgprot_modify() to use the new VMA flags type vma_flags_t, and >rename to vma_pgprot_modify() accordingly. > >This is part of the ongoing work to convert vm_flags_t to vma_flags_t, in >order to eliminate the arbitrary limit of the number of bits in a system >word on available VMA flags. > >Update VMA userland tests accordingly, updating vma_set_page_prot() to no >longer inline vma_pgprot_modify(), rather we can simply define >vma_pgprot_modify() as a static inline function and the tests will pick it >up from vma.h. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- [...] >diff --git a/mm/vma.h b/mm/vma.h >index bcf0c2773449..6a8abb8ae937 100644 >--- a/mm/vma.h >+++ b/mm/vma.h >@@ -522,9 +522,11 @@ static inline bool vma_wants_manual_pte_write_upgrade(struct vm_area_struct *vma > } > > #ifdef CONFIG_MMU >-static inline pgprot_t vm_pgprot_modify(pgprot_t oldprot, vm_flags_t vm_flags) >+static inline pgprot_t vma_pgprot_modify(pgprot_t oldprot, vma_flags_t vma_flags) > { >- return pgprot_modify(oldprot, vm_get_page_prot(vm_flags)); >+ const pgprot_t prot = vma_get_page_prot(vma_flags); >+ >+ return pgprot_modify(oldprot, prot); Nit: could this just stay as a single return? something like: return pgprot_modify(oldprot, vma_get_page_prot(vma_flags)); Otherwise, LGTM, feel free to add: Reviewed-by: Lance Yang [...] From xen-devel-bounces@lists.xenproject.org Thu Jul 02 12:25:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 12:25:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351792.1608843 (Exim 4.92) (envelope-from ) id 1wfGUL-0006JD-JR; Thu, 02 Jul 2026 12:25:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351792.1608843; Thu, 02 Jul 2026 12:25:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGUL-0006J6-Gq; Thu, 02 Jul 2026 12:25:53 +0000 Received: by outflank-mailman (input) for mailman id 1351792; Thu, 02 Jul 2026 12:25:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGUK-0006Iz-TJ for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:25:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfGUF-007vAO-47 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:25:52 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4658c9-bab6-0a2a0a5309dd-0a2a4501def0-6 for ; Thu, 02 Jul 2026 14:25:47 +0200 Received: from [91.218.175.184] (helo=out-184.mta0.migadu.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4658ca-400f-0a2a45010019-5bdaafb8cc25-3 for ; Thu, 02 Jul 2026 14:25:46 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782995144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Ko6g/fNv98hSurpFrjSC8unNT/smMh3pnGqTobbcqg=; b=b+ldrvkt8ZmJ+OrI3yxcQgFLnRxGCWHjhsFZZL3rVzLaxyNILjolYA01aJGr58GPqotONa C0qfjyiCv0Ek1cqalMJ+/t7YCyD5CeARmY/TMOXt2of2lM3qjKi0LZINpNnLjdz9QLcCqu OOzdaIK15Lm4UMi7JwMdKk4MKXYIZlw= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 07/13] mm/vma: rename vma_get_page_prot to vma_flags_to_page_prot Date: Thu, 2 Jul 2026 20:25:15 +0800 Message-Id: <20260702122515.74271-1-lance.yang@linux.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-d62444/1782995146-804D21E0-701ECA56/0/0 X-purgate-type: clean X-purgate-size: 479 On Mon, Jun 29, 2026 at 08:25:30PM +0100, Lorenzo Stoakes wrote: >Having vma_get_page_prot() refer to VMA flags and vma_set_page_prot() refer >to a VMA is confusing. > >Rename vma_get_page_prot() to vma_flags_to_page_prot() to resolve this >confusion. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- straight rename, no stale callers that I can spot ;) Feel free to add: Reviewed-by: Lance Yang From xen-devel-bounces@lists.xenproject.org Thu Jul 02 12:31:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 12:31:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351802.1608851 (Exim 4.92) (envelope-from ) id 1wfGZq-00084R-4s; Thu, 02 Jul 2026 12:31:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351802.1608851; Thu, 02 Jul 2026 12:31:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGZq-00084K-1l; Thu, 02 Jul 2026 12:31:34 +0000 Received: by outflank-mailman (input) for mailman id 1351802; Thu, 02 Jul 2026 12:31:33 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGZp-00084E-6Z for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:31:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfGZo-005jVG-JY for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:31:32 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a465a22-bab6-0a2a0a5309dd-0a2a4503cc4c-12 for ; Thu, 02 Jul 2026 14:31:32 +0200 Received: from [74.125.224.45] (helo=mail-yx1-f45.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a465a23-ec1a-0a2a45030019-4a7de02dbc5b-3 for ; Thu, 02 Jul 2026 14:31:32 +0200 Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-6662551100bso1120382d50.0 for ; Thu, 02 Jul 2026 05:31:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1782995491; cv=none; d=google.com; s=arc-20260327; b=ToXjHFqgtd9xRNZXbyw7iy2syBaNQTa6+mr0ewRd+YFNzytay3g4mFPvCGAsOPgQWN JYvD/jXg2N+kGvxG25mDB5vi60ZDP5WR+hd3U/Wk179qwRbClzsoTcjoQpsol3R1G0NF 4/Zv85qYpc9mSSbC2n8rpDBj8XjxZwoQGdoDWAX0dHaHBX0tDF6H0vzyci1EAoj5TeA8 iH6hknSHohStNPlzTBTCIRjG6SJdxsCjq/s7GqgsNgxkDqIaxKPdQSAo8CNt0dSf9Chf mvwsiEpUnEfsfLzpkEJX6zH6EOTz27xELsTQAy8qFzD5X7mE0sSMO+yziDDKjfvfbZPG y3Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=ySn3gMwf35pdMOoKlEwyhm0+ybEatoARftdVy4I7+6A=; fh=pmfIAu1zZ/y4MK+Ok8pH+KJi8l1vy8Cep5fL3L/xSOQ=; b=Dxhr8Lw73FhzB18WO711DnLtorlFOOJccADY0iGQfzjF5Y6DSK09A0oIDY+0QqCCY7 dd4gHllVD3BqXeDu0MKXydJl/9k3EsNU5KK8W3sWtJpUZ+x7ryb/1n1rBaSCgxCthzno naobrM6l2kFMShlqCWNVZOFSUReRoS/FaBZKVOo1I2aXNEE1van8fbi2nda2PENajvUt WuQ+wXOepElM7T7x3rGG2KBka65hxHymUhoqYICCqCEvdaNSt/HZnBbwLa687oY6Th/B FBL8N98GV3XE3tTEOIsmQzBHvz7j7x4xnKzyQdlC2NOoNcQpdRGhOwU1M3gtKO97v7JJ iw/A==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782995491; x=1783600291; darn=lists.xenproject.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ySn3gMwf35pdMOoKlEwyhm0+ybEatoARftdVy4I7+6A=; b=C9u0eeltBO2W1v62fqqJmc9NngJIvYY0at1xBVKpG0jFj3k8aZdtZOXINTYdz2f8Ye lIUnyMfcr0ZYkDHk9biLFM359sZKYEpSUr1M23a9kLEY4ptux5yRz5Doqrans+73Sfqh T/N7I9CbQ9ER8QleSlNnrjWnqr5SaeDtw/jkXcVQYk0pmDcoMFbin4pxoESxJecAoUSX KvAn0MedJ4WkxqjS45v+EPCTkOvYTlpzldjIxoeEMSyGpBJcKrJLct9Y6UFd7D4lU8Fx Pn8Jt65Ef52NJ5vR7Z7X+RvyRWdPs37AT6dURfNzPdqeRmwmot0wtop8MRMX0xJIKKZt O0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782995491; x=1783600291; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ySn3gMwf35pdMOoKlEwyhm0+ybEatoARftdVy4I7+6A=; b=hCa0iSjuO3nv03d9iTyW/HSX1amQrncj3u18vv+mlnHnFPtnoSXkZYaQ2lVA3LU1An DxoKEAVzCDFu/iUrp30AueeP+aKlY0lJeKLIk1Ya8MOImykD5KTR1ecSgpNGT9n7kUQY 77cLYx67DJhJCDTjlZ/y+Hk9p9bKVLNRHs++ANC3mxNPp8vTMEjL+FfmBmU18DgC7uZ/ JyfnY6mgChDNFJ96rbTRbg7bFdnHxAeMyxYjZBcydES7g6UZ9skhkItYHOWXBnXYGUm0 8cRPEDe+mZ1IByM0eQPD0KnR1u/v7GLawhEoNKW3boH+44KxJOouJO272hLuHdCi6Kq2 ToFg== X-Gm-Message-State: AOJu0Yx/tB45aS9FyRy/bWji9Zt33beTxsoe9XLaN3doN1rDSdKGkv13 Kjh2hkTJnCPKnUKSbfdhGMqttgPNFW9x+DVK0NOkEJG9u6itHJMaRpYWHwXoJWVi1g4vBgzziTS tPflNh5D0H6T/yDT0L2svnfUhXij4+cI= X-Gm-Gg: AfdE7cluurAF1oihHtTT99tNzBl1Hn2oRFc7iAHUcAmeELdmwRTy1aibwey8rK6gfEi E8IaWDkN5PY48NIA5rY2Zbu42wT/fYZAD5XSyl7NsO0vx9g+bfcG8yEYcHjjbRHPPQux07OYPv+ w35lJnTVMIgv7ROUg1mIt84dLXu+R5vdsnuEdBGUKan+kJj5Q30Fw+w5An6E6V1FXHD+GL7fDu0 0cqdARTciimxiJDzirF6y22x5TSBAhWaIbZrXJg8GcxTZyxQKlC1VBakIBYVABDAJTNgUVFdCVi RoxDRCxaNwMlgy9wB0x/IjhRiP8wdIbhDQ== X-Received: by 2002:a05:690e:1918:b0:664:de27:9de5 with SMTP id 956f58d0204a3-66521cf00a0mr5248423d50.79.1782995490812; Thu, 02 Jul 2026 05:31:30 -0700 (PDT) MIME-Version: 1.0 References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-3-frediano.ziglio@citrix.com> <66e293a9-0384-4028-913d-90f2f3d1874c@citrix.com> In-Reply-To: <66e293a9-0384-4028-913d-90f2f3d1874c@citrix.com> From: Frediano Ziglio Date: Thu, 2 Jul 2026 13:31:19 +0100 X-Gm-Features: AVVi8Ccva7Q2tC64CMNMqEawCU1qa3IEf_tdqGCKpCdU9568YVWxJ1bZjnm9ppw Message-ID: Subject: Re: [PATCH v6 02/16] libs/guest: Reduce number of I/O vectors in write_batch To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1782995492-061315D1-A5907257/0/0 X-purgate-type: clean X-purgate-size: 1081 On Tue, 30 Jun 2026 at 17:41, Andrew Cooper wrote: > > On 19/06/2026 2:04 pm, Frediano Ziglio wrote: > > diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c > > index fdbceab52e..68ce1aeb98 100644 > > --- a/tools/libs/guest/xg_sr_save.c > > +++ b/tools/libs/guest/xg_sr_save.c > > @@ -97,9 +97,11 @@ static int write_batch(struct xc_sr_context *ctx) > > void *page, *orig_page; > > uint64_t *rec_pfns = NULL; > > struct iovec *iov = NULL; int iovcnt = 0; > > - struct xc_sr_rec_page_data_header hdr = { 0 }; > > - struct xc_sr_record rec = { > > - .type = REC_TYPE_PAGE_DATA, > > + struct { > > + struct xc_sr_rhdr rec; > > + struct xc_sr_rec_page_data_header page_data; > > + } hdrs = { > > + { .type = REC_TYPE_PAGE_DATA }, > > .rec = { .type = ... }, > > Otherwise this is fragile to reordering. > Changed. Here we are implementing a network protocol, reordering should not be done, unless you want to break the code. > ~Andrew Frediano From xen-devel-bounces@lists.xenproject.org Thu Jul 02 12:33:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 12:33:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351810.1608862 (Exim 4.92) (envelope-from ) id 1wfGbX-00008R-Fq; Thu, 02 Jul 2026 12:33:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351810.1608862; Thu, 02 Jul 2026 12:33:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGbX-00008K-By; Thu, 02 Jul 2026 12:33:19 +0000 Received: by outflank-mailman (input) for mailman id 1351810; Thu, 02 Jul 2026 12:33:18 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGbW-000088-OQ for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:33:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfGbW-007x4h-5Q for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:33:18 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a465a7f-bab6-0a2a0a5309dd-0a2a4501a978-28 for ; Thu, 02 Jul 2026 14:33:17 +0200 Received: from [74.125.224.43] (helo=mail-yx1-f43.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a465a8c-400f-0a2a45010019-4a7de02bc8c9-3 for ; Thu, 02 Jul 2026 14:33:17 +0200 Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-666275a685eso834316d50.2 for ; Thu, 02 Jul 2026 05:33:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1782995596; cv=none; d=google.com; s=arc-20260327; b=nETdmxlVuAGR5gNY9uc5DmLWumxU7eXFzm+reV7S8W1mtleevO+E9Pj2lbxbrpDFtY E6zx8cjT7p7oqL/DRBWD/WbYM4GiTvXEshNMpkf86k6x0HS8a8MSUbIGGWHoQw8StPJr SFNuGrcIIScOM+cvifbR45grlML6jArsQN9gU096sIdyjv0n3Hpmi0ybdlQfy8sPKIPb 1n50xMmRrAWM1jmfnGk9QrARNPgJOCt0rv24RwXia6eN529Rfjqn7WLioOUmMDebGRo6 RqwRPFElElgCotyayLvW0RhcIDfIfxhT9MOXNaDbTChRDsoAmT7JDgcQ9HB9RGOwJNTt AWrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+WSGWfYa7gMrkFqASJhZI8VjZ8XuFjtdt/nRUpEHU4w=; fh=pmfIAu1zZ/y4MK+Ok8pH+KJi8l1vy8Cep5fL3L/xSOQ=; b=K/Kv4RuZsVKAnEiQmgvB0mgZa0wlsN4PVUNEHyxm7oMg2OSxZdhWtVAGX0eAEjoF5d hhSABik1S19GpXCRiuEh6W7Xw8tau4OuHELTxkZiso2gFlPcbcKCHkhisj7D3SRwHSL+ wcrsCf/930RFlR55X46c8WlYXL8WD7iVA/RD6nU8AFL0mnCS1f9kzTnCrM8YFsUvbcAe NhzEc0vai4GHxRCK5Me3WJGa6Yj/mKDO3/Cc2a3ofQ04AKI4OSJIuSiD4rFCPeah9WOf ne4xjWIQP1zKpFPENR2fSrYs02B8EfxzQcz95k63Vl07xOUUppxcm9+Hkxt+NOA9lIW8 9gfw==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782995596; x=1783600396; darn=lists.xenproject.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+WSGWfYa7gMrkFqASJhZI8VjZ8XuFjtdt/nRUpEHU4w=; b=EeP1nFBzAflEdB/TPMaAEUsp7OZU5/nq1qqDyyILV+S6AxuXIYm/6FXlTDL68+gRKs YO6GvMgUFlySaCPH3UuDr8/YW2wgIuG+59LgGeRQKyRAXPf/WCMZnvBAGbzAmaWBi+TO HqoxTeEEcPeOFa72YN7sm6118ap9O2B7Ypp6mP31lv0LumgwoDU1/fM59pGB5bAkIAfA btnMeFynbnjOfqQaFlsleFxd4gxEdMIJQc/4qEoIlB2b5GI4VNV2XhSnrcyvw+eAEFzF RCcbGokdv+0GvVGC3L4/l4TCu1u6i3nwRnDGRGqkxVv0ld3yh9c6N9Uev3WLMUhYD8Y6 MCrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782995596; x=1783600396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+WSGWfYa7gMrkFqASJhZI8VjZ8XuFjtdt/nRUpEHU4w=; b=XfvLS45axmqC6V8ljgtXba5iLyiw0d4N1BPeNONwRNhJeX2ZCsYOR+2SxNufqMJ/I8 LkZqI//xzsBkIEABIW9VQaEM2b+s8Bps80RQlFBQDxRpRu96FkUVQ13tQDYBfIsQLZMB /n+mYxx+IruFANUKXWl25u8bwbNiJi2GtlkVrbp+hwfMFNyJ5LSNL8eq/VQdxLbRicCk uwtPV5xqsyaIorCjWVQ2M7JwqOKvXdRiNHNCC6B5yrvXUBXrE9zR83qDVV8vBTE6sjGJ lH9sDrHfJn42QEzzrHy7Q0ZRHhu/T5ZIVuLI12rK3dnmwd61g6W3kjAJb2wfDDDXUEeK 9y6w== X-Gm-Message-State: AOJu0YyHFJKNF5zV4L7h4JWLwUIVAoDVguyXeyk1GZfHM5EDQI3AZ7g+ EwFeUDTu0EYyUxA7R3vDm8Z7D2MwYIL5HUHpsn1wh0/+L+W2ziNLYgMtI5yGQNJvwhRCbtfTv2R 2wTeYtd5GIrdEx8HL/1IbzUaWDQbKEI4= X-Gm-Gg: AfdE7ckH2ejko7yoTHsD3Jti4YIGcrbhDtDhBgdn4kP9kuL7+en2dmpsZlZsEMGIBSC 6BbJzWi6AA2w2lab74IQNmith9d5U07oGdg046ci3nO7Yu48rY+5IlLYVkUWgqUTxRkdWJDOj7S gsIoT0lTIY8ILVe0uq0zsRwCVcm32zkpzXaIc9vmySY9EbuP4XWmcaYZen9SvVC93m2GQJdESd8 bmjjo+hlEu9aXyg94ChWny0UPO2kttsXgPLE3vahMZJMqmaA9azTGWuQVU9ErBePu4yUXo3yMVr zD5oZW86Zb/GM7O9Jowq5cM= X-Received: by 2002:a05:690e:c4a:b0:664:ae6b:b49f with SMTP id 956f58d0204a3-66521df7ecemr5780590d50.84.1782995596295; Thu, 02 Jul 2026 05:33:16 -0700 (PDT) MIME-Version: 1.0 References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-4-frediano.ziglio@citrix.com> <73d8b955-8462-47ce-8913-d11303bf63c3@citrix.com> In-Reply-To: <73d8b955-8462-47ce-8913-d11303bf63c3@citrix.com> From: Frediano Ziglio Date: Thu, 2 Jul 2026 13:33:05 +0100 X-Gm-Features: AVVi8CfiNk8R3HWPdAWYqLYbbFbfGclL4KGvJwM6ZfR2wmiHZqxS3xp-wW99V30 Message-ID: Subject: Re: [PATCH v6 03/16] libs/guest: Reduce number of I/O vectors in write_batch To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-d62444/1782995597-FECC61E0-9FB1387F/0/0 X-purgate-type: clean X-purgate-size: 1108 On Tue, 30 Jun 2026 at 17:47, Andrew Cooper wro= te: > > > This has the same exact subject as the prior patch. > > Either it wants merging, as they're both in the same function, or the > subject wants to be different. Even a "Further ..." prefix would help. > > On 19/06/2026 2:04 pm, Frediano Ziglio wrote: > > Each page was sent using a different iovec item. This potentially excee= d > > Linux maximum (1024). > > Linux cannot have a maximum of 1024 because this has been working fine > for a decade using 1028 in the common case. > But the code does not call writev or similars directly, so there's no limit besides the sky. The result with 1028 is simply that you do 2 system calls instead of one. > > Coalesce adjacent IO vector elements to attempt to reduce the number of > > overall IO vectors for each operation. > > Also some implementation (MiniOS) emulate writev with multiple write ca= lls. > > > > Signed-off-by: Frediano Ziglio > > Reviewed-by: Roger Pau Monn=C3=A9 > Frediano From xen-devel-bounces@lists.xenproject.org Thu Jul 02 12:39:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 12:39:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351830.1608869 (Exim 4.92) (envelope-from ) id 1wfGhq-00016q-6m; Thu, 02 Jul 2026 12:39:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351830.1608869; Thu, 02 Jul 2026 12:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGhq-00016j-3Z; Thu, 02 Jul 2026 12:39:50 +0000 Received: by outflank-mailman (input) for mailman id 1351830; Thu, 02 Jul 2026 12:39:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGho-00016d-G6 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:39:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfGhn-00Ed1n-PD for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:39:47 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a465c0e-5cb7-0a2a0a5109dd-0a2a45019d10-26 for ; Thu, 02 Jul 2026 14:39:47 +0200 Received: from [95.215.58.172] (helo=out-172.mta1.migadu.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a465c13-400f-0a2a45010019-5fd73aacfb8b-3 for ; Thu, 02 Jul 2026 14:39:47 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782995985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MSqvG6QTDeOE5qt8LI9tLb3iySB/2eramUM4HlZdPG8=; b=F10EZD2MKuMsgIZGg+Kv4CpsFBAqfutqUSZV+CnlSj4mTRO6SM+hx7IFnwTXi02n4W5ksq B3eV7EruPZaVg8GiZqN77RrtZjvlyRAPzkka+Z5kYwT5shcZ0occtt6vxWz8dsjkDZRJwI jZvjN/4FCRiAB3/YW0BqvRoNYnrlgRU= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 08/13] mm: introduce vma_get_page_prot() and use it Date: Thu, 2 Jul 2026 20:38:45 +0800 Message-Id: <20260702123845.95316-1-lance.yang@linux.dev> In-Reply-To: <3bb8bdc4788230c33102166d56cbc5abfad9d4cb.1782760670.git.ljs@kernel.org> References: <3bb8bdc4788230c33102166d56cbc5abfad9d4cb.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-d62444/1782995987-82CC61E0-273DAF2E/0/0 X-purgate-type: clean X-purgate-size: 1633 On Mon, Jun 29, 2026 at 08:25:31PM +0100, Lorenzo Stoakes wrote: >There's a large number of vm_get_page_prot(vma->vm_flags) invocations. Make >life easier by introducing vma_get_page_prot() parameterised by the VMA. > >This also makes converting vm_get_page_prot() to vma_flags_t easier. > >Also update the userland VMA tests to reflect the change. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- > drivers/gpu/drm/drm_gem.c | 2 +- > drivers/gpu/drm/drm_gem_dma_helper.c | 2 +- > drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 6 +++--- > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 12 ++++++------ > drivers/gpu/drm/msm/msm_gem.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- > drivers/gpu/drm/omapdrm/omap_gem.c | 6 +++--- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- > drivers/gpu/drm/tegra/gem.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_vram.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c | 2 +- > drivers/gpu/drm/xe/xe_device.c | 2 +- > drivers/gpu/drm/xe/xe_mmio_gem.c | 2 +- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- > drivers/video/fbdev/core/fb_io_fops.c | 2 +- One missed? drivers/gpu/drm/panthor/panthor_gem.c still has: vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); Can use vma_get_page_prot(vma) too. [...] From xen-devel-bounces@lists.xenproject.org Thu Jul 02 12:51:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 12:51:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351846.1608878 (Exim 4.92) (envelope-from ) id 1wfGt3-0003y0-4i; Thu, 02 Jul 2026 12:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351846.1608878; Thu, 02 Jul 2026 12:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGt3-0003xt-1m; Thu, 02 Jul 2026 12:51:25 +0000 Received: by outflank-mailman (input) for mailman id 1351846; Thu, 02 Jul 2026 12:51:23 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfGt0-0003xU-8N for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 12:51:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfGsy-007X31-36 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:51:21 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a465ec2-e002-0a2a0a5209dd-0a2a45079942-14 for ; Thu, 02 Jul 2026 14:51:19 +0200 Received: from [95.215.58.179] (helo=out-179.mta1.migadu.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a465ec5-9c8e-0a2a45070019-5fd73ab35c1e-3 for ; Thu, 02 Jul 2026 14:51:17 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782996675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KCmq1hZLLl7GOyWtL6cRPjjbHfWJ5jvpchLdwXolxL8=; b=F4ZVf9BvB+hLAf9gQChbe4sRNb4sLCrUWRBNFM0pPt8IAzUbVhXxDEH/DvD8axflIDk2vm 3zmwuSmbnQ/BvpRKYzyKP8V+Wt7x4/jYspjeo/Nuwy87WFjjbKm5Us6Gqkc64N1S5Bi0bl Qu3WpSOCEMC/DqM+tZU+hrTjGqJDt6Q= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 09/13] mm/vma: update create_init_stack_vma() to use vma_flags_t Date: Thu, 2 Jul 2026 20:50:52 +0800 Message-Id: <20260702125052.19248-1-lance.yang@linux.dev> In-Reply-To: <34689784ee6856f100c02ad4eabeaa4db643713a.1782760670.git.ljs@kernel.org> References: <34689784ee6856f100c02ad4eabeaa4db643713a.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-ef75cf/1782996679-7E32725E-8D5CFD8E/0/0 X-purgate-type: clean X-purgate-size: 518 On Mon, Jun 29, 2026 at 08:25:32PM +0100, Lorenzo Stoakes wrote: >Replace use of the legacy vm_flags_t flags with vma_flags_t values in >create_init_stack_vma(). > >As part of this change we add VMA_STACK_EARLY and VMA_STACK_INCOMPLETE >vma_flags_t defines, and slightly rework create_init_stack_vma() for >clarity. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- Nothing looks off to me ;) Feel free to add: Reviewed-by: Lance Yang From xen-devel-bounces@lists.xenproject.org Thu Jul 02 13:13:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 13:13:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351871.1608888 (Exim 4.92) (envelope-from ) id 1wfHE8-0007xG-My; Thu, 02 Jul 2026 13:13:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351871.1608888; Thu, 02 Jul 2026 13:13:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHE8-0007x9-K5; Thu, 02 Jul 2026 13:13:12 +0000 Received: by outflank-mailman (input) for mailman id 1351871; Thu, 02 Jul 2026 13:13:11 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHE6-0007x3-NA for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:13:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfHE5-006pFj-84 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:13:10 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4663e2-bab6-0a2a0a5309dd-0a2a45018f08-12 for ; Thu, 02 Jul 2026 15:13:08 +0200 Received: from [91.218.175.179] (helo=out-179.mta0.migadu.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4663e3-400f-0a2a45010019-5bdaafb3e00f-3 for ; Thu, 02 Jul 2026 15:13:07 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782997985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WkYIESER5H1pxokBfEp6m9xEZZ5ghGe4TjZZy4BO5I=; b=jHDhEc6CTiPftGqyHzVdl3xS/wEnOHSN4PeeVFnRX9fUml//8WA53GAPbsxSbJvWuzc/sf tH1rSEqcTxDFS7qyJ0iIaX/a6tA48FPP/mFE4c/byOkvPcPlvJwYSUFubJkz9Jxs6S5ya/ AItLuFoisprFM8kvEpkf04Kk84Cg/T0= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm Date: Thu, 2 Jul 2026 21:12:33 +0800 Message-Id: <20260702131233.59026-1-lance.yang@linux.dev> In-Reply-To: <1e7d834c887b6a65627d730addcff13d458c6268.1782760670.git.ljs@kernel.org> References: <1e7d834c887b6a65627d730addcff13d458c6268.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-d62444/1782997988-838C81E0-A776CE22/0/0 X-purgate-type: clean X-purgate-size: 1577 On Mon, Jun 29, 2026 at 08:25:33PM +0100, Lorenzo Stoakes wrote: >Update various uses of legacy flags in vma.c and mmap.c to the new >vma_flags_t type, updating comments alongside them to be consistent. > >Also update __install_special_mapping() to rearrange things slightly to >accommodate the changes. > >Signed-off-by: Lorenzo Stoakes >--- [...] >diff --git a/mm/vma.c b/mm/vma.c >index b81c05e67a61..ab2ef0f04420 100644 >--- a/mm/vma.c >+++ b/mm/vma.c >@@ -3417,23 +3417,27 @@ struct vm_area_struct *__install_special_mapping( > vm_flags_t vm_flags, void *priv, > const struct vm_operations_struct *ops) > { >- int ret; >+ vma_flags_t vma_flags = legacy_to_vma_flags(vm_flags); > struct vm_area_struct *vma; >+ int ret; > > vma = vm_area_alloc(mm); >- if (unlikely(vma == NULL)) >+ if (unlikely(!vma)) > return ERR_PTR(-ENOMEM); > >- vma_set_range(vma, addr, addr + len, 0); >- vm_flags |= vma_flags_to_legacy(mm->def_vma_flags) | VM_DONTEXPAND; >+ vma_flags_set_mask(&vma_flags, mm->def_vma_flags); >+ vma_flags_set(&vma_flags, VMA_DONTEXPAND_BIT); > if (pgtable_supports_soft_dirty()) >- vm_flags |= VM_SOFTDIRTY; >- vm_flags_init(vma, vm_flags & ~VM_LOCKED_MASK); >+ vma_flags_set(&vma_flags, VMA_SOFTDIRTY_BIT); >+ vma_flags_clear_mask(&vma_flags, VMA_LOCKED_MASK); >+ vma->flags = vma_flags; Maybe worth a vma_flags_init() helper here to mirror vm_flags_init()? With this open-coded, we lose the soft-dirty WARN_ON_ONCE sanity check. Might be nicer to keep that check in one place ;) [...] From xen-devel-bounces@lists.xenproject.org Thu Jul 02 13:19:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 13:19:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351883.1608896 (Exim 4.92) (envelope-from ) id 1wfHJj-0000YY-93; Thu, 02 Jul 2026 13:18:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351883.1608896; Thu, 02 Jul 2026 13:18:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHJj-0000YR-6P; Thu, 02 Jul 2026 13:18:59 +0000 Received: by outflank-mailman (input) for mailman id 1351883; Thu, 02 Jul 2026 13:18:58 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHJi-0000X6-7h for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:18:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfHJh-005sZh-3I for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:18:57 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a466532-bab6-0a2a0a5309dd-0a2a450c867c-24 for ; Thu, 02 Jul 2026 15:18:56 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a466540-f399-0a2a450c0019-d1558035c853-3 for ; Thu, 02 Jul 2026 15:18:56 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493c19bad03so14857945e9.2 for ; Thu, 02 Jul 2026 06:18:56 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6354926sm58037265e9.1.2026.07.02.06.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 06:18:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782998336; x=1783603136; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=f/ZNJVP0fUmpD0EWNlk5M4ki1CL0rYI/U52aPfaxbz4=; b=WsYyfrrtWoDIpamn59Lt1Jb/jnAI2UAlo0GJ8qW3UBbBcHroPtgtTSq/Bgx9Mzxh9S a2c7p3gxKOXsRojFf/D5RKnpKg3spkV5olmi4sCZ1FJVaJaHnHvoleuUfrigy6zy1sJh lVvpR/7NpT9AsesF0yljEVah+ZdeiLxf8oFJo8JEzmw+cbNnjh3HirspVZ9MPDRcrSgu WrKW9ZWx5ztYq+Yjrr/YfCDQUgYVkYeWqOGzy5db8rSXMvmcvARkv+T3ysXYNdyEj6wP MbsQ+Dgyv4tqJRoo2c61R8HkupmRzEwCHd/7sRt/hb///qdLltrykjMNeRDW1Lp/lhCd GDsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782998336; x=1783603136; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f/ZNJVP0fUmpD0EWNlk5M4ki1CL0rYI/U52aPfaxbz4=; b=HwBRcBY3WovYDjCS0Xu0wmo8aBlW5ijKM3nzhhbuXveCJOCd0K8JX9ucVsP09EadNx rRi64g4wqUTzzYYnYtBZrebnM1ski5zt/j9G7eandmKAcMrMFvPYI026PxIWstTzWh9p 7w30wEGsb7oGFhRPweKIjkwfC5h/I4vPJHA1zLvExoM1FFusioylfQOt8K+8ziw2jCBb yI3D4LaHQ00tlgCrrxl3KAFIGN0AzsgkVd3CGzJMEiDZ1t/W3CG5m5pbx68Fokz+EyFN 0d26QdDkyiHyQWeW6Sh+zgWl49xkc7Pqj2XvByjpBXMFkXyeHA12iMvwrHMy4ZabZ9dq 1HzA== X-Forwarded-Encrypted: i=1; AFNElJ/SQFr8geir8/3zCyqQYUKSblJHTsaLPuWdEqtH9wUpyxEoklcrwSlaI7VmVL9dhfY+i8bl5KKaXN8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzBIEQXFC+912utB6KJlLeckHahWyquXMwcBnwPj9v5o0AtlRS2 Bq8boWi2Rwx7X8/M/+i616ITHd5yCY66vFEX9qWzluoQJnMJztjpMLiCIMAvDrAs4SpVGD2mSMY vk60t2A== X-Gm-Gg: AfdE7ckixdpLZqHdL6E6XoTMmX+xu9+Qtx66Yj5idTrSw+FLTySwoWvOQbWgh0hkVLO OVPghlu1cK83RqjT70mRA/y5Uy1ggjsuveYLrKz6Oo4htItW/SBunGk/eMy/3MSSruM/kPh1PyZ p6PXrFgolIp0Owhh0ii3cfNtSYOpt1F/PRckRZ3tuTDD2NrN0+pG9MSkIfP2Co32A/Hh9U1JVCb mPiM3H/ZHaO4w7pX+LSdQRZit719879LplB902tPyOepnvXk1mvZ9S8RG9pIKEv3ay7GlPufV6l iA468rxh9QgV0oCXodLuUGNHowfbV9kKHCXFhmdaAdwGvAyJab9wTKMOPHfpacIyT0IYPcWc133 dxTJkfRzkTFGEB/BqkqpsACAW96RAhijmjE+FYNFVihcwi9lbIxotWMySGuDYR8FBla4C2qDViv Yhg4BVXW3Lv4Z7lK6mM2x9jQq5tToSblm3+csswl4QbD6avnHOOn9KSHFnUCU+To8Jy1yjdqQrV suPOZRxpxGW0fo= X-Received: by 2002:a05:600c:a00c:b0:493:c4e1:40a6 with SMTP id 5b1f17b1804b1-493c4e140f9mr45568225e9.32.1782998336287; Thu, 02 Jul 2026 06:18:56 -0700 (PDT) Message-ID: <20836109-fadf-4ad4-ad9e-9fa44883716a@suse.com> Date: Thu, 2 Jul 2026 15:18:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] x86/HVM: don't (almost) open-code POP_GPRS To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> <6065311f-15b3-403e-b39c-f9652f0513ff@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6065311f-15b3-403e-b39c-f9652f0513ff@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1782998336-91128D51-B08C898D/0/0 X-purgate-type: clean X-purgate-size: 1206 On 02.07.2026 13:31, Andrew Cooper wrote: > On 02/07/2026 11:55 am, Jan Beulich wrote: >> It can be used as-is for VMX. For SVM the special treatment of %rax needs >> accounting for. >> >> Signed-off-by: Jan Beulich >> --- >> This is the minimum required as a prereq to the next patch (to avoid the >> need for custom adjustments in the two places). We could go further and >> switch to using PUSH_AND_CLEAR_GPRS at the same time. > > I've got several part-series that result in purging SAVE_ALL/RESTORE_ALL. > > If you want to put this patch in, then Acked-by: Andrew Cooper > Thanks. Yes, I think I'll put it in as one small piece in the move. > but I firmly want to finish my series before > patch 2 adds yet-more complexity to macros which I'm wanting to remove > for being too complicated already. Well, if you make this a strict prereq, then I might as well make one or more patches myself to replace at least the SAVE_ALL the next patch needs to fiddle with. Or else I'd like to understand when you expect your work to arrive, as this series imo is one of those which have already been blocked for far too long. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 13:21:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 13:21:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351893.1608906 (Exim 4.92) (envelope-from ) id 1wfHMN-0002FJ-LU; Thu, 02 Jul 2026 13:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351893.1608906; Thu, 02 Jul 2026 13:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHMN-0002FC-Ig; Thu, 02 Jul 2026 13:21:43 +0000 Received: by outflank-mailman (input) for mailman id 1351893; Thu, 02 Jul 2026 13:21:42 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHMM-0002F6-Dt for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:21:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfHML-006qr4-Qp for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:21:41 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4665d3-5cb7-0a2a0a5109dd-0a2a45019050-46 for ; Thu, 02 Jul 2026 15:21:41 +0200 Received: from [91.218.175.178] (helo=out-178.mta0.migadu.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4665e5-400f-0a2a45010019-5bdaafb2370c-3 for ; Thu, 02 Jul 2026 15:21:41 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782998499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JUypSg4x3H5Npdac5Q/QNTHcczAl9LnBdMVXVWinEec=; b=lItd+RyL3jRAHkpl0dxrPEWed2AY0HWUHX4RwICujMLfpbUgWjWjW+ARImTVfb6PHm9Sny y6V8i67fWjOA8LCWLGCzxRy43+gvonIsLNLIP4rLaMNI+LWR2I1BadswAi+4/7c6z/eUrS IlFVPIdu28UO/M5UjVs/++abx0FKfS4= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 11/13] mm/mlock: convert mlock code to use vma_flags_t Date: Thu, 2 Jul 2026 21:21:07 +0800 Message-Id: <20260702132107.73727-1-lance.yang@linux.dev> In-Reply-To: <2db16db81538355ca65f778c246d2381c673cad4.1782760670.git.ljs@kernel.org> References: <2db16db81538355ca65f778c246d2381c673cad4.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-d62444/1782998501-D14DD1E0-880B5E1E/0/0 X-purgate-type: clean X-purgate-size: 1714 On Mon, Jun 29, 2026 at 08:25:34PM +0100, Lorenzo Stoakes wrote: >Replace use of the legacy vm_flags_t flags with vma_flags_t values >throughout the mlock logic. > >Additionally update comments to reflect the changes to be consistent. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- Nothing scary jumped out at me. Just one tiny nit below ;) [...] >@@ -466,24 +466,23 @@ static void mlock_vma_pages_range(struct vm_area_struct *vma, > */ > static int mlock_fixup(struct vma_iterator *vmi, struct vm_area_struct *vma, > struct vm_area_struct **prev, unsigned long start, >- unsigned long end, vm_flags_t newflags) >+ unsigned long end, vma_flags_t *new_vma_flags) > { >- vma_flags_t new_vma_flags = legacy_to_vma_flags(newflags); > const vma_flags_t old_vma_flags = vma->flags; > struct mm_struct *mm = vma->vm_mm; > int nr_pages; > int ret = 0; > >- if (vma_flags_same_pair(&old_vma_flags, &new_vma_flags) || >+ if (vma_flags_same_pair(&old_vma_flags, new_vma_flags) || > vma_is_secretmem(vma) || !vma_supports_mlock(vma)) { > /* >- * Don't set VM_LOCKED or VM_LOCKONFAULT and don't count. >+ * Don't set VMA_LOCKED_BIT or VM_LOCKONFAULT and don't count. s/VM_LOCKONFAULT/VMA_LOCKONFAULT_BIT/ Otherwise LGTM. Feel free to add: Reviewed-by: Lance Yang > * For secretmem, don't allow the memory to be unlocked. > */ > goto out; > } > >- vma = vma_modify_flags(vmi, *prev, vma, start, end, &new_vma_flags); >+ vma = vma_modify_flags(vmi, *prev, vma, start, end, new_vma_flags); > if (IS_ERR(vma)) { > ret = PTR_ERR(vma); > goto out; [...] From xen-devel-bounces@lists.xenproject.org Thu Jul 02 13:50:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 13:50:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351916.1608914 (Exim 4.92) (envelope-from ) id 1wfHoC-00086Y-RZ; Thu, 02 Jul 2026 13:50:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351916.1608914; Thu, 02 Jul 2026 13:50:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHoC-00086R-Oz; Thu, 02 Jul 2026 13:50:28 +0000 Received: by outflank-mailman (input) for mailman id 1351916; Thu, 02 Jul 2026 13:50:27 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfHoA-00086L-80 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 13:50:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfHo9-006nIQ-1t for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:50:25 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a466c97-2eae-0a2a0a5409dd-0a2a4503a584-30 for ; Thu, 02 Jul 2026 15:50:24 +0200 Received: from [91.218.175.188] (helo=out-188.mta0.migadu.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a466c9b-ec1a-0a2a45030019-5bdaafbcdeea-3 for ; Thu, 02 Jul 2026 15:50:19 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-Id:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783000216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n7JedrMMFsZ3SA9xp8Er9WQ7Q5NWmS7gMbpQ8O+PQSg=; b=SBk2LGdo8O2Fh816oQbqXrmhKAQAYAxHqV6r2z//9k66SRzp2XfssdY3VkdvqTHoJEhhne KBLV5b7WimMmbUd67b8UpLhwJTAsCl8UHKUpcr3XwD//YOwU43JswyAPjZ9yhLgdwnTOAg TszqN8wOwdlDLsXMvuRT5nF6gC9LQmA= From: Lance Yang To: ljs@kernel.org Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t Date: Thu, 2 Jul 2026 21:49:47 +0800 Message-Id: <20260702134947.25189-1-lance.yang@linux.dev> In-Reply-To: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> References: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-33051d/1783000224-B57BF5D1-802020C5/0/0 X-purgate-type: clean X-purgate-size: 6121 On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote: >Replace use of the legacy vm_flags_t flags with vma_flags_t values >throughout the mremap logic. > >Additionally update comments to reflect the changes to be consistent. > >No functional change intended. > >Signed-off-by: Lorenzo Stoakes >--- The vm_flags_set() cases below spell out vma_start_write(), but the vm_flags_clear() cases don't? Thanks, Lance > mm/mremap.c | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > >diff --git a/mm/mremap.c b/mm/mremap.c >index 079a0ba0c4a7..0ea43302b7ed 100644 >--- a/mm/mremap.c >+++ b/mm/mremap.c >@@ -68,7 +68,7 @@ struct vma_remap_struct { > bool populate_expand; /* mlock()'d expanded, must populate. */ > enum mremap_type remap_type; /* expand, shrink, etc. */ > bool mmap_locked; /* Is mm currently write-locked? */ >- unsigned long charged; /* If VM_ACCOUNT, # pages to account. */ >+ unsigned long charged; /* If VMA_ACCOUNT_BIT, # pgs to account */ > bool vmi_needs_invalidate; /* Is the VMA iterator invalidated? */ > }; > >@@ -954,7 +954,7 @@ static unsigned long vrm_set_new_addr(struct vma_remap_struct *vrm) > > if (vrm->flags & MREMAP_FIXED) > map_flags |= MAP_FIXED; >- if (vma->vm_flags & VM_MAYSHARE) >+ if (vma_test(vma, VMA_MAYSHARE_BIT)) > map_flags |= MAP_SHARED; > > res = get_unmapped_area(vma->vm_file, new_addr, vrm->new_len, pgoff, >@@ -976,7 +976,7 @@ static bool vrm_calc_charge(struct vma_remap_struct *vrm) > { > unsigned long charged; > >- if (!(vrm->vma->vm_flags & VM_ACCOUNT)) >+ if (!vma_test(vrm->vma, VMA_ACCOUNT_BIT)) > return true; > > /* >@@ -1003,7 +1003,7 @@ static bool vrm_calc_charge(struct vma_remap_struct *vrm) > */ > static void vrm_uncharge(struct vma_remap_struct *vrm) > { >- if (!(vrm->vma->vm_flags & VM_ACCOUNT)) >+ if (!vma_test(vrm->vma, VMA_ACCOUNT_BIT)) > return; > > vm_unacct_memory(vrm->charged); >@@ -1023,7 +1023,7 @@ static void vrm_stat_account(struct vma_remap_struct *vrm, > struct vm_area_struct *vma = vrm->vma; > > vm_stat_account(mm, vma->vm_flags, pages); >- if (vma->vm_flags & VM_LOCKED) >+ if (vma_test(vma, VMA_LOCKED_BIT)) > mm->locked_vm += pages; > } > >@@ -1167,7 +1167,7 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > * arose, in which case we _do_ wish to unmap the _new_ VMA, which means > * we actually _do_ want it be unaccounted. > */ >- bool accountable_move = (vma->vm_flags & VM_ACCOUNT) && >+ bool accountable_move = vma_test(vma, VMA_ACCOUNT_BIT) && > !(vrm->flags & MREMAP_DONTUNMAP); > > /* >@@ -1186,7 +1186,7 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > * portions of the original VMA that remain. > */ > if (accountable_move) { >- vm_flags_clear(vma, VM_ACCOUNT); >+ vma_clear_flags(vma, VMA_ACCOUNT_BIT); > /* We are about to split vma, so store the start/end. */ > vm_start = vma->vm_start; > vm_end = vma->vm_end; >@@ -1211,8 +1211,8 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > * | | > * |-------------| > * >- * Having cleared VM_ACCOUNT from the whole VMA, after we unmap above >- * we'll end up with: >+ * Having cleared VMA_ACCOUNT_BIT from the whole VMA, after we unmap >+ * above we'll end up with: > * > * addr end > * | | >@@ -1232,13 +1232,15 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > if (vm_start < addr) { > struct vm_area_struct *prev = vma_prev(&vmi); > >- vm_flags_set(prev, VM_ACCOUNT); /* Acquires VMA lock. */ >+ vma_start_write(prev); >+ vma_set_flags(prev, VMA_ACCOUNT_BIT); > } > > if (vm_end > end) { > struct vm_area_struct *next = vma_next(&vmi); > >- vm_flags_set(next, VM_ACCOUNT); /* Acquires VMA lock. */ >+ vma_start_write(next); >+ vma_set_flags(next, VMA_ACCOUNT_BIT); > } > } > } >@@ -1321,8 +1323,8 @@ static void dontunmap_complete(struct vma_remap_struct *vrm, > unsigned long old_start = vrm->vma->vm_start; > unsigned long old_end = vrm->vma->vm_end; > >- /* We always clear VM_LOCKED[ONFAULT] on the old VMA. */ >- vm_flags_clear(vrm->vma, VM_LOCKED_MASK); >+ /* We always clear VMA_LOCKED[ONFAULT]_BIT on the old VMA. */ >+ vma_clear_flags_mask(vrm->vma, VMA_LOCKED_MASK); > > /* > * anon_vma links of the old vma is no longer needed after its page >@@ -1758,14 +1760,14 @@ static int check_prep_vma(struct vma_remap_struct *vrm) > * based on the original. There are no known use cases for this > * behavior. As a result, fail such attempts. > */ >- if (!old_len && !(vma->vm_flags & (VM_SHARED | VM_MAYSHARE))) { >+ if (!old_len && !vma_test_any(vma, VMA_SHARED_BIT, VMA_MAYSHARE_BIT)) { > pr_warn_once("%s (%d): attempted to duplicate a private mapping with mremap. This is not supported.\n", > current->comm, current->pid); > return -EINVAL; > } > > if ((vrm->flags & MREMAP_DONTUNMAP) && >- (vma->vm_flags & (VM_DONTEXPAND | VM_PFNMAP))) >+ vma_test_any(vma, VMA_DONTEXPAND_BIT, VMA_PFNMAP_BIT)) > return -EINVAL; > > /* >@@ -1795,7 +1797,7 @@ static int check_prep_vma(struct vma_remap_struct *vrm) > return 0; > > /* We are expanding and the VMA is mlock()'d so we need to populate. */ >- if (vma->vm_flags & VM_LOCKED) >+ if (vma_test(vma, VMA_LOCKED_BIT)) > vrm->populate_expand = true; > > /* Need to be careful about a growing mapping */ >@@ -1803,10 +1805,10 @@ static int check_prep_vma(struct vma_remap_struct *vrm) > if (pgoff + (new_len >> PAGE_SHIFT) < pgoff) > return -EINVAL; > >- if (vma->vm_flags & (VM_DONTEXPAND | VM_PFNMAP)) >+ if (vma_test_any(vma, VMA_DONTEXPAND_BIT, VMA_PFNMAP_BIT)) > return -EFAULT; > >- if (!mlock_future_ok(mm, vma->vm_flags & VM_LOCKED, vrm->delta)) >+ if (!mlock_future_ok(mm, vma_test(vma, VMA_LOCKED_BIT), vrm->delta)) > return -EAGAIN; > > if (!may_expand_vm(mm, &vma->flags, vrm->delta >> PAGE_SHIFT)) >-- >2.54.0 > > From xen-devel-bounces@lists.xenproject.org Thu Jul 02 14:09:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 14:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351930.1608924 (Exim 4.92) (envelope-from ) id 1wfI68-0002Ay-8E; Thu, 02 Jul 2026 14:09:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351930.1608924; Thu, 02 Jul 2026 14:09:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfI68-0002Ar-5G; Thu, 02 Jul 2026 14:09:00 +0000 Received: by outflank-mailman (input) for mailman id 1351930; Thu, 02 Jul 2026 14:08:59 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfI66-0002Al-Pw for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:08:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfI66-00EvtM-0T for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:08:58 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4670f6-e002-0a2a0a5209dd-0a2a45059590-4 for ; Thu, 02 Jul 2026 16:08:57 +0200 Received: from [52.101.43.32] (helo=SJ2PR03CU001.outbound.protection.outlook.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4670f7-3cb2-0a2a45050019-34652b205362-3 for ; Thu, 02 Jul 2026 16:08:57 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by CH3PR03MB7508.namprd03.prod.outlook.com (2603:10b6:610:19c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Thu, 2 Jul 2026 14:08:49 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Thu, 2 Jul 2026 14:08:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mY86+0PeAFLHOpNwnQRFu5CYuTNmSOfF3u+9/uCH+QTVZLbpODfVjfC5vffcf80RDD5xBeLZwp6cLJUmpIIuPVboOyu0MM3O51k23reyPBRP5xnMqdhimdlTvPsUljzpeepfg+P1rYEc13umvOOXs9RF59CXPSZoWE3bheA1o83wgKONUu82q33wV4K9ZpWAcesr6Uag6aziYuijpzIyikyL+DL2TNkTqwuCkmG+/wnZI6OKyfWYTLFijQYt1Y2GKYs0Vw19VkBmUsi4j+05cVzvVoVQwmXpnvFmIp41mL753/zQ70m30UsZOSFmaDqzG2uSNF6/SO+B8/VSzkMiZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ofN1ll3EDoK8dYwj/6OEn+2jPQWTZas/sO08x1VmQLY=; b=hHfvaShjYm0HMSG/3OsGBTeZ4UUirYcjJ7FyzQBonL5BB20MG29bV+vAtJyJLMYCqgIKQXygwGwCiFBjl9Zs/IqjZxfOrugsusvwk5zjOto2QEKB2ANozvlJ33JYnfXiQNEcMADvZ2WkKD/NcH6N6Rui/3u6ninIBe8bF72CvL6C5mGnOFJuYNAEckJQKsdB7V32EW2LmfAqczdB59WEXeYZhGJ5upvXwhLAff+apSR5NCI86Hk86sHhtvGT0oKUSa2iS5orvWVlStHWpBwDL9NLbDlYSlaJFT9YGxtOivtVzluKjJ2txg8lXE9mgjS89VKcvcCHWjj2SNJwVBhm0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ofN1ll3EDoK8dYwj/6OEn+2jPQWTZas/sO08x1VmQLY=; b=yyLLAy9uj/hgOTxpJ+VlFGV518V1A/OlhQiSdlmOool1EPpLpHVP60NSyhrKOq1EQlD28Lc5RDRTU3G2L/JwEelnsGUL3LlfgvYHYzFiAW06okNK08FJNlbCcSMMIG/6beGx0iG/l6ERDQcmj738tIlJFpgLqz1ygYKHkKWKmzY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <012d7d69-39c6-4e46-a817-83d57169f323@citrix.com> Date: Thu, 2 Jul 2026 15:08:46 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 1/4] x86/HVM: don't (almost) open-code POP_GPRS To: Jan Beulich References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> <6065311f-15b3-403e-b39c-f9652f0513ff@citrix.com> <20836109-fadf-4ad4-ad9e-9fa44883716a@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20836109-fadf-4ad4-ad9e-9fa44883716a@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0119.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::6) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|CH3PR03MB7508:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a29e7da-cd13-4e55-8eed-08ded8437041 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|366016|11063799006|56012099006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 6jRGnI3c1N3XNNJcqRxIQoXenReal/+d2tK6D8QyVZLkqZ8OyXZvCOyphfXE2Sx8ZPHtL9GbVj5y8Ek6dAsAlKwK3EBmpi38dv6fAuNXCTQDKtuSVXw2WWR6XVBCrH35vBnfC40vl0hwhuEBg/0BHBaIZWjpE9uOkC2s/cHOI2IzlCTRs9a42EJVn7m4+KRG7htURkYe8bzVsWZn7s984cLtUUuIm7Ng+OZHojxD8F9KTgMONyNNUNpWrfrNlrw6yNnULPmgP69rXW7cilGhNiwbiPBT0aKXko+nClzbk6d2upOzocLkppA1xOmG+Dzjw3tf0jP+YtmI+zhYx15p1cHIaC22nZlsvEfyjNDx1glCmobrNSxFS7MAA+lokonnA3eAkryG2HtgJ+oCf33qrccalyT5JbkQW0Ll9PdbRJSKEg5CWcZ01yukBCo63fKQ1dCu4CQ+vvsFn+k+/Og4KF5RpBZWR+BoTeTNtftHGMeA8ijlidc9G5FuZwKqFFofcIpPG4zuxGSPSlwCRXa61lVsprR6ylvYke08IoGdtnIkkXACTN/DaVTTiiZOxnVvqeGn8l73lCrB/A0TZDnAFt6hb1ZJtm0TeJVj/DA87LjUeVar9vyTAmsJ6a0vEKa0ElMmBiGLdnu9f7Lid60H1flOcZTcjOzMxjpFm1BIP7w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(11063799006)(56012099006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTRrdFpWajFQNWp2R3Nuc0hnOUhVVVNCdFhZU25LOExiMDdWV1RvNGo0cTVi?= =?utf-8?B?bEk2WWVqaFpqcW1PNHNLcjgrQ2w0VE1vdkNIMEQ5WVJLL2hjbS9RR1gvNGl3?= =?utf-8?B?L256Mm5MYkJMcjBGTFY1RklpcTU4YVgzQVk0YjVJSkR1ajY2dEQ0TmsxclF3?= =?utf-8?B?RU9YSjE2QjVZQUZqek40VytkYjF1TDdZTWZoMHY4TmFEVTRkQlhlNUZDTC9n?= =?utf-8?B?VkJ1a05FaGIyRjF4NUFBR3Jqd1Azb0VCV2g1eU11VTAwM0doWklxc1ZOcTgx?= =?utf-8?B?M0lNWWhveUJzZUFaa3BOejF6VnhRTVdrYndkSkt6bFNjTXR1TDIyanhhb3Qv?= =?utf-8?B?OS8yUENYb0hERSsxL3M0ZkhZTEN4Wm55NDBGK2Y3S29HN01NUFUwZFFTQllB?= =?utf-8?B?SUZGNWRhTGFYWTlXdzljUG1PekEzczY2VU9KcGtTVWJQK2JuZXNZT3NaN0xJ?= =?utf-8?B?UjZRemFxMTkrb0lPcXR4WEJFT25yY28zK3FlL2p2Qm14M1J5ZCtQWERxSG5W?= =?utf-8?B?TDJRSm5qTVNiekJIVncwakJuZVNuRVRtZ3JVOVF3Vk9rejgwL1AvNUMyc0xa?= =?utf-8?B?MzZNenpqSEU1ZmVaVnpUNVhCZGFmNWY5aXIweVJ4Y05sZ0dhU2Z1VGd1V1pM?= =?utf-8?B?eDV4RVMxSFc4N1N5cEFTaXFKTnVPN3o5TGFlOFlsbkFxQWVJOFNGcWJoZnhx?= =?utf-8?B?VGF0dmJVS2dVc2YzVTBXakpQRzNZYzNXbnh1SStVL1VYeVkzcThrc1JaZ1J4?= =?utf-8?B?Q29nR09zd1gvaG95eEcyVWsvNEFYb1JhbnF4bHFYZ2pTNzh1N3hmTzJTSXBU?= =?utf-8?B?WU5YcUk3WG10YkFyMEVuV3RFVDdodjIySXFHcFAyZEJ5WEt3ZTVHRGgyZGM0?= =?utf-8?B?OHBjdVNqQ1JVYzFQMGZBbTdvaWdJQUluSlNMY0JmWm02amFoZmprODY4MHpt?= =?utf-8?B?R2NycGtlZ29YWXpmU29qNFJrMUs4SVNRb0l1SDRxWTZXNmlQME10YkZzUys5?= =?utf-8?B?dk9RVFFVcXRhNTRCaVV0QWtnMi9mWE1vNDlML3N3VU02Wm0ybk5nbEhvVkdB?= =?utf-8?B?VG5hemdSVXU0T0NVbzBCTmxaTlI5SmxGRVRrYTV3eWJPQVo5M29yTGZMR0lX?= =?utf-8?B?T3ZyazRMUGF2TzB5S0Y5ZGZ2TVQzMHZrMEMrYVQzdXBnM2hPOE50RDg2anBv?= =?utf-8?B?ZFdOZ3MrWlp3UHpsdzZEbEVPSDJsdHlMemtjOXA5RGFnTmZvNDhISC8rMWxo?= =?utf-8?B?cjFoYmdiWEcxSHNOV0c2Uk5UM05mNDRUYWY0RTZXWVVDSDJRRlNURno0MXE1?= =?utf-8?B?aDBMTUp6cWcxamJWYVZ4TFdJUW5hRVRGMnExRkxadk94c08zRE96U1F4emxI?= =?utf-8?B?QmJ1eUhmY2Rsb1Qzb3UrYVI5WHAyL1ZDSkQyNi9TaUxCQVNtMlRrQ3dzbkph?= =?utf-8?B?VXJYVmFidy9Za3NYcVY3cU5RckxZMXltSktKR2RVTzJzQVBGTkhXZStoNDA5?= =?utf-8?B?ZlJKWVNkUG1DMGI2MkNnMm5BL2Y3SGh2Y0laVUtuRVdYYU80VU1saktVZ2Ry?= =?utf-8?B?eVdXTEk1elV4TjlsM09KVThzNDBxTGZDekZaZWMrY2Q4REhhUVdPMjdtVDMr?= =?utf-8?B?Wm10dDNKVTEwUWR4MnkwWDJNclkyS0VtT1QxdmV5VG5YWTBvems5NTNqOXpr?= =?utf-8?B?dDBBZDNMRzFXMGdjVDB3b0M2b09GWWt4L2taVDQ1RzhGNVNyVHBXTFl2UDNz?= =?utf-8?B?TzhGSm9oQlVqejhoeDNRQWxlOURCaGxFZUtLYnZoWGpZY2hJcFpSTjlFSEt2?= =?utf-8?B?QnRLYmtFMGhidCt4OXlxREoyUzBkSXhlNy9QcC9ycCtxajZtdVgyOGFEUUt1?= =?utf-8?B?VzVzTmJlcjRER2tDYjcrMWhLZE9pNHVDODZrb3JiMHh6ZU9iMGxNQjZZSUZ0?= =?utf-8?B?RHRhSmt3VXJoOFlvc1FROEE0dzdyRm9TNGpKTGhnUWJsSFFCWXJCVnBTTEF3?= =?utf-8?B?aCsrOTY0MDJHMlI5ZXlveVBQRytTV0tKbjlwS0JreVF4VjJKZUJRbCs4cFBK?= =?utf-8?B?eXRnRzVydHB1RitOczh0S0xaNElTZG4vanZyLzRSVGZZYlZGcCswZnRnYUtT?= =?utf-8?B?VUV4c3YxaUhkY3hmN0x1U0R6N0dxM084TzlHQ2dOUjRPZllYY3JqK1NaVFdR?= =?utf-8?B?VjVsakwzK25YSXRlamZtRW9MNFdRWnBNK2tuaS9CRGJUamlLc2R5UjdybWwz?= =?utf-8?B?aVpzZDRaVDgwVjNXNXUxUGtQRXNoTy9sOHRsYzVMTVZZbCtaaGlBRExMOFJo?= =?utf-8?B?UHQ2ZWJTM1BxV0daZ3RDOFBYQlRrcEptaVVvZGl0di9tMjZCMW9Idz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a29e7da-cd13-4e55-8eed-08ded8437041 X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 14:08:49.1651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9vC5euabcpXtDB/XJ4XiVgO78RaKsdv+VofFfE3tvLJwdKSReJZf87gBWCTFkpl8qv6YvjMoaOHIir0l0ER6SAkaim5Zhl4lh4uPDcOGhU8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR03MB7508 X-purgate-ID: tlsNG-c201ff/1783001337-0DD0E2B8-2014AD2A/0/0 X-purgate-type: clean X-purgate-size: 1453 On 02/07/2026 2:18 pm, Jan Beulich wrote: > On 02.07.2026 13:31, Andrew Cooper wrote: >> On 02/07/2026 11:55 am, Jan Beulich wrote: >>> It can be used as-is for VMX. For SVM the special treatment of %rax needs >>> accounting for. >>> >>> Signed-off-by: Jan Beulich >>> --- >>> This is the minimum required as a prereq to the next patch (to avoid the >>> need for custom adjustments in the two places). We could go further and >>> switch to using PUSH_AND_CLEAR_GPRS at the same time. >> I've got several part-series that result in purging SAVE_ALL/RESTORE_ALL. >> >> If you want to put this patch in, then Acked-by: Andrew Cooper >> > Thanks. Yes, I think I'll put it in as one small piece in the move. > >> but I firmly want to finish my series before >> patch 2 adds yet-more complexity to macros which I'm wanting to remove >> for being too complicated already. > Well, if you make this a strict prereq, then I might as well make one or > more patches myself to replace at least the SAVE_ALL the next patch needs > to fiddle with. Or else I'd like to understand when you expect your work > to arrive, as this series imo is one of those which have already been > blocked for far too long. Get this patch committed, which will resolve the skip_rax issue holding up my last attempt to make progress here. I'll then rebase and try to collect everything together. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 02 14:17:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 14:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351940.1608932 (Exim 4.92) (envelope-from ) id 1wfIDh-0003sQ-Ui; Thu, 02 Jul 2026 14:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351940.1608932; Thu, 02 Jul 2026 14:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfIDh-0003sJ-Rt; Thu, 02 Jul 2026 14:16:49 +0000 Received: by outflank-mailman (input) for mailman id 1351940; Thu, 02 Jul 2026 14:16:48 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfIDg-0003sD-DO for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:16:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfIDf-00EGRZ-Ll for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:16:47 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4672ce-e002-0a2a0a5209dd-0a2a4502a132-2 for ; Thu, 02 Jul 2026 16:16:47 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4672cd-5a27-0a2a45020019-aceafc1f9362-3 for ; Thu, 02 Jul 2026 16:16:46 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1F28543249; Thu, 2 Jul 2026 14:16:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B77881F00A3A; Thu, 2 Jul 2026 14:16:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783001804; bh=vcXV/OFRF3o5nc90hy/rNYztoQp19dfE8boUb7skCPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=nBuFO4OKuZkx4g9lHIILMu0GcvZdBu9Hnc71+r10+sQ+KcL0n3xj7kUQucOnqcAk3 AkoJXlYf1oNjG50cQd8gf2TOHQhPraHIQjZt480Xg/htWdV6q91LBwFijLRn3TQOuu DUzRy0MHOPnAYLdnUDmlOOE6s8dMsOCBWennldGjml9Hl6vq1cQQi9Nbr1EERzrjN/ Lkc41jqy6VqEbMgqwe1omDOJT4iOl7aycvqDHrKI8KUC4jXNXsDmIx9h9ZJsJesofT OviVXSDvnQJkEiSWSZwtp7bcBRhTwnjivbJlK0EsZWjLSEUjELxUeBndnhMBbTL5bE /U9iv5KrQkB8g== Date: Thu, 2 Jul 2026 15:16:20 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t Message-ID: References: <20260702111531.64883-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702111531.64883-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-720697/1783001807-55AE07C5-610C3D44/0/0 X-purgate-type: clean X-purgate-size: 4381 On Thu, Jul 02, 2026 at 07:15:31PM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:25PM +0100, Lorenzo Stoakes wrote: > >The core do_mmap() function accepts a vm_flags_t parameter which it then > >manipulates before passing to mmap_region() to do the heavy lifting of the > >memory mapping. > > > >Update do_mmap() to instead accept a vma_flags_t parameter, and adjust all > >the logic within do_mmap() to manipulate this instead. > > > >This is as part of the ongoing effort to convert VMA flags from a system > >word size to a bitmap type which allows us to unrestrict the number of VMA > >flags, as well as gain control over how VMA flag manipulation occurs. > > > >We do not cascade these changes to all functions which accept vm_flags_t, > >but rather use vma_flags_to_legacy() where necessary, specifically > >deferring converting calc_vm_prot_bits(), calc_vm_flag_bits() and > >__get_unmapped_area() to vma_flags_t. > > > >Also utilise the new vma_flags_can_grow() predicate which correctly handles > >the case of architectures without upward growing stacks. > > > >As part of this change, introduce VMA_SHADOW_STACK so we can correctly > >handle the case of the shadow stack not being defined. > > > >No functional change intended. > > > >Signed-off-by: Lorenzo Stoakes > >--- > > Not exactly a small one :) I stared at this patch for a while, hopefully > don't miss anythig ... Yeah sorry maybe I could have broken this down more! > > Just one tiny nit below. Overall, LGTM, feel free to add: > > Reviewed-by: Lance Yang Thanks! > > [...] > >diff --git a/mm/mmap.c b/mm/mmap.c > >index 46174e706bbe..547352183214 100644 > >--- a/mm/mmap.c > >+++ b/mm/mmap.c > [...] > >@@ -488,23 +496,27 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > > * Check to see if we are violating any seals and update VMA > > * flags if necessary to avoid future seal violations. > > */ > >- err = memfd_check_seals_mmap(file, &vm_flags); > >+ err = memfd_check_seals_mmap(file, &vma_flags); > > if (err) > > return (unsigned long)err; > > } else { > > switch (flags & MAP_TYPE) { > > case MAP_SHARED: > >- if (vm_flags & (VM_GROWSDOWN|VM_GROWSUP)) > >+ if (vma_flags_can_grow(&vma_flags)) > > return -EINVAL; > > /* > > * Ignore pgoff. > > */ > > pgoff = 0; > >- vm_flags |= VM_SHARED | VM_MAYSHARE; > >+ vma_flags_set(&vma_flags, VMA_SHARED_BIT, VMA_MAYSHARE_BIT); > > break; > >- case MAP_DROPPABLE: > >- if (VM_DROPPABLE == VM_NONE) > >+ case MAP_DROPPABLE: { > >+ vma_flags_t droppable = VMA_DROPPABLE; > >+ > >+ if (vma_flags_empty(&droppable)) > > return -EOPNOTSUPP; > >+ vma_flags_set_mask(&vma_flags, droppable); > >+ > > /* > > * A locked or stack area makes no sense to be droppable. > > * > >@@ -515,23 +527,24 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > > */ > > if (flags & (MAP_LOCKED | MAP_HUGETLB)) > > return -EINVAL; > >- if (vm_flags & (VM_GROWSDOWN | VM_GROWSUP)) > >+ if (vma_flags_can_grow(&vma_flags)) > > return -EINVAL; > > > >- vm_flags |= VM_DROPPABLE; > > Old code checked VM_GROWSDOWN|VM_GROWSUP before seting VM_DROPPABLE. New > code flips that around. Hmm, shouldn't master, just made me look twice ;) > > Maybe keep old order? I guess I feared that defining droppable above then referencing it below would be less clear? Can move if you feel strongly about it, and sorry for making the move at the same time as the general vm_flags_t -> vma_flags_t refactor as it does make that less clear... > > Cheers, Lance > > >- > > /* > > * If the pages can be dropped, then it doesn't make > > * sense to reserve them. > > */ > >- vm_flags |= VM_NORESERVE; > >+ vma_flags_set(&vma_flags, VMA_NORESERVE_BIT); > > > > /* > > * Likewise, they're volatile enough that they > > * shouldn't survive forks or coredumps. > > */ > >- vm_flags |= VM_WIPEONFORK | VM_DONTDUMP; > >+ vma_flags_set(&vma_flags, VMA_WIPEONFORK_BIT, > >+ VMA_DONTDUMP_BIT); > >+ > > fallthrough; > >+ } > > case MAP_PRIVATE: > > /* > > * Set pgoff according to addr for anon_vma. > [...] Thanks, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 14:23:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 14:23:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351958.1608942 (Exim 4.92) (envelope-from ) id 1wfIJn-0005na-Kp; Thu, 02 Jul 2026 14:23:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351958.1608942; Thu, 02 Jul 2026 14:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfIJn-0005nT-Hu; Thu, 02 Jul 2026 14:23:07 +0000 Received: by outflank-mailman (input) for mailman id 1351958; Thu, 02 Jul 2026 14:23:05 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfIJl-0005nM-MT for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:23:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfIJk-00Eyp6-H0 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:23:04 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46743b-2eae-0a2a0a5409dd-0a2a4508cff2-32 for ; Thu, 02 Jul 2026 16:23:04 +0200 Received: from [40.93.194.27] (helo=SN4PR0501CU005.outbound.protection.outlook.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a467446-edec-0a2a45080019-285dc21bdff9-3 for ; Thu, 02 Jul 2026 16:23:04 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by DS0PR03MB7558.namprd03.prod.outlook.com (2603:10b6:8:203::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 2 Jul 2026 14:22:59 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%3]) with mapi id 15.21.0159.018; Thu, 2 Jul 2026 14:22:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QK3VF73qJLtEvryp6s06xag9QBgNy8PGyzUp1w3/6Hnx9rKsRnUHnInCkmdW8UxJvuqoxO2oQLf4RnKtm6AN1VtLHNNsErGPT/I9zlD4ywetx/HI0ouZNo2TTYv78cZnbcEijowypP1cI2mFrIWoEVFz6FBx+AKOroCmsdGlWbIO07cJDNVVlXbtlXx9NgJ0LtQpI2DRHK+OQwR7ClPAbCOqApU52iW0XGB3gE0hOHFWKzkeff156b+fYyvh65LPrc+OKJWEoEWw9l3wAyhQRsNEWolxCUzWwkK6UrtVqTra3j8pC7N9twnCklNHOpDHpsjkChuFycyxcI+7XKLMow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B8NEVJSLpQfT2iBI8syE2cnaLKWdctWENKasfgbWPwc=; b=OoE9iuUnuibJHhBlFs5ev1muMQr1x+o5jPPTzX3zY6s/jKtMXkv/3TC+kEauf4pNhvn8a5/NFFig2TtcDNuWMbF3DRP09Uj5Pfa94GG8AGrdj+zHQwOzd1E8K6nAlvkMtM6OL3E4nWQ8UeYwq9UHuhMZHCsPohcpfIXkg/jLTsQH+YV29C/KR4RjrfEeN3MShdUGMg0Sa/XdHQPGyKYA+hRotkHi1tiXTstM7U2/07ZnqMNFJkL9qJ6Djk9R7a+qBXcNF4q6G/yML5B68Nq7F52hut2gTl5S5k3lfpjNA7T39gqZp9FXBQU80ZiV1kqWH2ZOoltw9wDY9s+RbKTT3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B8NEVJSLpQfT2iBI8syE2cnaLKWdctWENKasfgbWPwc=; b=peF3VejK4AJo+P7RRKNGOYQ9kdGO42g111jstOOdrXIq+/SBPLzOoLPUNcQLQL6T7ZLj5o5Fem+xD8hELRWSD6rLC4hErYNAnkKkuxj5Jh1ZlRVPq88Dh+IfrEejD6fvM8ldnj/FhMBX1c8SmWJhtvBN9ZFWBB5863jrDHlIf00= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7fb4624a-02dd-472d-b981-cb7e0c1fce54@citrix.com> Date: Thu, 2 Jul 2026 15:22:56 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH v3 3/4] x86/traps: use entry_ssp in fixup_exception_return() To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> <8af61c08-71f9-4d18-ba9c-952b7894c44d@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <8af61c08-71f9-4d18-ba9c-952b7894c44d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0019.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::13) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|DS0PR03MB7558:EE_ X-MS-Office365-Filtering-Correlation-Id: 3fd5c016-8b09-4c70-9ac0-08ded8456b20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|366016|22082099003|18002099003|5023799004|11063799006|4143699003|56012099006; X-Microsoft-Antispam-Message-Info: kepSCAho0K3UIqRwtnYCWTh8PgnB0QLqMFCSUssf7oZ2yr2EJ7dxBssC0MlfMPsoPAGgyVgFJRFjjA7VbSAS9F0PBpkFOk7QjFenFTIbZmsxlXLlVSTq5JW66fYyKc3U+dOLf5cYac8xZuzyXnLGjXEA+6PODjigBDqHRJl8+rVvlzqiD0HbTva/OUrtSrSS4FfzBRRSj/fA/X8tCHwsRJtLfSvANItL9S5CJLk7kZoA4CFuCr+sXRYnFU2XhNG/8HhZWO4RIWd0HRpxboZ2bMTkOeDbsJ58iVZZJ8Btjb7mxSomZbxByd5jwbU5GVVrWRF00z44IMV78qrtFLqfKF6lN08sQ1bFcXVwMr/qjcWgLgiD5Jlt7bYxkOtOR5NgW0cpl9ZNSXcQ0ezgEBCjeL5ZSGAn9pBE/zbqcAU/xai/uoCIMo1h6OoEH95de3/JWMaQOUueNIG1cKaxib1SKtUA/7KvMq1HMEBmFupLzhGl89Z/BJbx8x2SKgiWy4tUwA0bfAFpRxHQv7ccUMRnBUtJL6UgdUXGdXbDxdBxajW2yzpthS7KrLxRMvwoJBmgNuOEKemSOVfO0Wa+DIdJzRYT9EPdZZ1xbpHS8c0bD34TONnFtlNpkMA+fViWfglnB6Tj0yz43lAWqNGTKvIsM08L0FswHQjBSszQomcO9ro= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(366016)(22082099003)(18002099003)(5023799004)(11063799006)(4143699003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2lQUTd0N2lUM3Z4Vzd5SDFQaDEyWXZ4cCsvZTFyaTBidnJkUFJsaS93QXcv?= =?utf-8?B?ZC9hTDN6VExjVmQrbENwOWpseXhBWnhCc0hkTTlWTWRSbnp5UkZqcDNjL2JG?= =?utf-8?B?U0JMRlF5RDUzQnk3ZHhwZEo5bEQvRjVtaUNvbmpkQ0d3eTEwd28zSnQ2UFNt?= =?utf-8?B?bVZ1QzducktaMWs3dEc5N3FXdkFPTUNkMXB2dEJySFpTL1IyaGJvU2c2QTQ1?= =?utf-8?B?cWdQalVyZDdOOHI0elBnRnRoQzNLTFkzb1RNY0FjVitCTWpjWE5Lb0tWTC9D?= =?utf-8?B?UU9WZjc5TWhselM2V3d4dVUvK2VPY2RWVldIakhYOG9HM2x1T3YwanBCZGth?= =?utf-8?B?aW44RVdZZVdwUXpyQW9DM0dhVGt0NkZuUjBKYjFnZW0rSzZrVkxRUkhYaUts?= =?utf-8?B?eDd2YXhPR0pFNE9hdjIyQ2pqVy93TFNTMVZSVHdGVGdzVFpWM2kxeTBMT3Jm?= =?utf-8?B?VVFqcHRhUHFYT2lZL2RFdDlpbVV6QTIvWjZ4VTBBVFZieTA5YmRUM3hDWXYv?= =?utf-8?B?c29IbzA0WTc3c21MRUlwcHpjR0xiUU4vWlF1QmJWNFNjSkdOakRnTEdPcU5S?= =?utf-8?B?NW0vMlNnWElPT3VEMXdaQkVlNFRrcC9zMVcwcWNjSWNwKzE4UVpYNWEya3E0?= =?utf-8?B?RG1wMGZ1azM5d2RkZFNtSU4zdmdZOUZuWC9aWVNtckZrdFN4VG4vcDNsMklJ?= =?utf-8?B?ZjROeksyZDhXVi8wUmorOUJndVRyclhrWkg1bEFwYnovdGlES3NHWTBWd3Zx?= =?utf-8?B?Wkd0dGFCLzVTWGdpWCtaTERZcDVPeHZVaXBodi9NbTRGVVM0SDAxTUMxNDZL?= =?utf-8?B?dXJoTENORXg4UGVuazdDQjdIeEQyMmpEcWE4TVNxMGhXcVppcEF6VUQ5YTRi?= =?utf-8?B?OWt0OXhxWnhQanVMeE0ydEdmZVV3aVRWYk5FREFMelFxTCtraERBNDhrWnFz?= =?utf-8?B?ckxsc3FlaVJEczRrNFFxQkZzeDUvV1dSNDJ5ZStTRFVnQVh3VEwvWE5IbzYv?= =?utf-8?B?K1R4czVya0UxL0ZhZjlrdGsyZHpSZEZMbVJEWVQ4bUhiSHUySjFjbGwwamRl?= =?utf-8?B?QWVZdi9uYTI2ZUswUjJWaEVFSDZTMUZKZE1jTWdwa0FwWEZJV2ZmQmROSVR0?= =?utf-8?B?ZFkwNG9jUDhHNE1OaXVEYnlXVlNCVFdSNlJLeFRLckJEamdXQ2l0YjhYdHA0?= =?utf-8?B?cjlpR0htSlZ0dXF0T1RuVHhObWpvdVhLYXlBNHRmejNiYVU4WWJsVUh6UjZp?= =?utf-8?B?RUdFZjlXbEtQSllpOXFvQm5GNXc3aGNKS25iYTQwRUtFOVJZb0YvSDdDbmZQ?= =?utf-8?B?S2VSb0V4Slk1dnY2STZ2L01TaFRTRHFCUkdOVTBFSE1LRGk0aDlvWno3TmJL?= =?utf-8?B?NzFsRjJDSzU0Z2pWZmY0TkVpaWtPS2FPQ0FBRGJEUWRCbjRXeHloWkRzQzlr?= =?utf-8?B?Z09HUW55WWFWbE1NVWdwUGhITEV5eTFkZjF5a0hqQmlBSS9FeXRKYnFCeU1E?= =?utf-8?B?ZFBTTGJqRmxFWEZLTVR2QVRoTnZLRE9hbWU2bHloZ21ZQ2tucjRyNVB4QW5N?= =?utf-8?B?N3JWSFlBTkVmaksvNXFCb2c2c3BiVGJGdjgzRzR1UmpLdVpBay9tZUNSRzVl?= =?utf-8?B?RGo4dTh4MlR2N293MndzVWp1ajRsZHEyY0tEckg1UzhmUis0MTMzV1YwWEsz?= =?utf-8?B?L01QenY1TlNQYkpmVnRxUW9CRGhJTTVCcTZmdUI0Vk5OYnlrZkZQWC9xTGp5?= =?utf-8?B?S3QxdU91c2RLaTVjT0pFdCs1elhRTnk3Y3IzV2dYVU9tdmdFRGE1emdMOG9q?= =?utf-8?B?b0hHWVVLMWdrMnRWSzdxTjdnZkZ0Mmt0c3d3RnByK21KSHhTUzRaSG5vbkM4?= =?utf-8?B?VW1uTm0yM05IRDQ0NC9lVFhEbzNIRlRUaTh6aGZ6dDFYcE1jd1N0UityVXJO?= =?utf-8?B?MFU5Z252SFpVZDQyc2d4ZEZ2MTNMNWxzSGJzNzZFdXJHTDRFUzhqY0xOMlYv?= =?utf-8?B?VG9lWm5ZT3BlTzNqeDd1Vm1odVFCNmthVWlhUS9JckdHZDRvVTlJR0lhTFI5?= =?utf-8?B?WE1yQkFFQklZUUJKTEJYTjFENlhka1N5QkdWRUY5cWtZK3IrVkF0b0taelEv?= =?utf-8?B?ZUN1Vi84R3d1QU41eWdJVkxQSWE1ZnhEVGd5M3NrRk9hSVU1TXYyNldvMzVZ?= =?utf-8?B?YWxVSWRGeDlvS25CZUVGMm9CUVZyREFlL2lyNTYvQ05Qdk91Y2JxVS9tMFl3?= =?utf-8?B?Qm8zcitjUXZpTWlRaVZwNHJUazRLYW1ESDZPWVFRdHlWbzhSbzZVM1BMekZK?= =?utf-8?B?TE85dm9RdmcxeGt5UnJBMHpCdU9iS1BLTjV4UENYQWUzQWNyYkF2QT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fd5c016-8b09-4c70-9ac0-08ded8456b20 X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 14:22:59.6184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aDntkHta52xt01JH29Q1rtCNf/rFx6qQ0vS82+WP7IxiIE86uhLeT8Wf4EbKIcz/0bkZ5/d56drkbNI0L8W+Z50kK3gqgflbF745mCVtUhk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR03MB7558 X-purgate-ID: tlsNG-c1860d/1783002184-A2F3A3FC-22AC30E2/0/0 X-purgate-type: clean X-purgate-size: 870 On 02/07/2026 11:55 am, Jan Beulich wrote: > With the value recorded on entry there's no need anymore to go hunt for > the respective exception frame on the shadow stack. By deriving "ptr" > from that field (without any offset), it then ends up pointing one slot > lower than before. Therefore all array indexes need incrementing, nicely > doing away with all the negative ones. > > Signed-off-by: Jan Beulich The diff isn't easy going, but the end result nicer. Reviewed-by: Andrew Cooper > --- > Indentation of the prior inner (but not innermost) if()'s body is > deliberately left untouched, to aid review. It'll be adjusted in a > separate follow-on patch. There are two indentations needing removing.  Deferring to another patch is fine, but it would be nice to be in this series. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jul 02 14:28:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 14:28:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351974.1608951 (Exim 4.92) (envelope-from ) id 1wfIOi-0006Sf-5g; Thu, 02 Jul 2026 14:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351974.1608951; Thu, 02 Jul 2026 14:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfIOi-0006SY-2o; Thu, 02 Jul 2026 14:28:12 +0000 Received: by outflank-mailman (input) for mailman id 1351974; Thu, 02 Jul 2026 14:28:11 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfIOh-0006SS-Ot for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:28:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfIOh-00EITS-5g for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:28:11 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a467564-e002-0a2a0a5209dd-0a2a4502b26e-40 for ; Thu, 02 Jul 2026 16:28:11 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46757a-5a27-0a2a45020019-d155802fc8e5-3 for ; Thu, 02 Jul 2026 16:28:10 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493c19bad03so15642205e9.2 for ; Thu, 02 Jul 2026 07:28:10 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6354771sm57322205e9.3.2026.07.02.07.28.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 07:28:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783002490; x=1783607290; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=GUmoHYSJrMKjXZep5Z7Hi/mcnqXBGMF8TUyKctMSQmA=; b=XKMvuQwun3l80g9i9Q26HP8tXTQK6R8CigJF7v3Ps8eAdx2oCy3Xmrm4C1F1Sbc0Se mG4m1l2yQK6RwWSAe/LPqkreIxa5i6Q7/38pau7oEJjjKuQyDaSa8rybui9V/wQqyxzB FOCYwjUWbyqtvEEizazmLUcFX4PZnbinCqpFnUdnmIREFuRM4IvyokMA+ySw96/zQ/b7 NQ9ixNzbUFDflAy8Y32wTdvDprpAc6f8jiC7IFWEhTiiwOixwx0n/AYv2KYde0x+gc/z GaZIW8tdY4YG4+FrrACzMazzkcfhdfWrlCg+hNwuEmKNEbesnPz5E2kaXrq40R06FEX3 jGYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783002490; x=1783607290; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GUmoHYSJrMKjXZep5Z7Hi/mcnqXBGMF8TUyKctMSQmA=; b=FlwjC9sAOtTlCls5vryoM+xz5AIYig+2yX4jZjNNG6YhQtM697Wpc3R6Yeo9GDmiWD 7i/wLoO/3yjGzYEbW0emIDizzKTV5BQW2guF4t+ssWeWsFwEgE7s8OO32bD76ni6dwDK O6ZiJRxPZUwr4wGQC3O+j8hUwfjQUZsfp0bq6szxwEl1dl1Y/ASxX6NVNHvXfG9bwxai /PF8h4pLpAeiRekvOAc26t1mbhTI98sd8tLXWKKmDWJoHw1+A6wfrySm6T7F5ZA+vmNw VvUT6CO1O94aWZgdX2BTIMSGWB8HMjCOA19cwe3fHjZ7lymkEtJfa3lNHvCsYMly1lGx bu8g== X-Forwarded-Encrypted: i=1; AFNElJ+8GFEeEDKueLZvGeEAre9Qj2BMouKKpnsHUjh4raAVEdI/7tyzGM36egBCinW0ttgwLfTBpGNXaQ8=@lists.xenproject.org X-Gm-Message-State: AOJu0YwO7H1vKsRmdlY9hNFssCaAq4nLNXiXo7JpPN7Zi+4Y2i8ehM7n diDnnjmMVOihffDsCDZ2jaWSpditVBNQcYKphak/DHcE0/n7MKvREU5tTuFm1Kb/YQ== X-Gm-Gg: AfdE7ckRkyhFUVxaVdHHhMu66hOMo82wgm/OCFvqJln0eRXlFnrByj+oUPluhrZjhBQ hPmUZlurmM4HQ2F1MTwqOktyIexW8HyMCjO1F+WbhniEi3mZqwhE6pGVg9jCnZL58gBoLBKbSCX 1cG8AZlGju2qEz8lNHu8hvZssykBvkyW48hizCTpEJvqPe+sEhTedM5xmNBvHv3pfwe+2gnPYFA +UsIjQngUBNjhk85LiQd6WpiYCSi0uFu4ZJaPVTALdL8kvByDJfHZ5zv0t2r6/OfR0NDEUihlmh YPGSet8wURR7Drs6EuWkZxR2yf6lNJ0CBnKXWc2pgHO6e78/ua5IfXD5lq926+cSR77PCZvb+nY fBGDbG1MRujo6aUZYSdtlak3KTQmeZGBKq4iKTo2evcWyPsrsi3zbay92yDxuP27ldLQ2ULI7+X PkDv3MVOdZuEJ9Y6k7kSiAP38D00a5Qc+SVJzLFZ+AyKEm5F+j/Sgg9/R9i76sPkApMNdqHdFEd Je813idZ8Fj4GA= X-Received: by 2002:a05:600c:c108:b0:490:c024:2ec8 with SMTP id 5b1f17b1804b1-493c2ac7384mr75886215e9.0.1783002490425; Thu, 02 Jul 2026 07:28:10 -0700 (PDT) Message-ID: <6f192c41-7b70-401f-93f1-5bf546b858a2@suse.com> Date: Thu, 2 Jul 2026 16:28:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] x86/traps: use entry_ssp in fixup_exception_return() To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <7ba5ecff-af64-49c0-abf9-23963ca56aa6@suse.com> <8af61c08-71f9-4d18-ba9c-952b7894c44d@suse.com> <7fb4624a-02dd-472d-b981-cb7e0c1fce54@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <7fb4624a-02dd-472d-b981-cb7e0c1fce54@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1783002491-4F1127C5-33D5779D/0/0 X-purgate-type: clean X-purgate-size: 1011 On 02.07.2026 16:22, Andrew Cooper wrote: > On 02/07/2026 11:55 am, Jan Beulich wrote: >> With the value recorded on entry there's no need anymore to go hunt for >> the respective exception frame on the shadow stack. By deriving "ptr" >> from that field (without any offset), it then ends up pointing one slot >> lower than before. Therefore all array indexes need incrementing, nicely >> doing away with all the negative ones. >> >> Signed-off-by: Jan Beulich > > The diff isn't easy going, but the end result nicer. > > Reviewed-by: Andrew Cooper Thanks. >> --- >> Indentation of the prior inner (but not innermost) if()'s body is >> deliberately left untouched, to aid review. It'll be adjusted in a >> separate follow-on patch. > > There are two indentations needing removing.  Deferring to another patch > is fine, but it would be nice to be in this series. Can do for v4. I just didn't want to do this more than once. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 14:32:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 14:32:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1351985.1608959 (Exim 4.92) (envelope-from ) id 1wfISy-00084I-LU; Thu, 02 Jul 2026 14:32:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1351985.1608959; Thu, 02 Jul 2026 14:32:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfISy-00084B-It; Thu, 02 Jul 2026 14:32:36 +0000 Received: by outflank-mailman (input) for mailman id 1351985; Thu, 02 Jul 2026 14:32:35 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfISx-000830-73 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 14:32:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfISw-00F19m-GO for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:32:34 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a467682-5cb7-0a2a0a5109dd-0a2a4501dd04-0 for ; Thu, 02 Jul 2026 16:32:34 +0200 Received: from [209.85.221.50] (helo=mail-wr1-f50.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a467682-400f-0a2a45010019-d155dd32ed85-3 for ; Thu, 02 Jul 2026 16:32:34 +0200 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47231f1f8f3so2172020f8f.1 for ; Thu, 02 Jul 2026 07:32:34 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db3dbb01sm9540012f8f.1.2026.07.02.07.32.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 07:32:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783002754; x=1783607554; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ouAIXKABUS86tGqzusDeAOuz+zhrRm4/w2+8FueUbIw=; b=W7ERDM/rc4qEM24HtyAufxDDtvndKMXU3OvNT8ZkCfv02i8bxc90pCc6GG23Ej4oRM n3YPgcNndtugus9l6Aa8Ig1wskh6whOhap42zHWRn4ppMwF/0F54i0vOG2FHNqdJ1+0C aGXrfDPl01Bk1FpfOimrDdOAS4y6y9rOPc7nAv0SSUVhtrrlRt0cM84zlD0mDzPgfUCj 6zcDDG/Ai3GzsiA+Ev6JYD+8NYabVPeQrzJFnLcfGlPUT4PRi5G/i68eV7CzdZ8UQ9W6 a/D2YPjx25kScml3P2vXCKl7IGKzSpUCXz5vuVPrL8PN0deRDnG5TW2m12DpRnovyVFD +4Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783002754; x=1783607554; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ouAIXKABUS86tGqzusDeAOuz+zhrRm4/w2+8FueUbIw=; b=VcjtbfFzQSakhpWhOdKOAxuRnZ8y1+9Yp4j88NvadfuQ69Q4zDcb4fVdtUFvylX4yy pRtAYen5rfG8hAa1ctcMoIdhRTQVqI+ttU2XyxagCOsJ2uz2uETMAA1eqETcIxvLdoBa czldpwphWwQAF4pX1QwFRSrkG0ICI9FuseVXoUjKynUtT7Hnp/pvKmz1ny2uB1Oel6P8 OlmjmvkE2TIf+kbbADFRQHZcDs8OFWhpjxPeAr2jVlTJoxp8glNT0jAtRh86n6VMW/+H aCqgFN2E3ZUBM0PFMDlpmv345YVPLlDL4HhoHdo/nZAnGvtkiWW4+RlhLQ8KT0v1tlzS EyHA== X-Forwarded-Encrypted: i=1; AHgh+Rr0BUJw/ThFFHerLOIeobF8XZuPzUJPU5QVzKtwZzKF/m2YjffIH5PIDjekDVWa8s084nLlttb1qDo=@lists.xenproject.org X-Gm-Message-State: AOJu0YzsglNKmpHdpFAeBEc1nkQnGmoSnzTra16ZcXeT+TrYVO83cxlg IJo3wO6zAyc6B5o4JpvRSPEkBfqCk+2LKGUajwKy9j7bA03ItvfgdU9nEB0e5tJqVA== X-Gm-Gg: AfdE7cmT1kwmnlwnAVN2WAH+NViAsLQnA4r98veWuKWxvH0W7/4h/qsJ6kYapkjPZ3l CWWzD5if4VqmTwE8WJVh5l8vr67GRGA551E29/y7/Bo//G70/F1HtSjns5+phjTfSVeNgeTq0pV Kjsm0qx06sw6OciG3W8hY+BJJVgE3o12G1FbsHcm8x60VkIbdKC1RmcFgUDNpZZXrmtp6iJ0nIR QhocFNIkOPGOm2ZSB70haMc5BJh1nypM5iUB3XYT7Ku71p8kdWJDhER2u2fWIU8Pnoo9bBEv99i Dbv9/vLpyyx5AQYirnWwmbx4IAgWEM6kn3HPsVY98+btdw6KrRSRrja7ATjx4rhvYLoQ8Avk51l lwDbACxrKHnTtbsNQsA47bXMAladO0TU2AIuth/dIhqPzQb7SeuZvnEuPWWjqjmLEr8GJKpAmc4 ryeL/nziD3Jxz64Sf9S7Z/dRzGlvEfECaPrZnnCihJVgStxvhAjE5LYXJwNABOIGkFma5Ne6r05 6fO X-Received: by 2002:a05:6000:402a:b0:441:1e41:194 with SMTP id ffacd0b85a97d-477b3983918mr8722264f8f.17.1783002753853; Thu, 02 Jul 2026 07:32:33 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 16:32:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/25] xen/riscv: implement IRQ routing for device passthrough To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <472a77604d35a0bc2a75b71f250fd67b63afde4c.1782487661.git.oleksii.kurochko@gmail.com> <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> <40bcf6b7-306a-419a-bf12-1855f9e589fe@suse.com> <91ffc1b2-7648-4185-a2f1-12b30181c8a9@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <91ffc1b2-7648-4185-a2f1-12b30181c8a9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1783002754-830C41E0-5B701841/0/0 X-purgate-type: clean X-purgate-size: 1772 On 02.07.2026 11:33, Oleksii Kurochko wrote: > > > On 7/2/26 8:38 AM, Jan Beulich wrote: > >>>>> + spin_unlock_irqrestore(&desc->lock, flags); >>>>> + >>>>> + release_irq(desc->irq, info); >>>>> + xvfree(info); >>>> >>>> If, in release_irq(), action isn't freed, it's ->dev_id field will now have >>>> a dangling pointer. (I think I did point this out before.) >>> >>> It should freed in release_irq() as route_irq_to_guest() always set >>> action->free_on_release = true; >> >> Well, "free_on_release" must exits for a purpose. I.e. there must be, now >> or soon, cases where it's set to false. Else simply drop the field. > > I can't simply remove this field because it is part of the common > `struct irqaction` and is used by other arc-s. (I assume that it is not > what you fully meant...) > > IIUC, this field is used to determine whether an irqaction is > heap-allocated (and therefore should be freed) or statically allocated > (and therefore should not be freed). Yes. However, all uses of the field are in arch-specific code. So in principle it could be #ifdef-ed out for RISC-V. There may be a better option, though: > At the moment, all IRQ actions are heap-allocated (on RISC-V), so > free_on_release should always be set to true. In particular, the code > snippet you asked about releases a guest interrupt, and guest interrupt > actions are always heap-allocated. As a result, when release_guest_irq() > calls release_irq(), the associated irqaction will be freed. > > So, from what I can see, the current behavior is correct and I think it > should be left as it is. Do you have any concerns about this? If you only ever have the field set to true, use ASSERT() in place of if(). Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:03:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:03:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352012.1608968 (Exim 4.92) (envelope-from ) id 1wfIwa-0005Yl-Vx; Thu, 02 Jul 2026 15:03:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352012.1608968; Thu, 02 Jul 2026 15:03:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfIwa-0005Ye-T9; Thu, 02 Jul 2026 15:03:12 +0000 Received: by outflank-mailman (input) for mailman id 1352012; Thu, 02 Jul 2026 15:03:11 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfIwZ-0005YR-3D for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:03:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfIwX-007ziY-RR for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:03:09 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a467d9b-bab6-0a2a0a5309dd-0a2a4503e5ce-46 for ; Thu, 02 Jul 2026 17:03:09 +0200 Received: from [209.85.208.47] (helo=mail-ed1-f47.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a467da8-ec1a-0a2a45030019-d155d02fa899-3 for ; Thu, 02 Jul 2026 17:03:04 +0200 Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6983d3dae7aso1171353a12.0 for ; Thu, 02 Jul 2026 08:03:04 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4b83sm11052511f8f.12.2026.07.02.08.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 08:03:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1783004584; x=1783609384; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DjmOe84IrhGJfQjiy2t/gDqUrLCLWBZLNspBTB4loJM=; b=JP5i7hTN5B82dxM7VAn+1fc0tYAt2zceSPUA9OL1YZy+G6v8zjGD5wYPvbGVUAVmIc 7wr1vBNf+MkN92xxVILVb5hDvJrZo3EM+gnp5LlOVuBiGnqdzPMA7Ekq+Yu9W+2vJeni d2nlGh/JmQQbhMiaQxnO9yaH0bOtK586Rh5/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783004584; x=1783609384; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DjmOe84IrhGJfQjiy2t/gDqUrLCLWBZLNspBTB4loJM=; b=p/ZEzCOHKU0wFPoXQAEMuUudOnPc6ie4tluiu7AMHUlx8Kq4iCFJ36O0V14d5pSo6d Qh8Ytnw6+ZPckrhcDQmDFI5XatCs8dv7dE/4zTqkNj8X0oaLRbZVnC1dgtyZVBSjK3y3 DnVSeFdTFWaOsdBvXjDdBhNVvStSIq9ffwCcgEhryvSCpkeGGmgePRfu0AN2Pp/m7riI Zd92ZcgFWUPaUrxh3HSGr0snbWQpERuNP9K1jgGDuJqZR6gfX7ahqTksCECMa1sPGv/q BRCvIPBvqdhMUXk6BXS4t/nffvgubDfSMGgvyscQlMb2D/7f2Xp7eWoKLwqiq/tusSEm mJsg== X-Gm-Message-State: AOJu0YyakJ3Zno1jDu52uMatiAeE581v00fAV1xo9X4/3xm5popGbsjR zWAf7FlUXhrb9JUidMwyjIH+oIreKgxnm3qpa2B9J1Wm7EFn6eZeAWZJCt32auEsnuIsmMXix/6 i4fpFDiM= X-Gm-Gg: AfdE7cliNE1ICdaAVXM1vx2/75Wrufg6+0aMzqbzz14tnOqi0lSf/qUNKTAHoANnzda rqdT5p5NdC9+DBvFo3F2mjewOG9MEMr/iq5FGDGVDRN/uJ05Kaypv1VayoHzPC0Ktl2+Stho2fD vypCuauuStZtk6cg04SQKrlyIYtSi8LAcq/QElp3wBCV4bPcs8QZjXCq26DZ+Ftoe1GAL2pgeGJ SnHMiRVsvHhbGWNY/ApAYrHMKnc4Jol8YvDxWnIZGDgD6einpRG1243fG9P7WtIvO7CkVuf91Jg K1IK4TKCoYiMSPLblPjgUNm6zhwkl+Z+O8eFZOGvgCpALPtU2xpsaGJ9nGCiyPOaofs8ZiLUWcb X8JFsEgzMgH4C7a1q1B9LV+3Zg8DrFfwIxWlPtewOACwBYt0I6wRvgxbs6w84Ft+jXBXoShoypk p9mWCfVEGFR1aF8LSsVIdzSC/KfhDKjq0BNkOw/FXTf1XyWPluK9XF7WxaGYhkhGQ= X-Received: by 2002:a17:907:d303:b0:c12:a7c5:e638 with SMTP id a640c23a62f3a-c12c9d3c84cmr14402666b.7.1783004583966; Thu, 02 Jul 2026 08:03:03 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Oleksii Kurochko Subject: [PATCH for-4.22] tools/libfsimage: Remove the XEN_FSIMAGE_FSDIR environment variable Date: Thu, 2 Jul 2026 16:03:01 +0100 Message-Id: <20260702150301.825883-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1783004589-B57BF5D1-AA55E787/10/73395122804 X-purgate-type: spam X-purgate-size: 2307 This was reported to the security team, demonstrating that code execution could be achieved, but without a demonstration of a priviliege boundary being bypassed. Still, it's a high risk path with no obvious evidence of having been used even for debugging, so remove the environment variable and use the build time $(libdir)/xenfsimage path only. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini CC: Oleksii Kurochko For 4.22. This was supposed to be posted earlier but fell through the cracks. Given it's borderline-security aspect, we don't want to delay it any further. --- CHANGELOG.md | 1 + tools/libfsimage/common/fsimage_plugin.c | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ef4e6ae9c459..0a4e5f013cb1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -63,6 +63,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Removed xenpm tool on non-x86 platforms as it doesn't actually provide anything useful outside of x86. + - Removed the XEN_FSIMAGE_FSDIR environment variable. ## [4.21.0](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.21.0) - 2025-11-19 diff --git a/tools/libfsimage/common/fsimage_plugin.c b/tools/libfsimage/common/fsimage_plugin.c index d0cb9e96a654..539dc247356a 100644 --- a/tools/libfsimage/common/fsimage_plugin.c +++ b/tools/libfsimage/common/fsimage_plugin.c @@ -121,7 +121,7 @@ static int init_plugin(const char *lib) int fsi_init(void) { - const char *fsdir = getenv("XEN_FSIMAGE_FSDIR"); + const char *fsdir = FSIMAGE_FSDIR; struct dirent *dp = NULL; DIR *dir = NULL; char *tmp = NULL; @@ -129,9 +129,6 @@ int fsi_init(void) int err; int ret = -1; - if (fsdir == NULL) - fsdir = FSIMAGE_FSDIR; - if ((name_max = pathconf(fsdir, _PC_NAME_MAX)) == -1) goto fail; base-commit: ad9f564a5d840389cbf1b230086e1dd8257d8820 -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:09:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352026.1608979 (Exim 4.92) (envelope-from ) id 1wfJ2J-0006TJ-IR; Thu, 02 Jul 2026 15:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352026.1608979; Thu, 02 Jul 2026 15:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJ2J-0006TC-EO; Thu, 02 Jul 2026 15:09:07 +0000 Received: by outflank-mailman (input) for mailman id 1352026; Thu, 02 Jul 2026 15:09:06 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJ2H-0006T6-6i for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:09:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJ2G-008SiF-Js for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:09:04 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a467f01-e002-0a2a0a5209dd-0a2a4505b22c-28 for ; Thu, 02 Jul 2026 17:09:04 +0200 Received: from [95.215.58.179] (helo=out-179.mta1.migadu.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a467f0f-3cb2-0a2a45050019-5fd73ab3f860-3 for ; Thu, 02 Jul 2026 17:09:03 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783004941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GVgi/IDW6MB0ICHH5yTujujreeH5t5fHN661xjkq/74=; b=Dkh9RWL9rMIQE6Ur1L+lFP9fWBIPUF1EBlETBXiV1FwoU/+0F4n7u3+DtwQotZKTkFazHu oHVZr/Vs+FAfYKVbUxY57cWOfPctKhbPm5r74IEfkBs57Xoqgu/OIspBSvCnXq9uEYouaN h+ygMrTbcJpYGV90L9aTDp+5SWenOgM= Date: Thu, 2 Jul 2026 23:08:32 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org References: <20260702111531.64883-1-lance.yang@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-c201ff/1783004944-0ED162B8-6F8D3693/0/0 X-purgate-type: clean X-purgate-size: 2292 On 2026/7/2 22:16, Lorenzo Stoakes wrote: > On Thu, Jul 02, 2026 at 07:15:31PM +0800, Lance Yang wrote: [...] >> >> [...] >>> diff --git a/mm/mmap.c b/mm/mmap.c >>> index 46174e706bbe..547352183214 100644 >>> --- a/mm/mmap.c >>> +++ b/mm/mmap.c >> [...] >>> @@ -488,23 +496,27 @@ unsigned long do_mmap(struct file *file, unsigned long addr, >>> * Check to see if we are violating any seals and update VMA >>> * flags if necessary to avoid future seal violations. >>> */ >>> - err = memfd_check_seals_mmap(file, &vm_flags); >>> + err = memfd_check_seals_mmap(file, &vma_flags); >>> if (err) >>> return (unsigned long)err; >>> } else { >>> switch (flags & MAP_TYPE) { >>> case MAP_SHARED: >>> - if (vm_flags & (VM_GROWSDOWN|VM_GROWSUP)) >>> + if (vma_flags_can_grow(&vma_flags)) >>> return -EINVAL; >>> /* >>> * Ignore pgoff. >>> */ >>> pgoff = 0; >>> - vm_flags |= VM_SHARED | VM_MAYSHARE; >>> + vma_flags_set(&vma_flags, VMA_SHARED_BIT, VMA_MAYSHARE_BIT); >>> break; >>> - case MAP_DROPPABLE: >>> - if (VM_DROPPABLE == VM_NONE) >>> + case MAP_DROPPABLE: { >>> + vma_flags_t droppable = VMA_DROPPABLE; >>> + >>> + if (vma_flags_empty(&droppable)) >>> return -EOPNOTSUPP; >>> + vma_flags_set_mask(&vma_flags, droppable); >>> + >>> /* >>> * A locked or stack area makes no sense to be droppable. >>> * >>> @@ -515,23 +527,24 @@ unsigned long do_mmap(struct file *file, unsigned long addr, >>> */ >>> if (flags & (MAP_LOCKED | MAP_HUGETLB)) >>> return -EINVAL; >>> - if (vm_flags & (VM_GROWSDOWN | VM_GROWSUP)) >>> + if (vma_flags_can_grow(&vma_flags)) >>> return -EINVAL; >>> >>> - vm_flags |= VM_DROPPABLE; >> >> Old code checked VM_GROWSDOWN|VM_GROWSUP before seting VM_DROPPABLE. New >> code flips that around. Hmm, shouldn't master, just made me look twice ;) >> >> Maybe keep old order? > > I guess I feared that defining droppable above then referencing it below would > be less clear? > > Can move if you feel strongly about it, and sorry for making the move at the > same time as the general vm_flags_t -> vma_flags_t refactor as it does make that > less clear... No need to churn just for me. Thanks :) From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:25:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:25:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352053.1608987 (Exim 4.92) (envelope-from ) id 1wfJHl-0001GI-R7; Thu, 02 Jul 2026 15:25:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352053.1608987; Thu, 02 Jul 2026 15:25:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJHl-0001GB-NM; Thu, 02 Jul 2026 15:25:05 +0000 Received: by outflank-mailman (input) for mailman id 1352053; Thu, 02 Jul 2026 15:25:04 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJHj-0001G5-ST for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:25:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJHj-00ESrZ-92 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:25:03 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4682cd-5cb7-0a2a0a5109dd-0a2a4509e6a8-8 for ; Thu, 02 Jul 2026 17:25:03 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4682cd-97e6-0a2a45090019-aceafc1fb67a-3 for ; Thu, 02 Jul 2026 17:25:02 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C929640801; Thu, 2 Jul 2026 15:25:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F0E41F000E9; Thu, 2 Jul 2026 15:24:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783005900; bh=LX3BYrLY2k63JpXB67A/Bjg+Ew5yjhUF+WJZEyA1fRw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kbG+cL/z/Lm6qSE4udnGibaK8FsMK4daZd2R+hoEFAnemIecEE1GgHP0X+YmGanAO lUy6V/tOsn4eLItop07tyF1+tKZLAB376Z73zBZZR/VxVccPToewSf2zWsClidLb0a 1ba3VdHACF4EGJhQZxBSvTHBcWlMH/zUclnichRT0/C3hk+pIj4TS7GYchozD+ZWNu evu0CqyUEndELEE8NUvVmpXBep2Kukvvzwrnf2DWGzh4uAWg/PKpNORRO9bOZEjI+M pMTZGas90E8+KBulzvC/BZdad1hSIx2FR4a50cjXxyZVyxi/oq6E9v6gCdozTTgwHV VbLDs0NzwuGjg== Date: Thu, 2 Jul 2026 16:24:37 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 05/13] mm: prefer mm->def_vma_flags in mm logic Message-ID: References: <3b4ccdc38819b42ddc79ee5a795831208ac7986c.1782760670.git.ljs@kernel.org> <20260702121022.49113-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702121022.49113-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-bad1c0/1783005903-46538986-48406A97/0/0 X-purgate-type: clean X-purgate-size: 1764 On Thu, Jul 02, 2026 at 08:10:22PM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:28PM +0100, Lorenzo Stoakes wrote: > >Currently mm->def_flags (of type vm_flags_t) is union'd with > >mm->def_vma_flags (of type vma_flags_t). > > > >As part of the effort to convert vm_flags_t usage to vma_flags_t (in order > >to no longer be arbitrarily limited to a system word size for VMA flags), > >prefer mm->def_vma_flags to mm->def_flags throughout the mm logic. > > > >No functional change intended. > > > >Signed-off-by: Lorenzo Stoakes > >--- > > mm/debug.c | 2 +- > > mm/mlock.c | 13 +++++++------ > > mm/mmap.c | 11 ++++++----- > > mm/vma.c | 4 ++-- > > 4 files changed, 16 insertions(+), 14 deletions(-) > > > >diff --git a/mm/debug.c b/mm/debug.c > >index 497654b36f1a..f0a354a9496a 100644 > >--- a/mm/debug.c > >+++ b/mm/debug.c > >@@ -226,7 +226,7 @@ void dump_mm(const struct mm_struct *mm) > > mm->numa_next_scan, mm->numa_scan_offset, mm->numa_scan_seq, > > #endif > > atomic_read(&mm->tlb_flush_pending), > >- mm->def_flags, &mm->def_flags > >+ vma_flags_to_legacy(mm->def_vma_flags), &mm->def_vma_flags > > ); > > While at it, one thing for later: dump_mm() still assumes one-world VMA > flags. That works today since vma_flags_t is one word. Maybe worth a > BUILD_BUG_ON() here, before that stops being true? Ah yeah that could actually be pretty straightforward, if you see https://www.kernel.org/doc/Documentation/printk-formats.txt there is a bitmap format that could be used. Can do that on a respin! > > Not a big deal though. Feel free to add: > > Reviewed-by: Lance Yang > > > } > > EXPORT_SYMBOL(dump_mm); > [...] Cheers, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:29:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352064.1608995 (Exim 4.92) (envelope-from ) id 1wfJMM-0002B4-8g; Thu, 02 Jul 2026 15:29:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352064.1608995; Thu, 02 Jul 2026 15:29:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJMM-0002Ax-5g; Thu, 02 Jul 2026 15:29:50 +0000 Received: by outflank-mailman (input) for mailman id 1352064; Thu, 02 Jul 2026 15:29:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJMK-00029m-9a for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:29:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJMJ-0084eC-92 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:29:47 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4683e8-e002-0a2a0a5209dd-0a2a45028da4-6 for ; Thu, 02 Jul 2026 17:29:47 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4683e8-5a27-0a2a45020019-aceafc1f89b6-3 for ; Thu, 02 Jul 2026 17:29:46 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 25A4F418F4; Thu, 2 Jul 2026 15:29:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA7DF1F000E9; Thu, 2 Jul 2026 15:29:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783006184; bh=AmvNH9wwHqyoIMesePnV6/zMDBtlSz51dFh4yHJ1BTo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EZDY+QGcsghhDIw9rxbIhnPAJRijthrModhJ3dAoSN5cVM+YkTpcpEvD+KPlh/M/u Qwt3kZkRl2OzXpZ8lNBF20cEMvcQmjr2C3N0OBOmi3krbMnyRHMJTEBJXrtiCGLkys hVceGk9nKeLivyWhhq1nb1heVf5ntbaXnUG4S4OpDlt89/1RU+lLBy/OziQBm1WY0f mLETtt6Kv1hVTKJQz++mgHlN+PUF+ac9yH5QtMrmNRfTW7GoeSyD7Rts3hi3Don33s UtJfTmtwGOSlfBDJEzVdm8IjgP96nHmx5GxFIPDKfkfCebxxa9UBrNHRuHW+T6BGzw FkrA9PbgKP9aQ== Date: Thu, 2 Jul 2026 16:29:20 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 06/13] mm/vma: convert vm_pgprot_modify() to use vma_flags_t and rename Message-ID: References: <548ba81b2971734d4d2143237ad1465bd1b2f525.1782760670.git.ljs@kernel.org> <20260702122116.65642-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702122116.65642-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-720697/1783006186-552E47C5-BA5FFC58/0/0 X-purgate-type: clean X-purgate-size: 1810 On Thu, Jul 02, 2026 at 08:21:16PM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:29PM +0100, Lorenzo Stoakes wrote: > >Update vm_pgprot_modify() to use the new VMA flags type vma_flags_t, and > >rename to vma_pgprot_modify() accordingly. > > > >This is part of the ongoing work to convert vm_flags_t to vma_flags_t, in > >order to eliminate the arbitrary limit of the number of bits in a system > >word on available VMA flags. > > > >Update VMA userland tests accordingly, updating vma_set_page_prot() to no > >longer inline vma_pgprot_modify(), rather we can simply define > >vma_pgprot_modify() as a static inline function and the tests will pick it > >up from vma.h. > > > >No functional change intended. > > > >Signed-off-by: Lorenzo Stoakes > >--- > [...] > >diff --git a/mm/vma.h b/mm/vma.h > >index bcf0c2773449..6a8abb8ae937 100644 > >--- a/mm/vma.h > >+++ b/mm/vma.h > >@@ -522,9 +522,11 @@ static inline bool vma_wants_manual_pte_write_upgrade(struct vm_area_struct *vma > > } > > > > #ifdef CONFIG_MMU > >-static inline pgprot_t vm_pgprot_modify(pgprot_t oldprot, vm_flags_t vm_flags) > >+static inline pgprot_t vma_pgprot_modify(pgprot_t oldprot, vma_flags_t vma_flags) > > { > >- return pgprot_modify(oldprot, vm_get_page_prot(vm_flags)); > >+ const pgprot_t prot = vma_get_page_prot(vma_flags); > >+ > >+ return pgprot_modify(oldprot, prot); > > Nit: could this just stay as a single return? something like: > > return pgprot_modify(oldprot, vma_get_page_prot(vma_flags)); I feel it's a bit clearer this way, separating out the two, I know it's a super tiny difference but anyway :P > > Otherwise, LGTM, feel free to add: > > Reviewed-by: Lance Yang Thanks! > > [...] Cheers, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:40:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352084.1609005 (Exim 4.92) (envelope-from ) id 1wfJWI-0005MA-4m; Thu, 02 Jul 2026 15:40:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352084.1609005; Thu, 02 Jul 2026 15:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJWI-0005Ll-1S; Thu, 02 Jul 2026 15:40:06 +0000 Received: by outflank-mailman (input) for mailman id 1352084; Thu, 02 Jul 2026 15:40:05 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJWG-00059y-Vg for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:40:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJWG-00EVOQ-C2 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:40:04 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46864a-e002-0a2a0a5209dd-0a2a4504b9c0-24 for ; Thu, 02 Jul 2026 17:40:04 +0200 Received: from [52.101.85.64] (helo=BYAPR05CU005.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a468652-a01d-0a2a45040019-346555404dab-3 for ; Thu, 02 Jul 2026 17:40:04 +0200 Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by CO1PR03MB5683.namprd03.prod.outlook.com (2603:10b6:303:9a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 2 Jul 2026 15:40:00 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.21.0181.009; Thu, 2 Jul 2026 15:40:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xq6L0EW8cmNSozruK4Mh4Uif/JXSa7SKtWbaPHgOV7qNl+04iGK0pZK4IZMXViOvw2zMRJzuRikFWLD9tFojkEUF1ReIsDvs0J5LaK8kBDUqs3aYzztXlp5d2VLjFvNk/U8tkE/+6ePEIruXGEOTF9TLSsgho3uYk/q331/V0hZbazLb1jroOBp+R8F1BRuQo1SloXPpq5fAmFHKVYHWd9BUfcm7S1Sjp3Mg1JuXdmdkWwpiWW3oWbfG7VwiOv9gKvNqvKXBTqIXLCSMmwTLTQDbmeMjAqxDf61rodk3pp2higDFt6YQ7ma1TCb8li9G8BLlArfsu5Hafzd24YpkUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QbowieJOT1/uNI5pXTx+Eiyli8QxGa23XmMOv8oyoDk=; b=P8VAt2bbmTCLvzeIFRsujQtLtM68V4L+Z2VqBbfgJUQ1RqhuIucfYrZwcO5mcil1zJamHWQGUowFh84XLxl6uXUAIuJ8oOFSGt3NvusIIBmZQ3MsG89DPdwGYsvyZjI9USVZflBnhQeiDVqJ/Winbvse74wcphrTDq45hjIrLp3EJmUPFCD+pTKrz6gL94ptm4vjyVuXX0mEINJa2wKAUbzujd3VV5mVPzbx/esK02OQOgyUGUk3o0OWIrstdbaLt+hzP8Nzbpezz5hgW/0YQUfQRpZvcGPthg6sUFWVMGZ1POYzU/077veRwzhHCUDydlfTTUVEtZXkLTtxMpE5rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QbowieJOT1/uNI5pXTx+Eiyli8QxGa23XmMOv8oyoDk=; b=G8E/OPY/nvSm+Lk7DKqW4UmeYwZEZ7Py7W+IoBaomcCRBk71eYAaKumRDl92+y1+HE8iShOKWYhKrHpNQoRT7gJgk1KOq8Dm8fUBl2fngEc0s0+uqnEw/awumTJCzvJppb3doPl1GMdhrTx74ytD7I5QefpLrMuJTcKxQqw3M/k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 2 Jul 2026 17:39:56 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini , Oleksii Kurochko Subject: Re: [PATCH for-4.22] tools/libfsimage: Remove the XEN_FSIMAGE_FSDIR environment variable Message-ID: References: <20260702150301.825883-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260702150301.825883-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: MA3P292CA0019.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250:47::9) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|CO1PR03MB5683:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f1e905f-128a-4f97-f245-08ded8502d2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|366016|1800799024|6133799003|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: cpz7LV4gsA4vsI8GwrXuWyc3HCESvIheXdm/Gx2QQ5r0yNNrdkdzVmtfKhHj5T0t9lmEHAaGl+yDaIQdafVfcQJtY2IP0zLYviS0vaXDiYYYvL8tg5k03G1yYfWgoB+kVWOf2i1KPoJT3SJF85JE8PwDI6yA6FJZgBo3V3WhyTAjPR/Ai1fBOfk6zneu0T7jXsswNutJwMajgV2AMXa1WdZhhvGWuLE9WuPh+usOOOGCwRUP/qyWKFHYgcjJJOl8meWj+PDPlxcq4HVwlfJrOV4AfVlKTc2jpztylEx0cuKRXj30/EjKw9kByCzmIdF2vnb7DpfS4yrcovY/9Bywyl4OzYeuTGF+J+kuhrEJOFuECYpb/LzLuZSYPOEoMq7dZt18atJHktAllNNnynROK/t6bHuKZZR2kNxxazKMx6myspZlaMKNnbwQb0D1+p63eL2knL4DX9hhlAMeGmTumxHzxDjdeAtj6PD6RyRg2yOQGecMrXFWL4SwJoIMLS4bpa0owSFkBcRmChbu07FxM5ATHbmavUrguldKKt/uiQbLfU9kfHdgfmfWt7Vz1jculttHMQAMT3TBOck+cs5rHrB4Aidlfrrm/Enq72pwtckh/nzsleHlOqMlER9oy8k5S0PqI6cvQrWTDECiWmfQTyaAJo5Yt5EiiF2fYMKgKJU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(6133799003)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXB2RVhrNDQ2OXM4em93WGx1VkMxS2svN1RZc3pCSnNsWndWbzEvUWs2akJB?= =?utf-8?B?a2ljRDNZR2l0UDRIU3hoOHRtdDhDK1NicW1aNzVKMVluRE5TTFVjc3c4R1Ir?= =?utf-8?B?MDJLT3c3Wjd6UTJGZDBWdVBWNy93Z0tQZ0s1Q3hYSFRBK0hreStzS0RSdTg4?= =?utf-8?B?T3RhdUZFc00zVUJIWk5kS05WQ0NISFlabVc4YUwxWThQdEJlZ2xaS2pGWTlJ?= =?utf-8?B?L2lJaEF6cVhWNkZTa3NRQWVNaWRiTi9zV0xSMG52RnkweGM0QXl1V3owRW55?= =?utf-8?B?cDFreDhVS2ZYK2hseHFQeGFVbUFpWVVYeUxzQm53SE54ZHkyVTlqOEg1RXdH?= =?utf-8?B?QXpyWHc3bE5EVEZWcG1UUkJ5UXVKeldIckFJSTJjVjlXNTdGdXBmY2tVcEFR?= =?utf-8?B?ck85RE96M2Rtb1RqR0hiNktPQWFoaVFSMUNwQVN1Q3RhazA2My82LzZ0bDJi?= =?utf-8?B?cnYzS2pMOWFrRWdFUk4wbTNLbVl2NFE3UDVCWnA3cDRYWEpid250a3RONHBG?= =?utf-8?B?WGV2NTh4THd2cE9hWDdNRG5RRkZ2Zi9kdkFVMWQyTzh1MzRQeGY1ZUo5NXgv?= =?utf-8?B?ODNDaVFOQnNNei9MK0MxUW9QYlg5SkUrRTUxSk9pZnVWYTRNamNZQ2pvblhW?= =?utf-8?B?L3ZxZjZuR0tMbHlMNUVFYlFmM2MzRkpBaU5hUzZycTg5SzdUalR0dE1kRTJt?= =?utf-8?B?Y0FUdForTnpSY0YyZkVRVTBhZWJsdWNxL25kOXNUZUQ2RW1rWmtkZUZycEdn?= =?utf-8?B?UWpuaVRyWDRvcTVOTHZzdXFzMStueDY5ZDVaV1RpUFZVVEVFS2lXS0p5eEtu?= =?utf-8?B?ZE9CelYzS2xQeEVSa0xiUDZHUGt5VzNteFVoS0wrZStCVVNoQWZwYWFtV1Ry?= =?utf-8?B?dUxsMktlMzBNYWdSbGxEakJ4dGpWNnprUXZBdEFaNEtSQ1BuR0hvRHF0TGYz?= =?utf-8?B?UmFna1dFeTRZTHJvdlJOanVFTWZQM215N3lYRWRUN05CMGpsT2V0YmlzRE5D?= =?utf-8?B?NXM3cGpmR1RGZlZCUXZoSTFndkgrRW56TkpRUVBhLzBNK3pUbSsxMUIyVXhF?= =?utf-8?B?bTdZRzVETm4xK3ppcVNuK3lCRU4xM0FzbytGcWx4TTZydUU3OEZQU2FVbVRD?= =?utf-8?B?T1Z3OC9INnN0d2t5cWk4cWFIUGdHMmdJQkp0Q09uOEhWNDIrVWduSWJUS0U0?= =?utf-8?B?dWN0RXRpZHphdXduYmduN3BhWWUzSXN5a0dMWjBGelk2Y0RCOEpQL3BNOTZw?= =?utf-8?B?UnN3Mnl3OWZvNzU3eXZUdWtTeGpTQ0pTcHJoaFRFMWpZemNEQXNGNFFvSTFW?= =?utf-8?B?SlZsVWRlckxrTERVNGRrMjJwTUpSUnRma3M2czFWOG5aSUtZZ2RHMU14WHlU?= =?utf-8?B?NkpBMFVaRU1sYjJEWHVSU09iWnJlSUNnekJwRDJFTDdCdjI5M0poUmtNY0hU?= =?utf-8?B?aEcvRTFjZ3BSRFNPL0tEQ084azhJQmhCRlc3NjIwdlZEY0dnVytsM291ZzQr?= =?utf-8?B?WlJsOGxVdWczMCsrczRuZWo0T2dqVi9jNjhDZFdRaDliQTFLVTV3NnFubTVo?= =?utf-8?B?SXBaUzUzWk1uSjB5TWNCQ1JxSnB5OHkyNUdiYmlGbndJMXJlRy80c2F0T1NK?= =?utf-8?B?aHRUdVJCUERDUzJnek1wY0gzekpTRG13ZmYxS2NFMW5FVHIxQnNZV09lZ1dQ?= =?utf-8?B?VHFiczV5LzlhODBQc0lpOWhlemNTbHNIV0R2SS9rMmlUK2VQejhWNUx3VVlW?= =?utf-8?B?RzdoYXk3NGM0UzhDU2tMNVVnOEdMZC9La2NrZWYrbUU5TUVXNVdKZlJMdUhj?= =?utf-8?B?aisyaWp4cGdRU2tuUHp1TjFnb2JNeXJLRGZhTWl0OCtEU09hb0tmaU1SVlhF?= =?utf-8?B?WWpJM2cyOWd6Y0w2SjhPc0xXMzVPUjNiN1o5MXdnYWRLR3FoUUN2akF1ditB?= =?utf-8?B?MGxVOGtxbTVSQlB2ZEV2VkFTU0tjZFNsRW5ta053OGdaZ085UGFhN24zQTJq?= =?utf-8?B?R0F4MDYwaFM1bHlMOEJCQUhTYWJzQXVIL1BnZG0vM2RwQlBvdk05UG5LdHpI?= =?utf-8?B?TnBQZGtTa1Flczk0eVFKbGl1RndpUlorWmsrVmRYVzZEdldlekV3K25JdU5Z?= =?utf-8?B?QjdvNWtGbHJZZUt2Z3NKRWxNL0duTnNSc1h0ckkvajFsV2NWTUJad2graGNW?= =?utf-8?B?NHMybXBPMlc3dHllalBGR2tnQmJmK0ptU1QwRnBLMTFKVWN5ZnF2aDBRMnBG?= =?utf-8?B?LzN3Tk1SZDlsREhkWVUvbUZBYlByS1kwRUkvMDl3cG83Z3M3QUR2REZYaTRO?= =?utf-8?B?c2tIbGFlTWdrTStmTVFrWVFFQnRxNVcwNCtCOWZIUFJ6WW8zYVVCdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f1e905f-128a-4f97-f245-08ded8502d2f X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 15:40:00.3295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qwXtM/J1fafZHNTJGn7P1eSZOCRqcEFNBIGs7l3Klvxl9QEW8rAkGzgYXFNQWWZozS+x9i6wv0l10zsSJ7j2FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5683 X-purgate-ID: tlsNG-ebf023/1783006804-AF32F1CC-61F768F0/0/0 X-purgate-type: clean X-purgate-size: 570 On Thu, Jul 02, 2026 at 04:03:01PM +0100, Andrew Cooper wrote: > This was reported to the security team, demonstrating that code execution > could be achieved, but without a demonstration of a priviliege boundary being > bypassed. > > Still, it's a high risk path with no obvious evidence of having been used even > for debugging, so remove the environment variable and use the build time > $(libdir)/xenfsimage path only. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:40:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:40:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352092.1609015 (Exim 4.92) (envelope-from ) id 1wfJWs-0005uS-GS; Thu, 02 Jul 2026 15:40:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352092.1609015; Thu, 02 Jul 2026 15:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJWs-0005uL-CB; Thu, 02 Jul 2026 15:40:42 +0000 Received: by outflank-mailman (input) for mailman id 1352092; Thu, 02 Jul 2026 15:40:41 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJWr-0005uB-Fz for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:40:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJWq-006HWF-T4 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:40:40 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46866d-2eae-0a2a0a5409dd-0a2a45068534-10 for ; Thu, 02 Jul 2026 17:40:40 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a468677-08de-0a2a45060019-ac6904fed628-3 for ; Thu, 02 Jul 2026 17:40:40 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id C7EA7601CA; Thu, 2 Jul 2026 15:40:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE8E41F00A3E; Thu, 2 Jul 2026 15:40:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783006838; bh=gNLYS8EYE6bJ5KaXF7DR9fRu4urDF+a7laqqF8q0hcA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Z8vOAtQOT+iGTiy4xQ3GfxWy9CpR6iieY1qxm1fyBJSvxEFV2aEwGeTLwIZE4UbYF sH6QvDHKQJHBXcc/JYlecYNDNZBJEw63vn2taYjOLxg3iNlePJRLcm76SDX3qcqqpf OAzUHT+NRGQHyZOOfos5EJuVfaKEWfkdr4crDOBp2KFX/hKeIetGWLc1I64/oz6RHQ NC8RA6ivq/IEW4DV1d+3Z0k229cWnviqo6Svky+UHUgnyeaFy3m0xyIovRQ1UfVX8n wqqP9ts5FpBy46j7HS+G+te0/D/3BLeS388iQo+wLiLJCSDRdl7jDwGFy3vdpkllGJ NUUDfmqseIbQg== Date: Thu, 2 Jul 2026 16:40:15 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 08/13] mm: introduce vma_get_page_prot() and use it Message-ID: References: <3bb8bdc4788230c33102166d56cbc5abfad9d4cb.1782760670.git.ljs@kernel.org> <20260702123845.95316-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702123845.95316-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-16d1c6/1783006840-C473068D-0B2CF8FD/0/0 X-purgate-type: clean X-purgate-size: 1835 On Thu, Jul 02, 2026 at 08:38:45PM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:31PM +0100, Lorenzo Stoakes wrote: > >There's a large number of vm_get_page_prot(vma->vm_flags) invocations. Make > >life easier by introducing vma_get_page_prot() parameterised by the VMA. > > > >This also makes converting vm_get_page_prot() to vma_flags_t easier. > > > >Also update the userland VMA tests to reflect the change. > > > >No functional change intended. > > > >Signed-off-by: Lorenzo Stoakes > >--- > > drivers/gpu/drm/drm_gem.c | 2 +- > > drivers/gpu/drm/drm_gem_dma_helper.c | 2 +- > > drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- > > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +- > > drivers/gpu/drm/exynos/exynos_drm_gem.c | 6 +++--- > > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 12 ++++++------ > > drivers/gpu/drm/msm/msm_gem.c | 2 +- > > drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- > > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- > > drivers/gpu/drm/omapdrm/omap_gem.c | 6 +++--- > > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- > > drivers/gpu/drm/tegra/gem.c | 2 +- > > drivers/gpu/drm/virtio/virtgpu_vram.c | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c | 2 +- > > drivers/gpu/drm/xe/xe_device.c | 2 +- > > drivers/gpu/drm/xe/xe_mmio_gem.c | 2 +- > > drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- > > drivers/video/fbdev/core/fb_io_fops.c | 2 +- > > One missed? > > drivers/gpu/drm/panthor/panthor_gem.c still has: > > vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > > Can use vma_get_page_prot(vma) too. Oops! Will respin and update. Good spot! > > [...] Thanks, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:46:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:46:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352104.1609023 (Exim 4.92) (envelope-from ) id 1wfJcW-0006mo-2k; Thu, 02 Jul 2026 15:46:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352104.1609023; Thu, 02 Jul 2026 15:46:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJcV-0006mh-VV; Thu, 02 Jul 2026 15:46:31 +0000 Received: by outflank-mailman (input) for mailman id 1352104; Thu, 02 Jul 2026 15:46:30 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJcU-0006mb-LN for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:46:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJcU-00EUhV-2M for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:46:30 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4687c2-bab6-0a2a0a5309dd-0a2a4506ec10-28 for ; Thu, 02 Jul 2026 17:46:29 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4687d4-08de-0a2a45060019-ac6904feedd0-3 for ; Thu, 02 Jul 2026 17:46:29 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2EBA4601EE; Thu, 2 Jul 2026 15:46:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90EC61F000E9; Thu, 2 Jul 2026 15:46:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783007187; bh=jvE9wSqWBUCbGMsJG9svgBUezevNvrm1MrcHHSCChso=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Mynx6GD6LkebsGmUnF9MjOYGoc5t/kjVRBAa3y4hDMiI7/vl1tQdkpNYaMYBglDKt PpjOhV7WkyGWbA6148JfY40EHSUewPFem4EcHLSNtrDL52P+m6uRZFhhXV+p8drDP5 krlXhtnXXcRAzWJ2KFYq3Hh8rhTgMNWOvfDO5ubcScHxjko5fhA5/oYXfBSBTm3FYZ q91+d//PbttUXOxvDyYYUNz2FFsT7LJ6pIAF99pcS/rpWlpmF6qsZCGqK6q0R7Cu6u A7jMMvK5AtByO3p0pYtd9gulxJxBI42o3AQ7j7VXEvArqPbpGQYUH4EuymRAwVZamK 6IrFtw9w61Ysg== Date: Thu, 2 Jul 2026 16:46:04 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm Message-ID: References: <1e7d834c887b6a65627d730addcff13d458c6268.1782760670.git.ljs@kernel.org> <20260702131233.59026-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702131233.59026-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-16d1c6/1783007189-C4D3568D-248080DD/0/0 X-purgate-type: clean X-purgate-size: 2543 On Thu, Jul 02, 2026 at 09:12:33PM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:33PM +0100, Lorenzo Stoakes wrote: > >Update various uses of legacy flags in vma.c and mmap.c to the new > >vma_flags_t type, updating comments alongside them to be consistent. > > > >Also update __install_special_mapping() to rearrange things slightly to > >accommodate the changes. > > > >Signed-off-by: Lorenzo Stoakes > >--- > [...] > >diff --git a/mm/vma.c b/mm/vma.c > >index b81c05e67a61..ab2ef0f04420 100644 > >--- a/mm/vma.c > >+++ b/mm/vma.c > >@@ -3417,23 +3417,27 @@ struct vm_area_struct *__install_special_mapping( > > vm_flags_t vm_flags, void *priv, > > const struct vm_operations_struct *ops) > > { > >- int ret; > >+ vma_flags_t vma_flags = legacy_to_vma_flags(vm_flags); > > struct vm_area_struct *vma; > >+ int ret; > > > > vma = vm_area_alloc(mm); > >- if (unlikely(vma == NULL)) > >+ if (unlikely(!vma)) > > return ERR_PTR(-ENOMEM); > > > >- vma_set_range(vma, addr, addr + len, 0); > >- vm_flags |= vma_flags_to_legacy(mm->def_vma_flags) | VM_DONTEXPAND; > >+ vma_flags_set_mask(&vma_flags, mm->def_vma_flags); > >+ vma_flags_set(&vma_flags, VMA_DONTEXPAND_BIT); > > if (pgtable_supports_soft_dirty()) > >- vm_flags |= VM_SOFTDIRTY; > >- vm_flags_init(vma, vm_flags & ~VM_LOCKED_MASK); > >+ vma_flags_set(&vma_flags, VMA_SOFTDIRTY_BIT); > >+ vma_flags_clear_mask(&vma_flags, VMA_LOCKED_MASK); > >+ vma->flags = vma_flags; > > Maybe worth a vma_flags_init() helper here to mirror vm_flags_init()? > With this open-coded, we lose the soft-dirty WARN_ON_ONCE sanity check. > > Might be nicer to keep that check in one place ;) I really hate all the VMA flag accessors, they conflate things horribly - we should be explicitly taking VMA write locks when we need to (and often killable ones actually) not assuming that a VMA flags accessor does (they should at most assert). This case is even more terribly egregious - you are setting flags at an arbitrary time, why are we asserting something about softdirty? You may update them as part of initialisation, maybe not. It's far from a guarantee and feels like a lazy place to put it. BUT obviously it's an oversight not to open code that here, so I'll update the patch to do that! I want VMA flags to be a clean stateless thing, other than the flags themselves. Implicit, unrelated, asserts or lock acquisitions in general should be done separately IMO. > > [...] Thanks, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:47:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:47:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352113.1609033 (Exim 4.92) (envelope-from ) id 1wfJde-0007Nb-By; Thu, 02 Jul 2026 15:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352113.1609033; Thu, 02 Jul 2026 15:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJde-0007NT-7o; Thu, 02 Jul 2026 15:47:42 +0000 Received: by outflank-mailman (input) for mailman id 1352113; Thu, 02 Jul 2026 15:47:40 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJdc-0007M2-Ns for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:47:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJdb-0087ca-NB for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:47:39 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46880a-e002-0a2a0a5209dd-0a2a450ca58c-32 for ; Thu, 02 Jul 2026 17:47:39 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46881a-f399-0a2a450c0019-ac6904fea700-3 for ; Thu, 02 Jul 2026 17:47:39 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E29F6601F1; Thu, 2 Jul 2026 15:47:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 504D91F00A3E; Thu, 2 Jul 2026 15:47:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783007257; bh=Po4UWa+Txwx6nSBMW1aPQiZMcfNfQH1HH88CC93hgvE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TzKC7lqe9Irn8JWqPCnRnBZrIjo+wjSEuABLaM62PvcVIf4DaJMLiJvSaLOlIhJOf znTjZNuNsA3irPkrJRqgdqBSalvaquhCKCvJXbcnp48ft4f4usQWudMjc5HdiilEg8 aXu2StIvmQVSGOVmy/Z45hqYBBWUQ4dmbbAuXk0zKTG9Nk6i9FrPim4oLQSVwaxjeJ SDNmxdCjFnKqxvBlFG1TSv8opFwMO6hCg3J9TODlwY2GGXnrD8Ppex9n5gZkrvDNyw HAH74jjJFvvUXueVEU77M3F6be8/OSAHgO1cGcNXrmLyLcrgWJzjocoh6IYJOxKTNs hiEtCFwm59HOw== Date: Thu, 2 Jul 2026 16:47:14 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 11/13] mm/mlock: convert mlock code to use vma_flags_t Message-ID: References: <2db16db81538355ca65f778c246d2381c673cad4.1782760670.git.ljs@kernel.org> <20260702132107.73727-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702132107.73727-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-d25034/1783007259-A88A7D51-D963730D/0/0 X-purgate-type: clean X-purgate-size: 1969 On Thu, Jul 02, 2026 at 09:21:07PM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:34PM +0100, Lorenzo Stoakes wrote: > >Replace use of the legacy vm_flags_t flags with vma_flags_t values > >throughout the mlock logic. > > > >Additionally update comments to reflect the changes to be consistent. > > > >No functional change intended. > > > >Signed-off-by: Lorenzo Stoakes > >--- > > Nothing scary jumped out at me. Just one tiny nit below ;) > > [...] > >@@ -466,24 +466,23 @@ static void mlock_vma_pages_range(struct vm_area_struct *vma, > > */ > > static int mlock_fixup(struct vma_iterator *vmi, struct vm_area_struct *vma, > > struct vm_area_struct **prev, unsigned long start, > >- unsigned long end, vm_flags_t newflags) > >+ unsigned long end, vma_flags_t *new_vma_flags) > > { > >- vma_flags_t new_vma_flags = legacy_to_vma_flags(newflags); > > const vma_flags_t old_vma_flags = vma->flags; > > struct mm_struct *mm = vma->vm_mm; > > int nr_pages; > > int ret = 0; > > > >- if (vma_flags_same_pair(&old_vma_flags, &new_vma_flags) || > >+ if (vma_flags_same_pair(&old_vma_flags, new_vma_flags) || > > vma_is_secretmem(vma) || !vma_supports_mlock(vma)) { > > /* > >- * Don't set VM_LOCKED or VM_LOCKONFAULT and don't count. > >+ * Don't set VMA_LOCKED_BIT or VM_LOCKONFAULT and don't count. > > s/VM_LOCKONFAULT/VMA_LOCKONFAULT_BIT/ Ah yeah oops, will fix and respin! Good spot [and claude missed it ugh] :) > > Otherwise LGTM. Feel free to add: > > Reviewed-by: Lance Yang > > > * For secretmem, don't allow the memory to be unlocked. > > */ > > goto out; > > } > > > >- vma = vma_modify_flags(vmi, *prev, vma, start, end, &new_vma_flags); > >+ vma = vma_modify_flags(vmi, *prev, vma, start, end, new_vma_flags); > > if (IS_ERR(vma)) { > > ret = PTR_ERR(vma); > > goto out; > [...] Thanks, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 15:53:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 15:53:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352127.1609040 (Exim 4.92) (envelope-from ) id 1wfJjF-0000x7-TT; Thu, 02 Jul 2026 15:53:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352127.1609040; Thu, 02 Jul 2026 15:53:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJjF-0000x0-Qm; Thu, 02 Jul 2026 15:53:29 +0000 Received: by outflank-mailman (input) for mailman id 1352127; Thu, 02 Jul 2026 15:53:28 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJjE-0000wu-1r for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 15:53:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJjD-007IZG-Dt for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:53:27 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a468963-5cb7-0a2a0a5109dd-0a2a450599ec-42 for ; Thu, 02 Jul 2026 17:53:27 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a468976-3cb2-0a2a45050019-ac6904fed1cc-3 for ; Thu, 02 Jul 2026 17:53:27 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8A81B601CA; Thu, 2 Jul 2026 15:53:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87BC51F000E9; Thu, 2 Jul 2026 15:53:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783007605; bh=rQoQgNL4RLwOJnesXJ906iiowNQYEhnsDiycftRDMfA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=RQbSkv+EjZljB5g46djvoiDLFxojsXRU7Kht7L4jS+hQfEbvLoddE5ik5cDm8RdCY BqtXzK5uRv9pKYN6O4Tsu8EtqfPc36l/PyBm4MnF4L/Lj7XhDm03p3BdIE6c5nK+EW WgpMr9xlTDqRIB0VqPTmKhcFe7wtPBcgkLNUiWKV6EXjD7eDfr1juT0c0xwZM3oIhX yoTEQ0aDxj88mE4YuknOHetVU7Tkkxdet4F5l/46xPMCuTjg7uKR5BnT4gNu2YfNUW X6p/cRUZ6h1qZ1EK6Q4sO2TBLVEUPUv3Po11nDMVUJoDiNp2oyKVRliXzikuEZxJQO doneV51wWqdgg== Date: Thu, 2 Jul 2026 16:53:01 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 12/13] mm/mprotect: convert mprotect code to use vma_flags_t Message-ID: References: <7ef626d8a12dc742cfc09d080be5dc09850e873a.1782760670.git.ljs@kernel.org> <20260701160917.91435-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701160917.91435-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-c201ff/1783007607-151042B8-799A1D2D/0/0 X-purgate-type: clean X-purgate-size: 4441 On Thu, Jul 02, 2026 at 12:09:17AM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:35PM +0100, Lorenzo Stoakes wrote: > >Replace use of the legacy vm_flags_t flags with vma_flags_t values > >throughout the mprotect logic. > > > >Note that we retain the legacy vm_flags_t bit shifting code in > >do_mprotect_key(), deferring a vma_flags_t approach to this for the time > >being. > > > >Additionally update comments to reflect the changes to be consistent. > > > >No functional change intended. > > > >Signed-off-by: Lorenzo Stoakes > >--- > > mm/mprotect.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > >diff --git a/mm/mprotect.c b/mm/mprotect.c > >index 9cbf932b028c..c9504b2a2525 100644 > >--- a/mm/mprotect.c > >+++ b/mm/mprotect.c > >@@ -40,7 +40,7 @@ > > > > static bool maybe_change_pte_writable(struct vm_area_struct *vma, pte_t pte) > > { > >- if (WARN_ON_ONCE(!(vma->vm_flags & VM_WRITE))) > >+ if (WARN_ON_ONCE(!vma_test(vma, VMA_WRITE_BIT))) > > return false; > > > > /* Don't touch entries that are not even readable. */ > >@@ -97,7 +97,7 @@ static bool can_change_shared_pte_writable(struct vm_area_struct *vma, > > bool can_change_pte_writable(struct vm_area_struct *vma, unsigned long addr, > > pte_t pte) > > { > >- if (!(vma->vm_flags & VM_SHARED)) > >+ if (!vma_test(vma, VMA_SHARED_BIT)) > > return can_change_private_pte_writable(vma, addr, pte); > > > > return can_change_shared_pte_writable(vma, pte); > >@@ -194,7 +194,7 @@ static __always_inline void set_write_prot_commit_flush_ptes(struct vm_area_stru > > { > > bool set_write; > > > >- if (vma->vm_flags & VM_SHARED) { > >+ if (vma_test(vma, VMA_SHARED_BIT)) { > > set_write = can_change_shared_pte_writable(vma, ptent); > > prot_commit_flush_ptes(vma, addr, ptep, oldpte, ptent, nr_ptes, > > /* idx = */ 0, set_write, tlb); > >@@ -811,8 +811,8 @@ mprotect_fixup(struct vma_iterator *vmi, struct mmu_gather *tlb, > > vm_unacct_memory(nrpages); > > > > /* > >- * Private VM_LOCKED VMA becoming writable: trigger COW to avoid major > >- * fault on access. > >+ * Private VMA_LOCKED_BIT VMA becoming writable: trigger COW to avoid > >+ * major fault on access. > > */ > > if (vma_flags_test(&new_vma_flags, VMA_WRITE_BIT) && > > vma_flags_test(&old_vma_flags, VMA_LOCKED_BIT) && > >@@ -886,7 +886,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > > goto out; > > start = vma->vm_start; > > error = -EINVAL; > >- if (!(vma->vm_flags & VM_GROWSDOWN)) > >+ if (!vma_test(vma, VMA_GROWSDOWN_BIT)) > > goto out; > > } else { > > if (vma->vm_start > start) > >@@ -894,7 +894,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > > if (unlikely(grows & PROT_GROWSUP)) { > > end = vma->vm_end; > > error = -EINVAL; > >- if (!(vma->vm_flags & VM_GROWSUP)) > >+ if (!vma_test(vma, VMA_GROWSUP_BIT)) > > IIUC, should this be > > if (!vma_test_single_mask(vma, VMA_GROWSUP)) > > instead? > > #elif defined(CONFIG_PARISC) > #define VM_GROWSUP INIT_VM_FLAG(GROWSUP) > ... > #ifndef VM_GROWSUP > #define VM_GROWSUP VM_NONE > ... > > VM_GROWSUP is only defined as GROWSUP on parisc and becomes VM_NONE > elsewhere. But VMA_GROWSUP_BIT is the raw ARCH_1 bit, which is also used > for other arch-specific VMA flags: > > DECLARE_VMA_BIT_ALIAS(SAO, ARCH_1), /* Strong Access Ordering (powerpc) */ > DECLARE_VMA_BIT_ALIAS(GROWSUP, ARCH_1), /* parisc */ > DECLARE_VMA_BIT_ALIAS(SPARC_ADI, ARCH_1), /* sparc64 */ > DECLARE_VMA_BIT_ALIAS(ARM64_BTI, ARCH_1), /* arm64 */ > DECLARE_VMA_BIT_ALIAS(ARCH_CLEAR, ARCH_1), /* sparc64, arm64 */ > DECLARE_VMA_BIT_ALIAS(MAPPED_COPY, ARCH_1), /* !CONFIG_MMU */ > > Other vma_test() changes look fine to me: just fixed INIT_VM_FLAG() > masks matching their VMA_*_BIT :) Thanks you're right, will fix! Again I swear I ran claude on all of this so it's failing me here :) > > Cheers, Lance > > > goto out; > > } > > } > >@@ -918,7 +918,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > > } > > > > /* Does the application expect PROT_READ to imply PROT_EXEC */ > >- if (rier && (vma->vm_flags & VM_MAYEXEC)) > >+ if (rier && vma_test(vma, VMA_MAYEXEC_BIT)) > > prot |= PROT_EXEC; > > > > /* > >-- > >2.54.0 > > > > From xen-devel-bounces@lists.xenproject.org Thu Jul 02 16:04:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 16:04:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352143.1609050 (Exim 4.92) (envelope-from ) id 1wfJtn-00044A-U0; Thu, 02 Jul 2026 16:04:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352143.1609050; Thu, 02 Jul 2026 16:04:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJtn-000443-QD; Thu, 02 Jul 2026 16:04:23 +0000 Received: by outflank-mailman (input) for mailman id 1352143; Thu, 02 Jul 2026 16:04:22 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfJtm-00043x-KN for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:04:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJtm-00FHEq-1D for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 18:04:22 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a468bfe-2eae-0a2a0a5409dd-0a2a4507d9de-22 for ; Thu, 02 Jul 2026 18:04:21 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a468c05-9c8e-0a2a45070019-d155dd31d51c-3 for ; Thu, 02 Jul 2026 18:04:21 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-4745492ed3aso1319110f8f.1 for ; Thu, 02 Jul 2026 09:04:21 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6354771sm63382545e9.3.2026.07.02.09.04.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 09:04:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783008261; x=1783613061; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hg7xCQml2wVUlKW51sJppmbaydhq4zZPmDS+V54apPw=; b=Px+9NHfdN3pCgb4XTGzb+uGgfSHfemFdFwft23qscLvnbPpQ2W+gi6OyVLk+oHoLBa prlaf/DVC9t57NIxPLLNdG+Cg8zVIPG49j24Iz2qjgs2WpdKU2dLHSIXf+XG2RgnrOWr r3FLE5AUmGFG2/aYmcmhD3g0/yB2gBmYHiFsBlXddY8wznZbXV/5XC2M9cgjbRXWaeS0 wAoVpmvCKqLK8Hf8HZy49f3IKifwaXSrJXJBrNihrkBI3ds+IQdpYqcJ2p1nZpo1occU qRdpnnbYRAOsmbmEsEosVYaPlLIVSP+vRQDu3cD4KOfWo3XpCpC0UiDy+Gvnr51UwXwt eBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783008261; x=1783613061; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hg7xCQml2wVUlKW51sJppmbaydhq4zZPmDS+V54apPw=; b=JX/8yu9IdQRpes3sdWtNwJQPYe02CC41VL+rNJKcAiEQQ5sdKPiWJTjTXsvWae8TFO kju044x2t4wI8U32R7iil12vfx0qwEoAOSe6pCNsqJpcVuI3Ioetn9TNi5uQUAnvPykj U2yqTZI/R+5ewAjZyb64ucqj7UAXXrXgf8SyqH1Y01CIlrIcZpdS+m5MFsWUJgBqffkV wmA5rq9FvuKp8C1nu9H9HEV9/WMko1nfo3wAg98YFfm87aKhJJZ2sQ6hlU0ecgSo08bn NY8vRVdSVvLKvApPZyt0GLMSTRGfwcWLlcpWEF5PWPQiTHHK3TS+wul8sW4Lxkpjo2ja B3xQ== X-Forwarded-Encrypted: i=1; AFNElJ+ly3qLhoSfNYwcv+kSCKuQywRl6yknqOR+4Tjg+A75uGxA9cIYg+8h5Iq+ggI2wiDek8ibB2F0Vgs=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz2cbI1jz9jzUchr5bi4UkPXOirs5+Cz0FZtnFaxHT3a2jiCXqU pKogQOak61ivjATnWLGXQ1TzGd0P0ArgK80fKOSe29ERvSDTkvgllTFp X-Gm-Gg: AfdE7ck7BoK4PcYqeHzFDMPSd6oIQ7pKvmkPdWy55cNcFa0h/tPo9NfhfH3t3NeUQ+R Fz8IXZJAuCjzsl4yA/4IQE0uTzGEzW+Ehdqo3Ks1mTVldUpBEKrcTyKGS+gusZuBjOQ8pPYGauK oX9beKEjbDZwU5lLkyesAAxbY8x48q7Ru0ofR2fKQBOWDjp139EKii2eD1p12Hp/sT+Hk/2D4J1 vJxKj5i/LVw8Oq2iCTfXyXXxF3V/Px7EkpF7FQe59jIOvH5WYUBFybEe0MQH5LBooWHm9Ci9Wgn 86QIb2SHOy/15PLFRQCV1qd0xFR8AOzmP1tCqFU4A6tj032RNTLbGryItaAx5zs+/AWm7lLsJas +zp7uazOI7w+qKDnrSRmBtFSVype0S5f6tBEdkcXdRWh9lAakuYxvmTx7mnRrffox9s5ZAS4nIY sGETdNn7hIUXtExBit3smeQtco50qZ0SUgfE6f3KtqMIkm+Cb9H6aK4gbP+XVUPpm0gnI= X-Received: by 2002:a05:600c:34d4:b0:493:a966:d5b5 with SMTP id 5b1f17b1804b1-493c2b3a709mr98864035e9.2.1783008261100; Thu, 02 Jul 2026 09:04:21 -0700 (PDT) Message-ID: Date: Thu, 2 Jul 2026 18:04:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/25] xen/riscv: implement IRQ routing for device passthrough To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <472a77604d35a0bc2a75b71f250fd67b63afde4c.1782487661.git.oleksii.kurochko@gmail.com> <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> <40bcf6b7-306a-419a-bf12-1855f9e589fe@suse.com> <91ffc1b2-7648-4185-a2f1-12b30181c8a9@gmail.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1783008261-7DD2425E-221535F7/10/73395122804 X-purgate-type: spam X-purgate-size: 2926 On 7/2/26 4:32 PM, Jan Beulich wrote: > On 02.07.2026 11:33, Oleksii Kurochko wrote: >> >> >> On 7/2/26 8:38 AM, Jan Beulich wrote: >> >>>>>> + spin_unlock_irqrestore(&desc->lock, flags); >>>>>> + >>>>>> + release_irq(desc->irq, info); >>>>>> + xvfree(info); >>>>> >>>>> If, in release_irq(), action isn't freed, it's ->dev_id field will now have >>>>> a dangling pointer. (I think I did point this out before.) >>>> >>>> It should freed in release_irq() as route_irq_to_guest() always set >>>> action->free_on_release = true; >>> >>> Well, "free_on_release" must exits for a purpose. I.e. there must be, now >>> or soon, cases where it's set to false. Else simply drop the field. >> >> I can't simply remove this field because it is part of the common >> `struct irqaction` and is used by other arc-s. (I assume that it is not >> what you fully meant...) >> >> IIUC, this field is used to determine whether an irqaction is >> heap-allocated (and therefore should be freed) or statically allocated >> (and therefore should not be freed). > > Yes. However, all uses of the field are in arch-specific code. So in > principle it could be #ifdef-ed out for RISC-V. There may be a better > option, though: > >> At the moment, all IRQ actions are heap-allocated (on RISC-V), so >> free_on_release should always be set to true. In particular, the code >> snippet you asked about releases a guest interrupt, and guest interrupt >> actions are always heap-allocated. As a result, when release_guest_irq() >> calls release_irq(), the associated irqaction will be freed. >> >> So, from what I can see, the current behavior is correct and I think it >> should be left as it is. Do you have any concerns about this? > > If you only ever have the field set to true, use ASSERT() in place of > if(). > It looks like that if we want an `ASSERT()`, it should be in `release_guest_irq()`. However, that would require duplicating part of `release_irq()` to locate the corresponding `irqaction` and verify `free_on_release`. Since guest IRQs are created through `route_irq_to_guest()`, which always sets `action->free_on_release = true`, we are already safe. I don't see much benefit in replacing the `if` statement with an `ASSERT()` in `release_irq()`. The current implementation is generic and would also work for Xen-owned, statically allocated interrupts (even though there are none today). If we replace the `if` with an `ASSERT()` now, anyone introducing a Xen-owned, statically allocated interrupt in the future would simply have to revert the change and restore the `if` statement, bringing us back to the current implementation. Since the existing code doesn't break any logic and already handles both the current use case and potential future extensions (statically allocated irqs), it seems reasonable to keep it as it is. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Jul 02 16:07:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 16:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352152.1609059 (Exim 4.92) (envelope-from ) id 1wfJww-0004jh-Cq; Thu, 02 Jul 2026 16:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352152.1609059; Thu, 02 Jul 2026 16:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJww-0004j3-8W; Thu, 02 Jul 2026 16:07:38 +0000 Received: by outflank-mailman (input) for mailman id 1352152; Thu, 02 Jul 2026 16:07:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfJwv-0004h5-B2 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:07:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfJwu-008dlG-H3 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 18:07:36 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a468cad-2eae-0a2a0a5409dd-0a2a450c8618-42 for ; Thu, 02 Jul 2026 18:07:36 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a468cc6-f399-0a2a450c0019-aceafc1f8e1c-3 for ; Thu, 02 Jul 2026 18:07:36 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E840C43BB8; Thu, 2 Jul 2026 16:07:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C8A31F000E9; Thu, 2 Jul 2026 16:07:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783008453; bh=TfvR3Muaq7o+afYbXjsDSvqRy7FxUVckvz1k4Hxbez0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=RZKUR0qnMCX1lVPMLegWDJwvMR3XwPOjgqmuDlY8+1sNyGBX6G0WNkOyriJ+PtG6y WoL1rkJ4u0k6Z/pcI27Q9cfN5qit8W5zrOm26I9VdyLr6cW2bUvNsdF/9cAdED/TO5 AhCJxe7BVGNUURRd3IeizZOkboEYr9oFtXUUDXIMY549O+sfZleE5cdwLHHY1Mnd5w fUEwk8w3Bqh1uArvHx8Wkw0ChPSb59uuaQpmYgj0hIESSw8+X4zGBfFv8Mg5ixvDOI z8XtFU+Dq4mFlmkaOHGXh7hbxcLj3TzRDApEJrIOyiLSNEjyj9JwDrdlVKeNPP3pCm r9BU9h8EBQzqg== Date: Thu, 2 Jul 2026 17:07:10 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t Message-ID: References: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> <20260702134947.25189-1-lance.yang@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702134947.25189-1-lance.yang@linux.dev> X-purgate-ID: tlsNG-d25034/1783008456-0E93CD51-0F9EC836/0/0 X-purgate-type: clean X-purgate-size: 7008 On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote: > > On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote: > >Replace use of the legacy vm_flags_t flags with vma_flags_t values > >throughout the mremap logic. > > > >Additionally update comments to reflect the changes to be consistent. > > > >No functional change intended. > > > >Signed-off-by: Lorenzo Stoakes > >--- > > The vm_flags_set() cases below spell out vma_start_write(), but the > vm_flags_clear() cases don't? Yep as I said elsewhere, implicitly taking the lock is terrible and me doing this is completely on purpose to get rid of that :) But I haven't been clear enough clearly, so I should put the argument as to why that's ok in the commit message. Will do so on respin. > > Thanks, Lance > > > mm/mremap.c | 38 ++++++++++++++++++++------------------ > > 1 file changed, 20 insertions(+), 18 deletions(-) > > > >diff --git a/mm/mremap.c b/mm/mremap.c > >index 079a0ba0c4a7..0ea43302b7ed 100644 > >--- a/mm/mremap.c > >+++ b/mm/mremap.c > >@@ -68,7 +68,7 @@ struct vma_remap_struct { > > bool populate_expand; /* mlock()'d expanded, must populate. */ > > enum mremap_type remap_type; /* expand, shrink, etc. */ > > bool mmap_locked; /* Is mm currently write-locked? */ > >- unsigned long charged; /* If VM_ACCOUNT, # pages to account. */ > >+ unsigned long charged; /* If VMA_ACCOUNT_BIT, # pgs to account */ > > bool vmi_needs_invalidate; /* Is the VMA iterator invalidated? */ > > }; > > > >@@ -954,7 +954,7 @@ static unsigned long vrm_set_new_addr(struct vma_remap_struct *vrm) > > > > if (vrm->flags & MREMAP_FIXED) > > map_flags |= MAP_FIXED; > >- if (vma->vm_flags & VM_MAYSHARE) > >+ if (vma_test(vma, VMA_MAYSHARE_BIT)) > > map_flags |= MAP_SHARED; > > > > res = get_unmapped_area(vma->vm_file, new_addr, vrm->new_len, pgoff, > >@@ -976,7 +976,7 @@ static bool vrm_calc_charge(struct vma_remap_struct *vrm) > > { > > unsigned long charged; > > > >- if (!(vrm->vma->vm_flags & VM_ACCOUNT)) > >+ if (!vma_test(vrm->vma, VMA_ACCOUNT_BIT)) > > return true; > > > > /* > >@@ -1003,7 +1003,7 @@ static bool vrm_calc_charge(struct vma_remap_struct *vrm) > > */ > > static void vrm_uncharge(struct vma_remap_struct *vrm) > > { > >- if (!(vrm->vma->vm_flags & VM_ACCOUNT)) > >+ if (!vma_test(vrm->vma, VMA_ACCOUNT_BIT)) > > return; > > > > vm_unacct_memory(vrm->charged); > >@@ -1023,7 +1023,7 @@ static void vrm_stat_account(struct vma_remap_struct *vrm, > > struct vm_area_struct *vma = vrm->vma; > > > > vm_stat_account(mm, vma->vm_flags, pages); > >- if (vma->vm_flags & VM_LOCKED) > >+ if (vma_test(vma, VMA_LOCKED_BIT)) > > mm->locked_vm += pages; > > } > > > >@@ -1167,7 +1167,7 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > > * arose, in which case we _do_ wish to unmap the _new_ VMA, which means > > * we actually _do_ want it be unaccounted. > > */ > >- bool accountable_move = (vma->vm_flags & VM_ACCOUNT) && > >+ bool accountable_move = vma_test(vma, VMA_ACCOUNT_BIT) && > > !(vrm->flags & MREMAP_DONTUNMAP); > > > > /* > >@@ -1186,7 +1186,7 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > > * portions of the original VMA that remain. > > */ > > if (accountable_move) { > >- vm_flags_clear(vma, VM_ACCOUNT); > >+ vma_clear_flags(vma, VMA_ACCOUNT_BIT); This is called from move_vma() which holds the VMA write lock on vma. > > /* We are about to split vma, so store the start/end. */ > > vm_start = vma->vm_start; > > vm_end = vma->vm_end; > >@@ -1211,8 +1211,8 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > > * | | > > * |-------------| > > * > >- * Having cleared VM_ACCOUNT from the whole VMA, after we unmap above > >- * we'll end up with: > >+ * Having cleared VMA_ACCOUNT_BIT from the whole VMA, after we unmap > >+ * above we'll end up with: > > * > > * addr end > > * | | > >@@ -1232,13 +1232,15 @@ static void unmap_source_vma(struct vma_remap_struct *vrm) > > if (vm_start < addr) { > > struct vm_area_struct *prev = vma_prev(&vmi); > > > >- vm_flags_set(prev, VM_ACCOUNT); /* Acquires VMA lock. */ > >+ vma_start_write(prev); > >+ vma_set_flags(prev, VMA_ACCOUNT_BIT); > > } > > > > if (vm_end > end) { > > struct vm_area_struct *next = vma_next(&vmi); > > > >- vm_flags_set(next, VM_ACCOUNT); /* Acquires VMA lock. */ > >+ vma_start_write(next); > >+ vma_set_flags(next, VMA_ACCOUNT_BIT); These need vma_start_write() as referencing other, unlocked VMAs. > > } > > } > > } > >@@ -1321,8 +1323,8 @@ static void dontunmap_complete(struct vma_remap_struct *vrm, > > unsigned long old_start = vrm->vma->vm_start; > > unsigned long old_end = vrm->vma->vm_end; > > > >- /* We always clear VM_LOCKED[ONFAULT] on the old VMA. */ > >- vm_flags_clear(vrm->vma, VM_LOCKED_MASK); > >+ /* We always clear VMA_LOCKED[ONFAULT]_BIT on the old VMA. */ > >+ vma_clear_flags_mask(vrm->vma, VMA_LOCKED_MASK); - Same as above, called from move_vma() with VMA write lock held. > > > > /* > > * anon_vma links of the old vma is no longer needed after its page > >@@ -1758,14 +1760,14 @@ static int check_prep_vma(struct vma_remap_struct *vrm) > > * based on the original. There are no known use cases for this > > * behavior. As a result, fail such attempts. > > */ > >- if (!old_len && !(vma->vm_flags & (VM_SHARED | VM_MAYSHARE))) { > >+ if (!old_len && !vma_test_any(vma, VMA_SHARED_BIT, VMA_MAYSHARE_BIT)) { > > pr_warn_once("%s (%d): attempted to duplicate a private mapping with mremap. This is not supported.\n", > > current->comm, current->pid); > > return -EINVAL; > > } > > > > if ((vrm->flags & MREMAP_DONTUNMAP) && > >- (vma->vm_flags & (VM_DONTEXPAND | VM_PFNMAP))) > >+ vma_test_any(vma, VMA_DONTEXPAND_BIT, VMA_PFNMAP_BIT)) > > return -EINVAL; > > > > /* > >@@ -1795,7 +1797,7 @@ static int check_prep_vma(struct vma_remap_struct *vrm) > > return 0; > > > > /* We are expanding and the VMA is mlock()'d so we need to populate. */ > >- if (vma->vm_flags & VM_LOCKED) > >+ if (vma_test(vma, VMA_LOCKED_BIT)) > > vrm->populate_expand = true; > > > > /* Need to be careful about a growing mapping */ > >@@ -1803,10 +1805,10 @@ static int check_prep_vma(struct vma_remap_struct *vrm) > > if (pgoff + (new_len >> PAGE_SHIFT) < pgoff) > > return -EINVAL; > > > >- if (vma->vm_flags & (VM_DONTEXPAND | VM_PFNMAP)) > >+ if (vma_test_any(vma, VMA_DONTEXPAND_BIT, VMA_PFNMAP_BIT)) > > return -EFAULT; > > > >- if (!mlock_future_ok(mm, vma->vm_flags & VM_LOCKED, vrm->delta)) > >+ if (!mlock_future_ok(mm, vma_test(vma, VMA_LOCKED_BIT), vrm->delta)) > > return -EAGAIN; > > > > if (!may_expand_vm(mm, &vma->flags, vrm->delta >> PAGE_SHIFT)) > >-- > >2.54.0 > > > > Cheers, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 16:18:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 16:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352166.1609068 (Exim 4.92) (envelope-from ) id 1wfK7H-00070E-8O; Thu, 02 Jul 2026 16:18:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352166.1609068; Thu, 02 Jul 2026 16:18:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfK7H-000707-5b; Thu, 02 Jul 2026 16:18:19 +0000 Received: by outflank-mailman (input) for mailman id 1352166; Thu, 02 Jul 2026 16:18:17 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfK7F-0006zy-43 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:18:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfK7C-008CkH-TV for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 18:18:15 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a468f43-e002-0a2a0a5209dd-0a2a4506d37c-6 for ; Thu, 02 Jul 2026 18:18:14 +0200 Received: from [95.215.58.181] (helo=out-181.mta1.migadu.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a468f45-08de-0a2a45060019-5fd73ab5ae21-3 for ; Thu, 02 Jul 2026 18:18:13 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References" Message-ID: <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783009091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLm6wd6MZy34PotO0lu+sqiieTpRzFwK6t+5eDAyG2s=; b=ZvFsPkNBnPpT/fXlkSqC4NvmGcAElqV1ItfaWxOxanuNMADXNea0vysO/aaC9fK20Fa/Nl /h+xkuVNERTD1ctetn6nlGPrMQ61CJ3XCqhhkVF860M2M509mqat5nuz+pZfFLHprM1shj DZ6Bs3Xsc4eQrpsCTRy6e4DCc3heh0Y= Date: Fri, 3 Jul 2026 00:17:29 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t Content-Language: en-US To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org References: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> <20260702134947.25189-1-lance.yang@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-16d1c6/1783009094-C5B3A68D-7765C000/0/0 X-purgate-type: clean X-purgate-size: 984 On 2026/7/3 00:07, Lorenzo Stoakes wrote: > On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote: >> >> On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote: >>> Replace use of the legacy vm_flags_t flags with vma_flags_t values >>> throughout the mremap logic. >>> >>> Additionally update comments to reflect the changes to be consistent. >>> >>> No functional change intended. >>> >>> Signed-off-by: Lorenzo Stoakes >>> --- >> >> The vm_flags_set() cases below spell out vma_start_write(), but the >> vm_flags_clear() cases don't? > > Yep as I said elsewhere, implicitly taking the lock is terrible and me doing > this is completely on purpose to get rid of that :) > > But I haven't been clear enough clearly, so I should put the argument as to why > that's ok in the commit message. > > Will do so on respin. Makes sense, thanks for spelling it out! A short changelog note should clear it up for me :D [...] From xen-devel-bounces@lists.xenproject.org Thu Jul 02 16:32:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 16:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352195.1609077 (Exim 4.92) (envelope-from ) id 1wfKKO-000246-E6; Thu, 02 Jul 2026 16:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352195.1609077; Thu, 02 Jul 2026 16:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfKKO-00023z-BS; Thu, 02 Jul 2026 16:31:52 +0000 Received: by outflank-mailman (input) for mailman id 1352195; Thu, 02 Jul 2026 16:31:50 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfKKM-00023t-Ue for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:31:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfKKL-007GfE-UP for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 18:31:49 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a469255-bab6-0a2a0a5309dd-0a2a4507b8c8-46 for ; Thu, 02 Jul 2026 18:31:49 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a469274-9c8e-0a2a45070019-aceafc1f9164-3 for ; Thu, 02 Jul 2026 18:31:49 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6EC6943A8D; Thu, 2 Jul 2026 16:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5261F00A3A; Thu, 2 Jul 2026 16:31:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783009907; bh=E1qWf++P4fQTxTfdt1w7bxV4tlwl6MwcbrDidejiQ/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=FTJm75v6g78dw7nc2yIjeNrtd/XXU46WO/2u8nnziEKlJYchAWQ9hGEChgT4F31ah HiH5xTUbuFOhBbd6C1duQ+RhK7b4oHictxqHPOAi/lrzXWZ0FTN2EDGOuyFEWt0mD1 vjw0IUs1vrHYSMCjr+3zzHxShdi1SoTmUIrBx0H0nw1oUHkfV6THw+nOZBnbM1ksv+ +IgzClZgoCati852KoF+eqgYzFxCjgh+OL3JRZibavJHQwCUYoiGfhSnInQcjeQExX M1Tr3eyxRp2MXQhzrXdgxW+NoNc9BMVcJx67MLhqeaR6Vs6Z2WBP6mhtT0mJnysYek vPOd4U2WlHy2g== Date: Thu, 2 Jul 2026 17:31:24 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t Message-ID: References: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> <20260702134947.25189-1-lance.yang@linux.dev> <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> X-purgate-ID: tlsNG-ef75cf/1783009909-7DB2325E-5FAACDFD/0/0 X-purgate-type: clean X-purgate-size: 1287 On Fri, Jul 03, 2026 at 12:17:29AM +0800, Lance Yang wrote: > > > On 2026/7/3 00:07, Lorenzo Stoakes wrote: > > On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote: > > > > > > On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote: > > > > Replace use of the legacy vm_flags_t flags with vma_flags_t values > > > > throughout the mremap logic. > > > > > > > > Additionally update comments to reflect the changes to be consistent. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > --- > > > > > > The vm_flags_set() cases below spell out vma_start_write(), but the > > > vm_flags_clear() cases don't? > > > > Yep as I said elsewhere, implicitly taking the lock is terrible and me doing > > this is completely on purpose to get rid of that :) > > > > But I haven't been clear enough clearly, so I should put the argument as to why > > that's ok in the commit message. > > > > Will do so on respin. > > Makes sense, thanks for spelling it out! A short changelog note > should clear it up for me :D Yeah absolutely, that's necessary and was an oversight on my part, will correct! Thanks for your great review here, much appreciated! :) > > [...] Cheers, Lorenzo From xen-devel-bounces@lists.xenproject.org Thu Jul 02 16:39:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 16:39:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352212.1609086 (Exim 4.92) (envelope-from ) id 1wfKRr-0003GD-9g; Thu, 02 Jul 2026 16:39:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352212.1609086; Thu, 02 Jul 2026 16:39:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfKRr-0003G6-6i; Thu, 02 Jul 2026 16:39:35 +0000 Received: by outflank-mailman (input) for mailman id 1352212; Thu, 02 Jul 2026 16:39:34 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfKRp-0003G0-U7 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:39:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfKRp-007HlB-At for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 18:39:33 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a469419-bab6-0a2a0a5309dd-0a2a4506b7ca-40 for ; Thu, 02 Jul 2026 18:39:33 +0200 Received: from [40.93.194.58] (helo=SN4PR0501CU005.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a469443-08de-0a2a45060019-285dc23ac512-3 for ; Thu, 02 Jul 2026 18:39:33 +0200 Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by DM4PR03MB6032.namprd03.prod.outlook.com (2603:10b6:5:393::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Thu, 2 Jul 2026 16:39:30 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.21.0181.009; Thu, 2 Jul 2026 16:39:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=irGt1oz+VsHtgk0pilSn2K54dKX8Es2jvlAesgTgaVbkMUP8sgwow2DUD5+3J2t7f9ikJSOUAUpw6+6lS5cu4nEEmhzgNhS6J4hdjIPJ2pDU66QygR7U3SYSaF5GgRnRC1CN7Svx8nq1cOxAeCcOxiSryAdNrqfS3JW2SSGUhWbwj02yNcddjWWXpU0N4ZPM7swRwAVkuDqeo9T++NPJ8ro9JLSi2Azmv8AxVAd/VjJzrvvsXwI24R/PMp5IC1lrNegxwMFbAZGt9DYC4LXFathrVzHSaefsFznVb30n68xcpSr1zayA8QMwL8xJD0NSjqLFBUm17xRcfnA+vQ+Xnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eGR5Lkr/+WrJogcyH2alIWIw2RuHcvnc2gBp24CTNrI=; b=dRbvRyGytqzEs9wZ4z9Ha09XTZ/qbas7kf+aAi1g0Iv7uCjND8HnfcNPavtHvtP9mJuYLuT9krPZ0Xeqmte6LxjXxj/mkxbbU1gMrVg3l1CnchiRnN9LfMOXek0m0CiWpsh0dIymWLgk4oi7m05ss2sMOgIWuu8YzBxNDDKJ3jpmW7vlivM1GXd7nXitqrHBeEGInhgf4e5x+a1CkijOUs/uGDrqOZHUUPcIFod9Jw7XQljX6cZJc0mFBW3J0MfBRn7jzS78KzLYl5AtxjSbHy+jKFXvCm+umH858PewHu9H3SXTFGA+QnNfL9f47xFAeSJu3v9poTir3Y/0zalUGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eGR5Lkr/+WrJogcyH2alIWIw2RuHcvnc2gBp24CTNrI=; b=Gs52EhnqeGx0hf6XYEzeSvDOBHdNOyaoqOWuy3TPivXDbgxxsTSjbmu73YbO/PwjYJzkGorcOwUyGwluD6JrqxaAc1xK0kFLkS2R5UHwvdPNQS8WoyFdcvvprdjBpNL2DQ5jO74W/HRgATQS3lqIGv+5KJ+jGLo5z4tIx+BRzDw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini , Christopher Clark Subject: [PATCH] argo: fall back maintainership into the rest Date: Thu, 2 Jul 2026 18:38:45 +0200 Message-ID: <20260702163845.36453-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.53.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MA3P292CA0022.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250:47::17) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|DM4PR03MB6032:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c0dfa93-bf91-40a0-4249-08ded8587ccf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|23010399003|11063799006|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: zy3ULQqMl5sgjXblwkch4T8D7H0ThUTmTSuEpuOpoS+9gLEvEy86GTXruh+6e1YjgUi721PTginD5AZIXL4VkwH4DMFd0zUVB+MMqX7DCkxnIh+wHB1xozK4kJQff3R4c0A4L93ph6fGo1KOgp1xMngARiryeFYHWC/jSByFZmRDjpxaykrGZLNzHVJKwbsQh1pS7e4f/uX2ZpPzgPAdnih7EHXkgDgPs8N795n9GR5jHcGTktnHclcQE6E193H0ycRBVkpjbBXZaXNvidr39FOp7zJ2uMEY9tfrYaw9or997Vw12Ql5jSlti9lCIMXj7OKoZWlH7nKpUDT1WGgrj+sWU5j2W4KEl5J2iYPg9kDsIbtjUZaoAeI/NW2s4go11gD+MnDLKtjkKw8LF0VjdxhShqT+fU5B0xyH8HYx0sd0kVClVTgUIaFPwCPKYzJag7RPk9X9Lsr6BoHBoixB6422ie+6rHY8zDIvEBuXLObVovkWu9nIErVHbxUx5qeR1EyaWJjqqEZ80dhwIC6vAMF+1PuihXL16kH7dk9P4uj2dCgnBonpalrguOVA7TxL9+jovcFiAb7nB7pU6DZ1UXxKw0F8Sf79bBQzXu7kou/BWboRwRA7j7cWUlyNuTLR5Q8G78CcPPSsBrcnRX+TKnVDlxvCJgt8Poh+O4p8ABc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(23010399003)(11063799006)(56012099006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1BodDJIY0x4YmxCWWdVQ3RaRjdqS21DUWNqNE5yajJDcFVTTk85UW9ZQUo0?= =?utf-8?B?TzlRb0RtbTF3cGlBeVNBdjE5UC9xMDlMbnMwVUJGOHNrOWZ1TWNpNk1WeEJR?= =?utf-8?B?dk13a3BUL3MvWkRyT3dYQ3A5ZTBhVFkzUENlYjJ1WVp3UHZ3bjhrQ2ZXak1Q?= =?utf-8?B?SmRkVm5kWTZHSy9GbW9zZG9VZjVSbnh0QXNIK2trcDl2UGRZNEpCVEFLaDRu?= =?utf-8?B?YXlGSEVQaEFPMUU4QzF6eDYyREpvU2doa2Y2L1l4SlhWWkVMR25zakpPYWVj?= =?utf-8?B?WWV0ekUrbEVXK1hzdlpqbVViS2NiTUZlNDVqU21ETGhJVVQ1czBCK0RzVEc3?= =?utf-8?B?WUFucG9wdmZiNzVWNVpGK3Z0RHdETDVSa1cwamVpN2xZMWFMRkkzcHlnV01j?= =?utf-8?B?M3Urb05jYjRCdkFuRkI5K3djTzNYd0VEVmVXRGgxM3NQT2MxMkRvVXNKRmZQ?= =?utf-8?B?K3kyZXpaajZ4bWMxd1NBRHZEZUorQlBqMUQxZ3VJQ1VxSkJYcXFyOUx4cUhE?= =?utf-8?B?TERyUGVRM0trK3FGUHZ3WVFlNlpMRHdBNVQ1RnhGcnBHT2pqckhRMWpnRisx?= =?utf-8?B?Rk9GKzBpR3RvZEVIdkhGT1ZHQ0h1aDhHTXFHVVBQbjdabTdYYTJBelFNUEcv?= =?utf-8?B?QkVsR2ZTbitaT2kyWTI0MFhtcXU2TStkbHo2VUZjTmE2ZHNsTFNZbEtTbXFM?= =?utf-8?B?N29uaDJTWHhrb0ZJeno5eG5tRHlveXhja0J1aWRTc2NWbkptV2psaXAvaU52?= =?utf-8?B?anZlaU9UZ2ptTnVzWE5STUhlbHJUM2I1UWpJckhxZWIyTnFJNUN4NS9zVE8x?= =?utf-8?B?YmJucFhUWnE3dkY2THdlR3Y2V2ljUnFtMGY2VGlmZnRVMmM5Zm5iVFR1MlZY?= =?utf-8?B?TllDNkhVNGYwUEN5emVGZUpneXB3ajB2RHVUbTB0OTFNWnNKeTZ5YlNaUmZ4?= =?utf-8?B?c3A4U0tsSjhCa2llZ29qV0YvMkhsb25HYmZYSW1LbGlvbzZMcGR2a2s5Zm5K?= =?utf-8?B?UTZ2UUw2azhKanNrMFlHRkQ2eFFoS0VuWElxUjJzTUFEQVkzd0UyVnZOa0xp?= =?utf-8?B?V25EL0JxbUNVMUVMTUg1aFdYTXkrZkZGQUc1clRkMER4clVPYjA1Mk0wWGNS?= =?utf-8?B?cUtwcjZ0WmZVbm9EWk90UWF5OU5QT1JwaS9XM3NwTzdCZTcyVlV4ZWszRUZO?= =?utf-8?B?RXNaa0M5Qi8zUjJ6L2lseWxXdkcyTFZxeDhXVStCM0JjVVFLczFzaUtub0tt?= =?utf-8?B?aUE0a0dVNThWSnF3NmlKcStjWnZaRk5aUG40d0JTd2NuSmg5cFc4R1V5TmJB?= =?utf-8?B?ME1YcTNPTnJGbUlTVTY2TG1ST2RjNzh1SGdkcS9HS2dMcWlyWmJyVE9NQkFn?= =?utf-8?B?by9MWkJQMkJ3SGVrSWhtZ2pOQ2M5N2Q1VEtaRGNpdTVxR1dSODFMcWNzL1Av?= =?utf-8?B?djdscWlHYXEweWFaYkx2cUM3ZGNxWjQ0Q01JNXZpN3lnVDdUQUM3L3NRdXRJ?= =?utf-8?B?TElRS3pURiswMFZrc3owaThqalIwakpwNmdTOTJkT1pGSjZXdk8xcDQ4ZHhH?= =?utf-8?B?d3YvRkdTMjQ0b0c0VW5iUFdCMGo0aUhyMmNmMFNITmJzNDB2ZFhwaVNjdkU1?= =?utf-8?B?SWdQYjdCQThaUHN3SUp6Zkd6UGZjWVU4TVVlZndYOStaVHgyZ25ZdmZoZlhL?= =?utf-8?B?c0dxUjhzTW9qbndDQnlmRUFsK0RaNGJDdy9mQzBqQTAyUU83Q0VKRVJVdXJm?= =?utf-8?B?RFByZzZQdElhbUVrOUdhb1dBbk94UWVVMEpvQTVjQzU3clRuaUxsK3hOeG5l?= =?utf-8?B?WXNQSlV0eFF6N3ZYWk42OGY1Q25zTXVncDdob1dhU3pMSmlTWitIM2wwVndi?= =?utf-8?B?Z0Zaak43SVlNcHdXbXFZWUFwbmQ3dyttc2ZWazFNaERrQ2NFRTU5VEtVUHVY?= =?utf-8?B?a0ZtaU11aTRRL1U4L25YQUhUUUN4S3pPSzdDb3g2QkdHWFkzakFHVDFRaTln?= =?utf-8?B?TktsSy9oaEloYVJHek9WcEFZMkJRMGxiYm1aYUlJU1JnWlNteWkxdXI0VWFT?= =?utf-8?B?Tm5yMDJrK3RRZjhqbnBjbEN1L1lxR1RBbzVqT0oxQW03MnFZNVBSbkljZWti?= =?utf-8?B?a2pSMjBLa0M2RHMrU0p3YUZ3T0puYVBnUjZOSUZneGE1dkJRRE84MWpRRXRT?= =?utf-8?B?eFdDdEtHMDI3akdRdmFBdHU0VUZjNzVQRklMUWhHTFM3aklvdWkwVGdpekZF?= =?utf-8?B?V2UrckxKaDl6eGhJWVJTMnBLTzhKNXpCUEpmRlZHVzIveDI4UU5jNnkrNENM?= =?utf-8?B?RVRiaG04TmQyMmNQQVJ2MmlndnN6UVVMQXJ4QUU0bkFycVcxdytjZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c0dfa93-bf91-40a0-4249-08ded8587ccf X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2026 16:39:29.7670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y8xNlq3beIsYp95l/g32QwU0+VNy3Elt3Ur2eGqYwGMyyjWqPHG5vidc5cIIVyy7zzRl/4ZNZdzSPRh6u1gn1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6032 X-purgate-ID: tlsNG-16d1c6/1783010373-F87E668D-0520EC45/0/0 X-purgate-type: clean X-purgate-size: 864 Due to unresponsiveness of the current maintainer. In particular, the committers have been trying to get in touch with Christopher for 2 weeks to have a chat about disputes around recent commits and pending changes to the ARGO component without getting any response. Signed-of-by: Roger Pau Monné --- This patch is on behalf of the committers, and not a personal decision of its author. --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 81bd0dfeec30..6b2e391441d5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -241,7 +241,6 @@ F: xen/arch/x86/hvm/svm/ F: xen/arch/x86/include/asm/hvm/svm/ ARGO -M: Christopher Clark R: Daniel P. Smith S: Maintained F: xen/include/public/argo.h -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 16:43:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 16:43:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352223.1609094 (Exim 4.92) (envelope-from ) id 1wfKVg-0004nP-Oo; Thu, 02 Jul 2026 16:43:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352223.1609094; Thu, 02 Jul 2026 16:43:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfKVg-0004nI-Le; Thu, 02 Jul 2026 16:43:32 +0000 Received: by outflank-mailman (input) for mailman id 1352223; Thu, 02 Jul 2026 16:43:32 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfKVg-0004nC-9l for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 16:43:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfKVe-007IVn-3g for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 18:43:30 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a469527-e002-0a2a0a5209dd-0a2a4506dca0-12 for ; Thu, 02 Jul 2026 18:43:30 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a469530-08de-0a2a45060019-aceafc1fc7b8-3 for ; Thu, 02 Jul 2026 18:43:29 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id CA008416F6; Thu, 2 Jul 2026 16:43:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E1C81F00A3A; Thu, 2 Jul 2026 16:43:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783010607; bh=6PcFLEoyRJf8kxb2GS0a34t6Sr+st1IFRARKd9dpAAI=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=Yaja7h2ajlb9QYXmFh17BV3Z6ClPfSTvrHGPGerzwUxl0BUsJoAdLmpiPXhOKqj/a fraFqB1Yh3B0eEn6W8iFq+CUSfXr+IPowxp8Lx+R9UEnfgonzQpCMMRYSI5XXQuOIz 3QGc46OXEtUfo+UXwis1ZKW94kUWkHCYWI80jnJEGTMKP4m4VoRF4C4cFRFO73hIjy eVR1gcm01Qd2GkElP62O0ObjQEz5RBu6VRyMZAxoJl25gfbnHNFUdeJSo1Sdpltld+ o8XnfGK9kNTIUKPeUZ6Fa7TJO9+g3nNYK+EsiKyLFLCHjk78ISoYjbCfIUPcRxFRqu c4iJfnhS5yl7A== Date: Thu, 2 Jul 2026 09:43:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Roger Pau Monne cc: xen-devel@lists.xenproject.org, Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini , Christopher Clark Subject: Re: [PATCH] argo: fall back maintainership into the rest In-Reply-To: <20260702163845.36453-1-roger.pau@citrix.com> Message-ID: References: <20260702163845.36453-1-roger.pau@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1768402433-1783010586=:992629" Content-ID: X-purgate-ID: tlsNG-16d1c6/1783010610-C513768D-6D1CAD3A/0/0 X-purgate-type: clean X-purgate-size: 1423 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1768402433-1783010586=:992629 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 2 Jul 2026, Roger Pau Monne wrote: > Due to unresponsiveness of the current maintainer. In particular, the > committers have been trying to get in touch with Christopher for 2 weeks to > have a chat about disputes around recent commits and pending changes to the > ARGO component without getting any response. > > Signed-of-by: Roger Pau Monné Acked-by: Stefano Stabellini > --- > This patch is on behalf of the committers, and not a personal decision of > its author. > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 81bd0dfeec30..6b2e391441d5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -241,7 +241,6 @@ F: xen/arch/x86/hvm/svm/ > F: xen/arch/x86/include/asm/hvm/svm/ > > ARGO > -M: Christopher Clark > R: Daniel P. Smith > S: Maintained > F: xen/include/public/argo.h > -- > 2.53.0 > --8323329-1768402433-1783010586=:992629-- From xen-devel-bounces@lists.xenproject.org Thu Jul 02 17:47:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 17:47:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352279.1609104 (Exim 4.92) (envelope-from ) id 1wfLVf-0006Nk-As; Thu, 02 Jul 2026 17:47:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352279.1609104; Thu, 02 Jul 2026 17:47:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLVf-0006Nd-7A; Thu, 02 Jul 2026 17:47:35 +0000 Received: by outflank-mailman (input) for mailman id 1352279; Thu, 02 Jul 2026 17:47:33 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLVd-0006NX-Iy for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:47:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfLVc-00EjrA-F0 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 19:47:32 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46a428-2eae-0a2a0a5409dd-0a2a4501ec4c-14 for ; Thu, 02 Jul 2026 19:47:32 +0200 Received: from [52.103.1.13] (helo=BL2PR02CU003.outbound.protection.outlook.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46a433-400f-0a2a45010019-3467010d4978-3 for ; Thu, 02 Jul 2026 19:47:32 +0200 Received: from SN6PR02MB4157.namprd02.prod.outlook.com (2603:10b6:805:33::23) by LV8PR02MB10144.namprd02.prod.outlook.com (2603:10b6:408:18f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 2 Jul 2026 17:47:27 +0000 Received: from SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6]) by SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6%3]) with mapi id 15.21.0181.008; Thu, 2 Jul 2026 17:47:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=outlook.com header.i="@outlook.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gSn+/upNAJrnk7n/jLvrZH8A+EKxHEVv0SWT6UOtd9kvD6EaN+j9XA8qzA9NcTWd5yFp2p9ECeFXgA7HBIHPcw6Fl6D25Ipk5RFh/kQ3IX5XeweUHyDWJrjhHTy0tQvt3UxBVLNz4InTPH6ItWdzu9j1jMv9/dLRYuT+pkqUwe7cZaslp22Ujk5L0cRmWOpJDf5OYlTjKPedjPMwiA1+IZS399PlGh/dBe5voUyGlt8n1jvZwtKQeM6XX45eLLeT0XppqYSLu2Ubt/ORXn5bCqJN6Ze6tBFJZkSSMWJRaJbRMEwkl8ldAlefUzgDi/6sDFBxaqbDQOYGMw9tY6Ae2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/U4V13hwZGhvpkdmcDFMNobqvgip4Nea0yy3TPSYIXU=; b=ksEr7f9RhHMeKiJztHTt4Y6jklvB5/rXs8sziM4stDKlmB4ySXgMdxggyThAhYwyX9ZbdV4+2JfHpRlTSoK8Fpe0ocdC/AStfO0HoXzbssmd3y0vV5zX33GLFA8pRki1V1u0wmmLkvJC4wPGLnk1xML7Ihv7sNyeHX/dPvnfXC6kZfAVeQcw9vfFrPjX0rqK3CsCuQ9qb4hQocQ5il3hKKle4VE//Lb4Iq5LsARUzLUzYVf+/f7IzZZH1jNC3GGcCc1iUcBicyYKy76M8vHIWrNxGvWK3TQ/VaBKFIs52aLGrCYqtfm3NcZd/3wCP6ZCLWmSy+K9PExc2z+C8HauvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/U4V13hwZGhvpkdmcDFMNobqvgip4Nea0yy3TPSYIXU=; b=XH98sYS0dJjEqeyiWejkonzIYf66AGNfD4NPxx/eqqaEHr7NWC4itSdhkjxXiBywUEn0Qe55cYBg4VpBNR/xeqvZh6eY9kPWpmYkRJar++K8FkExWLHgf+UyA+rKb2L7AifOJApZhEfOp9erpb9vgD2ndpdC/D3BSp3cU4pfJBk3lUH22OaLMOprrkUHadg0BRHnNiaGyDNPRx6YILngX/K3fmLpuUYFB8Bl6Bc7ytnED0V/sF//aayztm0DuYk8x0SI35V2lisJXIiO+3hkUb3mguv2Jkd+jPfR05lqYDmHCqDtNS5i7dGRX28olPBb/RmCTcpZHye0EbX40M8Ynw== From: Michael Kelley To: Sean Christopherson , Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Kiryl Shutsemau , Rick Edgecombe , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz CC: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , "linux-doc@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "virtualization@lists.linux.dev" , "xen-devel@lists.xenproject.org" , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Subject: RE: [PATCH v5 01/51] x86/apic: Provide helpers to set local APIC timer period in hz and khz Thread-Topic: [PATCH v5 01/51] x86/apic: Provide helpers to set local APIC timer period in hz and khz Thread-Index: AQHdCZBe6TYzIJYr/E2B6pv9f83kWbZago1g Date: Thu, 2 Jul 2026 17:47:26 +0000 Message-ID: References: <20260701193212.749551-1-seanjc@google.com> <20260701193212.749551-2-seanjc@google.com> In-Reply-To: <20260701193212.749551-2-seanjc@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR02MB4157:EE_|LV8PR02MB10144:EE_ x-ms-office365-filtering-correlation-id: 8a00adf4-ed81-48ed-ddee-08ded861fb20 x-ms-exchange-slblob-mailprops: LVbdfIC7uFA0GyAFqbKW0EprdbA2EYzU3cYeZ/aYpf+3yv7G/lcFWJP9wfJT3Dq57DaLrgkhDqJ2vgZCqdiCRIJ19cEqRknj6rpg6LHTipbc4xDgvVAkJ8HKHGisnQwrh3KvL4zs26qbcKpMP9PjggGt2NV4XStGOEFDzZuNamyyBijUY+O7kKWznDLctv6dGUJXR4NBNsKsJUY7N2vt10LLefGC9qN9cC2/UsL/bBxU8rZjEArpONcppmF3c2V/uk27/RNe93WaOuvv0wXt+voNWk2fMqJ89ZvY7G4Yh/9VnPWzTR7e9AjiNZ6HnHZxdP+u1TCNBr/vGZ6Pfed/9A0LiwHIYgyD1ilbMGRGWmtSzT6qT1hE67GhS0/oXAv7XzLZwWI1n8VcHyKN19cB6Oc8DOVow5S7UuyPVNVxUTi6Kw4K04uxMsIApYi/GyVe5CZHXr2/o3Zhd7Q/FRmsKxyvAJTWdNxp2DivvOWFDkEtZ8viIGlhlyv1xMdl5Lv5luNC0xY1DWkW13GycTnlpIsJ5TevNY59u7MSGsT6qd7u77vZJNoxFk6wQw3z1cmUl+jPLSkbN4lxBbdYMk3Bc8y3um2qgvxk4WTElrTHSFTgWrvrh7zYZHuuGgFgiz04mR6ktfwTSA1KzE+WVb9QfYuV9KAeRyFpV27GVESCgPGw3DNNOVc/bsNMnFHgsyBmqd8+VfZggKVWXHxam/DEEffBEM1eyje8k8Vo39sGtftt5ST9xz86sg== x-microsoft-antispam: BCL:0;ARA:14566002|51005399006|19101099003|37011999003|13091999003|8060799015|8062599012|31061999003|41001999006|19110799012|25010399006|15080799012|4140399003|40105399003|102099032|440099028|3412199025|1710799026; x-microsoft-antispam-message-info: =?us-ascii?Q?peMOuPd68er2iuBIlvPe1FpE3avD7jemrANNs0NhGvaJrfYlTxTbu/H8uXg1?= =?us-ascii?Q?NNrfa6Nrk4M6KpZyLgYBu656L2r5Ifgi0ei28OgUHTdRDWqxloSru/zKPRgK?= =?us-ascii?Q?xH2WOrWQ/HjQGtczFrSdGvogN+IeGusA/TQL74aBMwzgzJViWITZrxoYIBHp?= =?us-ascii?Q?n7sYMT2VJMOBzuA0TzVyChWb4cSvztuv/m0/vIkopp1DVb9Oa101dTN4ItgH?= =?us-ascii?Q?AgtUg94Cqv6+o0iRpjq4XrNwFL/YPWmweB+Ae2zJKMpgO0ATCmhXRXaXXDVA?= =?us-ascii?Q?0/FwYpN+dOgN0BALPK3IWub4IxVI36N9hb4QhRdEHVxUdxSmGVozr4g5cYFI?= =?us-ascii?Q?2OBf3lruU8SZiSn1V7pF7NgMLGpj4jAQhx7m8qwUIshkR1/TPBsvRzZsKmQ2?= =?us-ascii?Q?oC9ht8w4Nib6hOWl07bSTetcV0swX8j1FIYlthKdgUeqGQ7uoiYINrRRDRXl?= =?us-ascii?Q?ESeS276omrEdz2lJAYXbFErxU/G0leXrOGHVXNci2i4DVaF7IznaUqpxbcuw?= =?us-ascii?Q?jCXsf416h/u0jWGSAh7ckYczBoT9VqlSv9AVHULbapWveKirnSZtsGbpvPGQ?= =?us-ascii?Q?7GdClRCaEYfcgdBZpDyMx5w9qLx7s2pKjvPtCzd8ksr/h3SOXk5F06XqDkKT?= =?us-ascii?Q?OjoL4nBw6b9l8ZelwJX7e2aYGxbvHvhScxG9UOYcA8X7TFaw7LlfZBfEz+iH?= =?us-ascii?Q?6SuFJ/Iw7fkMXganMFObKMyY1wdDrKxFGXuBTpUbWFSM00c10MJ92LZjeIHI?= =?us-ascii?Q?/ty0LiP+ZhFerfWVwyq3SJxev1xyvU3pTIb7xUUT+AujbPhJ8mbZjDKjc1hP?= =?us-ascii?Q?brBYZHZj1cKoawpkh+U9DuFWb4eXZAww6rRsv+vY3DN5iFv4yT5apCxxmnWq?= =?us-ascii?Q?ypgMQk3FLlnJpWJMLfHOpunIwzTGHAxMIKoyGOrPORkVMN2jchdYZD+PjjOx?= =?us-ascii?Q?9KeC6X7TN+Annkybz9T1cgzhKyRcULulACNvcI36AE+Os8/F1IgYgvvg/wtm?= =?us-ascii?Q?LI9Gtpgy8dR+dE36bXPvdS1K2QTWpUXyHE2j9kj/GlU2R+t7QWKcTXGiZwxQ?= =?us-ascii?Q?XKHnKTWZ?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XV/LB4nUK5W2uqNGw2+DJZYQaEYI1lVpWtyir20MVFp+xOnXOezB9mOnwfWt?= =?us-ascii?Q?eWv0WvajOIgLD6OWDKzqH1wyM4TD2DKNplWEVIlyk6vBRwXJTSJ5ZLx2g6tE?= =?us-ascii?Q?7gZQgUEFkgw/vSfr2Eq+xxztw3cfYnmWoDZNjQJJPfqhVborUWcB5mR/YrdI?= =?us-ascii?Q?9drt1+O1mN+gyQ52LgX1hpTGDXOjPeqYEhccT7nb+7srQhPFqRn1T9z+JSis?= =?us-ascii?Q?88ieDllzG7Yiklw7mPQOyhCxK90doRezcj4OxaKAj8uhDaS9phWPjFLDUMG+?= =?us-ascii?Q?PCPnlaKRZ5/xPBjpMwIG+G+IcCBRgL+JLeQjXfvXHQ3H21FWSV9fcB3uJn2l?= =?us-ascii?Q?gEMUXKv111C9ojwhYQLfJZF4hkHmLaUui6g9JWx0iRz9dw1QIHREvGt+IeNp?= =?us-ascii?Q?YS6SYyl9MoH1ZOyuiGn+AdRSmZKx7gHi/oYZWDS+MMAQItV+S1cx+WPeoEsP?= =?us-ascii?Q?ldc/lhmdQaiCicDXLgpoVRjP66YYK2o+D4BLw1N7e0pY9hDcZF8+KaOU/npQ?= =?us-ascii?Q?MeG8T5BTVnyUaVjsc1fPx7ABGTGqKdKl7pRCUsA901eps7DVeaBnp7Ahoks4?= =?us-ascii?Q?l36F9Ie2GkYSmb8M62m7RxRdbw27U5BgGMCxYBnIpSwB0vKo56guMScsYyUz?= =?us-ascii?Q?d4ovntZA6Z3cfJBUZmqYWfKMeEzy1snPAi3jrrOskQZlu7aMQwVRX2NlXkNe?= =?us-ascii?Q?vXpEn/JYCzCGquVScbVa6NF700q0M2JyRWeP/PhUcie0PF5IDqCEkuasqaGG?= =?us-ascii?Q?9erURcOyzC3kKABockUZ+kGOsNVbcTIfKuQBU+3wH8xmkJLnh/U8GyL0YE0I?= =?us-ascii?Q?NSTgOSmS3XZAPvl7EaZQ6TZPJpgwfeuUHFyHh191N3Q7WstfAavl1HNRMnLi?= =?us-ascii?Q?d/Mv9SXiLTj05T+r0wGUrmkfGMfKydAihTjnjVvg+stkKGXjtICWoXfstcjb?= =?us-ascii?Q?0OLVT86x3pYU1vnFvlWNcuZM1/IfeIM9jCf1ZU11tIcZxCSpt0jrqA7+W9uo?= =?us-ascii?Q?SACY/ntosJF5kBkzp4JTg0rRQ1gkP1uJyPZ9trEpTU+UaU/bdInhb9nzw7gM?= =?us-ascii?Q?IvtFftmHn7l93SwkoNxwjTdXq/2bQa5cIwZEa3+0sSy0h398dxGZj7mnn9Dx?= =?us-ascii?Q?wX0uPOOTiug0q1vxgiqJpxMifqAiQpumi4zxOL2CbXvTIM9X6kLYJjdNhYsq?= =?us-ascii?Q?Hwv4Y1lTm6yKVRxy1UTNXO+Abzi/ncw3W+Y+PQya61q31wYkfUTDFldt3PM6?= =?us-ascii?Q?mpiXiUoKglCX8ELQG4hB5bih5q/yIYZq56Ca7ZNV7apWBsEQdEYOIlH/teek?= =?us-ascii?Q?FpIHE/zM5n3uunuYobC47I2CJp/+50Q5xUBK727khNabUOZ0Cyr42AtbyQC8?= =?us-ascii?Q?jbTSbIU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8a00adf4-ed81-48ed-ddee-08ded861fb20 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2026 17:47:26.9688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR02MB10144 X-purgate-ID: tlsNG-d62444/1783014452-D26C61E0-A8379AE9/0/0 X-purgate-type: clean X-purgate-size: 6457 From: Sean Christopherson Sent: Wednesday, July 1, 2026= 12:31 PM >=20 > Add and use APIs to set the local APIC timer period instead of open codin= g > the subtle HZ math in a all external callers, and make lapic_timer_period Spurious word "a". > local to apic.c. Provide APIs to specify the frequency in both hertz and > kilohertz so that Hyper-V and VMware code aren't forced to lose precision= . >=20 > Opportunistically use mul_u64_u32_div() to harden against the possibility > that the period in Khz is greater than 4294967, i.e. if the APIC timer ru= ns > at ~4.29 GHz. As pointed out by Sashiko, 4294968 * 1000 =3D=3D 0x1_00000= 2c0, > and thus a Khz period of 4294968 would silently overflow the 32-bit > unsigned integer used by most callers. >=20 > Signed-off-by: Sean Christopherson > --- > arch/x86/include/asm/apic.h | 3 ++- > arch/x86/kernel/apic/apic.c | 12 +++++++++++- > arch/x86/kernel/cpu/mshyperv.c | 5 +---- > arch/x86/kernel/cpu/vmware.c | 4 +--- > arch/x86/kernel/jailhouse.c | 2 +- > arch/x86/kernel/tsc.c | 2 +- > arch/x86/kernel/tsc_msr.c | 2 +- > 7 files changed, 18 insertions(+), 12 deletions(-) >=20 > diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h > index 9cd493d467d4..cd84a94688a2 100644 > --- a/arch/x86/include/asm/apic.h > +++ b/arch/x86/include/asm/apic.h > @@ -63,7 +63,6 @@ extern int apic_verbosity; > extern int local_apic_timer_c2_ok; >=20 > extern bool apic_is_disabled; > -extern unsigned int lapic_timer_period; >=20 > extern enum apic_intr_mode_id apic_intr_mode; > enum apic_intr_mode_id { > @@ -138,6 +137,8 @@ void register_lapic_address(unsigned long address); > extern void setup_boot_APIC_clock(void); > extern void setup_secondary_APIC_clock(void); > extern void lapic_update_tsc_freq(void); > +extern void apic_set_timer_period_hz(u64 period_hz, const char *source); > +extern void apic_set_timer_period_khz(u64 period_khz, const char *source= ); >=20 > #ifdef CONFIG_X86_64 > static inline bool apic_force_enable(unsigned long addr) > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c > index aa1e19979aa8..8d3d930576fd 100644 > --- a/arch/x86/kernel/apic/apic.c > +++ b/arch/x86/kernel/apic/apic.c > @@ -176,7 +176,7 @@ static struct resource lapic_resource =3D { > }; >=20 > /* Measured in ticks per HZ. */ > -unsigned int lapic_timer_period =3D 0; > +static unsigned int lapic_timer_period; >=20 > static void apic_pm_activate(void); >=20 > @@ -796,6 +796,16 @@ bool __init apic_needs_pit(void) > return lapic_timer_period =3D=3D 0; > } >=20 > +void apic_set_timer_period_khz(u64 period_khz, const char *source) > +{ > + lapic_timer_period =3D mul_u64_u32_div(period_khz, 1000, HZ); > +} > + > +void apic_set_timer_period_hz(u64 period_hz, const char *source) > +{ > + lapic_timer_period =3D div_u64(period_hz, HZ); > +} A string "source" argument is passed in, but not used. Is there an envisioned future use? Also, this function doesn't output a pr_info() message like the existing Hyper-V and VMware code does. I don't know that the message is all that useful, though I do remember one case where I was debugging some clock/timer issue when I looked at it.=20 Michael > + > static int __init calibrate_APIC_clock(void) > { > struct clock_event_device *levt =3D this_cpu_ptr(&lapic_events); > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyper= v.c > index 185d4f677ec0..87beecec76f0 100644 > --- a/arch/x86/kernel/cpu/mshyperv.c > +++ b/arch/x86/kernel/cpu/mshyperv.c > @@ -646,10 +646,7 @@ static void __init ms_hyperv_init_platform(void) > u64 hv_lapic_frequency; >=20 > rdmsrq(HV_X64_MSR_APIC_FREQUENCY, hv_lapic_frequency); > - hv_lapic_frequency =3D div_u64(hv_lapic_frequency, HZ); > - lapic_timer_period =3D hv_lapic_frequency; > - pr_info("Hyper-V: LAPIC Timer Frequency: %#x\n", > - lapic_timer_period); > + apic_set_timer_period_hz(hv_lapic_frequency, "Hyper-V hypervisor"); > } >=20 > register_nmi_handler(NMI_UNKNOWN, hv_nmi_unknown, NMI_FLAG_FIRST, > diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c > index 34b73573b108..36f779dd311d 100644 > --- a/arch/x86/kernel/cpu/vmware.c > +++ b/arch/x86/kernel/cpu/vmware.c > @@ -424,9 +424,7 @@ static void __init vmware_platform_setup(void) >=20 > #ifdef CONFIG_X86_LOCAL_APIC > /* Skip lapic calibration since we know the bus frequency. */ > - lapic_timer_period =3D ecx / HZ; > - pr_info("Host bus clock speed read from hypervisor : %u Hz\n", > - ecx); > + apic_set_timer_period_hz(ecx, "VMware hypervisor"); > #endif > } else { > pr_warn("Failed to get TSC freq from the hypervisor\n"); > diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c > index f58ce9220e0f..f2d4ef89c085 100644 > --- a/arch/x86/kernel/jailhouse.c > +++ b/arch/x86/kernel/jailhouse.c > @@ -65,7 +65,7 @@ static void jailhouse_get_wallclock(struct timespec64 *= now) >=20 > static void __init jailhouse_timer_init(void) > { > - lapic_timer_period =3D setup_data.v1.apic_khz * (1000 / HZ); > + apic_set_timer_period_khz(setup_data.v1.apic_khz, "Jailhouse hypervisor= "); > } >=20 > static unsigned long jailhouse_get_tsc(void) > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > index ce10ae4b298b..f9ecc9256863 100644 > --- a/arch/x86/kernel/tsc.c > +++ b/arch/x86/kernel/tsc.c > @@ -717,7 +717,7 @@ unsigned long native_calibrate_tsc(void) > * lapic_timer_period here to avoid having to calibrate the APIC > * timer later. > */ > - lapic_timer_period =3D crystal_khz * 1000 / HZ; > + apic_set_timer_period_khz(crystal_khz, "CPUID 0x15/0x16"); > #endif >=20 > return crystal_khz * ebx_numerator / eax_denominator; > diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c > index 48e6cc1cb017..7e990871e041 100644 > --- a/arch/x86/kernel/tsc_msr.c > +++ b/arch/x86/kernel/tsc_msr.c > @@ -211,7 +211,7 @@ unsigned long cpu_khz_from_msr(void) > pr_err("Error MSR_FSB_FREQ index %d is unknown\n", index); >=20 > #ifdef CONFIG_X86_LOCAL_APIC > - lapic_timer_period =3D (freq * 1000) / HZ; > + apic_set_timer_period_khz(freq, "MSR_FSB_FREQ"); > #endif >=20 > /* > -- > 2.55.0.rc0.799.gd6f94ed593-goog >=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 17:47:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 17:47:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352281.1609113 (Exim 4.92) (envelope-from ) id 1wfLVy-0006hz-MV; Thu, 02 Jul 2026 17:47:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352281.1609113; Thu, 02 Jul 2026 17:47:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLVy-0006hs-Jb; Thu, 02 Jul 2026 17:47:54 +0000 Received: by outflank-mailman (input) for mailman id 1352281; Thu, 02 Jul 2026 17:47:52 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLVw-0006fA-N5 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:47:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfLVt-007SXW-D1 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 19:47:49 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46a439-5cb7-0a2a0a5109dd-0a2a450cc90c-22 for ; Thu, 02 Jul 2026 19:47:49 +0200 Received: from [52.103.23.25] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46a443-f399-0a2a450c0019-346717197778-3 for ; Thu, 02 Jul 2026 19:47:49 +0200 Received: from SN6PR02MB4157.namprd02.prod.outlook.com (2603:10b6:805:33::23) by LV8PR02MB10144.namprd02.prod.outlook.com (2603:10b6:408:18f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 2 Jul 2026 17:47:41 +0000 Received: from SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6]) by SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6%3]) with mapi id 15.21.0181.008; Thu, 2 Jul 2026 17:47:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=outlook.com header.i="@outlook.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LaxK4zXuiGCXZXF456keOKJXgW709FOg6P3jbzDmJXAoEM0vaxEAZnhN64nKumuMpGuJeIP4zR5n8FLKSKbpaX1IGuxLwzDI49e1ysNEWND7ojP9M04ogcMuDjYYPE3azbE+IBOA53CvuxwceFTiKzFkYpU0sE6s70ln16UJ/WwgpAQQAF4A6RfWuRVYGbldWNWRi3XjmPRUUS1iPNJR4yUNgQDKcKXJbe6r3zsc4XFgfruBap07izS0ikqUuLE7Rk+rxEXK6gkudrUK9kZu5WBR0EnXwuCy9fNjFuwt0YJJpDs0eLvzyUtomKJ8+mxm6tjDYUNjzgKl9xYhqJJzdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZWmMUitMLSZDRRLFU2IMOWfB8yb8tq9o5kiAKU/+UXc=; b=yOD/YrqEiEz/nNbQeXBvGd9DHcr+X0whRvpC8KqNqeGP3JPXGdPbFBRpjW6kKc67LSMDDkyM2QzQmqUa0uuo3uIjow1giLQc8GJ+yy429RQjGxmB1+x+V8rHkWndEAdHd6uqKmbLlkd/mCtWpCPsdwDtlxLPlaJ/4Aqqi1x1hjhxCvYN4vDo0JnD9I0yxhs5w61seDfvlBKaMrP8r6h1R9Z1gF82SW+d6eKEZnP41rf/LngRTsVzfnJcFJzN9nosDGpqlxVqbaQJ5Lgey8tWkaaI5fstbYfwcLNVadTbGDY1wciW2wr39YSPduZFDsisgmpDsd/eph8AWDb7UUuAwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZWmMUitMLSZDRRLFU2IMOWfB8yb8tq9o5kiAKU/+UXc=; b=b95GXywtL9sHqekRWnl7on4Jdi3+jwz7xFCYUrW/+CR3REAEJ1DtGX/Z3tq0r6il+kJXOqYI/9AT57BkkWg62ka1poRGMFFXcEWRJ/cIuOK3SmBFdDdb/172WuNObQ3RMwpa5+atmEUHylmE/wrPHHNeKk51aKP6adF77WuilH0FNmQ9qIY9Q+5EqWolqkQzOjD4GrTRYaqurR4D2aZ7F97w6lVFkYFH18NfLiOE0RX8nY5N2T+wy9k6i8SDa+MuwbeF0YmyWnIchGvHKBI5imfuL1AAU4RSw6Um9cu/y7iNReIpUqd1Mk0t7B7Wc+lVOVHqLhnUCgaMaxxIU0+hnw== From: Michael Kelley To: Sean Christopherson , Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Kiryl Shutsemau , Rick Edgecombe , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz CC: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , "linux-doc@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "virtualization@lists.linux.dev" , "xen-devel@lists.xenproject.org" , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Subject: RE: [PATCH v5 11/51] x86/tsc: Add dedicated hypervisor hooks for getting known TSC/CPU frequencies Thread-Topic: [PATCH v5 11/51] x86/tsc: Add dedicated hypervisor hooks for getting known TSC/CPU frequencies Thread-Index: AQHdCZBiL1rak39MDUu25HviYbt1I7Zagp+Q Date: Thu, 2 Jul 2026 17:47:41 +0000 Message-ID: References: <20260701193212.749551-1-seanjc@google.com> <20260701193212.749551-12-seanjc@google.com> In-Reply-To: <20260701193212.749551-12-seanjc@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR02MB4157:EE_|LV8PR02MB10144:EE_ x-ms-office365-filtering-correlation-id: 608bedcf-0f7f-4e6a-a182-08ded86203c3 x-ms-exchange-slblob-mailprops: qdrM8TqeFBvhuFgLLe5qs4jWk9CHdv0ADgXhcmcD8O8NksmzWPYmQHlsojLAIeNVDHf3Hw8hrqAX1b7rewvdJkeLwglK1GqPSN+rhPZdyuNmalCV3p4r2isH8zBwRkZ/vUdAfUanUSF+uFm8IadQVbbnjn37buSKUrlNlyN8yOtMpzsTjhUiRaz3yRzTM9WOCE01L2M4nRD3JoOKUCQTqgsQNk5Byr/zbzhFjLryElOFQ/qaIj5RQarCkr0YoBTjWGOvBQfZMP03+BJF91BLDXcfJn3dfATMLoztSSmDufasc5VMapOQPQzXlPmnBSpeB2FE0iNU4uJPETFWCmQKO6dvWOcmAW6zYTIkN4PUv7t6k4SRSE6yxI/G6tzRdrYB+FS6ZY62ZDXbF7Au7OWlI7KoL7+G6W9vULkG0i3Ji414oLjAD1vSuIeHV071vj3gMjVY8oQBJT3kMqMxduHSRkmh4fVe0/79QNc/56hR0vWaNEYGA1CC6ALvO85kWYWuyZQqQfgKX8fK1358qHPPkEMGhIWF2By4r77iOREeioHRmh0caUE3Su59L7BH/qwE0CSFggwlB7rJp2XznOlmGx7V9BMNXHVYAaY3OvfWXQnGEy+n1UWlES0O1s2W5ucQLvbrYcOnb9mf9xhnSk7/1a0eEvQkSlx00oTwGZsWHv3Y1xbnHF+/kto9cyq8Cm1i24Ja4TnCVVVBdd8vtYcDyEy1twvtzPIFbXdlvs7o4pu5bH+O2+Pl3Db2Dgl7puY4sGY/WXAJNy4vhUnKfLnIi3KdTisQ6+58 x-microsoft-antispam: BCL:0;ARA:14566002|51005399006|19101099003|2604032031799003|37011999003|13091999003|8060799015|8062599012|31061999003|41001999006|19110799012|25010399006|15080799012|40105399003|102099032|440099028|3412199025|1710799026; x-microsoft-antispam-message-info: =?us-ascii?Q?FjWRO8cQB0yTmG+KMmGFW0HenY9BSv4KQcfNr5+mYzBHqLcrBBlL7GNbiwZJ?= =?us-ascii?Q?24+az0axRiGnRTxFV5jVbWO3BYUpU4hWE/v6k1suyumA2SlZwd2o7VWUiWxa?= =?us-ascii?Q?V1ZTqjV9GZplqdZ5op/nmZBSVvKWtZNIh0pbAFiz4tRHaqx1b57/MHFY+RwV?= =?us-ascii?Q?WINkUqZxmdO9S1woT1tem0Vawl8fpKnzf7h1O8mVUbQ3K6qfVgIRdhZTc7lh?= =?us-ascii?Q?bz4kXPy5dvR6sPlBAKwZb/qengrtkWb73A0fmy+23k13nfdCh9GkbLJMU4Fw?= =?us-ascii?Q?eRpNp1vxM/EhdY2R5p5OTEQ0gKVD67iXuoTpNJDFp9pvsmwvx8dIWIIlEBlw?= =?us-ascii?Q?VFn6lPIWG/qmjzWUfgt6monNfOT0E6BTCRpZnlCmx+ZReCi1OQQNjJjFDRO9?= =?us-ascii?Q?DmVbGFWItMWY2Y9vcsE3XLRuK9GwCIB+Eu9LM3VG5J8Rqpc/aP/o95rCjfPs?= =?us-ascii?Q?n1gqxf571zRYL6A5Uq/TV3KlrF8Rp3WuBc3ELr7q1uk2M6SVva6mM0jNTs8r?= =?us-ascii?Q?iRwjo1c+RuS3H54WuKEDGMNMnL8ObgSuPru9djvA98F2kUduIYp5jl29i18H?= =?us-ascii?Q?qpjh5U1cJXAYMCd6SRA8EtABntKyQpinQY8AhP9RJeiC7nySNYrdb6pE1ZqR?= =?us-ascii?Q?EhxSahKr74ORyhPprUWJ0+92cRAON4Lsnx61P/VyYlqYCgp2s/9q3Yayd42H?= =?us-ascii?Q?Ero4Du+DBs2BWVOcCoNW6WYdE2ZKjs/ytvq2hWFgoW/oBNidl+n9uahh+/e6?= =?us-ascii?Q?aOGo47OYj9398v6zJg+cfJI9pQeZKUU8t2aOxxLbPMfPm6x9/Gmj5+8Fy8g1?= =?us-ascii?Q?16LLWxK8bUq3eC94HiljtZif7PNdNuZqRG0JiF1JRBMVuLITqEA5RPmSbWZx?= =?us-ascii?Q?/5rOZtiahJyPQupfk6jR//GWYgvUipsfE6t9qwi86tIvL4cKQwtGj0nrGibG?= =?us-ascii?Q?CWjx5w9MUy4Bdp+oXjSAD5yNIb6s2O+295G+m2IwN14UXtXp45Ac2MgIQ+va?= =?us-ascii?Q?vzGybE2SudLA2J7rQxi3SisZlOeKLVbAdlQLVOx/hUmbLsUSs8GwzxTlEQ8J?= =?us-ascii?Q?QvkxY3l7o80jKPH6Tudm6k8ibswskw0eHKMOq07dvGxVdZDl/G0=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2+EkK3WJ2A8CFCVjmoXJpTqF27iqk2sV29foMuYdT+TAHJ7lGaUabB0nI4yS?= =?us-ascii?Q?/eTQrQyH09nlmVL394B8l23Gs4MPOgNaYVGE8HZ4GlW4QG0Zua0Wqy/VTejC?= =?us-ascii?Q?rqJS1jiiozTjCzRn4uZ2vYJuNsmMxSbwXn/H/1jzSCNNIvgy97oYdh5Hq1kr?= =?us-ascii?Q?xx4YWJHRbZuHXhi9uHKXR3NejhrkQhVmewGtnYK60DFQ3wZLRClNPR0yUafm?= =?us-ascii?Q?SPcVDF+H0YQO71ArmSoXzxH1GMIPxySEblcWyGrx9d+GvBSaw4RJ+LZjmeYr?= =?us-ascii?Q?4LafkM80RUhRl74SfaNxvbuEvFQcFfs0AgAN6EmEVSG6A4PmyZi7THG/tcLx?= =?us-ascii?Q?fHgs6jhkqSpUNGHk1kpA0TsGoRUmy9N4sD+NRL7rI1+p3q1mQGOOI0r0pgZl?= =?us-ascii?Q?i9Kvp5EU/nnYNOtg0VKbqrruftyo6qMg1P/wuwOEFlIHecco8B2GIgcaf1+g?= =?us-ascii?Q?TRmAY6+WA5N+uRCVhxVqjvCsgW+nnYC30vpodxBrvZFhgW7XacXgoDB3xCSa?= =?us-ascii?Q?BD718lFVSslHToBgxb2NM8jfz+69myHVYwcSh0Gk70nNLGIDoaI/cdl+rnHU?= =?us-ascii?Q?psGGGPKSEqw7aLlGCS34kGoYnW62Ru+RE37rFHaPeIdl+YmlGRBWbTvk+U4w?= =?us-ascii?Q?V+Lvuykm9Cky0/rwtjbPcASQr6vwZ+2LG5+jbY28/P0fOZBnGrutZE36Lp/8?= =?us-ascii?Q?pk7PdzMTwMnWxmCNToDeFAu4zHdA3vamiq9jpj0+v+eqy0urJIq3RiZIlA1p?= =?us-ascii?Q?+ncEq55wjexMmgYqv27zVIaoXSEXqpAx7ti1PTRc/076F/Aa7VE9QnpTS3b+?= =?us-ascii?Q?NbQoogfN6Uol9fjIoZjoHYbDDs7KZHxndEj9/jJtDubf1I97oHWVsxc8FvBN?= =?us-ascii?Q?PVF/XAjzUcoIPfuSll/p+WSzxM4RIgsUGyvsuSKAr8BJsiHm7gMfVpYrquZ0?= =?us-ascii?Q?DRgcjJClaYqtpHudZ+UDGfnUpa28hryUOiC3HIqPF9XeckB3rkg0E5lYwxIb?= =?us-ascii?Q?+UkJD0O0CykkcGVrrRIpi0p7uItZ7vP8CjG7HA5CSXuPPdPoNPAIu5nekx3F?= =?us-ascii?Q?2lFVkIGmXlPdbR9b7mviKrqmbEbHbXwJg1w3SC8KRKKdFfeQi3IACQlUs0sB?= =?us-ascii?Q?ZiyrJSA5z1wEDwwM+SKcnBjQxX3uDlif8CWezgpOCvPH+QD6C8n+y4+8GthW?= =?us-ascii?Q?nGaJuYmIyUYJh5tSL4vEosOdzPepUgmtZxZF3eTdnqv5IPIkJdt6IO41NbEF?= =?us-ascii?Q?+or5paPKFKqlKfjr8QGlV6C/sFrEprjxbX617KEJn0vfSK1piRdtwlsizP47?= =?us-ascii?Q?V5lAJ04lNQGk1UZOu2qFTo5Y7GSl1GzghIelRAffNdkTv0iol838Od8SkD8s?= =?us-ascii?Q?Ms9G1uA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 608bedcf-0f7f-4e6a-a182-08ded86203c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2026 17:47:41.4288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR02MB10144 X-purgate-ID: tlsNG-d25034/1783014469-A8AA8D51-9423B9BB/0/0 X-purgate-type: clean X-purgate-size: 13687 From: Sean Christopherson Sent: Wednesday, July 1, 2026= 12:32 PM >=20 > Add dedicated hypervisor hooks for getting known TSC/CPU frequencies > instead of overriding seemingly generic platform hooks, and explicitly > priotize hypervisor-provided frequencies over native methods, but do NOT s/priotize/prioritize/ > clobber the frequency obtained from trusted firmware. While shuffling th= e > hooks around is arguably "six of one, half dozen of the other", scoping > them to x86_hyper_init makes their purpose more obvious, and allows for > explicitly defining the priority of sources (as is done here). >=20 > As is already done when trusted firmware provides the TSC frequency, igno= re Word "ignore" is duplicated. > ignore tsc_early_khz if the exact TSC frequency was obtained from the > hypervisor, as attempting to refine the TSC frequency when running in a V= M > is all but guaranteed to cause problems sooner or later due to the > calibration sources being emulated devices in the vast majority of setups= . >=20 > Cc: David Woodhouse > Signed-off-by: Sean Christopherson For the Hyper-V changes, Reviewed-by: Michael Kelley =20 > --- > .../admin-guide/kernel-parameters.txt | 3 +- > arch/x86/include/asm/acrn.h | 5 ---- > arch/x86/include/asm/x86_init.h | 4 +++ > arch/x86/kernel/cpu/acrn.c | 10 +++++-- > arch/x86/kernel/cpu/mshyperv.c | 6 ++-- > arch/x86/kernel/cpu/vmware.c | 8 ++--- > arch/x86/kernel/jailhouse.c | 6 ++-- > arch/x86/kernel/kvmclock.c | 6 ++-- > arch/x86/kernel/tsc.c | 29 ++++++++++++++----- > arch/x86/xen/time.c | 4 +-- > 10 files changed, 50 insertions(+), 31 deletions(-) >=20 > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat= ion/admin- > guide/kernel-parameters.txt > index 490e6aa72fc2..a387bb2c47e2 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -7948,7 +7948,8 @@ Kernel parameters >=20 > Note, tsc_early_khz is ignored if the TSC frequency is > provided by trusted firmware when running as an SNP or > - TDX guest. > + TDX guest, or when the hypervisor provides the exact > + frequency via a paravirtual interface. >=20 > tsx=3D [X86] Control Transactional Synchronization > Extensions (TSX) feature in Intel processors that > diff --git a/arch/x86/include/asm/acrn.h b/arch/x86/include/asm/acrn.h > index db42b477c41d..a892179c61c6 100644 > --- a/arch/x86/include/asm/acrn.h > +++ b/arch/x86/include/asm/acrn.h > @@ -32,11 +32,6 @@ static inline u32 acrn_cpuid_base(void) > return 0; > } >=20 > -static inline unsigned long acrn_get_tsc_khz(void) > -{ > - return cpuid_eax(ACRN_CPUID_TIMING_INFO); > -} > - > /* > * Hypercalls for ACRN > * > diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_i= nit.h > index 953d3199408a..0c89bf40f507 100644 > --- a/arch/x86/include/asm/x86_init.h > +++ b/arch/x86/include/asm/x86_init.h > @@ -123,6 +123,8 @@ struct x86_init_pci { > * @msi_ext_dest_id: MSI supports 15-bit APIC IDs > * @init_mem_mapping: setup early mappings during init_mem_mapping() > * @init_after_bootmem: guest init after boot allocator is finished > + * @get_tsc_khz: get the TSC frequency (returns 0 if frequency is unkno= wn) > + * @get_cpu_khz: get the CPU frequency (returns 0 if frequency is unkno= wn) > */ > struct x86_hyper_init { > void (*init_platform)(void); > @@ -131,6 +133,8 @@ struct x86_hyper_init { > bool (*msi_ext_dest_id)(void); > void (*init_mem_mapping)(void); > void (*init_after_bootmem)(void); > + unsigned int (*get_tsc_khz)(void); > + unsigned int (*get_cpu_khz)(void); > }; >=20 > /** > diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c > index dc119af83524..ad8f2da8003b 100644 > --- a/arch/x86/kernel/cpu/acrn.c > +++ b/arch/x86/kernel/cpu/acrn.c > @@ -24,13 +24,15 @@ static u32 __init acrn_detect(void) > return acrn_cpuid_base(); > } >=20 > +static unsigned int __init acrn_get_tsc_khz(void) > +{ > + return cpuid_eax(ACRN_CPUID_TIMING_INFO); > +} > + > static void __init acrn_init_platform(void) > { > /* Install system interrupt handler for ACRN hypervisor callback */ > sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); > - > - x86_platform.calibrate_tsc =3D acrn_get_tsc_khz; > - x86_platform.calibrate_cpu =3D acrn_get_tsc_khz; > } >=20 > static bool acrn_x2apic_available(void) > @@ -78,4 +80,6 @@ const __initconst struct hypervisor_x86 x86_hyper_acrn = =3D { > .type =3D X86_HYPER_ACRN, > .init.init_platform =3D acrn_init_platform, > .init.x2apic_available =3D acrn_x2apic_available, > + .init.get_tsc_khz =3D acrn_get_tsc_khz, > + .init.get_cpu_khz =3D acrn_get_tsc_khz, > }; > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyper= v.c > index 87beecec76f0..f9bc1c2d8c93 100644 > --- a/arch/x86/kernel/cpu/mshyperv.c > +++ b/arch/x86/kernel/cpu/mshyperv.c > @@ -395,7 +395,7 @@ static int hv_nmi_unknown(unsigned int val, struct pt= _regs *regs) > } > #endif >=20 > -static unsigned long hv_get_tsc_khz(void) > +static unsigned int __init hv_get_tsc_khz(void) > { > unsigned long freq; >=20 > @@ -573,8 +573,8 @@ static void __init ms_hyperv_init_platform(void) >=20 > if (ms_hyperv.features & HV_ACCESS_FREQUENCY_MSRS && > ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) { > - x86_platform.calibrate_tsc =3D hv_get_tsc_khz; > - x86_platform.calibrate_cpu =3D hv_get_tsc_khz; > + x86_init.hyper.get_tsc_khz =3D hv_get_tsc_khz; > + x86_init.hyper.get_cpu_khz =3D hv_get_tsc_khz; > setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > } >=20 > diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c > index 13b97265c535..3cb473cae462 100644 > --- a/arch/x86/kernel/cpu/vmware.c > +++ b/arch/x86/kernel/cpu/vmware.c > @@ -64,7 +64,7 @@ struct vmware_steal_time { > u64 reserved[7]; > }; >=20 > -static unsigned long vmware_tsc_khz __ro_after_init; > +static unsigned long vmware_tsc_khz __initdata; > static u8 vmware_hypercall_mode __ro_after_init; >=20 > unsigned long vmware_hypercall_slow(unsigned long cmd, > @@ -137,7 +137,7 @@ static inline int __vmware_platform(void) > return eax !=3D UINT_MAX && ebx =3D=3D VMWARE_HYPERVISOR_MAGIC; > } >=20 > -static unsigned long vmware_get_tsc_khz(void) > +static unsigned int __init vmware_get_tsc_khz(void) > { > return vmware_tsc_khz; > } > @@ -419,8 +419,8 @@ static void __init vmware_platform_setup(void) > } >=20 > vmware_tsc_khz =3D tsc_khz; > - x86_platform.calibrate_tsc =3D vmware_get_tsc_khz; > - x86_platform.calibrate_cpu =3D vmware_get_tsc_khz; > + x86_init.hyper.get_tsc_khz =3D vmware_get_tsc_khz; > + x86_init.hyper.get_cpu_khz =3D vmware_get_tsc_khz; >=20 > /* Skip lapic calibration since we know the bus frequency. */ > apic_set_timer_period_hz(ecx, "VMware hypervisor"); > diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c > index f2d4ef89c085..e24c05ab4fae 100644 > --- a/arch/x86/kernel/jailhouse.c > +++ b/arch/x86/kernel/jailhouse.c > @@ -68,7 +68,7 @@ static void __init jailhouse_timer_init(void) > apic_set_timer_period_khz(setup_data.v1.apic_khz, "Jailhouse hypervisor= "); > } >=20 > -static unsigned long jailhouse_get_tsc(void) > +static unsigned int __init jailhouse_get_tsc(void) > { > return precalibrated_tsc_khz; > } > @@ -210,8 +210,6 @@ static void __init jailhouse_init_platform(void) > x86_init.mpparse.parse_smp_cfg =3D jailhouse_parse_smp_config; > x86_init.pci.arch_init =3D jailhouse_pci_arch_init; >=20 > - x86_platform.calibrate_cpu =3D jailhouse_get_tsc; > - x86_platform.calibrate_tsc =3D jailhouse_get_tsc; > x86_platform.get_wallclock =3D jailhouse_get_wallclock; > x86_platform.legacy.rtc =3D 0; > x86_platform.legacy.warm_reset =3D 0; > @@ -293,5 +291,7 @@ const struct hypervisor_x86 x86_hyper_jailhouse __ref= const =3D { > .detect =3D jailhouse_detect, > .init.init_platform =3D jailhouse_init_platform, > .init.x2apic_available =3D jailhouse_x2apic_available, > + .init.get_tsc_khz =3D jailhouse_get_tsc, > + .init.get_cpu_khz =3D jailhouse_get_tsc, > .ignore_nopv =3D true, > }; > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > index cb3d0ca1fa22..4f8299303a19 100644 > --- a/arch/x86/kernel/kvmclock.c > +++ b/arch/x86/kernel/kvmclock.c > @@ -136,7 +136,7 @@ static inline void kvm_sched_clock_init(bool stable) > * poll of guests can be running and trouble each other. So we preset > * lpj here > */ > -static unsigned long kvm_get_tsc_khz(void) > +static unsigned int __init kvm_get_tsc_khz(void) > { > setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > return pvclock_tsc_khz(this_cpu_pvti()); > @@ -343,8 +343,8 @@ void __init kvmclock_init(void) > flags =3D pvclock_read_flags(&hv_clock_boot[0].pvti); > kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); >=20 > - x86_platform.calibrate_tsc =3D kvm_get_tsc_khz; > - x86_platform.calibrate_cpu =3D kvm_get_tsc_khz; > + x86_init.hyper.get_tsc_khz =3D kvm_get_tsc_khz; > + x86_init.hyper.get_cpu_khz =3D kvm_get_tsc_khz; > x86_platform.get_wallclock =3D kvm_get_wallclock; > x86_platform.set_wallclock =3D kvm_set_wallclock; > #ifdef CONFIG_X86_LOCAL_APIC > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > index 86384a83a5f6..1dca9464b41c 100644 > --- a/arch/x86/kernel/tsc.c > +++ b/arch/x86/kernel/tsc.c > @@ -1451,13 +1451,17 @@ static int __init init_tsc_clocksource(void) > device_initcall(init_tsc_clocksource); >=20 > static bool __init determine_cpu_tsc_frequencies(bool early, > + unsigned int known_cpu_khz, > unsigned int known_tsc_khz) > { > /* Make sure that cpu and tsc are not already calibrated */ > WARN_ON(cpu_khz || tsc_khz); >=20 > if (early) { > - cpu_khz =3D x86_platform.calibrate_cpu(); > + if (known_cpu_khz) > + cpu_khz =3D known_cpu_khz; > + else > + cpu_khz =3D x86_platform.calibrate_cpu(); > if (known_tsc_khz) > tsc_khz =3D known_tsc_khz; > else > @@ -1514,7 +1518,7 @@ static void __init tsc_enable_sched_clock(void) >=20 > void __init tsc_early_init(void) > { > - unsigned int known_tsc_khz =3D 0; > + unsigned int known_cpu_khz =3D 0, known_tsc_khz =3D 0; >=20 > if (!boot_cpu_has(X86_FEATURE_TSC)) > return; > @@ -1522,22 +1526,33 @@ void __init tsc_early_init(void) > if (is_early_uv_system()) > return; >=20 > + if (x86_init.hyper.get_cpu_khz) > + known_cpu_khz =3D x86_init.hyper.get_cpu_khz(); > + > if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) > known_tsc_khz =3D snp_secure_tsc_init(); > else if (boot_cpu_has(X86_FEATURE_TDX_GUEST)) > known_tsc_khz =3D tdx_tsc_init(); >=20 > + /* > + * If the TSC frequency wasn't provided by trusted firmware, try to get > + * it from the hypervisor (which is untrusted when running as a CoCo gu= est). > + */ > + if (!known_tsc_khz && x86_init.hyper.get_tsc_khz) > + known_tsc_khz =3D x86_init.hyper.get_tsc_khz(); > + > /* > * Ignore the user-provided TSC frequency if the exact frequency was > - * obtained from trusted firmware, as the user-provided frequency is > - * intended as a "starting point", not a known, guaranteed frequency. > + * obtained from trusted firmware or the hypervisor, as the user- > + * provided frequency is intended as a "starting point", not a known, > + * guaranteed frequency. > */ > if (!known_tsc_khz) > known_tsc_khz =3D tsc_early_khz; > else if (tsc_early_khz) > - pr_err("Ignoring 'tsc_early_khz' in favor of trusted firmware.\n"); > + pr_err("Ignoring 'tsc_early_khz' in favor of firmware/hypervisor.\n"); >=20 > - if (!determine_cpu_tsc_frequencies(true, known_tsc_khz)) > + if (!determine_cpu_tsc_frequencies(true, known_cpu_khz, known_tsc_khz)) > return; > tsc_enable_sched_clock(); > } > @@ -1558,7 +1573,7 @@ void __init tsc_init(void) >=20 > if (!tsc_khz) { > /* We failed to determine frequencies earlier, try again */ > - if (!determine_cpu_tsc_frequencies(false, 0)) { > + if (!determine_cpu_tsc_frequencies(false, 0, 0)) { > mark_tsc_unstable("could not calculate TSC khz"); > setup_clear_cpu_cap(X86_FEATURE_TSC_DEADLINE_TIMER); > return; > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index d62c14334b35..1adb44fdddb2 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -38,7 +38,7 @@ > static u64 xen_sched_clock_offset __read_mostly; >=20 > /* Get the TSC speed from Xen */ > -static unsigned long xen_tsc_khz(void) > +static unsigned int __init xen_tsc_khz(void) > { > struct pvclock_vcpu_time_info *info =3D > &HYPERVISOR_shared_info->vcpu_info[0].time; > @@ -569,7 +569,7 @@ static void __init xen_init_time_common(void) > static_call_update(pv_steal_clock, xen_steal_clock); > paravirt_set_sched_clock(xen_sched_clock); >=20 > - x86_platform.calibrate_tsc =3D xen_tsc_khz; > + x86_init.hyper.get_tsc_khz =3D xen_tsc_khz; > x86_platform.get_wallclock =3D xen_get_wallclock; > } >=20 > -- > 2.55.0.rc0.799.gd6f94ed593-goog >=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 17:48:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 17:48:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352287.1609122 (Exim 4.92) (envelope-from ) id 1wfLW8-00073T-T0; Thu, 02 Jul 2026 17:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352287.1609122; Thu, 02 Jul 2026 17:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLW8-00073M-QA; Thu, 02 Jul 2026 17:48:04 +0000 Received: by outflank-mailman (input) for mailman id 1352287; Thu, 02 Jul 2026 17:48:03 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLW7-00072X-EJ for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:48:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfLW6-008qpb-RM for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 19:48:02 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46a443-e002-0a2a0a5209dd-0a2a4505c830-8 for ; Thu, 02 Jul 2026 19:48:02 +0200 Received: from [52.103.1.0] (helo=BL2PR02CU003.outbound.protection.outlook.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46a44e-3cb2-0a2a45050019-34670100a453-3 for ; Thu, 02 Jul 2026 19:48:01 +0200 Received: from SN6PR02MB4157.namprd02.prod.outlook.com (2603:10b6:805:33::23) by LV8PR02MB10144.namprd02.prod.outlook.com (2603:10b6:408:18f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 2 Jul 2026 17:47:54 +0000 Received: from SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6]) by SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6%3]) with mapi id 15.21.0181.008; Thu, 2 Jul 2026 17:47:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=outlook.com header.i="@outlook.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KHoEp7dCJNfZ2ZEYm/gm9MNVzODF6uNunrGbwyFYG6dJ7U7U06e4d1kCGT5Y9poMpqx7SM2ZdOCmAsVl7N+y0syGRgIW8N1W6dwapBFpOtVKk+EkyTl7p+flLIVd1krsOwDpPdWpea+0MTM7v50Z+NERPXcGY9o9OCOISv0uMPUwKC5k1UOowuHfjarZAstBwezEsJcplgK0DMFhNp5HrPYvV/ilk+fHosBeGErcGHNULVzW9Ek3xFbqr7BYHXBcVqAsY5KDq+yaRT6i6e00DTiasSaNK0q8SMgGR/DwclndAGDvo3WG87WW9h+JEpuCu0xBVlWUogQgPdw4xcRG4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8G/iF/UE8E5eJfmXsP11xDkhwiBaGeTGpy27NbqqiJA=; b=CuIcHBPd6cKQLaEvdL1PqAHyCFffbi70t+H3NVC8ZISZJff+ofDBD3kcTF/N9yZzyGg1Aa/md/eDQ0MjqDu8h2OWlLFDUcUmwyOqrqj8+5xDMMdDf9BrYZ4Ug3Nh4ChHODand2k9JRJ+HgPSLXgDQGYLHmvYcMHsdcTT0gmHNXHJepecZRZ5ABG3tIW5ReuyHuDxXY7ggNpUFwh2Bax05Ll8g0ggntUEsgf7/r+C2kPyhTc7JEx7eIai0oRAzSA2i65UAR0twi6lrXBynxrHVTb25X/pFFljfx/K2U4uMEz+Bk1cdJ3T6geyU0eTDJna5cOO8qGDsOH1n9JB+Ssc/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8G/iF/UE8E5eJfmXsP11xDkhwiBaGeTGpy27NbqqiJA=; b=pLjHkLTjRY7SL6oMuKrPzcF0TKzE/f7W/qu/2sAJUIRyjjWoGj9KJY6Yfe0UX/Hs7sJTFUxVyFC6SxQH52J0nxe9iGo12gpM3v+DkXCCNAKaILJsUn1QCLQCtfx7LF6DGaWcHEd+TBmN/Sls7lwj649F18zqDM7UvL/ytznNlNTP2LFvCUpAFCj/pAvU3rIzSL3UWVobMRq+rS3KMhNo1aFGw5pAdI72rl3zvouD9FA1FFriN/S/qPrhI4SWveYxAa9Ic+NmD5NGYhTcU71y+/9zIEMzq2iIpackyfreNZksU0F5Kyar0by8Nzf5ASGZHSCCTgOS/C63qLf5mPeVag== From: Michael Kelley To: Sean Christopherson , Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Kiryl Shutsemau , Rick Edgecombe , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz CC: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , "linux-doc@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "virtualization@lists.linux.dev" , "xen-devel@lists.xenproject.org" , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Subject: RE: [PATCH v5 14/51] x86/tsc: Consolidate forcing of X86_FEATURE_TSC_KNOWN_FREQ for PV code Thread-Topic: [PATCH v5 14/51] x86/tsc: Consolidate forcing of X86_FEATURE_TSC_KNOWN_FREQ for PV code Thread-Index: AQHdCZBo3fC/rBiXmkyrOoc2yLGVY7Zagq9Q Date: Thu, 2 Jul 2026 17:47:54 +0000 Message-ID: References: <20260701193212.749551-1-seanjc@google.com> <20260701193212.749551-15-seanjc@google.com> In-Reply-To: <20260701193212.749551-15-seanjc@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR02MB4157:EE_|LV8PR02MB10144:EE_ x-ms-office365-filtering-correlation-id: 7e735224-d18e-4d76-5415-08ded8620b95 x-ms-exchange-slblob-mailprops: qdrM8TqeFBvhuFgLLe5qs4jWk9CHdv0ATSI6n101gleWPZ+LxoY8/5cb6C/shF5Ih0Hn092D14Pn4D/9I/HbBPvhjVldxo3XYuQ9DVtjNxkw82om94dSRT6eLqLcY7HzSrlv4MNnP+aj8F8x8/9970aQXiX+Bz6jmZ8/h5vfmjfOuVaJtyek7dY0ORq3MUtJ7+hiQFfSTuS9VyZyOVL/ljDRMe6gB10eJpocaD7syQuNkL7gWZSaUbF9fuawuW4o+hb4yKivswiKsTFaPrCtWH5k+20lx807gmul9NZLedoSHDAWR5G8htGjaRgPZagaNt5Ki3CcNBbKpqpPaVRo9o5zUYCd3cKylcIDAppOZ18kmwFm0/XFIdgldzBuTFjo/8k5DpHqW1rjxWYlpf9F8KnJlGZgIJEsuAFH2Y94vlufiZSbk7XANlEpVHQsPJR95AFFfEff0FxLwGTCQbGEoB08AareuAzyXl1ptVNZxnW9he84pMbEYlheNXKp1JeY/f5iMn8JF/1rs4R1aE+/n79npIrbf+wPgAcMYfLB+rIwhTZ1VXhe0x4V32zx3AezoU6fkoRJ8yGpG3Hb9JDUsf6T352K58Kol793lSmQuFAHgPGVGRox9NmzSOVRlFoBTfDNdydCks+QfviZjgWYZ082onf4HVadxEI5VXhmTW2moxSbKMXk7iiASqDEB4AGjmFVqk1ZSUUthoPISD4gF/bYRnbMft8nw4eC8ZDJJ2DgmR3iKi4ixqeuRvPhIkaogG2AYA3gq60l7/EgAREzACsEdfwA97cq x-microsoft-antispam: BCL:0;ARA:14566002|16051099003|51005399006|19101099003|2604032031799003|37011999003|13091999003|8060799015|8062599012|31061999003|41001999006|19110799012|25010399006|15080799012|40105399003|102099032|440099028|3412199025|1710799026; x-microsoft-antispam-message-info: =?us-ascii?Q?xlTLF8VHk2mVYDxNPmyNyz9IsIDRGFuy97oGnlCy9hjUPDeUqFKlUlBFuhwc?= =?us-ascii?Q?13p4tTeObKDvQ2KB1BQJQx6wmxIVGjO8nnRBHR0A/hRKt2ZI8m5CsQDrOvr3?= =?us-ascii?Q?o9IbfzBrbUF66oKZ16298Fuay6gt1n+7C8yLrLDZxiW6xfXdIlXQyG4ozyhV?= =?us-ascii?Q?6FIJ6Obbm5BruShxr4PXNs444ZuLrFgPhPhw/jrzD90dlRVulvgEE+YPSStn?= =?us-ascii?Q?4E43RYJNNyZ8oBVcvMJMPN3JbfywWHQfPqMdoi/DAZLOk9+9LMzjPbyvIcYO?= =?us-ascii?Q?9nXXm4CPFG0A13LiSDzNjSncQCMTCxwUIEdvJJ1wvQMOAeJsRIcYh+uFgcjF?= =?us-ascii?Q?GZ35u8UTLmaV5P+EWDQdqCBjk7K9RjzlmPEuYhojW50TnqjOrECq+i4Zr3md?= =?us-ascii?Q?SortMf1w/VO/9ZLhdBQDlkui+NdqJWAKrGd1GQmEwQZKXkF+li7rAPK3i5+7?= =?us-ascii?Q?Mn986ANy7pyKYN5LaXFK7TOqZ1unYRQpQEy4d/BMls/unHQRBTJebJ5/ZScE?= =?us-ascii?Q?xbiXvwTOupDny3i6NudS1VRKqsQsjMRtYwyUClNpjVDa0uRyDppbqtEN0egG?= =?us-ascii?Q?JvxxugZfRZrYVgyuz0x8y/SLR91Y8tSWNnLuCjSv5nnoX/LmuDuh/maxZT+X?= =?us-ascii?Q?KDiSlwgosi3XG7Vq8pUaqKAz/OGXfaYjadBKnahMrw4Xg8k6gyeyjMprPulh?= =?us-ascii?Q?5ASMdy3cfg3Jl1aGx9ILdsnFOF5uFJsBANV2wqFVCoRp+5KZPZCT0dq4G5bH?= =?us-ascii?Q?5V8P6XWECYR4/gPujyLpY/6i6DFdkIwL8XY7+x11D141DEy6vFQtkWosCtDT?= =?us-ascii?Q?tza6B+SmdRkcrvFHe2NzAdPi8OQgUV4jHGAZi58JCSWPts1Pe3ccPvt3og+S?= =?us-ascii?Q?8EJUB0ajZYPNjyMvNi8F2wqzHU7vtkzXWbwAoqhJdvTUCQxTZXMOOQh2G2r+?= =?us-ascii?Q?sdoSAmesMg5mMvGbYiG5xFtIIQ0KdFJfHLFaeHxMEHC56vAjPpnCkPctAIJl?= =?us-ascii?Q?4b7zRRuupvgS2RHSuSdi7SA/cFaDSk/0NriOL23tIWhaW1+MUYKoWaLXeIve?= =?us-ascii?Q?gamOOBdRCQlxn229LYTLFmn0zBmJ2t59o5RfW0Ix0gGY8+Pw1SH3R6S6oH7V?= =?us-ascii?Q?bfzxeC1EcvLf?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WtAwUa0GT7zoPNOR5eAD5D8n1jZ5qyjc5SXCkQxlLud9GLCVWQkU5NYMqVAo?= =?us-ascii?Q?gvGwoNPdGx+gg7rFn2IpSNt2nTWL7Lg58peYDqJBFCTRefBDLYh4jhVopHL1?= =?us-ascii?Q?m27aJWcCcUa29RXDT5FkCfurwYfFjzL8gj7auj9iB8egKfCIfNBTV0gnR7aq?= =?us-ascii?Q?kQReOmaHAcpRLchiEaoKkAA97kjWRnqOwtMQbvkiFXJ43G7q1oEi4fuWDKz1?= =?us-ascii?Q?GOuRxvBen0FNVCrwxMnCqt/T3UReyuuCIuq2CNn6DymfTlfPEWAQJ6Jg43UK?= =?us-ascii?Q?1KnPSXQcFgyptKH4Zn7z//UJO2vLNkn+an9tlvWyEiQmY0DZ2r9KYwPQstk5?= =?us-ascii?Q?+pHn1Iqd/fYwuRhU8RFkaGJ+x3QkQFglDcaRCMzfyOlqZMxToF49V2t8VvX7?= =?us-ascii?Q?ks54ClCv64sC4n87zVuS4qqvV67MWqiJ9fN5Lnq53X0SlF0KFXBsR1lZMAv9?= =?us-ascii?Q?HKiLMPFoqsjNPRpMvLUWQOLypsEpPKfDAOZEYGkS+60gFQSGEpY6wuT02Xw+?= =?us-ascii?Q?fIK6iYXBg99CykG4zNH1B4qhzJriI+NFfVUQKZ+d3cDhWip8lR8QW05/pyxW?= =?us-ascii?Q?6V/EgNodaIz1Gm72C9ER92shdtxjdZc+aKTiKe8O3nAS+VdAVfYLA+5PuugH?= =?us-ascii?Q?AARHMYMLYMXJOUZxO0WX5iNKPrm1vQIpingTijaEPFmFS9goz5gqcsscv6MT?= =?us-ascii?Q?hqQ4cQ15OWOPeBEzKCkWCj0l76ai81Bsq4uAve6PIm9Brm24ZGljtoUg5XHc?= =?us-ascii?Q?eb4+eUxl0tYM6rmtBXMTOixVdkEWXN+rVNKJGF5Z6uVD3cVLNAyrYY7UWwt6?= =?us-ascii?Q?TtRzAR83X6SOmnk6eBLh6QoVBevG4qonZPsMwqFdqZQS+xX0sn+lE8wT27Uh?= =?us-ascii?Q?pYtv3mWSN9aiSBxO5Fwn9+i0ocf4a/WQ3NMm6Z7o99bu/b83cP7AW741FmLE?= =?us-ascii?Q?WTJUzHSsdg21Z0Q6c42RC0LGp3Y5gZapWYbi+wzaemqFlMQ3tE1+FJ42s0HS?= =?us-ascii?Q?0Cf0O3PFpV1HuCxU4FzmRaCrsMLj0NCqPFYbRNP88odYn7jVxqjI+4pyvVMQ?= =?us-ascii?Q?4S97eFhW+ECEzYq4a+OPnObM+aOHvsySDy/Q9fcIj24W000Fz2AnNZsceSD4?= =?us-ascii?Q?dOKkDUICWAlb8ca2yLwQTiOY1QzzRjw52rhMPNfo7rM/c0G2pKOCH1sYjDoU?= =?us-ascii?Q?l+5zuNBy8FYuQd8nYqac6cS5JUajH0h2+PhETaA8BdulsFZtgc48bOGyw4cF?= =?us-ascii?Q?1RMDcj+agQzfXbuXLZQ9Nk3HF3uT19zqefEHaKdvBvmSBRdsRaSz03++/OWo?= =?us-ascii?Q?XGW+PK1LYM1YzmZuGp/6vcli5+omuRR+DcdGJyZc9FcWCRyx1X6Uywn3hIR1?= =?us-ascii?Q?SQN67sg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7e735224-d18e-4d76-5415-08ded8620b95 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2026 17:47:54.5401 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR02MB10144 X-purgate-ID: tlsNG-c201ff/1783014481-0DD0E2B8-A9B42984/0/0 X-purgate-type: clean X-purgate-size: 6413 From: Sean Christopherson Sent: Wednesday, July 1, 2026= 12:32 PM >=20 > Now that all paravirt code that explicitly specifies the TSC frequency > also sets X86_FEATURE_TSC_KNOWN_FREQ, replace all of the one-off code > and simply set X86_FEATURE_TSC_KNOWN_FREQ if the TSC frequency is known. >=20 > Do NOT force set TSC_KNOWN_FREQ if the "known" TSC frequency was provided > by the user. Per commit bd35c77e32e4 ("x86/tsc: Add tsc_early_khz comman= d > line parameter"), one of the goals of the param is to allow the refined > calibration work "to do meaningful error checking". >=20 > No functional change intended. >=20 > Signed-off-by: Sean Christopherson For the Hyper-V changes, Reviewed-by: Michael Kelley > --- > arch/x86/coco/sev/core.c | 1 - > arch/x86/coco/tdx/tdx.c | 1 - > arch/x86/kernel/cpu/acrn.c | 1 - > arch/x86/kernel/cpu/mshyperv.c | 1 - > arch/x86/kernel/cpu/vmware.c | 2 -- > arch/x86/kernel/jailhouse.c | 1 - > arch/x86/kernel/kvmclock.c | 1 - > arch/x86/kernel/tsc.c | 13 ++++++++++--- > arch/x86/xen/time.c | 1 - > 9 files changed, 10 insertions(+), 12 deletions(-) >=20 > diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c > index bc5ae9ef74da..72313b36b6f5 100644 > --- a/arch/x86/coco/sev/core.c > +++ b/arch/x86/coco/sev/core.c > @@ -2027,7 +2027,6 @@ unsigned int __init snp_secure_tsc_init(void) >=20 > secrets =3D (__force struct snp_secrets_page *)mem; >=20 > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); >=20 > rdmsrq(MSR_AMD64_GUEST_TSC_FREQ, tsc_freq_mhz); > diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c > index ae2d35f2ef33..94682aca188b 100644 > --- a/arch/x86/coco/tdx/tdx.c > +++ b/arch/x86/coco/tdx/tdx.c > @@ -1205,7 +1205,6 @@ unsigned int __init tdx_tsc_init(void) >=20 > /* TSC is the only reliable clock in TDX guest */ > setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); >=20 > return info.crystal_khz * info.numerator / info.denominator; > } > diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c > index 3818f6ae0629..dc71a6fdd461 100644 > --- a/arch/x86/kernel/cpu/acrn.c > +++ b/arch/x86/kernel/cpu/acrn.c > @@ -40,7 +40,6 @@ static void __init acrn_init_platform(void) > if (acrn_tsc_khz_cpuid) { > x86_init.hyper.get_tsc_khz =3D acrn_get_tsc_khz; > x86_init.hyper.get_cpu_khz =3D acrn_get_tsc_khz; > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > } > } >=20 > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyper= v.c > index f9bc1c2d8c93..e03c69a4db33 100644 > --- a/arch/x86/kernel/cpu/mshyperv.c > +++ b/arch/x86/kernel/cpu/mshyperv.c > @@ -575,7 +575,6 @@ static void __init ms_hyperv_init_platform(void) > ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) { > x86_init.hyper.get_tsc_khz =3D hv_get_tsc_khz; > x86_init.hyper.get_cpu_khz =3D hv_get_tsc_khz; > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > } >=20 > if (ms_hyperv.priv_high & HV_ISOLATION) { > diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c > index 3cb473cae462..0a3bd90576d4 100644 > --- a/arch/x86/kernel/cpu/vmware.c > +++ b/arch/x86/kernel/cpu/vmware.c > @@ -390,8 +390,6 @@ static void __init vmware_set_capabilities(void) > { > setup_force_cpu_cap(X86_FEATURE_CONSTANT_TSC); > setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); > - if (vmware_tsc_khz) > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > if (vmware_hypercall_mode =3D=3D CPUID_VMWARE_FEATURES_ECX_VMCALL) > setup_force_cpu_cap(X86_FEATURE_VMCALL); > else if (vmware_hypercall_mode =3D=3D CPUID_VMWARE_FEATURES_ECX_VMMCALL= ) > diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c > index e24c05ab4fae..ff173052cdce 100644 > --- a/arch/x86/kernel/jailhouse.c > +++ b/arch/x86/kernel/jailhouse.c > @@ -255,7 +255,6 @@ static void __init jailhouse_init_platform(void) > pr_debug("Jailhouse: PM-Timer IO Port: %#x\n", pmtmr_ioport); >=20 > precalibrated_tsc_khz =3D setup_data.v1.tsc_khz; > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); >=20 > pci_probe =3D 0; >=20 > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > index 4f8299303a19..35a879d33e9e 100644 > --- a/arch/x86/kernel/kvmclock.c > +++ b/arch/x86/kernel/kvmclock.c > @@ -138,7 +138,6 @@ static inline void kvm_sched_clock_init(bool stable) > */ > static unsigned int __init kvm_get_tsc_khz(void) > { > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > return pvclock_tsc_khz(this_cpu_pvti()); > } >=20 > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > index 1dca9464b41c..676910292af7 100644 > --- a/arch/x86/kernel/tsc.c > +++ b/arch/x86/kernel/tsc.c > @@ -1541,11 +1541,18 @@ void __init tsc_early_init(void) > if (!known_tsc_khz && x86_init.hyper.get_tsc_khz) > known_tsc_khz =3D x86_init.hyper.get_tsc_khz(); >=20 > + /* > + * Mark the TSC frequency as known if it was obtained from a hypervisor > + * or trusted firmware. > + */ > + if (known_tsc_khz) > + setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > + > /* > * Ignore the user-provided TSC frequency if the exact frequency was > - * obtained from trusted firmware or the hypervisor, as the user- > - * provided frequency is intended as a "starting point", not a known, > - * guaranteed frequency. > + * obtained from trusted firmware or the hypervisor, and don't mark the > + * frequency as known, as the user-provided frequency is intended as a > + * "starting point", not a known, guaranteed frequency > */ > if (!known_tsc_khz) > known_tsc_khz =3D tsc_early_khz; > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index 1adb44fdddb2..487ad838c441 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -43,7 +43,6 @@ static unsigned int __init xen_tsc_khz(void) > struct pvclock_vcpu_time_info *info =3D > &HYPERVISOR_shared_info->vcpu_info[0].time; >=20 > - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); > return pvclock_tsc_khz(info); > } >=20 > -- > 2.55.0.rc0.799.gd6f94ed593-goog >=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 17:48:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 17:48:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352294.1609130 (Exim 4.92) (envelope-from ) id 1wfLWK-0007YV-As; Thu, 02 Jul 2026 17:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352294.1609130; Thu, 02 Jul 2026 17:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLWK-0007YK-7Q; Thu, 02 Jul 2026 17:48:16 +0000 Received: by outflank-mailman (input) for mailman id 1352294; Thu, 02 Jul 2026 17:48:14 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLWI-0007Ve-HN for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:48:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfLWH-00Ejw1-UL for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 19:48:13 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46a44e-2eae-0a2a0a5409dd-0a2a4501ebf4-12 for ; Thu, 02 Jul 2026 19:48:13 +0200 Received: from [52.103.7.21] (helo=CY7PR03CU001.outbound.protection.outlook.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46a45c-400f-0a2a45010019-34670715cc7a-3 for ; Thu, 02 Jul 2026 19:48:13 +0200 Received: from SN6PR02MB4157.namprd02.prod.outlook.com (2603:10b6:805:33::23) by LV8PR02MB10144.namprd02.prod.outlook.com (2603:10b6:408:18f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 2 Jul 2026 17:48:08 +0000 Received: from SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6]) by SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6%3]) with mapi id 15.21.0181.008; Thu, 2 Jul 2026 17:48:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=outlook.com header.i="@outlook.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RtYz6mZVqa+x8k+wF/ExqMa3lMG2xQ89vEMzvj1jy4kYvuqUqCrU+zvDWECeujr6duw4q+MGef/aPYbW5DyxveRpEFD9IviMlNICIblVr62jARsqWc8vyzZpoNXKbfOOB0mtIjlWOU48kVOxutoWeIvdCA6vqA6Cl0oK1EBymVbIQmfxnbhSbB08O6I9nYdkB35XYwAuiahQoxe65qBvjHnTgv9ee+P9XLAS3vA/EB9eXk0okHi1vQxrHIR7XjKi3YUQdOBsVObbiAgDrR7M/JJJUPj8K6EsMQMz9JWhwqlgsriOQ8GFLeiR3bNcG5rPm3dkco5XIKnoDPeDQhIX+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EF/dNgUAPKgXvgYHOIu4XocLCofCHLr1YWn24Zv2Z+0=; b=Oe2s20JC83+Z2Lwrg1m8O8+N2Jm7nqnqKQmjNsaNOtZBqp9EDcHr0cYh7qy4e+2k8DFJ47mpbcTlAhjRyXp5jMu/iXa9rxvbeHR7rT3+ycc8damCmxgsqNfoTnWRfLfpnBV/6KzpAHyMnCJIE0N0amCr2xYSW9eWznsZlg4ejwI7QyQ2zyA5AJ8iFCwmbyU4oGU9deV04rrdxuBsS1VG5QnsJsj40c4KRBGom9n4CUd3/xYWKiDTgQpQSc5zEexUaAd1xsRYjTK3Lr4v45lK96pZdxxyE/DbyItR8R+FdOnZpy3VBbZ6DOrQAn6tc4mP+JOrXfv/l8OzDzJAB/ZJ2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EF/dNgUAPKgXvgYHOIu4XocLCofCHLr1YWn24Zv2Z+0=; b=YsU6Xe2mKi4pkrWmG465otDnzxZhDpfKwy7HhSX4fsl9MMSCMVCAKuwcJzKiPpv8SE3J01UL/W38oZCKcyS2z2Bz+ltS33wArpmXBmcoZ6JoXi9CrPVopWwXx3P/EkMatS0Obsp6mGYPOo3eWR54/pXdIjR0Vc1iCRkJfgKikm6txyJa8ojCz35dDJkyU72/u9cCp+9jhkhtTzHDBwdEKmZG92OjMC7gdgxuPp9PbgcX1hp8cDtuk3EkJATb+/D7XnLSP4uI/T0SapU1W8CVyzb8YsygyrsbidqtpUPZLYEIljGqyr/jIpsRlY+bNZPRovgfTkUziUoCnKrVEoEtzA== From: Michael Kelley To: Sean Christopherson , Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Kiryl Shutsemau , Rick Edgecombe , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz CC: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , "linux-doc@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "virtualization@lists.linux.dev" , "xen-devel@lists.xenproject.org" , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Subject: RE: [PATCH v5 36/51] x86/paravirt: Pass sched_clock save/restore helpers during registration Thread-Topic: [PATCH v5 36/51] x86/paravirt: Pass sched_clock save/restore helpers during registration Thread-Index: AQHdCZB1dwmhmpW5S0uF1Oay95dScrZagr+Q Date: Thu, 2 Jul 2026 17:48:07 +0000 Message-ID: References: <20260701193212.749551-1-seanjc@google.com> <20260701193212.749551-37-seanjc@google.com> In-Reply-To: <20260701193212.749551-37-seanjc@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR02MB4157:EE_|LV8PR02MB10144:EE_ x-ms-office365-filtering-correlation-id: c3577bdd-ddd7-41d3-8060-08ded8621392 x-ms-exchange-slblob-mailprops: znQPCv1HvwUXBahuwteIkQeW30lJPuxO32JBo/6Xj0q/IUmNyxK81DjJPNRS+7GLYAeX8QbO+oXhFFrbJB8myfneXiZHb4wpCkSb1knjoi5fJ2SzBjtbKkwz2HggYIp3qH4EMSOVGj/ID1EiDoSTSsNLy5W8JKhXABkiAcHsYPOvzQ7A1J5PkOYTPSUsZCDFtBiFaE9OcowlIeR2HStX9DW5RQct6iXUHNlw1Bkvy1S2OpMsbYtDEpbJ87QuqoCQwdAel5iMQvgCKo/NmC+hhDy5LNldjH935YL8I5D3qDEYPhwBaSR2Z0fjOaagYj9tEE2d94nnJfy0eDXGbNPXEy6uN0yTZXNTDFBnV1nuwmEds+SVuGIHPk2+zt22ZIVdTvPfIo74NJBwtGV0O80YNnN9MbsbsjS06p0DDqUJbgRzq1nSK2iNI1tgPOxX3ha3LFnq2UEMeuh45D19QqlE6lBbIIXAf+f6cgOZd3ofTL6esOzyJpTXIAMwE32QmrzmjUw+FLYz28x3tq9hY5KMEXyTD7IN7bzP4NhwFxGDU2GcKyOiCEwJcqoQOFuMj1dwlN2eoeGYZhNRbil21mjCVQSa+68QtdCwlgayQVuT8vGkDTLshY8soMhxazUxRs9+K5CiYrwZ7WK8dB0+cqZQrWfDHNXkw2pm/rs8CagOrmHq3acGv5i1kv0lmnnM2LDfQ2SF8EhBzaYubyM3gm9bbX8aYLmI0SS4eyFjQ0y/rI2rTDwgHGEJtXYhZWNE+PaTJ+eAPcPxRAI= x-microsoft-antispam: BCL:0;ARA:14566002|16051099003|51005399006|19101099003|2604032031799003|704163111799003|37011999003|13091999003|8060799015|8062599012|31061999003|41001999006|19110799012|25010399006|15080799012|12121999013|40105399003|19061999003|11031999003|12091999003|102099032|440099028|3412199025|1710799026; x-microsoft-antispam-message-info: =?us-ascii?Q?583mfXen6Mcf+6N8jqSL54LaJIVBlLQShuVP/FobtVnWTBhPPScF86q7RHZ0?= =?us-ascii?Q?Ru7tPxaIzfCprph77DjJLFaVDiu3hYPrfWkSktGO7a69RWUrnrGWNTRi9ucN?= =?us-ascii?Q?v18/zs2v/Pq5JNkf/VkxJ+c3MIt7T1vo13dfDubpl9TisDActYf5G38unkK+?= =?us-ascii?Q?ENhpLZE61P5DB27ZiMGVjnHY1AoDrbo+7H7xFHguGYvT2NkMwcQpMV8TJvsR?= =?us-ascii?Q?hHzB5X6b2mxvTy3MJLBVKnzRfk7+T9wcxjHDmXGAkWcEzkL8mrap41yIMFIE?= =?us-ascii?Q?QNO0uJM14S8WA9NLDSuKcVINCuXu3dfANiCOreXLX0Zbe263o5D1bGLr5z/8?= =?us-ascii?Q?84bSDGtRzOBgDUk8b8bEoZ9yRD0yvhkaSf15I5IUQl4fuZQzUW/O5sK6CF4C?= =?us-ascii?Q?lbTMWz/YuDfSjn1dRhf3t6jNf5alNCs4TRB/XvKyzuDJ8lsCJOtPF5AQJphu?= =?us-ascii?Q?l6HCuFQeNNEUyFXEc7gK5E1nUUrIH9TvTTzRFedQz0Sinp2LPOwldQQFoVXO?= =?us-ascii?Q?Nreod1Vd7eGwOtH9ZYN0p+SZhcW4lHZQzozfyaKhOYnCG4OzshLakSzq3OMT?= =?us-ascii?Q?scLf+C12e9qXDDbsw6xr/hzck2mddyc45N9ic3hABTSO3v9i5AsfxbkgHlBN?= =?us-ascii?Q?M3jkgXzl9Ox3ng/rWoQQXzfawtg6gzY7WwkhT9VvUY3XQsEYr+yJ2Jkx6CAR?= =?us-ascii?Q?4fsV3Xe1gLxmTwt/UlDbfMwRb4bpkFFkeXJNGmOehHqRtUrr0fvmRnct9DmJ?= =?us-ascii?Q?Ziamcnp3SXdo0sg8T19FEqICzywxyKWw4ryVc2ZPnmlRSQ9gN3iVYmAj1lLE?= =?us-ascii?Q?ra9OpKmlModRZBR8jmRn8ty1kooLar4AbDQJHK6YXczcINKZPergSq8zfdv3?= =?us-ascii?Q?vKGhyUgxgOjIxhsor5N+gyWdV23ebh0sXNxgKFhXrBx1o4wwKO0AMXOpQaCw?= =?us-ascii?Q?kkxz2ZHCHb/0u/6t/3GH0r93VAUNRKLJ4Um2Mbefm8Q1GCKYAgCMQDSIYEaX?= =?us-ascii?Q?2nPkeoRmu4MQ6XxHfyIslv3mCYzwbmbe6hW37uLEIpGOSTQCMZuEIJIszBF2?= =?us-ascii?Q?TY1dHesSnZvcXasP/yDorZ06ypiJN0gYco2/sceilJ5TYWhvBBoTNd0uByXH?= =?us-ascii?Q?lohrZoV0BbwetyFbFKeyl4zj7VQyAo1cLczRUFdqUsWsnXv/+N5n/MwQ9XkA?= =?us-ascii?Q?5LaZBeI2tc+lkO+h2rAqkpaRL7UZ7LAx8zsvA2jk6U+gJOYK2j8i58uB1t1V?= =?us-ascii?Q?72yiTPFWK0GN7ESg+5qJZzfwb4QH6zw1kiPr65VKbkm1+MI3Nxl6GbMtROCD?= =?us-ascii?Q?HSw=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ooju6lp8Kv0IJer1HnQ3REULmZb5dOz25hSVv5ifBIxccmJfxbOBwAIB0ubY?= =?us-ascii?Q?4r0trWqslkalqnuJcBFBNpSYdINUBIyh/OBw/BtG21imZ7PAdk1IW+Lywt+r?= =?us-ascii?Q?Bfl/teca13r6hAANUGB9pTZNK7YevcV81SV5I54J9o5ht4hJPrrx+AOQ/fGM?= =?us-ascii?Q?jUDuabevRuiYA1zDkUJcSPP5sCoAAKceSfK6rwt3easEbonDache1r7GqdyO?= =?us-ascii?Q?+/RaD/Le9rC9lGRjMu/w63CryrPX3MwvUTtVNaOi3ec9e9wbKcNqGj9JX6CA?= =?us-ascii?Q?xolc1jnHpjbTuqJxXjVBYPf1g9mtmhYzKMTgYpIUmlMkIE0p0p4TBDZFfriZ?= =?us-ascii?Q?KSP4uQXJ2v3KYWw5hQIuMlvBvmqWzz/U8eot7GXoDAWHbslJq2khOGJSt9gj?= =?us-ascii?Q?+vTbLuT9b2rbyrXKKn6gzhUiZIVXyOWlfCi01i45GlLI52DxQEPZURSu+SUx?= =?us-ascii?Q?r06TjAN7AMvPoUklUBM1Upkn49w1R4y2nBXB+orLKt3QTqgc+qvLvHXXDi41?= =?us-ascii?Q?Fbu4PNcUs/JBTc5S/GOncMR1REsW+ckxeE2S8yPA3+7mE4VUa9updlrCpcfV?= =?us-ascii?Q?dPO1aN+PU/qLukk6FPj00zdgFzIuKhM80AGUUfPNZ3n9Eekyi9MYSHXWuV4n?= =?us-ascii?Q?zwXJr3nMGWp2a8ZhOC8nEZa15XRP/z7cNI14z3xbmfWZjixrG4Avdy0ZLMcO?= =?us-ascii?Q?tPM8Bw32dOSAdL7tMYSWjnTs8T/2XgePWc02dwYt/sxFlZkKfOwVcyP1hBAu?= =?us-ascii?Q?73iE7ri0MNsXA4nhiMJ0EKe7gg5I/1DqetHptC8nfLKLZByM/t3PGOLDqP5w?= =?us-ascii?Q?ZnVDVw177bgBd4R/+RxcdgUvOwGhgjcRZcsKuZxUGf7iNRIlpXLbsm4U1wJX?= =?us-ascii?Q?bD57Zwt4fHtZEiAPR6PB9iM+s9PZZe9oeOdLdFFsE0xpwS04S11n7wW+Tl0f?= =?us-ascii?Q?ua4L1GSkZUIe6GJSraQ53OKxVSQ6PqoVx155ECoQttE1g7LrsJwBLaBKgoEb?= =?us-ascii?Q?7gO+ym72UhXK7ZxX6JJERriyOuLXM4DBSUM02oUV7eO2vSCNob7LY9L6LxDG?= =?us-ascii?Q?gomdvZrna3E60aL4Q3nGlwxqjY1ofayQ3ExPN133bfg4ot1lh5ObaMi1KYB6?= =?us-ascii?Q?CcMnMbbEFr0SRJxI+KzrJEG/xPGJw1MpxWDZxPKRSDJQS5n/sNWtrq48Ky5P?= =?us-ascii?Q?zGW3ajxvruWow4SliJ0eYE9KKdDTb/Et/RpH8+blxlH6lLpEUt/92E6NtIbF?= =?us-ascii?Q?912JXJ8ZY/xCk9L39VWnEutHAMwkxSqdcDaqSaGSFkq8WMCM10Vy3vKY4D4U?= =?us-ascii?Q?DLT4elQRFike6WuVODeauQxJusObRNqow0JuTsi1F9Ni4RRJ7Tu3V8dy/TUe?= =?us-ascii?Q?OR8U0lo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c3577bdd-ddd7-41d3-8060-08ded8621392 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2026 17:48:07.9363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR02MB10144 X-purgate-ID: tlsNG-d62444/1783014493-D16DE1E0-B09061BB/0/0 X-purgate-type: clean X-purgate-size: 6262 From: Sean Christopherson Sent: Wednesday, July 1, 2026= 12:32 PM >=20 > Pass in a PV clock's save/restore helpers when configuring sched_clock > instead of relying on each PV clock to manually set the save/restore hook= s. > In addition to bringing sanity to the code, this will allow gracefully > "rejecting" a PV sched_clock, e.g. when running as a CoCo guest that has > access to a "secure" TSC. >=20 > No functional change intended. >=20 > Reviewed-by: David Woodhouse > Signed-off-by: Sean Christopherson For the Hyper-V changes, Reviewed-by: Michael Kelley > --- > arch/x86/include/asm/timer.h | 9 ++++++--- > arch/x86/kernel/cpu/vmware.c | 8 +++----- > arch/x86/kernel/kvmclock.c | 6 +++--- > arch/x86/kernel/tsc.c | 5 ++++- > arch/x86/xen/time.c | 5 ++--- > drivers/clocksource/hyperv_timer.c | 6 ++---- > 6 files changed, 20 insertions(+), 19 deletions(-) >=20 > diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h > index fe41d40a9ae6..e97cd1ae03d1 100644 > --- a/arch/x86/include/asm/timer.h > +++ b/arch/x86/include/asm/timer.h > @@ -14,11 +14,14 @@ extern int no_timer_check; > extern bool using_native_sched_clock(void); >=20 > #ifdef CONFIG_PARAVIRT > -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable); > +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, > + void (*save)(void), void (*restore)(void)); >=20 > -static inline void paravirt_set_sched_clock(u64 (*func)(void)) > +static inline void paravirt_set_sched_clock(u64 (*func)(void), > + void (*save)(void), > + void (*restore)(void)) > { > - __paravirt_set_sched_clock(func, true); > + __paravirt_set_sched_clock(func, true, save, restore); > } > #endif >=20 > diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c > index 5c1ccaf4a25e..232255279a6e 100644 > --- a/arch/x86/kernel/cpu/vmware.c > +++ b/arch/x86/kernel/cpu/vmware.c > @@ -347,11 +347,9 @@ static void __init vmware_paravirt_ops_setup(void) >=20 > vmware_cyc2ns_setup(); >=20 > - if (vmw_sched_clock) { > - paravirt_set_sched_clock(vmware_sched_clock); > - x86_platform.save_sched_clock_state =3D x86_init_noop; > - x86_platform.restore_sched_clock_state =3D x86_init_noop; > - } > + if (vmw_sched_clock) > + paravirt_set_sched_clock(vmware_sched_clock, > + x86_init_noop, x86_init_noop); >=20 > if (vmware_is_stealclock_available()) { > has_steal_clock =3D true; > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > index 07e875738c39..5b9955343199 100644 > --- a/arch/x86/kernel/kvmclock.c > +++ b/arch/x86/kernel/kvmclock.c > @@ -158,7 +158,9 @@ static void kvm_restore_sched_clock_state(void) > static inline void kvm_sched_clock_init(bool stable) > { > kvm_sched_clock_offset =3D kvm_clock_read(); > - __paravirt_set_sched_clock(kvm_sched_clock_read, stable); > + __paravirt_set_sched_clock(kvm_sched_clock_read, stable, > + kvm_save_sched_clock_state, > + kvm_restore_sched_clock_state); >=20 > pr_info("kvm-clock: using sched offset of %llu cycles", > kvm_sched_clock_offset); > @@ -367,8 +369,6 @@ void __init kvmclock_init(bool prefer_tsc) > #ifdef CONFIG_SMP > x86_cpuinit.early_percpu_clock_init =3D kvm_setup_secondary_clock; > #endif > - x86_platform.save_sched_clock_state =3D kvm_save_sched_clock_state; > - x86_platform.restore_sched_clock_state =3D kvm_restore_sched_clock_stat= e; > kvm_get_preset_lpj(); >=20 > /* > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > index 7473dcab4775..83353d643150 100644 > --- a/arch/x86/kernel/tsc.c > +++ b/arch/x86/kernel/tsc.c > @@ -280,12 +280,15 @@ bool using_native_sched_clock(void) > return static_call_query(pv_sched_clock) =3D=3D native_sched_clock; > } >=20 > -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable) > +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, > + void (*save)(void), void (*restore)(void)) > { > if (!stable) > clear_sched_clock_stable(); >=20 > static_call_update(pv_sched_clock, func); > + x86_platform.save_sched_clock_state =3D save; > + x86_platform.restore_sched_clock_state =3D restore; > } > #else > u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock")= )); > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index 477441752f40..8cd8bfaf1320 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -566,13 +566,12 @@ static void __init xen_init_time_common(void) > { > xen_sched_clock_offset =3D xen_clocksource_read(); > static_call_update(pv_steal_clock, xen_steal_clock); > - paravirt_set_sched_clock(xen_sched_clock); > + > /* > * Xen has paravirtualized suspend/resume and so doesn't use the common > * x86 sched_clock save/restore hooks. > */ > - x86_platform.save_sched_clock_state =3D x86_init_noop; > - x86_platform.restore_sched_clock_state =3D x86_init_noop; > + paravirt_set_sched_clock(xen_sched_clock, x86_init_noop, x86_init_noop)= ; >=20 > x86_init.hyper.get_tsc_khz =3D xen_tsc_khz; > x86_platform.get_wallclock =3D xen_get_wallclock; > diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyp= erv_timer.c > index 220668207d19..8ee7a9de0f4f 100644 > --- a/drivers/clocksource/hyperv_timer.c > +++ b/drivers/clocksource/hyperv_timer.c > @@ -570,10 +570,8 @@ static void hv_restore_sched_clock_state(void) > static __always_inline void hv_setup_sched_clock(void *sched_clock) > { > /* We're on x86/x64 *and* using PV ops */ > - paravirt_set_sched_clock(sched_clock); > - > - x86_platform.save_sched_clock_state =3D hv_save_sched_clock_state; > - x86_platform.restore_sched_clock_state =3D hv_restore_sched_clock_state= ; > + paravirt_set_sched_clock(sched_clock, hv_save_sched_clock_state, > + hv_restore_sched_clock_state); > } > #else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */ > static __always_inline void hv_setup_sched_clock(void *sched_clock) {} > -- > 2.55.0.rc0.799.gd6f94ed593-goog >=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 02 17:48:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Jul 2026 17:48:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352308.1609140 (Exim 4.92) (envelope-from ) id 1wfLWb-00087m-IK; Thu, 02 Jul 2026 17:48:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352308.1609140; Thu, 02 Jul 2026 17:48:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLWb-00087f-Er; Thu, 02 Jul 2026 17:48:33 +0000 Received: by outflank-mailman (input) for mailman id 1352308; Thu, 02 Jul 2026 17:48:32 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfLWa-00085M-K0 for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 17:48:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfLWa-008Pbt-0f for xen-devel@lists.xenproject.org; Thu, 02 Jul 2026 19:48:32 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a46a462-2eae-0a2a0a5409dd-0a2a4506bc76-34 for ; Thu, 02 Jul 2026 19:48:32 +0200 Received: from [52.103.12.22] (helo=BN1PR04CU002.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a46a46f-08de-0a2a45060019-34670c168653-3 for ; Thu, 02 Jul 2026 19:48:31 +0200 Received: from SN6PR02MB4157.namprd02.prod.outlook.com (2603:10b6:805:33::23) by LV8PR02MB10144.namprd02.prod.outlook.com (2603:10b6:408:18f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Thu, 2 Jul 2026 17:48:27 +0000 Received: from SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6]) by SN6PR02MB4157.namprd02.prod.outlook.com ([fe80::900:1ccf:2b1e:52b6%3]) with mapi id 15.21.0181.008; Thu, 2 Jul 2026 17:48:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=outlook.com header.i="@outlook.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ieEeUfKOgC00JIcY3PvHgwK7QYDQvGSCasQvpxg6c8IH7ncCF09epUR7IORg7pwa1yzjTTnRDBmQfxNAlUJEwsdHgcLJjkqYmnkt2tM3Ib2sXeUE80hbPZvhwjPzUTiyrpbnq7s1CKbp7Ux3T3unDi+ZLE/YFVdk+vFUHLDk2RadfBsfpKnnVVPsP2cxn9col1omt8zj0yHkoQH2oSs35Qh5ColbY5Y/wxCBZ3t/wla9l0nIV9Sl1S72iCdIk0Lev32HMOC5TsWSqOytSAcRePbN9PTZbS5N/TzFNmXc//HWZjSgGu6K/tHCn9ewIdHYdFcLSBhSKXMD/WUZ2a83DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NbBFbp/nzUuGrsjGnl+g4Yfp6IgxX5osOjXE0eNcIFY=; b=VG3s8DbNm0ylTYmmX0zWdJvU4dLxDOU8uW0u2fuPPDx4OyjnhCiyj1MRa7H4f2k9bvNQ2ewKmx5+t9xs3KQRKgZQ6SJQwzlBHF18ZsvWxeCqxe7YIY0QuPb1w6RqCbrFqVd2O+a7+IqIkqT1aOk7/jRTrhg5li9IYaaDrvhPZ6E8o1d9a6PNLM+JU53PI6iWh7RN6TiM+W4qjYFWdRR+BtJaH5rvbFL7IOfAH7oFmZ69xRhCB2YjzSfVbTBMAiE+cX7nGjcehn44Wn3UsCWa32Y9LcSooamEPMxfJwUL5tIlLyBF4mqfNnth0FxKFbhs9l9ZTC1jf4wEpDJ0pOPrdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbBFbp/nzUuGrsjGnl+g4Yfp6IgxX5osOjXE0eNcIFY=; b=R7APknHlBYFtJGoVLN5EBazyu5cgiI9bcsty7hyFb13oOSvuxvDls2gyoPIlZoeVg8NV9phoaMsMu+B9P1EopBpCZkj5HWwoVxsljT1mDpn4Kf5ZzqPy0tmGbM18+HiAl9nwUgsmRYk1DV1LTMY9wJPCyHw9VPlOheU2/lGwhRgHw1HWbDGHaIKXEDzuoI2dWpifmqf1D3Vif4VxbG7t9tZg61ffJawpS4SI8cqcSz9yu0SdVxX6oqDdT9y7Oa1O66XNOi9q4SJG9eTLE4zDxgubRJquL/hQL7udfZNSZF0vpCSYtOojHpBjNPZv4dcOAao4yEogaDQsXAxc0YlmHw== From: Michael Kelley To: Sean Christopherson , Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Kiryl Shutsemau , Rick Edgecombe , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz CC: Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , "linux-doc@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "virtualization@lists.linux.dev" , "xen-devel@lists.xenproject.org" , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Michael Kelley , Thomas Gleixner Subject: RE: [PATCH v5 47/51] x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC Thread-Topic: [PATCH v5 47/51] x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC Thread-Index: AQHdCZB9X/lWZeCwrUy8v9Xjt7LqZrZagtZQ Date: Thu, 2 Jul 2026 17:48:27 +0000 Message-ID: References: <20260701193212.749551-1-seanjc@google.com> <20260701193212.749551-48-seanjc@google.com> In-Reply-To: <20260701193212.749551-48-seanjc@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR02MB4157:EE_|LV8PR02MB10144:EE_ x-ms-office365-filtering-correlation-id: 5bf48bad-71fc-4fda-a241-08ded8621f36 x-ms-exchange-slblob-mailprops: qdrM8TqeFBvhuFgLLe5qs4jWk9CHdv0AYy8cQ/QUVhQUEcb7T5SCn14eOaFpictd8GSq+faiQenIYJC3hGGrRCyh+R4fFG3ungSx8vvHg6Tjppm2dQnX30ASlF2J96QIDukoKi+xo7ESP1SYnfq23VqRdmy4dlG1AImTkwtYVhea+dWishLk7ttaDW5e2MCVTeygprhy6mIjolk5/1ZkSCiLgGXo/7gwBvYMwpsk/fFicMxPgE1dL52nd/rhroAqmrRKfO+NNNgpZlYYEt2eDv5KwnzFeljrtJ3b6MadCUpbo6jUr6cKoQIKhKAQzjb++BfqdoPQWSANfgUv9sVrqwoNJFtrgJ0xG5h1yPAVKiYuNLEYW9ZbyML6iQU+b2tNL0uDDuwRReAvWedIRwzl2V0XzfR/JVqg8nGAj0sMpdrgdGvZmpt87zaFiUuILg0yDo8iTQRZ3MaGZcIh2sRuGfHJAlo6AU+LJWJoOqUgCyguuK/Zblb6CFmUxoDfAznroIyLhua0X/accY6iVlFXFEJJ/jdlNdan73cTEXblbhVTQbGEQbV/43vfoQopcX5g2ROdfHk3BJJweSzOR5U29C143Rh5etZR1sVjLbPSr4/ifndXV6afz5bxvfPGRxqRRrULlrDQYWa776RnE3r4cN84Q8De9cD6C6M0tpxkns64W++g7SC/15nyqLx03lOosuKPf31tAMBbtHUB/3Ev2QLp0nsFrqt8v/79G33kP2t0BfC0NZBRp0EGQoTcV2rCju4mAXp1g+O7/fbjSJnS7lWGyb1FRNMk x-microsoft-antispam: BCL:0;ARA:14566002|16051099003|51005399006|19101099003|2604032031799003|704163111799003|37011999003|13091999003|8060799015|8062599012|31061999003|41001999006|19110799012|25010399006|15080799012|40105399003|12091999003|102099032|440099028|3412199025|1710799026; x-microsoft-antispam-message-info: =?us-ascii?Q?5q25IsYCsTrASI9NXfU4P8ec+nkHfyWyOIdXMISJZkyJv0QJ7STvp5XcT1W7?= =?us-ascii?Q?/QKhsM5M3Miw6nR+GJ6iwocnKGOnuL/6RkuMyjUY3MpNToGlVOkxjLb+8nT3?= =?us-ascii?Q?+fFDQWdp/6r9O1Jc+EGvh2PUBXWRRqp28RUTSaXZNxmg4kFfaAvKzjbSFuTo?= =?us-ascii?Q?TqDqyzBlR6mdHcE5kz41tPHZiScYWwAhhR+IH8jMMREKrxVO0pdIuRfF2U3l?= =?us-ascii?Q?opBVxRkyjKFv7VXnnoOTPiBSlf6Oh0JMz5p5F3GWpYwCZcRNoyTGhk3Tuvzh?= =?us-ascii?Q?f+zyK+U2GLO2hhXDEjjmNdqg6ZJE/17O7gxDFW/j4bED5LKa1aPzDt2LifD1?= =?us-ascii?Q?PavW6l8RW/bmbbUPXpoMFkM1UjRXHf4R6q+A8uyeaUVUYTfEujzUvulKEWhY?= =?us-ascii?Q?lmhylgj8nZGoxzB4Mg6Db82p8IAvfqWRJHopDwP+2qKeX9sAEsEBoIXsgtX7?= =?us-ascii?Q?kj5UdvFVAI9F479/BOhDgRS9g01bef0+khEuvG95gNCWP8jh8vULlZThaSqo?= =?us-ascii?Q?9cjUoxk1uOWXSVQhdh1GSCCZwEiivnIv3WB+gf7lC1g7eKw8jDG3pKgSKgDy?= =?us-ascii?Q?XQRIqrWsh/+s/FhRUVEzJRiymsoRNQqnfR/YwuM57Dd33lP02HkKFsMfrc5Q?= =?us-ascii?Q?DZaavCwuekpRC9PUpiLvK/7QmyYuCBRh5D/PCK/SwvXRf58DNKFM72HZB9C8?= =?us-ascii?Q?d60fJGMNhaolO2amArN70YOnG9mdjpj2kGAD7Xu8m/p0qtBLXvW4/DPWrAuN?= =?us-ascii?Q?lmdf4lv8h36ypDREoeUYLgJcJlLy/JsmRGKaGUj4GhRRl1u8MYs6I05wjcHI?= =?us-ascii?Q?WvfocHk38DfI1bMfRXe3rXkPDXenVW6WgaV0badRV7kxbWsEUoHt1Rhh7Sbf?= =?us-ascii?Q?keTVebboyDJqEh+q1dh1RjWbX2LHTW3shgPTEenOVvu16/SADvIMwRV1SthY?= =?us-ascii?Q?yPYEBgnTjbsVTl9dmWaSw16Giy4xdtrHNYOXe8/FOzN7ZLjlfRvxwExp/WBA?= =?us-ascii?Q?HCOE4TrHVGz0CcQ4T5dPSHolsfLYmeKIDvaqbExVwEq6Scck1/x8rhQWXsoX?= =?us-ascii?Q?N3HXqjHt5BoNS4vFRJNJO1gmxRtBcsfeeQkZsvKPSWirB/oKkKQxPdiiTYVx?= =?us-ascii?Q?3Ep2Ifg1ZvbXynIkGkm5HIZK7kEmQIodZLFwYFmCKrAXnDBqz6AxVgMwO80x?= =?us-ascii?Q?kYOb8ZVrEng6XqO7NM7f3GWeHViBVsmUDrJ7gw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7ZODV6s9+KgwoUB9aH93lAXzLBMUrLUPS6UpHgZTToRjFFPgYrhYHnGagxox?= =?us-ascii?Q?z5xnafvLdobfSsJY9UmQbFDepqNijntrvvz9mJ/2aor1u0ClTVJFtHVzuPMa?= =?us-ascii?Q?eVR0QU1Ex9kgHxXryv9nlRbKaVVsv0I9Ao12/ePQRyzD4TmOG65wwEGqvLge?= =?us-ascii?Q?Nbd2MrQI9qX4j5MS0kzCCXLdvj0AIWY1yK3fcLBPoMIcYgnikE9M9SRSvXCp?= =?us-ascii?Q?KIvQqwobbHXjb+hClkOz4blrKqZE+0eijqFqYVji15kEAZ+D3hU4WLi0Y40L?= =?us-ascii?Q?9pwn1kfnIBAHmxoThDW/Y4vso5XmizuweJbViqyycyq3Md+d8oRCvBr4WaBk?= =?us-ascii?Q?tJIcrjjJnNnB1iSmx17WQ6Xf7snGDPLfbCFRIQH5bCpAca0rHsySxFwLL6C4?= =?us-ascii?Q?Kz1b6DAGMHvGzRa+4vf+KLp4jCGH00ieS9scORtZutlhZWmFh3K07vqywkMp?= =?us-ascii?Q?8XIO1YKikGOXuJTWa9c0+XRBZlHZJtfASPJ7FHfVDectRzVWdUYOS2x9kfuj?= =?us-ascii?Q?qBPwsXEylWkjWW8hKm3W5z5jVVfKdICUbqeum9S2nFDkltjMAUoDZcKPg+hZ?= =?us-ascii?Q?GRvgfD5shKwi0tVO4BR657VS5yHHmaDjxHi03txTRzckmEWLpps3ep8kM3Hl?= =?us-ascii?Q?BvbNuptg4i0r3setc4pHerG9YbaOhtc5jGL6pA85bLOw3kgONsAzlIDLd/0p?= =?us-ascii?Q?FbOEMHbixneKp451NYZ+D7ODJyI08ydYOGv2lwUTmWCkVCffLeDIbfB8/IZi?= =?us-ascii?Q?D/NzRZu4OZm+49Fmnml69sq8z79Q1jROgKiKSdYfDpjh+7BhScgrq9JiXcvQ?= =?us-ascii?Q?9pKcto81Te9x9HCYf4gelvZ8oL3SPam2fV2N621arFvM1gphFNUxivUucnWM?= =?us-ascii?Q?NeLzFim7/IQFP2WM0n2EMfk+qwGY09T3Aw5Rt+2o+QWyeYwjeSQ8r/6+8RwQ?= =?us-ascii?Q?jyTyfgi8YHhdSoe+weDeCFNj27v9HMzk5WOulPd3BnlkGd2jLsuVQYDSFe1G?= =?us-ascii?Q?VIOv0JuLrxnBENW3AOQzgq3kt7bZS9EbVr5Kz3esENIJaX1bk2ff5fKi2mWZ?= =?us-ascii?Q?L9UeJcI81yWWpQY2uumolT/EJwNxRXViH5VlUgr9q2r3BCw/l8AT+aGyH2UU?= =?us-ascii?Q?MRZgCf4h+ssxwRiddWTLXvwv3Jzj0MM8wZidGxhEeWHfAh8OlhOK1oOtj/yS?= =?us-ascii?Q?QBWyD6Qjn2dV4IGzcJb47teDLTv4873vJhGIzD2CfUKnpYT+U8aQxrI452q8?= =?us-ascii?Q?miyTh8sSu+2SESot8bC3VX6aHBvM/zuCAOC0xmBKyYR3FrwTjAmzeymOF9HG?= =?us-ascii?Q?ftisthux+koPRFIisQZ5TyogjMEGb0FEQmPFh/s/e+JT/h5xCsOeZDuBJywh?= =?us-ascii?Q?wZSjFIw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 5bf48bad-71fc-4fda-a241-08ded8621f36 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2026 17:48:27.4623 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR02MB10144 X-purgate-ID: tlsNG-16d1c6/1783014511-C712768D-021FBCAD/0/0 X-purgate-type: clean X-purgate-size: 1712 From: Sean Christopherson Sent: Wednesday, July 1, 2026= 12:32 PM >=20 > Silently ignore attempts to switch to a paravirt sched_clock when running > as a CoCo guest with trusted TSC. In hand-wavy theory, a misbehaving > hypervisor could attack the guest by manipulating the PV clock to affect > guest scheduling in some weird and/or predictable way. More importantly, > reading TSC on such platforms is faster than any PV clock, and sched_cloc= k > is all about speed. >=20 > Reviewed-by: David Woodhouse > Signed-off-by: Sean Christopherson > --- > arch/x86/kernel/tsc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > index 012321fed5e5..a146fc7b5e74 100644 > --- a/arch/x86/kernel/tsc.c > +++ b/arch/x86/kernel/tsc.c > @@ -283,6 +283,15 @@ bool using_native_sched_clock(void) > int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, > void (*save)(void), void (*restore)(void)) > { > + /* > + * Don't replace TSC with a PV clock when running as a CoCo guest and > + * the TSC is secure/trusted; PV clocks are emulated by the hypervisor, > + * which isn't in the guest's TCB. > + */ > + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC) || > + boot_cpu_has(X86_FEATURE_TDX_GUEST)) > + return -EPERM; Do a pr_warn() in the error case? Your commit message says to do the ignore silently, but I wonder if that's a good idea. At least for Hyper-V, the error case shouldn't happen. Michael > + > if (!stable) > clear_sched_clock_stable(); >=20 > -- > 2.55.0.rc0.799.gd6f94ed593-goog >=20 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 05:57:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 05:57:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352825.1609149 (Exim 4.92) (envelope-from ) id 1wfWtT-000150-Nv; Fri, 03 Jul 2026 05:56:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352825.1609149; Fri, 03 Jul 2026 05:56:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfWtT-00014s-Ie; Fri, 03 Jul 2026 05:56:55 +0000 Received: by outflank-mailman (input) for mailman id 1352825; Fri, 03 Jul 2026 05:56:54 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfWtS-00014m-QH for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 05:56:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfWtR-00FyMx-O3 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 07:56:53 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a474f0f-2eae-0a2a0a5409dd-0a2a450393c0-26 for ; Fri, 03 Jul 2026 07:56:53 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a474f25-ec1a-0a2a45030019-d1558036edef-3 for ; Fri, 03 Jul 2026 07:56:53 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493b61b52b6so806025e9.1 for ; Thu, 02 Jul 2026 22:56:53 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a4a09sm15441046f8f.13.2026.07.02.22.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 22:56:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783058213; x=1783663013; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IemmhEklWXsMozzSGD05TXsrjHUQafyMg5AZqO6fdiA=; b=UiVBW9qo5C0JYh6EN07ebuD0fkO2qfN9MT1RvW+1vecQl++BwFzW5iWE4g2Ygn2ozI CcEBHVntNRIRn2HjGB4khZ6MDcL6BcVlBm5UflFOytZjCNdPd+dVbykinWAg9GCddX3I QZCkh8D1cDKbltYO6kMRcQ19mOKm+zD5LEOUKBcGlIaMfsQkB+TleMxBCwkz5mtRCH2a LIVgLqA8q8h7HameBY5pTdo53Ytu9kiXLERqyyVYRXNX5sNaUFTRxCOlrwGzMsXcUZ6z fvgLP6NWIGhiKMZdTE+o9w9Jo3pNZ80rFP5l9nnJVhAwertRAYfgV3k5fw0FYZxvJ2SP 6HVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783058213; x=1783663013; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IemmhEklWXsMozzSGD05TXsrjHUQafyMg5AZqO6fdiA=; b=QvZky4efeqgsznVahAsjjrS+ewmGMC/X5HUfWCT0RLt4Axqo3AdqwHq103WzBCsyEd 83qmWnPQ2kiA3OOqGrfdZ06ulGM+eFhtz2p/LdFYaNEGY3iUohu/cSVxs6P2sBXJkXFv saSexx/91TJ0GxinSiwr62NphHQbnan2R7BjaZDUc8EAuHhFa+J4JJHuO7kHz5YIARfq V2LYqekYtHaszvLLiibvOgIUfBrQ05JoqEGKx2SbnuWhEQ55G2ED1bqiDyHjdsw1k7ts jl13R2rCi/LrEub5s3uthdWB/PbC19VaerYzfmk9QPoLEWQQbvMyCd1MlEZSueMcfnM/ TgYA== X-Forwarded-Encrypted: i=1; AFNElJ8FVtQ52kyiXGnM7nQaNv6XvZ9/qwGjevLLZ9s3kqzAmsrBPWZ6GTRkaVYS58ndyBLjTqFruqqP3Rc=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz07nzxY5YSouhqr7qhOJ+QC9Ul4FjBzRLmSUxcwLHay/6yja0P QWZXyqa+Hyr017pcoqTvXCKiiSN11nOf5g7w/ggB2HBw6BOTF/dFXYiUMbFspjygyw== X-Gm-Gg: AfdE7cm+S83/HKMvWsOL+BXF2wz5Vk6710IWHdBFQfCATfW2g/lnksDINd1Gj4B/ZG7 cKMLFe4HRSSInHQ9boWBoC7MkjYPOnMWARaAQy38WnX5woE8IFVeUfhlnYnOViEr6THo869ZYUS nuDlc8TM7vJql6PMRWgBbyb5IATVFYOzF2X/wyAB9NWoliZfiF8pslMhj28mqHN3y7rlWwTI6ba w/5BfO/ytMmEZvGVJwdpbexybeDpYPCtHoCbcTFsLxUrcZB068DMNSpS/lL7SRRo0/ngLi2fISE MkZrPBB+NknkSD3v9kOEAgflzU2AlOfqVrRClbfzFbKQJDfMPxRx8UGKmZ0CvQbtbkN0Qe2G/3+ DkHE37sD8j0V/Ftrqxo8Xftt4lOLm4g6HjVtLV4vpHxzruwPs3UMkV1f4JJm7872vUAt7avgmLx HqIxir22KWXCcjimQJcndzx3IbSzklaNzbkdP4gJO4e6HXAFz9pO2JVuckcuh5/N/dKz13bewLb gno X-Received: by 2002:a05:600c:4e4c:b0:492:465c:56f6 with SMTP id 5b1f17b1804b1-493c3cd54f8mr125599585e9.10.1783058212811; Thu, 02 Jul 2026 22:56:52 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 07:56:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] argo: fall back maintainership into the rest To: Roger Pau Monne Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini , Christopher Clark , xen-devel@lists.xenproject.org References: <20260702163845.36453-1-roger.pau@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260702163845.36453-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1783058213-B55BC5D1-F7D8F105/0/0 X-purgate-type: clean X-purgate-size: 433 On 02.07.2026 18:38, Roger Pau Monne wrote: > Due to unresponsiveness of the current maintainer. In particular, the > committers have been trying to get in touch with Christopher for 2 weeks to > have a chat about disputes around recent commits and pending changes to the > ARGO component without getting any response. > > Signed-of-by: Roger Pau Monné Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri Jul 03 05:57:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 05:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352832.1609158 (Exim 4.92) (envelope-from ) id 1wfWuP-0001ZO-Uo; Fri, 03 Jul 2026 05:57:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352832.1609158; Fri, 03 Jul 2026 05:57:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfWuP-0001ZG-RE; Fri, 03 Jul 2026 05:57:53 +0000 Received: by outflank-mailman (input) for mailman id 1352832; Fri, 03 Jul 2026 05:57:53 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfWuP-0001ZA-5x for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 05:57:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfWuO-00GO1b-Ij for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 07:57:52 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a474f4a-5cb7-0a2a0a5109dd-0a2a4509b3a2-34 for ; Fri, 03 Jul 2026 07:57:52 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a474f60-97e6-0a2a45090019-d155dd2db488-3 for ; Fri, 03 Jul 2026 07:57:52 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-476d8e647e9so165987f8f.0 for ; Thu, 02 Jul 2026 22:57:52 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477dd94ce4csm15725644f8f.17.2026.07.02.22.57.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 22:57:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783058272; x=1783663072; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Kx2Mq9CGUh/oNjMiYpEYd6BlsoDVRLUSWd/QFyojYHw=; b=del1suS9xsKQcofqpYrX0lMjWDS2KQM6FFVhJPo3I2c3C4FoSAq8LMMfgKy5TezMTf xQ6pM+ZIwqvu2tkLcxUTFPDenj/rZG3SJSmbs5m3UKJPtIpDtKob0tXXtNovGt6u3001 jyFiN+Nc0Yhuvm2IqXYaWHIhd7SaEiz/Q9Mge0fQfOZyrlC4aj8Zqmd7bpiUUQB5JFKO WVAy+iw/HPpsUs94aP7yF8FhPDfbVDqPK/OKXNXUk4jsBPAiBl/RNm3Ba5EPg795w/MR ZGWTvNFv5Kx7CG5BSFoNpw/jCNlwasXncwVTafgiIxBBN2iwblfTWjHB/iKGpXL+JGU6 bTJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783058272; x=1783663072; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kx2Mq9CGUh/oNjMiYpEYd6BlsoDVRLUSWd/QFyojYHw=; b=o4lcM2PFWwwWJEeIP07hsYiskzawQJDDUV91ATWod2i3ybGATZoA9Txp1UPXxpU4UF L4pqoqvmzx/kZuw79D8hVbC1wvg0o+3hjcbLmC1ojxlskp/wVz7zfsMsgTqlseBV+QHv kGYjXsuIWr143lrMQRB2/9Hrcc2zrQ6SkG1yk6uYUvpNPUuiggOt8h0HLqPhCUv6GvXe Lv7ys0RcPbx29v3wHKJnm/dYNgZXK562D8J3B8mdbkx2S1iEy6M08+JxBCNObQbMtVks C8+n5Lie06gzYqOxA5GZdjIBbbA0wuRRWFUH6R+DtRKNI8gCEJMQJ1eOHwVGgBuV++MO MYEw== X-Forwarded-Encrypted: i=1; AHgh+Rqki7Ht0OrR5rZImQEERw21bYmVpO+kUBCo17xdpM2es29U3mcC51IKsb+FFVslggqbB+FUaj/B94w=@lists.xenproject.org X-Gm-Message-State: AOJu0YzJy7YVARFIRX2tKhjI0ZJDT3WFpEAD90VKMMyHIyJSlFG8TzA6 S1CEVVdjJ+zUmnMBTrPtJwo8HCSWclanx132gBT44QnD+XAJtJDXEoQeoc08z55T8Q== X-Gm-Gg: AfdE7cn6sSQcJbHshf2tAUuUZ3lGckUPMt9lu/b0sv9LA9pji9RZOkrhq4eIymkd6QK IROC7MsAiu0BzgJ8hNqdjlkO3FZfF59sZbTVVIiqQun0IfpK+hYd4E2zORW9U9fIKxKNCXyw9Qv nN+mBDdC2h3Xbe9fhTck8z2IBgLNBFYoD3gQ3gwsNiHhi4Iu/okceglBTpaetZ1wfaB/78sAA+O QrPmAlpqmNn70tT5BVdJ/akQpdIZvZOQsXvempQzJkdp2tUnu9Icx+6dHPf5i3NLJwXdR73BGqP o/DAlc0ZEyK5wlbGjdipdRm0hwtPAtEMsGX4FuHNQmAJ8tgPFNGsZlflv0/nESxNC2mJrAFQcmI 3VXaV8noywbjqwL/5jLzp9EquSnc+6kNLB8hRcE7oMI8MyCK+tl2+9p4sAU4SFGxX6p2qPaDkz0 7WrzqZlSbripvXogMjE7nJTEoRmmgVCPexLa1PVNqI/epGSYVdOi43mV1MQyFhfxmERMRe0q0g3 tR5 X-Received: by 2002:adf:e009:0:20b0:475:f0d1:eb6d with SMTP id ffacd0b85a97d-4775cf541b2mr10111727f8f.58.1783058271895; Thu, 02 Jul 2026 22:57:51 -0700 (PDT) Message-ID: <9efb193c-8657-4046-b417-4cd7cdccd2eb@suse.com> Date: Fri, 3 Jul 2026 07:57:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] MAINTAINERS: Add myself as an Argo reviewer To: Jason Andryuk Cc: Christopher Clark , "Daniel P . Smith" , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20260604184413.788910-1-jason.andryuk@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260604184413.788910-1-jason.andryuk@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1783058272-4532F986-08FE423C/0/0 X-purgate-type: clean X-purgate-size: 285 On 04.06.2026 20:44, Jason Andryuk wrote: > I'd like to help with reviews of Argo. > > Signed-off-by: Jason Andryuk With reference to https://lists.xen.org/archives/html/xen-devel/2026-07/msg00196.html Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 03 06:26:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 06:26:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352856.1609167 (Exim 4.92) (envelope-from ) id 1wfXLk-0005ya-2j; Fri, 03 Jul 2026 06:26:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352856.1609167; Fri, 03 Jul 2026 06:26:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfXLj-0005yT-Vd; Fri, 03 Jul 2026 06:26:07 +0000 Received: by outflank-mailman (input) for mailman id 1352856; Fri, 03 Jul 2026 06:26:06 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfXLi-0005yM-3D for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 06:26:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfXLg-00H54x-Nj for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 08:26:04 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4755e0-bab6-0a2a0a5309dd-0a2a4505e232-36 for ; Fri, 03 Jul 2026 08:26:04 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4755fc-3cb2-0a2a45050019-d155dd2dbdc8-3 for ; Fri, 03 Jul 2026 08:26:04 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4798bea72f9so123583f8f.1 for ; Thu, 02 Jul 2026 23:26:04 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477de3dd53fsm14981470f8f.37.2026.07.02.23.26.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 23:26:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Autocrypt:Content-Language:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783059964; x=1783664764; darn=lists.xenproject.org; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Osy0sYEvcEVc3wSdb+rsl4BwKV2b8jJ9NOV+BOqJ2/M=; b=JhsZ66IHs7razkBPCBqxKrm2z13cwm1yKuThK02Hjkj0veJcbWRGtGT2eRbdmqQc+n YIovpar/WfTZjUURimhV1xOiBep82Y2AlFs2EvqpWKYIpspce2UDe70Iop/Dr33qb6CC WkwJBHdUKFbcTxKgaTE87gwT2ZFXQ4MYV10rmii03ZZnsl9jXimganjIVNr6G8xTMTG+ 0aTpqW78RwZ706j8hfcnTlHXvsFA+giAdJJBAd7gf0gfCxeYI8QG7MT6dLV1obilepsA 8h5eTqIUgv4nGWhZn/aiTxw3avnL/LtS5R4x7QYCVeu8EuGDRRzrmJsgnaYCtdgrNbuN 4qeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783059964; x=1783664764; h=content-transfer-encoding:autocrypt:content-language:cc:to:subject :from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Osy0sYEvcEVc3wSdb+rsl4BwKV2b8jJ9NOV+BOqJ2/M=; b=Or94vcgSk+fVb3h7WgJT/YSzxadka8TkshuwF4bwCwqYnpR0Ew6N2UN1mLDyVA/z3R ekA7kZ1H5RUWCYEhC2HDRo9PoUEO1ekdkzZgHcsm3p3ta+bTAa+P/Dm+ldsjd1+b2kH/ WZ+WBTlOv3O7EAPvBuR8HL6GGUpwK1rLTNQD3pptuUWSgTvVTfD0b1CZZsX6qzhSrAIf zu0uDe6p1iFr4GO2e7T0MQLaYGt0LyHR7TlGwoiOjzpozvjASBhfknMXIt6T9GUKIBo8 kVoeftfv+geavYijufPRzJlxmSCtz691qR6JgD6uFEVh8lS4ye24G6eoYWTirSdSEnnm LmPA== X-Gm-Message-State: AOJu0YxheNfh01oh15OckPwtyKynFWLSpXft9IO9vQTJBoWaMnrN+xMk El7ZT19D7ocV54SqgDeZ87JZ/6aB3AaodYVlZDi2L+/HiHzB7GdZ7rT55cReuhbIaLorLk1LLnR dzhST0Q== X-Gm-Gg: AfdE7cnG6GwkptKqXpx+fYHLx8DE14YRE3kFeOwhLI4/nPWrMsVOjtftw3R0G/uBDe4 xRoFciK3YJxCfH1dDq34gimGjqqhklqMVoJ+tmhDolcYR3wF2PjSUJK1Or0LWMZxYXQUlIk4FQW SDiOCtcldjAo0XDK38wvF0rgD9Nmbt9G7yf6PaZlaSBjmwytuOsM8djJSpjy0tPaTarL8l+eeDB SMkKY7sDRCxwuk8ITt+chQSY8z00ElFC5IiSK3JKXF0Ejwylw+vZok0LQeg94eDsWtKzhVGBye8 IXGYXa3rL6aNAjWZn0CrypsRYH2Jnd9rtTFm6H4NWFgh9324MYpOYBbmKKVMKOrn5pQsL0XqrUY BSCTEx3e0eLFTeHwyF/K24ihzJFf8+4j7ZQDdlbLjB9sI4DnVYT4k6qydHPIu7VlCc/q45YoJPX PptUB9pjEZvH/sk9XhdKCxJbmdyDh9soaZZpjtDXoBsRvWKz04NqhAWJ8ucM/RfrDjC4zyBVpVY bj0 X-Received: by 2002:adf:e001:0:10b0:46d:9871:1a44 with SMTP id ffacd0b85a97d-4775a0fcd6dmr9531248f8f.32.1783059963849; Thu, 02 Jul 2026 23:26:03 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 08:26:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v2 for-4.22] x86/cpu-policy: set up host policy earlier To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski , Teddy Astie , Oleksii Kurochko Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1783059964-15F0F2B8-52C46047/0/0 X-purgate-type: clean X-purgate-size: 3274 In order to use cpu_has_* expanding to host_cpu_policy.*, the host policy needs setting up alongside boot_cpu_data.x86_capability[]. Arrange for that towards the end of identify_cpu(). Then make sure .x86_capability[] and host policy remain in sync when setup_{force,clear}_cpu_cap() are used. Rename the function now it's no longer static. Fixes: 894bd7617924 ("x86/Intel: use host CPU policy for ARAT checking") Reported-by: Marek Marczykowski-Górecki Signed-off-by: Jan Beulich --- This really was part of one of the XSTATE cleanup patches at the head of the AMX series. This explains the specific placement ahead of the call to xstate_init()). Likely anything from there downwards shouldn't really live in identify_cpu() anyway. --- v2: Call calculate_host_cpu_policy() from setup_{force,clear}_cpu_cap() instead of from init_guest_cpu_policies(). --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -66,8 +66,10 @@ void __init setup_clear_cpu_cap(unsigned __clear_bit(cap, boot_cpu_data.x86_capability); dfs = x86_cpu_policy_lookup_deep_deps(cap); - if (!dfs) + if (!dfs) { + calculate_host_cpu_policy(); return; + } for (i = 0; i < FSCAPINTS; ++i) { cleared_caps[i] |= dfs[i]; @@ -78,6 +80,8 @@ void __init setup_clear_cpu_cap(unsigned __builtin_return_address(0), i, forced_caps[i] & dfs[i]); } + + calculate_host_cpu_policy(); } void __init setup_force_cpu_cap(unsigned int cap) @@ -92,6 +96,8 @@ void __init setup_force_cpu_cap(unsigned } __set_bit(cap, boot_cpu_data.x86_capability); + + calculate_host_cpu_policy(); } bool __init is_forced_cpu_cap(unsigned int cap) @@ -586,6 +590,8 @@ void identify_cpu(struct cpuinfo_x86 *c) } /* Now the feature flags better reflect actual CPU features! */ + if (c == &boot_cpu_data) + calculate_host_cpu_policy(); xstate_init(c); --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -359,11 +359,18 @@ void calculate_raw_cpu_policy(void) /* Was already added by probe_cpuid_faulting() */ } -static void __init calculate_host_policy(void) +void __init calculate_host_cpu_policy(void) { struct cpu_policy *p = &host_cpu_policy; unsigned int max_extd_leaf; + /* + * Bail if the raw policy wasn't set up yet. At least recalculate_xstate() + * can't be used yet in that case. + */ + if ( !raw_cpu_policy.basic.max_leaf ) + return; + *p = raw_cpu_policy; p->basic.max_leaf = @@ -904,8 +911,6 @@ static void __init calculate_hvm_def_pol void __init init_guest_cpu_policies(void) { - calculate_host_policy(); - if ( IS_ENABLED(CONFIG_PV) ) { calculate_pv_max_policy(); --- a/xen/arch/x86/include/asm/cpu-policy.h +++ b/xen/arch/x86/include/asm/cpu-policy.h @@ -30,4 +30,10 @@ void recalculate_cpuid_policy(struct dom */ void calculate_raw_cpu_policy(void); +/* + * Collect the host CPU policy. Called after collecting enough CPUID output, + * and again after all feature overrides have been put in place. + */ +void calculate_host_cpu_policy(void); + #endif /* X86_CPU_POLICY_H */ From xen-devel-bounces@lists.xenproject.org Fri Jul 03 07:21:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 07:21:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352912.1609192 (Exim 4.92) (envelope-from ) id 1wfYDR-0005Y0-1d; Fri, 03 Jul 2026 07:21:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352912.1609192; Fri, 03 Jul 2026 07:21:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfYDQ-0005Xt-V6; Fri, 03 Jul 2026 07:21:36 +0000 Received: by outflank-mailman (input) for mailman id 1352912; Fri, 03 Jul 2026 07:21:35 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfYDP-0005Xn-Ew for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 07:21:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfYDO-009EYT-Gj for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 09:21:34 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4762ea-e002-0a2a0a5209dd-0a2a45019242-26 for ; Fri, 03 Jul 2026 09:21:34 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4762fe-400f-0a2a45010019-d1558033b42d-3 for ; Fri, 03 Jul 2026 09:21:34 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493c733f15aso2108745e9.0 for ; Fri, 03 Jul 2026 00:21:34 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c0e92687sm157586555e9.0.2026.07.03.00.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 00:21:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783063294; x=1783668094; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=njq/POdC0ep8atQorNWA20dk/rulCctxQiil69IKqHg=; b=E+Q37yFpRxKoqdeuHzQGhbZvl0LX3E2AJ4LjML8Kx5bVA8oK9JX1cYRg9JMRint7MJ gY7yPt6m7HmG/Yl91jOYL/UfYnVZv/1WsJEb2Q0Ozv+f805pefEs4lJ+1T8p8srwkW42 m3f/Ic3kx6NBr265BEqs17GirEUYsFF2FuTAl+NpVuOGlV/UNAkIWBGCoUjC27vwCA3e 0MVWEuRzAR6rIRF/l8hHL4+AVRqkqgedYhEJTuMRbEom3psQ8eRS8SYjEgt9P5rcaG4y EJMD1tBMyt0jmzZhcKtQAlk4OrF0niSF6bbZDfY0G25eJJLH13Z6xtOHJE6usYZPv9FI rIEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783063294; x=1783668094; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=njq/POdC0ep8atQorNWA20dk/rulCctxQiil69IKqHg=; b=aqXXhRlBCvXD097RGXc8b2Zj29kz1GoCpm/5DBYGYhloQfO4v7pHUV2bIwHCSDUpzw uzyfYDfD/Ld8KzmlTzmpnSD5Ybb9PAHfYb6sRgDIRf3JkfqrzVwN5KfLQ3XHqaPPbnJ8 Mlf5X0poL/TRtgUzeRx46b3DVlJJe5AzWAyyCdueiG5cwV7HmpV3Wcgvs4ZE7lCd+QBg LoRzJ3flv9OdOQFKazeC1nzPSKdP8V4Lls+QXLtOKIz9Mfu9Y0XZ7UNOZmCgRgByTZE4 6dhmNqjwmHU2EROPLdiww6e2Kp29ovWYdsQSzsHLEl/JoEh9vvjZxXxjgT2NqLjSqsQh iSeQ== X-Forwarded-Encrypted: i=1; AFNElJ/MkojeoVZJ8877PhI8a+/qN4WXQTmL8XPOQxTK8J422koclIGPvavnAASqbfhbdzcASeroxtSl/4k=@lists.xenproject.org X-Gm-Message-State: AOJu0YykaWa4HR2b3ZrpQsX89f3Pz1mZl5RUkbWorMc402haWNvkGWS+ g43CtlbJInnC0lXbTD6GR2OwCpcZKfTf/sDLeO9Nl5soBcbSB6rUhrOzBQ9YcHypuw== X-Gm-Gg: AfdE7ckkx47QngciCDvTdqBuH9rajlXSws5wcjNNpAutof42AFNm9EPfp4WjiAQPqfT xnwEPIU1qA86FNpZfmYzLuQiJghnozwEq0wW7oUko7aymt7jkGHpQBn+o5a7Q9UojqJtaWDNkWG ss9u2IRWF+4t2Gz4PHrhY0EQQxgqFoJfZU9BjXRF6Mfw+Aucp/BXQK/xxxe6iIcrQcmDdi/GndC y/C4Nbim8oPVXZy/GoZrZ3/ci/z3L6oHw/MQBWyyhv0Ikvrk2PF9+PrXqwch0Np7iYnp25mNyFa caPMVHA+2o8h2OuIIROhkrNo9qvxjDI2wcmIy9AMeJWLrR2cJklxusMZbuEVSm5MRrd+vA8R3cO cGHFy/vKIXAYeK98Z6dWL1wED41kWpOoZGZ8XSNQTYeu3NwYmQsdZJkYIG3ydFhF61H2TxwYIfl FOjYGRSi6CRT9CyiCut+RC8gzXhQKOCsXzlug8jQL6ZiyhuuHWlTKN7o1soPgRvUSrK2ZAwTuPR MOd X-Received: by 2002:a05:600c:3e15:b0:493:a8ff:d7af with SMTP id 5b1f17b1804b1-493c2b15c9bmr129669105e9.4.1783063293517; Fri, 03 Jul 2026 00:21:33 -0700 (PDT) Message-ID: <9a8c4ef2-ae6d-48bc-bd41-6c3147acaff8@suse.com> Date: Fri, 3 Jul 2026 09:21:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/25] xen/riscv: implement IRQ routing for device passthrough To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <472a77604d35a0bc2a75b71f250fd67b63afde4c.1782487661.git.oleksii.kurochko@gmail.com> <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> <40bcf6b7-306a-419a-bf12-1855f9e589fe@suse.com> <91ffc1b2-7648-4185-a2f1-12b30181c8a9@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1783063294-FF4CA1E0-AB9AEFF2/0/0 X-purgate-type: clean X-purgate-size: 3110 On 02.07.2026 18:04, Oleksii Kurochko wrote: > On 7/2/26 4:32 PM, Jan Beulich wrote: >> On 02.07.2026 11:33, Oleksii Kurochko wrote: >>> On 7/2/26 8:38 AM, Jan Beulich wrote: >>>>>>> + spin_unlock_irqrestore(&desc->lock, flags); >>>>>>> + >>>>>>> + release_irq(desc->irq, info); >>>>>>> + xvfree(info); >>>>>> >>>>>> If, in release_irq(), action isn't freed, it's ->dev_id field will now have >>>>>> a dangling pointer. (I think I did point this out before.) We'll be back to this if ... >>>>> It should freed in release_irq() as route_irq_to_guest() always set >>>>> action->free_on_release = true; >>>> >>>> Well, "free_on_release" must exits for a purpose. I.e. there must be, now >>>> or soon, cases where it's set to false. Else simply drop the field. >>> >>> I can't simply remove this field because it is part of the common >>> `struct irqaction` and is used by other arc-s. (I assume that it is not >>> what you fully meant...) >>> >>> IIUC, this field is used to determine whether an irqaction is >>> heap-allocated (and therefore should be freed) or statically allocated >>> (and therefore should not be freed). >> >> Yes. However, all uses of the field are in arch-specific code. So in >> principle it could be #ifdef-ed out for RISC-V. There may be a better >> option, though: >> >>> At the moment, all IRQ actions are heap-allocated (on RISC-V), so >>> free_on_release should always be set to true. In particular, the code >>> snippet you asked about releases a guest interrupt, and guest interrupt >>> actions are always heap-allocated. As a result, when release_guest_irq() >>> calls release_irq(), the associated irqaction will be freed. >>> >>> So, from what I can see, the current behavior is correct and I think it >>> should be left as it is. Do you have any concerns about this? >> >> If you only ever have the field set to true, use ASSERT() in place of >> if(). >> > > It looks like that if we want an `ASSERT()`, it should be in > `release_guest_irq()`. However, that would require duplicating part of > `release_irq()` to locate the corresponding `irqaction` and verify > `free_on_release`. Since guest IRQs are created through > `route_irq_to_guest()`, which always sets `action->free_on_release = > true`, we are already safe. > > I don't see much benefit in replacing the `if` statement with an > `ASSERT()` in `release_irq()`. The current implementation is generic and > would also work for Xen-owned, statically allocated interrupts (even > though there are none today). If we replace the `if` with an `ASSERT()` > now, anyone introducing a Xen-owned, statically allocated interrupt in > the future would simply have to revert the change and restore the `if` > statement, bringing us back to the current implementation. ... such a change was made. Imo you have two choices: Deal with the issue properly right away, keeping the if(). Or assume "free_on_release" is only ever true, and add an assertion to this effect (indicating that code needs auditing if that assumption is broken). Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 03 07:58:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 07:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1352940.1609201 (Exim 4.92) (envelope-from ) id 1wfYmn-0001Cn-PI; Fri, 03 Jul 2026 07:58:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1352940.1609201; Fri, 03 Jul 2026 07:58:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfYmn-0001Cg-ML; Fri, 03 Jul 2026 07:58:09 +0000 Received: by outflank-mailman (input) for mailman id 1352940; Fri, 03 Jul 2026 07:58:08 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfYmm-0001Ca-Bv for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 07:58:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfYml-00AaF8-Os for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 09:58:07 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a476b8f-2eae-0a2a0a5409dd-0a2a4507e994-0 for ; Fri, 03 Jul 2026 09:58:07 +0200 Received: from [209.85.208.178] (helo=mail-lj1-f178.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a476b8e-9c8e-0a2a45070019-d155d0b2cc3c-3 for ; Fri, 03 Jul 2026 09:58:06 +0200 Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-39afb0d9f7eso3011291fa.0 for ; Fri, 03 Jul 2026 00:58:06 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13c4acdsm283255e87.76.2026.07.03.00.58.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 00:58:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783065486; x=1783670286; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WLuTWbOCGUpepJm0WQVVJLBtO432gPwRh4dR2sQxfh4=; b=CENsmDGGll90igdUxHbTvLyphvTVYxVgFspOwRlVaaUcB/A21kuWj5JebxfJPfpUYh dxQ9Mj6mv19bN0/g0pQ8osWT6bxtmESsYqNrMa2Ud7xg1Eoq4t3vK/wOjIho36k936kt Hc1+/Me8S3vEp+iAYN655chCA5xR024R3P5ZV02ERXt0H7g+a5faDLKG+EWLGgAnpaW9 jq1ixsokN57dZvrTG28Vqsm10BEQNfBH1XA3DVS4uA6NVFhWTqR2AUnU3S8iqxOEN7tA zq5TMBmTVJS9Fu1IocYcy5NpkmT/GA4KBwgGsukRfLWVbbVvJB0I9jRS7k2yvvYxcUjP nhZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783065486; x=1783670286; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WLuTWbOCGUpepJm0WQVVJLBtO432gPwRh4dR2sQxfh4=; b=hPC7sq+WMcdeUeMdp11qBbnIJ5qZyK1NTaBXNinCpJ00wnkdqjr9PGBI4WI/8h4Lbv 0y5xLFfcg/tsDAopXEVSRhVPR0uXJCO0Lu6yA4a+tywez8uQe5eBRfaEp0rXIEfALvQ/ IzvyA7K5bRo3acwAvCqXqHP7Zn7zefey1rNDL4gKEZo3GDMLdSjDWEc4EPhz78d15Akz u0/71m0h0gewluDBUM8geRzr6dSR8g8SSNuOXrcu4yh5mtAKwScJXty/JjBU06cLMonb hX1nX8HhvwUb0VqjQqcKsndNrJwgc1o6nZzPQqDYfgOgoyigBSMWsG1eUWzq7RbWDPdn nAww== X-Forwarded-Encrypted: i=1; AHgh+RpOWPc8IVVJUUIHeyIBF6FMSD1x0r8kDJtHe46rXdVJvH43DUy97ZKkvh538XtavjpBmT+VIk26IY8=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw8JpgUWn8Iweo1G4cdQg95HfWnmYHXuwi1/CcJHKs/naDRUT8y IhrdKmNRgYjK292m7YvE78lnxzcO/60Ii60l9HgghWKQRlK+/KlH4MDu X-Gm-Gg: AfdE7cnY/tIJrSUpajVbuhxsbcpSTU0DDXpmYjPEe27NK4o18SFVM6NZsg+af2GOFcj LsCd4SJXhlxNmIhP3hDsS4em4WqVF1znNVEoN2PAy9Dqtxv7iBEVhkEZQqxDmNpBxXeFVnD3ikq H0cwL+V3i8RZ4lmUFgRY3wbQf49rCQQGVDJrb1GX8t+yiaAFja/NNs5MnpNTQT/n7aqs1b9FBJd jXsfkUH01QeqhWgL70tIBA1gYzQ8aa+T/T/vBpueYEFd50yna2yrzj9haw5ElmSRwY06HsjhIdV Y7JEG8+rXwbXyTewCE0YGLk22RDV6qa/xTRKo8pjWz2atwfc2LSi+B0YQoX9D8Y4kZeVUrzXPNQ EDlWvqDVbXzSxRGhcSp07q51S9R/x3C7CVml6qDuPvhzHVfqVCAECw54sIa1SNv6RxVa6b0yaam kqtIqih+jSPNtDdFNZP0HWYlbna8Pzb+V++g766oUAvKFzjKxEtGzjnixWj8uM4VA9W5E= X-Received: by 2002:a05:6512:138e:b0:5ae:bcf6:b07c with SMTP id 2adb3069b0e04-5aec6795a7fmr2066254e87.4.1783065485964; Fri, 03 Jul 2026 00:58:05 -0700 (PDT) Message-ID: <5a4024d7-370a-4519-9191-42c64c614847@gmail.com> Date: Fri, 3 Jul 2026 09:58:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 for-4.22] x86/cpu-policy: set up host policy earlier To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski , Teddy Astie References: Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1783065486-7F53025E-1AEC714D/10/73395122804 X-purgate-type: spam X-purgate-size: 694 On 7/3/26 8:26 AM, Jan Beulich wrote: > In order to use cpu_has_* expanding to host_cpu_policy.*, the host policy > needs setting up alongside boot_cpu_data.x86_capability[]. Arrange for > that towards the end of identify_cpu(). Then make sure .x86_capability[] > and host policy remain in sync when setup_{force,clear}_cpu_cap() are > used. > > Rename the function now it's no longer static. > > Fixes: 894bd7617924 ("x86/Intel: use host CPU policy for ARAT checking") > Reported-by: Marek Marczykowski-Górecki > Signed-off-by: Jan Beulich Release-Acked-by: Oleksii Kurochko ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Jul 03 09:16:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 09:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353029.1609228 (Exim 4.92) (envelope-from ) id 1wfa07-0004cI-8y; Fri, 03 Jul 2026 09:15:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353029.1609228; Fri, 03 Jul 2026 09:15:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa07-0004cA-4o; Fri, 03 Jul 2026 09:15:59 +0000 Received: by outflank-mailman (input) for mailman id 1353029; Fri, 03 Jul 2026 09:15:57 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa05-0004CO-EJ for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 09:15:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfa04-00GN2P-RH for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 11:15:56 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a477dc6-2eae-0a2a0a5409dd-0a2a450ace40-18 for ; Fri, 03 Jul 2026 11:15:56 +0200 Received: from [52.101.125.115] (helo=TYVP286CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a477dc6-e40e-0a2a450a0019-34657d733221-5 for ; Fri, 03 Jul 2026 11:15:56 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TY3P286MB3731.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3d3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 09:15:51 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 09:15:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aLQf9NjWFAp0sgYXR18wZlVg/+WBL1XhhzCuFFSa2YTAVJVYMICZeO4I6K35UUMjbt4mrsy2qDe77Rp7m3Bf51boIW8Fqd32UyQKDZT9VVTwGakSK/03W0/S1CtkgGubAoEkvF4iguTzp86j8flI23e2jRRSTlbqufDERIW0RjQrHjTdSgyt9Jj6I9OdnKectMb1ryXKLwPd91LaELnLiwLsBQNwHc1wnLf4APmc6pLCllN5dZmLLEHvJ4ffHWTXaJQdiuRjrud9uBbUOZChgXf/aOYsIW9ZdEtaIosZab0Z+cjXzpKhBoP7y0ZHoKi5yJRGZZ+SZ1M/dnMvvACc6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+YHhlMJ0BRCDYFFnZBlOKPtPhGxi/edvzDAP34FGr24=; b=NsYvwOpSjf9vS+JCTcngE8sLnQkwc7UojEJkKIjDO34iNzeF0T/M9FoTWJao+S4Ryt2hp9JOn6nC+fqeKu1Xc0P/TVBZ6YNm1eJPAN19MzJnPBypqydbUXRf4yHAmDQomnJJvTZBbFAoG2xwH0QVKKijGLKao8y4RIhiVMkNA0uu4LoncwPzIJo5/B2lggyvv2RIZ0SCA3gTNMOK0TtF9hyMgtHYmco4HeNpvVJd/widtHrwrcQZMmt4LgEhIw+eI3laLeHjFOMYxWmGKoyCbuh4trG6BJNmpp3q6DXrr/DsHgMZmvarpx0ySJG8CVWeYw4RrZ4KOltp0Y2YStyy2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+YHhlMJ0BRCDYFFnZBlOKPtPhGxi/edvzDAP34FGr24=; b=S73jlVwO/nBJ5kW3IUiFk+6QGyNfHhcIZ/W++QIYEJSl5S93Db6GcKl8kfTPW9b7/gcFaLXgGf2tuehwKxjAfFscOrHBeoI5dpMRQk+yjFQ/j9YBTkwknpfcur8Czt2V6aBzGWHv2u+CGxLaqlrW7A6SP0E9wnPfEGbBfxJG+bY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Hirokazu Takahashi To: xen-devel@lists.xenproject.org Cc: Hirokazu Takahashi , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Timothy Pearson , Alistair Francis , Connor Davis , Oleksii Kurochko , Dario Faggioli , Juergen Gross , George Dunlap Subject: [PATCH v4 2/3] xen/sched: Link CPU topology to scheduler Date: Fri, 3 Jul 2026 18:15:43 +0900 Message-ID: <20260703091544.183548-3-taka@valinux.co.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260703091544.183548-1-taka@valinux.co.jp> References: <20260703091544.183548-1-taka@valinux.co.jp> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TY4P301CA0066.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36a::19) To OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9P286MB7222:EE_|TY3P286MB3731:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bb621b4-27f9-4158-1e13-08ded8e3ad3b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|7416014|376014|10070799003|6133799003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: nA6/Gz9DLhADgr6Uqb4vb8g/ivN7hfVWeBPFRkSrrFRqZXVc5mqcceZusHmkG4cOolrqdGuiFfa7GNDp9hiz8pNhdcJYw+Wnh9+21xBghhYswIM9/uIx0heSIM2QGSsryD/CJOz68YPojqRt5QQ7AeNF3KBQs2pob/tMLT4rBJ0ZFv4+FISDstVYbJHHU/8yGkDQzl1zK88EAhcETXYxS/bUHOJ4zUKp91wu6bWm5rS42JTETGQZ423dof71D9dBNMeIwz0B8j0pNNSya0lThgK0xgl88C2Q1WrbjCoQ8D5VjgaWaNVj9ACBf/RVqYeXatumWHFQaXywYir+dW3YY3yepjROTm5qyhhkh0QE26nHP1ApjN/OFtnE+SAgvMlVTc5IUNZu8QB2ObghrFu7SG14MELa6lNB1uDy5tMIMXMbRvSqZPhUL0/W+D/JcuzcHMEyyx4ot58qbSRF9Z87BTs/Ne1LO3z7Uwe/BvIAyV+ox3iSzHv/ILkN0oB73y05/k5hGm7bPWjCCT1eTBHjoziiTzqfUFCecNMlHE4VVhMnFV1RAItoavZ89Fxz5+Ex7Uxg79GW7qqfO6VrPEtElHLKYLf/2YW7sPsOtx46C2tpN0b2W+AHKMpd9ZHFpWWSjJvcDob0gLAqixKjWYeA7FQ18tEB0g/Lce4nMfKHevk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(7416014)(376014)(10070799003)(6133799003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0D1BFx68aW6aVfbvesUXY8qnLYpTgYMqvDI/zjEIZblavbahj17IdISxMZR7?= =?us-ascii?Q?zJrAs2gOk4PmK9DR4nUSqu+IMi4DlqpVuMuHBpM0HXOkT9d2lcU2vHEGZRUQ?= =?us-ascii?Q?d4SN0SnmA3kM5rusKqnWzyLsAvX02v7NqRHTgMbXX0R68LYmokg/uOCQbR4R?= =?us-ascii?Q?fQs9HpuPaiwixb2V5otqNTlU6U12G3cMisPtHQwQJm1PUb4zog1lvLXmj5JD?= =?us-ascii?Q?X7j5rsLRhEdYwY8Vno+s5T0/IWpohADqqSQnYS3WsD7oF/EZt7tUvJplYn3W?= =?us-ascii?Q?JMpBX4NlX4BAwlSjZT4hparUwKzV4SFxTdHuUp/j0t/+0knpQsaTavaN8JS3?= =?us-ascii?Q?gF//RuRiZtoUdLBXr25aH1xpECThf/9TcG07i6T7tiWznhkCHVPSSU4yHCq+?= =?us-ascii?Q?1kdZsc+Dicz41dOKlLaTDcVsMwuLTM7aYlkk/E2PEa2RVBIVh7m4NhdG5HQb?= =?us-ascii?Q?iaFuNx3Gf2MDKo4M3p2zWUQ471gvEwYMSvkfUGjI7TBXoj2VIMOAvRxm0oBD?= =?us-ascii?Q?1HbPPjsdi+g1t/ak7GAHBc9HMPZHTzhoWt0PDIf5+gjcFc766qXWTMhBT+1l?= =?us-ascii?Q?js8GCwarqWmkVBHGGqbwd2eQ7+iHjhfiuQC+Xfk6h7u5a72Kv71fz93BG4T9?= =?us-ascii?Q?sqSZfz0fOCIYJhrULkjc5AbAODl2gqYCJo1Pyj1Enk9/YOVGA4ief1m8Gl8U?= =?us-ascii?Q?dablmPisjYCRWEaVtScoq+NeNwf0TErHANS9ZtuRNodGz0Mjcc8jmkTyHS7V?= =?us-ascii?Q?by1y56iAddykWGmKDYC3hoc+Wl4n7ehYuazWWCQQMphr4cx974wJXemHUbIY?= =?us-ascii?Q?bfzCuNTJEs9TIOGO5jqXdSz3v3pG5RENCouhI6muQ4E5hfOTcxNqmSFIvD9M?= =?us-ascii?Q?BzuAncAHkwBe4u8LL+cKpuvPEeBh2mL3slGXC1CoorfXJyP6A50qmFuMGKA7?= =?us-ascii?Q?7PFM6ZnueCjq6jdwqu8dpPFi2eW5crNUFneE/jXKMWTOEsBsnygSgidopipa?= =?us-ascii?Q?XWvFTsHueAzPHL0gp6ohfxl9HZGpcudtXNVfMU3HbPyHrDqUjhk11oK3ubAX?= =?us-ascii?Q?yq9Brn4yWZZFyEwoPtIgGde4OGDrOhls5dA4ryQlZV4xW7FbeFhYeAz80xki?= =?us-ascii?Q?8rIGA4uTrW39NQa4t4DmFq4Jmna2d/GYHieUmgsSqZx8UXSdoLAikCSY4Ztc?= =?us-ascii?Q?YwdM+HCCkU1TB7I8xT1FqYPrx/DcVSpAAzLkLiqpIHuP+BNBpJglG3hDnCrf?= =?us-ascii?Q?hAMJx1MEDHUmvo9AV/lmuYFgDIbWdDh6vL3wW/y376nkpAzUkTVdlrn8tEqz?= =?us-ascii?Q?6KDZkxMVi6u6wav7AuQKaueJHqBIZoNPaqUsjr7nezX6tjR8BB3E93nzB6hJ?= =?us-ascii?Q?SE7gGOmRM7rgn9mep++85z6tPBO0M43LZ+NsFgGPNyyAJxxDY6cK13CAhWbL?= =?us-ascii?Q?ndVgsZ+zMtirgXUCfAP3+GiO5wtwVtXug7sb1XN6jV8s8M78ySCLmO8XwcZq?= =?us-ascii?Q?A+vbBrSI+pRF1ed2arYnOua9VN+Dba7a68fixxed74upp3hYRYpiFXZ93vvo?= =?us-ascii?Q?QGa+8q/5vMFSuMZ1mRQk+RkFTyaWz2pX/hPt9SgNnlkZc3JnWDVcwJkxauZK?= =?us-ascii?Q?K4dfY3ixGKtGHG7VOKRHHaWNUowLPZ/5BedddCDiZ/wXhYcSQD1fbifDMPVz?= =?us-ascii?Q?nVQESFmozWbjobUJTG+fVy4SGYk72M71L1sH+FElPQNKITf5rfu2scGE75Gh?= =?us-ascii?Q?0JH6RDH2UUAhfHvIxIh8T046+0QVTQWjcOHaZH6+VlM/O2zzcZIOVLNuegeE?= X-MS-Exchange-AntiSpam-MessageData-1: x9kPTIBldMY/0w== X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 3bb621b4-27f9-4158-1e13-08ded8e3ad3b X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 09:15:51.0417 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y4EaEG/NesYEwkb1Vgnv91kV8OexUC+y+UesgDFni0vdAPuYU6GhQjS/Gbe2ZmYjfX5m/3WzO/In61hqPvEQ2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3P286MB3731 X-purgate-ID: tlsNG-4011c0/1783070156-D5D23DDE-8CB46B54/0/0 X-purgate-type: clean X-purgate-size: 9565 Make CPU topology information available to the Xen scheduler. Additionally, ensure that this topology information is displayed when executing the 'xl info -n' command. Signed-off-by: Hirokazu Takahashi --- Changes in v4 - Explicitly #include in cpu-topology.h to guarantee that arch-specific definitions of cpu_to_core() and cpu_to_socket() take precedence over the generic fallbacks. - Introduce inline initialization functions for cpu_sibling_mask and cpu_core_mask in cpu-topology.h, providing separate variants for both when CONFIG_GENERIC_CPU_TOPOLOGY is enabled and disabled. Changes in v3 - Remove the temporary definitions of cpu_to_core() and cpu_to_socket() from RISC-V and PPC processor.h. - Minimize the use of #ifdef blocks, leveraging compiler Dead Code Elimination (DCE) where possible. xen/arch/arm/include/asm/processor.h | 4 -- xen/arch/arm/smpboot.c | 8 +--- xen/arch/ppc/include/asm/processor.h | 4 -- xen/arch/riscv/include/asm/processor.h | 4 -- xen/common/device-tree/cpu-topology.c | 51 ++++++++++++++++++++++++++ xen/common/sched/credit2.c | 3 ++ xen/common/sysctl.c | 1 + xen/drivers/acpi/topology.c | 3 ++ xen/include/xen/cpu-topology.h | 45 ++++++++++++++++++++++- 9 files changed, 103 insertions(+), 20 deletions(-) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index a3753c317f..41fa73cfc4 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -613,10 +613,6 @@ void show_stack(const struct cpu_user_regs *regs); #define cpu_relax() barrier() /* Could yield? */ -/* All a bit UP for the moment */ -#define cpu_to_core(_cpu) (0) -#define cpu_to_socket(_cpu) (0) - struct vcpu; void vcpu_regs_hyp_to_user(const struct vcpu *vcpu, struct vcpu_guest_core_regs *regs); diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 5ce2bcf6ec..3c9f2a5c53 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -92,13 +92,7 @@ static int setup_cpu_sibling_map(int cpu) !zalloc_cpumask_var(&per_cpu(cpu_core_mask, cpu)) ) return -ENOMEM; - /* - * Currently we assume there is no multithread and NUMA, so - * a CPU is a sibling with itself, and the all possible CPUs - * are supposed to belong to the same socket (NUMA node). - */ - cpumask_set_cpu(cpu, per_cpu(cpu_sibling_mask, cpu)); - cpumask_copy(per_cpu(cpu_core_mask, cpu), &cpu_possible_map); + init_cpu_sibling_map(cpu); return 0; } diff --git a/xen/arch/ppc/include/asm/processor.h b/xen/arch/ppc/include/asm/processor.h index 242346cab9..1bf6f6c66c 100644 --- a/xen/arch/ppc/include/asm/processor.h +++ b/xen/arch/ppc/include/asm/processor.h @@ -141,10 +141,6 @@ /* Macro to adjust thread priority for hardware multithreading */ #define HMT_very_low() asm volatile ( "or %r31, %r31, %r31" ) -/* TODO: This isn't correct */ -#define cpu_to_core(cpu) (0) -#define cpu_to_socket(cpu) (0) - /* * User-accessible registers: most of these need to be saved/restored * for every nested Xen invocation. diff --git a/xen/arch/riscv/include/asm/processor.h b/xen/arch/riscv/include/asm/processor.h index 6b89df4a2d..d478ffb76b 100644 --- a/xen/arch/riscv/include/asm/processor.h +++ b/xen/arch/riscv/include/asm/processor.h @@ -54,10 +54,6 @@ struct cpu_user_regs unsigned long pregs; }; -/* TODO: need to implement */ -#define cpu_to_core(cpu) 0 -#define cpu_to_socket(cpu) 0 - static inline void cpu_relax(void) { #ifdef __riscv_zihintpause diff --git a/xen/common/device-tree/cpu-topology.c b/xen/common/device-tree/cpu-topology.c index b653227ef4..43322a153f 100644 --- a/xen/common/device-tree/cpu-topology.c +++ b/xen/common/device-tree/cpu-topology.c @@ -330,6 +330,55 @@ int __init parse_dt_topology(void) return parse_socket(map); } +static void __init setup_cpu_topology_ids(void) +{ + unsigned int cpu; + unsigned int next_core_id = 0; + unsigned int next_cluster_id = 0; + unsigned int next_socket_id = 0; + + for_each_possible_cpu(cpu) + { + unsigned int first_cpu; + struct cpu_topology *topo = &cpu_topology[cpu]; + + first_cpu = cpumask_first(topo->thread_sibling); + if ( first_cpu == cpu ) + { + topo->phys_core_id = next_core_id; + next_core_id++; + } + else + topo->phys_core_id = cpu_topology[first_cpu].phys_core_id; + + /* Reuse the calculated core id if clustering is not supported */ + if ( cpumask_empty(topo->cluster_sibling) ) + topo->phys_cluster_id = topo->phys_core_id; + else + { + first_cpu = cpumask_first(topo->cluster_sibling); + if ( first_cpu == cpu ) + { + topo->phys_cluster_id = next_cluster_id; + next_cluster_id++; + } + else + topo->phys_cluster_id = cpu_topology[first_cpu].phys_cluster_id; + } + + first_cpu = cpumask_first(topo->core_sibling); + if ( first_cpu == cpu ) + { + topo->phys_socket_id = next_socket_id; + next_socket_id++; + } + else + topo->phys_socket_id = cpu_topology[first_cpu].phys_socket_id; + + topo->num_siblings = cpumask_weight(topo->thread_sibling); + } +} + void __init dt_init_cpu_topology(void) { unsigned int cpu; @@ -342,6 +391,8 @@ void __init dt_init_cpu_topology(void) for_each_possible_cpu(cpu) setup_siblings_masks(cpu); + + setup_cpu_topology_ids(); } /* diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 95946634d1..ada430f262 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -9,6 +9,7 @@ * Based on an earlier verson by Emmanuel Ackaouy. */ +#include #include #include #include @@ -37,6 +38,8 @@ static unsigned int cpu_nr_siblings(unsigned int cpu) { #ifdef CONFIG_X86 return cpu_data[cpu].x86_num_siblings; +#elif defined(CONFIG_CPU_TOPOLOGY) + return cpu_topology ? cpu_topology[cpu].num_siblings : 1; #else return 1; #endif diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 5207664252..81a68fe24c 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -28,6 +28,7 @@ #include #include #include +#include long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) { diff --git a/xen/drivers/acpi/topology.c b/xen/drivers/acpi/topology.c index 6bd2d96ebb..9155edc0be 100644 --- a/xen/drivers/acpi/topology.c +++ b/xen/drivers/acpi/topology.c @@ -22,6 +22,9 @@ void __init acpi_init_cpu_topology(void) { struct cpu_topology *topo = &cpu_topology[cpu]; + topo->phys_core_id = cpu; + topo->num_siblings = 1; + cpumask_set_cpu(cpu, topo->thread_sibling); cpumask_copy(topo->core_sibling, &cpu_possible_map); } diff --git a/xen/include/xen/cpu-topology.h b/xen/include/xen/cpu-topology.h index f64820febf..ee34425680 100644 --- a/xen/include/xen/cpu-topology.h +++ b/xen/include/xen/cpu-topology.h @@ -4,6 +4,9 @@ #define XEN_CPU_TOPOLOGY_H #include +#include +#include +#include #ifdef CONFIG_GENERIC_CPU_TOPOLOGY @@ -11,16 +14,56 @@ struct cpu_topology { cpumask_var_t thread_sibling; cpumask_var_t core_sibling; cpumask_var_t cluster_sibling; + unsigned int phys_core_id; + unsigned int phys_cluster_id; + unsigned int phys_socket_id; + unsigned int num_siblings; }; extern struct cpu_topology *cpu_topology; void init_cpu_topology(void); +static inline void init_cpu_sibling_map(unsigned int cpu) +{ + if ( cpu_topology ) + { + cpumask_copy(per_cpu(cpu_sibling_mask, cpu), + cpu_topology[cpu].thread_sibling); + cpumask_copy(per_cpu(cpu_core_mask, cpu), + cpu_topology[cpu].core_sibling); + } + else + { + cpumask_set_cpu(cpu, per_cpu(cpu_sibling_mask, cpu)); + cpumask_copy(per_cpu(cpu_core_mask, cpu), &cpu_possible_map); + } +} + +#define cpu_to_core(cpu) (cpu_topology ? cpu_topology[cpu].phys_core_id : 0) +#define cpu_to_socket(cpu) (cpu_topology ? cpu_topology[cpu].phys_socket_id : 0) + #else /* CONFIG_GENERIC_CPU_TOPOLOGY */ -#define cpu_topology ((struct cpu_topology *)NULL) static inline void init_cpu_topology(void) {} +static inline void init_cpu_sibling_map(unsigned int cpu) +{ + /* + * If CONFIG_GENERIC_CPU_TOPOLOGY is disabled, it is assumed that + * all CPUs reside in the same socket and that SMT is not used. + */ + cpumask_set_cpu(cpu, per_cpu(cpu_sibling_mask, cpu)); + cpumask_copy(per_cpu(cpu_core_mask, cpu), &cpu_possible_map); +} + +#ifndef cpu_to_core +#define cpu_to_core(cpu) (0) +#endif + +#ifndef cpu_to_socket +#define cpu_to_socket(cpu) (0) +#endif + #endif /* CONFIG_GENERIC_CPU_TOPOLOGY */ #endif /* XEN_CPU_TOPOLOGY_H */ -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 09:16:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 09:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353028.1609215 (Exim 4.92) (envelope-from ) id 1wfa05-0004Ez-U9; Fri, 03 Jul 2026 09:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353028.1609215; Fri, 03 Jul 2026 09:15:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa05-0004EK-PX; Fri, 03 Jul 2026 09:15:57 +0000 Received: by outflank-mailman (input) for mailman id 1353028; Fri, 03 Jul 2026 09:15:56 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa04-0004CB-EH for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 09:15:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfa03-00GN2P-GX for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 11:15:55 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a477dc6-2eae-0a2a0a5409dd-0a2a450ace40-8 for ; Fri, 03 Jul 2026 11:15:55 +0200 Received: from [52.101.125.115] (helo=TYVP286CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a477dc6-e40e-0a2a450a0019-34657d733221-4 for ; Fri, 03 Jul 2026 11:15:55 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TY3P286MB3731.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3d3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 09:15:49 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 09:15:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nHYMtEk5qw5V/ZvYP2pL4lQE2SCWEx8+w7C1BO7kR8feLzMu1KpLVZBfNywUCTrRU7K23pccdInHQA/q09+ikOGdlf6z0EW6jnCMzs0OvoGPzImUoQR6DjVcv9aBzcpixLemGPrtkUd8OOmSusHayE2EI2uTzCQxMFspWfCln7UVj3LCLVFcEMWGQijqjUKHwWKXeMu+29TqScj5U/okS080A3EQkgUY2HUCm0RkAhCzLJu85A4Q6EIyMSim25DQhTljQLW5odK/AsiKNN3MXKmNOm4F7vGO+Wy+5tzvv0tBFOASVLRTsrROivnMrPliBwt7qYyCJ/3fG0UJFc/c3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NThAHoBNg8DkdpKZCAuwHukZHxyXIkvelDPgBuO8Jxc=; b=WFGTDRfzqPB4V6Fufp325EvdULp4YuuHuV6DoKNuqB41f4JOb2IExNDXI08YK0ElAX/EuD/HaQ6NlOVNOoL9ARePPI6To4Imsw5h4C+8QTqLHVNI3clGIDd96hv4rfE6nvDlQ77QaieDYYqblfThOjNUizvKK0nHrZuXDwrGWhmnm54/K5x4+ASWoCtPurI3syzdahTUniVbYaXGQ3rEKbxWUFQqaR+42/ap98xC0695n2Eecx5alyDA0yu+5UE9IS0f55oOqmc7/dD75s2R4m2NqOieKX47qxdWUQYZqkC6I2Q3bry5x2QJV1pWfL3ub6BSKc74FFqKQb+WAwT0hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NThAHoBNg8DkdpKZCAuwHukZHxyXIkvelDPgBuO8Jxc=; b=iNylflYEbu3pAMMmLruqtBRGJGU5UDRPWATkgN/7/MsTP2QuuPsTkCzbJrSEpO5aWAaTDjTT/e8121bSTqInKkvUWbwXho8PZAW97KzQwyuJZA2YwaxFj/dRpi858PYbArl2/McUOIC6LqhnJt3Z7mFHQ5uEIC+s6OWj5Itg/pI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Hirokazu Takahashi To: xen-devel@lists.xenproject.org Cc: Hirokazu Takahashi , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Date: Fri, 3 Jul 2026 18:15:42 +0900 Message-ID: <20260703091544.183548-2-taka@valinux.co.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260703091544.183548-1-taka@valinux.co.jp> References: <20260703091544.183548-1-taka@valinux.co.jp> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TY4P301CA0068.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36a::7) To OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9P286MB7222:EE_|TY3P286MB3731:EE_ X-MS-Office365-Filtering-Correlation-Id: dc408169-b0e3-4f62-e9a3-08ded8e3ac48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|7416014|376014|10070799003|3023799007|29003799003|25016099003|6133799003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 7sDJ0od3F7aChrt6sTpQC536rY0xOISWjcEeS7jjTRkxXBmnqN2Ay277rHnabzXvEIYVdbsyYEZGqs+Iaht7o5cKReRgPXA8MNzck+kwG/Ef4vO63cJs+gpHubD7pyy8yfp0QuJf1PdGjnd3wO3kGV/WtyZE8id5Y+q7aG8L1L14B8TPUqQT44rUBBmUd21Fkhk6CLftu2m47u2yhYzAcdP6PEM3ExJyAE8syTMxZfm98X4QSc48bMRlwa+LXPRT7dAEDTPydpHCuc0aiTaaIZ5F67wEjlJOaw+cYDZWdpwM0tfid/Ynh2nKkD8i4S68gfpclDMa3gmfJ6DMA8O2rFacISrZZreiU5DCJQotYIPsnIdNz2oqxCA/d7yyKpW7Gk1LgmJvVo7nuV92YkhbzYnZp7RjmUk9MjDEU/qiKtpu15C9ffqmrrZ7JTSAk4tjTHTiC7M4cc1mhwWIPmSn8qVwcF1lsFzHSDbty0PIgukOvXka3WLE1++ZCsaLiDhKBJxNX/EzhYnh/N7IUbd/mUwmMTZBlACl1z0d9vOaOrSuuq+i6Q0gfT+hzKeAUQDxOxxDy2egd6fvqIw5xL8DdJlhUJWQBZ4bYC53oQdxwakzCZebH8MJkmOzKhUCWj0CCcOG8oUjaKmpeIIh/moVXNZ1LQOFiaPX66CjfqjqF2w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(7416014)(376014)(10070799003)(3023799007)(29003799003)(25016099003)(6133799003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uh6JORA60YRI0i+YuLX5dgLNcFkEgAXZP7p1Yn03h+vHi05RgaZtILKgpREx?= =?us-ascii?Q?AWw+6t8J2jKnKCSfMI2dDx4MjKViiufute/tT2ECtSfF5va1NTkscLd9bg2n?= =?us-ascii?Q?T41dJmKRGV2D42s/0mvUGqd+uw2HSxniyxL/s4ll1zat4Q73uisHhUN1ZdMv?= =?us-ascii?Q?32Cx/pMYKo/xX2nUNMmCZEpFwsoKbqHafjFh5dmcgDrMHcrSfkI3iIyTUFPD?= =?us-ascii?Q?hO7tMBhxc5cagdfrkg8K3vx3piVrq8PHTYpRReg8TssOMkgNHBeO7J5aDyVY?= =?us-ascii?Q?GGnHSQSedjkrWQKB7NhAz2yAoFTzAXUgfhQmb7GLFmfmUu1EGRbfsX+Sh0wm?= =?us-ascii?Q?JZijqC6NsZcaScSSeWMUjQE/g4hioJqaR/jBrOhkwGt08X1ydJktC1kV+YJH?= =?us-ascii?Q?ZX0gcDI8TExpbE29uUPCUYuwRrrFxHHNJLCd5eGm0yuqaJjP2xPy0vm50HZu?= =?us-ascii?Q?LHBI891XHB38X+FxWkLGswgxbZRdwJZg2GIXfw7iGEza6SlDTCbmPFUewZWx?= =?us-ascii?Q?Nf+pnCik2rc5+VbIS47MJkyiYxLpheJXa7KFo8mX31gqqCt025SC2lT37Qpy?= =?us-ascii?Q?vbnI+feihlxrjL60OZKLafeWK0Fly1SH5sOK/hDZDx1CHONSQ0szzmEuiqN6?= =?us-ascii?Q?+1p2Egf23dmhuqdyOOUCMBmBFkjCxrrDwLaKO2Ri6NtnVtBuSQF/nt5xYd0+?= =?us-ascii?Q?vVyFwnE3Or7TpHdtWh/mpcEYG0+1klBAfVV2LYDBUrcakqtgZX7d9PCFD/40?= =?us-ascii?Q?5HsKY/w8m7rircmyQ3YdO3W458gd6lIC3vDOojnPLzQEuJbl+gYc+E5HR3GP?= =?us-ascii?Q?rO9At3K6oc0Q9n9dOLYXobID1XfnIlOysrqt09fQwrYo2DVeJ5qvZeWgk/vb?= =?us-ascii?Q?9ZYtkQAI02nHzroZyCPo3ScBawVDO2fa2jiddbFMWAOy8oBlqUL59SKCA29c?= =?us-ascii?Q?H0UDUSRxjt2b8NfzuRx0kb8auNs8RzP3S1veYEPpy96e/IKyJqnTknIcIBvE?= =?us-ascii?Q?G5ffqtneWSAMNAVqFSSBTHFOvh1CWT2FdnuMphcDJdclEIgTl3u8E+5D+XEE?= =?us-ascii?Q?P1U9n75hKY9igd+Vz9r0u+Wg4xzNVv9ctJ3Hvw4RN2A/WtHv5YDkS0F+zGrm?= =?us-ascii?Q?QiaL8DBAR3F9ZMtK3GrKNNPB6/Fx+aEB5M1/yQopuuKsrKOBTCp6uQynnNbj?= =?us-ascii?Q?RSHc2g6DY7i/1KaQtl68fLJ9KNiWtEQOo073FKV4KT3HbRmD9q6zAM7th54w?= =?us-ascii?Q?TMcmRjiQqqELaK10LWI6LFlahpdU5AhDHUb6p1P94UUl7dvoH2c7iocFYHce?= =?us-ascii?Q?xOy4R2EtMIj4BkCK4PlHvFXlJfmR39pf0BtaySmySVIvsq9VBt8Ws6UO5ZEb?= =?us-ascii?Q?z26ss7hqPmZQc70j2NvqeNE3wzsftOOfQilNl4zhVrYqs9lCODx1pP3520SE?= =?us-ascii?Q?MU+PWmY2wZiU6MH+jwivCGV80XKdKPh27458lmTfyvtw8O5KMwvP9GcvCfJz?= =?us-ascii?Q?0RATmXWdkx+YVHy1qNh9kwPNq9kAqF0brJbWy7G8155kyR7HgHe2QGIOtKPg?= =?us-ascii?Q?P/uCXVB9vGPk+peHBfidiNo3QOV7rTdvTweUIBI/WTsHm+d3Z1ot73GaIJvn?= =?us-ascii?Q?jFIlMWeSpqCQpnvViC5K9JgsH5XzeOGCNyiN4EOpuM3aeSYxxYV8pQD+hDjP?= =?us-ascii?Q?TV7jDQtcIptd33Wgrqz59V9trFZTGDTqN0GanCw/QekOrBQyn03USlYs2112?= =?us-ascii?Q?B8TFW5N3CM/RshzDqF3ugIURbC1D3uOTmrK5MtsjpAFizLHW+QEccu/c4Cu8?= X-MS-Exchange-AntiSpam-MessageData-1: nbcw1yE3qkfuUg== X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: dc408169-b0e3-4f62-e9a3-08ded8e3ac48 X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 09:15:49.4886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z5cChvhGNC5LgbV4nTCd46wtawED68Pfxr9ot0W4s/MpAM7Eh1j/qONZiypyvvQR+wNyNQl6a6QF+VjSg0pLuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3P286MB3731 X-purgate-ID: tlsNG-4011c0/1783070155-D653FDDE-276232E8/0/0 X-purgate-type: clean X-purgate-size: 22852 Parse the 'cpu-map' node in the Device Tree to extract CPU topology information. If the 'cpu-map' node is absent, fall back to generating the topology data from the NUMA information. This generation assumes exactly one socket per NUMA node and that SMT is unsupported. Signed-off-by: Hirokazu Takahashi --- Changes in v4: - Only display the CPU topology configuration prompt in common/Kconfig if the architecture defines HAS_GENERIC_CPU_TOPOLOGY. - Move the definition of the global 'cpu_topology' pointer to common/cpu-topology.c. - Update the Makefile to explicitly build objects as .init.o when all functions and data within a file are annotated with __init/__initdata, ensuring their memory is reclaimed after system initialization. - Add an error log in the CPU-to-node mapping function for out-of-bounds cases. - Use ARRAY_SIZE() instead of raw macros when guarding array accesses. - Rename variables and functions to avoid ambiguous or misleading terms: - Avoid 'cpuid' to prevent confusion with x86 CPUID features/instructions. - Avoid 'node' where it could be confused with a NUMA node, explicitly renaming them to clarify they refer to a Device Tree node. - Move local variable declarations into the narrowest possible scope. - Replace the unsupported "%pOF" printk format specifier with "%s" and explicit node name retrieval. - Remove #include from cpu-topology.h, and ensure the header directly includes only what its definitions require. - Remove #include from dt-cpu-topology.h, replacing it with a forward declaration of 'struct dt_device_node'. - Use 'const' qualifiers for pointer declarations where the pointed-to structure is not modified. Changes in v3: - Use (nr_cpu_ids - 1) as the maximum CPU ID here. The fix for the sparse map mismatch issue on ARM Xen has been split out into a separate patch. - Switch topology sibling masks to cpumask_var_t for dynamic allocation. - Allow the system to keep running with a degraded fallback even if the topology table allocation fails. - Clean up the code to follow the Xen coding style. Please let me know if I missed any style nits! - Verify successful builds across x86, RISC-V, and PPC environments. Changes in v2: - Generate topology information even when ACPI is enabled. Note that this is a temporary implementation and doesn't yet parse the PPTT (Processor Properties Topology Table). - Added support for cpu-map node in Device Tree that doesn't contain explicit cluster node definitions. xen/arch/arm/Kconfig | 1 + xen/arch/arm/smpboot.c | 7 + xen/common/Kconfig | 18 ++ xen/common/Makefile | 1 + xen/common/cpu-topology.c | 62 +++++ xen/common/device-tree/Makefile | 1 + xen/common/device-tree/cpu-topology.c | 355 ++++++++++++++++++++++++++ xen/drivers/acpi/Kconfig | 3 + xen/drivers/acpi/Makefile | 1 + xen/drivers/acpi/topology.c | 38 +++ xen/include/xen/acpi.h | 2 + xen/include/xen/cpu-topology.h | 35 +++ xen/include/xen/dt-cpu-topology.h | 29 +++ 13 files changed, 553 insertions(+) create mode 100644 xen/common/cpu-topology.c create mode 100644 xen/common/device-tree/cpu-topology.c create mode 100644 xen/drivers/acpi/topology.c create mode 100644 xen/include/xen/cpu-topology.h create mode 100644 xen/include/xen/dt-cpu-topology.h diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 5fa89fcb24..a390844432 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -22,6 +22,7 @@ config ARM select HAS_GRANT_CACHE_FLUSH if GRANT_TABLE select HAS_STACK_PROTECTOR select HAS_UBSAN + select HAS_GENERIC_CPU_TOPOLOGY config ARCH_DEFCONFIG string diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 7f3cfa812e..5ce2bcf6ec 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -9,10 +9,12 @@ #include #include +#include #include #include #include #include +#include #include #include #include @@ -242,6 +244,9 @@ static void __init dt_smp_init_cpus(void) } else tmp_map[i] = hwid; + + /* Pass the info to dt_init_cpu_topology() */ + map_cpu_to_dt_node(i, cpu); } if ( !bootcpu_valid ) @@ -279,6 +284,8 @@ void __init smp_init_cpus(void) else acpi_smp_init_cpus(); + init_cpu_topology(); + if ( opt_hmp_unsafe ) warning_add("WARNING: HMP COMPUTING HAS BEEN ENABLED.\n" "It has implications on the security and stability of the system,\n" diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 5ff71480ee..6ee689cbdd 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -188,6 +188,24 @@ config VM_EVENT config NEEDS_LIBELF bool +config HAS_GENERIC_CPU_TOPOLOGY + bool + +config DT_CPU_TOPOLOGY + bool + +config GENERIC_CPU_TOPOLOGY + bool "CPU topology support (UNSUPPORTED)" if UNSUPPORTED + depends on HAS_GENERIC_CPU_TOPOLOGY + select DT_CPU_TOPOLOGY if DEVICE_TREE_PARSE + select ACPI_CPU_TOPOLOGY if ACPI + help + Retrieve CPU topology information from the device tree to optimize + virtual CPU scheduling. + + Note: Implementation for parsing CPU topology from the ACPI PPTT + is currently missing. + config NUMA bool diff --git a/xen/common/Makefile b/xen/common/Makefile index 6018e25614..34b333cdb3 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -5,6 +5,7 @@ obj-$(CONFIG_GENERIC_BUG_FRAME) += bug.o obj-$(CONFIG_HYPFS_CONFIG) += config_data.o obj-$(CONFIG_CORE_PARKING) += core_parking.o obj-y += cpu.o +obj-$(CONFIG_GENERIC_CPU_TOPOLOGY) += cpu-topology.o obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o obj-$(CONFIG_HAS_DEVICE_TREE_DISCOVERY) += device.o obj-$(filter-out $(CONFIG_X86),$(CONFIG_ACPI)) += device.o diff --git a/xen/common/cpu-topology.c b/xen/common/cpu-topology.c new file mode 100644 index 0000000000..94cb9ba312 --- /dev/null +++ b/xen/common/cpu-topology.c @@ -0,0 +1,62 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include +#include +#include +#include + +struct cpu_topology *__ro_after_init cpu_topology; + +static void __init free_topology_table(void) +{ + unsigned int cpu; + + for ( cpu = 0; cpu < nr_cpu_ids; cpu++ ) + { + free_cpumask_var(cpu_topology[cpu].thread_sibling); + free_cpumask_var(cpu_topology[cpu].core_sibling); + free_cpumask_var(cpu_topology[cpu].cluster_sibling); + } + + XFREE(cpu_topology); +} + +void __init init_cpu_topology(void) +{ + unsigned int cpu; + + cpu_topology = xzalloc_array(struct cpu_topology, nr_cpu_ids); + if ( !cpu_topology ) + { + printk(XENLOG_ERR "Failed to allocate memory for cpu_topology table\n"); + return; + } + + for ( cpu = 0; cpu < nr_cpu_ids; cpu++ ) + { + if ( !zalloc_cpumask_var(&cpu_topology[cpu].thread_sibling) || + !zalloc_cpumask_var(&cpu_topology[cpu].core_sibling) || + !zalloc_cpumask_var(&cpu_topology[cpu].cluster_sibling) ) + { + free_topology_table(); + printk(XENLOG_ERR "Failed to allocate memory for cpu_topology table\n"); + return; + } + } + + if ( acpi_disabled ) + dt_init_cpu_topology(); + else + acpi_init_cpu_topology(); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/common/device-tree/Makefile b/xen/common/device-tree/Makefile index 9036e455d6..6ee670b5f4 100644 --- a/xen/common/device-tree/Makefile +++ b/xen/common/device-tree/Makefile @@ -1,6 +1,7 @@ obj-y += bootfdt.init.o obj-$(CONFIG_HAS_DEVICE_TREE_DISCOVERY) += bootinfo-fdt.init.o obj-$(CONFIG_HAS_DEVICE_TREE_DISCOVERY) += bootinfo.init.o +obj-$(CONFIG_DT_CPU_TOPOLOGY) += cpu-topology.init.o obj-y += device-tree.o obj-$(CONFIG_DOMAIN_BUILD_HELPERS) += domain-build.init.o obj-$(filter $(CONFIG_DOM0LESS_BOOT),$(CONFIG_HAS_DEVICE_TREE_DISCOVERY)) += dom0less-build.init.o diff --git a/xen/common/device-tree/cpu-topology.c b/xen/common/device-tree/cpu-topology.c new file mode 100644 index 0000000000..b653227ef4 --- /dev/null +++ b/xen/common/device-tree/cpu-topology.c @@ -0,0 +1,355 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Derived from Linux kernel 7.0's $drivers/base/arch_topology.c + * Parse cpu topology information. + */ + +#include +#include +#include +#include +#include +#include +#include + +struct cpu_map { + unsigned int thread_id; + unsigned int core_id; + unsigned int cluster_id; + unsigned int package_id; +}; + +static const unsigned int __initdata invalid_topo_id = ~0U; +static struct cpu_map __initdata cpu_map[NR_CPUS] = { + [0 ... NR_CPUS - 1] = {invalid_topo_id, invalid_topo_id, invalid_topo_id, 0} +}; +static struct dt_device_node *__initdata dt_cpu_table[NR_CPUS]; + +static void __init setup_siblings_masks(unsigned int target_cpu) +{ + const struct cpu_topology *target_topo = &cpu_topology[target_cpu]; + const struct cpu_map *target_map = &cpu_map[target_cpu]; + unsigned int cpu; + + /* Update core and thread sibling masks */ + for_each_possible_cpu(cpu) + { + const struct cpu_topology *cpu_topo = &cpu_topology[cpu]; + const struct cpu_map *map = &cpu_map[cpu]; + + if ( target_map->package_id != map->package_id ) + continue; + + cpumask_set_cpu(target_cpu, cpu_topo->core_sibling); + cpumask_set_cpu(cpu, target_topo->core_sibling); + + if ( target_map->cluster_id != map->cluster_id ) + continue; + + if ( target_map->cluster_id != invalid_topo_id ) + { + cpumask_set_cpu(target_cpu, cpu_topo->cluster_sibling); + cpumask_set_cpu(cpu, target_topo->cluster_sibling); + } + + if ( target_map->core_id != map->core_id ) + continue; + + cpumask_set_cpu(target_cpu, cpu_topo->thread_sibling); + cpumask_set_cpu(cpu, target_topo->thread_sibling); + } +} + +static struct dt_device_node *__init + dt_find_child_node_by_name(const struct dt_device_node *dt, + const char *name) +{ + struct dt_device_node *np; + + dt_for_each_child_node(dt, np) + if ( np->name && (dt_node_cmp(np->name, name) == 0) ) + break; + + return np; +} + +void __init map_cpu_to_dt_node(unsigned int cpu, + struct dt_device_node *cpu_node) +{ + if ( cpu < ARRAY_SIZE(dt_cpu_table) ) + dt_cpu_table[cpu] = cpu_node; + else + printk(XENLOG_WARNING + "cpu id %u exceeds the max cores %lu\n", + cpu, ARRAY_SIZE(dt_cpu_table)); +} + +static unsigned int __init cpu_node_to_id(const struct dt_device_node *cpu_node) +{ + unsigned int cpu; + + for_each_possible_cpu(cpu) + if ( cpu_node == dt_cpu_table[cpu] ) + return cpu; + + return invalid_topo_id; +} + +/* + * This function returns the logical cpu number of the DT node. + */ +static unsigned int __init + get_cpu_for_node(const struct dt_device_node *dt_node) +{ + const struct dt_device_node *cpu_node = dt_parse_phandle(dt_node, "cpu", 0); + + if ( !cpu_node ) + return invalid_topo_id; + + return cpu_node_to_id(cpu_node); +} + +static int __init parse_core(const struct dt_device_node *core, + unsigned int package_id, + unsigned int cluster_id, + unsigned int core_id) +{ + bool leaf = true; + unsigned int i = 0; + unsigned int cpu; + + do { + const struct dt_device_node *t; + char name[20]; + + snprintf(name, sizeof(name), "thread%u", i); + t = dt_find_child_node_by_name(core, name); + + if ( !t ) + break; + + leaf = false; + cpu = get_cpu_for_node(t); + if ( cpu != invalid_topo_id ) + { + cpu_map[cpu].package_id = package_id; + cpu_map[cpu].cluster_id = cluster_id; + cpu_map[cpu].core_id = core_id; + cpu_map[cpu].thread_id = i; + } + else + { + printk(XENLOG_ERR + "ERROR: %s: Can't get CPU for thread\n", dt_node_name(t)); + return -EINVAL; + } + i++; + } while ( true ); + + cpu = get_cpu_for_node(core); + + if ( cpu != invalid_topo_id ) + { + if ( !leaf ) + { + printk(XENLOG_ERR "ERROR: %s: Core has both threads and CPU\n", + dt_node_name(core)); + return -EINVAL; + } + + cpu_map[cpu].package_id = package_id; + cpu_map[cpu].cluster_id = cluster_id; + cpu_map[cpu].core_id = core_id; + cpu_map[cpu].thread_id = 0; + } + else if ( leaf ) + { + printk(XENLOG_ERR + "ERROR: %s: Can't get CPU for leaf core\n", dt_node_name(core)); + return -EINVAL; + } + + return 0; +} + +static int __init parse_cluster(const struct dt_device_node *cluster, + unsigned int package_id, + unsigned int cluster_id, + unsigned int depth) +{ + bool leaf = true; + bool has_cores = false; + unsigned int core_id = 0; + unsigned int i = 0; + + /* + * First check for child clusters; we currently ignore any + * information about the nesting of clusters and present the + * scheduler with a flat list of them. + */ + do { + const struct dt_device_node *c; + char name[20]; + int ret; + + snprintf(name, sizeof(name), "cluster%u", i); + c = dt_find_child_node_by_name(cluster, name); + + if ( !c ) + break; + + leaf = false; + ret = parse_cluster(c, package_id, i, depth + 1); + if ( depth > 0 ) + printk(XENLOG_WARNING + "WARNING: Topology for clusters of clusters not yet supported\n"); + if ( ret != 0 ) + return ret; + i++; + } while ( true ); + + /* Now check for cores */ + i = 0; + do { + const struct dt_device_node *c; + char name[20]; + int ret; + + snprintf(name, sizeof(name), "core%u", i); + c = dt_find_child_node_by_name(cluster, name); + + if ( !c ) + break; + + has_cores = true; + + if ( depth == 0 ) + { + printk(XENLOG_ERR + "ERROR: %s: cpu-map children should be clusters\n", + dt_node_name(c)); + return -EINVAL; + } + + if ( leaf ) + { + ret = parse_core(c, package_id, cluster_id, core_id++); + if ( ret != 0 ) + return ret; + } + else + { + printk(XENLOG_ERR "ERROR: %s: Non-leaf cluster with core %s\n", + dt_node_name(cluster), name); + return -EINVAL; + } + + i++; + } while ( true ); + + if ( leaf && !has_cores ) + printk(XENLOG_WARNING "WARNING: %s: empty cluster\n", + dt_node_name(cluster)); + + return 0; +} + +static int __init parse_socket(const struct dt_device_node *socket) +{ + bool has_socket = false; + unsigned int package_id = 0; + int ret; + + do { + const struct dt_device_node *c; + char name[20]; + + snprintf(name, sizeof(name), "socket%u", package_id); + c = dt_find_child_node_by_name(socket, name); + + if ( !c ) + break; + + has_socket = true; + ret = parse_cluster(c, package_id, invalid_topo_id, 0); + if ( ret != 0 ) + return ret; + + package_id++; + } while ( true ); + + if ( !has_socket ) + ret = parse_cluster(socket, 0, invalid_topo_id, 0); + + return ret; +} + +/* + * Generate cpu topology information when cpu-map node doesn't exist. + * It assumes that the cpu doesn't have SMT and all CPUs on a NUMA + * node belong to the same socket. + */ +static void __init fixup_topology(void) +{ + unsigned int cpu; + unsigned int clid = 0; + unsigned int pkgid = 0; + + for_each_possible_cpu(cpu) + { + struct cpu_map *map = &cpu_map[cpu]; + + map->package_id = cpu_to_node(cpu); + if ( map->package_id != pkgid ) + { + pkgid = map->package_id; + clid = 0; + } + map->cluster_id = clid++; + map->core_id = 0; + map->thread_id = 0; + } +} + +int __init parse_dt_topology(void) +{ + const struct dt_device_node *cpus; + const struct dt_device_node *map; + + cpus = dt_find_node_by_path("/cpus"); + if ( !cpus ) + { + printk(XENLOG_ERR "ERROR: No CPU information found in DT\n"); + return -EINVAL; + } + + map = dt_find_child_node_by_name(cpus, "cpu-map"); + if ( !map ) + return -ENOENT; + + return parse_socket(map); +} + +void __init dt_init_cpu_topology(void) +{ + unsigned int cpu; + + BUG_ON(!acpi_disabled); + BUG_ON(!cpu_topology); + + if ( parse_dt_topology() ) + fixup_topology(); + + for_each_possible_cpu(cpu) + setup_siblings_masks(cpu); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig index e3f3d8f4b1..5277b7bf83 100644 --- a/xen/drivers/acpi/Kconfig +++ b/xen/drivers/acpi/Kconfig @@ -8,3 +8,6 @@ config ACPI_LEGACY_TABLES_LOOKUP config ACPI_NUMA bool select NUMA + +config ACPI_CPU_TOPOLOGY + bool diff --git a/xen/drivers/acpi/Makefile b/xen/drivers/acpi/Makefile index 477408afbe..bcdb1b5e1b 100644 --- a/xen/drivers/acpi/Makefile +++ b/xen/drivers/acpi/Makefile @@ -10,3 +10,4 @@ obj-$(CONFIG_PM_OP) += pm-op.o obj-$(CONFIG_X86) += hwregs.o obj-$(CONFIG_X86) += reboot.o +obj-$(CONFIG_ACPI_CPU_TOPOLOGY) += topology.init.o diff --git a/xen/drivers/acpi/topology.c b/xen/drivers/acpi/topology.c new file mode 100644 index 0000000000..6bd2d96ebb --- /dev/null +++ b/xen/drivers/acpi/topology.c @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include +#include +#include + +/* + * TODO: Populate the topology information by scanning the ACPI + * PPTT (Processor Properties Topology Table). + */ +void __init acpi_init_cpu_topology(void) +{ + unsigned int cpu; + + /* + * Generate temporary cpu topology information for now. + * It assumes that the cpu doesn't have SMT and all CPUs + * belong to the same socket. + */ + for_each_possible_cpu(cpu) + { + struct cpu_topology *topo = &cpu_topology[cpu]; + + cpumask_set_cpu(cpu, topo->thread_sibling); + cpumask_copy(topo->core_sibling, &cpu_possible_map); + } +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 2fdf38cf74..d531c76370 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -101,6 +101,8 @@ void acpi_table_print (struct acpi_table_header *header, unsigned long phys_addr void acpi_table_print_madt_entry (struct acpi_subtable_header *madt); void acpi_table_print_srat_entry (struct acpi_subtable_header *srat); +void acpi_init_cpu_topology(void); + /* the following four functions are architecture-dependent */ void acpi_numa_slit_init (struct acpi_table_slit *slit); void acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *); diff --git a/xen/include/xen/cpu-topology.h b/xen/include/xen/cpu-topology.h new file mode 100644 index 0000000000..f64820febf --- /dev/null +++ b/xen/include/xen/cpu-topology.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef XEN_CPU_TOPOLOGY_H +#define XEN_CPU_TOPOLOGY_H + +#include + +#ifdef CONFIG_GENERIC_CPU_TOPOLOGY + +struct cpu_topology { + cpumask_var_t thread_sibling; + cpumask_var_t core_sibling; + cpumask_var_t cluster_sibling; +}; + +extern struct cpu_topology *cpu_topology; +void init_cpu_topology(void); + +#else /* CONFIG_GENERIC_CPU_TOPOLOGY */ + +#define cpu_topology ((struct cpu_topology *)NULL) +static inline void init_cpu_topology(void) {} + +#endif /* CONFIG_GENERIC_CPU_TOPOLOGY */ + +#endif /* XEN_CPU_TOPOLOGY_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/dt-cpu-topology.h b/xen/include/xen/dt-cpu-topology.h new file mode 100644 index 0000000000..cb8a266479 --- /dev/null +++ b/xen/include/xen/dt-cpu-topology.h @@ -0,0 +1,29 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef XEN_DT_CPU_TOPOLOGY_H +#define XEN_DT_CPU_TOPOLOGY_H + +struct dt_device_node; + +#ifdef CONFIG_DT_CPU_TOPOLOGY + +void map_cpu_to_dt_node(unsigned int cpu, struct dt_device_node *cpu_node); +void dt_init_cpu_topology(void); + +#else /* CONFIG_DT_CPU_TOPOLOGY */ + +static inline void map_cpu_to_dt_node(unsigned int cpu, + struct dt_device_node *cpu_node) {} + +#endif /* CONFIG_DT_CPU_TOPOLOGY */ + +#endif /* XEN_DT_CPU_TOPOLOGY_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 09:16:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 09:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353027.1609209 (Exim 4.92) (envelope-from ) id 1wfa05-0004CX-MC; Fri, 03 Jul 2026 09:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353027.1609209; Fri, 03 Jul 2026 09:15:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa05-0004CQ-Ik; Fri, 03 Jul 2026 09:15:57 +0000 Received: by outflank-mailman (input) for mailman id 1353027; Fri, 03 Jul 2026 09:15:56 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa03-0004Bu-00 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 09:15:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfa02-00GN2P-5L for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 11:15:54 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a477dc6-2eae-0a2a0a5409dd-0a2a450ace40-4 for ; Fri, 03 Jul 2026 11:15:53 +0200 Received: from [52.101.125.115] (helo=TYVP286CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a477dc6-e40e-0a2a450a0019-34657d733221-3 for ; Fri, 03 Jul 2026 11:15:52 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TY3P286MB3731.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3d3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 09:15:47 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 09:15:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jyh2PoPDSRqn2koWS9MUd/eyGUS008vJmldeA0cV4rSNuJ0rnyMStDBLFmbpdWeoP9rmBfuK7OUgj08g88Q0VV6kExlZrHPjnIpE6Ir/vBI1Cs2CHEGWuzf+3pyG66TEbmRWp9vlLzcuQeq3LYciGQoj9EJjbwW7Fdn3l8L84WyOYsaqAu4YUBV7jOyH15zqoVTEmRtFlBpOU+bCxb8BRBFZ7eQgBXGYvrdjWOCkZx26SQrcqMMEFRdVb8XUChJB+CVYL9KzaoCZFUxbxv6SStlvdfhA9sjsFOYKoBFniJFAOZ69QElTR85rsiUvKZJIXSKHVqnRneudrVH68FGMUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lJiE4pPeY5QvYLhZ/xDXbCkrelaciRSvhG3kRNYSjE=; b=r3MXN5dD/eXYTSnKVhUteth0CJMfWlL/y4yl1kxBmVh0+y2R1RAOGu60y+NZUp0C7EhdMUfqDMIPEp2e9uARLxhI0S/PAepUxRiaesebCQBp59+a7TT5ZG1GD3yeZwm6aGFDS1+U26BR15V9hm+CupzK5ChGAL3sSuk6ScvIIHtw5+QWZFkAe5nCMG6bHzEdcna/N8d3LM+9qKEiy2O6Q4KV7yk0la+lpsC0j4dqrT533g3zWgglbNk2tdB5csfRY+ZWOa7fh2bdt50Sqq5RB9CezP7rnrsPmOagMc8ioMqy/NfzLfJGZigBw6U7i5biyXy/H7DLrC44n3t1+hgqtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7lJiE4pPeY5QvYLhZ/xDXbCkrelaciRSvhG3kRNYSjE=; b=dHV9As1spRToGLO1FE2XskTH6a4cbrP4G7BiBql7o3wWbpHm3/F8mAtoTLyDIJr013CRS9BiPSzDZHrRnzd9AebeA1VnNv3ULzF2qcij4pFuxbpygh/YXS5YsQUpTwbDvehbpiwnAUAaRuzJvXgEgZH6d9WezfN4hbJ9q4HVKs8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Hirokazu Takahashi To: xen-devel@lists.xenproject.org Cc: Hirokazu Takahashi Subject: [PATCH v4 0/3] xen/arm: Device Tree based CPU topology support Date: Fri, 3 Jul 2026 18:15:41 +0900 Message-ID: <20260703091544.183548-1-taka@valinux.co.jp> X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TY4P301CA0062.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36a::13) To OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9P286MB7222:EE_|TY3P286MB3731:EE_ X-MS-Office365-Filtering-Correlation-Id: 962167c5-cf88-4311-a63e-08ded8e3ab43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|10070799003|3023799007|29003799003|25016099003|6133799003|56012099006|18002099003; X-Microsoft-Antispam-Message-Info: 2WbLpQmPlIcSdrY8e4iq/wk/8gF28J/g+1lyLD6WhKVXJJn/crzHozZbCiIcM0rYYPpU5GBoA293xNAxAsCB73EHwXv52vVSu+QtUP98o/Hpo1BvWpo/O5vCXAK0q1PinkXvNF3L9mED7iR5lPkACJO5oZDx4WWAXdkKt87H8JfeyQDBUnSeFA5jT6invQYGNuT6OkuSNvqiY6iF0epk8WoZw6BOfmw7tNutx42pBJeLyk3Yf4X9To46PnhZzk4lKBXL87koDzP0cIIZA1eIb9n5bywqep3XAo8kTNNCfTOOHS5FiXAhEi4MD/AwMHal+JvhaiKnnap6rKAMvx1DYcFKy4fSbe5Zu+i1Ves1lzNDaxFHm5ANX8IV1hdklbldfQG5LFVDM/Ze6nEVkTjYmfhS9+PxNQppl72ZGgGGVTOdEOgF5Cxmc6KiTKI1RuRYwX2SMbLdjBr+sXryLKJ8AqTEzxjmUv0hffRcQL1W4ZXpD9lytvmGlKHc/TWHaMJX7MrKIrCn3mGCCXnDJ6Nt5LgJQRI7frGdi3oFxqgh/789V6mhRjy4XtjDPgKej6qN3KQI+Sr/oT76OjteWlRzlVaiYzHzXLbB62uXNmwiC9l3nzYLkcV39B7UeIJxDnVxdXnpHHzTxgL5DMpesiuKokkMkESIsGqXZl64pcdX5wg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(10070799003)(3023799007)(29003799003)(25016099003)(6133799003)(56012099006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yhG50z0vGq5AwkqtgbKBVfjbe00c4a1NVdxbXr88jk6d1qOOjIqgQ4r7jAoB?= =?us-ascii?Q?RxeLbSWdThkLybPQqx9ySgCPJHwvgIkpUcrF5+rkh7F48c7Bst30YRIZnSPm?= =?us-ascii?Q?9Tv52WKX81lsmiyyM3pBezbKStvg1U0rUA9g98QIjjHKqbtEzfPi8MwU4roc?= =?us-ascii?Q?KWxuBFbrcRcWD0ZXOf7mC4keDsJG1NH9rKP91F58G5LC1w4P9RH/W0jxfaGj?= =?us-ascii?Q?iymP8hgllkw/0VrgbnfXbl/xm8wm8IxbZyqiJxYpBGkWviys88pIMRwFGZi5?= =?us-ascii?Q?oDUwl0Vui3MHF/SQQ4V1SothLCnbL0k1KTVLuOn7j7mY5xya5GNspvVmQUgT?= =?us-ascii?Q?+Ob3vof5dd2JLTJAOXRhEq//UNcngz0r7ume2x8r8vnmxnYiQ4a0KRWbuq48?= =?us-ascii?Q?/7VH4doRW4mAexPeH9BICRQiIo8kchmgMghBzWKCslchSpUsmJTQmAvAVhh4?= =?us-ascii?Q?yo5CSYX7G3hXW97BMJg8a4ZVTw8X1Goyvy6w22bPWxv2vYXeYs/6MCmp44gE?= =?us-ascii?Q?gbrdwf1KqojPyEnu4sQkEPNRWtSY8HjgvUhCDIU3HaoMiV2P8wOgrYg9JxMF?= =?us-ascii?Q?7R4nmq/+4oZm/n5qV+dQfFxPKOzn7mu3UGvNZIA+Z/pplu0qll6jAqSpQc+M?= =?us-ascii?Q?DrSU8ry1l+Xq5QYvG5T20f1DComtdsO1roC8PtscuEJTQJ75s5oX5r9pj3pQ?= =?us-ascii?Q?mxBROrAjgGQQ8DC64j4prP02wQoykG0hQMsUB/I21xPZO7SuE2KftWC74hwo?= =?us-ascii?Q?jOjdIIIaIXz/voy/sn46M6PXOgJqOh3+MW47M7uy8NmXprF6OZiD/ldx/4LO?= =?us-ascii?Q?xFwrZEc965a4axUl6l9rPsoxdNOjUgS19U8i0FsOSwTWIBruJZWdVhOOqMcK?= =?us-ascii?Q?zRppmD6LD9pHsqqs8XgHW9VDCz9L+SIXFbcoLKt/Nws5RSkTFpq3G8bSxeN9?= =?us-ascii?Q?wTf3cAlAHDUMJw5TU+fxL/sLi7PkJJT8QTcVK/+UGvyzlASkvwY5KFl1WKIx?= =?us-ascii?Q?lCJWd7lFEJAXtPoDuGsWtqoMaNz/EkrYbq8fWkL86lBvHAjoYc2T+aDlCApz?= =?us-ascii?Q?jaBCpqDICivoHdVYTJUTUt30+3DF8ZEl6fymDxcWooOUoBkc/gNRv+eN09gr?= =?us-ascii?Q?ot6NGlprvS6JW2ahV/rUrJGMKQjpSdTA/2xkZruQSeiAYR3RgDEnzoqcGj1n?= =?us-ascii?Q?iRdY8SiouXvscpc/iYL0lhdfxOkAUh533dOFft+8AdGCOxOoKiFGJcwT0c7N?= =?us-ascii?Q?+Rs+DagdOoDKjGRUF84jm0pzLE0cv0baqxrhK2Bi+ot6izX5hMrvRTTze2m0?= =?us-ascii?Q?BDE7N5Ey4P4TwT0MaClW/Do7E72gMB/C05N+UhKVTWc91evjhWPo6nkdN6Nc?= =?us-ascii?Q?3VKn0dIwYl5bYotdsuwxEOMRdEC/W4hgghVM+b7tWoDvQYEkLYatYU1QCLQu?= =?us-ascii?Q?K2t9H9VFD3GLIc0c3YSLMX3p7+ELFHe5f2Rr4PcZ+UNVD9nfHB5teg2USO0g?= =?us-ascii?Q?o9owZrjKoXoxQIksIbIDtIbyJ6y0SWt6f9Zni8UOr5UhaOyx4sM9lOpPufGK?= =?us-ascii?Q?KONMoYVeElOViBYKVrzZECk/R3dxRa36o1G+xBIJC9Yk78r2LYcxMZb7z07o?= =?us-ascii?Q?wITlUdQ6Bbltz8q9OVcZkyIgt7zA81WdSrJivSkUsEICJdp2PuR+29NGICU2?= =?us-ascii?Q?NqB0I+7FmB6le3WIMmzUJ/FpzoYCniVdvTrv7zUWaPBR0yWsU0hjnigKzbjm?= =?us-ascii?Q?a2xZqZUL3gBAmJqcgtm/RTUrEqFcJBkKEOegs8Q+TqjSeMMiXeap0mtxebD6?= X-MS-Exchange-AntiSpam-MessageData-1: pTL2LVlnC+RiBw== X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 962167c5-cf88-4311-a63e-08ded8e3ab43 X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 09:15:47.6919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Edy9msFGwxJJTLewKSBCOus1dNBl1Zv4OKeiEK1Du6k7eaeqvgfj3jGDJIQy5g0Kld/fs6SzrKzvGsJdd4aD3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3P286MB3731 X-purgate-ID: tlsNG-4011c0/1783070153-CF935DDE-51332E90/0/0 X-purgate-type: clean X-purgate-size: 5768 Hello, This patch series introduces Device-Tree based CPU topology support for ARM Xen. This version incorporates the feedback received from Jan on the v3 submission. The main focus of this update includes transitioning towards a generic Kconfig structure, untangling header dependencies and various code cleanups. Future Work: - Support for the "credit2_runqueue=cluster" option. - CPU topology support for RISC-V and PPC (once SMP support is available). - Topology information generation from the ACPI PPTT. Changes in v4: - Only display the CPU topology configuration prompt in common/Kconfig if the architecture defines HAS_GENERIC_CPU_TOPOLOGY. - Move the definition of the global 'cpu_topology' pointer to common/cpu-topology.c. - Update the Makefile to explicitly build objects as .init.o when all functions and data within a file are annotated with __init/__initdata, ensuring their memory is reclaimed after system initialization. - Add an error log in the CPU-to-node mapping function for out-of-bounds cases. - Use ARRAY_SIZE() instead of raw macros when guarding array accesses. - Rename variables and functions to avoid ambiguous or misleading terms: - Avoid 'cpuid' to prevent confusion with x86 CPUID features/instructions. - Avoid 'node' where it could be confused with a NUMA node, explicitly renaming them to clarify they refer to a Device Tree node. - Move local variable declarations into the narrowest possible scope. - Replace the unsupported "%pOF" printk format specifier with "%s" and explicit node name retrieval. - Remove #include from cpu-topology.h, and ensure the header directly includes only what its definitions require. - Remove #include from dt-cpu-topology.h, replacing it with a forward declaration of 'struct dt_device_node'. - Use 'const' qualifiers for pointer declarations where the pointed-to structure is not modified. - Explicitly #include in cpu-topology.h to guarantee that arch-specific definitions of cpu_to_core() and cpu_to_socket() take precedence over the generic fallbacks. - Introduce inline initialization functions for cpu_sibling_mask and cpu_core_mask in cpu-topology.h, providing separate variants for both when CONFIG_GENERIC_CPU_TOPOLOGY is enabled and disabled. Changes in v3: - Use (nr_cpu_ids - 1) as the maximum CPU ID here. The fix for the sparse map mismatch issue on ARM Xen has been split out into a separate patch. - Switch topology sibling masks to cpumask_var_t for dynamic allocation. - Allow the system to keep running with a degraded fallback even if the topology table allocation fails. - Remove the temporary definitions of cpu_to_core() and cpu_to_socket() from RISC-V and PPC processor.h. - Minimize the use of #ifdef blocks, leveraging compiler Dead Code Elimination (DCE) where possible. - Clean up the code to follow the Xen coding style. Please let me know if I missed any style nits! - Verify successful builds across x86, RISC-V, and PPC environments. Changes in v2: - Generate topology information even when ACPI is enabled. Note that this is a temporary implementation and doesn't yet parse the PPTT (Processor Properties Topology Table). - Added support for cpu-map node in Device Tree that doesn't contain explicit cluster node definitions. Changes in v1 from the previous series "Introduce Device Tree based NUMA support for ARM Xen": 1. Optimized Memory Allocation: The series now allocates only the minimum required memory area to manage the essential data for the CPUs. 2. Flexible Device Tree Parsing: The parsing logic no longer depends on the definition order of the 'cpu' nodes and 'cpu-map' nodes in the Device Tree. They can now be read correctly even if their orders do not match. 3. CPU Hotplug Readiness: To support future CPU hotplug, the system assumes that inactive CPUs are also described in the Device Tree. Xen will pre-load and generate the topology information for these inactive CPUs during the boot phase so it stays available in memory. Thank you, Hirokazu Takahashi Hirokazu Takahashi (3): xen/device-tree: Parse 'cpu-map' node for CPU topology exploration xen/sched: Link CPU topology to scheduler xen/sched: Make cpu_nr_siblings() architecture-specific xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/processor.h | 4 - xen/arch/arm/smpboot.c | 15 +- xen/arch/ppc/include/asm/processor.h | 4 - xen/arch/riscv/include/asm/processor.h | 4 - xen/arch/x86/include/asm/processor.h | 1 + xen/common/Kconfig | 18 ++ xen/common/Makefile | 1 + xen/common/cpu-topology.c | 62 ++++ xen/common/device-tree/Makefile | 1 + xen/common/device-tree/cpu-topology.c | 406 +++++++++++++++++++++++++ xen/common/sched/credit2.c | 21 +- xen/common/sysctl.c | 1 + xen/drivers/acpi/Kconfig | 3 + xen/drivers/acpi/Makefile | 1 + xen/drivers/acpi/topology.c | 41 +++ xen/include/xen/acpi.h | 2 + xen/include/xen/cpu-topology.h | 83 +++++ xen/include/xen/dt-cpu-topology.h | 29 ++ 19 files changed, 662 insertions(+), 36 deletions(-) create mode 100644 xen/common/cpu-topology.c create mode 100644 xen/common/device-tree/cpu-topology.c create mode 100644 xen/drivers/acpi/topology.c create mode 100644 xen/include/xen/cpu-topology.h create mode 100644 xen/include/xen/dt-cpu-topology.h -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 09:16:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 09:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353030.1609237 (Exim 4.92) (envelope-from ) id 1wfa08-0004pL-G4; Fri, 03 Jul 2026 09:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353030.1609237; Fri, 03 Jul 2026 09:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa08-0004pD-CV; Fri, 03 Jul 2026 09:16:00 +0000 Received: by outflank-mailman (input) for mailman id 1353030; Fri, 03 Jul 2026 09:15:58 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfa06-0004QW-Gu for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 09:15:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfa05-00GN2P-T4 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 11:15:57 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a477dc6-2eae-0a2a0a5409dd-0a2a450ace40-22 for ; Fri, 03 Jul 2026 11:15:57 +0200 Received: from [52.101.125.115] (helo=TYVP286CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a477dc6-e40e-0a2a450a0019-34657d733221-6 for ; Fri, 03 Jul 2026 11:15:57 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TY3P286MB3731.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3d3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 09:15:52 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 09:15:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uULWK3Wp7UmAqolW0O87DbjhR/76XnHEmq8iiCnKPIqg+IQuQErTi+WLR4KqESCF+bzfbISpFDzpGQKxQcECrkbJaK2GDOgbXcxN4WHGyLgja/GaRNgmgOE/1uOrxEtgsQzC7Vy9GiuUGI7xJdKi+WLGyDm/2tsTRdiIDJaIdqIQVKK73M+ELsUfGhal06CjnOQSkOpja/RLMTLSmpgPWeZPlhY0aHENH2nrSoMgE75lu85B6PHjUpdESbpjxIJ4HsQg475Wu88x3c+A0gkOvahrX22et4ti1Baa2T8tiYs6CHa5Wevr0rbfKku4P5Z/VZ7YvoUexajQ+2QWn9y+kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cnhJk1GWwfTBQlXCmlfrD1hdxu7L/SP10nBbA09ZTac=; b=HyPVswMvWB7UuGHOlDzV7IzZLg4yHRpSjAGIOax7l8ipQDz+xgEg/5F4XM3U7BT04H8C05X5pkFa+i2T9/nhJnOUroKR0H+ZAkVhOTcK1MtnBEpnZP56mn7AOyOKlVvwU8nnuOelLDxiIX8GLmcb+fOPmzL8am59rucxG4jkgc1pL3mCRQO2NMOPwDt0d52AbifNr1GYJ0LmjoECwBr7O87TUxUa5iSVRCCy8v7Z4c0pILuBoa52ppF9S4jQ7lmL+sJbgoDY5b+tVO9CJQCXWEQO7rPolqRtJWCqD5ORKeFu7dsYZiFHdIOGk7SmYPP7qKJQ6WansCCOeaxjsN++ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cnhJk1GWwfTBQlXCmlfrD1hdxu7L/SP10nBbA09ZTac=; b=Rtv2s3MO7xV10pJDpPuN6KUucd9DvuK2szy6i0Nhvf5B6dG1/eqi4APBIrbbRuJ6LQ0So01msRnZU9R0ov+XI6n7YQQ1kOCw+BA2qhkZV2ZkPyn22ml1HlXdhWoYWzCIBm5Dpu6WSIYNvAF7aDuPIbw7C97Sc3tKWfICK0BZi/Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Hirokazu Takahashi To: xen-devel@lists.xenproject.org Cc: Hirokazu Takahashi , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini , Dario Faggioli , Juergen Gross , George Dunlap Subject: [PATCH v4 3/3] xen/sched: Make cpu_nr_siblings() architecture-specific Date: Fri, 3 Jul 2026 18:15:44 +0900 Message-ID: <20260703091544.183548-4-taka@valinux.co.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260703091544.183548-1-taka@valinux.co.jp> References: <20260703091544.183548-1-taka@valinux.co.jp> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TY4P301CA0070.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36a::8) To OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9P286MB7222:EE_|TY3P286MB3731:EE_ X-MS-Office365-Filtering-Correlation-Id: 48dcbeaa-84cd-4c33-485b-08ded8e3ae2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|7416014|376014|10070799003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: oo16E+eLbXDUCFPcNBT4Dz+rz9LjNOoPYtNKSgAMBOMwG6HGOVTNXWMNYgm4QYXWWpKimioYbo9CBtYbNVXw4K4aRW6pdx/BNYTfuyfnD5x9I8WhxwmmRoV3h0F9uxmZI/v4A7YKCZC/cs4UGECp/cugJbwM2r5/oMH4V6AYsFum3fLjSkWsh5z3360Qyq8cXJCeVtO71zMFzSSZZd0Rs5nVUuySmWmWFNE6w1XNsSS01Bjq1/b3bxGpyIWCWlIsoBEVvdj1+SVUhom0G6ESipmXGH3xeW1N4xwl7pdnXc5fxM65/UKJxols15pyTipDAfhSuWVJXH+4OKTpvAJzUcm0kmePpe8M+53vyHOnUNdQVClCNDIlnStaJafpRDlBzyzhIloBUj4ySPrbUS3AAn7qFBSFdjAUBQUOQWBJ3oM11AdTjgRg8Q8Zy3pdH4l0CHoV6w/5mmsyK1QmM8Rb3RPnLnCKU8Twc1Xxtq+Dj6ioZIln+nLsZh1h8mTGoBlmK+q8EVEKJ2pLu2OnUBS5JClyJ/WJYhJu/zZ5X9daDW49fUe+gdDXPmkksE2wGMgho+SQG8Y75U3Jo5yxhkDfphfHfsSlD71g1SfxB4v4yWSCg/z/WafnMGiq4Zwptz1+qfDI2oFJlgjQyWs1j/p8jKCFLkr9oPFaBEZ2B4aPh3w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(7416014)(376014)(10070799003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kmcPo6fmRptx6CRdZrK7XnS12tnW+Ob00UId9DjIEV1N2xs62uS9SlfgGNT5?= =?us-ascii?Q?I7oFiec8X1WEBIHDcwFYrVPnzakYEBn1+hqNY3y/Np+k9UfTM6dlQcDGcwOc?= =?us-ascii?Q?KSsmtZiOSib5f9RBgWKYWhPU8avcKxt+v1V0PaKsyZ4luexRibTU6BMu3kkb?= =?us-ascii?Q?sh2hmngLYWqZBbVxBur6zzMHpg5ojxM4uT6eGFE7n7JttVNroLdsVpOCZNpi?= =?us-ascii?Q?wR1WIUYNOo3c1RDggHXVCTOsu3nBYeiEto7Tq6/i5+wmuFuE7JVmrdV4Wxd8?= =?us-ascii?Q?D33+MqXMJiSOA9sr2/DUKv0FJE5QI2UeijtaBNo6R/AwOaDgY/Pxn+es65rT?= =?us-ascii?Q?WxXlGOrO3uWxwcnh0Qp24TN44rCCYwU8yXNvlxXgE8OTMr1wayaiErG+Hq24?= =?us-ascii?Q?X5A4o+HuDFsiZSWASCUJT1IOkvGHssvzMArZIai7xNGsC9R/JWgqAK1veGFU?= =?us-ascii?Q?9cSwVrTZYTbMWMeKkg797YMqIoIwCwu2qlIDreNOyeHdiQgTkM8nBI7u7IJK?= =?us-ascii?Q?p7bsHI3Vjk9W9SgOUnAT+SfZg282Ti/88WWlam5mDP2e7WK3i+dSrB6F6Gw0?= =?us-ascii?Q?GfNjDlU1odXMXA3w23x8s9cBukOy37CU/kwoqAn8qziCE+hRxJvUFdqLwbUT?= =?us-ascii?Q?QcrmuqsF96tOwCvffNbelqIjSTvLFv/yyzmyVAZ9Llmxejjss1VuGz0sf1xq?= =?us-ascii?Q?VDRMWPW2cLCMyI6driJKXIuoLOk5fjn8GYAMsS3bT1ks66E2JaMZoqldYTVR?= =?us-ascii?Q?CRE0gRfUPweDfoRhX1sMQC/jPuoBVPWKIYnx+B8BDqMqHFIa7Q2NWIh++ATu?= =?us-ascii?Q?uEz5pVG/IaOzXSJLAy40x2aCWUf+6QdOq5WL/BkEiM8csQLPh+xiP7SdRJSJ?= =?us-ascii?Q?hkKTkqW369bilv5688Ehh2xHbVcaQne0D5xn6p2D9QPW+2iemmr/GaMN/aof?= =?us-ascii?Q?cSF5JsTFgkJCJhOl79zifRH9V8DvcG+WcUXGw2yDP5D/nXzTBqFm55p37L/A?= =?us-ascii?Q?H77dj3hwjEeCQXqRCRVtVQACc5raRj5QtJAshCyrA+hPZmh2ac148MMq33SN?= =?us-ascii?Q?LB77Ff90lf//5ldWHAnNXYFBIyfTcmCMViLhpAZtxV5luwUj0mlxEX52wWaI?= =?us-ascii?Q?F8h+gKxM8bM8Oxxc/jjbNqYOx0COMY88Ie0EvfK+pwNJG+hIYX1KiL59OJpU?= =?us-ascii?Q?EmahtrpOvqD3DKIoWm5gl7Sa9GrEDm0I46eqOR/APbrcL/li3cE21YQb0L8C?= =?us-ascii?Q?OanVuhtrKG1Vid4ezwGZONnV+WFyw5nw0YOvDxjsPgcIbKkdYJswSmVJragm?= =?us-ascii?Q?z1AAzr1ffezE74IYSc9Ipfe4bPXGsGtDl+QZcB+Vs7nrtdwur+dE6D46aGGC?= =?us-ascii?Q?Klvdfth8FLujQbgWQhGQnlZSmVqVzZyxvqYq/VKmNFxhrJxCnOBl2j0qMG2O?= =?us-ascii?Q?fq0fBs+4uBAZzWjf2nmhohiIlwerFlHmRxV1/CBerMpZHpxyyVwfwcPAoRa6?= =?us-ascii?Q?T9QAtyq9eV58HW2G1MGzM87kXRNpj44qQaVn/bPcOo3B06XkPK77km917hwS?= =?us-ascii?Q?+oXUVZccU9P4Q8DFGpy0qJlqHe5cd/1uGrHjMy1p+yt2TM5CZnizKr7Jq2KU?= =?us-ascii?Q?L3OJ+CJ8i3LmH2RNCAJU1hPWISDDwKvtk8pufEB8ZMUlOLe9C2VlLzkQd9u4?= =?us-ascii?Q?boHrg+DkH+xzNUfXL3BO4C5gjdWtTAMPCIdUriZ3CjCNDqxbArZipulOCvly?= =?us-ascii?Q?428BzznIgc6P4uOl2XRqpLv6u4wFqcXZGNHimO3dDrod1A1b2fqNmm91TybR?= X-MS-Exchange-AntiSpam-MessageData-1: HF2eafndh9FfyQ== X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 48dcbeaa-84cd-4c33-485b-08ded8e3ae2c X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 09:15:52.6061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /KYaUN8VH2Le7wWtViC/OOGIMQYPFVDfpI6KJdndlSqIv3cnEqd3dQwKcaomwQlYAI0oKYiYxgDdbDiZYPcPiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3P286MB3731 X-purgate-ID: tlsNG-4011c0/1783070157-3C67BDDE-406116AF/0/0 X-purgate-type: clean X-purgate-size: 3386 Make cpu_nr_siblings() an architecture-specific function. This patch provides the implementation for x86 and a common version for Device Tree-based architectures. Signed-off-by: Hirokazu Takahashi Acked-by: Jan Beulich --- xen/arch/x86/include/asm/processor.h | 1 + xen/common/sched/credit2.c | 22 +++------------------- xen/include/xen/cpu-topology.h | 5 +++++ 3 files changed, 9 insertions(+), 19 deletions(-) diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 8ca6799a81..9758060129 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -106,6 +106,7 @@ extern void intel_init_arat(void); #define cpu_to_core(_cpu) (cpu_data[_cpu].cpu_core_id) #define cpu_to_socket(_cpu) (cpu_data[_cpu].phys_proc_id) +#define cpu_nr_siblings(_cpu) (cpu_data[_cpu].x86_num_siblings) unsigned int apicid_to_socket(unsigned int apicid); diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index ada430f262..6c645f0e21 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -29,22 +29,6 @@ /* #define d2printk printk */ #define d2printk(x...) -/* - * TODO: Abstract this properly, and figure out what Credit2 wants to do with - * the fact that x86_num_siblings doesn't even have the same meaning - * between x86 vendors. - */ -static unsigned int cpu_nr_siblings(unsigned int cpu) -{ -#ifdef CONFIG_X86 - return cpu_data[cpu].x86_num_siblings; -#elif defined(CONFIG_CPU_TOPOLOGY) - return cpu_topology ? cpu_topology[cpu].num_siblings : 1; -#else - return 1; -#endif -} - /* * Credit2 tracing events ("only" 512 available!). Check * include/public/trace.h for more details. @@ -882,9 +866,9 @@ cpu_runqueue_match(const struct csched2_runqueue_data *rqd, unsigned int cpu) /* * Additional checks, to avoid separating siblings in different runqueues. - * This deals with both Intel's HTs and AMD's CUs. An arch that does not have - * any similar concept will just have cpu_nr_siblings() always return 1, and - * setup the cpu_sibling_mask-s acordingly (as currently does ARM), and things + * This deals with Intel's HTs, AMD's CUs and ARM's SMT. An arch that + * does not have similar concept will just have cpu_nr_siblings() always + * return 1, and setup the cpu_sibling_mask-s accordingly, and things * will just work as well. */ static bool diff --git a/xen/include/xen/cpu-topology.h b/xen/include/xen/cpu-topology.h index ee34425680..646cd0ff04 100644 --- a/xen/include/xen/cpu-topology.h +++ b/xen/include/xen/cpu-topology.h @@ -41,6 +41,7 @@ static inline void init_cpu_sibling_map(unsigned int cpu) #define cpu_to_core(cpu) (cpu_topology ? cpu_topology[cpu].phys_core_id : 0) #define cpu_to_socket(cpu) (cpu_topology ? cpu_topology[cpu].phys_socket_id : 0) +#define cpu_nr_siblings(cpu) (cpu_topology ? cpu_topology[cpu].num_siblings : 1) #else /* CONFIG_GENERIC_CPU_TOPOLOGY */ @@ -64,6 +65,10 @@ static inline void init_cpu_sibling_map(unsigned int cpu) #define cpu_to_socket(cpu) (0) #endif +#ifndef cpu_nr_siblings +#define cpu_nr_siblings(cpu) (1) +#endif + #endif /* CONFIG_GENERIC_CPU_TOPOLOGY */ #endif /* XEN_CPU_TOPOLOGY_H */ -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 09:43:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 09:43:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353079.1609245 (Exim 4.92) (envelope-from ) id 1wfaQp-0003LT-MM; Fri, 03 Jul 2026 09:43:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353079.1609245; Fri, 03 Jul 2026 09:43:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfaQp-0003LM-JL; Fri, 03 Jul 2026 09:43:35 +0000 Received: by outflank-mailman (input) for mailman id 1353079; Fri, 03 Jul 2026 09:43:34 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfaQo-0003LG-2B for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 09:43:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfaQm-00AoAH-UE for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 11:43:32 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47842d-bab6-0a2a0a5309dd-0a2a450cd956-48 for ; Fri, 03 Jul 2026 11:43:32 +0200 Received: from [195.135.223.131] (helo=smtp-out2.suse.de) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a478444-f399-0a2a450c0019-c387df83ea1c-3 for ; Fri, 03 Jul 2026 11:43:32 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0819076252; Fri, 3 Jul 2026 09:43:32 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D6D31779AA; Fri, 3 Jul 2026 09:43:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +XcVM0OER2pNAQAAD6G6ig (envelope-from ); Fri, 03 Jul 2026 09:43:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1783071812; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kfDPJrMP2pjLPfibCY+Wnky6tntoznQRsfn+ZLs5Pes=; b=RR60CSW3s+Lm/h7OglM5SaYhQA9LI8MDCZSc6SZD5b/d3kJpp3bbbBXB55r6ikjb2iC7lt qIuiJV/Mvp6LbHCnUDhE/W08yhA5lDoORHbIeYQg4Aj5NLfrYY3bSGKs2bVr5ZYHSjsK7y Zf8YQ8zm8hVuJvrSdxkZl4MfCcAaVIw= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1783071812; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kfDPJrMP2pjLPfibCY+Wnky6tntoznQRsfn+ZLs5Pes=; b=RR60CSW3s+Lm/h7OglM5SaYhQA9LI8MDCZSc6SZD5b/d3kJpp3bbbBXB55r6ikjb2iC7lt qIuiJV/Mvp6LbHCnUDhE/W08yhA5lDoORHbIeYQg4Aj5NLfrYY3bSGKs2bVr5ZYHSjsK7y Zf8YQ8zm8hVuJvrSdxkZl4MfCcAaVIw= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v7.2-rc2 Date: Fri, 3 Jul 2026 11:43:31 +0200 Message-ID: <20260703094331.1752102-1-jgross@suse.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spamd-Result: default: False [-2.78 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.18)[-0.882]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:mid]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Spam-Score: -2.78 X-purgate-ID: tlsNG-d25034/1783071812-9273FD51-CF3BC3DE/0/0 X-purgate-type: clean X-purgate-size: 1756 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-7.2a-rc2-tag xen: branch for v7.2-rc2 It contains the following changes: - A patch by Jan Beulich renaming function parameters and a comment related to xen_exchange_memory(). - A patch by Thomas Huth replacing __ASSEMBLY__ with __ASSEMBLER__. - A patch by Michael Bommarito adding some sanity checking to the Xen pvcalls frontend driver. - A patch by Wentao Liang fixing error handling in the Xen gntdev driver. - 4 patches by Yousef Alhouseen fixing several minor bugs in Xen related drivers. Thanks. Juergen arch/x86/xen/mmu_pv.c | 15 ++++--- drivers/xen/gntalloc.c | 19 +++++--- drivers/xen/gntdev.c | 8 +++- drivers/xen/pvcalls-front.c | 88 ++++++++++++++++++++++++++++++++----- drivers/xen/xen-front-pgdir-shbuf.c | 12 +++-- drivers/xen/xenbus/xenbus_xs.c | 6 +++ include/xen/interface/xen-mca.h | 4 +- include/xen/interface/xen.h | 8 ++-- 8 files changed, 124 insertions(+), 36 deletions(-) Jan Beulich (1): x86/Xen: correct commentary and parameter naming of xen_exchange_memory() Michael Bommarito (1): xen/pvcalls: bound backend response req_id before indexing rsp[] Thomas Huth (1): xen: Replace __ASSEMBLY__ with __ASSEMBLER__ in header files Wentao Liang (1): xen/gntdev: fix error handling in ioctl Yousef Alhouseen (4): xen/front-pgdir-shbuf: free grant reference head on errors xen/gntalloc: make grant counters unsigned xen/gntalloc: validate grant count before allocation xenbus: reject unterminated directory replies From xen-devel-bounces@lists.xenproject.org Fri Jul 03 10:35:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 10:35:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353121.1609255 (Exim 4.92) (envelope-from ) id 1wfbEY-0003ZH-6e; Fri, 03 Jul 2026 10:34:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353121.1609255; Fri, 03 Jul 2026 10:34:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfbEY-0003ZA-3a; Fri, 03 Jul 2026 10:34:58 +0000 Received: by outflank-mailman (input) for mailman id 1353121; Fri, 03 Jul 2026 10:34:55 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfbEV-0003Yy-NM for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 10:34:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfbEV-00GptB-3t for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 12:34:55 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47903e-5cb7-0a2a0a5109dd-0a2a450ab3c0-16 for ; Fri, 03 Jul 2026 12:34:55 +0200 Received: from [209.85.208.177] (helo=mail-lj1-f177.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47904e-e40e-0a2a450a0019-d155d0b1a9f0-3 for ; Fri, 03 Jul 2026 12:34:55 +0200 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-3995e22ef81so13776451fa.1 for ; Fri, 03 Jul 2026 03:34:54 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed136f8c6sm377488e87.17.2026.07.03.03.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 03:34:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783074894; x=1783679694; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IVVSDVvGSqDjS8eedHXV2NuXXVvLPdFwplVOOg+Moow=; b=Cm3MqSGJUl1BOxXd5ebJK3IVB4plyVYdHWVq55kGvXFbqx+19JhWDqb/AOP4M52Hvy rYjTD0yR8YPncViFbJRgxg3UZmzeusEdqSEeDG4JksPh1I1KwEOwbXsVe44AjWSmlrYC bMe1gJTOj+zE65kF5w3pHL3VhzPdVdzzFmGij0RL0rX79WV56Yuf7VIaYnNbOEkxABE6 iVULKdEK22Vm5P62zJMSMabCiAFCQGzaiciKI4ve6Pizw9kQ5Yq3h36vsiwwioaPggA+ Zk57JFICkcNpLEJ0rcXH2Erpc5HKjxUcOmZxrGy424yv256nghcfNs7Vx6O1Wmvunng3 v7pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783074894; x=1783679694; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IVVSDVvGSqDjS8eedHXV2NuXXVvLPdFwplVOOg+Moow=; b=KX2co7Y67zxT5C03bUc22GZCgeRYOF8RUY29zx9UReJsmDXG6kjWTD5fhCOiNBgNaP T6zjILRn3pC870sGUddlANlak23qKuODexheUcGJDPnus3UkKuZW9DH9IH7KowmDIAX6 3G1vL1ELLUNENwx2oa7/EjtjGpV64XEPlawweRpFm7jWrlD/wvbYA24oT60F6ePfxuWO 5I1sFdpn1Nmp2Rhph9JsYv7f48QdeSVH0hsWb9FgzjPEoprw3yctnzultgvW83qRX6II Px3OqZSQWZHArqnX2is++eXei/ZJ4yoOaBQ7AKqI3GpYMyP+Hwa6pSUk3PgjZuGayZiQ PUjQ== X-Forwarded-Encrypted: i=1; AHgh+Ro3RILp9IqAfY7sG2DP6vCvYGYlNriPvVFUOQ4ykPbt9/5ZShGdwKQEk+VXfqaZjk2frCuUYRCrcSA=@lists.xenproject.org X-Gm-Message-State: AOJu0YwOIBI5IesAspz1vZg3OpHY60R3YvIHOkmiXH25mZg1CeLvd8oM eu4SqAJ1Tt1ab8v6u5a6NXKxiLGOEujZAo58tjCE+azsdeXF3sG/UEflPVFotQ== X-Gm-Gg: AfdE7cmH3yQ2W1GC5BbIX/4ZGrAhv+oxPS/O1X+Ou7iMXvuzIYkgiHA8OQWt3ej4sS4 9HYXuWL0o4GbjBBMAU3DiqtIRPRJLFtGaNTFg0jhXfe+7paQVQAS18ujxeukNP7iy8FjZnuBgRB ebFunoRAf/JMo9ShvG9G0EkvXMWgu9gmPZ+FXDLI0sKnUA9eMlPad0WC6QA9tNmTGknp6E2C7Nw RZ4oHoQ+dC2QjxrLpgE+6JTNMRs7q/r4NsTo1JwnUCKRMoi9hWC8Irly06uNnDLykb1Z5QDry1C s3RFQOhljt2YljeOX/x+lxfIJ+CpeFLdQGdTrxd6tza+DV01bTBXLUcwhUwGwbF5xYc+OtlQj12 +DzsZFoiTEoBN+w8v6TqrT9CFSWcxjpsinPkgT4sc7rViaTlDlltLEJSIcKXhes9+LBhEkzLXrG hj/lOpcm2uQNfg/b2WL4z59//uKCkzsO/voP17XHzLibivvfd9kiCzcVV6JJHWLftDEO4LqUVW3 CLhsA== X-Received: by 2002:a05:6512:8393:b0:5ae:b7c1:f7a with SMTP id 2adb3069b0e04-5aecf506c4fmr601997e87.30.1783074894038; Fri, 03 Jul 2026 03:34:54 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 12:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 21/25] xen/riscv: implement IRQ routing for device passthrough To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <472a77604d35a0bc2a75b71f250fd67b63afde4c.1782487661.git.oleksii.kurochko@gmail.com> <6aafbeb5-2f33-49f4-9d14-937b0bc4d15d@gmail.com> <40bcf6b7-306a-419a-bf12-1855f9e589fe@suse.com> <91ffc1b2-7648-4185-a2f1-12b30181c8a9@gmail.com> <9a8c4ef2-ae6d-48bc-bd41-6c3147acaff8@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <9a8c4ef2-ae6d-48bc-bd41-6c3147acaff8@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1783074895-3DC0CDDE-162FCA1B/10/73395122804 X-purgate-type: spam X-purgate-size: 6865 On 7/3/26 9:21 AM, Jan Beulich wrote: > On 02.07.2026 18:04, Oleksii Kurochko wrote: >> On 7/2/26 4:32 PM, Jan Beulich wrote: >>> On 02.07.2026 11:33, Oleksii Kurochko wrote: >>>> On 7/2/26 8:38 AM, Jan Beulich wrote: >>>>>>>> + spin_unlock_irqrestore(&desc->lock, flags); >>>>>>>> + >>>>>>>> + release_irq(desc->irq, info); >>>>>>>> + xvfree(info); >>>>>>> >>>>>>> If, in release_irq(), action isn't freed, it's ->dev_id field will now have >>>>>>> a dangling pointer. (I think I did point this out before.) > > We'll be back to this if ... > >>>>>> It should freed in release_irq() as route_irq_to_guest() always set >>>>>> action->free_on_release = true; >>>>> >>>>> Well, "free_on_release" must exits for a purpose. I.e. there must be, now >>>>> or soon, cases where it's set to false. Else simply drop the field. >>>> >>>> I can't simply remove this field because it is part of the common >>>> `struct irqaction` and is used by other arc-s. (I assume that it is not >>>> what you fully meant...) >>>> >>>> IIUC, this field is used to determine whether an irqaction is >>>> heap-allocated (and therefore should be freed) or statically allocated >>>> (and therefore should not be freed). >>> >>> Yes. However, all uses of the field are in arch-specific code. So in >>> principle it could be #ifdef-ed out for RISC-V. There may be a better >>> option, though: >>> >>>> At the moment, all IRQ actions are heap-allocated (on RISC-V), so >>>> free_on_release should always be set to true. In particular, the code >>>> snippet you asked about releases a guest interrupt, and guest interrupt >>>> actions are always heap-allocated. As a result, when release_guest_irq() >>>> calls release_irq(), the associated irqaction will be freed. >>>> >>>> So, from what I can see, the current behavior is correct and I think it >>>> should be left as it is. Do you have any concerns about this? >>> >>> If you only ever have the field set to true, use ASSERT() in place of >>> if(). >>> >> >> It looks like that if we want an `ASSERT()`, it should be in >> `release_guest_irq()`. However, that would require duplicating part of >> `release_irq()` to locate the corresponding `irqaction` and verify >> `free_on_release`. Since guest IRQs are created through >> `route_irq_to_guest()`, which always sets `action->free_on_release = >> true`, we are already safe. >> >> I don't see much benefit in replacing the `if` statement with an >> `ASSERT()` in `release_irq()`. The current implementation is generic and >> would also work for Xen-owned, statically allocated interrupts (even >> though there are none today). If we replace the `if` with an `ASSERT()` >> now, anyone introducing a Xen-owned, statically allocated interrupt in >> the future would simply have to revert the change and restore the `if` >> statement, bringing us back to the current implementation. > > ... such a change was made. Imo you have two choices: Deal with the issue > properly right away, keeping the if(). So then my fix will look like as embed struct irqaction as the first member of struct irq_guest and allocate them as one block. Then xvfree(action) inside release_irq() (gated by the still-meaningful if (action->free_on_release)) frees the whole thing - no separate xvfree(info) needed anywhere, so the dangling pointer can't happen regardless of what free_on_release is: $ git diff diff --git a/xen/arch/riscv/irq.c b/xen/arch/riscv/irq.c index 830f8d5d5997..146156f1caae 100644 --- a/xen/arch/riscv/irq.c +++ b/xen/arch/riscv/irq.c @@ -19,9 +19,18 @@ #include #include -/* Describe an IRQ assigned to a guest */ +/* + * Describe an IRQ assigned to a guest. + * + * The irqaction is embedded here (rather than allocated separately with + * its dev_id pointing at a standalone struct irq_guest) so that freeing + * the action in release_irq() also frees this whole structure in one go. + * That avoids the alternative of release_irq()'s caller having to free + * dev_id itself (something like in Arm release_guest_irq()). + */ struct irq_guest { + struct irqaction action; struct domain *d; unsigned int virq; }; @@ -345,7 +354,6 @@ int release_guest_irq(struct domain *d, unsigned int virq) spin_unlock_irqrestore(&desc->lock, flags); release_irq(desc->irq, info); - xvfree(info); return 0; @@ -369,20 +377,23 @@ int route_irq_to_guest(struct domain *d, unsigned int virq, desc = irq_to_desc(irq); - action = xvmalloc(struct irqaction); - if ( !action ) - return -ENOMEM; + /* + * release_irq() frees this action via xvfree(), relying on action + * being the first member of struct irq_guest so that &info->action + * coincides with info itself. Guard the layout so a future field + * reorder can't silently turn that into a free() of a mid-allocation + * pointer. + */ + BUILD_BUG_ON(offsetof(struct irq_guest, action) != 0); info = xvmalloc(struct irq_guest); if ( !info ) - { - xvfree(action); return -ENOMEM; - } info->d = d; info->virq = virq; + action = &info->action; action->dev_id = info; action->name = devname; action->free_on_release = true; @@ -436,15 +447,13 @@ int route_irq_to_guest(struct domain *d, unsigned int virq, if ( retval ) { release_irq(desc->irq, info); - goto free_info; + return retval; } return 0; out: spin_unlock_irqrestore(&desc->lock, flags); - xvfree(action); - free_info: xvfree(info); return retval; Also, with such approach release_guest_irq() could be dropped at all, at least for now. Does this approach look good? Or assume "free_on_release" is only > ever true, and add an assertion to this effect (indicating that code needs > auditing if that assumption is broken). I think I'm okay with using ASSERT() instead of the changes suggested above. What I don't understand is why you think it would be better to put the ASSERT() in release_irq() instead of keeping the if(): ``` ... if ( action->free_on_release ) xvfree(action); } ``` As I understand it, the dangling pointer problem would only occur if someone started statically allocating guest interrupts, right? At least for now, all guest interrupts are heap-allocated by route_irq_to_guest(). So my understanding is that we want to ensure that nobody starts statically allocating guest interrupts in the future. If that's the case, wouldn't it make more sense to add the ASSERT() to release_guest_irq(), somewhere before xvfree(info); rather than to release_irq()? ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Jul 03 11:00:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 11:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353152.1609263 (Exim 4.92) (envelope-from ) id 1wfbcx-0008BT-2m; Fri, 03 Jul 2026 11:00:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353152.1609263; Fri, 03 Jul 2026 11:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfbcw-0008BM-W9; Fri, 03 Jul 2026 11:00:10 +0000 Received: by outflank-mailman (input) for mailman id 1353152; Fri, 03 Jul 2026 11:00:09 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfbcv-0008BE-Mh for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 11:00:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfbcu-000Np5-FA for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 13:00:08 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a479632-bab6-0a2a0a5309dd-0a2a45048592-24 for ; Fri, 03 Jul 2026 13:00:08 +0200 Received: from [209.85.167.50] (helo=mail-lf1-f50.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a479638-a01d-0a2a45040019-d155a732b503-3 for ; Fri, 03 Jul 2026 13:00:08 +0200 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5aec5675c46so466737e87.1 for ; Fri, 03 Jul 2026 04:00:08 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13c5c11sm393585e87.77.2026.07.03.04.00.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 04:00:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783076407; x=1783681207; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3Ohgw0X4VP/JMwTkY286QlvDpibdPKHXNfR1zkAuVBA=; b=pGvAw/G5XuLLNzW/xEa+ZrqPza7Mha4z3p2ERiMnY4ZmAGUecqQWJ+BGlvLw8l2xo8 8wgaWLuIm3sZKFfV03snxgRMmguM1fDeflsb/6TmuA7oftSoHj1V5iToc1AYTEWA6A38 s9AGAz8mrqZRm1YIC7N5V+qTIrW4f5BxnLK1BfmJ+xI0oGML7/Ro01u7DT/9kbpHNJtQ 5LOURGoT0Fw3XmpHPqb7CyBivWHJy6gwwDmpZpz0Mnkmi0HzWov5qYf/Hh/S9IVoSbfv HyUgnNu6Hgw5WxSazRWlvdOYGbEyLi65Zv7bhtvhpxtDf2687ksaBqVuXUZn/juIaJ+j uxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783076407; x=1783681207; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Ohgw0X4VP/JMwTkY286QlvDpibdPKHXNfR1zkAuVBA=; b=NMoSG+SN4184Kn9eKSXtK/IB9VNz5gq9SsIQkNhI0KM5S+BvqPk703Q238egYh6I7n 64RBifGd927DN7dU/qn2pGVc8u3Fxx4FN+WlVJn9i7ZFCwawMjyChANB+QXa0IvaAMsT FIprYw4bp2Q2e0ezdQYF1ZWkxvTySZKDS+BHej+f5IU/RbkWfrafUTMmqexOxHmTq+QK N42DJpRc/S555zGIceFsvZ/+uhVW/zEvOATSSav/2GYiVB2uhjQd1GpZk/xHvkJkaWif zRVmHxX3n2Z2NDiCkNKORkgQzOPTjlMUyQC+bbfxUH7B4mVqgfgJkVdYQ9dON9TmTN3g U3Dw== X-Forwarded-Encrypted: i=1; AHgh+Rq5PcTya2QAc3wM08jhn754xaOYv/VKSSDEa6eqbt6tsr2G+ibIg80obLhvAkSoBygVu5MyBTvOzhY=@lists.xenproject.org X-Gm-Message-State: AOJu0YwFq74eski22lO+DjnBMQFUiMh5pfGIV32Be43d6pkphIIXfdDu ofCHAmRp0fvdX46FrOT3x+wHiK3uHrt+qZ4KCFkvUpkgKdjf2pQ9Hrhg X-Gm-Gg: AfdE7clQQZqXJpDgjRrAM8Ge/d2xg+vvxzR3UO6CN1OyAy9xv2RG7lE8ujErG0/zv4K Gky75bhrap+Pm7e2P4xAAzO1NKgsC+ZSy2/P0ynCYGU4nZneIpgnZMdCPKPpLkVzGh4ijoOzQIy H8MN5AJb21SlPldgQu0nxtwwh4+Xuxd3Hl6NfgqhCceIhLbaqKuT6b+jTpyOZXBjRxbMneu9k5q r6AcZGErqPVdFw4fHqWuI+47UaFWPXWmLUoOIwwoh4HQDCQnPIONN2QrcBo/DsShmLPYCvC42qC +Xf/Wa6i4BmLanYVKbWcD0S3A9Ev/MLLmGol1yJM+FBHnBXtu7aiSgcZfVdd/tViYmKYL41YVYy t+4tOv4zFwKoDLIzKl/Ej1bdoHDaQiID4qNMYc8/sTU+8dHfiP4RNnFOnHp5V1Dbnsnq//EqzFb scOIQkV9Ink4cpPT82EwQhSS7/fhgfyFJ7yozj2RDE7iEr0pX1vmRgCswr2SKX/oE3+o76RZVMw f6duA== X-Received: by 2002:a05:6512:611:20b0:5ad:518a:61dd with SMTP id 2adb3069b0e04-5aec68b8313mr1589861e87.46.1783076407393; Fri, 03 Jul 2026 04:00:07 -0700 (PDT) Message-ID: <0c12eeed-5e3c-4289-9b19-156530c3b822@gmail.com> Date: Fri, 3 Jul 2026 13:00:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-4.22] tools/libfsimage: Remove the XEN_FSIMAGE_FSDIR environment variable To: Andrew Cooper , Xen-devel Cc: Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini References: <20260702150301.825883-1-andrew.cooper3@citrix.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <20260702150301.825883-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1783076408-AFD241CC-8B680338/10/73395122804 X-purgate-type: spam X-purgate-size: 2631 On 7/2/26 5:03 PM, Andrew Cooper wrote: > This was reported to the security team, demonstrating that code execution > could be achieved, but without a demonstration of a priviliege boundary being > bypassed. > > Still, it's a high risk path with no obvious evidence of having been used even > for debugging, so remove the environment variable and use the build time > $(libdir)/xenfsimage path only. > > Signed-off-by: Andrew Cooper > --- > CC: Anthony PERARD > CC: Michal Orzel > CC: Jan Beulich > CC: Julien Grall > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Oleksii Kurochko > > For 4.22. This was supposed to be posted earlier but fell through the cracks. > Given it's borderline-security aspect, we don't want to delay it any further. > --- Release-Acked-by: Oleksii Kurochko > CHANGELOG.md | 1 + > tools/libfsimage/common/fsimage_plugin.c | 5 +---- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index ef4e6ae9c459..0a4e5f013cb1 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -63,6 +63,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > - Removed xenpm tool on non-x86 platforms as it doesn't actually provide > anything useful outside of x86. > + - Removed the XEN_FSIMAGE_FSDIR environment variable. > > ## [4.21.0](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.21.0) - 2025-11-19 > Acked-by: Oleksii Kurochko > diff --git a/tools/libfsimage/common/fsimage_plugin.c b/tools/libfsimage/common/fsimage_plugin.c > index d0cb9e96a654..539dc247356a 100644 > --- a/tools/libfsimage/common/fsimage_plugin.c > +++ b/tools/libfsimage/common/fsimage_plugin.c > @@ -121,7 +121,7 @@ static int init_plugin(const char *lib) > > int fsi_init(void) > { > - const char *fsdir = getenv("XEN_FSIMAGE_FSDIR"); > + const char *fsdir = FSIMAGE_FSDIR; > struct dirent *dp = NULL; > DIR *dir = NULL; > char *tmp = NULL; > @@ -129,9 +129,6 @@ int fsi_init(void) > int err; > int ret = -1; > > - if (fsdir == NULL) > - fsdir = FSIMAGE_FSDIR; > - > if ((name_max = pathconf(fsdir, _PC_NAME_MAX)) == -1) > goto fail; > > > base-commit: ad9f564a5d840389cbf1b230086e1dd8257d8820 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Jul 03 11:44:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 11:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353248.1609272 (Exim 4.92) (envelope-from ) id 1wfcJh-0006iy-72; Fri, 03 Jul 2026 11:44:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353248.1609272; Fri, 03 Jul 2026 11:44:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfcJh-0006ir-4L; Fri, 03 Jul 2026 11:44:21 +0000 Received: by outflank-mailman (input) for mailman id 1353248; Fri, 03 Jul 2026 11:44:20 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wfcJg-0006il-CA for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 11:44:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfcJe-00BDe4-MN for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 13:44:18 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47a08f-bab6-0a2a0a5309dd-0a2a4504eda6-6 for ; Fri, 03 Jul 2026 13:44:18 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47a092-a01d-0a2a45040019-d155802fb5ee-3 for ; Fri, 03 Jul 2026 13:44:18 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-490cf3000f0so4045375e9.1 for ; Fri, 03 Jul 2026 04:44:18 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63b6f1bsm115209625e9.10.2026.07.03.04.44.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 04:44:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783079058; x=1783683858; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hbH1aNFyyNe3stX/uhltfqjToNpdgn2HT2T4a4oOTIY=; b=juyr9FQ0pJEAMSP8eusdoGTMQ2760ch9u2GDVwnGVwLbprlcYntob/haEaFTzBtfoJ a2wT4BZHWWpXj7JjHhYn/diuC43c6aQ1t9MvjioEmZDg0ki/2N1ttMZMWobchPN5Pk/A +sU7ytjg+aZQdb/UyrHoMMBw5qtRL4RTAw+ulK2q7JdUac26mCYaUP+c4yjd6VZ7th+9 cfPMNwlg4FM37daThBck+8qvR7J+oaI7SRNv1XVy2JwfA2Pusx+1VP8qt7ll0a+DiIaQ I86sZz4+gyPk2PK0HiKyuwKB2q9mic/4z8NsNTcSPV1+VJ1VWKgk7aFBoFegmHCKo2xf bCtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783079058; x=1783683858; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hbH1aNFyyNe3stX/uhltfqjToNpdgn2HT2T4a4oOTIY=; b=iCnOCZ5a7gTetAewiqE6LA/9fkMgAZLNUmmHBAaro5UOb7bzDD+4BtVS+xgJrSGJ8w m6HLfgVPBZKa6r7aagBZRzvM1jDJmXMqDBHoi9BkJm29ENcNeZDOykVzwnhKVA4G51Yz y3fbITbeEXySgmSNYF+iggkwCcSLexf9Wd+ftU1LnmdkSOHbq7vOwfCoObQQfPJQT8JS FtkuIoGnzZN1PeD8QomI1X24I0PgZgV5hdD8mlWzSHZiqWwnfaeQbokV+G2YH2y2z7Cj Al04Dm6T1/G+qbQgpwOaSQZpeQT/S1WVBrSpDzaOr8oQfAhDi/mjn/NLP1bNC8n9qSHw MZvA== X-Forwarded-Encrypted: i=1; AFNElJ860CSiy65YP8K9WU7vk3Ts1jEWDnZTqsHe3eAF/6KFISXcnGnEoDayr5oQfI/6onWPmcW17KBD8fo=@lists.xenproject.org X-Gm-Message-State: AOJu0Ywwc3+S8osuYr1kl7t7kUOKu9B21uYy292iuLo3rI8pB18sZ0Xw 2hR3xQpAHeUbR/9pfWcBryfeou8t300hDrlVPTrGR94UyT/jEhPsX4Ov X-Gm-Gg: AfdE7cn8ouj0wxBbin+Tut43eucJWidiq/Pdsh0I/aA7Z1o9RBk4rn5JssZ0hXgJu30 8L+mjb4UXqWqq75Lw+X8vTn7R5g8iGn1hOpSfusCQ5FV4SkMnn6dLZtnI+fgfNYOeYiVv0/D15r Gdl8kw5w1XO4bf1NN7Un2eiF6IE/NdCu/n6N6W2n1ylPbwDTQhAwZKq2ACXJMFNe2lIHW6q3pkA y3ekSzS/DYi7l/0lH1mDt57yixPBI61qVw5O3x0JA6j3M9qHQZagnq0rQXHxNYlXTwdhJJjK5jT YeYQAbxT7U50VqW3O+WqQbBGkf9y7Md8mR1v7lwuTqOM04z1PoP5g8uUMlRUWCHI/Jb8WXIZwwG GrpJDdWoIRvChuEX5xIV3eEpxXkQ/mVQTZSgIgTDmyw1vJdZVnJxfCRohUqmkF8/SybwhgsO3aR ngbKFLhF+FjQC5jwhYinNI5yFFLtHCj1j249RuLiqb5kRjvgUGzzbRe4uih7r+HMLYzmI= X-Received: by 2002:a05:600d:3:b0:492:523f:a3df with SMTP id 5b1f17b1804b1-493c2b161b3mr121210095e9.5.1783079058002; Fri, 03 Jul 2026 04:44:18 -0700 (PDT) Message-ID: <30e859e2-ee54-4d02-ac2c-08f8f80547bf@gmail.com> Date: Fri, 3 Jul 2026 13:44:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] xen/sched: Link CPU topology to scheduler To: Hirokazu Takahashi , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Timothy Pearson , Alistair Francis , Connor Davis , Dario Faggioli , Juergen Gross , George Dunlap References: <20260703091544.183548-1-taka@valinux.co.jp> <20260703091544.183548-3-taka@valinux.co.jp> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <20260703091544.183548-3-taka@valinux.co.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1783079058-AC93A1CC-E881F4A2/10/73395122804 X-purgate-type: spam X-purgate-size: 776 On 7/3/26 11:15 AM, Hirokazu Takahashi wrote: > > /* > diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c > index 95946634d1..ada430f262 100644 > --- a/xen/common/sched/credit2.c > +++ b/xen/common/sched/credit2.c > @@ -9,6 +9,7 @@ > * Based on an earlier verson by Emmanuel Ackaouy. > */ > > +#include > #include > #include > #include > @@ -37,6 +38,8 @@ static unsigned int cpu_nr_siblings(unsigned int cpu) > { > #ifdef CONFIG_X86 > return cpu_data[cpu].x86_num_siblings; > +#elif defined(CONFIG_CPU_TOPOLOGY) > + return cpu_topology ? cpu_topology[cpu].num_siblings : 1; Shouldn't here be CONFIG_GENERIC_CPU_TOPOLOGY? ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Jul 03 13:05:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 13:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353320.1609289 (Exim 4.92) (envelope-from ) id 1wfda7-0002Hu-0b; Fri, 03 Jul 2026 13:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353320.1609289; Fri, 03 Jul 2026 13:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfda6-0002Hn-U9; Fri, 03 Jul 2026 13:05:22 +0000 Received: by outflank-mailman (input) for mailman id 1353320; Fri, 03 Jul 2026 13:05:21 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfda4-0002Hf-OC for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 13:05:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfda3-000KTy-SG for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 15:05:19 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47b38e-2eae-0a2a0a5409dd-0a2a4503ce4e-4 for ; Fri, 03 Jul 2026 15:05:19 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47b38e-ec1a-0a2a45030019-b9ff1c22816d-3 for ; Fri, 03 Jul 2026 15:05:19 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f281556cf00080a8.005 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 03 Jul 2026 13:05:14 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 28BA781C0A; Fri, 3 Jul 2026 15:05:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=XKcNaM/91Jjk6ZkU0ufuyTcVGSv3GFLvBuIsiSJ873k=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=Jb1AIBzqGw9LTas0JQj685LG4YzpIivXZ1uVy1vxOoEcU0QmXZvzdYzZ9qyPaeiCk5MSBF6wj /wQCljNUwKR6S6STt5nUuJVrpY4htUlYr3Bg/P1GjcN/AXd0Pd7PZHWkTUJiwgU2ur63RsouxsS OLPoLJCO1BUxQuYtsnX/oCXo8ISdy8InYZyXr+rLUfVw36q6IQj95jqutWYTq3teilOFeZuaBKr oqmWtciLus6VeO5RUTjFNWLQ1+wjTgEdJFzotlYqUm+peZk70Y699EK+Ysl6CLoVHVwNT0WcIOU w8VucvBQITZdoKM+ukaNeVS8K7JX0AIMLWP0qI4gBkkQ== X-Zone-Loop: e43875fd35f7250afce1517219b42109ddd4216cf2e9 x-campaign-type: default x-transaction-id: ee1b7a28-95f5-4953-84d4-8c86cbb2812e x-swg-uid: 01-fa80b72d-2938-47d8-9a39-a70a45392133 X-Mailer: Sweego Message-ID: <1783083915.8631fc262581453bbf619ec5b2062170.19f281556cf00080a8@vates.tech> x-swg-bid: 1783083915.8631fc262581453bbf619ec5b2062170.19f281556cf00080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Fri, 3 Jul 2026 15:05:13 +0200 From: Anthony PERARD To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Juergen Gross , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH] tools: Use posix_memalign instead of valloc for NetBSD References: <20260430095521.8399-1-frediano.ziglio@cloud.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260430095521.8399-1-frediano.ziglio@cloud.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.c6.2ee9de91ac841128.19f28155423.ab549c87a61d0f6d=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1783083914279 X-purgate-ID: tlsNG-33051d/1783083919-B47875D1-F28A5EF1/0/0 X-purgate-type: clean X-purgate-size: 675 ---=Part.c6.2ee9de91ac841128.19f28155423.ab549c87a61d0f6d=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Apr 30, 2026 at 10:55:21AM +0100, Frediano Ziglio wrote: > More similar to other implementation=2E > posix_memalign was adde in NetBSD 8=2E0, released on July 17, 2018 > and went out of support on May 4, 2024=2E >=20 > Signed-off-by: Frediano Ziglio Acked-by: Anthony PERARD Thanks, -- | Vates XCP-ng & Xen Orchestra - Vates solutions web: https://vate= s=2Etech ---=Part.c6.2ee9de91ac841128.19f28155423.ab549c87a61d0f6d=--- From xen-devel-bounces@lists.xenproject.org Fri Jul 03 13:08:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 13:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353332.1609299 (Exim 4.92) (envelope-from ) id 1wfddF-0002xJ-EF; Fri, 03 Jul 2026 13:08:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353332.1609299; Fri, 03 Jul 2026 13:08:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfddF-0002xC-BS; Fri, 03 Jul 2026 13:08:37 +0000 Received: by outflank-mailman (input) for mailman id 1353332; Fri, 03 Jul 2026 13:08:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfddD-0002x6-WB for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 13:08:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfddD-00Bbpy-Br for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 15:08:35 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47b442-bab6-0a2a0a5309dd-0a2a45058cca-28 for ; Fri, 03 Jul 2026 15:08:35 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47b453-3cb2-0a2a45050019-b9ff1c239d81-3 for ; Fri, 03 Jul 2026 15:08:35 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f28184fc000080a8.006 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 03 Jul 2026 13:08:29 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 0ADD381C1B; Fri, 3 Jul 2026 15:08:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=VDWJgtP/AnY0r8NxFjfUJNOMZlOVroSKIzuuLx6zirw=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=jjzMPM0O7g6MSeoGiZG6nGTZV7Lx/U4AoTApaZKym0a7487BngyS/TQgeZy0a9FF95yhLF7jk aSGs9J71BKiQAG+bfc7u10XUqUvByczb3gY1s8Oh+9zxpU0tPkfd998OaU/03a9eMWlegA/jpdW ctAjqL8iqXqtEdp6CJQfT5Wb97W3IGoVgbmhUQAW4jAed8Yi+QzclKW6vXM55LCyU/8K6lYPFEv B+PWmtyFlhcb6F90X1nVY8VK618E5yRfiQ3c+mIieWdwv4sOyBDDMJqCNsdlV9+W1rqX9VxX4BE msUZ6xCWQhhizm6O96JYc1iEiWEfLGTdrJOpx6O1YfWA== X-Zone-Loop: e96cc2f1795bb0a13a820145f52115a20f1a79e15d11 x-campaign-type: default x-transaction-id: cb8cfce5-a343-4065-b258-43e694a50e03 x-swg-uid: 01-a130aedd-fc21-4193-a899-0b5bf17dfe99 X-Mailer: Sweego Message-ID: <1783084109.8631fc262581453bbf619ec5b2062170.19f28184fc000080a8@vates.tech> x-swg-bid: 1783084109.8631fc262581453bbf619ec5b2062170.19f28184fc000080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Fri, 3 Jul 2026 15:08:28 +0200 From: Anthony PERARD To: Andrew Cooper Cc: Xen-devel , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini , Oleksii Kurochko Subject: Re: [PATCH for-4.22] tools/libfsimage: Remove the XEN_FSIMAGE_FSDIR environment variable References: <20260702150301.825883-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260702150301.825883-1-andrew.cooper3@citrix.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.c7.af50758f9556348f.19f28184d77.5869ff7f27bf93b=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1783084109175 X-purgate-ID: tlsNG-c201ff/1783084115-14F072B8-38318739/0/0 X-purgate-type: clean X-purgate-size: 924 ---=Part.c7.af50758f9556348f.19f28184d77.5869ff7f27bf93b=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2026 at 04:03:01PM +0100, Andrew Cooper wrote: > This was reported to the security team, demonstrating that code executio= n > could be achieved, but without a demonstration of a priviliege boundary = being > bypassed=2E >=20 > Still, it's a high risk path with no obvious evidence of having been use= d even > for debugging, so remove the environment variable and use the build time > $(libdir)/xenfsimage path only=2E >=20 > Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.c7.af50758f9556348f.19f28184d77.5869ff7f27bf93b=--- From xen-devel-bounces@lists.xenproject.org Fri Jul 03 13:10:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 13:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353355.1609307 (Exim 4.92) (envelope-from ) id 1wfdf4-0004RP-P5; Fri, 03 Jul 2026 13:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353355.1609307; Fri, 03 Jul 2026 13:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfdf4-0004RI-M7; Fri, 03 Jul 2026 13:10:30 +0000 Received: by outflank-mailman (input) for mailman id 1353355; Fri, 03 Jul 2026 13:10:29 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfdf3-0004RB-RF for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 13:10:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfdf3-00HJ8H-82 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 15:10:29 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47b4bf-2eae-0a2a0a5409dd-0a2a4509ab62-24 for ; Fri, 03 Jul 2026 15:10:29 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47b4c4-97e6-0a2a45090019-b9ff1c12a495-3 for ; Fri, 03 Jul 2026 15:10:29 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f281a15d000080a8.006 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 03 Jul 2026 13:10:26 +0000 Received: from l14 (lfbn-gre-1-197-6.w90-112.abo.wanadoo.fr [90.112.16.6]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 43EA881BF1; Fri, 3 Jul 2026 15:10:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=xUYMzz16TJmepg947+pGYhGIre2CDd2/iM8L4cia8cI=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=gOV/hZ3g8NGAqUHMg8WDRoqzaZow4G0De3jJBLiXTau6I5aKHhI5rqres9ZA1xQRlLIAMxKrp DYPn0QyQkek0gxFWBoRTHMkD+WpFFsbQA65jYGB7+YJ/P45eo/MYWoe2FS/4ItT269o06bKkN8o yPaa91OyF+ndbh5nJuCkSsSqiQj/23RelTTnOWHCLxwUKfk1mTDBisgCH2X7/ZYJcxK1zYvbR0Y G+93c7CFND+xZ3CSLdoL+dr/cjlL+iwMghV3+juVRDh5fVgef9gd0YCQ2qAARAfdnOzykg+c+y9 tifI1RCx2ejegldn0MTlXoYdzEWk7PFPq9QCvYn8V5zg== X-Zone-Loop: b38b0842b25709e937141a36b9064441bca85a7ef37a x-campaign-type: default x-transaction-id: 3a1740db-54fc-4c2a-b1b8-a70c7911fd62 x-swg-uid: 01-72aad2ae-2065-492a-80e5-210a2f103eb2 X-Mailer: Sweego Message-ID: <1783084226.8631fc262581453bbf619ec5b2062170.19f281a15d000080a8@vates.tech> x-swg-bid: 1783084226.8631fc262581453bbf619ec5b2062170.19f281a15d000080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Fri, 3 Jul 2026 15:10:25 +0200 From: Anthony PERARD To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini , Christopher Clark Subject: Re: [PATCH] argo: fall back maintainership into the rest References: <20260702163845.36453-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260702163845.36453-1-roger.pau@citrix.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.c9.8bbea27004231cbf.19f281a1381.e615ae573bc4ba06=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1783084225410 X-purgate-ID: tlsNG-bad1c0/1783084229-56B97986-314FB8B7/0/0 X-purgate-type: clean X-purgate-size: 940 ---=Part.c9.8bbea27004231cbf.19f281a1381.e615ae573bc4ba06=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2026 at 06:38:45PM +0200, Roger Pau Monne wrote: > Due to unresponsiveness of the current maintainer=2E In particular, the > committers have been trying to get in touch with Christopher for 2 weeks= to > have a chat about disputes around recent commits and pending changes to = the > ARGO component without getting any response=2E >=20 > Signed-of-by: Roger Pau Monn=C3=A9 > --- > This patch is on behalf of the committers, and not a personal decision o= f > its author=2E Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.c9.8bbea27004231cbf.19f281a1381.e615ae573bc4ba06=--- From xen-devel-bounces@lists.xenproject.org Fri Jul 03 13:26:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 13:26:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353374.1609317 (Exim 4.92) (envelope-from ) id 1wfduL-0006ro-0g; Fri, 03 Jul 2026 13:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353374.1609317; Fri, 03 Jul 2026 13:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfduK-0006rh-TS; Fri, 03 Jul 2026 13:26:16 +0000 Received: by outflank-mailman (input) for mailman id 1353374; Fri, 03 Jul 2026 13:26:15 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfduJ-0006rb-MA for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 13:26:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfduJ-009BZo-2o for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 15:26:15 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47b874-e002-0a2a0a5209dd-0a2a450acab4-2 for ; Fri, 03 Jul 2026 15:26:14 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47b874-e40e-0a2a450a0019-888fbc3352ad-3 for ; Fri, 03 Jul 2026 15:26:14 +0200 Received: by mx.zohomail.com with SMTPS id 1783085163546356.15735760972905; Fri, 3 Jul 2026 06:26:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1783085165; cv=none; d=zohomail.com; s=zohoarc; b=QDkFvulDrMEXanFNnGDyt5B2JOroMiaGAB9msIxYQ0RnI4d1zDTa8LDuq8Cye3IJgABvQCWw20ZfLYL98aG3YEm6K8gQpZmmvxSPn+FRJteR9QMat0QAtnCjRzoPQiB9u9mUsfcWMa2i2MQbjy6IBkgcEb+wNY5cqvwPCupvP1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783085165; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=ig8ANEKwi0TjwdlfQpJ6o8aEeNdrbGbOiuwMXYgrS2U=; b=ESNqU2tILqAVYfuBgw7flcegEB4mBb3irmu+NBzlw8ZdsBpeDiPOrKlyNszl9WUuaJk+JTOdhzZbjJdI5lntT8Os9Ht9Bx9l5nrhSbU4VjwmTmcnS5CAVfYF9gqVm+l7SS4ZymA2Z513/Zs7WhcTMBWglv+dX1ih9fwBzk/KVYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1783085165; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=ig8ANEKwi0TjwdlfQpJ6o8aEeNdrbGbOiuwMXYgrS2U=; b=uzD2s04WQqKV9AJIiueHwXOAScOqTq/yzbQTZmcANYurMm4O/i+83Wo85gujck4A EOFfSDCW+KabYJiz0IXrgNcT7OndIiqB68y9LpcFhJHSvIFOgcN6dbUMzVGoXTAvfOJ vR6Msy+zNqX1qawiFt6OP3sSMRzpf1I+1SnUt3VQ= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH] maintiners: promote to argo maintainer Date: Fri, 3 Jul 2026 09:18:55 -0400 Message-Id: <20260703131855.3256-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-purgate-ID: tlsNG-4011c0/1783085174-3E20DDDE-F7003CE2/0/0 X-purgate-type: clean X-purgate-size: 774 I have been involved with Argo since its inception and a reviewer for some time. As Argo is a critical part of the solution I maintain, I am stepping up to help oversee its ongoing maintenance. Signed-off-by: Daniel P. Smith --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 81bd0dfeec30..e42afe70fc10 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -242,7 +242,7 @@ F: xen/arch/x86/include/asm/hvm/svm/ ARGO M: Christopher Clark -R: Daniel P. Smith +M: Daniel P. Smith S: Maintained F: xen/include/public/argo.h F: xen/include/xen/argo.h -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 13:37:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 13:37:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353396.1609325 (Exim 4.92) (envelope-from ) id 1wfe5R-0000rY-UQ; Fri, 03 Jul 2026 13:37:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353396.1609325; Fri, 03 Jul 2026 13:37:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfe5R-0000rR-RY; Fri, 03 Jul 2026 13:37:45 +0000 Received: by outflank-mailman (input) for mailman id 1353396; Fri, 03 Jul 2026 13:37:44 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfe5Q-0000rL-Ct for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 13:37:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfe5P-009EC2-Q0 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 15:37:43 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47bb1b-bab6-0a2a0a5309dd-0a2a450beb98-22 for ; Fri, 03 Jul 2026 15:37:43 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47bb27-ac48-0a2a450b0019-b9ff1c239d03-3 for ; Fri, 03 Jul 2026 15:37:43 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f2833024000080a8.005 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 03 Jul 2026 13:37:39 +0000 Received: from [192.168.1.18] (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie) by mail2.vates.fr (Postfix) with ESMTPSA id A451F81C28; Fri, 3 Jul 2026 15:37:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=1n3YZFETxOsJfoHK6l3xelDjADhaX9JklcckDZjk4d8=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=XCnGvjCDchGO7ZKV9Y8phvrpTyCVWKf2GjYoGSz08e9C6TgoJvf/WISWc5s4T94w51t4iBYs5 XwNBOqycCNOmYGYhi2dVt/cOLLjzBnTGes1c6d7px0iC2NdU7uvkpsFNnA808fKav1JeMCGtNoh FElo4+tQwVk98rJO3sfS0UUTCZiS2kOU1QxQ7Wxypo6ZHA4hsNpgGkCpfGfmQfy7XSqcPIx5+7b /vjCkgLwQWBvg8oNUboL03kEhi5CRvkXvnaQaYRSfDenTF01h5ayxC61lw7i8jNLjmGhZOOb9ro dn/MoerKtP0urxKi4f0dCmu/3+ROAfmKMrYu7Tg6e11g== X-Zone-Loop: 37c93c5ea6495444149334cade739c490a5ca6b9c555 x-campaign-type: default x-transaction-id: 4fc35f1d-c934-418c-b421-c1125f076366 x-swg-uid: 01-c0c9f1b1-1563-4409-949d-07487259897a X-Mailer: Sweego Message-ID: <1783085859.8631fc262581453bbf619ec5b2062170.19f2833024000080a8@vates.tech> x-swg-bid: 1783085859.8631fc262581453bbf619ec5b2062170.19f2833024000080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Fri, 3 Jul 2026 15:37:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 for-4.22] x86/cpu-policy: set up host policy earlier To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski , Oleksii Kurochko References: Content-Language: en-US From: Teddy Astie Autocrypt: addr=teddy.astie@vates.tech; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------rNHeVO3n5DbEEksqKdgM8wxX" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1783085858816 X-purgate-ID: tlsNG-42698a/1783085863-A653B220-83AF77CE/0/0 X-purgate-type: clean X-purgate-size: 10702 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------rNHeVO3n5DbEEksqKdgM8wxX Content-Type: multipart/mixed; boundary="------------QK8rbwIujNhxSW0B5RvVCqkL"; protected-headers="v1" From: Teddy Astie To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Marek Marczykowski , Oleksii Kurochko Message-ID: Subject: Re: [PATCH v2 for-4.22] x86/cpu-policy: set up host policy earlier References: In-Reply-To: --------------QK8rbwIujNhxSW0B5RvVCqkL Content-Type: multipart/mixed; boundary="------------nR83I3x2siQvkRtBsKTIqkEr" --------------nR83I3x2siQvkRtBsKTIqkEr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 TGUgMDMvMDcvMjAyNiDDoCAwODoyOCwgSmFuIEJldWxpY2ggYSDDqWNyaXTCoDoNCj4gSW4g b3JkZXIgdG8gdXNlIGNwdV9oYXNfKiBleHBhbmRpbmcgdG8gaG9zdF9jcHVfcG9saWN5Lios IHRoZSBob3N0IHBvbGljeQ0KPiBuZWVkcyBzZXR0aW5nIHVwIGFsb25nc2lkZSBib290X2Nw dV9kYXRhLng4Nl9jYXBhYmlsaXR5W10uIEFycmFuZ2UgZm9yDQo+IHRoYXQgdG93YXJkcyB0 aGUgZW5kIG9mIGlkZW50aWZ5X2NwdSgpLiBUaGVuIG1ha2Ugc3VyZSAueDg2X2NhcGFiaWxp dHlbXQ0KPiBhbmQgaG9zdCBwb2xpY3kgcmVtYWluIGluIHN5bmMgd2hlbiBzZXR1cF97Zm9y Y2UsY2xlYXJ9X2NwdV9jYXAoKSBhcmUNCj4gdXNlZC4NCj4gDQo+IFJlbmFtZSB0aGUgZnVu Y3Rpb24gbm93IGl0J3Mgbm8gbG9uZ2VyIHN0YXRpYy4NCj4gDQo+IEZpeGVzOiA4OTRiZDc2 MTc5MjQgKCJ4ODYvSW50ZWw6IHVzZSBob3N0IENQVSBwb2xpY3kgZm9yIEFSQVQgY2hlY2tp bmciKQ0KPiBSZXBvcnRlZC1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJt YXJla0BpbnZpc2libGV0aGluZ3NsYWIuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1 bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IC0tLQ0KPiBUaGlzIHJlYWxseSB3YXMgcGFy dCBvZiBvbmUgb2YgdGhlIFhTVEFURSBjbGVhbnVwIHBhdGNoZXMgYXQgdGhlIGhlYWQgb2YN Cj4gdGhlIEFNWCBzZXJpZXMuIFRoaXMgZXhwbGFpbnMgdGhlIHNwZWNpZmljIHBsYWNlbWVu dCBhaGVhZCBvZiB0aGUgY2FsbCB0bw0KPiB4c3RhdGVfaW5pdCgpKS4gTGlrZWx5IGFueXRo aW5nIGZyb20gdGhlcmUgZG93bndhcmRzIHNob3VsZG4ndCByZWFsbHkNCj4gbGl2ZSBpbiBp ZGVudGlmeV9jcHUoKSBhbnl3YXkuDQo+IC0tLQ0KPiB2MjogQ2FsbCBjYWxjdWxhdGVfaG9z dF9jcHVfcG9saWN5KCkgZnJvbSBzZXR1cF97Zm9yY2UsY2xlYXJ9X2NwdV9jYXAoKQ0KPiAg ICAgIGluc3RlYWQgb2YgZnJvbSBpbml0X2d1ZXN0X2NwdV9wb2xpY2llcygpLg0KPiANCj4g LS0tIGEveGVuL2FyY2gveDg2L2NwdS9jb21tb24uYw0KPiArKysgYi94ZW4vYXJjaC94ODYv Y3B1L2NvbW1vbi5jDQo+IEBAIC02Niw4ICs2NiwxMCBAQCB2b2lkIF9faW5pdCBzZXR1cF9j bGVhcl9jcHVfY2FwKHVuc2lnbmVkDQo+ICAgCV9fY2xlYXJfYml0KGNhcCwgYm9vdF9jcHVf ZGF0YS54ODZfY2FwYWJpbGl0eSk7DQo+ICAgCWRmcyA9IHg4Nl9jcHVfcG9saWN5X2xvb2t1 cF9kZWVwX2RlcHMoY2FwKTsNCj4gICANCj4gLQlpZiAoIWRmcykNCj4gKwlpZiAoIWRmcykg ew0KPiArCQljYWxjdWxhdGVfaG9zdF9jcHVfcG9saWN5KCk7DQo+ICAgCQlyZXR1cm47DQo+ ICsJfQ0KPiAgIA0KPiAgIAlmb3IgKGkgPSAwOyBpIDwgRlNDQVBJTlRTOyArK2kpIHsNCj4g ICAJCWNsZWFyZWRfY2Fwc1tpXSB8PSBkZnNbaV07DQo+IEBAIC03OCw2ICs4MCw4IEBAIHZv aWQgX19pbml0IHNldHVwX2NsZWFyX2NwdV9jYXAodW5zaWduZWQNCj4gICAJCSAgICAgICBf X2J1aWx0aW5fcmV0dXJuX2FkZHJlc3MoMCksDQo+ICAgCQkgICAgICAgaSwgZm9yY2VkX2Nh cHNbaV0gJiBkZnNbaV0pOw0KPiAgIAl9DQo+ICsNCj4gKwljYWxjdWxhdGVfaG9zdF9jcHVf cG9saWN5KCk7DQo+ICAgfQ0KPiAgIA0KPiAgIHZvaWQgX19pbml0IHNldHVwX2ZvcmNlX2Nw dV9jYXAodW5zaWduZWQgaW50IGNhcCkNCj4gQEAgLTkyLDYgKzk2LDggQEAgdm9pZCBfX2lu aXQgc2V0dXBfZm9yY2VfY3B1X2NhcCh1bnNpZ25lZA0KPiAgIAl9DQo+ICAgDQo+ICAgCV9f c2V0X2JpdChjYXAsIGJvb3RfY3B1X2RhdGEueDg2X2NhcGFiaWxpdHkpOw0KPiArDQo+ICsJ Y2FsY3VsYXRlX2hvc3RfY3B1X3BvbGljeSgpOw0KPiAgIH0NCj4gICANCj4gICBib29sIF9f aW5pdCBpc19mb3JjZWRfY3B1X2NhcCh1bnNpZ25lZCBpbnQgY2FwKQ0KPiBAQCAtNTg2LDYg KzU5MCw4IEBAIHZvaWQgaWRlbnRpZnlfY3B1KHN0cnVjdCBjcHVpbmZvX3g4NiAqYykNCj4g ICAJfQ0KPiAgIA0KPiAgIAkvKiBOb3cgdGhlIGZlYXR1cmUgZmxhZ3MgYmV0dGVyIHJlZmxl Y3QgYWN0dWFsIENQVSBmZWF0dXJlcyEgKi8NCj4gKwlpZiAoYyA9PSAmYm9vdF9jcHVfZGF0 YSkNCj4gKwkJY2FsY3VsYXRlX2hvc3RfY3B1X3BvbGljeSgpOw0KPiAgIA0KPiAgIAl4c3Rh dGVfaW5pdChjKTsNCj4gICANCj4gLS0tIGEveGVuL2FyY2gveDg2L2NwdS1wb2xpY3kuYw0K PiArKysgYi94ZW4vYXJjaC94ODYvY3B1LXBvbGljeS5jDQo+IEBAIC0zNTksMTEgKzM1OSwx OCBAQCB2b2lkIGNhbGN1bGF0ZV9yYXdfY3B1X3BvbGljeSh2b2lkKQ0KPiAgICAgICAvKiBX YXMgYWxyZWFkeSBhZGRlZCBieSBwcm9iZV9jcHVpZF9mYXVsdGluZygpICovDQo+ICAgfQ0K PiAgIA0KPiAtc3RhdGljIHZvaWQgX19pbml0IGNhbGN1bGF0ZV9ob3N0X3BvbGljeSh2b2lk KQ0KPiArdm9pZCBfX2luaXQgY2FsY3VsYXRlX2hvc3RfY3B1X3BvbGljeSh2b2lkKQ0KPiAg IHsNCj4gICAgICAgc3RydWN0IGNwdV9wb2xpY3kgKnAgPSAmaG9zdF9jcHVfcG9saWN5Ow0K PiAgICAgICB1bnNpZ25lZCBpbnQgbWF4X2V4dGRfbGVhZjsNCj4gICANCj4gKyAgICAvKg0K PiArICAgICAqIEJhaWwgaWYgdGhlIHJhdyBwb2xpY3kgd2Fzbid0IHNldCB1cCB5ZXQuIEF0 IGxlYXN0IHJlY2FsY3VsYXRlX3hzdGF0ZSgpDQo+ICsgICAgICogY2FuJ3QgYmUgdXNlZCB5 ZXQgaW4gdGhhdCBjYXNlLg0KPiArICAgICAqLw0KPiArICAgIGlmICggIXJhd19jcHVfcG9s aWN5LmJhc2ljLm1heF9sZWFmICkNCj4gKyAgICAgICAgcmV0dXJuOw0KPiArDQo+ICAgICAg ICpwID0gcmF3X2NwdV9wb2xpY3k7DQo+ICAgDQo+ICAgICAgIHAtPmJhc2ljLm1heF9sZWFm ID0NCj4gQEAgLTkwNCw4ICs5MTEsNiBAQCBzdGF0aWMgdm9pZCBfX2luaXQgY2FsY3VsYXRl X2h2bV9kZWZfcG9sDQo+ICAgDQo+ICAgdm9pZCBfX2luaXQgaW5pdF9ndWVzdF9jcHVfcG9s aWNpZXModm9pZCkNCj4gICB7DQo+IC0gICAgY2FsY3VsYXRlX2hvc3RfcG9saWN5KCk7DQo+ IC0NCj4gICAgICAgaWYgKCBJU19FTkFCTEVEKENPTkZJR19QVikgKQ0KPiAgICAgICB7DQo+ ICAgICAgICAgICBjYWxjdWxhdGVfcHZfbWF4X3BvbGljeSgpOw0KPiAtLS0gYS94ZW4vYXJj aC94ODYvaW5jbHVkZS9hc20vY3B1LXBvbGljeS5oDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9p bmNsdWRlL2FzbS9jcHUtcG9saWN5LmgNCj4gQEAgLTMwLDQgKzMwLDEwIEBAIHZvaWQgcmVj YWxjdWxhdGVfY3B1aWRfcG9saWN5KHN0cnVjdCBkb20NCj4gICAgKi8NCj4gICB2b2lkIGNh bGN1bGF0ZV9yYXdfY3B1X3BvbGljeSh2b2lkKTsNCj4gICANCj4gKy8qDQo+ICsgKiBDb2xs ZWN0IHRoZSBob3N0IENQVSBwb2xpY3kuICBDYWxsZWQgYWZ0ZXIgY29sbGVjdGluZyBlbm91 Z2ggQ1BVSUQgb3V0cHV0LA0KPiArICogYW5kIGFnYWluIGFmdGVyIGFsbCBmZWF0dXJlIG92 ZXJyaWRlcyBoYXZlIGJlZW4gcHV0IGluIHBsYWNlLg0KPiArICovDQo+ICt2b2lkIGNhbGN1 bGF0ZV9ob3N0X2NwdV9wb2xpY3kodm9pZCk7DQo+ICsNCj4gICAjZW5kaWYgLyogWDg2X0NQ VV9QT0xJQ1lfSCAqLw0KPiANCg0KVGhhdCBsb29rcyBxdWl0ZSBjb25mdXNpbmcuDQoNCkFz IEkgdW5kZXJzdGFuZCBpdCwgKGlkZWFsbHkpIGhvc3QgQ1BVIHBvbGljeSAod2hpY2ggSSBz dXBwb3NlLCBjb250YWlucyANCiJub24gc3ludGhldGljIiBjcHUgZmVhdHVyZXNldCkgaXMg YWJvdXQgdGhlIENQVUlEIGluZm8gdGhhdCBYZW4gaXMgDQphbGxvd2VkIHRvIHNlZSBhbmQg cmVseSBvbiwgd2hpbGUgInN5bnRoZXRpYyBDUFUgY2FwYWJpbGl0aWVzIiBpcyBtb3JlIA0K YWJvdXQgWGVuIGRlY2lzaW9ucy4NCg0KSWYgImNwdSBmZWF0dXJlc2V0IGluZm8iIGFuZCAi aG9zdCBjcHUgcG9saWN5IiBjYW4gZ2V0IG91dCBvZiBzeW5jLCB0aGVuIA0KcmVjYWxjdWxh dGluZyBob3N0IGNwdSBwb2xpY3kgZWFjaCB0aW1lIHdlIG1ha2UgYSBtb2RpZmljYXRpb24g b2YgdGhlIA0KY3B1IGZlYXR1cmVzZXQgc291bmRzIGxpa2UgYSBiYWQgaWRlYSwgYW5kIHdl IHByb2JhYmx5IHNob3VsZCB0cnkgdG8gbm90IA0KZW5kIHVwIGluIHRoaXMgc2l0dWF0aW9u IGluIHRoZSBmaXJzdCBwbGFjZSBieSBub3QgaGF2aW5nIGhvc3QgQ1BVIA0KcG9saWN5IGFu ZCBmZWF0dXJlc2V0IGNvbXBldGluZyBvbiB3aGF0IGhhcmR3YXJlIGZlYXR1cmUgWGVuIHNo b3VsZCByZWx5IG9uLg0KDQpUZWRkeQ0K --------------nR83I3x2siQvkRtBsKTIqkEr Content-Type: application/pgp-keys; name="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Disposition: attachment; filename="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7L TBVHV/XOZw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJ T4ny+OGntnJntUoRKRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJA WicutjkkUgd28Bh6HV9EIumHtCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO 8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaTVqMdqul07o72m3eA2mf+LMu9a04FX/d4 wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/EoucejoZ5SH49ksmVAmKOLkt OaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+SPhHar7TPKjFz0G3D PNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89MXfQXZ3q t1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWj moACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNz uyOVCskwfUZPla6Zpd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp 0x0HfuhcYfAYPR46XHTvjaJEv99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuR OxdK8G+YHccJY8PvWSq2K2yiae2KGiAv1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50 wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhPeP3IdpfWc8cyRLXF06Rk46YM YCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcTUwgnYlFRk2FLq0Qe KEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9Egr/Wmu3 MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEM AKiQiZa3yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ 3DbVf+en3/FvdVZg2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTm etSG5/52AjtmPFtlXAk0NmLvfJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0 s3109sJeXT5ImVdphFs9cvyZyBT9t1PbRowv58EgV0zE4hbAeVkULAbxFV5b/ExT jjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKbYu6NCfiHfEyB3Xyg9hfdrRgj MRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ovXoK4jm+Py0FiUGUa A6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/eVtR2Q1w ZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWj moACGwwACgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiV oUiHYN5QwhnbZnsaJDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764Qxy X6rld2f2RcWkDuBHun55ZWXjby8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk /dS0XTOQi2wVUb17sW/+ybCEokdVacZGzOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fu oGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+lOWSvdNHgoEkWR0RXBPQjnGm LKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/OffO485NOTKwGOxyWb0 06cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR8ULR9nX0 LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa =3DlUIA -----END PGP PUBLIC KEY BLOCK----- --------------nR83I3x2siQvkRtBsKTIqkEr-- --------------QK8rbwIujNhxSW0B5RvVCqkL-- --------------rNHeVO3n5DbEEksqKdgM8wxX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmpHuyIFAwAAAAAACgkQZg+p0QLLz9DH 9gwAj1DBC3g+ypP7sgNc/tzpiJqcdu9T8nWj/PYNPDAJ2O4SYXFAyFhN79ZlM72uF23+/cYeypcn b7o+kqtPrE+fY1n88+VifLVuLbCn56AsXdJSMLpVHWZyCaUu9qern2VFXjX6gCzH721PaV6qYWSq Ggn2t5gktXVnM6PbiDwLcCHQbh1N7iHSlmPdH84wSMgTdKhwAYItxEgf8TO3LNfL9FswqCRVhYco dogmuX75vB6ihc8Cq6u6By8cEf0Hr9uG8XJDzLG891N4pyCZUoOjjqDk/bvPbCVa5fa1qEY5uJvv Mtj3uvRNNIEtDCP3h42ph3zrMjkCrlKM334Z73TNEiCiiglp8ix58514axvXNn7D3U1OPOjuCmab dfRtarZHieGoUx94mn0VPqKQcJt3XZkkKd6fV03CTnVrvlMr/4NXfQUrsdQQ8UOrJKXB4dqGD/3C LKLalgXPR6rcI/7oWj2Uba2KVr3uA3+W2IShrHNDVtMIYRNVmaGs25eCNAgt =m4c3 -----END PGP SIGNATURE----- --------------rNHeVO3n5DbEEksqKdgM8wxX-- From xen-devel-bounces@lists.xenproject.org Fri Jul 03 15:19:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 15:19:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353458.1609335 (Exim 4.92) (envelope-from ) id 1wfffy-0008V8-UH; Fri, 03 Jul 2026 15:19:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353458.1609335; Fri, 03 Jul 2026 15:19:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfffy-0008V1-Rb; Fri, 03 Jul 2026 15:19:34 +0000 Received: by outflank-mailman (input) for mailman id 1353458; Fri, 03 Jul 2026 15:19:33 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfffx-0008Uv-Ap for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 15:19:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfffw-00017f-3A for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 17:19:32 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47d2d9-2eae-0a2a0a5409dd-0a2a450aa4fe-34 for ; Fri, 03 Jul 2026 17:19:31 +0200 Received: from [40.93.198.47] (helo=CY7PR03CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47d301-e40e-0a2a450a0019-285dc62f2c99-3 for ; Fri, 03 Jul 2026 17:19:31 +0200 Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by PH7PR12MB5856.namprd12.prod.outlook.com (2603:10b6:510:1d7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Fri, 3 Jul 2026 15:19:24 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 15:19:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=temperror header.s=selector2 header.d=Nvidia.com header.i="@Nvidia.com" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rd5m6Emj+TW16fmXTB1pci+NBqwXYENjsKVlpGD9ECAMCq4EcFrxnPhVkkMIW4RcBBI34HG37RaG8Led8uF8M2iHrVrQhWK0ccbQVS97v/TAk8XweX7IU+Im+ztTSRWr01bT95TmQVED8847wafdlWo0alwby0VEPrXLaJBYqd1qna8fahsLtay9GBEHQkZelBLdDUBRqRCdp6q5++t3mjkLOshLuIMEObh3eWu3aCjsib4zYzDtSuX1s2ZI4MKmvbl6Sg6FprEiJjqnSItTfENlHySq7y4E2btiZUFnzKRv9ZmvnwdIJ2hTV8ICwEmJ/p5UdY1af2cxKeOf1lphMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PJsWbDxlK1lfEc9swedmNLuoU5uhFAQRmSm+tgJfwMs=; b=MlVpoqHTH5ZYuGcvTo6vQxZA6Q+ZxE+n0kqcyo0CHUW8OzzzU3R+YG0Xk7iVG7BIY8GscI80LAzKFruvS7JRoWgLCMnnVSCfzPfhQeTaPtlEJn60ndflIMTsW/V/EmUZR2HLExQ/ew5kD1VFvDtf1hFVrbyh8+L9uh7jaFUOPGMYCPEeMZpBIjXcGjWwGAZjmbSjKHVD7RmG1sfNtW7KvaUQu8+8sdTbGYrtz++fAbn+xA3YfIFkluhIzjw8GmvIRLGcxKcCcA5sivFJ0tqfe5BEkgEUbXe84jqVgO73hHpXrCdlAvDAcNowP1n+1b/iWw7bPkEpQ2edrmJoRjCrew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PJsWbDxlK1lfEc9swedmNLuoU5uhFAQRmSm+tgJfwMs=; b=mnMlyBtKDLgxm2OMOM0mkmruD50fISkEz0+Rm+W8d9qTDm8k5EzC4Q3/8cx1JgWQOS8tPYLdVYIkTY19mOOH12wdO6H9G0SrjIYZE/9oDIZtJiWO1BfN5drpSK7RapWDqpnIAwIgo53cOphJ4MhLrRJv9Y5xq2GkaeWUIDPMrAf7Uv6B439nR/YQdSgOzevGmaTP/v/4/DxTYP9XtMsDyRyqHf+IEvLadGOW7bA/7ZiAPMhnMqJshOpYXFQBXVXCOxGhiHJ9UzunYdxaS+1ZvY7HagMXeCCs77ohgUMUuxtU0WMyOp9GuYgmcxgs0NxNoqKsXfRV4OaEnw5ikaO1Og== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 03 Jul 2026 11:19:17 -0400 Message-Id: From: "Zi Yan" Subject: Re: [PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() Cc: "Thomas Bogendoerfer" , "Madhavan Srinivasan" , "Michael Ellerman" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Lucas Stach" , "Inki Dae" , "Seung-Woo Kim" , "Kyungmin Park" , "Krzysztof Kozlowski" , "Peter Griffin" , "Jani Nikula" , "Joonas Lahtinen" , "Rodrigo Vivi" , "Tvrtko Ursulin" , "Rob Clark" , "Dmitry Baryshkov" , "Lyude Paul" , "Danilo Krummrich" , "Tomi Valkeinen" , "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "Thierry Reding" , "Mikko Perttunen" , "Jonathan Hunter" , "Gerd Hoffmann" , "Dmitry Osipenko" , "Zack Rusin" , "Matthew Brost" , "Thomas Hellstrom" , "Oleksandr Andrushchenko" , "Helge Deller" , "Benjamin LaHaise" , "Alexander Viro" , "Christian Brauner" , "Muchun Song" , "Oscar Salvador" , "David Hildenbrand" , "Baolin Wang" , "Liam R . Howlett" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Barry Song" , "Lance Yang" , "Hugh Dickins" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Jann Horn" , "Pedro Falcato" , "Kees Cook" , "Jaroslav Kysela" , "Takashi Iwai" , , , , , , , , , , , , , , , , , , , , , To: "Lorenzo Stoakes" , "Andrew Morton" X-Mailer: aerc 0.21.0 References: In-Reply-To: X-ClientProxiedBy: DM6PR05CA0061.namprd05.prod.outlook.com (2603:10b6:5:335::30) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|PH7PR12MB5856:EE_ X-MS-Office365-Filtering-Correlation-Id: 51d166c3-9eb7-44b5-2305-08ded9167693 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|23010399003|18002099003|22082099003|6133799003|4143699003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: waK9HC66LHyvBqm/X6oa+SmhtU6o8X1iOE5NifCkoFkl5td3cp7RXlP+HRoyh/cPFfi70qQO5DQzjzA6/Tubl7xExcVdSWQd+1uWXGR2/gZnGhw4MqYnjDvjFzQBfBBDyvbTxCAthTYUGWdeifgcBwOPeuRIdFPiiFRrUf8cI8NyQLgNhYG1d9toWhc/iTV/sMRgjuC0gqZf7KKvfczTA/r5DoDHE8+8uw0r0waNlUYq+kVtsogTd4HMeap1Q/ZGs42D2YrV+r+5WQkQWUapt0DojyhDAdAmhm5LrxJpJK5EtINZouQbNgQHddP19XtOobJmcUt8jShLMIJocHpoBUnvaALynq3QYcf3VBJXViaATppkrRwmpHWnhW9MoQaFLp9BTE3SbavKLcA5+Anm6t+qECfj0oVTwXb2i5QOQvWEe074SxPlzNCClQ6OAFZGUJuEWuCn9futMXAribhavfRqlwDtPIMaz2obrS2xVTK5R2ZKOxYDiTNfSZL85RJTGnykaasKwCuBFvLX3U+DscbIUXiSF/qxXs4R/q6jP3tNiYzOl6jM/E8w+7V/mCisjndwxIaC2DrRoSjttxMZ6IXYMQZBdUWQ0gMF335ajCA/GS4nm1PUrfUwMqdVRVfSiqilkJEQMTsQvGZqvzNXMXkjxvHcG3sxuHOFhqZeEzI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(23010399003)(18002099003)(22082099003)(6133799003)(4143699003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGpZaHFMRFpUd2wzWXozWHFHZE9SK1B5ZHB0c01aVldkSTV4eWRWRWU5OWFS?= =?utf-8?B?Ri9rM0MzSjdwMlZyTHFkalNyb2wvQ0ZsSTJUSnlyOThOQll3MEFTcDRHTzQz?= =?utf-8?B?NEJIUzVUSkk1Sm96UXlNM0ZZNllxNC9EV2dTV3dwN3JhdWdDYWVZSGFYUWt6?= =?utf-8?B?ZjVYb29udGpJTFQ1U2tmMzVBa3FwamoyU3c2Q3JyOW1RZW1RNUNaYjQ2U1Iv?= =?utf-8?B?WjRNMHUxckZxcnArY2xtMWd0MXVlMWg1RjZzMGZTdjl1QjhqaEVNeXF1bDBJ?= =?utf-8?B?aXd4eW83U2IxdzhCV1VWUU5YdXcwQWFINTM2ck84TTlQdkpsMXRDZEZBdEMv?= =?utf-8?B?eVh1REs1THArbElVQi9RVzZuQW1wMjZoRjZJN0M4U0NpVW9sS0NQY0tXVjc4?= =?utf-8?B?aXhQM2kwUGE5ZzVGUVlOdVp0ckM5MksrWEluNUhYeENtdzVaNmt6MGh0QjF6?= =?utf-8?B?WWlVaTVRd0JUR0x1UUtMYklDeEhQRXJDbHNHaDN2Ly9PcHJtRGljelJvcUtV?= =?utf-8?B?aGM4RU9YY2orSUMxLzBBMHkvNmVlRkwrVlZMNzRMR09kZ3BlenRyT1ZZN1c1?= =?utf-8?B?SHNTY05SUWFoTDdLTy9ycGF1b1BWaWJSSjYzNTF5RFBvZVFwMEZqd3hEV255?= =?utf-8?B?bVRhd3dlRWx3ZUczQzN1Uzk3NVM1ZUhMeEszcWZ5eXd6Z0RONU9qaWRwTjc0?= =?utf-8?B?RzdrcEduZTZPS0I5UWc2U1ZlajNQVlc0cXJNV1pNTHI5bDZtQzBnRnhYSFRh?= =?utf-8?B?SG9vMTNuRittdGxrZWNmaFZTZzNiamlpU2Riay8xRVlsL0lnUTVKQkgrOUdG?= =?utf-8?B?SC9SQkRvdkd0L0x1VFR1TnBYSDFoYXNKVG1GcFVOQ1JLNnA3VDI4b2FRVU41?= =?utf-8?B?UlVTVHB3YkRWVFhzeFZtc2YrQzZSVDlwRVYwSTFodlhNbm95MkQ5bjBhTCs4?= =?utf-8?B?UGZKUjZKODhnTVI4SU1wRjgvZjZwM0t6Rjg2ZnBYcUQ2VSs3d3VUOUlyYklu?= =?utf-8?B?Z3NkMUJUQzJpMFY2WmxWRkh1eEhhbDZFOERtdEh5NE5WUTYrbWxUQVQwNmky?= =?utf-8?B?NlpTTUwwVWxtVHlJOTl3cjFtSDh0RjMwUlVIcThYU3FJZ0dlOHdTU3hraTl1?= =?utf-8?B?TzdlMHlIaUVPT0d0L1c0SzhEWWlpUGdsbWV1UDFmWDNtYzZzYmZWVVhRV3VT?= =?utf-8?B?a3M4Nkpscm5tZnhYVjhMVUtNRk9yQXg1K1QzOUFObURza091SlYveU0rM2VD?= =?utf-8?B?cDNIYnhWZkZQNG8vWHVEQnFWcFRVTENRNkF2eUVBYzBjT2FLZm5HK1NjQTRK?= =?utf-8?B?eW9HNkRwRXBZWllRRGgwODZqTmNXSWpBVVpPaUF4cm1LL05BTVlLcFJWclZQ?= =?utf-8?B?eXZRM1dyMjRVbWM4aytMTDkxc2djWVVacFFMQWFzL0JrczlzR2J2ZXhBUjlm?= =?utf-8?B?ODU3WFhwZmRWOFlKUDUwcnMrR3MrQWJhOGY4K0lmKy9qOU1rVUhlRUhtVnlk?= =?utf-8?B?TWdvanpBN1ZJaEpZY3BCbmt2aDBWd0Q5QzVONm94Z0doVHVnVFRHRlhYR1I2?= =?utf-8?B?SjRNVDgyZm9MYzNiRHhNMnEyL2NONDJtUkN0dVV0aGF0cUNsVmovM1Z4dUgv?= =?utf-8?B?dHlyb0J4eVlJVXpkME16N0Jqci82UGdKQmkwNEFaVUc2aUJEZ2Q2NTd2QVo3?= =?utf-8?B?b2x0SHBSeGkwVXNmQWsvYlZ0aVIyZlJVNW96R0xkZWpHd2EwZkRFVEg0SGdH?= =?utf-8?B?VVM2MzArMWF2K3hsbmgySllIaFJmZlQzUVd4SmRhWGZ3Wmw5WTlKRXBCb0JQ?= =?utf-8?B?cTVzT1l4UlpWNU42cHpnc2lnSk05QmZsekR6aDJKNDR3SWs0b0tLTjR0dVJR?= =?utf-8?B?UlVJdmhIQTRlcFZ2M1VsVHcvWFVyZWFNMzlsSUFSdGVUV0xXREdaYjI5YXky?= =?utf-8?B?VU5zV2tHL0VHdEYyREpSd3FFaUtzaUhDYnMzWFpnOGd1ckJqaS96dnBxbE5W?= =?utf-8?B?ZGNSaDdEY2dsQnk2RVBYUzMyOU94UzY0QWRQd21hUHFDV25qUG9ObW0wUWQx?= =?utf-8?B?RlM4Y2l3ZW1QQWhCcjhmaVdqMU5QRno3QktZbndYNUhWbENBZCtXbm54OXFo?= =?utf-8?B?b2F6dk9XOTY0OG84ODZPWnB0L2RzbVpxdm9IM1JYZ2ZPYkRlZUx6NlZmb1lk?= =?utf-8?B?MC91eVNkVm4rekk1UVlyQ1J1anQxRmxuZ2IxSlNVdHh4VlJjSmFyM1hxMnZt?= =?utf-8?B?QlBTK1FpRk96U3JZUGcvSEZaR1pDMWs3QnRPVWlnZzV0U1lINjZzSE9pOENE?= =?utf-8?Q?FLvWesTPpyJ9tzjTvw?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51d166c3-9eb7-44b5-2305-08ded9167693 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 15:19:23.7516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ve4DjdZRKH5W6DDGg77kv2BkqOMwB0CUDzxD06BnHw7k9x0Ex3i12jMTXkRZN8oc X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5856 X-purgate-ID: tlsNG-4011c0/1783091971-D693DDDE-9804D025/0/0 X-purgate-type: clean X-purgate-size: 849 On Mon Jun 29, 2026 at 3:25 PM EDT, Lorenzo Stoakes wrote: > These test whether the VMA has stack sematics, i.e. is able to grow upwar= ds > or downwards depending on the architecture. > > In order to account for arches which do not support upward-growing stacks= , > introduce VMA_GROWSUP whose definition depends on the architecture > supporting it, and use vma_flags_test_single_mask() in vma_flags_can_grow= () > to account for this. > > Update the VMA userland tests to reflect the changes > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes > --- > include/linux/mm.h | 21 ++++++++++++++++++--- > tools/testing/vma/include/dup.h | 4 ++++ > 2 files changed, 22 insertions(+), 3 deletions(-) > Reviewed-by: Zi Yan --=20 Best Regards, Yan, Zi From xen-devel-bounces@lists.xenproject.org Fri Jul 03 15:55:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 15:55:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353500.1609360 (Exim 4.92) (envelope-from ) id 1wfgEi-0007Ar-LD; Fri, 03 Jul 2026 15:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353500.1609360; Fri, 03 Jul 2026 15:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfgEi-0007Ak-I8; Fri, 03 Jul 2026 15:55:28 +0000 Received: by outflank-mailman (input) for mailman id 1353500; Fri, 03 Jul 2026 15:55:28 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfgEh-0007Ae-VX for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 15:55:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfgEh-009Xco-CF for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 17:55:27 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47db58-bab6-0a2a0a5309dd-0a2a4509d680-32 for ; Fri, 03 Jul 2026 17:55:27 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47db6d-97e6-0a2a45090019-aceafc1f9416-3 for ; Fri, 03 Jul 2026 17:55:27 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E391743F1E; Fri, 3 Jul 2026 15:55:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C801E1F00A3A; Fri, 3 Jul 2026 15:55:24 +0000 (UTC) Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 56A8A3939347; Fri, 3 Jul 2026 15:55:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Subject:From:In-Reply-To:References:Date:To:Cc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783094124; bh=tIT8m71ileIYoE59zB8wpmg7EclFYCxOBjVOAJkW9Gc=; h=Subject:From:In-Reply-To:References:Date:To:Cc; b=k4ayWB6PeBEyCS21jjUK+yFOOVoSk3gcVL0UCFKfXsvISsuybeRKqvcC1xOw99Tnk YMYzaXcLwk2JXvV6XwrnR3QQpCI3UwSV/b8FGTLVFLiWsqueYAPaXAm9HT5r/35vej gkn8kGOYBbJ5AW4eScaLdZqbPcDw7c2YPIW/DqGo6JHDAn0ClybmDPdVpVPkUzfoCl GAwLL8Fcpu1XFHaW2n7R7FrQj2Naw0l8Is7hDwXfU0jNwts9Bri1YjbnJT7rNp+ZVt qF+xjMA4QxIN/pDpIdljhuOf7aqAL0Pto7/6aHGksJcDaQyV3tGH/9DXTXFTfj7FFz Ib/XdryehMZWQ== Subject: Re: [GIT PULL] xen: branch for v7.2-rc2 From: pr-tracker-bot@kernel.org In-Reply-To: <20260703094331.1752102-1-jgross@suse.com> References: <20260703094331.1752102-1-jgross@suse.com> X-PR-Tracked-List-Id: Xen developer discussion X-PR-Tracked-Message-Id: <20260703094331.1752102-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-7.2a-rc2-tag X-PR-Tracked-Commit-Id: fcd245ea7528d50fddffc0fd1308941a9180f5b3 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 4dbc94bcc2df0c3bba40318c0751a8f487486783 Message-Id: <178309410689.2776291.14945976796385511167.pr-tracker-bot@kernel.org> Date: Fri, 03 Jul 2026 15:55:06 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org X-purgate-ID: tlsNG-bad1c0/1783094127-47D34986-8A89B703/0/0 X-purgate-type: clean X-purgate-size: 363 The pull request you sent on Fri, 3 Jul 2026 11:43:31 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-7.2a-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4dbc94bcc2df0c3bba40318c0751a8f487486783 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Fri Jul 03 16:30:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 16:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353525.1609369 (Exim 4.92) (envelope-from ) id 1wfgmL-00060G-6L; Fri, 03 Jul 2026 16:30:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353525.1609369; Fri, 03 Jul 2026 16:30:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfgmL-000608-34; Fri, 03 Jul 2026 16:30:13 +0000 Received: by outflank-mailman (input) for mailman id 1353525; Fri, 03 Jul 2026 16:30:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfgmJ-000602-M3 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 16:30:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfgmI-00Ahc5-LF for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 18:30:10 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a47e388-2eae-0a2a0a5409dd-0a2a4501817a-22 for ; Fri, 03 Jul 2026 18:30:10 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a47e392-400f-0a2a45010019-b9ff1c22976d-3 for ; Fri, 03 Jul 2026 18:30:10 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19f28d0d9fc00080a8.006 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 03 Jul 2026 16:30:03 +0000 Received: from localhost.localdomain (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie@vates.tech) by mail2.vates.fr (Postfix) with ESMTPSA id D6F3680A50; Fri, 3 Jul 2026 18:30:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=RQjEcU4YXGqI5p2avl7VVKfWwfVX8xlmY4b9mgjYYxQ=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=KBFtbqOX3yP+ftlSrP90Ur7znTycsqg4wcYWQDUyx3D1j8iUaI2So3d5hq6Wpd2UBiRBwtYuS 8sKvVDpKQRNQkd4PuNlBVX77aN+F2MdKJn5+Upmau3Z2AQ4EKWW+yhndyzTsWWwVn7bhelLAOay 0TmV6sOT/HUET3rBK/FbXD3XN7r68PVK0FphoAepag/yrOt8hpxDIY2wddnnioXBEyfNluY2B4R d6o114Zh6bGm62yctZZ+gK1B3jt28um2+j7qdznUQDcpHD4EDVxNM95iI0Yd6C4x3JG+PAeZym7 GiR1/nQ5C0KwAZ/5o+pXWRQE+T+nyS9fzY0npVkG+6Mw== X-Zone-Loop: df28dea631562b212faec0e426749e529d3a5150216c x-campaign-type: default x-transaction-id: 7633c826-ec20-4c9e-a44b-1d67d7966408 x-swg-uid: 01-5c2e9b72-ea6d-43d9-8898-0e6cde5ab358 X-Mailer: Sweego Message-ID: <1783096203.8631fc262581453bbf619ec5b2062170.19f28d0d9fc00080a8@vates.tech> x-swg-bid: 1783096203.8631fc262581453bbf619ec5b2062170.19f28d0d9fc00080a8 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Teddy Astie To: xen-devel@lists.xenproject.org Cc: Teddy Astie , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini , "Daniel P. Smith" Subject: [PATCH v3.1 02/18] pci: Use pci_sbdf_t in pci_add_device() Date: Fri, 3 Jul 2026 18:29:06 +0200 In-Reply-To: <1782753810.8631fc262581453bbf619ec5b2062170.19f1468572a000701b@vates.tech> References: <1782753810.8631fc262581453bbf619ec5b2062170.19f1468572a000701b@vates.tech> MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.ef.f30dce182e3a6b24.19f28d0d76b.198041397edd7b15=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1783096203116 X-purgate-ID: tlsNG-d62444/1783096210-80CD61E0-BAD80866/0/0 X-purgate-type: clean X-purgate-size: 8407 ---=Part.ef.f30dce182e3a6b24.19f28d0d76b.198041397edd7b15=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Signed-off-by: Teddy Astie --- v3: Don't adjust adjacent code=2E v3=2E1: Remove slot variable and move func down to its user=2E --- xen/arch/x86/physdev=2Ec | 6 +++--- xen/drivers/passthrough/pci=2Ec | 37 +++++++++++++++++------------------ xen/drivers/pci/physdev=2Ec | 3 ++- xen/include/xen/pci=2Eh | 4 ++-- 4 files changed, 25 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/physdev=2Ec b/xen/arch/x86/physdev=2Ec index 5bbcf3b530=2E=2E60c02076d6 100644 --- a/xen/arch/x86/physdev=2Ec +++ b/xen/arch/x86/physdev=2Ec @@ -472,7 +472,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(vo= id) arg) if ( copy_from_guest(&manage_pci, arg, 1) !=3D 0 ) break; =20 - ret =3D pci_add_device(0, manage_pci=2Ebus, manage_pci=2Edevfn, + ret =3D pci_add_device(PCI_SBDF(0, manage_pci=2Ebus, manage_pci= =2Edevfn), NULL, NUMA_NO_NODE); break; } @@ -503,8 +503,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(vo= id) arg) pdev_info=2Eis_virtfn =3D manage_pci_ext=2Eis_virtfn; pdev_info=2Ephysfn=2Ebus =3D manage_pci_ext=2Ephysfn=2Ebus; pdev_info=2Ephysfn=2Edevfn =3D manage_pci_ext=2Ephysfn=2Edevfn; - ret =3D pci_add_device(0, manage_pci_ext=2Ebus, - manage_pci_ext=2Edevfn, + ret =3D pci_add_device(PCI_SBDF(0, manage_pci_ext=2Ebus, + manage_pci_ext=2Edevfn), &pdev_info, NUMA_NO_NODE); break; } diff --git a/xen/drivers/passthrough/pci=2Ec b/xen/drivers/passthrough/pci= =2Ec index 0adf573150=2E=2Ed7e60e6fbb 100644 --- a/xen/drivers/passthrough/pci=2Ec +++ b/xen/drivers/passthrough/pci=2Ec @@ -662,12 +662,10 @@ unsigned int pci_size_mem_bar(pci_sbdf_t sbdf, unsig= ned int pos, return is64bits ? 2 : 1; } =20 -int pci_add_device(u16 seg, u8 bus, u8 devfn, - const struct pci_dev_info *info, nodeid_t node) +int pci_add_device(pci_sbdf_t sbdf, const struct pci_dev_info *info, node= id_t node) { struct pci_seg *pseg; struct pci_dev *pdev; - unsigned int slot =3D PCI_SLOT(devfn), func =3D PCI_FUNC(devfn); const char *type; int ret; =20 @@ -680,17 +678,17 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, else type =3D "device"; =20 - ret =3D xsm_resource_plug_pci(XSM_PRIV, (seg << 16) | (bus << 8) | de= vfn); + ret =3D xsm_resource_plug_pci(XSM_PRIV, sbdf=2Esbdf); if ( ret ) return ret; =20 ret =3D -ENOMEM; =20 pcidevs_lock(); - pseg =3D alloc_pseg(seg); + pseg =3D alloc_pseg(sbdf=2Eseg); if ( !pseg ) goto out; - pdev =3D alloc_pdev(pseg, bus, devfn); + pdev =3D alloc_pdev(pseg, sbdf=2Ebus, sbdf=2Edevfn); if ( !pdev ) goto out; =20 @@ -701,16 +699,15 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, pdev->info =3D *info; if ( pdev->info=2Eis_virtfn ) { - struct pci_dev *pf_pdev =3D - pci_get_pdev(NULL, PCI_SBDF(seg, info->physfn=2Ebus, - info->physfn=2Edevfn)); + pci_sbdf_t pf_sbdf =3D PCI_SBDF(sbdf=2Eseg, info->physfn=2Ebu= s, + info->physfn=2Edevfn); + struct pci_dev *pf_pdev =3D pci_get_pdev(NULL, pf_sbdf); =20 if ( !pf_pdev ) { printk(XENLOG_WARNING "Attempted to add SR-IOV VF %pp without PF %pp\n", - &pdev->sbdf, - &PCI_SBDF(seg, info->physfn=2Ebus, info->physfn=2E= devfn)); + &sbdf, &pf_sbdf); free_pdev(pseg, pdev); ret =3D -ENODEV; goto out; @@ -729,14 +726,14 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, if ( !pdev->ext_cfg ) printk(XENLOG_WARNING "%pp: VF without extended config space?\n", - &pdev->sbdf); + &sbdf); } } =20 if ( !pdev->info=2Eis_virtfn && !pdev->physfn=2Evf_rlen[0] ) { unsigned int pos =3D pci_find_ext_capability(pdev, PCI_EXT_CAP_ID= _SRIOV); - uint16_t ctrl =3D pci_conf_read16(pdev->sbdf, pos + PCI_SRIOV_CTR= L); + uint16_t ctrl =3D pci_conf_read16(sbdf, pos + PCI_SRIOV_CTRL); =20 if ( !pos ) /* Nothing */; @@ -750,18 +747,18 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, for ( i =3D 0; i < PCI_SRIOV_NUM_BARS; ) { unsigned int idx =3D pos + PCI_SRIOV_BAR + i * 4; - uint32_t bar =3D pci_conf_read32(pdev->sbdf, idx); + uint32_t bar =3D pci_conf_read32(sbdf, idx); =20 if ( (bar & PCI_BASE_ADDRESS_SPACE) =3D=3D PCI_BASE_ADDRESS_SPACE_IO ) { printk(XENLOG_WARNING "SR-IOV device %pp with vf BAR%u in IO space\n= ", - &pdev->sbdf, i); + &sbdf, i); ++i; continue; } - ret =3D pci_size_mem_bar(pdev->sbdf, idx, NULL, + ret =3D pci_size_mem_bar(sbdf, idx, NULL, &pdev->physfn=2Evf_rlen[i], PCI_BAR_VF | ((i =3D=3D PCI_SRIOV_NUM_BARS - 1)= ? @@ -772,7 +769,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, } else printk(XENLOG_WARNING "SR-IOV device %pp has its virtual" - " functions already enabled (%04x)\n", &pdev->sbdf, ct= rl); + " functions already enabled (%04x)\n", &sbdf, ctrl); } =20 check_pdev(pdev); @@ -818,14 +815,16 @@ out: pcidevs_unlock(); if ( !ret ) { - printk(XENLOG_DEBUG "PCI add %s %pp\n", type, &pdev->sbdf); + unsigned int func =3D sbdf=2Efn; + + printk(XENLOG_DEBUG "PCI add %s %pp\n", type, &sbdf); while ( pdev->phantom_stride ) { func +=3D pdev->phantom_stride; if ( PCI_SLOT(func) ) break; printk(XENLOG_DEBUG "PCI phantom %pp\n", - &PCI_SBDF(seg, bus, slot, func)); + &PCI_SBDF(sbdf=2Eseg, sbdf=2Ebus, sbdf=2Edev, func)); } } return ret; diff --git a/xen/drivers/pci/physdev=2Ec b/xen/drivers/pci/physdev=2Ec index d46501b884=2E=2E46735a5fc9 100644 --- a/xen/drivers/pci/physdev=2Ec +++ b/xen/drivers/pci/physdev=2Ec @@ -50,7 +50,8 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(voi= d) arg) } #endif =20 - ret =3D pci_add_device(add=2Eseg, add=2Ebus, add=2Edevfn, &pdev_i= nfo, node); + ret =3D pci_add_device(PCI_SBDF(add=2Eseg, add=2Ebus, add=2Edevfn= ), + &pdev_info, node); break; } =20 diff --git a/xen/include/xen/pci=2Eh b/xen/include/xen/pci=2Eh index ade882caee=2E=2E26c0c6e449 100644 --- a/xen/include/xen/pci=2Eh +++ b/xen/include/xen/pci=2Eh @@ -229,8 +229,8 @@ void setup_hwdom_pci_devices(struct domain *d, int pci_release_devices(struct domain *d); int pci_add_segment(u16 seg); const unsigned long *pci_get_ro_map(u16 seg); -int pci_add_device(u16 seg, u8 bus, u8 devfn, - const struct pci_dev_info *info, nodeid_t node); +int pci_add_device(pci_sbdf_t sbdf, const struct pci_dev_info *info, + nodeid_t node); int pci_remove_device(u16 seg, u8 bus, u8 devfn); int pci_ro_device(int seg, int bus, int devfn); int pci_hide_device(unsigned int seg, unsigned int bus, unsigned int devf= n); --=20 2=2E54=2E0 -- Teddy Astie | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates s= olutions web: https://vates=2Etech ---=Part.ef.f30dce182e3a6b24.19f28d0d76b.198041397edd7b15=--- From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353753.1609467 (Exim 4.92) (envelope-from ) id 1wflKo-0005Z7-26; Fri, 03 Jul 2026 21:22:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353753.1609467; Fri, 03 Jul 2026 21:22:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKn-0005Xe-TV; Fri, 03 Jul 2026 21:22:05 +0000 Received: by outflank-mailman (input) for mailman id 1353753; Fri, 03 Jul 2026 21:22:04 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKm-00051o-8x for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKl-00CeeP-Lo; Fri, 03 Jul 2026 23:22:03 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827de-bab6-0a2a0a5309dd-0a2a450adcec-14 for ; Fri, 03 Jul 2026 23:22:02 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827fa-e40e-0a2a450a0019-5a9b3222c012-3 for ; Fri, 03 Jul 2026 23:22:02 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYB-09Vp; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001RP9-3lTW; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=EXbsKVccUqJVUsNQz6ddm7iFrU6RHTQ7Y+Y2aEq7ws8=; b=bmWLHuUVFitSUFZOTx9OuvAnfd xPH4uTWi9QwLkGQZiHcolsh2xvG2w+yaFIm6i3YV1ye8RBp7cKq+mwvTGGF+JhdBEMUE5bBTAdMKk 0IYlkrAN/MRrqOBcpHFfI+dzK6kbqckneRzOhdzUIj7qH+AWGPVy7JUQLJYgjbTPxlhB4eB5SwXmA uI1j/2xzbfvh6RW09eoS99Y3PPw//1OiHHNoYebGJIdwL13NuGPRTZD4QY77tAFfJcdzkJgJ6DjLo 8KHrwUNDMmWRZUUINWybBd1Ov9lHW3YVD/FKf6ETSPYBgbG7dkcdaqqxnn57QUV+cq3wubXh174y0 gUWoax4g==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 20/36] KVM: x86: Kill last_tsc_{nsec,write,offset} fields Date: Fri, 3 Jul 2026 22:17:59 +0100 Message-ID: <20260703212145.343527-21-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1783113722-CED3BDDE-051B5C97/0/0 X-purgate-type: clean X-purgate-size: 6394 From: David Woodhouse These pointlessly duplicate the cur_tsc_{nsec,write,offset} values. The only place they were used was where the TSC is stable and a new vCPU is being synchronized to the previous setting, in which case the cur_tsc_* value is definitely identical. Rename last_tsc_khz and last_tsc_scaling_ratio to cur_tsc_khz and cur_tsc_scaling_ratio respectively, since they are properties of the current TSC generation. Since cur_tsc_offset now serves as the single source of truth for the TSC generation's offset, the backwards-TSC adjustment (used during S4 resume when the host TSC resets) must also update cur_tsc_offset by the same delta applied to all vCPUs. Without this, subsequent vCPUs that synchronize after the adjustment would get the stale pre-S4 offset. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/include/asm/kvm_host.h | 7 ++--- arch/x86/kvm/x86.c | 45 +++++++++++++++++---------------- 2 files changed, 25 insertions(+), 27 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 87435ddecde1..e752b13c0809 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1486,11 +1486,8 @@ struct kvm_arch { * preemption-disabled region, so it must be a raw spinlock. */ raw_spinlock_t tsc_write_lock; - u64 last_tsc_nsec; - u64 last_tsc_write; - u32 last_tsc_khz; - u64 last_tsc_offset; - u64 last_tsc_scaling_ratio; + u32 cur_tsc_khz; + u64 cur_tsc_scaling_ratio; u64 cur_tsc_nsec; u64 cur_tsc_write; u64 cur_tsc_offset; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index ffe5f98a5688..478147aff56a 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2813,14 +2813,12 @@ static void __kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 offset, u64 tsc, vcpu->kvm->arch.user_set_tsc = true; /* - * We also track th most recent recorded KHZ, write and time to - * allow the matching interval to be extended at each write. + * Track the TSC frequency, scaling ratio, and offset for the current + * generation. These are used to detect matching TSC writes and to + * compute the guest TSC from the host clock. */ - kvm->arch.last_tsc_nsec = ns; - kvm->arch.last_tsc_write = tsc; - kvm->arch.last_tsc_khz = vcpu->arch.virtual_tsc_khz; - kvm->arch.last_tsc_offset = offset; - kvm->arch.last_tsc_scaling_ratio = vcpu->arch.l1_tsc_scaling_ratio; + kvm->arch.cur_tsc_khz = vcpu->arch.virtual_tsc_khz; + kvm->arch.cur_tsc_scaling_ratio = vcpu->arch.l1_tsc_scaling_ratio; vcpu->arch.last_guest_tsc = tsc; @@ -2833,8 +2831,6 @@ static void __kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 offset, u64 tsc, * nanosecond time, offset, and write, so if TSCs are in * sync, we can match exact offset, and if not, we can match * exact software computation in compute_guest_tsc() - * - * These values are tracked in kvm->arch.cur_xxx variables. */ kvm->arch.cur_tsc_generation++; kvm->arch.cur_tsc_nsec = ns; @@ -2874,7 +2870,7 @@ static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value) } offset = kvm_compute_l1_tsc_offset(vcpu, host_tsc, data); - elapsed = ns - kvm->arch.last_tsc_nsec; + elapsed = ns - kvm->arch.cur_tsc_nsec; if (vcpu->arch.virtual_tsc_khz) { if (data == 0) { @@ -2884,7 +2880,7 @@ static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value) */ synchronizing = true; } else if (kvm->arch.user_set_tsc) { - u64 tsc_exp = kvm->arch.last_tsc_write + + u64 tsc_exp = kvm->arch.cur_tsc_write + nsec_to_cycles(vcpu, elapsed); u64 tsc_hz = vcpu->arch.virtual_tsc_khz * 1000LL; /* @@ -2915,7 +2911,7 @@ static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value) * it's better to try to match offsets from the beginning. */ if (synchronizing && - vcpu->arch.virtual_tsc_khz == kvm->arch.last_tsc_khz) { + vcpu->arch.virtual_tsc_khz == kvm->arch.cur_tsc_khz) { /* * If synchronizing, advance the reference point to "now" * so the matching window slides forward with each vCPU. @@ -3199,7 +3195,7 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) * get_kvmclock() to compute kvmclock from the host TSC * without needing a vCPU reference. */ - ka->master_tsc_scaling_ratio = ka->last_tsc_scaling_ratio; + ka->master_tsc_scaling_ratio = ka->cur_tsc_scaling_ratio; tsc_hz = (u64)get_cpu_tsc_khz() * 1000; if (tsc_hz && kvm_caps.has_tsc_control) tsc_hz = kvm_scale_tsc(tsc_hz, @@ -6068,8 +6064,8 @@ static int kvm_arch_tsc_set_attr(struct kvm_vcpu *vcpu, raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); matched = (vcpu->arch.virtual_tsc_khz && - kvm->arch.last_tsc_khz == vcpu->arch.virtual_tsc_khz && - kvm->arch.last_tsc_offset == offset); + kvm->arch.cur_tsc_khz == vcpu->arch.virtual_tsc_khz && + kvm->arch.cur_tsc_offset == offset); tsc = kvm_scale_tsc(rdtsc(), vcpu->arch.l1_tsc_scaling_ratio) + offset; ns = get_kvmclock_base_ns(); @@ -13451,7 +13447,7 @@ int kvm_arch_enable_virtualization_cpu(void) { struct kvm *kvm; struct kvm_vcpu *vcpu; - unsigned long i; + unsigned long i, flags; int ret; u64 local_tsc; u64 max_tsc = 0; @@ -13530,13 +13526,18 @@ int kvm_arch_enable_virtualization_cpu(void) } /* - * We have to disable TSC offset matching.. if you were - * booting a VM while issuing an S4 host suspend.... - * you may have some problem. Solving this issue is - * left as an exercise to the reader. + * Adjust the TSC matching reference by the same + * delta applied to each vCPU's offset, so that + * future KVM_SET_TSC / vCPU creation still matches + * correctly against the adjusted TSC timeline. + * Scale from host to guest TSC rate. */ - kvm->arch.last_tsc_nsec = 0; - kvm->arch.last_tsc_write = 0; + raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); + kvm->arch.cur_tsc_write -= + kvm_scale_tsc(delta_cyc, + kvm->arch.cur_tsc_scaling_ratio); + kvm->arch.cur_tsc_offset += delta_cyc; + raw_spin_unlock_irqrestore(&kvm->arch.tsc_write_lock, flags); } } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353755.1609495 (Exim 4.92) (envelope-from ) id 1wflKq-0006DW-6O; Fri, 03 Jul 2026 21:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353755.1609495; Fri, 03 Jul 2026 21:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKp-0006Cb-Tt; Fri, 03 Jul 2026 21:22:07 +0000 Received: by outflank-mailman (input) for mailman id 1353755; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKn-0005QS-Tu for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKn-00CeeP-A4; Fri, 03 Jul 2026 23:22:05 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827de-bab6-0a2a0a5309dd-0a2a450adcec-18 for ; Fri, 03 Jul 2026 23:22:05 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f7-e40e-0a2a450a0019-5a9b3222e672-3 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKV-0000000AsXw-3fP8; Fri, 03 Jul 2026 21:21:48 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKV-00000001RNm-31u8; Fri, 03 Jul 2026 22:21:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=wvuVYxcpMKTUzB1PVAb2vp+z8q/daFQH97Zt0FzYdTI=; b=W9XzMKZF+Q5CoOq/aV2FImKmn4 +MBNEUMz1UUX//35ieMEnUbaiZsHQsTOrfpMqJyem7xM2MCXsESLogrweax1K4VEn7VGsaAxuFtol n+KQ3EN4fgjtWaRqFyqxHg1HXf/yi2skXyW+jTaS0Qk1V7TSrvx56j13mRj5oekE/3fEQ694N2cEW mgq2fLxp2c99mW3FSQvDkCeudg1OHZOrce5n9XulglxvOXfr3wtY6IequF8Fr3xVB2motyCwj4WPC gykHtGQP7j0TgEtGz5X17+6/VdjMQG4YNf7bRWnBi75ZgSnmbQsHS/Sr74SliiI5bkrRKoTzdHNeY jhjnQZOA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 00/36] Cleaning up the KVM clock mess Date: Fri, 3 Jul 2026 22:17:39 +0100 Message-ID: <20260703212145.343527-1-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1783113725-CFF32DDE-2FE648EC/0/0 X-purgate-type: clean X-purgate-size: 8553 This is v6 of the series to clean up the KVM clock, rebased onto the tip timers/ptp material (the timers-ptp-2026-06-13 merge, which includes Thomas's ktime snapshot series and the read_snapshot patches). The KVM clock has historically suffered from three problems: 1. Imprecision: get_kvmclock_ns() computed the clock from the *host* TSC without applying guest TSC scaling, causing systemic drift from the values the guest computes from its own TSC. 2. Unnecessary discontinuities: gratuitous KVM_REQ_MASTERCLOCK_UPDATE requests caused the master clock reference point to be re-snapshotted, yanking the guest's clock due to arithmetic precision differences. 3. No precise migration API: the existing KVM_[GS]ET_CLOCK only allows setting the clock at a given UTC reference time, which is necessarily imprecise. There was no way to preserve the exact arithmetic relationship between guest TSC and KVM clock across live migration. This series addresses all three, and adds new APIs for precise clock migration and TSC frequency reporting. As an added bonus, it now rips out the whole pvclock_gtod_data hack which was shadowing the kernel's timekeeping, and uses ktime snapshots as $DEITY (well, Thomas) intended. v5: https://lore.kernel.org/all/20260608145455.89187-1-dwmw2@infradead.org/ Changes since v5: - Rebased onto the tip timers-ptp-2026-06-13 merge. - Series shape: two new patches ("KVM: selftests: Use UAPI pvclock-abi.h in xen_shinfo_test" and "KVM: x86: Activate master clock from kvm_arch_init_vm()"); "Replace pvclock_gtod_data vclock_mode with boolean" is replaced by "Cache host vclock_mode for masterclock eligibility checks". - Sean Christopherson's review: * KVM_VCPU_TSC_SCALE: return -ENXIO (not -EINVAL) from the get/set device-attribute handlers when !has_tsc_control, and do so in the patch that introduces the attribute. * Clear SECONDARY_EXEC_TSC_SCALING in setup_vmcs_config() rather than vmx_hardware_setup(), so the per-CPU configs recomputed by vmx_check_processor_compat() stay consistent with the golden vmcs_config. - kernel test robot (0-day), i386 W=1 warnings: * get_kvmclock(): move hv_clock into the use_master_clock block, drop the now-unnecessary get_cpu()/put_cpu() pinning (use_master_clock implies a stable synchronised TSC clocksource), and replace the goto/'fallback:' label with a 'continue'. * pvclock_gtod_notify(): move 'tk' inside CONFIG_X86_64. - Correctness fixes from review: * KVM_SET_CLOCK_GUEST: bound the shift in hvclock_to_hz(), tighten tsc_shift validation to [-31, 31], and reject guest_tsc below pvclock.tsc_timestamp. * kvm_guest_time_update(): read kvmclock_offset inside the pvclock seqcount loop to avoid a torn read. * kvm_snapshot_has_tsc(): honour snap->valid and zero-init the snapshot, avoiding use of uninitialised stack. * kvm_synchronize_tsc(): advance the matched reference point to "now" to preserve the 1-second TSC matching window. * kvm_track_tsc_matching(): request a masterclock update when all_vcpus_matched_tsc changes, so PVCLOCK_TSC_STABLE_BIT is broadcast to the other vCPUs. * kvm_arch_enable_virtualization_cpu(): adjust cur_tsc_offset together with cur_tsc_write under tsc_write_lock on the backwards-TSC / host S4 resume path. * kvm_set_tsc_khz(): sample the guest TSC before changing the ratio, preserving continuity across the frequency change. * Keep the real vclock_mode (int) rather than collapsing it to a bool, so kvm_check_tsc_unstable() still special-cases HVCLOCK. * Activate the master clock, and establish the initial TSC generation and kvmclock epoch, from kvm_arch_init_vm() instead of a synchronous kvm_update_masterclock() at each vCPU creation (avoids O(N^2)). - selftests: use kvm_vm_free() instead of kvm_vm_release(); add the missing Makefile entry for xen_migration_test; guard on KVM_GET_CLOCK_GUEST / KVM_VCPU_TSC_OFFSET availability; use the KVM_VCPU_TSC_SCALE enum instead of a literal; overflow-safe arithmetic and looser tolerances. - Documentation: fix the KVM_VCPU_TSC_OFFSET / KVM_VCPU_TSC_SCALE ReST heading underlines (Randy Dunlap). - UAPI: asm/kvm.h now includes so the KVM_[GS]ET_CLOCK_GUEST ioctls are self-contained. - Collected Dongli Zhang's Tested-by (kexec/LUO testing of the KVM clock accuracy, pvclock-abi UAPI move, KVM_[GS]ET_CLOCK_GUEST and redundant-masterclock-update patches). David Woodhouse (33): KVM: x86/xen: Do not corrupt KVM clock in kvm_xen_shared_info_init() KVM: x86: Improve accuracy of KVM clock when TSC scaling is in force KVM: selftests: Use UAPI pvclock-abi.h in xen_shinfo_test KVM: x86: Explicitly disable TSC scaling without CONSTANT_TSC KVM: x86: Activate master clock immediately on vCPU creation KVM: x86: Add KVM_VCPU_TSC_SCALE and fix the documentation on TSC migration KVM: x86: Avoid NTP frequency skew for KVM clock on 32-bit host KVM: x86: Fold __get_kvmclock() into get_kvmclock() KVM: x86: Restructure get_kvmclock() KVM: x86: Fix KVM clock precision in get_kvmclock() with TSC scaling KVM: x86: Use get_kvmclock() in kvm_get_wall_clock_epoch() KVM: x86: Fix compute_guest_tsc() to handle negative time deltas KVM: x86: Restructure kvm_guest_time_update() for TSC upscaling KVM: x86: Simplify and comment kvm_get_time_scale() KVM: x86: Remove implicit rdtsc() from kvm_compute_l1_tsc_offset() KVM: x86: Improve synchronization in kvm_synchronize_tsc() KVM: x86: Kill last_tsc_{nsec,write,offset} fields KVM: x86: Replace nr_vcpus_matched_tsc count with all_vcpus_matched_tsc bool KVM: x86: Allow KVM master clock mode when TSCs are offset from each other KVM: selftests: Add master clock offset test KVM: x86: Factor out kvm_use_master_clock() KVM: x86: Avoid gratuitous global clock updates KVM: x86/xen: Prevent runstate times from becoming negative KVM: x86: Avoid redundant masterclock updates from multiple vCPUs KVM: x86: Remove runtime Xen TSC frequency CPUID update KVM: selftests: Add Xen/generic CPUID timing leaf test KVM: x86: Re-synchronize TSC after KVM_SET_TSC_KHZ KVM: selftests: Add Xen runstate migration test KVM: x86: Use ktime_get_snapshot_id() for master clock KVM: x86: Compute kvmclock base without pvclock_gtod_data KVM: x86: Cache host vclock_mode for masterclock eligibility checks KVM: x86: Remove pvclock_gtod_data and private timekeeping code KVM: x86: Activate master clock from kvm_arch_init_vm() Jack Allister (3): UAPI: x86: Move pvclock-abi to UAPI for x86 platforms KVM: x86: Add KVM_[GS]ET_CLOCK_GUEST for accurate KVM clock migration KVM: selftests: Add KVM/PV clock selftest to prove timer correction Documentation/virt/kvm/api.rst | 37 + Documentation/virt/kvm/devices/vcpu.rst | 120 ++- MAINTAINERS | 4 +- arch/x86/include/asm/kvm_host.h | 16 +- arch/x86/include/uapi/asm/kvm.h | 7 + arch/x86/include/{ => uapi}/asm/pvclock-abi.h | 27 +- arch/x86/kvm/cpuid.c | 16 - arch/x86/kvm/svm/svm.c | 3 +- arch/x86/kvm/vmx/vmx.c | 10 + arch/x86/kvm/x86.c | 1104 ++++++++++++-------- arch/x86/kvm/xen.c | 30 +- arch/x86/kvm/xen.h | 13 - include/uapi/linux/kvm.h | 3 + scripts/xen-hypercalls.sh | 2 +- tools/testing/selftests/kvm/Makefile.kvm | 5 + .../selftests/kvm/x86/masterclock_offset_test.c | 180 ++++ .../selftests/kvm/x86/pvclock_migration_test.c | 383 +++++++ tools/testing/selftests/kvm/x86/pvclock_test.c | 443 ++++++++ .../selftests/kvm/x86/xen_cpuid_timing_test.c | 230 ++++ .../testing/selftests/kvm/x86/xen_migration_test.c | 194 ++++ tools/testing/selftests/kvm/x86/xen_shinfo_test.c | 17 +- 21 files changed, 2318 insertions(+), 526 deletions(-) base-commit: 2d6d57f889f3 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353758.1609507 (Exim 4.92) (envelope-from ) id 1wflKr-0006Wb-43; Fri, 03 Jul 2026 21:22:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353758.1609507; Fri, 03 Jul 2026 21:22:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKq-0006Td-QL; Fri, 03 Jul 2026 21:22:08 +0000 Received: by outflank-mailman (input) for mailman id 1353758; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKo-0005hr-LN for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKo-00BXCb-1w; Fri, 03 Jul 2026 23:22:06 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48279b-2eae-0a2a0a5409dd-0a2a45019e62-24 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f8-400f-0a2a45010019-5a9b3222a836-3 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYS-3lGH; Fri, 03 Jul 2026 21:21:50 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RQI-3LPT; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=9YLu6jUxizeyw6FPvXNgLWAHtpjzd7Ja/IQI9k+fk+s=; b=fcUVvHAIPPdYkE7/dYS8PsNO0M 0l7rKpCfaWyv7qnO627IUm/45JZzCNXpKFxdSx3aOe4X/asoyK1w+W3ZNk66BM8q3BbjYRzGNQLNV FIOdbKNq2+NaKcooJ/SV2aSPahIzidPDXtyB92+iE1701oAJYZIobMAgIC8rg0p2P6qLAa9eY/PVl /pGKXDoXfX1z+5rZmDtJJ9Wv34vMFTG3iFXgK7vu2PgYTbtbFTcJhelUV/ioie3vUIgVLGidMeVnR PeaxJ2Y8zB3aSgCvh1ZPeMDKjka+OYRslMm979N9HKfPZmmsO4HL0U8OnTYlA/VVYGrcVlh/JcdzD AnicB8aQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 36/36] KVM: x86: Activate master clock from kvm_arch_init_vm() Date: Fri, 3 Jul 2026 22:18:15 +0100 Message-ID: <20260703212145.343527-37-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d62444/1783113721-D18C31E0-8D48DA2E/0/0 X-purgate-type: clean X-purgate-size: 4143 From: David Woodhouse Initialize the TSC generation and master clock state at VM creation time, rather than relying on kvm_update_masterclock() from kvm_arch_vcpu_postcreate(). Set cur_tsc_generation=1, cur_tsc_khz, cur_tsc_scaling_ratio, cur_tsc_offset, cur_tsc_nsec and kvmclock_offset from an atomic ktime/TSC snapshot. This establishes a coherent epoch so that: - The first vCPU synchronizes to the existing generation (getting the pre-computed TSC offset) rather than computing its own. - pvclock_update_vm_gtod_copy() succeeds immediately (no zero tsc_hz from uninitialized cur_tsc_scaling_ratio). - KVM_GET_CLOCK returns valid {host_tsc, realtime} fields as soon as any vCPU exists. - KVM_[GS]ET_CLOCK_GUEST works without a prior KVM_RUN. - No O(N) iteration of all vCPUs on each vCPU creation. This replaces the kvm_update_masterclock() call that was added to kvm_arch_vcpu_postcreate() to work around the missing initialization. Signed-off-by: David Woodhouse Assisted-by: Kiro (claude-opus-4.6-1m) --- arch/x86/kvm/x86.c | 45 +++++++++++++++++++++++++++++++++++++-------- 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 58016af64932..d35f2ac3ef49 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -13161,8 +13161,6 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) return; vcpu_load(vcpu); kvm_synchronize_tsc(vcpu, NULL); - if (!vcpu->kvm->arch.use_master_clock) - kvm_update_masterclock(vcpu->kvm, NULL); vcpu_put(vcpu); /* poll control enabled by default */ @@ -13572,6 +13570,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) { int ret; unsigned long flags; + u64 kvmclock_host_tsc; + s64 kvmclock_ns; if (!kvm_is_vm_type_supported(type)) return -EINVAL; @@ -13603,18 +13603,47 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) seqcount_raw_spinlock_init(&kvm->arch.pvclock_sc, &kvm->arch.tsc_write_lock); ratelimit_state_init(&kvm->arch.kvmclock_update_rs, HZ, 10); ratelimit_set_flags(&kvm->arch.kvmclock_update_rs, RATELIMIT_MSG_ON_RELEASE); - kvm->arch.kvmclock_offset = -get_kvmclock_base_ns(); - kvm->arch.all_vcpus_matched_freq = true; - - raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); - pvclock_update_vm_gtod_copy(kvm); - raw_spin_unlock_irqrestore(&kvm->arch.tsc_write_lock, flags); kvm->arch.default_tsc_khz = max_tsc_khz ? : tsc_khz; kvm->arch.apic_bus_cycle_ns = APIC_BUS_CYCLE_NS_DEFAULT; kvm->arch.guest_can_read_msr_platform_info = true; kvm->arch.enable_pmu = enable_pmu; + kvm->arch.all_vcpus_matched_freq = true; + kvm->arch.all_vcpus_matched_tsc = true; + kvm->arch.cur_tsc_scaling_ratio = kvm_caps.default_tsc_scaling_ratio; + kvm->arch.cur_tsc_khz = kvm->arch.default_tsc_khz; + + raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); + + /* + * Establish the initial TSC generation for synchronization logic. + * The first vCPU will sync to this, starting its guest TSC at the + * number of cycles elapsed since VM creation rather than at zero. + * This ensures coherence with the kvmclock epoch (also set here) + * and means the master clock snapshot taken below is immediately + * valid — no need to redo it at first vCPU creation. + */ +#ifdef CONFIG_X86_64 + if (!kvm_get_time_and_clockread(&kvmclock_ns, &kvmclock_host_tsc)) +#endif + { + /* + * If not simultaneous, we want the TSC to be zero slightly + * *after* the kvmclock is zero. + */ + kvmclock_ns = get_kvmclock_base_ns(); + kvmclock_host_tsc = rdtsc(); + } + kvm->arch.cur_tsc_write = 0; + kvm->arch.cur_tsc_offset = -(s64)kvmclock_host_tsc; + kvm->arch.cur_tsc_nsec = kvmclock_ns; + kvm->arch.cur_tsc_generation = 1; + kvm->arch.kvmclock_offset = -kvmclock_ns; + + pvclock_update_vm_gtod_copy(kvm); + raw_spin_unlock_irqrestore(&kvm->arch.tsc_write_lock, flags); + #if IS_ENABLED(CONFIG_HYPERV) spin_lock_init(&kvm->arch.hv_root_tdp_lock); kvm->arch.hv_root_tdp = INVALID_PAGE; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353750.1609444 (Exim 4.92) (envelope-from ) id 1wflKm-00053h-Qm; Fri, 03 Jul 2026 21:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353750.1609444; Fri, 03 Jul 2026 21:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKm-00053F-Js; Fri, 03 Jul 2026 21:22:04 +0000 Received: by outflank-mailman (input) for mailman id 1353750; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKl-00051Q-Fi for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKk-001t36-Sc; Fri, 03 Jul 2026 23:22:02 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827ca-bab6-0a2a0a5309dd-0a2a4503bf3c-18 for ; Fri, 03 Jul 2026 23:22:02 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827fa-ec1a-0a2a45030019-5a9b3222b952-3 for ; Fri, 03 Jul 2026 23:22:02 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYF-1TB1; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPX-0w0H; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=V5hQ2fJb27QK5yOdBL7f7A818+T1JNBNilH2QwnYDyE=; b=UEnwhLQsS2wkPtr1Pd+i9zzOxH sP8ejEvNPTu+HXmRA1IRK2tldo2/gJzqZvVFkblE3k6NJg2illNeTq4r1tIkNMYNlkdWFonJNHdMK mhSmA+bD14VOI9+r+ngRb7JB7fqCDAalnTCht1e3MXaFddIt8qbgkhuau0zS6oAateAvgrEcabeSd 8ssD8QbBlyyz0HmKWi8dhUlItveVTjZXTUCDUvvZgduEIsDDko+7didrcRF7/U9ZjOHxshnYVg5m8 dzZupkJUGPLn1s+4YQMYQSdzXtYuOWrxtKD6MQ0XG4ZFW1ckoKyrimh4GbzgzAMJIyiUdwJSkSu0l 7JBF15DA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 26/36] KVM: x86/xen: Prevent runstate times from becoming negative Date: Fri, 3 Jul 2026 22:18:05 +0100 Message-ID: <20260703212145.343527-27-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1783113722-B59BA5D1-E40BB414/0/0 X-purgate-type: clean X-purgate-size: 3262 From: David Woodhouse When kvm_xen_update_runstate() is invoked to set a vCPU's runstate, the time spent in the previous runstate is accounted. This is based on the delta between the current KVM clock time, and the previous value stored in vcpu->arch.xen.runstate_entry_time. If the KVM clock goes backwards, that delta will be negative. Or, since it's an unsigned 64-bit integer, very *large*. Linux guests deal with that particularly badly, reporting 100% steal time for ever more (well, for *centuries* at least, until the delta has been consumed). So when a negative delta is detected, just refrain from updating the runstate times until the KVM clock catches up with runstate_entry_time again. Also clamp steal_ns to delta_ns to prevent steal time from exceeding the total elapsed time, and handle negative steal_ns (which can happen if run_delay goes backwards across a scheduler update). The userspace APIs for setting the runstate times do not allow them to be set past the current KVM clock, but userspace can still adjust the KVM clock *after* setting the runstate times, which would cause this situation to occur. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/kvm/xen.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c index 82e34edbfdbd..b1d67ece5db3 100644 --- a/arch/x86/kvm/xen.c +++ b/arch/x86/kvm/xen.c @@ -586,29 +586,45 @@ void kvm_xen_update_runstate(struct kvm_vcpu *v, int state) { struct kvm_vcpu_xen *vx = &v->arch.xen; u64 now = get_kvmclock_ns(v->kvm); - u64 delta_ns = now - vx->runstate_entry_time; u64 run_delay = current->sched_info.run_delay; + s64 delta_ns = now - vx->runstate_entry_time; + s64 steal_ns = run_delay - vx->last_steal; + /* + * If the vCPU was never run before, its prior state should + * be considered RUNSTATE_offline. + */ if (unlikely(!vx->runstate_entry_time)) vx->current_runstate = RUNSTATE_offline; + /* + * If KVM clock went backwards, just update the current runstate + * but don't account any time. Leave entry_time unchanged so the + * next positive delta covers the full period once the clock + * catches up. Update last_steal every time so stolen time only + * reflects the interval since the most recent call. + */ + if (delta_ns < 0) + goto update_guest; + /* * Time waiting for the scheduler isn't "stolen" if the * vCPU wasn't running anyway. */ - if (vx->current_runstate == RUNSTATE_running) { - u64 steal_ns = run_delay - vx->last_steal; + if (vx->current_runstate == RUNSTATE_running && steal_ns > 0) { + if (steal_ns > delta_ns) + steal_ns = delta_ns; delta_ns -= steal_ns; - vx->runstate_times[RUNSTATE_runnable] += steal_ns; } - vx->last_steal = run_delay; vx->runstate_times[vx->current_runstate] += delta_ns; - vx->current_runstate = state; vx->runstate_entry_time = now; + update_guest: + vx->current_runstate = state; + vx->last_steal = run_delay; if (vx->runstate_cache.active) kvm_xen_update_runstate_guest(v, state == RUNSTATE_runnable); } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353751.1609454 (Exim 4.92) (envelope-from ) id 1wflKn-0005Fb-BS; Fri, 03 Jul 2026 21:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353751.1609454; Fri, 03 Jul 2026 21:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKn-0005Eh-60; Fri, 03 Jul 2026 21:22:05 +0000 Received: by outflank-mailman (input) for mailman id 1353751; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKk-00051P-Kz for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKk-001t36-1i; Fri, 03 Jul 2026 23:22:02 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827ca-bab6-0a2a0a5309dd-0a2a4503bf3c-16 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f9-ec1a-0a2a45030019-5a9b3222c562-3 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYG-1i3E; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPb-1H0I; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=CzWz4Us7r/rEWP66HSxuHNlM7/EVQzg+tC4fjHgL8hU=; b=mTF1YHeydnaypEa+INXWx9qXoR M0PqgmKfFa4z677E1dsW1eEvyWkF6xUV1PdB8gg/x+CCYBbTc8AfTSe7OkZPaq2U5ubShAbVjKgct kCMUrQtwKWJRjjP9W7glXLslomFXL1Uab3oPmtTv/VeXByun+aTfqAFILzp5HUTkuKh4m1NdyROs6 HNxK1P0nee9tkb0MG2OqepLt57YqRuJjvJlfa11a8OWJs2g1z30A2IGWV3whrfTOf0xpAlQC1+teG DfqFxOoVBfqyecjXVw+McN+dGdz8Nmn7AjS0GmGwMHLWHq8299lfwPp8dMCfRogqtIfbHaA41RpTZ GQMkyl5A==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 27/36] KVM: x86: Avoid redundant masterclock updates from multiple vCPUs Date: Fri, 3 Jul 2026 22:18:06 +0100 Message-ID: <20260703212145.343527-28-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1783113721-B63305D1-3A59CD18/0/0 X-purgate-type: clean X-purgate-size: 5183 From: David Woodhouse When a masterclock update is triggered (e.g. by the clocksource change notifier), KVM_REQ_MASTERCLOCK_UPDATE is set on all vCPUs. Without this fix, each vCPU independently processes the request and redundantly re-executes the entire pvclock_update_vm_gtod_copy() sequence, serialized only by tsc_write_lock. Each redundant re-snapshot of the master clock reference point introduces potential clock drift. Fix this by having __kvm_start_pvclock_update() check, after acquiring the lock, whether the requesting vCPU's KVM_REQ_MASTERCLOCK_UPDATE is still set. If another vCPU already did the update and cleared it, bail out. Otherwise, clear the request on all other vCPUs before proceeding. The caller in vcpu_enter_guest() now uses kvm_test_request() (non-clearing) since the clearing is done inside __kvm_start_pvclock_update() under the lock. Suggested-by: Dongli Zhang Signed-off-by: David Woodhouse Tested-by: Dongli Zhang --- arch/x86/kvm/x86.c | 60 +++++++++++++++++++++++++++++++++++----------- 1 file changed, 46 insertions(+), 14 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 2a1e1a1ab6ee..80fe69974ded 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3282,10 +3282,39 @@ static void kvm_make_mclock_inprogress_request(struct kvm *kvm) kvm_make_all_cpus_request(kvm, KVM_REQ_MCLOCK_INPROGRESS); } -static void __kvm_start_pvclock_update(struct kvm *kvm) +static void kvm_clear_mclock_inprogress_request(struct kvm *kvm) { + struct kvm_vcpu *vcpu; + unsigned long i; + + kvm_for_each_vcpu(i, vcpu, kvm) + kvm_clear_request(KVM_REQ_MCLOCK_INPROGRESS, vcpu); +} + +static bool __kvm_start_pvclock_update(struct kvm *kvm, struct kvm_vcpu *requesting_vcpu) +{ + struct kvm_vcpu *vcpu; + unsigned long i; + raw_spin_lock_irq(&kvm->arch.tsc_write_lock); + + /* + * If another vCPU already did the update while we were waiting + * for the lock, our request will have been cleared. Bail out. + */ + if (requesting_vcpu && + !kvm_test_request(KVM_REQ_MASTERCLOCK_UPDATE, requesting_vcpu)) { + kvm_clear_mclock_inprogress_request(kvm); + raw_spin_unlock_irq(&kvm->arch.tsc_write_lock); + return false; + } + + /* The update is VM-wide; prevent other vCPUs from redoing it. */ + kvm_for_each_vcpu(i, vcpu, kvm) + kvm_clear_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu); + write_seqcount_begin(&kvm->arch.pvclock_sc); + return true; } static void kvm_start_pvclock_update(struct kvm *kvm) @@ -3293,7 +3322,7 @@ static void kvm_start_pvclock_update(struct kvm *kvm) kvm_make_mclock_inprogress_request(kvm); /* no guest entries from this point */ - __kvm_start_pvclock_update(kvm); + __kvm_start_pvclock_update(kvm, NULL); } static void kvm_end_pvclock_update(struct kvm *kvm) @@ -3302,22 +3331,25 @@ static void kvm_end_pvclock_update(struct kvm *kvm) struct kvm_vcpu *vcpu; unsigned long i; - write_seqcount_end(&ka->pvclock_sc); - raw_spin_unlock_irq(&ka->tsc_write_lock); kvm_for_each_vcpu(i, vcpu, kvm) kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); /* guest entries allowed */ - kvm_for_each_vcpu(i, vcpu, kvm) - kvm_clear_request(KVM_REQ_MCLOCK_INPROGRESS, vcpu); + kvm_clear_mclock_inprogress_request(kvm); + + write_seqcount_end(&ka->pvclock_sc); + raw_spin_unlock_irq(&ka->tsc_write_lock); } -static void kvm_update_masterclock(struct kvm *kvm) +static void kvm_update_masterclock(struct kvm *kvm, struct kvm_vcpu *vcpu) { kvm_hv_request_tsc_page_update(kvm); - kvm_start_pvclock_update(kvm); - pvclock_update_vm_gtod_copy(kvm); - kvm_end_pvclock_update(kvm); + kvm_make_mclock_inprogress_request(kvm); + + if (__kvm_start_pvclock_update(kvm, vcpu)) { + pvclock_update_vm_gtod_copy(kvm); + kvm_end_pvclock_update(kvm); + } } /* @@ -10144,7 +10176,7 @@ static void kvm_hyperv_tsc_notifier(void) kvm_caps.max_guest_tsc_khz = tsc_khz; list_for_each_entry(kvm, &vm_list, vm_list) { - __kvm_start_pvclock_update(kvm); + __kvm_start_pvclock_update(kvm, NULL); pvclock_update_vm_gtod_copy(kvm); kvm_end_pvclock_update(kvm); } @@ -11522,8 +11554,8 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu) kvm_mmu_free_obsolete_roots(vcpu); if (kvm_check_request(KVM_REQ_MIGRATE_TIMER, vcpu)) __kvm_migrate_timers(vcpu); - if (kvm_check_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu)) - kvm_update_masterclock(vcpu->kvm); + if (kvm_test_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu)) + kvm_update_masterclock(vcpu->kvm, vcpu); if (kvm_check_request(KVM_REQ_GLOBAL_CLOCK_UPDATE, vcpu)) kvm_gen_kvmclock_update(vcpu); if (kvm_check_request(KVM_REQ_CLOCK_UPDATE, vcpu)) { @@ -13260,7 +13292,7 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) vcpu_load(vcpu); kvm_synchronize_tsc(vcpu, NULL); if (!vcpu->kvm->arch.use_master_clock) - kvm_update_masterclock(vcpu->kvm); + kvm_update_masterclock(vcpu->kvm, NULL); vcpu_put(vcpu); /* poll control enabled by default */ -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353749.1609448 (Exim 4.92) (envelope-from ) id 1wflKn-00056f-3S; Fri, 03 Jul 2026 21:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353749.1609448; Fri, 03 Jul 2026 21:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKm-00055K-Rl; Fri, 03 Jul 2026 21:22:04 +0000 Received: by outflank-mailman (input) for mailman id 1353749; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKl-00051N-OQ for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKj-00A7vt-8P; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827ce-e002-0a2a0a5209dd-0a2a45029cd6-32 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f8-5a27-0a2a45020019-5a9b322291d8-3 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKW-0000000AsXz-0V43; Fri, 03 Jul 2026 21:21:48 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001RO5-085M; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=0/Ko95h1bBGKJF1vvgeKDeWdrJpZvK3VkW99NKrhR+Q=; b=S3vRHxeLB0ApTOC406bbIRimZD LC6e7diwcttbDgjqEu6A71ZDwAAcje0fFBxS68GU3Rfpt7DbqJ9S/Kc6YHHHgvP/ABwSAHYC9PBFL ExKQNj0bFNhPncvKdMD4ZLP4CgQKvO9Xa4jNtOj9quyXzxQqCYv77ZbzSeLPna3xQqFpaUM7C8hpL w1ToHaEd0myJRhspO9phRm30ftZIbMOSVix/C2jEv5SWWjcilsUMd/+SAOStTEb/ZP8M6rNDJN6oU 9W7Wj/lhjERIlMWnMxL286yDCeSUwlLCNPdfZi9mNLMZt6wx3/JQQHG1MfOiAlxHMdyGK8Yfr6PoF Wq7/22PQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 05/36] KVM: x86: Add KVM_[GS]ET_CLOCK_GUEST for accurate KVM clock migration Date: Fri, 3 Jul 2026 22:17:44 +0100 Message-ID: <20260703212145.343527-6-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-720697/1783113720-5411E7C5-86A5D477/0/0 X-purgate-type: clean X-purgate-size: 11360 From: Jack Allister In the common case (where kvm->arch.use_master_clock is true), the KVM clock is defined as a simple arithmetic function of the guest TSC, based on a reference point stored in kvm->arch.master_kernel_ns and kvm->arch.master_cycle_now. The existing KVM_[GS]ET_CLOCK functionality does not allow for this relationship to be precisely saved and restored by userspace. All it can currently do is set the KVM clock at a given UTC reference time, which is necessarily imprecise. So on live update, the guest TSC can remain cycle accurate at precisely the same offset from the host TSC, but there is no way for userspace to restore the KVM clock accurately. Even on live migration to a new host, where the accuracy of the guest time-keeping is fundamentally limited by the accuracy of wallclock synchronization between the source and destination hosts, the clock jump experienced by the guest's TSC and its KVM clock should at least be *consistent*. Even when the guest TSC suffers a discontinuity, its KVM clock should still remain the *same* arithmetic function of the guest TSC, and not suffer an *additional* discontinuity. To allow for accurate migration of the KVM clock, add per-vCPU ioctls which save and restore the actual PV clock info in pvclock_vcpu_time_info. The restoration in KVM_SET_CLOCK_GUEST works by creating a new reference point in time just as kvm_update_masterclock() does, and calculating the corresponding guest TSC value. This guest TSC value is then passed through the user-provided pvclock structure to generate the *intended* KVM clock value at that point in time, and through the *actual* KVM clock calculation. Then kvm->arch.kvmclock_offset is adjusted to eliminate the difference. Where kvm->arch.use_master_clock is false (because the host TSC is unreliable, or the guest TSCs are configured strangely), the KVM clock is *not* defined as a function of the guest TSC so KVM_GET_CLOCK_GUEST returns an error. In this case, as documented, userspace shall use the legacy KVM_GET_CLOCK ioctl. The loss of precision is acceptable in this case since the clocks are imprecise in this mode anyway. On *restoration*, if kvm->arch.use_master_clock is false, an error is returned for similar reasons and userspace shall fall back to using KVM_SET_CLOCK. This does mean that, as documented, userspace needs to use *both* KVM_GET_CLOCK_GUEST and KVM_GET_CLOCK and send both results with the migration data (unless the intent is to refuse to resume on a host with bad TSC). Co-developed-by: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Jack Allister Reviewed-by: Paul Durrant Cc: Dongli Zhang Tested-by: Dongli Zhang --- Documentation/virt/kvm/api.rst | 37 +++++++ arch/x86/include/uapi/asm/kvm.h | 1 + arch/x86/kvm/x86.c | 171 ++++++++++++++++++++++++++++++++ include/uapi/linux/kvm.h | 3 + 4 files changed, 212 insertions(+) diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst index 52bbbb553ce1..2268b4442df6 100644 --- a/Documentation/virt/kvm/api.rst +++ b/Documentation/virt/kvm/api.rst @@ -6553,6 +6553,43 @@ KVM_S390_KEYOP_SSKE Sets the storage key for the guest address ``guest_addr`` to the key specified in ``key``, returning the previous value in ``key``. +4.145 KVM_GET_CLOCK_GUEST +---------------------------- + +:Capability: none +:Architectures: x86_64 +:Type: vcpu ioctl +:Parameters: struct pvclock_vcpu_time_info (out) +:Returns: 0 on success, <0 on error + +Retrieves the current time information structure used for KVM/PV clocks, +in precisely the form advertised to the guest vCPU, which gives parameters +for a direct conversion from a guest TSC value to nanoseconds. + +When the KVM clock is not in "master clock" mode, for example because the +host TSC is unreliable or the guest TSCs are oddly configured, the KVM clock +is actually defined by the host CLOCK_MONOTONIC_RAW instead of the guest TSC. +In this case, the KVM_GET_CLOCK_GUEST ioctl returns -EINVAL. + +4.146 KVM_SET_CLOCK_GUEST +---------------------------- + +:Capability: none +:Architectures: x86_64 +:Type: vcpu ioctl +:Parameters: struct pvclock_vcpu_time_info (in) +:Returns: 0 on success, <0 on error + +Sets the KVM clock (for the whole VM) in terms of the vCPU TSC, using the +pvclock structure as returned by KVM_GET_CLOCK_GUEST. This allows the precise +arithmetic relationship between guest TSC and KVM clock to be preserved by +userspace across migration. + +When the KVM clock is not in "master clock" mode, and the KVM clock is actually +defined by the host CLOCK_MONOTONIC_RAW, this ioctl returns -EINVAL. Userspace +may choose to set the clock using the less precise KVM_SET_CLOCK ioctl, or may +choose to fail, denying migration to a host whose TSC is misbehaving. + .. _kvm_run: 5. The kvm_run structure diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kvm.h index 5f2b30d0405c..5f4a66b1662a 100644 --- a/arch/x86/include/uapi/asm/kvm.h +++ b/arch/x86/include/uapi/asm/kvm.h @@ -12,6 +12,7 @@ #include #include #include +#include #define KVM_PIO_PAGE_OFFSET 1 #define KVM_COALESCED_MMIO_PAGE_OFFSET 2 diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index dbcff49cd561..ff45577ed90c 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -6210,6 +6210,169 @@ static int kvm_get_reg_list(struct kvm_vcpu *vcpu, return 0; } +#ifdef CONFIG_X86_64 +static int kvm_vcpu_ioctl_get_clock_guest(struct kvm_vcpu *v, void __user *argp) +{ + struct pvclock_vcpu_time_info hv_clock = {}; + struct kvm_vcpu_arch *vcpu = &v->arch; + struct kvm_arch *ka = &v->kvm->arch; + unsigned int seq; + + /* + * If KVM_REQ_CLOCK_UPDATE is already pending, or if the pvclock + * has never been generated at all, call kvm_guest_time_update(). + */ + if (kvm_check_request(KVM_REQ_CLOCK_UPDATE, v) || !vcpu->hw_tsc_hz) { + int idx = srcu_read_lock(&v->kvm->srcu); + int ret = kvm_guest_time_update(v); + + srcu_read_unlock(&v->kvm->srcu, idx); + if (ret) + return -EINVAL; + } + + /* + * Reconstruct the pvclock from the master clock state, matching + * exactly what kvm_guest_time_update() writes to the guest. + */ + do { + seq = read_seqcount_begin(&ka->pvclock_sc); + + if (!ka->use_master_clock) + return -EINVAL; + + hv_clock.tsc_timestamp = kvm_read_l1_tsc(v, ka->master_cycle_now); + hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset; + } while (read_seqcount_retry(&ka->pvclock_sc, seq)); + + hv_clock.tsc_shift = vcpu->pvclock_tsc_shift; + hv_clock.tsc_to_system_mul = vcpu->pvclock_tsc_mul; + hv_clock.flags = PVCLOCK_TSC_STABLE_BIT; + + if (copy_to_user(argp, &hv_clock, sizeof(hv_clock))) + return -EFAULT; + + return 0; +} + +/* + * Reverse the calculation in the hv_clock definition. + * + * time_ns = ( (cycles << shift) * mul ) >> 32; + * (although shift can be negative, so that's bad C) + * + * So for a single second, + * NSEC_PER_SEC = ( ( FREQ_HZ << shift) * mul ) >> 32 + * NSEC_PER_SEC << 32 = ( FREQ_HZ << shift ) * mul + * ( NSEC_PER_SEC << 32 ) / mul = FREQ_HZ << shift + * ( NSEC_PER_SEC << 32 ) / mul ) >> shift = FREQ_HZ + */ +static u64 hvclock_to_hz(u32 mul, s8 shift) +{ + u64 tm = NSEC_PER_SEC << 32; + + /* Maximise precision. Shift right until the top bit is set */ + tm <<= 2; + shift += 2; + + /* While 'mul' is even, increase the shift *after* the division */ + while (!(mul & 1)) { + shift++; + mul >>= 1; + } + + tm /= mul; + + if (shift >= 64) + return 0; + if (shift > 0) + return tm >> shift; + if (shift <= -64) + return 0; + return tm << -shift; +} + +static int kvm_vcpu_ioctl_set_clock_guest(struct kvm_vcpu *v, void __user *argp) +{ + struct pvclock_vcpu_time_info user_hv_clock; + struct kvm *kvm = v->kvm; + struct kvm_arch *ka = &kvm->arch; + u64 curr_tsc_hz, user_tsc_hz; + u64 user_clk_ns; + u64 guest_tsc; + int rc = 0; + + if (copy_from_user(&user_hv_clock, argp, sizeof(user_hv_clock))) + return -EFAULT; + + if (user_hv_clock.pad0 || user_hv_clock.pad[0] || user_hv_clock.pad[1]) + return -EINVAL; + + if (!user_hv_clock.tsc_to_system_mul) + return -EINVAL; + + if (user_hv_clock.tsc_shift < -31 || user_hv_clock.tsc_shift > 31) + return -EINVAL; + + user_tsc_hz = hvclock_to_hz(user_hv_clock.tsc_to_system_mul, + user_hv_clock.tsc_shift); + + kvm_hv_request_tsc_page_update(kvm); + + /* + * kvm_start_pvclock_update() takes tsc_write_lock and opens + * the pvclock seqcount; kvm_end_pvclock_update() closes both. + * All clock state modifications between them are atomic with + * respect to readers in kvm_guest_time_update(). + */ + kvm_start_pvclock_update(kvm); + pvclock_update_vm_gtod_copy(kvm); + + if (!ka->use_master_clock) { + rc = -EINVAL; + goto out; + } + + curr_tsc_hz = (u64)get_cpu_tsc_khz() * 1000; + if (unlikely(curr_tsc_hz == 0)) { + rc = -EINVAL; + goto out; + } + + if (kvm_caps.has_tsc_control) + curr_tsc_hz = kvm_scale_tsc(curr_tsc_hz, + v->arch.l1_tsc_scaling_ratio); + + /* + * Allow for a discrepancy of 1 kHz either way between the TSC + * frequency used to generate the user's pvclock and the current + * host's measured frequency, since they may not precisely match. + */ + if (user_tsc_hz < curr_tsc_hz - 1000 || + user_tsc_hz > curr_tsc_hz + 1000) { + rc = -ERANGE; + goto out; + } + + /* + * Calculate the guest TSC at the new reference point, and the + * corresponding KVM clock value according to user_hv_clock. + * Adjust kvmclock_offset so both definitions agree. + */ + guest_tsc = kvm_read_l1_tsc(v, ka->master_cycle_now); + if (guest_tsc < user_hv_clock.tsc_timestamp) { + rc = -EINVAL; + goto out; + } + user_clk_ns = __pvclock_read_cycles(&user_hv_clock, guest_tsc); + ka->kvmclock_offset = user_clk_ns - ka->master_kernel_ns; + +out: + kvm_end_pvclock_update(kvm); + return rc; +} +#endif + long kvm_arch_vcpu_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg) { @@ -6610,6 +6773,14 @@ long kvm_arch_vcpu_ioctl(struct file *filp, srcu_read_unlock(&vcpu->kvm->srcu, idx); break; } +#ifdef CONFIG_X86_64 + case KVM_SET_CLOCK_GUEST: + r = kvm_vcpu_ioctl_set_clock_guest(vcpu, argp); + break; + case KVM_GET_CLOCK_GUEST: + r = kvm_vcpu_ioctl_get_clock_guest(vcpu, argp); + break; +#endif #ifdef CONFIG_KVM_HYPERV case KVM_GET_SUPPORTED_HV_CPUID: r = kvm_ioctl_get_supported_hv_cpuid(vcpu, argp); diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h index 6c8afa2047bf..9b50191b859c 100644 --- a/include/uapi/linux/kvm.h +++ b/include/uapi/linux/kvm.h @@ -1669,4 +1669,7 @@ struct kvm_pre_fault_memory { __u64 padding[5]; }; +#define KVM_SET_CLOCK_GUEST _IOW(KVMIO, 0xd6, struct pvclock_vcpu_time_info) +#define KVM_GET_CLOCK_GUEST _IOR(KVMIO, 0xd7, struct pvclock_vcpu_time_info) + #endif /* __LINUX_KVM_H */ -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353748.1609438 (Exim 4.92) (envelope-from ) id 1wflKm-000522-Fe; Fri, 03 Jul 2026 21:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353748.1609438; Fri, 03 Jul 2026 21:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKm-00051r-CB; Fri, 03 Jul 2026 21:22:04 +0000 Received: by outflank-mailman (input) for mailman id 1353748; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKk-00051O-DP for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKj-001t36-Bn; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827ca-bab6-0a2a0a5309dd-0a2a4503bf3c-14 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f8-ec1a-0a2a45030019-5a9b322284a8-3 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYQ-3NCh; Fri, 03 Jul 2026 21:21:50 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RQ7-2xkg; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=EpzXffKcCC8OCVBj38i2t8eVI2Er97bsxo1QNBYCK8E=; b=jIerjpGT+yTwXfADnzFS9Ehvw1 qj5/hvk/X0LarGRgEVv+dsiKFbGxRWGknJH57gqRXscS5FUYAhSqnvtRBTN2Z6vn9teqs3fY7T27K jW8kTa1Wn2iOLEOqSbhIdiHt8Zmudzhq+tZg56Q8n6poP0Su9bZXGRUplcGieKFs0iNapavWjR6fc hzkoY/l9qx1zH8w8EdFXPjFM5inA9cmW6nJSdRy1/qSf00oSXhQLvq8P2NHcd9wzCsCydXn58F6FC AElEi2x7GlGagDUvtuQfZMQtQYs0miIjMnEqFVh2YzqPw/nArOHgfhgvtrehoSUcccIphTfkzHx4t XG8AdZ9w==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 34/36] KVM: x86: Cache host vclock_mode for masterclock eligibility checks Date: Fri, 3 Jul 2026 22:18:13 +0100 Message-ID: <20260703212145.343527-35-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1783113721-B4F835D1-4427BB93/0/0 X-purgate-type: clean X-purgate-size: 4113 From: David Woodhouse The remaining users of pvclock_gtod_data only need to know whether the host clocksource is TSC-based. Cache the vclock_mode value in a simple kvm_host_vclock_mode variable, updated by the pvclock_gtod_notify callback, and use gtod_is_based_on_tsc() for eligibility checks. This is inherently racy (as it always was — kvm_track_tsc_matching never held the gtod seqcount), relying on eventual consistency: the notifier fires on every timekeeping update and will correct any transient inconsistency within one tick. Signed-off-by: David Woodhouse Assisted-by: Kiro (claude-opus-4.6-1m) --- arch/x86/kvm/x86.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8d520bfae089..c67655f8e078 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2647,6 +2647,8 @@ static u64 compute_guest_tsc(struct kvm_vcpu *vcpu, s64 kernel_ns) } #ifdef CONFIG_X86_64 +static int kvm_host_vclock_mode; + static inline bool gtod_is_based_on_tsc(int mode) { return mode == VDSO_CLOCKMODE_TSC || mode == VDSO_CLOCKMODE_HVCLOCK; @@ -2676,7 +2678,6 @@ static bool kvm_use_master_clock(struct kvm *kvm) static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool update_mclock) { struct kvm_arch *ka = &vcpu->kvm->arch; - struct pvclock_gtod_data *gtod = &pvclock_gtod_data; bool prev_matched_tsc = ka->all_vcpus_matched_tsc; /* @@ -2713,7 +2714,7 @@ static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool update_mclock) * accounts for its offset. */ bool use_master_clock = kvm_use_master_clock(vcpu->kvm) && - gtod_is_based_on_tsc(gtod->clock.vclock_mode); + gtod_is_based_on_tsc(kvm_host_vclock_mode); /* * Request a masterclock update if needed: toggling master clock, @@ -2726,11 +2727,11 @@ static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool update_mclock) trace_kvm_track_tsc(vcpu->vcpu_id, ka->nr_vcpus_matched_tsc, atomic_read(&vcpu->kvm->online_vcpus), - ka->use_master_clock, gtod->clock.vclock_mode); + ka->use_master_clock, kvm_host_vclock_mode); } #else static inline void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, - bool new_generation) {} + bool update_mclock) {} #endif /* @@ -2850,7 +2851,7 @@ static inline bool kvm_check_tsc_unstable(void) * TSC is marked unstable when we're running on Hyper-V, * 'TSC page' clocksource is good. */ - if (pvclock_gtod_data.clock.vclock_mode == VDSO_CLOCKMODE_HVCLOCK) + if (kvm_host_vclock_mode == VDSO_CLOCKMODE_HVCLOCK) return false; #endif return check_tsc_unstable(); @@ -3274,7 +3275,6 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) { #ifdef CONFIG_X86_64 struct kvm_arch *ka = &kvm->arch; - int vclock_mode; bool host_tsc_clocksource; lockdep_assert_held(&kvm->arch.tsc_write_lock); @@ -3314,9 +3314,9 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) ka->use_master_clock = false; } - vclock_mode = pvclock_gtod_data.clock.vclock_mode; - trace_kvm_update_master_clock(ka->use_master_clock, vclock_mode, - ka->all_vcpus_matched_freq); + trace_kvm_update_master_clock(ka->use_master_clock, + kvm_host_vclock_mode, + ka->all_vcpus_matched_freq); #endif } @@ -10399,12 +10399,15 @@ static int pvclock_gtod_notify(struct notifier_block *nb, unsigned long unused, update_pvclock_gtod(tk); #ifdef CONFIG_X86_64 + kvm_host_vclock_mode = + tk->tkr_mono.clock->vdso_clock_mode; + /* * Disable master clock if host does not trust, or does not use, * TSC based clocksource. Delegate queue_work() to irq_work as * this is invoked with tk_core.seq write held. */ - if (!gtod_is_based_on_tsc(pvclock_gtod_data.clock.vclock_mode) && + if (!gtod_is_based_on_tsc(kvm_host_vclock_mode) && atomic_read(&kvm_guest_has_master_clock) != 0) irq_work_queue(&pvclock_irq_work); #endif -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353756.1609501 (Exim 4.92) (envelope-from ) id 1wflKq-0006Is-JK; Fri, 03 Jul 2026 21:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353756.1609501; Fri, 03 Jul 2026 21:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKq-0006H8-7Z; Fri, 03 Jul 2026 21:22:08 +0000 Received: by outflank-mailman (input) for mailman id 1353756; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKo-0005Xr-HM for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKn-00BEX7-GE; Fri, 03 Jul 2026 23:22:05 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827be-5cb7-0a2a0a5109dd-0a2a450bcf44-20 for ; Fri, 03 Jul 2026 23:22:05 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f8-ac48-0a2a450b0019-5a9b3222e674-3 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKW-0000000AsXx-09Ii; Fri, 03 Jul 2026 21:21:48 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKV-00000001RNx-3z0C; Fri, 03 Jul 2026 22:21:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=JGip5OQmCNyYBe2RKNqtANSbVWKYmHi+8pzbH2BRHSA=; b=K/OjjdcT6O/cygwEuqkom8qloZ C+OSPUx10ymjhW/V1tZF78Q5nJxxW2QjPYLriE1GdGwSREYz44Tw3TsyTe82NSqCWM4lhGivf38wg 9D4xJ62zrzNbRoTxpSRpCCvI1dys9Fy/vhBI//h1vnhNBgX8NhQ4YfneO8qb7VoE7Wc2qbmTreVVa GCneIJ/+04IgHesf0fEdF7QfFZ4qvRcVRcQeGwt1frRTnHVzA3JdKed2mpPaZI/LW7m4axN8dohsQ eqIh5yx6j6F7xOtPZxM5z3JlqseV4oJ+7+jG5Og0yXJOI4I7gubsrk0nQ/3NxYg95+n+OLVBYJeVh wxION8tA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 03/36] UAPI: x86: Move pvclock-abi to UAPI for x86 platforms Date: Fri, 3 Jul 2026 22:17:42 +0100 Message-ID: <20260703212145.343527-4-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-42698a/1783113725-A5B20220-C70E66EA/0/0 X-purgate-type: clean X-purgate-size: 3570 From: Jack Allister A subsequent commit will provide a new KVM interface for performing a fixup/correction of the KVM clock against the reference TSC. The KVM_[GS]ET_CLOCK_GUEST API requires a pvclock_vcpu_time_info, as such the caller must know about this definition. Move the definition to the UAPI folder so that it is exported to usermode and also change the type definitions to use the standard for UAPI exports. Signed-off-by: Jack Allister Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant Tested-by: Dongli Zhang --- MAINTAINERS | 4 +-- arch/x86/include/{ => uapi}/asm/pvclock-abi.h | 27 ++++++++++--------- scripts/xen-hypercalls.sh | 2 +- 3 files changed, 18 insertions(+), 15 deletions(-) rename arch/x86/include/{ => uapi}/asm/pvclock-abi.h (82%) diff --git a/MAINTAINERS b/MAINTAINERS index 905c29fe4996..057ccef8d1fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14420,7 +14420,7 @@ S: Supported T: git git://git.kernel.org/pub/scm/virt/kvm/kvm.git F: arch/um/include/asm/kvm_para.h F: arch/x86/include/asm/kvm_para.h -F: arch/x86/include/asm/pvclock-abi.h +F: arch/x86/include/uapi/asm/pvclock-abi.h F: arch/x86/include/uapi/asm/kvm_para.h F: arch/x86/kernel/kvm.c F: arch/x86/kernel/kvmclock.c @@ -29105,7 +29105,7 @@ R: Boris Ostrovsky L: xen-devel@lists.xenproject.org (moderated for non-subscribers) S: Supported F: arch/x86/configs/xen.config -F: arch/x86/include/asm/pvclock-abi.h +F: arch/x86/include/uapi/asm/pvclock-abi.h F: arch/x86/include/asm/xen/ F: arch/x86/platform/pvh/ F: arch/x86/xen/ diff --git a/arch/x86/include/asm/pvclock-abi.h b/arch/x86/include/uapi/asm/pvclock-abi.h similarity index 82% rename from arch/x86/include/asm/pvclock-abi.h rename to arch/x86/include/uapi/asm/pvclock-abi.h index b9fece5fc96d..6d70cf640362 100644 --- a/arch/x86/include/asm/pvclock-abi.h +++ b/arch/x86/include/uapi/asm/pvclock-abi.h @@ -1,6 +1,9 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ #ifndef _ASM_X86_PVCLOCK_ABI_H #define _ASM_X86_PVCLOCK_ABI_H + +#include + #ifndef __ASSEMBLER__ /* @@ -24,20 +27,20 @@ */ struct pvclock_vcpu_time_info { - u32 version; - u32 pad0; - u64 tsc_timestamp; - u64 system_time; - u32 tsc_to_system_mul; - s8 tsc_shift; - u8 flags; - u8 pad[2]; + __u32 version; + __u32 pad0; + __u64 tsc_timestamp; + __u64 system_time; + __u32 tsc_to_system_mul; + __s8 tsc_shift; + __u8 flags; + __u8 pad[2]; } __attribute__((__packed__)); /* 32 bytes */ struct pvclock_wall_clock { - u32 version; - u32 sec; - u32 nsec; + __u32 version; + __u32 sec; + __u32 nsec; } __attribute__((__packed__)); #define PVCLOCK_TSC_STABLE_BIT (1 << 0) diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh index f18b00843df3..51a722198997 100755 --- a/scripts/xen-hypercalls.sh +++ b/scripts/xen-hypercalls.sh @@ -5,7 +5,7 @@ shift in="$@" for i in $in; do - eval $CPP $LINUXINCLUDE -dD -imacros "$i" -x c /dev/null + eval $CPP -D__KERNEL__ $LINUXINCLUDE -dD -imacros "$i" -x c /dev/null done | \ awk '$1 == "#define" && $2 ~ /__HYPERVISOR_[a-z][a-z_0-9]*/ { v[$3] = $2 } END { print "/* auto-generated by scripts/xen-hypercall.sh */" -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353754.1609489 (Exim 4.92) (envelope-from ) id 1wflKp-00067k-QD; Fri, 03 Jul 2026 21:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353754.1609489; Fri, 03 Jul 2026 21:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKp-00065J-Ii; Fri, 03 Jul 2026 21:22:07 +0000 Received: by outflank-mailman (input) for mailman id 1353754; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKn-0005Py-Su for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKn-00A7vt-9e; Fri, 03 Jul 2026 23:22:05 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827a3-e002-0a2a0a5209dd-0a2a4507d220-28 for ; Fri, 03 Jul 2026 23:22:05 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827fc-9c8e-0a2a45070019-5a9b322282c8-3 for ; Fri, 03 Jul 2026 23:22:05 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYE-1AzU; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPT-0m6V; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=Uf6PMMgja7l0D+gznz6ziYSzcjhgw4gAMyV+QMwIS4w=; b=hb/nvHEGmIkkWSIO9fLFyYkl6P lhXj0DAUVaYTNlSjh9Ss2Uc7JqT+E0mDSgQF6HZZfS6Uhrl3pFZMXnt57qYqdw8l/FXZns/+M5YY/ kKM4u3aIR9pCz2XESpfpAi5/Bi1spkdEUwrRa0uWaWvhfktAKSlCmqIgUEiL+l3J8ZMFmlO8ZLLj5 rdW5ORlo4NyoFiq4LVYWiKqBt5CXZNjaAWZ5DKCm0b5O9mq3eWA3bDwiSAPZNZ/Abx6a7eMs3duc3 /POuQuY/i9iQJJ3zU2Q5BVdFKXYQi8EURSyU73jVB+7z0aOV1hkkdmaUMI8Kzbxa0vw9EnSuOEcRF Rl2ZUp/w==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 25/36] KVM: x86: Avoid gratuitous global clock updates Date: Fri, 3 Jul 2026 22:18:04 +0100 Message-ID: <20260703212145.343527-26-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ef75cf/1783113725-FD12E25E-AC831E57/0/0 X-purgate-type: clean X-purgate-size: 2448 From: David Woodhouse Eliminate two sources of unnecessary KVM_REQ_GLOBAL_CLOCK_UPDATE: 1. kvm_write_system_time(): The global clock update was a workaround for ever-drifting clocks based on the host's CLOCK_MONOTONIC subject to NTP skew. Now that the KVM clock uses CLOCK_MONOTONIC_RAW, the clock does not drift with NTP corrections and there is no need to synchronize all vCPUs on boot or resume. Use KVM_REQ_CLOCK_UPDATE on the vCPU itself, and only when the clock is being enabled, not disabled. 2. kvm_arch_vcpu_load(): In master clock mode, migration between pCPUs does not require any clock update since the master clock reference is shared. Only request a local KVM_REQ_CLOCK_UPDATE for the vCPU's first-ever load (vcpu->cpu == -1) to generate initial pvclock params. In non-master-clock mode, keep the global update to synchronize all vCPUs. Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index f8883c3b8ed2..2a1e1a1ab6ee 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2457,13 +2457,13 @@ static void kvm_write_system_time(struct kvm_vcpu *vcpu, gpa_t system_time, } vcpu->arch.time = system_time; - kvm_make_request(KVM_REQ_GLOBAL_CLOCK_UPDATE, vcpu); /* we verify if the enable bit is set... */ - if (system_time & 1) + if (system_time & 1) { kvm_gpc_activate(&vcpu->arch.pv_time, system_time & ~1ULL, sizeof(struct pvclock_vcpu_time_info)); - else + kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); + } else kvm_gpc_deactivate(&vcpu->arch.pv_time); return; @@ -5355,13 +5355,13 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) * On a host with synchronized TSC, there is no need to update * kvmclock on vcpu->cpu migration */ - if (!vcpu->kvm->arch.use_master_clock || vcpu->cpu == -1) { + if (!vcpu->kvm->arch.use_master_clock) { if (__ratelimit(&vcpu->kvm->arch.kvmclock_update_rs)) kvm_make_request(KVM_REQ_GLOBAL_CLOCK_UPDATE, vcpu); else kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); - } - + } else if (vcpu->cpu == -1) + kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); if (vcpu->cpu != cpu) kvm_make_request(KVM_REQ_MIGRATE_TIMER, vcpu); vcpu->cpu = cpu; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353759.1609520 (Exim 4.92) (envelope-from ) id 1wflKs-0006jt-2G; Fri, 03 Jul 2026 21:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353759.1609520; Fri, 03 Jul 2026 21:22:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKr-0006gm-MO; Fri, 03 Jul 2026 21:22:09 +0000 Received: by outflank-mailman (input) for mailman id 1353759; Fri, 03 Jul 2026 21:22:07 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKo-0005nZ-RA for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKo-00BXCb-80; Fri, 03 Jul 2026 23:22:06 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827c7-2eae-0a2a0a5409dd-0a2a4504c5b0-30 for ; Fri, 03 Jul 2026 23:22:06 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f8-a01d-0a2a45040019-5a9b322291dc-3 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKW-0000000AsYA-412E; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001RP5-3Puq; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=aJbyYvbMlra4ob/lrPKW+13k0D2GomXNtoUlefAARyI=; b=RUX0gU2BmZAS8Mc7MvtqcjpKaA 4X2GDo7Scxh/FJ1zfZj/ZZUyMDJLZdQtdY/yzpdVZO3bM/BQQLjwYOuR7nQJiiOLfJN8o9bXd0KEm l746azezEjoQE2RTg+hpkWKNpt6Vb5ogWz+nAFg5mQQ0InOMCWqd7vLGDc76I66RSvfzFQY+yfOne tJbmYqYf4y8NcSnh+ymr0gQ0qUnSjLlbP7a9/JcR68N/4qX/IVF7uUKlxqNM4lp3vkFKExekknJt9 4Ipax9FNfOZuryGMT0mvzgT9ncQ6Of+VmYZ1R2nRjr/PYhl4mTt99MskS2b0Erewa9tJ3yQ+Kw6dt ciUtLalA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 19/36] KVM: x86: Improve synchronization in kvm_synchronize_tsc() Date: Fri, 3 Jul 2026 22:17:58 +0100 Message-ID: <20260703212145.343527-20-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ebf023/1783113720-ACB3B1CC-02C39D49/0/0 X-purgate-type: clean X-purgate-size: 3475 From: David Woodhouse When synchronizing to an existing TSC (either by explicitly writing zero, or the legacy hack where the TSC is written within one second's worth of the previously written TSC), the last_tsc_write and last_tsc_nsec values were being misrecorded by __kvm_synchronize_tsc(). The *unsynchronized* value of the TSC (perhaps even zero) was being recorded, along with the current time at which kvm_synchronize_tsc() was called. This could cause *subsequent* writes to fail to synchronize correctly. Fix that by resetting {data, ns} to the previous values before passing them to __kvm_synchronize_tsc() when synchronization is detected. Except in the case where the TSC is unstable and *has* to be synthesised from the host clock, in which case attempt to create a nsec/tsc pair which is on the correct line. Furthermore, there were *three* different TSC reads used for calculating the "current" time, all slightly different from each other. Fix that by using kvm_get_time_and_clockread() where possible and using the same host_tsc value in all cases. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/kvm/x86.c | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 0fa2050f4bd4..ffe5f98a5688 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -203,6 +203,9 @@ module_param(mitigate_smt_rsb, bool, 0444); * usermode, e.g. SYSCALL MSRs and TSC_AUX, can be deferred until the CPU * returns to userspace, i.e. the kernel can run with the guest's value. */ +#ifdef CONFIG_X86_64 +static bool kvm_get_time_and_clockread(s64 *kernel_ns, u64 *tsc_timestamp); +#endif #define KVM_MAX_NR_USER_RETURN_MSRS 16 struct kvm_user_return_msrs { @@ -2854,14 +2857,23 @@ static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value) { u64 data = user_value ? *user_value : 0; struct kvm *kvm = vcpu->kvm; - u64 offset, ns, elapsed; + u64 offset, host_tsc, elapsed; + s64 ns; unsigned long flags; bool matched = false; bool synchronizing = false; raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); - offset = kvm_compute_l1_tsc_offset(vcpu, rdtsc(), data); - ns = get_kvmclock_base_ns(); + +#ifdef CONFIG_X86_64 + if (!kvm_get_time_and_clockread(&ns, &host_tsc)) +#endif + { + host_tsc = rdtsc(); + ns = get_kvmclock_base_ns(); + } + + offset = kvm_compute_l1_tsc_offset(vcpu, host_tsc, data); elapsed = ns - kvm->arch.last_tsc_nsec; if (vcpu->arch.virtual_tsc_khz) { @@ -2904,13 +2916,18 @@ static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value) */ if (synchronizing && vcpu->arch.virtual_tsc_khz == kvm->arch.last_tsc_khz) { - if (!kvm_check_tsc_unstable()) { + /* + * If synchronizing, advance the reference point to "now" + * so the matching window slides forward with each vCPU. + */ + u64 delta = nsec_to_cycles(vcpu, elapsed); + + data = kvm->arch.cur_tsc_write + delta; + + if (!kvm_check_tsc_unstable()) offset = kvm->arch.cur_tsc_offset; - } else { - u64 delta = nsec_to_cycles(vcpu, elapsed); - data += delta; - offset = kvm_compute_l1_tsc_offset(vcpu, rdtsc(), data); - } + else + offset = kvm_compute_l1_tsc_offset(vcpu, host_tsc, data); matched = true; } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353752.1609462 (Exim 4.92) (envelope-from ) id 1wflKn-0005OF-MH; Fri, 03 Jul 2026 21:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353752.1609462; Fri, 03 Jul 2026 21:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKn-0005Me-Er; Fri, 03 Jul 2026 21:22:05 +0000 Received: by outflank-mailman (input) for mailman id 1353752; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKl-00051M-OQ for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKj-00A7vt-4i; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827a3-e002-0a2a0a5209dd-0a2a4507d220-22 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f7-9c8e-0a2a45070019-5a9b3222db84-3 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYJ-27pF; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPj-1hBl; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=dcChYx15IhyePM7jxxFL8xpvT1sezeCblvUhAhYmoTc=; b=PpxWMrvMWWKNxttwja7nHYJHNJ Tdw+PzgGZjwODRY98hW5BR+tAtE89GRECyXkUmSTeJX1rBty2kcY8W+58CRVlWYk4Bz4l41ihaFha g01FYDjNMOh8OKhpw6xaihQ43pPDg704uo3EVd3bW5xMlHRGXnL0d+Hffs2+SQF+WpgWeEp7CgGs1 Qbg3PriQlFgedyBXaFLnwXicyc7Ph84YMeMxmkCegXoq2LTS4hfbXFUPjEA8KQWIbUH+wERqoWG49 xsrw3fT911L0O1Vdx4DtSCpxTgfx6KSV+Kg3+Gl0SH6biyYxrIIAOSM8tCTHByHs82tPXLS5Knk8Y 1/TJPGTg==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 29/36] KVM: selftests: Add Xen/generic CPUID timing leaf test Date: Fri, 3 Jul 2026 22:18:08 +0100 Message-ID: <20260703212145.343527-30-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ef75cf/1783113721-FD52025E-D8802687/0/0 X-purgate-type: clean X-purgate-size: 8822 From: David Woodhouse Verify that userspace can correctly populate Xen and generic CPUID timing leaves using the KVM_VCPU_TSC_SCALE and KVM_VCPU_TSC_SCALE attributes. This validates that the removal of KVM's runtime Xen CPUID modification doesn't break guests: userspace queries the effective TSC and bus frequencies, computes the pvclock mul/shift, populates the CPUID leaves, and the guest verifies the values match. The test exercises: - KVM_VCPU_TSC_SCALE at native and scaled frequencies - KVM_VCPU_TSC_SCALE ratio verification against effective frequency - Generic timing leaf 0x40000010 (EAX=tsc_khz, EBX=bus_khz) - Xen leaf 3 sub-leaf 0 (ECX=guest TSC kHz) - Xen leaf 3 sub-leaf 1 (ECX=mul, EDX=shift) Gracefully skips TSC scaling tests on hardware without support. Signed-off-by: David Woodhouse --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../selftests/kvm/x86/xen_cpuid_timing_test.c | 230 ++++++++++++++++++ 2 files changed, 231 insertions(+) create mode 100644 tools/testing/selftests/kvm/x86/xen_cpuid_timing_test.c diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 7ecaaf82056e..58aac2980cdf 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -141,6 +141,7 @@ TEST_GEN_PROGS_x86 += x86/xss_msr_test TEST_GEN_PROGS_x86 += x86/debug_regs TEST_GEN_PROGS_x86 += x86/tsc_msrs_test TEST_GEN_PROGS_x86 += x86/vmx_pmu_caps_test +TEST_GEN_PROGS_x86 += x86/xen_cpuid_timing_test TEST_GEN_PROGS_x86 += x86/xen_shinfo_test TEST_GEN_PROGS_x86 += x86/xen_vmcall_test TEST_GEN_PROGS_x86 += x86/sev_init2_tests diff --git a/tools/testing/selftests/kvm/x86/xen_cpuid_timing_test.c b/tools/testing/selftests/kvm/x86/xen_cpuid_timing_test.c new file mode 100644 index 000000000000..2098cb511ef0 --- /dev/null +++ b/tools/testing/selftests/kvm/x86/xen_cpuid_timing_test.c @@ -0,0 +1,230 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Test that userspace can correctly populate Xen and generic CPUID + * timing leaves using KVM_GET_TSC_KHZ and KVM_VCPU_TSC_SCALE. + * + * This validates that the removal of KVM's runtime Xen CPUID modification + * doesn't break guests, because userspace has all the information needed. + */ +#include +#include +#include + +#include "test_util.h" +#include "kvm_util.h" +#include "processor.h" + +#include + +#define XEN_CPUID_BASE 0x40000100 +#define XEN_CPUID_LEAF(n) (XEN_CPUID_BASE + (n)) +#define GENERIC_TIMING_LEAF 0x40000010 + +/* Values set by host, verified by guest */ +static uint32_t expected_tsc_khz; +static uint32_t expected_bus_khz; +static uint32_t expected_tsc_mul; +static int8_t expected_tsc_shift; +static uint64_t host_khz; + +static void guest_code(void) +{ + uint32_t eax, ebx, ecx, edx; + + /* Check generic timing leaf 0x40000010 */ + __cpuid(GENERIC_TIMING_LEAF, 0, &eax, &ebx, &ecx, &edx); + GUEST_ASSERT_EQ(eax, expected_tsc_khz); + GUEST_ASSERT_EQ(ebx, expected_bus_khz); + + /* Check Xen leaf 3, sub-leaf 0: ECX = guest TSC frequency */ + __cpuid(XEN_CPUID_LEAF(3), 0, &eax, &ebx, &ecx, &edx); + GUEST_ASSERT_EQ(ecx, expected_tsc_khz); + + /* Check Xen leaf 3, sub-leaf 1: ECX = mul, EDX = shift */ + __cpuid(XEN_CPUID_LEAF(3), 1, &eax, &ebx, &ecx, &edx); + GUEST_ASSERT_EQ(ecx, expected_tsc_mul); + GUEST_ASSERT_EQ((int8_t)edx, expected_tsc_shift); + + GUEST_SYNC(0); +} + +static void add_cpuid_entry(struct kvm_vcpu *vcpu, uint32_t function, + uint32_t index, uint32_t eax, uint32_t ebx, + uint32_t ecx, uint32_t edx) +{ + struct kvm_cpuid2 *cpuid = vcpu->cpuid; + struct kvm_cpuid_entry2 *entry; + int n = cpuid->nent; + + vcpu->cpuid = realloc(vcpu->cpuid, + sizeof(*cpuid) + (n + 1) * sizeof(*entry)); + cpuid = vcpu->cpuid; + cpuid->nent = n + 1; + + entry = &cpuid->entries[n]; + memset(entry, 0, sizeof(*entry)); + entry->function = function; + entry->index = index; + entry->flags = KVM_CPUID_FLAG_SIGNIFCANT_INDEX; + entry->eax = eax; + entry->ebx = ebx; + entry->ecx = ecx; + entry->edx = edx; +} + +/* + * Compute pvclock mul/shift from frequency, matching kvm_get_time_scale(). + */ +static void compute_tsc_mul_shift(uint64_t tsc_hz, uint32_t *mul, int8_t *shift) +{ + uint64_t scaled = 1000000000ULL; + uint64_t base = tsc_hz; + int32_t s = 0; + uint32_t base32; + + while (base > scaled * 2 || base >> 32) { + base >>= 1; + s--; + } + base32 = (uint32_t)base; + while (base32 <= scaled || scaled >> 32) { + if (scaled >> 32 || base32 & (1U << 31)) + scaled >>= 1; + else + base32 <<= 1; + s++; + } + *mul = (uint32_t)((scaled << 32) / base32); + *shift = (int8_t)s; +} + +static void run_test(uint64_t tsc_khz) +{ + struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + struct ucall uc; + uint32_t effective_tsc_khz, effective_bus_khz; + int bus_cycle_ns; + + vm = vm_create_with_one_vcpu(&vcpu, guest_code); + + if (tsc_khz) { + pr_info("Testing at TSC frequency %lu kHz\n", tsc_khz); + vcpu_ioctl(vcpu, KVM_SET_TSC_KHZ, (void *)(unsigned long)tsc_khz); + } else { + pr_info("Testing at native TSC frequency\n"); + } + + effective_tsc_khz = __vcpu_ioctl(vcpu, KVM_GET_TSC_KHZ, NULL); + bus_cycle_ns = vm_check_cap(vm, KVM_CAP_X86_APIC_BUS_CYCLES_NS); + effective_bus_khz = bus_cycle_ns > 0 ? 1000000 / bus_cycle_ns : 1000000; + + /* If scaling wasn't applied, skip this frequency */ + if (tsc_khz && effective_tsc_khz == host_khz) { + pr_info(" TSC scaling not available, skipping\n"); + kvm_vm_free(vm); + return; + } + + pr_info(" Effective TSC: %u kHz, Bus: %u kHz\n", effective_tsc_khz, effective_bus_khz); + + /* Also exercise KVM_VCPU_TSC_SCALE if available */ + { + struct { uint64_t ratio; uint64_t frac_bits; } scale; + struct kvm_device_attr scale_attr = { + .group = KVM_VCPU_TSC_CTRL, + .attr = KVM_VCPU_TSC_SCALE, + .addr = (uint64_t)(uintptr_t)&scale, + }; + + if (!__vcpu_ioctl(vcpu, KVM_HAS_DEVICE_ATTR, &scale_attr)) { + vcpu_ioctl(vcpu, KVM_GET_DEVICE_ATTR, &scale_attr); + pr_info(" TSC scale: ratio=%lu frac_bits=%lu\n", + scale.ratio, scale.frac_bits); + + /* + * Verify: applying the ratio to the host TSC frequency + * should give approximately the effective frequency. + */ + if (tsc_khz) { + uint64_t computed = ((__uint128_t)host_khz * scale.ratio) >> scale.frac_bits; + int64_t diff = (int64_t)computed - (int64_t)effective_tsc_khz; + + TEST_ASSERT(diff >= -1 && diff <= 1, + "TSC_SCALE ratio mismatch: computed %lu vs effective %u (diff %ld)", + computed, effective_tsc_khz, diff); + } + } + } + + compute_tsc_mul_shift((uint64_t)effective_tsc_khz * 1000, + &expected_tsc_mul, &expected_tsc_shift); + + expected_tsc_khz = effective_tsc_khz; + expected_bus_khz = effective_bus_khz; + + sync_global_to_guest(vm, expected_tsc_khz); + sync_global_to_guest(vm, expected_bus_khz); + sync_global_to_guest(vm, expected_tsc_mul); + sync_global_to_guest(vm, expected_tsc_shift); + + /* Populate CPUID leaves as a VMM would */ + add_cpuid_entry(vcpu, GENERIC_TIMING_LEAF, 0, + effective_tsc_khz, effective_bus_khz, 0, 0); + add_cpuid_entry(vcpu, XEN_CPUID_LEAF(3), 0, + 0, 0, effective_tsc_khz, 0); + add_cpuid_entry(vcpu, XEN_CPUID_LEAF(3), 1, + 0, 0, expected_tsc_mul, + (uint32_t)(uint8_t)expected_tsc_shift); + + vcpu_set_cpuid(vcpu); + + pr_info(" pvclock mul=%u shift=%d\n", expected_tsc_mul, expected_tsc_shift); + + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + + switch (get_ucall(vcpu, &uc)) { + case UCALL_ABORT: + REPORT_GUEST_ASSERT(uc); + break; + case UCALL_SYNC: + break; + default: + TEST_FAIL("Unexpected ucall"); + } + + kvm_vm_free(vm); +} + +int main(void) +{ + uint64_t freq; + struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + struct kvm_device_attr attr = { + .group = KVM_VCPU_TSC_CTRL, + .attr = KVM_VCPU_TSC_SCALE, + }; + + TEST_REQUIRE(sys_clocksource_is_based_on_tsc()); + + /* Check KVM_VCPU_TSC_SCALE is supported (implies TSC scaling) */ + vm = vm_create_with_one_vcpu(&vcpu, guest_code); + TEST_REQUIRE(!__vcpu_ioctl(vcpu, KVM_HAS_DEVICE_ATTR, &attr)); + host_khz = __vcpu_ioctl(vcpu, KVM_GET_TSC_KHZ, NULL); + kvm_vm_free(vm); + + /* Native frequency */ + run_test(0); + + /* Scaled frequencies — skip if TSC scaling not available */ + for (freq = 1000000; freq <= 4000000; freq += 1000000) { + if (freq == host_khz) + continue; + run_test(freq); + } + + pr_info("PASS: All CPUID timing leaf tests passed\n"); + return 0; +} -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353757.1609514 (Exim 4.92) (envelope-from ) id 1wflKr-0006dH-GM; Fri, 03 Jul 2026 21:22:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353757.1609514; Fri, 03 Jul 2026 21:22:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKr-0006aR-6H; Fri, 03 Jul 2026 21:22:09 +0000 Received: by outflank-mailman (input) for mailman id 1353757; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKo-0005h7-Ju for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKj-00BXCb-0b; Fri, 03 Jul 2026 23:22:06 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827c7-2eae-0a2a0a5409dd-0a2a4504c5b0-26 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f7-a01d-0a2a45040019-5a9b3222e448-3 for ; Fri, 03 Jul 2026 23:22:00 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYC-0U5S; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001RPD-46vV; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=sAJ+w5HRGJ1JE3H1Wx/huE4jGAY90IdO6mwCHpL6bJA=; b=fPnUdJ68VFN82oFjJj/i57tghy 0ZFD0hlumo0Eo/gYwzBln/e4uVYPLsis5GydyD/+Vy4w0rNcBsFWA+dW+Ch1zFGpDHSdlShsvrN6H 2XPhUzEfjC6LB0Tg162oU459VFP6GwWorQp5lrMES88+J5LfEdmILh5zqQipXPKBFQL+QF6Pjkixl 636TJb/z0HGrnDJ1GFdnnpOTdabYuoPygi84otBK2A9xaA55UpAOVjtSsMueaNRJPCWb+Nf+bWhfL UHPuZPEewOXB2c2BM4PG3/hV3K+2lePVnxjsArjeyD/3F2zSR5t6Hi71bD2Gy6MSpkMgA9oCaaUzU Dg0T/Ycw==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 21/36] KVM: x86: Replace nr_vcpus_matched_tsc count with all_vcpus_matched_tsc bool Date: Fri, 3 Jul 2026 22:18:00 +0100 Message-ID: <20260703212145.343527-22-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ebf023/1783113720-AFD241CC-35407CC4/0/0 X-purgate-type: clean X-purgate-size: 2850 From: David Woodhouse Using a count and comparing with kvm->online_vcpus was always racy because a new vCPU could be created while kvm_track_tsc_matching() was running and comparing with kvm->online_vcpus. That variable is only atomic with respect to itself; kvm_arch_vcpu_create() runs before kvm->online_vcpus is incremented for the new vCPU. Replace the count with a boolean that is set in kvm_track_tsc_matching() after comparing the count, and cleared when a new TSC generation starts. The boolean is consumed by pvclock_update_vm_gtod_copy() under the tsc_write_lock, which serializes against __kvm_synchronize_tsc(). Keep the count for now as it's still used in the trace event. Signed-off-by: David Woodhouse --- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/x86.c | 10 ++++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index e752b13c0809..51d8bcbc2d1d 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1492,6 +1492,7 @@ struct kvm_arch { u64 cur_tsc_write; u64 cur_tsc_offset; u64 cur_tsc_generation; + bool all_vcpus_matched_tsc; int nr_vcpus_matched_tsc; u32 default_tsc_khz; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 478147aff56a..83c47fe5c9b8 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2651,8 +2651,10 @@ static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool new_generation) * and all vCPUs must have matching TSCs. Note, the count for matching * vCPUs doesn't include the reference vCPU, hence "+1". */ - bool use_master_clock = (ka->nr_vcpus_matched_tsc + 1 == - atomic_read(&vcpu->kvm->online_vcpus)) && + ka->all_vcpus_matched_tsc = (ka->nr_vcpus_matched_tsc + 1 == + atomic_read(&vcpu->kvm->online_vcpus)); + + bool use_master_clock = ka->all_vcpus_matched_tsc && gtod_is_based_on_tsc(gtod->clock.vclock_mode); /* @@ -2837,6 +2839,7 @@ static void __kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 offset, u64 tsc, kvm->arch.cur_tsc_write = tsc; kvm->arch.cur_tsc_offset = offset; kvm->arch.nr_vcpus_matched_tsc = 0; + kvm->arch.all_vcpus_matched_tsc = false; } else if (vcpu->arch.this_tsc_generation != kvm->arch.cur_tsc_generation) { kvm->arch.nr_vcpus_matched_tsc++; } @@ -3169,8 +3172,7 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) bool host_tsc_clocksource, vcpus_matched; lockdep_assert_held(&kvm->arch.tsc_write_lock); - vcpus_matched = (ka->nr_vcpus_matched_tsc + 1 == - atomic_read(&kvm->online_vcpus)); + vcpus_matched = ka->all_vcpus_matched_tsc; /* * If the host uses TSC clock, then passthrough TSC as stable -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353760.1609526 (Exim 4.92) (envelope-from ) id 1wflKs-0006w3-Et; Fri, 03 Jul 2026 21:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353760.1609526; Fri, 03 Jul 2026 21:22:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKs-0006sg-3X; Fri, 03 Jul 2026 21:22:10 +0000 Received: by outflank-mailman (input) for mailman id 1353760; Fri, 03 Jul 2026 21:22:07 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKo-0005mx-QX for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKo-00BXCb-7G; Fri, 03 Jul 2026 23:22:06 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48279b-2eae-0a2a0a5409dd-0a2a45019e62-26 for ; Fri, 03 Jul 2026 23:22:06 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4827f9-400f-0a2a45010019-5a9b3222b94c-3 for ; Fri, 03 Jul 2026 23:22:01 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKW-0000000AsY0-0gKK; Fri, 03 Jul 2026 21:21:48 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001RO9-0J5N; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=/GVIzOguJ6FEtu0Xi+CX41sxIMFfZk32Sup1CQOK2cA=; b=BaLfOYts8sUMPmGLNaou7hmwDv ZEfJ2OXH77XM1HGv9Qct/70aBrcfJbrFrtbzbbsDoOpGsFipDwRaLmNxMu2mtVcacWgZcyXNPob4E g7uxUNPd+zDqY6qBjNJ+x9SpZ1a0eWx9S8whOdlJn11Sdea2BzLYhL6nLX7Nria99A57xj169SUeP IB8A6a3ZpKbJ6hmsFt+zSw0qlRITMmBDgjsOQounx182YctWVblQukg2QqcyGsPz/AVV8mZRN0Xn0 G7G6WOhJrirf5aATGmlwhdiPBxIdukuDn/grl0vpdDfgN1+/dlXxuqFgaxEG4ywrZfLj+AV07Ve/h tySrJOhA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 06/36] KVM: selftests: Add KVM/PV clock selftest to prove timer correction Date: Fri, 3 Jul 2026 22:17:45 +0100 Message-ID: <20260703212145.343527-7-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d62444/1783113721-FFCCE1E0-C9E5487E/0/0 X-purgate-type: clean X-purgate-size: 16061 From: Jack Allister A VM's KVM/PV clock has an inherent relationship to its TSC. When either the host system live-updates or the VM is live-migrated this pairing of the two clock sources should stay the same. In reality this is not the case without some correction taking place. The KVM_GET_CLOCK_GUEST/KVM_SET_CLOCK_GUEST ioctls can be used to perform a correction on the PVTI (PV time information) structure held by KVM to effectively fix up the kvmclock_offset prior to the guest VM resuming in either a live-update/migration scenario. This test proves that without the necessary fixup there is a perceived change in the guest TSC and KVM/PV clock relationship before and after a simulated LU/LM takes place, and that the correction eliminates it. The test: 1. Snapshots the PVTI at boot (PVTI0). 2. Induces a change in PVTI data (KVM_REQ_MASTERCLOCK_UPDATE). 3. Snapshots the PVTI after the change (PVTI1). 4. Requests correction via KVM_SET_CLOCK_GUEST using PVTI0. 5. Snapshots the PVTI after correction (PVTI2). Then samples the TSC at a single point in time and calculates the KVM clock using each PVTI snapshot. The corrected clock should match the boot clock to within ±1ns. The test enumerates multiple TSC frequencies from 1GHz to 5GHz at 500MHz steps, crossing the 32-bit boundary, to exercise the scaling path at various ratios. The sleep duration between snapshots is configurable via the -s/--sleep command line option. Co-developed-by: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Jack Allister Reviewed-by: Paul Durrant Cc: Dongli Zhang --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/x86/pvclock_test.c | 443 ++++++++++++++++++ 2 files changed, 444 insertions(+) create mode 100644 tools/testing/selftests/kvm/x86/pvclock_test.c diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 9118a5a51b89..fb935ae3bf38 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -105,6 +105,7 @@ TEST_GEN_PROGS_x86 += x86/pmu_counters_test TEST_GEN_PROGS_x86 += x86/pmu_event_filter_test TEST_GEN_PROGS_x86 += x86/private_mem_conversions_test TEST_GEN_PROGS_x86 += x86/private_mem_kvm_exits_test +TEST_GEN_PROGS_x86 += x86/pvclock_test TEST_GEN_PROGS_x86 += x86/set_boot_cpu_id TEST_GEN_PROGS_x86 += x86/set_sregs_test TEST_GEN_PROGS_x86 += x86/smaller_maxphyaddr_emulation_test diff --git a/tools/testing/selftests/kvm/x86/pvclock_test.c b/tools/testing/selftests/kvm/x86/pvclock_test.c new file mode 100644 index 000000000000..f2b917ed5dea --- /dev/null +++ b/tools/testing/selftests/kvm/x86/pvclock_test.c @@ -0,0 +1,443 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright © Amazon.com, Inc. or its affiliates. + * + * Tests for pvclock API + * KVM_SET_CLOCK_GUEST/KVM_GET_CLOCK_GUEST + */ +#include +#include +#include +#include +#include + +#include "test_util.h" +#include "kvm_util.h" +#include "processor.h" + +#include + +/* + * Reproduce the pvclock calculation the guest uses to convert TSC to + * nanoseconds. This must match the kernel's __pvclock_read_cycles(). + */ +static inline uint64_t pvclock_scale_delta(uint64_t delta, uint32_t mul, + int8_t shift) +{ + if (shift < 0) + delta >>= -shift; + else + delta <<= shift; + return ((__uint128_t)delta * mul) >> 32; +} + +static inline uint64_t pvclock_read_cycles(struct pvclock_vcpu_time_info *src, + uint64_t tsc) +{ + uint64_t delta = tsc - src->tsc_timestamp; + + return src->system_time + pvclock_scale_delta(delta, + src->tsc_to_system_mul, + src->tsc_shift); +} + +static inline void pvti_snapshot(struct pvclock_vcpu_time_info *dst, + volatile struct pvclock_vcpu_time_info *src) +{ + uint32_t version; + + do { + version = src->version; + __asm__ __volatile__("" ::: "memory"); + *dst = *src; + __asm__ __volatile__("" ::: "memory"); + } while ((src->version & 1) || src->version != version); +} + +enum { + STAGE_FIRST_BOOT, + STAGE_UNCORRECTED, + STAGE_CORRECTED +}; + +#define KVMCLOCK_GPA 0xc0000000ull +#define KVMCLOCK_SIZE sizeof(struct pvclock_vcpu_time_info) + +static void trigger_pvti_update(void) +{ + /* + * Toggle between KVM's old and new system time methods to coerce KVM + * into updating the fields in the PV time info struct. + */ + wrmsr(MSR_KVM_SYSTEM_TIME, KVMCLOCK_GPA | KVM_MSR_ENABLED); + wrmsr(MSR_KVM_SYSTEM_TIME_NEW, KVMCLOCK_GPA | KVM_MSR_ENABLED); +} + +static void guest_code(void) +{ + struct pvclock_vcpu_time_info *pvti = + (void *)(unsigned long)KVMCLOCK_GPA; + struct pvclock_vcpu_time_info pvti_boot; + struct pvclock_vcpu_time_info pvti_uncorrected; + struct pvclock_vcpu_time_info pvti_corrected; + uint64_t tsc_guest; + uint64_t clk_boot, clk_uncorrected, clk_corrected; + int64_t delta_corrected; + + /* Set up kvmclock and snapshot the initial pvclock parameters. */ + wrmsr(MSR_KVM_SYSTEM_TIME_NEW, KVMCLOCK_GPA | KVM_MSR_ENABLED); + pvti_snapshot(&pvti_boot, pvti); + GUEST_SYNC(STAGE_FIRST_BOOT); + + /* + * Trigger an update of the PVTI. Calculating the KVM clock using this + * updated structure will show a delta from the original. + */ + trigger_pvti_update(); + pvti_snapshot(&pvti_uncorrected, pvti); + GUEST_SYNC(STAGE_UNCORRECTED); + + /* + * Snapshot the corrected time (the host does KVM_SET_CLOCK_GUEST when + * handling STAGE_UNCORRECTED). + */ + pvti_snapshot(&pvti_corrected, pvti); + + /* + * Sample the TSC at a single point in time, then calculate the + * effective KVM clock using the PVTI from each stage. Verify that the + * corrected clock matches the boot clock to within ±2ns. + */ + tsc_guest = rdtsc(); + + clk_boot = pvclock_read_cycles(&pvti_boot, tsc_guest); + clk_uncorrected = pvclock_read_cycles(&pvti_uncorrected, tsc_guest); + clk_corrected = pvclock_read_cycles(&pvti_corrected, tsc_guest); + + delta_corrected = clk_boot - clk_corrected; + + __GUEST_ASSERT(delta_corrected >= -2 && delta_corrected <= 2, + "corrected delta %ld out of range (boot=%lu uncorrected=%lu corrected=%lu)", + delta_corrected, clk_boot, clk_uncorrected, clk_corrected); + + GUEST_SYNC(STAGE_CORRECTED); +} + +static void run_test(struct kvm_vm *vm, struct kvm_vcpu *vcpu, + unsigned int sleep_sec) +{ + struct pvclock_vcpu_time_info pvti_before; + struct ucall uc; + + for (;;) { + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + + switch (get_ucall(vcpu, &uc)) { + case UCALL_ABORT: + REPORT_GUEST_ASSERT(uc); + break; + case UCALL_SYNC: + break; + default: + TEST_FAIL("Unexpected ucall"); + } + + switch (uc.args[1]) { + case STAGE_FIRST_BOOT: + /* Save the pvclock parameters before the update. */ + vcpu_ioctl(vcpu, KVM_GET_CLOCK_GUEST, &pvti_before); + + /* Sleep to let the clocks diverge. */ + sleep(sleep_sec); + break; + + case STAGE_UNCORRECTED: + /* Restore the original pvclock parameters. */ + vcpu_ioctl(vcpu, KVM_SET_CLOCK_GUEST, &pvti_before); + break; + + case STAGE_CORRECTED: + /* Guest verified the delta in-guest. */ + return; + + default: + TEST_FAIL("Unknown stage %lu", uc.args[1]); + } + } +} + +static void configure_pvclock(struct kvm_vm *vm) +{ + unsigned int nr_pages; + + nr_pages = vm_calc_num_guest_pages(VM_MODE_DEFAULT, getpagesize()); + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, + KVMCLOCK_GPA, 1, nr_pages, 0); + virt_map(vm, KVMCLOCK_GPA, KVMCLOCK_GPA, nr_pages); +} + +static void run_at_frequency(uint64_t tsc_khz, unsigned int sleep_sec) +{ + struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + + pr_info("Testing at TSC frequency %lu kHz\n", tsc_khz); + vm = vm_create_with_one_vcpu(&vcpu, guest_code); + configure_pvclock(vm); + vcpu_ioctl(vcpu, KVM_SET_TSC_KHZ, (void *)tsc_khz); + run_test(vm, vcpu, sleep_sec); + kvm_vm_free(vm); +} + +static void test_tsc_stable_bit(void); +static void test_clock_guest_with_offsets(void); + +static void usage(const char *name) +{ + printf("Usage: %s [options]\n" + " -s, --sleep SEC sleep duration between snapshots (default: 2)\n" + " -h, --help show this help\n", name); +} + +int main(int argc, char *argv[]) +{ + static const struct option long_opts[] = { + { "sleep", required_argument, NULL, 's' }, + { "help", no_argument, NULL, 'h' }, + { NULL, 0, NULL, 0 }, + }; + unsigned int sleep_sec = 2; + struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + uint64_t host_khz; + uint64_t freq; + int opt; + + while ((opt = getopt_long(argc, argv, "s:h", long_opts, NULL)) != -1) { + switch (opt) { + case 's': + sleep_sec = atoi(optarg); + break; + case 'h': + default: + usage(argv[0]); + return opt == 'h' ? 0 : 1; + } + } + + TEST_REQUIRE(sys_clocksource_is_based_on_tsc()); + TEST_REQUIRE(kvm_has_cap(KVM_CAP_TSC_CONTROL)); + + vm = vm_create_with_one_vcpu(&vcpu, guest_code); + configure_pvclock(vm); + + /* Check KVM_GET_CLOCK_GUEST is supported */ + { + struct pvclock_vcpu_time_info tmp; + int ret = __vcpu_ioctl(vcpu, KVM_GET_CLOCK_GUEST, &tmp); + TEST_REQUIRE(ret == 0); + } + + /* First run at native frequency (no scaling). */ + run_test(vm, vcpu, sleep_sec); + + /* + * Then enumerate a range of TSC frequencies crossing the 32-bit + * boundary, to exercise the scaling path at various ratios. + */ + host_khz = __vcpu_ioctl(vcpu, KVM_GET_TSC_KHZ, NULL); + kvm_vm_free(vm); + + for (freq = 1000000; freq <= 5000000; freq += 500000) { + if (freq == host_khz) + continue; + run_at_frequency(freq, sleep_sec); + } + + test_tsc_stable_bit(); + test_clock_guest_with_offsets(); + + return 0; +} + +static volatile uint32_t vcpu_counter; +static void guest_code_stable_bit(void) +{ + uint32_t idx = __atomic_fetch_add(&vcpu_counter, 1, __ATOMIC_SEQ_CST); + uint64_t gpa = KVMCLOCK_GPA + idx * sizeof(struct pvclock_vcpu_time_info); + + wrmsr(MSR_KVM_SYSTEM_TIME_NEW, gpa | KVM_MSR_ENABLED); + GUEST_SYNC(0); + GUEST_SYNC(0); + GUEST_SYNC(0); +} + +static void set_tsc_offset(struct kvm_vcpu *vcpu, uint64_t offset) +{ + struct kvm_device_attr attr = { + .group = KVM_VCPU_TSC_CTRL, + .attr = KVM_VCPU_TSC_OFFSET, + .addr = (__u64)(uintptr_t)&offset, + }; + + TEST_REQUIRE(__vcpu_has_device_attr(vcpu, KVM_VCPU_TSC_CTRL, + KVM_VCPU_TSC_OFFSET) == 0); + vcpu_ioctl(vcpu, KVM_SET_DEVICE_ATTR, &attr); +} + +static void run_vcpu_once(struct kvm_vcpu *vcpu) +{ + struct ucall uc; + + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + switch (get_ucall(vcpu, &uc)) { + case UCALL_ABORT: + REPORT_GUEST_ASSERT(uc); + break; + case UCALL_SYNC: + break; + default: + TEST_FAIL("Unexpected ucall"); + } +} + +static void test_tsc_stable_bit(void) +{ + struct pvclock_vcpu_time_info pvti; + struct kvm_vcpu *vcpus[2]; + struct kvm_vm *vm; + int ret; + + pr_info("Testing PVCLOCK_TSC_STABLE_BIT with matched/unmatched TSCs\n"); + + vm = vm_create_with_vcpus(2, guest_code_stable_bit, vcpus); + configure_pvclock(vm); + + /* + * Case 1: All TSCs matched (same frequency and offset). + * Master clock should be active, PVCLOCK_TSC_STABLE_BIT set. + */ + run_vcpu_once(vcpus[0]); + + ret = __vcpu_ioctl(vcpus[0], KVM_GET_CLOCK_GUEST, &pvti); + TEST_ASSERT(!ret, "GET_CLOCK_GUEST should succeed with matched TSCs"); + TEST_ASSERT(pvti.flags & PVCLOCK_TSC_STABLE_BIT, + "PVCLOCK_TSC_STABLE_BIT should be set with matched TSCs"); + + /* + * Case 2: Different TSC offset, same frequency. + * Master clock should still be active (frequency matches), but + * PVCLOCK_TSC_STABLE_BIT should be cleared (offsets differ). + */ + set_tsc_offset(vcpus[1], 12345678); + run_vcpu_once(vcpus[1]); + run_vcpu_once(vcpus[0]); + + ret = __vcpu_ioctl(vcpus[0], KVM_GET_CLOCK_GUEST, &pvti); + if (ret) { + /* Master clock disabled by offset mismatch — old kernel */ + pr_info(" Skipping offset tests (master clock requires matched offsets)\n"); + goto out_stable; + } + TEST_ASSERT(!(pvti.flags & PVCLOCK_TSC_STABLE_BIT), + "PVCLOCK_TSC_STABLE_BIT should be clear with offset-mismatched TSCs"); + + /* + * Case 3: Different TSC frequency. + * Master clock should be disabled entirely. + */ + vcpu_ioctl(vcpus[1], KVM_SET_TSC_KHZ, + (void *)(unsigned long)(__vcpu_ioctl(vcpus[1], KVM_GET_TSC_KHZ, NULL) / 2)); + /* Write TSC to trigger kvm_synchronize_tsc / kvm_track_tsc_matching */ + vcpu_set_msr(vcpus[1], MSR_IA32_TSC, 0); + run_vcpu_once(vcpus[1]); + + ret = __vcpu_ioctl(vcpus[0], KVM_GET_CLOCK_GUEST, &pvti); + TEST_ASSERT(ret && errno == EINVAL, + "GET_CLOCK_GUEST should fail with frequency-mismatched TSCs, got %d (errno %d)", + ret, errno); + +out_stable: + kvm_vm_free(vm); +} + +static void test_clock_guest_with_offsets(void) +{ + struct pvclock_vcpu_time_info pvti0, pvti1, pvti1_after; + struct kvm_vcpu *vcpus[2]; + struct kvm_vm *vm; + int64_t delta; + int ret; + + pr_info("Testing KVM_[GS]ET_CLOCK_GUEST with different TSC offsets\n"); + + vm = vm_create_with_vcpus(2, guest_code_stable_bit, vcpus); + configure_pvclock(vm); + + /* Set different TSC offsets on the two vCPUs */ + set_tsc_offset(vcpus[0], 0); + set_tsc_offset(vcpus[1], 1000000000ull); + + /* Run both to establish kvmclock */ + run_vcpu_once(vcpus[0]); + run_vcpu_once(vcpus[1]); + + /* GET_CLOCK_GUEST on both — should succeed (master clock active) */ + ret = __vcpu_ioctl(vcpus[0], KVM_GET_CLOCK_GUEST, &pvti0); + if (ret) { + pr_info(" Skipping (master clock requires matched offsets on this kernel)\n"); + kvm_vm_free(vm); + return; + } + ret = __vcpu_ioctl(vcpus[1], KVM_GET_CLOCK_GUEST, &pvti1); + TEST_ASSERT(!ret, "GET_CLOCK_GUEST on vcpu1 failed"); + + /* The tsc_timestamps should differ (different offsets) */ + TEST_ASSERT(pvti0.tsc_timestamp != pvti1.tsc_timestamp, + "tsc_timestamps should differ with different offsets"); + + /* Sleep to let time elapse, then restore vcpu0's clock */ + sleep(1); + vcpu_ioctl(vcpus[0], KVM_SET_CLOCK_GUEST, &pvti0); + + /* Run vcpu0 to process the clock update */ + run_vcpu_once(vcpus[0]); + + /* GET_CLOCK_GUEST on vcpu1 — should reflect the correction */ + ret = __vcpu_ioctl(vcpus[1], KVM_GET_CLOCK_GUEST, &pvti1_after); + TEST_ASSERT(!ret, "GET_CLOCK_GUEST on vcpu1 after SET failed"); + + /* + * After SET on vcpu0, verify the correction worked by getting + * the clock on vcpu0 again. The mul/shift should be the same, + * and computing kvmclock at the same TSC should give the same + * result as the original (within ±2ns). + */ + { + struct pvclock_vcpu_time_info pvti0_after; + uint64_t tsc_now, clk_from_old, clk_from_new; + + ret = __vcpu_ioctl(vcpus[0], KVM_GET_CLOCK_GUEST, &pvti0_after); + TEST_ASSERT(!ret, "GET_CLOCK_GUEST on vcpu0 after SET failed"); + + tsc_now = pvti0_after.tsc_timestamp; + clk_from_old = pvclock_read_cycles(&pvti0, tsc_now); + clk_from_new = pvclock_read_cycles(&pvti0_after, tsc_now); + + delta = (int64_t)clk_from_new - (int64_t)clk_from_old; + TEST_ASSERT(delta >= -2 && delta <= 2, + "clock correction delta should be <=2ns, got %ld ns", + delta); + } + + /* + * Also verify that vcpu1's clock is still accessible (master + * clock still active with different offsets). + */ + ret = __vcpu_ioctl(vcpus[1], KVM_GET_CLOCK_GUEST, &pvti1_after); + TEST_ASSERT(!ret, "GET_CLOCK_GUEST on vcpu1 after SET failed"); + + kvm_vm_free(vm); +} -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353763.1609555 (Exim 4.92) (envelope-from ) id 1wflKy-0008BG-9m; Fri, 03 Jul 2026 21:22:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353763.1609555; Fri, 03 Jul 2026 21:22:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKy-0008B2-6D; Fri, 03 Jul 2026 21:22:16 +0000 Received: by outflank-mailman (input) for mailman id 1353763; Fri, 03 Jul 2026 21:22:14 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKw-00081M-88 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKv-00CeeP-LH; Fri, 03 Jul 2026 23:22:13 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827de-bab6-0a2a0a5309dd-0a2a450adcec-24 for ; Fri, 03 Jul 2026 23:22:13 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482805-e40e-0a2a450a0019-5a9b3222ce60-3 for ; Fri, 03 Jul 2026 23:22:13 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYD-0x2z; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPP-0bzt; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=LCPHKocQxei12eLOnimwDSC7Gdxv3emgr2rZMstPsfQ=; b=D+gxe+zOcTheHMuzWnvdCppNWA 57JVykAHl5rRTwt63XLCRD1vkYCu3NQBErzPcDEbuP+MaahyYUw5hq3EwgT7E4w2h7Gg0Ma1b5I9c y+FhSO1tI4GXlHfRW+zlB1kpu6M0vVZhLe9024hdHZX3BeH+AbDSkFNkPcop8uZEzpFkwZZTViDED XNcIi+iHLsu+wlkRd+qUOzLAXeurJLINvTyk2DBnlnB/8mRDQeMAjew2fmG/MNXpKG+17Z+JFWmfB M+I6BAQ6bxpzkaSzDdefvG7Z1bLT2dKVd2DTwpsBwrI0PN2j3OaH1YdS6A6i80wBBLY9y/hrMp1mS kde8DTaQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 24/36] KVM: x86: Factor out kvm_use_master_clock() Date: Fri, 3 Jul 2026 22:18:03 +0100 Message-ID: <20260703212145.343527-25-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1783113733-D6B3CDDE-1712DCFB/0/0 X-purgate-type: clean X-purgate-size: 4292 From: David Woodhouse Both kvm_track_tsc_matching() and pvclock_update_vm_gtod_copy() make a decision about whether the KVM clock should be in master clock mode. They used *different* criteria for the decision though. This isn't really a problem; it only has the potential to cause unnecessary invocations of KVM_REQ_MASTERCLOCK_UPDATE if the masterclock was disabled due to TSC going backwards, or the guest using the old MSR. But it isn't pretty. Factor the decision out to a single function. And document the historical reason why it's disabled for guests that use the old MSR_KVM_SYSTEM_TIME. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/kvm/x86.c | 40 ++++++++++++++++++++++++++++++---------- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 3a651f5ce2d2..f8883c3b8ed2 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2638,11 +2638,30 @@ static inline bool gtod_is_based_on_tsc(int mode) { return mode == VDSO_CLOCKMODE_TSC || mode == VDSO_CLOCKMODE_HVCLOCK; } -#endif + +static bool kvm_use_master_clock(struct kvm *kvm) +{ + struct kvm_arch *ka = &kvm->arch; + + /* + * The 'old kvmclock' check is a workaround (from 2015) for a + * SUSE 2.6.16 kernel that didn't boot if the system_time in + * its kvmclock was too far behind the current time. So the + * mode of just setting the reference point and allowing time + * to proceed linearly from there makes it fail to boot. + * Despite that being kind of the *point* of the way the clock + * is exposed to the guest. By coincidence, the offending + * kernels used the old MSR_KVM_SYSTEM_TIME, which was moved + * only because it resided in the wrong number range. So the + * workaround is activated for *all* guests using the old MSR. + */ + return ka->all_vcpus_matched_freq && + !ka->backwards_tsc_observed && + !ka->boot_vcpu_runs_old_kvmclock; +} static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool update_mclock) { -#ifdef CONFIG_X86_64 struct kvm_arch *ka = &vcpu->kvm->arch; struct pvclock_gtod_data *gtod = &pvclock_gtod_data; bool prev_matched_tsc = ka->all_vcpus_matched_tsc; @@ -2680,7 +2699,7 @@ static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool update_mclock) * are fine — each vCPU's pvclock has its own tsc_timestamp that * accounts for its offset. */ - bool use_master_clock = ka->all_vcpus_matched_freq && + bool use_master_clock = kvm_use_master_clock(vcpu->kvm) && gtod_is_based_on_tsc(gtod->clock.vclock_mode); /* @@ -2695,8 +2714,11 @@ static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool update_mclock) trace_kvm_track_tsc(vcpu->vcpu_id, ka->nr_vcpus_matched_tsc, atomic_read(&vcpu->kvm->online_vcpus), ka->use_master_clock, gtod->clock.vclock_mode); -#endif } +#else +static inline void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, + bool new_generation) {} +#endif /* * Multiply tsc by a fixed point number represented by ratio. @@ -3210,10 +3232,9 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) #ifdef CONFIG_X86_64 struct kvm_arch *ka = &kvm->arch; int vclock_mode; - bool host_tsc_clocksource, vcpus_matched; + bool host_tsc_clocksource; lockdep_assert_held(&kvm->arch.tsc_write_lock); - vcpus_matched = ka->all_vcpus_matched_freq; /* * If the host uses TSC clock, then passthrough TSC as stable @@ -3223,9 +3244,8 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) &ka->master_kernel_ns, &ka->master_cycle_now); - ka->use_master_clock = host_tsc_clocksource && vcpus_matched - && !ka->backwards_tsc_observed - && !ka->boot_vcpu_runs_old_kvmclock; + ka->use_master_clock = host_tsc_clocksource && + kvm_use_master_clock(kvm); if (ka->use_master_clock) { u64 tsc_hz; @@ -3253,7 +3273,7 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) vclock_mode = pvclock_gtod_data.clock.vclock_mode; trace_kvm_update_master_clock(ka->use_master_clock, vclock_mode, - vcpus_matched); + ka->all_vcpus_matched_freq); #endif } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353764.1609559 (Exim 4.92) (envelope-from ) id 1wflKz-0008GA-1Y; Fri, 03 Jul 2026 21:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353764.1609559; Fri, 03 Jul 2026 21:22:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKy-0008EG-Mg; Fri, 03 Jul 2026 21:22:16 +0000 Received: by outflank-mailman (input) for mailman id 1353764; Fri, 03 Jul 2026 21:22:14 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKw-00082A-Ce for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKv-00CeeP-PD; Fri, 03 Jul 2026 23:22:13 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827ca-bab6-0a2a0a5309dd-0a2a4503bf3c-26 for ; Fri, 03 Jul 2026 23:22:13 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482805-ec1a-0a2a45030019-5a9b3222d6fa-3 for ; Fri, 03 Jul 2026 23:22:13 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKW-0000000AsY5-1o7d; Fri, 03 Jul 2026 21:21:48 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROT-1D1r; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=5esTOgHqgTZQG0bhg0+NN2EeUiyx8in1MUEgOdbTb68=; b=i2Ub5UzQieNGYKh00g6PXh3mlj M6QMKQ7kfa6KmzGRvyGWn+y6cTd5d12wteB+OfmlUg/ChloyUDVPBsk+4pnifDfVTcFbQg8XPC6Wx 9w7ufgolgi/BG63pmuYQdHTWGhN65P30JJe53ZSKtWpbYn92SfYCQPWnJpgO1TxJrQffhrc+nwhfT Hf+GYVvn5FM5FeI/rUSwlUKt+kTEK/s1DWnwBVHw4/d0ffwmTdNa7342xixebxJ+gyh5rnT0fAaFH X9l96ijMza3ZqOhdx51JKTtN5H+fAKNBFRSq11Ker17Mu5sqoVCHIho+ILVaPiuiyXPfDunwp82m5 B97pDgTg==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 11/36] KVM: x86: Fold __get_kvmclock() into get_kvmclock() Date: Fri, 3 Jul 2026 22:17:50 +0100 Message-ID: <20260703212145.343527-12-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1783113733-061315D1-03F432AA/0/0 X-purgate-type: clean X-purgate-size: 3279 From: David Woodhouse There is no need for the separate __get_kvmclock() helper; just inline its body into get_kvmclock() within the seqcount retry loop. No functional change. Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 63 +++++++++++++++++++++------------------------- 1 file changed, 28 insertions(+), 35 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 21603feb44c5..50f088570dab 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3200,50 +3200,43 @@ static unsigned long get_cpu_tsc_khz(void) return __this_cpu_read(cpu_tsc_khz); } -/* Called within read_seqcount_begin/retry for kvm->pvclock_sc. */ -static void __get_kvmclock(struct kvm *kvm, struct kvm_clock_data *data) +static void get_kvmclock(struct kvm *kvm, struct kvm_clock_data *data) { struct kvm_arch *ka = &kvm->arch; struct pvclock_vcpu_time_info hv_clock; + unsigned int seq; - /* both __this_cpu_read() and rdtsc() should be on the same cpu */ - get_cpu(); + do { + seq = read_seqcount_begin(&ka->pvclock_sc); - data->flags = 0; - if (ka->use_master_clock && - (static_cpu_has(X86_FEATURE_CONSTANT_TSC) || __this_cpu_read(cpu_tsc_khz))) { + /* both __this_cpu_read() and rdtsc() should be on the same cpu */ + get_cpu(); + + data->flags = 0; + if (ka->use_master_clock && + (static_cpu_has(X86_FEATURE_CONSTANT_TSC) || __this_cpu_read(cpu_tsc_khz))) { #ifdef CONFIG_X86_64 - struct timespec64 ts; + struct timespec64 ts; - if (kvm_get_walltime_and_clockread(&ts, &data->host_tsc)) { - data->realtime = ts.tv_nsec + NSEC_PER_SEC * ts.tv_sec; - data->flags |= KVM_CLOCK_REALTIME | KVM_CLOCK_HOST_TSC; - } else + if (kvm_get_walltime_and_clockread(&ts, &data->host_tsc)) { + data->realtime = ts.tv_nsec + NSEC_PER_SEC * ts.tv_sec; + data->flags |= KVM_CLOCK_REALTIME | KVM_CLOCK_HOST_TSC; + } else #endif - data->host_tsc = rdtsc(); - - data->flags |= KVM_CLOCK_TSC_STABLE; - hv_clock.tsc_timestamp = ka->master_cycle_now; - hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset; - kvm_get_time_scale(NSEC_PER_SEC, get_cpu_tsc_khz() * 1000LL, - &hv_clock.tsc_shift, - &hv_clock.tsc_to_system_mul); - data->clock = __pvclock_read_cycles(&hv_clock, data->host_tsc); - } else { - data->clock = get_kvmclock_base_ns() + ka->kvmclock_offset; - } - - put_cpu(); -} - -static void get_kvmclock(struct kvm *kvm, struct kvm_clock_data *data) -{ - struct kvm_arch *ka = &kvm->arch; - unsigned seq; + data->host_tsc = rdtsc(); + + data->flags |= KVM_CLOCK_TSC_STABLE; + hv_clock.tsc_timestamp = ka->master_cycle_now; + hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset; + kvm_get_time_scale(NSEC_PER_SEC, get_cpu_tsc_khz() * 1000LL, + &hv_clock.tsc_shift, + &hv_clock.tsc_to_system_mul); + data->clock = __pvclock_read_cycles(&hv_clock, data->host_tsc); + } else { + data->clock = get_kvmclock_base_ns() + ka->kvmclock_offset; + } - do { - seq = read_seqcount_begin(&ka->pvclock_sc); - __get_kvmclock(kvm, data); + put_cpu(); } while (read_seqcount_retry(&ka->pvclock_sc, seq)); } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353766.1609565 (Exim 4.92) (envelope-from ) id 1wflKz-0008Pk-M8; Fri, 03 Jul 2026 21:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353766.1609565; Fri, 03 Jul 2026 21:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKz-0008M4-8j; Fri, 03 Jul 2026 21:22:17 +0000 Received: by outflank-mailman (input) for mailman id 1353766; Fri, 03 Jul 2026 21:22:15 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflKx-000876-Gu for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflKw-00A7vt-U1; Fri, 03 Jul 2026 23:22:14 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482804-e002-0a2a0a5209dd-0a2a4506d606-2 for ; Fri, 03 Jul 2026 23:22:14 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482806-08de-0a2a45060019-5a9b3222ce6e-3 for ; Fri, 03 Jul 2026 23:22:14 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKW-0000000AsY2-1TLA; Fri, 03 Jul 2026 21:21:48 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROP-12v9; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=s+7qUlbLcb8dcHIU9yxWWuYHzICS9PPJgOOAoGyBp5o=; b=HPj7neF/edX8jbo/JX8quja682 cEZuozcFmVKIQrBdJlzohG2fuYYQuNFcycqs5FWy96RgLuuCtsgPNENsXWM1BtzCtDYj1EbxULEiz FLnDUQn4MBs3GFp1PKN0NeVRrmqEWCnvYXdjIEPT0PPSKKwX+xlLnZfg37I9KK8Dp8hRsppgYkT8k sJz+4rBN3tgwri8rHwondVAyaMDPbqxGfNKNT1Mf5ShXTpgoE/LlIqlFF0q2ledbnIuzB0Z2Y/oK4 bMTCbCB/sTsOzQyuyvF7zwSQ3/zygcdDmM/tQILbMrqw5OpyejMR+PvuyewpDD3JmZASo2/07mat4 e/rL9FOw==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 10/36] KVM: x86: Avoid NTP frequency skew for KVM clock on 32-bit host Date: Fri, 3 Jul 2026 22:17:49 +0100 Message-ID: <20260703212145.343527-11-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-16d1c6/1783113734-4292368D-96F22E46/0/0 X-purgate-type: clean X-purgate-size: 3670 From: David Woodhouse Commit 53fafdbb8b21 ("KVM: x86: switch KVMCLOCK base to monotonic raw clock") did so only for 64-bit hosts, by capturing the boot offset from within the existing clocksource notifier update_pvclock_gtod(). That notifier was added in commit 16e8d74d2da9 ("KVM: x86: notifier for clocksource changes") but only on x86_64, because its original purpose was just to disable the "master clock" mode which is only supported on x86_64. Now that the notifier is used for more than disabling master clock mode, enable it for the 32-bit build too so that get_kvmclock_base_ns() can be unaffected by NTP sync on 32-bit too. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/kvm/x86.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 26b4649dfb94..21603feb44c5 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2342,7 +2342,6 @@ static int do_set_msr(struct kvm_vcpu *vcpu, unsigned index, u64 *data) return kvm_set_msr_ignored_check(vcpu, index, *data, true); } -#ifdef CONFIG_X86_64 struct pvclock_clock { int vclock_mode; u64 cycle_last; @@ -2400,13 +2399,6 @@ static s64 get_kvmclock_base_ns(void) /* Count up from boot time, but with the frequency of the raw clock. */ return ktime_to_ns(ktime_add(ktime_get_raw(), pvclock_gtod_data.offs_boot)); } -#else -static s64 get_kvmclock_base_ns(void) -{ - /* Master clock not used, so we can just use CLOCK_BOOTTIME. */ - return ktime_get_boottime_ns(); -} -#endif static void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs) { @@ -10184,6 +10176,7 @@ static void pvclock_irq_work_fn(struct irq_work *w) } static DEFINE_IRQ_WORK(pvclock_irq_work, pvclock_irq_work_fn); +#endif /* * Notification about pvclock gtod data update. @@ -10191,26 +10184,26 @@ static DEFINE_IRQ_WORK(pvclock_irq_work, pvclock_irq_work_fn); static int pvclock_gtod_notify(struct notifier_block *nb, unsigned long unused, void *priv) { - struct pvclock_gtod_data *gtod = &pvclock_gtod_data; struct timekeeper *tk = priv; update_pvclock_gtod(tk); +#ifdef CONFIG_X86_64 /* * Disable master clock if host does not trust, or does not use, * TSC based clocksource. Delegate queue_work() to irq_work as * this is invoked with tk_core.seq write held. */ - if (!gtod_is_based_on_tsc(gtod->clock.vclock_mode) && + if (!gtod_is_based_on_tsc(pvclock_gtod_data.clock.vclock_mode) && atomic_read(&kvm_guest_has_master_clock) != 0) irq_work_queue(&pvclock_irq_work); +#endif return 0; } static struct notifier_block pvclock_gtod_notifier = { .notifier_call = pvclock_gtod_notify, }; -#endif void kvm_setup_xss_caps(void) { @@ -10399,9 +10392,9 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops) if (pi_inject_timer == -1) pi_inject_timer = housekeeping_enabled(HK_TYPE_TIMER); -#ifdef CONFIG_X86_64 pvclock_gtod_register_notifier(&pvclock_gtod_notifier); +#ifdef CONFIG_X86_64 if (hypervisor_is_type(X86_HYPER_MS_HYPERV)) set_hv_tscchange_cb(kvm_hyperv_tsc_notifier); #endif @@ -10458,8 +10451,8 @@ void kvm_x86_vendor_exit(void) CPUFREQ_TRANSITION_NOTIFIER); cpuhp_remove_state_nocalls(CPUHP_AP_X86_KVM_CLK_ONLINE); } -#ifdef CONFIG_X86_64 pvclock_gtod_unregister_notifier(&pvclock_gtod_notifier); +#ifdef CONFIG_X86_64 irq_work_sync(&pvclock_irq_work); cancel_work_sync(&pvclock_gtod_work); #endif -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:22:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:22:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353776.1609582 (Exim 4.92) (envelope-from ) id 1wflL6-00013V-0G; Fri, 03 Jul 2026 21:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353776.1609582; Fri, 03 Jul 2026 21:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflL5-00012A-QH; Fri, 03 Jul 2026 21:22:23 +0000 Received: by outflank-mailman (input) for mailman id 1353776; Fri, 03 Jul 2026 21:22:22 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflL4-0000qR-B0 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:22:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflL3-00BXCb-O9; Fri, 03 Jul 2026 23:22:21 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48279b-2eae-0a2a0a5409dd-0a2a45019e62-30 for ; Fri, 03 Jul 2026 23:22:21 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48280d-400f-0a2a45010019-5a9b3222d726-3 for ; Fri, 03 Jul 2026 23:22:21 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wflKX-0000000AsYP-3AaT; Fri, 03 Jul 2026 21:21:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RQ2-2bjR; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=O/oUbS7kYPJiTQjk6lyYh7lx0CQJ2SSehd3aLwyJ2+s=; b=aeZWxhF7AsGk3HBJM42jxJ3/G5 41bAnL10ZxObpBizC6FNpkO2Xhx7SLTdkscJ8MKF5yDV47DW5K+0Rw52xwDwbc1v5Xr6MFbnNaTIv fMmGadiIUz9/bFMDHwx0xHflvuT1vZtuOSFpAKCF3QT2vzA8bXyzcVb4uDPgzNPhaOjGPB/vOO/IA loTUM/AxnKgV+4Vvn7XmBqxGyMwOCoM+b1mH5d8sGRjOgY1ASOuzE7uJuQuuP+lcgT+aChKij4fAP gHIMwiL9H7nnCcslwip0AW7fSsC5uwRS4Eu3HetQtUtYTjnz0/Qt9luFtpmls6AGa86HRk5vBEFwt e062+P2A==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 33/36] KVM: x86: Compute kvmclock base without pvclock_gtod_data Date: Fri, 3 Jul 2026 22:18:12 +0100 Message-ID: <20260703212145.343527-34-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d62444/1783113741-80AD11E0-32343D7B/0/0 X-purgate-type: clean X-purgate-size: 1092 From: David Woodhouse get_kvmclock_base_ns() needs CLOCK_MONOTONIC_RAW + offs_boot. Compute this directly rather than reading offs_boot from the pvclock_gtod_data private copy. offs_boot only changes at suspend/resume so does not need to be atomically paired with the raw clock read. Signed-off-by: David Woodhouse Assisted-by: Kiro:claude-opus-4.6-1m --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 56afd5e66c06..8d520bfae089 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2402,7 +2402,7 @@ static void update_pvclock_gtod(struct timekeeper *tk) static s64 get_kvmclock_base_ns(void) { /* Count up from boot time, but with the frequency of the raw clock. */ - return ktime_to_ns(ktime_add(ktime_get_raw(), pvclock_gtod_data.offs_boot)); + return ktime_to_ns(ktime_mono_to_any(ktime_get_raw(), TK_OFFS_BOOT)); } static void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs) -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353875.1609590 (Exim 4.92) (envelope-from ) id 1wflM6-0004RW-Er; Fri, 03 Jul 2026 21:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353875.1609590; Fri, 03 Jul 2026 21:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflM6-0004RP-Bk; Fri, 03 Jul 2026 21:23:26 +0000 Received: by outflank-mailman (input) for mailman id 1353875; Fri, 03 Jul 2026 21:23:25 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflM4-0004QN-ON for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflM4-00CejO-5F; Fri, 03 Jul 2026 23:23:24 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482835-bab6-0a2a0a5309dd-0a2a45038b46-12 for ; Fri, 03 Jul 2026 23:23:23 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48284a-ec1a-0a2a45030019-5a9b5cc7ce42-3 for ; Fri, 03 Jul 2026 23:23:23 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKY-000000059O6-1xMF; Fri, 03 Jul 2026 21:23:04 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROv-2yUi; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=ydNYanTzV+rXuDAMNzpsQ17TnZayvJkNqhFCKKMsQXQ=; b=oMsIAx+viNMO768Fm1dQ1GGaQK HXvg0RdzbGgsuyU4XEvhoMXSxjNjkwu5TbIxHkRRwfGkDZDe1Z4U8tJ6GLT0QO2ULe44BAftyOTbv aaFsMl9pLEPIW5nhCurlLhDQSFXMAlkIcVYGkGjlWSmASd1UGSg+vCw8weRL+ou3XrY8d/8LuRSbC 8/jZsf0YPkPlj4c1U57Nd8tJI6vJbUxLgJg9kHdwnvj/OHA4wyNNua2tIyY/ICjN9qfYH4GiS+luu QIUIDYxtlqNIQmClLOA15ZhWTJa5IvVzPxSBFxY7cLYtioKEIJgJcJE9Uoy0dATamc19dnoF+0clO wIaVaSdg==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 17/36] KVM: x86: Simplify and comment kvm_get_time_scale() Date: Fri, 3 Jul 2026 22:17:56 +0100 Message-ID: <20260703212145.343527-18-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1783113803-0652F5D1-4893E3B8/0/0 X-purgate-type: clean X-purgate-size: 3197 From: David Woodhouse The kvm_get_time_scale() function was entirely opaque. Add comments explaining what it does: compute a fixed-point multiplier and shift for converting TSC ticks to nanoseconds via pvclock_scale_delta(). Rename the local variables from the cryptic tps64/tps32/scaled64 to base_hz_u64/base32/scaled_hz_u64 to make the code self-documenting. The "tps32" name stood for "Ticks Per Second" but was misleading since it held the shifted base frequency, not a tick count. No functional change. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/kvm/x86.c | 55 +++++++++++++++++++++++++++++++++------------- 1 file changed, 40 insertions(+), 15 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 9dc4213f0fa5..0087ddd08e83 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2472,32 +2472,57 @@ static uint32_t div_frac(uint32_t dividend, uint32_t divisor) return dividend; } -static void kvm_get_time_scale(uint64_t scaled_hz, uint64_t base_hz, +static void kvm_get_time_scale(u64 scaled_hz, u64 base_hz, s8 *pshift, u32 *pmultiplier) { - uint64_t scaled64; - int32_t shift = 0; - uint64_t tps64; - uint32_t tps32; + u64 scaled_hz_u64 = scaled_hz; + s32 shift = 0; + u64 base_hz_u64; + u32 base32; - tps64 = base_hz; - scaled64 = scaled_hz; - while (tps64 > scaled64*2 || tps64 & 0xffffffff00000000ULL) { - tps64 >>= 1; + /* + * This function calculates a fixed-point multiplier and shift such + * that: + * time_ns = (tsc_cycles << shift) * multiplier >> 32 + * + * Where tsc_cycles tick at base_hz, and time_ns should count at + * scaled_hz (typically NSEC_PER_SEC for a TSC→nanoseconds conversion). + * + * The multiplier is: (scaled_hz << 32) / base_hz, adjusted by shift + * to keep everything in range. + */ + + base_hz_u64 = base_hz; + + /* + * Start by shifting base_hz right until it fits in 32 bits, and + * is lower than double the target rate. This introduces a negative + * shift value which would result in pvclock_scale_delta() shifting + * the actual tick count right before performing the multiplication. + */ + while (base_hz_u64 > scaled_hz_u64 * 2 || base_hz_u64 >> 32) { + base_hz_u64 >>= 1; shift--; } - tps32 = (uint32_t)tps64; - while (tps32 <= scaled64 || scaled64 & 0xffffffff00000000ULL) { - if (scaled64 & 0xffffffff00000000ULL || tps32 & 0x80000000) - scaled64 >>= 1; + /* Now the shifted base_hz fits in 32 bits. */ + base32 = (u32)base_hz_u64; + + /* + * Next, shift scaled_hz right until it fits in 32 bits, and ensure + * that the shifted base_hz is strictly larger (so that the result of the + * final division also fits in 32 bits). + */ + while (base32 <= scaled_hz_u64 || scaled_hz_u64 >> 32) { + if (scaled_hz_u64 >> 32 || base32 & BIT(31)) + scaled_hz_u64 >>= 1; else - tps32 <<= 1; + base32 <<= 1; shift++; } *pshift = shift; - *pmultiplier = div_frac(scaled64, tps32); + *pmultiplier = div_frac(scaled_hz_u64, base32); } #ifdef CONFIG_X86_64 -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353876.1609596 (Exim 4.92) (envelope-from ) id 1wflM6-0004Ul-Py; Fri, 03 Jul 2026 21:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353876.1609596; Fri, 03 Jul 2026 21:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflM6-0004UL-K2; Fri, 03 Jul 2026 21:23:26 +0000 Received: by outflank-mailman (input) for mailman id 1353876; Fri, 03 Jul 2026 21:23:25 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflM4-0004QI-El for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflM3-00BXKf-Rt; Fri, 03 Jul 2026 23:23:23 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827dc-2eae-0a2a0a5409dd-0a2a4509cd18-38 for ; Fri, 03 Jul 2026 23:23:23 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48284a-97e6-0a2a45090019-5a9b5cc7a69c-3 for ; Fri, 03 Jul 2026 23:23:23 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKe-000000059OD-0yjS; Fri, 03 Jul 2026 21:22:53 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPs-2B0E; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=MSS/L0DlzIiHi7Bw2B047mUTxdF1yD6n9Esd4lrjANw=; b=iU6SK+6HlatYeQ2gl9tGwyLkqi sAlSNaCj1PI5JPhBJmRbg/ZFhceYepOCKk0FhLL4jYcu0Ca1VR2EtHfZyR4QbM6Nkewx7oXq5ElzM SEIB8TwnLNxYKX69h8tecrdlNIfS4rDY4Bwhm5882oYca8mbjNYb3jUkg7/HSWCpmyYBUBFyQOOi3 tcR/CDUHlwPBWqbHVVgaWWgQRlA6+jwPo9gNJ9sC8Gj+x8HkO25EeY7RimOfYveAQMCdQmD5iWBYI UP7CHZJJi5EKQaHg39iDBGsOfy3hGBLeHuhNl9ZJkgXvFeo9mpsYJEgU9DxfO7FEEbwn5yRsKKDgf yzRGECYw==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 31/36] KVM: selftests: Add Xen runstate migration test Date: Fri, 3 Jul 2026 22:18:10 +0100 Message-ID: <20260703212145.343527-32-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-bad1c0/1783113803-47731986-BAA3D1A4/0/0 X-purgate-type: clean X-purgate-size: 8510 From: David Woodhouse Test that Xen runstate (steal time) is correctly accounted across a simulated live migration using KVM_XEN_VCPU_ATTR and KVM_[GS]ET_CLOCK_GUEST. The test simulates what a real VMM does during migration: 1. Creates a VM with Xen HVM config and runstate tracking 2. Runs the guest to accumulate some kvmclock time 3. Saves clock (KVM_GET_CLOCK_GUEST), TSC offset, and runstate 4. Marks the saved state as RUNSTATE_runnable (vCPU not running) 5. Destroys the source VM 6. Sleeps 10ms (simulating migration network transfer time) 7. Creates a new VM and restores all state precisely as saved 8. Runs the guest and verifies the migration gap appears as steal The kernel accounts the gap because: on vcpu_load, it transitions from RUNSTATE_runnable to RUNSTATE_running, computing delta = kvmclock_now - state_entry_time. Since kvmclock has advanced past the saved entry time (real time elapsed during migration), the delta is added to time_runnable. Signed-off-by: David Woodhouse --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../selftests/kvm/x86/xen_migration_test.c | 194 ++++++++++++++++++ 2 files changed, 195 insertions(+) create mode 100644 tools/testing/selftests/kvm/x86/xen_migration_test.c diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 58aac2980cdf..f155683bd7f8 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -142,6 +142,7 @@ TEST_GEN_PROGS_x86 += x86/debug_regs TEST_GEN_PROGS_x86 += x86/tsc_msrs_test TEST_GEN_PROGS_x86 += x86/vmx_pmu_caps_test TEST_GEN_PROGS_x86 += x86/xen_cpuid_timing_test +TEST_GEN_PROGS_x86 += x86/xen_migration_test TEST_GEN_PROGS_x86 += x86/xen_shinfo_test TEST_GEN_PROGS_x86 += x86/xen_vmcall_test TEST_GEN_PROGS_x86 += x86/sev_init2_tests diff --git a/tools/testing/selftests/kvm/x86/xen_migration_test.c b/tools/testing/selftests/kvm/x86/xen_migration_test.c new file mode 100644 index 000000000000..4a041d36f1b9 --- /dev/null +++ b/tools/testing/selftests/kvm/x86/xen_migration_test.c @@ -0,0 +1,194 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Test Xen runstate (steal time) preservation across simulated migration. + * + * Verifies that the kernel correctly accounts the migration gap as + * steal time (runnable) when runstate data is saved and restored + * precisely, but real time elapses during the migration. + * + * The key insight: userspace saves the runstate with state=RUNSTATE_runnable + * (the vCPU is not running during migration). On restore, the kernel sees + * that kvmclock has advanced past state_entry_time, and accounts the + * difference as time spent in the runnable state. + */ +#include +#include +#include +#include +#include + +#include "test_util.h" +#include "kvm_util.h" +#include "processor.h" + +#include + +#define SHINFO_GPA 0xc0000000ULL +#define RUNSTATE_GPA (SHINFO_GPA + 0x1000) + +#define RUNSTATE_running 0 +#define RUNSTATE_runnable 1 +#define RUNSTATE_blocked 2 +#define RUNSTATE_offline 3 + +struct vcpu_runstate_info { + uint32_t state; + uint64_t state_entry_time; + uint64_t time[4]; +} __attribute__((packed)); + +static void guest_code(void) +{ + volatile struct vcpu_runstate_info *rs = + (void *)(unsigned long)RUNSTATE_GPA; + + /* Report runstate times — no need to enable kvmclock MSR, + * the kernel writes runstate using its internal kvmclock. */ + GUEST_SYNC_ARGS(0, rs->time[RUNSTATE_runnable], + rs->time[RUNSTATE_running], 0, 0); +} + +static struct kvm_vm *create_xen_vm(struct kvm_vcpu **vcpu) +{ + struct kvm_vm *vm; + int xen_caps; + + vm = vm_create_with_one_vcpu(vcpu, guest_code); + + xen_caps = kvm_check_cap(KVM_CAP_XEN_HVM); + TEST_REQUIRE(xen_caps & KVM_XEN_HVM_CONFIG_SHARED_INFO); + TEST_REQUIRE(xen_caps & KVM_XEN_HVM_CONFIG_RUNSTATE); + + /* Map pages */ + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, + SHINFO_GPA, 1, 2, 0); + virt_map(vm, SHINFO_GPA, SHINFO_GPA, 2); + + /* Enable Xen HVM with MSR interception (enables runstate tracking) */ + struct kvm_xen_hvm_config cfg = { + .flags = KVM_XEN_HVM_CONFIG_INTERCEPT_HCALL, + .msr = 0x40000000, + }; + vm_ioctl(vm, KVM_XEN_HVM_CONFIG, &cfg); + + /* Set shared_info */ + struct kvm_xen_hvm_attr ha = { + .type = KVM_XEN_ATTR_TYPE_SHARED_INFO, + .u.shared_info.gfn = SHINFO_GPA >> 12, + }; + vm_ioctl(vm, KVM_XEN_HVM_SET_ATTR, &ha); + + /* Set runstate address */ + struct kvm_xen_vcpu_attr rs_addr = { + .type = KVM_XEN_VCPU_ATTR_TYPE_RUNSTATE_ADDR, + .u.gpa = RUNSTATE_GPA, + }; + vcpu_ioctl(*vcpu, KVM_XEN_VCPU_SET_ATTR, &rs_addr); + + return vm; +} + +int main(void) +{ + struct pvclock_vcpu_time_info pvti; + struct kvm_xen_vcpu_attr runstate_save; + struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + struct ucall uc; + uint64_t tsc_offset; + int ret; + + /* === SOURCE SIDE === */ + pr_info("=== Source: create VM and run guest ===\n"); + vm = create_xen_vm(&vcpu); + + /* Run guest once to accumulate some runstate time */ + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + TEST_ASSERT_EQ(get_ucall(vcpu, &uc), UCALL_SYNC); + + pr_info(" Guest sees: runnable=%" PRIu64 " running=%" PRIu64 "\n", + uc.args[2], uc.args[3]); + + /* Save clock state */ + ret = __vcpu_ioctl(vcpu, KVM_GET_CLOCK_GUEST, &pvti); + TEST_ASSERT(!ret, "KVM_GET_CLOCK_GUEST failed"); + + /* Save TSC offset */ + tsc_offset = vcpu_get_msr(vcpu, MSR_IA32_TSC_ADJUST); + + /* Save runstate — the vCPU is now "runnable" (not running) */ + runstate_save.type = KVM_XEN_VCPU_ATTR_TYPE_RUNSTATE_DATA; + vcpu_ioctl(vcpu, KVM_XEN_VCPU_GET_ATTR, &runstate_save); + + /* + * Transition to runnable state before saving — the vCPU is + * not running during migration. + */ + runstate_save.u.runstate.state = RUNSTATE_runnable; + + pr_info(" Saved runstate: running=%" PRIu64 " runnable=%" PRIu64 + " entry=%" PRIu64 "\n", + (uint64_t)runstate_save.u.runstate.time_running, + (uint64_t)runstate_save.u.runstate.time_runnable, + (uint64_t)runstate_save.u.runstate.state_entry_time); + + uint64_t saved_runnable = runstate_save.u.runstate.time_runnable; + + kvm_vm_free(vm); + + /* === MIGRATION GAP === */ + pr_info("=== Simulating migration (sleeping 10ms) ===\n"); + usleep(10000); + + /* === DESTINATION SIDE === */ + pr_info("=== Destination: create new VM and restore ===\n"); + vm = create_xen_vm(&vcpu); + + /* Restore TSC offset */ + vcpu_set_msr(vcpu, MSR_IA32_TSC_ADJUST, tsc_offset); + + /* Restore clock — kvmclock will now be ~10ms ahead of the snapshot */ + vcpu_ioctl(vcpu, KVM_SET_CLOCK_GUEST, &pvti); + + /* Restore runstate exactly as saved (state=runnable) */ + runstate_save.type = KVM_XEN_VCPU_ATTR_TYPE_RUNSTATE_DATA; + ret = __vcpu_ioctl(vcpu, KVM_XEN_VCPU_SET_ATTR, &runstate_save); + TEST_ASSERT(!ret, "Restore runstate failed: errno %d", errno); + + /* + * Run the guest. When the vCPU enters vcpu_run, the kernel + * transitions from RUNSTATE_runnable to RUNSTATE_running. + * It computes: delta = kvmclock_now - state_entry_time + * This delta (which includes the migration gap) is added to + * time_runnable (steal time). + */ + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + TEST_ASSERT_EQ(get_ucall(vcpu, &uc), UCALL_SYNC); + + uint64_t guest_runnable = uc.args[2]; + uint64_t guest_running = uc.args[3]; + + pr_info(" Guest sees: runnable=%" PRIu64 " running=%" PRIu64 "\n", + guest_runnable, guest_running); + + uint64_t steal_increase = guest_runnable - saved_runnable; + pr_info(" Steal time increase: %" PRIu64 " ns (migration gap)\n", + steal_increase); + + /* + * The steal time increase should be at least 10ms (the sleep) + * but not more than 5s (allowing for VM creation overhead). + * The actual gap is from the source's state_entry_time to the + * destination's kvmclock "now" at vcpu_load time. + */ + TEST_ASSERT(steal_increase >= 10000000ULL && + steal_increase < 5000000000ULL, + "Steal time increase %" PRIu64 " ns not in expected range " + "[10ms, 5s]", steal_increase); + + kvm_vm_free(vm); + pr_info("PASS: Migration gap correctly accounted as steal time\n"); + return 0; +} -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353877.1609609 (Exim 4.92) (envelope-from ) id 1wflMA-0004wX-VH; Fri, 03 Jul 2026 21:23:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353877.1609609; Fri, 03 Jul 2026 21:23:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMA-0004wM-Rv; Fri, 03 Jul 2026 21:23:30 +0000 Received: by outflank-mailman (input) for mailman id 1353877; Fri, 03 Jul 2026 21:23:29 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflM9-0004uV-E8 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflM8-00BXKf-RK; Fri, 03 Jul 2026 23:23:28 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482832-2eae-0a2a0a5409dd-0a2a450b92fe-22 for ; Fri, 03 Jul 2026 23:23:28 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482850-ac48-0a2a450b0019-5a9b5cc7b0d2-3 for ; Fri, 03 Jul 2026 23:23:28 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKY-000000059O0-1xLJ; Fri, 03 Jul 2026 21:22:53 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROY-1YDI; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=tXL7aPo/yAWhlGILCeEnNw76Lh3seTcvuCYSfmK7zhI=; b=LK2l6nQjgd7DLaXcp7LIMUlNxA epcMuonePcQII23FEgetXgqFD+AaZXALFS9ajZIDA0hOhsfpISgZHAO8WzmAlWco0rLd/8BVw/en/ jU+YYEMLC4dz5fOSsczVKgQ5CxhKFAMTcfj/NRJEX6CND9xVsdtvLUQfOoACz0uz+cc3LS3pPW2In TTff6EzdA3x8+ljSoDSNP7+bzp9Xyl6SHQtIw/3pX7snHqV6H52FeGGVgfEkScDfUMCZeqkL+myG/ 88kadjllLlyrTpys0ZML5ORFoQ4EuiwHCVQpvfEWOALEIblsTSGQ1eFvv0cZpOrGRfIFSE/87cT82 lURSRZaA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 12/36] KVM: x86: Restructure get_kvmclock() Date: Fri, 3 Jul 2026 22:17:51 +0100 Message-ID: <20260703212145.343527-13-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-42698a/1783113808-3AB38220-0F7362C9/0/0 X-purgate-type: clean X-purgate-size: 3563 From: David Woodhouse Simplify the use_master_clock condition: the open-coded CONSTANT_TSC || cpu_tsc_khz check is unnecessary since use_master_clock can only be true when the host clocksource is TSC based, which in turn requires a stable, constant and synchronised TSC across all CPUs. Given that, the get_cpu()/put_cpu() pinning is not needed either: both the TSC read and get_cpu_tsc_khz() are CPU-independent when the master clock is in use, so drop them. Wrap the entire use_master_clock block in #ifdef CONFIG_X86_64, since use_master_clock is never true on 32-bit (host_tsc_clocksource is only set under CONFIG_X86_64), and declare hv_clock inside the block so it is not left as an unused variable on 32-bit. Use 'continue' on the master-clock success path so the non-master-clock computation becomes the common tail, avoiding a goto and label. When the clock read fails (e.g. clocksource transitioning away from TSC), fall back to that path rather than proceeding with uninitialised data or spinning in the seqcount loop. Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 42 ++++++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 50f088570dab..37b1f8192842 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3203,40 +3203,38 @@ static unsigned long get_cpu_tsc_khz(void) static void get_kvmclock(struct kvm *kvm, struct kvm_clock_data *data) { struct kvm_arch *ka = &kvm->arch; - struct pvclock_vcpu_time_info hv_clock; unsigned int seq; do { seq = read_seqcount_begin(&ka->pvclock_sc); - /* both __this_cpu_read() and rdtsc() should be on the same cpu */ - get_cpu(); - data->flags = 0; - if (ka->use_master_clock && - (static_cpu_has(X86_FEATURE_CONSTANT_TSC) || __this_cpu_read(cpu_tsc_khz))) { #ifdef CONFIG_X86_64 + if (ka->use_master_clock) { + struct pvclock_vcpu_time_info hv_clock; struct timespec64 ts; if (kvm_get_walltime_and_clockread(&ts, &data->host_tsc)) { data->realtime = ts.tv_nsec + NSEC_PER_SEC * ts.tv_sec; - data->flags |= KVM_CLOCK_REALTIME | KVM_CLOCK_HOST_TSC; - } else -#endif - data->host_tsc = rdtsc(); - - data->flags |= KVM_CLOCK_TSC_STABLE; - hv_clock.tsc_timestamp = ka->master_cycle_now; - hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset; - kvm_get_time_scale(NSEC_PER_SEC, get_cpu_tsc_khz() * 1000LL, - &hv_clock.tsc_shift, - &hv_clock.tsc_to_system_mul); - data->clock = __pvclock_read_cycles(&hv_clock, data->host_tsc); - } else { - data->clock = get_kvmclock_base_ns() + ka->kvmclock_offset; - } + data->flags |= KVM_CLOCK_REALTIME | KVM_CLOCK_HOST_TSC | KVM_CLOCK_TSC_STABLE; + + hv_clock.tsc_timestamp = ka->master_cycle_now; + hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset; + kvm_get_time_scale(NSEC_PER_SEC, get_cpu_tsc_khz() * 1000LL, + &hv_clock.tsc_shift, + &hv_clock.tsc_to_system_mul); + data->clock = __pvclock_read_cycles(&hv_clock, data->host_tsc); + continue; + } - put_cpu(); + /* + * Clock read failed (e.g. clocksource is transitioning + * away from TSC). Fall back to the non-master-clock path + * rather than spinning. + */ + } +#endif + data->clock = get_kvmclock_base_ns() + ka->kvmclock_offset; } while (read_seqcount_retry(&ka->pvclock_sc, seq)); } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353878.1609618 (Exim 4.92) (envelope-from ) id 1wflMD-0005DE-6U; Fri, 03 Jul 2026 21:23:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353878.1609618; Fri, 03 Jul 2026 21:23:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMD-0005D0-2w; Fri, 03 Jul 2026 21:23:33 +0000 Received: by outflank-mailman (input) for mailman id 1353878; Fri, 03 Jul 2026 21:23:31 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMB-00052w-Ee for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMA-00BElj-Rp; Fri, 03 Jul 2026 23:23:30 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48282a-5cb7-0a2a0a5109dd-0a2a450aa8e8-10 for ; Fri, 03 Jul 2026 23:23:30 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48284f-e40e-0a2a450a0019-5a9b5cc7a18a-3 for ; Fri, 03 Jul 2026 23:23:27 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKe-000000059OE-0v6i; Fri, 03 Jul 2026 21:22:53 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPx-2LRG; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=1OUv5CdFlAHAtCyTuuEwus8cGCX4Zb6KK8eBdOb5xl8=; b=iAY6MPfXrlFmZymwYSi+vVUVlO Foj75r55Pg0RY2rE1G43N+8fD9XfvQ9wvrkZ6IQFehekLM47aqnS2WyUEiaEq45e/K3+QqpL883g2 oxc0gIJzsIQslagkNwURfAqdrJBtEiZF1ADO/kBfNTsCiCu2whVOx6OV+YtpWXnWiJjHf/km1xwi8 BjZeLG8R28itKIdJU2ORDJdGL/twrFkXyZF4cfcv/Ls01m6xV3PS2mcL+rBFHVol6Gi9uDe/rCWHY weB/t2G31ola0QBkAmIxp7fDT6IzQ5OkKGjhGdZVLn5cAiSUfsWQGKBUU3K3pD2jWVTS4EmGKfQAR jmWut/Bw==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 32/36] KVM: x86: Use ktime_get_snapshot_id() for master clock Date: Fri, 3 Jul 2026 22:18:11 +0100 Message-ID: <20260703212145.343527-33-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1783113807-CF537DDE-DC71D870/0/0 X-purgate-type: clean X-purgate-size: 3954 From: David Woodhouse Replace the KVM-private vgettsc()/do_kvmclock_base()/do_monotonic()/ do_realtime() timekeeping reimplementation with calls to the generic ktime_get_snapshot_id() interface. The snapshot provides both the system time and the raw_cycles (TSC) atomically paired. When raw_cycles is zero, the clocksource could not provide a raw hardware counter value, which is equivalent to the previous vgettsc() returning VDSO_CLOCKMODE_NONE. For kvm_get_time_and_clockread(), the kvmclock base time is CLOCK_MONOTONIC_RAW + offs_boot. The snapshot provides the raw time atomically paired with the TSC; offs_boot is added separately as it only changes at suspend/resume boundaries. This is a step towards eliminating the pvclock_gtod_data private copy of timekeeping state and the associated notifier callback. Signed-off-by: David Woodhouse Assisted-by: Kiro:claude-opus-4.6-1m --- arch/x86/kvm/x86.c | 53 ++++++++++++++++++++++++++++++++++++---------- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 37a768b2fe16..56afd5e66c06 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -35,6 +35,7 @@ #include "smm.h" #include +#include #include #include #include @@ -3154,14 +3155,39 @@ static int do_realtime(struct timespec64 *ts, u64 *tsc_timestamp) * reports the TSC value from which it do so. Returns true if host is * using TSC based clocksource. */ +static bool kvm_snapshot_has_tsc(struct system_time_snapshot *snap, + u64 *tsc_timestamp) +{ + /* + * ktime_get_snapshot_id() cannot fail for standard clock IDs + * (only for invalid/aux clocks or during suspend, with a WARN). + */ + if (!snap->valid) + return false; + + if (snap->cs_id == CSID_X86_TSC) { + *tsc_timestamp = snap->cycles; + return true; + } + + if (snap->hw_csid == CSID_X86_TSC && snap->hw_cycles) { + *tsc_timestamp = snap->hw_cycles; + return true; + } + + return false; +} + static bool kvm_get_time_and_clockread(s64 *kernel_ns, u64 *tsc_timestamp) { - /* checked again under seqlock below */ - if (!gtod_is_based_on_tsc(pvclock_gtod_data.clock.vclock_mode)) + struct system_time_snapshot snap = {}; + + ktime_get_snapshot_id(CLOCK_MONOTONIC_RAW, &snap); + if (!kvm_snapshot_has_tsc(&snap, tsc_timestamp)) return false; - return gtod_is_based_on_tsc(do_kvmclock_base(kernel_ns, - tsc_timestamp)); + *kernel_ns = ktime_to_ns(ktime_mono_to_any(snap.systime, TK_OFFS_BOOT)); + return true; } /* @@ -3170,12 +3196,14 @@ static bool kvm_get_time_and_clockread(s64 *kernel_ns, u64 *tsc_timestamp) */ bool kvm_get_monotonic_and_clockread(s64 *kernel_ns, u64 *tsc_timestamp) { - /* checked again under seqlock below */ - if (!gtod_is_based_on_tsc(pvclock_gtod_data.clock.vclock_mode)) + struct system_time_snapshot snap = {}; + + ktime_get_snapshot_id(CLOCK_MONOTONIC, &snap); + if (!kvm_snapshot_has_tsc(&snap, tsc_timestamp)) return false; - return gtod_is_based_on_tsc(do_monotonic(kernel_ns, - tsc_timestamp)); + *kernel_ns = ktime_to_ns(snap.systime); + return true; } /* @@ -3188,11 +3216,14 @@ bool kvm_get_monotonic_and_clockread(s64 *kernel_ns, u64 *tsc_timestamp) static bool kvm_get_walltime_and_clockread(struct timespec64 *ts, u64 *tsc_timestamp) { - /* checked again under seqlock below */ - if (!gtod_is_based_on_tsc(pvclock_gtod_data.clock.vclock_mode)) + struct system_time_snapshot snap = {}; + + ktime_get_snapshot_id(CLOCK_REALTIME, &snap); + if (!kvm_snapshot_has_tsc(&snap, tsc_timestamp)) return false; - return gtod_is_based_on_tsc(do_realtime(ts, tsc_timestamp)); + *ts = ktime_to_timespec64(snap.systime); + return true; } #endif -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353882.1609627 (Exim 4.92) (envelope-from ) id 1wflMM-0005h2-Lm; Fri, 03 Jul 2026 21:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353882.1609627; Fri, 03 Jul 2026 21:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMM-0005gl-IC; Fri, 03 Jul 2026 21:23:42 +0000 Received: by outflank-mailman (input) for mailman id 1353882; Fri, 03 Jul 2026 21:23:41 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflML-0005et-F3 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMK-001XO6-S9; Fri, 03 Jul 2026 23:23:40 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48282a-5cb7-0a2a0a5109dd-0a2a450aa8e8-22 for ; Fri, 03 Jul 2026 23:23:40 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48285c-e40e-0a2a450a0019-5a9b5cc7db7c-3 for ; Fri, 03 Jul 2026 23:23:40 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059O1-3OLf; Fri, 03 Jul 2026 21:23:26 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROd-1uel; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=GJgji+5kC3YzYVHStlFYRgwhsr0ZfLQx7Fpf6sFlDAA=; b=aNaMFKhduCWNdatfzzJJHFUyeo Rv0SPwZDALsXDKwMgu8TapnCKqex3QPVj6TX+zcg6JTU+v1auSQB/Dm++Fne6Kd6/Xsd1WpTAh66p +Jw+sbONjIBR0Ucx+tpPYaoTJ+irYWQyCueZjPBZL8ujVdf7l3w9ZfCHuqaOz3JKseBAeiAyDV+7D ZHZ8RHyxNJF0eyEn2u16sn8ppCB0vLGNANDCMEtR4E8moNuG3lTnO3T0FdJSxQh+iIg5dUgiofp4Q WdYXyTAa47+JwSUPFmx+SeUirPzgv2aPbC8gxMNw396yX7a6sSd6/7iF/f4W8/EB9/3wPty5xPA5/ oJ+JIJWg==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 13/36] KVM: x86: Fix KVM clock precision in get_kvmclock() with TSC scaling Date: Fri, 3 Jul 2026 22:17:52 +0100 Message-ID: <20260703212145.343527-14-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1783113820-3D275DDE-6998DC17/0/0 X-purgate-type: clean X-purgate-size: 4620 From: David Woodhouse When in master clock mode, the KVM clock is defined in terms of the guest TSC. But get_kvmclock() was computing it from the host TSC without applying TSC scaling, leading to a systemic drift from the values the guest computes from its own TSC. Store the VM's TSC scaling ratio in kvm_arch and precompute the guest-TSC-based mul/shift in pvclock_update_vm_gtod_copy(). Use these in get_kvmclock() to scale the host TSC delta to guest TSC before converting to nanoseconds. This avoids "definition C" of the KVM clock described in the earlier commit "KVM: x86/xen: Do not corrupt KVM clock in kvm_xen_shared_info_init()". Signed-off-by: David Woodhouse --- arch/x86/include/asm/kvm_host.h | 4 +++ arch/x86/kvm/x86.c | 52 +++++++++++++++++++++++++++++---- 2 files changed, 51 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index b2446c04a076..87435ddecde1 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1490,6 +1490,7 @@ struct kvm_arch { u64 last_tsc_write; u32 last_tsc_khz; u64 last_tsc_offset; + u64 last_tsc_scaling_ratio; u64 cur_tsc_nsec; u64 cur_tsc_write; u64 cur_tsc_offset; @@ -1505,6 +1506,9 @@ struct kvm_arch { u64 master_kernel_ns; u64 master_cycle_now; struct ratelimit_state kvmclock_update_rs; + u64 master_tsc_scaling_ratio; + s8 master_tsc_shift; + u32 master_tsc_mul; #ifdef CONFIG_KVM_HYPERV struct kvm_hv hyperv; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 37b1f8192842..65aa0fb0b5e1 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2781,6 +2781,7 @@ static void __kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 offset, u64 tsc, kvm->arch.last_tsc_write = tsc; kvm->arch.last_tsc_khz = vcpu->arch.virtual_tsc_khz; kvm->arch.last_tsc_offset = offset; + kvm->arch.last_tsc_scaling_ratio = vcpu->arch.l1_tsc_scaling_ratio; vcpu->arch.last_guest_tsc = tsc; @@ -3109,6 +3110,8 @@ static bool kvm_get_walltime_and_clockread(struct timespec64 *ts, * */ +static unsigned long get_cpu_tsc_khz(void); + static void pvclock_update_vm_gtod_copy(struct kvm *kvm) { #ifdef CONFIG_X86_64 @@ -3132,9 +3135,30 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) && !ka->backwards_tsc_observed && !ka->boot_vcpu_runs_old_kvmclock; - if (ka->use_master_clock) + if (ka->use_master_clock) { + u64 tsc_hz; + atomic_set(&kvm_guest_has_master_clock, 1); + /* + * Copy the scaling ratio and precompute the mul/shift for + * converting guest TSC to nanoseconds. These are used by + * get_kvmclock() to compute kvmclock from the host TSC + * without needing a vCPU reference. + */ + ka->master_tsc_scaling_ratio = ka->last_tsc_scaling_ratio; + tsc_hz = (u64)get_cpu_tsc_khz() * 1000; + if (tsc_hz && kvm_caps.has_tsc_control) + tsc_hz = kvm_scale_tsc(tsc_hz, + ka->master_tsc_scaling_ratio); + if (tsc_hz) + kvm_get_time_scale(NSEC_PER_SEC, tsc_hz, + &ka->master_tsc_shift, + &ka->master_tsc_mul); + else + ka->use_master_clock = false; + } + vclock_mode = pvclock_gtod_data.clock.vclock_mode; trace_kvm_update_master_clock(ka->use_master_clock, vclock_mode, vcpus_matched); @@ -3220,10 +3244,28 @@ static void get_kvmclock(struct kvm *kvm, struct kvm_clock_data *data) hv_clock.tsc_timestamp = ka->master_cycle_now; hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset; - kvm_get_time_scale(NSEC_PER_SEC, get_cpu_tsc_khz() * 1000LL, - &hv_clock.tsc_shift, - &hv_clock.tsc_to_system_mul); - data->clock = __pvclock_read_cycles(&hv_clock, data->host_tsc); + + /* + * Use the precomputed guest-TSC-based mul/shift + * so that the kvmclock value matches what the + * guest computes from its own TSC. + */ + hv_clock.tsc_shift = ka->master_tsc_shift; + hv_clock.tsc_to_system_mul = ka->master_tsc_mul; + + if (kvm_caps.has_tsc_control) { + u64 tsc_delta = data->host_tsc - ka->master_cycle_now; + + tsc_delta = kvm_scale_tsc(tsc_delta, + ka->master_tsc_scaling_ratio); + data->clock = hv_clock.system_time + + pvclock_scale_delta(tsc_delta, + hv_clock.tsc_to_system_mul, + hv_clock.tsc_shift); + } else { + data->clock = __pvclock_read_cycles(&hv_clock, + data->host_tsc); + } continue; } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353883.1609632 (Exim 4.92) (envelope-from ) id 1wflMM-0005kO-Un; Fri, 03 Jul 2026 21:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353883.1609632; Fri, 03 Jul 2026 21:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMM-0005jN-PI; Fri, 03 Jul 2026 21:23:42 +0000 Received: by outflank-mailman (input) for mailman id 1353883; Fri, 03 Jul 2026 21:23:42 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMM-0005fl-0s for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflML-00A83n-Dv; Fri, 03 Jul 2026 23:23:41 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482855-e002-0a2a0a5209dd-0a2a450295e8-8 for ; Fri, 03 Jul 2026 23:23:41 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48285c-5a27-0a2a45020019-5a9b5cc7c936-3 for ; Fri, 03 Jul 2026 23:23:41 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKc-000000059O2-31Bq; Fri, 03 Jul 2026 21:23:04 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROh-26Xn; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=B9z9WHPmvLHevYFOtmsj0qG2r63h9YkhzzxvRZTeAmQ=; b=onaWDNN2jSP0Q3PZPJs7nogpsV djN5zQDEAAEwp07PHEgjWunIEq3y03q0c8S7zV2OcMlYhl/J34JEKZ7hDMXXyEtTrI/81rwJ8Q8gM QFTPzOTXCK8UXssjTS9zoGTX9rQa4JMpnl9rJ36ID3INFYr2lBLrrofRd04iiPjaseA5YUq4XVSN+ P9NXmp10mCYVX7lINntbmHveElZKC1lFoVpWLbMkv65zJAIwkRzxBWGO+p0yyYJDfQF/6Kweqcw6j YMLtCZsL3NEMhJ26U9Dc5d2d7RIA/mGXd6lQ4sqAxNmH6Bvcz9akyjmHc63sIuT7ieyCDZ6azwkhU pCaM9FxA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 14/36] KVM: x86: Use get_kvmclock() in kvm_get_wall_clock_epoch() Date: Fri, 3 Jul 2026 22:17:53 +0100 Message-ID: <20260703212145.343527-15-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-720697/1783113821-7751C7C5-1868F5BF/0/0 X-purgate-type: clean X-purgate-size: 3112 From: David Woodhouse Now that get_kvmclock() correctly handles TSC scaling and captures both wallclock and kvmclock from the same TSC reading, kvm_get_wall_clock_epoch() can simply call it instead of duplicating the pvclock computation. This eliminates the last instance of the "definition C" kvmclock calculation that computed nanoseconds directly from the host TSC without accounting for guest TSC scaling. Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 59 +++++++--------------------------------------- 1 file changed, 9 insertions(+), 50 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 65aa0fb0b5e1..376b8dc2ade9 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3480,63 +3480,22 @@ int kvm_guest_time_update(struct kvm_vcpu *v) * wallclock and kvmclock times, and subtracting one from the other. * * Fall back to using their values at slightly different moments by - * calling ktime_get_real_ns() and get_kvmclock_ns() separately. + * calling ktime_get_real_ns() and get_kvmclock() separately. */ uint64_t kvm_get_wall_clock_epoch(struct kvm *kvm) { -#ifdef CONFIG_X86_64 - struct pvclock_vcpu_time_info hv_clock; - struct kvm_arch *ka = &kvm->arch; - unsigned long seq, local_tsc_khz; - struct timespec64 ts; - uint64_t host_tsc; - - do { - seq = read_seqcount_begin(&ka->pvclock_sc); - - local_tsc_khz = 0; - if (!ka->use_master_clock) - break; - - /* - * The TSC read and the call to get_cpu_tsc_khz() must happen - * on the same CPU. - */ - get_cpu(); - - local_tsc_khz = get_cpu_tsc_khz(); - - if (local_tsc_khz && - !kvm_get_walltime_and_clockread(&ts, &host_tsc)) - local_tsc_khz = 0; /* Fall back to old method */ - - put_cpu(); - - /* - * These values must be snapshotted within the seqcount loop. - * After that, it's just mathematics which can happen on any - * CPU at any time. - */ - hv_clock.tsc_timestamp = ka->master_cycle_now; - hv_clock.system_time = ka->master_kernel_ns + ka->kvmclock_offset; + struct kvm_clock_data data; - } while (read_seqcount_retry(&ka->pvclock_sc, seq)); + get_kvmclock(kvm, &data); /* - * If the conditions were right, and obtaining the wallclock+TSC was - * successful, calculate the KVM clock at the corresponding time and - * subtract one from the other to get the guest's epoch in nanoseconds - * since 1970-01-01. + * If get_kvmclock() captured both wallclock and kvmclock from the + * same TSC reading, use them for a precise epoch calculation. */ - if (local_tsc_khz) { - kvm_get_time_scale(NSEC_PER_SEC, local_tsc_khz * NSEC_PER_USEC, - &hv_clock.tsc_shift, - &hv_clock.tsc_to_system_mul); - return ts.tv_nsec + NSEC_PER_SEC * ts.tv_sec - - __pvclock_read_cycles(&hv_clock, host_tsc); - } -#endif - return ktime_get_real_ns() - get_kvmclock_ns(kvm); + if (data.flags & KVM_CLOCK_REALTIME) + return data.realtime - data.clock; + + return ktime_get_real_ns() - data.clock; } /* -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353884.1609645 (Exim 4.92) (envelope-from ) id 1wflMP-0006D2-8H; Fri, 03 Jul 2026 21:23:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353884.1609645; Fri, 03 Jul 2026 21:23:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMP-0006Cs-2Y; Fri, 03 Jul 2026 21:23:45 +0000 Received: by outflank-mailman (input) for mailman id 1353884; Fri, 03 Jul 2026 21:23:43 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMN-0005qG-BT for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMM-000kw0-O4; Fri, 03 Jul 2026 23:23:42 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48281c-2eae-0a2a0a5409dd-0a2a4504979a-10 for ; Fri, 03 Jul 2026 23:23:42 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48285d-a01d-0a2a45040019-5a9b5cc78d46-3 for ; Fri, 03 Jul 2026 23:23:42 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKe-000000059OF-0vI4; Fri, 03 Jul 2026 21:23:11 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RQD-3BKG; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=Ort/pZQb4ierCrxm1j8Wvj2iLn37EL9Xs8ile8CK+5w=; b=iGUqq6bke/f9INoPyifWfn6tMr Dxx9c7T5UqI5UMg8YjyLmZpMVseB7N8tyabz9obX/dC+ngIU3yv1JHY3JTAWY6WngiA570Ryh4IOF b01mRW0I0bfTI3wDMXY7Yqmz4AqjFrVwhNTMruP7kS6z7gO1y/WKqWK9lLjnLOsgL2ks7g7OnG9iK 1C80or7kq0ERNDnGtFaUh3xmfdkYHkkAWlJ+T0ZNUpaqHxFoQDCFHBGH5vce0dCBsk83GzuL97PPe r2wTSTLoYRY1lpzZtdTadwaq2mg2QrWDju/Gu1EeSlgsy4TO/ncXhKlwClbwNm7lOreXmIVUpUc0Y cP23OeUg==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 35/36] KVM: x86: Remove pvclock_gtod_data and private timekeeping code Date: Fri, 3 Jul 2026 22:18:14 +0100 Message-ID: <20260703212145.343527-36-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ebf023/1783113822-AFD241CC-A09A4783/0/0 X-purgate-type: clean X-purgate-size: 6507 From: David Woodhouse Remove the now-unused KVM-private timekeeping infrastructure: - struct pvclock_clock and struct pvclock_gtod_data - update_pvclock_gtod() and its seqcount-protected state copy - read_tsc() (KVM's private TSC reader with cycle_last clamping) - vgettsc() (KVM's private clocksource interpolation) - do_kvmclock_base(), do_monotonic(), do_realtime() Signed-off-by: David Woodhouse Assisted-by: Kiro:claude-opus-4.6-1m --- arch/x86/kvm/x86.c | 178 +-------------------------------------------- 1 file changed, 1 insertion(+), 177 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index c67655f8e078..58016af64932 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2347,58 +2347,6 @@ static int do_set_msr(struct kvm_vcpu *vcpu, unsigned index, u64 *data) return kvm_set_msr_ignored_check(vcpu, index, *data, true); } -struct pvclock_clock { - int vclock_mode; - u64 cycle_last; - u64 mask; - u32 mult; - u32 shift; - u64 base_cycles; - u64 offset; -}; - -struct pvclock_gtod_data { - seqcount_t seq; - - struct pvclock_clock clock; /* extract of a clocksource struct */ - struct pvclock_clock raw_clock; /* extract of a clocksource struct */ - - ktime_t offs_boot; - u64 wall_time_sec; -}; - -static struct pvclock_gtod_data pvclock_gtod_data; - -static void update_pvclock_gtod(struct timekeeper *tk) -{ - struct pvclock_gtod_data *vdata = &pvclock_gtod_data; - - write_seqcount_begin(&vdata->seq); - - /* copy pvclock gtod data */ - vdata->clock.vclock_mode = tk->tkr_mono.clock->vdso_clock_mode; - vdata->clock.cycle_last = tk->tkr_mono.cycle_last; - vdata->clock.mask = tk->tkr_mono.mask; - vdata->clock.mult = tk->tkr_mono.mult; - vdata->clock.shift = tk->tkr_mono.shift; - vdata->clock.base_cycles = tk->tkr_mono.xtime_nsec; - vdata->clock.offset = tk->tkr_mono.base; - - vdata->raw_clock.vclock_mode = tk->tkr_raw.clock->vdso_clock_mode; - vdata->raw_clock.cycle_last = tk->tkr_raw.cycle_last; - vdata->raw_clock.mask = tk->tkr_raw.mask; - vdata->raw_clock.mult = tk->tkr_raw.mult; - vdata->raw_clock.shift = tk->tkr_raw.shift; - vdata->raw_clock.base_cycles = tk->tkr_raw.xtime_nsec; - vdata->raw_clock.offset = tk->tkr_raw.base; - - vdata->wall_time_sec = tk->xtime_sec; - - vdata->offs_boot = tk->offs_boot; - - write_seqcount_end(&vdata->seq); -} - static s64 get_kvmclock_base_ns(void) { /* Count up from boot time, but with the frequency of the raw clock. */ @@ -3029,128 +2977,6 @@ static inline void adjust_tsc_offset_host(struct kvm_vcpu *vcpu, s64 adjustment) #ifdef CONFIG_X86_64 -static u64 read_tsc(void) -{ - u64 ret = (u64)rdtsc_ordered(); - u64 last = pvclock_gtod_data.clock.cycle_last; - - if (likely(ret >= last)) - return ret; - - /* - * GCC likes to generate cmov here, but this branch is extremely - * predictable (it's just a function of time and the likely is - * very likely) and there's a data dependence, so force GCC - * to generate a branch instead. I don't barrier() because - * we don't actually need a barrier, and if this function - * ever gets inlined it will generate worse code. - */ - asm volatile (""); - return last; -} - -static inline u64 vgettsc(struct pvclock_clock *clock, u64 *tsc_timestamp, - int *mode) -{ - u64 tsc_pg_val; - long v; - - switch (clock->vclock_mode) { - case VDSO_CLOCKMODE_HVCLOCK: - if (hv_read_tsc_page_tsc(hv_get_tsc_page(), - tsc_timestamp, &tsc_pg_val)) { - /* TSC page valid */ - *mode = VDSO_CLOCKMODE_HVCLOCK; - v = (tsc_pg_val - clock->cycle_last) & - clock->mask; - } else { - /* TSC page invalid */ - *mode = VDSO_CLOCKMODE_NONE; - } - break; - case VDSO_CLOCKMODE_TSC: - *mode = VDSO_CLOCKMODE_TSC; - *tsc_timestamp = read_tsc(); - v = (*tsc_timestamp - clock->cycle_last) & - clock->mask; - break; - default: - *mode = VDSO_CLOCKMODE_NONE; - } - - if (*mode == VDSO_CLOCKMODE_NONE) - *tsc_timestamp = v = 0; - - return v * clock->mult; -} - -/* - * As with get_kvmclock_base_ns(), this counts from boot time, at the - * frequency of CLOCK_MONOTONIC_RAW (hence adding gtos->offs_boot). - */ -static int do_kvmclock_base(s64 *t, u64 *tsc_timestamp) -{ - struct pvclock_gtod_data *gtod = &pvclock_gtod_data; - unsigned long seq; - int mode; - u64 ns; - - do { - seq = read_seqcount_begin(>od->seq); - ns = gtod->raw_clock.base_cycles; - ns += vgettsc(>od->raw_clock, tsc_timestamp, &mode); - ns >>= gtod->raw_clock.shift; - ns += ktime_to_ns(ktime_add(gtod->raw_clock.offset, gtod->offs_boot)); - } while (unlikely(read_seqcount_retry(>od->seq, seq))); - *t = ns; - - return mode; -} - -/* - * This calculates CLOCK_MONOTONIC at the time of the TSC snapshot, with - * no boot time offset. - */ -static int do_monotonic(s64 *t, u64 *tsc_timestamp) -{ - struct pvclock_gtod_data *gtod = &pvclock_gtod_data; - unsigned long seq; - int mode; - u64 ns; - - do { - seq = read_seqcount_begin(>od->seq); - ns = gtod->clock.base_cycles; - ns += vgettsc(>od->clock, tsc_timestamp, &mode); - ns >>= gtod->clock.shift; - ns += ktime_to_ns(gtod->clock.offset); - } while (unlikely(read_seqcount_retry(>od->seq, seq))); - *t = ns; - - return mode; -} - -static int do_realtime(struct timespec64 *ts, u64 *tsc_timestamp) -{ - struct pvclock_gtod_data *gtod = &pvclock_gtod_data; - unsigned long seq; - int mode; - u64 ns; - - do { - seq = read_seqcount_begin(>od->seq); - ts->tv_sec = gtod->wall_time_sec; - ns = gtod->clock.base_cycles; - ns += vgettsc(>od->clock, tsc_timestamp, &mode); - ns >>= gtod->clock.shift; - } while (unlikely(read_seqcount_retry(>od->seq, seq))); - - ts->tv_sec += __iter_div_u64_rem(ns, NSEC_PER_SEC, &ns); - ts->tv_nsec = ns; - - return mode; -} - /* * Calculates the kvmclock_base_ns (CLOCK_MONOTONIC_RAW + boot time) and * reports the TSC value from which it do so. Returns true if host is @@ -10394,11 +10220,9 @@ static DEFINE_IRQ_WORK(pvclock_irq_work, pvclock_irq_work_fn); static int pvclock_gtod_notify(struct notifier_block *nb, unsigned long unused, void *priv) { +#ifdef CONFIG_X86_64 struct timekeeper *tk = priv; - update_pvclock_gtod(tk); - -#ifdef CONFIG_X86_64 kvm_host_vclock_mode = tk->tkr_mono.clock->vdso_clock_mode; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353895.1609655 (Exim 4.92) (envelope-from ) id 1wflMX-00073z-K0; Fri, 03 Jul 2026 21:23:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353895.1609655; Fri, 03 Jul 2026 21:23:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMX-00073O-C9; Fri, 03 Jul 2026 21:23:53 +0000 Received: by outflank-mailman (input) for mailman id 1353895; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMW-0006u2-4y for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMV-001XO6-Gs; Fri, 03 Jul 2026 23:23:51 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482856-5cb7-0a2a0a5109dd-0a2a4501b470-6 for ; Fri, 03 Jul 2026 23:23:51 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482866-400f-0a2a45010019-5a9b5cc79db4-3 for ; Fri, 03 Jul 2026 23:23:51 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKc-000000059Nw-41Pc; Fri, 03 Jul 2026 21:23:11 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKV-00000001RO1-49DP; Fri, 03 Jul 2026 22:21:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=hH+knYn8nTd+TnpfZC0k8V0fYdXUF8AZtKckehaVSow=; b=ag/RZYPYcN4fVre9EsOS+cOhgG SwK+HBXd1dgEt76oRFLUyPps4X6KBXzSXwZeG8u4bPBlS1lY6kQQvAcw3N7JBu/jgw5Oe4TmfsCbY cGsWk+shyieTGRcnmmdvQW3sYKZmi87gbtyJxTa9TzZQfKD6AJliCrRLqmacRh4oYvoPEd9VQZYHP +EBg6NrRc7a+h2xbCvCY2ik3TtHc7gqWcC1e6ZFSOkCHviU9BxUopFV+Av+rB7l/zJUI5VuUCrOlH sKBpN9uwsn5Q2ooxq1gQ5H+fO3FvAsMOJ+0Fskg5ceKnccVTWZJB6lTZZtjdD9iLxY8ozyYLaNuNg BCA7oq3A==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 04/36] KVM: selftests: Use UAPI pvclock-abi.h in xen_shinfo_test Date: Fri, 3 Jul 2026 22:17:43 +0100 Message-ID: <20260703212145.343527-5-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d62444/1783113831-83AC91E0-5144876C/0/0 X-purgate-type: clean X-purgate-size: 1138 From: David Woodhouse Now that pvclock-abi.h is a UAPI header, use it in xen_shinfo_test.c instead of locally duplicating the struct definitions. Signed-off-by: David Woodhouse --- .../testing/selftests/kvm/x86/xen_shinfo_test.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/tools/testing/selftests/kvm/x86/xen_shinfo_test.c b/tools/testing/selftests/kvm/x86/xen_shinfo_test.c index 5076f6a75455..2f241ca4f096 100644 --- a/tools/testing/selftests/kvm/x86/xen_shinfo_test.c +++ b/tools/testing/selftests/kvm/x86/xen_shinfo_test.c @@ -98,22 +98,7 @@ struct sched_poll { u64 timeout; }; -struct pvclock_vcpu_time_info { - u32 version; - u32 pad0; - u64 tsc_timestamp; - u64 system_time; - u32 tsc_to_system_mul; - s8 tsc_shift; - u8 flags; - u8 pad[2]; -} __attribute__((__packed__)); /* 32 bytes */ - -struct pvclock_wall_clock { - u32 version; - u32 sec; - u32 nsec; -} __attribute__((__packed__)); +#include struct vcpu_runstate_info { u32 state; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353896.1609659 (Exim 4.92) (envelope-from ) id 1wflMY-0007At-4J; Fri, 03 Jul 2026 21:23:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353896.1609659; Fri, 03 Jul 2026 21:23:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMX-00079A-Ue; Fri, 03 Jul 2026 21:23:53 +0000 Received: by outflank-mailman (input) for mailman id 1353896; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMW-0006v5-KE for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMW-000kw0-1F; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482832-2eae-0a2a0a5409dd-0a2a450b92fe-38 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482867-ac48-0a2a450b0019-5a9b5cc7a076-3 for ; Fri, 03 Jul 2026 23:23:51 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKc-000000059Ny-3C3B; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROH-0fUc; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=v5twNDtsGAUIy7fgp54AfjET8D0248IAEiPECDLBGtY=; b=D3raY3MtOWfOex9Yyi+xdwR0oR uH968+lTAMciyl5YT2WpYYHWkV4kZsN8/ZHM2GRGrwrBj9ui5GYmD9fG5F2abnWtV4WzOKBvaPhA2 Q0QkFD8RDTCmadp3BR9IBi8DDKktdVZV77/JpgdmtpX0sSXUozU4PcguLEOrURgnnk/FD1DDwvg11 GhxzUTCQtWepYdtdsACcCD7qQa4cSuaOUyBMo3ystxYHRyA1I0arDUTqQRtVZrp2cyUSbbXeGS0Ie iCh4Z9aESsuLp+Ly/0B9HNI3BAqiQTUd6lP1/mWLYFZqczT8/eBEz4K0SdSrfmyS9ogn3nh0vMR4J oqQGhlcA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 08/36] KVM: x86: Activate master clock immediately on vCPU creation Date: Fri, 3 Jul 2026 22:17:47 +0100 Message-ID: <20260703212145.343527-9-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-42698a/1783113832-A7B30220-98314000/0/0 X-purgate-type: clean X-purgate-size: 1254 From: David Woodhouse Previously, the master clock was only activated when the first vCPU processed KVM_REQ_MASTERCLOCK_UPDATE during KVM_RUN. This meant that KVM_GET_CLOCK could not return the host_tsc field until after the first KVM_RUN, making it impossible for userspace to follow the documented TSC migration procedure without a dummy vCPU run. Fix this by calling kvm_update_masterclock() directly from kvm_arch_vcpu_postcreate(), after kvm_synchronize_tsc() has already set all_vcpus_matched_freq. This ensures the master clock is active immediately, and KVM_GET_CLOCK returns a valid {host_tsc, realtime} pair as soon as a vCPU exists. Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index ff45577ed90c..2039bd8518fb 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -13110,6 +13110,8 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) return; vcpu_load(vcpu); kvm_synchronize_tsc(vcpu, NULL); + if (!vcpu->kvm->arch.use_master_clock) + kvm_update_masterclock(vcpu->kvm); vcpu_put(vcpu); /* poll control enabled by default */ -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353900.1609665 (Exim 4.92) (envelope-from ) id 1wflMY-0007Fw-Rg; Fri, 03 Jul 2026 21:23:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353900.1609665; Fri, 03 Jul 2026 21:23:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMY-0007FO-CF; Fri, 03 Jul 2026 21:23:54 +0000 Received: by outflank-mailman (input) for mailman id 1353900; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMW-0006v9-Mq for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMW-00CejO-2E; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48275c-bab6-0a2a0a5309dd-0a2a450c84ae-48 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482867-f399-0a2a450c0019-5a9b5cc7bdf0-3 for ; Fri, 03 Jul 2026 23:23:51 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059O3-3Oad; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROl-2MEe; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=pFpNlCE+MJW0eKcLFgCCZwMvqjxRJ/tMcKVjrR0U73Q=; b=qTsfnPqYdMDx4eUygFXJFljz/J HPP9ML6utEPbyFF37E1VztfM6jgMhMBh95PQ1lNByOYWgIaCp6JWwXn4CRiSdDQFDIubsZaIb1glB Pu8lGpAoP1cmJkXCbNxwxUkWPL34CuBc3XRH6b6uwshPpJHdqsbbOUZ4TmvT2K+ejBCcOwlpZY1Jb GjvaQoRWKExUh3UM+KhXoM+5PJv34XQ5X20qE921jQFhjoHQPWuJAMkL9/oLGBiIyvViWkFfekSOH a1X/CfCJ/Z+HF+xC8jpSbTeTXXtYydVpu1qQp7aurcyiShWJWGhkMCvXINe0EysHUaf8mOrj5+V/i 2xt5dohQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 15/36] KVM: x86: Fix compute_guest_tsc() to handle negative time deltas Date: Fri, 3 Jul 2026 22:17:54 +0100 Message-ID: <20260703212145.343527-16-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d25034/1783113832-92F3BD51-96E90A37/0/0 X-purgate-type: clean X-purgate-size: 1721 From: David Woodhouse The compute_guest_tsc() function computes the guest TSC at a given kernel_ns timestamp. When the master clock reference point (master_kernel_ns) is earlier than vcpu->arch.this_tsc_nsec, the delta is negative. Since pvclock_scale_delta() takes a u64, the negative value wraps to a huge positive number, producing a wildly wrong result. Handle negative deltas explicitly by negating the delta, scaling it, and subtracting from this_tsc_write. Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 376b8dc2ade9..55fb19fb7a88 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2588,11 +2588,21 @@ static int kvm_set_tsc_khz(struct kvm_vcpu *vcpu, u32 user_tsc_khz) static u64 compute_guest_tsc(struct kvm_vcpu *vcpu, s64 kernel_ns) { - u64 tsc = pvclock_scale_delta(kernel_ns-vcpu->arch.this_tsc_nsec, - vcpu->arch.virtual_tsc_mult, - vcpu->arch.virtual_tsc_shift); - tsc += vcpu->arch.this_tsc_write; - return tsc; + s64 delta_ns = kernel_ns - vcpu->arch.this_tsc_nsec; + u64 tsc; + + /* Handle negative deltas gracefully (master clock ref may be earlier) */ + if (delta_ns < 0) { + tsc = pvclock_scale_delta(-delta_ns, + vcpu->arch.virtual_tsc_mult, + vcpu->arch.virtual_tsc_shift); + return vcpu->arch.this_tsc_write - tsc; + } + + tsc = pvclock_scale_delta(delta_ns, + vcpu->arch.virtual_tsc_mult, + vcpu->arch.virtual_tsc_shift); + return vcpu->arch.this_tsc_write + tsc; } #ifdef CONFIG_X86_64 -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353901.1609669 (Exim 4.92) (envelope-from ) id 1wflMZ-0007KA-2c; Fri, 03 Jul 2026 21:23:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353901.1609669; Fri, 03 Jul 2026 21:23:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMY-0007IX-QX; Fri, 03 Jul 2026 21:23:54 +0000 Received: by outflank-mailman (input) for mailman id 1353901; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMW-0006v8-Lb for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMW-001XO6-2V; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827d9-5cb7-0a2a0a5109dd-0a2a4505dcf2-42 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482867-3cb2-0a2a45050019-5a9b5cc781b6-3 for ; Fri, 03 Jul 2026 23:23:51 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059Nu-3OYm; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKV-00000001RNp-3OFP; Fri, 03 Jul 2026 22:21:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=SebBoBga7+8xvSm9Qg2DITvEgd/PpKvvHuYtx20We+A=; b=MrJT44uEu/ZgsbRjkneqpYQb+I C9bwJVuCznY58yJD8EdJi8FQdNVEgxGcL50Ro9AZYdMNScp+g1s1h2IFLUn2lIqqc9EYs8NUR3RGy 6qxE3E1hl0ywiGSZI+jKomQ4xMQr+7uKuHnk/5q0xaHqpxokRZIG6n6fJrVvB2w20H2Y8vq7G+Kz/ ypBryhHJBUZNe7TIsGAxVDdtKuU2mjrLVIBo3VZJ4w8SDZ7LzobdRT/yT+cdPuckXVbOn/8HEOmTl 5FiE48zNpNUBhA5POfG4WA4DzdJ+VDeI0VUe2SBZrA7WCF/2WPhGmEyI6XoaCQ7zDs39P9Nk5648O 5UZK0HgA==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 01/36] KVM: x86/xen: Do not corrupt KVM clock in kvm_xen_shared_info_init() Date: Fri, 3 Jul 2026 22:17:40 +0100 Message-ID: <20260703212145.343527-2-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-c201ff/1783113832-179182B8-3037DC53/0/0 X-purgate-type: clean X-purgate-size: 4490 From: David Woodhouse The KVM clock is an interesting thing. It is defined as "nanoseconds since the guest was created", but in practice it runs at two *different* rates — or three different rates, if you count implementation bugs. Definition A is that it runs synchronously with the CLOCK_MONOTONIC_RAW of the host, with a delta of kvm->arch.kvmclock_offset. But that version doesn't actually get used in the common case, where the host has a reliable TSC and the guest TSCs are all running at the same rate and in sync with each other, and kvm->arch.use_master_clock is set. In that common case, definition B is used: There is a reference point in time at kvm->arch.master_kernel_ns (again a CLOCK_MONOTONIC_RAW time), and a corresponding host TSC value kvm->arch.master_cycle_now. This fixed point in time is converted to guest units (the time offset by kvmclock_offset and the TSC Value scaled and offset to be a guest TSC value) and advertised to the guest in the pvclock structure. While in this 'use_master_clock' mode, the fixed point in time never needs to be changed, and the clock runs precisely in time with the guest TSC, at the rate advertised in the pvclock structure. The third definition C is implemented in kvm_get_wall_clock_epoch() and __get_kvmclock(), using the master_cycle_now and master_kernel_ns fields but converting the *host* TSC cycles directly to a value in nanoseconds instead of scaling via the guest TSC. One might naïvely think that all three definitions are identical, since CLOCK_MONOTONIC_RAW is not skewed by NTP frequency corrections; all three are just the result of counting the host TSC at a known frequency, or the scaled guest TSC at a known precise fraction of the host's frequency. The problem is with arithmetic precision, and the way that frequency scaling is done in a division-free way by multiplying by a scale factor, then shifting right. In practice, all three ways of calculating the KVM clock will suffer a systemic drift from each other. Eventually, definition C should just be eliminated. Commit 451a707813ae ("KVM: x86/xen: improve accuracy of Xen timers") worked around it for the specific case of Xen timers, which are defined in terms of the KVM clock and suffered from a continually increasing error in timer expiry times. That commit notes that get_kvmclock_ns() is non-trivial to fix and says "I'll come back to that", which remains true. Definitions A and B do need to coexist, the former to handle the case where the host or guest TSC is suboptimally configured. But KVM should be more careful about switching between them, and the discontinuity in guest time which could result. In particular, KVM_REQ_MASTERCLOCK_UPDATE will take a new snapshot of time as the reference in master_kernel_ns and master_cycle_now, yanking the guest's clock back to match definition A at that moment. When invoked from in 'use_master_clock' mode, kvm_update_masterclock() should probably *adjust* kvm->arch.kvmclock_offset to account for the drift, instead of yanking the clock back to definition A. But in the meantime there are a bunch of places where it just doesn't need to be invoked at all. To start with: there is no need to do such an update when a Xen guest populates the shared_info page. This seems to have been a hangover from the very first implementation of shared_info which automatically populated the vcpu_info structures at their default locations, but even then it should just have raised KVM_REQ_CLOCK_UPDATE on each vCPU instead of using KVM_REQ_MASTERCLOCK_UPDATE. And now that userspace is expected to explicitly set the vcpu_info even in its default locations, there's not even any need for that either. Fixes: 629b5348841a ("KVM: x86/xen: update wallclock region") Reviewed-by: Paul Durrant Signed-off-by: David Woodhouse --- arch/x86/kvm/xen.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c index 91fd3673c09a..82e34edbfdbd 100644 --- a/arch/x86/kvm/xen.c +++ b/arch/x86/kvm/xen.c @@ -98,8 +98,6 @@ static int kvm_xen_shared_info_init(struct kvm *kvm) wc->version = wc_version + 1; read_unlock_irq(&gpc->lock); - kvm_make_all_cpus_request(kvm, KVM_REQ_MASTERCLOCK_UPDATE); - out: srcu_read_unlock(&kvm->srcu, idx); return ret; base-commit: 2d6d57f889f3a5e7d19009c560ea2002cdde9fb8 -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353903.1609678 (Exim 4.92) (envelope-from ) id 1wflMa-0007WJ-1L; Fri, 03 Jul 2026 21:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353903.1609678; Fri, 03 Jul 2026 21:23:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMZ-0007SR-H5; Fri, 03 Jul 2026 21:23:55 +0000 Received: by outflank-mailman (input) for mailman id 1353903; Fri, 03 Jul 2026 21:23:53 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMW-0006zB-Vi for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMW-001XO6-CA; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48282a-5cb7-0a2a0a5109dd-0a2a450aa8e8-34 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482867-e40e-0a2a450a0019-5a9b5cc7ba58-3 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059Nx-0xnf; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROD-0TOT; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=XAeJCQ+9v+mDSYHMRAWw2uzIOBs6a2aQ/+qu99zPeWk=; b=L06h6XB7ChTw5JFuRa1oGPYKJD pa/C7Tzgjlg4/j8Xcz0xLWravurCFkrPEx8W3oxblz5pXyRuuOucw0AfVSQ49G8Z2gokwtlVqRpUZ 76hF5gEabMj2GhEiYzS+cxTluSHaQJf3VqmfsdAaBGUby6HcIzGDTJx1nTtkYwrlAiBOzKKn/OJLk NsB+IqXwT26+U20Jo6IPUmvncGBzgomgyfc+lfqu+HJCe1B3oMqqyDWXnWGzjpdTw3Yw4pvvAdIDe NWCOKCuauAg+5mLGmvv2MuV/AJ4pY0kVq9SZWRoaSGeGhhLb4lcny8uw6kw5j20BInWSG2/SHbvPx 3UEsgyoQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 07/36] KVM: x86: Explicitly disable TSC scaling without CONSTANT_TSC Date: Fri, 3 Jul 2026 22:17:46 +0100 Message-ID: <20260703212145.343527-8-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1783113832-D4B2CDDE-DEF88D8C/0/0 X-purgate-type: clean X-purgate-size: 2365 From: David Woodhouse KVM does make an attempt to cope with non-constant TSC, and has notifiers to handle host TSC frequency changes. However, it *only* adjusts the KVM clock, and doesn't adjust TSC frequency scaling when the host changes. This is presumably because non-constant TSCs were fixed in hardware long before TSC scaling was implemented, so there should never be real CPUs which have TSC scaling but *not* CONSTANT_TSC. Such a combination could potentially happen in some odd L1 nesting environment, but it isn't worth trying to support it. Just make the dependency explicit. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/kvm/svm/svm.c | 3 ++- arch/x86/kvm/vmx/vmx.c | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index e02a38da5296..c46a34aeb3df 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -5557,7 +5557,8 @@ static __init int svm_hardware_setup(void) XFEATURE_MASK_BNDCSR); if (tsc_scaling) { - if (!boot_cpu_has(X86_FEATURE_TSCRATEMSR)) { + if (!boot_cpu_has(X86_FEATURE_TSCRATEMSR) || + !boot_cpu_has(X86_FEATURE_CONSTANT_TSC)) { tsc_scaling = false; } else { pr_info("TSC scaling supported\n"); diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index b9103de01428..54e92d94155e 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2792,6 +2792,16 @@ static int setup_vmcs_config(struct vmcs_config *vmcs_conf, if (!cpu_has_sgx()) _cpu_based_2nd_exec_control &= ~SECONDARY_EXEC_ENCLS_EXITING; + /* + * KVM doesn't re-derive the TSC scaling ratio when the host TSC + * frequency changes, so TSC scaling is only usable with a constant + * TSC. Clear the control here rather than in vmx_hardware_setup() so + * that the per-CPU configs recomputed by vmx_check_processor_compat() + * stay consistent with the golden vmcs_config. + */ + if (!boot_cpu_has(X86_FEATURE_CONSTANT_TSC)) + _cpu_based_2nd_exec_control &= ~SECONDARY_EXEC_TSC_SCALING; + if (_cpu_based_exec_control & CPU_BASED_ACTIVATE_TERTIARY_CONTROLS) _cpu_based_3rd_exec_control = adjust_vmx_controls64(KVM_OPTIONAL_VMX_TERTIARY_VM_EXEC_CONTROL, -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353904.1609680 (Exim 4.92) (envelope-from ) id 1wflMa-0007iL-Am; Fri, 03 Jul 2026 21:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353904.1609680; Fri, 03 Jul 2026 21:23:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMa-0007h5-4w; Fri, 03 Jul 2026 21:23:56 +0000 Received: by outflank-mailman (input) for mailman id 1353904; Fri, 03 Jul 2026 21:23:53 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMX-00071A-7M for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMW-00CejO-KM; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482835-bab6-0a2a0a5309dd-0a2a45038b46-26 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482868-ec1a-0a2a45030019-5a9b5cc7ba66-3 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059OB-3OKN; Fri, 03 Jul 2026 21:23:31 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPf-1VR4; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=mAoCrW41i2oubtWoRcSbcZKOTJ7hLP/U/r8vkThOrIU=; b=SCbksCL3C6lCq63v2liwrhb2lA xAbzjM0Ap/EFmihcazXJMLsPc0Gy/LZbYMpy3KNL9NaNPZ08PMTpDHyMT9z4L9DQzWXqndhnhJVT/ KaO3tzV57y2ygHn+F/s78qY2H4870En1P/JMMQzNiMI3AcHjVzKmP29ZJ27qVm3fVpi0kgOi3ocQC Ldb5j68wLws0DZDKidaCijCDu71rnX34BxkzVhC35mPOUB55mdo0urZogZbzzyX9H1Btken59i/zq quARfNTDShyil/B7FPKU929VA3Q43dAMg5lcGHrX+ePGE7kLAD/aHCLdFkn9CykhB+0xJ6rmrTdEl TdTctQvw==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 28/36] KVM: x86: Remove runtime Xen TSC frequency CPUID update Date: Fri, 3 Jul 2026 22:18:07 +0100 Message-ID: <20260703212145.343527-29-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1783113832-07B245D1-AD583B97/0/0 X-purgate-type: clean X-purgate-size: 3099 From: David Woodhouse Remove the code in kvm_cpuid() that dynamically updates the Xen TSC info CPUID leaf at runtime. This code was updating the wrong sub-leaf anyway (0x40000x03/2 EAX is the *host* TSC frequency per the Xen ABI, not the guest frequency which belongs in 0x40000x03/0 ECX). Userspace now has all the information it needs to populate the Xen TSC info leaves (and the generic 0x40000010 timing leaf) at vCPU setup time: - KVM_GET_CLOCK_GUEST returns the pvclock_vcpu_time_info structure containing tsc_to_system_mul and tsc_shift (Xen leaf index 1) - KVM_VCPU_TSC_SCALE returns the effective TSC and bus frequencies in kHz (Xen leaf index 2, and 0x40000010) - KVM_VCPU_TSC_SCALE returns the raw hardware scaling ratio for precise arithmetic (VMClock) This eliminates the last instance of KVM modifying guest CPUID entries at runtime for timing information. Signed-off-by: David Woodhouse --- arch/x86/kvm/cpuid.c | 16 ---------------- arch/x86/kvm/xen.h | 13 ------------- 2 files changed, 29 deletions(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 621d950ec692..826637a0b72d 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -2117,22 +2117,6 @@ bool kvm_cpuid(struct kvm_vcpu *vcpu, u32 *eax, u32 *ebx, } else if (function == 0x80000007) { if (kvm_hv_invtsc_suppressed(vcpu)) *edx &= ~feature_bit(CONSTANT_TSC); - } else if (IS_ENABLED(CONFIG_KVM_XEN) && - kvm_xen_is_tsc_leaf(vcpu, function)) { - /* - * Update guest TSC frequency information if necessary. - * Ignore failures, there is no sane value that can be - * provided if KVM can't get the TSC frequency. - */ - if (kvm_check_request(KVM_REQ_CLOCK_UPDATE, vcpu)) - kvm_guest_time_update(vcpu); - - if (index == 1) { - *ecx = vcpu->arch.pvclock_tsc_mul; - *edx = vcpu->arch.pvclock_tsc_shift; - } else if (index == 2) { - *eax = div_u64(vcpu->arch.hw_tsc_hz, 1000); - } } } else { *eax = *ebx = *ecx = *edx = 0; diff --git a/arch/x86/kvm/xen.h b/arch/x86/kvm/xen.h index 59e6128a7bd3..f372855857a8 100644 --- a/arch/x86/kvm/xen.h +++ b/arch/x86/kvm/xen.h @@ -50,14 +50,6 @@ static inline void kvm_xen_sw_enable_lapic(struct kvm_vcpu *vcpu) kvm_xen_inject_vcpu_vector(vcpu); } -static inline bool kvm_xen_is_tsc_leaf(struct kvm_vcpu *vcpu, u32 function) -{ - return static_branch_unlikely(&kvm_xen_enabled.key) && - vcpu->arch.xen.cpuid.base && - function <= vcpu->arch.xen.cpuid.limit && - function == (vcpu->arch.xen.cpuid.base | XEN_CPUID_LEAF(3)); -} - static inline bool kvm_xen_msr_enabled(struct kvm *kvm) { return static_branch_unlikely(&kvm_xen_enabled.key) && @@ -177,11 +169,6 @@ static inline bool kvm_xen_timer_enabled(struct kvm_vcpu *vcpu) { return false; } - -static inline bool kvm_xen_is_tsc_leaf(struct kvm_vcpu *vcpu, u32 function) -{ - return false; -} #endif int kvm_xen_hypercall(struct kvm_vcpu *vcpu); -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353906.1609691 (Exim 4.92) (envelope-from ) id 1wflMb-0007xy-Oj; Fri, 03 Jul 2026 21:23:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353906.1609691; Fri, 03 Jul 2026 21:23:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMb-0007w8-79; Fri, 03 Jul 2026 21:23:57 +0000 Received: by outflank-mailman (input) for mailman id 1353906; Fri, 03 Jul 2026 21:23:54 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMY-0007Bo-8r for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMX-00CejO-Lw; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48281d-bab6-0a2a0a5309dd-0a2a4507d556-20 for ; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482869-9c8e-0a2a45070019-5a9b5cc7914a-3 for ; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKc-000000059Nv-34Xj; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKV-00000001RNt-3e6d; Fri, 03 Jul 2026 22:21:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=flkC/OcSCGAXpnaP19vXBE2hMaRp11igqBu5RS6r3dg=; b=Tbbp2+TwxLpc+G6p3RBqRTKHVF F4m+83xyTjWYceXJyh2USsFVoW6+F+mtSXFFxfE40w5kBpDY7LtCXofCcMc5DNYajLyDOqwL8awjr D8NjUmK74H6WSJ4msHlpTTp23TRYPcLxDbu5yf3S4NBseUm1GXoEO6eGOWBjZbhbqtgNYV3EslBHl sdjDwDOi/MgPFJ/us5LXXWA4S16xfC6rAOzt5Ui6F0K99DIcw/7CW4aX8nJ96jKVAAqZ7lQKV3S/e wuu9Y93KEfLorCJOM0DRw0AlgEomw2lcT+tPvveFIhQ0M5LxwRmzGgsezMN8iEKUMRI6h7CJsDgke xHD9FbXQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 02/36] KVM: x86: Improve accuracy of KVM clock when TSC scaling is in force Date: Fri, 3 Jul 2026 22:17:41 +0100 Message-ID: <20260703212145.343527-3-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ef75cf/1783113833-FEB3B25E-425DE96E/0/0 X-purgate-type: clean X-purgate-size: 4085 From: David Woodhouse The kvm_guest_time_update() function scales the host TSC frequency to the guest's using kvm_scale_tsc() and the v->arch.l1_tsc_scaling_ratio scaling ratio previously calculated for that vCPU. Then calculates the scaling factors for the KVM clock itself based on that guest TSC frequency. However, it uses kHz as the unit when scaling, and then multiplies by 1000 only at the end. With a host TSC frequency of 3000MHz and a guest set to 2500MHz, the result of kvm_scale_tsc() will actually come out at 2,499,999kHz. So the KVM clock advertised to the guest is based on a frequency of 2,499,999,000 Hz. By using Hz as the unit from the beginning, the KVM clock would be based on a more accurate frequency of 2,499,999,999 Hz in this example. Use u64 for the hw_tsc_hz field since an unsigned int would overflow for TSC frequencies above 4GHz. Use div_u64() for the Xen CPUID leaf to play nice with 32-bit kernels. Fixes: 78db6a503796 ("KVM: x86: rewrite handling of scaled TSC for kvmclock") Reviewed-by: Paul Durrant Signed-off-by: David Woodhouse Tested-by: Dongli Zhang --- arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/kvm/cpuid.c | 2 +- arch/x86/kvm/x86.c | 17 +++++++++-------- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index f14009f25a3b..b2446c04a076 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -950,7 +950,7 @@ struct kvm_vcpu_arch { gpa_t time; s8 pvclock_tsc_shift; u32 pvclock_tsc_mul; - unsigned int hw_tsc_khz; + u64 hw_tsc_hz; struct gfn_to_pfn_cache pv_time; /* set guest stopped flag in pvclock flags field */ bool pvclock_set_guest_stopped_request; diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index e69156b54cff..621d950ec692 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -2131,7 +2131,7 @@ bool kvm_cpuid(struct kvm_vcpu *vcpu, u32 *eax, u32 *ebx, *ecx = vcpu->arch.pvclock_tsc_mul; *edx = vcpu->arch.pvclock_tsc_shift; } else if (index == 2) { - *eax = vcpu->arch.hw_tsc_khz; + *eax = div_u64(vcpu->arch.hw_tsc_hz, 1000); } } } else { diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 0550359ed798..dbcff49cd561 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3314,7 +3314,8 @@ static void kvm_setup_guest_pvclock(struct pvclock_vcpu_time_info *ref_hv_clock, int kvm_guest_time_update(struct kvm_vcpu *v) { struct pvclock_vcpu_time_info hv_clock = {}; - unsigned long flags, tgt_tsc_khz; + unsigned long flags; + u64 tgt_tsc_hz; unsigned seq; struct kvm_vcpu_arch *vcpu = &v->arch; struct kvm_arch *ka = &v->kvm->arch; @@ -3340,8 +3341,8 @@ int kvm_guest_time_update(struct kvm_vcpu *v) /* Keep irq disabled to prevent changes to the clock */ local_irq_save(flags); - tgt_tsc_khz = get_cpu_tsc_khz(); - if (unlikely(tgt_tsc_khz == 0)) { + tgt_tsc_hz = (u64)get_cpu_tsc_khz() * 1000; + if (unlikely(tgt_tsc_hz == 0)) { local_irq_restore(flags); kvm_make_request(KVM_REQ_CLOCK_UPDATE, v); return 1; @@ -3376,16 +3377,16 @@ int kvm_guest_time_update(struct kvm_vcpu *v) /* With all the info we got, fill in the values */ if (kvm_caps.has_tsc_control) { - tgt_tsc_khz = kvm_scale_tsc(tgt_tsc_khz, + tgt_tsc_hz = kvm_scale_tsc(tgt_tsc_hz, v->arch.l1_tsc_scaling_ratio); - tgt_tsc_khz = tgt_tsc_khz ? : 1; + tgt_tsc_hz = tgt_tsc_hz ? : 1; } - if (unlikely(vcpu->hw_tsc_khz != tgt_tsc_khz)) { - kvm_get_time_scale(NSEC_PER_SEC, tgt_tsc_khz * 1000LL, + if (unlikely(vcpu->hw_tsc_hz != tgt_tsc_hz)) { + kvm_get_time_scale(NSEC_PER_SEC, tgt_tsc_hz, &vcpu->pvclock_tsc_shift, &vcpu->pvclock_tsc_mul); - vcpu->hw_tsc_khz = tgt_tsc_khz; + vcpu->hw_tsc_hz = tgt_tsc_hz; } hv_clock.tsc_shift = vcpu->pvclock_tsc_shift; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353907.1609697 (Exim 4.92) (envelope-from ) id 1wflMc-00082Y-4f; Fri, 03 Jul 2026 21:23:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353907.1609697; Fri, 03 Jul 2026 21:23:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMb-00080t-Ke; Fri, 03 Jul 2026 21:23:57 +0000 Received: by outflank-mailman (input) for mailman id 1353907; Fri, 03 Jul 2026 21:23:54 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMY-00078a-3q for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMX-00A83n-GB; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482855-e002-0a2a0a5209dd-0a2a450295e8-10 for ; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482868-5a27-0a2a45020019-5a9b5cc7c8dc-3 for ; Fri, 03 Jul 2026 23:23:52 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059Nz-0yD3; Fri, 03 Jul 2026 21:23:31 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROL-0svz; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=3lUib/EIrL1+94Hfr3HOPm3NJZGT4m6/AxpXp3yQAbg=; b=Z7Au5hbqzBkr89WU5YG+ZPC5S9 ySbJNMLzah02oxol8S6rfewycGcma4xQAxc/yMNJ1UwcfKW0RZDK3N+ZfzpwnX0cDbzjv5IEtb3XP BqmZyXcEoEi6mGeg4G6eowbPuwlNfZdOQ3/Bi5QFoSwkKPyjSnPkAGntNnwvwwDGqmSGfM+0tOfqP H7LdsJn0nbVCjmbDvgIm50n7FXL+ms0X6P1pPKn8r3p7vR1RPFZ7mfnTwaazlLdhUz077TRnX5ZbP eSFnpVBx/QIZTGoz7Uf4ekeKzPD87F7ACQm+Sjaqai+PI1jV9VHGP1Dq2P8ygLT7zgjTP15zci0gv RqcBJSrQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 09/36] KVM: x86: Add KVM_VCPU_TSC_SCALE and fix the documentation on TSC migration Date: Fri, 3 Jul 2026 22:17:48 +0100 Message-ID: <20260703212145.343527-10-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-720697/1783113833-4E10A7C5-2A36E47B/0/0 X-purgate-type: clean X-purgate-size: 24002 From: David Woodhouse The documentation on TSC migration using KVM_VCPU_TSC_OFFSET is woefully inadequate. It ignores TSC scaling, and ignores the fact that the host TSC may differ from one host to the next (and in fact because of the way the kernel calibrates it, it generally differs from one boot to the next even on the same hardware). Add KVM_VCPU_TSC_SCALE to extract the actual scale ratio and frac_bits, and attempt to document the process that userspace needs to follow to preserve the TSC across migration. Add a self test to function as an exemplar. Only enumerate KVM_VCPU_TSC_SCALE when kvm_caps.has_tsc_control is true, since the scaling ratio is only meaningful when hardware TSC scaling is supported. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- Documentation/virt/kvm/devices/vcpu.rst | 120 ++++-- arch/x86/include/uapi/asm/kvm.h | 6 + arch/x86/kvm/x86.c | 21 + tools/testing/selftests/kvm/Makefile.kvm | 1 + .../kvm/x86/pvclock_migration_test.c | 383 ++++++++++++++++++ 5 files changed, 501 insertions(+), 30 deletions(-) create mode 100644 tools/testing/selftests/kvm/x86/pvclock_migration_test.c diff --git a/Documentation/virt/kvm/devices/vcpu.rst b/Documentation/virt/kvm/devices/vcpu.rst index 5e3805820010..de9f58f75eb9 100644 --- a/Documentation/virt/kvm/devices/vcpu.rst +++ b/Documentation/virt/kvm/devices/vcpu.rst @@ -229,6 +229,7 @@ including the layout of the stolen time structure. :Architectures: x86 4.1 ATTRIBUTE: KVM_VCPU_TSC_OFFSET +---------------------------------- :Parameters: 64-bit unsigned TSC offset @@ -243,7 +244,10 @@ Returns: Specifies the guest's TSC offset relative to the host's TSC. The guest's TSC is then derived by the following equation: - guest_tsc = host_tsc + KVM_VCPU_TSC_OFFSET + guest_tsc = ((host_tsc * tsc_ratio) >> tsc_frac_bits) + KVM_VCPU_TSC_OFFSET + +The values of tsc_ratio and tsc_frac_bits can be obtained using +the KVM_VCPU_TSC_SCALE attribute. This attribute is useful to adjust the guest's TSC on live migration, so that the TSC counts the time during which the VM was paused. The @@ -251,44 +255,100 @@ following describes a possible algorithm to use for this purpose. From the source VMM process: -1. Invoke the KVM_GET_CLOCK ioctl to record the host TSC (tsc_src), +1. Invoke the KVM_GET_CLOCK ioctl to record the host TSC (host_tsc_src), kvmclock nanoseconds (guest_src), and host CLOCK_REALTIME nanoseconds - (host_src). + (time_src) at a given moment (Tsrc). + +2. For each vCPU[i]: + + a. Read the KVM_VCPU_TSC_OFFSET attribute to record the guest TSC offset + (ofs_src[i]). -2. Read the KVM_VCPU_TSC_OFFSET attribute for every vCPU to record the - guest TSC offset (ofs_src[i]). + b. Read the KVM_VCPU_TSC_SCALE attribute to record the guest TSC scaling + ratio (ratio_src[i], frac_bits_src[i]). -3. Invoke the KVM_GET_TSC_KHZ ioctl to record the frequency of the - guest's TSC (freq). + c. Use host_tsc_src and the scaling/offset factors to calculate this + vCPU's TSC at time Tsrc: + + tsc_src[i] = ((host_tsc_src * ratio_src[i]) >> frac_bits_src[i]) + ofs_src[i] + +3. Invoke the KVM_GET_CLOCK_GUEST ioctl on the boot vCPU to return the KVM + clock as a function of the guest TSC (pvti_src). (This ioctl may not + succeed if the host and guest TSCs are not consistent and well-behaved.) From the destination VMM process: -4. Invoke the KVM_SET_CLOCK ioctl, providing the source nanoseconds from - kvmclock (guest_src) and CLOCK_REALTIME (host_src) in their respective - fields. Ensure that the KVM_CLOCK_REALTIME flag is set in the provided - structure. +4. Before creating the vCPUs, invoke the KVM_SET_TSC_KHZ ioctl on the VM, to + set the scaled frequency of the guest's TSC (freq). + +5. Invoke the KVM_GET_CLOCK ioctl to record the host TSC (host_tsc_dst) and + host CLOCK_REALTIME nanoseconds (time_dst) at a given moment (Tdst). + +6. Calculate the number of nanoseconds elapsed between Tsrc and Tdst: + + ΔT = time_dst - time_src + +7. As each vCPU[i] is created: + + a. Read the KVM_VCPU_TSC_SCALE attribute to record the guest TSC scaling + ratio (ratio_dst[i], frac_bits_dst[i]). + + b. Calculate the intended guest TSC value at time Tdst: + + tsc_dst[i] = tsc_src[i] + (ΔT * freq[i]) - KVM will advance the VM's kvmclock to account for elapsed time since - recording the clock values. Note that this will cause problems in - the guest (e.g., timeouts) unless CLOCK_REALTIME is synchronized - between the source and destination, and a reasonably short time passes - between the source pausing the VMs and the destination executing - steps 4-7. + c. Use host_tsc_dst and the scaling factors to calculate this vCPU's + raw scaled TSC at time Tdst without offsetting: + + raw_dst[i] = ((host_tsc_dst * ratio_dst[i]) >> frac_bits_dst[i]) + + d. Calculate ofs_dst[i] = tsc_dst[i] - raw_dst[i] and set the resulting + offset using the KVM_VCPU_TSC_OFFSET attribute. + +8. If pvti_src was provided, invoke the KVM_SET_CLOCK_GUEST ioctl on the boot + vCPU to restore the KVM clock as a precise function of the guest TSC. + +9. If KVM_SET_CLOCK_GUEST was not available or failed (e.g. because the + master clock is not active), fall back to the KVM_SET_CLOCK ioctl, + providing the source nanoseconds from kvmclock (guest_src) and + CLOCK_REALTIME (time_src) in their respective fields. Ensure that the + KVM_CLOCK_REALTIME flag is set in the provided structure. + + KVM will restore the VM's kvmclock, accounting for elapsed time since + the clock values were recorded. Note that this will cause problems in + the guest (e.g., timeouts) unless CLOCK_REALTIME is synchronized between + the source and destination, and a reasonably short time passes between + the source pausing the VMs and the destination resuming them. + Due to the KVM_[SG]ET_CLOCK API using CLOCK_REALTIME instead of + CLOCK_TAI, leap seconds during the migration may also introduce errors. + +4.2 ATTRIBUTE: KVM_VCPU_TSC_SCALE +--------------------------------- + +:Parameters: struct kvm_vcpu_tsc_scale + +Returns: + + ======= ====================================== + -EFAULT Error reading the provided parameter + address. + -ENXIO Attribute not supported (no TSC scaling) + -EINVAL Invalid request to write the attribute + ======= ====================================== -5. Invoke the KVM_GET_CLOCK ioctl to record the host TSC (tsc_dest) and - kvmclock nanoseconds (guest_dest). +This read-only attribute reports the guest's TSC scaling factor, in the form +of a fixed-point number represented by the following structure:: -6. Adjust the guest TSC offsets for every vCPU to account for (1) time - elapsed since recording state and (2) difference in TSCs between the - source and destination machine: + struct kvm_vcpu_tsc_scale { + __u64 tsc_ratio; + __u64 tsc_frac_bits; + }; - ofs_dst[i] = ofs_src[i] - - (guest_src - guest_dest) * freq + - (tsc_src - tsc_dest) +The tsc_frac_bits field indicates the location of the fixed point, such that +host TSC values are converted to guest TSC using the formula: - ("ofs[i] + tsc - guest * freq" is the guest TSC value corresponding to - a time of 0 in kvmclock. The above formula ensures that it is the - same on the destination as it was on the source). + guest_tsc = ((host_tsc * tsc_ratio) >> tsc_frac_bits) + offset -7. Write the KVM_VCPU_TSC_OFFSET attribute for every vCPU with the - respective value derived in the previous step. +Userspace can use this to precisely calculate the guest TSC from the host +TSC at any given moment. This is needed for accurate migration of guests, +as described in the documentation for the KVM_VCPU_TSC_OFFSET attribute. diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kvm.h index 5f4a66b1662a..fb38486ff742 100644 --- a/arch/x86/include/uapi/asm/kvm.h +++ b/arch/x86/include/uapi/asm/kvm.h @@ -962,6 +962,12 @@ struct kvm_hyperv_eventfd { /* for KVM_{GET,SET,HAS}_DEVICE_ATTR */ #define KVM_VCPU_TSC_CTRL 0 /* control group for the timestamp counter (TSC) */ #define KVM_VCPU_TSC_OFFSET 0 /* attribute for the TSC offset */ +#define KVM_VCPU_TSC_SCALE 1 /* attribute for TSC scaling factor */ + +struct kvm_vcpu_tsc_scale { + __u64 tsc_ratio; + __u64 tsc_frac_bits; +}; /* x86-specific KVM_EXIT_HYPERCALL flags. */ #define KVM_EXIT_HYPERCALL_LONG_MODE _BITULL(0) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 2039bd8518fb..26b4649dfb94 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5935,6 +5935,9 @@ static int kvm_arch_tsc_has_attr(struct kvm_vcpu *vcpu, case KVM_VCPU_TSC_OFFSET: r = 0; break; + case KVM_VCPU_TSC_SCALE: + r = kvm_caps.has_tsc_control ? 0 : -ENXIO; + break; default: r = -ENXIO; } @@ -5955,6 +5958,21 @@ static int kvm_arch_tsc_get_attr(struct kvm_vcpu *vcpu, break; r = 0; break; + case KVM_VCPU_TSC_SCALE: { + struct kvm_vcpu_tsc_scale scale; + + r = -ENXIO; + if (!kvm_caps.has_tsc_control) + break; + + scale.tsc_ratio = vcpu->arch.l1_tsc_scaling_ratio; + scale.tsc_frac_bits = kvm_caps.tsc_scaling_ratio_frac_bits; + r = -EFAULT; + if (copy_to_user(uaddr, &scale, sizeof(scale))) + break; + r = 0; + break; + } default: r = -ENXIO; } @@ -5994,6 +6012,9 @@ static int kvm_arch_tsc_set_attr(struct kvm_vcpu *vcpu, r = 0; break; } + case KVM_VCPU_TSC_SCALE: + r = kvm_caps.has_tsc_control ? -EINVAL : -ENXIO; + break; default: r = -ENXIO; } diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index fb935ae3bf38..90568ab631d7 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -106,6 +106,7 @@ TEST_GEN_PROGS_x86 += x86/pmu_event_filter_test TEST_GEN_PROGS_x86 += x86/private_mem_conversions_test TEST_GEN_PROGS_x86 += x86/private_mem_kvm_exits_test TEST_GEN_PROGS_x86 += x86/pvclock_test +TEST_GEN_PROGS_x86 += x86/pvclock_migration_test TEST_GEN_PROGS_x86 += x86/set_boot_cpu_id TEST_GEN_PROGS_x86 += x86/set_sregs_test TEST_GEN_PROGS_x86 += x86/smaller_maxphyaddr_emulation_test diff --git a/tools/testing/selftests/kvm/x86/pvclock_migration_test.c b/tools/testing/selftests/kvm/x86/pvclock_migration_test.c new file mode 100644 index 000000000000..3b675827aec3 --- /dev/null +++ b/tools/testing/selftests/kvm/x86/pvclock_migration_test.c @@ -0,0 +1,383 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Test KVM clock precision across simulated live migration. + * + * Verifies that the documented TSC migration procedure (using + * KVM_VCPU_TSC_OFFSET, KVM_VCPU_TSC_SCALE, KVM_GET_CLOCK, and + * KVM_SET_CLOCK_GUEST) preserves the kvmclock's relationship to + * CLOCK_MONOTONIC_RAW. + * + * The test: + * 1. Creates a VM, runs the guest to enable kvmclock + * 2. Does a PTP-like ABA measurement of kvmclock vs CLOCK_MONOTONIC_RAW + * 3. Follows the documented migration procedure (same host, 1s pause) + * 4. Does the same ABA measurement on the destination VM + * 5. Verifies the kvmclock-vs-monotonic delta is preserved + */ +#include +#include +#include +#include +#include +#include + +#include "test_util.h" +#include "kvm_util.h" +#include "processor.h" + +#include + +#define KVMCLOCK_GPA 0xc0000000ULL + +static void guest_code(void) +{ + wrmsr(MSR_KVM_SYSTEM_TIME_NEW, KVMCLOCK_GPA | 1); + GUEST_SYNC(0); + GUEST_SYNC(1); +} + +static uint64_t read_kvmclock_ns(struct kvm_vm *vm) +{ + struct kvm_clock_data data = {}; + + vm_ioctl(vm, KVM_GET_CLOCK, &data); + return data.clock; +} + +static uint64_t pvclock_read_cycles(struct pvclock_vcpu_time_info *src, + uint64_t tsc) +{ + uint64_t delta = tsc - src->tsc_timestamp; + uint64_t ns; + + if (src->tsc_shift >= 0) + delta <<= src->tsc_shift; + else + delta >>= -(int32_t)src->tsc_shift; + + ns = (unsigned __int128)delta * src->tsc_to_system_mul >> 32; + return src->system_time + ns; +} + +/* + * ABA measurement: read CLOCK_MONOTONIC_RAW, kvmclock, CLOCK_MONOTONIC_RAW. + * Repeat 3 times, keep the reading with the smallest spread. + */ +static void aba_reading(struct kvm_vm *vm, uint64_t *lo, uint64_t *kvm_ns, + uint64_t *hi) +{ + uint64_t best_spread = UINT64_MAX; + int i; + + for (i = 0; i < 3; i++) { + struct timespec ts1, ts2; + uint64_t m1, m2, clk; + + clock_gettime(CLOCK_MONOTONIC_RAW, &ts1); + clk = read_kvmclock_ns(vm); + clock_gettime(CLOCK_MONOTONIC_RAW, &ts2); + + m1 = ts1.tv_sec * 1000000000ULL + ts1.tv_nsec; + m2 = ts2.tv_sec * 1000000000ULL + ts2.tv_nsec; + + if (m2 - m1 < best_spread) { + best_spread = m2 - m1; + *lo = m1; + *kvm_ns = clk; + *hi = m2; + } + } +} + +static struct kvm_vm *create_vm(struct kvm_vcpu **vcpu) +{ + struct kvm_vm *vm = vm_create_with_one_vcpu(vcpu, guest_code); + + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, + KVMCLOCK_GPA, 1, 1, 0); + virt_map(vm, KVMCLOCK_GPA, KVMCLOCK_GPA, 1); + return vm; +} + +int main(void) +{ + struct pvclock_vcpu_time_info pvti_src; + struct kvm_clock_data clock_src, clock_dst; + struct kvm_vcpu_tsc_scale scale_src, scale_dst; + struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + struct ucall uc; + uint64_t mono_before, kvm_before, kvm_after; + int64_t delta_before; + uint64_t ofs_src, tsc_src, tsc_dst, raw_dst, ofs_dst; + uint64_t host_tsc_src, host_tsc_dst; + uint64_t time_src, time_dst; + int64_t delta_t; + uint32_t freq_khz = 1500000; /* 1.5 GHz — forces TSC scaling */ + int ret; + + TEST_REQUIRE(sys_clocksource_is_based_on_tsc()); + TEST_REQUIRE(kvm_has_cap(KVM_CAP_TSC_CONTROL)); + + /* === SOURCE SIDE === */ + pr_info("=== Source VM ===\n"); + vm = create_vm(&vcpu); + + /* Set guest TSC frequency (may trigger scaling) */ + vcpu_ioctl(vcpu, KVM_SET_TSC_KHZ, (void *)(unsigned long)freq_khz); + + /* Run guest to enable kvmclock */ + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + TEST_ASSERT_EQ(get_ucall(vcpu, &uc), UCALL_SYNC); + + /* ABA measurement: kvmclock vs CLOCK_MONOTONIC_RAW */ + uint64_t src_mono_lo, src_mono_hi; + aba_reading(vm, &src_mono_lo, &kvm_before, &src_mono_hi); + mono_before = (src_mono_lo + src_mono_hi) / 2; + delta_before = (int64_t)(kvm_before - mono_before); + pr_info(" kvmclock - MONOTONIC_RAW = %" PRId64 " ns (±%" PRIu64 " ns)\n", + delta_before, (src_mono_hi - src_mono_lo) / 2); + + /* Step 1: KVM_GET_CLOCK for atomic {host_tsc, realtime} */ + memset(&clock_src, 0, sizeof(clock_src)); + clock_src.flags = KVM_CLOCK_REALTIME; + vm_ioctl(vm, KVM_GET_CLOCK, &clock_src); + host_tsc_src = clock_src.host_tsc; + time_src = clock_src.realtime; + + /* Step 2: Save TSC offset and scale */ + { + struct kvm_device_attr attr = { + .group = KVM_VCPU_TSC_CTRL, + .attr = KVM_VCPU_TSC_OFFSET, + .addr = (uint64_t)(uintptr_t)&ofs_src, + }; + vcpu_ioctl(vcpu, KVM_GET_DEVICE_ATTR, &attr); + } + { + struct kvm_device_attr attr = { + .group = KVM_VCPU_TSC_CTRL, + .attr = KVM_VCPU_TSC_SCALE, + .addr = (uint64_t)(uintptr_t)&scale_src, + }; + memset(&scale_src, 0, sizeof(scale_src)); + __vcpu_ioctl(vcpu, KVM_GET_DEVICE_ATTR, &attr); + } + + /* Compute guest TSC at Tsrc */ + if (scale_src.tsc_frac_bits) + tsc_src = ((unsigned __int128)host_tsc_src * scale_src.tsc_ratio + >> scale_src.tsc_frac_bits) + ofs_src; + else + tsc_src = host_tsc_src + ofs_src; + + /* Step 3: KVM_GET_CLOCK_GUEST */ + ret = __vcpu_ioctl(vcpu, KVM_GET_CLOCK_GUEST, &pvti_src); + TEST_ASSERT(!ret, "KVM_GET_CLOCK_GUEST failed"); + + pr_info(" TSC freq=%u kHz, offset=%" PRId64 "\n", freq_khz, (int64_t)ofs_src); + + kvm_vm_release(vm); + + /* === PAUSE (simulate migration) === */ + pr_info("=== Pausing 1 second ===\n"); + sleep(1); + + /* === DESTINATION SIDE === */ + pr_info("=== Destination VM ===\n"); + vm = create_vm(&vcpu); + + /* Step 4: KVM_SET_TSC_KHZ */ + vcpu_ioctl(vcpu, KVM_SET_TSC_KHZ, (void *)(unsigned long)freq_khz); + + /* Step 5: KVM_GET_CLOCK for atomic {host_tsc, realtime} pair. + * Master clock is active from vCPU creation. + */ + memset(&clock_dst, 0, sizeof(clock_dst)); + vm_ioctl(vm, KVM_GET_CLOCK, &clock_dst); + host_tsc_dst = clock_dst.host_tsc; + time_dst = clock_dst.realtime; + + /* Step 6: ΔT */ + delta_t = (int64_t)(time_dst - time_src); + + /* Step 7: Compute destination offset */ + { + struct kvm_device_attr attr = { + .group = KVM_VCPU_TSC_CTRL, + .attr = KVM_VCPU_TSC_SCALE, + .addr = (uint64_t)(uintptr_t)&scale_dst, + }; + memset(&scale_dst, 0, sizeof(scale_dst)); + __vcpu_ioctl(vcpu, KVM_GET_DEVICE_ATTR, &attr); + } + + tsc_dst = tsc_src + (uint64_t)((int64_t)freq_khz * delta_t / 1000000LL); + + if (scale_dst.tsc_frac_bits) + raw_dst = (unsigned __int128)host_tsc_dst * scale_dst.tsc_ratio + >> scale_dst.tsc_frac_bits; + else + raw_dst = host_tsc_dst; + + ofs_dst = tsc_dst - raw_dst; + + /* + * The TSC offset delta introduced by using CLOCK_REALTIME to + * estimate elapsed time. On same host, the correct offset is + * ofs_src; the difference is the CLOCK_REALTIME-vs-TSC error. + */ + int64_t tsc_ofs_delta = (int64_t)(ofs_dst - ofs_src); + int64_t tsc_ofs_delta_ns = tsc_ofs_delta * 1000000LL / freq_khz; + pr_info(" Destination TSC offset=%" PRId64 + ", imprecision from CLOCK_REALTIME: %" PRId64 " cycles = %" + PRId64 " ns\n", (int64_t)ofs_dst, tsc_ofs_delta, tsc_ofs_delta_ns); + + /* Set TSC offset */ + { + struct kvm_device_attr attr = { + .group = KVM_VCPU_TSC_CTRL, + .attr = KVM_VCPU_TSC_OFFSET, + .addr = (uint64_t)(uintptr_t)&ofs_dst, + }; + vcpu_ioctl(vcpu, KVM_SET_DEVICE_ATTR, &attr); + } + + /* Step 8: KVM_SET_CLOCK_GUEST */ + ret = __vcpu_ioctl(vcpu, KVM_SET_CLOCK_GUEST, &pvti_src); + TEST_ASSERT(!ret, "KVM_SET_CLOCK_GUEST failed: errno %d", errno); + + /* Run guest to update pvclock page on destination */ + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + TEST_ASSERT_EQ(get_ucall(vcpu, &uc), UCALL_SYNC); + + /* ABA measurement on destination */ + uint64_t mono_lo, mono_hi; + aba_reading(vm, &mono_lo, &kvm_after, &mono_hi); + + /* + * The kvmclock is tied to the guest TSC via SET_CLOCK_GUEST. + * The guest TSC is offset from the correct value by tsc_ofs_delta_ns + * (due to CLOCK_REALTIME imprecision). So the kvmclock should be + * offset from CLOCK_MONOTONIC_RAW by exactly: + * (original delta) + tsc_ofs_delta_ns + * + * The "original delta" has uncertainty from the source ABA spread, + * and the measurement has uncertainty from the destination ABA spread. + * Verify the expected value falls within the combined bounds. + */ + int64_t delta_before_lo = (int64_t)(kvm_before - src_mono_hi); + int64_t delta_before_hi = (int64_t)(kvm_before - src_mono_lo); + int64_t expected_lo = delta_before_lo + tsc_ofs_delta_ns; + int64_t expected_hi = delta_before_hi + tsc_ofs_delta_ns; + int64_t actual_lo = (int64_t)(kvm_after - mono_hi); + int64_t actual_hi = (int64_t)(kvm_after - mono_lo); + + /* Show the shift relative to the source measurement */ + int64_t expected_mid = tsc_ofs_delta_ns; + int64_t expected_err = (int64_t)(src_mono_hi - src_mono_lo) / 2; + int64_t actual_mid = ((actual_lo + actual_hi) / 2) - delta_before; + int64_t actual_err = (int64_t)(mono_hi - mono_lo) / 2; + pr_info(" kvmclock-mono shift: expected %" PRId64 " ns (±%" PRId64 + "), measured %" PRId64 " ns (±%" PRId64 ")\n", + expected_mid, expected_err, actual_mid, actual_err); + + /* The ranges must overlap */ + TEST_ASSERT(expected_hi >= actual_lo && expected_lo <= actual_hi, + "Ranges don't overlap: expected [%" PRId64 ", %" PRId64 + "] measured [%" PRId64 ", %" PRId64 "]", + expected_lo, expected_hi, actual_lo, actual_hi); + + /* + * Direct pvclock verification: read the destination pvclock page + * and verify that computing kvmclock from pvti_src and pvti_dst + * at the same guest TSC gives the same result. + * + * Get an atomic {host_tsc, kvmclock} pair, scale host_tsc to + * guest TSC using KVM_VCPU_TSC_SCALE, then compute kvmclock + * from both pvclock structs. + */ + struct kvm_clock_data clock_now = {}; + vm_ioctl(vm, KVM_GET_CLOCK, &clock_now); + + struct pvclock_vcpu_time_info *pvti_dst = addr_gpa2hva(vm, KVMCLOCK_GPA); + uint64_t host_tsc_now = clock_now.host_tsc; + uint64_t guest_tsc_now; + + if (scale_dst.tsc_frac_bits) + guest_tsc_now = ((unsigned __int128)host_tsc_now * + scale_dst.tsc_ratio >> scale_dst.tsc_frac_bits) + + ofs_dst; + else + guest_tsc_now = host_tsc_now + ofs_dst; + + uint64_t clk_from_src = pvclock_read_cycles(&pvti_src, guest_tsc_now); + uint64_t clk_from_dst = pvclock_read_cycles(pvti_dst, guest_tsc_now); + int64_t pvclock_delta = (int64_t)(clk_from_src - clk_from_dst); + + pr_info(" Pvclock direct: src=%" PRIu64 " dst=%" PRIu64 + " delta=%" PRId64 " ns\n", clk_from_src, clk_from_dst, pvclock_delta); + pr_info(" KVM_GET_CLOCK: %" PRIu64 " ns\n", (uint64_t)clock_now.clock); + + TEST_ASSERT(pvclock_delta >= -2 && pvclock_delta <= 2, + "pvclock src vs dst disagree by %" PRId64 " ns", pvclock_delta); + + /* + * Tight ABA: compare pvclock_read() directly (no ioctl) against + * CLOCK_MONOTONIC_RAW. The spread should be much smaller since + * there's no syscall between the two clock_gettime calls — just + * rdtsc + userspace mul/shift. + */ + uint64_t tight_mono_lo = 0, tight_mono_hi = 0, tight_kvm = 0; + uint64_t tight_best_spread = UINT64_MAX; + for (int i = 0; i < 3; i++) { + struct timespec ts1, ts2; + uint64_t m1, m2, tsc, clk; + + clock_gettime(CLOCK_MONOTONIC_RAW, &ts1); + tsc = rdtsc(); + clock_gettime(CLOCK_MONOTONIC_RAW, &ts2); + + m1 = ts1.tv_sec * 1000000000ULL + ts1.tv_nsec; + m2 = ts2.tv_sec * 1000000000ULL + ts2.tv_nsec; + + /* Scale host TSC to guest TSC */ + if (scale_dst.tsc_frac_bits) + tsc = ((unsigned __int128)tsc * scale_dst.tsc_ratio + >> scale_dst.tsc_frac_bits) + ofs_dst; + else + tsc += ofs_dst; + + clk = pvclock_read_cycles(pvti_dst, tsc); + + if (m2 - m1 < tight_best_spread) { + tight_best_spread = m2 - m1; + tight_mono_lo = m1; + tight_mono_hi = m2; + tight_kvm = clk; + } + } + pr_info(" Tight ABA spread: %" PRIu64 " ns (best of 3)\n", tight_best_spread); + + int64_t tight_expected_lo = delta_before_lo + tsc_ofs_delta_ns; + int64_t tight_expected_hi = delta_before_hi + tsc_ofs_delta_ns; + int64_t tight_actual_lo = (int64_t)(tight_kvm - tight_mono_hi); + int64_t tight_actual_hi = (int64_t)(tight_kvm - tight_mono_lo); + int64_t tight_actual_mid = ((tight_actual_lo + tight_actual_hi) / 2) - delta_before; + int64_t tight_actual_err = (int64_t)(tight_mono_hi - tight_mono_lo) / 2; + + pr_info(" Tight kvmclock-mono shift: expected %" PRId64 + " ns (±%" PRId64 "), measured %" PRId64 " ns (±%" PRId64 ")\n", + expected_mid, expected_err, tight_actual_mid, tight_actual_err); + + TEST_ASSERT(tight_expected_hi >= tight_actual_lo && + tight_expected_lo <= tight_actual_hi, + "Tight ABA ranges don't overlap"); + + kvm_vm_release(vm); + pr_info("PASS: kvmclock offset matches TSC delta from CLOCK_REALTIME" + " (%" PRId64 " ns) within ABA bounds\n", tsc_ofs_delta_ns); + return 0; +} -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:23:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:23:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353908.1609705 (Exim 4.92) (envelope-from ) id 1wflMd-0008E9-3e; Fri, 03 Jul 2026 21:23:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353908.1609705; Fri, 03 Jul 2026 21:23:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMc-0008A0-EG; Fri, 03 Jul 2026 21:23:58 +0000 Received: by outflank-mailman (input) for mailman id 1353908; Fri, 03 Jul 2026 21:23:54 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMY-0007C5-A7 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMX-001XO6-N0; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827d9-5cb7-0a2a0a5109dd-0a2a4505dcf2-44 for ; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a482869-3cb2-0a2a45050019-5a9b5cc79154-3 for ; Fri, 03 Jul 2026 23:23:53 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKc-000000059OA-40uX; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPL-0RPj; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=wRdzvKD2bSU5nsIEUajIFrEJsqOT3VIHViFgVZVhuqk=; b=i2HbQgc8AAYdlD8WujdrvoPn1U qoodV8ewcMdiGBQg69o486bMpQqj3pTV6LFQ+p4lqOS+REgBO5BemjRGoJIYKDskYoX3dzxU/dlWs fn2vzHq+FScArRGbLA7uB4jy7vpg8ka9zk3nmtu49+oDQijwv+s28SVc4L6+1aNJSTs0xpcGVGk+4 PUaalf6n5Bs4BQ+P+PIB8knTn4QDDa19PFHuBjY+s0Xdh5h6LrgJk/Hs3e1pM9yixhVu0mhnBsWjJ q2hW1MEceXMx6MN7p1chCFiOsbQ0DLRYilZs1FhSzRg3dTm8+BBZ+L5AdoSzqbp/un2xzu5DlNmAh h7pBrsWw==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 23/36] KVM: selftests: Add master clock offset test Date: Fri, 3 Jul 2026 22:18:02 +0100 Message-ID: <20260703212145.343527-24-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-c201ff/1783113833-151042B8-9021AFCA/0/0 X-purgate-type: clean X-purgate-size: 8060 From: David Woodhouse Verify that KVM master clock mode remains active when vCPUs have different TSC offsets but the same frequency. Creates three vCPUs, sets one to a different TSC value, and confirms: - KVM_CLOCK_HOST_TSC is set (master clock active) - KVM_CLOCK_TSC_STABLE IS set (master clock ⇒ stable flag) - PVCLOCK_TSC_STABLE_BIT is NOT set (offsets differ) Signed-off-by: David Woodhouse Assisted-by: Kiro (claude-opus-4.6-1m) --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../kvm/x86/masterclock_offset_test.c | 180 ++++++++++++++++++ 2 files changed, 181 insertions(+) create mode 100644 tools/testing/selftests/kvm/x86/masterclock_offset_test.c diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 90568ab631d7..7ecaaf82056e 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -106,6 +106,7 @@ TEST_GEN_PROGS_x86 += x86/pmu_event_filter_test TEST_GEN_PROGS_x86 += x86/private_mem_conversions_test TEST_GEN_PROGS_x86 += x86/private_mem_kvm_exits_test TEST_GEN_PROGS_x86 += x86/pvclock_test +TEST_GEN_PROGS_x86 += x86/masterclock_offset_test TEST_GEN_PROGS_x86 += x86/pvclock_migration_test TEST_GEN_PROGS_x86 += x86/set_boot_cpu_id TEST_GEN_PROGS_x86 += x86/set_sregs_test diff --git a/tools/testing/selftests/kvm/x86/masterclock_offset_test.c b/tools/testing/selftests/kvm/x86/masterclock_offset_test.c new file mode 100644 index 000000000000..88e2bd2edab5 --- /dev/null +++ b/tools/testing/selftests/kvm/x86/masterclock_offset_test.c @@ -0,0 +1,180 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Test that KVM master clock mode works with different TSC offsets + * as long as all vCPUs have the same TSC frequency. + */ +#include +#include + +#include "test_util.h" +#include "kvm_util.h" +#include "processor.h" + +#include + +#define KVMCLOCK_GPA 0xc0000000ull +#define TSC_OFFSET (1000000000ULL) + +static uint64_t pvclock_calc(struct pvclock_vcpu_time_info *pvti, uint64_t guest_tsc) +{ + uint64_t delta = guest_tsc - pvti->tsc_timestamp; + + if (pvti->tsc_shift >= 0) + delta <<= pvti->tsc_shift; + else + delta >>= -(int)pvti->tsc_shift; + + return pvti->system_time + ((__uint128_t)delta * pvti->tsc_to_system_mul >> 32); +} + +static void guest_code(void) +{ + wrmsr(MSR_KVM_SYSTEM_TIME_NEW, KVMCLOCK_GPA | KVM_MSR_ENABLED); + for (;;) + GUEST_SYNC(0); +} + +int main(void) +{ + struct kvm_vcpu *vcpus[3]; + struct kvm_clock_data clock; + struct pvclock_vcpu_time_info pvti[3]; + struct kvm_vm *vm; + uint64_t offset0, host_tsc, clk0, clk2; + int i; + + TEST_REQUIRE(sys_clocksource_is_based_on_tsc()); + + vm = vm_create_with_vcpus(3, guest_code, vcpus); + + TEST_REQUIRE(!__vcpu_has_device_attr(vcpus[0], KVM_VCPU_TSC_CTRL, + KVM_VCPU_TSC_OFFSET)); + + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, + KVMCLOCK_GPA, 1, + vm_calc_num_guest_pages(VM_MODE_DEFAULT, + getpagesize()), 0); + virt_map(vm, KVMCLOCK_GPA, KVMCLOCK_GPA, + vm_calc_num_guest_pages(VM_MODE_DEFAULT, getpagesize())); + + /* Get vCPU 0's default offset and set vCPU 2's offset higher */ + vcpu_device_attr_get(vcpus[0], KVM_VCPU_TSC_CTRL, + KVM_VCPU_TSC_OFFSET, &offset0); + uint64_t offset2 = offset0 + TSC_OFFSET; + vcpu_device_attr_set(vcpus[2], KVM_VCPU_TSC_CTRL, + KVM_VCPU_TSC_OFFSET, &offset2); + + /* Run each vCPU to enable kvmclock (with offset already set) */ + for (i = 0; i < 3; i++) { + vcpu_run(vcpus[i]); + TEST_ASSERT_KVM_EXIT_REASON(vcpus[i], KVM_EXIT_IO); + } + + /* Check master clock is active */ + memset(&clock, 0, sizeof(clock)); + vm_ioctl(vm, KVM_GET_CLOCK, &clock); + pr_info("KVM_GET_CLOCK flags: 0x%x\n", clock.flags); + TEST_ASSERT(clock.flags & KVM_CLOCK_HOST_TSC, + "Master clock should be active, flags=0x%x", clock.flags); + TEST_ASSERT(clock.flags & KVM_CLOCK_TSC_STABLE, + "KVM_CLOCK_TSC_STABLE should be set, flags=0x%x", clock.flags); + + /* Get per-vCPU pvclock in order 0, 2, 1 */ + int order[] = {0, 2, 1}; + for (i = 0; i < 3; i++) { + int idx = order[i]; + __vcpu_ioctl(vcpus[idx], KVM_GET_CLOCK_GUEST, &pvti[idx]); + pr_info("vCPU %d: tsc_timestamp=%lu system_time=%lu " + "mul=%u shift=%d flags=0x%x\n", + idx, (unsigned long)pvti[idx].tsc_timestamp, + (unsigned long)pvti[idx].system_time, + pvti[idx].tsc_to_system_mul, pvti[idx].tsc_shift, + pvti[idx].flags); + } + + /* Read guest TSCs: should see (0+OFF) < 2 < (1+OFF) */ + uint64_t gtsc0 = vcpu_get_msr(vcpus[0], MSR_IA32_TSC); + uint64_t gtsc2 = vcpu_get_msr(vcpus[2], MSR_IA32_TSC); + uint64_t gtsc1 = vcpu_get_msr(vcpus[1], MSR_IA32_TSC); + pr_info("Guest TSCs: vcpu0=%lu vcpu2=%lu vcpu1=%lu\n", + (unsigned long)gtsc0, (unsigned long)gtsc2, (unsigned long)gtsc1); + pr_info("vcpu0+OFF=%lu vcpu1+OFF=%lu\n", + (unsigned long)(gtsc0 + TSC_OFFSET), + (unsigned long)(gtsc1 + TSC_OFFSET)); + TEST_ASSERT(gtsc0 + TSC_OFFSET < gtsc2 && gtsc2 < gtsc1 + TSC_OFFSET, + "Expected (vcpu0+OFF) < vcpu2 < (vcpu1+OFF)"); + + /* PVCLOCK_TSC_STABLE_BIT should NOT be set (offsets differ) */ + TEST_ASSERT(!(pvti[2].flags & PVCLOCK_TSC_STABLE_BIT), + "PVCLOCK_TSC_STABLE_BIT should NOT be set, flags=0x%x", + pvti[2].flags); + + /* Same mul/shift */ + TEST_ASSERT(pvti[0].tsc_to_system_mul == pvti[2].tsc_to_system_mul && + pvti[0].tsc_shift == pvti[2].tsc_shift, + "All vCPUs should have same mul/shift"); + + /* + * Read host TSC once. At this instant: + * vCPU 0 guest TSC = host_tsc + offset0 + * vCPU 2 guest TSC = host_tsc + offset0 + TSC_OFFSET + * Feed each through its pvclock. Expect the same kvmclock. + */ + host_tsc = rdtsc(); + clk0 = pvclock_calc(&pvti[0], host_tsc + offset0); + clk2 = pvclock_calc(&pvti[2], host_tsc + offset0 + TSC_OFFSET); + + pr_info("kvmclock via vCPU 0: %lu ns\n", (unsigned long)clk0); + pr_info("kvmclock via vCPU 2: %lu ns\n", (unsigned long)clk2); + TEST_ASSERT(clk0 == clk2, + "kvmclock from offset vCPUs should match exactly, " + "diff=%ld ns", (long)(clk2 - clk0)); + + pr_info("PASSED: pvclock consistent across offset vCPUs\n"); + + /* + * Now add an hour to the VM kvmclock via KVM_SET_CLOCK, run each + * vCPU to pick up the update, and check they're still in sync. + */ + { +#define ONE_HOUR_NS (3600ULL * NSEC_PER_SEC) + struct kvm_clock_data setclk = { .clock = clock.clock + ONE_HOUR_NS }; + + vm_ioctl(vm, KVM_SET_CLOCK, &setclk); + } + + /* Guest code does GUEST_SYNC then exits — run each to see update */ + for (i = 0; i < 3; i++) { + vcpu_run(vcpus[order[i]]); + TEST_ASSERT_KVM_EXIT_REASON(vcpus[order[i]], KVM_EXIT_IO); + } + + /* Re-read pvclocks */ + for (i = 0; i < 3; i++) + __vcpu_ioctl(vcpus[order[i]], KVM_GET_CLOCK_GUEST, &pvti[order[i]]); + + pr_info("After +1h: vCPU 0 system_time=%lu, vCPU 2 system_time=%lu\n", + (unsigned long)pvti[0].system_time, + (unsigned long)pvti[2].system_time); + TEST_ASSERT(pvti[0].system_time == pvti[2].system_time, + "system_time should still match after KVM_SET_CLOCK"); + + host_tsc = rdtsc(); + clk0 = pvclock_calc(&pvti[0], host_tsc + offset0); + clk2 = pvclock_calc(&pvti[2], host_tsc + offset0 + TSC_OFFSET); + + pr_info("After +1h: kvmclock via vCPU 0: %lu ns\n", (unsigned long)clk0); + pr_info("After +1h: kvmclock via vCPU 2: %lu ns\n", (unsigned long)clk2); + TEST_ASSERT(clk0 == clk2, + "After +1h: kvmclock should still match, diff=%ld ns", + (long)(clk2 - clk0)); + + /* Verify the clock actually moved by ~1 hour */ + TEST_ASSERT(clk0 > ONE_HOUR_NS, + "Clock should be > 1 hour after set, got %lu ns", + (unsigned long)clk0); + + pr_info("PASSED: pvclock still consistent after KVM_SET_CLOCK +1h\n"); + kvm_vm_free(vm); + return 0; +} -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:24:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:24:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353913.1609716 (Exim 4.92) (envelope-from ) id 1wflMf-0000EB-4H; Fri, 03 Jul 2026 21:24:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353913.1609716; Fri, 03 Jul 2026 21:24:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMe-0000Au-72; Fri, 03 Jul 2026 21:24:00 +0000 Received: by outflank-mailman (input) for mailman id 1353913; Fri, 03 Jul 2026 21:23:56 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMa-0007jg-H7 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMZ-000kw0-TV; Fri, 03 Jul 2026 23:23:55 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48286a-2eae-0a2a0a5409dd-0a2a450c8f72-2 for ; Fri, 03 Jul 2026 23:23:55 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48286b-f399-0a2a450c0019-5a9b5cc7a078-3 for ; Fri, 03 Jul 2026 23:23:55 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059O7-0xa8; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001RP0-3AEv; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=shVwq4KBAoPWsH6/R3iiBMGtywtPoLEemfeJh0CtfZs=; b=SkZEUnibqnamMNvwwjyJzispV2 1MAtJAGPw1iTZJIRDZxFsdCIlehr1AJH72HcFSyB3jKCKJfw0Fd90BGAlMMMQdhA236xcz+KnrZt5 J6i/f9vm7aYd6lYLWiOLY+LqdIMG1Ummf9nhQjx/g01cPSSLh5/CKmfSk5kPOmdKGFOhCTL26KmEI ziGIU04PWq+VUBYLPAmIU9CwFFR6ay7jQAr64KUXu8sagOP2LGtLZxu7PLuu1f+oiXbDPU+92cEal OqD64ZglNnmvPA+hnXOyUgFGpeEPFJtjTQHmX1QHmakytiLhcqBRD3DUGTLbIfb+3qld2oG2YjZa1 kKLVzvmg==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 18/36] KVM: x86: Remove implicit rdtsc() from kvm_compute_l1_tsc_offset() Date: Fri, 3 Jul 2026 22:17:57 +0100 Message-ID: <20260703212145.343527-19-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d25034/1783113835-0D526D51-A8B0B7BB/0/0 X-purgate-type: clean X-purgate-size: 2890 From: David Woodhouse Let the callers pass the host TSC value in as an explicit parameter. This leaves some fairly obviously stupid code, which is using this function to compare the guest TSC at some *other* time, with the newly-minted TSC value from rdtsc(). Unless it's being used to measure *elapsed* time, that isn't very sensible. In this case, "obviously stupid" is an improvement over being non-obviously so. No functional change intended. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- arch/x86/kvm/x86.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 0087ddd08e83..0fa2050f4bd4 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2693,11 +2693,12 @@ u64 kvm_scale_tsc(u64 tsc, u64 ratio) return _tsc; } -static u64 kvm_compute_l1_tsc_offset(struct kvm_vcpu *vcpu, u64 target_tsc) +static u64 kvm_compute_l1_tsc_offset(struct kvm_vcpu *vcpu, u64 host_tsc, + u64 target_tsc) { u64 tsc; - tsc = kvm_scale_tsc(rdtsc(), vcpu->arch.l1_tsc_scaling_ratio); + tsc = kvm_scale_tsc(host_tsc, vcpu->arch.l1_tsc_scaling_ratio); return target_tsc - tsc; } @@ -2859,7 +2860,7 @@ static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value) bool synchronizing = false; raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); - offset = kvm_compute_l1_tsc_offset(vcpu, data); + offset = kvm_compute_l1_tsc_offset(vcpu, rdtsc(), data); ns = get_kvmclock_base_ns(); elapsed = ns - kvm->arch.last_tsc_nsec; @@ -2908,7 +2909,7 @@ static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value) } else { u64 delta = nsec_to_cycles(vcpu, elapsed); data += delta; - offset = kvm_compute_l1_tsc_offset(vcpu, data); + offset = kvm_compute_l1_tsc_offset(vcpu, rdtsc(), data); } matched = true; } @@ -4139,7 +4140,8 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info) if (msr_info->host_initiated) { kvm_synchronize_tsc(vcpu, &data); } else if (!vcpu->arch.guest_tsc_protected) { - u64 adj = kvm_compute_l1_tsc_offset(vcpu, data) - vcpu->arch.l1_tsc_offset; + u64 adj = kvm_compute_l1_tsc_offset(vcpu, rdtsc(), data) - + vcpu->arch.l1_tsc_offset; adjust_tsc_offset_guest(vcpu, adj); vcpu->arch.ia32_tsc_adjust_msr += adj; } @@ -5263,7 +5265,7 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) mark_tsc_unstable("KVM discovered backwards TSC"); if (kvm_check_tsc_unstable()) { - u64 offset = kvm_compute_l1_tsc_offset(vcpu, + u64 offset = kvm_compute_l1_tsc_offset(vcpu, rdtsc(), vcpu->arch.last_guest_tsc); kvm_vcpu_write_tsc_offset(vcpu, offset); if (!vcpu->arch.guest_tsc_protected) -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:24:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:24:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353914.1609724 (Exim 4.92) (envelope-from ) id 1wflMg-0000XB-D0; Fri, 03 Jul 2026 21:24:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353914.1609724; Fri, 03 Jul 2026 21:24:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMf-0000Q5-CR; Fri, 03 Jul 2026 21:24:01 +0000 Received: by outflank-mailman (input) for mailman id 1353914; Fri, 03 Jul 2026 21:23:57 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMa-0007jy-HN for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMZ-000kw0-U9; Fri, 03 Jul 2026 23:23:55 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a4827dc-2eae-0a2a0a5409dd-0a2a4509cd18-48 for ; Fri, 03 Jul 2026 23:23:55 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48286b-97e6-0a2a45090019-5a9b5cc79a66-3 for ; Fri, 03 Jul 2026 23:23:55 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059O9-0xpH; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPH-0GfY; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description; bh=R3kolXIrB5v3kRPh3GGJc2upCU64dX2iOOV3hTZ0WFA=; b=EhYBXertXP5my1I9h4kbmXaNIu mnQI9h3PNrFrUq2Sp0GS+koN6FeHP7pXuM9lNKoJUfWQRMl+2GsyT2xxuCu2Lv8UecBHDmVRYOwHJ k5fDVDoCYaKlIgi0r3xyoTp3+mjuIVt1scTHSifB7mML8tKJWZL/ST5mZ4jBe6LgzbTcM+f7wY4nB S313GWO2jTa+j2fze8yAeMLDkAg6rsMu+k7lGr4284yb14qj98f9Tj5J3Lkx7EdZFjrddByve2YLp Gps6d02Cw5BQReD2TWZ0Bvd8I9bhzX3+lsqZcAU35+OtFaq9kj4c0fqgIKv4zHEv9edwvdqAhWX4z IQ7I+QVQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 22/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other Date: Fri, 3 Jul 2026 22:18:01 +0100 Message-ID: <20260703212145.343527-23-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-bad1c0/1783113835-45721986-A5634E7E/0/0 X-purgate-type: clean X-purgate-size: 9939 From: David Woodhouse Previously, a guest writing different TSC values on different vCPUs could force KVM out of master clock mode. With this change, only a frequency mismatch disables master clock. The only ways for non-master-clock mode to happen now are archaic hardware without a TSC-based clocksource, a VMM that sets different TSC frequencies across vCPUs, or a guest using the legacy MSR_KVM_SYSTEM_TIME (which could be addressed in future by simply updating tsc_timestamp more frequently rather than falling out of master clock mode entirely). Running at a different frequency would lead to a systemic skew between the clock(s) as observed by different vCPUs due to arithmetic precision in the scaling. So that should indeed force the clock to be based on the host's CLOCK_MONOTONIC_RAW instead of being in masterclock mode where it is defined by the guest TSC. But when the vCPUs merely have a different TSC *offset*, that's not a problem. The offset is applied to that vCPU's kvmclock->tsc_timestamp field, and it all comes out in the wash. Track frequency matching separately from offset matching using a dedicated freq generation counter (cur_tsc_freq_generation) that only bumps on actual frequency changes. Each vCPU is counted exactly once per freq generation via a per-vCPU this_tsc_freq_generation field, preventing repeated syncs of the same vCPU from falsely re-enabling master clock. Note that the generation-based counting has a known limitation: if all vCPUs are in sync and one changes away and then back again, the other vCPUs are still at the old generation and won't be counted until they sync again (which may never happen). This was always the case for the offset tracking and isn't expected VMM behaviour — although it is the scenario that the VM-wide KVM_SET_TSC_KHZ ioctl was introduced to handle cleanly. While at it, restructure the existing TSC offset generation tracking to use the same pattern: reset counter to zero on new generation, then unconditionally count vCPUs that haven't been seen in this generation. Both counters now use a consistent >= online_vcpus threshold (1-based counting where the reference vCPU is included in the count). Use frequency match for master clock eligibility, and full TSC match (including offset) only for PVCLOCK_TSC_STABLE_BIT, which tells the guest it is safe to skip cross-vCPU monotonicity enforcement. Signed-off-by: David Woodhouse --- arch/x86/include/asm/kvm_host.h | 4 ++ arch/x86/kvm/x86.c | 82 +++++++++++++++++++++++++-------- 2 files changed, 66 insertions(+), 20 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 51d8bcbc2d1d..da9141ea7d7b 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -970,6 +970,7 @@ struct kvm_vcpu_arch { u64 this_tsc_nsec; u64 this_tsc_write; u64 this_tsc_generation; + u64 this_tsc_freq_generation; bool tsc_catchup; bool tsc_always_catchup; s8 virtual_tsc_shift; @@ -1493,6 +1494,9 @@ struct kvm_arch { u64 cur_tsc_offset; u64 cur_tsc_generation; bool all_vcpus_matched_tsc; + bool all_vcpus_matched_freq; + int nr_vcpus_matched_freq; + u64 cur_tsc_freq_generation; int nr_vcpus_matched_tsc; u32 default_tsc_khz; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 83c47fe5c9b8..3a651f5ce2d2 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -2640,30 +2640,55 @@ static inline bool gtod_is_based_on_tsc(int mode) } #endif -static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool new_generation) +static void kvm_track_tsc_matching(struct kvm_vcpu *vcpu, bool update_mclock) { #ifdef CONFIG_X86_64 struct kvm_arch *ka = &vcpu->kvm->arch; struct pvclock_gtod_data *gtod = &pvclock_gtod_data; + bool prev_matched_tsc = ka->all_vcpus_matched_tsc; /* - * To use the masterclock, the host clocksource must be based on TSC - * and all vCPUs must have matching TSCs. Note, the count for matching - * vCPUs doesn't include the reference vCPU, hence "+1". + * Track whether all vCPUs have matching TSC offsets (for + * PVCLOCK_TSC_STABLE_BIT) and matching frequencies (for + * master clock eligibility). + */ + + /* + * A new vCPU might already have incremented ->online_vcpus + * and cause a temporary false negative here. But will then + * call kvm_synchronize_tsc() from kvm_arch_vcpu_postcreate() + * and finish the job. */ - ka->all_vcpus_matched_tsc = (ka->nr_vcpus_matched_tsc + 1 == - atomic_read(&vcpu->kvm->online_vcpus)); + int online = atomic_read(&vcpu->kvm->online_vcpus); + ka->all_vcpus_matched_tsc = (ka->nr_vcpus_matched_tsc >= online); + + update_mclock |= (prev_matched_tsc != ka->all_vcpus_matched_tsc); - bool use_master_clock = ka->all_vcpus_matched_tsc && + /* + * all_vcpus_matched_freq starts true and is cleared when + * __kvm_synchronize_tsc() detects a frequency mismatch. + * Re-enable when all vCPUs have synced with matching frequency. + * If all offsets also match, that implies frequencies match too. + */ + if (ka->all_vcpus_matched_tsc || + ka->nr_vcpus_matched_freq >= online) + ka->all_vcpus_matched_freq = true; + + /* + * To use the masterclock, the host clocksource must be based on TSC + * and all vCPUs must have matching TSC *frequency*. Different offsets + * are fine — each vCPU's pvclock has its own tsc_timestamp that + * accounts for its offset. + */ + bool use_master_clock = ka->all_vcpus_matched_freq && gtod_is_based_on_tsc(gtod->clock.vclock_mode); /* - * Request a masterclock update if the masterclock needs to be toggled - * on/off, or when starting a new generation and the masterclock is - * enabled (compute_guest_tsc() requires the masterclock snapshot to be - * taken _after_ the new generation is created). + * Request a masterclock update if needed: toggling master clock, + * new generation requiring a fresh snapshot, or a change in + * all_vcpus_matched_tsc (to broadcast PVCLOCK_TSC_STABLE_BIT). */ - if ((ka->use_master_clock && new_generation) || + if ((ka->use_master_clock && update_mclock) || (ka->use_master_clock != use_master_clock)) kvm_make_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu); @@ -2818,7 +2843,22 @@ static void __kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 offset, u64 tsc, * Track the TSC frequency, scaling ratio, and offset for the current * generation. These are used to detect matching TSC writes and to * compute the guest TSC from the host clock. + * + * If the frequency changed, master clock mode can no longer be used + * since the kvmclock scaling factors differ between vCPUs. */ + if (vcpu->arch.virtual_tsc_khz != kvm->arch.cur_tsc_khz) { + kvm->arch.cur_tsc_freq_generation++; + kvm->arch.all_vcpus_matched_freq = false; + kvm->arch.nr_vcpus_matched_freq = 0; + } + + /* Count each vCPU once per freq generation */ + if (vcpu->arch.this_tsc_freq_generation != kvm->arch.cur_tsc_freq_generation) { + vcpu->arch.this_tsc_freq_generation = kvm->arch.cur_tsc_freq_generation; + kvm->arch.nr_vcpus_matched_freq++; + } + kvm->arch.cur_tsc_khz = vcpu->arch.virtual_tsc_khz; kvm->arch.cur_tsc_scaling_ratio = vcpu->arch.l1_tsc_scaling_ratio; @@ -2835,17 +2875,18 @@ static void __kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 offset, u64 tsc, * exact software computation in compute_guest_tsc() */ kvm->arch.cur_tsc_generation++; + kvm->arch.all_vcpus_matched_tsc = false; + kvm->arch.nr_vcpus_matched_tsc = 0; kvm->arch.cur_tsc_nsec = ns; kvm->arch.cur_tsc_write = tsc; kvm->arch.cur_tsc_offset = offset; - kvm->arch.nr_vcpus_matched_tsc = 0; - kvm->arch.all_vcpus_matched_tsc = false; - } else if (vcpu->arch.this_tsc_generation != kvm->arch.cur_tsc_generation) { + } + + if (vcpu->arch.this_tsc_generation != kvm->arch.cur_tsc_generation) { + vcpu->arch.this_tsc_generation = kvm->arch.cur_tsc_generation; kvm->arch.nr_vcpus_matched_tsc++; } - /* Keep track of which generation this VCPU has synchronized to */ - vcpu->arch.this_tsc_generation = kvm->arch.cur_tsc_generation; vcpu->arch.this_tsc_nsec = kvm->arch.cur_tsc_nsec; vcpu->arch.this_tsc_write = kvm->arch.cur_tsc_write; @@ -3172,7 +3213,7 @@ static void pvclock_update_vm_gtod_copy(struct kvm *kvm) bool host_tsc_clocksource, vcpus_matched; lockdep_assert_held(&kvm->arch.tsc_write_lock); - vcpus_matched = ka->all_vcpus_matched_tsc; + vcpus_matched = ka->all_vcpus_matched_freq; /* * If the host uses TSC clock, then passthrough TSC as stable @@ -3503,7 +3544,7 @@ int kvm_guest_time_update(struct kvm_vcpu *v) /* If the host uses TSC clocksource, then it is stable */ hv_clock.flags = 0; - if (use_master_clock) + if (use_master_clock && ka->all_vcpus_matched_tsc) hv_clock.flags |= PVCLOCK_TSC_STABLE_BIT; if (vcpu->pv_time.active) { @@ -6334,7 +6375,7 @@ static int kvm_vcpu_ioctl_get_clock_guest(struct kvm_vcpu *v, void __user *argp) hv_clock.tsc_shift = vcpu->pvclock_tsc_shift; hv_clock.tsc_to_system_mul = vcpu->pvclock_tsc_mul; - hv_clock.flags = PVCLOCK_TSC_STABLE_BIT; + hv_clock.flags = ka->all_vcpus_matched_tsc ? PVCLOCK_TSC_STABLE_BIT : 0; if (copy_to_user(argp, &hv_clock, sizeof(hv_clock))) return -EFAULT; @@ -13641,6 +13682,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) ratelimit_state_init(&kvm->arch.kvmclock_update_rs, HZ, 10); ratelimit_set_flags(&kvm->arch.kvmclock_update_rs, RATELIMIT_MSG_ON_RELEASE); kvm->arch.kvmclock_offset = -get_kvmclock_base_ns(); + kvm->arch.all_vcpus_matched_freq = true; raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); pvclock_update_vm_gtod_copy(kvm); -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:24:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:24:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353915.1609731 (Exim 4.92) (envelope-from ) id 1wflMi-0000rX-13; Fri, 03 Jul 2026 21:24:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353915.1609731; Fri, 03 Jul 2026 21:24:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMg-0000mz-Ut; Fri, 03 Jul 2026 21:24:02 +0000 Received: by outflank-mailman (input) for mailman id 1353915; Fri, 03 Jul 2026 21:23:58 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMb-0007x2-Fl for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:23:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMa-00CejO-SH; Fri, 03 Jul 2026 23:23:56 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a482835-bab6-0a2a0a5309dd-0a2a45038b46-28 for ; Fri, 03 Jul 2026 23:23:56 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48286c-ec1a-0a2a45030019-5a9b5cc7915c-3 for ; Fri, 03 Jul 2026 23:23:56 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKd-000000059O5-3OG6; Fri, 03 Jul 2026 21:23:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKW-00000001ROq-2d0k; Fri, 03 Jul 2026 22:21:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=mU5wFjlLT83r2DMLYPo2Un7WZ36IERFw89f8aTvqSMA=; b=pLhCX7LKJ9jL0Egq3v1CQ2lbNB 6geYPA9+pnJQWRXzcRMfmIi6LmGdMv7pThTm9NBNqZ3oV/CLIRofkA9ghaM+kloYstTg6rGJ/uqbr GnQswAHHEQt//Hy0gqdhdsn2erC1pWE0fd77SkDgRHk6MqST5sk0bwspbMRnNR5szbd7Ymj8VJCst YU9p6hcjeyn6NnLTlQsfhXC1nz4OCMMSxlp07pY7lLsSATOEAODpqxY33VaH+awEptGUnxzsC6wQA YeA0u9LEqIHNkVIvkPfmzrOZ2vz+0FVTFKbgwlsKGY+yYpSVLKz1UcRj/XZobe/0Q+GwKKYcpYyCW 9ykmkL4g==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 16/36] KVM: x86: Restructure kvm_guest_time_update() for TSC upscaling Date: Fri, 3 Jul 2026 22:17:55 +0100 Message-ID: <20260703212145.343527-17-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1783113836-BD1BE5D1-951A7974/0/0 X-purgate-type: clean X-purgate-size: 4893 From: David Woodhouse Restructure kvm_guest_time_update() so that kernel_ns/host_tsc are always "now" when doing TSC catchup, then swap in the master clock reference values afterward for the hv_clock. This makes the TSC upscaling code considerably simpler: the catchup adjustment is computed as the delta between what the guest TSC *should* be at "now" and what it actually is, rather than mixing "now" and "master clock reference" timestamps. The seqcount loop now also contains the kvm_get_time_and_clockread() call (matching get_kvmclock's pattern). Based on a suggestion by Sean Christopherson. Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 78 ++++++++++++++++++++++++++++++++-------------- 1 file changed, 54 insertions(+), 24 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 55fb19fb7a88..9dc4213f0fa5 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3349,45 +3349,60 @@ static void kvm_setup_guest_pvclock(struct pvclock_vcpu_time_info *ref_hv_clock, int kvm_guest_time_update(struct kvm_vcpu *v) { struct pvclock_vcpu_time_info hv_clock = {}; - unsigned long flags; u64 tgt_tsc_hz; unsigned seq; struct kvm_vcpu_arch *vcpu = &v->arch; struct kvm_arch *ka = &v->kvm->arch; s64 kernel_ns; u64 tsc_timestamp, host_tsc; + u64 master_host_tsc = 0; + s64 master_kernel_ns = 0; + s64 kvmclock_offset = 0; bool use_master_clock; - kernel_ns = 0; - host_tsc = 0; - /* * If the host uses TSC clock, then passthrough TSC as stable * to the guest. */ do { seq = read_seqcount_begin(&ka->pvclock_sc); + use_master_clock = ka->use_master_clock; + + /* + * The TSC read and the call to get_cpu_tsc_khz() must happen + * on the same CPU. + */ + get_cpu(); + + tgt_tsc_hz = (u64)get_cpu_tsc_khz() * 1000; + +#ifdef CONFIG_X86_64 + if (use_master_clock && + !kvm_get_time_and_clockread(&kernel_ns, &host_tsc) && + !read_seqcount_retry(&ka->pvclock_sc, seq)) + use_master_clock = false; +#endif + + put_cpu(); + if (use_master_clock) { - host_tsc = ka->master_cycle_now; - kernel_ns = ka->master_kernel_ns; + master_host_tsc = ka->master_cycle_now; + master_kernel_ns = ka->master_kernel_ns; + } else { + local_irq_disable(); + host_tsc = rdtsc(); + kernel_ns = get_kvmclock_base_ns(); + local_irq_enable(); } + + kvmclock_offset = ka->kvmclock_offset; } while (read_seqcount_retry(&ka->pvclock_sc, seq)); - /* Keep irq disabled to prevent changes to the clock */ - local_irq_save(flags); - tgt_tsc_hz = (u64)get_cpu_tsc_khz() * 1000; if (unlikely(tgt_tsc_hz == 0)) { - local_irq_restore(flags); kvm_make_request(KVM_REQ_CLOCK_UPDATE, v); return 1; } - if (!use_master_clock) { - host_tsc = rdtsc(); - kernel_ns = get_kvmclock_base_ns(); - } - - tsc_timestamp = kvm_read_l1_tsc(v, host_tsc); /* * We may have to catch up the TSC to match elapsed wall clock @@ -3397,17 +3412,32 @@ int kvm_guest_time_update(struct kvm_vcpu *v) * entry to avoid unknown leaps of TSC even when running * again on the same CPU. This may cause apparent elapsed * time to disappear, and the guest to stand still or run - * very slowly. + * very slowly. */ if (vcpu->tsc_catchup) { - u64 tsc = compute_guest_tsc(v, kernel_ns); - if (tsc > tsc_timestamp) { - adjust_tsc_offset_guest(v, tsc - tsc_timestamp); - tsc_timestamp = tsc; - } + s64 adjustment; + + /* + * Calculate the delta between what the guest TSC *should* be + * and what it actually is according to kvm_read_l1_tsc(). + */ + adjustment = compute_guest_tsc(v, kernel_ns) - + kvm_read_l1_tsc(v, host_tsc); + if (adjustment > 0) + adjust_tsc_offset_guest(v, adjustment); } - local_irq_restore(flags); + /* + * Now that TSC upscaling is out of the way, the remaining calculations + * are all relative to the reference time that's placed in hv_clock. + * If the master clock is NOT in use, the reference time is "now". If + * master clock is in use, the reference time comes from there. + */ + if (use_master_clock) { + host_tsc = master_host_tsc; + kernel_ns = master_kernel_ns; + } + tsc_timestamp = kvm_read_l1_tsc(v, host_tsc); /* With all the info we got, fill in the values */ @@ -3427,7 +3457,7 @@ int kvm_guest_time_update(struct kvm_vcpu *v) hv_clock.tsc_shift = vcpu->pvclock_tsc_shift; hv_clock.tsc_to_system_mul = vcpu->pvclock_tsc_mul; hv_clock.tsc_timestamp = tsc_timestamp; - hv_clock.system_time = kernel_ns + v->kvm->arch.kvmclock_offset; + hv_clock.system_time = kernel_ns + kvmclock_offset; vcpu->last_guest_tsc = tsc_timestamp; /* If the host uses TSC clocksource, then it is stable */ -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 03 21:24:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Jul 2026 21:24:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1353952.1609763 (Exim 4.92) (envelope-from ) id 1wflMr-0002vx-QG; Fri, 03 Jul 2026 21:24:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1353952.1609763; Fri, 03 Jul 2026 21:24:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMr-0002uz-GE; Fri, 03 Jul 2026 21:24:13 +0000 Received: by outflank-mailman (input) for mailman id 1353952; Fri, 03 Jul 2026 21:24:12 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wflMp-0002lY-W8 for xen-devel@lists.xenproject.org; Fri, 03 Jul 2026 21:24:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wflMp-00A8LG-Cn; Fri, 03 Jul 2026 23:24:11 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48281d-bab6-0a2a0a5309dd-0a2a4507d556-28 for ; Fri, 03 Jul 2026 23:24:10 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48287a-9c8e-0a2a45070019-5a9b5cc78b72-3 for ; Fri, 03 Jul 2026 23:24:10 +0200 Received: from [2001:8b0:10b:1::425] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKe-000000059OC-0v73; Fri, 03 Jul 2026 21:23:05 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.99.2 #2 (Red Hat Linux)) id 1wflKX-00000001RPn-1wE5; Fri, 03 Jul 2026 22:21:49 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="Sender:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description; bh=cd7ADB+seora88pbKs2aD/tIbj9VePpwMwSL1OtTGjc=; b=apbGiZMkUWlTVRA2dMsajeQnJ0 RhOJ6E89Pg9nZWfqc1RytnC60PxmSbLIc70g2wiX9+ooo+ZTGG+wuRG28iqP40gybMT4pWEYVKG45 IVR/hQwGVcaV0h45HGBgtN2qd4s+8dCM8XetiqvJ905knza/omAjyD5QDeKL2kLEu5tSs9t9rUG0C pUge3V166Jv7ecOVz6xHEpZMkC/QA8i04z7CCvmXPW7GybxZC1kDSoXQr3x1//zaHva65YLoum3ha jySMWli1TzgZTW4U5jDjlS4f0GHvt/pA6S68YpOLver+gZSd/WhlFkM4AA9b5RT7qhPBtTqlM1su1 y/Xr5sFQ==; From: David Woodhouse To: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , David Woodhouse , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Subject: [PATCH v6 30/36] KVM: x86: Re-synchronize TSC after KVM_SET_TSC_KHZ Date: Fri, 3 Jul 2026 22:18:09 +0100 Message-ID: <20260703212145.343527-31-dwmw2@infradead.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260703212145.343527-1-dwmw2@infradead.org> References: <20260703212145.343527-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ef75cf/1783113850-145FC25E-F64A76C9/0/0 X-purgate-type: clean X-purgate-size: 2200 From: David Woodhouse KVM_SET_TSC_KHZ changes the vCPU's TSC scaling ratio but does not update the VM-wide cur_tsc_scaling_ratio used by get_kvmclock(). This causes get_kvmclock() to use a stale (default 1:1) ratio when computing the KVM clock, leading to drift between the host-side kvmclock and what the guest observes. Fix this by calling kvm_synchronize_tsc() after changing the TSC frequency. This: - Updates cur_tsc_scaling_ratio (consumed by pvclock_update_vm_gtod_copy) - Ensures the TSC value is continuous across the frequency change - Triggers kvm_track_tsc_matching() for proper masterclock handling - Allows subsequent vCPUs to synchronize via the 1-second slop hack Signed-off-by: David Woodhouse --- arch/x86/kvm/x86.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 80fe69974ded..37a768b2fe16 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -206,6 +206,7 @@ module_param(mitigate_smt_rsb, bool, 0444); #ifdef CONFIG_X86_64 static bool kvm_get_time_and_clockread(s64 *kernel_ns, u64 *tsc_timestamp); #endif +static void kvm_synchronize_tsc(struct kvm_vcpu *vcpu, u64 *user_value); #define KVM_MAX_NR_USER_RETURN_MSRS 16 struct kvm_user_return_msrs { @@ -2584,6 +2585,7 @@ static int kvm_set_tsc_khz(struct kvm_vcpu *vcpu, u32 user_tsc_khz) { u32 thresh_lo, thresh_hi; int use_scaling = 0; + u64 tsc; /* tsc_khz can be zero if TSC calibration fails */ if (user_tsc_khz == 0) { @@ -2611,7 +2613,17 @@ static int kvm_set_tsc_khz(struct kvm_vcpu *vcpu, u32 user_tsc_khz) user_tsc_khz, thresh_lo, thresh_hi); use_scaling = 1; } - return set_tsc_khz(vcpu, user_tsc_khz, use_scaling); + /* + * Read the guest TSC before changing the ratio, so we can + * re-synchronize to preserve continuity across the change. + */ + tsc = kvm_read_l1_tsc(vcpu, rdtsc()); + + if (set_tsc_khz(vcpu, user_tsc_khz, use_scaling)) + return -1; + + kvm_synchronize_tsc(vcpu, &tsc); + return 0; } static u64 compute_guest_tsc(struct kvm_vcpu *vcpu, s64 kernel_ns) -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Sat Jul 04 12:19:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Jul 2026 12:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1354331.1609770 (Exim 4.92) (envelope-from ) id 1wfzKQ-0006Wo-Cx; Sat, 04 Jul 2026 12:18:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1354331.1609770; Sat, 04 Jul 2026 12:18:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfzKQ-0006Wg-9W; Sat, 04 Jul 2026 12:18:38 +0000 Received: by outflank-mailman (input) for mailman id 1354331; Sat, 04 Jul 2026 12:18:36 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wfzKO-0006Wa-UN for xen-devel@lists.xenproject.org; Sat, 04 Jul 2026 12:18:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wfzKO-002eU2-BK for xen-devel@lists.xenproject.org; Sat, 04 Jul 2026 14:18:36 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a48f9eb-bab6-0a2a0a5309dd-0a2a4505d6b8-34 for ; Sat, 04 Jul 2026 14:18:35 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a48fa19-3cb2-0a2a45050019-888fbc3352b3-3 for ; Sat, 04 Jul 2026 14:18:35 +0200 Received: by mx.zohomail.com with SMTPS id 1783167502132933.2922733573388; Sat, 4 Jul 2026 05:18:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1783167505; cv=none; d=zohomail.com; s=zohoarc; b=EfZ9cGjuuv37D6ppIlfjx5EWNVOZLItHTlo2+Y2K7x9cGFZeI9S1RZATbtdhq1o6vDNeU1sRTwRVPO0EsdLekXQv7zFgGGGAl+dmPJnbxS1HyUeCypznftabO8yRYJgwok5PBGmAe/enqeMAjx9A0T110IfGKica3BRn8vfwKgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783167505; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=nvPyqzORMvUik+ZDU3iWG4TakUWWBCyUbCCHGUSGanU=; b=nPafiV32pAQA0w9x0f04xLvE3aVCmBt61a/FUdGukPWoMk1Y/Tkj65eh31SxRQEIUpPCU/Cws1YBjYfE269Sbu1ORWuYyPnUX4Jyg2HptcUbj15M98/Rx+LbkMKSmJqWTy3GnTAfC2U0yslYRmaH9534/eKjdLKTEi+Tthn880s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1783167505; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=nvPyqzORMvUik+ZDU3iWG4TakUWWBCyUbCCHGUSGanU=; b=SaAUPL01Q9G13nzfQyeUgzjEMCA12Nt7pxKRzfiggQBRmmCLWfc3RS5IwZgnOfXg rWMx8a/nyYKnZxanKCVIAcg+dEUVMalK9EXull/ZyyDEjEBB/AcFqFUs2ehmhuduG6l IGgFjJ0JyyZGyr+5lkKsT5WI+xYk76NlTEID0U9c= Message-ID: <0a6e5076-d5d1-4ae7-9f34-07454881301a@apertussolutions.com> Date: Sat, 4 Jul 2026 08:18:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/18] pci: Use pci_sbdf_t in pci_add_device() To: Teddy Astie , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini References: <1782753810.8631fc262581453bbf619ec5b2062170.19f1468572a000701b@vates.tech> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <1782753810.8631fc262581453bbf619ec5b2062170.19f1468572a000701b@vates.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-c201ff/1783167515-0F1142B8-05D1C448/0/0 X-purgate-type: clean X-purgate-size: 2762 On 6/29/26 1:21 PM, Teddy Astie wrote: > Signed-off-by: Teddy Astie > --- > v3: Don't adjust adjacent code. > --- > xen/arch/x86/physdev.c | 6 +++--- > xen/drivers/passthrough/pci.c | 36 +++++++++++++++++------------------ > xen/drivers/pci/physdev.c | 3 ++- > xen/include/xen/pci.h | 4 ++-- > 4 files changed, 24 insertions(+), 25 deletions(-) > > diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c > index 5bbcf3b530..60c02076d6 100644 > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -472,7 +472,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > if ( copy_from_guest(&manage_pci, arg, 1) != 0 ) > break; > > - ret = pci_add_device(0, manage_pci.bus, manage_pci.devfn, > + ret = pci_add_device(PCI_SBDF(0, manage_pci.bus, manage_pci.devfn), > NULL, NUMA_NO_NODE); > break; > } > @@ -503,8 +503,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > pdev_info.is_virtfn = manage_pci_ext.is_virtfn; > pdev_info.physfn.bus = manage_pci_ext.physfn.bus; > pdev_info.physfn.devfn = manage_pci_ext.physfn.devfn; > - ret = pci_add_device(0, manage_pci_ext.bus, > - manage_pci_ext.devfn, > + ret = pci_add_device(PCI_SBDF(0, manage_pci_ext.bus, > + manage_pci_ext.devfn), > &pdev_info, NUMA_NO_NODE); > break; > } > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 0adf573150..3038827e28 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -662,12 +662,11 @@ unsigned int pci_size_mem_bar(pci_sbdf_t sbdf, unsigned int pos, > return is64bits ? 2 : 1; > } > > -int pci_add_device(u16 seg, u8 bus, u8 devfn, > - const struct pci_dev_info *info, nodeid_t node) > +int pci_add_device(pci_sbdf_t sbdf, const struct pci_dev_info *info, nodeid_t node) > { > struct pci_seg *pseg; > struct pci_dev *pdev; > - unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn); > + unsigned int slot = sbdf.devfn, func = sbdf.fn; > const char *type; > int ret; > > @@ -680,17 +679,17 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, > else > type = "device"; > > - ret = xsm_resource_plug_pci(XSM_PRIV, (seg << 16) | (bus << 8) | devfn); > + ret = xsm_resource_plug_pci(XSM_PRIV, sbdf.sbdf); > if ( ret ) > return ret; Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Jul 05 05:45:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Jul 2026 05:45:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1354501.1609802 (Exim 4.92) (envelope-from ) id 1wgFfn-0003LX-1S; Sun, 05 Jul 2026 05:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1354501.1609802; Sun, 05 Jul 2026 05:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wgFfm-0003Iz-Qe; Sun, 05 Jul 2026 05:45:46 +0000 Received: by outflank-mailman (input) for mailman id 1354501; Sat, 04 Jul 2026 18:33:07 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wg5Ao-0000S2-Up for xen-devel@lists.xenproject.org; Sat, 04 Jul 2026 18:33:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wg5Ao-0048ji-Af for xen-devel@lists.xenproject.org; Sat, 04 Jul 2026 20:33:06 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a49518c-bab6-0a2a0a5309dd-0a2a45058334-36 for ; Sat, 04 Jul 2026 20:33:06 +0200 Received: from [205.220.180.131] (helo=mx0b-0031df01.pphosted.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a4951e0-3cb2-0a2a45050019-cddcb4834ccc-3 for ; Sat, 04 Jul 2026 20:33:05 +0200 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 664GTV313485933 for ; Sat, 4 Jul 2026 18:33:04 GMT Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s64hgtw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 04 Jul 2026 18:33:04 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c88da04b719so1050728a12.2 for ; Sat, 04 Jul 2026 11:33:03 -0700 (PDT) Received: from [192.168.1.100] ([151.243.38.149]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b6057dsm1508437b3a.7.2026.07.04.11.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 11:33:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=qcppdkim1 header.d=qualcomm.com header.i="@qualcomm.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-Id:MIME-Version:References:Subject:To"; dkim=pass header.s=google header.d=oss.qualcomm.com header.i="@oss.qualcomm.com" header.h="Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eQ2wkGh9OQFPGIh6+CsATSCyNIJhVVQjedvP3yUcR8I=; b=piotc2XuZr1Bos25 5+otg4KB3av2dGCjMnxed7l9UNU1sVMI2kUsiZRBoFsmF86yqMxA6CL0XqY4mJKJ uLWJ26w7JLB6hTr5Y3blAe6hFdllG5Aab+MVAsOysh3S6GhGS15NxNYaOuz0dnQJ htQBNF/gMJPFMGVxcqqLNF37XPK2aFHwhZSIAVMt9dTDs/ETvdinooP5J+47b0Hm Q9ekeu9T31+WduIFfsCcgQWiIX9OcelaDpS/L77sJM9YzYgVG060Xug0K2nH30TX Es+o2G8e7KL9jEKWjSOVlMEZrqiwc2DJvPfilJZMgXagYwb30oTfgLMCrpBA6syy Ia0rew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783189983; x=1783794783; darn=lists.xenproject.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eQ2wkGh9OQFPGIh6+CsATSCyNIJhVVQjedvP3yUcR8I=; b=Hh8YgH50MW3etcmtb0mMNOL4gJ8rm4z+l1y9qXyqCosuVQrlAMKttOkT+FdOEo2ajJ vVa1kPGAOGdsDu6s3k0J4zTyTdusQZvCn4/4F1r7iBK6P/Li79Rc3x77zAu4MS7qPo6L ZWvBgPkPtvSSYQf+SI86DENYv8kOD1jdtIXFEeG3Gz89mApTsjAO/dLNQxC9VN7eXs0Y oBpt5XaJFch3b+s35DZOMkPBHS2qym3cWDngKOHXAfx+d1oc6SZxC9ZmMTF/58kNARIY cYdooIbrxMA983aiflWjimVU7k66rO5RPl/r5VZ8q7F2LXfPTwkqJcAdS1EcEuHO+SJu CIPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783189983; x=1783794783; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eQ2wkGh9OQFPGIh6+CsATSCyNIJhVVQjedvP3yUcR8I=; b=UfiF1k6o0y3pJ0YMYeeaA7MpGPY+CDJs4/idj43Qq80r6XS7gcOeZ16NvgeH4xjNuF wp1vcSb2vgR4zPuWplJB4/RRbyXPSbukKOmccXQ8gWomG8IK0rmm+D5oRa5bPj9Yk8Nf yb6Q5aV7EN72viqIC4sxqFIRyjdyPU3Aqb8p9WrhtMD024DG//MnfDcDTEhES7ybGYzg 9tGL5TWG5/RX4HV6P/Mk4vrGfXUhMiNtoNkJeaqtWZwEHyHYyMfYLbTm+ZK66pv7SXN8 bQzgoIeMs+uyga0iiTD989CJ4VI1BpPkW/qWg26pxkyAQvOAiXDB/FnEMKr8iDtQIZzd YVCA== X-Forwarded-Encrypted: i=1; AHgh+RogtXkfBY2wY2XCTHPwoy8M3Haz/Jtw8bPJiERS5MZwBB5NYhl9kE70A4AgsjvPxDIQrEE2Miaxr4M=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz2bJnEp851j1KoQC35kAj6Pap8FV12ZjDq2j11loqwxbSpvyZm UsINGtzQy/ASLnARGNcr2sfRCJFoiW1MYX/gL8qy3f83Dq25q2Rns2HKoJ/qJm95zQNWmpymgH2 dvViItlb/vv0MOnykGTn2RErAhbierDq0tIIT1dG3e3tLeCcjLyhQeLtH1f2yUNwgYS1WIQ== X-Gm-Gg: AfdE7clMmPZJUF/KvstTetqrKhhDCdzwJQiJr7RAGbdYa016Qckxbz3gqdBcjw9I04b r0wHVEpFSnH0aMqQdZWXbM8WPfPbcN1tSll4GKFVViM9Wl2swVFnh/fMCoE0zJmPkAm3E4ZGSpY DTHDyl9YgGn/LAlo+dPDjks3fcMSIMLqaeUO0ATu9Y881fRzbkYT7apID57XcqmHSV4EKe2e3ue JLSsCHkfI4R5FjIXn1R9rqq9knXggtsqJlYGct133TbFeQfscZ5k5WtdAlCtY/tYAy3AnpvHm4H pdFbOBPrlVBlGV9cE/TqiHpmyCnqkWwBpYOxc8yeHUqhDf4EwW6yeYKGTDwiIfj7LZjaWIPAUuK 8fXtb7UXgdmUQbsOCoKPN5FE= X-Received: by 2002:a05:6a00:330c:b0:847:7f7a:dd18 with SMTP id d2e1a72fcca58-847f6d663f2mr3781696b3a.3.1783189982984; Sat, 04 Jul 2026 11:33:02 -0700 (PDT) X-Received: by 2002:a05:6a00:330c:b0:847:7f7a:dd18 with SMTP id d2e1a72fcca58-847f6d663f2mr3781665b3a.3.1783189982458; Sat, 04 Jul 2026 11:33:02 -0700 (PDT) From: Ze Huang Date: Sun, 05 Jul 2026 02:31:13 +0800 Subject: [PATCH 4/9] drm/mcde: replace struct drm_simple_display_pipe with regular atomic helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260705-drm-simple-kms-removal-v1-4-b4e1ca053623@oss.qualcomm.com> References: <20260705-drm-simple-kms-removal-v1-0-b4e1ca053623@oss.qualcomm.com> In-Reply-To: <20260705-drm-simple-kms-removal-v1-0-b4e1ca053623@oss.qualcomm.com> To: Alexey Brodkin , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Hans de Goede , Alex Lanzano , Oleksandr Andrushchenko Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, xen-devel@lists.xenproject.org, Ze Huang X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783189912; l=10718; i=ze.huang@oss.qualcomm.com; s=20260704; h=from:subject:message-id; bh=Qcol9fj3wcEepZH3ImnK7lH90wrvdzfXhAcRLociBUs=; b=Mx6Ue7MKCfC0JMWj0BrhEUBH/ynLrlUW5+zwyXd6XNRIoOn78c9YTfhlfyKIIkBbAjhKd8rqo rj42P/bhNkcBIPjnFtFAre0a4wkLVPMpB+ZD6+uq3vfaTAz3vXXq5qV X-Developer-Key: i=ze.huang@oss.qualcomm.com; a=ed25519; pk=pSsISLZF2ubEjJRmslsa6Ps4W3yAuPY7yaircQTlQQU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA0MDE5MiBTYWx0ZWRfXwNh5sHsQQjJf fqjZjt2YMGMNk1inD3ykBDFmReAEL3BzKmCheJoIQ4Kg+AxVYHIHuZee6S6f4EwHlqpxN5xb8sD y8x1t/Kiq24KXlbhzpzzHoPeYdcPUtsHOOHYgP5+VrsPYCAGGInZE6Sz2mkiir8m0nCLw7bM6Oy oQlshX/mXYBhYVLcUgLpdyFaWPNoVAG4n2DZ7U7mm1RA+cM0d96zfYskvdl09eA6dXfOrt9d5az xkW3gkYst1xjioIC5NTLPvUsCSAor1Js/P44MJB0gBxrv2NEG3brH7Dro6UuAeYTuSBaZU4VZGL BJRsQRXrjyEw7pMscv86fmuEuqppqHEMyGoyokwJ7leYPfxjeBooHU7CjnTQYM433Z83YYNhS+j hZcsF9lN/5Yvgimvcb8DJq4PVWXuIoY5ENdEb+rSe5vgB3GYVkX9qglmiPG9yEo5Kb10kISJZys moqQVzfx5JC9u6zsaKw== X-Authority-Analysis: v=2.4 cv=VvITxe2n c=1 sm=1 tr=0 ts=6a4951e0 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=cNux22OjBTKCC6TmznXXXA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=T3BUC5bxBd2b0rxqrJgA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: Ig7xOkd75prW22cNA6v3IqdQQyk2rcLX X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA0MDE5MiBTYWx0ZWRfX6HHiO1Rs+bAP 4an3C/RKMnxrZETM2l6vb8wp0hRYylPER7kFYi2iGIpil83OPE0AZ8I69W8/Op+tSqah1p+CeGF SDKg96UbsEm8OzJz3pWnxX9iI3sFR7U= X-Proofpoint-GUID: Ig7xOkd75prW22cNA6v3IqdQQyk2rcLX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-04_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1011 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607040192 X-purgate-ID: tlsNG-c201ff/1783189985-0E7132B8-CC17D6E1/0/0 X-purgate-type: clean X-purgate-size: 10720 Convert MCDE to explicit plane, CRTC and encoder objects. Keep FIFO, event and framebuffer update sequencing intact, and install GEM framebuffer prepare callback explicitly. Signed-off-by: Ze Huang --- drivers/gpu/drm/mcde/mcde_display.c | 162 +++++++++++++++++++++++++++--------- drivers/gpu/drm/mcde/mcde_drm.h | 6 +- drivers/gpu/drm/mcde/mcde_drv.c | 3 +- 3 files changed, 129 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c index 257a6e84dd58..4d86fa5030eb 100644 --- a/drivers/gpu/drm/mcde/mcde_display.c +++ b/drivers/gpu/drm/mcde/mcde_display.c @@ -10,6 +10,7 @@ #include #include +#include #include #include #include @@ -18,7 +19,6 @@ #include #include #include -#include #include #include #include