From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:04:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:04:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379703.1624120 (Exim 4.92) (envelope-from ) id 1wpxD1-00079x-AF; Sat, 01 Aug 2026 00:04:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379703.1624120; Sat, 01 Aug 2026 00:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxD1-00079q-6P; Sat, 01 Aug 2026 00:04:11 +0000 Received: by outflank-mailman (input) for mailman id 1379703; Sat, 01 Aug 2026 00:04:09 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxCy-00079R-TG for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:04:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxCy-00Fh5s-6F for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:04:08 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d37c7-2eae-0a2a0a5409dd-0a2a45089e78-22 for ; Sat, 01 Aug 2026 02:04:03 +0200 Received: from [98.137.64.84] (helo=sonic305-21.consmr.mail.gq1.yahoo.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d37f2-f659-0a2a45080019-628940548152-3 for ; Sat, 01 Aug 2026 02:04:03 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:04:01 +0000 Received: by hermes--production-ne1-6f6bdbdd7c-rppmz (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c7608ec2cac0a95d3d8faa6ec551e65c; Sat, 01 Aug 2026 00:03:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785542641; bh=ScxuLdCEEpt8xcvaZGVm8pblnaaeCXt2k3SUmUrCDDQ=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=BtZRziS2ygv2KGOSQFkP5aQBWo2876ju/GKwUxZmxJTPJzhXRwNiuHImAyZgXwr0xAKYD5SgYEx2SKUniLfHDuEPLuswLJCTtCpA2i0PkkN1YbiqxMgFRUe6uNN3bXxEnKaDsIHFIGBtHkvRLqpkyElptwGfyuJd0mrUHfnXUUum2hx5WYpn3bQSaVteWEtDq+wn8rmytq9M2Vf868PZ9j56hWV63DTEFHR4kyell+yDUqCjgXdFubYwUFQkwstPp1aB+/LzsUVWzKItZwT4yTzH077oVan8MvwF8yHMao5zvFqfvJC/zPA1hRrF9gxtfxCGthCf+aAANbBzTZtoYA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785542641; bh=EgevDvieZTrS5c5/q5o0sA8ls7qQ9KS6Qjw0ldsYmTK=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=QUuOUFJzgLja2jgoY0vvNkPuDILYmIpoA6zBTStqTSto/kWhVNX5D+bDyPDneyzeprvmya4CFPG16NDKtATHvw50bgwwVglJQKP+WW5JwT43JLCrdf6B4lnpxQItjso2UxoW8XNiumXHIlK80Y0pFD8a9nUAH/c5yOBDlL4sjEl+GKFOCt7m5+VEpYCk4b4qQIy+a0VGNeTsZLiISJZkeOEFSsBxMX4eChN5SUYoDqNEX1Xly18Tem0RoZCrBWcdO+3PDgb1wxt21dPPzhJIJjuUTea8R6bm6xEwCFV7PMDZxuk7aJCQMc/kt7jkBPwSq7AfOLDNPpP5mMcFytORRQ== X-YMail-OSG: NZZFObAVM1mQ8GuUv0FKMv9ixWb._8avAcvTzthF8BSuwGKlf2uXznS9QLs4qHu cNSuiCa1BGPlLlHPquwa8hkq.Svb8y21.sX5taYNKrwxdRfi1nMpGGeik8E3mDKIBrw5qm3yhp7N JwylAqzYZfc7.i67ygWf27FZ_BCi6BYNSENdrXEtrxfUmuFD2QGpCr2JhDDiS8IIEHBee4qBibkG qmeDyvAJou8JGl39oNojjw6tJ3oWma3PWSl8JsknF4HOd6hVmDBu8qznZlxGJdTvdwry4xssFuvz AMuv3jNMkOYxaXmaT1Jis1ANyveIEArGN_QvsMMaqKcSdTTuDwD.94C_2D1k9Xxt9zUXi5VT2hub XBmQceX6E6X4IEncTk3Lv7X246HrGPdeeu0BbVoSVnPoso_7xM_NsPrV1PTu5pZWZnnXX2nFuq2K 8kRZfSfuBtK2vc4hIhu.rFOdrP50kZ0lAH8ieip29_Cwallgo5aHpabQUfpKf.WyhM4UQnFXiqTj GoZjF_S3eVSL9f4OBS3_JKiAOujJD6BVoY7AqaeQD8omDQMpT6klqGmQPT_3MCJ35ddSKLip0guO Ot6J2NDn4LqHt94gJX22A9cbAECN1NkgIB_l1zchHbPjmqTHxDxCQs0nVb3QUWDzwRvjrX3ytXYF nfOFmY2Jb8Nmd191LbSmUSRLe0tXxZZ915repd.4_pUUIW3SCN3tFKK2IwfxQQ_8XCJezkNLksFn TBu2AIgzCd22pMALioITJmEQQz_2xTlutcgdy.1w7XofZlI6pnlZxNmZR_psdJObbAKTB34gNqFz .TqzvO4R0NCvLps1zTV3PVVoV2hbUq69ezRuWYssjzlsnaE2a9r43Uk1on2aFUsBGd5a71mKFkXv 81RoL20olZdxyX.Xq.5vpF68KIWifctNXs9ErAkakdLCJ911KeYSnlE8QPkP6QogBH3IU0VYwoIR bLaIDLI7p_wJU8cuAhl_PHq.6WW15baogYVq7.kjuvz7e4xevteZXJGXPPhn1NcZZL3d7he9EmX. VesxsFK.4X4MEFdU8fv27Cm4hqMXVRJK7a8mCxqxOd9UnUHkH_thy8HzVEnuCBc4FL90oBAx_7.F xtYFaMQvYRfdzxdFh0XR5L4lnQDc9__WC_uIZ9vg4R9KwDYLyssCAWbPzKTCOX5MyErv.KTGMAI7 Ok8yrG9Lz5fdB3Qj.oZh.QqrUoS.5XnuQcM2.hiUnI8khOq9xuM5fJgEBhOlU2.Z3GmXmsCpRdcs G2T0o5YjXwcmNL7WN4_aHqdhp4sGgE4Ei_TzpQOf9wpio2kRJE8xOMPSNVMpfigE39tDuARi_l_I 6vT.yFuugjxncpY_FFk3sftXGu5.pVfkhZWD9KN1PIJ.5NaQy898Qqf4OVlGrQ2PlgkXGdLWHNlt WCZ0CTk3ibM3qeDfnnYCuiIPoQKVnEpNXkEhSJFCrPoa6c2164tkOm58gyMgRTXSqAIvVupMj7i1 5xkJtCW5r1k4NxY8qcW3zl_MPBlxNA98Df2Pttk8Q.oVXmuzUtqC04jFeVPjVXC7iFN50k1xIRr0 4n0BoAs2HW7v5IY69MfAkGpscSvhj2BEv0ioCCSLH0msIeGmyVneSwUsvU7POwf1W9xt2LADJGIr RzFs16RbnydAQL39dDzo1bVqhsCqUjWRI5HbiOVOjG.8v5RjXbtqXsLPWRKvMdhboA96gcyCL3_r XOS4Z11jeCFvdl_gzMoO4NXDMux9sRVjOu1C3B3vlpSJDlSHTrCIbT..S7qZIsroYDQyjBW_na9q kOmjygO2ayYw6ReN1dP7U8ma3FW_jkAM1C.Q6tm622SOGSmA10y3vyhE6AQEwAIxZyIodwJiwzp0 9JOElHyeWEp6AEb.1win1FYbiQSjxME6WC0ZBxGwcSy8lFty6uFmOMJyF59j8lIUcogCNF2nngDI .5Qe3fjO._cM.qwqWc84V1fZJ4qsJ04yFE.7.EAwmTn_OVkcCHZepP9se_nCGUkwxQOWKJlVsp4S Js05WxoHo2uFx4Whomomp7v1pQ8gfuL4mE58KgYEq2n4x0geIIt_dmuWTuPKVlp0rlOQbJUElHwy 8R.UK8mhEfrHlf7fRmhL.0CMaWWiWdQIMvceRNyZ6e3Dr72hWv5VXdL7JqJFzK2SsQrgfm_amXSc l4po3C_DjBMPqC24wlaCc1XO4CqIQ6c9RrKu6LPHE.gyz291mZyCSD76NvNsqXQcyNXSpEkQbub9 jQLAXPt4_E4mSjfoR9h22fhzeaEvMStYKbQs4hr1q X-Sonic-MF: X-Sonic-ID: 81e8e4b2-3141-45c8-9bab-4fa037b5cbfb From: Chuck Zmudzinski To: xen-devel@lists.xenproject.org Cc: qemu-devel@nongnu.org, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH] tools/hvmloader: implement Intel IGD extended VBT support Date: Fri, 31 Jul 2026 20:03:45 -0400 Message-ID: <20260801000354.16446-1-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <20260801000354.16446-1-brchuckz.ref@aol.com> Content-Length: 19725 X-purgate-ID: tlsNG-c1860d/1785542643-CE14687B-AF569FAE/0/0 X-purgate-type: clean X-purgate-size: 20214 Modern Intel IGD devices do not work well with the current implementation of support for the Intel IGD in hvmloader because it lacks support for an extended video bios table (VBT). Code 43 errors in Windows guests and failure of the guest screen to light up are some of the problems that occur with the current implementation. To address this problem, this patch implements support for Intel IGD devices with an extended VBT and OpRegion version 2 and higher which is required for most modern Intel IGD devices. This patch also depends on compatible support in the device model. If hvmloader detects the device model lacks such support, it will fall back to the currently implemented protocol for configuring the OpRegion to provide backward compatibiltiy for systems that lack a device model with support for an extended VBT. Support for an extended VBT is implemented in the newly introduced function opregion_setup() which is implemented in the new file intel_opregion.c. Major differences between this implementation and the current implemntation that only supports older devices without an extended VBT: 1. The current implemntation reserves a constant number of pages (3) in the E820 map for the OpRegion which is set by the IGD_OPREGION_PAGES macro in the current implementation. With OpRegion 2 and higher, the OpRegion can have an extended VBT that must be provided to the guest with the OpRegion. This means the size of the region is not fixed, so in this new implementation the IGD_OPREGION_PAGES constant is changed to a variable in e820.c, igd_opregion_e820_pages, that is set to its proper value based on the the size of the VBT. In this new implemntation, the size of the ACPI NVS region reserved for the OpRegion in the E820 map is equal to the value of the igd_opregion_e820_pages variable instead of being set to the constant value determined by IGD_OPREGION_PAGES. 2. The current implemntation provides the guest with access to the unmodified OpRegion on the host via memory mapping from the host to the guest. This is insufficient for OpRegion 2 and higher because some devices will require modifications to the OpRegion for proper operation in the guest. So this new implementation provides hvmloader with a copy of the host's OpRegion that hvmloader can modify as needed for proper operation. Mapping the OpRegion from the host to the guest is only used temporarily during setup of the OpRegion by hvmloader and once hvmloader has a copy of the OpRegion and the extended VBT, the device model removes the host mapping and hvmloader configures the guest to use the guest's possibly modified copy of the OpRegion instead. 3. The current implementation lacks useful debugging information for the more recent devices. This new implementation provides useful debugging output from hvmloader, such as the detected host OpRegion version and address, the values for rvda, rvds, and the guest OpRegion address when the guest_loglvl is set to all/all. Link: https://lore.kernel.org/kvm/20211012124855.52463-1-colin.xu@gmail.com/ Link: https://lore.kernel.org/kvm/20210325170953.24549-1-fred.gao@intel.com/ Signed-off-by: Chuck Zmudzinski --- Later versions of this patch will provide a link to the compatible patch for extended VBT support in the device model which will be posted to the qemu-devel and xen-devel mailing lists and Cc'd to the appropriate maintainers and reviewers soon. The compatible patch for the device model is part of a larger patchset that fixes many of the problems that currently affect the feature of Intel IGD passthrough to Xen HVM guests. This patch should be considered as a companion patch to that patchset for the device model. Do not try to test this patch with a real Intel IGD device without also applying the patchset for the device model because without those patches, the guest will most likely fail to start if an Intel IGD is passed through to the guest. There are different requirements to support OpRegion version 2.0 and OpRegion version 2.1+, with support for OpRegion 2 the more difficult case because it always requires modifications to the OpRegion for proper operation in the guest. For some details about OpRegion 2 and higher and the extended VBT, see the links in the commit message. tools/firmware/hvmloader/Makefile | 1 + tools/firmware/hvmloader/config.h | 15 +- tools/firmware/hvmloader/e820.c | 4 +- tools/firmware/hvmloader/intel_opregion.c | 297 ++++++++++++++++++++++ tools/firmware/hvmloader/pci.c | 10 +- 5 files changed, 313 insertions(+), 14 deletions(-) create mode 100644 tools/firmware/hvmloader/intel_opregion.c diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile index 21de721..ed42915 100644 --- a/tools/firmware/hvmloader/Makefile +++ b/tools/firmware/hvmloader/Makefile @@ -35,6 +35,7 @@ OBJS += smp.o cacheattr.o xenbus.o vnuma.o OBJS += e820.o pci.o pir.o ctype.o OBJS += hvm_param.o OBJS += ovmf.o seabios.o +OBJS += intel_opregion.o ifeq ($(debug),y) OBJS += tests.o endif diff --git a/tools/firmware/hvmloader/config.h b/tools/firmware/hvmloader/config.h index c159db3..bd3c0f9 100644 --- a/tools/firmware/hvmloader/config.h +++ b/tools/firmware/hvmloader/config.h @@ -7,9 +7,6 @@ enum virtual_vga { VGA_none, VGA_std, VGA_cirrus, VGA_pt }; extern enum virtual_vga virtual_vga; -extern unsigned long igd_opregion_pgbase; -#define IGD_OPREGION_PAGES 3 - struct bios_config { const char *name; @@ -43,6 +40,18 @@ extern struct bios_config ovmf_config; #define PAGE_SHIFT 12 #define PAGE_SIZE (1ul << PAGE_SHIFT) +#define IGD_OPREGION_PAGES 3 +#define IGD_OPREGION_SIZE ((IGD_OPREGION_PAGES - 1) << PAGE_SHIFT) +#define IGD_OPREGION_RVDA 0x3ba +#define IGD_OPREGION_RVDS 0x3c2 +#define IGD_OPREGION_VERSION 0x16 +#define IGD_OPREGION_MASK 0xfff +#define IGD_OPREGION2_SUPPORT_MASK 0x1 +#define IGD_OPREGION_SIGNATURE "IntelGraphicsMem" +#define IGD_VBT_SIGNATURE "$VBT" +extern unsigned long igd_opregion_pgbase; +extern uint32_t igd_opregion_e820_pages; +void intel_opregion_setup(uint32_t vga_devfn); extern uint8_t ioapic_version; diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c index 86d3954..97a234e 100644 --- a/tools/firmware/hvmloader/e820.c +++ b/tools/firmware/hvmloader/e820.c @@ -243,11 +243,11 @@ int build_e820_table(struct e820entry *e820, nr++; e820[nr].addr = igd_opregion_base; - e820[nr].size = IGD_OPREGION_PAGES * PAGE_SIZE; + e820[nr].size = igd_opregion_e820_pages * PAGE_SIZE; e820[nr].type = E820_NVS; nr++; - e820[nr].addr = igd_opregion_base + IGD_OPREGION_PAGES * PAGE_SIZE; + e820[nr].addr = igd_opregion_base + igd_opregion_e820_pages * PAGE_SIZE; e820[nr].size = (uint32_t)-e820[nr].addr; e820[nr].type = E820_RESERVED; nr++; diff --git a/tools/firmware/hvmloader/intel_opregion.c b/tools/firmware/hvmloader/intel_opregion.c new file mode 100644 index 0000000..59cb2c3 --- /dev/null +++ b/tools/firmware/hvmloader/intel_opregion.c @@ -0,0 +1,297 @@ +/* + * intel_opregion.c: HVM Intel OpRegion setup. + * + * Leendert van Doorn, leendert@watson.ibm.com + * Copyright (c) 2005, International Business Machines Corporation. + * + * Copyright (c) 2006, Keir Fraser, XenSource Inc. + * + * Copyright (c) 2026, Charles Zmudzinski. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#include "util.h" +#include "config.h" +#include "pci_regs.h" + +unsigned long igd_opregion_pgbase = 0; +uint32_t igd_opregion_e820_pages = IGD_OPREGION_PAGES; + +static bool verify_opregion(const uint32_t addr) +{ + const char *opregion_signature = IGD_OPREGION_SIGNATURE; + if ( memcmp((const void *)addr, (const void *)opregion_signature, 16) ) + return false; + return true; +} + +static bool verify_vbt(const uint32_t addr) +{ + const char *vbt_signature = IGD_VBT_SIGNATURE; + if ( memcmp((const void *)addr, (const void *)vbt_signature, 4) ) + return false; + return true; +} + +void intel_opregion_setup(uint32_t vga_devfn) +{ + uint32_t igd_guest_opregion; + uint32_t pages_needed; /* for OpRegion + VBT */ + void *opregion_scratch; + void *vbt_scratch; + void *vbt_source; + /* + * absolute value in the host/guest except + * as noted in the comments + */ + static unsigned long rvda_host; + static unsigned long rvda_guest; + + igd_opregion_pgbase = mem_hole_alloc(IGD_OPREGION_PAGES); + /* + * Tentative value for the number of pages to reserve + * in the E820 map for the OpRegion and VBT. + * + * This will be the final value for the E820 map if + * the device model lacks support for OpRegion 2 or + * if the host OpRegion version is < 2 or if we never + * allocate more pages in the E820 map for the VBT. + */ + igd_opregion_e820_pages = IGD_OPREGION_PAGES; + + /* + * Read the value the device model is initialized with. + * If the device model supports OpRegion 2, it will + * return the host IGD OpRegion address. If not, it + * will return 0. If the device model does not support + * OpRegion 2, the device model expects us to give it + * the address to which it will map the OpRegion in the + * guest and then expects us to do nothing more to setup + * the OpRegion, so that is all we will do in that case. + */ + const uint32_t igd_host_opregion = pci_readl(vga_devfn, + PCI_INTEL_OPREGION); + if ( !igd_host_opregion ) { + printf("device model lacks extended VBT " + "support. Continuing with legacy support only\n"); + /* + * Write the the OpRegion offset to give the OpRegion + * address to the device model. The device model will trap + * and map the OpRegion at the give address. + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + igd_opregion_pgbase << PAGE_SHIFT); + return; + } else { + printf("host OpRegion address: 0x%x\n", + igd_host_opregion); + } + + const uint32_t igd_host_opregion_page_offset = + igd_host_opregion & IGD_OPREGION_MASK; + igd_guest_opregion = (igd_opregion_pgbase << PAGE_SHIFT) | + igd_host_opregion_page_offset; + + /* + * We know at this point the device model supports + * OpRegion 2. + * + * Indicate to the device model that we support + * OpRegion 2 by setting the least significant bit + * of the address we give to the device model. + * The device model will notice this bit set and + * respond appropriately to our writes to the + * register where the OpRegion address is stored. + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + (igd_opregion_pgbase << PAGE_SHIFT) | + IGD_OPREGION2_SUPPORT_MASK); + + printf("guest OpRegion tentative " + "address: 0x%x\n", igd_guest_opregion); + + if ( !verify_opregion(igd_guest_opregion) ) { + printf("error: IGD OpRegion signature " + "not found.\n"); + BUG(); + } + + opregion_scratch = scratch_alloc(IGD_OPREGION_SIZE, 0); + memcpy(opregion_scratch, (const void *)igd_guest_opregion, + IGD_OPREGION_SIZE); + + /* Read OpRegion version, rvda_host, and rvds */ + const uint16_t version = *(uint16_t *)(opregion_scratch + + IGD_OPREGION_VERSION); + printf("OpRegion version: 0x%x\n", version); + if ( version >= 0x0200 ) { + rvda_host = *(unsigned long *)(opregion_scratch + + IGD_OPREGION_RVDA); + /* It is convenient to make rvda_host absolute */ + if ( version > 0x0200 ) + rvda_host += igd_host_opregion; + printf("host VBT address: 0x%lx\n", rvda_host); + } else { + printf("guest OpRegion address: 0x%x\n", igd_guest_opregion); + rvda_host = 0; + } + const uint32_t rvda_host_page_offset = rvda_host & + IGD_OPREGION_MASK; + const uint32_t rvds = *(uint32_t *)(opregion_scratch + + IGD_OPREGION_RVDS); + const uint32_t rvds_page_offset = rvds & IGD_OPREGION_MASK; + printf("VBT size: 0x%x\n", rvds); + + if ( !rvds || !rvda_host ) { + printf("guest OpRegion address: 0x%x\n", igd_guest_opregion); + rvda_host = 0; + } + /* + * Write rvda_host as 2 successive 32-bit values + * to communicate location of the VBT to the device + * model. If rvda_host is not 0, The device model + * unmaps the OpRegion and eventually maps the VBT + * after we also write the guest address where the + * VBT will be mapped. + * + * If we send rvda_host = 0 to the device model, it + * will assume we do not need OpRegion 2 support and + * it will not unmap the OpRegion. + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + (uint32_t)(rvda_host & 0xfffffffful)); + unsigned long rvda_host_upper_32 = (uint64_t)rvda_host >> 32; + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + (uint32_t)rvda_host_upper_32); + + /* In this case, we use the mapped OpRegion */ + if ( !rvda_host ) + return; + + /* + * Update the number of pages the device model + * needs to map for us to get a copy of the VBT. + * + * N.B.: Here, igd_opregion_pgbase is really the page + * base of the location where the device model will + * map the VBT. + */ + uint32_t vbt_pages_needed = rvds >> PAGE_SHIFT; + if ( rvds & IGD_OPREGION_MASK ) + vbt_pages_needed++; + if ( vbt_pages_needed > igd_opregion_e820_pages ) { + igd_opregion_pgbase = mem_hole_alloc + (vbt_pages_needed - igd_opregion_e820_pages); + igd_opregion_e820_pages = vbt_pages_needed; + } + + /* + * Write the location where the device model is to + * map the VBT in the guest with the 12 least + * significant bits encoded as the number of pages + * for the device model to map (vbt_pages_needed). + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + ((igd_opregion_pgbase << PAGE_SHIFT) | vbt_pages_needed)); + + /* + * When the VBT is mapped from the host, the page offset + * of the VBT will be the same as on the host + */ + rvda_guest = (igd_opregion_pgbase << PAGE_SHIFT) | + rvda_host_page_offset; + if ( !verify_vbt(rvda_guest) ) { + printf("error: VBT signature not found.\n"); + BUG(); + } + + vbt_source = (void *)rvda_guest; + vbt_scratch = scratch_alloc(rvds, 0); + memcpy(vbt_scratch, vbt_source, rvds); + + /* Compute how many pages we need for OpRegion + VBT */ + pages_needed = (IGD_OPREGION_SIZE + rvds) >> PAGE_SHIFT; + if ( (IGD_OPREGION_SIZE + rvds) & IGD_OPREGION_MASK ) + pages_needed++; + + /* Update the number of pages we need for the E820 map */ + igd_opregion_e820_pages = pages_needed; + + /* + * So far we have allocated vbt_pages_needed + * and we will likely need to allocate more + * pages to fully contain OpRegion + VBT. + */ + if ( pages_needed > vbt_pages_needed ) + igd_opregion_pgbase = mem_hole_alloc + (pages_needed - vbt_pages_needed); + + /* + * Compute the final igd_guest_opregion value and + * keep the same offset as on the host if doing so + * will not push us across another page boundary. + */ + igd_guest_opregion = igd_opregion_pgbase << PAGE_SHIFT; + if ( (igd_host_opregion_page_offset + rvds_page_offset) <= PAGE_SIZE ) + igd_guest_opregion |= igd_host_opregion_page_offset; + printf("guest OpRegion address: 0x%x\n", igd_guest_opregion); + + /* The device model will unmap the VBT */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, igd_guest_opregion); + + /* + * After unmapping we need to populate the memory hole. + * If the unmapping failed this will crash the guest. + * + * We could try to use the mapped VBT with our copy of the + * OpRegion, but it is probably better to BUG() if the + * device model failed to unmap the VBT. + */ + if ( verify_vbt(rvda_guest) ) + BUG(); + mem_hole_populate_ram(igd_opregion_pgbase, + igd_opregion_e820_pages); + + /* + * After unmapping we are free to shift the VBT by + * an arbitrary number of bytes. For efficient use + * of memory and to keep the memory map simple, + * place the VBT contiguous after the OpRegion. + */ + rvda_guest = igd_guest_opregion + IGD_OPREGION_SIZE; + printf("guest VBT address: 0x%lx\n", rvda_guest); + + /* + * Until now, rvda_guest has been an absolute address + * in the guest. We need to translate it to a relative + * address if OpRegion version > 0x0200 and in that case + * we also verify it is contiguous with the OpRegion. + */ + if ( version > 0x0200 ) { + rvda_guest -= igd_guest_opregion; + printf("guest rvda (relative): 0x%lx\n", rvda_guest); + BUG_ON(rvda_guest != IGD_OPREGION_SIZE); + } + + /* + * Write the correct rvda_guest value to the + * guest copy of the OpRegion and copy the scratch + * buffers to the correct address in our E820 region. + */ + *(unsigned long *)(opregion_scratch + IGD_OPREGION_RVDA) = rvda_guest; + memcpy((void *)(igd_guest_opregion + IGD_OPREGION_SIZE), + (const void *)vbt_scratch, rvds); + memcpy((void *)igd_guest_opregion, + (const void *)opregion_scratch, IGD_OPREGION_SIZE); +} diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c index c41c8d9..07a37e5 100644 --- a/tools/firmware/hvmloader/pci.c +++ b/tools/firmware/hvmloader/pci.c @@ -43,7 +43,6 @@ uint64_t pci_hi_mem_start = 0, pci_hi_mem_end = 0; #define BAR_RELOC_THRESH GB(1) enum virtual_vga virtual_vga = VGA_none; -unsigned long igd_opregion_pgbase = 0; /* Check if the specified range conflicts with any reserved device memory. */ static bool check_overlap_all(uint64_t start, uint64_t size) @@ -190,14 +189,7 @@ void pci_setup(void) virtual_vga = VGA_pt; if ( vendor_id == 0x8086 ) { - igd_opregion_pgbase = mem_hole_alloc(IGD_OPREGION_PAGES); - /* - * Write the the OpRegion offset to give the opregion - * address to the device model. The device model will trap - * and map the OpRegion at the give address. - */ - pci_writel(vga_devfn, PCI_INTEL_OPREGION, - igd_opregion_pgbase << PAGE_SHIFT); + intel_opregion_setup(vga_devfn); } } break; -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:17:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379719.1624134 (Exim 4.92) (envelope-from ) id 1wpxQF-0000ym-Tu; Sat, 01 Aug 2026 00:17:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379719.1624134; Sat, 01 Aug 2026 00:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQF-0000xZ-PV; Sat, 01 Aug 2026 00:17:51 +0000 Received: by outflank-mailman (input) for mailman id 1379719; Sat, 01 Aug 2026 00:17:50 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQE-0000rr-3E for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:17:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxQD-00AjZN-Cv for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:49 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d3a84-e002-0a2a0a5209dd-0a2a4501e7a8-40 for ; Sat, 01 Aug 2026 02:17:48 +0200 Received: from [98.137.68.206] (helo=sonic304-25.consmr.mail.gq1.yahoo.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d3b2b-5984-0a2a45010019-628944ce9cb4-3 for ; Sat, 01 Aug 2026 02:17:48 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:17:46 +0000 Received: by hermes--production-bf1-54b5569bdc-h5zdx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 655a093bcead2c5289eeab02aa189b76; Sat, 01 Aug 2026 00:17:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785543466; bh=aPSDtc80QxBay9GHhGU8jyIiLkLfb59Aeoc3NEAiIBw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=odcmwXJKuXz0mR8QwvIHWS5CWZdlP4zmZcTbRTSPwnxtghiNAD6/TQex0uG1kZ6c87VlVa0VXjbadj8/iDFtpe6am+9BQCY6jN5mUEMv3s50T+5AhJWeLNjG1hZWpM0D7iYXuYsKvJkdVmMAejowRt3d2fAi/cRXbJC5B5AliX8vVu4fnumhfjXsP4Nk+/MxQwJaf1gchf77Pv+ncoOpGJD5hyhuIs7sy8pF7dkl6zZs9gNwEzz90cd3udKQxc/uZNP5sh7ONYhA/JqjTV0a0qESReB/8TRfHGLNu7msiJotCM9HBwgALv/mWip+ppAN6SfwFMkBhvNID11aZQ6M8A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785543466; bh=g9vcxOFW9WO8GJRAE0inlaJ0qmxWPRXJTYNL6abXrOx=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=agPsYFLa4qHJiBe2k21l+dYlmkBwUxm3cth0vIKcnMgRADMnduqqybndvN3sbVV7rTsnaakIBjTg0ZH9f3DXHi3JwzXl7yVQrCGq2O6q4dJfr+K2cAaZEnY3nk4+47osWt8xfWk3xIH36lr6iJHMQcQPzaq7IvgSLioTr6eOoX3rZ4d7T4godBmJiaR4RxARMWDUMxbxqcoX96VcvZJUK9pfeUpGlGp6kP82m+oeH0fnfM2ez1oHpsz71N9SFYNMnTNuEneNkX9v2FS4C/2xlgUS6RaFZsIgorT8PPZZYw7bFXiqdBEcgu2AN1oyDM0wQAEBkRTSMdfbaYwNlPW8Dg== X-YMail-OSG: CkDsvboVM1kpbg5Mpy3X92H1oMm50miAqVpeWOVcuRiuxh_RK79p5J0uCxvsOMJ lbN0Xkg_ZmQlffZEgrgyNzczcHf4ojzXZEIKIgXEHRFED5hbuPP8SWYc2ZVppvdPF9XQxWEK8iO8 FTti4rEn_IsrYEcNIL3FuZSKUJwRwqol8LHse2H6cntOuDDeHekD6J.XRnkRnONzVvFQ6ebYvSLA TATGSvRF5.PATQtkaUET0OzuZHS2Mv5F5TcCqgB2lczBmaFxH3ssVTE_8t09utRPKXa_eqN1ubB2 IOeD7nU6xYoIoO258hw4A_WJp1PXh.F7QyFeRgLllVAM6uIxtcoAF1tM6QXnQHHUA0ULM6bVs.OB zJc3Y_OdfORvvOJqEMfpcVyMVvrs5XOUjm3qmVO0kS_Q_0BBg2zZ8.ZziYJojLuh1Ij2jrwgt4i9 kDh1ohA9yz03DbzRAfrwCuHoVVXrOrpNYapw6ejRLf_9xG6Ii0Qdwei43V0Nf0hWKzUbfCXUbU9Z Ef0HZYaZ3bPTQlkdwlzWiSB95SU.YeDS3EcSn9yLQdQsoBbDbG0JkSqQX81B0KwYdluNjOfwekDN GSjZZrgeS8kOaTYeTUwXT0Er5XH_5YGQJlG8htPCh4u_wWkIvf4irB23rH_zSBWKiNv22.0f7NHX YOVlx1up6bqbUG7kFpFbhUCgtw2nZomdClWU78utA2Cd2Sflnm3R7g8O8b42A2q8FVRAcvLHgy.i McxX9GlONL0urFahnON8lQuy_qUjfuAQUTDfDF_aPWRD9xIPQ6FUC9EwA54GWPW8ivHIlOfZEkZI Fcb6Bf4hhQ7mDoNv8m.O1LD3NFCZ00oAhcN2xTjgbzFwiQElHfR_v_Jl7jJPpuD_nHLh0r7_qPoG uybctR3S8aQYk8Rh08zqKzypkTMSqtatAiGW12lmqVePQYhyDtHDAGJ9CHHwg5ryBIVorc5osJ9V TBa2A8oyhEqMGXXMJr6tE8XArxfGRxj.qw6vezPcQ6gj8xl5udluiuuIgs3q74pIwQtzf8QJxixM l9phMgmnPB547YBFj392s7fW07rRzc_x2odOS49UyIWUFKhWR8ypZNdAB.b1A7_1d8e_fOM03s4d cpUW2h1l.Sy.CtQaWhTcfoaypOTYDssw5ahUSpIL05S.BFHLDZ__4gcs24fO6fdA2dOUS_3VlMJO qy.xLAHsoVktnlb8ZKBuwV2w8JiA2xKwyIpovXvKezptAsg4gAdjO80yCqPtiEsg.a7CnEIGwiXp S7.N2Rl6Bhl0uLGGo36ZoWD0yPuCK4xkiP6qBecZmBO_M4.MrZe5LBC_8BpoAFwBhhlshrgV4ieZ H.1pDRcSEp0pYMunfbk3nmOQw3zIbMiqL1SZDTpH0fH8TYC_bKTUaQ0JK88vzzPXKrgaY.Wgu1z7 RsTkD00elxcuICbY6dSukKYGDA5vojeYFe8zLmYCIqfqnwK3V09eYQb9sxTPDV3K0UIc6empwZFy _lGfOBxlHdJgzpCeKkvLqXU03zqGrLQXqeA98m1uoPx1LFG9GSyA5UeZmWlN9Ij3QMmTVX_aHC86 qA6sXis3XKVd2NssjA8VPLKCv.Ft_Tu5vhm6vZi5KgB4n8tTU_VHBnAW3sJNh44fI5lOteLoJWkM FD78mKumArUBLsW.sbiMqXmOytSgkbdKqrVK6XU0aygkaJFVMj7Igb2Fbn5UoCdRYhVJVrlOJCVU AxldNt56XZmnMBhixdaIyRWlGl018ishkFtbwoEIKAJ5a_2GoX51ETJcCnjE3LdJA8HHJZUS03WN tjJo4YxwUTSKFu8mE_zLT3KeZ6qVhQ7T4R96syRMQSB48R9qlLIz9naubkd55wThHWlYUCKYskIp pb1jafOcyykirr0hNpXJkKr82Pvezh5lsswAbaNENX7dFcNKFKGvyzOktOUOTymmxixGO0RFHsXc OMfwTGk3sU6_gs_PBmuurRxosChZkvb16bXNx3NXs1mo6HOsWSp_ZYzWewn5cSXdf50o20QUEbNo 9_.BJhAXVrhI7cZtuhb9AC7IZNGx_X7.4zButAgEFLzVBnbpR.vj7lAvssDPohKsN11N2QmnSTsM YafAcaGuu0cYUoCZDC2OJstesALPInKyJwTG7QAxyzuK738Spt_zuXmk.KWA_fCCy6DasO2AxkUt wVNIXxvJbrp9bqROng.XPyyY3NFhkqLhPWlcEJ0L4B5p0l2HhEhcdrcyMt4TveGUKcS44WoJMDsF dfJ.VpvUc1CxkAX5_aHBtYgrRrhs_CJ_m3Y77ESLdUzBlOwFc X-Sonic-MF: X-Sonic-ID: 19268ac6-fb05-4394-9e7e-926ddebd28c2 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v4 1/6] xen/igd: get PCH info from host sysfs Date: Fri, 31 Jul 2026 20:17:25 -0400 Message-ID: <20260801001737.16509-2-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260801001737.16509-1-brchuckz@aol.com> References: <20260801001737.16509-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 5699 X-purgate-ID: tlsNG-d62444/1785543468-BDC79757-73620B74/0/0 X-purgate-type: clean X-purgate-size: 5851 The igd_combo_id_infos[] data is out of date with many devices missing from igd_combo_id_infos[]. For newer devices not in igd_combo_id_infos[], get the infos from the host sysfs. If logging is configured, print log messages displaying the PCH info used for the guest. Introduce helper function xen_pt_get_host_pch_info() to facilitate getting the necessary information from sysfs. Treat failure to get the host PCH device id as an unrecoverable error that causes guest creation to fail. If access to the host PCH device revision id fails, print a warning message and use a default value of 0x1 in that case. Also, use errp in xen_igd_passthrough_isa_bridge_create() to set errors from xen_pt_get_host_pch_info() and cleanup on error path with xen_host_pci_device_put(&s->real_device) and object_unparent(OBJECT(&d->rom)) for errors when creating creating the IGD PCH bridge. Add cleanup with object_unparent(OBJECT(&d->rom)) for errors when setting up VGA BIOS for GFX passthrough. Signed-off-by: Chuck Zmudzinski --- Changes in v4: - re-wrote xen_pt_get_host_pch_info() using functions from xen-host-pci-device.h - add more error handling to clean up better after if errors occur - don't consider failure to get the PCH device revision id a fatal error but instead print a warning message and use a default value of 0x1 hw/xen/xen_pt.c | 10 +++++++++- hw/xen/xen_pt_graphics.c | 39 +++++++++++++++++++++++++++++++++++++-- include/hw/xen/xen_igd.h | 3 ++- 3 files changed, 48 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0fe9c0a..c8f08b5 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -862,12 +862,20 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) if (*errp) { error_append_hint(errp, "Setup VGA BIOS of passthrough" " GFX failed"); + object_unparent(OBJECT(&d->rom)); xen_host_pci_device_put(&s->real_device); return; } /* Register ISA bridge for passthrough GFX. */ - xen_igd_passthrough_isa_bridge_create(s, &s->real_device); + xen_igd_passthrough_isa_bridge_create(s, &s->real_device, errp); + if (*errp) { + error_append_hint(errp, "Failed to create PCH bridge" + " for passthrough GFX"); + object_unparent(OBJECT(&d->rom)); + xen_host_pci_device_put(&s->real_device); + return; + } } /* Handle real device's MMIO/PIO BARs */ diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index 7df9344..b37f9b7 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -2,6 +2,7 @@ * graphics passthrough */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "hw/xen/xen_pt.h" #include "hw/xen/xen_igd.h" @@ -376,8 +377,33 @@ static void pt_graphics_register_types(void) } type_init(pt_graphics_register_types) +static void xen_pt_get_host_pch_info(uint16_t *pch_dev_id, uint8_t *pch_rev_id, + Error **errp) +{ + g_autofree XenHostPCIDevice *pch_dev = g_new(XenHostPCIDevice, 1); + + xen_host_pci_device_get(pch_dev, 0, 0, 0x1f, 0, errp); + if (*errp) { + goto error; + } + + *pch_dev_id = pch_dev->device_id; + + if (xen_host_pci_get_byte(pch_dev, PCI_REVISION_ID, pch_rev_id)) { + *pch_rev_id = 0x1; + warn_report("failed to get host PCH revision for Intel IGD, setting it to 0x1"); + } + + xen_host_pci_device_put(pch_dev); + return; + +error: + error_append_hint(errp, "failed to get host PCH device for Intel IGD"); +} + void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, - XenHostPCIDevice *dev) + XenHostPCIDevice *dev, + Error **errp) { PCIBus *bus = pci_get_bus(&s->dev); struct PCIDevice *bridge_dev; @@ -394,7 +420,16 @@ void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, } } + /* Newer devices get PCH infos from host sysfs */ + if ((pch_dev_id == 0xffff) || !pch_rev_id) { + xen_pt_get_host_pch_info(&pch_dev_id, &pch_rev_id, errp); + } + + XEN_PT_LOG(&s->dev, "PCH device id: 0x%x\n", pch_dev_id); + XEN_PT_LOG(&s->dev, "PCH revision: 0x%x\n", pch_rev_id); + if (pch_dev_id == 0xffff) { + error_setg(errp, "failed to get PCH device id"); return; } @@ -406,7 +441,7 @@ void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, * Note that vendor id is always PCI_VENDOR_ID_INTEL. */ if (!bridge_dev) { - fprintf(stderr, "set igd-passthrough-isa-bridge failed!\n"); + error_setg(errp, "set igd-passthrough-isa-bridge failed!"); return; } pci_config_set_device_id(bridge_dev->config, pch_dev_id); diff --git a/include/hw/xen/xen_igd.h b/include/hw/xen/xen_igd.h index 7ffca06..da51f09 100644 --- a/include/hw/xen/xen_igd.h +++ b/include/hw/xen/xen_igd.h @@ -22,7 +22,8 @@ uint32_t igd_read_opregion(XenPCIPassthroughState *s); void xen_igd_reserve_slot(PCIBus *pci_bus); void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, - XenHostPCIDevice *dev); + XenHostPCIDevice *dev, + Error **errp); static inline bool is_igd_vga_passthrough(XenHostPCIDevice *dev) { -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:17:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379718.1624130 (Exim 4.92) (envelope-from ) id 1wpxQF-0000v2-M4; Sat, 01 Aug 2026 00:17:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379718.1624130; Sat, 01 Aug 2026 00:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQF-0000uu-Ho; Sat, 01 Aug 2026 00:17:51 +0000 Received: by outflank-mailman (input) for mailman id 1379718; Sat, 01 Aug 2026 00:17:50 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQE-0000rs-2x for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:17:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxQD-00Firx-DI for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:49 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d3ae6-bab6-0a2a0a5309dd-0a2a4506dbea-24 for ; Sat, 01 Aug 2026 02:17:48 +0200 Received: from [98.137.69.83] (helo=sonic314-20.consmr.mail.gq1.yahoo.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d3b2b-195a-0a2a45060019-628945539ebc-3 for ; Sat, 01 Aug 2026 02:17:48 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:17:46 +0000 Received: by hermes--production-bf1-54b5569bdc-h5zdx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 655a093bcead2c5289eeab02aa189b76; Sat, 01 Aug 2026 00:17:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785543466; bh=MtlsR1zLIBzo7DokWP/PBZ1CtP2Neyt/oQv1hSzEZAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=l2NAnr2ZeOl00G7zLAfZYUgGGgl3bASj4jRKmAak+9N9/hG24pcUM/LzEn1xl4fJMjpfmcW4O10lvFpATFzfX9CpSfIxtRInzt+3HuBZgIclDqkLODwk2pyWHNVYX8+90vj2YMDizy7uAq4+8YT8E+L2LsbsA4zCApdIWya8uXQV7SXi6LiOzWpYAkul/mTRfIIfjducGFC2IwrAvlqgsviu77t5dtvaEjydWtiMDY/SFD10L5fq9wfzVPmpwSymGDgqyVAVC1NkefvikFb7qmsxJGz7dIwosXSVTfZz2nnjp2n1LIDoYf9SETOVXytPLvpYKgBL8ziU2Ib9lpG//A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785543466; bh=5ahFWUv8lvDNModk7E2uOFUzvRNOZLW3kzh0fNuw3rd=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jO+g+4wGJ7JwN/G8/5y3TWUhOu2HKR7nJQIFCXXO393SFuJqbxDeBBqXBqrGsrFqwWdQOFyUupbAHB1smtjynyOEMHFUJDHF8fAi3ToXpWO1MWY2CfKSXylgzU80L2OjI5f5sf2I3iscHYz6y06UZ7q841cp9qKyA+xxUy4EDnCjOCmS9DSwOU6xwdg6lCzQbjxD3wWJAeJGryRhxTXUVF++gV8j8vAOBYDFKbMAbyQhB45w9AFcnBvkRNgtwPvtn/+TuRte86J35QG2Se41UmlkR5NxJOn92kuXBWh32mlbWr+ZSBjiSoae3gY1JjBsm7HQI1yfNsRLS342FASJtQ== X-YMail-OSG: gT3lLSsVM1lm2IGDDEANNWhuhXhBu9oXnaJGyZ28aKnJKr8IBok0tFrcXySMacJ Wpy9JYTmVsUvpQ8aYqe2.J23IobED.xdg1MZV3gvbzI1KpvLzxoLL4mCVb4DKGv7KSXc8gnChmPu 1lxcASxzyA0sPTMnFzfYpjWszTKVYJMFikJE8SgHKd8KjX4w8YrZNDSqOqqQhldD41rTH1WabT8k rAwvc5yDLXQrpLi3W6SmZIXE0vk_MKoeofkUxq.2lweeWKh0nPMHaNpaLWa_4Q454aeKTHcJfFpB ttWNOc8zROh4OpEcIpBnk8KUO15Wnrfh.mKGQygjM4OibeXITow7gQLMBCIFSE7HQ_qXThG27F1j nauoZnIdGYzGDbfiWn4_cXwiaY_pS1BlUdc.NXkxFKEaxNvr6K56RCTvbusyfCjb8dRTHf9OJ4_j cTFTLyl8Sqh0FkILwA6h_Vk2BsLfolO7GKt9ByLNiEMGbSvt_A3KjxK7kWIJYtCBu5GCGuosbIpN gmj53mxvsUy9W2DCTwZX34NhoFPd3eJHqngAz63f0Dr3BPSszz09c5IlJhwBAx9I2itH8IwCnRcv yZRMmBEc55yUd3EfmOI2VvY547FoZM78Z6zNrMrJKQUjIagiDwecjcJGzVt8eMvFw2m4aHYT1lyC aBJEGVA0Qjml7LbSX0yOh7sT_5posDSWxWXF0c9cip4UrBTHZl1WBWYobgSnMkoqtOQ24D7HWL3t 1Om7bSfxfTR3yrQmcnfxJdgPsrRRxSTzbMf9sFtiIUJ_flzInYb8QkJPpoc7WIqoSBHVSsFVoqRo O2a0hT09iMgfD6MOpDRnUt4RPLL44TbKGk8XQuJkNRKeN799Nc_bVbjFLy5rKGMm_1Wh7RodGwxu rN1EyHu.rr8O1INZHiByuGvABdCX4vilBQoMv4vChG38Eq7lm6SYdGh2R13AqxZDI9Gx1DGXEdon hwd4LYsQdPd5dF_fpAyDNCVYFkWaPqafaU_Vz_wuWXelKMLenYKPOpD40Ja1tSibmKQE9ZIjZSW2 FsapOInc3CvAZ2U2asC_5lZ1DWTR9DyWaUjXFz07U9_2EugKeWUhbgRHJCtorumWZ_KdYhTH4OYL .YbsxA9o2UNkf1.Y2ujdYftI9HXIjBYMwhB.C2KkrWP.KeC4DAoX1Gx1KndPHdBqnKal9w0KaS1I 7pf4ci95rtbrbPZI7pZG.0nie7xzsqRiCz4INP9QZvuDPZ4v8f2ih2bvgF79UrJAGCJxtafsTqaB JD94VsldUt7F5vmmJ0iI9izuhKDIwz3Zkyd7Vpv8gy2kXa3MssR_ug5AZXejSTJgk4Pk1N3plAlA z9u4x7IkIBC7EegRl.Ui194iSJyTIPXbsHcwX5X_hgl8rXLXf0eBlsqyu4ImHJdHEXAP9Qpdkk17 hVxhgafEeea9ezfJp_mg_ZMj816YlzYRy5q0HcNxE4eCEsvCVBafjwUntw57jRRnVN8UncBaUuK0 Q6WlHBUf9mmdic4kMNsUeJp1jfyuGzBVRBTDBRgPsffORyY9bdULEzDk6gWp2UGEMZH13i.lBGn. YD_weV7zsyPqLvIRT5.OZlw1nJhsEMdW_INz6Ac84UfkDiLiWwOXJ.EQQDDVvFyE_ENEs3YeJ4jh PmSeGB5Mv7.Tk27.g5.3jifhDFqD.I_ZEXb7NOnhb1h1Y6cuK23b7UOFbKIOVPDV4.bctL3g1aS8 2U.bHN12X78Dd9jJbRZPIDpk1CLbHct3s07fNRsstwCzM5xLi4UDq5MIhybwcbaEKyGJ7ymjLpNR uUCg3w_yavzfJhp093mXaYFc87rsElWqoHj1DVD9LIwVMjZgz8p7UUbiCzFmgt.Z.UNAN8Kf89Uy YVwu.jSF6yfBGNtT787dxQ.cQ1JnZQzp3rXVWg9QdV_HctWMub5SaxImA4P7Lu_KuNNoFCMjKMWR 0y1ISuOnqP..R7qlIxm8epK5vevI6tTZAINDhOrYuCGyBB3TX1PlUT_v_a.HbbdT7ET2YQ64xHsO _4XrEdrpRwLGZ1fn75OR6fYIFKA2f7Thgg06Pd1DDCjZ_CWOOrRp8oFWal5HzwFoK4msQUpsf2H7 u3dg03h1mBhoh4QCl5LhvdD6dSDTvZnGj3Q79HX63z28mbEbQTdO2o7WnE7d3uGv928dKV_xq95. UW6ecAcVE8OJPpxL5F46pheb8Y6wWfl3ZXqh5ujcRDNBhu6ZCsf6a2PyfWQf3R799tN1uKX9WNki oO2sif9h.FexmR388UyMb3axdpXNZg1WOlfx9F4KxaIgOlb8n X-Sonic-MF: X-Sonic-ID: 6e72e470-4730-41e5-b846-8856782acdd4 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v4 3/6] xen/igd: fixup device id before registering rom Date: Fri, 31 Jul 2026 20:17:27 -0400 Message-ID: <20260801001737.16509-4-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260801001737.16509-1-brchuckz@aol.com> References: <20260801001737.16509-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 3165 X-purgate-ID: tlsNG-16d1c6/1785543468-F6C7777B-A84B88A1/0/0 X-purgate-type: clean X-purgate-size: 3246 With the current implementation, Seabios does not see the fixup of the device id done here and consequently Seabios does not load the VGA bios and the guest screen does not light up until the guest OS graphics driver is loaded. So there is no VGA output from the passed through Intel IGD from either Seabios or the guest bootloader with the current implementation in cases when the device id needs fixing. Fix this by waiting until after doing fixup of the device id before registering the option ROM. With this patch, Seabios sees the fixup done here and loads the VGA bios, and both Seabios and the guest bootloader light up the guest screen in cases when fixup of the device id is needed. Also, remove unused header hw/core/loader.h. Fixes: 881213f1b9c5 ("xen, gfx passthrough: retrieve VGA BIOS to work") Signed-off-by: Chuck Zmudzinski --- Changes in v4: - Add a Fixes tag hw/xen/xen_pt_graphics.c | 3 +++ hw/xen/xen_pt_load_rom.c | 18 ++++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index b37f9b7..0ae95cc 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -223,6 +223,9 @@ void xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev, } } + pci_register_bar(&s->dev, PCI_ROM_SLOT, 0, &s->dev.rom); + s->dev.has_rom = true; + /* Currently we fixed this address as a primary for legacy BIOS. */ physical_memory_write(0xc0000, bios, bios_size); } diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index 319efca..407b630 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -4,14 +4,22 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/error-report.h" -#include "hw/core/loader.h" #include "hw/pci/pci.h" #include "xen_pt.h" /* - * Scan the assigned devices for the devices that have an option ROM, and then - * load the corresponding ROM data to RAM. If an error occurs while loading an - * option ROM, we just ignore that option ROM and continue with the next one. + * Normally xen_pt_register_regions will handle loading the option ROM, + * but in some cases, such as for the Intel IGD, the option ROM might + * need to be modified. + * + * For such cases, use this function to get a pointer to the option ROM + * from sysfs. Caller has the responsibility to edit the option ROM as + * needed, call pci_register_bar to register the modified option ROM, + * and set has_rom to true for the PCI device. + * + * This function must be called before xen_pt_register_regions is called + * because if xen_pt_register_regions is called first, it will register + * the option ROM and any attempt to register it again will fail. */ void *pci_assign_dev_load_option_rom(PCIDevice *dev, int *size, unsigned int domain, @@ -76,8 +84,6 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, goto close_rom; } - pci_register_bar(dev, PCI_ROM_SLOT, 0, &dev->rom); - dev->has_rom = true; *size = st.st_size; close_rom: /* Write "0" to disable ROM */ -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:17:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379720.1624140 (Exim 4.92) (envelope-from ) id 1wpxQG-00013f-7C; Sat, 01 Aug 2026 00:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379720.1624140; Sat, 01 Aug 2026 00:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQG-000124-0h; Sat, 01 Aug 2026 00:17:52 +0000 Received: by outflank-mailman (input) for mailman id 1379720; Sat, 01 Aug 2026 00:17:50 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQE-0000rq-2x for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:17:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxQD-00Firx-CP for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:49 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d3b0f-bab6-0a2a0a5309dd-0a2a4507c094-8 for ; Sat, 01 Aug 2026 02:17:44 +0200 Received: from [98.137.65.83] (helo=sonic313-20.consmr.mail.gq1.yahoo.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d3b27-b4ea-0a2a45070019-6289415393ab-3 for ; Sat, 01 Aug 2026 02:17:44 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:17:42 +0000 Received: by hermes--production-bf1-54b5569bdc-h5zdx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 655a093bcead2c5289eeab02aa189b76; Sat, 01 Aug 2026 00:17:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785543462; bh=HIdr9C+lQ6Jo7WCNlxAtCo2E+oJ9NtzQ6wQnEjmdA0c=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=HJyFvByv/JaHrQ8YDyLQg80tGhOCl+wqOV2V/fp5Rp13BcrSKyY4seukQgb7gjr8GKUf2vOyfArtokuWAa9w3xBLT1o2klLyJ+ww0Hl2lk5cc1stBxr7t1XKYhBsiI4V2mV+Uax96Kyl4ilSS4gmWHZh258zNkPzd48vVypwoZr/WUSc+hHyUtpR1HskiqZJcQ2Zc70T4YVFGHuQGwG6i5xlIM9mXGvihloc/Jhf6ax+QYmLdyScDH1Q9dUPYH3h6ptGxvkQIl3dxJSmpHex0tOvrKrTDjnzlbzAwdF4WM3N+SUUMmrGR6HYZVbawRQ4/K86uCG1TBKaiIms8C3mjQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785543462; bh=y3QEujPX9kE448RVtEETa7Ed9ZNYf7OrJSkBxZtAVNF=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=A1oMkOHopeoIOr1bQdvA/KSB64iT2kiPxX/YdvrXBQ2R3hkwxyoEVbCKZPxHf4JKlwt2BzCny+furZZlYEUzD5uECZY1BFs3nOlaMn+il98pu2TdryHXn99NrOJP+a328b9jd35Fmyl1RaPdGtq+pM+ELPr7gSyprQNKkZ9Wkf4ULgFz7gz9A/javO6KMkCPl2DiTjAOc+PJDeqlhfO2Zj4fcIBjZXXCBTcWl0a1DxxtG5Zl+1aSmD52hajQXi0DUH9XydMaAprtxTmRMvtiPtAsWPMCWCREeRfTM2bHgPQrgouaL5Wt94okqHI032dzQN7+tPQXwajJzFu5zuxeSg== X-YMail-OSG: ne4VrocVM1lH1iDmo0cvieuzMkAyBDUp_2QC5WjVPFKC7wyOU4sJPUOTcIIAxxg 338sot0z0Y1Fof4BGUYmZna9OAzYkZRPFVpoLX5AiPjhv_H6ecp_SsW2w9LRtjszqkt59Y801rtX 1.0fFCoUqluAOLY76W80DXouX36JeJtCo51Lf6R3jBHk79e6J_ErzFxZcQGumxa85BPx8YJ1sYG5 jsdf4UFrSFjey9BAWK2pslNofS0SOzeno_9cqVIoID86ME1ZTvsR8RFDFid.bSNnQmXnz_SaioG5 9OZ1k0OhvXrQ7kzP0SsIC4s19xSNB8kBCIOOPWBl4By.nkEMDueI54AEgQD1I.m8toj1Rl_8cVFV AOALx_1FaWC.ieOBLhVrogDqChUOMwXLPzVh.bs2anRs34RIXNQ6mPSLW5csIit5ghl.hisUIjU2 F4VTL.QKKJ8yg4aw1FAM1doE8ir52C9BpyXDZbNmqSC14cu26j5OUubcb2ja8w7WBK9GT9UB9tgL QFUrJ2YQp2oifXsum90lODu30FXTy0VvUg.pm64_E2RN1rIWq4TzHcNDF.QlNB_IdmP8t247phAK SdRbfwjA9SYYnZqzoKnQRuJVyp3ersT1WvLod8jH6D5OuWLNh1bwLiDLBK69yS3uWaocO9DGeNGc ELXH16cz4lsH.PCR.VCMHyR2vJklTaQ5c0u1MFStg2rd5N.EYDU4V2vi1zyQ_NBb1BpwqxLmx448 B7M5e1RvhZSB2GflTlRsd6lc3vkX6vWTvXBXRGzHi5JKdbzrTDflcMEma_PEekVbHDntiURYg2Dv pAK1YbWGMJpbiEfe.7SiGNlO_wyNtFwG.McndWCDRvFcgp2kIHoAaqEiowLTL3ExQ3IMti0hD4HB p896PSUFQDHgVDbzp5DDppVpEkm04pYKMxCpSA_tPYFayUO5TjX9txo0OQs4CJZypSFgwEAS5faN g2exS44QG7NZLAo7TFklWpjcpr86UY6cqYN.mw1fRkDyUMSjtOjR1J2Qplraxaf._kzL7v1RBC8Y ewsZ0QywF_beCnK7RmYoGMeABYmVcYj_3Li6oExpiMbG3N3at9Fn0BnFxefy4rawWrUfD2bGPK.I scr3zbtEYLm6gGJHNIccKPltdC4.qJNbRVIAypA0SZVYmKjUVE.tQeDTfHqoPQH6OSB1Upb9lLYL 5AQwNWAOg7.n8YXsmo3dhIuppfT5UsQMTt5i3qwYowebrmZtkDI19lLQrHM89N54125QxPXlGq.Z lM_5Bu3K7iV47EUTp2JH1B0tixmq.RQo_18lxQ4I957jGa3uZCXHrTkHMfj7ayLsTf838DrW04Eu Zb72det6Zc8zxuY2rr9Fm69wTnkxfsBQtskbhiYdZHyLDVvHj_6o8dIp8.9VgJrizVzN.IYVTLvN g4z0PuLREHE0mTQlqppajrZON2Bv64eUAAJiQm7CMnFKNPQu07GcHkgnWGbuTaEnkyLO5AkrmJ9q Nzo7lhRKrvyLDLTX9KgNsTyq1wCo0ZAhXHmAK58jZK79fJif.hbOtOd66YknW5QsOEIiU7wrpEgX 6y7cF4uGOV.jtpzDJYiANr2016YbkO9jmlEKKDL23Fz4wXVZjZpz6vey2AJAxMO3vhqO65bQqz13 w9Lg6KuBTRovKMEva_di1epZIczKriME3M9viLOCw0NMu57RsGXmfZpT7OPFHuPtYywScFxVjkAB FQIBAwjnO5U2W.rKUrVxoTCd33ATdH.3gIFcw_ZpXXG_gS8DbowKZwEba75TGLe5M5vrLiN2bfAH cxMKRE0AcG08MN1Z7T6DAqimA81PIDqrdspqP0lIbLP8ha1HeyxgDf26mZ5jQiNnntMCntRu0TkH drqZw0yHNPGOP4uNGh8AIaoWypfA0tCe.ejSeK8GleGy7I5WEqX29OPsWRG2g3YHO9Pj40S4KHlN vZZAbkaT0D_kcfIHF2cS60lK2kZ4UUhr5efiKBw3TTSIA8or8fn7.OyI7JwmmSb8llc1SuSfhtJA kV5Glli_h69vrhDq2uaFzkZA.UNA6YP8o6781GfUStYSgH0XK.HgKV3AAMH_ntEMDW3H8sYXB2kW YcWj9LHGlrKd0UFgoY3ktHkXl0xOaHvpEvHmS_MlaeaHb1INzoqBQzI.obXpwnl0CqanjI86eb_k 2fM44zyewmB2U5BZUg617YFFJs70yWOc_jr_RFBPIH0IpPwQyeIhequLxFS7oa4qfoiGxmesdIrE 61Wx.Q74lD5vkJPJJwS1Rj4cC7B_QQkALde94XHiFmpK.pA-- X-Sonic-MF: X-Sonic-ID: 32995032-351f-4f3d-b1f3-2db34182d857 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v4 0/6] xen/igd: fixes for Intel IGD passthrough Date: Fri, 31 Jul 2026 20:17:24 -0400 Message-ID: <20260801001737.16509-1-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <20260801001737.16509-1-brchuckz.ref@aol.com> Content-Length: 4795 X-purgate-ID: tlsNG-ef75cf/1785543464-A72DCAE4-5A5895D7/0/0 X-purgate-type: clean X-purgate-size: 4902 Please note that Patch 5 of this series also requires a patch to hvmloader of Xen for the new support to take effect that is available here: https://lore.kernel.org/qemu-devel/20260801000354.16446-1-brchuckz@aol.com/ This patch series aims to fix long-standing bugs that need to be backported to all currently supported stable versions in order to support passthrough of both older and modern Intel IGD devices to Xen HVM guests. Note that previous versions of this patch series only fixed the bugs affecting older devices and the patches needed for newer devices were not included, so this is the first version of this patch series that is suitable for use and testing with newer devices that, for example, are designed by the manufacturer to only work with UEFI firmware. These patches fix several bugs that cause problems ranging from a dark screen in the guest until the guest OS graphics are loaded to an assert failure or other failures in newer devices that in many cases prevent guest creation from succeeding or cause other problems such as code 43 errors in Windows guests. To test the the third patch and verify it fixes the bug of no video output from Seabios, it is necessary to test with older Intel IGD devices that have support for legacy VGA bios (Seabios) because the newer devices, as far as I can tell, are not compatible with legacy VGA BIOS. The first three patches have been tested using Xen 4.21 and Seabios 1.17 on Fedora 44 using an older Intel NUC7i5BNK with an i5-7260U processor and have been verified to fix the bugs described in the individual patches. This device is compatible with legacy VGA BIOS and Seabios. With the fourth through sixth patches applied, it is possible to use/test with newer devices since, with those patches applied, the bugs that prevent guest creation from succeeding with many newer devices are fixed. All six patches have been tested on both the older Intel NUC7i5BNK mentioned above and a newer 14th Gen i5-14500 Raptor Lake processor in an ASRock board that, as far as I can tell, is not compatible with legacy VGA BIOS and Seabios, which means that, although one can successfully create a guest with Seabios for the guest with the newer device, there will be no graphics output from the guest until the guest OS loads the graphics drivers when using the newer device with Seabios. The sixth patch is provided for use with newer devices that require an EFI graphics output protocol (GOP) driver for graphics output during early boot. For more details, read the commit message and the accompanying notes in Patch 6. Two hints to help configuring Xen HVM guests with Intel IGD passthrough: - Increase the value of mmio_hole from its default value of 256 to at least 512 using the mmio_hole setting in the guest config. The value of 512 works well when the stolen memory is 256 MiB. If more stolen memory is used, the mmio_hole may need to be increased even more. - If there are rdm conflicts, lower the rdm_mem_boundary setting in the guest config from its default value of 2048 to a value at which all rdm conflicts are resolved. I have discovered that lowering it in 128 MiB increments works well. With the older device I needed to lower it to 1792 and with the newer one I needed to lower it to 1664. See the description of the rdm_mem_boundary setting in the xl.cfg(5) man page for more details. Changes in v2: - close open files before setting errp - improvements to readability and style - small corrections to the commit messages - add stable to Cc list Changes in v3: - whitespace fix in first patch - fix Cc address for qemu-stable Changes in v4: - add three patches to provide support for newer Intel IGD devices - edit the commit messages for better consistency of style - use 12 digits instead of 7 when referencing commit hashes - re-write xen_pt_get_host_pch_info() in patch 1 using the functions declared in xen-host-pci-device.h - handle errors in patch 1 that in previous versions of that patch were not handled - add a Fixes tag to the third patch - add two hints in the cover letter to help those who are trying to configure Xen HVM guests with an Intel IGD passed through Chuck Zmudzinski (6): xen/igd: get PCH info from host sysfs xen/igd: don't register rom bar twice xen/igd: fixup device id before registering rom xen/igd: enable guest creation when ROM read fails xen/igd: implement support for extended VBT xen/igd: use custom option ROM if provided hw/xen/xen_pt.c | 13 +- hw/xen/xen_pt_graphics.c | 280 +++++++++++++++++++++++++++++++++++++-- hw/xen/xen_pt_load_rom.c | 64 ++++++--- include/hw/xen/xen_igd.h | 3 +- 4 files changed, 325 insertions(+), 35 deletions(-) -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:17:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:17:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379721.1624156 (Exim 4.92) (envelope-from ) id 1wpxQH-0001XR-Hr; Sat, 01 Aug 2026 00:17:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379721.1624156; Sat, 01 Aug 2026 00:17:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQH-0001XK-EH; Sat, 01 Aug 2026 00:17:53 +0000 Received: by outflank-mailman (input) for mailman id 1379721; Sat, 01 Aug 2026 00:17:52 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQF-0000ut-Ts for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:17:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxQE-00FX1B-Pu for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:50 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d3ada-2eae-0a2a0a5409dd-0a2a450bdfc6-30 for ; Sat, 01 Aug 2026 02:17:50 +0200 Received: from [98.137.65.31] (helo=sonic315-55.consmr.mail.gq1.yahoo.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d3b2c-b7e8-0a2a450b0019-6289411f9269-3 for ; Sat, 01 Aug 2026 02:17:50 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:17:48 +0000 Received: by hermes--production-bf1-54b5569bdc-h5zdx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 655a093bcead2c5289eeab02aa189b76; Sat, 01 Aug 2026 00:17:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785543468; bh=e+hFrPKjm/qktFvrEGDQAvmP2RXLyh9VDR7iL4Z1uvE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=YTkrELbZWKdR6MlF3on4FPg7soY/Dc92529AE8IAES+R9eHjMSTIQtUmJV53clCHzIxdW1PBg8jCqy/IkNylsIIMjLLgzJhXKYTzoaafStyZThLBKnOc8WILBxLgWjCp/Yqx0e9Fv4xFldUN+8xYuFOfh2zU1bVivDxgPZ5JkLm9Zv/pWJiw9TbHdqja/TFS0frXbaJbCmrYiJjfaw/R5PW+0Dr9aqLa38J3PvIslk6IFXq+f+nn8jR4MuSMj7sk3joDSqxLF9bUfgJjVV1qzCtugdHqfjN4PwxmLwBrEzhB7Wu4sJPL9HaQp+n2gCV29kv/W3J1uBsL8QGI4tSTfg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785543468; bh=ND82rFy7/zOVwXsz/RHMs6SkJ7Wu+/qRU6xlDEOWfxF=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=snGXE5kMidyeL6q2BmQQrjYREoQyr3mCUngVDBAvmhtBzHxCg8kFonZhm82Ct97clMwTGmSdSCk+gEAGVsqcPMrctnZnyxtWgQgTKrrFod3gS5vorxHpY2xmQeldjcD2/CqycytY7jYZwnOCM8M7Rmlw3/W88L21/x9WfCVoT27gcHrDAWosXTZ9Ky1TILj3dAjt2/3u8bObwGIOcMfo4OhJUs5p3OrqLR4igQ+c80V7RbM89wZ9wa5mvGCpLLuverQbqMt+N8OYfCh91Jw5DhFnwWirfRNF1WUpVRwKH1/seKW2/2Fzl0A4HhvTVND08QGsWpa421eDO/eNCQYzSg== X-YMail-OSG: DO9eCQQVM1kM2YtzD1yVaZ6ZUBpRnIAxSCKVSwdHs7_TF8pvf6vHY8nncsOK5c9 nm7l2gzBy71iJPUHoF1UJEQXM2gAyrmK3.fVq0m19RSPW6i7ghwnotPYWE9oUMdTfqWA5w8sqLwu cS0MZD4zMSREe6ZnYmzXk3Z.wDo5bO0UIDHFD49VtrfHEh9m6a2d8DmVKOS2cSDXYC3LZnQa7B60 OinNH4CJ68t8C9GpxeEMKsIOpdzlAl1wfVQa6elCfo9asebZobxeAtMHu9mjKhJ0g87jEago.KJd GliNj2g9WG02NHVie51Den6jKehkK616TYLPxc1qn7GPFw3ekwY81.mP61.UcXGmMT0S2bxOD0q1 oGYt393F4hvoAlLWT1c4_h1PVxKq97radMKhEP7Eq8er.t3smg118OFQ2dhJGcqf3DyT780oMPsX 3zYYqI2st3NoCgdBSvzN2BE7Kn9HRpDhdDewAFazL3Bpe3OfiQWIWsXiJINzRsd56KMyEfIUvS29 cX08sTJrcliVQtPWBaoZAWzrqLl6MD5SqoiaQ6J4CmwRmWfJcNe8VTqiHsbcgfFjKTK5x7oZQOEw iULHNJ2UnfxfMVKrQoYl1OIcPKyQK8x11c4zml3WJ4SVHA2KuFCqfjo3ih9fbz8mNO8HJkVQugQ2 iGztX0lwG_GuBAzZ99awjIIhcRLLddIgVnqec_sv3C2P.JN.kPS6cBl5nQK11q4t9XeWyLrTXVBp seO5KajhlyRZjSRzOQO3.Mz_xwbV0KOS2P6eSx1RAtcNSgD7.le8BLSgfGFb3dkP1ncMejQN7_Wi G0p_hBfUFLX0.tbduCD6ydK_Bs0bqyth0PLVEL1zPkPoHQzjekPWMHbQr3b0na47Yi70rf8kusla FpG9yJ619HS5uClZeIfL1hILR25jfeGDUBbB4F8.PmQmDIF5FqzD.vqDgS6zbnhipPbkAlO_aZPt g0YLm1vZDakTnMiADxiqhoq_edlWU19pHzidiHs6HhDKJNIxFefzXrRnPz_8TXvs.wOVSaJILEtV fwvZCPlbSLzr8AZKTenQu5eEy1BHjAT205yA0AD_DAbneHqOGUKPuzLHRsNJZkXI_LdC7.StCO7a G2XCP1JDcAH9YaYEsavjx_wFpwPVx.88DY9HE4u8kPN48l95p_yVRMRI_lwWZvjvsYgbuUD.kYY9 vn4F6DNvmEfNKPVqBl0w..usKwaI6tsJgUylmkrGaohSyb23svwN3CtW8elWWsWRGjn_SErqNYWJ FmDoWts7FKkoLi7tapxrlY9ULZSftmFlIUQe_dQIi5C79QXHlMixwJRmTsae8_u0txkL5Au31Etj w3OBLOqW5KTTEPMhrNgNysVuS6t1wmcNCJpgxhjAYoehEBGWeHamfG96xYNlIfPF6KGO9TntH8oT _F3ErcVKpJpvKsAUn8rPNtpYaH25xQwbBXR8fF6tngzdt4woa43H2QzLww_Uejq_IdTYelviiQjE YAxn8FHweY53AiVuSAplB1Y3hF_c.hYntBQdeDkxnSt3ZLkdPa7jRz1e457jl4.Cqai4lIBwygfS LFV_vOa4ojrJCTt.gLdiCjNyetJgIGIYsGyAY0FtCUOiZYm6KuPrGA2hYx0_8fXCMczZc_aER.jv MxLRpzXq_ZSGZGcYa70fA8gyiIPFCdk2PBAprUAWWWjdBNSy8pMBHTjjQc7RjhKdZ.wBJQ7ZQrNy 6wr9lEG331x_kBpL53uFTLpyZQeHXSuPDw6T6zfa5QOKNDlCLWlH7KQwwa3MPWTPJZdTnYc.eVnm pP21mfpuMizuG7gn9bSpkPGT7paL_bvbR9wpnq4ZUrMUOLcqelltsLL47gIkR9aklUNRvQP9QHR8 3Inud10EKm1qS5AewB1nL7KgR0LPKtnQPV6Wp7lIkUlFrvzDwn4850jA_E3Rp5BMB1aM5ahXlURX yoZv1hv1UqKFhqV18f2KLSzP1uFWC1UfzycfhPkNrk6_uq27bBbcE4zrMKrXqeCICMqGFkVdZzOv RZiE_Wjwmux3REQgiXSqzwubTOixMLdlhrJgutvA_utRTRed6VZvTY08df0PauK4V4IiSLSmrf7. peCrAcEVTPs0TI9pwUfr4rBx0kiD2PVeEf_La2_810yj3yjJ7JV1k1Zr.UoD629GBTWokb7IIIZg LJ_qLeyMWKHtUdwM.kIzlX02aKzPpeJBPcBWML9iyo6oLAMBDCsmWGNL2_UUJhRQdHpB.j6fvYpq 0050.U8NXXacnZfDFs3sVPNZ0QnTYgCPPQVLT7kl9xAMe99VpMQ-- X-Sonic-MF: X-Sonic-ID: e5ab0868-b2cf-4cbb-9ca7-34935d8b786d From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v4 2/6] xen/igd: don't register rom bar twice Date: Fri, 31 Jul 2026 20:17:26 -0400 Message-ID: <20260801001737.16509-3-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260801001737.16509-1-brchuckz@aol.com> References: <20260801001737.16509-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 1267 X-purgate-ID: tlsNG-42698a/1785543470-1BAD09EA-624BBA8F/0/0 X-purgate-type: clean X-purgate-size: 1305 This also fixes a failed assertion in pci [1] for Qemu version 10 and higher when passing through an Intel IGD with an option ROM to the guest. [1] f6fc01c78666 ("hw/pci: Assert a bar is not registered multiple times") Fixes: 881213f1b9c5 ("xen, gfx passthrough: retrieve VGA BIOS to work") Signed-off-by: Chuck Zmudzinski --- Changes in v4: - Use 12 digits for commit hashes hw/xen/xen_pt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c8f08b5..4d159a2 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -459,6 +459,7 @@ static int xen_pt_register_regions(XenPCIPassthroughState *s, uint16_t *cmd) { int i = 0; XenHostPCIDevice *d = &s->real_device; + const pcibus_t romsize = s->dev.io_regions[PCI_ROM_SLOT].size; /* Register PIO/MMIO BARs */ for (i = 0; i < PCI_ROM_SLOT; i++) { @@ -495,7 +496,7 @@ static int xen_pt_register_regions(XenPCIPassthroughState *s, uint16_t *cmd) } /* Register expansion ROM address */ - if (d->rom.base_addr && d->rom.size) { + if (!romsize && d->rom.base_addr && d->rom.size) { uint32_t bar_data = 0; /* Re-set BAR reported by OS, otherwise ROM can't be read. */ -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:17:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:17:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379722.1624165 (Exim 4.92) (envelope-from ) id 1wpxQK-0001ob-Pw; Sat, 01 Aug 2026 00:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379722.1624165; Sat, 01 Aug 2026 00:17:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQK-0001oU-Mc; Sat, 01 Aug 2026 00:17:56 +0000 Received: by outflank-mailman (input) for mailman id 1379722; Sat, 01 Aug 2026 00:17:56 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQJ-0001mv-Oj for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:17:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxQJ-00AjYh-5k for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:55 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d3ac2-5cb7-0a2a0a5109dd-0a2a4508975c-34 for ; Sat, 01 Aug 2026 02:17:55 +0200 Received: from [98.137.65.31] (helo=sonic315-55.consmr.mail.gq1.yahoo.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d3b31-f659-0a2a45080019-6289411f9b38-3 for ; Sat, 01 Aug 2026 02:17:54 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:17:53 +0000 Received: by hermes--production-bf1-54b5569bdc-h5zdx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 655a093bcead2c5289eeab02aa189b76; Sat, 01 Aug 2026 00:17:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785543473; bh=ffO8qrCy0LABWluXubgddMD+88wzPHM657OWh8V4ys8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=jBEsPlsKDZ9k3OFUK2pNIuuFEyLSfjnjdOdeflcM4v+Iuc+0ClVkgXoYY/svRgtXdwNMMOj5MxOZzCh8OmgbY05QVK7S0EQVGjXbA/z0TYifQ6HcBjHU7kgvrYZlcXXUgcasTrSMBef8IPLNQJzA1c3dZrOwwfT1GUOxrxpIcdH68v/rVwh3X5dg2DoRJ0B5ELph6O7Xw/uWzQnlZhJCUP57DHZOhKlwU2ZBnNVw54WnfS/rG6B0KSefzZ1+LQpi19a8OptFY2UaizDVK2r97xYvtolsNxAvwQSgzXcTksXj6WSi89UqeAOw+Je11P3+Sn5RlyEgAWTRoMOXhhcYAA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785543473; bh=kuDA4OeFX9PVEeDeut7LzAaV7cmzKLjJEjtDq8yrl7C=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ah8qZSRF+83WizDbIeD1p/nOf1ufgUYy9ODrru1BhoHk1bID+XlbapZJlK3nbaEjkGYa2JYpJIwmpq9KS64VbJ/kRqruWPxXwU4P+SEaNXeBgQ+4ujW25yJyAZo2Las9zn+Gv7l9naY5dgBtpGhC45RjRiQcyEeASAkrn0bBPySmU4VARCFcruGUBwELyWmhgZkAcp9Bm0ms3qFO5tGQWGildXOTgCOnvgNsSA0rRYoFR8t86XxCI5elBvaGeb4Q1ccTAbd9eMk6gWXZoQQwvYUTx4udbL6DgKjwCX6WbogjCfnmMo79/UF67QimBgljSOZVEJuypPLTvnrpRK9oCQ== X-YMail-OSG: .NpycOsVM1n53CI.4.B7xsmBIgwyCi_2EPd5rWydy.y4Jx4SOCYE2eEJ5PUQZ3k yPsyl_7JvTWTXRpTdq4LYYGUNXjMQfAv4eKdwrpnKtHYCo9PNJntOrIFdkkgXGsJtYUHf_EFo4Wg t6_b.9REPKN9Hm8ov46q5b584SuQyo8V38u.VHTBAZ3sNd6Lsv32a2e_N9gmiap71hcSlLyPZRVD LdR5O6wdUt8cYkVbHcwLOO2ql6UXi0E3ecZ_4VPh1IS708crJmcrx3_4H9Zqx0Er5q6ypDOdoy6a aB4De4X7.PzHhxyLJwAB4D1oDsZkpppMk34TXVQXj7XsD0NZSQSTBAg7fdHAVMHMUYiWTtD1aay1 _Z.Inm.TPl60eZ5wWeiIgkUtHe666jIny9S0LE6yB0X35ItXpNdJtbopxSh3wOp8Hzlw32vbrOCi Gr0O6QCHO4oEVKigOtlnOPuGYPuKAyYT9VQgZl3qzPcZBQFzpqdNXrx_8Uuy00TwSaav9RDQCG6N 48m6jAN8aO2lzlYf6Nh62C9N3WeR78QfkOEuNFGEkIeHAn3hi3Sm2Q100c0.tm11pVQZ09c7UB40 _YTZ5r2xqzelhc9iuNUXCQYCJWdSWQgrK4.SODSIRj5eeeW5jB9R2MC7CuVuEHRGp0BUqC1MFKgc eBULYVninRRrVEfHDzm8hU7TBPWoYB4ymiaW6RTPBegJpUH_nTvnNFrII2hi8ueffnmYmNzdivVU qA4TyibE0TGsUrDZImr6iGUwDqLFXuZHHdllEadGvzviJ2TDKgzhRy.L9UFzfXa65caBkZ6C6OfS lWtNV0ffqmVniZm8X3kh7JrZaenOVtYzE0u9SI8NZJd9QNFLiO3Fvw1OLXaV1RSc8tGcuDb4R.AH nfmmyIuUyMiTzUmHPhn4s3ila.2ot0DURu264JPjWLml2UL6p2XBJ1RvgHeTPErCiX8._cMVQHfb MBQQljgrx1dSJHxiMwqQWaC.8QKbUm1lYSm7Vh50bACkhzRiN.JOCaM5PhLxhKjjJ4Ovgbk.mJUu PtyobS.4uknqGkrFWSuQakYOtqcMxw2oxYaM5bp5auSwk7ExnLjSfB_RYp2CxeK3wQwlDKWYXfLT v8iiCd67R2vGvmu.f166JZqfHc3H4OE9Ua8yfmchOC8liPHIPBC6BrunMUh59oRphcDWfuKk4CLS ZONTkXuq.XcUoxVEj2TpZT.3WMvu2Sg3S2qfAs4U6oPkuZRK0UQL5KzsTPd99c8mgbLlBAp0K80E 0k.LoaSq_sAvOXmBg.XNgRlKL2eVIih2lLaduFxuSnGrH9mLF5yRWqP21gIkZIS_JMQkln1E91aa nO8J6qUi5B3ZttmOcfniCcGld1Liwpjv6UZpeDNRBMg5IMM.iCZGGEEdr2w8pWtcALGTPo_goGEy UzIPXclVB3DRKqykBe0uJ6IEJauEGYpXj2CRww33kMFdSDvwriLv_iTZviDcHNTmyUyKJyDNUaQW X0OUJtLngRa04ZxAv4hQdTFqptK2TC2AAT9YKvPFFQATKbrgkY7QQq.EAGLnNazUJ.m37uk75DNY Gox2hTs2DiaD2RoDYYF1KmNUuKfu39Wy6oD_.rFp6lqXzx.n0QA.x6pVw7.CzirBwsjzYx2x4fxK TzPnMTcgZ2MqCJsGY.uqXi1RiuGuaqR53dglmzCnPKUM9KLkGBSHGWN9tKzcYAP3BaqDXffHMTIl RLxHrI9OJ3f1OYSYXPf2qIHEZIwPAFkikqhQRJNu04VvZV4PHdnFT2KA6gmRe4YApZbqP1w2TQAJ oOotujPdAIY4S.Mu6v6ojACnWD1o4iSlt.ATJkQMZm9pED4Vqm.SoZs4c_sWNhDckPfHJi8ZdR_K 7KowPOpIlyz.vCu49qlDW6PWXl2iZkgsQQVprcFk03OgBldqz9EG6sc3btedLB2opDobiBH4aDx_ gbWOOCXYEr9MmkbU9KZ60_5tuVxx7y79oR3Kua6giOCegMdtbd9YYLOuRFkg.UStCnnlyuSZgcZy vvIakHp9bk7rndw7SC9Y44sI.2HibJATn1Je6GSJfE5BEUSVmNtWsyqV83rqBcBPm9Dzj2oEkpdh _7E_mFC4M0xtu7U01UdOSHT0Dj5aqXBzK8N3KeQUD7ORBN3HptKdarioYdt5grFMFdfHdcfsm.o_ uFz9HFDHN0X8bbi8t4wUYXn0GzUbbROQZgCUYerUBa6dzOQWPh3UA9dTyc8ksssz_h20Fpa_ZIzd lEwaKmNTiKXf.GliX5Y4OCHMCKabx_u3I482.U2XSexQKndZxRw-- X-Sonic-MF: X-Sonic-ID: 8c31a32f-648a-4935-9991-1504277b6dc1 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v4 5/6] xen/igd: implement support for extended VBT Date: Fri, 31 Jul 2026 20:17:29 -0400 Message-ID: <20260801001737.16509-6-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260801001737.16509-1-brchuckz@aol.com> References: <20260801001737.16509-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 14630 X-purgate-ID: tlsNG-c1860d/1785543475-D457487B-AEE13D86/0/0 X-purgate-type: clean X-purgate-size: 14963 Newer devices with versions of the OpRegion >= 2 require an extended bios table (VBT) in some cases and also in some cases require modifications to the OpRegion for proper operation in the guest. This is in contrast to legacy devices in which the VBT is always embedded within the OpRegion. This makes the current approach of providing only the unmodified host OpRegion to the guest with no guest access to the VBT insufficient for proper support of devices with OpRegion version 2 or higher and an extended VBT. Support for extended VBT also depends on compatible support in hvmloader. If such support is lacking in hvmloader, fall back to the current protocol that does not provide support for extended VBT. To implement support for extended VBT: Instead of configuring the guest with access to the unmodified host OpRegion via hypervisor mapping of the OpRegion from the host to the guest, temporarily map the host OpRegion and VBT into the guest, allowing the guest (hvmloader) to get copies of the host OpRegion and VBT which hvmloader can modify as needed to support cases that require modifications to the OpRegion. In xen_pt_unregister_vga_regions(), do not try to unmap the OpRegion in cases when the OpRegion is not mapped during normal operation of the guest, and replace the constant '3' with the macro XEN_PCI_INTEL_OPREGION_PAGES which is defined to be 3. To implement this: Use 'done = true' to end further processing when the OpRegion does not need to be unmapped in xen_pt_unregister_vga_regions(), and use 'guest_supports_opregion2 = false' to end further processing when the OpRegion does need to be unmapped in xen_pt_unregister_vga_regions(). The OpRegion 2+ support that can be provided by this patch and a compatible patch to hvmloader is required to fix code 43 errors in Windows guests that have an Intel IGD with extended VBT passed through to the guest. Link: https://lore.kernel.org/kvm/20211012124855.52463-1-colin.xu@gmail.com/ Signed-off-by: Chuck Zmudzinski --- Changes in v4: - v4 is the first version of the series that has this patch The companion patch to hvmloader that is needed to make this patch take effect is available here: https://lore.kernel.org/qemu-devel/20260801000354.16446-1-brchuckz@aol.com/ hw/xen/xen_pt_graphics.c | 231 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 223 insertions(+), 8 deletions(-) diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index a124233..3d2a94c 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -12,7 +12,26 @@ static unsigned long igd_guest_opregion; static unsigned long igd_host_opregion; +/* + * These are true until they are set to false when the guest first + * accesses the OpRegion address register for a read or write, + * respectively. + */ +static bool first_guest_opregion_read = true; +static bool first_guest_opregion_write = true; + +static uint32_t guest_opregion_extra_writes; +static bool guest_supports_opregion2 = false; +static bool done = false; +static unsigned long rvda; /* absolute host VBT address */ +static unsigned long vbt_guest_pgbase; +static uint32_t vbt_nr_pages; + #define XEN_PCI_INTEL_OPREGION_MASK 0xfff +#define XEN_PCI_INTEL_OPREGION_PAGES 0x3 +#define XEN_PCI_INTEL_OPREGION_ENABLE_ACCESSED 0x1 +#define XEN_PCI_INTEL_OPREGION_DISABLE_ACCESS 0x0 +#define XEN_PCI_INTEL_OPREGION2_SUPPORT_MASK 0x1 typedef struct VGARegion { int type; /* Memory or port I/O */ @@ -117,11 +136,11 @@ int xen_pt_unregister_vga_regions(XenHostPCIDevice *dev) } } - if (igd_guest_opregion) { + if (!guest_supports_opregion2 && igd_guest_opregion) { ret = xc_domain_memory_mapping(xen_xc, xen_domid, (unsigned long)(igd_guest_opregion >> XC_PAGE_SHIFT), (unsigned long)(igd_host_opregion >> XC_PAGE_SHIFT), - 3, + XEN_PCI_INTEL_OPREGION_PAGES, DPCI_REMOVE_MAPPING); if (ret) { return ret; @@ -239,7 +258,30 @@ void xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev, uint32_t igd_read_opregion(XenPCIPassthroughState *s) { + if (!igd_host_opregion) + /* We just work with LE. */ + xen_host_pci_get_block(&s->real_device, XEN_PCI_INTEL_OPREGION, + (uint8_t *)&igd_host_opregion, 4); + + /* + * By returning igd_host_opregion here instead of 0, we can + * indicate to hvmloader that we support OpRegion 2. + * + * The conditions are there to prevent returning igd_host_opregion + * to guests that have a version of hvmloader that lacks support + * for OpRegion 2. We do this to maintain backward compatibility for + * guests with earlier versions of hvmloader that always expect us + * to return 0 instead of igd_host_opregion when igd_guest_opregion + * is not yet set to a non-zero value. + */ + if (first_guest_opregion_read && !igd_guest_opregion && + first_guest_opregion_write) { + first_guest_opregion_read = false; + return igd_host_opregion; + } + uint32_t val = 0; + first_guest_opregion_read = false; if (!igd_guest_opregion) { return val; @@ -251,21 +293,194 @@ uint32_t igd_read_opregion(XenPCIPassthroughState *s) return val; } -#define XEN_PCI_INTEL_OPREGION_PAGES 0x3 -#define XEN_PCI_INTEL_OPREGION_ENABLE_ACCESSED 0x1 void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val) { int ret; - if (igd_guest_opregion) { + /* hvmloader with OpRegion 2 support uses lsb of val to indicate support */ + if ((val & XEN_PCI_INTEL_OPREGION2_SUPPORT_MASK) && + first_guest_opregion_write) { + guest_supports_opregion2 = true; + } else if (first_guest_opregion_write) { + XEN_PT_LOG(&s->dev, "hvmloader lacks extended VBT support, " + "continuing with legacy support only\n"); + } + + if ((!guest_supports_opregion2 && igd_guest_opregion) || done) { XEN_PT_LOG(&s->dev, "opregion register already been set, ignoring %x\n", val); return; } - /* We just work with LE. */ - xen_host_pci_get_block(&s->real_device, XEN_PCI_INTEL_OPREGION, - (uint8_t *)&igd_host_opregion, 4); + if (guest_supports_opregion2 && !first_guest_opregion_write) { + /* + * OpRegion 2 is supported and we are processing + * additional writes that the legacy protocol ignores. + * + * We should always return from this if block to prevent + * executing code below which is only for the first write + * when we map the host OpRegion into the guest. + */ + guest_opregion_extra_writes++; + switch (guest_opregion_extra_writes) { + case 1: + /* + * Hvmloader expects us to store the value as the least + * significant DWORD of rvda. + */ + rvda = (unsigned long)val; + break; + case 2: + /* + * Hvmloader expects us to store the value as the most + * significant DWORD of rvda and unmap the OpRegion if + * rvda is not equal to zero. + * + * If the unmapping fails, hvmloader will fall back to the + * behavior of older versions which simply map the OpRegion + * from the host to the guest without trying to configure + * the guest with OpRegion 2 with extended VBT support. + */ + rvda |= (unsigned long)(val) << 32; + if (rvda) { + ret = xc_domain_memory_mapping(xen_xc, xen_domid, + (unsigned long) + (igd_guest_opregion >> XC_PAGE_SHIFT), + (unsigned long) + (igd_host_opregion >> XC_PAGE_SHIFT), + XEN_PCI_INTEL_OPREGION_PAGES, + DPCI_REMOVE_MAPPING); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't unmap IGD host opregion:0x%lx" + " from guest opregion:0x%lx.\n", ret, + (unsigned long)(igd_host_opregion >> XC_PAGE_SHIFT), + (unsigned long)(igd_guest_opregion >> XC_PAGE_SHIFT)); + rvda = 0; + guest_supports_opregion2 = false; + } + ret = xc_domain_iomem_permission(xen_xc, xen_domid, + (unsigned long) + (igd_host_opregion >> XC_PAGE_SHIFT), + XEN_PCI_INTEL_OPREGION_PAGES, + XEN_PCI_INTEL_OPREGION_DISABLE_ACCESS); + if (ret) { + XEN_PT_WARN(&s->dev, "[%d]:Can't disable access to IGD host" + " OpRegion: 0x%x.\n", ret, + (unsigned long)(igd_host_opregion >> XC_PAGE_SHIFT)); + } + } else { + guest_supports_opregion2 = false; + } + break; + case 3: + /* + * Hvmloader expects us to store the value as the address + * to map the VBT to in the guest and to map the VBT at the + * provided address in the guest. Hvmloader encodes the number + * of pages to map in the least significant 12 bits of the + * provided address. + * + * If VBT verification fails, hvmloader can't determine if the + * VBT is mapped but corrupted or unmapped, so it crashes the + * guest as an unrecoverable error. + */ + + /* address (gfn) to map VBT to in the guest */ + vbt_guest_pgbase = val >> XC_PAGE_SHIFT; + vbt_nr_pages = val & XEN_PCI_INTEL_OPREGION_MASK; + ret = xc_domain_iomem_permission(xen_xc, xen_domid, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, + XEN_PCI_INTEL_OPREGION_ENABLE_ACCESSED); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't enable access to IGD host VBT:" + " 0x%lx.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT)), + rvda = 0; + vbt_guest_pgbase = 0; + vbt_nr_pages = 0; + done = true; + break; + } + ret = xc_domain_memory_mapping(xen_xc, xen_domid, + (unsigned long)vbt_guest_pgbase, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, DPCI_ADD_MAPPING); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't map IGD host VBT:0x%lx to" + " guest VBT:0x%lx.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + (unsigned long)vbt_guest_pgbase); + rvda = 0; + vbt_guest_pgbase = 0; + vbt_nr_pages = 0; + done = true; + break; + } + XEN_PT_LOG(&s->dev, "Map VBT: 0x%lx -> 0x%lx\n", + (unsigned long)(rvda >> XC_PAGE_SHIFT), + (unsigned long)vbt_guest_pgbase); + XEN_PT_LOG(&s->dev, "VBT host address: 0x%lx\n", rvda); + break; + case 4: + /* + * Hvmloader expects us to store the given value as the + * final value for the register that stores the OpRegion + * address in the guest. We also unmap the VBT since the + * guest now has its own copy of both it and the OpRegion. + * + * If the unmapping fails the VBT will be mapped where + * hvmloader needs to place the OpRegion plus VBT in the + * guest E820 map. In this case, hvmloader will crash with + * BUG() rather than try to use the mapped VBT with the + * guest's copy of the OpRegion. + */ + igd_guest_opregion = val; + ret = xc_domain_memory_mapping(xen_xc, xen_domid, + (unsigned long)vbt_guest_pgbase, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, DPCI_REMOVE_MAPPING); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't unmap IGD host VBT:0x%lx from" + " guest VBT:0x%lx.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + (unsigned long)vbt_guest_pgbase); + rvda = 0; + done = true; + break; + } + + ret = xc_domain_iomem_permission(xen_xc, xen_domid, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, + XEN_PCI_INTEL_OPREGION_DISABLE_ACCESS); + if (ret) { + XEN_PT_WARN(&s->dev, "[%d]:Can't disable access to IGD host" + " VBT: 0x%x.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT)); + } + + done = true; + break; + default: + break; + } + return; + } + + /* + * This code handles the first write to the register from the guest. + * It maps the host OpRegion into the guest. + * + * Set first_guest_opregion_write to false to enable more writes + * if OpRegion 2 is supported. + */ + first_guest_opregion_write = false; + + if (!igd_host_opregion) + /* We just work with LE. */ + xen_host_pci_get_block(&s->real_device, XEN_PCI_INTEL_OPREGION, + (uint8_t *)&igd_host_opregion, 4); igd_guest_opregion = (unsigned long)(val & ~XEN_PCI_INTEL_OPREGION_MASK) | (igd_host_opregion & XEN_PCI_INTEL_OPREGION_MASK); -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:17:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379723.1624170 (Exim 4.92) (envelope-from ) id 1wpxQL-0001rl-3t; Sat, 01 Aug 2026 00:17:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379723.1624170; Sat, 01 Aug 2026 00:17:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQK-0001rK-Ts; Sat, 01 Aug 2026 00:17:56 +0000 Received: by outflank-mailman (input) for mailman id 1379723; Sat, 01 Aug 2026 00:17:56 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQJ-0001n2-St for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:17:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxQJ-00AjYh-9m for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:55 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d3b2e-5cb7-0a2a0a5109dd-0a2a4504e2b2-2 for ; Sat, 01 Aug 2026 02:17:54 +0200 Received: from [98.137.65.83] (helo=sonic313-20.consmr.mail.gq1.yahoo.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d3b31-b57f-0a2a45040019-628941538f8a-3 for ; Sat, 01 Aug 2026 02:17:54 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:17:52 +0000 Received: by hermes--production-bf1-54b5569bdc-h5zdx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 655a093bcead2c5289eeab02aa189b76; Sat, 01 Aug 2026 00:17:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785543472; bh=em0LfYUuUVS4dEN9yvrJ5cV2XhQB99q5Rt9+dzqOtV8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=doRUbXE9lp7Rw1ayMqIEmMaOq61ZZ18P651yd9qLvqvHwwgEheT9s29kPcvdAeSzqcBy6E8q64wx5G5tndqx9taq34l+lIRQwVh6qnZDj/lM4u9Ld0DtB4WOY/ECilS30+DLMbC7kWpPRX5oWH+pkwTiG6QxiZU4kJz/0S4nCa44WZ0GwmuXqUGIsboRXuSc02t1bkqmzaTrhVa6l5rS5560B6VgTwIlYLZy7F+jPmBT3AAZ9Xo+loKmx/aYQG4/yzHHiFt8scqNqhVbCTB9ag3jA98bEEZHFwTqpem7kSeb15QrFszZ3jhRCyT10JkxnR6DkHxC5pNSdORxBPOkwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785543472; bh=yestQipyg8w6O7Lx6tHhvERxFQ0+EPj6fbFiGqFivaC=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=DTmMbpPHouEZffyYD8i9ETwRQGkBBS3lYG+EYg4WLNsBbUmCKx7dDieFyKWDTVTv2ZQr7+BovBgUXBxANgLu6pCmhha7XO38MurgyOGerYQbngzK9BVo8dhW37UX4pRfnKeYcWww8c5YNZGzk3hctyE3ffiDS5DLKUYkt+VbuY22X3yAJ6bn6DAOo1vVE1Q5Bax+QzIuGHNCalgMdNHMyiwe4L1OkOEZ6NY5JeXS/5MDXQnCOhen6UwzcwQKoI2/abeGb3iU2EEGH0+iAgq2pf+ixr13WwMdPP8jJ53daEMJalERFLwhm3ftGOGlLWb5Ccgud9ccq/ObmL6UmyJ4Dg== X-YMail-OSG: ZBJJFDUVM1lYaflSIDnAPpefQzBjC4MCmcdUwDWYRCTlsqVtBUN8I3KXRUt7uwI _o4JXcUdynTxGYpD0TiJttBaPsU_GzIRhTB1wLEe2QaVIxdAu9l9STMG2Z1IJ3TSDlROqk7kwN16 JtKWp68X16juyC.0rrf1wsK8xzlRAgE_hCR_TQUTVY8pv_Efo4B6HRuv6kHabfUBbH8k3204IAHL Cj3oK2qEcz8FiooQeLJWzHtVS8l.anoCfh5ln6uKgp01GArbjTRSJzoQJJTUpNPVSB_wwpC3le_g eQ1GKRYu_uDTT5k_XSICpSVlF3I5a6u9q3BZSiRZgKk_.MTmpFj0GTPhAxcflKfrK3WiToTmHCzX B9bvu3HZYjMmAiigmEj2GADLKskO2NRxO5TWYMJiWgHpwX8URruzNCuMulKfqWYG.sK7tt4dg1JT fUDhQhoQ6Dvk.HRKKyzjSvY_ZiNtMX1B94oueWt9PK.hKcmXsxxx3a54LH_tDpiEXLhUIvNB7hQN 8eypeFZDIzUk1ChUmNWKp69KNNaHOf7dnB21Nmocr8vq855JFf.qoZ7pwQhtIu1kArw4Wl39eiIq rU.YIsEOfUkX_FbqMy2Ms_FGXMrtea122Z4Nz31bXsWE7.uObJ9WfBYUQHMcbB5.fwLulmeN5aPL KC_3HWLYLIw3AkjB5v8WHiOwCG4vzPm4GGV3xb8WCTVsmqVdVh2tXs8P.RKrjdSTIyfEQ6iHqxvU RlDmAabVweD5RlyfudSK7Az7ScWSTQKyytzQknB0bEeZLo2lYVTFNO9s5Weqxzbxz.8moPuS8.GP nbWqfYo0f1cSAkFRFPEL7rQf61B.kblH.6emi0IABxaxgpLzY4zeWmHU6WS8ZzJuie2LI83U1g25 HUpa68WQC1XKpFm4wJDkb8ZHYB1b.S7AdrJkmHBRqdyq4nyi60KnLYSsJvIFgTqZv9aE6kpa.HCG n8l0wX8m5Prsg6Ft6UARtQKwUSjUM7gl0X0qEhFxAbkWdsmNc9NQQSSOfF83FQytVvRf7xlj5WPm G_sMbnLvkec7xseQ3w_fx97BbAkjgUgB06BqdvJpnUevZjiKA3AsXJb.bC0ehYnIAUCJccp9JIVX fESuncfIaoqdox8NDaGuoN9JlAzaVPXyMzAf4zT2TEDOahj6nthRmV2sNU_gdywJOiBprSxtF93N PDkSpcfb71ejOuzoIsypf7j..31h48pv1yvIIRfXgxEm_uSgWUDK4q2Vtniav7jwzgBayXvVSzAE 5FwBEJCbrXNso2uWlpzeqWKhM.xU83jX6d98QXQI2bXjzpxx7V3CbjOazm2BdHDus9nONyLikHQA _e.7ZP8QMdssc0y4PoPNQPrzvLw8pHtNqtupbjCRNd9aTw7l9oENEAa2cvKa93T8YCAt9AgGiF17 31Qu8vRvkrE2wOsenoJWGaCfcgVGyGDM._HoxaE47A8QJurAImSBcpVzy_XaLBBjOF3z5TQwvBW0 a6vLYSvD3jVk9M5D.GsThs3R3_Cxe2Wa4dqPUd4_3NxiArQi8apD7PZWd1MtxflBbd8vTLokKbYT LfM0EBzVcMEVh8hAMd88I0qF3VOGFmerdA6aAJlDX2zHtQK7jCknrgKxbnYkVoZf_mxyBUsmF9gf bVU7kyspB3vjjAggfIw6Uwrdx2zuWnWcwz7ro3PHV7lxO4kbF.UQ8lp3jyZ9kCUJrPN2DigiZxMO CM5XKGIehm2d6nPi8anaRc1lqvWNoHkL64PXXLJU8WKriO3VITE13CmsywIT6aoBiz_jQS1cZGAs eETHs997pF_RXMPNkHh73JYq749g7v_EZsskKlZhSbXYYBwzNyUyDQCNwenpSZcEdkXMnLKMKA8h IVn_lFBSvaGXEeSJXinIrBetw7PGjXfCvKn_fBC4ZWyOmnn5N.2fuH4PlttdNkzA89Ua6DQvfSOq WRD1q35q3kM7bjPqG3DxAt8_hGdflXBG8Mi7YeTjij14kzr7czxyCgjMc9mOkguEJ2Y4QVwJlDWG 12uXZAR_0EMafDOYNTy.X.iWDC.mJD0jYcISkAHk12zPIXmBNF92n.91OsI_XnBW9CQoLcBiqSRO Hr92UI4itq08LYLbjah0vdv6v3zYndoXg1jMClUmCQM6Qef9RqnmXPLmXLiiHmNgkx5agREnPAPR pFmM4XOO4Ms0jS9U0uoR4qSJK3geka0zvQXsTocst6puucZLXoyWYBezv63Q.Ovu6Cgu8No2hTsj dqrp5z65dUz6QAisb5jkubRhabtev1kG2Bxun.bAAfP3vR75XZw-- X-Sonic-MF: X-Sonic-ID: 66360c73-547b-4fd8-8909-7c15d88570af From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v4 6/6] xen/igd: use custom option ROM if provided Date: Fri, 31 Jul 2026 20:17:30 -0400 Message-ID: <20260801001737.16509-7-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260801001737.16509-1-brchuckz@aol.com> References: <20260801001737.16509-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 8793 X-purgate-ID: tlsNG-ebf023/1785543474-C24CBB50-C52C0853/0/0 X-purgate-type: clean X-purgate-size: 9003 Since in some cases the option ROM is not readable from sysfs on the host, provide the option to use a custom option ROM file instead that, for example, could be extracted from BIOS or UEFI firmware and modified as needed for use with a particular Intel IGD device. The file must be named "igd.rom" and be located in a directory configured at build time as a Qemu firmware directory and its size should be a power of two, and it must be compatible with the particular Intel IGD device being passed through. If provided, the "igd.rom" file will be used as the option ROM instead of the option ROM file epxosed in the host sysfs. If no "igd.rom" file is provided, this patch has no effect. Signed-off-by: Chuck Zmudzinski --- Changes in v4: - v4 is the first version of the series that has this patch Sorry for the length of these notes but there are many things to say about this patch that are not obvious to persons without some experience of actually trying to use the option ROM of an Intel IGD when it is passed through to a Xen HVM guest. This patch is primarily for providing a way to add Intel IGD support for the OvmfXen platform to get graphics output during early boot from modern Intel IGD devices that are only compatible with UEFI for graphics output during early boot. Note this patch is not necessary for successful operation of the Intel IGD in the guest once the guest OS drivers have loaded. It is only needed as part of the patchset necessary to provide graphics output from the Intel IGD in the guest during early boot when using newer devices that are only compatible with UEFI for graphics output during early boot. Most older devices that are compatible with legacy VGA BIOS will work with Seabios without this patch, but they will need Patch 3 of this patchset to work with Seabios. Some notes on adding Intel IGD support for the OvmfXen platform: It is necessary to provide an EFI graphics output protocol (GOP) driver to the guest to get output from the Intel IGD before the guest OS loads the graphics drivers when the guest uses UEFI. This GOP driver is essentially the replacement of the VBIOS driver that applied to older devices that use legacy bios, as described here: https://www.intel.com/content/www/us/en/support/articles/000005749/graphics.html Unfortunately, with modern Intel IGD devices, the EFI GOP driver is not provided to the guest in the usual way of providing firmware for a PCI device in the option ROM of the real PCI device. So I included this patch in this patchset to provide a way to expose the EFI GOP driver to the guest. I was able to extract the GOP driver for my device using the UEFI bios update file from the motherboard manufacturer and the UEFITool available here: https://github.com/longsoft/uefitool That EFI driver can be wrapped into an option ROM using the EfiRom bin wrapper that is part of the edk2 project: https://github.com/tianocore/edk2/blob/master/BaseTools/BinWrappers/PosixLike/EfiRom I tried setting the 'romfile' member of the PCIDevice struct that is used by KVM/VFIO Qemu devices and emulated Qemu PCI devices, but that did not work with Xen PCI passthrough devices. Neither Seabios nor the OvmfXen platform could detect the option ROM in the guest with that method of exposing an option ROM to the guest. So I implemented this approach of substituting the 'rom' file exposed by sysfs with an administrator-provided file instead of using 'romfile'. In the commit message I mentioned the size of the rom file "should" be a power of two. I mentioned this because the code in pci.c that handles the 'romfile' setting for PCI devices enforces this requirement strictly on the romfile that Qemu emulated or VFIO devices use. However, I do not know for sure whether or not the rom file is strictly required to have a size of a power of two, so that is why I say it should be a power of two. In my testing, I zero pad the "igd.rom" file so it has a size of a power of two. I will accept the suggestions of experts on this question about the appropriate size of the option ROM file (I am not such an expert!). As mentioned in the message accompanying Patch 4 of this patchset, the official edk2 project does not provide support for the Intel IGD, but some OVMF patches for Intel IGD support are available online for KVM/VFIO guests, such as at the links below (they apply to the OvmfPkgX64 platform): https://github.com/cmd2001/build-edk2-gvtd https://eci.intel.com/docs/3.3/components/kvm-hypervisor.html#build-ovmf-fd-for-kvm https://github.com/LongQT-sea/intel-igpu-passthru With such patches it is reported that the passed through Intel IGD device lights up the display during early boot from OVMF and the guest bootloader in KVM/VFIO guests provided that the administrator provides the correct ROM file via the 'romfile' setting for the passed thorugh Intel iGD device and applies appropriate patches to the OvmfPkgX64 platform. It should also be possible to add Intel IGD support for the OvmfXen platform also but I have not seen any such patches online for OvmfXen and if anyone knows of such patches online I would be interested to be informed about them. I am also working on my own patches to add Intel IGD support to the OvmfXen platform, in private for now. If anyone is interested, I can make the work I have done so far toward this goal avalable online. hw/xen/xen_pt_load_rom.c | 47 +++++++++++++++++++++++++++------------- 1 file changed, 32 insertions(+), 15 deletions(-) diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index eaf0ae1..6c2aa8f 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -2,6 +2,7 @@ * This is splited from hw/i386/kvm/pci-assign.c */ #include "qemu/osdep.h" +#include "qemu/datadir.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/pci/pci.h" @@ -13,9 +14,9 @@ * need to be modified. * * For such cases, use this function to get a pointer to the option ROM - * from sysfs. Caller has the responsibility to edit the option ROM as - * needed, call pci_register_bar to register the modified option ROM, - * and set has_rom to true for the PCI device. + * from a user provided romfile or sysfs. Caller has the responsibility + * to edit the option ROM as needed, call pci_register_bar to register + * the modified option ROM, and set has_rom to true for the PCI device. * * This function must be called before xen_pt_register_regions is called * because if xen_pt_register_regions is called first, it will register @@ -32,17 +33,27 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, struct stat st; void *ptr = NULL; Object *owner = OBJECT(dev); + g_autofree const char *fname = g_strdup("igd.rom"); + g_autofree const char *path = qemu_find_file(QEMU_FILE_TYPE_BIOS, fname); + bool sysfs = false; /* If loading ROM from file, pci handles it */ if (dev->romfile || !dev->rom_bar) { return NULL; } - snprintf(rom_file, sizeof(rom_file), - "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/rom", - domain, bus, slot, function); + if (path) { + snprintf(rom_file, sizeof(rom_file), "%s", path); + XEN_PT_LOG(dev, "Using Intel IGD romfile %s " + "(administratior provided)\n", path); + } else { + snprintf(rom_file, sizeof(rom_file), + "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/rom", + domain, bus, slot, function); + sysfs = true; + XEN_PT_LOG(dev, "Using Intel IGD romfile from host sysfs\n"); + } - /* Write "1" to the ROM file to enable it */ fp = fopen(rom_file, "r+"); if (fp == NULL) { if (errno != ENOENT) { @@ -55,10 +66,14 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, goto close_rom; } - val = 1; - if (fwrite(&val, 1, 1, fp) != 1) { - goto close_rom; + /* Write "1" to the ROM file to enable it if using ROM from sysfs */ + if (sysfs) { + val = 1; + if (fwrite(&val, 1, 1, fp) != 1) { + goto close_rom; + } } + fseek(fp, 0, SEEK_SET); if (dev->romsize != UINT_MAX) { @@ -83,11 +98,13 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, *size = st.st_size; close_rom: - /* Write "0" to disable ROM */ - fseek(fp, 0, SEEK_SET); - val = 0; - if (!fwrite(&val, 1, 1, fp)) { - XEN_PT_WARN(dev, "%s\n", "Failed to disable pci-sysfs rom file"); + /* Write "0" to disable ROM if using ROM from sysfs */ + if (sysfs) { + fseek(fp, 0, SEEK_SET); + val = 0; + if (!fwrite(&val, 1, 1, fp)) { + XEN_PT_WARN(dev, "%s\n", "Failed to disable pci-sysfs rom file"); + } } fclose(fp); -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 00:18:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 00:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379725.1624183 (Exim 4.92) (envelope-from ) id 1wpxQO-0002Mw-F4; Sat, 01 Aug 2026 00:18:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379725.1624183; Sat, 01 Aug 2026 00:18:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQO-0002Mm-9x; Sat, 01 Aug 2026 00:18:00 +0000 Received: by outflank-mailman (input) for mailman id 1379725; Sat, 01 Aug 2026 00:17:58 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpxQM-0002CL-6m for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 00:17:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpxQL-00FX1B-K0 for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:57 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d3a86-2eae-0a2a0a5409dd-0a2a450cce78-44 for ; Sat, 01 Aug 2026 02:17:54 +0200 Received: from [98.137.64.206] (helo=sonic303-25.consmr.mail.gq1.yahoo.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d3b30-f479-0a2a450c0019-628940ceb171-3 for ; Sat, 01 Aug 2026 02:17:53 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 00:17:52 +0000 Received: by hermes--production-bf1-54b5569bdc-h5zdx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 655a093bcead2c5289eeab02aa189b76; Sat, 01 Aug 2026 00:17:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785543472; bh=dt4PNu6AZ8WmochcJSUTO58mxubi+byKBAAny8f1ZfI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=N9WwHxoB+cf3cO+Co06Yt+h8kaZi09MEcr8dsgrkRZjvSYks/E2U/RUsfSCMDCJ5EbQq8bFpRiSj4z8sM2XsEk7e/+RNQINe24YUDWi2aVVHHbCBz95r387g4xUXOW9Vlod5CgXmMmAAmzIgA96GbeEozdnNmXgfFrzINvsyQg5Y1bHhWxPhOTLXynFGFOZPcAFBSK6GhQrCzg1T/2kNDLCeAVfhr1Qpg3zGO7PPnXf6SYD+v972nBg/D/eeIDZTC7rK3hBX66P/ByxvhAMAkOCfjUbLCmZtG4fmLURSn5bCAtjIaOoVGQ4sHiNuF23oXREJBoLidNXBluGgN/ktgg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785543472; bh=uijYDbf63QNZRyqSO+BcjNAdvkUvYboCyFEczonTTzC=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=r/iLX5neOxLm1Hizrb85XBD85w5EzXJZZ8eub5uQw6xuLCA59zaDclf6AFPv8uY8IoMeT0kvgb+jB6m0hxfYoGaNbrOoiAwhLZJ0WyWrGxsRlldsu2vqjT2iF7r5DMCgvVhmPwJrM7Aobh9xl5M7otYR4T19PQEiE5EmN5hsoD4ozilwGGCKcpqthlTeCRaaJmEJZwFM0NuL6Qq2WneLEkNl/luUHL/f807PPj5xpwPTItm4lS27aVlCnItQx9I9BmRZlXYZ4nh6a1DucfEZrpGdIwmkAp1nJuAyntHllEmCKok7+xSAD+XRNyv9M83FRQ9HZJw4gnnjj6aFZT0eQA== X-YMail-OSG: OB._0IMVM1mru75Egk5pnS7mtmdxlDFp2MywWseBRLa7DWCM3r2ltqo3uqt6Lyd Rt6xkeJS27P0r8Cq9siuuneSs9DQEtjumqKQ7oSfJP8gBtQ5hHZpkRl_KbOsVhoDKSlom8eoCXk9 JjHDjqTOSzaRqfLbPNESGpRwHWksXrNIHZlhkDUUmMFutW.2LZ8OCiNPEFln2gALzKvPxvqylyDN A64ZIaHkUfyEkQNxs1DM8flmn0ffPHLyPfkcl7eaOtOcUHbt0JlSuUklWSz5SZfUaDQQWOWNiUuf ydP9LfQ3xYGgYr7KwBqvU9X9IWpDYW9.WrGii5uPQ9HgcuS32UX0Az_t76hE_G2MCFiteoTBYqJ3 gO2JhwkRLQtVvUeoBmd0dyjzON7NCN5VoqINBBwULMJh1.LRezBmCysQMlq_urADxbeYkRenKlSM VAim1BV3a7EDH_T2zCTvXrB2vvY2dSDCH61a7.QQNWUrXwlDWHzSQqVm5cOO5o4LdZ3ZzSnQWJk1 zEyUHzw4h_M_7qtNpRNQUdhFxVZE5s8P4JsMiGwggyfL8Mp5Xn5G2ZK5JqJirNWSsXIwQrDomOqz MKRQT3JOHBlihZvTUurD0k0W1NzLdhlvWnIiKWtcPY.exoLeDU_H3jC_2TI.W1HWxWDYjU2EUk4Q qde8I9juKv7Bz3YJZTJSu0UBQK2gdk0IQ593t5_EKQCGicz7aQVoIlbUtj3fptqrYxQJwaJXndVl roGCqXppEdlq4ZOishAOVtEMklUj32gRPDhgVb5edvwlOtIZ.NJEb8u1vKJzgzZFDLjn2g.QPHtF 7QMslpSYIrysjLpMVv9eQ3Fa2S.IP0.OPH3zSiUTZu6bPFdxLqmPmoMYc2rS_CY7IV4XkEwC7lZK xVPYDwytZphPJw5ZAi05DXHVtaqQZxNkDb3_5CYfloqCCpbPob2t0GATkhSY3U9LWMltNlcZ6U0Q 4fBOVSINurtn11QitxYCFr4WHAVqhs2sSaOgTkKQXaMifuHyx7kbzMQauQvgNiSplzYD4ZGdFBBO .1VY8EBlvsSEDhGwBDDM5fkRFip6dmzegTzdVbmxNx3QdyoD0JDt0PpYXQ01F2Igehn9FDwp9QLB Bml8OdklLIxPkOOnWCetld7UM2.9WD_mdXZD8g8TBKhlRCrSg0Nql67T5AaWKEkjYhEZDZbxqBPO GgWKypu7Klzo3l_y6Q_HXpi7BI8vmJaA65nm8CCwB5axK7iD_7dyqGjheHasTKLSHkdIBeF4UCaH UkDLwuoAMbWNLb7fMUwFxv0DTdZX0CIw9K0ouP9WnXioFium_U1pjC3vqIhkkgNsQAqceziWFAiz etyzoFqTmd2nz81SrTVGIgGIc5_OTPKbW84Umg_mDLfddrDXjiCwkAZ8iw180wWjJ.apfEiLPdaT y.Xfgbp2blqyDCBpAEFcEVMRHnm1xR6Aiucqi4DpYtmnyhaEM_nycUDv4hT3fFpCjQICTx8.rrHA lbXBnhe8VIddi9bvxPoi7NRr7k6kYPn2sKOnSyv9f_A.ZCrMnqr2C9afaRzW47BMDk8BSXG2RgZU _LoUHFazGGVf3gT3j1Js5JGisHskglTYXC_FohCPrLg51G_KgIXOrptXU.W0fmkmw1NtfIGpSk5r N05d1xpYhlQMLuwN3_q0XhbFbnFpT1F0iGfdhdEQAwPl5yvCCTVI0HLl4baoxwRxs0TEo1eSJwqf DUpikmUktwPHd6DjjSW1dpfVkae_uWupiZvJbeJ22YCl0aeQFoW.l_70f3jwYBzdczzh73nOkzFl WvzGwkNbXpxvX6JrNrWb9AbpgqYvj.5kZI9poCc.c6FuO5n_vmdm1XhmtG2jczhbrYB.bHvr1z7w lRBEA.CUOHl9dH3TY8v36HscptEguga4ggzGTPM6I_obHCxUERH7KvqHLND8j0aquqZxcgh0r2It XI_95HG_RMDAxh95F6zw5nPkRLLR4FBY7qMHSSdPiG4DTLrIk0aJFaPkllXhhxKDn7INc60jIhbU JUsuuIZU1W2ZBLixsXeV583GXc7tJgfMwtLl4.nn6JLm5xi8NNei4bKIUHeY4XBlq8_dsahsEjyJ 8BB9M9uVlNvlK31Nl9wNoNOArKQT_oNbPdxx7xTXuaM_WX5KU9WAoJjjEt5TdpO4GhrPE8lEbDb2 O7qxsO9vYc.gBTyHmwg__.QdRz.fHIsn9AC.kop66w.LeJbK4vrF2AKivfAprBdQFk8UM3o8F20T r87KSJZ6c5tp3msZ2VRwI_fIpIYm1ujTHSmn4WTVtrSV512mc5A-- X-Sonic-MF: X-Sonic-ID: 4ab60735-23cf-4f17-a1e3-b99ab0ce6955 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v4 4/6] xen/igd: enable guest creation when ROM read fails Date: Fri, 31 Jul 2026 20:17:28 -0400 Message-ID: <20260801001737.16509-5-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260801001737.16509-1-brchuckz@aol.com> References: <20260801001737.16509-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 4799 X-purgate-ID: tlsNG-d25034/1785543474-776D6A5B-17B7CE2F/0/0 X-purgate-type: clean X-purgate-size: 4906 For newer IGD devices, the host option ROM is not readable from sysfs and this results in a call to error_fail() that causes Qemu to exit(1) so guest creation fails with the current implementation for many newer IGD devices. But this read failure need not be a fatal error causing guest creation to fail because the guest does not need the option ROM to successfully boot and run. The guest only needs the option ROM for getting graphics output from the guest during early boot before the guest OS loads the Intel IGD graphics drivers. To fix this, allow guest creation to continue by avoiding setting errp if the attempt to read the host ROM file from sysfs fails. In this case, the memory for the guest option ROM has been allocated so free that memory by calling object_unparent(OBJECT(&s->dev.rom)) before continuing. Replace the error_report() and error_printf() messages for this case when the option ROM cannot be read via sysfs with a suitable info_report() message. In the case when the host option ROM cannot be read via the sysfs interface, xen_pt_register_regions() will attempt to setup the option ROM for the guest the same way it would for any other Xen passthrough PCI device that has an option ROM. Signed-off-by: Chuck Zmudzinski --- Changes in v4: - v4 is the first version of the series that has this patch This patch provides initial support for many newer Intel IGD devices so, at least, guest creation will not fail if such newer Intel IGD devices are passed through to a Xen HVM guest. But this patch alone is not sufficient for proper operation of the Intel IGD for many, if not all, of the newer Intel IGD devices when passed through to a Xen HVM guest. There are two main problems with more recent, modern devices: 1. The newer divices might require patches to the Intel OpRegion and also an extended video bios table (VBT). Without support for these aspects of the newer devices, the experience will not be great and in many cases the Intel IGD still will not function properly in the guest. 2. The newer devices only work with UEFI AFAICT, and the Ovmf* platforms provided by the upsream edk2 project do not provide support for the Intel IGD. It appears the problem is that the ekd2 project deems the fact that the hardware manufacturer does not provide the necessary firmware, the EFI graphics output protocol (GOP) driver, in the ordinary way by making the EFI GOP driver accessible in virtual environments via the option ROM of the real PCI device, to be a reason to reject patches that add support for the Intel IGD. This, however, is not a fatal problem since it only affects the guest during early boot when OVMF or the bootloader is running and the guest OS graphics drivers have not yet been loaded. Lack of support for the Intel IGD in OVMF does not seem to affect the experience negatively once the guest OS graphics drivers have been loaded. So efforts to address this problem are only important in cases when it is necessary to get graphics output from OVMF and/or the guest bootloader. The next two patches in this patchset address these two problems. Of those two patches, the first one is more necessary, and the second of those two patches is only needed to provide graphics output from the guest during early boot. hw/xen/xen_pt_graphics.c | 7 +++++++ hw/xen/xen_pt_load_rom.c | 5 +---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index 0ae95cc..a124233 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -187,6 +187,13 @@ void xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev, return; } + /* Case when the host ROM file from sysfs could not be read */ + if (!bios_size) { + object_unparent(OBJECT(&s->dev.rom)); + bios = NULL; + return; + } + if (bios_size < sizeof(struct rom_header)) { error_setg(errp, "VGA: VBIOS image corrupt (too small)"); return; diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index 407b630..eaf0ae1 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -77,10 +77,7 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, memset(ptr, 0xff, dev->romsize); if (!fread(ptr, 1, st.st_size, fp)) { - error_report("pci-assign: Cannot read from host %s", rom_file); - error_printf("Device option ROM contents are probably invalid " - "(check dmesg).\nSkip option ROM probe with rombar=0, " - "or load from file with romfile=\n"); + info_report("pci-assign: Cannot read Option ROM %s from host", rom_file); goto close_rom; } -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 02:17:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 02:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379779.1624192 (Exim 4.92) (envelope-from ) id 1wpzHd-0003EN-NL; Sat, 01 Aug 2026 02:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379779.1624192; Sat, 01 Aug 2026 02:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpzHd-0003EF-IR; Sat, 01 Aug 2026 02:17:05 +0000 Received: by outflank-mailman (input) for mailman id 1379779; Sat, 01 Aug 2026 02:17:04 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpzHc-0003E8-Ds for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpzHb-00Aunc-NM for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 04:17:03 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d56d1-e002-0a2a0a5209dd-0a2a4501e050-26 for ; Sat, 01 Aug 2026 04:17:03 +0200 Received: from [52.101.201.44] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d571d-5984-0a2a45010019-3465c92c65c2-3 for ; Sat, 01 Aug 2026 04:17:02 +0200 Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by PH8PR12MB7373.namprd12.prod.outlook.com (2603:10b6:510:217::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.16; Sat, 1 Aug 2026 02:16:57 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0270.015; Sat, 1 Aug 2026 02:16:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=temperror header.s=selector2 header.d=Nvidia.com header.i="@Nvidia.com" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u44/GoQAKEfhaTFN0cACyRuDUN/qFmU5KeNVe6H4h01LG6EoPe6fnBbXHMpvBNCKR52tlotyqMT1TD+lPynBXR7ecEjwk9SwoKLVYcpaosIDc3Lle0tXrynJpIK5XMVquvSoVXzKBgMRiAioSWi1+iRpJWbhwvOlk1cL6tMUJWO1yxS3fYGbhJPSRk7accS5G0CpIoZmpF3syHO/VbBkMGuA4/8iNx0iOU0QdbDUtOkYbKMMuUGe0XZCPBphpGdWG/oPchow0KvvOymP03pXnUH488q+GcGkdbCmmqiCjYUBV4qFMl0kKjjo8/v2T0ILSe5qr1KuaNr3lS/v7Rf0CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+rDyjehUqENheZn7IayeoBu38MNxc8V2l1+M+P1R5Kk=; b=hwVTZ+ZIjCwu3z85up7B78kt4GgN1SRYJ4xJQBqvlw09N6Wglz5dChzfwRxpQqoTp7FM3aZJQtI2bzzxGXyz/3D+koJsURiylUVybKgN8FLaLR5SISJPjx6rQVPujnnul2Q8RVnfeUs4ztAKbicL/xDLFDDoBzC7g1jAwHYVWYygHtXxJPbImAb/86Fe+WqZUoKJC7f7MQcPVwj/MZrj127Wo5Gpt/52C2Zt08Qe6cDjNrsGfk8UwPmZNAaX3e5U3SfBEDsHCQdQPBDDaexxDAwR9YmegDaFSk83NBV7ts1q11N7iFtizZROOnUZo//tuHsyE6ItZ5lnvPBPs6OVYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+rDyjehUqENheZn7IayeoBu38MNxc8V2l1+M+P1R5Kk=; b=ePN9dqmfoYRJWyt+gF6Y5HNX/2lKdq/3QAwQGnIf1SuYpRtE+2818HFICgLZOh55zQgQTBPJqmUGxUi+H3HTnAeoRuNIhTs/jW+23ZCRLBO3VozrMONGv/22ouJTIjTgX/tMDZvLVgfYPgx5Pta7xjaNt/IELhyG1gZ22FBg8AzVWlMnnKBO89zlcqtCYmaflDHjUTMExcMiwJ+QEw5pLigscriXqhULeqgV36s1134mntTwKv3qXhIr1X6nRn0gWJFlPYGyxCTsBH2qwPmXvv/YK0ihraVvrqbccSlb2pvjP4+522DVyksA5wm3ebQrfYwNoEYfTxi9LUyGBzOU6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; From: Zi Yan Date: Fri, 31 Jul 2026 22:13:26 -0400 Subject: [PATCH RFC 03/14] xen/grant-table: stop setting PG_private on pages for grant mapping Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260731-remove-pg_private-v1-3-142c97ba3562@nvidia.com> References: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> In-Reply-To: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> To: David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org X-Mailer: b4 0.14.3 X-ClientProxiedBy: BL1PR13CA0203.namprd13.prod.outlook.com (2603:10b6:208:2be::28) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|PH8PR12MB7373:EE_ X-MS-Office365-Filtering-Correlation-Id: 223addd4-bae0-41ab-437c-08deef72f65e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|23010399003|366016|11063799006|56012099006|10067099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: ScYFd10qX5KaVaxBZiEZeesmoY/e1LTIdd+/y8YBpOBMf9QvAl1vdS9Q/+G1U4IRvoHJ6DrxRAKPmOTw6YTWWYVC9x1QfPVLI3U820TfHWdxwQDgEbeIUonNa5lXhCYqZ3ap0EJsOS2wuz3xf119PDTJdKJvFjktQXZUWAthEpZ3bUYXkzaAIqEdaM+8LoCMnXh1uF5QDXpHYHIHUEM+qiiWagwFth0NjBSAFuw8U0eLpn8AnSwIyZ/J8vJUuyL1tG4e7jWVgPDgYPHz/k0cxUpF2Xwj0fIWtQnAEATw4TnzCS90UCFnSH3fykkBQbqz3E6ehvfvsWMrkFjWJAqn9cXRST3IBXOFqBI0H34Z9D7jmLUXGyFPRFSaUj6qlgoBx66DmcHYqLXJo2FW4/WNcdkRRI7ugwvo7fWm0QPbEVV/zN79nPw/vJw5OADRYOoRsC/P8GJDodWiva3y/n+zAkv4Dyo8R7FQwZ4yuHJjSlhTiuY8OXtfXuZkSWFxTu/qCnpheTNxYDJXyBnOZkFenmpLxtoh2idPUog7PQyhHcb5Jf89LlOtcngAZxlceBI5aKXsx4tRLm33pDCCZPjqArSUZj7HnyDjM74734bJQs2m2tXIV2T5OfhBayjiAylA72D8l6+1lchkNDDNC3DddJgFDkXeeKHFEB46sxE6NfshlqoWesXTsBy9X2sFPwsrcQrD35UhG5kZOik+VQavYw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(23010399003)(366016)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnc3RzZqWExLeER3a0R2VGJvZXB1a21Kb3kzTXN0a1F2RUF6elFjRzhrRXBQ?= =?utf-8?B?M0pGUEFRRzRRVmZka1Z5YytZL01mSU9ka1QyZ0VsYjdPWWxVTVRzZ005dnl0?= =?utf-8?B?L015NlZuVm1PeXN0ajhVdW9SM0hieEViYjd3THcyL29mcVE3UmhFTWl1MzVU?= =?utf-8?B?ajMxQWM5dFZ4bXVlcFNCTEx6MEtIS0diSElkVWlhM3MvOFV3UE9zY3BWcWtr?= =?utf-8?B?czkxQ1VWVVptZUU5UnZ5UkVpYWw3SUtXSmtWYlhGaitzbVhtWTFxeTE4cmlh?= =?utf-8?B?cGVJd1pXM3h1T2tnSDYwN3VFbkt6MTlBMzlnSTdOeHV0RVNUTll3MGh1eGJu?= =?utf-8?B?d0NlV3VvSWhOS0xKTG5SWnE0cmNRTk1IUGYwZnhyb1M5MHBYcjRGMytHU0hG?= =?utf-8?B?UkkzK1R5NWZWRU0rRDgxeks4MzFncmMxRUJkTE1xQTJCTkczMUlyNTNWb3NB?= =?utf-8?B?WGpvTkk5OG5KQWtRaXI2cUI1cXk2NXBWS1hZN1NUakd0Rnp3YTU4K1d1SE5O?= =?utf-8?B?dldRZmJtRHllRldnalFyY3JWV1lwdnVnZGJnN01rNEJWWllxV2Z5Rnp5L1ZG?= =?utf-8?B?ajBLcS9aanYzTHA3V1VPWXVoYjBUYkpYbEVWMzVhTlNzV1B1SEZkdmx3V2Ni?= =?utf-8?B?ZzNiNjFYYWloektvK2hqWE8yMjMxTW96RURjWmdnUXBUVUo4REgwS3dCQ1dX?= =?utf-8?B?WWVFVG9IK0tqWWFkNUlMMFUwenJmZ3hFNitNUU5JdngvbUN2eGxXY2RQTUd4?= =?utf-8?B?dlo0VUlNWnBYRVlTdFgwcDJaZHJtaWQ1d1ZteU9zbVhtaWJlMnY1cU9haUhy?= =?utf-8?B?RHNDSmpJK3gvbW4xQXJyamZPeUxzMWRmSXVHTG9nUU5STkNqelhZYS9GOUdS?= =?utf-8?B?SWJ1cmdvKzkvT0pDaE1BYkNxL3ByMmc5RDg5c3owQlc3NmZBUS9HRHFvbEkv?= =?utf-8?B?dGpZQ3lKSjFyc0p0a2E0b2JxWXdyUXFNTkNXQW5XN2k2WDgvdXFXN2p1YU5E?= =?utf-8?B?TnNRbC9hWjdmUWlkeGJhYWY5bXRXSzZZR2hXTSthdlJrUHdaQVRpTlQyOFli?= =?utf-8?B?YXAvS3NIQlRhN3ZxK3ZqVVY4WkRxcEYzTnlORXRQOVdaRG15QVNqbFFZWUtw?= =?utf-8?B?eFExaHREbVl1Z3BKaVZacHVUS3dBb0RKSFhtVUFTNWRBSjQ2UXBHbEV6WVo3?= =?utf-8?B?YjA3YVg5VnZvakJsMjdsQWZ1azlaVGl1K05YWVRoVWp3ckJuaCtIR0hFVjQv?= =?utf-8?B?RWhjNkgySExPeVVpYlJNcXQxdlZiOVU2cHZONmZHdDF6VmVsM1pXNGVuNFF2?= =?utf-8?B?MlNHQVNCYUkvOEExc2R2VWxyTmJJOHNMdlJkb2M2VEFhdWdWbkxyUTR6UXVW?= =?utf-8?B?RFhiTmtNOHJ0NjZyWUFMbW1DVWdkc0FScmZjWmdFbzlGeXBzNzFtM2ZlQ2VV?= =?utf-8?B?RDBqek8wVkdZZ3NUWWVmbDZqNDNiRU1TeHM4WTRRWTIxbGlaN1UzM1RlRTZL?= =?utf-8?B?bWFNQ0pBdFZlb0NBSWFpMEtoa2pjNEZxeXBUWU81eGlPT0ZkaWhJTmwyK1V0?= =?utf-8?B?di9BRzJrY3RqbkZZc0pWdGZFRytReGRPeU0wdjJ2RThIQlZVMnlKZTFtelhr?= =?utf-8?B?eVQxaU41UnVZREY1ZENqVG9qdTVWcjJVTE16NUN0RFBUZ2JGQ25yZXFhQnFP?= =?utf-8?B?d2NLU1pweWp6OWFRaEF5UW9FdFdlbHBTeHJWdUZha2tZWjJyVDNVNGVXSVEv?= =?utf-8?B?WjNWd2VDNlE5bkcyb3VSRFpEQVdGQlBkUjJDSXNWY0o5NEFCNVVCVnBjZVV4?= =?utf-8?B?OVhra3p1ODlvbTlBeWsrd1VVNklaaWdackQrL2RZcXpxNm1OeWVXSGUxVFND?= =?utf-8?B?Znh5ZjhsVmsrTFh1eWt2b2JtVmpiTjd5WjhMQTkxSVZ1ZWxwWE8yOWpKdE92?= =?utf-8?B?N0xIYllFVWMzUVFqTHlZU0d6YXZFSkdRZ1JieC9Gb0pCelRpaUsxTFljQzhi?= =?utf-8?B?bjZaNXpxQTgrOEthMjZjVmdUbWlKcXlPa1FGUU83Qi9nbXIxakpUclB6RHEx?= =?utf-8?B?b1RDUVlHN2xqL05qaG9DY3Y1K3R2SFd0Vkd0MUs4M2Vtbi95eWYwRnZiWTZJ?= =?utf-8?B?OXVmVUs0M21Cc3NVVnc4ZExaN3RISWg3MEpFNDhnVjNjaHNaYUVqbjRWNDkx?= =?utf-8?B?Q2JvYTg1aE9zaGxrYmo5bzd4RHlubUtiem9JTGZFdHlhWStsMTl2QWlod2wy?= =?utf-8?B?K1gvaElhOE43UjgramV3L0lPaDlrWjJEeXRnWkhJWml6WGhlRjBhQmpxYmk2?= =?utf-8?Q?ITaq4Fubij1f0izSo5?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 223addd4-bae0-41ab-437c-08deef72f65e X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2026 02:16:57.2721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l0Am5J63xefsnsrMlCk7fC0Wd3OeYNH67IOGu5z5PLPygKkzgKEkQimaGrjMNeEp X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7373 X-purgate-ID: tlsNG-d62444/1785550623-BF46D757-6BC18A1D/0/0 X-purgate-type: clean X-purgate-size: 2244 gnttab_alloc_pages() stores xen_page_foreign in allocated page->private. On 32-bit, a pointer to xen_page_foreign is stored; on 64-bit, xen_page_foreign is stored inline. Checking page->private != NULL is enough to tell whether a xen_page_foreign needs to be freed on 32-bit and page->private is zeroed unconditionally on 64-bit. It prepares for a future commit that remove PG_private. No funtional change intended. Assisted-by: Claude:claude-opus-4-8 Assisted-by: Codex:gpt-5 Signed-off-by: Zi Yan To: Juergen Gross To: Stefano Stabellini Cc: Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org Cc: linux-kernel@vger.kernel.org --- drivers/xen/balloon.c | 5 +++++ drivers/xen/grant-table.c | 7 +++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index e7f1d4ca6d753..7f47b0ad05607 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -182,6 +182,11 @@ static struct page *balloon_retrieve(bool require_lowmem) __ClearPageOffline(page); dec_node_page_state(page, NR_BALLOON_PAGES); + /* + * clear page->private before giving it out, since it might be used to + * store xen_page_foreign info. + */ + set_page_private(page, 0); return page; } diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 35f879dc5dfb8..cc348ba2e0786 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -875,7 +875,7 @@ int gnttab_pages_set_private(int nr_pages, struct page **pages) set_page_private(pages[i], (unsigned long)foreign); #endif - SetPagePrivate(pages[i]); + /* Data is stored in page->private on 64-bit */ } return 0; @@ -1031,12 +1031,11 @@ void gnttab_pages_clear_private(int nr_pages, struct page **pages) int i; for (i = 0; i < nr_pages; i++) { - if (PagePrivate(pages[i])) { #if BITS_PER_LONG < 64 + if (page_private(pages[i])) kfree((void *)page_private(pages[i])); #endif - ClearPagePrivate(pages[i]); - } + set_page_private(pages[i], 0); } } EXPORT_SYMBOL_GPL(gnttab_pages_clear_private); -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 02:17:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 02:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379780.1624202 (Exim 4.92) (envelope-from ) id 1wpzHf-0003R5-Sh; Sat, 01 Aug 2026 02:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379780.1624202; Sat, 01 Aug 2026 02:17:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpzHf-0003Qy-P8; Sat, 01 Aug 2026 02:17:07 +0000 Received: by outflank-mailman (input) for mailman id 1379780; Sat, 01 Aug 2026 02:17:05 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpzHd-0003EE-L1 for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 02:17:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpzHd-00Aunc-1z for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 04:17:05 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d56d1-e002-0a2a0a5209dd-0a2a4501e050-28 for ; Sat, 01 Aug 2026 04:17:04 +0200 Received: from [52.101.201.44] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d571d-5984-0a2a45010019-3465c92c65c2-4 for ; Sat, 01 Aug 2026 04:17:04 +0200 Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by PH8PR12MB7373.namprd12.prod.outlook.com (2603:10b6:510:217::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.16; Sat, 1 Aug 2026 02:16:55 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0270.015; Sat, 1 Aug 2026 02:16:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=temperror header.s=selector2 header.d=Nvidia.com header.i="@Nvidia.com" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=juOG2d/steEklncNOvTy2HvMCzBRsBGtDaBigF+Zw99wCtxthKH9xaGYT9qWEVMP8Q76Iov7fdZDUGjwHlvM66fNmEIIPjId1D7gZZLIViWJAtaPlxuhcb7/aCtyiXWtwjSDdkuhSj4uxmaU6voqSMzVv+wLCaZdEpm1UniIM6XXr/y08d3cNmlDzA37/s+JyM+lKktnI+pPDcw4LcroYMhMWSlFXabL9JX7qqq2G9GkbyzxNZZdBfDXhiVcwodCDaUwfV4RLlUop1Vjl3p2ixOvETBfmnPpPYyDCHPwUZ6z8D4R4UBbp3gbajUber9EYwmfNycR/9reTyem8JAXug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Dj2NYUyQZvuonVfcvoKoW2H3adtSVWranxYgEi8YQU=; b=nS22Y21LUCkU9rE1tarBHVVoAOS6WoqXifPtaQIE8OYP/CiU7e1kuVgaMB8YfpBfwoWAzik518UdioQWoZmjgtRvCkiZoV18o6PNnRTVj6ggOgtj6OEdb9s9LF2yhoqyLMGg1EJ5eSVv4eBT1+JcD+3kJZrBt9FU0cKgRk9BBrqrjgM5c0KkO59dyK/lRP96h2SLx1wu57lFNzyM/iAKasNf3twQFbmJao0qMCbFWmBjeHqehUINFK536hvgVac4mYp2NrOIMZcRh5B4mo81JHleaUmUx1urY27cvvzQgM2iZgZQWkKx38i1rxQ8hux3PaeLK5OtUsv35myLt1YIAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Dj2NYUyQZvuonVfcvoKoW2H3adtSVWranxYgEi8YQU=; b=FB5Uzv+jjIOz2Gqd5kNRUmj0oMIAGc13ZaO7PxN87N2Vsm1h2AmI6UBCGxbiU8v7rBmpSk66cpyjk9doS0l2Cwug3L6tWxa7EnpwkUAI8obSHPvyEZtRmsQRP4Ad/qzEarvlDy1s6rnXeWJmaBg7+kXQP80MMmTUTKKx60Kkrzh78dZdHaCQVnN4Ent82GUKgm+hwh7r8TitUV618trGITHpcjPjn9zyBwtkgbG20BWoOZwi5n1SC1ZzVLkEqAMp7SKzKMlAu2o6c8XmMv0HO0zTS1DVdv1s4GB47p2UxxkBgmCmVu6y6Mvahl6HousWTQ32VDFXU9udlm0xGrD9Mg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; From: Zi Yan Subject: [PATCH RFC 00/14] Remove PG_private by using page/folio->private checks instead Date: Fri, 31 Jul 2026 22:13:23 -0400 Message-Id: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAENWbWoC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDcyML3aLU3PyyVN2C9PiCosyyxJJU3eS0VEsjs2TzNAvjZCWgvoKi1LT MCrCZ0UpBbs5KsbW1AC4r+oRoAAAA X-Change-ID: 20260728-remove-pg_private-cfe926c7f83c To: David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Minchan Kim , Sergey Senozhatsky , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "H. Peter Anvin" , linux-perf-users@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Eric Biggers , "Theodore Y. Ts'o" , Jaegeuk Kim , linux-fscrypt@vger.kernel.org, Oscar Salvador , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Gao Xiang , Jan Kara , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Axel Rasmussen , Yuanchu Xie , Wei Xu , linux-trace-kernel@vger.kernel.org, Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, Song Liu , Yu Kuai , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Li Nan , Xiao Ni , linux-raid@vger.kernel.org, ceph-devel@vger.kernel.org, Richard Weinberger , Zhihao Cheng , linux-mtd@lists.infradead.org, Baoquan He , Pasha Tatashin , Pratyush Yadav , Jonathan Corbet , Dave Young , Shuah Khan , kexec@lists.infradead.org, linux-doc@vger.kernel.org X-Mailer: b4 0.14.3 X-ClientProxiedBy: BL1PR13CA0208.namprd13.prod.outlook.com (2603:10b6:208:2be::33) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|PH8PR12MB7373:EE_ X-MS-Office365-Filtering-Correlation-Id: 8049e82e-f2ed-4234-27b6-08deef72f511 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|23010399003|366016|5023799004|11063799006|56012099006|10067099003|18002099003|3023799007|6133799003|921020; X-Microsoft-Antispam-Message-Info: pNDbTnWlggYMSHNy6jsULJFDGtRzmhD27769oJzJU2pngka0LaGEKVpniUoUJ3CQmbg9xv959+2z+JRtqFf67HdU+qB4JaCwRrXHvxitHS4+X0w1LJjCqx7wSOTmTpy3XxuOd9+f8rK/oQHRePQKndJw/6mlHZZMRqE9wjM6o1AKyiS+KOoN9AwCyphX8Vge1MTQ4lDkgWBEWecQpXPpnk0UVsgsZQXPhDQPsCCipKZBMP4VxfsQyzGYHKkCHv+pjywEZE4DEG6l+4rl5dqSNtc7Qp/DQhsoH47boah3/NyuS1fH0f4kWHFAY6G6Uc40wwSbnwNwgs+WyRKk+i8gXQhhXxEgFiKIttIR6DzHA+ZDDvqLRYbRPY4/hfrCcr7v8m7gnFeK1A/TZtrfpXTX8OQHDcrLTPwZSWiqO7CgFcVOlcx6g3XcpK6DY058ctzvMykbyqZaT3/MipYsv6FlMBL6ObuDgleNuUqlH1qFmIrE1zerLMArOoouhPo7b0s2r8t/oX7VceX7KaXz8dR06EcgNpjyds4vn+pl4J9+JGfO801D7wUbLE0kNRfs3NfM96JMpb8PT2+Pv0dezg5+fDtkUnY8TRZh/pSBDuNLl0m7gAChrxtLbAkf1kt7TaGiF4i0NjEzc+x2hdxLFU5P8kIq8nFhZ6pjA5bStDcTp7wi6cPDfsKsUTMx1/68zgx1mYhoWmcx/XO8OqmYGdg28g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(23010399003)(366016)(5023799004)(11063799006)(56012099006)(10067099003)(18002099003)(3023799007)(6133799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0xSZ2tsSUJ1YURzL2lvL2tRdmRuVEFFNFlkQnBtd1dkOG4vbTg2cHFsVnRG?= =?utf-8?B?VFNoYzN2cXdwK3picTlObkZKZGdHYTMxUjNlR0xycFB4WXUycHhxeEhYOHd3?= =?utf-8?B?K0J2Uk9rVk1WUkZOVEFtd2ZwNWdOZ2QxekZNTEphRWh5L2NxRlFZZFlVUXZB?= =?utf-8?B?K3NxZWdPQ0lyVThKaFZBelNPV1EzOVl5VEhQaFZydTRzblRDNDY1U01mQnhD?= =?utf-8?B?NDhiU1dKdE5SWXVoSjkvdDc0dnNUSzdoVjdSQnordHV1Tk0zSFZwaS9EUGto?= =?utf-8?B?aEtpY2ExQzM3T1VTbWEycmdiT1hzSTVFclVkMXg0eWJhWDI5WmhtL1duV0Z2?= =?utf-8?B?SlNBK1lYUCtaVkFtdFdRZ2RuQVZuTGdoVjl4V2xmVTBTRmhZQ2JYUDBORDJH?= =?utf-8?B?QnV2b2RvbnVFRUtOcnZHcTlRQlZMaWtzMXFyWnk5OXpvd1Vib0ZkSUdJZWdP?= =?utf-8?B?UDJ3Y2xwTmtNRVdYR1JJeTgvMXNOTERXcDFRaDBiQlpHOThGTnFQR1RCNnRr?= =?utf-8?B?SHE4M1BFZXBFTW9BbXExQWJYNEZsNTl6WkRtd1NMU08ycU5wRVFnWHlxb05L?= =?utf-8?B?a1pFT2h1VW9BdDlrYnBCNExFdWRTYnNmbVk4UEdaYnJyL0pueVZJczJ1MC85?= =?utf-8?B?RlJhcnRCbkl2SzZuV3ovN01xcjhkcWVNSVJqZHp1akNhUDA2b2Q1YWY5RkNa?= =?utf-8?B?TVpvUG9tSG5mcm0xMG9mTHFwZnVMYjBrdVRleG5UcmlXSVlnWGs5eWQ0Kzll?= =?utf-8?B?RDBSMlFuL3JucEFxeHRGYURTOERQdkxmYWMrWEFLak0xZVZ2RGVqUWZieFBu?= =?utf-8?B?NmhZMk9yci9URFpuaHUwQVpGa2p3VnJFK2pNRjduanF2Lys0Z0JDMTBkblBp?= =?utf-8?B?L3dQd2hhTC9PSkZhY09neFIxWEo1d2Q2UmJQQWdyMkF0aGQwWVprQ1hJTVcv?= =?utf-8?B?RTl0Z25ZM2J5SW8rMkMrblhROS9vZFZNTHIzY1BjKzFlTEZOTGd6ckozVmhY?= =?utf-8?B?YXBPdHVMRjgzNHgra3VibnRFbkdScXNjVkdFQ2pIdVJBRE81OWlsaS9IL01R?= =?utf-8?B?L25MZE92SFBFVFd6TFpEdG4wZ1JlRVdxS2x3WE5JbVViOXFsdU92eVN1TFdE?= =?utf-8?B?ak1UUjRUak5tVVh4MzFqdVpUT3BNbFNVRFBPUDc3d1ZXSlV6Nktoa0RhSjlW?= =?utf-8?B?UDlpRlViYzJaM09aY1lEYjVOOVNpWExmVFo1cFNSaXB3WGRKWlNaUGt1WkVv?= =?utf-8?B?bVp5QTFDM1BHZWZqZGQzbjFRMC8zM1I1Q1VtZWVhZWp5Ull6T2hJMmszTGFl?= =?utf-8?B?eXo5V0RMQWFUVHFMMG1ZQThHVW1nMDVIaEVKOEc5djY0TFIvNEpKVnJPM093?= =?utf-8?B?MHh4NmdhV0dERDZYTE5RdGF6OURVRThnUko4aDBsTmppSVRyb0pMYkV3b05u?= =?utf-8?B?UUVaNkxQNlp0NHRCWkFlVHhiR3hRZDF0RHMvcjFnelhHZU1peEpqYlNyLzlY?= =?utf-8?B?c1VsL1lNbHBEYk12cDkxZHJHM3Q2eS82UnZmT00vY0p2eWlwelRpeXc0cWxM?= =?utf-8?B?cVRpVExMSXdEQk1LUllBQ3RmOW02S0lOWDRqMFhoL2JTSkh0SnFhcGNzZWpC?= =?utf-8?B?eDYwR05Xbmg1WVhybkRrWW1sRTJZM1NENjlUNkM4RzdEWVZBSHN4NlcyRFdP?= =?utf-8?B?UUxDOEVZTXFsQVk1dCtmQ2Z0THZHTlRGdzlwV0FkTU5wdVdzZ3VncFNweEVH?= =?utf-8?B?WHBvSGUwcG5qVU10ZVBGYitrSkc2aUQvdzZaZXFKdzh5SjFHemVMTkhtSEhi?= =?utf-8?B?Slo0ZE9Cdjk4UkdVZ3I5dXhoNzlqdGE3c0xkOFM3clRCSDlnN2puNnFDWlhw?= =?utf-8?B?ZDZyTXNEQXBKdGc2LzhUSzNTVmYvOGZ0WEpxQXptbTA0ME5KWTQ5cHVybGov?= =?utf-8?B?SWNYYnJ3QVJlaW91d3VvMjFEcGl3R0RWemdqM1hYTHAxak5wL1VQeUo0TFdY?= =?utf-8?B?RDdmS3kxSUYwMlBwN01CTmlZMlpvQlg5Mkp0SWxzZTFMY3BrcEpqMHdGZ2Fy?= =?utf-8?B?Y0g3eWE3UlRuUmkrTnVnc29adHdwM3J2V3VrS21NUU92T3dBVHkwcThlbWJh?= =?utf-8?B?UkRmUDYwdy95cVByVklSRHpXenhpdHNORWJKdTNFaFV6WjNsbmZpaFRvM052?= =?utf-8?B?clUzczgvaXVmaWZjamxqNDVqQTRHR2M4MzFUQmN0Z2NkUjVROHJvakFZVlhD?= =?utf-8?B?TWRpYnhlNU5ZMjFXZDFzellUTlloTDMwZE1aTkxWYi8rM0xCbmpuM3JabDVp?= =?utf-8?Q?rIlyagVXs903sFdXgk?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8049e82e-f2ed-4234-27b6-08deef72f511 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2026 02:16:55.1454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dHRY+Bi+1YHiBNSqzAr7tvYfQ+7uKeAf5TdP84c5qEpoH6FkhhVKrN9emBFarEQs X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7373 X-purgate-ID: tlsNG-d62444/1785550624-BC558757-8DBA9948/0/0 X-purgate-type: clean X-purgate-size: 8724 Hi all, This patchset removes PG_private to make space for upcoming PG_folio (reserved as __PG_folio) for identifying pages from a folio (more details in Note below). Instead of checking PG_private, all code is changed to check page/folio->private != NULL instead. MM people are cc'd on all patches and subsystem people are cc'd on the cover letter and corresponding patches. Overview === Most code uses folio_attach/detach/change_private() functions, so folio refcount is increased and decreased when folio->private is set and reset, respectively. There is no need to change them. Changes are needed for exceptional users: 1. zsmalloc uses PG_private to indicate first component zpdesc page and page->private is used to store zspage in zpdesc. To remove PG_private, is_first_zpdesc() is changed to zpdesc->zspage->first_zpdesc == zpdesc instead of checking PG_private. 2. kernel/events/ring_buffer.c stores page order in page->private. Replacing PG_private with page->private != NULL works. 3. drivers/xen/grant-table.c stores xen_page_foreign in page->private, where on 32-bit, a pointer to xen_page_foreign is stored; on 64-bit, page->private is used as xen_page_foreign. PG_private check is replaced by page->private != NULL on 32-bit for xen_page_foreign deallocation. On 64-bit, page->private is cleared unconditionally since {domid=0, gref=0} (xen_page_foreign can be 0) is valid. 4. fs/crypto/crypto.c stores a folio pointer in page->private, PG_private checks are replaced by page->private != NULL. 5. fs/erofs has two different uses: 5a. folio->private is used to form a reversed list of the outputs of readahead_folio(). readahead_folio_reverse() is added to output folios in reversed order, so that ->private is no longer needed. 5b. folio->private is used as an in-flight I/O counter. Convert the code to use folio_attach/detach/get_private(). 6. fs/nfs/write.c: folio refcount maintenance is in a bigger scope than folio->private. So folio_attach/detach/get_private() is not used. Nothing to change. 7. fs/f2fs uses attach_page_private() to first reset folio->private then immediately sets PAGE_PRIVATE_NOT_POINTER bit on it. Change it to use attach_page_private() to set PAGE_PRIVATE_NOT_POINTER bit directly to avoid folio->private == NULL gap inside set_page_private_##name(). 8. hugetlb uses folio_change_private(folio, NULL) without folio refcount maintenance. Change it to folio->private = NULL. After the above changes, PG_private ops are converted to page/folio->private ops. folio_test_fs_private() is added to check filesystem-only private data by excluding swapcache and hugetlb folios, because swapcache folios overlap swp_entry_t swap with ->private and hugetlb sets its own flags in ->private. Note === 1. KPF_PRIVATE has a minor semantic change. Since PG_private will be removed, KPF_PRIVATE represents pagecache folios whose ->mapping is not NULL and with ->private set. Currently KPF_PRIVATE can be set for orphaned pagecache folios with ->mapping == NULL. 2. Documentation/mm/hugetlbfs_reserv.rst is outdated, so I did not remove PG_private related text. It should be rewritten. 3. PG_folio is planned to be set on every page from a folio in page_rmappable_folio(), so folios with any order (currently PG_large_rmappable is used to identify >0 order folios) can be identified, vm_insert_*() can correctly reject all folios, and rmap code can accept only folios. Eventually, page_folio() will return NULL for non-folio pages. Tests === 1. allmodconfig build passed. 2. zsmalloc is tested using ext4 on a 1GB lz4 zram: 2a. zram load + zsmalloc compaction; 2b. concurrent zspage migration via memory compaction; 2c. confirmed that multi-page zspages actually formed. Details: https://github.com/x-y-z/linux-dev/blob/b4/remove-pg_private/test_zsmalloc.md 3. erofs is tested on images created with -C4096 and lz4hc, lzma, deflate, and zstd algorithms: 3a. cold read of all files, verify checksums match source; 3b. readahead + reclaim/migration race. Details: https://github.com/x-y-z/linux-dev/blob/b4/remove-pg_private/test_erofs.md 4. fscrypt is tested on software-encrypted ext4 with writes to exercise bounce pages. Details: https://github.com/x-y-z/linux-dev/blob/b4/remove-pg_private/test_fscrypt.md 5. f2fs is tested on an image with inline_data,compress_algorithm=lz4: 5a. INLINE_INODE — lots of tiny files; 5b. REF_RESOURCE + general writeback — buffered write churn with fsync; 5c. ONGOING_MIGRATION — force GC / page migration; 5d. ATOMIC_WRITE — atomic-write ioctl path. Details: https://github.com/x-y-z/linux-dev/blob/b4/remove-pg_private/test_f2fs.md (I did not run xfstests) 6. MM selftests passed. LLM use === Claude was used to form a concrete plan on what code needs to be changed and how to change them. The plan was reviewed by Codex until no issue was spotted. Plan is at: https://github.com/x-y-z/linux-dev/blob/b4/remove-pg_private/plan.md I then followed the plan to make code changes. I did bounce ideas with Claude how to change fs/erofs, since I did not like the original idea. After each change, I asked Claude to review my code and git commit message. I also asked Claude to give me test plans (see above). At last, Codex was used to review all patches. Comments and suggestions are welcome. Thanks. Assisted-by: Claude:claude-opus-4-8 Assisted-by: Codex:gpt-5 Signed-off-by: Zi Yan --- Zi Yan (14): mm/zsmalloc: replace PG_private with pointer comparison perf/ring_buffer: stop using PG_private as AUX page high-order marker xen/grant-table: stop setting PG_private on pages for grant mapping fs/crypto: stop setting PG_private on bounce page mm/hugetlb: use direct assignment instead of folio_change_private() fs/f2fs: stop using PG_private fs/erofs: mm/pagemap: add readahead_folio_reverse() to avoid folio->private fs/erofs: use folio_attach/detach_private() instead of direct assignment mm/page-flags: check page/folio->private instead of PG_private mm/page-flags: introduce folio_test_fs_private() treewide: remove folio_set/clear_private() treewide: replace PagePrivate() with page_private() treewide: adjust comments on PagePrivate and PG_private mm/page-flags: remove PG_private Documentation/admin-guide/kdump/vmcoreinfo.rst | 2 +- Documentation/filesystems/vfs.rst | 6 ++-- arch/x86/events/intel/bts.c | 3 -- arch/x86/events/intel/pt.c | 6 ++-- drivers/md/md-bitmap.c | 6 ++-- drivers/xen/balloon.c | 5 ++++ drivers/xen/grant-table.c | 7 ++--- fs/ceph/addr.c | 8 ++---- fs/crypto/crypto.c | 2 -- fs/erofs/data.c | 5 ++-- fs/erofs/zdata.c | 11 ++------ fs/f2fs/f2fs.h | 8 +++--- fs/nfs/file.c | 4 +-- fs/nfs/write.c | 2 -- fs/proc/page.c | 5 +++- fs/ubifs/file.c | 6 ++-- include/linux/buffer_head.h | 6 ---- include/linux/mm.h | 16 +++++------ include/linux/mm_types.h | 4 +-- include/linux/page-flags.h | 38 ++++++++++++++++++-------- include/linux/pagemap.h | 35 ++++++++++++++++++++++-- include/trace/events/mmflags.h | 2 +- include/trace/events/pagemap.h | 2 +- kernel/events/ring_buffer.c | 7 ++--- kernel/vmcore_info.c | 1 - mm/huge_memory.c | 2 +- mm/hugetlb.c | 6 ++-- mm/migrate.c | 3 +- mm/page-writeback.c | 5 +++- mm/vmscan.c | 3 +- mm/zpdesc.h | 2 +- mm/zsmalloc.c | 15 ++-------- 32 files changed, 127 insertions(+), 106 deletions(-) --- base-commit: bcd5eb68a6a189497eb26c1b9f622538aa48895d change-id: 20260728-remove-pg_private-cfe926c7f83c Best regards, -- Yan, Zi From xen-devel-bounces@lists.xenproject.org Sat Aug 01 03:21:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 03:21:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379799.1624211 (Exim 4.92) (envelope-from ) id 1wq0I5-00054d-EL; Sat, 01 Aug 2026 03:21:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379799.1624211; Sat, 01 Aug 2026 03:21:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq0I5-00054W-Aq; Sat, 01 Aug 2026 03:21:37 +0000 Received: by outflank-mailman (input) for mailman id 1379799; Sat, 01 Aug 2026 03:21:36 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq0I3-00054Q-9y for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 03:21:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wq0I0-000uL9-3s for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 05:21:32 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6d65b6-5cb7-0a2a0a5109dd-0a2a4503b7d6-30 for ; Sat, 01 Aug 2026 05:21:32 +0200 Received: from [148.163.143.241] (helo=mx0b-00498f03.pphosted.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6d6637-fae8-0a2a45030019-94a38ff1754c-3 for ; Sat, 01 Aug 2026 05:21:28 +0200 Received: from pps.filterd (m0367128.ppops.net [127.0.0.1]) by mx0b-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VLw8RS2091199 for ; Sat, 1 Aug 2026 03:21:27 GMT Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012011.outbound.protection.outlook.com [52.101.48.11]) by mx0b-00498f03.pphosted.com (PPS) with ESMTPS id 4fs2jn9yfv-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Sat, 01 Aug 2026 03:21:26 +0000 (GMT) Received: from SJ0PR03CA0275.namprd03.prod.outlook.com (2603:10b6:a03:39e::10) by PH0PR16MB4782.namprd16.prod.outlook.com (2603:10b6:510:145::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.15; Sat, 1 Aug 2026 03:21:20 +0000 Received: from SJ5PEPF000001EC.namprd05.prod.outlook.com (2603:10b6:a03:39e:cafe::67) by SJ0PR03CA0275.outlook.office365.com (2603:10b6:a03:39e::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.16 via Frontend Transport; Sat, 1 Aug 2026 03:21:20 +0000 Received: from mx0b-00498f04.pphosted.com (148.163.138.245) by SJ5PEPF000001EC.mail.protection.outlook.com (10.167.242.200) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Sat, 1 Aug 2026 03:21:19 +0000 Received: from pps.filterd (m0426316.ppops.net [127.0.0.1]) by mx0b-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6713C6XZ3235982 for ; Fri, 31 Jul 2026 23:21:18 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-use.ser.proofpoint.com [44.208.76.22]) by mx0b-00498f04.pphosted.com (PPS) with ESMTPS id 4fs8pg80bv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 23:21:18 -0400 (EDT) Received: from localhost ([19.12.92.221]) by cmsmtp with ESMTPSA id q0HkwQP2q1Fglq0Hlw8Pe8; Sat, 01 Aug 2026 03:21:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=ppford; bh=nrHVQBAOvOe4C0Nray242Rigc P7NARuM6TjGSPzA8es=; b=uABiRfb9JIwVr1pAabS0UeLxee6O2exoGE48yprwl HnRl1QoKhtYFym6V/rQy5zLtbPR2RdGalujEfAc25j/SuQdsAJs5VZq1u/Qdgopk qWC1/xkdHtEp0fc/0u+4RNf7ZNbi4zqAQjQlY8Cwp6L0CXFDJf3Vot3Ao0LIbtJi +MvyilWS7GO3rRogHu9WeHbpYlx24/5LrDR7QxAe9IS8o4VT+eZkjr/XGu74rktq P5XfguTjQgmR0Fx4+7nGt7CL2Yn+90VtXIr55WlKgggRPs9awPVhbDOeWveTRezX smChVQZyG/uXiGIbtFkwcRNMVW03bVJMp3ojJQ6ca7FbQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sKNrmUDWnHWZWY1i0KjLBXn7dAZpWbL815JlQaaAWjU2Bphph7GgqNvyk/PhE5ranw3Mdae+ouvvSuURwDaBlY6XgBd+HWfE0wkA8j6KiIElxmHBqNS0IkdhSCvsZel1Lk+H36NgPo503vNn9g/zuN53R1uYp4+8+L4snbbc3s/oEaMQDs4JOPM4bkCs5Dfzap0AwWrzvz+CudbIaR/ZC83a0YXFl2y6bR09ADvXh/Db2I0wDNBCpPBLkzocwonSNUAISw21ZUtoMgdKUkL36xb4uTtLLKA6iojd0bpoLuZPIleKlxudtv1/SqgfX4Hkq+5h/BsmiIriYzxyzekDzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nrHVQBAOvOe4C0Nray242RigcP7NARuM6TjGSPzA8es=; b=oHPXv3Az1goPHoM8LrJizYDOOobRa6XT7AruZ106zkSbk0CRp9nH68piXBO+p0RTzwaDBCwxmc5maeLiUFu/fa7CgFHUJxKvxBhbieKj4+VvJcec+hW7hc9jPCYiJs4XBzM0K9d/Xx+FsQ3IMCAM720z+0ZGxuMrxaiqF7iQVeGkahB3soR9+5WQAfllLlef2HYvKglSejUZSeCatVqK81Z72zG3vbzvGENGPuxCmQXk7m8i/TgX38BMflbDjzo2UC1MWt0t5rrbWmZvtXYrJ0NZi86hb0IPZcPHci4qTr00I5IyRLA3MuJegdnzYU1vHeDMJeaMYx0WuvywcX7U/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nrHVQBAOvOe4C0Nray242RigcP7NARuM6TjGSPzA8es=; b=fKQb1gWqG2S9r+wsv8swqaBMOL/dHOA/Tcy2Fgm12+GOK0zqYW0YM4mR1Xkh52GI6f2F/sHX/FAj0/PdMNeV3ZZ0RerrJhAqHEJc4oQZbqdNGogm3hswf7iK+Vn2EApXzCTi0pmmFTzGfL0rE9mhDhNnVuq17jEYCxqH/rcbnTI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 148.163.138.245) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 148.163.138.245 as permitted sender) receiver=protection.outlook.com; client-ip=148.163.138.245; helo=mx0b-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to; s=ppserprodsaar; bh=nrHVQBA OvOe4C0Nray242RigcP7NARuM6TjGSPzA8es=; b=QXa/gMgulDaXr4eEI75f+ym cSxjQN2MhBM3RQ4y9ZBmzpKweOCX+4459FKvoCCrG1MQtbO98sEVJVKCdpXQg/tn m1B+uqEbGcTV3R0c9QwpZRh6GKp3pGLLhaOtkLUlWFzn8g2kwf2Q/q6TqHoVWM9h oxjno9aHfA/XHoKBqsEHcHYMAovNyEEJlY273zyfV+fnErJmP36DQcu7u0lWAjJN 9YTducqBnPZOF6unOk7vKxuiSkKVpMyjxzwIDXLQsFbOWSWj8uw9iowsTMRASA65 kKHhap1llF3Wj6Jufduw4XjdCXd/5lDveRTKH7vba9t3LD4oDEpHXe59hhtlO1g= = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=ppfserpocford; bh=nrHVQBAOvOe4C0Nray242RigcP7NARu M6TjGSPzA8es=; b=NQgAzBjKWopmvc8JxNdwdtbC+ZSaYrw2aju79mcVh4nuNg4 oHsKUy0zHP9KHant0JnxRjL+gdHIR7/Aiwg5JbskBNA/xuMn/o7pxwO6kZMBmmnn HxwL0iheVFMPoeQUlO9xl7J5mvJbBqbpEHPxdDjYm325WLyVM6VzEphOb6F6SIZy L325SdabhttyEpXcu+9zv9JzUvutui/ygHROEb0XvLGreGNH6KF4eqFQjmsa/yA2 BJ1g4eV90QCyfDYYq26ggM3JO25CqTejknrz1yusWM5nXZJAnnFylO2ckZJS2GVk 2gkaShuQs6Ur3bM87NjSeUI6eMWkE+sIvfDWIzA== X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: q0HkwQP2q1Fglq0Hlw8Pe8 X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v2] acpi: reboot: log reset parameters Date: Fri, 31 Jul 2026 20:17:39 -0700 Message-ID: <20260801031737.344756-3-dmukhin@ford.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_07,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608010018 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EC:EE_|PH0PR16MB4782:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 33f6b6e5-277b-471a-8af7-08deef7bf49e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|23010399003|36860700016|10067099003|11063799006|56012099006|18002099003|13003099007; X-Microsoft-Antispam-Message-Info: qvu/pqhS2hy2e4uK3sTgFYnuHcN0WuE/iUoFY7wnLjtHV7lds8kuK7Bvzz7C62LLNtqD9+egSBMnVAoHynoAIN5TXq4Muq3Lv3N7QNqDUH66xKiiOW6G1U1TEIQTP+65asGOoOo9QgRnBdPVplebEFt1Y1s+lRu+AyntcXW6KSiW211RlQHeNpazJz1q70e+NNn/z5/uA7bS8iBjVlamaTIsOGH+UX9733jD2tbqCQleRKhnWUJ9GoY/tqyCWETRldELVNVlzLgXEBPoHotjsM41wEj6+3KMgdxP72e1+WndwviNYrCiuGsOF4cp2EPKlgS1wvqzkGNg29PVQaF0g2izIDqMcAZ8KwFSuRO86M1Bu+ROeyLKN829o8D/n2Hoikp/BcqGHAvsj06JAtK7TfCeX/EpkbNMJMLjq/dmANrOa2v46eVgccgUj1UrpbNj6XVSQdZ84z3A746CiGV7JT3/hrNBbQe5D99f/rS/ouOjQlGS80KZclHmkFloPE3N88Ra4DsfMVf09BixmSM+NdV8ZrRlLybEtMxrmPAZRJHV8tSrAm3F8E53xdkPKq/QZv+WJ1PJ3i7rxfmAI4hp6E9GKgATX8flDgnhwWXRWuXlyt9qxsNJL93+k9mZsVAZvSEVUSF5MMOPpI6i7y+32lc/69Yr/owaP1+iKMNcprXksbgmtUIjKk+g7usEkYRQrnTyOuIBnLd529JAAuutMQ== X-Forefront-Antispam-Report: CIP:148.163.138.245;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0b-00498f04.pphosted.com;PTR:mx0b-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(23010399003)(36860700016)(10067099003)(11063799006)(56012099006)(18002099003)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /sQyepu2/mDB9xWS/B/6Fj/Cep1DZS5IKomMSnUJbc6SOvYC6de3fu8esqafp3z5xN4SRhuCdDn0SjjFhdkgLbo/VyDnTlw4gYJkpwS3F0JmPLrrP7IVcZYVGgxKqzch0SrT99kf2TUeRasyDDpyce9LVe9v4rYQCVoAkaWSg6X0KadwxZlHm52QAv5sGrTf7G/ns2B2s2m6zrR9Omr5aja8ivz4ajoJ+d1Gm+F/hrbznFCXzQ4RU3CpyY76KpiZHsbbVwYpY2s9HBKoDVUkfdE8+Y+vRTdzMBPHaRBoD94q7XVgW5bQ2HR4TUBC8x+dAUu2sxlPRlwTC/sEQUKeR3uz2QuPhJ6hlUIiS25Kg0uCaBsI54uyqq3syypgF7Wz/s/rl4Wk4IN8PctZE8YBsSTdPBEQ7Xd+s7zrmeCWe5rJa4ysL65kd4UauUU06tGP X-Exchange-RoutingPolicyChecked: DNiIyGVjEqRPhVA9RQaBYILh7s4oufPpsmc86GUjybemmsKUUEDnXhPH8u3U3WhFxrXJ7TShgoFNlALQho/Ek2XsqoRG/sAux9QiixsySp9pCc8j6ZaRgw3MS9IlerPxuSzrRz8+rANBZuULt1NvMtcdm0C9TfXGBIMNP1WsldjRi7U4KClfnzhsT7+04F8DPTHWdr1jin5noWY1bNd+bhzyHIwXiSnm+qq0t/pjwz1Mdoce5WyS0mj+V5pIx8f9tY0sNwzrK62jsM1kOZBKfoLzz+8msblv9sb5Sc7VkuRc4yQyB1+eU05UqzHkySRDP7nIpvDo5XgeK2PeJ0JQUA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LPE6jDTwxRcWrqX9PavanlZWmCQB1gHgnMQUENITdTipweBo0a+UzEF/ZPYTHwOsb6tyNGUrnKDACwsQFenGYL8869cQu1sjZnQt9hCoJEAe1v06Qky2gZ69ViWFsiCBwnSmPf85/uOWErlTWqYifmDBVSkaDDdh2TCrZgoipnbzVYMEv6vlUMULkHKeNgCrJxzXoiqTVOIWWzap4R8J/8RMD79mY33jWV+PAXfSR81FkU9QuEIMsdVOUUHjmpihDvg60n/LPjpXF9RGOeT7/hVAQT2V+pohhl4H6QCNUruH0y3+qF2JKik98X45CItLmKyU7VX+PUR1GkMLdfO1Fxw9azGLMbvUzWP5TlHyDgMP3TbsnOQ8MSsBnkqCE7MoILnQAfU+JcwDQJUDjp3Sz0UHBSOASTHeGl7kQSDuFdnHijEyHi6cANJiPOGSbXmgPViypqfzZLDxPqBioSolZe9upfmmeffQVri7638bpBIOgnXHIe83iA3j6eviGirsotTfWoubCcNw7hd/ZHW+LRUfPi/EafQd5DeIjRcB7mA9FBBAoo7DuzTSGSoSEaEZnWFGUGs5cQWUTGP3/GgvnVU0E24v1zA2n/benHj81Ygcu++sCt3MsdnBnjd/LMcI X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2026 03:21:19.4573 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33f6b6e5-277b-471a-8af7-08deef7bf49e X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[148.163.138.245];Helo=[mx0b-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR16MB4782 X-Authority-Analysis: v=2.4 cv=JKELdcKb c=1 sm=1 tr=0 ts=6a6d6636 cx=c_pps a=AgKHDJP192gAOy1PpHj/Qg==:117 a=b7IhknPlfT0FN1EembXvig==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=WER9OelvoqQQjwJToBYG:22 a=VwQbUJbxAAAA:8 a=cbNQJ9GKAAAA:8 a=p0WdMEafAAAA:8 a=g95BRj5zbggsEhE0B_YA:9 a=3whSkbs7g9Me0DR5EJEX:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODAxMDAxOCBTYWx0ZWRfXy3WZPTpyA8e4 j2uy1w2Wtuw1UsVDMePp4gSNiJfUjXdT3ZW73Txw2EdkXt+XGXxq1soymtEBFXcrZ/t9FasS2Wr 0Spw2YYqD1Z5pxTKUsPt57L+RMSLUPQHA7jzECtZKa4rdPIqFl/T X-Proofpoint-GUID: HBOzySsYY6Ko4OLg-HpNQ99jWO0CiZ6g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAxMDAxOCBTYWx0ZWRfX2xf5fNI4rdu3 8NNTu0b3BOofrFJorjh7c1Y+5jaBJm7EMgI0xaSXQWdv5QuVauQOOqoSnG6AX/HRKicc8Xs+J12 ZNktjbci6F05Q1XrFtwiMSmlsv2i/nVU4ixCnXSzHBPaDD0IFQNcvu8adKmobq6HfPk4MBHiiJm aUXB4I4R8OUE+poH8oaabnpqa7a5ASw73yWyei2uRTH71JtvsqvZG4s2K4nE9AEfsFheliQdxiU tLwmnX+yjHKi5+JC3bX7qJndtU8Ybcpc2srw77ILTrZuSlkNH4otgsMbGcLPAAXVWXoYWNhFioF uHE7hfxA7G/8DvF6pxTssW8iqVxOmMeM+Cmk20Gv56083iytIfvblC3Ed7DdyOzL82/RuGk+vPI 1WsRqYxailJNw0/9axn5MyntrMYAwtkrMw9dONFdfS8to80Ij5I1PzIhYOzrxlSmZSBB5xDDiO/ xzcZO31w2gXv/k9bsqA== X-Proofpoint-ORIG-GUID: HBOzySsYY6Ko4OLg-HpNQ99jWO0CiZ6g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_07,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608010018 X-purgate-ID: tlsNG-33051d/1785554488-6D4D74E9-B2CCC98C/0/0 X-purgate-type: clean X-purgate-size: 2418 From: Denis Mukhin Xen does not provide much details for system reset debugging in case system reset happens via ACPI subsystem. Log reset I/O address and reset value. While here, add the missing default case, add breaks between case statements and drop full stops in the loglines. Signed-off-by: Denis Mukhin --- - v1: https://lore.kernel.org/xen-devel/20260730001854.905354-2-dmukhin@ford.com/ - CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2723268852 Changes since v1: - removed wrong ASSERT_UNREACHABLE() - switched formatting to %#x - fixed indentation --- xen/drivers/acpi/reboot.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/xen/drivers/acpi/reboot.c b/xen/drivers/acpi/reboot.c index f6345be8749f..dc5671f9b42a 100644 --- a/xen/drivers/acpi/reboot.c +++ b/xen/drivers/acpi/reboot.c @@ -6,6 +6,7 @@ void acpi_reboot(void) { struct acpi_generic_address *rr; u8 reset_value; + pci_sbdf_t sbdf; rr = &acpi_gbl_FADT.reset_register; @@ -21,17 +22,30 @@ void acpi_reboot(void) * on a device on bus 0. */ switch (rr->space_id) { case ACPI_ADR_SPACE_PCI_CONFIG: - printk("Resetting with ACPI PCI RESET_REG.\n"); + sbdf = PCI_SBDF(0, 0, rr->address >> 32, rr->address >> 16); + printk("Resetting with ACPI PCI %pp RESET_REG at %#lx (%#x)\n", + &sbdf, rr->address & 0xff, reset_value); /* Write the value that resets us. */ - pci_conf_write8(PCI_SBDF(0, 0, rr->address >> 32, - rr->address >> 16), - (rr->address & 255), - reset_value); + pci_conf_write8(sbdf, rr->address & 0xff, reset_value); break; + case ACPI_ADR_SPACE_SYSTEM_MEMORY: - case ACPI_ADR_SPACE_SYSTEM_IO: - printk("Resetting with ACPI MEMORY or I/O RESET_REG.\n"); + printk("Resetting with ACPI MEMORY at %#lx (%#x)\n", + rr->address, reset_value); acpi_hw_low_level_write(8, reset_value, rr); break; + + case ACPI_ADR_SPACE_SYSTEM_IO: + printk("Resetting with I/O RESET_REG at %#lx (%#x)\n", + rr->address, reset_value); + acpi_hw_low_level_write(8, reset_value, rr); + break; + + default: + /* Fallback to alternative reboot methods */ + printk(XENLOG_WARNING + "Resetting with ACPI method failed: bad ADR %#x\n", + rr->space_id); + break; } } -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Sat Aug 01 08:08:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 08:08:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379842.1624218 (Exim 4.92) (envelope-from ) id 1wq4lK-0001nz-ND; Sat, 01 Aug 2026 08:08:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379842.1624218; Sat, 01 Aug 2026 08:08:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq4lK-0001ns-Kb; Sat, 01 Aug 2026 08:08:06 +0000 Received: by outflank-mailman (input) for mailman id 1379842; Sat, 01 Aug 2026 08:08:05 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq4lH-0001nm-MI for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 08:08:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wq4lG-008eqK-PU; Sat, 01 Aug 2026 10:08:02 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6da934-bab6-0a2a0a5309dd-0a2a450a816a-34 for ; Sat, 01 Aug 2026 10:08:02 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6da961-f2d2-0a2a450a0019-5a9b322283d6-3 for ; Sat, 01 Aug 2026 10:08:01 +0200 Received: from [2001:8b0:10b:5:784e:4057:b43d:bb6b] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wq4l0-00000003hNc-3Aw4; Sat, 01 Aug 2026 08:07:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=18bIdcOeGSTwG3qH9s4I6NnzfHA4VI/ZEO9zsxictiQ=; b=keOR5QrpcT3tMBAohjjaUZz9So 2846u95schqlk5LuRQutlcPQXxNmIrUE0JXY0TCc36e/2lGCX737H+8lis2ylsMEcjBN6wGLjSTCc 0El67Eyc8eR0xLVlj2nt/Arft+RO0sfAttqftRvlrdcGvsvlk5s7kznZo6DMJIRdhmIaXZMMtOglg DKyWmovB9dCR7acS4cD8Gd0TMLMgUEFFDfwswlxFakYgWXgZuVAREXhXjY/iQZ+lH94yu45PqBChE HQwrWXJJAC2mRlKWeXXr02DmHShTFiM1hMmpT5tR8H2j9dcsOehYbCuKXkjA1u/ZPQVKrijIpAFS3 eVFs87qg==; Message-ID: Subject: Re: [PATCH v7 31/36] KVM: x86: Add KVM_[GS]ET_CLOCK_GUEST for accurate KVM clock migration From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Sat, 01 Aug 2026 09:07:46 +0100 In-Reply-To: References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-32-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-hhE/NFLqzUIzrpVlTdn+" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1785571682-510C9CFC-EB7B0D2C/0/0 X-purgate-type: clean X-purgate-size: 9637 --=-hhE/NFLqzUIzrpVlTdn+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2026-07-31 at 16:24 -0700, Sean Christopherson wrote: >=20 > > + /* > > + * Allow for a discrepancy of 1 kHz either way between the TSC > > + * frequency used to generate the user's pvclock and the current > > + * host's measured frequency, since they may not precisely match. > > + */ > > + if (user_tsc_hz < curr_tsc_hz - 1000 || > > + =C2=A0=C2=A0=C2=A0 user_tsc_hz > curr_tsc_hz + 1000) { >=20 > I don't follow, why is KVM restricting what frequency userspace can set? Userspace actually sets the frequency with KVM_SET_TSC_KHZ. What KVM is insisting upon here is that the input to KVM_SET_CLOCK_GUEST is *consistent* with the guest's TSC frequency (within a little slop caused by different host TSCs). I think the comment above it is fairly badly worded though ("host's measured frequency"), so I'll fix that. --=-hhE/NFLqzUIzrpVlTdn+ Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDEwODA3NDZaMC8GCSqGSIb3DQEJBDEiBCCx6LFSi3mTZHte3UKbr1SYwMC+1Sbx fqXVt8jJ3ebHRDCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAYgstmq2fylz6eE4M82Uj4rzKYdzkSNcnWI+4Sk7ckLcTx+hEckGL lcM2Pd04AVNbB/iuyw87C+1kW/34wEBPZ6DdFE96NDTX0Vfd01vAhmASua0Os46qt7kNcAgQ696R HQZstzHuiZ8V8cnIR4tpaVtOXV9hsKhkbSC/1WZCTH+zgeMHwzYgq81HiD1sOmwWeq3LZsoggZF5 MciAGdU3DfY5QTXzXX3inwM8/6HSfjDeSTnEj8duWYQ+p2CwNuahtFGlECr5offONE1+RJV2EsXz vJTTqwNWuJXuf9enthTtTuLLIhi93LyLKJzUzarGQcyHgjWUfLCn0YGLAapZlF6gFjZdp+PSObD3 oa8jwHXK+kp1YIEyBmwPpDNRs7RQvkCe65lv+CVd2HzHNCjDrL1MWzqBog4dALOrdhZhLsZ1e48t lQJvp04HDSRCwrLsizwDEf+eGjQnc72V6zowxgZLhyXJoq4pISKTsWHqGww/KyD0VqkYuNxkQ98M sdd2FIN9NV7tqDAxLt8L9NiY06n0plgyk95JgtGOtevUoD/0itCiUUJ9qSGx6oQ6g55RTuws2HhH Ijwxk6xZgxdWCb6Pmr2EQnOe/E5djI2HIMPjRtag03cXP2pAW344YBQvSkQRWfiEGdFk7kU+3qRc H5lnUq64/yTq6jmeC4zkY2MAAAAAAAA= --=-hhE/NFLqzUIzrpVlTdn+-- From xen-devel-bounces@lists.xenproject.org Sat Aug 01 08:39:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 08:39:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379857.1624227 (Exim 4.92) (envelope-from ) id 1wq5FC-0006QO-Bt; Sat, 01 Aug 2026 08:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379857.1624227; Sat, 01 Aug 2026 08:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq5FC-0006QH-8X; Sat, 01 Aug 2026 08:38:58 +0000 Received: by outflank-mailman (input) for mailman id 1379857; Sat, 01 Aug 2026 08:38:57 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq5FB-0006Q8-1s for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 08:38:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wq5F9-001UbZ-TY; Sat, 01 Aug 2026 10:38:55 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6db04f-2eae-0a2a0a5409dd-0a2a4508de7e-34 for ; Sat, 01 Aug 2026 10:38:55 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6db09e-f659-0a2a45080019-5a9b3222ddfc-3 for ; Sat, 01 Aug 2026 10:38:54 +0200 Received: from [2001:8b0:10b:5:784e:4057:b43d:bb6b] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wq5Ey-00000003jTv-3gah; Sat, 01 Aug 2026 08:38:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=RmaoA/bE6iZHtJ0us23hNByggU40JWjLRZegqTIvQPI=; b=vQasd3OR46RhN5KQUpGQADF6bW +2c2nY5mmQ1ulxEFUgciJnHuT+vVqELlROSkKpdtnyAVQXispOa7zBqnCRAHCARNVKsSBI8q4cDD+ q06S0c/9hrZ1sFmFB52Ppd6cgwderqAXpGFQh+o5oE0hkb5JpUcQPMBZOr+uJvIamKup99id/gis3 2xav0+WJIn+qUmtpTrGUsGU1xCgc/k3m7pdakbOJapFPtJptJ4Y7ERj662DVDQmiFMDrX0mn+QcmO EbCNQuEfDPviupojz10DBBKE9qABvEjYNZT6YS0ZifMB+3jJFF1hptMLxOXK1XZw6Pvd3nlS7i+kf RRwqHUlA==; Message-ID: <8b90851f38ef5b10cdcdc70e7543bd6b0b5e2773.camel@infradead.org> Subject: Re: [PATCH v6 00/36] Cleaning up the KVM clock mess From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Sat, 01 Aug 2026 09:38:44 +0100 In-Reply-To: <178552799129.2700794.10181439022561913222.b4-ty@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-n8Rk3MbvUbHa+AO2Y0Ay" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-c1860d/1785573535-CEB4187B-CC5963C1/0/0 X-purgate-type: clean X-purgate-size: 9868 --=-n8Rk3MbvUbHa+AO2Y0Ay Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2026-07-31 at 13:09 -0700, Sean Christopherson wrote: > Applied patch 1 to kvm-x86 clocks. > > [01/36] KVM: x86/xen: Do not corrupt KVM clock in kvm_xen_shared_info_ini= t() > https://github.com/kvm-x86/linux/commit/3d4b20b5a7df Thanks. Could the clocks branch be based on something that includes the timekeeping work from the timers-ptp-2026-06-13 merge (in v7.2-rc1)? The later parts of the series depend on ktime_get_snapshot_id() and the reworked struct system_time_snapshot from there. Your kvm-x86/next branch does have it; I'll keep my WIP kvmclock8 branch based on that for now as I address the other comments. * 2d6d57f889f3 Merge tag 'timers-ptp-2026-06-13' of tip |\ | * bc484a509673 ptp: vmclock: Use hw_cycles from snapshot for precise TSC = pairing | ... | * ca1ec8bfac8c timekeeping: Add clocksource read_snapshot() method and hw= _cycles to snapshot | ... | * ef22786707e3 timekeeping: Use system_time_snapshot::systime/monoraw ins= tead of ::real/raw | * eba302268a01 timekeeping: Provide ktime_get_snapshot_id() --=-n8Rk3MbvUbHa+AO2Y0Ay Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDEwODM4NDRaMC8GCSqGSIb3DQEJBDEiBCAso9YgR/k05/yJ8iZRqVjWS7kJsmyC 4WAIPhpvsss2dTCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAdAvGOIdR3Jym1MBnTKyIkb7N1sSz5Vej8AU3UrA7wQyFFV+xxt+W U4+JFtZ/Fi5klcY9EzNDudfDBWhyon49IkXMD+S7082yR4+xOttX/b1DnZDcgkppOpUUjl3LbTeB TyDLay066nD7PRf+LbW4aQJq/8o6ZAP0toivg2yaJlOPSBtqXkgCbUSAWvXwM0N4f02Gfc7AS32K 6xGoc7OkcR3HVB/v11ESFFstkri9pIkxTlqKUeTu042PvM8aYc0I48LdzjbnxgpA/FoJ3OBqb9WK nPc8jYH6Vna1CKV012j2/vMsCBKaxflX7LoCSL9o80CfJ1TN/RRst8IUBScdH0PfLKs1L6Ueun3+ 1lE+TR4+lSJH1hMcq/MUB0cKpdhY45b2CV63E7jgvEzvY2UpJpTv9vQ+faTcsO7cWQ+yWPf8LZqJ Lpt6CFDkb96sBQTo1KuSWBsrqcixjynHePxls5aJRN62LJpi3gAR85/caH53Cr/jVj51/p0a86ga U11YtBGy1lkCecUfGiftwY0FQyXcyEqTbl829EhxNQhZOvGUKBAWf9Wt8AQOBrj1d8gNKTazslyN nAvZhMNEbG3c4G6IqJOy1JT/LjRRpwwQlYmaBgG5EFLhQgtiHuxdyB4ZEFT033Rj0JaWnRf2q/lZ DDryVrM9D3j/jkMsEszYe1MAAAAAAAA= --=-n8Rk3MbvUbHa+AO2Y0Ay-- From xen-devel-bounces@lists.xenproject.org Sat Aug 01 11:51:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 11:51:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379955.1624238 (Exim 4.92) (envelope-from ) id 1wq8FW-0008Jt-Od; Sat, 01 Aug 2026 11:51:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379955.1624238; Sat, 01 Aug 2026 11:51:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq8FW-0008Jl-Im; Sat, 01 Aug 2026 11:51:30 +0000 Received: by outflank-mailman (input) for mailman id 1379955; Sat, 01 Aug 2026 11:51:28 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq8FU-0008Je-DX for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 11:51:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wq8FT-00EecW-QQ for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 13:51:27 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6ddd84-bab6-0a2a0a5309dd-0a2a4503971c-28 for ; Sat, 01 Aug 2026 13:51:26 +0200 Received: from [98.137.64.82] (helo=sonic305-19.consmr.mail.gq1.yahoo.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6dddbd-fae8-0a2a45030019-628940528cad-3 for ; Sat, 01 Aug 2026 13:51:26 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 11:51:24 +0000 Received: by hermes--production-ne1-6f6bdbdd7c-jtc22 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2c6e9c6518a5b71581c74d9ac6047a6d; Sat, 01 Aug 2026 11:51:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=netscape.net header.i="@netscape.net" header.h="Date:Subject:To:Cc:References:From:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1785585084; bh=fuiv5o+ZM6uC/qcEX+Tzmuq7yIkIt71ND7aoktB7eoE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=RzrSTEwcS6DdKfMZCyRalp4+SYc+zLSn8i0BDw8EJ+IqKSwtQ1YC+E0i6jvhUQoITreHxMMhubTFv4mH2Ap8VX9CbBDfZ8NXyBRuoneFABkpJc1reVMd58iEZhNqnRaCczrNAsZtt8y/9qGKxgvfyix0Eoq+rF/553X9Xro36R6GtG0EQs4Pk0Sr+HpKaRBMHd5ejBk5I0Z6BXRzF3CR7IeWCOM1z59aMWsBuXmNtZ5vFFyTqivcQ+zUChOpac12c+UqItZv1Fq5D++lAGwk+9PolsLHWhBq6sgc2nTkiy6EmfoCV9EWxlJhBUnZVMwYaJIfcEQ/JDf0UX5IQ0V6TQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785585084; bh=N1KTBtU3ESCjUWEFdgsobkxQoc0Bd7zyUuVx50lfR4k=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=tCOVNGsXenhDGDx13ti0hjjT5Fs2Z6Mksu2Gftu24N4xBrQi5XSgDRMFcvp//TNG7iGPuWZd2P3RwTUOAZAqtjBa2X2NHEBr7YVLCeH2nkOYsTswBZ1353sjNFHKefJ2dBelpLB+tDIT1P8s/IbC+hXJRG2jYxsU//oyovSNKCsBQCELHot33BAUB7bXG42NwR/Wze15/sVLeWL1qSLUwPXrZ8To8kp6f5k1QBdmofIE5sAvTLTky4woa7a3vzxJiIxNygE70jwUCZPhkojEUH4DFPWsqirUqPhYlSjsYsDs1re1oKjFxpL50dihFJ4KarLybkbkm1cIIch5L1L7uA== X-YMail-OSG: aKsnXoYVM1msTfRexnj39EqPGrx117cWtsOWgBMvH8i.wtCxTTdrSq.xKjIGhhO 8lTaENnx.Xo71QG6aCfadwl10j5BWRCUFbZEmBK8nYFnJZPGqjzykIdoVlFJkhPgS7dO63IARVSe hnMAnDINxz9zG8vu7rUw2QIK9Xf7AcWXeuAMA7bSoKauxYxW9lii_CUX5t887g_wPE_dQo9SKXBF Yg3DWRVLAGXozWK4kXSr1OeSkNQGesu4y9tQ1YPKzy.lah4ydU7YYJ0Qzw7nRRHAT955kteiHpJB O2J3Wdd3ZzPsS1WgFA9rU7cq8UUSEdVv_0UCbxFlb_6Phzqa52c8Rd8w4zka8TQhirkXjxeqWGgC PfDVuu21XHzEoClVppiJdeYPi4oymsTjEbCuWpsuTkY8DDLuN5KBX9YZC28PsDniiiip1NoH5a4_ NBiVYKNq7yRvnNLGiEbKdzeZ4u.6A1oDK25PH0AxbntTQisb8B10lp3j02Df_E6xp4N8Qzwa72jY duJZv14j_26ufz6sYMbknq8HfAjdXna9sd7W.ezfzqx7Np574d76tdlESBD7xIBdCSMV8hR7b70k qaSYI2HWBozE9Lt0DvXBm0AK6eVeGn1u9BVcxBiKE4emHqSvdtO4AELZEpLksHCIb7WzGWyipR2J 1Nm4gRF6IFyyLBxLK94NbZA_Vfs.KJSkL_AMpj3eAK.lBnvDcU1zqVrmyBCG2Mjgkn2UggHHyhaR 4RXSjRYc.R8194Q9N3_Fnk5PFJh9wv_A41hE3FgWG0LcN8CJR_YsqquLMfz9xEm7IcKqmylpoK33 AHXzR5nSsR.0xsC.A9McnS79jd2X77yu0zX5rhec5oSjxR9eS46lZJ3Rtxpi8mvRnHskGfKCkER1 drpBotZBSKUy911Q81Yf4YHRF.KSIa68On7FVAJGyGlIzGRoRsUbJnjXeZqxnIE7vOaNHo8uf_QQ xIgtGyDAPe2hSf6OEUhUDVL0lpIxOsSQ70cI2PfYNezQ1KHk3.HGH6shG3rZWZ6mn0IYRtqPktFF LgFFwwwK7FmobjmNT19pvsUv8C0EJ_588HWu38pBwSesiDWM.Rja_m4CHfNVBDTE9xj06yW.GfjF 8WZf.HwaSVvE4C_MpYKm4DIURVWq44GwjYJzwgiLCQKlKhFfzXKVAnsQgKCr9gdg7NlHifqve6h_ MtOlBADM9Lawz0A9XYGhQ9vwvZjkIe.ae_s6nDqYMNi2AwOpLgrPTDgvukQmexdym3tx7Elpz9vF qtiQUpOarTaXtGaec3879KS.e.CoD3LkwWX28b1sEuwuxQOX1GCaiJYgV9hRIXrK9xZ56iV7MciI ORNQUdBt27x2zjlwwhyYCBRgLw7tTG61fGj8y9OQmfLskMi8nwtzDyH4M_eLLPgXC6TdvhC3ACbf ohN05lM.10W.u5mVmnUopLpl.8z33pOLEqqaQYIfQcIuS4TEuDCbY9z.qBvhfRBvH11EjtG77n6T D5Tt0iAMyw4MyvzgYri3ffFMG_sSzgBPAAlx85U7jcDooFaUiMFajhiBnlXPqhAYgpsEQnkudmJ6 VKV4a6T9m0Fzr.CEII_QtUOJC9vTNly3zXYz2sdkMeJtcgOQv64hurf4qbsv0SZBF.ohrzBziImy RcfHR2oY9fnTxuRzZMtjZonw9uaTfXkmnwFMZ1d2Ln.K7OHrFo3J0ZbrTQzpH1ODkudlLkO6yfLM 0W1nIl470Fyl1oLUajyErKVDdp5wg47TzCmtqgrNotvvrl.IDEP3BBFvI.4iyQdSbMH.1f7rjKtt ELkUF4MQ3Ey_4Jw7dtJFwtJ1iSdbk_3hENT7LcrJKztteNQREAr5PEJwPx2mQDHaOX28y8Q7X1mR 2nHLW8oeNxwKD8wNhM1BxLNJ1fysYkWDMVGjCd3u0K2kpYvuCEkyJCnmIofToOvHHhoK0TXXIIXc 0scGm5z2JvQCXTZpG75wKaFd71l4ykoyNdK7tbs8BqL2F0_lEv0gxnhgxoeyuHh.hjqv5ncyunKT JyDOuGV_Ze2_sPIcQJUSIj7EHOiKOxK5C1pE..VP9gE28WCkTapNCpmxgU5mf1yxmD53OAazKudJ R753iIExk0QwgcKhQL8YyX1q2vFoHOeiXpPAH6RemvB9XQ26Pzwmo8R23nkVhD7GW9ntvJ2wJabJ IT7vxFkCTAlqVQq.PWsw8MO6Zsr3M6g65YYrKD2yARUoymbqYhHYK9ohd0_RhF9GzXDSeIhhkcwE oYn6aytZTzy2z1Yivb0zaqBfRGbEBlbHYxM3hIA1D0wHq0EdXJgc.G4CjL_YVO_h5 X-Sonic-MF: X-Sonic-ID: cf8f62cc-639d-4ae9-8f4f-fa4e168ee8ab Message-ID: <1418735a-2ed4-4f89-a9e4-631f5423608d@netscape.net> Date: Sat, 1 Aug 2026 07:51:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] xen/igd: use custom option ROM if provided To: Chuck Zmudzinski , qemu-devel@nongnu.org, Tomita Moeko Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie References: <20260801001737.16509-1-brchuckz@aol.com> <20260801001737.16509-7-brchuckz@aol.com> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20260801001737.16509-7-brchuckz@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.26215 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 1447 X-purgate-ID: tlsNG-33051d/1785585086-770F64E9-F4A491CD/0/0 X-purgate-type: clean X-purgate-size: 1481 On 7/31/2026 8:17 PM, Chuck Zmudzinski wrote: > > As mentioned in the message accompanying Patch 4 of this patchset, > the official edk2 project does not provide support for the Intel > IGD, but some OVMF patches for Intel IGD support are available > online for KVM/VFIO guests, such as at the links below (they apply > to the OvmfPkgX64 platform): > > https://github.com/cmd2001/build-edk2-gvtd > https://eci.intel.com/docs/3.3/components/kvm-hypervisor.html#build-ovmf-fd-for-kvm > https://github.com/LongQT-sea/intel-igpu-passthru And also from Tomita: https://github.com/tomitamoeko/VfioIgdPkg Thanks, Tomita! > > With such patches it is reported that the passed through Intel > IGD device lights up the display during early boot from OVMF > and the guest bootloader in KVM/VFIO guests provided that the > administrator provides the correct ROM file via the 'romfile' > setting for the passed thorugh Intel iGD device and applies > appropriate patches to the OvmfPkgX64 platform. > > It should also be possible to add Intel IGD support for the OvmfXen > platform also but I have not seen any such patches online for OvmfXen > and if anyone knows of such patches online I would be interested to > be informed about them. I am also working on my own patches to > add Intel IGD support to the OvmfXen platform, in private for now. > If anyone is interested, I can make the work I have done so far > toward this goal avalable online. > From xen-devel-bounces@lists.xenproject.org Sat Aug 01 12:03:36 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 12:03:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1379972.1624246 (Exim 4.92) (envelope-from ) id 1wq8RA-0001tf-ST; Sat, 01 Aug 2026 12:03:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1379972.1624246; Sat, 01 Aug 2026 12:03:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq8RA-0001tY-PH; Sat, 01 Aug 2026 12:03:32 +0000 Received: by outflank-mailman (input) for mailman id 1379972; Sat, 01 Aug 2026 12:03:31 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wq8R9-0001tQ-BB for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 12:03:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wq8R8-005qb0-OK for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 14:03:30 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6de084-2eae-0a2a0a5409dd-0a2a4501e058-24 for ; Sat, 01 Aug 2026 14:03:30 +0200 Received: from [98.137.64.147] (helo=sonic301-21.consmr.mail.gq1.yahoo.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6de090-5984-0a2a45010019-628940938312-3 for ; Sat, 01 Aug 2026 14:03:29 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Sat, 1 Aug 2026 12:03:28 +0000 Received: by hermes--production-ne1-6f6bdbdd7c-w9xxm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ad3319020c74423f6b69925ddd631e52; Sat, 01 Aug 2026 12:03:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=netscape.net header.i="@netscape.net" header.h="Date:Subject:To:Cc:References:From:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1785585808; bh=W0MydP2oUX8/HYVYaoYYc6r8/esVa87AQ2CEiLLTU1E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=ffC9Ik3graT2CJhW++p7INhiiZEAHJIgo3bsG+g/reKKr7HZ/P4uyycCyMpDguWtYS38lLy9zPVLhB5RVYfHLQn86SacE1qCWbjmrdRH8H6NYE3iBqQ8Mhjc0U/LfNXdXuTs/ks5LYZLgOUfFWCNudc/Fh5Ad6OOLDgm/jv8KtOS26ttk2qzBI59+N4gCbbc48i3vJ/dKAcNmgMxKrjImk8jDZlxMjTKo3FU080qFYj/++60OOF1u19i6DIQRIsQ6zEk91nOnfXRB+8FToYJdsPktyZnxKiwwXBf3s5h4tHzHv7mPsy5WZN6SOUlX7goBlGWRpj6g88Rf8HF5lptVA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785585808; bh=VA3wADtmLWVH2/OEkFO9nIiNxhVsfZRpcgwrie4z1wo=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=TumVOIKNKpXhAVJmMPra0bLYp46neYIUct0hSGptSSiiP03izywkag8iVlv7cvg64oh9NqVpbsTq1SbDqSHaM/rnZy7u+/GFbqgAV46CpILoy8iwNNB1U/3znf0vQIYT1dGIlVGqgk2Lq5JndZfo1kd05515Sm/1iZMPXutm+g2RZH0yiYwjc3RLbJ2uXs0OJJ3VtGKqqDREuhijI0lc9BnavX5jCQLmeYhGgrxQP2fjo3schk4JrS9Jm55fkUZ7q4dU0feMwExuLWdd9HoYa6TQXb83wewLZw0LP/7fulU//MmRM8yrh/haRHjUH4zvwC8UsEmEU0xHmZTQJj657w== X-YMail-OSG: 7AOkLyYVM1nc0L2KIboVCyc2u3fUpk01ULdAuHHVXgEIrgHjs_utYiXQ7Qhf420 VT5ESB0Y6XHjA0QySs7e_CVe7JDA8XhV8k0EyCXUUDWHIEsvHsSzeajILGXneruw_uOJc_KgGol_ 7kyGnFb.8NtPYUWKyISUYzLSklmnE8pkyNgwODg0QdjVcDQD4LLGHVEGLpnRdGlxO0OWrJHG9bWA MfOID75l5SZ7QYmQvviM38Xx2jrjcPzqtG.LRZRsGdST.nTLnAkmf0J2tZkUfcL.qyHJXGHqeHT0 DS6RG1elXwk.VYT1TyxR94EIqfwhcXST5HVjEv2azWmcQ10Z.q.EZ1nyAIa8dJ0YPSfr9HHS4R0K bX9MEEPiUUFd.Bb6Ba8LmSGpnZ0g3zke7Sp0dtX0p7jn3KBUxrdo89331srrIz.JhSdSJLdw9_0h DRn1bD3C3XySL0Hr.8rGMcOnBXJ6LSBYXYJTynxmOlmO_3JOFJ2ZsrasmqFxKl_6xHjUDCvRskm9 zbwA_bLtxZUcw4F.4TSJrEsAuupNxqBu1IFIpl_SUDAAXvbk9FeAhAiHronBFsykkvr0RTlKsPSj h1OnB3xmCY_uhIyrznnyf9GX_gABBChwlX2wfr9s2ycJ8xNPAwLLVtONMNx5wD9E3S7jmTeEK6P5 5mTvNr4qMBpCnGnBCvmlADi9Aong2W4lTkCBEU7vUiMfQPzu4QanDZfNJ_fDdospmBGNol3aKc_3 Z9nacZUYws1q1R3GRsDfgBYLcKsjdNYxiFw42kfQFcDfz.GFCqpVNIOZtYrlVQqKCOZUkvNWJAdC and42_N3cqaddYlOuYWMYF0_7SC1aGA1UvH6k7MX1edgDOj1kK8Ue7SB1P90UEKXIXlfqzx8Gd5o SmC.Z2kWbzKrfojIOswLtDzRvJneint46VOsuhqLa_sODPQ3INjBzvHXfykwjhJ.I2Cp4A2MyQ7L Rvdm3HjHd4wLEeamS9TXJ8rVfLV8bMYYJ2t2RxHus_nELfQpvgu9s_2F8C5n6EftOwtU3SbmSIxm Mr1U6Ug6pAnR8N6hRFRBrK3Q9fYD8i5yJzTnq2ZPLwcs1kOPagQE31QWVfGz6ZmBw4kphSM2MG48 S4Ja40GRmTfKYvNZIQzIlnM03HHw3kB99nk07qTDtn4v0lN4mlUMnJAOc2sIO00c4jZ0zC_lVP.x HlUrEb6PI8H.jDPXfKRXCB1.hsDQBti4pfK1.3KoGZXjyryBr8r7EknKFzL_EWNcme2toBjP8W8Y 2qPYWnV_RofGLsIUtbWwIkWLZU5pvNjEIbkDXBhqp7jBR5_Rb2O90Cvqa5Zshq4loupZa8P_Vt7_ vee549jbJ0OTVf2.D8gnRPdBrouQ5vR6paWvYNJt5R7YeojbZXC3HmahVClWcgjcqoZH.Ew4lLAM YslY7bjVWhne0HqbAOhltpVgtc60dvBMhupgUgEoa7PkgUtUPSqtl6H5J9XPqGZyFm95cg0IGb36 FGxSBesQKzm4NCD6wWRujxR8taVaIg7YID6nrjlM3aQCElD4E8cvKns1eqWR1sKPeg0NdHA5nog6 SQyi5gPmDyDG1C9h1cq3LEghD9neV0yJ.sFILIifGsLVIrvDAuVhk61PNArv7J26fOQJl166IaUo lW7waRJlvMEnQ0ZdcJByL683UlNSLltQ72bIaxs3wPg4iywosj1o9yXd7Ve1j1_OA7o0mo.fV3AH jU_4JnOOLMIbwIEzr3Qg01wC8sUZkLl9GL27Ef5bYAcf5PRtu5tD4cTRRamLBjPIjAl8iK0pAfKu NbJMB93KLenZRQ5KYqqEH2KBEEBLG5zsT6regLwEFrs81wrYm_WcohyQf9hJmRJv82DL6SNzXbCi E9yGmtHUIKvfGwbQJezNDdXwnoiYE5mnpkFJEqlBMjuiW61rAFRePEJqgVK0SZs2UzZlUDrubnge ._sszneJ7fX2LIf42Mx9mOG7BaLPUPelWDcyZFO3RkicjEtU092GENvuXqH2kUmhcCjxZRudSaKs 6DidXiKiR8tDe9ZIsGdJcW8ppLOM...vpipu3sL7SUkGlxAfQKF.wvstak8WnZV9MHBIfvgxqQI0 WBYuEjB5C9IU_088XSD2tMGI2YUEHU3vetkXbewC6jvgjadaSu426Q4p9NGKi2_zxe6z7NegCAPV TEZ9HDGDXVNM1FnjUNNvGkf_ZAyxMattWPy3d0LBVTlM1D8hzR3wtiACeNtbAgkaMtTdAOtqVfhx qsZPZOeRuobdkp6rLtMe1.Ff.19IsqWMq4ekCGo78EvpfZYDNpo.Axw-- X-Sonic-MF: X-Sonic-ID: c0652755-41f1-40de-b129-bf55e3b14eed Message-ID: <7e4719b8-7396-4daa-aa8e-4c4836951de9@netscape.net> Date: Sat, 1 Aug 2026 08:03:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tools/hvmloader: implement Intel IGD extended VBT support To: xen-devel@lists.xenproject.org Cc: qemu-devel@nongnu.org, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Tomita Moeko References: <20260801000354.16446-1-brchuckz.ref@aol.com> <20260801000354.16446-1-brchuckz@aol.com> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20260801000354.16446-1-brchuckz@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.26215 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5398 X-purgate-ID: tlsNG-d62444/1785585810-BDA7E757-ED7C9CD1/0/0 X-purgate-type: clean X-purgate-size: 5498 On 7/31/2026 8:03 PM, Chuck Zmudzinski wrote: > Modern Intel IGD devices do not work well with the current > implementation of support for the Intel IGD in hvmloader because > it lacks support for an extended video bios table (VBT). > > Code 43 errors in Windows guests and failure of the guest screen > to light up are some of the problems that occur with the > current implementation. > > To address this problem, this patch implements support for > Intel IGD devices with an extended VBT and OpRegion version 2 > and higher which is required for most modern Intel IGD devices. > > This patch also depends on compatible support in the device > model. If hvmloader detects the device model lacks such support, > it will fall back to the currently implemented protocol for > configuring the OpRegion to provide backward compatibiltiy for > systems that lack a device model with support for an extended VBT. > > Support for an extended VBT is implemented in the newly introduced > function opregion_setup() which is implemented in the new file > intel_opregion.c. > > Major differences between this implementation and the current > implemntation that only supports older devices without an > extended VBT: > > 1. The current implemntation reserves a constant number of > pages (3) in the E820 map for the OpRegion which is set by > the IGD_OPREGION_PAGES macro in the current implementation. > With OpRegion 2 and higher, the OpRegion can have an > extended VBT that must be provided to the guest with the > OpRegion. This means the size of the region is not fixed, > so in this new implementation the IGD_OPREGION_PAGES constant > is changed to a variable in e820.c, igd_opregion_e820_pages, > that is set to its proper value based on the the size of the > VBT. In this new implemntation, the size of the ACPI NVS region > reserved for the OpRegion in the E820 map is equal to the value > of the igd_opregion_e820_pages variable instead of being set > to the constant value determined by IGD_OPREGION_PAGES. > > 2. The current implemntation provides the guest with access > to the unmodified OpRegion on the host via memory mapping > from the host to the guest. This is insufficient for > OpRegion 2 and higher because some devices will require > modifications to the OpRegion for proper operation in the > guest. So this new implementation provides hvmloader with a > copy of the host's OpRegion that hvmloader can modify as > needed for proper operation. Mapping the OpRegion from the > host to the guest is only used temporarily during setup of > the OpRegion by hvmloader and once hvmloader has a copy of > the OpRegion and the extended VBT, the device model removes > the host mapping and hvmloader configures the guest to use > the guest's possibly modified copy of the OpRegion instead. > > 3. The current implementation lacks useful debugging information > for the more recent devices. This new implementation provides > useful debugging output from hvmloader, such as the detected > host OpRegion version and address, the values for rvda, rvds, > and the guest OpRegion address when the guest_loglvl is set > to all/all. > > Link: https://lore.kernel.org/kvm/20211012124855.52463-1-colin.xu@gmail.com/ > Link: https://lore.kernel.org/kvm/20210325170953.24549-1-fred.gao@intel.com/ > Signed-off-by: Chuck Zmudzinski > --- > Later versions of this patch will provide a link to the compatible patch > for extended VBT support in the device model which will be posted to > the qemu-devel and xen-devel mailing lists and Cc'd to the appropriate > maintainers and reviewers soon. I forgot to mention that there is an undocumented setting that works in the xl.cfg(5) domain configuration file, firmware_override, that makes it possible to use a patched version of hvmloader alongside an installation of unpatched upstream Xen or a version of Xen packaged by a distro. So one can download the source for one's installed version of Xen, apply this patch and build just hvmloader and then install the patched version of hvmloader with a different filename, such as hvmloader-igd-testing, into the same directory where hvmloader is installed (usually something like /usr/libexec/xen/boot) and then one can configure a guest to use the patched version of hvmloader with one's installed version of Xen by adding a line like this to the domain xl.cfg file: firmware_override = 'hvmloader-igd-testing' > > The compatible patch for the device model is part of a larger patchset > that fixes many of the problems that currently affect the feature of > Intel IGD passthrough to Xen HVM guests. This patch should be considered > as a companion patch to that patchset for the device model. Do not try > to test this patch with a real Intel IGD device without also applying > the patchset for the device model because without those patches, the > guest will most likely fail to start if an Intel IGD is passed through > to the guest. > > There are different requirements to support OpRegion version 2.0 > and OpRegion version 2.1+, with support for OpRegion 2 the more > difficult case because it always requires modifications to the OpRegion > for proper operation in the guest. For some details about OpRegion > 2 and higher and the extended VBT, see the links in the commit message. > From xen-devel-bounces@lists.xenproject.org Sat Aug 01 14:42:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 01 Aug 2026 14:42:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380254.1624255 (Exim 4.92) (envelope-from ) id 1wqAv8-0005Se-Lr; Sat, 01 Aug 2026 14:42:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380254.1624255; Sat, 01 Aug 2026 14:42:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqAv8-0005SX-Ij; Sat, 01 Aug 2026 14:42:38 +0000 Received: by outflank-mailman (input) for mailman id 1380254; Sat, 01 Aug 2026 14:42:37 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqAv6-0005SR-8R for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 14:42:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqAv4-009QRQ-BF for xen-devel@lists.xenproject.org; Sat, 01 Aug 2026 16:42:35 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6e05b7-e002-0a2a0a5209dd-0a2a450ba9c2-20 for ; Sat, 01 Aug 2026 16:42:33 +0200 Received: from [91.218.175.185] (helo=out-185.mta0.migadu.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6e05d8-b7e8-0a2a450b0019-5bdaafb99398-3 for ; Sat, 01 Aug 2026 16:42:32 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=key1 header.d=linux.dev header.i="@linux.dev" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785595351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bAGXb0quOYyJBifFj3CMsobl7Wj528s8Q4pbvQG4r8=; b=NEVhQSZZKi4DShjfGxrZuPRqNtphOqe5pi5nbT5xk6bKbRruhnX8733czhr713IWW5JtNX lBIXPePnqdQ4ryvX+Ui/oO5FEIW8RXuUpYzDAhh8N6HVjtmRQGHRB2ii5QDX7Pypq+cifn JH9gGi4r4HorTfPR/8XI8D8vS+iUZ30= From: Usama Arif To: Zi Yan Cc: Usama Arif , David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: Re: [PATCH RFC 03/14] xen/grant-table: stop setting PG_private on pages for grant mapping Date: Sat, 1 Aug 2026 07:42:19 -0700 Message-ID: <20260801144223.1599317-1-usama.arif@linux.dev> In-Reply-To: <20260731-remove-pg_private-v1-3-142c97ba3562@nvidia.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-purgate-ID: tlsNG-42698a/1785595353-1AEDE9EA-5B6B8159/0/0 X-purgate-type: clean X-purgate-size: 2611 On Fri, 31 Jul 2026 22:13:26 -0400 Zi Yan wrote: > gnttab_alloc_pages() stores xen_page_foreign in allocated page->private. in allocated page->private "for 32-bit only". > On 32-bit, a pointer to xen_page_foreign is stored; on 64-bit, > xen_page_foreign is stored inline. Checking page->private != NULL is enough > to tell whether a xen_page_foreign needs to be freed on 32-bit and > page->private is zeroed unconditionally on 64-bit. > > It prepares for a future commit that remove PG_private. > > No funtional change intended. > > Assisted-by: Claude:claude-opus-4-8 > Assisted-by: Codex:gpt-5 > Signed-off-by: Zi Yan > To: Juergen Gross > To: Stefano Stabellini > Cc: Oleksandr Tyshchenko > Cc: xen-devel@lists.xenproject.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/xen/balloon.c | 5 +++++ > drivers/xen/grant-table.c | 7 +++---- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c > index e7f1d4ca6d753..7f47b0ad05607 100644 > --- a/drivers/xen/balloon.c > +++ b/drivers/xen/balloon.c > @@ -182,6 +182,11 @@ static struct page *balloon_retrieve(bool require_lowmem) > > __ClearPageOffline(page); > dec_node_page_state(page, NR_BALLOON_PAGES); > + /* > + * clear page->private before giving it out, since it might be used to > + * store xen_page_foreign info. > + */ > + set_page_private(page, 0); > > return page; > } > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > index 35f879dc5dfb8..cc348ba2e0786 100644 > --- a/drivers/xen/grant-table.c > +++ b/drivers/xen/grant-table.c > @@ -875,7 +875,7 @@ int gnttab_pages_set_private(int nr_pages, struct page **pages) > > set_page_private(pages[i], (unsigned long)foreign); > #endif > - SetPagePrivate(pages[i]); > + /* Data is stored in page->private on 64-bit */ On 64-bit arch you just iterate an empty for loop. Cleaner to put the whole for loop in ifdef? > } > > return 0; > @@ -1031,12 +1031,11 @@ void gnttab_pages_clear_private(int nr_pages, struct page **pages) > int i; > > for (i = 0; i < nr_pages; i++) { > - if (PagePrivate(pages[i])) { > #if BITS_PER_LONG < 64 > + if (page_private(pages[i])) > kfree((void *)page_private(pages[i])); > #endif > - ClearPagePrivate(pages[i]); > - } > + set_page_private(pages[i], 0); > } > } > EXPORT_SYMBOL_GPL(gnttab_pages_clear_private); > > -- > 2.53.0 > > From xen-devel-bounces@lists.xenproject.org Sun Aug 02 01:24:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 01:24:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380446.1624265 (Exim 4.92) (envelope-from ) id 1wqKwO-0000If-3A; Sun, 02 Aug 2026 01:24:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380446.1624265; Sun, 02 Aug 2026 01:24:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqKwN-0000IX-T6; Sun, 02 Aug 2026 01:24:35 +0000 Received: by outflank-mailman (input) for mailman id 1380446; Sun, 02 Aug 2026 01:24:33 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqKwL-0000IR-KE for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 01:24:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqKwK-00ATml-Az for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 03:24:32 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6e9bb8-e002-0a2a0a5209dd-0a2a4506a6b2-42 for ; Sun, 02 Aug 2026 03:24:31 +0200 Received: from [40.93.194.35] (helo=SN4PR0501CU005.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6e9c4e-195a-0a2a45060019-285dc223a853-3 for ; Sun, 02 Aug 2026 03:24:31 +0200 Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by CH3PR12MB7497.namprd12.prod.outlook.com (2603:10b6:610:153::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.17; Sun, 2 Aug 2026 01:24:23 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0270.016; Sun, 2 Aug 2026 01:24:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=temperror header.s=selector2 header.d=Nvidia.com header.i="@Nvidia.com" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XEVNIPKAqOIV9mPMnFjfnpvdbGwMTKWLPGO4LhReL0tHq6mHWSYYwVUOKL8Miz2KQabLfSzuwh7A6EMZiHGn3VvwqGf766VePfoiuI/g/oKJVDp9pZmVESwcX0NBOrgPCLgigBadgLDjXdjrnl/NFqOIAFnHso/2V1pps7CAPKCBj2G+T+Txmny9FXuRXGl5toLLV3EyvVtl63qwEf0+7AGS1fPJw5B+qJtJz7wXisSPJDvO54/BU3g56B4fSzJm5tnm7w0CD7d/jw7XkNolMG2OMszhjm4xZtyfEWqZ/G/wh6os5B81D5b7aphTRjP5lKp+3ke+PPDKPPb2r5MkUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/dve184dRKBcdbil6sKtCHstimONll/8S0M0bj98lGU=; b=IfsnNxhPaKZ4h/3EheHQka7tTyLaXbLejvGPfd0WdpLGo4KRkor9h/8i7l+AVoaUOiGNOWe4u9jQbEMX9fiyohSUz0RgVNKf+HdJ3sMRvCSw5w5glbmZo+Ig1AE3kWJQwmNG85/qvo6TICRoC5ROaA4l13JXfSLoUXrnISAoDPYaSWPRkhJ2KQQzSn9a4vOqGJkYonPji2IgGOaa0Q+DL0M1fPE1DZCK6UHxmFk9rzROT++LG+pRTZNbenlDrLRcd1B5RiCvx9KFTSrV8JRj/BYuor/Bx8OAk5d5q03WRIl67ZsPst+ch3Q++BuK5vSZHMG0dDRIBdpeyrV3uxAZIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/dve184dRKBcdbil6sKtCHstimONll/8S0M0bj98lGU=; b=pztXLPe5k9J0syXAUdpvNVHcnb2ztarvoesmwJ6WM/kxSKfqrt2MxPh46o9fw8cgcElsRWhqFZGP7oyorkoTByeuqciSZfFxc5Wtf1GhFsiUh2+bEIqrk8sqeNa6g32yhL48WgBy+Csd78vi4YiK5ay7GAdJwWJIwAKIKFkApzAnslJnEPfTqPdQfJXHyGEC7QWXvHj+f4nTRVDjmiXRWS6lZy8LHTzv3lGc7qWBKGWr/anfciJ635RHNjqEZDAM0bW+KK60Hwb2tzOQpK9l6ZJY2JNR5r/WkEgBBgLPZ/fnEd1G4rGAsRNNRJKX6rT8HHIw8IwznMLWwslBSw9EuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 01 Aug 2026 21:24:18 -0400 Message-Id: Subject: Re: [PATCH RFC 03/14] xen/grant-table: stop setting PG_private on pages for grant mapping Cc: "David Hildenbrand" , "Matthew Wilcox (Oracle)" , "Andrew Morton" , "Muchun Song" , "Lorenzo Stoakes" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Baolin Wang" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Barry Song" , "Lance Yang" , "Gregory Price" , "Ying Huang" , "Alistair Popple" , "Johannes Weiner" , "Qi Zheng" , "Shakeel Butt" , "Kairui Song" , , , "Juergen Gross" , "Stefano Stabellini" , "Oleksandr Tyshchenko" , To: "Usama Arif" From: "Zi Yan" X-Mailer: aerc 0.21.0 References: <20260731-remove-pg_private-v1-3-142c97ba3562@nvidia.com> <20260801144223.1599317-1-usama.arif@linux.dev> In-Reply-To: <20260801144223.1599317-1-usama.arif@linux.dev> X-ClientProxiedBy: CY5P220CA0011.NAMP220.PROD.OUTLOOK.COM (2603:10b6:930:ed::14) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|CH3PR12MB7497:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b51436f-178d-4c7f-8d75-08def034c8d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|23010399003|366016|11063799006|4143699003|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: GTL9MuIyFml9pJZkxR0sjs63KiJ3J+8GxVms+5aX0KtiKCEf+rQ5nG4tkJfvp3E7quVqmCgj0IKvlia372YhviX9j8HIRIrDOeC0Mborl8eTLQbGn1CRGcDRGZhFwR22XgQrg5sTQsnzRabvETE68xcsgu3d+AU3hUrW3HFiGR6Id0BRsiXVuQ6jCnBqdGdkxkn0kVyAhXID7YiUAyij1VWUHcZ6so3tbtC9sS4et4CYdlgkCRdjVXQj/9A8T9YNMEHYGwoBm2DIttalgxf3TjLQQ1AAM/wDTQWLPJIV2FppBfOnu4ooyC8INrfddZUsretpTCxy/Lh+GTlYl8/+dnvhsPFphs1XEpg02TblypTdKLyiTdLSCIZ64VWaMsDyHab5IPJG35XWoBTHMwjQvc2ghW7iRXzzL6sr7P86amfCZWqiDEXUZRPtu8lO8na2Prg+C7v6KKXqxA4s3fStYA4C88zZT9oh5tzTJYcimKzqb5XFQYAiRaWVuT4HZwf+Pc97yTJy+DBiad86t86VWi5Cs9VSTNolGB7HE1S0cqE6/OSgT9rtJZCMfqaEqT6MAEZYxdLBvyfxYEMpASB3saK/wLtxieDYhZ+Ztd83KZOlzEM250hUXF63m3miyX1XvK3LhFRhgkjPPfBwtyf6UNh2ArldG9LlBh5OJeyt41Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(23010399003)(366016)(11063799006)(4143699003)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YStDN1BLV2tpdk9Kc0ZORFJCK1o4eVhZdDdzN2VrQ1o2RzdxUTFuTG9QMGJP?= =?utf-8?B?VHFUbVN2SFJOYmFmbEhURWM0QTlsSHRQRWtRRTAwdUphbjI4YlF1L20xcTda?= =?utf-8?B?bmwxb1NKSWYwSXRXdFRsRDk0b2twZEhYQkVZTU5pVExOZ0JwU0s3amtrWTd2?= =?utf-8?B?cVQ1UEZmbDM3Z3IzTVA2aWtOVVVxdzJDNG1QS1BrRFNUVUorTEhrYmtxWUlX?= =?utf-8?B?Ty8wa2VVM1hnOC9nVW9PRmgwOTJvRHdsMndXZkNKeDdSaUd1MjlmTTRLS29t?= =?utf-8?B?czlRYjZJM2tWaEQrMk92RktmbU5OSFBqQ2JSUk42T0FFcGhwN3ZPdWhybWY4?= =?utf-8?B?bmh5SklIRXJKME5ocVlyU2tHaWNJYjg2MWFYaUc2Kys4aUJMK1dMWW5KUzNs?= =?utf-8?B?NmxOcUZsK2orcFhrMEZYdE8ySWZXVGo2TGM5dkZsdmp3Ti83ZmpIVm80T0o4?= =?utf-8?B?MCtyWFlQaWNaMFk3ZEZsaXFkTVZ0Y0RCekx2STdHOEV5Mk5CeFQyRmxlS1VZ?= =?utf-8?B?Q0NycW1zUUM3MEptTXA1N2Y2K3p1U2dydWluZXNyQnVHZUUycEwzN2ovQVpp?= =?utf-8?B?REZHYWllRzBDOVRBTExlRmgySXdYUjdmYzZaMlJ1TTF6eUtidGQ5L1IxQmpr?= =?utf-8?B?NzgyZ1RqK1NKUGRPeHZJblRkNkpsN0NaZkV6TEJRQjFibHltTHlJOHptQVB2?= =?utf-8?B?SElhN1JIT2s0SkkrR3lpY1dQczJzVGk1T29XMEdKaUFJb0wwN0dTRzArTnlZ?= =?utf-8?B?a204TnkxcVNsaGNMbEhwbUxkbnIwU2k5U1JMZWNlZ1NudUxTQmQ0QkpJVmN4?= =?utf-8?B?a2tPK3ZTZHI3R1pXWkF3dkN2dWFpdDlFVjZDUWRxVG1xYUdtMithUXh1bXFD?= =?utf-8?B?Y1FIYlFZdVJSVmE4bEZoeGdLWmlvZlVkQTBNMjNQa3BHMExTZ2N2NmdiaWFn?= =?utf-8?B?RXF1MkE1K1ltSlVqZEZ5QzBNV0tWQVh1ekNFeVppNjRhTFZxUXQ3UC80OFVa?= =?utf-8?B?MGlQb3lJS2VUSTBiRXhSc0o0NG9sbHNrUENCTUVKU1dhUEtqSUtlY1MwVWtQ?= =?utf-8?B?U1ZlbjE5NVE1N201cHNGajk5eGxza2YzMmppNHRsMzN5OHVheHljNUlseWZU?= =?utf-8?B?RnEzS3FXRE5TV2pnMnovQ05qc3ZWaDluUmhYVktBSGxpOG5Bai9jZHRuRTVQ?= =?utf-8?B?UURib2c1VGRiNG1hdE9vNzgzMVJvdnd3TTFGd0I5TG9hR0hPenBoTUo2OWh4?= =?utf-8?B?V3hmTHpzVlc5WmdFQlpKZkNjbGE4MERyRlg0TDh2bGkyNlR2a0FkQjZqZ2k0?= =?utf-8?B?eWltM1NSbEZTWGRObFk2QWxrdytxOG43ZENESkRiUmVSWkdQNlBZK1hHamJG?= =?utf-8?B?SlhWRG0wdXJ0aTJ3eUdKT0cxSVFVanFKRGlOb1ozaTVmVUtYREcvbnFUL210?= =?utf-8?B?SmhhOHdrdUZqOXRoWnNDOVAyVmtUTng2cEFSNVprQzRBeGp2RTl5VVFEWW91?= =?utf-8?B?ZmZUTlV3Zk9DaW9JYlBwa3krUzc2N1U2VVFpYkVQRGVOM1k0TkFOMy9RY1FU?= =?utf-8?B?Tmp4M3lUN0NEUXZQWCt4YUxsZXhNYm9ucjdkclBHY1V3M0pqYkFST3VKbHdq?= =?utf-8?B?dUJEU2s2aHU3akEwVVhUemloVzg0R05SYUx0LzExdzIwdmd3WUdHUnZjVE5E?= =?utf-8?B?UVhIT2pObmhvZGhmMFpMVDBsWWptTzhZd0VyeWpJd0xlcDllV3k1NG1rRElS?= =?utf-8?B?T0dyMmVwaXJNbEhlNlhNUUxuV0dEMVg1OWR6K2thRmFIV1dlSDJEVm93R2o0?= =?utf-8?B?ZDkvSTJUL0lwemFuTU9TRFN1MGY1ejdlUkxPdzRwS3gxZnZLSlBZNjFsR3k2?= =?utf-8?B?bmlUL1A3WEFPa3E4U0VHQlhRTVFxYTkyeTliUEFqdjBUT0ZrOUVLVUVtT2N1?= =?utf-8?B?ajFHakF0SWxKalE3dHZSUCtjNm0zOGhYWStZMk8yc0NWUERYZWlUMEZRd1lu?= =?utf-8?B?MWJ2b2xTS1YyTkhHaDdQZHR2eXdaK2M4Y3RYRzdYYWZoaFZveEw4cFIrUE4z?= =?utf-8?B?RWdkbkRJUTJWSVdEL1I2SHJPSjJMbnNyVkE0Q0RJRndjOGFTekNTWERzZjU2?= =?utf-8?B?eWwxVzhKcVFCNnZmRUY1VHNFV3c4Y3BBMzZsVU1nczFpQ3hGYnNCZmlUMU16?= =?utf-8?B?ZnBzRldxbVJ1ZmxVT0pSNHpadHRzVHRJWFAvSWhVUVZhcHdCSkpJb29sOUYr?= =?utf-8?B?SEFTN1VzNDM0ZlorVCtoSXZhMkhQQXpZT0kyT2dkckhaVEFudmRXVjF5K3hV?= =?utf-8?Q?5vUglnHOG7PTctab9d?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b51436f-178d-4c7f-8d75-08def034c8d1 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2026 01:24:23.2424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3PUHSVb9kPk6/DlsZk4L3x3wkLtYhelcslgc595NElzHQWP4c3rG3dXU7IPovngI X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7497 X-purgate-ID: tlsNG-16d1c6/1785633871-FCE0677B-C4497805/0/0 X-purgate-type: clean X-purgate-size: 2954 On Sat Aug 1, 2026 at 10:42 AM EDT, Usama Arif wrote: > On Fri, 31 Jul 2026 22:13:26 -0400 Zi Yan wrote: > >> gnttab_alloc_pages() stores xen_page_foreign in allocated page->private. > > in allocated page->private "for 32-bit only". I will remove "allocated" in the sentence. That should cover both 32-bit and 64-bit cases. > >> On 32-bit, a pointer to xen_page_foreign is stored; on 64-bit, >> xen_page_foreign is stored inline. Checking page->private !=3D NULL is e= nough >> to tell whether a xen_page_foreign needs to be freed on 32-bit and >> page->private is zeroed unconditionally on 64-bit. >>=20 >> It prepares for a future commit that remove PG_private. >>=20 >> No funtional change intended. >>=20 >> Assisted-by: Claude:claude-opus-4-8 >> Assisted-by: Codex:gpt-5 >> Signed-off-by: Zi Yan >> To: Juergen Gross >> To: Stefano Stabellini >> Cc: Oleksandr Tyshchenko >> Cc: xen-devel@lists.xenproject.org >> Cc: linux-kernel@vger.kernel.org >> --- >> drivers/xen/balloon.c | 5 +++++ >> drivers/xen/grant-table.c | 7 +++---- >> 2 files changed, 8 insertions(+), 4 deletions(-) >>=20 >> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c >> index e7f1d4ca6d753..7f47b0ad05607 100644 >> --- a/drivers/xen/balloon.c >> +++ b/drivers/xen/balloon.c >> @@ -182,6 +182,11 @@ static struct page *balloon_retrieve(bool require_l= owmem) >> =20 >> __ClearPageOffline(page); >> dec_node_page_state(page, NR_BALLOON_PAGES); >> + /* >> + * clear page->private before giving it out, since it might be used to >> + * store xen_page_foreign info. >> + */ >> + set_page_private(page, 0); >> =20 >> return page; >> } >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c >> index 35f879dc5dfb8..cc348ba2e0786 100644 >> --- a/drivers/xen/grant-table.c >> +++ b/drivers/xen/grant-table.c >> @@ -875,7 +875,7 @@ int gnttab_pages_set_private(int nr_pages, struct pa= ge **pages) >> =20 >> set_page_private(pages[i], (unsigned long)foreign); >> #endif >> - SetPagePrivate(pages[i]); >> + /* Data is stored in page->private on 64-bit */ > > On 64-bit arch you just iterate an empty for loop. Cleaner to put the > whole for loop in ifdef? Sure. Will do that. > >> } >> =20 >> return 0; >> @@ -1031,12 +1031,11 @@ void gnttab_pages_clear_private(int nr_pages, st= ruct page **pages) >> int i; >> =20 >> for (i =3D 0; i < nr_pages; i++) { >> - if (PagePrivate(pages[i])) { >> #if BITS_PER_LONG < 64 >> + if (page_private(pages[i])) >> kfree((void *)page_private(pages[i])); >> #endif >> - ClearPagePrivate(pages[i]); >> - } >> + set_page_private(pages[i], 0); >> } >> } >> EXPORT_SYMBOL_GPL(gnttab_pages_clear_private); >>=20 >> --=20 >> 2.53.0 >>=20 >>=20 --=20 Best Regards, Yan, Zi From xen-devel-bounces@lists.xenproject.org Sun Aug 02 05:08:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 05:08:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380488.1624278 (Exim 4.92) (envelope-from ) id 1wqOR8-0003Dj-HI; Sun, 02 Aug 2026 05:08:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380488.1624278; Sun, 02 Aug 2026 05:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqOR8-0003Da-Ci; Sun, 02 Aug 2026 05:08:34 +0000 Received: by outflank-mailman (input) for mailman id 1380488; Sun, 02 Aug 2026 05:08:33 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqOR7-0003DU-4a for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 05:08:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqOR5-003hFc-Rf for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 07:08:31 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6ed0c5-e002-0a2a0a5209dd-0a2a4505806a-4 for ; Sun, 02 Aug 2026 07:08:30 +0200 Received: from [98.137.65.32] (helo=sonic315-8.consmr.mail.gq1.yahoo.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6ed0cd-4cb1-0a2a45050019-62894120a298-3 for ; Sun, 02 Aug 2026 07:08:30 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sun, 2 Aug 2026 05:08:28 +0000 Received: by hermes--production-ne1-6f6bdbdd7c-6qsrs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 38873ceacd7487424d36cd594a4ef84d; Sun, 02 Aug 2026 05:08:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785647308; bh=qI3cvxJkB0wST2pLg+kJk+H1/7OsJAYv2EoXvyMCIBI=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=dT0rXBUgs0mgBPCg8e+PeGnZbTqg7eRBYBxXIk10d911DXOTsGqOt4TVAEErMU3TKiNtcmSe/hmug7qGSBqMhId+lUbg1fhmYIOcKzTWw6jQfNuewFWvSLdc4rQe2Mk6lzIpkutmP0j3pxbydnUvXaxKdFO61ocJS9EGi3qnn6hb2o88hRQ18m1vHuxTT2o0AJ6SSVdjxas9OCj1ua8ajOp17zq18UIijLOnwZSkxZ1p2bXnbPsa01OIb8PqIMA3W6DNGn7eMNVsVZQLEFMH+eSnFQuNnSikHAnCB/k//h7Su8H/5YB9g8/EuhCuJ5SKJwNWbbols0a0LAw37sR+2A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785647308; bh=55uMRXMxddGSCqkDCycETdUXDjoHOP1zl/jTH9nPnTt=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=BWVg2F3ISOn9a+MnZ7gd1DX/vCZGKt50+SzK17C4QUBrjBODaLUBSHqzdvGqMRwh0fnbnhqkjuxo8Duou9AeAJu3dwtbPOvxAiAPdc/T6dbDYFx8qWThgnUhMoF4A1HsN+SsZJWyfNYQnh6Durf3XwcS0zO2/RyQdubS+62U4T87tmO9h7vF7vkBGWcz9nwlS0yS47U/xlCD3H+eWsa+VL7ESTg++kgAK15YixDUxvNX8aBCvFBaOguX/SUxiWItc9wrbKCKw8qSdxsE9JD2VxBtn3P0Ix8jqb4rX2XlbHI+ghcH0I4v/dDqufOIsQy/BD4rf7l2Lp1YqrMkmoHnfA== X-YMail-OSG: KwRT3NkVM1npbbUkdnGcr_aHoBT436ZNTELI4trj0hzZgfcNEtANa_UFL9s26Lj 7fmfhx3YG6uGFZ2tShgSUBAjckUWfJzo8MXPckMbLGfzAUrpl60Kxy6fENxqUOOLrhFW7AzHGfAs nyfr30VnnVFwsyClZPVDhFQcCorqlkom_vpX9OSdFYtRQfOGBdSdTDHZat5NWUwd361HhcQRPtnK i3CK5VMOtqwhoLsIncOBUgpxPeoil_y2Pf9WRHNe7rAPLIn0QB4LIu94fLwhKntnGpL0Vlv.DD.. 3LmL2QrT.h_KIxXlq07ufwHYe6isKly654swXs4GCSdD9OxE_pgjUOf4hkA4fH5cefr_VoMTbHj0 Esa9aydO8CrE52wVGSfRNX_QwgIuOqyYCbn.B9505U8Jq_1vNxQnPHXzlkgl.nAoadbfF0wn5dqK 3nVmdRW0WrJG4ztjFNS5UWR7Cc5IRp3wSZd823N0uZK914Q6.8DZMNHGbmSfaOfXav6uAOJlGhZg 0dvM3MQXobpcX6QpmWNrLYUuGJXvL6totqmqtghxH1MStD2C6zVGsmDbEJ_DLBhVv1TWz94dVUEJ _2_mCaXeh_CepKFIkh94hH2bGkyO25KaLUK6hp9zXHXoVTLP2NZ6SvUJAdiHCBJWhZqiH6YV1U98 hd85CSdyZtMKfhQsPkSMZp8Dq1bmyxmnY7pAsFg.2PKZ8vBPugibTesKOEK5n153X6dDBd6Ytkm6 .tTBu9sL3lMQWVO5h_DMtdnvC3kM84DAEnrl0sCg8nDn58XOk7o4cre_kiClCxyhLlAnT5a67rlD R9PoeXeh0Co_pzDKCWHugjob2asMQgoGI1qg4_pZmVKksAzAUGEE8l_ncdu.9npX4Cc5pSj5nfKx m8__ZhWVpDGfbwvt5zSZgWXzz7_syHU4kRZqW3P7gNeGY3x8l2dVRiKLRoEa.C0HkBbGyDEQVrSV x7JaYO9HVVRKG6qQHrUncL7NimDpjaz0hJk7qlBZUZBzh.xL5LF3uz0tnNf2vxRt6t.y0YjjwtQ1 PYiaL8IaKxeUpc44wDydcDYh_0J6rX_DFCXMSU4Rk7O33jRxHBkuKWbV60bGCxBLM5lOe.P_wGIZ jVITAM1UnItQ2KOZFeDvjK7nR45S7_ZZWPBl4JW3kHdrfzDswjGQ8LbmlJZwb3ewLjtRzsikx3TW BCxjzN7M2.x.OvN2WYVxX8mtAWcPNF8e731Ob1ADKak29X_scdRWxxwGytfmhJvsK29nNDTayhlE 4uuJVb.OfFRrTudknVNgT1L8jqDePs1jivsxui32zmtjUW9R9rT87FrKyJgeXUK3CyUi_OWEUV6c IOHu4Q4CDEC7a1NRvQ5Ifr0p7uAh_drMzHWUYECaOu4C894.h75huHzBYc969x5h128NahwGi9XD mS3DpOZ1EYK1UN5PmwHStXa6mi69FkcpWjWQRviMweXQxK4J_Ek3StkRiCFWiOUlE5747ItHF1hP ThKfH7mGCvhNxshxhfr7AlqL3Ngixkqa6xQpUQNvZWKU8bo3MxSd_s80tuJpsFimPKXtVbM2LgCG oNrRKChYqHepvX8SyZonU0jz.90ieAq.mU9yAL2q9gosx4UgsKk7BBiMrCHqvTwL3wnQHiVdUEVg knMdwcacNS0PI.f8APr4NGbBJhMuUgUr1m.yFMjA.mybqKHYqP8bzeEBuByV12K0ULqVnnq.AUoj 1d25kHVN3IZ_CZcA0a6VcJUzkEbgt6NI.nYxyrL9Nx4CUW0a_yc_xMu4MFYshyoChyHEL8nuaBQX bLhJvwuWYFcowUxhP4MJcZ34R7z5FGquqgUJh7qzJyWNePo.Ey.JaNrtkH96XOvuM30OiWrb1Fvk csU8UxS6CYlLG896VmE6kk3deZHMq32g48JkF_TEvwaJXpPxgGiHS6m3VvLLoKrYPQu0hYKgyI.K ISDGQnwgKxREOIfFZfDRV4HVQJHntNG6SpWKlnOkZ1e.klDDdiRmNu7WpoPfMw5MsJOKpERfc4Dn EtOmj631iW_As7dXP_LrfOrt3ebAzPSu9QvgmtfcwwyCAaH10pOeAtloJf74ZkJjhLcLxX_9_JEk gR._XNKQ25kzUWLmh_XUx074ift5LfdhDj3RaE.WZlVWPzzyCGbarfVR.3tf4wK5CdHTSDm3cB9m L70llLWtuPn0MhQO9J2PfuG7.X23GeDMbsxkQLvDSb5Qbgq7oc5NRMWSzi5dwUMMjDG0ib1Im8Bo P4h1bsZgsK.Nx_PDuimzvrP3Bdav1xVmQl1xV9ZKFHIgpKw-- X-Sonic-MF: X-Sonic-ID: 102b02d6-5502-4279-a553-a5f20c7f39e4 From: Chuck Zmudzinski To: xen-devel@lists.xenproject.org Cc: qemu-devel@nongnu.org, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v2] tools/hvmloader: implement Intel IGD extended VBT support Date: Sun, 2 Aug 2026 01:08:10 -0400 Message-ID: <20260802050824.10554-1-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <20260802050824.10554-1-brchuckz.ref@aol.com> Content-Length: 21848 X-purgate-ID: tlsNG-c201ff/1785647310-714AC2A1-F72EF1AD/0/0 X-purgate-type: clean X-purgate-size: 22391 Modern Intel IGD devices do not work well with the current implementation of support for the Intel IGD in hvmloader because it lacks support for an extended video bios table (VBT). Code 43 errors in Windows guests and failure of the guest screen to light up are some of the problems that occur with the current implementation. To address this problem, this patch implements support for Intel IGD devices with an extended VBT and OpRegion version 2 and higher which is required for most modern Intel IGD devices. This patch also depends on compatible support in the device model. If hvmloader detects the device model lacks such support, it will fall back to the currently implemented protocol for configuring the OpRegion to provide backward compatibiltiy for systems that lack a device model with support for an extended VBT. Support for an extended VBT is implemented in the newly introduced function intel_opregion_setup() which is implemented in the new file intel_opregion.c. Major differences between this implementation and the current implemntation that only supports older devices without an extended VBT: 1. The current implemntation reserves a constant number of pages (3) in the E820 map for the OpRegion which is set by the IGD_OPREGION_PAGES macro in the current implementation. With OpRegion 2 and higher, the OpRegion can have an extended VBT that must be provided to the guest with the OpRegion. This means the size of the region is not fixed, so in this new implementation the IGD_OPREGION_PAGES constant is changed to a variable in e820.c, igd_opregion_e820_pages, that is set to its proper value based on the the size of the VBT. In this new implemntation, the size of the ACPI NVS region reserved for the OpRegion in the E820 map is equal to the value of the igd_opregion_e820_pages variable instead of being set to the constant value determined by IGD_OPREGION_PAGES. 2. The current implemntation provides the guest with access to the unmodified OpRegion on the host via memory mapping from the host to the guest. This is insufficient for OpRegion 2 and higher because some devices will require modifications to the OpRegion for proper operation in the guest. So this new implementation provides hvmloader with a copy of the host's OpRegion that hvmloader can modify as needed for proper operation. Mapping the OpRegion from the host to the guest is only used temporarily during setup of the OpRegion by hvmloader and once hvmloader has a copy of the OpRegion and the extended VBT, the device model removes the host mapping and hvmloader configures the guest to use the guest's possibly modified copy of the OpRegion instead. 3. The current implementation lacks useful debugging information for the more recent devices. This new implementation provides useful debugging output from hvmloader, such as the detected host OpRegion version and address, the values for rvda, rvds, and the guest OpRegion address when the guest_loglvl is set to all/all. Link: https://lore.kernel.org/kvm/20211012124855.52463-1-colin.xu@gmail.com/ Link: https://lore.kernel.org/kvm/20210325170953.24549-1-fred.gao@intel.com/ Signed-off-by: Chuck Zmudzinski --- The companion patchset for the device model is available here: https://lore.kernel.org/xen-devel/20260801001737.16509-1-brchuckz@aol.com/ There is an undocumented setting that works in the xl.cfg(5) domain configuration file, firmware_override, that makes it possible to use a patched version of hvmloader alongside an installation of unpatched upstream Xen or a version of Xen packaged by a distro. So one can download the source for one's installed version of Xen, apply this patch and build just hvmloader and then install the patched version of hvmloader with a different filename, such as hvmloader-igd-testing, into the same directory where hvmloader is installed (usually something like /usr/libexec/xen/boot) and then one can configure a guest to use the patched version of hvmloader with one's installed version of Xen by adding a line like this to the domain xl.cfg file: firmware_override = 'hvmloader-igd-testing' The compatible patch for the device model is part of a larger patchset that fixes many of the problems that currently affect the feature of Intel IGD passthrough to Xen HVM guests. This patch should be considered as a companion patch to that patchset for the device model. Do not try to test this patch with a real Intel IGD device without also applying the patchset for the device model because without those patches, the guest will most likely fail to start if an Intel IGD is passed through to the guest. There are different requirements to support OpRegion version 2.0 and OpRegion version 2.1+, with support for OpRegion 2 the more difficult case because it always requires modifications to the OpRegion for proper operation in the guest. For some details about OpRegion 2 and higher and the extended VBT, see the links in the commit message. Changes in v2: - Correct the name of the new function in the commit message opregion_setup() -> intel_opregion_setup() - Add a link to the companion patchset for the device model - Describe how to use the firmware_override setting in xl.cfg(5) to simplify testing of this patch. - Correct a logical flaw that in case the size of the extended VBT is <= 2 pages, an extra, unnecessary page would be allocated in the memory hole. This correction is in the intel_opregion.c file. This code: /* Update the number of pages we need for the E820 map */ igd_opregion_e820_pages = pages_needed; /* * So far we have allocated vbt_pages_needed * and we will likely need to allocate more * pages to fully contain OpRegion + VBT. */ if ( pages_needed > vbt_pages_needed ) igd_opregion_pgbase = mem_hole_alloc (pages_needed - vbt_pages_needed); Is replaced with this code: /* * So far we have allocated igd_opregion_e820_pages * and we will likely need to allocate more * pages to fully contain OpRegion + VBT. */ if ( pages_needed > igd_opregion_e820_pages ) igd_opregion_pgbase = mem_hole_alloc (pages_needed - igd_opregion_e820_pages); /* Update the number of pages we need for the E820 map */ igd_opregion_e820_pages = pages_needed; tools/firmware/hvmloader/Makefile | 1 + tools/firmware/hvmloader/config.h | 15 +- tools/firmware/hvmloader/e820.c | 4 +- tools/firmware/hvmloader/intel_opregion.c | 297 ++++++++++++++++++++++ tools/firmware/hvmloader/pci.c | 10 +- 5 files changed, 313 insertions(+), 14 deletions(-) create mode 100644 tools/firmware/hvmloader/intel_opregion.c diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile index 21de721..ed42915 100644 --- a/tools/firmware/hvmloader/Makefile +++ b/tools/firmware/hvmloader/Makefile @@ -35,6 +35,7 @@ OBJS += smp.o cacheattr.o xenbus.o vnuma.o OBJS += e820.o pci.o pir.o ctype.o OBJS += hvm_param.o OBJS += ovmf.o seabios.o +OBJS += intel_opregion.o ifeq ($(debug),y) OBJS += tests.o endif diff --git a/tools/firmware/hvmloader/config.h b/tools/firmware/hvmloader/config.h index c159db3..bd3c0f9 100644 --- a/tools/firmware/hvmloader/config.h +++ b/tools/firmware/hvmloader/config.h @@ -7,9 +7,6 @@ enum virtual_vga { VGA_none, VGA_std, VGA_cirrus, VGA_pt }; extern enum virtual_vga virtual_vga; -extern unsigned long igd_opregion_pgbase; -#define IGD_OPREGION_PAGES 3 - struct bios_config { const char *name; @@ -43,6 +40,18 @@ extern struct bios_config ovmf_config; #define PAGE_SHIFT 12 #define PAGE_SIZE (1ul << PAGE_SHIFT) +#define IGD_OPREGION_PAGES 3 +#define IGD_OPREGION_SIZE ((IGD_OPREGION_PAGES - 1) << PAGE_SHIFT) +#define IGD_OPREGION_RVDA 0x3ba +#define IGD_OPREGION_RVDS 0x3c2 +#define IGD_OPREGION_VERSION 0x16 +#define IGD_OPREGION_MASK 0xfff +#define IGD_OPREGION2_SUPPORT_MASK 0x1 +#define IGD_OPREGION_SIGNATURE "IntelGraphicsMem" +#define IGD_VBT_SIGNATURE "$VBT" +extern unsigned long igd_opregion_pgbase; +extern uint32_t igd_opregion_e820_pages; +void intel_opregion_setup(uint32_t vga_devfn); extern uint8_t ioapic_version; diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c index 86d3954..97a234e 100644 --- a/tools/firmware/hvmloader/e820.c +++ b/tools/firmware/hvmloader/e820.c @@ -243,11 +243,11 @@ int build_e820_table(struct e820entry *e820, nr++; e820[nr].addr = igd_opregion_base; - e820[nr].size = IGD_OPREGION_PAGES * PAGE_SIZE; + e820[nr].size = igd_opregion_e820_pages * PAGE_SIZE; e820[nr].type = E820_NVS; nr++; - e820[nr].addr = igd_opregion_base + IGD_OPREGION_PAGES * PAGE_SIZE; + e820[nr].addr = igd_opregion_base + igd_opregion_e820_pages * PAGE_SIZE; e820[nr].size = (uint32_t)-e820[nr].addr; e820[nr].type = E820_RESERVED; nr++; diff --git a/tools/firmware/hvmloader/intel_opregion.c b/tools/firmware/hvmloader/intel_opregion.c new file mode 100644 index 0000000..59cb2c3 --- /dev/null +++ b/tools/firmware/hvmloader/intel_opregion.c @@ -0,0 +1,297 @@ +/* + * intel_opregion.c: HVM Intel OpRegion setup. + * + * Leendert van Doorn, leendert@watson.ibm.com + * Copyright (c) 2005, International Business Machines Corporation. + * + * Copyright (c) 2006, Keir Fraser, XenSource Inc. + * + * Copyright (c) 2026, Charles Zmudzinski. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#include "util.h" +#include "config.h" +#include "pci_regs.h" + +unsigned long igd_opregion_pgbase = 0; +uint32_t igd_opregion_e820_pages = IGD_OPREGION_PAGES; + +static bool verify_opregion(const uint32_t addr) +{ + const char *opregion_signature = IGD_OPREGION_SIGNATURE; + if ( memcmp((const void *)addr, (const void *)opregion_signature, 16) ) + return false; + return true; +} + +static bool verify_vbt(const uint32_t addr) +{ + const char *vbt_signature = IGD_VBT_SIGNATURE; + if ( memcmp((const void *)addr, (const void *)vbt_signature, 4) ) + return false; + return true; +} + +void intel_opregion_setup(uint32_t vga_devfn) +{ + uint32_t igd_guest_opregion; + uint32_t pages_needed; /* for OpRegion + VBT */ + void *opregion_scratch; + void *vbt_scratch; + void *vbt_source; + /* + * absolute value in the host/guest except + * as noted in the comments + */ + static unsigned long rvda_host; + static unsigned long rvda_guest; + + igd_opregion_pgbase = mem_hole_alloc(IGD_OPREGION_PAGES); + /* + * Tentative value for the number of pages to reserve + * in the E820 map for the OpRegion and VBT. + * + * This will be the final value for the E820 map if + * the device model lacks support for OpRegion 2 or + * if the host OpRegion version is < 2 or if we never + * allocate more pages in the E820 map for the VBT. + */ + igd_opregion_e820_pages = IGD_OPREGION_PAGES; + + /* + * Read the value the device model is initialized with. + * If the device model supports OpRegion 2, it will + * return the host IGD OpRegion address. If not, it + * will return 0. If the device model does not support + * OpRegion 2, the device model expects us to give it + * the address to which it will map the OpRegion in the + * guest and then expects us to do nothing more to setup + * the OpRegion, so that is all we will do in that case. + */ + const uint32_t igd_host_opregion = pci_readl(vga_devfn, + PCI_INTEL_OPREGION); + if ( !igd_host_opregion ) { + printf("device model lacks extended VBT " + "support. Continuing with legacy support only\n"); + /* + * Write the the OpRegion offset to give the OpRegion + * address to the device model. The device model will trap + * and map the OpRegion at the give address. + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + igd_opregion_pgbase << PAGE_SHIFT); + return; + } else { + printf("host OpRegion address: 0x%x\n", + igd_host_opregion); + } + + const uint32_t igd_host_opregion_page_offset = + igd_host_opregion & IGD_OPREGION_MASK; + igd_guest_opregion = (igd_opregion_pgbase << PAGE_SHIFT) | + igd_host_opregion_page_offset; + + /* + * We know at this point the device model supports + * OpRegion 2. + * + * Indicate to the device model that we support + * OpRegion 2 by setting the least significant bit + * of the address we give to the device model. + * The device model will notice this bit set and + * respond appropriately to our writes to the + * register where the OpRegion address is stored. + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + (igd_opregion_pgbase << PAGE_SHIFT) | + IGD_OPREGION2_SUPPORT_MASK); + + printf("guest OpRegion tentative " + "address: 0x%x\n", igd_guest_opregion); + + if ( !verify_opregion(igd_guest_opregion) ) { + printf("error: IGD OpRegion signature " + "not found.\n"); + BUG(); + } + + opregion_scratch = scratch_alloc(IGD_OPREGION_SIZE, 0); + memcpy(opregion_scratch, (const void *)igd_guest_opregion, + IGD_OPREGION_SIZE); + + /* Read OpRegion version, rvda_host, and rvds */ + const uint16_t version = *(uint16_t *)(opregion_scratch + + IGD_OPREGION_VERSION); + printf("OpRegion version: 0x%x\n", version); + if ( version >= 0x0200 ) { + rvda_host = *(unsigned long *)(opregion_scratch + + IGD_OPREGION_RVDA); + /* It is convenient to make rvda_host absolute */ + if ( version > 0x0200 ) + rvda_host += igd_host_opregion; + printf("host VBT address: 0x%lx\n", rvda_host); + } else { + printf("guest OpRegion address: 0x%x\n", igd_guest_opregion); + rvda_host = 0; + } + const uint32_t rvda_host_page_offset = rvda_host & + IGD_OPREGION_MASK; + const uint32_t rvds = *(uint32_t *)(opregion_scratch + + IGD_OPREGION_RVDS); + const uint32_t rvds_page_offset = rvds & IGD_OPREGION_MASK; + printf("VBT size: 0x%x\n", rvds); + + if ( !rvds || !rvda_host ) { + printf("guest OpRegion address: 0x%x\n", igd_guest_opregion); + rvda_host = 0; + } + /* + * Write rvda_host as 2 successive 32-bit values + * to communicate location of the VBT to the device + * model. If rvda_host is not 0, The device model + * unmaps the OpRegion and eventually maps the VBT + * after we also write the guest address where the + * VBT will be mapped. + * + * If we send rvda_host = 0 to the device model, it + * will assume we do not need OpRegion 2 support and + * it will not unmap the OpRegion. + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + (uint32_t)(rvda_host & 0xfffffffful)); + unsigned long rvda_host_upper_32 = (uint64_t)rvda_host >> 32; + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + (uint32_t)rvda_host_upper_32); + + /* In this case, we use the mapped OpRegion */ + if ( !rvda_host ) + return; + + /* + * Update the number of pages the device model + * needs to map for us to get a copy of the VBT. + * + * N.B.: Here, igd_opregion_pgbase is really the page + * base of the location where the device model will + * map the VBT. + */ + uint32_t vbt_pages_needed = rvds >> PAGE_SHIFT; + if ( rvds & IGD_OPREGION_MASK ) + vbt_pages_needed++; + if ( vbt_pages_needed > igd_opregion_e820_pages ) { + igd_opregion_pgbase = mem_hole_alloc + (vbt_pages_needed - igd_opregion_e820_pages); + igd_opregion_e820_pages = vbt_pages_needed; + } + + /* + * Write the location where the device model is to + * map the VBT in the guest with the 12 least + * significant bits encoded as the number of pages + * for the device model to map (vbt_pages_needed). + */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, + ((igd_opregion_pgbase << PAGE_SHIFT) | vbt_pages_needed)); + + /* + * When the VBT is mapped from the host, the page offset + * of the VBT will be the same as on the host + */ + rvda_guest = (igd_opregion_pgbase << PAGE_SHIFT) | + rvda_host_page_offset; + if ( !verify_vbt(rvda_guest) ) { + printf("error: VBT signature not found.\n"); + BUG(); + } + + vbt_source = (void *)rvda_guest; + vbt_scratch = scratch_alloc(rvds, 0); + memcpy(vbt_scratch, vbt_source, rvds); + + /* Compute how many pages we need for OpRegion + VBT */ + pages_needed = (IGD_OPREGION_SIZE + rvds) >> PAGE_SHIFT; + if ( (IGD_OPREGION_SIZE + rvds) & IGD_OPREGION_MASK ) + pages_needed++; + + /* + * So far we have allocated igd_opregion_e820_pages + * and we will likely need to allocate more + * pages to fully contain OpRegion + VBT. + */ + if ( pages_needed > igd_opregion_e820_pages ) + igd_opregion_pgbase = mem_hole_alloc + (pages_needed - igd_opregion_e820_pages); + + /* Update the number of pages we need for the E820 map */ + igd_opregion_e820_pages = pages_needed; + + /* + * Compute the final igd_guest_opregion value and + * keep the same offset as on the host if doing so + * will not push us across another page boundary. + */ + igd_guest_opregion = igd_opregion_pgbase << PAGE_SHIFT; + if ( (igd_host_opregion_page_offset + rvds_page_offset) <= PAGE_SIZE ) + igd_guest_opregion |= igd_host_opregion_page_offset; + printf("guest OpRegion address: 0x%x\n", igd_guest_opregion); + + /* The device model will unmap the VBT */ + pci_writel(vga_devfn, PCI_INTEL_OPREGION, igd_guest_opregion); + + /* + * After unmapping we need to populate the memory hole. + * If the unmapping failed this will crash the guest. + * + * We could try to use the mapped VBT with our copy of the + * OpRegion, but it is probably better to BUG() if the + * device model failed to unmap the VBT. + */ + if ( verify_vbt(rvda_guest) ) + BUG(); + mem_hole_populate_ram(igd_opregion_pgbase, + igd_opregion_e820_pages); + + /* + * After unmapping we are free to shift the VBT by + * an arbitrary number of bytes. For efficient use + * of memory and to keep the memory map simple, + * place the VBT contiguous after the OpRegion. + */ + rvda_guest = igd_guest_opregion + IGD_OPREGION_SIZE; + printf("guest VBT address: 0x%lx\n", rvda_guest); + + /* + * Until now, rvda_guest has been an absolute address + * in the guest. We need to translate it to a relative + * address if OpRegion version > 0x0200 and in that case + * we also verify it is contiguous with the OpRegion. + */ + if ( version > 0x0200 ) { + rvda_guest -= igd_guest_opregion; + printf("guest rvda (relative): 0x%lx\n", rvda_guest); + BUG_ON(rvda_guest != IGD_OPREGION_SIZE); + } + + /* + * Write the correct rvda_guest value to the + * guest copy of the OpRegion and copy the scratch + * buffers to the correct address in our E820 region. + */ + *(unsigned long *)(opregion_scratch + IGD_OPREGION_RVDA) = rvda_guest; + memcpy((void *)(igd_guest_opregion + IGD_OPREGION_SIZE), + (const void *)vbt_scratch, rvds); + memcpy((void *)igd_guest_opregion, + (const void *)opregion_scratch, IGD_OPREGION_SIZE); +} diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c index c41c8d9..07a37e5 100644 --- a/tools/firmware/hvmloader/pci.c +++ b/tools/firmware/hvmloader/pci.c @@ -43,7 +43,6 @@ uint64_t pci_hi_mem_start = 0, pci_hi_mem_end = 0; #define BAR_RELOC_THRESH GB(1) enum virtual_vga virtual_vga = VGA_none; -unsigned long igd_opregion_pgbase = 0; /* Check if the specified range conflicts with any reserved device memory. */ static bool check_overlap_all(uint64_t start, uint64_t size) @@ -190,14 +189,7 @@ void pci_setup(void) virtual_vga = VGA_pt; if ( vendor_id == 0x8086 ) { - igd_opregion_pgbase = mem_hole_alloc(IGD_OPREGION_PAGES); - /* - * Write the the OpRegion offset to give the opregion - * address to the device model. The device model will trap - * and map the OpRegion at the give address. - */ - pci_writel(vga_devfn, PCI_INTEL_OPREGION, - igd_opregion_pgbase << PAGE_SHIFT); + intel_opregion_setup(vga_devfn); } } break; -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 05:21:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 05:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380496.1624286 (Exim 4.92) (envelope-from ) id 1wqOdO-0005rZ-IR; Sun, 02 Aug 2026 05:21:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380496.1624286; Sun, 02 Aug 2026 05:21:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqOdO-0005rS-Eo; Sun, 02 Aug 2026 05:21:14 +0000 Received: by outflank-mailman (input) for mailman id 1380496; Sun, 02 Aug 2026 05:21:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqOdM-0005rM-LP for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 05:21:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqOdM-007bSz-2L for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 07:21:12 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6ed3a3-2eae-0a2a0a5409dd-0a2a4502a064-24 for ; Sun, 02 Aug 2026 07:21:11 +0200 Received: from [98.137.65.84] (helo=sonic313-21.consmr.mail.gq1.yahoo.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6ed3c1-6ca4-0a2a45020019-62894154a0ab-3 for ; Sun, 02 Aug 2026 07:21:06 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Sun, 2 Aug 2026 05:21:04 +0000 Received: by hermes--production-ne1-6f6bdbdd7c-6qsrs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5835b75ab342781156a842e5dbde47e3; Sun, 02 Aug 2026 05:20:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=netscape.net header.i="@netscape.net" header.h="Date:Subject:To:Cc:References:From:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1785648064; bh=tj8RIhqOXdYnx1HcBJgeOZ7JZFvUwTdqF2qHquu6/eY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=uM+GbcJXRELucFBpSuvdtKd651VUtycEdshz8fG/EiRQTobl81p0wUbTNIH/94GfkzLtYIOSgWp6md5FHLZWigqffnUQf16VyoV59oa9u+VpeDvmQI8qiIAW7IzLVpFYYjWj0hF2Hh6UPqCWArNlfOzHbPfP6BLcU1Oe7lBGPkTEgpe7p+dntSLfOxKOomM6kYxy0GReFSzIWGk6uLllg96poEFKHd8OW0w0eqZ7aSyFR1Bw6xgWiQVjSvPa3e3C328KSCIPg4r2rUZN9ybWRobWvNTach37Tz2HUSxKAqH331w8P9Ppaj2S+z7diZMN9Yo4YW94q8JtOA1JIUuQTw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785648064; bh=t8hnSLzTo5kXfTM5hXR5EvB4kIcyJhJM2cMOg/DaYOH=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=q9XFzQB+uRnY/8nG1EyN6FiEDVpjw3CtgJBtwvV3xt4i7eFoPpLfhFN1xdCcGwJ1XDYR5/uVkOXQgMOa6ODDU7PSQmtGq4Do8JWB6NgOV/m9LU4c1WI+ANcTuPysyfCIHVUC9vKqb3b59Ule5q+Q8FrB0DNIg/KExaZt+YTo8UqmYI4H0xFPnVn3+PN36cRTxMOn8InpWrFhc+m1hJQ7oNeK8qCxqNjxK5Y+w5pvX8m6VcJj/ee7+AOnnVqND3ulvYP1ctCwKLs2frVwW8vsmw4wHIiUnmvWu11XMcPdrnwXfu+WPa6bM7xH/G19ry/kOtb9ECxE2ZJzNDyOeE5HIg== X-YMail-OSG: B20biegVM1m4M_E0_N8TgVHgJZVXgPEFW.EPK7OG2ck_G.8tS3APhCpKfINB4BR iNfxePBW22b.pAV8RV1jE61zJLRWwLB3fgxSkSA3Rua3bGZnezUxc4ThKkm8_JhG8e.ZYztgiHEE 1qqvfCsm7bq4A_bfai3i.SvQ4q7donDdGwRd828_V2j7ZrSlaR40tFc_7gbM8lD1APqJKYkKyTXj 0JRG9_vxgj.4mYuY2X_BJwa.x93P553TsyJ2Hw_0V3v0Ihg_OkcIcXi4Y3SL0wSOFAVDJlXIx0qz U6RRgk6fRIftJZD4MpOYVSI7QulxWb3VTQLEBJWG8VQs_jw7toL9ncE2U6CyZOvnH6f_3SidGIe9 XscUkOMgCZTuA0CN5_3G46qA1yiga9Bwl0G7Qrjg3WTIeQk0g6HLUJmhNbCvmTaNtVxLMNCwh4UM UNm1dQYPR.U83X_zGHeJJ9xRLd2ZVT6EviMeXoFo2yNDzzKXVk0irlzxLRvlDajnnOG_oemKpdae DsHjdAKn2yKa57WN3k_nf5nMQ2BalpXLiS8lcNHekwWbK3mmAqx37oJtNkqKlMTc2Uhx6YHWRY8o efxOgBKhF.VRc9lOJHgDKRfzZ9bB0qvMQyy_JOouP5kFc_CMwZUtvDBmmLo7PT90VeududwI80fx UDd06PbEwkVUOZDAFs9EyDyMzRtlTsaDhkuFqLwpXoDGzoiZbfecZ8BmV2ss1sb5URIeP9gS51Ul p76kAClPUP4iWVjq5C5lZYe5PH4NCBPsp72b9NK1N5XI_XxIRdVqgrSOHrAivwBMnNEEDr3uLc2M bpO8DcFlT71UqgJC9euVBqY4PVQdYd2W4s9RWkJZJNcjlGZZYR7_.hnwJB8oDS3aXbM2Lxd5tvXQ 9Tw2TZ7zlxIrp_9qWZucCRWsYpyoonZ8Ko9CkpUqASOXQZSJLG1Ai3SzsZFqFywFlYYTAKsLGAVO Bw8Lji5QlOKmuuaXA368eSzt9kitbpy7H8GMa8YlGlVGW8CUQQ.b5HeiJFSx2C7Go6nQ2Ujj4c48 2hQGvVxHXZ8NLawhIcz_onMH628gjjkxzhlpet_aEGNUNjuFv8FfB8hSJJtqqY_0GSrCqHHR0M3G JtI1ypRF6ty4mk7Upkv2Zpo_8WbR1Tttni5Ag_kPlY00Fo8tH2Vy6VjIvb6znRvwc7fIcUXWjctK TRXqOngvpIZTl4BWVHXurAUgq._bS0YWASxuqm5j1V0eDQCEfelSC4.M7hZcGewWyrtkpmfce7jL X2Vq08vfQhuN69egjkJdXEz7p7FTlK8docrjeVJ_iu2YRyFPHa.f0sfd8Wu.XsIGRsSxI3WLVvc3 yk4h.0whU4e2n15r7JooWOIwB6BVBEiEiQYiW2erV8aiHw2y_Ny1xokZRboUFNw7hBE6oG8MhdvW XxmhINjJZsov012WaqUMI7gcnd03au52YBg5lX177k9pGsXBo53UNaO_oTjGm._paLVpKV0jNlmP NIzKrwSbujZrIJliKbFU.PxRErl3v.sD0ytrNWl7TpW5u2TMf1p7eh5J_CMv_FfZix9vkNpAyPY6 jwglvLaJAEWlwT6Fli1.bX3JfuHt7tF.2bx4kflHRAQOk55f7aDfuE.w_0VSb3IeQo9uLfSuT2ZM NVkIJ6Dx5OgIzNhqlnXYQLVySZpoAucJATkeDpDNYmj9IRUTTuDdijGUEh7b5tcKxrxL7Mi8_xMl K6TulRyRn3933ydvBnQ7QX605_jM0NVsBQ563lwZvm.UR.BweH2IcqWANrC6_ME7rCIZ.rneMCB0 kCqjJhqlxzUqDWRudre5WfFCYIdizhMtoDGS_KJcAKsFKQBsZv2LWhUhIODE3KMSwew73dSJ1r0S 4ZXyLKxwjfoVGm8Xxl8NJuV0_dJ1WU4yCLVied4OB0Vu0SG3jVilMxzjRHmlrX2vgLlLR8Q6u8kw gvyJ3tdP_QVt2zrMGyVC9QbWz8rEdDhKNDsGgjcFTnJmpRIu.h7C.5JRmBRLAgzV3JxK4iywNf7r nbt4jia3is41lqIZ.j1WZ_bhr4qJhi0WDaEr5brB.p__FT1jcyY1k8KUbSvlWFWd99Dn0nAgY65V KYkaie6JQ0DvkwQsVYEVGqH.5h7xDE5NDf6OrorVqjRgGCIPqZ2jJGRveUxj_ahe9nooHR8ad.E6 x8X.5VUsTTN8W.L.Fj0P7fVPxS2j7cOdGLJCpyKISGHgZdQm7LB4uQwaVJDYBLkPXo9rRhrab0gP 6_KHg3VKhh8Qa0do8eQFV4m3ArFa5ug5MwjlzaRUd X-Sonic-MF: X-Sonic-ID: d6e338b6-534f-401f-a6d0-d7bde3049c82 Message-ID: <60f1e89b-f0a7-41b8-a9b2-e0ae97b69b36@netscape.net> Date: Sun, 2 Aug 2026 01:20:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] xen/igd: fixes for Intel IGD passthrough To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Tomita Moeko References: <20260801001737.16509-1-brchuckz.ref@aol.com> <20260801001737.16509-1-brchuckz@aol.com> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20260801001737.16509-1-brchuckz@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.26215 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 539 X-purgate-ID: tlsNG-720697/1785648071-F2EB32AC-7212A09B/0/0 X-purgate-type: clean X-purgate-size: 555 On 7/31/26 8:17 PM, Chuck Zmudzinski wrote: > Please note that Patch 5 of this series also requires a patch > to hvmloader of Xen for the new support to take effect that > is available here: > > https://lore.kernel.org/qemu-devel/20260801000354.16446-1-brchuckz@aol.com/ > The patch to hvmloader of Xen that is required for the new support added in Patch 5 of this patchset to take effect has been updated to version 2 and is available here: https://lore.kernel.org/qemu-devel/20260802050824.10554-1-brchuckz@aol.com/ Thanks, Chuck From xen-devel-bounces@lists.xenproject.org Sun Aug 02 05:26:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 05:26:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380505.1624295 (Exim 4.92) (envelope-from ) id 1wqOil-0006Tq-7b; Sun, 02 Aug 2026 05:26:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380505.1624295; Sun, 02 Aug 2026 05:26:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqOil-0006Tj-4d; Sun, 02 Aug 2026 05:26:47 +0000 Received: by outflank-mailman (input) for mailman id 1380505; Sun, 02 Aug 2026 05:26:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqOij-0006Td-GQ for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 05:26:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqOii-0016Gv-PJ for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 07:26:44 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6ed4fc-2eae-0a2a0a5409dd-0a2a45099800-12 for ; Sun, 02 Aug 2026 07:26:44 +0200 Received: from [98.137.68.204] (helo=sonic304-23.consmr.mail.gq1.yahoo.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6ed512-be1a-0a2a45090019-628944ccb192-3 for ; Sun, 02 Aug 2026 07:26:44 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Sun, 2 Aug 2026 05:26:42 +0000 Received: by hermes--production-ne1-6f6bdbdd7c-dvlsw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 11499ee497b205444310b641ae38b9f1; Sun, 02 Aug 2026 05:26:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=netscape.net header.i="@netscape.net" header.h="Date:Subject:To:Cc:References:From:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1785648402; bh=LH/ftC7GkUWQq6FB6XQBny4DcVZLjeM6/HaeFg9bv3w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=Yah76xINiQI8Aa5SpWbJzbbV8erP/BHCmrBwMDQXSzEc7PeE2PEnVpsAOQfTCNRFRH4wCbkqgbQwZvmVX//B9xURciuDHjCwLUrgXK3YdfR/RGmvWRcHZxP8vxfUmrFfbabWwuE9nACL5iZbREkYmoOitTQkYoxGVKo2FrLGPUM2wjk3f9JaTP6IjE0T4SmD2VKwrdyS0p4khaKvIDPstYPu2IrefrijQBWe/CeB2RrmocuhP/ksBoV5HCexU7Qsiow54+gCOHzMz6YjUrTFOvd+oGPxAkafQldFBBFEWrWj6KkISpPvqEtORDLXxt2mwGMJj+1kAapcE88Rl0UxzQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785648402; bh=MAFVCLLvA0klvEZcVA5etVjnRgqlL0lGl7k0CnhiFb3=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=nZk8q/7/fq/CD2AbOuARFOh3y0FI79kWvSlWMiRySvCh+pk07CQulJKMf9NCanDCKaXxzg1iK9MAeMftQ6A1YvkprwdaGFQVxRt77vA0tTC1xd6Z0wJyey1zowSDO5dtF0mpYkoZ4dw1NVAVBTH3idmmEvFDrE9uEQ98VBXwRkk6RCLmeFIX+wBqFRNm7Sr5OuTExy+rznYmCzsfUPoLpCI9O0dYsV/7HJmkidt9CK9FIcp7lyjiiQk3SV6vPiHRCBOJV2ctb5FVkpht34zhs7txDE6+GFzErfEgK5OcJka4YEkQiYxBGzw6Jx4CCY2pMzHFtFaYc6ONpa3BN3H4pA== X-YMail-OSG: IUYVv7QVM1ksrzGFnH34ZNa9tFKOa0UEiqQf8uWRUH518rC13_b5BhBg10Hv8aS FU.tLcrzA6dcAldNQwxkdReWoWUrWqmbk1yPxUno_wB92sn8NFLXp3rMXiUWrp.Jwr_wIk6a05ct mDVueUgAnXuOd_IHHGLcyuxG8BaGg29WaFAwd8Wt3CkCQYEb_46ks0Y3o34FB1NJtV.7yUAcgDLX hCuHV6LGD6.l6_fQrNVr.tLgfRWe20MPYRxtxEbwiKnHYsCmzxh2pD2y6W1YZdOCOE5WFNLV1tXg OgHQFfmIbAUSdURf6fjDV1u29yv8Af8OIj5tYTiLkYvFKe2aeseKsKDc4Qx41uyXaP60_JiQunqp PI8v_hSfVibZ65RTO5YM2DNm7dD9VWbl8ZZ5zM24Doiu.VQqNqrknB89wmYYN9AEOepTaefP7BeJ i6_AUqPY.te8V3OvI7OgXIYYXNNVKIQf_OsubclGSyXmUIAaMoJ7Kxm5xoxZNs1dq00pBSp9dV1C Jioq0Mg_HghYB6iJq5BzQ4GB3drAPwnUEJVSpxNKAbrMJj3HyF3s0gk_zGzA9y6etqbaIk9EfuSs uDeFvKVgxNrOnPCaFluN0lSKk6tC2srKBc5qoiU1.Gfx8jrT.wFa1plpNsOlEskrsm6tz.uogNR3 ZWpUGpoxscWgBPDOqtR5dt5cggZ49CLyV1S.JalcD_HNDbfio7JGD0BP_WuEGGQRsOPMWbNlCtjp 4mGDqg1iKqWpM.HuSOsbek4mDKfZHbLLWYQHNgXUDwliTzFgPPBg.nb2RpjhQ8yxe4NE06upj4S9 OHRhMyugeqIGPmdH6To0wIXdGZXZIC6FmFDDUPehbtL5Luv8I3VbuACP1GrWvxttds8S8dRGFrWj Yr4W0IPeqdVmVrsJbuUOdW8vyQNRNnSJf3cUn027m2vY0g6u9LzsgSmMbJz1MuaKj_LzXX_98uV. m8XbzpSkuvjkTtpLr9gRFbEYZKOqDVrk72YDuF43jSCWQ1pM1sbhL4Qc9J3sHxhai6IloRQLLTcP lAjshWJ0RWbBIl5U1ut2tM0_7jCj3Ci0jbW.3V9x648RDarmxbWK0s5OOcWbYD9cxur8vpv0mBnl 6LIt81l.a8261OM_S1o6Erh8yNzFcxNzrJsCkDEvPwqRadClrzzmCxEVywO2LFKoeItpWvxXGJkP sb1VgYRzAA_9o8rswI3I6utxqNbGhnUMmqBwwK0nWU52nqb2i5qvRNzKdhRJD2QmdXvdR4HSZLq_ pkpegqCUaixQSQdQwN8mH8zUzoaKvVEccrzU7KsUcIfpcwbzei0MWx3Mca5Su_3UzD5HS.aIte9Y aEXw1NEObI1Dt_EZ94wZIr4fwJcafoOkHCkgXa8yxbWFCA__17aHCSEbE9laLwrRkaYhJrObrOGE Q2Y10r7wfdxhOsQ4u0okTzplvnSLkHHrDu6wZlvTrpgsYodk3f3g48vteAorOOP73MRQBaQZovhR NnqXxc9lPAnu1Gooy.G3D2H.XSGPCGy748JEEfzKc8lZgc6UEeqBhRjQgUh8N6pZ3NZLD5j7qDCH uBggtT983z95bZb4v6X.l8NuEzgutHRNw_u0DsXWTlQunY9kDqjTh1Q25rlRiAdx0R23ZmZTd1yK paQSaX0Bgjj8QNdrNAF6f2voB4qew9AVALIel07ru7rRu9Px9gax0l39SDgQe2eGLfYkN8uOEyIB 94FcytGQAjyF1_fWNwAud5fn4Q785HkLI6r7mvydaXGFBs3afHf3bitJmpkOGDheEZ.rzcsKJ8uq tf86tKay6tUd4WAq9YOrBqwmrdVW1P8ndt4x9y4xZo07L5GUrfSpmbAfD7gEzjpxVOagIvPrmAF5 YenGnj51OQe0QuKcJSYvusVbtl7Dzpwd574bfqO77owdnoCZB7xtjgSawIiH.T62Cj85c4uA8co9 4qCCJqKCzRWERd8ZqghJFHomwUUzie0GEVfUpTeH73iiS_m5Iz9dmtsZTdaHiPTSq9q8s9eqgsn4 hxd9GMlkEwXQcpgNIkH0bThGhoVpg2XQCdJtKSskJmyY0XbLEdgSygX1fouKklBqT7.Q4UGfUPi1 8GHbAEsQ5wkAArOMjx0sG8.Pi.qToLk58dEMPasVQw_UbHZpNCNYBoqdtZRnwooll3GdaL3yNSko jG9BRCYlb4MJszbc84BKqpWBIXMO_HDNalw1T3yXH27DK8QODIvT4lmo_nTDlC0mNdq8Om0JBO19 zeMOgC1NLmMtsm9lr0mNgYCAFD7Iy.Ols2GQ0z.w2p.q4qMo- X-Sonic-MF: X-Sonic-ID: 9ef0d839-c41c-43b5-90aa-8784cfba1c62 Message-ID: <236b6db6-ddb2-4f60-935e-fcb153c1ab38@netscape.net> Date: Sun, 2 Aug 2026 01:26:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] xen/igd: implement support for extended VBT To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Tomita Moeko References: <20260801001737.16509-1-brchuckz@aol.com> <20260801001737.16509-6-brchuckz@aol.com> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20260801001737.16509-6-brchuckz@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.26215 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 389 X-purgate-ID: tlsNG-bad1c0/1785648404-BCCCF034-8C7A4A98/0/0 X-purgate-type: clean X-purgate-size: 403 On 7/31/26 8:17 PM, Chuck Zmudzinski wrote: > > The companion patch to hvmloader that is needed to make this patch take > effect is available here: > > https://lore.kernel.org/qemu-devel/20260801000354.16446-1-brchuckz@aol.com/ This patch has been update to version 2 and is available here: https://lore.kernel.org/qemu-devel/20260802050824.10554-1-brchuckz@aol.com/ Thanks, Chuck From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380622.1624358 (Exim 4.92) (envelope-from ) id 1wqVx7-0004Nq-HK; Sun, 02 Aug 2026 13:10:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380622.1624358; Sun, 02 Aug 2026 13:10:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVx7-0004ND-DE; Sun, 02 Aug 2026 13:10:05 +0000 Received: by outflank-mailman (input) for mailman id 1380622; Sun, 02 Aug 2026 13:10:03 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVx5-0003vX-AA for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVx4-004d7k-NN for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:02 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f417e-2eae-0a2a0a5409dd-0a2a4502c3a4-28 for ; Sun, 02 Aug 2026 15:10:02 +0200 Received: from [46.105.56.78] (helo=9.mo576.mail-out.ovh.net) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41a9-6ca4-0a2a45020019-2e69384ec885-3 for ; Sun, 02 Aug 2026 15:10:02 +0200 Received: from director9.ghost.mail-out.ovh.net (unknown [10.110.43.163]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 4hCgBx55Tjz5xWk for ; Sun, 2 Aug 2026 13:10:01 +0000 (UTC) Received: from ghost-submission-7d8d68f679-6sth2 (unknown [10.111.174.161]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id F1CB180F81; Sun, 2 Aug 2026 13:09:59 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.101]) by ghost-submission-7d8d68f679-6sth2 with ESMTPSA id ljuXJadBb2qpHhgAK5rK4A (envelope-from ); Sun, 02 Aug 2026 13:09:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-101G00462dcfbc5-c94d-471e-95e6-b257f1962b5d, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Ross Philipson , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Lukasz Hawrylko , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , trenchboot-devel@googlegroups.com Subject: [PATCH v4 06/23] x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap Date: Sun, 2 Aug 2026 16:09:22 +0300 Message-ID: <15fc3a65709a6f132018589891d2de1602267f75.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4731312883743139260 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTFZ8AtnZpIyl6ET+v3fHmA+uYUkMD3DwZB0P07GRr8J86P8aEK0TrIgvEmvMk2UMHLQcrPmKka+msSt/0TaecPfdcx6Ctkzl/IQTPxfVtaP4//uOPzb7zuNCMwkPc0Fz4/OS0qT7MhCIRPFyW6pdcu9LLnVzpKpLjrKi5cvgJCqGdBXnNZmrQH54omClw/hNP24rkF6xCI8byjkJYQhTq3hW/2iAafs5tP1aMfaMB2SAbmrJsBH59VjqPkxz7VyIrdiwsxnEq+nYIOXwOIC83XPRbw8D2/WH8A/IIXngJ3UMgzTCeGDTtAXEJQRbBSYtkkUlETXIFPtHwFUuu0Mcfe4o1t6vxp/IU/vmFieuOyt8qybimr01gORxexKfJyCbeB7Yj/gnZsdUmouEAFzAvi3Po41psvqOoUGIAR7HZljOzTxLBWaxuw6Gl256ZBmLwbe2LlX9tgJFSRrro8rR9ANq31dTUndUnLQ9FGyyqTouFBLjEtcgT6v3m390YbGEG3TC3h6a5YoykNHwLORe+lqMFyuiu2QHakD5u8uhYJoTGFUZSv1uuHQYfELt2y96i9FK4SHjvLNroQKG9NtYhmuPgD1CQ9Tb/Lw5v8H/nCyUyskvp3wqUMlhixD8KeR2TzB3R2YDjigaghEKoNwvyxrakoecd2NmZFUmpdU9IUCEw DKIM-Signature: a=rsa-sha256; bh=37ueSWxMjwvM39AlgHrUkrBrOhrpGYPMLbYZOxLndJg=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676201; v=1; b=k2XQD9wrIIJggfjdTty2IWYNP5q/KXJVHy+FRX85kFtXtUmJOlensOjWMyAXWS9U6K65ZZPh SAAHGIMJ+fBY1HI3b6lo8ID2JOrjZHzh7O9X0RcfT3vjpBat0vrzZ8vdz2jMyJ+2gUIOSvKCu1R t11sSPD9uFQ0NRZZNllWxB7osBdUcMeEELHSvpKHfe2MbPfs97IyokpfLdTKLXsH9s3+xLfMjA2 Kzqghv1po+zrmsoPRKoOUq0lbKjPTJnQR1suZsmnsg+bxpASfl6ozXXn7RkfRnWST+g4E8YaXAm Vp4yhuyTiCYkpD5fSzmkooQQkSDsUdAgZ4f3mNGx9MsAw== X-purgate-ID: tlsNG-720697/1785676202-664B62AC-D71ACAD6/0/0 X-purgate-type: clean X-purgate-size: 11357 From: Krystian Hebel The file contains base address of TXT register spaces, offsets of registers within them, error codes and inline functions for accessing structures stored on TXT heap. xen/arch/x86/tboot.c is updated to use definitions from this new header instead of duplicating them. The change in tboot_protect_mem_regions() there is caused by going from NR_TXT_CONFIG_PAGES to TXT_CONFIG_SPACE_SIZE which avoids multiplying number of pages by page size on every use. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: removed unused SLAUNCH_ERROR_* #defines v4: __ASSEMBLY__ => __ASSEMBLER__ v4: added back halt() loop before unreachable() in txt_reset() as reset is apparently asynchronous v4: replaced txt_*_{start,size}() with an enumeration and txt_{start,size}() that iterate over entries v4: NR_TXT_CONFIG_SIZE => TXT_CONFIG_SPACE_SIZE in one place (this was renamed but one use remained unchanged) xen/arch/x86/include/asm/intel-txt.h | 250 +++++++++++++++++++++++++++ xen/arch/x86/tboot.c | 20 +-- 2 files changed, 252 insertions(+), 18 deletions(-) create mode 100644 xen/arch/x86/include/asm/intel-txt.h diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h new file mode 100644 index 0000000000..15d474f002 --- /dev/null +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -0,0 +1,250 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Intel TXT is an implementation of DRTM in CPUs made by Intel (although CPU + * alone isn't enough, chipset must support TXT as well). + * + * Overview: + * https://www.intel.com/content/www/us/en/support/articles/000025873/processors.html + * Software Development Guide (SDG): + * https://www.intel.com/content/www/us/en/content-details/315168/ + */ + +#ifndef X86_INTEL_TXT_H +#define X86_INTEL_TXT_H + +/* + * TXT configuration registers (offsets from TXT_{PUB, PRIV}_CONFIG_REGS_BASE) + */ +#define TXT_PUB_CONFIG_REGS_BASE 0xfed30000U +#define TXT_PRIV_CONFIG_REGS_BASE 0xfed20000U + +/* + * The same set of registers is exposed twice (with different permissions) and + * they are allocated continuously with page alignment. + */ +#define TXT_CONFIG_SPACE_SIZE \ + (TXT_PUB_CONFIG_REGS_BASE - TXT_PRIV_CONFIG_REGS_BASE) + +/* Offsets from pub/priv config space. */ +#define TXTCR_STS 0x0000 +#define TXTCR_ESTS 0x0008 +#define TXTCR_ERRORCODE 0x0030 +#define TXTCR_CMD_RESET 0x0038 +#define TXTCR_CMD_CLOSE_PRIVATE 0x0048 +#define TXTCR_DIDVID 0x0110 +#define TXTCR_VER_EMIF 0x0200 +#define TXTCR_CMD_UNLOCK_MEM_CONFIG 0x0218 +#define TXTCR_SINIT_BASE 0x0270 +#define TXTCR_SINIT_SIZE 0x0278 +#define TXTCR_MLE_JOIN 0x0290 +#define TXTCR_HEAP_BASE 0x0300 +#define TXTCR_HEAP_SIZE 0x0308 +#define TXTCR_SCRATCHPAD 0x0378 +#define TXTCR_CMD_OPEN_LOCALITY1 0x0380 +#define TXTCR_CMD_CLOSE_LOCALITY1 0x0388 +#define TXTCR_CMD_OPEN_LOCALITY2 0x0390 +#define TXTCR_CMD_CLOSE_LOCALITY2 0x0398 +#define TXTCR_CMD_SECRETS 0x08e0 +#define TXTCR_CMD_NO_SECRETS 0x08e8 +#define TXTCR_E2STS 0x08f0 + +/* + * Secure Launch Defined Error Codes used in MLE-initiated TXT resets. + * + * TXT Specification + * Appendix I ACM Error Codes + */ +#define SLAUNCH_ERROR_INTEGER_OVERFLOW 0xc0008001U +#define SLAUNCH_ERROR_HI_PMR_BASE 0xc0008002U +#define SLAUNCH_ERROR_LO_PMR_BASE 0xc0008003U +#define SLAUNCH_ERROR_LO_PMR_SIZE 0xc0008004U +#define SLAUNCH_ERROR_LO_PMR_MLE 0xc0008005U +#define SLAUNCH_ERROR_BUFFER_BEYOND_PMR 0xc0008006U +#define SLAUNCH_ERROR_HEAP_BAD_OS2MLE 0xc0008007U +#define SLAUNCH_ERROR_HEAP_BAD_OS2SINIT 0xc0008008U + +#ifndef __ASSEMBLER__ + +/* Need to differentiate between pre- and post paging enabled. */ +#ifdef __EARLY_SLAUNCH__ +#include +#define _txt(x) _p(x) +#else +#include +#include /* __va() */ +#define _txt(x) __va(x) +#endif + +/* + * Always use private space as some of registers are either read-only or not + * present in public space. + */ +static inline uint64_t txt_read(unsigned int reg_no) +{ + volatile uint64_t *reg = _txt(TXT_PRIV_CONFIG_REGS_BASE + reg_no); + return *reg; +} + +static inline void txt_write(unsigned int reg_no, uint64_t val) +{ + volatile uint64_t *reg = _txt(TXT_PRIV_CONFIG_REGS_BASE + reg_no); + *reg = val; +} + +static inline void noreturn txt_reset(uint32_t error) +{ + txt_write(TXTCR_ERRORCODE, error); + txt_write(TXTCR_CMD_NO_SECRETS, 1); + txt_write(TXTCR_CMD_UNLOCK_MEM_CONFIG, 1); + /* + * Ignoring the result as this serves as a TXT register barrier after + * writing to TXTCR_CMD_UNLOCK_MEM_CONFIG. Must be done to ensure that any + * future chipset operations see the write. + */ + txt_read(TXTCR_ESTS); + txt_write(TXTCR_CMD_RESET, 1); + + while (true) + { + /* + * This is halt() from . Can't include the file as it + * breaks early code compilation. + */ + asm volatile ( "hlt" : : : "memory" ); + } + unreachable(); +} + +/* + * Secure Launch defined OS/MLE TXT Heap table + */ +struct txt_os_mle_data { + uint32_t version; + uint32_t reserved; + uint64_t slrt; + uint64_t txt_info; + uint32_t ap_wake_block; + uint32_t ap_wake_block_size; + uint8_t mle_scratch[64]; +} __packed; + +/* + * TXT specification defined BIOS data TXT Heap table + */ +struct txt_bios_data { + uint32_t version; /* Currently 5 for TPM 1.2 and 6 for TPM 2.0 */ + uint32_t bios_sinit_size; + uint64_t reserved1; + uint64_t reserved2; + uint32_t num_logical_procs; + /* Versions >= 3 && < 5 */ + uint32_t sinit_flags; + /* Versions >= 5 with updates in version 6 */ + uint32_t mle_flags; + /* Versions >= 4 */ + /* Ext Data Elements */ +} __packed; + +/* + * TXT specification defined OS/SINIT TXT Heap table + */ +struct txt_os_sinit_data { + uint32_t version; /* Currently 6 for TPM 1.2 and 7 for TPM 2.0 */ + uint32_t flags; /* Reserved in version 6 */ + uint64_t mle_ptab; + uint64_t mle_size; + uint64_t mle_hdr_base; + uint64_t vtd_pmr_lo_base; + uint64_t vtd_pmr_lo_size; + uint64_t vtd_pmr_hi_base; + uint64_t vtd_pmr_hi_size; + uint64_t lcp_po_base; + uint64_t lcp_po_size; + uint32_t capabilities; + /* Version = 5 */ + uint64_t efi_rsdt_ptr; /* RSD*P* in versions >= 6 */ + /* Versions >= 6 */ + /* Ext Data Elements */ +} __packed; + +/* + * TXT specification defined SINIT/MLE TXT Heap table + */ +struct txt_sinit_mle_data { + uint32_t version; /* Current values are 6 through 9 */ + /* Versions <= 8, fields until lcp_policy_control must be 0 for >= 9 */ + uint8_t bios_acm_id[20]; + uint32_t edx_senter_flags; + uint64_t mseg_valid; + uint8_t sinit_hash[20]; + uint8_t mle_hash[20]; + uint8_t stm_hash[20]; + uint8_t lcp_policy_hash[20]; + uint32_t lcp_policy_control; + /* Versions >= 7 */ + uint32_t rlp_wakeup_addr; + uint32_t reserved; + uint32_t num_of_sinit_mdrs; + uint32_t sinit_mdrs_table_offset; + uint32_t sinit_vtd_dmar_table_size; + uint32_t sinit_vtd_dmar_table_offset; + /* Versions >= 8 */ + uint32_t processor_scrtm_status; + /* Versions >= 9 */ + /* Ext Data Elements */ +} __packed; + +/* + * Functions to extract data from the Intel TXT Heap Memory. + * + * The layout of the heap is dictated by TXT. It's a set of variable-sized + * tables that appear in pre-defined order: + * + * +------------------------------------+ + * | Size of Bios Data table (uint64_t) | + * +------------------------------------+ + * | Bios Data table | + * +------------------------------------+ + * | Size of OS MLE table (uint64_t) | + * +------------------------------------+ + * | OS MLE table | + * +-------------------------------- + + * | Size of OS SINIT table (uint64_t) | + * +------------------------------------+ + * | OS SINIT table | + * +------------------------------------+ + * | Size of SINIT MLE table (uint64_t) | + * +------------------------------------+ + * | SINIT MLE table | + * +------------------------------------+ + * + * NOTE: the table size fields include the 8 byte size field itself. + * + * NOTE: despite SDG mentioning 8-byte alignment, at least some BIOS ACM modules + * were observed to violate this requirement for Bios Data table, so not + * enforcing any alignment. + */ +enum { + TXT_BIOS, + TXT_OS2MLE, + TXT_OS2SINIT, + TXT_SINIT2MLE, +}; +static inline uint64_t txt_size(const void *heap, int table_index) +{ + int i; + for (i = 0; i < table_index; ++i) + heap += *(const uint64_t *)heap; + return *(const uint64_t *)heap - sizeof(uint64_t); +} +static inline void *txt_start(void *heap, int table_index) +{ + int i; + for (i = 0; i < table_index; ++i) + heap += *(const uint64_t *)heap; + return heap + sizeof(uint64_t); +} + +#endif /* !__ASSEMBLER__ */ + +#endif /* X86_INTEL_TXT_H */ diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index 5ae27f481f..e914177689 100644 --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -17,6 +17,7 @@ #include #include #include +#include #include @@ -37,23 +38,6 @@ static uint64_t __initdata sinit_base, __initdata sinit_size; static bool __ro_after_init is_vtd; -/* - * TXT configuration registers (offsets from TXT_{PUB, PRIV}_CONFIG_REGS_BASE) - */ - -#define TXT_PUB_CONFIG_REGS_BASE 0xfed30000U -#define TXT_PRIV_CONFIG_REGS_BASE 0xfed20000U - -/* # pages for each config regs space - used by fixmap */ -#define NR_TXT_CONFIG_PAGES ((TXT_PUB_CONFIG_REGS_BASE - \ - TXT_PRIV_CONFIG_REGS_BASE) >> PAGE_SHIFT) - -/* offsets from pub/priv config space */ -#define TXTCR_SINIT_BASE 0x0270 -#define TXTCR_SINIT_SIZE 0x0278 -#define TXTCR_HEAP_BASE 0x0300 -#define TXTCR_HEAP_SIZE 0x0308 - #define SHA1_SIZE 20 typedef uint8_t sha1_hash_t[SHA1_SIZE]; @@ -411,7 +395,7 @@ int __init tboot_protect_mem_regions(void) /* TXT Private Space */ rc = e820_change_range_type(&e820, TXT_PRIV_CONFIG_REGS_BASE, - TXT_PRIV_CONFIG_REGS_BASE + NR_TXT_CONFIG_PAGES * PAGE_SIZE, + TXT_PRIV_CONFIG_REGS_BASE + TXT_CONFIG_SPACE_SIZE, E820_RESERVED, E820_UNUSABLE); if ( !rc ) return 0; -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380619.1624340 (Exim 4.92) (envelope-from ) id 1wqVwz-0003Dr-TK; Sun, 02 Aug 2026 13:09:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380619.1624340; Sun, 02 Aug 2026 13:09:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVwz-0003Dk-Q7; Sun, 02 Aug 2026 13:09:57 +0000 Received: by outflank-mailman (input) for mailman id 1380619; Sun, 02 Aug 2026 13:09:56 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVwy-0003CL-Iy for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:09:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVwx-004d7k-W6 for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:09:56 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4195-2eae-0a2a0a5409dd-0a2a4507dfe0-20 for ; Sun, 02 Aug 2026 15:09:55 +0200 Received: from [188.165.52.147] (helo=8.mo560.mail-out.ovh.net) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41a3-b4ea-0a2a45070019-bca53493ae4b-3 for ; Sun, 02 Aug 2026 15:09:55 +0200 Received: from director5.ghost.mail-out.ovh.net (unknown [10.109.249.22]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 4hCgBp6RdjzB4vx for ; Sun, 2 Aug 2026 13:09:54 +0000 (UTC) Received: from ghost-submission-7d8d68f679-vd989 (unknown [10.110.178.131]) by director5.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 22D9610014F; Sun, 2 Aug 2026 13:09:53 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.114]) by ghost-submission-7d8d68f679-vd989 with ESMTPSA id TPz6M6FBb2qoXxsAp+IlDQ (envelope-from ); Sun, 02 Aug 2026 13:09:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-114S008a36bb849-095f-4e42-92f9-3b91a7ad8aa0, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Ross Philipson , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 04/23] x86/tpm.c: support extending PCRs of TPM2.0 via TIS Date: Sun, 2 Aug 2026 16:09:20 +0300 Message-ID: <037a0134f174f76a28754848446430eca1ad0e36.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4729342561658414524 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTFiq8m7bQTuMp+kHfkzWccLWGLiQDKFabJ2RhDT9kfSCdofJQR0IvQFrevpmIyB+jnOmWgMITL1LVlUdujF/88Dy35XfmsnynnsdO5Xa4QZ6Gc6PwZL/w0OaybZqkAliIuAt3zKOqs8qNDyeged1T+HCIn38vZ4164Thxki6LcZk2mWbVf0lh3liuwuFkaWODA5MvDecSoe9+O3Y32ZXF0UgxCi2WcxOeNMSvMwvsFTMPUzkDUeexFvnw7jvdCv07SWscXglPm5ceMWU9Pt/FCybH4TixDs6/CyEmv3wohSL4ZxKHESdLK6bja1pMVMnC16ZdsXken8EiAcdvwD4XzyXGPFS3hYmeie7FdIUOE5QWBGgI95OgiDchtHk8AWo+2oI3iXP1bWpFiBpfjFw7XkwiCcsmMpd5JGWoCTO9ln1V3GOHKQ+3v/z2vrxr5TrzGXksBG88OrnF3qxHU9gZMYG4ZmzXbhW0q3dbiWb5AmmlJ6n8+XBeXQQQU4mbTLv0c20a2oOwJeOt0yVTAPwWic/jlpb4N/4sGPhKDX4aV+uncP6S58hM+JhJpW4P+WYRRr5xuJuhw6Ek0eucXCSKTp/XsBh6keFof4XswHBt5G3VlzuLjEy6B003jcLtTOE3soSRxoEcrlmo98eKZ0n1wyCke1EXI7fxmj9C5SdoKVAQ DKIM-Signature: a=rsa-sha256; bh=q07hwwp6TmxzYBwgs2/61Pp5yrXD10YTmVaY8Lj0LRA=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676194; v=1; b=B1bFU+rM3wmZemXNRXx2RIohYao53dWNzs6q6/3wtafTHe3NHNX+J9csV299VomLkesyt2Zw chWnf94Gfs6/j1kG6/q50GbOPXhWAhlFYcmZPrGF7Ya63s/FR1+pi8AR+VJoLAeMB4BEF00/Llf GwfKT+3YX64sUB1yWyRBO4UtCKW+GMY20cL358rG4CZwWncgKC/ugvb7zyKEPuAFmisdaHTOYk7 fWe/TahHE+DxHI+6kT5NZHCAyfevLMKeKS0F2InKPBQ2HZ7PDWtLmCc5jCj7S21aJcI//YKyznn EQyjRxFePqfxKZWHyhZRfCOkLfZw+1DlKLOq4tRHFCElA== X-purgate-ID: tlsNG-ef75cf/1785676195-A6CDFAE4-5AFFB8EE/0/0 X-purgate-type: clean X-purgate-size: 18905 SHA1 and SHA256 are hard-coded here, but their support by the TPM is checked. CRB isn't supported, only TPM1.2-like TIS interface is (data is passed via writes and reads to/from a single-byte FIFO register). Signed-off-by: Sergii Dmytruk Signed-off-by: Szymon Acedański Assisted-by: Claude:claude-opus-4-6 Signed-off-by: Sergii Dmytruk --- Notes: v4: was called "x86/tpm.c: support extending PCRs of TPM2.0" v4: adds xen/arch/x86/include/asm/tpm2.h with TPM2.0 declarations by TCG v4: detect CRB and do nothing (implemented separately) v4: put SPDX license comment on its own line v4: `unsigned` => `unsigned int` v4: replace uses of `swap16()` and `swap32()` v4: more error checks when parsing TPM responses v4: style fixes for `goto` labels and spacing xen/arch/x86/include/asm/tpm.h | 5 + xen/arch/x86/include/asm/tpm2.h | 150 ++++++++++++++ xen/arch/x86/tpm.c | 340 +++++++++++++++++++++++++++++++- 3 files changed, 489 insertions(+), 6 deletions(-) create mode 100644 xen/arch/x86/include/asm/tpm2.h diff --git a/xen/arch/x86/include/asm/tpm.h b/xen/arch/x86/include/asm/tpm.h index 06b54fb786..5fa883dad8 100644 --- a/xen/arch/x86/include/asm/tpm.h +++ b/xen/arch/x86/include/asm/tpm.h @@ -57,6 +57,11 @@ bool tpm_is_tpm1(void); * The list of hashes must either be empty or contain nothing but SHA1 hash when * tpm_is_tpm1() returns true. * + * When tpm_is_tpm1() returns false, the list of digests can also be used to + * determine which hashes to extend. The only hashes that are guaranteed to be + * supported are SHA1 and SHA256, all other digests need to be pre-filled by + * the caller with some placeholder value. + * * Returns: * - TPM error code when < 4096 (0 means success) * - TPM_INTERNAL_ERROR on invalid invocation or a failure to communicate with diff --git a/xen/arch/x86/include/asm/tpm2.h b/xen/arch/x86/include/asm/tpm2.h new file mode 100644 index 0000000000..4565d302f3 --- /dev/null +++ b/xen/arch/x86/include/asm/tpm2.h @@ -0,0 +1,150 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * TPM2.0-related definitions defined by Trusted Computing Group (TCG). + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#ifndef X86_TPM2_H +#define X86_TPM2_H + +#include + +#include + +/* + * These constants are for TPM2.0 but don't have a distinct prefix to match + * names in the specification. + */ + +#define TPM_HT_PCR 0x00 + +#define TPM_RH_NULL 0x40000007 +#define TPM_RS_PW 0x40000009 + +#define HR_SHIFT 24 +#define HR_PCR (TPM_HT_PCR << HR_SHIFT) + +#define TPM_ST_NO_SESSIONS 0x8001 +#define TPM_ST_SESSIONS 0x8002 + +#define TPM2_PCR_Extend 0x00000182 +#define TPM2_PCR_HashSequenceStart 0x00000186 +#define TPM2_PCR_SequenceUpdate 0x0000015C +#define TPM2_PCR_EventSequenceComplete 0x00000185 + +/* All fields of the following structs are big endian. */ + +struct tpm2_session_header { + uint32_t handle; + uint16_t nonceSize; + uint8_t nonce[0]; + uint8_t attrs; + uint16_t hmacSize; + uint8_t hmac[0]; +} __packed; + +struct tpm2_extend_cmd { + struct tpm_cmd_hdr h; + uint32_t pcrHandle; + uint32_t sessionHdrSize; + struct tpm2_session_header pcrSession; + uint32_t hashCount; + uint8_t hashes[0]; +} __packed; + +struct tpm2_extend_rsp { + struct tpm_rsp_hdr h; +} __packed; + +struct tpm2_sequence_start_cmd { + struct tpm_cmd_hdr h; + uint16_t hmacSize; + uint8_t hmac[0]; + uint16_t hashAlg; +} __packed; + +struct tpm2_sequence_start_rsp { + struct tpm_rsp_hdr h; + uint32_t sequenceHandle; +} __packed; + +struct tpm2_sequence_update_cmd { + struct tpm_cmd_hdr h; + uint32_t sequenceHandle; + uint32_t sessionHdrSize; + struct tpm2_session_header session; + uint16_t dataSize; + uint8_t data[0]; +} __packed; + +struct tpm2_sequence_update_rsp { + struct tpm_rsp_hdr h; +} __packed; + +struct tpm2_sequence_complete_cmd { + struct tpm_cmd_hdr h; + uint32_t pcrHandle; + uint32_t sequenceHandle; + uint32_t sessionHdrSize; + struct tpm2_session_header pcrSession; + struct tpm2_session_header sequenceSession; + uint16_t dataSize; + uint8_t data[0]; +} __packed; + +struct tpm2_sequence_complete_rsp { + struct tpm_rsp_hdr h; + uint32_t paramSize; + uint32_t hashCount; + uint8_t hashes[0]; + /* + * Each hash is represented as: + * struct { + * uint16_t hashAlg; + * uint8_t hash[size of hashAlg]; + * }; + */ +} __packed; + +/* The structures below are for TPM event log and these are in little-endian. */ + +struct tpm2_pcr_event_header { + uint32_t pcrIndex; + uint32_t eventType; + uint32_t digestCount; + uint8_t digests[0]; + /* + * Each hash is represented as: + * struct { + * uint16_t hashAlg; + * uint8_t hash[size of hashAlg]; + * }; + */ + /* uint32_t eventSize; */ + /* uint8_t event[0]; */ +} __packed; + +struct tpm2_digest_sizes { + uint16_t algId; + uint16_t digestSize; +} __packed; + +struct tpm2_spec_id_event { + uint32_t pcrIndex; + uint32_t eventType; + uint8_t digest[20]; + uint32_t eventSize; + uint8_t signature[16]; + uint32_t platformClass; + uint8_t specVersionMinor; + uint8_t specVersionMajor; + uint8_t specErrata; + uint8_t uintnSize; + uint32_t digestCount; + struct tpm2_digest_sizes digestSizes[0]; /* variable number of members */ + /* uint8_t vendorInfoSize; */ + /* uint8_t vendorInfo[vendorInfoSize]; */ +} __packed; + +#endif /* X86_TPM2_H */ diff --git a/xen/arch/x86/tpm.c b/xen/arch/x86/tpm.c index 9efaf75440..59bb1ff2c4 100644 --- a/xen/arch/x86/tpm.c +++ b/xen/arch/x86/tpm.c @@ -12,11 +12,13 @@ #include #include +#include #include #include #include #include +#include #ifdef __EARLY_TPM__ @@ -75,6 +77,22 @@ static void tpm_write8(unsigned int reg, uint8_t val) *(volatile uint8_t *)__va(TPM_MMIO_BASE + reg) = val; } +/************************** Interface detection *******************************/ + +#define TPM_INTF_ID_(x) TPM_LOC_REG(x, 0x30) +#define INTF_TYPE_MASK 0x0000000fU +#define INTF_TYPE_TIS 0x00 +#define INTF_TYPE_CRB 0x01 + +/* + * No static caching: the early 32-bit binary (tpm_early.bin) is built with + * "objcopy -j .text", which omits .bss/.data. + */ +static bool tpm_is_crb(void) +{ + return (tpm_read32(TPM_INTF_ID_(0)) & INTF_TYPE_MASK) == INTF_TYPE_CRB; +} + /************************** TIS register definitions **************************/ #define TIS_ACCESS_(x) TPM_LOC_REG(x, 0x00) @@ -181,24 +199,37 @@ static void tis_send_cmd(unsigned int loc, uint8_t *buf, unsigned int i_size, static void request_locality(unsigned int loc) { - tis_request_locality(loc); + if ( tpm_is_crb() ) + return; + else + tis_request_locality(loc); } static void relinquish_locality(unsigned int loc) { - tis_relinquish_locality(loc); + if ( tpm_is_crb() ) + return; + else + tis_relinquish_locality(loc); } static void send_cmd(unsigned int loc, uint8_t *buf, unsigned int i_size, unsigned int *o_size) { - tis_send_cmd(loc, buf, i_size, o_size); + if ( tpm_is_crb() ) + *o_size = 0; + else + tis_send_cmd(loc, buf, i_size, o_size); } bool tpm_is_tpm1(void) { uint32_t intf_version; + /* CRB interface is always TPM 2.0. */ + if ( tpm_is_crb() ) + return false; + /* * If one of these conditions is true: * - INTF_CAPABILITY_x.interfaceVersion is 0 (TIS <= 1.21) @@ -211,14 +242,19 @@ bool tpm_is_tpm1(void) !(tpm_read32(TIS_STS_(0)) & STS_FAMILY_MASK)); } -/****************************** TPM1.2 specific *******************************/ +/****************************** TPM1.2 & TPM2.0 *******************************/ -#ifdef __EARLY_TPM__ /* * TPM1.2 is required to support commands of up to 1101 bytes, vendors rarely * go above that. Limit maximum size of block of data to be hashed to 1024. + * + * TPM2.0 should support hashing of at least 1024 bytes. */ #define MAX_HASH_BLOCK 1024 + +/****************************** TPM1.2 specific *******************************/ + +#ifdef __EARLY_TPM__ #define CMD_RSP_BUF_SIZE (sizeof(struct sha1_update_cmd) + MAX_HASH_BLOCK) union cmd_rsp { @@ -382,6 +418,298 @@ static uint32_t tpm12_hash_extend(unsigned int loc, const uint8_t *buf, /************************** end of TPM1.2 specific ****************************/ +/****************************** TPM2.0 specific *******************************/ + +#ifdef __EARLY_TPM__ + +union tpm2_cmd_rsp { + uint8_t b[sizeof(struct tpm2_sequence_update_cmd) + MAX_HASH_BLOCK]; + struct tpm_cmd_hdr c; + struct tpm_rsp_hdr r; + struct tpm2_sequence_start_cmd start_c; + struct tpm2_sequence_start_rsp start_r; + struct tpm2_sequence_update_cmd update_c; + struct tpm2_sequence_update_rsp update_r; + struct tpm2_sequence_complete_cmd finish_c; + struct tpm2_sequence_complete_rsp finish_r; +}; + +static uint32_t tpm2_hash_extend(unsigned int loc, const uint8_t *buf, + unsigned int size, unsigned int pcr, + const struct tpm_log_hashes *log_hashes) +{ + uint32_t seq_handle; + unsigned int max_bytes = MAX_HASH_BLOCK; + + union tpm2_cmd_rsp cmd_rsp; + unsigned int o_size; + unsigned int i; + uint8_t *p; + uint32_t rc; + + cmd_rsp.start_c = (struct tpm2_sequence_start_cmd) { + .h.tag = cpu_to_be16(TPM_ST_NO_SESSIONS), + .h.paramSize = cpu_to_be32(sizeof(cmd_rsp.start_c)), + .h.ordinal = cpu_to_be32(TPM2_PCR_HashSequenceStart), + /* Compute all supported hashes. */ + .hashAlg = cpu_to_be16(TPM_ALG_NULL), + }; + + request_locality(loc); + + o_size = sizeof(cmd_rsp); + send_cmd(loc, cmd_rsp.b, be32_to_cpu(cmd_rsp.c.paramSize), &o_size); + + if ( o_size < sizeof(struct tpm_rsp_hdr) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + rc = be32_to_cpu(cmd_rsp.r.returnCode); + if ( rc != 0 ) + goto error; + + seq_handle = be32_to_cpu(cmd_rsp.start_r.sequenceHandle); + + while ( size > 64 ) + { + if ( size < max_bytes ) + max_bytes = ROUNDDOWN(size, 64); + + cmd_rsp.update_c = (struct tpm2_sequence_update_cmd) { + .h.tag = cpu_to_be16(TPM_ST_SESSIONS), + .h.paramSize = cpu_to_be32(sizeof(cmd_rsp.update_c) + max_bytes), + .h.ordinal = cpu_to_be32(TPM2_PCR_SequenceUpdate), + .sequenceHandle = cpu_to_be32(seq_handle), + .sessionHdrSize = cpu_to_be32(sizeof(struct tpm2_session_header)), + .session.handle = cpu_to_be32(TPM_RS_PW), + .dataSize = cpu_to_be16(max_bytes), + }; + + memcpy(cmd_rsp.update_c.data, buf, max_bytes); + + o_size = sizeof(cmd_rsp); + send_cmd(loc, cmd_rsp.b, be32_to_cpu(cmd_rsp.c.paramSize), &o_size); + + if ( o_size < sizeof(struct tpm_rsp_hdr) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + rc = be32_to_cpu(cmd_rsp.r.returnCode); + if ( rc != 0 ) + goto error; + + size -= max_bytes; + buf += max_bytes; + } + + cmd_rsp.finish_c = (struct tpm2_sequence_complete_cmd) { + .h.tag = cpu_to_be16(TPM_ST_SESSIONS), + .h.paramSize = cpu_to_be32(sizeof(cmd_rsp.finish_c) + size), + .h.ordinal = cpu_to_be32(TPM2_PCR_EventSequenceComplete), + .pcrHandle = cpu_to_be32(HR_PCR + pcr), + .sequenceHandle = cpu_to_be32(seq_handle), + .sessionHdrSize = cpu_to_be32(sizeof(struct tpm2_session_header) * 2), + .pcrSession.handle = cpu_to_be32(TPM_RS_PW), + .sequenceSession.handle = cpu_to_be32(TPM_RS_PW), + .dataSize = cpu_to_be16(size), + }; + + memcpy(cmd_rsp.finish_c.data, buf, size); + + o_size = sizeof(cmd_rsp); + send_cmd(loc, cmd_rsp.b, be32_to_cpu(cmd_rsp.c.paramSize), &o_size); + + if ( o_size < sizeof(struct tpm_rsp_hdr) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + rc = be32_to_cpu(cmd_rsp.r.returnCode); + if ( rc != 0 ) + goto error; + + if ( o_size < sizeof(cmd_rsp.finish_r) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + + p = cmd_rsp.finish_r.hashes; + for ( i = 0; i < be32_to_cpu(cmd_rsp.finish_r.hashCount); ++i ) + { + unsigned int j; + uint16_t hash_type; + + if ( p + sizeof(uint16_t) > cmd_rsp.b + o_size ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + hash_type = be16_to_cpu(*(uint16_t *)p); + p += sizeof(uint16_t); + + for ( j = 0; j < log_hashes->count; ++j ) + { + const struct tpm_log_hash *hash = &log_hashes->hashes[j]; + if ( hash->alg == hash_type ) + { + if ( p + hash->size > cmd_rsp.b + o_size ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + memcpy(hash->data, p, hash->size); + p += hash->size; + break; + } + } + + if ( j == log_hashes->count ) + /* Can't continue parsing without knowing hash size. */ + break; + } + + rc = 0; + + error: + relinquish_locality(loc); + return rc; +} + +#else + +union tpm2_cmd_rsp { + /* Enough space for multiple hashes. */ + uint8_t b[sizeof(struct tpm2_extend_cmd) + 1024]; + struct tpm_cmd_hdr c; + struct tpm_rsp_hdr r; + struct tpm2_extend_cmd extend_c; + struct tpm2_extend_rsp extend_r; +}; + +static uint32_t tpm20_pcr_extend(unsigned int loc, uint32_t pcr_handle, + const struct tpm_log_hashes *log_hashes) +{ + union tpm2_cmd_rsp cmd_rsp; + unsigned int o_size; + unsigned int i; + uint8_t *p; + + cmd_rsp.extend_c = (struct tpm2_extend_cmd) { + .h.tag = cpu_to_be16(TPM_ST_SESSIONS), + .h.ordinal = cpu_to_be32(TPM2_PCR_Extend), + .pcrHandle = cpu_to_be32(pcr_handle), + .sessionHdrSize = cpu_to_be32(sizeof(struct tpm2_session_header)), + .pcrSession.handle = cpu_to_be32(TPM_RS_PW), + .hashCount = cpu_to_be32(log_hashes->count), + }; + + p = cmd_rsp.extend_c.hashes; + for ( i = 0; i < log_hashes->count; ++i ) + { + const struct tpm_log_hash *hash = &log_hashes->hashes[i]; + + if ( p + sizeof(uint16_t) + hash->size > &cmd_rsp.b[sizeof(cmd_rsp)] ) + { + printk(XENLOG_ERR "Hit TPM message size implementation limit: %ld\n", + sizeof(cmd_rsp)); + return TPM_INTERNAL_ERROR; + } + + *(uint16_t *)p = cpu_to_be16(hash->alg); + p += sizeof(uint16_t); + + memcpy(p, hash->data, hash->size); + p += hash->size; + } + + /* Fill in command size (size of the whole buffer). */ + cmd_rsp.c.paramSize = cpu_to_be32(sizeof(cmd_rsp.extend_c) + + (p - cmd_rsp.extend_c.hashes)); + + o_size = sizeof(cmd_rsp); + send_cmd(loc, cmd_rsp.b, be32_to_cpu(cmd_rsp.c.paramSize), &o_size); + + return be32_to_cpu(cmd_rsp.r.returnCode); +} + +static bool tpm2_supports_hash(unsigned int loc, + const struct tpm_log_hash *hash) +{ + uint32_t rc; + struct tpm_log_hashes hashes = { + .count = 1, + .hashes[0] = *hash, + }; + + /* + * This is a valid way of checking hash support, using it to not implement + * TPM2_GetCapability(). + */ + rc = tpm20_pcr_extend(loc, /*pcr_handle=*/TPM_RH_NULL, &hashes); + + return rc == 0; +} + +static uint32_t tpm2_hash_extend(unsigned int loc, const uint8_t *buf, + unsigned int size, unsigned int pcr, + const struct tpm_log_hashes *log_hashes) +{ + uint32_t rc; + unsigned int i; + struct tpm_log_hashes supported_hashes = {0}; + + request_locality(loc); + + for ( i = 0; i < log_hashes->count; ++i ) + { + const struct tpm_log_hash *hash = &log_hashes->hashes[i]; + if ( !tpm2_supports_hash(loc, hash) ) + { + printk(XENLOG_WARNING "Skipped hash unsupported by TPM: %d\n", + hash->alg); + continue; + } + + if ( hash->alg == TPM_ALG_SHA1 ) + { + sha1(hash->data, buf, size); + } + else if ( hash->alg == TPM_ALG_SHA256 ) + { + sha2_256(hash->data, buf, size); + } + else + { + /* + * Assuming the caller has initialized the digest with some + * pattern. + */ + } + + if ( supported_hashes.count == MAX_TPM_HASH_COUNT ) + { + printk(XENLOG_ERR "Hit hash count implementation limit: %d\n", + MAX_TPM_HASH_COUNT); + return TPM_INTERNAL_ERROR; + } + + supported_hashes.hashes[supported_hashes.count] = *hash; + ++supported_hashes.count; + } + + rc = tpm20_pcr_extend(loc, HR_PCR + pcr, &supported_hashes); + relinquish_locality(loc); + + return rc; +} + +#endif /* __EARLY_TPM__ */ + +/************************** end of TPM2.0 specific ****************************/ + uint32_t tpm_hash_extend(unsigned int loc, unsigned int pcr, const uint8_t *buf, unsigned int size, const struct tpm_log_hashes *log_hashes) @@ -402,5 +730,5 @@ uint32_t tpm_hash_extend(unsigned int loc, unsigned int pcr, const uint8_t *buf, return tpm12_hash_extend(loc, buf, size, pcr, log_hashes); } - return TPM_INTERNAL_ERROR; + return tpm2_hash_extend(loc, buf, size, pcr, log_hashes); } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380617.1624318 (Exim 4.92) (envelope-from ) id 1wqVwu-0002bT-BN; Sun, 02 Aug 2026 13:09:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380617.1624318; Sun, 02 Aug 2026 13:09:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVwu-0002ah-7a; Sun, 02 Aug 2026 13:09:52 +0000 Received: by outflank-mailman (input) for mailman id 1380617; Sun, 02 Aug 2026 13:09:51 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVws-0002Lt-W5 for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:09:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVws-001l71-1i for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:09:50 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4184-e002-0a2a0a5209dd-0a2a4509b098-12 for ; Sun, 02 Aug 2026 15:09:49 +0200 Received: from [46.105.40.108] (helo=3.mo583.mail-out.ovh.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f419d-be1a-0a2a45090019-2e69286cbf7b-3 for ; Sun, 02 Aug 2026 15:09:49 +0200 Received: from director11.ghost.mail-out.ovh.net (unknown [10.110.37.89]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 4hCgBj0K6Wz5yKg for ; Sun, 2 Aug 2026 13:09:48 +0000 (UTC) Received: from ghost-submission-7d8d68f679-94gmt (unknown [10.110.113.120]) by director11.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 5580EC28DA; Sun, 2 Aug 2026 13:09:48 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.101]) by ghost-submission-7d8d68f679-94gmt with ESMTPSA id NPxXBZxBb2p7shoA8/69sg (envelope-from ); Sun, 02 Aug 2026 13:09:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-101G004d28b9708-d722-46a0-b753-19657ed76a3a, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 02/23] x86/cpu: report SMX, TXT and SKINIT capabilities Date: Sun, 2 Aug 2026 16:09:18 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4727653710698587580 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEO37Lm1soAj3J6HJwxZueJ91jNrKiCMD9VOxO+7S6oZcwX5ZhHy/rf+u1q3gsSFBR0MQ0G/W66mTSt5xumJoxY/EyDpxdVBT5aAA1fHupbW88f/IumzeClwwf3PGe5NCfIC4rAkaw9D49zl0L3FOqYw1yebY9XQZPEoEgqOhxU7iAITzoi4rSZJugXTxFrfgz5z3QYtYzrLSr0w464iDE2Jv+mfsQyDLbPqlC9XEGpFu9KBxFx07+KPXWsR6kr02Tgk2fJ3ulvjdiKijPJd2EPMcqID96OcOqj/uCF/V+6MYDFkW6NlVR5eWMFf+caoPBoCiQxHguJ/BWn2Nt+/d7LNllcVQgdmgcry5NN7wS+7P244IVm1i3hxWTS0fY6l0mLmTrBdYMSj1l2MPXzfgrzKe+RwmeSG1PQWIXYbI81FBT96hhatZiup856cK5HOUf8jO43hH6Pam7Rb/cvxoRnQ189n0TR2SsNPS1cxZSJfG85p4aqQ61kgp59XqEL9nYtCPpVz0amvbk20nzSS6OIulbeXySnAFJAzehqeShpvFZ5FI2mFTvLc/rxG5Lgqfv02DJJ+HsLt4SETJwrMLt0L/KbPvgMIWS5lQQmVLxOofSfw0XSP0l/0tqgdtE0POhVRwEKgTJ54tR66Y6E2i0sC1FqUKF8QYD5nMk8jkj9JQ DKIM-Signature: a=rsa-sha256; bh=guK4ex2HH/E4mH457QyNnqirM8tblzphlMNWG1MrUQs=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676189; v=1; b=ad4fknva8ekoVibK/O1uF7vEnWMXYQS4A8+qPP4vzp/vKVYUudVIhuUQzYx1wxUsjQxy+vQg YbweWI0bsr05oWQ5Mfk8c03cDWsdhZmJapciYcaRneWnNcgESaKlreYlH/yS+vuWxwrTo8un1br +LXKI7Z0LaSJj49ZGr1ZhpezOPzRYZrzo3BdoIh93I3wGjlzRtZfTLEvQ1TifMy0RxI2XM+PTgV FZvdGLFSwnjGeO9+yOVffVjzCibhxeoDboO8n/jkrX/VsjqsM/4XRuL2cYJyQIXbbqgIT/rslYE 4DKxlImaRh8A09Qn5wTAQuU+P8v05sEJEHuUtF9tAwghQ== X-purgate-ID: tlsNG-bad1c0/1785676189-FC817034-625FF1C6/0/0 X-purgate-type: clean X-purgate-size: 5038 From: Michał Żygowski Report TXT capabilities so that dom0 can query the Intel TXT or AMD SKINIT support information using xl dmesg. Signed-off-by: Michał Żygowski Signed-off-by: Sergii Dmytruk --- Notes: v4: fixed conditions for not reporting capabilities (match correct comments) v4: define GETSEC_* macros used only by xen/arch/x86/cpu/intel.c in the file itself (to not depend on Slaunch) v4: don't postpone restoring state of X86_CR4_SMXE, do it before printing test results xen/arch/x86/cpu/amd.c | 16 +++++++++++++ xen/arch/x86/cpu/cpu.h | 1 + xen/arch/x86/cpu/hygon.c | 1 + xen/arch/x86/cpu/intel.c | 50 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 68 insertions(+) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 70783c9a0a..5ea16ad8a8 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -617,6 +617,21 @@ void amd_process_freq(const struct cpuinfo_x86 *c, *low_mhz = amd_parse_freq(c->family, lo); } +void amd_log_skinit(const struct cpuinfo_x86 *c) +{ + /* + * Run only on BSP and not during resume to report the capability only once. + */ + if ( system_state == SYS_STATE_resume || smp_processor_id() ) + return; + + printk("CPU: SKINIT capability "); + if ( !test_bit(X86_FEATURE_SKINIT, &boot_cpu_data.x86_capability) ) + printk("not supported\n"); + else + printk("supported\n"); +} + void cf_check early_init_amd(struct cpuinfo_x86 *c) { if (c == &boot_cpu_data) @@ -1325,6 +1340,7 @@ static void cf_check init_amd(struct cpuinfo_x86 *c) setup_force_cpu_cap(X86_FEATURE_XEN_REP_MOVSB); amd_log_freq(c); + amd_log_skinit(c); } const struct cpu_dev __initconst_cf_clobber amd_cpu_dev = { diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h index bbede57ab0..17935190b7 100644 --- a/xen/arch/x86/cpu/cpu.h +++ b/xen/arch/x86/cpu/cpu.h @@ -21,6 +21,7 @@ extern bool detect_extended_topology(struct cpuinfo_x86 *c); void cf_check early_init_amd(struct cpuinfo_x86 *c); void amd_log_freq(const struct cpuinfo_x86 *c); +void amd_log_skinit(const struct cpuinfo_x86 *c); void amd_init_de_cfg(const struct cpuinfo_x86 *c); void amd_init_lfence_dispatch(void); void amd_init_ssbd(const struct cpuinfo_x86 *c); diff --git a/xen/arch/x86/cpu/hygon.c b/xen/arch/x86/cpu/hygon.c index 7a9fc25d31..608a7c4319 100644 --- a/xen/arch/x86/cpu/hygon.c +++ b/xen/arch/x86/cpu/hygon.c @@ -90,6 +90,7 @@ static void cf_check init_hygon(struct cpuinfo_x86 *c) } amd_log_freq(c); + amd_log_skinit(c); } const struct cpu_dev __initconst_cf_clobber hygon_cpu_dev = { diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c index 90c9d36186..ddb34c0c02 100644 --- a/xen/arch/x86/cpu/intel.c +++ b/xen/arch/x86/cpu/intel.c @@ -14,6 +14,11 @@ #include "cpu.h" +/* EAX value for GETSEC leaf functions. Intel SDM: GETSEC[CAPABILITIES] */ +#define GETSEC_CAPABILITIES 0 +/* Intel SDM: GETSEC Capability Result Encoding */ +#define GETSEC_CAP_TXT_CHIPSET 1 + /* * MSR_MCU_OPT_CTRL is a collection of unrelated functionality, with separate * enablement requirements, but which want to be consistent across the system. @@ -620,6 +625,49 @@ static void init_intel_perf(struct cpuinfo_x86 *c) } } +/* + * Print out the SMX and TXT capabilties, so that dom0 can determine if the + * system is DRTM-capable. + */ +static void intel_log_smx_txt(void) +{ + unsigned long cr4_val, getsec_caps; + + /* + * Run only on BSP and not during resume to report the capability only once. + */ + if ( system_state == SYS_STATE_resume || smp_processor_id() ) + return; + + printk("CPU: SMX capability "); + if ( !test_bit(X86_FEATURE_SMX, &boot_cpu_data.x86_capability) ) + { + printk("not supported\n"); + return; + } + printk("supported\n"); + + /* Can't run GETSEC without VMX and SMX */ + if ( !test_bit(X86_FEATURE_VMX, &boot_cpu_data.x86_capability) ) + return; + + cr4_val = read_cr4(); + if ( !(cr4_val & X86_CR4_SMXE) ) + write_cr4(cr4_val | X86_CR4_SMXE); + + asm volatile ("getsec\n" + : "=a" (getsec_caps) + : "a" (GETSEC_CAPABILITIES), "b" (0) :); + + if ( !(cr4_val & X86_CR4_SMXE) ) + write_cr4(cr4_val & ~X86_CR4_SMXE); + + if ( getsec_caps & GETSEC_CAP_TXT_CHIPSET ) + printk("Chipset supports TXT\n"); + else + printk("Chipset does not support TXT\n"); +} + static void cf_check init_intel(struct cpuinfo_x86 *c) { /* Detect the extended topology information if available */ @@ -634,6 +682,8 @@ static void cf_check init_intel(struct cpuinfo_x86 *c) detect_ht(c); } + intel_log_smx_txt(); + /* Work around errata */ Intel_errata_workarounds(c); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380620.1624349 (Exim 4.92) (envelope-from ) id 1wqVx3-0003Ux-A0; Sun, 02 Aug 2026 13:10:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380620.1624349; Sun, 02 Aug 2026 13:10:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVx3-0003Un-5Q; Sun, 02 Aug 2026 13:10:01 +0000 Received: by outflank-mailman (input) for mailman id 1380620; Sun, 02 Aug 2026 13:09:59 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVx1-0003SZ-OU for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:09:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVx1-004d7k-5L for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:09:59 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4195-2eae-0a2a0a5409dd-0a2a4507dfe0-26 for ; Sun, 02 Aug 2026 15:09:58 +0200 Received: from [188.165.39.161] (helo=15.mo582.mail-out.ovh.net) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41a6-b4ea-0a2a45070019-bca527a1b141-3 for ; Sun, 02 Aug 2026 15:09:58 +0200 Received: from director5.ghost.mail-out.ovh.net (unknown [10.110.43.253]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 4hCgBs6hNwz5xnH for ; Sun, 2 Aug 2026 13:09:57 +0000 (UTC) Received: from ghost-submission-7d8d68f679-z8rfb (unknown [10.110.178.126]) by director5.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 115A5100161; Sun, 2 Aug 2026 13:09:57 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.95]) by ghost-submission-7d8d68f679-z8rfb with ESMTPSA id 5ylFN6RBb2rsZRYAaLQSgA (envelope-from ); Sun, 02 Aug 2026 13:09:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-95G0018acbab62-8b0a-4aab-827c-72b2fa275ecb, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Ross Philipson , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 05/23] x86/tpm.c: add CRB interface support Date: Sun, 2 Aug 2026 16:09:21 +0300 Message-ID: <5d71b306b8b6162cc434e8bfe16ed5dd1da068e8.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4730186985154487740 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEO37Lm1soAj3J6HJwxZueJ91jNrKiCMD9VOxO+7S6oZcwX5ZhHy/rf+u1q3gsSFBR0MQ0G/W66mTSt5xumJoxY/EyDpxdVBT5aAA1fHupbW88f/IumzeClwwf3PGe5NCfIC4rAkaw9D49zl0L3FOqYw1yebY9XQZPEoEgqOhxU7iAITzoi4rSZJugXTxFrfgz5z3QYtYzrLSr0w464iDE2Jv+mfsQyDLbPqlC9XEGpFu9KBxFx07+KPXWsR6kr02Tgk2fJ3ulvjdiKijPJd2EPMcqID96OcOqj/uCF/V+6MYDFkW6NlVR5eWMFf+caoPBoCiQxHguJ/BWn2Nt+/d7LIegd+W1HbJziGmUkNlCXhtzzh8HFSxQegASwemNchOJ3BdFA6NU/4EVQ6NTYL5e7Ey8YL1XyK6rItWnm1ifNg8olZjXM/sdiZFU7hWXSnAcleF0ugP7hWh9YMLoZKt3VU86pK5q81+ombrJ7OPetYH7fY+t3rbw/Jhf5Wv83Om4S1dmHgmtZqwbsUU0WOuoZka2cCqGYKQj95R7eLHEadAPWPErFtoSxe/DqQGlVxCkTNJxPW54bS6YywVOBrLhPp0WqOjYusmxpja7d2qS6Qz9xPDhxddyzZbWfAChxAYyfYUwcPOMXOM9M4msoqRwjdLhCFiFXeInLQDMwBhZoJg DKIM-Signature: a=rsa-sha256; bh=BhGw1vM0t4hYsGT8oICAVoewzT6l4ZY+UO8jUoK1vZ0=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676198; v=1; b=Fj/EKOsqTK9/FmUtMRYQH++TVyOAB2/XJP5qoITerU7RU7h1mJBVrgjrmqJTyRdNFRw+fngG 6JDaEBOnSjtG3GUiD4Pf/S6Ta5cLXgIvqeJk3hGVlEOfIR2hkU/jMli936A6KhN+JJ7lUmnIcJR r/HSlWEoyZLppwcLjzA0I4VF33zX8516OObJT6BRnPgeZWo9dsKOImSl/Q8d15R1/B3PGHrBTtQ Wh87/I2OQ/vgJuA1cbCVDOCMBHU3qAJokzQsPMlof8PT4e90s6iWTWVxldP6vTgoUNx2/NzAJJW 29ilNPj2WE4ddpfYs6vsXdB3/scPaVhd+cqp86/yeSi/Q== X-purgate-ID: tlsNG-ef75cf/1785676198-A72DCAE4-33145081/0/0 X-purgate-type: clean X-purgate-size: 6771 From: Szymon Acedański TIS is an older and slower byte-oriented TPM interface that gets replaced by CRB on modern systems. Signed-off-by: Szymon Acedański Assisted-by: Claude:claude-opus-4-6 Signed-off-by: Sergii Dmytruk --- Notes: v4: new commit to support CRB interface of TPM2.0 xen/arch/x86/tpm.c | 134 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 131 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/tpm.c b/xen/arch/x86/tpm.c index 59bb1ff2c4..a3d9a0d3e5 100644 --- a/xen/arch/x86/tpm.c +++ b/xen/arch/x86/tpm.c @@ -72,6 +72,11 @@ static uint8_t tpm_read8(unsigned int reg) return *(volatile uint8_t *)__va(TPM_MMIO_BASE + reg); } +static void tpm_write32(unsigned int reg, uint32_t val) +{ + *(volatile uint32_t *)__va(TPM_MMIO_BASE + reg) = val; +} + static void tpm_write8(unsigned int reg, uint8_t val) { *(volatile uint8_t *)__va(TPM_MMIO_BASE + reg) = val; @@ -110,6 +115,31 @@ static bool tpm_is_crb(void) #define TIS_BURST_COUNT_(x) TPM_LOC_REG(x, 0x19) /* the middle of STS */ #define TIS_DATA_FIFO_(x) TPM_LOC_REG(x, 0x24) +/************************** CRB register definitions **************************/ + +#define CRB_LOC_STATE_(x) TPM_LOC_REG(x, 0x00) +#define CRB_LOC_STATE_LOC_ASSIGNED (1 << 1) +#define CRB_LOC_STATE_REG_VALID_STS (1 << 7) +#define CRB_LOC_CTRL_(x) TPM_LOC_REG(x, 0x08) +#define CRB_LOC_CTRL_REQUEST_ACCESS (1 << 0) +#define CRB_LOC_CTRL_RELINQUISH (1 << 1) +#define CRB_CTRL_REQ_(x) TPM_LOC_REG(x, 0x40) +#define CRB_CTRL_REQ_CMD_READY (1 << 0) +#define CRB_CTRL_REQ_GO_IDLE (1 << 1) +#define CRB_CTRL_STS_(x) TPM_LOC_REG(x, 0x44) +#define CRB_CTRL_STS_ERROR (1 << 0) +#define CRB_CTRL_CANCEL_(x) TPM_LOC_REG(x, 0x48) +#define CRB_CTRL_CANCEL_INVOKE (1 << 0) +#define CRB_CTRL_START_(x) TPM_LOC_REG(x, 0x4C) +#define CRB_CTRL_START_INVOKE (1 << 0) +#define CRB_CTRL_CMD_SIZE_(x) TPM_LOC_REG(x, 0x58) +#define CRB_CTRL_CMD_LADDR_(x) TPM_LOC_REG(x, 0x5C) +#define CRB_CTRL_CMD_HADDR_(x) TPM_LOC_REG(x, 0x60) +#define CRB_CTRL_RSP_SIZE_(x) TPM_LOC_REG(x, 0x64) +#define CRB_CTRL_RSP_ADDR_(x) TPM_LOC_REG(x, 0x68) +#define CRB_DATA_BUFFER_(x) TPM_LOC_REG(x, 0x80) +#define CRB_DATA_BUFFER_SIZE 0x0F80 + /************************** TIS locality & command ****************************/ static void tis_request_locality(unsigned int loc) @@ -195,12 +225,110 @@ static void tis_send_cmd(unsigned int loc, uint8_t *buf, unsigned int i_size, tpm_write8(TIS_STS_(loc), STS_COMMAND_READY); } +/************************** CRB locality & command ****************************/ + +static void crb_request_locality(unsigned int loc) +{ + const uint32_t mask = CRB_LOC_STATE_LOC_ASSIGNED | + CRB_LOC_STATE_REG_VALID_STS; + + tpm_write32(CRB_LOC_CTRL_(loc), CRB_LOC_CTRL_REQUEST_ACCESS); + while ( (tpm_read32(CRB_LOC_STATE_(loc)) & mask) != mask ) + ; +} + +static void crb_relinquish_locality(unsigned int loc) +{ + tpm_write32(CRB_LOC_CTRL_(loc), CRB_LOC_CTRL_RELINQUISH); + while ( tpm_read32(CRB_LOC_STATE_(loc)) & CRB_LOC_STATE_LOC_ASSIGNED ) + ; +} + +static void crb_cmd_ready(unsigned int loc) +{ + tpm_write32(CRB_CTRL_REQ_(loc), CRB_CTRL_REQ_CMD_READY); + while ( tpm_read32(CRB_CTRL_REQ_(loc)) & CRB_CTRL_REQ_CMD_READY ) + ; +} + +static void crb_go_idle(unsigned int loc) +{ + tpm_write32(CRB_CTRL_REQ_(loc), CRB_CTRL_REQ_GO_IDLE); + while ( tpm_read32(CRB_CTRL_REQ_(loc)) & CRB_CTRL_REQ_GO_IDLE ) + ; +} + +static void crb_send_cmd(unsigned int loc, uint8_t *buf, unsigned int i_size, + unsigned int *o_size) +{ + paddr_t data_buf_pa = TPM_MMIO_BASE + CRB_DATA_BUFFER_(loc); + unsigned int expected; + + if ( i_size > CRB_DATA_BUFFER_SIZE || *o_size < sizeof(struct tpm_rsp_hdr) ) + { + *o_size = 0; + return; + } + + /* Out of caution, make sure no previous command is still executing. */ + while ( tpm_read32(CRB_CTRL_START_(loc)) & CRB_CTRL_START_INVOKE ) + ; + + crb_cmd_ready(loc); + + /* In an unlikely event that TPM signals irrecoverable error here, + * better bail out than hang in infinite loop waiting for the + * start condition later. */ + if ( tpm_read32(CRB_CTRL_STS_(loc)) & CRB_CTRL_STS_ERROR ) + { + *o_size = 0; + crb_go_idle(loc); + return; + } + + tpm_write32(CRB_CTRL_CANCEL_(loc), 0); + + tpm_write32(CRB_CTRL_CMD_LADDR_(loc), data_buf_pa); + tpm_write32(CRB_CTRL_CMD_HADDR_(loc), 0); + tpm_write32(CRB_CTRL_CMD_SIZE_(loc), CRB_DATA_BUFFER_SIZE); + tpm_write32(CRB_CTRL_RSP_SIZE_(loc), CRB_DATA_BUFFER_SIZE); + /* RSP_ADDR is 64-bit. */ + tpm_write32(CRB_CTRL_RSP_ADDR_(loc), data_buf_pa); + tpm_write32(CRB_CTRL_RSP_ADDR_(loc) + 4, 0); + + memcpy(__va(data_buf_pa), buf, i_size); + + tpm_write32(CRB_CTRL_START_(loc), CRB_CTRL_START_INVOKE); + while ( tpm_read32(CRB_CTRL_START_(loc)) & CRB_CTRL_START_INVOKE ) + ; + + if ( tpm_read32(CRB_CTRL_STS_(loc)) & CRB_CTRL_STS_ERROR ) + { + *o_size = 0; + crb_go_idle(loc); + return; + } + + /* Read header to learn the response length. */ + memcpy(buf, __va(data_buf_pa), sizeof(struct tpm_rsp_hdr)); + expected = be32_to_cpu(((struct tpm_rsp_hdr *)buf)->paramSize); + if ( expected > *o_size ) + expected = *o_size; + if ( expected > CRB_DATA_BUFFER_SIZE ) + expected = CRB_DATA_BUFFER_SIZE; + + memcpy(buf, __va(data_buf_pa), expected); + + *o_size = expected; + crb_go_idle(loc); +} + /************************** Interface dispatch ********************************/ static void request_locality(unsigned int loc) { if ( tpm_is_crb() ) - return; + crb_request_locality(loc); else tis_request_locality(loc); } @@ -208,7 +336,7 @@ static void request_locality(unsigned int loc) static void relinquish_locality(unsigned int loc) { if ( tpm_is_crb() ) - return; + crb_relinquish_locality(loc); else tis_relinquish_locality(loc); } @@ -217,7 +345,7 @@ static void send_cmd(unsigned int loc, uint8_t *buf, unsigned int i_size, unsigned int *o_size) { if ( tpm_is_crb() ) - *o_size = 0; + crb_send_cmd(loc, buf, i_size, o_size); else tis_send_cmd(loc, buf, i_size, o_size); } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380616.1624312 (Exim 4.92) (envelope-from ) id 1wqVwu-0002XC-3R; Sun, 02 Aug 2026 13:09:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380616.1624312; Sun, 02 Aug 2026 13:09:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVwt-0002Ww-VX; Sun, 02 Aug 2026 13:09:51 +0000 Received: by outflank-mailman (input) for mailman id 1380616; Sun, 02 Aug 2026 13:09:51 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVws-0002Ls-Rc for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:09:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVwr-004d0q-Mc for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:09:49 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f417e-2eae-0a2a0a5409dd-0a2a4502c3a4-18 for ; Sun, 02 Aug 2026 15:09:49 +0200 Received: from [87.98.181.248] (helo=5.mo560.mail-out.ovh.net) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f4197-6ca4-0a2a45020019-5762b5f89245-3 for ; Sun, 02 Aug 2026 15:09:44 +0200 Received: from director10.ghost.mail-out.ovh.net (unknown [10.110.37.197]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 4hCgBb5RkDzB5lq for ; Sun, 2 Aug 2026 13:09:43 +0000 (UTC) Received: from ghost-submission-7d8d68f679-xdn7l (unknown [10.110.96.89]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id AA4E2C0F4F; Sun, 2 Aug 2026 13:09:41 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.96]) by ghost-submission-7d8d68f679-xdn7l with ESMTPSA id 2ctPGpVBb2ofBBsATjhwOw (envelope-from ); Sun, 02 Aug 2026 13:09:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-96R0016b89e747-1785-4152-95ae-486e00688f50, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , Lukasz Hawrylko , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini , Nicola Vetrini , Doug Goldstein , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , trenchboot-devel@googlegroups.com Subject: [PATCH v4 00/23] x86: Trenchboot Secure Launch DRTM (Xen) Date: Sun, 2 Aug 2026 16:09:16 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4726246333962331580 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -51 X-VR-SPAMCAUSE: dmFkZTFdXTrARFACQ6m9P7gTxX0PekKK8WeIVA15uE+Q8jnwA9gEyJa7xjXxo5vANI53/0+D44IJm6ZWpxAtd4w3ij7mPxMHSgilLVIAbFfDh74rWf79n1eaYlmPcZv5e6jI+mYGSty3r03VTenwEhPzEEAFz6EhCwT2dGzWQhDVwl7Wvgr5EyDql+zuQNMTRf0D8nzyFZGp15N6IkYLAr7uLr2cUucu71/cfXLIz/4eakvJn7uag/1v5Pka9Gi+tIHo0NtqsYPZIVphzck04C9GB6uAf2dfA8R8ZCdxSLdLJLip4cwRyE5bwLdAwax0O1xBzxePGB2TbRYRKAiiU/R9VFwcmJFnFqemLxjevb6bqC3OcwQg3SqHW2QNlhG0XgELBicbjxtMdkPA7T9MMgGaOmTZi+54x63HT3yvj+kLO6jmxmQxgDq5vJHm4U6fnVEf4hupdi4mg6ImUsJAb/16BOkq/SmCA6zb98joQZtJpiqYtz1ZOry7gpZSC8ZlfdpAAejx5FqdltDSrGM1e3LRoSxFCJziHrcGuKTiSGapnoCOLPVbkXMcx4RVTTvyv+LavBs8GkpYomQHQjrKYm2H3jDDZNRHCPloGrHv9Ndvv7kohZbstOpKU6A2nHx25hBWQdmBv5aC2gyCA4qJ6fJc3/ZzxP8sUaCsCzWkpNK6rBJDNg DKIM-Signature: a=rsa-sha256; bh=qHXC8mHNWg/aZvJUsYG80TVBq7kbjbeH1mde4zTkom8=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676183; v=1; b=TRXyQY/eSHLhVvcblvdDseI8wit6I9NXOVUiHWc9PbvJDgJ5L3XPgXviZ4mQcCzoDvOKmvww JX3w35rxT4hSszEayPR1PoruXap/gmtTGFeJZqaQrWS1nBdOo/OGcROqjFLuuW4ZwrfcNMi8uS1 Mktf0Bm6FqEe7UZfuO9OBjx9hg767448xVz9fhAiBkErQ1VeSqq5Md4Ln1MAHNduTjdJAIokOTg w850fbkIqb0zauwsJegtUXYtXQZvno6t9P3HaKKhwNRwgFgqKEVyjNTuvil3RwvpVKag6TP6a/F XubtPBpo+3dj78TZ4rC3rmu338U7cNkCSIzZm3hu4ddxA== X-purgate-ID: tlsNG-720697/1785676189-66EB32AC-0E948AD1/0/0 X-purgate-type: clean X-purgate-size: 10266 The aim of the [TrenchBoot] project is to provide an implementation of DRTM that is generic enough to cover various use cases: - Intel TXT and AMD SKINIT on x86 CPUs - legacy and UEFI boot - TPM1.2 and TPM2.0 (TIS and CRB) - (in the future) DRTM on Arm CPUs DRTM is a version of a measured launch that starts on request rather than at the start of a boot cycle. One of its advantages is in not including the firmware in the chain of trust. Xen already supports DRTM via [tboot] which targets Intel TXT only. tboot encapsulates some of the DRTM details within itself while with TrenchBoot Xen (or Linux) is meant to be a self-contained payload for a TrenchBoot-enabled bootloader (think GRUB). The one exception is that UEFI case requires calling back into bootloader to initiate DRTM, which is necessary to give Xen a chance of querying all the information it needs from the firmware before performing DRTM start. >From reading the above tboot might seem like a more abstracted, but the reality is that the payload needs to have DRTM-specific knowledge either way. In principle, TrenchBoot, allows coming up with independent implementations of bootloaders and payloads that are compatible with each other. The "x86/boot: choose AP stack based on APIC ID" patch is shared with [Parallelize AP bring-up] series and is required here because Intel TXT always releases all APs simultaneously. The rest of the patches are unique. This version of the patches corresponds to this branch: https://github.com/TrenchBoot/xen/compare/7c77acd452fb...tb-staging-2026-07-31-v4 ----- [TrenchBoot]: https://trenchboot.org/ [tboot]: https://sourceforge.net/p/tboot/wiki/Home/ [Parallelize AP bring-up]: https://lore.kernel.org/xen-devel/cover.1699982111.git.krystian.hebel@3mdeb.com/ [v1]: https://lore.kernel.org/xen-devel/cover.1745172094.git.sergii.dmytruk@3mdeb.com/ [v2]: https://lore.kernel.org/xen-devel/cover.1747155790.git.sergii.dmytruk@3mdeb.com/ [v3]: https://lore.kernel.org/xen-devel/cover.1748611041.git.sergii.dmytruk@3mdeb.com/ ----- Changes in v4: - added notes to individial commits, the notes below cover some of more generic changes or those spanning multiple commits - dropped SHA-1 changes (was committed independently of this patchset) - added CONFIG_SLAUNCH Kconfig option - TPM driver changes have been moved to the front and are now independent from TPM event log and the rest of this patchset in general - a few commits were split, joined and/or renamed to make changes more independent, see notes in individual patches - added support for communicating with TPM2.0 via CRB and memory protection using TPR to support newer handware - moved UEFI_SLR_TABLE_GUID from xen/include/xen/slr-table.h to xen/common/efi/boot.c - changed the code for dealing with tables in TXT heap to be iterative - added more implementation-specific error codes and removed unused ones - extracted declarations from tpm.c into headers for TPM1.2 and TPM2.0 - return EACCES instead of EPERM when refusing to go into S3 state - moved SLAUNCH_BOOTLOADER_MAGIC from x86/asm/intel-txt.h to x86/boot/head.S - moved making MTRR-related functions public to commit which uses them - use container_of() after slr_next_entry_by_tag() instead of a cast - made more code that deals with SLRT const-correct (including adding const to the parameter of dl_handler_func) - absent TPM event log is now consistently allowed by both TPM1.2 and TPM2.0 implementations Changes in [v3]: - sorted `F:` entries in MAINTAINERS file - made sha1 implementation more similar to sha256 - dropped unused parameter from xen/arch/x86/cpu/intel.c:intel_log_smx_txt() - updated header guards according to new style - xen/arch/x86/include/asm/intel-txt.h: + briefly explained what TXT is + renamed: NR_TXT_CONFIG_SIZE -> TXT_CONFIG_SPACE_SIZE + renamed: read_txt_reg() -> txt_read() + renamed: write_txt_reg() -> txt_write() + marked txt_reset() as noreturn and used unreacheable() instead of while(1) + explained a bit more about TXT Heap - xen/include/xen/slr-table.h: + briefly explained what SLRT is + fixed checks in slr_next_entry() - SPDX-License-Identifier: GPL-2.0 -> GPL-2.0-only - made more code const-correct - use arithmetic on pointers to `void` instead of pointers to `uint8_t` Changes in [v2]: - using dashes instead of underscores in the names of new files - dropping of an extra sha256 implementation - rewriting sha1 implementation to be in line with already present sha256 implementation (simplifying it and getting rid of macros) - correct placement of new lines in Makefile - add header guards to all new files - use correct names for header guards in new files - update license of xen/include/xen/slr-table.h - changed fixmlehdr to search for header within 8 instead of 4 KiB file prefix - don't print DRTM-related capabilities when resuming from S3 - forbade S3 in case of Secure Launch - fixed an issue with resuming from S3 caused by inappropriate use of __initdata - added a new section to MAINTAINERS - improved commit messages - fixed MISRA C violations: + shadowing of e820 global + missing U literal suffixes + use of ull literal suffix + excluded fixmlehdr from analysis (similar to other build tools) + use of 0 instead of NULL in one place + provided declarations for some definitions + marked asm-invoked functions with `asmlinkage` ----- Kacper Stojek (2): x86/boot: add CONFIG_SLAUNCH, MLE header and Secure Launch entry point xen/arch/x86: reserve TXT memory during Slaunch Krystian Hebel (7): x86/tpm.c: hashing and extending PCRs for TPM1.2 x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap x86/boot/slaunch-early: early Intel TXT sanity checks x86/slaunch: restore boot MTRRs after Intel TXT DRTM x86/slaunch: measure MBI into TPM x86/boot: choose AP stack based on APIC ID x86/smpboot.c: TXT AP bringup Michał Żygowski (2): x86/cpu: report SMX, TXT and SKINIT capabilities x86/hvm: check for VMX in SMX if Slaunch is active Sergii Dmytruk (10): x86/mtrr: get rid of a static variable on pause/restore x86/tpm.c: support extending PCRs of TPM2.0 via TIS include/xen/slr-table.h: Secure Launch Resource Table definitions x86/boot/slaunch-early: implement early initialization x86/slaunch: update TPM event log (TPM1.2 or TPM2.0) x86/slaunch: process DRTM policy x86/acpi: disallow S3 on Secure Launch boot x86/slaunch: support AMD CPUs x86/slaunch: support EFI boot MAINTAINERS: add a section for TrenchBoot Slaunch Szymon Acedański (2): x86/tpm.c: add CRB interface support xen/arch/x86: add TPR (TXT Protected Range) DMA protection support .gitignore | 1 + MAINTAINERS | 19 + .../eclair_analysis/ECLAIR/out_of_scope.ecl | 1 + docs/hypervisor-guide/x86/how-xen-boots.rst | 12 + xen/arch/x86/Kconfig | 8 + xen/arch/x86/Makefile | 16 +- xen/arch/x86/acpi/power.c | 8 + xen/arch/x86/boot/Makefile | 22 +- xen/arch/x86/boot/head.S | 267 ++++++ xen/arch/x86/boot/slaunch-early.c | 104 +++ xen/arch/x86/boot/trampoline.S | 42 +- xen/arch/x86/boot/x86_64.S | 67 +- xen/arch/x86/cpu/amd.c | 16 + xen/arch/x86/cpu/cpu.h | 1 + xen/arch/x86/cpu/hygon.c | 1 + xen/arch/x86/cpu/intel.c | 50 + xen/arch/x86/cpu/mtrr/generic.c | 50 +- xen/arch/x86/e820.c | 5 + xen/arch/x86/efi/efi-boot.h | 95 +- xen/arch/x86/efi/fixmlehdr.c | 127 +++ xen/arch/x86/hvm/vmx/vmcs.c | 3 +- xen/arch/x86/include/asm/apicdef.h | 4 + xen/arch/x86/include/asm/intel-txt.h | 573 ++++++++++++ xen/arch/x86/include/asm/msr-index.h | 3 + xen/arch/x86/include/asm/mtrr.h | 8 + xen/arch/x86/include/asm/processor.h | 1 + xen/arch/x86/include/asm/setup.h | 3 + xen/arch/x86/include/asm/slaunch-tpm.h | 26 + xen/arch/x86/include/asm/slaunch.h | 128 +++ xen/arch/x86/include/asm/tpm.h | 74 ++ xen/arch/x86/include/asm/tpm1.h | 94 ++ xen/arch/x86/include/asm/tpm2.h | 150 +++ xen/arch/x86/intel-txt.c | 197 ++++ xen/arch/x86/setup.c | 32 +- xen/arch/x86/slaunch-tpm.c | 312 +++++++ xen/arch/x86/slaunch.c | 478 ++++++++++ xen/arch/x86/smpboot.c | 75 ++ xen/arch/x86/tboot.c | 20 +- xen/arch/x86/tpm.c | 862 ++++++++++++++++++ xen/arch/x86/x86_64/asm-offsets.c | 13 + xen/common/efi/boot.c | 6 + xen/common/efi/runtime.c | 1 + xen/include/xen/efi.h | 1 + xen/include/xen/slr-table.h | 272 ++++++ 44 files changed, 4191 insertions(+), 57 deletions(-) create mode 100644 xen/arch/x86/boot/slaunch-early.c create mode 100644 xen/arch/x86/efi/fixmlehdr.c create mode 100644 xen/arch/x86/include/asm/intel-txt.h create mode 100644 xen/arch/x86/include/asm/slaunch-tpm.h create mode 100644 xen/arch/x86/include/asm/slaunch.h create mode 100644 xen/arch/x86/include/asm/tpm.h create mode 100644 xen/arch/x86/include/asm/tpm1.h create mode 100644 xen/arch/x86/include/asm/tpm2.h create mode 100644 xen/arch/x86/intel-txt.c create mode 100644 xen/arch/x86/slaunch-tpm.c create mode 100644 xen/arch/x86/slaunch.c create mode 100644 xen/arch/x86/tpm.c create mode 100644 xen/include/xen/slr-table.h base-commit: 7c77acd452fb6a3079661e75ebb5cf23ed985cc7 -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380618.1624331 (Exim 4.92) (envelope-from ) id 1wqVww-0002yk-Lw; Sun, 02 Aug 2026 13:09:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380618.1624331; Sun, 02 Aug 2026 13:09:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVww-0002yd-Iv; Sun, 02 Aug 2026 13:09:54 +0000 Received: by outflank-mailman (input) for mailman id 1380618; Sun, 02 Aug 2026 13:09:54 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVwv-0002y1-Ud for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:09:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVwv-00Beoh-Bb for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:09:53 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4173-bab6-0a2a0a5309dd-0a2a450c9222-34 for ; Sun, 02 Aug 2026 15:09:53 +0200 Received: from [46.105.63.230] (helo=7.mo575.mail-out.ovh.net) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41a0-f479-0a2a450c0019-2e693fe6ac23-3 for ; Sun, 02 Aug 2026 15:09:52 +0200 Received: from director1.ghost.mail-out.ovh.net (unknown [10.110.58.50]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 4hCgBm1jnpz5xm0 for ; Sun, 2 Aug 2026 13:09:51 +0000 (UTC) Received: from ghost-submission-7d8d68f679-57pcc (unknown [10.110.164.236]) by director1.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 21241C0F98; Sun, 2 Aug 2026 13:09:50 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.101]) by ghost-submission-7d8d68f679-57pcc with ESMTPSA id VxU1NJ5Bb2oLoxsA/StGhg (envelope-from ); Sun, 02 Aug 2026 13:09:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-101G004acb215d6-7df5-4471-9e04-20cb55976478, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 03/23] x86/tpm.c: hashing and extending PCRs for TPM1.2 Date: Sun, 2 Aug 2026 16:09:19 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4728498136041268668 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEtK5p0SNYtBef44Zaajhk33i63wmjVwNNhJ4YROChk7mhZcpyT3bd5ACP3F2TkAykP416Z/qj7tU2KxG1rTRS8MypF1KRhaA/AvmFdmp6hM2n75hgvTPUkRMkZtHtCy5BQJTDAa5dye2uRhTva5lFRUMRQoQfXqDmPkoEsCcMiOXhj8LDb8bxT7fPbPw+L6oM3Ib4+Crk5z3znR8b12WvIauAwvZwi4TwyXrVt8t5cjjf6p6tk/jAP3JPPWAt8lJLbOqKqZPj2dLVv8AcggN/kQjhcbgaHkG9r5s4innAGR9o3gaGzW+PeUVjPnviytxFmoTk+gQnhQiwpJq7s595nro3dDeuJs3r7PQx7V1K5fDPxkXiSwZe2lpVbkaWyv2p59iz/SIXjpugOQqVbJPoyrz7LbnDBWXKS66PYZWt87iuau+QRV23XF3bPbO94TTOakCioNXrOvJoPu9PMtSMMbW3YdbI5o5UqzbO8YWccAbk8u+SYUA/6uc3oa/lV0FtXaaJ5xC/ERvxf3WNKd69NprOiXi6+whRVw4SZxeQvgnTLw0OsL65npUEtg8SMe3ZurJxyTwkqdtRFyNkYKaQbCsZQqwxivk0/snc2zf0vOS5BEafSj0PpsmTzt2HJ44FVbdFCYICCD6GbBvPFX/y6i2sn8twpHhGY/qQuos83Tg DKIM-Signature: a=rsa-sha256; bh=6hGSZXXcE+GcwWq+O2X1Dm5dHBDi/Fx386sIY1IuUps=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676192; v=1; b=I3zkZcWyzoVDVVQltodqnln/Uu0EsD3B6Wrjf4RDsJo5q1sTiAtbx/TrkxdIZ+8pAiMS5Ckm crNZo/3wIfpYqfwNm6s/pFKkQeLRZnXLxngR/jPg4rYV+FBxMt8zYFquw1FecesQHmOx0cRrkOK wtUD9SKCbn1jTtaOL371f/ivcx7fnKb1tERIZC0KuJ1L4VS4NM8wsetRhcSgp5vAi4PtHDjGlbB nqRV3TiHRThvtwov0Dp6lXf1xP+JZE/zMas3oM6YNT3AYObc+Hg+rEbzRJMRymkyNRmjorGK/Ln w6hTkj8Id5yz5OMtLkZEpRltCUHirQtMQ+APDjUHQWQiQ== X-purgate-ID: tlsNG-d25034/1785676192-52530A5B-7756090D/0/0 X-purgate-type: clean X-purgate-size: 20343 From: Krystian Hebel This file is built twice: for early 32b mode without paging and for 64b code. The expectation is that the data that's measured early is small and thus sending it to TPM to do the hashing is viable. Version with paging computes digests and only sends their values to TPM, thus permitting hashing of large chunks of data like dom0's kernel and initrd (sending them to TPM would take multiple minutes). Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: renamed from "x86/tpm.c: code for early hashing and extending PCRs (for TPM1.2)" v4: no longer depends on Slaunch v4: __EARLY_SLAUNCH__ got replaced with __EARLY_TPM__ v4: fixed SPDX license comments v4: added short description at the top v4: TPM_TIS_* => TPM_MMIO_* v4: tpm_hash_extend() now returns an error code v4: tpm_hash_extend() now accepts list of hashes like TPM2 but expects at most SHA1 v4: turned is_tpm12() into public tpm_is_tpm1() function (to be used for event log) v4: added xen/arch/x86/include/asm/tpm1.h with TPM1.2 TCG declarations v4: removed swap16() and swap32() macros to use macros from v4: no more `static inline` in tpm.c, it's pointless there v4: style fixes for empty loops, operator placement on wrapped lines, checking for unset bits v4: take TPM burst count into account v4: fixed incorrect check for `data_avail` when communicating with TPM v4: internal functions return TPM error code instead of `bool` v4: added command and response fields to `union cmd_rsp` to make using it easier v4: `unsigned` => `unsigned int` v4: not opencoding ROUNDDOWN() macro v4: digest storage became optional v4: returns TPM_INTERNAL_ERROR if not dealing with TPM1.2 or on communication error v4: the code is written for TIS, but has room for other TPM interfaces xen/arch/x86/Makefile | 1 + xen/arch/x86/boot/Makefile | 5 + xen/arch/x86/include/asm/tpm.h | 69 ++++++ xen/arch/x86/include/asm/tpm1.h | 79 +++++++ xen/arch/x86/tpm.c | 406 ++++++++++++++++++++++++++++++++ 5 files changed, 560 insertions(+) create mode 100644 xen/arch/x86/include/asm/tpm.h create mode 100644 xen/arch/x86/include/asm/tpm1.h create mode 100644 xen/arch/x86/tpm.c diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index b14eca98bf..293f3bee35 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -68,6 +68,7 @@ obj-y += string.o obj-$(CONFIG_SYSCTL) += sysctl.o obj-$(CONFIG_TBOOT) += tboot.o obj-y += time.o +obj-y += tpm.o obj-y += traps-setup.o obj-y += traps.o obj-$(CONFIG_INTEL) += tsx.o diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile index ff0d61d7ac..feae17c14a 100644 --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -5,6 +5,7 @@ obj-bin-y += $(obj64) obj32 := cmdline.32.o obj32 += reloc.32.o obj32 += reloc-trampoline.32.o +obj32 += tpm-early.32.o obj64 := reloc-trampoline.o @@ -28,6 +29,10 @@ $(obj32): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic $(obj)/%.32.o: $(src)/%.c FORCE $(call if_changed_rule,cc_o_c) +$(obj)/tpm-early.32.o: XEN_CFLAGS += -D__EARLY_TPM__ +$(obj)/tpm-early.32.o: $(src)/../tpm.c FORCE + $(call if_changed_rule,cc_o_c) + orphan-handling-$(call ld-option,--orphan-handling=error) := --orphan-handling=error LDFLAGS_DIRECT-$(call ld-option,--warn-rwx-segments) := --no-warn-rwx-segments LDFLAGS_DIRECT += $(LDFLAGS_DIRECT-y) diff --git a/xen/arch/x86/include/asm/tpm.h b/xen/arch/x86/include/asm/tpm.h new file mode 100644 index 0000000000..06b54fb786 --- /dev/null +++ b/xen/arch/x86/include/asm/tpm.h @@ -0,0 +1,69 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * A TPM driver for both normal and early boot environments. + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#ifndef X86_TPM_H +#define X86_TPM_H + +#include + +#define TPM_INTERNAL_ERROR 0xffffffffU + +#define TPM_MMIO_BASE 0xfed40000U +#define TPM_MMIO_SIZE 0x00010000U + +/* These are defined for TPM2, but they are used by generic API. */ +#define TPM_ALG_SHA1 0x0004 +#define TPM_ALG_SHA256 0x000b +#define TPM_ALG_NULL 0x0010 + +/* + * These two structures are for convenience, they don't correspond to anything + * in any specification. + */ +struct tpm_log_hash { + uint16_t alg; /* TPM_ALG_* */ + uint16_t size; + uint8_t *data; /* Non-owning reference to a buffer inside log entry. */ +}; +/* Should be more than enough for now and awhile in the future. */ +#define MAX_TPM_HASH_COUNT 8 +struct tpm_log_hashes { + uint32_t count; + struct tpm_log_hash hashes[MAX_TPM_HASH_COUNT]; +}; + +/* All fields of the following structs are big endian. */ + +struct tpm_cmd_hdr { + uint16_t tag; + uint32_t paramSize; + uint32_t ordinal; +} __packed; + +struct tpm_rsp_hdr { + uint16_t tag; + uint32_t paramSize; + uint32_t returnCode; +} __packed; + +/* Checks whether TPM belongs to TPM 1 family, the only alternative is TPM 2. */ +bool tpm_is_tpm1(void); + +/* + * The list of hashes must either be empty or contain nothing but SHA1 hash when + * tpm_is_tpm1() returns true. + * + * Returns: + * - TPM error code when < 4096 (0 means success) + * - TPM_INTERNAL_ERROR on invalid invocation or a failure to communicate with + * a TPM device + */ +uint32_t tpm_hash_extend(unsigned int loc, unsigned int pcr, const uint8_t *buf, + unsigned int size, + const struct tpm_log_hashes *log_hashes); + +#endif /* X86_TPM_H */ diff --git a/xen/arch/x86/include/asm/tpm1.h b/xen/arch/x86/include/asm/tpm1.h new file mode 100644 index 0000000000..d1cb2cc041 --- /dev/null +++ b/xen/arch/x86/include/asm/tpm1.h @@ -0,0 +1,79 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * TPM1.2-related declarations defined by Trusted Computing Group (TCG). + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#ifndef X86_TPM1_H +#define X86_TPM1_H + +#include +#include + +#include + +#define TPM_ORD_Extend 0x00000014 +#define TPM_ORD_SHA1Start 0x000000A0 +#define TPM_ORD_SHA1Update 0x000000A1 +#define TPM_ORD_SHA1CompleteExtend 0x000000A3 + +#define TPM_TAG_RQU_COMMAND 0x00C1 +#define TPM_TAG_RSP_COMMAND 0x00C4 + +/* All fields of the following structs are big endian. */ + +struct extend_cmd { + struct tpm_cmd_hdr h; + uint32_t pcrNum; + uint8_t inDigest[SHA1_DIGEST_SIZE]; +} __packed; + +struct extend_rsp { + struct tpm_rsp_hdr h; + uint8_t outDigest[SHA1_DIGEST_SIZE]; +} __packed; + +struct sha1_start_cmd { + struct tpm_cmd_hdr h; +} __packed; + +struct sha1_start_rsp { + struct tpm_rsp_hdr h; + uint32_t maxNumBytes; +} __packed; + +struct sha1_update_cmd { + struct tpm_cmd_hdr h; + uint32_t numBytes; /* Must be a multiple of 64 */ + uint8_t hashData[]; +} __packed; + +struct sha1_update_rsp { + struct tpm_rsp_hdr h; +} __packed; + +struct sha1_complete_extend_cmd { + struct tpm_cmd_hdr h; + uint32_t pcrNum; + uint32_t hashDataSize; /* 0-64, inclusive */ + uint8_t hashData[]; +} __packed; + +struct sha1_complete_extend_rsp { + struct tpm_rsp_hdr h; + uint8_t hashValue[SHA1_DIGEST_SIZE]; + uint8_t outDigest[SHA1_DIGEST_SIZE]; +} __packed; + +/* The structures below are for TPM event log and these are in little-endian. */ + +struct TPM12_PCREvent { + uint32_t PCRIndex; + uint32_t Type; + uint8_t Digest[SHA1_DIGEST_SIZE]; + uint32_t Size; + uint8_t Data[]; +}; + +#endif /* X86_TPM1_H */ diff --git a/xen/arch/x86/tpm.c b/xen/arch/x86/tpm.c new file mode 100644 index 0000000000..9efaf75440 --- /dev/null +++ b/xen/arch/x86/tpm.c @@ -0,0 +1,406 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * TPM driver for extending PCRs. + * + * This file is built twice: + * 1. For early 32b mode without paging the code sends data to be hashed to + * TPM. + * 2. For 64b code which computes hashes and only extends them into PCRs. + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#include +#include +#include +#include + +#include +#include + +#ifdef __EARLY_TPM__ + +#include + +#ifdef __va +#error "__va defined in non-paged mode!" +#endif + +#define __va(x) _p(x) + +/* + * The code is being compiled as a standalone binary without linking to any + * other part of Xen. Providing implementation of builtin functions in this + * case is necessary if compiler chooses to not use an inline builtin. + */ +void *(memcpy)(void *dest, const void *src, size_t n) +{ + const uint8_t *s = src; + uint8_t *d = dest; + + while ( n-- ) + *d++ = *s++; + + return dest; +} + +#else /* __EARLY_TPM__ */ + +#include +#include + +#endif /* __EARLY_TPM__ */ + +#define TPM_LOC_REG(loc, reg) (0x1000 * (loc) + (reg)) + +/******************************** MMIO helpers ********************************/ + +static uint32_t tpm_read32(unsigned int reg) +{ + return *(volatile uint32_t *)__va(TPM_MMIO_BASE + reg); +} + +static uint16_t tpm_read16(unsigned int reg) +{ + return *(volatile uint16_t *)__va(TPM_MMIO_BASE + reg); +} + +static uint8_t tpm_read8(unsigned int reg) +{ + return *(volatile uint8_t *)__va(TPM_MMIO_BASE + reg); +} + +static void tpm_write8(unsigned int reg, uint8_t val) +{ + *(volatile uint8_t *)__va(TPM_MMIO_BASE + reg) = val; +} + +/************************** TIS register definitions **************************/ + +#define TIS_ACCESS_(x) TPM_LOC_REG(x, 0x00) +#define ACCESS_REQUEST_USE (1 << 1) +#define ACCESS_ACTIVE_LOCALITY (1 << 5) +#define TIS_INTF_CAPABILITY_(x) TPM_LOC_REG(x, 0x14) +#define INTF_VERSION_MASK 0x70000000 +#define TIS_STS_(x) TPM_LOC_REG(x, 0x18) +#define STS_FAMILY_MASK 0x0C000000 +#define STS_EXPECT_DATA (1 << 3) +#define STS_DATA_AVAIL (1 << 4) +#define STS_TPM_GO (1 << 5) +#define STS_COMMAND_READY (1 << 6) +#define STS_VALID (1 << 7) +#define TIS_BURST_COUNT_(x) TPM_LOC_REG(x, 0x19) /* the middle of STS */ +#define TIS_DATA_FIFO_(x) TPM_LOC_REG(x, 0x24) + +/************************** TIS locality & command ****************************/ + +static void tis_request_locality(unsigned int loc) +{ + tpm_write8(TIS_ACCESS_(loc), ACCESS_REQUEST_USE); + /* Check that locality was actually activated. */ + while ( !(tpm_read8(TIS_ACCESS_(loc)) & ACCESS_ACTIVE_LOCALITY) ) + ; +} + +static void tis_relinquish_locality(unsigned int loc) +{ + tpm_write8(TIS_ACCESS_(loc), ACCESS_ACTIVE_LOCALITY); +} + +static uint16_t tis_get_burst_count(unsigned int loc) +{ + return tpm_read16(TIS_BURST_COUNT_(loc)); +} + +static void tis_send_cmd(unsigned int loc, uint8_t *buf, unsigned int i_size, + unsigned int *o_size) +{ + /* + * Values of "expect data" and "data available" bits count only when "valid" + * field is set as well. + */ + const unsigned int expect_data = STS_VALID | STS_EXPECT_DATA; + const unsigned int data_avail = STS_VALID | STS_DATA_AVAIL; + + unsigned int i; + unsigned int burst_count; + + /* Make sure TPM can accept a command. */ + if ( !(tpm_read8(TIS_STS_(loc)) & STS_COMMAND_READY) ) + { + /* Abort current command. */ + tpm_write8(TIS_STS_(loc), STS_COMMAND_READY); + /* Wait until TPM is ready for a new one. */ + while ( !(tpm_read8(TIS_STS_(loc)) & STS_COMMAND_READY) ) + ; + } + + i = 0; + while ( i < i_size ) + { + do + burst_count = tis_get_burst_count(loc); + while ( burst_count == 0 ); + + while ( burst_count-- > 0 && i < i_size ) + tpm_write8(TIS_DATA_FIFO_(loc), buf[i++]); + + if ( i < i_size ) + { + while ( (tpm_read8(TIS_STS_(loc)) & expect_data) != expect_data ) + ; + } + } + + tpm_write8(TIS_STS_(loc), STS_TPM_GO); + + /* Wait for the first byte of response. */ + while ( (tpm_read8(TIS_STS_(loc)) & data_avail) != data_avail ) + ; + + i = 0; + do { + do + burst_count = tis_get_burst_count(loc); + while ( burst_count == 0 ); + + while ( burst_count-- > 0 && i < *o_size) + buf[i++] = tpm_read8(TIS_DATA_FIFO_(loc)); + + while ( !(tpm_read8(TIS_STS_(loc)) & STS_VALID) ) + ; + } while ( i < *o_size && + (tpm_read8(TIS_STS_(loc)) & data_avail) == data_avail ); + + *o_size = i; + + tpm_write8(TIS_STS_(loc), STS_COMMAND_READY); +} + +/************************** Interface dispatch ********************************/ + +static void request_locality(unsigned int loc) +{ + tis_request_locality(loc); +} + +static void relinquish_locality(unsigned int loc) +{ + tis_relinquish_locality(loc); +} + +static void send_cmd(unsigned int loc, uint8_t *buf, unsigned int i_size, + unsigned int *o_size) +{ + tis_send_cmd(loc, buf, i_size, o_size); +} + +bool tpm_is_tpm1(void) +{ + uint32_t intf_version; + + /* + * If one of these conditions is true: + * - INTF_CAPABILITY_x.interfaceVersion is 0 (TIS <= 1.21) + * - INTF_CAPABILITY_x.interfaceVersion is 2 (TIS == 1.3) + * - STS_x.tpmFamily is 0 + * we're dealing with TPM1.2. + */ + intf_version = tpm_read32(TIS_INTF_CAPABILITY_(0)) & INTF_VERSION_MASK; + return (intf_version == 0x00000000 || intf_version == 0x20000000 || + !(tpm_read32(TIS_STS_(0)) & STS_FAMILY_MASK)); +} + +/****************************** TPM1.2 specific *******************************/ + +#ifdef __EARLY_TPM__ +/* + * TPM1.2 is required to support commands of up to 1101 bytes, vendors rarely + * go above that. Limit maximum size of block of data to be hashed to 1024. + */ +#define MAX_HASH_BLOCK 1024 +#define CMD_RSP_BUF_SIZE (sizeof(struct sha1_update_cmd) + MAX_HASH_BLOCK) + +union cmd_rsp { + struct tpm_cmd_hdr c; + struct tpm_rsp_hdr r; + struct sha1_start_cmd start_c; + struct sha1_start_rsp start_r; + struct sha1_update_cmd update_c; + struct sha1_update_rsp update_r; + struct sha1_complete_extend_cmd finish_c; + struct sha1_complete_extend_rsp finish_r; + uint8_t buf[CMD_RSP_BUF_SIZE]; +}; + +static uint32_t tpm12_hash_extend(unsigned int loc, const uint8_t *buf, + unsigned int size, unsigned int pcr, + const struct tpm_log_hashes *log_hashes) +{ + union cmd_rsp cmd_rsp; + unsigned int max_bytes = MAX_HASH_BLOCK; + unsigned int o_size = sizeof(cmd_rsp); + uint32_t rc; + + request_locality(loc); + + cmd_rsp.start_c = (struct sha1_start_cmd) { + .h.tag = cpu_to_be16(TPM_TAG_RQU_COMMAND), + .h.paramSize = cpu_to_be32(sizeof(cmd_rsp.start_c)), + .h.ordinal = cpu_to_be32(TPM_ORD_SHA1Start), + }; + + send_cmd(loc, cmd_rsp.buf, be32_to_cpu(cmd_rsp.c.paramSize), &o_size); + if ( o_size < sizeof(cmd_rsp.start_r) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + rc = be32_to_cpu(cmd_rsp.r.returnCode); + if ( rc != 0 ) + goto error; + + if ( max_bytes > be32_to_cpu(cmd_rsp.start_r.maxNumBytes) ) + max_bytes = be32_to_cpu(cmd_rsp.start_r.maxNumBytes); + + while ( size > 64 ) + { + if ( size < max_bytes ) + max_bytes = ROUNDDOWN(size, 64); + + o_size = sizeof(cmd_rsp); + + cmd_rsp.update_c = (struct sha1_update_cmd) { + .h.tag = cpu_to_be16(TPM_TAG_RQU_COMMAND), + .h.paramSize = cpu_to_be32(sizeof(cmd_rsp.update_c) + max_bytes), + .h.ordinal = cpu_to_be32(TPM_ORD_SHA1Update), + .numBytes = cpu_to_be32(max_bytes), + }; + memcpy(cmd_rsp.update_c.hashData, buf, max_bytes); + + send_cmd(loc, cmd_rsp.buf, be32_to_cpu(cmd_rsp.c.paramSize), &o_size); + if ( o_size < sizeof(cmd_rsp.update_r) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + rc = be32_to_cpu(cmd_rsp.r.returnCode); + if ( rc != 0 ) + goto error; + + size -= max_bytes; + buf += max_bytes; + } + + o_size = sizeof(cmd_rsp); + + cmd_rsp.finish_c = (struct sha1_complete_extend_cmd) { + .h.tag = cpu_to_be16(TPM_TAG_RQU_COMMAND), + .h.paramSize = cpu_to_be32(sizeof(cmd_rsp.finish_c) + size), + .h.ordinal = cpu_to_be32(TPM_ORD_SHA1CompleteExtend), + .pcrNum = cpu_to_be32(pcr), + .hashDataSize = cpu_to_be32(size), + }; + memcpy(cmd_rsp.finish_c.hashData, buf, size); + + send_cmd(loc, cmd_rsp.buf, be32_to_cpu(cmd_rsp.c.paramSize), &o_size); + if ( o_size < sizeof(cmd_rsp.finish_r) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + rc = be32_to_cpu(cmd_rsp.r.returnCode); + if ( rc != 0 ) + goto error; + + if ( log_hashes->count != 0 ) + { + memcpy(log_hashes->hashes[0].data, cmd_rsp.finish_r.hashValue, + SHA1_DIGEST_SIZE); + } + + rc = 0; + + error: + relinquish_locality(loc); + return rc; +} + +#else + +union cmd_rsp { + struct tpm_cmd_hdr c; + struct tpm_rsp_hdr r; + struct extend_cmd extend_c; + struct extend_rsp extend_r; +}; + +static uint32_t tpm12_hash_extend(unsigned int loc, const uint8_t *buf, + unsigned int size, unsigned int pcr, + const struct tpm_log_hashes *log_hashes) +{ + union cmd_rsp cmd_rsp; + unsigned int o_size = sizeof(cmd_rsp); + uint32_t rc; + + request_locality(loc); + + cmd_rsp.extend_c = (struct extend_cmd) { + .h.tag = cpu_to_be16(TPM_TAG_RQU_COMMAND), + .h.paramSize = cpu_to_be32(sizeof(cmd_rsp.extend_c)), + .h.ordinal = cpu_to_be32(TPM_ORD_Extend), + .pcrNum = cpu_to_be32(pcr), + }; + + sha1(cmd_rsp.extend_c.inDigest, buf, size); + if ( log_hashes->count != 0 ) + { + memcpy(log_hashes->hashes[0].data, cmd_rsp.extend_c.inDigest, + SHA1_DIGEST_SIZE); + } + + send_cmd(loc, (uint8_t *)&cmd_rsp, be32_to_cpu(cmd_rsp.c.paramSize), + &o_size); + if ( o_size < sizeof(cmd_rsp.extend_r) ) + { + rc = TPM_INTERNAL_ERROR; + goto error; + } + rc = be32_to_cpu(cmd_rsp.r.returnCode); + if ( rc != 0 ) + goto error; + + relinquish_locality(loc); + + rc = 0; + + error: + return rc; +} + +#endif /* __EARLY_TPM__ */ + +/************************** end of TPM1.2 specific ****************************/ + +uint32_t tpm_hash_extend(unsigned int loc, unsigned int pcr, const uint8_t *buf, + unsigned int size, + const struct tpm_log_hashes *log_hashes) +{ + if ( tpm_is_tpm1() ) + { + if (log_hashes->count != 0 && + !(log_hashes->count == 1 && + log_hashes->hashes[0].alg == TPM_ALG_SHA1 && + log_hashes->hashes[0].size == SHA1_DIGEST_SIZE)) + { +#ifndef __EARLY_TPM__ + printk(XENLOG_ERR "Bad TPM1 log hash for PCR-%u\n", pcr); +#endif + return TPM_INTERNAL_ERROR; + } + + return tpm12_hash_extend(loc, buf, size, pcr, log_hashes); + } + + return TPM_INTERNAL_ERROR; +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380615.1624304 (Exim 4.92) (envelope-from ) id 1wqVws-0002M2-S3; Sun, 02 Aug 2026 13:09:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380615.1624304; Sun, 02 Aug 2026 13:09:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVws-0002Lu-O5; Sun, 02 Aug 2026 13:09:50 +0000 Received: by outflank-mailman (input) for mailman id 1380615; Sun, 02 Aug 2026 13:09:49 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVwq-0002Lk-AX for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:09:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVwp-001xPK-IM for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:09:47 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4195-5cb7-0a2a0a5109dd-0a2a4506dd12-8 for ; Sun, 02 Aug 2026 15:09:46 +0200 Received: from [178.33.46.10] (helo=4.mo561.mail-out.ovh.net) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f419a-195a-0a2a45060019-b2212e0aa901-3 for ; Sun, 02 Aug 2026 15:09:46 +0200 Received: from director7.ghost.mail-out.ovh.net (unknown [10.110.54.182]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4hCgBf2cWyz5wxV for ; Sun, 2 Aug 2026 13:09:46 +0000 (UTC) Received: from ghost-submission-7d8d68f679-tcfrn (unknown [10.111.174.62]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 84B5BC00F3; Sun, 2 Aug 2026 13:09:45 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.112]) by ghost-submission-7d8d68f679-tcfrn with ESMTPSA id 9Lx+DJlBb2rrfyEAU3TobQ (envelope-from ); Sun, 02 Aug 2026 13:09:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-112S0067dc25300-a989-4a04-944e-3b51f6587265, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 01/23] x86/mtrr: get rid of a static variable on pause/restore Date: Sun, 2 Aug 2026 16:09:17 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4727090759001843132 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEtK5p0SNYtBef44Zaajhk33i63wmjVwNNhJ4YROChk7mhZcpyT3bd5ACP3F2TkAykP416Z/qj7tU2KxG1rTRS8MypF1KRhaA/AvmFdmp6hM2n75hgvTPUkRMkZtHtCy5BQJTDAa5dye2uRhTva5lFRUMRQoQfXqDmPkoEsCcMiOXhj8LDb8bxT7fPbPw+L6oM3Ib4+Crk5z3znR8b12WvIauAwvZwi4TwyXrVt8t5cjjf6p6tk/jAP3JPPWAt8lJLbOqKqZPj2dLVv8AcggN/kQjhcbgaHkG9r5s4innAGR9o3gaGzW+PeUVjPnviytxFmoTk+gQnhQiwpJq7s595nq0/dNHg0K5j2/u4togUta8cK/sYD5KBkNvqDKDkP2Mqf4xYNTNh5h0uvCo6u6RAiqKqjL4e/nWsAkN1HVqW7sIR+iMygbzv7AJlPA8cxp2kX69Aw+9xSEw4ne+98yONw9skyGEdzNUs5erSqMJWK+0O3epc5lpnqvRdzUJgb8EZdM7Cj9hXLgC8cB1ndL6HKAHXj/w4ela7PY6shb+FWKaaYztmGPyQyPRNz595AZhT890rNV64MLH8m5m7wkb7aRz5vB7zsXcll1SY3nMQH850SCLiHYo879ix6XTKada1yIneAP3BkZliSYtaUIhs1I/4u3jxLPAyGYlJOtawbAg DKIM-Signature: a=rsa-sha256; bh=45a6v7qxNqaXiQeBDtCOedZ5o8Tq5ypxyrPqCVlyc0I=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676186; v=1; b=J+JpuW0eGrX+12iBiIP2laX8HNfi1XKqWNFnPsu8IXbjqRPbqG9YMw2BQBBiFVZjeVwyUGBM b4/A5yC7Qby8LzofkxEQL1YWPJLqVqZgxrCtxnmuq26Cb1d0twC/1TsMnu8q6KKc1J+H8x3TQDE 4GRy3tXPK+YN41rISv5V1FmA6VaON3Gvszfj+Lh7rSIe0xzOMLhhP3aPKu0NbTrRNmG2VuE99e/ FW4VNGWEn/zGpucfksvt80mBuipCcQadptfdlXWLBUcgeDJPcufB+TIMjVexocUiRaecM3J/E70 LxTzG8efeyM6LTzTAE6AvRjqUW8tEcReZlH2ZlfXzRsdg== X-purgate-ID: tlsNG-16d1c6/1785676186-F420077B-D5098E62/0/0 X-purgate-type: clean X-purgate-size: 5288 In addition to keeping the state in one place instead of on stack and in a static variable, this enables exposing this functionality to other units in the future. Signed-off-by: Sergii Dmytruk --- Notes: v4: was called "x86/mtrr: expose functions for pausing caching" v4: no longer makes anything public, just updates implementation v4: the state structure is now an output parameter instead of a return value v4: switches from rdmsrl() to rdmsr() on one line that's updated anyway xen/arch/x86/cpu/mtrr/generic.c | 55 +++++++++++++++++---------------- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c index 23c279eb9a..86eb0f405b 100644 --- a/xen/arch/x86/cpu/mtrr/generic.c +++ b/xen/arch/x86/cpu/mtrr/generic.c @@ -14,6 +14,11 @@ #include #include "mtrr.h" +struct mtrr_pausing_state { + bool pge; + uint64_t def_type; +}; + static const struct fixed_range_block { uint32_t base_msr; /* start address of an MTRR block */ unsigned int ranges; /* number of MTRRs in this block */ @@ -395,9 +400,7 @@ static bool set_mtrr_var_ranges(unsigned int index, struct mtrr_var_range *vr) return changed; } -static uint64_t deftype; - -static unsigned long set_mtrr_state(void) +static unsigned long set_mtrr_state(uint64_t *deftype) /* [SUMMARY] Set the MTRR state for this CPU. The MTRR state information to read. Some relevant CPU context. @@ -415,14 +418,12 @@ static unsigned long set_mtrr_state(void) if (mtrr_state.have_fixed && set_fixed_ranges(mtrr_state.fixed_ranges)) change_mask |= MTRR_CHANGE_MASK_FIXED; - /* Set_mtrr_restore restores the old value of MTRRdefType, - so to set it we fiddle with the saved value */ - if ((deftype & 0xff) != mtrr_state.def_type - || MASK_EXTR(deftype, MTRRdefType_E) != mtrr_state.enabled - || MASK_EXTR(deftype, MTRRdefType_FE) != mtrr_state.fixed_enabled) { - deftype = (deftype & ~0xcff) | mtrr_state.def_type | - MASK_INSR(mtrr_state.enabled, MTRRdefType_E) | - MASK_INSR(mtrr_state.fixed_enabled, MTRRdefType_FE); + if ((*deftype & 0xff) != mtrr_state.def_type + || MASK_EXTR(*deftype, MTRRdefType_E) != mtrr_state.enabled + || MASK_EXTR(*deftype, MTRRdefType_FE) != mtrr_state.fixed_enabled) { + *deftype = (*deftype & ~0xcff) | mtrr_state.def_type | + MASK_INSR(mtrr_state.enabled, MTRRdefType_E) | + MASK_INSR(mtrr_state.fixed_enabled, MTRRdefType_FE); change_mask |= MTRR_CHANGE_MASK_DEFTYPE; } @@ -439,7 +440,7 @@ static DEFINE_SPINLOCK(set_atomicity_lock); * has been called. */ -static bool prepare_set(void) +static void mtrr_pause_caching(struct mtrr_pausing_state *state) { unsigned long cr4; @@ -461,7 +462,9 @@ static bool prepare_set(void) alternative("wbinvd", "", X86_FEATURE_XEN_SELFSNOOP); cr4 = read_cr4(); - if (cr4 & X86_CR4_PGE) + state->pge = cr4 & X86_CR4_PGE; + + if (state->pge) write_cr4(cr4 & ~X86_CR4_PGE); else if (use_invpcid) invpcid_flush_all(); @@ -469,27 +472,25 @@ static bool prepare_set(void) write_cr3(read_cr3()); /* Save MTRR state */ - rdmsrl(MSR_MTRRdefType, deftype); + state->def_type = rdmsr(MSR_MTRRdefType); /* Disable MTRRs, and set the default type to uncached */ - mtrr_wrmsr(MSR_MTRRdefType, deftype & ~0xcff); + mtrr_wrmsr(MSR_MTRRdefType, state->def_type & ~0xcff); /* Again, only flush caches if we have to. */ alternative("wbinvd", "", X86_FEATURE_XEN_SELFSNOOP); - - return cr4 & X86_CR4_PGE; } -static void post_set(bool pge) +static void mtrr_resume_caching(struct mtrr_pausing_state state) { /* Intel (P6) standard MTRRs */ - mtrr_wrmsr(MSR_MTRRdefType, deftype); + mtrr_wrmsr(MSR_MTRRdefType, state.def_type); /* Enable caches */ write_cr0(read_cr0() & ~X86_CR0_CD); /* Reenable CR4.PGE (also flushes the TLB) */ - if (pge) + if (state.pge) write_cr4(read_cr4() | X86_CR4_PGE); else if (use_invpcid) invpcid_flush_all(); @@ -503,15 +504,15 @@ void mtrr_set_all(void) { unsigned long mask, count; unsigned long flags; - bool pge; + struct mtrr_pausing_state pausing_state; local_irq_save(flags); - pge = prepare_set(); + mtrr_pause_caching(&pausing_state); /* Actually set the state */ - mask = set_mtrr_state(); + mask = set_mtrr_state(&pausing_state.def_type); - post_set(pge); + mtrr_resume_caching(pausing_state); local_irq_restore(flags); /* Use the atomic bitops to update the global mask */ @@ -536,12 +537,12 @@ void mtrr_set( { unsigned long flags; struct mtrr_var_range *vr; - bool pge; + struct mtrr_pausing_state pausing_state; vr = &mtrr_state.var_ranges[reg]; local_irq_save(flags); - pge = prepare_set(); + mtrr_pause_caching(&pausing_state); if (size == 0) { /* The invalid bit is kept in the mask, so we simply clear the @@ -562,7 +563,7 @@ void mtrr_set( mtrr_wrmsr(MSR_IA32_MTRR_PHYSMASK(reg), vr->mask); } - post_set(pge); + mtrr_resume_caching(pausing_state); local_irq_restore(flags); } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380626.1624367 (Exim 4.92) (envelope-from ) id 1wqVxA-00054p-RL; Sun, 02 Aug 2026 13:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380626.1624367; Sun, 02 Aug 2026 13:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxA-00054D-Lm; Sun, 02 Aug 2026 13:10:08 +0000 Received: by outflank-mailman (input) for mailman id 1380626; Sun, 02 Aug 2026 13:10:06 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVx8-0004bl-Bq for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVx7-001xPK-OX for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:05 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4195-5cb7-0a2a0a5109dd-0a2a4506dd12-16 for ; Sun, 02 Aug 2026 15:10:05 +0200 Received: from [87.98.179.142] (helo=17.mo550.mail-out.ovh.net) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41ad-195a-0a2a45060019-5762b38eedc5-3 for ; Sun, 02 Aug 2026 15:10:05 +0200 Received: from director3.ghost.mail-out.ovh.net (unknown [10.110.58.156]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4hCgC10RDWz5yR7 for ; Sun, 2 Aug 2026 13:10:04 +0000 (UTC) Received: from ghost-submission-7d8d68f679-lkzsb (unknown [10.110.178.46]) by director3.ghost.mail-out.ovh.net (Postfix) with ESMTPS id F1632C0A40; Sun, 2 Aug 2026 13:10:03 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.100]) by ghost-submission-7d8d68f679-lkzsb with ESMTPSA id MaIRK6tBb2rqGBgA1y1k7A (envelope-from ); Sun, 02 Aug 2026 13:10:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-100R003147be42b-89d9-414b-ba50-7c1feb6d7b6d, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 07/23] x86/boot: add CONFIG_SLAUNCH, MLE header and Secure Launch entry point Date: Sun, 2 Aug 2026 16:09:23 +0300 Message-ID: <18917d8a445748ba8e997ef71f3172e8f96ed173.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4732157311134148028 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTGce0r1ej7YhDvQcoqZzEJUtCQawdbz8FQcTUZWO9brC0fe8AmOsukA+lpn9eiuqako/+9EHlgkoenIYWl357JWwxZOYEqD7LgSB99mM+zUZBiC7QnYK6FiDOBKtL9EXtmHdYOKWcos3vmqFqx4iL/JYXlSeHTzjkKOlsOppKzx/OjSnRSPfqZj0haS76+HPBGMt4m9UNntAG8pd1aw7UmCIs68THN1JZzkevU8BOUWLkPp7zSSYrTQoWq+4FNfY85nWoc+NuYU0vsYmLoQ/W/xvsOsp1BFgfhCXbO5dG2+akiMePW94isPsGmNCVi75YOYndcrS2F/rDTAxq8iT2SlplevNjvkj9ERWKOYBz3pR+l3PibRWrN+TamsRsDuT41truaT1bY/63Wshns5HHYig9FakelyGKvVyT4loq4LCsm0x2fjWun6wZ0BF7Ce5Ka/7QrRWs/Cjj0VP7UmomxPBa9IMvGoIG+shwW33VPCKjijK8UsTF0Y6lMwucph3JrTIQDLAHHNzvdHPE1qqQ1s39EHC4plsQqZp30WupmrIUK6hqHAnb29G2CzAWCUo+MxeLLAhsCiNLk9dXeNm/uNHQcHUm+c+Hz784luCrLvBIBTe0cf76KO6AC2VjMLVIX1Ji4EMCq/qflLs2E2RwytP1trb8WQxuda1ajVsAZItQ DKIM-Signature: a=rsa-sha256; bh=cFSKQz8f5JDd+KNHvqLRMdQrdK9DDxsbcV/OttzdZYs=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676205; v=1; b=eZSWfAGwHvJHU0enPhMtKBrUHdn0qyBiqANe+N1MybITDguAyRHv+5uxShTp6TtH6jZwOkH9 kyzVzyVJ37yOxVKRiNM1rdz2MES/w1Svxl+imVnC2mpS7egIIDzWVXFYB0Wje0QlcWzv86xy6aj v12D8mGjCqBBDlUOuXxxEJzeNNb6k3N3zKtu9iKz++VMVoxOEu/rHkigTVXHqxNB8HMXcuAB05N sLslbO0iw/Kz0lWG7fwok3e3G2mI9FfuQtrbObZ2H2aH6jx+l79jfzzqI2zG/0csU3cnqMvY2B0 3NaGucJSP9tyEoTqSEZ9xwKTZBwkJ/vHkfqxcYCtcOzkw== X-purgate-ID: tlsNG-16d1c6/1785676205-FDA0C77B-A49DB105/0/0 X-purgate-type: clean X-purgate-size: 8714 From: Kacper Stojek Measured Launched Environment (MLE) is Intel TXT specific term for DLME (Dynamic Launch Measured Environment) which is whatever gets control after DRTM (Dynamic Root of Trust for Measurement) is initiated. DRTM is a way to establish hardware root of trust which excludes firmware and is not directly tied to hardware's boot process (in contrast to static RTM, or SRTM). A bootloader compatible with Secure Launch specification [1] parses MLE header to know how to invoke Xen as MLE/DLME. The header is also processed by SINIT ACM. The new entry point is called `slaunch_stub_entry` and is used mainly to differentiate from other kinds of boots. It moves a magic number to `EAX` before jumping into common startup code. [1]: https://trenchboot.org/specifications/Secure_Launch/ Signed-off-by: Kacper Stojek Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: was "x86/boot: add MLE header and Secure Launch entry point" v4: added CONFIG_SLAUNCH Kconfig option v4: expanded commit message significantly v4: expanded the paragraph added to the documentation v4: SLAUNCH_BOOTLOADER_MAGIC now lives here v4: MLE header size is now computed from labels v4: provided more details in the comment on slaunch_stub_entry v4: handle Slaunch bootloader by just hanging (wasn't handled here in v3) v4: use __base_reloc_end as an end of image instead of _end docs/hypervisor-guide/x86/how-xen-boots.rst | 10 +++ xen/arch/x86/Kconfig | 8 +++ xen/arch/x86/boot/head.S | 76 +++++++++++++++++++++ 3 files changed, 94 insertions(+) diff --git a/docs/hypervisor-guide/x86/how-xen-boots.rst b/docs/hypervisor-guide/x86/how-xen-boots.rst index 8b3229005c..a841d1e9f8 100644 --- a/docs/hypervisor-guide/x86/how-xen-boots.rst +++ b/docs/hypervisor-guide/x86/how-xen-boots.rst @@ -55,6 +55,16 @@ If ``CONFIG_PVH_GUEST`` was selected at build time, an Elf note is included which indicates the ability to use the PVH boot protocol, and registers ``__pvh_start`` as the entrypoint, entered in 32bit mode. +A combination of Multiboot 2 and Measured Launched Environment (MLE) headers +is used to support Dynamic Root of Trust for Measurement (DRTM) for legacy +(BIOS) boot. DRTM is a way to establish hardware root of trust which +excludes firmware and is not directly tied to hardware's boot process. The +separate entry point called ``slaunch_stub_entry`` is used mainly to +differentiate from other kinds of boots. It moves a magic number to ``EAX`` +before jumping into common startup code. More details about Secure Launch +data structures processed by Xen in this boot mode can be found in +``_. + xen.gz ~~~~~~ diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 3ce0774b8d..d8dac2dcfa 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -187,6 +187,14 @@ config TBOOT If unsure, stay with the default. +config SLAUNCH + bool "DRTM via Secure Launch support" + depends on INTEL + default y + help + Allows support for Secure Launch DRTM boot. This is a boot in a + measured environment which requires a compatible bootloader. + config X86_PSR bool "Platform Shared Resource support" if EXPERT default INTEL diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 68b963ce6f..cbf91b23c9 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -4,6 +4,7 @@ #include #include #include +#include #include #include #include @@ -36,6 +37,7 @@ #define MB2_TT(name) (MULTIBOOT2_TAG_TYPE_##name) #define XEN_HVM_START_MAGIC_VALUE 0x336ec578 +#define SLAUNCH_BOOTLOADER_MAGIC 0x4c534254 .macro mb2ht_args arg:req, args:vararg .long \arg @@ -126,6 +128,25 @@ multiboot2_header: .size multiboot2_header, . - multiboot2_header .type multiboot2_header, @object +#if CONFIG_SLAUNCH +SYM(mle_header, DATA, LOCAL, 16) + .long 0x9082ac5a /* UUID0 */ + .long 0x74a7476f /* UUID1 */ + .long 0xa2555c0f /* UUID2 */ + .long 0x42b651cb /* UUID3 */ + .long (.Lmle_header_end - mle_header) /* MLE header size */ + .long 0x00020002 /* MLE version 2.2 */ + .long (slaunch_stub_entry - start) /* Linear entry point of MLE (SINIT virt. address) */ + .long 0x00000000 /* First valid page of MLE */ + .long 0x00000000 /* Offset within binary of first byte of MLE */ + .long (__base_relocs_end - start) /* Offset within binary of last byte + 1 of MLE */ + .long 0x00000723 /* Bit vector of MLE-supported capabilities */ + .long 0x00000000 /* Starting linear address of command line (unused) */ + .long 0x00000000 /* Ending linear address of command line (unused) */ +.Lmle_header_end: + END(mle_header) +#endif + .section .init.rodata, "a", @progbits .Lbad_cpu_msg: .asciz "ERR: Not a 64-bit CPU!" @@ -334,6 +355,43 @@ cs32_switch: /* Jump to earlier loaded address. */ jmp *%edi +#if CONFIG_SLAUNCH + /* + * Entry point for TrenchBoot Secure Launch on Intel TXT platforms. + * + * CPU is in 32b protected mode with paging disabled. On entry: + * - %ebx = %eip = MLE entry point, + * - stack pointer is undefined, + * - CS is flat 4GB code segment, + * - DS, ES, SS, FS and GS are undefined according to TXT SDG, but this + * would make it impossible to initialize GDTR, because GDT base must + * be relocated in the descriptor, which requires write access that + * CS doesn't provide. Instead we have to assume that some data + * segment register is set by SINIT ACM as flat 4GB data segment and + * choose DS as that register (LGDT instruction uses it by default). + * + * Additional restrictions: + * - some MSRs are partially cleared, among them IA32_MISC_ENABLE, so + * some capabilities might be reported as disabled even if they are + * supported by CPU + * - interrupts (including NMIs and SMIs) are disabled and must be + * enabled later + * - trying to enter real mode results in reset + * - APs are in a special SENTER sleep state and must be woken up by + * writing a non-zero value at a MONITORed address or via + * GETSEC[WAKEUP] instruction, depending on which is supported by a + * given SINIT ACM + */ +slaunch_stub_entry: + /* Calculate the load base address. */ + mov %ebx, %esi + sub $sym_offs(slaunch_stub_entry), %esi + + /* Mark Secure Launch boot protocol and jump to common entry. */ + mov $SLAUNCH_BOOTLOADER_MAGIC, %eax + jmp .Lset_stack +#endif /* CONFIG_SLAUNCH */ + #ifdef CONFIG_PVH_GUEST ELFNOTE(Xen, XEN_ELFNOTE_PHYS32_ENTRY, .long sym_offs(__pvh_start)) @@ -373,6 +431,7 @@ __start: /* Restore the clobbered field. */ mov %edx, (%ebx) +.Lset_stack: /* Set up stack. */ lea STACK_SIZE - CPUINFO_sizeof + sym_esi(cpu0_stack), %esp @@ -421,6 +480,12 @@ __start: /* Bootloaders may set multiboot{1,2}.mem_lower to a nonzero value. */ xor %edx,%edx +#if CONFIG_SLAUNCH + /* Check for TrenchBoot slaunch bootloader. */ + cmp $SLAUNCH_BOOTLOADER_MAGIC, %eax + je .Lslaunch_proto +#endif + /* Check for Multiboot2 bootloader. */ cmp $MULTIBOOT2_BOOTLOADER_MAGIC,%eax je .Lmultiboot2_proto @@ -436,6 +501,17 @@ __start: cmovnz MB_mem_lower(%ebx),%edx jmp trampoline_bios_setup +#if CONFIG_SLAUNCH +.Lslaunch_proto: + /* + * Upon reaching here, CPU state mostly matches the one set up by the + * bootloader with ESP, ESI and EDX being clobbered above. + */ + + /* Hang as this boot path is yet to be implemented. */ + jmp .Lslaunch_proto +#endif + .Lmultiboot2_proto: /* Skip Multiboot2 information fixed part. */ lea (MB2_fixed_sizeof+MULTIBOOT2_TAG_ALIGN-1)(%ebx),%ecx -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380628.1624376 (Exim 4.92) (envelope-from ) id 1wqVxD-0005OU-B2; Sun, 02 Aug 2026 13:10:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380628.1624376; Sun, 02 Aug 2026 13:10:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxD-0005OJ-71; Sun, 02 Aug 2026 13:10:11 +0000 Received: by outflank-mailman (input) for mailman id 1380628; Sun, 02 Aug 2026 13:10:09 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxB-0005C8-Cx for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxA-001xPK-PV for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:08 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f417c-5cb7-0a2a0a5109dd-0a2a450494b6-24 for ; Sun, 02 Aug 2026 15:10:08 +0200 Received: from [178.33.45.107] (helo=5.mo550.mail-out.ovh.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41b0-b57f-0a2a45040019-b2212d6ba827-3 for ; Sun, 02 Aug 2026 15:10:08 +0200 Received: from director3.ghost.mail-out.ovh.net (unknown [10.110.58.129]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4hCgC407Bjz5vcd for ; Sun, 2 Aug 2026 13:10:08 +0000 (UTC) Received: from ghost-submission-7d8d68f679-l27qx (unknown [10.110.164.150]) by director3.ghost.mail-out.ovh.net (Postfix) with ESMTPS id EA6A8C087F; Sun, 2 Aug 2026 13:10:06 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.110]) by ghost-submission-7d8d68f679-l27qx with ESMTPSA id FEktLq5Bb2p4JBgA8jA8Vg (envelope-from ); Sun, 02 Aug 2026 13:10:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-110S004cfa44f52-636f-4fe7-84b6-ee1fcc9c9fc6, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Ross Philipson , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , trenchboot-devel@googlegroups.com Subject: [PATCH v4 08/23] include/xen/slr-table.h: Secure Launch Resource Table definitions Date: Sun, 2 Aug 2026 16:09:24 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4733283212314486204 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTFEt9rkYLpJL+cl3MFrtmBH26QPTyhYi9qHrkoiTnaMUtlAY1lwR47UkZfGh/N3kIbPRaT084rWyyj0f2JMoiTIuWk88tOTpqbWD+8hC3sHFIeAIaNwLpfieKAV/oDZeA5fXzWkJ+PufWeKVey7XV+t3gagU0FfqS1GnJw40TdHOt9/zZxCNeNQ1xYrZZk/z9lKt/ZR+fPeb9MX9yw4ylL4i/KvelA7NBtfHURXKRRWfvSctzDm5GYKINzIihhhpAfGKHWkvGkxr+CkOAum/IrGBwxh70xS05ddTJiHy3ZOkrjwYsxmq0h2G1Y4kO2Ig3vOYJzBfxgIKmGVLc7ZkHqbf2qsPN5Rb1vFTaQ5BtV2MoJGLFnn2L/b21tdnnRYR2y7jQOjzFOQ4s1ru9pOgslOIHfSiApTAEuLR+/5XYWGS77z2uSu3JUZrG3CGuGTNWD2PDDLoE3uFtvwUVhICtF1OGUKgVpF5jhXlTUNcQEpcjCy5yrL0z2ppJc+spZybrMTTxK6XgM1UTIkaB9OZiQjBe65tgN8O6j9WCD+1FhVQ8cRQ+lLjLQCVZfRh0hJaadSOGPv2M0r6MSXs14NbcDaO+OYA6TmF+Qpv0YqQJiJVfE9Jwt3GDvNJBfhyctHW+p/5YlLMGzGdOd5T3/SmyUP/obKA5yhXYoMTgnmHA64PA DKIM-Signature: a=rsa-sha256; bh=iSnIQz4NjR9M23iyGWMbP2PkGPiuWCB32F9e/qscvEE=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676208; v=1; b=VRPFLOY95wvJxvGOtSy5r5WNPBoBKAaoYamtPZLswuVOxgHXFbdno3tUHgT6PqCNHuSgb6k9 +5Bo3IXFi7Tdo4ftzm7xqImwreLqKEr4ay33bAI/1SxAx4FmpWtqmV8Ng0ep9li/5GGkoIYRmka 9f4xjSRDZMQDkKzc03b0t06Y4bvcjoo3yuRghUmY+3WEPxptxLzuyDE9QwXNBzjjpKyvyMdKVAH caEmiHsJHO/nYt9JakkZXzqHYc+B3mZrb21TUv6/yo2eiZr+0zjOdjwkcbW6fQeJ0JYUblgS8B9 DonZxSImz7ztBgQZqZDx00BZCOs5LKoQ7N3qd9mVTInVw== X-purgate-ID: tlsNG-ebf023/1785676208-C26CAB50-7D5768F5/0/0 X-purgate-type: clean X-purgate-size: 7668 The file provides constants, structures and several helper functions for parsing SLRT. The data described by the structures is passed to Xen by a bootloader which initiated DRTM. Signed-off-by: Daniel P. Smith Signed-off-by: Ross Philipson Signed-off-by: Sergii Dmytruk --- Notes: v4: don't define UEFI_SLR_TABLE_GUID here, it's specific to UEFI support v4: made pointer parameter of dl_handler_func() constant xen/include/xen/slr-table.h | 272 ++++++++++++++++++++++++++++++++++++ 1 file changed, 272 insertions(+) create mode 100644 xen/include/xen/slr-table.h diff --git a/xen/include/xen/slr-table.h b/xen/include/xen/slr-table.h new file mode 100644 index 0000000000..e3e5eb75f2 --- /dev/null +++ b/xen/include/xen/slr-table.h @@ -0,0 +1,272 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Secure Launch Resource Table definitions. This table is passed to Xen by + * a bootloader and contains information about pre-DRTM state necessary to + * restore hardware configuration, where to find TPM event log, how to call + * back into the bootloader (for EFI case) and what needs to be measured by + * Xen. In other words, this is similar to MBI in Multiboot Specification. + * + * Specification: + * https://trenchboot.org/specifications/Secure_Launch/ + * + * Copyright (c) 2025 Apertus Solutions, LLC + * Copyright (c) 2025 Oracle and/or its affiliates. + * Copyright (c) 2026 3mdeb Sp. z o.o + */ + +#ifndef XEN_SLR_TABLE_H +#define XEN_SLR_TABLE_H + +#include + +/* SLR table header values */ +#define SLR_TABLE_MAGIC 0x4452544d +#define SLR_TABLE_REVISION 1 + +/* Current revisions for the policy and UEFI config */ +#define SLR_POLICY_REVISION 1 +#define SLR_UEFI_CONFIG_REVISION 1 + +/* SLR defined architectures */ +#define SLR_INTEL_TXT 1 +#define SLR_AMD_SKINIT 2 + +/* SLR defined bootloaders */ +#define SLR_BOOTLOADER_INVALID 0 +#define SLR_BOOTLOADER_GRUB 1 + +/* Log formats */ +#define SLR_DRTM_TPM12_LOG 1 +#define SLR_DRTM_TPM20_LOG 2 + +/* DRTM Policy Entry Flags */ +#define SLR_POLICY_FLAG_MEASURED 0x1 +#define SLR_POLICY_IMPLICIT_SIZE 0x2 + +/* Array Lengths */ +#define TPM_EVENT_INFO_LENGTH 32 +#define TXT_VARIABLE_MTRRS_LENGTH 32 + +/* Tags */ +#define SLR_ENTRY_INVALID 0x0000 +#define SLR_ENTRY_DL_INFO 0x0001 +#define SLR_ENTRY_LOG_INFO 0x0002 +#define SLR_ENTRY_DRTM_POLICY 0x0003 +#define SLR_ENTRY_INTEL_INFO 0x0004 +#define SLR_ENTRY_AMD_INFO 0x0005 +#define SLR_ENTRY_ARM_INFO 0x0006 +#define SLR_ENTRY_UEFI_INFO 0x0007 +#define SLR_ENTRY_UEFI_CONFIG 0x0008 +#define SLR_ENTRY_END 0xffff + +/* Entity Types */ +#define SLR_ET_UNSPECIFIED 0x0000 +#define SLR_ET_SLRT 0x0001 +#define SLR_ET_BOOT_PARAMS 0x0002 +#define SLR_ET_SETUP_DATA 0x0003 +#define SLR_ET_CMDLINE 0x0004 +#define SLR_ET_UEFI_MEMMAP 0x0005 +#define SLR_ET_RAMDISK 0x0006 +#define SLR_ET_MULTIBOOT2_INFO 0x0007 +#define SLR_ET_MULTIBOOT2_MODULE 0x0008 +#define SLR_ET_TXT_OS2MLE 0x0010 +#define SLR_ET_UNUSED 0xffff + +/* + * Primary SLR Table Header + */ +struct slr_table +{ + uint32_t magic; + uint16_t revision; + uint16_t architecture; + uint32_t size; + uint32_t max_size; + /* entries[] */ +} __packed; + +/* + * Common SLRT Table Header + */ +struct slr_entry_hdr +{ + uint32_t tag; + uint32_t size; +} __packed; + +/* + * Boot loader context + */ +struct slr_bl_context +{ + uint16_t bootloader; + uint16_t reserved[3]; + uint64_t context; +} __packed; + +/* + * Prototype of a function pointed to by slr_entry_dl_info::dl_handler. + */ +typedef void (*dl_handler_func)(const struct slr_bl_context *bl_context); + +/* + * DRTM Dynamic Launch Configuration + */ +struct slr_entry_dl_info +{ + struct slr_entry_hdr hdr; + uint64_t dce_size; + uint64_t dce_base; + uint64_t dlme_size; + uint64_t dlme_base; + uint64_t dlme_entry; + struct slr_bl_context bl_context; + uint64_t dl_handler; +} __packed; + +/* + * TPM Log Information + */ +struct slr_entry_log_info +{ + struct slr_entry_hdr hdr; + uint16_t format; + uint16_t reserved; + uint32_t size; + uint64_t addr; +} __packed; + +/* + * DRTM Measurement Entry + */ +struct slr_policy_entry +{ + uint16_t pcr; + uint16_t entity_type; + uint16_t flags; + uint16_t reserved; + uint64_t size; + uint64_t entity; + char evt_info[TPM_EVENT_INFO_LENGTH]; +} __packed; + +/* + * DRTM Measurement Policy + */ +struct slr_entry_policy +{ + struct slr_entry_hdr hdr; + uint16_t reserved[2]; + uint16_t revision; + uint16_t nr_entries; + struct slr_policy_entry policy_entries[]; +} __packed; + +/* + * Secure Launch defined MTRR saving structures + */ +struct slr_txt_mtrr_pair +{ + uint64_t mtrr_physbase; + uint64_t mtrr_physmask; +} __packed; + +struct slr_txt_mtrr_state +{ + uint64_t default_mem_type; + uint64_t mtrr_vcnt; + struct slr_txt_mtrr_pair mtrr_pair[TXT_VARIABLE_MTRRS_LENGTH]; +} __packed; + +/* + * Intel TXT Info table + */ +struct slr_entry_intel_info +{ + struct slr_entry_hdr hdr; + uint64_t boot_params_base; + uint64_t txt_heap; + uint64_t saved_misc_enable_msr; + struct slr_txt_mtrr_state saved_bsp_mtrrs; +} __packed; + +/* + * AMD SKINIT Info table + */ +struct slr_entry_amd_info +{ + struct slr_entry_hdr hdr; + uint64_t next; + uint32_t type; + uint32_t len; + uint64_t slrt_size; + uint64_t slrt_base; + uint64_t boot_params_base; + uint16_t psp_version; + uint16_t reserved[3]; +} __packed; + +/* + * UEFI config measurement entry + */ +struct slr_uefi_cfg_entry +{ + uint16_t pcr; + uint16_t reserved; + uint32_t size; + uint64_t cfg; /* address or value */ + char evt_info[TPM_EVENT_INFO_LENGTH]; +} __packed; + +struct slr_entry_uefi_config +{ + struct slr_entry_hdr hdr; + uint16_t reserved[2]; + uint16_t revision; + uint16_t nr_entries; + struct slr_uefi_cfg_entry uefi_cfg_entries[]; +} __packed; + +static inline const void * +slr_end_of_entries(const struct slr_table *table) +{ + return (const void *)table + table->size; +} + +static inline const struct slr_entry_hdr * +slr_next_entry(const struct slr_table *table, const struct slr_entry_hdr *curr) +{ + const struct slr_entry_hdr *next = (void *)curr + curr->size; + + if ( (void *)next + sizeof(*next) > slr_end_of_entries(table) ) + return NULL; + if ( next->tag == SLR_ENTRY_END ) + return NULL; + if ( (void *)next + next->size > slr_end_of_entries(table) ) + return NULL; + + return next; +} + +static inline const struct slr_entry_hdr * +slr_next_entry_by_tag(const struct slr_table *table, + const struct slr_entry_hdr *entry, + uint16_t tag) +{ + if ( !entry ) /* Start from the beginning */ + entry = (void *)table + sizeof(*table); + + for ( ; ; ) + { + if ( entry->tag == tag ) + return entry; + + entry = slr_next_entry(table, entry); + if ( !entry ) + return NULL; + } + + return NULL; +} + +#endif /* XEN_SLR_TABLE_H */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380631.1624386 (Exim 4.92) (envelope-from ) id 1wqVxF-0005hG-Kp; Sun, 02 Aug 2026 13:10:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380631.1624386; Sun, 02 Aug 2026 13:10:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxF-0005gv-Fd; Sun, 02 Aug 2026 13:10:13 +0000 Received: by outflank-mailman (input) for mailman id 1380631; Sun, 02 Aug 2026 13:10:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxE-0005Z5-6e for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxD-001xPK-Jl for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:11 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4195-5cb7-0a2a0a5109dd-0a2a4506dd12-22 for ; Sun, 02 Aug 2026 15:10:11 +0200 Received: from [46.105.41.146] (helo=1.mo575.mail-out.ovh.net) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41b3-195a-0a2a45060019-2e69299290d5-3 for ; Sun, 02 Aug 2026 15:10:11 +0200 Received: from director10.ghost.mail-out.ovh.net (unknown [10.110.43.150]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 4hCgC66llDz5xLM for ; Sun, 2 Aug 2026 13:10:10 +0000 (UTC) Received: from ghost-submission-7d8d68f679-z97vt (unknown [10.108.42.126]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 1481DC0F52; Sun, 2 Aug 2026 13:10:09 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.97]) by ghost-submission-7d8d68f679-z97vt with ESMTPSA id HOPCMbFBb2qckyEA8OaJdQ (envelope-from ); Sun, 02 Aug 2026 13:10:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-97G002759774ff-67e2-4e88-897e-e4d797b01b88, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 09/23] x86/boot/slaunch-early: implement early initialization Date: Sun, 2 Aug 2026 16:09:25 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4733846160438273468 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTGsfQl4qlsgd+N+wAzPmNJTn57cp9N+xnwwaaRrUX/V6epLRbAkTLzIb7MrZYzAgV1mXqxto38PVOV8M1gCRAWNqYLO/9D/7ThxqhtJqfPGAKmZVxIjAM5yEQUhCC6dFnujA3MWREnZFdoQzTCxfJojxKdW5ZChWkOJ9AUQ25O/ECkniAmAiMyzFAzvJZDzqhq14vVGsj761l+whWE5dDh9InBX3k6L+BJwmxnLWn+XkNLVJdB0+nUqxAu4mV0REM3RkTdxePykHWGme39HCkYRWu0q6kGsSu5zbfL/bw71j8mrKZtU3nfWKi+AH44O8zieSUy8MIUD+q1k8bB7ssEPhNfj9OEi9xLqa1+Xt1VA4rfkgRYFTniRTP5m3YgRi0tMQ/SNdSCUr3aq50yJ1wsUWvD3ZP9ohRYBdJdqovqMMY5V7LdxGscZKk+tDmygUb4FRl14qXnTpQIoWchT08ATCom1yDdxGg7+9QrdBEpVKwRmhSj9btO681DQ9bjopyjb33Yy1YMVcbH63TRixsnjW2o15ZxIEIQqKyvJ99fYP40fp0/o60xgFE0KN9l4KWt+qSXagZM76FNocYylod5B3KXJtnH6GBiLeFbYOQ4sRpNZDHYZa9idwh4OnR/w3oaseQKlvT0wxKrXNvPF2PboKj6aiZs1ELlWKcWH393A4A DKIM-Signature: a=rsa-sha256; bh=XpO21I90FRNGjruF0bFEEp2uwv0PGytNt88X2ZMCmZo=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676211; v=1; b=AXUCSSpG9s/N0sPc/aP7QeTc8dNX+hcQaMGZcUZX//cS8twv9vc8pEv+cEqzA7jHbkfTWhan aEUAFbjtMhyuG877a0hfYsoeJ0XfXpji5l0EoVMjYno3TgMNJxdGTIbv0v2RdFJ6ywBUJxhvJiY 666+bupgb1KBT8Ri/szwp8D1DrNMO2qMvoZMzeE458XkNTdQ/aiPyjfH7HmMGvjx6sHu5LRHNbb S6m3EyRTFCIzTLzlttcsMU7HXW7WUKS75kYREyssDywY5fy6fyMgQpCac7nc0jg0OLGYnOv9Kj6 7C6/3aAEVIpNnmiTjXaqjq7G//nVL5sz5mtEJoAQAGBvw== X-purgate-ID: tlsNG-16d1c6/1785676211-1F2C677B-AA1B2DB9/0/0 X-purgate-type: clean X-purgate-size: 11362 Make head.S invoke a C function to retrieve MBI and SLRT addresses in a platform-specific way. This is also the place to perform sanity checks of DRTM. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: use CONFIG_SLAUNCH v4: expose slaunch_early_init_results via asm-offsets.c to not hard-code its size v4: use `mov` instead of `lea` in head.S v4: put SPDX license comment on its own line v4: check that SLRT address is below 4 GiB v4: perform a TXT reset with specific error codes if data doesn't meet expectations v4: replace SLAUNCH_ERROR_GENERIC with specific error codes v4: removed declaration and a reference to otherwise unused slaunch_get_slrt() v4: mark `slaunch_active` variable with `__ro_after_init` v4: updates to the handling of TXT heap sections due to different API xen/arch/x86/Makefile | 1 + xen/arch/x86/boot/Makefile | 12 +++++++- xen/arch/x86/boot/head.S | 35 +++++++++++++++++++-- xen/arch/x86/boot/slaunch-early.c | 46 ++++++++++++++++++++++++++++ xen/arch/x86/include/asm/intel-txt.h | 20 ++++++++++++ xen/arch/x86/include/asm/slaunch.h | 30 ++++++++++++++++++ xen/arch/x86/slaunch.c | 32 +++++++++++++++++++ xen/arch/x86/x86_64/asm-offsets.c | 10 ++++++ 8 files changed, 183 insertions(+), 3 deletions(-) create mode 100644 xen/arch/x86/boot/slaunch-early.c create mode 100644 xen/arch/x86/include/asm/slaunch.h create mode 100644 xen/arch/x86/slaunch.c diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 293f3bee35..a03f5a91ef 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -60,6 +60,7 @@ obj-$(CONFIG_COMPAT) += x86_64/physdev.o obj-$(CONFIG_X86_PSR) += psr.o obj-y += setup.o obj-y += shutdown.o +obj-$(CONFIG_SLAUNCH) += slaunch.o obj-y += smp.o obj-y += smpboot.o obj-y += spec_ctrl.o diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile index feae17c14a..02f690d34a 100644 --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -5,10 +5,18 @@ obj-bin-y += $(obj64) obj32 := cmdline.32.o obj32 += reloc.32.o obj32 += reloc-trampoline.32.o +ifeq ($(CONFIG_SLAUNCH),y) +obj32 += slaunch-early.32.o +endif obj32 += tpm-early.32.o obj64 := reloc-trampoline.o +exports := cmdline_parse_early,reloc,reloc_trampoline32 +ifeq ($(CONFIG_SLAUNCH),y) +exports := $(exports),slaunch_early_init +endif + nocov-y += $(obj32) $(obj64) noubsan-y += $(obj32) $(obj64) targets += $(obj32) @@ -29,6 +37,8 @@ $(obj32): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic $(obj)/%.32.o: $(src)/%.c FORCE $(call if_changed_rule,cc_o_c) +$(obj)/slaunch-early.32.o: XEN_CFLAGS += -D__EARLY_SLAUNCH__ + $(obj)/tpm-early.32.o: XEN_CFLAGS += -D__EARLY_TPM__ $(obj)/tpm-early.32.o: $(src)/../tpm.c FORCE $(call if_changed_rule,cc_o_c) @@ -86,7 +96,7 @@ cmd_combine = \ --bin1 $(obj)/built-in-32.base.bin \ --bin2 $(obj)/built-in-32.offset.bin \ --map $(obj)/built-in-32.base.map \ - --exports cmdline_parse_early,reloc,reloc_trampoline32 \ + --exports $(exports) \ --output $@ targets += built-in-32.S diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index cbf91b23c9..700d1d850e 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -508,8 +508,39 @@ __start: * bootloader with ESP, ESI and EDX being clobbered above. */ - /* Hang as this boot path is yet to be implemented. */ - jmp .Lslaunch_proto + /* Save information that TrenchBoot slaunch was used. */ + movb $1, sym_esi(slaunch_active) + + /* + * Prepare space for output parameter of slaunch_early_init(), which is + * the following structure: + * struct slaunch_early_init_results + * { + * uint32_t mbi_pa; + * uint32_t slrt_pa; + * } __packed; + */ + sub $SL_EIR_size, %esp + + push %esp /* pointer to output structure */ + mov $sym_offs(__2M_rwdata_end), %ecx /* end of target image */ + mov $sym_offs(_start), %edx /* target base address */ + mov %esi, %eax /* load base address */ + /* + * slaunch_early_init(load/eax, tgt/edx, tgt_end/ecx, ret/stk) using + * fastcall calling convention. + */ + call slaunch_early_init + add $4, %esp /* pop the fourth parameter */ + + /* Move outputs of slaunch_early_init() from the stack. */ + pop %ebx /* store physical MBI address in EBX where + MB2 code expects it */ + pop sym_esi(slaunch_slrt) /* save physical address of SLRT for C + code */ + + /* Move magic number expected by Multiboot 2 to EAX and fall through. */ + movl $MULTIBOOT2_BOOTLOADER_MAGIC, %eax #endif .Lmultiboot2_proto: diff --git a/xen/arch/x86/boot/slaunch-early.c b/xen/arch/x86/boot/slaunch-early.c new file mode 100644 index 0000000000..35992cb9b3 --- /dev/null +++ b/xen/arch/x86/boot/slaunch-early.c @@ -0,0 +1,46 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Early Slaunch initialization code responsible for determining location of + * MBI and SLRT and enforcing basic conditions. + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#include +#include +#include + +#include +#include + +void asmlinkage slaunch_early_init(uint32_t load_base_addr, + uint32_t tgt_base_addr, + uint32_t tgt_end_addr, + struct slaunch_early_init_results *result) +{ + void *txt_heap; + const struct txt_os_mle_data *os_mle; + const struct slr_table *slrt; + const struct slr_entry_hdr *entry; + const struct slr_entry_intel_info *intel_info; + + txt_heap = txt_init(); + os_mle = txt_start(txt_heap, TXT_OS2MLE); + + if ( os_mle->slrt & ~0xffffffffULL ) + txt_reset(SLAUNCH_ERROR_BAD_SLRT_ADDRESS); + + result->slrt_pa = os_mle->slrt; + + slrt = (const struct slr_table *)result->slrt_pa; + + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_INTEL_INFO); + if ( entry == NULL ) + txt_reset(SLAUNCH_ERROR_NO_VENDOR_INFO); + + intel_info = container_of(entry, const struct slr_entry_intel_info, hdr); + if ( intel_info->hdr.size != sizeof(*intel_info) ) + txt_reset(SLAUNCH_ERROR_BAD_VENDOR_INFO); + + result->mbi_pa = intel_info->boot_params_base; +} diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h index 15d474f002..dc6c689f1a 100644 --- a/xen/arch/x86/include/asm/intel-txt.h +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -62,6 +62,9 @@ #define SLAUNCH_ERROR_BUFFER_BEYOND_PMR 0xc0008006U #define SLAUNCH_ERROR_HEAP_BAD_OS2MLE 0xc0008007U #define SLAUNCH_ERROR_HEAP_BAD_OS2SINIT 0xc0008008U +#define SLAUNCH_ERROR_NO_VENDOR_INFO 0xc0008009U +#define SLAUNCH_ERROR_BAD_VENDOR_INFO 0xc000800AU +#define SLAUNCH_ERROR_BAD_SLRT_ADDRESS 0xc000800BU #ifndef __ASSEMBLER__ @@ -245,6 +248,23 @@ static inline void *txt_start(void *heap, int table_index) return heap + sizeof(uint64_t); } +static inline void *txt_init(void) +{ + void *txt_heap; + + /* Clear the TXT error register for a clean start of the day. */ + txt_write(TXTCR_ERRORCODE, 0); + + txt_heap = _p(txt_read(TXTCR_HEAP_BASE)); + + if ( txt_size(txt_heap, TXT_OS2MLE) < sizeof(struct txt_os_mle_data) ) + txt_reset(SLAUNCH_ERROR_HEAP_BAD_OS2MLE); + if ( txt_size(txt_heap, TXT_OS2SINIT) < sizeof(struct txt_os_sinit_data) ) + txt_reset(SLAUNCH_ERROR_HEAP_BAD_OS2SINIT); + + return txt_heap; +} + #endif /* !__ASSEMBLER__ */ #endif /* X86_INTEL_TXT_H */ diff --git a/xen/arch/x86/include/asm/slaunch.h b/xen/arch/x86/include/asm/slaunch.h new file mode 100644 index 0000000000..24ba164c0a --- /dev/null +++ b/xen/arch/x86/include/asm/slaunch.h @@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Declarations related to Slaunch (an implementation of a DRTM launch). This + * header is consumed by both normal and early boot code and has to take the + * two environments into account. + * + * More details about Slaunch are available at: + * https://trenchboot.org/specifications/Secure_Launch/ + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#ifndef X86_SLAUNCH_H +#define X86_SLAUNCH_H + +#include + +struct slaunch_early_init_results +{ + uint32_t mbi_pa; + uint32_t slrt_pa; +} __packed; + +/* Indicates an active Secure Launch boot. */ +extern bool slaunch_active; + +/* Holds physical address of SLRT. */ +extern uint32_t slaunch_slrt; + +#endif /* X86_SLAUNCH_H */ diff --git a/xen/arch/x86/slaunch.c b/xen/arch/x86/slaunch.c new file mode 100644 index 0000000000..acf751804f --- /dev/null +++ b/xen/arch/x86/slaunch.c @@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Main Slaunch code used during boot process. + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#include +#include +#include +#include +#include + +#include + +/* + * These variables are assigned to by the code near Xen's entry point. + * + * slaunch_active is not __initdata to allow checking for an active Secure + * Launch boot at any point. + */ +bool __ro_after_init slaunch_active; +uint32_t __initdata slaunch_slrt; /* physical address */ + +/* + * Using slaunch_active in head.S assumes it's a single byte in size, so enforce + * this assumption. + */ +static void __maybe_unused compile_time_checks(void) +{ + BUILD_BUG_ON(sizeof(slaunch_active) != 1); +} diff --git a/xen/arch/x86/x86_64/asm-offsets.c b/xen/arch/x86/x86_64/asm-offsets.c index baf266ab80..f0aaf0f4ba 100644 --- a/xen/arch/x86/x86_64/asm-offsets.c +++ b/xen/arch/x86/x86_64/asm-offsets.c @@ -16,6 +16,9 @@ #include #include #include +#ifdef CONFIG_SLAUNCH +#include +#endif #ifdef CONFIG_VIDEO # include "../boot/video.h" @@ -236,4 +239,11 @@ void __dummy__(void) DEFINE(BVI_size, sizeof(struct boot_video_info)); BLANK(); #endif /* CONFIG_VIDEO */ + +#ifdef CONFIG_SLAUNCH + OFFSET(SL_EIR_mbi_pa, struct slaunch_early_init_results, mbi_pa); + OFFSET(SL_EIR_slrt_pa, struct slaunch_early_init_results, slrt_pa); + DEFINE(SL_EIR_size, sizeof(struct slaunch_early_init_results)); + BLANK(); +#endif } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380634.1624394 (Exim 4.92) (envelope-from ) id 1wqVxI-0006Bx-Uh; Sun, 02 Aug 2026 13:10:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380634.1624394; Sun, 02 Aug 2026 13:10:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxI-0006Bl-RA; Sun, 02 Aug 2026 13:10:16 +0000 Received: by outflank-mailman (input) for mailman id 1380634; Sun, 02 Aug 2026 13:10:15 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxH-0005zZ-B3 for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxG-001lF1-OE for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:14 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4178-e002-0a2a0a5209dd-0a2a450adcca-20 for ; Sun, 02 Aug 2026 15:10:14 +0200 Received: from [178.33.253.128] (helo=13.mo550.mail-out.ovh.net) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41b6-f2d2-0a2a450a0019-b221fd8086dd-3 for ; Sun, 02 Aug 2026 15:10:14 +0200 Received: from director2.ghost.mail-out.ovh.net (unknown [10.109.249.53]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4hCgC96FF6z5vqC for ; Sun, 2 Aug 2026 13:10:13 +0000 (UTC) Received: from ghost-submission-7d8d68f679-fpgjl (unknown [10.110.188.109]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 21233C0C02; Sun, 2 Aug 2026 13:10:12 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.110]) by ghost-submission-7d8d68f679-fpgjl with ESMTPSA id 3QscMLRBb2oQFhcAmIgvlw (envelope-from ); Sun, 02 Aug 2026 13:10:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-110S00492330883-8e1e-4041-880f-17e41b1ce3ec, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Ross Philipson , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 10/23] x86/boot/slaunch-early: early Intel TXT sanity checks Date: Sun, 2 Aug 2026 16:09:26 +0300 Message-ID: <474ab4540b1b78a818f873e77b29e586c37cedfd.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4734690583935657404 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEtK5p0SNYtBef44Zaajhk33i63wmjVwNNhJ4YROChk7mhZcpyT3bd5ACP3F2TkAykP416Z/qj7tU2KxG1rTRS8MypF1KRhaA/AvmFdmp6hM2n75hgvTPUkRMkZtHtCy5BQJTDAa5dye2uRhTva5lFRUMRQoQfXqDmPkoEsCcMiOXhj8LDb8bxT7fPbPw+L6oM3Ib4+Crk5z3znR8b12WvIauAwvZwi4TwyXrVt8t5cjjf6p6tk/jAP3JPPWAt8lJLbOqKqZPj2dLVv8AcggN/kQjhcbgaHkG9r5s4innAGR9o3gaGzW+PeUVjPnviytxFmoTk+gQnhQiwpJq7s595nR3i4f5Pd9uZjZZwp5dja8ThsJAWAqSi0Ji08ZzRSfvsKevsf4lI4r3AceU0+TOjsi8cfX9Ebz4U0JdUYHwuqIjjMujsfCM+CX3cvqBTAbRdRyYCD/REj1KlkgZzpr6PNcpnwBs/LOoWYORw4Z8m2KbbvJzyNsm49G9kv8LDYod6P9Tz6d3frSOvoD11isMQR94DHI8J0bdj/w01vBfslM8X2Z1FiphvHWr0lNUC/9fLVawzXhoaLkn9H6Z/SPWG6PTjnKx4TBwruKEnmHdzSjgOB3YOwi5RRvh1zWQGOH71mFymbSEgJG0UmOh6cw2ozzDu2itvychXQUm0N0LyHzw DKIM-Signature: a=rsa-sha256; bh=PcPWVqGwirde0tITg3pYCTNlAzedu0RLv0kvrhdujRg=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676213; v=1; b=ZQnx8jMMOt5aRGygMY3FWyn00QnqOqGrQv503Y2hK16qP/Fb8WVYwjf4y6LRjEgRlgVZsJA7 uVI3jjkOFa/vbo/lATiX9Kjlvjl4F7S1hCmxTbWlyFJyN13dzrGz+IIqvFZxHjXefRIsj+slQwR JNWkvoscfZSgiPBEYR1xfIWxk+79Q43LH1HDiAOHB8bGKN0mjxLl9/SPPGbv2XXTu/aXG8w67IE CQbNbNRwS2ueSJFLejAd8lWkXmSf85FRfRSpxbI9Ro7Q0tPoBbz6RA4QNSyDvELly0guOYLAGri bGq8gGyZfrxK3yT9O0pIZKHdOp/5Yv3Izd0ofv9pE0l/Q== X-purgate-ID: tlsNG-4011c0/1785676214-599C1CFC-519EFD12/0/0 X-purgate-type: clean X-purgate-size: 8036 From: Krystian Hebel The tests validate that important parts of memory are protected against DMA attacks, including Xen and MBI. Modules can be tested later, when it is possible to report issues to a user before invoking TXT reset. The protection used here is Protected Memory Regions (PMRs), which is not available on modern hardware like MeteorLake that uses TXT DMA Protection Ranges (TPR) and is to be added separately. TPM event log validation is temporarily disabled due to an issue with its allocation by bootloader (GRUB) which will need to be modified to address this. Ultimately event log will also have to be validated early as it is used immediately after these tests to hold MBI measurements. See larger comment in txt_verify_pmr_ranges(). Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: was "x86/boot/slaunch-early: early TXT checks and boot data retrieval" v4: updates to the handling of TXT heap sections due to different API v4: use `bool` instead of `int` in two places v4: don't use low range in is_in_pmr(), it must be zero v4: use `struct multiboot2_fixed_t` instead of casting and dereferencing `uint32_t *` v4: TPM event log check being covered by PMR can't be safely uncommented without constraining where TPM event log is allocated xen/arch/x86/boot/slaunch-early.c | 6 ++ xen/arch/x86/include/asm/intel-txt.h | 118 +++++++++++++++++++++++++++ 2 files changed, 124 insertions(+) diff --git a/xen/arch/x86/boot/slaunch-early.c b/xen/arch/x86/boot/slaunch-early.c index 35992cb9b3..00c772cfdf 100644 --- a/xen/arch/x86/boot/slaunch-early.c +++ b/xen/arch/x86/boot/slaunch-early.c @@ -21,11 +21,14 @@ void asmlinkage slaunch_early_init(uint32_t load_base_addr, void *txt_heap; const struct txt_os_mle_data *os_mle; const struct slr_table *slrt; + const struct txt_os_sinit_data *os_sinit; const struct slr_entry_hdr *entry; const struct slr_entry_intel_info *intel_info; + uint32_t size = tgt_end_addr - tgt_base_addr; txt_heap = txt_init(); os_mle = txt_start(txt_heap, TXT_OS2MLE); + os_sinit = txt_start(txt_heap, TXT_OS2SINIT); if ( os_mle->slrt & ~0xffffffffULL ) txt_reset(SLAUNCH_ERROR_BAD_SLRT_ADDRESS); @@ -43,4 +46,7 @@ void asmlinkage slaunch_early_init(uint32_t load_base_addr, txt_reset(SLAUNCH_ERROR_BAD_VENDOR_INFO); result->mbi_pa = intel_info->boot_params_base; + + txt_verify_pmr_ranges(os_mle, os_sinit, intel_info, + load_base_addr, tgt_base_addr, size); } diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h index dc6c689f1a..66039dbeee 100644 --- a/xen/arch/x86/include/asm/intel-txt.h +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -68,6 +68,9 @@ #ifndef __ASSEMBLER__ +#include +#include + /* Need to differentiate between pre- and post paging enabled. */ #ifdef __EARLY_SLAUNCH__ #include @@ -265,6 +268,121 @@ static inline void *txt_init(void) return txt_heap; } +static inline bool is_in_pmr(const struct txt_os_sinit_data *os_sinit, + uint64_t base, uint32_t size, bool check_high) +{ + /* Check for size overflow. */ + if ( base + size < base ) + txt_reset(SLAUNCH_ERROR_INTEGER_OVERFLOW); + + /* + * txt_verify_pmr_ranges() makes sure the low range always starts at 0, so + * its size is also end address. + */ + if ( base + size <= os_sinit->vtd_pmr_lo_size ) + return true; + + if ( check_high && os_sinit->vtd_pmr_hi_size != 0 ) + { + if ( base >= os_sinit->vtd_pmr_hi_base && + base + size <= os_sinit->vtd_pmr_hi_base + + os_sinit->vtd_pmr_hi_size ) + return true; + } + + return false; +} + +static inline void txt_verify_pmr_ranges( + const struct txt_os_mle_data *os_mle, + const struct txt_os_sinit_data *os_sinit, + const struct slr_entry_intel_info *info, + uint32_t load_base_addr, + uint32_t tgt_base_addr, + uint32_t xen_size) +{ + bool check_high_pmr = false; + + /* Verify the value of the low PMR base. It should always be 0. */ + if ( os_sinit->vtd_pmr_lo_base != 0 ) + txt_reset(SLAUNCH_ERROR_LO_PMR_BASE); + + /* + * Low PMR size should not be 0 on current platforms. There is an ongoing + * transition to TPR-based DMA protection instead of PMR-based; this is not + * yet supported by the code. + */ + if ( os_sinit->vtd_pmr_lo_size == 0 ) + txt_reset(SLAUNCH_ERROR_LO_PMR_SIZE); + + /* Check if regions overlap. Treat regions with no hole between as error. */ + if ( os_sinit->vtd_pmr_hi_size != 0 && + os_sinit->vtd_pmr_hi_base <= os_sinit->vtd_pmr_lo_size ) + txt_reset(SLAUNCH_ERROR_HI_PMR_BASE); + + /* Check for size overflow. */ + if ( os_sinit->vtd_pmr_hi_base + os_sinit->vtd_pmr_hi_size < + os_sinit->vtd_pmr_hi_size ) + txt_reset(SLAUNCH_ERROR_INTEGER_OVERFLOW); + + /* All regions accessed by 32b code must be below 4G. */ + if ( os_sinit->vtd_pmr_hi_base + os_sinit->vtd_pmr_hi_size <= + 0x100000000ULL ) + check_high_pmr = true; + + /* + * ACM checks that TXT heap and MLE memory is protected against DMA. We have + * to check if MBI and whole Xen memory is protected. The latter is done in + * case bootloader failed to set whole image as MLE and to make sure that + * both pre- and post-relocation code is protected. + */ + + /* Check if all of Xen before relocation is protected. */ + if ( !is_in_pmr(os_sinit, load_base_addr, xen_size, check_high_pmr) ) + txt_reset(SLAUNCH_ERROR_LO_PMR_MLE); + + /* Check if all of Xen after relocation is protected. */ + if ( load_base_addr != tgt_base_addr && + !is_in_pmr(os_sinit, tgt_base_addr, xen_size, check_high_pmr) ) + txt_reset(SLAUNCH_ERROR_LO_PMR_MLE); + + /* If present, check that MBI is protected. */ + if ( info->boot_params_base != 0 ) + { + const multiboot2_fixed_t *mbi = + (const multiboot2_fixed_t *)(uintptr_t)info->boot_params_base; + + if ( !is_in_pmr(os_sinit, info->boot_params_base, mbi->total_size, + check_high_pmr) ) + txt_reset(SLAUNCH_ERROR_BUFFER_BEYOND_PMR); + } + + /* Check if TPM event log (if present) is protected. */ + /* + * FIXME: currently commented out as GRUB allocates it in a hole between + * PMR and reserved RAM, due to 2MB resolution of PMR. There are no other + * easy-to-use DMA protection mechanisms that would allow to protect that + * part of memory. TPR (TXT DMA Protection Range) gives 1MB resolution, but + * it still wouldn't be enough. + * + * One possible solution would be for GRUB to allocate log at lower address, + * but this would further increase memory space fragmentation. Another + * option is to align PMR up instead of down, making PMR cover part of + * reserved region, but it is unclear what the consequences may be. + * + * In tboot this issue was resolved by reserving leftover chunks of memory + * in e820 and/or UEFI memory map. This is also a valid solution, but would + * require more changes to GRUB than the ones listed above, as event log is + * allocated much earlier than PMRs. + */ + /* + if ( os_mle->evtlog_addr != 0 && os_mle->evtlog_size != 0 && + !is_in_pmr(os_sinit, os_mle->evtlog_addr, os_mle->evtlog_size, + check_high_pmr) ) + txt_reset(SLAUNCH_ERROR_BUFFER_BEYOND_PMR); + */ +} + #endif /* !__ASSEMBLER__ */ #endif /* X86_INTEL_TXT_H */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380641.1624402 (Exim 4.92) (envelope-from ) id 1wqVxL-0006by-Cu; Sun, 02 Aug 2026 13:10:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380641.1624402; Sun, 02 Aug 2026 13:10:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxL-0006bP-6z; Sun, 02 Aug 2026 13:10:19 +0000 Received: by outflank-mailman (input) for mailman id 1380641; Sun, 02 Aug 2026 13:10:18 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxK-0006RK-2p for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxJ-004d7k-Fw for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:17 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f41b9-2eae-0a2a0a5409dd-0a2a450c80ea-0 for ; Sun, 02 Aug 2026 15:10:17 +0200 Received: from [46.105.74.219] (helo=8.mo575.mail-out.ovh.net) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41b8-f479-0a2a450c0019-2e694adbc0eb-3 for ; Sun, 02 Aug 2026 15:10:17 +0200 Received: from director5.ghost.mail-out.ovh.net (unknown [10.110.43.172]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCD45f2z5xnT for ; Sun, 2 Aug 2026 13:10:16 +0000 (UTC) Received: from ghost-submission-7d8d68f679-8bsrl (unknown [10.110.168.242]) by director5.ghost.mail-out.ovh.net (Postfix) with ESMTPS id CDFA1100020; Sun, 2 Aug 2026 13:10:15 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.103]) by ghost-submission-7d8d68f679-8bsrl with ESMTPSA id KMrpJ7dBb2ovoRcAxLjVHw (envelope-from ); Sun, 02 Aug 2026 13:10:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-103G0052a2b29ed-d934-4988-9f63-b340be87dd25, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 11/23] xen/arch/x86: reserve TXT memory during Slaunch Date: Sun, 2 Aug 2026 16:09:27 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4735535011450856892 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEO37Lm1soAj3J6HJwxZueJ91jNrKiCMD9VOxO+7S6oZcwX5ZhHy/rf+u1q3gsSFBR0MQ0G/W66mTSt5xumJoxY/EyDpxdVBT5aAA1fHupbW88f/IumzeClwwf3PGe5NCfIC4rAkaw9D49zl0L3FOqYw1yebY9XQZPEoEgqOhxU7iAITzoi4rSZJugXTxFrfgz5z3QYtYzrLSr0w464iDE2Jv+mfsQyDLbPqlC9XEGpFu9KBxFx07+KPXWsR6kr02Tgk2fJ3ulvjdiKijPJd2EPMcqID96OcOqj/uCF/V+6MYDFkW6NlVR5eWMFf+caoPBoCiQxHguJ/BWn2Nt+/d7LCTI8eZJ2PVPqJ7R8r1mCMC874y8TvUY4M3E5jUoLAVE92BrDMfCwD48x3utzTTcexOR9Bx9x4MyG58wNKd5h8O8hWBBDpa8KSJLI0wXoyZHNC6pc/ie7fI+F2C3sxjR+KTuQikp/85T6/dq1yLgeBQidpuPF2pETuFe98x0fjC/ChtI1BR+vPxkotFj4rn09yBLXYsTnJra1sfkfpZC4sVDaBw+bAtvAz3yLuk6LDSjyqziy3R1rxorXgxTV38bZnkZ4cktHL0GOqNKMo5QZddfKRMnJrujEzRCHegUa1ARbvEMYx1244SmrQErwTYH0WxDfg0O+0SFfGgWZWqnIwQ DKIM-Signature: a=rsa-sha256; bh=iPbTspJ5mXNctv1oIOt0yeLZOD025ha+qDyeKfpyWXs=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676216; v=1; b=I4i+fsJg33Yz99ooQCcPzl3BDXMYnweU+/4I/SsQhJ13lbeMvHXtnDVEgSP0JIWCwUCvVZDb 7No1vFQL/kz2gsw8Nt5iuUun/kc/DCzaJWQ6+IjCtbQJsCqKRLz1k9Hop6ymCVIbmnpNo+8jmo8 A0f2Cu+5vFyF1xJsH5/SDx8LzKa8LSrFncJ+ZrMg70ZkV4YXCAPIzTaLGVAe8IBJ0xVdFv9fEld 7S5um5rFb4DbUSryB9S4A9s9HFHFct7JvO579pIV/BuiE7zMxNvNHfhPMn7HsCGr/3sVXCQR1Bd eW8bhkNik8f/VpJlRlGLP1XWmC5i6oWmCS6iwOAyBLkWQ== X-purgate-ID: tlsNG-d25034/1785676217-774D7A5B-FE099550/0/0 X-purgate-type: clean X-purgate-size: 16017 From: Kacper Stojek TXT heap, SINIT and TXT private space are marked as reserved or unused in e820 to protect from unintended uses. Signed-off-by: Kacper Stojek Signed-off-by: Krystian Hebel Signed-off-by: Michał Żygowski Signed-off-by: Sergii Dmytruk --- Notes: v4: use CONFIG_SLAUNCH v4: use unsigned long constant in PREBUILT_MAP_LIMIT #define v4: add slaunch-tpm unit for TPM-related code specific to Slaunch (builds as normal and early code) v4: slaunch_get_slrt() now makes its first appearance in this commit v4: slaunch_find_log() is now defined in slaunch-tpm.c v4: improved signature and comment for slaunch_map_l2() v4: moved SPDX license comments to their own lines v4: reduced txt_heap_base and txt_heap_size from 64-bit to 32-bit v4: changed reserve_ram() to return bool and not take type (it's always the same) and skip already reserved memory v4: switch from "(from - to)" ranges to "[from, to)" in prints v4: verify that slaunch_map_l2() was passed a range below 4 GiB v4: move PREBUILT_MAP_LIMIT from asm/mm.h to asm/setup.h xen/arch/x86/Makefile | 2 + xen/arch/x86/include/asm/intel-txt.h | 6 ++ xen/arch/x86/include/asm/setup.h | 3 + xen/arch/x86/include/asm/slaunch-tpm.h | 19 +++++ xen/arch/x86/include/asm/slaunch.h | 34 +++++++- xen/arch/x86/intel-txt.c | 113 +++++++++++++++++++++++++ xen/arch/x86/setup.c | 10 ++- xen/arch/x86/slaunch-tpm.c | 36 ++++++++ xen/arch/x86/slaunch.c | 105 ++++++++++++++++++++++- 9 files changed, 323 insertions(+), 5 deletions(-) create mode 100644 xen/arch/x86/include/asm/slaunch-tpm.h create mode 100644 xen/arch/x86/intel-txt.c create mode 100644 xen/arch/x86/slaunch-tpm.c diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index a03f5a91ef..8dbb76a3a0 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -42,6 +42,7 @@ obj-y += i387.o obj-y += i8259.o obj-$(CONFIG_INDIRECT_THUNK) += indirect-thunk.o obj-$(CONFIG_RETURN_THUNK) += indirect-thunk.o +obj-$(CONFIG_SLAUNCH) += intel-txt.o obj-$(CONFIG_PV) += ioport_emulate.o obj-y += io_apic.o obj-y += irq.o @@ -61,6 +62,7 @@ obj-$(CONFIG_X86_PSR) += psr.o obj-y += setup.o obj-y += shutdown.o obj-$(CONFIG_SLAUNCH) += slaunch.o +obj-$(CONFIG_SLAUNCH) += slaunch-tpm.o obj-y += smp.o obj-y += smpboot.o obj-y += spec_ctrl.o diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h index 66039dbeee..db6b0defd0 100644 --- a/xen/arch/x86/include/asm/intel-txt.h +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -383,6 +383,12 @@ static inline void txt_verify_pmr_ranges( */ } +/* Prepares for accesses to TXT-specific memory. */ +void txt_map_mem_regions(void); + +/* Marks TXT-specific memory as used to avoid its corruption. */ +void txt_reserve_mem_regions(void); + #endif /* !__ASSEMBLER__ */ #endif /* X86_INTEL_TXT_H */ diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index b01e83a8ed..431c0a26b5 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -4,6 +4,9 @@ #include #include +/* How much of the directmap is prebuilt at compile time. */ +#define PREBUILT_MAP_LIMIT (1UL << L2_PAGETABLE_SHIFT) + extern const char __2M_text_start[], __2M_text_end[]; extern const char __2M_rodata_start[], __2M_rodata_end[]; extern char __2M_init_start[], __2M_init_end[]; diff --git a/xen/arch/x86/include/asm/slaunch-tpm.h b/xen/arch/x86/include/asm/slaunch-tpm.h new file mode 100644 index 0000000000..68e9c8358a --- /dev/null +++ b/xen/arch/x86/include/asm/slaunch-tpm.h @@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * TPM-related functions of Slaunch. Can be used in both normal and early boot + * environments. + * + * Copyright (c) 2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#ifndef X86_SLAUNCH_TPM_H +#define X86_SLAUNCH_TPM_H + +#include + +struct slr_table; + +void slaunch_find_log(const struct slr_table *slrt, paddr_t *evt_log, + uint32_t *evt_log_size); + +#endif /* X86_SLAUNCH_TPM_H */ diff --git a/xen/arch/x86/include/asm/slaunch.h b/xen/arch/x86/include/asm/slaunch.h index 24ba164c0a..3df7174b4b 100644 --- a/xen/arch/x86/include/asm/slaunch.h +++ b/xen/arch/x86/include/asm/slaunch.h @@ -13,6 +13,8 @@ #ifndef X86_SLAUNCH_H #define X86_SLAUNCH_H +#include +#include #include struct slaunch_early_init_results @@ -24,7 +26,37 @@ struct slaunch_early_init_results /* Indicates an active Secure Launch boot. */ extern bool slaunch_active; -/* Holds physical address of SLRT. */ +/* + * Holds physical address of SLRT. Use slaunch_get_slrt() to access SLRT + * instead of mapping where this points to. + */ extern uint32_t slaunch_slrt; +/* + * Retrieves pointer to SLRT. Checks table's validity and maps it as necessary. + */ +struct slr_table *slaunch_get_slrt(void); + +/* + * Prepares for accesses to essential data structures setup by boot environment. + */ +void slaunch_map_mem_regions(void); + +/* Marks regions of memory as used to avoid their corruption. */ +void slaunch_reserve_mem_regions(void); + +/* + * This helper function is used to map memory below 4 GiB using L2 page tables + * by aligning mapped regions to 2MB. This way page allocator (which at this + * point isn't yet initialized) isn't needed for creating new L1 mappings. The + * function also checks and skips memory already mapped by the prebuilt tables. + * + * There is no unmap_l2() because the function is meant to be used by the code + * that accesses DRTM-related memory soon after which Xen rebuilds memory maps, + * effectively dropping all existing mappings. + * + * Returns zero on success. + */ +int slaunch_map_l2(paddr_t paddr, size_t size); + #endif /* X86_SLAUNCH_H */ diff --git a/xen/arch/x86/intel-txt.c b/xen/arch/x86/intel-txt.c new file mode 100644 index 0000000000..4a42abf8df --- /dev/null +++ b/xen/arch/x86/intel-txt.c @@ -0,0 +1,113 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Functions related to DRTM on Intel using its TXT (Trusted eXecution + * Technology). + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#include +#include +#include +#include +#include +#include +#include + +/* + * Corresponding TXT registers seem to have 64-bits allocated for them, yet the + * actual values are 32-bit long, so using the latter. + */ +static uint32_t __initdata txt_heap_base, txt_heap_size; + +void __init txt_map_mem_regions(void) +{ + int rc; + + rc = slaunch_map_l2(TXT_PRIV_CONFIG_REGS_BASE, TXT_CONFIG_SPACE_SIZE); + BUG_ON(rc != 0); + + txt_heap_base = txt_read(TXTCR_HEAP_BASE); + BUG_ON(txt_heap_base == 0); + + txt_heap_size = txt_read(TXTCR_HEAP_SIZE); + BUG_ON(txt_heap_size == 0); + + rc = slaunch_map_l2(txt_heap_base, txt_heap_size); + BUG_ON(rc != 0); +} + +/* Mark a RAM region as reserved if it isn't marked that way already. */ +static bool __init reserve_ram(struct e820map *map, uint64_t start, + uint64_t end) +{ + unsigned int i; + + for ( i = 0; i < map->nr_map; i++ ) + { + uint64_t rs = map->map[i].addr; + uint64_t re = rs + map->map[i].size; + + /* The entry includes the range. */ + if ( start >= rs && end <= re ) + break; + + /* The entry intersects the range. */ + if ( end > rs && start < re ) + { + /* Fatal failure. */ + return false; + } + } + + /* + * If the range is not included by any entry and no entry intersects it, + * then it's not listed in the memory map. Consider this case as a success + * since we're only preventing RAM from being used and unlisted range should + * not be used. + */ + if ( i == map->nr_map ) + return true; + + /* + * e820_change_range_type() fails if the range is already marked with the + * desired type. Don't consider it an error if firmware has done it for us. + */ + if ( map->map[i].type == E820_RESERVED ) + return true; + + return e820_change_range_type(map, start, end, E820_RAM, E820_RESERVED); +} + +void __init txt_reserve_mem_regions(void) +{ + bool ok; + uint32_t sinit_base, sinit_size; + + /* TXT Heap */ + BUG_ON(txt_heap_base == 0); + printk("SLAUNCH: reserving TXT heap range [%#x, %#x)\n", txt_heap_base, + txt_heap_base + txt_heap_size); + ok = reserve_ram(&e820_raw, txt_heap_base, txt_heap_base + txt_heap_size); + BUG_ON(!ok); + + sinit_base = txt_read(TXTCR_SINIT_BASE); + BUG_ON(sinit_base == 0); + + sinit_size = txt_read(TXTCR_SINIT_SIZE); + BUG_ON(sinit_size == 0); + + /* SINIT */ + printk("SLAUNCH: reserving SINIT memory range [%#x, %#x)\n", sinit_base, + sinit_base + sinit_size); + ok = reserve_ram(&e820_raw, sinit_base, sinit_base + sinit_size); + BUG_ON(!ok); + + /* TXT Private Space */ + printk("SLAUNCH: reserving private TXT registers range [%#x, %#x)\n", + TXT_PRIV_CONFIG_REGS_BASE, + TXT_PRIV_CONFIG_REGS_BASE + TXT_CONFIG_SPACE_SIZE); + ok = reserve_ram(&e820_raw, TXT_PRIV_CONFIG_REGS_BASE, + TXT_PRIV_CONFIG_REGS_BASE + TXT_CONFIG_SPACE_SIZE); + BUG_ON(!ok); +} diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 7d71fea6c0..5494fa1621 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -50,6 +50,7 @@ #include #include #include +#include #include #include #include @@ -1128,9 +1129,6 @@ static struct domain *__init create_dom0(struct boot_info *bi) return d; } -/* How much of the directmap is prebuilt at compile time. */ -#define PREBUILT_MAP_LIMIT (1 << L2_PAGETABLE_SHIFT) - void asmlinkage __init noreturn __start_xen(void) { const char *memmap_type = NULL; @@ -1472,6 +1470,12 @@ void asmlinkage __init noreturn __start_xen(void) #endif } + if ( slaunch_active ) + { + slaunch_map_mem_regions(); + slaunch_reserve_mem_regions(); + } + /* Sanitise the raw E820 map to produce a final clean version. */ max_page = raw_max_page = init_e820(memmap_type, &e820_raw); diff --git a/xen/arch/x86/slaunch-tpm.c b/xen/arch/x86/slaunch-tpm.c new file mode 100644 index 0000000000..f59170594d --- /dev/null +++ b/xen/arch/x86/slaunch-tpm.c @@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Slaunch functions related to TPM. + * + * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. + */ + +#include +#include +#include + +void slaunch_find_log(const struct slr_table *slrt, paddr_t *evt_log, + uint32_t *evt_log_size) +{ + const struct slr_entry_hdr *hdr; + + hdr = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_LOG_INFO); + if ( hdr != NULL ) + { + const struct slr_entry_log_info *log_info; + log_info = container_of(hdr, const struct slr_entry_log_info, hdr); + + *evt_log = (uintptr_t)_p(log_info->addr); + *evt_log_size = log_info->size; + } + else + { + /* + * Event log is used to verify measurements, but values of PCRs is the + * real authoritative source of information, so keep going if there is + * no log as secrets may still be correctly unsealed by TPM. + */ + *evt_log = 0; + *evt_log_size = 0; + } +} diff --git a/xen/arch/x86/slaunch.c b/xen/arch/x86/slaunch.c index acf751804f..ba1ba61c47 100644 --- a/xen/arch/x86/slaunch.c +++ b/xen/arch/x86/slaunch.c @@ -7,11 +7,17 @@ #include #include -#include #include +#include #include +#include +#include +#include +#include +#include #include +#include /* * These variables are assigned to by the code near Xen's entry point. @@ -30,3 +36,100 @@ static void __maybe_unused compile_time_checks(void) { BUILD_BUG_ON(sizeof(slaunch_active) != 1); } + +struct slr_table *__init slaunch_get_slrt(void) +{ + static struct slr_table *__initdata slrt; + + if ( slrt == NULL ) + { + int rc; + + slrt = __va(slaunch_slrt); + + rc = slaunch_map_l2(slaunch_slrt, PAGE_SIZE); + BUG_ON(rc != 0); + + if ( slrt->magic != SLR_TABLE_MAGIC ) + panic("SLRT has invalid magic value: %#x!\n", slrt->magic); + /* XXX: are newer revisions allowed? */ + if ( slrt->revision != SLR_TABLE_REVISION ) + panic("SLRT is of unsupported revision: %#x!\n", slrt->revision); + if ( slrt->architecture != SLR_INTEL_TXT ) + panic("SLRT is for unexpected architecture: %#x!\n", + slrt->architecture); + if ( slrt->size > slrt->max_size ) + panic("SLRT is larger than its max size: %#x > %#x!\n", + slrt->size, slrt->max_size); + + if ( slrt->size > PAGE_SIZE ) + { + rc = slaunch_map_l2(slaunch_slrt, slrt->size); + BUG_ON(rc != 0); + } + } + + return slrt; +} + +void __init slaunch_map_mem_regions(void) +{ + int rc; + paddr_t evt_log_addr; + uint32_t evt_log_size; + + /* Vendor-specific part. */ + txt_map_mem_regions(); + + slaunch_find_log(slaunch_get_slrt(), &evt_log_addr, &evt_log_size); + if ( evt_log_addr != 0 ) + { + rc = slaunch_map_l2(evt_log_addr, evt_log_size); + BUG_ON(rc != 0); + } +} + +void __init slaunch_reserve_mem_regions(void) +{ + paddr_t evt_log_addr; + uint32_t evt_log_size; + + /* Vendor-specific part. */ + txt_reserve_mem_regions(); + + slaunch_find_log(slaunch_get_slrt(), &evt_log_addr, &evt_log_size); + if ( evt_log_addr != 0 ) + { + int ok; + + printk("SLAUNCH: reserving event log [%#lx, %#lx)\n", evt_log_addr, + evt_log_addr + evt_log_size); + ok = reserve_e820_ram(&e820_raw, evt_log_addr, + evt_log_addr + evt_log_size); + BUG_ON(!ok); + } +} + +int __init slaunch_map_l2(paddr_t paddr, size_t size) +{ + unsigned long aligned_paddr = paddr & ~((1ULL << L2_PAGETABLE_SHIFT) - 1); + unsigned long pages = ((paddr + size) - aligned_paddr); + + pages = ROUNDUP(pages, 1ULL << L2_PAGETABLE_SHIFT) >> PAGE_SHIFT; + + BUG_ON(paddr >= (1ULL << 32)); + BUG_ON(paddr + pages * PAGE_SIZE >= (1ULL << 32)); + + if ( aligned_paddr + pages * PAGE_SIZE <= PREBUILT_MAP_LIMIT ) + return 0; + + if ( aligned_paddr < PREBUILT_MAP_LIMIT ) + { + pages -= (PREBUILT_MAP_LIMIT - aligned_paddr) >> PAGE_SHIFT; + aligned_paddr = PREBUILT_MAP_LIMIT; + } + + return map_pages_to_xen((uintptr_t)__va(aligned_paddr), + maddr_to_mfn(aligned_paddr), + pages, PAGE_HYPERVISOR); +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380649.1624412 (Exim 4.92) (envelope-from ) id 1wqVxO-00073e-Ls; Sun, 02 Aug 2026 13:10:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380649.1624412; Sun, 02 Aug 2026 13:10:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxO-00072q-Gf; Sun, 02 Aug 2026 13:10:22 +0000 Received: by outflank-mailman (input) for mailman id 1380649; Sun, 02 Aug 2026 13:10:21 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxN-0006yB-3h for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxM-001lF1-Gh for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:20 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f41a9-e002-0a2a0a5209dd-0a2a4505e158-16 for ; Sun, 02 Aug 2026 15:10:20 +0200 Received: from [87.98.181.248] (helo=5.mo560.mail-out.ovh.net) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41bb-4cb1-0a2a45050019-5762b5f8891f-3 for ; Sun, 02 Aug 2026 15:10:20 +0200 Received: from director8.ghost.mail-out.ovh.net (unknown [10.110.43.172]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCH5LSBzB5rZ for ; Sun, 2 Aug 2026 13:10:19 +0000 (UTC) Received: from ghost-submission-7d8d68f679-mzsh5 (unknown [10.110.113.68]) by director8.ghost.mail-out.ovh.net (Postfix) with ESMTPS id E6D71C0120; Sun, 2 Aug 2026 13:10:18 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.105]) by ghost-submission-7d8d68f679-mzsh5 with ESMTPSA id fXhJKLpBb2pj5QUAuSgMJA (envelope-from ); Sun, 02 Aug 2026 13:10:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-105G0066ba2b957-759b-4dab-a1b9-b171d58bcbdf, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 12/23] x86/slaunch: restore boot MTRRs after Intel TXT DRTM Date: Sun, 2 Aug 2026 16:09:28 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4736379434136577468 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEO37Lm1soAj3J6HJwxZueJ91jNrKiCMD9VOxO+7S6oZcwX5ZhHy/rf+u1q3gsSFBR0MQ0G/W66mTSt5xumJoxY/EyDpxdVBT5aAA1fHupbW88f/IumzeClwwf3PGe5NCfIC4rAkaw9D49zl0L3FOqYw1yebY9XQZPEoEgqOhxU7iAITzoi4rSZJugXTxFrfgz5z3QYtYzrLSr0w464iDE2Jv+mfsQyDLbPqlC9XEGpFu9KBxFx07+KPXWsR6kr02Tgk2fJ3ulvjdiKijPJd2EPMcqID96OcOqj/uCF/V+6MYDFkW6NlVR5eWMFf+caoPBoCiQxHguJ/BWn2Nt+/d7LjfFvrcZF/8u8Q0n3PRHV4r3WKIwqRJzxJHPFSQxIKbl3XKNnFvBMXLOpuFHhZH23vljAyKNWXhmDAuNjJx+48Xd79wb1kFhk4s4YAFiFF/CVJN2Zsd6Gpz9N2JkkrsrlXnt3OHFvS8MHgPe6pYWDNjrhVTKEFh1bdt4tWvVVIZ+8woEhh6YA1yerfSR6yGkZEMy4A2UTcafcpvD2uDfNKO9Y5/nle0Uw/V9ra7AnWQwHcMv3n76VKKlBUNHLO4sKlPa1oupiaIcxzn7yOQZWEygxdQF5fsa33PPA/dvi89nZzUt4xXZ20devYMkWwQoLGOCH9fpurC4Yr9x5I7VD7w DKIM-Signature: a=rsa-sha256; bh=+7PqKj5rgs6xrE/At11/PBfNJMiWB0u0NPN3/ZI5tEc=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676219; v=1; b=ZiBwsSJKedYzeY7PbMzMY/56bIkaFnx4nGmP5x7pJ99HTIhHDEfiJxpXvWPTdojoG1f8STrF 6r9KQx0Un0fxHb3PIfDmsI65gi9VAYMbHAyUuK2lrhAfO+WcSea57kcYl/CB1CoQpzvXwkkahWM kAAIEhElCVL3uvBsZc+a7rfX0VRKDbRiWrN1oCS5HA59+b1ehsp8GQ2fnp0Cq3yMUYmGQdz5pG4 KHsZ5RTDOiIFf63ZHzujLfbL5bn5UZzj9SCfzRPwDBUcTqcmVsnkCVkP2lo25Hp3U4fvSQcvg7K m9RkXEjA4AgayF4WoQoORDnXUk9oln9P4lr2gLWhjrdyg== X-purgate-ID: tlsNG-c201ff/1785676220-F74BC2A1-6258F757/0/0 X-purgate-type: clean X-purgate-size: 8515 From: Krystian Hebel In preparation for TXT SENTER call, GRUB had to modify MTRR settings to be UC for everything except SINIT ACM. Old values are restored from SLRT where they were saved by the bootloader. Signed-off-by: Krystian Hebel Signed-off-by: Michał Żygowski Signed-off-by: Sergii Dmytruk --- Notes: v4: now this commit makes two functions of mtrr/generic.c public v4: take CONFIG_SLAUNCH into account v4: restore MTRRs earlier: move from mtrr_top_of_ram() to machine_specific_memory_setup() v4: renamed parameter of txt_restore_mtrrs(): e820_verbose => verbose v4: don't use rdmsrl() and wrmsrl() v4: extract part of an integer consistently (`mtrr_cap` in txt_restore_mtrrs(), was a mix of `(uint8_t)` cast and `& 0xff`) v4: use container_of() v4: manage MTRR count in txt_restore_mtrrs() better (separate variable, no weird ?: operator) xen/arch/x86/cpu/mtrr/generic.c | 9 +-- xen/arch/x86/e820.c | 5 ++ xen/arch/x86/include/asm/intel-txt.h | 3 + xen/arch/x86/include/asm/mtrr.h | 8 +++ xen/arch/x86/include/asm/slaunch.h | 8 +++ xen/arch/x86/intel-txt.c | 84 ++++++++++++++++++++++++++++ 6 files changed, 110 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c index 86eb0f405b..c179935dd3 100644 --- a/xen/arch/x86/cpu/mtrr/generic.c +++ b/xen/arch/x86/cpu/mtrr/generic.c @@ -14,11 +14,6 @@ #include #include "mtrr.h" -struct mtrr_pausing_state { - bool pge; - uint64_t def_type; -}; - static const struct fixed_range_block { uint32_t base_msr; /* start address of an MTRR block */ unsigned int ranges; /* number of MTRRs in this block */ @@ -440,7 +435,7 @@ static DEFINE_SPINLOCK(set_atomicity_lock); * has been called. */ -static void mtrr_pause_caching(struct mtrr_pausing_state *state) +void mtrr_pause_caching(struct mtrr_pausing_state *state) { unsigned long cr4; @@ -481,7 +476,7 @@ static void mtrr_pause_caching(struct mtrr_pausing_state *state) alternative("wbinvd", "", X86_FEATURE_XEN_SELFSNOOP); } -static void mtrr_resume_caching(struct mtrr_pausing_state state) +void mtrr_resume_caching(struct mtrr_pausing_state state) { /* Intel (P6) standard MTRRs */ mtrr_wrmsr(MSR_MTRRdefType, state.def_type); diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c index 872208ab37..c63b0b12cc 100644 --- a/xen/arch/x86/e820.c +++ b/xen/arch/x86/e820.c @@ -11,6 +11,8 @@ #include #include #include +#include +#include /* * opt_mem: Limit maximum address of physical RAM. @@ -499,6 +501,9 @@ static void __init machine_specific_memory_setup(struct e820map *raw) uint64_t top_of_ram, size; unsigned int i; + if ( slaunch_active ) + txt_restore_mtrrs(e820_verbose); + sanitize_e820_map(raw->map, &raw->nr_map); copy_e820_map(raw->map, raw->nr_map); diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h index db6b0defd0..406929fac2 100644 --- a/xen/arch/x86/include/asm/intel-txt.h +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -389,6 +389,9 @@ void txt_map_mem_regions(void); /* Marks TXT-specific memory as used to avoid its corruption. */ void txt_reserve_mem_regions(void); +/* Restores original MTRR values saved by a bootloader before starting DRTM. */ +void txt_restore_mtrrs(bool verbose); + #endif /* !__ASSEMBLER__ */ #endif /* X86_INTEL_TXT_H */ diff --git a/xen/arch/x86/include/asm/mtrr.h b/xen/arch/x86/include/asm/mtrr.h index 3a5b4f5b6e..bf82af8c47 100644 --- a/xen/arch/x86/include/asm/mtrr.h +++ b/xen/arch/x86/include/asm/mtrr.h @@ -63,6 +63,14 @@ extern uint8_t pat_type_2_pte_flags(uint8_t pat_type); extern void mtrr_aps_sync_begin(void); extern void mtrr_aps_sync_end(void); +struct mtrr_pausing_state { + bool pge; + uint64_t def_type; +}; + +extern void mtrr_pause_caching(struct mtrr_pausing_state *state); +extern void mtrr_resume_caching(struct mtrr_pausing_state state); + extern bool mtrr_var_range_msr_set(struct domain *d, struct mtrr_state *m, uint32_t msr, uint64_t msr_content); extern bool mtrr_fix_range_msr_set(struct domain *d, struct mtrr_state *m, diff --git a/xen/arch/x86/include/asm/slaunch.h b/xen/arch/x86/include/asm/slaunch.h index 3df7174b4b..459fc83388 100644 --- a/xen/arch/x86/include/asm/slaunch.h +++ b/xen/arch/x86/include/asm/slaunch.h @@ -23,8 +23,16 @@ struct slaunch_early_init_results uint32_t slrt_pa; } __packed; +#ifdef CONFIG_SLAUNCH /* Indicates an active Secure Launch boot. */ extern bool slaunch_active; +#else +/* + * This avoids `#ifdef CONFIG_SLAUNCH` around `if ( slaunch_active )` thanks to + * dead code elimination. + */ +static bool slaunch_active = false; +#endif /* * Holds physical address of SLRT. Use slaunch_get_slrt() to access SLRT diff --git a/xen/arch/x86/intel-txt.c b/xen/arch/x86/intel-txt.c index 4a42abf8df..e0344d3421 100644 --- a/xen/arch/x86/intel-txt.c +++ b/xen/arch/x86/intel-txt.c @@ -8,10 +8,13 @@ #include #include +#include #include #include #include #include +#include +#include #include /* @@ -111,3 +114,84 @@ void __init txt_reserve_mem_regions(void) TXT_PRIV_CONFIG_REGS_BASE + TXT_CONFIG_SPACE_SIZE); BUG_ON(!ok); } + +void __init txt_restore_mtrrs(bool verbose) +{ + const struct slr_entry_hdr *entry; + const struct slr_entry_intel_info *intel_info; + uint64_t mtrr_cap, mtrr_def, base, mask; + unsigned int i; + unsigned int vcnt; + uint64_t def_type; + struct mtrr_pausing_state pausing_state; + + mtrr_cap = rdmsr(MSR_MTRRcap); + mtrr_def = rdmsr(MSR_MTRRdefType); + + vcnt = mtrr_cap & 0xFF; + + if ( verbose ) + { + printk("MTRRs set previously for SINIT ACM:\n"); + printk(" MTRR cap: %"PRIx64" type: %"PRIx64"\n", mtrr_cap, mtrr_def); + + for ( i = 0; i < vcnt; i++ ) + { + base = rdmsr(MSR_IA32_MTRR_PHYSBASE(i)); + mask = rdmsr(MSR_IA32_MTRR_PHYSMASK(i)); + + printk(" MTRR[%d]: base %"PRIx64" mask %"PRIx64"\n", + i, base, mask); + } + } + + entry = + slr_next_entry_by_tag(slaunch_get_slrt(), NULL, SLR_ENTRY_INTEL_INFO); + intel_info = container_of(entry, const struct slr_entry_intel_info, hdr); + + if ( vcnt != intel_info->saved_bsp_mtrrs.mtrr_vcnt ) + { + printk("Bootloader saved %ld MTRR values, but there should be %d\n", + intel_info->saved_bsp_mtrrs.mtrr_vcnt, vcnt); + /* Choose the smaller one to be on the safe side. */ + if ( intel_info->saved_bsp_mtrrs.mtrr_vcnt < vcnt ) + vcnt = intel_info->saved_bsp_mtrrs.mtrr_vcnt; + } + + def_type = intel_info->saved_bsp_mtrrs.default_mem_type; + mtrr_pause_caching(&pausing_state); + + for ( i = 0; i < vcnt; i++ ) + { + base = intel_info->saved_bsp_mtrrs.mtrr_pair[i].mtrr_physbase; + mask = intel_info->saved_bsp_mtrrs.mtrr_pair[i].mtrr_physmask; + wrmsr(MSR_IA32_MTRR_PHYSBASE(i), base); + wrmsr(MSR_IA32_MTRR_PHYSMASK(i), mask); + } + + pausing_state.def_type = def_type; + mtrr_resume_caching(pausing_state); + + if ( verbose ) + { + printk("Restored MTRRs:\n"); + + /* + * If MTRRs are not enabled or WB is not the default, MTRRs won't be + * printed. + */ + if ( !test_bit(11, &def_type) || (def_type & 0x7) == X86_MT_WB ) + { + for ( i = 0; i < vcnt; i++ ) + { + base = rdmsr(MSR_IA32_MTRR_PHYSBASE(i)); + mask = rdmsr(MSR_IA32_MTRR_PHYSMASK(i)); + printk(" MTRR[%d]: base %"PRIx64" mask %"PRIx64"\n", + i, base, mask); + } + } + } + + /* Restore IA32_MISC_ENABLES */ + wrmsr(MSR_IA32_MISC_ENABLE, intel_info->saved_misc_enable_msr); +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380655.1624421 (Exim 4.92) (envelope-from ) id 1wqVxS-0007a7-52; Sun, 02 Aug 2026 13:10:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380655.1624421; Sun, 02 Aug 2026 13:10:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxR-0007Zy-Vt; Sun, 02 Aug 2026 13:10:25 +0000 Received: by outflank-mailman (input) for mailman id 1380655; Sun, 02 Aug 2026 13:10:24 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxQ-0007Lq-1f for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxP-001lF1-Ew for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:23 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4178-e002-0a2a0a5209dd-0a2a450adcca-26 for ; Sun, 02 Aug 2026 15:10:23 +0200 Received: from [46.105.63.121] (helo=1.mo560.mail-out.ovh.net) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41be-f2d2-0a2a450a0019-2e693f79a513-3 for ; Sun, 02 Aug 2026 15:10:23 +0200 Received: from director5.ghost.mail-out.ovh.net (unknown [10.110.58.120]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCL66r7zB5rw for ; Sun, 2 Aug 2026 13:10:22 +0000 (UTC) Received: from ghost-submission-7d8d68f679-m4frt (unknown [10.111.174.155]) by director5.ghost.mail-out.ovh.net (Postfix) with ESMTPS id EE3FC100020; Sun, 2 Aug 2026 13:10:21 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.105]) by ghost-submission-7d8d68f679-m4frt with ESMTPSA id +ukvK71Bb2oAsRcAXQcPeQ (envelope-from ); Sun, 02 Aug 2026 13:10:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-105G0063c3aa204-ba72-4722-ade4-19b5dcf0e5f5, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 13/23] x86/slaunch: measure MBI into TPM Date: Sun, 2 Aug 2026 16:09:29 +0300 Message-ID: <8e971b5b87d6b5dd7aebba55a40ddaeed7b97616.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4737223860187702716 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTErXTMJAFd1A/dXmS31doF3eHiFwFavtbE0IdxSAxcjBkbm/Y2r8C0ugmNxHgh0ttjc9HcWB48DtmHsboYn+R8rGouoQtvWBvuW7UoEIxsUWbq/tHAG5l0RfFjNSyhC5/+eLgR0uRIXbClVnnLU0J/e2MH+H41gFQHMN7aHv5oF4XCxU6iBwYAbzZv3Yhh++GCTcK0XOcSHoKOpYkiLjzaWT2sDXaneeSXeAAfPIRWbR3tUvr9IWTEkcXdO9/v8flsgALJWAnTuyhJyR7xa7rElw4l9ZKZPp4F7IlSUp4UkO78BMUlmU3YvvPg7A/cDjWsr7oy1auF5nv72TyzhOj1kihXXkuJHUxuhH70tfkuXm5adpj7kYIq40ucJWy4eC8j4fd5KD8Rjrj+faMOgHhQfHMXHXc/D+vxjCPoiXhdVJyUP1hH3j+BXHyKw9Tm0xzuxJs/dEVF0AWE6Y8pzOWujbxug4nS1eBH11qnIpTz4s9R8aGzvTzhCgv94NwckC+ebxuOt/l2btFhWFQHAoiqdtUsXR/i/4pBjb6y9MWckygLMxPIOgsvDY5lH16jia9YFKUGoEIfy7eaWSjXfgvkVWqQa/ykLH0W2krnjwb2FiHZynPwGWkL/fRdSDP/svwT+IR+/3WdSNXTDQirQHtqd04KTIx+HNfdXzKcP7YYOJA DKIM-Signature: a=rsa-sha256; bh=NTPb66lzSKmerltG0bBqdXZxKAyljMiz3zhpakFzmRs=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676222; v=1; b=Fj/IJVW2RxfGpPoBj7h4FcE+jcamEVbzMgjD/1vmGj7QEjOOJpDXyz3s7Ap8y0V5pHVqNkUL i/5vI/j3deL8KfzJRVwmfjqMG0I6y6qRc2nDZsDCwZ9Ig63GJwWTxb6X/d1Qpd3yspWcnnmig5M +fxKrqhGE/x8rcn/gRAtyt47+nvFCUyrIomu2EDu8g9GfRJmJJMzE80hs+pFl2n3o45VbluBr9Q uvnU5dq04MW7WBUZqERGAPUs2FFw7OfTAGA6ssfG30NCWPObMDQg9FC8czVLq/+33qIB05qemH6 SYa6p36J/gNsIiNxe2vSOqttchdEH8UlAtEnofT4LfVOA== X-purgate-ID: tlsNG-4011c0/1785676223-4ABD8CFC-00CF7C25/0/0 X-purgate-type: clean X-purgate-size: 8972 From: Krystian Hebel Make slaunch-tpm.c compile in early boot environment use it to measure MBI in early 32b code without paging (gets triggered from head.S). The fact of the measurement is not yet stored anywhere as there is no code for TPM event log discovery and modification. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: was part of "x86/tpm.c: code for early hashing and extending PCRs (for TPM1.2)" v4: tpm_extend_mbi => slaunch_measure_mbi v4: doesn't touch tpm.c, uses slaunch-tpm.c instead v4: use `const multiboot2_fixed_t *` instead of `uint32_t *` for MBI xen/arch/x86/boot/Makefile | 7 +- xen/arch/x86/boot/head.S | 5 ++ xen/arch/x86/include/asm/slaunch-tpm.h | 7 ++ xen/arch/x86/include/asm/slaunch.h | 14 ++++ xen/arch/x86/slaunch-tpm.c | 112 +++++++++++++++++++++++++ xen/arch/x86/slaunch.c | 4 + 6 files changed, 148 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile index 02f690d34a..b31c96be18 100644 --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -7,6 +7,7 @@ obj32 += reloc.32.o obj32 += reloc-trampoline.32.o ifeq ($(CONFIG_SLAUNCH),y) obj32 += slaunch-early.32.o +obj32 += slaunch-tpm-early.32.o endif obj32 += tpm-early.32.o @@ -14,7 +15,7 @@ obj64 := reloc-trampoline.o exports := cmdline_parse_early,reloc,reloc_trampoline32 ifeq ($(CONFIG_SLAUNCH),y) -exports := $(exports),slaunch_early_init +exports := $(exports),slaunch_early_init,slaunch_measure_mbi endif nocov-y += $(obj32) $(obj64) @@ -39,6 +40,10 @@ $(obj)/%.32.o: $(src)/%.c FORCE $(obj)/slaunch-early.32.o: XEN_CFLAGS += -D__EARLY_SLAUNCH__ +$(obj)/slaunch-tpm-early.32.o: XEN_CFLAGS += -D__EARLY_SLAUNCH__ +$(obj)/slaunch-tpm-early.32.o: $(src)/../slaunch-tpm.c FORCE + $(call if_changed_rule,cc_o_c) + $(obj)/tpm-early.32.o: XEN_CFLAGS += -D__EARLY_TPM__ $(obj)/tpm-early.32.o: $(src)/../tpm.c FORCE $(call if_changed_rule,cc_o_c) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 700d1d850e..2c1a0f6306 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -539,6 +539,11 @@ __start: pop sym_esi(slaunch_slrt) /* save physical address of SLRT for C code */ + mov sym_esi(slaunch_slrt), %edx /* physical SLRT address */ + mov %ebx, %eax /* physical MBI address */ + /* slaunch_measure_mbi(mbi/eax, slrt/edx) using fastcall. */ + call slaunch_measure_mbi + /* Move magic number expected by Multiboot 2 to EAX and fall through. */ movl $MULTIBOOT2_BOOTLOADER_MAGIC, %eax #endif diff --git a/xen/arch/x86/include/asm/slaunch-tpm.h b/xen/arch/x86/include/asm/slaunch-tpm.h index 68e9c8358a..79154f505b 100644 --- a/xen/arch/x86/include/asm/slaunch-tpm.h +++ b/xen/arch/x86/include/asm/slaunch-tpm.h @@ -16,4 +16,11 @@ struct slr_table; void slaunch_find_log(const struct slr_table *slrt, paddr_t *evt_log, uint32_t *evt_log_size); +/* + * Log data is optional (pass in NULL and/or zero size to indicate its absence). + */ +void slaunch_hash_extend(unsigned int loc, unsigned int pcr, const uint8_t *buf, + unsigned int size, uint32_t type, + const uint8_t *log_data, unsigned int log_data_size); + #endif /* X86_SLAUNCH_TPM_H */ diff --git a/xen/arch/x86/include/asm/slaunch.h b/xen/arch/x86/include/asm/slaunch.h index 459fc83388..65aab01f04 100644 --- a/xen/arch/x86/include/asm/slaunch.h +++ b/xen/arch/x86/include/asm/slaunch.h @@ -17,6 +17,20 @@ #include #include +#define DRTM_LOC 2 +#define DRTM_CODE_PCR 17 +#define DRTM_DATA_PCR 18 + +/* + * Secure Launch event log entry types. The TXT specification defines the base + * event value as 0x400 for DRTM values, use it regardless of the DRTM for + * consistency. + */ +#define DLE_EVTYPE_BASE 0x400 +#define DLE_EVTYPE_SLAUNCH (DLE_EVTYPE_BASE + 0x102) +#define DLE_EVTYPE_SLAUNCH_START (DLE_EVTYPE_BASE + 0x103) +#define DLE_EVTYPE_SLAUNCH_END (DLE_EVTYPE_BASE + 0x104) + struct slaunch_early_init_results { uint32_t mbi_pa; diff --git a/xen/arch/x86/slaunch-tpm.c b/xen/arch/x86/slaunch-tpm.c index f59170594d..21dec67dca 100644 --- a/xen/arch/x86/slaunch-tpm.c +++ b/xen/arch/x86/slaunch-tpm.c @@ -2,13 +2,71 @@ /* * Slaunch functions related to TPM. * + * This file is built twice: + * 1. For early 32b mode without paging when it also provides + * slaunch_measure_mbi() to be called from assembly. + * 2. For 64b code. + * * Copyright (c) 2022-2026 3mdeb Sp. z o.o. All rights reserved. */ +#include +#include #include +#include +#include +#include #include #include +#include +#include +#include +#include +#include + +#ifdef __EARLY_SLAUNCH__ + +#ifdef __va +#error "__va defined in non-paged mode!" +#endif + +#define __va(x) _p(x) + +static uint32_t slrt_location; + +/* + * The code is being compiled as a standalone binary without linking to any + * other part of Xen. Providing implementation of builtin functions in this + * case is necessary if compiler chooses to not use an inline builtin. + */ +void *(memset)(void *s, int c, size_t n) +{ + uint8_t *d = s; + + while ( n-- ) + *d++ = c; + + return s; +} + +struct slr_table *slaunch_get_slrt(void) +{ + return _p(slrt_location); +} + +void asmlinkage slaunch_measure_mbi(const multiboot2_fixed_t *mbi, + uint32_t slrt_pa) +{ + /* Need this to implement slaunch_get_slrt() for early TPM code. */ + slrt_location = slrt_pa; + + slaunch_hash_extend(DRTM_LOC, DRTM_DATA_PCR, (const uint8_t *)mbi, + mbi->total_size, DLE_EVTYPE_SLAUNCH, NULL, 0); +} + +#endif /* __EARLY_SLAUNCH__ */ + void slaunch_find_log(const struct slr_table *slrt, paddr_t *evt_log, uint32_t *evt_log_size) { @@ -34,3 +92,57 @@ void slaunch_find_log(const struct slr_table *slrt, paddr_t *evt_log, *evt_log_size = 0; } } + +void slaunch_hash_extend(unsigned int loc, unsigned int pcr, const uint8_t *buf, + unsigned int size, uint32_t type, + const uint8_t *log_data, unsigned int log_data_size) +{ + paddr_t evt_log_paddr; + uint32_t evt_log_size; + struct tpm_log_hashes log_hashes; + uint8_t discarded_digests[SHA2_256_DIGEST_SIZE]; + uint32_t rc; + + slaunch_find_log(slaunch_get_slrt(), &evt_log_paddr, &evt_log_size); + + if ( tpm_is_tpm1() ) + { + log_hashes = (struct tpm_log_hashes) { + .count = 1, + .hashes = { + { + .alg = TPM_ALG_SHA1, + .size = SHA1_DIGEST_SIZE, + .data = discarded_digests, + }, + }, + }; + } + else + { + log_hashes = (struct tpm_log_hashes) { + .count = 2, + .hashes = { + { + .alg = TPM_ALG_SHA1, + .size = SHA1_DIGEST_SIZE, + .data = discarded_digests, + }, + { + .alg = TPM_ALG_SHA256, + .size = SHA2_256_DIGEST_SIZE, + .data = discarded_digests, + }, + }, + }; + } + + rc = tpm_hash_extend(loc, pcr, buf, size, &log_hashes); + if (rc != 0) + { +#ifndef __EARLY_SLAUNCH__ + printk(XENLOG_ERR "Extending PCR-%u failed with an error: 0x%08x\n", + pcr, rc); +#endif + } +} diff --git a/xen/arch/x86/slaunch.c b/xen/arch/x86/slaunch.c index ba1ba61c47..83dce3d57d 100644 --- a/xen/arch/x86/slaunch.c +++ b/xen/arch/x86/slaunch.c @@ -18,6 +18,7 @@ #include #include #include +#include /* * These variables are assigned to by the code near Xen's entry point. @@ -78,6 +79,9 @@ void __init slaunch_map_mem_regions(void) paddr_t evt_log_addr; uint32_t evt_log_size; + rc = slaunch_map_l2(TPM_MMIO_BASE, TPM_MMIO_SIZE); + BUG_ON(rc != 0); + /* Vendor-specific part. */ txt_map_mem_regions(); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380663.1624430 (Exim 4.92) (envelope-from ) id 1wqVxU-0007yK-D3; Sun, 02 Aug 2026 13:10:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380663.1624430; Sun, 02 Aug 2026 13:10:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxU-0007y8-9V; Sun, 02 Aug 2026 13:10:28 +0000 Received: by outflank-mailman (input) for mailman id 1380663; Sun, 02 Aug 2026 13:10:27 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxS-0007he-S4 for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxS-001lF1-90 for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:26 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4184-e002-0a2a0a5209dd-0a2a4509b098-38 for ; Sun, 02 Aug 2026 15:10:26 +0200 Received: from [87.98.165.232] (helo=10.mo561.mail-out.ovh.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41c1-be1a-0a2a45090019-5762a5e89cdd-3 for ; Sun, 02 Aug 2026 15:10:25 +0200 Received: from director1.ghost.mail-out.ovh.net (unknown [10.109.231.50]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCP3tlTz5xsS for ; Sun, 2 Aug 2026 13:10:25 +0000 (UTC) Received: from ghost-submission-7d8d68f679-zxq5n (unknown [10.110.96.50]) by director1.ghost.mail-out.ovh.net (Postfix) with ESMTPS id DC9B3C0F9B; Sun, 2 Aug 2026 13:10:24 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.106]) by ghost-submission-7d8d68f679-zxq5n with ESMTPSA id ABhuKMBBb2rQIhgAgBBa5Q (envelope-from ); Sun, 02 Aug 2026 13:10:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-106R0065f936387-df7e-49bc-bd38-eb12fb54b197, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Ross Philipson , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 14/23] x86/slaunch: update TPM event log (TPM1.2 or TPM2.0) Date: Sun, 2 Aug 2026 16:09:30 +0300 Message-ID: <76a5865c29f948838db879e60d3c0bc3dfc58de1.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4738068283416716732 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEO37Lm1soAj3J6HJwxZueJ91jNrKiCMD9VOxO+7S6oZcwX5ZhHy/rf+u1q3gsSFBR0MQ0G/W66mTSt5xumJoxY/EyDpxdVBT5aAA1fHupbW88f/IumzeClwwf3PGe5NCfIC4rAkaw9D49zl0L3FOqYw1yebY9XQZPEoEgqOhxU7iAITzoi4rSZJugXTxFrfgz5z3QYtYzrLSr0w464iDE2Jv+mfsQyDLbPqlC9XEGpFu9KBxFx07+KPXWsR6kr02Tgk2fJ3ulvjdiKijPJd2EPMcqID96OcOqj/uCF/V+6MYDFkW6NlVR5eWMFf+caoPBoCiQxHguJ/BWn2Nt+/d7LHwk69zDTIzqt35GmMuoaho7idYrBzTS7yFU7rRghw3pVL5X4c9i4LE2QS5r59QBm8FJTtOqdwzRrju4/cPXmMV65S054EmWWTBKFXMIClT7YPWN3N9hAaNB8S3Cc6sHWyA+COP8gR6nuxyfLjGl7d4aCpJbIJUbT8WJx64Q0sKD4cjoPWtWHheWmfy/pMY9rDumd5/Vq/OaOAQAQVqboCfFeqi5NdrKe2LQXSW4/u/51iqfceb77TgBWerQHjS457dejEfH7mAwgRjTpMAGsnxoTI9wdoNaHmSI94dNWH2IH9GcA2PbvS5JKqgVrQOAAJ6RVb3/NApTuHM0BM9mXvQ DKIM-Signature: a=rsa-sha256; bh=BH2ypaGIGioPbhMgOZFVFcYuPiFMRNHbe3vWB1O+qXM=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676225; v=1; b=CY6zFFJe3hvmPSrE8bM27jiwPLc6d37prIdu0KWicm39eJmTCtEBCsbBjWr55aUlrBxUaNcQ XsI7nr1GJR63LKicVE1hbMMv/bkD8riaYGQb0KJqUJYD45Lp9oTg61UTbuOorLxZ60xuOOD5wuH WIkkZk4TdQrfwc3qYRY4xZujO+edPo7YAjyK3AHaiMHT9E/p9ltO6SZACTgvi7CJb95xw7eiCXT Bft1M06d6nF10IwaAv6xA1TS1/CNpI5Bm/ACU79HzdUTWIP3Fk2RPFHHTyP3Mb+aPRkZNnBMAN/ 3pdDHlG28jtqA9fmEGYgvaHjJnuW/v13ss3TrQINZaTdA== X-purgate-ID: tlsNG-bad1c0/1785676226-BCECE034-12BB87FE/0/0 X-purgate-type: clean X-purgate-size: 11676 Instead of storing hashing result to stack variables, a TPM event log is discovered in an Slaunch-specific way, extended with an additional entry and that entry is filled with digests. Signed-off-by: Krystian Hebel Signed-off-by: Szymon Acedański Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Sergii Dmytruk --- Notes: v4: was "x86/tpm.c: implement event log for TPM2.0" v4: part of it as in "x86/tpm.c: code for early hashing and extending PCRs (for TPM1.2)" v4: TPM event log code was part of tpm.c changes, now in slaunch-tpm.c v4: fixed comment on txt_ext_data_element::size and finding log element (worked because it was first) v4: provide list of hashes even in the absence of event log to extend PCRs xen/arch/x86/include/asm/intel-txt.h | 69 ++++++++++ xen/arch/x86/slaunch-tpm.c | 188 +++++++++++++++++++++++---- 2 files changed, 232 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h index 406929fac2..8bcca20d6e 100644 --- a/xen/arch/x86/include/asm/intel-txt.h +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -71,6 +71,8 @@ #include #include +#include + /* Need to differentiate between pre- and post paging enabled. */ #ifdef __EARLY_SLAUNCH__ #include @@ -200,6 +202,52 @@ struct txt_sinit_mle_data { /* Ext Data Elements */ } __packed; +struct txt_ev_log_container_12 { + char Signature[20]; /* "TXT Event Container", null-terminated */ + uint8_t Reserved[12]; + uint8_t ContainerVerMajor; + uint8_t ContainerVerMinor; + uint8_t PCREventVerMajor; + uint8_t PCREventVerMinor; + uint32_t ContainerSize; /* Allocated size */ + uint32_t PCREventsOffset; + uint32_t NextEventOffset; + struct TPM12_PCREvent PCREvents[]; +}; + +/* Types of extended data. */ +#define TXT_HEAP_EXTDATA_TYPE_END 0 +#define TXT_HEAP_EXTDATA_TYPE_BIOS_SPEC_VER 1 +#define TXT_HEAP_EXTDATA_TYPE_ACM 2 +#define TXT_HEAP_EXTDATA_TYPE_STM 3 +#define TXT_HEAP_EXTDATA_TYPE_CUSTOM 4 +#define TXT_HEAP_EXTDATA_TYPE_MADT 6 +#define TXT_HEAP_EXTDATA_TYPE_EVENT_LOG_POINTER2_1 8 +#define TXT_HEAP_EXTDATA_TYPE_MCFG 9 +#define TXT_HEAP_EXTDATA_TYPE_TPR_REQ 13 +#define TXT_HEAP_EXTDATA_TYPE_DTPR 14 +#define TXT_HEAP_EXTDATA_TYPE_CEDT 15 + +/* + * Self-describing data structure that is used for extensions to TXT heap + * tables. + */ +struct txt_ext_data_element { + uint32_t type; /* One of TXT_HEAP_EXTDATA_TYPE_*. */ + uint32_t size; /* Size of the whole element (header + data), in bytes. */ + uint8_t data[0]; +} __packed; + +/* + * Extended data describing TPM 2.0 log. + */ +struct heap_event_log_pointer_element2_1 { + uint64_t physical_address; + uint32_t allocated_event_container_size; + uint32_t first_record_offset; + uint32_t next_record_offset; +} __packed; + /* * Functions to extract data from the Intel TXT Heap Memory. * @@ -268,6 +316,27 @@ static inline void *txt_init(void) return txt_heap; } +/* + * Find the given element in the TXT heap extended data. + */ +static inline struct txt_ext_data_element * +txt_find_ext_data_element(struct txt_os_sinit_data *os_sinit, uint32_t type) +{ + struct txt_ext_data_element *ext_elem; + + ext_elem = (void *)os_sinit + sizeof(struct txt_os_sinit_data); + + while ( ext_elem->type != TXT_HEAP_EXTDATA_TYPE_END ) + { + if ( ext_elem->type == type ) + return ext_elem; + + ext_elem = (void *)ext_elem + ext_elem->size; + } + + return NULL; +} + static inline bool is_in_pmr(const struct txt_os_sinit_data *os_sinit, uint64_t base, uint32_t size, bool check_high) { diff --git a/xen/arch/x86/slaunch-tpm.c b/xen/arch/x86/slaunch-tpm.c index 21dec67dca..e3b7341cc5 100644 --- a/xen/arch/x86/slaunch-tpm.c +++ b/xen/arch/x86/slaunch-tpm.c @@ -67,6 +67,136 @@ void asmlinkage slaunch_measure_mbi(const multiboot2_fixed_t *mbi, #endif /* __EARLY_SLAUNCH__ */ +static struct tpm_log_hashes +create_log_event12(struct txt_ev_log_container_12 *evt_log, + uint32_t evt_log_size, uint32_t pcr, uint32_t type, + const uint8_t *data, unsigned data_size) +{ + struct tpm_log_hashes log_hashes = {0}; + + struct TPM12_PCREvent *new_entry; + + if (evt_log == NULL) + return log_hashes; + + new_entry = (void *)evt_log + evt_log->NextEventOffset; + + /* + * Check if there is enough space left for new entry. + * Note: it is possible to introduce a gap in event log if entry with big + * data_size is followed by another entry with smaller data. Maybe we should + * cap the event log size in such case? + */ + if ( evt_log->NextEventOffset + sizeof(struct TPM12_PCREvent) + data_size > + evt_log_size ) + return log_hashes; + + evt_log->NextEventOffset += sizeof(struct TPM12_PCREvent) + data_size; + + new_entry->PCRIndex = pcr; + new_entry->Type = type; + new_entry->Size = data_size; + + if ( data != NULL && data_size > 0 ) + memcpy(new_entry->Data, data, data_size); + + log_hashes.count = 1; + log_hashes.hashes[0].alg = TPM_ALG_SHA1; + log_hashes.hashes[0].size = SHA1_DIGEST_SIZE; + log_hashes.hashes[0].data = new_entry->Digest; + + return log_hashes; +} + +static struct heap_event_log_pointer_element2_1 * +find_evt_log_ext_data(struct tpm2_spec_id_event *evt_log) +{ + struct txt_os_sinit_data *os_sinit; + struct txt_ext_data_element *ext_data; + + os_sinit = txt_start(__va(txt_read(TXTCR_HEAP_BASE)), TXT_OS2SINIT); + ext_data = txt_find_ext_data_element(os_sinit, + TXT_HEAP_EXTDATA_TYPE_EVENT_LOG_POINTER2_1); + if ( ext_data == NULL ) + return NULL; + + return (struct heap_event_log_pointer_element2_1 *)ext_data->data; +} + +static struct tpm_log_hashes +create_log_event20(struct tpm2_spec_id_event *evt_log, uint32_t evt_log_size, + uint32_t pcr, uint32_t type, const uint8_t *data, + unsigned data_size) +{ + struct tpm_log_hashes log_hashes = {0}; + + struct heap_event_log_pointer_element2_1 *log_ext_data; + struct tpm2_pcr_event_header *new_entry; + uint32_t entry_size; + unsigned i; + uint8_t *p; + + if (evt_log == NULL) + return log_hashes; + + log_ext_data = find_evt_log_ext_data(evt_log); + if ( log_ext_data == NULL ) + return log_hashes; + + entry_size = sizeof(*new_entry); + for ( i = 0; i < evt_log->digestCount; ++i ) + { + entry_size += sizeof(uint16_t); /* hash type */ + entry_size += evt_log->digestSizes[i].digestSize; + } + entry_size += sizeof(uint32_t); /* data size field */ + entry_size += data_size; + + /* + * Check if there is enough space left for new entry. + * Note: it is possible to introduce a gap in event log if entry with big + * data_size is followed by another entry with smaller data. Maybe we should + * cap the event log size in such case? + */ + if ( log_ext_data->next_record_offset + entry_size > evt_log_size ) + return log_hashes; + + new_entry = (void *)evt_log + log_ext_data->next_record_offset; + log_ext_data->next_record_offset += entry_size; + + new_entry->pcrIndex = pcr; + new_entry->eventType = type; + new_entry->digestCount = evt_log->digestCount; + + p = &new_entry->digests[0]; + for ( i = 0; i < evt_log->digestCount; ++i ) + { + uint16_t alg = evt_log->digestSizes[i].algId; + uint16_t size = evt_log->digestSizes[i].digestSize; + + *(uint16_t *)p = alg; + p += sizeof(uint16_t); + + log_hashes.hashes[i].alg = alg; + log_hashes.hashes[i].size = size; + log_hashes.hashes[i].data = p; + p += size; + + /* This is called "OneDigest" in TXT Software Development Guide. */ + memset(log_hashes.hashes[i].data, 0, size); + log_hashes.hashes[i].data[0] = 1; + } + log_hashes.count = evt_log->digestCount; + + *(uint32_t *)p = data_size; + p += sizeof(uint32_t); + + if ( data != NULL && data_size > 0 ) + memcpy(p, data, data_size); + + return log_hashes; +} + void slaunch_find_log(const struct slr_table *slrt, paddr_t *evt_log, uint32_t *evt_log_size) { @@ -99,42 +229,50 @@ void slaunch_hash_extend(unsigned int loc, unsigned int pcr, const uint8_t *buf, { paddr_t evt_log_paddr; uint32_t evt_log_size; - struct tpm_log_hashes log_hashes; uint8_t discarded_digests[SHA2_256_DIGEST_SIZE]; + struct tpm_log_hashes log_hashes; uint32_t rc; slaunch_find_log(slaunch_get_slrt(), &evt_log_paddr, &evt_log_size); if ( tpm_is_tpm1() ) { - log_hashes = (struct tpm_log_hashes) { - .count = 1, - .hashes = { - { - .alg = TPM_ALG_SHA1, - .size = SHA1_DIGEST_SIZE, - .data = discarded_digests, - }, - }, - }; + struct txt_ev_log_container_12 *evt_log = __va(evt_log_paddr); + + log_hashes = create_log_event12(evt_log, evt_log_size, pcr, type, + log_data, log_data_size); } else { - log_hashes = (struct tpm_log_hashes) { - .count = 2, - .hashes = { - { - .alg = TPM_ALG_SHA1, - .size = SHA1_DIGEST_SIZE, - .data = discarded_digests, - }, - { - .alg = TPM_ALG_SHA256, - .size = SHA2_256_DIGEST_SIZE, - .data = discarded_digests, + struct tpm2_spec_id_event *evt_log = __va(evt_log_paddr); + + log_hashes = create_log_event20(evt_log, evt_log_size, pcr, type, + log_data, log_data_size); + + if ( log_hashes.count == 0 ) + { + /* + * Because TPM2 supports multiple PCR banks, the list of digests is + * also used to indicate which banks to extend. Thus avoid passing + * an empty list of digests to have a chance of something being + * extended even without event log. + */ + log_hashes = (struct tpm_log_hashes) { + .count = 2, + .hashes = { + { + .alg = TPM_ALG_SHA1, + .size = SHA1_DIGEST_SIZE, + .data = discarded_digests, + }, + { + .alg = TPM_ALG_SHA256, + .size = SHA2_256_DIGEST_SIZE, + .data = discarded_digests, + }, }, - }, - }; + }; + } } rc = tpm_hash_extend(loc, pcr, buf, size, &log_hashes); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380680.1624439 (Exim 4.92) (envelope-from ) id 1wqVxZ-0000Eg-Ne; Sun, 02 Aug 2026 13:10:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380680.1624439; Sun, 02 Aug 2026 13:10:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxZ-0000EQ-IL; Sun, 02 Aug 2026 13:10:33 +0000 Received: by outflank-mailman (input) for mailman id 1380680; Sun, 02 Aug 2026 13:10:32 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxY-00007z-GC for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxX-001lF1-TF for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:31 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4184-e002-0a2a0a5209dd-0a2a4509b098-44 for ; Sun, 02 Aug 2026 15:10:31 +0200 Received: from [87.98.184.158] (helo=11.mo561.mail-out.ovh.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41c7-be1a-0a2a45090019-5762b89ebacd-3 for ; Sun, 02 Aug 2026 15:10:31 +0200 Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.231.47]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCW0pGXz5wv5 for ; Sun, 2 Aug 2026 13:10:31 +0000 (UTC) Received: from ghost-submission-7d8d68f679-qqknf (unknown [10.110.118.7]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 8D24180CB8; Sun, 2 Aug 2026 13:10:30 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.107]) by ghost-submission-7d8d68f679-qqknf with ESMTPSA id imrrGcZBb2r/DwMAM9HtzQ (envelope-from ); Sun, 02 Aug 2026 13:10:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-107S001a797ad44-ff3d-4c1b-8922-8d72a027f86c, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 16/23] x86/boot: choose AP stack based on APIC ID Date: Sun, 2 Aug 2026 16:09:32 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4739757135520277948 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTGLHzKh4/yJ/9rf7CVt2QjsLwpvIpIsbu5Q2ifTmTa4q+eoHsA7x5p9tsU480lKc7avA4p9mQWidCaEagfwmOhbXstCvypZ5scXYG1ng5ZFn9DnZ/N4oJIyWEurvQROCl2S2LjSwQS4U9WsDPZlCH4wDQNquTzOHj3nCzD461Ug0y82B4dSkV4Qd6i3fTBEb7a9savBPVAJgImDz1yOc6e/MZXaSIBshKtsS6bpgI45CY1MGNOZLKz09EiRFzZT/TqOcaDeccgXEqV2zkykSmXX8x9Rj5Vs78IZmjlqU3jZjyxS/HGi3JQdQKPhStYb42CxYmmlD99lDVIwqt02Eg61lKPUSgxiC3YPZU5EOM9qZgJJDIvxKa/27X25R8OtxF+YZxXiSazSGf/tGvBabHCGft3wtC0/wejVTmTfsbwZK3I4ZGECc/2eSuWJ9DWM5KwmSHZZzDNcGWqsu+fauCQYbzRJNhzlDjDLHXRKFXl3fWOzuaHGVrdQNkb/3meb4lAfZz3eBo2I9cM29P6RaLUfPWDlC9oAUcWxEXgPHopmiqnrIhGSyQj5G+7Ky6YGBOZVt8t3o6NW4JVr7p96F6LEHAP1WOkX/798e630MFicSIWZW2tsrrY2P/huNH8FtUEchedmL8mI1pqPfdm2nHPPYuEMn8ycVI3g0kb7Cxc4vg DKIM-Signature: a=rsa-sha256; bh=Eqi6HL4ViPn3eSFszDe1Rd+g0+twCZr1xKGba49FCiw=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676231; v=1; b=Rqvv9Dkk75QS2x6loJ83clBTdNzE068Uah/YFdh7olIMBCN946tKIl9gcRBYq151d6p0ThRI nKyGSrvxZsY7GX92OvhHfFX2GSCWPeqmG+tbel6ESa2aCJdfHQ6cyUH5+mqplNSEgBa5jA+rhJ9 0izzWE+jbeykLm2IQkR9zM04K8cco3UK4MbIWfNyEDmtavxSOIMQS7XbmIUhmM1Q+12cMHBollB UCIfGuhTn+Tj1cEeg7wCGuRg2n2a3qkTEOEknUWz4JKrFPb8yiliYV5ploUSGwFH4EqVA9A8gPH Y5QMIRIPVDmeQHt4Eju0RaGI5L0yf3TXE3hJqhos899jw== X-purgate-ID: tlsNG-bad1c0/1785676231-3A4DB034-558501BB/0/0 X-purgate-type: clean X-purgate-size: 6017 From: Krystian Hebel This is made as the first step of making parallel AP bring-up possible. It should be enough for pre-C code. Parallel AP bring-up is necessary because TXT by design releases all APs at once. In addition to that it reduces number of IPIs (and more importantly, delays between them) required to start all logical processors. This results in significant reduction of boot time, even when DRTM is not used, with performance gain growing with the number of logical CPUs. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: better comments in boot/trampoline.S v4: use %ebp instead of %esp to pass data to boot/x86_64.S v4: use `nr_cpu_ids(%rip)` instead of `$NR_CPUS` in boot/x86_64.S v4: L_stack_set => L_after_stack_setup v4: __ASSEMBLY__ => __ASSEMBLER__ xen/arch/x86/boot/head.S | 1 + xen/arch/x86/boot/trampoline.S | 23 +++++++++++++++++++++ xen/arch/x86/boot/x86_64.S | 31 +++++++++++++++++++++++++++- xen/arch/x86/include/asm/apicdef.h | 4 ++++ xen/arch/x86/include/asm/msr-index.h | 3 +++ xen/arch/x86/setup.c | 7 +++++++ 6 files changed, 68 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 2c1a0f6306..ff46579904 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -8,6 +8,7 @@ #include #include #include +#include #include #include diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S index a92e399fbe..9306c1bb76 100644 --- a/xen/arch/x86/boot/trampoline.S +++ b/xen/arch/x86/boot/trampoline.S @@ -71,6 +71,29 @@ trampoline_protmode_entry: mov $X86_CR4_PAE,%ecx mov %ecx,%cr4 + /* + * Get APIC ID while we're in non-paged mode to later derive Xen CPU + * index and determine CPU-specific stack. Start by checking if x2APIC + * is enabled. + */ + mov $MSR_APIC_BASE, %ecx + rdmsr + test $APIC_BASE_EXTD, %eax + jnz .Lx2apic + + /* Not x2APIC, read APIC ID from MMIO. */ + and $APIC_BASE_ADDR_MASK, %eax + mov APIC_ID(%eax), %eax + shr $24, %eax + jmp 1f + +.Lx2apic: + mov $(MSR_X2APIC_FIRST + (APIC_ID >> MSR_X2APIC_SHIFT)), %ecx + rdmsr +1: + /* The value of the APIC ID will be consumed in __high_start. */ + mov %eax, %ebp + /* Load pagetable base register. */ mov $sym_offs(idle_pg_table),%eax add bootsym_rel(trampoline_xen_phys_start,4,%eax) diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S index 9705d03f84..19f3062a7b 100644 --- a/xen/arch/x86/boot/x86_64.S +++ b/xen/arch/x86/boot/x86_64.S @@ -11,7 +11,36 @@ ENTRY(__high_start) mov %ecx,%gs mov %ecx,%ss - mov stack_start(%rip),%rsp + /* %ebx is set to non-zero in trampoline.S to indicate an AP. */ + test %ebx, %ebx + cmovz stack_start(%rip), %rsp + jz .L_after_stack_setup + + /* + * APs only: get stack base from APIC ID saved to %ebp in trampoline.S. + */ + mov $-1, %rax + lea x86_cpu_to_apicid(%rip), %rcx +1: + inc %rax + cmp nr_cpu_ids(%rip), %eax + jb 2f + hlt +2: + cmp %ebp, (%rcx, %rax, 4) + jne 1b + + /* %eax is now Xen CPU index. */ + lea stack_base(%rip), %rcx + mov (%rcx, %rax, 8), %rsp + + test %rsp, %rsp + jnz 1f + hlt +1: + add $(STACK_SIZE - CPUINFO_sizeof), %rsp + +.L_after_stack_setup: /* Reset EFLAGS (subsumes CLI and CLD). */ pushq $0 diff --git a/xen/arch/x86/include/asm/apicdef.h b/xen/arch/x86/include/asm/apicdef.h index 112c1dc613..7a09d08b91 100644 --- a/xen/arch/x86/include/asm/apicdef.h +++ b/xen/arch/x86/include/asm/apicdef.h @@ -120,6 +120,10 @@ #define MAX_IO_APICS 128 +#ifndef __ASSEMBLER__ + extern bool x2apic_enabled; +#endif /* !__ASSEMBLER__ */ + #endif diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index ad1c6c97f8..0900e21811 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -186,6 +186,9 @@ #define MSR_X2APIC_FIRST 0x00000800 #define MSR_X2APIC_LAST 0x000008ff +/* MSR offset can be obtained by shifting MMIO offset this number of bits to the right. */ +#define MSR_X2APIC_SHIFT 4 + #define MSR_X2APIC_TPR 0x00000808 #define MSR_X2APIC_PPR 0x0000080a #define MSR_X2APIC_EOI 0x0000080b diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 5494fa1621..fbc44b0174 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -2141,6 +2141,7 @@ void asmlinkage __init noreturn __start_xen(void) */ if ( !pv_shim ) { + /* Separate loop to make parallel AP bringup possible. */ for_each_present_cpu ( i ) { /* Set up cpu_to_node[]. */ @@ -2148,6 +2149,12 @@ void asmlinkage __init noreturn __start_xen(void) /* Set up node_to_cpumask based on cpu_to_node[]. */ numa_add_cpu(i); + if ( stack_base[i] == NULL ) + stack_base[i] = cpu_alloc_stack(i); + } + + for_each_present_cpu ( i ) + { if ( (park_offline_cpus || num_online_cpus() < max_cpus) && !cpu_online(i) ) { -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:10:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:10:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380720.1624447 (Exim 4.92) (envelope-from ) id 1wqVxv-0001tL-76; Sun, 02 Aug 2026 13:10:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380720.1624447; Sun, 02 Aug 2026 13:10:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxv-0001tB-40; Sun, 02 Aug 2026 13:10:55 +0000 Received: by outflank-mailman (input) for mailman id 1380720; Sun, 02 Aug 2026 13:10:53 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqVxt-0001mb-5Z for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:10:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqVxs-001xWz-IX for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:10:52 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f417c-5cb7-0a2a0a5109dd-0a2a450494b6-38 for ; Sun, 02 Aug 2026 15:10:52 +0200 Received: from [46.105.78.111] (helo=9.mo575.mail-out.ovh.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41db-b57f-0a2a45040019-2e694e6fce07-3 for ; Sun, 02 Aug 2026 15:10:52 +0200 Received: from director4.ghost.mail-out.ovh.net (unknown [10.110.0.25]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCv5gCvz5yC5 for ; Sun, 2 Aug 2026 13:10:51 +0000 (UTC) Received: from ghost-submission-7d8d68f679-mmdjj (unknown [10.111.174.62]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id CE7D3C21CD; Sun, 2 Aug 2026 13:10:50 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.107]) by ghost-submission-7d8d68f679-mmdjj with ESMTPSA id 3kn8ItpBb2ouQCEAuGTBVw (envelope-from ); Sun, 02 Aug 2026 13:10:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-107S00173adc3a6-1efd-427d-a375-044976d73348, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , trenchboot-devel@googlegroups.com Subject: [PATCH v4 22/23] xen/arch/x86: add TPR (TXT Protected Range) DMA protection support Date: Sun, 2 Aug 2026 16:09:38 +0300 Message-ID: <8ed1f7368cee0cff23a58307e57cc7674ac33f3f.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4745386632626185660 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTE33bHOuRYjR55j3c0aKJq9LyUAb/VEqKPzbbnohVyg0sOzvTcGgEpNupkNpT0kA5RkCIYWacPED1f5CRgYm6QYZs34c8QczK9TFMGKFcrxaX4rGTDwIGsX2VV0UOdEb3kMbe0OGNl1im0yNBFiDgox63+E3E8fd2OAuJbMS1O4xwld9YJ8XPGcIIH1nNDgFE7Fl6ZKuahgLIsF2gye04vdnhGmKcdC30OZEE6Qh2AGE2vwZgyGoqcrUOVY+fOYmZC3joypOFUGhebsnPOQewACpCWZtmWpz4NqsbMeBA08IBf/10rJZlXY2/jCGwiJRxwa1XYsjVMTivuwcBl6mQPTBA4AjdY5/vlPIkPy495Y9wvlhkevDpwzeUMZ0b5t/BE5NDPsOhOvv+JEjKc6r3MieiWIHtLq5zf5mnjmSlI+BlY2pJIHFtYJGfdurc78OF3KiUN58+xe8RO4TAznmjW3iUAfcR3d4f8k2R9H3eRoZr82CNEDrhZ6I7Im7yJcMvbp9IJFc2xb7x1OvgO0Izsdsa8uCd5ZsaXtbv5zDL0WvQX9AHReLVmyXkihfbvt96xzd39f27OYLH5DKqhs5Q1Gfj4n1HxRaQhpxykFmHNNPeytF3RArwQavj/OK2rxi2TUlxeQqJ8orf8HlZ46g7RPslh6lr565p/2Il4Y7GOg0Q DKIM-Signature: a=rsa-sha256; bh=XRhIvLHiIGKrJOYDdY+rnVnbW5lLaGsiIQXQluDbzAI=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676251; v=1; b=hzOmIa+43lNKkFP7PxEwBlHTNgZInsK1BZTLBg6jOdx4wHgDB8EEuP0lJEfQsjw7u9s3ya5y GVioZfZv1Y8WEZpRdqYZZQfIjtz09Ty8AxKXPAEXiDOCsU6gpjYZ3C0daASWrP/6fiPX/4SOgP7 IHhtVFjw40B/fg0JHHoa4UBiX2TwSTHlWn1+swqZJQmQqeUdAY2DKaYad+IuPGRCXH8vGw0z1L+ YbBklA7ZtKn71tWupNjNV6wEMDHM2I4mNM8XwLhJIOgvOBIn7RUzjFV0zK4mPHcF0RH4wWPd2KR EcHLzhuQJl+pylnvCmhJfGlqLzQCUf5F+7UgNMcrg6kiw== X-purgate-ID: tlsNG-ebf023/1785676252-51CD7B50-5F158D66/0/0 X-purgate-type: clean X-purgate-size: 14489 From: Szymon Acedański Pointer to txt_os_sinit_data variables lost constness due to the use of txt_find_ext_data_element() which needs to work in a non-const context as well for its other use. This is required for modern Intel CPUs (at least LunarLake) that no longer support PMR (Protected Memory Regions) protection mechanism. Unlike PMR, TPR is not related to Intel VT-d, independent from IOMMU and, despite its name, is not tied to TXT. The next generation (PantherLake) similarly supports only PMR but seems to have an undocumented requirement that TPR protection must be disabled or device initialization fails (NVMe/USB/NIC). This is not done by this patch. Signed-off-by: Szymon Acedański Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Sergii Dmytruk --- Notes: v4: new commit in this version, needed for modern devices xen/arch/x86/boot/head.S | 4 +- xen/arch/x86/boot/slaunch-early.c | 6 +- xen/arch/x86/efi/efi-boot.h | 7 +- xen/arch/x86/include/asm/intel-txt.h | 182 +++++++++++++++++++++------ 4 files changed, 151 insertions(+), 48 deletions(-) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 22b331a45c..ac177839d1 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -136,12 +136,12 @@ SYM(mle_header, DATA, LOCAL, 16) .long 0xa2555c0f /* UUID2 */ .long 0x42b651cb /* UUID3 */ .long (.Lmle_header_end - mle_header) /* MLE header size */ - .long 0x00020002 /* MLE version 2.2 */ + .long 0x00020003 /* MLE version 2.3 */ .long (slaunch_stub_entry - start) /* Linear entry point of MLE (SINIT virt. address) */ .long 0x00000000 /* First valid page of MLE */ .long 0x00000000 /* Offset within binary of first byte of MLE */ .long (__base_relocs_end - start) /* Offset within binary of last byte + 1 of MLE */ - .long 0x00000723 /* Bit vector of MLE-supported capabilities */ + .long 0x00004723 /* Bit vector of MLE-supported capabilities */ .long 0x00000000 /* Starting linear address of command line (unused) */ .long 0x00000000 /* Ending linear address of command line (unused) */ .Lmle_header_end: diff --git a/xen/arch/x86/boot/slaunch-early.c b/xen/arch/x86/boot/slaunch-early.c index 9b16602ac8..7348a3d156 100644 --- a/xen/arch/x86/boot/slaunch-early.c +++ b/xen/arch/x86/boot/slaunch-early.c @@ -35,7 +35,7 @@ void asmlinkage slaunch_early_init(uint32_t load_base_addr, void *txt_heap; const struct txt_os_mle_data *os_mle; const struct slr_table *slrt; - const struct txt_os_sinit_data *os_sinit; + struct txt_os_sinit_data *os_sinit; const struct slr_entry_hdr *entry; const struct slr_entry_intel_info *intel_info; uint32_t size = tgt_end_addr - tgt_base_addr; @@ -99,6 +99,6 @@ void asmlinkage slaunch_early_init(uint32_t load_base_addr, result->mbi_pa = intel_info->boot_params_base; - txt_verify_pmr_ranges(os_mle, os_sinit, intel_info, - load_base_addr, tgt_base_addr, size); + txt_verify_dma_protection(os_mle, os_sinit, intel_info, + load_base_addr, tgt_base_addr, size); } diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 9653de4ca9..573d1938c6 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -261,11 +261,12 @@ void __init asmlinkage noreturn start_xen_from_efi(void) void *txt_heap = txt_init(); const struct txt_os_mle_data *os_mle = txt_start(txt_heap, TXT_OS2MLE); - const struct txt_os_sinit_data *os_sinit = + struct txt_os_sinit_data *os_sinit = txt_start(txt_heap, TXT_OS2SINIT); - txt_verify_pmr_ranges(os_mle, os_sinit, intel_info, xen_phys_start, - xen_phys_start, xen_image_size); + txt_verify_dma_protection(os_mle, os_sinit, intel_info, + xen_phys_start, xen_phys_start, + xen_image_size); } } diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h index eb15bf68ad..0fd2fb6fdd 100644 --- a/xen/arch/x86/include/asm/intel-txt.h +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -65,6 +65,12 @@ #define SLAUNCH_ERROR_NO_VENDOR_INFO 0xc0008009U #define SLAUNCH_ERROR_BAD_VENDOR_INFO 0xc000800AU #define SLAUNCH_ERROR_BAD_SLRT_ADDRESS 0xc000800BU +#define SLAUNCH_ERROR_TPR_INVALID 0xc000800CU +#define SLAUNCH_ERROR_TPR_UNSUPPORTED 0xc000800DU +#define SLAUNCH_ERROR_TPR_NOT_FOUND 0xc000800EU + +/* SINIT/MLE capability bit for TPR (TXT Protected Range) DMA protection. */ +#define TXT_SINIT_MLE_CAP_TPR_SUPPORT 14 #ifndef __ASSEMBLER__ @@ -253,6 +259,19 @@ struct heap_event_log_pointer_element2_1 { uint32_t next_record_offset; } __packed; +/* + * Extended data describing TPR (TXT Protected Range) DMA protection ranges. + */ +struct txt_heap_tpr_range { + uint64_t base; + uint64_t size; +} __packed; + +struct txt_heap_tpr_req_element { + uint32_t count; + struct txt_heap_tpr_range ranges[0]; +} __packed; + /* * Functions to extract data from the Intel TXT Heap Memory. * @@ -342,67 +361,150 @@ txt_find_ext_data_element(struct txt_os_sinit_data *os_sinit, uint32_t type) return NULL; } -static inline bool is_in_pmr(const struct txt_os_sinit_data *os_sinit, - uint64_t base, uint32_t size, bool check_high) +static inline bool is_in_dma_prot(struct txt_os_sinit_data *os_sinit, + uint64_t base, uint32_t size, bool check_high) { + uint64_t lo_size, hi_base, hi_size; + /* Check for size overflow. */ if ( base + size < base ) txt_reset(SLAUNCH_ERROR_INTEGER_OVERFLOW); + if ( os_sinit->capabilities & (1u << TXT_SINIT_MLE_CAP_TPR_SUPPORT) ) + { + /* + * txt_verify_dma_protection() has already validated presence and contents + * of the TPR_REQ element. + */ + const struct txt_heap_tpr_req_element *tpr_req = (const struct txt_heap_tpr_req_element *) + txt_find_ext_data_element(os_sinit, TXT_HEAP_EXTDATA_TYPE_TPR_REQ)->data; + + lo_size = tpr_req->ranges[0].size; + if ( tpr_req->count > 1 ) + { + hi_base = tpr_req->ranges[1].base; + hi_size = tpr_req->ranges[1].size; + } + else + { + hi_base = 0; + hi_size = 0; + } + } + else + { + lo_size = os_sinit->vtd_pmr_lo_size; + hi_base = os_sinit->vtd_pmr_hi_base; + hi_size = os_sinit->vtd_pmr_hi_size; + } + /* - * txt_verify_pmr_ranges() makes sure the low range always starts at 0, so - * its size is also end address. + * txt_verify_dma_protection() makes sure the low range always starts at + * 0, so its size is also end address. */ - if ( base + size <= os_sinit->vtd_pmr_lo_size ) + if ( base + size <= lo_size ) return true; - if ( check_high && os_sinit->vtd_pmr_hi_size != 0 ) + if ( check_high && hi_size != 0 ) { - if ( base >= os_sinit->vtd_pmr_hi_base && - base + size <= os_sinit->vtd_pmr_hi_base + - os_sinit->vtd_pmr_hi_size ) + if ( base >= hi_base && base + size <= hi_base + hi_size ) return true; } return false; } -static inline void txt_verify_pmr_ranges( +static inline void txt_verify_dma_protection( const struct txt_os_mle_data *os_mle, - const struct txt_os_sinit_data *os_sinit, + struct txt_os_sinit_data *os_sinit, const struct slr_entry_intel_info *info, uint32_t load_base_addr, uint32_t tgt_base_addr, uint32_t xen_size) { - bool check_high_pmr = false; + bool check_high = false; - /* Verify the value of the low PMR base. It should always be 0. */ - if ( os_sinit->vtd_pmr_lo_base != 0 ) - txt_reset(SLAUNCH_ERROR_LO_PMR_BASE); + if ( os_sinit->capabilities & (1u << TXT_SINIT_MLE_CAP_TPR_SUPPORT) ) + { + const struct txt_ext_data_element *tpr_req_data_element; + const struct txt_heap_tpr_req_element *tpr_req; - /* - * Low PMR size should not be 0 on current platforms. There is an ongoing - * transition to TPR-based DMA protection instead of PMR-based; this is not - * yet supported by the code. - */ - if ( os_sinit->vtd_pmr_lo_size == 0 ) - txt_reset(SLAUNCH_ERROR_LO_PMR_SIZE); + /* + * For TPR-based DMA protection, it's not specified that the low + * range must begin at address 0. For now though, we support only + * 1- and 2-range configurations with the low range starting at 0. + */ - /* Check if regions overlap. Treat regions with no hole between as error. */ - if ( os_sinit->vtd_pmr_hi_size != 0 && - os_sinit->vtd_pmr_hi_base <= os_sinit->vtd_pmr_lo_size ) - txt_reset(SLAUNCH_ERROR_HI_PMR_BASE); + tpr_req_data_element = txt_find_ext_data_element(os_sinit, TXT_HEAP_EXTDATA_TYPE_TPR_REQ); + if ( tpr_req_data_element == NULL ) + txt_reset(SLAUNCH_ERROR_TPR_NOT_FOUND); + if ( tpr_req_data_element->size < sizeof(struct txt_heap_tpr_req_element) ) + txt_reset(SLAUNCH_ERROR_TPR_INVALID); + tpr_req = (const struct txt_heap_tpr_req_element *)tpr_req_data_element->data; + if ( tpr_req->count < 1 ) + txt_reset(SLAUNCH_ERROR_TPR_INVALID); + if ( tpr_req->count > 2 ) + txt_reset(SLAUNCH_ERROR_TPR_UNSUPPORTED); + + /* Low range must start at 0. */ + if ( tpr_req->ranges[0].base != 0 ) + txt_reset(SLAUNCH_ERROR_TPR_UNSUPPORTED); + + /* Size must not be 0. */ + if ( tpr_req->ranges[0].size == 0 ) + txt_reset(SLAUNCH_ERROR_TPR_INVALID); + + if ( tpr_req->count > 1 ) + { + /* Size must not be 0. */ + if ( tpr_req->ranges[1].size == 0 ) + txt_reset(SLAUNCH_ERROR_TPR_INVALID); + + /* Ranges must not overlap. */ + if ( tpr_req->ranges[0].size > tpr_req->ranges[1].base ) + txt_reset(SLAUNCH_ERROR_TPR_INVALID); + + /* Overflow check. */ + if ( tpr_req->ranges[1].base + tpr_req->ranges[1].size < tpr_req->ranges[1].size ) + txt_reset(SLAUNCH_ERROR_INTEGER_OVERFLOW); + + /* All regions accessed by 32b code must be below 4G. */ + if ( tpr_req->ranges[1].base + tpr_req->ranges[1].size <= + 0x100000000ULL ) + check_high = true; + } + } + else + { + /* Verify the value of the low PMR base. It should always be 0. */ + if ( os_sinit->vtd_pmr_lo_base != 0 ) + txt_reset(SLAUNCH_ERROR_LO_PMR_BASE); - /* Check for size overflow. */ - if ( os_sinit->vtd_pmr_hi_base + os_sinit->vtd_pmr_hi_size < - os_sinit->vtd_pmr_hi_size ) - txt_reset(SLAUNCH_ERROR_INTEGER_OVERFLOW); + /* + * Low PMR size should not be 0 on current platforms when PMR mode is + * in use. + */ + if ( os_sinit->vtd_pmr_lo_size == 0 ) + txt_reset(SLAUNCH_ERROR_LO_PMR_SIZE); - /* All regions accessed by 32b code must be below 4G. */ - if ( os_sinit->vtd_pmr_hi_base + os_sinit->vtd_pmr_hi_size <= - 0x100000000ULL ) - check_high_pmr = true; + /* + * Check if regions overlap. Treat regions with no hole between as + * error. + */ + if ( os_sinit->vtd_pmr_hi_size != 0 && + os_sinit->vtd_pmr_hi_base <= os_sinit->vtd_pmr_lo_size ) + txt_reset(SLAUNCH_ERROR_HI_PMR_BASE); + + /* Check for size overflow. */ + if ( os_sinit->vtd_pmr_hi_base + os_sinit->vtd_pmr_hi_size < + os_sinit->vtd_pmr_hi_size ) + txt_reset(SLAUNCH_ERROR_INTEGER_OVERFLOW); + + /* All regions accessed by 32b code must be below 4G. */ + if ( os_sinit->vtd_pmr_hi_base + os_sinit->vtd_pmr_hi_size <= + 0x100000000ULL ) + check_high = true; + } /* * ACM checks that TXT heap and MLE memory is protected against DMA. We have @@ -412,12 +514,12 @@ static inline void txt_verify_pmr_ranges( */ /* Check if all of Xen before relocation is protected. */ - if ( !is_in_pmr(os_sinit, load_base_addr, xen_size, check_high_pmr) ) + if ( !is_in_dma_prot(os_sinit, load_base_addr, xen_size, check_high) ) txt_reset(SLAUNCH_ERROR_LO_PMR_MLE); /* Check if all of Xen after relocation is protected. */ if ( load_base_addr != tgt_base_addr && - !is_in_pmr(os_sinit, tgt_base_addr, xen_size, check_high_pmr) ) + !is_in_dma_prot(os_sinit, tgt_base_addr, xen_size, check_high) ) txt_reset(SLAUNCH_ERROR_LO_PMR_MLE); /* If present, check that MBI is protected. */ @@ -426,8 +528,8 @@ static inline void txt_verify_pmr_ranges( const multiboot2_fixed_t *mbi = (const multiboot2_fixed_t *)(uintptr_t)info->boot_params_base; - if ( !is_in_pmr(os_sinit, info->boot_params_base, mbi->total_size, - check_high_pmr) ) + if ( !is_in_dma_prot(os_sinit, info->boot_params_base, mbi->total_size, + check_high) ) txt_reset(SLAUNCH_ERROR_BUFFER_BEYOND_PMR); } @@ -451,8 +553,8 @@ static inline void txt_verify_pmr_ranges( */ /* if ( os_mle->evtlog_addr != 0 && os_mle->evtlog_size != 0 && - !is_in_pmr(os_sinit, os_mle->evtlog_addr, os_mle->evtlog_size, - check_high_pmr) ) + !is_in_dma_prot(os_sinit, os_mle->evtlog_addr, os_mle->evtlog_size, + check_high) ) txt_reset(SLAUNCH_ERROR_BUFFER_BEYOND_PMR); */ } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:17:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380749.1624457 (Exim 4.92) (envelope-from ) id 1wqW4J-0003Qe-Su; Sun, 02 Aug 2026 13:17:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380749.1624457; Sun, 02 Aug 2026 13:17:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4J-0003QX-P6; Sun, 02 Aug 2026 13:17:31 +0000 Received: by outflank-mailman (input) for mailman id 1380749; Sun, 02 Aug 2026 13:17:30 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4I-0003QO-FV for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:17:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqW4H-0084CP-Kx for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:17:29 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4336-2eae-0a2a0a5409dd-0a2a450ce7a6-36 for ; Sun, 02 Aug 2026 15:17:29 +0200 Received: from [46.105.63.230] (helo=7.mo575.mail-out.ovh.net) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41c4-f479-0a2a450c0019-2e693fe6d995-3 for ; Sun, 02 Aug 2026 15:10:28 +0200 Received: from director2.ghost.mail-out.ovh.net (unknown [10.109.231.104]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCS41Xgz5x9r for ; Sun, 2 Aug 2026 13:10:28 +0000 (UTC) Received: from ghost-submission-7d8d68f679-4j9th (unknown [10.110.164.1]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id D7F99C076B; Sun, 2 Aug 2026 13:10:27 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.106]) by ghost-submission-7d8d68f679-4j9th with ESMTPSA id uj/0KMNBb2pAxRsAfFlxhA (envelope-from ); Sun, 02 Aug 2026 13:10:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-106R00637ba2a53-4aa7-4a04-ab4f-2f442dba9a54, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 15/23] x86/hvm: check for VMX in SMX if Slaunch is active Date: Sun, 2 Aug 2026 16:09:31 +0300 Message-ID: <239c0018e4c51a00bf4134971d3e15bf73947042.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4738912709584758204 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEO37Lm1soAj3J6HJwxZueJ91jNrKiCMD9VOxO+7S6oZcwX5ZhHy/rf+u1q3gsSFBR0MQ0G/W66mTSt5xumJoxY/EyDpxdVBT5aAA1fHupbW88f/IumzeClwwf3PGe5NCfIC4rAkaw9D49zl0L3FOqYw1yebY9XQZPEoEgqOhxU7iAITzoi4rSZJugXTxFrfgz5z3QYtYzrLSr0w464iDE2Jv+mfsQyDLbPqlC9XEGpFu9KBxFx07+KPXWsR6kr02Tgk2fJ3ulvjdiKijPJd2EPMcqID96OcOqj/uCF/V+6MYDFkW6NlVR5eWMFf+caoPBoCiQxHguJ/BWn2Nt+/d7LATLWy5uqTTYj8J0/VIlB7Zr0UhD/TGfijKUeNyIPDm3FNpzp7pAf5HCApOpKHKQAb3AHHyNlWfRyCdBrl2KexZBO+lUhUJhvSDWOvNVAM86kgUGxIbclAGz/zqAY8mQPB9gRquoFl/TJil04BBnx7enN7C2vdr+VA815b7S7rnOfIG1HRCwa53xu7oq5j8Jrk6vjnkxNemCkv1uxLGicCXcqfnOKl7UWejOh2fCFkM3x91o+8ufujVu7FXL6cKL0E5t+EbdHc11s/FCv80dpUD+DaiQWKUwGAij4tcrP/hC6VUH4U7N30B6kSSAEkw8VGa5RLTdAF0hBUqrFdxCBnw DKIM-Signature: a=rsa-sha256; bh=CxIu903ncrohvbZGr5K789lKkzZuj0GGkRH1KVPxQwk=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676228; v=1; b=M/JtvsIAXXQ+z1xjEV7S+QcPMQ8cv+B9mCdM49UNJ7PO3qHZsIsQf5hIP8CkEQuh6tx0mJMp iPEH7wt3pzETmgdpBwSDECGzxOfXdGB9pp6CrHN9q8y9xCiZ/w7y6D46uPDgmTcDcYrKiUhqs85 rYqHpuazZgH7ocDhT+dOWgj/3+o9q+R+I7pVjsZQEYEFpjRXICz6jxPbmjIZZCzPRWTDopqAGM4 r1Wbaf+jncSkp/xPV+3PNIQSCUwRS5lby1+R9RtrO0nYnXyatw2lSrnm71ztFCkA/6An7qkYDr7 LOWRPHpotE5JwY/jdO1Ll5JLIwZBq8wgxZPGvzZPgewVg== X-purgate-ID: tlsNG-d25034/1785676229-766DEA5B-9E11368F/0/0 X-purgate-type: clean X-purgate-size: 1271 From: Michał Żygowski Check whther IA32_FEATURE_CONTROL has the proper bits enabled to run VMX in SMX when slaunch is active. Signed-off-by: Michał Żygowski Signed-off-by: Sergii Dmytruk Acked-by: Jan Beulich --- Notes: v4: added Acked-by xen/arch/x86/hvm/vmx/vmcs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 8e52ef4d49..3c5dfd7c1b 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -742,7 +743,7 @@ static int _vmx_cpu_up(bool bsp) bios_locked = !!(eax & IA32_FEATURE_CONTROL_LOCK); if ( bios_locked ) { - if ( !(eax & (tboot_in_measured_env() + if ( !(eax & (tboot_in_measured_env() || slaunch_active ? IA32_FEATURE_CONTROL_ENABLE_VMXON_INSIDE_SMX : IA32_FEATURE_CONTROL_ENABLE_VMXON_OUTSIDE_SMX)) ) { -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:17:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:17:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380750.1624466 (Exim 4.92) (envelope-from ) id 1wqW4P-0003g4-3B; Sun, 02 Aug 2026 13:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380750.1624466; Sun, 02 Aug 2026 13:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4P-0003ft-0J; Sun, 02 Aug 2026 13:17:37 +0000 Received: by outflank-mailman (input) for mailman id 1380750; Sun, 02 Aug 2026 13:17:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4O-0003eV-9Q for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:17:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqW4N-00Bn6b-Mh for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:17:35 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f432c-bab6-0a2a0a5309dd-0a2a450aad66-34 for ; Sun, 02 Aug 2026 15:17:35 +0200 Received: from [87.98.178.36] (helo=5.mo561.mail-out.ovh.net) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41ca-f2d2-0a2a450a0019-5762b224da49-3 for ; Sun, 02 Aug 2026 15:10:34 +0200 Received: from director8.ghost.mail-out.ovh.net (unknown [10.109.231.242]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCZ1mvPz5xXb for ; Sun, 2 Aug 2026 13:10:34 +0000 (UTC) Received: from ghost-submission-7d8d68f679-7fkfz (unknown [10.110.178.196]) by director8.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 5D638C011C; Sun, 2 Aug 2026 13:10:33 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.95]) by ghost-submission-7d8d68f679-7fkfz with ESMTPSA id ySKADMlBb2rUsRoA5cIDVQ (envelope-from ); Sun, 02 Aug 2026 13:10:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-95G0019eb63cc7-1ece-468f-9b24-b7232bc7e4f6, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 17/23] x86/smpboot.c: TXT AP bringup Date: Sun, 2 Aug 2026 16:09:33 +0300 Message-ID: <7e23a48a8de4d6784c084f679c1362fdab22dd13.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4740601558912869820 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEV0zrRFI+8lKEQL+a1JI/7/0OrRJXjCVgGfW7fQN9qAaB9I3Brjm6G89cK6Ny30hIcTAKPzAOTqm+s8tXkHnzgivH613CtFsQhOqga+yav7fPvP7w6BCXsI971V+GKiHDssWsfTkzH71jEMdFAbdaH1gcYdPIddXko9jx50f4vfKOvZlTEh3piMuIRXjgxOe4w13mGdXJsWHKUemKBTBOZDknXtV88Avn3A1+DntFDWTSNHai88JS8wTtwj8VGV6geimdMBGQm1RTU996cjVSnv+0TRVzyqsv/449ido10EPKQw0SJ1AFr+cl9aJ11yniAGMNpIunYYGM5DWILNH39oDlve2TeG2GhFL7Lzvl0aTgC88dJTCVYLbM30HO/PwjqXw9lYNyERtOUR2eMMlRBrbhG7FZp/iW1wpbir5tOO2/Q4/ZPug0ZYEuQJpGDSUQgr9cLECPD9BqGKtjPm0/Aif96FIl4HMPh5rGrBYa3GpfTCRyhbCNX+QpfIq/4epOpj9zb4ZectFM8nnHPb1RTnRNL8jBQrZAlVpoKZwEBsQzW4BMvL2mceMEjPz/viZXi/rksmq63v8bVsCSEx+wVVRvbZtk8Q6P0nkPYSupO5+Wi3EkredGszkN2KkixYJHcFkwSscEYN9IIteCJJQjveh8EkoKBNHVEfh/o1nEqYg DKIM-Signature: a=rsa-sha256; bh=qgxp9JUvBhn9rB5VsxLIqx1c2ElEewxhPrQYLLC8PSg=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676234; v=1; b=QTX+L5oUiDz9fb6Pfi/gnCfeez8Gvj68o6IEsQp0gGLKnC06viyyM9sRs3awrFezjZGW8ODu CL6hSgjAQxGRyAPPdb7Kd57oJYNXtAd3JlIQLMJC75N4bqVCSm26w8nOZJd2fP+QNDm9PgXIkLl lqVY+iilQ9x0s+JNUlxyigFe0MBxaMSzoVVWQtLOyuMjsYx/hvKApwxrHdahMotmVPisqxh71fj /u0VJ7eCXZDc/ovVU1Km4VKLqPgiMWUgDyVf3FF1DN1mhxa4Eo3N1Eb5fAg1eJTTT6tAzRAeE6q jLl9ExmUj3jqGCpDrLt77RmBECHeRyhBr9TJdNMJ4SJbg== X-purgate-ID: tlsNG-4011c0/1785676234-5A5DBCFC-C1D39C19/0/0 X-purgate-type: clean X-purgate-size: 11255 From: Krystian Hebel On Intel TXT, APs are started in one of two ways, depending on ACM which reports it in its information table. In both cases, all APs are started simultaneously after BSP requests them to do so. Two possible ways are: - GETSEC[WAKEUP] instruction, - MONITOR address. GETSEC[WAKEUP] requires versions >= 7 of SINIT to MLE Data, but there is no clear mapping of that version with regard to processor family and it's not known which CPUs actually use it. It could have been designed for TXT support on CPUs that lack MONITOR/MWAIT, because GETSEC[WAKEUP] seems to be more complicated, in software and hardware alike. This patch implements only MONITOR approach, GETSEC[WAKEUP] support will be added later once more details and means of testing are available and if there is a practical need for it. With this patch, every AP goes through assembly part, and only when in start_secondary() in C they re-enter MONITOR/MWAIT iff they are not the AP that was asked to boot. The same address is reused for simplicity, and on next wakeup call APs don't have to go through assembly part again (GDT, paging, stack setting). Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk Signed-off-by: Szymon Acedański Assisted-by: Claude:claude-opus-4-6 Signed-off-by: Michał Iwanicki --- Notes: v4: replace TXT_AP_BOOT_CS and TXT_AP_BOOT_DS with trampoline_gdt_txt and computing CS v4: make APs call C from __high_start to synchronize with BSP v4: recheck condition between `monitor` and `mwait` instructions v4: write to wakeup address only once (all APs are woken up at once) v4: make JOIN variable static as it's not read synchronously v4: when an AP waits for a wakeup, monitor the variable that's expected to change xen/arch/x86/boot/trampoline.S | 19 ++++++- xen/arch/x86/boot/x86_64.S | 24 ++++++++- xen/arch/x86/include/asm/intel-txt.h | 5 ++ xen/arch/x86/include/asm/processor.h | 1 + xen/arch/x86/smpboot.c | 75 ++++++++++++++++++++++++++++ xen/arch/x86/x86_64/asm-offsets.c | 3 ++ 6 files changed, 125 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S index 9306c1bb76..4208bd75b8 100644 --- a/xen/arch/x86/boot/trampoline.S +++ b/xen/arch/x86/boot/trampoline.S @@ -58,6 +58,16 @@ GLOBAL(entry_SIPI16) ljmpl $BOOT_CS32,$bootsym_rel(trampoline_protmode_entry,6) .code32 +GLOBAL(txt_ap_entry) + /* + * APs enter here in protected mode without paging. GDT is set in JOIN + * structure, it points to trampoline_gdt. Interrupts are disabled by + * TXT (including NMI and SMI), so IDT doesn't matter at this point. + * The only missing point is telling that we are AP by saving non-zero + * value in EBX. + */ + mov $1, %ebx + trampoline_protmode_entry: /* Set up a few descriptors: on entry only CS is guaranteed good. */ mov $BOOT_DS,%eax @@ -145,7 +155,7 @@ start64: .word 0 idt_48: .word 0, 0, 0 # base = limit = 0 -trampoline_gdt: +GLOBAL(trampoline_gdt) .word 0 /* 0x0000: unused (reused for GDTR) */ gdt_48: .word .Ltrampoline_gdt_end - trampoline_gdt - 1 @@ -156,6 +166,13 @@ gdt_48: .quad 0x00cf93000000ffff /* 0x0018: ring 0 data */ .quad 0x00009b000000ffff /* 0x0020: real-mode code @ BOOT_TRAMPOLINE */ .quad 0x000093000000ffff /* 0x0028: real-mode data @ BOOT_TRAMPOLINE */ + /* + * Intel TXT requires these two in exact order. This isn't compatible + * with the order required by syscall, so we have duplicated entries... + */ +GLOBAL(trampoline_gdt_txt) + .quad 0x00cf9b000000ffff /* 0x0030: ring 0 code, 32-bit mode */ + .quad 0x00cf93000000ffff /* 0x0038: ring 0 data */ .Ltrampoline_gdt_end: /* Relocations for trampoline Real Mode segments. */ diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S index 19f3062a7b..886960c22f 100644 --- a/xen/arch/x86/boot/x86_64.S +++ b/xen/arch/x86/boot/x86_64.S @@ -30,7 +30,10 @@ ENTRY(__high_start) cmp %ebp, (%rcx, %rax, 4) jne 1b - /* %eax is now Xen CPU index. */ + mov %ebp, %edx + + /* %eax is now Xen CPU index, %edx is APIC ID. */ + lea stack_base(%rip), %rcx mov (%rcx, %rax, 8), %rsp @@ -40,6 +43,25 @@ ENTRY(__high_start) 1: add $(STACK_SIZE - CPUINFO_sizeof), %rsp + /* + * TXT AP gate. + * + * In TXT boot, SINIT releases all APs at once and they race into + * __high_start in parallel. We serialize APs initialization here + * to force them waking up in order expected by the BSP. + * + * The gate must be placed before STACK_CPUINFO_FIELD(cr4) is written + * below: for each AP, the BSP memsets that AP's cpu_info struct in + * cpu_smpboot_alloc() just before releasing it through the gate, so + * anything written earlier would be clobbered. + * + * In non-TXT boot, APs wake one-by-one via SIPI. + */ + cmpl $ASM_AP_BOOT_TXT, ap_boot_method(%rip) + jne .L_after_stack_setup + mov %edx, %edi + call txt_ap_gate + .L_after_stack_setup: /* Reset EFLAGS (subsumes CLI and CLD). */ diff --git a/xen/arch/x86/include/asm/intel-txt.h b/xen/arch/x86/include/asm/intel-txt.h index 8bcca20d6e..eb15bf68ad 100644 --- a/xen/arch/x86/include/asm/intel-txt.h +++ b/xen/arch/x86/include/asm/intel-txt.h @@ -83,6 +83,11 @@ #define _txt(x) __va(x) #endif +extern char txt_ap_entry[]; +extern uint64_t trampoline_gdt[]; +/* Points at CS selector for TXT, DS selector follows. */ +extern uint64_t trampoline_gdt_txt[]; + /* * Always use private space as some of registers are either read-only or not * present in public space. diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 8ca6799a81..2c6e7b772f 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -436,6 +436,7 @@ void set_in_pb_opt_ctrl(uint32_t mask, uint32_t val); enum ap_boot_method { AP_BOOT_NORMAL, AP_BOOT_SKINIT, + AP_BOOT_TXT, }; extern enum ap_boot_method ap_boot_method; diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index 84e9e4beed..cdad60d5e4 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -38,6 +39,7 @@ #include #include #include +#include #include #include #include @@ -239,6 +241,32 @@ static void smp_callin(void) cpu_relax(); } +/* + * ACPI ID of the AP to be released by txt_ap_gate() next. Gets set in + * wake_ap_in_txt() after which do_boot_cpu() waits for the AP to initialize + * itself. + */ +static int txt_booting_apicid; + +void asmlinkage txt_ap_gate(int apicid) +{ + uint64_t misc_enable; + + /* TXT released us with MONITOR disabled in IA32_MISC_ENABLE. */ + misc_enable = rdmsr(MSR_IA32_MISC_ENABLE); + wrmsr(MSR_IA32_MISC_ENABLE, + misc_enable | MSR_IA32_MISC_ENABLE_MONITOR_ENABLE); + + while ( txt_booting_apicid != apicid ) + { + asm volatile ( "monitor" + :: "a"(&txt_booting_apicid), "c"(0), "d"(0) : "memory" ); + if ( txt_booting_apicid == apicid ) + break; + asm volatile ( "mwait" :: "a"(0), "c"(0) ); + } +} + /* CPUs for which sibling maps can be computed. */ static cpumask_t cpu_sibling_setup_map; @@ -417,6 +445,37 @@ void asmlinkage start_secondary(void) startup_cpu_idle_loop(); } +static int wake_ap_in_txt(int phys_apicid) +{ + static uint32_t join[4]; + + txt_booting_apicid = phys_apicid; + smp_mb(); + + /* + * All APs are released at the same time on the first write to wakeup + * address, which happens on the first invocation. Because the write isn't + * handled synchronously, the JOIN structure must outlive this function. + */ + if (join[0] == 0) + { + const struct txt_sinit_mle_data *sinit_mle = + txt_start(__va(txt_read(TXTCR_HEAP_BASE)), TXT_SINIT2MLE); + uint32_t *wakeup_addr = __va(sinit_mle->rlp_wakeup_addr); + + join[0] = trampoline_gdt[0] >> 32; /* GDT limit */ + join[1] = bootsym_phys(trampoline_gdt); /* GDT base */ + join[2] = (trampoline_gdt_txt - trampoline_gdt) * 8; /* CS selector */ + /* DS = CS + 8 */ + join[3] = bootsym_phys(txt_ap_entry); /* EIP */ + + txt_write(TXTCR_MLE_JOIN, __pa(join)); + *wakeup_addr = 1; + } + + return 0; +} + static int wakeup_secondary_cpu(int phys_apicid, unsigned long start_eip) { unsigned long send_status = 0, accept_status = 0; @@ -439,6 +498,9 @@ static int wakeup_secondary_cpu(int phys_apicid, unsigned long start_eip) if ( tboot_in_measured_env() && !tboot_wake_ap(phys_apicid, start_eip) ) return 0; + if ( ap_boot_method == AP_BOOT_TXT ) + return wake_ap_in_txt(phys_apicid); + /* * Be paranoid about clearing APIC errors. */ @@ -1165,6 +1227,13 @@ static struct notifier_block cpu_smpboot_nfb = { void __init smp_prepare_cpus(void) { + /* + * If the platform is performing a Secure Launch via TXT, secondary + * CPUs (APs) will need to be woken up in a TXT-specific way. + */ + if ( slaunch_active && boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) + ap_boot_method = AP_BOOT_TXT; + register_cpu_notifier(&cpu_smpboot_nfb); mtrr_aps_sync_begin(); @@ -1454,6 +1523,12 @@ void __init smp_cpus_done(void) mtrr_save_state(); mtrr_aps_sync_end(); + + /* + * After the initial startup the DRTM-specific method for booting APs + * should no longer be used unless DRTM sequence is started again. + */ + ap_boot_method = AP_BOOT_NORMAL; } void __init smp_intr_init(void) diff --git a/xen/arch/x86/x86_64/asm-offsets.c b/xen/arch/x86/x86_64/asm-offsets.c index f0aaf0f4ba..94f2995fff 100644 --- a/xen/arch/x86/x86_64/asm-offsets.c +++ b/xen/arch/x86/x86_64/asm-offsets.c @@ -246,4 +246,7 @@ void __dummy__(void) DEFINE(SL_EIR_size, sizeof(struct slaunch_early_init_results)); BLANK(); #endif + + DEFINE(ASM_AP_BOOT_TXT, AP_BOOT_TXT); + BLANK(); } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:17:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:17:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380752.1624475 (Exim 4.92) (envelope-from ) id 1wqW4S-0003ww-Dp; Sun, 02 Aug 2026 13:17:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380752.1624475; Sun, 02 Aug 2026 13:17:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4S-0003wo-AS; Sun, 02 Aug 2026 13:17:40 +0000 Received: by outflank-mailman (input) for mailman id 1380752; Sun, 02 Aug 2026 13:17:39 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4R-0003uD-0U for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:17:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqW4Q-001yKT-DN for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:17:38 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4331-5cb7-0a2a0a5109dd-0a2a45099578-26 for ; Sun, 02 Aug 2026 15:17:38 +0200 Received: from [46.105.50.107] (helo=6.mo576.mail-out.ovh.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41cc-be1a-0a2a45090019-2e69326b862f-3 for ; Sun, 02 Aug 2026 15:10:37 +0200 Received: from director8.ghost.mail-out.ovh.net (unknown [10.110.58.216]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCc5yvcz5wtD for ; Sun, 2 Aug 2026 13:10:36 +0000 (UTC) Received: from ghost-submission-7d8d68f679-j8ww2 (unknown [10.110.178.62]) by director8.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 35CFAC011C; Sun, 2 Aug 2026 13:10:36 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.101]) by ghost-submission-7d8d68f679-j8ww2 with ESMTPSA id EbDxBMxBb2oerBcAMfbduw (envelope-from ); Sun, 02 Aug 2026 13:10:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-101G0047759a04e-fb70-40cd-9ab5-d3d0ce46f05c, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Ross Philipson , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 18/23] x86/slaunch: process DRTM policy Date: Sun, 2 Aug 2026 16:09:34 +0300 Message-ID: <61c6b09b209572b5db6d8a17cf050f68a19b7ebe.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4741164507921524156 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEtK5p0SNYtBef44Zaajhk33i63wmjVwNNhJ4YROChk7mhZcpyT3bd5ACP3F2TkAykP416Z/qj7tU2KxG1rTRS8MypF1KRhaA/AvmFdmp6hM2n75hgvTPUkRMkZtHtCy5BQJTDAa5dye2uRhTva5lFRUMRQoQfXqDmPkoEsCcMiOXhj8LDb8bxT7fPbPw+L6oM3Ib4+Crk5z3znR8b12WvIauAwvZwi4TwyXrVt8t5cjjf6p6tk/jAP3JPPWAt8lJLbOqKqZPj2dLVv8AcggN/kQjhcbgaHkG9r5s4innAGR9o3gaGzW+PeUVjPnviytxFmoTk+gQnhQiwpJq7s595nY/XulObR4LpT8CCnpFEKUXa8Q3HNZgL1ABzJpjIi1J6AUI57hEg5iL0XtsQM1M+2lwUzz8WW8LK669P7w3SID8V/gy/GOVLQWv88pspKZVplcVpcw/OCEK21n1+RL2t3IPTGZl78dGk0Htq+5ZfF7n4xhyrK4aAg/Vd7dWF4m2RJsQDJQnJAvAhWs4FxAd3pjzjuzmMB5u+AF7fvUu5R+z0lmqSHRdb0GqFkFVeKvRpRvcUzamB/r6Jl4+/tzbTTC/r97Sfvu7DdVAKge/g72zDlT0RAfnvTa4D+hshw3iWYXAw2IsinFQ1BTuG8KcwyXlH+MuaardKsCrc0TihXkQ DKIM-Signature: a=rsa-sha256; bh=sgRLfUyi0AEtYRpb6nOFpLTPu2chdJ1AVrx0RK+bMno=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676236; v=1; b=WrKYoVoD8NTgJd2b0KnhR1cP1AyahlmdQGt5/3qbSXT0R91MCJa5rJqxSNy2vqrasIkV+IgL +3G1s+2hX50sa1/gdsaB6o4XfeP63a9W64gZa6ytyFSDZih9HHfZ8RSDHi2gZb8oDOpWeOu4NPM uaC/f3qAWqpYBiw7aQyyjEVsM80ElMWUtQAuUKsYSiJ0xkZbCKWtbzYW5vLeOfnBIQ2kiL7n1O6 3fHMOYdq5Hya6OcQcgP3bKRKzV/iRCw97UKggyQTCp0JhmaTQPL/doZZ5GyZxra0FAMLIQg0GNb 8zKNDCOT71xRgp7189A9Ncci8RhAKHtaGUNDuTkloO8EA== X-purgate-ID: tlsNG-bad1c0/1785676237-3AAD8034-8AF45364/0/0 X-purgate-type: clean X-purgate-size: 11877 Go through entires in the DRTM policy of SLRT to hash and extend data that they describe into corresponding PCRs. Addresses are being zeroed on measuring platform-specific data to prevent measurements from changing when the only thing that has changed is an address. Addresses can vary due to bootloader, firmware or user doing something differently or just if GRUB gets bigger in size due to inclusion of more modules and ends up offsetting newly allocated memory. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: use SLR_TABLE_REVISION in slaunch_measure_slrt() v4: don't cast away const of slr_next_entry_by_tag() v4: use container_of() v4: take changes of `struct boot_module` into account xen/arch/x86/include/asm/slaunch.h | 14 ++ xen/arch/x86/setup.c | 15 ++ xen/arch/x86/slaunch.c | 217 +++++++++++++++++++++++++++++ 3 files changed, 246 insertions(+) diff --git a/xen/arch/x86/include/asm/slaunch.h b/xen/arch/x86/include/asm/slaunch.h index 65aab01f04..1b2c5957e4 100644 --- a/xen/arch/x86/include/asm/slaunch.h +++ b/xen/arch/x86/include/asm/slaunch.h @@ -31,6 +31,8 @@ #define DLE_EVTYPE_SLAUNCH_START (DLE_EVTYPE_BASE + 0x103) #define DLE_EVTYPE_SLAUNCH_END (DLE_EVTYPE_BASE + 0x104) +struct boot_info; + struct slaunch_early_init_results { uint32_t mbi_pa; @@ -67,6 +69,18 @@ void slaunch_map_mem_regions(void); /* Marks regions of memory as used to avoid their corruption. */ void slaunch_reserve_mem_regions(void); +/* Measures essential parts of SLR table before making use of them. */ +void slaunch_measure_slrt(void); + +/* + * Takes measurements of DRTM policy entries except for MBI and SLRT which + * should have been measured by the time this is called. Also performs sanity + * checks of the policy and panics on failure. In particular, the function + * verifies that DRTM is consistent with modules obtained from MultibootInfo + * (MBI) and written to struct boot_info in setup.c. + */ +void slaunch_process_drtm_policy(const struct boot_info *bi); + /* * This helper function is used to map memory below 4 GiB using L2 page tables * by aligning mapped regions to 2MB. This way page allocator (which at this diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index fbc44b0174..fd712d69e3 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1473,6 +1473,13 @@ void asmlinkage __init noreturn __start_xen(void) if ( slaunch_active ) { slaunch_map_mem_regions(); + + /* + * SLRT needs to be measured here because it is used by init_e820(), the + * rest is measured slightly below by slaunch_process_drtm_policy(). + */ + slaunch_measure_slrt(); + slaunch_reserve_mem_regions(); } @@ -1494,6 +1501,14 @@ void asmlinkage __init noreturn __start_xen(void) /* Create a temporary copy of the E820 map. */ memcpy(&boot_e820, &e820, sizeof(e820)); + /* + * Process all yet unmeasured DRTM entries after E820 initialization to not + * do this while memory is uncached (too slow). This must also happen before + * modules are relocated or used. + */ + if ( slaunch_active ) + slaunch_process_drtm_policy(bi); + /* Early kexec reservation (explicit static start address). */ nr_pages = 0; for ( i = 0; i < e820.nr_map; i++ ) diff --git a/xen/arch/x86/slaunch.c b/xen/arch/x86/slaunch.c index 83dce3d57d..ac62301f93 100644 --- a/xen/arch/x86/slaunch.c +++ b/xen/arch/x86/slaunch.c @@ -7,14 +7,17 @@ #include #include +#include #include #include #include #include +#include #include #include #include +#include #include #include #include @@ -114,6 +117,220 @@ void __init slaunch_reserve_mem_regions(void) } } +void __init slaunch_measure_slrt(void) +{ + struct slr_table *slrt = slaunch_get_slrt(); + + if ( slrt->revision == SLR_TABLE_REVISION ) + { + const struct slr_entry_hdr *entry; + + /* + * In revision one of the SLRT, only platform-specific info table is + * measured. + */ + struct slr_entry_intel_info tmp; + + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_INTEL_INFO); + if ( entry == NULL ) + panic("SLRT is missing Intel-specific information!\n"); + + tmp = *container_of(entry, const struct slr_entry_intel_info, hdr); + tmp.boot_params_base = 0; + tmp.txt_heap = 0; + + slaunch_hash_extend(DRTM_LOC, DRTM_DATA_PCR, (uint8_t *)&tmp, + sizeof(tmp), DLE_EVTYPE_SLAUNCH, NULL, 0); + } + else + { + /* + * slaunch_get_slrt() checks that the revision is valid, so we must not + * get here unless the code is wrong. + */ + panic("Unhandled SLRT revision: %d!\n", slrt->revision); + } +} + +static const struct slr_entry_policy *__init +slr_get_policy(const struct slr_table *slrt) +{ + const struct slr_entry_hdr *entry; + const struct slr_entry_policy *policy; + + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_DRTM_POLICY); + if (entry == NULL) + panic("SLRT is missing DRTM policy!\n"); + + policy = container_of(entry, const struct slr_entry_policy, hdr); + + /* XXX: are newer revisions allowed? */ + if ( policy->revision != SLR_POLICY_REVISION ) + panic("DRTM policy in SLRT is of unsupported revision: %#04x!\n", + slrt->revision); + + return policy; +} + +static void __init +check_slrt_policy_entry(struct slr_policy_entry *policy_entry, + int idx, + const struct slr_table *slrt) +{ + if ( policy_entry->entity_type != SLR_ET_SLRT ) + panic("Expected DRTM policy entry #%d to describe SLRT, got %#04x!\n", + idx, policy_entry->entity_type); + if ( policy_entry->pcr != DRTM_DATA_PCR ) + panic("SLRT was measured to PCR-%d instead of PCR-%d!\n", DRTM_DATA_PCR, + policy_entry->pcr); + if ( policy_entry->entity != (uint64_t)__pa(slrt) ) + panic("SLRT address (%#08lx) differs from its DRTM entry (%#08lx)\n", + __pa(slrt), policy_entry->entity); +} + +/* Returns number of policy entries that were already measured. */ +static unsigned int __init +check_drtm_policy(const struct slr_table *slrt, + const struct slr_entry_policy *policy, + struct slr_policy_entry *policy_entry, + const struct boot_info *bi) +{ + uint32_t i; + uint32_t num_mod_entries; + + if ( policy->nr_entries < 2 ) + panic("DRTM policy in SLRT contains less than 2 entries (%d)!\n", + policy->nr_entries); + + /* + * MBI policy entry must be the first one, so that measuring order matches + * policy order. + */ + if ( policy_entry[0].entity_type != SLR_ET_MULTIBOOT2_INFO ) + panic("First entry of DRTM policy in SLRT is not MBI: %#04x!\n", + policy_entry[0].entity_type); + if ( policy_entry[0].pcr != DRTM_DATA_PCR ) + panic("MBI was measured to %d instead of %d PCR!\n", DRTM_DATA_PCR, + policy_entry[0].pcr); + + /* SLRT policy entry must be the second one. */ + check_slrt_policy_entry(&policy_entry[1], 1, slrt); + + for ( i = 0; i < bi->nr_modules; i++ ) + { + uint16_t j; + const struct boot_module *mod = &bi->mods[i]; + + if (mod->arch.relocated || mod->arch.released) + { + panic("Multiboot module \"%s\" (at %d) was consumed before measurement\n", + (const char *)__va(mod->arch.cmdline_pa), i); + } + + for ( j = 2; j < policy->nr_entries; j++ ) + { + if ( policy_entry[j].entity_type != SLR_ET_MULTIBOOT2_MODULE ) + continue; + + if ( policy_entry[j].entity == mod->start && + policy_entry[j].size == mod->size ) + break; + } + + if ( j >= policy->nr_entries ) + { + panic("Couldn't find Multiboot module \"%s\" (at %d) in DRTM of Secure Launch\n", + (const char *)__va(mod->arch.cmdline_pa), i); + } + } + + num_mod_entries = 0; + for ( i = 0; i < policy->nr_entries; i++ ) + { + if ( policy_entry[i].entity_type == SLR_ET_MULTIBOOT2_MODULE ) + num_mod_entries++; + } + + if ( bi->nr_modules != num_mod_entries ) + { + panic("Unexpected number of Multiboot modules: %d instead of %d\n", + (int)bi->nr_modules, (int)num_mod_entries); + } + + /* + * MBI was measured in slaunch_measure_mbi(). + * SLRT was measured in slaunch_measure_slrt(). + */ + return 2; +} + +void __init slaunch_process_drtm_policy(const struct boot_info *bi) +{ + const struct slr_table *slrt; + const struct slr_entry_policy *policy; + struct slr_policy_entry *policy_entry; + uint16_t i; + unsigned int measured; + + slrt = slaunch_get_slrt(); + + policy = slr_get_policy(slrt); + policy_entry = (void *)policy + sizeof(*policy); + + measured = check_drtm_policy(slrt, policy, policy_entry, bi); + for ( i = 0; i < measured; i++ ) + policy_entry[i].flags |= SLR_POLICY_FLAG_MEASURED; + + for ( i = measured; i < policy->nr_entries; i++ ) + { + int rc; + uint64_t start = policy_entry[i].entity; + uint64_t size = policy_entry[i].size; + + /* No already measured entries are expected here. */ + if ( policy_entry[i].flags & SLR_POLICY_FLAG_MEASURED ) + panic("DRTM entry at %d was measured out of order!\n", i); + + switch ( policy_entry[i].entity_type ) + { + case SLR_ET_MULTIBOOT2_INFO: + panic("Duplicated MBI entry in DRTM of Secure Launch at %d\n", i); + case SLR_ET_SLRT: + panic("Duplicated SLRT entry in DRTM of Secure Launch at %d\n", i); + + case SLR_ET_UNSPECIFIED: + case SLR_ET_BOOT_PARAMS: + case SLR_ET_SETUP_DATA: + case SLR_ET_CMDLINE: + case SLR_ET_UEFI_MEMMAP: + case SLR_ET_RAMDISK: + case SLR_ET_MULTIBOOT2_MODULE: + case SLR_ET_TXT_OS2MLE: + /* Measure this entry below. */ + break; + + case SLR_ET_UNUSED: + /* Skip this entry. */ + continue; + } + + if ( policy_entry[i].flags & SLR_POLICY_IMPLICIT_SIZE ) + panic("Unexpected implicitly-sized DRTM entry of Secure Launch at %d (type %d, info: %s)\n", + i, policy_entry[i].entity_type, policy_entry[i].evt_info); + + rc = slaunch_map_l2(start, size); + BUG_ON(rc != 0); + + slaunch_hash_extend(DRTM_LOC, policy_entry[i].pcr, __va(start), size, + DLE_EVTYPE_SLAUNCH, + (uint8_t *)policy_entry[i].evt_info, + strnlen(policy_entry[i].evt_info, + TPM_EVENT_INFO_LENGTH)); + + policy_entry[i].flags |= SLR_POLICY_FLAG_MEASURED; + } +} + int __init slaunch_map_l2(paddr_t paddr, size_t size) { unsigned long aligned_paddr = paddr & ~((1ULL << L2_PAGETABLE_SHIFT) - 1); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:17:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:17:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380753.1624485 (Exim 4.92) (envelope-from ) id 1wqW4U-0004DF-NA; Sun, 02 Aug 2026 13:17:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380753.1624485; Sun, 02 Aug 2026 13:17:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4U-0004D6-Ig; Sun, 02 Aug 2026 13:17:42 +0000 Received: by outflank-mailman (input) for mailman id 1380753; Sun, 02 Aug 2026 13:17:41 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4T-0004AU-Mx for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:17:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqW4T-00Bn6b-3r for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:17:41 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f431e-bab6-0a2a0a5309dd-0a2a4505b1b4-44 for ; Sun, 02 Aug 2026 15:17:40 +0200 Received: from [178.33.253.26] (helo=3.mo582.mail-out.ovh.net) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41cf-4cb1-0a2a45050019-b221fd1ab33f-3 for ; Sun, 02 Aug 2026 15:10:40 +0200 Received: from director11.ghost.mail-out.ovh.net (unknown [10.110.43.238]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCg58b5z5yC2 for ; Sun, 2 Aug 2026 13:10:39 +0000 (UTC) Received: from ghost-submission-7d8d68f679-t7wcg (unknown [10.108.42.75]) by director11.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 13768C28DA; Sun, 2 Aug 2026 13:10:38 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.100]) by ghost-submission-7d8d68f679-t7wcg with ESMTPSA id 2d6ZLs5Bb2o8SwgAPH/TWw (envelope-from ); Sun, 02 Aug 2026 13:10:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-100R00335e8ac6c-444d-4ca3-86c0-9dcadff2c860, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , trenchboot-devel@googlegroups.com Subject: [PATCH v4 19/23] x86/acpi: disallow S3 on Secure Launch boot Date: Sun, 2 Aug 2026 16:09:35 +0300 Message-ID: <92105cb825fd258f9236291c3dadb64a20c8e325.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4742008934594782652 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTF70AoUNTuq0lE163/HHHmITb2k71K2uLoI2ZNhSgyl66wu8n/QJYzc+NLLaUb0uP1TrkyCR/9L8Ilu8caNGFiWNKPhk8LryKkv9xxZSrEN1zqyUGrQN6nXky3jMJxzdN9g/O0CtTLwNhHfleReQxYNqzRPBHWIFmbNp+cZCBU9E3JqDvY2G2n8Fq8vuRNzFdlGIcwMaDxCbm3ZzhQ1uRn2km7gAWfvABUN0yPDoQrFrCjLaFwKnQdy3a/cfWa0gHDTshjKSe3BdNtt7392P9RjMTs2j3tG0nmovZ410v/2dE5urrhoo3isYDb0H1B5YfdyZsu/PJWc0DbUySgFmJKBWyyZ4p7OpoRv65vjlPO59tPusQpx1aMuOo83eyN3/z2B2mBiu7FmwCv1GODqRHfVtGZspfbAWPCRt62XbVidum0ZJIV0fYl/IHNBD8BUtjMSCMxbE8xP+IoIAB6AEBNnCJpQ8Reiks6gAi4SokCBCRjJAL8Ju7Z+ZniFrpo8t3NQwgY5XgQW+2XwxfGK9/D/OQMB9UIgonZzSfT00gHF/Mq1II2sJU7M79UXISx7I+ivnTh/ezcYTErqNAmQ4cRQUijC/g5UXHPihvDoRinLYRWPkve8j9wxolh7pjw7M3oq2pNO0quutIfljaMyHE+i04tIHFhyIQ+1NyntYDA96w DKIM-Signature: a=rsa-sha256; bh=6fGDnMoWwU0eNwEZq3/rY7JMw/amuue+vbvojSoNGps=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676239; v=1; b=XAVgBwBn3mcCQLaaRUrWtcsnk5+PL7bcDzCnNyqRC689m+c5P7ieywqkIr0HVV/dsZAUgBqQ qDYeyZOSagve3H1tNTRoqk4TBiw0HK0yEhpcuX+u78mbPiMdX7TrThipYiBWstS3KN/zjcXNPdR w/l8MBPeItTfYAUYt/zEWBtUmDyGfWhbHRoKPgH4Mqno3EyXG3cxf4csjSjF+J+2dkcEcoH86RH 24vCj06k8NAHiRTXEgDITKI2lgTlFu5KxPsZwzxZ++M20RG8sAX6mbm7vZEkcR83XwTyn4gb20h GFhbEYemj1iQpYISq4nbLEDlRAgHa+CDkAL3cF/2yyPZg== X-purgate-ID: tlsNG-c201ff/1785676240-72AB72A1-BA984278/0/0 X-purgate-type: clean X-purgate-size: 1335 Secure Launch won't initiate DRTM on S3 resume (the code for starting DRTM is not part of Xen), so abort a request to perform S3 suspend to not lose the state of DRTM PCRs. Signed-off-by: Sergii Dmytruk --- Notes: v4: return EACCES instead of EPERM xen/arch/x86/acpi/power.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c index 3452650a61..8428766f82 100644 --- a/xen/arch/x86/acpi/power.c +++ b/xen/arch/x86/acpi/power.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -335,6 +336,13 @@ int acpi_enter_sleep(const struct xenpf_enter_acpi_sleep *sleep) PAGE_SIZE - acpi_sinfo.vector_width / 8)) ) return -EOPNOTSUPP; + /* Secure Launch won't initiate DRTM on S3 resume, so abort S3 suspend. */ + if ( sleep->sleep_state == ACPI_STATE_S3 && slaunch_active ) + { + printk(XENLOG_INFO "SLAUNCH: refusing switching into ACPI S3 state.\n"); + return -EACCES; + } + if ( sleep->flags & XENPF_ACPI_SLEEP_EXTENDED ) { if ( !acpi_sinfo.sleep_control.address || -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:17:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:17:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380754.1624492 (Exim 4.92) (envelope-from ) id 1wqW4X-0004W5-Sx; Sun, 02 Aug 2026 13:17:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380754.1624492; Sun, 02 Aug 2026 13:17:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4X-0004Vt-PY; Sun, 02 Aug 2026 13:17:45 +0000 Received: by outflank-mailman (input) for mailman id 1380754; Sun, 02 Aug 2026 13:17:44 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4W-0004SK-HG for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:17:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqW4V-0084CP-UZ for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:17:43 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4326-2eae-0a2a0a5409dd-0a2a4502a226-20 for ; Sun, 02 Aug 2026 15:17:43 +0200 Received: from [46.105.50.32] (helo=7.mo576.mail-out.ovh.net) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41d2-6ca4-0a2a45020019-2e69322087e5-3 for ; Sun, 02 Aug 2026 15:10:43 +0200 Received: from director4.ghost.mail-out.ovh.net (unknown [10.110.37.160]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCk4CqMz5xWq for ; Sun, 2 Aug 2026 13:10:42 +0000 (UTC) Received: from ghost-submission-7d8d68f679-vv62g (unknown [10.110.101.105]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id BB4C4C21CD; Sun, 2 Aug 2026 13:10:41 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.98]) by ghost-submission-7d8d68f679-vv62g with ESMTPSA id TOywHtFBb2rWuxsAGKqLvg (envelope-from ); Sun, 02 Aug 2026 13:10:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-98R002ed3048ef-d622-49d2-a4d0-e16ccb5bdd2c, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , "Daniel P. Smith" , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 20/23] x86/slaunch: support AMD CPUs Date: Sun, 2 Aug 2026 16:09:36 +0300 Message-ID: <280c41d0b12c3b218d8e70d830bafdfb64229468.1785668458.git.sergii.dmytruk@3mdeb.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4742853359210603964 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTErXTMJAFd1A/dXmS31doF3eHiFwFavtbE0IdxSAxcjBkbm/Y2r8C0ugmNxHgh0ttjc9HcWB48DtmHsboYn+R8rGouoQtvWBvuW7UoEIxsUWbq/tHAG5l0RfFjNSyhC5/+eLgR0uRIXbClVnnLU0J/e2MH+H41gFQHMN7aHv5oF4XCxU6iBwYAbzZv3Yhh++GCTcK0XOcSHoKOpYkiLjzaWT2sDXaneeSXeAAfPIRWbR3tUvr9IWTEkcXdO9/v8flsgALJWAnTuyhJyR7xa7rElw4l9ZKZPp4F7IlSUp4UkO78BMUlmU3YvvPg7A/cDjWsr7oy1auF5nv72TyzhOj1kDLdIeqJa7OzYeh91R/AocqDNmP5GASH8TFSHubE5VjyP9gMe4ZKnoHLpohQNQN2MHYJ1BuQVvUrb1hUQ4RDRfY6CGUtI1G07rhyLjykDaObJxD+JHh8JfAZkQkVrOH0OsNzG8P2+vBLXnSDHOnTIfcnUcR3Nur9/0aWKN9W29FAibtNgB96b+HwuTsB1M0XywD/ifhwZV5EfClFdqOOqql/pWPtrM/TN9g8f1WAkumTfEG//+bvzGto2Qyfe+a8hEQI9jiFC3J9zIRp9MJmXt04vs9MvIlD1tXWhM/3Pdp9now7DMQLQ+kM0W7bHhdqx6RcdLSqoAMuo6YybFJdxKw DKIM-Signature: a=rsa-sha256; bh=NfKcGkd1fR1dcujpVOqhBYksRyhPEk+hlTYRJTUqPB0=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676242; v=1; b=cRFZV7xP76j7mOSRdfaC+q0j4Ue9TjdvQpcImSOiE70/uQ2hIS9GJH9/F47tEaReBnyKtxnL 7gsk2jFPTa7YjnmNJazmDmGlq+GjX4wju02AMFoAB93TxtQIzbvmQ/g2A1nwDqKB59ODCYlVshr bt7Txs62NiS1/RyJGoep5ZWfNvxgQZqkXCRlqOAeRWP8uRGFrAZh2SZTbrfnJqwlunrf/dxNqp8 zh2bPm/g6Zi67UrzFRWrsjcoOsHQTzfV/HiO84MHALbuRSrTEuAwOfM7t9Cxhl/RG1Ul4Agrl8E cm66mRTuSzs3qW6SXpeOXh5W+oQg8/yRi43PSgsBGSXlA== X-purgate-ID: tlsNG-720697/1785676243-666B72AC-238E9B3C/0/0 X-purgate-type: clean X-purgate-size: 17780 Handle the state after secure-kernel-loader (SKL) in boot/head.S. Use slr_entry_amd_info::boot_params_base on AMD with SKINIT to get MBI location. Locate SLRT which is bootloader's data after SKL on AMD. Measure AMD-specific data in slaunch_measure_slrt(). Find Intel-compatible TPM event log structure within vendor data of TCG-compliant event logs. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: squashed "x86/slaunch: support AMD SKINIT" and "x86/boot/slaunch-early: find MBI and SLRT on AMD" v4: use CONFIG_SLAUNCH v4: update large comment in head.S v4: define slaunch_is_amd_drtm() in a header and use twice to avoid duplication v4: %#04x => %#x in panic("SLRT is for unexpected architecture ...") v4: use container_of() v4: don't drop `const` from the result of `slr_next_entry_by_tag()` xen/arch/x86/boot/head.S | 42 ++++++++++++--- xen/arch/x86/boot/slaunch-early.c | 52 ++++++++++++++++++ xen/arch/x86/e820.c | 2 +- xen/arch/x86/include/asm/slaunch.h | 30 +++++++++++ xen/arch/x86/include/asm/tpm1.h | 15 ++++++ xen/arch/x86/slaunch-tpm.c | 26 +++++++++ xen/arch/x86/slaunch.c | 87 ++++++++++++++++++++++++------ 7 files changed, 231 insertions(+), 23 deletions(-) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index ff46579904..bf38aef21c 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -358,10 +358,14 @@ cs32_switch: #if CONFIG_SLAUNCH /* - * Entry point for TrenchBoot Secure Launch on Intel TXT platforms. + * Entry point for TrenchBoot Secure Launch, common for Intel TXT and + * AMD Secure Startup, but state is slightly different. + * + * On Intel + * -------- * * CPU is in 32b protected mode with paging disabled. On entry: - * - %ebx = %eip = MLE entry point, + * - %ebx = %eip = this entry point, * - stack pointer is undefined, * - CS is flat 4GB code segment, * - DS, ES, SS, FS and GS are undefined according to TXT SDG, but this @@ -382,13 +386,36 @@ cs32_switch: * writing a non-zero value at a MONITORed address or via * GETSEC[WAKEUP] instruction, depending on which is supported by a * given SINIT ACM + * + * On AMD (as implemented by TrenchBoot's secure-kernel-loader or SKL) + * ------------------------------------------------------------------- + * + * CPU is in 32b protected mode with paging disabled. On entry: + * - %ebx = %eip = this entry point, + * - %ebp holds base address of SKL + * - stack pointer is treated as undefined for parity with TXT, + * - CS is flat 4GB code segment, + * - DS, ES, SS are flat 4GB data segments, but treated as undefined for + * parity with TXT. + * + * Additional restrictions: + * - interrupts (including NMIs and SMIs) are disabled and must be + * enabled later + * - APs must be brought up by SIPI without an INIT */ slaunch_stub_entry: /* Calculate the load base address. */ mov %ebx, %esi sub $sym_offs(slaunch_stub_entry), %esi - /* Mark Secure Launch boot protocol and jump to common entry. */ + /* On AMD, %ebp holds the base address of SLB, save it for later. */ + mov %ebp, %ebx + + /* + * Mark Secure Launch boot protocol and jump to common entry. Note that + * all general purpose registers except %ebx and %esi are clobbered + * between here and .Lslaunch_proto. + */ mov $SLAUNCH_BOOTLOADER_MAGIC, %eax jmp .Lset_stack #endif /* CONFIG_SLAUNCH */ @@ -524,15 +551,18 @@ __start: sub $SL_EIR_size, %esp push %esp /* pointer to output structure */ + push %ebx /* Slaunch parameter on AMD */ mov $sym_offs(__2M_rwdata_end), %ecx /* end of target image */ mov $sym_offs(_start), %edx /* target base address */ mov %esi, %eax /* load base address */ /* - * slaunch_early_init(load/eax, tgt/edx, tgt_end/ecx, ret/stk) using - * fastcall calling convention. + * slaunch_early_init(load/eax, tgt/edx, tgt_end/ecx, + * slaunch/stk, ret/stk) + * + * Uses fastcall calling convention. */ call slaunch_early_init - add $4, %esp /* pop the fourth parameter */ + add $8, %esp /* pop last two parameters */ /* Move outputs of slaunch_early_init() from the stack. */ pop %ebx /* store physical MBI address in EBX where diff --git a/xen/arch/x86/boot/slaunch-early.c b/xen/arch/x86/boot/slaunch-early.c index 00c772cfdf..9b16602ac8 100644 --- a/xen/arch/x86/boot/slaunch-early.c +++ b/xen/arch/x86/boot/slaunch-early.c @@ -13,9 +13,23 @@ #include #include +/* + * The AMD-defined structure layout for the SLB. The last two fields are + * SL-specific. + */ +struct skinit_sl_header +{ + uint16_t skl_entry_point; + uint16_t length; + uint8_t reserved[62]; + uint16_t skl_info_offset; + uint16_t bootloader_data_offset; +} __packed; + void asmlinkage slaunch_early_init(uint32_t load_base_addr, uint32_t tgt_base_addr, uint32_t tgt_end_addr, + uint32_t slaunch_param, struct slaunch_early_init_results *result) { void *txt_heap; @@ -26,6 +40,44 @@ void asmlinkage slaunch_early_init(uint32_t load_base_addr, const struct slr_entry_intel_info *intel_info; uint32_t size = tgt_end_addr - tgt_base_addr; + if ( slaunch_is_amd_drtm() ) + { + /* + * Not an Intel CPU. Currently the only other option is AMD with SKINIT + * and secure-kernel-loader (SKL). + */ + const struct slr_entry_amd_info *amd_info; + const struct skinit_sl_header *sl_header = (void *)slaunch_param; + + /* + * slaunch_param holds a physical address of SLB. + * Bootloader's data is SLRT. + */ + result->slrt_pa = slaunch_param + sl_header->bootloader_data_offset; + + slrt = (struct slr_table *)(uintptr_t)result->slrt_pa; + + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_AMD_INFO); + if ( entry == NULL ) + { + /* No reset mechanism or an error register on AMD. */ + asm volatile ("ud2"); + unreachable(); + } + + amd_info = container_of(entry, const struct slr_entry_amd_info, hdr); + /* Basic checks only, SKL checked and consumed the rest. */ + if ( amd_info->hdr.size != sizeof(*amd_info) ) + { + /* No reset mechanism or an error register on AMD. */ + asm volatile ("ud2"); + unreachable(); + } + + result->mbi_pa = amd_info->boot_params_base; + return; + } + txt_heap = txt_init(); os_mle = txt_start(txt_heap, TXT_OS2MLE); os_sinit = txt_start(txt_heap, TXT_OS2SINIT); diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c index c63b0b12cc..964a02384d 100644 --- a/xen/arch/x86/e820.c +++ b/xen/arch/x86/e820.c @@ -501,7 +501,7 @@ static void __init machine_specific_memory_setup(struct e820map *raw) uint64_t top_of_ram, size; unsigned int i; - if ( slaunch_active ) + if ( slaunch_active && boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) txt_restore_mtrrs(e820_verbose); sanitize_e820_map(raw->map, &raw->nr_map); diff --git a/xen/arch/x86/include/asm/slaunch.h b/xen/arch/x86/include/asm/slaunch.h index 1b2c5957e4..a9c009fa96 100644 --- a/xen/arch/x86/include/asm/slaunch.h +++ b/xen/arch/x86/include/asm/slaunch.h @@ -17,6 +17,8 @@ #include #include +#include + #define DRTM_LOC 2 #define DRTM_CODE_PCR 17 #define DRTM_DATA_PCR 18 @@ -56,6 +58,34 @@ static bool slaunch_active = false; */ extern uint32_t slaunch_slrt; +#ifdef __EARLY_SLAUNCH__ + +static inline bool slaunch_is_amd_drtm(void) +{ + /* + * asm/processor.h can't be included in early code, which means neither + * cpuid() function nor boot_cpu_data can be used here. + */ + uint32_t eax, ebx, ecx, edx; + asm volatile ( "cpuid" + : "=a" (eax), "=b" (ebx), "=c" (ecx), "=d" (edx) + : "0" (0), "c" (0) ); + return ebx == X86_VENDOR_AMD_EBX + && ecx == X86_VENDOR_AMD_ECX + && edx == X86_VENDOR_AMD_EDX; +} + +#else /* __EARLY_SLAUNCH__ */ + +#include + +static inline bool slaunch_is_amd_drtm(void) +{ + return boot_cpu_data.x86_vendor == X86_VENDOR_AMD; +} + +#endif /* __EARLY_SLAUNCH__ */ + /* * Retrieves pointer to SLRT. Checks table's validity and maps it as necessary. */ diff --git a/xen/arch/x86/include/asm/tpm1.h b/xen/arch/x86/include/asm/tpm1.h index d1cb2cc041..57a60223ba 100644 --- a/xen/arch/x86/include/asm/tpm1.h +++ b/xen/arch/x86/include/asm/tpm1.h @@ -76,4 +76,19 @@ struct TPM12_PCREvent { uint8_t Data[]; }; +struct tpm1_spec_id_event { + uint32_t pcrIndex; + uint32_t eventType; + uint8_t digest[20]; + uint32_t eventSize; + uint8_t signature[16]; + uint32_t platformClass; + uint8_t specVersionMinor; + uint8_t specVersionMajor; + uint8_t specErrata; + uint8_t uintnSize; + uint8_t vendorInfoSize; + uint8_t vendorInfo[0]; /* variable number of members */ +} __packed; + #endif /* X86_TPM1_H */ diff --git a/xen/arch/x86/slaunch-tpm.c b/xen/arch/x86/slaunch-tpm.c index e3b7341cc5..2f8e598706 100644 --- a/xen/arch/x86/slaunch-tpm.c +++ b/xen/arch/x86/slaunch-tpm.c @@ -79,6 +79,16 @@ create_log_event12(struct txt_ev_log_container_12 *evt_log, if (evt_log == NULL) return log_hashes; + if ( slaunch_is_amd_drtm() ) + { + /* + * On AMD, TXT-compatible structure is stored as vendor data of + * TCG-defined event log header. + */ + struct tpm1_spec_id_event *spec_id = (void *)evt_log; + evt_log = (struct txt_ev_log_container_12 *)&spec_id->vendorInfo[0]; + } + new_entry = (void *)evt_log + evt_log->NextEventOffset; /* @@ -114,6 +124,22 @@ find_evt_log_ext_data(struct tpm2_spec_id_event *evt_log) struct txt_os_sinit_data *os_sinit; struct txt_ext_data_element *ext_data; + if ( slaunch_is_amd_drtm() ) + { + /* + * Event log pointer is defined by TXT specification, but + * secure-kernel-loader provides a compatible structure in vendor data + * of the log. + */ + uint8_t *data_size = + (uint8_t *)&evt_log->digestSizes[evt_log->digestCount]; + if ( *data_size != sizeof(struct heap_event_log_pointer_element2_1) ) + return NULL; + + /* Vendor data directly follows a single-byte size. */ + return (struct heap_event_log_pointer_element2_1 *)(data_size + 1); + } + os_sinit = txt_start(__va(txt_read(TXTCR_HEAP_BASE)), TXT_OS2SINIT); ext_data = txt_find_ext_data_element(os_sinit, TXT_HEAP_EXTDATA_TYPE_EVENT_LOG_POINTER2_1); diff --git a/xen/arch/x86/slaunch.c b/xen/arch/x86/slaunch.c index ac62301f93..af88ca9caa 100644 --- a/xen/arch/x86/slaunch.c +++ b/xen/arch/x86/slaunch.c @@ -23,6 +23,10 @@ #include #include +/* SLB is 64k, 64k-aligned */ +#define SKINIT_SLB_SIZE 0x10000 +#define SKINIT_SLB_ALIGN 0x10000 + /* * These variables are assigned to by the code near Xen's entry point. * @@ -48,6 +52,8 @@ struct slr_table *__init slaunch_get_slrt(void) if ( slrt == NULL ) { int rc; + bool intel_cpu = (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL); + uint16_t slrt_architecture = intel_cpu ? SLR_INTEL_TXT : SLR_AMD_SKINIT; slrt = __va(slaunch_slrt); @@ -59,9 +65,9 @@ struct slr_table *__init slaunch_get_slrt(void) /* XXX: are newer revisions allowed? */ if ( slrt->revision != SLR_TABLE_REVISION ) panic("SLRT is of unsupported revision: %#x!\n", slrt->revision); - if ( slrt->architecture != SLR_INTEL_TXT ) - panic("SLRT is for unexpected architecture: %#x!\n", - slrt->architecture); + if ( slrt->architecture != slrt_architecture ) + panic("SLRT is for unexpected architecture: %#x != %#x!\n", + slrt->architecture, slrt_architecture); if ( slrt->size > slrt->max_size ) panic("SLRT is larger than its max size: %#x > %#x!\n", slrt->size, slrt->max_size); @@ -76,6 +82,23 @@ struct slr_table *__init slaunch_get_slrt(void) return slrt; } +static uint32_t __init get_slb_start(void) +{ + /* + * The runtime computation relies on size being a power of 2 and equal to + * alignment. Make sure these assumptions hold. + */ + BUILD_BUG_ON(SKINIT_SLB_SIZE != SKINIT_SLB_ALIGN); + BUILD_BUG_ON(SKINIT_SLB_SIZE == 0); + BUILD_BUG_ON((SKINIT_SLB_SIZE & (SKINIT_SLB_SIZE - 1)) != 0); + + /* + * Rounding any address within SLB down to alignment gives SLB base and + * SLRT is inside SLB on AMD. + */ + return slaunch_slrt & ~(SKINIT_SLB_SIZE - 1); +} + void __init slaunch_map_mem_regions(void) { int rc; @@ -86,7 +109,10 @@ void __init slaunch_map_mem_regions(void) BUG_ON(rc != 0); /* Vendor-specific part. */ - txt_map_mem_regions(); + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) + txt_map_mem_regions(); + else if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) + slaunch_map_l2(get_slb_start(), SKINIT_SLB_SIZE); slaunch_find_log(slaunch_get_slrt(), &evt_log_addr, &evt_log_size); if ( evt_log_addr != 0 ) @@ -98,17 +124,27 @@ void __init slaunch_map_mem_regions(void) void __init slaunch_reserve_mem_regions(void) { + int ok; paddr_t evt_log_addr; uint32_t evt_log_size; /* Vendor-specific part. */ - txt_reserve_mem_regions(); + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) + { + txt_reserve_mem_regions(); + } + else if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) + { + uint64_t slb_start = get_slb_start(); + uint64_t slb_end = slb_start + SKINIT_SLB_SIZE; + printk("SLAUNCH: reserving SLB [%#lx, %#lx)\n", slb_start, slb_end); + ok = reserve_e820_ram(&e820_raw, slb_start, slb_end); + BUG_ON(!ok); + } slaunch_find_log(slaunch_get_slrt(), &evt_log_addr, &evt_log_size); if ( evt_log_addr != 0 ) { - int ok; - printk("SLAUNCH: reserving event log [%#lx, %#lx)\n", evt_log_addr, evt_log_addr + evt_log_size); ok = reserve_e820_ram(&e820_raw, evt_log_addr, @@ -129,18 +165,37 @@ void __init slaunch_measure_slrt(void) * In revision one of the SLRT, only platform-specific info table is * measured. */ - struct slr_entry_intel_info tmp; + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) + { + struct slr_entry_intel_info tmp; - entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_INTEL_INFO); - if ( entry == NULL ) - panic("SLRT is missing Intel-specific information!\n"); + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_INTEL_INFO); + if ( entry == NULL ) + panic("SLRT is missing Intel-specific information!\n"); - tmp = *container_of(entry, const struct slr_entry_intel_info, hdr); - tmp.boot_params_base = 0; - tmp.txt_heap = 0; + tmp = *container_of(entry, const struct slr_entry_intel_info, hdr); + tmp.boot_params_base = 0; + tmp.txt_heap = 0; - slaunch_hash_extend(DRTM_LOC, DRTM_DATA_PCR, (uint8_t *)&tmp, - sizeof(tmp), DLE_EVTYPE_SLAUNCH, NULL, 0); + slaunch_hash_extend(DRTM_LOC, DRTM_DATA_PCR, (uint8_t *)&tmp, + sizeof(tmp), DLE_EVTYPE_SLAUNCH, NULL, 0); + } + else if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) + { + struct slr_entry_amd_info tmp; + + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_AMD_INFO); + if ( entry == NULL ) + panic("SLRT is missing AMD-specific information!\n"); + + tmp = *container_of(entry, const struct slr_entry_amd_info, hdr); + tmp.next = 0; + tmp.slrt_base = 0; + tmp.boot_params_base = 0; + + slaunch_hash_extend(DRTM_LOC, DRTM_DATA_PCR, (uint8_t *)&tmp, + sizeof(tmp), DLE_EVTYPE_SLAUNCH, NULL, 0); + } } else { -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:17:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:17:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380758.1624502 (Exim 4.92) (envelope-from ) id 1wqW4c-0004tc-B7; Sun, 02 Aug 2026 13:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380758.1624502; Sun, 02 Aug 2026 13:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4c-0004tT-7i; Sun, 02 Aug 2026 13:17:50 +0000 Received: by outflank-mailman (input) for mailman id 1380758; Sun, 02 Aug 2026 13:17:49 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4a-0004pR-RA for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:17:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqW4a-00Bn6b-7p for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:17:48 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f436e-bab6-0a2a0a5309dd-0a2a4501cdb6-12 for ; Sun, 02 Aug 2026 15:17:48 +0200 Received: from [87.98.178.58] (helo=17.mo561.mail-out.ovh.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41d6-5984-0a2a45010019-5762b23adae3-3 for ; Sun, 02 Aug 2026 15:10:47 +0200 Received: from director4.ghost.mail-out.ovh.net (unknown [10.110.0.178]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCp55tjz5xsS for ; Sun, 2 Aug 2026 13:10:46 +0000 (UTC) Received: from ghost-submission-7d8d68f679-m4frt (unknown [10.111.174.132]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 9E9E0C2306; Sun, 2 Aug 2026 13:10:44 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.101]) by ghost-submission-7d8d68f679-m4frt with ESMTPSA id A262F9RBb2oNsRcAXQcPeQ (envelope-from ); Sun, 02 Aug 2026 13:10:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-101G004633ecb7a-a591-49b8-960a-955f05690000, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Nicola Vetrini , Doug Goldstein , Teddy Astie , "Daniel P. Smith" , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Ross Philipson , trenchboot-devel@googlegroups.com Subject: [PATCH v4 21/23] x86/slaunch: support EFI boot Date: Sun, 2 Aug 2026 16:09:37 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4743979258418570684 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTFkIVM66t9WfxMA1MBLamLRI1g7isw4fvjTq42J16AnGGiVkfZZz7RNohO0DVzuB6p7ByU2jpbyNpeFSmhxy18LKLUp8eoLMQd6SniSDWM2cNrBr0In5AXWUClj6LSw0UENmYdxRZSA2740zY8xbtv3e0tQCOijX5z+87X8/lqG082kExyxNnnNomzq4n6JxeS+9hUWvV3ncL+A/VeP2cvLfZQ+CqbSooIUmTa+tUTJpOYsWTKV07AKa/rJsi+zSktpNOwqnqM3QkFMTTxnOM0YJkWFFta90JnAtJgk2pNma17wsGvogAUiRHEWxKZPCW0f+1LBF9pVpiXy5iPezXU8d1hce61Aoq+F+RzUjso/AXwTe0q1s2f/fih1X+6DUmvool3KHQypNF8upsQVo+IBvC2Yjz4usFTJs0tU4CdieQIpWWA+M+WIP+3VvProtgPGB3V4I4TbBITe+5ww3KdQ8QBD+dIYUR2xsf46qGgJSHLLpxdbWpOAu39N4u/DbhJX9frf5n4MqugzsU42SlsfG2vroQwvKy7w8DgmCWSTGHyQhyOcU+pLZkvhAT0wCJmieOYIYVupe4kEpmCKcjFt2VY2EJrP6cQdkcw/LQXt7Tohx2E2u94aF3cgH6K1clYyYmuTm0lRXH1R/nT51K2vCRskrU0ONuM6EwWrUzRcBg DKIM-Signature: a=rsa-sha256; bh=eiitqsXzV8CcZOdxpmTe8+PK7v6PihsQTS4KVdOMirw=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676246; v=1; b=bEcHWuwNfJrOBZFyHuWhXz1RxNezZ6yFLALj21FFaaEJAWE7ZLWFAeEMcrhuLSh2ypaOGZmv t9Fqt54R3YaMwodm1CDuHXVh2DmQmbOF8g71SUrcNgTs9KrVQjcst7TSY8rwlEZ+rVVi7ZWYEWn PDZtjstZVDn3d39MnFpRHiTaiCFIrfRUEm3OWEI69gyKi70n234sbiyOk3M6lRdzhZbi0vx5OyT +TqMUX7emXKimOEWzXIGkFK46X96uRKRJr/v2p+N7/owZ0Gv+z/qjuCjiN1HoOeYnt+GT7tY6+M iCEw7vao67lmk3Q2iGbS/YgcXudK7cpvmr3ofs8f9Bmeg== X-purgate-ID: tlsNG-d62444/1785676247-C5146757-84F0834B/0/0 X-purgate-type: clean X-purgate-size: 27035 When running on an EFI-enabled system, Xen needs to have access to Boot Services in order to initialize itself properly and reach a state in which a dom0 kernel can operate without issues. This means that DRTM must be started in the middle of Xen's initialization process. This effect is achieved via a callback into a TrenchBoot-enabled bootloader (GRUB) which is responsible for initiating DRTM and continuing Xen's initialization process. The latter is done by branching in Slaunch entry point on a flag to switch back into long mode before calling the same function which Xen would execute as the next step without DRTM. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk --- Notes: v4: -DXEN_BUILD_EFI => -DXEN_BUILD_EFI=1 v4: use CONFIG_SLAUNCH v4: use pointers to `const` SLRT and TXT heap data v4: use container_of() v4: take updates to `struct boot_module` into account v4: now UEFI_SLR_TABLE_GUID is defined here in efi/boot.c .gitignore | 1 + .../eclair_analysis/ECLAIR/out_of_scope.ecl | 1 + docs/hypervisor-guide/x86/how-xen-boots.rst | 14 +- xen/arch/x86/Makefile | 12 +- xen/arch/x86/boot/head.S | 124 +++++++++++++++++ xen/arch/x86/boot/x86_64.S | 14 +- xen/arch/x86/efi/efi-boot.h | 94 ++++++++++++- xen/arch/x86/efi/fixmlehdr.c | 127 ++++++++++++++++++ xen/arch/x86/slaunch.c | 75 ++++++++++- xen/common/efi/boot.c | 6 + xen/common/efi/runtime.c | 1 + xen/include/xen/efi.h | 1 + 12 files changed, 455 insertions(+), 15 deletions(-) create mode 100644 xen/arch/x86/efi/fixmlehdr.c diff --git a/.gitignore b/.gitignore index bfc7bdf043..76bc97d5ea 100644 --- a/.gitignore +++ b/.gitignore @@ -177,6 +177,7 @@ xen/.xen.elf32 xen/System.map xen/arch/x86/efi.lds xen/arch/x86/efi/check.efi +xen/arch/x86/efi/fixmlehdr xen/arch/x86/efi/mkreloc xen/arch/x86/include/asm/asm-macros.h xen/arch/*/xen.lds diff --git a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl index 9bcec4c69d..a09cf5442c 100644 --- a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl +++ b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl @@ -19,6 +19,7 @@ -doc_begin="Build tools are out of scope." -file_tag+={out_of_scope_tools,"^xen/tools/.*$"} +-file_tag+={out_of_scope_tools,"^xen/arch/x86/efi/fixmlehdr\\.c$"} -file_tag+={out_of_scope_tools,"^xen/arch/x86/efi/mkreloc\\.c$"} -file_tag+={out_of_scope_tools,"^xen/arch/x86/boot/mkelf32\\.c$"} -doc_end diff --git a/docs/hypervisor-guide/x86/how-xen-boots.rst b/docs/hypervisor-guide/x86/how-xen-boots.rst index a841d1e9f8..0b1b62971f 100644 --- a/docs/hypervisor-guide/x86/how-xen-boots.rst +++ b/docs/hypervisor-guide/x86/how-xen-boots.rst @@ -56,12 +56,14 @@ which indicates the ability to use the PVH boot protocol, and registers ``__pvh_start`` as the entrypoint, entered in 32bit mode. A combination of Multiboot 2 and Measured Launched Environment (MLE) headers -is used to support Dynamic Root of Trust for Measurement (DRTM) for legacy -(BIOS) boot. DRTM is a way to establish hardware root of trust which -excludes firmware and is not directly tied to hardware's boot process. The -separate entry point called ``slaunch_stub_entry`` is used mainly to -differentiate from other kinds of boots. It moves a magic number to ``EAX`` -before jumping into common startup code. More details about Secure Launch +is used to support Dynamic Root of Trust for Measurement (DRTM). DRTM is a +way to establish hardware root of trust which excludes firmware and is not +directly tied to hardware's boot process. The separate entry point called +``slaunch_stub_entry`` is used mainly to differentiate from other kinds of +boots. For a legacy (BIOS) boot, it moves a magic number to ``EAX`` before +jumping into common startup code. For a EFI boot, it resumes execution of +Xen.efi which was paused by handing control to a part of a bootloader +responsible for initiating DRTM sequence. More details about Secure Launch data structures processed by Xen in this boot mode can be found in ``_. diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 8dbb76a3a0..4f7db9420e 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -89,6 +89,7 @@ extra-y += xen.lds hostprogs-y += boot/mkelf32 hostprogs-y += efi/mkreloc +hostprogs-y += efi/fixmlehdr $(obj)/efi/mkreloc: HOSTCFLAGS += -I$(srctree)/include @@ -123,6 +124,11 @@ $(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mkelf32 CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI +# Expose this build flag as a macro when compiling assembly files. +ifeq ($(XEN_BUILD_EFI),y) +XEN_AFLAGS += -DXEN_BUILD_EFI=1 +endif + $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds $(objtree)/tools/symbols $(all_symbols) --empty > $(dot-target).0.S $(MAKE) $(build)=$(@D) $(dot-target).0.o @@ -196,7 +202,7 @@ note_file_option ?= $(note_file) extra-$(XEN_BUILD_PE) += efi.lds ifeq ($(XEN_BUILD_PE),y) $(TARGET).efi: $(obj)/efi/relocs-dummy.o $(obj)/efi/relocs-empty.o $(obj)/efi/mkreloc -$(TARGET).efi: $(objtree)/prelink.o $(note_file) $(obj)/efi.lds +$(TARGET).efi: $(objtree)/prelink.o $(note_file) $(obj)/efi.lds $(obj)/efi/fixmlehdr ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),echo,:) "Will strip debug info from $(@F)" endif @@ -230,6 +236,10 @@ endif $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds $< $(obj)/efi/relocs-empty.o \ $(dot-target).2r.o $(dot-target).2s.o $(orphan-handling-y) \ $(note_file_option) -o $@ +ifeq ($(CONFIG_SLAUNCH),y) + # update entry point's address by taking image offset into account + $(obj)/efi/fixmlehdr $@ $(XEN_IMG_OFFSET) +endif $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > $@.map diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index bf38aef21c..22b331a45c 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -408,6 +408,12 @@ slaunch_stub_entry: mov %ebx, %esi sub $sym_offs(slaunch_stub_entry), %esi +#if XEN_BUILD_EFI + /* If the flag is already set, then Xen should continue execution. */ + cmpb $0, sym_esi(slaunch_active) + jne slaunch_efi_jumpback +#endif + /* On AMD, %ebp holds the base address of SLB, save it for later. */ mov %ebp, %ebx @@ -855,6 +861,124 @@ trampoline_setup: /* Jump into the relocated trampoline. */ lret +#if XEN_BUILD_EFI && CONFIG_SLAUNCH + + /* + * The state matches that of slaunch_stub_entry above, but with %esi + * already initialized. + */ +slaunch_efi_jumpback: + lea STACK_SIZE - CPUINFO_sizeof + sym_esi(cpu0_stack), %esp + + /* Prepare gdt and segments. */ + add %esi, sym_esi(gdt_boot_base) + lgdt sym_esi(gdt_boot_descr) + + mov $BOOT_DS, %ecx + mov %ecx, %ds + mov %ecx, %es + mov %ecx, %ss + + push $BOOT_CS32 + lea sym_esi(.Lgdt_is_set),%edx + push %edx + lret +.Lgdt_is_set: + + /* + * Stash TSC as above because it was zeroed on jumping into bootloader + * to not interfere with measurements. + */ + rdtsc + mov %eax, sym_esi(boot_tsc_stamp) + mov %edx, 4 + sym_esi(boot_tsc_stamp) + + /* + * Clear the pagetables before the use. We are loaded below 4GiB and + * this avoids the need for writing to higher dword of each entry. + * Additionally, this ensures those dwords are actually zero and the + * mappings aren't manipulated from outside. + */ + lea sym_esi(bootmap_start), %edi + lea sym_esi(bootmap_end), %ecx + sub %edi, %ecx + xor %eax, %eax + shr $2, %ecx + rep stosl + + /* 1x L1 page, 512 entries mapping total of 2M. */ + lea sym_esi(l1_bootmap), %edi + mov $512, %ecx + mov $(__PAGE_HYPERVISOR + 512 * PAGE_SIZE), %edx +.Lfill_l1_identmap: + sub $PAGE_SIZE, %edx + /* Loop runs for ecx=[512..1] for entries [511..0], hence -8. */ + mov %edx, -8(%edi,%ecx,8) + loop .Lfill_l1_identmap + + /* 4x L2 pages, each page mapping 1G of RAM. */ + lea sym_esi(l2_bootmap), %edi + /* 1st entry points to L1. */ + lea (sym_offs(l1_bootmap) + __PAGE_HYPERVISOR)(%esi), %edx + mov %edx, (%edi) + /* Other entries are 2MB pages. */ + mov $(4 * 512 - 1), %ecx + /* + * Value below should be 4GB + flags, which wouldn't fit in 32b + * register. To avoid warning from the assembler, 4GB is skipped here. + * Substitution in first iteration makes the value roll over and point + * to 4GB - 2MB + flags. + */ + mov $(_PAGE_PSE + __PAGE_HYPERVISOR), %edx +.Lfill_l2_identmap: + sub $(1 << L2_PAGETABLE_SHIFT), %edx + /* Loop runs for ecx=[2047..1] for entries [2047..1]. */ + mov %edx, (%edi,%ecx,8) + loop .Lfill_l2_identmap + + /* 1x L3 page, mapping the 4x L2 pages. */ + lea sym_esi(l3_bootmap), %edi + mov $4, %ecx + lea (sym_offs(l2_bootmap) + 4 * PAGE_SIZE + __PAGE_HYPERVISOR)(%esi), %edx +.Lfill_l3_identmap: + sub $PAGE_SIZE, %edx + /* Loop runs for ecx=[4..1] for entries [3..0], hence -8. */ + mov %edx, -8(%edi,%ecx,8) + loop .Lfill_l3_identmap + + /* 1x L4 page, mapping the L3 page. */ + lea (sym_offs(l3_bootmap) + __PAGE_HYPERVISOR)(%esi), %edx + mov %edx, sym_esi(l4_bootmap) + + /* Restore CR4, PAE must be enabled before IA-32e mode */ + mov %cr4, %ecx + or $X86_CR4_PAE, %ecx + mov %ecx, %cr4 + + /* Load PML4 table location into PT base register */ + lea sym_esi(l4_bootmap), %eax + mov %eax, %cr3 + + /* Enable IA-32e mode and paging */ + mov $MSR_EFER, %ecx + rdmsr + or $EFER_LME >> 8, %ah + wrmsr + + mov %cr0, %eax + or $X86_CR0_PG | X86_CR0_NE | X86_CR0_TS | X86_CR0_MP, %eax + mov %eax, %cr0 + + /* Now in IA-32e compatibility mode, use lret to jump to 64b mode */ + lea sym_esi(start_xen_from_efi), %ecx + push $BOOT_CS64 + push %ecx + lret + +.global start_xen_from_efi + +#endif /* XEN_BUILD_EFI && CONFIG_SLAUNCH */ + ENTRY(trampoline_start) #include "trampoline.S" ENTRY(trampoline_end) diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S index 886960c22f..d23cfebdb6 100644 --- a/xen/arch/x86/boot/x86_64.S +++ b/xen/arch/x86/boot/x86_64.S @@ -267,14 +267,22 @@ GLOBAL(__page_tables_end) /* Init pagetables. Enough page directories to map into 4GB. */ .section .init.data.page_aligned, "aw", @progbits -DATA_LOCAL(l1_bootmap, PAGE_SIZE) +bootmap_start: + +DATA_LOCAL(l1_bootmap, PAGE_SIZE) /* 1x L1 page, mapping 2M of RAM. */ .fill L1_PAGETABLE_ENTRIES, 8, 0 END(l1_bootmap) -DATA(l2_bootmap, PAGE_SIZE) +DATA(l2_bootmap, PAGE_SIZE) /* 4x L2 pages, each mapping 1G of RAM. */ .fill 4 * L2_PAGETABLE_ENTRIES, 8, 0 END(l2_bootmap) -DATA(l3_bootmap, PAGE_SIZE) +DATA(l3_bootmap, PAGE_SIZE) /* 1x L3 page, mapping the 4x L2 pages. */ .fill L3_PAGETABLE_ENTRIES, 8, 0 END(l3_bootmap) + +DATA_LOCAL(l4_bootmap, PAGE_SIZE) /* 1x L4 page, mapping the L3 page. */ + .fill L4_PAGETABLE_ENTRIES, 8, 0 +END(l4_bootmap) + +bootmap_end: diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index d738b839ee..9653de4ca9 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -7,8 +7,15 @@ #ifndef X86_EFI_EFI_BOOT_H #define X86_EFI_EFI_BOOT_H +#include #include +/* + * Tell to access TXT registers without address translation + * which has not yet been set up. + */ +#define __EARLY_SLAUNCH__ + #include #include #include @@ -17,8 +24,11 @@ #include #include #include +#include +#include static struct file __initdata ucode; +static uint64_t __initdata xen_image_size; static multiboot_info_t __initdata mbi = { .flags = MBI_MODULES | MBI_LOADERNAME }; @@ -234,10 +244,31 @@ static void __init efi_arch_pre_exit_boot(void) } } -static void __init noreturn efi_arch_post_exit_boot(void) +void __init asmlinkage noreturn start_xen_from_efi(void) { u64 cr4 = XEN_MINIMAL_CR4 & ~X86_CR4_PGE, efer; + if ( slaunch_active ) + { + const struct slr_table *slrt = (const struct slr_table *)efi.slr; + const struct slr_entry_hdr *entry; + + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_INTEL_INFO); + if ( entry != NULL ) + { + const struct slr_entry_intel_info *intel_info = + container_of(entry, const struct slr_entry_intel_info, hdr); + void *txt_heap = txt_init(); + const struct txt_os_mle_data *os_mle = + txt_start(txt_heap, TXT_OS2MLE); + const struct txt_os_sinit_data *os_sinit = + txt_start(txt_heap, TXT_OS2SINIT); + + txt_verify_pmr_ranges(os_mle, os_sinit, intel_info, xen_phys_start, + xen_phys_start, xen_image_size); + } + } + efi_arch_relocate_image(__XEN_VIRT_START - xen_phys_start); memcpy(_p(trampoline_phys), trampoline_start, cfg.size); @@ -283,6 +314,66 @@ static void __init noreturn efi_arch_post_exit_boot(void) unreachable(); } +static void __init attempt_secure_launch(void) +{ +#ifdef CONFIG_SLAUNCH + const struct slr_table *slrt; + const struct slr_entry_hdr *entry; + const struct slr_entry_dl_info *dlinfo; + dl_handler_func handler_callback; + + /* The presence of this table indicates a Secure Launch boot. */ + slrt = (const struct slr_table *)efi.slr; + if ( efi.slr == EFI_INVALID_TABLE_ADDR || slrt->magic != SLR_TABLE_MAGIC || + slrt->revision != SLR_TABLE_REVISION ) + return; + + /* Avoid calls into firmware after DRTM. */ + __clear_bit(EFI_RS, &efi_flags); + + /* + * Make measurements less sensitive to hardware-specific details. + * + * Intentionally leaving efi_ct and efi_num_ct intact. + */ + efi_ih = NULL; + efi_bs = NULL; + efi_bs_revision = 0; + efi_rs = NULL; + efi_version = 0; + efi_fw_vendor = NULL; + efi_fw_revision = 0; + StdOut = NULL; + StdErr = NULL; + boot_tsc_stamp = 0; + + slaunch_active = true; + slaunch_slrt = efi.slr; + + /* Jump through DL stub to initiate Secure Launch. */ + entry = slr_next_entry_by_tag(slrt, NULL, SLR_ENTRY_DL_INFO); + dlinfo = container_of(entry, const struct slr_entry_dl_info, hdr); + + handler_callback = (dl_handler_func)dlinfo->dl_handler; + handler_callback(&dlinfo->bl_context); + + unreachable(); +#endif +} + +static void __init noreturn efi_arch_post_exit_boot(void) +{ + /* + * If Secure Launch happens, attempt_secure_launch() doesn't return and + * start_xen_from_efi() is invoked after DRTM has been initiated. + * Otherwise, attempt_secure_launch() returns and execution continues as + * usual. + */ + attempt_secure_launch(); + + start_xen_from_efi(); +} + static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE *dir_handle, const char *section) @@ -783,6 +874,7 @@ static void noreturn __init efi_arch_halt(void) static void __init efi_arch_load_addr_check(const EFI_LOADED_IMAGE *loaded_image) { xen_phys_start = (UINTN)loaded_image->ImageBase; + xen_image_size = loaded_image->ImageSize; if ( (xen_phys_start + loaded_image->ImageSize - 1) >> 32 ) blexit(L"Xen must be loaded below 4Gb."); if ( xen_phys_start & ((1 << L2_PAGETABLE_SHIFT) - 1) ) diff --git a/xen/arch/x86/efi/fixmlehdr.c b/xen/arch/x86/efi/fixmlehdr.c new file mode 100644 index 0000000000..60a91c6b73 --- /dev/null +++ b/xen/arch/x86/efi/fixmlehdr.c @@ -0,0 +1,127 @@ +#include +#include +#include +#include + +/* + * Depending on the toolchain and its configuration the header can end up quite + * far from the start of the file. + */ +#define PREFIX_SIZE (8*1024) + +struct mle_header +{ + uint8_t uuid[16]; + uint32_t header_len; + uint32_t version; + uint32_t entry_point; + uint32_t first_valid_page; + uint32_t mle_start; + uint32_t mle_end; + uint32_t capabilities; + uint32_t cmdline_start; + uint32_t cmdline_end; +} __attribute__ ((packed)); + +static const uint8_t MLE_HEADER_UUID[] = { + 0x5a, 0xac, 0x82, 0x90, 0x6f, 0x47, 0xa7, 0x74, + 0x0f, 0x5c, 0x55, 0xa2, 0xcb, 0x51, 0xb6, 0x42 +}; + +int main(int argc, char *argv[]) +{ + FILE *fp; + struct mle_header header; + int i; + char *end_ptr; + long long correction; + const char *file_path; + + if ( argc != 3 ) + { + fprintf(stderr, "Usage: %s \n", argv[0]); + return 1; + } + + correction = strtoll(argv[2], &end_ptr, 0); + if ( *end_ptr != '\0' ) + { + fprintf(stderr, "Failed to parse '%s' as a number\n", argv[2]); + return 1; + } + if ( correction < INT32_MIN ) + { + fprintf(stderr, "Correction '%s' is too small\n", argv[2]); + return 1; + } + if ( correction > INT32_MAX ) + { + fprintf(stderr, "Correction '%s' is too large\n", argv[2]); + return 1; + } + + file_path = argv[1]; + + fp = fopen(file_path, "r+"); + if ( fp == NULL ) + { + fprintf(stderr, "Failed to open %s\n", file_path); + return 1; + } + + for ( i = 0; i < PREFIX_SIZE; i += 16 ) + { + uint8_t bytes[16]; + + if ( fread(bytes, sizeof(bytes), 1, fp) != 1 ) + { + fprintf(stderr, "Failed to find MLE header in %s\n", file_path); + goto fail; + } + + if ( memcmp(bytes, MLE_HEADER_UUID, 16) == 0 ) + { + break; + } + } + + if ( i >= PREFIX_SIZE ) + { + fprintf(stderr, "Failed to find MLE header in %s\n", file_path); + goto fail; + } + + if ( fseek(fp, -16, SEEK_CUR) ) + { + fprintf(stderr, "Failed to seek back to MLE header in %s\n", file_path); + goto fail; + } + + if ( fread(&header, sizeof(header), 1, fp) != 1 ) + { + fprintf(stderr, "Failed to read MLE header from %s\n", file_path); + goto fail; + } + + if ( fseek(fp, -(int)sizeof(header), SEEK_CUR) ) + { + fprintf(stderr, "Failed to seek back again to MLE header in %s\n", + file_path); + goto fail; + } + + header.entry_point += correction; + + if ( fwrite(&header, sizeof(header), 1, fp) != 1 ) + { + fprintf(stderr, "Failed to write MLE header in %s\n", file_path); + goto fail; + } + + fclose(fp); + return 0; + +fail: + fclose(fp); + return 1; +} diff --git a/xen/arch/x86/slaunch.c b/xen/arch/x86/slaunch.c index af88ca9caa..e506fb4293 100644 --- a/xen/arch/x86/slaunch.c +++ b/xen/arch/x86/slaunch.c @@ -6,6 +6,7 @@ */ #include +#include #include #include #include @@ -252,10 +253,23 @@ check_drtm_policy(const struct slr_table *slrt, { uint32_t i; uint32_t num_mod_entries; + int min_entries; - if ( policy->nr_entries < 2 ) - panic("DRTM policy in SLRT contains less than 2 entries (%d)!\n", - policy->nr_entries); + min_entries = efi_enabled(EFI_BOOT) ? 1 : 2; + if ( policy->nr_entries < min_entries ) + { + panic("DRTM policy in SLRT contains less than %d entries (%d)!\n", + min_entries, policy->nr_entries); + } + + if ( efi_enabled(EFI_BOOT) ) + { + check_slrt_policy_entry(&policy_entry[0], 0, slrt); + /* SLRT was measured in slaunch_measure_slrt(). */ + return 1; + } + + /* This must be legacy MultiBoot2 boot. */ /* * MBI policy entry must be the first one, so that measuring order matches @@ -324,6 +338,7 @@ void __init slaunch_process_drtm_policy(const struct boot_info *bi) const struct slr_table *slrt; const struct slr_entry_policy *policy; struct slr_policy_entry *policy_entry; + int rc; uint16_t i; unsigned int measured; @@ -338,7 +353,6 @@ void __init slaunch_process_drtm_policy(const struct boot_info *bi) for ( i = measured; i < policy->nr_entries; i++ ) { - int rc; uint64_t start = policy_entry[i].entity; uint64_t size = policy_entry[i].size; @@ -384,6 +398,59 @@ void __init slaunch_process_drtm_policy(const struct boot_info *bi) policy_entry[i].flags |= SLR_POLICY_FLAG_MEASURED; } + + /* + * On x86 EFI platforms Xen reads its command-line options and kernel/initrd + * from configuration files (several can be chained). Bootloader can't know + * contents of the configuration beforehand without parsing it, so there + * will be no corresponding policy entries. Instead, measure command-line + * and all modules here. + */ + if ( efi_enabled(EFI_BOOT) ) + { +#define LOG_DATA(str) (uint8_t *)(str), (sizeof(str) - 1) + + slaunch_hash_extend(DRTM_LOC, DRTM_DATA_PCR, + (const uint8_t *)bi->cmdline, strlen(bi->cmdline), + DLE_EVTYPE_SLAUNCH, LOG_DATA("Xen's command line")); + + for ( i = 0; i < bi->nr_modules; i++ ) + { + const struct boot_module *mod = &bi->mods[i]; + + paddr_t string = mod->arch.cmdline_pa; + paddr_t start = mod->start; + size_t size = mod->size; + + if ( mod->arch.relocated || mod->arch.released ) + { + panic("A module \"%s\" (#%d) was consumed before measurement\n", + (const char *)__va(string), i); + } + + /* + * Measuring module's name separately because module's command-line + * parameters are appended to its name when present. + * + * 2 MiB is minimally mapped size and it should more than suffice. + */ + rc = slaunch_map_l2(string, 2 * 1024 * 1024); + BUG_ON(rc != 0); + + slaunch_hash_extend(DRTM_LOC, DRTM_DATA_PCR, + __va(string), strlen(__va(string)), + DLE_EVTYPE_SLAUNCH, + LOG_DATA("MB module string")); + + rc = slaunch_map_l2(start, size); + BUG_ON(rc != 0); + + slaunch_hash_extend(DRTM_LOC, DRTM_CODE_PCR, __va(start), size, + DLE_EVTYPE_SLAUNCH, LOG_DATA("MB module")); + } + +#undef LOG_DATA + } } int __init slaunch_map_l2(paddr_t paddr, size_t size) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 8f24df9bc2..41ccc6dcd3 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -19,6 +19,7 @@ #if EFI_PAGE_SIZE != PAGE_SIZE # error Cannot use xen/pfn.h here! #endif +#include #include #include #ifdef CONFIG_X86 @@ -45,6 +46,8 @@ #define EFI_SYSTEM_RESOURCE_TABLE_GUID \ { 0xb122a263U, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 0x80} } #define EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION 1 +#define UEFI_SLR_TABLE_GUID \ + { 0x877a9b2aU, 0x0385, 0x45d1, { 0xa0, 0x34, 0x9d, 0xac, 0x9c, 0x9e, 0x56, 0x5f } } typedef struct { EFI_GUID FwClass; @@ -1154,6 +1157,7 @@ static void __init efi_tables(void) static EFI_GUID __initdata mps_guid = MPS_TABLE_GUID; static EFI_GUID __initdata smbios_guid = SMBIOS_TABLE_GUID; static EFI_GUID __initdata smbios3_guid = SMBIOS3_TABLE_GUID; + static EFI_GUID __initdata slr_guid = UEFI_SLR_TABLE_GUID; if ( match_guid(&acpi2_guid, &efi_ct[i].VendorGuid) ) efi.acpi20 = (unsigned long)efi_ct[i].VendorTable; @@ -1165,6 +1169,8 @@ static void __init efi_tables(void) efi.smbios = (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) ) efi.smbios3 = (unsigned long)efi_ct[i].VendorTable; + if ( match_guid(&slr_guid, &efi_ct[i].VendorGuid) ) + efi.slr = (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) ) esrt = (UINTN)efi_ct[i].VendorTable; } diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c index 596f2710fb..b2cebaad02 100644 --- a/xen/common/efi/runtime.c +++ b/xen/common/efi/runtime.c @@ -72,6 +72,7 @@ struct efi __read_mostly efi = { .mps = EFI_INVALID_TABLE_ADDR, .smbios = EFI_INVALID_TABLE_ADDR, .smbios3 = EFI_INVALID_TABLE_ADDR, + .slr = EFI_INVALID_TABLE_ADDR, }; const struct efi_pci_rom *__read_mostly efi_pci_roms; diff --git a/xen/include/xen/efi.h b/xen/include/xen/efi.h index 87146172ad..37d016d885 100644 --- a/xen/include/xen/efi.h +++ b/xen/include/xen/efi.h @@ -17,6 +17,7 @@ struct efi { unsigned long acpi20; /* ACPI table (ACPI 2.0) */ unsigned long smbios; /* SM BIOS table */ unsigned long smbios3; /* SMBIOS v3 table */ + unsigned long slr; /* SLR table */ }; extern struct efi efi; -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 13:17:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 13:17:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380765.1624510 (Exim 4.92) (envelope-from ) id 1wqW4k-0005ZC-Mm; Sun, 02 Aug 2026 13:17:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380765.1624510; Sun, 02 Aug 2026 13:17:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4k-0005Z5-In; Sun, 02 Aug 2026 13:17:58 +0000 Received: by outflank-mailman (input) for mailman id 1380765; Sun, 02 Aug 2026 13:17:57 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqW4j-0005S2-7S for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 13:17:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqW4i-004dxe-Kg for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:17:56 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f4339-e002-0a2a0a5209dd-0a2a45049482-46 for ; Sun, 02 Aug 2026 15:17:56 +0200 Received: from [188.165.56.177] (helo=19.mo582.mail-out.ovh.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f41df-b57f-0a2a45040019-bca538b1e9cd-3 for ; Sun, 02 Aug 2026 15:10:55 +0200 Received: from director10.ghost.mail-out.ovh.net (unknown [10.109.231.29]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 4hCgCy6f3Lz5yDC for ; Sun, 2 Aug 2026 13:10:54 +0000 (UTC) Received: from ghost-submission-7d8d68f679-zgxq6 (unknown [10.110.178.25]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id F0D1BC0F59; Sun, 2 Aug 2026 13:10:53 +0000 (UTC) Received: from 3mdeb.com ([37.59.142.98]) by ghost-submission-7d8d68f679-zgxq6 with ESMTPSA id uCqTMN1Bb2oVAxsAmLjjbA (envelope-from ); Sun, 02 Aug 2026 13:10:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ovhmo3617313-selector1 header.d=3mdeb.com header.i="@3mdeb.com" header.h=From Authentication-Results:garm.ovh; auth=pass (GARM-98R002ead41966-a0ae-48e8-ac73-de1d09aa3230, A7BD45287BC66A7121136900083CD01C39616B1D) smtp.auth=sergii.dmytruk@3mdeb.com X-OVh-ClientIp:176.111.181.215 From: Sergii Dmytruk To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , trenchboot-devel@googlegroups.com Subject: [PATCH v4 23/23] MAINTAINERS: add a section for TrenchBoot Slaunch Date: Sun, 2 Aug 2026 16:09:39 +0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x-ovh-tracer-id: 4746231058255652284 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTF70AoUNTuq0lE163/HHHmITb2k71K2uLoI2ZNhSgyl66wu8n/QJYzc+NLLaUb0uP1TrkyCR/9L8Ilu8caNGFiWNKPhk8LryKkv9xxZSrEN1zqyUGrQN6nXky3jMJxzdN9g/O0CtTLwNhHfleReQxYNqzRPBHWIFmbNp+cZCBU9E3JqDvY2G2n8Fq8vuRNzFdlGIcwMaDxCbm3ZzhQ1uRn2km7gAWfvABUN0yPDoQrFrCjLaFwKnQdy3a/cfWa0gHDTshjKSe3BdNtt7392P9RjMTs2j3tG0nmovZ410v/2dE5urrhoo3isYDb0H1B5YfdyZsu/PJWc0DbUySgFmJKBTwglKriq0gRMo1PkDd+xpWGLikl+rCGY83aL//Ruy+v/Mbj+0ZQsS8vdQI51LmzJzowkH1FGK9Z/4lYtIhngAxkTZCHoLGrmjs6snH8aiEvzdH3eGN/lNIqA4na2G+WgTW6ogNPO38BfcpkFZW1g9nmrbYYZ94Ah1ERH3PwZuFNYG/O1viBVOjdlrbn08mtWY9cFI2Ip+UV3QOWEvXvmV9rVR9CGSKGI3lBu76WftB73RKTJFT9HXgsnN0EeP/3/Wz/Zw1Q4jjyp9RXGBzAuAjIaBxP0asvu0zNdezWDGFBBZHDV56W2fOUJ1ZciSUxT/veWKpAUrtOhunw4sZRMEQ DKIM-Signature: a=rsa-sha256; bh=v4IOVEJofe0j1YxPJgQI553fOjaIdjsxp1gURHV2leg=; c=relaxed/relaxed; d=3mdeb.com; h=From; s=ovhmo3617313-selector1; t=1785676254; v=1; b=GYK1oxgVKJNi1aeOLTTwHscO9lEmKDNgG+soSTQH+gPXT52aNsi2DEneiC9mNWTL95wnDy0T KaczshOcgzqWDw2NEdT7uwFFiFODqT0vWAQUwiA2/6uf7bMZW+LRIB+h8CaEr9wTnA0kfGxDYp8 /4vtboAgGX7aVCfkyHCxlVmX9OgUHsKZUw3i0zGxTScB8L4XsbZIUq45Xn8oMCLqpr6F61M4pr0 8sQXivfjcuT0XgY7W6qOPdnDblMp4FMLw+uJSbPwKm4Nu9LAHyBCc+0J8BmhSzTzCx7ze3/UXpp DX7HNqDkM4hZGjn1L2+V73m0MTYy1puGBGS+VGwXz2MZA== X-purgate-ID: tlsNG-ebf023/1785676255-522D4B50-F23E0C30/0/0 X-purgate-type: clean X-purgate-size: 1139 Signed-off-by: Sergii Dmytruk --- Notes: v4: updated list of files to match this patchset MAINTAINERS | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ed0ffa608f..54c0428f8d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -565,6 +565,25 @@ F: */configure F: */*.ac F: tools/ +TRENCHBOOT SECURE LAUNCH +R: Daniel P. Smith +R: Ross Philipson +R: Sergii Dmytruk +S: Supported +F: xen/arch/x86/boot/slaunch-early.c +F: xen/arch/x86/efi/fixmlehdr.c +F: xen/arch/x86/include/asm/intel-txt.h +F: xen/arch/x86/include/asm/slaunch-tpm.h +F: xen/arch/x86/include/asm/slaunch.h +F: xen/arch/x86/include/asm/tpm.h +F: xen/arch/x86/include/asm/tpm1.h +F: xen/arch/x86/include/asm/tpm2.h +F: xen/arch/x86/intel-txt.c +F: xen/arch/x86/slaunch-tpm.c +F: xen/arch/x86/slaunch.c +F: xen/arch/x86/tpm.c +F: xen/include/xen/slr-table.h + VM EVENT, MEM ACCESS and MONITOR M: Tamas K Lengyel S: Supported -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Sun Aug 02 14:46:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 14:46:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380828.1624520 (Exim 4.92) (envelope-from ) id 1wqXSI-00034v-Rc; Sun, 02 Aug 2026 14:46:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380828.1624520; Sun, 02 Aug 2026 14:46:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXSI-00034o-Oq; Sun, 02 Aug 2026 14:46:22 +0000 Received: by outflank-mailman (input) for mailman id 1380828; Sun, 02 Aug 2026 14:46:21 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXSG-00034i-Uw for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 14:46:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXSG-00Bx6q-5q for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 16:46:20 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5830-bab6-0a2a0a5309dd-0a2a450bc278-8 for ; Sun, 02 Aug 2026 16:46:19 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5839-b7e8-0a2a450b0019-888fbc33527e-3 for ; Sun, 02 Aug 2026 16:46:19 +0200 Received: by mx.zohomail.com with SMTPS id 1785681972445252.2089444850145; Sun, 2 Aug 2026 07:46:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785681976; cv=none; d=zohomail.com; s=zohoarc; b=HRDJ5TU4A/2Q+ugBz1yN3EHE5j2GRSNS/7EVriDnj+UeFvsH0y5Y8lyneUxhVwAN3v10S2v0Gg8q/ORNriJ3S7+e1xyUkjD4k3GmQGHSgdeHtR/IRdEz36nVIt7w1SfmUMdEaRrowdjC+OfVwDUgoLb633hDf4YKMVnsB+hE1yI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785681976; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=kzbKdiqKfTJpZx1LkDJ90vqeYWH3KR+8s82icRqzEnw=; b=BK4MqGoQVy07at+Ah2nTYuVntosF2cvhw/jT4RvmmIXiNXBfoSQmcKbFf+amG2IXDBxa5CrZs2EQeMmdkcle0BP59sFjZMFxRY8sblJmaig8V7DapFIG/9qFrEk1sHAm8zf4FNBxs+nwZHrxbII5QM6QpZDLSRCsgZvrKmtq1kw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785681976; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=kzbKdiqKfTJpZx1LkDJ90vqeYWH3KR+8s82icRqzEnw=; b=tAJgAZScKoeyvnl5f7/f+E4z8skg8wsJntAfaO7HHZWXvlS9lv9+K1J81sMxKaF5 LEeMd6+xnaYtFcYIzjAX69Sfi6n++EoknqOjudo2Pb0WQla1u/XuSFI9yMtn0F8rMqZ iuk+WFWRFXm50qjF2py3MpUYGCDWKXpYZj0suDGI= Message-ID: <7a406302-5b29-4b21-8a00-12bcae460c74@apertussolutions.com> Date: Sun, 2 Aug 2026 10:46:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/24] XSM: reduce redundancy in hook machinery To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <7487f138-e5e9-41d6-9291-f5eef42d09a1@suse.com> <62738b20-ef4b-47ac-832c-5c5fe353e56f@apertussolutions.com> <8030ff8e-ed83-46c4-ba69-4954ee645c38@suse.com> <19775f5b-e458-4336-92a3-8f8103708564@apertussolutions.com> <8b4568ef-1fe7-4a3f-b1b4-a3175ebe62d9@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <8b4568ef-1fe7-4a3f-b1b4-a3175ebe62d9@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-42698a/1785681979-1B4D39EA-85CB4AC8/0/0 X-purgate-type: clean X-purgate-size: 1614 On 7/31/26 4:03 AM, Jan Beulich wrote: > On 30.07.2026 20:21, Daniel P. Smith wrote: >> On 7/30/26 11:18 AM, Jan Beulich wrote: >>> On 30.07.2026 17:05, Daniel P. Smith wrote: >>>> On 7/28/26 9:13 AM, Jan Beulich wrote: >>>>> Hooks not taking xsm_default_t as first argument could of course be >>>>> adjusted to take one, at which point they could be covered here as well. >>>>> Question is why there is this difference in the first place. >>>> >>>> I have a theory but I am not confident to write it down. I can see if I >>>> can confirm with DDG if you really care that much to know the why. >>>> Personally having a consistent hook interface convention would provide a >>>> simpler pattern for people to follow if they are having to introdcue a >>>> new hook. >>> >>> Well, I don't really need to know the reason. If you agree that making >>> things uniform is a good move, I can simply stick a few more patches at >>> the end of this series. >> >> Correct me if I am wrong, but we would be introducing an unused >> parameter in exchange for uniform interfaces that can be generated with >> machinery reducing hook maintenance overhead. IMHO I feel from a >> security standpoint this would be a win. Would you disagree? > > Definitely not. What I'm unsure is whether I'd call this a security related > win. To me it's more a win in maintainability in general. Which of course > (typically) also helps security of the resulting code. That's what I was intending in that statement, Reducing fragility in code/maintenance increases stability and thus security. v//r, dps From xen-devel-bounces@lists.xenproject.org Sun Aug 02 14:50:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 14:50:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380835.1624528 (Exim 4.92) (envelope-from ) id 1wqXWV-0006Ge-AZ; Sun, 02 Aug 2026 14:50:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380835.1624528; Sun, 02 Aug 2026 14:50:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXWV-0006GX-7p; Sun, 02 Aug 2026 14:50:43 +0000 Received: by outflank-mailman (input) for mailman id 1380835; Sun, 02 Aug 2026 14:50:42 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXWU-0006GR-Rm for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 14:50:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXWU-00BxXT-8h for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 16:50:42 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f58e6-e002-0a2a0a5209dd-0a2a4503c7d6-42 for ; Sun, 02 Aug 2026 16:50:41 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f593f-fae8-0a2a45030019-888fbc335281-3 for ; Sun, 02 Aug 2026 16:50:41 +0200 Received: by mx.zohomail.com with SMTPS id 1785682235119466.7755168004719; Sun, 2 Aug 2026 07:50:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785682237; cv=none; d=zohomail.com; s=zohoarc; b=BjJvg9Ur3O4HJe/WTBimbNZYGF8Cq7NcfHKEaHEXLkbVWTnOT+A/KzPVTYUT1i+Hv7fW94VSMXONHgr78zK3QejinALH/X8dvIeZgbOfCknOzpe9BiwOZF9MBT2sfszSu6yNcLdByXet3m+vv88VuM2JuD7oECwf6NV16fLOpc0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785682237; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ISvWVng+FYKzx5n50hE5vRcVh5WIYwczRj0Moy6WDrY=; b=TXiza9+cibhr+Q3vJN7h6Ai3c2NdqlnGZM5uj2qf/cHtFLcL5QfRTZWKXa8UKnPNeYGmuS7TvUKnuG/jFEEFoUBy8+I3gciUzBJF3L8/NaRCDaqjosGitA88VHkfMU42f9Gv5eJU9pvwnhTAqEVeHbKcdSIXob2hTwoUTKV4fQo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785682237; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=ISvWVng+FYKzx5n50hE5vRcVh5WIYwczRj0Moy6WDrY=; b=P7UmLbn7Svay2k+rGOTlKbmhyPGt54da8NGrdKnKmhz/ouGVpwqlxUVCbvbbNmAa rz3F7oa1Nx9Sv+g4I2iSZyUcOFDKkQQYEc0SQjwXsyhUYSrns0o4CUkm7dxaQ7w6ora l3eMz6ajRMjMboQzuQyw6MfayWJbRaDj4CjpshI4= Message-ID: Date: Sun, 2 Aug 2026 10:50:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/24] XSM: make .{,un}map_domain_pirq() hooks dependent upon HAS_PIRQ=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <9a0a1494-1357-43d2-ba6b-532fc01b703e@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <9a0a1494-1357-43d2-ba6b-532fc01b703e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-33051d/1785682241-77AC44E9-E6498643/0/0 X-purgate-type: clean X-purgate-size: 3272 On 7/28/26 9:14 AM, Jan Beulich wrote: > They're unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -450,6 +450,8 @@ static XSM_INLINE char *cf_check xsm_sho > return NULL; > } > > +#ifdef CONFIG_HAS_PIRQ > + > static XSM_INLINE int cf_check xsm_map_domain_pirq( > XSM_DEFAULT_ARG struct domain *d) > { > @@ -457,17 +459,19 @@ static XSM_INLINE int cf_check xsm_map_d > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_map_domain_irq( > - XSM_DEFAULT_ARG struct domain *d, int irq, const void *data) > +static XSM_INLINE int cf_check xsm_unmap_domain_pirq( > + XSM_DEFAULT_ARG struct domain *d) > { > - XSM_ASSERT_ACTION(XSM_HOOK); > + XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_unmap_domain_pirq( > - XSM_DEFAULT_ARG struct domain *d) > +#endif /* CONFIG_HAS_PIRQ */ > + > +static XSM_INLINE int cf_check xsm_map_domain_irq( > + XSM_DEFAULT_ARG struct domain *d, int irq, const void *data) > { > - XSM_ASSERT_ACTION(XSM_DM_PRIV); > + XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > } > > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -65,9 +65,12 @@ XSM_HOOK(int, kexec) > > XSM_HOOK(int, schedop_shutdown, struct domain *, struct domain *) > > +#ifdef CONFIG_HAS_PIRQ > XSM_HOOK(int, map_domain_pirq, struct domain *) > -XSM_HOOK(int, map_domain_irq, struct domain *, int, const void *) > XSM_HOOK(int, unmap_domain_pirq, struct domain *) > +#endif > + > +XSM_HOOK(int, map_domain_irq, struct domain *, int, const void *) > XSM_HOOK(int, unmap_domain_irq, struct domain *, int, const void *) > XSM_HOOK(int, bind_pt_irq, struct domain *, struct xen_domctl_bind_pt_irq *) > XSM_HOOK(int, unbind_pt_irq, struct domain *, struct xen_domctl_bind_pt_irq *) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1018,11 +1018,20 @@ static char *cf_check flask_show_irq_sid > return ctx; > } > > +#ifdef CONFIG_HAS_PIRQ > + > static int cf_check flask_map_domain_pirq(struct domain *d) > { > return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD); > } > > +static int cf_check flask_unmap_domain_pirq(struct domain *d) > +{ > + return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE); > +} > + > +#endif /* CONFIG_HAS_PIRQ */ > + > static int flask_map_domain_msi ( > struct domain *d, int irq, const void *data, uint32_t *sid, > struct avc_audit_data *ad) > @@ -1085,11 +1094,6 @@ static int cf_check flask_map_domain_irq > return rc; > } > > -static int cf_check flask_unmap_domain_pirq(struct domain *d) > -{ > - return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE); > -} > - > static int flask_unmap_domain_msi ( > struct domain *d, int irq, const void *data, uint32_t *sid, > struct avc_audit_data *ad) > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 14:53:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 14:53:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380843.1624537 (Exim 4.92) (envelope-from ) id 1wqXZ2-0007MU-MH; Sun, 02 Aug 2026 14:53:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380843.1624537; Sun, 02 Aug 2026 14:53:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXZ2-0007MN-Ja; Sun, 02 Aug 2026 14:53:20 +0000 Received: by outflank-mailman (input) for mailman id 1380843; Sun, 02 Aug 2026 14:53:20 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXZ1-0007MG-UM for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 14:53:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXZ1-00EjZv-BK for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 16:53:19 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5987-2eae-0a2a0a5409dd-0a2a4503c360-28 for ; Sun, 02 Aug 2026 16:53:19 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f59dd-fae8-0a2a45030019-888fbc335283-3 for ; Sun, 02 Aug 2026 16:53:19 +0200 Received: by mx.zohomail.com with SMTPS id 1785682393099230.6498974128616; Sun, 2 Aug 2026 07:53:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785682396; cv=none; d=zohomail.com; s=zohoarc; b=d/jEvwgzygpDUKscEvTENnwbGeqEQppbGQTHYTeGMeY/NizadalW2yDr3q8DWD/lY28Walnr+qoebhsijUXfBBIeEGVvjJJg38I2EeUa0ewVthp70/MWEDwWAXpq6DB6Kx1lAodH7HGOoQ0NjYu7cNwqi5M26GgzqOQ7q4wCo+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785682396; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=MVNr6pdZlz2IwSoh48lq1aj/GJU09fj8XWglhHdstE4=; b=OY5ygUpYC9t6cHdP2W1/ZdZpp9S2CFVfQTQ8r2wlMGwIl7irgEnw+WMZ8LKl0E/oiQKcLpcgHFpwF4d6horV+UaJJ5vsNkp6QkeXsMZBtngchMmbA3oQ1CeP1JIYRcDFdyTMZa9VjfarU/QN/6UnZKLLR04TADOIgtfiJBZ9AzA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785682396; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=MVNr6pdZlz2IwSoh48lq1aj/GJU09fj8XWglhHdstE4=; b=sdbVph9I/B6/a5Akzpjkd3Ey13f8D7tQFqHbksBzLvdUw/eJuPrjhETnY5QJju0G bvmGRyoFjjugEwGKsvKVpZ36SMi2GhoJJTNAtc003LrJxLM6RIYx34CHIbzxBHBP8zE zIAxrcO0TU82o640sy0768xuZnmuYjBguHWfvH/A= Message-ID: <68ebf12b-453c-490e-a9a3-87aa64693183@apertussolutions.com> Date: Sun, 2 Aug 2026 10:53:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/24] XSM: make PCI hooks dependent upon HAS_PCI=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <03267655-2c62-459a-abef-6a0a85a9fa44@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <03267655-2c62-459a-abef-6a0a85a9fa44@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-33051d/1785682399-6D2D84E9-A018125A/0/0 X-purgate-type: clean X-purgate-size: 4988 On 7/28/26 9:14 AM, Jan Beulich wrote: > They're unreachable / dead otherwise. Really resource_{,un}plug_pci() is > further limited to PCI pass-through. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -394,6 +394,8 @@ static XSM_INLINE int cf_check xsm_get_d > } > #endif /* HAS_PASSTHROUGH && HAS_PCI */ > > +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) > + > static XSM_INLINE int cf_check xsm_resource_plug_pci( > XSM_DEFAULT_ARG uint32_t machine_bdf) > { > @@ -408,6 +410,10 @@ static XSM_INLINE int cf_check xsm_resou > return xsm_default_action(action, current->domain, NULL); > } > > +#endif /* CONFIG_HAS_PASSTHROUGH && CONFIG_HAS_PCI */ > + > +#ifdef CONFIG_HAS_PCI > + > static XSM_INLINE int cf_check xsm_resource_setup_pci( > XSM_DEFAULT_ARG uint32_t machine_bdf) > { > @@ -421,6 +427,8 @@ static XSM_INLINE int cf_check xsm_resou > return xsm_default_action(action, current->domain, NULL); > } > > +#endif /* CONFIG_HAS_PCI */ > + > static XSM_INLINE int cf_check xsm_resource_setup_misc(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > @@ -524,6 +532,7 @@ static XSM_INLINE int cf_check xsm_iomem > return xsm_default_action(action, current->domain, d); > } > > +#ifdef CONFIG_HAS_PCI > static XSM_INLINE int cf_check xsm_pci_config_permission( > XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf, uint16_t start, > uint16_t end, uint8_t access) > @@ -531,6 +540,7 @@ static XSM_INLINE int cf_check xsm_pci_c > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > } > +#endif /* CONFIG_HAS_PCI */ > > static XSM_INLINE int cf_check xsm_add_to_physmap( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -77,21 +77,24 @@ XSM_HOOK(int, unbind_pt_irq, struct doma > > XSM_HOOK(int, irq_permission, struct domain *, int, uint8_t) > XSM_HOOK(int, iomem_permission, struct domain *, uint64_t, uint64_t, uint8_t) > -XSM_HOOK(int, pci_config_permission, struct domain *, uint32_t, uint16_t, > - uint16_t, uint8_t) > > XSM_HOOK(int, iomem_mapping, struct domain *, uint64_t, uint64_t, uint8_t) > XSM_HOOK(int, iomem_mapping_vpci, struct domain *, uint64_t, uint64_t, uint8_t) > > #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) > +XSM_HOOK(int, resource_plug_pci, uint32_t) > +XSM_HOOK(int, resource_unplug_pci, uint32_t) > XSM_HOOK(int, get_device_group, uint32_t) > #endif > > -XSM_HOOK(int, resource_plug_pci, uint32_t) > -XSM_HOOK(int, resource_unplug_pci, uint32_t) > +XSM_HOOK(int, resource_setup_misc) > + > +#ifdef CONFIG_HAS_PCI > XSM_HOOK(int, resource_setup_pci, uint32_t) > XSM_HOOK(int, resource_setup_gsi, int) > -XSM_HOOK(int, resource_setup_misc) > +XSM_HOOK(int, pci_config_permission, struct domain *, uint32_t, uint16_t, > + uint16_t, uint8_t) > +#endif > > XSM_HOOK(int, hypfs_op) > > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1225,6 +1225,7 @@ static int cf_check flask_iomem_mapping( > } > #define flask_iomem_mapping_vpci flask_iomem_mapping > > +#ifdef CONFIG_HAS_PCI > static int cf_check flask_pci_config_permission( > struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, > uint8_t access) > @@ -1250,6 +1251,7 @@ static int cf_check flask_pci_config_per > return avc_has_perm(dsid, rsid, SECCLASS_RESOURCE, perm, &ad); > > } > +#endif /* CONFIG_HAS_PCI */ > > #if defined(CONFIG_SYSCTL) || defined(CONFIG_X86) > static int flask_resource_plug_core(void) > @@ -1270,6 +1272,8 @@ static int flask_resource_use_core(void) > } > #endif /* CONFIG_SYSCTL */ > > +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) > + > static int cf_check flask_resource_plug_pci(uint32_t machine_bdf) > { > uint32_t rsid; > @@ -1300,6 +1304,10 @@ static int cf_check flask_resource_unplu > return avc_current_has_perm(rsid, SECCLASS_RESOURCE, RESOURCE__UNPLUG, &ad); > } > > +#endif /* CONFIG_HAS_PASSTHROUGH && CONFIG_HAS_PCI */ > + > +#ifdef CONFIG_HAS_PCI > + > static int cf_check flask_resource_setup_pci(uint32_t machine_bdf) > { > uint32_t rsid; > @@ -1328,6 +1336,8 @@ static int cf_check flask_resource_setup > return avc_current_has_perm(rsid, SECCLASS_RESOURCE, RESOURCE__SETUP, &ad); > } > > +#endif /* CONFIG_HAS_PCI */ > + > static int cf_check flask_resource_setup_misc(void) > { > return avc_current_has_perm(SECINITSID_XEN, SECCLASS_RESOURCE, RESOURCE__SETUP, NULL); > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 14:56:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 14:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380850.1624548 (Exim 4.92) (envelope-from ) id 1wqXbj-0007sh-3f; Sun, 02 Aug 2026 14:56:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380850.1624548; Sun, 02 Aug 2026 14:56:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXbj-0007sZ-09; Sun, 02 Aug 2026 14:56:07 +0000 Received: by outflank-mailman (input) for mailman id 1380850; Sun, 02 Aug 2026 14:56:05 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXbh-0007sQ-HI for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 14:56:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXbg-008Ecu-AZ for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 16:56:04 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5a74-bab6-0a2a0a5309dd-0a2a4507d39a-24 for ; Sun, 02 Aug 2026 16:56:03 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5a82-b4ea-0a2a45070019-888fbc335287-3 for ; Sun, 02 Aug 2026 16:56:03 +0200 Received: by mx.zohomail.com with SMTPS id 178568255845463.554231152630905; Sun, 2 Aug 2026 07:55:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785682560; cv=none; d=zohomail.com; s=zohoarc; b=VAz/p1RK69xgKt3N5Ueaeb2Ye60bKh3LCyM31UCMlhV3/EhyHrwa+u5FIDhPVeXRm6dR/YlYaMMi0DqBOu88sFQBTn2Q9PDn1QDWLr9bYL4rAWHAUr24JjkTBvuBQNPcsSkcAtvwpuS/Vq8hWA1R4BGjlkkg2enbhVxwwvvVDVg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785682560; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=nEk+EQeINCftDeVHUH0EflRmlpsWdGR8Goc03eXOtm0=; b=DzWgvtMCbIMrAI7krK0TgLj/r+L9h6CeLRPVbR7bkiJ4jptPtMV1IrRFkBXY7zzq9SvAOlU27qq0lGtndIc1iwKLXH3rC/D/mLof8pAr+SLQyjLwtWkz5Ue/vFStz2mF9VMA3Q+60ujCon8uLil0zEMw0FpzU5/kRdg41leRgOg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785682560; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=nEk+EQeINCftDeVHUH0EflRmlpsWdGR8Goc03eXOtm0=; b=ZlnuS17pnusfi7K+aUQ9fGKYWiiwOroh508btkj3cng82X4QCfyJdqYN0HhPsTAY 3mIUcBVDT/2tPaHSFGaRXOoLXOj8dxNpoOoBSG2ztJv7Rsann6JeXdOu9KbIvOa6VVR RjlkxNs2GeAQcUTaE+/qULGsKm9rkWwbc8fpsT0I= Message-ID: Date: Sun, 2 Aug 2026 10:56:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/24] XSM: make .iomem_mapping_vcpi() hook dependent upon HAS_VPCI=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-ef75cf/1785682563-36AD8AE4-51E90D11/0/0 X-purgate-type: clean X-purgate-size: 1435 nit: typo in subject, .iomem_mapping_vcpi --> .iomem_mapping_vpci On 7/28/26 9:15 AM, Jan Beulich wrote: > It's unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -525,12 +525,14 @@ static XSM_INLINE int cf_check xsm_iomem > return xsm_default_action(action, current->domain, d); > } > > +#ifdef CONFIG_HAS_VPCI > static XSM_INLINE int cf_check xsm_iomem_mapping_vpci( > XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > } > +#endif > > #ifdef CONFIG_HAS_PCI > static XSM_INLINE int cf_check xsm_pci_config_permission( > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -79,7 +79,9 @@ XSM_HOOK(int, irq_permission, struct dom > XSM_HOOK(int, iomem_permission, struct domain *, uint64_t, uint64_t, uint8_t) > > XSM_HOOK(int, iomem_mapping, struct domain *, uint64_t, uint64_t, uint8_t) > +#ifdef CONFIG_HAS_VPCI > XSM_HOOK(int, iomem_mapping_vpci, struct domain *, uint64_t, uint64_t, uint8_t) > +#endif > > #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) > XSM_HOOK(int, resource_plug_pci, uint32_t) > Outside of the typo, Acked-by: Daniel P. Smith Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 14:57:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380858.1624557 (Exim 4.92) (envelope-from ) id 1wqXd6-0008PI-Gg; Sun, 02 Aug 2026 14:57:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380858.1624557; Sun, 02 Aug 2026 14:57:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXd6-0008PB-DC; Sun, 02 Aug 2026 14:57:32 +0000 Received: by outflank-mailman (input) for mailman id 1380858; Sun, 02 Aug 2026 14:57:31 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXd5-0008P0-6w for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 14:57:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXd4-004pUG-GT for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 16:57:30 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5a86-5cb7-0a2a0a5109dd-0a2a450ce622-34 for ; Sun, 02 Aug 2026 16:57:30 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5ad8-f479-0a2a450c0019-888fbc335289-3 for ; Sun, 02 Aug 2026 16:57:29 +0200 Received: by mx.zohomail.com with SMTPS id 1785682644042977.50931892548; Sun, 2 Aug 2026 07:57:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785682646; cv=none; d=zohomail.com; s=zohoarc; b=MfQVxdtrEo3vzcogysJ0n6twxCqO81WwpEAuGkVDaySx6pheZmMYgX2dUMFT5tNpA7I46D8mXFYbFZOpTcjOQaun6Fki3xcKRGE67cOdIYYNpUUL7pu0PK2J+S/0o8aA9sVSGF5OSqVSV6stGg2Xc0g1vcNBzHDVtVeWXck0f6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785682646; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=jAIVKTmnx4gCtqOEaDrwuXQfRKpW+w0HA/n4qqJv41k=; b=mOxqlThpBeNpX6kbJvmyOetTyvzTA0WBJliiwFyczpceyWhBt0I/ZIC+YRBOXZJvJWR3BsidYDp11l8LX8zglElUsJphRJVGVOsADa0LMPm05RiLJX18+BDxMjGhEB6IWrvl36BjbjE8D93UfSrjbgHHTSAlvhUsCUztbnqqsSE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785682646; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=jAIVKTmnx4gCtqOEaDrwuXQfRKpW+w0HA/n4qqJv41k=; b=OXLjjLBHGad9mwdDElfcYTGIBu4oJvYh2GB1ocCq3kvjyjsJVG0u5irLRa7w8Dvn vRk4sBl/6guFSmop6QjQab/rs/4MkjjQySsHkCDva3YoBxhMQpwJwmgRXg/GGIvOrcJ zIfF5kAydkviuAYdZLaRHD5xY2UFZavw0qfdK3q8= Message-ID: Date: Sun, 2 Aug 2026 10:57:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/24] XSM: make .kexec() hook dependent upon KEXEC=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <2916d9d7-9a9f-4e1f-9202-628532abe35f@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <2916d9d7-9a9f-4e1f-9202-628532abe35f@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-d25034/1785682650-5113AA5B-96141E13/0/0 X-purgate-type: clean X-purgate-size: 1516 On 7/28/26 9:15 AM, Jan Beulich wrote: > It's unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -271,11 +271,13 @@ static XSM_INLINE int cf_check xsm_conso > return xsm_default_action(XSM_PRIV, d, NULL); > } > > +#ifdef CONFIG_KEXEC > static XSM_INLINE int cf_check xsm_kexec(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > +#endif > > static XSM_INLINE int cf_check xsm_schedop_shutdown( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -61,7 +61,9 @@ XSM_HOOK(int, claim_pages, struct domain > > XSM_HOOK(int, console_io, struct domain *, int) > > +#ifdef CONFIG_KEXEC > XSM_HOOK(int, kexec) > +#endif > > XSM_HOOK(int, schedop_shutdown, struct domain *, struct domain *) > > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -536,10 +536,12 @@ static int cf_check flask_console_io(str > return domain_has_xen(d, perm); > } > > +#ifdef CONFIG_KEXEC > static int cf_check flask_kexec(void) > { > return domain_has_xen(current->domain, XEN__KEXEC); > } > +#endif > > static int cf_check flask_schedop_shutdown(struct domain *d1, struct domain *d2) > { > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 14:58:06 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 14:58:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380865.1624564 (Exim 4.92) (envelope-from ) id 1wqXde-0000uk-N9; Sun, 02 Aug 2026 14:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380865.1624564; Sun, 02 Aug 2026 14:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXde-0000ud-K3; Sun, 02 Aug 2026 14:58:06 +0000 Received: by outflank-mailman (input) for mailman id 1380865; Sun, 02 Aug 2026 14:58:04 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXdc-0000t9-RP for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 14:58:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXdc-008duG-8E for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 16:58:04 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5a82-e002-0a2a0a5209dd-0a2a4502b080-44 for ; Sun, 02 Aug 2026 16:58:04 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5afa-6ca4-0a2a45020019-888fbc33528b-3 for ; Sun, 02 Aug 2026 16:58:03 +0200 Received: by mx.zohomail.com with SMTPS id 1785682678158727.6091595839646; Sun, 2 Aug 2026 07:57:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785682680; cv=none; d=zohomail.com; s=zohoarc; b=l93sO3TQy5KsKGpBeegk8uZbkDc3HHjNFOP7L/lE5pT9B5le7PNaCRl/xc5DtWIMrQCEiD79IjiUnpIqyZXNJ2w6cyO110xl45PZN6sWlIiBRZB1hq+g5oZbRw2T1fO93esQhNukfA9mAKbzFDdSj7Nf1oXJ0toNhQF+WOaXUbk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785682680; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=BwGvxoIih3661XeJf2rM9xF1BG7ESvF8oCZ8jkGkMck=; b=Ls/iWKGc5ghTQSB6AnUc/V7+VIBBfO83yeEO8SZFp2Zfsl4LunjtcWKqe0Rdq9utlUqjQCmUNm8l3W7JbrLwL+T83W4EFNmAOwHIMIFyn+lJdZ3fxdTALLDRv9JMzbN6mh5PLaQXUasnMzOKpaVrbCWcoNu2WcgaGRusKF0YZKs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785682680; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=BwGvxoIih3661XeJf2rM9xF1BG7ESvF8oCZ8jkGkMck=; b=bfJ1m9c53Ek8zCJBV/ThB8bSFPLfARVVHg4+fj+mNoz3zNG7JsDighoVvz9T50nD fznLZtWDTreVRBKlbaVjc8Az6d0v63mWj+71Z1g9buwNzimdsPll1fTVh1twdu2Hup6 Yrno74Nd0FxB+dNvMXMW2I3AQg6vzAB3v+FxCNyU= Message-ID: Date: Sun, 2 Aug 2026 10:58:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/24] XSM: make .hypfs() hook dependent upon HYPFS=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4efdae21-c8be-4fa0-825f-6369ed5d0b90@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <4efdae21-c8be-4fa0-825f-6369ed5d0b90@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-720697/1785682684-F22A92AC-E5AF4DEF/0/0 X-purgate-type: clean X-purgate-size: 1632 On 7/28/26 9:15 AM, Jan Beulich wrote: > It's unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -437,11 +437,13 @@ static XSM_INLINE int cf_check xsm_resou > return xsm_default_action(action, current->domain, NULL); > } > > +#ifdef CONFIG_HYPFS > static XSM_INLINE int cf_check xsm_hypfs_op(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > +#endif > > static XSM_INLINE long cf_check xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > { > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -100,7 +100,9 @@ XSM_HOOK(int, pci_config_permission, str > uint16_t, uint8_t) > #endif > > +#ifdef CONFIG_HYPFS > XSM_HOOK(int, hypfs_op) > +#endif > > XSM_HOOK(int, hvm_param, struct domain *, unsigned long) > XSM_HOOK(int, hvm_param_altp2mhvm, struct domain *) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1345,10 +1345,12 @@ static int cf_check flask_resource_setup > return avc_current_has_perm(SECINITSID_XEN, SECCLASS_RESOURCE, RESOURCE__SETUP, NULL); > } > > +#ifdef CONFIG_HYPFS > static inline int cf_check flask_hypfs_op(void) > { > return domain_has_xen(current->domain, XEN__HYPFS_OP); > } > +#endif > > static int cf_check flask_add_to_physmap(struct domain *d1, struct domain *d2) > { > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 14:58:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 14:58:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380872.1624574 (Exim 4.92) (envelope-from ) id 1wqXeQ-0001lo-UU; Sun, 02 Aug 2026 14:58:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380872.1624574; Sun, 02 Aug 2026 14:58:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXeQ-0001lf-RQ; Sun, 02 Aug 2026 14:58:54 +0000 Received: by outflank-mailman (input) for mailman id 1380872; Sun, 02 Aug 2026 14:58:52 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXeO-0001kH-OI for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 14:58:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXeO-00EkCO-3x for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 16:58:52 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5aa6-e002-0a2a0a5209dd-0a2a4504e618-40 for ; Sun, 02 Aug 2026 16:58:52 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5b2a-b57f-0a2a45040019-888fbc33528f-3 for ; Sun, 02 Aug 2026 16:58:51 +0200 Received: by mx.zohomail.com with SMTPS id 1785682725347102.55751453144865; Sun, 2 Aug 2026 07:58:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785682729; cv=none; d=zohomail.com; s=zohoarc; b=B19UDRc0SzbXVQDRZUNSVL4UsnJxj34lfr68VKa7JyhXd0TNQYun/s3jYF4VXnpKTCQ298mxoh8s7PhIhI0vfl/zOLSDJA0m5/LPjdAJyhSrMsAIEN2+LujRCZfUg+6j7xCHEekoLHi8sCvKI9aJ6inRlwihu7h1z2NAf/r3uOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785682729; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=REvUedEfGalwFIovbtEDV+JDqejvcYhtg35ytkXdVpc=; b=iut2fLazBw/vKWIM5I+TY18Yoy84paB96TVtRakN770ciFdsypzWbjrbJTc9DdrZ29G+tN/ruASZ1B6el+fpfddG8oxGDmDhu6/AXFvW9eD3mVY72QgXnDMUHjfZiRFcgPfgAlaWACDLcJxuhpp6eZpMpAHofQBOpXT8ulQIJMw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785682729; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=REvUedEfGalwFIovbtEDV+JDqejvcYhtg35ytkXdVpc=; b=fTt9kgy9TUpKvDiOzOYS6va+k7lu7zY6vL+qX4HSNeajG6dip+6qDbayCJjkAG32 BJuY/aoKYYHZaosQgYn744Vh/LVtlOVVqV9suqMpZuUH5rmySNQyRGNb775jlDJ7WVl PZeWxb+6z15ZYjbdm1htD5VnScTqrrSD10PLnNaA= Message-ID: <2eb2dc6c-6a12-4f62-9966-2945c7468ad8@apertussolutions.com> Date: Sun, 2 Aug 2026 10:58:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/24] XSM: make .hvm_altp2mhvm_op() hook dependent upon ALTP2M=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <5250093e-174f-4d2d-b19b-95a314b38469@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <5250093e-174f-4d2d-b19b-95a314b38469@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-ebf023/1785682732-51ED6B50-40D95FD7/0/0 X-purgate-type: clean X-purgate-size: 1892 On 7/28/26 9:16 AM, Jan Beulich wrote: > It's unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -583,6 +583,7 @@ static XSM_INLINE int cf_check xsm_hvm_p > return xsm_default_action(action, current->domain, d); > } > > +#ifdef CONFIG_ALTP2M > static XSM_INLINE int cf_check xsm_hvm_altp2mhvm_op( > XSM_DEFAULT_ARG struct domain *d, uint64_t mode, uint32_t op) > { > @@ -602,6 +603,7 @@ static XSM_INLINE int cf_check xsm_hvm_a > return -EPERM; > } > } > +#endif /* CONFIG_ALTP2M */ > > #ifdef CONFIG_VM_EVENT > static XSM_INLINE int cf_check xsm_mem_access(XSM_DEFAULT_ARG struct domain *d) > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -106,7 +106,11 @@ XSM_HOOK(int, hypfs_op) > > XSM_HOOK(int, hvm_param, struct domain *, unsigned long) > XSM_HOOK(int, hvm_param_altp2mhvm, struct domain *) > + > +#ifdef CONFIG_ALTP2M > XSM_HOOK(int, hvm_altp2mhvm_op, struct domain *, uint64_t, uint32_t) > +#endif > + > XSM_HOOK(int, get_vnumainfo, struct domain *) > > #ifdef CONFIG_VM_EVENT > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1393,6 +1393,7 @@ static int cf_check flask_hvm_param_altp > return current_has_perm(d, SECCLASS_HVM, HVM__ALTP2MHVM); > } > > +#ifdef CONFIG_ALTP2M > static int cf_check flask_hvm_altp2mhvm_op(struct domain *d, uint64_t mode, uint32_t op) > { > /* > @@ -1416,6 +1417,7 @@ static int cf_check flask_hvm_altp2mhvm_ > > return current_has_perm(d, SECCLASS_HVM, HVM__ALTP2MHVM_OP); > } > +#endif /* CONFIG_ALTP2M */ > > #ifdef CONFIG_VM_EVENT > static int cf_check flask_mem_access(struct domain *d) > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 15:05:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 15:05:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380883.1624582 (Exim 4.92) (envelope-from ) id 1wqXka-0005Fg-K3; Sun, 02 Aug 2026 15:05:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380883.1624582; Sun, 02 Aug 2026 15:05:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXka-0005FZ-HP; Sun, 02 Aug 2026 15:05:16 +0000 Received: by outflank-mailman (input) for mailman id 1380883; Sun, 02 Aug 2026 15:05:16 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXka-0005FT-1W for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:05:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXkZ-00BrS3-En for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 17:05:15 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5c72-bab6-0a2a0a5309dd-0a2a450bd02a-48 for ; Sun, 02 Aug 2026 17:05:14 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5ca8-b7e8-0a2a450b0019-888fbc33529e-3 for ; Sun, 02 Aug 2026 17:05:14 +0200 Received: by mx.zohomail.com with SMTPS id 1785683108310689.3839985231745; Sun, 2 Aug 2026 08:05:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785683110; cv=none; d=zohomail.com; s=zohoarc; b=kJGfvfFGGUdVCpdJp0jQBcqrzBM3AF3QTRgXkCiwTAlasW1Tz/uqmlaXNDeR8aPGmBUVQc6dht9ugFn4P4PoEjJa4FqyiWLVpkvpnkIhE74NSsq7ZBZfloe/b8XwdxOBbVpv4ulNO/HqFWsL4z84pelKjgimt+Vc3QrzjtmAseI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785683110; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=kjBmZcGw1BB42KQvYs/PpCClxsoGAWvtXvcmYYyz9s0=; b=XRWg9THcX6KTmkb5++uWQkMaduSCGYjCm9jhlicmqS2JCG9RuufQLpCT41D4lgsb9Puu7xl+8qVTeTwMWcF3AjuZ4cyvtUsk21OwwtBYOjIn4hPrF/T4B/vQF18mvvuXMty7jGUM7TyOeXKWLo08I4e9dz7cuLkfJEM3Yb6YFCU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785683110; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=kjBmZcGw1BB42KQvYs/PpCClxsoGAWvtXvcmYYyz9s0=; b=pvZDpAi7RQVMdnqXLKQdxQbBukZYsZdO21SMZWPQBygNQjcwomaL1cBtc4NO2nJV Cqhhg5b8rM6oo+RFbaq7Zk85KcsswOss0rcvD9hssAbj2JggIOeCI9Fl09zDycSUnQ6 y5GxxKBxECXzCMa0Rs0s7ZzUG07IB7XL5kulZvUc= Message-ID: <1b4d5a82-bdc4-460d-a5a4-59e788fe1c3f@apertussolutions.com> Date: Sun, 2 Aug 2026 11:05:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/24] XSM: make .hvm_param*() hooks dependent upon HVM=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <7947b62f-6763-4561-b3aa-c451cfa3dacb@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <7947b62f-6763-4561-b3aa-c451cfa3dacb@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-42698a/1785683114-19AC09EA-985CE3FF/0/0 X-purgate-type: clean X-purgate-size: 2234 On 7/28/26 9:17 AM, Jan Beulich wrote: > They're unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > --- > Strictly speaking .hvm_param_altp2mhvm() is dependent upon X86=y as well > (but oddly not dependent upon ALTP2M=y). > At a minimum, would it be worth at least adding a comment about the dependency? Note, this is just a question/suggestion. > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -569,6 +569,8 @@ static XSM_INLINE int cf_check xsm_map_g > return xsm_default_action(action, d, t); > } > > +#ifdef CONFIG_HVM > + > static XSM_INLINE int cf_check xsm_hvm_param( > XSM_DEFAULT_ARG struct domain *d, unsigned long op) > { > @@ -583,6 +585,8 @@ static XSM_INLINE int cf_check xsm_hvm_p > return xsm_default_action(action, current->domain, d); > } > > +#endif /* CONFIG_HVM */ > + > #ifdef CONFIG_ALTP2M > static XSM_INLINE int cf_check xsm_hvm_altp2mhvm_op( > XSM_DEFAULT_ARG struct domain *d, uint64_t mode, uint32_t op) > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -104,8 +104,10 @@ XSM_HOOK(int, pci_config_permission, str > XSM_HOOK(int, hypfs_op) > #endif > > +#ifdef CONFIG_HVM > XSM_HOOK(int, hvm_param, struct domain *, unsigned long) > XSM_HOOK(int, hvm_param_altp2mhvm, struct domain *) > +#endif > > #ifdef CONFIG_ALTP2M > XSM_HOOK(int, hvm_altp2mhvm_op, struct domain *, uint64_t, uint32_t) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1368,6 +1368,8 @@ static int cf_check flask_map_gmfn_forei > return domain_has_perm(d, t, SECCLASS_MMU, MMU__MAP_READ | MMU__MAP_WRITE); > } > > +#ifdef CONFIG_HVM > + > static int cf_check flask_hvm_param(struct domain *d, unsigned long op) > { > uint32_t perm; > @@ -1393,6 +1395,8 @@ static int cf_check flask_hvm_param_altp > return current_has_perm(d, SECCLASS_HVM, HVM__ALTP2MHVM); > } > > +#endif /* CONFIG_HVM */ > + > #ifdef CONFIG_ALTP2M > static int cf_check flask_hvm_altp2mhvm_op(struct domain *d, uint64_t mode, uint32_t op) > { > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 15:05:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 15:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380885.1624592 (Exim 4.92) (envelope-from ) id 1wqXkv-0005ap-S4; Sun, 02 Aug 2026 15:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380885.1624592; Sun, 02 Aug 2026 15:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXkv-0005ai-OX; Sun, 02 Aug 2026 15:05:37 +0000 Received: by outflank-mailman (input) for mailman id 1380885; Sun, 02 Aug 2026 15:05:37 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXkv-0005aO-7U for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:05:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXku-001xcr-KX for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 17:05:36 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5cad-5cb7-0a2a0a5109dd-0a2a450aaae0-14 for ; Sun, 02 Aug 2026 17:05:36 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5cbe-f2d2-0a2a450a0019-888fbc3352a0-3 for ; Sun, 02 Aug 2026 17:05:36 +0200 Received: by mx.zohomail.com with SMTPS id 17856831301261005.6998583405325; Sun, 2 Aug 2026 08:05:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785683132; cv=none; d=zohomail.com; s=zohoarc; b=ZqRPG8fvxCgZkK6LfxcjzyLWWaAJMA0zF2gyrQYLnCF5YUoYJ3JZbEhgIBp0Fm+EjJlstpnaOPFEIUG2/nr9RH6xEvr7Zz5A/oFqUwsd2/bZPs4bewecFkTABqk3zlVo7mkYXOqAn3hHfeIu8d6K5rraOSYcOLwj2Ns9IHu9dnQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785683132; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=kjBmZcGw1BB42KQvYs/PpCClxsoGAWvtXvcmYYyz9s0=; b=VVFMidnOq0R+4tZfTf65HbPRZ4tF8Q3bVxzyQBgU+MoqUBIBzmXw9ibdzmBqR+wNQeOqqLBsAw2hAi55Q+pWUYgnnunDjq3/GuDrpd46qxvERVoM3uE/v5Xix0kLTmQxuWymRRccbAds3rGSHjL9gGvt/uE5oh6KnYPzrVGNPMw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785683132; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=kjBmZcGw1BB42KQvYs/PpCClxsoGAWvtXvcmYYyz9s0=; b=PUryuzvMSDtOuPz3h8gCgH52EVpu9tTiXPdUIY5g0IrYApwwtw7Tr02a2IYu3MTX MGp5W9WsIfvahnjtuyfpHThEX/cAcEKzgVWncSBBK17L7nMC0p4XTticL4KZabSY8yK pLs3QFtrb52qJTEiG6BBlOgxmqpLG4BlXfSU7qSk= Message-ID: Date: Sun, 2 Aug 2026 11:05:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/24] XSM: make .hvm_param*() hooks dependent upon HVM=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <7947b62f-6763-4561-b3aa-c451cfa3dacb@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <7947b62f-6763-4561-b3aa-c451cfa3dacb@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-4011c0/1785683136-59DDFCFC-E3355295/0/0 X-purgate-type: clean X-purgate-size: 2234 On 7/28/26 9:17 AM, Jan Beulich wrote: > They're unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > --- > Strictly speaking .hvm_param_altp2mhvm() is dependent upon X86=y as well > (but oddly not dependent upon ALTP2M=y). > At a minimum, would it be worth at least adding a comment about the dependency? Note, this is just a question/suggestion. > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -569,6 +569,8 @@ static XSM_INLINE int cf_check xsm_map_g > return xsm_default_action(action, d, t); > } > > +#ifdef CONFIG_HVM > + > static XSM_INLINE int cf_check xsm_hvm_param( > XSM_DEFAULT_ARG struct domain *d, unsigned long op) > { > @@ -583,6 +585,8 @@ static XSM_INLINE int cf_check xsm_hvm_p > return xsm_default_action(action, current->domain, d); > } > > +#endif /* CONFIG_HVM */ > + > #ifdef CONFIG_ALTP2M > static XSM_INLINE int cf_check xsm_hvm_altp2mhvm_op( > XSM_DEFAULT_ARG struct domain *d, uint64_t mode, uint32_t op) > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -104,8 +104,10 @@ XSM_HOOK(int, pci_config_permission, str > XSM_HOOK(int, hypfs_op) > #endif > > +#ifdef CONFIG_HVM > XSM_HOOK(int, hvm_param, struct domain *, unsigned long) > XSM_HOOK(int, hvm_param_altp2mhvm, struct domain *) > +#endif > > #ifdef CONFIG_ALTP2M > XSM_HOOK(int, hvm_altp2mhvm_op, struct domain *, uint64_t, uint32_t) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1368,6 +1368,8 @@ static int cf_check flask_map_gmfn_forei > return domain_has_perm(d, t, SECCLASS_MMU, MMU__MAP_READ | MMU__MAP_WRITE); > } > > +#ifdef CONFIG_HVM > + > static int cf_check flask_hvm_param(struct domain *d, unsigned long op) > { > uint32_t perm; > @@ -1393,6 +1395,8 @@ static int cf_check flask_hvm_param_altp > return current_has_perm(d, SECCLASS_HVM, HVM__ALTP2MHVM); > } > > +#endif /* CONFIG_HVM */ > + > #ifdef CONFIG_ALTP2M > static int cf_check flask_hvm_altp2mhvm_op(struct domain *d, uint64_t mode, uint32_t op) > { > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 15:07:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 15:07:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380898.1624600 (Exim 4.92) (envelope-from ) id 1wqXmt-0006lc-Bk; Sun, 02 Aug 2026 15:07:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380898.1624600; Sun, 02 Aug 2026 15:07:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXmt-0006lV-98; Sun, 02 Aug 2026 15:07:39 +0000 Received: by outflank-mailman (input) for mailman id 1380898; Sun, 02 Aug 2026 15:07:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXmr-0006jH-Qa for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:07:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXmq-008fFA-F7 for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 17:07:36 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5d37-bab6-0a2a0a5309dd-0a2a450ac334-2 for ; Sun, 02 Aug 2026 17:07:36 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5d36-f2d2-0a2a450a0019-888fbc3352a2-3 for ; Sun, 02 Aug 2026 17:07:36 +0200 Received: by mx.zohomail.com with SMTPS id 1785683251443735.8930538915141; Sun, 2 Aug 2026 08:07:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785683253; cv=none; d=zohomail.com; s=zohoarc; b=F8rudERShobwyQAzml22u79eQoqJpuYeUFVBRoRrGH3/Akju7tILgCxvOuoUzZroUFWD0JCFs+mdW/Vc6z+ogRGH8zHv0/XQlWoOTdWeIF/gOMyQaNp29GLe4y2Z9tWMJ/75+LAAZZ3gCd8GutjY2lUbrw1BnH2HV3cEpsPpI1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785683253; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=oGbJXX1sOwuN6ygD60/WQFIBvc8kIT+FhnM8E4QOS08=; b=nkP994rG7e6bybsqEwslBt8M0JIQ4NEgVCNF41IGBBiWFLg4UwyX2bodRnkLKo7iQY0ie4Y9SBq0xA4OIVll7iQ9LSrdjHsgYCXY61H+srAuPR5ZwzdDntLtbZmV2hxG59hASpq/ykjER/8eooW6616p7/2M3aIyPx1jPO+oO7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785683253; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=oGbJXX1sOwuN6ygD60/WQFIBvc8kIT+FhnM8E4QOS08=; b=ZhbzfgLWaZ9qftjnBy9vtDV3G3twPnOqdJ6iVrfqSh4f4eeejQn484ergTjW7o3m F3F4KmRUq+JUXCOPBE1jDmimPzyTEQBpcuC4gW/7Ci13E7XbhRwd/IowmZBRor2lD1a vvNGD2x6tztEOIWboXMr89cnaNiQWk747ZKUGYhs= Message-ID: <821c7414-f0fc-4f18-88e7-294e8e5d78c7@apertussolutions.com> Date: Sun, 2 Aug 2026 11:07:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/24] XSM: make .dm_op() hook dependent upon IOREQ_SERVER=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <9ecda750-f0b5-49ad-9f6b-892a045b3b66@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <9ecda750-f0b5-49ad-9f6b-892a045b3b66@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-4011c0/1785683256-52CDBCFC-606E0E30/0/0 X-purgate-type: clean X-purgate-size: 1550 On 7/28/26 9:17 AM, Jan Beulich wrote: > It's unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -739,11 +739,13 @@ static XSM_INLINE int cf_check xsm_pmu_o > > #endif /* CONFIG_X86 */ > > +#ifdef CONFIG_IOREQ_SERVER > static XSM_INLINE int cf_check xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > +#endif > > #ifdef CONFIG_ARGO > static XSM_INLINE int cf_check xsm_argo_enable(const struct domain *d) > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -145,7 +145,10 @@ XSM_HOOK(int, ioport_mapping, struct dom > XSM_HOOK(int, pmu_op, struct domain *, unsigned int) > #endif /* CONFIG_X86 */ > > +#ifdef CONFIG_IOREQ_SERVER > XSM_HOOK(int, dm_op, struct domain *) > +#endif > + > XSM_HOOK(int, xen_version, uint32_t) > XSM_HOOK(int, domain_resource_map, struct domain *) > > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1852,10 +1852,12 @@ static int cf_check flask_pmu_op(struct > } > #endif /* CONFIG_X86 */ > > +#ifdef CONFIG_IOREQ_SERVER > static int cf_check flask_dm_op(struct domain *d) > { > return current_has_perm(d, SECCLASS_HVM, HVM__DM); > } > +#endif > > static int cf_check flask_xen_version(uint32_t op) > { > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 15:08:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 15:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380905.1624610 (Exim 4.92) (envelope-from ) id 1wqXo9-0007tN-MQ; Sun, 02 Aug 2026 15:08:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380905.1624610; Sun, 02 Aug 2026 15:08:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXo9-0007tG-Ie; Sun, 02 Aug 2026 15:08:57 +0000 Received: by outflank-mailman (input) for mailman id 1380905; Sun, 02 Aug 2026 15:08:55 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqXo7-0007t4-Qi for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:08:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqXo7-008fpt-7T for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 17:08:55 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f5d46-bab6-0a2a0a5309dd-0a2a4509a026-46 for ; Sun, 02 Aug 2026 17:08:54 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f5d84-be1a-0a2a45090019-888fbc3352a5-3 for ; Sun, 02 Aug 2026 17:08:54 +0200 Received: by mx.zohomail.com with SMTPS id 1785683328710862.2007758395154; Sun, 2 Aug 2026 08:08:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785683331; cv=none; d=zohomail.com; s=zohoarc; b=gkAqGa9mq9pC4fe6AcmrOrsZOfqoSQDpY3E+Ku9Xb8nAwFuD4kMkC62nUfpSL4cS0hJVpO8KTPxr2UMbZ4Wdg63nsPL7BRyw6YkijqiXQcSqC82E5/LtZnKjlVikYnEP5bnsbo10cRM2tdW/+XFWgnUcPKYlQCRHegAIbM+NcU4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785683331; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=VmVxueIYKCLre29nUNWrpK8gnn6byJI0KMoNwXHmXbQ=; b=j6gyWH4cPkZtqkqC2N2kHUSJjZ+7dcnaTRlL9WsXUidQ1kQ8Lj8pWs7COkKetGxQohnpeGHC+z+fgpeQdGK6p07vU1ADPt3W192g0PnRmPtA581yW6g9SBFywICJlghNZQ/HmXs+woiDSMd6Zpj0c9/4O7BsYkATZsIqhwMIQMk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785683331; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=VmVxueIYKCLre29nUNWrpK8gnn6byJI0KMoNwXHmXbQ=; b=tRzJkfX4BLAucN9+kOWarZnM4vcrESq8Kj0tzWAqNV4oLFf9dkRk+MBA3TyNV3HD vbrV7XbDCywF30sgBs7duBTM6YmVPiKWxhvouAELuuOVbau+Ehb2lSXyJxBZa9/2Zej YO74KH+vpRqwvF5kzjy+elktfNHKmTXbeMXdJpXE= Message-ID: <611d7bf0-94c4-4743-8d95-437d1729b9e4@apertussolutions.com> Date: Sun, 2 Aug 2026 11:08:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/24] XSM: make certain x86-specific hooks dependent upon PV=y To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <73257c34-3a86-46a2-b327-f35bff69399d@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <73257c34-3a86-46a2-b327-f35bff69399d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-bad1c0/1785683334-3A2C4034-07BDC739/0/0 X-purgate-type: clean X-purgate-size: 3541 On 7/28/26 9:18 AM, Jan Beulich wrote: > They're unreachable / dead otherwise. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -640,11 +640,6 @@ static XSM_INLINE int cf_check xsm_platf > } > > #ifdef CONFIG_X86 > -static XSM_INLINE int cf_check xsm_do_mca(XSM_DEFAULT_VOID) > -{ > - XSM_ASSERT_ACTION(XSM_PRIV); > - return xsm_default_action(action, current->domain, NULL); > -} > > static XSM_INLINE int cf_check xsm_mem_sharing_op( > XSM_DEFAULT_ARG struct domain *d, struct domain *cd, int op) > @@ -673,6 +668,14 @@ static XSM_INLINE int cf_check xsm_domai > return xsm_default_action(action, current->domain, d); > } > > +#ifdef CONFIG_PV > + > +static XSM_INLINE int cf_check xsm_do_mca(XSM_DEFAULT_VOID) > +{ > + XSM_ASSERT_ACTION(XSM_PRIV); > + return xsm_default_action(action, current->domain, NULL); > +} > + > static XSM_INLINE int cf_check xsm_mmu_update( > XSM_DEFAULT_ARG struct domain *d, struct domain *t, struct domain *f, > uint32_t flags) > @@ -700,6 +703,8 @@ static XSM_INLINE int cf_check xsm_updat > return xsm_default_action(action, d, f); > } > > +#endif /* CONFIG_PV */ > + > static XSM_INLINE int cf_check xsm_priv_mapping( > XSM_DEFAULT_ARG struct domain *d, struct domain *t) > { > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -131,14 +131,16 @@ XSM_HOOK(int, mem_sharing_op, struct dom > XSM_HOOK(int, platform_op, uint32_t) > > #ifdef CONFIG_X86 > -XSM_HOOK(int, do_mca) > XSM_HOOK(int, apic, struct domain *, int) > XSM_HOOK(int, machine_memory_map) > XSM_HOOK(int, domain_memory_map, struct domain *) > +#ifdef CONFIG_PV > +XSM_HOOK(int, do_mca) > XSM_HOOK(int, mmu_update, struct domain *, struct domain *, struct domain *, > uint32_t) > XSM_HOOK(int, mmuext_op, struct domain *, struct domain *) > XSM_HOOK(int, update_va_mapping, struct domain *, struct domain *, l1_pgentry_t) > +#endif /* CONFIG_PV */ > XSM_HOOK(int, priv_mapping, struct domain *, struct domain *) > XSM_HOOK(int, ioport_permission, struct domain *, uint32_t, uint32_t, uint8_t) > XSM_HOOK(int, ioport_mapping, struct domain *, uint32_t, uint32_t, uint8_t) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1654,10 +1654,6 @@ static int cf_check flask_platform_op(ui > } > > #ifdef CONFIG_X86 > -static int cf_check flask_do_mca(void) > -{ > - return domain_has_xen(current->domain, XEN__MCA_OP); > -} > > static int flask_shadow_control(struct domain *d, unsigned int op) > { > @@ -1783,6 +1779,13 @@ static int cf_check flask_domain_memory_ > return current_has_perm(d, SECCLASS_MMU, MMU__MEMORYMAP); > } > > +#ifdef CONFIG_PV > + > +static int cf_check flask_do_mca(void) > +{ > + return domain_has_xen(current->domain, XEN__MCA_OP); > +} > + > static int cf_check flask_mmu_update( > struct domain *d, struct domain *t, struct domain *f, uint32_t flags) > { > @@ -1823,6 +1826,8 @@ static int cf_check flask_update_va_mapp > return domain_has_perm(d, f, SECCLASS_MMU, map_perms); > } > > +#endif /* CONFIG_PV */ > + > static int cf_check flask_priv_mapping(struct domain *d, struct domain *t) > { > return domain_has_perm(d, t, SECCLASS_MMU, MMU__TARGET_HACK); > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Aug 02 15:55:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 02 Aug 2026 15:55:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1380929.1624618 (Exim 4.92) (envelope-from ) id 1wqYXP-0004Xw-0z; Sun, 02 Aug 2026 15:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1380929.1624618; Sun, 02 Aug 2026 15:55:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqYXO-0004Xp-Ud; Sun, 02 Aug 2026 15:55:42 +0000 Received: by outflank-mailman (input) for mailman id 1380929; Sun, 02 Aug 2026 15:55:41 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqYXN-0004Xi-4d for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 15:55:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqYXM-004wkr-31 for xen-devel@lists.xenproject.org; Sun, 02 Aug 2026 17:55:40 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6f6811-2eae-0a2a0a5409dd-0a2a4502e798-20 for ; Sun, 02 Aug 2026 17:55:40 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6f687a-6ca4-0a2a45020019-888fbc3352c0-3 for ; Sun, 02 Aug 2026 17:55:39 +0200 Received: by mx.zohomail.com with SMTPS id 1785686126692449.7937048040851; Sun, 2 Aug 2026 08:55:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785686130; cv=none; d=zohomail.com; s=zohoarc; b=femSRGpdtG1BdsSysSvXCjllA1p3DfbD2+gwqZf5uNIuoycZlm3/bX3TcQC2dW3bokA0PEsssCvVjtVFi+0YzXjzqSym8rCp/sMbg36e7LwZu4QXwuGG42TFBtOCPA+OkCcC1AJdWrFnX3ynRJbge2zfjCClHkqa059l7s6yH6w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785686130; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ei3nv7dzYgzxJ0zw1X14Ri/+yYhgMiX6VePRG6aHTzo=; b=YXmRxHxjFX8ACwZRrOppyKhrHb5RXSLVz3XMS/RLtI2Z7Nd5IK5RuHpwhp6KWU6oW93gaiFMDei2nyk/nSmBpjIU8n48v14GoDorIaN3B3Y//LT86boQQBI7z8zRIuIl9UJ+f8zJdDWUAoY/unbJds5DIPk0VTyEqc5M+YtI9Xc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785686130; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Ei3nv7dzYgzxJ0zw1X14Ri/+yYhgMiX6VePRG6aHTzo=; b=AohwUeyxTP2qY3/F4Xuw5AfjejshtKyhD3UD33nc4WVw73Dj/lTaG9dN8jkzo8Qm naXs7+2VDhJMw4WqNpPRjM0Jl9wiSFObQzum9X+dDROOZhreHilrrY6Tq+Ses/h9Ksz bmDeejVIsYQ3GnHLeiJ+xcI/u5TnPtcp8IQ5LVNA= Message-ID: <4531d02a-3a37-4c57-ba17-32034ba08cf9@apertussolutions.com> Date: Sun, 2 Aug 2026 11:55:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/24] x86/mm: get_page_from_l1e() is PV-or-shadow-only To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <07e90200-95b5-413f-9259-7f0481d36521@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <07e90200-95b5-413f-9259-7f0481d36521@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-720697/1785686140-F34BE2AC-A92D1B94/0/0 X-purgate-type: clean X-purgate-size: 3700 On 7/28/26 9:18 AM, Jan Beulich wrote: > Otherwise the function is unreachable, violating MISRA C:2012 rule 2.1. > With the function compiled out, its dedicated XSM hook also becomes > unreachable, so it is similarly guarded. > > Signed-off-by: Jan Beulich > --- > It feels suspicious that the .priv_mapping() check is used for HVM guests > in shadow mode, but not for ones in HAP mode. > I believe a hint to it is laying in the comment, /* * Let privileged domains transfer the right to map their target * domain's pages. This is used to allow stub-domain pvfb export to * dom0, until pvfb supports granted mappings. At that time this * minor hack can go away. */ Correct me if I am wrong, but get_page_from_l1e() is only used by PV and HVM + Shadow. When in HVM + HAP is mapping a guest page, it is done through p2m_get_foreign() which will then be covered by xsm_map_gmfn_foreign(). So only HVM + Shadow can hit TARGET_HACK check. I think the question is how to address the TARGET_HACK situation. > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -837,6 +837,8 @@ static int cf_check print_mmio_emul_rang > } > #endif > > +#if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) > + > /* > * get_page_from_l1e returns: > * 0 => success (page not present also counts as such) > @@ -1038,6 +1040,8 @@ get_page_from_l1e( > return -EBUSY; > } > > +#endif /* CONFIG_PV || CONFIG_SHADOW_PAGING */ > + Would it also not be prudent to #ifdef out the declaration in asm/mm.h? > /* > * The following flags are used to specify behavior of various get and > * put commands. The first is also stored in page->partial_flags to > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -705,12 +705,14 @@ static XSM_INLINE int cf_check xsm_updat > > #endif /* CONFIG_PV */ > > +#if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) > static XSM_INLINE int cf_check xsm_priv_mapping( > XSM_DEFAULT_ARG struct domain *d, struct domain *t) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d, t); > } > +#endif > > static XSM_INLINE int cf_check xsm_ioport_permission( > XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow) > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -141,7 +141,9 @@ XSM_HOOK(int, mmu_update, struct domain > XSM_HOOK(int, mmuext_op, struct domain *, struct domain *) > XSM_HOOK(int, update_va_mapping, struct domain *, struct domain *, l1_pgentry_t) > #endif /* CONFIG_PV */ > +#if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) > XSM_HOOK(int, priv_mapping, struct domain *, struct domain *) > +#endif > XSM_HOOK(int, ioport_permission, struct domain *, uint32_t, uint32_t, uint8_t) > XSM_HOOK(int, ioport_mapping, struct domain *, uint32_t, uint32_t, uint8_t) > XSM_HOOK(int, pmu_op, struct domain *, unsigned int) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1828,10 +1828,12 @@ static int cf_check flask_update_va_mapp > > #endif /* CONFIG_PV */ > > +#if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) > static int cf_check flask_priv_mapping(struct domain *d, struct domain *t) > { > return domain_has_perm(d, t, SECCLASS_MMU, MMU__TARGET_HACK); > } > +#endif > > static int cf_check flask_pmu_op(struct domain *d, unsigned int op) > { > I think it would be a good defensive approach to condition out the header declaration. Otherwise, Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Mon Aug 03 00:43:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 00:43:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381047.1624628 (Exim 4.92) (envelope-from ) id 1wqgmM-0003qU-V6; Mon, 03 Aug 2026 00:43:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381047.1624628; Mon, 03 Aug 2026 00:43:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqgmM-0003qN-SH; Mon, 03 Aug 2026 00:43:42 +0000 Received: by outflank-mailman (input) for mailman id 1381047; Mon, 03 Aug 2026 00:43:40 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqgmJ-0003ot-Ob for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 00:43:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqgmI-005yV6-J9 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 02:43:38 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6fe3ef-5cb7-0a2a0a5109dd-0a2a4503c442-20 for ; Mon, 03 Aug 2026 02:43:37 +0200 Received: from [52.101.229.77] (helo=TY3P286CU002.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6fe435-fae8-0a2a45030019-3465e54d30cb-3 for ; Mon, 03 Aug 2026 02:43:36 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TY4P286MB6832.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.17; Mon, 3 Aug 2026 00:43:30 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0270.016; Mon, 3 Aug 2026 00:43:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rA9hT+sa4szRgERS2SV9xt8KlQK4HrAtCc12HvBmBsd+xR1ziyBGdy5+juifdkwoC/rn8d7sNz3sLiePjoC+mDo+gDhr6sLeL3mqRhYuv0c8+KwtUbFV5vD8LW41ZbOpXAsIo1yO8x35X2m4kcKUiMzEfuaFixET8hivp0+G9AGsZXVHUbiCCXQwrpVzFkg0t9BrVfKxxXoolggyBzbeNILXtMGw3l+b9MT5uh7fVs8xkC+OgS+Ytx7xtUN1Ku1mDW217AcBF2quRhZRAlZGrH8yExXDpXcRyS8ml/3grW6o6COno6jmo51YrHSDhShEHDItuUrlv7XkIo2opa/JWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kvw2bZDRO4ch9uDZj3X9HF2N3NA+5bsuvObC4KDg1bg=; b=OyaU3Idm/mIEq8WjM7GGtuFtkSqMx38BRcMowGSYXY71wp0yOmA8+dWXgHKkiv3FYF71WalwGslaWYhMx+EZ56wVM5pPZ5wHVKa3pN2JxLWD7nIe/SabsZeCrAr9CJO2df7c4gEiIW9MxKlVifu3xDRKRyFtb9MsAoCuuqBIzVB0gvl5kA5NEbXIP1z7/JjJp2tdGOKust5FwZoZbz0Fun1dPXKzOe7LcAy01+IjWG3IGBI73ht8we5O4Rp7vuXxgf5GctFVB3RPWgGaafuvLEjkfGpy5z8YOh0mzP2nFBm+Tlv3YpeRyanjBr9V+yEzi/DtmGeW+3g5AWWvOpKdLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kvw2bZDRO4ch9uDZj3X9HF2N3NA+5bsuvObC4KDg1bg=; b=fMOdVn+7tR9FGFOg918I/2afUpjc9XopkmsicTAgSnw1sh6dZQrgjvR9q3aU8jfDGrUNLS5eiDu8re6SmO4a25XKGGZaytopZjJ58Z64zxOixq8bOxqSs5Mz+KjHZYQQ2xLqONyxHz7IhiT7fz3AzeiyR9w7eo9TjuOUjoi39io= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; From: Hirokazu Takahashi To: xen-devel@lists.xenproject.org Cc: Hirokazu Takahashi , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH] xen/arm: Hide PMU feature Date: Mon, 3 Aug 2026 09:42:45 +0900 Message-ID: <20260803004245.693844-1-taka@valinux.co.jp> X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TYCP301CA0088.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:7b::16) To OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9P286MB7222:EE_|TY4P286MB6832:EE_ X-MS-Office365-Filtering-Correlation-Id: fcb177a8-fa86-4813-bddb-08def0f83ce4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|1800799024|10070799003|6133799003|56012099006|10067099003|3023799007|18002099003; X-Microsoft-Antispam-Message-Info: T1GUEAOioOQ92ui6AMagEoTbboKNSNDbtEH8F/93oLwArBS8b4hicyNl/yizmOHyekSn/cuSJCQ+RMmhjS6RiZmxuFobYIED3P0sGzXyvobOsrSiCt+mgLYfGOQ0PE+90nEWNrTAAF1eS6SGfjKWvAUKF+RnBUvZAQG7uT9sIG8uuDNi7yY8dTdhVfVITzVU8EE3ka2pPcan1YeCuB1Ndy2D08uughljFtNUPCQwmtiSWlElv+siU/AwpnUyiwh2Nz8P7vklVHzY5mGXfJS2f0wZx5YNZZcxkWjCbnbT1u6GY/2wteWfR2oKc57NwwIj66sJafnW5PE8SA1h7colV/AMTBX3de2jZ+1n+6Fdd20BIP4+pZE9Enq/pIaCLTglpv58Qhv2v0LDWBQZGkoEugOMmQhSUiuZj+PPPJIoY0MV8S00LbHWI2BjEZa9WAL8XyfDfBHTxK9gVAv0I28WHOdGeUe5RWE6unOkXaZ7NTrAxacEKNzWX6CEVL4IgqhYcKtj6D6kTCLjk3L7KyzMUjPirh0F/YKZaokuO/Zq5vG/fWzdEn+pkibesCt7XRpJ2zX2vDt8n2svBiDJPzbVk8GSf6W9vKPx66OkRgIdkBWqlMXsKwJT+Emr+a3qGwJz7f7dhNGiT8r9kpfnxrtN7i0j7tg0WSMknrv95iM/sQk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(10070799003)(6133799003)(56012099006)(10067099003)(3023799007)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UhLnIU58IMMx34DuAEHo6WrkDvlLgpd30l0emMyayayhCx6u9O+BbHlbB4KU?= =?us-ascii?Q?WqYxxr73TU3HKhGdXXdjFtasOkGZ2pYGQRusUWatgwBkwWjE7lG9Xo/mpdnX?= =?us-ascii?Q?kBXpQ22mdTfKdrrg6Go0xRsUDs3QYWSE8Pgtc0Zny+tHznnqiuYwLPXC/Tgr?= =?us-ascii?Q?2vM4GkM19xX7tO3Xo9nllXq9yn0++EN0taLWikliwetVg76aRj5UIZTNV2tq?= =?us-ascii?Q?ysPCa9EATIkQ8T5e//2Hn+zo3QnhsHaSpxF/tML0mpTLsicM+bcdIzEu8HuA?= =?us-ascii?Q?aiB3O9xCCEhZNg3LkgemmcoqXGaGHkh8wxurlmsgvaNkrAa5QOSyde3YE/p0?= =?us-ascii?Q?mu2kH/gJcWgV2eiWFoPi+fIOEsUEHV6FGNSxx+aPuoubaqQGBT6MXcPtlOOB?= =?us-ascii?Q?7TpP1dFygU1Ndgbgv/6zfhJsOfLDqjrqiayu3vFktvaMvWsW1/ZCk6Wyd7SO?= =?us-ascii?Q?QWrtr3Zl5cHjq7HrERBvlvE97xyv/quZH5FxJSGWRStexkMI3bBSSWtQALmy?= =?us-ascii?Q?nq61COAKDqnOYyBK1Ga1lmHnizmGOCM2QhDwZlPDIk7sw8nai9mTmXWxy+zF?= =?us-ascii?Q?Qt+64WGRuUrHw9xk7Nh09KgYQDoC1LV+H0XUWmNDPy+hbsRA5+yj1KGPJ90j?= =?us-ascii?Q?CWn6JUCy7HTq7weMcWkGh5JzuyuQHLn1P/5Xm233qe2tBWtKXmklH424UFPt?= =?us-ascii?Q?1talkQyfqWSrwSQFwOLraBI1ugS0WYZt6AD5X0SlAtpUK8hFNsDu1rJWLRmf?= =?us-ascii?Q?D4HC27U3r5RLDZHTGulXX9I2BpvS8e/x0QGeorwa71WO6DX+V8ZyrwXMudPY?= =?us-ascii?Q?AcZo0M6RnvcVJrv7L+w/C9zAJx7Rh7CtejnLxJIHg9DJWVVVmb8u2FAcmAyp?= =?us-ascii?Q?T05C2WWNTxx5y1mpWTtlvyJ2zw+IIsIZjTlOq61Hh1YAWRNPggn16yZQnN4O?= =?us-ascii?Q?RlQu1nsYPnsIVVTcj0DuXV7qBL8NX6G9jDGUIYqpjyGdjts9/UgFV+Y5Fq1K?= =?us-ascii?Q?UBQJzDk+0JQw+/ZO329gb5Uc6hSAml2hsAVAIfbYEdWssLx/HCCshMMft8GL?= =?us-ascii?Q?Ek0MN31bw6exGx3/hFxfsq1JKpkzMo9T99Xuq5DZSA9VcZRN0xg0YhE3HGOp?= =?us-ascii?Q?urtbCztm5P9+qxZbwx86L/9daBvqTeQwPaiSJwn3gXxiaJ2ykIlrQcQpYaOS?= =?us-ascii?Q?biCEgpluiIlk70OrdXWUOpkdVYk3q9ggU2D3EfXt/H2Uf+5QgAR6rgfeNC0S?= =?us-ascii?Q?kdCQAIN0gKwCxkctA+7yDxfN77QxrUDIZjVThsMMrmrYu2GCMWAD+vX1BS4Q?= =?us-ascii?Q?AkD/hgY+XkgvwzXA07Pp9hd9ipbNPceGQIXkkGWW4Bz57eIhac6neBT5gVe+?= =?us-ascii?Q?Msm/wLv5t2jgO/uyE20lMfgTLF+iLFqHhj+SajhTTwyUYpr6AclIX/vs3FAQ?= =?us-ascii?Q?OIHKX2pTXt68QNgBe7oW/nAWI0aVv/KTr5WDQjF9xt6SIPSUVM8IM2xMQ7AH?= =?us-ascii?Q?fUBJIF11G70MtgAANSMUL+JtTPdA4KUHuegJ49I9KOAWrFcB2XtddrnBdYSe?= =?us-ascii?Q?LPe9GOuExarVrZQPrEsiathAWUAO+Amvk8y2LHxePi1ud005mzjhsKauesug?= =?us-ascii?Q?58E1xueE4jNv4aQwfxrSyZpN0zvKfSrfyg0CgR0dfVuqRivGijwykdqnKAae?= =?us-ascii?Q?4fKARNmzCGtXsi0xFtagQj9uEq9sLMxcetEdpcvv5/yWsEcLo9Ehlp5FdAIW?= =?us-ascii?Q?hHOYEvC5jMdBgeA1YufaiPFIf7jq8LlJogUPG9iSPuArBXpVpyEwc3ABib2h?= X-MS-Exchange-AntiSpam-MessageData-1: b2bE5gGc3lAy5A== X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: fcb177a8-fa86-4813-bddb-08def0f83ce4 X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 00:43:30.0171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gOdmSPcxDyK0PnSaP+QFHQPocYBGPNVA6OVABotbqZlWQNI/KVED28E4U4sWbuwegml4kw2+bY4AzswB+flOfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6832 X-purgate-ID: tlsNG-33051d/1785717817-762FD4E9-C3C8A53F/0/0 X-purgate-type: clean X-purgate-size: 3049 On ARMv8.4-A and newer platforms, booting Dom0 Linux with ACPI enabled causes the domain to probe advanced PMU feature based on system ID register ID_AA64DFR0_EL1. During this probe, Linux accesses PMMIR_EL1, which causes unhandled register traps and crashes the domain. Merely adding emulation code for PMMIR_EL1 in Xen is insufficient to fix the issue, as the guest PMU driver subsequently stalls during its initialization sequence. Fix this by explicitly masking PMU capability fields in create_domain_cpuinfo(). Additionally, preemptively mask other capability fields to prevent similar potential issues. Fixes: 3669a1cb9598 "xen/arm: create a cpuinfo structure for guest" Signed-off-by: Hirokazu Takahashi --- xen/arch/arm/cpufeature.c | 16 ++++++++++++++++ xen/arch/arm/include/asm/cpufeature.h | 10 ++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c index 94d14fb6a9..71d745d3cb 100644 --- a/xen/arch/arm/cpufeature.c +++ b/xen/arch/arm/cpufeature.c @@ -219,8 +219,24 @@ static int __init create_domain_cpuinfo(void) domain_cpuinfo.isa64.api = 0; domain_cpuinfo.isa64.gpa = 0; domain_cpuinfo.isa64.gpi = 0; + + /* Hide PMUv3 support as Xen does not support it */ + domain_cpuinfo.dbg64.pmu_ver = 0; + domain_cpuinfo.dbg64.mtpmu = 0; + domain_cpuinfo.dbg64.pmss = 0; + + /* Hide SPE, TRBE, BRBE, and Trace Extensions */ + domain_cpuinfo.dbg64.pms_ver = 0; + domain_cpuinfo.dbg64.trace_ver = 0; + domain_cpuinfo.dbg64.trace_filt = 0; + domain_cpuinfo.dbg64.trace_buffer = 0; + domain_cpuinfo.dbg64.ext_trc_buff = 0; + domain_cpuinfo.dbg64.brbe = 0; #endif + /* Hide PMUv1,v2 support as Xen does not support it */ + domain_cpuinfo.dbg32.perfmon = 0; + /* Hide AMU support */ #ifdef CONFIG_ARM_64 domain_cpuinfo.pfr64.amu = 0; diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index bf902a3970..c92b2651c7 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -216,16 +216,18 @@ struct cpuinfo_arm { unsigned long trace_ver:4; unsigned long pmu_ver:4; unsigned long brps:4; - unsigned long __res0:4; + unsigned long pmss:4; unsigned long wrps:4; - unsigned long __res1:4; + unsigned long sebep:4; unsigned long ctx_cmps:4; unsigned long pms_ver:4; unsigned long double_lock:4; unsigned long trace_filt:4; - unsigned long __res2:4; + unsigned long trace_buffer:4; unsigned long mtpmu:4; - unsigned long __res3:12; + unsigned long brbe:4; + unsigned long ext_trc_buff:4; + unsigned long hpmn0:4; /* DFR1 */ unsigned long __res4:64; -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 03:09:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 03:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381075.1624645 (Exim 4.92) (envelope-from ) id 1wqj35-0005Rc-T1; Mon, 03 Aug 2026 03:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381075.1624645; Mon, 03 Aug 2026 03:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqj35-0005RV-QO; Mon, 03 Aug 2026 03:09:07 +0000 Received: by outflank-mailman (input) for mailman id 1381075; Mon, 03 Aug 2026 03:09:06 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqj34-0005R7-Fq for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 03:09:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqj33-00D8Rb-PG for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:09:05 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a700643-5cb7-0a2a0a5109dd-0a2a4502d598-10 for ; Mon, 03 Aug 2026 05:09:05 +0200 Received: from [202.12.124.155] (helo=fhigh-b4-smtp.messagingengine.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70064c-6ca4-0a2a45020019-ca0c7c9bcf03-3 for ; Mon, 03 Aug 2026 05:09:01 +0200 Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfhigh.stl.internal (Postfix) with ESMTP id E0F677A0019; Sun, 2 Aug 2026 23:08:59 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Sun, 02 Aug 2026 23:09:00 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 2 Aug 2026 23:08:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785726539; x=1785812939; bh=AIC4GBmoae 3FANeCYGGjXR4JXRqPhRLZ84Tvuc7wIyc=; b=qADUq64WMQ6gOVvlQdtk46guUw v0PecpGJCe3nkB3nFGQgFPz+QiJJZM0O7/2s3KoUBKcSto0fveiOROO0EyM42SSv NdgC2ZlGSZ0MSEXSKBBzZ+TDaDZGHfGOqxtD4yH0tM7fuiBRWCS+7t+Tho/GIMFK KZ/5oK/zPKLBWNgRxxAhxt5upwJmEhXzt4CvyrdxtqHkPzIbsow/tDltMZ1uiWan 3Zu96q5dTVh9eZHuT22sl4eeyPIYwbWYiHZz+53mNdtMeGEDi9i4rQiVZcf7eII+ Tb4PwB1pi5jo2CyHDjj5kIttGlp2tdyr6/6bCTkkAlsqeFUOL9meU9I8sNvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785726539; x= 1785812939; bh=AIC4GBmoae3FANeCYGGjXR4JXRqPhRLZ84Tvuc7wIyc=; b=N TXgAljfpkzLzcsvsNA4Lu6G31VOi9xdy7uz7UHl0uGl1ZBbeDBgdb5GbkfCnWjou rPfvxp/sLYtQSTCETk8p7euz9EcdDpiQxoDRrX7uKPXXtIutQL8PlTN9ECy54VuU /pkuLs2sguLFYI67yXxXd025Ob4/sV3JpDjGiNazl7soJspz7pEQxxxnmKOAnf1T 3ivRZ/I6swvGlWhaw+R4E5zxOTpWII9LXjYzl8oXWGOOUa3z7CLCJXNeEGE+bwHz iJ6RTc7WXwlUe5Jd81sh3rTIF1UWZyxIUQ4mFp0eTFsv03DrTBn3Old80FS+k9n9 hpXakhMKTVTX8RCDfca5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEwpDv/j60enwUL1UJovK5tXTOpuP+SK+CoSIq7LCkDblI6JGegUQoofHbAEAnGvT 2WgLVckyPV5XFdyrVGVi3zRzttftvmTIpNXgwaCsmZQyy1Wq7AB80KuvWdz3HtjWBznKRO YqTXcyPTyrHDVVGYGYghLb9BlPINpgvfXxzBZdPROfUvA73iNoabD243iDQ2cJWJDYfwKf cs0XhU98QyiD/M/DY4Hz5Qiy7lZbhW3z8Ghs5pp3buJQxpFWdXvrT6ihLuxgnW4MXHWeZp Iwb8mvIC+LpEp990itYR+WCOpa25DzleigSNBpi7g4oWNLjklt/yhTSI+TyFh5I71gvcmk cp1Er+LY2bnKbm+qs7+wYqoMRneVGehuZ98opHpijgTvP+pCAhSw/EQF+QQSQP1wUS7Yt/ iS6nS5GOwroOq/D9PBp7gj5axk3u0qIp/R9c6nWq0AkStvabjylE6Q7yANzBUxlQyM3vPY Al2c0QpMZ4e5Mj4Sj2QhFM0wJy5NMEbhuf9i648MpFv5nsGOwG6f76VZMH0ICRW4m7i+Ve h86JsDfdI3eEpvK959vJWqNOs1IDPfhx8Pd1kpDJmGaQQo/JEvNKk3ZPEg1ht48yqGaHxu DIKXsY1ZVX0h6V80SBOGxYXyGmNIzK5VI28oKxLJ1R9+ZW6oApulf1tyCH8w X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jakub Kicinski , Bjorn Helgaas , Jason Andryuk , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) Subject: [PATCH 2/2] xen/xenbus: check otherend_id only after it has been initialized Date: Mon, 3 Aug 2026 05:08:02 +0200 Message-ID: <20260803030822.4104093-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> References: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1785726541-30DC12AC-AA6F7039/0/0 X-purgate-type: clean X-purgate-size: 1641 When device just got initialized (for example on module load), the otherend_id field is initialized only after xenbus_read_otherend_details() gets called. If xenstore watch triggers xenbus_dev_changed() before that, it might consider still zeroed otherend_id field (not matching actual xenstore content) as a sign of device state reset. It can happen because xenstore watch are handled in another thread (xenwatch), which can run in parallel to the initial device probe running at module load. In that case, it would call device_unregister(), which would deadlock against device probe from module init. Fix this by considering dev->otherend_id change only after dev->otherend is set (which happen after otherend_id is initialized). Fixes: e2dcf9065536 "xen/xenbus: better handle backend crash" Signed-off-by: Marek Marczykowski-Górecki --- drivers/xen/xenbus/xenbus_probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index a259c8f0fff4..b42d8d2e5a33 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -680,7 +680,8 @@ void xenbus_dev_changed(const char *node, struct xen_bus_type *bus) dev->otherend_id); if (state == XenbusStateInitialising && - (state != dev->state || backend != dev->otherend_id)) { + (state != dev->state || + (dev->otherend && backend != dev->otherend_id))) { /* * State has been reset, assume the old one vanished * and new one needs to be probed. -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 03:09:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 03:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381074.1624637 (Exim 4.92) (envelope-from ) id 1wqj2y-0005EM-Nd; Mon, 03 Aug 2026 03:09:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381074.1624637; Mon, 03 Aug 2026 03:09:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqj2y-0005EB-JT; Mon, 03 Aug 2026 03:09:00 +0000 Received: by outflank-mailman (input) for mailman id 1381074; Mon, 03 Aug 2026 03:09:00 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqj2x-0005E5-Tm for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 03:09:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqj2w-00D8Rb-V0 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:08:59 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a700618-5cb7-0a2a0a5109dd-0a2a450181ca-24 for ; Mon, 03 Aug 2026 05:08:58 +0200 Received: from [202.12.124.155] (helo=fhigh-b4-smtp.messagingengine.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a700649-5984-0a2a45010019-ca0c7c9baba9-3 for ; Mon, 03 Aug 2026 05:08:58 +0200 Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfhigh.stl.internal (Postfix) with ESMTP id DC1E47A0069; Sun, 2 Aug 2026 23:08:56 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Sun, 02 Aug 2026 23:08:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 2 Aug 2026 23:08:54 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:Message-ID:MIME-Version:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm2; t=1785726536; x=1785812936; bh=8Y5zAgxEseAiRyIU5rtwLgzJrStxXeP9 ashJGawv7H0=; b=cwrN4W3qSRGAz02qkHf106xji4HXsY+mJ11SnCpqTkQr9Jy2 ia+Uzp1M76hvgJc6tQq6lGcEbuMJ7/tmPh+/tZ6PTfkjTSfcFM6jGXjVozR19Spb fNVM86f2Yuk9LCwaSEllQybZBuVVlPePBbedmzbFTt6Mlne8zbrN9610ya2gTa8W UvMBWG7+B1bBAiE38/VkfN/DDKPw/bWwQ3M4DGBxZWdA7w/0b7V95FFKirwm+A+a uYpfvdMrnRF2xJ9Kdkk5xwBhjdCToAxWQ40PWNxj8wtu2PuhHvRo8ccytUVrkoJ/ X3GvI3lsHiPTJkFD5RLDTm2YJevJQMb3HotH3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1785726536; x=1785812936; bh=8Y5zAgxEseAiRyIU5rtwLgzJrStx XeP9ashJGawv7H0=; b=W+x+6oHjtmnxSqC6fy0cGeFuYANhlnZvW4gGOwhZE8xW yeWr/IhWZhrktMTJnvWUTue0ATJ/Olg5qsAhklfnSQW8ow985bisgXHPgnMFIaJr +KTlrFQUg5TBxIszm93t5bcAceg+GZBFG/nPYs05gOpZH0rtO69Ah93l1eqBNJuz e+xYR+fIxn3JLba1nO4RGRagDC69hHCxzBUaYrlZhFBdMTBmnqGPo6Jtegb37rEW sxU4ZH4a03qqvS0kXIial2kLxk9xVJ/SlG9f9mO4x6HCykfDz+rTFDW3JXWoHTYt mEqJnfnae6rPCLPSgB/CVf5fcAGFRLGaXsQw5iKBCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEFiahVVmp40OOwjwusbdef2xUVvLhYW9x1MdKYU/g1FneGLwTqoe+iWVZNousYSB QeW1rFANIP0uiYR5no31tqR+Qrhe4OBqGcoAmgZ6bpVK02LmGHYiUJhTlNsGgb+7HvGr8F 9x7ntapEphoghzsjaBvY++MRaQ60rOQ+pX/demLbBt8Jh20rMqojqse1WPeutn/PMC2DNb LfennEkKTRolsDMx6QQd1tZr1pa1L6r31pPNHg3GQnpnn467R5VE1qNrmjSWrQpCw0JtdZ 0QjxpcHGItqsJLJcVsZUWVGtIZG1elGeW1G3m8pnXGp2Y2PDALndgoplbX6JkvQd6/OBrR V0yjyiSbeM1Y1vrrCe3mSZM3p82eNt9ZU321CKJCvqAbdKuEmbylSzNU7oDFnoaQU+sTfb VpMNI+LfvklywtexxgVCqcV/NzYfmoAoq0eSAoulg3ozQvrZBsKfZirHQYorJovRz11n+2 o7cPh9iSJWWAkYdAGrYVtr006wgH7qAYnoKvEyhDv8GXd7ZR6rVIBuKZQEdMahTyh/0EwF 5nrZst20hm9LrQ2gcBclrFV3jrbzs+37VHgaioNDXxUa7nhO+xtM1FtGj33CVcqhheiMOE /bpoUFaB+B0WeQphy100c2jtdZntrMUXjeit500SdSTjLbYGak0TIuJGmttA X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jason Andryuk , "Martin K. Petersen" , Jakub Kicinski , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) Subject: [PATCH 1/2] xen/xenbus: log more information when device state got reset Date: Mon, 3 Aug 2026 05:08:01 +0200 Message-ID: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1785726538-C5341757-6C0E60A0/0/0 X-purgate-type: clean X-purgate-size: 887 Ease diagnosing what actually changed. Signed-off-by: Marek Marczykowski-Górecki --- drivers/xen/xenbus/xenbus_probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index eb260eceb4d2..a259c8f0fff4 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -686,7 +686,8 @@ void xenbus_dev_changed(const char *node, struct xen_bus_type *bus) * and new one needs to be probed. */ dev_warn(&dev->dev, - "state reset occurred, reconnecting\n"); + "state reset occurred (xenstore state %u, local state %u, xenstore backend %u, local backend %u), reconnecting\n", + state, dev->state, backend, dev->otherend_id); dev->vanished = true; } if (dev->vanished) { -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:07:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381102.1624673 (Exim 4.92) (envelope-from ) id 1wqktT-0002mf-GK; Mon, 03 Aug 2026 05:07:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381102.1624673; Mon, 03 Aug 2026 05:07:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktT-0002mY-Cq; Mon, 03 Aug 2026 05:07:19 +0000 Received: by outflank-mailman (input) for mailman id 1381102; Mon, 03 Aug 2026 05:07:18 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktS-0002lj-F3 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:07:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqktR-006WBT-S7 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:07:17 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a702204-e002-0a2a0a5209dd-0a2a4509bd80-8 for ; Mon, 03 Aug 2026 07:07:17 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a702205-be1a-0a2a45090019-d1558031f053-3 for ; Mon, 03 Aug 2026 07:07:17 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so17071495e9.2 for ; Sun, 02 Aug 2026 22:07:17 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733637; x=1786338437; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kwX99bHKclxWTYHmK+vhBg0zTegHyj1b3u5g7DqxgOA=; b=LrHtOCDS+2rHTuc7JUfMY4RT1XOTojHFP/DhHx0KMvxPPdZmBC76FNYOGKU5Y0KRIT 7Ah6KBAqy3j9I/9QtNE6n3T+BYXUMISDF2OEcscLEetdbqSsas3y5O8+//MYUYzxTl1c MbfqZB0PSvEyNlhxuO9AWufa5SuNnWJ7bgSK/hWojq/6aJJTC9X1YQa8UNXXmq3Nczz9 KhXJ9BjYHi8Cy4+D1GUalz/zJyB2yn6YqoD/3m9ONfgMOgxHQiw5mvNFaGS1nW7ZJKDe F2QNsPRE/bCcM2RgNEerocFDvkZVyX5/ilI1C89ojVrLebK78cHJ2sf+ZoBXOZP4e0Wl s4eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733637; x=1786338437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kwX99bHKclxWTYHmK+vhBg0zTegHyj1b3u5g7DqxgOA=; b=JnvgHv9TRh9pXg/DK6oJU2eRMa4bAs3kavudTCKrZ/OPsPRsO+xUNW+vt4YvfIZhdN 0MnFunzUFKj0gvhfqFfARMJ9aSCJloLHh7A1UhmjbjIHVMSASlTe98c8g4qXYRjd5qTy 84IVe6dFowLXhDu0fNgzNUgscvjaKx7/2HJYyxb4Gp4euM3eiXOaCAkYq13E7jVsZCoT OvsqwsPg3ndy5m/bopXE8VynJYE5E/g4zZfv9YzPiJVDIDZh6U2EDWkQZKkhpCy4ari+ a3ZQ+xpy8r4YvSdQwxGxNZr3KSSjQeArunWC4iNF/Sp/zV+cykCTXS9Uih4/ESA2+Z/Z Y6Dg== X-Gm-Message-State: AOJu0Yy3Ac26CAHGq3zr8sJbyM2D1zJd8X0jyGHpYcEaw0Om/SYT3/pj 34dG5Qu6PSU2nROdGE/oXyn/a02GBvtMnLWB6Sx0AD35C7EsS7wjqOrNTUr3uQ== X-Gm-Gg: AR+sD11x6ITQ8aCGR2NQmLtepzSY+/ZON2Y3igv/AsIXGI110mszaIKKib2lUpWv+ym yUfhZpS5fzlIwNs+cjWc/ohJ7Kr3wS6zbFkrsp2QcW3CLXsw5cLE7mN7BH5FcPB7g8mFRl4BjSA WVMLLQxTn3S8yFNJBN1NYnSjDUVVNzq1xA3oajykug4+gASORNnnygJ/j6ANnNqCRtg5MQR78QQ P7F4nagNWytlq0zSCigG7XwyRl4WWJububb3lcU54fwL7brlKEW/95QRMifsJwhsSA4D+Q2cqDu IJCx2R92GUpkZRKMnrmeijCGYi/HsfnJ1VnI9hQ4UDU2gjf1/Y5BFuBD4COWsccDfqb8wn1lxOC Z5u522tToFeKMiN7bOdQhg7hq4AqpMIzbZ4840Dcl4f5ueGwUEn7dnPT8mvvV4XXi0InJf4VVEp LnmQNMFLRRNBgZT3+53jrGrtGt7xnngb8a/CSzfOKIQwUiq5InNp1sE/P4bDhTEQ== X-Received: by 2002:a05:600c:8b33:b0:495:779a:ed33 with SMTP id 5b1f17b1804b1-4980c66c798mr200299205e9.7.1785733637288; Sun, 02 Aug 2026 22:07:17 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 2/7] xen/sched: credit: migrate to new sched_ops Date: Mon, 3 Aug 2026 08:06:09 +0300 Message-Id: <20260803050614.5222-3-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> References: <20260803050614.5222-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785733637-FCA16034-6DD59F6E/0/0 X-purgate-type: clean X-purgate-size: 1237 Declare sched_credit_def as a struct sched_ops instead of a struct scheduler, dropping the .sched_data field, and register it with REGISTER_SCHED_OPS() so it is found through sched_ops_array[] instead of schedulers[]. This moves the credit scheduler onto the new sched_ops registration path. Signed-off-by: Furkan Caliskan --- xen/common/sched/credit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 328c802d0c..d8c949af11 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -2273,11 +2273,10 @@ csched_deinit(struct scheduler *ops) } } -static const struct scheduler sched_credit_def = { +static const struct sched_ops sched_credit_def = { .name = "SMP Credit Scheduler", .opt_name = "credit", .sched_id = XEN_SCHEDULER_CREDIT, - .sched_data = NULL, .global_init = csched_global_init, @@ -2312,4 +2311,4 @@ static const struct scheduler sched_credit_def = { .move_timers = csched_move_timers, }; -REGISTER_SCHEDULER(sched_credit_def); +REGISTER_SCHED_OPS(sched_credit_def); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:07:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381101.1624663 (Exim 4.92) (envelope-from ) id 1wqktP-0002Wc-4c; Mon, 03 Aug 2026 05:07:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381101.1624663; Mon, 03 Aug 2026 05:07:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktP-0002WV-1X; Mon, 03 Aug 2026 05:07:15 +0000 Received: by outflank-mailman (input) for mailman id 1381101; Mon, 03 Aug 2026 05:07:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktN-0002WF-9G for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:07:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqktM-006W6b-MN for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:07:12 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7021f8-e002-0a2a0a5209dd-0a2a450bce68-26 for ; Mon, 03 Aug 2026 07:07:12 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a702200-b7e8-0a2a450b0019-d1558030e5e9-3 for ; Mon, 03 Aug 2026 07:07:12 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4957eefd361so10928575e9.1 for ; Sun, 02 Aug 2026 22:07:12 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733632; x=1786338432; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CvaIgsy1tiLeOz4+v4UxZSpgWz1oDHV9WwaN0mMyibY=; b=cc22UMfISvV5CaIzWCq7K3UvrVbWjWfqhCwBmSL2Vg+vj74LKVQiWgm4WJpaulmkPG 7Z80AZuFhud6WEyVe7rEBIGSD50YavcpACKE4XHzr7tEcNGjcit8stY9Y2tLJ+CUXNuY PUGYUBGsUvCblQNxIz4Midvrig5vc0Uq9CpRACVbQhFgdnKhdp2abdMAKc6zo9y/apH4 MYn2QP2WHzk4+wJEoyvRXQxmIJY85GPpUabJ5o/Tv8iw/Syc//+GiSQk8mxFSlYKRdKg BZNbzqWpYscQjoLKFjikO62uRHGSY2H1uJ0a/VmN1AqY3voZG+hO+2WLYTWz3xAGaWqi fjWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733632; x=1786338432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CvaIgsy1tiLeOz4+v4UxZSpgWz1oDHV9WwaN0mMyibY=; b=IDOmF5USp6N6m1dqs3//GUxOv7HIDxyNEm8/+QDuBwciyop6eexd85Rs4/aCUUsAEB fIMZG3QVImAtVYVB+05j/PV4TAWyog6i4R3Iy/l97gxDqvjWZxLTUN1NGqvcdyJw2eAE ZgGtQ74wQpbK/uroyFeAwGrVPhmvc/bwTLgM/QPsC/6UnD0j9hjXY11dbe2aGlRVb3Ox /pR3xITQYOZCUAGIhT61WJzdWNwRKNj+KDoj9afjom1w6Sdz49TLA+kZ8X8W4WuuL2CD dn9VIECZeWPB5GWrATXB6QLK1NmLaAdgOWK+H6WNM2NLiAG5J0ejK3n2X6CkCU/SIE14 t6EA== X-Gm-Message-State: AOJu0Yyk44rjQLsRn4poS2hlDRy7R+Csaoso/WVjCg3fSF5gFcW3Sl9C MLDOjmz39knM23YcxVe9ab4BVVKcLG0kvWJEuobQVZqAm2J86S2/CPqBueJysj5I X-Gm-Gg: AR+sD126IXl6KTmLV6TU60bo2mUI9gSxXLRM366vlfbSOITgvpCx3X3//wdBiSh7jq7 E3i1i88vBtuI9gFHmoYfAmT9A3r5fPmSuzsx7EEU2Rv8MNnFBt6ffca2lwhoh443Fi50L9C9o2W ucIBfbHIc/6vlbzvD3AG+5581A6C9k290ve3f9/vRVP3rNJEq6L1hcr6d28QVZRZ1nWnFFJjAFj JzDEDZ9kzCp6Pd52rkNKmZP8tZd7p4DNWMzr2mw2Lusk0xhwVutnQDfX9dso3umHXmqIhgmLiHJ 3pJ/CaW++gvf+wHpmRbt4GDXkoW6cYzqVD5KxeQHetNs1z7vCq+dZHwerf9e9X3JdpZyCg3kA/t IrEDoKXsOzdEL5mXR0A5Xc74AUdCcQjg8JL0f/FWy7xdo7HsEYcwnPTfrFMW7wNPozQ/UX0jNxU 44Y/BAnlZU3Io3ib+9jVNQHaoJsK0BKZiRUOLwPtv7CpxGRSHz/t93NhbeW9Fs4g== X-Received: by 2002:a05:600c:8489:b0:495:495b:9248 with SMTP id 5b1f17b1804b1-4980c64b73emr200743855e9.4.1785733631883; Sun, 02 Aug 2026 22:07:11 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 1/7] xen/sched: introduce struct sched_ops as a shared scheduler vtable Date: Mon, 3 Aug 2026 08:06:08 +0300 Message-Id: <20260803050614.5222-2-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> References: <20260803050614.5222-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785733632-1A2C49EA-B54E27DF/0/0 X-purgate-type: clean X-purgate-size: 14848 struct scheduler currently serves two purposes: it is the static vtable a scheduler backend defines (name, opt_name, sched_id, and all its function pointers), and it is also the per-cpupool runtime object scheduler_alloc() allocates. Being the same type forces scheduler_alloc() to memcpy() the whole vtable into a fresh allocation per cpupool, duplicating identical function pointers across every cpupool using the same scheduler. Introduce struct sched_ops to hold just the compile-time-constant identity and dispatch table, with no per-cpupool state, plus REGISTER_SCHED_OPS() and a sched_ops_array[] alongside the existing schedulers[]. scheduler_alloc(), sched_get_by_name(), and scheduler_init() are extended to also search sched_ops_array[], using a new sched_ops_to_scheduler() helper to build an identical flat struct scheduler regardless of which array a match came from. struct scheduler itself is left untouched for now and still duplicates every field sched_ops holds - this commit only lays the groundwork. Once every backend registers through sched_ops, struct scheduler will be shrunk to its genuinely per-cpupool fields (a pointer to a shared sched_ops instance, plus instance data), and the flattening copy, schedulers[], and REGISTER_SCHEDULER() will be removed. That is what actually removes the duplication; this commit does not yet change any behavior, since sched_ops_array[] is still empty. Signed-off-by: Furkan Caliskan --- xen/arch/arm/xen.lds.S | 1 + xen/arch/ppc/xen.lds.S | 1 + xen/arch/riscv/xen.lds.S | 1 + xen/arch/x86/xen.lds.S | 1 + xen/common/sched/core.c | 118 +++++++++++++++++++++++++++++++++++-- xen/common/sched/private.h | 73 +++++++++++++++++++++++ xen/include/xen/xen.lds.h | 6 ++ 7 files changed, 196 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 2d5f1c516d..9a63fa36a0 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -94,6 +94,7 @@ SECTIONS *(.data.page_aligned) SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM *(.data .data.*) diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S index d0f2ed43f1..da8f73d85b 100644 --- a/xen/arch/ppc/xen.lds.S +++ b/xen/arch/ppc/xen.lds.S @@ -85,6 +85,7 @@ SECTIONS *(.data.page_aligned) SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM *(.data .data.*) diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 65f136dce9..01f202e504 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -90,6 +90,7 @@ SECTIONS *(.data.page_aligned) SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM *(.data .data.*) diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index b9e888e596..d128a30440 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -307,6 +307,7 @@ SECTIONS *(.data.read_mostly) SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM } PHDR(text) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 3609721426..fb2d1d5314 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -91,6 +91,10 @@ extern const struct scheduler *__start_schedulers_array[], *__end_schedulers_arr #define NUM_SCHEDULERS (__end_schedulers_array - __start_schedulers_array) #define schedulers __start_schedulers_array +extern const struct sched_ops *__start_sched_ops_array[], *__end_sched_ops_array[]; +#define NUM_SCHED_OPS (__end_sched_ops_array - __start_sched_ops_array) +#define sched_ops_array __start_sched_ops_array + static struct scheduler __read_mostly operations; static bool scheduler_active; @@ -98,6 +102,43 @@ static bool scheduler_active; static void sched_set_affinity( struct sched_unit *unit, const cpumask_t *hard, const cpumask_t *soft); + +static void sched_ops_to_scheduler( + struct scheduler *sched, const struct sched_ops *ops) +{ + sched->name = ops->name; + sched->opt_name = ops->opt_name; + sched->sched_id = ops->sched_id; + sched->global_init = ops->global_init; + sched->init = ops->init; + sched->deinit = ops->deinit; + sched->free_udata = ops->free_udata; + sched->alloc_udata = ops->alloc_udata; + sched->free_pdata = ops->free_pdata; + sched->alloc_pdata = ops->alloc_pdata; + sched->deinit_pdata = ops->deinit_pdata; + sched->alloc_domdata = ops->alloc_domdata; + sched->free_domdata = ops->free_domdata; + sched->switch_sched = ops->switch_sched; + sched->insert_unit = ops->insert_unit; + sched->remove_unit = ops->remove_unit; + sched->sleep = ops->sleep; + sched->wake = ops->wake; + sched->yield = ops->yield; + sched->context_saved = ops->context_saved; + sched->do_schedule = ops->do_schedule; + sched->pick_resource = ops->pick_resource; + sched->migrate = ops->migrate; + sched->adjust = ops->adjust; + sched->adjust_affinity = ops->adjust_affinity; +#ifdef CONFIG_SYSCTL + sched->adjust_global = ops->adjust_global; +#endif + sched->dump_settings = ops->dump_settings; + sched->dump_cpu_state = ops->dump_cpu_state; + sched->move_timers = ops->move_timers; +} + static struct sched_resource *cf_check sched_idle_res_pick(const struct scheduler *ops, const struct sched_unit *unit) { @@ -3004,11 +3045,27 @@ const struct scheduler *__init sched_get_by_name(const char *sched_name) return NULL; } +static inline +const struct sched_ops *__init sched_ops_get_by_name(const char* sched_name) +{ + unsigned int i; + for ( i = 0; i < NUM_SCHED_OPS; i++) + if ( sched_ops_array[i] && !strcmp(sched_ops_array[i]->opt_name, sched_name) ) + return sched_ops_array[i]; + + return NULL; +} + int __init sched_get_id_by_name(const char *sched_name) { const struct scheduler *scheduler = sched_get_by_name(sched_name); + const struct sched_ops *ops; + + if ( scheduler ) + return scheduler->sched_id; - return scheduler ? scheduler->sched_id : -1; + ops = sched_ops_get_by_name(sched_name); + return ops ? ops->sched_id : -1; } /* Initialise the data structures. */ @@ -3016,6 +3073,7 @@ void __init scheduler_init(void) { struct domain *idle_domain; const struct scheduler *scheduler; + const struct sched_ops *ops; int i; scheduler_enable(); @@ -3048,15 +3106,52 @@ void __init scheduler_init(void) } } + for ( i = 0; i < NUM_SCHED_OPS; i++) + { +#define sched_test_func(f) \ + if ( !sched_ops_array[i]->f ) \ + { \ + printk("scheduler %s misses .%s, dropped\n", \ + sched_ops_array[i]->opt_name, #f); \ + sched_ops_array[i] = NULL; \ + } + + sched_test_func(init); + sched_test_func(deinit); + sched_test_func(pick_resource); + sched_test_func(alloc_udata); + sched_test_func(free_udata); + sched_test_func(switch_sched); + sched_test_func(do_schedule); + +#undef sched_test_func + + if ( sched_ops_array[i]->global_init && sched_ops_array[i]->global_init() < 0) + { + printk("scheduler %s failed initialization, dropped\n", + sched_ops_array[i]->opt_name); + sched_ops_array[i] = NULL; + } + } + scheduler = sched_get_by_name(opt_sched); - if ( !scheduler ) + ops = scheduler ? NULL : sched_ops_get_by_name(opt_sched); + if ( !scheduler && !ops ) { printk("Could not find scheduler: %s\n", opt_sched); scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT); - BUG_ON(!scheduler); - printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name); + ops = scheduler ? NULL : sched_ops_get_by_name(CONFIG_SCHED_DEFAULT); + BUG_ON(!scheduler && !ops); + if ( scheduler ) + printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name); + else + printk("Using '%s' (%s)\n", ops->name, ops->opt_name); } - operations = *scheduler; + + if ( scheduler ) + operations = *scheduler; + else + sched_ops_to_scheduler(&operations, ops); if ( cpu_schedule_up(0) ) BUG(); @@ -3415,12 +3510,25 @@ struct scheduler *scheduler_alloc(unsigned int sched_id) for ( i = 0; i < NUM_SCHEDULERS; i++ ) if ( schedulers[i] && schedulers[i]->sched_id == sched_id ) goto found; + + for ( i = 0; i < NUM_SCHED_OPS; i++ ) + if ( sched_ops_array[i] && sched_ops_array[i]->sched_id == sched_id ) + goto found_new; + return ERR_PTR(-ENOENT); found: if ( (sched = xmalloc(struct scheduler)) == NULL ) return ERR_PTR(-ENOMEM); memcpy(sched, schedulers[i], sizeof(*sched)); + goto init; + + found_new: + if ( (sched = xzalloc(struct scheduler)) == NULL ) + return ERR_PTR(-ENOMEM); + sched_ops_to_scheduler(sched, sched_ops_array[i]); + + init: if ( (ret = sched_init(sched)) != 0 ) { xfree(sched); diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index d6884550cd..4dd5c99b87 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -294,6 +294,76 @@ static inline spinlock_t *pcpu_schedule_trylock(unsigned int cpu) return NULL; } +struct sched_ops { + const char *name; /* full name for this sched_ops */ + const char *opt_name; /* option name for this sched_ops */ + unsigned int sched_id; /* ID for this sched_ops */ + + int (*global_init) (void); + + int (*init) (struct scheduler *ops); + void (*deinit) (struct scheduler *ops); + + void (*free_udata) (const struct scheduler *ops, void *priv); + void * (*alloc_udata) (const struct scheduler *ops, + struct sched_unit *unit, void *dd); + + void (*free_pdata) (const struct scheduler *ops, + void *pcpu, int cpu); + void * (*alloc_pdata) (const struct scheduler *ops, int cpu); + void (*deinit_pdata) (const struct scheduler *ops, + void *pcpu, int cpu); + + /* Returns ERR_PTR(-err) for error, NULL for 'nothing needed'. */ + void * (*alloc_domdata) (const struct scheduler *ops, + struct domain *dom); + /* Idempotent. */ + void (*free_domdata) (const struct scheduler *ops, void *data); + + spinlock_t * (*switch_sched) (struct scheduler *new_ops, unsigned int cpu, + void *pdata, void *vdata); + + /* Activate / deactivate units in a cpu pool */ + void (*insert_unit) (const struct scheduler *ops, + struct sched_unit *unit); + void (*remove_unit) (const struct scheduler *ops, + struct sched_unit *unit); + + void (*sleep) (const struct scheduler *ops, + struct sched_unit *unit); + void (*wake) (const struct scheduler *ops, + struct sched_unit *unit); + void (*yield) (const struct scheduler *ops, + struct sched_unit *unit); + void (*context_saved) (const struct scheduler *ops, + struct sched_unit *unit); + + void (*do_schedule) (const struct scheduler *ops, + struct sched_unit *currunit, s_time_t now, + bool tasklet_work_scheduled); + + struct sched_resource *(*pick_resource)(const struct scheduler *ops, + const struct sched_unit *unit); + void (*migrate) (const struct scheduler *ops, + struct sched_unit *unit, + unsigned int new_cpu); + int (*adjust) (const struct scheduler *ops, + struct domain *d, + struct xen_domctl_scheduler_op *op); + void (*adjust_affinity)(const struct scheduler *ops, + struct sched_unit *unit, + const struct cpumask *hard, + const struct cpumask *soft); +#ifdef CONFIG_SYSCTL + int (*adjust_global) (const struct scheduler *ops, + struct xen_sysctl_scheduler_op *sc); +#endif + void (*dump_settings) (const struct scheduler *ops); + void (*dump_cpu_state) (const struct scheduler *ops, int cpu); + void (*move_timers) (const struct scheduler *ops, + struct sched_resource *sr); +}; + struct scheduler { const char *name; /* full name for this scheduler */ const char *opt_name; /* option name for this scheduler */ @@ -546,6 +616,9 @@ static inline void sched_unit_unpause(const struct sched_unit *unit) #define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \ __used_section(".data.schedulers") = &(x) +#define REGISTER_SCHED_OPS(x) static const struct sched_ops *x##_entry \ + __used_section(".data.sched_ops") = &(x) + struct cpupool { unsigned int cpupool_id; diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h index ea11e3fb62..157d48eabd 100644 --- a/xen/include/xen/xen.lds.h +++ b/xen/include/xen/xen.lds.h @@ -179,6 +179,12 @@ *(.data.schedulers) \ __end_schedulers_array = .; +#define SCHED_OPS_ARRAY \ + . = ALIGN(POINTER_ALIGN); \ + __start_sched_ops_array = .; \ + *(.data.sched_ops) \ + __end_sched_ops_array = .; + #ifdef CONFIG_HYPFS #define HYPFS_PARAM \ . = ALIGN(POINTER_ALIGN); \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:07:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381100.1624655 (Exim 4.92) (envelope-from ) id 1wqktK-0002Jr-Ue; Mon, 03 Aug 2026 05:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381100.1624655; Mon, 03 Aug 2026 05:07:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktK-0002Jk-RP; Mon, 03 Aug 2026 05:07:10 +0000 Received: by outflank-mailman (input) for mailman id 1381100; Mon, 03 Aug 2026 05:07:09 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktJ-0002Je-0J for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:07:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqktI-006W4Q-9B for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:07:08 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7021f1-2eae-0a2a0a5409dd-0a2a450aec7a-16 for ; Mon, 03 Aug 2026 07:07:08 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7021f7-f2d2-0a2a450a0019-d1558034a963-3 for ; Mon, 03 Aug 2026 07:07:03 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4954a9e8490so12548335e9.1 for ; Sun, 02 Aug 2026 22:07:03 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733623; x=1786338423; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=s6Me0Ii/wXFwxSrXThVMvIBe3ZtEiu+nF8ISBnVnumA=; b=TvvRn6N8Uu/7wT3XircOrT7N5ZR/TOSYrtP4rmx0A6Dh3t3WDZsna9qkRSD3yh/Pll ySrCaSjpvOryge5UBNmTF2bqQ722VduUeh+K0fJ5G18/yJMsK3q/ANW2MfagOWQAQqM7 e6q6nJCoh7BxLlV/+4DXm8aziTg3hLOsmcV2crz5AgJFGNHEha4OB/xYOFR8B3lAYQbz 4DkMtOT4OGXMo8+TZybU9Hwqq/iVkPIGW2KRGneaL1O2cMTmKoifX8tQZocp0IiB92O0 QZD/JbwISVJ11HqMPo1zOxXW+3+Fm5SDanQPvoTMkpXNa9p2ZchiGU5bmjZQyojVREQG vHfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733623; x=1786338423; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s6Me0Ii/wXFwxSrXThVMvIBe3ZtEiu+nF8ISBnVnumA=; b=FJsLRt0JWpcdGoluDVGZ+t8koiXVjZ1JdyFX0IZsvlgPwU82YHG6XtdXft0+nr/TsK wJCmNWbzPrhU/nkHOOlW2C/HabZo9oj4P4DFD/ESnRlDhJkT0UX6qXrbm5DIOTIvsgGu umxKKoOnJVXN/WSRokqNHGFKCrpfMRXJgF2dvMOib+fbY1hJwjM6ESncEUZ20kYgEt66 iSRFZE5/XcL8LApw8tf5eqVLupEFYWVHuMIM7tTcCo193LI4hgSc+DrAln0WbRhXoOSS 3H4X4k02G3Mp3+SLeN2/nu+XlJSLCm2YZaJfZSuZCQbTOsJzIQhZst3N0V5aIedqUAk7 hvtA== X-Gm-Message-State: AOJu0YyKK236k3ImJEdOyfvnL4GTtFQrRZLCpcfSt3QWU0dCpHim3xSS No90cRgmzc90/ERYJfdCDvOi1a/Za5v0GyTcCmhT7QhSn19G7qcNfJ/Q09eM0eDa X-Gm-Gg: AR+sD13gATuO4maEAT1wp5B/smYPG4qx5LzQLhVR1y+oXpYrCNn8mgGiVmZubfvnkQS XRKoRGBIsXg7/6hyFEdLt6npa+I0peNKbHg72wk/JS+dxQgUlfvtVpby8lZy70tKVpD5gZxwxy6 Ew8AGtFxKskJkBM05KnEJ5BMl4QNOGzePaNgAT6px9DiYsjrSrIFovftT2qIqh3qO32zG3Z5Z1p sO2zqUvtdrK5bYAPzt4EYZMsk8MdoI//Acociv67C1DfqTXQhBjP37vhOjkzq0vKKxWWjZ+jhAh T4Ap4vs1lTPDBl/ot0ch4kyaw2ITXCFRx8Y/fvf4CmwqcQzanGFVrsvIZd3A6U7YDVd/bol2fK9 l3syFpkvxHb94XWPEeq9147g/TDlZo00Elzh75D/GrjeNpZxtGrH8yEzQMYV2kUJcHP+bfY4jkA O5ZUIrsZOOAGSdE0ry+SMuCoAyuFNd3V1foM2hBWuJKgvmj1eGoC8ROjvwBVcZo8I/vsaJ0Wv1k w== X-Received: by 2002:a05:600c:a42:b0:495:69eb:27d3 with SMTP id 5b1f17b1804b1-4980eba0a6fmr164772565e9.8.1785733623067; Sun, 02 Aug 2026 22:07:03 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 0/7] xen/sched: split scheduler vtable from scheduler Date: Mon, 3 Aug 2026 08:06:07 +0300 Message-Id: <20260803050614.5222-1-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1785733623-591C5CFC-7CDF42AE/0/0 X-purgate-type: clean X-purgate-size: 3004 Each struct scheduler currently doubles as both a scheduler backend's static vtable (name, opt_name, sched_id and every function pointer) and the per-cpupool runtime object that scheduler_alloc() allocates. Because these are the same type, scheduler_alloc() memcpy()s the entire vtable into a fresh heap allocation for every cpupool it creates. With N cpupools running the same scheduler, this duplicates N copies of identical function pointers and identifying fields that never differ between instances - the only fields that are genuinely per-cpupool are sched_data and cpupool. This series splits the vtable out into its own type, struct sched_ops, so it can be shared by every cpupool using a given scheduler instead of copied per cpupool. struct scheduler is left holding only what is actually per-instance: a pointer to the shared sched_ops, plus sched_data and cpupool. The series is structured as introduce/migrate/remove, so that every commit builds and boots on its own: - The first patch adds struct sched_ops, REGISTER_SCHED_OPS(), and a sched_ops_array[] alongside the existing schedulers[], extending every lookup path (scheduler_alloc(), sched_get_by_name(), scheduler_init()) to search both arrays. This is purely additive - no scheduler uses it yet. - The next five patches each migrate one scheduler backend (credit, credit2, rtds, arinc653, null) from struct scheduler to struct sched_ops. Each is small, mechanical, and independently bisectable, with no behavioral difference, since scheduler_alloc() builds an identical runtime struct scheduler regardless of which array a match is found in. - The final patch removes the old schedulers[] and REGISTER_SCHEDULER() path now that nothing uses it, shrinks struct scheduler down to { ops, sched_data, cpupool }, and updates every accessor in private.h accordingly. Furkan Caliskan (7): xen/sched: introduce struct sched_ops as a shared scheduler vtable xen/sched: credit: migrate to new sched_ops xen/sched: credit2: migrate to new sched_ops xen/sched: rtds: migrate to new sched_ops xen/sched: arinc653: migrate to new sched_ops xen/sched: null: migrate to new sched_ops xen/sched: remove old scheduler registration, shrink struct scheduler xen/arch/arm/xen.lds.S | 2 +- xen/arch/ppc/xen.lds.S | 2 +- xen/arch/riscv/xen.lds.S | 2 +- xen/arch/x86/xen.lds.S | 2 +- xen/common/sched/arinc653.c | 11 +--- xen/common/sched/core.c | 80 ++++++++++++++++------------- xen/common/sched/cpupool.c | 6 +-- xen/common/sched/credit.c | 5 +- xen/common/sched/credit2.c | 5 +- xen/common/sched/null.c | 5 +- xen/common/sched/private.h | 100 +++++++++++++++++++----------------- xen/common/sched/rt.c | 5 +- xen/include/xen/xen.lds.h | 8 +-- 13 files changed, 116 insertions(+), 117 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:07:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:07:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381103.1624682 (Exim 4.92) (envelope-from ) id 1wqktY-00034s-NP; Mon, 03 Aug 2026 05:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381103.1624682; Mon, 03 Aug 2026 05:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktY-00034h-Jp; Mon, 03 Aug 2026 05:07:24 +0000 Received: by outflank-mailman (input) for mailman id 1381103; Mon, 03 Aug 2026 05:07:23 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktX-00032f-Bx for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:07:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqktW-006W8q-P2 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:07:22 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7021f1-2eae-0a2a0a5409dd-0a2a450aec7a-34 for ; Mon, 03 Aug 2026 07:07:22 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a702209-f2d2-0a2a450a0019-d1558034b5d3-3 for ; Mon, 03 Aug 2026 07:07:21 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49557167508so14758105e9.1 for ; Sun, 02 Aug 2026 22:07:21 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733641; x=1786338441; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CM+qUXy25CRFKkF1HaPx8PYdTauLZnNcJY3C0JI+/Dc=; b=TCB+1OEl9u/sNipcbKczY61o/1VCQ2cKvMu9vCsZxuZYjSCIC+lbD8uxSbSpA9hMkf C7RQvNNHKu1AeZr7jHTyvZ0GTYURSf5ewWYa40W3s/rvl0zZHrmfpRUpMcfk3T6qIJxS UzX283JLA7W1WpQ5ZGqvrKiFpJJlANnjnM/5bWXahjGJQpFHelDaDU+10i3Q0KtwFmeD XCDCORthkgSwR+UJZGrqJiuhFDGqYr6WCTeMIXZx5xkqbMYfcnIU13FQStaHIIo98LLG YvKwaXeNDJbk+yqv5oKVsQl1MQaA8WCQukDhTDGSgeqQ48uYdsOGE4ZfD2Tgel6ch8Jb pmxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733641; x=1786338441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CM+qUXy25CRFKkF1HaPx8PYdTauLZnNcJY3C0JI+/Dc=; b=Fi5ahYbfUudRk+xY9zKdsQ0TGMN478GrmrMx6lq/NEkpj79j07uuU0Hx7Uy/ne+1DL YH8CKQnaGUwR1P6HUQteaotZn5pP7uhnvkxDSSMfcUA/MjYhQQnEXBzEHHUwA1drh5Fe 4eZu6HG+lcnjVA7vUFZzlOyInGhKs75rFMdoCfsy/lCR1Wtcze9sWgHGEIPhgUm7TxMW Hh7neA1W2sECaUVKct+SqDNW3sWBRzgYiII3FgNjP4gloKKdZcQxMB6zEP6uya2UUHeS 1WdwePmLn9sLwo5URu9didSk6H6msYxZ2HtK2/hGvraFZMRVJOoo6QKBlWm09+B7NTIp fXeQ== X-Gm-Message-State: AOJu0YwYSU7n/hbCFNjkpvnZDMsooeCFb8MlOj5O+1HQUOBjeo3ZY5tU gfNGqZyo8J8NBJOXPGS5rc4EdoUX+NzktkvZiRUtyM8P/t2AQoECaX33pmuz3w== X-Gm-Gg: AR+sD10wWtpzyABgA4Jnl+/5ppJRow5vpdjy958Co3o8wtwM6j0Y6xILBUX+nlN3c7u sLMxRWd4GW9mgjrR+cLFajVryYHbu2yTuMoNYcjEdT98XAJxEg1gaW+/QODyAswv8D/KAxG9sO/ FaasbhF568aBSc/xZnkPykGkJAXhKBalS2G+YCD2qSXDLNdOl/S9CsfgjOl5s7tLRKZt8Q5ZZni M/XdGKgKeTAInx0lMjWXo2Cu6USCUfKxd0yq7Z83oIPzLHlZkwHdHPBV5K4qofDPrHgduTlCsKe uOemx92QnEe1v6hDL1CoWZxSK3o66xnqzDc/031W7CjRn3EgoZoW2lnOCyMvGNiVVV6HyQMLzjp mKUv2HpaBR0kyc7Rx0aWOnDtkdDFCqcrAJJWASRKCoHdirdv+KAwQG2c6PT6d197MKtFe6vTYB6 Nvs+i4JyHCYsANXWexr92N0TsrW1dgYPgPb+xiKeNGbFVuVRyypVkZ4NYqLSqI0mA= X-Received: by 2002:a05:600c:354a:b0:490:b8c0:d470 with SMTP id 5b1f17b1804b1-4980c67d71emr173613755e9.19.1785733640879; Sun, 02 Aug 2026 22:07:20 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 3/7] xen/sched: credit2: migrate to new sched_ops Date: Mon, 3 Aug 2026 08:06:10 +0300 Message-Id: <20260803050614.5222-4-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> References: <20260803050614.5222-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1785733641-518C5CFC-88A0B142/0/0 X-purgate-type: clean X-purgate-size: 1270 Declare sched_credit2_def as a struct sched_ops instead of a struct scheduler, dropping the .sched_data field, and register it with REGISTER_SCHED_OPS() so it is found through sched_ops_array[] instead of schedulers[]. This moves the credit2 scheduler onto the new sched_ops registration path. Signed-off-by: Furkan Caliskan --- xen/common/sched/credit2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 95946634d1..9bcc90004a 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -4230,11 +4230,10 @@ csched2_deinit(struct scheduler *ops) xfree(prv); } -static const struct scheduler sched_credit2_def = { +static const struct sched_ops sched_credit2_def = { .name = "SMP Credit Scheduler rev2", .opt_name = "credit2", .sched_id = XEN_SCHEDULER_CREDIT2, - .sched_data = NULL, .global_init = csched2_global_init, @@ -4269,4 +4268,4 @@ static const struct scheduler sched_credit2_def = { .free_domdata = csched2_free_domdata, }; -REGISTER_SCHEDULER(sched_credit2_def); +REGISTER_SCHED_OPS(sched_credit2_def); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:07:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381105.1624690 (Exim 4.92) (envelope-from ) id 1wqktc-0003Ly-0E; Mon, 03 Aug 2026 05:07:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381105.1624690; Mon, 03 Aug 2026 05:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktb-0003Lr-TR; Mon, 03 Aug 2026 05:07:27 +0000 Received: by outflank-mailman (input) for mailman id 1381105; Mon, 03 Aug 2026 05:07:26 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqkta-0003Jz-Rr for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:07:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqkta-006WBT-8p for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:07:26 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a702204-e002-0a2a0a5209dd-0a2a4509bd80-24 for ; Mon, 03 Aug 2026 07:07:26 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70220e-be1a-0a2a45090019-d1558035bc4b-3 for ; Mon, 03 Aug 2026 07:07:26 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so8338955e9.0 for ; Sun, 02 Aug 2026 22:07:26 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733646; x=1786338446; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=21wuOD8HUjAVDqLCXgTFbv9BZRqUOWoQ8lloGzNNeyI=; b=W23IIMugZihv/E9MpUAS+BTshG2DONDxQU8e4HBIv7F9awZTjnUrciiIjKI3ytTOnN S0SjitHls5jaJ3iGwOoptFw48jeG+IFzMTJ3fNS4utYyMK301Qsdm2L+rTbuPkdpg2He 6mGb6YUZyMQb2vGgetwGTWEY5TK2CD8ql7twP7st9E1DhwQpQlKliJc8v3Dib8W/UXZy tYxstGgejFRbfeMVT7tdP24aTyxh8YC07bohejlLN34exn+XLfl5pRuumumHokirBeTS sOYUeRjQ+nSj+w+R0q2kw7CYY5z9grp1KPBFjl1Z1ivcHNvRx8eMjoJr1ftZY5nB3gB3 40mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733646; x=1786338446; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=21wuOD8HUjAVDqLCXgTFbv9BZRqUOWoQ8lloGzNNeyI=; b=H6oHgdCZgrsk4H6axV3roDcSR8/qykmtAYGjLFZJCVaTntmtSdewUWGR1Sfc0rvV2a 8TNiVMkm1ls9e20kAZ8+emvtuQjD2nlc/26XS9kHkqxMryVOKtDnHgP+gmVCAync6Hg7 2tcUEz2hbpg5rvCuiSX/fITi+iYsHvhhDW6RHZlk8AF9iWvwhoXghntsuj2FLqTdNfrc XlxTJfSxxRO+5co28p4lsdsizPYq2V1Bals+b67D3kl4dtMgo4hYJA+CvfBAtQzsoxIi uHlVAu7krYkeKjmf69ZXBVQIhmcWqnnQ10kAvHFiRO4AyQAlQtNbnxAohgONlktxDgql ns+Q== X-Gm-Message-State: AOJu0YysNBoDhQ6/kWHS+H9elxYcqZs47xGn4j3EJkCn1uODDuo4+5Wk 3hWyPN3BpunpOA1T4y40QXkDAI7gG7wTWIh2k6C+zVDW7fYrs+zDQnX4WCl0fw== X-Gm-Gg: AR+sD13NVLoLS3Axl+d/RuimuCzfkWglb0hAOt/C604Hr9ndJUgY8Tuk0Vr4Lv4KROJ mjqsnV7OrewQxl3O+wofqVpjIn+NcIiVUVsfwWzHtJa/+Rjk41ntLvPrFFt4oybv9nuooi8LyTA V08aIKfwbRnT5hsdbPboAKyOl70PusSAmOSQ5LjAlO2RXnSmgdvGVYy3j0yuqjcj2RtuzX0o/9A WjuPdNZyRLzHmukNf+mGjpagRRLrvBk3ybJ/FtxmHWjdV+NdDF9xm+6+tfIMdFLVaLCbWFSFpOw Cre4nIF/FECs/gDUsT1Y/8IE60Ne6+mwmUTvnlugFZUPyr0kgx0RjgoWADEvko4bOpKh37TAmp9 osE9ITBLFAp6rdaEMIbVd1KiuDUeTLeuXiJl2at4yrSVSxYSt57Xtlx2uXAVBJF4M7bIu2R3TOH 7M9xgBLtauuGnMZxlnTqRDhDdTfLDVRd4JxvUl3jpI/Vfbbh6JIK4HZLN9pew6+w== X-Received: by 2002:a05:600d:8498:20b0:497:fecd:5b00 with SMTP id 5b1f17b1804b1-4980c673230mr145973255e9.9.1785733645587; Sun, 02 Aug 2026 22:07:25 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 4/7] xen/sched: rtds: migrate to new sched_ops Date: Mon, 3 Aug 2026 08:06:11 +0300 Message-Id: <20260803050614.5222-5-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> References: <20260803050614.5222-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785733646-FDC6D034-B5E3BD18/0/0 X-purgate-type: clean X-purgate-size: 1259 Declare sched_rtds_def as a struct sched_ops instead of a struct scheduler, dropping the .sched_data field, and register it with REGISTER_SCHED_OPS() so it is found through sched_ops_array[] instead of schedulers[]. This moves the rtds scheduler onto the new sched_ops registration path. Signed-off-by: Furkan Caliskan --- xen/common/sched/rt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index 744f214173..8b4f05e2d1 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -1617,11 +1617,10 @@ static void cf_check repl_timer_handler(void *data) spin_unlock_irq(&prv->lock); } -static const struct scheduler sched_rtds_def = { +static const struct sched_ops sched_rtds_def = { .name = "SMP RTDS Scheduler", .opt_name = "rtds", .sched_id = XEN_SCHEDULER_RTDS, - .sched_data = NULL, .dump_cpu_state = rt_dump_pcpu, .dump_settings = rt_dump, @@ -1646,4 +1645,4 @@ static const struct scheduler sched_rtds_def = { .move_timers = rt_move_timers, }; -REGISTER_SCHEDULER(sched_rtds_def); +REGISTER_SCHED_OPS(sched_rtds_def); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:07:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:07:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381107.1624700 (Exim 4.92) (envelope-from ) id 1wqktg-0003mE-6J; Mon, 03 Aug 2026 05:07:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381107.1624700; Mon, 03 Aug 2026 05:07:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktg-0003m5-3J; Mon, 03 Aug 2026 05:07:32 +0000 Received: by outflank-mailman (input) for mailman id 1381107; Mon, 03 Aug 2026 05:07:31 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktf-0003fS-4Y for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:07:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqkte-00DMN1-Hk for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:07:30 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a702203-bab6-0a2a0a5309dd-0a2a450b8eae-44 for ; Mon, 03 Aug 2026 07:07:30 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a702212-b7e8-0a2a450b0019-d1558034e9ac-3 for ; Mon, 03 Aug 2026 07:07:30 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4955de8797cso9107745e9.3 for ; Sun, 02 Aug 2026 22:07:30 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733650; x=1786338450; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JMMpBw4vbiYd/isxZEkW0aMhzAaKpMobKqilYthaK3Q=; b=Wp06fp7foYAnABLEJc4NYwHmXkWBaExspDvCGo4STNyI6Tf8//6mewsVoCIMZn9bFm NQHJg/VFr2XVPQdKPrOclQrQIiqp7BixscQAS0eYURiFTv00ZGHrab/r3KJIbmVVlAFg wN5RTLVk6rhyGnvRjjkwZxeF2msgaAwHML3QWOQ+E+NmDVsiWr/a0J0q5maq2EfL0+XL HRdLLinvJPmowhPUt/Ixxu4Jgvqu97BD1RoG8qFDqGWgMh5B4cyO/QjC4mm4/n3KwMvN al5GvX0AnFc+A0xHN2alfvrEdCSz75Lc+ZshthfjmNxX85SEo4mTkHczDmdnbooy9Wr5 9daQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733650; x=1786338450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JMMpBw4vbiYd/isxZEkW0aMhzAaKpMobKqilYthaK3Q=; b=J2DHJ5nJNcsuQ7WPmDVjO3I1+/wi0ee5GmwNpC41pRUuIEmskffz+gMyLbzaL9JyFN /IYwqSrmyeUrOeklk2BYNd06xYaHKqdBwlAS9iSFohF1zSmEfpifXXyBGB1kXx3Fg6SO eiLSPXokXGgontFm8L8GUTwHHek6y+SE3ZYIJVMxhqGDg5lwkboOUYz5YgKkYmir+bNp DWZsoGcHkqDscG0jDjCpHu+56dHfvx4j3H6RP4DbEJUbETBxJaanDicuX6jGAVh4uic+ ymETxyks/hdL3jawjxt7O4fHGVuHZIz5gbVfDHWcah/AmDWceIHe/uVrCvEEghuIuC3+ Mhcw== X-Gm-Message-State: AOJu0Ywftkr+24lSEORak2pvgnutdQOb0UILBO/THiyk6WH3vS93ZYfp 6lLJtNfNOs+45O12X1MGrg1jS+EcLz3zxdUdPMRrsYofUDuyvg6T/5cgJcoQig== X-Gm-Gg: AR+sD10d+tkzIz7FUfNLEyV+NgiNVZ3DgfuFrxUtv8btQDCXyvDWdfJYTUp/+rcffi8 5AnNReXsa7Q4Oq2Bnhfh71np9omhVPoOhnWoNgAOhtvmcNR1/p3UhSAYEn7eG8uE8BXc2Mo/Xt/ sL3Q62cU233aVS1HeU0iej5tDkXYr8eWA5VzCmdQp+MzjXnKxIiL34z7O1LD6DEXoqnU16DyOne IEkkjSpRCbbTVlhPgeW1Blclvm02y0+XuHcyZ90M9iDE3wud4fxjc4zVS6TXPxFvg2BiQ6xUswg Mb4Q0b/tX8fRy44Bgco+7S4dbOhYbiPnOsmvd/VV7TRHUHeCSko8SM4NNyN8mEAZUE/non9FX5S yXD17u+Bs2Pf4zWDcXgUazJe0Xd1TSgKA3GLxqS4VYMzLEqGkv8nd+Sxqxa5NgEK1W+2sNaxTMk w6Og8Th/Si64l7Slvb9XvDJxpdPsDgDn9k9zwrd/zFjKaueUtu8gApLfu76WYhRw== X-Received: by 2002:a05:600c:3488:b0:493:e6f7:ad75 with SMTP id 5b1f17b1804b1-4980c653e15mr179910915e9.11.1785733649963; Sun, 02 Aug 2026 22:07:29 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 5/7] xen/sched: arinc653: migrate to new sched_ops Date: Mon, 3 Aug 2026 08:06:12 +0300 Message-Id: <20260803050614.5222-6-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> References: <20260803050614.5222-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785733650-1B8D19EA-0CF7C641/0/0 X-purgate-type: clean X-purgate-size: 1571 Declare sched_arinc653_def as a struct sched_ops instead of a struct scheduler, dropping the .sched_data field, and register it with REGISTER_SCHED_OPS() so it is found through sched_ops_array[] instead of schedulers[]. This moves the arinc653 scheduler onto the new sched_ops registration path. Signed-off-by: Furkan Caliskan --- xen/common/sched/arinc653.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c index 32c596a23c..efcaa44089 100644 --- a/xen/common/sched/arinc653.c +++ b/xen/common/sched/arinc653.c @@ -702,17 +702,10 @@ a653sched_adjust_global(const struct scheduler *ops, } #endif /* CONFIG_SYSCTL */ -/** - * This structure defines our scheduler for Xen. - * The entries tell Xen where to find our scheduler-specific - * callback functions. - * The symbol must be visible to the rest of Xen at link time. - */ -static const struct scheduler sched_arinc653_def = { +static const struct sched_ops sched_arinc653_def = { .name = "ARINC 653 Scheduler", .opt_name = "arinc653", .sched_id = XEN_SCHEDULER_ARINC653, - .sched_data = NULL, .init = a653sched_init, .deinit = a653sched_deinit, @@ -743,7 +736,7 @@ static const struct scheduler sched_arinc653_def = { .dump_cpu_state = NULL, }; -REGISTER_SCHEDULER(sched_arinc653_def); +REGISTER_SCHED_OPS(sched_arinc653_def); /* * Local variables: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:07:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:07:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381131.1624709 (Exim 4.92) (envelope-from ) id 1wqktu-0005Mh-EJ; Mon, 03 Aug 2026 05:07:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381131.1624709; Mon, 03 Aug 2026 05:07:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqktu-0005Ll-BI; Mon, 03 Aug 2026 05:07:46 +0000 Received: by outflank-mailman (input) for mailman id 1381131; Mon, 03 Aug 2026 05:07:44 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqkts-0005Gb-Lx for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:07:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqkts-003lut-2o for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:07:44 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a702215-2eae-0a2a0a5409dd-0a2a45028d14-18 for ; Mon, 03 Aug 2026 07:07:44 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70221f-6ca4-0a2a45020019-d1558034ccc0-3 for ; Mon, 03 Aug 2026 07:07:43 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4955aa106b1so15227285e9.0 for ; Sun, 02 Aug 2026 22:07:43 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733663; x=1786338463; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Dfo9WveiLxrAqqO79sjLeKOkwe8r7c3VXRClpdMKLaI=; b=WnxsgV08P7pAvLdbzi4gu2aO28A/JQqERE42GrWvurPzt1MRNFhXrWPd179i44dp39 GP/QTO1QU2dMnO6cqsTCl+sbZnm1IW4SmwRkEXLPTDAQffANuDjMNn4DRJR/PsChQPi6 X/ZfRbik6/ahzjhKWw7qkKeLB81KOK6Kh3mV302zJOMB1eK6c8f+ShgwPFt0+A6bqpwz asov8DtioNL4tH6dCN7+O8DuzfpqY89a33Ld6b9m9OgpI4c25F27uO29ygx0ffWAmJGP ib2o6qsSR10zdQ1OzY/bVk8AtTUuWVjLo1pv9j/O21usoLk00JTLVFUTygDrzbgUfl4h dyVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733663; x=1786338463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Dfo9WveiLxrAqqO79sjLeKOkwe8r7c3VXRClpdMKLaI=; b=BHB4UvxOXoezvnogpZjXoeuGBae0dyiMr9j6SjEPBe6dc4rmzm3Crk/JSxR6OWIiBD V560phCi7MujTWFZNdMUYeuSFJx8icu4Uzgws7p/G+nqZNDRNQhuxnnXL3eTP9zEjwl2 sHkugO3B9EWoR0U8QZtctW8W7Aa23AKiJIaoLFOrnt1vCPsceSfjqbIgVcszhbsXU2dr 2IAzFV2lKzvlwolFoj+LciNkKB9speTTju6Gl3VxCkFuWbwbRQZtzpsvGyfs/g78A/X1 t2jzyQGwxvpM2lJyVRJcnZOsNjYB1TKKNNg1BHD02ljcLjoq4hSvG7yhlaarrbc78hx0 Bi6g== X-Gm-Message-State: AOJu0Yzpo2IBp14364b0Cy8P4uJds3/WhzqDLWaKhFMMaViHfABw+sZO YSHfZaZbWUVeCvftd/UgRtIquJzVtN/bpm0sw4Ef4j8yU1G6lN3shaCzmRWKkQ== X-Gm-Gg: AR+sD1292SEmgbWgb49iGWx5xy9mfyDPIFYySsqFy6WYPYYr+gZUkNDNdmU0fMjIcEY 0rhBqeQC4E6NmEAxFwdBGGSZjzrF/cwk22o6APdw2qnWxJ+Ofn614+Dq7ZH6p5wgY7cczliAsYg Nlwlun3tzKy5KlHP5g5zNQNAmF11g3I+JhLPEPpxqM21ZcXVTLOPBrkOWU6cnosDmGhRmwuNqhO pVHelQGsVaJLkAOxS3TopyD1TT7IAtha8yb4AnvNfs2nmAbSM/5CQx8JzMQhq5/T9Q5U9WF4n3z 4/ElqbEaCJR8eKMMz/pI7b4I9inqff3htCZBqcd2MaivFKHsqH2WDuz8mtQNuBFh+Kfh3KOk8PV XT5+AxJpaG/LAs5TO5wqBZh24bcPpyAqfsK6Jq3b2U9WCl5SYh9XJ89Veb4Nu0hV7kDYuuWEIMm GlUxAR2Qopzo6WOY6xSIJ6dUMvxSseIVz2JxjvkZxB3ycNWrYoYE6iizjAkxWJtg== X-Received: by 2002:a05:600c:8b14:b0:495:4cb8:42b9 with SMTP id 5b1f17b1804b1-4980c66d8cemr193280875e9.4.1785733663338; Sun, 02 Aug 2026 22:07:43 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 7/7] xen/sched: remove old scheduler registration, shrink struct scheduler Date: Mon, 3 Aug 2026 08:06:14 +0300 Message-Id: <20260803050614.5222-8-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> References: <20260803050614.5222-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1785733664-662A92AC-64EF8C7C/0/0 X-purgate-type: clean X-purgate-size: 25587 Every in-tree scheduler now registers through sched_ops instead of the original struct-scheduler-as-vtable path, so schedulers[], REGISTER_SCHEDULER() and NUM_SCHEDULERS have no remaining users. Remove them and finish the change struct sched_ops was introduced for: struct scheduler is shrunk down to just its per-cpupool fields - a pointer to a shared sched_ops, plus sched_data and cpupool. scheduler_alloc() now stores a pointer to the matching sched_ops instance instead of copying every field into a fresh allocation. Cpupools sharing a scheduler type now share one dispatch table instead of each holding a private copy of it. Every accessor in private.h is updated from s->field to s->ops->field to match. sched_idle_ops is split the same way every other scheduler was. A handful of call sites elsewhere read a scheduler's name, opt_name or sched_id directly and are updated to go through ->ops as well. Signed-off-by: Furkan Caliskan --- xen/arch/arm/xen.lds.S | 1 - xen/arch/ppc/xen.lds.S | 1 - xen/arch/riscv/xen.lds.S | 1 - xen/arch/x86/xen.lds.S | 1 - xen/common/sched/core.c | 144 +++++----------------------------- xen/common/sched/cpupool.c | 6 +- xen/common/sched/private.h | 155 ++++++++++--------------------------- xen/include/xen/xen.lds.h | 6 -- 8 files changed, 67 insertions(+), 248 deletions(-) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 9a63fa36a0..07bf875599 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -93,7 +93,6 @@ SECTIONS .data : { /* Data */ *(.data.page_aligned) - SCHEDULER_ARRAY SCHED_OPS_ARRAY HYPFS_PARAM diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S index da8f73d85b..1f4e200693 100644 --- a/xen/arch/ppc/xen.lds.S +++ b/xen/arch/ppc/xen.lds.S @@ -84,7 +84,6 @@ SECTIONS DECL_SECTION(.data) { /* Data */ *(.data.page_aligned) - SCHEDULER_ARRAY SCHED_OPS_ARRAY HYPFS_PARAM diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 01f202e504..97f2db1dfd 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -89,7 +89,6 @@ SECTIONS .data : { /* Data */ *(.data.page_aligned) - SCHEDULER_ARRAY SCHED_OPS_ARRAY HYPFS_PARAM diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index d128a30440..0f506ff1f6 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -306,7 +306,6 @@ SECTIONS DECL_SECTION(.data.read_mostly) { *(.data.read_mostly) - SCHEDULER_ARRAY SCHED_OPS_ARRAY HYPFS_PARAM } PHDR(text) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index fb2d1d5314..4e5f78e84d 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -87,10 +87,6 @@ DEFINE_PER_CPU(cpumask_t, cpumask_scratch); /* How many urgent vcpus. */ DEFINE_PER_CPU(atomic_t, sched_urgent_count); -extern const struct scheduler *__start_schedulers_array[], *__end_schedulers_array[]; -#define NUM_SCHEDULERS (__end_schedulers_array - __start_schedulers_array) -#define schedulers __start_schedulers_array - extern const struct sched_ops *__start_sched_ops_array[], *__end_sched_ops_array[]; #define NUM_SCHED_OPS (__end_sched_ops_array - __start_sched_ops_array) #define sched_ops_array __start_sched_ops_array @@ -103,42 +99,6 @@ static void sched_set_affinity( struct sched_unit *unit, const cpumask_t *hard, const cpumask_t *soft); -static void sched_ops_to_scheduler( - struct scheduler *sched, const struct sched_ops *ops) -{ - sched->name = ops->name; - sched->opt_name = ops->opt_name; - sched->sched_id = ops->sched_id; - sched->global_init = ops->global_init; - sched->init = ops->init; - sched->deinit = ops->deinit; - sched->free_udata = ops->free_udata; - sched->alloc_udata = ops->alloc_udata; - sched->free_pdata = ops->free_pdata; - sched->alloc_pdata = ops->alloc_pdata; - sched->deinit_pdata = ops->deinit_pdata; - sched->alloc_domdata = ops->alloc_domdata; - sched->free_domdata = ops->free_domdata; - sched->switch_sched = ops->switch_sched; - sched->insert_unit = ops->insert_unit; - sched->remove_unit = ops->remove_unit; - sched->sleep = ops->sleep; - sched->wake = ops->wake; - sched->yield = ops->yield; - sched->context_saved = ops->context_saved; - sched->do_schedule = ops->do_schedule; - sched->pick_resource = ops->pick_resource; - sched->migrate = ops->migrate; - sched->adjust = ops->adjust; - sched->adjust_affinity = ops->adjust_affinity; -#ifdef CONFIG_SYSCTL - sched->adjust_global = ops->adjust_global; -#endif - sched->dump_settings = ops->dump_settings; - sched->dump_cpu_state = ops->dump_cpu_state; - sched->move_timers = ops->move_timers; -} - static struct sched_resource *cf_check sched_idle_res_pick(const struct scheduler *ops, const struct sched_unit *unit) { @@ -168,10 +128,9 @@ static void cf_check sched_idle_schedule( unit->next_task = sched_idle_unit(cpu); } -static struct scheduler sched_idle_ops = { +static struct sched_ops sched_idle_sched_ops = { .name = "Idle Scheduler", .opt_name = "idle", - .sched_data = NULL, .pick_resource = sched_idle_res_pick, .do_schedule = sched_idle_schedule, @@ -180,6 +139,11 @@ static struct scheduler sched_idle_ops = { .free_udata = sched_idle_free_udata, }; +static struct scheduler sched_idle_ops = { + .ops = &sched_idle_sched_ops, + .sched_data = NULL, +}; + static inline struct vcpu *unit2vcpu_cpu(const struct sched_unit *unit, unsigned int cpu) { @@ -2122,7 +2086,7 @@ long do_set_timer_op(s_time_t timeout) /* scheduler_id - fetch ID of current scheduler */ int scheduler_id(void) { - return operations.sched_id; + return operations.ops->sched_id; } #endif @@ -2131,7 +2095,7 @@ long sched_adjust(struct domain *d, struct xen_domctl_scheduler_op *op) { long ret; - if ( op->sched_id != dom_scheduler(d)->sched_id ) + if ( op->sched_id != dom_scheduler(d)->ops->sched_id ) return -EINVAL; switch ( op->cmd ) @@ -2177,7 +2141,7 @@ long sched_adjust_global(struct xen_sysctl_scheduler_op *op) rcu_read_lock(&sched_res_rculock); - rc = ((op->sched_id == pool->sched->sched_id) + rc = ((op->sched_id == pool->sched->ops->sched_id) ? sched_adjust_cpupool(pool->sched, op) : -EINVAL); rcu_read_unlock(&sched_res_rculock); @@ -2344,7 +2308,7 @@ static struct sched_unit *do_schedule(struct sched_unit *prev, s_time_t now, struct sched_unit *next; /* get policy-specific decision on scheduling... */ - sched->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); + sched->ops->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); next = prev->next_task; @@ -3033,18 +2997,6 @@ void scheduler_enable(void) scheduler_active = true; } -static inline -const struct scheduler *__init sched_get_by_name(const char *sched_name) -{ - unsigned int i; - - for ( i = 0; i < NUM_SCHEDULERS; i++ ) - if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) ) - return schedulers[i]; - - return NULL; -} - static inline const struct sched_ops *__init sched_ops_get_by_name(const char* sched_name) { @@ -3058,13 +3010,7 @@ const struct sched_ops *__init sched_ops_get_by_name(const char* sched_name) int __init sched_get_id_by_name(const char *sched_name) { - const struct scheduler *scheduler = sched_get_by_name(sched_name); - const struct sched_ops *ops; - - if ( scheduler ) - return scheduler->sched_id; - - ops = sched_ops_get_by_name(sched_name); + const struct sched_ops *ops = sched_ops_get_by_name(sched_name); return ops ? ops->sched_id : -1; } @@ -3072,40 +3018,11 @@ int __init sched_get_id_by_name(const char *sched_name) void __init scheduler_init(void) { struct domain *idle_domain; - const struct scheduler *scheduler; const struct sched_ops *ops; int i; scheduler_enable(); - for ( i = 0; i < NUM_SCHEDULERS; i++) - { -#define sched_test_func(f) \ - if ( !schedulers[i]->f ) \ - { \ - printk("scheduler %s misses .%s, dropped\n", \ - schedulers[i]->opt_name, #f); \ - schedulers[i] = NULL; \ - } - - sched_test_func(init); - sched_test_func(deinit); - sched_test_func(pick_resource); - sched_test_func(alloc_udata); - sched_test_func(free_udata); - sched_test_func(switch_sched); - sched_test_func(do_schedule); - -#undef sched_test_func - - if ( schedulers[i]->global_init && schedulers[i]->global_init() < 0 ) - { - printk("scheduler %s failed initialization, dropped\n", - schedulers[i]->opt_name); - schedulers[i] = NULL; - } - } - for ( i = 0; i < NUM_SCHED_OPS; i++) { #define sched_test_func(f) \ @@ -3134,30 +3051,22 @@ void __init scheduler_init(void) } } - scheduler = sched_get_by_name(opt_sched); - ops = scheduler ? NULL : sched_ops_get_by_name(opt_sched); - if ( !scheduler && !ops ) + ops = sched_ops_get_by_name(opt_sched); + if ( !ops ) { printk("Could not find scheduler: %s\n", opt_sched); - scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT); - ops = scheduler ? NULL : sched_ops_get_by_name(CONFIG_SCHED_DEFAULT); - BUG_ON(!scheduler && !ops); - if ( scheduler ) - printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name); - else - printk("Using '%s' (%s)\n", ops->name, ops->opt_name); + ops = sched_ops_get_by_name(CONFIG_SCHED_DEFAULT); + BUG_ON(!ops); + printk("Using '%s' (%s)\n", ops->name, ops->opt_name); } - if ( scheduler ) - operations = *scheduler; - else - sched_ops_to_scheduler(&operations, ops); + operations.ops = ops; if ( cpu_schedule_up(0) ) BUG(); register_cpu_notifier(&cpu_schedule_nfb); - printk("Using scheduler: %s (%s)\n", operations.name, operations.opt_name); + printk("Using scheduler: %s (%s)\n", operations.ops->name, operations.ops->opt_name); if ( sched_init(&operations) ) panic("scheduler returned error on init\n"); @@ -3507,28 +3416,17 @@ struct scheduler *scheduler_alloc(unsigned int sched_id) int ret; struct scheduler *sched; - for ( i = 0; i < NUM_SCHEDULERS; i++ ) - if ( schedulers[i] && schedulers[i]->sched_id == sched_id ) - goto found; - for ( i = 0; i < NUM_SCHED_OPS; i++ ) if ( sched_ops_array[i] && sched_ops_array[i]->sched_id == sched_id ) - goto found_new; + goto found; return ERR_PTR(-ENOENT); found: - if ( (sched = xmalloc(struct scheduler)) == NULL ) - return ERR_PTR(-ENOMEM); - memcpy(sched, schedulers[i], sizeof(*sched)); - goto init; - - found_new: if ( (sched = xzalloc(struct scheduler)) == NULL ) return ERR_PTR(-ENOMEM); - sched_ops_to_scheduler(sched, sched_ops_array[i]); + sched->ops = sched_ops_array[i]; - init: if ( (ret = sched_init(sched)) != 0 ) { xfree(sched); @@ -3559,7 +3457,7 @@ void schedule_dump(struct cpupool *c) { sched = c->sched; cpus = c->res_valid; - printk("Scheduler: %s (%s)\n", sched->name, sched->opt_name); + printk("Scheduler: %s (%s)\n", sched->ops->name, sched->ops->opt_name); sched_dump_settings(sched); } else diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 081e1053eb..1c70b58409 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -338,7 +338,7 @@ static struct cpupool *cpupool_create(unsigned int poolid, spin_unlock(&cpupool_lock); debugtrace_printk("Created cpupool %u with scheduler %s (%s)\n", - c->cpupool_id, c->sched->name, c->sched->opt_name); + c->cpupool_id, c->sched->ops->name, c->sched->ops->opt_name); return c; @@ -862,7 +862,7 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) if ( c == NULL ) break; op->cpupool_id = c->cpupool_id; - op->sched_id = c->sched->sched_id; + op->sched_id = c->sched->ops->sched_id; op->n_dom = c->n_dom; ret = cpumask_to_xenctl_bitmap(&op->cpumap, c->cpu_valid); cpupool_put(c); @@ -1294,7 +1294,7 @@ struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id) struct cpupool *pool; if ( sched_id < 0 ) - sched_id = scheduler_get_default()->sched_id; + sched_id = scheduler_get_default()->ops->sched_id; pool = cpupool_create(pool_id, sched_id); diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index 4dd5c99b87..c03063befe 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -365,198 +365,132 @@ struct sched_ops { }; struct scheduler { - const char *name; /* full name for this scheduler */ - const char *opt_name; /* option name for this scheduler */ - unsigned int sched_id; /* ID for this scheduler */ - void *sched_data; /* global data pointer */ - struct cpupool *cpupool;/* points to this scheduler's pool */ - - int (*global_init) (void); - - int (*init) (struct scheduler *ops); - void (*deinit) (struct scheduler *ops); - - void (*free_udata) (const struct scheduler *ops, void *priv); - void * (*alloc_udata) (const struct scheduler *ops, - struct sched_unit *unit, void *dd); - - void (*free_pdata) (const struct scheduler *ops, - void *pcpu, int cpu); - void * (*alloc_pdata) (const struct scheduler *ops, int cpu); - void (*deinit_pdata) (const struct scheduler *ops, - void *pcpu, int cpu); - - /* Returns ERR_PTR(-err) for error, NULL for 'nothing needed'. */ - void * (*alloc_domdata) (const struct scheduler *ops, - struct domain *dom); - /* Idempotent. */ - void (*free_domdata) (const struct scheduler *ops, void *data); - - spinlock_t * (*switch_sched) (struct scheduler *new_ops, unsigned int cpu, - void *pdata, void *vdata); - - /* Activate / deactivate units in a cpu pool */ - void (*insert_unit) (const struct scheduler *ops, - struct sched_unit *unit); - void (*remove_unit) (const struct scheduler *ops, - struct sched_unit *unit); - - void (*sleep) (const struct scheduler *ops, - struct sched_unit *unit); - void (*wake) (const struct scheduler *ops, - struct sched_unit *unit); - void (*yield) (const struct scheduler *ops, - struct sched_unit *unit); - void (*context_saved) (const struct scheduler *ops, - struct sched_unit *unit); - - void (*do_schedule) (const struct scheduler *ops, - struct sched_unit *currunit, s_time_t now, - bool tasklet_work_scheduled); - - struct sched_resource *(*pick_resource)(const struct scheduler *ops, - const struct sched_unit *unit); - void (*migrate) (const struct scheduler *ops, - struct sched_unit *unit, - unsigned int new_cpu); - int (*adjust) (const struct scheduler *ops, - struct domain *d, - struct xen_domctl_scheduler_op *op); - void (*adjust_affinity)(const struct scheduler *ops, - struct sched_unit *unit, - const struct cpumask *hard, - const struct cpumask *soft); -#ifdef CONFIG_SYSCTL - int (*adjust_global) (const struct scheduler *ops, - struct xen_sysctl_scheduler_op *sc); -#endif - void (*dump_settings) (const struct scheduler *ops); - void (*dump_cpu_state) (const struct scheduler *ops, int cpu); - void (*move_timers) (const struct scheduler *ops, - struct sched_resource *sr); + const struct sched_ops *ops; /* shared, read-only dispatch table */ + void *sched_data; /* global data pointer */ + struct cpupool *cpupool; /* points to this scheduler's pool */ }; static inline int sched_init(struct scheduler *s) { - return s->init(s); + return s->ops->init(s); } static inline void sched_deinit(struct scheduler *s) { - s->deinit(s); + s->ops->deinit(s); } static inline spinlock_t *sched_switch_sched(struct scheduler *s, unsigned int cpu, void *pdata, void *vdata) { - return s->switch_sched(s, cpu, pdata, vdata); + return s->ops->switch_sched(s, cpu, pdata, vdata); } static inline void sched_dump_settings(const struct scheduler *s) { - if ( s->dump_settings ) - s->dump_settings(s); + if ( s->ops->dump_settings ) + s->ops->dump_settings(s); } static inline void sched_dump_cpu_state(const struct scheduler *s, int cpu) { - if ( s->dump_cpu_state ) - s->dump_cpu_state(s, cpu); + if ( s->ops->dump_cpu_state ) + s->ops->dump_cpu_state(s, cpu); } static inline void *sched_alloc_domdata(const struct scheduler *s, struct domain *d) { - return s->alloc_domdata ? s->alloc_domdata(s, d) : NULL; + return s->ops->alloc_domdata ? s->ops->alloc_domdata(s, d) : NULL; } static inline void sched_free_domdata(const struct scheduler *s, void *data) { - ASSERT(s->free_domdata || !data); - if ( s->free_domdata ) - s->free_domdata(s, data); + ASSERT(s->ops->free_domdata || !data); + if ( s->ops->free_domdata ) + s->ops->free_domdata(s, data); } static inline void *sched_alloc_pdata(const struct scheduler *s, int cpu) { - return s->alloc_pdata ? s->alloc_pdata(s, cpu) : NULL; + return s->ops->alloc_pdata ? s->ops->alloc_pdata(s, cpu) : NULL; } static inline void sched_free_pdata(const struct scheduler *s, void *data, int cpu) { - ASSERT(s->free_pdata || !data); - if ( s->free_pdata ) - s->free_pdata(s, data, cpu); + ASSERT(s->ops->free_pdata || !data); + if ( s->ops->free_pdata ) + s->ops->free_pdata(s, data, cpu); } static inline void sched_deinit_pdata(const struct scheduler *s, void *data, int cpu) { - if ( s->deinit_pdata ) - s->deinit_pdata(s, data, cpu); + if ( s->ops->deinit_pdata ) + s->ops->deinit_pdata(s, data, cpu); } static inline void *sched_alloc_udata(const struct scheduler *s, struct sched_unit *unit, void *dom_data) { - return s->alloc_udata(s, unit, dom_data); + return s->ops->alloc_udata(s, unit, dom_data); } static inline void sched_free_udata(const struct scheduler *s, void *data) { - s->free_udata(s, data); + s->ops->free_udata(s, data); } static inline void sched_insert_unit(const struct scheduler *s, struct sched_unit *unit) { - if ( s->insert_unit ) - s->insert_unit(s, unit); + if ( s->ops->insert_unit ) + s->ops->insert_unit(s, unit); } static inline void sched_remove_unit(const struct scheduler *s, struct sched_unit *unit) { - if ( s->remove_unit ) - s->remove_unit(s, unit); + if ( s->ops->remove_unit ) + s->ops->remove_unit(s, unit); } static inline void sched_sleep(const struct scheduler *s, struct sched_unit *unit) { - if ( s->sleep ) - s->sleep(s, unit); + if ( s->ops->sleep ) + s->ops->sleep(s, unit); } static inline void sched_wake(const struct scheduler *s, struct sched_unit *unit) { - if ( s->wake ) - s->wake(s, unit); + if ( s->ops->wake ) + s->ops->wake(s, unit); } static inline void sched_yield(const struct scheduler *s, struct sched_unit *unit) { - if ( s->yield ) - s->yield(s, unit); + if ( s->ops->yield ) + s->ops->yield(s, unit); } static inline void sched_context_saved(const struct scheduler *s, struct sched_unit *unit) { - if ( s->context_saved ) - s->context_saved(s, unit); + if ( s->ops->context_saved ) + s->ops->context_saved(s, unit); } static inline void sched_migrate(const struct scheduler *s, struct sched_unit *unit, unsigned int cpu) { - if ( s->migrate ) - s->migrate(s, unit, cpu); + if ( s->ops->migrate ) + s->ops->migrate(s, unit, cpu); else sched_set_res(unit, get_sched_res(cpu)); } @@ -564,7 +498,7 @@ static inline void sched_migrate(const struct scheduler *s, static inline struct sched_resource *sched_pick_resource( const struct scheduler *s, const struct sched_unit *unit) { - return s->pick_resource(s, unit); + return s->ops->pick_resource(s, unit); } static inline void sched_adjust_affinity(const struct scheduler *s, @@ -572,29 +506,29 @@ static inline void sched_adjust_affinity(const struct scheduler *s, const cpumask_t *hard, const cpumask_t *soft) { - if ( s->adjust_affinity ) - s->adjust_affinity(s, unit, hard, soft); + if ( s->ops->adjust_affinity ) + s->ops->adjust_affinity(s, unit, hard, soft); } static inline int sched_adjust_dom(const struct scheduler *s, struct domain *d, struct xen_domctl_scheduler_op *op) { - return s->adjust ? s->adjust(s, d, op) : 0; + return s->ops->adjust ? s->ops->adjust(s, d, op) : 0; } #ifdef CONFIG_SYSCTL static inline int sched_adjust_cpupool(const struct scheduler *s, struct xen_sysctl_scheduler_op *op) { - return s->adjust_global ? s->adjust_global(s, op) : 0; + return s->ops->adjust_global ? s->ops->adjust_global(s, op) : 0; } #endif static inline void sched_move_timers(const struct scheduler *s, struct sched_resource *sr) { - if ( s->move_timers ) - s->move_timers(s, sr); + if ( s->ops->move_timers ) + s->ops->move_timers(s, sr); } static inline void sched_unit_pause_nosync(const struct sched_unit *unit) @@ -613,9 +547,6 @@ static inline void sched_unit_unpause(const struct sched_unit *unit) vcpu_unpause(v); } -#define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \ - __used_section(".data.schedulers") = &(x) - #define REGISTER_SCHED_OPS(x) static const struct sched_ops *x##_entry \ __used_section(".data.sched_ops") = &(x) diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h index 157d48eabd..0005c38486 100644 --- a/xen/include/xen/xen.lds.h +++ b/xen/include/xen/xen.lds.h @@ -173,12 +173,6 @@ _edevice = .; \ } :text -#define SCHEDULER_ARRAY \ - . = ALIGN(POINTER_ALIGN); \ - __start_schedulers_array = .; \ - *(.data.schedulers) \ - __end_schedulers_array = .; - #define SCHED_OPS_ARRAY \ . = ALIGN(POINTER_ALIGN); \ __start_sched_ops_array = .; \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 05:08:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 05:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381153.1624718 (Exim 4.92) (envelope-from ) id 1wqkuj-0006JV-RV; Mon, 03 Aug 2026 05:08:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381153.1624718; Mon, 03 Aug 2026 05:08:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqkuj-0006JM-Oo; Mon, 03 Aug 2026 05:08:37 +0000 Received: by outflank-mailman (input) for mailman id 1381153; Mon, 03 Aug 2026 05:08:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqkuj-0006JC-7e for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 05:08:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqkui-00Dbdy-KR for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:08:36 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a702231-bab6-0a2a0a5309dd-0a2a4502e77e-34 for ; Mon, 03 Aug 2026 07:08:36 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a702218-6ca4-0a2a45020019-d1558030c85d-3 for ; Mon, 03 Aug 2026 07:07:36 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4956869750eso9792965e9.2 for ; Sun, 02 Aug 2026 22:07:36 -0700 (PDT) Received: from notebook.. ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b917efsm310345185e9.11.2026.08.02.22.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 22:07:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785733656; x=1786338456; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V6MENfzpjRK8Go/oREv4Ua4C28lp8j5eDhquh247IHI=; b=i41N1IpN0Z9IJSaLvE/8GYPpXT/XvvfNg8xaQinM5VqeJSOVqNfO+EcoekSzHmOQVt xSseD0QqkF4Cp47yp8ExeX/kN6rpv0sElVHhNabXkqSw7BoyuCf4r7oU/z2HjsRUCJe7 cxqryWYe4VAIWiRDiR/J1buM4MU5V7BnZ4rNY7IkrrNPUHUhfgcd04+cXL4Hd6WNw1pV ZWec+hQCLJHN2ORGGmoxVIVT7hT+ddecyhfrsWYbOaBkeNPOQ8oNGjVVtLZitCO/nj6X h3YRlMMUJPJ+szQ91DR9JnO8dLjkeJljlZ8GcvHTy1UHtAdSPB9xkiMOmdLzkpFGznzr qjSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785733656; x=1786338456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=V6MENfzpjRK8Go/oREv4Ua4C28lp8j5eDhquh247IHI=; b=TOLtUlTQYR9cmjfTctILigprQJiyydl9Ix4RMkLVQKTFhL7/Cva9wAMT7ZQigInnT5 nmvGRBtNQOZnm3O7S0/skAOX48VVzsqnsFk5n1QIE0PHN/xeGCvcmzgquLcuP1S6q6jq PHiTFo+xdfUJ40IyPcGPOJu+u0rH3mYS7L3K0kEzDx3bdcfscQxSSmYizs3w2SybKRVg Pu+SNBUfPuE6wUtY2EWP+KaspMS83fQwrJ/gvYK2eq5c7zBBW3y8FEEd1tCjsGBXsNAT RS9j5ArWYi3BqxkcUmEAY9lCbdjOOFAsjxk+viDH1g3yHe8/RcHZ2sY11HgCuEr0hCmO 1I/A== X-Gm-Message-State: AOJu0Yw5buLPzuADYNh+TI71tAUvkq9wP2QqPrbLlkRUCcRq0Z5G2m4a rM900uVKxUjZoI/jKy6qs/v7QwCP2d/YSYBv+94HnBeXvJ24hsO4QyuEaXUtaQ== X-Gm-Gg: AR+sD13ioTfCJEMjRb8hkWhKhav6RM2eVVPPEMuJIOtJEwa5uPDbYw1DFmCX7nzk3O4 Nca0SNIAVkWp+A1YT5RxXb7GwvChT9TgBUHdg+8+L1zBZCeJdnrr18h7keZ9juv3p4Ie5wDstpD aTVCLM1mNdpBDU0xNd3ULiAd1c2kyp0wCBBWtignRc1mhKYJwdHsfDdSe47QctuZitXd7TwgCgW eboz1K3sgpMkfxdj6D0Z2ma2KTClcztMmf2R4sQPXdU6x7owjkvQtxjjvAuRiN2/3+E6Kl+kAFU +waKzdvKLgnAQKDZatx7Ws+e433+4+Tga6ddebxJpKvoVR5xJHPb6JBZLDpK2Ib3t1GuGrHBdfx 2OQpyqKNazOYOdE8R63XnkbIo5sq4zOO1rn/dI6vFXCps8aN9IrzwTB637neASoJg5syxw4Z86R W1yP4NN0Cyf449HfYpKT9hAWd1BwvrvOwsM7s/8mSvA0GaHeuaTDurFrWpL7kwyYZJJgcj463+ X-Received: by 2002:a05:600c:548d:b0:495:6134:6d61 with SMTP id 5b1f17b1804b1-4980c674de0mr196641985e9.19.1785733656026; Sun, 02 Aug 2026 22:07:36 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com, Furkan Caliskan Subject: [PATCH 6/7] xen/sched: null: migrate to new sched_ops Date: Mon, 3 Aug 2026 08:06:13 +0300 Message-Id: <20260803050614.5222-7-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> References: <20260803050614.5222-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1785733656-F1CAA2AC-CC47DECB/0/0 X-purgate-type: clean X-purgate-size: 1283 Declare sched_null_def as a struct sched_ops instead of a struct scheduler, dropping the .sched_data field, and register it with REGISTER_SCHED_OPS() so it is found through sched_ops_array[] instead of schedulers[]. This moves the null scheduler onto the new sched_ops registration path. Signed-off-by: Furkan Caliskan --- xen/common/sched/null.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index 952bb47444..5194c8216c 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -1037,11 +1037,10 @@ static void cf_check null_dump(const struct scheduler *ops) spin_unlock_irqrestore(&prv->lock, flags); } -static const struct scheduler sched_null_def = { +static const struct sched_ops sched_null_def = { .name = "null Scheduler", .opt_name = "null", .sched_id = XEN_SCHEDULER_NULL, - .sched_data = NULL, .init = null_init, .deinit = null_deinit, @@ -1068,4 +1067,4 @@ static const struct scheduler sched_null_def = { .dump_settings = null_dump, }; -REGISTER_SCHEDULER(sched_null_def); +REGISTER_SCHED_OPS(sched_null_def); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:01:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381175.1624745 (Exim 4.92) (envelope-from ) id 1wqmfd-0003WX-0G; Mon, 03 Aug 2026 07:01:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381175.1624745; Mon, 03 Aug 2026 07:01:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmfc-0003WQ-TG; Mon, 03 Aug 2026 07:01:08 +0000 Received: by outflank-mailman (input) for mailman id 1381175; Mon, 03 Aug 2026 07:01:07 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmfa-0003Lf-VJ for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:01:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmfa-00Dx4z-Al for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:01:06 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a703ca5-2eae-0a2a0a5409dd-0a2a450cb79a-48 for ; Mon, 03 Aug 2026 09:01:06 +0200 Received: from [148.163.143.241] (helo=mx0b-00498f03.pphosted.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a703cb0-f479-0a2a450c0019-94a38ff19176-3 for ; Mon, 03 Aug 2026 09:01:06 +0200 Received: from pps.filterd (m0384717.ppops.net [127.0.0.1]) by mx0b-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6733QgDQ149478 for ; Mon, 3 Aug 2026 07:01:04 GMT Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11011051.outbound.protection.outlook.com [52.101.62.51]) by mx0b-00498f03.pphosted.com (PPS) with ESMTPS id 4ftk39s1na-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Mon, 03 Aug 2026 07:01:04 +0000 (GMT) Received: from SA9P221CA0011.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::16) by LV8PR16MB5909.namprd16.prod.outlook.com (2603:10b6:408:1e9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.17; Mon, 3 Aug 2026 07:00:56 +0000 Received: from SN1PEPF000252A3.namprd05.prod.outlook.com (2603:10b6:806:25:cafe::9b) by SA9P221CA0011.outlook.office365.com (2603:10b6:806:25::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.10 via Frontend Transport; Mon, 3 Aug 2026 07:00:56 +0000 Received: from mx0b-00498f04.pphosted.com (148.163.138.245) by SN1PEPF000252A3.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Mon, 3 Aug 2026 07:00:56 +0000 Received: from pps.filterd (m0426316.ppops.net [127.0.0.1]) by mx0b-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6736OAVX3620404 for ; Mon, 3 Aug 2026 03:00:55 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-usw.ser.proofpoint.com [50.112.124.217]) by mx0b-00498f04.pphosted.com (PPS) with ESMTPS id 4fsyuch9af-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 03:00:55 -0400 (EDT) Received: from localhost ([19.12.76.221]) by cmsmtp with ESMTPSA id qmfMwSXbfJrM7qmfNwfg4Z; Mon, 03 Aug 2026 07:00:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=ppford; bh=dlZ MsMtUd8O/k0DHPgYEcJOApxOGUU7AlcWmznVSQRk=; b=l9Ejmnvy32myzL7JYQL nNDSxKy4iNteJtSOZvZIDrmlM6LRdjcJ164ajuYJTdlkFBMbZdkUuokFrAJ7CbUd Oh7ccpWSCKLcE2hPDUmRnautalwuaxjMAgWS4w6TWRXup2CpRkyw/iLGe3FX/fj5 NwC87HijT8z4n8D5qtmvYlTeOMouzHqc+rTszSORd50V4Kw8P2aD7g28zgzGeToi Rth2Dh5Z74c2NubOcaMhLiScJ721KlItO0uMuxaarTdf0pG/u1R9+YmdtjHy2xB/ dKOQ6PMwvCBcQ1xpoTyr5Pe47KDilm3bSXttAf5U3zO7lAATo4G6lVm5z+uXy4mr 1Uw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H+c+IdYWAjKx16L3JnxhYktEPqSXgYX4bwvKb5LCN74wtCtvqU4WGUvcjKEGmgxtb5FBzsm9ERPiLByFdk9XWnejbqHztdTfagk3fFKe/OQ394Hux8NQyBq6lY2BLX6PfAFJampJ1r8PstCrbKNeAOpkILhw59TYsqMI+UZm6tEcJbpxSRGNn1iWh5cI6lXRMx06QRZn+8hIV+YYwO9/v3P1I3FjWuVK3Ak8ixSJPJpRVZvI/nQcR74ES/DFTVwO7ihanay8o844zL8ozzrmSWPfP1sdi6toUQ/JYhFgeXgt8xcpCrSJPPzy14wi2vvprXSVG5/dVb+sbBjbb4tXAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dlZMsMtUd8O/k0DHPgYEcJOApxOGUU7AlcWmznVSQRk=; b=QY4CCa/feMtP83h5EbfInZmQDjWin+9DhLtUgEMWSZzhCqPvyQS3tYSCk9l8a0B96HXHDxv3rTJhfN7Gh6DNFf7GSjwScHUTnScNkNxwH53wQsXErJhaarDy0E3YWlQJ46xVwoydpUKVbgw9roNWyF89lLlwHbK6PStIFJ09AOrP0KUhWUPTTQnPS249YBHX6xyEztmB+3n4gIX6ycdkoQuv9+WelvH+/NCEYOYj2Pu3mHinVkqvQGg2Ok7tTkNUBRk+3ZKynBq+xwuIrFAo+icXIpdVjWb7U5twzDKlBX5vQNBio3tnjhUeVcm3GnHFi3JLIPT+Kv1YmyOKpxIbPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlZMsMtUd8O/k0DHPgYEcJOApxOGUU7AlcWmznVSQRk=; b=PQVr/tF7IWf/jLJbNSjNrE6j90QZW/hQcFTyHH40CUcBzcp8+RFwbTHncoyWulee+Gwh9Yu9EULpxCH3rTMavzAEd6Y1Ojcxb6t8dOwVe+9tDhPpnwId1BkjQC8fnMTUW56vGzP0rxSXYS/K4Qavl7ZsyLrhJvhQ7gSPWmu+03c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 148.163.138.245) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 148.163.138.245 as permitted sender) receiver=protection.outlook.com; client-ip=148.163.138.245; helo=mx0b-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= ppserprodsaar; bh=dlZMsMtUd8O/k0DHPgYEcJOApxOGUU7AlcWmznVSQRk=; b= AoLbcI7ROBr3tWuDESzxC8wCnrPWm/3VOivZenSqhvgtLgfCuADy3vFGC/kN8E7l UVLH4dbMbrmjwrzfppm/RFf8JSNDAdJ6Zceb+5J/hHWA/2GMSQNxy7c/8xApvVky kPrs3otByXZyhvS3xA4gMIDw7oNh2fjwJ7qmBy3M3xssKgZvCOBHuu9PYZMGeHKx dLK80Wp796nhghwVpPOXK4zFCbmigwHKd9Z4LUkK47xPhExvlzQch+ON6P4gqdt1 300tSzZdtEHqnIv5/7rqUlJGcJ6AYaJJRkSAVlNajs+iE1hG49OKpHuMqICKGT5R LQlx9KZs+0CqnxtLkidSmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=ppfserpocford; bh=dlZMsMt Ud8O/k0DHPgYEcJOApxOGUU7AlcWmznVSQRk=; b=pU2dHdnKv3d+j6pxCJ5HxFY FqeNt/YBPTpl9j/e2lO0zqIeR3n6hg22nNaJI/WX5ZcMhVZUD3rd0t4ATSEEWBNz woCg4SueWH/76msf4noJhZTHBY9RkpQKnWOegi9XazklHc8FCUxxBTdHoJokXCQD PitXHlgu7ZuMfwbwQgdxP5tprj3bsrn7GoNghFbi3gCkf2B0bGADsMfXArZRmdj/ CJMVyZ7WHMEsOXJGHlDXh+Kf+gChDn5N2Okevn/GOhZUSGgY15wU2sb5AyaxV9/O onmNQIc/t9WkRF+mMJqqPLvdSMcHKrHM/29Dk0Yh7ptn6QTp+HAjRbCwCojX23A= = X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: qmfMwSXbfJrM7qmfNwfg4Z X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v2 1/2] xen/common: annotate saved_cmdline with __ro_after_init Date: Mon, 3 Aug 2026 00:00:46 -0700 Message-ID: <20260803070047.3097846-2-dmukhin@ford.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803070047.3097846-1-dmukhin@ford.com> References: <20260803070047.3097846-1-dmukhin@ford.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030060 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A3:EE_|LV8PR16MB5909:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 825b73d9-e5c0-4f17-eb24-08def12cf75e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|82310400026|23010399003|22082099003|18002099003|6133799003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: 43+gtYv8ZGfgHWK6sPhM5Ck2V+wGDsyYWmiaK1LQJLccCPgR0KIs6hahnIqtXszGQSrtTH57dEGssvl2atdan6M+5KtK/7pmRi5Z189kKwjPwVmwLiaYpmwRAAtpqirSaOeix5TgDnw9DROkyuv+yS1MyH5I6nYD7qvUypmBXufOfn9w6rXNIPchgWtkiaUsGpu6W2Q03lz2rviqdHDvuNhedOIc/T6eYDJDNi9kQ/8itVW5fefy45pdViL7eOtvUtGLgMH62Tidhd/jrGJAYEwRt0GS7QPLtmh3eYp81E18IyjQVVikd27Jc+YXJS009WiHscHSF4LN1vahyUt73qqiNOyhl8eKKhep3EXqnTivuaBpohlET3J37W/wGYeOVtt4DSeNxZocOBKpJHSs1ibfOfOs9yi5PhZct1kJtK3mnItOPbbbDr+CYBsKcVBKPmJ8bUnCZwxrhGW85O9370wdvdQhF0mzNzb27JY//jh59UnurXj55+7gYw03wror0LUCUqtu+jiIHhLhIx9NENQYqk45/7YyfoAG0JHYD+xql4TA+JNGWN/riu2ROuoBm/c7EQtCk540VcGYjJ+QuXtv9uraW1mKZ1yJOzYkiy8JmOFuiRJmSoXnGWWMQtjhqr63HXmE4uyChyu+eBfYxuuFzYj2XGoO3zy34/Yszrp2oZGZ0fheabzESVlLzY689e2HYwtqanGl+eSECOTFkw== X-Forefront-Antispam-Report: CIP:148.163.138.245;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0b-00498f04.pphosted.com;PTR:mx0b-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(23010399003)(22082099003)(18002099003)(6133799003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CBDoDr/LahqAqadldgtjIrGrexhjkBehQw7Zv1zmA3EPaGA61Zx4oMyxbtYwqSIB3zRE5LMJw63hGHyGavLFcl5NDeOU2v2V0xnLlSDlTrCFAFkQnl6QFg91AZHrCPU003norlf0dq/ulc2sAhWgh9SjbbUo6jTGUYQQ/kaqZaorqUy0oviwydIRqS3HMHP7BR4OYysPPFrkwctlrzEiLM+ykarqUiu5gOJtHjGBP824p6qzzBwDxDVkMwHikiSqnTvn/8LArnBZ37Qhn3nny4VrGy2dk1XxeqPT5K14Qgbp3slaadi04h7EogdhyUbwbiG3wlk10SFN7i2zX3J80OTycCrcEd7l1Qn1TsgJXTDiVCXWhpSF7kqnb39unIVkfv6pXZ5J4gi+5BOmrDoKQkePFcBV8YRfE2wuMaoJqFnOPQWISqtuQcfELriW8nzn X-Exchange-RoutingPolicyChecked: qpUYF49fGlPh3fEyP5XAcUW9Wrau1rXP89G15qqKALdGD6gmAJG0yAgJRuA0B7QgKxGeX8gXv7kSx6cPN/s4pQzTkKqc5ULk78QxoAQrZAcEs2ANqKqQIwPqvRezCCUVNXfgYEr+uJ+zgERHxxJZH17l2cTJrKGwaxe1cLF+7M0K8n2J8OEM4rby+e0g3boXgI0OC4Y1g8GsmEIEQ+wUGX3rGoTRe4oIGvONk6NtpfIbFcXrDpd3Shuefoy9hEraNqj2jctgRl2aevdmjF2z+4AGNXBI50NlwlVpyHuVknEExa0BxwmJTdDyi7q4NMNhVIAwJwRjTlNpP1Z4mw5hhw== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /yyqXSja/+MdHqdwABC3LLhHN8KMiQascLVGao0vTuwBJDHn2agkLTPVH2Cx/NkGzyIEeEmt7Xb3woXok/Km0ZlmhWEbYz6K9hBVFeIZBh9+0mhhYyYDNKAk47h7IyzAygRxbuwUP3+jR+tSf5c9gIMrrO+dDFwEDZpojJUiBo44/s/Gd8oPsMQPNOYPhGIV25V0E7uvEPAr7iwTYqtKt42mndfBIidK22j5oB0Dho2UtbQE2ntXumZxWtk6XK4G/awLZLnn0c9/ewzSRk9LI/1y/8Q0ErS8wY7x10z6K62yV9oSguODAuZutj0xEerYeyEUttZYj5Rj1+M62rN3COCL1ph/YUldLRjy/rtn1q9UumZrRBd6yan+IdQZk7XEgQxZVFC+Rd4wEogmhHlpd0iNAqfXVhef13Gf+4b3REp0+5Fm06+3m6jxHMq59CI5q7NyEYlz22APGWwmHpomceu2Uh4sKrps84Ao/In7/0ZY7NKZ6QqBSlHueMEkC06CMDuxBrzt65gO/TR4w4Hkob8o11lx/51Ip0mZB/LBg7dZN9sIatqjZdxroTIiLt/BdKOzvZRxLrd9hjJRWrYGHcon3pYsYk+T9lhiSOpW5/wZHEcZ3s/efr+acwab5x0g X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 07:00:56.2117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 825b73d9-e5c0-4f17-eb24-08def12cf75e X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[148.163.138.245];Helo=[mx0b-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR16MB5909 X-Proofpoint-GUID: pvtjZgQwcI_eWl9TBq7J50Wys0Ft6DPv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDA2MCBTYWx0ZWRfX2ExiIPB5yj91 vlGuMp0GCiKpZWCoFx9yRvwk+TXBgwH6pxGgj7RpIgn5392V6pggkuWEe27xQR4FLUIqmyoIK52 MsXoY5Vi/BjagaWaxHFTk8Pyfbg2FlL3PJxi87arPK6PNO1fF2a1XMPKu4pcimG/HoJaFJfH0Iz igM1MwHvspTVcRaW5ii8MwoOl7fsi702PAwoejPpQaQI7+ZxQuXHg2R5cBYHSjAPbOqonY1sBYq cL2NU6ByGtW13a6k9i35Ca6g8exIolVhBVM2ubR5kpkkUWZerx2mQIO5ijRWK4/d6/wMeddmE/J w+ZpPJrOQFYl7xQR7i3fUj5IZCDb2fXxqFy/WWKSgmm3UWFxzKZw7Sl+riW+YPVtBmb17pvnc/X LUfvRVmhVaQ7sFhm/sw/qe6B6F9Yvvto9jGLAS1KcKH+h149VBzVXrkFHmCgDXYPgiIz1xDMX3N noUDGbkyohNVBTOAukw== X-Proofpoint-ORIG-GUID: pvtjZgQwcI_eWl9TBq7J50Wys0Ft6DPv X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDA2MCBTYWx0ZWRfX0M1M0ZaywzAl RTIBj8mmEjjmsfgqbweY1y+OKXU4VchlsbdUm4KKC8R3ZD45s412n9/fv8DfeivJTc+Mr6euQDS jqVkyhQTSWkKwReYZXg0cyOHAmV2X1EZHgG5dp/TinqHcBPdVbf+ X-Authority-Analysis: v=2.4 cv=doPrzVg4 c=1 sm=1 tr=0 ts=6a703cb0 cx=c_pps a=qX5DP9EEIf1faxnBSU0rOg==:117 a=b7IhknPlfT0FN1EembXvig==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=AHe91QgOk3R4nFVtG5At:22 a=cbNQJ9GKAAAA:8 a=iox4zFpeAAAA:8 a=SOBqYn4TATFuCMYqiXgA:9 a=DqJYxgmhk6moR-_7_KoZ:22 a=WzC6qhA0u3u7Ye7llzcV:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030060 X-purgate-ID: tlsNG-d25034/1785740466-76EDAA5B-3175B481/0/0 X-purgate-type: clean X-purgate-size: 942 From: Denis Mukhin The hypervisor command line is not modified after initialization. Annotate saved_cmdline with __ro_after_init to place it in the dedicated read-only-after-init section. Suggested-by: Jan Beulich Signed-off-by: Denis Mukhin --- Changes since v1: - new patch --- xen/common/kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index fb45f8139995..d1bef9ac2b2b 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -34,7 +34,7 @@ bool __ro_after_init opt_dit = IS_ENABLED(CONFIG_DIT_DEFAULT); boolean_param("dit", opt_dit); #endif -static xen_commandline_t saved_cmdline; +static xen_commandline_t __ro_after_init saved_cmdline; static const char __initconst opt_builtin_cmdline[] = CONFIG_CMDLINE; char __ro_after_init xen_cap_info[128]; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:01:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381173.1624728 (Exim 4.92) (envelope-from ) id 1wqmfV-00033O-Fp; Mon, 03 Aug 2026 07:01:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381173.1624728; Mon, 03 Aug 2026 07:01:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmfV-00033H-AH; Mon, 03 Aug 2026 07:01:01 +0000 Received: by outflank-mailman (input) for mailman id 1381173; Mon, 03 Aug 2026 07:01:00 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmfT-00033B-UE for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:01:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmfS-00Dx1a-QZ for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:00:58 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a703caa-2eae-0a2a0a5409dd-0a2a450adc84-0 for ; Mon, 03 Aug 2026 09:00:58 +0200 Received: from [148.163.143.241] (helo=mx0b-00498f03.pphosted.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a703ca9-f2d2-0a2a450a0019-94a38ff133c2-3 for ; Mon, 03 Aug 2026 09:00:58 +0200 Received: from pps.filterd (m0384717.ppops.net [127.0.0.1]) by mx0b-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6733QXrI149205 for ; Mon, 3 Aug 2026 07:00:57 GMT Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11011054.outbound.protection.outlook.com [40.93.194.54]) by mx0b-00498f03.pphosted.com (PPS) with ESMTPS id 4ftk39s1kx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Mon, 03 Aug 2026 07:00:56 +0000 (GMT) Received: from SJ0PR05CA0088.namprd05.prod.outlook.com (2603:10b6:a03:332::33) by BLAPR16MB3841.namprd16.prod.outlook.com (2603:10b6:208:273::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Mon, 3 Aug 2026 07:00:53 +0000 Received: from SJ5PEPF00000209.namprd05.prod.outlook.com (2603:10b6:a03:332:cafe::1c) by SJ0PR05CA0088.outlook.office365.com (2603:10b6:a03:332::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.15 via Frontend Transport; Mon, 3 Aug 2026 07:00:52 +0000 Received: from mx0a-00498f04.pphosted.com (205.220.161.53) by SJ5PEPF00000209.mail.protection.outlook.com (10.167.244.42) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Mon, 3 Aug 2026 07:00:52 +0000 Received: from pps.filterd (m0373460.ppops.net [127.0.0.1]) by mx0a-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6736LXdY2591096 for ; Mon, 3 Aug 2026 03:00:52 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-usw.ser.proofpoint.com [34.209.42.160]) by mx0a-00498f04.pphosted.com (PPS) with ESMTPS id 4ft1nxh7qg-32 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 03:00:51 -0400 (EDT) Received: from localhost ([19.12.76.221]) by cmsmtp with ESMTPSA id qmfJwsqcfRF75qmfKwf87h; Mon, 03 Aug 2026 07:00:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=ppford; bh=637qawqkKAH9vcNugWaXYQ4sA GQBt8YEUgWFoGQ/vj0=; b=qMnSivLpmkhYDuJeVtC3MCiryoFEoDpkmcUUJ5Pb8 X+lYoE80E5albeoEcF1qBrTwtNAQLypYK9g15oqa6XxKu2r0Xbgnn6h+XpibwHBl 4hYgZ1lejTbFETQPQ+zqlHnqMRlm5C/zlIiHS3+DMeE/13zlfpfKuAns2Uzs/3SZ iKullN9I+Mt2zeRRhURZ6Zpt5im/cQkqTTRjWj8rJyv65PTazjYIcKJFQjq6Oovk NQ0aOCpspD7F/xRvOO05eBUu8eTuGDCiFQl34RsW5ZghhetVUeF4Bgr8Ae85Tb7h C4e/NPN37BQYVFTOMeI43h5Q1pBD154hGn640e1YxXiww== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LWz2JGHfO8Ch4PUezlPkNu8kcyAj7DiwwSFA5zDRQdVtHPOdo7q9RhCZ4h2keAwU/HgFQiBG0aqwPobBa/zW3tsfYutHy2Nbz8vdeVL8o62WaVKWyJ2vgduCDHsSt9X0eaLxzlsbLYuhWgj/9jFAN+uGkTCo2Sn8ewruVLDmL8aA1EYqI5KRCuWJ9hr0Nu57faDMPArfMb2yvsGmyOyY6TohCGc4TkqCZM3hAdBObn2LA4lZmCSq020g06vg8aHCAkeSUIg+KIVYDe12H5FNJagEuoDCHEqfpdbHPHpvH4J4jomtuLBQflmDo/JuKmMa8Y9BjuNW4BXRkpPl+wkZIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=637qawqkKAH9vcNugWaXYQ4sAGQBt8YEUgWFoGQ/vj0=; b=VTr64Or6ziZvxdfHLdiAuro/t15yEAH/yexB5cu9OfBO9lc1xK3a/aDQBEb5aSDT7L6XfbFIx81gtwYqNcRxzvjurm1W1jS7MMP5je5JFsFFEZy+qfJ68BfMznNccA1QC8A+JLTmwinLVR5RmdyJLYJhPrVPx7UOWnsm1Ds7mHB/KIB+1jMTnwEFbV4cLXBLOv94rEGY8eTYw1m6mc3l8Hs6dcmLUEpEu9FEVS9nbU/Cvxny/ECKQfPvI4YOvj8l5DBgg2FKU5X7mVBxVlJ9jcr91JT9U99OV1UwhozvWY0t5A13ohlSAyCUVu67TNcmsMndGo3Ttsuf+0nuyNsdWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 205.220.161.53) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=637qawqkKAH9vcNugWaXYQ4sAGQBt8YEUgWFoGQ/vj0=; b=VKgg6OQZ0FepEyu0Wmy0yD9Lnn8Mv5HnEJ7Ggnh13cuXynTJX76IoLKJy37jIyaGglWWCw951p7H9Ky90uk1BrIkJgO/B1y9pux/Xyr/34qoKdIdIrLt76UW98LbJeZT3iwZV3ZgdAhGdrCL1cDMkwLAdRqJC3Blta0atiChPRs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 205.220.161.53) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 205.220.161.53 as permitted sender) receiver=protection.outlook.com; client-ip=205.220.161.53; helo=mx0a-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to; s=ppserprodsaar; bh=637qawq kKAH9vcNugWaXYQ4sAGQBt8YEUgWFoGQ/vj0=; b=QEb/6HrS3F/91wV1tyGLW7z kxGwSUq2LYtN4ozp8tTpRRJ4aycbRTjPQkntHN6ht7POhLA7NiEQkErDovJ6v2iV MejAOobu9GC2CARydr6Q67edVS9wxvD717HA9aMwUGSRgxB9nqJtgk5OOw5Nq8Ab XqV91BgJVusHonmENFYyY2UrhME/VO2vqmwpWVWpZWaiYmjnFLqEQjzBjfKzc9bH O7LPnL5+CTKLj5vxzNzZm4EPQQAuy8ml6QwHDJuyrJsPVgb4OZ4mdenW66NGcwZq JxT7Qbw72ZKlpCvRrD5W/4WehGAWP5ECkZ0lwUViQ+ehJRX/JuTGFfqUJqjftJg= = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=ppfserpocford; bh=637qawqkKAH9vcNugWaXYQ4sAGQBt8Y EUgWFoGQ/vj0=; b=MH/V7hm1Zpwy6YelsOGX0bznw8yN54ZqYTUcq+KwVxR93k8 cqIVMZnxrmNJgKCYHqYCvyEQKAnJCRhDAYA5y1pS2eGZhWQCz2K0n61juVeG8R/r gGVCarTSum9ill0rUWQLe/1dSvSyctyo8jzbxueapO8TB781tkqBL50cF5k//RRY 8lkcP55Lxaj1sTqt+cv1x0O3d+i2FwjtmzITD7X7LKWRb+X/hAdjrJLo1dAHHTBn Oqu4Fb5vpAW5y5dSLPS3tUqU3FLxTUIjmfOPiElhmpiy49s3bd5r2moAefua3GTB 7OKre2CVKsH6TtKLqMfulHDzU83NwCMu756sOFA== X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: qmfJwsqcfRF75qmfKwf87h X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v2 0/2] keyhandler to show Xen command line Date: Mon, 3 Aug 2026 00:00:45 -0700 Message-ID: <20260803070047.3097846-1-dmukhin@ford.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030060 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000209:EE_|BLAPR16MB3841:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 54a73456-2eab-4627-333d-08def12cf4f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|23010399003|376014|36860700016|56012099006|11063799006|10067099003|18002099003; X-Microsoft-Antispam-Message-Info: sU0HEe6X2AcWxJgu2JgvLTZKpfyrhBmbsfmLj34c/W6NVBSpW44PlfuQkP2dYeKbFXJ8KhYqWPB3D+Em04rEsn84XvFWSK3KWRAB3+JZyiYNDSe07BEy1SRB4jWUF9d+a4Sbjb0Ztm/JR/xSUXWRD6a2nMOhtCYNW/iTVCoFCW5RwGBma7A1M/dGQijhbHahWn8dVij10M/MQgEWxh/urXzH0vDZs+30roZMR+Ej7dtoRKcVzJZXrfR3Y9dSu/zrVQoVdCX3RSYaaTP/Ka/J9yTCigOQWbXRsjvNiPMAvX0Va7j3WOx59Uy9+Lbu12ZKXCGTehM/9Xk1Dpi8l0HHWXOwjFyj0rIImTDfa0B+bU5V9bG+BuKUIAMMElWCoSeat1mQGqQtWPK2UScZJrdmeoenU/cXYV0CzNcCV6FkjDqNK/ODNokAc6xU2OD98XG0PGOPRyQJQKn/F+85YyXvL9/QLEBWQtkiOtc0hKor3oESLPVfy8fp/SN35JrIe3E9xsVuwsn7tFr86jNIZ+4VhB17D/njK4SUTUs/omYvxl3dQ27QyGGL34oOV72hLu1W7z62K4aJdKxegmOfsrxkhvB9bshGRarNppG03bcni+/0XaqUaJfObLd+9yqID71eilUcAwQPtvfjhELzd8yME71qv1zaiBr0gPkCEO8ymlTfJoETENEEP8NHj7uuZ2VzvjjHzrhxBUUSRMzJpXW8DQ== X-Forefront-Antispam-Report: CIP:205.220.161.53;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0a-00498f04.pphosted.com;PTR:mx0a-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(23010399003)(376014)(36860700016)(56012099006)(11063799006)(10067099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kG0WTJ1Kbk+sHDq+xXUFc7Eyqj8LddjDgg487DMaqgJTmalkyTPhwnKta2CQrRbaEwRYXx13JfBxj9JsJ8OiN/O+DGJ9Lul5hDyjTqd6T+Q+iJn594A/RdPT7dO3wMXlAisE0YnzTYERUJZxA6w8Y0Gg0xIepvuCgoYwiCuGEqv1M/5faC/mmbYSMLUSZq4fuEuZOkOz2GYaAoJSAM9bq/NSONa63CQMftN+q4yw6YUZDDgpKYttLulhq8R/LWPXZP6kVhsrK/98QYCdgrY71J76ACKncw/ifXdb/MApkDOscrjLcPyF3VCRL+FgSBbNNdiH9BBpYgM76cczvFs/NL51xruiHOUOYEMx2bBgkTQi2tuDDasz603yFEfJGH0y65HvEecKatX2cYU5b1lplNNHwFni7Q6ZC/+I3+DkVKcLsUtnOs69lRAY0ZCjLPvy X-Exchange-RoutingPolicyChecked: d7YCDhtlYw58/DBF8AvJ9H5GxXUVKvU9G2e0mD/JB0wfbnuk+yPXxziTAxkq9qSB+jZKFFANe750TGvzJS8rIkOpllCrgSTw5ojbr7cG1COpotiBalCk8byG55w3BssWlGZjvawjKmdWN+TqXY5PUQGYDpHSvGnMkuupU9NHwXEYpwLCSu0ZVvRaZv4/pIwHxrqgGOTftRqB2M151epclYlQFn6Dca7DBzYM7O+qgQwtgaRBux8syG5PdXApVZs+JM+VJtcOXck/yJZ0szp+bwur2kcWd/84Wz/Un/ZYdZ/I54mIvftq9uZtm3QyLjDAKcFgC6U/VlVK2nwAzvPiaQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Z1SFw6rNL/S/uQ2IjjYv4d3xL5U90U9eZv/LdKf9H3cR+NNiOsb2SOrZa7n2Ap5xnRXgbJEkD/krlURBRjiBsyT3tQXEP7+xtAx+O0aIcR4vR8npPEEryWPdprh9TfF2c1IYCUYIUiz9JhUtjaSUH2MzsugxkdKL9X8Njoszbf2opLm+BwNQvW7Xs/VwBAt3hKcBo0Hpfj9JQyuxs5tLd9YEbk4e7c8bhbjSKsI5yDSOUxgRdtR67Rk6Mal5n24W1GqZMD7Is6yzj9t9FfJkuAeoioswoApr5V+44jhLx1MKqwr6vOVEbuuo1/w/MIx1IdkBl69rpJnCxih7lIYcsPTYCjhzreZ9mS9LCkDfBqtQGX3y7YeScdn87C6tNYUCBXVcm81oBOnoknGBNKMk4UkAPJO6h5A/ad8zGWeK+OcKookY5/flfDV2SdiTogD8qcpKi60I3BdRO1G4pkJefoSJ0I02op3TuLAwLvEeRmsCb66Da0nvGK53oDvmUeX2nbKUIh1KoDRAjgGqp5s1zlDUlhfZy6rwAlbQhabqV1xW45JSDn3w//y9oQs5IUCXPimFeVK8lgLhobZYwV3B6iu2fuqtw1a9szSBdEWAuWzCifb9fuMuqFkPDYTudxel X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 07:00:52.2902 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54a73456-2eab-4627-333d-08def12cf4f6 X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[205.220.161.53];Helo=[mx0a-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000209.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR16MB3841 X-Proofpoint-GUID: MJKzfB-LFmGf4YebNhJXxBzE8pdONy7D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDA2MCBTYWx0ZWRfX2YAVF98R3+s0 TUSHxVZsuMCAfKHW6jNkRwofe5NnDjkDAlXLf/Z6ufFn5Ck0ri+0laY/BqtF27iJ3Rw5C+XR/yK LgfLd0ykOpD7eTV3rQcgYrEDjdP+UBWSNbduuNRveodDiuH5tVwUPkLAqjGmTPxU6siwlmHinzc S9lLEvVkidjmywH1xnVHI5fVBj6qZK3W+VkwWbOLFTON2WmAQrGiBSHWNDxr76fRuDihXtzJBTm 57sdW86PZEe2IxX01CocymsqGiTu68vbvfRsQE/QKwD0PkZis2mlmbjJ8qqIn+z5elLO8WcqtGX +sVYdFBEyGCb+AEH7ieOqd80OF4q3DJJFnP1njtr53sQqQJCVBIpzj7IdySCmx29Sm0tNrLW0Ff RPd3PEqM+pyIpXsoVaLj+vcBtImTzaBJ4SdIG7V1NwmjKZm/mfDpK9j0StcFhm/yH1vW6F/6tZL cP0gmOWp4kQAhMiye8Q== X-Proofpoint-ORIG-GUID: MJKzfB-LFmGf4YebNhJXxBzE8pdONy7D X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDA2MCBTYWx0ZWRfX158QcP5YM1Zq 62lZdoM8UVyzklKqXrqL/0cMympt531OeGeGMD0MIfPYHzHgN+InD7kRek6W/B190m+WnOLfHea H07xRLr7I5qVfDsfYzKmQMLdL9ad00yN8ubmcRjzNVVP45zst6yO X-Authority-Analysis: v=2.4 cv=doPrzVg4 c=1 sm=1 tr=0 ts=6a703ca8 cx=c_pps a=cVuenkWoTzwZy9czxFkdkA==:117 a=lOEMawUel/sSvQipkIvNbg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=AHe91QgOk3R4nFVtG5At:22 a=p0WdMEafAAAA:8 a=Xf6Qf7mQbR-3ao5nFTAA:9 a=P0bj-C3X3jJDpopQwM1U:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030060 X-purgate-ID: tlsNG-4011c0/1785740458-518C5CFC-B72DB72C/0/0 X-purgate-type: clean X-purgate-size: 429 Tiny series which adds new 'X' keyhandler to show Xen command line to help debugging the system. CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2723312941 Denis Mukhin (2): xen/common: annotate saved_cmdline with __ro_after_init xen/common: add keyhandler to show Xen command line xen/common/kernel.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:01:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381174.1624737 (Exim 4.92) (envelope-from ) id 1wqmfa-0003Iz-Lm; Mon, 03 Aug 2026 07:01:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381174.1624737; Mon, 03 Aug 2026 07:01:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmfa-0003Is-I7; Mon, 03 Aug 2026 07:01:06 +0000 Received: by outflank-mailman (input) for mailman id 1381174; Mon, 03 Aug 2026 07:01:05 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmfZ-0003Ic-EB for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:01:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmfY-00A7ql-Qq for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:01:04 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a703caa-e002-0a2a0a5209dd-0a2a4503be26-28 for ; Mon, 03 Aug 2026 09:01:04 +0200 Received: from [148.163.146.23] (helo=mx0a-00498f03.pphosted.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a703caf-fae8-0a2a45030019-94a392174b60-3 for ; Mon, 03 Aug 2026 09:01:04 +0200 Received: from pps.filterd (m0367123.ppops.net [127.0.0.1]) by mx0a-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6736XQ1h3932701 for ; Mon, 3 Aug 2026 07:01:02 GMT Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012012.outbound.protection.outlook.com [52.101.48.12]) by mx0a-00498f03.pphosted.com (PPS) with ESMTPS id 4fswuhw3xk-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Mon, 03 Aug 2026 07:01:02 +0000 (GMT) Received: from CH2PR11CA0030.namprd11.prod.outlook.com (2603:10b6:610:54::40) by IA0PR16MB5548.namprd16.prod.outlook.com (2603:10b6:208:493::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.17; Mon, 3 Aug 2026 07:00:59 +0000 Received: from DS3PEPF000099DB.namprd04.prod.outlook.com (2603:10b6:610:54:cafe::e) by CH2PR11CA0030.outlook.office365.com (2603:10b6:610:54::40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.18 via Frontend Transport; Mon, 3 Aug 2026 07:00:59 +0000 Received: from mx0b-00498f04.pphosted.com (148.163.138.245) by DS3PEPF000099DB.mail.protection.outlook.com (10.167.17.197) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Mon, 3 Aug 2026 07:00:58 +0000 Received: from pps.filterd (m0426315.ppops.net [127.0.0.1]) by mx0b-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6736xJfM3670003 for ; Mon, 3 Aug 2026 03:00:58 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-usw.ser.proofpoint.com [50.112.124.217]) by mx0b-00498f04.pphosted.com (PPS) with ESMTPS id 4ft2pt14kv-2 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 03:00:57 -0400 (EDT) Received: from localhost ([19.12.76.222]) by cmsmtp with ESMTPSA id qmfPwSXo1JrM7qmfPwfgOJ; Mon, 03 Aug 2026 07:00:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=ppford; bh=vzj SlYxWBpGdDqVv+pIg3kuEssbNQ05qwEZxS4CT5kE=; b=OHMoeNqraqd7gRDrOY/ hxnKpNCBlqzMbxHTCg7nx8WZisTuddCc/mUOkzCqVIhhKeGyG0dgl48pPQSBJrdJ 1uO6kKT8JMr4DzNBdAYjfQdWkmDoajU+UAIZjUNV3kJF4ETX04ocgn/5imcNcpsv XKoQ+S88Ok051ZsWaEobTHa4h0kr3hld2HBvJyRfRNeVnxIxbzsgJQxoy+NU67x+ O1opqEUSnIF43zv9uAMdjoS/z0u5Y6p5+mwNLIU6DhOV+J+KWD5PIW1tSmsxIJ5V X5B3LLDlOPXDT4rXaYOKv3GxLUJl+q7UbBvqudfiNUZhYtl1lq+3AOfnyHTbyMWB /Jg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GUIo7bdY1qQ6YbZCsZDxT97QMhOqYo1bj9krhD9KGh0I2AZ1F1PTqSAQwpAOQ/9F5lJTP1cDTQOhCdb2fA4xlnxdQLRSXhcfn3OJ0d4BIJkNvAXXAQ1CX/oO6awOL5nFMOB0X9UhxNAOpNCuTcO5SR5wFrsrSPxKevmdXfKpGavH71RilHBzCkVdwCuAREINfaJslyFGUaRic9xnsfqjqo5eMCHrcT8/DbjEL1Z8VfwbYi3vK+4kE+UA7xAKK0h60JWrlbJ0YZlG16s5JOTiZr/f0j+5WITiAd2khiItL7zuQQAqpBpfNDmXVYkFLS8aUs4Q2DK4BBQDO4vdTfuSFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vzjSlYxWBpGdDqVv+pIg3kuEssbNQ05qwEZxS4CT5kE=; b=hfXziwWO6rJx8Vnujfghd8Fqqr3+XnPN2jd3F7RVlB0tQ1CkdeZYSe4ZMruHbCho3U5MDRxQWnSPzAu6hzdpXm5xTe8lJzljD0uctuG2xDLFLIyopXPGVDh+jNlGVjdWOOryYV1kDfMNTYRjwy2t/Yfi6F8+dEX3KzuTPgBVX+FxRccU/on4pG4HSwyg/sKkKZb4Y++GWjWE1arviU1UGgchnRPEn3seqdZyfDWrdbT8fQlBvapbG/fZI3lFckx3/Y3JPTicMw+uxIthcta7YB0tfzdPiCY65SAAYT4rKDhy9audRN5EJFNA6x9k/Ogi1Hqqrk7E/M7ca0ESNlrd6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vzjSlYxWBpGdDqVv+pIg3kuEssbNQ05qwEZxS4CT5kE=; b=DvYPBylp+/VmyURyxRA0CfuiuGfvDVj3rTDwbBM6JSJpF4UPVgk/9/DaIUHL1Qb3ahdQqmc3J7T4IjvYBZufEiFNnGdk9SiMZC/E6hvMY09mzo8TCF4oO/y3zaOMkmTWshCxa4Z5Feq1tDugKhjpGQOsg40HtBxGCjs4SN9VAAU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 148.163.138.245) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 148.163.138.245 as permitted sender) receiver=protection.outlook.com; client-ip=148.163.138.245; helo=mx0b-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= ppserprodsaar; bh=vzjSlYxWBpGdDqVv+pIg3kuEssbNQ05qwEZxS4CT5kE=; b= B8d03+LmESuJ0GwIXspIFyq5kuqgY712rNetCPjKqvMRZWLVziUbiAaYD24z+HzG zndul9XuXKoC+mOh3wDcaxOmXvlQGFXCL9GuRjd8p1sVXtXRMCRFeVfY20UweLFD MSAX9+97hF+goyqHr+FwhovQnActH66hvm4jlt09yEQ2vbuDx03qwRXVi8D+Rmtv cUXzOr3WoRfL7QQYczFGUkdLyitZGLWshzY4VMyYIodOzGkWDVHXcs74g94ojq7z ouD9v7wpwAZy01San1XAya7FaM4Ln2PlYjljYQrtE9fSvqaDx1DY7Z2Wlo+BuRRK OYpLYaNUTKP41MdQirwyEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=ppfserpocford; bh=vzjSlYx WBpGdDqVv+pIg3kuEssbNQ05qwEZxS4CT5kE=; b=eTsLJq/kLbM4E9hrm5eq+09 q9osCTtjIN2pxRfQtiRNazGYUvZMnzufkk2WvZxzGoycOqIlJ15gqb2Oi+bbDxiq tvly12/sGQXp5ZmA4Aw6CqTvXhmWTUlzDHyam2uAPLRPZ4ykDGUI71K7miOJEo0f Df0MdR7vDzju0Ys9UvzVGGnrsGpbcg8KfRz3rhW9+d97kRpTRdOtkoqeeTXSrbtU 0p4lssNih7ePFSTgb46vqnEBm036SwLNs2JlgqLpjG3Ae/Mf9jDtZmjeOww5VUQh HTNKFtlTuXGqqMx48ufW3o/F/SJwZlStYIS2fzmoszJSv05grD0fvAxnqrmw5bQ= = X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: qmfPwSXo1JrM7qmfPwfgOJ X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v2 2/2] xen/common: add keyhandler to show Xen command line Date: Mon, 3 Aug 2026 00:00:47 -0700 Message-ID: <20260803070047.3097846-3-dmukhin@ford.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260803070047.3097846-1-dmukhin@ford.com> References: <20260803070047.3097846-1-dmukhin@ford.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030060 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DB:EE_|IA0PR16MB5548:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: ecedcf11-c9e6-481c-0823-08def12cf8f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|376014|1800799024|82310400026|10067099003|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: TzGJhZT0cGIVequW9NT2Lhf7qdE41ImTRKgT5boIV9tAG8sYu0MdePzqYs19FGfYyVa6AYZO2haZXP78Sa5yVt3FNTYqYzhmvGrvYgVYzNTjSqj+59IoW1/EOQ/QUZVgVTjKpjnwy40F3OO4555hJXUBjUVtCoITbv3Rnq1nRhaDtyqtIt6SqtcVax1nOugvpD/FPnEMB2vwvdLqY2bCzNAIs8YSu783FgRsdVZs6IFZg5tMBu5lQv4Cxa9LSKPl8L9rhT6Rov3Ass2QgFuG268XIEC9NpwwjCk5P/vhAfBKYogjW8gLJl3gsRAJskcvSyGYV9EK8YyM8PId0pDxlKJOgSqgAjeFjrOPipyQsZDyQyfVD6+DD92YfLHEBaAVieJYH5qlr0GtCoiWYIbbB0AMtX/5j/VoBm+R2kQtNWzSwSxy88Q9U3MDuxDKkp03h4xp6CYk2niC18v1i7KFjA1D+sSbD6UtvPYsKmrDSeNznQpEv9QE4KduyUMhQYx2GSAiNHhYf4l1gNSIreB369Fv9bA/aCwivWHzSZ87JhBB2g71wywY1XI/4WH+OGGO/a/mw6XBm2uuKakltPoRR/P/hUyeL0k1IKE+uAhLo0jBZ6yGIYXbfnuUVchhWwJDLE7lhdqqV0INNjT5OYeu8SKycE/EyKNVCU8shugPe+cpPdEiiy+w2jISBq0IgMTUiMhyU2NfvfOiSCrTIsuDKQ== X-Forefront-Antispam-Report: CIP:148.163.138.245;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0b-00498f04.pphosted.com;PTR:mx0b-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(376014)(1800799024)(82310400026)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Jg8zgoch5brPANMZ3XuHzNy1fLpUReZIYCbON75pDa+W+HPbWRM9rnI+Z3C9BUVfwDL8fIWazA+zzYORYZhyMmQdPluhXWrseZjtojZUU3hb3QGkLNqYOTo9V4yAQaGCs+gDG0ZkRUR1aZ3PNnqQzcniuLdye8keYuecFTbYVIFCPysjHvzyhwANEQ/X2Pju2PNvA4JxB3LA2SR9xk3kj9/LChMLzVAKvZOCDCnguqX1mP7yhSzcNRr4LoA13mZxhCUmGO9lwSNGCwW/pSiNrndAgeF/BWRYP0m+N8gSovdBZDEik8JuBElKw9tFvER+dmDStYTjNDwCTZhflLFcEZFRqtlErs3hr+jz67fZ5ZmjKdUKDAkaUF0BEnqx481dJcd5sHTOFNlCtXqaFy0v0Da7DfO2Sea0jDtmcQ8F6pohd7itooqrHT4NNm9Bv+9+ X-Exchange-RoutingPolicyChecked: PgP1uXEapN1K7iST7kgOhCdbzU3LvVjL22K5HRD1tNSWcb0revrySQGjYNpHB+KoMQmrgufvy1XCvdCs0PfkNuqmFeWoZI2iKNQxtNg5VfjrETMetc2wd3ItJ1MquwppgSmbd7Igz5VEA89WEnQGQZRIlTd37J9cVnFqwidN/HQM3WkSEiQpciMKY1JZUguZ8RJlh+dUeELp4fCC5hu785aBIdlThi2z3hMrNOmi5MgQJJd8bgtE+R8syIszyIVFNUQokWor3kpFZg5bLbE2iFJnMmm9ysIB5kCU7S+ucl0h5hxXKIbICnwfHO6cDu26BfOzAZcM0EpJygJqzxZ07w== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bQugfy34CCvY/z/PRfFDCGp1Mnuqq45wm0MhWgxF/62ue7675Sd+CApshGWEqiRLr4ou0BBZv29Z3zB6t4hGAMylNVY9yWKgJwnQU6poWEkFgX65A3JVndB3eVEa0hxwa+aqaoxpoL4M0QS+zrPeosYrjM6TfSVALSnrYKFcG2AAHDMVMgBtjVc9NJwqrhEylpWZ58bbLyn8fJyaI2ACp7mSLXdpAaSUuK9V58Gv4DmCNT90eBqVZo5tjryEzfVXUaBwlPOVk+2R4QUeR5an3pEmHAGWQw+KzHevpfNbFa++Kwyg5xmO7AMCbrgzFJ30nb8ILP/GcIlEb3yO1oJFkVziwMkcvHNSM+RwoYWOJFE5JPOJ7v8AUfWS/wTzHoPSebBRcvvYuJycjFOL2XSb/i7Ylbzwe/70QmxuO7LZlcl3Nmc+MIB8r1lHlhBurXZwe+kM1hzB1JP1HXtRBX7UOrMujShaH8nPUh46i+Y0K67jg7EnT96UAoFYQ3MFPspNjlIx16dThjIX8OIHBtY925nWbd8KgbK57Os8k25LbfJXkWuXvKB7WYoZykBroKYyDBD9B3dZu+o4M8q8E2BMHxEUcOsMfkj+vWz8NpBOLeGR02XSf1T1EhiJpxihaZQ2 X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 07:00:58.8743 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecedcf11-c9e6-481c-0823-08def12cf8f0 X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[148.163.138.245];Helo=[mx0b-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DB.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR16MB5548 X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDA2MCBTYWx0ZWRfX3CT1Q6fNnpM5 i6KkieIYKoTkv4RO/mgjrg2xy7JCJ+sYOFs3rqOEMRqYNQEUbCejiVNR66JWPKchda8f9SNKblf x/SxsQYUm3sUlG6wldqSmDpxjYDt4MbRkSImuVc5B7qJOPb9MWiO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDA2MCBTYWx0ZWRfX08XMUj3yLEy0 i2LShH2g74tJSN6f876g5O+iUiEDDF+QcwKoVH8i4NnsEZHE4/MqHVMXNXQH0t8QNquw6bBBlWn Urz4P+NCgE1N4Mj4MjQku35+E5Snv3DgiBUHwy3i8SqwptOJBXLm3MgYZshaq+RYYvTNaf1Evnv /Z8t/ME42yexzPIj2zHLul1X3YeOeUTl6GF+z0aS26A8pK+P1Mv1xemofv7ibMmy0s9b9uZgxqW Sp6Gx2CbUGYVMP/9ct2/hj6emH4yKluTO9hHz4doc+NFDzgWO0hsduqThULawP7T7XCMYFem8ka xWkUrMmjFqqvkeaszsXXR8NuFWidQUqiQYFzR97JugxfSRRNnrcMSk0vOv3ROwWEtWRlBEBo9iU T5+OXANSX82Tj0rSv1v9Cd32mbxi/LEK0M3N3FTqgssjFRj0Xnekfnvn4jGN61fn5mWaP/4TcMc HHhGc7LpqWfB+bSvB8Q== X-Proofpoint-GUID: 2Ke1h0DB-RlHEMINttMYzlXeUG1ejo9J X-Proofpoint-ORIG-GUID: 2Ke1h0DB-RlHEMINttMYzlXeUG1ejo9J X-Authority-Analysis: v=2.4 cv=Xc25Co55 c=1 sm=1 tr=0 ts=6a703cae cx=c_pps a=TVJYqPbIpBJCeYGeirASbA==:117 a=b7IhknPlfT0FN1EembXvig==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=N9_n2FxmZfwfyRXvS9-E:22 a=VwQbUJbxAAAA:8 a=cbNQJ9GKAAAA:8 a=IgJ0wlFFhhnA7GDi3u4A:9 a=DqJYxgmhk6moR-_7_KoZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030060 X-purgate-ID: tlsNG-33051d/1785740464-6E0D14E9-684B3292/0/0 X-purgate-type: clean X-purgate-size: 1462 From: Denis Mukhin Currently there's no way to print Xen command line on the emergency console for debugging purposes (e.g. 'xl' is not available in dom0). Add new keyhander 'X' to do command line printout. Signed-off-by: Denis Mukhin --- v1: https://lore.kernel.org/xen-devel/20260730061459.2702672-2-dmukhin@ford.com/ Changes since v1: - moved implementation into kernel.c --- xen/common/kernel.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index d1bef9ac2b2b..9f334c92e3ab 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include @@ -505,6 +506,21 @@ static int __init cf_check param_init(void) __initcall(param_init); #endif +static void cf_check show_hypervisor_info(unsigned char key) +{ + printk("'%c' pressed -> showing hypervisor information\n", key); + printk("Command line: %s\n", saved_cmdline); +} + +static int __init cf_check misc_init(void) +{ + register_keyhandler('X', show_hypervisor_info, + "show hypervisor information", 0); + + return 0; +} +__initcall(misc_init); + static long xenver_varbuf_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { struct xen_varbuf user_str; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:03:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:03:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381197.1624755 (Exim 4.92) (envelope-from ) id 1wqmiF-0004Xu-F5; Mon, 03 Aug 2026 07:03:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381197.1624755; Mon, 03 Aug 2026 07:03:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmiF-0004Xn-AN; Mon, 03 Aug 2026 07:03:51 +0000 Received: by outflank-mailman (input) for mailman id 1381197; Mon, 03 Aug 2026 07:03:49 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmiD-0004Xh-RK for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:03:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmiD-00Dxvj-4A for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:03:49 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a703d4a-bab6-0a2a0a5309dd-0a2a45059f20-38 for ; Mon, 03 Aug 2026 09:03:48 +0200 Received: from [209.85.221.47] (helo=mail-wr1-f47.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a703d54-4cb1-0a2a45050019-d155dd2fc4e5-3 for ; Mon, 03 Aug 2026 09:03:48 +0200 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-4728c12ba97so1523518f8f.0 for ; Mon, 03 Aug 2026 00:03:48 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41d17f2sm33644859f8f.2.2026.08.03.00.03.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 00:03:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785740628; x=1786345428; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QKOmY2KE6KPejC5HiiQ7SG5gdG6x5qoQ/fhwL1B51YE=; b=M44zeSMqprEQeZ21Eom2rgZ62YOmWYCX7nAAPzLJ27aC9FMcs0qAsaOw8+/Ygq4zmh yzOtLnOL3MsUQgYKoeFN3XBsk/edniqZriAG1FqdXd9FHPK+EE+oJR5oRlF5Q0wdiapF ZMx2Id8StPsFL90hSiosHKSzLtpcCid8p+VDKaGadObDHdfz6aD42fTy3C3GnzpgnLAb WFhyZqG5ky3D6ffBkFfP8yS22C36fmKbGoTsVP6CYfPxmC2/3JgurENeltB8gblYaiiS bECsqMitb81Za3kkFLLhhsan6Wp+IaJtOucoHC8usa0PTm/pVhWrtelxyYExLUsi7OID AbKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785740628; x=1786345428; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QKOmY2KE6KPejC5HiiQ7SG5gdG6x5qoQ/fhwL1B51YE=; b=d0m531XCsdzfIv9JPiSXwRpBrp+lxUh3uCROUBZ4mcpJlw1ItMVaGMANLgkt2pG6MO i90lUI3zowXYxCIXrg5Ovz+WehL6/72fO50NTigfjl2Dtkc+ROjBZiggPnNPYWuE662e NtKH6vRckscnNLY2IzKTo2yiF3FymMlOkjydwnDgSkr764YdNg/HarDVjGrtxdHdan1+ CUwOU9hRzOjl7P5g3USit0kPLAho5GSX2UQRFGLWWHNwb3b/wnB6rLC4ClO5X7e9Iyjc F32fvZfp/Yws2GhgfhmkY/izoVmvJddUd7Q3ce7k8QnvDIJLK1sLr2Em1ChPbWzRRfU7 46yg== X-Forwarded-Encrypted: i=1; AHgh+Rrpqdnl2d73ppgBT4OhYNW7qxtzg3uLLKneLOIw3+6HMsnMRdZ15/TmnHM/Tr2DK+RILdr8+QIQdPc=@lists.xenproject.org X-Gm-Message-State: AOJu0YzMb/NMyjioAYoaOi6ujsfkB0RXH2xVXVfTQ5wTb7RO1XsQAM/p 9D7mL5L7rnno8Qcl3aXwVy1YtJLHJEX/gteScafpqra5oU5hSHXfm3al39jCQpAOHQ== X-Gm-Gg: AR+sD12N+hXUw3f+pBLN1f0uiWUFNn865OR07lwFqXW/nm2FPghCdLdlaedZqNL9XFq 3WQknL7hXd2lPdH/38P7ox+P1NWf32R0sr900ICf7LBNtbDSUkAUtHHze8cA+GumIn/v9wbQu49 a7ufwNFBnEPy6lZDNRKPxbTsXN72T9GIKiaVRcZ35HoXiShVpH7InQMIZyN9SKb1By19RwYg1ef YqV2c1hZ1745QcLxiPEFQkfFEAAx0zCzWrM3bxf34dj2/nMEjWdqdWUIH9LNvHi5/8R5FiXDb7N gNDiwMU2aBIjuk4BQ3/m9+Pj/G7j0GCyhF59N1rfVak76lggX02J5gjr8CeHJmzq8VnKfxzw0U8 VB8H1ZxeVa2g3kyW6LqEOjkD1oKrJDIUfSBuD+HqhALqfgRdc4pxbCCxW51xxwb8msaPUzWpUzA sVTgswqoNusByXS/2GAAZLlrPSrZfUwp5SMi8+i6Yx0smcIV9/LlfHP2LicMTdeSF9mYrTvfvSU GIj3HWx8Qba2qCf4aIjYgPQMKGDWu+6Lc5k51jnfNEX9yDN0jbIGXHC+phDrwYB X-Received: by 2002:a05:6000:2a8a:b0:47f:95e8:2ebf with SMTP id ffacd0b85a97d-47fd72a5db8mr18316947f8f.12.1785740628030; Mon, 03 Aug 2026 00:03:48 -0700 (PDT) Message-ID: <9d594e54-6409-4554-b555-d6de55e85840@suse.com> Date: Mon, 3 Aug 2026 09:03:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] xen/common: annotate saved_cmdline with __ro_after_init To: dmukhin@ford.com Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, xen-devel@lists.xenproject.org References: <20260803070047.3097846-1-dmukhin@ford.com> <20260803070047.3097846-2-dmukhin@ford.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260803070047.3097846-2-dmukhin@ford.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1785740628-722AB2A1-183040C2/0/0 X-purgate-type: clean X-purgate-size: 420 On 03.08.2026 09:00, dmukhin@ford.com wrote: > From: Denis Mukhin > > The hypervisor command line is not modified after initialization. > Annotate saved_cmdline with __ro_after_init to place it in the > dedicated read-only-after-init section. > > Suggested-by: Jan Beulich > Signed-off-by: Denis Mukhin Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:05:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381204.1624763 (Exim 4.92) (envelope-from ) id 1wqmjP-00052l-MY; Mon, 03 Aug 2026 07:05:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381204.1624763; Mon, 03 Aug 2026 07:05:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmjP-00052d-JE; Mon, 03 Aug 2026 07:05:03 +0000 Received: by outflank-mailman (input) for mailman id 1381204; Mon, 03 Aug 2026 07:05:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmjO-00052T-Is for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:05:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wqmjO-0035os-0W; Mon, 03 Aug 2026 07:05:01 +0000 Received: from [2a02:8012:3a1:0:1c3d:3a3f:6f77:bb54] by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wqmjN-00Gr4G-21; Mon, 03 Aug 2026 07:05:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GRSGqypqbk2k3z4aWHq7GUzYwzK35klZeVSvhyZvPNc=; b=Ty9zn0siBEbLWY4HQB7ljilVUl zaTS8dQlcQcmNOVcT03q9Zo+W48o68nZdie7p112YRjVx8/sKwa4iuxtvG924gZSDD6MwyQfHmurv rmKNrgJKxb8oWIYflUGpsAj/n/3eGYWzbDNvjMtXEZI0xuQ7wJf3efNjahI6vN3H9vWY=; Message-ID: Date: Mon, 3 Aug 2026 08:04:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/arm: Hide PMU feature To: Hirokazu Takahashi , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk References: <20260803004245.693844-1-taka@valinux.co.jp> Content-Language: en-GB From: Julien Grall In-Reply-To: <20260803004245.693844-1-taka@valinux.co.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 03/08/2026 01:42, Hirokazu Takahashi wrote: > On ARMv8.4-A and newer platforms, booting Dom0 Linux with ACPI enabled > causes the domain to probe advanced PMU feature based on system ID > register ID_AA64DFR0_EL1. > > During this probe, Linux accesses PMMIR_EL1, which causes unhandled > register traps and crashes the domain. Merely adding emulation code > for PMMIR_EL1 in Xen is insufficient to fix the issue, as the guest > PMU driver subsequently stalls during its initialization sequence. > > Fix this by explicitly masking PMU capability fields in > create_domain_cpuinfo(). Additionally, preemptively mask other > capability fields to prevent similar potential issues. While I agree Xen doesn't support PMU capability for every guest, I believe we are still allowing to expose the PMU in some cases (see commit dbb948110a "xen: Expose the PMU to the guests"). So we can't simply mask the features. So I think ... > > Fixes: 3669a1cb9598 "xen/arm: create a cpuinfo structure for guest" > Signed-off-by: Hirokazu Takahashi > --- > xen/arch/arm/cpufeature.c | 16 ++++++++++++++++ > xen/arch/arm/include/asm/cpufeature.h | 10 ++++++---- > 2 files changed, 22 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c > index 94d14fb6a9..71d745d3cb 100644 > --- a/xen/arch/arm/cpufeature.c > +++ b/xen/arch/arm/cpufeature.c > @@ -219,8 +219,24 @@ static int __init create_domain_cpuinfo(void) > domain_cpuinfo.isa64.api = 0; > domain_cpuinfo.isa64.gpa = 0; > domain_cpuinfo.isa64.gpi = 0; > + > + /* Hide PMUv3 support as Xen does not support it */ > + domain_cpuinfo.dbg64.pmu_ver = 0; > + domain_cpuinfo.dbg64.mtpmu = 0; > + domain_cpuinfo.dbg64.pmss = 0; ... this section needs to be conditional. > + > + /* Hide SPE, TRBE, BRBE, and Trace Extensions */ > + domain_cpuinfo.dbg64.pms_ver = 0; > + domain_cpuinfo.dbg64.trace_ver = 0; > + domain_cpuinfo.dbg64.trace_filt = 0; > + domain_cpuinfo.dbg64.trace_buffer = 0; > + domain_cpuinfo.dbg64.ext_trc_buff = 0; > + domain_cpuinfo.dbg64.brbe = 0; This section should be fine to unconditionally mask. > #endif > > + /* Hide PMUv1,v2 support as Xen does not support it */ > + domain_cpuinfo.dbg32.perfmon = 0; > + > /* Hide AMU support */ > #ifdef CONFIG_ARM_64 > domain_cpuinfo.pfr64.amu = 0; > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h > index bf902a3970..c92b2651c7 100644 > --- a/xen/arch/arm/include/asm/cpufeature.h > +++ b/xen/arch/arm/include/asm/cpufeature.h > @@ -216,16 +216,18 @@ struct cpuinfo_arm { > unsigned long trace_ver:4; > unsigned long pmu_ver:4; > unsigned long brps:4; > - unsigned long __res0:4; > + unsigned long pmss:4; > unsigned long wrps:4; > - unsigned long __res1:4; > + unsigned long sebep:4; > unsigned long ctx_cmps:4; > unsigned long pms_ver:4; > unsigned long double_lock:4; > unsigned long trace_filt:4; > - unsigned long __res2:4; > + unsigned long trace_buffer:4; > unsigned long mtpmu:4; > - unsigned long __res3:12; > + unsigned long brbe:4; > + unsigned long ext_trc_buff:4; > + unsigned long hpmn0:4; > > /* DFR1 */ > unsigned long __res4:64; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:12:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:12:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381214.1624772 (Exim 4.92) (envelope-from ) id 1wqmqJ-0007i6-Ew; Mon, 03 Aug 2026 07:12:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381214.1624772; Mon, 03 Aug 2026 07:12:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmqJ-0007hz-C9; Mon, 03 Aug 2026 07:12:11 +0000 Received: by outflank-mailman (input) for mailman id 1381214; Mon, 03 Aug 2026 07:12:09 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmqH-0007ht-Q3 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:12:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmqG-001kEi-Lu for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:12:08 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a703f3f-e002-0a2a0a5209dd-0a2a4508a91e-20 for ; Mon, 03 Aug 2026 09:12:08 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a703f47-f659-0a2a45080019-d1558033b8a7-3 for ; Mon, 03 Aug 2026 09:12:07 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so17468615e9.2 for ; Mon, 03 Aug 2026 00:12:07 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-498081a12a3sm304521125e9.8.2026.08.03.00.12.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 00:12:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785741127; x=1786345927; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dYttu9GmNTW+Yd8Ey/akGPCigADcH3aBDJw1ZLxxrHs=; b=Gkh25rRhQDVtyeaJEojMLsDL0BUz1YdhWf7qnOu+u8UJMuhAvWvXbV56DqPY7nujJG Z3xPu0zfS5Vt9Slc7aUO3fPzLmABcKvY4xqq8hb93Rs/TA2I90zSRgKq3BC9ExpzFqgz hsiGuyk6+a6catWjXHaDfRbuGKQP9HYpUyjADlvEOVSec4D/8SXc3Sj0A1oLxc4hYYW6 sGc+qRQuQ0bCGSrhIiuwpweiWBdqrcVVA4hnv1xfAxfD8arKVVMtdt6yziTzGNyoSpbl 0LTC8h2DWIZRDJv/zP+fSwx8bFc/FBR3n9YXuZHFY2BvTqiyTaKP6Y3Via+/2EGCRsfy tmzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785741127; x=1786345927; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dYttu9GmNTW+Yd8Ey/akGPCigADcH3aBDJw1ZLxxrHs=; b=HGty45UN0qOIzCsgZM/fGF8s002igdS6Gao7k92H9A0vvd57ZesIcIQTgnyW1SAOrM CBH2c49h7ZWgNFNIspq2UosOcdfur+q75vRq5fWl2WcJ4Ev6XECKQgpgzwkAuaJExunu qJSv8XVRvkB5FBTLvj+R+5v913rkOp1zRWAdl/l8Xc2HfgK5sppkeU2Tr3W05f8yXD/I g1JODBCk9pGouAVQ4ppDMCD6ez4XwOIySpu2Whu5B4f5iucHCJqnUqimRKZhrdinKrq+ yPa2mtsWJj5Kb0b6JocN1iA/4qq9L8a7yU+wJATNj2tBfFTWGF3VL1b5jIocYp7ESp4M M/gw== X-Forwarded-Encrypted: i=1; AHgh+Rre1dCb8IiaJ72qBD/7luuJTvaogJ52eLe0ivrT+LS0s6nyerQx3BhwqSXyktg5Xe0fD4IAkJYHdxg=@lists.xenproject.org X-Gm-Message-State: AOJu0Ywi0f2NaL1sv7rsZ8fAERWySrbdT3iSDXpbLlm7rei/PUjvLBco tlcnVL9CbV5GosAz5JZ25xAMNPkCpuwR4UWS0MpjQXHbBXS3y0DHIEXMqPKCQbLLrA== X-Gm-Gg: AR+sD11M9TdU+HI72Fx0q48/cpebJ8C0IgiNZyTBoTpxnGSt1VQPG+4C4cJ2LYuL0Go JcgPLpfDpindFTm7r7K8i9mJdiwL6t2yz3jvmf+iIhBFXIifpPjUk7TYmDKoMIZZlMPd1hznG2W iVB5rS5QRM0Iff+og1wIlTzfLGJz7+oq+Fo/zExcKzb5bBZLNqUUq9S0PeMItQz6HIsiCAFOQJC M2Y14iLxWDzwpXAyHNSRakA/WhxOS/UpumPMGa9YbJ4hbkGLJULA3TRgSO4Yaof+3W0j7IFVMV8 Kn+lyQC8UbjVqsDExJyg9gwnBvmndlanpe2/o6bJ5aEbp8nM1Dp+vJBPwKPznbXX2sT6tqdht1G ffi9iAtMcR/1mF9M3qMG/LDp/RwZKlYCMw+j0rnWMr3G7npOzJNI6yjpraoejxmIlkQtpx3uJUn eddbiRFuylGq9iixxguRXjwfZeS9Etl7bKF0W408L6HB7f9Whc1smC18hnWX0wxANspI7ncxuDD zUsD8IPJHkeUxlEzrr+K+5DxadVAQT27JEF6U2qvgA8JK3MiadG X-Received: by 2002:a05:600c:8711:b0:495:52a5:8829 with SMTP id 5b1f17b1804b1-4980c652515mr233174835e9.11.1785741127248; Mon, 03 Aug 2026 00:12:07 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 09:12:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] nSVM: Check injected event consistency To: Abdelkareem Abdelsaamad Cc: andrew.cooper3@citrix.com, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , jason.andryuk@amd.com, xen-devel@lists.xenproject.org, teddy.astie@vates.tech References: <1785247466.8631fc262581453bbf619ec5b2062170.19fa90a823a000e099@vates.tech> <20260731142700.2207713-1-abdelkareem.abdelsaamad@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260731142700.2207713-1-abdelkareem.abdelsaamad@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785741127-CC37587B-7C1ABA6A/0/0 X-purgate-type: clean X-purgate-size: 2052 On 31.07.2026 16:26, Abdelkareem Abdelsaamad wrote: > On 28.07.2026 14:04, Teddy Astie wrote: >> On 16.07.2026 17:41, Abdelkareem Abdelsaamad wrote: >>> --- a/xen/arch/x86/hvm/svm/vmcb.c >>> +++ b/xen/arch/x86/hvm/svm/vmcb.c >>> @@ -320,6 +320,31 @@ void svm_vmcb_dump(const char *from, const struct vmcb_struct *vmcb) >>> svm_dump_sel(" TR", &vmcb->tr); >>> } >>> >>> +static bool is_valid_svm_vmcb_injected_exception_vector( >>> + const struct vmcb_struct *vmcb, uint8_t vmcb_injected_vector) >>> +{ >>> + return ( (vmcb_injected_vector == X86_EXC_DE) || >>> + (vmcb_injected_vector == X86_EXC_DB) || >>> + (vmcb_injected_vector == X86_EXC_BP) || >>> + (vmcb_injected_vector == X86_EXC_OF) || >>> + (vmcb_injected_vector == X86_EXC_BR) || >> >> This particular exception is special. AMD APM states that this event is >> "impossible" if the guest is in 64-bit mode and will cause >> VMEXIT_INVALID in such case. >> >>> If the VMM attempts to inject an event that is impossible for the >> guest mode (e.g., a #BR exception when the guest is in 64-bit mode), the >> event injection will fail and no guest state instructions will be >> executed; VMRUN will immediately exit with an error code of VMEXIT_INVALID. >> >> So this one likely want a additional check for hvm_guest_x86_mode() != >> X86_MODE_64BIT. >> >> It looks like #OF has the same quirk (invalid in 64-bits mode). >> > I agree your point is valid. I will address in V3. >> Though I don't know if any other exception has a similar behavior though. > I have double-checked the APM vOL3(24594—Rev. 3.37—jULY 2025) regarding the > other exception vectors and instructions. Vector 4 (#OF) and vector 5 (#BR) are > unique because their triggering instructions BOUND and INTO are invalid and > disabled in 64-bit mode, making them structurally invalid. Other vectors remain > legal across the other modes. #BR is also used by MPX insns, which are usable from 64-bit mode. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:20:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381227.1624802 (Exim 4.92) (envelope-from ) id 1wqmy8-000254-3m; Mon, 03 Aug 2026 07:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381227.1624802; Mon, 03 Aug 2026 07:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy7-000241-PW; Mon, 03 Aug 2026 07:20:15 +0000 Received: by outflank-mailman (input) for mailman id 1381227; Mon, 03 Aug 2026 07:20:14 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy6-0001jg-4z for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:20:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmy5-003y8B-Hf for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:20:13 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a704126-bab6-0a2a0a5309dd-0a2a4503b0a8-16 for ; Mon, 03 Aug 2026 09:20:13 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70412d-fae8-0a2a45030019-d1558030ec2b-3 for ; Mon, 03 Aug 2026 09:20:13 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4954dff6536so11880315e9.0 for ; Mon, 03 Aug 2026 00:20:13 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b85be7sm254687935e9.2.2026.08.03.00.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 00:20:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785741613; x=1786346413; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gMKVONwVKWbxkNk3T1xy4QQFBmudUjsDlfFhaJQN3QA=; b=OW9ILTgoJECRpkGok21bENgd6gRtTiP29It/wLi0XXLv8hGTGSnZirCFtqhHFvnKr8 EupYblfooM4MTINs46ZYNObtZXSIhpTsjIrlZ3tgAsfodMB8JM+UXfzSB+iDneJVS2AM M93cM4peIfJya3p0K81xcpq1livvj7GBjRfQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785741613; x=1786346413; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gMKVONwVKWbxkNk3T1xy4QQFBmudUjsDlfFhaJQN3QA=; b=lZ6oifkWx02Z7Vp6prfMaz/xnlwf0N7uL63aeLzfmL/g0zVhYce+5lmbOoU9okP03d q+UWENdFw01N1m6h3V2tIBItG69jf2v8eqE/s9quZ+y8pQFG6wITTtAzthu7ilaAta53 CIe34WFxqgVwCfE8kXWJJVYd7rnzz4DCJTtd3zsOb5ZzguG11Q7FgZhDgMVhMEmdbVIH Jw9JAHpAVbpP6qUUB7rT+peq13zVoVs84SXt/o0vsjispVRO+jjsJa4kBXo2A26kNOcz pAL8aUBX/qua9ZSeLptj3/qT7C2om4DZDUw59qtrdCK1HSSAeT/xw7jm9PJqR8VvV5oA f2dQ== X-Gm-Message-State: AOJu0YxLOTmWAVCAh1jXcuhHdWir2pKL/ozh2S4fN30u3Y+s2tNFa2UX vprwfJWDHCEU1kpmn59d+UtepYmUkXA4GF5ban2p+Zx5j5neQS91X/6Ccc/yq3luTS0hR+V/Aix LvMfH X-Gm-Gg: AR+sD11U+JuzZDDXeYaFRe1xeh98XKKkcaEYejJ5kG6YSrItCCrL9wV/WzchxelvL13 vcVSf59s37YxNy1oPdHvVPiMJ7yNDsTXXVIbGlpkF9Y4ZsCGs5CoD2Chsn8XqBCAonBglgXPKhj Ikg1WQd9/S/yiuZ9fEPvVKaRJ0eoNcWwgXhTBkTl1oL0FLgu0utln94AWdAxZ6Kbg8iUiJyjjMd k9MTpEo1ckEk/y1yz5a28q1bWcigwBOTm6D7FMnnpdfmLCfPEYumOhSIQVycqd09SjoJBaIcCWc ZlE5+gOwgXQhC7O1H6ArBcjqvQkAyF8c5bnBVxB1bDDStnYJjxGo2m20kSKw5Jc9qRhMQbH5qKy h925xNP85fxpbXdmep0hLFupnqA1KEY2mOnBacW5vihgEXRjGr7EI793xCY8SLnztkar+LO2j4y p3LKiQDCS7hOVmEf+LX0zcaD69tP726JyOfPIvrkOiVAT/ntcW2kgEgfEKdfbFeOXhDifmgZJnp ArfmmjGmG6CaAU56cAxoNGVJNUIYI9PTeyn8wc= X-Received: by 2002:a05:600c:4ec9:b0:495:62bc:a022 with SMTP id 5b1f17b1804b1-4980c67474amr156128365e9.13.1785741612311; Mon, 03 Aug 2026 00:20:12 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH v3 2/5] tests/x86: Introduce a userspace test harness for x86_decode_lite() Date: Mon, 3 Aug 2026 08:20:03 +0100 Message-Id: <20260803072006.9678-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260803072006.9678-1-andrew.cooper3@citrix.com> References: <20260803072006.9678-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785741613-6F0C94E9-0D410C2D/0/0 X-purgate-type: clean X-purgate-size: 30806 All the interesting behaviour is in insns.S. There are 4 interesting cases; "not an instruction we tolerate", and one we do tolerate, split by no relation, disp8 or disp32. The DECL()/END() macros start and terminate the tests_*[] arrays used by C. Between DECL()/END(), a macro named _ adds an entry into the array, including a name and the length of the instruction according to the assembler, while being as visually unintrusive as possible. Plain labels are ad-hoc and there to aid legibility during disassembly. In a couple of cases, the macro named n (for name) allows for choosing a name manually, and is used for cases where the assembler doesn't like the mnemonic. Clang IAS doesn't like the convience macro, and Binutils of around 2.30 don't like sysexitl or movsxd with a 32bit operand. As it's only Ubuntu 18.04 affected by this, skip building the harness in old environments. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie v3: * Force disable Clang IAS. It doesn't like the _ macro. * Support 32bit builds v2: * New --- tools/tests/Makefile | 1 + tools/tests/x86-decode-lite/.gitignore | 1 + tools/tests/x86-decode-lite/Makefile | 56 ++ tools/tests/x86-decode-lite/insns.S | 703 ++++++++++++++++++++++ tools/tests/x86-decode-lite/macro-magic.h | 62 ++ tools/tests/x86-decode-lite/main.c | 111 ++++ tools/tests/x86-decode-lite/x86-emulate.h | 27 + 7 files changed, 961 insertions(+) create mode 100644 tools/tests/x86-decode-lite/.gitignore create mode 100644 tools/tests/x86-decode-lite/Makefile create mode 100644 tools/tests/x86-decode-lite/insns.S create mode 100644 tools/tests/x86-decode-lite/macro-magic.h create mode 100644 tools/tests/x86-decode-lite/main.c create mode 100644 tools/tests/x86-decode-lite/x86-emulate.h diff --git a/tools/tests/Makefile b/tools/tests/Makefile index fc0ed8091510..ca4f0c707638 100644 --- a/tools/tests/Makefile +++ b/tools/tests/Makefile @@ -14,6 +14,7 @@ SUBDIRS-y += xenstore SUBDIRS-$(CONFIG_X86) += cpu-policy SUBDIRS-$(CONFIG_X86) += tsx +SUBDIRS-$(CONFIG_X86) += x86-decode-lite ifneq ($(clang),y) SUBDIRS-$(CONFIG_X86) += x86_emulator endif diff --git a/tools/tests/x86-decode-lite/.gitignore b/tools/tests/x86-decode-lite/.gitignore new file mode 100644 index 000000000000..e726b493c993 --- /dev/null +++ b/tools/tests/x86-decode-lite/.gitignore @@ -0,0 +1 @@ +test-x86-decode-lite diff --git a/tools/tests/x86-decode-lite/Makefile b/tools/tests/x86-decode-lite/Makefile new file mode 100644 index 000000000000..dc33d5fd173a --- /dev/null +++ b/tools/tests/x86-decode-lite/Makefile @@ -0,0 +1,56 @@ +XEN_ROOT = $(CURDIR)/../../.. +include $(XEN_ROOT)/tools/Rules.mk + +TARGET := + +# Clang IAS doesn't like the convenience macros we use +$(call cc-option-add,CFLAGS,CC,-no-integrated-as) + +# Binutils around 2.30 have mutually exclusive expectations of instruction +# suffix validities compared to later versions. Among the distro we test, +# this only excludes Ubuntu 18.04. +ifeq ($(shell echo 'asm(".code64;sysexitl");' | $(CC) -x c -c -o /dev/null 2>/dev/null - && echo y),y) +TARGET += test-x86-decode-lite +endif + +.PHONY: all +all: $(TARGET) + +.PHONY: run +run: $(TARGET) + ./$< + +.PHONY: clean +clean: + $(RM) -- *.o $(TARGET) $(DEPS_RM) + +.PHONY: distclean +distclean: clean + $(RM) -- *~ + +.PHONY: install +install: all + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)/tests + $(if $(TARGET),$(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN)/tests) + +.PHONY: uninstall +uninstall: + $(RM) -- $(DESTDIR)$(LIBEXEC_BIN)/$(TARGET) + +.PHONY: uninstall +uninstall: + +vpath decode-lite.c $(XEN_ROOT)/xen/arch/x86/x86_emulate + +CFLAGS += $(CFLAGS_xeninclude) -I. -I$(XEN_ROOT)/xen/arch/x86 +CFLAGS += $(APPEND_CFLAGS) + + +LDFLAGS += $(APPEND_LDFLAGS) + +%.o: Makefile + +$(TARGET): main.o insns.o decode-lite.o + $(CC) -o $@ $^ $(LDFLAGS) + +-include $(DEPS_INCLUDE) diff --git a/tools/tests/x86-decode-lite/insns.S b/tools/tests/x86-decode-lite/insns.S new file mode 100644 index 000000000000..8b299cfb594e --- /dev/null +++ b/tools/tests/x86-decode-lite/insns.S @@ -0,0 +1,703 @@ +#include "macro-magic.h" + + .code64 + + .allow_index_reg + + .text + +DECL(tests_rel0) +modrm: + /* Mod=0, Reg=0, RM {0..f} */ + _ add %al, (%rax) + _ add %al, (%rcx) + _ add %al, (%rdx) + _ add %al, (%rbx) + _ add %al, (%rsp) /* SIB */ + /*add %al, (%rbp) RIP --> tests_rel4 */ + _ add %al, (%rsi) + _ add %al, (%rdi) + _ add %al, (%r8) + _ add %al, (%r9) + _ add %al, (%r10) + _ add %al, (%r11) + _ add %al, (%r12) /* SIB */ + /*add %al, (%r13) RIP --> tests_rel4 */ + _ add %al, (%r14) + _ add %al, (%r15) + + /* Mod=1, Reg=0, RM {0..f} */ + _ add %al, 0x01(%rax) + _ add %al, 0x01(%rcx) + _ add %al, 0x01(%rdx) + _ add %al, 0x01(%rbx) + _ add %al, 0x01(%rsp) /* SIB */ + _ add %al, 0x01(%rbp) + _ add %al, 0x01(%rsi) + _ add %al, 0x01(%rdi) + _ add %al, 0x01(%r8) + _ add %al, 0x01(%r9) + _ add %al, 0x01(%r10) + _ add %al, 0x01(%r11) + _ add %al, 0x01(%r12) /* SIB */ + _ add %al, 0x01(%r13) + _ add %al, 0x01(%r14) + _ add %al, 0x01(%r15) + + /* Mod=2, Reg=0, RM {0..f} */ + _ add %al, 0x7f000001(%rax) + _ add %al, 0x7f000001(%rcx) + _ add %al, 0x7f000001(%rdx) + _ add %al, 0x7f000001(%rbx) + _ add %al, 0x7f000001(%rsp) /* SIB */ + _ add %al, 0x7f000001(%rbp) + _ add %al, 0x7f000001(%rsi) + _ add %al, 0x7f000001(%rdi) + _ add %al, 0x7f000001(%r8) + _ add %al, 0x7f000001(%r9) + _ add %al, 0x7f000001(%r10) + _ add %al, 0x7f000001(%r11) + _ add %al, 0x7f000001(%r12) /* SIB */ + _ add %al, 0x7f000001(%r13) + _ add %al, 0x7f000001(%r14) + _ add %al, 0x7f000001(%r15) + + /* Mod=3, Reg=0, RM {0..f} */ + _ add %al, %al + _ add %al, %cl + _ add %al, %dl + _ add %al, %bl + _ add %al, %ah + _ add %al, %ch + _ add %al, %dh + _ add %al, %dl + _ add %al, %r8b + _ add %al, %r9b + _ add %al, %r10b + _ add %al, %r11b + _ add %al, %r12b + _ add %al, %r13b + _ add %al, %r14b + _ add %al, %r15b + +sib: + /* Mod=0, Reg=0, RM=4, SIB S=3, I=0, B {0..f} */ + _ add %al, (%rax, %rax, 8) + _ add %al, (%rcx, %rax, 8) + _ add %al, (%rdx, %rax, 8) + _ add %al, (%rbx, %rax, 8) + _ add %al, (%rsp, %rax, 8) + _ add %al, ( , %rax, 8) /* "none", %rbp encoded with mod=1/2 */ + _ add %al, (%rsi, %rax, 8) + _ add %al, (%rdi, %rax, 8) + _ add %al, (%r8, %rax, 8) + _ add %al, (%r9, %rax, 8) + _ add %al, (%r10, %rax, 8) + _ add %al, (%r11, %rax, 8) + _ add %al, (%r12, %rax, 8) + _ rex.b add %al,(,%rax, 8) /* "none", %r13 encoded with mod=1/2 */ + _ add %al, (%r14, %rax, 8) + _ add %al, (%r15, %rax, 8) + + /* Mod=1, Reg=0, RM=4, SIB S=3, I=0, B {0..f} */ + _ add %al, 0x01(%rax, %rax, 8) + _ add %al, 0x01(%rcx, %rax, 8) + _ add %al, 0x01(%rdx, %rax, 8) + _ add %al, 0x01(%rbx, %rax, 8) + _ add %al, 0x01(%rsp, %rax, 8) + _ add %al, 0x01(%rbp, %rax, 8) + _ add %al, 0x01(%rsi, %rax, 8) + _ add %al, 0x01(%rdi, %rax, 8) + _ add %al, 0x01(%r8, %rax, 8) + _ add %al, 0x01(%r9, %rax, 8) + _ add %al, 0x01(%r10, %rax, 8) + _ add %al, 0x01(%r11, %rax, 8) + _ add %al, 0x01(%r12, %rax, 8) + _ add %al, 0x01(%r13, %rax, 8) + _ add %al, 0x01(%r14, %rax, 8) + _ add %al, 0x01(%r15, %rax, 8) + + /* Mod=2, Reg=0, RM=4, SIB S=3, I=0, B {0..f} */ + _ add %al, 0x7f000001(%rax, %rax, 8) + _ add %al, 0x7f000001(%rcx, %rax, 8) + _ add %al, 0x7f000001(%rdx, %rax, 8) + _ add %al, 0x7f000001(%rbx, %rax, 8) + _ add %al, 0x7f000001(%rsp, %rax, 8) + _ add %al, 0x7f000001(%rbp, %rax, 8) + _ add %al, 0x7f000001(%rsi, %rax, 8) + _ add %al, 0x7f000001(%rdi, %rax, 8) + _ add %al, 0x7f000001(%r8, %rax, 8) + _ add %al, 0x7f000001(%r9, %rax, 8) + _ add %al, 0x7f000001(%r10, %rax, 8) + _ add %al, 0x7f000001(%r11, %rax, 8) + _ add %al, 0x7f000001(%r12, %rax, 8) + _ add %al, 0x7f000001(%r13, %rax, 8) + _ add %al, 0x7f000001(%r14, %rax, 8) + _ add %al, 0x7f000001(%r15, %rax, 8) + + /* Mod=0, Reg=0, RM=4, SIB S=3, I=4, B {0..f} */ + _ add %al, (%rax, %riz, 8) + _ add %al, (%rcx, %riz, 8) + _ add %al, (%rdx, %riz, 8) + _ add %al, (%rbx, %riz, 8) + _ add %al, (%rsp, %riz, 8) + _ add %al, ( , %riz, 8) /* %rbp encoded with mod=1/2 */ + _ add %al, (%rsi, %riz, 8) + _ add %al, (%rdi, %riz, 8) + _ add %al, (%r8, %riz, 8) + _ add %al, (%r9, %riz, 8) + _ add %al, (%r10, %riz, 8) + _ add %al, (%r11, %riz, 8) + _ add %al, (%r12, %riz, 8) + _ rex.b add %al,(,%riz, 8) /* %r13 encoded with mod=1/2 */ + _ add %al, (%r14, %riz, 8) + _ add %al, (%r15, %riz, 8) + + /* Mod=1, Reg=0, RM=4, SIB S=3, I=4, B {0..f} */ + _ add %al, 0x01(%rax, %riz, 8) + _ add %al, 0x01(%rcx, %riz, 8) + _ add %al, 0x01(%rdx, %riz, 8) + _ add %al, 0x01(%rbx, %riz, 8) + _ add %al, 0x01(%rsp, %riz, 8) + _ add %al, 0x01(%rbp, %riz, 8) + _ add %al, 0x01(%rsi, %riz, 8) + _ add %al, 0x01(%rdi, %riz, 8) + _ add %al, 0x01(%r8, %riz, 8) + _ add %al, 0x01(%r9, %riz, 8) + _ add %al, 0x01(%r10, %riz, 8) + _ add %al, 0x01(%r11, %riz, 8) + _ add %al, 0x01(%r12, %riz, 8) + _ add %al, 0x01(%r13, %riz, 8) + _ add %al, 0x01(%r14, %riz, 8) + _ add %al, 0x01(%r15, %riz, 8) + + /* Mod=2, Reg=0, RM=4, SIB S=3, I=4, B {0..f} */ + _ add %al, 0x7f000001(%rax, %riz, 8) + _ add %al, 0x7f000001(%rcx, %riz, 8) + _ add %al, 0x7f000001(%rdx, %riz, 8) + _ add %al, 0x7f000001(%rbx, %riz, 8) + _ add %al, 0x7f000001(%rsp, %riz, 8) + _ add %al, 0x7f000001(%rbp, %riz, 8) + _ add %al, 0x7f000001(%rsi, %riz, 8) + _ add %al, 0x7f000001(%rdi, %riz, 8) + _ add %al, 0x7f000001(%r8, %riz, 8) + _ add %al, 0x7f000001(%r9, %riz, 8) + _ add %al, 0x7f000001(%r10, %riz, 8) + _ add %al, 0x7f000001(%r11, %riz, 8) + _ add %al, 0x7f000001(%r12, %riz, 8) + _ add %al, 0x7f000001(%r13, %riz, 8) + _ add %al, 0x7f000001(%r14, %riz, 8) + _ add %al, 0x7f000001(%r15, %riz, 8) + + .macro alu_ops op + _ \op %al, (%rax) + _ \op %eax, (%rax) + _ \op (%rax), %al + _ \op (%rax), %eax + _ \op $1, %al + _ \op $0x7f000001, %eax + + /* Vary osize on imm fields */ + _ data16 \op $1, %al + _ rex.w \op $1, %al + _ data16 rex.w \op $1, %al + + _ \op $0x7f01, %ax + _ \op $0x7f000001, %rax + _ data16 \op $0x7f000001, %rax + .endm + +onebyte_row_0x: + alu_ops add + alu_ops or + +onebyte_row_1x: + alu_ops adc + alu_ops sbb + +onebyte_row_2x: + alu_ops and + .code32 + _ es nop + .code64 + alu_ops sub + _ cs nop + +onebyte_row_3x: + alu_ops xor + .code32 + _ ss nop + .code64 + alu_ops cmp + _ ds nop + +/* onebyte_row_4x --> rex prefixes */ + +onebyte_row_5x: + _ push %rax + _ push %rcx + _ push %rdx + _ push %rbx + _ push %rsp + _ push %rbp + _ push %rsi + _ push %rdi + _ pop %rax + _ pop %rcx + _ pop %rdx + _ pop %rbx + _ pop %rsp + _ pop %rbp + _ pop %rsi + _ pop %rdi + +onebyte_row_6x: + /*pusha,popa,bound --> not supported */ + _ movsxd (%rax), %eax + _ movslq (%rax), %rax + _ fs nop + _ gs nop + _ data16 nop + /* addr32 --> not supported */ + _ pushq $0x7f000001 + _ pushw $0x7f01 + _ rex.w pushq $0x7f000001 + _ imul $0x7f01, %ax, %ax + _ imul $0x7f000001, %eax, %eax + _ imul $0x7f000001, %rax, %rax + _ pushq $0 + _ pushw $0 + _ rex.w pushq $0 + _ imul $0, %ax, %ax + _ imul $0, %eax, %eax + _ imul $0, %rax, %rax + _ insb + _ insw + _ insl + _ outsb + _ outsw + _ outsl + +/* onebyte_row_7x: --> Jcc disp8 */ + +onebyte_row_8x: + _ add $0, %cl /* Grp1 */ + _ data16 add $0, %cl + _ rex.w add $0, %cl + _ add $0x7f01, %cx + _ add $0x7f000001, %ecx + _ add $0x7f000001, %rcx + _ add $0, %cx + _ add $0, %ecx + _ add $0, %rcx + _ test %cl, %cl + _ test %ecx, %ecx + _ xchg %cl, %cl + _ xchg %ecx, %ecx + _ mov %cl, (%rax) + _ mov %ecx, (%rax) + _ mov (%rax), %cl + _ mov (%rax), %ecx + _ mov %cs, (%rax) + _ lea (%rax), %eax + _ mov (%rax), %cs + /*pop mem --> Grp1a, Not supported (XOP prefix adjacent) */ + +onebyte_row_9x: + _ nop + _ pause + _ xchg %ax, %ax + _ xchg %eax, %eax + _ xchg %rax, %rax + _ rex.w xchg %rax, %rax + _ cltq + _ cqto + _ wait + _ pushf + _ popf + _ sahf + _ lahf + +onebyte_row_ax: + _ mov 0x8000000000000001, %al + _ mov 0x8000000000000001, %ax + _ mov 0x8000000000000001, %eax + _ mov 0x8000000000000001, %rax + _ mov %al, 0x8000000000000001 + _ mov %ax, 0x8000000000000001 + _ mov %eax, 0x8000000000000001 + _ mov %rax, 0x8000000000000001 + _ movsb + _ movsl + _ cmpsb + _ cmpsl + _ test $0, %al + _ test $0x80000001, %eax + _ test $0x7f000001, %rax + _ stosb + _ stosl + _ lodsb + _ lodsl + _ scasb + _ scasl + +onebyte_row_bx: + _ mov $0, %al + _ mov $0, %cl + _ mov $0x7f01, %ax + _ mov $0x7f01, %cx + _ mov $0x7f000001, %eax + _ mov $0x7f000001, %ecx + _ mov $0x7f00000000000001, %rax + _ mov $0x7f00000000000001, %rcx + +onebyte_row_cx: + _ rol $0, %al /* Grp2 */ + _ rol $0, %ax + _ rol $0, %eax + _ rol $0, %rax + /*ret $0 --> not supported */ + _ ret + /*les,lds --> not supported */ + _ movb $0, (%rax) /* Grp11 */ + _ movw $0, (%rax) + _ movl $0, (%rax) + _ movq $0, (%rax) + /*xbegin (Grp11) --> disp32 */ + /*enter,leave,lretq $0 --> not supported */ + _ lretq + _ int3 + _ int $0 + /*into,iret --> not supported */ + +onebyte_row_dx: + _ rol $1, %al /* Grp2 */ + _ rol $1, %ax + _ rol $1, %eax + _ rol $1, %rax + _ rol %cl, %al + _ rol %cl, %ax + _ rol %cl, %eax + _ rol %cl, %rax + /*aam,aad --> not supported */ + n "udb" .byte 0xd6 + /*xlat,d8...df --> not supported */ + +onebyte_row_ex: + /*loop{ne,e,},jrcxz --> not supported */ + _ in $0, %al + _ in $0, %eax + _ out %al, $0 + _ out %eax, $0 + /*call,jmp --> disp32 */ + /*ljmp --> not supported */ + /*jmp --> disp8 */ + _ in %dx, %al + _ in %dx, %eax + _ out %al, %dx + _ out %eax, %dx + +onebyte_row_fx: + _ lock addb $0, (%rax) + n "icebp" .byte 0xf1 /* icebp */ + _ repne nop + _ repe nop + _ hlt + _ cmc + _ test $0, %cl /* Grp3, /0 has extra Imm{8,} */ + _ not %cl + _ test $0x7f01, %cx + _ not %cx + _ test $0x7f000001, %ecx + _ not %ecx + _ test $0x7f000001, %rcx + _ not %rcx + _ clc + _ stc + _ cli + _ sti + _ cld + _ std + _ inc %cl /* Grp4 */ + _ dec %cl + _ inc %ecx /* Grp5 */ + _ dec %ecx + _ call *(%rax) + _ lcall *(%rax) + _ jmp *(%rax) + _ ljmp *(%rax) + _ push (%rax) + +twobyte_row_0x: + _ sldt (%rax) /* Grp6 */ + _ sgdt (%rax) /* Grp7 */ + _ lar (%rax), %eax + _ lsl (%rax), %eax + _ ud2a + +twobyte_row_1x: + _ prefetchnta (%rax) /* Grp16 (Hint Nop) */ + _ nopl (%rax) + +twobyte_row_2x: + _ mov %cr0, %rax + _ mov %dr0, %rax + _ mov %rax, %cr0 + _ mov %rax, %dr0 + +twobyte_row_3x: + _ wrmsr + _ rdtsc + _ rdmsr + _ rdpmc + +twobyte_row_4x: + _ cmovo (%rax), %eax + _ cmovg (%rax), %eax + +/* twobyte_row_8x: --> Jcc disp32 */ + +twobyte_row_9x: + _ seto (%rax) + _ setg (%rax) + +twobyte_row_ax: + _ push %fs + _ pop %fs + _ cpuid + _ bt %eax, (%rax) + _ shld $0, %ax, (%rax) + _ shld $0, %eax, (%rax) + _ shld $0, %rax, (%rax) + _ shld %cl, %ax, (%rax) + _ shld %cl, %eax, (%rax) + _ shld %cl, %rax, (%rax) + _ push %gs + _ pop %gs + /*rsm --> not supported */ + _ bts %eax, (%rax) + _ shrd $0, %ax, (%rax) + _ shrd $0, %eax, (%rax) + _ shrd $0, %rax, (%rax) + _ shrd %cl, %ax, (%rax) + _ shrd %cl, %eax, (%rax) + _ shrd %cl, %rax, (%rax) + _ fxsave (%rax) /* Grp15 */ + _ imul (%rax), %eax + +twobyte_row_bx: + _ cmpxchg %al, (%rax) + _ cmpxchg %eax, (%rax) + _ lss (%rax), %eax + _ btr %eax, (%rax) + _ lfs (%rax), %eax + _ lgs (%rax), %eax + _ movzbl (%rax), %eax + _ movzwl (%rax), %eax + _ popcnt (%rax), %eax + _ ud1 (%rax), %eax /* Grp10 */ + _ bt $0, %ax /* Grp8 */ + _ bt $0, %eax + _ bt $0, %rax + _ btc %eax, (%rax) + _ bsf (%rax), %eax + _ bsr (%rax), %eax + _ movsbl (%rax), %eax + _ movswl (%rax), %eax + +twobyte_row_cx: + _ xadd %al, (%rax) + _ xadd %eax, (%rax) + _ cmpxchg8b (%rax) /* Grp9 */ + _ bswap %eax + _ bswap %edi + +END(tests_rel0) + +DECL(tests_rel1) +disp8: +1: + _ jo 1b + _ jno 1b + _ jb 1b + _ jae 1b + _ je 1b + _ jne 1b + _ jbe 1b + _ ja 1b + _ js 1b + _ jns 1b + _ jp 1b + _ jnp 1b + _ jl 1b + _ jge 1b + _ jle 1b + _ jg 1b + _ jmp 1b + +disp8_rex: + _ rex.w jo 1b + _ rex.w jno 1b + _ rex.w jb 1b + _ rex.w jae 1b + _ rex.w je 1b + _ rex.w jne 1b + _ rex.w jbe 1b + _ rex.w ja 1b + _ rex.w js 1b + _ rex.w jns 1b + _ rex.w jp 1b + _ rex.w jnp 1b + _ rex.w jl 1b + _ rex.w jge 1b + _ rex.w jle 1b + _ rex.w jg 1b + _ rex.w jmp 1b +END(tests_rel1) + +DECL(tests_rel4) +disp32: + _ call other_section + _ jmp other_section + _ jo other_section + _ jno other_section + _ jb other_section + _ jae other_section + _ je other_section + _ jne other_section + _ jbe other_section + _ ja other_section + _ js other_section + _ jns other_section + _ jp other_section + _ jnp other_section + _ jl other_section + _ jge other_section + _ jle other_section + _ jg other_section + _ xbegin other_section + +disp32_rex: + _ rex.w call other_section + _ rex.w jmp other_section + _ rex.w jo other_section + _ rex.w jno other_section + _ rex.w jb other_section + _ rex.w jae other_section + _ rex.w je other_section + _ rex.w jne other_section + _ rex.w jbe other_section + _ rex.w ja other_section + _ rex.w js other_section + _ rex.w jns other_section + _ rex.w jp other_section + _ rex.w jnp other_section + _ rex.w jl other_section + _ rex.w jge other_section + _ rex.w jle other_section + _ rex.w jg other_section + _ rex.w xbegin other_section + +riprel: + _ add %al, 0(%rip) + _ rex.b add %al, 0(%rip) + + _ addb $1, 0(%rip) + _ rex.b addb $1, 0(%rip) + + _ addl $0x7f000001, 0(%rip) + _ rex.b addl $0x7f000001, 0(%rip) +END(tests_rel4) + +DECL(tests_unsup) + +unsup_prefix: /* Prefixes unimplemented for simplicity. */ + _ vaddpd %zmm0, %zmm0, %zmm0 /* 0x62 EVEX */ + _ addr32 nop /* 0x67 Address size override */ + _ bextr $0, %eax, %eax /* 0x8f XOP */ + _ bextr %eax, %eax, %eax /* 0xc4 VEX3 */ + _ vaddpd %ymm0, %ymm0, %ymm0 /* 0xc5 VEX2 */ + n "jmpabs 0" .byte 0xd5, 0x00, 0xa1, 0x01, 0, 0, 0, 0, 0, 0, 0x80 /* 0xd5 REX2 */ + _ fadds (%rax) /* 0xd8 ... 0xdf ESCAPE (x87) */ + _ femms /* 0x0f,0x0e ... 0x0f 3DNOW */ + +unsup_branch: +1: + _ loopne 1b + _ loope 1b + _ loop 1b + _ jrcxz 1b + +opsize_branch: /* 66-prefixed branches are decoded differently by vendors */ + _ data16 call other_section + _ data16 jmp other_section + _ data16 jo other_section + _ data16 jno other_section + _ data16 jb other_section + _ data16 jae other_section + _ data16 je other_section + _ data16 jne other_section + _ data16 jbe other_section + _ data16 ja other_section + _ data16 js other_section + _ data16 jns other_section + _ data16 jp other_section + _ data16 jnp other_section + _ data16 jl other_section + _ data16 jge other_section + _ data16 jle other_section + _ data16 jg other_section + _ data16 xbegin other_section + +not_64bit: /* Not valid/encodable in 64bit mode */ + .code32 + _ push %es + _ pop %es + _ push %cs + _ push %ss + _ pop %ss + _ push %ds + _ pop %ds + _ daa + _ das + _ aaa + _ aas + _ pusha + _ popa + _ bound %eax, (%eax) + /*arpl %ax, %ax --> movsxd in 64bit mode */ + /* Grp1 */ + _ lcall $-1, $-1 + _ les (%eax), %eax + _ lds (%eax), %eax + _ into + _ aam $0 + _ aad $0 /* Also REX2, also not supported */ + _ ljmp $-1, $-1 + .code64 + +unsup_insn: /* Instructions that would complicated decode, or shouldn't be used */ + _ ret $0 + _ enter $0, $0 + _ leave + _ lretq $0 + _ iretq + _ xlat + _ clts + _ wbinvd + _ syscall + _ sysretl + _ invd + _ sysenter + _ sysexitl + _ rsm + +END(tests_unsup) + + /* This is here to cause jmps to use their disp32 form. */ + .section .text.other_section, "ax", @progbits +other_section: + int3 + + /* Mark this file as not needing executable stacks. */ + .section .note.GNU-stack, "", @progbits diff --git a/tools/tests/x86-decode-lite/macro-magic.h b/tools/tests/x86-decode-lite/macro-magic.h new file mode 100644 index 000000000000..b3c8aae39acd --- /dev/null +++ b/tools/tests/x86-decode-lite/macro-magic.h @@ -0,0 +1,62 @@ +#ifndef X86_DECODE_LITE_LINKAGE_H +#define X86_DECODE_LITE_LINKAGE_H + +#ifdef __i386__ +# define PTR_ALIGN 4 +# define PTR .long +#else +# define PTR_ALIGN 8 +# define PTR .quad +#endif + + +/* Start a 'struct test' array */ +.macro start_arr aname + .pushsection .data.rel.ro.\aname, "aw", @progbits + .globl \aname + .align PTR_ALIGN + .type \aname, STT_OBJECT +\aname: + .popsection + + /* Declare a macro wrapping \aname */ + .macro pushsection_arr + .pushsection .data.rel.ro.\aname, "aw", @progbits + .endm +.endm + +/* Macro 'n' to wrap the metadata of an instruction. Name can be different. */ +.macro n name:req insn:vararg + /* Emit the instruction, with start & end markers. */ +.Ls\@: \insn +.Le\@: + + /* Emit \name as a string. */ + .pushsection .rodata.str1, "aMS", @progbits, 1 +.Ln\@: .asciz "\name" + .popsection + + /* Emit an entry into the array. */ + pushsection_arr + PTR .Ln\@, .Ls\@, .Le\@ - .Ls\@ + .popsection +.endm + +/* Macro '_' where the name is the instruction itself. */ +.macro _ insn:vararg + n "\insn" \insn +.endm + +/* Finish a 'struct test' array */ +.macro finish_arr aname + pushsection_arr + PTR 0, 0, 0 + .size \aname, . - \aname + .popsection + .purgem pushsection_arr +.endm + +#define DECL(aname) start_arr aname +#define END(aname) finish_arr aname + +#endif /* X86_DECODE_LITE_LINKAGE_H */ diff --git a/tools/tests/x86-decode-lite/main.c b/tools/tests/x86-decode-lite/main.c new file mode 100644 index 000000000000..cdae7de8e90e --- /dev/null +++ b/tools/tests/x86-decode-lite/main.c @@ -0,0 +1,111 @@ +/* + * Userspace test harness for x86_decode_lite(). + */ +#include + +#include "x86-emulate.h" + +static unsigned int nr_failures; +#define fail(t, fmt, ...) \ +({ \ + const unsigned char *insn = (t)->ip; \ + \ + nr_failures++; \ + \ + (void)printf(" Fail '%s' [%02x", (t)->name, *insn); \ + for ( unsigned int i = 1; i < (t)->len; i++ ) \ + printf(" %02x", insn[i]); \ + printf("]\n"); \ + \ + (void)printf(fmt, ##__VA_ARGS__); \ +}) + +struct test { + const char *name; + void *ip; + unsigned long len; +}; + +extern const struct test +/* Defined in insns.S, ends with sentinel */ + tests_rel0[], /* No relocatable entry */ + tests_rel1[], /* disp8 */ + tests_rel4[], /* disp32 or RIP-relative */ + tests_unsup[]; /* Unsupported instructions */ + +static inline void run_tests(const struct test *tests, unsigned int rel_sz) +{ + printf("Test rel%u\n", rel_sz); + + for ( unsigned int i = 0; tests[i].name; ++i ) + { + const struct test *t = &tests[i]; + x86_decode_lite_t r; + + /* + * Don't end strictly at t->len. This provides better diagnostics if + * too many bytes end up getting consumed. + */ + r = x86_decode_lite(t->ip, t->ip + /* t->len */ 20); + + if ( r.len == 0 ) + { + fail(t, " Failed to decode instruction\n"); + + if ( r.rel_sz != 0 || r.rel ) + fail(t, " Rel/sz despite no decode\n"); + + continue; + } + + if ( r.len != t->len ) + { + fail(t, " Expected length %lu, got %u\n", + t->len, r.len); + continue; + } + + if ( r.rel_sz != rel_sz ) + { + fail(t, " Expected relocation size %u, got %u\n", + rel_sz, r.rel_sz); + continue; + } + + if ( r.rel_sz && + (r.rel < t->ip || + r.rel > t->ip + t->len || + r.rel + r.rel_sz > t->ip + t->len) ) + { + fail(t, " Rel [%p,+%u) outside insn [%p,+%lu)\n", + r.rel, r.rel_sz, t->ip, t->len); + continue; + } + } +} + +static void run_tests_unsup(const struct test *tests) +{ + printf("Test unsup\n"); + + for ( unsigned int i = 0; tests[i].name; ++i ) + { + const struct test *t = &tests[i]; + x86_decode_lite_t r = x86_decode_lite(t->ip, t->ip + t->len); + + if ( r.len ) + fail(t, " Got len %u\n", r.len); + } +} + +int main(int argc, char **argv) +{ + printf("Tests for x86_decode_lite()\n"); + + run_tests(tests_rel0, 0); + run_tests(tests_rel1, 1); + run_tests(tests_rel4, 4); + run_tests_unsup(tests_unsup); + + return !!nr_failures; +} diff --git a/tools/tests/x86-decode-lite/x86-emulate.h b/tools/tests/x86-decode-lite/x86-emulate.h new file mode 100644 index 000000000000..558dab1b768e --- /dev/null +++ b/tools/tests/x86-decode-lite/x86-emulate.h @@ -0,0 +1,27 @@ +#ifndef X86_EMULATE_H +#define X86_EMULATE_H + +#include +#include +#include +#include +#include + +#include +#include + +#include + +#define ASSERT assert + +#define printk(...) + +#define likely +#define unlikely +#define cf_check +#define init_or_livepatch +#define init_or_livepatch_const + +#include "x86_emulate/x86_emulate.h" + +#endif /* X86_EMULATE_H */ -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:20:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381226.1624795 (Exim 4.92) (envelope-from ) id 1wqmy7-0001zI-Ld; Mon, 03 Aug 2026 07:20:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381226.1624795; Mon, 03 Aug 2026 07:20:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy7-0001yY-Fr; Mon, 03 Aug 2026 07:20:15 +0000 Received: by outflank-mailman (input) for mailman id 1381226; Mon, 03 Aug 2026 07:20:14 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy6-0001jl-7i for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:20:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmy5-003y8B-Km for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:20:13 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a704126-bab6-0a2a0a5309dd-0a2a4503b0a8-20 for ; Mon, 03 Aug 2026 09:20:13 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70412d-fae8-0a2a45030019-d1558034ac3f-3 for ; Mon, 03 Aug 2026 09:20:13 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-495590dde14so16957645e9.0 for ; Mon, 03 Aug 2026 00:20:13 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b85be7sm254687935e9.2.2026.08.03.00.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 00:20:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785741613; x=1786346413; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9oalEqncjdi9YKb26F6ASg1uy+nWQGozZLeLwjudyuk=; b=nXQToXflDY+GL0UfpGRRGa/mTaF3lJrALlJSTIj5pJJp4E1rr6etPaNvXifQYZvDBO pkleLegLT8CnonqfpLkYcpZ3BYoQQ3EFuN34omNUNeG+Y5tmArhhQJK3pdcuB9dBy3L4 +azacdKjGK6mWIgxSvTdUkTfG8dprXzaxbA68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785741613; x=1786346413; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9oalEqncjdi9YKb26F6ASg1uy+nWQGozZLeLwjudyuk=; b=Zv8366P381RA65Bu5vAzw4Il85qRvCGOqGNyPNtZkvJpgpq43aAHWyCAQliUVh7Sni YhuD16OLAXaeRfYXpJi0WlHj5uEII/ygZUp1DHoLVNS6wghot1QdjuwMBsyplwpM0kgN M29Qy6JRAGGX1Pi8/368UmaJWjVbbi2ubMFYf5qjmQO1J7C+25y1V5t8LIpKLPB1CM67 Pnl1phN59vpfq1tJG4Jp0c7AqOi5XP9s+zwRNbMjg7RvlncvVMw6/s5XcZl1LZC8v8/q ceCqrxrgLygKwebPjFK50VNJ1l/wyBgbZarSJuzjsqs9MBosPpPBA/2PS9tJQA/ypPUs akdA== X-Gm-Message-State: AOJu0YzSPvBBCyMuGX1etuv3N23UqWGaEigdgUPhjLFOZJtarKJlcbzU fUZ2PaFfwGFX5fsuvo+wVHoAIUA3KCVSupudGZ2/QcBLdMCOieX4bswIWmrjFoOs0FSle6jwI19 +v+lU9mU= X-Gm-Gg: AR+sD10/X+cB1tbPIjI8aiP1eTsAzEY3/BzenZ9AV72bJ1wgtMyHZVOczP9RDOrDQAN ax36zRNRYhL9SqJHYBXWhav8es2hzVk/znrlrEAFM7zy8Sw3C7FXLZZGPojNfH+U9r7LiroTH5c wKKXG/zlJnpEUHcDMpyY51xK7H+QBF6qE9HBSIumuLQzPdlzY2xnf55iiR2dWIwZawYr6rB9t4v EKOyTOqXUdwIt0kProMIrml0/8I+PFQHnnQvk7+lY2BJnX0u80CQoAANrW3D/RhvDtPXcmPxwDh YJG3Lr0O8OT4Q3O92DQ5iPWh53IMktsSYudVBrLNQbF3PB2wY5KB2Oqt7NO0z0uvsPMmGREsBm8 aMvSkIys8v6Wokhkg+FXr9n2h9IElM29EAzp0/ZA1pBzFrdldTsNy14ERprdhrJNd673UREg5JM bu/JJu0emVB0hNZ5RbGz0SrVexZ6Uh2I7iNPfwrEu8ExeirnES+Bj6LP1Cfx5Ph2bFrPYSD3qyY Yla8wm7LLmkxbPTq0E53vKIvTaKeqQ/o+FghKo= X-Received: by 2002:a05:600c:4685:b0:493:e365:7630 with SMTP id 5b1f17b1804b1-4980eb66053mr147150085e9.14.1785741612890; Mon, 03 Aug 2026 00:20:12 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH v3 3/5] x86/alternative: Walk all replacements during self tests Date: Mon, 3 Aug 2026 08:20:04 +0100 Message-Id: <20260803072006.9678-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260803072006.9678-1-andrew.cooper3@citrix.com> References: <20260803072006.9678-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785741613-758824E9-8A49664C/0/0 X-purgate-type: clean X-purgate-size: 2998 When self tests are active, walk all alternative replacements with x86_decode_lite(). This checks that we can decode all instructions, and also lets us check that disp8's don't leave the replacement block as such a case will definitely malfunction. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie v2: * Rebase over API changes in patch 1 * Use +%lu and drop casts * Swap to CONFIG_SELF_TESTS --- xen/arch/x86/alternative.c | 52 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 5ed0c2672589..fd03147bdd12 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #define MAX_PATCH_LEN (255-1) @@ -586,6 +587,57 @@ static void __init _alternative_instructions(unsigned int what) void __init alternative_instructions(void) { arch_init_ideal_nops(); + + /* + * Walk all replacement instructions with x86_decode_lite(). This checks + * both that we can decode all instructions within the replacement, and + * that any near branch with a disp8 stays within the alternative itself. + */ + if ( IS_ENABLED(CONFIG_SELF_TESTS) ) + { + struct alt_instr *a; + + for ( a = __alt_instructions; + a < __alt_instructions_end; ++a ) + { + void *repl = ALT_REPL_PTR(a); + void *ip = repl, *end = ip + a->repl_len; + + if ( !a->repl_len ) + continue; + + for ( x86_decode_lite_t res; ip < end; ip += res.len ) + { + const int8_t *d8; + const void *target; + + res = x86_decode_lite(ip, end); + + if ( res.len == 0 ) + { + printk("Alt for %ps [%*ph]\n", + ALT_ORIG_PTR(a), a->repl_len, repl); + panic(" Unable to decode instruction at +%lu in alternative\n", + ip - repl); + } + + if ( res.rel_sz != 1 ) + continue; + + d8 = res.rel; + target = ip + res.len + *d8; + + if ( target < repl || target > end ) + { + printk("Alt for %ps [%*ph]\n", + ALT_ORIG_PTR(a), a->repl_len, repl); + panic(" 'JMP/Jcc disp8' at +%lu leaves alternative block\n", + ip - repl); + } + } + } + } + _alternative_instructions(ALT_INSNS); } -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:20:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381228.1624812 (Exim 4.92) (envelope-from ) id 1wqmy8-0002KN-OB; Mon, 03 Aug 2026 07:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381228.1624812; Mon, 03 Aug 2026 07:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy8-0002Jr-F9; Mon, 03 Aug 2026 07:20:16 +0000 Received: by outflank-mailman (input) for mailman id 1381228; Mon, 03 Aug 2026 07:20:15 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy7-0001uR-3K for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:20:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmy6-00Dk99-GY for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:20:14 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70412d-5cb7-0a2a0a5109dd-0a2a45088d92-8 for ; Mon, 03 Aug 2026 09:20:14 +0200 Received: from [209.85.221.46] (helo=mail-wr1-f46.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70412e-f659-0a2a45080019-d155dd2ed828-3 for ; Mon, 03 Aug 2026 09:20:14 +0200 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47fd4ee0b01so1842141f8f.2 for ; Mon, 03 Aug 2026 00:20:14 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b85be7sm254687935e9.2.2026.08.03.00.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 00:20:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785741614; x=1786346414; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=HxkChm6nTI+5JRyuyWipeFtEAkEUxs5crJhjhmOkg8A=; b=mtnOI27/DhL8W/LMMi5Pb25C2MuCzmwBVCnj/1A8w/74wMnlI9QJRLIKuWjdOtDNWZ TpvdMA1Ym0MHFBtW/rvUl1SxJa5nIx2tiF9ekqXmp+mZIuFhlyTZBZyJJ1BWyX9oi8Yj wQcnOdcJPyUdtCM6FuvQqaxMyPWf68EcwkkfU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785741614; x=1786346414; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HxkChm6nTI+5JRyuyWipeFtEAkEUxs5crJhjhmOkg8A=; b=XLy0A+Sd02KCgevNr01X8f4FkldYQoAQvhHMiiOlvz6OHzk99IBKBu8Ib6kr66StV5 fvi6L1Rm2DCLt6LBciNRjHDrUDo4Gehe3pE2vuH7u5Ls4t1KZgPHv/LvC+fTrb7NIRmC wsMyiA+rCPEEEvMSmt3NvUCgwpeeLh7cvM89MfjKaMMnr4G4eEV4ipHICx9PEpc/Se0Y ft8Cp+1JrqA9SP/3QyiEI73PQdHi1uTuWlgEVj8b45huy/6aiDDFn+dZC6aa0hXkK7K1 SnxDP5QbBtoNQye4Co5lA52i13hpP1uN4o1Cx5u9dJyD3vZVGEl69F9tgRjF83fdBIut WjJw== X-Gm-Message-State: AOJu0Yy9hUPVbCXrQ0JISwRLcwanYAyCQ+G//JOXwCS/FzVeucm3m2j/ nH7m90Qo4Lol2bzs8ToPU8KYfUeGEEvRKLRK8k0cBiYutqKarrhTlp7/hS50KEXOsGlRn2wE6PR a0X77oYA= X-Gm-Gg: AR+sD1152/KSo7BQDIqyw2hsgFwZNFwjeI5l3md4uiwfYhmfk7hNODRRRPWcZ/4JLRP oqhvwub9Dkbhs6aCJNoRYb/4zjM3xUCzfVaWDOVXXTESxN4byi7vkhus6yTU9ZleAFwjGEhtQQw v6Z0R+caXC/Xlw7Iwb1lqed/TfDxqp5p9HGH6mscr9zgKKTGK5hzN6/llgWbBLOmPbCTRU8mWF6 QBATqGZJgIaHqtt2gcXxI9mncRNGqmO2MqRxb/P0sueUlVXdIztt+3FT1JRo0rwbx9czoVGnEft 2+1vDXHvV5fqy1ArgaophwS4tEDvMU9bDt7elWIesCCIlvaHSiZvol2bduFQpHM6yqxLhYQHSS+ TpSSc4XF2fj9mu7MyS15V2jrvk2RAF5OhW48cYPhpMVS6s6e+S/uUSR0BvR23mYYTPTOU5uDnEp +N9z693E4LMo2glLveZi7aZR4+JsHd7fpJUiqln24rrFz0yOTYaAlwGgw36C6gUtebyDIxElbPJ 3Fd8OhPnBtQRbeqIhJeNrQuBaOD/eSXSC77WBs= X-Received: by 2002:a05:600d:640f:20b0:495:503f:cf9a with SMTP id 5b1f17b1804b1-4980c672adbmr145404915e9.9.1785741613604; Mon, 03 Aug 2026 00:20:13 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH v3 4/5] x86/alternative: Relocate all insn-relative fields Date: Mon, 3 Aug 2026 08:20:05 +0100 Message-Id: <20260803072006.9678-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260803072006.9678-1-andrew.cooper3@citrix.com> References: <20260803072006.9678-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785741614-CD54C87B-DC0C22F6/0/0 X-purgate-type: clean X-purgate-size: 3035 Right now, relocation of displacements is restricted to finding 0xe8/e9 as the first byte of the replacement, but this is overly restrictive. Use x86_decode_lite() to find and adjust all insn-relative fields. As with disp8's not leaving the replacemnet block, some disp32's don't either. e.g. the RSB stuffing loop. These stay unmodified. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie v3: * Rebase over the split-out of altcall. Substantially simpler. --- xen/arch/x86/alternative.c | 50 +++++++++++++++++++++++++++++++------- 1 file changed, 41 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index fd03147bdd12..a4a65597b2fc 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -349,15 +349,47 @@ static int init_or_livepatch _apply_alternatives(struct alt_instr *start, memcpy(buf, repl, a->repl_len); - /* 0xe8/0xe9 are relative branches; fix the offset. */ - if ( a->repl_len >= 5 && (*buf & 0xfe) == 0xe8 ) - *(int32_t *)(buf + 1) += repl - orig; - else if ( IS_ENABLED(CONFIG_RETURN_THUNK) && - a->repl_len > 5 && buf[a->repl_len - 5] == 0xe9 && - ((long)repl + a->repl_len + - *(int32_t *)(buf + a->repl_len - 4) == - (long)__x86_return_thunk) ) - *(int32_t *)(buf + a->repl_len - 4) += repl - orig; + /* + * Walk buf[] and adjust any insn-relative operands which leave the + * replacement block. + */ + if ( a->repl_len ) + { + uint8_t *ip = buf, *repl_end = ip + a->repl_len; + + for ( x86_decode_lite_t res; ip < repl_end; ip += res.len ) + { + int32_t *d32; + const uint8_t *target; + + res = x86_decode_lite(ip, repl_end); + + if ( res.len == 0 ) + { + printk("Alt for %ps [%*ph]\n" + " Unable to decode instruction at +%lu in alternative\n", + ALT_ORIG_PTR(a), a->repl_len, repl, ip - repl); + return -EINVAL; + } + + if ( res.rel_sz != 4 ) + continue; + + d32 = res.rel; + target = ip + res.len + *d32; + + if ( target >= buf && target <= repl_end ) + { + /* + * Target doesn't leave the replacement block. e.g. RSB + * stuffing. Leave it unmodified. + */ + continue; + } + + *d32 += repl - orig; + } + } a->priv = 1; -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:20:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381225.1624789 (Exim 4.92) (envelope-from ) id 1wqmy7-0001wj-C9; Mon, 03 Aug 2026 07:20:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381225.1624789; Mon, 03 Aug 2026 07:20:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy7-0001wb-9I; Mon, 03 Aug 2026 07:20:15 +0000 Received: by outflank-mailman (input) for mailman id 1381225; Mon, 03 Aug 2026 07:20:14 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy5-0001jf-Q6 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:20:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmy5-001lnU-6i for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:20:13 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70411b-2eae-0a2a0a5409dd-0a2a4509eaca-46 for ; Mon, 03 Aug 2026 09:20:13 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70412c-be1a-0a2a45090019-d1558036d87d-3 for ; Mon, 03 Aug 2026 09:20:12 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-496b7622a83so10889715e9.2 for ; Mon, 03 Aug 2026 00:20:12 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b85be7sm254687935e9.2.2026.08.03.00.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 00:20:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785741612; x=1786346412; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ub/V0kRy79kgAjDqq6A4lupnXHVPDMBJb38IyKztucA=; b=m/LZlSJ73th47EW3aq+8u7uO4RvAinRPHAuSrcmRmu/VIojsArSoAzHjkOkq+woFyb bxzaZjEWUUgNl0UDJx9WAwo04WZ2zWpYjz+CPWH+RuEjXUeBAyQvLHnURVTdVuiFYJ9+ iUyhdT7kCCT9n4MEBMGLzTtxr++iPB67FZmaU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785741612; x=1786346412; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ub/V0kRy79kgAjDqq6A4lupnXHVPDMBJb38IyKztucA=; b=G7N9oMEKzwoxTXakgiFH+y3bXAu6dZbMLbW3LqaIUJUARQm53445XXYSp/VVrnAB8p 7tVs4sYR83X9/oPCDBWdplFEpv6fxoVOAQdXFF+2HnH6KnnszWgafAFYA7+FUWAYK6ZP in6i+1NdCxToL3tMc2gQ72eiobPATjRRFDMLdRqp7uBVyC7jlxEjfxJp3B81BcRm3hJO OlMoVfRY2bm52UmpLuCID1Jx5tOcbxw4Orc87eouuCJSo8Vwx5z0h6Wy3EvIzHGIGM+V mcjgn6TjxuU+/ga8PmzfEZrfLB3iExlJ3EVwHkl7uO7UpQiCEJQOHG81EL4Oau8YxkVO 1nzw== X-Gm-Message-State: AOJu0YxSsbC62vZxHBECrOAZZ94UXEdxQUMX/y0H7uX0HWjAdVHIgwA3 HdmmU7Ul/0t0baoUIK9QUv5Vlg9BFLB42dd3kc5FfLe24LMwZX+rCL51HNaK0Fzvl3taDo8GQYh 3ppEq X-Gm-Gg: AR+sD11ScO9Q6cCqHtxDNsg+20OL1sYXYsUc41L55IVxh4O5b05G+jolDSUmZg61dRR 6ay9VnXYPLJN9cMI2DvsSjrtyF4V/Peoeny7lnyWr9XhUQfkHtsIoDfgk9dP/+Ia8X6sfAz87Lv cWPFp+dbKcMi+IJoqeKmG7enkqJIfGCFSF5pwAvHQfRE2qjkq9Bm74S1Jg6483q8kJgr/lKWCyp yeILcsX3fHDgW1QrYqwBF4IM4gZ3TTy2p7WSm2FudbSTQmApDVbyaS4c6jPJUrBClNKe1qx/LLZ x5xuN/QBNp9/L35lOECIXgVLFi8BzcCj03Peuunh+jY2A5LnP761VzRecaVyFLf1Hmc9/pc8Y7P wStYONuZsFlnFAT7KGXyY9aZ8qtk96orKyFUhVQcL8bJDsIffG2eEiBVa/5eSKi2KMBq6E6CzIf t9ihKPqGIY6pS9bdo8PK9qwOgt39St0Vd4JBcDDMth4ZIlSr0fWX3W2ERC5FRlU6JqpfWDEaodW nfOlq1HdE7H0R+AiwUHtGt6RPardryfnxUA6CANBdJgbG9C5g== X-Received: by 2002:a05:600c:19cf:b0:498:2b1f:e0c6 with SMTP id 5b1f17b1804b1-4982b1fe255mr23440215e9.18.1785741611381; Mon, 03 Aug 2026 00:20:11 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH v3 1/5] x86/emul: Introduce x86_decode_lite() Date: Mon, 3 Aug 2026 08:20:02 +0100 Message-Id: <20260803072006.9678-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260803072006.9678-1-andrew.cooper3@citrix.com> References: <20260803072006.9678-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785741612-3B4D3034-D2B7BA1C/0/0 X-purgate-type: clean X-purgate-size: 14873 In order to relocate all IP-relative fields in an alternative replacement block, we need to decode the instructions enough to obtain their length and any relative fields. Full x86_decode() is far too heavyweight, so introduce a minimal form which can make several simplifying assumptions. This a mostly-complete decoder for integer instruction in the onebyte and twobyte maps. Some instructions are intentionally unrecognised, as finding them in an alternative is more likely to be a bug than intentional. Some instruction groups and prefixes are unimplemented to reduce decode complexity. This logic can decode all alternative blocks that exist in Xen right now. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie v3: * Rearrange decode tables to satisfy comment requests without splitting * Recognise UDB now it's used by Xen * Fix MISRA violations * Misc other changes v2: * Switch to 0 on failure, rel_sz in bytes * Mostly complete the integer instructions; paird with userspace harness * Put in .init when !CONFIG_LIVEPATCH --- xen/arch/x86/x86_emulate/Makefile | 6 + xen/arch/x86/x86_emulate/decode-lite.c | 330 +++++++++++++++++++++++++ xen/arch/x86/x86_emulate/x86_emulate.h | 14 ++ 3 files changed, 350 insertions(+) create mode 100644 xen/arch/x86/x86_emulate/decode-lite.c diff --git a/xen/arch/x86/x86_emulate/Makefile b/xen/arch/x86/x86_emulate/Makefile index 295e602f6b86..679bddbb1584 100644 --- a/xen/arch/x86/x86_emulate/Makefile +++ b/xen/arch/x86/x86_emulate/Makefile @@ -17,3 +17,9 @@ obj-y += decode.o obj-$(CONFIG_HVM) += fpu.o obj-y += util.o obj-y += util-xen.o + +ifeq ($(CONFIG_LIVEPATCH),y) +obj-y += decode-lite.o +else +obj-bin-y += decode-lite.init.o +endif diff --git a/xen/arch/x86/x86_emulate/decode-lite.c b/xen/arch/x86/x86_emulate/decode-lite.c new file mode 100644 index 000000000000..131cc07d5516 --- /dev/null +++ b/xen/arch/x86/x86_emulate/decode-lite.c @@ -0,0 +1,330 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifdef __XEN__ +# include +# include +#endif + +#include "private.h" + +#undef ModRM + +/* + * Bare minimum x86 instruction decoder to parse the alternative replacement + * instructions and locate the IP-relative references that may need updating. + * + * These are: + * - disp8/32 from near direct branches + * - RIP-relative memory references + * + * The following simplifications are used: + * - All code is 64bit, the instruction stream is well formed and safe to + * read. + * - Instruction groups and prefixes not used by Xen's current alternatives + * are not implemented in order to reduce the decode complexity. + * - Certain instructions are intentionally not recognised, when it is more + * likely for their presence to be an error than intentional. + * + * Inputs: + * @ip The position to start decoding from. + * @end End of the replacement block. Exceeding this is considered an error. + * + * Returns: x86_decode_lite_t + * - On failure, length of 0. + * - On success, length > 0. For rel_sz > 0, rel points at the relative + * field in the instruction stream. + */ +x86_decode_lite_t init_or_livepatch x86_decode_lite(void *ip, void *end) +{ +#define Imm8 (1 << 0) +#define Imm (1 << 1) +#define Moffs (1 << 2) +#define Branch (1 << 5) /* Near direct branches, which have a displacement */ +#define ModRM (1 << 6) +#define Known (1 << 7) + + static const uint8_t init_or_livepatch_const onebyte[256] = { + +#define ALU_OPS(x) \ + [(x) + 0] = (Known|ModRM), \ + [(x) + 1] = (Known|ModRM), \ + [(x) + 2] = (Known|ModRM), \ + [(x) + 3] = (Known|ModRM), \ + [(x) + 4] = (Known|Imm8), \ + [(x) + 5] = (Known|Imm) + + ALU_OPS(0x00) /* ADD */, ALU_OPS(0x08) /* OR */, + ALU_OPS(0x10) /* ADC */, ALU_OPS(0x18) /* SBB */, + ALU_OPS(0x20) /* AND */, ALU_OPS(0x28) /* SUB */, + ALU_OPS(0x30) /* XOR */, ALU_OPS(0x38) /* CMP */, + +#undef ALU_OPS + + [0x50 ... 0x5f] = (Known), /* PUSH/POP %reg */ + + [0x62] = 0, /* BOUND, but also EVEX prefix, not implemented. */ + [0x63] = (Known|ModRM), /* MOVSxd */ + + [0x68] = (Known|Imm), /* PUSH $imm */ + [0x69] = (Known|ModRM|Imm), /* IMUL $imm */ + [0x6a] = (Known|Imm8), /* PUSH $imm8 */ + [0x6b] = (Known|ModRM|Imm8), /* PUSH $imm8 */ + [0x6c ... 0x6f] = (Known), /* INS/OUTS */ + [0x70 ... 0x7f] = (Known|Branch|Imm8), /* Jcc disp8 */ + [0x80] = (Known|ModRM|Imm8), /* Grp1 */ + [0x81] = (Known|ModRM|Imm), /* Grp1 */ + + [0x83] = (Known|ModRM|Imm8), /* Grp1 */ + [0x84 ... 0x8e] = (Known|ModRM), /* TEST/XCHG/MOV/MOV-SREG/LEA */ + [0x8f] = 0, /* Grp1A - POP but also XOP prefix, not implemented. */ + [0x90 ... 0x99] = (Known), /* NOP/XCHG %rAX/CLTQ/CQTO */ + + [0x9b ... 0x9f] = (Known), /* FWAIT/PUSHF/POPF/SAHF/LAHF */ + [0xa0 ... 0xa3] = (Known|Moffs), /* MOVABS */ + [0xa4 ... 0xa7] = (Known), /* MOVS/CMPS */ + [0xa8] = (Known|Imm8), /* TEST %al */ + [0xa9] = (Known|Imm), /* TEST %rAX */ + [0xaa ... 0xaf] = (Known), /* STOS/LODS/SCAS */ + [0xb0 ... 0xb7] = (Known|Imm8), /* MOV $imm8, %reg */ + [0xb8 ... 0xbf] = (Known|Imm), /* MOV $imm{16,32,64}, %reg */ + [0xc0 ... 0xc1] = (Known|ModRM|Imm8), /* Grp2 (ROL..SAR $imm8, %reg) */ + + [0xc3] = (Known), /* RET */ + [0xc4 ... 0xc5] = 0, /* LES/LDS but also VEX prefixes, not implemented. */ + [0xc6] = (Known|ModRM|Imm8), /* Grp11, Further ModRM decode */ + [0xc7] = (Known|ModRM|Imm), /* Grp11, Further ModRM decode */ + + [0xcb ... 0xcc] = (Known), /* LRET/INT3 */ + [0xcd] = (Known|Imm8), /* INT $imm8 */ + + [0xd0 ... 0xd3] = (Known|ModRM), /* Grp2 (ROL..SAR {$1,%cl}, %reg) */ + + [0xd6] = (Known), /* UDB */ + + [0xe4 ... 0xe7] = (Known|Imm8), /* IN/OUT $imm8 */ + [0xe8 ... 0xe9] = (Known|Branch|Imm), /* CALL/JMP disp32 */ + + [0xeb] = (Known|Branch|Imm8), /* JMP disp8 */ + [0xec ... 0xef] = (Known), /* IN/OUT %dx */ + + [0xf1] = (Known), /* ICEBP */ + + [0xf4] = (Known), /* HLT */ + [0xf5] = (Known), /* CMC */ + [0xf6 ... 0xf7] = (Known|ModRM), /* Grp3, Further ModRM decode */ + [0xf8 ... 0xfd] = (Known), /* CLC ... STD */ + [0xfe ... 0xff] = (Known|ModRM), /* Grp4 */ + }; + static const uint8_t init_or_livepatch_const twobyte[256] = { + [0x00 ... 0x03] = (Known|ModRM), /* Grp6/Grp7/LAR/LSL */ + + [0x0b] = (Known), /* UD2 */ + + [0x18 ... 0x1f] = (Known|ModRM), /* Grp16 (Hint Nop) */ + [0x20 ... 0x23] = (Known|ModRM), /* MOV %cr/%dr */ + + [0x30 ... 0x33] = (Known), /* WRMSR/RDTSC/RDMSR/RDPMC */ + + [0x40 ... 0x4f] = (Known|ModRM), /* CMOVcc */ + + [0x80 ... 0x8f] = (Known|Branch|Imm), /* Jcc disp32 */ + [0x90 ... 0x9f] = (Known|ModRM), /* SETcc */ + + [0xa0 ... 0xa2] = (Known), /* PUSH/POP %fs/CPUID */ + [0xa3] = (Known|ModRM), /* BT */ + [0xa4] = (Known|ModRM|Imm8), /* SHLD $imm8 */ + [0xa5] = (Known|ModRM), /* SHLD %cl */ + + [0xa8 ... 0xa9] = (Known), /* PUSH/POP %gs */ + + [0xab] = (Known|ModRM), /* BTS */ + [0xac] = (Known|ModRM|Imm8), /* SHRD $imm8 */ + [0xad ... 0xaf] = (Known|ModRM), /* SHRD %cl/Grp15/IMUL */ + + [0xb0 ... 0xb9] = (Known|ModRM), /* CMPXCHG/LSS/BTR/LFS/LGS/MOVZxx/POPCNT/UD1 */ + [0xba] = (Known|ModRM|Imm8), /* Grp8 */ + [0xbb ... 0xbf] = (Known|ModRM), /* BTC/BSF/BSR/MOVSX */ + [0xc0 ... 0xc1] = (Known|ModRM), /* XADD */ + [0xc7] = (Known|ModRM), /* Grp9 */ + [0xc8 ... 0xcf] = (Known), /* BSWAP */ + }; + + void *start = ip, *rel = NULL; + unsigned int opc, rel_sz = 0; + uint8_t b, d, rex = 0, osize = 4; + +#define OPC_TWOBYTE (1 << 8) + + /* Mutates IP, uses END. */ +#define FETCH(ty) \ + ({ \ + ty _val; \ + \ + if ( (ip + sizeof(ty)) > end ) \ + goto overrun; \ + _val = *(ty *)ip; \ + ip += sizeof(ty); \ + _val; \ + }) + + for ( ;; ) /* Prefixes */ + { + switch ( b = FETCH(uint8_t) ) + { + case 0x26: /* ES override */ + case 0x2e: /* CS override */ + case 0x36: /* DS override */ + case 0x3e: /* SS override */ + case 0x64: /* FS override */ + case 0x65: /* GS override */ + case 0xf0: /* LOCK */ + case 0xf2: /* REPNE */ + case 0xf3: /* REP */ + break; + + case 0x66: /* Operand size override */ + osize = 2; + break; + + /* case 0x67: Address size override, not implemented */ + + case 0x40 ... 0x4f: /* REX */ + rex = b; + continue; + + default: + goto prefixes_done; + } + rex = 0; /* REX cancelled by subsequent legacy prefix. */ + } + prefixes_done: + + if ( rex & REX_W ) + osize = 8; + + /* Fetch the main opcode byte(s) */ + if ( b == 0x0f ) + { + b = FETCH(uint8_t); + opc = OPC_TWOBYTE | b; + + d = twobyte[b]; + } + else + { + opc = b; + d = onebyte[b]; + } + + if ( unlikely(!(d & Known)) ) + goto unknown; + + if ( d & ModRM ) + { + uint8_t modrm = FETCH(uint8_t); + uint8_t mod = modrm >> 6; + uint8_t reg = (modrm >> 3) & 7; + uint8_t rm = modrm & 7; + + /* ModRM/SIB decode */ + if ( mod == 0 && rm == 5 ) /* RIP relative */ + { + rel = ip; + rel_sz = 4; + FETCH(int32_t); + } + else if ( mod != 3 && rm == 4 ) /* SIB */ + { + uint8_t sib = FETCH(uint8_t); + uint8_t base = sib & 7; + + if ( mod == 0 && base == 5 ) + goto disp32; + } + + if ( mod == 1 ) /* disp8 */ + FETCH(int8_t); + else if ( mod == 2 ) /* disp32 */ + { + disp32: + FETCH(int32_t); + } + + /* ModRM based decode adjustements */ + switch ( opc ) + { + case 0xc7: /* Grp11 XBEGIN is a near direct branch. */ + if ( modrm == 0xf8 ) + d |= Branch; + break; + + case 0xf6: /* Grp3 TEST(s) have extra Imm8 */ + if ( reg == 0 || reg == 1 ) + d |= Imm8; + break; + + case 0xf7: /* Grp3 TEST(s) have extra Imm */ + if ( reg == 0 || reg == 1 ) + d |= Imm; + break; + } + } + + if ( d & Branch ) + { + /* + * We don't tolerate 66-prefixed call/jmp in alternatives. Some are + * genuinely decoded differently between Intel and AMD CPUs. + * + * We also don't implement APX instructions, so don't have to cope + * with JMPABS which is the first branch to have an 8-byte immediate. + */ + if ( osize < 4 ) + goto bad_osize; + + rel = ip; + rel_sz = (d & Imm8) ? 1 : 4; + } + + if ( d & (Imm | Imm8 | Moffs) ) + { + if ( d & Imm8 ) + osize = 1; + else if ( d & Moffs ) + osize = 8; + else if ( osize == 8 && !(opc >= 0xb8 && opc <= 0xbf) ) + osize = 4; + + switch ( osize ) + { + case 1: FETCH(uint8_t); break; + case 2: FETCH(uint16_t); break; + case 4: FETCH(uint32_t); break; + case 8: FETCH(uint64_t); break; + default: goto bad_osize; + } + } + + return (x86_decode_lite_t){ ip - start, rel_sz, rel }; + + bad_osize: + printk(XENLOG_ERR "%s() Bad osize %u in %*ph\n", + __func__, osize, + (int)(unsigned long)(end - start), start); + return (x86_decode_lite_t){ 0, 0, NULL }; + + unknown: + printk(XENLOG_ERR "%s() Unknown opcode in %*ph <%02x> %*ph\n", + __func__, + (int)(unsigned long)(ip - 1 - start), start, b, + (int)(unsigned long)(end - ip), ip); + return (x86_decode_lite_t){ 0, 0, NULL }; + + overrun: + printk(XENLOG_ERR "%s() Decode overrun, got %*ph\n", + __func__, + (int)(unsigned long)(end - start), start); + return (x86_decode_lite_t){ 0, 0, NULL }; + +#undef FETCH +} diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index 0fd20747dc43..566a8297d8a5 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -835,4 +835,18 @@ static inline void x86_emul_reset_event(struct x86_emulate_ctxt *ctxt) ctxt->event = (struct x86_event){}; } +/* + * x86_decode_lite(). Very minimal decoder for managing alternatives. + * + * @len is 0 on error, or nonzero on success. If the instruction has a + * relative field, @rel_sz is nonzero, and @rel points at the field. + */ +typedef struct { + uint8_t len; + uint8_t rel_sz; /* bytes: 0, 1 or 4 */ + void *rel; +} x86_decode_lite_t; + +x86_decode_lite_t x86_decode_lite(void *ip, void *end); + #endif /* __X86_EMULATE_H__ */ -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:20:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381224.1624781 (Exim 4.92) (envelope-from ) id 1wqmy6-0001jt-6s; Mon, 03 Aug 2026 07:20:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381224.1624781; Mon, 03 Aug 2026 07:20:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy6-0001jm-39; Mon, 03 Aug 2026 07:20:14 +0000 Received: by outflank-mailman (input) for mailman id 1381224; Mon, 03 Aug 2026 07:20:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy4-0001jZ-Sq for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:20:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmy3-00Dk9I-RV for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:20:11 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70412b-e002-0a2a0a5209dd-0a2a450bb788-0 for ; Mon, 03 Aug 2026 09:20:11 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70412b-b7e8-0a2a450b0019-d1558032e956-3 for ; Mon, 03 Aug 2026 09:20:11 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4955de8797cso9803985e9.3 for ; Mon, 03 Aug 2026 00:20:11 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b85be7sm254687935e9.2.2026.08.03.00.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 00:20:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785741611; x=1786346411; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Vn4hYT6+TtjuUJM3snHYvQUurh//1CWbljHmLcAATKw=; b=KsLvh5lyyn7oCgi26jrcq3NPMa2gHS12AWLM6hL5DVKPxrwb1cv5+gLXkgYwcLvu/o z8ulse263sFtKOBLfQXuVKPFqLrs7iulylpQQndrliRZLAoiSxsufSV992V9ex77W5bx 6i8JMcgKC2P+f5RTX6CzTj0PxeiCjRseWUKE8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785741611; x=1786346411; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Vn4hYT6+TtjuUJM3snHYvQUurh//1CWbljHmLcAATKw=; b=qgoGVNHHQgveS1ZQIpxRaxj0MxO6yWI4R0zpNxLyZPKM6jJsYhMHKB3NgmRmgceHeq EuHQI7HJs+tfhemw72/8tgPV1WIPANasjPm4xfecZnx5TteC81KzoWCfPVqEK6W6lZ7N rq5Jq3FV1uxY7a55tV1FLWT4v3DF5nLMs68FUD72bxqsr/CYH9ujoQ4LBvcZ85naioUF k+EeJ3ZavaRGvkVjcinUi8nX6FazhgeKwPQsXkeeIMTT2xHIYzJ+B6pF9NxyHg8LefDi ZCRQJ9/7pdW+WGkHuVIbAGP/g3oXCkU+FaQRjTFAu0csatIOGlVIQpwSRNI2FCUHaQhx DahQ== X-Gm-Message-State: AOJu0Yw0ajfmlq7aynMU6uubSYZ6rtsZlTF15S+7/bGBY/eBM34xtA+O pvD8OmzWmEHiOwRw5V3+BSEfWlyfNLRI9wwUfGLNWqgH457jOODskdsKgoz2Q7C6x3yPrY12KUw 9Kh4v7TE= X-Gm-Gg: AR+sD13uDVgrHDW7GBtbkiO0HeCr+mSz9B0Gk1Ve9lfRfSw5G0PCqTLKHVzr0v8MJaN QOJS3De4fEdLPTtELb/XOvUZn0mLdVz96D8RROVAEDRewVszJKEv3DAJMOm/pyGx0X0MDzp2JeN BrDWCvMld3CoA4rvARJhwb3cEdPI+0iZg34LHGWPyRS69Ap1hmyRNoJrHJCV/Kef41NvtdjXcmm vSdgq+3j2a1FhAj1acDrzljUvEArHCLFm5+g/rClP+e26YLXu2wDfsjfu1j/SNpKVmmjabYzsM9 ptt6+Z1fe+4TSzOrqDIvILpvaqIsvr+/IQBWfqf6IdfKFQzDrl50IweazRPJ4f9qxFWR9zfE+rI ziwqoOA9JnkRAtqBhERfQc30PqUVZoradorSXxOTinBrCaFQI+JcM+WhjfuLvcXn3ofUxeG4SHL m3UGFg+ckd6LWay11buZ9oI2wbCXOKIBEllPSa2ElmeFzBDqnxgMijy0n4Ii0bEfW9LVJKjXzvR X/KyHJYKKDZXEXOOG5UgYFo6fa91IY0iIKv62w= X-Received: by 2002:a05:600c:8b13:b0:498:8e6:d464 with SMTP id 5b1f17b1804b1-4980c65cd2fmr198611065e9.14.1785741610768; Mon, 03 Aug 2026 00:20:10 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH v3 0/5] x86/alternatives: Adjust all insn-relative fields Date: Mon, 3 Aug 2026 08:20:01 +0100 Message-Id: <20260803072006.9678-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785741611-188C99EA-C3D7F43C/0/0 X-purgate-type: clean X-purgate-size: 1886 Alternatives have had a reasonably severe restriction since their introduction. This has been the source of several bugs, and several inefficiencies particularly in the speculative safety paths. https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/2724019865 v3: * Run through Gitlab CI. * Fix up Eclair issues, Clang issues, and older-binutils issues. Andrew Cooper (5): x86/emul: Introduce x86_decode_lite() tests/x86: Introduce a userspace test harness for x86_decode_lite() x86/alternative: Walk all replacements during self tests x86/alternative: Relocate all insn-relative fields x86/spec-ctrl: Introduce and use DO_COND_BHB_SEQ tools/tests/Makefile | 1 + tools/tests/x86-decode-lite/.gitignore | 1 + tools/tests/x86-decode-lite/Makefile | 56 ++ tools/tests/x86-decode-lite/insns.S | 703 ++++++++++++++++++++++ tools/tests/x86-decode-lite/macro-magic.h | 62 ++ tools/tests/x86-decode-lite/main.c | 111 ++++ tools/tests/x86-decode-lite/x86-emulate.h | 27 + xen/arch/x86/alternative.c | 102 +++- xen/arch/x86/hvm/vmx/entry.S | 12 +- xen/arch/x86/include/asm/spec_ctrl_asm.h | 43 +- xen/arch/x86/x86_emulate/Makefile | 6 + xen/arch/x86/x86_emulate/decode-lite.c | 330 ++++++++++ xen/arch/x86/x86_emulate/x86_emulate.h | 14 + 13 files changed, 1434 insertions(+), 34 deletions(-) create mode 100644 tools/tests/x86-decode-lite/.gitignore create mode 100644 tools/tests/x86-decode-lite/Makefile create mode 100644 tools/tests/x86-decode-lite/insns.S create mode 100644 tools/tests/x86-decode-lite/macro-magic.h create mode 100644 tools/tests/x86-decode-lite/main.c create mode 100644 tools/tests/x86-decode-lite/x86-emulate.h create mode 100644 xen/arch/x86/x86_emulate/decode-lite.c -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 07:20:18 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 07:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381229.1624825 (Exim 4.92) (envelope-from ) id 1wqmy9-0002mb-TG; Mon, 03 Aug 2026 07:20:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381229.1624825; Mon, 03 Aug 2026 07:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy9-0002lb-Of; Mon, 03 Aug 2026 07:20:17 +0000 Received: by outflank-mailman (input) for mailman id 1381229; Mon, 03 Aug 2026 07:20:15 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqmy7-0001yA-Lc for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 07:20:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqmy7-00Dk9I-23 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:20:15 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a704119-e002-0a2a0a5209dd-0a2a4501c310-46 for ; Mon, 03 Aug 2026 09:20:15 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70412e-5984-0a2a45010019-d1558030c113-3 for ; Mon, 03 Aug 2026 09:20:15 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4954aff6088so14417695e9.3 for ; Mon, 03 Aug 2026 00:20:14 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b85be7sm254687935e9.2.2026.08.03.00.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 00:20:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785741614; x=1786346414; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SjwuBsICIK/H/Y6+HpcAgCloLVRbw36ixgETurBOkCw=; b=X2RSM6EpKUZkN34/3ySIiuU+Be1QmfqrwwfUVPWZ3s24nv2ra0DGlD0MV2Z0rWLA5F 8FyIsGAPcKW4KxrrXu+PNjSM5KA71DU1h9Xh/qSwZFER6W/IpHENQHSSqfXLLHDpYlY9 RWi7WF30Y2N870dZ6G5cEpjGExOVfm6elTg28= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785741614; x=1786346414; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SjwuBsICIK/H/Y6+HpcAgCloLVRbw36ixgETurBOkCw=; b=HM1Wr4qoYrwPRDFJ0vxYxD2hgXFUQ31CCdmJE3e0WC9Ba6iYTQ1PIWwL7oFnguO56J y4XxO2HEWEgHx4Ijr7WvX553VjhA3YFN6bKnXztKyHHTHrpEIRaouQ0HuZPD9hAMQUXa mFBc4MYxVgfVjYBEcmChKExa88VWdMe9gbBShvGNVtIVwB9+R8KYh4+nOiuaJx4pxeCG 2Cx1XNQLzMOpo2cO2YE/hVdMUEK1p2+QZYqLCRd/J8+Doh5IOo4tT1qzloQJ66nYRT49 sufWzkM5iCg1AhMajv2UCubqRI/LYHEiNeVRMDp63M2Mdx1Z6CXA63rLJ1jUzD/0cJbJ AIqQ== X-Gm-Message-State: AOJu0YyqiVH55tJzQXze4wBFNo0qhRTF8T+jKJRhVrtMXUtteJylnMlj LwTHNlD3V28FCxU3xMvCHBe8POQKj0LrVvV823yT4381vDrv3oLQFZYeTEAG7V3RrPloA0IIaMM Lf9lHHZM= X-Gm-Gg: AR+sD13ElKyup0+QIQBgDZFOpoxm0WmK72UFcy0yVjnvjh1tmiQv1S3i+lba7LP2XRf hIjARuioRldmO6+X+tvb4sJNjC8PnR/mdj3xWRcytEgKPQYmydsmGhBEKFFaiiiOhYxa7tyJBcL rIpz/WqpGWkOglA+FBKViW9EN9h7Pa+NWtrw9tl8vSBP0esDJgalqiB6w0ydFsrc+G5sGyt9+r7 Gs/cgF7XsJ8uKGywYIeBuLhfhBNQVE35lU5klpyzo1HISZL2xiBVfnVuAvHQ4d2rsQ5LTDh52Kt sotDY1UApmrSpILPiJMDWtt5p9PivWxYWfmpFkfZnvlw7rCHj1g1V44geQCNbFyUQ4arXkvgxpi w9VQnzNN0x+a+vzWtqfEWj8Aqli0caTfx7YlT9sE+/aJMfqiNxJou9ytBDlm02fuHjYCem95mYr JHOEywkzNc8ifaWgEBkvZT42bw4OutYWGhuZ4xtRBJ3NgAlMj90FX9Ye+qjUHVJUHlUMHGDVYUw iZcxjTkyUb9nGUBlrAd9eSDyLFRW80br6Gg328= X-Received: by 2002:a05:600c:4504:b0:493:c194:4e7a with SMTP id 5b1f17b1804b1-4980c66c9a8mr181514035e9.3.1785741614271; Mon, 03 Aug 2026 00:20:14 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH v3 5/5] x86/spec-ctrl: Introduce and use DO_COND_BHB_SEQ Date: Mon, 3 Aug 2026 08:20:06 +0100 Message-Id: <20260803072006.9678-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260803072006.9678-1-andrew.cooper3@citrix.com> References: <20260803072006.9678-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1785741615-C5540757-3BC6C667/0/0 X-purgate-type: clean X-purgate-size: 4495 Now that alternatives can fix up call displacements even when they're not the first instruction of the replacement, move the SCF_entry_bhb conditional inside the replacement block. This removes a conditional branch from the fastpaths of BHI-unaffected hardware. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie --- xen/arch/x86/hvm/vmx/entry.S | 12 +++---- xen/arch/x86/include/asm/spec_ctrl_asm.h | 43 +++++++++++++----------- 2 files changed, 30 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S index cebc70064048..76508c0de2f3 100644 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -59,12 +59,12 @@ FUNC(vmx_asm_vmexit_handler) * Clear the BHB to mitigate BHI. Used on eIBRS parts, and uses RETs * itself so must be after we've perfomed all the RET-safety we can. */ - testb $SCF_entry_bhb, CPUINFO_scf(%rsp) - jz .L_skip_bhb - ALTERNATIVE_2 "", \ - "call clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ - "call clear_bhb_tsx", X86_SPEC_BHB_TSX -.L_skip_bhb: + .macro VMX_BHB_SEQ fn:req + DO_COND_BHB_SEQ \fn scf=CPUINFO_scf(%rsp) + .endm + ALTERNATIVE_2 "", \ + "VMX_BHB_SEQ fn=clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ + "VMX_BHB_SEQ fn=clear_bhb_tsx", X86_SPEC_BHB_TSX ALTERNATIVE "lfence", "", X86_SPEC_NO_LFENCE_ENTRY_VMX /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */ diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index abb64ad2b7f9..780ec57f4553 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -92,6 +92,21 @@ .L\@_skip: .endm +.macro DO_COND_BHB_SEQ fn:req, scf=%bl +/* + * Requires SCF (defaults to %rbx), fn=clear_bhb_{loops,tsx} + * Clobbers %rax, %rcx + * + * Conditionally use a BHB clearing software sequence. + */ + testb $SCF_entry_bhb, \scf + jz .L\@_skip_bhb + + call \fn + +.L\@_skip_bhb: +.endm + .macro DO_OVERWRITE_RSB tmp=rax, xu /* * Requires nothing @@ -277,12 +292,9 @@ * Clear the BHB to mitigate BHI. Used on eIBRS parts, and uses RETs * itself so must be after we've perfomed all the RET-safety we can. */ - testb $SCF_entry_bhb, %bl - jz .L\@_skip_bhb - ALTERNATIVE_2 "", \ - "call clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ - "call clear_bhb_tsx", X86_SPEC_BHB_TSX -.L\@_skip_bhb: + ALTERNATIVE_2 "", \ + "DO_COND_BHB_SEQ clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ + "DO_COND_BHB_SEQ clear_bhb_tsx", X86_SPEC_BHB_TSX ALTERNATIVE "lfence", "", X86_SPEC_NO_LFENCE_ENTRY_PV .endm @@ -322,12 +334,9 @@ ALTERNATIVE "", __stringify(DO_SPEC_CTRL_ENTRY maybexen=1), \ X86_FEATURE_SC_MSR_PV - testb $SCF_entry_bhb, %bl - jz .L\@_skip_bhb - ALTERNATIVE_2 "", \ - "call clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ - "call clear_bhb_tsx", X86_SPEC_BHB_TSX -.L\@_skip_bhb: + ALTERNATIVE_2 "", \ + "DO_COND_BHB_SEQ clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ + "DO_COND_BHB_SEQ clear_bhb_tsx", X86_SPEC_BHB_TSX ALTERNATIVE "lfence", "", X86_SPEC_NO_LFENCE_ENTRY_INTR .endm @@ -433,13 +442,9 @@ * Clear the BHB to mitigate BHI. Used on eIBRS parts, and uses RETs * itself so must be after we've perfomed all the RET-safety we can. */ - testb $SCF_entry_bhb, %bl - jz .L\@_skip_bhb - - ALTERNATIVE_2 "", \ - "call clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ - "call clear_bhb_tsx", X86_SPEC_BHB_TSX -.L\@_skip_bhb: + ALTERNATIVE_2 "", \ + "DO_COND_BHB_SEQ clear_bhb_loops", X86_SPEC_BHB_LOOPS, \ + "DO_COND_BHB_SEQ clear_bhb_tsx", X86_SPEC_BHB_TSX lfence .endm -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 09:07:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 09:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381303.1624867 (Exim 4.92) (envelope-from ) id 1wqoe9-0007k2-6G; Mon, 03 Aug 2026 09:07:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381303.1624867; Mon, 03 Aug 2026 09:07:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqoe9-0007ju-2G; Mon, 03 Aug 2026 09:07:45 +0000 Received: by outflank-mailman (input) for mailman id 1381303; Mon, 03 Aug 2026 09:07:43 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqoe7-0007h7-Ev for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:07:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqoe6-00B0Hb-RS for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 11:07:42 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a705a4e-e002-0a2a0a5209dd-0a2a4502ccc4-42 for ; Mon, 03 Aug 2026 11:07:42 +0200 Received: from [209.85.218.45] (helo=mail-ej1-f45.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a705a5e-6ca4-0a2a45020019-d155da2de4ef-3 for ; Mon, 03 Aug 2026 11:07:42 +0200 Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-c197eaaab00so507729266b.0 for ; Mon, 03 Aug 2026 02:07:42 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd445432dsm507440166b.41.2026.08.03.02.07.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 02:07:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785748061; x=1786352861; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=b16T4GW68hAFFc0osm9lAVRPnORne6TE2Xjz+8jsFek=; b=P4olmWH6CfUDmU6sM4CVU3NrsiKSkPP3TmVonoy+u/7NAxj8/7GLjG0GJ2I2eDr/+1 yfrMYnGJsMvdFm3gt5gAKc5VHd+nD1acJsSgSwiAnI1k+rvKnY9vjgvSCKX6/x+j24XT c4vsYFCtcFgVPg+5CVPLIplJh9NWLys5e2YGgHcmswsB8gW4l4HyQL2g3fGvWw6ydyEu OU1VuhGR8alKr4tdubmSSEeEo0NZqk6ndKycC28AFXpry3/cCzxSpyAf0d5+ef0hi6vV FM0r547H28TWnG6Up/lrl+3s4UYj6CsN1IW3xa2hBpzumPyRb/5BW6hwuaNNBkdWTwdZ bNrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785748061; x=1786352861; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=b16T4GW68hAFFc0osm9lAVRPnORne6TE2Xjz+8jsFek=; b=aBBUangYoOBq4g2ONO89D1ccSNnQajzVHDzMd4SPdW4D+HkthU6cibehhuLmt26v0I ffczWzsxeXmpdQF1vuCqA+nPif6hYfK9kzxHUARwuU/2cQ3yMT67lNpHZXIPj4x8P9sR 87c/pzF+fx2ykls2NJz7WHSQfUZUpYVexeykQ5lZAwS3ekOqi8VAiygKtMCUe0Q0wQLt b5W2O0z7/7nQiXgdOETH8B8HiBtsNPYomBZ+0wpO0UmjW0OrapZj466Q0of9M+4b4Hhx TW9yngllSNesYnZon28NQ6tp7mEdOkZ0omBRMvF7bv99DWQ7pGnoWXkCqdBkhXmX/+IA IcgQ== X-Forwarded-Encrypted: i=1; AHgh+RpRJxQJSetZ/eFih7ubzb0p1V8RvgioGEbElKOKt+JgUroUO+ZlJMPk+xw72HUTKJX4s5+b/SXQeQ0=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw1OL1SF0Nmx9odq5mv/krUED7bRisrJEcwoa4h97XqveQEjiwJ vOm6QPTilgQuqsxRZzqRvl5TLRlqiDeAyR8mYOKH06fPLbgZicWWg4ys+k8BEjJSvr4= X-Gm-Gg: AR+sD11TtPEj5JUgZyi79HKVreDduPB2ihWRwzkphy38mrsL1khHXy2WDR45x7iGCCl H19zaNQSnMe4T2TlHB61dGlfQGXxglXvlsEOa/Lv/N3R7dCQJzy9GA67V14TrM2jwOPI8jnAO+h 95Gw1dHQ8hX20FEalPlobdYylRzT7ue6U/rhIIkrE9TGQUY3y4Va+f1476Yk+wQWJhfG851Z8s7 p7lIRtl9kW225/vbSoI24GzTA9EskyIP9zkomH/Vvez2h3vBEhSfKYAF1EmdYZopdbD8eRw6c8B 9rvkxoAEv2BbB6qtkb7o35GzLaq1dSUpEcz6+Y8GwNtCNeqB4CBJRw/UdlbpBjGQ/Z/68t4IBgJ 6l7aPjams0TYu1d3jd9kElfzebtN7zADH1bYNRjsmN4jb3cSnxqNzzgc0dee0bAYMKWoy/fPu76 41Wi0y8fiScCXnZgvyS71uxdz8Nn9N/7n/mM0ZZRyK6KXhtoUS0riCesiAHm7Kk8cB7AFo2BPFS 1fLgi7Ii7s3lUAmoabK93YSshFHLONnKwi6uz9LWl+4Cj4dSz+p+ylcfOHTbDmVLEVD4IZPj6Pj ihHukk1uiZkerVQ= X-Received: by 2002:a17:907:76fa:b0:c19:fb6e:5ff0 with SMTP id a640c23a62f3a-c1fe81a5d9fmr582774266b.15.1785748061532; Mon, 03 Aug 2026 02:07:41 -0700 (PDT) Message-ID: <5ca4d0e4-1747-45a7-a916-a7516bb1692b@suse.com> Date: Mon, 3 Aug 2026 11:07:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 00/14] Remove PG_private by using page/folio->private checks instead To: Zi Yan , David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Sergey Senozhatsky , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "H. Peter Anvin" , linux-perf-users@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Eric Biggers , "Theodore Y. Ts'o" , Jaegeuk Kim , linux-fscrypt@vger.kernel.org, Oscar Salvador , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Gao Xiang , Jan Kara , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Axel Rasmussen , Yuanchu Xie , Wei Xu , linux-trace-kernel@vger.kernel.org, Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, Song Liu , Yu Kuai , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Li Nan , Xiao Ni , linux-raid@vger.kernel.org, ceph-devel@vger.kernel.org, Richard Weinberger , Zhihao Cheng , linux-mtd@lists.infradead.org, Baoquan He , Pasha Tatashin , Pratyush Yadav , Jonathan Corbet , Dave Young , Shuah Khan , kexec@lists.infradead.org, linux-doc@vger.kernel.org References: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Vg9NJvq3ine0Gyx1IX0BEzQC" X-purgate-ID: tlsNG-720697/1785748062-305C52AC-89ECAC62/0/0 X-purgate-type: clean X-purgate-size: 10188 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Vg9NJvq3ine0Gyx1IX0BEzQC Content-Type: multipart/mixed; boundary="------------1XNOHvG0ftKOzuceeKWaT2Id"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Zi Yan , David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Sergey Senozhatsky , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "H. Peter Anvin" , linux-perf-users@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Eric Biggers , "Theodore Y. Ts'o" , Jaegeuk Kim , linux-fscrypt@vger.kernel.org, Oscar Salvador , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Gao Xiang , Jan Kara , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Axel Rasmussen , Yuanchu Xie , Wei Xu , linux-trace-kernel@vger.kernel.org, Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, Song Liu , Yu Kuai , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Li Nan , Xiao Ni , linux-raid@vger.kernel.org, ceph-devel@vger.kernel.org, Richard Weinberger , Zhihao Cheng , linux-mtd@lists.infradead.org, Baoquan He , Pasha Tatashin , Pratyush Yadav , Jonathan Corbet , Dave Young , Shuah Khan , kexec@lists.infradead.org, linux-doc@vger.kernel.org Message-ID: <5ca4d0e4-1747-45a7-a916-a7516bb1692b@suse.com> Subject: Re: [PATCH RFC 00/14] Remove PG_private by using page/folio->private checks instead References: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> In-Reply-To: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> --------------1XNOHvG0ftKOzuceeKWaT2Id Content-Type: multipart/mixed; boundary="------------emnYBJyIfA0mAuf1FBk0JrWD" --------------emnYBJyIfA0mAuf1FBk0JrWD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDguMjYgMDQ6MTMsIFppIFlhbiB3cm90ZToNCj4gSGkgYWxsLA0KPiANCj4gVGhp cyBwYXRjaHNldCByZW1vdmVzIFBHX3ByaXZhdGUgdG8gbWFrZSBzcGFjZSBmb3IgdXBjb21p bmcgUEdfZm9saW8NCj4gKHJlc2VydmVkIGFzIF9fUEdfZm9saW8pIGZvciBpZGVudGlmeWlu ZyBwYWdlcyBmcm9tIGEgZm9saW8gKG1vcmUgZGV0YWlscw0KPiBpbiBOb3RlIGJlbG93KS4g SW5zdGVhZCBvZiBjaGVja2luZyBQR19wcml2YXRlLCBhbGwgY29kZSBpcyBjaGFuZ2VkIHRv DQo+IGNoZWNrIHBhZ2UvZm9saW8tPnByaXZhdGUgIT0gTlVMTCBpbnN0ZWFkLg0KDQpJJ20g YSBsaXR0bGUgYml0IHdvcnJpZWQgdGhhdCBwYWdlL2ZvbGlvLT5wcml2YXRlIGlzIGluIGEg dW5pb24sIHNvIHRvZGF5DQppdCBjb3VsZCAoaW4gdGhlb3J5KSBiZSAhPSBOVUxMIHdoaWxl IFBHX3ByaXZhdGUgaXNuJ3Qgc2V0Lg0KDQpJcyBpdCByZWFsbHkgbm90IHBvc3NpYmxlIHRv IGVudGVyIGEgcGF0aCB3aGVyZSBQR19wcml2YXRlIGlzIHRlc3RlZCB3aGlsZQ0KcGFnZS9m b2xpby0+cHJpdmF0ZSAhPSBOVUxMIGR1ZSB0byB0aGUgdW5pb24gYmVpbmcgdXNlZCBvdGhl cndpc2UgKFBHX3ByaXZhdGUNCm5vdCBzZXQpPw0KDQoNCkp1ZXJnZW4NCg== --------------emnYBJyIfA0mAuf1FBk0JrWD Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------emnYBJyIfA0mAuf1FBk0JrWD-- --------------1XNOHvG0ftKOzuceeKWaT2Id-- --------------Vg9NJvq3ine0Gyx1IX0BEzQC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpwWlsFAwAAAAAACgkQsN6d1ii/Ey/i jgf/ZwJPxlL37xKWgHvTpcOyxx9OjPwR5NnmxhKYC+qK1G+dCKRR2aNsNRd92IvtuR/zlwoSK3Bz 7Knn/QAX+Sr8+MzzkoSZZy4464mITxuVnjBsYOy1wmVfTRA9xJ5kPDsLcow9h9fba5YWY5JKjJEr fuIk59vC3iZC8TXbrwFnUB118QfIzPMfnHvl18ioDjqN/X6ooFJudXLB3hTrlpzsxtdu1OFI+TsY 0FUiNapbbcLYtM5X9v/bo7LSqQNdjZKmfV2DVQHs8Vj2bH/TyrIG+SvEggEztdqBgec9T7Ix66uU FOasApx6jWOz0UmYAKKBF0iBOhSZaPnQhSA6xqkzCw== =lraB -----END PGP SIGNATURE----- --------------Vg9NJvq3ine0Gyx1IX0BEzQC-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 09:14:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 09:14:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381313.1624876 (Exim 4.92) (envelope-from ) id 1wqoko-0001bJ-U3; Mon, 03 Aug 2026 09:14:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381313.1624876; Mon, 03 Aug 2026 09:14:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqoko-0001bC-Qy; Mon, 03 Aug 2026 09:14:38 +0000 Received: by outflank-mailman (input) for mailman id 1381313; Mon, 03 Aug 2026 09:14:37 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqokn-0001b4-H0 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:14:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqokm-00E9gR-Tk for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 11:14:36 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a705bfa-5cb7-0a2a0a5109dd-0a2a450296ec-4 for ; Mon, 03 Aug 2026 11:14:36 +0200 Received: from [40.107.200.51] (helo=CH5PR02CU005.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a705bfb-6ca4-0a2a45020019-286bc8334d66-3 for ; Mon, 03 Aug 2026 11:14:36 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by BN9PR03MB5964.namprd03.prod.outlook.com (2603:10b6:408:135::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Mon, 3 Aug 2026 09:14:33 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0270.017; Mon, 3 Aug 2026 09:14:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JxaNim8YFCvhgZdYlREAR01MiL/ri+NfUnf2921a675RKSIQz5BwvTjRG1dLy/Bz55MntAYlFdjnSHIHsIR6EbB8O+O1fDrNdYEq8OE3Sxq1FRnT6bt6N5Y6b8w8jS8JLoA1iIYEaFQIqAonm/nPXsgqTcg4Q2Iy60HfslwPHrl361IisN3YMwrcWMoW0gCtYPhmR7MsbR/Y0Q3XT/CuTUz8NFEJ/nURXoJnDcfCEnxN1410qdCZ3nFdFKZ5pzdvsWMhxuKkdkUilt+ETtqiXf9sIc/SdA5ydEuBuV/E2EqgoRD5Zqx85B30F/dWUtcaM0IUSs9JMqqHqR7I1aCNAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQe3jkA8rX/YsH8gkWg7TjQ13snFQ+1/VGMhIr9kwU4=; b=EY68H5IbfDmFpx0uEOQYNK/oNt5uI4fdC7pC69KgiFA9HyQqftJPygKn4mGI3k1ST3pCjzMZvc+HF/xUfVfwMAg/qSzq43J67E/vXlX82vPl7893XReVR12/8YkBJ5W7P2IfG3kiSBziW4WujQNO9iFpUa259HUCouTD5R7giuszwQ6syhn2BzLVJdN/2XxQUCJvzf4zwUIeHLNfAfczFdDp8gAh9oTw1y1P75vZsEGHsYkvLyjxtb+9qQAMsyl8Tp4XbMnl+iz/InX618bVtNMdR4y+q7VIG/icRthElt6es7XElrG6VVnB7xSstSeZZKaBqh6cc+pLoHD3mux0lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQe3jkA8rX/YsH8gkWg7TjQ13snFQ+1/VGMhIr9kwU4=; b=jgnr28Hngb4wyyORZVRHjkhTAKusZhHeSyPXF0j/WkeTlVJPhZ3LM3Y74cuRg2Zv0JOMGFyWwhIx4lwx9p1+Kg7+BSKS1DlM4KglM7+pej2acJTMio133+ztpUnk+NYtqKNJVFwKiVqrMHwtj35pp2qvnaTK1U/JtU99I+wlKbo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 3 Aug 2026 10:14:29 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie Subject: Re: [PATCH v3 1/5] x86/emul: Introduce x86_decode_lite() To: Xen-devel References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-2-andrew.cooper3@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260803072006.9678-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0699.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::6) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|BN9PR03MB5964:EE_ X-MS-Office365-Filtering-Correlation-Id: e09100be-83fc-4536-b6b7-08def13fa14a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|56012099006|10067099003|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 3KeHgKs3cFMRuOxCct5/itLB517SBhAFWCuoxGKRRCFuxbiDZEOTDLD5+JC1rLQxvAY7bBZnzugits30ajjQLfuRceUghWGAOiBK06IYhtqa9u36zkVamR3n2EkNMTQtXXVmElb6pOQaq3MSeic40qaNAO7wEWVkuW96Y2Voa1IP40nFJoXqCk+lDIgW0zfC5JNr8qtHoVYO0i3/mARhVHse/UA3hzsUVaHZuNEPyCpS+9Xv46rNzPIA0Ap+0t0yyJN+0zxPq5HZwWJHPuevemj6WDNYpxQxCASdozXAAz2xkjm7fo/oHy+esC8g03Bpc5OYp8NGorK8oMdaN7eVjtxrxcuquo1k7DL6r7QZegVrzefg2HNwv3lktfGn79kk7mFGaOxf/cblS/TnLpqRO/xKUvRjA3qPNPm+rhuCqFZ51zHxtN3ndKtA4LlWOYXfdaP3zOdLMbQo7BHkrNSVgiGH7A45OaiYNeXSJJyGL2kh+SIGvtmrptX0V31ZoS3ARqBWTpEJtsJpoVhZM93gpLbWAVJXRhotOWfPVmxFz0l8lyCTnEJlTvR+rQc6fRihLocJshtXG1uE+a5q+mJQZhBNSoRKtlve1TaagGT3ijVwhoSza9t7PxNo1+wZ1JqNFXxhkEtgjlG0fyFlGeEyS3/8XrKeC8RvaWcbhweJfUA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(56012099006)(10067099003)(11063799006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkYwOVNGa1Zwb0tCN0ljZng2bDFGOWdvQzNpNm5rMkMrRFk5Ti96YmhkbWh0?= =?utf-8?B?cm4wSFVhK3FvWDkwZTBYczgrU2VCdXpKSGJlWlI1TVpiYVNUWkJaQ3dvMFd0?= =?utf-8?B?ZmZ1Ny96NmNtd3JZZUpKU3Y0MGZ3ZmFNMUxRWlUyQlFZY2l1bWNneTVQV3M4?= =?utf-8?B?a0ZNdHRHY25DKzlsRmd0bEFGaFJub2phdDZCNXdKK0xIWHZucGdPTmFMNFBt?= =?utf-8?B?MUN3VEErVkd2ZTBJVmpVOUJOVk1uSnRkdEkyaFBPMXVkNXEzSFZTYkFQMXJC?= =?utf-8?B?bi9nbFZIWjBQR3gzaEpla1RxSG5aRDIrYktqOXd1UXlmSE9CWWFUVjVpM0lO?= =?utf-8?B?czg3V2gwQlRRVmUwWVlzVWdyYUFlK3hyd2hiYVZpb1FueEN4VkFBL1RaTEcr?= =?utf-8?B?b1FIYzNwRTJaWWM4OXhtRVpZVVNqWEZqSEFDMVAvemdYT2NISldmUTZrQnBD?= =?utf-8?B?dDY0bzZRUk9GU0tLa05yRVd1MTdBdG5CVkVWZVBrS1ZHeVdiQWJUSWZINEk1?= =?utf-8?B?cThTa01lN25zbEcyTVhpUWRyQlh4eXZGdit2OGRVOW9OcVhZa0t0VHh3Z2oy?= =?utf-8?B?ZWNJMFJmSU91cUZSY0dYNFZpKzBTK0xWK2wwQkRDMlhXSkxtcG1SeG12VW02?= =?utf-8?B?MkJFcHRVSkRyRld5VHdiYXFIVDlxZzdTZ09zckY0T2plVnRZV0JQWklkeVNP?= =?utf-8?B?enBtNlczd21WTlgyNnFtZXA5MVBPK2g2VGxrVS9TVzcyTTE0cFlTdkkyb0Q0?= =?utf-8?B?SFJVWU9saHp6T3lzeFhRY3VPVXV5V3BGMEtOOHkyQm9zSnowZzJXU1VkYU9X?= =?utf-8?B?cmkya1RKTVd6bUFyRkNDU1FiV1lzdlFrdTc0UjN0UzBFZDd6VkRQVWo2bzJR?= =?utf-8?B?R1cwYzFvQXBMWi9MUERUU3dCNWFDaDZrb0g3WE1EL25CbGxwWUMybEMyVTMx?= =?utf-8?B?aVVIOHNTV1BKbGNTNnYzMkR3SnJXYXJtRW55eXRJMldKOCsvZFhkR0JmeFd3?= =?utf-8?B?WlBYMnZWdEFzWUlkc0lvTDF1MUhjeDhMT3lxbGN4QlE1NnFvUUdLM3YvRUln?= =?utf-8?B?eCszYytWWThwc29jS2NINllxN3p1UUx2VkFwZ01yRlBVc0FuNlJsZTVzR1Bx?= =?utf-8?B?YUxkZzgvSWUwU0JOdWYwNjFQSmRGeXlrMHlJbVpuU0VjUm9RV1VKajJrOHdH?= =?utf-8?B?a2dzVFlNaXh2UGtSMVBNNmJpdWZEcE4wUURjaFNzejZyNFh4RW10Y1U4TXpB?= =?utf-8?B?ZXdreTJ3RFZhdXRHdHNlVUVGVFpGellaZkkycStGNDZzTTVaNi9IdTdvTFZP?= =?utf-8?B?MUdzeWs4QmRUVVZZd1V1cit2bEQ5SHhNc1A5Y0JHUGtNMmpRZVhuQUZZUXNF?= =?utf-8?B?U0w5NkI0MGVIWHJjV2l5UUxQYlhCc2JPZVBjZVFtZUp6SE1DU0hjM1ZZL2FH?= =?utf-8?B?UjgzSWpHYjZqdVdjT2VOay9GaXMxQytweUdRcGljL0VBdzg3RDdsVU4zWFhX?= =?utf-8?B?c251TFBpY2xzM1JXaENZY09DWlFYNmh3cm1KS2lKVHN3ZlBIemlDRG8xVlBa?= =?utf-8?B?a0I5OFkzTUU4TVNnRTI4KzVrRUhrRks1WExyWGNRa3gvR1JRRGQxR0UxTmZo?= =?utf-8?B?RVhFdktGVmxuQ2tlVGF0Vk1TK2dCNExaSDE5Qm9TUUIzeUMya25BSWRJSFlE?= =?utf-8?B?T0lrZFBrQkVqY1YxUXJpL3NOZExwc1JZaWJ1RFFodGRDK1FERXJ4TjR4bzRJ?= =?utf-8?B?MUEyUzlHWTVxd2lzanRYNnlIcjBibXdQblY5c0lxRWJRNmpTaVNpMTRySWE0?= =?utf-8?B?dmJPNW00cHFsZWROS0tZd3hQRmJ4aUhUS3pWN1ZWQVBoSEFtTklkSDJsRDZw?= =?utf-8?B?NVNHUU14T3M0R3orbnFSVmY0Zjk5aTZ3UzBsdTFmbmlRNTlSN290TU9uOVA5?= =?utf-8?B?UlJWbEF6cDc5UU9SdlVjckNabXpDaXllNnpWN21rK01sUUswVE9qTHVUcEQz?= =?utf-8?B?aURncHA4M0ZudlhzUWlPa2lPaXBSZ2I5ZlNOd0owYzJqVUN5Vmg3NHloZkpN?= =?utf-8?B?OGVvV1RyZGN0dXJWN0ZrMDhFUXF5cjVMUzVLLzNhd1NXWWpaUXRrWHdRMVRF?= =?utf-8?B?d1c1c3NUQkg5Tyt5YXluSGNZMmJlUlI1ODFsTU1NWWo4UXRZeVFHUUUzSjNM?= =?utf-8?B?b1BPVTh2dy82ajRQcTlRNllDem9TS01PcHFIak1hRGpNOUpMd3ovRFdVS1NM?= =?utf-8?B?M1hZWmlkNjNJZ3JZYUtRb2NTRDhKbDZPdThlWDlQRmxFSTBMbmN4cnJ2cllz?= =?utf-8?B?VzFOKzc3MndHU3lLQTVRQmltbS8wVVdBRkU1cjJFWkN4SGRLaFJhUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e09100be-83fc-4536-b6b7-08def13fa14a X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 09:14:32.5341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9yMmWBsBBn9yOgLW3WjATjIusFKoo3jox6QQgGRpLLF2h0NRH4zp/jKeeBemqA4y0FqptvuVNiqE6EKW8yrLxAQl6qCOeMP2/ynNi3agj7s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5964 X-purgate-ID: tlsNG-720697/1785748476-319CB2AC-6A2C863C/0/0 X-purgate-type: clean X-purgate-size: 2256 On 03/08/2026 8:20 am, Andrew Cooper wrote: > diff --git a/xen/arch/x86/x86_emulate/decode-lite.c b/xen/arch/x86/x86_emulate/decode-lite.c > new file mode 100644 > index 000000000000..131cc07d5516 > --- /dev/null > +++ b/xen/arch/x86/x86_emulate/decode-lite.c > @@ -0,0 +1,330 @@ > + > + if ( d & (Imm | Imm8 | Moffs) ) > + { > + if ( d & Imm8 ) > + osize = 1; > + else if ( d & Moffs ) > + osize = 8; > + else if ( osize == 8 && !(opc >= 0xb8 && opc <= 0xbf) ) > + osize = 4; GCC 12 does transform this into sub $0xb8; cmp $7. > + > + switch ( osize ) > + { > + case 1: FETCH(uint8_t); break; > + case 2: FETCH(uint16_t); break; > + case 4: FETCH(uint32_t); break; > + case 8: FETCH(uint64_t); break; > + default: goto bad_osize; > + } On further consideration:         switch ( osize )         {         case 1:         case 2:         case 4:         case 8:             if ( ip + osize > end )                 goto overrun;             ip += osize;             break;         default: goto bad_osize;         } drops nearly 10% of the function:     add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-91 (-91)     Function                                     old     new   delta     x86_decode_lite                              972     881     -91 GCC clearly can't reason about the relationship between osize and sizeof(type), and needs the help. I also tried the further simplification:         if ( osize > 8 || (osize & (osize - 1)) != 0 )             goto bad_osize;         if ( ip + osize > end )             goto overrun;         ip += osize; but interestingly this delta grows the function by 30 bytes.  It only seems to add the block checking osize, meaning that GCC managed to optimise away all of the switch dispatch previously.  In hindsight this is probably quite easy; because we're 64bit only, osize only ever has constant values that GCC can see. Anyway, I've folded in the first optimisation. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 03 09:55:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 09:55:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381331.1624905 (Exim 4.92) (envelope-from ) id 1wqpOk-0001X6-1l; Mon, 03 Aug 2026 09:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381331.1624905; Mon, 03 Aug 2026 09:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqpOj-0001Wz-UO; Mon, 03 Aug 2026 09:55:53 +0000 Received: by outflank-mailman (input) for mailman id 1381331; Mon, 03 Aug 2026 09:55:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqpOi-0001Wm-A2 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 09:55:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqpOh-00B9i8-MV for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 11:55:51 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7065a7-bab6-0a2a0a5309dd-0a2a4503b012-2 for ; Mon, 03 Aug 2026 11:55:51 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7065a5-fae8-0a2a45030019-d1558033c915-3 for ; Mon, 03 Aug 2026 11:55:49 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493b966dd74so10010125e9.3 for ; Mon, 03 Aug 2026 02:55:49 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4980878dcb4sm353186965e9.13.2026.08.03.02.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 02:55:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Cc:Content-Language:References:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785750949; x=1786355749; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :cc:content-language:references:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qmDsnUCui8sqdr2eheUQXwVu5kWQQnxMMLiHzaFa0lM=; b=Iu4/DQI+Dj9lmfWj8bgpE6L/mSD60x+hXjta65RMiYGMnMiJZZ3haLyGeP5NEaM0LR Xgmmf30AhvFlCPcH3X4oRJ4lk+duFOTIUmI675QzRjxrKo6KsCNzhgsthr2COtZJ0Q1/ MI76b/yBIXkhaVKZ313ACr/CiuBdgs+GvQpcbZ4nmOkCBVO8I8/YvE8fokBwgv7FZMEi T8MSUVmi0KA7+ZzwbPq8F5B97jpKQeqo4Qczf8wlSremYwIKe3I4wtiOinVWUKsHMIbD 9TXAk6cEMs1nidGy9ZwLrf/vh3SjiIAC4v6meCMgOqynnZ9GvAYQbxMcoOh6WrU4t1Tr /BPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785750949; x=1786355749; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :cc:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qmDsnUCui8sqdr2eheUQXwVu5kWQQnxMMLiHzaFa0lM=; b=T2EhND8y7nUjwBJlHr3FekB2ZAf60W+UnpoBytKpR28N6nb1xPfDH3z3VsOGtPsp/J 1fZt4nE4ktlsTlGmL+YEaYJbXwZTEaanVWp8gOM0X0c4zNesleFf0tTG+jEW4+YP2Y0Y P//WV1LLrJrnhEwtd2N9XoBuKAuX32D6x/ZlNxPZUJMQ+rPJH+DmLUfd6PUnT+dOgc0k AbnaJ9VUe55msyxeGwb4CEHumjNnbNsf6PItZavDNXruk6nLpsHoKb2cNT9NQ2Uo8M+C zfo3VlUZrOTO0ER+S5SdC7cQqDBz9t47bUoFwWz8z1Ntl30T0BNlDLp9QLbvqyFhGNi/ 6acw== X-Gm-Message-State: AOJu0YzsRo9EmBdXS4ll8txE/YoAqPxbOGS4huDENyxzd6UN4IDmVDd5 eKlnIoK1fCwSRx4GHcvGyIYtGbFU0lqFatWIxxmF77Q//ggibspHrSyX3xMxx5am70joWYo3zwd 7x63v9g== X-Gm-Gg: AR+sD10Eqmuq1f3T2j1bGHWNzZjBix1lx337T1zopHBVlzwgfY5pN/uVefgx9OmbBVM 4THIbBl6rCjLhEC983hByu1NA0+c6TypPPcmLqRpEjJQ31za+NUDi3JEAQ/UFjTG0d8poZ2wYss 8Gmwq+VKSpjpFq9W7qVB3wayPMQx549DhLfwPsHnssTenaPwQVISLkGpVSR/mChNvfTyKEsUPs0 LZsDmtFjkz6nBdX9jzwYfgUgYQ+pPpJI25E1Buj5bQaJq5hkI0DBpczvaQsIws/+RWoNSRFBUxZ Cc5gRf+7R8DignfN/zpgVCnP/S8OWDPoMVUR6JzNuTRsWZbBEMQ7kpH6KbN5l4DbJDggvY2fPM+ H3CF586N6UvR6Qm52Oho2AJppWSd7oKPPxtplIYwG1dn4+e3TwrdFjfaS6uwkGDFbmd+CWYqjdX 1LSvZXilaMsvh3HAcxeiXCWgAsG7967TNIW72i2FhGr4zSfltBdqlTx97c0Y0eFLPPEv5RL6/lk eDs5gT/Legifb+qq+jQSZNyR454+W4uNMUneBl0I2zwA5AaQc09 X-Received: by 2002:a05:600d:8443:20b0:493:e974:41ac with SMTP id 5b1f17b1804b1-4980c6562c5mr157611345e9.16.1785750949416; Mon, 03 Aug 2026 02:55:49 -0700 (PDT) Message-ID: <7e9c755a-0cbd-45f3-9683-069627e540eb@suse.com> Date: Mon, 3 Aug 2026 11:55:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/24] XSM: make .hvm_param*() hooks dependent upon HVM=y To: "Daniel P. Smith" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <7947b62f-6763-4561-b3aa-c451cfa3dacb@suse.com> <1b4d5a82-bdc4-460d-a5a4-59e788fe1c3f@apertussolutions.com> Content-Language: en-US Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1b4d5a82-bdc4-460d-a5a4-59e788fe1c3f@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1785750949-76CF84E9-1CF67549/0/0 X-purgate-type: clean X-purgate-size: 835 On 02.08.2026 17:05, Daniel P. Smith wrote: > On 7/28/26 9:17 AM, Jan Beulich wrote: >> They're unreachable / dead otherwise. >> >> Signed-off-by: Jan Beulich >> --- >> Strictly speaking .hvm_param_altp2mhvm() is dependent upon X86=y as well >> (but oddly not dependent upon ALTP2M=y). > > At a minimum, would it be worth at least adding a comment about the > dependency? Note, this is just a question/suggestion. Just a comment would be too little imo. One way or another we want to sort this properly. With the first question being - why a separate hook, and hence why the double checking for HVM_PARAM_ALTP2M? With further data passed into the hook, the Flask case can easily be dealt with using just a single hook. The XSM_TARGET vs XSM_PRIV makes this a little less nice for dummy. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 10:11:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 10:11:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381345.1624933 (Exim 4.92) (envelope-from ) id 1wqpdn-0005x6-I9; Mon, 03 Aug 2026 10:11:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381345.1624933; Mon, 03 Aug 2026 10:11:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqpdn-0005wz-FG; Mon, 03 Aug 2026 10:11:27 +0000 Received: by outflank-mailman (input) for mailman id 1381345; Mon, 03 Aug 2026 10:11:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqpdl-0005wt-Mw for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 10:11:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqpdk-00EdkD-4a for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:11:24 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a706948-bab6-0a2a0a5309dd-0a2a4508b0ea-18 for ; Mon, 03 Aug 2026 12:11:24 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70694b-f659-0a2a45080019-d155802ced93-3 for ; Mon, 03 Aug 2026 12:11:23 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49553515a8bso30564155e9.1 for ; Mon, 03 Aug 2026 03:11:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b4bdc7sm130641945e9.0.2026.08.03.03.11.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 03:11:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785751883; x=1786356683; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gnOva0LMcogndW3IgqX95g4dwlTyOBKUvXh5mUS4hXs=; b=VOZmgU0D6QdELjqCTXzGwQsX9GLPRegp3YOcTZG9OcDNevvC3L5JvvMjBqxF4jTWHR 5j9Fyf8QdyJlTiWAsWSKUKZkF0E1qwTSZlLOrUNsS5glvvx2WqHvh3lOcnKZdLL9aGoW bVwrp+iUeW5eYPRqc5p4U523wHxb5gEyPzUc0xqmGxLihHRrSGMtyqU2KJBe98LwARiE uPLdOzzEiwi3+4LDmeUx670/uKA0zQS14A7IO7cWcEDUXrzJVmMIIy7VMaQgHdw4B9gA DoMqEqMzO6BRw/w41SY6IXf7O8OgijoRkzZ9J05Uzm+qEWfdKRqvVapXRQwwREuhdH6S P9Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785751883; x=1786356683; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gnOva0LMcogndW3IgqX95g4dwlTyOBKUvXh5mUS4hXs=; b=g1fkTWnxdpVjgX/3nqdrWF9u3unhh3K8tv/P9+ukEAwP2DScJX9Oy6u7XQa9gmZw2Y 7D+1aMOjt35n3kP79ckNToNexYDu1QdCU11kp/5pwAiP1SZQpa20VtQKDfhVNvhdvLvB 0ZrpTGl9rsTMqk4dYR6EUeEvDrUkFnxheCTkew1vPqFRJC9kjyCw6sA+o7odNIrMMecW KeFWjMhBT9wRxgxxZ/w7nhQOTTnIR7WVZNGqJh79mbIkSENvawg0O+0h6prCBlw9oCTq o3f53nrTMtXqcYZDFMNaxAH3b8TKird64BHR7uyj6myuqFFp7sbX8gGApXPsZPPx5ht+ zYXA== X-Forwarded-Encrypted: i=1; AHgh+Rqzn1WGT/5i7heShEnhubFRJzDHpboFEzWbsr+UL6ac7DlyukozXdNP4I7G18hoWWJws5Jy/QM1glM=@lists.xenproject.org X-Gm-Message-State: AOJu0YwCDvMRT0M6InV4iBVSKNr1PwVxbvRlOa7ukke8WBJ7KO4UOGjA xloEhFkz6l1RNTS0aR8xmnSFSzBQX1TPHJPcSNbi0YOvQk4QdnppwJrD1o/3bRnm6w== X-Gm-Gg: AR+sD11VdvfprLKYaUpMLZObDFAY0ghScY6IpbjBZZ6JlPDaXpGerv9tn33zOsLONfl nm/TJi2eweCRjuh5H//F6j7CxaG4widF4YI3lZQct79cSdj3OQK116mOKroFb0QgQ+bMT0kOTiU zyAC/h6hHtINW9I5a75f5Nj9rtrbdPpBKo4DfLT29ztloQ1yM/FVYLKK+gRWhYOgDw5Q7l/2wlb e+gSepUjr1lyo7yHCD7FyII6iKgvwZuGIbWq4yd3vxHsxvanNV2oxSjqiCKs3Ph/11xxCBipBK2 c2c71VPBWZbJEL7Ntm7vtnROmlDuhjCkI1DJh4uKHEze360dJPeVy1emnHimweASpGfQI2mYH3d ufTQkKPUDX+3BZ2SW6RnDAxPE1FZcRsRwC7snrwOtjcG1Gv4p5Yl5zQLfFbS5vtIiVjoKYOssI1 oVpxMQ17lruaIwiLZ3luSOheuZ1x1sDPeBqb9PBTAREdodyMBcLCvoarJmwSJX+5XBQZLEm0Wk/ XfrxGGnvpdNawV7ibRnWMqTqJRBaOSRF9Fgk/5cKb0APNam4Ka6nDYduIYkhSU= X-Received: by 2002:a05:600d:849c:10b0:499:48bb:417e with SMTP id 5b1f17b1804b1-49948bb41d5mr5396535e9.2.1785751882919; Mon, 03 Aug 2026 03:11:22 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 12:11:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/24] x86/mm: get_page_from_l1e() is PV-or-shadow-only To: "Daniel P. Smith" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <07e90200-95b5-413f-9259-7f0481d36521@suse.com> <4531d02a-3a37-4c57-ba17-32034ba08cf9@apertussolutions.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <4531d02a-3a37-4c57-ba17-32034ba08cf9@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c1860d/1785751883-CD34D87B-CF92F006/0/0 X-purgate-type: clean X-purgate-size: 2352 On 02.08.2026 17:55, Daniel P. Smith wrote: > On 7/28/26 9:18 AM, Jan Beulich wrote: >> Otherwise the function is unreachable, violating MISRA C:2012 rule 2.1. >> With the function compiled out, its dedicated XSM hook also becomes >> unreachable, so it is similarly guarded. >> >> Signed-off-by: Jan Beulich >> --- >> It feels suspicious that the .priv_mapping() check is used for HVM guests >> in shadow mode, but not for ones in HAP mode. > > I believe a hint to it is laying in the comment, > > /* > * Let privileged domains transfer the right to map their target > * domain's pages. This is used to allow stub-domain pvfb export to > * dom0, until pvfb supports granted mappings. At that time this > * minor hack can go away. > */ > > Correct me if I am wrong, but get_page_from_l1e() is only used by PV and > HVM + Shadow. When in HVM + HAP is mapping a guest page, it is done > through p2m_get_foreign() which will then be covered by > xsm_map_gmfn_foreign(). So only HVM + Shadow can hit TARGET_HACK check. Yes, sure; that wasn't the point of my comment. The point was that I'd expect _the same_ hook to be used by the other path. Aiui if you make a policy, you want same situations dealt with the same. Hence there shouldn't be a need to express the same thing two ways. > I think the question is how to address the TARGET_HACK situation. I fear I don't really know what exactly you mean here. >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -837,6 +837,8 @@ static int cf_check print_mmio_emul_rang >> } >> #endif >> >> +#if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) >> + >> /* >> * get_page_from_l1e returns: >> * 0 => success (page not present also counts as such) >> @@ -1038,6 +1040,8 @@ get_page_from_l1e( >> return -EBUSY; >> } >> >> +#endif /* CONFIG_PV || CONFIG_SHADOW_PAGING */ >> + > > Would it also not be prudent to #ifdef out the declaration in asm/mm.h? Ah, yes, this looks possible for this function - the decl isn't needed for any DCE-ing by the compiler. > I think it would be a good defensive approach to condition out the > header declaration. Otherwise, > > Acked-by: Daniel P. Smith Thanks, also for all the others. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 10:34:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 10:34:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381356.1624942 (Exim 4.92) (envelope-from ) id 1wqpzz-0001ji-Ck; Mon, 03 Aug 2026 10:34:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381356.1624942; Mon, 03 Aug 2026 10:34:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqpzz-0001jb-A7; Mon, 03 Aug 2026 10:34:23 +0000 Received: by outflank-mailman (input) for mailman id 1381356; Mon, 03 Aug 2026 10:34:23 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqpzy-0001jU-RW for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 10:34:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqpzy-007cMG-84 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:34:22 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a706ea6-5cb7-0a2a0a5109dd-0a2a450a85da-28 for ; Mon, 03 Aug 2026 12:34:22 +0200 Received: from [209.85.218.41] (helo=mail-ej1-f41.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a706ead-f2d2-0a2a450a0019-d155da29c161-3 for ; Mon, 03 Aug 2026 12:34:22 +0200 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c1c4c7ddaf6so490500366b.3 for ; Mon, 03 Aug 2026 03:34:22 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd450d731sm524364066b.47.2026.08.03.03.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 03:34:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785753261; x=1786358061; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=RW+5JNTzwVuFTHOA2ETGOuWyQINN5n5cjuH4cgKFvXg=; b=YtYEbHloRzvkzvnlBgxOR8SFEHBvgvWfjXG1CRsL39XTeAyQXNrUgocv2ZPYw45i6s gY51SbXHuxi9JzlkXJcCvup+j0dafxkcrwZOm6eVaHsX5fn7WQgvf+dIy5GlloExvxMO MuOJTFGJK++mKnv2wvGojhAK3x9taC0JF3dCiYYWnYsM6yqPz/lCfeBXmcO9iGXkyasp hAIvO/m6whunp1D44/gir+u3phPLwqSppz4lF3VFBNGjqtM+26XwL/X0oUjY5UmtMFtP xF+V8gV+6ZfQ38S8QptYOHb7Wh1jDzuKAl9sBKb8Wyj+i17Dh/v3Ycq6WnxOeXL+NOCy cXdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785753261; x=1786358061; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RW+5JNTzwVuFTHOA2ETGOuWyQINN5n5cjuH4cgKFvXg=; b=Ulnffc7cuJ4LCy0X00lj1gUS+rFCdVuVxniRJj8rn4Fwe+1OQ5qciZy4iidS4dm2+E dLFacrxsgIZzCWUSiyBl7iA8a2j8OjYeWypspEx2a49K+/TEe0gjCaPXRbYKM6Dwlthc qQYXKXXgbhOc1HouGXzZJBN4T51SWutyPBRTI0eDiNbZlA9TNOBmcXRoMmjKbxk015Ka xZ+qIpOdRoYQeMlvGQzIaAJr1xOYKY5ktXN03JHWPGD6zi2DpjIS+P06qtlsy9Znx9rM p98r/9MZEaJWbzt5a9OhkVys+8goXpA6nQ8cvA+iYJ9rqbx37+Rq/4QAdGMcvhx2+lXC a/dQ== X-Forwarded-Encrypted: i=1; AHgh+Rr6SHqBAMJkbwb6MeXI0gAjWoe80/jrRP7+fi9N7oH/mZsmJxZbITM593kkjcZy3QFxM9vUprk6vCs=@lists.xenproject.org X-Gm-Message-State: AOJu0YyhqL4vJobiTjanPvMQjJGTIIgFCQBuws+p1fNKxQUqRSfJneEZ JE3lbuI6//b6+JTVvvO1cSUfT1MIJQ+jGvt6yQVYIoPplp1ZsK+6q1TympWSMBnGyi0= X-Gm-Gg: AR+sD12bVu1BksX/3+bWRGae4K3JC6zSf4u/jM4OFFjYR4qrFVK/OqMvBZWisEcKNPs F6PyeRs4yziB1Hs8IAqk/ZEUPDl+mdf8UPg6OpTFeNjP1dMzO/vy15/5DyqOArNp78gU77qtVD4 flmpw7s27kHkh6q1AOv2FdrIX86VQ18+VDE/F9FMMYbGkzIIkOcErPR4pCmDha9pT3mMRQd1pN2 J0RBgN2OKqo30mwPc9ToqkDlXbCnjSsGsi0OSpfm+UxhXEy343GE5AV1OvNp3eu1nLwmbmvv/lx yyQtdm0DoYkoKAFgd8JFb9P3T1XEyMIRkOHh8bu/uWnp9qj2B4mztkRhesZ9EOUmRVH+MVM8dtG rrNXajw3fq7hl0ZyIH20b21LXzPipiEFjBCqQ2Ni4IDpwNRKYsh0RKLEqOke7VXybF04xPX3Jv/ 3hd4t7j8MfCEuqJL8luJ6+IvEfYOYD8pBPpVsG5CkxetXDwr5wSNs9XYCTcwAWhOyTWtLNyN8w/ mkpox4uslS6hcCK01fQpWdLkXro1vDCr3ZsbCBB6wYwtgObCTyRmqcYim0O6wyjm1xDyXZUlj9S 2m73LlJliH9VTFE= X-Received: by 2002:a17:907:c318:b0:c1f:b883:ed3b with SMTP id a640c23a62f3a-c1ff13e1e3cmr705662966b.4.1785753261255; Mon, 03 Aug 2026 03:34:21 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 12:34:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] xen/sched: split scheduler vtable from scheduler To: Furkan Caliskan , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com References: <20260803050614.5222-1-frn1furkan10@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------NhSDnOO0pxwLPqjEg1D6vQsE" X-purgate-ID: tlsNG-4011c0/1785753262-53ED2CFC-E433D674/0/0 X-purgate-type: clean X-purgate-size: 13198 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------NhSDnOO0pxwLPqjEg1D6vQsE Content-Type: multipart/mixed; boundary="------------0wFAAmCsdOzQMaRLESNA7cV0"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Furkan Caliskan , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com Message-ID: Subject: Re: [PATCH 0/7] xen/sched: split scheduler vtable from scheduler References: <20260803050614.5222-1-frn1furkan10@gmail.com> In-Reply-To: <20260803050614.5222-1-frn1furkan10@gmail.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------0wFAAmCsdOzQMaRLESNA7cV0 Content-Type: multipart/mixed; boundary="------------CBTZ4VXU29aSPHmdICCq7QhP" --------------CBTZ4VXU29aSPHmdICCq7QhP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjYgMDc6MDYsIEZ1cmthbiBDYWxpc2thbiB3cm90ZToNCj4gRWFjaCBzdHJ1 Y3Qgc2NoZWR1bGVyIGN1cnJlbnRseSBkb3VibGVzIGFzIGJvdGggYSBzY2hlZHVsZXINCj4g YmFja2VuZCdzIHN0YXRpYyB2dGFibGUgKG5hbWUsIG9wdF9uYW1lLCBzY2hlZF9pZCBhbmQg ZXZlcnkNCj4gZnVuY3Rpb24gcG9pbnRlcikgYW5kIHRoZSBwZXItY3B1cG9vbCBydW50aW1l IG9iamVjdCB0aGF0DQo+IHNjaGVkdWxlcl9hbGxvYygpIGFsbG9jYXRlcy4gQmVjYXVzZSB0 aGVzZSBhcmUgdGhlIHNhbWUgdHlwZSwNCj4gc2NoZWR1bGVyX2FsbG9jKCkgbWVtY3B5KClz IHRoZSBlbnRpcmUgdnRhYmxlIGludG8gYSBmcmVzaCBoZWFwDQo+IGFsbG9jYXRpb24gZm9y IGV2ZXJ5IGNwdXBvb2wgaXQgY3JlYXRlcy4gV2l0aCBOIGNwdXBvb2xzIHJ1bm5pbmcNCj4g dGhlIHNhbWUgc2NoZWR1bGVyLCB0aGlzIGR1cGxpY2F0ZXMgTiBjb3BpZXMgb2YgaWRlbnRp Y2FsIGZ1bmN0aW9uDQo+IHBvaW50ZXJzIGFuZCBpZGVudGlmeWluZyBmaWVsZHMgdGhhdCBu ZXZlciBkaWZmZXIgYmV0d2Vlbg0KPiBpbnN0YW5jZXMgLSB0aGUgb25seSBmaWVsZHMgdGhh dCBhcmUgZ2VudWluZWx5IHBlci1jcHVwb29sIGFyZQ0KPiBzY2hlZF9kYXRhIGFuZCBjcHVw b29sLg0KPiANCj4gVGhpcyBzZXJpZXMgc3BsaXRzIHRoZSB2dGFibGUgb3V0IGludG8gaXRz IG93biB0eXBlLCBzdHJ1Y3QNCj4gc2NoZWRfb3BzLCBzbyBpdCBjYW4gYmUgc2hhcmVkIGJ5 IGV2ZXJ5IGNwdXBvb2wgdXNpbmcgYSBnaXZlbg0KPiBzY2hlZHVsZXIgaW5zdGVhZCBvZiBj b3BpZWQgcGVyIGNwdXBvb2wuIHN0cnVjdCBzY2hlZHVsZXIgaXMgbGVmdA0KPiBob2xkaW5n IG9ubHkgd2hhdCBpcyBhY3R1YWxseSBwZXItaW5zdGFuY2U6IGEgcG9pbnRlciB0byB0aGUN Cj4gc2hhcmVkIHNjaGVkX29wcywgcGx1cyBzY2hlZF9kYXRhIGFuZCBjcHVwb29sLg0KPiAN Cj4gVGhlIHNlcmllcyBpcyBzdHJ1Y3R1cmVkIGFzIGludHJvZHVjZS9taWdyYXRlL3JlbW92 ZSwgc28gdGhhdA0KPiBldmVyeSBjb21taXQgYnVpbGRzIGFuZCBib290cyBvbiBpdHMgb3du Og0KPiANCj4gICAgLSBUaGUgZmlyc3QgcGF0Y2ggYWRkcyBzdHJ1Y3Qgc2NoZWRfb3BzLCBS RUdJU1RFUl9TQ0hFRF9PUFMoKSwNCj4gICAgICBhbmQgYSBzY2hlZF9vcHNfYXJyYXlbXSBh bG9uZ3NpZGUgdGhlIGV4aXN0aW5nIHNjaGVkdWxlcnNbXSwNCj4gICAgICBleHRlbmRpbmcg ZXZlcnkgbG9va3VwIHBhdGggKHNjaGVkdWxlcl9hbGxvYygpLA0KPiAgICAgIHNjaGVkX2dl dF9ieV9uYW1lKCksIHNjaGVkdWxlcl9pbml0KCkpIHRvIHNlYXJjaCBib3RoIGFycmF5cy4N Cj4gICAgICBUaGlzIGlzIHB1cmVseSBhZGRpdGl2ZSAtIG5vIHNjaGVkdWxlciB1c2VzIGl0 IHlldC4NCj4gDQo+ICAgIC0gVGhlIG5leHQgZml2ZSBwYXRjaGVzIGVhY2ggbWlncmF0ZSBv bmUgc2NoZWR1bGVyIGJhY2tlbmQNCj4gICAgICAoY3JlZGl0LCBjcmVkaXQyLCBydGRzLCBh cmluYzY1MywgbnVsbCkgZnJvbSBzdHJ1Y3Qgc2NoZWR1bGVyDQo+ICAgICAgdG8gc3RydWN0 IHNjaGVkX29wcy4gRWFjaCBpcyBzbWFsbCwgbWVjaGFuaWNhbCwgYW5kDQo+ICAgICAgaW5k ZXBlbmRlbnRseSBiaXNlY3RhYmxlLCB3aXRoIG5vIGJlaGF2aW9yYWwgZGlmZmVyZW5jZSwg c2luY2UNCj4gICAgICBzY2hlZHVsZXJfYWxsb2MoKSBidWlsZHMgYW4gaWRlbnRpY2FsIHJ1 bnRpbWUgc3RydWN0IHNjaGVkdWxlcg0KPiAgICAgIHJlZ2FyZGxlc3Mgb2Ygd2hpY2ggYXJy YXkgYSBtYXRjaCBpcyBmb3VuZCBpbi4NCj4gDQo+ICAgIC0gVGhlIGZpbmFsIHBhdGNoIHJl bW92ZXMgdGhlIG9sZCBzY2hlZHVsZXJzW10gYW5kDQo+ICAgICAgUkVHSVNURVJfU0NIRURV TEVSKCkgcGF0aCBub3cgdGhhdCBub3RoaW5nIHVzZXMgaXQsIHNocmlua3MNCj4gICAgICBz dHJ1Y3Qgc2NoZWR1bGVyIGRvd24gdG8geyBvcHMsIHNjaGVkX2RhdGEsIGNwdXBvb2wgfSwg YW5kDQo+ICAgICAgdXBkYXRlcyBldmVyeSBhY2Nlc3NvciBpbiBwcml2YXRlLmggYWNjb3Jk aW5nbHkuDQo+IA0KPiBGdXJrYW4gQ2FsaXNrYW4gKDcpOg0KPiAgICB4ZW4vc2NoZWQ6IGlu dHJvZHVjZSBzdHJ1Y3Qgc2NoZWRfb3BzIGFzIGEgc2hhcmVkIHNjaGVkdWxlciB2dGFibGUN Cj4gICAgeGVuL3NjaGVkOiBjcmVkaXQ6IG1pZ3JhdGUgdG8gbmV3IHNjaGVkX29wcw0KPiAg ICB4ZW4vc2NoZWQ6IGNyZWRpdDI6IG1pZ3JhdGUgdG8gbmV3IHNjaGVkX29wcw0KPiAgICB4 ZW4vc2NoZWQ6IHJ0ZHM6IG1pZ3JhdGUgdG8gbmV3IHNjaGVkX29wcw0KPiAgICB4ZW4vc2No ZWQ6IGFyaW5jNjUzOiBtaWdyYXRlIHRvIG5ldyBzY2hlZF9vcHMNCj4gICAgeGVuL3NjaGVk OiBudWxsOiBtaWdyYXRlIHRvIG5ldyBzY2hlZF9vcHMNCj4gICAgeGVuL3NjaGVkOiByZW1v dmUgb2xkIHNjaGVkdWxlciByZWdpc3RyYXRpb24sIHNocmluayBzdHJ1Y3Qgc2NoZWR1bGVy DQo+IA0KPiAgIHhlbi9hcmNoL2FybS94ZW4ubGRzLlMgICAgICB8ICAgMiArLQ0KPiAgIHhl bi9hcmNoL3BwYy94ZW4ubGRzLlMgICAgICB8ICAgMiArLQ0KPiAgIHhlbi9hcmNoL3Jpc2N2 L3hlbi5sZHMuUyAgICB8ICAgMiArLQ0KPiAgIHhlbi9hcmNoL3g4Ni94ZW4ubGRzLlMgICAg ICB8ICAgMiArLQ0KPiAgIHhlbi9jb21tb24vc2NoZWQvYXJpbmM2NTMuYyB8ICAxMSArLS0t DQo+ICAgeGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMgICAgIHwgIDgwICsrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tDQo+ICAgeGVuL2NvbW1vbi9zY2hlZC9jcHVwb29sLmMgIHwgICA2 ICstLQ0KPiAgIHhlbi9jb21tb24vc2NoZWQvY3JlZGl0LmMgICB8ICAgNSArLQ0KPiAgIHhl bi9jb21tb24vc2NoZWQvY3JlZGl0Mi5jICB8ICAgNSArLQ0KPiAgIHhlbi9jb21tb24vc2No ZWQvbnVsbC5jICAgICB8ICAgNSArLQ0KPiAgIHhlbi9jb21tb24vc2NoZWQvcHJpdmF0ZS5o ICB8IDEwMCArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0NCj4gICB4ZW4v Y29tbW9uL3NjaGVkL3J0LmMgICAgICAgfCAgIDUgKy0NCj4gICB4ZW4vaW5jbHVkZS94ZW4v eGVuLmxkcy5oICAgfCAgIDggKy0tDQo+ICAgMTMgZmlsZXMgY2hhbmdlZCwgMTE2IGluc2Vy dGlvbnMoKyksIDExNyBkZWxldGlvbnMoLSkNCj4gDQoNCllvdSBoYXZlIGEgc2VyaWVzIGhl cmUgd2hpY2ggaXMgYWRkaW5nIDExNiBsaW5lcyBhbmQgcmVtb3ZpbmcgMTE3Lg0KDQpQYXRj aCA3IGFsb25lIGlzIHJlbW92aW5nIDI0OCBsaW5lcyB3aGlsZSBhZGRpbmcgNjcgbGluZXMu DQoNClNvIGluIHRoZSBlbmQgdGhlcmUgaXMgYSBzaW5nbGUgcGF0Y2ggaW4gdGhpcyBzZXJp ZXMgd2hpY2ggaGFzIG1vcmUgY29kZQ0KY2h1cm4gdGhhbiB0aGUgY29tcGxldGUgc2VyaWVz IHdoZW4gYWRkZWQgaW4gb25lIGdvLg0KDQpJT1c6IG1ha2luZyB0aGlzIGp1c3QgYSBzaW5n bGUgcGF0Y2ggd291bGQgYmUgZWFzaWVyIHRvIHJldmlldyB0aGFuIHRoZQ0KbGFzdCBwYXRj aCBhbG9uZSwgbGV0IGFsb25lIGFsbCB0aGUgdGVtcG9yYXJ5IG1vZGlmaWNhdGlvbnMgd2hp Y2ggd291bGQNCmJlIGdvbmUgd2hlbiBtZXJnaW5nIGFsbCBwYXRjaGVzIGludG8gb25lLiBB bmQgd2l0aCB0aGF0IHlvdSBjb3VsZCBldmVuDQpkcm9wIHNvbWUgb2YgdGhlIHJlbmFtaW5n IHlvdSBkaWQgKGUuZy4gaW4gdGhlIGxpbmtlciBmaWxlKSwgbWFraW5nIHRoZQ0KZGlmZiBl dmVuIHNtYWxsZXIuDQoNCkkgYWdyZWUgd2l0aCB0aGUgb3ZlcmFsbCBnb2FsLCBidXQgSSdt IHNwYXJpbmcgbXkgdGltZSBkb2luZyBhIHRob3JvdWdoDQpyZXZpZXcgb2YgdGhlIHNlcmll cyBpbiB0aGlzIHNoYXBlLg0KDQoNCkp1ZXJnZW4NCg== --------------CBTZ4VXU29aSPHmdICCq7QhP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------CBTZ4VXU29aSPHmdICCq7QhP-- --------------0wFAAmCsdOzQMaRLESNA7cV0-- --------------NhSDnOO0pxwLPqjEg1D6vQsE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpwbqwFAwAAAAAACgkQsN6d1ii/Ey9T wwgAjxhwwwWWs686CCBFHwePzXm29voDe8LchNCVr02zbdtFKaSEqU1rGaMJl39LT4pgr8CHOnFy KIijRAkVwI5TgcFoPamVfWN3WJ56teAzVjEC7thKFi/StkbxvrXYJa6TIrTUzBnsLl96HNPQJMGh izbuaoyhOgw3IUSd2hF1RTYf6gVF8cLEX8ZHlL/q1jYH5Qx1+hJvKc1esPqobcaMOzQP2wWPaNb3 xL+b219muAc1khjAS9GGVnUIeV9w2ErJcPM7moAZHc8oDpX+yNEgk5Vq+XiZ8pJYCOGj9fuBBcXS ieQz+a0t0jjLwMPuvGzMtMytV2ew4zn8cCVUXe++TA== =r5DE -----END PGP SIGNATURE----- --------------NhSDnOO0pxwLPqjEg1D6vQsE-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 10:37:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 10:37:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381363.1624953 (Exim 4.92) (envelope-from ) id 1wqq2k-0002MZ-QM; Mon, 03 Aug 2026 10:37:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381363.1624953; Mon, 03 Aug 2026 10:37:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqq2k-0002MS-Mp; Mon, 03 Aug 2026 10:37:14 +0000 Received: by outflank-mailman (input) for mailman id 1381363; Mon, 03 Aug 2026 10:37:14 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqq2k-0002MH-07 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 10:37:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqq2i-004fKp-Hp for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:37:12 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a706f4f-e002-0a2a0a5209dd-0a2a4507ca84-28 for ; Mon, 03 Aug 2026 12:37:12 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a706f58-b4ea-0a2a45070019-d1558034ccd5-3 for ; Mon, 03 Aug 2026 12:37:12 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4955aa106b1so17849745e9.0 for ; Mon, 03 Aug 2026 03:37:12 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd456a6besm30189824f8f.22.2026.08.03.03.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 03:37:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785753432; x=1786358232; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=W1YOnSiXDFhTOBMMsgIEia7N6LZYw+jLgptOHs4zxWg=; b=SLbETNjhWzYILVPBwHWG9/LWpor6ZsSC+L3Ij5OuOnMstXU9AbD2yJ9S4Xv7Da2bbT 3Ba7cX8McoVO/106neU8za4wQZpgtHn2RhBLetPp+zmTutlKJQZyP+P4Mw+azdldW2vi q9ISdK58wP3Ov7kBQ4g0iaha73BD3zsjj5qU8xJphQRNOWLf9cDK42TnHm8Zt4Lhm5ab Ky9h2+lagY3nQLia2L1E2FHNHdfIFjksV81NTsZgriri1wODHAR4hYHYHutrDtJAbKMl lDy6dfBK3KJWPepPhFXsIIXVdR6rPsdWB4ja2oxdmdz/8nZX3oZ7yuMXzCYAyh0vmyt3 Xz+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785753432; x=1786358232; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W1YOnSiXDFhTOBMMsgIEia7N6LZYw+jLgptOHs4zxWg=; b=Y6+qaMlarSGQ5OIkQzAz3r+qhhus5Nn6QacZ4sbxgkf4wcznlk0DfdsOcjN60zN/Wj B2JInbWW8nuDX7Wd+hhK85rNbbCBUMM/GBZxg7PWny6N8g4zoHgmN5HXxSIOSHMWd3i2 RhEGs/3XBYGTAL2vBGeYTXEhLFeowPSa2hZfszsWSF5scYEsTN6wRa5MPeCr18Xx0Th0 3rXhVXFmcjqqRRdm0j5k2s5K/FWkw4OYckkpGsekxv4JC5+6nHHRUITIpYaeXglSk2EQ pGTUBOjygxkej5sqEjQw5p1iw/llx2eM2A8vEInVUsrg9pyRJ7s4nYCnOGhENTQjvKvh ODwQ== X-Forwarded-Encrypted: i=1; AHgh+RrtJYP9kuDP+tg8mYKQhgC6X6/IF9lcZLpfO+nrRkt1dAJdJsx+QmZNokZ3RROXWefLEaTX1K0Eja8=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz7cbB3wzL4M+MVl/oWBQJJ0R5ppfr6wi0SYPSG1dANnPFlhT3j f7dODg13Mxf/1bnAkz8oY7+7E5A/Tvh1fecMyuwwjVymNVYp3JVf/4OdtzNJCegdrA== X-Gm-Gg: AR+sD13dvl2i3fKIxyiDUo7thAupV5mdVfn8bRs875jEdf0LNakXRN5T5IE02ijJC9R lNzRdzi+TlOkBHLaTzk/EC9zENRrSjf7XMPwqwgL/CR6yv2OdwnPB6qbFWNACSxE6++DDhAOYQd /O7g3WibB4bdl4+y8hV+WkX+ipgGn5SEgCsEDsSG9rzDfeYdTRfJPbAD/FoJmGe1otonUQpH/4c 1jsEXKFmWwJ4+v8XmQfa18J1oyd+L68xbz80979pzOlEVt2OkUsJIYI0gqd7rz+NCgepIYEWpR6 OEovdaLZp2pwslmCD1WCBuxOKtQaJyKWRCdQmu9lmKc6Z6fO6plsRPWDwFLLguheOyxGKm+BsMX MZxpIGLRaO6qgShQAwp6VrmpeoLxxcndd8xMcsEyZ1W0GsXPkwGyjLUhSIPwuO9kzgrynZT6acd oti57ypbrwPrPh4wT+pgA6yzYcfsIct14Evm5c90zE+yqVO3/Bsnek/p0fQCnxUgu1bwKm/1hOl Ija2LB8/K5ZozRyI48dN1/QDR6yIFcRkIVgcP0+CuogqIYcJgSF X-Received: by 2002:a05:600c:2294:b0:492:4e09:9fc1 with SMTP id 5b1f17b1804b1-4980c67af97mr170252525e9.15.1785753431921; Mon, 03 Aug 2026 03:37:11 -0700 (PDT) Message-ID: <3b1e19f9-ed72-4898-aa1a-f9f43c1700a0@suse.com> Date: Mon, 3 Aug 2026 12:37:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/17] xen/riscv: add basic VGEIN management for AIA guests To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <6501f040-ea59-4e78-8854-030f786dbcf7@suse.com> <191a9ddc-9f37-4d26-9141-7dfaf88cb26c@gmail.com> <489a1b05-4ae5-44ac-a73b-485669190b59@suse.com> <79ea95df-29bf-4c9e-8097-2c2b991f27bf@suse.com> <39aa93bb-edb8-4f05-8b62-c2677d12fb0b@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <39aa93bb-edb8-4f05-8b62-c2677d12fb0b@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1785753432-A68D9AE4-5E3DCEC8/0/0 X-purgate-type: clean X-purgate-size: 3987 On 31.07.2026 16:59, Oleksii Kurochko wrote: > > > On 7/30/26 6:03 PM, Jan Beulich wrote: >> On 30.07.2026 17:46, Oleksii Kurochko wrote: >>> On 7/30/26 9:42 AM, Jan Beulich wrote: >>>> On 29.07.2026 16:55, Oleksii Kurochko wrote: >>>>> On 7/27/26 5:41 PM, Jan Beulich wrote: >>>>>> On 20.07.2026 18:02, Oleksii Kurochko wrote: >>>>>>> It was decided to add support for IMSIC from the start instead of having APLIC >>>>>>> operate in direct delivery mode, as it requires a trap-and-emulation approach, >>>>>>> which is not optimal from a performance standpoint. >>>>>>> >>>>>>> AIA provides a hardware-accelerated mechanism for delivering external >>>>>>> interrupts to domains via "guest interrupt files" located in IMSIC. >>>>>>> A single physical hart can implement multiple such files (up to GEILEN), >>>>>>> allowing several virtual harts to receive interrupts directly from hardware. >>>>>>> >>>>>>> Introduce per-CPU tracking of guest interrupt file identifiers (VGEIN) >>>>>>> for systems implementing AIA specification. Each CPU maintains >>>>>>> a bitmap describing which guest interrupt files are currently in use. >>>>>>> >>>>>>> Add helpers to initialize the bitmap based on the number of available >>>>>>> guest interrupt files (GEILEN), assign a VGEIN to a vCPU, and release it >>>>>>> when no longer needed. When assigning a VGEIN, the corresponding value >>>>>>> is written to the VGEIN field of the guest hstatus register so that >>>>>>> VS-level external interrupts are delivered from the selected interrupt >>>>>>> file. >>>>>> >>>>>> And when exactly is this "assignment" intended to occur? vgein_assign() and >>>>>> vgein_release() have no callers here, so this remains entirely unclear. >>>>> >>>>> [A] Agreed, I should have added that information to the commit message: >>>>> >>>>> VGEIN is assigned (via vgein_assign()) before jumping to the new vCPU >>>>> execution context (in continue_new_vcpu()) and is re-assigned during >>>>> vCPU migration from one pCPU to another. >>>>> >>>>> VGEIN is released (via vgein_release()) on the old pCPU during migration. >>>> >>>> That is, state of that vCPU is held in hardware for perhaps an extended >>>> period of time after the vCPU was last de-scheduled. That's a fair >>>> optimization (we do something similar on x86, albeit that has been >>>> increasingly under question lately). However, doesn't this then require >>>> sync_local_execstate() to become non-empty? >>> >>> IIUC, sync_local_execstate() is needed for the lazy context switch case >>> when switching from vCPUA to the idle vCPU. >> >> Or when full state is to be obtained for a vCPU, for example. > > I assume you're referring to XEN_DOMCTL_getvcpucontext, right? Yes. > In general, it seems that sync_local_execstate() is primarily an > optimization. If lazy switching isn't supported, then every time a vCPU > is de-scheduled, its state must be fully saved to memory. My > understanding is that everything will still work correctly, just less > efficiently. The lazy switching is an optimization, yes. If any state is kept in hardware, sync_local_execstate() has to be used when full state of a vCPU is to be obtained. Supplying back stale state of "guest interrupt files" can't be correct. (Of course you can also arrange to obtain up-to-date state by custom means, but imo that's likely less desirable.) > I'm curious how much this optimization actually helps. How often does it > happen that a vCPU is de-scheduled from a pCPU and then immediately > scheduled back onto the same pCPU without any other vCPU being scheduled > in between? That heavily depends on overall load of the system. When pCPU-s aren't over-subscribed, a HVM vCPU getting de-scheduled to wait for qemu to handle a certain operation may very well be able to resume on the same pCPU after completion of the ioreq. The less overhead there, the better. (Just to give an example.) Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 10:41:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 10:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381373.1624960 (Exim 4.92) (envelope-from ) id 1wqq6c-0004f4-CZ; Mon, 03 Aug 2026 10:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381373.1624960; Mon, 03 Aug 2026 10:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqq6c-0004ex-9Y; Mon, 03 Aug 2026 10:41:14 +0000 Received: by outflank-mailman (input) for mailman id 1381373; Mon, 03 Aug 2026 10:41:13 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqq6b-0004er-6Z for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 10:41:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqq6a-004uuD-JD for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:41:12 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70703b-5cb7-0a2a0a5109dd-0a2a450885bc-28 for ; Mon, 03 Aug 2026 12:41:08 +0200 Received: from [209.85.221.51] (helo=mail-wr1-f51.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a707044-f659-0a2a45080019-d155dd33a93f-3 for ; Mon, 03 Aug 2026 12:41:08 +0200 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4720f3bf164so2502575f8f.1 for ; Mon, 03 Aug 2026 03:41:08 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41e2cf1sm31636029f8f.10.2026.08.03.03.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 03:41:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785753668; x=1786358468; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IawgCP+jZFb3uk7JaxA8OP7ijbXNyIydlK45oaJI28w=; b=STED+EnLx9pXeJULZgrne/eA/TX8R8pIn5YHWvk9navYUEXXSaNKjlpEd+77MeXKZV ZFjfKhxpiyCO5wwMPkMZO7M8vElV9o0uXE6IHEIuUpkwPPJ0+4mDftcUD9pKqech4NNp TTfV1/xEL3hMSF8f0ncKZq1bxq50zRhjmv2cWNaNK0D5aRcFPDpnoLBbYvVPy68DRks3 /jKJOyt1MpGSee22NY0dnb/6dwG7R/mu6C1xicaBHzNFni6gbaykiWvEX/qLw4DGEBcO 4Kpmmwn8qvo1cF1zlbChWBqi14VPivgNeXe0IcQ1tlEBNMKYAE8hQCtlOnlJmoC8G77C Cc0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785753668; x=1786358468; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IawgCP+jZFb3uk7JaxA8OP7ijbXNyIydlK45oaJI28w=; b=DsnKHt0/fRC5P+gpTIyAceYkxwv4XeHwP99aceA/Ix6+yYmCc6t26mZHEYLR9tWmzH 1MYVFR7x7LAdLkNbYFQLYeK1qSoaPQDSHpZFwRvYtSN3UKvmO4ZxVXBNX+JIdGfQxEb6 b/PmlGoRCwl8nMx/KzAdv2Bn/Ixr4f6d71OpciHpDejYiwD7UM6uAZkvquB5xaXt3R6U LHhFfleyPRAb1nGkjbn4s8h3RbJr2L3LToguhTKC4aCCtdOFp8eFDpNjJINvKSFhhOAM HcZE3M3Qpb314M0BZnQYuTEUncpjWA75qjfk+CdWpSSDmH4wU5ba9Bej4vLwgsT3QbmV nhMw== X-Forwarded-Encrypted: i=1; AHgh+RqEB+Ykttz3QTAhFRcVEGJQBu454CeNlE+ls1Huhv/XOwrc8/2UEd30LxuHW0T/ZxuRCGp99EEH3Og=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzfw1u38NhetE1znUqNwgG9ONhKlG8R057YnVPmh4Qm3DLZLQEk LahmILfzWDVQDqrLaCWzTI7PD3u4RpE8YRak0dasB+aCdhnIZ9nfQv0/7sJb18OpnA== X-Gm-Gg: AR+sD12oJYUH2A7sgtvG8lfSuTh1i7JYgbgD/OLGGiPGu1pwRqiytlouu8ikWTwVPP3 yY0uamUvy/4I9NYXXE141iOXgJxPzyQ85ObFOP+E49xqFcuRqxJqUC1T3MoKdmQ9xjpwzWSbh8Z mkGPlap9Ku/nHk6kr+NEHJAXfek9od/zJDvuD8AiY/WmIrsVBCriHlyTKaUcMy7Ts37HkSVY+xA ziow4IBDYztJB78lnJdhhrvwmvMCCghM1hpupm9r2s0Ntj9gASvC25F+RFF4AsNiFopXT9ZlgtV 67JUtNsQLB8KvhTAHVkkrMWDZFtwTrFuigYpVi2llCXaN5Jw57cqObVD+Pwyc+OFIWjuxe9PVxk 6msopjkE+oXOzDTlxOPDfJxfeBchyskaXTCUgBm1DMCb/xMTInPJvRjzWePzI2RcnRU7WjSiy0A GQkQBE1LWOKz3lJ7gXyziuxDsXpJwhMZ6h2xP96+qGzezOA4IH2ZslXLDpjj16bg/p0Sbo7YAgU FvnB8VClRH+73aa0wVhAPxxyflNQO1xRdAtrADlpx5AZbHvOqoP X-Received: by 2002:a05:6000:18a6:b0:47f:7fe0:a287 with SMTP id ffacd0b85a97d-47fd725b307mr23032494f8f.2.1785753667898; Mon, 03 Aug 2026 03:41:07 -0700 (PDT) Message-ID: <51e537a4-f568-458d-9625-ada7fbebd842@suse.com> Date: Mon, 3 Aug 2026 12:41:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/17] xen/riscv: introduce device-agnostic MMIO emulation dispatch To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <704870c1-18ec-4c7b-873c-e07e77ae0d39@suse.com> <2ef6b295-862b-40be-a7d2-c94a6378126b@suse.com> <636a6183-8c66-41b2-b820-6a02098fd33d@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <636a6183-8c66-41b2-b820-6a02098fd33d@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785753668-D6D4087B-0EB09F8A/0/0 X-purgate-type: clean X-purgate-size: 3188 On 31.07.2026 17:24, Oleksii Kurochko wrote: > On 7/30/26 6:09 PM, Jan Beulich wrote: >> On 30.07.2026 18:03, Oleksii Kurochko wrote: >>> On 7/28/26 2:23 PM, Jan Beulich wrote: >>>> On 20.07.2026 18:02, Oleksii Kurochko wrote: >>>>> --- /dev/null >>>>> +++ b/xen/arch/riscv/mmio.c >>>>> @@ -0,0 +1,145 @@ >>>>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>>>> +/* >>>>> + * Copyright (C) Vates >>>>> + */ >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> + >>>>> +#include >>>>> +#include >>>>> + >>>>> +static enum io_state handle_read(const struct mmio_handler *handler, >>>>> + struct vcpu *v, >>>>> + mmio_info_t *info) >>>>> +{ >>>>> + register_t r = 0; >>>>> + enum io_state rc; >>>>> + >>>>> + rc = handler->ops->read(v, info, &r); >>>>> + if ( rc == IO_HANDLED ) >>>>> + info->data = r; >>>> >>>> Extending my earlier comment: Why could ->read() not put the value directly >>>> into info->data? And why ... >>>> >>>>> +static enum io_state handle_write(const struct mmio_handler *handler, >>>>> + struct vcpu *v, >>>>> + mmio_info_t *info) >>>>> +{ >>>>> + return handler->ops->write(v, info, info->data); >>>> >>>> ... can't write take the value directly from info->data? >>> >>> I totally agree, it can. Do you think it is better to keep ->data and >>> drop an argument 'r' or vice versa? >> >> How can I know? You know future plans you have. >> >>>>> +} >>>>> + >>>>> +/* Assumes mmio regions are not overlapping. */ >>>> >>>> Are you guaranteeing this anywhere? >>> >>> There is no such guarantee. register_mmio_handler() simply adds the >>> handler to the handlers array without performing any checks. I can add >>> such a check. The only question is whether it should be enabled only in >>> debug builds or in all builds. >> >> Depends on what other badness can happen when this is violated. My gut >> feeling is that checking in debug builds may be enough. > > Overlapping regions would be a Xen bug rather than something a guest can > trigger — register_mmio_handler() is only called from Xen's own emulated > device code, so the layout isn't under guest control. > > The badness is worse than just mis-emulating one device though: > cmp_mmio_handler() is used both by bsearch() and by sort(). With > overlapping regions it's no longer a consistent ordering, so sort() may > produce an arbitrary order and lookups can then fail (or match the wrong > handler) even for regions which don't overlap themselves. That would > show up as a spurious fault injected into the guest, which is quite hard > to debug. Didn't you say you'd get rid of the use of sort()? > So I agree a check is worthwhile; I'll add one under CONFIG_DEBUG in > register_mmio_handler(). Some assertion then hopefully, rather than an open-coded use of CONFIG_DEBUG. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 11:13:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 11:13:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381383.1624978 (Exim 4.92) (envelope-from ) id 1wqqbP-0002XC-NQ; Mon, 03 Aug 2026 11:13:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381383.1624978; Mon, 03 Aug 2026 11:13:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqqbP-0002X4-KF; Mon, 03 Aug 2026 11:13:03 +0000 Received: by outflank-mailman (input) for mailman id 1381383; Mon, 03 Aug 2026 11:13:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqqbO-0002Wy-32 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 11:13:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqqbM-00EqOR-UG for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 13:13:00 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7077b7-2eae-0a2a0a5409dd-0a2a4501d6f4-0 for ; Mon, 03 Aug 2026 13:12:55 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7077b7-5984-0a2a45010019-d155802ee440-3 for ; Mon, 03 Aug 2026 13:12:55 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso12807485e9.0 for ; Mon, 03 Aug 2026 04:12:55 -0700 (PDT) Received: from [192.168.1.109] ([78.173.117.153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808199a5csm317148575e9.4.2026.08.03.04.12.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 04:12:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785755575; x=1786360375; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=n15kLGrJ+FWpwmzVHEDI31BEOzMm4iFVML/1saYo8ro=; b=r/j3k3rL3Ndi8EtK411WXb2szOgSQ/bhwXJPWLxZz+CsXK8XvyRW6ETJ7eMFeo/F9r 5S8EV2i2HpWy8vm4Ne9bQKiI6AR6fPUPaO67PKh0HP4S45EiRiKK78qlNKXIK11/t5gG VGOGqpZWZeeO+N3yeEuZwc1L6ZuS7XWBH4jC9JqZ6f3BOGP8I3/4EnL2CPMJY21iB5Ik h+4gz7dtbgpzGw+r2dFF3qp/TMkxo+TcdCGbOnMiShnj0F60kS4yVjwB3GuDzZEu7ZCI i/1Y1h2taYvPXjWvRA0jvRBs4Sp2kzywBKNMIUXVKA+V5NXqgjMqlHvHYkAD7h6rerwK iyfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785755575; x=1786360375; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n15kLGrJ+FWpwmzVHEDI31BEOzMm4iFVML/1saYo8ro=; b=fCBUDRDWKPoKrS21NUdkCIxtuvz1QvwwPjrAkNmpckCR/p+ljgMcpTNLcgFqSTQmVA QE11iEzMDF+4VS4slEU6j2vedrpFb7ZpT9EJAnAolFzJjMOJPocRQ6d0vb2NzGpz/Fy1 Bb2Mv9gNK+K5Knrx4jTBvnKmXGZKy7iD++1yZpKGnqFnZBU5+oQXZ29FhHSA1+xL4Yxt SOsUiRbEO3YYdSSlQIKehD/aTjn/WjRaatvDAMKqWti0y6mtSDTefdXf5CLgMPXKCuqd 28hXqR2lnSUJGdAOCoP+6dfcSZIfcFgMfO5qM1On0zvWEVLKFu0DOr5DLEZlOIXUPLDQ vRQw== X-Forwarded-Encrypted: i=1; AHgh+RrwqVaptoUzrKAy05aFLeTUoYjNQmZd61C7WPPt7VerfxjtwCc9NXYus35OEWjSyHrnuQetzFriD6E=@lists.xenproject.org X-Gm-Message-State: AOJu0YyGoMpQIcH2GhoaDmVKCblaK83IalHZi+1EOYHZr4Bz1rJq+qAd qbUsvTa/N4Djd6hyOE7cZGRhM4ehTBekhJfwSCbUt6iJSewKQ8XPvPIo X-Gm-Gg: AR+sD12u0ClY4xO7CnKSZU7x6gob4laFzZIn4Z2Cnq8SHmAIwYYHCzRejtKQMz0tczu JFMuIGbAOi18MwAdPoo/VP093kWTa6EgYJ2s+UXMQ7YcMIlUPyfT4I65cIeOcHbD6UeGzg/3pCN fNaroslCTit4RvToz47xyXGWvDM4Jd0TqJHVb965bk6Tjg5QOs5jdFUwo+9hykzErJHcoDNSdfi m37Gtz04IT/50irEfG+ucu7hwfD85EUD1VmaZGcju8mZnubYXInvKp97ldKeXlHNho0VV6l0qei e9KhF1lM8GrT9T4BkZhaCwnr0BI2iGrGKN//kUvOsTEUN56ElKf+iwdHpKZT4FUXIqWWDDQU7pm /5TMq+7R8h7uNF/dZeZPYGbJPK7miLpLAB5Rlr2BVM65IiSKbmDyIi96Rgwz1V+yG7bV24LbAR3 oYpmHsTyFJAPariC+Z3/4RsQBMvatYSa4pI6d8YObe2fAys6AlX3AUW0QLsusc5m1NemkSgi/0Z q9sFUw= X-Received: by 2002:a05:600c:628c:b0:496:c0f6:78d6 with SMTP id 5b1f17b1804b1-4980c64b5a7mr227722965e9.2.1785755574994; Mon, 03 Aug 2026 04:12:54 -0700 (PDT) Message-ID: <6a6a04dc-0d8c-4b7a-a190-09113b3b68cd@gmail.com> Date: Mon, 3 Aug 2026 14:12:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] xen/sched: split scheduler vtable from scheduler To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com References: <20260803050614.5222-1-frn1furkan10@gmail.com> Content-Language: en-US From: =?UTF-8?B?RnVya2FuIMOHYWzEscWfa2Fu?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1785755575-BC75B757-76A94DF6/0/0 X-purgate-type: clean X-purgate-size: 4743 Hi Jürgen, On 8/3/26 13:34, Jürgen Groß wrote: > On 03.08.26 07:06, Furkan Caliskan wrote: >> Each struct scheduler currently doubles as both a scheduler >> backend's static vtable (name, opt_name, sched_id and every >> function pointer) and the per-cpupool runtime object that >> scheduler_alloc() allocates. Because these are the same type, >> scheduler_alloc() memcpy()s the entire vtable into a fresh heap >> allocation for every cpupool it creates. With N cpupools running >> the same scheduler, this duplicates N copies of identical function >> pointers and identifying fields that never differ between >> instances - the only fields that are genuinely per-cpupool are >> sched_data and cpupool. >> >> This series splits the vtable out into its own type, struct >> sched_ops, so it can be shared by every cpupool using a given >> scheduler instead of copied per cpupool. struct scheduler is left >> holding only what is actually per-instance: a pointer to the >> shared sched_ops, plus sched_data and cpupool. >> >> The series is structured as introduce/migrate/remove, so that >> every commit builds and boots on its own: >> >>    - The first patch adds struct sched_ops, REGISTER_SCHED_OPS(), >>      and a sched_ops_array[] alongside the existing schedulers[], >>      extending every lookup path (scheduler_alloc(), >>      sched_get_by_name(), scheduler_init()) to search both arrays. >>      This is purely additive - no scheduler uses it yet. >> >>    - The next five patches each migrate one scheduler backend >>      (credit, credit2, rtds, arinc653, null) from struct scheduler >>      to struct sched_ops. Each is small, mechanical, and >>      independently bisectable, with no behavioral difference, since >>      scheduler_alloc() builds an identical runtime struct scheduler >>      regardless of which array a match is found in. >> >>    - The final patch removes the old schedulers[] and >>      REGISTER_SCHEDULER() path now that nothing uses it, shrinks >>      struct scheduler down to { ops, sched_data, cpupool }, and >>      updates every accessor in private.h accordingly. >> >> Furkan Caliskan (7): >>    xen/sched: introduce struct sched_ops as a shared scheduler vtable >>    xen/sched: credit: migrate to new sched_ops >>    xen/sched: credit2: migrate to new sched_ops >>    xen/sched: rtds: migrate to new sched_ops >>    xen/sched: arinc653: migrate to new sched_ops >>    xen/sched: null: migrate to new sched_ops >>    xen/sched: remove old scheduler registration, shrink struct scheduler >> >>   xen/arch/arm/xen.lds.S      |   2 +- >>   xen/arch/ppc/xen.lds.S      |   2 +- >>   xen/arch/riscv/xen.lds.S    |   2 +- >>   xen/arch/x86/xen.lds.S      |   2 +- >>   xen/common/sched/arinc653.c |  11 +--- >>   xen/common/sched/core.c     |  80 ++++++++++++++++------------- >>   xen/common/sched/cpupool.c  |   6 +-- >>   xen/common/sched/credit.c   |   5 +- >>   xen/common/sched/credit2.c  |   5 +- >>   xen/common/sched/null.c     |   5 +- >>   xen/common/sched/private.h  | 100 +++++++++++++++++++----------------- >>   xen/common/sched/rt.c       |   5 +- >>   xen/include/xen/xen.lds.h   |   8 +-- >>   13 files changed, 116 insertions(+), 117 deletions(-) >> > > You have a series here which is adding 116 lines and removing 117. > > Patch 7 alone is removing 248 lines while adding 67 lines. > > So in the end there is a single patch in this series which has more code > churn than the complete series when added in one go. > > IOW: making this just a single patch would be easier to review than the > last patch alone, let alone all the temporary modifications which would > be gone when merging all patches into one. And with that you could even > drop some of the renaming you did (e.g. in the linker file), making the > diff even smaller. > > I agree with the overall goal, but I'm sparing my time doing a thorough > review of the series in this shape. > > > Juergen My first instinct was actually to just send this as one patch. I split it up because I wanted each scheduler's conversion to be its own small, bisectable commit, but you're right that it's not worth it here. I will squash it into a single patch and resend. But I would still like to rename SCHEDULER_ARRAY to SCHED_OPS_ARRAY in the per-arch linker files and other related variable names in other files, since they now hold sched_ops entries rather than struct scheduler ones, and I think the name should reflect that. Thanks for the feedback, Furkan Caliskan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 11:19:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 11:19:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381391.1624987 (Exim 4.92) (envelope-from ) id 1wqqhw-0003qh-C2; Mon, 03 Aug 2026 11:19:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381391.1624987; Mon, 03 Aug 2026 11:19:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqqhw-0003qa-92; Mon, 03 Aug 2026 11:19:48 +0000 Received: by outflank-mailman (input) for mailman id 1381391; Mon, 03 Aug 2026 11:19:46 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqqhu-0003qB-Ba for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 11:19:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqqht-00EYud-62 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 13:19:45 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a707948-2eae-0a2a0a5409dd-0a2a45049896-34 for ; Mon, 03 Aug 2026 13:19:45 +0200 Received: from [209.85.218.46] (helo=mail-ej1-f46.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a707950-b57f-0a2a45040019-d155da2eb020-3 for ; Mon, 03 Aug 2026 13:19:44 +0200 Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-c16794450aeso457755166b.2 for ; Mon, 03 Aug 2026 04:19:44 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44e9ff0sm486592866b.42.2026.08.03.04.19.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 04:19:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785755984; x=1786360784; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Y6ZiLzDwyrefHpHNId0SfIDP7KVAik7WooDx4DLjY7M=; b=TcXCcNKeKOr4GXR4qbdD+NAvgMD4FP+ZLkB6uKPfqHQgFf7rakqprMST7qhcmL2ksK nwF8YOqAGNyrdCRV1dd22meAJoJE26qAsgkaJ8RHluB8uZNcr3tpgiXvumLnynqhpmAs /GY16HawYCPZ1IVTqE71MA6yRGAErzIpEJ5TBGJO8qY8yPOgQP8Wud2Zq9S6qw/bnIHU eaQ34OoG9LBkcovu4WhatA2L5W2PmFd4tmqeh+c9MtfyRZ7Bk0CEOvCwCRBivlC3G9H7 Pp2+Gn9ci9yr+k/14Jk3s7YkozBVUO0k/1ra6UH8um6AejBLkvGSOUdhX5qygA9HJ/AA CAvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785755984; x=1786360784; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Y6ZiLzDwyrefHpHNId0SfIDP7KVAik7WooDx4DLjY7M=; b=p0s34uawrylsQ+kYk0Pf6TqfTJZ3t+ydoFXVBlSxiQ/Yy1xG90drYxmxhPaSuHT4nI GhOcb2yLyB9hECKXnoKvbyfr03mgtlp19PJu5EtM12Nq9eNwz6jb7hGDDqUJMeQ7qWY+ BX6YGU0/Bwjzxvxb8Tr80ckM6cEWUFBLNNtgdCVMMyvCg9qZWhGloKXScDD+O6mDfi4T Qeo2YRSNmevtnrcuL+8wzsZP7Bcd7ubNNLyZKXCwTZPOcDUy6J5mo7EzJuchVVeWEfi7 Yu17JP+/51DAM4AbT42faG5HCxJuowZtq4n3dNgknBD3NgO80kvKnJ/cqaIR5dKtSrpF LqPg== X-Forwarded-Encrypted: i=1; AHgh+RqoxNoetnh7LxLDeIRFPOhfTelrWfLbhOGxguLWRXmmPU4yMQzzaTe3NsBpdzfhHrPSdquEg8Bl3II=@lists.xenproject.org X-Gm-Message-State: AOJu0YwyF5xZ9uJ2G8JZd+fyZY4mZerMY7Ia3SFdn7qgMRcniWQJAQdR qFp7MvN6wpB3mXQTtPDYYLCsiHOnUXm1Be4NViJS0/4XzUHpjPUjvQ44demHS+XKOoo= X-Gm-Gg: AR+sD131fi2nSO4QYMUUHzBa3Lfz5zjaSv3w/ULyilfdVBKdoElBEfpWog8GXZHann6 FdccfbF7k+kSZpbK3+cv57KWkQz2UEmp/UvxTHqGa5aVKV+8NT8/FZF0TbBYKXI1Xg+SEfr5ZW0 XWHlWitY1JKEqUiw0SvtBBW2FLCcjUoHwv3Cwm3fvuamLWHrHFPPx1NgFht+Qn3t+rZ48CcEaBS JiJySkiB9vQ9uuokR/I3p0W5XgwM4pZjVshvWHIzTXZ0Qa4Z1auQiBSPRlzCcdUQEo8tgZD5Cg4 GszfF+vVH/I6fQDB8zBT5HDavU8KWxA+Nfn8r1pnT7iu61RTlmHY/xYyupwW/ib9chO+1tndg1w CBM7JG0jjVD8i1Q4uTQRL+4Wx4lCwQZ2491eTGj2udBx6v49qic1o8Tb1ek6/LrGKBjpyJt2VpF sQMrSOcbhW2jqcGPorlYqL39kGLfQY9Ey85gkwsn8CEMB/rVFXzv66WUZuIRGHieGmiKC2BDZQ5 N1OgvJ+1JIKO1pl3gWk2UGIzlP0vdBCXSncDyEmW0XwtYywMMpZsk2AIqi9qdl6HsuOrSqYdxPC saLDtezhLRbz09g= X-Received: by 2002:a17:906:99c2:b0:c20:1db7:f486 with SMTP id a640c23a62f3a-c201db7f6d5mr51425966b.4.1785755984414; Mon, 03 Aug 2026 04:19:44 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 13:19:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] xen/sched: split scheduler vtable from scheduler To: =?UTF-8?B?RnVya2FuIMOHYWzEscWfa2Fu?= , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com References: <20260803050614.5222-1-frn1furkan10@gmail.com> <6a6a04dc-0d8c-4b7a-a190-09113b3b68cd@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <6a6a04dc-0d8c-4b7a-a190-09113b3b68cd@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Jb0N41yXYZfVlxU4E0wzd6Gy" X-purgate-ID: tlsNG-ebf023/1785755985-C22D4B50-A11A547A/0/0 X-purgate-type: clean X-purgate-size: 14780 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Jb0N41yXYZfVlxU4E0wzd6Gy Content-Type: multipart/mixed; boundary="------------e0KE3W7ckWjUDvsdlmgZxEAX"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: =?UTF-8?B?RnVya2FuIMOHYWzEscWfa2Fu?= , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, oleksii.kurochko@gmail.com Message-ID: Subject: Re: [PATCH 0/7] xen/sched: split scheduler vtable from scheduler References: <20260803050614.5222-1-frn1furkan10@gmail.com> <6a6a04dc-0d8c-4b7a-a190-09113b3b68cd@gmail.com> In-Reply-To: <6a6a04dc-0d8c-4b7a-a190-09113b3b68cd@gmail.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------e0KE3W7ckWjUDvsdlmgZxEAX Content-Type: multipart/mixed; boundary="------------rgestBAm8DxHNbbDoJMPTflu" --------------rgestBAm8DxHNbbDoJMPTflu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjYgMTM6MTIsIEZ1cmthbiDDh2FsxLHFn2thbiB3cm90ZToNCj4gSGkgSsO8 cmdlbiwNCj4gDQo+IE9uIDgvMy8yNiAxMzozNCwgSsO8cmdlbiBHcm/DnyB3cm90ZToNCj4+ IE9uIDAzLjA4LjI2IDA3OjA2LCBGdXJrYW4gQ2FsaXNrYW4gd3JvdGU6DQo+Pj4gRWFjaCBz dHJ1Y3Qgc2NoZWR1bGVyIGN1cnJlbnRseSBkb3VibGVzIGFzIGJvdGggYSBzY2hlZHVsZXIN Cj4+PiBiYWNrZW5kJ3Mgc3RhdGljIHZ0YWJsZSAobmFtZSwgb3B0X25hbWUsIHNjaGVkX2lk IGFuZCBldmVyeQ0KPj4+IGZ1bmN0aW9uIHBvaW50ZXIpIGFuZCB0aGUgcGVyLWNwdXBvb2wg cnVudGltZSBvYmplY3QgdGhhdA0KPj4+IHNjaGVkdWxlcl9hbGxvYygpIGFsbG9jYXRlcy4g QmVjYXVzZSB0aGVzZSBhcmUgdGhlIHNhbWUgdHlwZSwNCj4+PiBzY2hlZHVsZXJfYWxsb2Mo KSBtZW1jcHkoKXMgdGhlIGVudGlyZSB2dGFibGUgaW50byBhIGZyZXNoIGhlYXANCj4+PiBh bGxvY2F0aW9uIGZvciBldmVyeSBjcHVwb29sIGl0IGNyZWF0ZXMuIFdpdGggTiBjcHVwb29s cyBydW5uaW5nDQo+Pj4gdGhlIHNhbWUgc2NoZWR1bGVyLCB0aGlzIGR1cGxpY2F0ZXMgTiBj b3BpZXMgb2YgaWRlbnRpY2FsIGZ1bmN0aW9uDQo+Pj4gcG9pbnRlcnMgYW5kIGlkZW50aWZ5 aW5nIGZpZWxkcyB0aGF0IG5ldmVyIGRpZmZlciBiZXR3ZWVuDQo+Pj4gaW5zdGFuY2VzIC0g dGhlIG9ubHkgZmllbGRzIHRoYXQgYXJlIGdlbnVpbmVseSBwZXItY3B1cG9vbCBhcmUNCj4+ PiBzY2hlZF9kYXRhIGFuZCBjcHVwb29sLg0KPj4+DQo+Pj4gVGhpcyBzZXJpZXMgc3BsaXRz IHRoZSB2dGFibGUgb3V0IGludG8gaXRzIG93biB0eXBlLCBzdHJ1Y3QNCj4+PiBzY2hlZF9v cHMsIHNvIGl0IGNhbiBiZSBzaGFyZWQgYnkgZXZlcnkgY3B1cG9vbCB1c2luZyBhIGdpdmVu DQo+Pj4gc2NoZWR1bGVyIGluc3RlYWQgb2YgY29waWVkIHBlciBjcHVwb29sLiBzdHJ1Y3Qg c2NoZWR1bGVyIGlzIGxlZnQNCj4+PiBob2xkaW5nIG9ubHkgd2hhdCBpcyBhY3R1YWxseSBw ZXItaW5zdGFuY2U6IGEgcG9pbnRlciB0byB0aGUNCj4+PiBzaGFyZWQgc2NoZWRfb3BzLCBw bHVzIHNjaGVkX2RhdGEgYW5kIGNwdXBvb2wuDQo+Pj4NCj4+PiBUaGUgc2VyaWVzIGlzIHN0 cnVjdHVyZWQgYXMgaW50cm9kdWNlL21pZ3JhdGUvcmVtb3ZlLCBzbyB0aGF0DQo+Pj4gZXZl cnkgY29tbWl0IGJ1aWxkcyBhbmQgYm9vdHMgb24gaXRzIG93bjoNCj4+Pg0KPj4+ICDCoMKg IC0gVGhlIGZpcnN0IHBhdGNoIGFkZHMgc3RydWN0IHNjaGVkX29wcywgUkVHSVNURVJfU0NI RURfT1BTKCksDQo+Pj4gIMKgwqDCoMKgIGFuZCBhIHNjaGVkX29wc19hcnJheVtdIGFsb25n c2lkZSB0aGUgZXhpc3Rpbmcgc2NoZWR1bGVyc1tdLA0KPj4+ICDCoMKgwqDCoCBleHRlbmRp bmcgZXZlcnkgbG9va3VwIHBhdGggKHNjaGVkdWxlcl9hbGxvYygpLA0KPj4+ICDCoMKgwqDC oCBzY2hlZF9nZXRfYnlfbmFtZSgpLCBzY2hlZHVsZXJfaW5pdCgpKSB0byBzZWFyY2ggYm90 aCBhcnJheXMuDQo+Pj4gIMKgwqDCoMKgIFRoaXMgaXMgcHVyZWx5IGFkZGl0aXZlIC0gbm8g c2NoZWR1bGVyIHVzZXMgaXQgeWV0Lg0KPj4+DQo+Pj4gIMKgwqAgLSBUaGUgbmV4dCBmaXZl IHBhdGNoZXMgZWFjaCBtaWdyYXRlIG9uZSBzY2hlZHVsZXIgYmFja2VuZA0KPj4+ICDCoMKg wqDCoCAoY3JlZGl0LCBjcmVkaXQyLCBydGRzLCBhcmluYzY1MywgbnVsbCkgZnJvbSBzdHJ1 Y3Qgc2NoZWR1bGVyDQo+Pj4gIMKgwqDCoMKgIHRvIHN0cnVjdCBzY2hlZF9vcHMuIEVhY2gg aXMgc21hbGwsIG1lY2hhbmljYWwsIGFuZA0KPj4+ICDCoMKgwqDCoCBpbmRlcGVuZGVudGx5 IGJpc2VjdGFibGUsIHdpdGggbm8gYmVoYXZpb3JhbCBkaWZmZXJlbmNlLCBzaW5jZQ0KPj4+ ICDCoMKgwqDCoCBzY2hlZHVsZXJfYWxsb2MoKSBidWlsZHMgYW4gaWRlbnRpY2FsIHJ1bnRp bWUgc3RydWN0IHNjaGVkdWxlcg0KPj4+ICDCoMKgwqDCoCByZWdhcmRsZXNzIG9mIHdoaWNo IGFycmF5IGEgbWF0Y2ggaXMgZm91bmQgaW4uDQo+Pj4NCj4+PiAgwqDCoCAtIFRoZSBmaW5h bCBwYXRjaCByZW1vdmVzIHRoZSBvbGQgc2NoZWR1bGVyc1tdIGFuZA0KPj4+ICDCoMKgwqDC oCBSRUdJU1RFUl9TQ0hFRFVMRVIoKSBwYXRoIG5vdyB0aGF0IG5vdGhpbmcgdXNlcyBpdCwg c2hyaW5rcw0KPj4+ICDCoMKgwqDCoCBzdHJ1Y3Qgc2NoZWR1bGVyIGRvd24gdG8geyBvcHMs IHNjaGVkX2RhdGEsIGNwdXBvb2wgfSwgYW5kDQo+Pj4gIMKgwqDCoMKgIHVwZGF0ZXMgZXZl cnkgYWNjZXNzb3IgaW4gcHJpdmF0ZS5oIGFjY29yZGluZ2x5Lg0KPj4+DQo+Pj4gRnVya2Fu IENhbGlza2FuICg3KToNCj4+PiAgwqDCoCB4ZW4vc2NoZWQ6IGludHJvZHVjZSBzdHJ1Y3Qg c2NoZWRfb3BzIGFzIGEgc2hhcmVkIHNjaGVkdWxlciB2dGFibGUNCj4+PiAgwqDCoCB4ZW4v c2NoZWQ6IGNyZWRpdDogbWlncmF0ZSB0byBuZXcgc2NoZWRfb3BzDQo+Pj4gIMKgwqAgeGVu L3NjaGVkOiBjcmVkaXQyOiBtaWdyYXRlIHRvIG5ldyBzY2hlZF9vcHMNCj4+PiAgwqDCoCB4 ZW4vc2NoZWQ6IHJ0ZHM6IG1pZ3JhdGUgdG8gbmV3IHNjaGVkX29wcw0KPj4+ICDCoMKgIHhl bi9zY2hlZDogYXJpbmM2NTM6IG1pZ3JhdGUgdG8gbmV3IHNjaGVkX29wcw0KPj4+ICDCoMKg IHhlbi9zY2hlZDogbnVsbDogbWlncmF0ZSB0byBuZXcgc2NoZWRfb3BzDQo+Pj4gIMKgwqAg eGVuL3NjaGVkOiByZW1vdmUgb2xkIHNjaGVkdWxlciByZWdpc3RyYXRpb24sIHNocmluayBz dHJ1Y3Qgc2NoZWR1bGVyDQo+Pj4NCj4+PiAgwqAgeGVuL2FyY2gvYXJtL3hlbi5sZHMuU8Kg wqDCoMKgwqAgfMKgwqAgMiArLQ0KPj4+ICDCoCB4ZW4vYXJjaC9wcGMveGVuLmxkcy5TwqDC oMKgwqDCoCB8wqDCoCAyICstDQo+Pj4gIMKgIHhlbi9hcmNoL3Jpc2N2L3hlbi5sZHMuU8Kg wqDCoCB8wqDCoCAyICstDQo+Pj4gIMKgIHhlbi9hcmNoL3g4Ni94ZW4ubGRzLlPCoMKgwqDC oMKgIHzCoMKgIDIgKy0NCj4+PiAgwqAgeGVuL2NvbW1vbi9zY2hlZC9hcmluYzY1My5jIHzC oCAxMSArLS0tDQo+Pj4gIMKgIHhlbi9jb21tb24vc2NoZWQvY29yZS5jwqDCoMKgwqAgfMKg IDgwICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tDQo+Pj4gIMKgIHhlbi9jb21tb24v c2NoZWQvY3B1cG9vbC5jwqAgfMKgwqAgNiArLS0NCj4+PiAgwqAgeGVuL2NvbW1vbi9zY2hl ZC9jcmVkaXQuY8KgwqAgfMKgwqAgNSArLQ0KPj4+ICDCoCB4ZW4vY29tbW9uL3NjaGVkL2Ny ZWRpdDIuY8KgIHzCoMKgIDUgKy0NCj4+PiAgwqAgeGVuL2NvbW1vbi9zY2hlZC9udWxsLmPC oMKgwqDCoCB8wqDCoCA1ICstDQo+Pj4gIMKgIHhlbi9jb21tb24vc2NoZWQvcHJpdmF0ZS5o wqAgfCAxMDAgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tDQo+Pj4gIMKg IHhlbi9jb21tb24vc2NoZWQvcnQuY8KgwqDCoMKgwqDCoCB8wqDCoCA1ICstDQo+Pj4gIMKg IHhlbi9pbmNsdWRlL3hlbi94ZW4ubGRzLmjCoMKgIHzCoMKgIDggKy0tDQo+Pj4gIMKgIDEz IGZpbGVzIGNoYW5nZWQsIDExNiBpbnNlcnRpb25zKCspLCAxMTcgZGVsZXRpb25zKC0pDQo+ Pj4NCj4+DQo+PiBZb3UgaGF2ZSBhIHNlcmllcyBoZXJlIHdoaWNoIGlzIGFkZGluZyAxMTYg bGluZXMgYW5kIHJlbW92aW5nIDExNy4NCj4+DQo+PiBQYXRjaCA3IGFsb25lIGlzIHJlbW92 aW5nIDI0OCBsaW5lcyB3aGlsZSBhZGRpbmcgNjcgbGluZXMuDQo+Pg0KPj4gU28gaW4gdGhl IGVuZCB0aGVyZSBpcyBhIHNpbmdsZSBwYXRjaCBpbiB0aGlzIHNlcmllcyB3aGljaCBoYXMg bW9yZSBjb2RlDQo+PiBjaHVybiB0aGFuIHRoZSBjb21wbGV0ZSBzZXJpZXMgd2hlbiBhZGRl ZCBpbiBvbmUgZ28uDQo+Pg0KPj4gSU9XOiBtYWtpbmcgdGhpcyBqdXN0IGEgc2luZ2xlIHBh dGNoIHdvdWxkIGJlIGVhc2llciB0byByZXZpZXcgdGhhbiB0aGUNCj4+IGxhc3QgcGF0Y2gg YWxvbmUsIGxldCBhbG9uZSBhbGwgdGhlIHRlbXBvcmFyeSBtb2RpZmljYXRpb25zIHdoaWNo IHdvdWxkDQo+PiBiZSBnb25lIHdoZW4gbWVyZ2luZyBhbGwgcGF0Y2hlcyBpbnRvIG9uZS4g QW5kIHdpdGggdGhhdCB5b3UgY291bGQgZXZlbg0KPj4gZHJvcCBzb21lIG9mIHRoZSByZW5h bWluZyB5b3UgZGlkIChlLmcuIGluIHRoZSBsaW5rZXIgZmlsZSksIG1ha2luZyB0aGUNCj4+ IGRpZmYgZXZlbiBzbWFsbGVyLg0KPj4NCj4+IEkgYWdyZWUgd2l0aCB0aGUgb3ZlcmFsbCBn b2FsLCBidXQgSSdtIHNwYXJpbmcgbXkgdGltZSBkb2luZyBhIHRob3JvdWdoDQo+PiByZXZp ZXcgb2YgdGhlIHNlcmllcyBpbiB0aGlzIHNoYXBlLg0KPj4NCj4+DQo+PiBKdWVyZ2VuDQo+ IA0KPiBNeSBmaXJzdCBpbnN0aW5jdCB3YXMgYWN0dWFsbHkgdG8ganVzdCBzZW5kIHRoaXMg YXMgb25lIHBhdGNoLiBJIHNwbGl0DQo+IGl0IHVwIGJlY2F1c2UgSSB3YW50ZWQgZWFjaCBz Y2hlZHVsZXIncyBjb252ZXJzaW9uIHRvIGJlIGl0cyBvd24gc21hbGwsDQo+IGJpc2VjdGFi bGUgY29tbWl0LCBidXQgeW91J3JlIHJpZ2h0IHRoYXQgaXQncyBub3Qgd29ydGggaXQgaGVy ZS4NCj4gDQo+IEkgd2lsbCBzcXVhc2ggaXQgaW50byBhIHNpbmdsZSBwYXRjaCBhbmQgcmVz ZW5kLiBCdXQgSSB3b3VsZCBzdGlsbCBsaWtlDQo+IHRvIHJlbmFtZSBTQ0hFRFVMRVJfQVJS QVkgdG8gU0NIRURfT1BTX0FSUkFZIGluIHRoZSBwZXItYXJjaCBsaW5rZXIgZmlsZXMNCj4g YW5kIG90aGVyIHJlbGF0ZWQgdmFyaWFibGUgbmFtZXMgaW4gb3RoZXIgZmlsZXMsIHNpbmNl IHRoZXkgbm93IGhvbGQNCj4gc2NoZWRfb3BzIGVudHJpZXMgcmF0aGVyIHRoYW4gc3RydWN0 IHNjaGVkdWxlciBvbmVzLCBhbmQgSSB0aGluayB0aGUgbmFtZQ0KPiBzaG91bGQgcmVmbGVj dCB0aGF0Lg0KDQpOb3cgVEhJUyBjb3VsZCBiZSBkb25lIGluIGEgc2VwYXJhdGUgcGF0Y2gu DQoNCg0KSnVlcmdlbg0K --------------rgestBAm8DxHNbbDoJMPTflu Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------rgestBAm8DxHNbbDoJMPTflu-- --------------e0KE3W7ckWjUDvsdlmgZxEAX-- --------------Jb0N41yXYZfVlxU4E0wzd6Gy Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpweU8FAwAAAAAACgkQsN6d1ii/Ey9v gAf/ebSttKyOOXGrxS8t9W57Mu9fpoIa9l8Fmo6ofdzBSz/oLEvB+xg/Fp0XbM0z/JrBaugLGBHu dvHnZktv5eUt7ERxaIf9UELJz3PhnXvbspGTZs0xOmmTLmMBWmUB5ckIliuWvNId+j4zSx/NlJHt JHAQrreqjKm/3vnReccxQDnDz4w8b+VnE8ecOu7+tZIMNJLzFZhZ6uBWxpbEoisQ8rU/eOi9ScKx 5Tn990svnq6o5NZLzFpamQcrekfH23JYTtmm2IsmCeYnSA19jTOW8n7DP6dZH78Wri4ApGIVjRy6 qrhf39cFiZ1ijNANeK5W7VFifhev5ClbgTjlxODxwA== =z37H -----END PGP SIGNATURE----- --------------Jb0N41yXYZfVlxU4E0wzd6Gy-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:17:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 12:17:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381420.1625000 (Exim 4.92) (envelope-from ) id 1wqrc5-0007AZ-L2; Mon, 03 Aug 2026 12:17:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381420.1625000; Mon, 03 Aug 2026 12:17:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrc5-00079X-GY; Mon, 03 Aug 2026 12:17:49 +0000 Received: by outflank-mailman (input) for mailman id 1381420; Mon, 03 Aug 2026 12:17:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrc4-00077T-4Z for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:17:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqrc3-007wIE-3l for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:17:47 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7086e5-e002-0a2a0a5209dd-0a2a45059236-20 for ; Mon, 03 Aug 2026 14:17:47 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7086ea-4cb1-0a2a45050019-d155802ca8e8-3 for ; Mon, 03 Aug 2026 14:17:47 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso9420535e9.0 for ; Mon, 03 Aug 2026 05:17:47 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4980878dbaesm385075295e9.12.2026.08.03.05.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 05:17:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785759466; x=1786364266; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=set/tVnmTwyRXbbS2/hm5WA+Lv6/Z4na9/ek1L2Zqls=; b=cH/Iy6UsSU6DHVKYmaFEcS/x2i5uL7oEnjKgilZ36XcHrzdGQNn6JXdrGAYSL8Zfra 2X/xzUiwLWy3dacdLCoBfhZZuZvfgU2xz5XRaLINNqB82QkTmOw4ZDwI3AHjNwNT51ns +8GuAXCKwoF1EeQ2Ed3SVdz/QWrirsaY8RMTw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785759466; x=1786364266; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=set/tVnmTwyRXbbS2/hm5WA+Lv6/Z4na9/ek1L2Zqls=; b=CkIKgvgU69wmdzcqfOU0ITV//v6z4rdurkyW4+jzrFRz+2TGv3HTpeB1jsRaz32KAF lDthXnEL0cJ3jdc+MntOjMOp0oYVYBUGZjcU6MyZeJRlOrhmykUuI7TBe1j3/QhtepYR 80MTZCwzhUER58cIb0LoftfZ88Vl2shkbWzJr6F471X6k7dfNqwLqKflhG87qf1bWd7w /ImoeVkX0jCsQH3wjZnAwpIDRyaKfYK7FrA/xKWRa/aPBX/oelDDx20+XQKM0GjuJldi 4Y/y0CfTb5EcjMf60MYSNl2PyNOH7FNKeW5ZBWoWrVjxSJZIGvC8IC4Ys8y2jyndbTGi COqw== X-Gm-Message-State: AOJu0Yyy40q3dtH51z8lOshCm+xBfLz/D2q/KRcE6+Lu8Yq8r/b1mGQT uiqoZNgwXgCBW8R87bcVTmRKh7C+bGQ4G/tMlsXV8mt9KqUdTh4PoQawSBgseqRUOD01cJu6Fc1 P3VWL X-Gm-Gg: AR+sD11Ienn+VMFqdTwDkUhqKpSgwJoZ1vMBIi7T1LRYF9GkYTPOGjd+ylsR5kEzpJz 66s+5S2/DANnkAirjaq+/WDp8WyyMw9PmL9Wpw1PKlhBYIt7080nMm9eqHiao8vIINjsYcRtsT0 2gALCWlw8rJVbVpkAxLFs3xeTxNpdNLvZOZKQv6rKQVuR85/EgW1LAX1Kl/h5Ko0zrghyrHRmQp JgsjKQsVTHyYSgGEM+4dntQ4wtUvqqLQcgPieAelEG+78p2iqe7mM225a+dpVY9uAmh6lo5EDDJ BOllFZ45TGChLD33UkivzMn4pgfESowxYfO/n7+E4HqdoXH0YTwWRF5rZv8cGRqY3d1fXs5xfHA iQuDgpebdbX3yMocFajI1zJ7iHahTFfVBkKUH4+NERMdnUziXsuTdkZSUO8l1jjVNQOiyK70hQA GVMaytQXxp52Z1vczQ4jYpayCG0Lh+dqkGNQ1PxbgrvAybpMrgjUBwk2jOyHiRnoZ2qvvc/tBOs XinsxHN6atfFho2W6DPMkZVjOZURyuVYa49pik= X-Received: by 2002:a05:600c:5249:b0:495:3a52:71b1 with SMTP id 5b1f17b1804b1-4980eb9b2eemr144134715e9.5.1785759465972; Mon, 03 Aug 2026 05:17:45 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Bernhard Kaindl Subject: [PATCH 1/2] xen/mm: Alter get_outstanding_claims() to return information by value Date: Mon, 3 Aug 2026 13:17:38 +0100 Message-Id: <20260803121739.370951-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260803121739.370951-1-andrew.cooper3@citrix.com> References: <20260803121739.370951-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1785759467-F429B2A1-838194D7/0/0 X-purgate-type: clean X-purgate-size: 3474 A void function with two output parameters is a weird choice. Instead, return a two-element structure. No functional change. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini CC: Bernhard Kaindl Slightly RFC. claim_info_t name subject to improvement, but see next patch. This is to help unwedge the XenServer patchqueue following commit 44adbac3c7a6 ("xen/mm: Introduce per-node free page counter"). --- xen/common/page_alloc.c | 10 +++++++--- xen/common/sysctl.c | 8 ++++++-- xen/include/xen/mm.h | 6 +++++- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 598222e2c2e1..900fcf5755c1 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -582,12 +582,16 @@ int domain_set_outstanding_pages(struct domain *d, unsigned long pages) } #ifdef CONFIG_SYSCTL -void get_outstanding_claims(uint64_t *free_pages, uint64_t *outstanding_pages) +claim_info_t get_outstanding_claims(void) { + claim_info_t info; + spin_lock(&heap_lock); - *outstanding_pages = outstanding_claims; - *free_pages = avail_heap_pages(MEMZONE_XEN + 1, NR_ZONES - 1, -1); + info.avail = avail_heap_pages(MEMZONE_XEN + 1, NR_ZONES - 1, -1); + info.claimed = outstanding_claims; spin_unlock(&heap_lock); + + return info; } #endif /* CONFIG_SYSCTL */ diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 8fb5ff0af317..35c132564ef1 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -248,6 +248,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) case XEN_SYSCTL_physinfo: { struct xen_sysctl_physinfo *pi = &op->u.physinfo; + claim_info_t claim_info; memset(pi, 0, sizeof(*pi)); pi->threads_per_core = @@ -259,8 +260,11 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) pi->max_node_id = MAX_NUMNODES-1; pi->max_cpu_id = nr_cpu_ids - 1; pi->total_pages = total_pages; - /* Protected by lock */ - get_outstanding_claims(&pi->free_pages, &pi->outstanding_pages); + + claim_info = get_outstanding_claims(); + pi->free_pages = claim_info.avail; + pi->outstanding_pages = claim_info.claimed; + pi->scrub_pages = 0; pi->cpu_khz = cpu_khz; pi->max_mfn = get_upper_mfn_bound(); diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index b80bec00c124..74d28d2a1b7a 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -132,7 +132,11 @@ int populate_pt_range(unsigned long virt, unsigned long nr_mfns); unsigned long __must_check domain_adjust_tot_pages(struct domain *d, long pages); int domain_set_outstanding_pages(struct domain *d, unsigned long pages); -void get_outstanding_claims(uint64_t *free_pages, uint64_t *outstanding_pages); + +typedef struct { + unsigned long avail, claimed; +} claim_info_t; +claim_info_t get_outstanding_claims(void); /* Domain suballocator. These functions are *not* interrupt-safe.*/ void init_domheap_pages(paddr_t ps, paddr_t pe); -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:17:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 12:17:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381421.1625007 (Exim 4.92) (envelope-from ) id 1wqrc5-0007HC-UF; Mon, 03 Aug 2026 12:17:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381421.1625007; Mon, 03 Aug 2026 12:17:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrc5-0007Gb-QY; Mon, 03 Aug 2026 12:17:49 +0000 Received: by outflank-mailman (input) for mailman id 1381421; Mon, 03 Aug 2026 12:17:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrc4-00077Z-88 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:17:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqrc3-007wIE-KV for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:17:47 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7086e0-e002-0a2a0a5209dd-0a2a450ce7d8-8 for ; Mon, 03 Aug 2026 14:17:47 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7086eb-f479-0a2a450c0019-d155802da8b9-3 for ; Mon, 03 Aug 2026 14:17:47 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso9420635e9.0 for ; Mon, 03 Aug 2026 05:17:47 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4980878dbaesm385075295e9.12.2026.08.03.05.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 05:17:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785759467; x=1786364267; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6JCAOMMwTyxZkSFy3FwTezM7XZSAFX+kgUtlaig++k8=; b=mOkAGSdoBYNCkt5FcZovfp+J1gfWzFXJU/bFm5A3NDlOJ0Bglg0BItrHzw6M8GCBfJ WjW+sgALauKbsozsD1zwZXf9QY4b6EIiyXC/ONgpiduR3E+B/bk8xYfgQ0ROFX/GnfKH 5j2O75qojRgZGKjUAv401lGyBXhyzbkEcpinw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785759467; x=1786364267; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6JCAOMMwTyxZkSFy3FwTezM7XZSAFX+kgUtlaig++k8=; b=W2WTESaWD3x3bIU1KHb4yvjT8X7SXhEo2TNHCTt7bpXOfyo3imDiqiKUSFnQOcFTiN N9yq0a/Pp/F2nbIvRAXu7Z8bt0AXN3gkK5Vwg9O5McDBjR+3vSfwlWV6PnOIaC197zww QdOLFt7QLQC2BWPaKrfJjKDBUqQd5DaliTnkuJiwGa81VtZM29FGWlKTTw3wzS0zmkA8 /34gb7+DpYfNTR5jQ3D4tjbN17s09N3mm8U5mgTiJHqEdEGxARDbpLxghKLW5tdD5dEj gWQaUvle9G7NGSniDq8nEwMDTpq+9HFzWafR72r6IJj9iSzDmBH89x9qkPG4rhc0psme XhDw== X-Gm-Message-State: AOJu0YwcwqvvcIfe7Wb6DSNbvohOx8ce+zf9q87uJ74BkyNAoQv6XDtG weDEW5fuyMHRazZlOFkMW15mvNZy+fKnfsVAmKL7hIbYdSD36wVwhoA9vqZc21oclMxW4VCxgOA CvM8BJKQ= X-Gm-Gg: AR+sD12NxoAIjhFCiIfuH7QEEjjAssJVsFK+DCiPaoXyUsjcSm7FFoFU8Y5nWwaJcUo 1471nLt8l+TdD9Ohh70CPVYf6kngBu+oQ0kVXN5bybY5v7TwMHuAYfDHeBNIfLhibBzKT7yJguW TKnN/bzPrmsEf/P/2jjvyWdXOaEhosMKLPfWZwfwMdKCKgvd4+V6vxqXkM81a0o/iB4OB39PLWp BDC50JPvEMtFa9HQ/uI/zg6nWluOYj9gJjahq/A9lJ6S3+Pj9IzSjKVnHLZF1BoeE0rFBbvo2f/ L82hJOjSXjoLG7uPMOeGT7U9EZvvrxTfM3660eZ/BqgfVmcRhCojejpxVhVVq6nqKbGcypQLcHl YD0Fqp/z8+fZPpsQepco29RZH/kHSc4r18W5XJBTUwSElp68etNHkNzKYJpvq9MANXz6OaALyrF B8u5y4MxFS68vymQwGos27+WJIaFCUCXZ83KFUzslE/ZHrabCQv8gBwS1KaUnzUltlIppoNRJzq xiz6/YWqa7vWNuQPuSIQwtHhzdfd249DIpOPxrc+ic0Yyx5cg== X-Received: by 2002:a05:600c:3150:b0:495:3c6f:7c18 with SMTP id 5b1f17b1804b1-4980eb8c4c9mr154961375e9.3.1785759466769; Mon, 03 Aug 2026 05:17:46 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Bernhard Kaindl Subject: [PATCH RFC 2/2] xen/mm: Return claim information from avail_node_heap_pages() Date: Mon, 3 Aug 2026 13:17:39 +0100 Message-Id: <20260803121739.370951-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260803121739.370951-1-andrew.cooper3@citrix.com> References: <20260803121739.370951-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1785759467-01AC4A5B-269A8F01/0/0 X-purgate-type: clean X-purgate-size: 4060 Fully RFC. With per-node claims, avail_node_heap_pages() becomes: claim_info_t avail_node_heap_pages(unsigned int nodeid) { claim_info_t info = {}; if ( nodeid < MAX_NUMNODES && node_online(nodeid) ) { spin_lock(&heap_lock); info.avail = node_avail_pages[nodeid]; info.claimed = node_outstanding_claims[nodeid]; spin_unlock(&heap_lock); } return info; } along with modifications to the callers. I'm not intending to submit this patch as-is, but it is present to help judge the naming. Not-Really-Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini CC: Bernhard Kaindl --- xen/common/numa.c | 2 +- xen/common/page_alloc.c | 8 +++++--- xen/common/sysctl.c | 2 +- xen/include/xen/mm.h | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/xen/common/numa.c b/xen/common/numa.c index 92f8f1cedce1..eef8be06944e 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -713,7 +713,7 @@ static void cf_check dump_numa(unsigned char key) printk("NODE%u start->%lu size->%lu free->%lu\n", i, node_start_pfn(i), node_spanned_pages(i), - avail_node_heap_pages(i)); + avail_node_heap_pages(i).avail); /* Sanity check mfn_to_nid() */ if ( node_spanned_pages(i) > 1 && mfn_to_nid(mfn) != i ) printk("mfn_to_nid(%"PRI_mfn") -> %d should be %u\n", diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 900fcf5755c1..0b0f2033e738 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2852,12 +2852,14 @@ unsigned long avail_domheap_pages_region( return avail_heap_pages(zone_lo, zone_hi, node); } -unsigned long avail_node_heap_pages(unsigned int nodeid) +claim_info_t avail_node_heap_pages(unsigned int nodeid) { + claim_info_t info = {}; + if ( nodeid < MAX_NUMNODES && node_online(nodeid) ) - return node_avail_pages[nodeid]; + info.avail = node_avail_pages[nodeid]; - return 0; + return info; } diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 35c132564ef1..4d8dba51eb63 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -315,7 +315,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) if ( node_online(i) ) { meminfo.memsize = node_spanned_pages(i) << PAGE_SHIFT; - meminfo.memfree = avail_node_heap_pages(i) << PAGE_SHIFT; + meminfo.memfree = avail_node_heap_pages(i).avail << PAGE_SHIFT; } else meminfo.memsize = meminfo.memfree = XEN_INVALID_MEM_SZ; diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 74d28d2a1b7a..e8b81c0f1fc6 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -137,6 +137,7 @@ typedef struct { unsigned long avail, claimed; } claim_info_t; claim_info_t get_outstanding_claims(void); +claim_info_t avail_node_heap_pages(unsigned int nodeid); /* Domain suballocator. These functions are *not* interrupt-safe.*/ void init_domheap_pages(paddr_t ps, paddr_t pe); @@ -145,7 +146,6 @@ struct page_info *alloc_domheap_pages( void free_domheap_pages(struct page_info *pg, unsigned int order); unsigned long avail_domheap_pages_region( unsigned int node, unsigned int min_width, unsigned int max_width); -unsigned long avail_node_heap_pages(unsigned int nodeid); #define alloc_domheap_page(d,f) (alloc_domheap_pages(d,0,f)) #define free_domheap_page(p) (free_domheap_pages(p,0)) -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:17:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 12:17:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381419.1624996 (Exim 4.92) (envelope-from ) id 1wqrc5-00078D-CY; Mon, 03 Aug 2026 12:17:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381419.1624996; Mon, 03 Aug 2026 12:17:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrc5-000786-9j; Mon, 03 Aug 2026 12:17:49 +0000 Received: by outflank-mailman (input) for mailman id 1381419; Mon, 03 Aug 2026 12:17:47 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrc3-00077S-IK for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:17:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqrc2-00EkFX-6l for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:17:46 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7086e5-5cb7-0a2a0a5109dd-0a2a4504b816-24 for ; Mon, 03 Aug 2026 14:17:46 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7086e9-b57f-0a2a45040019-d1558035bc43-3 for ; Mon, 03 Aug 2026 14:17:45 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so10913155e9.0 for ; Mon, 03 Aug 2026 05:17:45 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4980878dbaesm385075295e9.12.2026.08.03.05.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 05:17:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785759465; x=1786364265; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gkyO29GJSH16hZeyxTwBRFcZE8QggRPa17kg4rPW+xA=; b=VnRBB3Aw1q5+bxfBTzXuCAS3UuYSMOALweyDCRorryARCf5PFFwMNgJ8STKlhlDFBw ys4D2hQkRh+ilxRhZTbog021Ngx7t14B/qFOa9QohCmmMRBMNhSmhRFp0I1srIwL22kw C6ijzoeGRjvRip1I4yGFm6JvgDaDugWkXx7Gc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785759465; x=1786364265; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gkyO29GJSH16hZeyxTwBRFcZE8QggRPa17kg4rPW+xA=; b=UD76hbY5kQ6D3H59pO5+RcBFzsUUPpyy5JsCWdkB2HPcGizBfhiYLGmMiMZzGyOse2 oqNTOCUOuXpKH4rdGcwhg17D4W2Wc75/4AuFJb4oDiWFzFeFRGgAsPnxWk1NQmtpCzSa axuBMyY2HnQ2rP0K3+NUKHTqheLjrLZiBgrUJUWlVSbdcTwKTATKumD/tX1QzNIMIJfi ne3CddUK51FwAfPXrJkQanZ6gzfmq09dDA8XgbEZxRMzaIH8S01kLcJoeGxT343m4TD2 KUm7g+shc+ALINi7jpEnLm0GIiwbtiH1GCsB/wSFl51XaasU7maAc4RqUmIctdFZF+kv 7NDQ== X-Gm-Message-State: AOJu0Yy0XgPAF0j0w73OwHdJGi/YRAF6IbzDtc5ocsDPHLmQjn26AgYY 7xbrvGqANCppfXn342NFwEH2fVe2pAn2poox7eMrzMBuT+J6W8evMzubA8uhCEna1FZh56st7pg BD8OlTFQ= X-Gm-Gg: AR+sD134GkHR6FYjeFExSMcoMc7+8BrE/6CI9FCLLTlkanJpS8Lg32aBjGQre+6WNBs zw+8cMUcDVxy7P3NBcRb/fUEDLlBFGavb9zpGWqIIYHZ/VWOKGgR6wQk8vbHAZOupVtbhKZ3mzB aH5AlcQnSK/GT/UQugRuxGA6El45h7s6BIuYQEsz7BxIQAcJdw2rMEDtE+5YYTM7TE+9vhC8wp+ sczBbYaKe7qCQvSIgRzIgLub+CGGxOJSXRws/qAzfDJDzjzsDZ8ha4ylV3tmhvddNqaeeSFKkHg mrnYp+fMwOvagQs7GMB8pXBQsCFEnG+h7FaSGii6GHPMsYgRXpWSo2hRmlOEFn8WUTiJYkWqnv9 9abaKGFikzbfS5bugOvb6Wzu7sA1LqnhynOVSqW/o6Eo9CJtynnHD/lKwkCqJRA66+/HjINg5vY jpknSjQOA4aK9SCNZe9klYGw1jP2Sp5iKvCTcrb4Gx7SIlzp3jmm1/9lIEzXaU0GhVmBzMEZTuK Wce8r+t7eRqbi4qMVUCfi02yNXKxb4Jh67tumc= X-Received: by 2002:a05:600c:4e94:b0:493:e365:ace9 with SMTP id 5b1f17b1804b1-4980ee9ce83mr174598615e9.11.1785759465068; Mon, 03 Aug 2026 05:17:45 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Bernhard Kaindl Subject: [PATCH 0/2] xen/mm: Alter get_outstanding_claims() to return information by value Date: Mon, 3 Aug 2026 13:17:37 +0100 Message-Id: <20260803121739.370951-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1785759465-50AD8B50-06B1DC1C/0/0 X-purgate-type: clean X-purgate-size: 529 Changes to help unwedge the XenServer patchqueue following commit 44adbac3c7a6 ("xen/mm: Introduce per-node free page counter"). Andrew Cooper (2): xen/mm: Alter get_outstanding_claims() to return information by value xen/mm: Return claim information from avail_node_heap_pages() xen/common/numa.c | 2 +- xen/common/page_alloc.c | 18 ++++++++++++------ xen/common/sysctl.c | 10 +++++++--- xen/include/xen/mm.h | 8 ++++++-- 4 files changed, 26 insertions(+), 12 deletions(-) -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:35:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 12:35:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381444.1625022 (Exim 4.92) (envelope-from ) id 1wqrsi-0003Oj-AD; Mon, 03 Aug 2026 12:35:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381444.1625022; Mon, 03 Aug 2026 12:35:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrsi-0003Oc-7B; Mon, 03 Aug 2026 12:35:00 +0000 Received: by outflank-mailman (input) for mailman id 1381444; Mon, 03 Aug 2026 12:34:59 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrsh-0003NR-9R for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:34:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqrsg-005IeJ-M2 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:34:58 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a708aef-2eae-0a2a0a5409dd-0a2a450cc58e-22 for ; Mon, 03 Aug 2026 14:34:58 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a708af2-f479-0a2a450c0019-d155802fe025-3 for ; Mon, 03 Aug 2026 14:34:58 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4956242332dso18003175e9.2 for ; Mon, 03 Aug 2026 05:34:58 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808690ffbsm256801355e9.10.2026.08.03.05.34.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 05:34:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785760498; x=1786365298; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=69n3Og5xkKdvFQyeK95WwlJPqVsgYp8WOb8rfW4Bplc=; b=HP9ThGxsiSh1MYpFH8qbApBaNOIDJhCPrw+KQn5N2x6QWQZF4EmzDdt7CftEohtDF5 VRPbOJfgPjGR7oNe3TgIqqPYXoiDPdO9JSXBrqHxVSbkQBHdZL27jTU2tg5IA+KSqSZb FGbz2TGtQ3+6tAQ+yN9L8awbGYUznmtgyLSlmFvJE2+ERfpGdugS7K5/S1qPdF3v8B91 KsynlmmVtgVW6HcaYGjuLv1djOOWiHHoeqqzePEF5DeMNWLdkGR50ADWY28DveAVOyEU oniI173F+Oj2pErDJRyu3vO0MYRoPkVntEJi+r5bGElKJJIWkVQFoQld/+Diy9kI4hj8 tQEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785760498; x=1786365298; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=69n3Og5xkKdvFQyeK95WwlJPqVsgYp8WOb8rfW4Bplc=; b=oTVzMY4k7ck0FiNo57VHVAF5GQnnBkj+L1pBtUaJUJWNynsUc17gATXw0NkNrChLl5 ukPn/Y5a7YJvX/FFdzFy2T9OnXDMx2cqHGb2v3QLNX25dmNqCv993j3atO6PKD33yZvW eyyT/nlWMtjR8pgi9W6f4tylgQhtLjgjMEIXsEA4m0lvkaFoAFR/oVlNzkD5BKjUoZQW DcIkZad9dSQOhKKDbKVCAf5cRRzxh+nvcIEhKIJuHf9x4z9uUUkjvvnVx0PupUXnqzJw zqP6d3rHOeENx4H2hjHyvZ+qWyLRtM3u4K0Y9k0l9wXWMs3JcDfC4tJf2QFKBKHx+YhZ G2Sw== X-Forwarded-Encrypted: i=1; AHgh+Rr3SaOuIywit3c2maQE/rlUEwIcbgGUx7mP0TJaojdx3IEfp02TnR/biJmzBMYJWYEMc8xDZuK09p8=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw11lWxIroyrVad8wqTAcEZmq1PRyo5ZJrvWh9jV8sw9gxG/R/8 LTfgiS44X6qxNboSemBbVKZr+xI1kKhvBhso1NK/p4qPbkpllHfQURvOW94oQYKvo0IOL9+buhF PWG/AvA== X-Gm-Gg: AR+sD11OmaNxhZQ65FY6V34LBNj21A99Jdk+kIMiiSMZNZXJegNq/djxOAVLcC408pz XSOXoEc4175Pj3aiLF891qZu/BO2O2yFwRWW/BPh+SkBqZPVK9HIiFt2g+9ho3Axsa+WB5AAcyS /HwMiHGYFdFzb4DJM1XfEi+l0Aaiav3fWn4sWm92ddLo/SDVjTHGJAL1pBhPDqZMtglIrPxP3Pq ETzxKq43EnSQao4AT4S548RBv37dJBW3tCxbAcTm50g8fxZU9SQiCNkBjyg6PV0dmLwxAet2LaJ aZiPGico3stNhH5OAHfXfOM1S286eJJgqqCLcMojWciz196btEXRJA1oKPZGIMOOyqH275BBpfW H6zbgd9kO/W7akIQAI7v1t7ED5GP4Nf/xu5qRYfLxX7ZI/NNEp0O7E/g7vxp36GS7GgTaCMNot3 3hZ61Iq78wprAMV37iCQeY0P9/KgaB3ezzIqCKySGy25D2BiNcx61F2t5inBDyxQ6aULfulmsGD mVtdyXtCCwu8/nq9cihWVMx9Mp+F6jJfqjswkC5sJfHuLhdRX9p X-Received: by 2002:a05:600c:840f:b0:493:c42e:5be0 with SMTP id 5b1f17b1804b1-4980c60705amr202123705e9.0.1785760497947; Mon, 03 Aug 2026 05:34:57 -0700 (PDT) Message-ID: <9ad2867a-3d01-4ff3-bb9f-d89cf9d4e96c@suse.com> Date: Mon, 3 Aug 2026 14:34:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] xen/mm: Alter get_outstanding_claims() to return information by value To: Andrew Cooper Cc: Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Bernhard Kaindl , Xen-devel References: <20260803121739.370951-1-andrew.cooper3@citrix.com> <20260803121739.370951-2-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260803121739.370951-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1785760498-004CFA5B-D56C6D9E/0/0 X-purgate-type: clean X-purgate-size: 1281 On 03.08.2026 14:17, Andrew Cooper wrote: > A void function with two output parameters is a weird choice. Instead, return > a two-element structure. Hmm. Generally in reviews I'm trying to recommend against returning of structures by value. I don't like this very much here either, and it is (slightly) harder to use ... > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -248,6 +248,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) > case XEN_SYSCTL_physinfo: > { > struct xen_sysctl_physinfo *pi = &op->u.physinfo; > + claim_info_t claim_info; > > memset(pi, 0, sizeof(*pi)); > pi->threads_per_core = > @@ -259,8 +260,11 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) > pi->max_node_id = MAX_NUMNODES-1; > pi->max_cpu_id = nr_cpu_ids - 1; > pi->total_pages = total_pages; > - /* Protected by lock */ > - get_outstanding_claims(&pi->free_pages, &pi->outstanding_pages); > + > + claim_info = get_outstanding_claims(); > + pi->free_pages = claim_info.avail; > + pi->outstanding_pages = claim_info.claimed; ... here. If others think this is the way to go, so be it. But I'm not in favor. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 12:40:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 12:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381453.1625032 (Exim 4.92) (envelope-from ) id 1wqrxd-0005Wo-0D; Mon, 03 Aug 2026 12:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381453.1625032; Mon, 03 Aug 2026 12:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrxc-0005Vy-S5; Mon, 03 Aug 2026 12:40:04 +0000 Received: by outflank-mailman (input) for mailman id 1381453; Mon, 03 Aug 2026 12:40:03 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqrxb-00056b-B4 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 12:40:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqrxa-005Jvb-Fl for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:40:02 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a708c1d-bab6-0a2a0a5309dd-0a2a4506e340-20 for ; Mon, 03 Aug 2026 14:40:02 +0200 Received: from [209.85.218.50] (helo=mail-ej1-f50.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a708c22-195a-0a2a45060019-d155da32a49f-3 for ; Mon, 03 Aug 2026 14:40:02 +0200 Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c15e03c2763so621708866b.0 for ; Mon, 03 Aug 2026 05:40:02 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd4662727sm496448466b.59.2026.08.03.05.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 05:40:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785760802; x=1786365602; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1Rv9ekgCqFE0xkNpyFLzSLNtbTIiyypWYXYLZoy/njo=; b=HgLZAaryCEs0vSZSyglCCysp5cBn168Ke+IThMbuhFHaqCwCgn4BPGsGjsukMRq8Cm T0HD1a6TZJexssHtahpC/MyFShAJD9OJJWE58vW3QgPJ/uXTtVzsYLfe1v1bvz+Y62yQ guUEG10MYkCi3Zp3uGIRZAT1ik+WgyRJg7Pg/y0k/Xbv6oWZjIktOW/paAEKT0PXs1Op CI17u0CAVye8rf4MywTfsTRJ4AqWrZd82BBT7/JUxhYTPuLBG9S8h55hoedyw7BUDrRR +kmVKS7agMmopXuDg7KOCt9mzKBZr3UoRVR/Y9EtItPWSBTxjLnWO1dOZfcBs2T0PXYk akrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785760802; x=1786365602; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1Rv9ekgCqFE0xkNpyFLzSLNtbTIiyypWYXYLZoy/njo=; b=dK/BK3m+JZrtOhS1IAElgT7JsaTiIuYJFzuwBoWgJyn6Y+jE8sF130LxWGsN+GKKke ce1wrZGbg5HfsbS08YS+UflW/HWNy7SfZD6QasL97n7egz4a+GDFrHq8lfWYsRntyt35 N9NwsFaYAvu5Y4akPswGw5/YoFWvzAcScoGtTy39Wx5VnCrrdlGfPzTs771StAmr6mWV zOb37H34AvLccym5jdLMWCi9PYeaSc9fIR2z4/4+q46bgHBUnry3bDWv/bRwHsHL5/o2 u01+y16hLHh9kvJ51UC1R/5HjS/lD41APe2i+WcB9Jen80vpiF/jXEUijXlao4Hb7ulN sCmg== X-Forwarded-Encrypted: i=1; AHgh+RpiUqqHy7pXL6MEq4XVp+qgzjShbbU3tmCpmFqjopk+SPOMIMs/862HjZJ+WFtlx/t3DeyvE6u3gvM=@lists.xenproject.org X-Gm-Message-State: AOJu0YxvGQA+egGcyiyg7bjYVOsj+XqtYHjCNzPWFGzuVQWwonoP0OB7 m3fUWYGK0ChNSU+PcvD5cGDjfpmmVilDebZ7lWXHIJDkrqKUMC+DZ0X08p6WtSo4YQ== X-Gm-Gg: AR+sD13grdeFxoSsMN765r7+DQtGx3RiROd+afMgpUe6lBtBxn4XZupF43BJeYW2U+F ztjEOiMZtzUhE4wda5TvpPEsAVYk/GMkhxzwMm9nA25yK/eXsmeteYlY8k6A/a12TwUVTjIXdBy TOOgOSLP0I3xnPyElNYlvXs9dSeS23ePO7xMxZMkR1ttDxib7VF5BC0DUPXuuSGcTUPXAYRO5bZ pmC+XWi2lr3bv/WdKFrWy18UKe2pqySFA2tYAc9mTk2niO6KFfJSONmTWuP3VxtiFjBFrXJ+b+0 bOb0R8WGxGedhWtJ7vS1TRv9rzpOkoCtfdQejY2KTU+EoKJ5AS5M+BDrPjFd9GT8MVi0xthZUz6 gDbcM/orftdTSlPRMoBu6IpL4/a0kaDwWy52DwyJq1JLFayfz64cONWIfdSJk1aQ3SS2MMj2Nyx beHmDTcYNHSzdxoB7N6IsKCBELpRIKQ4JGL43nutWDtu108dKdluLGw/Gv0ZiJ9WHwofBTvK4OS OS8RtIan9vLGSG8Np0oVs2I1I4OnOqr0Fy2pJBiIDXNMgk5PBvianUeEeHyeP6N X-Received: by 2002:a17:906:9c96:b0:c19:7908:c67e with SMTP id a640c23a62f3a-c1fd316d26bmr966117266b.4.1785760801966; Mon, 03 Aug 2026 05:40:01 -0700 (PDT) Message-ID: <166491d8-70f2-4250-9212-e86b002d877a@suse.com> Date: Mon, 3 Aug 2026 14:40:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] xen/mm: Return claim information from avail_node_heap_pages() To: Andrew Cooper Cc: Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Bernhard Kaindl , Xen-devel References: <20260803121739.370951-1-andrew.cooper3@citrix.com> <20260803121739.370951-3-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260803121739.370951-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1785760802-F5C0F77B-AA87A6BB/0/0 X-purgate-type: clean X-purgate-size: 1024 On 03.08.2026 14:17, Andrew Cooper wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -2852,12 +2852,14 @@ unsigned long avail_domheap_pages_region( > return avail_heap_pages(zone_lo, zone_hi, node); > } > > -unsigned long avail_node_heap_pages(unsigned int nodeid) > +claim_info_t avail_node_heap_pages(unsigned int nodeid) > { > + claim_info_t info = {}; > + > if ( nodeid < MAX_NUMNODES && node_online(nodeid) ) > - return node_avail_pages[nodeid]; > + info.avail = node_avail_pages[nodeid]; > > - return 0; > + return info; > } Why would this be? What use is a compound return value consisting of two pieces, only one of which is ever going to be non-zero? In the form shown for per-node claims that effect goes away, yet at that point the function name doesn't really reflect its purpose anymore. As to the naming of claim_info_t - that's perhaps good enough if really we want to go with the return-by-value approach. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:06:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:06:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381489.1625042 (Exim 4.92) (envelope-from ) id 1wqtIc-00053R-T6; Mon, 03 Aug 2026 14:05:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381489.1625042; Mon, 03 Aug 2026 14:05:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtIc-00053K-On; Mon, 03 Aug 2026 14:05:50 +0000 Received: by outflank-mailman (input) for mailman id 1381489; Mon, 03 Aug 2026 14:05:49 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtIb-00052v-Nw for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:05:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqtIa-000TjP-Pi for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:05:48 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70a036-e002-0a2a0a5209dd-0a2a4503cfa0-32 for ; Mon, 03 Aug 2026 16:05:48 +0200 Received: from [209.85.218.43] (helo=mail-ej1-f43.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70a03c-fae8-0a2a45030019-d155da2be131-3 for ; Mon, 03 Aug 2026 16:05:48 +0200 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c1c50c1e29bso484054066b.3 for ; Mon, 03 Aug 2026 07:05:48 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44541fbsm550119266b.39.2026.08.03.07.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 07:05:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785765948; x=1786370748; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=6cbka/s3gspot+G9lavFH5bjpkJkKfJrehNnhrK+WT8=; b=HvMNk+ofziRczVbAvUa066mltEf+V7dIhZWe2mQXh3Y8JX95S1uQdi6Xdr13f6DKmQ v2rp6Wee91Q8m4QhcO8tOfgYPCthIx5Yi+jIGNQZPOsP2C00NTt4zmj1ByfmhoYtyb5g +N/0CGx+TimO3g28RA9Z2U167mE200VCL5/xCQf1X3y8fgGrv52P4z3GJq+7LEqFTthE xCEqsBs1KzIdIcIrcdbBJdjBcZDnzXXqWPmfTjrvq7ID+ak3Zn6bUwYX01fWX44dJxlY qE1JMfDLc+K4/RtwuqFDBWCGD300vW8NnIxAGuxWmb9ig4BbRbuKyc0vDAw49SliWtGO nTPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785765948; x=1786370748; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6cbka/s3gspot+G9lavFH5bjpkJkKfJrehNnhrK+WT8=; b=IqxDXYRxds6v5I1+ShYjgKCibH6W74iX+4RaH+WTz4rojBPRiTl6maS4ilnjRgjF6G As6E73w1dg3xoFyGKj4WcKwoVMn5oW6Ozf0IH6oaRoz6TOk3YA94A9qcN5Qd5JHz5mWY aQQ5atyoRNC37LE0xLtDhF5X+KMTrlqtzyF+EZhp6Ob9CnvN4oh+EtEIB2zdW9jRyHIY WNwMijb3P2rSKYKgmF6SOaBq1sWrAYhf4DlxR1mJ/wspHyw3l7zT7lW6SmxTSh5Z0d9o ljfdTHCNnQTM++G04KP8u9vlNljQw0empVLgBOAr3h7vPXlp9iTR+rGLW1WwOP9V/xrj fkWQ== X-Forwarded-Encrypted: i=1; AHgh+Ron92sfcg9x+xvpLMTbVeXvsWfvy3e5nxWVUoSii4h0TVoilLt+sHzPQFA0pUZ8BLXxn5VMfmHXLQ4=@lists.xenproject.org X-Gm-Message-State: AOJu0YwOGRx6MAJgL1lVH1MekBKqxzYHqqej5CQDwrQ1GFpSGOgbIDI1 Rm4s53ndAuT1wQiLnS1Ilwz24stRSLsCMf4niFQxZt6THWGJdC4XBxiQ6c6pm91USt0= X-Gm-Gg: AR+sD1370hpOr6IwOH7iS+zd59G0jsk9WA32nDFLTmP8vV0hYq2CDIGQTwZ73oFaHjv ajn2AENbVKu2AsoJqkisPjD1wM+/UhACRnqFECu9lZl5WFlCoNYGqfDeMrYYQvHT1+w2jmEoNzr 67RZEBeqssFiGmhCfvzylJrZ8/OEDgsZZyZP9CQGNrdrdIHDpVpQgmCrmuhYpDLQnhUsqm4mjwI sVTrNnI+vVNmBm2p/DDpN5h7CD5f4Nx05hK7JLYDtLQr1/CDhZ3ltnsmOYMH14GgFoeq6MpvmTt 8n2Ivam5pVmP4uVN9REOtvPvvXZVwE2Z3li0iByDXvFUhulFPqLD8qLthimP52+PGTW70sDCUYg dskr8sk/+Pni/dtPC9yIF0StfoqLhjcuu1AU5cBnxTxLWfUo8JSmHjgFLovnCrsK5Hm4N+0iQw5 V4/3phSjlrCLeaff7CoLR31npuXNvgIvxB13Rq1fT054Am8Y8Jdg6EdoXC0cNXEngJEgWbiIsJh rUGsdWn/LFKsn5klPUnNjmj+lacU8eMtmKzWTZd3ElntPVUAQz1wGp0cl+xwKnA0R7wrjgd0guS pr4SFkKrKXNocpo= X-Received: by 2002:a17:907:c28:b0:c1c:3b06:ed19 with SMTP id a640c23a62f3a-c1fe82058dbmr830741166b.31.1785765947878; Mon, 03 Aug 2026 07:05:47 -0700 (PDT) Message-ID: <439c2740-fb84-42cb-b001-cb290684a583@suse.com> Date: Mon, 3 Aug 2026 16:05:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH Linux v6 16/16] xen/privcmd: Add new ABI to allow copying foreign memory To: Frediano Ziglio , xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-17-frediano.ziglio@citrix.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260619130501.272832-17-frediano.ziglio@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------eViDH0Q70fvb6ZFclS200RM0" X-purgate-ID: tlsNG-33051d/1785765948-752854E9-EB66C591/0/0 X-purgate-type: clean X-purgate-size: 9769 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------eViDH0Q70fvb6ZFclS200RM0 Content-Type: multipart/mixed; boundary="------------jJl2wII0I5iZYAc7xTzCv0ty"; protected-headers="v1" From: Juergen Gross To: Frediano Ziglio , xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD Message-ID: <439c2740-fb84-42cb-b001-cb290684a583@suse.com> Subject: Re: [PATCH Linux v6 16/16] xen/privcmd: Add new ABI to allow copying foreign memory References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-17-frediano.ziglio@citrix.com> In-Reply-To: <20260619130501.272832-17-frediano.ziglio@citrix.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------jJl2wII0I5iZYAc7xTzCv0ty Content-Type: multipart/mixed; boundary="------------mDmQSlGNimUUgFFkZKGULTvo" --------------mDmQSlGNimUUgFFkZKGULTvo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDYuMjYgMTU6MDUsIEZyZWRpYW5vIFppZ2xpbyB3cm90ZToNCj4gVGhpcyBuZXcg QUJJIGFsbG93cyB0byBjb3B5IGZvcmVpZ24gZG9tYWluIG1lbW9yeSB0by9mcm9tIGEgYnVm ZmVyLg0KPiBUaGlzIGF2b2lkcyBoYXZpbmcgdG8gbWFwL2NvcHkvdW5tYXAgZm9yZWlnbiBt ZW1vcnkgd2hpY2ggaXMNCj4gZXhwZW5zaXZlLg0KPiBUaGlzIG9wZXJhdGlvbiBpcyBkb25l IHBhcnRpY3VsYXJseSB3aGVuIG1pZ3JhdGluZyBWTXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5 OiBGcmVkaWFubyBaaWdsaW8gPGZyZWRpYW5vLnppZ2xpb0BjaXRyaXguY29tPg0KDQpXaGls ZSBkb2luZyBhIHRlc3QgYnVpbGQgSSBnb3QgdGhlIGZvbGxvd2luZyBidWlsZCBmYWlsdXJl cyBmb3IgMzItYml0IGFybToNCg0KICAgQ0MgICAgICBhcmNoL2FybS94ZW4vZW5saWdodGVu Lm8NCkluIGZpbGUgaW5jbHVkZWQgZnJvbSAvaG9tZS9ncm9zcy9rb3JnL3NyYy9hcmNoL2Fy bS9pbmNsdWRlL2FzbS94ZW4vaW50ZXJmYWNlLmg6MSwNCiAgICAgICAgICAgICAgICAgIGZy b20gL2hvbWUvZ3Jvc3Mva29yZy9zcmMvaW5jbHVkZS94ZW4vaW50ZXJmYWNlL3hlbi5oOjEz LA0KICAgICAgICAgICAgICAgICAgZnJvbSAvaG9tZS9ncm9zcy9rb3JnL3NyYy9pbmNsdWRl L3hlbi94ZW4uaDo1MiwNCiAgICAgICAgICAgICAgICAgIGZyb20gL2hvbWUvZ3Jvc3Mva29y Zy9zcmMvYXJjaC9hcm0veGVuL2VubGlnaHRlbi5jOjI6DQovaG9tZS9ncm9zcy9rb3JnL3Ny Yy9pbmNsdWRlL3hlbi9hcm0vaW50ZXJmYWNlLmg6MjI6MzU6IGVycm9yOiB1bmtub3duIHR5 cGUgbmFtZSANCidfX2d1ZXN0X2hhbmRsZV91aW50OF90Jw0KICAgIDIyIHwgI2RlZmluZSBH VUVTVF9IQU5ETEUobmFtZSkgICAgICAgIF9fZ3Vlc3RfaGFuZGxlXyAjIyBuYW1lDQogICAg ICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+ DQovaG9tZS9ncm9zcy9rb3JnL3NyYy9pbmNsdWRlL3hlbi9pbnRlcmZhY2UvbWVtb3J5Lmg6 MzYxOjU6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiANCm1hY3JvICdHVUVTVF9IQU5ETEUnDQog ICAzNjEgfCAgICAgR1VFU1RfSEFORExFKHVpbnQ4X3QpIGJ1ZmZlcjsNCiAgICAgICB8ICAg ICBefn5+fn5+fn5+fn4NCm1ha2VbNV06ICoqKiBbL2hvbWUvZ3Jvc3Mva29yZy9zcmMvc2Ny aXB0cy9NYWtlZmlsZS5idWlsZDoyODk6IA0KYXJjaC9hcm0veGVuL2VubGlnaHRlbi5vXSBF cnJvciAxDQptYWtlWzRdOiAqKiogWy9ob21lL2dyb3NzL2tvcmcvc3JjL3NjcmlwdHMvTWFr ZWZpbGUuYnVpbGQ6NTQ5OiBhcmNoL2FybS94ZW5dIEVycm9yIDINCm1ha2VbM106ICoqKiBb L2hvbWUvZ3Jvc3Mva29yZy9zcmMvc2NyaXB0cy9NYWtlZmlsZS5idWlsZDo1NDk6IGFyY2gv YXJtXSBFcnJvciAyDQoNCg0KUGxlYXNlIGZpeCB0aG9zZS4NCg0KDQpKdWVyZ2VuDQo= --------------mDmQSlGNimUUgFFkZKGULTvo Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------mDmQSlGNimUUgFFkZKGULTvo-- --------------jJl2wII0I5iZYAc7xTzCv0ty-- --------------eViDH0Q70fvb6ZFclS200RM0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB4BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpwoDoFAwAAAAAACgkQsN6d1ii/Ey/M Tgf2LlOj7QPEdjOxIk0ADPK+S55E6zaoy/XQvnR76J84IZnusmHhUR+Z28kG9H3O90OuKl2AFbE+ Xjr0gJjZwWqoDgrc8RR42AXoH0JjCy6EkiE0s5yZ7NRtXhwW1DFZb956Ptn96laOeRj99x3+eUJR 9DuUXt1wCVuvBp/xeXqLDIlHbi0CTxW6bKi+HE/MJzgYfnFKRuSwf1opduOXS8ilVyc9Y4y+b4SY r7DiplwBdueMiSqsb9ZQqneT64l62dzMlWAwIwlFT7yg6eLH6k11TG2Kr/pbYDYU2lHDMJq/tKYu i8iDNfNEZHqo8yal1x6QedRjpNp8G8NpKUEFybYd =wTnP -----END PGP SIGNATURE----- --------------eViDH0Q70fvb6ZFclS200RM0-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:11:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381498.1625049 (Exim 4.92) (envelope-from ) id 1wqtNn-0007Mf-Dy; Mon, 03 Aug 2026 14:11:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381498.1625049; Mon, 03 Aug 2026 14:11:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtNn-0007MY-BL; Mon, 03 Aug 2026 14:11:11 +0000 Received: by outflank-mailman (input) for mailman id 1381498; Mon, 03 Aug 2026 14:11:09 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtNl-0007MS-Qq for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:11:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqtNl-00F6Hu-7R for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:11:09 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70a170-e002-0a2a0a5209dd-0a2a4501c246-30 for ; Mon, 03 Aug 2026 16:11:09 +0200 Received: from [209.85.218.41] (helo=mail-ej1-f41.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70a17d-5984-0a2a45010019-d155da29d80f-3 for ; Mon, 03 Aug 2026 16:11:09 +0200 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c197e7e4e94so600011466b.2 for ; Mon, 03 Aug 2026 07:11:09 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd466271csm586500966b.60.2026.08.03.07.11.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 07:11:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785766268; x=1786371068; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=uuFRCL7uyGFk+NUBtcHerZxA349KsV1wcoysKkIK15g=; b=NCWJEphprSXKrxPagfR0bqFkw0oH4KIU1/aDqptyB+Wzyh9Q+Bp2p6ilBwNix/N6QG ukouWCirGkSDueieU9Bp56N/45xyrG5N36IpwAt9IRsYGLk8Ib/7TX5vUqHlPOGIbPp9 a3rrUHU3uZ2iGBGG/KZSTTrGmOeL7rVqEITCS+RW8o696PpLeYS7MZFm9waVBqbWN/W/ dnvdlBO3U4Hr3sy2pSxZwL0Lfu2dWFmweHZd4iPaChHJFTTOPA+bdgNFQlJ4L1tdaTMr ANJJw/Ewk1cx9melKvSaEHa0jWjxfK9ThRDNWI3+wWqRNEqntKESSD5BD0OfJ+0PI5O+ 9wHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766268; x=1786371068; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uuFRCL7uyGFk+NUBtcHerZxA349KsV1wcoysKkIK15g=; b=fgc18GCG1UyQxAu/wQHTe7SOwC+X5vQuHf19+OWjcpHmcvCox/766LrzxdwWvMnTRK Ks0ONiqZZPrxvZYvsMcO+z0iOpiGR5xBuIES0bm0hMM1ejaiijEXOiJf5eTbYG8pK4Sf HL67hgNhhqsDYUr7xrJA/JjUQp1rU7Korb8p7htAUevxHfZKQA3n0ZT+0CQm/NkRVfEz H3HFAIBoUchhztESkHQi3VeCqvDBQ4f4TwY4eLn+AVc+p0XeKTR1h6G6VSW2rCA5Z5VU kNRAdH/bmpNnIV90YYhE9K9AVO7E9bL+Khme8GzZcdVCkG1ctcrxuI9+7x3MIPvmAZ4E ZOiA== X-Forwarded-Encrypted: i=1; AHgh+Ro+9LViEgAyWRI4CeZemqBetx8AYGhN7I55H18VhhXqu5FEpS5r9miBFIcYQ0BvBl/aGtOzt8MhaHg=@lists.xenproject.org X-Gm-Message-State: AOJu0YzakfviNKMvYJ9yFG/jIp82Po3SmMhh94Xxth/sOvitq+0NsbIN 0QLaLXW199tXbuyk9oKj3QNR0iHm8ZuqGe2mSPcwOQI85rybgqL5Ak3cXIPoJP2CEr4= X-Gm-Gg: AR+sD1114PC0Jw+VRaRMKvC081/PU555AKEWInJeQkQB+lS+LUIg7dUDftrY6vuPmFa IYg4wFH8CDFR7+pHsik5pJdAOM6sFo9SDHeCuWg9Y3Pbp3iN8vr4asOcUwX43E8mmkIcObDPd5b b/nndL9G9BIYAe8XK4eB05HvjILKYVFYAuaFUAEnVmFarpaq6oO4MPLjNJWZup7nLCGCB4yPzG0 t4dQ6XobLlry6rdtp9gZ2ehGA2CEFykgLe2oSR7TQ8wQ9+s1y29cq9190cnaAOB68zNe2BHH/fC LtfOti87yvBfgZCupbUnib7JNjGUPhEokcIoJuJ9eblYYjVZA04IwyUz3JrkcHNDM3CyWHmVSf0 xf8C/JhM/zsRikGjJbpp7uVAVjiBJHTmOBPVKMtji2QS8RStr8rX7i87Yyna7vBGPvOuZvQCALW q7+oHI48AyoUThaqPt19/v+mBno/Znc3PdIdU+B2rdw8TBp++ljFOxoX2c/tf+DF4++dy5uSsuI hVK1ZObUcgwFCeh5qdnozHw19Dw87Cw/bL2YeEfj9nkw9Y+JCflD/8/uUDb/qTc427lq0vTOjgw YIZvA/xSeJCRavXh2JratB//dA== X-Received: by 2002:a17:907:da15:b0:c16:2dc0:e1ef with SMTP id a640c23a62f3a-c1fe7ee26f5mr869611266b.14.1785766268469; Mon, 03 Aug 2026 07:11:08 -0700 (PDT) Message-ID: <8b5d403c-e77a-45cb-9e3c-d6ccc8ea7a20@suse.com> Date: Mon, 3 Aug 2026 16:11:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen: privcmd: fix ioeventfd crash under PV domain To: Val Packett , Stefano Stabellini , Oleksandr Tyshchenko Cc: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev References: <20260708082934.16038-1-val@invisiblethingslab.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260708082934.16038-1-val@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1AXnnEZdKSQIDXhChQCpZZ8V" X-purgate-ID: tlsNG-d62444/1785766269-BDE78757-0F716071/0/0 X-purgate-type: clean X-purgate-size: 6791 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1AXnnEZdKSQIDXhChQCpZZ8V Content-Type: multipart/mixed; boundary="------------jjPFIGwq8ny90GlEvD0bObib"; protected-headers="v1" From: Juergen Gross To: Val Packett , Stefano Stabellini , Oleksandr Tyshchenko Cc: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev Message-ID: <8b5d403c-e77a-45cb-9e3c-d6ccc8ea7a20@suse.com> Subject: Re: [PATCH] xen: privcmd: fix ioeventfd crash under PV domain References: <20260708082934.16038-1-val@invisiblethingslab.com> In-Reply-To: <20260708082934.16038-1-val@invisiblethingslab.com> --------------jjPFIGwq8ny90GlEvD0bObib Content-Type: multipart/mixed; boundary="------------3t26jS1XeIREdEEEzFWgOEUG" --------------3t26jS1XeIREdEEEzFWgOEUG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDcuMjYgMTA6MTgsIFZhbCBQYWNrZXR0IHdyb3RlOg0KPiBTdGFydGluZyBhIHZp cnRpbyBiYWNrZW5kIGluIGEgUFYgZG9tYWluIHdvdWxkIHBhbmljIHRoZSBrZXJuZWwgaW4N Cj4gYWxsb2NfaW9yZXEsIHRyeWluZyB0byBkZXJlZmVyZW5jZSB2bWEtPnZtX3ByaXZhdGVf ZGF0YSBhcyBhIHBhZ2VzDQo+IHBvaW50ZXIgd2hlbiBpbiByZWFsaXR5IGl0IHN0YXllZCBh cyBQUklWX1ZNQV9MT0NLRUQuDQo+IA0KPiBBdm9pZCBjcmFzaGluZyBieSBoYW5kbGluZyB0 aGUgUFJJVl9WTUFfTE9DS0VEIGNhc2UgaW4gYWxsb2NfaW9yZXEuDQo+IFBWIHN1cHBvcnQg cmVxdWlyZXMgbWFwcGluZyB0aGUgdmlydGlvIGlvcmVxIHBhZ2UgZXhwbGljaXRseSBpbnRv DQo+IHRoZSBrZXJuZWwncyBwYWdlIHRhYmxlcywgc28gZG8gaXQgb24tZGVtYW5kIHdoZW4g UFJJVl9WTUFfTE9DS0VEDQo+IGlzIHNlZW4uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBWYWwg UGFja2V0dCA8dmFsQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQoNClJldmlld2VkLWJ5OiBK dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K --------------3t26jS1XeIREdEEEzFWgOEUG Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------3t26jS1XeIREdEEEzFWgOEUG-- --------------jjPFIGwq8ny90GlEvD0bObib-- --------------1AXnnEZdKSQIDXhChQCpZZ8V Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpwoXsFAwAAAAAACgkQsN6d1ii/Ey/U DAgAmd+R/wiU6Lccg8jX9tw5WrYHgjVRd99YLcspiEseAHZsU4BLHRyV8hSKHyR/ATE6m4shUuly OsgYSf32bvicsIHYOiDbJ4XGkF8w7KItltBOv9QUYImxtaT5iQ/FkC2vuGEzkbubqXPQ9glUnK3K 7Kbh2+FzdkDLPJi12zgYaUWh43Hcqs0vbx/3uYjU0Vv0TVSVoUUx+dbA4R2j7qQUK11hRY0PfpX3 8JErwCCGhoxGQrYQFSKRf/Cjjx1Ki9NGOpfGDSWmVYRnRgKFeGZG0ClYO5e4GPbRg+BeP3xCH5tQ N9AAdG7HnOPj8UGJulZGa4TGD8X6BS8/fjE+hhKd1w== =xYVH -----END PGP SIGNATURE----- --------------1AXnnEZdKSQIDXhChQCpZZ8V-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:12:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381508.1625059 (Exim 4.92) (envelope-from ) id 1wqtOi-0007ti-R8; Mon, 03 Aug 2026 14:12:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381508.1625059; Mon, 03 Aug 2026 14:12:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtOi-0007tb-OH; Mon, 03 Aug 2026 14:12:08 +0000 Received: by outflank-mailman (input) for mailman id 1381508; Mon, 03 Aug 2026 14:12:07 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtOh-0007tR-Kt for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:12:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqtOh-00F6UV-1Z for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:12:07 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70a1ab-e002-0a2a0a5209dd-0a2a450a9fe8-20 for ; Mon, 03 Aug 2026 16:12:06 +0200 Received: from [209.85.218.48] (helo=mail-ej1-f48.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70a1b6-f2d2-0a2a450a0019-d155da30b5e3-3 for ; Mon, 03 Aug 2026 16:12:06 +0200 Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-c15f020a223so518366366b.1 for ; Mon, 03 Aug 2026 07:12:06 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44542d2sm589170266b.35.2026.08.03.07.12.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 07:12:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785766326; x=1786371126; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=MS/I3nwa6tPsNEN+LIrocgCk6NLiF+ItW1O5FQY1Gfw=; b=NBugHU9fLau0W+HlgVet7pRCEz4Tu5GN9MTbCGc6wGuMBzkFZyRMWawVlep5QAUdLG fDx9/HqlZ4rJiaU1JodrPqx3FlBsH/tbGJVEjw8EBKdBCgC8/qE0dcf/ub1HAdDxPprD gv74BaXEMXmK0nTkO3y79aybqW/3vaHdkfFD7Kn0422h6z8yon19RL+ZlWE07GDpXEOS HDHM9mTDUOwR1jxsOaWS3mkD7n99Awo1oDKYnHHFjvs+sEGQUG4k9EW7aBO7VlNz6JvQ /la2xKc63a0VUBggGhP2DZ2EHYkUuNkGuIMEp84/ETfJZTqlwJEPyfNJp0+zjA3n26C1 L84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766326; x=1786371126; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MS/I3nwa6tPsNEN+LIrocgCk6NLiF+ItW1O5FQY1Gfw=; b=S/dwACj/YuvSW18qZ2bMku2GPZ9FoA5jMRw/Gmv9TaO6Y7wa2gv2MzuAqCDEKGty9v MgSHUxnG6lAURNd4uU15kcL3jKuWW5nARrrBkY0FjlHN8B+lP1gQyMXxLuh1cvoaiHxZ cMJDz+dHZl842TAyxr4EksqDCoWwDUWx4HFJkckmW+NiPw3mfi/jpEMSq6/GedGyOzot XPGfMANUG4hUbGRY5XNB5E/XJPsveqr+DwbJsQnSzXuf5yoBrDk1Lijn08hxzRiFOJFG sKGOD860L5GY91nZWTlvNW0zVvZdFiJc4qeF0qt91I8glVoVj+WW6ORniZ8vquMqsFLc ec/A== X-Forwarded-Encrypted: i=1; AHgh+RqAWSgD8mbrZkaeVtiZkApcvosTw4Ux1fbnq9lvDYD8hlUy1ssoMGMXk4ycIZ7XrnS4bxFSBZV2j9s=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy56miseFDdeuxcqoppfMmJm5ztb3AZ7lSU5jDzuo3pW0JUKCDV cOTT1O96wdWb2iLIsf5s5BSB8foKS3JCBxvs3Tmvlc6M8sA8pSDdvzUVhjrUT/olYqQ= X-Gm-Gg: AR+sD13y7LVrDBIUs293mVr0um3WFrJdle4Qap+Iss+EoeO9zKjLWtEi6xgVdgJhytf jYzDpJBkqEZ3NJGKdqLLVJItUJDzZPTEUZxsNdYzgddNcvlINlWjrJZyGFk/fkWIJp12wy43mGI x68yXdEmKQbtXaoLzJfmrLN6kctsLsJCgp6ia+5DDx2kBXeTg27lhbnh7ebcDEJZXdAaFKU1LRw sWopoJIk60qlV0+23n+/rhIHg9IZXn13VF/7Px0K5ijfjNt1nciGU2e+kYTbBaJiGWPTxckBfWV Rxj/vQDbSd/x8cpx4wulqHXIN+tD1XqivZ20wTiY7pUaDLmNZJUgCrF/dvZS847N1Wx46HktCLh smhz4kLYsxrzt9IcJzVkWwWAKqB3zVGx/6A5zYso7sjPepSe9n43RnFH7A9/6wLdqa6/Q/mfM8H lI1Q/0cr6BORIeB+J7EARukMKX3wbpOCS6iPUNdC5NRCYWKuLQEy9oj9og/kgrZ0PGGnsZVUp3Q +2tcrgGU3KiykiSqGhZ2wEE4XnVycvTHuQwUcEr1ca8lmRrQCTO1Ej29fIRcKXSrzPt/Xj2fsHU zzkGTn3b6Wv2bzE= X-Received: by 2002:a17:907:d28:b0:c20:1bc5:7002 with SMTP id a640c23a62f3a-c201bc577a6mr147988666b.3.1785766325454; Mon, 03 Aug 2026 07:12:05 -0700 (PDT) Message-ID: <2d4b7ec8-7900-433a-a3b4-a5b043e55ca8@suse.com> Date: Mon, 3 Aug 2026 16:12:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/xen: fix init of balloon stats for PV guests with memory != maxmem To: Roger Pau Monne , Roger Pau Monne , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Yannick Martin , Thorsten Leemhuis , Stefano Stabellini , Oleksandr Tyshchenko References: <20260730143548.39320-1-roger@xenproject.org> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260730143548.39320-1-roger@xenproject.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------102FQPugHI0qaeHSeczrm1XT" X-purgate-ID: tlsNG-4011c0/1785766326-518C5CFC-65CB5895/0/0 X-purgate-type: clean X-purgate-size: 7035 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------102FQPugHI0qaeHSeczrm1XT Content-Type: multipart/mixed; boundary="------------JqWSU2jrs0iCl3o7E0OAmZf5"; protected-headers="v1" From: Juergen Gross To: Roger Pau Monne , Roger Pau Monne , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Yannick Martin , Thorsten Leemhuis , Stefano Stabellini , Oleksandr Tyshchenko Message-ID: <2d4b7ec8-7900-433a-a3b4-a5b043e55ca8@suse.com> Subject: Re: [PATCH] x86/xen: fix init of balloon stats for PV guests with memory != maxmem References: <20260730143548.39320-1-roger@xenproject.org> In-Reply-To: <20260730143548.39320-1-roger@xenproject.org> --------------JqWSU2jrs0iCl3o7E0OAmZf5 Content-Type: multipart/mixed; boundary="------------wDZ9xUzZMQeFCoQUHq4De83r" --------------wDZ9xUzZMQeFCoQUHq4De83r Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMDcuMjYgMTY6MzUsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4gVGhlIGhhbmRs aW5nIG9mIGV4dHJhIG1lbW9yeSByZWdpb25zIGRvbmUgaW4gYmFsbG9vbl9hZGRfcmVnaW9u cygpIGlzIG5vdA0KPiBjb3JyZWN0IGZvciBQViBndWVzdHMsIHNpbmNlIHRoZSBpbml0aWFs IHRhcmdldCBpcyBzZXQgdG8gcmVmbGVjdCB0aGUgcmVhbA0KPiBtZW1vcnkgdGhlIHN5c3Rl bSBoYXMsIG5vdCB3aGF0J3MgZGVzY3JpYmVkIG9uIHRoZSBtZW1vcnkgbWFwLCB3aGljaCBj YW4gYmUNCj4gaGlnaGVyIGlmIG1lbW9yeSAhPSBtYXhtZW0uDQo+IA0KPiBJbnRyb2R1Y2Ug c2VwYXJhdGUgbG9naWMgZm9yIFBWIHZzIEhWTSBpbiBiYWxsb29uX2FkZF9yZWdpb25zKCkg YW5kIGhhbmRsZQ0KPiB0aGUgZXh0cmEgcmVnaW9uIGNvcnJlY3RseSBieSBhZGRpbmcgdGhl bSB0byB0aGUgdG90YWwgYW1vdW50IG9mIHBhZ2VzLA0KPiBpbnN0ZWFkIG9mIHN1YnRyYWN0 aW5nIGZyb20gdGhlIGN1cnJlbnQgYW5kIHRhcmdldCBwYWdlcyBhbW91bnRzLg0KPiANCj4g Rml4ZXM6IDg3YWY2MzM2ODljZSAoIng4Ni94ZW46IGZpeCBiYWxsb29uIHRhcmdldCBpbml0 aWFsaXphdGlvbiBmb3IgUFZIIGRvbTAiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUg TW9ubsOpIDxyb2dlckB4ZW5wcm9qZWN0Lm9yZz4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo= --------------wDZ9xUzZMQeFCoQUHq4De83r Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------wDZ9xUzZMQeFCoQUHq4De83r-- --------------JqWSU2jrs0iCl3o7E0OAmZf5-- --------------102FQPugHI0qaeHSeczrm1XT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpwobQFAwAAAAAACgkQsN6d1ii/Ey9J Bgf9HymnFMUKn+2bsmwaBf5rACLUjwPLhafp6AAAf7Qw6kTOJcJpM6xq0xqTcvHevmuXlXsGC09c 3/RvrZQD4dLA1yzEx5sueDYxhhcRl7H4cm2R+jVw+QJzmtc+5Nu+KlK4bhcBED/+wuYxiuGofABq s9zCbpVKlh0lhd1jPE8bTts7AXJ2y3gVyURfJud7xHe0OiI+Cz19TypkzEoIr/0FkgJtOABVFmQ8 oLBLsVFijdd2EW4vLC97sXkffzv6VXsTfGZKonC5dlcI378QvCbjRyMyikTzd5eZJDHhBmLYVruh O3KAw+pZ8dbAET5Q0hqCMFePMYSQJSfowAYAIBO8Yw== =HiJW -----END PGP SIGNATURE----- --------------102FQPugHI0qaeHSeczrm1XT-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:16:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:16:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381516.1625067 (Exim 4.92) (envelope-from ) id 1wqtSv-0008VG-Ac; Mon, 03 Aug 2026 14:16:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381516.1625067; Mon, 03 Aug 2026 14:16:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtSv-0008V9-7W; Mon, 03 Aug 2026 14:16:29 +0000 Received: by outflank-mailman (input) for mailman id 1381516; Mon, 03 Aug 2026 14:16:27 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtSt-0008V3-Ft for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:16:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqtSs-000Vfj-Ft for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:16:26 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70a2ab-5cb7-0a2a0a5109dd-0a2a450bce52-36 for ; Mon, 03 Aug 2026 16:16:26 +0200 Received: from [209.85.208.52] (helo=mail-ed1-f52.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70a2ba-b7e8-0a2a450b0019-d155d034d556-3 for ; Mon, 03 Aug 2026 16:16:26 +0200 Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6984169c126so5837989a12.1 for ; Mon, 03 Aug 2026 07:16:26 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd455ab7dsm554385966b.58.2026.08.03.07.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 07:16:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785766586; x=1786371386; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=9zmKpIRJOfwxhVT7o5SfsschrPF9Vp2UNHR3Vo7J7+8=; b=G29KKn78HpxbUgJFLcTuU/G9ezHarDKKGzPoZ2GGXzTa2c1AA+pIBPbf5P6X4e6hr1 VfaphAP0Az8ah/pWfebawQ1DUQ9jCvg9j7kMa/WiPTi+t9ktHX19UDJLxksPf/ETAQhx BfxvJooVgCx1QYSkldMxKd1+i2c8PD9cc3MG7ZwLGPcd2oOIJ/ke5R+wc7m1FuCV6pyQ ZlJ0u4vOj5JJqPXjgI+XplRunvjZkWjP57IPpIc/xeZgMo5opzgM0/GXPgW5h2eH0yTL 0tt8oeFDwvErgXgji8DniGc3WUkWxs5fBBo4JnYVh34gGNQxApoPaOyBjBR8axEA6AgU SV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766586; x=1786371386; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9zmKpIRJOfwxhVT7o5SfsschrPF9Vp2UNHR3Vo7J7+8=; b=dQgnvOV2FfOBU2XySuH7WnY9wjsxEV6okKq+dTBs6f+bQecwjXTD5YWy4QPE2U0IDy Kvy9A8ea2xyoQ6ilToR0ngG3tTwGsz3854PTW9OCjRFoD6Cnmw9D+4ichE5ffm5TsgGr Wpxy3P53Ol25IgpCHnpNT+2k13XylxhKGK1dur0kY0FbFeh0gQv/cUu1iBuk/qHdx6XN SZCX305UuWoDCKi+B7JiLfRM2WY9+FHxw1822nMsru1bt70FYsYD23uqImw26Kx1rFf6 lKa4n75OaKzViIaxJNSoh9cBILm4v3kEJA7074m9RwkDlEbVzynbQdCVor4RkFfyCJju U2/Q== X-Forwarded-Encrypted: i=1; AHgh+Roydl6Jkt1QmKb2O2TqKNATIAvqnuqZwui2jXXMFpuC5va86jXGuxMdJud7qKZLX8BAZoup4eazd0U=@lists.xenproject.org X-Gm-Message-State: AOJu0Yyb/JlisrugPBJ/Y5E6JNYiaptP5MT5xE6pzWMgPYVBHzo2vr/L 6De6zYc5clJn2sQZr1dwAGC7xP1Px/yUSuBgTzT4adm1bPl/Fj+CrhyaKba1o3N7fEY= X-Gm-Gg: AR+sD13VZqLcbt4JTJo0VQsolFhK+6nzYGsCdrMdgXuo6mcrCult9z+p68gvg9Yl0kK AMcs8o765zDG5ZuCNz69pmY3EDZExrejNZCTdN0yOOIY23Z7/c3t0VmNHY9yReVwiqKR5cTmqzC xHcXPTUbEkey4jCEuLoVZHhcG63uHexO0Qb2S8QlRuIipYuT/x3ongo7wotmcJm8zdRll1lbXpn /jHhdD31TuW7tBgEZtH2x76Ub5QRgpJabLunJCC3n/GcPbu1/Xkhn2kcsY/sahnp7toFY7vWQ/a Qd8QFDlJhCoIcSHRNt1+gD9lMY9Aa5ykqx1rKhfETuPIPyobkpiLPH6mhzWL2PkVz+AaQxBi0Sf whHhzB07mMIlUQe3fKBf96ZCslIed67SGvcL0m58NffsQfzC77hmi0WwjtN//d5G9BXPCRCkRR2 OqujY2PVCITGhxkQQRHPLjp07WbWIeSZMrfDCELyIro6DW39l57EJV8BgVx2bK1xG7CkXSIa9Ma VU5yGmkzf6li0uUbvDeY7fIYB/lysvg5ZxwrtOuY90HENm6fr1zZZ0seJJCxALszIx3ICi52f/y kT4IpCXBkU/KdGs= X-Received: by 2002:a17:907:db01:b0:c15:cfb4:6a6 with SMTP id a640c23a62f3a-c1fe816c171mr848842166b.30.1785766585905; Mon, 03 Aug 2026 07:16:25 -0700 (PDT) Message-ID: <862428ae-e706-4300-9eff-d55db42e841b@suse.com> Date: Mon, 3 Aug 2026 16:16:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] xen/xenbus: log more information when device state got reset To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Jason Andryuk , "Martin K. Petersen" , Jakub Kicinski , "moderated list:XEN HYPERVISOR INTERFACE" References: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4RlqZjK6tRdeNjWmWmqFkmOH" X-purgate-ID: tlsNG-42698a/1785766586-18CCF9EA-48D2CD05/0/0 X-purgate-type: clean X-purgate-size: 6452 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4RlqZjK6tRdeNjWmWmqFkmOH Content-Type: multipart/mixed; boundary="------------M8zyK6hx8ej1F0xDZaNfD0nJ"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Jason Andryuk , "Martin K. Petersen" , Jakub Kicinski , "moderated list:XEN HYPERVISOR INTERFACE" Message-ID: <862428ae-e706-4300-9eff-d55db42e841b@suse.com> Subject: Re: [PATCH 1/2] xen/xenbus: log more information when device state got reset References: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> In-Reply-To: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> --------------M8zyK6hx8ej1F0xDZaNfD0nJ Content-Type: multipart/mixed; boundary="------------1FvQFrZLlUfEjHgTmLcxY5wr" --------------1FvQFrZLlUfEjHgTmLcxY5wr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjYgMDU6MDgsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN Cj4gRWFzZSBkaWFnbm9zaW5nIHdoYXQgYWN0dWFsbHkgY2hhbmdlZC4NCj4gDQo+IFNpZ25l ZC1vZmYtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFyZWtAaW52aXNp YmxldGhpbmdzbGFiLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo= --------------1FvQFrZLlUfEjHgTmLcxY5wr Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------1FvQFrZLlUfEjHgTmLcxY5wr-- --------------M8zyK6hx8ej1F0xDZaNfD0nJ-- --------------4RlqZjK6tRdeNjWmWmqFkmOH Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpworkFAwAAAAAACgkQsN6d1ii/Ey9s Kgf/V4G7MjXBhRqRA7cRQIYPI151zhTJOQc1Q7MZzibRI5Nb6tN+diWzCGnEoCXOJ9fHUKppBtzt w9BgEYrmWtMRG+jM1itBKMdC83vOX5ik0WJumFNlntYHBNV55D2aQSwNt6xpq4XfKcEafYjvQi2a cNuxv5ex8NK8/9UFpifeOAFqouarh02Qf95WmXX7JcsHKUUpcI/LHXqfoK6Y9BS5gieTFTAp3a8P sy2cZG/soaRTkQ9junw5Z3Yl7aOPITi+zE1xDK/r1afxEwCmUHx+zPv3C0DyjP0z/kRsZ4YV2GD9 xn9lQ68FslYXfponE8FIKuAk27Mo8FC5xUDXq5T/Xg== =vh3K -----END PGP SIGNATURE----- --------------4RlqZjK6tRdeNjWmWmqFkmOH-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:16:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381521.1625076 (Exim 4.92) (envelope-from ) id 1wqtTL-0000RV-H6; Mon, 03 Aug 2026 14:16:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381521.1625076; Mon, 03 Aug 2026 14:16:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtTL-0000RO-ED; Mon, 03 Aug 2026 14:16:55 +0000 Received: by outflank-mailman (input) for mailman id 1381521; Mon, 03 Aug 2026 14:16:54 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtTJ-0000R3-Sj for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:16:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqtTI-005cGg-TQ for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:16:52 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70a2c5-2eae-0a2a0a5409dd-0a2a4507bab2-44 for ; Mon, 03 Aug 2026 16:16:52 +0200 Received: from [209.85.218.44] (helo=mail-ej1-f44.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70a2d4-b4ea-0a2a45070019-d155da2ced76-3 for ; Mon, 03 Aug 2026 16:16:52 +0200 Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c15cf78d1a2so407034366b.1 for ; Mon, 03 Aug 2026 07:16:52 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd4454321sm537745666b.31.2026.08.03.07.16.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 07:16:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785766612; x=1786371412; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=2tPYjDuAYCYdNaJq4I9qGJyfSrpnRvk91bWPEkVR1nk=; b=EDgd2SrWvzhq8buZhuYuzrEiEmbwfvaWd2Zq0jIzm8nFrMd5/YJsB52bUoqbwXacuU 0aWXppOqzq8nSbDF6ZrVvWkfnAkkonh2Arj+Xd/mj8dp48DTFlNHi0GbCSgiY/FrSI6L ATMxmgOAgES8H9JapvlKAyb/TCkdOeAQdGCi1w8abU0732iPT3jrAV4hI5hxzOG12Be9 bO0bz7gfyP9f78VOWZkzTZj7uGBWVDx7F9yVVg8otAUV3nP6/fPK3daA9HAEQPti8p+O 4e1iJQGO5nf08he24e7EL8ndlQ3AuOYXn/gCqOvtmJxMW74saUmTIuoU3fp9PAEjvpC2 KB1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766612; x=1786371412; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2tPYjDuAYCYdNaJq4I9qGJyfSrpnRvk91bWPEkVR1nk=; b=E4zKDGrJA/8BFMyE1eg1gdp35ExkwQUyUsAqKXCQTyJ+2UTopF7Q9MnZhTbq7Lyhac 8XhYDVlc3bv0sAhW5jOZ1UMrEmuypbTZSkfuwrf96MU7M2tVmETd2bNemHKjxL/djJwf bXLuqXXB5zdJRh5mIl3z2u7Dz7s+nwkf52qkT4Z8kxVmpVDNyQjbd5LL9Je0WiAGQnVa T5WSQ9tihXVGzi5GG67JSWOM8O+aThKzBHzmx2vtwteEI4SLamNzobfGc1bHPYYv5MeW wEln+TCrF4/0q8exMOarWDDE+k3xyLTwyF767iN+I/sFCuCiKROsyFrbF8+4edsZsZ9L PDQg== X-Forwarded-Encrypted: i=1; AHgh+RoHKdWNxQvacuQIIRdciCeNDjzD2pUO05PKfJxetdGFC9UwqrEAGxyKUa2kO1dJOAYpj98K5JTKCUA=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzup9LZT27UezuhOacVFG5AgxMcxw/XcUD4K1ZYmGcDQTZrGuzO EC/MSlS6IlhtSk2Ku1YXTzb483YF2vJ7W05ltte7R29E6dS/tXgsCmQCfzaOF9MTFMY= X-Gm-Gg: AR+sD12wAS/tPVRG0vqcqwR+8i5q8CN3jfuJMGSIOJFwOP810OaGRInKhPKSzZKw6ud psjBlHThcYs3ajvSm0t3NGzFYHJYH5HqwZ2skSAXD9Sot9QMhXb2ACKZ+ZnJKf94iKyz5i5U/4E R+tlaTBbo80+uK0HDiSsKALfKpnaNjJlFVAeLyCdcOJ9RYp1hh2sKbYlI5paemuGrRT/jO5ZUvR eoQ7r6PSjd1FI4EvhgbUNYn7AGZNRzzRThqnc9QIM3MUh/DEWnkFBVH+RJpC4Ff6lXolSXSrHRG Nr81SnGAoOcoqkVO7jSGNDX2HXhvKfEXMXmB1CliIpBpnN29vQO1UxilC0gxfQ7g1/WyT1iVXhP rI6qVd5eeq/kaW1qkZIOwCaRDgAMCrGStmWuNH4eGkThV7j+HsegPQ+vD4zjZb7sYkVAKw7jmIC wmvbSF9QGGlU3RvsTtEqalVrG1HTHqh35KCiQl3Qn7iTaGrv7KvVUvaiubDQqpoldA2PQv1P8PT FOxz4wLvZP/clgtHuBtIHCr3AswssiNWqzOvGGbYPJLfOOz/SNqeQzjfoahEDHGXTyPOqEZGEZj kS+AuED4svNHa5A= X-Received: by 2002:a17:907:3e24:b0:c16:1a00:3feb with SMTP id a640c23a62f3a-c1fe7eec66dmr989728066b.15.1785766612172; Mon, 03 Aug 2026 07:16:52 -0700 (PDT) Message-ID: <68379ceb-85a7-4d86-aa05-00766b4d6da3@suse.com> Date: Mon, 3 Aug 2026 16:16:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] xen/xenbus: check otherend_id only after it has been initialized To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Jakub Kicinski , Bjorn Helgaas , Jason Andryuk , "moderated list:XEN HYPERVISOR INTERFACE" References: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> <20260803030822.4104093-2-marmarek@invisiblethingslab.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260803030822.4104093-2-marmarek@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Np676FD9hdO4V5vtfRruHXLO" X-purgate-ID: tlsNG-ef75cf/1785766612-A66DAAE4-D371476D/0/0 X-purgate-type: clean X-purgate-size: 7591 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Np676FD9hdO4V5vtfRruHXLO Content-Type: multipart/mixed; boundary="------------HYR8tqeqAMQWvqblcxL6iSaN"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Jakub Kicinski , Bjorn Helgaas , Jason Andryuk , "moderated list:XEN HYPERVISOR INTERFACE" Message-ID: <68379ceb-85a7-4d86-aa05-00766b4d6da3@suse.com> Subject: Re: [PATCH 2/2] xen/xenbus: check otherend_id only after it has been initialized References: <20260803030822.4104093-1-marmarek@invisiblethingslab.com> <20260803030822.4104093-2-marmarek@invisiblethingslab.com> In-Reply-To: <20260803030822.4104093-2-marmarek@invisiblethingslab.com> --------------HYR8tqeqAMQWvqblcxL6iSaN Content-Type: multipart/mixed; boundary="------------xBoTws2zYZvW03IxmXVfJFNO" --------------xBoTws2zYZvW03IxmXVfJFNO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjYgMDU6MDgsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN Cj4gV2hlbiBkZXZpY2UganVzdCBnb3QgaW5pdGlhbGl6ZWQgKGZvciBleGFtcGxlIG9uIG1v ZHVsZSBsb2FkKSwgdGhlDQo+IG90aGVyZW5kX2lkIGZpZWxkIGlzIGluaXRpYWxpemVkIG9u bHkgYWZ0ZXINCj4geGVuYnVzX3JlYWRfb3RoZXJlbmRfZGV0YWlscygpIGdldHMgY2FsbGVk LiBJZiB4ZW5zdG9yZSB3YXRjaCB0cmlnZ2Vycw0KPiB4ZW5idXNfZGV2X2NoYW5nZWQoKSBi ZWZvcmUgdGhhdCwgaXQgbWlnaHQgY29uc2lkZXIgc3RpbGwgemVyb2VkDQo+IG90aGVyZW5k X2lkIGZpZWxkIChub3QgbWF0Y2hpbmcgYWN0dWFsIHhlbnN0b3JlIGNvbnRlbnQpIGFzIGEg c2lnbiBvZg0KPiBkZXZpY2Ugc3RhdGUgcmVzZXQuIEl0IGNhbiBoYXBwZW4gYmVjYXVzZSB4 ZW5zdG9yZSB3YXRjaCBhcmUgaGFuZGxlZCBpbg0KPiBhbm90aGVyIHRocmVhZCAoeGVud2F0 Y2gpLCB3aGljaCBjYW4gcnVuIGluIHBhcmFsbGVsIHRvIHRoZSBpbml0aWFsDQo+IGRldmlj ZSBwcm9iZSBydW5uaW5nIGF0IG1vZHVsZSBsb2FkLiBJbiB0aGF0IGNhc2UsIGl0IHdvdWxk IGNhbGwNCj4gZGV2aWNlX3VucmVnaXN0ZXIoKSwgd2hpY2ggd291bGQgZGVhZGxvY2sgYWdh aW5zdCBkZXZpY2UgcHJvYmUgZnJvbQ0KPiBtb2R1bGUgaW5pdC4NCj4gDQo+IEZpeCB0aGlz IGJ5IGNvbnNpZGVyaW5nIGRldi0+b3RoZXJlbmRfaWQgY2hhbmdlIG9ubHkgYWZ0ZXIgZGV2 LT5vdGhlcmVuZA0KPiBpcyBzZXQgKHdoaWNoIGhhcHBlbiBhZnRlciBvdGhlcmVuZF9pZCBp cyBpbml0aWFsaXplZCkuDQo+IA0KPiBGaXhlczogZTJkY2Y5MDY1NTM2ICJ4ZW4veGVuYnVz OiBiZXR0ZXIgaGFuZGxlIGJhY2tlbmQgY3Jhc2giDQo+IFNpZ25lZC1vZmYtYnk6IE1hcmVr IE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNv bT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0K DQpKdWVyZ2VuDQo= --------------xBoTws2zYZvW03IxmXVfJFNO Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------xBoTws2zYZvW03IxmXVfJFNO-- --------------HYR8tqeqAMQWvqblcxL6iSaN-- --------------Np676FD9hdO4V5vtfRruHXLO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpwotMFAwAAAAAACgkQsN6d1ii/Ey// HggAmKerqd0ZKg0S7g5eb6J9TTXeuOhucdi85EdBRUmVgzfUGSpehy8fMSuix01V9s4AWmbFwBu0 Wjs5pu2Z1W2J6m5kduTsNqU7S5hQ8Hkpuk5obLb18yg6o4aMR4ZzC1dlHV0uWmmfLr6yoEssvY7K P5Fp5Cys4xAi0Q6gi0MCC/9gkbDR4Ykm4vmN1Tl2E4PCe+WbPwogtjIj9LunF0sk1AsOOXduqhFW tqz2B1cwu+u/qhQRgwR+qXenip25ScMAtl9nZKNqo/BZwHRCbnf4dP+2cvi0dd6FUXaQn69F/slW v4DBcz9e9wBxykk4gQRmzZcsffCcyrwdl25tSduAlw== =Gvk9 -----END PGP SIGNATURE----- --------------Np676FD9hdO4V5vtfRruHXLO-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:23:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:23:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381532.1625085 (Exim 4.92) (envelope-from ) id 1wqta0-0002yd-9K; Mon, 03 Aug 2026 14:23:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381532.1625085; Mon, 03 Aug 2026 14:23:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqta0-0002yW-6K; Mon, 03 Aug 2026 14:23:48 +0000 Received: by outflank-mailman (input) for mailman id 1381532; Mon, 03 Aug 2026 14:23:46 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqtZy-0002yQ-P7 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:23:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqtZy-008Lpw-0e for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:23:46 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70a471-e002-0a2a0a5209dd-0a2a4508c968-0 for ; Mon, 03 Aug 2026 16:23:45 +0200 Received: from [74.125.224.52] (helo=mail-yx1-f52.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70a470-f659-0a2a45080019-4a7de034a98b-3 for ; Mon, 03 Aug 2026 16:23:45 +0200 Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-664e3ed58bcso5999374d50.1 for ; Mon, 03 Aug 2026 07:23:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1785767024; cv=none; d=google.com; s=arc-20260327; b=qUgfs/2xcuc0cfk1lvM/KQlm+bowFUjBSiFvMt74wYIpCRUiQZiNthI6OlRbtdFPjh J7AmKf+MwiQvyXwd3ktWF4CuEgQB8k03W32FyQMVY6GEOG3tWWT/KIhrA9x8B0rNEDjt tObewF0j42Tu9dt3DElY09zBfFLZ9JV6vzUhQ1rY6IFDVdgTHabqkWl+We89m4KjslS1 eB68oACSbiSK5FhYBjItZTaqYQh2/cKYny+ZjzynzAsPY74/q1VajhEU3cPK+UMhkFCq XNAWyXG7e1OzK/lOABLQZWuvm6q9wcMvj5X76L859TUJwYBtpXZwllJrbUHle64LOloj RBiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=wJiMbpzbgvUxnGJ9663a2S4Y/6f0ltDGF8OXt0DNfUo=; fh=5u7kHD1b/hNtHHJofCBl7jWiqXiR32ui2YCHFqJNZUo=; b=hTPn/K9KCAfKPpXLlfaaOjpJ3Ctps0Fk1s42Lm3Unt2ZHHMJQTDWAV2LfGZrcYV7mF VBImqNmYAzZmB/4RWOdwgcVGji3Hqxj7XN9HRhPgspZjiowRnjB09BicZvVL5nKIu+ix amItkki+1rrSkkI4+sq504Te8gsksS4YD3f8ZLpH0hnmx+H7kYaWYijLOD27u3W1piSN mWcCc6NFzfped0Bbj7fVrHfdeExbwbdWgqiLYuKL8A6umqNBGsha2hxsG/+uVt5byXzj zJQkwgTsBdMlgn+gOmOVOzIVLpPf2/Pyt6iG4x5fyHDsZW0ToD5M+T+I7VQzOh8gT8tE 5rCw==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785767024; x=1786371824; darn=lists.xenproject.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wJiMbpzbgvUxnGJ9663a2S4Y/6f0ltDGF8OXt0DNfUo=; b=aKDIFLikEEU2Z3SXKAP059KDA9JCtI0RNdzpcsqmnkElrwe6eKDx5QKpbVV0AYEeXv UfHWojekrSMwbwwo8UPjEj/b970kvK/AsjY97ImRPm1adBNzT02NYVsslxJgVLXfqzjx ClZx4pOW1SV7AIU+5Z6xxZPa3njzw9RYjzr2g7nTMNCPry7CoH4xm4XDrFHaZb+kYLaM UmEBFEPwijgUrCiFT6Mo47Kfaut+Bw8hZEpNilA7mr4awr/elAKqNM0T7k+cu5K7wym6 7VpZ6Ywd6ogyManzO0PT8SgdO+1oob6hduZ4NTPQXspxghh0dft8NbwqXyiE/XA4VmgP RjEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785767024; x=1786371824; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=wJiMbpzbgvUxnGJ9663a2S4Y/6f0ltDGF8OXt0DNfUo=; b=ZSrTt5ZjUsGYgHbdpZHWMvSW+jojiFjUIBeIhIVFsp2soBl9Ttjx8Y1ANFffuNucCj tu0D1Jtjq03OR2ccXrZli8n4rkfaCZKB4YprBbAo8AY6gP7eqhWtrh48qjdj4FM8NavS zIVrx+g/aNGyI2Ig4jfth8t1kAaaZkBmCUwaBTaUv9H+nLERIQbdKKCZSGTzXSX+DOth 9iPMQRkm3GtwbEwolEoPfDA/bxB1xkJbwYou3AcFGD2DfaRoA+QgOAea/SVffR/zMYXH 3c1ONMeUHkIF0Hx9udRPVzxOyMeiBUnowWQLyDntm41/bzgl0rYHhbejBFbnd/ammlIp JkBw== X-Gm-Message-State: AOJu0YwSMtqBa3Kpvs1VVW8GyHUZ+vQHJfIxurRqFABBtcOT+BZyZGtq +2mPfDfjrOhx8vgvEw7hNfDPoBERjAhs3bbhkmAytrdusbbYmqRmngTN9flDekLGGixrgndg9C7 82gvoGe27sm6m2QRKjf49AC/Rpp8gQTCirTvuio8= X-Gm-Gg: AR+sD12DWmm08ldELLKSfRdBxXmJwXaWk6mq16wUyUHlkbZv8jPZVmTlFEtD+Jsgjju nGVWKOtYaYsjlrVZ7xvXU7q1ft20UPFYpDws/gff5pH7Ft38n9gd4LtqF5MPVewkMaxDbW/7rDp V0Vl9OMaXC35JSkuLXiCFE/Tqf2mXMBPJAG/L0FKHEH9AeI23fFxwmqfmvWZdo4QSnsiSo122Xx MLSEm6hAnrtikRsJqgSjV5zxo6YMx2906jWcRtn9Fz1tKGU/MiwAreZPZ+taD2/UOca6nyuRMkF 2QdOZfGoAFrsQELPQW9t5tsidkbMRtTrx3WErlpoyUpqyO9wzpITDHxEXhHwNI+qxNKWQCUwmHn u X-Received: by 2002:a05:690e:2506:20b0:665:2045:fe47 with SMTP id 956f58d0204a3-66945bea125mr10911877d50.7.1785767024406; Mon, 03 Aug 2026 07:23:44 -0700 (PDT) MIME-Version: 1.0 References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-17-frediano.ziglio@citrix.com> <439c2740-fb84-42cb-b001-cb290684a583@suse.com> In-Reply-To: <439c2740-fb84-42cb-b001-cb290684a583@suse.com> From: Frediano Ziglio Date: Mon, 3 Aug 2026 15:23:33 +0100 X-Gm-Features: AUfX_mz0p6FBcsbJBhjjFHmdqxj5qR1izMtTAZfJP_Yflmxkjgdnunb1POk8ZYU Message-ID: Subject: Re: [PATCH Linux v6 16/16] xen/privcmd: Add new ABI to allow copying foreign memory To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c1860d/1785767025-D5D4887B-6A09A46B/0/0 X-purgate-type: clean X-purgate-size: 2065 On Mon, 3 Aug 2026 at 15:05, Juergen Gross wrote: > > On 19.06.26 15:05, Frediano Ziglio wrote: > > This new ABI allows to copy foreign domain memory to/from a buffer. > > This avoids having to map/copy/unmap foreign memory which is > > expensive. > > This operation is done particularly when migrating VMs. > > > > Signed-off-by: Frediano Ziglio > > While doing a test build I got the following build failures for 32-bit arm: > > CC arch/arm/xen/enlighten.o > In file included from /home/gross/korg/src/arch/arm/include/asm/xen/interface.h:1, > from /home/gross/korg/src/include/xen/interface/xen.h:13, > from /home/gross/korg/src/include/xen/xen.h:52, > from /home/gross/korg/src/arch/arm/xen/enlighten.c:2: > /home/gross/korg/src/include/xen/arm/interface.h:22:35: error: unknown type name > '__guest_handle_uint8_t' > 22 | #define GUEST_HANDLE(name) __guest_handle_ ## name > | ^~~~~~~~~~~~~~~ > /home/gross/korg/src/include/xen/interface/memory.h:361:5: note: in expansion of > macro 'GUEST_HANDLE' > 361 | GUEST_HANDLE(uint8_t) buffer; > | ^~~~~~~~~~~~ > make[5]: *** [/home/gross/korg/src/scripts/Makefile.build:289: > arch/arm/xen/enlighten.o] Error 1 > make[4]: *** [/home/gross/korg/src/scripts/Makefile.build:549: arch/arm/xen] Error 2 > make[3]: *** [/home/gross/korg/src/scripts/Makefile.build:549: arch/arm] Error 2 > > > Please fix those. > > > Juergen Mumble... I suppose this would fix it diff --git a/include/xen/arm/interface.h b/include/xen/arm/interface.h index c3eada2642aa..7e79853b188d 100644 --- a/include/xen/arm/interface.h +++ b/include/xen/arm/interface.h @@ -53,6 +53,7 @@ DEFINE_GUEST_HANDLE(int); DEFINE_GUEST_HANDLE(void); DEFINE_GUEST_HANDLE(uint64_t); DEFINE_GUEST_HANDLE(uint32_t); +DEFINE_GUEST_HANDLE(uint8_t); DEFINE_GUEST_HANDLE(xen_pfn_t); DEFINE_GUEST_HANDLE(xen_ulong_t); Frediano From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:52:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:52:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381549.1625101 (Exim 4.92) (envelope-from ) id 1wqu19-0001TE-Ee; Mon, 03 Aug 2026 14:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381549.1625101; Mon, 03 Aug 2026 14:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqu19-0001T7-B9; Mon, 03 Aug 2026 14:51:51 +0000 Received: by outflank-mailman (input) for mailman id 1381549; Mon, 03 Aug 2026 14:51:49 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqu17-0001Si-MV for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:51:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqu16-005i0I-E9 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:51:48 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70aaea-e002-0a2a0a5209dd-0a2a4503e5a6-42 for ; Mon, 03 Aug 2026 16:51:48 +0200 Received: from [74.125.224.44] (helo=mail-yx1-f44.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70ab03-fae8-0a2a45030019-4a7de02cd8fb-3 for ; Mon, 03 Aug 2026 16:51:48 +0200 Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-668c1b780e5so5314004d50.2 for ; Mon, 03 Aug 2026 07:51:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1785768707; cv=none; d=google.com; s=arc-20260327; b=e0td3MPQbXv/HxNE6lcBu/VK6RXHrwrLYuQ9fkQjIjYvktd9UP8S48TSjWfVp6GR0E hD9PasHOvFMEqLl9BQxCC/X7eOlcrlIIzqjZMbkn+aG68V7IgXS2Uf5p7N61z2pHx5wS F3myns0I+o8LTOp9T3BjlZpuXT4rQ4bQhr5v1d6W6IlAOTUWDG0v+ef61o0ktaZ52k52 n7dlCwoX1MHdyCmY+ijfzX5fIUa693A9BHnUNpXjcu64cf5Twt4ISiLDPAtHsCKu0EqZ E+NfRlM9nl0WSUSt4uSiPHmf5Nrz+u0CSr9GI3Oqef8pwovp7jxugOpLjanGFJsx4gI4 aJfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=D9ggXvuJw0OfV/7DwKJBrE2gM6POgD68kCOokV6rNFg=; fh=wWTf0SxaJts9rmPnRaimTcgF13vS7beuyeD2+6KhZkk=; b=RTgI8l67HilPsDjihHeO69y/3NEc4fwBC5lkIf0sLdVgxMWxsfuBLNRUa6XIRfLXq4 sCCHjJMGZHSAtPwZdpXbt393je1JVvL1ommbkGIVwo0Vhfsv7MFL1yeq7Ki1FFRwmTkH +dL73V+2lNHQyYPyb7BTYXaPnkDLSrb5+QAZ8QtdJUnOTpbEDKZlDwMbxCWLJqOWi43w QvPlxAw1f95P9Cf03wAFpMf4ILbtrvbM/SzWYl5/9uqzHlcpg6KlCTyuEMO6CV/GGy7g gIq74r+N3qISH0Ck536u2uVAX0dPlTh75xw1/0kzTYAMw1oXvGQpAjHD3WBfp9o1U8+X 3xRg==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785768707; x=1786373507; darn=lists.xenproject.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=D9ggXvuJw0OfV/7DwKJBrE2gM6POgD68kCOokV6rNFg=; b=ICyiP5ifAHUUGf/3s9QWw1rwd0ifC1e9FWWH+J4UY9SiDSsavcIvGsAsbd4MlTJIMF LTmbL5EYYHixm1WNTXjsNz2EQx6rlxa/ZXWhMtE10g6GSVHdVXOaX3zBw8ZldeD9/1OF q4jr1iWb+0QrIVYA8fANUIENP5me9CN82jCjw+1BD/AFwzVttS/HAQiYph4XqvftzkI8 ahdxr/Eqteq0oN04iCDPVHkG0nBFxbtOYACoGPV7HIaRtWhKolZWlNE0fv3Tcx1n8tlf InXCoa2t0D4NWu+YPHd8CAVnJMDtFgZKJH+JPc90iYeUgIg2ribCyKFGyL7cFQK1+n72 DHBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785768707; x=1786373507; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=D9ggXvuJw0OfV/7DwKJBrE2gM6POgD68kCOokV6rNFg=; b=IjKB6DtOEbSrqU6Pzqi1d9vxIBDO2w469UN5KA0KBA6TNc/ylYCkolfyF+Hk3gC70T PGfKyReHOi2ty9ERKnLNnfRgEMX0CAwjjr/OEXsWb0BG+uBPhzAirKLDm3iYGq64pfcN 4OYWCj4XaoKxH5o8cR2Z815sohqTwByQ86R+jWvd8+/nZbqY+b0Ob+Hn07X1g2eWf1Hr KQg3P7dAZoT3xM5Jg/kVN2Pbvdl0w04grcHtCxVLwMeG2u78l1zaHSIKNA2vUWF1/fnN dgVbTuEgyofTvefeDp85RdyFoKkO5TNkxaNNzVFIDC8bw3nWv4ea39pkxspGqZ360Ugz JJjw== X-Forwarded-Encrypted: i=1; AHgh+RpMocEp5rzUBiPECuRjpwor1k2Hlweo7VRU6Z2PKHYneDFV8O4KnSC2BTBpZVW/NR5jraMDLJNwcg4=@lists.xenproject.org X-Gm-Message-State: AOJu0YzVpXpxZQqaxA/i0j89x/GWB6uBfNdqMn0FwjnsdjJou0k+DE+G 9EW9Y5dLKhPnUiVDX4me6OiSIXLxql4/hawaYRBQMG10n8mCl9XgwtRvJB7MayWFUw6Cjx4jGeJ /I8CRSYIq5QJgM6gcH18kJWj3wpJrcHE= X-Gm-Gg: AR+sD10qE6DSMgDXy/kkswYnM353wzBGZOK3DBBh8uTXRZ05eyKhRXHYz1MSicqG/5F gpgxW4snF7ZtWiaPU0COnz1ls6OzVMpbeImkTOXRjiTXL2RT96EF/8WW3VC8X+TxNL2Rjjj1qLG rVLTqaeSJVp14LZuupxP/XCj7ky3c91LUYhDpwW3pip3KYLcDbTmV1UZcNDJcnQVaFiKxkzC+zE 0Zs7XePrquOxaHq83G7L+6eKO17pvBC7NQFh8NKGhryloBZEuhwku0EG5FkTgfcwqf8AZNk0dzX VvER93Za7ewG1rtT8enS3L/DRxtVYs/45tKV+MaIfOBRQgLIjCIXZyRD2ZAayOekPmZOGSJwUls j X-Received: by 2002:a53:ca4f:0:b0:667:a025:89a4 with SMTP id 956f58d0204a3-6694f08334emr9042125d50.18.1785768706580; Mon, 03 Aug 2026 07:51:46 -0700 (PDT) MIME-Version: 1.0 References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-13-frediano.ziglio@citrix.com> <2889dc4e-33ec-4d8f-b01d-026506a39cbf@suse.com> <07b3bbb6-ef62-419c-b708-1b9ae2774462@suse.com> <46b70e9d-1ade-4ba6-ad5f-87d2c9652a7b@suse.com> In-Reply-To: <46b70e9d-1ade-4ba6-ad5f-87d2c9652a7b@suse.com> From: Frediano Ziglio Date: Mon, 3 Aug 2026 15:51:34 +0100 X-Gm-Features: AUfX_mzy7nANcnwN3EGkyMZENWLyCWbjND7mD9ySmJskC8tgrgPc-DcdzJDw84U Message-ID: Subject: Re: [PATCH v6 12/16] xen: implement new foreign copy hypercall To: Jan Beulich Cc: Frediano Ziglio , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross , "Daniel P . Smith" , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1785768708-76AF94E9-CBE7C056/0/0 X-purgate-type: clean X-purgate-size: 8625 On Mon, 29 Jun 2026 at 07:59, Jan Beulich wrote: > > On 26.06.2026 16:14, Frediano Ziglio wrote: > > On Wed, 24 Jun 2026 at 07:44, Jan Beulich wrote: > >> On 23.06.2026 23:18, Frediano Ziglio wrote: > >>> On Tue, 23 Jun 2026 at 14:21, Jan Beulich wrote: > >>>> On 23.06.2026 12:55, Frediano Ziglio wrote: > >>>>> On Mon, 22 Jun 2026 at 11:34, Jan Beulich wrote: > >>>>>> On 19.06.2026 15:04, Frediano Ziglio wrote: > >>>>>>> --- a/xen/common/memory.c > >>>>>>> +++ b/xen/common/memory.c > >>>>>>> @@ -1545,6 +1545,139 @@ static int acquire_resource( > >>>>>>> return rc; > >>>>>>> } > >>>>>>> > >>>>>>> +/* > >>>>>>> + * The "noinline" qualifier avoids the compiler to create a large function > >>>>>>> + * consuming quite a lot of stack. > >>>>>>> + */ > >>>>>>> +static int noinline mem_foreigncopy( > >>>>>>> + XEN_GUEST_HANDLE_PARAM(xen_foreigncopy_t) arg) > >>>>>>> +{ > >>>>>>> + struct domain *d, *const currd = current->domain; > >>>>>>> + xen_foreigncopy_t copy; > >>>>>>> + int rc, direction; > >>>>>>> + > >>>>>>> + if ( copy_from_guest(©, arg, 1) ) > >>>>>>> + return -EFAULT; > >>>>>>> + > >>>>>>> + if ( copy.flags & ~XENMEM_foreigncopy_direction ) > >>>>>>> + return -EINVAL; > >>>>>>> + > >>>>>>> + direction = copy.flags & XENMEM_foreigncopy_direction; > >>>>>>> + > >>>>>>> + rc = rcu_lock_remote_domain_by_id(copy.domid, &d); > >>>>>> > >>>>>> Iirc I did ask before why this isn't ..._by_any_id(). > >>>>> > >>>>> I probably was confused by the question about MMUEXT and the 2 domains. > >>>>> There are different similar hypercalls (like the mentioned MMUEXT but > >>>>> also hypercalls to map foreign domain memory) that have this check > >>>>> (not the same domain). Any domain has, obviously, access to its own > >>>>> memory, so it should not have to use hypercall to access its own > >>>>> memory. If it does it looks like a mistake causing performance issues > >>>>> or an attempt to circumvent security; in either case you would like to > >>>>> avoid it. > >>>> > >>>> No. Self-grants are possible as well, for example, and for a good reason. > >>>> Allowing normally-remote operations on oneself helps with testing, for > >>>> example. It may also help avoid needing to special-case "self" in code > >>>> which needs to cover both cases. > >>> > >>> But this is not a grant, it's a copy. > >> > >> Sure, but the underlying principle is what matters. Plus you don't prevent > >> self-copy by using ..._by_id(), you only preclude the use of DOMID_SELF. > > > > Sure about this? > > No, I'm sorry: I (repeatedly) managed to ignore the "remote" in the function > called. That said, my request stands: No arbitrary restrictions please. If > you can properly justify a restriction, that's a different thing. > Not strong about it. I'll change to rcu_lock_domain_by_any_id. > >>>>>>> + XEN_GUEST_HANDLE(uint8) buffer; > >>>>>>> +}; > >>>>>> > >>>>>> What was (again) left unaddressed is the question towards using GFNs on both > >>>>>> sides of the copy. This would eliminate the need for the flags field, taken > >>>>>> by a 2nd domid_t one then. > >>>>>> > >>>>> > >>>>> This was addressed in > >>>>> https://lists.xenproject.org/archives/html/xen-devel/2026-06/msg00567.html > >>>> > >>>> Well, yes, but not in a satisfactory way. Back channels tell me that you > >>>> actually got the same feedback already on internal review. Which makes it > >>>> all the more puzzling that you insist on doing it differently. Multiple > >>>> maintainers asking for the same thing may be an indication of something. > >>> > >>> Not needing to have backchannel feedback, I already wrote that a > >>> similar approach was tried and made the code more complicated. > >> > >> Even if indeed so: Yet at the same time more flexible. > >> > >>> Both maintainers didn't comment on my replies so I assume they were > >>> fine with it. > >>> And you are failing to provide positive feedback. > >>> I asked (that one internally) for examples of guest buffers provided > >>> as frame numbers but I got no answer (or better the answer was more > >>> "currently there are not"). > >>> Also note that the location of xen_foreigncopy_t structure is also > >>> provided using a guest pointer. > >>> I remember there were some discussions about ABI changes (2/3 years > >>> ago) to address this and other issues but I cannot see much progress. > >> > >> And it's that (very slowly progressing effort) which made me ask. The > >> fewer virtual addresses we bake into new sub-ops, the better for that > >> effort. And no, that doesn't go as far as completely eliminating > >> handles (presently representing virtual addresses) - that needs to be > >> part of the new ABI. > > > > In other words, you want me to code something temporary that you > > already know that needs to be changed. > > What do you mean by "temporary"? We will need to live with the present > ABI for the foreseeable future. The new ABI's requirements haven't even > been spelled out yet. Patches to allow use of physical addresses in > place of virtual ones were actually turned down on the grounds of there > not having been a write-down of all requirements. > Temporary in the sense that there will be new ABIs to deal with not using virtual addresses. The second sentence is a bit contradictory. You want me to address the virtual address complaint but you are telling me that the change will be turned down if I don't address everything. And this is why this is out of scope here. > >> To preempt the argument towards "fewer virtual addresses" not really > >> being true when changing from handle-to-uint8 to handle-to-pfn: The > >> former won't be able to express a buffer mapped contiguously in VA > >> space, but discontiguous in PA space. The latter will, simply be > >> avoiding buffer VAs in the first place (the array of frame numbers > >> can e.g. be placed in a dedicated hypercall argument area known to be > >> physically contiguous). > > > > If it's mapped continuously in VA and you pass the VA I don't > > understand the problem. From the way I see it's more the latter that's > > the problem. > > I'm talking of the future, where VAs wouldn't be used anymore. The > buffer you use couldn't be described by a single PA, unless the caller > took specific measures up front. > If you read my reply I suggested a way to avoid virtual addresses completely. > Jan About the P2M type check it turned out that I was wrong with the checking. The MMAP way use MMU_UPDATE calls which do not care about P2M type at all. Changing the code to ... for ( unsigned int i = 0; i < todo; i++ ) { struct page_info *foreign_page; mfn_t foreign_mfn; void *foreign; p2m_type_t p2mt; p2m_query_t q = (direction == XENMEM_foreigncopy_to) ? P2M_ALLOC | P2M_UNSHARE : P2M_ALLOC; foreign_page = get_page_from_gfn(d, gfn_list[i], &p2mt, q); if ( unlikely(p2m_is_paged(p2mt)) ) { if ( foreign_page ) put_page(foreign_page); p2m_mem_paging_populate(d, _gfn(gfn_list[i])); p2mt = p2m_ram_paging_in; foreign_page = NULL; } if ( unlikely(!foreign_page) ) { rc = -ENOENT; if ( p2mt != p2m_ram_paging_in ) { gdprintk(XENLOG_WARNING, "Error accessing foreign gfn %" PRI_gfn "\n", gfn_list[i]); rc = -EINVAL; } copy.nr_frames -= i; guest_handle_add_offset(copy.frame_list, i); goto out; } ... About the XSM part I have now ... /* * Check we are allowed to map and access these foreign pages. */ if ( direction == XENMEM_foreigncopy_from ) rc = xsm_foreigncopy_from(XSM_TARGET, currd, d); else rc = xsm_foreigncopy_to(XSM_TARGET, currd, d); if ( rc ) goto out; ... I wrote some code for the compat mode but I need to test it. Still I think that adding it it's a mistake, it's just a new, probably unused, ABI that must be maintained till a probable "no virtual address" ABI will replace it. Frediano From xen-devel-bounces@lists.xenproject.org Mon Aug 03 14:52:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 14:52:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381550.1625108 (Exim 4.92) (envelope-from ) id 1wqu1d-0001mH-M3; Mon, 03 Aug 2026 14:52:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381550.1625108; Mon, 03 Aug 2026 14:52:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqu1d-0001mA-Iw; Mon, 03 Aug 2026 14:52:21 +0000 Received: by outflank-mailman (input) for mailman id 1381550; Mon, 03 Aug 2026 14:52:20 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqu1c-0001kH-4b for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 14:52:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqu1b-00FD5N-5f for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:52:19 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70ab1c-bab6-0a2a0a5309dd-0a2a4506e79a-10 for ; Mon, 03 Aug 2026 16:52:19 +0200 Received: from [209.85.218.47] (helo=mail-ej1-f47.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70ab22-195a-0a2a45060019-d155da2fadae-3 for ; Mon, 03 Aug 2026 16:52:19 +0200 Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-c15ba3a2b4bso416268466b.1 for ; Mon, 03 Aug 2026 07:52:19 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd466271csm594663266b.60.2026.08.03.07.52.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 07:52:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785768738; x=1786373538; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0qKWJoSCqTs9s/h/TtgzhU/DUhBV122CIkFwWPBNBUk=; b=LwjccAjQtHAZ8Zh414NvjqxLsqVx6vNReCA+vPZxFgtkIMaMDiK2TSCssTIYfl9qsL a/OPYH3M3rO2iVuu66FAbDeU8v93FRK0GQPwatktAshZAESevBzIuYui0I761XiRf/oJ rtFu0UfkeNdCFfoXgsR87u1qpx7s2w2kVTEjWEJ9YCwQKNHxn9yUWOBahLPlxv/JqNbW 8CA37OZrW3x/tz4WOpgRs0PFrzMcTXVN+4r46A/mRdtUKsBL60h/FKfOK0RriEXCutTm ac+CbNlpdi3AMGCfoEfkCNe+QDkIFc+ZDrGcid2CvBVB8k8cXw5hItU70uPGBY3OMK4b 94pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785768738; x=1786373538; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0qKWJoSCqTs9s/h/TtgzhU/DUhBV122CIkFwWPBNBUk=; b=tIpPifRccrh56eyICJ0hLPcoJ5T/bEOznNyynB5Jr9KfR2iMUTP63jv2qKB+goJKBw CLo+9Gdrs1EwWQtHmYKOp3T6qf0Bgv14+DfEIYBkQ3fpuLOmYTMXjh3MML3YKvfttd7m dAjmffDeqroWe1j0Zj/PO/rGTy2SHQRwfDaeooJ5Za6a5U+naWcsi7JKtXK/QDbrUM/z gNFEPYVv0ELPMyqSZ+JK/T+JQcKv5wF9wNKHXk9P7zXn7d6EfKh/pK+MPwkZ2H++TSew 6VLcpnEKjnNR5TayLYFLi4rWKhoYnD2aBSh1LMR3DcuIukYCQT6snsyEKTQVsRxKNEz5 5n/g== X-Gm-Message-State: AOJu0YxV5TiGDLqBZmO92M9zpi6vCmGP9HAunSRClFk1mgbBPteCqwFa 7N9oKbIcvnnzT2SXtO6cnB385vwl1qssF36ca1jloxw/6Pme6iZMZBOW8et3R5LjyBM= X-Gm-Gg: AR+sD10qb8XRIOQhRmuZY+sGJqfVeaSLEWcBnWbnAKkTr9OIRfZTS/Ta4DjR8KCiDBK kHjUEKtmTJcAajKMA8eaIdpIM62eJFr6UqIooLLZ8F0cdXcX3BOhLl61R2+kmvTfE1EtsPTauPz KHPEF0AMO2GyBwI9Obqe078cptTMqFbblyW/HvrHEgNzQomify3Xm1qTbT5xlDIQGuVsoGt6ULy fvN86J5yBVzpfbbrBhFpgY+/uE+ijcc/wVjoyoTnfpABz5xeZFA0t19ZznT8sDXUZH5MzQ6lbVR iPDikeKhvZr8qE6939s/86VpnJ5bZzXHr1V3wp+vihrkTF4Pw7zbtVcyasrFBGHnwdufk+GvUdS TAFbORF/7yFZDIHxSGm8J9iaN6nWl3m94wVmFOk/cbbZushyeQg64WPPHqMV2LfYi3irOsanJgU c+Qt/vrsymlvFylsF0Ffw5qVucNqTq+yeDx48yDrae0DNCwCx2FNzmXCiTVbgOL1NuOnUCcb1QH lIEy4TO7PNpAjCvoMdRs6NI2A1coh0aIAf5hjuO4/LpfxMVTR4aQW2O2jGCPU/J3EJcvRv0PPCt on+AvV/y2SAzCaYUenMMH3L0MA== X-Received: by 2002:a17:907:da15:b0:c15:cac2:1ec4 with SMTP id a640c23a62f3a-c1fe7ecaf45mr867318666b.1.1785768738422; Mon, 03 Aug 2026 07:52:18 -0700 (PDT) Message-ID: <2f1348d8-c175-42e5-9b33-bdca19bde734@suse.com> Date: Mon, 3 Aug 2026 16:52:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH Linux v6 16/16] xen/privcmd: Add new ABI to allow copying foreign memory To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-17-frediano.ziglio@citrix.com> <439c2740-fb84-42cb-b001-cb290684a583@suse.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------pU6AunD4X9CW20zewjSsZ2ob" X-purgate-ID: tlsNG-16d1c6/1785768739-F7ACA77B-DB8132FD/0/0 X-purgate-type: clean X-purgate-size: 11849 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------pU6AunD4X9CW20zewjSsZ2ob Content-Type: multipart/mixed; boundary="------------lQhl9a0UTJFXvMiSh6rfC5yO"; protected-headers="v1" From: Juergen Gross To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD Message-ID: <2f1348d8-c175-42e5-9b33-bdca19bde734@suse.com> Subject: Re: [PATCH Linux v6 16/16] xen/privcmd: Add new ABI to allow copying foreign memory References: <20260619130501.272832-1-frediano.ziglio@citrix.com> <20260619130501.272832-17-frediano.ziglio@citrix.com> <439c2740-fb84-42cb-b001-cb290684a583@suse.com> In-Reply-To: Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------lQhl9a0UTJFXvMiSh6rfC5yO Content-Type: multipart/mixed; boundary="------------I41cUVayIIqMBA0WgqbDouAc" --------------I41cUVayIIqMBA0WgqbDouAc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjYgMTY6MjMsIEZyZWRpYW5vIFppZ2xpbyB3cm90ZToNCj4gT24gTW9uLCAz IEF1ZyAyMDI2IGF0IDE1OjA1LCBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+IHdy b3RlOg0KPj4NCj4+IE9uIDE5LjA2LjI2IDE1OjA1LCBGcmVkaWFubyBaaWdsaW8gd3JvdGU6 DQo+Pj4gVGhpcyBuZXcgQUJJIGFsbG93cyB0byBjb3B5IGZvcmVpZ24gZG9tYWluIG1lbW9y eSB0by9mcm9tIGEgYnVmZmVyLg0KPj4+IFRoaXMgYXZvaWRzIGhhdmluZyB0byBtYXAvY29w eS91bm1hcCBmb3JlaWduIG1lbW9yeSB3aGljaCBpcw0KPj4+IGV4cGVuc2l2ZS4NCj4+PiBU aGlzIG9wZXJhdGlvbiBpcyBkb25lIHBhcnRpY3VsYXJseSB3aGVuIG1pZ3JhdGluZyBWTXMu DQo+Pj4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBGcmVkaWFubyBaaWdsaW8gPGZyZWRpYW5vLnpp Z2xpb0BjaXRyaXguY29tPg0KPj4NCj4+IFdoaWxlIGRvaW5nIGEgdGVzdCBidWlsZCBJIGdv dCB0aGUgZm9sbG93aW5nIGJ1aWxkIGZhaWx1cmVzIGZvciAzMi1iaXQgYXJtOg0KPj4NCj4+ ICAgICBDQyAgICAgIGFyY2gvYXJtL3hlbi9lbmxpZ2h0ZW4ubw0KPj4gSW4gZmlsZSBpbmNs dWRlZCBmcm9tIC9ob21lL2dyb3NzL2tvcmcvc3JjL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3hl bi9pbnRlcmZhY2UuaDoxLA0KPj4gICAgICAgICAgICAgICAgICAgIGZyb20gL2hvbWUvZ3Jv c3Mva29yZy9zcmMvaW5jbHVkZS94ZW4vaW50ZXJmYWNlL3hlbi5oOjEzLA0KPj4gICAgICAg ICAgICAgICAgICAgIGZyb20gL2hvbWUvZ3Jvc3Mva29yZy9zcmMvaW5jbHVkZS94ZW4veGVu Lmg6NTIsDQo+PiAgICAgICAgICAgICAgICAgICAgZnJvbSAvaG9tZS9ncm9zcy9rb3JnL3Ny Yy9hcmNoL2FybS94ZW4vZW5saWdodGVuLmM6MjoNCj4+IC9ob21lL2dyb3NzL2tvcmcvc3Jj L2luY2x1ZGUveGVuL2FybS9pbnRlcmZhY2UuaDoyMjozNTogZXJyb3I6IHVua25vd24gdHlw ZSBuYW1lDQo+PiAnX19ndWVzdF9oYW5kbGVfdWludDhfdCcNCj4+ICAgICAgMjIgfCAjZGVm aW5lIEdVRVNUX0hBTkRMRShuYW1lKSAgICAgICAgX19ndWVzdF9oYW5kbGVfICMjIG5hbWUN Cj4+ICAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+ fn5+fn5+fn5+DQo+PiAvaG9tZS9ncm9zcy9rb3JnL3NyYy9pbmNsdWRlL3hlbi9pbnRlcmZh Y2UvbWVtb3J5Lmg6MzYxOjU6IG5vdGU6IGluIGV4cGFuc2lvbiBvZg0KPj4gbWFjcm8gJ0dV RVNUX0hBTkRMRScNCj4+ICAgICAzNjEgfCAgICAgR1VFU1RfSEFORExFKHVpbnQ4X3QpIGJ1 ZmZlcjsNCj4+ICAgICAgICAgfCAgICAgXn5+fn5+fn5+fn5+DQo+PiBtYWtlWzVdOiAqKiog Wy9ob21lL2dyb3NzL2tvcmcvc3JjL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6Mjg5Og0KPj4g YXJjaC9hcm0veGVuL2VubGlnaHRlbi5vXSBFcnJvciAxDQo+PiBtYWtlWzRdOiAqKiogWy9o b21lL2dyb3NzL2tvcmcvc3JjL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6NTQ5OiBhcmNoL2Fy bS94ZW5dIEVycm9yIDINCj4+IG1ha2VbM106ICoqKiBbL2hvbWUvZ3Jvc3Mva29yZy9zcmMv c2NyaXB0cy9NYWtlZmlsZS5idWlsZDo1NDk6IGFyY2gvYXJtXSBFcnJvciAyDQo+Pg0KPj4N Cj4+IFBsZWFzZSBmaXggdGhvc2UuDQo+Pg0KPj4NCj4+IEp1ZXJnZW4NCj4gDQo+IE11bWJs ZS4uLg0KPiANCj4gSSBzdXBwb3NlIHRoaXMgd291bGQgZml4IGl0DQo+IA0KPiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS94ZW4vYXJtL2ludGVyZmFjZS5oIGIvaW5jbHVkZS94ZW4vYXJtL2lu dGVyZmFjZS5oDQo+IGluZGV4IGMzZWFkYTI2NDJhYS4uN2U3OTg1M2IxODhkIDEwMDY0NA0K PiAtLS0gYS9pbmNsdWRlL3hlbi9hcm0vaW50ZXJmYWNlLmgNCj4gKysrIGIvaW5jbHVkZS94 ZW4vYXJtL2ludGVyZmFjZS5oDQo+IEBAIC01Myw2ICs1Myw3IEBAIERFRklORV9HVUVTVF9I QU5ETEUoaW50KTsNCj4gICBERUZJTkVfR1VFU1RfSEFORExFKHZvaWQpOw0KPiAgIERFRklO RV9HVUVTVF9IQU5ETEUodWludDY0X3QpOw0KPiAgIERFRklORV9HVUVTVF9IQU5ETEUodWlu dDMyX3QpOw0KPiArREVGSU5FX0dVRVNUX0hBTkRMRSh1aW50OF90KTsNCj4gICBERUZJTkVf R1VFU1RfSEFORExFKHhlbl9wZm5fdCk7DQo+ICAgREVGSU5FX0dVRVNUX0hBTkRMRSh4ZW5f dWxvbmdfdCk7DQo+IA0KPiBGcmVkaWFubw0KPiANCg0KQW5kIG5vdyBhbm90aGVyIG9uZToN Cg0KL2hvbWUvZ3Jvc3Mva29yZy9zcmMvZHJpdmVycy94ZW4vcHJpdmNtZC5jOiBJbiBmdW5j dGlvbiAncHJpdmNtZF9pb2N0bF9mb3JlaWduY29weSc6DQovaG9tZS9ncm9zcy9rb3JnL3Ny Yy9kcml2ZXJzL3hlbi9wcml2Y21kLmM6MTU5MToyOTogZXJyb3I6IGluY29tcGF0aWJsZSB0 eXBlcyANCndoZW4gYXNzaWduaW5nIHRvIHR5cGUgJ2NvbnN0IHhlbl9wZm5fdCAqJyB7YWth ICdjb25zdCBsb25nIGxvbmcgdW5zaWduZWQgaW50IA0KKid9IGZyb20gdHlwZSAnX19ndWVz dF9oYW5kbGVfeGVuX3Bmbl90Jw0KICAxNTkxIHwgICAgICAgICAgICAgICAgIGNvcHkucGZu cyA9IHhjb3B5LmZyYW1lX2xpc3Q7DQogICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgXn5+fn4NCi9ob21lL2dyb3NzL2tvcmcvc3JjL2RyaXZlcnMveGVuL3ByaXZjbWQu YzoxNTkyOjMxOiBlcnJvcjogaW5jb21wYXRpYmxlIHR5cGVzIA0Kd2hlbiBhc3NpZ25pbmcg dG8gdHlwZSAndm9pZCAqJyBmcm9tIHR5cGUgJ19fZ3Vlc3RfaGFuZGxlX3VpbnQ4X3QnDQog IDE1OTIgfCAgICAgICAgICAgICAgICAgY29weS5idWZmZXIgPSB4Y29weS5idWZmZXI7DQog ICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fg0KDQoNCkp1ZXJn ZW4NCg== --------------I41cUVayIIqMBA0WgqbDouAc Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------I41cUVayIIqMBA0WgqbDouAc-- --------------lQhl9a0UTJFXvMiSh6rfC5yO-- --------------pU6AunD4X9CW20zewjSsZ2ob Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpwqyEFAwAAAAAACgkQsN6d1ii/Ey+X awf8DEKzTmCk+s5KRL6C70aTw6kpX+aMhkz2Mlnu1Hy2zzzb9abqos+57esHSIuvUCgJfhpbaKfI NKkrfLpt63PBmUBUfpO6g2lLqKcpPwBnlyTkmkLM8RkQ4ZO6kcB9iuwMvDuAkgeeJC5eFRPf9PPj zvkY/9nk1qjjLf/6GUqxspczKK5ti1CS5XtLHYPQwALl2Y4DGTMFggnQaEr41q3OlUvsqs5Pyno8 5d5IEwu9xGRRpmm3VaIV/NTsNdH8eQO3QN/nVMyCUB/R06mq1o3f84Oq2+IlAaUP1rPX+f2LZ3/K A31Q/nSO0OPhail0y3iE3vvXcH59RnHfvp6DBg2YwA== =h9ye -----END PGP SIGNATURE----- --------------pU6AunD4X9CW20zewjSsZ2ob-- From xen-devel-bounces@lists.xenproject.org Mon Aug 03 15:05:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 15:05:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381571.1625117 (Exim 4.92) (envelope-from ) id 1wquEg-0004Xm-Ty; Mon, 03 Aug 2026 15:05:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381571.1625117; Mon, 03 Aug 2026 15:05:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wquEg-0004Xf-R0; Mon, 03 Aug 2026 15:05:50 +0000 Received: by outflank-mailman (input) for mailman id 1381571; Mon, 03 Aug 2026 15:05:49 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wquEf-0004XG-9r for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 15:05:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wquEe-00C4tH-58 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 17:05:48 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70ae3b-bab6-0a2a0a5309dd-0a2a4509e122-22 for ; Mon, 03 Aug 2026 17:05:48 +0200 Received: from [40.93.196.34] (helo=SA9PR02CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70ae46-be1a-0a2a45090019-285dc4226f70-3 for ; Mon, 03 Aug 2026 17:05:43 +0200 Received: from CH8PR03MB8274.namprd03.prod.outlook.com (2603:10b6:610:2ba::5) by CH2PR03MB5237.namprd03.prod.outlook.com (2603:10b6:610:9c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.15; Mon, 3 Aug 2026 15:05:39 +0000 Received: from CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096]) by CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096%7]) with mapi id 15.21.0270.017; Mon, 3 Aug 2026 15:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E95kQb54/Up4zQNpaK2mkQPBjjPUTJKxWMfkPGvedy5hkuh4ZaEM79QZsq1e0xojCTuHDQuc2+CE1cgSVN914XR4hNvFL3j2NhSj1GqGqdP8Z8PKLP7+zVL5a1m44ba+azxb38Ceei9ITGeDOJh5eixA2muBWOlsz8RxLc+S7WF93BydMtKwZV+4ZTuJgZLV5OTeOkxak9utxnTmJUev9pqFwcMlVna1Zcpr9CZhDIrfw6K6732BZqeJOiFn0WkCXS0LgxrELdEN1kdT7njQxCw+ZsUzk6AWBtuVdXxUu8oOn/1og+fKlLY6jL863SPs1pCFKRLSxdBX9DLRCmjleA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dQhPrpdiWnaSoeNcNnfROBr+QPpTBnQIhAoLCjbz3l4=; b=R8Qlc3CZbKbCUWeHtkmzJue6ngci5xUrkSN20Km0BT/1YnQRYUPF8pxM/jfFnLAaYovCgxv4eqd0GbhSuNmRFNIL+I2ARRw0l3Km7p7e7DhQhWCekJfRm5njS/j2fMDCg6/4YSBMU4WzkMUdwLqkFsRhp6BSJQsTXsuwwWVL7EfS+49c7ZmfQoHevwqHKitvLbp/w+TFT9eW96Udfkvjhqd8OxyyMOj6G50PVC+If+XE2jXzjrDpK9KNIbOH1r+MN+YMHqJFthr6Agu6FQFbprBOTS2ghe34czD32SwRQ7WCGS84kDckjMZyxV31yw7sH+bfSAIABiOyWRisoEN7Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dQhPrpdiWnaSoeNcNnfROBr+QPpTBnQIhAoLCjbz3l4=; b=OgknMIp4lqkzxUxDuwHMe2cJvErdytH8BcEkxsqBrJP7Yj76RSX1Pu1xyurgyGhhMJqJiptWqRsWM5YYme4pSPpT4IEfjJBUOXVYQiHrLTI/iOQch/n5dJZ7DTkn4jutUg56RaTp956XNk9ijr+0KBR3a1pmECPXqdQo1uhqZM4= From: Ross Lagerwall To: Andrew Cooper , Xen-devel CC: Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Oleksii Kurochko Subject: Re: [PATCH v3 2/3] xen/livepatch: Fix include hierarchy Thread-Topic: [PATCH v3 2/3] xen/livepatch: Fix include hierarchy Thread-Index: AQHdIQOIBBx6uSDlKEqW+113k5excraMcI6S Date: Mon, 3 Aug 2026 15:05:38 +0000 Message-ID: References: <20250509163212.2948359-3-andrew.cooper3@citrix.com> <20260731154447.436019-1-andrew.cooper3@citrix.com> In-Reply-To: <20260731154447.436019-1-andrew.cooper3@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH8PR03MB8274:EE_|CH2PR03MB5237:EE_ x-ms-office365-filtering-correlation-id: 5de7c475-6062-4b3a-5f55-08def170aded x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|366016|1800799024|38070700021|56012099006|4143699003|10067099003|11063799006|18002099003|22082099003; x-microsoft-antispam-message-info: qXEQmdSh8d1NRfnJEZ3a3PfDWNJ42M/Xjs6z2hiymcLT2PGzzmulK441LqcCBPZXLHkzAXcKgi4i022z7l9DCBV7WPgOKXYTLhFd+GaRkJ2YdKxFIzdxBaga/63v7OEow97pPFFMegha3yXwwVp/YhhuoojCGywuF3c5vU58vEBi1QRvqAiWl2K6sd3Vmb7Wa5F4V1Tn9JswO/hxnkxbGk1gGvGBQIi60NlhOITmb4vVsaSg+XAZiTtVAJuP4gsQ+rlmdtoVkc7wbVOFAtdT8BaxjpdZLRGWcwNCy3hqUUrJy9WcXWSyOgWlIlpFhYpClNVXVB7Se4yaG4lZtSTSDvJ7L4shM5wTbyklas4e21wNd64sPLgHEcJCHf09zq729TRf4/A74Okz6C9ZOJ3XAgR6t3EXutjHV5FXr1FycW0CWpSIRIP7pwuK5sEB4PPbvEbngYyBlq6G9oaw4RXYj2fVPo1t1fY35vlOX9RxQmyWs9bT/wJzv4wuJDEwu9VkYZchxfV3byIJksou+aIGuT9e1TvnqcpWO8OY12bDf+SHr+xWvVe7/U1fmtYApIG8cd/ftCFavpwlEv3fjKdSC60vqtNJTJkP5YyAbKh3mH0WErTsPnYsXZZlSo+8ytxds0zOIrfewYjlc2X5YjdwLTGJms9rWMl4fT0TS8daAsQovwHk+nkpXhZdc16lzR7Pg2Y+vCnbSDN/tamGqfFzMTT50P2dfNPmuFm9I6a0Cmw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8274.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(366016)(1800799024)(38070700021)(56012099006)(4143699003)(10067099003)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ADouJoRp4rHWRrRdvY6mwBF3NQqcDvds3/9lMmltsL+03BGLsFtlgeEuyT?= =?iso-8859-1?Q?hRO4NVwuUOQ3HweveH2ELcOWIQdfJB7++Vv/mIXmy3D8Wfl7Df8r/fGfU+?= =?iso-8859-1?Q?L4MKaNk36DR7R9FK4NeCLGhpO13iY0V/Q7F1sjQhFthCt9tXgyNlc+Oe4B?= =?iso-8859-1?Q?m+EDri7iwo/WhqxcjNYYQlVqTfnQ7ni+iOQw0CED40wbGmbl3Wfuri9UCy?= =?iso-8859-1?Q?kunlp4wuTWFSgLES7qaSeITVDfjuzgglVx7zWJUcD/4yaY1Z3ZWdIEYZKH?= =?iso-8859-1?Q?IXFHcVgq8dpzCtD4CC1PUQ8NolzoDoSdnKZnfc2trcyyFvVFCyUzuEfzNu?= =?iso-8859-1?Q?Kfj2WTNgkmyV09v8A0S4JIUpNySSBp8zsJJ7nsV6/wsMtEgsNWwYMxp5uB?= =?iso-8859-1?Q?hu5MVVlHvAb8DwvHNyDuR+YLRa8SVAX65f+0r5Zplmt71jmGpqQstRDtjB?= =?iso-8859-1?Q?7RQb6uYG75Nan1Py/98EhXXb/cAZbxz0uTlHC4Oz8y8AzN/4eR6zZeAxGY?= =?iso-8859-1?Q?6wq97bG0n2XKqy/tmencgoWOWaGUZlDauGV+wZsf9yXFMPIn/MlXQYpmyh?= =?iso-8859-1?Q?xzqFMWnmCGLt8q5fjdpxj8lmcEXSl67dJso9+OO2V2kB/CkCXhfIBSJJug?= =?iso-8859-1?Q?fQXgJoe8fhZekHV6XtzkGO35XlEFR7Fnr3YAe6LUdvP/FK/tSYgE2JFY6b?= =?iso-8859-1?Q?fNHpo7P122r6TshYCTT3/4ITNvG+WcqYqwpJrisO6AJfdEKxS0KDcBt0+f?= =?iso-8859-1?Q?klnTH5a9Ghwzdt6jDXm5hRF8a1awifTW3ZYOmh0h5itzFBO0c/8XDHLpMQ?= =?iso-8859-1?Q?jj57/Z8PlNhAyrgAbOSpjBr0IE9ci2hIExKYBE+XEzb5BIKGw6Wtguqrem?= =?iso-8859-1?Q?8CL7M5iGzg++BdWyEiROaIIannFnmMGVHLChEctQmRevwW8zHttsWaDzxo?= =?iso-8859-1?Q?eTpI0snQhT/fcrPhkpYRnecjxQRoiUUwb3St/twthn+4VePa4QbHUPoyGY?= =?iso-8859-1?Q?os0WyYri8Wn9hRQhFVBpYpKamX+KaHSJ3oFfa/PhmersF/iVIUm+9cyCYh?= =?iso-8859-1?Q?Iudnr3FpHOhhg8kU11X1+bPpyjWOp1Dq/IxGNU/1Ao9SEC+POCK7juZ+4+?= =?iso-8859-1?Q?AQYS9DpfRdxPgJvXFgWjUWDZrn0Jsv8V+woNCrGst2Ybq41tAqfvRe5qWU?= =?iso-8859-1?Q?ORCxev2GiAIz5fPQ3CfImSTDXxO5C9LwTGOlVTE5CVcKVlqdW9iPqnRD+4?= =?iso-8859-1?Q?d06il8Cg00KN91v02kLnYG4BMIvKXWF0aTnRS8A1bRPoJ9krfySs0t5dsu?= =?iso-8859-1?Q?ESag7/Rx1MCKEMu1WqgNnt0BSRJrquWOjRYSBHSHls66nasVPmLrYCtA+i?= =?iso-8859-1?Q?fNswKPzgp0NjJhYgNYtNGhPgejyx5LeyPeKk3wd8R3HN1WvAweci+/vQ2V?= =?iso-8859-1?Q?bKlm0qslnQEafCM1GzVIpf2jBoyJoQ4BZ0Qn32s//NczCP8+9WDpl7yXFF?= =?iso-8859-1?Q?XdYPYMsF6jO4S4VLZc4NyZN30pUMIf79pzw3dYi4z/l/gfQEG2HvYXOxKr?= =?iso-8859-1?Q?sD/BLZ0V9NLiXh6YyaGHRnyttxxP08VI5IjTpyR5nSbKeQpAjEJ1baDWio?= =?iso-8859-1?Q?J9PJdT2vsgoaffgWK4k0kQ4kWOSRc8bBHkQeXECzCoFnhDMjXG9w2a9F1F?= =?iso-8859-1?Q?+M66UlVmRSH0IYsDqBtp7GgtBlFYise0S+qUIiyfPEh3BtRyq0a8NNtnUK?= =?iso-8859-1?Q?5PZx470mU2fhS4zixlFMMXDtBZkaWtlAmGsb/P2OGbyGJiSCBOVL2wDf2q?= =?iso-8859-1?Q?i/etsI5+hQ=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8274.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5de7c475-6062-4b3a-5f55-08def170aded X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2026 15:05:38.9750 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rgO7HR7Lx9DwX9eRF35xCNin+Pc3FYVmQC3lpd7f2EwsW9npgwtddVUFoMUQcZBM/4ZyepAl73wwkf3cvEdTZ9tlDB7bOxaQWpSnxCzm9kY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5237 X-purgate-ID: tlsNG-bad1c0/1785769544-39AC0034-D83E6303/0/0 X-purgate-type: clean X-purgate-size: 808 > From: Andrew Cooper =0A= > Sent: Friday, July 31, 2026 4:44 PM=0A= > To: Xen-devel=0A= > Cc: Andrew Cooper; Anthony PERARD; Michal Orzel; Jan Beulich; Julien Gral= l; Roger Pau Monn=E9; Stefano Stabellini; Volodymyr Babchuk; Bertrand Marqu= is; Oleksii Kurochko; Ross Lagerwall=0A= > Subject: [PATCH v3 2/3] xen/livepatch: Fix include hierarchy=0A= > =0A= > xen/livepatch.h includes public/sysctl.h twice, which can be deduplicated= , and=0A= > includes asm/livepatch.h meaning that each livepatch.c does not need to= =0A= > include both.=0A= > =0A= > Comment the #else and #endif cases to aid legibility.=0A= > =0A= > Signed-off-by: Andrew Cooper =0A= =0A= Reviewed-by: Ross Lagerwall =0A= =0A= Thanks= From xen-devel-bounces@lists.xenproject.org Mon Aug 03 15:09:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 15:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381578.1625127 (Exim 4.92) (envelope-from ) id 1wquII-0005mS-Db; Mon, 03 Aug 2026 15:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381578.1625127; Mon, 03 Aug 2026 15:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wquII-0005mL-AP; Mon, 03 Aug 2026 15:09:34 +0000 Received: by outflank-mailman (input) for mailman id 1381578; Mon, 03 Aug 2026 15:09:33 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wquIG-0005mF-Rz for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 15:09:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wquIG-00FGFk-8j for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 17:09:32 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70af1d-2eae-0a2a0a5409dd-0a2a450ab052-46 for ; Mon, 03 Aug 2026 17:09:32 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70af2b-f2d2-0a2a450a0019-d155802dc807-3 for ; Mon, 03 Aug 2026 17:09:32 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4956869750eso14065385e9.2 for ; Mon, 03 Aug 2026 08:09:31 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808199a5csm338284985e9.4.2026.08.03.08.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 08:09:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785769771; x=1786374571; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7+c+qq8EM5bi4ZLYwjWJgiPT8GJ9IUzuXDiF/Sbo//g=; b=Yj8X+y/hJOoaEuHg6yKICKLzdp67EgMAbtwYvddARVOoG44yPx1r0W+H72rKZo9E4W IcwPO2wxeUKfx/MM+FaA+aDPeMeyamvWu64A9nrMwYBNjI7E3A0eOPsY5nJi1vorG2A1 7Ib7Nu3FJ1Hj6UTMWN/rFZvRPU7nKcf0ZUhwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785769771; x=1786374571; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7+c+qq8EM5bi4ZLYwjWJgiPT8GJ9IUzuXDiF/Sbo//g=; b=YaILgg3WJlQRFC97R3g/BZMqnVNt1uUFqVHvP4D+4L93X+pNQUdBSKsiucKcvjHypl IV+li88wvDKqWlqFhMr1zOjSqYIBpd2tSQGoS5K34CYz6ftUI8bXu+lw8c2A/oFaxLZ0 PbQexOREDH9Swiqc8Si7RTXBHmhaDMa/r+GyRewW3seMfK2Pjxf0RLkEKaaNx4ycB3Kp k5gljyJ+xkfBw41YkyBJsvHMvpUS7OInoniLe/tH91Zy2aR6IbFi1cUW0pphVngh1mow Tvbuof9qZbSYS0dkeijfoZpyYnb9oqqXdaGme/M7fQy+U/JBlnHrwHIXA5/IG5n4TXG6 CyPA== X-Gm-Message-State: AOJu0YyE/4KmoynY3o695fCtfj+pmu/558trPWAG/c4VVAeGrxhxtOUF zOr6tVd+hIqaMqVscIJ/gkFizMkhVxSX4TYfUq9CY6TnjqaDj4sUWVsE/azJRacSuJ3tH6BMnk+ 3aVBOvls= X-Gm-Gg: AR+sD10LsyvWXxGM/IdzgaMY6y580pCyc1GO9uiX1FyYdAzpJwwo7bkHnqdFjJsNMB5 OtAUNQeWD8eZ374zx0SDAa6YHvIInMOQJKJajcKnZSCUHz6iVrnY01cuC5yV8zr3Oh15eWUQhM1 +HCt7Mcj6pWtfhWKTgVjjvjn9K9pDdUygPSWhh/iarAQwqiZCJl5P+M3qKjfvvkfzWAHzFOOosY q6jqbNAsIZb4htP21xcKKRS865YZOqG6USr4q8ZwkYQDjkq8cDN0v3LYk+3YLGtG6AJK4Uyihig HWTqtNRCHuteB8VsOzeXs31Wr3iKB8rnI0afyHt9gIaqViXDZX6BBtA679+ISkMNWEc7DDhPUDG bq2gOdYuAEPeYZZNDznQ5prtI3M3lDLbOyQLNh0xNTehHUo33Dihw89WO6Hd94WjOBIWI9v4o5E mAkj773q3CbCkvIqzBtwxROmnctVVaF1M9pgqV15i1K96VR5IXMDaZH3s//2wIZk8je3Da52ytb WavgYvwNGf34kemFKkdCNIDw0HU9Yu5ZYqui3GMyxQa/ooZcg== X-Received: by 2002:a05:600c:628d:b0:490:e5c1:b8bf with SMTP id 5b1f17b1804b1-4980c64e4c8mr248831955e9.13.1785769771272; Mon, 03 Aug 2026 08:09:31 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Oleksii Kurochko , Ross Lagerwall Subject: [PATCH] xen/livepatch: Move init_or_livepatch_* into xen/init.h Date: Mon, 3 Aug 2026 16:09:25 +0100 Message-Id: <20260803150925.408857-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1785769772-532D8CFC-79776C13/10/73395122804 X-purgate-type: spam X-purgate-size: 5701 xen/livepatch.h is a fairly heavyweight header pulling in public/sysctl.h, and a reasonable number of users care only for the init_or_livepatch_* tags only. They're arguably more init than livepatch anyway, and by moving them to init.h, we can remove a number of includes. The include in vsprintf was leftover from early versions of the work. In the version committed, d5ccf4482e4f ("x86, xsplice: Print payload's symbol name and payload name in backtraces"), symbol_lookup() had been adjusted to handle the livepatch symbol names properly. No functional change. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan Beulich CC: Julien Grall CC: Roger Pau Monné CC: Stefano Stabellini CC: Oleksii Kurochko CC: Ross Lagerwall --- xen/arch/riscv/extable.c | 1 - xen/arch/x86/alternative.c | 1 - xen/arch/x86/extable.c | 1 - xen/arch/x86/mm.c | 1 - xen/common/vsprintf.c | 1 - xen/include/xen/init.h | 19 +++++++++++++++++++ xen/include/xen/livepatch.h | 21 --------------------- 7 files changed, 19 insertions(+), 26 deletions(-) diff --git a/xen/arch/riscv/extable.c b/xen/arch/riscv/extable.c index 77e5e9e89439..5b89c4278c65 100644 --- a/xen/arch/riscv/extable.c +++ b/xen/arch/riscv/extable.c @@ -3,7 +3,6 @@ #include #include #include -#include #include #include diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 5ed0c2672589..4c09dc55c684 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -16,7 +16,6 @@ #include #include #include -#include #define MAX_PATCH_LEN (255-1) diff --git a/xen/arch/x86/extable.c b/xen/arch/x86/extable.c index e1c8c9fab811..1425ea176570 100644 --- a/xen/arch/x86/extable.c +++ b/xen/arch/x86/extable.c @@ -2,7 +2,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 511de4cc38a8..b158742408f9 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -101,7 +101,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c index 612751c90f43..90192fd9e8b9 100644 --- a/xen/common/vsprintf.c +++ b/xen/common/vsprintf.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #include diff --git a/xen/include/xen/init.h b/xen/include/xen/init.h index 0c921672c196..2e5bea2bff93 100644 --- a/xen/include/xen/init.h +++ b/xen/include/xen/init.h @@ -19,6 +19,25 @@ #define __initdata_cf_clobber __section(".init.data.cf_clobber") #define __initconst_cf_clobber __section(".init.rodata.cf_clobber") +/* + * Various pieces of functionality are needed at runtime only if livepatching + * is enabled. Provide tags which resolve to the appropriate section + * annotation in either configuration. + */ +#ifdef CONFIG_LIVEPATCH +# define init_or_livepatch_const +# define init_or_livepatch_constrel +# define init_or_livepatch_data +# define init_or_livepatch_read_mostly __read_mostly +# define init_or_livepatch +#else /* !CONFIG_LIVEPATCH */ +# define init_or_livepatch_const __initconst +# define init_or_livepatch_constrel __initconstrel +# define init_or_livepatch_data __initdata +# define init_or_livepatch_read_mostly __initdata +# define init_or_livepatch __init +#endif /* !CONFIG_LIVEPATCH */ + /* These macros are used to mark some functions or * initialized data (doesn't apply to uninitialized data) * as `initialization' functions. The kernel can take this diff --git a/xen/include/xen/livepatch.h b/xen/include/xen/livepatch.h index 45c8924f3412..416eecb70045 100644 --- a/xen/include/xen/livepatch.h +++ b/xen/include/xen/livepatch.h @@ -20,17 +20,6 @@ struct xen_sysctl_livepatch_op; #include -/* - * We use alternative and exception table code - which by default are __init - * only, however we need them during runtime. These macros allows us to build - * the image with these functions built-in. (See the #else below). - */ -#define init_or_livepatch_const -#define init_or_livepatch_constrel -#define init_or_livepatch_data -#define init_or_livepatch_read_mostly __read_mostly -#define init_or_livepatch - /* Convenience define for printk. */ #define LIVEPATCH "livepatch: " /* ELF payload special section names. */ @@ -145,16 +134,6 @@ void revert_payload_tail(struct payload *data); #else -/* - * If not compiling with Live Patch certain functionality should stay as - * __init. - */ -#define init_or_livepatch_const __initconst -#define init_or_livepatch_constrel __initconstrel -#define init_or_livepatch_data __initdata -#define init_or_livepatch_read_mostly __initdata -#define init_or_livepatch __init - static inline int livepatch_op(struct xen_sysctl_livepatch_op *op) { return -ENOSYS; -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 03 15:26:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 15:26:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381608.1625140 (Exim 4.92) (envelope-from ) id 1wquZ0-0000wy-SA; Mon, 03 Aug 2026 15:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381608.1625140; Mon, 03 Aug 2026 15:26:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wquZ0-0000wr-P9; Mon, 03 Aug 2026 15:26:50 +0000 Received: by outflank-mailman (input) for mailman id 1381608; Mon, 03 Aug 2026 15:26:50 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wquYz-0000wV-Q2 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 15:26:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wquYz-00C8Z0-6b for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 17:26:49 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70b325-5cb7-0a2a0a5109dd-0a2a450b990c-18 for ; Mon, 03 Aug 2026 17:26:49 +0200 Received: from [209.85.221.41] (helo=mail-wr1-f41.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70b334-b7e8-0a2a450b0019-d155dd29dc98-3 for ; Mon, 03 Aug 2026 17:26:44 +0200 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47f92e3c14bso2492538f8f.0 for ; Mon, 03 Aug 2026 08:26:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41e2484sm35099096f8f.11.2026.08.03.08.26.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 08:26:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785770804; x=1786375604; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mmwVO0GCSPE8S03FffRhOAtiOUMzJODrygXLq0JIkfA=; b=IDR/rD/DpKn7sHMysRmuOz1IL35d6BM1/tYTxgxC4ubpAn+6diYiV/F1FXZaaSJmlp KmqH5QwOfkVJwXEUpjb5fLlzBCUlrb0XPQJCyYK/rW3LEAFEhXvrj5dXswTn2mIjKMLq cceeliPG92uENlJNphnY7JGXvNQQ0JLQ3JpEm0x0BE4saIpOaQoptDp+NS6FBukEhNDJ tpD7N4sKcOsDoOpiQa+8LU38zSL1CRjnSfFRR/lAfrkeRGDxQXcgQ1zYBPHtrrZa0Qnh Y/HtC62i7BWb4iR1OmZrw/7scPjpUV7c9BHNxCWYr/rcdXjJoPWhjhXNwK14E4g3MR01 RFEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785770804; x=1786375604; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mmwVO0GCSPE8S03FffRhOAtiOUMzJODrygXLq0JIkfA=; b=q6EX9ZwuqBDI08yjtd+eGn1gA5sAO1tw+IdN+IAQxElDNgF3OROhs3jDOONzRWMeoy vxat+7OAaX5DoYzis3Ntoc1p9aVMQq1M3XGSxSgseTQPpItCibz9YmR+xM3FVnnFdXVl 71H1cNJaIHG/D2/asDgDVFr4ZK3BCqqfm4VoqSHh5rm6QsvWnDlQNtxSP4sH9KEUvlhP lcv97pWFK6PKWM/dWxwfWy9+/I34vu72vAoGHPgNHKXfFGMI+fp0uTqzJ24yaDB1yE5Q E1g8JTXqhPaUxr/a7fHORngiNwdPNq2y6skfw4LJtwhIjZt77A9pSzelUAPscaP+Dziy 5VPQ== X-Forwarded-Encrypted: i=1; AHgh+Ro3poHwx76+vI8eXQaVJvr/Uu1EJnL3pipfg4rD82HqISdgEyVX/ZzKl5mukBoR1TLc9MXPvtENpLY=@lists.xenproject.org X-Gm-Message-State: AOJu0YwCo5njVOjMKcBSkiAk4KY7mXyKNSQO4fQjBq2pVkEUTR60+LOc xc6rAivQaPvCBeglh7x2XLyz9NKnp8xrtRowrmv8jamEHX11GxclA/lNkLpxbVINDw== X-Gm-Gg: AR+sD11zlCpvalFNLhF8OrFIoGAnimO9FkWIYFZ4vG/nu9PW95c63aFk2m1RlfIAaZn W7l5STuGxTyh6qRt+q5ZPaDt6ptxhjtwMpwzeTojiux81HHRJVMhksa0AEhUiLkIddjLD0q+6iX K9GbpXlSAqUo5s0H6EsZyI2o6/Sdf9K5L6tRMoC25xo7MA2WTCeN7Adib+nW3itJ0DCDaBR1ms0 3VjhkX9F0gcbDcGfqGB3rOdAnYY/9XWDbZjUEYOQqRouS6YV++yZwp8uJPm3sdc7T10AAnF1kls /LSbRwLPNyusDJjL2O9WtzZHqBL60uW9t7YYCQXcwxxDW9u8aDARNm7UWiQDYnuLd2cM/PIhioY 98brod6B1Q66QnGz9kGoIHRX/BeidZZ61FZ3RGG2jqO5od8u9NSyDAGKW9M8grUau2waXLco5F/ UXqduwpLHLzYSJisOwi9LWFCNzCi+WChoQLeOYMx0Vbdn+6w41wO69i3D18ezfw8GbmM1Dab8f1 /ge7MdlDq/eNir1wJseSjZAt4AZblenY/V1wcaER8upi1jPAzMv X-Received: by 2002:a05:6000:3102:b0:47f:5a97:2a63 with SMTP id ffacd0b85a97d-47fd729fce9mr29683590f8f.9.1785770803801; Mon, 03 Aug 2026 08:26:43 -0700 (PDT) Message-ID: <01b27228-fdc0-4546-aa23-2bcdafb22727@suse.com> Date: Mon, 3 Aug 2026 17:26:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] x86/emul: Introduce x86_decode_lite() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Xen-devel References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-2-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260803072006.9678-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1785770804-1A8D99EA-4B094D6B/0/0 X-purgate-type: clean X-purgate-size: 12314 > --- /dev/null > +++ b/xen/arch/x86/x86_emulate/decode-lite.c > @@ -0,0 +1,330 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifdef __XEN__ > +# include > +# include > +#endif > + > +#include "private.h" > + > +#undef ModRM > + > +/* > + * Bare minimum x86 instruction decoder to parse the alternative replacement > + * instructions and locate the IP-relative references that may need updating. > + * > + * These are: > + * - disp8/32 from near direct branches > + * - RIP-relative memory references > + * > + * The following simplifications are used: > + * - All code is 64bit, the instruction stream is well formed and safe to > + * read. > + * - Instruction groups and prefixes not used by Xen's current alternatives > + * are not implemented in order to reduce the decode complexity. > + * - Certain instructions are intentionally not recognised, when it is more > + * likely for their presence to be an error than intentional. > + * > + * Inputs: > + * @ip The position to start decoding from. > + * @end End of the replacement block. Exceeding this is considered an error. Why do you mention replacement blocks here? Are we entirely set on this code not possibly gaining any purpose beyond the scanning of those? > + * Returns: x86_decode_lite_t > + * - On failure, length of 0. > + * - On success, length > 0. For rel_sz > 0, rel points at the relative > + * field in the instruction stream. > + */ > +x86_decode_lite_t init_or_livepatch x86_decode_lite(void *ip, void *end) Is there a reason the parameters can't be pointer-to-const? Hmm, apparently for x86_decode_lite_t's "rel" field not be plaing void *, "ip" needs to be this way as well. But not "end", I don't think. > +{ > +#define Imm8 (1 << 0) > +#define Imm (1 << 1) > +#define Moffs (1 << 2) > +#define Branch (1 << 5) /* Near direct branches, which have a displacement */ > +#define ModRM (1 << 6) > +#define Known (1 << 7) > + > + static const uint8_t init_or_livepatch_const onebyte[256] = { > + > +#define ALU_OPS(x) \ > + [(x) + 0] = (Known|ModRM), \ > + [(x) + 1] = (Known|ModRM), \ > + [(x) + 2] = (Known|ModRM), \ > + [(x) + 3] = (Known|ModRM), \ > + [(x) + 4] = (Known|Imm8), \ > + [(x) + 5] = (Known|Imm) > + > + ALU_OPS(0x00) /* ADD */, ALU_OPS(0x08) /* OR */, > + ALU_OPS(0x10) /* ADC */, ALU_OPS(0x18) /* SBB */, > + ALU_OPS(0x20) /* AND */, ALU_OPS(0x28) /* SUB */, > + ALU_OPS(0x30) /* XOR */, ALU_OPS(0x38) /* CMP */, > + > +#undef ALU_OPS > + > + [0x50 ... 0x5f] = (Known), /* PUSH/POP %reg */ > + > + [0x62] = 0, /* BOUND, but also EVEX prefix, not implemented. */ > + [0x63] = (Known|ModRM), /* MOVSxd */ > + > + [0x68] = (Known|Imm), /* PUSH $imm */ > + [0x69] = (Known|ModRM|Imm), /* IMUL $imm */ > + [0x6a] = (Known|Imm8), /* PUSH $imm8 */ > + [0x6b] = (Known|ModRM|Imm8), /* PUSH $imm8 */ > + [0x6c ... 0x6f] = (Known), /* INS/OUTS */ > + [0x70 ... 0x7f] = (Known|Branch|Imm8), /* Jcc disp8 */ > + [0x80] = (Known|ModRM|Imm8), /* Grp1 */ > + [0x81] = (Known|ModRM|Imm), /* Grp1 */ > + > + [0x83] = (Known|ModRM|Imm8), /* Grp1 */ > + [0x84 ... 0x8e] = (Known|ModRM), /* TEST/XCHG/MOV/MOV-SREG/LEA */ > + [0x8f] = 0, /* Grp1A - POP but also XOP prefix, not implemented. */ POP doesn't look all that unlikely to be used in inline assembly, and hence in alternatives. That said, of course using it with a memory operand requires quite a bit of care. I don't see you excluding the PUSH counterpart, though - being consistent for any such pairs would seem somewhat desirable. > + [0x90 ... 0x99] = (Known), /* NOP/XCHG %rAX/CLTQ/CQTO */ > + > + [0x9b ... 0x9f] = (Known), /* FWAIT/PUSHF/POPF/SAHF/LAHF */ > + [0xa0 ... 0xa3] = (Known|Moffs), /* MOVABS */ > + [0xa4 ... 0xa7] = (Known), /* MOVS/CMPS */ > + [0xa8] = (Known|Imm8), /* TEST %al */ > + [0xa9] = (Known|Imm), /* TEST %rAX */ > + [0xaa ... 0xaf] = (Known), /* STOS/LODS/SCAS */ > + [0xb0 ... 0xb7] = (Known|Imm8), /* MOV $imm8, %reg */ > + [0xb8 ... 0xbf] = (Known|Imm), /* MOV $imm{16,32,64}, %reg */ > + [0xc0 ... 0xc1] = (Known|ModRM|Imm8), /* Grp2 (ROL..SAR $imm8, %reg) */ > + > + [0xc3] = (Known), /* RET */ > + [0xc4 ... 0xc5] = 0, /* LES/LDS but also VEX prefixes, not implemented. */ This may bite us sooner or later, due to the VEX-encoded integer insns that there are. Of course as long as we don't use this function on compiled code, and as long as my "x86: allow Kconfig control over psABI level" doesn't come close to going in, that's merely a theoretical concern. Same goes for not supporting the 3-byte opcodes, which also encode certain integer insns. > + [0xc6] = (Known|ModRM|Imm8), /* Grp11, Further ModRM decode */ > + [0xc7] = (Known|ModRM|Imm), /* Grp11, Further ModRM decode */ > + > + [0xcb ... 0xcc] = (Known), /* LRET/INT3 */ > + [0xcd] = (Known|Imm8), /* INT $imm8 */ > + > + [0xd0 ... 0xd3] = (Known|ModRM), /* Grp2 (ROL..SAR {$1,%cl}, %reg) */ > + > + [0xd6] = (Known), /* UDB */ I guess you consider XLAT, LOOP*, and J*CXZ as too odd to use in alternatives? Decoding-wise they're rather easy to implement. > + [0xe4 ... 0xe7] = (Known|Imm8), /* IN/OUT $imm8 */ > + [0xe8 ... 0xe9] = (Known|Branch|Imm), /* CALL/JMP disp32 */ > + > + [0xeb] = (Known|Branch|Imm8), /* JMP disp8 */ > + [0xec ... 0xef] = (Known), /* IN/OUT %dx */ > + > + [0xf1] = (Known), /* ICEBP */ > + > + [0xf4] = (Known), /* HLT */ > + [0xf5] = (Known), /* CMC */ > + [0xf6 ... 0xf7] = (Known|ModRM), /* Grp3, Further ModRM decode */ > + [0xf8 ... 0xfd] = (Known), /* CLC ... STD */ > + [0xfe ... 0xff] = (Known|ModRM), /* Grp4 */ > + }; > + static const uint8_t init_or_livepatch_const twobyte[256] = { > + [0x00 ... 0x03] = (Known|ModRM), /* Grp6/Grp7/LAR/LSL */ Leaving out INVD is surely find, but WBINVD? > + [0x0b] = (Known), /* UD2 */ > + > + [0x18 ... 0x1f] = (Known|ModRM), /* Grp16 (Hint Nop) */ > + [0x20 ... 0x23] = (Known|ModRM), /* MOV %cr/%dr */ > + > + [0x30 ... 0x33] = (Known), /* WRMSR/RDTSC/RDMSR/RDPMC */ > + > + [0x40 ... 0x4f] = (Known|ModRM), /* CMOVcc */ > + > + [0x80 ... 0x8f] = (Known|Branch|Imm), /* Jcc disp32 */ > + [0x90 ... 0x9f] = (Known|ModRM), /* SETcc */ > + > + [0xa0 ... 0xa2] = (Known), /* PUSH/POP %fs/CPUID */ > + [0xa3] = (Known|ModRM), /* BT */ > + [0xa4] = (Known|ModRM|Imm8), /* SHLD $imm8 */ > + [0xa5] = (Known|ModRM), /* SHLD %cl */ > + > + [0xa8 ... 0xa9] = (Known), /* PUSH/POP %gs */ > + > + [0xab] = (Known|ModRM), /* BTS */ > + [0xac] = (Known|ModRM|Imm8), /* SHRD $imm8 */ > + [0xad ... 0xaf] = (Known|ModRM), /* SHRD %cl/Grp15/IMUL */ > + > + [0xb0 ... 0xb9] = (Known|ModRM), /* CMPXCHG/LSS/BTR/LFS/LGS/MOVZxx/POPCNT/UD1 */ > + [0xba] = (Known|ModRM|Imm8), /* Grp8 */ > + [0xbb ... 0xbf] = (Known|ModRM), /* BTC/BSF/BSR/MOVSX */ > + [0xc0 ... 0xc1] = (Known|ModRM), /* XADD */ What about MOVNTI? > + [0xc7] = (Known|ModRM), /* Grp9 */ > + [0xc8 ... 0xcf] = (Known), /* BSWAP */ > + }; What about UD0? > + void *start = ip, *rel = NULL; > + unsigned int opc, rel_sz = 0; > + uint8_t b, d, rex = 0, osize = 4; > + > +#define OPC_TWOBYTE (1 << 8) > + > + /* Mutates IP, uses END. */ > +#define FETCH(ty) \ > + ({ \ > + ty _val; \ > + \ > + if ( (ip + sizeof(ty)) > end ) \ > + goto overrun; \ > + _val = *(ty *)ip; \ > + ip += sizeof(ty); \ > + _val; \ > + }) > + > + for ( ;; ) /* Prefixes */ > + { > + switch ( b = FETCH(uint8_t) ) > + { > + case 0x26: /* ES override */ > + case 0x2e: /* CS override */ > + case 0x36: /* DS override */ > + case 0x3e: /* SS override */ > + case 0x64: /* FS override */ > + case 0x65: /* GS override */ > + case 0xf0: /* LOCK */ > + case 0xf2: /* REPNE */ > + case 0xf3: /* REP */ > + break; > + > + case 0x66: /* Operand size override */ > + osize = 2; > + break; > + > + /* case 0x67: Address size override, not implemented */ > + > + case 0x40 ... 0x4f: /* REX */ > + rex = b; > + continue; > + > + default: > + goto prefixes_done; > + } > + rex = 0; /* REX cancelled by subsequent legacy prefix. */ > + } > + prefixes_done: > + > + if ( rex & REX_W ) > + osize = 8; > + > + /* Fetch the main opcode byte(s) */ > + if ( b == 0x0f ) > + { > + b = FETCH(uint8_t); > + opc = OPC_TWOBYTE | b; > + > + d = twobyte[b]; > + } > + else > + { > + opc = b; > + d = onebyte[b]; > + } > + > + if ( unlikely(!(d & Known)) ) > + goto unknown; > + > + if ( d & ModRM ) > + { > + uint8_t modrm = FETCH(uint8_t); > + uint8_t mod = modrm >> 6; > + uint8_t reg = (modrm >> 3) & 7; > + uint8_t rm = modrm & 7; > + > + /* ModRM/SIB decode */ > + if ( mod == 0 && rm == 5 ) /* RIP relative */ > + { > + rel = ip; > + rel_sz = 4; > + FETCH(int32_t); FETCH() here but ... > + } > + else if ( mod != 3 && rm == 4 ) /* SIB */ > + { > + uint8_t sib = FETCH(uint8_t); > + uint8_t base = sib & 7; > + > + if ( mod == 0 && base == 5 ) > + goto disp32; ... goto here? > + } > + > + if ( mod == 1 ) /* disp8 */ > + FETCH(int8_t); > + else if ( mod == 2 ) /* disp32 */ > + { > + disp32: > + FETCH(int32_t); > + } In several cases the FETCH()ed value isn't used. Compilers as well as Eclair (and alike) are happy with that? And compilers also manage to eliminate the memory accesses then? > --- a/xen/arch/x86/x86_emulate/x86_emulate.h > +++ b/xen/arch/x86/x86_emulate/x86_emulate.h > @@ -835,4 +835,18 @@ static inline void x86_emul_reset_event(struct x86_emulate_ctxt *ctxt) > ctxt->event = (struct x86_event){}; > } > > +/* > + * x86_decode_lite(). Very minimal decoder for managing alternatives. > + * > + * @len is 0 on error, or nonzero on success. If the instruction has a > + * relative field, @rel_sz is nonzero, and @rel points at the field. > + */ > +typedef struct { > + uint8_t len; > + uint8_t rel_sz; /* bytes: 0, 1 or 4 */ Perhaps use bitfields in favor of fixed-width integers, seeing what ./CODING_STYLE says? Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 15:28:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 15:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381617.1625150 (Exim 4.92) (envelope-from ) id 1wqub3-0001z9-C3; Mon, 03 Aug 2026 15:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381617.1625150; Mon, 03 Aug 2026 15:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqub3-0001z2-87; Mon, 03 Aug 2026 15:28:57 +0000 Received: by outflank-mailman (input) for mailman id 1381617; Mon, 03 Aug 2026 15:28:56 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqub2-0001yw-2x for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 15:28:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqub1-005nvY-FN for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 17:28:55 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70b3ad-bab6-0a2a0a5309dd-0a2a4503dc86-10 for ; Mon, 03 Aug 2026 17:28:55 +0200 Received: from [209.85.221.43] (helo=mail-wr1-f43.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70b3b7-fae8-0a2a45030019-d155dd2bad51-3 for ; Mon, 03 Aug 2026 17:28:55 +0200 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47fe377a217so625398f8f.1 for ; Mon, 03 Aug 2026 08:28:55 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd458bf7csm35270409f8f.32.2026.08.03.08.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 08:28:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785770935; x=1786375735; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9hbDzSn/VBQV83BOzqY8ZJiuJKORLuI5AlvgJfHJbW8=; b=bOc5b96NREoydI5ejd95ickBbT6J8mxyULCOOu0kN9YLYSh0v/pljueNfQEjGYhzL+ EyY3ck2qvCcRcBCA9+UegMh8NyyAJYd72WeNDntTruhwZMMFI0vHvw/xZAgJcU3fjphu vfa8c9K41nst/wTPbglZj6mh8YLpH2bcsDV2ojBe3MkOfuRNuHOM7WyS1ami8fPA+C1c sQacar4ppodbo5YuUCBgY19lojaO/5v2UjL5VlWqaRE8SHx+dnasBEzPk/14PrW01v4I m+EW0X3QkEZWNT54nkDUzuFaGJKB2PFSCHSSBdgyUe0jDcMe0rsjNULhJ5TviPGm5FG6 y6Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785770935; x=1786375735; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9hbDzSn/VBQV83BOzqY8ZJiuJKORLuI5AlvgJfHJbW8=; b=r0k0DGOwTSaPtDfj5EQKcHf4p7TtaWS120Q3YmqTzv1BIPAMRHLk5e8dDvnuXoa+jN ExSnnX7rqqJbUh9aaNSOXksX4FQ7FftWmYYr+jLUh5ZLJk2TZyh0KZHG0IP6HyF7tImM GvEsGnAfvaDKxyhxunO5YzNLN34BHa4bZxCwGsU5rzRZ+da0oJ5zVSlGEz5wvmubu9/2 h3YFvx1Wu1knPN8KPU2fnMda2TClMihv5rA3oRHhmu5TkaEur/SrlLIVlsY2rmLBCRvJ 9g3hpCPhgoSe+5iMAXMKYiDx9+DIzkm61FxLw5Jm4v45VjhFIINpblwkKyaNx36LRdem CyWA== X-Forwarded-Encrypted: i=1; AHgh+RrUKxQO5PZ9cWRWLyde+0HHxCWm9H3HPd81CkVAsL1t3WcapJLh8LluhcatIjnwsi3sQwwgEduXvAU=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy6wHWC3BjU5LsJwFBO59fuXmJe9W3hHAG1LjNpslHUySBQZiVP A4TFfNlc9vIfSen93TfeFynw8eH2VGEf6ugMIMsX28gzbqAOyuLLsR/J9ziyz0cREg== X-Gm-Gg: AR+sD11UMmErqHIppuLVpzfoF22NGNPmsWS4pb767guyHwO4h9PkVgUUFE2jW7DLcpc IBBtFYg5oQ45pZdSIYUi/AKO4T6KuPkfXWc2/IZIl28a92sBTCb9p9WdVY56e0bkavV1fNvPBT0 De3Eilsgj/sbbsLA3vxJfPBQ2udv02zpLI+7W1QeZ+Au38lyL0m+loGrBDp0id4hsz6Z9H5ac7x iKsN4Qfj/M+oPZtUFHL9xPNLlPylwqBQF01ISIJO/rcEuQG1+VJzhq15Y/5iMWzxncr1J/7VFwu fMkvrr4AcTqRU5zRL7KXiEB44c5NZeeVEtIULJ7quGIgOYT27GAy0QSGiONqBXvQpHZxJ41KAwe Vs35yiCtvEbgzzn+WOKVBeXSTKVjh5w0+rhad8OkZgIr2vkc1rJ2Ca9Os8uure0baNl5PLlggST +BCSBtQLjii1na3fXYmRDAntW59f9XxT1ETx6lFLCTeHjcO73/y7HLuOvVPhaiJzvqLC1vR2wll JqZNCnA/9BkMKonsoTFEW3eXOhBqb35eiAn8pup5u/U6Mg7jpjyE55MwPN4bBw= X-Received: by 2002:a05:6000:1864:b0:477:47c6:36e5 with SMTP id ffacd0b85a97d-47fd72d2db0mr30889443f8f.25.1785770934785; Mon, 03 Aug 2026 08:28:54 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 17:28:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/livepatch: Move init_or_livepatch_* into xen/init.h To: Andrew Cooper Cc: Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Oleksii Kurochko , Ross Lagerwall , Xen-devel References: <20260803150925.408857-1-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260803150925.408857-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1785770935-6CCDB4E9-EBE93D33/0/0 X-purgate-type: clean X-purgate-size: 760 On 03.08.2026 17:09, Andrew Cooper wrote: > xen/livepatch.h is a fairly heavyweight header pulling in public/sysctl.h, and > a reasonable number of users care only for the init_or_livepatch_* tags only. > > They're arguably more init than livepatch anyway, and by moving them to > init.h, we can remove a number of includes. > > The include in vsprintf was leftover from early versions of the work. In the > version committed, d5ccf4482e4f ("x86, xsplice: Print payload's symbol name > and payload name in backtraces"), symbol_lookup() had been adjusted to handle > the livepatch symbol names properly. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 03 15:38:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 15:38:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381639.1625163 (Exim 4.92) (envelope-from ) id 1wqukI-0004KZ-9p; Mon, 03 Aug 2026 15:38:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381639.1625163; Mon, 03 Aug 2026 15:38:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqukI-0004KS-6y; Mon, 03 Aug 2026 15:38:30 +0000 Received: by outflank-mailman (input) for mailman id 1381639; Mon, 03 Aug 2026 15:38:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqukG-0004KM-AI for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 15:38:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqukF-000inF-G6 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 17:38:27 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70b5db-e002-0a2a0a5209dd-0a2a4507de56-38 for ; Mon, 03 Aug 2026 17:38:27 +0200 Received: from [40.107.208.43] (helo=PH0PR06CU001.outbound.protection.outlook.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70b5ef-b4ea-0a2a45070019-286bd02b57bd-3 for ; Mon, 03 Aug 2026 17:38:26 +0200 Received: from CH8PR03MB8274.namprd03.prod.outlook.com (2603:10b6:610:2ba::5) by LV3PR03MB8003.namprd03.prod.outlook.com (2603:10b6:408:282::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Mon, 3 Aug 2026 15:38:21 +0000 Received: from CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096]) by CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096%7]) with mapi id 15.21.0270.017; Mon, 3 Aug 2026 15:38:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TT8lmlup7esX4SPiDBkwiikbYYEsjqPWeQW5PnoZupzLOnDt3eJAg4ff/3eEap6AhiAUW6X8aSryB7zmkW133NPShedIn6MwbXf6uPrAITyY/JLuC6wfM1Bs0Td2cVxOQdoeIEk81vUrHYbZICXv3WM1uTwVypi8wrY86NOVax8DS+c3NADmjOdE3WIwATwCv3ZCRIVi6N3AHICbH1hbr9MLJv+YMhvzXtyiKx5siLXWImLvYyPuqIj9pUBaEUonEeg1JQ3Z/gfp3WTkhVgTvFquQsprXS6GcyGRBDUNC8tk1dG7RZHP98XVNuEI60zqLZXofpa8Gz9KmDIEiuGT8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5DJbWVherjg++BqI272ogCa9VbVUtKcQHwb55KAWEL4=; b=Sm42Q9yFlFu6P5GN06KyorwMXdqR4yjwwNkoJVE6FsN2ZLCRGf3BzP4icFTd+l98ZqqAVXETllNrc5rgWbxmWRHDnObxk6kC4phmHXL247+43YyR0Ks00CrGZsJHR/eFk5KWI8fLb/ZW2P5R1gvwj4lOlsK7whHGVTzgtXNDjTUvTBmlFGhhhEc4EhxCMyJ8O7+a5jrYjqNDSOXNCPdGK07l60wMaDa2nW9uHgqfrWG3r9L7gK4uXc63JzihDtL+45dxacqneucuKFAwRwpEtj8KrMo7GOlE9qm8bDYb2ED6BMf1u9MHTxwQ46wUObYlUZTGerb9G4/Er2AOf6DBZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5DJbWVherjg++BqI272ogCa9VbVUtKcQHwb55KAWEL4=; b=Ne/MlHL2p/qCK0Qo+DnHoB1fiqcWH5F+BAHayQN+NaO4SXSbC4EANh5R+S5rarEdcJ2gPPT9Car4b1Iy0SXJSW0it6SKIDHXp/b7E1BcOaVU2PW9Hl4jYJ7rHtnfQfYEn4KwcCY/H7amb0w4sZvt43PLTM7q2dbfkcfDlk3Vxto= From: Ross Lagerwall To: Andrew Cooper , Xen-devel CC: Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Stefano Stabellini , Oleksii Kurochko Subject: Re: [PATCH] xen/livepatch: Move init_or_livepatch_* into xen/init.h Thread-Topic: [PATCH] xen/livepatch: Move init_or_livepatch_* into xen/init.h Thread-Index: AQHdI1oaaSQdYQmCuk+Kogsfl3eCaraMcIo9 Date: Mon, 3 Aug 2026 15:38:21 +0000 Message-ID: References: <20260803150925.408857-1-andrew.cooper3@citrix.com> In-Reply-To: <20260803150925.408857-1-andrew.cooper3@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH8PR03MB8274:EE_|LV3PR03MB8003:EE_ x-ms-office365-filtering-correlation-id: 5443ff49-ad3c-450c-0f4b-08def1753f9a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|23010399003|1800799024|376014|38070700021|56012099006|11063799006|10067099003|18002099003|22082099003; x-microsoft-antispam-message-info: +4ZIJoUPZdU0hOhLuhzP0EkCUhEuosfm33phJD29kf+RArB72pV6XccpzBMcBW4jBLzbZb8cATdFpjUUey5XA+/1+FgjWKC99DKqSU8gpnxb7IkM6DeVnG2IpKNyxJovNk/qC49RwCxAVMi52fo3zLncZZkzjLwgx7kRBi/cSDoJ9hqYgryLRSDRkNgdVj2FAjJ2T6HZDgnhUu7RTdZFCqzbxWXtvsr0LBu50Ow+YU9whopZy/gYKJI6Z8DErvRAAzzSQWjmxXkyd7Cq2RInimcqqvbs1o7G95o7rB5btFXQG+au4UO+LfGkds+ha1+ciwD/erdQXPg1TOh6sXnbI5CG8xlBG5liIkA5U/fx2lxe0qs8MH989tNxBZLVrbt/2oquXXTNFmcd9VwWHHF/MOkv/zeSyjUbJpQJRad1WDSjhP6F7Pmeo26bb1pngSgLiUKNsd0+5XIkkEKpIAA31tqaTsThmKepbfsUdzbn3UEzaftaBrlgaBpklXuBGjmWfMDYBR0dj0Hs9GszWYaYHipeuTs5GFjLzzwPbrt0ZgqNAaBcg77jcRxt1v5rCpstiFYiuKSoA01Yq3TUcio8N3KLvB/Gg7ZpgJTGRx84bT+ER7GOxUQ9rZjHWsfaINZAebZOwUEN4u3nF35txeuJrlYdDuWRIY7NnGzVM73jcOI0/o1EQ348wJuKALpD9o90y+pqasF71rlfyK/RCsKF77atfGv3wNziPMsZN5I9ekE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8274.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(1800799024)(376014)(38070700021)(56012099006)(11063799006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?37fWiSXoY/o85LOSLk0ki7kzDkzIUELShyFjzyC6JKXbizvSrUhTiuKEV2?= =?iso-8859-1?Q?ultEjHhQjuwGjN2kZmQnR7fMohNVWuSvKtxZ+UxLcdJ0oWmXBpxO29TRbB?= =?iso-8859-1?Q?sxhGWydkBipezyhofHfKJHFqBIU5RKkprIWmnawKVgQB75ipwNSq4ohPDu?= =?iso-8859-1?Q?RRUIDctOXy/07Y3oBpxUOr3NRMktrjZnvKZpVIRszRQeK5w4wpMAu2ubie?= =?iso-8859-1?Q?ocfGSTf63O1DfkNknRdwBUQvCSqY+iMcVorSH5p7jyL4ozZ38v7h5kiMUl?= =?iso-8859-1?Q?5OfSFj//CoREBXK4RIYm08eVktpN1/B8pyd2GxeUFRtBiYDqZWozW1WFDo?= =?iso-8859-1?Q?DPikRR7IMqTnF1YhU1cu52zPSLPcIQYIWE+1lpfZMaaV1cxok4vBZCmN8r?= =?iso-8859-1?Q?GqguDxpZVNn/COB6vs1Tp6WXUXgLKqacoJwgCQLrwREzu8Y2hcc+XBerIi?= =?iso-8859-1?Q?2Q+wPqOegWy+ml6OMnUH9dbxaFpBh/EIKNMkOPBclFcT7hO+6lluLQW9YW?= =?iso-8859-1?Q?BEnXcaBCvcNQdH036AKpkhv7g9ZpQI/sex4pDNfVbcTcZjNGTlCFccF+XH?= =?iso-8859-1?Q?calPOaSjAH7y05SwdSpIabiB3lre23njHmDVLJeR/vFDUJZSKm65urNizn?= =?iso-8859-1?Q?swZJiyiJf7koXUm3S8kj36N7AaF5eMs26XoQz6GyDj54UVyhcDtMouYuMw?= =?iso-8859-1?Q?9jHYJVye32rl0K5fzQLgYt1tW2yDgUy5lGNFhhRBgjJTRiZ8dVoahXGjRD?= =?iso-8859-1?Q?S2PrN9yCQmkRIB3ON0igXykLeEs7YfL0LW36Xx4tvFubA2KbOfK+B/n35s?= =?iso-8859-1?Q?cDVQ09c5qc7qwlsa/zQNSc5YZC5t6YbpuR5Cqhm+gPbb2oRqG8ECUd+W41?= =?iso-8859-1?Q?bDXq6nY06U8QVgpt1HsPju0ZT0GQ14KqktwkIr7hpTApkpuIU1KrN7oixE?= =?iso-8859-1?Q?3mwAqN+2nHgWzUFpU9D/DveuoK5WS+ezwq7tAcrzT1xVkdut+NmOPp6dGa?= =?iso-8859-1?Q?uAWHv16KWvWlOsROGgTOGNuXwJxtftw2HQHP+CIJzBQt4qmks18oQqU0KJ?= =?iso-8859-1?Q?YJ1fNGox/w1CY9bcIzoMxP81ltLdG1bxbdmFb+bBb/toYxMhLp3UPG8qFy?= =?iso-8859-1?Q?4CeR69Ucz0jX0Fm+h9QDrdEym++pX3mBYLTEgkqbKPLkucvQZWq7f1EGeC?= =?iso-8859-1?Q?6gFct8RboNVIlSeJQFL6D89efk7c7b3xE+lnrUO2UeasbXrcFglObAorky?= =?iso-8859-1?Q?l9l6KAOdyjTwYsvRoIVx7bOtuDw8CdIe9w3vmCv5n1+ZEDl/GRPSLuSWUD?= =?iso-8859-1?Q?lc7Uxwm9QHyYxNgX/P6h9UvJPB4ZoVlS7x+EtXIdl2NtEvxSDYwuGbL4TU?= =?iso-8859-1?Q?JHuKWQ8yr9sMzuwBfVNBmHMr9DEXaeOB5idDWZBPqcy0Uk16YpeedKCFqE?= =?iso-8859-1?Q?k1oMwHbyzMOMeXHpkZqC82otyp15maszBmfjKsn38YSnP2WXmZ1HaGgOdw?= =?iso-8859-1?Q?WVplkXcRc0wGISHpwbTxM+vL133DJxrjlmI4sjqbmZyITt4GHX3QeVf7Js?= =?iso-8859-1?Q?hu0+t76YmbRISRPg5cC9F25PaRVcOns2MTNKxhO5HhqzdbNt0+0krM5YX7?= =?iso-8859-1?Q?XW593Pi5N/iQgS11ViPU/LvVvgVzXaeFslccs9VXrYXpVf7Kn2FfJ7VHVk?= =?iso-8859-1?Q?tXqcK8xW+3Yxq1p+ir4CMYg6utQuDDGh4sf5I8sqw1kVhxrxQV+rOBGjey?= =?iso-8859-1?Q?WMK9bc44/zjKotWEwX5OrZFBKPd5wdg0pGGGYEtk++Eo1kCow9+xJcuo9x?= =?iso-8859-1?Q?gRKV4m6IKA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8274.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5443ff49-ad3c-450c-0f4b-08def1753f9a X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2026 15:38:21.3417 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IyerVeoGFlk3geEim036Oivshq0RIfo9DWtCMQpWsfrGr6U/0SmpOhWvE9Brq6Tj839xWThD69iEVxfrjhh/2KrJzqRJH2gkJE5BU/r/qYw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR03MB8003 X-purgate-ID: tlsNG-ef75cf/1785771506-344CBAE4-87ADAC26/0/0 X-purgate-type: clean X-purgate-size: 1198 > From: Andrew Cooper =0A= > Sent: Monday, August 3, 2026 4:09 PM=0A= > To: Xen-devel=0A= > Cc: Andrew Cooper; Anthony PERARD; Michal Orzel; Jan Beulich; Julien Gral= l; Roger Pau Monn=E9; Stefano Stabellini; Oleksii Kurochko; Ross Lagerwall= =0A= > Subject: [PATCH] xen/livepatch: Move init_or_livepatch_* into xen/init.h= =0A= > =0A= > xen/livepatch.h is a fairly heavyweight header pulling in public/sysctl.h= , and=0A= > a reasonable number of users care only for the init_or_livepatch_* tags o= nly.=0A= > =0A= > They're arguably more init than livepatch anyway, and by moving them to= =0A= > init.h, we can remove a number of includes.=0A= > =0A= > The include in vsprintf was leftover from early versions of the work. In= the=0A= > version committed, d5ccf4482e4f ("x86, xsplice: Print payload's symbol na= me=0A= > and payload name in backtraces"), symbol_lookup() had been adjusted to ha= ndle=0A= > the livepatch symbol names properly.=0A= > =0A= > No functional change.=0A= > =0A= > Signed-off-by: Andrew Cooper =0A= =0A= Reviewed-by: Ross Lagerwall =0A= =0A= Thanks=0A= From xen-devel-bounces@lists.xenproject.org Mon Aug 03 16:03:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 16:03:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381670.1625217 (Exim 4.92) (envelope-from ) id 1wqv8V-0001k2-Kx; Mon, 03 Aug 2026 16:03:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381670.1625217; Mon, 03 Aug 2026 16:03:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqv8V-0001jv-Hc; Mon, 03 Aug 2026 16:03:31 +0000 Received: by outflank-mailman (input) for mailman id 1381670; Mon, 03 Aug 2026 16:03:30 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqv8U-0001jo-5Y for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 16:03:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqv8T-00FOCh-IM for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 18:03:29 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70bbcb-2eae-0a2a0a5409dd-0a2a4507cde2-20 for ; Mon, 03 Aug 2026 18:03:29 +0200 Received: from [209.85.221.47] (helo=mail-wr1-f47.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70bbd1-b4ea-0a2a45070019-d155dd2fb0a4-3 for ; Mon, 03 Aug 2026 18:03:29 +0200 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-472326ca506so2510721f8f.2 for ; Mon, 03 Aug 2026 09:03:29 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd42d91bfsm36196367f8f.15.2026.08.03.09.03.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 09:03:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785773009; x=1786377809; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gR6EXUyY3JxG4Cgz9uSawE1d5EoxywOylNGrSFbS9E4=; b=I+Rc1G573QadXwAZiWQGAtm7nbIA8lpokPQ+FVQC5hWxSe+pCJzlduhCK1/AEyNZxY Ysw2klLoZYHcP68WjCctYP+XdBHqwfm9CTOjzfAI2ndPuRxiPDiwuEoElsh84TV78Ubl F9h36sRP/HCTBJ1ci/KeiB2wE1St1CAESTXGOhwl5NRLJjmJU6wxek5JRkyqiPLEk+py TYaSE2iFL1spzBzl+67G3bMa1KXKAZmfZ4rwJrBJcs7A+FZPKikJNWb4WdnyajiKWW2R cqJSl9gyyAXER4UGOskKWcyDzj/NE8fHbAw2iM2x3o3KJ9ka7zxb0EjzWZmNFrDX5iOC DEGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785773009; x=1786377809; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gR6EXUyY3JxG4Cgz9uSawE1d5EoxywOylNGrSFbS9E4=; b=kYCv+2kDgr9Iy6TtNmP34vRMRuI6bY0/h3Olz2AelzX/SqvgkowgUBmZc3++e5aovO 3ODKO09gcws4Jx5XckspxXZP8Yo+CyiV9w3ko0kOP/syEOaVHDX7QHJ6gPxGx24/tjfw B0ijkUpnzHzyTJsRYwNZawAAAHmLMjnQD8iEPmC0e1Cr3fiQ4O0/zrNoUw/CWz+jALeD zHsTbKYFT4wNPMWz7Erqc7C7TqTeiTEXNcjb8nkcjYVEGCdU5vcCRYAAlW8D4PaRmQut fA5sCBpANY1y8aILxSu/1h3sXdSi2ry5MKhqXSeLo1QMF2Ddf0f0lwnMYCzP7Fm33xCP Hq0w== X-Forwarded-Encrypted: i=1; AHgh+RptA5Sgl5eAk13m3oJv1A3Vu8xw6An+Ex6AQu474paulYWHgH6xQTVonqWXOlVzgWI3ThOoxHdhtuY=@lists.xenproject.org X-Gm-Message-State: AOJu0YyJ1OcGzIqWsh0sTYM71DMtCjJbCa2fZUFFZh43mjmhcJ0T01te miloh6o6po2n1dfTMfj+cr69LXIjU9e6+anv34RGUM//bpQHWUpRjhtTNbrkLh4BZA== X-Gm-Gg: AR+sD11Qp3EGvQpUkWm8MpX53QkbamvgwUkjZqiJNN9vRW0Ymni9nwtc6VVw+euege9 jGrl+XEfdItHmy8lmr+oxiUkS/Gxb3W7DfW1f9NvEBBojA2z6j4nnm/8GIn4acSVP2/RipASD6i 5MiEpBMsLwPx/TyotStpD2/bl9KJUhrMZ4E4DyssYx+biNO20/KGvkO+gmwraY9NPM1C2UIimrc Abm1N6ntox4cy/qO0SSAII49VTiZx2JXUMuCQyPvfN9oUJH/Rprc4RjfMvBqng2RUpQnATZmc8G MelQ25AWeW1kcUsHT37UaEoGLdiOlXEI2c5JNNY3gVDGznycwaoE4qseH3/8ay0O2rpE2nwMt2I oIHSaqV6/H75zaX8/T3wfMeN402IxIS02kN6vL13jX43ukDVuCllEfD22zVax5CVAbXyhZVJrjT NphJqmhz4bMpADAup8PSGDd4rMR2GCjxwIR2rndFfswzjOVJdZznoX/AVxhyLfIdFkCULHehwfc pqNvzAD9t0Oh3fXNKGJvRkuK52XBmitdIqWhjoKPb6BLJJ0oMvk X-Received: by 2002:a05:6000:1a87:b0:47a:b86f:3ed1 with SMTP id ffacd0b85a97d-47fd72c6dacmr26654371f8f.21.1785773008460; Mon, 03 Aug 2026 09:03:28 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 18:03:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] tests/x86: Introduce a userspace test harness for x86_decode_lite() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Xen-devel References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-3-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260803072006.9678-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1785773009-3C411AE4-B99B1469/0/0 X-purgate-type: clean X-purgate-size: 9440 On 03.08.2026 09:20, Andrew Cooper wrote: > --- /dev/null > +++ b/tools/tests/x86-decode-lite/insns.S > @@ -0,0 +1,703 @@ > +#include "macro-magic.h" > + > + .code64 > + > + .allow_index_reg > + > + .text > + > +DECL(tests_rel0) > +modrm: > + /* Mod=0, Reg=0, RM {0..f} */ > + _ add %al, (%rax) > + _ add %al, (%rcx) > + _ add %al, (%rdx) > + _ add %al, (%rbx) > + _ add %al, (%rsp) /* SIB */ > + /*add %al, (%rbp) RIP --> tests_rel4 */ > + _ add %al, (%rsi) > + _ add %al, (%rdi) > + _ add %al, (%r8) > + _ add %al, (%r9) > + _ add %al, (%r10) > + _ add %al, (%r11) > + _ add %al, (%r12) /* SIB */ > + /*add %al, (%r13) RIP --> tests_rel4 */ > + _ add %al, (%r14) > + _ add %al, (%r15) > + > + /* Mod=1, Reg=0, RM {0..f} */ > + _ add %al, 0x01(%rax) > + _ add %al, 0x01(%rcx) > + _ add %al, 0x01(%rdx) > + _ add %al, 0x01(%rbx) > + _ add %al, 0x01(%rsp) /* SIB */ > + _ add %al, 0x01(%rbp) > + _ add %al, 0x01(%rsi) > + _ add %al, 0x01(%rdi) > + _ add %al, 0x01(%r8) > + _ add %al, 0x01(%r9) > + _ add %al, 0x01(%r10) > + _ add %al, 0x01(%r11) > + _ add %al, 0x01(%r12) /* SIB */ > + _ add %al, 0x01(%r13) > + _ add %al, 0x01(%r14) > + _ add %al, 0x01(%r15) > + > + /* Mod=2, Reg=0, RM {0..f} */ > + _ add %al, 0x7f000001(%rax) > + _ add %al, 0x7f000001(%rcx) > + _ add %al, 0x7f000001(%rdx) > + _ add %al, 0x7f000001(%rbx) > + _ add %al, 0x7f000001(%rsp) /* SIB */ > + _ add %al, 0x7f000001(%rbp) > + _ add %al, 0x7f000001(%rsi) > + _ add %al, 0x7f000001(%rdi) > + _ add %al, 0x7f000001(%r8) > + _ add %al, 0x7f000001(%r9) > + _ add %al, 0x7f000001(%r10) > + _ add %al, 0x7f000001(%r11) > + _ add %al, 0x7f000001(%r12) /* SIB */ > + _ add %al, 0x7f000001(%r13) > + _ add %al, 0x7f000001(%r14) > + _ add %al, 0x7f000001(%r15) > + > + /* Mod=3, Reg=0, RM {0..f} */ > + _ add %al, %al > + _ add %al, %cl > + _ add %al, %dl > + _ add %al, %bl > + _ add %al, %ah > + _ add %al, %ch > + _ add %al, %dh > + _ add %al, %dl Perhaps also include %bpl, %sil, and %dil? > +onebyte_row_9x: > + _ nop > + _ pause > + _ xchg %ax, %ax > + _ xchg %eax, %eax > + _ xchg %rax, %rax > + _ rex.w xchg %rax, %rax > + _ cltq > + _ cqto > + _ wait > + _ pushf > + _ popf > + _ sahf > + _ lahf > + > +onebyte_row_ax: May I suggest onebyte_row_Ax? > +DECL(tests_rel1) > +disp8: > +1: > + _ jo 1b > + _ jno 1b > + _ jb 1b > + _ jae 1b > + _ je 1b > + _ jne 1b > + _ jbe 1b > + _ ja 1b > + _ js 1b > + _ jns 1b > + _ jp 1b > + _ jnp 1b > + _ jl 1b > + _ jge 1b > + _ jle 1b > + _ jg 1b > + _ jmp 1b > + > +disp8_rex: > + _ rex.w jo 1b > + _ rex.w jno 1b > + _ rex.w jb 1b > + _ rex.w jae 1b > + _ rex.w je 1b > + _ rex.w jne 1b > + _ rex.w jbe 1b > + _ rex.w ja 1b > + _ rex.w js 1b > + _ rex.w jns 1b > + _ rex.w jp 1b > + _ rex.w jnp 1b > + _ rex.w jl 1b > + _ rex.w jge 1b > + _ rex.w jle 1b > + _ rex.w jg 1b > + _ rex.w jmp 1b > +END(tests_rel1) What's the idea behind the separate REX.W testing? It almost suggests that tests with an operand size prefix also may want adding. Except that's difficult, because of ... > +DECL(tests_rel4) > +disp32: > + _ call other_section > + _ jmp other_section > + _ jo other_section > + _ jno other_section > + _ jb other_section > + _ jae other_section > + _ je other_section > + _ jne other_section > + _ jbe other_section > + _ ja other_section > + _ js other_section > + _ jns other_section > + _ jp other_section > + _ jnp other_section > + _ jl other_section > + _ jge other_section > + _ jle other_section > + _ jg other_section > + _ xbegin other_section > + > +disp32_rex: > + _ rex.w call other_section > + _ rex.w jmp other_section > + _ rex.w jo other_section > + _ rex.w jno other_section > + _ rex.w jb other_section > + _ rex.w jae other_section > + _ rex.w je other_section > + _ rex.w jne other_section > + _ rex.w jbe other_section > + _ rex.w ja other_section > + _ rex.w js other_section > + _ rex.w jns other_section > + _ rex.w jp other_section > + _ rex.w jnp other_section > + _ rex.w jl other_section > + _ rex.w jge other_section > + _ rex.w jle other_section > + _ rex.w jg other_section > + _ rex.w xbegin other_section ... vendor differences here. Perhaps the decoder itself would better reject handling of operand-size-prefixed branches. > +opsize_branch: /* 66-prefixed branches are decoded differently by vendors */ > + _ data16 call other_section > + _ data16 jmp other_section > + _ data16 jo other_section > + _ data16 jno other_section > + _ data16 jb other_section > + _ data16 jae other_section > + _ data16 je other_section > + _ data16 jne other_section > + _ data16 jbe other_section > + _ data16 ja other_section > + _ data16 js other_section > + _ data16 jns other_section > + _ data16 jp other_section > + _ data16 jnp other_section > + _ data16 jl other_section > + _ data16 jge other_section > + _ data16 jle other_section > + _ data16 jg other_section > + _ data16 xbegin other_section Oh, you even cover the case here. For XBEGIN, however, this can only be pure guesswork as to AMD behavior, I suppose. I also don't see how you force which form you want. > --- /dev/null > +++ b/tools/tests/x86-decode-lite/main.c > @@ -0,0 +1,111 @@ > +/* > + * Userspace test harness for x86_decode_lite(). > + */ > +#include > + > +#include "x86-emulate.h" > + > +static unsigned int nr_failures; > +#define fail(t, fmt, ...) \ > +({ \ > + const unsigned char *insn = (t)->ip; \ > + \ > + nr_failures++; \ > + \ > + (void)printf(" Fail '%s' [%02x", (t)->name, *insn); \ > + for ( unsigned int i = 1; i < (t)->len; i++ ) \ > + printf(" %02x", insn[i]); \ > + printf("]\n"); \ > + \ > + (void)printf(fmt, ##__VA_ARGS__); \ > +}) > + > +struct test { > + const char *name; > + void *ip; > + unsigned long len; > +}; > + > +extern const struct test > +/* Defined in insns.S, ends with sentinel */ > + tests_rel0[], /* No relocatable entry */ > + tests_rel1[], /* disp8 */ > + tests_rel4[], /* disp32 or RIP-relative */ > + tests_unsup[]; /* Unsupported instructions */ > + > +static inline void run_tests(const struct test *tests, unsigned int rel_sz) > +{ > + printf("Test rel%u\n", rel_sz); > + > + for ( unsigned int i = 0; tests[i].name; ++i ) > + { > + const struct test *t = &tests[i]; > + x86_decode_lite_t r; > + > + /* > + * Don't end strictly at t->len. This provides better diagnostics if > + * too many bytes end up getting consumed. > + */ > + r = x86_decode_lite(t->ip, t->ip + /* t->len */ 20); For the excess bytes to at least be legitimate to access (not causing UB), shouldn't finish_arr emit enough filler bytes? > --- /dev/null > +++ b/tools/tests/x86-decode-lite/x86-emulate.h > @@ -0,0 +1,27 @@ > +#ifndef X86_EMULATE_H > +#define X86_EMULATE_H > + > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include > + > +#define ASSERT assert > + > +#define printk(...) > + > +#define likely > +#define unlikely > +#define cf_check > +#define init_or_livepatch > +#define init_or_livepatch_const > + > +#include "x86_emulate/x86_emulate.h" Why does this end up being needed? Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 17:20:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 17:20:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381727.1625269 (Exim 4.92) (envelope-from ) id 1wqwLA-0006pL-F3; Mon, 03 Aug 2026 17:20:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381727.1625269; Mon, 03 Aug 2026 17:20:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqwLA-0006pE-CV; Mon, 03 Aug 2026 17:20:40 +0000 Received: by outflank-mailman (input) for mailman id 1381727; Mon, 03 Aug 2026 17:20:39 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqwL9-0006p7-IB for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 17:20:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqwL8-005wQt-Io for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 19:20:38 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70cdd2-5cb7-0a2a0a5109dd-0a2a450aaf30-18 for ; Mon, 03 Aug 2026 19:20:38 +0200 Received: from [52.101.201.67] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70cde4-f2d2-0a2a450a0019-3465c94312ce-3 for ; Mon, 03 Aug 2026 19:20:38 +0200 Received: from LV4PR03MB8234.namprd03.prod.outlook.com (2603:10b6:408:2e3::8) by CO1PR03MB7844.namprd03.prod.outlook.com (2603:10b6:303:271::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Mon, 3 Aug 2026 17:20:34 +0000 Received: from LV4PR03MB8234.namprd03.prod.outlook.com ([fe80::264a:2e82:2064:7fab]) by LV4PR03MB8234.namprd03.prod.outlook.com ([fe80::264a:2e82:2064:7fab%4]) with mapi id 15.21.0270.017; Mon, 3 Aug 2026 17:20:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sQDUWfgloOuBhgGFHAs9LKFSjxN5m3HrWFN/rrazmfKbR4zEKz33sQw+g+lTc7+4BNE07lOE8qyr6DRlGsIG9oIZ2X63NoeoD8+NlfuOThUy2nXcIEk1X97e9sjjGPMqUGuTBdwqA0s+WmQdfFQJpr6Zno8QBx7iBS1wAt5hGThUpn5o7664OnVAmYnf99/rsawE3njOxlv0/zHpRUAeMR2vJscCZbs+JyJECxJQUsdtthIVvseNR1/E8sZct+YnM5GuUh7XfZDxQTOumnYPPTS8Qme7h/DjCXwFXIa5nHi4lPHb01LYSxQbaxb85FE0Kq9PGbKpd97gs+SI2gyEZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=McJSzCrEOR2LSblxBLAbR8WL/F8VFRGO8LEK1pbv4AY=; b=ksvdd48KX+t0nZiRJRkz5W2sKjJLt+Z5r+yPUJaeo6yuquLM+QgW5fI/KVwq+E4/QsB6wBrnQBXG29WrhEK/72uoNJObp3/4bht3GwaDy8Jm8aFObWXYPsfVQBrrXEbiLpdcGzfupGuVq6+9P5K5AqowY96421l0jN/wZnm6kG3fNGbe+KRYL6mQgSMvU4cCJf6l2eFHWXykWjC+gUJ248CuCc/moJoxcuUvV2ShiEbIipdx86EPrY4X6rHzpEhxjXRh9PlxJLm4ihCzdW/3gz5gA07i8xSsTX01PBlZultik1oocLpJHOPMTCi8FdbrQqUCSqOSuu3hYRPge3rBew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=McJSzCrEOR2LSblxBLAbR8WL/F8VFRGO8LEK1pbv4AY=; b=X4ff/j7m0B/uOn3cOa7vwuvZjoZRR8QlkQkDZ/A0Bj8zSHFzVWOkvKcqOmf04KFW6MtA6ylZxAAApsh1mxk15ff23uInBMz1oT7kWtzosZL5Dch6jozapfaXK2pXgihpMy/vyAw9GC6dgoetNK0f7Qn+MCX999TDW9gpL+xbo4g= From: Marcus Granado To: Frediano Ziglio , Teddy Astie CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau Monne , Anthony PERARD , =?iso-8859-1?Q?Marek_Marczykowski-G=F3recki?= Subject: Re: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type Thread-Topic: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type Thread-Index: AQHdGF9mhIhyvqGSRUyPVZ4Z3HHB7rZ3oucAgAJQsgCAAB5PgIAKMo6AgAhhrfE= Date: Mon, 3 Aug 2026 17:20:34 +0000 Message-ID: References: <20260720154832.1907401-1-marcus.granado@citrix.com> <20260720154832.1907401-2-marcus.granado@citrix.com> <1784622046.8631fc262581453bbf619ec5b2062170.19f83c35cd4000edb5@vates.tech> <1784755834.8631fc262581453bbf619ec5b2062170.19f8bbccffd000edb5@vates.tech> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV4PR03MB8234:EE_|CO1PR03MB7844:EE_ x-ms-office365-filtering-correlation-id: 2dc8adee-03c6-4607-bde3-08def183870d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|10070799003|23010399003|376014|1800799024|366016|38070700021|6133799003|56012099006|4143699003|11063799006|5023799004|10067099003|18002099003|22082099003; x-microsoft-antispam-message-info: ai83XngNyv26uaWP2TIu1i2LXQtZvSNRXXPDdBMeALD85fvLZDdLgnTCikrFrmhUnOl0lTW52P5IVVYrIEaGbivG3ipOkpA3Ua1EJR0bjJKOnGV4/6teqrQpzADymFu2pbtrYy3smjFb/qRNh3mJOKPeFd/gslvVPEpJKrbtfs2zhzVOizesBMmV1/UKc5xM1CqPBnjYO4ZtUfDrEuvzUwKwQ43BlbpT5x/OTZiJYzp102X8hrWhiT2FuYn4mEcop1EoVaEIfNd4SzKETLUJvMS7ZxDzdMFXPqTlFh2dHzERQkRFgDD55pk/7sGGYTOTo5jT6cqG+kQy/0On0+P/GzJRxqn3ty27m37VXmXCPRgul5KuKmqlMdr9k70Oq08TuA0mTd7n9Kimkcg/PFAmSz4/ZlYI2WraLKOydWJUeSY03RxY+nqvQ6wfTWNJK0HjlaDb8L/3AOrvPPkQqSK6oTXHJDT3KqSVp56KwX3juhnXiRl84H9tqHDTp4rUcpG8dyIHBzw4hvWAuxQ2zoI+SCTb+YAlGgsCKOwTVXvVX2jXCqq6ZT6q4gR/bfYacdB0vgfThTFOT85YX9hEr023jtXbw4PpgeUAN4OnQlxHi+Qtl+iV4zgaPa0WnkX5sVLEkkDQUUgQn5xG4CaKd+lc4oHOhHANCz2AiBB5Ir2xVXOs200fCfhgZxYz7lp0Hqb4cMuwOGCn+m6DvX69/2/hOHWkeh2mTSFC8cBwyd5QFKo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV4PR03MB8234.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(23010399003)(376014)(1800799024)(366016)(38070700021)(6133799003)(56012099006)(4143699003)(11063799006)(5023799004)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?CV1LCZhFdxcJxtW4v20HQ03VEW6Lm19DNNJez83YIu9AWHLB4L37QYh8d7?= =?iso-8859-1?Q?Brp59IqJl6QmzyPhpWC0ehZNbsZRhA1gA/BnAFQ7/lcbRbs3+CfStRvh96?= =?iso-8859-1?Q?H4ItjBlcn6nHGeK6x9HH9DYI1yRCKYlXddGy2VhfyxmsVIxGTdF6JdIteH?= =?iso-8859-1?Q?JzPQnMzvdgmcx615T50cvwKcUP2rLtGiEhD4qMRRI5NXK5DOHeemJSTiZ/?= =?iso-8859-1?Q?vhEHLE2kg/1e/H3Q4i9T34Jraa9XKNeTPZw4bNvaEo7BlbcGk6XkmP1q/c?= =?iso-8859-1?Q?BNIaTHnUm2488/Q5FZSBzfNtACkFJ8wh7mPstPtmOFv6+XHskicITYZjmL?= =?iso-8859-1?Q?lFHoUTYPsuw+LguZf+wOta+5crV1FMf9ke7DR05xbSFL5T0Kq76O+RzrBB?= =?iso-8859-1?Q?ZqcAUB1loIeHdnwvqCOHiF5VpQIlWy3w4163FV3brVK+bC7K3CJ3iLHw2b?= =?iso-8859-1?Q?KT6aEv17UeVLq++uB6dPVVdDfaZFMuvKpiVmGt+dKXD4Y3DrSvZN7e+eCb?= =?iso-8859-1?Q?19ctMu3td2WZT8ytZ/5fWCTVa3IpJbuwSW+89hy2/UoEg8Wf5c2zf9gFKc?= =?iso-8859-1?Q?jEjcnOOpa44XKfOJaYNV6b1VHw0C0gjfpzFvH9B+wepvMeVl1ZEMLJRxft?= =?iso-8859-1?Q?whONMBUuKFjXUf7Xi+3h6do1qv2ooYxytbegePOEQ+VmoiKRLlQjM0JxEQ?= =?iso-8859-1?Q?RHKL+W4DLwlNFqwf7+X8aKKsltd8zdK6Nb/Ck22lziE7m47+UPOX136tYE?= =?iso-8859-1?Q?OB3zE4BbZHw9l3RPPj7xhq/qWHlLZWUXGo2Yh3DKckoRTZqJ4TWjzMJ+8E?= =?iso-8859-1?Q?iuU9iD5pL76xzZpLJmuLGkK40RqvH6issF3abrnfP+4PIhSZS9znbVW18Y?= =?iso-8859-1?Q?rKruGvUqJ4vEA7Asedwu5JWxyWdZ1DpbOH1pfvBAZKRrqSvqSvyMQ34ZqP?= =?iso-8859-1?Q?OKJQJEvS1EigWGnmezKlCdEm+rvcLi2G8VgWqXBDmR1eyOKpdPxL8ewsq+?= =?iso-8859-1?Q?COKmbJ1joV9M6iPtLqVK/tNpiptLLlF93D/w0V/VD0dBLIDb8BeFlNLpL3?= =?iso-8859-1?Q?MQIwGeZmWpwCieG9hH++VfrCGtjPdlBVaaZC8X1U18sqZeIiiQs+SXhjyd?= =?iso-8859-1?Q?vITmrZND5ImxtHMAIMEu7N047XhROrwo63OiWbyGFvQYQ5+USQnyCYtP+F?= =?iso-8859-1?Q?rf4fuAWev4vxVk/qz1eUCEhE/0lzGuKzkvHEx1HnBiEBQHglehgTKLCNBd?= =?iso-8859-1?Q?3lJFpSvxZHE+Fzz5i8v8GQbb+9WFJFdEZ9/IXrNsL6/1toE+uFgGHpsaRe?= =?iso-8859-1?Q?0CFGhmev089GTmdqm0lUiUq0MZdkV3b6nOno+F7Qxrl37ooVQ790LmpAky?= =?iso-8859-1?Q?4BWlRJMwmBKESZf3u2Xd2VxflQhypzj8JVh0joKQV99TwGPKDK2CNwtbTs?= =?iso-8859-1?Q?Dacq6h+gTn/Gzwl3v+kRKiYV1zhuNzgiJOI+Cm9tp1MTJBzwoRd8WltaUi?= =?iso-8859-1?Q?I3AKlMC0huEAu/Bu3NIwqohOMDZ8qtP1EUPxTZqH5JxZNWZxQBZj03lzjr?= =?iso-8859-1?Q?XsCspqAufJSHgEXx7MQRwEF3QHJCB4H9hNQyJRMcC1/Zxm1IeWExxwAKUV?= =?iso-8859-1?Q?+R/Mb5wj5Vc+g/mFfxNDSrEbAMvVGcEgIVqlo8YRXPAdYtrf93zpMLJCxG?= =?iso-8859-1?Q?e/JrcVjj5MbhRZE7TbaAA/kfnLjn2PgQlskKGTdkdi2Rnu4M6vwUT3UlIG?= =?iso-8859-1?Q?0U8C9QqgBY4qEaCeOxRh2PPjUg6j4EWuBmRy2c26i+4u1LJdqG2LLt8Jga?= =?iso-8859-1?Q?9uG54wwtB6b34tlGBhTzLgM66iEbswFEe+sATmRYRHPcbYA5ypnJfKTrdI?= =?iso-8859-1?Q?6X?= x-ms-exchange-antispam-messagedata-1: oNOkn+7hI2Z4EA== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV4PR03MB8234.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc8adee-03c6-4607-bde3-08def183870d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2026 17:20:34.1814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hMB8AhLHGpRApPy1gWhSVIu3USMA/kkE1siULy1+gj5XYHCR2TW+QuRwFF4MyrmPLz0n6MJ5Gw8nZxvS/qSzqFBoxTdSXjjStSzdPi0Pu4U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB7844 X-purgate-ID: tlsNG-4011c0/1785777638-5ABD8CFC-6497A97C/0/0 X-purgate-type: clean X-purgate-size: 6810 On Wed, 29 Jul 2026 at 10:14, Frediano Ziglio wrote:= =0A= > About compressing all together and considering also the issue of=0A= > memory changing while sending I would vote to copy the memory in a=0A= > temporary buffer to avoid this. One advantage is that it simplified=0A= > the format. The current LZ4 implementation seems to cope with data=0A= > changes but nothing guarantees it in the future, the buffer you are=0A= > passing is not supposed to change while you compress it.=0A= =0A= =0A= Agreed. Frediano and I discussed this further, including simplifications on= =0A= the compression record for v2 so that the page data compression:=0A= * compresses the whole batch together=0A= * and uses a staged copy for it as you and Teddy suggested (so that we do= =0A= not need to worry about mutating buffers affecting LZ4 or other algorithms)= .=0A= =0A= Once there's exactly one compressed blob per record, there's no need for=0A= extra fields to describe the compressed data, as the uncompressed batch=0A= size is known (and bounded by MAX_BATCH_SIZE * page_size), and its=0A= compressed size can be inferred from the size of the emitted compressed=0A= record without a need for an explicit field for clen or a field with the=0A= number of raw compressed blobs. This means the separate PAGE_DATA_LZ4=0A= record type is not needed, and the proposal for v2 compression record could= =0A= simplify to reusing PAGE_DATA and spending one octet of its reserved word= =0A= as follows:=0A= =0A= =0A= 0 1 2 3 4 5 6 7 octet=0A= +-----------------------+-----+-------------------+=0A= | count (C) | comp| (reserved) |=0A= +-----------------------+-----+-------------------+=0A= | pfn[0] |=0A= +-------------------------------------------------+=0A= ...=0A= +-------------------------------------------------+=0A= | pfn[C-1] |=0A= +-------------------------------------------------+=0A= | page_data[0..N-1] if comp =3D=3D 0 |=0A= | or page_cdata if comp !=3D 0 |=0A= +-------------------------------------------------+=0A= =0A= with two new entries in the field table:=0A= =0A= comp Compression algorithm applied to the page contents. 0=0A= means none, and the record is exactly as it is today. 1=0A= means LZ4 block format. Other values are reserved for=0A= other future formats like ZSTD etc. A comp !=3D 0 can only=0A= be emitted if 0 < len(page_cdata) < N * page_size. An=0A= unknown comp must cause the receiver to fail with a=0A= "Compression algorithm not handled" error.=0A= =0A= page_cdata Present instead of page_data when comp is non-zero. A=0A= single compressed object holding the concatenation of the=0A= N page_data entries. The receiver must verify that=0A= 0 < count <=3D MAX_BATCH_SIZE.=0A= =0A= =0A= Teddy, I hope this format covers your points: it's no longer LZ4 specific,= =0A= the inline clen inconsistency in libxenguest record disappears, it's one=0A= block over an immutable copy of the batch instead of one per page, the=0A= decompressed size is known up front, and the allocation derived from count= =0A= is bounded on the receiver.=0A= =0A= =0A= This simplification is also forward-compatible in two different ways: your= =0A= 64KB chunking for cache locality doesn't depend on the format, as the=0A= staging copy can be done in chunks while still making a single compress=0A= call over the whole batch. And if we find benefits in splitting the payload= =0A= into several compressed units, that can be implemented as a new comp value= =0A= using a self-delimiting format like zstd or lz4f frames, which report the= =0A= consumed bytes without a need to specify clen or extra framing fields at th= e=0A= record level.=0A= =0A= =0A= On Wed, 22 Jul 2026 at 20:42, Frediano Ziglio wrote:= =0A= > Don't we need to bump the version number while we add a new mandatory rec= ord?=0A= =0A= I believe we may avoid having to do a version bump if we adopt the property= =0A= that 0 < len(page_cdata) < N * page_size when comp !=3D 0, as in this case= =0A= the compressed data sent to an old receiver would fail in handle_page_data(= )=0A= with "PAGE_DATA record wrong size". Bumping the version would make=0A= uncompressed migrations fail if they are sent to old receivers that also=0A= understand uncompressed migration, so avoiding if possible would be good.= =0A= The spec says migration tools "shall always save images using version V",= =0A= so it doesn't seem like we could bump the version only when compression is = on.=0A= =0A= =0A= > Is there no kind of dialog about the supported version?=0A= =0A= There is no in-stream negotiation, and this proposal does not add one.=0A= Compression is opt-in at the sender via xl migrate --compress, so an operat= or=0A= who enables it against an old receiver gets a clean failure rather than=0A= corruption.=0A= =0A= > Why not extending the generalization compressing all payload of=0A= > uncompressed packets (type+body),=0A= =0A= A composable wrapper would be a clean generic mechanism, but I think there= =0A= are two reasons not to go that way in v2: PAGE_DATA is effectively all of t= he=0A= stream bytes, so compressing the other record types would not show up in a= =0A= measurement. And the no-extra-fields property above depends on PAGE_DATA=0A= specifically: a generic wrapper has no pfn array from where we can derive= =0A= the uncompressed size, so it would need explicit algorithm, compressed=0A= size and uncompressed size fields on every record, which re-adds the fields= =0A= that this proposal tries to avoid.=0A= =0A= =0A= Please let me know if the ideas above capture what you had in mind in terms= of=0A= suggestions to improve v1.=0A= =0A= In particular, I wonder what the maintainers think of the use of one of the= =0A= octets of the PAGE_DATA reserved field for the purpose of indicating the da= ta=0A= is compressed, or is it preferable to use a new PAGE_DATA_COMPRESSED (0x13)= =0A= type record as a mandatory record so that an old receiver fails more cleanl= y=0A= when it doesn't understand compression "Mandatory record not handled= "=0A= (caused by the specification of mandatory records) instead of with a generi= c=0A= error "PAGE_DATA record wrong size" (caused by the current safety=0A= implementation that rejects unexpected record sizes)?=0A= =0A= =0A= Marcus=0A= =0A= From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:13:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 18:13:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381746.1625279 (Exim 4.92) (envelope-from ) id 1wqxAK-0006sb-5r; Mon, 03 Aug 2026 18:13:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381746.1625279; Mon, 03 Aug 2026 18:13:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqxAK-0006sU-2q; Mon, 03 Aug 2026 18:13:32 +0000 Received: by outflank-mailman (input) for mailman id 1381746; Mon, 03 Aug 2026 18:13:31 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqxAJ-0006sN-0v for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 18:13:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqxAI-00CW6Z-5z for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 20:13:30 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70da46-e002-0a2a0a5209dd-0a2a4503978a-8 for ; Mon, 03 Aug 2026 20:13:29 +0200 Received: from [52.101.61.9] (helo=DM1PR04CU001.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70da47-fae8-0a2a45030019-34653d097a90-3 for ; Mon, 03 Aug 2026 20:13:28 +0200 Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by PH7PR12MB6935.namprd12.prod.outlook.com (2603:10b6:510:1b9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Mon, 3 Aug 2026 18:13:18 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0270.017; Mon, 3 Aug 2026 18:13:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=temperror header.s=selector2 header.d=Nvidia.com header.i="@Nvidia.com" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WD6ZOUp+WnBpKUL/Z/T7kHJS3gdbMiHPaDWLnG+FW2Ughc5kivpbHAl9m7v4kZtUlwne3dtTcxUKM7WrJyBjIzNunVwJE8YCw5xf460FYDTOx6lI06pdu9THT47XqNLtDLCdzux8qTLf/nbRDsOOv/8gNbNU4E2T2QAuULs2fA5qQHbM4xHgZv2o0OOWsIgB9IrcShazm0DicLCB2r0EQKH4D6YFHM6X6V09ySI5OEc6n7D3GLeeZQVOXqxWW+VbyMV7HL3rN70ZTujV0k0q4aAXFKUkqMGPn1t6bGDJN5lRp550zxCce4yQxpsqpaiJjD8UiJnfV95Vbq8C+ISS6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eRjbsBRIUTAFpugKKLOjSbZ6YnFTaZPMTTSy9l9apTE=; b=axI4QwD0gDNm37sbZwPepJqFwCIiAQLsRb16JqMJC18kzIbTrEGCymZhb+s+VT3do6EhX/NunZoNzoqNMzdrVPiKGAHzZxXxgE3R9xuo+1Gti7a03F9fRjGK5P50Lt8AxaBXztxd5r9zFCY/UqUcakRm4oUcNJdIAnG/3xc01xoOvlR1WiMD7tpFinSy/n/j8hqvWefCeMnzCgHYzYcPJ8uU/jJoPnMGHd/+YZPkn0JJ2U3O95hflOwGfyepG+2jZsgsMfbSa132CavPOtTL6zLMDpd6I+fzR/hlKcTK94MwK5Xl/bUCYD9mr9kjrEYXGsa4Ph7cigPFSjEaaRhp/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eRjbsBRIUTAFpugKKLOjSbZ6YnFTaZPMTTSy9l9apTE=; b=gxRy5BNSr6u+YqAfadGamez0ES69ulGmVjdQ7wL80choytSsnxQAlwikJcKnY7d7Uw564V87JyMSSqEMqm6I3eyQ8hHwQgGFREoi4hLHlGzS9JCT9FEDSrgt5yoHWS9vKZEID6DWzvgO/uM68mWZ19n7kvMB+gzmij0pdwS5RPmRbSJIRi0JMJdUya8s9PYMz1a0gliFwwRvb7ymFruUVGm7IrQhIxbKxZt2k3pI13FRQ2A68aYiDbfeVVWpfh3Mmt76rm/50mIM4i03A/9AFOI/h98bANBM9Ic5xWGJvoXq7pwmi/JlRG0WcTtM7QctGHIP3ZNoYVG8sNcqXB0SMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 03 Aug 2026 14:13:13 -0400 Message-Id: Subject: Re: [PATCH RFC 00/14] Remove PG_private by using page/folio->private checks instead Cc: , , "Minchan Kim" , "Sergey Senozhatsky" , "Peter Zijlstra" , "Ingo Molnar" , "Arnaldo Carvalho de Melo" , "Namhyung Kim" , "Thomas Gleixner" , "Borislav Petkov" , "Dave Hansen" , , "Mark Rutland" , "Alexander Shishkin" , "Jiri Olsa" , "Ian Rogers" , "Adrian Hunter" , "James Clark" , "H. Peter Anvin" , , "Stefano Stabellini" , "Oleksandr Tyshchenko" , , "Eric Biggers" , "Theodore Y. Ts'o" , "Jaegeuk Kim" , , "Oscar Salvador" , "Chao Yu" , , "Gao Xiang" , "Jan Kara" , "Yue Hu" , "Jeffle Xu" , "Sandeep Dhavale" , "Hongbo Li" , "Chunhai Guo" , , , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" , "Matthew Brost" , "Joshua Hahn" , "Rakie Kim" , "Byungchul Park" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , , "Trond Myklebust" , "Anna Schumaker" , , "Song Liu" , "Yu Kuai" , "Ilya Dryomov" , "Alex Markuze" , "Viacheslav Dubeyko" , "Li Nan" , "Xiao Ni" , , , "Richard Weinberger" , "Zhihao Cheng" , , "Baoquan He" , "Pasha Tatashin" , "Pratyush Yadav" , "Jonathan Corbet" , "Dave Young" , "Shuah Khan" , , To: =?utf-8?q?J=C3=BCrgen_Gro=C3=9F?= , "David Hildenbrand" , "Matthew Wilcox (Oracle)" , "Andrew Morton" , "Muchun Song" , "Lorenzo Stoakes" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Baolin Wang" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Barry Song" , "Lance Yang" , "Usama Arif" , "Gregory Price" , "Ying Huang" , "Alistair Popple" , "Johannes Weiner" , "Qi Zheng" , "Shakeel Butt" , "Kairui Song" From: "Zi Yan" X-Mailer: aerc 0.21.0 References: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> <5ca4d0e4-1747-45a7-a916-a7516bb1692b@suse.com> In-Reply-To: <5ca4d0e4-1747-45a7-a916-a7516bb1692b@suse.com> X-ClientProxiedBy: BN1PR13CA0008.namprd13.prod.outlook.com (2603:10b6:408:e2::13) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|PH7PR12MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 22480e3c-b594-45b3-2d38-08def18ae4af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|1800799024|7416014|376014|56012099006|10067099003|11063799006|4143699003|22082099003|18002099003|921020; X-Microsoft-Antispam-Message-Info: FGtzsi0Ff3pxghP3lc/P1ddrXZKj3w8+yJGJxor6kKDLvhXg+qE0BqULU2Yo4OHklIfrWOBiiWaCcUZnd8ysXvfpjMQVyqBTVvH/b0Q17IDGUvQ8gt4J4mT1pT8nL+gY1FWLJGaajKiB9bLXL2OjTnlzpUnhjYKRFUTTC7RGTKyqFnabJILfF0z8AU4m783vOuMWi1tH6BS67AbjJ4dVCwGPtnKldp5SDaCm2TxXxeP2ZK6wfMDiS18Gr47k19fmlmm0ZUGj0jp67G22umHBdhIuM/sszkroYKwIza/1o1owYO9aVUG8Kv5LLxa3I2WUu8Ak6QcEoCd3A2d3jHYGJW/+RNZgWm8LAjH1uSwDiuMBOFm3gYnB13ZB1YWOVqPwQNKUBqw2XePEUHqKE4fOH9Olf52EBU/o/jip+pXcqLAnmKr38c1u8C6/5d3be9P/UcA7qVZ6LQVHh1HhK+V2a0F4TWz2ERZK7VcaT0nO+9jiux83RgoLv9ibtvBSCrNZX0SkURZ0XZaQ0oYH8g5uGiBx9GzWnhS4/uZIqjBS3kSthtIogVRo5UtaDQmHcm2QBw0H8x81CRrgqFRLK1h46fKWbpTQB7QQyeITnN19I+9mhcOVt1PKHVji0hhO+J6TgRKcsFzS5/DlUr/Fqyiazhpd1b+TgYpo1iieuX06GMveH1pyl1ECk5P3tuqWv1WNYZcGmnoPQLT79hKI5uGaSg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(1800799024)(7416014)(376014)(56012099006)(10067099003)(11063799006)(4143699003)(22082099003)(18002099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXNoMVUva1pWRkd1aHNpSk54cGxMMXZJTnFmUUFPbkhLbnlRdVFGRC9Ueks3?= =?utf-8?B?aUZnZGZMSDNWdS96ZWJFRUNiQzRtejhxdjRJKzRyaGxHUVcwMy82UDRMWUhm?= =?utf-8?B?Q1VCeGJNT1YrbjFDa3pMRFp3WE9VekNKMG5TbXBaejhIK05pbXZwcEVjZjdr?= =?utf-8?B?TlRyV2JuRFZ6QVlaSm9iRWlPUjBTN1ZsTkwrcVcvdURjSXFlcXVHdm5rYVBy?= =?utf-8?B?cTYxazVUcVFFR3NvZU5jQUdjUEhHWVoyQzFvUTRUZDZJdjhRL0hPQ0llVnoy?= =?utf-8?B?ZXRCMzBQbWNteVRPemNMQ3hyTDNzN3UxU3ZkM3h3Rk9BQ1N3TTl1Zzl3NzE5?= =?utf-8?B?SHNIcDZ2S0RVRzNjVENoUVdWZzVXUDJpNzRockZoZjhzT1ROWXhxQjJtc0Nj?= =?utf-8?B?QTRHTTh4a1E5eGJuMWpwLzY3cko0bSs2WUlTQklTekE1Tm9qRVA3dFRmbmRS?= =?utf-8?B?d1Z1eUtZNmJ6aWlJbDBGNVVOb0JNMXdqbEg5eVZlYmJyakxzenB6cEt1OVA5?= =?utf-8?B?SFVBYTllZkhOQXlwU3JZend2NjNLVGxVWmt6b3FlandDdHJrZ3R1Y3N4RVNt?= =?utf-8?B?MHdCTmpsNTc3b3lLYnkySXlhZDVaQVZZQmZFTElscUdhakFGd2xibS9NajVV?= =?utf-8?B?TmxCYzk2bmIwLzZXWnF6NFhsMUFHTUZMMGN0R25vaFllczhkVXFaSVdtZyt3?= =?utf-8?B?MlJ4NXA4VFVaWUw5c1FvMXg0UWdLUkxKUk8vMWlBeUJ1M2k2NjlFcGc2RDc3?= =?utf-8?B?aGk1em1DbnFlSUN4b3Z0S2p0UlQ2dEdhRXJaZ0FhLzVkN2MxQS9tekRKS1ZR?= =?utf-8?B?Vy9tRkpMWmdaZ3hUcGtDL2lPTHN5YUFpa1JJY0N1Q2RCWVUvSXlCRFJpOEEy?= =?utf-8?B?YVFkb1RHaVVCcm9oNU1wTmp0ZHZDazQ3QkRoTDRwR2gvT1gwUW1VUzd1MTR3?= =?utf-8?B?dHBzZXdWOTkrck81QXRjUDVHOFo2ZUUvazRpc0xYSDd3MUg3V1FGZjV6dVA2?= =?utf-8?B?VlhRUHRaOGJ5SnlTT1d6WUV2TG5VdHA2R296TW5KZ2pnWGtxbFpqSTZDeC9p?= =?utf-8?B?TDE4TFRzMkwrMmhrR2h6dTZwb3hXYkxTMkl0Z0dtRmE1RFNtZDZ3eHpGdDVG?= =?utf-8?B?N1Q1SWRvQlZEQzhlUHhzSFMvc3JkaVliZG5OZlZySGkrYXl2UVlJZENtR2NX?= =?utf-8?B?dUc1cWNRYjhidlNzN0VOTFBwYUpwMytFRmJQejc4MXUxNnNWaTA0MytrYm1W?= =?utf-8?B?U0NCM0gxSlNZd0tiTnJoeTIzZGlxYmdVajdqeTFOYVdKcEYxQXhqdU9aVVVK?= =?utf-8?B?NDM0U0xSaTdBT3NrTWpxdTFldTdJblVLbGFvanBSTW92cVhBYmhINnFlNDY2?= =?utf-8?B?WWRPSGIrVUh6Mm5sY1RBS2huYkwxZlJnMkNmQ3pFUitwYUg5K2drOGhMZEJH?= =?utf-8?B?VFpldlFLdzN3NXJYNDVWa0hSaGxiaHpQWjJlTFcwNTVxbG1uWXdlcm1HS3dj?= =?utf-8?B?RXhNdkRSTGNxdUVhSENVeHB4eGZZeWFRbnZFczdZbFNNMkl6b3pjT2tiK01u?= =?utf-8?B?TGtwQXlxN3lIWitmTUpiL3Vyckw5cHdHQTZwT3NrR0t5ZEYxRERQZVZqd0hX?= =?utf-8?B?MlFiUTFCNkJ1UTJPTTl5MEkrS1d3U2hTQnN0TExUdUxodVVvelJ2VFFDb1ZH?= =?utf-8?B?cEJ2YnhIZGtRSVVSZjRoWFU3V1o3NytYOW5COXJ2dVR2aUNQMmVoaHg4ZEFy?= =?utf-8?B?TDhGTXpYUEZTVUM3dHA4SzhKYjR0ZVVVbEROa3BrR3VHYmRVRlVHYS9yU0xl?= =?utf-8?B?dzc5bUlPWjM2R0Yvdm4rc0xLRnZZd3hYbnFDVG9BeEN6b2dqa3dQVDlHV3g1?= =?utf-8?B?dTBhWGpyVStjODlOYmJlUkJjVVM3WS8yaUtpaGhDN2M5UjhlR01qZGdVdmRZ?= =?utf-8?B?RHVuZHB2K2FFQ0tPSXFLdW10cVZsQ3ljSGNIbm9GaGlzb0lETi9WcmZ0ZHZC?= =?utf-8?B?cGJpQnpFUmpLc3UrRDNMVi9kaHloUUVhdjhTb2I5dUNWVFc3MlZkbmk0Z012?= =?utf-8?B?MmtxVUJOSnRBTElMVGNQeUJaOXhDbGNrSElrdFQ5VnAycDRrS1c5QVZ3VXF2?= =?utf-8?B?NGd2TXhnK25kNFhtdUwzU3RoWE1BaHpnNzYwVW9nek93dXJNaHhNMEo1QlFz?= =?utf-8?B?Q3haWDFpZkhkL0FXRlpsQzFLUzZiSHRYYTlvUWRXbmRVY0tpRDFORG9CaDBj?= =?utf-8?B?OE9CVlZrcFRhWDhTQlZ6c0Fnc3BRdmRZeHZQcWhDbFJaZlFrcUxFZTRtVVJl?= =?utf-8?Q?vOMDLuS+uZ6B+uZb7U?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22480e3c-b594-45b3-2d38-08def18ae4af X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 18:13:17.9727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P4jLnqIwTNmEW1LtTpM+2MhjKsFG8QpvIYdQ6DM5UZU3RRUlEMTS746tqky9GXuA X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6935 X-purgate-ID: tlsNG-33051d/1785780808-6C2E04E9-3D22F222/0/0 X-purgate-type: clean X-purgate-size: 1339 On Mon Aug 3, 2026 at 5:07 AM EDT, J=C3=BCrgen Gro=C3=9F wrote: > On 01.08.26 04:13, Zi Yan wrote: >> Hi all, >>=20 >> This patchset removes PG_private to make space for upcoming PG_folio >> (reserved as __PG_folio) for identifying pages from a folio (more detail= s >> in Note below). Instead of checking PG_private, all code is changed to >> check page/folio->private !=3D NULL instead. > > I'm a little bit worried that page/folio->private is in a union, so today > it could (in theory) be !=3D NULL while PG_private isn't set. > > Is it really not possible to enter a path where PG_private is tested whil= e > page/folio->private !=3D NULL due to the union being used otherwise (PG_p= rivate > not set)? Yes, it is possible. See: #5 in the exceptional users: erofs uses ->private for reverse linked list and in-flight counters without setting PG_private. I get rid of the first one and converted the second one to use folio_attach/detach/get_private() to follow the general ->private use pattern.. For non file system folios, anon swapcache puts swap_entry_t in ->private and hugetlb puts its flags in ->private. I added folio_test_fs_private() to exclude them, but this helper is planned to be used by core MM, since filesystem code should not encounter these two. --=20 Best Regards, Yan, Zi From xen-devel-bounces@lists.xenproject.org Mon Aug 03 18:47:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 18:47:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381762.1625287 (Exim 4.92) (envelope-from ) id 1wqxh3-0003pK-My; Mon, 03 Aug 2026 18:47:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381762.1625287; Mon, 03 Aug 2026 18:47:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqxh3-0003pD-KQ; Mon, 03 Aug 2026 18:47:21 +0000 Received: by outflank-mailman (input) for mailman id 1381762; Mon, 03 Aug 2026 18:47:20 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqxh2-0003p7-85 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 18:47:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqxh0-00Fim2-BI for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 20:47:18 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a70e22d-5cb7-0a2a0a5109dd-0a2a45038af8-6 for ; Mon, 03 Aug 2026 20:47:18 +0200 Received: from [160.101.131.8] (helo=na1pdmzitismtp01.tibco.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a70e235-fae8-0a2a45030019-a0658308bfc6-3 for ; Mon, 03 Aug 2026 20:47:18 +0200 Received: from fedora.eng.citrite.net (unknown [10.113.40.46]) by na1pdmzitismtp01.tibco.com (Postfix) with ESMTP id EE4E9440E018; Mon, 3 Aug 2026 14:45:39 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; none From: Abdelkareem Abdelsaamad To: jbeulich@suse.com, xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, jason.andryuk@amd.com, Teddy Astie Subject: Re: Re: [PATCH v2] nSVM: Check injected event consistency Date: Mon, 3 Aug 2026 19:44:09 +0100 Message-ID: <20260803184412.2323732-1-abdelkareem.abdelsaamad@citrix.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785782838-6ECCB4E9-95CB2077/0/0 X-purgate-type: clean X-purgate-size: 2194 On 03.08.2026 07:12, Jan Beulich wrote: >On 31.07.2026 16:26, Abdelkareem Abdelsaamad wrote: >> On 28.07.2026 14:04, Teddy Astie wrote: >>> On 16.07.2026 17:41, Abdelkareem Abdelsaamad wrote: >>>> --- a/xen/arch/x86/hvm/svm/vmcb.c >>>> +++ b/xen/arch/x86/hvm/svm/vmcb.c >>>> @@ -320,6 +320,31 @@ void svm_vmcb_dump(const char *from, const struct vmcb_struct *vmcb) >>>> svm_dump_sel(" TR", &vmcb->tr); >>>> } >>>> >>>> +static bool is_valid_svm_vmcb_injected_exception_vector( >>>> + const struct vmcb_struct *vmcb, uint8_t vmcb_injected_vector) >>>> +{ >>>> + return ( (vmcb_injected_vector == X86_EXC_DE) || >>>> + (vmcb_injected_vector == X86_EXC_DB) || >>>> + (vmcb_injected_vector == X86_EXC_BP) || >>>> + (vmcb_injected_vector == X86_EXC_OF) || >>>> + (vmcb_injected_vector == X86_EXC_BR) || >>> >>> This particular exception is special. AMD APM states that this event is >>> "impossible" if the guest is in 64-bit mode and will cause >>> VMEXIT_INVALID in such case. >>> >>>> If the VMM attempts to inject an event that is impossible for the >>> guest mode (e.g., a #BR exception when the guest is in 64-bit mode), the >>> event injection will fail and no guest state instructions will be >>> executed; VMRUN will immediately exit with an error code of VMEXIT_INVALID. >>> >>> So this one likely want a additional check for hvm_guest_x86_mode() != >>> X86_MODE_64BIT. >>> >>> It looks like #OF has the same quirk (invalid in 64-bits mode). >>> >> I agree your point is valid. I will address in V3. >>> Though I don't know if any other exception has a similar behavior though. >> I have double-checked the APM vOL3(24594—Rev. 3.37—jULY 2025) regarding the >> other exception vectors and instructions. Vector 4 (#OF) and vector 5 (#BR) are >> unique because their triggering instructions BOUND and INTO are invalid and >> disabled in 64-bit mode, making them structurally invalid. Other vectors remain >> legal across the other modes. >#BR is also used by MPX insns, which are usable from 64-bit mode. I think this is only relevant to Intel's VMX, not AMD's SVM. >Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 03 21:02:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 03 Aug 2026 21:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381811.1625297 (Exim 4.92) (envelope-from ) id 1wqznJ-0000sm-S6; Mon, 03 Aug 2026 21:01:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381811.1625297; Mon, 03 Aug 2026 21:01:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqznJ-0000sf-PQ; Mon, 03 Aug 2026 21:01:57 +0000 Received: by outflank-mailman (input) for mailman id 1381811; Mon, 03 Aug 2026 21:01:55 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wqznH-0000sD-Gl for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 21:01:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wqznF-001NVQ-Q0 for xen-devel@lists.xenproject.org; Mon, 03 Aug 2026 23:01:53 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71019e-2eae-0a2a0a5409dd-0a2a450cb198-44 for ; Mon, 03 Aug 2026 23:01:53 +0200 Received: from [52.101.57.43] (helo=BN8PR05CU002.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7101bf-f479-0a2a450c0019-3465392b139c-3 for ; Mon, 03 Aug 2026 23:01:52 +0200 Received: from CH0PR03CA0205.namprd03.prod.outlook.com (2603:10b6:610:e4::30) by SJ0PR12MB8140.namprd12.prod.outlook.com (2603:10b6:a03:4e3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Mon, 3 Aug 2026 21:01:44 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:610:e4:cafe::d) by CH0PR03CA0205.outlook.office365.com (2603:10b6:610:e4::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.18 via Frontend Transport; Mon, 3 Aug 2026 21:01:44 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.0 via Frontend Transport; Mon, 3 Aug 2026 21:01:44 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 3 Aug 2026 16:01:44 -0500 Received: from [172.19.79.34] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 3 Aug 2026 16:01:43 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iTyKZXx5jeJeCIi21orKLBttZSXFVh0ZEMjO0I+DB6YmoLYd6LMI8tVdAhZxRvNsv/EGXNeQ0Gj9H11Q+3nRYo5IwgyRqRFPa7GMSwEbcxOHgbCgZbI7mBEA43mUrQHYofkxt+npcB+zezD6Z+bvzO9WiHtpoFVObp5nqCa1oZg5nD8vtdowIy4lAkTslVCBiEElcwQ8iU0Pl1qUns8dfadfyG1JZzHCFsIYC1X1nlFl8GSNhNYBAL6vIyARdC+sfU+EotK03WTPNVZZzrNpC48uf9OYhkRScD4PYN3RIPk33IxiSTwC8GA/LfCK1Pj4jEBEzqF5LV/KFVuTZKaBUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8aPzKaT4Ch3aMYTEO4glCQqrnHCy3HTBrxMY75ZeYh0=; b=e7mlNv3pYLMg2wFj7zcCh5jn4eznJPSXZOO8lZrtixXJXfpv9NXrCxoSjhgFJMxCkGoEkhM+D1F1KIBqtS74pbXZeZUb0BGxnuF6O5VYoweDP+vyXZVxiLVLyhsf63NTR+LSJFlXeX9cbD7ZryVCAeGV9uzyseO+ITNO8VH6N1Rth6+YABxqM4BZlsrTu0+BUjdElKwVZLY7yGi79HIKBWOeVXxa4PxWZfxg9mfv27KtiZGJ1pwGXN6/Bswqg/6cQjd3nRL/XST8WPriUsTWApdGU27ZXHZUnC4FWL7zgUXSOnA8QxjujGfOxHF4QPu1dZfuDUYozTV02166hWsKeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8aPzKaT4Ch3aMYTEO4glCQqrnHCy3HTBrxMY75ZeYh0=; b=2kEkQtYQXO5+nEB8js2YM3LTGgVD244sIbWyTHVhDnBBl7FGt0eB2tEEZ08xgLufigu0O7lhLo10ej2/VfY/kMFtnj1g9HzqPcokmfyCEpI4HRzm52ymLBVJZv2AhuoOGtvYLDF4txDLsIiWjBldVyLqLLiPhzYuiG7XYa450Jc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Message-ID: Date: Mon, 3 Aug 2026 17:01:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Daniel Smith References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> Content-Language: en-US From: Jason Andryuk In-Reply-To: <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|SJ0PR12MB8140:EE_ X-MS-Office365-Filtering-Correlation-Id: af729bf2-2f5f-4cdd-3855-08def1a26cb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700016|23010399003|376014|4143699003|56012099006|11063799006|10067099003|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: t1fDly2XTT0moDZX478LchSyX7SBgmm3cYknyOLVHAAfgXbCkTnAZfNLtY2gOtxp3wxrTuN7r44Zn9e+Ct+jOWN1df1SkbxUZJZ879k6QP27JT3ZdjUgSQoK5nzSShh1vu7W5Zo+xQnbQ5fpS58R2YAhE+UiMXRVV+tJgEdLonrqaBR9+3nKD65LmLf4k50P1ctmFhIXp28j0dj98cW6hYOtjMAUs+ID6sP32HzEAQNTqQL6utoTZWSoXMMcU2rjP2gJ2xc9lVUQkvI7qh907SVJmqTXCNMMrikF8GSQdlj/CNbms3oWu7js/vgndSblPoqv2R7IQc4YNPjFeVCCGQH9ONw3oGleOpb7adHvPYYbGtkm+voZSg0AIpW26Z5HnLb+ICQ2JhDbZcQOSyKVoyuw7LFYo3xr1j3VHseXwA131g5HttQd2VN6Zm0ufKXQu+J2ZqhtqffO4ZDO6eN3AgVlwrr8RhP9YMGzTfEEBRiDmALX2csFUucFWsLjrDFe4iRG3PSUu+xDH97YOU+ggAlo/Vyt5+CsOtALAduGeRuYijlHS3jgDftAxT9FMyFvbYwzS0gVu0jlmj0DA2oJXuwFEJRi3jJeo1SubPR0Jbu2DKtz/oHsw0sqyZBjMaGGQfHe7OpHI/mGN8Dq2oX7kCkkxT9iQV044rYTPJZo4LMHilNF8JGbs77gCfyeXdE/9df+kQELy0WoFHLaQsitQQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700016)(23010399003)(376014)(4143699003)(56012099006)(11063799006)(10067099003)(18002099003)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lx8CjabBpQ9+DPM4RDKSkLBF+bih6AFioW/MOTJtFRMkdRCdZFJPYIeldvHZYU/Q6UEHuGTKZXy1hRxUeVkSRFjuH6yPuFKvQQL4FdFMCrBAZ8IiCKl8xF1B8Cy/gsKvPZ6NGJ7/kF9cA6M4NqemhThOStWj9F5OoEDQkCf1jpO1an3yrYhHbyQGrsBYglan2uGijgJzDai9SKxnvfC5KlhnWFmbiVfMpQN9y6qZofYFNFqwvxVbufpYGe8kIFWiAYL23a+PCY7mMTZq5+0mVYlkrxF3574TtW4pMrXRfRlU/l1ExLcnL3kZjVjYDAYQMz5YiMigCBdVrcjdYqhbWQ0nfSZFpVKUQ8s74a/I6X3ptvYpaHUYMRCOu/PVETmKvBhWKyXx8yfXEiNwo3g0MV8zBBs1CMe9dBGCewJFRr42rZWsXQ8/cScmaiWsPfAE X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2026 21:01:44.3467 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af729bf2-2f5f-4cdd-3855-08def1a26cb1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8140 X-purgate-ID: tlsNG-d25034/1785790913-77ED2A5B-A1409A0E/0/0 X-purgate-type: clean X-purgate-size: 2449 On 2026-07-28 09:22, Jan Beulich wrote: > For whatever reason they didn't have an xsm_default_t first argument (to > cope with XSM=n mode), making it impossible to (easily) cover them in > xsm/hooks.h. > > To be able to retain the const on their function parameters, adjust > xsm_default_action() accordingly. > > Signed-off-by: Jan Beulich > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -751,27 +751,32 @@ static XSM_INLINE int xsm_dm_op(XSM_DEFA > #endif > > #ifdef CONFIG_ARGO > -static XSM_INLINE int xsm_argo_enable(const struct domain *d) > + > +static XSM_INLINE int xsm_argo_enable(XSM_DEFAULT_ARG const struct domain *d) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, current->domain, d); This one I think should be return xsm_default_action(action, d, NULL); Usually current is passed in for the check, but for domain_create() -> argo_init() it is the under-construction domain. > } > > static XSM_INLINE int xsm_argo_register_single_source( > - const struct domain *d, const struct domain *t) > + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, d, t); > } > > static XSM_INLINE int xsm_argo_register_any_source( > - const struct domain *d) > + XSM_DEFAULT_ARG const struct domain *d) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, current->domain, d); Similarly: return xsm_default_action(action, d, NULL); The single call is: xsm_argo_register_any_source(currd); These argo hooks all pass in their arguments explicitly, so I think we should do that and not use current. (The send and register hooks could use current, and that could make sense as those map to hypercalls. But it is correct today with the explicit arguments.) With the changes: Reviewed-by: Jason Andryuk Thanks, Jason > } > > static XSM_INLINE int xsm_argo_send( > - const struct domain *d, const struct domain *t) > + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, d, t); > } > > #endif /* CONFIG_ARGO */ From xen-devel-bounces@lists.xenproject.org Tue Aug 04 00:54:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 00:54:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381834.1625307 (Exim 4.92) (envelope-from ) id 1wr3Pk-0004J7-5y; Tue, 04 Aug 2026 00:53:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381834.1625307; Tue, 04 Aug 2026 00:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr3Pj-0004Iz-Vu; Tue, 04 Aug 2026 00:53:51 +0000 Received: by outflank-mailman (input) for mailman id 1381834; Tue, 04 Aug 2026 00:53:51 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3GzhxagYKCaocOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 1wr3Pj-0004It-Lk for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 00:53:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr3Pi-001mWE-5c for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 02:53:50 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3GzhxagYKCaocOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 6a713812-2eae-0a2a0a5409dd-0a2a45098ad0-14 for ; Tue, 04 Aug 2026 02:53:50 +0200 Received: from [209.85.215.199] (helo=mail-pg1-f199.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3GzhxagYKCaocOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 6a71381c-be1a-0a2a45090019-d155d7c7d942-3 for ; Tue, 04 Aug 2026 02:53:49 +0200 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb4bd11ddf8so4700936a12.3 for ; Mon, 03 Aug 2026 17:53:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785804828; x=1786409628; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KFqZcLCrY5f3+v3uGjD/c1GxsX1WczytwYYei8eRc4I=; b=DTnJdb9gae+0dN3jsn5oTQ3E3AxFA628rxnLCUMIiK8+IaZHNvxiQXiFQeNiVHhYE2 OhRuw1tvmfhlI1LCFqPPBWvhe2VLiJSi8Xhgtsp9PRuJ0sOS53kuIEpPUR2m0RrNYOOF 5RsVSlelNxwEfgEQlIMqRMvfd//SZAkJF67Dm/N/L6Nr9XTBY0mfKgv6G0dLlq6h5Fnv S+kV7bD/EQTDaIPLT/oNi99wbOSKGvJ3J3DomB6omQu9WxBAJlUdn3IT9Oh7iM1V5INp G0CbyaMd7brI4VrDNBxDXgu7vRNQsjo2hgYM607edcFCrcK3sbPKhy0LpPKRvKpoR88j cMdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785804828; x=1786409628; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KFqZcLCrY5f3+v3uGjD/c1GxsX1WczytwYYei8eRc4I=; b=eurGQBdyhYZ9u3J2Rl7d3Ln6Z+FwLbE0yvwZzw1SYwfnFoc7JopJxdmUEfzvO2929Z 6M+r4Aq7/O3ZakPtVcv8EBwK/9APnz1XLwyBwrSL5ouORwpwhUPjbFwNy5t5XPW6ERN1 iHTLhlhKmRNbE01XXp5V9Hiu4v0Htj9Eg2RXLKv7yzONRO6dlrn7GY5sycgjLAg3C9bK +4tjeAyIzBaIGPNTL6W1IJoZbo22stLRZeXjxZUCcCgXbgDAn9aln9twuKdE7lduKWQh ttxVMsEl9aOGW6pfHGmiOeFuDhpB6KjVoezdT0seHbHOWKK/wZjtHsHvnJyDp28h/Rt5 t3oQ== X-Forwarded-Encrypted: i=1; AHgh+RpkvQwrVHLLLWD2Yb8FGplbz22fU8B6SXi/+wywrYuppUCq+G30WUqk6UXYanABMytsqiFNMefe5Mw=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw4cLgI6bz88oBQp0/ektlHLPW96LcN3cn14C4LfgjJWPLjFHa8 BE3zlOBDV7c26HS3Popw8fByd7zP+Y7enxuUbsMG7D/ZLGSE5d6cpsiPN3ExZu+BqPK5vk0zvUb aMaq5WA== X-Received: from pgke23.prod.google.com ([2002:a63:f557:0:b0:c85:98b1:c613]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:3397:b0:3c3:a140:9392 with SMTP id adf61e73a8af0-3c92a28f176mr12976405637.0.1785804827335; Mon, 03 Aug 2026 17:53:47 -0700 (PDT) Date: Mon, 3 Aug 2026 17:53:46 -0700 In-Reply-To: <8b90851f38ef5b10cdcdc70e7543bd6b0b5e2773.camel@infradead.org> Mime-Version: 1.0 References: <178552799129.2700794.10181439022561913222.b4-ty@google.com> <8b90851f38ef5b10cdcdc70e7543bd6b0b5e2773.camel@infradead.org> Message-ID: Subject: Re: [PATCH v6 00/36] Cleaning up the KVM clock mess From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-bad1c0/1785804830-BCECE034-7A1A16D9/0/0 X-purgate-type: clean X-purgate-size: 1522 On Sat, Aug 01, 2026, David Woodhouse wrote: > On Fri, 2026-07-31 at 13:09 -0700, Sean Christopherson wrote: > > Applied patch 1 to kvm-x86 clocks. > > > > [01/36] KVM: x86/xen: Do not corrupt KVM clock in kvm_xen_shared_info_init() > > https://github.com/kvm-x86/linux/commit/3d4b20b5a7df > > Thanks. Could the clocks branch be based on something that includes the > timekeeping work from the timers-ptp-2026-06-13 merge (in v7.2-rc1)? Yeah, I can rebase onto a 7.2-rcN. Y'all are likely the only people that care about the above commit, so a late rebase isn't a big deal. There's basically zero chance I'll get the entire series applied for 7.3, but "Use ktime_get_snapshot_id() for master clock" is at least in striking distance, so there's no reason not to allow for the possibility. > The later parts of the series depend on ktime_get_snapshot_id() and the > reworked struct system_time_snapshot from there. Your kvm-x86/next > branch does have it; I'll keep my WIP kvmclock8 branch based on that > for now as I address the other comments. > > > * 2d6d57f889f3 Merge tag 'timers-ptp-2026-06-13' of tip > |\ > | * bc484a509673 ptp: vmclock: Use hw_cycles from snapshot for precise TSC pairing > | ... > | * ca1ec8bfac8c timekeeping: Add clocksource read_snapshot() method and hw_cycles to snapshot > | ... > | * ef22786707e3 timekeeping: Use system_time_snapshot::systime/monoraw instead of ::real/raw > | * eba302268a01 timekeeping: Provide ktime_get_snapshot_id() From xen-devel-bounces@lists.xenproject.org Tue Aug 04 01:26:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 01:26:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381844.1625314 (Exim 4.92) (envelope-from ) id 1wr3v3-0000X4-FM; Tue, 04 Aug 2026 01:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381844.1625314; Tue, 04 Aug 2026 01:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr3v3-0000Ww-C0; Tue, 04 Aug 2026 01:26:13 +0000 Received: by outflank-mailman (input) for mailman id 1381844; Tue, 04 Aug 2026 01:26:12 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3sD9xagYKCU89vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 1wr3v2-0000Wq-He for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 01:26:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr3v1-00CvVm-7u for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 03:26:11 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3sD9xagYKCU89vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a713f9c-bab6-0a2a0a5309dd-0a2a4502e7c8-16 for ; Tue, 04 Aug 2026 03:26:11 +0200 Received: from [209.85.215.198] (helo=mail-pg1-f198.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3sD9xagYKCU89vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a713fb1-6ca4-0a2a45020019-d155d7c6c1e2-3 for ; Tue, 04 Aug 2026 03:26:11 +0200 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cbb6433e9d4so5366091a12.3 for ; Mon, 03 Aug 2026 18:26:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785806769; x=1786411569; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6RexsWdhj3mVsIfZtSBkyTeZ2lUaorlH2urK3kzEKiI=; b=LQ5wEqUBm3MDYN6aB73gurgjp8JaXG4ZJ2nvHxYEF9wurXESSukvRYuRg2Lsjq9f1D iYAodCQaNtVIQTBRVjdpNX/Vm60uiYIkObBVyF0rzG/3L9ZyDut5IxcfLB+NEE1iEw4n JRPCgEn48zeysyOCWuR6hHd05E+wA26w3rOk+GHlcLFSIFo2qCJPD0KX2l1r5B4Wca6j VXvXUPNojf9AVnduoyfSngUBimCGQieyR0CfUi5q7h/8YXU6H4akzMa78z5UOjOC6O57 1Fx8GxHCSMnw31VBCpoJx7dg0pdYYgKn+fFK77M4ZKB4P/y7aQRS8wRJ0oYL9HEs0sUD tHGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785806769; x=1786411569; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6RexsWdhj3mVsIfZtSBkyTeZ2lUaorlH2urK3kzEKiI=; b=lEkAI3boh2PF0SO7aliqQazqZZ+8tz10XGXFQZARKttHXIQ5uXq27WSW/Mn7LUKfN1 UuM8HBW4cnfhzmaahotC3gSO6H6x4BJaTPAKItezGoK4xqtqEbLMqoLXdPWDnEsic0rB GvjHT1CdVT4xL4r0ohfNIdtHJ46YybmbTaL7hBPa6+RdMMUdkdCIEzYD5wkMOVb/nDJj pxBB7W4+xa6vZbN58FJ6aauMoxujOcVR4UzvlPf5Y8BujZQaONjLPdY1Kii8pbYGpiiw wnvBrWnMz1mDiu2Dy8J1Tit3gPgQj8aJRz06LS67iCefK17z2fJXpxpT1sMIID9rs4YP JtxQ== X-Forwarded-Encrypted: i=1; AHgh+RpRy4DpdcLATkPmfEs++AwTppcQcfNyiuXsQXRgmOu/2vY701zUz/eqqBtf4WD4NgB6Qtgtubvt9AU=@lists.xenproject.org X-Gm-Message-State: AOJu0YwfsZQox8P32pPgS9WS0Gf6mAHWNEi2Jnx3frCkxznz/L0bFMxS Fx7v7zLkNidP0dRg2lxno3ks7r1u8ek9s3zGJ4ilGn9tJTRbWntGO6YN6BPoy61p7VP2V6Pt8N6 W2+f3Gg== X-Received: from pgvt1.prod.google.com ([2002:a65:64c1:0:b0:c9e:63b8:11b5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:6cc4:b0:3b4:61f:1fec with SMTP id adf61e73a8af0-3c92a4c4549mr11840955637.2.1785806768677; Mon, 03 Aug 2026 18:26:08 -0700 (PDT) Date: Mon, 3 Aug 2026 18:26:08 -0700 In-Reply-To: <20260728144954.355376-12-dwmw2@infradead.org> Mime-Version: 1.0 References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-12-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v7 11/36] KVM: x86: Restructure kvm_guest_time_update() for TSC upscaling From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-720697/1785806771-319CB2AC-62EB56ED/0/0 X-purgate-type: clean X-purgate-size: 7127 On Tue, Jul 28, 2026, David Woodhouse wrote: > From: David Woodhouse > > Restructure kvm_guest_time_update() so that kernel_ns/host_tsc are > always "now" when doing TSC catchup, then swap in the master clock > reference values afterward for the hv_clock. > > This makes the TSC upscaling code considerably simpler: the catchup > adjustment is computed as the delta between what the guest TSC *should* > be at "now" and what it actually is, rather than mixing "now" and > "master clock reference" timestamps. > > The seqcount loop now also contains the kvm_get_time_and_clockread() > call (matching get_kvmclock's pattern). > > Based on a suggestion by Sean Christopherson. Looking at this with fresh eyes, it wasn't a very good suggestion. In addition to the goof Sashiko reported, propagating master_host_tsc/master_kernel_ns to host_tsc/kernel_ns is completely unnecessary and convoluted, it's much easier to simply use master_{host_tsc,kernel_ns} when stuffing hv_clock. > Signed-off-by: David Woodhouse > --- > arch/x86/kvm/x86.c | 78 ++++++++++++++++++++++++++++++++-------------- > 1 file changed, 54 insertions(+), 24 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 52c9268007f8..12c3d7d503ca 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1793,45 +1793,60 @@ static void kvm_setup_guest_pvclock(struct pvclock_vcpu_time_info *ref_hv_clock, > int kvm_guest_time_update(struct kvm_vcpu *v) > { > struct pvclock_vcpu_time_info hv_clock = {}; > - unsigned long flags; > u64 tgt_tsc_hz; > unsigned seq; > struct kvm_vcpu_arch *vcpu = &v->arch; > struct kvm_arch *ka = &v->kvm->arch; > s64 kernel_ns; > u64 tsc_timestamp, host_tsc; > + u64 master_host_tsc = 0; > + s64 master_kernel_ns = 0; > + s64 kvmclock_offset = 0; > bool use_master_clock; > > - kernel_ns = 0; > - host_tsc = 0; > - > /* > * If the host uses TSC clock, then passthrough TSC as stable > * to the guest. > */ > do { > seq = read_seqcount_begin(&ka->pvclock_sc); > + > use_master_clock = ka->use_master_clock; > + > + /* > + * The TSC read and the call to get_cpu_tsc_khz() must happen > + * on the same CPU. > + */ > + get_cpu(); > + > + tgt_tsc_hz = (u64)get_cpu_tsc_khz() * HZ_PER_KHZ; > + > +#ifdef CONFIG_X86_64 > + if (use_master_clock && > + !kvm_get_time_and_clockread(&kernel_ns, &host_tsc) && > + !read_seqcount_retry(&ka->pvclock_sc, seq)) > + use_master_clock = false; > +#endif Actually, the entire use_master_clock code can be thrown under CONFIG_X86_64=y (in a separate prep patch). > @@ -1841,17 +1856,32 @@ int kvm_guest_time_update(struct kvm_vcpu *v) > * entry to avoid unknown leaps of TSC even when running > * again on the same CPU. This may cause apparent elapsed > * time to disappear, and the guest to stand still or run > - * very slowly. > + * very slowly. > */ > if (vcpu->tsc_catchup) { > - u64 tsc = compute_guest_tsc(v, kernel_ns); > - if (tsc > tsc_timestamp) { > - adjust_tsc_offset_guest(v, tsc - tsc_timestamp); > - tsc_timestamp = tsc; > - } > + s64 adjustment; > + > + /* > + * Calculate the delta between what the guest TSC *should* be > + * and what it actually is according to kvm_read_l1_tsc(). > + */ > + adjustment = compute_guest_tsc(v, kernel_ns) - > + kvm_read_l1_tsc(v, host_tsc); > + if (adjustment > 0) > + adjust_tsc_offset_guest(v, adjustment); > } > > - local_irq_restore(flags); > + /* > + * Now that TSC upscaling is out of the way, the remaining calculations > + * are all relative to the reference time that's placed in hv_clock. > + * If the master clock is NOT in use, the reference time is "now". If > + * master clock is in use, the reference time comes from there. > + */ > + if (use_master_clock) { > + host_tsc = master_host_tsc; > + kernel_ns = master_kernel_ns; > + } > + tsc_timestamp = kvm_read_l1_tsc(v, host_tsc); And the big reason my suggestion was bad: this is wrong for vcpu->last_guest_tsc, because vcpu->last_guest_tsc needs to be updated to "now" (it's the same TSC that's shoved into TSC_OFFSET in the tsc_catchup path). This is what I have locally for the change this patch really cares about. This, and several prep cleanup patches, pass your selftests with the rest of the series piled on top. Assuming my other testing doesn't explode, I'll get a sub-series through "KVM: x86: Remove implicit rdtsc() from kvm_compute_l1_tsc_offset()" posted tomorrow, with the plan of landing all of that in 7.3. That'd leave about half the patches for 7.4, which certainly isn't ideal, but it's not too shabby either. --- arch/x86/kvm/x86.c | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 793340292d39..e826d1f8cabe 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1796,12 +1796,11 @@ static void kvm_setup_guest_pvclock(struct pvclock_vcpu_time_info *ref_hv_clock, int kvm_guest_time_update(struct kvm_vcpu *v) { + u64 tgt_tsc_hz, tsc_timestamp, host_tsc, master_tsc, master_ns; struct kvm_arch *ka __maybe_unused = &v->kvm->arch; struct pvclock_vcpu_time_info hv_clock = {}; - u64 tgt_tsc_hz; struct kvm_vcpu_arch *vcpu = &v->arch; s64 kernel_ns; - u64 tsc_timestamp, host_tsc; /* * If the host uses TSC clock, then passthrough TSC as stable @@ -1814,10 +1813,16 @@ int kvm_guest_time_update(struct kvm_vcpu *v) do { seq = read_seqcount_begin(&ka->pvclock_sc); use_master_clock = ka->use_master_clock; - if (use_master_clock) { - host_tsc = ka->master_cycle_now; - kernel_ns = ka->master_kernel_ns; + if (!use_master_clock) + continue; + + if (!kvm_get_time_and_clockread(&kernel_ns, &host_tsc)) { + use_master_clock = false; + continue; } + + master_tsc = ka->master_cycle_now; + master_ns = ka->master_kernel_ns; } while (read_seqcount_retry(&ka->pvclock_sc, seq)); #else const bool use_master_clock = false; @@ -1883,8 +1888,18 @@ int kvm_guest_time_update(struct kvm_vcpu *v) hv_clock.tsc_shift = vcpu->pvclock_tsc_shift; hv_clock.tsc_to_system_mul = vcpu->pvclock_tsc_mul; - hv_clock.tsc_timestamp = tsc_timestamp; - hv_clock.system_time = kernel_ns + v->kvm->arch.kvmclock_offset; + /* + * If the master clock is NOT in use, the reference time placed in the + * hv_clock is "now". If master clock is in use, the reference time is + * the master clock's snapshot from some time in the past, not "now". + */ + if (use_master_clock) { + hv_clock.tsc_timestamp = kvm_read_l1_tsc(v, master_tsc); + hv_clock.system_time = master_ns + v->kvm->arch.kvmclock_offset; + } else { + hv_clock.tsc_timestamp = tsc_timestamp; + hv_clock.system_time = kernel_ns + v->kvm->arch.kvmclock_offset; + } /* If the host uses TSC clocksource, then it is stable */ hv_clock.flags = 0; -- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 05:54:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 05:54:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381882.1625324 (Exim 4.92) (envelope-from ) id 1wr86n-00007I-KZ; Tue, 04 Aug 2026 05:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381882.1625324; Tue, 04 Aug 2026 05:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr86n-000078-Ga; Tue, 04 Aug 2026 05:54:37 +0000 Received: by outflank-mailman (input) for mailman id 1381882; Tue, 04 Aug 2026 05:54:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr86m-000072-8i for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 05:54:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr86k-00DoFh-Vo for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:54:34 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a717e9a-5cb7-0a2a0a5109dd-0a2a4506a80c-4 for ; Tue, 04 Aug 2026 07:54:34 +0200 Received: from [209.85.221.54] (helo=mail-wr1-f54.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a717e9a-195a-0a2a45060019-d155dd36b8d1-3 for ; Tue, 04 Aug 2026 07:54:34 +0200 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47362928f65so3965165f8f.2 for ; Mon, 03 Aug 2026 22:54:34 -0700 (PDT) Received: from notebook.. ([78.173.117.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a100e14sm55453775e9.14.2026.08.03.22.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 22:54:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785822874; x=1786427674; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0vVyXrNs9xN2FQ9GoJBozZev2DVipZjRBvvshex9mY0=; b=fM+wfhklcbhwjMZpKXXkcO4EN89o4knpSzTw5uZMu34KsJ3nettbBIvsx555K0URED WkSA4SyvM+6xXGg55f4BMDCOpHG6uBmJqdEQm1u7AodoM2cip9tT7WK3DWF0I1GxXtVM Mrf4P0eTyVWh90lgmsQMrBJaH/WbT+/mqSpD5QTqsEcimzF7J3xwjBNb+S57n/o11H8q zZHlvGfB4vDsdgbcALuEEHqe6Y2Alq+wcHxqGBXc/KQu1BmaYjacpbX7B9gN/aTPf1ch YYZsyaLgPHhgaFXdWiKqi21LCOh1aqEWydtMEFrXbldWlGJhW7/6ox460CgWVzCAJADC YyNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785822874; x=1786427674; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0vVyXrNs9xN2FQ9GoJBozZev2DVipZjRBvvshex9mY0=; b=SnlUlAQUVSrPPi3eC20QKIu+4tCOGrnVWrNLPUr0+ErSvufTmbKj8keHensrL2xPRc PVQcMMrtAFbxRYBtVZFDeB2p+dN6/cB75G+gXNGhFAuEnVPkrs4WbzUX5nqeFNIjEU+5 GYcqqyroSKyGv6eX0jpCDIyZA/yv8EFdebPM2JDZ475/+pb/717yfJvWyGSE0tfR9eaT 1XltuxN76fsruk7QSW3Biaf2erJtfbS1uldCABKy8OfCoE4qRNx2Efi79osu33cXE1WL 6vnzSieorMret515CqvmLV+869H51MVzAkLG5XGBbhfEbtLkFPHO+uEQYFLSl3ksmQky ziXw== X-Gm-Message-State: AOJu0YwNTyYxp7WEdSZee6GlufbjbtvGSTZ4Mwu4xq9ParEoVqY8ocIt uHR6L84ZBqXBq/nGFZx1bFC6qbdO7aQqGWAUov6LjkP3QNKc5sHexsLS5/L37g== X-Gm-Gg: AR+sD13ee9ssu1CZdR2nL+8uYgv7Moz+aNEWOZx4OjfD0zEQZU6fl1O7EntqSI1LTSj 1dBxSt4FgZCHwznd+IGSXqkc4JCk+agBUGP/rxTE0AU64iGTe78hBcktgFjDT7REi9pVxyx+r+V OsxqBLnPt8fgcXdfEptOnCNf7Bs89ALkjSJLTcSpjJv0iIKAvxDxpflH1zirF/WbHA8KY1GnWb6 pLYS4VwFzuOu2Z3W+Z3kUAOHmQPFm+vEB8jARWxxfnfK569rEoxuvjch2vSPQQcJZ5lGs+Pv81n zjS673r5GlwRefFhu56ZdPNPVP8Za5PCPJOxEgOgSMIhcuW0336ymG4P2uJqCg4JsBlBDFedvmn WH6RafYSAXlAiSPPp/cWmcPRRA+JmRk+8FOIIeoFUJOnrJP+4/bJTX1WMwE7xumK01D5nf75JYS c8/5D7nVTX8cP1rT6LBmFzQlvEQWCIgUELv0G9xoPvG/FZu82JWS1i66tBDzl9Ew== X-Received: by 2002:a05:600c:1908:b0:495:7838:7e25 with SMTP id 5b1f17b1804b1-4980ee9f00fmr276868105e9.15.1785822874289; Mon, 03 Aug 2026 22:54:34 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, Furkan Caliskan Subject: [PATCH v2 0/2] xen/sched: split scheduler vtable from scheduler Date: Tue, 4 Aug 2026 08:53:25 +0300 Message-Id: <20260804055327.22119-1-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1785822874-F4E0677B-0796F279/0/0 X-purgate-type: clean X-purgate-size: 2000 Each struct scheduler currently doubles as both a scheduler backend's static vtable (name, opt_name, sched_id and every function pointer) and the per-cpupool runtime object that scheduler_alloc() allocates. Because these are the same type, scheduler_alloc() memcpy()s the entire vtable into a fresh heap allocation for every cpupool it creates. With N cpupools running the same scheduler, this duplicates N copies of identical function pointers and identifying fields that never differ between instances - the only fields that are genuinely per-cpupool are sched_data and cpupool. This series splits the vtable out into its own type, struct sched_ops, so it can be shared by every cpupool using a given scheduler instead of copied per cpupool. struct scheduler is left holding only what is actually per-instance: a pointer to the shared sched_ops, plus sched_data and cpupool. Patch 1 contains the whole functional change: struct sched_ops is introduced, every in-tree scheduler backend is converted to it, and struct scheduler is shrunk accordingly. Patch 2 is a pure rename of the symbols to match the new sched_ops. v2: folded the previous 7-patch series into two patches. Furkan Caliskan (2): xen/sched: split scheduler vtable from struct scheduler xen/sched: rename scheduler registration symbols xen/arch/arm/xen.lds.S | 2 +- xen/arch/ppc/xen.lds.S | 2 +- xen/arch/riscv/xen.lds.S | 2 +- xen/arch/x86/xen.lds.S | 2 +- xen/common/sched/arinc653.c | 11 +--- xen/common/sched/core.c | 81 ++++++++++++++++------------- xen/common/sched/cpupool.c | 7 +-- xen/common/sched/credit.c | 5 +- xen/common/sched/credit2.c | 5 +- xen/common/sched/null.c | 5 +- xen/common/sched/private.h | 100 +++++++++++++++++++----------------- xen/common/sched/rt.c | 5 +- xen/include/xen/xen.lds.h | 10 ++-- 13 files changed, 119 insertions(+), 118 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 05:54:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 05:54:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381883.1625333 (Exim 4.92) (envelope-from ) id 1wr86w-0000M4-RW; Tue, 04 Aug 2026 05:54:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381883.1625333; Tue, 04 Aug 2026 05:54:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr86w-0000Lv-Nl; Tue, 04 Aug 2026 05:54:46 +0000 Received: by outflank-mailman (input) for mailman id 1381883; Tue, 04 Aug 2026 05:54:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr86v-0000LU-71 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 05:54:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr86u-00DoJM-Gc for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:54:44 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a717e93-2eae-0a2a0a5409dd-0a2a4504e2c6-20 for ; Tue, 04 Aug 2026 07:54:44 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a717ea4-b57f-0a2a45040019-d155802cb57b-3 for ; Tue, 04 Aug 2026 07:54:44 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49557167508so25172265e9.1 for ; Mon, 03 Aug 2026 22:54:44 -0700 (PDT) Received: from notebook.. ([78.173.117.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a100e14sm55453775e9.14.2026.08.03.22.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 22:54:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785822884; x=1786427684; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8ggoOmXMwyCogxzBnBzSfIP7aGxj9wPFdRUdL5Ji3Ko=; b=G60Am7tK6ST+k+DGPtB7LfQROY7sRE6nvpaBiOv67VWd3KMROhxZMNVQ6dlYOY/ufm AqYJIWfXpIuLlljql9PNPGQkP2QIzL1o8gqa0wwCnTgBmZoLy49nA4rLbjmzvQjeb4Fl KcuxSG+qYL/yuadwdFgOpa1LLW/J39l8XgkbItr/Qx8QNDhpNJBL7spssCHmqbDPFNRK DVOx6jXRiFd2YNCr2XVvwI5UIHgClQOECpx1/aPJqCe6mbwIqyjQw3msfjd/SzVLX0j6 1meQz0fNF0Ggwg5h4AXaZq7Vv/qvVpqR4w1gzPwg2Ml/PqSJBuH/skgfL3eq4jROm/gI 5bRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785822884; x=1786427684; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8ggoOmXMwyCogxzBnBzSfIP7aGxj9wPFdRUdL5Ji3Ko=; b=UY9UZuzQpzpV2+IMrjvPme7UR8i2jHA67YRWtVgcgEmqFs9Zsmx6epWmjxcbMc2AGe qKF3aAmjjCvAZPwMRPZ6B9kr9LPdDTiB5tg9UM76RUjVFE7WQSF2VtU9TRmGxjfVMbjk V+JSXY3glQVzFd87qxMsnA+mhrWMvl/0SJH6RrfhxRoM7tTracXKHXYfCobcRNLbd9X0 /V2s0hUS7uAVYvn5/zhNSLee0gA4j/rlTXrLBd1sbDFtzOPgPqdv8p/UyLD/jZ/gQUAv TH/rWgRCskyStS5AAw5OoQttoqI8O1Uw8+Fey2CccAfgoaVYfcLO2OidOLdG2Xwc4yqJ OEuA== X-Gm-Message-State: AOJu0Yw+zNhkp8LJw9CfChYbnJhIZ5S7j7MpPLfu3bka3vxhTMD8Nzeb 0LE/wRkqr+FQASy2txUEPLtryEbF06310ZjSnTnzHLoT8qZE5cQ6r0lS4H+O1g== X-Gm-Gg: AR+sD10Tg/Z4ddVzvSDYH8ti//09EmoXLg7h0XMKPxEiBOSBoQQaD8al6GCmGxEYm5A 3MoMkADvwqow6xrihmQhhmtLO3vAwFy1K/VEgDvx/FIVQhUMLPxSBu/pEEFOf3SQHPUgQ6xYb86 xNs65kIi/zajKcDxXc5FLPd3L0k8dstX55eVTg1RNKRFt5Yo0ZI5l9nGiwneAVJLsi8Wmqi/KLz WF54RJpfcY4wVWbp7vEYBdv2ZszNx2hyfumgM0q4URvE6S0ga9pSPgu6S0HENtI2jtUJwniKOFO drFof1mCOHQS2r9KcWo/dX2pnvTX7pp5/wm501pzBDccmHRbAiGvbdBNHaePnEY4i+pwOM23K2c G9cn/jPF/XPhziPAfko5AaohXUpS+Xo3WuuMipRV3cgjqfsU07EsmCMBUu9w9gs5zDcAMNbEmhd gv4SrvBYC3wc/5t5/eAafAP/6Y93khyStEeOU30Mwj95GuOjJ+5rRVoqYHQVXVt9+4OHaGL2ka X-Received: by 2002:a05:600c:4453:b0:495:6274:56c2 with SMTP id 5b1f17b1804b1-4980c649c6emr272532265e9.2.1785822883826; Mon, 03 Aug 2026 22:54:43 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, Furkan Caliskan Subject: [PATCH v2 1/2] xen/sched: split scheduler vtable from struct scheduler Date: Tue, 4 Aug 2026 08:53:26 +0300 Message-Id: <20260804055327.22119-2-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260804055327.22119-1-frn1furkan10@gmail.com> References: <20260804055327.22119-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1785822884-506DAB50-A98A8F2D/0/0 X-purgate-type: clean X-purgate-size: 20100 struct scheduler currently serves two purposes: it is the static vtable a scheduler backend defines (name, opt_name, sched_id, and all its function pointers), and it is also the per-cpupool runtime object scheduler_alloc() allocates. Being the same type forces scheduler_alloc() to memcpy() the whole vtable into a fresh allocation per cpupool, duplicating identical function pointers across every cpupool using the same scheduler. Split the vtable out into its own type, struct sched_ops, so it can be shared by every cpupool using a given scheduler instead of copied per cpupool. struct scheduler is left holding only what is actually per-instance: a pointer to the shared sched_ops, plus sched_data and cpupool. scheduler_alloc() now stores a pointer to the matching sched_ops instance instead of copying its fields, and every accessor in private.h is updated from s->field to s->ops->field to match. Every in-tree scheduler backend (credit, credit2, rtds, arinc653, null) is converted from struct scheduler to struct sched_ops. A handful of call sites elsewhere read a scheduler's name, opt_name or sched_id directly and are updated to go through ->ops as well. Signed-off-by: Furkan Caliskan --- xen/common/sched/arinc653.c | 9 +--- xen/common/sched/core.c | 52 +++++++++++--------- xen/common/sched/cpupool.c | 7 +-- xen/common/sched/credit.c | 3 +- xen/common/sched/credit2.c | 3 +- xen/common/sched/null.c | 3 +- xen/common/sched/private.h | 98 +++++++++++++++++++------------------ xen/common/sched/rt.c | 3 +- 8 files changed, 89 insertions(+), 89 deletions(-) diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c index 32c596a23c..746963806e 100644 --- a/xen/common/sched/arinc653.c +++ b/xen/common/sched/arinc653.c @@ -702,17 +702,10 @@ a653sched_adjust_global(const struct scheduler *ops, } #endif /* CONFIG_SYSCTL */ -/** - * This structure defines our scheduler for Xen. - * The entries tell Xen where to find our scheduler-specific - * callback functions. - * The symbol must be visible to the rest of Xen at link time. - */ -static const struct scheduler sched_arinc653_def = { +static const struct sched_ops sched_arinc653_def = { .name = "ARINC 653 Scheduler", .opt_name = "arinc653", .sched_id = XEN_SCHEDULER_ARINC653, - .sched_data = NULL, .init = a653sched_init, .deinit = a653sched_deinit, diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 9ccf5811bf..5cdae0415c 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -87,7 +87,7 @@ DEFINE_PER_CPU(cpumask_t, cpumask_scratch); /* How many urgent vcpus. */ DEFINE_PER_CPU(atomic_t, sched_urgent_count); -extern const struct scheduler *__start_schedulers_array[], *__end_schedulers_array[]; +extern const struct sched_ops *__start_schedulers_array[], *__end_schedulers_array[]; #define NUM_SCHEDULERS (__end_schedulers_array - __start_schedulers_array) #define schedulers __start_schedulers_array @@ -127,10 +127,9 @@ static void cf_check sched_idle_schedule( unit->next_task = sched_idle_unit(cpu); } -static struct scheduler sched_idle_ops = { +static struct sched_ops sched_idle_sched_ops = { .name = "Idle Scheduler", .opt_name = "idle", - .sched_data = NULL, .pick_resource = sched_idle_res_pick, .do_schedule = sched_idle_schedule, @@ -139,6 +138,11 @@ static struct scheduler sched_idle_ops = { .free_udata = sched_idle_free_udata, }; +static struct scheduler sched_idle_ops = { + .ops = &sched_idle_sched_ops, + .sched_data = NULL, +}; + static inline struct vcpu *unit2vcpu_cpu(const struct sched_unit *unit, unsigned int cpu) { @@ -2081,7 +2085,7 @@ long do_set_timer_op(s_time_t timeout) /* scheduler_id - fetch ID of current scheduler */ int scheduler_id(void) { - return operations.sched_id; + return operations.ops->sched_id; } #endif @@ -2090,7 +2094,7 @@ long sched_adjust(struct domain *d, struct xen_domctl_scheduler_op *op) { long ret; - if ( op->sched_id != dom_scheduler(d)->sched_id ) + if ( op->sched_id != dom_scheduler(d)->ops->sched_id ) return -EINVAL; switch ( op->cmd ) @@ -2132,7 +2136,7 @@ long sched_adjust_global(struct xen_sysctl_scheduler_op *op) rcu_read_lock(&sched_res_rculock); - rc = ((op->sched_id == pool->sched->sched_id) + rc = ((op->sched_id == pool->sched->ops->sched_id) ? sched_adjust_cpupool(pool->sched, op) : -EINVAL); rcu_read_unlock(&sched_res_rculock); @@ -2299,7 +2303,7 @@ static struct sched_unit *do_schedule(struct sched_unit *prev, s_time_t now, struct sched_unit *next; /* get policy-specific decision on scheduling... */ - sched->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); + sched->ops->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); next = prev->next_task; @@ -2989,10 +2993,9 @@ void scheduler_enable(void) } static inline -const struct scheduler *__init sched_get_by_name(const char *sched_name) +const struct sched_ops *__init sched_ops_get_by_name(const char* sched_name) { unsigned int i; - for ( i = 0; i < NUM_SCHEDULERS; i++ ) if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) ) return schedulers[i]; @@ -3002,16 +3005,15 @@ const struct scheduler *__init sched_get_by_name(const char *sched_name) int __init sched_get_id_by_name(const char *sched_name) { - const struct scheduler *scheduler = sched_get_by_name(sched_name); - - return scheduler ? scheduler->sched_id : -1; + const struct sched_ops *ops = sched_ops_get_by_name(sched_name); + return ops ? ops->sched_id : -1; } /* Initialise the data structures. */ void __init scheduler_init(void) { struct domain *idle_domain; - const struct scheduler *scheduler; + const struct sched_ops *ops; int i; scheduler_enable(); @@ -3044,21 +3046,23 @@ void __init scheduler_init(void) } } - scheduler = sched_get_by_name(opt_sched); - if ( !scheduler ) + ops = sched_ops_get_by_name(opt_sched); + if ( !ops ) { printk("Could not find scheduler: %s\n", opt_sched); - scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT); - BUG_ON(!scheduler); - printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name); + ops = sched_ops_get_by_name(CONFIG_SCHED_DEFAULT); + BUG_ON(!ops); + printk("Using '%s' (%s)\n", ops->name, ops->opt_name); } - operations = *scheduler; + + operations.ops = ops; if ( cpu_schedule_up(0) ) BUG(); register_cpu_notifier(&cpu_schedule_nfb); - printk("Using scheduler: %s (%s)\n", operations.name, operations.opt_name); + printk("Using scheduler: %s (%s)\n", + operations.ops->name, operations.ops->opt_name); if ( sched_init(&operations) ) panic("scheduler returned error on init\n"); @@ -3411,12 +3415,14 @@ struct scheduler *scheduler_alloc(unsigned int sched_id) for ( i = 0; i < NUM_SCHEDULERS; i++ ) if ( schedulers[i] && schedulers[i]->sched_id == sched_id ) goto found; + return ERR_PTR(-ENOENT); found: - if ( (sched = xmalloc(struct scheduler)) == NULL ) + if ( (sched = xzalloc(struct scheduler)) == NULL ) return ERR_PTR(-ENOMEM); - memcpy(sched, schedulers[i], sizeof(*sched)); + sched->ops = schedulers[i]; + if ( (ret = sched_init(sched)) != 0 ) { xfree(sched); @@ -3447,7 +3453,7 @@ void schedule_dump(struct cpupool *c) { sched = c->sched; cpus = c->res_valid; - printk("Scheduler: %s (%s)\n", sched->name, sched->opt_name); + printk("Scheduler: %s (%s)\n", sched->ops->name, sched->ops->opt_name); sched_dump_settings(sched); } else diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 081e1053eb..640578201f 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -338,7 +338,8 @@ static struct cpupool *cpupool_create(unsigned int poolid, spin_unlock(&cpupool_lock); debugtrace_printk("Created cpupool %u with scheduler %s (%s)\n", - c->cpupool_id, c->sched->name, c->sched->opt_name); + c->cpupool_id, c->sched->ops->name, + c->sched->ops->opt_name); return c; @@ -862,7 +863,7 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) if ( c == NULL ) break; op->cpupool_id = c->cpupool_id; - op->sched_id = c->sched->sched_id; + op->sched_id = c->sched->ops->sched_id; op->n_dom = c->n_dom; ret = cpumask_to_xenctl_bitmap(&op->cpumap, c->cpu_valid); cpupool_put(c); @@ -1294,7 +1295,7 @@ struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id) struct cpupool *pool; if ( sched_id < 0 ) - sched_id = scheduler_get_default()->sched_id; + sched_id = scheduler_get_default()->ops->sched_id; pool = cpupool_create(pool_id, sched_id); diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 4dde2ede12..8df746bf6b 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -2277,11 +2277,10 @@ csched_deinit(struct scheduler *ops) } } -static const struct scheduler sched_credit_def = { +static const struct sched_ops sched_credit_def = { .name = "SMP Credit Scheduler", .opt_name = "credit", .sched_id = XEN_SCHEDULER_CREDIT, - .sched_data = NULL, .global_init = csched_global_init, diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 95946634d1..4949606881 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -4230,11 +4230,10 @@ csched2_deinit(struct scheduler *ops) xfree(prv); } -static const struct scheduler sched_credit2_def = { +static const struct sched_ops sched_credit2_def = { .name = "SMP Credit Scheduler rev2", .opt_name = "credit2", .sched_id = XEN_SCHEDULER_CREDIT2, - .sched_data = NULL, .global_init = csched2_global_init, diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index 952bb47444..b3c6651fb1 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -1037,11 +1037,10 @@ static void cf_check null_dump(const struct scheduler *ops) spin_unlock_irqrestore(&prv->lock, flags); } -static const struct scheduler sched_null_def = { +static const struct sched_ops sched_null_def = { .name = "null Scheduler", .opt_name = "null", .sched_id = XEN_SCHEDULER_NULL, - .sched_data = NULL, .init = null_init, .deinit = null_deinit, diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index d6884550cd..0c5181891c 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -294,12 +294,10 @@ static inline spinlock_t *pcpu_schedule_trylock(unsigned int cpu) return NULL; } -struct scheduler { - const char *name; /* full name for this scheduler */ - const char *opt_name; /* option name for this scheduler */ - unsigned int sched_id; /* ID for this scheduler */ - void *sched_data; /* global data pointer */ - struct cpupool *cpupool;/* points to this scheduler's pool */ +struct sched_ops { + const char *name; /* full name for this sched_ops */ + const char *opt_name; /* option name for this sched_ops */ + unsigned int sched_id; /* ID for this sched_ops */ int (*global_init) (void); @@ -366,127 +364,133 @@ struct scheduler { struct sched_resource *sr); }; +struct scheduler { + const struct sched_ops *ops; /* shared, read-only dispatch table */ + void *sched_data; /* global data pointer */ + struct cpupool *cpupool; /* points to this scheduler's pool */ +}; + static inline int sched_init(struct scheduler *s) { - return s->init(s); + return s->ops->init(s); } static inline void sched_deinit(struct scheduler *s) { - s->deinit(s); + s->ops->deinit(s); } static inline spinlock_t *sched_switch_sched(struct scheduler *s, unsigned int cpu, void *pdata, void *vdata) { - return s->switch_sched(s, cpu, pdata, vdata); + return s->ops->switch_sched(s, cpu, pdata, vdata); } static inline void sched_dump_settings(const struct scheduler *s) { - if ( s->dump_settings ) - s->dump_settings(s); + if ( s->ops->dump_settings ) + s->ops->dump_settings(s); } static inline void sched_dump_cpu_state(const struct scheduler *s, int cpu) { - if ( s->dump_cpu_state ) - s->dump_cpu_state(s, cpu); + if ( s->ops->dump_cpu_state ) + s->ops->dump_cpu_state(s, cpu); } static inline void *sched_alloc_domdata(const struct scheduler *s, struct domain *d) { - return s->alloc_domdata ? s->alloc_domdata(s, d) : NULL; + return s->ops->alloc_domdata ? s->ops->alloc_domdata(s, d) : NULL; } static inline void sched_free_domdata(const struct scheduler *s, void *data) { - ASSERT(s->free_domdata || !data); - if ( s->free_domdata ) - s->free_domdata(s, data); + ASSERT(s->ops->free_domdata || !data); + if ( s->ops->free_domdata ) + s->ops->free_domdata(s, data); } static inline void *sched_alloc_pdata(const struct scheduler *s, int cpu) { - return s->alloc_pdata ? s->alloc_pdata(s, cpu) : NULL; + return s->ops->alloc_pdata ? s->ops->alloc_pdata(s, cpu) : NULL; } static inline void sched_free_pdata(const struct scheduler *s, void *data, int cpu) { - ASSERT(s->free_pdata || !data); - if ( s->free_pdata ) - s->free_pdata(s, data, cpu); + ASSERT(s->ops->free_pdata || !data); + if ( s->ops->free_pdata ) + s->ops->free_pdata(s, data, cpu); } static inline void sched_deinit_pdata(const struct scheduler *s, void *data, int cpu) { - if ( s->deinit_pdata ) - s->deinit_pdata(s, data, cpu); + if ( s->ops->deinit_pdata ) + s->ops->deinit_pdata(s, data, cpu); } static inline void *sched_alloc_udata(const struct scheduler *s, struct sched_unit *unit, void *dom_data) { - return s->alloc_udata(s, unit, dom_data); + return s->ops->alloc_udata(s, unit, dom_data); } static inline void sched_free_udata(const struct scheduler *s, void *data) { - s->free_udata(s, data); + s->ops->free_udata(s, data); } static inline void sched_insert_unit(const struct scheduler *s, struct sched_unit *unit) { - if ( s->insert_unit ) - s->insert_unit(s, unit); + if ( s->ops->insert_unit ) + s->ops->insert_unit(s, unit); } static inline void sched_remove_unit(const struct scheduler *s, struct sched_unit *unit) { - if ( s->remove_unit ) - s->remove_unit(s, unit); + if ( s->ops->remove_unit ) + s->ops->remove_unit(s, unit); } static inline void sched_sleep(const struct scheduler *s, struct sched_unit *unit) { - if ( s->sleep ) - s->sleep(s, unit); + if ( s->ops->sleep ) + s->ops->sleep(s, unit); } static inline void sched_wake(const struct scheduler *s, struct sched_unit *unit) { - if ( s->wake ) - s->wake(s, unit); + if ( s->ops->wake ) + s->ops->wake(s, unit); } static inline void sched_yield(const struct scheduler *s, struct sched_unit *unit) { - if ( s->yield ) - s->yield(s, unit); + if ( s->ops->yield ) + s->ops->yield(s, unit); } static inline void sched_context_saved(const struct scheduler *s, struct sched_unit *unit) { - if ( s->context_saved ) - s->context_saved(s, unit); + if ( s->ops->context_saved ) + s->ops->context_saved(s, unit); } static inline void sched_migrate(const struct scheduler *s, struct sched_unit *unit, unsigned int cpu) { - if ( s->migrate ) - s->migrate(s, unit, cpu); + if ( s->ops->migrate ) + s->ops->migrate(s, unit, cpu); else sched_set_res(unit, get_sched_res(cpu)); } @@ -494,7 +498,7 @@ static inline void sched_migrate(const struct scheduler *s, static inline struct sched_resource *sched_pick_resource( const struct scheduler *s, const struct sched_unit *unit) { - return s->pick_resource(s, unit); + return s->ops->pick_resource(s, unit); } static inline void sched_adjust_affinity(const struct scheduler *s, @@ -502,29 +506,29 @@ static inline void sched_adjust_affinity(const struct scheduler *s, const cpumask_t *hard, const cpumask_t *soft) { - if ( s->adjust_affinity ) - s->adjust_affinity(s, unit, hard, soft); + if ( s->ops->adjust_affinity ) + s->ops->adjust_affinity(s, unit, hard, soft); } static inline int sched_adjust_dom(const struct scheduler *s, struct domain *d, struct xen_domctl_scheduler_op *op) { - return s->adjust ? s->adjust(s, d, op) : 0; + return s->ops->adjust ? s->ops->adjust(s, d, op) : 0; } #ifdef CONFIG_SYSCTL static inline int sched_adjust_cpupool(const struct scheduler *s, struct xen_sysctl_scheduler_op *op) { - return s->adjust_global ? s->adjust_global(s, op) : 0; + return s->ops->adjust_global ? s->ops->adjust_global(s, op) : 0; } #endif static inline void sched_move_timers(const struct scheduler *s, struct sched_resource *sr) { - if ( s->move_timers ) - s->move_timers(s, sr); + if ( s->ops->move_timers ) + s->ops->move_timers(s, sr); } static inline void sched_unit_pause_nosync(const struct sched_unit *unit) @@ -543,7 +547,7 @@ static inline void sched_unit_unpause(const struct sched_unit *unit) vcpu_unpause(v); } -#define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \ +#define REGISTER_SCHEDULER(x) static const struct sched_ops *x##_entry \ __used_section(".data.schedulers") = &(x) struct cpupool diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index 744f214173..0e9f04ea72 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -1617,11 +1617,10 @@ static void cf_check repl_timer_handler(void *data) spin_unlock_irq(&prv->lock); } -static const struct scheduler sched_rtds_def = { +static const struct sched_ops sched_rtds_def = { .name = "SMP RTDS Scheduler", .opt_name = "rtds", .sched_id = XEN_SCHEDULER_RTDS, - .sched_data = NULL, .dump_cpu_state = rt_dump_pcpu, .dump_settings = rt_dump, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 05:54:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 05:54:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381885.1625342 (Exim 4.92) (envelope-from ) id 1wr873-0000dG-6H; Tue, 04 Aug 2026 05:54:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381885.1625342; Tue, 04 Aug 2026 05:54:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr873-0000d9-3K; Tue, 04 Aug 2026 05:54:53 +0000 Received: by outflank-mailman (input) for mailman id 1381885; Tue, 04 Aug 2026 05:54:51 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr871-0000bZ-Iw for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 05:54:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr870-00DRnB-Vx for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:54:50 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a717e95-e002-0a2a0a5209dd-0a2a4503adec-46 for ; Tue, 04 Aug 2026 07:54:50 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a717eaa-fae8-0a2a45030019-d155802cdded-3 for ; Tue, 04 Aug 2026 07:54:50 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49802c418b5so23317355e9.1 for ; Mon, 03 Aug 2026 22:54:50 -0700 (PDT) Received: from notebook.. ([78.173.117.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a100e14sm55453775e9.14.2026.08.03.22.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 22:54:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785822890; x=1786427690; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=p6vxw/6ES4G2VqIbltqaKS0hNP1qFgjai3ORZHffXN8=; b=JRBVpzyToFDKUCnkHaEdrbYtw2LlbHqHuWQW1LM5y+CIthEEkEEjCzBkK6ji57okMt KQNGM3ErzhXq4yuErKRTCtkpeozvPF1ShGjtis0vxvYq3+H8xj+ZYvh4Do0jfbWKJWjN BuzdQiQpzH3l1X01MBs4+/qUKjXbNEh2rLdQNFbQcrb8aVbV4AUvDXheMdb+3Dh9RARv LhCTNt7me8MIKwKYvxPeJb67t8papaSyNN196lS2E98/nI9Sz4ScGvfbK6ySL0tEsjM/ NS7icNZf8qEJV/ou7vjnL80GFc1O8+zNX45LqY0e70etuOd723n7uhCQ4nCNAXJ3b5sm VgvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785822890; x=1786427690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=p6vxw/6ES4G2VqIbltqaKS0hNP1qFgjai3ORZHffXN8=; b=n+ZvlSwGEIrF1sXYq0VRCVWYnJwTuXcq6YMB676sYVzzJ1U+ZkzDyzREEaiZ0GZJp2 M7Eu7LZDCO0KRfryhmmU9MvphuJwziy9w0EuHkQb+5tkmt2eo9SirDE+Xh9P4n31nSU3 RhQIhjM8coKcFb+N+i62qnDtLR+HORibcQS6m5mUWO5Ovf+IRHr+cuJjRq3CeWXvnVrL 7hH3vsB90/nm5qgEfGfuYGE0yRy7uVTrPeB3aW9t+3AKcGjFFXSGi3xB1aVECE60WNGJ 4L8aSLI1P7ApHZG4wMsYCabJnXqjG88W8VdGrvGhuyzdIQ6LAtwMDBOwgsUiWJArH8zm QdPw== X-Gm-Message-State: AOJu0YyF4MoeD3DmTAHai04i5LGibHLZU4tYSJr34JjYvw6+KIoF+ANC zgvvN+x2sAZqXZVn2mGdAt5u3I1VeaDJIq6CqRIVBYBDMIORi2p1I6M7HXyoqQ== X-Gm-Gg: AR+sD10gX4sCWXbh4QV61VrRnBSLQRH3Vk9f0yds9SCvzcy3avC3CR2E5dtS9vwpvl/ rYt1voidGkF7wyl3+K4uMDeopUTYc0YnsRtPAxQrmWsNYeM9fGsRPnvERESCXSMRY8vhAYMfCN2 wWbYrR6kzyaCJ+7kSu99jFKQNQNl94wJ1aGX2BRQXor4GkvH0v/Wg12KWPMDYkLGpcYtskPe/ny qvSyTqJe+t64YAPdwkx1l4GrGeL7yO3MN7AelRPhi6+mrWJdsokhzYcMXMgRw1rFsROUw2b/Mkz OTtYGbzODqw+lWDDp7mLdvbbUiVug4Mx4KHQUD5HEnJoAhyTBhphtFQVknjPSJ/fcyDMWcPKRfy avoHK2TVkm4W6cVIBWtBiZcHygbV8DDK/T78iLJc2D1+5x5uolEFotaOH+H5KLly/haZqOdyLT9 8RY6drQpnreqqe6xF4Ye3PjR9G7CD2ovlksh7ZL9AUBINAbJeLnMmcTvlaLTtN2w== X-Received: by 2002:a05:600c:840f:b0:493:c42e:5be0 with SMTP id 5b1f17b1804b1-4980c60705amr267135705e9.0.1785822890072; Mon, 03 Aug 2026 22:54:50 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, Furkan Caliskan Subject: [PATCH v2 2/2] xen/sched: rename scheduler registration symbols Date: Tue, 4 Aug 2026 08:53:27 +0300 Message-Id: <20260804055327.22119-3-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260804055327.22119-1-frn1furkan10@gmail.com> References: <20260804055327.22119-1-frn1furkan10@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785822890-6E8CD4E9-A21BE1E6/0/0 X-purgate-type: clean X-purgate-size: 8916 REGISTER_SCHEDULER(), schedulers[], NUM_SCHEDULERS, and the per-arch SCHEDULER_ARRAY linker macro now register and hold struct sched_ops instances rather than struct scheduler ones, but still carry names describing the old type. Rename them to match the current behaviour. No functional change. Signed-off-by: Furkan Caliskan --- xen/arch/arm/xen.lds.S | 2 +- xen/arch/ppc/xen.lds.S | 2 +- xen/arch/riscv/xen.lds.S | 2 +- xen/arch/x86/xen.lds.S | 2 +- xen/common/sched/arinc653.c | 2 +- xen/common/sched/core.c | 33 +++++++++++++++++---------------- xen/common/sched/credit.c | 2 +- xen/common/sched/credit2.c | 2 +- xen/common/sched/null.c | 2 +- xen/common/sched/private.h | 4 ++-- xen/common/sched/rt.c | 2 +- xen/include/xen/xen.lds.h | 10 +++++----- 12 files changed, 33 insertions(+), 32 deletions(-) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 2d5f1c516d..07bf875599 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -93,7 +93,7 @@ SECTIONS .data : { /* Data */ *(.data.page_aligned) - SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM *(.data .data.*) diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S index d0f2ed43f1..1f4e200693 100644 --- a/xen/arch/ppc/xen.lds.S +++ b/xen/arch/ppc/xen.lds.S @@ -84,7 +84,7 @@ SECTIONS DECL_SECTION(.data) { /* Data */ *(.data.page_aligned) - SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM *(.data .data.*) diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 65f136dce9..97f2db1dfd 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -89,7 +89,7 @@ SECTIONS .data : { /* Data */ *(.data.page_aligned) - SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM *(.data .data.*) diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index b9e888e596..0f506ff1f6 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -306,7 +306,7 @@ SECTIONS DECL_SECTION(.data.read_mostly) { *(.data.read_mostly) - SCHEDULER_ARRAY + SCHED_OPS_ARRAY HYPFS_PARAM } PHDR(text) diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c index 746963806e..efcaa44089 100644 --- a/xen/common/sched/arinc653.c +++ b/xen/common/sched/arinc653.c @@ -736,7 +736,7 @@ static const struct sched_ops sched_arinc653_def = { .dump_cpu_state = NULL, }; -REGISTER_SCHEDULER(sched_arinc653_def); +REGISTER_SCHED_OPS(sched_arinc653_def); /* * Local variables: diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 5cdae0415c..8e938a3810 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -87,9 +87,9 @@ DEFINE_PER_CPU(cpumask_t, cpumask_scratch); /* How many urgent vcpus. */ DEFINE_PER_CPU(atomic_t, sched_urgent_count); -extern const struct sched_ops *__start_schedulers_array[], *__end_schedulers_array[]; -#define NUM_SCHEDULERS (__end_schedulers_array - __start_schedulers_array) -#define schedulers __start_schedulers_array +extern const struct sched_ops *__start_sched_ops_array[], *__end_sched_ops_array[]; +#define NUM_SCHED_OPS (__end_sched_ops_array - __start_sched_ops_array) +#define sched_ops_array __start_sched_ops_array static struct scheduler __read_mostly operations; @@ -2996,9 +2996,9 @@ static inline const struct sched_ops *__init sched_ops_get_by_name(const char* sched_name) { unsigned int i; - for ( i = 0; i < NUM_SCHEDULERS; i++ ) - if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) ) - return schedulers[i]; + for ( i = 0; i < NUM_SCHED_OPS; i++ ) + if ( sched_ops_array[i] && !strcmp(sched_ops_array[i]->opt_name, sched_name) ) + return sched_ops_array[i]; return NULL; } @@ -3018,14 +3018,14 @@ void __init scheduler_init(void) scheduler_enable(); - for ( i = 0; i < NUM_SCHEDULERS; i++) + for ( i = 0; i < NUM_SCHED_OPS; i++) { #define sched_test_func(f) \ - if ( !schedulers[i]->f ) \ + if ( !sched_ops_array[i]->f ) \ { \ printk("scheduler %s misses .%s, dropped\n", \ - schedulers[i]->opt_name, #f); \ - schedulers[i] = NULL; \ + sched_ops_array[i]->opt_name, #f); \ + sched_ops_array[i] = NULL; \ } sched_test_func(init); @@ -3038,11 +3038,12 @@ void __init scheduler_init(void) #undef sched_test_func - if ( schedulers[i]->global_init && schedulers[i]->global_init() < 0 ) + if ( sched_ops_array[i]->global_init && + sched_ops_array[i]->global_init() < 0 ) { printk("scheduler %s failed initialization, dropped\n", - schedulers[i]->opt_name); - schedulers[i] = NULL; + sched_ops_array[i]->opt_name); + sched_ops_array[i] = NULL; } } @@ -3412,8 +3413,8 @@ struct scheduler *scheduler_alloc(unsigned int sched_id) int ret; struct scheduler *sched; - for ( i = 0; i < NUM_SCHEDULERS; i++ ) - if ( schedulers[i] && schedulers[i]->sched_id == sched_id ) + for ( i = 0; i < NUM_SCHED_OPS; i++ ) + if ( sched_ops_array[i] && sched_ops_array[i]->sched_id == sched_id ) goto found; return ERR_PTR(-ENOENT); @@ -3421,7 +3422,7 @@ struct scheduler *scheduler_alloc(unsigned int sched_id) found: if ( (sched = xzalloc(struct scheduler)) == NULL ) return ERR_PTR(-ENOMEM); - sched->ops = schedulers[i]; + sched->ops = sched_ops_array[i]; if ( (ret = sched_init(sched)) != 0 ) { diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 8df746bf6b..995cf097b5 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -2315,4 +2315,4 @@ static const struct sched_ops sched_credit_def = { .move_timers = csched_move_timers, }; -REGISTER_SCHEDULER(sched_credit_def); +REGISTER_SCHED_OPS(sched_credit_def); diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 4949606881..9bcc90004a 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -4268,4 +4268,4 @@ static const struct sched_ops sched_credit2_def = { .free_domdata = csched2_free_domdata, }; -REGISTER_SCHEDULER(sched_credit2_def); +REGISTER_SCHED_OPS(sched_credit2_def); diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index b3c6651fb1..5194c8216c 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -1067,4 +1067,4 @@ static const struct sched_ops sched_null_def = { .dump_settings = null_dump, }; -REGISTER_SCHEDULER(sched_null_def); +REGISTER_SCHED_OPS(sched_null_def); diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index 0c5181891c..c03063befe 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -547,8 +547,8 @@ static inline void sched_unit_unpause(const struct sched_unit *unit) vcpu_unpause(v); } -#define REGISTER_SCHEDULER(x) static const struct sched_ops *x##_entry \ - __used_section(".data.schedulers") = &(x) +#define REGISTER_SCHED_OPS(x) static const struct sched_ops *x##_entry \ + __used_section(".data.sched_ops") = &(x) struct cpupool { diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index 0e9f04ea72..8b4f05e2d1 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -1645,4 +1645,4 @@ static const struct sched_ops sched_rtds_def = { .move_timers = rt_move_timers, }; -REGISTER_SCHEDULER(sched_rtds_def); +REGISTER_SCHED_OPS(sched_rtds_def); diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h index ea11e3fb62..fc44d28734 100644 --- a/xen/include/xen/xen.lds.h +++ b/xen/include/xen/xen.lds.h @@ -173,11 +173,11 @@ _edevice = .; \ } :text -#define SCHEDULER_ARRAY \ - . = ALIGN(POINTER_ALIGN); \ - __start_schedulers_array = .; \ - *(.data.schedulers) \ - __end_schedulers_array = .; +#define SCHED_OPS_ARRAY \ + . = ALIGN(POINTER_ALIGN); \ + __start_sched_ops_array = .; \ + *(.data.sched_ops) \ + __end_sched_ops_array = .; #ifdef CONFIG_HYPFS #define HYPFS_PARAM \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 06:22:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 06:22:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381912.1625352 (Exim 4.92) (envelope-from ) id 1wr8Y9-0006fB-A6; Tue, 04 Aug 2026 06:22:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381912.1625352; Tue, 04 Aug 2026 06:22:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr8Y9-0006f4-75; Tue, 04 Aug 2026 06:22:53 +0000 Received: by outflank-mailman (input) for mailman id 1381912; Tue, 04 Aug 2026 06:12:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr8O8-00053K-MO for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 06:12:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wr8O8-004eM8-2Q for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 06:12:32 +0000 Received: from mail-lf1-f44.google.com ([209.85.167.44]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wr8O8-007Sib-1I for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 06:12:32 +0000 Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5b28c91fba5so796609e87.1 for ; Mon, 03 Aug 2026 23:12:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:MIME-Version; bh=cKkt4ers6CnESh/Dtqx6JQgb2hU5RYPlj5ywtje48gQ=; b=XW Om9dgoOSHjstj0vCbZKxisMZjdrjcjdIJCNfwuqPvWnsUbqXHYMZUgUmJsOY6QMpMDiFQGpJkpWdp xleOagT6oy4aGlaatSzN6XsrXiwQcwTAEvpb8h6WeUnJc0DjhGnv6ySyzPPg7UP+1wLhJKefdmvr0 7sQeT4Xe7OcIRt0=; X-Gm-Message-State: AOJu0Yy0pKT+rtsymcU7kSDuvD+G1AWNnDaZEskXDZFv/7aezmnY9rjX u4ufOyw/voCEBekVFBMGDShDWCFbr6zlnsU+YWOv1Zd7Pqzsop202dNVG115fqy6z3hhlrQglh0 nZytjer51jGMZ16IuzVD5bzZxtqZPh9o= X-Received: by 2002:a05:6512:3e23:b0:5b2:aa73:ea6a with SMTP id 2adb3069b0e04-5b2f281bc1emr276587e87.10.1785823951299; Mon, 03 Aug 2026 23:12:31 -0700 (PDT) MIME-Version: 1.0 From: George Dunlap Date: Tue, 4 Aug 2026 16:12:17 +1000 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mw6ehuTpnm2xYeSM80RlQxvsXMGAHoaDwR3g3EL7lt0OIExqIqZbAwNxk8 Message-ID: Subject: Linux PV domU with >1 vCPU never resumes after xl save/restore To: xen-devel Cc: Juergen Gross Content-Type: multipart/alternative; boundary="0000000000003fa71a0658328abf" --0000000000003fa71a0658328abf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Saving and restoring a multi-vcpu PV guest appears to have been broken in Linux for some time (observed 6.6.56 and 6.12.86). Report below from Claude Fable; I've independently verified the behavior on vanilla Linux 6.6.56. Claude seems to think it's a bug in Linux. Gitlab CI seems to only run with vcpus=3D1, which is why it didn't notice. George Dunlap Freelance Xen consultant https://www.laleolanguage.com/consulting 8<---- A PV guest with more than one vCPU survives `xl save`, but after `xl restore` it never comes back: the kernel wedges mid-resume, before xenbus reconnect, so all frontends stay disconnected (netfront frontend state remains XenbusStateInitialising, backend InitWait; vif shows NO-CARRIER in dom0) and the guest is unreachable indefinitely. With vcpus=3D1 the same guest/image/kernel resumes cleanly, PVH SMP save/restore is fine, and the suspend-cancel path (a failed `xl save` resuming the domain in place) is also fine. Reproduced with: - Debian trixie kernel 6.12.86+deb13-amd64 - the Xen-project CI test-artifacts kernel, vanilla 6.6.56 (identical signature on both, so not a 6.12 regression; at least the 6.6..6.12 LTS span is affected) Host: x86-64, Xen master/staging (4.23-unstable); also reproduced on an older commit, so the Xen version does not appear relevant. Plain `xl save` + `xl restore` of an idle 4-vCPU, 2G PV domU, direct kernel boot, xvda file-backed disk, one vif. 100% reproducible. What the resume looks like (full logs available): - Capturing the console across a paused restore (`xl restore -p`, attach console, unpause) shows all secondary vCPUs immediately splatting: WARNING: CPU: 1 PID: 0 at kernel/time/timekeeping.c:747 ktime_get+0xa9/0xd0 ... tick_nohz_idle_enter do_idle cpu_startup_entry cpu_bringup_and_idle asm_cpu_bringup_and_idle i.e. the idle task entering nohz while timekeeping is still suspended =E2=80=94 with printk timestamps taken from the *uncorrected* clock (pre-suspend time + the save/restore wall-clock gap), while CPU0's own subsequent resume messages ("Grant tables using version 1 layout", from gnttab_resume() inside xen_suspend()) carry the *corrected*, earlier timestamp. The secondaries therefore left the stop_machine corral before CPU0's post-suspend work inside xen_suspend() had run, which the multi_cpu_stop state machine is supposed to make impossible. - xenctx on the restored-but-still-paused domain shows the vCPU contexts are restored faithfully (RIP-for-RIP identical to a probe taken at the suspend point: vCPU0 inside the suspend hypercall stub, the secondaries inside the multi_cpu_stop corral loop). The toolstack is delivering exactly what was saved; the wedge develops after unpause, guest-side. - End state, stable forever after: vCPU0 spins at 100% inside the multi_cpu_stop corral code (per xenctx; `xl vcpu-list` shows r-- accumulating time), while the secondary vCPUs sit blocked in SCHED_block on their idle-task stacks. Because stop_machine() never completes, do_suspend() never reaches xen_arch_resume() (so the secondaries' local ticks, suspended by xen_arch_suspend() before the corral, are never resumed =E2=80=94 nothing will ever wake them) nor xs_resume()/dpm_resume_*() (so xenbus frontends never reconnect). A speculative note on the trigger, from reading the 6.12 code =E2=80=94 tre= at as unverified: xen_vcpu_restore() (called from xen_pv_post_suspend() while the secondaries are mid-corral with virtual interrupts masked) does VCPUOP_down, re-registers vcpu_info via xen_vcpu_setup_restore(), then VCPUOP_up on each secondary. If the re-registration ends up with evtchn_upcall_mask clear in the newly registered vcpu_info, the vCPU comes back up with an unexpected upcall window mid-corral; stray exc_xen_hypervisor_callback frames in the secondaries' backtraces are consistent with that. I stopped root-causing at this point. Happy to provide the full console logs, xenctx dumps at suspend/restored-paused/wedged, and the reproduction scripts, or to test patches. --0000000000003fa71a0658328abf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Saving and restoring a multi-vcp= u PV guest appears to have been broken in Linux for some time (observed 6.6= .56 and 6.12.86).=C2=A0 Report below from Claude Fable; I've independen= tly verified the behavior on vanilla Linux 6.6.56.=C2=A0 Claude seems to th= ink it's a bug in Linux.

Gitlab CI seems to on= ly run with vcpus=3D1, which is why it didn't notice.

George Dunlap
Freelance Xen consultant

8<----

A PV guest with more than one vCPU survives `xl save`, but after
`xl re= store` it never comes back: the kernel wedges mid-resume, before
xenbus = reconnect, so all frontends stay disconnected (netfront frontend
state r= emains XenbusStateInitialising, backend InitWait; vif shows
NO-CARRIER i= n dom0) and the guest is unreachable indefinitely. With
vcpus=3D1 the sa= me guest/image/kernel resumes cleanly, PVH SMP
save/restore is fine, and= the suspend-cancel path (a failed `xl save`
resuming the domain in plac= e) is also fine.

Reproduced with:
=C2=A0- Debian trixie kernel 6.= 12.86+deb13-amd64
=C2=A0- the Xen-project CI test-artifacts kernel, vani= lla 6.6.56
=C2=A0(identical signature on both, so not a 6.12 regression;= at least the
=C2=A06.6..6.12 LTS span is affected)
Host: x86-64, Xen= master/staging (4.23-unstable); also reproduced on an
older commit, so = the Xen version does not appear relevant. Plain
`xl save` + `xl restore`= of an idle 4-vCPU, 2G PV domU, direct kernel
boot, xvda file-backed dis= k, one vif. 100% reproducible.

What the resume looks like (full logs= available):

=C2=A0- Capturing the console across a paused restore (= `xl restore -p`,
=C2=A0 =C2=A0attach console, unpause) shows all seconda= ry vCPUs immediately
=C2=A0 =C2=A0splatting:

=C2=A0 =C2=A0 =C2=A0= WARNING: CPU: 1 PID: 0 at kernel/time/timekeeping.c:747 ktime_get+0xa9/0xd0=
=C2=A0 =C2=A0 =C2=A0...
=C2=A0 =C2=A0 =C2=A0 tick_nohz_idle_enter=C2=A0 =C2=A0 =C2=A0 do_idle
=C2=A0 =C2=A0 =C2=A0 cpu_startup_entry
= =C2=A0 =C2=A0 =C2=A0 cpu_bringup_and_idle
=C2=A0 =C2=A0 =C2=A0 asm_cpu_b= ringup_and_idle

=C2=A0 =C2=A0i.e. the idle task entering nohz while = timekeeping is still
=C2=A0 =C2=A0suspended =E2=80=94 with printk timest= amps taken from the *uncorrected*
=C2=A0 =C2=A0clock (pre-suspend time += the save/restore wall-clock gap), while
=C2=A0 =C2=A0CPU0's own sub= sequent resume messages ("Grant tables using version 1
=C2=A0 =C2= =A0layout", from gnttab_resume() inside xen_suspend()) carry the
= =C2=A0 =C2=A0*corrected*, earlier timestamp. The secondaries therefore left= the
=C2=A0 =C2=A0stop_machine corral before CPU0's post-suspend wor= k inside
=C2=A0 =C2=A0xen_suspend() had run, which the multi_cpu_stop st= ate machine is
=C2=A0 =C2=A0supposed to make impossible.

=C2=A0- = xenctx on the restored-but-still-paused domain shows the vCPU
=C2=A0 =C2= =A0contexts are restored faithfully (RIP-for-RIP identical to a probe
= =C2=A0 =C2=A0taken at the suspend point: vCPU0 inside the suspend hypercall= stub,
=C2=A0 =C2=A0the secondaries inside the multi_cpu_stop corral loo= p). The
=C2=A0 =C2=A0toolstack is delivering exactly what was saved; the= wedge develops
=C2=A0 =C2=A0after unpause, guest-side.

=C2=A0- E= nd state, stable forever after: vCPU0 spins at 100% inside the
=C2=A0 = =C2=A0multi_cpu_stop corral code (per xenctx; `xl vcpu-list` shows r--
= =C2=A0 =C2=A0accumulating time), while the secondary vCPUs sit blocked in=C2=A0 =C2=A0SCHED_block on their idle-task stacks. Because stop_machine(= ) never
=C2=A0 =C2=A0completes, do_suspend() never reaches xen_arch_resu= me() (so the
=C2=A0 =C2=A0secondaries' local ticks, suspended by xen= _arch_suspend() before the
=C2=A0 =C2=A0corral, are never resumed =E2=80= =94 nothing will ever wake them) nor
=C2=A0 =C2=A0xs_resume()/dpm_resume= _*() (so xenbus frontends never reconnect).

A speculative note on th= e trigger, from reading the 6.12 code =E2=80=94 treat
as unverified: xen= _vcpu_restore() (called from xen_pv_post_suspend()
while the secondaries= are mid-corral with virtual interrupts masked)
does VCPUOP_down, re-reg= isters vcpu_info via xen_vcpu_setup_restore(),
then VCPUOP_up on each se= condary. If the re-registration ends up with
evtchn_upcall_mask clear in= the newly registered vcpu_info, the vCPU
comes back up with an unexpect= ed upcall window mid-corral; stray
exc_xen_hypervisor_callback frames in= the secondaries' backtraces are
consistent with that. I stopped roo= t-causing at this point.

Happy to provide the full console logs, xen= ctx dumps at
suspend/restored-paused/wedged, and the reproduction script= s, or to
test patches.
--0000000000003fa71a0658328abf-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:19:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 07:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381933.1625361 (Exim 4.92) (envelope-from ) id 1wr9R7-0007Oj-Fb; Tue, 04 Aug 2026 07:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381933.1625361; Tue, 04 Aug 2026 07:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9R7-0007Oc-Ca; Tue, 04 Aug 2026 07:19:41 +0000 Received: by outflank-mailman (input) for mailman id 1381933; Tue, 04 Aug 2026 07:16:11 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9Nj-0006yt-Gn for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:16:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr9Ni-007h56-TR for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:16:10 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7191ba-2eae-0a2a0a5409dd-0a2a4506dbb6-2 for ; Tue, 04 Aug 2026 09:16:10 +0200 Received: from [178.62.254.231] (helo=mail.ilvokhin.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7191ba-195a-0a2a45060019-b23efee78ee2-3 for ; Tue, 04 Aug 2026 09:16:10 +0200 Received: from localhost.localdomain (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 24FC1E16D4; Tue, 04 Aug 2026 07:16:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mail header.d=ilvokhin.com header.i="@ilvokhin.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1785827769; bh=WuLqet5KqDLEqzcC11hIv1M/iVcVPFYVpjgSQGthfWs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wuKIY1D4nBbR5uq8gfZNxdmHgxtiW+Zwfk36Z3rrQRTooGhRRML5EXyzobMw0uJxv 5P/K81r2u82h7iiaVnYm4EpGO+40bXq+eTassRL9b5566xMP0Fz5dav+H08KKCBg4i JYRM7O6cFcYUV5X3SXyn9SghO75pg22YrPEy33FY= From: Dmitry Ilvokhin To: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com, Dmitry Ilvokhin Subject: [PATCH 2/5] locking: Factor out queued_spin_release() Date: Tue, 4 Aug 2026 07:15:42 +0000 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1785827770-F78CB77B-E9ACA1BD/0/0 X-purgate-type: clean X-purgate-size: 2814 The contended_release tracepoint needs to hook queued_spin_unlock(), but architectures with a custom unlock define queued_spin_unlock() directly, leaving no single generic place to add the tracing. Introduce queued_spin_release() as the arch-overridable release primitive and make queued_spin_unlock() a generic wrapper around it. An architecture that only customizes the release can then override queued_spin_release() and inherit the generic wrapper. Rename the MIPS override to queued_spin_release() accordingly. x86 paravirt overrides queued_spin_unlock() directly and is left unchanged. No functional change intended. Signed-off-by: Dmitry Ilvokhin --- arch/mips/include/asm/spinlock.h | 6 +++--- include/asm-generic/qspinlock.h | 17 ++++++++++++++--- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/arch/mips/include/asm/spinlock.h b/arch/mips/include/asm/spinlock.h index 6ce2117e49f6..c349162f15eb 100644 --- a/arch/mips/include/asm/spinlock.h +++ b/arch/mips/include/asm/spinlock.h @@ -13,12 +13,12 @@ #include -#define queued_spin_unlock queued_spin_unlock +#define queued_spin_release queued_spin_release /** - * queued_spin_unlock - release a queued spinlock + * queued_spin_release - release a queued spinlock * @lock : Pointer to queued spinlock structure */ -static inline void queued_spin_unlock(struct qspinlock *lock) +static inline void queued_spin_release(struct qspinlock *lock) { /* This could be optimised with ARCH_HAS_MMIOWB */ mmiowb(); diff --git a/include/asm-generic/qspinlock.h b/include/asm-generic/qspinlock.h index bf47cca2c375..ae45289e8ec7 100644 --- a/include/asm-generic/qspinlock.h +++ b/include/asm-generic/qspinlock.h @@ -115,12 +115,12 @@ static __always_inline void queued_spin_lock(struct qspinlock *lock) } #endif -#ifndef queued_spin_unlock +#ifndef queued_spin_release /** - * queued_spin_unlock - release a queued spinlock + * queued_spin_release - release a queued spinlock * @lock : Pointer to queued spinlock structure */ -static __always_inline void queued_spin_unlock(struct qspinlock *lock) +static __always_inline void queued_spin_release(struct qspinlock *lock) { /* * unlock() needs release semantics: @@ -129,6 +129,17 @@ static __always_inline void queued_spin_unlock(struct qspinlock *lock) } #endif +#ifndef queued_spin_unlock +/** + * queued_spin_unlock - unlock a queued spinlock + * @lock : Pointer to queued spinlock structure + */ +static __always_inline void queued_spin_unlock(struct qspinlock *lock) +{ + queued_spin_release(lock); +} +#endif + #ifndef virt_spin_lock static __always_inline bool virt_spin_lock(struct qspinlock *lock) { -- 2.53.0-Meta From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:19:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 07:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381937.1625378 (Exim 4.92) (envelope-from ) id 1wr9R8-0007ZN-7c; Tue, 04 Aug 2026 07:19:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381937.1625378; Tue, 04 Aug 2026 07:19:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9R7-0007Wz-Vh; Tue, 04 Aug 2026 07:19:41 +0000 Received: by outflank-mailman (input) for mailman id 1381937; Tue, 04 Aug 2026 07:16:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9Nl-0006z6-2A for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:16:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr9Nk-00AVMl-1r for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:16:12 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7191b9-bab6-0a2a0a5309dd-0a2a45039b3a-2 for ; Tue, 04 Aug 2026 09:16:12 +0200 Received: from [178.62.254.231] (helo=mail.ilvokhin.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7191ba-fae8-0a2a45030019-b23efee7ec10-3 for ; Tue, 04 Aug 2026 09:16:11 +0200 Received: from localhost.localdomain (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 8F84BE16D9; Tue, 04 Aug 2026 07:16:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mail header.d=ilvokhin.com header.i="@ilvokhin.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1785827769; bh=fHFQBsOvzK2/mUZmCSCVwo8JOcS+aODOMFtgBaMfo18=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0OMfUdlqT7tXp+xgFH8Lqhq8QKQ7xel10QLPov1Fj6BEEyus3KjXzGsZvJvOoCmFc HoubPtrG0hOfQ94rwZ6ss/UcnbQNjRe7uPtfYREtEbeVVgOyI7BCepcQi8X/rHThP1 7w23gEsazcnNYc12vfymcaG7+J/NylkdvJYVuzVs= From: Dmitry Ilvokhin To: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com, Dmitry Ilvokhin Subject: [PATCH 3/5] locking/qspinlock: Add contended_release tracepoint Date: Tue, 4 Aug 2026 07:15:43 +0000 Message-ID: <0d998e22a0c595f670cfc6725bb683323aced5cb.1785778551.git.d@ilvokhin.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785827771-76EF74E9-2C1F7D91/0/0 X-purgate-type: clean X-purgate-size: 7845 Unlike mutex and rw_semaphore, qspinlock has no owner field, so "perf lock contention --lock-owner" cannot attribute a contended spinlock to its holder. The waiter-side contention_begin event records that a spinlock is contended, but not by whom. Firing contended_release in the holder's context at unlock is the only way to capture the holder of a contended spinlock. Combine the contention check, trace call and release in an out-of-line queued_spin_release_traced() so the compiler need not preserve the lock pointer in a callee-saved register across the call. The check in queued_spin_unlock() is paid on every unlock, even while the tracepoint is disabled: a static-branch NOP on x86_64, and a few more instructions to manage a stack frame elsewhere. Gate it behind CONFIG_QUEUED_SPINLOCKS_TRACE_CONTENDED_RELEASE (default n) so nobody pays for a tracepoint they do not use. Sleeping locks fire contended_release regardless. On x86 this generic path is used only with PARAVIRT_SPINLOCKS=n (e.g. defconfig). PARAVIRT_SPINLOCKS=y kernels keep the paravirt static_call unlock and are wired up separately. All below are with the QUEUED_SPINLOCKS_TRACE_CONTENDED_RELEASE option enabled. _raw_spin_unlock(), x86_64 defconfig, GCC 11, tracepoint compiled in but disabled. The unlock is the single 'movb'. The only instruction added to the executed path is the 2-byte static-branch NOP. The CALL to the traced helper and the JMP back are emitted out of line and are reached only once the static branch is patched on: endbr64 ; 4 bytes xchg %ax,%ax ; 2 static-branch NOP ; (added) movb $0x0,(%rdi) ; 3 unlock (single store) A: decl %gs:__preempt_count ; 7 je B ; 2 jmp __x86_return_thunk ; 5 call queued_spin_release_traced ; 5 out of line, reached ; only when the ; tracepoint is on jmp A ; 2 (added) B: call __SCT__preempt_schedule ; 5 jmp __x86_return_thunk ; 5 Baseline is the same stream without the NOP and the out-of-line CALL/JMP: 31 bytes vs 40 (+9 bytes). Binary size impact on x86_64, defconfig: +680 bytes (+0.00%), since all standard configs out-of-line unlock. Architectures with inlined unlock (s390 (always), csky and loongarch (both when !PREEMPTION)) will see a bigger increase in binary size. On the same path (x86_64, PARAVIRT_SPINLOCKS=n) with the tracepoint disabled, a _raw_spin_unlock()-heavy nginx workload [1] shows no measurable difference between baseline and patched kernels in throughput, latency, cycles, instructions, IPC, or L1 instruction-cache misses (kernel and total): all deltas stay within run-to-run noise. Unlike x86, on arm64 the frame setup code (STP, MOV and LDP) lands on the executed path in addition to static-branch NOP. Binary size impact on arm64, defconfig: +932 bytes (+0.00%). The _raw_spin_unlock()-heavy nginx workload reflects the larger hot path: L1 instruction-cache misses rise ~1.4% (kernel and total) and instruction count ~0.4%, consistent with the per-unlock frame. cpu_cycles, throughput and latency show no measurable change and are within run-to-run noise. Architectures with fully custom qspinlock implementations (e.g. PowerPC) are not covered by this change. [1]: https://lore.kernel.org/all/aiphFXe_TPNPxZ_n@shell.ilvokhin.com/ Signed-off-by: Dmitry Ilvokhin --- include/asm-generic/qspinlock.h | 21 +++++++++++++++++++++ kernel/Kconfig.locks | 20 ++++++++++++++++++++ kernel/locking/qspinlock.c | 22 ++++++++++++++++++++++ 3 files changed, 63 insertions(+) diff --git a/include/asm-generic/qspinlock.h b/include/asm-generic/qspinlock.h index ae45289e8ec7..2ca94e41823b 100644 --- a/include/asm-generic/qspinlock.h +++ b/include/asm-generic/qspinlock.h @@ -41,6 +41,7 @@ #include #include +#include #ifndef queued_spin_is_locked /** @@ -130,12 +131,32 @@ static __always_inline void queued_spin_release(struct qspinlock *lock) #endif #ifndef queued_spin_unlock + +DECLARE_TRACEPOINT(contended_release); + +extern void queued_spin_release_traced(struct qspinlock *lock); + /** * queued_spin_unlock - unlock a queued spinlock * @lock : Pointer to queued spinlock structure + * + * Generic tracing wrapper around the arch-overridable + * queued_spin_release(). */ static __always_inline void queued_spin_unlock(struct qspinlock *lock) { + /* + * Trace and release are combined in queued_spin_release_traced() so + * the compiler does not need to preserve the lock pointer across the + * function call, avoiding callee-saved register save/restore on the + * hot path. queued_spin_release() is therefore called both here and in + * queued_spin_release_traced(). Keep the two in sync. + */ + if (IS_ENABLED(CONFIG_QUEUED_SPINLOCKS_TRACE_CONTENDED_RELEASE) && + tracepoint_enabled(contended_release)) { + queued_spin_release_traced(lock); + return; + } queued_spin_release(lock); } #endif diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks index 4198f0273ecd..1c6423aafcd4 100644 --- a/kernel/Kconfig.locks +++ b/kernel/Kconfig.locks @@ -243,6 +243,26 @@ config QUEUED_SPINLOCKS def_bool y if ARCH_USE_QUEUED_SPINLOCKS depends on SMP +config QUEUED_SPINLOCKS_TRACE_CONTENDED_RELEASE + bool "Trace contended_release on queued spinlocks" + depends on QUEUED_SPINLOCKS && TRACEPOINTS + help + Fire the lock:contended_release tracepoint when a contended queued + spinlock is released, so it is possible to attribute a contended + spinlock to its holder. + + Architectures that can patch the unlock site do this at no cost and + do not need this option. + + Everywhere else the check is compiled into queued_spin_unlock() and + a small cost is paid on every unlock even when the tracepoint is + disabled: a static-branch NOP and possibly a few more instructions + to manage a stack frame. + + Sleeping locks fire lock:contended_release regardless of this option. + + If unsure, say N. + config BPF_ARCH_SPINLOCK bool diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c index af8d122bb649..33fe6d437c8f 100644 --- a/kernel/locking/qspinlock.c +++ b/kernel/locking/qspinlock.c @@ -104,6 +104,28 @@ static __always_inline u32 __pv_wait_head_or_lock(struct qspinlock *lock, #define queued_spin_lock_slowpath native_queued_spin_lock_slowpath #endif +#if !defined(queued_spin_unlock) && \ + IS_ENABLED(CONFIG_QUEUED_SPINLOCKS_TRACE_CONTENDED_RELEASE) +/* + * Out-of-line trace-and-release path for queued_spin_unlock(), used when + * the contended_release tracepoint is enabled. + * + * queued_spin_release() is duplicated here on purpose: doing the release + * in this function (rather than tracing here and releasing in the caller) + * lets queued_spin_unlock() return right after the call, so the + * tracepoint-disabled hot path never has to keep lock live across a call + * in a callee-saved register. Keep this release in sync with the one in + * queued_spin_unlock(). + */ +void __lockfunc queued_spin_release_traced(struct qspinlock *lock) +{ + if (queued_spin_is_contended(lock)) + trace_call__contended_release(lock); + queued_spin_release(lock); +} +EXPORT_SYMBOL(queued_spin_release_traced); +#endif + #endif /* _GEN_PV_LOCK_SLOWPATH */ /** -- 2.53.0-Meta From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:19:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 07:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381934.1625367 (Exim 4.92) (envelope-from ) id 1wr9R7-0007RK-NL; Tue, 04 Aug 2026 07:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381934.1625367; Tue, 04 Aug 2026 07:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9R7-0007Qr-IG; Tue, 04 Aug 2026 07:19:41 +0000 Received: by outflank-mailman (input) for mailman id 1381934; Tue, 04 Aug 2026 07:16:12 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9Nk-0006yz-1Z for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:16:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr9Nj-005IZo-EK for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:16:11 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7191b8-e002-0a2a0a5209dd-0a2a4509d848-18 for ; Tue, 04 Aug 2026 09:16:11 +0200 Received: from [178.62.254.231] (helo=mail.ilvokhin.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7191bb-be1a-0a2a45090019-b23efee783a0-3 for ; Tue, 04 Aug 2026 09:16:11 +0200 Received: from localhost.localdomain (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 05AB4E16DC; Tue, 04 Aug 2026 07:16:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mail header.d=ilvokhin.com header.i="@ilvokhin.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1785827770; bh=Bz2CpdeYvHJ4wdtpHF06PqmuJczwotX2rk+VZpOkhHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=pap3mJ3/HxJEJFDk1E9V+MfQ4ojuK31y3RhNzciiECTAVYuygUg+AAUpw8Vg2iPD9 bo0bIm+yzmE6QIWLIch8VLiCc2NJUocvXXQ2cbg2o8M207KKA1P5DizNPLx/31xYgC RZ1Z6my1XJzOWuENeYHFx8DmI08HwyPl+3SWt/mM= From: Dmitry Ilvokhin To: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com, Dmitry Ilvokhin Subject: [PATCH 4/5] tracing/lock: Use TRACE_EVENT_FN() for contended_release Date: Tue, 4 Aug 2026 07:15:44 +0000 Message-ID: <1c2fcccfb584c075c02890c484f22c76a1948bf1.1785778551.git.d@ilvokhin.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785827771-3ACDF034-F8BD3241/0/0 X-purgate-type: clean X-purgate-size: 2205 queued_spin_unlock() gates its contended_release trace call behind a static branch, so a NOP sits on the unlock path even while the tracepoint is disabled. Removing that requires replacing the unlock implementation only while contended_release is enabled, which needs a callback when the tracepoint is toggled. Convert contended_release to TRACE_EVENT_FN() and add weak no-op arch_contended_release_trace_reg()/arch_contended_release_trace_unreg() hooks. The default hooks are empty, so this is a no-op until an architecture overrides them. No functional change intended. Signed-off-by: Dmitry Ilvokhin --- include/trace/events/lock.h | 10 ++++++++-- kernel/locking/mutex.c | 4 ++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/include/trace/events/lock.h b/include/trace/events/lock.h index 1ded869cd619..b1d5b18c4514 100644 --- a/include/trace/events/lock.h +++ b/include/trace/events/lock.h @@ -137,7 +137,11 @@ TRACE_EVENT(contention_end, TP_printk("%p (ret=%d)", __entry->lock_addr, __entry->ret) ); -TRACE_EVENT(contended_release, +/* kernel/locking/mutex.c */ +int arch_contended_release_trace_reg(void); +void arch_contended_release_trace_unreg(void); + +TRACE_EVENT_FN(contended_release, TP_PROTO(void *lock), @@ -151,7 +155,9 @@ TRACE_EVENT(contended_release, __entry->lock_addr = lock; ), - TP_printk("%p", __entry->lock_addr) + TP_printk("%p", __entry->lock_addr), + + arch_contended_release_trace_reg, arch_contended_release_trace_unreg ); #endif /* _TRACE_LOCK_H */ diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c index 8a85912d7ee6..942a939cee95 100644 --- a/kernel/locking/mutex.c +++ b/kernel/locking/mutex.c @@ -1272,6 +1272,10 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(contention_begin); EXPORT_TRACEPOINT_SYMBOL_GPL(contention_end); EXPORT_TRACEPOINT_SYMBOL_GPL(contended_release); +__weak int arch_contended_release_trace_reg(void) { return 0; } + +__weak void arch_contended_release_trace_unreg(void) { } + /** * atomic_dec_and_mutex_lock - return holding mutex if we dec to 0 * @cnt: the atomic which we are to dec -- 2.53.0-Meta From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:19:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 07:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381935.1625374 (Exim 4.92) (envelope-from ) id 1wr9R7-0007UM-VY; Tue, 04 Aug 2026 07:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381935.1625374; Tue, 04 Aug 2026 07:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9R7-0007TL-OR; Tue, 04 Aug 2026 07:19:41 +0000 Received: by outflank-mailman (input) for mailman id 1381935; Tue, 04 Aug 2026 07:16:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9Nk-0006z4-Bz for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:16:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr9Nj-007h56-P3 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:16:11 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7191b0-2eae-0a2a0a5409dd-0a2a450781e2-34 for ; Tue, 04 Aug 2026 09:16:11 +0200 Received: from [178.62.254.231] (helo=mail.ilvokhin.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7191bb-b4ea-0a2a45070019-b23efee7e7da-3 for ; Tue, 04 Aug 2026 09:16:11 +0200 Received: from localhost.localdomain (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 77194E16E0; Tue, 04 Aug 2026 07:16:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mail header.d=ilvokhin.com header.i="@ilvokhin.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1785827770; bh=MJXFdixHataYYt87xEtn0QdfMJOi3nH/EXHHrFBbQBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YCa2mhDCHjFFX0O6d3S1tYEYBR/Jb4ai4lQlH0qCvYfntcHb1/+MEaIyrBX3QT0u1 jViT9cjtE41ag6sP28YwsfmBHSjMYS3PwUlLcqd8dqfNVR1ReEl98E/Q9nIoYF3BTz G+fzkT2LOVauhNUbkR9kOT4y87KoehBEuITFVAbI= From: Dmitry Ilvokhin To: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com, Dmitry Ilvokhin Subject: [PATCH 5/5] x86/paravirt: Trace contended_release on unlock Date: Tue, 4 Aug 2026 07:15:45 +0000 Message-ID: <17fa67f9fa4cf93f1150725e89f5f916e41a9b6f.1785778551.git.d@ilvokhin.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1785827771-A60C5AE4-2400FED8/0/0 X-purgate-type: clean X-purgate-size: 4667 On PARAVIRT_SPINLOCKS=y kernels queued_spin_unlock() is dispatched through a static_call(). Those PARAVIRT_SPINLOCKS=y kernels are quite popular. Gating contended_release behind a static branch would leave a NOP on the unlock hot path even, when the tracepoint is disabled. Since the static_call() is already present, swap its target to a traced unlock, when the tracepoint is enabled instead. When contended_release tracepoint is disabled the target is the plain unlock (an inline store on native x86_64), so the unlock path is unchanged and the tracepoint is truly zero-cost. Provide two traced variants, native_queued_spin_unlock_traced() and pv_queued_spin_unlock_traced(), so each tail-calls its own base unlock directly rather than recursing through the now-traced static_call(). Teach pv_is_native_spin_unlock() that the traced native variant still counts as native. Only PARAVIRT_SPINLOCKS=y is affected. PARAVIRT_SPINLOCKS=n keeps the generic static-branch path. Suggested-by: Peter Zijlstra Signed-off-by: Dmitry Ilvokhin --- arch/x86/include/asm/paravirt-spinlock.h | 2 + arch/x86/kernel/paravirt-spinlocks.c | 53 +++++++++++++++++++++++- 2 files changed, 53 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/paravirt-spinlock.h b/arch/x86/include/asm/paravirt-spinlock.h index ff735830de4a..302bc2ba3a75 100644 --- a/arch/x86/include/asm/paravirt-spinlock.h +++ b/arch/x86/include/asm/paravirt-spinlock.h @@ -99,6 +99,8 @@ bool __raw_callee_save___native_vcpu_is_preempted(long cpu); void __init native_pv_lock_init(void); __visible void __native_queued_spin_unlock(struct qspinlock *lock); +__visible void native_queued_spin_unlock_traced(struct qspinlock *lock); +__visible void pv_queued_spin_unlock_traced(struct qspinlock *lock); bool pv_is_native_spin_unlock(void); __visible bool __native_vcpu_is_preempted(long cpu); bool pv_is_native_vcpu_is_preempted(void); diff --git a/arch/x86/kernel/paravirt-spinlocks.c b/arch/x86/kernel/paravirt-spinlocks.c index ddc19dc28ba1..ca12b3655307 100644 --- a/arch/x86/kernel/paravirt-spinlocks.c +++ b/arch/x86/kernel/paravirt-spinlocks.c @@ -7,6 +7,7 @@ #include #include #include +#include DEFINE_STATIC_KEY_FALSE(virt_spin_lock_key); @@ -30,10 +31,58 @@ EXPORT_STATIC_CALL_TRAMP(queued_spin_lock_slowpath); DEFINE_STATIC_CALL(queued_spin_unlock, __raw_callee_save___native_queued_spin_unlock); EXPORT_STATIC_CALL_TRAMP(queued_spin_unlock); +/* + * Traced unlock variants, swapped in via static_call while the + * contended_release tracepoint is enabled. Two of them, so each tail calls its + * own base directly. + */ +__visible void native_queued_spin_unlock_traced(struct qspinlock *lock) +{ + if (queued_spin_is_contended(lock)) + trace_call__contended_release(lock); + native_queued_spin_unlock(lock); +} +PV_CALLEE_SAVE_REGS_THUNK(native_queued_spin_unlock_traced); + +__visible void pv_queued_spin_unlock_traced(struct qspinlock *lock) +{ + if (queued_spin_is_contended(lock)) + trace_call__contended_release(lock); + __raw_callee_save___pv_queued_spin_unlock(lock); +} +PV_CALLEE_SAVE_REGS_THUNK(pv_queued_spin_unlock_traced); + bool pv_is_native_spin_unlock(void) { - return static_call_query(queued_spin_unlock) == - __raw_callee_save___native_queued_spin_unlock; + void *unlock = static_call_query(queued_spin_unlock); + + return unlock == __raw_callee_save___native_queued_spin_unlock || + unlock == __raw_callee_save_native_queued_spin_unlock_traced; +} + +int arch_contended_release_trace_reg(void) +{ + void *cur = static_call_query(queued_spin_unlock); + + if (cur == __raw_callee_save___native_queued_spin_unlock) + static_call_update(queued_spin_unlock, + __raw_callee_save_native_queued_spin_unlock_traced); + else if (cur == __raw_callee_save___pv_queued_spin_unlock) + static_call_update(queued_spin_unlock, + __raw_callee_save_pv_queued_spin_unlock_traced); + return 0; +} + +void arch_contended_release_trace_unreg(void) +{ + void *cur = static_call_query(queued_spin_unlock); + + if (cur == __raw_callee_save_native_queued_spin_unlock_traced) + static_call_update(queued_spin_unlock, + __raw_callee_save___native_queued_spin_unlock); + else if (cur == __raw_callee_save_pv_queued_spin_unlock_traced) + static_call_update(queued_spin_unlock, + __raw_callee_save___pv_queued_spin_unlock); } __visible bool __native_vcpu_is_preempted(long cpu) -- 2.53.0-Meta From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:25:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 07:25:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381968.1625398 (Exim 4.92) (envelope-from ) id 1wr9WS-000278-Pc; Tue, 04 Aug 2026 07:25:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381968.1625398; Tue, 04 Aug 2026 07:25:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9WS-000271-Mv; Tue, 04 Aug 2026 07:25:12 +0000 Received: by outflank-mailman (input) for mailman id 1381968; Tue, 04 Aug 2026 07:25:11 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9WR-00026p-4O for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:25:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr9WQ-007it1-Cm for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:25:10 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7193c6-2eae-0a2a0a5409dd-0a2a4501af2e-40 for ; Tue, 04 Aug 2026 09:25:10 +0200 Received: from [178.62.254.231] (helo=mail.ilvokhin.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7191b9-5984-0a2a45010019-b23efee7b86e-3 for ; Tue, 04 Aug 2026 09:16:09 +0200 Received: from localhost.localdomain (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 48833E16CF; Tue, 04 Aug 2026 07:16:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mail header.d=ilvokhin.com header.i="@ilvokhin.com" header.h="From:To:Cc:Subject:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1785827768; bh=C36dNKMErd6fEDuyOzYmXnXLzsDFA2rEQeKm0PrIEwU=; h=From:To:Cc:Subject:Date; b=zuuQlk9HFx1s4aMIaXtgkNF/m3YJ86B2QbZ83bIHeVzXGJfBm3WQ9v5qi06ycUsSA y8MsnTc4o0Lw3f7cazZ6t3ZC6FpEzOcBi4/n2bvgLJMepXG/4Pg6/7hQIy/DJBPKo1 3AcjhlumYX+Odef7Y8fxkp0G8LLBWqmj0Tg/agbQ= From: Dmitry Ilvokhin To: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com, Dmitry Ilvokhin Subject: [PATCH 0/5] locking/qspinlock: Add contended_release tracepoint Date: Tue, 4 Aug 2026 07:15:40 +0000 Message-ID: X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1785827769-C4558757-279072D9/13/0 X-purgate-type: clean X-purgate-size: 4019 The contended_release tracepoint landed in v7.2-rc2 for sleeping locks (4f070ccb4dc4 "locking: Add contended_release tracepoint to sleepable locks"). Spinlock support was dropped from that series. This one adds it for queued spinlocks. The existing contention_begin/contention_end tracepoints fire on the waiter side. The holder's identity and stack can be captured at contention_begin time (e.g. perf lock contention --lock-owner), but only for locks with an owner field to read: mutex and rwsem. qspinlock has none, so a contended spinlock cannot be attributed to its holder at all. Even where the owner can be read, it reflects the holder's state when a waiter arrives, not when the lock is released. This series adds a contended_release tracepoint to qspinlock that fires on the holder side when a lock with waiters is released. This provides: - Hold time estimation: when the holder's own acquisition was contended, its contention_end (acquisition) and contended_release can be correlated to measure how long the lock was held under contention. - The holder's stack at release time, which for spinlocks is not available by any other means. The unlock path might be quite hot, so the tracepoint is made as cheap as possible, to keep it usable in production: - x86 with PARAVIRT_SPINLOCKS=y, which is what distributions ship, swaps the unlock implementation via static_call() when the tracepoint is enabled. The disabled path is byte-identical to today's: the same inline movb, no NOP and no call. - Everywhere else a static-branch check is compiled into queued_spin_unlock(). On x86_64 that is a single NOP on the executed path, with the call to the traced helper emitted out of line and unreachable while the tracepoint is off. On other architectures a few more instructions to manage a stack frame land on the executed path too, so the generic path sits behind CONFIG_QUEUED_SPINLOCKS_TRACE_CONTENDED_RELEASE (default n). Costs and measurements are in the individual changelogs. Briefly, no throughput or latency change is measurable on either x86_64 or arm64 with QUEUED_SPINLOCKS_TRACE_CONTENDED_RELEASE=y. Tested: x86_64 with PARAVIRT_SPINLOCKS=y and =n, arm64, tracepoint on and off, disassembly checked in both states, locktorture with tracepoint on and off. Not covered: qrwlock, and architectures with fully custom qspinlock implementations (e.g. PowerPC). The stack frame managing instructions on arm64 should be avoidable, but that is not done in this patchset. Patch 1 is Peter's draft from [1] and is missing his Signed-off-by. Peter, please add it if you are happy with the patch. [1]: https://lore.kernel.org/all/20260603120811.GW3493090@noisy.programming.kicks-ass.net/ Dmitry Ilvokhin (4): locking: Factor out queued_spin_release() locking/qspinlock: Add contended_release tracepoint tracing/lock: Use TRACE_EVENT_FN() for contended_release x86/paravirt: Trace contended_release on unlock Peter Zijlstra (1): x86/paravirt: Use static_call() for the paravirt spinlock ops arch/mips/include/asm/spinlock.h | 6 +-- arch/x86/hyperv/hv_spinlock.c | 4 +- arch/x86/include/asm/cpufeatures.h | 1 - arch/x86/include/asm/paravirt-spinlock.h | 21 +++++--- arch/x86/kernel/kvm.c | 5 +- arch/x86/kernel/paravirt-spinlocks.c | 63 +++++++++++++++++++++--- arch/x86/kernel/static_call.c | 27 ++++++++++ arch/x86/xen/spinlock.c | 5 +- include/asm-generic/qspinlock.h | 38 ++++++++++++-- include/trace/events/lock.h | 10 +++- kernel/Kconfig.locks | 20 ++++++++ kernel/locking/mutex.c | 4 ++ kernel/locking/qspinlock.c | 22 +++++++++ tools/arch/x86/include/asm/cpufeatures.h | 1 - 14 files changed, 195 insertions(+), 32 deletions(-) base-commit: 5e601ab3615c86be7c4068ce992f94654693a032 -- 2.53.0-Meta From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:25:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 07:25:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381969.1625402 (Exim 4.92) (envelope-from ) id 1wr9WT-00028s-04; Tue, 04 Aug 2026 07:25:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381969.1625402; Tue, 04 Aug 2026 07:25:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9WS-00028U-TB; Tue, 04 Aug 2026 07:25:12 +0000 Received: by outflank-mailman (input) for mailman id 1381969; Tue, 04 Aug 2026 07:25:11 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9WR-00026v-Hg for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:25:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr9WQ-007nMH-R7 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:25:10 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7193c6-2eae-0a2a0a5409dd-0a2a4501af2e-44 for ; Tue, 04 Aug 2026 09:25:10 +0200 Received: from [178.62.254.231] (helo=mail.ilvokhin.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7191b9-5984-0a2a45010019-b23efee7e792-3 for ; Tue, 04 Aug 2026 09:16:09 +0200 Received: from localhost.localdomain (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id AF538E16D0; Tue, 04 Aug 2026 07:16:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mail header.d=ilvokhin.com header.i="@ilvokhin.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1785827769; bh=Hgqlc//hwpz+K1crcBkrYPgGS5kJOu9yEyqJUnHTuno=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FVNDO3r4J4MOXT5qmRaXYUu2pNzl9ZurajzLzmFoGAVSzfbChQnc8xUZc5dM6cHjl dl4A/X2nBgfn5GZv2d97IF3LH92AggOHh7cpwlOahEJLSUKNdgOV9q4kQ+BBqIcgV2 hjQ84vsVQbCOHXjwIMxPrXZCCUeUGcpJzNJ/G9uA= From: Dmitry Ilvokhin To: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com, Dmitry Ilvokhin Subject: [PATCH 1/5] x86/paravirt: Use static_call() for the paravirt spinlock ops Date: Tue, 4 Aug 2026 07:15:41 +0000 Message-ID: <9a32ae399eb804a02a31af04dcabe7e7ee4f3fdf.1785778551.git.d@ilvokhin.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1785827769-BF262757-BC7EE8D0/13/0 X-purgate-type: clean X-purgate-size: 10838 From: Peter Zijlstra queued_spin_lock_slowpath() and queued_spin_unlock() are dispatched through pv_ops_lock via the paravirt-ops ALTERNATIVE machinery, which picks the target (native inline store / hypervisor call) once at boot and cannot change at runtime. Convert both to static_call(). The site becomes a direct call patched in place (one byte smaller), and on native the unlock still collapses to the inline "movb $0, (%rdi)" store, so the fast path is unchanged. Unlike the ALTERNATIVE mechanism, a static_call() target can also be updated at runtime via static_call_update(). This is a prerequisite for the contended_release tracepoint, which has to swap in a traced unlock while the system is running. [ ilvokhin: commit message; fix PARAVIRT_SPINLOCKS=n build; teach __static_call_validate() about the inline unlock insn; make the slowpath site module-safe: static_call_mod() + EXPORT_STATIC_CALL_TRAMP(); pass @lock to the callee-save unlock, fixing a boot hang under CALL_DEPTH_TRACKING. Boot tested native + KVM PV guest. ] Link: https://lore.kernel.org/all/20260603120811.GW3493090@noisy.programming.kicks-ass.net/ Co-developed-by: Dmitry Ilvokhin Signed-off-by: Dmitry Ilvokhin --- arch/x86/hyperv/hv_spinlock.c | 4 ++-- arch/x86/include/asm/cpufeatures.h | 1 - arch/x86/include/asm/paravirt-spinlock.h | 19 +++++++++++------ arch/x86/kernel/kvm.c | 5 ++--- arch/x86/kernel/paravirt-spinlocks.c | 12 +++++------ arch/x86/kernel/static_call.c | 27 ++++++++++++++++++++++++ arch/x86/xen/spinlock.c | 5 ++--- tools/arch/x86/include/asm/cpufeatures.h | 1 - 8 files changed, 51 insertions(+), 23 deletions(-) diff --git a/arch/x86/hyperv/hv_spinlock.c b/arch/x86/hyperv/hv_spinlock.c index 210b494e4de0..6b4bdea18218 100644 --- a/arch/x86/hyperv/hv_spinlock.c +++ b/arch/x86/hyperv/hv_spinlock.c @@ -78,8 +78,8 @@ void __init hv_init_spinlocks(void) pr_info("PV spinlocks enabled\n"); __pv_init_lock_hash(); - pv_ops_lock.queued_spin_lock_slowpath = __pv_queued_spin_lock_slowpath; - pv_ops_lock.queued_spin_unlock = PV_CALLEE_SAVE(__pv_queued_spin_unlock); + static_call_update(queued_spin_lock_slowpath, __pv_queued_spin_lock_slowpath); + static_call_update(queued_spin_unlock, __raw_callee_save___pv_queued_spin_unlock); pv_ops_lock.wait = hv_qlock_wait; pv_ops_lock.kick = hv_qlock_kick; pv_ops_lock.vcpu_is_preempted = PV_CALLEE_SAVE(hv_vcpu_is_preempted); diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index 1b4a48bff18f..e41fe5c24841 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -225,7 +225,6 @@ #define X86_FEATURE_EPT_AD ( 8*32+17) /* "ept_ad" Intel Extended Page Table access-dirty bit */ #define X86_FEATURE_VMCALL ( 8*32+18) /* Hypervisor supports the VMCALL instruction */ #define X86_FEATURE_VMW_VMMCALL ( 8*32+19) /* VMware prefers VMMCALL hypercall instruction */ -#define X86_FEATURE_PVUNLOCK ( 8*32+20) /* PV unlock function */ #define X86_FEATURE_VCPUPREEMPT ( 8*32+21) /* PV vcpu_is_preempted function */ #define X86_FEATURE_TDX_GUEST ( 8*32+22) /* "tdx_guest" Intel Trust Domain Extensions Guest */ diff --git a/arch/x86/include/asm/paravirt-spinlock.h b/arch/x86/include/asm/paravirt-spinlock.h index 7beffcb08ed6..ff735830de4a 100644 --- a/arch/x86/include/asm/paravirt-spinlock.h +++ b/arch/x86/include/asm/paravirt-spinlock.h @@ -3,6 +3,7 @@ #define _ASM_X86_PARAVIRT_SPINLOCK_H #include +#include #ifdef CONFIG_SMP #include @@ -11,9 +12,6 @@ struct qspinlock; struct pv_lock_ops { - void (*queued_spin_lock_slowpath)(struct qspinlock *lock, u32 val); - struct paravirt_callee_save queued_spin_unlock; - void (*wait)(u8 *ptr, u8 val); void (*kick)(int cpu); @@ -26,20 +24,27 @@ extern struct pv_lock_ops pv_ops_lock; extern void native_queued_spin_lock_slowpath(struct qspinlock *lock, u32 val); extern void __pv_init_lock_hash(void); extern void __pv_queued_spin_lock_slowpath(struct qspinlock *lock, u32 val); +extern void __raw_callee_save___native_queued_spin_unlock(struct qspinlock *lock); extern void __raw_callee_save___pv_queued_spin_unlock(struct qspinlock *lock); extern bool nopvspin; +DECLARE_STATIC_CALL(queued_spin_lock_slowpath, native_queued_spin_lock_slowpath); +DECLARE_STATIC_CALL(queued_spin_unlock, __raw_callee_save___native_queued_spin_unlock); + static __always_inline void pv_queued_spin_lock_slowpath(struct qspinlock *lock, u32 val) { - PVOP_VCALL2(pv_ops_lock, queued_spin_lock_slowpath, lock, val); + static_call_mod(queued_spin_lock_slowpath)(lock, val); } static __always_inline void pv_queued_spin_unlock(struct qspinlock *lock) { - PVOP_ALT_VCALLEE1(pv_ops_lock, queued_spin_unlock, lock, - "movb $0, (%%" _ASM_ARG1 ")", - ALT_NOT(X86_FEATURE_PVUNLOCK)); + PVOP_CALL_ARGS; + __STATIC_CALL_MOD_ADDRESSABLE(queued_spin_unlock); + asm volatile ("call " STATIC_CALL_TRAMP_STR(queued_spin_unlock) + : PVOP_VCALLEE_CLOBBERS, ASM_CALL_CONSTRAINT + : PVOP_CALL_ARG1(lock) + : "memory", "cc"); } static __always_inline bool pv_vcpu_is_preempted(long cpu) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index dcef84da304b..253c159c4abe 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -1136,9 +1136,8 @@ void __init kvm_spinlock_init(void) pr_info("PV spinlocks enabled\n"); __pv_init_lock_hash(); - pv_ops_lock.queued_spin_lock_slowpath = __pv_queued_spin_lock_slowpath; - pv_ops_lock.queued_spin_unlock = - PV_CALLEE_SAVE(__pv_queued_spin_unlock); + static_call_update(queued_spin_lock_slowpath, __pv_queued_spin_lock_slowpath); + static_call_update(queued_spin_unlock, __raw_callee_save___pv_queued_spin_unlock); pv_ops_lock.wait = kvm_wait; pv_ops_lock.kick = kvm_kick_cpu; diff --git a/arch/x86/kernel/paravirt-spinlocks.c b/arch/x86/kernel/paravirt-spinlocks.c index 95452444868f..ddc19dc28ba1 100644 --- a/arch/x86/kernel/paravirt-spinlocks.c +++ b/arch/x86/kernel/paravirt-spinlocks.c @@ -25,9 +25,14 @@ __visible void __native_queued_spin_unlock(struct qspinlock *lock) } PV_CALLEE_SAVE_REGS_THUNK(__native_queued_spin_unlock); +DEFINE_STATIC_CALL(queued_spin_lock_slowpath, native_queued_spin_lock_slowpath); +EXPORT_STATIC_CALL_TRAMP(queued_spin_lock_slowpath); +DEFINE_STATIC_CALL(queued_spin_unlock, __raw_callee_save___native_queued_spin_unlock); +EXPORT_STATIC_CALL_TRAMP(queued_spin_unlock); + bool pv_is_native_spin_unlock(void) { - return pv_ops_lock.queued_spin_unlock.func == + return static_call_query(queued_spin_unlock) == __raw_callee_save___native_queued_spin_unlock; } @@ -45,16 +50,11 @@ bool pv_is_native_vcpu_is_preempted(void) void __init paravirt_set_cap(void) { - if (!pv_is_native_spin_unlock()) - setup_force_cpu_cap(X86_FEATURE_PVUNLOCK); - if (!pv_is_native_vcpu_is_preempted()) setup_force_cpu_cap(X86_FEATURE_VCPUPREEMPT); } struct pv_lock_ops pv_ops_lock = { - .queued_spin_lock_slowpath = native_queued_spin_lock_slowpath, - .queued_spin_unlock = PV_CALLEE_SAVE(__native_queued_spin_unlock), .wait = paravirt_nop, .kick = paravirt_nop, .vcpu_is_preempted = PV_CALLEE_SAVE(__native_vcpu_is_preempted), diff --git a/arch/x86/kernel/static_call.c b/arch/x86/kernel/static_call.c index 61592e41a6b1..bab9406e6d6a 100644 --- a/arch/x86/kernel/static_call.c +++ b/arch/x86/kernel/static_call.c @@ -4,6 +4,12 @@ #include #include +/* Declared locally to avoid pulling asm/paravirt-spinlock.h header. */ +#ifdef CONFIG_PARAVIRT_SPINLOCKS +struct qspinlock; +void __raw_callee_save___native_queued_spin_unlock(struct qspinlock *lock); +#endif + enum insn_type { CALL = 0, /* site call */ NOP = 1, /* site cond-call */ @@ -31,6 +37,17 @@ static const u8 retinsn[] = { RET_INSN_OPCODE, 0xcc, 0xcc, 0xcc, 0xcc }; */ static const u8 warninsn[] = { 0x67, 0x48, 0x0f, 0xb9, 0x3a }; +#ifdef CONFIG_PARAVIRT_SPINLOCKS +/* + * ds ds movb $0, (_ASM_ARG1) + */ +#ifdef CONFIG_64BIT +static const u8 unlockinsn[] = { 0x3e, 0x3e, 0xc6, 0x07, 0x00 }; +#else +static const u8 unlockinsn[] = { 0x3e, 0x3e, 0xc6, 0x00, 0x00 }; +#endif +#endif + static u8 __is_Jcc(u8 *insn) /* Jcc.d32 */ { u8 ret = 0; @@ -78,6 +95,12 @@ static void __ref __static_call_transform(void *insn, enum insn_type type, emulate = code; code = &warninsn; } +#ifdef CONFIG_PARAVIRT_SPINLOCKS + if (func == &__raw_callee_save___native_queued_spin_unlock) { + emulate = code; + code = &unlockinsn; + } +#endif break; case NOP: @@ -139,6 +162,10 @@ static void __static_call_validate(u8 *insn, bool tail, bool tramp) !memcmp(insn, xor5rax, 5) || !memcmp(insn, warninsn, 5)) return; +#ifdef CONFIG_PARAVIRT_SPINLOCKS + if (!memcmp(insn, unlockinsn, 5)) + return; +#endif } /* diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c index 83ac24ead289..f718e535ea7c 100644 --- a/arch/x86/xen/spinlock.c +++ b/arch/x86/xen/spinlock.c @@ -134,9 +134,8 @@ void __init xen_init_spinlocks(void) printk(KERN_DEBUG "xen: PV spinlocks enabled\n"); __pv_init_lock_hash(); - pv_ops_lock.queued_spin_lock_slowpath = __pv_queued_spin_lock_slowpath; - pv_ops_lock.queued_spin_unlock = - PV_CALLEE_SAVE(__pv_queued_spin_unlock); + static_call_update(queued_spin_lock_slowpath, __pv_queued_spin_lock_slowpath); + static_call_update(queued_spin_unlock, __raw_callee_save___pv_queued_spin_unlock); pv_ops_lock.wait = xen_qlock_wait; pv_ops_lock.kick = xen_qlock_kick; pv_ops_lock.vcpu_is_preempted = PV_CALLEE_SAVE(xen_vcpu_stolen); diff --git a/tools/arch/x86/include/asm/cpufeatures.h b/tools/arch/x86/include/asm/cpufeatures.h index 86d17b195e79..61541f042f74 100644 --- a/tools/arch/x86/include/asm/cpufeatures.h +++ b/tools/arch/x86/include/asm/cpufeatures.h @@ -225,7 +225,6 @@ #define X86_FEATURE_EPT_AD ( 8*32+17) /* "ept_ad" Intel Extended Page Table access-dirty bit */ #define X86_FEATURE_VMCALL ( 8*32+18) /* Hypervisor supports the VMCALL instruction */ #define X86_FEATURE_VMW_VMMCALL ( 8*32+19) /* VMware prefers VMMCALL hypercall instruction */ -#define X86_FEATURE_PVUNLOCK ( 8*32+20) /* PV unlock function */ #define X86_FEATURE_VCPUPREEMPT ( 8*32+21) /* PV vcpu_is_preempted function */ #define X86_FEATURE_TDX_GUEST ( 8*32+22) /* "tdx_guest" Intel Trust Domain Extensions Guest */ -- 2.53.0-Meta From xen-devel-bounces@lists.xenproject.org Tue Aug 04 07:53:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 07:53:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1381986.1625416 (Exim 4.92) (envelope-from ) id 1wr9y5-00082X-6Y; Tue, 04 Aug 2026 07:53:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1381986.1625416; Tue, 04 Aug 2026 07:53:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9y5-00082Q-3d; Tue, 04 Aug 2026 07:53:45 +0000 Received: by outflank-mailman (input) for mailman id 1381986; Tue, 04 Aug 2026 07:53:44 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wr9y4-00082K-GR for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 07:53:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wr9y3-007p01-Q2 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:53:43 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a719a7f-5cb7-0a2a0a5109dd-0a2a450ab1ae-28 for ; Tue, 04 Aug 2026 09:53:43 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a719a86-f2d2-0a2a450a0019-d1558032b9f6-3 for ; Tue, 04 Aug 2026 09:53:42 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4954a2e73a9so17436055e9.3 for ; Tue, 04 Aug 2026 00:53:42 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b8d04fsm424536895e9.3.2026.08.04.00.53.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 00:53:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785830022; x=1786434822; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0V9nSUKv/Tdm/jG0nL5ZJn57YHMdk7QgzcpAmuCQNyo=; b=K/y+m01L4Os4X++fxrQPHHrAn63rJOE/hDKd//miu/Z6Z+koPq4DKVLCEQcFCe6CAV LNzbG7IfSbAH0ZhheDm5rqip4kVn0Ylnq5aGDRTWT/q2J96TG3oTlpePLX4txnapWvkm NYqobRceDdcLIIP+aRVJS0wj7Jc99CvWfPHlkEu8Yab0YWh4iDaqsFKtdlTyI88BBuRw 66y2gUAeKaVJuEgeegysb6MNXNwrcZ1S3N7AeQVAlYTy2V0aCd6CG6548laakxL38npq 4qcySbVRIqZnAO33RZgzj3n0kStyApH463CjU626CgAJsVcP13ZnBKFspNUCbS5mJerU aDdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785830022; x=1786434822; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0V9nSUKv/Tdm/jG0nL5ZJn57YHMdk7QgzcpAmuCQNyo=; b=fU8rcQaqtTPiSJ3cAEBhNzaAY53pul6UxTNS8dirRU0lSQZ7r8RQTv9O1JeAPH7aCt towK0zs2sNfzShcdpZlWVVSf1lGTBzSHdHeIZSNrBxxfXjsk8h3/sTWVuZVw1eb/lx05 c9nN7itkBWq2bkyVkJX4jov5TcpO7p37whP6AoCHClmjyebMIOhQtoeG9OrUKe2tdnCi 1KPPlWnUt/fgLQKjW+6EbVU42zfP4u93vmwIvA0UQn8gbvFBNaGDGCmn6rcB5L/djnyW Sj6W88Rbq8Ueq7nMz3eejOXw9ekzB980CItj981Pe8mS3hl6KA71rjaTp9fmYuQxgFSL Y2Sg== X-Forwarded-Encrypted: i=1; AHgh+Rp7KYS7DdjiJBP/tm/l+RnboQ9o0+ZWeljva5uJZXef1lrjLkUCCCzJdsjYhqhU1NwbpKbAF+PdH7k=@lists.xenproject.org X-Gm-Message-State: AOJu0YxkR7v6C4U0v/8vX7h04l9U/jtjP0OxbLCqEeR/QfgCvJ1EtEzg qoIUi/meaN4Sy0UoLwG7VHGXnrTNF6PGg/TTURDRKREaJZ65/jB1yrfEF4T3mcMe5I6wLv1CDM4 RA3gR7Q== X-Gm-Gg: AR+sD10wl9RXer50s3HmQBJxFlbDiz3p6a0fKL5BKyBF4rrK155lSYkFXUO568CknG3 ZI1Fdtg7M5HMqTpu0dM+Zyjq4eVRhIZOyxbOa3obRNfc/8fTy6BDMOF7ULfCj5ea8TdqlIySGE7 2ronKopNksA61ueEt+YaCFPNXp8lrQQ7rMnks8CEs4Nm9rzYm50llv/pPR5b/OMe/A/1buFVuwJ yXU0wkOyuq9Qow6TKbHnRjERrSFi15W/tEpVDTPE7845yBbbKWB9T8jyuldi7MXHTXD+SYJtEw9 ZWR3/zvOJdKrESMm/w9mO71YmQVrCKs9NF2YvkMnlZmBQmGcp6mzFAWjMy/mJpwwgTiS4biYzvH I6a9WCUpn1qrInq2LBFLrWNgCwmn5RX0ak7++fNQGo6vZYURwSbKTvOK3jylsXPPdICSGy1KwuZ paqAffgAfqhpG8xQCfBN4WqV1R6teRUm5tn5Grg1rBeb/SBK1QLMcLq9NqNM0htk7a0IZyRb7ze udx2ct1fLv2b2O3fL+ThhGWAeCjwLUqsIamJY9a2CPrbAdPLNms X-Received: by 2002:a05:600c:6209:b0:495:6396:8b67 with SMTP id 5b1f17b1804b1-4980c649f67mr323207235e9.4.1785830022317; Tue, 04 Aug 2026 00:53:42 -0700 (PDT) Message-ID: <8097d8e8-42ec-463a-8247-56c9e4d834cd@suse.com> Date: Tue, 4 Aug 2026 09:53:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: Jason Andryuk Cc: Daniel Smith , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1785830022-589C9CFC-5C6B7CF0/0/0 X-purgate-type: clean X-purgate-size: 2399 On 03.08.2026 23:01, Jason Andryuk wrote: > On 2026-07-28 09:22, Jan Beulich wrote: >> --- a/xen/include/xsm/dummy.h >> +++ b/xen/include/xsm/dummy.h > >> @@ -751,27 +751,32 @@ static XSM_INLINE int xsm_dm_op(XSM_DEFA >> #endif >> >> #ifdef CONFIG_ARGO >> -static XSM_INLINE int xsm_argo_enable(const struct domain *d) >> + >> +static XSM_INLINE int xsm_argo_enable(XSM_DEFAULT_ARG const struct domain *d) >> { >> - return 0; >> + XSM_ASSERT_ACTION(XSM_HOOK); >> + return xsm_default_action(action, current->domain, d); > > This one I think should be > return xsm_default_action(action, d, NULL); > > Usually current is passed in for the check, but for domain_create() -> > argo_init() it is the under-construction domain. And in that case we want to make sure that current->domain may enable Argo for d. >> } >> >> static XSM_INLINE int xsm_argo_register_single_source( >> - const struct domain *d, const struct domain *t) >> + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) >> { >> - return 0; >> + XSM_ASSERT_ACTION(XSM_HOOK); >> + return xsm_default_action(action, d, t); >> } >> >> static XSM_INLINE int xsm_argo_register_any_source( >> - const struct domain *d) >> + XSM_DEFAULT_ARG const struct domain *d) >> { >> - return 0; >> + XSM_ASSERT_ACTION(XSM_HOOK); >> + return xsm_default_action(action, current->domain, d); > > Similarly: > return xsm_default_action(action, d, NULL); > > The single call is: > xsm_argo_register_any_source(currd); There being just a single call puts this on the edge. If there was another one not passing current->domain, I think the same argument as above would hold here. And the general concept is what I think should matter when writing the dummy implementations. > These argo hooks all pass in their arguments explicitly, so I think we > should do that and not use current. (The send and register hooks could > use current, and that could make sense as those map to hypercalls. But > it is correct today with the explicit arguments.) > > With the changes: > Reviewed-by: Jason Andryuk Thanks, but no - unless I misunderstand how permissions are intended to work here, I don't think I can make the changes requested, and hence I can't apply the R-b. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 08:01:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 08:01:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382005.1625425 (Exim 4.92) (envelope-from ) id 1wrA5a-0002Ew-BY; Tue, 04 Aug 2026 08:01:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382005.1625425; Tue, 04 Aug 2026 08:01:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrA5a-0002Ep-8h; Tue, 04 Aug 2026 08:01:30 +0000 Received: by outflank-mailman (input) for mailman id 1382005; Tue, 04 Aug 2026 08:01:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrA5Y-0002Ej-7j for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 08:01:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrA5W-00AeaW-HW for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:01:26 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a719c54-5cb7-0a2a0a5109dd-0a2a45058332-2 for ; Tue, 04 Aug 2026 10:01:26 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a719b65-4cb1-0a2a45050019-d155802ab00d-3 for ; Tue, 04 Aug 2026 09:57:25 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4954d29264cso14977445e9.2 for ; Tue, 04 Aug 2026 00:57:25 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a0f7b86sm64048765e9.10.2026.08.04.00.57.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 00:57:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785830245; x=1786435045; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=qVb1MOqU1bZoDcbi0BZfBIW2AUDTbUQ2MWUzyPm0KVs=; b=eAXU2M2hR7Tqlw2as0AJ0rgcNhxjvmJ4Of+krK7As4LAHjta+CmzkqrY7nGR6X6Spn uoWowMEevbS/AX2pzUt73pYX8trxIwH0Nd95iJIt/l6F8bJFe8Ie6NzNrLWf9HdW6N8w RzcGyeL5K0NSsJCuXVCbrFtmefrIpmBKeqnNH3dbdn6h1voXLs/EFIOV6IFEAC3u7k6m JIivVHuVagOwAXA9OGore8iUg6AH+CsNzA0pfy9BGCA5tXYLtaqqBq7HZl0VjkTWTsms qIbjUTcxneACK75tV87oc2Ruq+kd7QSEXdE8+C2Tn8UlWrrQ1FGvZUEWGQlLWXbWVcdA bH1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785830245; x=1786435045; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qVb1MOqU1bZoDcbi0BZfBIW2AUDTbUQ2MWUzyPm0KVs=; b=sAHGx1pS31AdMZupi3Te0bKa2A0TVx2nIlGJQAt7VhvupWppImpTMgtGomEkSgFMeh HeWz0j1Ugv0l9uDwUlY97w5ff/SFtuKTPL6R+lLItivFeOtSck/IEW0P/vfw/6Hlpxbt r5w+nqvtr9H9MbBXa2uv6P8TQcH5kSeKsOaWnLl0fYs4cdKHADiC2bAnzBPWOlOOZx3f MKzJD9o1p1pZfe8GuoKG701vMxPKwC84IPUAfVH4mh3S0yODgHHfGMJXhCamwBRrgxSY YEhYE4FC9skDSLA2NPoCLLT363XC8RFllhratkbDjtLF4cLJmiILWB3dnQAEIR2WaIee pmxw== X-Forwarded-Encrypted: i=1; AHgh+Rq6hqZUwg6VgqvqV95I/Bskdaj5xTCtXpPjmmgqtO+KEMae1RK0X/IAC1A16jfO6CvOz9No0dfYxgY=@lists.xenproject.org X-Gm-Message-State: AOJu0Yybbcd+AzivJ0dTIQMxz0CyB11VFebv3JnXYppGhv9h6WsWE6dV 3Ia6jc+gW6I8swstzcioVEHkx3fLNnufWnvzbG43eqKgIs+hg/sVDB1bxafzFOHFCTc= X-Gm-Gg: AR+sD11Qg2sOKuoz7AjboZdtaF3YKo/2mKGfK4E9OzAgRuMTm7Qeltay9cX5G3EMfdt SHa8VSWhf7DoZYIx6m2TdO2hoHezk2WJ9o17lA+sZFZSdeyGLPDIIZuXghsES4gPHoBpaeffvLr g0FSOwTi/3PtCgrsatBw4QCd82D4fsWz800pDWRgXsUi7rBHmlUVRGpPnp7q+6IJJ/A9fKG19el 49Uy8pOFInUhKF3y7swDOmxA500nMpOkMbfJGYZdD5T7YqgaK1KzNmDk+2WZdXX7xpSPF1ur1B5 hhoEvcCKDgsXIbi4TS5o1Kyzy6Z1vlK1WWbVTNB2oIce3cJ5TmrRdExhIevnk7HtYbwt8GyWa4n hcQIJEUfGbLgHBtwjqtA1LsWjTG2QWwple0XUYw2MForSy/bhuDgyyoY2zcXs2tzXEAhIktKjlN wgii9pkZ6BaTERTXV13X0YkySgJHgiN5VoC4qK0w2lXRjDt42KiHpi7kvPt8fW3ggvJUsV4kM2u QMXmpvzCWWFvzBDmqV5yijuYNT3m8ukIuk54qA70gNQoKyq6gnNr4tDhGuTYn1/q6pfpfwtkAd2 5WmjkWx0pJoPzV4= X-Received: by 2002:a05:600c:8b54:b0:495:4859:8f9b with SMTP id 5b1f17b1804b1-4980c674f25mr345983915e9.9.1785830245215; Tue, 04 Aug 2026 00:57:25 -0700 (PDT) Message-ID: <627c59ee-54b1-4f37-b849-c331a9d01618@suse.com> Date: Tue, 4 Aug 2026 09:57:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] locking/qspinlock: Add contended_release tracepoint To: Dmitry Ilvokhin , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com References: Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------AEfGGk6p5V0hCBAWv3tcK3FA" X-purgate-ID: tlsNG-c201ff/1785830245-716AD2A1-F4F27DED/13/0 X-purgate-type: clean X-purgate-size: 13448 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------AEfGGk6p5V0hCBAWv3tcK3FA Content-Type: multipart/mixed; boundary="------------HRWVg0V4yc1LTGims01Et589"; protected-headers="v1" From: Juergen Gross To: Dmitry Ilvokhin , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com Message-ID: <627c59ee-54b1-4f37-b849-c331a9d01618@suse.com> Subject: Re: [PATCH 0/5] locking/qspinlock: Add contended_release tracepoint References: In-Reply-To: --------------HRWVg0V4yc1LTGims01Et589 Content-Type: multipart/mixed; boundary="------------33sYuJhXGYzE04xG2wTAikO4" --------------33sYuJhXGYzE04xG2wTAikO4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjYgMDk6MTUsIERtaXRyeSBJbHZva2hpbiB3cm90ZToNCj4gVGhlIGNvbnRl bmRlZF9yZWxlYXNlIHRyYWNlcG9pbnQgbGFuZGVkIGluIHY3LjItcmMyIGZvciBzbGVlcGlu ZyBsb2Nrcw0KPiAoNGYwNzBjY2I0ZGM0ICJsb2NraW5nOiBBZGQgY29udGVuZGVkX3JlbGVh c2UgdHJhY2Vwb2ludCB0byBzbGVlcGFibGUNCj4gbG9ja3MiKS4gU3BpbmxvY2sgc3VwcG9y dCB3YXMgZHJvcHBlZCBmcm9tIHRoYXQgc2VyaWVzLiBUaGlzIG9uZSBhZGRzIGl0DQo+IGZv ciBxdWV1ZWQgc3BpbmxvY2tzLg0KPiANCj4gVGhlIGV4aXN0aW5nIGNvbnRlbnRpb25fYmVn aW4vY29udGVudGlvbl9lbmQgdHJhY2Vwb2ludHMgZmlyZSBvbiB0aGUNCj4gd2FpdGVyIHNp ZGUuIFRoZSBob2xkZXIncyBpZGVudGl0eSBhbmQgc3RhY2sgY2FuIGJlIGNhcHR1cmVkIGF0 DQo+IGNvbnRlbnRpb25fYmVnaW4gdGltZSAoZS5nLiBwZXJmIGxvY2sgY29udGVudGlvbiAt LWxvY2stb3duZXIpLCBidXQgb25seQ0KPiBmb3IgbG9ja3Mgd2l0aCBhbiBvd25lciBmaWVs ZCB0byByZWFkOiBtdXRleCBhbmQgcndzZW0uIHFzcGlubG9jayBoYXMNCj4gbm9uZSwgc28g YSBjb250ZW5kZWQgc3BpbmxvY2sgY2Fubm90IGJlIGF0dHJpYnV0ZWQgdG8gaXRzIGhvbGRl ciBhdCBhbGwuDQo+IEV2ZW4gd2hlcmUgdGhlIG93bmVyIGNhbiBiZSByZWFkLCBpdCByZWZs ZWN0cyB0aGUgaG9sZGVyJ3Mgc3RhdGUgd2hlbiBhDQo+IHdhaXRlciBhcnJpdmVzLCBub3Qg d2hlbiB0aGUgbG9jayBpcyByZWxlYXNlZC4NCj4gDQo+IFRoaXMgc2VyaWVzIGFkZHMgYSBj b250ZW5kZWRfcmVsZWFzZSB0cmFjZXBvaW50IHRvIHFzcGlubG9jayB0aGF0IGZpcmVzDQo+ IG9uIHRoZSBob2xkZXIgc2lkZSB3aGVuIGEgbG9jayB3aXRoIHdhaXRlcnMgaXMgcmVsZWFz ZWQuIFRoaXMgcHJvdmlkZXM6DQo+IA0KPiAtIEhvbGQgdGltZSBlc3RpbWF0aW9uOiB3aGVu IHRoZSBob2xkZXIncyBvd24gYWNxdWlzaXRpb24gd2FzDQo+ICAgIGNvbnRlbmRlZCwgaXRz IGNvbnRlbnRpb25fZW5kIChhY3F1aXNpdGlvbikgYW5kIGNvbnRlbmRlZF9yZWxlYXNlDQo+ ICAgIGNhbiBiZSBjb3JyZWxhdGVkIHRvIG1lYXN1cmUgaG93IGxvbmcgdGhlIGxvY2sgd2Fz IGhlbGQgdW5kZXINCj4gICAgY29udGVudGlvbi4NCj4gDQo+IC0gVGhlIGhvbGRlcidzIHN0 YWNrIGF0IHJlbGVhc2UgdGltZSwgd2hpY2ggZm9yIHNwaW5sb2NrcyBpcyBub3QNCj4gICAg YXZhaWxhYmxlIGJ5IGFueSBvdGhlciBtZWFucy4NCj4gDQo+IFRoZSB1bmxvY2sgcGF0aCBt aWdodCBiZSBxdWl0ZSBob3QsIHNvIHRoZSB0cmFjZXBvaW50IGlzIG1hZGUgYXMgY2hlYXAN Cj4gYXMgcG9zc2libGUsIHRvIGtlZXAgaXQgdXNhYmxlIGluIHByb2R1Y3Rpb246DQo+IA0K PiAtIHg4NiB3aXRoIFBBUkFWSVJUX1NQSU5MT0NLUz15LCB3aGljaCBpcyB3aGF0IGRpc3Ry aWJ1dGlvbnMgc2hpcCwgc3dhcHMNCj4gICAgdGhlIHVubG9jayBpbXBsZW1lbnRhdGlvbiB2 aWEgc3RhdGljX2NhbGwoKSB3aGVuIHRoZSB0cmFjZXBvaW50IGlzDQo+ICAgIGVuYWJsZWQu IFRoZSBkaXNhYmxlZCBwYXRoIGlzIGJ5dGUtaWRlbnRpY2FsIHRvIHRvZGF5J3M6IHRoZSBz YW1lDQo+ICAgIGlubGluZSBtb3ZiLCBubyBOT1AgYW5kIG5vIGNhbGwuDQo+IA0KPiAtIEV2 ZXJ5d2hlcmUgZWxzZSBhIHN0YXRpYy1icmFuY2ggY2hlY2sgaXMgY29tcGlsZWQgaW50bw0K PiAgICBxdWV1ZWRfc3Bpbl91bmxvY2soKS4gT24geDg2XzY0IHRoYXQgaXMgYSBzaW5nbGUg Tk9QIG9uIHRoZSBleGVjdXRlZA0KPiAgICBwYXRoLCB3aXRoIHRoZSBjYWxsIHRvIHRoZSB0 cmFjZWQgaGVscGVyIGVtaXR0ZWQgb3V0IG9mIGxpbmUgYW5kDQo+ICAgIHVucmVhY2hhYmxl IHdoaWxlIHRoZSB0cmFjZXBvaW50IGlzIG9mZi4gT24gb3RoZXIgYXJjaGl0ZWN0dXJlcyBh IGZldw0KPiAgICBtb3JlIGluc3RydWN0aW9ucyB0byBtYW5hZ2UgYSBzdGFjayBmcmFtZSBs YW5kIG9uIHRoZSBleGVjdXRlZCBwYXRoDQo+ICAgIHRvbywgc28gdGhlIGdlbmVyaWMgcGF0 aCBzaXRzIGJlaGluZA0KPiAgICBDT05GSUdfUVVFVUVEX1NQSU5MT0NLU19UUkFDRV9DT05U RU5ERURfUkVMRUFTRSAoZGVmYXVsdCBuKS4NCj4gDQo+IENvc3RzIGFuZCBtZWFzdXJlbWVu dHMgYXJlIGluIHRoZSBpbmRpdmlkdWFsIGNoYW5nZWxvZ3MuIEJyaWVmbHksIG5vDQo+IHRo cm91Z2hwdXQgb3IgbGF0ZW5jeSBjaGFuZ2UgaXMgbWVhc3VyYWJsZSBvbiBlaXRoZXIgeDg2 XzY0IG9yIGFybTY0DQo+IHdpdGggUVVFVUVEX1NQSU5MT0NLU19UUkFDRV9DT05URU5ERURf UkVMRUFTRT15Lg0KPiANCj4gVGVzdGVkOiB4ODZfNjQgd2l0aCBQQVJBVklSVF9TUElOTE9D S1M9eSBhbmQgPW4sIGFybTY0LCB0cmFjZXBvaW50IG9uDQo+IGFuZCBvZmYsIGRpc2Fzc2Vt Ymx5IGNoZWNrZWQgaW4gYm90aCBzdGF0ZXMsIGxvY2t0b3J0dXJlIHdpdGggdHJhY2Vwb2lu dA0KPiBvbiBhbmQgb2ZmLg0KPiANCj4gTm90IGNvdmVyZWQ6IHFyd2xvY2ssIGFuZCBhcmNo aXRlY3R1cmVzIHdpdGggZnVsbHkgY3VzdG9tIHFzcGlubG9jaw0KPiBpbXBsZW1lbnRhdGlv bnMgKGUuZy4gUG93ZXJQQykuIFRoZSBzdGFjayBmcmFtZSBtYW5hZ2luZyBpbnN0cnVjdGlv bnMgb24NCj4gYXJtNjQgc2hvdWxkIGJlIGF2b2lkYWJsZSwgYnV0IHRoYXQgaXMgbm90IGRv bmUgaW4gdGhpcyBwYXRjaHNldC4NCj4gDQo+IFBhdGNoIDEgaXMgUGV0ZXIncyBkcmFmdCBm cm9tIFsxXSBhbmQgaXMgbWlzc2luZyBoaXMgU2lnbmVkLW9mZi1ieS4NCj4gUGV0ZXIsIHBs ZWFzZSBhZGQgaXQgaWYgeW91IGFyZSBoYXBweSB3aXRoIHRoZSBwYXRjaC4NCj4gDQo+IFsx XTogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjYwNjAzMTIwODExLkdXMzQ5MzA5 MEBub2lzeS5wcm9ncmFtbWluZy5raWNrcy1hc3MubmV0Lw0KPiANCj4gRG1pdHJ5IElsdm9r aGluICg0KToNCj4gICAgbG9ja2luZzogRmFjdG9yIG91dCBxdWV1ZWRfc3Bpbl9yZWxlYXNl KCkNCj4gICAgbG9ja2luZy9xc3BpbmxvY2s6IEFkZCBjb250ZW5kZWRfcmVsZWFzZSB0cmFj ZXBvaW50DQo+ICAgIHRyYWNpbmcvbG9jazogVXNlIFRSQUNFX0VWRU5UX0ZOKCkgZm9yIGNv bnRlbmRlZF9yZWxlYXNlDQo+ICAgIHg4Ni9wYXJhdmlydDogVHJhY2UgY29udGVuZGVkX3Jl bGVhc2Ugb24gdW5sb2NrDQo+IA0KPiBQZXRlciBaaWpsc3RyYSAoMSk6DQo+ICAgIHg4Ni9w YXJhdmlydDogVXNlIHN0YXRpY19jYWxsKCkgZm9yIHRoZSBwYXJhdmlydCBzcGlubG9jayBv cHMNCj4gDQo+ICAgYXJjaC9taXBzL2luY2x1ZGUvYXNtL3NwaW5sb2NrLmggICAgICAgICB8 ICA2ICstLQ0KPiAgIGFyY2gveDg2L2h5cGVydi9odl9zcGlubG9jay5jICAgICAgICAgICAg fCAgNCArLQ0KPiAgIGFyY2gveDg2L2luY2x1ZGUvYXNtL2NwdWZlYXR1cmVzLmggICAgICAg fCAgMSAtDQo+ICAgYXJjaC94ODYvaW5jbHVkZS9hc20vcGFyYXZpcnQtc3BpbmxvY2suaCB8 IDIxICsrKysrLS0tDQo+ICAgYXJjaC94ODYva2VybmVsL2t2bS5jICAgICAgICAgICAgICAg ICAgICB8ICA1ICstDQo+ICAgYXJjaC94ODYva2VybmVsL3BhcmF2aXJ0LXNwaW5sb2Nrcy5j ICAgICB8IDYzICsrKysrKysrKysrKysrKysrKysrKy0tLQ0KPiAgIGFyY2gveDg2L2tlcm5l bC9zdGF0aWNfY2FsbC5jICAgICAgICAgICAgfCAyNyArKysrKysrKysrDQo+ICAgYXJjaC94 ODYveGVuL3NwaW5sb2NrLmMgICAgICAgICAgICAgICAgICB8ICA1ICstDQo+ICAgaW5jbHVk ZS9hc20tZ2VuZXJpYy9xc3BpbmxvY2suaCAgICAgICAgICB8IDM4ICsrKysrKysrKysrKy0t DQo+ICAgaW5jbHVkZS90cmFjZS9ldmVudHMvbG9jay5oICAgICAgICAgICAgICB8IDEwICsr Ky0NCj4gICBrZXJuZWwvS2NvbmZpZy5sb2NrcyAgICAgICAgICAgICAgICAgICAgIHwgMjAg KysrKysrKysNCj4gICBrZXJuZWwvbG9ja2luZy9tdXRleC5jICAgICAgICAgICAgICAgICAg IHwgIDQgKysNCj4gICBrZXJuZWwvbG9ja2luZy9xc3BpbmxvY2suYyAgICAgICAgICAgICAg IHwgMjIgKysrKysrKysrDQo+ICAgdG9vbHMvYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVh dHVyZXMuaCB8ICAxIC0NCj4gICAxNCBmaWxlcyBjaGFuZ2VkLCAxOTUgaW5zZXJ0aW9ucygr KSwgMzIgZGVsZXRpb25zKC0pDQo+IA0KPiANCj4gYmFzZS1jb21taXQ6IDVlNjAxYWIzNjE1 Yzg2YmU3YzQwNjhjZTk5MmY5NDY1NDY5M2EwMzINCg0KRm9yIHRoZSB3aG9sZSBzZXJpZXM6 DQoNCkFja2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCkknbSBj b25zaWRlcmluZyBzb21lIGZvbGxvd3VwIHBhdGNoZXMgcmVwbGFjaW5nIHRoZSByZW1haW5p bmcgcGFyYXZpcnQNCmNhc2VzIG5vdCBjb3ZlcmVkIGJ5IENPTkZJR19QQVJBVklSVF9YWEwg d2l0aCBzdGF0aWNfY2FsbCgpLCB0b28uDQoNClRoaXMgd2lsbCBhbGxvdyB0byBkcm9wIHRo ZSAzMi1iaXQgcGFyYXZpcnQgcGF0Y2hpbmcgY29tcGxldGVseS4gOi0pDQoNClRoZSBxdWV1 ZWRfc3Bpbl91bmxvY2soKSBob29rIHdhcyB0aGUgbWFpbiByZWFzb24gSSBkaWRuJ3QgZG8g dGhhdCB5ZXQuDQoNCg0KSnVlcmdlbg0K --------------33sYuJhXGYzE04xG2wTAikO4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------33sYuJhXGYzE04xG2wTAikO4-- --------------HRWVg0V4yc1LTGims01Et589-- --------------AEfGGk6p5V0hCBAWv3tcK3FA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpxm2MFAwAAAAAACgkQsN6d1ii/Ey+9 Agf+IWx5eXJ7mO6oP+n4rxGw46J5o8kxhJQXckuPe4UqJ4KZp2eDhMwkS/QfmUPt+V4ojeOdZa1V t5qalPRfTCjVf4ZjarkTErmzJEGtvM5UFOPA1nJBFIGlV8VkDzRzYXof0c0ySuzecPKbh7pY3vUz VAUq0Q4EI6/WZY9jlKSQPoVjFFnIaWF5MoA2mGETIaZNXIBKSb/JmKfyRKxoY+u6IIeXrzl3wnIp VRnKsfQY36idWLXCtgq72WaTEl8HBUfpg0cTNGX0Fs6DZ4wH41e/KenwyCtV/RoC9vMyVKhvshqA JQOnAn0AVEbRYSsu6FmlqT/H4mCv6HrNanDhE76nUA== =gT7a -----END PGP SIGNATURE----- --------------AEfGGk6p5V0hCBAWv3tcK3FA-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 08:02:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 08:02:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382013.1625435 (Exim 4.92) (envelope-from ) id 1wrA6p-0002m6-Q1; Tue, 04 Aug 2026 08:02:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382013.1625435; Tue, 04 Aug 2026 08:02:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrA6p-0002lz-Lq; Tue, 04 Aug 2026 08:02:47 +0000 Received: by outflank-mailman (input) for mailman id 1382013; Tue, 04 Aug 2026 08:02:46 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrA6o-0002lq-EL for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 08:02:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrA6n-002m56-RE for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:02:45 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a719c9e-e002-0a2a0a5209dd-0a2a45079228-22 for ; Tue, 04 Aug 2026 10:02:45 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a719ca5-b4ea-0a2a45070019-d1558032e8bc-3 for ; Tue, 04 Aug 2026 10:02:45 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4954f5e8020so14270615e9.2 for ; Tue, 04 Aug 2026 01:02:45 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fc2ff6sm61006725e9.1.2026.08.04.01.02.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 01:02:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785830565; x=1786435365; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=86lG+DPRfxOIdxiwMYJYnP52hG1gKOaF+TCIcTnAaM4=; b=c+gtxNu+6XbnY0AxLVpUXJqa7TV2MYxdLzhgmRBFc8Endh5EhJonFkI6Y99Zo3bEbB X1skoq6n2HdGVHE2s7EjSRANeEj50qUIvFzCPrvslI/UZfM6qZ0J4QLIawmcyiBUQDXI 9So/Uo3mHnBN58c1SeXNa6iHT3hMSw9MJIXoP9M23dYKJPFg9asPG9g6XeILoAEJTQO0 82zIOYv5HWCBvWhMO+4ybTMY2nSA6THgTnr/khkAZSWim9oGo+20itt9AwUqFpreo1Nw J9+nR9LEy0A6fZMM7rFG9IR2FDnQ+RACDbiTzcgBo9CFSIo3zp3qe6SpWVJE2yyoGgfZ idfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785830565; x=1786435365; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=86lG+DPRfxOIdxiwMYJYnP52hG1gKOaF+TCIcTnAaM4=; b=C44G0LOvpuLJ0USwq/D7PHsD2Ozz/wQARwJUV9fRrBVl6wsRJvsRIbHZ6iAQZeZGr9 M0ksIX9u/DWeiPtl+P8/l0MevVTVGEEw+lw3BNAJtsjjZQIcKLjdp1DggUp1j6SygNfM 1XS5vF/cIE8Vcl3naEGqFC24ZuhV+LAGoTxUn3gkJfaR7mv4Sk1/Iv4dTfl3O8SzFVD1 sHLmfMyFsCtYcDCCjLfRRilRbn662PsaZQgd/BTCZ5zGVL0Ibdie3ev/aBi4Soycwh53 gdWaawCgGCTesL4OVRz+LhBrWY9UfCHiaWvo9XusygGLzQ0MKQf1vnOSmYcj2gMsyqFc WUrw== X-Forwarded-Encrypted: i=1; AHgh+Rr72PA0ckmkBVCecEXb+cN/qOO07zO6W3lneeMiUhY7LSUjmv4EDrJqQ2JQ7cF2vzVwGC9ex/sA2Vg=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy4PYJzuW9sGAQvKlYUvNFSxaezY2BGrdIGq78udGpzolInFALT 1/C8BSkw6elPOZpP6ophfP3wjFsZECkFtkh4+ZXJg0uPtU+kIvRNky/XXzgo9eYYNYy7qJlQoUl c+H9vnw== X-Gm-Gg: AR+sD119J6OocNKKv/jwuNRpJ0T79+P64jFppCsW83VySyCflMTlu43EBYhActpBKav jHRpQaEZjmH6+Kjs2YXvzi5GxqHrAYqUKBgWN5AHS4vQ0QeWX8ymyByQz39N4RfMlJYQKKQL5sT NJ1jcMc/ocJ1EQo2sy9GhmxrIDCa4uJXAHDNa22OmsaR0HwN6DE75LvoN9JVH16eHD9Lj4FyoRl umAM90a3Opvii6Bqc3d405lRBDUpoovXhr3lPq1DCLAcsh62Cf1HsR8X4nuaevz8cSXxo1vAYcc nt8j9Ue65pZ9I6ZmSLO3nEXZW92hfr/QPyXRk5EOLmqblZh0XLcml0dXuEcs3iftBZsPLeuWM+C kJk1UkWEYbtmaXRdO9G5ZoMVYa8DASL0v8/RyGQdK1HOhgY4ozYs+ucH1kpYwzWaeinM/gweEoP h0yn09jPc2JAGVomSWaEGo3lJObdqZwk34J6748NONbPI61VSz5k3thuL6eI2IT9aKfBkMiDvjk yijcSwS0bN525lBwZZHaZ6MQ7qztY70YnSazmWBtwcN8I+IwMyNqptGECqzXlQ= X-Received: by 2002:a05:600c:e557:10b0:495:5890:8f6c with SMTP id 5b1f17b1804b1-4980c64b824mr211207245e9.7.1785830564585; Tue, 04 Aug 2026 01:02:44 -0700 (PDT) Message-ID: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> Date: Tue, 4 Aug 2026 10:02:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux PV domU with >1 vCPU never resumes after xl save/restore To: George Dunlap Cc: Juergen Gross , xen-devel References: Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1785830565-374D3AE4-8F51320E/0/0 X-purgate-type: clean X-purgate-size: 512 On 04.08.2026 08:12, George Dunlap wrote: > Saving and restoring a multi-vcpu PV guest appears to have been broken in > Linux for some time (observed 6.6.56 and 6.12.86). Report below from > Claude Fable; I've independently verified the behavior on vanilla Linux > 6.6.56. Claude seems to think it's a bug in Linux. Just to double check, as there was a crucial fix there recently: This is with a Xen including bedbc17d8407 ("x86/domctl: restore all registers in arch_{get,set}_info_guest()")? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 08:45:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 08:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382033.1625444 (Exim 4.92) (envelope-from ) id 1wrAln-0001AD-Qe; Tue, 04 Aug 2026 08:45:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382033.1625444; Tue, 04 Aug 2026 08:45:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrAln-0001A6-MO; Tue, 04 Aug 2026 08:45:07 +0000 Received: by outflank-mailman (input) for mailman id 1382033; Tue, 04 Aug 2026 08:45:07 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrAln-0001A0-18 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 08:45:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrAlm-00E1pE-4h for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:45:06 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71a691-2eae-0a2a0a5409dd-0a2a4504ec10-2 for ; Tue, 04 Aug 2026 10:45:05 +0200 Received: from [209.85.208.44] (helo=mail-ed1-f44.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71a691-b57f-0a2a45040019-d155d02ca540-3 for ; Tue, 04 Aug 2026 10:45:05 +0200 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6a08a2b7e5bso1531887a12.1 for ; Tue, 04 Aug 2026 01:45:05 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a0d0ed21aesm3184111a12.5.2026.08.04.01.45.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 01:45:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785833105; x=1786437905; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=iaU3/gpq/3H9J2szYrRVZY+0G842nsPIgdgjVJmjc6g=; b=IB7LSZDeQyhNCxoJZ0zsfv+t9ssHCXs8r1LqgyDKauvVJ1Q0TtcahKQnuGR+BMuqN7 vGKe/iFphg7+WEbvVQLVDuti3kkhPMeYRxmlOKWNOZYNGbXm4hp3+1XlMJcJLhKXbh08 Af/BtjcSD5Lxwax2JcjX2fNQ2tLryfKDZoJtdqvdQZFh48j85V/HR6VV0IYNckc0Mbuk waFeMwRW+5mXtP+fWBSdX2B/fcwc4EzikUda6jp4H15MARGqFE6NcKJxoKSA/sMbW8S/ 8M+xTTHCoRWz94Dve61yqFGfP6ugxsdZH6Xg0jr6SI6rtbJ6tVLM+CXvG6u/ElnaZwiU fCKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785833105; x=1786437905; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iaU3/gpq/3H9J2szYrRVZY+0G842nsPIgdgjVJmjc6g=; b=hRaOP3z80UpKOIDO3/+g+URvi+0CMikCHCCuPS3ddybAmxA6ykau1AGcaFzrSpBoGX STN6D0DtfEIkeNe1Vni65hjnTqHNpM660AmrinXNRqzZBvxWMfk6Q1WPyEA6RhO2d/QH aRXKhCi2G6uidKQFMA4tzB60PqlKStOM9EpZmFgi3lDzmVBxtntfobyYTaOiGPiisOsK p5jrNZ5ECg85xCmRchZIkC+dV/BL+5KYxhIYiETAWmDVMmPGfWwJb7P385sL7D/v+2OC ezz/PvL3sHKccf1P5T2aBOPfWyyY+5MPee7GxaZA8jZ1VtmnUWUjTI1KP6oeoZfJ7AwG RKOg== X-Gm-Message-State: AOJu0YyxWcj+JO+H48lH27K1Gtg1JclwRh/686RUv03t2nC5RP9ZdLbu mr0Vj6TBY/iVulp1JdO5iuGU3SyKiYPR37sB4oVlBIZrk63/VJXLswyxPo1jO2L7xoY= X-Gm-Gg: AR+sD13G1ccHXpUf9AWGqt7dWBt1Tq7V6d87dKz8x1sddKpnMD6F0TsFYDFeGe35aWt HUiFqJot+hAJjwQghTu+f4u8p5esJMsL9vkeMKe+tqlew8bQ53g8XHdehbDpsOyH+tkSiuq7ESO 7cTgzQyaESFNNV/qDrMvIZP9HfSYJwTz4XxbOdmTmKAQUCsTT+bMP7AaU7HWaeMxfsz+1JtkHfi 5+/KE9WqRYtKeyt9Kob4ZMRH00/C5eLOfO5oUWFwofG4mlNKBVhviP+OGs2yUUVAKfXpndJ8B57 EIJ8cYQidb11aUps83RF4RzGmVVJP9f00fQSH0i+VUnJ2Y83yLBsz91Rfs5JIK37dx9qP2EetVG nNqsEUaImO2PGR+RF5mQsrtYVB7ighUzz2k54bCih/3+m0QEb6pH1dRbLCZV0pdGqUh3F2V5+7q OjQydKWT1bOVoWUac2h/TzHtFwChsVY7wsTMsPWZn14DexwifcvpZGhVRn43a5mKsypadXp7ix/ BtPh17mcW8FrTKvc8/xSheLpEJsnWfB8+fTIs4Iuq5aRxfRMIXuaPTGlfaBSpcIWVcNDrvmv2HP PnTcC2vJgYW0fSY= X-Received: by 2002:a05:6402:11cb:b0:69e:14ab:5966 with SMTP id 4fb4d7f45d1cf-6a12319f03amr2901669a12.8.1785833105429; Tue, 04 Aug 2026 01:45:05 -0700 (PDT) Message-ID: <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> Date: Tue, 4 Aug 2026 10:45:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux PV domU with >1 vCPU never resumes after xl save/restore To: Jan Beulich , George Dunlap Cc: xen-devel References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WVRzwMQeY23S5wu1WdvhUDd2" X-purgate-ID: tlsNG-ebf023/1785833105-516D2B50-64075477/0/0 X-purgate-type: clean X-purgate-size: 8837 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WVRzwMQeY23S5wu1WdvhUDd2 Content-Type: multipart/mixed; boundary="------------pa0cUgpdHzoVvd7rAPNWfrwC"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , George Dunlap Cc: xen-devel Message-ID: <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> Subject: Re: Linux PV domU with >1 vCPU never resumes after xl save/restore References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> In-Reply-To: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------pa0cUgpdHzoVvd7rAPNWfrwC Content-Type: multipart/mixed; boundary="------------WTP03W800uCAC6gjMvuPYlYZ" --------------WTP03W800uCAC6gjMvuPYlYZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjYgMTA6MDIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNC4wOC4yMDI2 IDA4OjEyLCBHZW9yZ2UgRHVubGFwIHdyb3RlOg0KPj4gU2F2aW5nIGFuZCByZXN0b3Jpbmcg YSBtdWx0aS12Y3B1IFBWIGd1ZXN0IGFwcGVhcnMgdG8gaGF2ZSBiZWVuIGJyb2tlbiBpbg0K Pj4gTGludXggZm9yIHNvbWUgdGltZSAob2JzZXJ2ZWQgNi42LjU2IGFuZCA2LjEyLjg2KS4g IFJlcG9ydCBiZWxvdyBmcm9tDQo+PiBDbGF1ZGUgRmFibGU7IEkndmUgaW5kZXBlbmRlbnRs eSB2ZXJpZmllZCB0aGUgYmVoYXZpb3Igb24gdmFuaWxsYSBMaW51eA0KPj4gNi42LjU2LiAg Q2xhdWRlIHNlZW1zIHRvIHRoaW5rIGl0J3MgYSBidWcgaW4gTGludXguDQo+IA0KPiBKdXN0 IHRvIGRvdWJsZSBjaGVjaywgYXMgdGhlcmUgd2FzIGEgY3J1Y2lhbCBmaXggdGhlcmUgcmVj ZW50bHk6IFRoaXMgaXMgd2l0aA0KPiBhIFhlbiBpbmNsdWRpbmcgYmVkYmMxN2Q4NDA3ICgi eDg2L2RvbWN0bDogcmVzdG9yZSBhbGwgcmVnaXN0ZXJzIGluDQo+IGFyY2hfe2dldCxzZXR9 X2luZm9fZ3Vlc3QoKSIpPw0KDQpUaGFua3MgZm9yIGJyaW5naW5nIHRoaXMgdXAuDQoNCkkg anVzdCB3YW50ZWQgdG8gc3RhcnQgaW52ZXN0aWdhdGlvbiwgYXMgeGwgc2F2ZS9yZXN0b3Jl IGRpZG4ndCB3b3JrIGZvciBtZQ0KZWl0aGVyIHVzaW5nIGFuIHVwc3RyZWFtIDcuMSBrZXJu ZWwuDQoNClVzaW5nIGFuIHVwLXRvLWRhdGUgWGVuIG1hZGUgdGhlIGRpZmZlcmVuY2UgKEkg aGFkIGEgb25lIG1vbnRoIG9sZCBYZW4gb24gbXkNCnRlc3Qgc3lzdGVtIGZvciB0aGUgaW5p dGlhbCB0ZXN0KS4NCg0KDQpKdWVyZ2VuDQoNClAuUy46IEdlb3JnZSwgd291bGQgaXQgYmUg cG9zc2libGUgdG8gdHVybiBvZmYgSFRNTCBtYWlscyB3aGVuIHNlbmRpbmcgdG8NCiAgICAg ICB4ZW4tZGV2ZWw/DQo= --------------WTP03W800uCAC6gjMvuPYlYZ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------WTP03W800uCAC6gjMvuPYlYZ-- --------------pa0cUgpdHzoVvd7rAPNWfrwC-- --------------WVRzwMQeY23S5wu1WdvhUDd2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpxppAFAwAAAAAACgkQsN6d1ii/Ey8y 2gf9G2gLNc5IG8tJ5It/UYmwD3CJz+8fX1u5OgApne08uKg7Jms0cBlNyaVpN5eegCEUV8XRfRUs Avz1BpSJ2yKeTEoV7Tsk+B75wwsVZOd7cSf7J9c9EQA3RzROfq41boOl5H2vSKlrpWhhyxQvIPgD TOHX4yrTnaxXNuRIKBxEt4LpQ+I5cKeSvAd9Zy+S/tddoUo690OjiyGCfYeMIIeF+Qrg1+6E2BqF LmyalCNQoS01ZjPScAeNKkArgsWsm70n2F50HLsWFtQCvHytKZ1vVgDKQc8zb7a4EpPz0RZQ11dA GUvBosyR/gxFzkVnZK3yey0XeTsx+8vKPS5UrdxAHA== =LQ7a -----END PGP SIGNATURE----- --------------WVRzwMQeY23S5wu1WdvhUDd2-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 09:15:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 09:15:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382048.1625454 (Exim 4.92) (envelope-from ) id 1wrBEw-0006NU-2K; Tue, 04 Aug 2026 09:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382048.1625454; Tue, 04 Aug 2026 09:15:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrBEv-0006NN-Vi; Tue, 04 Aug 2026 09:15:13 +0000 Received: by outflank-mailman (input) for mailman id 1382048; Tue, 04 Aug 2026 09:15:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrBEt-0006NF-TI for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:15:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrBEr-00878h-EL for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 11:15:09 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71ad8d-e002-0a2a0a5209dd-0a2a450a89e8-40 for ; Tue, 04 Aug 2026 11:15:09 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71ad9a-f2d2-0a2a450a0019-b9ff1c2291e9-3 for ; Tue, 04 Aug 2026 11:15:06 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fcc0e18f8000e099.006 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 04 Aug 2026 09:15:03 +0000 Received: from [192.168.1.18] (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie) by mail2.vates.fr (Postfix) with ESMTPSA id B5BD38340E; Tue, 4 Aug 2026 11:15:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=2V3Tn92zkbXcZR5dja6Se9zC0FVeI7Mgv3coqMu/3jk=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=sS5NoJqNKu33dP57KnbE6DYZUxHwjO97bSL0lzRo8wA99xNA0LSPNC5M/0ls7evQrTvC7s3t6 wPINYChgw1EuGTdRJBmQ4NaEJgsrzRGpn+KD75mPVA2y61zP58w4Mx0zEEcN6hz2vNWrEnqm9IW 1t2HJv94v5A/OPNdpP+Nepmht1cDeYSrnp6y7+Sa1oYWstUB7jKvHuA0sOC8UXV5BGhs7MfOsNn EFYkIxZ8Hkjx1Ncaz6AyqlEmm6auQzaelucEuCu0WMFEC0JpCxzWwzJ/+cg3OYZ+gz+kSy4clsW +nNpE4Q/7c/U90XZAcDtF1TgtZDWtQp5tl9Fbskro8BQ== X-Zone-Loop: be9c5299de486e907cd307ba575e68146a1c6b48d74b x-campaign-type: default x-transaction-id: 12649b57-dd6f-4ceb-8776-fd8eac736d34 x-swg-uid: 01-42eff819-3e4a-43cb-959f-933edb5dd093 X-Mailer: Sweego Message-ID: <1785834903.8631fc262581453bbf619ec5b2062170.19fcc0e18f8000e099@vates.tech> x-swg-bid: 1785834903.8631fc262581453bbf619ec5b2062170.19fcc0e18f8000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Tue, 4 Aug 2026 11:15:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type To: Marcus Granado , Frediano Ziglio Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau Monne , Anthony PERARD , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= References: <20260720154832.1907401-1-marcus.granado@citrix.com> <20260720154832.1907401-2-marcus.granado@citrix.com> <1784622046.8631fc262581453bbf619ec5b2062170.19f83c35cd4000edb5@vates.tech> <1784755834.8631fc262581453bbf619ec5b2062170.19f8bbccffd000edb5@vates.tech> Content-Language: en-US From: Teddy Astie Autocrypt: addr=teddy.astie@vates.tech; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------tLoy9wFY8vD4kZQNnvXo5qTt" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1785834902930 X-purgate-ID: tlsNG-4011c0/1785834907-53AD4CFC-CEFE82DC/0/0 X-purgate-type: clean X-purgate-size: 14900 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------tLoy9wFY8vD4kZQNnvXo5qTt Content-Type: multipart/mixed; boundary="------------hNQ5LyUMizokDAxHrKBPhLw7"; protected-headers="v1" From: Teddy Astie To: Marcus Granado , Frediano Ziglio Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau Monne , Anthony PERARD , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= Message-ID: <473315c8-6e90-4921-ac2b-e22ba3332f69@vates.tech> Subject: Re: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type References: <20260720154832.1907401-1-marcus.granado@citrix.com> <20260720154832.1907401-2-marcus.granado@citrix.com> <1784622046.8631fc262581453bbf619ec5b2062170.19f83c35cd4000edb5@vates.tech> <1784755834.8631fc262581453bbf619ec5b2062170.19f8bbccffd000edb5@vates.tech> In-Reply-To: --------------hNQ5LyUMizokDAxHrKBPhLw7 Content-Type: multipart/mixed; boundary="------------qL9BXv60iFiNIQQzDu3jqzUh" --------------qL9BXv60iFiNIQQzDu3jqzUh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 TGUgMDMvMDgvMjAyNiDDoCAxOToyMywgTWFyY3VzIEdyYW5hZG8gYSDDqWNyaXTCoDoNCj4g T24gV2VkLCAyOSBKdWwgMjAyNiBhdCAxMDoxNCwgRnJlZGlhbm8gWmlnbGlvIDxmcmVkZHk3 N0BnbWFpbC5jb20+IHdyb3RlOg0KPj4gQWJvdXQgY29tcHJlc3NpbmcgYWxsIHRvZ2V0aGVy IGFuZCBjb25zaWRlcmluZyBhbHNvIHRoZSBpc3N1ZSBvZg0KPj4gbWVtb3J5IGNoYW5naW5n IHdoaWxlIHNlbmRpbmcgSSB3b3VsZCB2b3RlIHRvIGNvcHkgdGhlIG1lbW9yeSBpbiBhDQo+ PiB0ZW1wb3JhcnkgYnVmZmVyIHRvIGF2b2lkIHRoaXMuIE9uZSBhZHZhbnRhZ2UgaXMgdGhh dCBpdCBzaW1wbGlmaWVkDQo+PiB0aGUgZm9ybWF0LiBUaGUgY3VycmVudCBMWjQgaW1wbGVt ZW50YXRpb24gc2VlbXMgdG8gY29wZSB3aXRoIGRhdGENCj4+IGNoYW5nZXMgYnV0IG5vdGhp bmcgZ3VhcmFudGVlcyBpdCBpbiB0aGUgZnV0dXJlLCB0aGUgYnVmZmVyIHlvdSBhcmUNCj4+ IHBhc3NpbmcgaXMgbm90IHN1cHBvc2VkIHRvIGNoYW5nZSB3aGlsZSB5b3UgY29tcHJlc3Mg aXQuDQo+IA0KPiANCj4gQWdyZWVkLiBGcmVkaWFubyBhbmQgSSBkaXNjdXNzZWQgdGhpcyBm dXJ0aGVyLCBpbmNsdWRpbmcgc2ltcGxpZmljYXRpb25zIG9uDQo+IHRoZSBjb21wcmVzc2lv biByZWNvcmQgZm9yIHYyIHNvIHRoYXQgdGhlIHBhZ2UgZGF0YSBjb21wcmVzc2lvbjoNCj4g KiBjb21wcmVzc2VzIHRoZSB3aG9sZSBiYXRjaCB0b2dldGhlcg0KPiAqIGFuZCB1c2VzIGEg c3RhZ2VkIGNvcHkgZm9yIGl0IGFzIHlvdSBhbmQgVGVkZHkgc3VnZ2VzdGVkIChzbyB0aGF0 IHdlIGRvDQo+IG5vdCBuZWVkIHRvIHdvcnJ5IGFib3V0IG11dGF0aW5nIGJ1ZmZlcnMgYWZm ZWN0aW5nIExaNCBvciBvdGhlciBhbGdvcml0aG1zKS4NCj4gDQo+IE9uY2UgdGhlcmUncyBl eGFjdGx5IG9uZSBjb21wcmVzc2VkIGJsb2IgcGVyIHJlY29yZCwgdGhlcmUncyBubyBuZWVk IGZvcg0KPiBleHRyYSBmaWVsZHMgdG8gZGVzY3JpYmUgdGhlIGNvbXByZXNzZWQgZGF0YSwg YXMgdGhlIHVuY29tcHJlc3NlZCBiYXRjaA0KPiBzaXplIGlzIGtub3duIChhbmQgYm91bmRl ZCBieSBNQVhfQkFUQ0hfU0laRSAqIHBhZ2Vfc2l6ZSksIGFuZCBpdHMNCj4gY29tcHJlc3Nl ZCBzaXplIGNhbiBiZSBpbmZlcnJlZCBmcm9tIHRoZSBzaXplIG9mIHRoZSBlbWl0dGVkIGNv bXByZXNzZWQNCj4gcmVjb3JkIHdpdGhvdXQgYSBuZWVkIGZvciBhbiBleHBsaWNpdCBmaWVs ZCBmb3IgY2xlbiBvciBhIGZpZWxkIHdpdGggdGhlDQo+IG51bWJlciBvZiByYXcgY29tcHJl c3NlZCBibG9icy4gVGhpcyBtZWFucyB0aGUgc2VwYXJhdGUgUEFHRV9EQVRBX0xaNA0KPiBy ZWNvcmQgdHlwZSBpcyBub3QgbmVlZGVkLCBhbmQgdGhlIHByb3Bvc2FsIGZvciB2MiBjb21w cmVzc2lvbiByZWNvcmQgY291bGQNCj4gc2ltcGxpZnkgdG8gcmV1c2luZyBQQUdFX0RBVEEg YW5kIHNwZW5kaW5nIG9uZSBvY3RldCBvZiBpdHMgcmVzZXJ2ZWQgd29yZA0KPiBhcyBmb2xs b3dzOg0KPiANCj4gDQo+ICAgICAgIDAgICAgIDEgICAgIDIgICAgIDMgICAgIDQgICAgIDUg ICAgIDYgICAgIDcgb2N0ZXQNCj4gICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rLS0t LS0rLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4gICAgICB8IGNvdW50IChDKSAgICAgICAgICAg ICB8IGNvbXB8IChyZXNlcnZlZCkgICAgICAgIHwNCj4gICAgICArLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0rLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4gICAgICB8IHBmblswXSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwNCj4gICAgICArLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4gICAg ICAuLi4NCj4gICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLSsNCj4gICAgICB8IHBmbltDLTFdICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwNCj4gICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4gICAgICB8IHBhZ2VfZGF0YVswLi5OLTFdIGlm IGNvbXAgPT0gMCAgICAgICAgICAgICAgICAgIHwNCj4gICAgICB8IG9yIHBhZ2VfY2RhdGEg ICAgIGlmIGNvbXAgIT0gMCAgICAgICAgICAgICAgICAgIHwNCj4gICAgICArLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4gDQo+IHdpdGgg dHdvIG5ldyBlbnRyaWVzIGluIHRoZSBmaWVsZCB0YWJsZToNCj4gDQo+IGNvbXAgICAgICAg IENvbXByZXNzaW9uIGFsZ29yaXRobSBhcHBsaWVkIHRvIHRoZSBwYWdlIGNvbnRlbnRzLiAw DQo+ICAgICAgICAgICAgICBtZWFucyBub25lLCBhbmQgdGhlIHJlY29yZCBpcyBleGFjdGx5 IGFzIGl0IGlzIHRvZGF5LiAxDQo+ICAgICAgICAgICAgICBtZWFucyBMWjQgYmxvY2sgZm9y bWF0LiBPdGhlciB2YWx1ZXMgYXJlIHJlc2VydmVkIGZvcg0KPiAgICAgICAgICAgICAgb3Ro ZXIgZnV0dXJlIGZvcm1hdHMgbGlrZSBaU1REIGV0Yy4gQSBjb21wICE9IDAgY2FuIG9ubHkN Cj4gICAgICAgICAgICAgIGJlIGVtaXR0ZWQgaWYgMCA8IGxlbihwYWdlX2NkYXRhKSA8IE4g KiBwYWdlX3NpemUuIEFuDQo+ICAgICAgICAgICAgICB1bmtub3duIGNvbXAgbXVzdCBjYXVz ZSB0aGUgcmVjZWl2ZXIgdG8gZmFpbCB3aXRoIGENCj4gICAgICAgICAgICAgICJDb21wcmVz c2lvbiBhbGdvcml0aG0gPHZhbHVlPiBub3QgaGFuZGxlZCIgZXJyb3IuDQo+IA0KPiBwYWdl X2NkYXRhICBQcmVzZW50IGluc3RlYWQgb2YgcGFnZV9kYXRhIHdoZW4gY29tcCBpcyBub24t emVyby4gQQ0KPiAgICAgICAgICAgICAgc2luZ2xlIGNvbXByZXNzZWQgb2JqZWN0IGhvbGRp bmcgdGhlIGNvbmNhdGVuYXRpb24gb2YgdGhlDQo+ICAgICAgICAgICAgICBOIHBhZ2VfZGF0 YSBlbnRyaWVzLiBUaGUgcmVjZWl2ZXIgbXVzdCB2ZXJpZnkgdGhhdA0KPiAgICAgICAgICAg ICAgMCA8IGNvdW50IDw9IE1BWF9CQVRDSF9TSVpFLg0KPiANCj4gDQo+IFRlZGR5LCBJIGhv cGUgdGhpcyBmb3JtYXQgY292ZXJzIHlvdXIgcG9pbnRzOiBpdCdzIG5vIGxvbmdlciBMWjQg c3BlY2lmaWMsDQo+IHRoZSBpbmxpbmUgY2xlbiBpbmNvbnNpc3RlbmN5IGluIGxpYnhlbmd1 ZXN0IHJlY29yZCBkaXNhcHBlYXJzLCBpdCdzIG9uZQ0KPiBibG9jayBvdmVyIGFuIGltbXV0 YWJsZSBjb3B5IG9mIHRoZSBiYXRjaCBpbnN0ZWFkIG9mIG9uZSBwZXIgcGFnZSwgdGhlDQo+ IGRlY29tcHJlc3NlZCBzaXplIGlzIGtub3duIHVwIGZyb250LCBhbmQgdGhlIGFsbG9jYXRp b24gZGVyaXZlZCBmcm9tIGNvdW50DQo+IGlzIGJvdW5kZWQgb24gdGhlIHJlY2VpdmVyLg0K PiANCg0KTG9va3MgZ29vZCB0byBtZS4NCg0KPiANCj4gVGhpcyBzaW1wbGlmaWNhdGlvbiBp cyBhbHNvIGZvcndhcmQtY29tcGF0aWJsZSBpbiB0d28gZGlmZmVyZW50IHdheXM6IHlvdXIN Cj4gNjRLQiBjaHVua2luZyBmb3IgY2FjaGUgbG9jYWxpdHkgZG9lc24ndCBkZXBlbmQgb24g dGhlIGZvcm1hdCwgYXMgdGhlDQo+IHN0YWdpbmcgY29weSBjYW4gYmUgZG9uZSBpbiBjaHVu a3Mgd2hpbGUgc3RpbGwgbWFraW5nIGEgc2luZ2xlIGNvbXByZXNzDQo+IGNhbGwgb3ZlciB0 aGUgd2hvbGUgYmF0Y2guIEFuZCBpZiB3ZSBmaW5kIGJlbmVmaXRzIGluIHNwbGl0dGluZyB0 aGUgcGF5bG9hZA0KPiBpbnRvIHNldmVyYWwgY29tcHJlc3NlZCB1bml0cywgdGhhdCBjYW4g YmUgaW1wbGVtZW50ZWQgYXMgYSBuZXcgY29tcCB2YWx1ZQ0KPiB1c2luZyBhIHNlbGYtZGVs aW1pdGluZyBmb3JtYXQgbGlrZSB6c3RkIG9yIGx6NGYgZnJhbWVzLCB3aGljaCByZXBvcnQg dGhlDQo+IGNvbnN1bWVkIGJ5dGVzIHdpdGhvdXQgYSBuZWVkIHRvIHNwZWNpZnkgY2xlbiBv ciBleHRyYSBmcmFtaW5nIGZpZWxkcyBhdCB0aGUNCj4gcmVjb3JkIGxldmVsLg0KPiANCj4g DQo+IE9uIFdlZCwgMjIgSnVsIDIwMjYgYXQgMjA6NDIsIEZyZWRpYW5vIFppZ2xpbyA8ZnJl ZGR5NzdAZ21haWwuY29tPiB3cm90ZToNCj4+IERvbid0IHdlIG5lZWQgdG8gYnVtcCB0aGUg dmVyc2lvbiBudW1iZXIgd2hpbGUgd2UgYWRkIGEgbmV3IG1hbmRhdG9yeSByZWNvcmQ/DQo+ IA0KPiBJIGJlbGlldmUgd2UgbWF5IGF2b2lkIGhhdmluZyB0byBkbyBhIHZlcnNpb24gYnVt cCBpZiB3ZSBhZG9wdCB0aGUgcHJvcGVydHkNCj4gdGhhdCAwIDwgbGVuKHBhZ2VfY2RhdGEp IDwgTiAqIHBhZ2Vfc2l6ZSB3aGVuIGNvbXAgIT0gMCwgYXMgaW4gdGhpcyBjYXNlDQo+IHRo ZSBjb21wcmVzc2VkIGRhdGEgc2VudCB0byBhbiBvbGQgcmVjZWl2ZXIgd291bGQgZmFpbCBp biBoYW5kbGVfcGFnZV9kYXRhKCkNCj4gd2l0aCAiUEFHRV9EQVRBIHJlY29yZCB3cm9uZyBz aXplIi4gQnVtcGluZyB0aGUgdmVyc2lvbiB3b3VsZCBtYWtlDQo+IHVuY29tcHJlc3NlZCBt aWdyYXRpb25zIGZhaWwgaWYgdGhleSBhcmUgc2VudCB0byBvbGQgcmVjZWl2ZXJzIHRoYXQg YWxzbw0KPiB1bmRlcnN0YW5kIHVuY29tcHJlc3NlZCBtaWdyYXRpb24sIHNvIGF2b2lkaW5n IGlmIHBvc3NpYmxlIHdvdWxkIGJlIGdvb2QuDQo+IFRoZSBzcGVjIHNheXMgbWlncmF0aW9u IHRvb2xzICJzaGFsbCBhbHdheXMgc2F2ZSBpbWFnZXMgdXNpbmcgdmVyc2lvbiBWIiwNCj4g c28gaXQgZG9lc24ndCBzZWVtIGxpa2Ugd2UgY291bGQgYnVtcCB0aGUgdmVyc2lvbiBvbmx5 IHdoZW4gY29tcHJlc3Npb24gaXMgb24uDQo+IA0KPiANCj4+IElzIHRoZXJlIG5vIGtpbmQg b2YgZGlhbG9nIGFib3V0IHRoZSBzdXBwb3J0ZWQgdmVyc2lvbj8NCj4gDQo+IFRoZXJlIGlz IG5vIGluLXN0cmVhbSBuZWdvdGlhdGlvbiwgYW5kIHRoaXMgcHJvcG9zYWwgZG9lcyBub3Qg YWRkIG9uZS4NCj4gQ29tcHJlc3Npb24gaXMgb3B0LWluIGF0IHRoZSBzZW5kZXIgdmlhIHhs IG1pZ3JhdGUgLS1jb21wcmVzcywgc28gYW4gb3BlcmF0b3INCj4gd2hvIGVuYWJsZXMgaXQg YWdhaW5zdCBhbiBvbGQgcmVjZWl2ZXIgZ2V0cyBhIGNsZWFuIGZhaWx1cmUgcmF0aGVyIHRo YW4NCj4gY29ycnVwdGlvbi4NCj4gDQo+PiBXaHkgbm90IGV4dGVuZGluZyB0aGUgZ2VuZXJh bGl6YXRpb24gY29tcHJlc3NpbmcgYWxsIHBheWxvYWQgb2YNCj4+IHVuY29tcHJlc3NlZCBw YWNrZXRzICh0eXBlK2JvZHkpLA0KPiANCj4gQSBjb21wb3NhYmxlIHdyYXBwZXIgd291bGQg YmUgYSBjbGVhbiBnZW5lcmljIG1lY2hhbmlzbSwgYnV0IEkgdGhpbmsgdGhlcmUNCj4gYXJl IHR3byByZWFzb25zIG5vdCB0byBnbyB0aGF0IHdheSBpbiB2MjogUEFHRV9EQVRBIGlzIGVm ZmVjdGl2ZWx5IGFsbCBvZiB0aGUNCj4gc3RyZWFtIGJ5dGVzLCBzbyBjb21wcmVzc2luZyB0 aGUgb3RoZXIgcmVjb3JkIHR5cGVzIHdvdWxkIG5vdCBzaG93IHVwIGluIGENCj4gbWVhc3Vy ZW1lbnQuIEFuZCB0aGUgbm8tZXh0cmEtZmllbGRzIHByb3BlcnR5IGFib3ZlIGRlcGVuZHMg b24gUEFHRV9EQVRBDQo+IHNwZWNpZmljYWxseTogYSBnZW5lcmljIHdyYXBwZXIgaGFzIG5v IHBmbiBhcnJheSBmcm9tIHdoZXJlIHdlIGNhbiBkZXJpdmUNCj4gdGhlIHVuY29tcHJlc3Nl ZCBzaXplLCBzbyBpdCB3b3VsZCBuZWVkIGV4cGxpY2l0IGFsZ29yaXRobSwgY29tcHJlc3Nl ZA0KPiBzaXplIGFuZCB1bmNvbXByZXNzZWQgc2l6ZSBmaWVsZHMgb24gZXZlcnkgcmVjb3Jk LCB3aGljaCByZS1hZGRzIHRoZSBmaWVsZHMNCj4gdGhhdCB0aGlzIHByb3Bvc2FsIHRyaWVz IHRvIGF2b2lkLg0KPiANCj4gDQo+IFBsZWFzZSBsZXQgbWUga25vdyBpZiB0aGUgaWRlYXMg YWJvdmUgY2FwdHVyZSB3aGF0IHlvdSBoYWQgaW4gbWluZCBpbiB0ZXJtcyBvZg0KPiBzdWdn ZXN0aW9ucyB0byBpbXByb3ZlIHYxLg0KPiANCj4gSW4gcGFydGljdWxhciwgSSB3b25kZXIg d2hhdCB0aGUgbWFpbnRhaW5lcnMgdGhpbmsgb2YgdGhlIHVzZSBvZiBvbmUgb2YgdGhlDQo+ IG9jdGV0cyBvZiB0aGUgUEFHRV9EQVRBIHJlc2VydmVkIGZpZWxkIGZvciB0aGUgcHVycG9z ZSBvZiBpbmRpY2F0aW5nIHRoZSBkYXRhDQo+IGlzIGNvbXByZXNzZWQsIG9yIGlzIGl0IHBy ZWZlcmFibGUgdG8gdXNlIGEgbmV3IFBBR0VfREFUQV9DT01QUkVTU0VEICgweDEzKQ0KPiB0 eXBlIHJlY29yZCBhcyBhIG1hbmRhdG9yeSByZWNvcmQgc28gdGhhdCBhbiBvbGQgcmVjZWl2 ZXIgZmFpbHMgbW9yZSBjbGVhbmx5DQo+IHdoZW4gaXQgZG9lc24ndCB1bmRlcnN0YW5kIGNv bXByZXNzaW9uICJNYW5kYXRvcnkgcmVjb3JkIDxuYW1lPiBub3QgaGFuZGxlZCINCj4gKGNh dXNlZCBieSB0aGUgc3BlY2lmaWNhdGlvbiBvZiBtYW5kYXRvcnkgcmVjb3JkcykgaW5zdGVh ZCBvZiB3aXRoIGEgZ2VuZXJpYw0KPiBlcnJvciAiUEFHRV9EQVRBIHJlY29yZCB3cm9uZyBz aXplIiAoY2F1c2VkIGJ5IHRoZSBjdXJyZW50IHNhZmV0eQ0KPiBpbXBsZW1lbnRhdGlvbiB0 aGF0IHJlamVjdHMgdW5leHBlY3RlZCByZWNvcmQgc2l6ZXMpPw0KPiANCg0KVGhlIHNwZWNp ZmljYXRpb24gc2F5cw0KDQogPiBQYWRkaW5nIGFuZCByZXNlcnZlZCBmaWVsZHMgYXJlIHNl dCB0byB6ZXJvIG9uIHNhdmUgYW5kIG11c3QgYmUNCmlnbm9yZWQgZHVyaW5nIHJlc3RvcmUu DQoNCldoaWNoIGlzIG5vdCByZWFsbHkgZ29pbmcgdG8gaGVscCBpZiB3ZSBhZGQgYSBuZXcg ZmllbGQgdGhhdCBtYXR0ZXJzIG9uIA0KaG93IHRoZSBjb250ZW50IGlzIG9yZ2FuaXplZC4N Cg0KVG8gYXZvaWQgY29uZnVzaW9uLCBpdCBtYXkgYmUgZGVzaXJhYmxlIHRvIGFkZCBhIG5l dyB0eXBlIA0KKFBBR0VfREFUQV9DT01QUkVTU0VEKSwgYnV0IEknbSBub3QgZnVsbHkgc29s ZCBvbiBpdC4NCg0KPiANCj4gTWFyY3VzDQo+IA0KPiANCg0KVGVkZHkNCg== --------------qL9BXv60iFiNIQQzDu3jqzUh Content-Type: application/pgp-keys; name="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Disposition: attachment; filename="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7L TBVHV/XOZw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJ T4ny+OGntnJntUoRKRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJA WicutjkkUgd28Bh6HV9EIumHtCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO 8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaTVqMdqul07o72m3eA2mf+LMu9a04FX/d4 wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/EoucejoZ5SH49ksmVAmKOLkt OaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+SPhHar7TPKjFz0G3D PNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89MXfQXZ3q t1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWj moACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNz uyOVCskwfUZPla6Zpd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp 0x0HfuhcYfAYPR46XHTvjaJEv99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuR OxdK8G+YHccJY8PvWSq2K2yiae2KGiAv1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50 wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhPeP3IdpfWc8cyRLXF06Rk46YM YCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcTUwgnYlFRk2FLq0Qe KEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9Egr/Wmu3 MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEM AKiQiZa3yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ 3DbVf+en3/FvdVZg2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTm etSG5/52AjtmPFtlXAk0NmLvfJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0 s3109sJeXT5ImVdphFs9cvyZyBT9t1PbRowv58EgV0zE4hbAeVkULAbxFV5b/ExT jjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKbYu6NCfiHfEyB3Xyg9hfdrRgj MRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ovXoK4jm+Py0FiUGUa A6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/eVtR2Q1w ZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWj moACGwwACgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiV oUiHYN5QwhnbZnsaJDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764Qxy X6rld2f2RcWkDuBHun55ZWXjby8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk /dS0XTOQi2wVUb17sW/+ybCEokdVacZGzOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fu oGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+lOWSvdNHgoEkWR0RXBPQjnGm LKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/OffO485NOTKwGOxyWb0 06cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR8ULR9nX0 LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa =3DlUIA -----END PGP PUBLIC KEY BLOCK----- --------------qL9BXv60iFiNIQQzDu3jqzUh-- --------------hNQ5LyUMizokDAxHrKBPhLw7-- --------------tLoy9wFY8vD4kZQNnvXo5qTt Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmpxrZYFAwAAAAAACgkQZg+p0QLLz9CC EAwAqmEMd1SikFOClTEEjZw+ESDICB9UuEyhrZ5LK4CaAQsO3HxMYwfN7st4RyL/PBHy4CbyddvQ hu1HS0T3XyU2WjiahkSx9IhrEYjAU1B89bsNi5hpofhgGpBi4qCocQ6iJgpBWg9z6bPUhDCKC2qs tWg0wndY7ZwFqx/PiE1vPTpp1FRntQQwS+o9JlsUKuNlk8stMvrQz1j+vyaZlDBKbLZ+j76QrNti drccO+ikWGn4mAQWqfEdDhkRorR3hYrffs1bRT+/wy6BeoxGzUEPH+JnMY1kB5JohrwKKv0fNqwm oYj1XVInPKZXAnjMQqoVf/Ykm8xIAtPkWap4Cu9CteUQKe67Jg+wwURzN5HqV4GRFhPvBsRDptom TVsHe+ZDIQEJ1b73oVJEZzqx60Vq5Ws9ehvWMi0l8lfrwgDZKFu/6hibl5RSfX7YR0BQI+X0Io1/ jFxYTrJjOwF7huiDb9TBj9eVSslKNLS1h0nUvMCFDuN7OAFD+r47h+m0y8Vk =gycT -----END PGP SIGNATURE----- --------------tLoy9wFY8vD4kZQNnvXo5qTt-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 09:28:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 09:28:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382061.1625464 (Exim 4.92) (envelope-from ) id 1wrBRI-0000MA-9c; Tue, 04 Aug 2026 09:28:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382061.1625464; Tue, 04 Aug 2026 09:28:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrBRI-0000M2-4T; Tue, 04 Aug 2026 09:28:00 +0000 Received: by outflank-mailman (input) for mailman id 1382061; Tue, 04 Aug 2026 09:27:58 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrBRG-0000Lv-K0 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 09:27:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrBRG-00EZdy-0g for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 11:27:58 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71b08e-5cb7-0a2a0a5109dd-0a2a4508ec64-38 for ; Tue, 04 Aug 2026 11:27:57 +0200 Received: from [74.125.224.47] (helo=mail-yx1-f47.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71b09c-f659-0a2a45080019-4a7de02fb8ed-3 for ; Tue, 04 Aug 2026 11:27:56 +0200 Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-66892c81725so5920962d50.2 for ; Tue, 04 Aug 2026 02:27:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1785835675; cv=none; d=google.com; s=arc-20260327; b=gTdAkbaR+cuCBKZz+pwgrlCYUatnChk+MfwON2JuZqM5KIsOGuC6q15YEc2z4VElQy xAnwsy+YVmqAlFohDqtzOAWaq4hC1zB+y8hOGXxzYg/xA83Mssap6qD2I0q0neFV/qbY WX2EzeTGPD8v78cLhq5e5kgiN2phQGl6uCGb3bn+sJV0Vnzme7yVbDTVCp2hLKvww8Tt /frNv0qbLJdhvojVFld1Dm7rhU5ryx9ykQmZcDlsPJ9+qiqR1aCQCmQtyJ1zEGu06bZj WRj5zi3kqeXwt6MKBQYr0Ij+1tw1sRMUuzM5M6w/IO1cZE3yzqFG323//3tqOkl3RaLN 75sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=fQwOQ6fPXMYo5N5tkHcaXYRfhVBL6xu1DTd6Y7Q0NLk=; fh=xbnCk1fMGZS2xoJIy7HSNqzoA8cI7GtUsg/C2XqwZXc=; b=MIP+Gd68Sh39DtvaKeT4HMDX6FG26t23LCc9ZRrfLBJyiXJzsjibkosV0LnFZ9I9ms Hmf5B7NNHO1piJ80Md5OLCTvtN2qLbjtL51LiH+WBj4vxbxcTtoauhX+Ualb2+A97dmy RBr25WssZwOCvdwel1KuxfKo/ns0B7w1G7wqcChOmF+Jk9JObWvWOzmRab2VU5q99RO/ tSa6CjqTMT8R5pMWIACLUdYLE34vhkj9zlbkg3/CIfVsdwB4xaYyY3uwFmJyhx6qvKWy VPFX7ekhbsZrUNpQ1L206SnGWf0dodFp1PZJ5ZugCQvQCbbskQArcjTTicxnuAS0gnyo 8drQ==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785835675; x=1786440475; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fQwOQ6fPXMYo5N5tkHcaXYRfhVBL6xu1DTd6Y7Q0NLk=; b=DPEi/Kw/47tQGcGPnT9oS8L8/7/ebuWSHR4vS2bv/927yBTY92ltjUSEonyN06e4lJ aDNDEbLEv1troLte9ri/HW3Vy6rvSQBNj7VlEx+w10m/YY/y/zqP9rOx9g93ODaBELgk mbcLwACyDtdCsRgCIAC3Tgzne6kw6jcv7PUzzC220mxCXnQPivcmCK0cvk4eHJkeHncv tytgk5vbg560mjBqmhQZgnxfhetvYwZIAUNhPR9tY7C0YpArlovgLbngKCXRCHdnHgZq Ggcz03QLtVLonqKzYLV1GJEaVabyq90Fba1nLIPrqVtY73Uj2YY5rvunCrxSQOupHT7T 049Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785835675; x=1786440475; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fQwOQ6fPXMYo5N5tkHcaXYRfhVBL6xu1DTd6Y7Q0NLk=; b=hePIj4v+OHppFsq/ti80oyXNRX8gAbncwMH0lQ1WIPvuDcAc0f5D/pIYinOH1atPWm ewgyjNuGn/3N57+kGo/Z6okBQFHJ0VJaELLq9faUR82lw1EopZ+Vweu678sf6eJTteYx v1xOyumfYLc78S0qUB23DBK7wAxlE7XKFCdBzXVVN0follQd+Eu5nCe2FoYBrDlP908m XTWDNc5ZZusAq2bemn5VVoG34G6QYv0f99uV7xYPN2CeqHdQkFYp7gHTWbyrfGM1348G 7/n5EjPnRXyGoGmD9aCdTWJ5eGOvZ3qALEFtk8g7OyqC3WRaXbLenIje0zxAABczQxw5 98sA== X-Forwarded-Encrypted: i=1; AHgh+RpWPlOZhsUxa+SZ9lXDlkFLhBOiC/Y79KVU7JY+gKHW1xW5wBwwCVWQaj8l+04Z5zXKa/0E6piCo94=@lists.xenproject.org X-Gm-Message-State: AOJu0YwS8OhoLTzDCqIhMqeH96VkuqMHm7WjA5+KOyqCeK2P56Mj3zWK zXKkqBv61zRbn/ycBmagpzLJXATw7uUEnx9I/cqLwWYyz6gw0xep8/SjGmvKv9poFKcLS1PDFgG euR1VgMmq0XFjRLPOQrznAXhWERXi+e8= X-Gm-Gg: AR+sD11i/EsstZcBcM2WEpIQD6utFlwDOU8HXtjYn9LEJQo6ttJoN2TC31KrvAaCEMM pDP3KwaLV79GtMz2y9DWjB60C97y99RAnl5q2UUebm1M3AKjRXCBDz++f5+grQxoKDYNfAdMdO9 Tax3wbEnuETRpD7zBzLjDIiDssWwp3tQCGjp81n5hDrWB67vKAf3XZ7jlutXsVmDCzv76iJzSc6 ARIBDpUHLBWLPH9mVaehO2QvMk1IwxUeDVskByW2aJgGHliAjoHyWTxzVz2eTEEQebxwh2LO9Fe xRt/gu/QlWktntDUMfsqHLTER6FB31C+ZHz+YvrBBCsxURhipIwXzHJYUWiRhaGHKEU9M5XCHsK Q X-Received: by 2002:a53:c48e:0:b0:668:43ff:265d with SMTP id 956f58d0204a3-6694f17589cmr12645410d50.33.1785835675350; Tue, 04 Aug 2026 02:27:55 -0700 (PDT) MIME-Version: 1.0 References: <20260720154832.1907401-1-marcus.granado@citrix.com> <20260720154832.1907401-2-marcus.granado@citrix.com> <1784622046.8631fc262581453bbf619ec5b2062170.19f83c35cd4000edb5@vates.tech> <1784755834.8631fc262581453bbf619ec5b2062170.19f8bbccffd000edb5@vates.tech> <1785834903.8631fc262581453bbf619ec5b2062170.19fcc0e18f8000e099@vates.tech> In-Reply-To: <1785834903.8631fc262581453bbf619ec5b2062170.19fcc0e18f8000e099@vates.tech> From: Frediano Ziglio Date: Tue, 4 Aug 2026 10:27:44 +0100 X-Gm-Features: AUfX_myRCQgeCxpioVZftRZlPcB9bBWODlwGQuWLd2QIALmUwjZBZ_LIOFxb_iU Message-ID: Subject: Re: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type To: Teddy Astie Cc: Marcus Granado , "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau Monne , Anthony PERARD , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c1860d/1785835677-CEF5F87B-66FF65BF/0/0 X-purgate-type: clean X-purgate-size: 8056 On Tue, 4 Aug 2026 at 10:15, Teddy Astie wrote: > > Le 03/08/2026 =C3=A0 19:23, Marcus Granado a =C3=A9crit : > > On Wed, 29 Jul 2026 at 10:14, Frediano Ziglio wrot= e: > >> About compressing all together and considering also the issue of > >> memory changing while sending I would vote to copy the memory in a > >> temporary buffer to avoid this. One advantage is that it simplified > >> the format. The current LZ4 implementation seems to cope with data > >> changes but nothing guarantees it in the future, the buffer you are > >> passing is not supposed to change while you compress it. > > > > > > Agreed. Frediano and I discussed this further, including simplification= s on > > the compression record for v2 so that the page data compression: > > * compresses the whole batch together > > * and uses a staged copy for it as you and Teddy suggested (so that we = do > > not need to worry about mutating buffers affecting LZ4 or other algorit= hms). > > > > Once there's exactly one compressed blob per record, there's no need fo= r > > extra fields to describe the compressed data, as the uncompressed batch > > size is known (and bounded by MAX_BATCH_SIZE * page_size), and its > > compressed size can be inferred from the size of the emitted compressed > > record without a need for an explicit field for clen or a field with th= e > > number of raw compressed blobs. This means the separate PAGE_DATA_LZ4 > > record type is not needed, and the proposal for v2 compression record c= ould > > simplify to reusing PAGE_DATA and spending one octet of its reserved wo= rd > > as follows: > > > > > > 0 1 2 3 4 5 6 7 octet > > +-----------------------+-----+-------------------+ > > | count (C) | comp| (reserved) | > > +-----------------------+-----+-------------------+ > > | pfn[0] | > > +-------------------------------------------------+ > > ... > > +-------------------------------------------------+ > > | pfn[C-1] | > > +-------------------------------------------------+ > > | page_data[0..N-1] if comp =3D=3D 0 | > > | or page_cdata if comp !=3D 0 | > > +-------------------------------------------------+ > > > > with two new entries in the field table: > > > > comp Compression algorithm applied to the page contents. 0 > > means none, and the record is exactly as it is today. 1 > > means LZ4 block format. Other values are reserved for > > other future formats like ZSTD etc. A comp !=3D 0 can only > > be emitted if 0 < len(page_cdata) < N * page_size. An > > unknown comp must cause the receiver to fail with a > > "Compression algorithm not handled" error. > > > > page_cdata Present instead of page_data when comp is non-zero. A > > single compressed object holding the concatenation of the > > N page_data entries. The receiver must verify that > > 0 < count <=3D MAX_BATCH_SIZE. > > > > > > Teddy, I hope this format covers your points: it's no longer LZ4 specif= ic, > > the inline clen inconsistency in libxenguest record disappears, it's on= e > > block over an immutable copy of the batch instead of one per page, the > > decompressed size is known up front, and the allocation derived from co= unt > > is bounded on the receiver. > > > > Looks good to me. > > > > > This simplification is also forward-compatible in two different ways: y= our > > 64KB chunking for cache locality doesn't depend on the format, as the > > staging copy can be done in chunks while still making a single compress > > call over the whole batch. And if we find benefits in splitting the pay= load > > into several compressed units, that can be implemented as a new comp va= lue > > using a self-delimiting format like zstd or lz4f frames, which report t= he > > consumed bytes without a need to specify clen or extra framing fields a= t the > > record level. > > > > > > On Wed, 22 Jul 2026 at 20:42, Frediano Ziglio wrot= e: > >> Don't we need to bump the version number while we add a new mandatory = record? > > > > I believe we may avoid having to do a version bump if we adopt the prop= erty > > that 0 < len(page_cdata) < N * page_size when comp !=3D 0, as in this c= ase > > the compressed data sent to an old receiver would fail in handle_page_d= ata() > > with "PAGE_DATA record wrong size". Bumping the version would make > > uncompressed migrations fail if they are sent to old receivers that als= o > > understand uncompressed migration, so avoiding if possible would be goo= d. > > The spec says migration tools "shall always save images using version V= ", > > so it doesn't seem like we could bump the version only when compression= is on. > > > > > >> Is there no kind of dialog about the supported version? > > > > There is no in-stream negotiation, and this proposal does not add one. > > Compression is opt-in at the sender via xl migrate --compress, so an op= erator > > who enables it against an old receiver gets a clean failure rather than > > corruption. > > > >> Why not extending the generalization compressing all payload of > >> uncompressed packets (type+body), > > > > A composable wrapper would be a clean generic mechanism, but I think th= ere > > are two reasons not to go that way in v2: PAGE_DATA is effectively all = of the > > stream bytes, so compressing the other record types would not show up i= n a > > measurement. And the no-extra-fields property above depends on PAGE_DAT= A > > specifically: a generic wrapper has no pfn array from where we can deri= ve > > the uncompressed size, so it would need explicit algorithm, compressed > > size and uncompressed size fields on every record, which re-adds the fi= elds > > that this proposal tries to avoid. > > > > > > Please let me know if the ideas above capture what you had in mind in t= erms of > > suggestions to improve v1. > > > > In particular, I wonder what the maintainers think of the use of one of= the > > octets of the PAGE_DATA reserved field for the purpose of indicating th= e data > > is compressed, or is it preferable to use a new PAGE_DATA_COMPRESSED (0= x13) > > type record as a mandatory record so that an old receiver fails more cl= eanly > > when it doesn't understand compression "Mandatory record not han= dled" > > (caused by the specification of mandatory records) instead of with a ge= neric > > error "PAGE_DATA record wrong size" (caused by the current safety > > implementation that rejects unexpected record sizes)? > > > > The specification says > > > Padding and reserved fields are set to zero on save and must be > ignored during restore. > > Which is not really going to help if we add a new field that matters on > how the content is organized. > Yes, there's no check for "_res1" being 0, however there's this check: if ( rec->length !=3D (sizeof(*pages) + (sizeof(uint64_t) * pages->count) + (PAGE_SIZE * pages_of_data)) ) { ERROR("PAGE_DATA record wrong size: length %u, expected " "%zu + %zu + %lu", rec->length, sizeof(*pages), (sizeof(uint64_t) * pages->count), (PAGE_SIZE * pages_of_data= )); goto err; } so, as long as we require that the compressed data is less than the uncompressed one (we should) it's fine. > To avoid confusion, it may be desirable to add a new type > (PAGE_DATA_COMPRESSED), but I'm not fully sold on it. > Not strong but if I could vote I would just use part of "_res1" as proposed= . > > > > Marcus > > > > > > Teddy Frediano From xen-devel-bounces@lists.xenproject.org Tue Aug 04 10:08:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 10:08:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382072.1625471 (Exim 4.92) (envelope-from ) id 1wrC3p-0006nT-0Y; Tue, 04 Aug 2026 10:07:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382072.1625471; Tue, 04 Aug 2026 10:07:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrC3o-0006nM-To; Tue, 04 Aug 2026 10:07:48 +0000 Received: by outflank-mailman (input) for mailman id 1382072; Tue, 04 Aug 2026 10:07:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrC3n-0006m1-BM for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:07:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrC3n-004jQy-12 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:07:47 +0000 Received: from mail-lf1-f52.google.com ([209.85.167.52]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wrC3m-008pHX-3C for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:07:47 +0000 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5b0115b9e17so4162282e87.0 for ; Tue, 04 Aug 2026 03:07:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version; bh=7lDpe5KpYW9iI4a2Xe0Pg6NsMRjTcXcMnAiS1mu0Vls=; b=JbwKGZd17ljrw8I//uuoj7CGRE KdEOaH78F3fFlhf6k2ZK1BfNh8OlYw0JcGQyk+Chrhw2zEZKZxKl21d64OgNM96QefI9UtbGyhK6f cJnlP4PGcgQfsdi+gl1z+vY28zm/X83YMzlCjv8vGUV3FtJq3ukiAUvCtXmvwfLLyPrE=; X-Forwarded-Encrypted: i=1; AHgh+Ro0+x7AwDURAINbyKABqtZ6Y+8yIBR+L8UBhJ+jq8/jcKUEVcyet+0yxkDbI9j4ENaE9IxIGPhXc5k=@lists.xenproject.org X-Gm-Message-State: AOJu0YweBcrIgDyxzRZ5V6pw9buCDKIHueRAELl39n5tXTcjX029yauT ow1AEOamgRcsyaJzeJssi+reaV7DQfG82bdyKKo5OP09hN7+3V7U0wauGNLV9jlw1jM/rTcyjdt zEB/8S8hGtFALesqnbVLJ3XUKP/aLUOY= X-Received: by 2002:a05:6512:3ba3:b0:5ae:b36d:bb1 with SMTP id 2adb3069b0e04-5b2e4f1a62cmr3090684e87.4.1785838065938; Tue, 04 Aug 2026 03:07:45 -0700 (PDT) MIME-Version: 1.0 References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> In-Reply-To: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> From: George Dunlap Date: Tue, 4 Aug 2026 20:07:33 +1000 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mzEH8wS0lJD_7rm_YVid-q_Smc21r0QSHW0rIMTEvJCLS_nLYGxc5SGcCQ Message-ID: Subject: Re: Linux PV domU with >1 vCPU never resumes after xl save/restore To: Jan Beulich Cc: Juergen Gross , xen-devel Content-Type: multipart/alternative; boundary="0000000000008bf724065835d353" --0000000000008bf724065835d353 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 4, 2026 at 6:02=E2=80=AFPM Jan Beulich wrot= e: > On 04.08.2026 08:12, George Dunlap wrote: > > Saving and restoring a multi-vcpu PV guest appears to have been broken = in > > Linux for some time (observed 6.6.56 and 6.12.86). Report below from > > Claude Fable; I've independently verified the behavior on vanilla Linux > > 6.6.56. Claude seems to think it's a bug in Linux. > > Just to double check, as there was a crucial fix there recently: This is > with > a Xen including bedbc17d8407 ("x86/domctl: restore all registers in > arch_{get,set}_info_guest()")? > Ah, yes, that seems to have done the trick. Sorry for he noise. -George --0000000000008bf724065835d353 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Aug 4, = 2026 at 6:02=E2=80=AFPM Jan Beulich <jbeulich@suse.com> wrote:
On 04.08.2026 08:12, George Dunlap wrote:
> Saving and restoring a multi-vcpu PV guest appears to have been broken= in
> Linux for some time (observed 6.6.56 and 6.12.86).=C2=A0 Report below = from
> Claude Fable; I've independently verified the behavior on vanilla = Linux
> 6.6.56.=C2=A0 Claude seems to think it's a bug in Linux.

Just to double check, as there was a crucial fix there recently: This is wi= th
a Xen including bedbc17d8407 ("x86/domctl: restore all registers in arch_{get,set}_info_guest()")?

Ah, yes, that seems to have done = the trick.=C2=A0 Sorry for he noise.

=C2=A0-George=C2=A0
--0000000000008bf724065835d353-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 10:26:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 10:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382082.1625481 (Exim 4.92) (envelope-from ) id 1wrCMD-0001iy-Fn; Tue, 04 Aug 2026 10:26:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382082.1625481; Tue, 04 Aug 2026 10:26:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrCMD-0001iq-CE; Tue, 04 Aug 2026 10:26:49 +0000 Received: by outflank-mailman (input) for mailman id 1382082; Tue, 04 Aug 2026 10:26:47 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrCMB-0001ik-Qt for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:26:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrCM8-000Epx-OT for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 12:26:44 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71be44-5cb7-0a2a0a5109dd-0a2a450693e8-42 for ; Tue, 04 Aug 2026 12:26:44 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71be64-195a-0a2a45060019-d1558029dd44-3 for ; Tue, 04 Aug 2026 12:26:44 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49802c418b5so25572265e9.1 for ; Tue, 04 Aug 2026 03:26:44 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b85be7sm395082985e9.2.2026.08.04.03.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 03:26:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785839204; x=1786444004; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=H6sw/ezMudW4mMwFYZn+KvA6eMQevSBKyPZciC7qYM4=; b=X0S2to+ZltJ/iKhreWlAIWe663vrfpc6Z5nrqQSXFX/Og6t0wGARC4sOAbATzhY8r2 IBYlUzHCB4do/w+5Q3eISCzOCxr8Xyts1wQONNeUz/lQ+BsfaHjksZKcIhDFYSanoSer GCXyxap4DtkL5ODH+kTmzPDS0pqBjhha7y5mK6enPqAkN15CJsIzSqzNYKErIRxq/1mn fe/Xidia8IRtGNmuCZK3k6Baj+nY3rwy/IZs+FsW0lLXOi8yGde6KcQTSPL8Z1upwUXs E71jkss631U8Kt4v8Tma0fRbfqUqt2rmVLNaPBkIfm6cM66L59Bg1rlIguuUBPS45Pee 2uHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785839204; x=1786444004; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H6sw/ezMudW4mMwFYZn+KvA6eMQevSBKyPZciC7qYM4=; b=oabTn5iDoLI8961hLtjznoSwv23YPO3q/Of65aCBMyJyiOEFmehlexKINUtvBj0GuN loKoOQLtHTMEkNxTrDjdlAk+O3emDYRMbIjpMf8P4D2RvBNIkicJbsxnEae8TjAwFrlo v9EQE9EG2E5LjUmWcTggvXTHvhxPCRooezLiShbR3x/A0wionYzeoJUSKVAyjOsCjSnL DoekLkXJl1MM7hGfXKtwrtPd5V74c1k0tzjRwuoyxBQdEuWnUnfLKbij+IWU0r8RFwcY USDKM/wpXUeogcAIyGXSrdyLzyrZW/763h1rOzpsVzF5GedktNlSRrXFBjKzPitDxo+/ OSsA== X-Forwarded-Encrypted: i=1; AHgh+RqXWkih57W8G5Mx/Ytb1x2qhK5TxTEVe0m2VLI0mT+EmDcVWcakXi9MiyTwXj29VDtAxoktq1gb8Cs=@lists.xenproject.org X-Gm-Message-State: AOJu0YxK0rCuPH0YJ3VbKeDeF8MD8nndxIbfodi0HotPKNbIXso/t/YW /QZT0U9xKda8xuTS67V6oDZcz+6J81c4znqgT+XbBnJI5DCwiHHqu0iA X-Gm-Gg: AR+sD10pjhikCG0Q0JGECgRY6vnrunwnKOYyGmuHDGqalgKPLnmID0zz/9771iveQYs GMi4HeBdYk8MRUN9GcSMdrKFKOco81GqHI4L95xiss637+76ZsDAAzQN3OY8LDBwHFi13xxZPsK VfOXswl2kiixvTSgS2A6qmZ1907qAjPpoG2K8iOVxxqJzcnPG+36Eg20w90xG8HBe6m794npLPe j9TMu3vKWPOhunqcmCms7oTn0bjCbSj1zR7MmYif0w+ibdYm24xG3WpFPaOh5umH2DFLKW5rqmH I63QoxiOCtCSIoKeQsYmLEaGxNGaWvY47BB1xmqz2+kJ5exZj1kR7jTJ66HHOMLeVbkI/+lsdOX Ar0T7bL8yCnde0MpPyagaa+l0BlLNagMNy0FFzPiagZ7NJinyQpS32zFxWSclYb+DJfRmA0+cRu FfTgM+W4mxr8M5QwdpZLpchrbL/Lr2V8GWQXBx9NuIHpj+Jkxx+cEG/u785bc3ikFvltwIkEcVC 5ow9rHW0W0T1jortO3SiK0bFVH6yDDw+HvlUvWr+XQ= X-Received: by 2002:a05:600c:8b17:b0:495:4491:b8c2 with SMTP id 5b1f17b1804b1-4980c66c926mr305125115e9.3.1785839202753; Tue, 04 Aug 2026 03:26:42 -0700 (PDT) Message-ID: <24351c43-0b41-45f9-8d57-e88308edd5db@gmail.com> Date: Tue, 4 Aug 2026 12:26:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/17] xen/riscv: introduce device-agnostic MMIO emulation dispatch To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <704870c1-18ec-4c7b-873c-e07e77ae0d39@suse.com> <2ef6b295-862b-40be-a7d2-c94a6378126b@suse.com> <636a6183-8c66-41b2-b820-6a02098fd33d@gmail.com> <51e537a4-f568-458d-9625-ada7fbebd842@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <51e537a4-f568-458d-9625-ada7fbebd842@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1785839204-FC20077B-8F76657E/10/73395122804 X-purgate-type: spam X-purgate-size: 3203 On 8/3/26 12:41 PM, Jan Beulich wrote: > On 31.07.2026 17:24, Oleksii Kurochko wrote: >> On 7/30/26 6:09 PM, Jan Beulich wrote: >>> On 30.07.2026 18:03, Oleksii Kurochko wrote: >>>> On 7/28/26 2:23 PM, Jan Beulich wrote: >>>>> On 20.07.2026 18:02, Oleksii Kurochko wrote: >>>>>> --- /dev/null >>>>>> +++ b/xen/arch/riscv/mmio.c >>>>>> @@ -0,0 +1,145 @@ >>>>>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>>>>> +/* >>>>>> + * Copyright (C) Vates >>>>>> + */ >>>>>> + >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> + >>>>>> +#include >>>>>> +#include >>>>>> + >>>>>> +static enum io_state handle_read(const struct mmio_handler *handler, >>>>>> + struct vcpu *v, >>>>>> + mmio_info_t *info) >>>>>> +{ >>>>>> + register_t r = 0; >>>>>> + enum io_state rc; >>>>>> + >>>>>> + rc = handler->ops->read(v, info, &r); >>>>>> + if ( rc == IO_HANDLED ) >>>>>> + info->data = r; >>>>> >>>>> Extending my earlier comment: Why could ->read() not put the value directly >>>>> into info->data? And why ... >>>>> >>>>>> +static enum io_state handle_write(const struct mmio_handler *handler, >>>>>> + struct vcpu *v, >>>>>> + mmio_info_t *info) >>>>>> +{ >>>>>> + return handler->ops->write(v, info, info->data); >>>>> >>>>> ... can't write take the value directly from info->data? >>>> >>>> I totally agree, it can. Do you think it is better to keep ->data and >>>> drop an argument 'r' or vice versa? >>> >>> How can I know? You know future plans you have. >>> >>>>>> +} >>>>>> + >>>>>> +/* Assumes mmio regions are not overlapping. */ >>>>> >>>>> Are you guaranteeing this anywhere? >>>> >>>> There is no such guarantee. register_mmio_handler() simply adds the >>>> handler to the handlers array without performing any checks. I can add >>>> such a check. The only question is whether it should be enabled only in >>>> debug builds or in all builds. >>> >>> Depends on what other badness can happen when this is violated. My gut >>> feeling is that checking in debug builds may be enough. >> >> Overlapping regions would be a Xen bug rather than something a guest can >> trigger — register_mmio_handler() is only called from Xen's own emulated >> device code, so the layout isn't under guest control. >> >> The badness is worse than just mis-emulating one device though: >> cmp_mmio_handler() is used both by bsearch() and by sort(). With >> overlapping regions it's no longer a consistent ordering, so sort() may >> produce an arbitrary order and lookups can then fail (or match the wrong >> handler) even for regions which don't overlap themselves. That would >> show up as a spurious fault injected into the guest, which is quite hard >> to debug. > > Didn't you say you'd get rid of the use of sort()? > Yes, I will. I just wrote that for the case if sort() will still present. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 04 10:30:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 10:30:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382090.1625490 (Exim 4.92) (envelope-from ) id 1wrCPy-0003dJ-Tc; Tue, 04 Aug 2026 10:30:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382090.1625490; Tue, 04 Aug 2026 10:30:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrCPy-0003dC-R9; Tue, 04 Aug 2026 10:30:42 +0000 Received: by outflank-mailman (input) for mailman id 1382090; Tue, 04 Aug 2026 10:30:42 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrCPx-0003d6-U4 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:30:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrCPx-008S8k-1s for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 12:30:41 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71bf48-bab6-0a2a0a5309dd-0a2a45018890-20 for ; Tue, 04 Aug 2026 12:30:40 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71bf50-5984-0a2a45010019-b9ff1c2392cb-3 for ; Tue, 04 Aug 2026 12:30:40 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fcc534b55000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 04 Aug 2026 10:30:38 +0000 Received: from [192.168.1.18] (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie) by mail2.vates.fr (Postfix) with ESMTPSA id D5A9882B38; Tue, 4 Aug 2026 12:30:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=zZvTd+A2AJmp5zfcAxTGKFv6JW42t67YlT7CJlkzJ2E=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=ZfxHyD/dqMUR8OdMZ1EmSMLVn4gFHSliuuXtCc059BdXuDkOfYQ1VIEvVMaWvXGEOM2jj+GEf bQBpVmZ0EH4ELE4HECdtF8YeoNkW976m7WHGx/HthPbuR/biF2pZXNOGW+kw/jQXdesMjMZBiqY oRzvl9YFbHASRL8r3lFLGi3X3gmk9LedHc2lSVUGDDvich9KFo4rpID+j4q/+LzDFHO3HeZhM/x atuzuw1ALtCfa65IJEWOZOg1nPauCooWEdKi7ULAMOevxSp5IZgz9DpxIpkxVdD6e0tsjKNON3k mHI3I6fDwne0d1R5Ki5eT2w6BPo5BXBd061a66gQR8mw== X-Zone-Loop: 5a14cca138ed5b2c24699c48932ac69c099221f97f91 x-campaign-type: default x-transaction-id: b87eefd5-552d-4b01-b45d-3aa199a70e53 x-swg-uid: 01-d2f83eec-1717-4f12-9172-00c1fd93b1e0 X-Mailer: Sweego Message-ID: <1785839438.8631fc262581453bbf619ec5b2062170.19fcc534b55000e099@vates.tech> x-swg-bid: 1785839438.8631fc262581453bbf619ec5b2062170.19fcc534b55000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Tue, 4 Aug 2026 12:30:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Teddy Astie Subject: Re: [PATCH 4/4] x86: add new pte_get_and_clear hypercall To: Kevin Lampis , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com References: <20260727150615.1373200-1-kevin.lampis@citrix.com> <20260727150615.1373200-5-kevin.lampis@citrix.com> Content-Language: en-US Autocrypt: addr=teddy.astie@vates.tech; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa In-Reply-To: <20260727150615.1373200-5-kevin.lampis@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MxACY9YVHgqPACfBH3sKssh2" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1785839437997 X-purgate-ID: tlsNG-d62444/1785839440-1F262757-D7B2A83C/0/0 X-purgate-type: clean X-purgate-size: 10018 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MxACY9YVHgqPACfBH3sKssh2 Content-Type: multipart/mixed; boundary="------------Lj3c0HMPasC8mjY3UC1lTLsW"; protected-headers="v1" From: Teddy Astie To: Kevin Lampis , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com Message-ID: <515e7c68-19a0-4d8c-815c-ca062a1aad04@vates.tech> Subject: Re: [PATCH 4/4] x86: add new pte_get_and_clear hypercall References: <20260727150615.1373200-1-kevin.lampis@citrix.com> <20260727150615.1373200-5-kevin.lampis@citrix.com> In-Reply-To: <20260727150615.1373200-5-kevin.lampis@citrix.com> --------------Lj3c0HMPasC8mjY3UC1lTLsW Content-Type: multipart/mixed; boundary="------------IFX40LrLar5N7Oq0qB0i5dsL" --------------IFX40LrLar5N7Oq0qB0i5dsL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 TGUgMjcvMDcvMjAyNiDDoCAxNzowNywgS2V2aW4gTGFtcGlzIGEgw6ljcml0wqA6DQo+IFRo aXMgbmV3IGh5cGVyY2FsbCB1c2VzIHRoZSBzYW1lIGludGVyZmFjZSBhcyB0aGUgbW11X3Vw ZGF0ZSBoeXBlcmNhbGwgZXhjZXB0DQo+IHRoZSBvbGQgUFRFIHZhbHVlIGlzIHJldHVybmVk IGluIHRoZSBtbXVfdXBkYXRlX3QtPnZhbCBmaWVsZC4NCj4gDQo+IFRoZSBwdXJwb3NlIG9m IHRoaXMgbmV3IGh5cGVyY2FsbCBpcyB0byBpbXByb3ZlIHBlcmZvcm1hbmNlIG92ZXIgdGhl IGN1cnJlbnQNCj4gdHJhcCBhbmQgZW11bGF0ZSBiZWhhdmlvci4gT25seSBsMSBQVEVzIGFy ZSBzdXBwb3J0ZWQgYmVjYXVzZSB0aGV5IGhhdmUgdGhlDQo+IGJpZ2dlc3QgcGVyZm9ybWFu Y2UgaW1wYWN0Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogS2V2aW4gTGFtcGlzIDxrZXZpbi5s YW1waXNAY2l0cml4LmNvbT4NCj4gLS0tDQo+ICAgeGVuL2FyY2gveDg2L21tLmMgICAgICAg ICAgICB8IDI0ICsrKysrKysrKysrKysrKysrLS0tLS0tLQ0KPiAgIHhlbi9pbmNsdWRlL2h5 cGVyY2FsbC1kZWZzLmMgfCAgMiArKw0KPiAgIHhlbi9pbmNsdWRlL3B1YmxpYy94ZW4uaCAg ICAgfCAgMSArDQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9tbS5jIGIveGVu L2FyY2gveDg2L21tLmMNCj4gaW5kZXggMjc4Yjk5MmFjYTVjLi5lNWZkZmM2NjA4MWEgMTAw NjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9t bS5jDQo+IEBAIC0zOTkzLDYgKzM5OTMsNyBAQCBzdGF0aWMgbG9uZyBfX2RvX21tdV91cGRh dGUoDQo+ICAgICAgIHVuc2lnbmVkIGludCBjb3VudCwNCg0KLi4uDQoNCj4gICAjZW5kaWYg LyogQ09ORklHX1BWICovDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9oeXBlcmNhbGwt ZGVmcy5jIGIveGVuL2luY2x1ZGUvaHlwZXJjYWxsLWRlZnMuYw0KPiBpbmRleCBhNjI1ZDYz NGI2OTQuLjA1NTJlOTNhYjU2MCAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvaHlwZXJj YWxsLWRlZnMuYw0KPiArKysgYi94ZW4vaW5jbHVkZS9oeXBlcmNhbGwtZGVmcy5jDQo+IEBA IC0xNzQsNiArMTc0LDcgQEAgbXVsdGljYWxsKG11bHRpY2FsbF9lbnRyeV90ICpjYWxsX2xp c3QsIHVuc2lnbmVkIGxvbmcgbnJfY2FsbHMpDQo+ICAgI2lmZGVmIENPTkZJR19QVg0KPiAg IG1tdWV4dF9vcChtbXVleHRfb3BfdCAqdW9wcywgdW5zaWduZWQgaW50IGNvdW50LCB1bnNp Z25lZCBpbnQgKnBkb25lLCB1bnNpZ25lZCBpbnQgZm9yZWlnbmRvbSkNCj4gICBtbXVfdXBk YXRlKG1tdV91cGRhdGVfdCAqdXJlcXMsIHVuc2lnbmVkIGludCBjb3VudCwgdW5zaWduZWQg aW50ICpwZG9uZSwgdW5zaWduZWQgaW50IGZvcmVpZ25kb20pDQo+ICtwdGVfZ2V0X2FuZF9j bGVhcihtbXVfdXBkYXRlX3QgKnVyZXFzLCB1bnNpZ25lZCBpbnQgY291bnQsIHVuc2lnbmVk IGludCAqcGRvbmUsIHVuc2lnbmVkIGludCBmb3JlaWduZG9tKQ0KPiAgIHN0YWNrX3N3aXRj aCh1bnNpZ25lZCBsb25nIHNzLCB1bnNpZ25lZCBsb25nIGVzcCkNCj4gICBmcHVfdGFza3N3 aXRjaChpbnQgc2V0KQ0KPiAgIHNldF9kZWJ1Z3JlZyhpbnQgcmVnLCB1bnNpZ25lZCBsb25n IHZhbHVlKQ0KPiBAQCAtMjMyLDYgKzIzMyw3IEBAIGNhbGxlcjogYXJtDQo+ICAgdGFibGU6 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdjMyICAgICBwdjY0ICAgICBodm0zMiAg ICBodm02NCAgICBhcm0NCj4gICBzZXRfdHJhcF90YWJsZSAgICAgICAgICAgICAgICAgICAg IGNvbXBhdCAgIGRvICAgICAgIC0gICAgICAgIC0gICAgICAgIC0NCj4gICBtbXVfdXBkYXRl ICAgICAgICAgICAgICAgICAgICAgICAgIGRvOjEgICAgIGRvOjEgICAgIC0gICAgICAgIC0g ICAgICAgIC0NCj4gK3B0ZV9nZXRfYW5kX2NsZWFyICAgICAgICAgICAgICAgICAgZG86MSAg ICAgZG86MSAgICAgLSAgICAgICAgLSAgICAgICAgLQ0KPiAgIHNldF9nZHQgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29tcGF0ICAgZG8gICAgICAgLSAgICAgICAgLSAgICAgICAg LQ0KPiAgIHN0YWNrX3N3aXRjaCAgICAgICAgICAgICAgICAgICAgICAgZG86MiAgICAgZG86 MiAgICAgLSAgICAgICAgLSAgICAgICAgLQ0KPiAgIHNldF9jYWxsYmFja3MgICAgICAgICAg ICAgICAgICAgICAgY29tcGF0ICAgZG8gICAgICAgLSAgICAgICAgLSAgICAgICAgLQ0KPiBk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvcHVibGljL3hlbi5oIGIveGVuL2luY2x1ZGUvcHVi bGljL3hlbi5oDQo+IGluZGV4IDIxNDliOGRkMzgwOC4uOWUyYmEwMTA3ZDNiIDEwMDY0NA0K PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMveGVuLmgNCj4gKysrIGIveGVuL2luY2x1ZGUv cHVibGljL3hlbi5oDQo+IEBAIC0xMTgsNiArMTE4LDcgQEAgREVGSU5FX1hFTl9HVUVTVF9I QU5ETEUoeGVuX3Vsb25nX3QpOw0KPiAgICNkZWZpbmUgX19IWVBFUlZJU09SX3hlbnBtdV9v cCAgICAgICAgICAgIDQwDQo+ICAgI2RlZmluZSBfX0hZUEVSVklTT1JfZG1fb3AgICAgICAg ICAgICAgICAgNDENCj4gICAjZGVmaW5lIF9fSFlQRVJWSVNPUl9oeXBmc19vcCAgICAgICAg ICAgICA0Mg0KPiArI2RlZmluZSBfX0hZUEVSVklTT1JfcHRlX2dldF9hbmRfY2xlYXIgICAg NDMNCj4gICANCg0KSSdtIG5vdCBzdXJlIF9fSFlQRVJWSVNPUl9wdGVfZ2V0X2FuZF9jbGVh ciBpcyBhIGdyZWF0IG5hbWUsIGFzIEkgDQp1bmRlcnN0YW5kIGl0LCBpdCdzIG1vcmUgdGhh dCBpdCdzIGRvaW5nIChtb3JlIGdlbmVyYWwpIENNUFhDSEcgDQpvcGVyYXRpb24gYW5kIHJl dHVybmluZyB0aGUgb2xkIHZhbHVlIHRoYW4gc3RyaWN0bHkgZG9pbmcgYSANCmdldF9hbmRf Y2xlYXIgb25lICh3aGljaCBpcyB0aGUgbWFpbiBpbnRlbnQgZm9yIExpbnV4KS4NCg0KSSBh bHNvIHRoaW5rIHdlIGNhbiBmaW5kIGEgd2F5IHRvIGV4cGFuZCBIWVBFUlZJU09SX21tdV91 cGRhdGUgaW5zdGVhZCANCm9mIGludHJvZHVjaW5nIGEgbmV3IGh5cGVyY2FsbC4NCg0KSFlQ RVJWSVNPUl9tbXVfdXBkYXRlIGFjdHVhbGx5IGhhcyBhIHVuZG9jdW1lbnRlZCAiYWN0dWFs bHkgcmVzZXJ2ZWQgDQpiaXQiIChhdCBsZWFzdCwgZm9yIFBWMzItcGFlIGFuZCBQVjY0IGd1 ZXN0cykgd2hpY2ggY3VycmVudGx5IG11c3QgYmUgDQp6ZXJvIChvdGhlcndpc2UsIGh5cGVy Y2FsbCBmYWlscyk7IGJ1dCB3ZSBjYW4gcmVwdXJwb3NlIGl0IHRvIGV4cGFuZCANCmF2YWls YWJsZSBjb21tYW5kIGNvdW50IHRvIGFkZCAiY21weGNoZyBzZW1hbnRpY3MiIHZhcmlhbnRz LiBUaGF0IHdvdWxkIA0KZ3JlYXRseSBzaW1wbGlmeSB0aGUgaW1wbGVtZW50YXRpb24gYXMg d2Ugd29uJ3QgaGF2ZSB0byBpbnRyb2R1Y2UgYSBuZXcgDQpzZXBhcmF0ZSBoeXBlcmNhbGwg anVzdCBmb3IgdGhpcy4NCihJIHdpbGwgc2VuZCBhIHBhdGNoIHJlZ2FyZGluZyB0aGlzIGlu IHBhcnRpY3VsYXIpDQoNCi0tLQ0KDQpBc2lkZSB0aGF0LCBuZXcgZmVhdHVyZXMgd2FudHMg dG8gYmUgZW51bWVyYXRlZCBzbyB0aGF0IHRoZSBrZXJuZWwga25vd3MgDQp0aGF0IGl0J3Mg c3VwcG9ydGVkIGJlZm9yZSB0cnlpbmcgdG8gdXNlIGl0LiBXZSBjYW4gZXhwYW5kIGZlYXR1 cmVzLmggDQp3aXRoIGEgbmV3IGZsYWcgZm9yIHRoaXMuDQoNCj4gICAvKiBBcmNoaXRlY3R1 cmUtc3BlY2lmaWMgaHlwZXJjYWxsIGRlZmluaXRpb25zLiAqLw0KPiAgICNkZWZpbmUgX19I WVBFUlZJU09SX2FyY2hfMCAgICAgICAgICAgICAgIDQ4DQoNClRlZGR5DQo= --------------IFX40LrLar5N7Oq0qB0i5dsL Content-Type: application/pgp-keys; name="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Disposition: attachment; filename="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7L TBVHV/XOZw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJ T4ny+OGntnJntUoRKRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJA WicutjkkUgd28Bh6HV9EIumHtCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO 8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaTVqMdqul07o72m3eA2mf+LMu9a04FX/d4 wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/EoucejoZ5SH49ksmVAmKOLkt OaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+SPhHar7TPKjFz0G3D PNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89MXfQXZ3q t1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWj moACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNz uyOVCskwfUZPla6Zpd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp 0x0HfuhcYfAYPR46XHTvjaJEv99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuR OxdK8G+YHccJY8PvWSq2K2yiae2KGiAv1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50 wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhPeP3IdpfWc8cyRLXF06Rk46YM YCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcTUwgnYlFRk2FLq0Qe KEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9Egr/Wmu3 MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEM AKiQiZa3yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ 3DbVf+en3/FvdVZg2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTm etSG5/52AjtmPFtlXAk0NmLvfJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0 s3109sJeXT5ImVdphFs9cvyZyBT9t1PbRowv58EgV0zE4hbAeVkULAbxFV5b/ExT jjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKbYu6NCfiHfEyB3Xyg9hfdrRgj MRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ovXoK4jm+Py0FiUGUa A6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/eVtR2Q1w ZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWj moACGwwACgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiV oUiHYN5QwhnbZnsaJDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764Qxy X6rld2f2RcWkDuBHun55ZWXjby8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk /dS0XTOQi2wVUb17sW/+ybCEokdVacZGzOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fu oGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+lOWSvdNHgoEkWR0RXBPQjnGm LKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/OffO485NOTKwGOxyWb0 06cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR8ULR9nX0 LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa =3DlUIA -----END PGP PUBLIC KEY BLOCK----- --------------IFX40LrLar5N7Oq0qB0i5dsL-- --------------Lj3c0HMPasC8mjY3UC1lTLsW-- --------------MxACY9YVHgqPACfBH3sKssh2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmpxv00FAwAAAAAACgkQZg+p0QLLz9Ci nQv/VvGFEbUTC5o7Bn7nY5jNoQgfXOeAu582//4PlPlCGmptOeSCXWRNBe148Yrbjsf89bQSYC9J CuzJ2RSb2FFbRoHoTflR1biBJp22ptSnbi0mPMXKWODfGkNH6F8gmo045StniJr7TfVtu8PnIhXz nZc0BUAmOG+Swq6/Udwl23VgG1qNXvCQRXQeWsyrEoNCTo8FM2LjTY5vEOaBU/iHkiFgHoblP7gS wn4NUaqiK1aTZSxW4qhw29y8N2PVfXTKTbx+lfLZT2BRAqvKXXrkh54TI1HdzOmcRv11rhQPHzj4 p3qylNA3Fd7RwF61DAXDCux9J1MsAc8aYmkaEhxl1pgh2GiwOGFkHqbYmAJBqDVJXynTAutl4Djg lGvwG75wVHGENZs2PfKJUmps55zIK2wCjs5hG7QU7EiUayHPyosiq3ozz6u2nCQZWvZJdaYukxjt tidgAqN6/7yNqqREPTQKI+pVcIeEvNUV3pjrQiPbpHJQnER2d5jjp+K2vBET =hjVR -----END PGP SIGNATURE----- --------------MxACY9YVHgqPACfBH3sKssh2-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 10:40:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 10:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382101.1625500 (Exim 4.92) (envelope-from ) id 1wrCZ2-0005Kc-St; Tue, 04 Aug 2026 10:40:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382101.1625500; Tue, 04 Aug 2026 10:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrCZ2-0005K6-Of; Tue, 04 Aug 2026 10:40:04 +0000 Received: by outflank-mailman (input) for mailman id 1382101; Tue, 04 Aug 2026 10:40:03 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrCYy-0004g3-Bt for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 10:40:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrCYx-000HMQ-AZ for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 12:39:59 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71c16e-5cb7-0a2a0a5109dd-0a2a450cd6bc-34 for ; Tue, 04 Aug 2026 12:39:57 +0200 Received: from [90.155.92.199] (helo=desiato.infradead.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71c17c-f479-0a2a450c0019-5a9b5cc7e060-3 for ; Tue, 04 Aug 2026 12:39:57 +0200 Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wrCYe-00000009nOq-2bzw; Tue, 04 Aug 2026 10:39:40 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5984030045A; Tue, 04 Aug 2026 12:39:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=desiato.20200630 header.d=infradead.org header.i="@infradead.org" header.h="In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MsldYqnXOycsS4y2/7KD3GU//XDAu63pq55swDGd2xw=; b=LGA1lkkRQbVX1KW9YPvaAmrSjX iVDDDoXj/8hc/CzXkHA5ffJ8pRRD8pKaS0GgylshFZGV1Gt51cxqLuoVgYiuV2+ASvLqawoyP37O2 ta0OHhxCiAPtEM7zdUElmcx4T8aqOOi6F0Y2q+lPdg8ionsZP3yHhQDAZ8wcCfqcYRJN5+hEbCGN8 sfZ+ukTa3ier64oRKtJsK+zhxdviWmRFE/G+2nNfwhkLzN58M0Lmk13/TM+rpL52AWovHxCh20cap NFJT1Jbuiblfw8ziL76Tp7Ia//DA11YVN9uCIT6u7MxpE8hBCpXj1BKi8NhSEyEoqHzzQKtxscgCI IVoTVISw==; Date: Tue, 4 Aug 2026 12:39:38 +0200 From: Peter Zijlstra To: Dmitry Ilvokhin Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 0/5] locking/qspinlock: Add contended_release tracepoint Message-ID: <20260804103938.GH776954@noisy.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-purgate-ID: tlsNG-d25034/1785839997-016C6A5B-6B0A1322/0/0 X-purgate-type: clean X-purgate-size: 616 On Tue, Aug 04, 2026 at 07:15:40AM +0000, Dmitry Ilvokhin wrote: > Patch 1 is Peter's draft from [1] and is missing his Signed-off-by. > Peter, please add it if you are happy with the patch. > > Dmitry Ilvokhin (4): > locking: Factor out queued_spin_release() > locking/qspinlock: Add contended_release tracepoint > tracing/lock: Use TRACE_EVENT_FN() for contended_release > x86/paravirt: Trace contended_release on unlock > > Peter Zijlstra (1): > x86/paravirt: Use static_call() for the paravirt spinlock ops Right, this all looks nice. Let me go queue this for the robots. Thanks! From xen-devel-bounces@lists.xenproject.org Tue Aug 04 12:31:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 12:31:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382130.1625508 (Exim 4.92) (envelope-from ) id 1wrEI7-0005n1-Gy; Tue, 04 Aug 2026 12:30:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382130.1625508; Tue, 04 Aug 2026 12:30:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrEI7-0005mu-E6; Tue, 04 Aug 2026 12:30:43 +0000 Received: by outflank-mailman (input) for mailman id 1382130; Tue, 04 Aug 2026 12:30:42 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrEI6-0005mo-2o for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 12:30:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrEI5-000bEY-7M for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 14:30:41 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71db67-e002-0a2a0a5209dd-0a2a450ad7ea-44 for ; Tue, 04 Aug 2026 14:30:40 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71db70-f2d2-0a2a450a0019-d1558035b139-3 for ; Tue, 04 Aug 2026 14:30:40 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49545ba3d4eso15440815e9.3 for ; Tue, 04 Aug 2026 05:30:40 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41d17f2sm47140603f8f.2.2026.08.04.05.30.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 05:30:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:Autocrypt:Subject:From:Cc:To:Content-Language:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785846640; x=1786451440; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tD8l2te+mjYfra2fISPdgTAYo6a1/PWVUQZcpuPMPqA=; b=GRMig7i9cvXEeMTERAjZw7i0Xy1md4hJ1cqzuCYxEEnjE4wazw2+FaHjVjaLNvrR3h x14i/RGxZ8tPrHLiy3/+0/byV5hnFq5qdO57gGcd1TwoudZ85vT9JTVaNCnH54XeGv1/ KtZlmflXNZ/0ARDb5DY1KnyXa1BbRYhmp2WB6xbVL8G0hKuopvOqki19KdYTP3v1Y5dt P2PKyrFwjEaHX78El86fPFUDgm2DkB/I+T13P6/0Yz9IbIksQnv2Rhyv2cyteof+mqrL Dz8n8XaMzj3jQHe1hFG5Jt9LJ6aEhws8UhZXN5d7E4qn44naQhkZ/uKp3XUY2uSVaAv7 rj6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785846640; x=1786451440; h=content-transfer-encoding:content-type:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tD8l2te+mjYfra2fISPdgTAYo6a1/PWVUQZcpuPMPqA=; b=oryiNJbpmMIpKNgdyoBWNrJs94JC5yAq0S9XhoWaSUKZ9pvXGon46AMOL6qS75aII5 zikzJ1ACnjunhTeajbgfwg2yZtzoApR3GH85IG4/pRab6xPFOodV+lptfaxgDbqRZa+n A+/XzE5QgaJKJlHZlzOE6apfqQwo3q95u65kUliTdJmsOCiVJcuaxJP8H2/iGE1VD0m1 2azRRO14oEiy4BEv/NbI0A1VSgwVe9DuKUEZ+lWAhrIqevoeBUUNHAE3TdWWu0HX0aYV AmM+zGXk1yYcWx+dgu1qCZYDMctdnVBYv1U2fOVDh0r/LraaJmxdO+hTRrN8JisCLW6i WdNg== X-Gm-Message-State: AOJu0YzhqzkVq+B5W0HeQsWdVIPRdJM45KHEgctoT7kj/dfGWRxSUXlo sFV/NLFgURpJMY561Opy/XuZCNPsScxOAAu+/JSvl/RGI9lx5R7pdU589OhrBwcBgTsu3jRl/19 CZfr8lA== X-Gm-Gg: AR+sD11JEqq1FKUgMOFjmczTvDUAuqtTu1lGRRB6D72JkdmXCOsr4RFgodn0bXXdipe HjT6xf5+tofz1GeW6lCFelsk48ZTl3tSfpo2zCrZX8D/vz8AAIVmhOyRD5JpaVI+6F5DyiGp7Az b0EsQl5OuTPJWv+k3+B5ZVl/9OCoPvjhO4f2FO80A+kk9UI3GBkl77Cbj+UqiaYyNB+qJVigHUX SfLnFaX+iO39mx17UV1Odrf3ZP1SrP6kL0tz+qBBFsP1Xrft01I3tbjTMQV9p9NM6Xrm5Em8wmq jHeVDT6zLOtlT2cWfFAnw+nEIHHt54XGqWw4OKOWfM8sf9RBEIuahIcBelrOQ/V13s6vFcFXiL5 jcQO2Dj1rCCXdYukZfZeZT8w9qIteHvpXH3r4tUDNpRvUvphQLJUax6Fs9w+91BC0FkHr+syGaH P6iDb0430mN2b/79zMaO8MusCdktUKIWblOVq4jZBsuuneoaoI0MvXEPi+i87HiI861cq6CcHyh dwt0XNQ6LlNtvqqsP0MaM9LgwMca2upKSXwPSA2N4YeXzXZa5C+ X-Received: by 2002:a05:600c:6d03:b0:495:7a23:1eee with SMTP id 5b1f17b1804b1-4980c674f32mr243964825e9.12.1785846640329; Tue, 04 Aug 2026 05:30:40 -0700 (PDT) Message-ID: <25cf9c88-7589-4a5d-994d-45f488a3e00b@suse.com> Date: Tue, 4 Aug 2026 14:30:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel From: Jan Beulich Subject: [PATCH] radix-tree: drop radix_tree_init_maxindex() Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1785846640-4A9D9CFC-F5BD7A87/0/0 X-purgate-type: clean X-purgate-size: 2590 Radix trees are in principle usable as soon as memory allocation works. (Radix trees with only index 0 populated are usable even earlier.) If only there wasn't height_to_maxindex[], which is filled only by a pre-SMP initcall. The benefit of this array is rather limited - the calculations done by __maxindex() can as well be done by radix_tree_maxindex(); the overhead isn't all this high. Fixes: 21844b0e32e7 ("PCI multi-seg: introduce notion of PCI segments") Fixes: 8dc6738dbb3c ("Update radix-tree.[ch] from upstream Linux to gain RCU awareness") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- Two Fixes: tags because the use of a pre-SMP initcall was clearly setting up a trap for later code to fall into. I know for certain that I've seen logs of Xen running on multi-segment systems. I can't quite explain how that ended up working. --- a/xen/common/radix-tree.c +++ b/xen/common/radix-tree.c @@ -32,12 +32,6 @@ struct radix_tree_path { #define RADIX_TREE_MAX_PATH (DIV_ROUND_UP(RADIX_TREE_INDEX_BITS, \ RADIX_TREE_MAP_SHIFT)) -/* - * The height_to_maxindex array needs to be one deeper than the maximum - * path as height 0 holds only 1 entry. - */ -static unsigned long height_to_maxindex[RADIX_TREE_MAX_PATH + 1] __read_mostly; - static inline void *ptr_to_indirect(void *ptr) { return (void *)((unsigned long)ptr | RADIX_TREE_INDIRECT_PTR); @@ -80,7 +74,16 @@ static void radix_tree_node_free(struct */ static inline unsigned long radix_tree_maxindex(unsigned int height) { - return height_to_maxindex[height]; + unsigned int width = height * RADIX_TREE_MAP_SHIFT; + int shift = RADIX_TREE_INDEX_BITS - width; + + if (shift < 0) + return ~0UL; + + if (shift >= BITS_PER_LONG) + return 0UL; + + return ~0UL >> shift; } /* @@ -705,27 +708,3 @@ void radix_tree_init(struct radix_tree_r { *root = (struct radix_tree_root)RADIX_TREE_INIT(); } - -static __init unsigned long __maxindex(unsigned int height) -{ - unsigned int width = height * RADIX_TREE_MAP_SHIFT; - int shift = RADIX_TREE_INDEX_BITS - width; - - if (shift < 0) - return ~0UL; - if (shift >= BITS_PER_LONG) - return 0UL; - return ~0UL >> shift; -} - -static int __init cf_check radix_tree_init_maxindex(void) -{ - unsigned int i; - - for (i = 0; i < ARRAY_SIZE(height_to_maxindex); i++) - height_to_maxindex[i] = __maxindex(i); - - return 0; -} -/* pre-SMP just so it runs before 'normal' initcalls */ -presmp_initcall(radix_tree_init_maxindex); From xen-devel-bounces@lists.xenproject.org Tue Aug 04 12:59:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 12:59:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382142.1625518 (Exim 4.92) (envelope-from ) id 1wrEja-0001B0-Lx; Tue, 04 Aug 2026 12:59:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382142.1625518; Tue, 04 Aug 2026 12:59:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrEja-0001Ar-Ht; Tue, 04 Aug 2026 12:59:06 +0000 Received: by outflank-mailman (input) for mailman id 1382142; Tue, 04 Aug 2026 12:59:04 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrEjY-0001AU-Cn for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 12:59:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrEjX-00FGT8-3H for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 14:59:03 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71e214-bab6-0a2a0a5309dd-0a2a45059f44-6 for ; Tue, 04 Aug 2026 14:59:02 +0200 Received: from [52.101.43.66] (helo=SJ2PR03CU001.outbound.protection.outlook.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71e215-4cb1-0a2a45050019-34652b422d9c-3 for ; Tue, 04 Aug 2026 14:59:02 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by DS3PR03MB989170.namprd03.prod.outlook.com (2603:10b6:8:39b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 12:58:59 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Tue, 4 Aug 2026 12:58:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Cht8kZ5bmVpp+Rqysj++EissTq5dQVrnbp7T9FRAPVdTp9YkLgvsP1W6E7R0cs4/JweBEhZsuMNGKVqyhubFF04ApOHFFVPLDy1eQjf/Hq3GynZKrVmFjDPkLmFrOAPBlRdLV9iPG2GiREctRN4B7ZHOK0snQV4g5IC5uE7BnPWqQcgXlT6iQ4H2pHmMbPeZ6RilreSUcUl9nCh1YK8Zuc6HMloPIQJ0jVNjoBB3H8f8M9B/bNO4uT6/UIzbl9ajfGrxcfqjBDClchFJkHmQMXQfI5AM3HeOAJ4kri1/mzuGa3Qiy03h0D9vMUhmKUzCwYGqI2GwiZqtQwxX5fPSqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xlZhJWvCveYBdustcfvWoJPNK1wtPBpfURVhKnBVXaw=; b=udiL+63e3Ubs7nTOy3WtTIBQdf8lIe7D9LKlMfzwWvRKiF9utrCdX36Je1yF0tcz4V9RxVU/ZCa/IwM/C9JmCqm6tUBcLvmz4JWU4HxkAyoy8izJfUj6JCcoaiy9Lytln60bHHEjDlRRGt8IjAoIYCoIfGF3J93cEWWN2Wz5KrAJ3DUAwkSoc5I8hzqklNyBKFVOTzWOhGRVuLb03ZPz+Nnszeo6O/EGvl+AZ4owJtPx1z+xiYRGyqsNkyU1HNI9BsBdOekk4GwFLDIQYhDBR4lDCx1B4yAaHLEl+2ZqgyrKQKa5Kr4ecNW04TLKiF+TBAeWokOlIEuIODXP7YqurQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xlZhJWvCveYBdustcfvWoJPNK1wtPBpfURVhKnBVXaw=; b=ilhfrZGW0Mjum8m4ZXBNqZoZjc6QdDIKQjRQ6ijPgIYbe1jbKJAz1bQ5Ay75YQUAKKzJfjDez44CLH1huGmffV0tPPxvUp8gz1owO8Epo/aqfUHwtkp7HvZknj9IM8Rv12xQQeGjhYyQx6k1c/X4EIBfGSjL1B0yJZ43O1MMD2w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 4 Aug 2026 13:58:55 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel Subject: Re: [PATCH] radix-tree: drop radix_tree_init_maxindex() To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <25cf9c88-7589-4a5d-994d-45f488a3e00b@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <25cf9c88-7589-4a5d-994d-45f488a3e00b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0137.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::15) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|DS3PR03MB989170:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cd4c0ac-9034-4c97-f87b-08def2282648 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|366016|1800799024|10067099003|56012099006|22082099003|18002099003|11063799006; X-Microsoft-Antispam-Message-Info: 4K91DknpsGFmMfiNF/wGPEDlIw7taLyfZ0Jj9R2gkybEkkh6psadKfxla5iqMpy9AUIqtc97ow0sTpQOEmOqBCRlkV8KUDbRycD4FEZuYa/wDoh0X/OL8JC/epfPDyz4FbDDWPyMZ9qmyqo8h3NCF33ix3DhWtw+GBQ9jBl0s2VTkoyjM0i/MmKWiMaPyhu0VzAs8DQvSiMlKCrnols6IfBOG7SOqbXIAT84ctaUuPNAd3Epsos1aHgtxH1xf2dF1FcUhT3HzlxtIRbhRpedoYyXQ1OyntQPgd1x7RRsGFgEV3PRt/Yt0rU/OMaQcxnG44SrIcLTPmhcafEpIlucawGSZJgFVqZRmI5DYAzJT4U8MaCQuFC/wKo/NsnSalcZBNMmMlxpoIF0DvBxskANe6pKDNfUTrT2B3pof0fO2QZnUL+k4J2W28hT4kuS3wL++ahsT3mcniIn+89SbgYI/EN9pmtWuIiEizpPpgLNQNjexH1G3k115wCk9RsOUwFZ5E76QxmyVfcd0aK9Zi9GrO4nm3bhLshDyAOBCECDvoIAg10Sj2K7wh07dA5wE1zjgBpy0g3yeN7eKEnPwBxDj7Lh+ffakpGAn5W4i48q1FEFKbXcNSOPKG9ffV843EmPK2ylhWUhfgDdGlPdzD30KwfVAzqRB7RllDSxx1c/AqM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGQ5dm5lUzdXOWJnT2RONzV0MFRwRXlmQytrb3NtY3dXU3pwd2VCcjNMYTVn?= =?utf-8?B?UFpVa0tGU09ZUGwxYndYNjBieXZWeXlad1hQdEdONGtiVVF1N0RnTXVwVTRs?= =?utf-8?B?akVjbjhLSkhiNlBzRG9CV3lkNFZUdmpWTE5FYVdXSmZLdFpUVitYL0lHMGNt?= =?utf-8?B?Y05qS0xoNUpjaldEb3dWbEQ3OGhiMzNDYks0YWtVMngyS2M3SG1kdXhyRmVh?= =?utf-8?B?dDZKSDVTYlJCOWFkTmlaT0syTXBIMHZJL1dzb0N6STR1RFVveS8vQnczZWFM?= =?utf-8?B?SHNQMmpiT2RyRXN0cFhmODMrSlh1VzJEM2FUVjRET01OaGt1UnF2aSswbzM0?= =?utf-8?B?WU9WS3d3YmNLbDF1ekVGYWExWCtXa1lmdDE3Z1l4d0ZDYUl3L0hvQjhQaUNr?= =?utf-8?B?ZGhGejRZTDFBaDZ5QzJ0d016QkpsWEhTSmFvVFVRT1JPSzU4WlFjbGt5amMw?= =?utf-8?B?aU4xWCttSkJKZ01OcjZiV3drWkhBM3hsMFJxVmdRVVJkdEpQUjJUeXFOS2h4?= =?utf-8?B?bStoVCtTcEF5YUxDWXJ5djdGY0poRlorT0J5d0d2Ui9oTlQyc1dDMmlibmkz?= =?utf-8?B?ZTVRMFA5b2VVRC9BZTJTMWlvMTAyMHhVb0g3b2p1WXRVZzZvL1hRdWtqaysw?= =?utf-8?B?N0F4S1p2RHhZbUdmUlZVVm1tOEN3TnN5akMweUU3bTF3cjJUcW1LSmljbmho?= =?utf-8?B?bjlCaXdocE8xeWlPR3hlOGxpdlFWeldzSzBZZEVLR2FLdGJJQ2VQb3FvVWE1?= =?utf-8?B?b3B2OVlsVVJOTnZ0MGQvYWtBaDUrRVllbkNDS2hVY1JjVVpLTmVrN1YySCtw?= =?utf-8?B?cXFGSlI2QnFXMGJxNE9QS2xVTDNLTHQvWGd1WjlDL2JUS2Z4RGdRbUJRL2c2?= =?utf-8?B?OWdBU0V4N0ZmT09XMlZLeTJzNmI1ZnBhVXo5M3p2SE1tb29DSVR2R2JFRUZw?= =?utf-8?B?WmJvaC9laE95aHc0cE8vdkpqcG1jOUx2anFySDk1MTVaNVNLak5vTUhrZ2VL?= =?utf-8?B?OVQ3c3hXdk1DRGRBcWZyK1pSbzRzQjV3b3R6QTlEYkFXVlROeTZFRE9JUE15?= =?utf-8?B?S3hOUFd2bk44VmRQNTNKQmVlNTZhcm9KQktycEMxdzdWWGd6RG5WU21xMnpL?= =?utf-8?B?eU5xZDFpVmZ1M0t5bU50YWRVQTZmY0JIcGc2TE9Uaml4QjVWVExDM1daUE81?= =?utf-8?B?MEFMc016NURReGFwWTljN1NLcitDcFJtcHo5Mnh2RStxVnV5aVpLNW5QOXNn?= =?utf-8?B?bjdSVmIrZkpCdkhJUHVGQUtPK0E2ejRBSnpVL0Q5SUVMYzN6cW81aG9oR3NL?= =?utf-8?B?b0FseVhGTFVuSERWamNMdWx6eVRPWW0zbG1KYXplVEorVHEwUGpCUmJ6N1NJ?= =?utf-8?B?QmdzQld1U1NoRHNUa0VRSjlzcWVzMjlET01nc2lkcXArTk9aR3M0Ynowb0FP?= =?utf-8?B?dDlzcTJLU3pQdHVraG82bXpGeEtuTVBFNXZFU3V6MGNFNmVCTmZzYnVZOU8y?= =?utf-8?B?RXlzUDRSOE9JK1F5aW1STkRsc0lEem43T1p1L3JnMTBDdkp0bEhsUVBSMmFW?= =?utf-8?B?akFtSjAzM2l5Yk4xV0FTeWlmNXk5aHJuWTJyaEZJL3FiazZJT2kwZEI2ZTRt?= =?utf-8?B?NWxqUTJLTkJXdCthMEwweGRRYmlNVjJ3YVIvY3RsbHAvYTdtNHVrTTBkWFUy?= =?utf-8?B?YzNrenQ0WmVST1B0c20vcExicEtJYmt2QmZDZ1RJUVZBZUwzNnFxbHpuSEdP?= =?utf-8?B?dU9tc3I0dUpReHZZeU0zSWJnblBnNkFCbU1JOFZLdDJUMGw5U3VsYWtlYWsy?= =?utf-8?B?TW9iQ1pONDJYelExQk43N1NtOTdnTXNISXlUeHhsV0dDa3c0VUJuRHZ6ZFdM?= =?utf-8?B?Y1dCVm5La1dIZmtPcnBXdjJoMGE5U1dIQXdVYUc2WEltS0VJcVJoeStwNjFj?= =?utf-8?B?SnBLcm5VRCtrNE1EdDhLWGV1Z3d3YzAyZFJ6eDQrbWZQYUJUd010dWFwMFpO?= =?utf-8?B?WjNScDZFTWUrQ2tUa3hzWXlKUDlvK2xPYjkyNTZiZ1lPOVpFTFdXRGwyOWwz?= =?utf-8?B?QUZiSUtVbTROUi9pekY0MUt3L0tBTFcrWDNMWllHUUU3ZElQb3JUaXVQY0JD?= =?utf-8?B?Wm53MU5XODdjRlJDMnNGR3BXQXBDMHRLYXYydjZSYVNWVVVUVytzdGcyejVQ?= =?utf-8?B?Wmk0cGh5YkJaU0o5K0JmdFNUTHUzUXd6enlUb01ocVp5T3JhSzAzSkYzV3Fv?= =?utf-8?B?eFF4Nk9zNEE0QnJwT1RuMGRsbzFCZHVzeEVqQzd3eE1DTXF6RXFMRXdqSk5Z?= =?utf-8?B?M0haN3NWSkFjclBhZ1lXZi9iOTE4L2ZSQ1FndVkwd2RKazY2T3NGMUtGdXhQ?= =?utf-8?Q?wsVzOesj6cSlTu2g=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd4c0ac-9034-4c97-f87b-08def2282648 X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 12:58:58.9147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bOi4JPLFHhqtp1O8gmwwcw1scPGQzz5EinEF3rb6E2xRvmevhcBM0AOL5MYM/YecbYLR2/8yhugKt1VTxQjUB1dfxB/hug0wir//AUXzztY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS3PR03MB989170 X-purgate-ID: tlsNG-c201ff/1785848342-F66B52A1-4DD798D3/0/0 X-purgate-type: clean X-purgate-size: 3046 On 04/08/2026 1:30 pm, Jan Beulich wrote: > Radix trees are in principle usable as soon as memory allocation works. > (Radix trees with only index 0 populated are usable even earlier.) If only > there wasn't height_to_maxindex[], which is filled only by a pre-SMP > initcall. The benefit of this array is rather limited - the calculations > done by __maxindex() can as well be done by radix_tree_maxindex(); the > overhead isn't all this high. It's quite possibly lower overhead.  Some simple integer arithmetic vs a memory read. I think it's worth noting that this was found by UBSAN on a multi-segment system: (XEN) UBSAN: Undefined behaviour in common/radix-tree.c:83:27 (XEN) index 12 is out of range for type 'long unsigned int [12]' ... (XEN) Xen call trace: (XEN)    [] R common/ubsan/ubsan.c#ubsan_epilogue+0xa/0xd5 (XEN)    [] F __ubsan_handle_out_of_bounds+0x9d/0xd4 (XEN)    [] F radix_tree_insert+0x24d/0x570 (XEN)    [] F drivers/passthrough/pci.c#alloc_pseg+0xc4/0x165 (XEN)    [] F pci_add_segment+0xc/0x1b (XEN)    [] F acpi_parse_mcfg+0x29b/0x344 (XEN)    [] F acpi_table_parse+0x5d/0x92 (XEN)    [] F acpi_mmcfg_init+0x3a2/0x71d (XEN)    [] F pci_setup+0x17/0x29 (XEN)    [] F __start_xen+0x394c/0x4ed8 (XEN)    [] F __high_start+0xb7/0xb8 > > Fixes: 21844b0e32e7 ("PCI multi-seg: introduce notion of PCI segments") > Fixes: 8dc6738dbb3c ("Update radix-tree.[ch] from upstream Linux to gain RCU awareness") > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper All the UBSAN violations are gone. > --- > Two Fixes: tags because the use of a pre-SMP initcall was clearly setting > up a trap for later code to fall into. > > I know for certain that I've seen logs of Xen running on multi-segment > systems. I can't quite explain how that ended up working. At a guess, we limp along with only segment 0 until dom0 reports the other segments. This particular system is set up for GPU testing and the GPU is in segment 1, so something was working well enough for that to function. FWIW, there are still issues on this box, even after the fix: (XEN) setup 0000:fe:00.0 for d0 failed (-19) (XEN) setup 0000:fe:00.1 for d0 failed (-19) ... (XEN) setup 0000:ff:19.0 for d0 failed (-19) (XEN) setup 0000:ff:1a.0 for d0 failed (-19) (XEN) setup 0001:fe:00.0 for d0 failed (-19) (XEN) setup 0001:fe:00.1 for d0 failed (-19) ... (XEN) setup 0001:ff:19.0 for d0 failed (-19) (XEN) setup 0001:ff:1a.0 for d0 failed (-19) These are the PCI devices for aspects of the uncore, mostly performance counters it seems.  Despite the lack of information, I think the complaint is about setting up the IOMMU context for them. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:26:18 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 13:26:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382155.1625526 (Exim 4.92) (envelope-from ) id 1wrF9o-0005lo-M0; Tue, 04 Aug 2026 13:26:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382155.1625526; Tue, 04 Aug 2026 13:26:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrF9o-0005lg-IU; Tue, 04 Aug 2026 13:26:12 +0000 Received: by outflank-mailman (input) for mailman id 1382155; Tue, 04 Aug 2026 13:26:11 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrF9n-0005lZ-GX for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 13:26:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrF9j-00EwWZ-LD for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:26:07 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71e865-bab6-0a2a0a5309dd-0a2a45049eec-22 for ; Tue, 04 Aug 2026 15:26:07 +0200 Received: from [52.101.193.39] (helo=CH1PR05CU001.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71e869-b57f-0a2a45040019-3465c1270510-3 for ; Tue, 04 Aug 2026 15:26:04 +0200 Received: from LV4PR03MB8234.namprd03.prod.outlook.com (2603:10b6:408:2e3::8) by CH4PR03MB7650.namprd03.prod.outlook.com (2603:10b6:610:235::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 13:25:59 +0000 Received: from LV4PR03MB8234.namprd03.prod.outlook.com ([fe80::264a:2e82:2064:7fab]) by LV4PR03MB8234.namprd03.prod.outlook.com ([fe80::264a:2e82:2064:7fab%4]) with mapi id 15.21.0292.015; Tue, 4 Aug 2026 13:25:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qQce9i+beoT6Sz0IVgC6nTOtXRH08LaAU6TN99Zp6jSivd5TcGZuw1aCNQ3ZMJ192e4XemDu74Wp6lk4olG6oWacohmcu6VtnqM7tOpxCJ80ElC1XsBhDCaAinyB6LnwFGVQWrSXhKz1rvbQlCQ7z1bxd/YZhXUwXdxE7EY9PQjI4CjJHPeL+nkFhFObp4c70XN4wMM7qssl1uxa+KGrbDyjSYQXTso99D5c3bTP0KHlGS57HY8PjlvvwxyEjmksUrWiYXC/zwAeAujGIaALaf3+3ynlEm/SrSAW+Odpqb8jJCG3+9or99waMX6aItkZBsi+afcD6T3vf2aJYmmkEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oiW6mLdAAoCz8vBWUjYfWULIRb0u3XW6lB+9qHUuNCQ=; b=lEbH41CRA+BuhA+EtS0EWIDpngY8wWksYmrfQxy2D6ZSULGwSYSypcS4t2qvj9WRsj2T4jh5pmsKViTc6L9FC1NEy1ANuM2QxL6Et9+sCTiCJhGFbx28khx1L4ScNO68ISi2B4YmfKIFT6qXKr3VmBx6Zm9Z8BOYEW9LjDqheEF0rjjsuUaaMXy21nqwvIUts+U3BnuXUpJvRaswI87xu5O8B3iWWH1M88KjqOP5d9BQlhhEoN0/HSif5NVujinlWntSoL9DUAR6geyYwzQNHs/8xlyY5lNBOV9KFhcVCEbxGKB5ri3mWvRSfBNoGex9QYkOZbWJAVcsNFq9hPLAng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oiW6mLdAAoCz8vBWUjYfWULIRb0u3XW6lB+9qHUuNCQ=; b=eq4TI9tggU+2MqOlJgRn6vK/6U5s8Y8AJaRp5sOomWJLwuNn1Q7az+7KxT78cJ0EcvLHvy8vLsjJHDOwbJDREqVRfAyc061p01daPboeG6zbRe/p1zslY2PRA/kUg9eXKeECWotTF4pwjXF7z1G9di/wpbOEkLsRxVQkBvNbQiI= From: Marcus Granado To: Frediano Ziglio , Teddy Astie , Andrew Cooper , Roger Pau Monne CC: "xen-devel@lists.xenproject.org" , Anthony PERARD , =?iso-8859-1?Q?Marek_Marczykowski-G=F3recki?= Subject: Re: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type Thread-Topic: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type Thread-Index: AQHdGF9mhIhyvqGSRUyPVZ4Z3HHB7rZ3oucAgAJQsgCAAB5PgIAKMo6AgAhhrfGAAQyTAIAAA40AgAA+3Ks= Date: Tue, 4 Aug 2026 13:25:59 +0000 Message-ID: References: <20260720154832.1907401-1-marcus.granado@citrix.com> <20260720154832.1907401-2-marcus.granado@citrix.com> <1784622046.8631fc262581453bbf619ec5b2062170.19f83c35cd4000edb5@vates.tech> <1784755834.8631fc262581453bbf619ec5b2062170.19f8bbccffd000edb5@vates.tech> <1785834903.8631fc262581453bbf619ec5b2062170.19fcc0e18f8000e099@vates.tech> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV4PR03MB8234:EE_|CH4PR03MB7650:EE_ x-ms-office365-filtering-correlation-id: 14ed79d3-2558-43c8-7ca9-08def22bec68 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|10070799003|23010399003|366016|376014|1800799024|38070700021|56012099006|6133799003|10067099003|4143699003|11063799006|5023799004|22082099003|18002099003; x-microsoft-antispam-message-info: 9cMZ06eFEkIr4hMVI+ljPo08HkzJ0tUkZK4Ake+Zwb7GA7pcDF/fBk1Srj6P7Sq6KP4LqnJVtuoOAd5y9yTgutE4y2uuDRM0Z1hrVp/cjOB6GIDIW2ENqAhT8+7zykPj0mcUn8ybVKPXI4g2FRPTIzwYMpVRvn6nrssd2I2oxuGdXcU2c7n194ZH6utRXUvDt40HpeAlbhMaQ1ATrffpJsyMrezmjW37HQyDoPaDqx5Gsdvu3z90wL004FZ+67moAUrhi3PSlevtClUdyg68kYSyHN0gOqRTuLdQb9vOEBIYEUndAGo+tJm1dqO5vy0EWUGTvyzlMXLKq815EH5NHHjZW/bJbKT1v5PUtzMuTEozYeXelzBg0f86/q1jFzRNSGQLS4Rnfiofm3c+Jj0oKTBk1lMGmNIgCUcz0J5iQMHtsw6JJ0PLxlBks35bnHAj+rL8oAqD5CxZgDaSYoYBlINcgt9fQbFzIxDfRJJ4scfBVJr9rWnDZgU6d1FNJqaZlW+KiGd77dgFErImKMHShTnVJJUQDfR+O7XlLOAzniU+GI5JbzQttXo+XaSjEV6yCVtiCW9m95+oEOAEthFGnYHX8HOninNBi1muGAS94YWuygrS9atUssa5tXaasqh936XGmTI+iorDORCb60s+1voOz1c9NtUzxw/KAD5GSFrsOijzkw6Iax/zwxU7H4+6v8WIeNqdleea0q6Qq0Ow0K+SuBUoLifV5Pvun5Weyuc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV4PR03MB8234.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(23010399003)(366016)(376014)(1800799024)(38070700021)(56012099006)(6133799003)(10067099003)(4143699003)(11063799006)(5023799004)(22082099003)(18002099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rFqBhGpF3XwwZDp4wqSseYm0EKVdGrmgXONwwYb3EK4YGGE/uR64qoDJfl?= =?iso-8859-1?Q?4SaceeTVBGKrcrfbdPP5fi2yrKZiaSmkAd0wVWnscCMHym6nyhEiP4neME?= =?iso-8859-1?Q?v5t3SXQVPLMqJE+aF361I6xhfqZYk26z9RoTCoIqCIvq/YwYOg0yeBRe/P?= =?iso-8859-1?Q?4SOKET1cYkZDnGpMqqpCCWj2bG59L44EB+WCOWKysbHuVrZl33C1P3FhHT?= =?iso-8859-1?Q?OJLBUxqHyjafVFgBxOu+whBR3jM+p0cwMIfpMOs1oIn+Tlhb1Gb0LSc5T6?= =?iso-8859-1?Q?l5Wcg4Bx0drSZl4p5U+YFjmhu3exBJaM5MlTmQhgUgzhNqD2296Q75QU88?= =?iso-8859-1?Q?TD9uetCuDscqQksFPF4certwjS/UAfdfxlbHVA7KG4BkBpc+3QXP4NyrKu?= =?iso-8859-1?Q?fvMxxgjvHGVlYjgen/XhEDzZo91kwPkHogyw0CHOCo876gU92Q27GCzGpI?= =?iso-8859-1?Q?2HHqDcsnKtPmH/FMdgmPYjbhpq2u3CcM4gFTCwBtoEijTmxQDAcYKjv1ww?= =?iso-8859-1?Q?wtHv33ZrzzuKJ5JoglNNe/NxMkB+utFTcvz5Z61b0/HyFehH/GYy6mdIQB?= =?iso-8859-1?Q?zm8xLQ5ubYhuqo93qR53bnaxl7282DppHA6NpKVqGK8eCEfNntkOBicyLY?= =?iso-8859-1?Q?Oi0owwZNv0bRUsU9i8Np+VkXU4F1eG73MiQn3FqXyogt5C8atc9L1upTVJ?= =?iso-8859-1?Q?bGGJeBqsgu9OYWImTEaKU8Jlk+Im6IDj5ywqLEcVDm+QqXhSBTNmmU3TwF?= =?iso-8859-1?Q?RUM+md6Yg09/v2//goa4IjKXkh+IMMgMVtoCrtQB1z103rKUSDZyv3Vi5M?= =?iso-8859-1?Q?21z4zqMgVlj5NVylt6crFmY+j5MLGOzjZz5eI6xa8B3NZnO7EgbZvgjYxt?= =?iso-8859-1?Q?ISoRI3mO66x6IvY5zEIA2lnL4u4gRdMa0Vk7xnjx2X1SeMYHnO2nv25oI/?= =?iso-8859-1?Q?tiwD4oMb9Wgbgf9oxgd6W9nZ3sA8HRo7Bi8aAjkYQ92V+lyWKUeMyFOKXf?= =?iso-8859-1?Q?bWPZd6aSfaDHSvi4qLW+VuqIIlbbqOvosIJqKf4fkCNFHSm2XINb0+n8pm?= =?iso-8859-1?Q?o8N5W+2BL/pBUegKhvRYmearsUzjrDeg61LoFRLNaRlMC9yaxYjxhN+lQi?= =?iso-8859-1?Q?psSqLmwQYOWAvh29DC6uxKJTHcWQrzdG/xMj9pM+slQTwWFLHQvz8it3Mv?= =?iso-8859-1?Q?9ZMeosQLF7GOSvA8QHEGzbab3cdqrH2ZZYO0Dehi9/3rRINu+qNy261nxr?= =?iso-8859-1?Q?oLve5gKY5nFNwQ6N8Rzg3A7SkZECly9EI4R9rezvnuaMIxscXhK7hnm2BI?= =?iso-8859-1?Q?pdmW4Aht5241TSozsvf8o/aSBsSvxE+IPOXbRzizhaYX2PDtyWfVgeBXVd?= =?iso-8859-1?Q?JS/dDs+OmxFQ4w3ptlaLrjiNZ2vPojYQrNlkDenGsrfW1VRSvULJvwnbkJ?= =?iso-8859-1?Q?2sKA+O3EkTcoR0PLlcJ2NdBJFtpfOQwAHGzwWvnUVsVrgF7kunAlmM2Rit?= =?iso-8859-1?Q?SIuloSFe3RaWbwOo09eW7yO0Sy38E10Z9EJ+SB8gtxEL2Wk2Uf1AKadxbm?= =?iso-8859-1?Q?X44NT2RL7CqgcV9QuU2r5p+yavW2ZUMVmhdt51NWGdURalxefJG+M7r7yA?= =?iso-8859-1?Q?ejN0ykZe1+SgrlHQ4bmfcn1oWG8cEREOLlHLNMsZYgty/tPc1k62I3TH36?= =?iso-8859-1?Q?ShEtQ3dYxFBxLLqI4MzFtu0rdQwZ/FaUXDjLukMNSLHv+TwiUW1IF9zUK/?= =?iso-8859-1?Q?y9K9Q/AOCyY1ENDH70xLUZWgt/fANbDKjwdjOfPKkOI7BeQifqUJ9LCMLh?= =?iso-8859-1?Q?I8PFF+2FTzOIegPpbjSssyPbms939mjIDF9Vxd0EmKbnzjz5knt+eoaNnv?= =?iso-8859-1?Q?Zb?= x-ms-exchange-antispam-messagedata-1: MdL7AZZ066Q20g== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV4PR03MB8234.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14ed79d3-2558-43c8-7ca9-08def22bec68 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2026 13:25:59.6436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ggaNSiIXgARp+KVX8hqCBhDHuB6FKUsYRxTrVaaFPv9DeNUqG67+0qErW9EdCJzM92mWya6Lt5JTQY/Wim4e86QJlh8bfSqGTr832a9rdMA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR03MB7650 X-purgate-ID: tlsNG-ebf023/1785849964-51ED6B50-92D0355F/0/0 X-purgate-type: clean X-purgate-size: 6230 On Tue, 4 Aug 2026 at 10:27, Frediano Ziglio wrote:=0A= > On Tue, 4 Aug 2026 at 10:15, Teddy Astie wrote:= =0A= >>=0A= >> Le 03/08/2026 =E0 19:23, Marcus Granado a =E9crit :=0A= >>> simplify to reusing PAGE_DATA and spending one octet of its reserved wo= rd=0A= >>> as follows:=0A= >>>=0A= >>>=0A= >>> 0 1 2 3 4 5 6 7 octet=0A= >>> +-----------------------+-----+-------------------+=0A= >>> | count (C) | comp| (reserved) |=0A= >>> +-----------------------+-----+-------------------+=0A= >>> | pfn[0] |=0A= >>> +-------------------------------------------------+=0A= >>> ...=0A= >>> +-------------------------------------------------+=0A= >>> | pfn[C-1] |=0A= >>> +-------------------------------------------------+=0A= >>> | page_data[0..N-1] if comp =3D=3D 0 |=0A= >>> | or page_cdata if comp !=3D 0 |=0A= >>> +-------------------------------------------------+=0A= >>>=0A= >>> with two new entries in the field table:=0A= >>>=0A= >>> comp Compression algorithm applied to the page contents. 0=0A= >>> means none, and the record is exactly as it is today. 1=0A= >>> means LZ4 block format. Other values are reserved for=0A= >>> other future formats like ZSTD etc. A comp !=3D 0 can only= =0A= >>> be emitted if 0 < len(page_cdata) < N * page_size. An=0A= >>> unknown comp must cause the receiver to fail with a=0A= >>> "Compression algorithm not handled" error.=0A= >>>=0A= >>> page_cdata Present instead of page_data when comp is non-zero. A=0A= >>> single compressed object holding the concatenation of the= =0A= >>> N page_data entries. The receiver must verify that=0A= >>> 0 < count <=3D MAX_BATCH_SIZE.=0A= >>>=0A= >>>=0A= >>> Teddy, I hope this format covers your points: it's no longer LZ4 specif= ic,=0A= >>> the inline clen inconsistency in libxenguest record disappears, it's on= e=0A= >>> block over an immutable copy of the batch instead of one per page, the= =0A= >>> decompressed size is known up front, and the allocation derived from co= unt=0A= >>> is bounded on the receiver.=0A= >>>=0A= >>=0A= >> Looks good to me.=0A= >>=0A= >>> On Wed, 22 Jul 2026 at 20:42, Frediano Ziglio wrot= e:=0A= >>>> Don't we need to bump the version number while we add a new mandatory= =0A= >>>> record?=0A= >>>=0A= >>> I believe we may avoid having to do a version bump if we adopt the prop= erty=0A= >>> that 0 < len(page_cdata) < N * page_size when comp !=3D 0, as in this c= ase=0A= >>> the compressed data sent to an old receiver would fail in handle_page_d= ata()=0A= >>> with "PAGE_DATA record wrong size". Bumping the version would make=0A= >>> uncompressed migrations fail if they are sent to old receivers that als= o=0A= >>> understand uncompressed migration, so avoiding if possible would be goo= d.=0A= >>> The spec says migration tools "shall always save images using version V= ",=0A= >>> so it doesn't seem like we could bump the version only when compression= is=0A= >>> on.=0A= =0A= =0A= Thanks. I will take the discussion so far as the record format above being= =0A= agreed, so the only open point is how it is carried.=0A= =0A= >> The specification says=0A= >>=0A= >> > Padding and reserved fields are set to zero on save and must be=0A= >> ignored during restore.=0A= >>=0A= >> Which is not really going to help if we add a new field that matters on= =0A= >> how the content is organized.=0A= =0A= Agreed that the sentence as it stands does not cover it, but I think that= =0A= is a documentation problem rather than a format problem: once the octet is= =0A= given a meaning by the specification it is no longer a reserved field, so= =0A= the rule stops applying to it. The v2 spec patch would define comp in the= =0A= PAGE_DATA field table alongside count and pfn, and leave the remaining=0A= three octets reserved and required to be zero.=0A= =0A= To make the compatibility argument rest on the specification rather than on= =0A= one implementation, I would also add these rules to it in the same patch:= =0A= =0A= * a saver may only emit comp !=3D 0 when 0 < len(page_cdata) < N * page_siz= e=0A= * a restoring side must reject a PAGE_DATA record whose length is not=0A= exactly sizeof(hdr) + C * 8 + N * page_size when comp =3D=3D 0=0A= * a restoring side must reject a record with count > MAX_BATCH_SIZE, and=0A= must fail on a comp value it does not implement=0A= =0A= The second is what handle_page_data() already does today, so writing it=0A= down in the specification is easy and turns the PAGE_DATA argument below=0A= into a guarantee rather than an observation about the current code.=0A= =0A= > Yes, there's no check for "_res1" being 0, however there's this check:=0A= > if ( rec->length !=3D (sizeof(*pages) + ...=0A= > so, as long as we require that the compressed data is less than the=0A= > uncompressed one (we should) it's fine.=0A= =0A= > Not strong but if I could vote I would just use part of "_res1" as=0A= > proposed.=0A= =0A= I would vote the same way. To be explicit about it: an old receiver=0A= will reject a compressed record through the length check rather than=0A= through the mandatory record rule, so the diagnostic is "PAGE_DATA record= =0A= wrong size" rather than one naming the unsupported compression. I think=0A= that is an acceptable price for not adding a record type, given the strict= =0A= inequality above makes the rejection guaranteed rather than incidental.=0A= =0A= Andrew, Roger, the one open point is whether to carry this in a PAGE_DATA= =0A= reserved octet or in a separate PAGE_DATA_COMPRESSED mandatory record.=0A= Unless a maintainer prefers the latter, I will implement v2 with the comp= =0A= octet in PAGE_DATA and the three rules above.=0A= =0A= Marcus=0A= =0A= From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:38:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 13:38:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382167.1625535 (Exim 4.92) (envelope-from ) id 1wrFLp-0008GG-RU; Tue, 04 Aug 2026 13:38:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382167.1625535; Tue, 04 Aug 2026 13:38:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFLp-0008G9-Ny; Tue, 04 Aug 2026 13:38:37 +0000 Received: by outflank-mailman (input) for mailman id 1382167; Tue, 04 Aug 2026 13:38:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFLn-0008G3-W7 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 13:38:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrFLm-00FOA0-U1 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:38:35 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71eb54-2eae-0a2a0a5409dd-0a2a450ac004-10 for ; Tue, 04 Aug 2026 15:38:34 +0200 Received: from [52.101.85.5] (helo=BYAPR05CU005.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71eb58-f2d2-0a2a450a0019-346555052edd-3 for ; Tue, 04 Aug 2026 15:38:33 +0200 Received: from PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) by CH2PR12MB4136.namprd12.prod.outlook.com (2603:10b6:610:a4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Tue, 4 Aug 2026 13:38:24 +0000 Received: from PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::ce69:cfae:774d:a65c]) by PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::ce69:cfae:774d:a65c%5]) with mapi id 15.21.0270.017; Tue, 4 Aug 2026 13:38:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r96iwnW/WdZ0/lPjKFvwKw53/13qLfA16D1uNcB2DA0clOWwAeWTPfFnfjrCWtAawlPifegi/Gk/O2ayEk1eejGP05KurD/x0Qzl/qgbxapFcQLJSuVd+F4UgeWYGT5buh1V9peObL1naEzQ8xEsepGmFWLYVeMEbJXgJPAjb+mGtHgUVioCh78OU+vKe0R8nWjmTmccxh8zcHU3kUPfhVSNhkjwc2UMlvW6DDgSw2JyAQZBewuCpqJr9bmHmejs5PkY2LmrLsBl0MifGE7Kj7o5+QFeimAc4/StyHcIk8jHDL4Ww0GKcD+M7kq85++0zdai8zILvBi9sZeOi+3Iow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6OiQ8taLrghruyRg4YmHgzFRo6wnNdajhJXdo46Fzaw=; b=gNY3covjJM0tESQcEQF6Gd6SDeI23uRb0Wxce+6EBk1c6KAS3ztIFMrZUp1uYFUMiA2OqLPu5xe2sPxkswv8EpEx1DltdihiPU53+/RRVOaWl38ZxdFrOflQQYo34GCUJ/D5BkxnyB0IiF6DuBNvaa1Eb/m5cuxn12cdqj8MVcnVXoVLuCEPqi923tsjcr0pwLZpDkGmE9DazKGXXIrY2vGO2w3VhQfw35vYW9Ic5UD2zuwlewQDQq8pTHpN7EDbiQADaZWYKiYZo114YAWhQBfyQ4FU+x08L14TFA4WAlN20en14x89bkXvVH3EFXpmuT36oEFjOwNW7J/uwb3TfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6OiQ8taLrghruyRg4YmHgzFRo6wnNdajhJXdo46Fzaw=; b=jaCEfpeiA5AbrFWyKXDrHdyR9N++a+e8dvGtDEniOIwhVfg2/+TnZfgftFG7O9yPye7Pr6FH64RIN8d8HHceYZcWLw0gUjLEL9blul6pH6DLQ6s+ysexnP00vkrW+FfUsBDkNkN6/1A64ksqP7uXQVmekpaEfS8cALyAxuVWVIc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <1e65ec27-372e-45bc-8c44-99ca2bc97a30@amd.com> Date: Tue, 4 Aug 2026 15:38:09 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/gem: Move pages_to_sg helper into drm_gem.c To: =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , Alex Deucher , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas Stach , Russell King , Christian Gmeiner , Jianmin Lv , Qianhai Wu , Huacai Chen , Mingcong Bai , Xi Ruoyao , Icenowy Zheng , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Lyude Paul , Danilo Krummrich , Boris Brezillon , Steven Price , Liviu Dudau , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Zack Rusin , Broadcom internal kernel review list , Matthew Brost , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Oleksandr Andrushchenko , Sumit Semwal Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org References: <20260724-get_pages-v1-1-b10e5d65628e@collabora.com> Content-Language: en-US From: =?UTF-8?Q?Christian_K=C3=B6nig?= In-Reply-To: <20260724-get_pages-v1-1-b10e5d65628e@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b8::17) To PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB5685:EE_|CH2PR12MB4136:EE_ X-MS-Office365-Filtering-Correlation-Id: 0147a598-a9d1-4a3b-efc5-08def22da7f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|366016|1800799024|921020|56012099006|10067099003|11063799006|5023799004|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: R1TpWk3vilOh0hB5JVbEo/bifnhNrQ8r79onpBBFKV5TcudcA8OnR2sxyj8OQ/Ge2XchKLsxXVpGO2VKlOdbQC3xNPfxJrHEUvhVDbXGbgB+yFOZQZWaJGVO8NLJaw3+Ke28xn1g9vEcWtBGD99stLP92Z5wS3LCjN56h79mEQ41m5XHg6ZY84myeGhgQrblxG2naiIsfrAw/5R3o1kmKTsAOstxaGLisuwl91I59F44nfXAiSskpI2EzCcvQES64hh86SJ0dCMz2LEFb+LU7hiLTyejEq5ui3od9Mq5ovBFocOVGneHOppuF7rdsyMl6kYCXvrFTVm6gxXXgizuKzHOu+peq/6EJFUyIf5042AhtpA64WD6ANFeXWz1WqDn83N+Ef1D2eH0Ful/czzXIi6rFVarIb13NEbHQS7C7mMdLDLsNZDtoz5IYiCsP9Vg7aCuG8tl24RUuRG8Ebw73XA/700jGjNdNr1cGrakyi46FplZhJrmq17+jBMKKjP1tTF+nVSfJbF6Xmv3n3i1d5ajgYi4ItYJdpQgZ/RQIndAK7fGB/ryj/9QZgKuqyDw0qS9sbOdbirG0RSVxyCWKVBKiTz7FuPnRFvmYhYw8oGmAORzpz6tosLWESIClimLvTavkVGNilMdMvwawP1UU24o8JQ8s6tISyoTWK7i9l2y0piUv4bV3hbch8AxxVLvpWgosni7vtZk/PDYvJHjcA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB5685.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(366016)(1800799024)(921020)(56012099006)(10067099003)(11063799006)(5023799004)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djEyZXZZVWxvNHJOcXYyYlQzRWVKTW9naGp2VDZwNmdrQW96RENpc25SejR0?= =?utf-8?B?N1YzQWpJS1djMU9CUmNlZTUyenFZaDArMnpmV1BwS1p2c2xsTEZaemxzSmZy?= =?utf-8?B?RHgrMm1DNjZBS2xOQzhhR0M3Z1FLY0E1b3IrYVZaWFU4R0srMzF1UnM0dVdT?= =?utf-8?B?R2loT05LODUzaVVObVpJZ1hHNlNRLzNiTXp0T21XaXhjeTBLc1lIYVo5WWhr?= =?utf-8?B?dzVNUU5JMXhNdU01cGhFamFXUEFUSFg3djNCTEpGcXozMmdrbzFoV1VOOEoz?= =?utf-8?B?YUR1KytCUFJpaDVOUGFtREVRS1dvbit4QjQ1SkthSUtnTlBDSlR4cmlTbHNt?= =?utf-8?B?R2piMHFhcmE3RGhBYlBjM2RYN0RNUXpiN2RNWnJZSWF1dGZ6UjBNMG1MeTU3?= =?utf-8?B?cXdrbTZObHd6ZUxmbElqdXdTZzFNY2lxdU1KVlB4NDBNeTNCWEZKaTJaRCtJ?= =?utf-8?B?ZGJxTDV1cjN5SmRiOFV0OW1pdUkyVHFNVjc1bGZ2eDVmQVNrczhJUTU3ejdT?= =?utf-8?B?RDNvTExUWEhIS05hMUZ4Mm95WE9LcXNiTFNYY3lkNUxKWGFxRGlPRk94cXpy?= =?utf-8?B?a0F1dEp4Znp6c05BRjNCSTk1dHRmMTIweTBPZU1KbkcwTGFnbVpBWXkzcmJC?= =?utf-8?B?NnlyS3RCd01uN3VpOGErUiszME9Qem42N3d3OGtjbmhLUzRlSUxWTW8rM2Ry?= =?utf-8?B?bkIzZU9BZXg1VGkwRzNnR3lWNmRFZGc1VjZyemltWUExTmZlUllBYzRHM0FO?= =?utf-8?B?NWFCbUxRVm5BdWo0bW5KTGZ1TUVBWTEvSzM0d0dlS1BXY0lwUGdhcWFFVm5J?= =?utf-8?B?eVFFYXkyTTNkUEx4bkp5TExQSEdVd0U0T3dZWG5rcnZySzYvc3NJTmhaVktp?= =?utf-8?B?cUlXUFc4ZUt1aW8wS25NTVdyQnZMVVd2U0RTYUhYRUdBU010RkkxVnZuMENC?= =?utf-8?B?WFc5Y1d6UUxMdnUzb0hTdUZUQmRUQXdsMVZObEE0Sk9TeUFiYVI2cGhXcTZU?= =?utf-8?B?SzdjUEpyYWxLakt2a2JDamk3L2ZweWVYTWRSTmp0eHdFb0NPbHU2NXIzRExO?= =?utf-8?B?a3pkcEtNNitJa3oyYU9xOGJLTldnQWNqOW4xYmlweUdpVFRyQVg1NDlzWFNy?= =?utf-8?B?SzBweE1Na3JHbkdMVDlVVFhxeWFsUFovemFLYkQ4cU5tdmNuV3liU2xrTW5l?= =?utf-8?B?REVxSTU0MzdkRmtOUVA2Q1kvTzhjRlhlbjMxSnNtMGZWcXJaMVdOVHVybVlH?= =?utf-8?B?VE5jVVQydHpXWVZUdlo3NEVHa29JTUNTMEt0ekd3T3hka2FtTkhYQklJSlVR?= =?utf-8?B?cHRoMHFOYlNzdW1HK2pOb0tOd0c1VzJiMEdLNWFHQWRmK1FpR0hOR2p6Unpy?= =?utf-8?B?c3dTcXB1N3VGb3lGcjJtWmFwcmpYWGhzeVVMdFpxUXJrZUtyOEhIU2NYcVRj?= =?utf-8?B?WnQ4K1BHV1Yra0pnVHpKdjNGWHdBMEgwZ1NDdlovVm5MTklYVjRpY051VXNL?= =?utf-8?B?c0NNM2orVmZnb1MweHROd3paMDQ0ZEl0MjY1ODNRWkJmVGw2Vk0rTlN1MnA2?= =?utf-8?B?ZVpwd2d0Sk55bzYvMTlybHVLcFJldVZwQ3JHQy9iK0NkbERLcFhVaDh1Wk40?= =?utf-8?B?L2xoYmVzTjl6bk1QWEp4dFROQzQ0RDI0Rml3ZHJTdStabE1DUlphR0xvUUZI?= =?utf-8?B?dG16Z0laT0pvNTBaL0NVWWw1djFqVnUzTmQzMDJDYnRIYzJPOXFjbmtrbk42?= =?utf-8?B?K0QwTUdqakp2b0JFRldycWNYbDNSRVg3Z0srQ3NoNHBEZHBwUzlMdkgzSHVx?= =?utf-8?B?b1JWekJzd0lhRGFiM2JKNlBtcHUyTFoxWDJjNWsvcGRGdDVNYkNlcXVTbjh0?= =?utf-8?B?aXJZWHFhbXl5ZDB4UEFZbEsycGJXbEluVFMxL2ZCWENPS1AyN28zdTVKYUJO?= =?utf-8?B?SitocldLUlpjSmZMdVZXZDRKSjBLdnkxVTlzQVVvN1JuOWNiZzhmU1JGR0du?= =?utf-8?B?N1o3NGdERUlac01teFppK2YyVjRJRGJwazl4aTg4SmFxVHdjL051T25ZNGpp?= =?utf-8?B?ZHd2THBCZUtjTnBIdFJWMHhweExBeGQ1Q2dOV3dBb2tiSlJ3UW9pR1pwb2lo?= =?utf-8?B?S00vSnUvZlpQbmVXNEhkdUVnVUQxK2F0V2tVRFVIL2IwV2NvcG5WeDZrY3Rm?= =?utf-8?B?U3J3MlROYTR2b3RubUtUR1dSTEg4SkNNVHlLaW5iZ0ZhL3pUSjJtRllSajlP?= =?utf-8?B?dWFvNkFlYlpqUTdmMUVVT3hjNlF4UTBjMDYwR3VJbmFFdURHVEJwZWppejB6?= =?utf-8?Q?N5jlV4ACThTJGiJhD/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0147a598-a9d1-4a3b-efc5-08def22da7f1 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 13:38:24.2839 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T1we7gz+msqYs5BOViZcVvxzazHnyiEcfi4bcJzi5rasJ0vTAGg2bjyYN9IeDyOl X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4136 X-purgate-ID: tlsNG-4011c0/1785850714-59BC0CFC-E6B74832/0/0 X-purgate-type: clean X-purgate-size: 18956 On 7/24/26 14:08, Adrián Larumbe wrote: > None of the semantics of the function tell of it being a PRIME-exclusive > entry point. In fact, most drivers seem to be using it to translate a list > of pages into an sg table that can be used for GPU mapping later on, rather > than just for sharing an object's pages with another driver. > > Move it across files and rename accordingly. > > Signed-off-by: Adrián Larumbe > --- > drm_prime_pages_to_sg() has no real dependency on PRIME/dma-buf interfaces. > It is a generic helper that converts a page array into a scatter/gather > table via dma_map_sg_attrs. Nothing in its implementation touches struct > dma_buf or import/export logic. It is correct that this helper is not DMA-buf dependent, but DMA-buf should be the only case when a DRM driver needs to convert an array of pages into an SG table. The background is that we want to discourage people from using SG tables because it was a rather bad design choice to have pages mangled with the DMA addresses in one structure in the first place. So question is why do you want to do this? Regards, Christian. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 6 ++--- > drivers/gpu/drm/drm_gem.c | 35 ++++++++++++++++++++++++++ > drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- > drivers/gpu/drm/drm_prime.c | 38 ----------------------------- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 +-- > drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 ++- > drivers/gpu/drm/loongson/lsdc_gem.c | 3 +-- > drivers/gpu/drm/msm/msm_gem.c | 2 +- > drivers/gpu/drm/msm/msm_gem_prime.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +-- > drivers/gpu/drm/panthor/panthor_gem.c | 6 ++--- > drivers/gpu/drm/radeon/radeon_prime.c | 5 ++-- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 ++--- > drivers/gpu/drm/tegra/gem.c | 4 +-- > drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 4 +-- > drivers/gpu/drm/xe/xe_dma_buf.c | 6 ++--- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- > include/drm/drm_gem.h | 5 +++- > include/drm/drm_prime.h | 2 -- > 19 files changed, 68 insertions(+), 70 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c > index b33c300e26e2..c9a98aec7eb6 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c > @@ -203,9 +203,9 @@ static struct sg_table *amdgpu_dma_buf_map(struct dma_buf_attachment *attach, > > switch (bo->tbo.resource->mem_type) { > case TTM_PL_TT: > - sgt = drm_prime_pages_to_sg(obj->dev, > - bo->tbo.ttm->pages, > - bo->tbo.ttm->num_pages); > + sgt = drm_pages_to_sg(obj->dev, > + bo->tbo.ttm->pages, > + bo->tbo.ttm->num_pages); > if (IS_ERR(sgt)) > return sgt; > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index 018df97d590d..22c8a3b5f667 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -780,6 +780,41 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages, > } > EXPORT_SYMBOL(drm_gem_put_pages); > > +/** > + * drm_pages_to_sg - converts a page array into an sg list > + * @dev: DRM device > + * @pages: pointer to the array of page pointers to convert > + * @nr_pages: length of the page vector > + * > + * This helper creates an sg table object from a set of pages. > + * This is useful for implementing &drm_gem_object_funcs.get_sg_table. > + */ > +struct sg_table *drm_pages_to_sg(struct drm_device *dev, > + struct page **pages, unsigned int nr_pages) > +{ > + struct sg_table *sg; > + size_t max_segment = 0; > + int err; > + > + sg = kmalloc_obj(struct sg_table); > + if (!sg) > + return ERR_PTR(-ENOMEM); > + > + if (dev) > + max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev)); > + if (max_segment == 0) > + max_segment = UINT_MAX; > + err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0, > + (unsigned long)nr_pages << PAGE_SHIFT, > + max_segment, GFP_KERNEL); > + if (err) { > + kfree(sg); > + sg = ERR_PTR(err); > + } > + return sg; > +} > +EXPORT_SYMBOL(drm_pages_to_sg); > + > static int objects_lookup(struct drm_file *filp, u32 *handle, int count, > struct drm_gem_object **objs) > { > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c > index 22ec52e2ffb8..144d088a477f 100644 > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > @@ -825,7 +825,7 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem) > > drm_WARN_ON(obj->dev, drm_gem_is_imported(obj)); > > - return drm_prime_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT); > + return drm_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT); > } > EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table); > > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c > index 9b44c78cd77f..54539a8929c1 100644 > --- a/drivers/gpu/drm/drm_prime.c > +++ b/drivers/gpu/drm/drm_prime.c > @@ -835,44 +835,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = { > .vunmap = drm_gem_dmabuf_vunmap, > }; > > -/** > - * drm_prime_pages_to_sg - converts a page array into an sg list > - * @dev: DRM device > - * @pages: pointer to the array of page pointers to convert > - * @nr_pages: length of the page vector > - * > - * This helper creates an sg table object from a set of pages > - * the driver is responsible for mapping the pages into the > - * importers address space for use with dma_buf itself. > - * > - * This is useful for implementing &drm_gem_object_funcs.get_sg_table. > - */ > -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev, > - struct page **pages, unsigned int nr_pages) > -{ > - struct sg_table *sg; > - size_t max_segment = 0; > - int err; > - > - sg = kmalloc_obj(struct sg_table); > - if (!sg) > - return ERR_PTR(-ENOMEM); > - > - if (dev) > - max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev)); > - if (max_segment == 0) > - max_segment = UINT_MAX; > - err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0, > - (unsigned long)nr_pages << PAGE_SHIFT, > - max_segment, GFP_KERNEL); > - if (err) { > - kfree(sg); > - sg = ERR_PTR(err); > - } > - return sg; > -} > -EXPORT_SYMBOL(drm_prime_pages_to_sg); > - > /** > * drm_prime_get_contiguous_size - returns the contiguous size of the buffer > * @sgt: sg_table describing the buffer to check > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > index b0436a1e103f..a8e8614f8210 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > @@ -3,7 +3,6 @@ > * Copyright (C) 2015-2018 Etnaviv Project > */ > > -#include > #include > #include > #include > @@ -104,7 +103,7 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj) > unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT; > struct sg_table *sgt; > > - sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages); > + sgt = drm_pages_to_sg(dev, etnaviv_obj->pages, npages); > if (IS_ERR(sgt)) { > dev_err(dev->dev, "failed to allocate sgt: %ld\n", > PTR_ERR(sgt)); > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > index 6757ae6ec304..f44484325ddb 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c > @@ -3,6 +3,7 @@ > * Copyright (C) 2014-2018 Etnaviv Project > */ > > +#include > #include > #include > #include > @@ -22,7 +23,7 @@ struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj) > if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */ > return ERR_PTR(-EINVAL); > > - return drm_prime_pages_to_sg(obj->dev, etnaviv_obj->pages, npages); > + return drm_pages_to_sg(obj->dev, etnaviv_obj->pages, npages); > } > > int etnaviv_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map) > diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c > index 2fb03487c983..37160228244c 100644 > --- a/drivers/gpu/drm/loongson/lsdc_gem.c > +++ b/drivers/gpu/drm/loongson/lsdc_gem.c > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > #include > > #include "lsdc_drv.h" > @@ -51,7 +50,7 @@ static struct sg_table *lsdc_gem_prime_get_sg_table(struct drm_gem_object *obj) > return ERR_PTR(-ENOMEM); > } > > - return drm_prime_pages_to_sg(obj->dev, tt->pages, tt->num_pages); > + return drm_pages_to_sg(obj->dev, tt->pages, tt->num_pages); > } > > static void lsdc_gem_object_free(struct drm_gem_object *obj) > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index efd3d3c9a449..7e3418290c22 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -207,7 +207,7 @@ static struct page **get_pages(struct drm_gem_object *obj) > > msm_obj->pages = p; > > - msm_obj->sgt = drm_prime_pages_to_sg(obj->dev, p, npages); > + msm_obj->sgt = drm_pages_to_sg(obj->dev, p, npages); > if (IS_ERR(msm_obj->sgt)) { > void *ptr = ERR_CAST(msm_obj->sgt); > > diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c > index 036d34c674d9..d25393a9e549 100644 > --- a/drivers/gpu/drm/msm/msm_gem_prime.c > +++ b/drivers/gpu/drm/msm/msm_gem_prime.c > @@ -23,7 +23,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj) > if (WARN_ON(!msm_obj->pages)) /* should have already pinned! */ > return ERR_PTR(-ENOMEM); > > - return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages); > + return drm_pages_to_sg(obj->dev, msm_obj->pages, npages); > } > > int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map) > diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c > index caab60fc62f6..b95f2f07df74 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_prime.c > +++ b/drivers/gpu/drm/nouveau/nouveau_prime.c > @@ -32,8 +32,8 @@ struct sg_table *nouveau_gem_prime_get_sg_table(struct drm_gem_object *obj) > { > struct nouveau_bo *nvbo = nouveau_gem_object(obj); > > - return drm_prime_pages_to_sg(obj->dev, nvbo->bo.ttm->pages, > - nvbo->bo.ttm->num_pages); > + return drm_pages_to_sg(obj->dev, nvbo->bo.ttm->pages, > + nvbo->bo.ttm->num_pages); > } > > struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev, > diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c > index 9855df738194..ec530d254fa4 100644 > --- a/drivers/gpu/drm/panthor/panthor_gem.c > +++ b/drivers/gpu/drm/panthor/panthor_gem.c > @@ -321,8 +321,8 @@ panthor_gem_dev_map_get_sgt_locked(struct panthor_gem_object *bo) > if (ret) > return ERR_PTR(ret); > > - sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages, > - bo->base.size >> PAGE_SHIFT); > + sgt = drm_pages_to_sg(bo->base.dev, bo->backing.pages, > + bo->base.size >> PAGE_SHIFT); > if (IS_ERR(sgt)) > return sgt; > > @@ -702,7 +702,7 @@ static struct sg_table *panthor_gem_get_sg_table(struct drm_gem_object *obj) > drm_WARN_ON_ONCE(obj->dev, !bo->backing.pages); > drm_WARN_ON_ONCE(obj->dev, !refcount_read(&bo->backing.pin_count)); > > - return drm_prime_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT); > + return drm_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT); > } > > static int panthor_gem_vmap_locked(struct drm_gem_object *obj, > diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c > index a77881f035e7..4cfc4282a59c 100644 > --- a/drivers/gpu/drm/radeon/radeon_prime.c > +++ b/drivers/gpu/drm/radeon/radeon_prime.c > @@ -26,6 +26,7 @@ > > #include > > +#include > #include > #include > > @@ -38,8 +39,8 @@ struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj) > { > struct radeon_bo *bo = gem_to_radeon_bo(obj); > > - return drm_prime_pages_to_sg(obj->dev, bo->tbo.ttm->pages, > - bo->tbo.ttm->num_pages); > + return drm_pages_to_sg(obj->dev, bo->tbo.ttm->pages, > + bo->tbo.ttm->num_pages); > } > > struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev, > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > index b188539dca0b..7897da0becf4 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -89,8 +89,8 @@ static int rockchip_gem_get_pages(struct rockchip_gem_object *rk_obj) > > rk_obj->num_pages = rk_obj->base.size >> PAGE_SHIFT; > > - rk_obj->sgt = drm_prime_pages_to_sg(rk_obj->base.dev, > - rk_obj->pages, rk_obj->num_pages); > + rk_obj->sgt = drm_pages_to_sg(rk_obj->base.dev, > + rk_obj->pages, rk_obj->num_pages); > if (IS_ERR(rk_obj->sgt)) { > ret = PTR_ERR(rk_obj->sgt); > goto err_put_pages; > @@ -432,7 +432,7 @@ struct sg_table *rockchip_gem_prime_get_sg_table(struct drm_gem_object *obj) > int ret; > > if (rk_obj->pages) > - return drm_prime_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages); > + return drm_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages); > > sgt = kzalloc_obj(*sgt); > if (!sgt) > diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c > index 436394e04812..701af672b4e5 100644 > --- a/drivers/gpu/drm/tegra/gem.c > +++ b/drivers/gpu/drm/tegra/gem.c > @@ -17,7 +17,7 @@ > > #include > #include > -#include > +#include > > #include "drm.h" > #include "gem.h" > @@ -352,7 +352,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo) > > bo->num_pages = bo->gem.size >> PAGE_SHIFT; > > - bo->sgt = drm_prime_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages); > + bo->sgt = drm_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages); > if (IS_ERR(bo->sgt)) { > err = PTR_ERR(bo->sgt); > goto put_pages; > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c > index 39f8c46550c2..c9e7f2e3668c 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c > @@ -28,7 +28,7 @@ > #include "vmwgfx_bo.h" > #include "vmwgfx_drv.h" > > -#include "drm/drm_prime.h" > +#include "drm/drm_gem.h" > #include "drm/drm_gem_ttm_helper.h" > > #include > @@ -76,7 +76,7 @@ static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object *obj) > if (vmw_tt->vsgt.sgt) > return vmw_tt->vsgt.sgt; > > - return drm_prime_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages); > + return drm_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages); > } > > static int vmw_gem_vmap(struct drm_gem_object *obj, struct iosys_map *map) > diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c > index 8a920e58245c..f0fe80706b79 100644 > --- a/drivers/gpu/drm/xe/xe_dma_buf.c > +++ b/drivers/gpu/drm/xe/xe_dma_buf.c > @@ -118,9 +118,9 @@ static struct sg_table *xe_dma_buf_map(struct dma_buf_attachment *attach, > > switch (bo->ttm.resource->mem_type) { > case XE_PL_TT: > - sgt = drm_prime_pages_to_sg(obj->dev, > - bo->ttm.ttm->pages, > - obj->size >> PAGE_SHIFT); > + sgt = drm_pages_to_sg(obj->dev, > + bo->ttm.ttm->pages, > + obj->size >> PAGE_SHIFT); > if (IS_ERR(sgt)) > return sgt; > > diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c > index eec4c1da3f9e..a4a7c7f2c91c 100644 > --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c > +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c > @@ -236,7 +236,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj) > if (!xen_obj->pages) > return ERR_PTR(-ENOMEM); > > - return drm_prime_pages_to_sg(gem_obj->dev, > + return drm_pages_to_sg(gem_obj->dev, > xen_obj->pages, xen_obj->num_pages); > } > > diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h > index 885244e375d3..7b9cc6335689 100644 > --- a/include/drm/drm_gem.h > +++ b/include/drm/drm_gem.h > @@ -155,7 +155,7 @@ struct drm_gem_object_funcs { > * here cannot be used for sg tables pointing at driver private memory > * ranges. > * > - * See also drm_prime_pages_to_sg(). > + * See also drm_pages_to_sg(). > */ > struct sg_table *(*get_sg_table)(struct drm_gem_object *obj); > > @@ -589,6 +589,9 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj); > void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages, > bool dirty, bool accessed); > > +struct sg_table *drm_pages_to_sg(struct drm_device *dev, > + struct page **pages, unsigned int nr_pages); > + > void drm_gem_lock(struct drm_gem_object *obj); > void drm_gem_unlock(struct drm_gem_object *obj); > > diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h > index f50f862f0d8b..603e16a40ae7 100644 > --- a/include/drm/drm_prime.h > +++ b/include/drm/drm_prime.h > @@ -92,8 +92,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map); > int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma); > int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma); > > -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev, > - struct page **pages, unsigned int nr_pages); > struct dma_buf *drm_gem_prime_export(struct drm_gem_object *obj, > int flags); > > > --- > base-commit: 48dd37d1fef33fbf42f1d6887c61e242fd21d00d > change-id: 20260724-get_pages-e2e91c53eaa3 > > Best regards, > -- > Adrián Larumbe > From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:41:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 13:41:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382174.1625544 (Exim 4.92) (envelope-from ) id 1wrFO7-0001JG-6C; Tue, 04 Aug 2026 13:40:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382174.1625544; Tue, 04 Aug 2026 13:40:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFO7-0001J9-3T; Tue, 04 Aug 2026 13:40:59 +0000 Received: by outflank-mailman (input) for mailman id 1382174; Tue, 04 Aug 2026 13:40:57 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFO5-0001J2-DR for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 13:40:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrFO4-00EzIj-AN for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:40:56 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71ebdc-5cb7-0a2a0a5109dd-0a2a4507af8a-44 for ; Tue, 04 Aug 2026 15:40:56 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71ebe7-b4ea-0a2a45070019-d1558029e403-3 for ; Tue, 04 Aug 2026 15:40:56 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso22305565e9.0 for ; Tue, 04 Aug 2026 06:40:56 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fc6f16sm159359965e9.2.2026.08.04.06.40.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 06:40:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785850855; x=1786455655; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OJJQReJUi7fUzVzzuopy47u3RxzqcfK1FXi07EBFiFs=; b=FzxPh1Hb5Zc+wY9VXIP0tz/nNr41bOv0/pEnbRWvFou+uHatSd3K2TspxcTqxL4yco WJ66jnjO7EfbdH6zKB1Hgx22lYDBYO+LQYKdcGwjzMaW6LhOBYqKZkHiPjoyppHpZvzZ TV7N5vqUuodoS9yIHh+S+oYSJj8cMEE9X730LYcPe1cysKYExCaBw6oTPgXqbfB/tAlx TG+/yiEP2DFPkvWhLK+bFuPwG8Sp+GqeIRi9eVdCdwWXVmq47wtlJj2or1ahaT+7l+Fq Np2k3N+wFYtXpc8RK+DhMFz/opAWa8sx29NBeDRMHD5IA5uJe5Xp4wS+tUTRqzYTlNqK fyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785850855; x=1786455655; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OJJQReJUi7fUzVzzuopy47u3RxzqcfK1FXi07EBFiFs=; b=IwQ9ss10WD4Xfid07yrdpzX6Ej8bCpSv4x4VsyFbz/A+Uh9ARjFtbZSAMOnnQwuJWQ Cs1vMTKfl+1Ng6n9M+4ETz07xwhlqZVqKU5T1QrzLdaHsCDRNbbKimTCKctNMZMRoIDL VnQWpKAorY17WXPO4fqzAktk8eFTBVSn4ESp160lyql5P6xPiU3YsY9dkgENXXrb92A6 eK5SJzjxEKZVCQkppNSw2eofAbSj3JUu2Uhn2HGdCxCi5DK9FAvcixR3ivWllivg9IvQ Qm2P2laX+F6bDzyA4Dflfypx/g0Ru+yWYDL+QCwCUXpCgoCY6PsiKTrzTYep486GHPRa Lycg== X-Forwarded-Encrypted: i=1; AHgh+RqjJBSr9eqVphtdrOaZyZTjNIjaQ6cvvC2XKEWKHBF0OUhrGy3BgIq1LGq8U8bE8StTwDEKByc8zNs=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzw0ZbPpfkovqGlqDyXNNpJfV6IEHSKGkD8CXJV7cjWLwgQJGLa ocJ0tA1KP3DkFHhLeUeeJ4tTnJGl3liKnRbdIXkTYM+z/YfD43jbkz03aDKtoO7+ow== X-Gm-Gg: AR+sD11LgpZ7BPZjRdnb27UwUQXh4WLsE9q1GR46dRHHEqr9GwQr4rqLhXyph6tx5RX UT79dPUhb1KGBDLIBPabPbUkO+A51hYYdqKgQHz1lOViXbWgLEofJE6gy6l7e4YuLC3utehoebj 9VDw3oWyzS8yxB+usZMMVIZKGimDSFSE4svBjlSCYAiIb7/9Ey3CDVnYpAO+X/biuAzLEs2RDE/ gx8vR5ROowwlDITAT4z6eP2w7p46jYlxX3jRUabnsIslyskiahsWBt9/p1ARrZ01lta+9JJa3hr pJCFh7QAKXw2OLIU0h4WUaAL8z7HL7fWUTnFqTb/pBoPzdOB2D0l+C1P7i+U2KJP+FUv9MM570o alpYPiv5hl6pVaPmoXwzdbOmWS/4OrqTRmDb41Ot/i1olss/s8w+m+5WrkNCIW4k05DMsLXDDol bYP+tj7ZCnlmgb8isgcgKCsuzpUs5LuqgoJnuDA1KfNdoSTvjZudCNELc41T5XvHq6fGRaLxGFk cv7TJlBwwqC4XL4jiR664i25GAZrDbNlSmG0RGer2pGB8Vft5ni X-Received: by 2002:a05:600c:840f:b0:495:5fdf:2075 with SMTP id 5b1f17b1804b1-4980c5fa29amr299658695e9.0.1785850852314; Tue, 04 Aug 2026 06:40:52 -0700 (PDT) Message-ID: <2c012213-0fd0-40f8-8806-0096040370aa@suse.com> Date: Tue, 4 Aug 2026 15:40:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] x86: introduce "brk" allocator To: Andrew Cooper Cc: Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <31ba7ff2-a42d-44aa-976c-17fbff44a56f@suse.com> <91bdef16-2da7-49e7-af5a-e395da533330@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <91bdef16-2da7-49e7-af5a-e395da533330@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1785850856-36CDFAE4-6EA4D02B/0/0 X-purgate-type: clean X-purgate-size: 4240 On 30.07.2026 19:59, Andrew Cooper wrote: > On 27/07/2026 11:19 am, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/x86/boot/brk.c > > While brk.c has x86 specifics, I'm not sure it's worthy if being in > boot/, rather than simply in x86/.  It's used until mid way through > __start_xen(). As discussed, I'll move this to common/brk.c right away, abstracting out the x86 specifics. >> @@ -0,0 +1,72 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> + >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> + >> +extern char __brk_start[]; >> +extern const char __bss_end[]; >> + >> +static unsigned long __initdata allocated; >> +static bool __initdata finished; >> + >> +void *__init brk_alloc(size_t size) >> +{ >> + void *ptr = __brk_start + allocated; >> + >> + if ( finished ) >> + return NULL; >> + >> + /* Allocations PAGE_SIZE and up will be page-aligned. */ >> + if ( size >= PAGE_SIZE ) >> + allocated = ROUNDUP(allocated, PAGE_SIZE); >> + >> + allocated += ROUNDUP(size, sizeof(void *)); >> + >> + if ( allocated > __bss_end - __brk_start ) >> + return NULL; > > This means one (or more) subsystem has brk_alloc()'d more than they > reserved. > > While returning NULL is probably the best action, I think a > printk_once() is also warranted. Hmm, yes, just that there's a quirk to work around: The static that printk_once() uses gets in the way of the file getting compiled into brk.init.o. >> + >> + return ptr; >> +} >> + >> +unsigned long __init brk_get_unused_start(void) >> +{ >> + finished = true; > > This doesn't get the unused start.  It also terminates the allocator, > and the name needs to reflect that. brk_cease() then. > But combined with brk_end in the next patch, it's really quite a mess.  > Integrating brk_end properly simplifies this patch too. No, brk_end really is an x86-specific helper variable. I'd like to keep that as it is. >> --- /dev/null >> +++ b/xen/arch/x86/include/asm/brk.h >> @@ -0,0 +1,7 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> + >> +#include >> + >> +void *brk_alloc(size_t size); >> +unsigned long brk_get_unused_start(void); >> +void brk_free_unused(void); > > It's inevitable that brk is going to be used in other architectures, and > none of this is x86 specific. > > This should be xen/include/brk.h right from the outset, even if that's > all we do in the way of making it generic. > > Except, brk_end in patch 2 really needs to live in common/brk.c so it's > probably easier to go in arch-neutral right from the outset and use > "select ARCH_HAS_BRK" or so to allow the arches to opt into using it. > > Furthermore, this header needs some commentary.  To do this nicely, > DEFINE_BRK() needs to be introduced here so the comment makes sense. Sure, I can move introduction of the macro here. Jan > ----- > Early Boot memory allocator. > > Subsystems which conditionally need memory prior to the main heap being > set up should use DEFINE_BRK() to reserve BSS space in Xen. > > During boot, brk_alloc() allocates memory from the reserved space.  Such > allocations are good for the lifetime of Xen.  Subsystems MUST NOT > brk_alloc() more memory than they reserved. > > When the main heap is set up, brk allocations become unavailable.  > Reserved but unallocated space is handed to the main heap, so it doesn't > go to waste. > ----- > > > With just a few sentences, it's now far clearer what brk is and how to > use it. > > >> --- a/xen/arch/x86/xen.lds.S >> +++ b/xen/arch/x86/xen.lds.S >> @@ -321,7 +321,11 @@ SECTIONS >> __bss_start = .; >> *(.bss.page_aligned*) >> PERCPU_BSS >> - *(.bss .bss.*) >> + *(.bss .bss.[a-zA-Z0-9_]*) >> + . = ALIGN(PAGE_SIZE); >> + __brk_start = .; >> + *(.bss..brk.page_aligned*) >> + *(.bss..brk*) >> . = ALIGN(POINTER_ALIGN); > > This looks fine, but if it's becoming common then it wants to be a macro > in xen.lds.h > > ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 13:56:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 13:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382183.1625554 (Exim 4.92) (envelope-from ) id 1wrFcg-0003Sz-Gi; Tue, 04 Aug 2026 13:56:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382183.1625554; Tue, 04 Aug 2026 13:56:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFcg-0003Ss-D9; Tue, 04 Aug 2026 13:56:02 +0000 Received: by outflank-mailman (input) for mailman id 1382183; Tue, 04 Aug 2026 13:56:00 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFce-0003Sm-CX for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 13:56:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrFca-00Box7-1L for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:55:56 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71ef6a-e002-0a2a0a5209dd-0a2a45028796-10 for ; Tue, 04 Aug 2026 15:55:55 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71ef6b-6ca4-0a2a45020019-d155dd2dd0cd-3 for ; Tue, 04 Aug 2026 15:55:55 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4799b3f7c83so3027752f8f.2 for ; Tue, 04 Aug 2026 06:55:55 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41e2484sm45261033f8f.11.2026.08.04.06.55.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 06:55:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785851755; x=1786456555; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9h9+fq6Jp77OyWF1yf/69cNg6J6mI+PxR6Z5EORHM/I=; b=A6DwsTGd+HY+bgcER38rKTb3mqFqy4B1SUT2vBjqc1s7KIBepArPAEuFmHczZJD/c7 Dd5g2TBrnKpGi/F+ljRnIeII4+gwmxoFVkJy3g6gucuKlOyCP/ETCULht0IiUmidG0jR w4nyPinBtSgZ+lmfSF7vNdYsSi49JvdyTpAIWd58hLS3ob/4j0rY2wg1YIpzWEFLjZGY XLKzcQktBgZVYUWwBf5HH+q/JbJB85Sls8Y5BVhyO2JZdyOBS1pVB3QVP2Y42ych/ehB VasmNbstisrQ+FAKwO8T5wOTn3QhbhUpaq6YRlm3lSeDKbyTUiPk6vs57ljVE2Ee8e7T WRfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785851755; x=1786456555; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9h9+fq6Jp77OyWF1yf/69cNg6J6mI+PxR6Z5EORHM/I=; b=TG4K0Mtc0xfoEwnit0Kv6gXkXfGQ57M/72TuL/YmIkmiyT8Gamg/E5FVgFLjWtMuTQ wPxnFQ30EAiEe5HggbtYRcUceGZkRv/wb8Tj9CVhOj7QstW2FWBZXs4jvEatbQJ9P59u N8IrY0p0vUFU6E6sqf6FeARft4nnS2C/DMV+fIBAcdwP9H69PTfkHjbH/p28EY9ElohH NxHBXKpM2G1v7C8dbza0uiIOHTRkYgbvpmlsAt782ZJZ/D/dCNY5O7MKLezfbF5NRSCE 7d/sJeOW8bpXocmNxuW1RSq52r3ytWjKWZ4VwYvMu/G6Q7aPttVRSI2alcF4e/f2qOx6 QP7g== X-Forwarded-Encrypted: i=1; AHgh+Rrwrtpq96DvpN+k7nh0fYx0juU2E7BUNoqBJsxE4ul9IjyJNTewi2VL8XdF3TRrQ555yT3jaCYNP7Y=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxg27Qluu0/SHAXTHKkKClfSP9yGvE7Cb0ItdytH7/7aHAQ3cAx EWrgjIbbwttXxcA9U+SfpOEp4YDP5QdsvggUupdgOjqOQ/S2j5V93ZCecjhFTRungw== X-Gm-Gg: AR+sD13rYj3EYIna8iuXLThwAUzFUUlo9oVEY6J/h0cmEx+GeCqWIXmVo9DSz2nwQFn UJ6hNgwmXlESDdiXIYaH/eh4xqcCIgUYM1YdVHP9QY4Yc+nosbbFbzXUV4mEW/5U6sPcjVdLfz5 yDWV2fL732FHFv9Bef0FOJcdH8P1XlmKr6NrK7xZAfrDHEMnglCCKUV1z3giqLhgdJe2zF9I3oy U1E0q6VSTL06bylr3GZ12mwNDlcr4qFAotHE1Ax66uyYCUW6IWmFw00RREiBA3l5uhP6ajpppMB fCYaYCPIMl58ve4GBpdjzPmqSSmHfgwIH6vjfVthDOruy+ruMP2UnYru+m08tcxRE+0Pb4/NjAp aV0LEPHP0vI1tZKnWXtA5njV5rx6UJTbro5DaShmpNLIjrvU5aE4g0a2igyc40+7AD3zZurioXQ 6MA5F24OShkPvLXCh5uTwr7/ReQOT+/y4dAgyjG4NiAQz5sH8aZ5IknWYVBr1q2/mbGUHLD/e/I c7X2kgTkm77eDSKNJjWL7xVvhZei+IeyjD8i7l5PN+MYdlWRrJu X-Received: by 2002:a05:6000:40e1:b0:47f:8b1f:efa2 with SMTP id ffacd0b85a97d-47fd729e88bmr37834347f8f.8.1785851755310; Tue, 04 Aug 2026 06:55:55 -0700 (PDT) Message-ID: <28d4e98a-2fd2-41fb-9f1c-c5f4768989f9@suse.com> Date: Tue, 4 Aug 2026 15:55:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] radix-tree: drop radix_tree_init_maxindex() To: Andrew Cooper Cc: Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel , "xen-devel@lists.xenproject.org" References: <25cf9c88-7589-4a5d-994d-45f488a3e00b@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1785851755-F0AA52AC-0FF330C8/0/0 X-purgate-type: clean X-purgate-size: 2864 On 04.08.2026 14:58, Andrew Cooper wrote: > On 04/08/2026 1:30 pm, Jan Beulich wrote: >> Radix trees are in principle usable as soon as memory allocation works. >> (Radix trees with only index 0 populated are usable even earlier.) If only >> there wasn't height_to_maxindex[], which is filled only by a pre-SMP >> initcall. The benefit of this array is rather limited - the calculations >> done by __maxindex() can as well be done by radix_tree_maxindex(); the >> overhead isn't all this high. > > It's quite possibly lower overhead.  Some simple integer arithmetic vs a > memory read. > > I think it's worth noting that this was found by UBSAN on a > multi-segment system: > > (XEN) UBSAN: Undefined behaviour in common/radix-tree.c:83:27 > (XEN) index 12 is out of range for type 'long unsigned int [12]' > ... > (XEN) Xen call trace: > (XEN)    [] R common/ubsan/ubsan.c#ubsan_epilogue+0xa/0xd5 > (XEN)    [] F __ubsan_handle_out_of_bounds+0x9d/0xd4 > (XEN)    [] F radix_tree_insert+0x24d/0x570 > (XEN)    [] F drivers/passthrough/pci.c#alloc_pseg+0xc4/0x165 > (XEN)    [] F pci_add_segment+0xc/0x1b > (XEN)    [] F acpi_parse_mcfg+0x29b/0x344 > (XEN)    [] F acpi_table_parse+0x5d/0x92 > (XEN)    [] F acpi_mmcfg_init+0x3a2/0x71d > (XEN)    [] F pci_setup+0x17/0x29 > (XEN)    [] F __start_xen+0x394c/0x4ed8 > (XEN)    [] F __high_start+0xb7/0xb8 Added in. >> Fixes: 21844b0e32e7 ("PCI multi-seg: introduce notion of PCI segments") >> Fixes: 8dc6738dbb3c ("Update radix-tree.[ch] from upstream Linux to gain RCU awareness") >> Reported-by: Andrew Cooper >> Signed-off-by: Jan Beulich > > Reviewed-by: Andrew Cooper Thanks. > All the UBSAN violations are gone. Good. > FWIW, there are still issues on this box, even after the fix: > > (XEN) setup 0000:fe:00.0 for d0 failed (-19) > (XEN) setup 0000:fe:00.1 for d0 failed (-19) > ... > (XEN) setup 0000:ff:19.0 for d0 failed (-19) > (XEN) setup 0000:ff:1a.0 for d0 failed (-19) > (XEN) setup 0001:fe:00.0 for d0 failed (-19) > (XEN) setup 0001:fe:00.1 for d0 failed (-19) > ... > (XEN) setup 0001:ff:19.0 for d0 failed (-19) > (XEN) setup 0001:ff:1a.0 for d0 failed (-19) > > These are the PCI devices for aspects of the uncore, mostly performance > counters it seems.  Despite the lack of information, I think the > complaint is about setting up the IOMMU context for them. This looks vaguely familiar. Are these devices properly covered by the ACPI DMAR table? (In the instance where I think I saw such before, they weren't.) Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:01:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 14:01:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382191.1625561 (Exim 4.92) (envelope-from ) id 1wrFhx-0005UV-1r; Tue, 04 Aug 2026 14:01:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382191.1625561; Tue, 04 Aug 2026 14:01:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFhw-0005UO-Va; Tue, 04 Aug 2026 14:01:28 +0000 Received: by outflank-mailman (input) for mailman id 1382191; Tue, 04 Aug 2026 14:01:28 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFhw-0005UI-4o for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 14:01:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrFhv-00FSWu-Dv for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 16:01:27 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71f0b3-e002-0a2a0a5209dd-0a2a4508a3de-14 for ; Tue, 04 Aug 2026 16:01:27 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71f0b6-f659-0a2a45080019-d155dd31c9dc-3 for ; Tue, 04 Aug 2026 16:01:27 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47fd4531020so2742052f8f.3 for ; Tue, 04 Aug 2026 07:01:27 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41e296csm40257775f8f.12.2026.08.04.07.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 07:01:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785852086; x=1786456886; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=e+v4psFhaswe/NmQm5nAjbAZqqFxseEEVmVnupeklQA=; b=TYGfdWIkMvqm6NE7yO2gK5ZmNBEE3/BcvPAUKy5TzB/2Ap90shveyA7Nf5Oxo6q0HC LzxK2t8MlzC134M156a23XoWCvCQAhHHRDxWThdx5yhHX2K208DH0nqjehIzMJoW3eo+ A2MeYssxCTqjP3KW58XPOXYhSK1HgFbWlB5BCgBbg/6CSG69kEHwl/yZFiQJWCF0kOJf mk2bVFN5d+Ewdkp7Ar8ODPh3ppG9W8AwQvriG4m7gppLlypOSivXsCwAQlXDzuJHOP5s tTaALoaAEE310eJGhQbV8geT1yXED5tQWq4/R0Bpu7H87SO+z4XZ78OwQKrf7TaoVs1e rEAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785852086; x=1786456886; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=e+v4psFhaswe/NmQm5nAjbAZqqFxseEEVmVnupeklQA=; b=jEqkcZCCQRqwcsrPMnU9ugR2V2hmf8oxB5lPG3+0+1EtfAGVWjRjI0tFjmnZFUgsmX INNXNpSL8qwa0Omx6GNMSg7X4hNpmJ9LazBklVjoAgstvjhdmVl5HugvgWBFmD+rZ206 /L+V+L+ekbXKlPEF06Y0uE6serN3cD8Pwfor/kJhz40hVc9P+MMGDtjEHp5ixmhZP6x+ v7Eg5yf69yY9WbpJnf7dpCmPYscMeCuF38Mm0Zx8MyZhKIz4iLuxDK0fdP6/Ebtg0NCP bqOABq8ZDu8dBkweohU+g/AU9gov8OvkynRFkUsSDux2dxsp8uUDtTaz0GKrfVui6ShK W2RQ== X-Forwarded-Encrypted: i=1; AHgh+RrOtQ89je6tsQ0RWiH/F+46IwacaP7GVZbVHy2FPXeTofxBZFQxAGzNpakRxu8ceFsn+xM3VUYuBqI=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz/RCQlNpC5tvLi745iIXW6sQJeDNwDgvqjKV77lV6KMvRQvmtR h/2aJr/AOnxAKis/YGm4G/BVL0k754k+qcdlFzvaGbombd7WBMMZ/Ihra8udX2wjjQ== X-Gm-Gg: AR+sD11vkbcVgEPyC1mCG0YAWteq0vAUROBj95+R+O9MgAUdVG1MqxXhMkRZErB0FwL iDqOJrZNNPUu1i/Fwn5XRQIF+lR3HRnJwNz0q6y96MDDH4rwibciPSPT7xnd0E8BEhv07DuR+y3 +nyeflosWtwrW0WDdTHKL/JXUYhnUfg9huPBMalOULlaEcS0R/f/rC2W72pvLPldTnHiXRggEyZ cDAc9dzeBg+nLV12BHkyi6oqLBIqmd7ARr8aPjv0lJFGqH7fvN6Ci/IB20ZBI8fK09HKheKgYHr EPzqy0cJ8jBbMJ2sI4F7PFfX0Y8M7jR7zX+1LPcMkbiO29COTVHbhVW1HUYrnauy0djfY2gJTKz fEmCybN0gMlcxePDAAjdhTx7a6oZ/t2pX02wkH3HpVgh7tOa7065Ow46hLDwVJLAobyAuA2AxQg UNcDpQ1vbRC1Z6LPKfgFNyVspC63IaDhU3isf5gIC+pMvFodQ2L6lTVt/fS6NoAjb/DdDjzU6k1 k+WW0uIq4iR/JmvAYMLtIEdIJcMYSRT8ikdjn1GcqKsxG4cTQSC X-Received: by 2002:a05:6000:b48:b0:47f:91e3:3cbf with SMTP id ffacd0b85a97d-47fd72b0a3dmr30401083f8f.19.1785852086379; Tue, 04 Aug 2026 07:01:26 -0700 (PDT) Message-ID: Date: Tue, 4 Aug 2026 16:01:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] x86/EFI: replace ebmalloc() To: Andrew Cooper Cc: Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Anthony PERARD , Michal Orzel , Teddy Astie , Marek Marczykowski , Daniel Smith References: <31ba7ff2-a42d-44aa-976c-17fbff44a56f@suse.com> <98388998-c5c6-4991-8662-2b4bf25188f2@suse.com> <2eb924b2-11fd-45be-b933-c6352fb2dfe0@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2eb924b2-11fd-45be-b933-c6352fb2dfe0@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785852087-CD74B87B-96CF44F6/0/0 X-purgate-type: clean X-purgate-size: 3321 On 30.07.2026 20:08, Andrew Cooper wrote: > On 27/07/2026 11:20 am, Jan Beulich wrote: >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -31,6 +31,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -164,6 +165,8 @@ cpumask_t __read_mostly cpu_present_map; >> >> unsigned long __read_mostly xen_phys_start; >> >> +unsigned long __ro_after_init brk_end; >> + >> /* Only used in asm code and within this source file */ >> char asmlinkage __section(".init.bss.stack_aligned") __aligned(STACK_SIZE) >> cpu0_stack[STACK_SIZE]; >> @@ -1141,7 +1144,6 @@ void asmlinkage __init noreturn __start_ >> struct boot_info *bi; >> unsigned long nr_pages, raw_max_page; >> int i, j, bytes = 0; >> - unsigned long eb_start, eb_end; >> bool acpi_boot_table_init_done = false, relocated = false; >> bool vm_init_done = false; >> int ret; >> @@ -1511,7 +1513,7 @@ void asmlinkage __init noreturn __start_ >> /* >> * This needs to remain in sync with remove_xen_ranges() and the >> * respective reserve_e820_ram() invocation below. No need to >> - * query efi_boot_mem_unused() here, though. >> + * query brk_get_unused_start() here, though. >> */ >> xen->start = virt_to_maddr(_stext); >> xen->size = __2M_rwdata_end - _stext; >> @@ -1654,18 +1656,11 @@ void asmlinkage __init noreturn __start_ >> if ( !xen_phys_start ) >> panic("Not enough memory to relocate Xen\n"); >> >> - /* FIXME: Putting a hole in .bss would shatter the large page mapping. */ >> - if ( using_2M_mapping() ) >> - efi_boot_mem_unused(NULL, NULL); >> - >> /* This needs to remain in sync with remove_xen_ranges(). */ >> - if ( efi_boot_mem_unused(&eb_start, &eb_end) ) >> - { >> - reserve_e820_ram(&boot_e820, __pa(_stext), __pa(eb_start)); >> - reserve_e820_ram(&boot_e820, __pa(eb_end), __pa(__2M_rwdata_end)); >> - } >> - else >> - reserve_e820_ram(&boot_e820, __pa(_stext), __pa(__2M_rwdata_end)); >> + brk_end = brk_get_unused_start(); >> + if ( using_2M_mapping() ) >> + brk_end = PAGE_ALIGN_2M(brk_end); >> + reserve_e820_ram(&boot_e820, __pa(_stext), __pa(brk_end)); > > Hiding brk_end in setup.c like this is quite rude.  I guess it's because > you want to have brk.c be brk.init.o, but it really does live with the > other brk functions. As said in reply to you comments on patch 1 - brk_end is purely an x86 helper variable. I don't want it to move to common code. > Furthermore, having brk_end right from the outset fixes the fact that > brk_get_unused_start() is doing things beyond retrieving a value. > > With brk_end being the real bump pointer the allocator uses, Hmm, no - I don't view the variable as fulfilling that purpose. Jan > then the > only function you need is brk_finish() (name subject to improvement) > which is now very clear about the point at which brk allocations cease > working. > > The rest, dropping EFI's current ebmalloc() all looks fine now. > > ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:04:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 14:04:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382197.1625571 (Exim 4.92) (envelope-from ) id 1wrFkR-0005yu-EQ; Tue, 04 Aug 2026 14:04:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382197.1625571; Tue, 04 Aug 2026 14:04:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFkR-0005yn-BL; Tue, 04 Aug 2026 14:04:03 +0000 Received: by outflank-mailman (input) for mailman id 1382197; Tue, 04 Aug 2026 14:04:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrFkQ-0005yh-A7 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 14:04:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrFkP-001Ss4-Mw for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 16:04:01 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71f133-e002-0a2a0a5209dd-0a2a4504ce8e-24 for ; Tue, 04 Aug 2026 16:04:01 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71f151-b57f-0a2a45040019-d1558029a5ee-3 for ; Tue, 04 Aug 2026 16:04:01 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-495437bb891so9046985e9.1 for ; Tue, 04 Aug 2026 07:04:01 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b4bdc7sm199977865e9.0.2026.08.04.07.03.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 07:04:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785852241; x=1786457041; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=AK/eiZ5xlog3jlcYi/mBuAqCNsuak+f8+DnZSCJJgmE=; b=AsYxcn3atE77CQUSyAgY7ox4yngG2SLKc026pY1kHAQS9c17bkO+VBdlb2wS+rrkDq odpxhq9dWqwq01AZ4+5yxsB3QMyQ7ZDRfnkyWtCbsRRUsVhaoEIltkjW2WvzJ6vj0qL7 ifmIBMBmHlcblItHz9/kXzL1zfqjuboGJdfAAmIlRWYPtOus2/4Uk6POSJjq+RU1mIkx AgsINOt25+hJAGjbnRO5ELOjO7wQ+CRmagI9isFBhPYBpUQxqOBEMogQU4RKGVM9tHTC tV11CpIm0UwBkTTjMN0SU16wDvZHQzpPIg3q0a9bpW9Vx4LhFNJe8G27O+7WeA8ma0oh 6bWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785852241; x=1786457041; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=AK/eiZ5xlog3jlcYi/mBuAqCNsuak+f8+DnZSCJJgmE=; b=NDmExA5CmsBroUQ7/zXCohYOu2e//n8b2ehmm2TJGia5xHWUnblsuU5/m7SH1htCfC E68m7SG7J0yYE6CrtPQC6iz3eKfDQ2Zt7aPicdXjL6G6PRs/bN6JEZczw1tiQWZzMsGt W81Cxl8jbGmhwOwl1PHLAb2WF0MAukNDRGhif8uGWD6/UAiffsdheqxOjR/+RSPLELw2 EYNXrM958exHfGpthSnKZ6TZ2cCQ9vKBkI1aLTHWMWiqcFGukSLOSjITg4tng/r/BrKu l5twmYPTuDrW9s5cWCWn09dF5FI9LoHXPnq5pySdoPa455h/2/5KpFYuCTPXCS55Qyg/ ptiw== X-Forwarded-Encrypted: i=1; AHgh+RpWpslPWCtnRJJP810r6CtWHShp2P3f2JpLXiC00LTBuqBP8WmfEnWaYdKrJxTFpsAcypqJsEYGPiw=@lists.xenproject.org X-Gm-Message-State: AOJu0YwI1jIThXmv9/sMiXVkoZTO+UqCYnF6QgwoTHRN0GiFfMAmNs2R EyrQnxUgR5Vo8a8UAwAbJwRuTfBtoC9Zcy6Kv+TwJ57kOY8GSYpZKdbz4A3tgj3Xuw== X-Gm-Gg: AR+sD13Fj+lTWadIxO/jwVcIAKOxheX5RRTCBqFBze2scjKHgvIpmpEe93hnd3iApkS Q8fWlw3KGj25cuutkzB05iZf6C5ueYPBJBwZmR81MJETIkCFg3gTaN+9ug6tsWKewQdtE1Fg+eY /4JlWMPLu1TEiNommKVCtt7pM72RjiyPv+lwp4uPMQqAXOXjaeZIToHACldm7MfmiRvEoNGWkV/ eUlxEAiD24t9vYM1HE8vrbdKNZjkjqB+GrrB0aMtKPmKIWLtbPS4plzMyp9pZDMNYR1JSsPHiYi FevlUINGWj7EJHvecj4AFgWMRqc/yRdFWVmtDq7+jMFDLeZ5pjUe7kUYgSe28tY+o9VD1//EkQz PnZUirjJKgauMfWq85dcfNaDmmmxz1RE2ANYanXFeJDPlsVCAIwaK7nC6Qjwa2Yz+bsp8QHc190 jvuIb54d5o/dPBW1rBKtu5M5aJzuSGUa1nYdrX9F4kOosoCzRRSv1GUNpBF0t575eSPJueijEtU fhXDvJxG0NiICwYGc4eP76kiGlAYLxLIMmBdfJL/3cl0fHToF+db0PRXl7RI3g= X-Received: by 2002:a05:600c:1987:b0:495:69eb:27d3 with SMTP id 5b1f17b1804b1-4994a101e6cmr70831905e9.8.1785852240938; Tue, 04 Aug 2026 07:04:00 -0700 (PDT) Message-ID: <36859779-a6c1-448b-91ae-511ada7260fe@suse.com> Date: Tue, 4 Aug 2026 16:03:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] x86/EFI: replace ebmalloc() From: Jan Beulich To: Andrew Cooper Cc: Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Anthony PERARD , Michal Orzel , Teddy Astie , Marek Marczykowski , Daniel Smith References: <31ba7ff2-a42d-44aa-976c-17fbff44a56f@suse.com> <98388998-c5c6-4991-8662-2b4bf25188f2@suse.com> <2eb924b2-11fd-45be-b933-c6352fb2dfe0@citrix.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1785852241-506DAB50-DB12CCA5/0/0 X-purgate-type: clean X-purgate-size: 3429 On 04.08.2026 16:01, Jan Beulich wrote: > On 30.07.2026 20:08, Andrew Cooper wrote: >> On 27/07/2026 11:20 am, Jan Beulich wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -31,6 +31,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -164,6 +165,8 @@ cpumask_t __read_mostly cpu_present_map; >>> >>> unsigned long __read_mostly xen_phys_start; >>> >>> +unsigned long __ro_after_init brk_end; >>> + >>> /* Only used in asm code and within this source file */ >>> char asmlinkage __section(".init.bss.stack_aligned") __aligned(STACK_SIZE) >>> cpu0_stack[STACK_SIZE]; >>> @@ -1141,7 +1144,6 @@ void asmlinkage __init noreturn __start_ >>> struct boot_info *bi; >>> unsigned long nr_pages, raw_max_page; >>> int i, j, bytes = 0; >>> - unsigned long eb_start, eb_end; >>> bool acpi_boot_table_init_done = false, relocated = false; >>> bool vm_init_done = false; >>> int ret; >>> @@ -1511,7 +1513,7 @@ void asmlinkage __init noreturn __start_ >>> /* >>> * This needs to remain in sync with remove_xen_ranges() and the >>> * respective reserve_e820_ram() invocation below. No need to >>> - * query efi_boot_mem_unused() here, though. >>> + * query brk_get_unused_start() here, though. >>> */ >>> xen->start = virt_to_maddr(_stext); >>> xen->size = __2M_rwdata_end - _stext; >>> @@ -1654,18 +1656,11 @@ void asmlinkage __init noreturn __start_ >>> if ( !xen_phys_start ) >>> panic("Not enough memory to relocate Xen\n"); >>> >>> - /* FIXME: Putting a hole in .bss would shatter the large page mapping. */ >>> - if ( using_2M_mapping() ) >>> - efi_boot_mem_unused(NULL, NULL); >>> - >>> /* This needs to remain in sync with remove_xen_ranges(). */ >>> - if ( efi_boot_mem_unused(&eb_start, &eb_end) ) >>> - { >>> - reserve_e820_ram(&boot_e820, __pa(_stext), __pa(eb_start)); >>> - reserve_e820_ram(&boot_e820, __pa(eb_end), __pa(__2M_rwdata_end)); >>> - } >>> - else >>> - reserve_e820_ram(&boot_e820, __pa(_stext), __pa(__2M_rwdata_end)); >>> + brk_end = brk_get_unused_start(); >>> + if ( using_2M_mapping() ) >>> + brk_end = PAGE_ALIGN_2M(brk_end); >>> + reserve_e820_ram(&boot_e820, __pa(_stext), __pa(brk_end)); >> >> Hiding brk_end in setup.c like this is quite rude.  I guess it's because >> you want to have brk.c be brk.init.o, but it really does live with the >> other brk functions. > > As said in reply to you comments on patch 1 - brk_end is purely an x86 > helper variable. I don't want it to move to common code. > >> Furthermore, having brk_end right from the outset fixes the fact that >> brk_get_unused_start() is doing things beyond retrieving a value. >> >> With brk_end being the real bump pointer the allocator uses, > > Hmm, no - I don't view the variable as fulfilling that purpose. In fact, to add to this, originally I had a variable of this purpose. It simply didn't work out nicely, in particular because of the page alignment which may need enforcing. (Surely it could be done like you say, but I'd really prefer not to.) Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 14:27:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 14:27:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382214.1625581 (Exim 4.92) (envelope-from ) id 1wrG75-0001N6-Ci; Tue, 04 Aug 2026 14:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382214.1625581; Tue, 04 Aug 2026 14:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrG75-0001My-9C; Tue, 04 Aug 2026 14:27:27 +0000 Received: by outflank-mailman (input) for mailman id 1382214; Tue, 04 Aug 2026 14:27:26 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrG73-0001Ms-W0 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 14:27:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrG72-00Bvym-Fx for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 16:27:24 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a71f6c0-5cb7-0a2a0a5109dd-0a2a4504d054-40 for ; Tue, 04 Aug 2026 16:27:23 +0200 Received: from [52.101.52.70] (helo=BL2PR02CU003.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a71f6ca-b57f-0a2a45040019-3465344686da-3 for ; Tue, 04 Aug 2026 16:27:23 +0200 Received: from BLAP220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::9) by DM6PR12MB4217.namprd12.prod.outlook.com (2603:10b6:5:219::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 14:27:19 +0000 Received: from BL02EPF00029928.namprd02.prod.outlook.com (2603:10b6:208:32c:cafe::84) by BLAP220CA0004.outlook.office365.com (2603:10b6:208:32c::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.16 via Frontend Transport; Tue, 4 Aug 2026 14:27:19 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by BL02EPF00029928.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Tue, 4 Aug 2026 14:27:19 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Tue, 4 Aug 2026 09:27:19 -0500 Received: from [172.19.79.34] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Tue, 4 Aug 2026 09:27:18 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DdejiW88sNJhAhZbXKWD0EyYZGNDAcuFlEfel4t62wJgjJ5gAu3tjUxfQjiluWWqUuIYdQzdBuuIpm5MXADKCQ+eWeNGCYw+VnoRLU2faqh4jJGur8Kh8Fps5o/HbKYonR0LdlwaVZzKsKEdVe1E8MLBNF2hEdFqPWPh3i1p1I055Me0nk1k8sYw7J92eiwWDlmGK3NNkgClV+vqFIY/TLyDCusNwlpsRPdx0hg4zgsJvjMrHINnWBOpl0H2g587sDqbIddFVVRG9SYQ6uZqm2+ckjLymP0uEvcOfgeXyaLftkqY82EXzYr/ftC9Pwg1t8vI5T2lnVBRpsmfVoeCEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nR4Is8OyR6I08GeGM3t3zaSmggdBeboOOSXRsCXiuVk=; b=NtR4D2chpsbSQNxJQIVU2OnNc6q7AAzDkyL7XMYVTj4XEmvpWE5AcMlT19WboYKnUWSf3xKi0fMgzjMIeAWszu18NR8GXd7K6zjJLXZ4Ul1dXel+JUPu2Rpxj1JndVMjVjNk8kcU4FmhkRSLr6w23eIQXgEjMmYZRrMD6oF84rS57edea8GK9WYU56y+Tghw+7zZ4Zmj0pBq+9V4aXXWZUCwzOdHYQMiJZNkts6i5Mzu2xGOOuL80xFCoc7yAr9y4sfckhlHxBpfBvspxBx+XSDIejFwS3nS5s4uKr0rGv9HIu9jZxP5IMJna8FD+MxoG/nVx7h2W831iUukVQfW3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nR4Is8OyR6I08GeGM3t3zaSmggdBeboOOSXRsCXiuVk=; b=vHikyjsjeR3BqxkivlzyWm4/uVVwGdnxTqPo9MC+VXy2wEZoWvkeT6sQKGpYfTLLBaWElJ1jogP255iNb3jsGVE2QiX94VAN7r91D5XFZyH5UvDs6FMT2MUWm7gLPKiZBHvBm/eyWFlhlUbjgadOWSsGrzZW3Oa9yA7XCKj98sc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Message-ID: <57bb7281-5898-4243-837a-1236b25e761e@amd.com> Date: Tue, 4 Aug 2026 10:27:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: Jan Beulich CC: Daniel Smith , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> <8097d8e8-42ec-463a-8247-56c9e4d834cd@suse.com> Content-Language: en-US From: Jason Andryuk In-Reply-To: <8097d8e8-42ec-463a-8247-56c9e4d834cd@suse.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029928:EE_|DM6PR12MB4217:EE_ X-MS-Office365-Filtering-Correlation-Id: cd2c43c3-4fbc-4524-3cc8-08def2347de7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|376014|82310400026|1800799024|56012099006|10067099003|4143699003|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Gb+sXQlU8KCyB1mqweNeyt/qVLzsprrW7ckV3dZ4Rk54zeQBqjRzvkYZ5ovxHl0K2kb66SbZ08ewI3VJOq9KZFuAX2hXWxo/R7iOOu8iemw3uTstmAbfNLhoZd6TF+Kz+yTn+LGpOe5MeQ0/nEJbGwUA+l6riNOF89Ge6jmID3IwOQ3hNa4hU4LJ+tnZc6NFpBSq0rrO9lHOi8LPStD0meqaEGslYSg8EBlgAizNPXJ4VrdBjJmZexb/iMFWSG+UKYUz55AWiw6Ek9utGMWGaCEwMVCRe52InwhI9/SvyjW+qrD70tLkA2tAzR9pT+ahIVC9TOsEAjKV1Bj2PC0O++QBOJDoz1TM0TIA03j+ITDI8rheTYv+RkNfCQVjF6IVlnV/gIC/gk32RF02xD7hmr3yKeNoMQCsm3n8Z7H5/70Oyw4rLdPmYQmh/ggHJ1GCAcoZxb9V7etuSdFo4Z/2tz94zz8t0VmhlBa3ZvSCXexyEsXK4WWguzNVZQHq1UysfAZrbSEHBiSasyk/keU1QvXEOTaAt4eFFuD1DYrjYqcXXSEpwY7k9LKZb71Guok2q8P0M2EuF+85evkFvMkPYMCA12Qo6hoJnirP6OUTL+Whh+nIktll/PfHfSh9D15OhtwiiKpgqvOAW2eBAxHJOFML99ydPCowGYM3g5vXVSmlyscQO9gGHeohnhN0Kr1SQmug2Xl5ln0nn93KMbW5Iw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(376014)(82310400026)(1800799024)(56012099006)(10067099003)(4143699003)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5GY+wQCayyJvmwVn4l5h/PIAoNhagbDpleGfOu/s/REXN4AwNoY1CeV3rB3UGNSDoEDJwOKSWCn0by4yq4I6OOxqUUNpriHUP66NinIWZhF+wk50TNa7qeLwtr3CCuTPgbJ2ZV+0CkwAAcIk7HoHsGXVr5rJXhydvKjIntZC1lMJdhNAN50OGM0iSSmjC9j4fRoiU3WTyAAfeGWpOfWamFgso5yigc/NpshFtAN06XExaPW1xEd222cb231T/FZ6mkAciEgLaOyYhF01zLwPk9z9X/lv9c4g9Pc5f1DC0qg8jRZK8AhzyrY6GfGbmuLaDTb4NIWvQ32+WIlhhAMNrXhOrMNF5CSp315zUxW+0ucIQbCBtvNxz6ZxJ/yUc/7wFNSYvTdxdo3ve9BBrXyPPw6FWtRr6vFbbzJqSrsW29S0Arb/2wTEazhiwEncUb1/ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 14:27:19.7286 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd2c43c3-4fbc-4524-3cc8-08def2347de7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029928.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4217 X-purgate-ID: tlsNG-ebf023/1785853643-514D3B50-7B3FA852/0/0 X-purgate-type: clean X-purgate-size: 3406 On 2026-08-04 03:53, Jan Beulich wrote: > On 03.08.2026 23:01, Jason Andryuk wrote: >> On 2026-07-28 09:22, Jan Beulich wrote: >>> --- a/xen/include/xsm/dummy.h >>> +++ b/xen/include/xsm/dummy.h >> >>> @@ -751,27 +751,32 @@ static XSM_INLINE int xsm_dm_op(XSM_DEFA >>> #endif >>> >>> #ifdef CONFIG_ARGO >>> -static XSM_INLINE int xsm_argo_enable(const struct domain *d) >>> + >>> +static XSM_INLINE int xsm_argo_enable(XSM_DEFAULT_ARG const struct domain *d) >>> { >>> - return 0; >>> + XSM_ASSERT_ACTION(XSM_HOOK); >>> + return xsm_default_action(action, current->domain, d); >> >> This one I think should be >> return xsm_default_action(action, d, NULL); >> >> Usually current is passed in for the check, but for domain_create() -> >> argo_init() it is the under-construction domain. > > And in that case we want to make sure that current->domain may enable Argo > for d. It's not a hook for current to enable for d, but more of a hook "is d allowed to use argo." In the hypercall entry path, it use is clear - "is this domain allowed to make argo hypercalls." In argo_init(), it is more of an optimization. Only initialize if d is allowed to use argo. I think this use is questionable, but it is the current code. In flask, the source is d, the target is xen_t: allow domain_type xen_t:argo enable So it is not an operation between domains. >>> } >>> >>> static XSM_INLINE int xsm_argo_register_single_source( >>> - const struct domain *d, const struct domain *t) >>> + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) >>> { >>> - return 0; >>> + XSM_ASSERT_ACTION(XSM_HOOK); >>> + return xsm_default_action(action, d, t); >>> } >>> >>> static XSM_INLINE int xsm_argo_register_any_source( >>> - const struct domain *d) >>> + XSM_DEFAULT_ARG const struct domain *d) >>> { >>> - return 0; >>> + XSM_ASSERT_ACTION(XSM_HOOK); >>> + return xsm_default_action(action, current->domain, d); >> >> Similarly: >> return xsm_default_action(action, d, NULL); >> >> The single call is: >> xsm_argo_register_any_source(currd); > > There being just a single call puts this on the edge. If there was another > one not passing current->domain, I think the same argument as above would > hold here. And the general concept is what I think should matter when > writing the dummy implementations. For flask, we have xen as the target again: allow domain_type xen_t:argo register_any_source; ... since a wildcard ring doesn't have a known target domain. >> These argo hooks all pass in their arguments explicitly, so I think we >> should do that and not use current. (The send and register hooks could >> use current, and that could make sense as those map to hypercalls. But >> it is correct today with the explicit arguments.) >> >> With the changes: >> Reviewed-by: Jason Andryuk > > Thanks, but no - unless I misunderstand how permissions are intended to > work here, I don't think I can make the changes requested, and hence I > can't apply the R-b. Understandable. It seems to me that the XSM hooks have two styles. Either implicit args (using current) or explicit args. Today, the argo hooks take explicit like the grant hooks for instance. Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:31:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382237.1625588 (Exim 4.92) (envelope-from ) id 1wrH6e-00043a-Q2; Tue, 04 Aug 2026 15:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382237.1625588; Tue, 04 Aug 2026 15:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrH6e-00043T-Mh; Tue, 04 Aug 2026 15:31:04 +0000 Received: by outflank-mailman (input) for mailman id 1382237; Tue, 04 Aug 2026 15:31:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrH6d-00043N-P7 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:31:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrH6d-004pGb-2q for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:31:03 +0000 Received: from mail-lf1-f42.google.com ([209.85.167.42]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wrH6d-00AukV-1u for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:31:03 +0000 Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5b013aa02b2so1298592e87.0 for ; Tue, 04 Aug 2026 08:31:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Type:To:Subject:Message-ID:Date: From:MIME-Version; bh=wUnWfLwtyqKHjxc5MZcvpzA2F49Qe7vEZ46gubm6ZLI=; b=0UzYp0W OJVmRrw3XaohqaeIDfpxYTdqiMx/jYZxPmQgvohnJMlghlOx8oar0Pjm4ZB+1N+ulPQnS8Oz1DEtc JegPQ/l5Om4AiEoHEU/S2SENKfVDHq8HTaZUah0EjTb4IFI/O6Mia3kxevCO2MnYUWb5x0widSwFc Ec9TIvYFU4=; X-Gm-Message-State: AOJu0Yxap6+y+HvC260fpNqEBXBFd+91DRr27+E/aMSm6so7sKPXsv8J RDFMggEggYJiyE/J9PqN23K2te8hF3M/TaCvZHbFF2VMkTkteyVqhVgI/28OLu9IcPbI/5ZlbzO wfZi5MULUTX28OFUhpqvgfAizM+g5Fbg= X-Received: by 2002:a05:6512:3b90:b0:5b0:1e26:7751 with SMTP id 2adb3069b0e04-5b2ee5e4dbbmr1249418e87.8.1785857462436; Tue, 04 Aug 2026 08:31:02 -0700 (PDT) MIME-Version: 1.0 From: Cody Zuschlag Date: Tue, 4 Aug 2026 17:30:50 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mz1wVMRUzsBvMVX98GLu2pW70C6sFQH8l8wnmnEUy5iBrUe5l1BBD3W3oM Message-ID: Subject: [ANNOUNCE] - Call for agenda items for August 6 Xen Community Call @ 15:00 UTC To: xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000ab072206583a57bb" --000000000000ab072206583a57bb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi everyone, It's time for the August Xen Project Community Call, happening this Thursday, 6 August at 15:00 UTC. Whether you have updates to share or just want to listen in, we'd love to have you join. It's a great opportunity to hear what the community has been working on, discuss ongoing project activities, and catch up on recent developments. *Preparation* =F0=9F=91=89 Please take a few minutes to review and update the agenda befo= re the call: https://cryptpad.fr/pad/#/2/pad/edit/eqPXghB7GwT4OuySCjSQRyVD/ Feel free to: - Add topics or project updates - Suggest anything we can drop or defer - Include links to patches, mailing list threads, or documentation where helpful The agenda also includes the meeting link and a link to find your local meeting time. *Call Details* Date: Thursday, 6 August 2026 Time: 15:00 UTC (agenda starts at 15:05 UTC) Join: https://meet.jit.si/XenProjectCommunityCall We'll open the room at 15:00 UTC and begin the agenda at 15:05 UTC to give everyone a few minutes to join. Want to be CC'd on future community call announcements? Add or remove yourself from our sign-up sheet: https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ See you on Thursday! Best regards, Cody Zuschlag Xen Project - Community Manager --000000000000ab072206583a57bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi everyone,

It's time for the August Xen = Project Community Call, happening this Thursday, 6 August at 15:00 UTC.
=
Whether you have updates to share or just want to listen in, we'd l= ove to have you join. It's a great opportunity to hear what the communi= ty has been working on, discuss ongoing project activities, and catch up on= recent developments.

Preparation

=F0=9F=91=89 Please = take a few minutes to review and update the agenda before the call:

= = https://cryptpad.fr/pad/#/2/pad/edit/eqPXghB7GwT4OuySCjSQRyVD/

F= eel free to:
- Add topics or project updates
- Suggest anything we ca= n drop or defer
- Include links to patches, mailing list threads, or doc= umentation where helpful

The agenda also includes the meeting link a= nd a link to find your local meeting time.

Call Details
Date: Thursday, 6 August 2026
Time: 15:00 UTC (agenda start= s at 15:05 UTC)
Join: https://meet.jit.si/XenProjectCommunityCall

We'll open= the room at 15:00 UTC and begin the agenda at 15:05 UTC to give everyone a= few minutes to join.

Want to be CC'd on future community call a= nnouncements?

Add or remove yourself from our sign-up sheet:
http= s://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

See y= ou on Thursday!

Best regards,

Cody Zuschlag
Xen= Project - Community Manager
--000000000000ab072206583a57bb-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:39:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:39:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382248.1625598 (Exim 4.92) (envelope-from ) id 1wrHF5-00053D-Fc; Tue, 04 Aug 2026 15:39:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382248.1625598; Tue, 04 Aug 2026 15:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHF5-000536-Cv; Tue, 04 Aug 2026 15:39:47 +0000 Received: by outflank-mailman (input) for mailman id 1382248; Tue, 04 Aug 2026 15:39:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHF3-000530-Nq for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:39:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHF3-00FjQT-1K for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:39:45 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72079c-bab6-0a2a0a5309dd-0a2a45048a62-44 for ; Tue, 04 Aug 2026 17:39:44 +0200 Received: from [209.85.221.54] (helo=mail-wr1-f54.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7207c0-b57f-0a2a45040019-d155dd36b9c3-3 for ; Tue, 04 Aug 2026 17:39:44 +0200 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47f84023916so4588659f8f.3 for ; Tue, 04 Aug 2026 08:39:44 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23ec3asm551990f8f.31.2026.08.04.08.39.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 08:39:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785857984; x=1786462784; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=2toUDhZyEbbG0kKRohXauBWdzsUJgpoNHOwbrQ7ecrY=; b=M9BRdTf5M3TFz626lH0amRKEftLvy7JVlaGDDh563EyJBgyJtqJVRpcoCPQpkjUltx AGK/PEQSL2vFZ5/fkVm1H2wKz0qnSdzt85ngwNvBsulyodKDEfwsoUQlgS+jorOfep3v iE4xLQ3VK/SHrldhqzUNXbjWHH1v7QLgTlWm3OYJCbbSVyYBi9R+WluTh8NouBL0or1u xxRVY3y909A8UoA0bzl7Eu79c2GI8A9iQ5cY0GHuD0GPo79Ap5SBDefztlAudftVYhqh q1xQrV6JoDl4JHvAo/LaUJkfgJk+UUbjPVvZey858VNRWP4ofS/NMdETyC/qobg7JZKp gNMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785857984; x=1786462784; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=2toUDhZyEbbG0kKRohXauBWdzsUJgpoNHOwbrQ7ecrY=; b=HCVGrLg343fnvOtFK7X3Igtr9WRpVgqSl7THz67kLAYasI2F5qI1tonEpobMAXzgp/ oTvDvHy1z41IqRqLOSOXFjG3vsHDw39oJZRhnqXnYKJdz+3IQI2QQHj9lo9ZS1EFPXam V1XjN0uFZDa/EIKk5z1U9wzkDOaj7ZsLowz5k6CDzniB7BEyInAcpA2Ai8xLqqyhFxpF HuVo2omTbkuWfJ35/zz5m0zTghrvMROA/GUg9yEsobm/3AJXoBFZftcKjV1RByImw8vo ND6nMY0PCIM17d9fx/jEMchqxDrBi81K9KJDrNbHN0WXW4X0GzRQ2tS1/WyRKC6fei1n 55Vg== X-Forwarded-Encrypted: i=1; AHgh+RqTIIwAEgcHBusoK7XsLmPyEyJSx3Dv1gCmfBPUol/jqGZLdVgDGeo189Zj8EQwD7sEokFzTlzPw7o=@lists.xenproject.org X-Gm-Message-State: AOJu0YxZQlX+CFJLp7bCCy3C+3kSfiqIbnLZ6bS3mTVniQNDs4TBJ2N1 IVGTZPSpAo44BbUeGZvway7i+kny2yTzi67kX2MZ5+ZlBv4zuMwnAtSHTc4EUT4zcA== X-Gm-Gg: AR+sD10ptemqVp5oEzIwu29sf7+23L1gXDX9Mjq2T0m5L5Z/B/C3/8SD7kEOIJsyc1N rfMluDtNIchAjxc3Gkra2WnNE0oC1KxvyiMGkmaKcMvHgkJiPZMwrV9Vqwi6KbTQizGWzzegkcl Nzvt9ApJnEoF/+x+oZG7Qy5Kg+5hS73Mg1aihHtUW6AvvJdvuMQf6MpPhfnIoeN8ZtezaWSvlyx iIqLAMFSYLSI4QBrstzwL2Iqg/n208g6+wcea6/2MRv/AR1iMpyS+U137LB099Kqdbnmx50AIjJ JJ8t64AE8EsYHfJ+JOQBpl996MGOouKsD4KpcWj+WdwCzhvlaCDuhhA4pwhSE15pg6s9Zc2v7OO AXpzwZXA4sQftIwrlCGhdpJs9u4kb1cVCOlUaNbi3+cZYOBijHk7yPzAuTIQVJeCJimCmKg8Y37 nkGqjbrMMIH3WszaDlVtHWgNqAIFwwS0GjdW92rxoJCg8TBP6hVu+IQ1JOnlNvwbPAo/iXxc8k/ aJEmqE0iY4ZexljztdNs83EMOcJmWo8t1+IJtbDIlrSmpLVxqX2 X-Received: by 2002:adf:fec7:0:b0:47e:81aa:3832 with SMTP id ffacd0b85a97d-47fec519ff8mr221710f8f.16.1785857984304; Tue, 04 Aug 2026 08:39:44 -0700 (PDT) Message-ID: <0b892cfe-0a7d-4e7f-b7f6-4fc2575762ac@suse.com> Date: Tue, 4 Aug 2026 17:39:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] x86/emul: Introduce x86_decode_lite() From: Jan Beulich To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Xen-devel References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-2-andrew.cooper3@citrix.com> <01b27228-fdc0-4546-aa23-2bcdafb22727@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <01b27228-fdc0-4546-aa23-2bcdafb22727@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1785857984-528C9B50-3F73523E/0/0 X-purgate-type: clean X-purgate-size: 5585 On 03.08.2026 17:26, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/x86/x86_emulate/decode-lite.c >> @@ -0,0 +1,330 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> + >> +#ifdef __XEN__ >> +# include >> +# include >> +#endif >> + >> +#include "private.h" >> + >> +#undef ModRM >> + >> +/* >> + * Bare minimum x86 instruction decoder to parse the alternative replacement >> + * instructions and locate the IP-relative references that may need updating. >> + * >> + * These are: >> + * - disp8/32 from near direct branches >> + * - RIP-relative memory references >> + * >> + * The following simplifications are used: >> + * - All code is 64bit, the instruction stream is well formed and safe to >> + * read. >> + * - Instruction groups and prefixes not used by Xen's current alternatives >> + * are not implemented in order to reduce the decode complexity. >> + * - Certain instructions are intentionally not recognised, when it is more >> + * likely for their presence to be an error than intentional. >> + * >> + * Inputs: >> + * @ip The position to start decoding from. >> + * @end End of the replacement block. Exceeding this is considered an error. > > Why do you mention replacement blocks here? Are we entirely set on this > code not possibly gaining any purpose beyond the scanning of those? > >> + * Returns: x86_decode_lite_t >> + * - On failure, length of 0. >> + * - On success, length > 0. For rel_sz > 0, rel points at the relative >> + * field in the instruction stream. >> + */ >> +x86_decode_lite_t init_or_livepatch x86_decode_lite(void *ip, void *end) > > Is there a reason the parameters can't be pointer-to-const? Hmm, > apparently for x86_decode_lite_t's "rel" field not be plaing void *, "ip" > needs to be this way as well. But not "end", I don't think. > >> +{ >> +#define Imm8 (1 << 0) >> +#define Imm (1 << 1) >> +#define Moffs (1 << 2) >> +#define Branch (1 << 5) /* Near direct branches, which have a displacement */ >> +#define ModRM (1 << 6) >> +#define Known (1 << 7) >> + >> + static const uint8_t init_or_livepatch_const onebyte[256] = { >> + >> +#define ALU_OPS(x) \ >> + [(x) + 0] = (Known|ModRM), \ >> + [(x) + 1] = (Known|ModRM), \ >> + [(x) + 2] = (Known|ModRM), \ >> + [(x) + 3] = (Known|ModRM), \ >> + [(x) + 4] = (Known|Imm8), \ >> + [(x) + 5] = (Known|Imm) >> + >> + ALU_OPS(0x00) /* ADD */, ALU_OPS(0x08) /* OR */, >> + ALU_OPS(0x10) /* ADC */, ALU_OPS(0x18) /* SBB */, >> + ALU_OPS(0x20) /* AND */, ALU_OPS(0x28) /* SUB */, >> + ALU_OPS(0x30) /* XOR */, ALU_OPS(0x38) /* CMP */, >> + >> +#undef ALU_OPS >> + >> + [0x50 ... 0x5f] = (Known), /* PUSH/POP %reg */ >> + >> + [0x62] = 0, /* BOUND, but also EVEX prefix, not implemented. */ >> + [0x63] = (Known|ModRM), /* MOVSxd */ >> + >> + [0x68] = (Known|Imm), /* PUSH $imm */ >> + [0x69] = (Known|ModRM|Imm), /* IMUL $imm */ >> + [0x6a] = (Known|Imm8), /* PUSH $imm8 */ >> + [0x6b] = (Known|ModRM|Imm8), /* PUSH $imm8 */ >> + [0x6c ... 0x6f] = (Known), /* INS/OUTS */ >> + [0x70 ... 0x7f] = (Known|Branch|Imm8), /* Jcc disp8 */ >> + [0x80] = (Known|ModRM|Imm8), /* Grp1 */ >> + [0x81] = (Known|ModRM|Imm), /* Grp1 */ >> + >> + [0x83] = (Known|ModRM|Imm8), /* Grp1 */ >> + [0x84 ... 0x8e] = (Known|ModRM), /* TEST/XCHG/MOV/MOV-SREG/LEA */ >> + [0x8f] = 0, /* Grp1A - POP but also XOP prefix, not implemented. */ > > POP doesn't look all that unlikely to be used in inline assembly, and > hence in alternatives. That said, of course using it with a memory > operand requires quite a bit of care. I don't see you excluding the > PUSH counterpart, though - being consistent for any such pairs would > seem somewhat desirable. > >> + [0x90 ... 0x99] = (Known), /* NOP/XCHG %rAX/CLTQ/CQTO */ >> + >> + [0x9b ... 0x9f] = (Known), /* FWAIT/PUSHF/POPF/SAHF/LAHF */ >> + [0xa0 ... 0xa3] = (Known|Moffs), /* MOVABS */ >> + [0xa4 ... 0xa7] = (Known), /* MOVS/CMPS */ >> + [0xa8] = (Known|Imm8), /* TEST %al */ >> + [0xa9] = (Known|Imm), /* TEST %rAX */ >> + [0xaa ... 0xaf] = (Known), /* STOS/LODS/SCAS */ >> + [0xb0 ... 0xb7] = (Known|Imm8), /* MOV $imm8, %reg */ >> + [0xb8 ... 0xbf] = (Known|Imm), /* MOV $imm{16,32,64}, %reg */ >> + [0xc0 ... 0xc1] = (Known|ModRM|Imm8), /* Grp2 (ROL..SAR $imm8, %reg) */ >> + >> + [0xc3] = (Known), /* RET */ >> + [0xc4 ... 0xc5] = 0, /* LES/LDS but also VEX prefixes, not implemented. */ > > This may bite us sooner or later, due to the VEX-encoded integer insns > that there are. Of course as long as we don't use this function on > compiled code, and as long as my "x86: allow Kconfig control over psABI > level" doesn't come close to going in, that's merely a theoretical > concern. Actually perhaps sooner - we're meaning to use MSR-IMM insns after all, if I'm not mistaken. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382262.1625614 (Exim 4.92) (envelope-from ) id 1wrHNP-0006xa-Mz; Tue, 04 Aug 2026 15:48:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382262.1625614; Tue, 04 Aug 2026 15:48:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNP-0006x3-GR; Tue, 04 Aug 2026 15:48:23 +0000 Received: by outflank-mailman (input) for mailman id 1382262; Tue, 04 Aug 2026 15:48:23 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNO-0006uJ-Sj for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNO-009Gcw-9m for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:22 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c5-bab6-0a2a0a5309dd-0a2a4509cbee-2 for ; Tue, 04 Aug 2026 17:48:22 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209c6-be1a-0a2a45090019-d155802ba947-3 for ; Tue, 04 Aug 2026 17:48:22 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4954a9e8490so6653095e9.1 for ; Tue, 04 Aug 2026 08:48:22 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858502; x=1786463302; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eQRAf5Du6pYWboeiDXqOeIZI6NQJ2iFJlkGQQHsxk/w=; b=M4Hnq68nWPuVsC7lwgbAoKk1HmzP+ekLiazSJ9amNCGZrUyd5PPFNyX4ZACZhyInPB +FPOcowBJDZvRU6z43RqtTb8wOZXe1LM685hOsXwkbT6xY329trAZuihjeobWc6m3MKW y3QQYIN+8S937Xn7IVM/4lUsRywVLRPxXl7PaFtb90k3zIrs2eqS2MCghJKQZtfQzK3c sIVnSqsCnz0bqNndrHGG4sPNpli+AFMnZORD2ylnLg6jpT0QWLHZ0IOWfq7NWPceq+0t N7jG/aj0tUDzTPm8Y0hKHUMJAzZimT2lDxACqPjtA1z4cMgBY8VSfTZpB9UyXDo/nxHc JNLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858502; x=1786463302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eQRAf5Du6pYWboeiDXqOeIZI6NQJ2iFJlkGQQHsxk/w=; b=oIekdbC+hCOxA0FU1+lFisS8TfuYcEW3ikZSnXYdJmsbl9rWolqudbhAmXWGMBx3Bm IrR9k4U2EweMJ73p5qg1XCe4y6aWpeNibKE/GIGOQO1M/AUYh8JXnePYqwYjhVc2ZaMw rujDOie4q+83coloujMuHnAtOjaS8zLJJ9pCrI7qnRNsP34IQADK8G6GlIDJOHVBeRaF Rfgn8tw5hYfGMo61rJYbaEqOoxn3LuqOlQqA1iKBuLEnbRrgkCnlRXmSeI3Bnoebbf0O XCpsW4/L1mDP6Jl95qkh7O6f9Z8oACi5FiG3K0f0OsL3Xp40BQvW/2BopPzEPFt4dCVq kVeQ== X-Gm-Message-State: AOJu0Yzo339f+YbOXfILuBoS12MiOE/viBqYPXB71j9zMh7aj+ky2JY6 fN2UiHKXahhUzozcqbWnnF51XDwAl485uvoguhLk+Ywz4EQxTU8HS1VUXKrVjQ== X-Gm-Gg: AR+sD100IJ8y2i4hca2J14u2pOK/D7zXXYUqTTQNuqtmEsyGitmNSSIsWe1nMjC+K5A VxPFDRxjIUoK12QeTltI43lg3wvWiBrfoGUK2puunVJkRdMkSKMemUlJX1vpKrXd8B/DWwqQh1e aA8czR96T+f09XUbP5kgq2cLk2LsX0s6KD1Ar2JrZ3zSEl2ZLHCF9QPAF+KVUQQPTZe4TE/ZuWZ 7L+yx0gsdVlVeKkwPHeY0SE0/+/ALW2yuhB3jydRpk/uO+wUariM2JBpqsWc3GTqzK0gm8lACy2 OjsPPhS/iwatyvc1ImUiv8dKoGVN++a41NCtkFLTwWh5gM43roQkYfF6DqcNfVE0sgzcMMVtkhw rRwlmDUdQ42FCNzYGnrrzHfN6+sQYC/UScNIqZOxMxXYg56sXXgS1QIYzzyVLGoxvxPdvH+WsBR rJxf1TT2/7ylNlo8xnU1hGLGspKJKwePDy0ZAo0RDuGYsOFrQ3r1jGGlTmRDBTRkj0xIEFiXSio I6UZmZU5Q19aHIVRImmTZzCatp2tj+FWw== X-Received: by 2002:a05:600c:3ba6:b0:495:3a52:71b1 with SMTP id 5b1f17b1804b1-4994e374ad3mr1342475e9.5.1785858501675; Tue, 04 Aug 2026 08:48:21 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Timothy Pearson , Alistair Francis , Connor Davis , Teddy Astie Subject: [PATCH v7 02/20] xen/dom0less: turn max_init_domid into a common variable Date: Tue, 4 Aug 2026 17:47:52 +0200 Message-ID: <6cd23822f5427a67f8f77300b09bc78d65a1d317.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785858502-BE6DA034-95C89CCA/10/73395122804 X-purgate-type: spam X-purgate-size: 5825 Until now every architecture carried its own notion of max_init_domid: Arm defined a real variable (declared in asm/setup.h, defined in setup.c), while ppc, riscv and x86 each provided a "#define max_init_domid (0)" stub in their asm/setup.h. This duplicated the same declaration across all arches and placed a purely dom0less concept in arch setup headers. Now that the dom0less build code lives in common (xen/common/ device-tree/dom0less-build.c sets max_init_domid, and the console serial-input switcher reads it), there is no reason for the symbol to be per-arch. Provide a single declaration in , with the !CONFIG_DOM0LESS_BOOT stub kept there as well, so there is one source of truth and the arch headers no longer need to mention it. Update console.c to include for the declaration instead of relying on asm/setup.h. Place the definition in xen/common/domid.c rather than in dom0less- build.c. The latter is built as dom0less-build.init.o, i.e. the whole object is relocated into the .init.* sections and freed after boot, whereas max_init_domid must outlive boot because it is read at runtime by the console serial-input switcher. domid.c is always linked (obj-y) and resides in regular (non-init) sections, so it is a correct home for the variable. It is marked __ro_after_init since it is only updated while creating boot-time domains and read-only afterwards, and guarded by CONFIG_DOM0LESS_BOOT as domid.c itself is unconditional. Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- Changes in v6-7: - Nothing changed. Only rebase. --- Changes in v5: - Add Reviewed-by: Jan Beulich --- Changes in v4: - New patch. --- --- xen/arch/arm/include/asm/setup.h | 2 -- xen/arch/arm/setup.c | 2 -- xen/arch/ppc/include/asm/setup.h | 2 -- xen/arch/riscv/include/asm/setup.h | 2 -- xen/arch/x86/include/asm/setup.h | 2 -- xen/common/domid.c | 5 +++++ xen/drivers/char/console.c | 1 + xen/include/xen/dom0less-build.h | 7 +++++++ 8 files changed, 13 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 0adfa4993a8f..2af780512540 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -25,8 +25,6 @@ struct map_range_data struct rangeset *irq_ranges; }; -extern domid_t max_init_domid; - void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); size_t estimate_efi_size(unsigned int mem_nr_banks); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 6310a47d68b6..86532d0a35b6 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -62,8 +62,6 @@ struct cpuinfo_arm __read_mostly system_cpuinfo; bool __read_mostly acpi_disabled; #endif -domid_t __read_mostly max_init_domid; - static __used void noreturn init_done(void) { /* Must be done past setting system_state. */ diff --git a/xen/arch/ppc/include/asm/setup.h b/xen/arch/ppc/include/asm/setup.h index e4f64879b68c..956fa6985adb 100644 --- a/xen/arch/ppc/include/asm/setup.h +++ b/xen/arch/ppc/include/asm/setup.h @@ -1,6 +1,4 @@ #ifndef __ASM_PPC_SETUP_H__ #define __ASM_PPC_SETUP_H__ -#define max_init_domid (0) - #endif /* __ASM_PPC_SETUP_H__ */ diff --git a/xen/arch/riscv/include/asm/setup.h b/xen/arch/riscv/include/asm/setup.h index 2215894cfbb1..73ce2f293348 100644 --- a/xen/arch/riscv/include/asm/setup.h +++ b/xen/arch/riscv/include/asm/setup.h @@ -5,8 +5,6 @@ #include -#define max_init_domid (0) - void setup_mm(void); void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index b01e83a8ed9f..5925c5f39cff 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -68,6 +68,4 @@ extern bool opt_dom0_verbose; extern bool opt_dom0_cpuid_faulting; extern bool opt_dom0_msr_relaxed; -#define max_init_domid (0) - #endif diff --git a/xen/common/domid.c b/xen/common/domid.c index b0258e477c1a..cd46cf952be6 100644 --- a/xen/common/domid.c +++ b/xen/common/domid.c @@ -9,6 +9,11 @@ */ #include +#include + +#ifdef CONFIG_DOM0LESS_BOOT +domid_t __ro_after_init max_init_domid; +#endif static DEFINE_SPINLOCK(domid_lock); static DECLARE_BITMAP(domid_bitmap, DOMID_FIRST_RESERVED); diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index ea4e3ff34178..4c735cc04c67 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include diff --git a/xen/include/xen/dom0less-build.h b/xen/include/xen/dom0less-build.h index 4118dec76c0a..8d4da16d1f0a 100644 --- a/xen/include/xen/dom0less-build.h +++ b/xen/include/xen/dom0less-build.h @@ -5,6 +5,8 @@ #include +#include + struct domain; #ifdef CONFIG_DOM0LESS_BOOT @@ -13,6 +15,9 @@ struct boot_domain; struct dt_device_node; struct kernel_info; +/* Highest domain ID assigned to a boot-time (dom0less) domain. */ +extern domid_t max_init_domid; + /* * List of possible features for dom0less domUs * @@ -72,6 +77,8 @@ static inline bool is_dom0less_mode(void) } static inline void set_xs_domain(struct domain *d) {} +#define max_init_domid 0 + #endif /* CONFIG_DOM0LESS_BOOT */ #endif /* __ASM_GENERIC_DOM0LESS_BUILD_H__ */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382264.1625629 (Exim 4.92) (envelope-from ) id 1wrHNT-0007OD-8s; Tue, 04 Aug 2026 15:48:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382264.1625629; Tue, 04 Aug 2026 15:48:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNT-0007Nn-3o; Tue, 04 Aug 2026 15:48:27 +0000 Received: by outflank-mailman (input) for mailman id 1382264; Tue, 04 Aug 2026 15:48:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNR-0007Jx-N4 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNR-009QIN-3r for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:25 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209be-e002-0a2a0a5209dd-0a2a45019e90-12 for ; Tue, 04 Aug 2026 17:48:24 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209c3-5984-0a2a45010019-d155802eb5f8-3 for ; Tue, 04 Aug 2026 17:48:19 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49557167508so30589855e9.1 for ; Tue, 04 Aug 2026 08:48:19 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858499; x=1786463299; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o7cNA0aHmLQVev9D/olk7PT2DhodkPFOY5f8VX+59pM=; b=dmWnQZo5Or7MRVLwxgJ/DupYW4q392r8kLcL0g+zRkYKBeA/WkUkZu1VcF13TLyg3D g5CIOvYcgXHUpgQKZPXoJgQ7VEM5nMAsIvOsBG074qIw74WEdcixztfOCaBsWXj+IYWv qjnaq502QKcPJ9UebV7hTwptKZj2GdII3evo1cHTdePmSaxRxUin8+E9DU4Z1Tgv/s8f ps9JBPczNom4ckhMXRzVrWPUSWiJUiDI4RlJxcRMxnLkDpuOJblOPND26E5zIUeN4VN7 W44xCwVD998BcorEvVtwoG38kcQCy7yFTG6aiELDRBLg41+Cq5SDzSP6VDg4ud79L5zf shuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858499; x=1786463299; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=o7cNA0aHmLQVev9D/olk7PT2DhodkPFOY5f8VX+59pM=; b=WLrLQlW/7QB0TiX+TE0VyfVj4x1XLVwQTxiZc3WD+F6lKMgvg0kgQMzZkQJDcDLxBG AEpCLfEDqTbGZwi7BPgaa4O2fVgiDdqQddLtSs7I3G8+fiTLmkW4VRWCUs/uPSKm09/H /2sp7e17bPOvAwB3Cg2xkz2p7DRtsjtTpu3E/brokcCxDQlLwEDex37b7E4k1KjhFV/1 2nBqRKkTzETOj7rh9w7tHQY90IxJhwNdE7Ye3APT2f+fh07F2WEeyTmuaEi+tdXU9Ux8 uLunV7wkIA3jF3zeeV3Pp1vWmXiszA29S6JI626WEWNn/Rfo64UBu+upyABOMeTa97xj HBPw== X-Gm-Message-State: AOJu0YzMJ2q1W+qodhMz6llCNWMoYFI8AJni4Fm/dVF86vSqk6ZkSqF/ SYbaFoGBH7WSUD/gux+iK/Bl4liV88KaYmkHBAGObG2ePXxuUa+GTUw+UN1dFw== X-Gm-Gg: AR+sD11MA3lz9Fmicg/476+ZAqJbU4m2t/Br7vj0jnAC8heiUBBxWMuMWUf07QFfQPS dzYJ6CB50ZEyEP+MftDSHfM02gJjsPDx890qmXeRjioRfssBqtnfoATsVDik2sV8y6ma5oK17GA liW/j7ULqX9lx6MkBepla15RK+TzNhh9vcrWiIAvs+C9o8/pZ+3Lw9joMwTAhhT6wpg7nQwnjyw U8YW5poRvevG8v0xP0Tr/VZXc5bIEEGJw4wMl7EDogJgLOZHerh3BYRydQ8Ks4F+8zjgdZkx/5u hPNLys6intytTJ2rwO0VC08a46j8FBvjImPC5CQyoOQCIELSMukJcF88lMFesFWLxnXIFY/nJ80 so4oMU1wi1Qve900QfrhShjNksadjrR9LBD7StPmBLXZhU9+j3BqgH0VxzObP4FLriNv73W49Qm cu9TzFhqQx37lT1ImKFRdHMwE2OXjgkcZZp4R/QNZPcicipz/21ELzh6DZWY4TM3RlHIXMv983m lqr3CWPLyM3Ju4pdIeUJnmFhrZf+QrrAhjEFaLlrB8q X-Received: by 2002:a05:600c:c8c:b0:495:5045:39e6 with SMTP id 5b1f17b1804b1-4980c664d68mr287612735e9.17.1785858499102; Tue, 04 Aug 2026 08:48:19 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Timothy Pearson , Alistair Francis , Connor Davis , "Daniel P. Smith" Subject: [PATCH v7 00/20] Introduce enablemenant of dom0less Date: Tue, 4 Aug 2026 17:47:50 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1785858499-1D073757-18158D8C/10/73395122804 X-purgate-type: spam X-purgate-size: 6195 This patch series reprensent a bunch of patches necessary to enable common part of Dom0less. The stuff necessary to start/launch domains will be introduced separately. CI tests: https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/2729854543 --- Changes in v7: - Merged to upstream/staging: - xen/riscv: Implement ARCH_PAGING_MEMPOOL - xen: arm: update p2m_set_allocation() prototype - xen/riscv: do a 4th linking pass if necessary - Address the comments from ML. --- Changes in v6: - Merged to upstream/staging: - xen: arm: move declaration of map_device_irqs_to_domain() to common header - xen/Kconfig: introduce HAS_STATIC_MEMORY - xen/riscv: rename enum intc_version to intc_variant - xen/riscv: implement prerequisites for domain_create() - Move UBSAN fix ("xen: introduce CONFIG_HAS_SHARED_INFO for archs without a shared page") to this patch series as it is connected to "xen/Kconfig: introduce HAS_STATIC_MEMORY". - Address the comments from ML. --- Changes in v5: - Add new patch (xen/riscv: do a 4th linking pass if necessary) which fixes randconfig job issue. - Address comments from ML. --- Changes in v4: - Address comments from ML. --- Changes in v3: - Drop dependency from other patch series ([1] https://lore.kernel.org/xen-devel/cover.1778140240.git.oleksii.kurochko@gmail.com/T/#t) as it was merged. - Reorder patches: - move common patches to the start. - Move some patches to separate patch series (will be introduced later) - Address comments from ML. --- Changes in v2: - Move patch "[PATCH v1 04/27] xen/riscv: rework G-stage mode handling" to patch series [1] - Address the comments from ML. - The following patches were folded into one: # xen/riscv: implement init_intc_phandle() # xen/riscv: call do_initcalls() in start_xen() # xen/riscv: setup system domains - The following patch were folded into one: # xen/riscv: add vaplic access check # xen/riscv: emulate guest writes to virtual APLIC MMIO # xen/riscv: emulate guest reads from virtual APLIC MMIO - Add new bug fix, not really necessary to this patch series: xen/riscv: manage IRQ_DISABLED flag in APLIC irq enable/disable callbacks --- Oleksii Kurochko (20): xen: introduce CONFIG_HAS_SHARED_INFO for archs without a shared page xen/dom0less: turn max_init_domid into a common variable xen/riscv: Implement construct_domain() xen/riscv: introduce guest riscv,isa string xen/riscv: implement make_cpus_node() xen/riscv: implement make_timer_node() xen/riscv: implement make_arch_nodes() xen/riscv: introduce init interrupt controller operations xen/riscv: implement make_intc_domU_node() xen/riscv: introduce aia_init() and aia_usable() xen/riscv: introduce per-vCPU IMSIC state xen/riscv: introduce minimal virtual APLIC (vAPLIC) infrastructure xen/riscv: introduce (de)initialization helpers for vINTC xen/riscv: generate IMSIC DT node for guest domains xen/riscv: create APLIC DT node for guest domains xen/riscv: implement IRQ routing for device passthrough xen/riscv: implement init_intc_phandle() xen/riscv: initialize RCU, scheduler, and system domains in start_xen() xen/riscv: provide init_vuart() xen/riscv: add initial dom0less infrastructure support xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/setup.h | 2 - xen/arch/arm/setup.c | 2 - xen/arch/ppc/include/asm/setup.h | 2 - xen/arch/riscv/Kconfig | 2 + xen/arch/riscv/Makefile | 4 + xen/arch/riscv/aia.c | 23 +++ xen/arch/riscv/aplic-priv.h | 13 ++ xen/arch/riscv/aplic.c | 14 +- xen/arch/riscv/cpufeature.c | 171 +++++++++++++--- xen/arch/riscv/device.c | 94 +++++++++ xen/arch/riscv/dom0less-build.c | 40 ++++ xen/arch/riscv/domain-build.c | 192 ++++++++++++++++++ xen/arch/riscv/domain.c | 16 +- xen/arch/riscv/imsic.c | 178 ++++++++++++++++- xen/arch/riscv/include/asm/aia.h | 10 + xen/arch/riscv/include/asm/aplic.h | 15 ++ xen/arch/riscv/include/asm/cpufeature.h | 5 + xen/arch/riscv/include/asm/domain.h | 7 + xen/arch/riscv/include/asm/guest-layout.h | 24 +++ xen/arch/riscv/include/asm/imsic.h | 25 +++ xen/arch/riscv/include/asm/intc.h | 44 ++++- xen/arch/riscv/include/asm/irq.h | 5 + xen/arch/riscv/include/asm/setup.h | 2 - xen/arch/riscv/include/asm/vaplic.h | 34 ++++ xen/arch/riscv/intc.c | 102 +++++++++- xen/arch/riscv/irq.c | 226 ++++++++++++++++++++++ xen/arch/riscv/setup.c | 12 ++ xen/arch/riscv/vaplic.c | 148 ++++++++++++++ xen/arch/x86/Kconfig | 1 + xen/arch/x86/include/asm/setup.h | 2 - xen/common/Kconfig | 3 + xen/common/Makefile | 2 +- xen/common/domain.c | 6 +- xen/common/domctl.c | 4 + xen/common/domid.c | 5 + xen/common/event_channel.c | 53 ++++- xen/common/event_channel.h | 6 + xen/common/event_fifo.c | 19 +- xen/common/time.c | 2 + xen/drivers/char/console.c | 1 + xen/include/xen/dom0less-build.h | 7 + xen/include/xen/sched.h | 2 + xen/include/xen/shared.h | 8 +- xen/include/xen/time.h | 4 + 45 files changed, 1478 insertions(+), 60 deletions(-) create mode 100644 xen/arch/riscv/aia.c create mode 100644 xen/arch/riscv/device.c create mode 100644 xen/arch/riscv/domain-build.c create mode 100644 xen/arch/riscv/include/asm/aia.h create mode 100644 xen/arch/riscv/include/asm/vaplic.h create mode 100644 xen/arch/riscv/vaplic.c -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382261.1625607 (Exim 4.92) (envelope-from ) id 1wrHNP-0006uX-Bk; Tue, 04 Aug 2026 15:48:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382261.1625607; Tue, 04 Aug 2026 15:48:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNP-0006uP-8L; Tue, 04 Aug 2026 15:48:23 +0000 Received: by outflank-mailman (input) for mailman id 1382261; Tue, 04 Aug 2026 15:48:22 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNO-0006uD-8C for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNN-009Gcw-9j for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:21 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209b7-bab6-0a2a0a5309dd-0a2a4505e25a-20 for ; Tue, 04 Aug 2026 17:48:21 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209c5-4cb1-0a2a45050019-d155802cd0a8-3 for ; Tue, 04 Aug 2026 17:48:21 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-495757ccbc1so33610805e9.2 for ; Tue, 04 Aug 2026 08:48:21 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858501; x=1786463301; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s2giNu/4S6jw/BG8lbsrBR4JasbJ4ALaPWnt21NbdkI=; b=WATOEZxONXg73Qtji13WhyZ7hCo7PQR4uWDhWB3FgXl2npZw1+dwocSRcNPOzoGwak a4IsN9RQemtkaLND9SVcpV24XmtvxYaCccrqzNOS9sF7HgFYrvckN3zSS+XsCh8oVjSo /82VrDQTviISxVytTN5GBk7taRFhtuv6dClyFKnt18qj6MLwiL3F0qI3Dsv0KLdIZanY iIPy1pl3/HYyoKNeHqY7ueyTWyWiLm6IJQAqG/fN/kPl/kAOYKZ9QD7f8ajFIXciwPxv rW2sGPwFVoLTVQqLv7gj9pdaBg7LRy9T+Xyo952v9TKyq4rrTlL/+wofYqEtBa/grcHe g55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858501; x=1786463301; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=s2giNu/4S6jw/BG8lbsrBR4JasbJ4ALaPWnt21NbdkI=; b=XTFRYRP228BZSGpG+DKz/TNVMrKRPU6NerRmmpGxfIWpGAyMcgU0yQkNveaNcse3jZ OUjsyo/+/HpJZGJnEC/4wkozKN0F7mRxnJq5cDOdHVutt5kWO34+s2Gb1i3hMD6CkVjl DvkEi10P7LVy2iNH0bW8p3e/luPwltEONZiQcKK3s2YxqBRKS19DhYzuYsYH9c/VKz7m uavlZBybHQevH7qXc31QZc6CJpL0wLYdmsDhA9bhgY1Epsqx69V1ngZtMLdM36A2Hxm1 0oa/+r4lgex/NinKfZqXiZx+wmTbF5w0o4d9IfSTkcoCyWNYQEdaHCFO5xjDtJlX97Dl 0ZTQ== X-Gm-Message-State: AOJu0YzY1GbxvjYC9nl0eA03fAYLJmB4dO8hOI+dJ+u8NLr71vURgiIG b4KWOY/nIK0aPuolW1xl1MwzfXtcaCcAb+U1wBbZSI3luLvbAw6+a2ym/vFoOA== X-Gm-Gg: AR+sD13F9ihAZu4St0THtNU/pJ1ZIkHjFWPefAF40o/Iqkx2IgmRQSoHmLgRS2+9+bD i2CtgKNqga/cNTwPV0ogbdwg14hF9p57NxU7aCLvATyzpSqwIEV+YMv6yl+zvKB6s/N1zCSdzWA 3FTK1TZ7i4OZNxw5lEabRgq1HSmNN/MwhANcq9FZRQ+IY84bI20l/Os+KJT634udbRTNBoTeMg6 RUe58tUDV1LkDhY9cqa5bzpmQ4Q7YOPitgyzOwvpZV2XaQP5do09+BQ468Hxwwct9O4cUBDAwZe eXKeM7+aEPfcMawFugBUWIL85pL7PWjUROU7S4PAa1/fzWxUcl5oPXsl7khSpnTUUNW7uZZOOSb 8PnyjdG3vZFyKFtB3L8EbS33IuouNS5EpVoJWUvIzrNmDBo2TrL96fn4Ih+iP+JgXrvj2sKM3Wf Vv5w1UaHQISSsToB2bnZ19gDfkxP4HIdiUfpGBKQLjqImOIIQEFuVwbbd36BZD1zsG8gmz7Q8UN x1OC+2TORrM5rwfaQKmqLwFKxYbyM2jlw== X-Received: by 2002:a05:600c:840f:b0:496:c379:b2a1 with SMTP id 5b1f17b1804b1-4980c66d7bbmr299592255e9.2.1785858500271; Tue, 04 Aug 2026 08:48:20 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH v7 01/20] xen: introduce CONFIG_HAS_SHARED_INFO for archs without a shared page Date: Tue, 4 Aug 2026 17:47:51 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1785858501-F68B62A1-243AE8C1/10/73395122804 X-purgate-type: spam X-purgate-size: 18652 On architectures that run guests in dom0less mode without the PV ABI (currently RISC-V), no shared_info page is allocated and d->shared_info remains NULL throughout the domain lifetime. Several places in common code access d->shared_info through the shared_info() macro or directly, causing UBSAN null-pointer errors on such architectures. Rather than adding runtime NULL guards that are logically unreachable on x86 and Arm (where shared_info is always allocated), introduce a new Kconfig symbol CONFIG_HAS_SHARED_INFO selected by x86 and Arm. On !HAS_SHARED_INFO the shared_info() macro expands to a dereference of shared_info_absent, an extern pointer that is declared but intentionally never defined. Any use of shared_info() that is not dead-code-eliminated will therefore cause a link-time failure, making missed guards impossible to overlook. The 2L event-channel ops call shared_info() and must not be compiled on architectures without a shared_info page, so event_2l.o is gated on CONFIG_HAS_SHARED_INFO. On such architectures evtchn_init() installs the FIFO ops as a placeholder instead, so that a later guest opt-in to the FIFO ABI via EVTCHNOP_init_control has no special-casing to do; if FIFO support itself is also unavailable (!CONFIG_EVTCHN_FIFO), a dedicated no-op evtchn_port_ops_none table is installed instead, so that d->evtchn_port_ops is never NULL. evtchn_fifo_word_from_port() is guarded against uninitialised d->evtchn_fifo so the FIFO ops are safe before evtchn_fifo_init_control() is called by the guest. With CONFIG_HAS_SHARED_INFO=n all vCPUs fall back to the global dummy_vcpu_info, so writes through vcpu_info() could leak data between vCPUs. Reviewing the write paths in common code: the write in map_guest_area() stores the constant ~0 so nothing serious would happen if it were leaked; the event_2l.c paths are not compiled on !HAS_SHARED_INFO, as event_2l.o is gated on CONFIG_HAS_SHARED_INFO; the write in vcpu_info_populate() targets the new mapping buffer, not dummy_vcpu_info. Outside common code, the remaining writes are x86 PV-specific, for which CONFIG_HAS_SHARED_INFO=y. No code changes are needed. Finally, struct domain's shared_info field itself is gated on CONFIG_HAS_SHARED_INFO, as it would otherwise be a permanently NULL pointer: every user of it is either arch code for an architecture that selects HAS_SHARED_INFO, or common code already guarded by the same Kconfig symbol. Signed-off-by: Oleksii Kurochko --- Changes in v7: - domctl.c: use a plain #ifdef CONFIG_HAS_SHARED_INFO / #else instead of the IS_ENABLED() if/else in getdomaininfo(), and set info->shared_info_frame to ~0 in the !HAS_SHARED_INFO case. - sched.h: drop struct domain's shared_info field when !HAS_SHARED_INFO, rather than keeping a field that can only ever be NULL there. All of its users are either in arch code selecting HAS_SHARED_INFO or already guarded by CONFIG_HAS_SHARED_INFO, so no further changes are needed. Update the commit message accordingly. --- Changes in v6: - s/INVALID_GFN_RAW/gfn_x(INVALID_GFN) as INVALID_GFN_RAW was dropped. - event_channel.c: make evtchn_none_init() static, moving the evtchn_port_ops_none table and its definition above evtchn_reset(), their first caller; move the leftover prototype into the #else arm of the same #ifndef guard instead of leaving it as a free-standing non-static declaration. - event_channel.c: evtchn_reset() now follows the same IS_ENABLED(CONFIG_HAS_SHARED_INFO) / IS_ENABLED(CONFIG_EVTCHN_FIFO) / else cascade already used by evtchn_init(), rather than assuming the FIFO ABI is unconditionally available whenever d->evtchn_fifo was set. - event_channel.c: narrow the evtchn_port_ops_none / evtchn_none_init guard from !CONFIG_HAS_SHARED_INFO to !CONFIG_HAS_SHARED_INFO && !CONFIG_EVTCHN_FIFO, so the placeholder cf_check functions are only built for the one combination that actually needs them. - event_channel.c: fix the evtchn_port_ops_none comment, which claimed the ops were never reachable in practice; they are reached whenever an event is delivered to (or queried on) a !HAS_SHARED_INFO && !EVTCHN_FIFO domain, they just have no ABI to record it in and discard it. - event_channel.h / event_fifo.c: drop the static inline evtchn_fifo_init_ops() stub for !CONFIG_EVTCHN_FIFO; a plain declaration outside the #ifdef/#else is enough, matching the treatment already given to evtchn_2l_init() and evtchn_none_init(). Update the "only call site" comment in event_fifo.c to mention both evtchn_init() and evtchn_reset(). --- Changes in v5: - drop the static inline evtchn_2l_init() stub for !HAS_SHARED_INFO; a plain declaration is enough since the only call sites are guarded by IS_ENABLED(CONFIG_HAS_SHARED_INFO) and the dead call is eliminated before linking. - fix a NULL d->evtchn_port_ops dereference when CONFIG_HAS_SHARED_INFO=n and CONFIG_EVTCHN_FIFO=n: evtchn_init() was unconditionally calling evtchn_fifo_init_ops(), whose !EVTCHN_FIFO stub leaves d->evtchn_port_ops unset. Gate the FIFO branch on IS_ENABLED(CONFIG_EVTCHN_FIFO) and add a dedicated evtchn_port_ops_none table for the remaining case. Stubs are shared where signatures permit: evtchn_none_noop covers both clear_pending and unmask; evtchn_none_false covers both is_pending and is_masked. evtchn_none_init() is called only from event_channel.c, so its declaration is kept there rather than in event_channel.h. - gate evtchn_fifo_init_ops() on !CONFIG_HAS_SHARED_INFO; its only call site is in the IS_ENABLED(CONFIG_EVTCHN_FIFO) dead branch of evtchn_init(), which is never reached on HAS_SHARED_INFO=y builds. --- Changes in v4: - event_channel.c: drop the redundant evtchn_fifo_init_ops() in the else branch of evtchn_reset(); evtchn_fifo_destroy() does not undo the ops installed by evtchn_init(), so only the switch back to 2-level ABI needs an explicit call. - shared.h: simplify the !HAS_SHARED_INFO shared_info() definition to use an undefined "extern struct shared_info *shared_info_absent" instead of shared_info_absent() with a typeof cast. - Extend the commit description to note that vcpu_info()/__vcpu_info() uses were also audited: on !HAS_SHARED_INFO vcpu_info_area.map points at dummy_vcpu_info, reads are harmless, and writes in common code do not open a cross-domain info-leak side channel, so no code changes are needed on that path. --- Changes in v3: - Introduce CONFIG_HAS_SHARED_INFO Kconfig symbol selected by x86 and Arm; RISC-V does not select it. - Gate shared_info() macro on CONFIG_HAS_SHARED_INFO; on !HAS_SHARED_INFO it calls shared_info_absent() (declared, never defined) so any unguarded use produces a link-time error. - Replace runtime if (!d->shared_info) guards with IS_ENABLED() at call sites so both branches type-check and dead code is eliminated. - Guard shared_info_frame assignment in domctl.c. - Gate event_2l.o on CONFIG_HAS_SHARED_INFO; use FIFO ops as placeholder on !HAS_SHARED_INFO archs instead of dedicated stub ops; guard evtchn_fifo_word_from_port() against uninitialised d->evtchn_fifo. - Add static inline stubs for evtchn_2l_init() (!HAS_SHARED_INFO) and evtchn_fifo_init_ops() (!EVTCHN_FIFO) so call sites can use IS_ENABLED() without #ifdef. - Drop inaccurate changelog entry about "only FIFO ABI" migration. - Update the commit message. - Drop R-by: Baptiste ... as some extra checks are added. --- Changes in v2: - Update commit message + subject. - Drop Fixes tag. --- xen/arch/arm/Kconfig | 1 + xen/arch/x86/Kconfig | 1 + xen/common/Kconfig | 3 +++ xen/common/Makefile | 2 +- xen/common/domain.c | 6 ++--- xen/common/domctl.c | 4 +++ xen/common/event_channel.c | 53 +++++++++++++++++++++++++++++++++++--- xen/common/event_channel.h | 6 +++++ xen/common/event_fifo.c | 19 +++++++++++++- xen/common/time.c | 2 ++ xen/include/xen/sched.h | 2 ++ xen/include/xen/shared.h | 8 +++++- xen/include/xen/time.h | 4 +++ 13 files changed, 102 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 843a43897e7b..d748404e82da 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -20,6 +20,7 @@ config ARM select HAS_DEVICE_TREE_DISCOVERY select HAS_DOM0LESS select HAS_GRANT_CACHE_FLUSH if GRANT_TABLE + select HAS_SHARED_INFO select HAS_STACK_PROTECTOR select HAS_STATIC_MEMORY select HAS_UBSAN diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 3ce0774b8d76..e5535ac48467 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -29,6 +29,7 @@ config X86 select HAS_PCI_MSI select HAS_PIRQ select HAS_SCHED_GRANULARITY + select HAS_SHARED_INFO imply HAS_SOFT_RESET select HAS_UBSAN select HAS_VMAP diff --git a/xen/common/Kconfig b/xen/common/Kconfig index da80fdba8469..5b289e444fa5 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -158,6 +158,9 @@ config HAS_PMAP config HAS_SCHED_GRANULARITY bool +config HAS_SHARED_INFO + bool + config HAS_STATIC_MEMORY bool diff --git a/xen/common/Makefile b/xen/common/Makefile index 6018e256147f..f69d47d18934 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -12,7 +12,7 @@ obj-$(CONFIG_DEVICE_TREE_PARSE) += device-tree/ obj-$(CONFIG_IOREQ_SERVER) += dm.o obj-y += domain.o obj-y += domid.o -obj-y += event_2l.o +obj-$(CONFIG_HAS_SHARED_INFO) += event_2l.o obj-y += event_channel.o obj-$(CONFIG_EVTCHN_FIFO) += event_fifo.o obj-$(CONFIG_GRANT_TABLE) += grant_table.o diff --git a/xen/common/domain.c b/xen/common/domain.c index e16f1ac38396..6b52713518da 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -316,9 +316,9 @@ void vcpu_info_reset(struct vcpu *v) struct domain *d = v->domain; v->vcpu_info_area.map = - ((v->vcpu_id < XEN_LEGACY_MAX_VCPUS) - ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id]) - : &dummy_vcpu_info); + IS_ENABLED(CONFIG_HAS_SHARED_INFO) && v->vcpu_id < XEN_LEGACY_MAX_VCPUS + ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id]) + : &dummy_vcpu_info; } static struct domain *alloc_domain_struct(void) diff --git a/xen/common/domctl.c b/xen/common/domctl.c index a6210db4fb97..83405a766a54 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -102,9 +102,13 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) #ifdef CONFIG_MEM_PAGING info->paged_pages = atomic_read(&d->paged_pages); #endif +#ifdef CONFIG_HAS_SHARED_INFO info->shared_info_frame = gfn_x(mfn_to_gfn(d, _mfn(virt_to_mfn(d->shared_info)))); BUG_ON(SHARED_M2P(info->shared_info_frame)); +#else + info->shared_info_frame = ~0; +#endif info->cpupool = cpupool_get_id(d); diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index a7f9cc5fe0ac..0911808fe861 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -40,6 +40,41 @@ #define consumer_is_xen(e) (!!(e)->xen_consumer) +#if !defined(CONFIG_HAS_SHARED_INFO) && !defined(CONFIG_EVTCHN_FIFO) +/* + * Placeholder ops for domains with neither a shared_info page nor a FIFO + * control block (CONFIG_HAS_SHARED_INFO=n and CONFIG_EVTCHN_FIFO=n). Such + * a domain has no ABI to record event state in, so these are reachable + * whenever an event is delivered to (or queried on) one of its ports; they + * just discard/no-op it. They exist to keep d->evtchn_port_ops non-NULL. + */ +static void cf_check evtchn_none_set_pending( + struct vcpu *v, struct evtchn *evtchn) {} +static void cf_check evtchn_none_noop( + struct domain *d, struct evtchn *evtchn) {} +static bool cf_check evtchn_none_false( + const struct domain *d, const struct evtchn *evtchn) { return false; } +static void cf_check evtchn_none_print_state( + struct domain *d, const struct evtchn *evtchn) {} + +static const struct evtchn_port_ops evtchn_port_ops_none = { + .set_pending = evtchn_none_set_pending, + .clear_pending = evtchn_none_noop, + .unmask = evtchn_none_noop, + .is_pending = evtchn_none_false, + .is_masked = evtchn_none_false, + .print_state = evtchn_none_print_state, +}; + +static void evtchn_none_init(struct domain *d) +{ + d->evtchn_port_ops = &evtchn_port_ops_none; +} +#else +/* Declaration only; the calls below are DCE'd unless both configs are off. */ +void evtchn_none_init(struct domain *d); +#endif /* !CONFIG_HAS_SHARED_INFO && !CONFIG_EVTCHN_FIFO */ + /* * Lock an event channel exclusively. This is allowed only when the channel is * free or unbound either when taking or when releasing the lock, as any @@ -1324,9 +1359,15 @@ int evtchn_reset(struct domain *d, bool resuming) rc = -EAGAIN; else if ( d->evtchn_fifo ) { - /* Switching back to 2-level ABI. */ evtchn_fifo_destroy(d); - evtchn_2l_init(d); + + if ( IS_ENABLED(CONFIG_HAS_SHARED_INFO) ) + /* Switching back to 2-level ABI. */ + evtchn_2l_init(d); + else if ( IS_ENABLED(CONFIG_EVTCHN_FIFO) ) + evtchn_fifo_init_ops(d); + else + evtchn_none_init(d); } write_unlock(&d->event_lock); @@ -1625,7 +1666,13 @@ void evtchn_check_pollers(struct domain *d, unsigned int port) int evtchn_init(struct domain *d, unsigned int max_port) { - evtchn_2l_init(d); + if ( IS_ENABLED(CONFIG_HAS_SHARED_INFO) ) + evtchn_2l_init(d); + else if ( IS_ENABLED(CONFIG_EVTCHN_FIFO) ) + evtchn_fifo_init_ops(d); + else + evtchn_none_init(d); + d->max_evtchn_port = min_t(unsigned int, max_port, INT_MAX); d->evtchn = alloc_evtchn_bucket(d, 0); diff --git a/xen/common/event_channel.h b/xen/common/event_channel.h index dc94a43cc2dd..c8ee09807008 100644 --- a/xen/common/event_channel.h +++ b/xen/common/event_channel.h @@ -70,6 +70,12 @@ static inline void evtchn_fifo_destroy(struct domain *d) } #endif /* CONFIG_EVTCHN_FIFO */ +/* + * Declaration only when !CONFIG_EVTCHN_FIFO; the (dead) calls in + * evtchn_init() and evtchn_reset() are DCE'd in that case. + */ +void evtchn_fifo_init_ops(struct domain *d); + #endif /* EVENT_CHANNEL_H */ /* diff --git a/xen/common/event_fifo.c b/xen/common/event_fifo.c index 611bf8a78801..3b6e619c5278 100644 --- a/xen/common/event_fifo.c +++ b/xen/common/event_fifo.c @@ -62,6 +62,9 @@ static inline event_word_t *evtchn_fifo_word_from_port(const struct domain *d, */ smp_rmb(); + if ( unlikely(!d->evtchn_fifo) ) + return NULL; + if ( unlikely(port >= d->evtchn_fifo->num_evtchns) ) return NULL; @@ -419,6 +422,19 @@ static const struct evtchn_port_ops evtchn_port_ops_fifo = .print_state = evtchn_fifo_print_state, }; +/* + * evtchn_fifo_init_ops()'s only call sites are in the + * IS_ENABLED(CONFIG_EVTCHN_FIFO) dead branches of evtchn_init() and + * evtchn_reset(), which are never reached on HAS_SHARED_INFO=y builds + * because of DCE. + */ +#ifndef CONFIG_HAS_SHARED_INFO +void evtchn_fifo_init_ops(struct domain *d) +{ + d->evtchn_port_ops = &evtchn_port_ops_fifo; +} +#endif + static int map_guest_page(struct domain *d, uint64_t gfn, void **virt) { struct page_info *p; @@ -561,7 +577,8 @@ static void setup_ports(struct domain *d, unsigned int prev_evtchns) evtchn = evtchn_from_port(d, port); - if ( guest_test_bit(d, port, &shared_info(d, evtchn_pending)) ) + if ( IS_ENABLED(CONFIG_HAS_SHARED_INFO) && + guest_test_bit(d, port, &shared_info(d, evtchn_pending)) ) evtchn->pending = true; evtchn_fifo_set_priority(d, evtchn, EVTCHN_FIFO_PRIORITY_DEFAULT); diff --git a/xen/common/time.c b/xen/common/time.c index 04a65f00b35c..cdfdc53b6a17 100644 --- a/xen/common/time.c +++ b/xen/common/time.c @@ -89,6 +89,7 @@ struct tm gmtime(unsigned long t) return tbuf; } +#ifdef CONFIG_HAS_SHARED_INFO void update_domain_wallclock_time(struct domain *d) { uint32_t *wc_version; @@ -117,6 +118,7 @@ void update_domain_wallclock_time(struct domain *d) spin_unlock(&wc_lock); } +#endif /* CONFIG_HAS_SHARED_INFO */ /* Set clock to after 00:00:00 UTC, 1 January, 1970. */ void do_settime(u64 secs, unsigned int nsecs, u64 system_time_base) diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index eef10c2ea2c0..53ba5ed8c257 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -404,7 +404,9 @@ struct domain struct vcpu **vcpu; +#ifdef CONFIG_HAS_SHARED_INFO shared_info_t *shared_info; /* shared data area */ +#endif rcu_read_lock_t rcu_lock; diff --git a/xen/include/xen/shared.h b/xen/include/xen/shared.h index 5b71342cab32..f20a46801181 100644 --- a/xen/include/xen/shared.h +++ b/xen/include/xen/shared.h @@ -43,7 +43,13 @@ typedef struct vcpu_info vcpu_info_t; extern vcpu_info_t dummy_vcpu_info; -#define shared_info(d, field) __shared_info(d, (d)->shared_info, field) +#ifdef CONFIG_HAS_SHARED_INFO +#define shared_info(d, field) __shared_info(d, (d)->shared_info, field) +#else +extern struct shared_info *shared_info_absent; +#define shared_info(d, field) (((void)(d), shared_info_absent)->field) +#endif /* CONFIG_HAS_SHARED_INFO */ + #define vcpu_info(v, field) \ __vcpu_info(v, (vcpu_info_t *)(v)->vcpu_info_area.map, field) diff --git a/xen/include/xen/time.h b/xen/include/xen/time.h index e9c0822e6f31..2f872f580ffc 100644 --- a/xen/include/xen/time.h +++ b/xen/include/xen/time.h @@ -66,7 +66,11 @@ struct tm wallclock_time(uint64_t *ns); #define version_update_begin(v) (((v) + 1) | 1) #define version_update_end(v) ((v) + 1) extern void update_vcpu_system_time(struct vcpu *v); +#ifdef CONFIG_HAS_SHARED_INFO extern void update_domain_wallclock_time(struct domain *d); +#else +static inline void update_domain_wallclock_time(struct domain *d) {} +#endif extern void do_settime( u64 secs, unsigned int nsecs, u64 system_time_base); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382265.1625636 (Exim 4.92) (envelope-from ) id 1wrHNT-0007TP-Md; Tue, 04 Aug 2026 15:48:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382265.1625636; Tue, 04 Aug 2026 15:48:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNT-0007Qz-DD; Tue, 04 Aug 2026 15:48:27 +0000 Received: by outflank-mailman (input) for mailman id 1382265; Tue, 04 Aug 2026 15:48:26 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNS-0007KG-25 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNR-009GfZ-F6 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:25 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209b0-2eae-0a2a0a5409dd-0a2a450cd344-36 for ; Tue, 04 Aug 2026 17:48:25 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209c9-f479-0a2a450c0019-d1558032ad18-3 for ; Tue, 04 Aug 2026 17:48:25 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49558ce01afso26773375e9.1 for ; Tue, 04 Aug 2026 08:48:25 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858505; x=1786463305; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OtCr8wU2t2GJWhHJ8VA4gfjPYB+rOSURYzxYVnJJT30=; b=Ks6kTuoOKfbkOPaqFnIMGRYHtWGNOL5PZdg9hLvfUylqpaC5qVz3RP2x4Z42TI875k Tr0fppbdAUwUVq4zU186c3UBIfmr4SfvtbkEYhW9i747ytaEDADTB3Zrm0uX9QqBxaOZ 03sLgVZuj/bpLyFtHA4anvYHeScykWsh3YyHFBERcd8qvkn7+F59tg8yEbu3r0f34wcj jyi44PjNxZ6aTLVLMes5P8HFOt17xBJAzdA8S/BfmcsWiO8ZpWDEB7gkl0rxb31P6KW/ X85B3RHKeeCywUnzwLGwOuoc4Ag8rz0ARrhERHOg/vMEZyR5E99XyHkhkfwZ0dfyypPW pLRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858505; x=1786463305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OtCr8wU2t2GJWhHJ8VA4gfjPYB+rOSURYzxYVnJJT30=; b=Z2H/rPGbEDzOAUDuI2mdcOsL4DJyIPkD5lctirG02Rk5I9n539aV8sTYVXdBoraehx 9S3JyQQ2J+x9UpMpe2gPv8rd3Ii6IKj3Iye3HJxi9kJpN3iHu5uBl27vaQzMSFwKI0ED DiaS1KcuaSJf1NkB3l1uufHvNIfSxx5g7c/P49v0azjwPYmwm1NB83uxLL/aEL3mocCV pzytKDBf0dMnhZr1sq2kBp5TN8xVsJUaUqnHjc3XM+Uw3Zmn4ySeDlVm4e6JYH87rg3z 2gPPskBjM8rczrGqBJiV6qo93DdCXWj0jHdCHCIPJ+kvkys3tVIiBxhuJ7QDMr+txKQI WM+Q== X-Gm-Message-State: AOJu0YytdCqg9lxqVpAh8z0XXoYkBMByw/6oD6rhUKmVu81A+fXbJk2t BQHggT7S+Pbu6I/UY2lJiCakSZ4jmIB+jQMSJjCoEVp5xjTJ11I8Y/wZ556TmQ== X-Gm-Gg: AR+sD13GTTpOQ+AB0R1mea0O2+WUoMpx23LnsfC5CO0iKl9rC5aFhnGebZtxaKEEO5+ ArByreEMrbs6kpgn7UGY7Tfa9g2mYCWzStFEhNlv+qUzfMyIVOCgIiD23/p3pm850tSUZbBov5V Kv0VnoXSm05yPd/9VP9JKoRu21M9wtdCD115d2cf5hHz/+s+agMLsdEJkIX4hWfYP44d2SiohVW H6XLbRxHiDSXQVJwafpoeUFK13zPRWRQu5ksZg5J5UlI6jB2p1DI7sqyqb0d/TamCS2suscZ/qn qgMNqqV4Ol1V+xjy9qOnFy5FYOPsdl7s3Rz0ONLABPKMwGqJR8btPw070jdzd7ZpR9eebYE3aLc c2JgsJEv9Xp64uG+cb0RRZ4XrfESKCEJUEANotnBM7t4Yc7jW7jpFSb9GeVTSaQjxA4ZX1iV4Gd s5o9U0X0YEUIC2A20fmngOHjAx1Hb4k9ccFEm+JoC2qEEIIh2VNk9qCKZOvXUZvbcFdV3N3QOv6 StonN0onK+o+/1gZ/OCwPFxIXOsRaP72Q== X-Received: by 2002:a05:600c:c490:b0:494:596e:e8c4 with SMTP id 5b1f17b1804b1-4980c67d1cbmr317723855e9.17.1785858504857; Tue, 04 Aug 2026 08:48:24 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 05/20] xen/riscv: implement make_cpus_node() Date: Tue, 4 Aug 2026 17:47:55 +0200 Message-ID: <4df84f91703588ca55c2c0fa73cadb9f94437571.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1785858505-02CDBA5B-A8231C93/10/73395122804 X-purgate-type: spam X-purgate-size: 6049 Implement make_cpus_node() to create cpus node for a guest domain. This function is going to be use by common dom0less code during construction domain. Signed-off-by: Oleksii Kurochko --- Changes in v7: - use get_guest_isa_str() for the "riscv,isa" property instead of building the string per domain. - as a consequence, drop the isa_str/len local variables, the xvmalloc_array()/xvfree() pair and the inclusion; with no resource left to release, the error paths now return res directly and the "out" label is gone. - s/sizeof/ARRAY_SIZE for snprintf's argument. - Drop Acked-by: Jan B. as some changes were done so it would be nice if Jan B. will review them again. --- Changes in v6: - Update the two build_guest_isa_str() call sites for its new `const struct domain *d` signature. - Drop build/tools/fixdep from the patch. - Add Acked-by: Jan Beulich . --- Changes in v5: - Drop Acked-by: Jan Beulich as extra changes were done because of the changed in prev. patch. - Move isa_str allocation and construction out of arch_domain_create() and into make_cpus_node() as a local variable, since the string is only needed during FDT generation. Use a two-call build_guest_isa_str() pattern (size probe, then fill) with xvmalloc_array, and convert all post-allocation error returns to goto out so xvfree() runs on every path. --- Changes in v4: - Update the comment in make_cpus_node() to match code style. - Add Acked-by: Jan Beulich . --- Changes in v3: - Add blank line above make_cpus_node() function definition. - Move 'unsigned int cpu' from function-level declarations into the for loop. - Drop 'uint32_t reg = cpu_to_fdt32(cpu)'; use fdt_property_cell(fdt, "reg", cpu) instead of fdt_property(fdt, "reg", ®, sizeof(reg)) so byte-order adjustment is handled internally. - Add matching /* interrupt-controller */ start comment; fix end comment to /* end interrupt-controller */. - Update d->arch.guest_isa_str to ->isa_str in make_cpus_node() function. --- Changes in v2: - s/u32/uint32_t for timebase_frequency local variable. - Drop +1 from BUILD_BUG_ON(). - return fdt_end_node(fdt); instead of res at the end of the function. --- --- xen/arch/riscv/domain-build.c | 106 ++++++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) diff --git a/xen/arch/riscv/domain-build.c b/xen/arch/riscv/domain-build.c index 5f6f4b6248a5..1af4c48fb30c 100644 --- a/xen/arch/riscv/domain-build.c +++ b/xen/arch/riscv/domain-build.c @@ -3,8 +3,10 @@ #include #include #include +#include #include +#include #include #include @@ -48,3 +50,107 @@ int __init construct_domain(struct domain *d, struct kernel_info *kinfo) return 0; } + +int __init make_cpus_node(const struct domain *d, struct kernel_info *kinfo) +{ + int res; + const struct dt_device_node *cpus = dt_find_node_by_path("/cpus"); + uint32_t timebase_frequency; + bool frequency_valid; + void *fdt = kinfo->fdt; + + dt_dprintk("Create cpus node\n"); + + if ( !cpus ) + { + dprintk(XENLOG_ERR, "Missing /cpus node in the device tree?\n"); + return -ENOENT; + } + + frequency_valid = dt_property_read_u32(cpus, "timebase-frequency", + &timebase_frequency); + + res = fdt_begin_node(fdt, "cpus"); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", 1); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#size-cells", 0); + if ( res ) + return res; + + if ( frequency_valid ) + res = fdt_property_cell(fdt, "timebase-frequency", timebase_frequency); + + for ( unsigned int cpu = 0; cpu < d->max_vcpus; cpu++ ) + { + char buf[64]; + + snprintf(buf, ARRAY_SIZE(buf), "cpu@%u", cpu); + res = fdt_begin_node(fdt, buf); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "reg", cpu); + if ( res ) + return res; + + res = fdt_property_string(fdt, "status", "okay"); + if ( res ) + return res; + + res = fdt_property_string(fdt, "compatible", "riscv"); + if ( res ) + return res; + + BUILD_BUG_ON((sizeof("riscv,") + + sizeof_field(struct gstage_mode_desc, name)) >= sizeof(buf)); + snprintf(buf, ARRAY_SIZE(buf), "riscv,%s", max_gstage_mode->name); + res = fdt_property_string(fdt, "mmu-type", buf); + if ( res ) + return res; + + res = fdt_property_string(fdt, "riscv,isa", get_guest_isa_str()); + if ( res ) + return res; + + res = fdt_property_string(fdt, "device_type", "cpu"); + if ( res ) + return res; + + /* Start of interrupt-controller */ + res = fdt_begin_node(fdt, "interrupt-controller"); + if ( res ) + return res; + + res = fdt_property_string(fdt, "compatible", "riscv,cpu-intc"); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#interrupt-cells", 1); + if ( res ) + return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if ( res ) + return res; + + res = fdt_property_u32(fdt, "phandle", alloc_phandle(kinfo)); + if ( res ) + return res; + + /* End of interrupt-controller */ + res = fdt_end_node(fdt); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return fdt_end_node(fdt); +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382263.1625625 (Exim 4.92) (envelope-from ) id 1wrHNS-0007L9-Ue; Tue, 04 Aug 2026 15:48:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382263.1625625; Tue, 04 Aug 2026 15:48:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNS-0007L2-Rt; Tue, 04 Aug 2026 15:48:26 +0000 Received: by outflank-mailman (input) for mailman id 1382263; Tue, 04 Aug 2026 15:48:25 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNR-0007Jq-FB for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNQ-009GfZ-SJ for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:24 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209a3-2eae-0a2a0a5409dd-0a2a450b975e-48 for ; Tue, 04 Aug 2026 17:48:24 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209c8-b7e8-0a2a450b0019-d155802ca8ce-3 for ; Tue, 04 Aug 2026 17:48:24 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso8471115e9.0 for ; Tue, 04 Aug 2026 08:48:24 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858504; x=1786463304; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oqMXCnK01BlYFZDe0+XHyH0PuzocnmSdtMYh4s8i6/I=; b=NrCqbKI/e42GXKnbhw/FVaj72OlfJPNqbFXidSkQs8p6efGG4TnQfNIrf6X3s80Vfe xDTRcvGW+wJeUwL0a76tdMkEAvk4NHC7HdQ41ozE/7gi+uTM9gkynlAsZ0CFpUe00vl+ dc+BDeKdRmMGSdW4gBNyBs+zT6Tz8Ooa1WdSn9+dI2YMIGBMYcashyEwqYOuD/090orW pY0xqGF5ZNfcFEn93izd2EB7nrlJogsfBdzbFzGbXv3AcIwZ8pCUaQ5MNQD9jB5VqHHy jnelwbZILQPwFTZNzU1zVWRz8fG04F5BqsvJEPCVns1mOM+l3SA/r5SJ+SmO+uK1Ea5v REGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858504; x=1786463304; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=oqMXCnK01BlYFZDe0+XHyH0PuzocnmSdtMYh4s8i6/I=; b=LGg99nNJygfUDPjrnxNDkDgGAujrS2ZyCvGimevc9DqA1vTl0X9+SoDB2tyhM8ttAa kmuDJ7mgUHogn3CnEd6UaUm+gPpzcehBD1f8yQRTsm+9CFm7Dgalm1Vh195T63FoAlUN 2ifg2+jBarurpXzaq2Vq8L6Swq2tVb6lrXQJPgyszx0CAU3I9bOBZfCkr3OIbYdpCA/R OT8ss7j7IUwdcLXtOpY30nTWDzHO4yz5uZ+Rjn5F5wWq9HK0Uh+pWbYcNyeUPmw3pluu eUV9mS7Tv3YPmkrsg63WJSP+YKIJIgq45XPowUdHmqKzqCKwDfl/yrNpbjNfPpTlKLAM 3pzA== X-Gm-Message-State: AOJu0YyI936rsMG3YtpYZWzmSYJi95fCPTYnM1TeanV8dD1bXI6/QyVx Y7wZgreNmXVa3Xv7oH7GJluJ5XFgqP1P74Hjmj2Pgd0pw192GCT9GjC3TD9zow== X-Gm-Gg: AR+sD12ssa4QbH03qv+JiPSZM0buAJomrIIdPs/nCVVBWgtN/mYHlRdNJjarIfo4nK4 K9qPP59137iLQyv4guJWVWTUomKEQt7mWptqq7yot7xB4daJjLk3/ymgbQbFJ6Z7WlSvuRkrsBU Td9W2qMTfzryEsbjoL167RYLWRB4nccg3z8/4NFDluxs5NNxNvmGXfJJlrHWRaeNmr6ViEh6hle Y1yDY1m81HgK78p2g0+xMA2VqUvUdt96Cck+jbM7nu/gAKy7KAru1bYgpeV+FHQnuu+340stpXU zhT1VfbTvvR73DGw61tm9FL8OxIUY8lctpEL9CH3XgF/nfH5o3183SLX0wt2RqTg0FUiE2PJcVQ 9ut0QaOLygHTWpglGd9PchQCRUDIlmLq77CTxhulALWFio0728Kv8HzBJUFp25XfM+OUSsYOk3b 8Y8G5jxTi93PacA8DOd2dKyu1Bk802DNgdz/pdn+8dDMEXzKiWo1az79HNAdHQdiUWloIoAJYM/ 15O6ZY07Yek3jcBndR8pvg6vZbVDhmGhw== X-Received: by 2002:a05:600c:468d:b0:493:f478:4c71 with SMTP id 5b1f17b1804b1-4994e382cacmr889265e9.7.1785858503857; Tue, 04 Aug 2026 08:48:23 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 04/20] xen/riscv: introduce guest riscv,isa string Date: Tue, 4 Aug 2026 17:47:54 +0200 Message-ID: <59b5b69f53ef81d68fd279d9ee0c03f5ffbbc2ae.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785858504-1BED69EA-756EA657/10/73395122804 X-purgate-type: spam X-purgate-size: 14745 Introduce build_guest_isa_str() to generate the riscv,isa string to be passed to the guest via the Device Tree riscv,isa property. Introduce the per-domain guest ISA bitmap, populated during domain creation by calling init_guest_isa(). Introduce struct riscv_isa_ext_entry with a new guest_supported field to filter out ISA extensions that should not be exposed to guests: - f/d/q/v: FPU and vector context save/restore are not yet implemented for guests. - Z*inx are not exposed either: they aren't in riscv_isa_ext[], so they can never be set in riscv_isa and thus never reach a guest, and no current hardware/guest-OS advertises or expects them. Supporting them would be cheaper than F/D/Q (FP values stay in integer registers Xen already context-switches), but is left as future work. - h: Nested virtualisation is not supported. - sstc: Xen owns the supervisor timer; guests must use SBI. - svade: Xen manages hardware A/D bit updates in stage-2 page tables. - svpbmt: Page-based memory types are not yet wired up in stage-2 code. Signed-off-by: Oleksii Kurochko --- Changes in v7: - build_guest_isa_str(): drop the struct domain argument and work directly on the guest_isa bitmap; make the function static as it has no external users anymore. - build the guest "riscv,isa" string only once, in compute_guest_isa(), and store it in an __ro_after_init pointer, instead of rebuilding it for every domain: all domains are currently given the same guest ISA, so apply here the same reasoning as for the guest_isa bitmap. - panic() on length calculation, allocation or formatting failure, in line with the rest of riscv_fill_hwcap() initialization. - introduce get_guest_isa_str() accessor and expose it in asm/cpufeature.h instead of build_guest_isa_str(). --- Changes in v6: - build_guest_isa_str() now takes a `const struct domain *d` instead of a raw `const unsigned long *isa_bitmap`, to leave room for using more than just the bitmap in the future. - Compute the guest-visible ISA bitmap once at boot, into a new __ro_after_init `guest_isa` bitmap (compute_guest_isa(), called at the end of riscv_fill_hwcap()), instead of re-deriving it from riscv_isa_ext[] on every domain creation in init_guest_isa(). All guests currently get the same extension set, so this avoids repeating identical work per domain; will need revisiting if/when per-domain ISA policy is introduced. - struct arch_domain's `isa` field is now `const unsigned long *isa` instead of an embedded bitmap; init_guest_isa() just points it at the shared `guest_isa` bitmap rather than copying bits into a per-domain array. - Mark riscv_isa_ext[] __initconstrel, since its entries hold name pointers and the need for relocations requires that the compiler emit the data to a writable section. - Make build_guest_isa_str() __init as it is called during make_cpus_node() which is used only (at least, for now) in build time of domain. --- Changes in v5: - Introduce struct riscv_isa_ext_entry with a guest_supported field and RISCV_ISA_EXT_ENTRY(name, guest_supp) macro for riscv_isa_ext[], replacing the ad-hoc guest_unsupp bitmap and init_guest_unsupp(). Every entry now carries an explicit true/false decision, enforced at compile time. - init_guest_isa() builds d->arch.isa by iterating riscv_isa_ext[] directly instead of using bitmap_andnot() against guest_unsupp. - init_guest_isa() changed to void as it can no longer fail. - Drop isa_str from struct arch_domain; the ISA string does not need to persist over the domain lifetime. build_guest_isa_str() is made non-static and declared in cpufeature.h for use when building the guest device tree. - Updated the fix of underflow in build_guest_isa_str(). - Drop unnecessary empty line in cpufeature.h before enum riscv_isa_ext_id. --- Changes in v4: - Add an explicit overflow guard in build_guest_isa_str(): return -ENOSPC when buf is non-NULL and total >= size, to avoid the size - total underflow being passed to snprintf(). - Expand the commit message to explain why Zfinx/Zdinx/Zqinx are not added to guest_unsupp (not in riscv_isa_ext[], so never set in riscv_isa nor exposed to a guest; left as future work) --- Changes in v3: - s/set_bit/__set_bit in init_guest_unsupp() as atomicity isn't needed at init time. - Drop RISCV_GUEST_ISA_STR_MAX; allocate isa_str dynamically with xvmalloc_array(). - Drop "guest" prefix from d->arch.guest_isa and d->arch.guest_isa_str. - Introduce build_guest_isa_str() using snprintf(NULL, 0, ...) to determine the needed buffer size; init_guest_isa() calls it once for sizing and once to fill, keeping both in a single function so they can't go out of sync. - Scope ret inside the loop; initialize total directly from the prefix snprintf(). - Merge "_" separator and extension name into a single snprintf() with "%s%s". - Replace ASSERT with an explicit error check: if the fill call returns a different length, free isa_str and return -EINVAL. --- Changes in v2: - s/guest_unsupp_bmp/guest_unsupp. - Drop guest_isa_str. - Provide init_guest_isa() instead of polluting match_isa_ext(). - Drop xlen. - Add the comment about guest_unsupp. - Update the way how guest_unsupp is init-ed. - Drop __initconst for riscv_isa_ext[] as it is used in init_guest_isa() which isn't marked as __init as it could be used after init stage. --- --- xen/arch/riscv/cpufeature.c | 171 ++++++++++++++++++++---- xen/arch/riscv/domain.c | 2 + xen/arch/riscv/include/asm/cpufeature.h | 5 + xen/arch/riscv/include/asm/domain.h | 3 + 4 files changed, 157 insertions(+), 24 deletions(-) diff --git a/xen/arch/riscv/cpufeature.c b/xen/arch/riscv/cpufeature.c index 92235fdfd5ab..c963c3d556b4 100644 --- a/xen/arch/riscv/cpufeature.c +++ b/xen/arch/riscv/cpufeature.c @@ -14,7 +14,9 @@ #include #include #include +#include #include +#include #include #include @@ -34,9 +36,35 @@ struct riscv_isa_ext_data { .name = #ext_name, \ } +struct riscv_isa_ext_entry { + unsigned int id; + const char *name; + bool guest_supported; +}; + +#define RISCV_ISA_EXT_ENTRY(ext_name, guest_supp) \ +{ \ + .id = RISCV_ISA_EXT_ ## ext_name, \ + .name = #ext_name, \ + .guest_supported = guest_supp, \ +} + /* Host ISA bitmap */ static __ro_after_init DECLARE_BITMAP(riscv_isa, RISCV_ISA_EXT_MAX); +/* + * ISA bitmap handed out to every guest. + * + * All guests are given the same extensions for the time being, so this is + * computed once out of riscv_isa_ext[] and riscv_isa, rather than redoing + * the walk for every domain created. Should per-domain ISA policy ever be + * introduced, this will need to become per-domain again. + */ +static __ro_after_init DECLARE_BITMAP(guest_isa, RISCV_ISA_EXT_MAX); + +/* "riscv,isa" string corresponding to guest_isa, shared by all domains. */ +static char *__ro_after_init guest_isa_str; + static int __init dt_get_cpuid_from_node(const struct dt_device_node *cpu, unsigned long *dt_cpuid) { @@ -120,29 +148,30 @@ static int __init dt_get_cpuid_from_node(const struct dt_device_node *cpu, * and strncmp() is used in match_isa_ext() to compare extension names instead * of strncasecmp(). */ -const struct riscv_isa_ext_data __initconst riscv_isa_ext[] = { - RISCV_ISA_EXT_DATA(i), - RISCV_ISA_EXT_DATA(m), - RISCV_ISA_EXT_DATA(a), - RISCV_ISA_EXT_DATA(f), - RISCV_ISA_EXT_DATA(d), - RISCV_ISA_EXT_DATA(q), - RISCV_ISA_EXT_DATA(c), - RISCV_ISA_EXT_DATA(h), - RISCV_ISA_EXT_DATA(zicntr), - RISCV_ISA_EXT_DATA(zicsr), - RISCV_ISA_EXT_DATA(zifencei), - RISCV_ISA_EXT_DATA(zihintpause), - RISCV_ISA_EXT_DATA(zihpm), - RISCV_ISA_EXT_DATA(zba), - RISCV_ISA_EXT_DATA(zbb), - RISCV_ISA_EXT_DATA(zbs), - RISCV_ISA_EXT_DATA(smaia), - RISCV_ISA_EXT_DATA(smstateen), - RISCV_ISA_EXT_DATA(ssaia), - RISCV_ISA_EXT_DATA(sstc), - RISCV_ISA_EXT_DATA(svade), - RISCV_ISA_EXT_DATA(svpbmt), +static const struct riscv_isa_ext_entry __initconstrel riscv_isa_ext[] = { + RISCV_ISA_EXT_ENTRY(i, true), + RISCV_ISA_EXT_ENTRY(m, true), + RISCV_ISA_EXT_ENTRY(a, true), + RISCV_ISA_EXT_ENTRY(f, false), + RISCV_ISA_EXT_ENTRY(d, false), + RISCV_ISA_EXT_ENTRY(q, false), + RISCV_ISA_EXT_ENTRY(c, true), + RISCV_ISA_EXT_ENTRY(v, false), + RISCV_ISA_EXT_ENTRY(h, false), + RISCV_ISA_EXT_ENTRY(zicntr, true), + RISCV_ISA_EXT_ENTRY(zicsr, true), + RISCV_ISA_EXT_ENTRY(zifencei, true), + RISCV_ISA_EXT_ENTRY(zihintpause, true), + RISCV_ISA_EXT_ENTRY(zihpm, true), + RISCV_ISA_EXT_ENTRY(zba, true), + RISCV_ISA_EXT_ENTRY(zbb, true), + RISCV_ISA_EXT_ENTRY(zbs, true), + RISCV_ISA_EXT_ENTRY(smaia, true), + RISCV_ISA_EXT_ENTRY(smstateen, true), + RISCV_ISA_EXT_ENTRY(ssaia, true), + RISCV_ISA_EXT_ENTRY(sstc, false), + RISCV_ISA_EXT_ENTRY(svade, false), + RISCV_ISA_EXT_ENTRY(svpbmt, false), }; static const struct riscv_isa_ext_data __initconst required_extensions[] = { @@ -181,7 +210,7 @@ static void __init match_isa_ext(const char *name, const char *name_end, for ( unsigned int i = 0; i < riscv_isa_ext_count; i++ ) { - const struct riscv_isa_ext_data *ext = &riscv_isa_ext[i]; + const struct riscv_isa_ext_entry *ext = &riscv_isa_ext[i]; /* * `ext->name` (according to initialization of riscv_isa_ext[] @@ -480,6 +509,98 @@ bool riscv_isa_extension_available(const unsigned long *isa_bitmap, return test_bit(id, isa_bitmap); } +static int __init build_guest_isa_str(char *buf, size_t size) +{ + char *p = buf; + size_t left = size; + int total; + +#if defined(CONFIG_RISCV_32) + total = snprintf(p, left, "rv32"); +#elif defined(CONFIG_RISCV_64) + total = snprintf(p, left, "rv64"); +#else +# error "Unsupported RISC-V bitness" +#endif + + if ( total < 0 ) + return total; + + if ( buf ) + { + if ( (size_t)total >= left ) + return -ENOSPC; + + p += total; + left -= total; + } + + for ( unsigned int i = 0; i < ARRAY_SIZE(riscv_isa_ext); i++ ) + { + const struct riscv_isa_ext_entry *ext = &riscv_isa_ext[i]; + int ret; + + if ( !riscv_isa_extension_available(guest_isa, ext->id) ) + continue; + + ret = snprintf(p, left, "%s%s", + ext->id >= RISCV_ISA_EXT_BASE ? "_" : "", + ext->name); + if ( ret < 0 ) + return ret; + + total += ret; + + if ( buf ) + { + if ( (size_t)ret >= left ) + return -ENOSPC; + + p += ret; + left -= ret; + } + } + + return total; +} + +static void __init compute_guest_isa(void) +{ + int len; + + for ( unsigned int i = 0; i < ARRAY_SIZE(riscv_isa_ext); i++ ) + { + const struct riscv_isa_ext_entry *ext = &riscv_isa_ext[i]; + + if ( ext->guest_supported && + riscv_isa_extension_available(NULL, ext->id) ) + __set_bit(ext->id, guest_isa); + } + + /* + * All domains are given the same guest ISA, so the "riscv,isa" string + * is built only once here and then shared by all of them. + */ + if ( (len = build_guest_isa_str(NULL, 0)) < 0 ) + panic("Failed to calculate guest \"riscv,isa\" length: %d\n", len); + + if ( !(guest_isa_str = xvmalloc_array(char, len + 1)) ) + panic("Failed to allocate guest \"riscv,isa\" string\n"); + + if ( build_guest_isa_str(guest_isa_str, len + 1) != len ) + panic("Failed to build guest \"riscv,isa\" string\n"); +} + +void init_guest_isa(struct domain *d) +{ + d->arch.isa = guest_isa; +} + +const char *get_guest_isa_str(void) +{ + return guest_isa_str; +} + void __init riscv_fill_hwcap(void) { unsigned int i; @@ -527,4 +648,6 @@ void __init riscv_fill_hwcap(void) if ( !all_extns_available ) panic("Look why the extensions above are needed in " "https://xenbits.xenproject.org/docs/unstable/misc/riscv/booting.txt\n"); + + compute_guest_isa(); } diff --git a/xen/arch/riscv/domain.c b/xen/arch/riscv/domain.c index 2819ff4e7c92..c9933147595e 100644 --- a/xen/arch/riscv/domain.c +++ b/xen/arch/riscv/domain.c @@ -308,6 +308,8 @@ int arch_domain_create(struct domain *d, if ( is_idle_domain(d) ) return 0; + init_guest_isa(d); + if ( (rc = p2m_init(d, config)) != 0) goto fail; diff --git a/xen/arch/riscv/include/asm/cpufeature.h b/xen/arch/riscv/include/asm/cpufeature.h index 0c48d57a03bb..2973eb13a513 100644 --- a/xen/arch/riscv/include/asm/cpufeature.h +++ b/xen/arch/riscv/include/asm/cpufeature.h @@ -5,6 +5,7 @@ #ifndef __ASSEMBLER__ #include +#include /* * These macros represent the logical IDs of each multi-letter RISC-V ISA @@ -44,7 +45,11 @@ enum riscv_isa_ext_id { RISCV_ISA_EXT_MAX }; +struct domain; + void riscv_fill_hwcap(void); +void init_guest_isa(struct domain *d); +const char *get_guest_isa_str(void); bool riscv_isa_extension_available(const unsigned long *isa_bitmap, enum riscv_isa_ext_id id); diff --git a/xen/arch/riscv/include/asm/domain.h b/xen/arch/riscv/include/asm/domain.h index 6044ce0feee0..8ae01a5e4dcc 100644 --- a/xen/arch/riscv/include/asm/domain.h +++ b/xen/arch/riscv/include/asm/domain.h @@ -7,6 +7,7 @@ #include #include +#include #include #include #include @@ -94,6 +95,8 @@ struct arch_domain { struct p2m_domain p2m; struct paging_domain paging; + + const unsigned long *isa; }; #include -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382266.1625638 (Exim 4.92) (envelope-from ) id 1wrHNT-0007YY-UJ; Tue, 04 Aug 2026 15:48:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382266.1625638; Tue, 04 Aug 2026 15:48:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNT-0007WN-PR; Tue, 04 Aug 2026 15:48:27 +0000 Received: by outflank-mailman (input) for mailman id 1382266; Tue, 04 Aug 2026 15:48:26 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNS-0007KO-6m for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNR-009GfZ-Jj for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:25 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c9-2eae-0a2a0a5409dd-0a2a4507c9be-2 for ; Tue, 04 Aug 2026 17:48:25 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209c7-b4ea-0a2a45070019-d155802eb8ac-3 for ; Tue, 04 Aug 2026 17:48:23 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so36540035e9.2 for ; Tue, 04 Aug 2026 08:48:23 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858503; x=1786463303; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MP/1zoasJWckGByg7jAKnBbEmQnEEwAq1X/Es6dlPOM=; b=SP+gnfjuQEudbjUeaC+DElxqkKK4NHG/SdzMh13jcpTvcHHZ4Nk3C1G8WBcR0nzBJ1 xfGBsC327fKshsOVjXV0oCwymy+cnOGB0IxZzZ1GPuzFZhvz+Dby16YDyveAAsbCyck+ 7mPOlJe7Oug+dRbyZmkLZP8onBSp0JH3Z0mJdF/LXW0mgfuFYRJNQR3R4nS94Ms0ODHT lx7vGsNY1p5Vq61TUWPdKjgTk3QFolBqC/l3jdJipkByuZK5C6yyATZSttIuJnjo0D7T B3KDwavPa940NO8DwvtdUkYnkY8P0Jo73+oJQQe0NvR6QnHmVsFibSCd+ho9+UOYtztc w4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858503; x=1786463303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MP/1zoasJWckGByg7jAKnBbEmQnEEwAq1X/Es6dlPOM=; b=Z39tjLd/JiwA9UVlluN6d5LoJyh/VJnMmKP0Q8f9rQP8sGkhUuNC9VStR3Syv8LLpd qwrm0IpcbvBwA9ateLRL6j+k6th44NK5M96mPNvjFxZabwxW0g5jZVCTTOCqwd2+4QS7 ahjrMUaMYRaIxFtznjIez+2wQkd/LgDjgIEpTMMvzXdkzLE2JVnMFcwwq4WYyhT0QWDq w0XqfA0w3VWeMu1UTRXZbwb3o0YkbKCVkwi/d26cdvkqbSqnFOzuSJ/mAMESiA5ILaSF hyd3lwxF24wOt2CL7ofKNSTk4OAzT3TeTmYONPpQBmcbudW31v+QyZM4/lU3mFkj4h5W OGFg== X-Gm-Message-State: AOJu0YyHZb4byQWXealrac2AEDbxmmGAQgAqktdcqjyZZNs9vNPaojpU pgmLy4Lry8MAk0Dx8EtzGDyF7NLPPVJ8HMbijqg6deu7B6pj5VUHzlcbpwmEzQ== X-Gm-Gg: AR+sD13+U1ZsVOZJ3y6gdcxaN9RoZxTGKhnpcHdf2uIiM9iM2NAv7FeF1J7aWsYGIzJ +GSQmYWnrEyc9dC4O+wiGeMPZsrSYnIjziBdeAoU/UA49TMso3lcQiXWNdwAMCUl4Lywv2LT0xm tMLObZVM4wKOc70u/3r1kP2xU3tL91XJI512qHhnVoDw3DiZQAB5lknko/bhfTdSx8qKZetrmt9 S1giWJcl56/MKIKo8Mc0fFu/lG0DSJj8OxN/zr+LqWYNo6hREjOJ1pOZ2eh7PxHa8R1Kk4xGner 7JfDNZNwJT7CB2dgyCL7yniPiSpzrqX3yHNsHkx/v8X4gcPDqA+efMRk/DwRGrnJRJ6y8lHIUdD 2PNF1UogGvPeW56cX0U4FwdeTVTeKQQ5J+KmlQquhbKeqsJ8gGSaX/ZOC02tqwrsqoVHB2lBlBJ PeefhtqOZcxdOZ9Qnr45HKLfRfcb44v1KEi28xaXD5XGoXu86uwS2nW+YKlv/GzxboQQPmyn16n dWsW4k3APnuWhme2CfLX0n29u6f9uztBg== X-Received: by 2002:a05:600c:8711:b0:495:52a5:8829 with SMTP id 5b1f17b1804b1-4980c652515mr416359285e9.11.1785858502781; Tue, 04 Aug 2026 08:48:22 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 03/20] xen/riscv: Implement construct_domain() Date: Tue, 4 Aug 2026 17:47:53 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1785858503-3C610AE4-0BE0FE40/10/73395122804 X-purgate-type: spam X-purgate-size: 3117 Implement construct_domain() function for RISC-V, which performs initial setup for the domain's first vCPU, loads the kernel, initrd, and device tree, and sets up guest CPU registers for boot. It also creates additional vCPUs up to max_vcpus and assigns the device tree address and boot cpuid in registers. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v5-v7: - Only rebase. Nothing changed. --- Changes in v4: - Drop the blank before v%u in the printk() failure message so the output matches that of %pv. - Restore Acked-by that was lost in v3. --- Changes in v3: - s/%d/%u for printing vCPU index in the failure message. - Drop dprintk() for successful vCPU creation. --- Changes in v2: - Rework construct_domain() to print that vCPU1...n are created using %pv. - Use true instead of 1 for initialization of v->is_initialised. - Drop unnessary BUG_ON() in construct_domain(). - Add TODO comment above *_load() functions. --- --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/domain-build.c | 50 +++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 xen/arch/riscv/domain-build.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 4fcdcf9e24de..2d24670dfc74 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,6 +1,7 @@ obj-y += aplic.o obj-y += cpufeature.o obj-y += domain.o +obj-y += domain-build.init.o obj-$(CONFIG_DOM0LESS_BOOT) += dom0less-build.init.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += entry.o diff --git a/xen/arch/riscv/domain-build.c b/xen/arch/riscv/domain-build.c new file mode 100644 index 000000000000..5f6f4b6248a5 --- /dev/null +++ b/xen/arch/riscv/domain-build.c @@ -0,0 +1,50 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include +#include +#include + +#include +#include + +int __init construct_domain(struct domain *d, struct kernel_info *kinfo) +{ + struct vcpu *v = d->vcpu[0]; + struct cpu_user_regs *regs = vcpu_guest_cpu_user_regs(v); + + BUG_ON(v->is_initialised); + + /* + * At the moment *_load() don't return value and will just panic() + * inside. + * TODO: it will be good to change that. + */ + kernel_load(kinfo); + initrd_load(kinfo, copy_to_guest_phys); + dtb_load(kinfo, copy_to_guest_phys); + + regs->sepc = kinfo->entry; + + /* Guest boot cpuid = 0 */ + regs->a0 = 0; + regs->a1 = kinfo->dtb_paddr; + + for ( unsigned int i = 1; i < d->max_vcpus; i++ ) + { + const struct vcpu *tmp_v = vcpu_create(d, i); + + if ( !tmp_v ) + { + printk("Failed to allocate %pdv%u\n", d, i); + break; + } + } + + domain_update_node_affinity(d); + + v->is_initialised = true; + clear_bit(_VPF_down, &v->pause_flags); + + return 0; +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382267.1625658 (Exim 4.92) (envelope-from ) id 1wrHNV-00089I-Fq; Tue, 04 Aug 2026 15:48:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382267.1625658; Tue, 04 Aug 2026 15:48:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNV-00086R-AR; Tue, 04 Aug 2026 15:48:29 +0000 Received: by outflank-mailman (input) for mailman id 1382267; Tue, 04 Aug 2026 15:48:27 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNT-0007LB-3D for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNS-009Gcw-Fw for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:26 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209b7-bab6-0a2a0a5309dd-0a2a4505e25a-32 for ; Tue, 04 Aug 2026 17:48:26 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209ca-4cb1-0a2a45050019-d1558032b837-3 for ; Tue, 04 Aug 2026 17:48:26 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so36541325e9.2 for ; Tue, 04 Aug 2026 08:48:26 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858506; x=1786463306; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xLkIYss1rW/F2qb2oVl9fc594E2EtP3QPXzs49dm0sw=; b=b1BwFxD+XbEtmhYCLlAGre2G5NtvTNmLE/etUJpULzhzJ5NMPdu155LyF9YV/4UmiR YvJGsloZRiWGva+hUIod38oQU9jhjMnw8eGG4PcpVPuqHx1FaClOuiDTTixUVv/eFcdh V0iBVwRgkhA7wWs9l/AMAumpWHJOIY23h1CLTfm3tg5XRMclK9sGinXCn6GVIXLwJ/4L a/3skOBNozAyO2/RWQNPQTHWN+0fcPw/xiQ53znripQVoCicQOMwgexvLWUMH5p2euNO zNjXJXT773I9hQ/5HxGkHjs8ieAIPnSQDmaoYaLtcFEvh9RUuvdcBOqqt3noUAwGWE4e 51ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858506; x=1786463306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xLkIYss1rW/F2qb2oVl9fc594E2EtP3QPXzs49dm0sw=; b=Aa/7UgDDBtsYoJRu9aGDYTVPVMCq37DwsWYZTEXEsb4opUKAHJNHp6mvLIzOFUIMcG LeZIyooLZB1DTeCSdMxI2goyhCMJt2jNSWQKwYe4+laL9vx/Mzp8b8wUbCfixUcVj/c5 j6cFzSN5wcYIqrEU/O6qUm0BKRcBZV4LKfd7q43z1iKWZD4swonOoWI+kZuW1KuOsYsy Di8C/cLWEn+YWav1oqHagicGMPkQcNjzkLubcTc/5Ow5EhW9Kalw8PTCqkQANogwOuI5 JuoqLq+51szPP+zdvc8CWKS54a4gfPpCaYbDHYXlN4dyI/FVBCfYvPcJ+XOJ/wVlQXoc CuWg== X-Gm-Message-State: AOJu0YyM7ELom/nPK28YLj84L73fuMdP7esJ8ztLWZNMxNgBLI6+oLqY TtyYQqY+G3MDYG3yivLxabqmYyB8FJeKkAEpcICLt9vjrC3qcjHglqBGPmjW8g== X-Gm-Gg: AR+sD11romr588/THHmwTkR4eqgZ9YBFx987Ug1ZOiVKJgRKK0qijA1d1TISxijSXg/ Ev/8nelQGW8J2fm3SUYECz25X1gFIydoImSs9o96VTaraxPo5lhAyrX1UeKRpWHS2rySm7LwKjt /IGBLgZUzD6Fz6ZQZWLsWWHGBHh3QMR8rl8vefkRkpBAM21N/zZsWTTBxcWLsiFvKIhRaXVCG0O 5IJpgiwO0SKurNilZQkpK9jrlDZZrFL2uz1cEqXXC94oonRCdRPx/YgblHHR6GY4J4ouic7ziQx k22pSjsgY5biaAa+5hwlnOsawtr3GgRVzkQ3na+LxqNp1LORBrxYkJp2S7Q25Pp0itpkBiOEx14 alZKNEBJotskajiWTXAwsxFyM5UOWYqrMLQ8U2Q+B7y8V67NirMsIQpxc1AqR8GfvOYgLX/x6Up 3bc+YVM13QO9TnXz/YdL2fI6sIGeX+CcnBqOu5uy65UODTYCmlyjEtkHKXx4keN8suV2T1P1CyW l00DSRPIbWtctT/yXX8FavyxLHgH3GYTw== X-Received: by 2002:a05:600c:1d0a:b0:495:5dcc:52b4 with SMTP id 5b1f17b1804b1-4994d9ef0b5mr33072185e9.3.1785858505967; Tue, 04 Aug 2026 08:48:25 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 06/20] xen/riscv: implement make_timer_node() Date: Tue, 4 Aug 2026 17:47:56 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1785858506-F60AA2A1-EB1945B8/10/73395122804 X-purgate-type: spam X-purgate-size: 1618 Generally, in DT for RISC-V there is a document which describes a timer node (riscv,timer.yaml or sifive,clint.yaml), but the Linux timer driver is declared with TIMER_OF_DECLARE(riscv_timer, "riscv", ...). It matches the CPU node (compatible "riscv"), not the timer node itself. It then calls of_find_compatible_node(NULL, NULL, "riscv,timer") only to read the optional riscv,timer-cannot-wake-cpu property. Since Xen does not care about that property for now, make_timer_node() is implemented to return 0, as no timer node needs to be created for RISC-V guests. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v3-7: - Nothing changed. Only rebase. --- Changes in v2: - Acked-by: Jan Beulich - Update the commit message. --- --- xen/arch/riscv/domain-build.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/riscv/domain-build.c b/xen/arch/riscv/domain-build.c index 1af4c48fb30c..d7613721db95 100644 --- a/xen/arch/riscv/domain-build.c +++ b/xen/arch/riscv/domain-build.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include @@ -154,3 +155,10 @@ int __init make_cpus_node(const struct domain *d, struct kernel_info *kinfo) return fdt_end_node(fdt); } + +int __init make_timer_node(const struct kernel_info *kinfo) +{ + /* There is no need for timer node for RISC-V. */ + + return 0; +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382268.1625670 (Exim 4.92) (envelope-from ) id 1wrHNW-0008Rt-RS; Tue, 04 Aug 2026 15:48:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382268.1625670; Tue, 04 Aug 2026 15:48:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNW-0008RZ-Kq; Tue, 04 Aug 2026 15:48:30 +0000 Received: by outflank-mailman (input) for mailman id 1382268; Tue, 04 Aug 2026 15:48:28 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNU-0007gh-Fy for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNT-009QHz-SM for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:27 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c8-5cb7-0a2a0a5109dd-0a2a450bdaba-8 for ; Tue, 04 Aug 2026 17:48:27 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209cb-b7e8-0a2a450b0019-d1558031e9ac-3 for ; Tue, 04 Aug 2026 17:48:27 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4955de8797cso21143195e9.3 for ; Tue, 04 Aug 2026 08:48:27 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858507; x=1786463307; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Rya0M33QFFZ2ZUtKRPpGLKlS3qYbQXw2r8chWSRTMZ4=; b=cfbY1msnd39EcO4GDxFdxC01xMFVr7SpVkJ9oPRgn9rDEu0Cs1AAcORr697/qthwfS nK+Psr0OIwV8BnvvKdbgAy7PEO2+YjBl2WluLDu1/EgUtV9BQPHBe6dqYg7kXv+4W6j3 Y1U1YarQO7ErvGXTMsd17ZmCXCNMCjB5n84gMnP2F1uPtcksmv8bjE4JR9N0zIdJ1Ug4 QzsG35CQHq/a4F9iK3eqe0ARfjcTzOpcqYGrP6IrODKuZpkul19gPekabLR32XZogGco Gwp5pZ9bwic/nJH/wLpQ1hoSJW/Sz7mo7Kan9B46jMS11iMCNx6Z2MzYgLBvRWpOFOdj WLmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858507; x=1786463307; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Rya0M33QFFZ2ZUtKRPpGLKlS3qYbQXw2r8chWSRTMZ4=; b=c4vIKlqb2vTmWvbRmZqp1m7JrQkHMktXnl8+6v82Q+OeRKe44Bv6MyJ2odXdfAWjZl T1gk7ihyd5fSl4a87IfOBNAoYA8WAoPbM+13TerULaUXtatckW68JH3vXCJ8EExffZTD +QJepOeKGSetkvM951kuqRo7Ummt+cvj3e65/Pqd4DyjltOvqChK/f31xiHQXoHHUL41 mtj5Eyo/F8GTwdMWtaBlaZHdHO5ARCsqkTJKzGu4rH4SWkwb3+yix5Mn2Um/ZyA84sT3 jW77PfbVgJb7ApFwOcy24KGrau43YZuek5wiTkeZ9TdDihNvAvRBln+HnGzu18xCxUge MH3g== X-Gm-Message-State: AOJu0Yw3/UQ/yX2fzcWfoe05vvPKoXu57eIUo5kLIIK+mw5Cdhv+nE0p zzsNj+x0+GAn0/h6Vmjg4jiYnQ//nxHWp4r7bcF4EWSktIai1M0VjEhpUfyVZw== X-Gm-Gg: AR+sD11jhv3dpsW+6gC1PElWwURVzh75OCjffG6yt4ek0Yv2qONMNCt4um4fm1+sVS1 SxWpmXz0gkrZHG+GqAFB3djXqACBhLZbDhSqqpqJpgkCvZUFEPZSg04lbz2+Po+iMmvZ6EtPTQs EzW4pvdQPJ19d9+UXNZNDu/7y5P4XbELCpltwWZ0zZ3ORVW7keBJHoAReF/06Shxp/GwzFSODve FMpP+yugC2IDPRBHXArfrk8s3do251ajHdhZKgqa6+hX4qWClPBM1U92efraxwX41CGwadTtZT8 fQgAA4jPiK+UAQhiGcOL7TZMiKeq4kFx849a+8OC9IS/vH1UAwuWy0ObfewBfRWGNWT9p3lM9lN GKFb5AZPs+TVyEUIF4eae3wXtv0pqLnXNhUHPhUDFeQeYH7WO+ZVVNfynCdjvzeWOiy9ouCfJzl no+C8NjLeDdSA3CbznM4gRbTImwnsJm08K5oAbbXcetKmAhKzfYkPT4Mqmn7+Ji8AkoLPO1CAtC w3xMCy0iFDT3JwXL0UzcmCwjHozrVsF2WlZHrnnGMkC X-Received: by 2002:a05:600c:628c:b0:496:c0f6:78d6 with SMTP id 5b1f17b1804b1-4980c64b5a7mr388460645e9.2.1785858506985; Tue, 04 Aug 2026 08:48:26 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 07/20] xen/riscv: implement make_arch_nodes() Date: Tue, 4 Aug 2026 17:47:57 +0200 Message-ID: <6bc1edc29160d7758d71402632309aeb7029d7fa.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785858507-AB8D19EA-DE3A0F14/10/73395122804 X-purgate-type: spam X-purgate-size: 1444 No RISC-V-specific nodes need to be created at the moment, so make_arch_nodes() is implemented to simply return 0. It is placed in dom0less-build.c as make_arch_nodes() is only used in the dom0less code path. In the future, it will be extended to create an emulated UART node. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v6-v7: - Nothing changed. Only rebase. --- Changes in v5: - Drop "Add" before Acked-by above the footer. --- Change in v4: - Add lost Acked-by. --- Changes in v3: - Add Acked-by: Jan Beulich . --- Changes in v2: - Update the commit message. --- --- xen/arch/riscv/dom0less-build.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/riscv/dom0less-build.c b/xen/arch/riscv/dom0less-build.c index a683972e9235..4cc00012aa8d 100644 --- a/xen/arch/riscv/dom0less-build.c +++ b/xen/arch/riscv/dom0less-build.c @@ -2,10 +2,18 @@ #include #include +#include #include #include +int __init make_arch_nodes(struct kernel_info *kinfo) +{ + /* No RISC-V specific nodes need to be made, at the moment. */ + + return 0; +} + int __init arch_parse_dom0less_node(struct dt_device_node *node, struct boot_domain *bd) { -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382269.1625676 (Exim 4.92) (envelope-from ) id 1wrHNX-00005D-Iv; Tue, 04 Aug 2026 15:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382269.1625676; Tue, 04 Aug 2026 15:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNX-0008VU-7C; Tue, 04 Aug 2026 15:48:31 +0000 Received: by outflank-mailman (input) for mailman id 1382269; Tue, 04 Aug 2026 15:48:29 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNV-000889-ID for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNU-009QHz-UW for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:28 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c8-5cb7-0a2a0a5109dd-0a2a450bdaba-10 for ; Tue, 04 Aug 2026 17:48:28 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209cc-b7e8-0a2a450b0019-d1558033b807-3 for ; Tue, 04 Aug 2026 17:48:28 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so36542205e9.2 for ; Tue, 04 Aug 2026 08:48:28 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858508; x=1786463308; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ebyF9U3D/MvFmcX3JXdHMfkwonGwN8CEi9ANlVWdpho=; b=cX/6V6ybntMPMEf/atcWFMKZPIuvZ6LUlu0I1s+X/rguGNPs9RXhaj5p189ilgD6e/ Eh5UpzFMd8lKbZPqDxOFidX7Ztta4TMjtUy+PwnY8LmYV/3919QN4dIR6YyOFpAJyq5H K7cO11KxobVpW90IqXXGHmPnx8CW4Lzq6uYpbe1JobY5QrHE/BPYvmEMDkCoUTABZhal Z67JsxG/5Pjru1A9cOy83Liku4fd7UYUdR2sjvxeTeJSXxgljbOMIHije/CdWNRBKJJq nXmofN0yjhAlgJwyCOYsvdXmsRzk+H62Psfs8bwfvxyZYh2BTy0I3EX295B95GOqaiQO N/Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858508; x=1786463308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ebyF9U3D/MvFmcX3JXdHMfkwonGwN8CEi9ANlVWdpho=; b=LE/pIyY1ZHKPYxDnpqWVqvsG90Rw1BpHkFHJ0nZFM2sQACak9E2b+SewmFMdmArPM8 pkMfcieZnUpHeMjK0GeQ5X9IQRccYhIMXIrRkTs22UC0LkRl51vaI57EcYST/ybOpIXW aolHhr5sxPxYOcVjEmAX48KpjAj+vLre8SGLV9v/fC2t9IXxGvjzi7okdk6Nt2Pgjfac a8hiJhqHXtp7aOzeE/0j1bEJ8brXsDTxEfbQcr21b4ecLnBRD3l2WwzbIgsbpdRN6MtG 0wq2COXQQeDPg++wzqVfEXOXToEuM0yndZtF8Fzola3MYQDq9X3z8HkJBlV2w9rAPxA0 rM5g== X-Gm-Message-State: AOJu0YywabMODMY7xeBJtxvhNfHwz0QDs5jSviSkSVrOB+SIyr1tl1QJ nyWRg+3Oc59MavNqaukYlxyqDWFULjNJmOpsTtX3oBO/vrDWc4HK+85cmdyCLw== X-Gm-Gg: AR+sD11H9xPPpHxSA1ubHCEqpFM/tQZJo+kxEwQpBoV84ES+B1Iv4ezvoY1ZQm0yLGB uCwGvM2GdrWx4S8h5YRVCrwh87wTfzzPK7PE18gLYrw91Bd++OEKl5/uqGYmodWDkyyleC6zZHJ Aww7RPjdV3ayyBTBtWY2RWq5nEFH9EzNzNVDFVnnOYnlayFt2sH7sxb0wzxYys9VolueZ5nS5ux laB88PpSGjuKXnY17JXrM2QuboZgODj1HCApUnoPwBArIzRvQrEdTJpbF28jNs+dtmwyBQF0+Pr rHo2mEkybMmu1J6yOEQyVQ5GG/XA3bbq31bZd7ulOYElUZf6pt94UGiPUFm72/ILnkmna9cG7RU ZruROax/qm0YkKehHrdf+mdkXCSS+pbjH/yI6IksLgx91bakzLG37Nox5qYcGUP0CLVQ81tlpoZ +UzXleOA4A+x7D8ucI4yJkrPkY+boSlfLfezD/UFn0aPpp+/O8sn7N5VSxc4QVC3e/YcZMcIXcw wmWUUkOAEDPMDGt9g8RPWvBQ8XvJ1EPdg== X-Received: by 2002:a05:600c:a016:b0:495:573e:1c54 with SMTP id 5b1f17b1804b1-4980c6523bamr409034915e9.9.1785858508247; Tue, 04 Aug 2026 08:48:28 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 08/20] xen/riscv: introduce init interrupt controller operations Date: Tue, 4 Aug 2026 17:47:58 +0200 Message-ID: <370ce245e6974650bd6efab9a4eba841f14552d5.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785858508-18ECE9EA-DC2254E9/10/73395122804 X-purgate-type: spam X-purgate-size: 4032 Introduce intc_hw_init_ops structure to avoid risky mix of init function and non-init function. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v5-7: - Nothin changed. Only rebase. --- Changes in v4: - Use __initconstrel instead of __initconst for aplic_init_ops as both initialized fields incur a relocation. - Add Acked-by: ... . --- Changes in v3: - Use __initconst instead of __initdata for const intc_hw_init_ops. - Embed const struct intc_hw_operations *ops into intc_hw_init_ops so register_intc_ops() takes a single pointer argument. --- Changes in v2: - New patch. --- --- xen/arch/riscv/aplic.c | 8 ++++++-- xen/arch/riscv/include/asm/intc.h | 10 +++++++--- xen/arch/riscv/intc.c | 11 ++++++++--- 3 files changed, 21 insertions(+), 8 deletions(-) diff --git a/xen/arch/riscv/aplic.c b/xen/arch/riscv/aplic.c index 9f023db5d525..d08401db46b3 100644 --- a/xen/arch/riscv/aplic.c +++ b/xen/arch/riscv/aplic.c @@ -325,12 +325,16 @@ static const hw_irq_controller aplic_xen_irq_type = { static const struct intc_hw_operations aplic_ops = { .info = &aplic_info, - .init = aplic_init, .host_irq_type = &aplic_xen_irq_type, .handle_interrupt = aplic_handle_interrupt, .set_irq_type = aplic_set_irq_type, }; +static const struct intc_hw_init_ops __initconstrel aplic_init_ops = { + .ops = &aplic_ops, + .init = aplic_init, +}; + static int cf_check aplic_irq_xlate(const uint32_t *intspec, unsigned int intsize, unsigned int *out_hwirq, @@ -366,7 +370,7 @@ static int __init aplic_preinit(struct dt_device_node *node, const void *dat) dt_irq_xlate = aplic_irq_xlate; - register_intc_ops(&aplic_ops); + register_intc_ops(&aplic_init_ops); /* Enable supervisor external interrupt */ csr_set(CSR_SIE, BIT(IRQ_S_EXT, UL)); diff --git a/xen/arch/riscv/include/asm/intc.h b/xen/arch/riscv/include/asm/intc.h index 675f703ec97f..d7b34fc15ad1 100644 --- a/xen/arch/riscv/include/asm/intc.h +++ b/xen/arch/riscv/include/asm/intc.h @@ -28,8 +28,6 @@ struct intc_info { struct intc_hw_operations { /* Hold intc hw information */ const struct intc_info *info; - /* Initialize the intc and the boot CPU */ - int (*init)(void); /* hw_irq_controller to enable/disable/eoi host irq */ const struct hw_interrupt_type *host_irq_type; @@ -43,9 +41,15 @@ struct intc_hw_operations { void (*handle_interrupt)(struct cpu_user_regs *regs); }; +struct intc_hw_init_ops { + const struct intc_hw_operations *ops; + /* Initialize the intc and the boot CPU */ + int (*init)(void); +}; + void intc_preinit(void); -void register_intc_ops(const struct intc_hw_operations *ops); +void register_intc_ops(const struct intc_hw_init_ops *init_ops); void intc_init(void); diff --git a/xen/arch/riscv/intc.c b/xen/arch/riscv/intc.c index ea317aea5ad8..3600d23bdb5b 100644 --- a/xen/arch/riscv/intc.c +++ b/xen/arch/riscv/intc.c @@ -12,9 +12,12 @@ static const struct intc_hw_operations *__ro_after_init intc_hw_ops; -void __init register_intc_ops(const struct intc_hw_operations *ops) +static const struct intc_hw_init_ops *__initdata intc_hw_init_ops; + +void __init register_intc_ops(const struct intc_hw_init_ops *init_ops) { - intc_hw_ops = ops; + intc_hw_ops = init_ops->ops; + intc_hw_init_ops = init_ops; } void __init intc_preinit(void) @@ -27,7 +30,9 @@ void __init intc_preinit(void) void __init intc_init(void) { - if ( intc_hw_ops->init() ) + ASSERT(intc_hw_init_ops && intc_hw_init_ops->init); + + if ( intc_hw_init_ops->init() ) panic("Failed to initialize the interrupt controller drivers\n"); } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382271.1625688 (Exim 4.92) (envelope-from ) id 1wrHNZ-0000XC-0j; Tue, 04 Aug 2026 15:48:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382271.1625688; Tue, 04 Aug 2026 15:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNY-0000VR-Oq; Tue, 04 Aug 2026 15:48:32 +0000 Received: by outflank-mailman (input) for mailman id 1382271; Tue, 04 Aug 2026 15:48:31 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNX-0008SN-08 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNW-009QHz-CE for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:30 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c8-5cb7-0a2a0a5109dd-0a2a450bdaba-14 for ; Tue, 04 Aug 2026 17:48:30 +0200 Received: from [209.85.128.44] (helo=mail-wm1-f44.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209ce-b7e8-0a2a450b0019-d155802cd52a-3 for ; Tue, 04 Aug 2026 17:48:30 +0200 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so21020405e9.1 for ; Tue, 04 Aug 2026 08:48:30 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858509; x=1786463309; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ER+uu35/NuCBQKkMFT6UQDxN44ZmROCjZqSQxG2REVI=; b=F54137HGfFFkXinnUZXnS7aXsO5/c6pfNP0uqQi3BtZ/TxB4/ncciWBE/X9lnMeKvB aMkKUTdvllYkgyFLEBUQoyEcv9SAqEab47Ltz6PwZklfEU+Gh5WGm4xpOjU6Riqi92/Y lzdAPinMymdF8+Ol5l3B4QI4OSu/5tFPFTb7/zti6Lgkb7CJVFpynTuDfWJvXRJtJpPT EpbQ3hzv3uHF6liBeGRaQMwS3NoYM927o/RMhg7NPddHzBWX/6GQ8bcxxOTdeea7RZQR cwQpCfHM5iyA5YyoYiE/PXceSrNvhNjWE7IaalLFjcTW2PPt4ZrSD6fN37j/RQ6zrBL4 UZjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858509; x=1786463309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ER+uu35/NuCBQKkMFT6UQDxN44ZmROCjZqSQxG2REVI=; b=esN7SLpwAfrVa+6ydYijbtIrQ18+8cAZ3pVvoQqqiw2rLb1oKedSHz3YyuEtV5MkxN LCc+jtLi08PcD1qersDP0irsbMxbfVZFWmbf2XjkjoAxtl+KZmlhrhmJodoLIBUVAuQt QxhBSn9Zj40IoASGll/9Am8QDQYhXo8H3ic6K6KXJ0SkCP5MFNGGiWbCyQF6JDZFKHEn H8rsE2nzBz1C6xDldz2u7jL8gfKZlzuSgfpADnNOBSX7QscaVHSf8nnBiEsS4MDb8Z81 wHM0JH5nTrQqTJzzBQW6NpqMq7vlG3hXz3EsqRXTtLG+o0d+UaCHHwWUJDScJmCy/hNn t2AQ== X-Gm-Message-State: AOJu0Yy/fUALqaYi7mZNFBz0hkhqbnNnHvdkLQIhNfbvbSHu2mDd8hgl szYiFtQ5ykDmDs1P6USpfgaDPdbtmY3o6qrECDo6MTjaduNitfKwkarqhUIyXQ== X-Gm-Gg: AR+sD10yWPMyOlfN3rVnNMaO1XZl2aCyosP5EsIdAXwb4kXBvuTHFmxnv/9nMEwXfoP jP/6mYYmjMZm7sxIvrKfcDIeRa10D5kRXwr/yAqMEdaU6r5i2wWJUN6iBDZHlmplMvZ6rGN+wUE kozU7YyEfrcVJ/c5BpG3czrqX0fjCn4QFBPRofQQYRmj2Yya9bTyRwgGbesdanajBGGxPdpXYVN PwAE57cEpP/vzvIo7cjcf2gJRJAfIX1e6b2FZds5V9D5O3B1qpXjhzAzup5FGYVH7oGgyKcvBj9 bxOXJ9yrfjzxKxoGc9RK3E8o5old9Q70FB1MmeA5nA5WajwpTRSYcl+FxoDwsIONphTv79QHDod eZb5+gaQXRoHwin38+JgRYtJrlVinUod+Abmo52KtHpg9MXhELqoNYzkOmg851WcWtn6daTwmJd g7sXrLuWlya+j2VYCJF/A/VHkO3y8pjpFoPTicK9e0Y3+lSVW40T9xJYl7e4vid2cMRGDOky4EO eYFg7rb1tfAZmO8sRzOMox77RkIOrbaUD5h2Hbh1qOn X-Received: by 2002:a05:600c:3550:b0:495:607e:5ee7 with SMTP id 5b1f17b1804b1-4980c679513mr352247215e9.17.1785858509525; Tue, 04 Aug 2026 08:48:29 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 09/20] xen/riscv: implement make_intc_domU_node() Date: Tue, 4 Aug 2026 17:47:59 +0200 Message-ID: <17901dd6707a12daef4aa1200c01fc1e0a754f63.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785858510-AA2C49EA-10D82817/10/73395122804 X-purgate-type: spam X-purgate-size: 3439 Introduce a RISC-V specific function to create an interrupt controller Device Tree node for DomU domains during dom0less build. Add make_intc_domU_node() to the dom0less build path and wire it to a new generic helper, intc_make_domu_dt_node(), which delegates DT node creation to the active interrupt controller implementation via vintc_init_ops. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v5-7: - Nothing changed. Onlye rebase. --- Change in v4: - Made local variable vintc pointer-to-const. - Add Acked-by: Jan Beulich --- Changes in v3: - Use const struct vintc_init_ops *init_ops in struct vintc. - Drop redundant intc_hw_ops check in make_intc_domU_node(). - Drop NULL pointer checks in make_intc_domU_node() as we can't start domU without properly created interrupt contoller node. --- Changes in v2: - s/intc_make_domu_dt_node/make_intc_domU_node. - introduce separate intc_hw_init_ops structure for init operations. - Return -EOPNOTSUPP instead of -ENOSYS. - Drop const for kinfo argument as it could be changed by interrupt controller node creation code. - Refactor make_domu_dt_node(). - Make make_domu_dt_node part of vintc structure as it looks more logical to be there. --- --- xen/arch/riscv/include/asm/domain.h | 2 ++ xen/arch/riscv/include/asm/intc.h | 10 ++++++++++ xen/arch/riscv/intc.c | 8 ++++++++ 3 files changed, 20 insertions(+) diff --git a/xen/arch/riscv/include/asm/domain.h b/xen/arch/riscv/include/asm/domain.h index 8ae01a5e4dcc..bd43ed08c22c 100644 --- a/xen/arch/riscv/include/asm/domain.h +++ b/xen/arch/riscv/include/asm/domain.h @@ -97,6 +97,8 @@ struct arch_domain { struct paging_domain paging; const unsigned long *isa; + + struct vintc *vintc; }; #include diff --git a/xen/arch/riscv/include/asm/intc.h b/xen/arch/riscv/include/asm/intc.h index d7b34fc15ad1..a4e678fad90b 100644 --- a/xen/arch/riscv/include/asm/intc.h +++ b/xen/arch/riscv/include/asm/intc.h @@ -16,6 +16,7 @@ enum intc_variant { struct cpu_user_regs; struct irq_desc; +struct kernel_info; struct intc_info { enum intc_variant hw_variant; @@ -47,6 +48,15 @@ struct intc_hw_init_ops { int (*init)(void); }; +struct vintc_init_ops { + /* Create interrupt controller node for domain */ + int (*make_domu_dt_node)(struct kernel_info *kinfo); +}; + +struct vintc { + const struct vintc_init_ops *init_ops; +}; + void intc_preinit(void); void register_intc_ops(const struct intc_hw_init_ops *init_ops); diff --git a/xen/arch/riscv/intc.c b/xen/arch/riscv/intc.c index 3600d23bdb5b..e63da5e22efc 100644 --- a/xen/arch/riscv/intc.c +++ b/xen/arch/riscv/intc.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -72,3 +73,10 @@ void intc_route_irq_to_xen(struct irq_desc *desc, unsigned int priority) intc_set_irq_type(desc, desc->arch.type); intc_set_irq_priority(desc, priority); } + +int __init make_intc_domU_node(struct kernel_info *kinfo) +{ + const struct vintc *vintc = kinfo->bd.d->arch.vintc; + + return vintc->init_ops->make_domu_dt_node(kinfo); +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382272.1625693 (Exim 4.92) (envelope-from ) id 1wrHNZ-0000du-Kx; Tue, 04 Aug 2026 15:48:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382272.1625693; Tue, 04 Aug 2026 15:48:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNZ-0000cn-9P; Tue, 04 Aug 2026 15:48:33 +0000 Received: by outflank-mailman (input) for mailman id 1382272; Tue, 04 Aug 2026 15:48:32 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNY-0000H8-3W for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNX-009QIN-GW for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:31 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209ce-e002-0a2a0a5209dd-0a2a45039d84-4 for ; Tue, 04 Aug 2026 17:48:31 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209cf-fae8-0a2a45030019-d155802ae1c7-3 for ; Tue, 04 Aug 2026 17:48:31 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso29813805e9.3 for ; Tue, 04 Aug 2026 08:48:31 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858511; x=1786463311; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SDS5pojmUe3g07xF2AfnOz4IjY2ac3KvA+3GWL6CRYM=; b=rExF+rEmSxmns9/JGLQkUQ/vd3TB1JZ/fiz/f0i6v57laz3Eo2/o6P2J8Ai8sYqJab funUWIHDqSm7j13kM/9dIwfSEDDaZR2uCtmBxJQckmsZ6hvjwSSN0nMgOBl53b2IGyuS GKazF+Hu/fXgjq80QIzzVhXm1WeZ9X1vHJEakIwsiPSNCeyJPM/nghtm3lNkDo1qe10e sKzHWjDcPR868Gv+An6oy2S7VF75dIl7agVir5I0L2K1DH1Yg8H5OzxFZ4CDiRGCuRCb fngfvjNkq9EBNkvq2R2r9fAFLy78ikkcbzTx3XtG2Ht04fgZqyofxViGeCC7Xd/k6Hxu Ytag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858511; x=1786463311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SDS5pojmUe3g07xF2AfnOz4IjY2ac3KvA+3GWL6CRYM=; b=hvGvTRD1j69g6jn+fcki4wxQAkwAGySkgNnayD6Pk6pbn1VeskE2z3IvkG8bc/Fa/1 oCDBdFXoQiU8va9deZD53x5SwHtTHHbF9DBoj4+Nm77sBi/PWzE0lH3SAp+MDdZsaLX9 DqfmEIXb1JiYq4l07WNYRH0aoe3Gdr+IqqA89LUU66dCzulgDzo3UFZlhvmnHD6Xm4WA W4Wn5VIlCl93SgeBdnPXcslW3jpxcwhilYyPwTXRNv1WMpaH8bNl4w48tXVqc+z7Or7l e04/PkQ8X+BIf20qBSrpynJ7576g4pToJ1gZmvgICMQpEIJMpOZbTphk8f6O5qi8dSp6 /bWQ== X-Gm-Message-State: AOJu0Yy1EUTNMZXnBF2Pk/yVSTHrq5hzXwlOmEbOjUqHJjdIxySXx+BG wznDGUHlF4ddRwGylHR60is+ph6j3menmBvWZKCHAA58uEXuc8rn8QqkfEghhg== X-Gm-Gg: AR+sD12w+X8tMWLBs1apKm3jEYuUWdXswNGYhL3W4jaox5pHAVwVJZ3eF9Y2ZBUKHIP Na0RDHBP5HcSr+lwo0BfqxvNTltS0/BCLJyPm5wq3SIjrjKULbq+vaMoYGLaFXbtf42Z49gzqtV u02crfHxtWUvWQ/L2TCadeKqiiHwKq3UsZNM1z8EfjziQJUtpjC/WQSGI1/boIPdbIuccvkZmWa T395fqhdtKhmI95F34eEID0IlRsKTO/JKyjsbD8qKc892wtMgOJxynGDbG7O6+lY2fRip14TEfI 329Y8Wse/cQd5fzp+5s0vCS7XIx+ae0dq1zv4RGQZoJoZ38Y5L7R3iba855w2lLlHSkAqHsRPdl 96Ugtx8aMNAqFtZfxdcqZuRyXZ2D3LbNfyyiO+GHRrY17vCLQgh+f9lgX1cScQkB30QZeM46k4b FOmcVIyIOvdIZ6jHq+iBcK3/CtifmheEY5xGIbsepB0+lAuXNVJvDXWnc1RelPdTDjnXUv5PR4A YEJNamdxcBwxWcF6MTKe2RULa/6WnbAnkU++nCiAP4JEw== X-Received: by 2002:a05:600c:6990:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-4980c673907mr369134765e9.12.1785858510888; Tue, 04 Aug 2026 08:48:30 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 10/20] xen/riscv: introduce aia_init() and aia_usable() Date: Tue, 4 Aug 2026 17:48:00 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785858511-6E6CE4E9-47FC6A01/10/73395122804 X-purgate-type: spam X-purgate-size: 3240 aia_init() is going to contain all the logic related to AIA initialization. At the moment, it only checks whether the SSAIA extension is available, and if so, sets is_aia_usable (which indicates more than just the availability of the extension) to true; it also signifies that the necessary components (to be introduced in follow-up patches) have been initialized. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v6-7: - Nothing changed. Only rebase. --- Changes in v5: - Update the guards in asm/aia.h according to CODING_STYLE: s/ASM__RISCV__AIA_H/RISCV_AIA_H. --- Changes in v4: - Add Acked-by: Jan Beulich --- Changes in v3: - s/is_aia_usable/_aia_usable to drop the is_ prefix while avoiding conflict with the aia_usable() function name. --- Changes in v2: - s/is_aia_available/is_aia_usable. - Drop return value for aia_init(). - s/aia_available()/aia_usable(). --- --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/aia.c | 23 +++++++++++++++++++++++ xen/arch/riscv/include/asm/aia.h | 10 ++++++++++ xen/arch/riscv/intc.c | 3 +++ 4 files changed, 37 insertions(+) create mode 100644 xen/arch/riscv/aia.c create mode 100644 xen/arch/riscv/include/asm/aia.h diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 2d24670dfc74..8e7a6370eee2 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,3 +1,4 @@ +obj-y += aia.o obj-y += aplic.o obj-y += cpufeature.o obj-y += domain.o diff --git a/xen/arch/riscv/aia.c b/xen/arch/riscv/aia.c new file mode 100644 index 000000000000..e31c9c2d24b6 --- /dev/null +++ b/xen/arch/riscv/aia.c @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include +#include +#include +#include + +#include + +static bool __ro_after_init _aia_usable; + +bool aia_usable(void) +{ + return _aia_usable; +} + +void __init aia_init(void) +{ + if ( !riscv_isa_extension_available(NULL, RISCV_ISA_EXT_ssaia) ) + return; + + _aia_usable = true; +} diff --git a/xen/arch/riscv/include/asm/aia.h b/xen/arch/riscv/include/asm/aia.h new file mode 100644 index 000000000000..aaa4bf91fc75 --- /dev/null +++ b/xen/arch/riscv/include/asm/aia.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef RISCV_AIA_H +#define RISCV_AIA_H + +bool aia_usable(void); + +void aia_init(void); + +#endif /* RISCV_AIA_H */ diff --git a/xen/arch/riscv/intc.c b/xen/arch/riscv/intc.c index e63da5e22efc..2864a896b677 100644 --- a/xen/arch/riscv/intc.c +++ b/xen/arch/riscv/intc.c @@ -9,6 +9,7 @@ #include #include +#include #include static const struct intc_hw_operations *__ro_after_init intc_hw_ops; @@ -33,6 +34,8 @@ void __init intc_init(void) { ASSERT(intc_hw_init_ops && intc_hw_init_ops->init); + aia_init(); + if ( intc_hw_init_ops->init() ) panic("Failed to initialize the interrupt controller drivers\n"); } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382273.1625702 (Exim 4.92) (envelope-from ) id 1wrHNb-0000xj-0v; Tue, 04 Aug 2026 15:48:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382273.1625702; Tue, 04 Aug 2026 15:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNa-0000xH-Pk; Tue, 04 Aug 2026 15:48:34 +0000 Received: by outflank-mailman (input) for mailman id 1382273; Tue, 04 Aug 2026 15:48:33 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNZ-0000bs-Bx for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNY-009QNa-Oj for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:32 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c8-5cb7-0a2a0a5109dd-0a2a450bdaba-22 for ; Tue, 04 Aug 2026 17:48:32 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d0-b7e8-0a2a450b0019-d155802ee5bf-3 for ; Tue, 04 Aug 2026 17:48:32 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4957eefd361so24591975e9.1 for ; Tue, 04 Aug 2026 08:48:32 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858512; x=1786463312; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JS4Pww1oLiCPhcc0rWFj9bF1S4Vy0n1GnD6OKYVDJuA=; b=GxGg0aJjEi0m0SDLi8hUlSnkPYL7fkDsdYH5sUjZYE9DPYOUVk92VETxiGbwsEJzZ4 N9yjlkiCGRDgM2PBvw0yo67d0v5olYejPsCrVQjyYtvu8nX5SLZKHIkqbH52KDHt8JLf ZQvMsLybG00c21voFJrp8UCwgy3zDR7dyo9rOV72Tt0DdAuvOS26mRFcertf8Qj4xcKV ao/7e7ktoJSnjcoTSCLOwvXTJDfS/NgTB5GfrFqzS7ZSIbesexKjpJo2pprtAAJXUT0d xkUO90/Sqt8PuoYKMajMSHwnyNLaXiYl4VCSiJz12IZdLPfAg93z8fHfeddPg5sWrwmZ Ms3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858512; x=1786463312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JS4Pww1oLiCPhcc0rWFj9bF1S4Vy0n1GnD6OKYVDJuA=; b=eXXVUQP4ITueUjVnKTuLWh7/HkgS54/mEmKqyK+KYNODb9iMOMvDsB7oSTBUhcopJ4 /2CG8XanovWRAcpwhdon4//8grM3q1qUsquViMBIEkdXf1S0cQg/mXZMu+VXukjqHTnf C/yjkD903RBbDR4Y8tuYkD7yyZsjoYYxwHIeNgqiSc/L8ww0bnok8AhAxx2ujwibAgX0 9QU5atu3XNsbA5iizkyVm78PvW3hYbV2BMePlcdowXdL4XdXbyAehh2QptnlhMVzrarJ N7NbjGgnwWrNTD6ZyCX7JbUgjKib+3YWB6f8a6/Cahuehx+ey8p24bjYZmcL2YM5GZc0 n+rQ== X-Gm-Message-State: AOJu0YwDIhOowEV22sQhG8gziZBZ5ioC546q2hXafGGhdWZ0tUFXI910 cyGKY+Zs+NlYHvGWeto3DrAPesMw27e7lhVbpupCzitvRi2taIBDE4lg+MoDDQ== X-Gm-Gg: AR+sD10KKuSCcPtxPd0eS455nQJ4Mj3rd+CzQoxv1eRJrzvSlm5TLHkme/+U5iHE5Pq 0lV89gsNeymYzRM1p/IJMfcKumwUrlsUIRFHOj2/Y93exiffhnHaZ8rMkz6dRMlJkxPqPMMfI8Z KndRIjdXMNrGo7WS4XBUmBUsosiC1iF07rATXJDYlJ1eXZRrJ97nfhfjJVLRCLT3j5qjx0nYVhs 2q6tUFwCS1MyoGbW6jbERGJJD+sudbcDU3LoxjE8jNSROKBOR8fQmHWlkJv9TKNNmsvcVnSbgp7 7HSfxYcpi0iEmX7HD7U5ib/K/fzVY8ulJ52ACxIuRdhX2+fXArJpnb6k0Gi+aaYzrUqaPU4Rl71 ceepsywiz1ou6ZBV6vUlA7qCfzbhuNwyKJsujRofLS1f4nY9zA0X62blet1CHHC1LvqaxHiTPcq paawXl37CFwXntOIAac117B3ogdnnKpsWl948WrF2EZQp2yU3f5ewF7H0OLBAHTfoQc4J/LC12M bb1FtUeqHZByqLOWez97Lps0gM+7yWMLb0RTJmcw72l X-Received: by 2002:a7b:cd93:0:b0:495:3de8:33a6 with SMTP id 5b1f17b1804b1-4980c65ed1bmr280281485e9.16.1785858512100; Tue, 04 Aug 2026 08:48:32 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 11/20] xen/riscv: introduce per-vCPU IMSIC state Date: Tue, 4 Aug 2026 17:48:01 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785858512-A86CA9EA-71F21E10/10/73395122804 X-purgate-type: spam X-purgate-size: 6490 Each vCPU interacting with the IMSIC requires state to track the associated guest interrupt file and its backing context. Introduce a per-vCPU structure to hold IMSIC-related state, including the guest interrupt file identifier and the CPU providing the backing VS-file. Access to the guest file identifier is protected by a lock. Initialize this structure during vCPU setup and store it in arch_vcpu. The initial state marks the VS-file as software-backed until it becomes associated with a physical CPU. Add helper to retrieve the guest interrupt file identifier: - vcpu_guest_file_id() is going to be used during update of APLIC's target register with the pair of information (to have MSI delivery mode work properly) when guest is trying to access vAPLIC's target register. It will be used in the follow up patches. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v6-7: - Nothing changed. Only rebase. --- Changes in v5: - Move v->arch.vimsic_state = imsic_state; after full initialization of the struct, so the pointer only becomes globally visible once all fields are set up. - Add Acked-by: Jan Beulich . --- Changes in v4: - s/w vs h/w IMSIC VS-file commentary for struct vimsic_state: - fix the vsfile_pcpu h/w condition: "vsfile_pcpu >= 0" -> "vsfile_pcpu < NR_CPUS" (the old wording conflicted with the s/w "== NR_CPUS" case). - reorder both comment blocks to the "s/w ... / h/w ..." form for readability. - drop IMPOSSIBLE_GUEST_FILE_ID: the s/w IMSIC VS-file is always available and corresponds to guest_file_id == 0, which xvzalloc() already provides, so the explicit initializer in vcpu_imsic_init() and the macro itself are unneeded. --- Changes in v3: - Drop const from imsic_set_guest_file_id() and vcpu_imsic_deinit() as it only works due to vimsic_state being a pointer member. - Use XVFREE() in vcpu_imsic_deinit() to make it idempotent. - Fix SW-file typo in struct vimsic_state comments; should be VS-file. - Drop imsic_set_guest_file_id() here, it will be added later when it will be nessary to initialise guest file id as the correspondendt code in this patch series was reworked and there is no need to use this function in arch_vcpu_create(). - Introduce IMPOSSIBLE_GUEST_FILE_ID and init with it ->guest_file_id. --- Changes in v2: - Rename imsic_state to vimsic_state. - Use 'unsigned int' for vsfile_pcpu. - Drop initialzation of ->guest_file_id as it will be by default zero. - Add the comment about ->guest_file_id field. - Drop __init for vcpu_imsic_init() as it could be used during post-boot vCPU creation. - Update the commit message. - Drop locks around ->guest_file_id() in vcpu_guest_file_id() and imsic_set_guest_file_id(). --- --- xen/arch/riscv/imsic.c | 35 +++++++++++++++++++++++++++++ xen/arch/riscv/include/asm/domain.h | 2 ++ xen/arch/riscv/include/asm/imsic.h | 22 ++++++++++++++++++ 3 files changed, 59 insertions(+) diff --git a/xen/arch/riscv/imsic.c b/xen/arch/riscv/imsic.c index f7b70a8da09e..5a5758e45dc2 100644 --- a/xen/arch/riscv/imsic.c +++ b/xen/arch/riscv/imsic.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -56,6 +57,11 @@ do { \ csr_clear(CSR_SIREG, v); \ } while (0) +unsigned int vcpu_guest_file_id(const struct vcpu *v) +{ + return ACCESS_ONCE(v->arch.vimsic_state->guest_file_id); +} + void __init imsic_ids_local_delivery(bool enable) { if ( enable ) @@ -312,6 +318,35 @@ static int imsic_parse_node(const struct dt_device_node *node, return 0; } +int vcpu_imsic_init(struct vcpu *v) +{ + struct vimsic_state *imsic_state; + + /* Allocate IMSIC context */ + imsic_state = xvzalloc(struct vimsic_state); + if ( !imsic_state ) + return -ENOMEM; + + /* Setup IMSIC context */ + rwlock_init(&imsic_state->vsfile_lock); + + /* + * xvzalloc() already cleared the context, so guest_file_id == 0, i.e. the + * always-available s/w IMSIC VS-file. Only vsfile_pcpu needs an explicit + * initializer as its s/w VS-file value is NR_CPUS rather than 0. + */ + imsic_state->vsfile_pcpu = NR_CPUS; + + v->arch.vimsic_state = imsic_state; + + return 0; +} + +void vcpu_imsic_deinit(struct vcpu *v) +{ + XVFREE(v->arch.vimsic_state); +} + /* * Initialize the imsic_cfg structure based on the IMSIC DT node. * diff --git a/xen/arch/riscv/include/asm/domain.h b/xen/arch/riscv/include/asm/domain.h index bd43ed08c22c..e035b33ddfdc 100644 --- a/xen/arch/riscv/include/asm/domain.h +++ b/xen/arch/riscv/include/asm/domain.h @@ -54,6 +54,8 @@ struct arch_vcpu { struct vtimer vtimer; + struct vimsic_state *vimsic_state; + register_t hcounteren; register_t hedeleg; register_t hideleg; diff --git a/xen/arch/riscv/include/asm/imsic.h b/xen/arch/riscv/include/asm/imsic.h index c6c59215df20..e2c413487d24 100644 --- a/xen/arch/riscv/include/asm/imsic.h +++ b/xen/arch/riscv/include/asm/imsic.h @@ -11,6 +11,7 @@ #ifndef ASM_RISCV_IMSIC_H #define ASM_RISCV_IMSIC_H +#include #include #include #include @@ -61,7 +62,24 @@ struct imsic_config { spinlock_t lock; }; +struct vimsic_state { + /* IMSIC VS-file */ + rwlock_t vsfile_lock; + /* + * s/w IMSIC VS-file -> guest_file_id == 0 + * h/w IMSIC VS-file -> guest_file_id > 0 + */ + unsigned int guest_file_id; + /* + * s/w IMSIC VS-file -> vsfile_pcpu == NR_CPUS + * h/w IMSIC VS-file -> vsfile_pcpu < NR_CPUS + */ + unsigned int vsfile_pcpu; +}; + struct dt_device_node; +struct vcpu; + int imsic_init(const struct dt_device_node *node); const struct imsic_config *imsic_get_config(void); @@ -71,4 +89,8 @@ void imsic_irq_disable(unsigned int hwirq); void imsic_ids_local_delivery(bool enable); +int vcpu_imsic_init(struct vcpu *v); +void vcpu_imsic_deinit(struct vcpu *v); +unsigned int vcpu_guest_file_id(const struct vcpu *v); + #endif /* ASM_RISCV_IMSIC_H */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382277.1625713 (Exim 4.92) (envelope-from ) id 1wrHNd-0001MP-04; Tue, 04 Aug 2026 15:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382277.1625713; Tue, 04 Aug 2026 15:48:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNc-0001KD-Nc; Tue, 04 Aug 2026 15:48:36 +0000 Received: by outflank-mailman (input) for mailman id 1382277; Tue, 04 Aug 2026 15:48:34 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNa-0000sO-GY for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNZ-009QNa-T6 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:33 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c8-5cb7-0a2a0a5109dd-0a2a450bdaba-26 for ; Tue, 04 Aug 2026 17:48:33 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d1-b7e8-0a2a450b0019-d1558030a46a-3 for ; Tue, 04 Aug 2026 17:48:33 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4994c49f588so545515e9.0 for ; Tue, 04 Aug 2026 08:48:33 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858513; x=1786463313; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yz5kOHNRF0KkwzsTFaIMw1rEUEyM76GxO23CT2jclP4=; b=Tvvh/o2fIIsOxbOs2SpkVCmn09HO2alCl9520s1PtkvRUkLSkPYcf0K0DfO6AD8Xm0 SKObNcqVl1LUlaRYc1h5PK45h8tl76FJ7x0smlvHFsU+KqU/fnGx/B/JQuiuHrx7cUXe p7BjeUdaQ6ld1JLAIAvE0D+9OZeG0NsEulO8ZhQjnbKS4VEPeaN0jCJ75AMxyhJLvyf7 FlSK9pGSpvRwb0UvQcpaoh39/0CWfVHsqIAJuaxPvthN8IVe6uldzTo4xL9s57u6nyQK Z/6W492qUgVjSZaHV/RNq4/Yp3/FqY7grg2B5ePEmAx8Zfau21i7oH32uL+DvtMGNo6G hF8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858513; x=1786463313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yz5kOHNRF0KkwzsTFaIMw1rEUEyM76GxO23CT2jclP4=; b=SjEAAWK/kV+pPXx8djLzuhekMbub36j/x5ISTc+jhbX9RjH/1KhCQHzmdJbIw1BVpa 4L1GpftR0selvYIATuZxwVJ9IJKszbM7VPP0ElmfEzk4ZBqj8kys7VUBM/hSyivREPP1 VZq5xCH4fQugJPYsRWOWRx91afAjeIxP00LqLFgyEtT7wDTqVtrabvPjS/9LtFqgZ1jI MmQ0YAaYE1zPHHSdCGd8qRlV3miEwsBuJz/CbNErTa7I6bFD5l0JNhTKyXG/y0AP+pFO JS7n2+1PwTVgWBblKmmfBC47teoC2xWo4P7M5cEmaaRCa2nssL36vdC6NKYshkDI4xAj fFAw== X-Gm-Message-State: AOJu0Yw3S8WxZWaWaDyl6WXmT+F+8kShUCBd9DVahoT3q3TKo1oPk/+6 k+ksuX0e9GlTDVNm0EycgEYbUU1TFJcoh0z1igDTeFpU/r0sqcd52BLQoZCOWA== X-Gm-Gg: AR+sD10CiLcnlPOZWrgVFekWp49QrRr89PSEtPhGFOZiGsZaIOpyYcJ7D+RehsDgo2A f30Fm25lLFhGfuF1d82XLgE6xm6bwCrX1hbwts747vX81+lbbJYr3OJp5n1+z36sgx+nd2zpWul TMA2cWvCX20tDGYOq/A9PKKE4zpUu1zaIYpCHJvOYsAkxPIyhIiQ9lOiedN3Ud7IFy3GWua3rq2 sdR3RfNLyj5qd+f4mFgAChMgNtKtU5fg8dQ0HpFTT0iWk0gPIbpQ5U3VIJr22I7hsnCigmgJrLS SBCQyIT9N6ZtQNGOtQSjrgvXK5Y3l04DTLx8vy4jx+O/IC+Cwd9faFOJPGIcQvU1P/NwY/huAWS dZOmPbSziGE46QGpr6pMQXfiFn18o4sx6t9Kd1NiuwU5k7NGZZpUvDpkHeRl2cvjkOpfpzoMwD0 Uo40g7Snfl86fWf+FymPt2va2yumILGJWxWVnaY+kfRQfDDAmoIkX4f6fNMUuKPsIoFoZhn37ez EJDfHeVyioXr8FsMRWfBrX3WNyaN7fjIw== X-Received: by 2002:a05:600c:1d1f:b0:497:ff5a:38b9 with SMTP id 5b1f17b1804b1-4994e39509emr554855e9.9.1785858513177; Tue, 04 Aug 2026 08:48:33 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 12/20] xen/riscv: introduce minimal virtual APLIC (vAPLIC) infrastructure Date: Tue, 4 Aug 2026 17:48:02 +0200 Message-ID: <7a592e36adcb805d87cb0d4c41f3aa96d7eb88e0.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785858513-A9CC79EA-2B2B96C7/10/73395122804 X-purgate-type: spam X-purgate-size: 9625 At the current development stage, only domain vINTC init and deinit operations are required, so implement those first. Initialize vAPLIC's domaincfg to with the interrupt-enable bit set and MSI delivery mode selected as the current solution is exepcted to have always IMSIC, and initialize vintc->ops. Other operations such as emulate_load(), emulate_store(), and is_access() will be needed once guests are running and MMIO accesses to APLIC MMIO range must be handled. These will be introduced separately later. Introduce a structure to describe a virtual interrupt controller (vINTC) and a vintc_ops structure, which provides operations to emulate load and store accesses to interrupt controller MMIOs and to check whether a given address falls within the MMIO range of a specific virtual interrupt controller. Note that already existed init_ops field in struct vintc will be init-ed for APLIC in the follow up patch. The vAPLIC implementation of these operations will be provided later once guests can be run and these operations are actually needed. Introduce these structures here as they are required for the implementation of domain_vaplic_init() and domain_vaplic_alloc(). Also, introduce vaplic_init() and init vintc_ops->vcpu_init() with it. Co-developed-by: Romain Caritey Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v7: - Add Acked-by: Jan Beulich . - Update the comment above init_ops member of vintc structure. --- Changes in v6: - Nothing changed. Only rebase. --- Changes in v5: - Add explanational comments for fields in struct vintc. - Drop unnessary empty line in asm/aplic.h. - Update the commit message to tell that init_ops will be init-ed later in follow up patch. - Init. .domaincfg with only APLIC_DOMAINCFG_RO. - Update the comment above APLIC_DOMAINCFG_RO. - Add defintion for APLIC_DOMAINCFG_BE. --- Changes in v4: - Change subject of the commit. - s/APLIC_DOMAINCFG_RO80/APLIC_DOMAINCFG_RO + added a comment above definition. - Drop unnessary blank lines. --- Changes in v3: - Drop ASSERT() before vintc->ops->vcpu_init() in arch_vcpu_create(); a NULL deref already produces a sufficient backtrace. - Parenthesize macro argument in to_vaplic(). - Drop __init from domain_vaplic_init() and domain_vaplic_deinit() since the caller domain_vintc_init() (follow-up patch) is not __init. - Remove pointless zero-initializer for rc in vcpu_vaplic_init(). - Fix domain_vaplic_deinit() to null d->arch.vintc before freeing, making the function idempotent. - Drop intc_irq_nums(), (*nr_irqs)(void) hook from intc_hw_operations, aplic_nr_irqs(), and vintc->nr_irqs field entirely. - Rename vcpu_vaplic_init() to vaplic_init() and drop vgein_assign() and imsic_set_guest_file_id() calls; those will be introduced/called later, where for sure we will know on which pCPU vCPU as it is required for proper h/w IMSIC interrupt file calculation, to have this initialization in one place. - Introduce vaplic_deinit(). --- Changes in v2: - s/vcpu/v for function arguments in struct vintc_ops(). - Update the comment above is_access() and drop const for addr argument. - Update to_vaplic() to work with 'struct domain *'. - Drop smsiaddrcfg{h} from vaplic_regs struct as they aren't used for now. - Drop inclusion of xen/schec.h from intc.c. - use result of xvzalloc() as initializer in vpalic_alloc(). - Drop goto in domain_vaplic_init(). - s/XVFREE/xvfree. - s/aplic/vintc. - Drop __init for vcpu_vaplic_init() as it could be called for secondary CPU bring up. - Drop vaplic_alloc(). - Drop vintc_ops struct, embed callbacks iniside struct vintc. - Introduce and init vintc irqs for vAPLIC. - Introduce intc_irq_nums() to properly initialize number of vAPLIC's irqs. --- --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/domain.c | 11 ++--- xen/arch/riscv/include/asm/aplic.h | 7 ++++ xen/arch/riscv/include/asm/intc.h | 12 ++++++ xen/arch/riscv/include/asm/vaplic.h | 34 ++++++++++++++++ xen/arch/riscv/vaplic.c | 62 +++++++++++++++++++++++++++++ 6 files changed, 119 insertions(+), 8 deletions(-) create mode 100644 xen/arch/riscv/include/asm/vaplic.h create mode 100644 xen/arch/riscv/vaplic.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 8e7a6370eee2..fcd73c7a2dd5 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -25,6 +25,7 @@ obj-y += smpboot.o obj-y += stubs.o obj-y += time.o obj-y += traps.o +obj-y += vaplic.o obj-y += vmid.o obj-y += vm_event.o obj-y += vsbi/ diff --git a/xen/arch/riscv/domain.c b/xen/arch/riscv/domain.c index c9933147595e..45712d305975 100644 --- a/xen/arch/riscv/domain.c +++ b/xen/arch/riscv/domain.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -155,14 +156,8 @@ int arch_vcpu_create(struct vcpu *v) if ( (rc = vcpu_vtimer_init(v)) ) goto fail; - /* - * As interrupt controller (IC) is not yet implemented, - * return an error. - * - * TODO: Drop this once IC is implemented. - */ - rc = -EOPNOTSUPP; - goto fail; + if ( (rc = v->domain->arch.vintc->ops->vcpu_init(v)) ) + goto fail; return rc; diff --git a/xen/arch/riscv/include/asm/aplic.h b/xen/arch/riscv/include/asm/aplic.h index b0724fe6f360..5a7fcb6ec4f1 100644 --- a/xen/arch/riscv/include/asm/aplic.h +++ b/xen/arch/riscv/include/asm/aplic.h @@ -15,8 +15,15 @@ #include +/* + * domaincfg read-only fields (AIA spec): + * - bits [31:24] -> read-only 0x80 + * - bit 7 -> read-only 0 + */ +#define APLIC_DOMAINCFG_RO (0x80U << 24) #define APLIC_DOMAINCFG_IE BIT(8, U) #define APLIC_DOMAINCFG_DM BIT(2, U) +#define APLIC_DOMAINCFG_BE BIT(0, U) #define APLIC_SOURCECFG_SM_INACTIVE 0x0 #define APLIC_SOURCECFG_SM_DETACH 0x1 diff --git a/xen/arch/riscv/include/asm/intc.h b/xen/arch/riscv/include/asm/intc.h index a4e678fad90b..875728885292 100644 --- a/xen/arch/riscv/include/asm/intc.h +++ b/xen/arch/riscv/include/asm/intc.h @@ -17,6 +17,7 @@ enum intc_variant { struct cpu_user_regs; struct irq_desc; struct kernel_info; +struct vcpu; struct intc_info { enum intc_variant hw_variant; @@ -53,8 +54,19 @@ struct vintc_init_ops { int (*make_domu_dt_node)(struct kernel_info *kinfo); }; +struct vintc_ops { + /* Initialize some vINTC-related stuff for a vCPU */ + int (*vcpu_init)(struct vcpu *v); + + /* Deinitialize some vINTC-related stuff for a vCPU */ + void (*vcpu_deinit)(struct vcpu *v); +}; + struct vintc { + /* Callbacks invoked during domain construction only. */ const struct vintc_init_ops *init_ops; + /* Runtime callbacks used for the lifetime of the guest. */ + const struct vintc_ops *ops; }; void intc_preinit(void); diff --git a/xen/arch/riscv/include/asm/vaplic.h b/xen/arch/riscv/include/asm/vaplic.h new file mode 100644 index 000000000000..96080bfbc23b --- /dev/null +++ b/xen/arch/riscv/include/asm/vaplic.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: MIT */ +/* + * xen/arch/riscv/vaplic.c + * + * Virtual RISC-V Advanced Platform-Level Interrupt Controller support + * + * Copyright (c) Microchip. + */ + +#ifndef ASM__RISCV__VAPLIC_H +#define ASM__RISCV__VAPLIC_H + +#include +#include + +#include + +struct domain; + +#define to_vaplic(d) container_of((d)->arch.vintc, struct vaplic, vintc) + +struct vaplic_regs { + uint32_t domaincfg; +}; + +struct vaplic { + struct vintc vintc; + struct vaplic_regs regs; +}; + +int domain_vaplic_init(struct domain *d); +void domain_vaplic_deinit(struct domain *d); + +#endif /* ASM__RISCV__VAPLIC_H */ diff --git a/xen/arch/riscv/vaplic.c b/xen/arch/riscv/vaplic.c new file mode 100644 index 000000000000..c813979a2ecb --- /dev/null +++ b/xen/arch/riscv/vaplic.c @@ -0,0 +1,62 @@ +/* SPDX-License-Identifier: MIT */ +/* + * xen/arch/riscv/vaplic.c + * + * Virtual RISC-V Advanced Platform-Level Interrupt Controller support + * + * Copyright (c) Microchip. + * Copyright (c) Vates + */ + +#include +#include +#include + +#include +#include +#include +#include + +#include "aplic-priv.h" + +static int cf_check vaplic_init(struct vcpu *v) +{ + return vcpu_imsic_init(v); +} + +static void cf_check vaplic_deinit(struct vcpu *v) +{ + return vcpu_imsic_deinit(v); +} + +static const struct vintc_ops vintc_ops = { + .vcpu_init = vaplic_init, + .vcpu_deinit = vaplic_deinit, +}; + +int domain_vaplic_init(struct domain *d) +{ + struct vaplic *vaplic = xvzalloc(struct vaplic); + + if ( !vaplic ) + return -ENOMEM; + + d->arch.vintc = &vaplic->vintc; + d->arch.vintc->ops = &vintc_ops; + + vaplic->regs.domaincfg = APLIC_DOMAINCFG_RO; + + return 0; +} + +void domain_vaplic_deinit(struct domain *d) +{ + struct vaplic *vaplic; + + if ( !d->arch.vintc ) + return; + + vaplic = to_vaplic(d); + d->arch.vintc = NULL; + xvfree(vaplic); +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382279.1625719 (Exim 4.92) (envelope-from ) id 1wrHNd-0001U4-QT; Tue, 04 Aug 2026 15:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382279.1625719; Tue, 04 Aug 2026 15:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNd-0001SR-Cl; Tue, 04 Aug 2026 15:48:37 +0000 Received: by outflank-mailman (input) for mailman id 1382279; Tue, 04 Aug 2026 15:48:35 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNb-00010v-Fh for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNa-009Gcw-SF for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:34 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c5-bab6-0a2a0a5309dd-0a2a4509cbee-26 for ; Tue, 04 Aug 2026 17:48:34 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d2-be1a-0a2a45090019-d1558031d14e-3 for ; Tue, 04 Aug 2026 17:48:34 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4955158f26aso23065955e9.3 for ; Tue, 04 Aug 2026 08:48:34 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858514; x=1786463314; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pNfWXKz7OiThFTVcFdBZ62/fmTIqtlbdTWRNjBnnGpc=; b=Dk6uZXJA6qAlrAEqZEzvjVa6D3gz9tyNKvBzDAAAQgXzM6TrstVeX6i/Kx9Wtd8slt wBrXRXMnQ2B13Pu0HJoZhB2VtqgBgIJE81v7HYSoRc07qMi6JG325CgQCJ3G/4tfJKrN t7115Sh2s5NnvwkimPGnReFyoFTBguMWT3T+THso8gnCSNKj/FTnijMed0ZTRX9eycV5 7XvyPUDv/2Fc2JIF6uvwXqKF2sCiK76hrC72/w4uAJ05CVYD1g50Kv8/TgzgB5U9QRsV rZz61yeDNVn/rOsD8q3WtFQVU7sJ0niKRxEl5PHsLuJeEHeJDuoWfWY9wMgZ/vtst+Ya YbMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858514; x=1786463314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=pNfWXKz7OiThFTVcFdBZ62/fmTIqtlbdTWRNjBnnGpc=; b=MhObpbTaYk2WRVx5jlNxzYZs/0plYNqVlwgVwDV4c3VDQcsyXCulswdVzZ/r/YdYpp s6GAqCyiBKQI5u2DqC5MzUWLXAbLvNB3F+rFfmgcXzAiwaB/fUvh3e/7g5TufJIhwoWq yHP+cKBcPIg9+9d6tOB2zOrGYS9sONw/vRi2e6DsZTBQekkjX9jEqzTnRMaCEQ8DkJvM TsFkisdP2VYZMmR+ns4XnjGTyNcE/rR01DaPAD71OwOPfZhWQafUA9MgHZztOUd37ZhI IytT0INBabW+9+HSI5rkrsOaIRTHpHKQE8/GDb1wcDvosMoEb33C3pxZBb6m8GJ4/0fd w/Mg== X-Gm-Message-State: AOJu0YzATc0rCfseCtAQKT5WMH+OLSjzsvczPd2qiQCGrd2gG2am8F/3 gR5/JGurlyDywMau3twEd4dCT5EvOWvBf4KaRbc1ghwrjfvWYiTM72t4AmWOyw== X-Gm-Gg: AR+sD127y/ABlsbUx3uvRb3z4y9MRGbMBC+31svGRHtDi543iAuj8l27akIMYknTjCm 5HyGXBcLijvg565hfdsZNxfm3bZOqaCHGu+PA8iROrenPlmtvsFDKXhkKMlx2GXMI1tUdxUaN7B HF1/qYwvbTMu7K4PBR76PyWeZEkD11KBVoANxiUIOqAqTa0XKEBHHqyjkw8EIIbXGD2O2WWvq0p DM4QRBaxuD8Th0V/kZ3gzcWvUIRxCYN4gA2nYfJvoZ4JUc3j9tEi6e1UShbqOM9u/Le0qaxCV05 f+0/ixr1K6oGVT5rIGb5zHWvgDFfgqLHb8omPy3Q0rbctSrIFkwaf8POQRs7guoAmL38myJg7Z9 RFBvNBYBJbw1U/hUrMOHycZFwqLUXVbmog9tG4bL5jU09EscHD+F4iejAWKnpZl5x7MeUGI3Hpi FNXt7hbUSv/ZkHDudYEDhnTjP/ydpwCu0wpTHzVCm8R4e+yesBeA0pyKyc4P+sfjI5jcsxEj2JR DcYVHK070iqgP6yzxkEF9MBHuRISipnZg== X-Received: by 2002:a05:600c:c113:b0:495:4689:1e98 with SMTP id 5b1f17b1804b1-4980c674e1dmr306196645e9.10.1785858514288; Tue, 04 Aug 2026 08:48:34 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 13/20] xen/riscv: introduce (de)initialization helpers for vINTC Date: Tue, 4 Aug 2026 17:48:03 +0200 Message-ID: <30c9d0f24a2e9b8ffafebb33a832ff0d61671544.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785858514-FCE14034-DB5ECD08/10/73395122804 X-purgate-type: spam X-purgate-size: 3635 Add common helpers domain_vintc_init() and domain_vintc_deinit() to allocate and deallocate a virtual interrupt controller (vINTC) structure and initialize basic virtual interrupt controller registers. domain_vintc_deinit() isn't called at the moment as arch_domain_destroy() is implemented as stub at the moment. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v6-7: - Nothing changed. Only rebase. --- Changes in v5: - s/printk/printk_once(). - Add Acked-by: Jan Beulich . --- Changes in v4: - Drop the comment from domain_vintc_init() about guests receiving a virtual interrupt controller that mirrors the host hardware as there can (and eventually should) be alternatives. - Finish renaming intc_version to intc_variant in domain_vintc_(de)init() (enum intc_variant, info->hw_variant, local variable) started in the prev patch. --- Changes in v3: - Drop redundant printk() from domain_vintc_deinit()'s default case to avoid duplicate messages when init fails. - Add a comment to domain_vintc_init() clarifying that guests currently receive a virtual interrupt controller that mirrors the host hardware. --- Changes in v2: - Drop __init for domain_vintc_(de)init(). - Update the commit message. --- --- xen/arch/riscv/domain.c | 3 +++ xen/arch/riscv/include/asm/intc.h | 3 +++ xen/arch/riscv/intc.c | 35 +++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+) diff --git a/xen/arch/riscv/domain.c b/xen/arch/riscv/domain.c index 45712d305975..4db9c28662c7 100644 --- a/xen/arch/riscv/domain.c +++ b/xen/arch/riscv/domain.c @@ -308,6 +308,9 @@ int arch_domain_create(struct domain *d, if ( (rc = p2m_init(d, config)) != 0) goto fail; + if ( (rc = domain_vintc_init(d)) ) + goto fail; + return rc; fail: diff --git a/xen/arch/riscv/include/asm/intc.h b/xen/arch/riscv/include/asm/intc.h index 875728885292..6fc0e620e937 100644 --- a/xen/arch/riscv/include/asm/intc.h +++ b/xen/arch/riscv/include/asm/intc.h @@ -79,4 +79,7 @@ void intc_route_irq_to_xen(struct irq_desc *desc, unsigned int priority); void intc_handle_external_irqs(struct cpu_user_regs *regs); +int domain_vintc_init(struct domain *d); +void domain_vintc_deinit(struct domain *d); + #endif /* ASM__RISCV__INTERRUPT_CONTOLLER_H */ diff --git a/xen/arch/riscv/intc.c b/xen/arch/riscv/intc.c index 2864a896b677..f5c8af6ddea4 100644 --- a/xen/arch/riscv/intc.c +++ b/xen/arch/riscv/intc.c @@ -11,6 +11,7 @@ #include #include +#include static const struct intc_hw_operations *__ro_after_init intc_hw_ops; @@ -83,3 +84,37 @@ int __init make_intc_domU_node(struct kernel_info *kinfo) return vintc->init_ops->make_domu_dt_node(kinfo); } + +int domain_vintc_init(struct domain *d) +{ + int ret = -EOPNOTSUPP; + const enum intc_variant variant = intc_hw_ops->info->hw_variant; + + switch ( variant ) + { + case INTC_APLIC: + ret = domain_vaplic_init(d); + break; + + default: + printk_once("vintc (variant:%d) isn't implemented\n", variant); + break; + } + + return ret; +} + +void domain_vintc_deinit(struct domain *d) +{ + const enum intc_variant variant = intc_hw_ops->info->hw_variant; + + switch ( variant ) + { + case INTC_APLIC: + domain_vaplic_deinit(d); + break; + + default: + break; + } +} -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382280.1625725 (Exim 4.92) (envelope-from ) id 1wrHNf-0001dU-3X; Tue, 04 Aug 2026 15:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382280.1625725; Tue, 04 Aug 2026 15:48:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNe-0001bl-6I; Tue, 04 Aug 2026 15:48:38 +0000 Received: by outflank-mailman (input) for mailman id 1382280; Tue, 04 Aug 2026 15:48:37 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNc-0001I1-LM for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNc-009Gcw-1e for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:36 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c9-bab6-0a2a0a5309dd-0a2a4508eace-12 for ; Tue, 04 Aug 2026 17:48:35 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d3-f659-0a2a45080019-d1558033ac15-3 for ; Tue, 04 Aug 2026 17:48:35 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-495590dde14so34298045e9.0 for ; Tue, 04 Aug 2026 08:48:35 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858515; x=1786463315; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=l7ZIghm4wlZpqQWikoFDy/4FVF6m3wHWKUUWrNvkWao=; b=ZTtd98gIekj8jEQRyKWKcBTNE6Pd8sn+nYTZsJfn9tDcE+mMVW6LsaZUhPpweZEZAV 37nmU3i9gsPYsg9lbi3vicfBjZ1yy0o2DgdlW3ziIxeg8OHGW1SnmEPCZCMeps6MGIzJ 2s9h+ueoOnnXUyS7FVarmeF1fUEedBnStMq13Udth8vYkoxRzgdBI5a7tEJuajHUelEU dxWJu/sYCvTrRldA3ILn/tQISeAkMw1vm+eGBa4S1fgKMYPJnDD4bAGuX7sNj3wAD445 nCP9FutvThgjTvJVO5W8HRXYiiA5Y7UZwrVgKQT7mfi3aDf+PiqQf+IcifOCU0twdeH5 URPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858515; x=1786463315; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l7ZIghm4wlZpqQWikoFDy/4FVF6m3wHWKUUWrNvkWao=; b=CHHoqig/WU5M6+xWzN0oz8sH0uc7pwR/LIXLJeULMxJXPVD90hFIFI80K1Uw6up+SY wRGA6UeKqSQkIZ4qpDSY+9k4c39NYhbkrJo7uOpbhesbXQ1PNMwc7ysx68INwZ+uGbt4 3fNygtA9XMxddfWZO841tsPXfklWoS4Kw61BYh6q+oePcUCuDpBaWXdQOepyuNH78/Ar Pi06yfrO0xiv7dUEe724ysWPm1i/Q1NJM3jCrRRt0gkSdyLOcvSlyrQeJ9DlRWUSQvCv Bp3Mr7cnlYZ8EoPazIurtFqZRahRDQxiXqpzC0llD7x1KW2cko88v3MCIlMGVcmGQpFC HvWA== X-Gm-Message-State: AOJu0Yx3K58epaimVj6G4JIdnLs6nSZI6ivtF6zoSU7uVkDtE64jlCOy lcu1Nlv6IVKPi1pkQ+znmU1NesGgLfJQyg7tOMsA/97zg0gfnN6AdXYMhfMcNg== X-Gm-Gg: AR+sD11xTBXWCcEWlh0tETy/kgeLuVl8+tE3FbxhpIL9EDM+XVnWvumrff9V1OBv/N5 icQSGWhuRDodfOotMQs2lnejplhuVD+1GNe5OAWaInX/1O1jpBEpg40o3iiPb14wn4i77wOhyms 7MUhMRX3VZtlhwwcj4Vn9DDC4tXRJzAmcDdQcgHgHxOvVkwex5XNVMhN27+qReImL7Zzqr+UgqJ 7uLJmSUx/4lC08hjE8j7O5Sue13H0EOEM3mMC/L4WaSAXvUaFIYRCmOGcX5tMztdFlL/eyRQP8N KA9m8qW8/ywWxNDVkBnjNUS4aRznjU/tUzHSskz/z6aXBIqCt0XMktlU+Rb2d22ghQ3kc9hftix MFFiDQTxoH4Tu2T1iPHI3sMEAyqJ/bYtZ5I8NDoE6RbEY6qJ0wGdXNB7QNaVBnO0udUhBNlOuzI TR1bTRPdCac8L3/N7Y1L4m0UmMpyGaoGlgsKRGinoUNXrCDWijjNES0ZSNcq9/Zl2krVZPypZqi J0wVLXV3UkFnyhmgrr++419v1tpYYvKDg== X-Received: by 2002:a05:600c:8b54:b0:495:4859:8f9b with SMTP id 5b1f17b1804b1-4980c674f25mr402292425e9.9.1785858515349; Tue, 04 Aug 2026 08:48:35 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 14/20] xen/riscv: generate IMSIC DT node for guest domains Date: Tue, 4 Aug 2026 17:48:04 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785858515-D497287B-E186827D/10/73395122804 X-purgate-type: spam X-purgate-size: 10732 Guests using the IMSIC interrupt controller require a corresponding Device Tree description. Add support for generating an IMSIC node when building the guest DT. This allows guests to discover and use the IMSIC interrupt controller. The value choosen for GUEST_IMSIC_S_BASE is an address which is typically used for IMSIC and QEMU. DT-building functions are marked __init because domain creation happens at boot time, before the init sections are freed. In a typical deployment libxl creates the interrupt controller node in userspace and hands the complete FDT to Xen, so these functions are only called during early domain construction. Co-developed-by: Romain Caritey Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v7: - Add Acked-by: Jan Beulich . --- Changes in v6: - Simplify initialization of guest_num_msis. - s/sizeof(vimsic_name)/ARRAY_SIZE(...). - Add empty line between declaration(s) and statement(s) in make_domu_dt_node(). - define GUEST_IMSIC_MAX_MSIS as 255U to avoid '+0U' when min(...) is used. --- Changes in v5: - s/GUEST_IMSIC_NUM_MSIS/GUEST_IMSIC_MAX_MSIS throughout. - Changed __read_mostly → __ro_after_init on guest_num_msis, since the value is set once during __init and never again. - Made imsic_parse_node() __init. - Moved the min(GUEST_IMSIC_MAX_MSIS, ...) cap into imsic_parse_node() right after guest_num_msis is assigned, so the bound is applied once at init time rather than on every DT node construction call. - Removed the now-unnecessary num_msis local variable from vimsic_make_domu_dt_node(); guest_num_msis is used directly. - s/snprintf(buf, sizeof(buf), ...)/snprintf(buf, ARRAY_SIZE(buf), ...) in guest_imsic_set_interrupt_extended_prop(). - Added decl. of vimsic_make_domu_dt_node() in this patch instead of next. --- Changes in v4: - Add a comment for guest_num_msis explaining that it is host-dependent and therefore identical for every domain, which is why a single global is used instead of a per-domain value. - Reduce vimsic_name[] from 128 to 32 bytes, which is enough to hold "/soc/imsic@" plus a 64-bit hex address. - Add a comment before GUEST_IMSIC_S_BASE noting that the value is the address typically used for IMSIC by QEMU. - s/__ULL/_UL for defintion of GUEST_IMSIC_S_BASE. --- Changes in v3: - s/__ro_after_init/__read_mostly for guest_num_msis. - Use IMSIC_MAX_ID as default for guest_num_msis instead of imsic_cfg.nr_ids. - Drop base_addr local variable in guest_imsic_make_reg_property(); use GUEST_IMSIC_S_BASE directly and introduce size to avoid spelling IMSIC_MMIO_PAGE_SZ * d->max_vcpus twice. - Change irq_ext type from uint32_t * to __be32 * in guest_imsic_set_interrupt_extended_prop(). - Move phandle declaration into the loop body. - Extend commit message to explain why __init is used for DT-building functions: libxl creates the interrupt controller node before handing the FDT to Xen, so these functions are only invoked during boot-time domain construction. - Re-order patch before APLIC DT node creation patch. - Update commit message. --- Changes in v2: - s/imsic_make_reg_property/guest_imsic_make_reg_property. - s/imsic_set_interrupt_extended_prop/guest_imsic_set_interrupt_extended_prop. - Use initalizer for regs[] array in imsic_make_reg_property(). - Move buf[] insde the for() loop. - Correct check of returned phandle. - Drop local variable len. - /s/XVFREE/xvfree in imsic_set_interrupt_extended_prop(). - Drop initializer for local variable data. - s/uint32_t/unsinged int for pos and cpu in imsic_set_interrupt_extended_prop(). - Drop next_phandle as it is now in common code. - Introduce vcpu_imsic_deinit. - Refactor vimsic_make_domu_dt_node() to avoid usage of host IMSIC dt node. --- --- xen/arch/riscv/imsic.c | 143 +++++++++++++++++++++- xen/arch/riscv/include/asm/guest-layout.h | 6 + xen/arch/riscv/include/asm/imsic.h | 3 + 3 files changed, 151 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/imsic.c b/xen/arch/riscv/imsic.c index 5a5758e45dc2..ffce77209c26 100644 --- a/xen/arch/riscv/imsic.c +++ b/xen/arch/riscv/imsic.c @@ -13,8 +13,12 @@ #include #include #include +#include #include +#include +#include #include +#include #include #include #include @@ -34,6 +38,21 @@ static struct imsic_config imsic_cfg = { .lock = SPIN_LOCK_UNLOCKED, }; +/* + * Number of MSIs available to a guest. Determined by the host interrupt + * controller, so it is identical for every domain -- hence a single global + * rather than a per-domain value. + */ +static unsigned int __ro_after_init guest_num_msis; + +#define GUEST_IMSIC_COMPATIBLE "riscv,imsics" + +/* + * Value is inspired by what QEMU is using for riscv,num-ids property for IMSIC + * node. + */ +#define GUEST_IMSIC_MAX_MSIS 255U + #define IMSIC_DISABLE_EIDELIVERY 0 #define IMSIC_ENABLE_EIDELIVERY 1 #define IMSIC_DISABLE_EITHRESHOLD 1 @@ -182,7 +201,7 @@ static int __init imsic_get_parent_hartid(const struct dt_device_node *node, * or IRQ_M_EXT if the IMSIC node corresponds to a machine-mode IMSIC, * which should be ignored by the hypervisor. */ -static int imsic_parse_node(const struct dt_device_node *node, +static int __init imsic_parse_node(const struct dt_device_node *node, unsigned int *nr_parent_irqs, unsigned int *nr_mmios) { @@ -285,6 +304,11 @@ static int imsic_parse_node(const struct dt_device_node *node, return -ENOENT; } + if ( dt_property_read_u32(node, "riscv,num-guest-ids", &tmp) ) + guest_num_msis = min(GUEST_IMSIC_MAX_MSIS, tmp); + else + guest_num_msis = GUEST_IMSIC_MAX_MSIS; + if ( (imsic_cfg.nr_ids < IMSIC_MIN_ID) || (imsic_cfg.nr_ids > IMSIC_MAX_ID) ) { @@ -522,3 +546,120 @@ int __init imsic_init(const struct dt_device_node *node) return rc; } + +static int __init guest_imsic_make_reg_property(struct domain *d, void *fdt) +{ + paddr_t size = IMSIC_MMIO_PAGE_SZ * d->max_vcpus; + __be32 regs[4] = { + cpu_to_be32(GUEST_IMSIC_S_BASE >> 32), + cpu_to_be32(GUEST_IMSIC_S_BASE), + cpu_to_be32(size >> 32), + cpu_to_be32(size), + }; + + return fdt_property(fdt, "reg", regs, sizeof(regs)); +} + +static int __init guest_imsic_set_interrupt_extended_prop(struct domain *d, + void *fdt) +{ + unsigned int cpu, pos = 0; + __be32 *irq_ext; + int res; + + irq_ext = xvzalloc_array(__be32, d->max_vcpus * 2); + if ( !irq_ext ) + return -ENOMEM; + + for ( cpu = 0; cpu < d->max_vcpus; cpu++ ) + { + char buf[64]; + uint32_t phandle; + + snprintf(buf, ARRAY_SIZE(buf), "/cpus/cpu@%u/interrupt-controller", cpu); + phandle = fdt_get_phandle(fdt, fdt_path_offset(fdt, buf)); + + if ( !phandle ) + { + res = -ENODEV; + goto out; + } + + irq_ext[pos++] = cpu_to_be32(phandle); + irq_ext[pos++] = cpu_to_be32(IRQ_S_EXT); + } + + res = fdt_property(fdt, "interrupts-extended", irq_ext, + d->max_vcpus * 2 * sizeof(*irq_ext)); + + out: + xvfree(irq_ext); + + return res; +} + +int __init vimsic_make_domu_dt_node(struct kernel_info *kinfo, + unsigned int *phandle) +{ + int res; + void *fdt = kinfo->fdt; + char vimsic_name[32]; + unsigned int vimsic_phandle; + + res = snprintf(vimsic_name, ARRAY_SIZE(vimsic_name), "/soc/imsic@%lx", + GUEST_IMSIC_S_BASE); + if ( res >= ARRAY_SIZE(vimsic_name) ) + { + dprintk(XENLOG_DEBUG, "vimsic name is truncated\n"); + return -ENOBUFS; + } + + res = fdt_begin_node(fdt, vimsic_name); + if ( res ) + return res; + + res = fdt_property_string(fdt, "compatible", GUEST_IMSIC_COMPATIBLE); + if ( res ) + return res; + + res = guest_imsic_make_reg_property(kinfo->bd.d, fdt); + if ( res ) + return res; + + res = guest_imsic_set_interrupt_extended_prop(kinfo->bd.d, fdt); + if ( res ) + return res; + + res = fdt_property_u32(fdt, "riscv,num-ids", guest_num_msis); + if ( res ) + return res; + + res = fdt_property(fdt, "msi-controller", NULL, 0); + if ( res ) + return res; + + res = fdt_property_u32(fdt, "#msi-cells", 0); + if ( res ) + return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if ( res ) + return res; + + res = fdt_property_u32(fdt, "#interrupt-cells", 0); + if ( res ) + return res; + + vimsic_phandle = alloc_phandle(kinfo); + if ( !vimsic_phandle ) + return -EOVERFLOW; + + res = fdt_property_cell(fdt, "phandle", vimsic_phandle); + if ( res ) + return res; + + if ( phandle ) + *phandle = vimsic_phandle; + + return fdt_end_node(fdt); +} diff --git a/xen/arch/riscv/include/asm/guest-layout.h b/xen/arch/riscv/include/asm/guest-layout.h index 68d95a09394c..5e566450bdfa 100644 --- a/xen/arch/riscv/include/asm/guest-layout.h +++ b/xen/arch/riscv/include/asm/guest-layout.h @@ -3,6 +3,12 @@ #include +/* + * Base address of the guest's supervisor-mode IMSIC. The value is the address + * typically used for IMSIC by QEMU. + */ +#define GUEST_IMSIC_S_BASE _UL(0x28000000) + #define GUEST_RAM_BANKS 2 /* diff --git a/xen/arch/riscv/include/asm/imsic.h b/xen/arch/riscv/include/asm/imsic.h index e2c413487d24..e1ec3d03c4e9 100644 --- a/xen/arch/riscv/include/asm/imsic.h +++ b/xen/arch/riscv/include/asm/imsic.h @@ -78,6 +78,7 @@ struct vimsic_state { }; struct dt_device_node; +struct kernel_info; struct vcpu; int imsic_init(const struct dt_device_node *node); @@ -93,4 +94,6 @@ int vcpu_imsic_init(struct vcpu *v); void vcpu_imsic_deinit(struct vcpu *v); unsigned int vcpu_guest_file_id(const struct vcpu *v); +int vimsic_make_domu_dt_node(struct kernel_info *kinfo, unsigned int *phandle); + #endif /* ASM_RISCV_IMSIC_H */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382281.1625732 (Exim 4.92) (envelope-from ) id 1wrHNi-00024O-A0; Tue, 04 Aug 2026 15:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382281.1625732; Tue, 04 Aug 2026 15:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNh-00020M-7G; Tue, 04 Aug 2026 15:48:41 +0000 Received: by outflank-mailman (input) for mailman id 1382281; Tue, 04 Aug 2026 15:48:38 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNd-0001Uq-S6 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNd-009GkK-8R for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:37 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209d5-e002-0a2a0a5209dd-0a2a4507cb76-2 for ; Tue, 04 Aug 2026 17:48:37 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d4-b4ea-0a2a45070019-d1558030d9a3-3 for ; Tue, 04 Aug 2026 17:48:37 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4954a32cf1eso16288195e9.3 for ; Tue, 04 Aug 2026 08:48:37 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858516; x=1786463316; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lLGWWikfegmq1d6uXZbQV5K+lLsNHD8dZ0j3uuHsqqQ=; b=rA8tZNhn33A8EsPIN5q3K4SEIb1pdOnMsx0lSgwwovCe5Ti2znKlsierFNKMYnAWuc DpTy42hvPgraFOb748R1Bl2fivVGnA6cj2r32qKW4Gmbg2qb7gRf6B0RlTA0QUj7M4nV 1IX9Sj4D1EFjnGPbHIlCdetDNqbjq2appRBHUKD0n9ORgBoyFN0kczY/090VhotUqf+C YPsuiExbi5WTgM8mSU5F5zWhybVpcLESBrZDtLXBj4RGGeyVJz4OIHcQNLHvEUHkgk9O LXonRg5GbFAFjOP6MPbx4HaEHyQaV4VW2hgqenWcmXbXqE5Ffw03LAjqTWqushO2KyS8 ZLmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858516; x=1786463316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lLGWWikfegmq1d6uXZbQV5K+lLsNHD8dZ0j3uuHsqqQ=; b=FthLbcK+N1WLynPLnxUOfyRGJGTq8FbxzQovsCh/SdSiV7x8j2aNQB6ktMm33VSnPG dz8BmlsvvUaXKpnu8T7u7vlnDL1RorZQvjkg1JGAjosv7JAbvMdPGmJ4s/hwxkkJT0Tg Tj8qjOgKpfyGa2yUoaLWRXO8wPcgiBfN4LGlDc5AeDwn6Zbpc7rYHBfuh5cnNrRl2cIY RjfMzUoVPNGMAauOoTsbDb8NfEA/6ralNKwvFkn2niMjFW3cAfy1UlFufYSbOTq5iGRJ rge1x0ysJ+nmy5kFyMu9uf/mQzaNxV/g07WJCiVpWCpElqo6EImYJGYf+VH6MBmeSBUO MH4A== X-Gm-Message-State: AOJu0YzzxLdP7N5iHv99E+t3LVJiMZ2fnUkI9Ka1VGEf6HWa/DmJe00j YI+cLdJebG25nNvZvwirYlIAAhpTPNmDy/nmCp4Mk5DyOKt6UApRzKS3dD6nvQ== X-Gm-Gg: AR+sD13fyewUVOxokvqTyyPw/S12dwQQwaQVnGS2t2H5tWvOEd7FnTxmdxSUoleJeLH Bgf4fATc8Dx+LDS+6c/7NkvbZXvLzqDVl188H9qnzpx6s8wzBzXE39RjwJlOYTFR7qur5bg8Wqw uKCQR5dYmhAkiPY6AZYnBAWlT4V707mOe7SrL47GfYjcBN4yi7rW7ttKn1s/OOZFeY0mjQ6W7Jz D9BE9YdljV4NPmr/ImokTD8Mqd0yRGwKlnll15b+9otVuEovjsge+NqL2A4GIKmhcVur2QBTVM8 vUBeP2RIcSfk2roZp2AcA1liRLDBmhnTxV5XbhcyrTS2hwJ4i2Mr6h0wUu16I2c5ylmAn0Hpe7q ADn0Clf2sN55CL1jY8I2PJQBgSaMu68nlnyg4zg8BbDKRnNGzBKVG15cn3G7/hl7EnjoMPBmW4D /1QksUlHdn0/xCZfQfTkEHXBPKymaLvjGcaDG5R1rG4EEmsgVQBJRBbrQKrRHg+HD4Lx1lKhyzk m54JY1rRha+H8CEOqLVQCx5npVPvtKVa+hXdSS30h/+ X-Received: by 2002:a05:600c:19cf:b0:498:2b1f:e0c6 with SMTP id 5b1f17b1804b1-4982b1fe255mr170113975e9.18.1785858516531; Tue, 04 Aug 2026 08:48:36 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 15/20] xen/riscv: create APLIC DT node for guest domains Date: Tue, 4 Aug 2026 17:48:05 +0200 Message-ID: <6ecfa02afc7237ee229a1ca2d12369b226ca816f.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1785858517-A5CC7AE4-A83E76A3/10/73395122804 X-purgate-type: spam X-purgate-size: 9020 Guests require a Device Tree description of the interrupt controller topology. Add support for creating an APLIC node when building the guest DT. Provide stub for imsic_make_dt_node() it will be introduced properly in follow-up patch. The value chosen for GUEST_APLIC_S_BASE is based on QEMU one. DT-building functions are marked __init because domain creation happens at boot time, before the init sections are freed. In a typical deployment libxl creates the interrupt controller node in userspace and hands the complete FDT to Xen, so these functions are only called during early domain construction. Co-developed-by: Romain Caritey Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v7: - Update the comment for guest_aplic_num_sources: drop "wired" to be less confusing, and mention that it is identical for every domain only for now. - Use ARRAY_SIZE() instead of sizeof() for the size argument of snprintf() in vaplic_make_domu_dt_node(). - Add Acked-by: Jan Beulich --- Changes in v6: - Redefine GUEST_APLIC_MAX_SOURCES as 96U to avoid '+OU' in min(...). - s/guest_num_sources/guest_aplic_num_sources. --- Changes in v5: - Drop pointless initializer for local variable res in vaplic_make_domu_dt_node(). - Limit guest_num_sources in the similar way to IMSIC. - Rename VAPLIC_NUM_SOURCES to GUEST_APLIC_MAX_SOURCES to be aligned with the similar place in vIMSIC related code. --- Changes in v4: - Drop spurious and includes from aplic.c (mistakenly added, they belong to vaplic.c). - Reduce vaplic_name[] from 128 to 32 bytes in vaplic_make_domu_dt_node(). - Use __initconstrel (with const) for init_ops instead of __initdata. - s/__ULL/_UL for defintion of GUEST_APLIC_S_BASE. --- Changes in v3: - Fix rebase conflicts becuase of this patch is reordered after IMSIC DT node creation is intoduced. - Update the commit message. - Move initialization of domaincfg with APLIC_DOMAINCFG_RO80 from this patch to earlier. - Change paddr_t aplic_size to unsigned int in vaplic_make_domu_dt_node() and replace the UB (after it started to be uint) aplic_size >> 32 with an explicit 0 in the DT reg property. - Add BUILD_BUG_ON() to be sure that aplic size isn't bigger then UINT32_MAX. --- Changes in v2: - Avoid as max as possible of host properties inheritance. Only number of APLIC's irqs are checked what leads to an introduction of get_aplic_irqs_num(). - Move this patch earlier what leads to an introduction of vimsic_make_domu_dt_node() stub. - s/vimsic_make_domu_dt_node/imsic_make_domu_dt_node. - Refactor vimsic_make_domu_dt_node() to avoid re-usage of APLIC host properties. - Drop next_phandle as it is now in common code. - Drop const for kinfo argument of vimsic_make_domu_dt_node() is is going to be updated inside vimsic_make_domu_dt_node(). - Use introduced before vintc->num_irqs. --- --- xen/arch/riscv/aplic-priv.h | 13 ++++ xen/arch/riscv/aplic.c | 2 + xen/arch/riscv/include/asm/aplic.h | 8 +++ xen/arch/riscv/include/asm/guest-layout.h | 6 ++ xen/arch/riscv/vaplic.c | 77 +++++++++++++++++++++++ 5 files changed, 106 insertions(+) diff --git a/xen/arch/riscv/aplic-priv.h b/xen/arch/riscv/aplic-priv.h index 85e0d028d1ae..35100d3a64fe 100644 --- a/xen/arch/riscv/aplic-priv.h +++ b/xen/arch/riscv/aplic-priv.h @@ -34,4 +34,17 @@ struct aplic_priv { const struct imsic_config *imsic_cfg; }; +/* + * Value is inspired by what QEMU is using for riscv,num-sources property for + * APLIC node. + */ +#define GUEST_APLIC_MAX_SOURCES 96U + +/* + * Specifies the number of interrupt sources supported by guest APLIC domain. + * Could be limited by host interrupt controller and is identical for every + * domain for now. + */ +extern unsigned int guest_aplic_num_sources; + #endif /* ASM_RISCV_APLIC_PRIV_H */ diff --git a/xen/arch/riscv/aplic.c b/xen/arch/riscv/aplic.c index d08401db46b3..c2d7183e1852 100644 --- a/xen/arch/riscv/aplic.c +++ b/xen/arch/riscv/aplic.c @@ -92,6 +92,8 @@ static int __init cf_check aplic_init(void) panic("%s: failed to get number of interrupt sources\n", node->full_name); + guest_aplic_num_sources = min(GUEST_APLIC_MAX_SOURCES, aplic_info.num_irqs); + if ( aplic_info.num_irqs > ARRAY_SIZE(aplic.regs->sourcecfg) ) aplic_info.num_irqs = ARRAY_SIZE(aplic.regs->sourcecfg); diff --git a/xen/arch/riscv/include/asm/aplic.h b/xen/arch/riscv/include/asm/aplic.h index 5a7fcb6ec4f1..07318aaac25d 100644 --- a/xen/arch/riscv/include/asm/aplic.h +++ b/xen/arch/riscv/include/asm/aplic.h @@ -34,6 +34,14 @@ #define APLIC_TARGET_HART_IDX_SHIFT 18 +#define APLIC_IDC_SIZE 32 + +#define APLIC_MIN_SIZE 0x4000 +#define APLIC_SIZE_ALIGN(x) ROUNDUP(x, APLIC_MIN_SIZE) + +#define APLIC_SIZE(nr_cpus) (APLIC_MIN_SIZE + \ + APLIC_SIZE_ALIGN(APLIC_IDC_SIZE * (nr_cpus))) + struct aplic_regs { uint32_t domaincfg; /* 0x0000 */ uint32_t sourcecfg[1023]; /* 0x0004 */ diff --git a/xen/arch/riscv/include/asm/guest-layout.h b/xen/arch/riscv/include/asm/guest-layout.h index 5e566450bdfa..90603f06bb91 100644 --- a/xen/arch/riscv/include/asm/guest-layout.h +++ b/xen/arch/riscv/include/asm/guest-layout.h @@ -3,6 +3,12 @@ #include +/* + * Base address of the guest's supervisor-mode APLIC. The value is the address + * typically used for APLIC by QEMU. + */ +#define GUEST_APLIC_S_BASE _UL(0xd000000) + /* * Base address of the guest's supervisor-mode IMSIC. The value is the address * typically used for IMSIC by QEMU. diff --git a/xen/arch/riscv/vaplic.c b/xen/arch/riscv/vaplic.c index c813979a2ecb..72bb2c4dc3c5 100644 --- a/xen/arch/riscv/vaplic.c +++ b/xen/arch/riscv/vaplic.c @@ -9,6 +9,8 @@ */ #include +#include +#include #include #include @@ -19,6 +21,12 @@ #include "aplic-priv.h" +unsigned int __ro_after_init guest_aplic_num_sources; + +#define VAPLIC_COMPATIBLE "riscv,aplic" + +#define FDT_VAPLIC_INT_CELLS 2 + static int cf_check vaplic_init(struct vcpu *v) { return vcpu_imsic_init(v); @@ -29,6 +37,74 @@ static void cf_check vaplic_deinit(struct vcpu *v) return vcpu_imsic_deinit(v); } +static int __init cf_check vaplic_make_domu_dt_node(struct kernel_info *kinfo) +{ + struct domain *d = kinfo->bd.d; + int res; + void *fdt = kinfo->fdt; + unsigned int msi_parent_phandle; + char vaplic_name[32]; + unsigned int aplic_size = APLIC_SIZE(d->max_vcpus); + const __be32 reg[] = { + cpu_to_be32(GUEST_APLIC_S_BASE >> 32), + cpu_to_be32(GUEST_APLIC_S_BASE), + cpu_to_be32(0), + cpu_to_be32(aplic_size), + }; + + BUILD_BUG_ON(APLIC_SIZE(MAX_VIRT_CPUS) > UINT_MAX); + + res = snprintf(vaplic_name, ARRAY_SIZE(vaplic_name), "/soc/aplic@%lx", + GUEST_APLIC_S_BASE); + if ( res >= sizeof(vaplic_name) ) + { + dprintk(XENLOG_DEBUG, "vaplic name is truncated\n"); + return -ENOBUFS; + } + + res = vimsic_make_domu_dt_node(kinfo, &msi_parent_phandle); + if ( res ) + return res; + + res = fdt_begin_node(fdt, vaplic_name); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#interrupt-cells", FDT_VAPLIC_INT_CELLS); + if ( res ) + return res; + + res = fdt_property(fdt, "reg", reg, sizeof(reg)); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "riscv,num-sources", guest_aplic_num_sources); + if ( res ) + return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if ( res ) + return res; + + res = fdt_property_string(fdt, "compatible", VAPLIC_COMPATIBLE); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "msi-parent", msi_parent_phandle); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "phandle", kinfo->phandle_intc); + if ( res ) + return res; + + return fdt_end_node(fdt); +} + +static const struct vintc_init_ops __initconstrel init_ops = { + .make_domu_dt_node = vaplic_make_domu_dt_node, +}; + static const struct vintc_ops vintc_ops = { .vcpu_init = vaplic_init, .vcpu_deinit = vaplic_deinit, @@ -43,6 +119,7 @@ int domain_vaplic_init(struct domain *d) d->arch.vintc = &vaplic->vintc; d->arch.vintc->ops = &vintc_ops; + d->arch.vintc->init_ops = &init_ops; vaplic->regs.domaincfg = APLIC_DOMAINCFG_RO; -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382283.1625736 (Exim 4.92) (envelope-from ) id 1wrHNj-0002CY-34; Tue, 04 Aug 2026 15:48:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382283.1625736; Tue, 04 Aug 2026 15:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNi-0002Af-8q; Tue, 04 Aug 2026 15:48:42 +0000 Received: by outflank-mailman (input) for mailman id 1382283; Tue, 04 Aug 2026 15:48:39 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNf-0001hs-7W for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNe-009GkK-I9 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:38 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c7-e002-0a2a0a5209dd-0a2a450a9cf8-22 for ; Tue, 04 Aug 2026 17:48:38 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d6-f2d2-0a2a450a0019-d155802dcd15-3 for ; Tue, 04 Aug 2026 17:48:38 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-498028b3d5eso35007495e9.1 for ; Tue, 04 Aug 2026 08:48:38 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858518; x=1786463318; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C5MjzH6tWZC1vulhg4mfpL7kW1xzkWEA9okhBx32l/4=; b=BGjXKKHSX+OxGm7JiMS1/+msZoeIiY5qyUFqLHUIdRsrBHFK17RTbIRW95oZ08j2wM raXjmOXfF5+GoKrRxvuVNNUo2S6O05ZFoBLEOWJtK3ke3MSbdFYLKqCsEeIv451L5asx x2QfIMgkGw9ji3EzMa6XDdijhIx1TC8U4RYdRa0+yI1rRYQxli+Pw5+dDiLqxH1LuUCD DnpGO6lkwEOnJPOilk92piO47bMch1/vg5skTT07F2BttPdx0kfkyHok+D9jxLAv/kIB qhLV5NaGCk35Un9R16yu/huoV39ChkK1pWHh0i8QBatsvJa6rAfOPCTUph4VUv/g2l6e XPTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858518; x=1786463318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=C5MjzH6tWZC1vulhg4mfpL7kW1xzkWEA9okhBx32l/4=; b=HwwiqPx+x53H+p9DfMSDj32dUZ3ws/RUQ12d8tIoxRbvn2XL79Gdz7PKPih28nnmZq uHfA4EFvn+j8la6no5ByajWzQ5WAGA8R0M25yPJuQ/bFRFKJ0R4Pr32e6N3P0xKbuwHS NBJooGSE/AvoLz4xCUmHeZNVqopPQ1hJVXkFv23K1XmdH03te1el0ojFompJsyBIGYcC f054z4eWekL/2Dqax4FoSSEIQjHTEtJZMMeASpR5KFI+R7gI7wbgQAIirna8ODr+vOSm 6mDmlS7bz4Gukn6nZu12H1Co3G3MB7lODWNDXIYVWP8ccpnLdsHbJfZ9WJI2cWq3Y0+G pWWQ== X-Gm-Message-State: AOJu0YzsMnX+dVxDxV8Uk0+RaWj3i3FUzUbOMnC/29kPT425iPnX6x0A iC3bAXVFkrF8fOCBLErFe8dHnkM1HmZ4LTnqricVSHoupqMCuPzBUDZXmeS10g== X-Gm-Gg: AR+sD13F6tuWyjWPuRUWLft3eV6A10hivuEwc+niIlQYm+kfiNBMc2sLG5tr/9wJ8hH 6NaQqtUFy3OZbTSdJQ/H8KhGzegq5bQErlYpo+1coEWuZIjzLZv40d6JrqcNtly1tfYR/uvUI7c CoPeLGotAj05wszCQmvtsIRXsq0C4F1/XgNRlfrt0Hj8awiLExi11TMx5A3KuKmb93tkNNczpBA F7+NkwdssCdhZmarneHxaI5DPZ0CPCcmybEbUQ8j4DFV2mBF4HXVxTGwa+A0iUfP2xU667ipPdn pDoNo8+Nd0OhZePCdfuCforJYGQ8ARngZr4cAFj588YMNU/XCXAHdiQimUEtbNwz9jbJKboahsY o1YOp07vBEsH623eOjzGftuFacblM8HrHKecjd7Q/6LWELj9OMH4SpfUzs4+CV7RX3fsVjdsScG MBLwr0mXhERLyHCEasmX5mn72ejHQy4/sLncUMG+w797S4DxDiaM2IAXGVsSJcuvM8go07yF7cx J0fTPFjKEEf8PDzg0eVlbjvVhvlEU6VfBbZL0npYlTp X-Received: by 2002:a05:600c:840f:b0:496:c379:b2a1 with SMTP id 5b1f17b1804b1-4980c66d7bbmr299616715e9.2.1785858517394; Tue, 04 Aug 2026 08:48:37 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , "Daniel P. Smith" Subject: [PATCH v7 16/20] xen/riscv: implement IRQ routing for device passthrough Date: Tue, 4 Aug 2026 17:48:06 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1785858518-508CDCFC-81DEB2F6/10/73395122804 X-purgate-type: spam X-purgate-size: 25224 dom0less device passthrough requires granting guest domains access to device interrupts. Introduce map_device_irqs_to_domain() to enumerate a DT node's interrupt properties, skipping those not owned by the primary interrupt controller (as at the moment I haven't seen usages of it), and map_irq_to_domain() to grant domain access and configure Xen's interrupt descriptor accordingly. Sharing IRQ between domains is rejected. Both map_irq_to_domain() and map_device_irqs_to_domain() are marked __overlay_init, mirroring Arm: without CONFIG_OVERLAY_DTB this expands to __init, so the functions are init-only and need no XSM check; with CONFIG_OVERLAY_DTB they become runtime-callable, but the only runtime entry point is dt_overlay_domctl(), which performs the XSM checks at the domctl layer. RISC-V does not wire up DT overlay yet, so today these are strictly __init; if/when overlay support is added, the domctl-level XSM gating must be added together with it, as on Arm. route_irq_to_guest() and release_irq() manage irq_desc ownership for guest-assigned interrupts. Each assignment carries a small irq_guest structure as irqaction::dev_id, recording the owning domain and virtual IRQ number which is 1:1 mapped to physical IRQ number. A per-domain vIRQ allocation bitmap (used_irqs in struct vintc), managed by vintc_reserve_virq(), prevents the same vIRQ being claimed twice. Host and guest interrupts may differ in some operations (EOI timing in particular, possibly others): a host IRQ is completed once Xen's handler runs, whereas a passthrough IRQ must defer the physical completion until the guest issues its own EOI, otherwise a still-asserted level line would immediately retrigger and storm. This affects only the .end callback; the rest of hw_interrupt_type is shared, hence the separate host and guest hw_interrupt_type instances. With APLIC+IMSIC, guest interrupts are delivered directly by hardware through the IMSIC, bypassing do_IRQ(). The _IRQ_GUEST branch in do_IRQ() is therefore left as BUG() until a platform without direct IMSIC delivery is encountered. Signed-off-by: Oleksii Kurochko --- Changes in v7: - Build device.c as device.init.o: everything it provides is __overlay_init, which is plain __init as long as CONFIG_OVERLAY_DTB stays Arm-only. Unlike Arm, which picks device.o/device.init.o based on that config, RISC-V cannot enable it, so the choice is unconditional for now. - Don't have release_irq() free the guest IRQ info anymore: set free_on_release = false and free 'info' explicitly in release_guest_irq(), i.e. reinstate the xvfree() dropped in v5. The action stays embedded in struct irq_guest, so a single allocation still covers both, but it no longer has to be the structure's first member: the offsetof() BUILD_BUG_ON and the xvfree() of a pointer that merely happened to coincide with the allocation base are gone. The ->dev_id concern from v5 doesn't apply: release_irq() clears desc->action under desc->lock and waits for in-flight handling before returning, so nothing can observe ->dev_id once 'info' is freed. - Move 'action' to the end of struct irq_guest and reword its comment accordingly. - Use xvzalloc() instead of xvmalloc() for struct irq_guest, so that the embedded action is fully initialized (action.handler was left uninitialized before). - route_irq_to_guest(): free 'info' via the common free_info label when intc_route_irq_to_guest() fails, now that release_irq() no longer frees it. - Drop a stray blank line ahead of release_irq(). --- Changes in v6: - size nr_virqs as guest_aplic_num_sources + 1 to reserve APLIC's 1-indexed source 0, so the highest source/irq could be reserved. --- Changes in v5: - add early -EINVAL return in route_irq_to_guest() if domain is dying - use __clear_bit() instead of clear_bit() in release_guest_irq() since desc->lock is already held - remove irq_get_domain() wrapper; inline irq_get_guest_info(desc)->d at its single call site - reword IRQ_GUEST comment in do_IRQ() for clarity - move XVFREE(used_irqs) before the switch so it is freed prior to variant-specific vintc teardown - fix missing space in dt_dprintk() format string split across lines - Drop 'inline' for irq_get_guest_info() and leave it only static. - Drop xfree(info) from release_guest_irq() to avoid a potential dangling-pointer issue with the ->dev_id field. Now that 'struct irqaction action;' is embedded into 'struct irq_guest', 'info' will be freed as part of release_irq() at the end. --- Changes in v4: - Update the commit message. - Mark map_irq_to_domain() and map_device_irqs_to_domain() as __overlay_init (mirroring Arm) and include . - Fix grammar in the controller-skip comment ("IRQ" -> "IRQs"). - Drop the redundant 'base' local in guest_imsic_make_reg_property(); use GUEST_IMSIC_S_BASE directly. - Rename vintc::irq_nums -> nr_virqs and update all users. - Guard domain_vintc_deinit() against a NULL d->arch.vintc. - Use smp_rmb() instead of smp_mb() in release_irq()'s wait loop and document how it pairs with the spin_unlock() in do_IRQ(). - In release_guest_irq(), reject live unrouting from a non-dying domain (-EBUSY) and clear _IRQ_GUEST under desc->lock so a concurrent release for the same IRQ bails out instead of double-freeing 'info'. - Tidy spurious whitespace in release_irq()'s spin_lock/unlock calls. --- Changes in v3: - Drop extraneous "to" from "Unable to permit to %pd" message. - Move res/irq/rirq to loop scope; use nirq as declaration initializer. - Hoist irq_ranges check before the loop (it is loop-invariant). - Remove spurious forward declarations (struct dt_device_node, struct rangeset) from intc.h; remove all three from setup.h. - Use __set_bit() instead of set_bit() in intc_route_irq_to_guest() since desc->lock is always held on every write path for desc->status. - Use XVFREE() instead of xvfree() in domain_vintc_deinit(). - Rename allocated_irqs -> used_irqs in struct vintc. - Fix dangling desc->action in release_irq()'s !IRQ_HAS_MULTIPLE_ACTION path by nulling *action_ptr after saving the action pointer. - Use true (not 1) for free_on_release in route_irq_to_guest(). - Use %pd for domain printing in route_irq_to_guest() error paths. - Introduce release_guest_irq() to pair with route_irq_to_guest() and plug the irq_guest info leak; call it from domain_vintc_deinit() for each vIRQ recorded in used_irqs. --- Changes in v2: - Rework IRQ mapping in more common (similar approach to Arm). --- Updates Signed-off-by: Oleksii Kurochko Changes in v7: - Build device.c as device.init.o: everything it provides is __overlay_init, which is plain __init as long as CONFIG_OVERLAY_DTB stays Arm-only. Unlike Arm, which picks device.o/device.init.o based on that config, RISC-V cannot enable it, so the choice is unconditional for now. - Don't have release_irq() free the guest IRQ info anymore: set free_on_release = false and free 'info' explicitly in release_guest_irq(), i.e. reinstate the xvfree() dropped in v5. The action stays embedded in struct irq_guest, so a single allocation still covers both, but it no longer has to be the structure's first member: the offsetof() BUILD_BUG_ON and the xvfree() of a pointer that merely happened to coincide with the allocation base are gone. The ->dev_id concern from v5 doesn't apply: release_irq() clears desc->action under desc->lock and waits for in-flight handling before returning, so nothing can observe ->dev_id once 'info' is freed. - Move 'action' to the end of struct irq_guest and reword its comment accordingly. - Use xvzalloc() instead of xvmalloc() for struct irq_guest, so that the embedded action is fully initialized (action.handler was left uninitialized before). - route_irq_to_guest(): free 'info' via the common free_info label when intc_route_irq_to_guest() fails, now that release_irq() no longer frees it. - Drop a stray blank line ahead of release_irq(). --- --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/aplic.c | 4 + xen/arch/riscv/device.c | 94 +++++++++++++ xen/arch/riscv/include/asm/intc.h | 9 ++ xen/arch/riscv/include/asm/irq.h | 5 + xen/arch/riscv/intc.c | 45 ++++++ xen/arch/riscv/irq.c | 226 ++++++++++++++++++++++++++++++ xen/arch/riscv/vaplic.c | 9 ++ 8 files changed, 393 insertions(+) create mode 100644 xen/arch/riscv/device.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index fcd73c7a2dd5..3b948c11dd61 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,6 +1,7 @@ obj-y += aia.o obj-y += aplic.o obj-y += cpufeature.o +obj-y += device.init.o obj-y += domain.o obj-y += domain-build.init.o obj-$(CONFIG_DOM0LESS_BOOT) += dom0less-build.init.o diff --git a/xen/arch/riscv/aplic.c b/xen/arch/riscv/aplic.c index c2d7183e1852..3681f0669efb 100644 --- a/xen/arch/riscv/aplic.c +++ b/xen/arch/riscv/aplic.c @@ -325,9 +325,13 @@ static const hw_irq_controller aplic_xen_irq_type = { .set_affinity = aplic_set_irq_affinity, }; +/* At the moment there is no difference between guest and Xen ops */ +#define aplic_guest_irq_type aplic_xen_irq_type + static const struct intc_hw_operations aplic_ops = { .info = &aplic_info, .host_irq_type = &aplic_xen_irq_type, + .guest_irq_type = &aplic_guest_irq_type, .handle_interrupt = aplic_handle_interrupt, .set_irq_type = aplic_set_irq_type, }; diff --git a/xen/arch/riscv/device.c b/xen/arch/riscv/device.c new file mode 100644 index 000000000000..f54d0fdaa7ab --- /dev/null +++ b/xen/arch/riscv/device.c @@ -0,0 +1,94 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include +#include +#include +#include +#include + +#include + +int __overlay_init map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname) +{ + int res; + + res = irq_permit_access(d, irq); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit %pd access to IRQ %u\n", d, irq); + return res; + } + + if ( need_mapping ) + { + /* + * Checking the return of vintc_reserve_virq is not + * necessary. It should not fail except when we try to map + * the IRQ twice. This can legitimately happen if the IRQ is shared. + */ + vintc_reserve_virq(d, irq); + + res = route_irq_to_guest(d, irq, irq, devname); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to map IRQ%u to %pd\n", irq, d); + return res; + } + } + + dt_dprintk(" - IRQ: %u\n", irq); + + return 0; +} + +int __overlay_init map_device_irqs_to_domain(struct domain *d, + struct dt_device_node *dev, + bool need_mapping, + struct rangeset *irq_ranges) +{ + unsigned int i, nirq = dt_number_of_irq(dev); + + if ( irq_ranges ) + return -EOPNOTSUPP; + + /* Give permission and map IRQs */ + for ( i = 0; i < nirq; i++ ) + { + int res, irq; + struct dt_raw_irq rirq; + + res = dt_device_get_raw_irq(dev, i, &rirq); + if ( res ) + { + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + /* + * Don't map IRQs that have no physical meaning + * ie: IRQs whose controller is not APLIC/IMSIC/PLIC. + */ + if ( rirq.controller != dt_interrupt_controller ) + { + dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", + i, dt_node_full_name(rirq.controller)); + continue; + } + + irq = platform_get_irq(dev, i); + if ( irq < 0 ) + { + printk("Unable to get irq %u for %s\n", i, dt_node_full_name(dev)); + return irq; + } + + res = map_irq_to_domain(d, irq, need_mapping, dt_node_name(dev)); + if ( res ) + return res; + } + + return 0; +} diff --git a/xen/arch/riscv/include/asm/intc.h b/xen/arch/riscv/include/asm/intc.h index 6fc0e620e937..a9bf909a436e 100644 --- a/xen/arch/riscv/include/asm/intc.h +++ b/xen/arch/riscv/include/asm/intc.h @@ -15,6 +15,7 @@ enum intc_variant { }; struct cpu_user_regs; +struct domain; struct irq_desc; struct kernel_info; struct vcpu; @@ -34,6 +35,9 @@ struct intc_hw_operations { /* hw_irq_controller to enable/disable/eoi host irq */ const struct hw_interrupt_type *host_irq_type; + /* hw_irq_controller to enable/disable/eoi guest irq */ + const struct hw_interrupt_type *guest_irq_type; + /* Set IRQ type */ void (*set_irq_type)(struct irq_desc *desc, unsigned int type); /* Set IRQ priority */ @@ -63,6 +67,8 @@ struct vintc_ops { }; struct vintc { + unsigned int nr_virqs; + unsigned long *used_irqs; /* Callbacks invoked during domain construction only. */ const struct vintc_init_ops *init_ops; /* Runtime callbacks used for the lifetime of the guest. */ @@ -76,10 +82,13 @@ void register_intc_ops(const struct intc_hw_init_ops *init_ops); void intc_init(void); void intc_route_irq_to_xen(struct irq_desc *desc, unsigned int priority); +int intc_route_irq_to_guest(struct irq_desc *desc, unsigned int priority); void intc_handle_external_irqs(struct cpu_user_regs *regs); int domain_vintc_init(struct domain *d); void domain_vintc_deinit(struct domain *d); +bool vintc_reserve_virq(const struct domain *d, unsigned int virq); + #endif /* ASM__RISCV__INTERRUPT_CONTOLLER_H */ diff --git a/xen/arch/riscv/include/asm/irq.h b/xen/arch/riscv/include/asm/irq.h index 62648bdc4252..66067747dc0f 100644 --- a/xen/arch/riscv/include/asm/irq.h +++ b/xen/arch/riscv/include/asm/irq.h @@ -52,6 +52,11 @@ void init_IRQ(void); void do_IRQ(struct cpu_user_regs *regs, unsigned int irq); +int route_irq_to_guest(struct domain *d, unsigned int virq, + unsigned int irq, const char *devname); + +int release_guest_irq(struct domain *d, unsigned int virq); + #endif /* ASM__RISCV__IRQ_H */ /* diff --git a/xen/arch/riscv/intc.c b/xen/arch/riscv/intc.c index f5c8af6ddea4..372c8d3a20f9 100644 --- a/xen/arch/riscv/intc.c +++ b/xen/arch/riscv/intc.c @@ -7,7 +7,9 @@ #include #include #include +#include #include +#include #include #include @@ -78,6 +80,22 @@ void intc_route_irq_to_xen(struct irq_desc *desc, unsigned int priority) intc_set_irq_priority(desc, priority); } +int intc_route_irq_to_guest(struct irq_desc *desc, + unsigned int priority) +{ + ASSERT(spin_is_locked(&desc->lock)); + + ASSERT(intc_hw_ops->guest_irq_type); + + desc->handler = intc_hw_ops->guest_irq_type; + __set_bit(_IRQ_GUEST, &desc->status); + + intc_set_irq_type(desc, desc->arch.type); + intc_set_irq_priority(desc, priority); + + return 0; +} + int __init make_intc_domU_node(struct kernel_info *kinfo) { const struct vintc *vintc = kinfo->bd.d->arch.vintc; @@ -101,12 +119,31 @@ int domain_vintc_init(struct domain *d) break; } + if ( !ret ) + { + d->arch.vintc->used_irqs = + xvzalloc_array(unsigned long, + BITS_TO_LONGS(d->arch.vintc->nr_virqs)); + if ( !d->arch.vintc->used_irqs ) + ret = -ENOMEM; + } + return ret; } void domain_vintc_deinit(struct domain *d) { const enum intc_variant variant = intc_hw_ops->info->hw_variant; + unsigned int virq; + + if ( !d->arch.vintc ) + return; + + for ( virq = 0; virq < d->arch.vintc->nr_virqs; virq++ ) + if ( test_bit(virq, d->arch.vintc->used_irqs) ) + release_guest_irq(d, virq); + + XVFREE(d->arch.vintc->used_irqs); switch ( variant ) { @@ -118,3 +155,11 @@ void domain_vintc_deinit(struct domain *d) break; } } + +bool vintc_reserve_virq(const struct domain *d, unsigned int virq) +{ + if ( virq >= d->arch.vintc->nr_virqs ) + return false; + + return !test_and_set_bit(virq, d->arch.vintc->used_irqs); +} diff --git a/xen/arch/riscv/irq.c b/xen/arch/riscv/irq.c index b5066fc3e981..9a8cd013e857 100644 --- a/xen/arch/riscv/irq.c +++ b/xen/arch/riscv/irq.c @@ -12,11 +12,26 @@ #include #include #include +#include #include +#include #include #include +/* Describe an IRQ assigned to a guest */ +struct irq_guest +{ + struct domain *d; + unsigned int virq; + /* + * The action of a guest IRQ has the same lifetime as this structure, so + * embed it here to have both covered by a single allocation. Consequently + * it must not be freed by release_irq() (see free_on_release below). + */ + struct irqaction action; +}; + static irq_desc_t irq_desc[NR_IRQS]; struct irq_desc *irq_to_desc(unsigned int irq) @@ -198,6 +213,14 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq) if ( desc->handler->ack ) desc->handler->ack(desc); + if ( desc->status & IRQ_GUEST ) + /* + * With APLIC + IMSIC, guest interrupts bypass Xen and are delivered + * directly to the guest. Without IMSIC, interrupts would be trapped + * by Xen and would need injecting into the guest here. + */ + panic("unimplemented"); + if ( desc->status & IRQ_DISABLED ) goto out; @@ -227,3 +250,206 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq) spin_unlock(&desc->lock); irq_exit(); } + +static struct irq_guest *irq_get_guest_info(struct irq_desc *desc) +{ + ASSERT(spin_is_locked(&desc->lock)); + ASSERT(test_bit(_IRQ_GUEST, &desc->status)); + ASSERT(desc->action != NULL); + + return desc->action->dev_id; +} + +void release_irq(unsigned int irq, const void *dev_id) +{ + struct irq_desc *desc; + unsigned long flags; + struct irqaction *action, **action_ptr; + + desc = irq_to_desc(irq); + + spin_lock_irqsave(&desc->lock, flags); + + action_ptr = &desc->action; +#ifdef CONFIG_IRQ_HAS_MULTIPLE_ACTION + for ( ;; ) + { + action = *action_ptr; + if ( !action ) + { + printk(XENLOG_WARNING "Trying to free already-free IRQ %u\n", irq); + spin_unlock_irqrestore(&desc->lock, flags); + return; + } + + if ( action->dev_id == dev_id ) + break; + + action_ptr = &action->next; + } + + /* Found it - remove it from the action list */ + *action_ptr = action->next; +#else + action = *action_ptr; + *action_ptr = NULL; +#endif + + /* If this was the last action, shut down the IRQ */ + if ( !desc->action ) + { + desc->handler->shutdown(desc); + __clear_bit(_IRQ_GUEST, &desc->status); + } + + spin_unlock_irqrestore(&desc->lock, flags); + + /* + * Wait to make sure it's not being used on another CPU. + * + * The read barrier pairs with the spin_unlock() in do_IRQ(): once we + * observe _IRQ_INPROGRESS cleared, we are guaranteed to also see the + * writes do_IRQ() made to desc (e.g. desc->action) before releasing the + * lock, so it is safe to free the action below. + */ + do { smp_rmb(); } while ( test_bit(_IRQ_INPROGRESS, &desc->status) ); + + if ( action->free_on_release ) + xvfree(action); +} + +int release_guest_irq(struct domain *d, unsigned int virq) +{ + struct irq_desc *desc = irq_to_desc(virq); + struct irq_guest *info; + unsigned long flags; + int ret = -EINVAL; + + spin_lock_irqsave(&desc->lock, flags); + + if ( !test_bit(_IRQ_GUEST, &desc->status) ) + goto unlock_err; + + info = irq_get_guest_info(desc); + if ( d != info->d ) + goto unlock_err; + + /* + * Live IRQ unrouting from a running domain is not supported: the tear-down + * drops desc->lock across release_irq()/xvfree() and relies on no + * concurrent route_irq_to_guest() being issued for this domain. Only permit + * it for a dying domain, where assignment is frozen and no new routes can + * appear. + */ + if ( !d->is_dying ) + { + ret = -EBUSY; + goto unlock_err; + } + + /* + * Clear _IRQ_GUEST while still holding the lock so that a concurrent + * release_guest_irq() for the same IRQ observes it and bails out, rather + * than capturing the same 'info' and double-freeing it below. + */ + __clear_bit(_IRQ_GUEST, &desc->status); + + spin_unlock_irqrestore(&desc->lock, flags); + + release_irq(desc->irq, info); + xvfree(info); + + return 0; + + unlock_err: + spin_unlock_irqrestore(&desc->lock, flags); + return ret; +} + +/* Route an IRQ to a specific guest */ +int route_irq_to_guest(struct domain *d, unsigned int virq, + unsigned int irq, const char *devname) +{ + struct irq_guest *info; + struct irq_desc *desc; + unsigned long flags; + int retval = 0; + + if ( d->is_dying ) + return -EINVAL; + + desc = irq_to_desc(irq); + + info = xvzalloc(struct irq_guest); + if ( !info ) + return -ENOMEM; + + info->d = d; + info->virq = virq; + + info->action.dev_id = info; + info->action.name = devname; + /* The action is part of 'info', thus it is freed together with it. */ + info->action.free_on_release = false; + + spin_lock_irqsave(&desc->lock, flags); + + /* + * If the IRQ is already used by someone + * - If it's the same domain -> Xen doesn't need to update the IRQ desc. + * For safety check if we are not trying to assign the IRQ to a + * different vIRQ. + * - Otherwise -> For now, don't allow the IRQ to be shared between + * Xen and domains. + */ + if ( desc->action != NULL ) + { + if ( test_bit(_IRQ_GUEST, &desc->status) ) + { + struct domain *ad = irq_get_guest_info(desc)->d; + + if ( d != ad ) + { + printk(XENLOG_G_ERR "IRQ %u is already used by %pd\n", + irq, ad); + retval = -EBUSY; + } + else if ( irq_get_guest_info(desc)->virq != virq ) + { + printk(XENLOG_G_ERR + "%pd: IRQ %u is already assigned to vIRQ %u\n", + d, irq, irq_get_guest_info(desc)->virq); + retval = -EBUSY; + } + } + else + { + printk(XENLOG_G_ERR "IRQ %u is already used by Xen\n", irq); + retval = -EBUSY; + } + goto out; + } + + retval = _setup_irq(desc, 0, &info->action); + if ( retval ) + goto out; + + retval = intc_route_irq_to_guest(desc, IRQ_NO_PRIORITY); + + spin_unlock_irqrestore(&desc->lock, flags); + + if ( retval ) + { + release_irq(desc->irq, info); + goto free_info; + } + + return 0; + + out: + spin_unlock_irqrestore(&desc->lock, flags); + free_info: + xvfree(info); + + return retval; +} diff --git a/xen/arch/riscv/vaplic.c b/xen/arch/riscv/vaplic.c index 72bb2c4dc3c5..8af748b1f1ed 100644 --- a/xen/arch/riscv/vaplic.c +++ b/xen/arch/riscv/vaplic.c @@ -123,6 +123,15 @@ int domain_vaplic_init(struct domain *d) vaplic->regs.domaincfg = APLIC_DOMAINCFG_RO; + /* + * APLIC source 0 is reserved; sources are numbered 1..guest_aplic_num_sources + * and used directly as indices into used_irqs. Size the bitmap to + * guest_aplic_num_sources + 1 so the highest source has a valid slot + * (index 0 stays unused). Without the +1, vintc_reserve_virq() can't record + * the top source, so domain_vintc_deinit() never releases it. + */ + d->arch.vintc->nr_virqs = guest_aplic_num_sources + 1; + return 0; } -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382284.1625744 (Exim 4.92) (envelope-from ) id 1wrHNk-0002Oo-Kn; Tue, 04 Aug 2026 15:48:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382284.1625744; Tue, 04 Aug 2026 15:48:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNj-0002KO-IX; Tue, 04 Aug 2026 15:48:43 +0000 Received: by outflank-mailman (input) for mailman id 1382284; Tue, 04 Aug 2026 15:48:40 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNf-0001mH-Lq for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNf-009GkK-0p for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:39 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209ce-e002-0a2a0a5209dd-0a2a45039d84-26 for ; Tue, 04 Aug 2026 17:48:39 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d6-fae8-0a2a45030019-d155802ead15-3 for ; Tue, 04 Aug 2026 17:48:38 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49558ce01afso26775235e9.1 for ; Tue, 04 Aug 2026 08:48:38 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858518; x=1786463318; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fJC5+YtFPL568P1Nwi/6zQXEX1Gc8Q+IUKJN5b49m2w=; b=sBzQ2F05A/eqIYdR9SxI/+qK+dW8EEqOZo0y/tYH37zqMKyijk8OoTC/gP4cuHigVs AGnVRuoDszt4mAtKovMyIJyCkM1XIyRusfdicgsyUjWUtdlsv1mnzWqvDbAKDeg6+b56 1a78yp0JkjC+jsavsnbhg4jDUMGBztPYmgCrHOIfZoU1F09CiCyjphO1ti0YqKOk3YRG rC6EOcCIsrPk9bvCLRkQV5xaU2yuerBM07oLE3xCUoHCSqY9fmSDLz6F3btw7fw9LIgf 4vgRvGg35QbbOIjie18hE2n4FTm5XYd03ZleacweTAmrO5a/6rCF6OSK2+Rf72Wb4vHs QBOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858518; x=1786463318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fJC5+YtFPL568P1Nwi/6zQXEX1Gc8Q+IUKJN5b49m2w=; b=FS+8oYyR740BMdHP0/OjR2G/Eo74ORp81tk7GXSy17t2Bpze6biN/C3ZtiHuYmayjm nuF+R7+8tGihju0vNo6fR9tnFfpR5LJxsPS5kjCFJmwLpaXyOlPOzRJxViBDGkq288JG mocWdJWo0EiBnM6+ktyzyCrwOCLQwMAuUa7nCnY2FKBx5wEhNF+NXP8rLHswl+QHwzjp W1uLvB+tYYVbrRHdxDVrIa0B3zmNNfdgz8r8u7moTZTsvd+/9exZvLCGbq+gW/7a5PVn HSeUPxe/OZ1AySlMmbIelCQgE2Jf1XBitYPOsNvW2LBfj9cQekXrUTi6GC9JbqiMq+9l ZBmA== X-Gm-Message-State: AOJu0YyzSiioIoaG5BD6t9obbgPGcI8xis9s47ebgjUgQYYEDlOJ8fuw 0rtubE+Zu5OSTz20ZCx/aVSwdM1/Z3ZhSyTlR4OGtNChjhxmPc40nEtevjpK+A== X-Gm-Gg: AR+sD10AcgyMz4Mgbn0ERB/cQmXyDETfG83fU07f2PXl4wUuuRPKZia4EGxp2mxTFDC j03D7gjixuwPiO66ew7B+gfPXZHdX2KJnOudun8XoBerjQZNmwkaGiyeaDMPsc3wyDwQgQ3QdLj 4Vhns6D8R8dvzVkKgerSiIfJHsxLSpRcJbEf1jRe522HCiwiT4uUo84GGPAYHyTzoFSt1B+MTid FPsx10271CLquPc0LLABPvLMeQ7QaKZUmPmbzPPf/M/aqHINYPaeQeazK8e2ZVSUenzNhsALMFs Uel1oazAQnJZb2WNQY2xZIMPhaXOSjQ1crTJrVsC+chNjUNehz876c2teUPguA/ZAeNNZMYe97l epERil6SXongVd8NnwH6Lo4W1/FJZcnwFzDneavyYfycKUiwhkgogoOGJwe8BVPPiT4zZSX9uzd CN5l9oTKbSnROrHtU7FRC/4IwPOs+cmhQFDiKkOYWJW2s42/W5Zw5oTbPAWlUTiFfjlvhLOSRAg PwSb3W0t5AHB8r5bri1BowhKiNrpWflFg== X-Received: by 2002:a05:600c:a45:b0:492:45a0:dcef with SMTP id 5b1f17b1804b1-4980c66d8a5mr305184025e9.5.1785858518366; Tue, 04 Aug 2026 08:48:38 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 17/20] xen/riscv: implement init_intc_phandle() Date: Tue, 4 Aug 2026 17:48:07 +0200 Message-ID: <2cfa77799f1605bbe4f7dc70662e356e52d4581e.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785858518-74A894E9-26B688DB/10/73395122804 X-purgate-type: spam X-purgate-size: 1378 Implement init_intc_phandle() to read phandle of interrupt controller node and save it in kernel->phandle_intc for the future usage during creation of guest interrupt controller node. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v4-7: - Nothing changed. Only rebase. --- --- xen/arch/riscv/dom0less-build.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/xen/arch/riscv/dom0less-build.c b/xen/arch/riscv/dom0less-build.c index 4cc00012aa8d..a1fa51b996a7 100644 --- a/xen/arch/riscv/dom0less-build.c +++ b/xen/arch/riscv/dom0less-build.c @@ -4,9 +4,26 @@ #include #include #include +#include #include +int __init init_intc_phandle(struct kernel_info *kinfo, const char *name, + const int node_next, const void *pfdt) +{ + if ( dt_node_cmp(name, "intc") == 0 ) + { + uint32_t phandle_intc = fdt_get_phandle(pfdt, node_next); + + if ( phandle_intc != 0 ) + kinfo->phandle_intc = phandle_intc; + + return 0; + } + + return 1; +} + int __init make_arch_nodes(struct kernel_info *kinfo) { /* No RISC-V specific nodes need to be made, at the moment. */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382288.1625749 (Exim 4.92) (envelope-from ) id 1wrHNn-0002wp-2j; Tue, 04 Aug 2026 15:48:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382288.1625749; Tue, 04 Aug 2026 15:48:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNl-0002qo-U1; Tue, 04 Aug 2026 15:48:45 +0000 Received: by outflank-mailman (input) for mailman id 1382288; Tue, 04 Aug 2026 15:48:41 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNg-0001vc-PV for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNg-009Gjx-4P for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:40 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209d3-bab6-0a2a0a5309dd-0a2a4505c19c-10 for ; Tue, 04 Aug 2026 17:48:40 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d7-4cb1-0a2a45050019-d1558034e023-3 for ; Tue, 04 Aug 2026 17:48:40 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4956242332dso28508505e9.2 for ; Tue, 04 Aug 2026 08:48:40 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858519; x=1786463319; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DmOaTFmnk9rQJklV5xKX1lfHsimIvxxfep8LTck6j7s=; b=Vcc0xrNL6uChNjtytBWRdaeF46dVLqNQD2/9aFisMeGX4xjugFGPUyRwSdjUw9MCfp OsmAwT/NoRQpr6mLrrC8ttiVc2VP+YfMt1ch5SQAidObAYJTnWAry8E60z4lezzNlDcf bX2iO3ym1gAaq4CfY2din4h0BYmpoiYqek8l6+ve+W42d4JPLDyMBbzQd89DW2It4Lj4 EMWogMkg+XYDuvzjo7GE6UPeIG0Lgw5UgwUENmYfwitPayjviULd/EoF+CVUDA8aHVFx XgUyozznGj3um45vf8V/sm6Tyt7R5KQYy/UXxlLEpkrcejIHYzAs++wuQFSEfPC5CXeA Gtfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858519; x=1786463319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DmOaTFmnk9rQJklV5xKX1lfHsimIvxxfep8LTck6j7s=; b=p7bBwazFwzO2N/gMz26ymT7LyC6kRzojuYXrb/eFKsH5ResTkoeMvu993QGwMRHx1V zSXvBilq9kZa8g7rmZ204Wk7ahIxgdbyhhyURD2d09sEIOpLo9RXas2rl0lNFDwkWe0B 4zUW+WGNpm3UWenvO6/u9gC3LECCSFiJRusJpyZHmyz8MGFBIN3qfbiw/c8I/Z38ABv3 brO2itWZbmT14gr5Ob1ZNr127DQnJOsQI0UFUIFBXYbSzbtQxw0kco9IwVz79eOEQRAo ueYhYlp0dZ6SyUP28j/g7+mvrY/wSjc386Xn1wVl97UenZ6eQ0V0sb/sIeGvG09cfHb4 1a4Q== X-Gm-Message-State: AOJu0YxNnU4Rdrao2bXen8vI6mFINvuzfwMrmRESUpb22Yqh11MpKsim JwAdn59z8gzdKkP68P9TT5qdv6sRsxG++L7mynU+34GB5p8rvvbAVKMh+6rU8A== X-Gm-Gg: AR+sD107eatE7hEq20e4N3z4ARq9ha12qSeQrnLRub51/G1/FnkIjX6OhqcPbIbRM2K cN6mUoQGjcownymnTvIHXFtqhvTvKTgqOdl6F668719V3wcFz/Jl113bnf4i3DZ3zFrFd6uY/7p 87stRIsgUX2g/rKa3lD+KR6bGm50u3kKHdZzDNFbiMStD+Irjt/2pUv7/Gcz4JHhvSxCICzN2bB Ron6SdytYdn0fcXxG0rJyv4gN7SCHC5jcVlRAzB5mHESkVCV3F0TFx5+RDJwRu78+F1Bjs/q5Sb fLV+FJDs5TCi3r47yz92EZcomLwDZzPnXPV6yWb7iYKtchcrbRmUmnKJZ8KAtxBcgiY8sJ08MnS 9cac9jXtrIQD3Ipu2zlO1nFvCu/pn+4HEGIV0qXvIAi+PLGVrzziTqFkUqBHeLw7aTVBuqne5ra zTb8w9b1CyuUYeXGuX+paFImAAYO5A/CkxJ/7AFDVwSdwcsgwlMJfQlDyovHJ4W5c9jBBxpaovr 0qpIzoHrTKI+uN5t2EheUQmK24fZ1AVyUGDWcVUiHPe X-Received: by 2002:a05:600c:3151:b0:496:c378:6420 with SMTP id 5b1f17b1804b1-4980c66c843mr278491605e9.8.1785858519419; Tue, 04 Aug 2026 08:48:39 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 18/20] xen/riscv: initialize RCU, scheduler, and system domains in start_xen() Date: Tue, 4 Aug 2026 17:48:08 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1785858520-732B32A1-8BF7E448/10/73395122804 X-purgate-type: spam X-purgate-size: 1560 Wire up the missing early-boot initialization steps in start_xen(). The scheduler must be initialized prior to do_initcalls() because cpupool_create_pool() is called during initcalls; without it, BUG_ON(IS_ERR(pool)) is triggered inside cpupool_create_pool(). Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v4-7: - Nothing changed. Only rebase. --- Changes in v3: - Add Acked-by: Jan Beulich . --- Changes in v2: - New patch. Several patches were folded into one. --- --- xen/arch/riscv/setup.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 56a0907a855f..c3e98733ebc3 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -6,9 +6,12 @@ #include #include #include +#include #include #include #include +#include +#include #include #include #include @@ -156,12 +159,21 @@ void __init noreturn start_xen(unsigned long bootcpu_id, timer_init(); + rcu_init(); + + setup_system_domains(); + local_irq_enable(); console_init_postirq(); guest_mm_init(); + scheduler_init(); + set_current(idle_vcpu[0]); + + do_initcalls(); + printk("All set up\n"); machine_halt(); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382290.1625757 (Exim 4.92) (envelope-from ) id 1wrHNo-0003FX-Py; Tue, 04 Aug 2026 15:48:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382290.1625757; Tue, 04 Aug 2026 15:48:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNn-0003BB-DT; Tue, 04 Aug 2026 15:48:47 +0000 Received: by outflank-mailman (input) for mailman id 1382290; Tue, 04 Aug 2026 15:48:42 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNh-00025v-UD for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNh-009QPZ-Ag for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:41 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209d6-2eae-0a2a0a5409dd-0a2a4504c160-8 for ; Tue, 04 Aug 2026 17:48:41 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209d9-b57f-0a2a45040019-d155dd2ce4e9-3 for ; Tue, 04 Aug 2026 17:48:41 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f703a9d05so2912747f8f.0 for ; Tue, 04 Aug 2026 08:48:41 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858521; x=1786463321; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GAWkDWNVTDEeajRUovPN0Ndt/ZkdBsFcfwqhXKheFEA=; b=BEMNLqjCMBlrrpVC5UiKeqk/4aIGkgCQb/6Xrt/fQ19RHuIQAiohM1nV06FouG1b3u t3f43xQPmyICYVF9B1MAfLngQYpKYyPhrqfWPVNOBWv+nrq9oITE0XVad1qMp169z9B1 eC62Nss6jT6AYgjwl8w96qsnb7P0t9KT2qr+jPmiUmWubexoFPQWe/yJxgfMErFoilGD G2Adz9jU30Kxsd7mV+Dbv6Vhome4ZdsU3XNtAkZGyDt/l7VCo7upCHknT6J1sfbSZvmL 8u650YLPq369RFm7BXCO42oLl6G3h+3MadgJVZvdP1Tj83xQ8/N/Kf4Rf8W+xdTixwWC G4HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858521; x=1786463321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GAWkDWNVTDEeajRUovPN0Ndt/ZkdBsFcfwqhXKheFEA=; b=QZ1WqELJczrgF6FpDa3S77hFvXnIfAxeADZ/WwcMPkAKtyMMKrBY6sEJDyvuzFAl4u MQUx7ai94/FLvHvmsc+QDtaRJpGIyW58VoH+4PilVDdcOUpW5bBCHjLB9nE9wIsaMGmQ DOmlyNfrkg/lLAq3tXZZLikUnaDZVFub391s7g6vDvTYoyBlkODyv7/aM/uduVJ+gywS yIqFIZGruXiUe5dEQUNncFJe5VLylNVeXemAjVIZXSoNAcbo5l8bbfaXvpz/HT8Aw/ul Ywfyl3kHFY6udHtWeRjFK7P4kIbNZQcTFFy62kRFHywvqZxocjxE5XodIZplwVQNTFRV 2CPA== X-Gm-Message-State: AOJu0YxluezbycgJKtFLoVTHwXwSzJuJ5i6kfdNZDD3fX3eG7bgxXDbu Dl3EaCPR2qK/R5x1uGIMkOzpOdbVP3Ckq1B5A2y/N0eGHtC7vgjUvi9z3EoZNQ== X-Gm-Gg: AR+sD111E5mS8nTTEZp0QJGzy8czL4GJs78+0TuUO3tA8HU4HoOcos0SmPJ0v9gJLwr x+HLdTP4v+4hmuQuQqZ4M6brb3dKrTPtcHbmI2LbGfCNDKrAHJ0/4EIVPeQud3hClcjD3tihuta AFBg202K62NKhRq1j94GYhQG5Qx5nVwN60nA5TXvX3qGmCCv+2vioMYxRdeahQ9Jm9Jj7GW7YIX eQ2XBaaLU1bMIx/X9xV0QGQSQ8+CfBuRGTiyTi+BByY9f4iWVLBhoQRQQlOwL3R5Vron6TanL4r sqK8yZxbJ5j+ED1pmVXgcJNluwcUzmVHl5eCehPJr37uhFS7ev31OdyGCUR8Q+D6MCCX6yPpEtN VPQAd695A3fwtH0v4CnfzLGhqvW5frES7XK2wzVicxdPm6ac3++T1bm6XGOuEUGIMu1OnKIN3NK 24KQGo1+BC3jbiyNixLGgE9kiH3IxnEMFM1HClJs2HSlmn0fZK7QO+GIX+BlcmESPLTz3W7O0wI Zq3jHUxJ51hLrRtruGVWkSRMxLIzZQc+A== X-Received: by 2002:a05:600c:c8c:b0:493:f318:3bc6 with SMTP id 5b1f17b1804b1-4980c6564d5mr316112725e9.13.1785858520601; Tue, 04 Aug 2026 08:48:40 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 19/20] xen/riscv: provide init_vuart() Date: Tue, 4 Aug 2026 17:48:09 +0200 Message-ID: <41598060f3f96d27da1c90299592bb908edd8910.1785836421.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1785858521-C0CDFB50-679FDBBD/10/73395122804 X-purgate-type: spam X-purgate-size: 1391 For debug purpose is enough to have only print messages from guest what is now implemented in vsbi_legacy_ecall_handler(). For full guesst console support it will better to have something similar to [1], thereby there is nothing specific should be done, at least, for now and init_vuart() is provided to make dom0less code buildable. [1] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2602041533440.3175371@ubuntu-linux-20-04-desktop/ Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v3-v7: - Nothing changed. Only rebase. --- Changes in v2: - Add Acked-by: Jan Beulich . --- --- xen/arch/riscv/dom0less-build.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/riscv/dom0less-build.c b/xen/arch/riscv/dom0less-build.c index a1fa51b996a7..d1a51b92936a 100644 --- a/xen/arch/riscv/dom0less-build.c +++ b/xen/arch/riscv/dom0less-build.c @@ -8,6 +8,14 @@ #include +int __init init_vuart(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + /* Nothing to do at the moment */ + + return 0; +} + int __init init_intc_phandle(struct kernel_info *kinfo, const char *name, const int node_next, const void *pfdt) { -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:48:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:48:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382294.1625766 (Exim 4.92) (envelope-from ) id 1wrHNq-0003gc-RC; Tue, 04 Aug 2026 15:48:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382294.1625766; Tue, 04 Aug 2026 15:48:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHNp-0003YL-AF; Tue, 04 Aug 2026 15:48:49 +0000 Received: by outflank-mailman (input) for mailman id 1382294; Tue, 04 Aug 2026 15:48:44 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrHNj-0002FV-1s for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:48:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHNi-00Fkwn-EG for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:48:42 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7209c2-5cb7-0a2a0a5109dd-0a2a4502e47a-46 for ; Tue, 04 Aug 2026 17:48:42 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7209da-6ca4-0a2a45020019-d1558029dc3a-3 for ; Tue, 04 Aug 2026 17:48:42 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4954afac04bso39788275e9.0 for ; Tue, 04 Aug 2026 08:48:42 -0700 (PDT) Received: from fedora (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm116430355e9.5.2026.08.04.08.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 08:48:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785858522; x=1786463322; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mU8gqNd7fh25EXrT+sx22hsxtXPyXu1gA9iMQ0AEA40=; b=U9uM+0BWUx54E3p3oARTBXFN52DxEUN/nQ3zIv9Qi/sGG4yu3YGGOjsn8ZnKLSBkHq 0VUtK3r+Bcdf907qUynx/eudQTHTciMwsw+WRiyRFGiZd5ZDY4M5finLD0A3XCIA6wpI Tb9kDZUNAgDS9tkYA+xYdUhVmhgflBf03gsfAlSyZnRfSndisXD2Z5f2s9/kiR2hD91V rylPyx4ygn6qBh4X9WMLpv7Tlb1o5o++rrxxqdgfgJ18YYgFYX54aeGl4vsTZNjt3KsL Q4IYpWLN2T29kSXlgb1eh3xgkB/pxGXolR6ZbfW6C+9ZyaVHsc5lttdCYoVl6ky2ZSyb zBMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785858522; x=1786463322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mU8gqNd7fh25EXrT+sx22hsxtXPyXu1gA9iMQ0AEA40=; b=d1zKLDxJ27a2ttg2RLNlZWUbFztuqfXXllnrcL8i8pahY0rX1e00sQIUTOq6H1lOwf Bh27/M7jcJOz231Cjve+2hX1GNeOMj5kg0QcTN/SrHRea/sSibYMgdofUzS+8Yf1vP/8 /l7oowdQ+aMSKSmnkjUaUZRxZlK/jKjkfwL1SbyBjI8B9ez5jLQEyV9SE/KbnF0gxQtP aW5qBRhPQ2O5qdrRkIl+UoXxKxE1GSVoT27QtmiQQx0b77my+tcyVbPjuX9bIoQMfS2f XQM0jlYnmT7FdhToRj9JqBMnliI6W0msxHjqcTEsdaVinaYoJPoNE2Zt7MhkuTJtAMtZ hwKg== X-Gm-Message-State: AOJu0YwnfU13j8gmnXRv5JQuoq1Cf5jQVZWeOy7M5FnrBfEog2PZ+8ow tzFVmVYUM7dt2wc5rFobXcfnTP2nfGJW243wgOQbyV3Lu/Sn7a+2lTW2Ue+3qw== X-Gm-Gg: AR+sD12JB0smAKeeqOTkDdWc3lSIKDHXoRiyH8Q96NM5B1ufarKfNnKD4GJBQt2fSN/ /4Dfvwmk/L9vyiC//z2kTKWoZQ7pydgu9DYeNa357MgCZksKaf8UCVb9dA+s031iXaydfuLMi21 cNmlleQLFuTI/rxkbJir+6aM8iJxlW3KaGRLlO0u0Ma9mIX6wuAGJ7VEYBNjcy9PZg9OzkSFXuu fjn1KZ0I+UXLkVTT54G4fOP/TqTrgc6fN+XpRPmZx8TwJc+WNeq8IazzQbrLEaF4HqBIBCj0C77 nEa+E1rv+66P4RlAvwI6TUMM/Je4cQM4287YGPavEJEyY6UYgt2Vv06Grk40iP7D3R8Tyn+sb83 iRF/9mWbvtud4k7QwN4/sjJweicZSL5y0kyO9NyrUYZIYeyLnlXmummovAuGOXsk9IcMudumEcV STDWajmmKrbO2DYzzJpyjI4XleeXNwtadqeMp0cQk0HuCpU22cX43yFpdz+wwHzA2dNqLPdpZ2M lCasJpZLihoBPj+Gurr+5Dtjs9H4IhpBuL8V/0c617x/RDxrfHhNdKd X-Received: by 2002:a05:600c:6990:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-4980c673907mr369152375e9.12.1785858521751; Tue, 04 Aug 2026 08:48:41 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Romain Caritey , Baptiste Le Duc , Oleksii Kurochko , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v7 20/20] xen/riscv: add initial dom0less infrastructure support Date: Tue, 4 Aug 2026 17:48:10 +0200 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1785858522-F28B42AC-6F1C9BE7/10/73395122804 X-purgate-type: spam X-purgate-size: 7342 Enable dom0less support for RISC-V by selecting HAS_DOM0LESS and providing the minimal architecture hooks required by the common dom0less infrastructure. Add stub implementations for architecture-specific helpers used when building domains from the device tree. These allow the generic dom0less code to build and let a basic DomU be constructed on RISC-V. construct_hwdom() and make_hypervisor_node() are still stubs returning an error: Dom0/hwdom construction isn't supported yet, and the hypervisor node generation (needed by domains with DOM0LESS_ENHANCED_NO_XS set) is not implemented. Both are marked with a TODO and are not reached by the currently supported configurations. Provide missing helpers and definitions required by the domain construction code, including domain bitness helpers and the p2m_set_allocation() prototype. Additionally define the guest magic memory region (GUEST_MAGIC_BASE / GUEST_MAGIC_SIZE) in asm/guest-layout.h. The base is arbitrary; the only constraint is that the region must not overlap guest RAM or the emulated device regions. It is placed in the unused gap below GUEST_RAM0_BASE (0x80000000); the constraints are documented next to the #define-s. A separate region for grant tables will be introduced at the same time as the introduction of the grant table for RISC-V. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in v6-7: - Acked-by: Jan Beulich . --- Changes in v5: - Reword the comment above defintion of GUEST_MAGIC_BASE. - Shrunk the size of GUEST_MAGIC_SIZE to 2Mb as looking on the Arm only 4 pages are used and there is no technical reason to have 16Mb for that region. (Maybe in case of Arm it is connected that Arm has these definitions in public header so more space is reserved to not "break" public API in future) - Update the commit message with a remark about grant table region in guest-layout.h. --- Changes in v4: - Reword the description: the stubs do not let dom0less fully "run" since construct_hwdom() and make_hypervisor_node() return an error; spell out these limitations instead. - Add a TODO comment to construct_hwdom() explaining that Dom0/hwdom construction isn't supported yet. - Add a TODO comment to make_hypervisor_node() explaining that returning an error breaks building of domains with DOM0LESS_ENHANCED_NO_XS set, and why that is harmless for now. - Document the constraints on GUEST_MAGIC_BASE/GUEST_MAGIC_SIZE next to the #define-s and drop the QEMU-based justification (QEMU is not involved); the base is simply an arbitrary non-overlapping address. Changes in v3: - Add /* Nothing specific to do for now */ comment to arch_handle_passthrough_prop(). - Use _ULL() instead of xen_mk_ullong() for GUEST_MAGIC_BASE and GUEST_MAGIC_SIZE (xen_mk_ullong() is intended for public headers only). - Fix GUEST_MAGIC_BASE from 0x39000000 to 0x79000000 to avoid the QEMU RISC-V virt machine PCIE_ECAM range. - Drop CONFIG_STATIC_MEMORY=n from the CI randconfig; now redundant since STATIC_MEMORY depends on HAS_STATIC_MEMORY which RISC-V does not select. Changes in v2: - Move declaration of p2m_set_allocation() to p2m-common.h. - Add __initdata for max_init_domid and drop initalizer for it. - Add CONFIG_STATIC_MEMORY=n to CI's randconfig to avoid compilation error because of guest_physmap_add_pages() isn't provided. --- xen/arch/riscv/Kconfig | 2 ++ xen/arch/riscv/dom0less-build.c | 7 ++++++ xen/arch/riscv/domain-build.c | 28 +++++++++++++++++++++++ xen/arch/riscv/include/asm/guest-layout.h | 12 ++++++++++ 4 files changed, 49 insertions(+) diff --git a/xen/arch/riscv/Kconfig b/xen/arch/riscv/Kconfig index 48520588fe40..d8a348c0cf07 100644 --- a/xen/arch/riscv/Kconfig +++ b/xen/arch/riscv/Kconfig @@ -6,6 +6,8 @@ config RISCV select GENERIC_BUG_FRAME select GENERIC_UART_INIT select HAS_DEVICE_TREE_DISCOVERY + select HAS_DOM0LESS + select HAS_DOMAIN_TYPE select HAS_EX_TABLE select HAS_PMAP select HAS_UBSAN diff --git a/xen/arch/riscv/dom0less-build.c b/xen/arch/riscv/dom0less-build.c index d1a51b92936a..0801d7e25059 100644 --- a/xen/arch/riscv/dom0less-build.c +++ b/xen/arch/riscv/dom0less-build.c @@ -102,3 +102,10 @@ int __init arch_parse_dom0less_node(struct dt_device_node *node, return 0; } + +int __init arch_handle_passthrough_prop(struct kernel_info *kinfo, + struct dt_device_node *node) +{ + /* Nothing specific to do for now */ + return 0; +} diff --git a/xen/arch/riscv/domain-build.c b/xen/arch/riscv/domain-build.c index d7613721db95..1e3abe259ccd 100644 --- a/xen/arch/riscv/domain-build.c +++ b/xen/arch/riscv/domain-build.c @@ -156,9 +156,37 @@ int __init make_cpus_node(const struct domain *d, struct kernel_info *kinfo) return fdt_end_node(fdt); } +int __init construct_hwdom(struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + /* + * TODO: Dom0/hwdom construction isn't supported on RISC-V yet, so this + * is a stub returning an error. It must be implemented before a hardware + * domain can be built from the device tree. + */ + + return -EOPNOTSUPP; +} + int __init make_timer_node(const struct kernel_info *kinfo) { /* There is no need for timer node for RISC-V. */ return 0; } + +int __init make_hypervisor_node(struct domain *d, + const struct kernel_info *kinfo, + int addrcells, int sizecells) +{ + /* + * TODO: Generating the hypervisor node isn't implemented yet. Returning + * an error here breaks building of any domain (DomU included) whose + * dom0less_feature has DOM0LESS_ENHANCED_NO_XS set. This is harmless for + * now because Dom0/hwdom construction isn't supported on RISC-V yet + * either, and no RISC-V DomU sets that flag, so this path is never taken. + * It must be implemented before DOM0LESS_ENHANCED_NO_XS is used. + */ + + return -EOPNOTSUPP; +} diff --git a/xen/arch/riscv/include/asm/guest-layout.h b/xen/arch/riscv/include/asm/guest-layout.h index 90603f06bb91..ceed9125e7e2 100644 --- a/xen/arch/riscv/include/asm/guest-layout.h +++ b/xen/arch/riscv/include/asm/guest-layout.h @@ -32,4 +32,16 @@ #define GUEST_RAM_BANK_BASES { GUEST_RAM0_BASE, GUEST_RAM1_BASE } #define GUEST_RAM_BANK_SIZES { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE } +/* + * The guest magic region holds the Xen-reserved pages mapped into the + * guest's physical address space. The only real constraint on + * GUEST_MAGIC_BASE/SIZE is that the region must not overlap guest RAM + * (the GUEST_RAMx banks) or the emulated device regions defined above; + * the exact base is otherwise arbitrary. Here it is placed in the unused gap + * below GUEST_RAM0_BASE (0x80000000), but a hole after a RAM bank would work + * equally well. + */ +#define GUEST_MAGIC_BASE _UL(0x79000000) +#define GUEST_MAGIC_SIZE _UL(0x00200000) + #endif /* ASM_RISCV_GUEST_LAYOUT_H */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 15:58:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 15:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382427.1625796 (Exim 4.92) (envelope-from ) id 1wrHXM-0001of-GP; Tue, 04 Aug 2026 15:58:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382427.1625796; Tue, 04 Aug 2026 15:58:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHXM-0001oY-Dg; Tue, 04 Aug 2026 15:58:40 +0000 Received: by outflank-mailman (input) for mailman id 1382427; Tue, 04 Aug 2026 15:58:39 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHXK-0001oQ-RJ for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 15:58:38 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHXK-00Fm1T-7v for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:58:38 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a720c02-5cb7-0a2a0a5109dd-0a2a4501dff6-46 for ; Tue, 04 Aug 2026 17:58:38 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a720c2d-5984-0a2a45010019-d155802bc07b-3 for ; Tue, 04 Aug 2026 17:58:38 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-49555a0e68bso17102085e9.2 for ; Tue, 04 Aug 2026 08:58:38 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b8d04fsm477454045e9.3.2026.08.04.08.58.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 08:58:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785859117; x=1786463917; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uTztnL3YIRuGnJqt6+Zduc6sY+i67CEbHhQ5R6Sx/LA=; b=HTtcWdIJyRO8GV8Zf6bncXTfFK6DNLPSkYE53keYPF/9c7tAwHYQkGAHTM9Iktts9s RjgRAzdP6+G41Re/nSMXudt81MX0lo+TI4hbifsofAouze6X011y0YzXImbUVqwYNS18 A1uSOz7yOy621A83nUwBFGmdbBsX0rMgNRmTLH50VTD5lGfaT9Q80ojC4UM4qXZad3Cg 1kn1hKKzbRGwe+wLXlVk/JUDyr7yk2kXzSVYz5KvA/cJ2Uj3wdskxK/LNoTBzvQ9sVjx TC0CSrZ4L8N5o1gabupPdKuL5Pa5fUgjpmurWL2XOePWx7cBGICPfAUT/v6FwqV/JZXX AVEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785859117; x=1786463917; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uTztnL3YIRuGnJqt6+Zduc6sY+i67CEbHhQ5R6Sx/LA=; b=MfH/x0NG3T9jkZtUL5VALG43S29Fkjg+XiGX/BrrnCsUdUzPN5Xd9UpjGENBxduSRq NmAhJNhPxpZUzdbqq8oxoY5rgsBYqwvU7kw9T/AsXbagJI7HFHRWupzw9n1hX07xbT8f jXgVC7mveAPkE4t+cgagsFWV6JIf5413TNvg4vUWEP8Bh2kQlbJ57GSboQ4X80R3+tyh IQgZLiVruFJZRJ5kAQcWJFVbSHCH4hD/Qwrvq7DvzBZJn+PC4F6wCjDHDxLPMFQSj2MG ljIIIy27X9o2RFWThhAU7LNur8gDfz/HhxipUZT2fO3LAQRcM6sIRqOlZL7jFsQ2jb32 DnBA== X-Forwarded-Encrypted: i=1; AHgh+RooVTFQO0UMBwDI6lgHfMWLnIn0u4pteBQbVNJQLFtoWd0wqgRffHUFNT1V0tlCwqQ1gg4OpXO9cAs=@lists.xenproject.org X-Gm-Message-State: AOJu0YztEd1b0P1YokoTUFPlQj6c22254h7MYGrZcFHwYK2p/6M4axkH fSZjqon0e0wJ6Zfmxa/keb8y+8dvH9ol2i4mvuJ2sWHT0OTzkIAItMieXHrFPojDdg== X-Gm-Gg: AR+sD12gqdlgwJMTUI4r+VLgIkYXmA7X7zDrF9/04ie2gtqCQjAMq2G1U8H2MnWFMRC jL9hU9nDDbL69Kmqt/538K83GE6sRWy4pRWSFheONm2L0QLeHYx79xmc3/w/MyEW4uEwRi0viOU ISju0tnxvzxL2VCf3FLmOYVOA1c1CsBIx0tf28Tuj9oAdEPQAn3zY+tdoYDeBeKjZoVBc7DtMN5 P9RQHq66pv5EvgaYUCfL/qiZTU+fVXX/bLjq8y4wfNoNJeqjV0xi02yM6byHRQaRHK0kJV4vE7L zu4plp+QpqRXLZut0E4g/5QTp8UbJYRNQCkqTNcaKFiDaGiPbYE+JcX67sMymtHfPvE43a2UPkW YMof2SGrIzXbu8k9tfFA4IBfI82Lr2fCBGyeF6KsytRB2/lRwnQmMVrdNM89MlPuSe3z6Z4KESE Op6NDjD/nPXAHroj/o6/7eOb48RJnlYtQLRsK0euGWFXTWt3gv4g7IJPQ8q7TZqNa+wFX1nSf8q Zg/AfJOxYz/hWNxw+ssn3bwqO0yFcUGY2QD/djdhYYA1rwJVVbm X-Received: by 2002:a05:600c:3b23:b0:493:cc25:9c0e with SMTP id 5b1f17b1804b1-4980c679e43mr371092945e9.14.1785859117612; Tue, 04 Aug 2026 08:58:37 -0700 (PDT) Message-ID: Date: Tue, 4 Aug 2026 17:58:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH 1/5] vtd: Ensure root entry is updated consistently To: Teddy Astie Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319678.8631fc262581453bbf619ec5b2062170.19fad586037000e099@vates.tech> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1785319678.8631fc262581453bbf619ec5b2062170.19fad586037000e099@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1785859118-1FA6E757-878CAEE4/0/0 X-purgate-type: clean X-purgate-size: 1791 On 29.07.2026 12:05, Teddy Astie wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -281,13 +281,13 @@ void free_pgtable_maddr(u64 maddr) > /* context entry handling */ > static u64 bus_to_context_maddr(struct vtd_iommu *iommu, u8 bus) > { > - struct root_entry *root, *root_entries; > + struct root_entry root, *root_entries; > u64 maddr; > > ASSERT(spin_is_locked(&iommu->lock)); > root_entries = (struct root_entry *)map_vtd_domain_page(iommu->root_maddr); > - root = &root_entries[bus]; > - if ( !root_present(*root) ) > + root.val = ACCESS_ONCE(root_entries[bus].val); I'm pretty concerned about this: You're reading only half of the entry here, and you're writing only half of it further down. The other half is reserved right now, but there's not even a comment being added to this effect. (Yet even with a comment, I'd still be concerned, just not as much.) > @@ -295,11 +295,12 @@ static u64 bus_to_context_maddr(struct vtd_iommu *iommu, u8 bus) > unmap_vtd_domain_page(root_entries); > return 0; > } > - set_root_value(*root, maddr); > - set_root_present(*root); > - iommu_sync_cache(root, sizeof(struct root_entry)); > + set_root_value(root, maddr); > + set_root_present(root); > + ACCESS_ONCE(root_entries[bus].val) = root.val; > + iommu_sync_cache(&root_entries[bus], sizeof(struct root_entry)); sizeof() please in favor of sizeof(), whenever possible. > } > - maddr = (u64) get_context_addr(*root); > + maddr = (u64) get_context_addr(root); While there, drop the pointless casts, thus getting rid of two style issues as well? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 16:04:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 16:04:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382436.1625806 (Exim 4.92) (envelope-from ) id 1wrHcx-0004kD-5w; Tue, 04 Aug 2026 16:04:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382436.1625806; Tue, 04 Aug 2026 16:04:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHcx-0004k5-0D; Tue, 04 Aug 2026 16:04:27 +0000 Received: by outflank-mailman (input) for mailman id 1382436; Tue, 04 Aug 2026 16:04:26 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHcv-0004jE-WC for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 16:04:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHcu-001mZB-MB for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 18:04:24 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a720d80-bab6-0a2a0a5309dd-0a2a450b8942-26 for ; Tue, 04 Aug 2026 18:04:24 +0200 Received: from [209.85.221.47] (helo=mail-wr1-f47.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a720d88-b7e8-0a2a450b0019-d155dd2fb82f-3 for ; Tue, 04 Aug 2026 18:04:24 +0200 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47362928f65so4540855f8f.2 for ; Tue, 04 Aug 2026 09:04:24 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec249a78sm642447f8f.34.2026.08.04.09.04.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 09:04:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785859464; x=1786464264; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=m5PEtzj8mtJe7pFOG8I3FsyiHy4JEbRtR3I88EiU7ZQ=; b=MX+irVqJ2dI01rJT/FniLmL2rBtcyz260T6tq4/5aZj2p1153/vecKPbA38XoTdJZ8 mFAk/ehQBz17WlK5Nl4H2ZTWEXR/JQWE6yJV8YdyTjq9m/7mihOOqLrseD+QFBy8T87M e0XYDMhdElNmf482tK4Q54fjx9XSFbT8tvZVd4bD33qiQBP3rtaT7bn9OEDgj8lgr3sI oeiTr+fBanIgBFZSUwlTYkhnZJztSC4WGU1myxAnNxRCOAbL6XP4UzabPsXYikGTqONZ EpTUWIACb6Hd5V+tYd1HEdz57CSQFXgnagbjyQVw/EeLFPm2cRQgbcRitLD0q5DMxVWt NMfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785859464; x=1786464264; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m5PEtzj8mtJe7pFOG8I3FsyiHy4JEbRtR3I88EiU7ZQ=; b=qoj6uvxt+/kdBUbtFyoD6Y2A547hO6XmodhFGHYHEx0LyeuuqKM9SSvIcKl8VY/q1m 0CoaGPsw7lIzUPuIzJBbNOGfpd/GRbNHS/f9oJwWoBdxmlN0J6mraBKMjXyfjGb6ce3r ZMEJp3DBMuyOnUpJ6ENgOtq3dDIZ6CRNjk7j4Ut2lNWtHGBxI87z/A+a7zy3ka5VoiU8 cx/W5+vNJ4AkFt1p6VQKt2wC+nxFHo484gV5mWPxCfL0CG8HMpTjGdR3Bd7pWey5SyPE 76D5DHUIfLjPmaIu+DYiuIghEZa6G+aLvT1fp9hGpmsk21veF9lFHfN3UJE7JXljQ3Ws ytxw== X-Forwarded-Encrypted: i=1; AHgh+RrMA5Dee2JgTbQlkFwoQFeFSXCAqzNRs+EsPYemrDLFG8+F612r0BWxTYV/WOxVBDm4GITDO+OWz10=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx29rJVF93B7jRFhha4EAHGsOmS1DLzK1saYs0+LzTQbeoh28zI Ogxtzd+nVENqNdMUltgE3bQysGew2XGmT+d+LmMELhOGuPYlNkcDxDccaoMQ004kdpcg/M1B7F0 2eeH8yQ== X-Gm-Gg: AR+sD10oo5siioo4NhlsdlYld2CPpMj4H3e2dYCygrE01HVRFC8OEjUg32KxFW8+teW lt2gbqHGJ8kl/9Qn/zqrDrOJo06u18BLYR43vjHOH2Wp2yINISHm+wsXONB16h4jR61Z5zZUzxb E/NtMJbEJbV9nYb9cN6SVD2Ff/10Rg5eoC2/ZdZ1NpMTCdbriX9FlnC5GlaLkJFF+yQymm6hu4I dSU5yW948Ep0YuQArOXPgCFeXfwZMGaq1kB8tA8jpr1fu23qSLNWIObC0C/gP4pISaPSTPf1AS9 diaKtsyMz1A2kkyP3CGquOA62JhIRRnrREhQCOt8kI3jURISoNOs3qG+R2Jo2ilJFi+fIVRdqwt 092he3ON0+B4FTZEIyazb4dWjOyYNU8oYN7OHMnS5kBe5ZCebmHENCtjYE4I7+Hbp2tWcsRbGIK 0KEgQbmmkCpo4hfDvf72NRtpvNaFW7uN6dYClOkLiHTTH2L+W2r+wx2h36eQHI9yEaHYvSETFtN EORn2YnGUhsO79Y/gz6D4BjRma14EwItNMfOO7x4Kycd3o7sXPy X-Received: by 2002:a5d:68c9:0:b0:474:18d9:8371 with SMTP id ffacd0b85a97d-47fec6359c1mr364268f8f.28.1785859464014; Tue, 04 Aug 2026 09:04:24 -0700 (PDT) Message-ID: <55d55c27-a482-4b59-a1f9-1412c91d7835@suse.com> Date: Tue, 4 Aug 2026 18:04:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] vtd: Ensure context entry is cleared properly To: Teddy Astie Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319341.8631fc262581453bbf619ec5b2062170.19fad533bfc000e099@vates.tech> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1785319341.8631fc262581453bbf619ec5b2062170.19fad533bfc000e099@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1785859464-A8AC89EA-A8DC0F50/0/0 X-purgate-type: clean X-purgate-size: 1931 On 29.07.2026 11:59, Teddy Astie wrote: > When removing a context entry for a device, the present bit needs to > be cleared first, then we can clear the rest of the field. In the current > logic, the compiler is allowed to perform optimizations in a way where high > is cleared before the present bit (which is in low part) is, leading to a > window where the context entry is invalid and would make the IOMMU fault > (as address width would be set to a reserved value). > > Fix the logic by ensuring we clear the low part first (which also clears > the present bit) then the high part afterward. > > Fixes: cada0c18f8d1 ("vtd: Move dom0 RMRR check to intel_iommu_remove_device()") > Reported-by: Teddy Astie > Signed-off-by: Andrew Cooper > Signed-off-by: Teddy Astie > --- > xen/drivers/passthrough/vtd/iommu.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c > index c314ce1db8..1005e200c1 100644 > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1889,8 +1889,14 @@ int domain_context_unmap_one( > > iommu_domid = context_domain_id(*context); > > - context_clear_present(*context); > - context_clear_entry(*context); > + /* > + * Clear the context entry. > + * > + * As this is performed with two stores, ensure lo (containing the present > + * bit) is cleared first. > + */ > + ACCESS_ONCE(context->lo) = 0; > + ACCESS_ONCE(context->hi) = 0; Implying the placement of the present bit is again something I'm a little uneasy with. With the uses of context_clear_{present,entry}() dropped, the macros are unused. I think they would better be dropped right away, to prevent misguided use elsewhere. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 04 16:24:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 16:24:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382449.1625814 (Exim 4.92) (envelope-from ) id 1wrHw6-0000LT-LN; Tue, 04 Aug 2026 16:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382449.1625814; Tue, 04 Aug 2026 16:24:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHw6-0000LL-Hs; Tue, 04 Aug 2026 16:24:14 +0000 Received: by outflank-mailman (input) for mailman id 1382449; Tue, 04 Aug 2026 16:24:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrHw5-0000LF-9z for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 16:24:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrHw4-004PPT-94 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 18:24:12 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a721222-bab6-0a2a0a5309dd-0a2a4507e9c4-14 for ; Tue, 04 Aug 2026 18:24:12 +0200 Received: from [52.101.56.9] (helo=BN1PR04CU002.outbound.protection.outlook.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72122a-b4ea-0a2a45070019-346538092921-3 for ; Tue, 04 Aug 2026 18:24:11 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by CY1PR03MB8122.namprd03.prod.outlook.com (2603:10b6:930:106::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 16:24:06 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Tue, 4 Aug 2026 16:24:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o5HjOoN19iTNgrpzWynhldcyWuud6gq1aKxxzdPOCPQmw/neYkIkwNWTNkQxEbHjbtcSLbvfCYGCfl1i3hkZkanDoLt1Ua95grraSkFtuoyHWPvE1ZdzvmUHhoFsoKLAr7mhatzQWVO4c6H5P9C+qx3eBoY9MDdiTBQXUcVKDEr5qPtEeRi1omcaizTDmaoyddaBLUuUL4HRrna/zHk9FJ5dFgB0tEJhLX2Wyyz9URQ1G/v+m2lKgjB7XkTwUX5MHs53jEhFXXLXJfEydYYCGpR07twuGi0hEiTHF5U7RiblP308D9bREqcdSQkxGfCocdJ1jfdNLTzEsk5jGWuizQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JvSlvUKUmqXgm62iNIgXSG22mwHOiYmM2XvdHRKiLC4=; b=xmkZGyiJ+ibdNfbC+CVQhcV6gvlaerMVS/MGGojJ30T1efgIZocG44uG6IWa2JWai+QuW6K6tnCTbNE5sLqgMgrPbYVoUhz721u5jrJWRr17/3TKg6GTsq1VVshxtQ4y9GiU8Q0d9U0XspNQAC7atZTCeXQHfXswKsiLzMSrGpHeNaoDh5VZufMo2RPv9oo95Y9DHAupEUccsCEl4HL5Sj5tvciHjqZFo8RoGZR4l99b53/DELbzhs+5lVBZmg2EDQuEEjqcErBGQaosPrXpT8K5KPjTBHCPPk3m2SdW74a2sMhh4s31/213jbbPxKAy1cX9z735JI7XOdXgzOJBIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JvSlvUKUmqXgm62iNIgXSG22mwHOiYmM2XvdHRKiLC4=; b=OaKiMiaay/c7vjseqfCRwwn6Kfnp/fUrAwHIzgwz7vuTRmO2iSNWKR/iSdY9eGBMXnjw7YDnF7kZQKvV6Dk3kvpDJK3epl2O61TuuJv89ER21aWGDbj9iNlstgRkgiKiYhLz0q0iWifv5MQuZdbPwOL6p5UX7nXs/m5Gx/34MBM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 4 Aug 2026 17:24:02 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Frediano Ziglio , Anthony PERARD , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v1 1/6] tools/migration: introduce PAGE_DATA_LZ4 stream record type To: Marcus Granado , xen-devel@lists.xenproject.org References: <20260720154832.1907401-1-marcus.granado@citrix.com> <20260720154832.1907401-2-marcus.granado@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260720154832.1907401-2-marcus.granado@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0055.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::12) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|CY1PR03MB8122:EE_ X-MS-Office365-Filtering-Correlation-Id: 623b78f5-6dad-426d-b514-08def244cdc7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|23010399003|366016|6133799003|11063799006|10067099003|4143699003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: DyZzO+oyIP5mfa8/V5cC3JKALHkhSo6pi7YozT8lVN7S3yokXgEXaHQxDucw+y8CpxxjqF+VG6jsdBur6Wb9POAn1c16jZUnjcstu5a+6OV8fg3lFWs2eSoqnleOFbcbklWT97jhuhMN9nS2bjZ12JEZiyEZfgjSi7xm/qfvhHg/gStVPZJw/4SmdhAcDtHZKSzLdxMRsi4Q1oPDUty9p7SV5/PipPT5d4tbbvhh7f80Ky4vzbkX2snZxIWjc6zsq6N9XicSPdN05NR69bUlPl9pG9J3RGssL4nxq2rSw2l2q5H5nLq3ckmHu7of3XCWYACSP5d/IHF1joRTJRdSEbTwCvTPWroqS08OFcRfxd6q+2GwmQYTehLRWECYJWcMCnTYTXlOqw6BcOPpTGbTPfnLop4RNjTNYj9Uy/SwoiZ7ASwLsiJ8zmg2ZgpIsd+LgeLEs75GLOQmFwDkveJkCEeNRp0hTIQoo33hVfiw648KBCn/hUa6Lb21yeXNWU5H+yMCrWaDX2HMHQ7oNbl3EZSA3ul2DkcfA38k5+bAw91dxFStl5HTi1vIcy9AQV9ARuB8o/OQR5EI+3iqWGHlSweybyQwEP3ClbJI3xzXH9GXDVdXKnIETlPm3dnZ+6LRff56AnKm2z4YzIPjdDC9vPrcQgojeqoqgs40grP8zbI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(23010399003)(366016)(6133799003)(11063799006)(10067099003)(4143699003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1JHUFlPQ1NTVnU2Y3R2WUsyeVlYSTB0SmF5UlJwYnYvTzdJdHRuNTB5UVoz?= =?utf-8?B?L1cyL1NKd243T2JFbEJGS1NPbXZyWmNaaXNreDFPV0R3eFl0OGpMQy9jekZB?= =?utf-8?B?OGp1YTdmVFBURGJIbHdOMCs5Vi9oc1VtK0tXZU1FbkI1QTM5dmNTdjkxQ3Rw?= =?utf-8?B?ZWJqcWFiTE9wak9qRFNwUWIwdWlPRGkzaU50d2x1Y2hoYVNqRVljV08vaGw2?= =?utf-8?B?YWoxNmdUamZqNTBVS3pLMHNBaDAwVFhHcUZzWHM5UTc0WWdoUERWS3NqL25a?= =?utf-8?B?Nlk5ekFad1VNUkI4WDBsM2psU1BoZ0c0ODBoU3V5bXVwdEpmUHUwVDFWV0cv?= =?utf-8?B?K2xFTGwrU1dvck96VTF1aDZEV0ljcklZUWg3Z0xXN2pMakNBMWR4L3E4Z1VL?= =?utf-8?B?VE1FUTYzRWRxNE1LcithNy83N0V4bDhqbnBabXRheWRtTkw2aDlySm4wczhx?= =?utf-8?B?RXhtUm1pMnBHTkdyQnVQeHlhaGJqZGwvOEhnWExDQ2tpRmpkeXF1NWJSaFJK?= =?utf-8?B?RG5DVjhXZkxDQmU2WkYxNnBwdE1BV2dwM2wxT3FtdVRlQUUzSS8xNWNnS1d2?= =?utf-8?B?QXhRbXJTeklMSzhaNG4zeDl6QmF3Y0FYd2Iza2ZCaVVqSzNFYnlwVk9LVzZ2?= =?utf-8?B?YlVLb3ZHT0ZFV0hEWjlpQTJDL2JmclNsa3IvZENXTkhzVGpKczBPbFcwblpq?= =?utf-8?B?K0R6cFBsYXYzejFOazJuVENzajJpWDByMjFTRERQclNqSE1aY3grTTFXVmY3?= =?utf-8?B?NnA5SUVPYzc1aFdoNTRlV3ZJU2Yrc0ducHc0UTNhNHNCK3hCSWFVV1lDNjFU?= =?utf-8?B?Sm9Ways5czF2V0N4SDJoWHFrWUJyY0RDU1JZK2grQ011NUJkZWFaYW0yUzdB?= =?utf-8?B?MGMwcjhuY3RoV2pLakZMNGdpY2FLanhna09YODd5WjRSd2lLcnFLd202eDZ0?= =?utf-8?B?SzMwUjJPaUtEcVh4ZEpRMVVIdlFSMEUwMUFKcXFLRXJMc21McGJSd1lOSWdV?= =?utf-8?B?OWtwb3ZoOTdwd0NKc3BsdCtza2hWZ1VoNGpMTXBBbkZxVTF0dTB5UlNsL2pC?= =?utf-8?B?Q1c4Wmo4YitFSlBXejBTTW4wL2tHclY2NmpTOVBCL1VKemx4ai9GSjJwYkZx?= =?utf-8?B?N0NOdFNmcFRseDNBc0RIUGxVQjVvclZTdHJ4QktmWFVxWEtnQUNVNzJmZVgw?= =?utf-8?B?U050dDJGa3RwT3dkR0ZweVM1L0VmYW05L2RJL2wxd0ZlcjlxdFBaeHZZaW1o?= =?utf-8?B?QWVySVQzdHFmYlEwZmFtSHdOanVrODhOSkliZUU2VmJtK25jNFo2T1pLa1Bx?= =?utf-8?B?ZjhnYWYrZ1dkZHBjaWZOd21VZytUZ3UzOHhURzdoU2s0RkU4UzQ0OWJWQVJt?= =?utf-8?B?ZG9kMkJrZzN0aUdmaEVKczNpYmxWVDh2Z1VnVXI4SzVwR0tmdHNGaUFwb2g1?= =?utf-8?B?dXNWdzQrN0d5NTh6UG1GYTRpNVRkRjRJN3ZTajhMMkhYaGI2OWJxa0RCbHhG?= =?utf-8?B?dmNwbVhrdW1ydGIxK3NtZndFTmNEQlAycjZ1Qm11MjFrQUEwWFFjTUxudjVm?= =?utf-8?B?VkRiM2xITzNDS1lKa1lObzRQVG1QV21mWW5rRkJ6akZBN21laXZXWVRWREFj?= =?utf-8?B?Z05Vc05PK2hFdjVuRVVMdXZ0Q3dyWmVCUnZPYjVkRjNpNk9rK0diQ3FGUzJC?= =?utf-8?B?TllSMUd1b04zNDFyOFYycWhDa0czckFzSEgwNlBqbC9NTDZXYTNwMWthYXJO?= =?utf-8?B?QjN1MitFTWRYb0VzNWNWUm1EZ2xJY09MM2duYVZLWjlMeEpUeTUrTU1rZGhn?= =?utf-8?B?cmFSTVZOWmlMS21ORUhlUUFtYjd5L2pNNy85UkgxOGp3eDhUWUpNTkZZL3RI?= =?utf-8?B?MkRzTXBDaXZ4U2ZPS1lJeDIxOE43dEZBVWg4R3VkSUdVbE5wNlZHS0ZVUitu?= =?utf-8?B?TktoNjBUOFNIZ2xUSllhWFFRSWJMc3g0cHNCUlVwbzcyMnNhR0VxUVQrVXAy?= =?utf-8?B?Zkg1QnJ4YXE0Yy9YZ2kwWjR1N2RRZGY4VDBJM05sdmpJOVI0OXNVMDFBazcv?= =?utf-8?B?NzlvUTVmcHpHMUV5R1Uzcm5nOHAxekNBODRNbUhtdVlENEVOVnlTdUs1VkRL?= =?utf-8?B?ZUMvRXNsZCt3UktCNEloQmpNOHFvYkE5TWROU3hBRVIwOUdnM2ViUlFwOEYy?= =?utf-8?B?MWZybFV5S3N6TFYzakg2WWFaanlLdTN3MWhvaTNuY1pGQ29KZkNPZTVtSEhp?= =?utf-8?B?cCt4T1gycWpQSHJJbURmcEJXd1hnaVE1Q3MyRzVxUG1aRkdHN0s2OFlyaXZv?= =?utf-8?B?ajJvcDNVdVNCMHh2cnNRWEpUa3E1NjdlcWFrYXFmc3psRXFFZFdsdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 623b78f5-6dad-426d-b514-08def244cdc7 X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 16:24:05.8860 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZUL+HsUlYKFVgCcvQJnbI07EDNdGByHWMOBYvW7oaqJjJ/toQXvMixsXS50i9bhiSEf2blL/eaQgOFAInm5ys2dpAj3KdDNBBmRMrd5rY1Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB8122 X-purgate-ID: tlsNG-ef75cf/1785860651-366DAAE4-0C74E280/0/0 X-purgate-type: clean X-purgate-size: 2147 On 20/07/2026 4:48 pm, Marcus Granado wrote: > diff --git a/docs/specs/libxc-migration-stream.pandoc b/docs/specs/libxc-migration-stream.pandoc > index 1319ce1f1e..7469c95139 100644 > --- a/docs/specs/libxc-migration-stream.pandoc > +++ b/docs/specs/libxc-migration-stream.pandoc > @@ -359,6 +360,68 @@ tail. > > \clearpage > > +PAGE_DATA_LZ4 > +------------- > + > +A PAGE_DATA_LZ4 record carries exactly the same information as a > +PAGE_DATA record, but with the page contents LZ4-compressed. The saver > +may emit it in place of a PAGE_DATA record when LZ4 compression has been > +requested. > + > + 0 1 2 3 4 5 6 7 octet > + +-----------------------+-------------------------+ > + | count (C) | (reserved) | > + +-----------------------+-------------------------+ This reserved field in the original PAGE_DATA was earmarked for compression information, but that was on the expectation that we'd be compressing the whole record in one go.  We're going to need to figure out that part first. A complication with compressing in a single block is that we end up with disjoint ranges for any PV pagetable, and for holes in HVM guests, although Frediano's foreign-copy work could be adjusted to arrange for the pagedata to be contiguous. Another question was about the choice of algorithm.  Yes we could use any algorithm, but CPU time in dom0 is at a premium and we want to favour speed over compression ratio.  LZ4 does this.  ZSTD might be acceptable too.  The others are unlikely to be a win. While this is going off topic, it's worth at least mentioning.  Another optimisation I had in mind was to remember the last version of a page that we sent, and on subsequent iterations, XOR the current contents with the old contents.  I posit that plenty of dirty pages will only have a small amount dirty compared to the previous send, meaning the XOR of the two will be mostly zeroes, and run-length encode very well.  The downside is extra memory overhead on the source side, so it's not an automatic win. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 16:28:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 16:28:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382458.1625822 (Exim 4.92) (envelope-from ) id 1wrI0W-0001HN-63; Tue, 04 Aug 2026 16:28:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382458.1625822; Tue, 04 Aug 2026 16:28:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrI0W-0001HG-3K; Tue, 04 Aug 2026 16:28:48 +0000 Received: by outflank-mailman (input) for mailman id 1382458; Tue, 04 Aug 2026 16:28:46 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrI0U-0001Fw-IU for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 16:28:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrI0S-00FQlU-7E for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 18:28:44 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72131d-bab6-0a2a0a5309dd-0a2a450acd8c-36 for ; Tue, 04 Aug 2026 18:28:43 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a721339-f2d2-0a2a450a0019-ac6904fee07c-3 for ; Tue, 04 Aug 2026 18:28:42 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 62FAC600B1; Tue, 4 Aug 2026 16:28:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D41C1F000E9; Tue, 4 Aug 2026 16:28:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:Cc:Subject" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785860921; bh=Kdx7GX4k8VWy3HBExGDyAtAIzWicr30iQzQ7BTOYMx0=; h=Date:From:To:Cc:Subject; b=RfJsSEv+0WQIiqBqX+7JmXsd3Yao6K9YFuLGoKPMZHayEMm6OPcMpVasJ1roiqS5/ rH6vRfL086JTj4gCfzn8Jjo83RdWKQsWUouiRq8i462SqUhipclb1katmLwp97Bc/P zuZ6b6Hqfd3w0ZfbHOddHZKjj0qEApyu6Oqo9V5nSD+xHCcujTxvAlDbKd3k+hsLvT gjkmxpVJZSaYLr/LB0CkweTPoFRqZBtr9C45HucfPhBqxlp33OxzgDr8HmAo7TPt/b voYOypuu6WZX1zVakCN7jF8jxsIDZkX25YA8yharns0KvCxx7ERFntRp5KILs+3Ht5 tNOTZrdkWJPTQ== Date: Tue, 4 Aug 2026 17:28:36 +0100 From: Mark Brown To: Val Packett , Juergen Gross , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Xen Devel Cc: Linux Kernel Mailing List , Linux Next Mailing List Subject: linux-next: build failure after merge of the xen-tip tree Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rglbo7ou1xcCVJY2" Content-Disposition: inline X-purgate-ID: tlsNG-4011c0/1785860923-4BED2CFC-7A2F5682/0/0 X-purgate-type: clean X-purgate-size: 1029 --rglbo7ou1xcCVJY2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi all, After merging the xen-tip tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: modpost: "init_mm" [drivers/xen/xen-privcmd.ko] undefined! Caused by commit 64d26fb2ad1f2 (xen: privcmd: fix ioeventfd crash under PV domain) I have used the tree from next-20260803 instead. --rglbo7ou1xcCVJY2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpyEzQACgkQJNaLcl1U h9DmEgf9GH3biACmWnmq/yNJJWbRBo9ckKis4YF8r9wWF3cUXlbPpFU/onwdiX1R 8niVRJ6do7WpnIleXDsraBsdZT+5A519dVcvwZQTGPZij3w+H6/8kbtSBvDK0hH8 QXNlGwdUHrC4Dmfnn3b7cSHA0kM1u7lkmGwlNjDnDypmVw/tV9KOVRSrFRDk1yax mjo6dYuai6eYmZ0RwZlX7R1u0BDDnJq0qwuI0Rz88ZvK8YSrE267CSXwQl9sJhzy S4Jclf7ASn5mR3RiNeI7ad/S8CmWOE4hFQLD/MaWEOFXB1ZkFpM06cRsD/nuSzld nTl9c3Va63TUmODp3RhIh3aLzwy7Wg== =/t8B -----END PGP SIGNATURE----- --rglbo7ou1xcCVJY2-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 17:14:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 17:14:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382486.1625843 (Exim 4.92) (envelope-from ) id 1wrIi9-0008QK-E5; Tue, 04 Aug 2026 17:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382486.1625843; Tue, 04 Aug 2026 17:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrIi9-0008QD-BC; Tue, 04 Aug 2026 17:13:53 +0000 Received: by outflank-mailman (input) for mailman id 1382486; Tue, 04 Aug 2026 17:13:52 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrIi7-0008P2-T1 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:13:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrIi6-0074nb-VO for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:13:50 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a721dcb-bab6-0a2a0a5309dd-0a2a4502d854-4 for ; Tue, 04 Aug 2026 19:13:50 +0200 Received: from [52.101.56.24] (helo=BN1PR04CU002.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a721dcd-6ca4-0a2a45020019-34653818a7ab-3 for ; Tue, 04 Aug 2026 19:13:50 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by IA3PR03MB7764.namprd03.prod.outlook.com (2603:10b6:208:50c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Tue, 4 Aug 2026 17:13:48 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Tue, 4 Aug 2026 17:13:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QGqyhXyIjLDdWAVieG7QobmoigOgx7jcmvd0xhTz+8+AZEF4L39zMbaYEzw2+y1TJnX38zENReqjUONan/go71Ky0mjnoESn6IYDA/i8RhDvT2LQCDKip/8eq2rjrZLsAbWZhwybcO/GhKgcWmOLz0MlYhSp8c1jGBH/lju03M6E/dg5pmC9O/NNURFwbsg8datYFRSgKIcxaVC936lJJmgAtMedfJv2/L3/8Kys/XS2fAgSkPDchKMTIit0XWtIZut8bnNdn9U8NiwAwsIJtgMlLOX90tK2IqxVOaihFEl3O9llijOXxYFq+Bj8/K9ONMceB7QZTvcuYAzExZ/xXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zx1F8nl9j7tXALRL1U17qJhg2+6Ayc3Y9A703hScVhM=; b=TPS3ymXgNmt1+AbanbjR7i34cJSGw6Vz8jqtyUk5NRzv/HYUQmEwyYCV0lya8qD2DTphh5Jrlb7UYiYNUTHPVpS7yS1SL1mo/9NzGikfTONHlA7Vad7IdPrhRN6nWibiPawuObQbVm4vW7PkUxWtmY99tQrXE9yWJ+sDOLHbrr5ZaDw+++/nS76DXg6Tr0YyHAWHhnAGJ0FZ/xOcArx+SYKGLz2wuVAZWHx0NX8hy/keibBtcGuqDsOJprO9goVGLoPyu/pq02DfHmu5zTHtLHZdXASWzX761U/xoiczTRysAfqeejBYPEEUk8quUNaq65irqDlsgGr1hg5RWo13Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zx1F8nl9j7tXALRL1U17qJhg2+6Ayc3Y9A703hScVhM=; b=s4DfpHnWS4P0kCgHZKBhdNtseIiIh6oGHlo4wUM477JEnnZjtXU+l1qy6elteXMfO52zQRanLy4I4KN05206EBsclnQywr1p+EkIAGxwPqZVb5JIwGvPF+K7D1i1RL3ODofNf3loniyVmX9/MyOOkzNuF2w3AxJ4GmWBhLLi9T0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 4 Aug 2026 18:13:45 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Xen-devel Subject: Re: [PATCH 2/3] x86/alternatives: Rework get_ideal_nops() To: Jan Beulich References: <20250522150015.555492-1-andrew.cooper3@citrix.com> <20250522150015.555492-3-andrew.cooper3@citrix.com> <99a39800-dbba-4d37-afcb-ae041af648f4@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <99a39800-dbba-4d37-afcb-ae041af648f4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0106.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::21) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|IA3PR03MB7764:EE_ X-MS-Office365-Filtering-Correlation-Id: 014bdde5-ee34-499e-b69f-08def24bbf2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|366016|10067099003|56012099006|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ELexaLCm117iZoWkpMbWEEGFU+12lY+u7pKjX8TUSi9VH+bQXwKhjvfXvmbePfAbxtJc7noRIcvlYJOJiEUJTHUlRTM5Iudv1BbmpvHo1DfTYqIiRdClZUeO2SJiSOqSEngqSq+4oo3i11SA+jFABTMEVQ9OSShF9oMe/6agN8vAEc5R2Uvt7jJhatRapY1+kwnyGvTfWr9ZBemzrZbSrLlPpQDFvZnjGGbiayv7tteQQ/C2KSM7kwTdzVDJ+xy0V7+wf9DTzoI3On7Y6t6CIJMAyLyB0R+8Z1Ipon+LEIKSJ9GtwXDQcopwpkB32NB3JZ/QXPVsKXIv3Yx6RT5tFoZ/CXMuc4GLN+HUeZpEt+uk5MNHmXdU6aZtN54QpgtpYEDbmovoOzCnFJ1rTGi4NPMpbn5GqhvwjP/6X3qJmn0IebMg/tafxLBE3nrxSFTCeUbtikpog7582d2sGoboHex2kHcuZtSZl2mo/TJoslbdTnJuVb1+30ttecHTJpXvxae76C7OeFAjOT4kTuAoxUTmxxexUIoSw236qjzy8ZGM18+Flpa9C+M5Eagxq89katBEj+GEuuDjNUmyuU7mcRCxRJloGS4mAkoBUeMUVLLuWN+HbREijms1SJtbKJhIiWvzCwNYFIYTYDaEjEl3VRoJBavDFmMfh5lt8ZPaYUY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(10067099003)(56012099006)(11063799006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckcvdUI0b2xoMUhMVXA3VzhoYnM4OWsrQWZqNzhHazhncTNDUkZSSmQ1bXY4?= =?utf-8?B?bnFYYVQxa2djS2J1Ty80WnMrNlU1c0YxQlJJcGNuM1FscHhjTUZrRFAzS1hZ?= =?utf-8?B?T2ZnTUZleUtORHBVZFNZenczY01Pa05wWkU2NitGa2tWWmxaa00wNEdEeTBY?= =?utf-8?B?M1p2bFhKUksrb0Z6dUJYeHZNOUUxUTNTQ05MblJDUklQZGpHOGp5d2xnQms3?= =?utf-8?B?VW96VjFVaXpaeFlmYmNUQ0ZEOW9kVFJKY0Y4TlZIamowYUxsdzJiVTRoVjN1?= =?utf-8?B?Y255SnhRRzZ1ckRITE53WFhPQzZPZ0l4b01rSzcyTTAzMHZrVkZSanBwS3Mv?= =?utf-8?B?VWJzSjNuUjJGUmlCOEhXWGtzQjlDdWprT0RGS2NOOEZkekFvSlFVeE9lUmpX?= =?utf-8?B?bkhvSmlxOHZRZ25sQ3lkdGxFNjgwT0lrSDU4emlGTU5xRHVVQ1pvenQ1bVF1?= =?utf-8?B?UFQ1bm9HRUxpRUhReXV1ZXpPZDNERmhTTFR1bTNacHJjK3dKRlp3dlpyVkIx?= =?utf-8?B?d2RObVhWUnBGTWJWRUNkWDlBOS9Dbng5UGlaVWYyZ3lUVG9MS2FFOFFhU0tU?= =?utf-8?B?QUVEMGdLMkx2TGZYWGZRSW1XcGRabVFDb2k4T3c1VVdQeUVwcHZwNnRBcDhl?= =?utf-8?B?Y1gzQ2ttYU16VEFmUFdkYTYzWWs0SFZOZGRJOGt2MGQwaFlBYjg2bVBIbW9W?= =?utf-8?B?S3pTdkt1V3l2d1V4RWkzVmljYnJONkRFUmIwOUpoRXJDbW9EV3Z5WDBxNGZ2?= =?utf-8?B?TUlVTWc0ZmdsRGhRT3lkZEpOZTVPZDBDUTc1Q0IyUVgvdWJ4MmhDZ1N3S2dq?= =?utf-8?B?YVZnb1hWZDlTZXFFcFpPMmQ2M0s1TFVRWFdlN0hKeHh2NkZRdmZWaU5mRXRr?= =?utf-8?B?eHpNdlY0Zm1SZzVZelJ3azBuZHJxWlFpc0dTVGtYbTZTM0VQWkJaTlJ0Wk5v?= =?utf-8?B?aGN0RkhVUStkOVlEOWpmQzFxWXlWR2RRaDV4ZGkrYXJPdThxcHFqb1N2bnpL?= =?utf-8?B?YTNKNk5pSDdrTW9rL1dDY3dEeUx2bWhIREhhYXYyY3Zqc1ZBUGJmTGZObDY3?= =?utf-8?B?d1hERUMwbk1iK1RYUlZzcGphcVBldGlaZWw1TXUydFJLSlB5aVVTMDlUdlY5?= =?utf-8?B?SDg3SjM4cDBrdlZjMlZUSXU0d1cvL2ZWWDNQbExUZktML1ZJQmhCT0t2U2d0?= =?utf-8?B?a1IrR2U0bFlCYkNDazVPUjJZelBoMnkzTnNDTGg1ZWRna3ZXeExST1gwMk96?= =?utf-8?B?eHNhWnhPQlNyeUtZSmVHRW56ZDZkRFBrbnBzdGV2UW5IdzFHaVV2VmNvYSto?= =?utf-8?B?RkxRTGRiNGR0MkhJQW9GR1FhYWVCWDN1YUg1aklCNFdQT3FJQTNzV2JxbURl?= =?utf-8?B?T0o0SzFGRjU0OGE1OFN1NGtleDB1enE1YXRuRzVUdjdFVDMwWDlsWEFvTSta?= =?utf-8?B?MGk0SHE1RXhHT0gwWFlSOE5nT0dGRVBDSmREblZqK0ZyY3hyRU5yTUVtWnNB?= =?utf-8?B?R0prVkF6RFFkTi8ydjBOanJjVWthRVlaNlpUSGNuR25wbGZxemh3b2haclNa?= =?utf-8?B?dUN4V3hJNGdFaTRkdEo5T1RhL2VuOFVKbmo5Y3ZWNnhzQWx0bEphVGl2Z2ZG?= =?utf-8?B?K2dKVzdQRC9ra3pDQnV3WlVYSXJ5NmMzQWVPNDVGWGFPK0YyaVBYSjVjV1V1?= =?utf-8?B?VFVlWGZlc2Nza1BQY2JjbGZlWU5NWmNaN0w3RjAxSFZoNi8wc0VrMUd1TWEw?= =?utf-8?B?bXlXMjhUMGtvbjNSN1F5cE5DekVvNmIrS0lRV0dISE4zbE9HVVVkK2k5ZUZ4?= =?utf-8?B?azlMdzlYUHFJSE1keVdZRjJneTBYSTVlZGwzNGNCeERjeXRHSHZWcGo5Z3do?= =?utf-8?B?L05SVFdZYkV2dE5oUWlqemRwZWxuWWw2ZTl2czFwci9wQVFWVVVhYlVJdUZz?= =?utf-8?B?ZTNjM3ZzR2pMNG9raUlGSTRjU1NzVEVCVUtYRTArRGFkLzQrOWlZaVo2SXh1?= =?utf-8?B?UXFuOURKa3N6NWlxcmE1d0RaREx3MFY5ekhzVkV6cHFVbXhsdUZ5MnhBU215?= =?utf-8?B?UVBLSkw5eERvRWc3Wk1UNUJ1T05oZjdzVld1dWIrc2d6UWVaMXZ0eHlDUGtJ?= =?utf-8?B?MDhKay95bndaWU4vUmV2amdYTi92cTdXaXV3SGNjNkw3V2pOQXJPWlNqblAx?= =?utf-8?B?bnJWY3drWEo1ZzBPSEhMNFVtTE1jSGhlWkdYSzdsSHFhMkFrdjMwTmhKOElk?= =?utf-8?B?c1hZdGZ0ZXhQTHJ2TFc5NHhFeXJIZDFVYmFjWktaQ3hxSHhCNTlRdTlWVitz?= =?utf-8?B?aHZ1QUVoZUN0a3YvS1JVSnFxU0hQdW1maVlYZW5tNXNrVTMxQk5hQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 014bdde5-ee34-499e-b69f-08def24bbf2b X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 17:13:47.9026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9Bt+f3sgcPHL4C52UO/P9UYPd1D1ZYyYECTrUJA3pWMQiaJ0gcj6MPVypcBfB6DBASI9XG1iJbPArlQttFrxprUeM71WWqkJ+jVIsfZtJfE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR03MB7764 X-purgate-ID: tlsNG-720697/1785863630-31FD62AC-F0D9089F/0/0 X-purgate-type: clean X-purgate-size: 1662 On 02/06/2025 10:57 am, Jan Beulich wrote: > On 22.05.2025 17:00, Andrew Cooper wrote: >> The implemenation of get_ideal_nops() changes from: >> >> mov 0x19bc41(%rip),%rax # >> mov %edi,%edi >> mov (%rax,%rdi,8),%rax >> jmp <__x86_return_thunk> >> >> to: >> >> lea -0x1(%rdi),%eax >> imul %edi,%eax >> shr %eax >> add 0x67fc1(%rip),%rax # >> jmp <__x86_return_thunk> >> >> The imul has a latency of 3 cycles on all CPUs back to the K8 and Nehalem. >> It's better than an extra deference on all CPUs, even the older ones. > While this is all good, what we're losing is ... > >> --- a/xen/arch/x86/alternative.c >> +++ b/xen/arch/x86/alternative.c >> @@ -20,7 +20,7 @@ >> #define MAX_PATCH_LEN (255-1) >> >> #ifdef K8_NOP1 >> -static const unsigned char k8nops[] init_or_livepatch_const = { >> +static const unsigned char k8_nops[] init_or_livepatch_const = { >> K8_NOP1, >> K8_NOP2, >> K8_NOP3, >> @@ -31,22 +31,10 @@ static const unsigned char k8nops[] init_or_livepatch_const = { >> K8_NOP8, >> K8_NOP9, >> }; >> -static const unsigned char * const k8_nops[ASM_NOP_MAX+1] init_or_livepatch_constrel = { > ... the (at least visual) connection to ASM_NOP_MAX. Could I talk you into > adding build time array-size checks for both arrays, to restore the > connection? Sorry, but I have no idea what you're asking for here. The use of ASM_NOP_MAX was latently buggy before; it was easy to create a NULL deference if the initialiser wasn't filled in when ASM_NOP_MAX changed. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 17:43:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 17:43:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382507.1625854 (Exim 4.92) (envelope-from ) id 1wrJAc-0004HL-JF; Tue, 04 Aug 2026 17:43:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382507.1625854; Tue, 04 Aug 2026 17:43:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJAc-0004HE-FS; Tue, 04 Aug 2026 17:43:18 +0000 Received: by outflank-mailman (input) for mailman id 1382507; Tue, 04 Aug 2026 17:43:17 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJAb-0004H7-CC for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:43:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrJAa-001NYu-PP for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:43:16 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72247a-bab6-0a2a0a5309dd-0a2a450ab7d0-42 for ; Tue, 04 Aug 2026 19:43:16 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7224b4-f2d2-0a2a450a0019-d1558031f1b1-3 for ; Tue, 04 Aug 2026 19:43:16 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49800c6a846so551155e9.3 for ; Tue, 04 Aug 2026 10:43:16 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994dfe64e0sm17657735e9.6.2026.08.04.10.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:43:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785865396; x=1786470196; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xhcQEnEut2xAAreQwODiVE7doxB7Jsdq8IAHiAi9kX0=; b=bFsJNWfxrZDnotwsthDQHRligR74wV1Yf63ba+bANB2BJMddjVo23AX3Srm1c276pD zf4bSmJjoPVhN2I8sQ0FLEcHZk0t/zLqi6b1IwiRfuFEGIghtt7q4WmaeM5FcnIMXDrW JFQzQeDprL/u+9VqqjhH6FGUSQLnK73qcVmAp/loTTvtQ70A+21951SvQ1obMt+znAcx tZw5ACqXsnZ8t0aBgoB7FyEc3CLQ5uQL635+Qv7Ku2bcrqizWlM5I7QBsW+H+ct5t22g ALup4uHxUHksE3BN/U/J5Zbo8k1YsmqTnYBjCiHebhzyi0ZcRWeeIeASA01IPTiI6wFP PnTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785865396; x=1786470196; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xhcQEnEut2xAAreQwODiVE7doxB7Jsdq8IAHiAi9kX0=; b=fHpeYBAUENlJ6kFDLbWHQCIH+7X3iw7g0oD3DqAgOe3zVi38lcsGadycKzD+6LTjsi OvdYTQzcS1Jah1EiRfO+8jaXTKggxoVof6e1jKtQrj1bu0667sKTRfoFGpBquiofy9sX l4CX2XuZgSqjX0au+F2lMgaEGPDrSxYRJPbTHS8kbOR//dOsWulbpaMs/XD0Qk077q+q IVFXtC/kUMGWgbM2Ei8mRAko7COf7WJlqFOJM8uQ4KOk97co+tFVB+rfafmAA2xMyjFs ofJj52FtCERHSXPCKhFyEViiaSZZnpm2Pl1VejjIdUHQnmcmQOWg+GhYq0upTMubZKJX Ue0g== X-Gm-Message-State: AOJu0YxYSRNYgvvBYPiXV0WZJAKc2XLhKLajwDfiyO494NhyUfHUw7Hp yp7+UqZ5TYjIAB8+oZvMleVBeyA8jIT7SGajqmnG29PLe4qG2tDN9qDCa3TpwZsaviU= X-Gm-Gg: AR+sD10+avuvoJ2/d+lJfhLeuz7z1bhzY2mz8GEDnxOVNs5n+4qN3LbLD1ZIFjmWf+P UWGzkIcSDfvrYxW9o3E+72JDYhOMI6mb0oBrzFiyDFxxsyd4ftzAOrjrshBIPiBTb1mpsAPDpLg lAmKTdQ1+xZosZvaTaB+IMTtkTO1eMugUAVwZj8e9QxHe0uwnSHaZcjFvZA0htGe/LEM3IH93BT YaGWXlBi0ZneEFWpOm+ri7/Bf/kSr2hfXfrwxzjexwiBHKs6MeG5jKru3Bldy8zgEMbvP+2/yhk xkCWs3+yKLUPTShG+LYkmz5TqCMTf2KTLCSlMzUEXmP8+CvA3pUCF259VVORvO/7OC/7EetVcbK Od+xJ8aivgKcv87Z4Vr7UISKVE8XUcFV/ZVVeJ/3y1YXX19uIso670jMnRaMd92oTBUNRMypn5Y 07J4yf5S0OdjyPmDoWai4aynx8VmeJCDY4KATPqXQELIMvQB8o3uivxndQ5Ciam7kd6F4nAYdRI 2lHjPndiaMGjvvciVatolckoH1lFAjaNewim3U2fNJmEjgI03k= X-Received: by 2002:a05:600c:e48a:b0:496:ca1f:a428 with SMTP id 5b1f17b1804b1-4980c695d6emr250589315e9.19.1785865395972; Tue, 04 Aug 2026 10:43:15 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH 0/2] CI: Check save/restore, minor style update Date: Tue, 4 Aug 2026 18:42:16 +0100 Message-ID: <20260804174219.835096-1-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1785865396-530D9CFC-369CA70B/0/0 X-purgate-type: clean X-purgate-size: 483 Main change is the second commit implementing a test for save and restore. First commit is just a style change to reduce number of commands (and lines). Frediano Ziglio (2): CI: Simplify directories creation CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 automation/scripts/console.exp | 8 ++++ automation/scripts/qemu-alpine-x86_64.sh | 51 ++++++++++++++++++------ 2 files changed, 47 insertions(+), 12 deletions(-) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 17:43:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 17:43:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382508.1625862 (Exim 4.92) (envelope-from ) id 1wrJAe-0004U4-Oh; Tue, 04 Aug 2026 17:43:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382508.1625862; Tue, 04 Aug 2026 17:43:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJAe-0004Tx-M5; Tue, 04 Aug 2026 17:43:20 +0000 Received: by outflank-mailman (input) for mailman id 1382508; Tue, 04 Aug 2026 17:43:19 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJAd-0004Ti-MG for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:43:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrJAd-001NYu-36 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:43:19 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7224b3-bab6-0a2a0a5309dd-0a2a45098d02-10 for ; Tue, 04 Aug 2026 19:43:19 +0200 Received: from [209.85.221.51] (helo=mail-wr1-f51.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7224b6-be1a-0a2a45090019-d155dd33d504-3 for ; Tue, 04 Aug 2026 19:43:19 +0200 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso51476f8f.1 for ; Tue, 04 Aug 2026 10:43:19 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994dfe64e0sm17657735e9.6.2026.08.04.10.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:43:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785865398; x=1786470198; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LJbe7BqS6R6E73aZnDhX1SHtM9ZoBc4H0nu3Jn4E/GA=; b=DqYzRCwxbpS0JBRR9yh85QOfeJrEXYjOciB+ggM3H6dy4SEN6CTBXzOLLM05GVPBVQ kx4sBSV2nJyNhe8RRvIy1Bh07NytXOofvod+4xnLIOK+zO6v68NVe/ROz/0G0FJdbekH zdRLxC2NnWnpUF5EeDvjHwFKT9ZocFWXoBc6+cVA52Tjw3eZJKOnjqXBB+HV8ww4UqZo VOO0CMsMbqFHx0xPs/12H3a2Civ//tFz1nDZ8G3PmcZhGIS/18L6msW65rq4Kqju9xnA B7ZeZQUp2nadvHVexvxMkZszIYAiBIX7wnfYaKVugxPkdN6BIeVkC4holbRjepveD87w vosg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785865398; x=1786470198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LJbe7BqS6R6E73aZnDhX1SHtM9ZoBc4H0nu3Jn4E/GA=; b=HsEmDmuDwxNPHK0ICBO6oDoSYCOGLYtkuuoQh+MOpaZbcQbiYzPqmzTslsiuNRVSF3 CmTDpspq0Lo+3LvSP2eHOx0FWD7oW0pWjnHsE2VMjbFs6cBHycCheTf4g7Gfu/nFa+lM 6SzlUy3vuJqigxr4obqOhoX6VuHOgszkTy9wMlY+N5GyXX1tr6yrg+oeBf5dV/dIlrdL zxlCVUJpF4gisrOEbVGTgo8HHagOtQL/NPLdeAUXLsaUXRvgrJbscuawIEzx/xmKMGlt ++E9WSXO14hsL7B00F8p0iWOKgRCrmnscbEQhB1zsLitTgFHkWx7wAuXnAp0gQUBV9Sy 8Wnw== X-Gm-Message-State: AOJu0YwHGndAcSUQM+5ptEgmGIegh6T4Z/TNtcN/aeIPq8vfCp2ZIEXW ujujA2HJCTP4MzaOzy0f8Wcy/LiZLzUHxmPITc2Bn934SxW33vEWTXJwvKaQDZqraL0= X-Gm-Gg: AR+sD12yCGX+3K4nGMTNxNLIgjgm0ds4ti+Egfx93rl4HcHWLtzXkymJL1Z4jy5voYf eLdJ4Bm9GLPXf8JPE2bhkwtszYU6QRx7PAHBGLxEtMzcUbWQAhJTUHrsCXorZ6xkN/Wj/BS+Ukx JWITU2p9cZf7rU3z2YDVvTw48qFDZNZ68QVDrqbO6/VTsfCIkiWsIiQF54GxtlzXDotZElkyC+H 6v3aO9qoL5JpDJcyySDl9OXsm6lC2CCxlU0kLoSVKTwTmBW4ISr0vSCq+SmqJGt7uD07r1VA95x c+zeKusMU7Y4jORix5zS3ASXoFdwprd3vp44/xyVrcelqaVMPVn02j1ER4hZKTfCR+X+iWz60We BoxmM01o9R+W1va+aabcox5uYtd5zyG98ipUK7CSs4M+hEVMVcM+OQgOZ1eEsY+T7OZjzdlGpDG H4VHS9utpP56SdSuoa6sohML/Ud6eheSOUa/xIXVn02leUfHhj99oDYpGOWUxouw1yFqnDTQJXi H+ZOfYNF0tV1rvZftlQHUL14jHAZpONUb120FNi X-Received: by 2002:a05:600c:840f:b0:493:bacb:1341 with SMTP id 5b1f17b1804b1-4994e72605emr742705e9.4.1785865398418; Tue, 04 Aug 2026 10:43:18 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 Date: Tue, 4 Aug 2026 18:42:18 +0100 Message-ID: <20260804174219.835096-3-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804174219.835096-1-frediano.ziglio@citrix.com> References: <20260804174219.835096-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785865399-FD668034-4C7677C1/0/0 X-purgate-type: clean X-purgate-size: 2998 Make sure that save/restore continue to work. The check save and restore twice to check for corrupted status. Also a command is launched in the guest to make sure that the machine is not crashed but working. Signed-off-by: Frediano Ziglio --- automation/scripts/console.exp | 8 +++++ automation/scripts/qemu-alpine-x86_64.sh | 40 ++++++++++++++++++++++-- 2 files changed, 46 insertions(+), 2 deletions(-) diff --git a/automation/scripts/console.exp b/automation/scripts/console.exp index e27886bbef..ff58ed29b8 100755 --- a/automation/scripts/console.exp +++ b/automation/scripts/console.exp @@ -58,6 +58,14 @@ if {[info exists env(WAKEUP_CMD)]} { system "$env(WAKEUP_CMD)" } +if {[info exists env(EXPECT_TEXTS)]} { + set lines [split "$env(EXPECT_TEXTS)" "\n"] + foreach {exp snd} $lines { + expect -re "$exp" + send "$snd\n" + } +} + if {[info exists env(LOG_MSG)]} { expect { -notransfer -re "$env(PASSED)" { diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh index 60f5cc49fc..409a601c34 100755 --- a/automation/scripts/qemu-alpine-x86_64.sh +++ b/automation/scripts/qemu-alpine-x86_64.sh @@ -48,6 +48,28 @@ xl -vvv create -c /root/domU.cfg " > etc/local.d/xen.start chmod +x etc/local.d/xen.start + +# Script to test save and restore. +# It saves and restores domU domain twice to check if the domain was corrupted +# during the first sequence. +# At the end open the console to check if the domain is working. +cat > root/save_restore_test << "EOF" +#!/bin/sh +set -ex +xl list | grep -q domU +rm -f save.dat +xl save "$(xl list | awk '$1=="domU" { print $2 }')" save.dat /root/domU.cfg +xl restore /root/domU.cfg save.dat +xl list | grep -q domU +rm -f save.dat +xl save "$(xl list | awk '$1=="domU" { print $2 }')" save.dat /root/domU.cfg +xl restore /root/domU.cfg save.dat +xl list | grep -q domU +rm -f save.dat +xl console "$(xl list | awk '$1=="domU" { print $2 }')" +EOF +chmod +x root/save_restore_test + find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz cd ../.. @@ -70,9 +92,23 @@ export TEST_CMD="qemu-system-x86_64 \ -device virtio-net-pci,netdev=n0 \ -netdev user,id=n0,tftp=binaries,bootfile=/pxelinux.0" +# Sequence of expect/send strings: +# 1. wait domain start and close console; +# 2. wait login prompt and login as root +# 3. wait login and launch save/restore test; +# 4. wait restore from domain console and send a command. +gs=$'\x1d' +export EXPECT_TEXTS="BusyBox +$gs $gs +login: +root +login on +/root/save_restore_test +Restarting tasks +dmesg | grep suspending | tr o 0" + export TEST_LOG="smoke.serial" export BOOT_MSG="Latest ChangeSet: " -export LOG_MSG="Domain-0" -export PASSED="BusyBox" +export PASSED="suspending xenst0re" ./automation/scripts/console.exp |& sed 's/\r\+$//' -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 17:43:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 17:43:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382509.1625867 (Exim 4.92) (envelope-from ) id 1wrJAf-0004WF-07; Tue, 04 Aug 2026 17:43:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382509.1625867; Tue, 04 Aug 2026 17:43:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJAe-0004VS-Sn; Tue, 04 Aug 2026 17:43:20 +0000 Received: by outflank-mailman (input) for mailman id 1382509; Tue, 04 Aug 2026 17:43:19 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJAd-0004HD-Nk for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:43:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrJAb-0078XC-I4 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:43:17 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7224b2-2eae-0a2a0a5409dd-0a2a45059d12-6 for ; Tue, 04 Aug 2026 19:43:17 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7224b5-4cb1-0a2a45050019-d1558036d52b-3 for ; Tue, 04 Aug 2026 19:43:17 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so620835e9.1 for ; Tue, 04 Aug 2026 10:43:17 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994dfe64e0sm17657735e9.6.2026.08.04.10.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:43:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785865397; x=1786470197; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QpDC3I+ovYUvjlP9wcYAb5gWHhSg8anilOmH4yhtzyI=; b=ZrmFnrPfXw2bdZcmMrNRblnkq3U51V2RwEUqp1Pd0j2tgWQ/fMXQmHxPhKFZKBlJX0 VsXsyLT2ANXupm25z55oG1wkYwWj1MFCzrc2Vbmj0aDRmBQnx/CMZvVEyzLhV5gMgJaT mng25wzn6bhBCtVFu6X25GdXiFjdR7+3reQAza+gO3+TrbwVf4SawPpCyeECzESTVSRi BRCcu4KE60z1DyS2QZSDmTPcX+GOi0N7SPuOyVyuN0wGzORib9aWxxQgXTmIIatk7Ekl VFf7N+xewO3jh7LIgmvg633zHLHyq5rp0FHl1xfuSJy2qai13T+Fq3y2w58CIUOLss0L 4sdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785865397; x=1786470197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QpDC3I+ovYUvjlP9wcYAb5gWHhSg8anilOmH4yhtzyI=; b=FvJkflRghY9sO7ZdcSVPcryvIX2My429yYdun+Scgn0UZ18dOwk3Jq2sTc+WfKVc2D 08/q1KYvyq6EKMQaq8RrY2W58Bz00kZgKmyWBVep0wXBABXlud2/pyClx2O0rp50ZsiV M/4cq0T1FV2dlxRwrzWpxg5r7IebOl6ejuJGCfV3lJZlHr6V+ckvqVFDsfQ/0D/0zzPJ orV1UX2DuE52XFJa5BP2kgSuUbf4WJBkuv/32I62F4x3WIZwryIIsDovShuI28AwaKAr ZQJMEpTSifyX3uttjDchYd1SdGxSKnRFbMJgIn3K35u3aKzWvwBjqVO40dXPWoL87f63 czog== X-Gm-Message-State: AOJu0Yz6GvkKFEyGmDNnNLvnm1eZfZFDFcE+KDzUwYvNtSFG9lwlnIqb eUVcA2uIDJQuqQ+d8PwineSr5YZa4ULnRCG0omRVuPfHq1CoUWBNHZ14QMr8t3D86lg= X-Gm-Gg: AR+sD12X8GU+UbY2kWybEqu2dMdkxBFtjowquJzGC9vYEaWpDcRYukS2bmc1JkEB2ie iwWszCgDC6NlZfddbd8g5MUEURi40gB2NO1GzJNx17+tjUAxDrBvYAwnh4p7n5L9DfaZbV6tzmj lu7WbTZ3/6i/ilQnNT7p+R4wsZICAEq/SeMMHzX1Vq1A8JFc+vu3RCAjsKUp3a+rinnxO4EBbFh qhHkLoZ1L8K+0Pm7va/9X5s4ooyHlaSBHYGpugB/n0DB2n9r07euTLswRYyWWkZW/i6LcEVhYeo jeBkoKY7uvoWibcOSWVTmDu91SEpVR74N84KMleuQkCX7J2dQKoHheZYPFwqMaTTJUE5sHRWAS8 5wQ6z+RMZHzjAGmXqTroQ1WDoP76LEKY9PWe9LkBq1BSCj9LDTbH16bm0zHl+OlFijoWj5ZtBbZ axCjgVu7+minBCVKUHkYhxMpEJY+Nl40azKeQiAP10Gfxuyr++h9bhKB9eK09O0CyOpwwaOxQch DvzmdoOz/qzOcDyNR+D3PqGi4Uy8J5+O/scAaquYwwzhsTQQns= X-Received: by 2002:a05:600c:3586:b0:499:49f3:77b1 with SMTP id 5b1f17b1804b1-4994e728283mr695025e9.3.1785865396781; Tue, 04 Aug 2026 10:43:16 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH 1/2] CI: Simplify directories creation Date: Tue, 4 Aug 2026 18:42:17 +0100 Message-ID: <20260804174219.835096-2-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804174219.835096-1-frediano.ziglio@citrix.com> References: <20260804174219.835096-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1785865397-F429B2A1-013AD751/0/0 X-purgate-type: clean X-purgate-size: 894 Use a single command. Signed-off-by: Frediano Ziglio --- automation/scripts/qemu-alpine-x86_64.sh | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh index 242ffca693..60f5cc49fc 100755 --- a/automation/scripts/qemu-alpine-x86_64.sh +++ b/automation/scripts/qemu-alpine-x86_64.sh @@ -4,16 +4,7 @@ set -ex -o pipefail # DomU Busybox cd binaries -mkdir -p initrd -mkdir -p initrd/bin -mkdir -p initrd/sbin -mkdir -p initrd/etc -mkdir -p initrd/dev -mkdir -p initrd/proc -mkdir -p initrd/sys -mkdir -p initrd/lib -mkdir -p initrd/var -mkdir -p initrd/mnt +mkdir -p initrd/{bin,sbin,etc,dev,proc,sys,lib,var,mnt} cp /bin/busybox initrd/bin/busybox initrd/bin/busybox --install initrd/bin echo "#!/bin/sh -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 04 17:57:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 17:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382534.1625881 (Exim 4.92) (envelope-from ) id 1wrJO3-00073v-B9; Tue, 04 Aug 2026 17:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382534.1625881; Tue, 04 Aug 2026 17:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJO3-00073o-6h; Tue, 04 Aug 2026 17:57:11 +0000 Received: by outflank-mailman (input) for mailman id 1382534; Tue, 04 Aug 2026 17:57:09 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJO1-00073i-4w for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 17:57:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrJNz-004aPi-VW for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:57:08 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7227ec-bab6-0a2a0a5309dd-0a2a4504d772-4 for ; Tue, 04 Aug 2026 19:57:07 +0200 Received: from [202.12.124.147] (helo=fout-b4-smtp.messagingengine.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7227f2-b57f-0a2a45040019-ca0c7c93a625-3 for ; Tue, 04 Aug 2026 19:57:07 +0200 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 9BDE81D000D1; Tue, 4 Aug 2026 13:57:05 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Tue, 04 Aug 2026 13:57:05 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Aug 2026 13:57:03 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1785866225; x=1785952625; bh=ilvpJNpKGxrxV5kM33ClZ1xTMRTeR1+MX3jPiDtUlC4=; b= K2METpv0Gv2Wyb7EmMIj1hF9Orky8caRFzOdiQDv23RBX9ItDXQ9Tg/YiBe0G8C/ 36eJQVyFR/8TkLqn2O+Z08O2dCN2wuRPdwi+DzfaUx1E8YgCWAW81FiMqX68F8gE Y5tz0uGe69B26aitB+8ZkC+t0H3YJA1atBI35XJi1TkEasNn60oOVr3RpRw5yBmX FpLjua26wZ8qWIXFYNEnJx2i/NsS99idxEOEeIp5Dx1qJRWIanffRroegbXaqJ3b 5lBzDDH08i7ztpti1/nJ8YGwMh+a8npCEGjW6X+Ggf4VtrBJY+0l1ohtytG94mIb YNoHhF59DJvqLRCdb8VXZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1785866225; x=1785952625; bh=ilvpJNpKGxrxV5kM33ClZ1xTMRTeR1+MX3j PiDtUlC4=; b=TfFt0xlY436n2kfkobk2xkIQ+/ScVkVZ+KlgO+jTCDv9zG4ARCt lruEPNOXon0fRui7dwg5FCJO0yfsPOmahqGlTQ6p/NrWtJLZSk0ZieNb3fENt5t9 q1URJoOM1dDefmIN8A93F/pTWz1cgEKuFG7XKNiGTtygJvZyCyuncxl5qjFzkpir NOLGSJHG42vgX3mTPX9K8TBBgb9wOHhFLswaiIzZ7PVxZnk3DmCLcM3Vd8RSgydx glBUn7xX1EA9onJZXDgg+eS6+VfjOsTtnqn+CC/GDWPgOAo719C0nsgQvBbViJpy 9PHUFlw5nbgGDqsudlIOfYsg3XLaw/8JI8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFTQJJq3HwzaBpsrRj+7R0dJX3Gux2GZu8uRmZucoiC10YCI5CaParej3yLyYTTgY 3YqGdhJwj/V9t8LBWfFJaL6Q3bnm2sWD2nhCeJrWc0ZgocG2yOIt+62/ob58ziD3n6Y7dw yH1RupsKh6+yiK003ybzwftZ57tUkSEOZb/6+EsypgeVm1hwwfuP5WTKqL5DW4Z3KzjR4s /eGguNpw2ptQB1cGoRddE58w52TCn3p45tGJ9+ggZAikcIjODG0v1gaftQ8FpmVbfIoHlf Ux8KD113N3T87GdnjJaD4dpZR2aKHcRwDhC6CQfdWCR8RoYZiIpw+3E1Zw1A57TjSyjvSL AWYnQX95ns26OkobKtA5FWQO3XL0bdp4snaILbKRIEKSBI4qL+VsboOnU7QCgLYDkmIAcx XS0LAzRezC7thvNf5dlY4StuTOAStjo2deVlIEpbojfOUsmMhj1Efzsiqx2lsCqWnTisuo gBCfBW0WlC0o4+Era0pj66QfvoHsjRqAT/B91CWgIrqoyWAub6xNfkJABnhF1GqNeY6DQa q46ktbNR3bTZD5R8WXUuECCAIbrSOwVGpwtZBeeld3n1v3rCjnFvnYE67Yxgm+g4SmBRQN EgvDQ3cE7wwk/tGrbrNdzJrWDsAwf0iq0o3tUeuMMxJ47Nxs2c6dN6tzWo+A X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 4 Aug 2026 19:57:01 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 Message-ID: References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-3-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TDtZEqwh2qedq+2U" Content-Disposition: inline In-Reply-To: <20260804174219.835096-3-frediano.ziglio@citrix.com> X-purgate-ID: tlsNG-ebf023/1785866227-C12DCB50-B438CBB6/0/0 X-purgate-type: clean X-purgate-size: 4831 --TDtZEqwh2qedq+2U Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 4 Aug 2026 19:57:01 +0200 From: Marek =?utf-8?B?PT91dGYtOD9RP01hcmN6eWtvd3NraS1HPUMzPUIzcmVja2k/PQ==?= To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 On Tue, Aug 04, 2026 at 06:42:18PM +0100, Frediano Ziglio wrote: > Make sure that save/restore continue to work. > The check save and restore twice to check for corrupted status. > Also a command is launched in the guest to make sure that the > machine is not crashed but working. >=20 > Signed-off-by: Frediano Ziglio > --- > automation/scripts/console.exp | 8 +++++ > automation/scripts/qemu-alpine-x86_64.sh | 40 ++++++++++++++++++++++-- > 2 files changed, 46 insertions(+), 2 deletions(-) >=20 > diff --git a/automation/scripts/console.exp b/automation/scripts/console.= exp > index e27886bbef..ff58ed29b8 100755 > --- a/automation/scripts/console.exp > +++ b/automation/scripts/console.exp > @@ -58,6 +58,14 @@ if {[info exists env(WAKEUP_CMD)]} { > system "$env(WAKEUP_CMD)" > } > =20 > +if {[info exists env(EXPECT_TEXTS)]} { > + set lines [split "$env(EXPECT_TEXTS)" "\n"] > + foreach {exp snd} $lines { > + expect -re "$exp" > + send "$snd\n" > + } > +} > + > if {[info exists env(LOG_MSG)]} { > expect { > -notransfer -re "$env(PASSED)" { > diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/script= s/qemu-alpine-x86_64.sh > index 60f5cc49fc..409a601c34 100755 > --- a/automation/scripts/qemu-alpine-x86_64.sh > +++ b/automation/scripts/qemu-alpine-x86_64.sh > @@ -48,6 +48,28 @@ xl -vvv create -c /root/domU.cfg > =20 > " > etc/local.d/xen.start > chmod +x etc/local.d/xen.start > + > +# Script to test save and restore. > +# It saves and restores domU domain twice to check if the domain was cor= rupted > +# during the first sequence. > +# At the end open the console to check if the domain is working. > +cat > root/save_restore_test << "EOF" > +#!/bin/sh > +set -ex > +xl list | grep -q domU > +rm -f save.dat > +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat /root/= domU.cfg > +xl restore /root/domU.cfg save.dat > +xl list | grep -q domU > +rm -f save.dat > +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat /root/= domU.cfg > +xl restore /root/domU.cfg save.dat > +xl list | grep -q domU > +rm -f save.dat > +xl console "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" > +EOF > +chmod +x root/save_restore_test > + > find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz > cd ../.. > =20 > @@ -70,9 +92,23 @@ export TEST_CMD=3D"qemu-system-x86_64 \ > -device virtio-net-pci,netdev=3Dn0 \ > -netdev user,id=3Dn0,tftp=3Dbinaries,bootfile=3D/pxelinux.0" > =20 > +# Sequence of expect/send strings: > +# 1. wait domain start and close console; > +# 2. wait login prompt and login as root > +# 3. wait login and launch save/restore test; > +# 4. wait restore from domain console and send a command. Why doing this interactively over serial, instead of adding to etc/local.d/xen.start and then printing test result at the end? > +gs=3D$'\x1d' > +export EXPECT_TEXTS=3D"BusyBox > +$gs $gs > +login: > +root > +login on > +/root/save_restore_test > +Restarting tasks > +dmesg | grep suspending | tr o 0" > + > export TEST_LOG=3D"smoke.serial" > export BOOT_MSG=3D"Latest ChangeSet: " > -export LOG_MSG=3D"Domain-0" > -export PASSED=3D"BusyBox" > +export PASSED=3D"suspending xenst0re" > =20 > ./automation/scripts/console.exp |& sed 's/\r\+$//' > --=20 > 2.43.0 >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --TDtZEqwh2qedq+2U Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmpyJ+0ACgkQ24/THMrX 1yy04Qf/fuaUVKZY9577YfoGDDwlo7DXrIjWgmukGdGCrtup38i8D6Mu4m0ME0s3 vTO/fPgEzFhH1D3Jeusu8CUA4XBoC3jcQl+4Sq6h9/ESP0qPS95o/jbQVnLA5wt7 qOSgHiaHxBgtkv7w6qFNqEANHuUk0L+8ARi6Yqr2ILhEwyK9Qu7bo+rCpkwVdgmp mFxyJknlRbmZVumbdEzKHk+C8GDrkZ4SvnQ50U5/xAhIkxu6PJ6uDg4Tv+oDB9tq 0ofwAFVf7NiNqkal8KfkdeiMUNGWD3eiB4kebncPueNSKVh/3GQjERb+XPIInCfF yMH/UVS0dsAPyFbl2JQrO/JKkzOzkQ== =qhiS -----END PGP SIGNATURE----- --TDtZEqwh2qedq+2U-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 18:00:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 18:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382541.1625890 (Exim 4.92) (envelope-from ) id 1wrJRB-0000Mc-Mp; Tue, 04 Aug 2026 18:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382541.1625890; Tue, 04 Aug 2026 18:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJRB-0000MV-Jf; Tue, 04 Aug 2026 18:00:25 +0000 Received: by outflank-mailman (input) for mailman id 1382541; Tue, 04 Aug 2026 18:00:23 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrJR9-0000MP-LW for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 18:00:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrJR8-009Xhk-Un for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 20:00:22 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7228a7-e002-0a2a0a5209dd-0a2a45089678-28 for ; Tue, 04 Aug 2026 20:00:22 +0200 Received: from [103.168.172.144] (helo=fout-a1-smtp.messagingengine.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7228b5-f659-0a2a45080019-67a8ac90a46b-3 for ; Tue, 04 Aug 2026 20:00:22 +0200 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id 05140EC0112; Tue, 4 Aug 2026 14:00:21 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Tue, 04 Aug 2026 14:00:21 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Aug 2026 14:00:19 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="CC:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="CC:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785866421; x=1785952821; bh=LDZ2h2Nlf2 cEyscx9QKZZfWGeO9IVpeAJYTIBjmBdSk=; b=U8B0xEmo3WYf0NSC7WpdFA5egr MMRDKsStHQ/i6/6csGQrbcsvIg0k5nXR3j5yKOH94VMhnau75lSx5HwbEMUwY72V CtS/M4su/sX6DFTgwBRLVIGBIHOCm1pvydlRPW7SGM3oKGTeaVi4rYT7nWK1+Ig3 G1WofNG8buKgAb640Qn4ALaTRuTAuVJ8REMHaSZDOQfaSH5FagD1PJcXLQ/nNA2V W6jMlgj74SA87tO3AGFZaDiCozR8frj/elKpm93gi21KfL5TmfdPPIZGOwHftqIc uv9e4pRugJeVh4GqCCyyg3BUoV3/4Dz3hUlwSw2UTRdq5kGBtTTbVYqqN0Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785866421; x= 1785952821; bh=LDZ2h2Nlf2cEyscx9QKZZfWGeO9IVpeAJYTIBjmBdSk=; b=D UdPhCg0Phe1INlR8RIRVJO+zzXoJhvYpNR1QImC53/SS4hIKbujmXIsDM6cgN9d7 R3mxMCqjOZwKvk1cRdpEMHR8ZqzbCd36Qwurv6zodpnqLnDd40oVabPhMCWnYFf+ bdBqjEnvbLSr3X8T5z5W3Hd0/Rmybnpd8UvVPbeWoGk5LdAtUao7E9DoV9Q6uuM2 dIPX1czvh9pE0iADXbYro5ouJg8od6lXh5uFOP9mHPsmfiqa36h5QpuibgcaXrq0 TTIypNDASinvzqOpc+OAXdn9K3f9yJkzw44upRVpF+/cwDD8z0zd4LlO2S3tZFBK 5tY4bpwIzsv/OLSikmcog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEy9dbI7dVgmVyTaT5KMPh+I6ZGxOK3AUQTOQS2bIRY0xfX1eIAwzd/CZk9yFoRlO Cri2v3V/i1GamfTXF4Mv4XHmUAbgnxwc4BXyQwC+UslzHDz4plo3+nm5ZbJWSR77uA6e+x QyOrouw+nm3LsJ+gQ5m2R52NJQCw0vHielvFIhC0lcoQkpiZiVsdAClDG5dL9VTXt+eAQC A4lzSc/D45tR8Y5H4pkl73rK6mn6+0ks95z5yk8ssNzEj5Q9q1VvJ+Qj1rzNmhNgFMWZeA bKBgaopxeX7O0UrCTf+EADrwtUUR9rjHRxyOIxSMNJ3cL4NkVvRtnLa7Mq4BTBQW4oN2eB qqW38IwlcUBx5GF+YZWX1RbS5iQ/h8ZNKLGQb7/vrG07VpH2pTe2xy06c24FxiwGby2sV/ xC9w0VW5qbbHSDDbo7bo7YIVWGgAhmKzjF9lD94oHrideo3ETE/xX5Ie9YjeOCcGGpYVHJ c11oUYpOE9nhCh/bt2kEIVcQaSq41dALy0f1JXwxTvChd2DIgCDYNRm0JwkjVzOTYfldG5 g1cfdyZWsKiUhgzUM19WGn63AiyfwnckMcz6qx+ujUd2gdEEkV7avQoH+UU5k86T3ZcoNH ufBriIRzVnJoofkGLl0+IqtrjH2vv2Yo9OQj1IviIly5yokoSmGI26w8tZfw X-ME-Proxy: Feedback-ID: i001e48d0:Fastmail Date: Tue, 04 Aug 2026 15:00:13 -0300 From: Val Packett To: Mark Brown , Juergen Gross , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Xen Devel CC: Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the xen-tip tree User-Agent: Thunderbird for Android In-Reply-To: References: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c1860d/1785866422-D514E87B-CA75770F/0/0 X-purgate-type: clean X-purgate-size: 709 El 4 de agosto de 2026 1:28:36=E2=80=AFp=2E=C2=A0m=2E ART, Mark Brown escribi=C3=B3: >Hi all, > >After merging the xen-tip tree, today's linux-next build (x86_64 >allmodconfig) failed like this: > >ERROR: modpost: "init_mm" [drivers/xen/xen-privcmd=2Eko] undefined! > >Caused by commit > > 64d26fb2ad1f2 (xen: privcmd: fix ioeventfd crash under PV domain) > >I have used the tree from next-20260803 instead=2E Sorry for the trouble! Did not expect that to get applied so quickly=2E=2E= I had noticed recently in my own testing that that patch wasn't actually r= eady to go in due to the symbol visibility issue, right=2E I'll work on res= olving it=2E ~val From xen-devel-bounces@lists.xenproject.org Tue Aug 04 18:48:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 18:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382557.1625909 (Exim 4.92) (envelope-from ) id 1wrKBe-0006Qi-61; Tue, 04 Aug 2026 18:48:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382557.1625909; Tue, 04 Aug 2026 18:48:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKBe-0006Qb-2n; Tue, 04 Aug 2026 18:48:26 +0000 Received: by outflank-mailman (input) for mailman id 1382557; Tue, 04 Aug 2026 18:48:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKBd-0006QU-6k for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 18:48:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrKBc-00282X-JZ for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 20:48:24 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7233db-2eae-0a2a0a5409dd-0a2a4503b71e-30 for ; Tue, 04 Aug 2026 20:48:24 +0200 Received: from [209.85.128.179] (helo=mail-yw1-f179.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7233f7-fae8-0a2a45030019-d15580b3d0e9-3 for ; Tue, 04 Aug 2026 20:48:24 +0200 Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-81f36179d72so2831187b3.2 for ; Tue, 04 Aug 2026 11:48:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1785869303; cv=none; d=google.com; s=arc-20260327; b=hrB4v5JwrlR1c80ACP0mDU4F2i+vYhy9zmseELS6dFRLXGu5e9NERT6alZDeMut/bq 4/Pm2mVwADRaAwFfhoSFFiGkz1GbZQot0CtJWmiv168ZC4cHicvJRk8irO9tRfOdlhn4 X65T8Xd04VNkOkkF/OOAa/MUM/uIivaLkdnSvZr7gmmuOU3IG2pgWQH6lJnf8ABBdlYj wRoyMX3VWccLySAVn5oInhYimQ/mP80ibWg11PO1yavWOpr0LluBvfiCUStX9poZLLo7 UYYQiI8NiVWTrDy7inh4ObKhMQtx5lkt/VhWD7eKC00gjohEbyYnLeiOav71cmhLBUIj 4Bgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=7hHb7A/iv/3NbWaHGGYKFA8iWxf7Etm7iPDj2vr104Y=; fh=RLhUWlRjq6yfpKY+h1JZzBpOTuG/g/EB3etsFhEdDDk=; b=IEF0C5x9/Zz10gdP3AGbNue2dEXxOvNVI0CWxFy95hwG0xhgfyCku3fN0lwg0GxN9v QHgPcy827tpvkPC9mSTZnV7iYCFO1tjm07FSfZJlPzivdg9oHbuTqInMzTRzr7V/JbGG DqCboeKso0bYnxh9z7RRzu2kkye4eCA1iekK+kxuTDjofgcM+hAh5obewWCVtPmD4Rnb 4u8cBMQdIsDA5pFH0GRjYtYBQzgMqFvkof4grsXqWlkPaq7wLUlq9ODShUiRxuhuSjeg 23SF/epheUqTV7qqsOXbOAndN5HtN3pD0V/Kh1LgN1pztD/dAJ42cCJZoqKdUiSTPItT 0uGg==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785869303; x=1786474103; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7hHb7A/iv/3NbWaHGGYKFA8iWxf7Etm7iPDj2vr104Y=; b=kunGUCAKyZS+QhtUN9mIrCYPDBvTVS6nmHFOPrp/pYqWJ6+EXys5Sn5JIiTmFA1+wo DVJfk0sFswyd+XSneXSrm+HFNgYo1r7RJnVN8hw34VTRqO4XDP1iBdY5snI9ZxGHMKy6 6PV5QDTAdIr61JRZYem/Ym0dCYEfHxeRaoIlCD1gZ6OGegxBVRSqC7GQw0i0IvR2qfKn uE0ZLhaMm5a4QdXBKU5xHH/XtvyfJC0EG678iZBqLoCALhXXvIko533wfif8T+vrRJNa /KvQHYAtdPvR+zGDDhF2N4S/iLtjmQ2FZPZnaHmfkkVuaZHYAfg95u+yee/TwcbUZxRo wHYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785869303; x=1786474103; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7hHb7A/iv/3NbWaHGGYKFA8iWxf7Etm7iPDj2vr104Y=; b=gaStgkDCYseoJJk9i7Ofh+ASriWFVI+b2xzFSnmP7Zab+NNCYwSRucrbS3fpXTUZCo eX4AxRBCqsi/P602o8eBPmwtuBOZbpcr8sG8GQLbG03MH+EbNyjDzDM+VKu9xv4/7dVe f0hkLirsDyADC4RYvHSwDNVjkaZykmA3+/Zo0bwenIcQsRByP+ShyE1Rdj70D+bH3OTZ ltY8gx/+JbJseC7CcASeuv0OZomqGO7YUhHuPHPzInYxo2WLs6xJUXEEYLWGVcNXtS8z AoJBMBYJsMkPxLauHSTRCeeblQxE0n+itxykp2zHYfkdlyFCpj8kBrA138/P27LqT8EY n4TA== X-Gm-Message-State: AOJu0Yx6J6xmWy4FwyYn3PTOMj+JRk55/T3NGgdYCRJDCmyIn4SaWPtv j/XyYqtJltACQgGqldPGfXxlDM8rP2YtZUyLf2C2PC3uQKmX8lEpzvfN0b6ShO16IgAc/lwA1+m /MuujbwvfjNd5+idwSqzkfBqRtZa/EOo= X-Gm-Gg: AR+sD10JhUZH2/CJRz1MgZHrxxaY3NIEwYxONXx168cbW7wNkcD92YYgUF56Ts+iztI upMgl/Dt3QalhYHoCacaZdbtQG2GAjyMs78WkFEPgrw19etC3ncyu3ow91gl0xq08PoCZXv8mGk cC1eW/3T2l/IZEL/mjFkniNpKWUMvaedAC9Oko6R6dEavyKQ5QhpIrmxSXK6OsHNhdwpoUze1f0 ChWZz/SnC+H1yxdfmekmrPqm/Hg23/pNXy/aDdt8mZea0sV6aocY7HHaCozwaxX+7X9jaqNVG4e PiQpO8ssxpHApFt6MI+xQJ7qeOt7TzxHqy59aMnUbJYQ+w37TOsBpY5xia9ZeGqQ673QBJ+q+C7 V X-Received: by 2002:a05:690c:c4e9:b0:81e:9b09:7263 with SMTP id 00721157ae682-820222bbbf6mr4493457b3.10.1785869302838; Tue, 04 Aug 2026 11:48:22 -0700 (PDT) MIME-Version: 1.0 References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-3-frediano.ziglio@citrix.com> In-Reply-To: From: Frediano Ziglio Date: Tue, 4 Aug 2026 19:48:10 +0100 X-Gm-Features: AUfX_mxZCKZPTK0G0XIsRbFiVIkMddiIg6XauhFcmZwsjjLI9vmE9jxSgwKs0lI Message-ID: Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1785869304-6FCC34E9-9D2B3B38/0/0 X-purgate-type: clean X-purgate-size: 4071 On Tue, 4 Aug 2026 at 18:57, Marek Marczykowski-G=C3=B3recki wrote: > > On Tue, Aug 04, 2026 at 06:42:18PM +0100, Frediano Ziglio wrote: > > Make sure that save/restore continue to work. > > The check save and restore twice to check for corrupted status. > > Also a command is launched in the guest to make sure that the > > machine is not crashed but working. > > > > Signed-off-by: Frediano Ziglio > > --- > > automation/scripts/console.exp | 8 +++++ > > automation/scripts/qemu-alpine-x86_64.sh | 40 ++++++++++++++++++++++-- > > 2 files changed, 46 insertions(+), 2 deletions(-) > > > > diff --git a/automation/scripts/console.exp b/automation/scripts/consol= e.exp > > index e27886bbef..ff58ed29b8 100755 > > --- a/automation/scripts/console.exp > > +++ b/automation/scripts/console.exp > > @@ -58,6 +58,14 @@ if {[info exists env(WAKEUP_CMD)]} { > > system "$env(WAKEUP_CMD)" > > } > > > > +if {[info exists env(EXPECT_TEXTS)]} { > > + set lines [split "$env(EXPECT_TEXTS)" "\n"] > > + foreach {exp snd} $lines { > > + expect -re "$exp" > > + send "$snd\n" > > + } > > +} > > + > > if {[info exists env(LOG_MSG)]} { > > expect { > > -notransfer -re "$env(PASSED)" { > > diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scri= pts/qemu-alpine-x86_64.sh > > index 60f5cc49fc..409a601c34 100755 > > --- a/automation/scripts/qemu-alpine-x86_64.sh > > +++ b/automation/scripts/qemu-alpine-x86_64.sh > > @@ -48,6 +48,28 @@ xl -vvv create -c /root/domU.cfg > > > > " > etc/local.d/xen.start > > chmod +x etc/local.d/xen.start > > + > > +# Script to test save and restore. > > +# It saves and restores domU domain twice to check if the domain was c= orrupted > > +# during the first sequence. > > +# At the end open the console to check if the domain is working. > > +cat > root/save_restore_test << "EOF" > > +#!/bin/sh > > +set -ex > > +xl list | grep -q domU > > +rm -f save.dat > > +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat /roo= t/domU.cfg > > +xl restore /root/domU.cfg save.dat > > +xl list | grep -q domU > > +rm -f save.dat > > +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat /roo= t/domU.cfg > > +xl restore /root/domU.cfg save.dat > > +xl list | grep -q domU > > +rm -f save.dat > > +xl console "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" > > +EOF > > +chmod +x root/save_restore_test > > + > > find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz > > cd ../.. > > > > @@ -70,9 +92,23 @@ export TEST_CMD=3D"qemu-system-x86_64 \ > > -device virtio-net-pci,netdev=3Dn0 \ > > -netdev user,id=3Dn0,tftp=3Dbinaries,bootfile=3D/pxelinux.0" > > > > +# Sequence of expect/send strings: > > +# 1. wait domain start and close console; > > +# 2. wait login prompt and login as root > > +# 3. wait login and launch save/restore test; > > +# 4. wait restore from domain console and send a command. > > Why doing this interactively over serial, instead of adding to > etc/local.d/xen.start and then printing test result at the end? > I'm using expect to interact with the console. expect is not available inside the alpine root filesystem. Some failure I had during migration is that the VM crashed. In the script I interact with the console to check that the VM is still able to run commands. > > +gs=3D$'\x1d' > > +export EXPECT_TEXTS=3D"BusyBox > > +$gs $gs > > +login: > > +root > > +login on > > +/root/save_restore_test > > +Restarting tasks > > +dmesg | grep suspending | tr o 0" > > + > > export TEST_LOG=3D"smoke.serial" > > export BOOT_MSG=3D"Latest ChangeSet: " > > -export LOG_MSG=3D"Domain-0" > > -export PASSED=3D"BusyBox" > > +export PASSED=3D"suspending xenst0re" > > > > ./automation/scripts/console.exp |& sed 's/\r\+$//' > > -- > > 2.43.0 > > > > -- > Best Regards, > Marek Marczykowski-G=C3=B3recki > Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Aug 04 18:55:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 18:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382571.1625919 (Exim 4.92) (envelope-from ) id 1wrKIa-00085s-0B; Tue, 04 Aug 2026 18:55:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382571.1625919; Tue, 04 Aug 2026 18:55:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKIZ-00085l-Tb; Tue, 04 Aug 2026 18:55:35 +0000 Received: by outflank-mailman (input) for mailman id 1382571; Tue, 04 Aug 2026 18:55:35 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKIY-00085f-NK for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 18:55:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrKIX-007HgV-KH for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 20:55:33 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7235a4-bab6-0a2a0a5309dd-0a2a4503eab0-2 for ; Tue, 04 Aug 2026 20:55:33 +0200 Received: from [40.107.208.45] (helo=PH0PR06CU001.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7235a3-fae8-0a2a45030019-286bd02d5678-3 for ; Tue, 04 Aug 2026 20:55:33 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by BY1PR03MB7995.namprd03.prod.outlook.com (2603:10b6:a03:5b5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 18:55:27 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Tue, 4 Aug 2026 18:55:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w3tnGWvshcEid+ytbQ85X9gaHqFCrebfv4y3opcmBCyI8jgO6b2jYx5QK6nEC89P0n60+nMRKgHDT12coPNp/ggexLjdLJgyJnNaswjmjebkDoixJSbXrFyC0QXePIxVKvP0rsSgk6Fpdtjj0jXYxRTnlaZEKelR2CByCFMfTkbrP/wD+5f8OGQAtA/6w0OtoYBpBNiv2vjM/dhSdFSzKVjuHpJ+xPiuZzICpS8OHPRgCIrC6gN25fqfx3H/ZHCb49GAoNjNsZLJbLRNmHq3sJEPM7Ipy8st/sGGVCnr52uOzPAgn4FM6wRNwyUCZQee9UvSZtfUxu2mlFowKj1Byw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LHMDwvv46rBKThaqSqCUdebu9WeFZbWgaZ2tLVoLzwA=; b=Aq5a7+PewbMth6871HBPSc4V0HyrWU5AdPTQaQZUZQ2UWx0wINRIuXSZq8CDCR5PnOPjKJQ1EPWazNsNz3Yb4hoFtKau1quTzGQfJWRdAA7a46xqVWGiXhRYqmgpDpo1lk+/hheHdgWaPAe2hURykMK+6JV7dP/WX1Pqu4B55j//x/hktWDqR1Cs2zctKWVb10NeJZAu7LDaNmnAcsvT+HBBKW8SBUfrR8I9euOe8PFwPSDKB2vBNTrXTbssk6nIBjK3j3kTrR5pYsIDqqZCWbDxOMBIapSoEOIlOUZ8NoTq8S75US5YhkOneuSwMuBKJaflwNHUM+tbbaYFaJk4lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LHMDwvv46rBKThaqSqCUdebu9WeFZbWgaZ2tLVoLzwA=; b=VbqoHKec+aRXDPyPtUhyVpFhdrkq/6Y1PKITc7G+Qw2HhsnKJGKtLwbCe4eSqjsoVX9rBMINYWPg2Mg/aWipch9ffEOzg/xhRXZGL9PMBidcsrI29VkkbWCtOoO8AyDWTW0jrdPDoSQcWAK8OXDHXJE4M8gmb2Jzi3pXnMkv0Ys= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <9dc1d91c-52e2-4cd9-a234-6d6ca6ecceb8@citrix.com> Date: Tue, 4 Aug 2026 19:55:24 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 To: Frediano Ziglio , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-3-frediano.ziglio@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0080.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::13) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|BY1PR03MB7995:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e90e035-2a8f-4b54-96b2-08def259f28d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|366016|1800799024|10067099003|11063799006|4143699003|56012099006|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: 2d3jkuSSTnxtuym8yOyTGKhGiwR8/uP8JwQ2QQcDJT9v6zWoamsZPrY7yaPsS/snij9W2pvGtjQbL9qeSoLCjnO3yFCDx1nVmgg7wv3EfnmPqKye4eHd8+QwGz7YEVCKOpee/06WJ4adcetwnyAyvmeNO9h53gmDhVNb6R20bHk3yTJ8ZkmMIO+2YtAqyZ8VDtTrdGdDA8bbgjWpp6efkGpXposXXb+QvbVxk5b8YzrcoaJgVxEI2egwcKEInyt+2yDkarWp79xsBTwWrDOtnNcGEitbNCsC0drMnVtxhHrFcFzPT9eVyFWjwav3hoMjxGPQ9LxnTimCUWh/VGSwkaILAmm4G5+uduFie1HaRO/WxGCpnbHx21pDpTcLhxt0NzJdXzLignE3ClXzuJRXrbIkk50J8f4jwqhCxr7dVIbhm8V/nxxJX32HMQFyDMDDOKoN1OuoQHwA8eUY462gCuyat2bxhgxbvUTSQ3mrW33wF3rcwH41eD9r4F8urN2eGQdNiUUwvl2pI+HC1EpaNtG6v0PBqDzWTZANdhnj3k65+ME/dIvLu6Pk0lDrqvbFA9OR/zxdZjiL9y580kMthRlk1updcDX0gRZXmgMoXAp27WQXOa1X2J/q4zuH1yNxbqV0/gOSVo5hwulSJh8D1C/U9xAcJWkugGhw9Fz+0IY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(10067099003)(11063799006)(4143699003)(56012099006)(18002099003)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWxuR0hZQk1UZHBHem5odXVEWEdpajA4a3gxUll1WFo0Mzk5V1d5bXl0bEZE?= =?utf-8?B?SHdQMWlPakE5aExGeDlkTjRKcDdaaHkzRXpGNGJXdXZFRHN3SWpHb2REaGtS?= =?utf-8?B?MWQyV1ljajBmR2hCQkxGeTQwK29VU1hyZGVaSnVWMm9QWXpKQ1c2MmxVMXJp?= =?utf-8?B?bTkzaVlNYVUxcXlnak42T1B5YXEvbU9yV1dkcmVLeVo0NCtMcFRhWVlRN0xV?= =?utf-8?B?c3MrRWNZWG0wRWFvTkJ1U0FGaVJ6UFozVjZWdUFmdE1NdkNoU2hrSkxramdL?= =?utf-8?B?RzRFUHNyQWxYUTlqRVkwMUdRZ0taa21PYVdCS0U5VHB6ZnlINkNSd0RHNUVR?= =?utf-8?B?NW5KVDVzVStBeTR6TWtvWFgrTGZwVGtvTUZ3NnFqYVA2Rmxqdk5wMWNTTndF?= =?utf-8?B?UzFxeEk5TGgxNE5hTkxUcEtZU1ZNT1J3NmhQcTNSbWlQYUtrK0VhSzhrd1BB?= =?utf-8?B?RnhCMXJ3eEJCakV4MkZxeVVrWCswWUhuOUx2SWZObFFLcGpZQ29sOWZ2aEho?= =?utf-8?B?WlMvcGcxTTcyUXNVOHV6ZDJGYzV3ZXRmTlZBc1R3a0N3Z0JYbDdGck9tZTg5?= =?utf-8?B?RzZ4aFFTdGFXY1I0K3FWbEVzTzk1S2tWVTlyd3Mzd0w5SWNOV1liYmE2akFL?= =?utf-8?B?bk1ZU2pjVW9nd1lxbFFIMEVjRC9uQXJTQUc0V1lnS1BDNXkvdWt1NGMyZVNI?= =?utf-8?B?NFgwWFlIVXpxSVVOaW5LTE55WG51NXRuSm54Yms5Y2dkUVJZSUxWNzR0SzMy?= =?utf-8?B?bW8zeUsyQ3EyTktwZFJOeEUwU1AxYmVNY0pkU0lkTlFaczZJODU5TDVsSzRs?= =?utf-8?B?VTl2OHpaaVBMQ1p2VzdBR2hjM2dNMlp4OGtQaGtRR0Fob2J2ZitQbVU2M0VW?= =?utf-8?B?VWVCbnVMM3RjdEQzaWZOTm10KytHVVBudEt2dldKTXJqajVWYUR4MEwxWjQ4?= =?utf-8?B?aFp6NEE0c0FRMXA5dm02M01PTHBhSTRqTzVzeGd2M3VIMjEyUUE0b2hkdEE2?= =?utf-8?B?UDVOU2s5NXM0dXpjZ2txZmRLWWF0UDNBWXV1L1NTTjdHQUw4OW9oL3E0bzN2?= =?utf-8?B?TDM5UFNrZkpqY2RZUjArSktHZnI4MTFjVUdLd1BKRU5kdk15QTgxM0JaVmVw?= =?utf-8?B?NmYxRmVkZWxGbkQvSWdPNnh1cTRFYUxrU0taQUR1UjRPVVdCK0pTMy9IZ0gv?= =?utf-8?B?c1NOLzk0YWpSUnVQdHViOHFWM2IzNThkWE1CQVFoY3hyckF0bXBQN3dwNXVi?= =?utf-8?B?UnBWUXlLSzVDMCszRmpqV1lRMHVSOU1jZENTSmRDenB4K3c1MnRLM1NNV2x6?= =?utf-8?B?WjRSTldMblRsT2hoNzFYcEhkZHZ4UmRKRS85aC9GRVk2bUdmQ0RtTjF1aHNi?= =?utf-8?B?TEFkSW1FcCtTL0UxbW5iOW1GWm5nTGRYMERFVHJSNUhzWUJZS1lnY1N0STc2?= =?utf-8?B?S1ZXK1NIRThNdHEySGpwdk40TFJGVHYrMXh4YjVKUTRteHV3ZVBUclZQMCtk?= =?utf-8?B?UjJoUiszbllBK0dDdGJGaFZWNmNyREp6Y2MrRExTelplZVJWcHpBRVRnTEFK?= =?utf-8?B?L1BDWHlBOFlYUVEvRXhmVWhtNHhmYlIxcWoveUxVbXJLMi9aQ2I5K2ozaVRZ?= =?utf-8?B?WDluck4yQTlTbUNlRFZ6ZEVxZWtERS9JTUVWQ3lTZ1FxMW9NdDJRZ2gyM21a?= =?utf-8?B?T0ozVDc5Vkw4UFJOb3NiWWxHM29Db0dPSVlxUEtSNkE4Tm1pT2pVb3NtcUFz?= =?utf-8?B?QzE5em1GVFphOHBoUENyT1RwVlg2bndRVUt0dGdBd2JCUmUvY24rQmpoQkNT?= =?utf-8?B?K3c3K3VhUzN1VW9wUkZMb2tNYlVyTUZuR09pNUJINUhRU3RyRGI2Wjg4alI5?= =?utf-8?B?dzhXTnh4YUFhU2hndDRNTFpjVDVUbUI2Y1ZzZEVRcVZROXkybStHQUMrMjdE?= =?utf-8?B?eUlrOTNoR3FDaXZXeVpCNE1ZTStLU2puNGU1c2FSTzRPYURVOXFoMmpjSTE1?= =?utf-8?B?SzFmczBQZi9tQjU5UVAvdGdGdnpGNXZtd2xIN1NlVit3SmpPTTRidW9EcFJn?= =?utf-8?B?RmdjR1lkcFJxRU9NV2k0MHBFUWxVUTgzd2Vza3NvU3VjMmJON3pzaDNMaS8x?= =?utf-8?B?dUcwZ0RkMTFxSUkrcFVyUDBFaGhIQmlZaXlDM2Y4NXRFWFQ1aXJ6WklscGhZ?= =?utf-8?B?WVBPYkhpc0ZWVlhWcFg3TnRIbmZKN292cDN3TGxWeDRISnpTa3lySGQ4cFBX?= =?utf-8?B?d0VzNGdqWW9aY3JZR2RkcXl2YnN0dGwrV1JZR2RvTFZKTG1TQWVBMU5VTjla?= =?utf-8?B?T01aaU5UelRvT0hlVmlaK2dISHZPTFRQMVN5VjVwUU9MeGZaVDd2QT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e90e035-2a8f-4b54-96b2-08def259f28d X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 18:55:26.9931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pE1s3349156D1QcXMj4OXAQiych3b69FZkindCdiL5S+3EC6jNIIK/DQOAgRtJbtgkG7Yy9VC1sB3Av+/MJ54DzsV1k4xOq3G2cFGe6v2cQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB7995 X-purgate-ID: tlsNG-33051d/1785869733-76CF84E9-BF4B4530/0/0 X-purgate-type: clean X-purgate-size: 3987 On 04/08/2026 7:48 pm, Frediano Ziglio wrote: > On Tue, 4 Aug 2026 at 18:57, Marek Marczykowski-Górecki > wrote: >> On Tue, Aug 04, 2026 at 06:42:18PM +0100, Frediano Ziglio wrote: >>> Make sure that save/restore continue to work. >>> The check save and restore twice to check for corrupted status. >>> Also a command is launched in the guest to make sure that the >>> machine is not crashed but working. >>> >>> Signed-off-by: Frediano Ziglio >>> --- >>> automation/scripts/console.exp | 8 +++++ >>> automation/scripts/qemu-alpine-x86_64.sh | 40 ++++++++++++++++++++++-- >>> 2 files changed, 46 insertions(+), 2 deletions(-) >>> >>> diff --git a/automation/scripts/console.exp b/automation/scripts/console.exp >>> index e27886bbef..ff58ed29b8 100755 >>> --- a/automation/scripts/console.exp >>> +++ b/automation/scripts/console.exp >>> @@ -58,6 +58,14 @@ if {[info exists env(WAKEUP_CMD)]} { >>> system "$env(WAKEUP_CMD)" >>> } >>> >>> +if {[info exists env(EXPECT_TEXTS)]} { >>> + set lines [split "$env(EXPECT_TEXTS)" "\n"] >>> + foreach {exp snd} $lines { >>> + expect -re "$exp" >>> + send "$snd\n" >>> + } >>> +} >>> + >>> if {[info exists env(LOG_MSG)]} { >>> expect { >>> -notransfer -re "$env(PASSED)" { >>> diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh >>> index 60f5cc49fc..409a601c34 100755 >>> --- a/automation/scripts/qemu-alpine-x86_64.sh >>> +++ b/automation/scripts/qemu-alpine-x86_64.sh >>> @@ -48,6 +48,28 @@ xl -vvv create -c /root/domU.cfg >>> >>> " > etc/local.d/xen.start >>> chmod +x etc/local.d/xen.start >>> + >>> +# Script to test save and restore. >>> +# It saves and restores domU domain twice to check if the domain was corrupted >>> +# during the first sequence. >>> +# At the end open the console to check if the domain is working. >>> +cat > root/save_restore_test << "EOF" >>> +#!/bin/sh >>> +set -ex >>> +xl list | grep -q domU >>> +rm -f save.dat >>> +xl save "$(xl list | awk '$1=="domU" { print $2 }')" save.dat /root/domU.cfg >>> +xl restore /root/domU.cfg save.dat >>> +xl list | grep -q domU >>> +rm -f save.dat >>> +xl save "$(xl list | awk '$1=="domU" { print $2 }')" save.dat /root/domU.cfg >>> +xl restore /root/domU.cfg save.dat >>> +xl list | grep -q domU >>> +rm -f save.dat >>> +xl console "$(xl list | awk '$1=="domU" { print $2 }')" >>> +EOF >>> +chmod +x root/save_restore_test >>> + >>> find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz >>> cd ../.. >>> >>> @@ -70,9 +92,23 @@ export TEST_CMD="qemu-system-x86_64 \ >>> -device virtio-net-pci,netdev=n0 \ >>> -netdev user,id=n0,tftp=binaries,bootfile=/pxelinux.0" >>> >>> +# Sequence of expect/send strings: >>> +# 1. wait domain start and close console; >>> +# 2. wait login prompt and login as root >>> +# 3. wait login and launch save/restore test; >>> +# 4. wait restore from domain console and send a command. >> Why doing this interactively over serial, instead of adding to >> etc/local.d/xen.start and then printing test result at the end? >> > I'm using expect to interact with the console. expect is not available > inside the alpine root filesystem. > Some failure I had during migration is that the VM crashed. In the > script I interact with the console to check that the VM is still able > to run commands. We can add `expect` to the dom0 root filesystem if we find a need for it, and it looks like this might be a good enough reason.  You want a patch to https://gitlab.com/xen-project/hardware/test-artifacts images/alpine/*-x86_64-base.dockerfile to get it included. But, for migration testing, this really wants to run on the real hardware.  Besides the main memory image, there's variations in register state and validity which will vary between hardware. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 18:57:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 18:57:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382578.1625927 (Exim 4.92) (envelope-from ) id 1wrKJw-0000DG-A3; Tue, 04 Aug 2026 18:57:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382578.1625927; Tue, 04 Aug 2026 18:57:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKJw-0000D9-74; Tue, 04 Aug 2026 18:57:00 +0000 Received: by outflank-mailman (input) for mailman id 1382578; Tue, 04 Aug 2026 18:56:58 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKJu-0000D1-Fy for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 18:56:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrKJt-007Hpb-TJ for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 20:56:57 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7235f7-bab6-0a2a0a5309dd-0a2a4503c0de-2 for ; Tue, 04 Aug 2026 20:56:57 +0200 Received: from [52.101.201.32] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7235f8-fae8-0a2a45030019-3465c920e498-3 for ; Tue, 04 Aug 2026 20:56:57 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by SJ0PR03MB5744.namprd03.prod.outlook.com (2603:10b6:a03:2df::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Tue, 4 Aug 2026 18:56:54 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Tue, 4 Aug 2026 18:56:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dZ4zYWrsN8oWBYgoAXI/nKbyFSxWnRUWjohv4CK7Azh4161lnCyI/GgQzhAnH6ImBbcDQyYBjAXPOAYW0Zkgkt8VH0odFDedL2+nMIZylShVf8h+eZsWsIDRSnmjtr9EGSxGiJfCBcNVKZC0dc8KzoUz4fNturTK/koK7/68DRlcUFQATJYqy1gICJmpuIcEG7r0emojqxkaGTViLu+s72Pa+Rq2VKeJ4fEX6d1ow7US/ih1Qpzm1tqV3o3HkDL9iPMR+SSJDXtUlubxvQThJ0g+lVI5NhNMIoJm0wLqHMuP8/1FsSWavJgPHcgJguA3+Y7DGhjvh4YWa9uN+MZwbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1w149KaIoZYVexb5ZFISq+2+xbDLHCF6EYoXbL5OQfo=; b=hgNFCYDgDm87wr2soKnPoiGb7mje4DZhBbnWqUhFL1+utAyGU8Lt0aUys2x9/gJZbIJfbr87aQvKp5MIo3LQ/ZPA9XZwlj07M5l3EbV4OKtUsUejt9XH47bYuZPFuBqOPkzgC1hzBTjoTdPNPV3Z39h19mDMsuuRxrSmwVWGAQjGJhGDTl9R8oCJGrozNZ2zp3DRXzIpJmcUMzVK83HJiC1HD9N5sxZan+TF/3Gn0rc6+/nyJZHFXzEfpoN9sdwCOiXwNcAYnGOafW2vRe2GgeDgr5zoceJlLFMYreEI5FBc51drjTPtISjGEMCnDwKWU95vUquvSF1xVUPTxrGkdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1w149KaIoZYVexb5ZFISq+2+xbDLHCF6EYoXbL5OQfo=; b=WPFyTRVB2q89x6G/gG2rRdUMnuizp4PFgw8sZs/VU+8h5iq4PsXK7OB6YTIqprZ1ypAtjBbzBXQUrzd2w9rSKgWsExjZRZMNpD7DGd5dr/tlUJK57O/KYOzK5BN32Gv9ttAqh8Ztvi2SlTXEowMv4gtx4YbgoxH8d0l8KYL3sPE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1e1a1c4d-5ffc-44b1-b26c-244c9af1f250@citrix.com> Date: Tue, 4 Aug 2026 19:56:50 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Xen-devel Subject: Re: [PATCH v3 1/5] x86/emul: Introduce x86_decode_lite() To: Jan Beulich References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-2-andrew.cooper3@citrix.com> <01b27228-fdc0-4546-aa23-2bcdafb22727@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <01b27228-fdc0-4546-aa23-2bcdafb22727@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0076.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::9) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|SJ0PR03MB5744:EE_ X-MS-Office365-Filtering-Correlation-Id: f3188295-7335-4f44-c169-08def25a267a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|23010399003|11063799006|10067099003|4143699003|56012099006|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 0Wx8Yrry1XeYdH6+UBKnATy523sKY/cOcQOSWSSiuAI+YZKqGmtZUZiKAWGGOxusV6+YFD8k5orfl1ZCeR5LycwXOu8KszZgFyvuSd3+T6XzqetVAIcRn9M+vROELfAdBidhFxqf0GnApojKmvVsuDhL4eElLooH7wr+uDwiwgmkCNkXefEgKhcuVS3nI6a2VqoEM3MbxFPR39/C1n5UsmZMTKo+BPzTZSTAjxj4HviPwK4D/GYGMllxb9FyPVqhcUbXCqsfbXwZrxRBqZ/TBAdGRoTf4JUB+aBSWQd18lsHjJx27Lb6CqqbT8Pd/4gknNVLfaBVXekR/vcjffresJ3aY7P+SxK/eMkL4dW/AZwBfi0BnuQn1VQBOgoEiH7AnCG/8/B70hpJAsIrSxmZefuOtAwsqciIi0JsTZjKyOcpiALnTZTsGtbQt+PXwJUVehRei6KCtukJ7LOyJbJjD1KODGiqm5FYGJR9Vs7mtC4sMaABhYD5t0gI9sUkzilkWUMI2isJBEaoSehb6utloTxCyFbv/p75T3Lq4ZPzucMoNt2qXCzDmfqxleH8auEHs5tkTFs7t0H1Y58UqPRjiOfat/dic+UEQp5J7mBeVL0Swb/25PSJHx6McCKeJa8FRFRB9ikjVpNUDEouoEz+o4PAKOiEGskfMoFN6C9PwDs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(11063799006)(10067099003)(4143699003)(56012099006)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3o1REk1OU9wS1ZUZ2FmeVgvU3lnZGExT1NVR2oybnArR1RlcVIwd2lkdzhL?= =?utf-8?B?OFRVWUNwSGh4MnBKL2U0UjB0UkZ6djEyM0NYZmlXTEVqTUEySjNhRWNKUEdi?= =?utf-8?B?YmVFN2hJd0pmT0lkMW5aUE9MbkN5eTl0Zk5JcHdTM2JGQnVXaXYzK2ZRcm83?= =?utf-8?B?cHY2N29jdU1SbE1tNDhwV0tiUU1NNHFlaDZtS3BnQ2xWRm1mT2lVTnFRbTJj?= =?utf-8?B?ODFCL2lCZWhBTmZQaFp0TjdMWkRaMjczWlVJOUordzMwa3JwYzN0R0s0dnZZ?= =?utf-8?B?YXBQOU52ZGVXRTRwaGFIVjhQSk9PTkc5aHdXaGJGR2NTSGFTY2tFT1hsTFkw?= =?utf-8?B?SEtvcGFRWFhKcmF5ai80RmtzaW9VenpBbGRiYXZWTnQ0U0xYK092anNvWmh0?= =?utf-8?B?bUNFeUYxMXBaQ3ZWS2VlUmNMRHpIbDUvaUdiMVVYeE9WWS9QYld6ZjQrMTU2?= =?utf-8?B?dCtJQnI2ZUFxVWloN2tlSitNMGU4SWFlYzhva0lzZTZuRy91MC9RK0RiZjlj?= =?utf-8?B?ZzBHbUM0UEgzNURHQ21MaWNkWVdXaHlqSkJ6KzRJQVBTdUFtNGkyZTBRK01L?= =?utf-8?B?NmtPTEhxdzYwYXJGTUxmV2QxblR6cG9Wa0xLbmNDWGxJM1RLeFFMcyswNm5W?= =?utf-8?B?MzUxLy9GVkVKMk40eDJQc1hNRTlENVBuOFFnb2ltSW9EWVpLbmxaUzFXWElw?= =?utf-8?B?TDdmR0hGM0Y4V0d6RHY5WCt1eXlFMzJZRzVqck5WSzlzM3p1Vm8xYVlnSm1y?= =?utf-8?B?bXZwZzFRbmE3cUxQeEVuaWNxYTF4VWcwVVVaY3JVcExuQkYwT212NVNjcGJH?= =?utf-8?B?cmFGS3Zwc0NDNzUrUzlESWVudWxXTnhYam1QT083ODVZeVJTaEsxNHhIQUVy?= =?utf-8?B?aElUT0NvSk9FYVorMVNVeGR3dFF6L2xpbHdydmdCL1krQml6NHV3d0JtTGpn?= =?utf-8?B?aE1uaUxlTVJ6TGs3bFRrelZIYmhqaDZPS3Bsd2ZjVWdaOGl5Q2xFQ3FZWE9B?= =?utf-8?B?Q0FPY0h0ZWEraFhtck9YanRJVkpWN21pQjF1S1NpZHpwbnNOTG4rLzcxeW9u?= =?utf-8?B?dUhMQUNvdG1oenBBM2o2NElPQmRBa2FtdFlBcXJhSE9yWGFJdzloNS9yRGZ1?= =?utf-8?B?b1VCdnNtMko1SzZodkJzYTJEUjZocC9RNDRpRzBWUDJVMStkRCtVSDNKd0tO?= =?utf-8?B?Ly9QYjBLTU4xaXFEeWN3dWhTR1gva21YUlVBNzkrb3l4THU2aUJnUTVkOTNk?= =?utf-8?B?ZWN3VVhYQ2E0TXc5NlN5em9ubXBXWWh2OEJDWGd0L0VQcmF2cGF1dVlTZW0x?= =?utf-8?B?WTRaQVhKd3ZUMTZna2QweUJOekdETmdYL0lDTDBYQXRXeXBjZTd2NWY0WGFR?= =?utf-8?B?WGxra2Y2eDQ1VE5WT3lFbmlSK0pZWnRSaW5FTEN0TEtQTnJlSG9aV1dmMW5o?= =?utf-8?B?a05BaU1LNUFncnNUbjdSRGplYXpyK2dWVWJDbFY0N0Zxb2MvOC9lcDhYYmo5?= =?utf-8?B?eElyVkFpK0gvRENndFhEQXVxZGt5VDRZOXZKUFFFQjh4eFRMamNsdHo5VVpG?= =?utf-8?B?V0I5MEIraW52ZjlZVzdjM1FxR2VyZEFHTlBMeHRUVlZaZi94Vk9KR2xxeTVX?= =?utf-8?B?eGpjY1pRTVpxcHN3YVE0YlNLVzFXaTMxY2xqUjRFUWhGaW5SWWIwOWhwL3RP?= =?utf-8?B?OUZYT0hzUjlQLzZQNGdxSjhUblB0eTkvNWNuL1VXeTVPYzJhTitzSDFJUGRm?= =?utf-8?B?MmR3SlFLZGs0RUs5YTY2R09nbjNQRFNsTkhKSGlaNyt5ZzVEaG9Nd2dhbkdq?= =?utf-8?B?djBlbnVGcXY4bElvd25lcEliTi93YWUvMlFpTmxNUFVXTHZTcUtUYkJmaWhW?= =?utf-8?B?Sjh3amRqa3FMaGVIRE84MlNsUWNFYWszNnMxbFQwYStKN1U1aGpnazhQTzFh?= =?utf-8?B?NzgyblRHeUtFWWpCMEVDU0pFYmVWRmJ0cDdwSEJ1RXMzamNRbnJKUE5uQnRj?= =?utf-8?B?VzZkN3FPaTRvZmNaWEptQVNXVEFTWlFrc0FuN3Y0UUlEK2lCL2tQQkJaODlq?= =?utf-8?B?OXlQUi9DRTVFK2xGNGI4TFpRZ2NXTHorSnJKcDRCWHBPWm82V1NzYVB0RXlR?= =?utf-8?B?V3J6TGRKVngyOXBrNFhaS29PYTR0TkZrNHFVdHJsN0xsVjI4NThtVFJhSEFp?= =?utf-8?B?MDlwYkE4QXcvVkQ0dmlCY28wME1Ydms4RXkwSkxETjhPb1IrSVRXbTRHY1Mw?= =?utf-8?B?b1p5Wk9JZ0gyY3FiUnJZOTUwTGJJZTN6RE81TlZNeGtxMzZ5cEpNK1JCb1lT?= =?utf-8?B?QjZxK0tjR0JjRFRDemRlTEl5VDhUNVdpNWsxQUdkc044dnd0NjdkQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3188295-7335-4f44-c169-08def25a267a X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 18:56:54.0555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IDqeZjSFeyZG2BCB9U2yZPtuzTcUpGJhwmi+dDRwmWxJtaXJ9iMLGCKm0kfvhYm9MNsAWMZyMx/jEykgN0Z0oGlj9J7uGnCUQUaBty5aJgg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5744 X-purgate-ID: tlsNG-33051d/1785869817-756834E9-7651E4B4/0/0 X-purgate-type: clean X-purgate-size: 14557 On 03/08/2026 4:26 pm, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/x86/x86_emulate/decode-lite.c >> @@ -0,0 +1,330 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> + >> +#ifdef __XEN__ >> +# include >> +# include >> +#endif >> + >> +#include "private.h" >> + >> +#undef ModRM >> + >> +/* >> + * Bare minimum x86 instruction decoder to parse the alternative replacement >> + * instructions and locate the IP-relative references that may need updating. >> + * >> + * These are: >> + * - disp8/32 from near direct branches >> + * - RIP-relative memory references >> + * >> + * The following simplifications are used: >> + * - All code is 64bit, the instruction stream is well formed and safe to >> + * read. >> + * - Instruction groups and prefixes not used by Xen's current alternatives >> + * are not implemented in order to reduce the decode complexity. >> + * - Certain instructions are intentionally not recognised, when it is more >> + * likely for their presence to be an error than intentional. >> + * >> + * Inputs: >> + * @ip The position to start decoding from. >> + * @end End of the replacement block. Exceeding this is considered an error. > Why do you mention replacement blocks here? Are we entirely set on this > code not possibly gaining any purpose beyond the scanning of those? It's just the end of the instruction stream wanting decoding.  I'll adjust the comment. >> +{ >> +#define Imm8 (1 << 0) >> +#define Imm (1 << 1) >> +#define Moffs (1 << 2) >> +#define Branch (1 << 5) /* Near direct branches, which have a displacement */ >> +#define ModRM (1 << 6) >> +#define Known (1 << 7) >> + >> + static const uint8_t init_or_livepatch_const onebyte[256] = { >> + >> +#define ALU_OPS(x) \ >> + [(x) + 0] = (Known|ModRM), \ >> + [(x) + 1] = (Known|ModRM), \ >> + [(x) + 2] = (Known|ModRM), \ >> + [(x) + 3] = (Known|ModRM), \ >> + [(x) + 4] = (Known|Imm8), \ >> + [(x) + 5] = (Known|Imm) >> + >> + ALU_OPS(0x00) /* ADD */, ALU_OPS(0x08) /* OR */, >> + ALU_OPS(0x10) /* ADC */, ALU_OPS(0x18) /* SBB */, >> + ALU_OPS(0x20) /* AND */, ALU_OPS(0x28) /* SUB */, >> + ALU_OPS(0x30) /* XOR */, ALU_OPS(0x38) /* CMP */, >> + >> +#undef ALU_OPS >> + >> + [0x50 ... 0x5f] = (Known), /* PUSH/POP %reg */ >> + >> + [0x62] = 0, /* BOUND, but also EVEX prefix, not implemented. */ >> + [0x63] = (Known|ModRM), /* MOVSxd */ >> + >> + [0x68] = (Known|Imm), /* PUSH $imm */ >> + [0x69] = (Known|ModRM|Imm), /* IMUL $imm */ >> + [0x6a] = (Known|Imm8), /* PUSH $imm8 */ >> + [0x6b] = (Known|ModRM|Imm8), /* PUSH $imm8 */ >> + [0x6c ... 0x6f] = (Known), /* INS/OUTS */ >> + [0x70 ... 0x7f] = (Known|Branch|Imm8), /* Jcc disp8 */ >> + [0x80] = (Known|ModRM|Imm8), /* Grp1 */ >> + [0x81] = (Known|ModRM|Imm), /* Grp1 */ >> + >> + [0x83] = (Known|ModRM|Imm8), /* Grp1 */ >> + [0x84 ... 0x8e] = (Known|ModRM), /* TEST/XCHG/MOV/MOV-SREG/LEA */ >> + [0x8f] = 0, /* Grp1A - POP but also XOP prefix, not implemented. */ > POP doesn't look all that unlikely to be used in inline assembly, and > hence in alternatives. That said, of course using it with a memory > operand requires quite a bit of care. We have no alternatives playing with the stack (beyond CALL instructions), and no alternatives which have any net %rsp delta. PUSH/POP MEM are rare in general and Xen doesn't have any at all. > I don't see you excluding the > PUSH counterpart, though - being consistent for any such pairs would > seem somewhat desirable. It would be nice to be handled symmetrically, but this *is* an odd-instruction-out in the x86 encoding space. It ought to live in Grp5 where the encoding would be 0xff /7 (and beside it's matching PUSH), except that's that's a rather important binary pattern and wants to not be considered a valid instruction. The fact that the group is split like this shows that the mistake was a late discovery in the development of the 8086, where it was easier to move the one opcode than the whole group.  (It's likely to have been a metal-layer fix for the decode PAL, rather than adjusting the transistors, which is typically an order of magnitude cheaper fix.) > >> + [0x90 ... 0x99] = (Known), /* NOP/XCHG %rAX/CLTQ/CQTO */ >> + >> + [0x9b ... 0x9f] = (Known), /* FWAIT/PUSHF/POPF/SAHF/LAHF */ >> + [0xa0 ... 0xa3] = (Known|Moffs), /* MOVABS */ >> + [0xa4 ... 0xa7] = (Known), /* MOVS/CMPS */ >> + [0xa8] = (Known|Imm8), /* TEST %al */ >> + [0xa9] = (Known|Imm), /* TEST %rAX */ >> + [0xaa ... 0xaf] = (Known), /* STOS/LODS/SCAS */ >> + [0xb0 ... 0xb7] = (Known|Imm8), /* MOV $imm8, %reg */ >> + [0xb8 ... 0xbf] = (Known|Imm), /* MOV $imm{16,32,64}, %reg */ >> + [0xc0 ... 0xc1] = (Known|ModRM|Imm8), /* Grp2 (ROL..SAR $imm8, %reg) */ >> + >> + [0xc3] = (Known), /* RET */ >> + [0xc4 ... 0xc5] = 0, /* LES/LDS but also VEX prefixes, not implemented. */ > This may bite us sooner or later, due to the VEX-encoded integer insns > that there are. Of course as long as we don't use this function on > compiled code, and as long as my "x86: allow Kconfig control over psABI > level" doesn't come close to going in, that's merely a theoretical > concern. > > Same goes for not supporting the 3-byte opcodes, which also encode > certain integer insns. I have no doubt that we're going to need to add support eventually. But, a) I don't have time right now b) We have real bugs/limitations right now needing this functionality to address (patch 5, and the xsave fixes, and bus lock trap enablement) c) GitlabCI will reliably notice any new alternative instructions that this can't decode (patch 3) d) This function is a fastpath during the alternatives patching critical region (patch 4) Option d alone is a good reason not to decode VEX prefixes yet. > >> + [0xc6] = (Known|ModRM|Imm8), /* Grp11, Further ModRM decode */ >> + [0xc7] = (Known|ModRM|Imm), /* Grp11, Further ModRM decode */ >> + >> + [0xcb ... 0xcc] = (Known), /* LRET/INT3 */ >> + [0xcd] = (Known|Imm8), /* INT $imm8 */ >> + >> + [0xd0 ... 0xd3] = (Known|ModRM), /* Grp2 (ROL..SAR {$1,%cl}, %reg) */ >> + >> + [0xd6] = (Known), /* UDB */ > I guess you consider XLAT, LOOP*, and J*CXZ as too odd to use in alternatives? > Decoding-wise they're rather easy to implement. They are easy, but they also shouldn't appear anywhere in Xen. I know we've got one J*CXZ in the emulator.  I tried quite hard to find an alternative before deciding it was an acceptable solution given the constraints, but it's in plain code. > >> + [0xe4 ... 0xe7] = (Known|Imm8), /* IN/OUT $imm8 */ >> + [0xe8 ... 0xe9] = (Known|Branch|Imm), /* CALL/JMP disp32 */ >> + >> + [0xeb] = (Known|Branch|Imm8), /* JMP disp8 */ >> + [0xec ... 0xef] = (Known), /* IN/OUT %dx */ >> + >> + [0xf1] = (Known), /* ICEBP */ >> + >> + [0xf4] = (Known), /* HLT */ >> + [0xf5] = (Known), /* CMC */ >> + [0xf6 ... 0xf7] = (Known|ModRM), /* Grp3, Further ModRM decode */ >> + [0xf8 ... 0xfd] = (Known), /* CLC ... STD */ >> + [0xfe ... 0xff] = (Known|ModRM), /* Grp4 */ >> + }; >> + static const uint8_t init_or_livepatch_const twobyte[256] = { >> + [0x00 ... 0x03] = (Known|ModRM), /* Grp6/Grp7/LAR/LSL */ > Leaving out INVD is surely find, but WBINVD? Given now expensive WBINVD is, what possible reason can you think for having it in an alternative ? > >> + [0x0b] = (Known), /* UD2 */ >> + >> + [0x18 ... 0x1f] = (Known|ModRM), /* Grp16 (Hint Nop) */ >> + [0x20 ... 0x23] = (Known|ModRM), /* MOV %cr/%dr */ >> + >> + [0x30 ... 0x33] = (Known), /* WRMSR/RDTSC/RDMSR/RDPMC */ >> + >> + [0x40 ... 0x4f] = (Known|ModRM), /* CMOVcc */ >> + >> + [0x80 ... 0x8f] = (Known|Branch|Imm), /* Jcc disp32 */ >> + [0x90 ... 0x9f] = (Known|ModRM), /* SETcc */ >> + >> + [0xa0 ... 0xa2] = (Known), /* PUSH/POP %fs/CPUID */ >> + [0xa3] = (Known|ModRM), /* BT */ >> + [0xa4] = (Known|ModRM|Imm8), /* SHLD $imm8 */ >> + [0xa5] = (Known|ModRM), /* SHLD %cl */ >> + >> + [0xa8 ... 0xa9] = (Known), /* PUSH/POP %gs */ >> + >> + [0xab] = (Known|ModRM), /* BTS */ >> + [0xac] = (Known|ModRM|Imm8), /* SHRD $imm8 */ >> + [0xad ... 0xaf] = (Known|ModRM), /* SHRD %cl/Grp15/IMUL */ >> + >> + [0xb0 ... 0xb9] = (Known|ModRM), /* CMPXCHG/LSS/BTR/LFS/LGS/MOVZxx/POPCNT/UD1 */ >> + [0xba] = (Known|ModRM|Imm8), /* Grp8 */ >> + [0xbb ... 0xbf] = (Known|ModRM), /* BTC/BSF/BSR/MOVSX */ >> + [0xc0 ... 0xc1] = (Known|ModRM), /* XADD */ > What about MOVNTI? I judged that to be on the unlikely side to be needed. > >> + [0xc7] = (Known|ModRM), /* Grp9 */ >> + [0xc8 ... 0xcf] = (Known), /* BSWAP */ >> + }; > What about UD0? UD0 differs between vendors and product lines from Intel. > >> + void *start = ip, *rel = NULL; >> + unsigned int opc, rel_sz = 0; >> + uint8_t b, d, rex = 0, osize = 4; >> + >> +#define OPC_TWOBYTE (1 << 8) >> + >> + /* Mutates IP, uses END. */ >> +#define FETCH(ty) \ >> + ({ \ >> + ty _val; \ >> + \ >> + if ( (ip + sizeof(ty)) > end ) \ >> + goto overrun; \ >> + _val = *(ty *)ip; \ >> + ip += sizeof(ty); \ >> + _val; \ >> + }) >> + >> + for ( ;; ) /* Prefixes */ >> + { >> + switch ( b = FETCH(uint8_t) ) >> + { >> + case 0x26: /* ES override */ >> + case 0x2e: /* CS override */ >> + case 0x36: /* DS override */ >> + case 0x3e: /* SS override */ >> + case 0x64: /* FS override */ >> + case 0x65: /* GS override */ >> + case 0xf0: /* LOCK */ >> + case 0xf2: /* REPNE */ >> + case 0xf3: /* REP */ >> + break; >> + >> + case 0x66: /* Operand size override */ >> + osize = 2; >> + break; >> + >> + /* case 0x67: Address size override, not implemented */ >> + >> + case 0x40 ... 0x4f: /* REX */ >> + rex = b; >> + continue; >> + >> + default: >> + goto prefixes_done; >> + } >> + rex = 0; /* REX cancelled by subsequent legacy prefix. */ >> + } >> + prefixes_done: >> + >> + if ( rex & REX_W ) >> + osize = 8; >> + >> + /* Fetch the main opcode byte(s) */ >> + if ( b == 0x0f ) >> + { >> + b = FETCH(uint8_t); >> + opc = OPC_TWOBYTE | b; >> + >> + d = twobyte[b]; >> + } >> + else >> + { >> + opc = b; >> + d = onebyte[b]; >> + } >> + >> + if ( unlikely(!(d & Known)) ) >> + goto unknown; >> + >> + if ( d & ModRM ) >> + { >> + uint8_t modrm = FETCH(uint8_t); >> + uint8_t mod = modrm >> 6; >> + uint8_t reg = (modrm >> 3) & 7; >> + uint8_t rm = modrm & 7; >> + >> + /* ModRM/SIB decode */ >> + if ( mod == 0 && rm == 5 ) /* RIP relative */ >> + { >> + rel = ip; >> + rel_sz = 4; >> + FETCH(int32_t); > FETCH() here but ... > >> + } >> + else if ( mod != 3 && rm == 4 ) /* SIB */ >> + { >> + uint8_t sib = FETCH(uint8_t); >> + uint8_t base = sib & 7; >> + >> + if ( mod == 0 && base == 5 ) >> + goto disp32; > ... goto here? Hmm.  That's an artefact of how it developed.  Swapping this goto for FETCH() does drop 20 bytes, but the function is rearranged so much that it's hard to tell if this is because real logic is getting dropped. > >> + } >> + >> + if ( mod == 1 ) /* disp8 */ >> + FETCH(int8_t); >> + else if ( mod == 2 ) /* disp32 */ >> + { >> + disp32: >> + FETCH(int32_t); >> + } > In several cases the FETCH()ed value isn't used. Compilers as well as Eclair > (and alike) are happy with that? Yes.  The cover letter has a fully passing pipeline. > And compilers also manage to eliminate the memory accesses then? Yes. > >> --- a/xen/arch/x86/x86_emulate/x86_emulate.h >> +++ b/xen/arch/x86/x86_emulate/x86_emulate.h >> @@ -835,4 +835,18 @@ static inline void x86_emul_reset_event(struct x86_emulate_ctxt *ctxt) >> ctxt->event = (struct x86_event){}; >> } >> >> +/* >> + * x86_decode_lite(). Very minimal decoder for managing alternatives. >> + * >> + * @len is 0 on error, or nonzero on success. If the instruction has a >> + * relative field, @rel_sz is nonzero, and @rel points at the field. >> + */ >> +typedef struct { >> + uint8_t len; >> + uint8_t rel_sz; /* bytes: 0, 1 or 4 */ > Perhaps use bitfields in favor of fixed-width integers, seeing what > ./CODING_STYLE says? No.  That destroys the code generation improvements gained by returning a pair like this in the first place. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 19:05:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 19:05:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382588.1625937 (Exim 4.92) (envelope-from ) id 1wrKSU-0002hn-5l; Tue, 04 Aug 2026 19:05:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382588.1625937; Tue, 04 Aug 2026 19:05:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKSU-0002hg-39; Tue, 04 Aug 2026 19:05:50 +0000 Received: by outflank-mailman (input) for mailman id 1382588; Tue, 04 Aug 2026 19:05:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKSR-0002ha-GP for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:05:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrKSQ-004j7r-6J for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:05:46 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7237eb-e002-0a2a0a5209dd-0a2a4506d856-20 for ; Tue, 04 Aug 2026 21:05:45 +0200 Received: from [65.109.113.108] (helo=mail.alien8.de) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a723719-195a-0a2a45060019-416d716cbea8-3 for ; Tue, 04 Aug 2026 21:01:45 +0200 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 45BCB40E00C4; Tue, 4 Aug 2026 19:01:44 +0000 (UTC) Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AlYW3JH6yZ7B; Tue, 4 Aug 2026 19:01:34 +0000 (UTC) Received: from stx.tnic (unknown [IPv6:2600:1700:38ca:c00::1b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 35E3D40E014A; Tue, 4 Aug 2026 19:00:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=alien8 header.d=alien8.de header.i="@alien8.de" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" X-Virus-Scanned: Debian amavisd-new at mail.alien8.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1785870092; bh=jTsy9ZARpgzdc80qYRTp3ZXD5rupzYp290aPlne24Qo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i0HieeVUumgJVayfbtPXTLtU9jBWToWFEfi863xOYMBKUVkhNQ0/BrVP6oPJRFif1 RGcTlXKPfkv3nwc3J6ik7Eoh+noJN7Y/49GURDCHiWmmcvjurYMzUfD5PiEHDk30cJ pRNh4761TsVzHwyED8UB3oOsW/8KQRN3Mx749T5gWDfd00+A8+mFaHrqBYTGTGIryy 1YPo/r7tQzScAcbHiBe85j+9dxxQ1Y731eyF2lUw4Sly7Q3WVTpF3AMKJkf1uQzBeb JYieO0HiWqsbzQPpPDzv9bTeOhd9OR72c9RvUYbqA+jOYpkvx07+CUAkReUdW59gi0 DEUGAN1LYWIUv6YarDwWUXxZMIEwPcB3vzm2FdFf05VVMvdQylixP4wN45bPVdqxMU Kn3fe9OIqnxcur1gYV2y0vcl5y6+qcZQuCJISJ6PNY7JBIodKNlAd38lRkhXr5dcLn ue0Fz+kQit+Fm1CnjBOmMu8dJCugOFpc7mCGptKUAONYjDfNlE7xcYS3TW8V8TeJ0I otMAHzrkRKiVwHtrfjaDjpwIXwb7+HQ0fvxUrGTFlI1hc5AMrr8BoufCl/Fvn4BE8B iR/+7JkM+My3QbPAtTN6ne7lhMXJnvOUNGV/mcaWods81JxYTbV35yHlLwwgWKwy7S DIyILA9dtJY98R+pyzsu94ok= Date: Tue, 4 Aug 2026 12:00:48 -0700 From: Borislav Petkov To: Dmitry Ilvokhin Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/5] x86/paravirt: Use static_call() for the paravirt spinlock ops Message-ID: <20260804190048.GCanI24Hb5P8qAyVZs@fat_crate.local> References: <9a32ae399eb804a02a31af04dcabe7e7ee4f3fdf.1785778551.git.d@ilvokhin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9a32ae399eb804a02a31af04dcabe7e7ee4f3fdf.1785778551.git.d@ilvokhin.com> X-purgate-ID: tlsNG-16d1c6/1785870105-F4C0777B-F4AEA2D4/13/0 X-purgate-type: clean X-purgate-size: 3813 On Tue, Aug 04, 2026 at 07:15:41AM +0000, Dmitry Ilvokhin wrote: > From: Peter Zijlstra > > queued_spin_lock_slowpath() and queued_spin_unlock() are dispatched > through pv_ops_lock via the paravirt-ops ALTERNATIVE machinery, which > picks the target (native inline store / hypervisor call) once at boot > and cannot change at runtime. > > Convert both to static_call(). The site becomes a direct call patched in > place (one byte smaller), and on native the unlock still collapses to > the inline "movb $0, (%rdi)" store, so the fast path is unchanged. > > Unlike the ALTERNATIVE mechanism, a static_call() target can also be > updated at runtime via static_call_update(). This is a prerequisite for > the contended_release tracepoint, which has to swap in a traced unlock > while the system is running. > > [ ilvokhin: commit message; fix PARAVIRT_SPINLOCKS=n build; teach > __static_call_validate() about the inline unlock insn; make the > slowpath site module-safe: static_call_mod() + > EXPORT_STATIC_CALL_TRAMP(); pass @lock to the callee-save unlock, > fixing a boot hang under CALL_DEPTH_TRACKING. Boot tested native + KVM > PV guest. ] > > Link: https://lore.kernel.org/all/20260603120811.GW3493090@noisy.programming.kicks-ass.net/ > Co-developed-by: Dmitry Ilvokhin > Signed-off-by: Dmitry Ilvokhin This needs Peter's SOB. > --- > arch/x86/hyperv/hv_spinlock.c | 4 ++-- > arch/x86/include/asm/cpufeatures.h | 1 - > arch/x86/include/asm/paravirt-spinlock.h | 19 +++++++++++------ > arch/x86/kernel/kvm.c | 5 ++--- > arch/x86/kernel/paravirt-spinlocks.c | 12 +++++------ > arch/x86/kernel/static_call.c | 27 ++++++++++++++++++++++++ > arch/x86/xen/spinlock.c | 5 ++--- > tools/arch/x86/include/asm/cpufeatures.h | 1 - > 8 files changed, 51 insertions(+), 23 deletions(-) > > diff --git a/arch/x86/hyperv/hv_spinlock.c b/arch/x86/hyperv/hv_spinlock.c > index 210b494e4de0..6b4bdea18218 100644 > --- a/arch/x86/hyperv/hv_spinlock.c > +++ b/arch/x86/hyperv/hv_spinlock.c > @@ -78,8 +78,8 @@ void __init hv_init_spinlocks(void) > pr_info("PV spinlocks enabled\n"); > > __pv_init_lock_hash(); > - pv_ops_lock.queued_spin_lock_slowpath = __pv_queued_spin_lock_slowpath; > - pv_ops_lock.queued_spin_unlock = PV_CALLEE_SAVE(__pv_queued_spin_unlock); > + static_call_update(queued_spin_lock_slowpath, __pv_queued_spin_lock_slowpath); > + static_call_update(queued_spin_unlock, __raw_callee_save___pv_queued_spin_unlock); > pv_ops_lock.wait = hv_qlock_wait; > pv_ops_lock.kick = hv_qlock_kick; > pv_ops_lock.vcpu_is_preempted = PV_CALLEE_SAVE(hv_vcpu_is_preempted); > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 1b4a48bff18f..e41fe5c24841 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -225,7 +225,6 @@ > #define X86_FEATURE_EPT_AD ( 8*32+17) /* "ept_ad" Intel Extended Page Table access-dirty bit */ > #define X86_FEATURE_VMCALL ( 8*32+18) /* Hypervisor supports the VMCALL instruction */ > #define X86_FEATURE_VMW_VMMCALL ( 8*32+19) /* VMware prefers VMMCALL hypercall instruction */ > -#define X86_FEATURE_PVUNLOCK ( 8*32+20) /* PV unlock function */ No, do: /* free: was #define X86_FEATURE_PVUNLOCK ( 8*32+20) /* PV unlock function */ so that we can reuse it by finding it easier. > #define X86_FEATURE_VCPUPREEMPT ( 8*32+21) /* PV vcpu_is_preempted function */ > #define X86_FEATURE_TDX_GUEST ( 8*32+22) /* "tdx_guest" Intel Trust Domain Extensions Guest */ -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Aug 04 19:17:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 19:17:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382596.1625947 (Exim 4.92) (envelope-from ) id 1wrKdx-0004mb-6o; Tue, 04 Aug 2026 19:17:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382596.1625947; Tue, 04 Aug 2026 19:17:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKdx-0004mU-3V; Tue, 04 Aug 2026 19:17:41 +0000 Received: by outflank-mailman (input) for mailman id 1382596; Tue, 04 Aug 2026 19:17:40 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKdw-0004mO-5i for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:17:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrKdu-001ZEk-MB for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:17:38 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a723ac1-5cb7-0a2a0a5109dd-0a2a450991aa-20 for ; Tue, 04 Aug 2026 21:17:38 +0200 Received: from [103.168.172.155] (helo=fhigh-a4-smtp.messagingengine.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a723ad0-be1a-0a2a45090019-67a8ac9ba8af-3 for ; Tue, 04 Aug 2026 21:17:37 +0200 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 99B98140003C; Tue, 4 Aug 2026 15:17:36 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Tue, 04 Aug 2026 15:17:36 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Aug 2026 15:17:34 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1785871056; x=1785957456; bh=M/edlRurpgP0Tl8VkZ8RyPV4qAksso5dpsJdKhGE39U=; b= FNN5lzzVzAPEd9kn2HyNaBsujZACMLlDtYxTDQiT0dzZ8awGOz8Rk7+2MIIVbVEj Etc0OeMQ21jn8WhCtRBFal3nXbh2ok8LQkCTQjeoQkTpAmPoZf7zuiqsaZV8D4Vi /SJy1YqnReOGJIyOR8beaWutZXKI59F4ScfRlzxLytwSz1YiZM+uH4a8n92+krcc k0Gzfnk5a64AnGNLW58sbFTLe7QLqJzigZ1jjVtqCiGuhzndludlJ1IBLqZH6OoV ruh6zP6f4gRgoU1yntQuNZaq10Qw75UY+ggGIxO8Y89PEZg6IfMlzyXTWQay8hZ+ 5/Ou2AAEHbG1CBoK4eIcSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1785871056; x=1785957456; bh=M/edlRurpgP0Tl8VkZ8RyPV4qAksso5dpsJ dKhGE39U=; b=CTZnioEQ64TFHLcoTa9PVnPoon2QEtDWKqEoTeWDFnDilw8n9fV iCCcjaV0D2460aHgi7F8R7P+J6u0zl1NmVGdE10cOswB2Nq7mEsBUKRQjygPwxJL Ouo8ak7zvpn/Gqfzchn7oZ/xR9kaqoaUB/JF5lV2+QW5Ltq1iGL/0BGzGMi0QSor 21EM4zsMwVMxBsMHcQo5cNvZ8kyD+WNOYz90WomAXCnCqfFChL1rQFPmlLFsG4k7 lsHZLPHAdidjN6v1ysyAFFg0L5QkE1j2EIY9VrYNjA316kuhkAq7JRnGaZCVjqv/ V64gQhGk8FUM19elq863BhTT7Q+zmEd6UOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFK/HNVRU9POJZ7muAO4IuQz06udRuTBk9a2svdjpaXCu7y0fu4q5+jNf4Nd9PP9u lRgIXJzXxCgD1zgHfD3THiV9eLVR4sO9C67JR78Ru9NZIPpKCKDw8WTy/90Z7WV1iiXE71 xjiU/1XQxW1i/L8o60OFHRBtK5D4JnD84vUO/dE96RWRQCC0WWcjt2VnejpYPo8gbIfa8N ZXl+yEcSleJSMgnRQPnAfpIA1vLLQ2xyWFnAiRm0shjcxM/bFYEMJZrPSpl0iimcbyNDxE 6o30zGwmiPPcYw6UuoZz1zeJxPhlzWODW1uEg/p2tqkImsxEKbG+ueI1T/zOaPTSdd7zFi ++gQ3P7Yr7ZusYXFWVv8T52RJB4il8Vm8dgs4OAQTt/Uy82ZWuIcu+Ou0SjUeyorscaso0 DgtYv/jS5dl3XZep1H0bgNZbJ8ZZLt3vuHnTv0z7a6m8Qq/OTUhLGFIezsF7CeKdIxgCva 6aLM1Hw05hFKvqR+TPx6UYTZqkx+T9zUrDpwtfMYZMOUTiJHanoILxq+1zvB5Pja0k9aP+ dQ4wxqv8h51bXjmHyJ00DxKAC0RG5T+KNU1pIeTyg/PUi+kGozK9M2D8H5FdyqdzhqlKvQ KaS1OPhBCGsMjWJYHKNPNsiah92uk8uu2RlIbg8TLURWNPyFJ5dvOw4D4vrg X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 4 Aug 2026 21:17:32 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Frediano Ziglio , xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 Message-ID: References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-3-frediano.ziglio@citrix.com> <9dc1d91c-52e2-4cd9-a234-6d6ca6ecceb8@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hQuFwtfgOO6JM1Yo" Content-Disposition: inline In-Reply-To: <9dc1d91c-52e2-4cd9-a234-6d6ca6ecceb8@citrix.com> X-purgate-ID: tlsNG-bad1c0/1785871058-3AAD8034-BA37ACC5/0/0 X-purgate-type: clean X-purgate-size: 5921 --hQuFwtfgOO6JM1Yo Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 4 Aug 2026 21:17:32 +0200 From: Marek =?utf-8?B?PT91dGYtOD9RP01hcmN6eWtvd3NraS1HPUMzPUIzcmVja2k/PQ==?= To: Andrew Cooper Cc: Frediano Ziglio , xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 On Tue, Aug 04, 2026 at 07:55:24PM +0100, Andrew Cooper wrote: > On 04/08/2026 7:48 pm, Frediano Ziglio wrote: > > On Tue, 4 Aug 2026 at 18:57, Marek Marczykowski-G=C3=B3recki > > wrote: > >> On Tue, Aug 04, 2026 at 06:42:18PM +0100, Frediano Ziglio wrote: > >>> Make sure that save/restore continue to work. > >>> The check save and restore twice to check for corrupted status. > >>> Also a command is launched in the guest to make sure that the > >>> machine is not crashed but working. > >>> > >>> Signed-off-by: Frediano Ziglio > >>> --- > >>> automation/scripts/console.exp | 8 +++++ > >>> automation/scripts/qemu-alpine-x86_64.sh | 40 ++++++++++++++++++++++= -- > >>> 2 files changed, 46 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/automation/scripts/console.exp b/automation/scripts/cons= ole.exp > >>> index e27886bbef..ff58ed29b8 100755 > >>> --- a/automation/scripts/console.exp > >>> +++ b/automation/scripts/console.exp > >>> @@ -58,6 +58,14 @@ if {[info exists env(WAKEUP_CMD)]} { > >>> system "$env(WAKEUP_CMD)" > >>> } > >>> > >>> +if {[info exists env(EXPECT_TEXTS)]} { > >>> + set lines [split "$env(EXPECT_TEXTS)" "\n"] > >>> + foreach {exp snd} $lines { > >>> + expect -re "$exp" > >>> + send "$snd\n" > >>> + } > >>> +} > >>> + > >>> if {[info exists env(LOG_MSG)]} { > >>> expect { > >>> -notransfer -re "$env(PASSED)" { > >>> diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/sc= ripts/qemu-alpine-x86_64.sh > >>> index 60f5cc49fc..409a601c34 100755 > >>> --- a/automation/scripts/qemu-alpine-x86_64.sh > >>> +++ b/automation/scripts/qemu-alpine-x86_64.sh > >>> @@ -48,6 +48,28 @@ xl -vvv create -c /root/domU.cfg > >>> > >>> " > etc/local.d/xen.start > >>> chmod +x etc/local.d/xen.start > >>> + > >>> +# Script to test save and restore. > >>> +# It saves and restores domU domain twice to check if the domain was= corrupted > >>> +# during the first sequence. > >>> +# At the end open the console to check if the domain is working. > >>> +cat > root/save_restore_test << "EOF" > >>> +#!/bin/sh > >>> +set -ex > >>> +xl list | grep -q domU > >>> +rm -f save.dat > >>> +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat /r= oot/domU.cfg > >>> +xl restore /root/domU.cfg save.dat > >>> +xl list | grep -q domU > >>> +rm -f save.dat > >>> +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat /r= oot/domU.cfg > >>> +xl restore /root/domU.cfg save.dat > >>> +xl list | grep -q domU > >>> +rm -f save.dat > >>> +xl console "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" > >>> +EOF > >>> +chmod +x root/save_restore_test > >>> + > >>> find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz > >>> cd ../.. > >>> > >>> @@ -70,9 +92,23 @@ export TEST_CMD=3D"qemu-system-x86_64 \ > >>> -device virtio-net-pci,netdev=3Dn0 \ > >>> -netdev user,id=3Dn0,tftp=3Dbinaries,bootfile=3D/pxelinux.0" > >>> > >>> +# Sequence of expect/send strings: > >>> +# 1. wait domain start and close console; > >>> +# 2. wait login prompt and login as root > >>> +# 3. wait login and launch save/restore test; > >>> +# 4. wait restore from domain console and send a command. > >> Why doing this interactively over serial, instead of adding to > >> etc/local.d/xen.start and then printing test result at the end? > >> > > I'm using expect to interact with the console. expect is not available > > inside the alpine root filesystem. > > Some failure I had during migration is that the VM crashed. In the > > script I interact with the console to check that the VM is still able > > to run commands. >=20 > We can add `expect` to the dom0 root filesystem if we find a need for > it, and it looks like this might be a good enough reason.=C2=A0 You want a > patch to https://gitlab.com/xen-project/hardware/test-artifacts > images/alpine/*-x86_64-base.dockerfile to get it included. FWIW, my suspend test (which tests a similar thing) uses ping to check if domU is still alive: https://gitlab.com/xen-project/people/marmarek/xen/-/blob/2184be51d426b60f5= e1a7e6e891d0f40e9488fc7/automation/scripts/qemu-alpine-domU-suspend-x86_64.= sh > But, for migration testing, this really wants to run on the real > hardware.=C2=A0 Besides the main memory image, there's variations in regi= ster > state and validity which will vary between hardware. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --hQuFwtfgOO6JM1Yo Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmpyOswACgkQ24/THMrX 1yyZZwgAk+x0JJUH7L6xO6AueJRPcm/8FB/EEIhmJn9UTrsz/AArwo1pHd24NhAn vDwM5cw4bkNAo8qqm9wkVI1UctRLdrR1yoj9nebEosm9969h5W8QfqX1BEZfjeB4 FcRVypbfDHXoeWRhA9f/k9Ixz/LAVxRbCmc3steaE8bGnnGH/U2K3zbqWYvXSDSF yNR2qQizmZpASTAdaeQv8ann8hfz7mqDAYMhfuAQ0iPn8GxzaksoYKlflr68nJd6 ZichuKBc4Vwjtp/8odC1uDEnYEwnbKxmQumnduCUcDi98ZZ8vjy9xOGeTkAzxYS6 fdDSeGVaCnX6PnruOVJtv85ohK9bUg== =lREV -----END PGP SIGNATURE----- --hQuFwtfgOO6JM1Yo-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 19:29:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 19:29:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382611.1625954 (Exim 4.92) (envelope-from ) id 1wrKp8-0006n1-52; Tue, 04 Aug 2026 19:29:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382611.1625954; Tue, 04 Aug 2026 19:29:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKp8-0006mu-29; Tue, 04 Aug 2026 19:29:14 +0000 Received: by outflank-mailman (input) for mailman id 1382611; Tue, 04 Aug 2026 19:29:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKp6-0006mm-VW for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:29:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrKp6-004lvs-0x for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:29:12 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a723d79-5cb7-0a2a0a5109dd-0a2a450286d6-16 for ; Tue, 04 Aug 2026 21:29:11 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a723d87-6ca4-0a2a45020019-b9ff1c228979-3 for ; Tue, 04 Aug 2026 21:29:11 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fce4038dd000e099.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 04 Aug 2026 19:29:03 +0000 Received: from l14 (82-67-99-167.subs.proxad.net [82.67.99.167]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 2E4F881FA4; Tue, 4 Aug 2026 21:29:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=kqZ+2ADVwqlVsYaAlIYvrBJpz0kUI7mX5ygvag4vGGo=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=l7LfxUowQGpuaYVgk0GYAZLvihpODE7NqpSuqW8SoV27t+f19jbMnXUyLfYHNncl3O4mGRqmD n6edZK/Rguw7bAteIrQVmAZbRlstVguS3jnGl5ehfgcJaixPzdJmV2Y8crufjKPf83wVQe4GcSA BPK5XGcwXnl7GiFBKUwdrflnG76quYXw22VM1Ajlqrk1mREJNJ/wM8247PeZ56LsLs2wECTI9E0 N7G6rLkppa3Q/0fW5OO9ZYf8h0Z73G78bJHDzPOl77R3ZJwXhceiBvmwFY/liO1uwD1O381J812 MoLr45RgozMx4APrKnUxzlZzrw5YkvVddetT5GSNbjZw== X-Zone-Loop: 1cc3a5874ce419e693a20bee8b22273485fa0c627fd1 x-campaign-type: default x-transaction-id: 12587eb6-e6d1-4239-ab16-3a7037affca0 x-swg-uid: 01-e90026e4-62bc-4f4b-8530-1edc21fa8f5d X-Mailer: Sweego Message-ID: <1785871743.8631fc262581453bbf619ec5b2062170.19fce4038dd000e099@vates.tech> x-swg-bid: 1785871743.8631fc262581453bbf619ec5b2062170.19fce4038dd000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Tue, 4 Aug 2026 21:29:01 +0200 From: Anthony PERARD To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= Subject: Re: [PATCH 1/2] CI: Simplify directories creation References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-2-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260804174219.835096-2-frediano.ziglio@citrix.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.1c3f.63ba4c08b36f0347.19fce4035b7.9383ca257edc557f=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1785871742391 X-purgate-ID: tlsNG-720697/1785871751-F06A72AC-A2D84C92/0/0 X-purgate-type: clean X-purgate-size: 1782 ---=Part.1c3f.63ba4c08b36f0347.19fce4035b7.9383ca257edc557f=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Aug 04, 2026 at 06:42:17PM +0100, Frediano Ziglio wrote: > diff --git a/automation/scripts/qemu-alpine-x86_64=2Esh b/automation/scr= ipts/qemu-alpine-x86_64=2Esh > index 242ffca693=2E=2E60f5cc49fc 100755 > --- a/automation/scripts/qemu-alpine-x86_64=2Esh > +++ b/automation/scripts/qemu-alpine-x86_64=2Esh > @@ -4,16 +4,7 @@ set -ex -o pipefail > =20 > # DomU Busybox > cd binaries > -mkdir -p initrd > -mkdir -p initrd/bin > -mkdir -p initrd/sbin > -mkdir -p initrd/etc > -mkdir -p initrd/dev > -mkdir -p initrd/proc > -mkdir -p initrd/sys > -mkdir -p initrd/lib > -mkdir -p initrd/var > -mkdir -p initrd/mnt > +mkdir -p initrd/{bin,sbin,etc,dev,proc,sys,lib,var,mnt} This makes it really hard to find out if more directory or less directory are been created=2E When reviewing a patch, we don't see what changed in a line without using more complex tools=2E For this patch, I have now idea at a glimpse if all the directory that was created before are still created=2E In the future, we might need to create more directories, this would change on very long line to another, and make it hard to find out what was the logical change, by just looking at the output of `diff -u`=2E So I don't see this patch as an improvement=2E But that just my opinion, but that would apply equally to other similar changes, like packing all the variable declaration on a single line in C= =2E Cheers, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.1c3f.63ba4c08b36f0347.19fce4035b7.9383ca257edc557f=--- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 19:37:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 19:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382618.1625963 (Exim 4.92) (envelope-from ) id 1wrKx4-0008PM-T4; Tue, 04 Aug 2026 19:37:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382618.1625963; Tue, 04 Aug 2026 19:37:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKx4-0008PF-QP; Tue, 04 Aug 2026 19:37:26 +0000 Received: by outflank-mailman (input) for mailman id 1382618; Tue, 04 Aug 2026 19:37:25 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrKx3-0008P9-L1 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 19:37:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrKx0-001bId-Qg for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:37:22 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a723f5e-5cb7-0a2a0a5109dd-0a2a4506b5ba-20 for ; Tue, 04 Aug 2026 21:37:22 +0200 Received: from [52.101.201.25] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a723f70-195a-0a2a45060019-3465c91949ac-4 for ; Tue, 04 Aug 2026 21:37:22 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by MN7PR03MB283467.namprd03.prod.outlook.com (2603:10b6:208:5f7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 19:37:19 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Tue, 4 Aug 2026 19:37:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Pz2DT61shBSEzN8w+Gte4E8/Pd/ITPXBVulHj3lEE+fBPfkikKw2loC6poxtEFa57Z2+kjyLZuWdwnIE5f8jU4EE+t02Qq8yCpXBBCd/BLwNJrYg6chF7UqcN08DblvUOJIh9eYIFB0u4RC1w+CcOiT9oP2BV9L5Ik/uICs+NdNHwAan/OApBd2RlH3NzSAVz9bVgodyPxcTZt2ipUnl9ADeMYZQDqkBZIw8iKSXQVKDcwOY6qYQPcwSpGVLdcKm3YnPT6bIbJ0v10TkYkYbtZKCTJvxKYbyDbd04jTU6kiN4q2S5F/S3c+5AiuTMGiSZLdngdV1wEBnFzlZV3Prog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZHm4HRFiqf/aeTm09glhME2FcmaxvO1JNLPRKicy50A=; b=QR1X279M1ywxMJXfgThHE10EYi95003jbNHG2g4zSieqAB+hjsj22OnmshUrwkvFJkVpQOHC+eOvhbvUh86aIitifkU1D51UWI2r0R9lvfT+R3Y0OuJfFqavkw1YYBwbYklyG6kbDtPKR+T8B+xeuQPdTrZG1PN7tgnW0Qn25dsTdkOkjvdCE909xoR3s7RjM3bopiVyYOaVPmxArgJ53LdHwCBbVtjD61lZqFuZEguEpZw6Yf0/sSBjn+DHQ/viGnOTJpMHC/k2MCDNVaWGKDyZBMUeJxYse3qF63WgbgoUr9szH5ZsNTOPajUEoN0h1Sz27jNOPUAI6muJoPuHVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZHm4HRFiqf/aeTm09glhME2FcmaxvO1JNLPRKicy50A=; b=kQTtaA6y9ktN8sVnn2KOD6Td1oHzs/MExgzizArhbwhOuGrdOJ+DhmCnsPBVMHJghDMoeCtci3ro6OBug+nyvx8lmOq8orugL5cbejiD76gIjACu/aVDiIR1M4BgIyKl4TREwbMhJTmxrIv83mhJtHQipEsbx9wcptY4eVYxzYk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <21d3fae8-e9b0-4c8a-a7b9-483a0257e44e@citrix.com> Date: Tue, 4 Aug 2026 20:37:15 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Xen-devel Subject: Re: [PATCH v3 2/5] tests/x86: Introduce a userspace test harness for x86_decode_lite() To: Jan Beulich References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-3-andrew.cooper3@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0317.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::16) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|MN7PR03MB283467:EE_ X-MS-Office365-Filtering-Correlation-Id: ba013c58-5bf0-435c-5976-08def25fcbcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|10067099003|56012099006|18002099003|6133799003|22082099003|3023799007|11063799006|4143699003; X-Microsoft-Antispam-Message-Info: QhtGUmJutLjS6bN9Hpok97xSpWokAhiELYDrnUpg2drmn8p/vl8xDGm/MVRbOYn3t+GwF6L3n0356RdnyvxYmnC90ZKdzh0aNlMvcg/r2A+wZgeblbaTQwJ/C5v1cPEw8EwKfiO6140TRXNtNSPLRbUCEQ6Te43b+3EPSs3FQGOLeBqwOkUdGwG+aNRzuGnQnKcouO7ClPLhW+OjyPqdC/FLK/X8Se2shmgvQ0IMp/r0LfYtmc+lNZNT5+jKyYKYh4M7//eubOBN9FtDmCFkKSwgYkBFOiaKCxqrkQmHvKZjzFNo53x7xNJXeQSNwRRUTPOS9IbtkivUjeiwOx7cZplESgehe2zPHo7F2DGSOmoklQQokbxGns91olEDlsjO2WpKS5ztM05o/2hMqjjN5/HlHT133ws24Z/TZRA8uh+tcbmlpFVWs6WEBN7kRBt8tf8IKSEA+1eYHzhJsNTtaNVrX5FyqHzyNCrb2I1Abkcc/CHMkFT5M0BZJtuKw+tlQxzuUCqNBcUivhH4cdLeei5xFyLp6Et2iuKPcXulADWHzbNa/mwgcToI39cWu+Mly+wKU7UqSYguHkIcx+7TAjrlNqN5jeGsd5i4KihavosYTavlShbR7M0st52qjulgC/IQzCNMFkfnb8J62kL29wM+AKKlGp0Vw+1Lsmbr8VA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(10067099003)(56012099006)(18002099003)(6133799003)(22082099003)(3023799007)(11063799006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUloclFlajBPL1JpbENZdytKRFBPZVk2UmR2WjZFRUVwSVowV21pamt2aTJ3?= =?utf-8?B?VXFYclROQkNRS0UzeGkzdWZDYWw4bzU2YWlXbUp6WVFuY3VrRWFuSTVwSndr?= =?utf-8?B?eFlGMFlwUWNVakhZOHprdUtiUHArVmlHSURPSWxtNnBJOURYb2JJbDBIdWF4?= =?utf-8?B?ZDlEcWkvZEdOZjZiMW8rOTlvakJpZkRqK0NjT3VqZGk4dWovYnQ2T2k1WW1I?= =?utf-8?B?N2E0MFlHZVZETFFsQmNiTVdFUDVtME8xZHRqMGJzdmo3RnZkSTJoV0tOUHNp?= =?utf-8?B?MDNwMmh1YTE1TEt0YTZrTEhnWmdLR1Q4Y2RtcDB3M3MrSTVwREdDdVVnbHFJ?= =?utf-8?B?bFVYdklUWnp2RFAza2RVdXNMYllYTHkrWm03NkZWUGdxNjRUdlR5SjJ5Wlk4?= =?utf-8?B?UjlLUldEYnVud2EvdG5hY2xxbVEyNUQ1Z0cramg3WjRkeDluQVFyTkZUSW9R?= =?utf-8?B?UVhRcCtNeWJRRnhBWGxSMXVFOWJCTHljSjZrYTVMT2NCZUhrY2NLb25jOVB1?= =?utf-8?B?SmoxeHltSjZJQk9VRHBOVFg4NFlSVnNXYjBtT2Z4V2I2MUo1MEVGeFNEcTJo?= =?utf-8?B?QllFNmNycGg1Rm9GSm5OTjBCU3g3Wk13VFV5ZmVqUGNFTFhQN2NuVmhWN1B4?= =?utf-8?B?UCtOOVU0dWJiYnVqVWVLWWI3RXBWNFNERXNuMG42MFBWTWh3dE1zOXp6Ykpw?= =?utf-8?B?d2JJd1I3T0pqYXArcTcyUSs2ckxRWVlOOWp0VEZTTTBnRTI5S1BCaFFkQzBK?= =?utf-8?B?SWZSWk9zTG1nWkkvajdKWjJMSkRybThLOUZVbDlGTXdmdjVWRW56WCtlVG1K?= =?utf-8?B?eVFaVWJaS1Z4MDdETFZVM0pvQlR6dWExQVBzK0gwYTZaSFFqci9panVLOUFt?= =?utf-8?B?L3ZidDJyWGVsV2loK2lYVmczRnBHRDFpdVlkdTc0TXR3eUpIV3BGRFRGQS96?= =?utf-8?B?ZFhyUVJiUEhVWmpkbUoyTzhWTldPLzJtRU05YzZid3JJdFA4bXNHWVZGeGNL?= =?utf-8?B?Ym9Nd0NjRGxUTUgrRGsxQU41NzUwWDJkYXAyN3NkUU5mUDYrdms5TFp2dWNC?= =?utf-8?B?VWhLbFhpYU1RYjc3SHRIOVRhbksyQ0FZRTRaUCt2KzBmcFVmK0NuanF5c1Fw?= =?utf-8?B?NFM1ZUZ2UTVKOG12N1B2NVFZRSt0VEhIbTAxL1pyd1hWOVhTRzhleUpMdkRl?= =?utf-8?B?WW5hbVJWaWJlRm9KYkFmc1cwWnhJNGIyOWxRZXJEd2dWVTluMXVXcnUvS2ta?= =?utf-8?B?MktSRGJMRFg3TmRYdUtLYnhwRFdNUkFzUVVRbzdGMGJyTUVxZjlrR0VmU01N?= =?utf-8?B?MHAwY2JuWkcxM081ekxsQkVKdzdNc2V0YkJJL0xZZ0x3eURWSC9Gc1B1Wndp?= =?utf-8?B?QWpVMUU4YmdVdHFpeG80dXROY0pwVkM0T25ENVZZa3ozK1cwem5yWUNQcmpS?= =?utf-8?B?ZkQ1NmJGM2dNNU9lMEpKWStKN3RGMDljTFpKQUtNN3VsWUJwMWE2NzFveUo3?= =?utf-8?B?cDBROGRGRGNoR3FaNkphTTVNYitvZ3EzZEwrTVlvZ0xvdFFwRmhZdTVhZkUy?= =?utf-8?B?V0FPRmIxRDViWkdrbW1zbHJzeWNRcjNMMjZyS0FJVWx4MkFTMDFsUHRjRXJa?= =?utf-8?B?UjRZb1NVaitZMDhOQzMvM0xFNnc2YlNMMGR6R2VQeGI4TXBFcVpPaGh0L3ZD?= =?utf-8?B?MitTdHN1K05tK25TbkZFMmNxaWg5d0dYWlRwbjMyS3RlUmw3bHJBRmY3NkFD?= =?utf-8?B?Kytock1SSTRZTUlJR0xtM25maVRacEFWd0dNcDFxaTF2YnJEQnc5UHRuZlJG?= =?utf-8?B?QVBlenJXd1ZUZUpmVlpoTG1NVE41OG00eFFEN2VGZFdUV1gwcE1aUjBoV0kw?= =?utf-8?B?YWJpSGc2Tm40TVVldVpsK0ttc3lXakhBRGR5eFlrQmQ0dFBPdGdwL1AxZDhE?= =?utf-8?B?dHJVVk12aEdKd0lSa3dZK0RIaXRGOWFKNmhKemRSRjRkbDBwek9pcXhueVJQ?= =?utf-8?B?VWp6NWhBOFhiSU5SWmF1NjFEMmZqeXUyeHg0VGJWRS9BWHFINGg4SUJ0RWFO?= =?utf-8?B?cC9GWHFKYm1qZzFrUGcyYU84d2Zsd0ZhVlhoVTlhOVp3V05od3J2Yzg1MXph?= =?utf-8?B?T2pRMXVLMHFxYWkwZGR0WWIxNGtNc25YVXRQaHFpanE0dFFzU0o0bFBvQ0o2?= =?utf-8?B?SjdZOFhZclEyVVo4THIrYXl1RTRFTzNUaWNHam0wODI3TFlYUWtreW1ZUU9O?= =?utf-8?B?UFRtOTRQdmQ0cXpWM2RzTnJaaExDN2J3YWZNTko3QjEwOWplS1RtSy9McGM4?= =?utf-8?B?ZFEzMXNRcnhQSGRqSzY0eitaS3hvUU1ZOUl0RWVPSUZlTXdVQXBiZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba013c58-5bf0-435c-5976-08def25fcbcf X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 19:37:18.9686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4jxL75zvnbgXF/nEZh+ly7yKjUzjrJO30RGES9vgdH+ARu0vC0RO1PoUCI4dfQDiw1WPzY221OWGPL1SmM0UfHzRjgL1BmrcteW/5c1ULeE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN7PR03MB283467 X-purgate-ID: tlsNG-16d1c6/1785872242-FE07177B-45415424/0/0 X-purgate-type: clean X-purgate-size: 11712 On 03/08/2026 5:03 pm, Jan Beulich wrote: > On 03.08.2026 09:20, Andrew Cooper wrote: >> --- /dev/null >> +++ b/tools/tests/x86-decode-lite/insns.S >> @@ -0,0 +1,703 @@ >> +#include "macro-magic.h" >> + >> + .code64 >> + >> + .allow_index_reg >> + >> + .text >> + >> +DECL(tests_rel0) >> +modrm: >> + /* Mod=0, Reg=0, RM {0..f} */ >> + _ add %al, (%rax) >> + _ add %al, (%rcx) >> + _ add %al, (%rdx) >> + _ add %al, (%rbx) >> + _ add %al, (%rsp) /* SIB */ >> + /*add %al, (%rbp) RIP --> tests_rel4 */ >> + _ add %al, (%rsi) >> + _ add %al, (%rdi) >> + _ add %al, (%r8) >> + _ add %al, (%r9) >> + _ add %al, (%r10) >> + _ add %al, (%r11) >> + _ add %al, (%r12) /* SIB */ >> + /*add %al, (%r13) RIP --> tests_rel4 */ >> + _ add %al, (%r14) >> + _ add %al, (%r15) >> + >> + /* Mod=1, Reg=0, RM {0..f} */ >> + _ add %al, 0x01(%rax) >> + _ add %al, 0x01(%rcx) >> + _ add %al, 0x01(%rdx) >> + _ add %al, 0x01(%rbx) >> + _ add %al, 0x01(%rsp) /* SIB */ >> + _ add %al, 0x01(%rbp) >> + _ add %al, 0x01(%rsi) >> + _ add %al, 0x01(%rdi) >> + _ add %al, 0x01(%r8) >> + _ add %al, 0x01(%r9) >> + _ add %al, 0x01(%r10) >> + _ add %al, 0x01(%r11) >> + _ add %al, 0x01(%r12) /* SIB */ >> + _ add %al, 0x01(%r13) >> + _ add %al, 0x01(%r14) >> + _ add %al, 0x01(%r15) >> + >> + /* Mod=2, Reg=0, RM {0..f} */ >> + _ add %al, 0x7f000001(%rax) >> + _ add %al, 0x7f000001(%rcx) >> + _ add %al, 0x7f000001(%rdx) >> + _ add %al, 0x7f000001(%rbx) >> + _ add %al, 0x7f000001(%rsp) /* SIB */ >> + _ add %al, 0x7f000001(%rbp) >> + _ add %al, 0x7f000001(%rsi) >> + _ add %al, 0x7f000001(%rdi) >> + _ add %al, 0x7f000001(%r8) >> + _ add %al, 0x7f000001(%r9) >> + _ add %al, 0x7f000001(%r10) >> + _ add %al, 0x7f000001(%r11) >> + _ add %al, 0x7f000001(%r12) /* SIB */ >> + _ add %al, 0x7f000001(%r13) >> + _ add %al, 0x7f000001(%r14) >> + _ add %al, 0x7f000001(%r15) >> + >> + /* Mod=3, Reg=0, RM {0..f} */ >> + _ add %al, %al >> + _ add %al, %cl >> + _ add %al, %dl >> + _ add %al, %bl >> + _ add %al, %ah >> + _ add %al, %ch >> + _ add %al, %dh >> + _ add %al, %dl > Perhaps also include %bpl, %sil, and %dil? They're not relevant to this test, and interfere with the intentional pattern set up. > >> +onebyte_row_9x: >> + _ nop >> + _ pause >> + _ xchg %ax, %ax >> + _ xchg %eax, %eax >> + _ xchg %rax, %rax >> + _ rex.w xchg %rax, %rax >> + _ cltq >> + _ cqto >> + _ wait >> + _ pushf >> + _ popf >> + _ sahf >> + _ lahf >> + >> +onebyte_row_ax: > May I suggest onebyte_row_Ax? Ok. > >> +DECL(tests_rel1) >> +disp8: >> +1: >> + _ jo 1b >> + _ jno 1b >> + _ jb 1b >> + _ jae 1b >> + _ je 1b >> + _ jne 1b >> + _ jbe 1b >> + _ ja 1b >> + _ js 1b >> + _ jns 1b >> + _ jp 1b >> + _ jnp 1b >> + _ jl 1b >> + _ jge 1b >> + _ jle 1b >> + _ jg 1b >> + _ jmp 1b >> + >> +disp8_rex: >> + _ rex.w jo 1b >> + _ rex.w jno 1b >> + _ rex.w jb 1b >> + _ rex.w jae 1b >> + _ rex.w je 1b >> + _ rex.w jne 1b >> + _ rex.w jbe 1b >> + _ rex.w ja 1b >> + _ rex.w js 1b >> + _ rex.w jns 1b >> + _ rex.w jp 1b >> + _ rex.w jnp 1b >> + _ rex.w jl 1b >> + _ rex.w jge 1b >> + _ rex.w jle 1b >> + _ rex.w jg 1b >> + _ rex.w jmp 1b >> +END(tests_rel1) > What's the idea behind the separate REX.W testing? Testing osize handling vs Imm8/Imm. > It almost suggests that > tests with an operand size prefix also may want adding. Except that's > difficult, because of ... > >> +DECL(tests_rel4) >> +disp32: >> + _ call other_section >> + _ jmp other_section >> + _ jo other_section >> + _ jno other_section >> + _ jb other_section >> + _ jae other_section >> + _ je other_section >> + _ jne other_section >> + _ jbe other_section >> + _ ja other_section >> + _ js other_section >> + _ jns other_section >> + _ jp other_section >> + _ jnp other_section >> + _ jl other_section >> + _ jge other_section >> + _ jle other_section >> + _ jg other_section >> + _ xbegin other_section >> + >> +disp32_rex: >> + _ rex.w call other_section >> + _ rex.w jmp other_section >> + _ rex.w jo other_section >> + _ rex.w jno other_section >> + _ rex.w jb other_section >> + _ rex.w jae other_section >> + _ rex.w je other_section >> + _ rex.w jne other_section >> + _ rex.w jbe other_section >> + _ rex.w ja other_section >> + _ rex.w js other_section >> + _ rex.w jns other_section >> + _ rex.w jp other_section >> + _ rex.w jnp other_section >> + _ rex.w jl other_section >> + _ rex.w jge other_section >> + _ rex.w jle other_section >> + _ rex.w jg other_section >> + _ rex.w xbegin other_section > ... vendor differences here. Perhaps the decoder itself would better > reject handling of operand-size-prefixed branches. Excluding 66-prefix is easy, but excluding rex.w on jumps is hard and would require extra logic. >> +opsize_branch: /* 66-prefixed branches are decoded differently by vendors */ >> + _ data16 call other_section >> + _ data16 jmp other_section >> + _ data16 jo other_section >> + _ data16 jno other_section >> + _ data16 jb other_section >> + _ data16 jae other_section >> + _ data16 je other_section >> + _ data16 jne other_section >> + _ data16 jbe other_section >> + _ data16 ja other_section >> + _ data16 js other_section >> + _ data16 jns other_section >> + _ data16 jp other_section >> + _ data16 jnp other_section >> + _ data16 jl other_section >> + _ data16 jge other_section >> + _ data16 jle other_section >> + _ data16 jg other_section >> + _ data16 xbegin other_section > Oh, you even cover the case here. For XBEGIN, however, this can only be pure > guesswork as to AMD behavior, I suppose. Remember that RTM is available on Zen2 if you know which chickenbits to clobber. I've not tried.  I expect it's more likely that they behave consistently than differently. > I also don't see how you force which form you want. Binutils always produces AMD behaviour.  (As far as I can see.) This is in the negative-tests section, which confirms that x86_decode_lite() rejects the byte pattern. If Binutils changes behaviour, the test will start failing. > >> --- /dev/null >> +++ b/tools/tests/x86-decode-lite/main.c >> @@ -0,0 +1,111 @@ >> +/* >> + * Userspace test harness for x86_decode_lite(). >> + */ >> +#include >> + >> +#include "x86-emulate.h" >> + >> +static unsigned int nr_failures; >> +#define fail(t, fmt, ...) \ >> +({ \ >> + const unsigned char *insn = (t)->ip; \ >> + \ >> + nr_failures++; \ >> + \ >> + (void)printf(" Fail '%s' [%02x", (t)->name, *insn); \ >> + for ( unsigned int i = 1; i < (t)->len; i++ ) \ >> + printf(" %02x", insn[i]); \ >> + printf("]\n"); \ >> + \ >> + (void)printf(fmt, ##__VA_ARGS__); \ >> +}) >> + >> +struct test { >> + const char *name; >> + void *ip; >> + unsigned long len; >> +}; >> + >> +extern const struct test >> +/* Defined in insns.S, ends with sentinel */ >> + tests_rel0[], /* No relocatable entry */ >> + tests_rel1[], /* disp8 */ >> + tests_rel4[], /* disp32 or RIP-relative */ >> + tests_unsup[]; /* Unsupported instructions */ >> + >> +static inline void run_tests(const struct test *tests, unsigned int rel_sz) >> +{ >> + printf("Test rel%u\n", rel_sz); >> + >> + for ( unsigned int i = 0; tests[i].name; ++i ) >> + { >> + const struct test *t = &tests[i]; >> + x86_decode_lite_t r; >> + >> + /* >> + * Don't end strictly at t->len. This provides better diagnostics if >> + * too many bytes end up getting consumed. >> + */ >> + r = x86_decode_lite(t->ip, t->ip + /* t->len */ 20); > For the excess bytes to at least be legitimate to access (not causing UB), > shouldn't finish_arr emit enough filler bytes? finish_arr is the wrong place, but I've folded in: diff --git a/tools/tests/x86-decode-lite/insns.S b/tools/tests/x86-decode-lite/insns.S index e52c2934c8d8..dc017016b2d2 100644 --- a/tools/tests/x86-decode-lite/insns.S +++ b/tools/tests/x86-decode-lite/insns.S @@ -695,6 +695,13 @@ unsup_insn: /* Instructions that would complicated decode, or shouldn't be used    END(tests_unsup)   +        /* +         * For improved diagnostics, we allow some overreading of the +         * instruction under test.  Ensure there are good bytes to read. +         */ +overread_padding: +        .skip 20 +          /* This is here to cause jmps to use their disp32 form. */          .section .text.other_section, "ax", @progbits  other_section: > >> --- /dev/null >> +++ b/tools/tests/x86-decode-lite/x86-emulate.h >> @@ -0,0 +1,27 @@ >> +#ifndef X86_EMULATE_H >> +#define X86_EMULATE_H >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> + >> +#include >> + >> +#define ASSERT assert >> + >> +#define printk(...) >> + >> +#define likely >> +#define unlikely >> +#define cf_check >> +#define init_or_livepatch >> +#define init_or_livepatch_const >> + >> +#include "x86_emulate/x86_emulate.h" > Why does this end up being needed? Well, this for starters: main.c: In function ‘run_tests’: main.c:43:9: error: unknown type name ‘x86_decode_lite_t’    43 |         x86_decode_lite_t r;       |         ^~~~~~~~~~~~~~~~~ main.c:49:13: error: implicit declaration of function ‘x86_decode_lite’ [-Werror=implicit-function-declaration]    49 |         r = x86_decode_lite(t->ip, t->ip + /* t->len */ 20);       |             ^~~~~~~~~~~~~~~ ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 04 20:06:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 20:06:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382629.1625973 (Exim 4.92) (envelope-from ) id 1wrLPI-0004Tg-7H; Tue, 04 Aug 2026 20:06:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382629.1625973; Tue, 04 Aug 2026 20:06:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrLPI-0004TZ-4m; Tue, 04 Aug 2026 20:06:36 +0000 Received: by outflank-mailman (input) for mailman id 1382629; Tue, 04 Aug 2026 20:06:34 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrLPF-0004TR-8T for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 20:06:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrLPE-001eg9-Lb for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 22:06:32 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72462c-e002-0a2a0a5209dd-0a2a45069ecc-10 for ; Tue, 04 Aug 2026 22:06:31 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a724376-195a-0a2a45060019-5a9b3222c75a-3 for ; Tue, 04 Aug 2026 21:54:31 +0200 Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrLDN-00000004dyG-3Yfn; Tue, 04 Aug 2026 19:54:17 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0A184300B40; Tue, 04 Aug 2026 21:54:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+IzxgHirXh8bANHLHHneykwXTiWqinCHzwnsN/D+w1g=; b=cgc/4q5XWxb+9KHledOTiCkjCj qq0/2fvaHG7Qp83Vg+3/fUN0X2kukF2LFGusGOYQrH0obYRDUEtgSeWR3tr+4dGHM1+rpu/rLQ1Tk 0IRno6TRcPM9AAut3SiFQbVeIH55/1SLk/L57s2QIePicpmXv8BSEr/7MiSgs+DW6OKfkUVq4xyWW f/Bg3OJHFn/zCKQb5ODfDBLhY5WYJ9QRUlrhLWFVC+XuxtxkMtKKJouvX0pcB5x+VcFKNyhAxS7MJ mm2BbOwBUTRRIZYT5+BtfzMIOia+PY04wvaF7AiNa2bNuOBjcNm1RZO5LghLrrQ4rMN1nlxylF5zK 0KLtQp6A==; Date: Tue, 4 Aug 2026 21:54:16 +0200 From: Peter Zijlstra To: Borislav Petkov Cc: Dmitry Ilvokhin , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Thomas Bogendoerfer , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Paolo Bonzini , Vitaly Kuznetsov , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Boris Ostrovsky , Arnd Bergmann , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/5] x86/paravirt: Use static_call() for the paravirt spinlock ops Message-ID: <20260804195416.GJ776954@noisy.programming.kicks-ass.net> References: <9a32ae399eb804a02a31af04dcabe7e7ee4f3fdf.1785778551.git.d@ilvokhin.com> <20260804190048.GCanI24Hb5P8qAyVZs@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804190048.GCanI24Hb5P8qAyVZs@fat_crate.local> X-purgate-ID: tlsNG-16d1c6/1785873271-FEA7477B-2DE99309/13/0 X-purgate-type: clean X-purgate-size: 3811 On Tue, Aug 04, 2026 at 12:00:48PM -0700, Borislav Petkov wrote: > On Tue, Aug 04, 2026 at 07:15:41AM +0000, Dmitry Ilvokhin wrote: > > From: Peter Zijlstra > > > > queued_spin_lock_slowpath() and queued_spin_unlock() are dispatched > > through pv_ops_lock via the paravirt-ops ALTERNATIVE machinery, which > > picks the target (native inline store / hypervisor call) once at boot > > and cannot change at runtime. > > > > Convert both to static_call(). The site becomes a direct call patched in > > place (one byte smaller), and on native the unlock still collapses to > > the inline "movb $0, (%rdi)" store, so the fast path is unchanged. > > > > Unlike the ALTERNATIVE mechanism, a static_call() target can also be > > updated at runtime via static_call_update(). This is a prerequisite for > > the contended_release tracepoint, which has to swap in a traced unlock > > while the system is running. > > > > [ ilvokhin: commit message; fix PARAVIRT_SPINLOCKS=n build; teach > > __static_call_validate() about the inline unlock insn; make the > > slowpath site module-safe: static_call_mod() + > > EXPORT_STATIC_CALL_TRAMP(); pass @lock to the callee-save unlock, > > fixing a boot hang under CALL_DEPTH_TRACKING. Boot tested native + KVM > > PV guest. ] > > > > Link: https://lore.kernel.org/all/20260603120811.GW3493090@noisy.programming.kicks-ass.net/ > > Co-developed-by: Dmitry Ilvokhin > > Signed-off-by: Dmitry Ilvokhin > > This needs Peter's SOB. Yeah, that got fixed when I applied it ;-) > > --- > > arch/x86/hyperv/hv_spinlock.c | 4 ++-- > > arch/x86/include/asm/cpufeatures.h | 1 - > > arch/x86/include/asm/paravirt-spinlock.h | 19 +++++++++++------ > > arch/x86/kernel/kvm.c | 5 ++--- > > arch/x86/kernel/paravirt-spinlocks.c | 12 +++++------ > > arch/x86/kernel/static_call.c | 27 ++++++++++++++++++++++++ > > arch/x86/xen/spinlock.c | 5 ++--- > > tools/arch/x86/include/asm/cpufeatures.h | 1 - > > 8 files changed, 51 insertions(+), 23 deletions(-) > > > > diff --git a/arch/x86/hyperv/hv_spinlock.c b/arch/x86/hyperv/hv_spinlock.c > > index 210b494e4de0..6b4bdea18218 100644 > > --- a/arch/x86/hyperv/hv_spinlock.c > > +++ b/arch/x86/hyperv/hv_spinlock.c > > @@ -78,8 +78,8 @@ void __init hv_init_spinlocks(void) > > pr_info("PV spinlocks enabled\n"); > > > > __pv_init_lock_hash(); > > - pv_ops_lock.queued_spin_lock_slowpath = __pv_queued_spin_lock_slowpath; > > - pv_ops_lock.queued_spin_unlock = PV_CALLEE_SAVE(__pv_queued_spin_unlock); > > + static_call_update(queued_spin_lock_slowpath, __pv_queued_spin_lock_slowpath); > > + static_call_update(queued_spin_unlock, __raw_callee_save___pv_queued_spin_unlock); > > pv_ops_lock.wait = hv_qlock_wait; > > pv_ops_lock.kick = hv_qlock_kick; > > pv_ops_lock.vcpu_is_preempted = PV_CALLEE_SAVE(hv_vcpu_is_preempted); > > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > > index 1b4a48bff18f..e41fe5c24841 100644 > > --- a/arch/x86/include/asm/cpufeatures.h > > +++ b/arch/x86/include/asm/cpufeatures.h > > @@ -225,7 +225,6 @@ > > #define X86_FEATURE_EPT_AD ( 8*32+17) /* "ept_ad" Intel Extended Page Table access-dirty bit */ > > #define X86_FEATURE_VMCALL ( 8*32+18) /* Hypervisor supports the VMCALL instruction */ > > #define X86_FEATURE_VMW_VMMCALL ( 8*32+19) /* VMware prefers VMMCALL hypercall instruction */ > > -#define X86_FEATURE_PVUNLOCK ( 8*32+20) /* PV unlock function */ > > No, do: > > /* free: was #define X86_FEATURE_PVUNLOCK ( 8*32+20) /* PV unlock function */ > > so that we can reuse it by finding it easier. Sure, I can do that. From xen-devel-bounces@lists.xenproject.org Tue Aug 04 21:41:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 21:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382653.1625982 (Exim 4.92) (envelope-from ) id 1wrMsd-0008Ml-PC; Tue, 04 Aug 2026 21:40:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382653.1625982; Tue, 04 Aug 2026 21:40:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrMsd-0008Me-LE; Tue, 04 Aug 2026 21:40:59 +0000 Received: by outflank-mailman (input) for mailman id 1382653; Tue, 04 Aug 2026 21:40:58 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrMsc-0008MY-2z for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:40:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrMsb-001obd-6Z for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 23:40:57 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a725c2a-2eae-0a2a0a5409dd-0a2a450487ba-44 for ; Tue, 04 Aug 2026 23:40:57 +0200 Received: from [74.125.224.47] (helo=mail-yx1-f47.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a725c68-b57f-0a2a45040019-4a7de02fbd12-3 for ; Tue, 04 Aug 2026 23:40:57 +0200 Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-669944f5ef1so302167d50.1 for ; Tue, 04 Aug 2026 14:40:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1785879655; cv=none; d=google.com; s=arc-20260327; b=g36Z68Wwbq2TXta0huJSzjGl+bhGBcD2EFjefRfbqycj6X6JaZ+yp9QWAxYBJHkW4B obuxWqfKz5sMs0hl9/BzcapFVmySqUAbEtO4PQ4EHTMLhQCP2e/DpO8/UyKyU6RFteRY MtJXaGw0M4P/xev9yK0KYBj2E6/yAYuC5w8Itdxd2R54YVGdvkH7ysIVaK0Nl2WnSBbb ZLhNPiB1FDpC1f7nHlXp5C5HRR7aD2eHsYKFfyQURDM0bGb/64yfLsLck9hPeKN8QVEh M9iTHyUnpqG1gGCP02yDnpnaf6/X/k4d7J2lsTuKjfS8Q8FWaIV4mYJHckBvadX9iEnR M8QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=sUP90bFdYVViBJwMVU0ncUeotpyeUeVbV/REZdSDfEg=; fh=K9IAd8BUey1PZ/zoeGTbn1ETVLXZhvAgW6PCZb/WSCU=; b=PnSMeV0tNNIU72qLKz4gKYb+ihNbTjXp+EBL/BRfoXbrLW1UbeENhZ/8g+Iwuu3pNV ZqNJs2SDNse1ED0kCgbSfpHcUC39ScrfeBWHZZI42GdkHoe6bwt8fgev4ZKgkGh2Z2IA XBOBv8oOKI+3nDimCzvvn3SLhcyYAV1nlH4V/jTopS/OOdWIbZjOIYIiw/9eFZ5oblMa jIoxe7AUUAXdSaAh1LnhU+PscieyXEJbCyV1ElgIKelKDL52OtNUAwyiIfarQm+MQY2H fhCP2RY8i4gXtJdriPN5ogCPEflCNPYN9thPnm+dV/MGtVsYvUZPmoZie5wb0m1x0VPw BcXA==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785879655; x=1786484455; darn=lists.xenproject.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sUP90bFdYVViBJwMVU0ncUeotpyeUeVbV/REZdSDfEg=; b=HGXP0+GmRqgqY7wih4hjQo0WG8iDs4T+MH/XXM+RgUbbY6jjqne+7KysjimYmi+Peo YcFneXnt4HIBBRMx7dRH7awBEiflpVr9MhP7LbPj0jyGi4sOpeCKVd6ATedg5r0BS4bC GwG3ukrh8Knae5FYx+Y7peWWofSr5fKaI0/UfPbfxd4aZEt9xjAJj6/TSl/0njLF0r+E nBQneR6Ws9jr/qLUqHpQwRucYHC6Nx76/655tYKTJlH6wrEwNdP252GUjcRn+Jc1A3Bf +qucN4rOYuBk0WXtkeFC/eCA8B8Wg7gUoD9ESasaFH5XsWvEP7/okuZ79wubqmpuwQxk 64HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785879655; x=1786484455; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=sUP90bFdYVViBJwMVU0ncUeotpyeUeVbV/REZdSDfEg=; b=SQ5zvTDhCZQtGKgJo1wecctnICiZLeZyXiGAXUOoaqGTSQ1KX6CVCf09vYEVe/hfuu 2qwVf4TqLMRX+zmiv+PO3GtUeMpmUXchcwEU4a14IJG74Heai4aAZjTjEUyhZEiUA893 vptrSREgSD4ohsZbQqDVBhVLcf7vUnnHuDs086aV+PO2Gi2/8dK16dOO11TrE5qhgWqZ wAo/fxGbolL19my4eUWkxjpcJt62IXn1C3g6B8VStYJCt3vFG4HEDDJZXekHMCWuUKFI 2hwkVa2Uf+YjOJDGXRCioX7efS5jrshMDhczZtKSkaRpQXqGkRpL6/Sr/GqRoxL1P6e8 w5Eg== X-Gm-Message-State: AOJu0Ywcd0LZ/KH/S4W7BDyakQdcpesO0A4PYBx9uX5DDKbCc3/JT8J7 D3JSscn6/w2LKeAjwyBs7J0NDQFa/4M1uw2AOz/Td97DH2Ygby9j+hqrvPTn1SmX+2IfmEL0Gle oY7tT2TYVvZ6cw43U/OjBKcNXiYhKBLQ= X-Gm-Gg: AR+sD13BvMb80n+QmJf+uZZhY08LIZE7iFGsUFJUVDUO0auVvs9I45347W8gFbHjRIM I0RiFwqp73YZ5FSkmj1AiwxqfwoqKj1/55jJaFjB8c+a6QlNLa4Amu5wPYy7OWTem/OtC6UoLmn ew0Z+a5IeCznAbLXB3bytJOnEMOv93KWG1rSkTmzXv0b1GgpvePbRkxvcGvJBYPn6UjyEcPZomm vdx76bpDM5YiwgUhpnzfQlAXNnjd7yihReV58Z7G9iR7oaTGoU/oNi3r49cXaC8EdGq1E9YTZKx 8Lt2lkqkjED8pnu0IYbV6Nl/t85byOIUUzp42WsY1SfaW0K2mXbda5JMcZGgUXrSppfsWs71GIu h X-Received: by 2002:a53:b543:0:b0:667:e04a:8a3f with SMTP id 956f58d0204a3-6699a919d86mr969713d50.5.1785879655484; Tue, 04 Aug 2026 14:40:55 -0700 (PDT) MIME-Version: 1.0 References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-2-frediano.ziglio@citrix.com> <1785871743.8631fc262581453bbf619ec5b2062170.19fce4038dd000e099@vates.tech> In-Reply-To: <1785871743.8631fc262581453bbf619ec5b2062170.19fce4038dd000e099@vates.tech> From: Frediano Ziglio Date: Tue, 4 Aug 2026 22:40:44 +0100 X-Gm-Features: AUfX_mxHyihNtyDMkBfWJHdz09e80hO9TOwHB81ucSm2D6hWkksFcqiOiVQvCaw Message-ID: Subject: Re: [PATCH 1/2] CI: Simplify directories creation To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1785879657-536C2B50-9A16AF3D/0/0 X-purgate-type: clean X-purgate-size: 2001 On Tue, 4 Aug 2026 at 20:29, Anthony PERARD wrote: > > On Tue, Aug 04, 2026 at 06:42:17PM +0100, Frediano Ziglio wrote: > > diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh > > index 242ffca693..60f5cc49fc 100755 > > --- a/automation/scripts/qemu-alpine-x86_64.sh > > +++ b/automation/scripts/qemu-alpine-x86_64.sh > > @@ -4,16 +4,7 @@ set -ex -o pipefail > > > > # DomU Busybox > > cd binaries > > -mkdir -p initrd > > -mkdir -p initrd/bin > > -mkdir -p initrd/sbin > > -mkdir -p initrd/etc > > -mkdir -p initrd/dev > > -mkdir -p initrd/proc > > -mkdir -p initrd/sys > > -mkdir -p initrd/lib > > -mkdir -p initrd/var > > -mkdir -p initrd/mnt > > +mkdir -p initrd/{bin,sbin,etc,dev,proc,sys,lib,var,mnt} > > This makes it really hard to find out if more directory or less > directory are been created. When reviewing a patch, we don't see what > changed in a line without using more complex tools. > > For this patch, I have now idea at a glimpse if all the directory that > was created before are still created. > > In the future, we might need to create more directories, this would > change on very long line to another, and make it hard to find out what > was the logical change, by just looking at the output of `diff -u`. > > So I don't see this patch as an improvement. > > But that just my opinion, but that would apply equally to other similar > changes, like packing all the variable declaration on a single line in C. > > Cheers, > Hi, what about putting the directory names in alphabetical order? Either in multiline or in the concise single line? In both cases it makes it easier to check if it's already there. Or something like mkdir -p binaries/initrd cd binaries/initrd mkdir -p \ bin \ dev \ etc \ lib \ mnt \ proc \ sbin \ sys \ var cd .. Regards, Frediano From xen-devel-bounces@lists.xenproject.org Tue Aug 04 21:59:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 21:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382660.1625990 (Exim 4.92) (envelope-from ) id 1wrNA7-0001nQ-3T; Tue, 04 Aug 2026 21:59:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382660.1625990; Tue, 04 Aug 2026 21:59:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrNA7-0001nJ-0x; Tue, 04 Aug 2026 21:59:03 +0000 Received: by outflank-mailman (input) for mailman id 1382660; Tue, 04 Aug 2026 21:59:02 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrNA6-0001nC-DA for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:59:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrNA4-001qb7-7a for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 23:59:00 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7260a4-2eae-0a2a0a5409dd-0a2a4507d66c-0 for ; Tue, 04 Aug 2026 23:59:00 +0200 Received: from [74.125.224.45] (helo=mail-yx1-f45.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7260a3-b4ea-0a2a45070019-4a7de02de46f-3 for ; Tue, 04 Aug 2026 23:58:59 +0200 Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-664ce3000e6so295227d50.0 for ; Tue, 04 Aug 2026 14:58:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1785880738; cv=none; d=google.com; s=arc-20260327; b=ocwEMswJr5/W5jBxixVcX9Vd3b+FhPofoJmEYAiNFQyfGRTh71cegqBR45pfB2aCbs Yd3DF+y0uLpYGPXvTnKifMd9Fe2kc1JtpS7lLwflnPcIX9RA8MI+lzmOA6Tb90xqCAyV WgwG1dfgZJR6FjsU3ze5MxjQlJccsPpLzD+7aUIpzemPbJQGA69CR4mWAaIIK56JwFoh 4ym3GMqE14g5gnjiCz9F3Xrrj7kl9XQjDa5TxX7fVx6SOFNVdV2nn3kfQB5Ir4Hx7Q6Q pObIl98p/v/FWdGauZbou7ik/vl/wH2k5d3orixcKi3tghSLzp3s1W2dbyCocSEmUmVy oFQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rVNb0qH2KaqSSA1wdzQ35ti5zCobKv53Fc4eqYo5Z2E=; fh=S7vaYQF6ldLkXu1uh42X3MXXcRRChuuDlJZSyF3Eswo=; b=npzm6QPk7iYEhS0tnki6E4Y6MwXEiwYqwRdGk+cLPOETYv8A8SiqhxfPcM7woiBfE5 Kbh7ovsCXSd96EgC6Gxy9eWTaEmEhXBpv35PQxXdCkjFoDI6VEcZcoYZd5PmSH2+pGDu 29phw1nsS4oRPsuKpr27YZ7s0xnujt9vKfXrhCkS534e+nlMlPW12NP8yKQB9sMKba+Q oS5oGT6Lc/heUAm19s3zI5qr5mxUKOcEVVwS331OUSF4TYRFq9/nF+vWvXC0Z+Pkvjks o5NTaYxss+v3APe5k+gjT8R+RU0jqs3LoCOJdCGl3z4rUcQjUnAyo2f5puJtdWYme+yZ p7IQ==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785880738; x=1786485538; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rVNb0qH2KaqSSA1wdzQ35ti5zCobKv53Fc4eqYo5Z2E=; b=lGryzvdd4RipRBZWPyiGBo7dA+b13Z21+Rpdy/LqRqPp5JP+txPJNrPXVnMC6ZCrMf lTlqcTy9bdmE9m6vqPXrkFzFYkUcCvc7wuTDL+caPznj2YgjfXDntY1YFmzddkn21xAx uyWlnhYkyC4uxEO1XyxvKt2hp5OqL/BL0ytmEROhvnjQ9SBDM2yIg2p8z2+5J6fx/o5/ qEgu6fmx5a7DSXyV4qRAM5RBRPskeyJx4gqjrvmoa/h3lSYl6lSDEjcpY83RkJSSzvfL HfGEEjoDWXDSloBwycLjQtS4EHEUKk3eT7mY+RRC5/BqkJQyIhCxAGxqd5YSlBvk+NHY rdIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785880738; x=1786485538; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rVNb0qH2KaqSSA1wdzQ35ti5zCobKv53Fc4eqYo5Z2E=; b=LOSV7/4rwDsR5Q2QPFtCwp0uJMbWcdEk2aki25pVcoEKU2FYKr/d+zZRVRW27C5pEm 1vLubSNTxL38UcWVRxnEhmQfTFdpXTozXI/UvFjkVgjUcl+iyYGuctInrteAVXklL677 svJz6rDeiSmKl+D4p82+gNXxrYOBGi1bw1fHJqjuVjDZXU0Xd7xWBPTl4MivT5cQbNvU VXzB3c+YiVr4+49EmJWAIxFaUplzek76xlsPBu7gTYM6drnmJJtRH1rKAD+11vnkeOY1 RcnsfwuvhPr2ssbeCYeY1fa9Xss4SFPPUUBZG2aKFPAM4KxK9SJRd0KxePsILm7q2rSs C8GA== X-Forwarded-Encrypted: i=1; AHgh+RrK1gTr2+xfklulqeShPslptjub+h9S24WhwEATbux6rXUhNzLZ397TB8sGzejQzYVKmWEwKvigGos=@lists.xenproject.org X-Gm-Message-State: AOJu0YzJ3GwHYjinGC59vD8ic0AiMzWJJIU0Phi57lp0F1oHt70999Yp oZp/OYzEwPVL9lWYYhi+hUv44vLNZ90e9R8lR7ijYdTTtrdJlL7+MSRZV6o1hn19S9kKxSKbWau MEl2km1+SbYuRXqBJh3PUtmnRitFfRFA= X-Gm-Gg: AR+sD123g1DZ4DR9fcjTs71xkvjwAFnnMYuomTDvQbY3xb1twfxbRvP0YB/KJWTyOTC JEW/vg77W5cQP6c5sCI1gkyFE+0q1VD+7pgxWHW/bHTkXZHir2WQAbGfl2SECStHwAEPFuQkEdi Q1o07Ehud2HPehwHHG54EMJvU8NTCFzEIiRuMUmUJVyIQtItX3qWIhRaXtpM1jsZK59PDyyNEOz /yKaOyJz5xVOctYnbQihIotYTFvSsVTUl6MAEADVVCMS+eevas/NWBSebhmhzQfp2fbsB7uTmry D4IVCmpxAJg4VfniMH987VzbymFgz2aZCv9TW4JKJaZX06AWi/fVRc3OieziA/6G7u+Nh3ygjwC sHyqJpjKXI3s= X-Received: by 2002:a05:690e:454b:20b0:667:be4a:4b5f with SMTP id 956f58d0204a3-6699aa26209mr991834d50.15.1785880738304; Tue, 04 Aug 2026 14:58:58 -0700 (PDT) MIME-Version: 1.0 References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-3-frediano.ziglio@citrix.com> <9dc1d91c-52e2-4cd9-a234-6d6ca6ecceb8@citrix.com> In-Reply-To: From: Frediano Ziglio Date: Tue, 4 Aug 2026 22:58:47 +0100 X-Gm-Features: AUfX_mzb93PcOca-QY5WJwRP4CkmwxCGy172nhyS-381muC9Oe8YoQ9qKC2mPWE Message-ID: Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ef75cf/1785880740-34AC8AE4-AFEBA6B6/0/0 X-purgate-type: clean X-purgate-size: 5514 On Tue, 4 Aug 2026 at 20:17, Marek Marczykowski-G=C3=B3recki wrote: > > On Tue, Aug 04, 2026 at 07:55:24PM +0100, Andrew Cooper wrote: > > On 04/08/2026 7:48 pm, Frediano Ziglio wrote: > > > On Tue, 4 Aug 2026 at 18:57, Marek Marczykowski-G=C3=B3recki > > > wrote: > > >> On Tue, Aug 04, 2026 at 06:42:18PM +0100, Frediano Ziglio wrote: > > >>> Make sure that save/restore continue to work. > > >>> The check save and restore twice to check for corrupted status. > > >>> Also a command is launched in the guest to make sure that the > > >>> machine is not crashed but working. > > >>> > > >>> Signed-off-by: Frediano Ziglio > > >>> --- > > >>> automation/scripts/console.exp | 8 +++++ > > >>> automation/scripts/qemu-alpine-x86_64.sh | 40 ++++++++++++++++++++= ++-- > > >>> 2 files changed, 46 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/automation/scripts/console.exp b/automation/scripts/co= nsole.exp > > >>> index e27886bbef..ff58ed29b8 100755 > > >>> --- a/automation/scripts/console.exp > > >>> +++ b/automation/scripts/console.exp > > >>> @@ -58,6 +58,14 @@ if {[info exists env(WAKEUP_CMD)]} { > > >>> system "$env(WAKEUP_CMD)" > > >>> } > > >>> > > >>> +if {[info exists env(EXPECT_TEXTS)]} { > > >>> + set lines [split "$env(EXPECT_TEXTS)" "\n"] > > >>> + foreach {exp snd} $lines { > > >>> + expect -re "$exp" > > >>> + send "$snd\n" > > >>> + } > > >>> +} > > >>> + > > >>> if {[info exists env(LOG_MSG)]} { > > >>> expect { > > >>> -notransfer -re "$env(PASSED)" { > > >>> diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/= scripts/qemu-alpine-x86_64.sh > > >>> index 60f5cc49fc..409a601c34 100755 > > >>> --- a/automation/scripts/qemu-alpine-x86_64.sh > > >>> +++ b/automation/scripts/qemu-alpine-x86_64.sh > > >>> @@ -48,6 +48,28 @@ xl -vvv create -c /root/domU.cfg > > >>> > > >>> " > etc/local.d/xen.start > > >>> chmod +x etc/local.d/xen.start > > >>> + > > >>> +# Script to test save and restore. > > >>> +# It saves and restores domU domain twice to check if the domain w= as corrupted > > >>> +# during the first sequence. > > >>> +# At the end open the console to check if the domain is working. > > >>> +cat > root/save_restore_test << "EOF" > > >>> +#!/bin/sh > > >>> +set -ex > > >>> +xl list | grep -q domU > > >>> +rm -f save.dat > > >>> +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat = /root/domU.cfg > > >>> +xl restore /root/domU.cfg save.dat > > >>> +xl list | grep -q domU > > >>> +rm -f save.dat > > >>> +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.dat = /root/domU.cfg > > >>> +xl restore /root/domU.cfg save.dat > > >>> +xl list | grep -q domU > > >>> +rm -f save.dat > > >>> +xl console "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" > > >>> +EOF > > >>> +chmod +x root/save_restore_test > > >>> + > > >>> find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz > > >>> cd ../.. > > >>> > > >>> @@ -70,9 +92,23 @@ export TEST_CMD=3D"qemu-system-x86_64 \ > > >>> -device virtio-net-pci,netdev=3Dn0 \ > > >>> -netdev user,id=3Dn0,tftp=3Dbinaries,bootfile=3D/pxelinux.0" > > >>> > > >>> +# Sequence of expect/send strings: > > >>> +# 1. wait domain start and close console; > > >>> +# 2. wait login prompt and login as root > > >>> +# 3. wait login and launch save/restore test; > > >>> +# 4. wait restore from domain console and send a command. > > >> Why doing this interactively over serial, instead of adding to > > >> etc/local.d/xen.start and then printing test result at the end? > > >> > > > I'm using expect to interact with the console. expect is not availabl= e > > > inside the alpine root filesystem. > > > Some failure I had during migration is that the VM crashed. In the > > > script I interact with the console to check that the VM is still able > > > to run commands. > > > > We can add `expect` to the dom0 root filesystem if we find a need for > > it, and it looks like this might be a good enough reason. You want a > > patch to https://gitlab.com/xen-project/hardware/test-artifacts > > images/alpine/*-x86_64-base.dockerfile to get it included. > > FWIW, my suspend test (which tests a similar thing) uses ping to check > if domU is still alive: > https://gitlab.com/xen-project/people/marmarek/xen/-/blob/2184be51d426b60= f5e1a7e6e891d0f40e9488fc7/automation/scripts/qemu-alpine-domU-suspend-x86_6= 4.sh > Are you going to upstream the test? Why sleep between commands? Worrying about possible races? Probably there should be no race after the command exited so I personally would remove. Using the network seems like a good idea. I also discovered that there is nc and bash installed so something like # nc -lk -p 8888 -e sh -c "echo Still alive" and # bash -c 'read -t 1 line < /dev/tcp/localhost/8888; echo $line' Still alive would even test if userspace is still working correctly > > > But, for migration testing, this really wants to run on the real > > hardware. Besides the main memory image, there's variations in registe= r > > state and validity which will vary between hardware. > Which scripts/jobs are run on real hardware (well, I suppose all that starts with zen, kbl, xilink or adl). Are they all run for every build? -- Frediano From xen-devel-bounces@lists.xenproject.org Tue Aug 04 21:59:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 21:59:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382661.1626000 (Exim 4.92) (envelope-from ) id 1wrNAG-00022P-A8; Tue, 04 Aug 2026 21:59:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382661.1626000; Tue, 04 Aug 2026 21:59:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrNAG-00022H-7M; Tue, 04 Aug 2026 21:59:12 +0000 Received: by outflank-mailman (input) for mailman id 1382661; Tue, 04 Aug 2026 21:59:11 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3q2ByagYKCZACyu73w08805y.w86Hy7-xyFy552CDC.Hy79B83ywD.8B0@flex--seanjc.bounces.google.com>) id 1wrNAE-00021L-Uk for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:59:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrNAE-00CrRL-00 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 23:59:10 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3q2ByagYKCZACyu73w08805y.w86Hy7-xyFy552CDC.Hy79B83ywD.8B0@flex--seanjc.bounces.google.com>) id 6a726056-bab6-0a2a0a5309dd-0a2a4504cbb2-18 for ; Tue, 04 Aug 2026 23:59:09 +0200 Received: from [209.85.215.200] (helo=mail-pg1-f200.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3q2ByagYKCZACyu73w08805y.w86Hy7-xyFy552CDC.Hy79B83ywD.8B0@flex--seanjc.bounces.google.com>) id 6a7260ac-b57f-0a2a45040019-d155d7c8d157-3 for ; Tue, 04 Aug 2026 23:59:09 +0200 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-ca7c1e22995so319660a12.3 for ; Tue, 04 Aug 2026 14:59:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785880748; x=1786485548; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Dhc7N1hQKet78fMxmoZ11biZ2HS+JiXgm3DEUzu8sT0=; b=GZlmgCQRiP6KXQ+vgOxzCfmpjphw57dNbEy14zZh2DGlqG1cuL2aWgJ+yYOjdict+C PvSKSWPHOByZPyZ1iluCRTj5Kme8SwkWq0T4ZWOqxc/bMVlDp+iR7oUYIGPe/zrMnKNN 6zmoQpcf9ZrBgu+bVW0Pbh8dOMJ2ZO/rbWTd8WjSLQyqWi7lefwJXxAj4vDnygjIHgvT w/NsqlamcssEibwoKhGE3+Mo/B3Pe4DmpvBypAoUDHqlbXEUanC+QLESYYV34D8iYfJS VB4/jhNgC4GwmnJuE5IS9YPugihkZrNpa8tgVxs4fL1BBSRVuDxiF1g/JtA6kHeSluur nL7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785880748; x=1786485548; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Dhc7N1hQKet78fMxmoZ11biZ2HS+JiXgm3DEUzu8sT0=; b=q8gLO3QgAMiQ0Bh+rrFpw7wovGISnZANjd0eqEqGpzluIiNnc1p3ueMcdo2IvGSIcP QLJgLUZa/bxSl0qriAXm5yyLAh/ASbG8MxLbZHvNzdkbl4ZMKdM91GlMoKexdLxBMny6 Mj/t7Hkh9XKaPe57ne0lRBdQXf2bfxxBL2ogJDFg/3sOtg6cV8tQHClEE+JsNSQplagE /bAKtMZPhcQQrLNdUXkgT5MwgP9bT0kA4djJVZBqqhvv7lGt2mGVpYei7byW+u2eYKos leWkG1rWE2jyP/u1FVOJHBfAToUZ1k/eIjEvpW/Odjg19gpXTTduioiZUHrkOzdvcpkv RjmA== X-Forwarded-Encrypted: i=1; AHgh+RqAFgfTLFt2F3KezkR9IRkUNwmPHtBl0bU18XkTcLHiQmvBrpAbHwdhYLgC67InEX40vnBUjHtuO3g=@lists.xenproject.org X-Gm-Message-State: AOJu0YyQyeh6Q9IXBlCTpfklPWNdbWfalFnIYoQmd+I59UTUEzeqjTOo bVwHar7Zz0eFEFOCGIyudbj+bQZC+7TNhOtPtyjln1ZTTQqryzLrUkHj/tbdg1UMPg0u7CV8Feq W8ikSOg== X-Received: from pgbdv13.prod.google.com ([2002:a05:6a02:446d:b0:c9a:3646:2398]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:998c:b0:3ba:cd5b:3dc8 with SMTP id adf61e73a8af0-3cb8603af30mr1757125637.31.1785880747446; Tue, 04 Aug 2026 14:59:07 -0700 (PDT) Date: Tue, 4 Aug 2026 14:59:06 -0700 In-Reply-To: Mime-Version: 1.0 References: <178552799129.2700794.10181439022561913222.b4-ty@google.com> <8b90851f38ef5b10cdcdc70e7543bd6b0b5e2773.camel@infradead.org> Message-ID: Subject: Re: [PATCH v6 00/36] Cleaning up the KVM clock mess From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-ebf023/1785880749-524CBB50-55F4180F/0/0 X-purgate-type: clean X-purgate-size: 1049 On Mon, Aug 03, 2026, Sean Christopherson wrote: > On Sat, Aug 01, 2026, David Woodhouse wrote: > > On Fri, 2026-07-31 at 13:09 -0700, Sean Christopherson wrote: > > > Applied patch 1 to kvm-x86 clocks. > > > > > > [01/36] KVM: x86/xen: Do not corrupt KVM clock in kvm_xen_shared_info_init() > > > https://github.com/kvm-x86/linux/commit/3d4b20b5a7df > > > > Thanks. Could the clocks branch be based on something that includes the > > timekeeping work from the timers-ptp-2026-06-13 merge (in v7.2-rc1)? > > Yeah, I can rebase onto a 7.2-rcN. Y'all are likely the only people that care > about the above commit, so a late rebase isn't a big deal. > > There's basically zero chance I'll get the entire series applied for 7.3, but > "Use ktime_get_snapshot_id() for master clock" is at least in striking distance, > so there's no reason not to allow for the possibility. New hash: [1/1] KVM: x86/xen: Do not corrupt KVM clock in kvm_xen_shared_info_init() https://github.com/kvm-x86/linux/commit/633d7652f80f From xen-devel-bounces@lists.xenproject.org Tue Aug 04 22:44:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 22:44:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382680.1626010 (Exim 4.92) (envelope-from ) id 1wrNrX-0000eT-Ph; Tue, 04 Aug 2026 22:43:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382680.1626010; Tue, 04 Aug 2026 22:43:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrNrX-0000eM-L7; Tue, 04 Aug 2026 22:43:55 +0000 Received: by outflank-mailman (input) for mailman id 1382680; Tue, 04 Aug 2026 22:43:54 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrNrW-0000eG-HY for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 22:43:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrNrU-001w5C-Lw for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 00:43:53 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a726b1d-5cb7-0a2a0a5109dd-0a2a450882c6-10 for ; Wed, 05 Aug 2026 00:43:52 +0200 Received: from [103.168.172.157] (helo=fhigh-a6-smtp.messagingengine.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a726b26-f659-0a2a45080019-67a8ac9db42f-3 for ; Wed, 05 Aug 2026 00:43:51 +0200 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id 71EA214000ED; Tue, 4 Aug 2026 18:43:50 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 04 Aug 2026 18:43:50 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Aug 2026 18:43:48 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1785883430; x=1785969830; bh=PBhPzA2xvYXBdzZGUAFISn9I3/g+BWXV5uO0PtXXq9g=; b= SzCu0Upv6WNBaN9gpFyLomh8ZtqoSP0Ow5OwA6dVxgg/2u2TXQqrcSah9OqPgZSz Le0P21RChZI1hVNDF+hxO+1GPNDYP8f8+r8fspubCu5jlgk0K2D/RQcEOHlnvVE7 MEU3bkTSVGQ88iulAD6tROVIP0eStmQFxta0DyuO5wo60gpV/raIFyxJa6obQyt5 WF3EHOAInLKcRLiBhjjZLKNX8sN2e8NSBx711pSnhgZHHyLyBXG1ychQWu9iqWvH k0vSD8e44l3ON7ggeScmhd3id5qM1GrUqCmMtRBBYjO5CtXOfs13nda7jsp7qxQm jOj0pE21kcOOtkK/JcX4eA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1785883430; x=1785969830; bh=PBhPzA2xvYXBdzZGUAFISn9I3/g+BWXV5uO 0PtXXq9g=; b=eLpaMKTwaDRi72weq/KQQ3cwRTvYsqhRVYIM7JZwqHl3wGIcMwv eR3p1XaP6xqJ+5v/WV+cAUY6+CNE5TA4mjJa3bQatEOdFkBOdnVYTOggl60MIYko qH0NKMY6PkxYcEOfCbnAFIsHOAtUuH0byXmTcWpWM9pgpA7ICa+nkJVh+vE7y/yD YqnFSr3P5M2PlZ6ls/vhQhs35biIcwTwI0rk1WMjK/tY25HujSYD0DT8D6NTVkUz 4qDCpxMN0aCwf72DIKGn+F40MtU+j42E2zzRU0734TvCQOVcCgl5IQ3fzHRo/A4i vZahCw79VB5GkpVZSSZna5xkyMz2scAValw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGpO0qsetRC26UsHWYpTodxhX3ZapQLjdNWY4FX1lbwq3qXfQfO90ne/DfjimpOGF xEwN/cIW+oGV9janrS44GhAZhmmbHuMUhPwv1H5hyWbefB7WedltbR92AgzCy4L3IOMGKZ 3/nj6ZO7Lqh2slbOH5OXawjn5xAio7Msasl5+tpGzP4udQQwva0cK7jvS4N1pW+1PadOGl QMOUhKEsVSq4b5+iuWXAHzwXr4BI6TAhieCXnKR/JtoJ0WWeqr8tCa2zicIL4V6AmKC6D7 PcUtd+vzoYotoIq48t/Bl+Mn/a19HW/BEM8OXTHpB4fLWoS4A3KKwqHY4P0mT7BwhXYxNn nmQcGeBVBPkOwg4HyFrBzbu0ZiYGL1YMGB0d1jL1G4KMcI4QisyCOVcMRGidWdJbVo2RrL xwn0n3dNCYcTpm5GnB5HHH3qO5gbDEJ72zQp2Deia/42QCnDyvlXecaM9GC0Y7mwV6KzjF srfOwOC7x93jzFA3biMO19H+zB++TMT5Lvl/seA4aVDNwQCZ6W4GRZXu0sf/oneuh+oV9/ OwQoRji45DMVcNxjIBSEYF3LI+bIkD2cxlDoHY7rTw7V9o5ozZxUieAdv0r/UdorOWQaow SdmguRWZ57TCKjgxb2wsRnRDK9oqI9Uq2Igf+zuhNgIh8ojuM+FZgGQzhFOw X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 5 Aug 2026 00:43:46 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Frediano Ziglio Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 Message-ID: References: <20260804174219.835096-1-frediano.ziglio@citrix.com> <20260804174219.835096-3-frediano.ziglio@citrix.com> <9dc1d91c-52e2-4cd9-a234-6d6ca6ecceb8@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PkvxQL4DZhCcODI5" Content-Disposition: inline In-Reply-To: X-purgate-ID: tlsNG-c1860d/1785883432-D7B5987B-E0D1FDAD/0/0 X-purgate-type: clean X-purgate-size: 7789 --PkvxQL4DZhCcODI5 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 5 Aug 2026 00:43:46 +0200 From: Marek =?utf-8?B?PT91dGYtOD9RP01hcmN6eWtvd3NraS1HPUMzPUIzcmVja2k/PQ==?= To: Frediano Ziglio Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Frediano Ziglio , Doug Goldstein , Stefano Stabellini , Jan Beulich Subject: Re: [PATCH 2/2] CI: Check save/restore of PV domain as part of qemu-alpine-x86_64 On Tue, Aug 04, 2026 at 10:58:47PM +0100, Frediano Ziglio wrote: > On Tue, 4 Aug 2026 at 20:17, Marek Marczykowski-G=C3=B3recki > wrote: > > > > On Tue, Aug 04, 2026 at 07:55:24PM +0100, Andrew Cooper wrote: > > > On 04/08/2026 7:48 pm, Frediano Ziglio wrote: > > > > On Tue, 4 Aug 2026 at 18:57, Marek Marczykowski-G=C3=B3recki > > > > wrote: > > > >> On Tue, Aug 04, 2026 at 06:42:18PM +0100, Frediano Ziglio wrote: > > > >>> Make sure that save/restore continue to work. > > > >>> The check save and restore twice to check for corrupted status. > > > >>> Also a command is launched in the guest to make sure that the > > > >>> machine is not crashed but working. > > > >>> > > > >>> Signed-off-by: Frediano Ziglio > > > >>> --- > > > >>> automation/scripts/console.exp | 8 +++++ > > > >>> automation/scripts/qemu-alpine-x86_64.sh | 40 ++++++++++++++++++= ++++-- > > > >>> 2 files changed, 46 insertions(+), 2 deletions(-) > > > >>> > > > >>> diff --git a/automation/scripts/console.exp b/automation/scripts/= console.exp > > > >>> index e27886bbef..ff58ed29b8 100755 > > > >>> --- a/automation/scripts/console.exp > > > >>> +++ b/automation/scripts/console.exp > > > >>> @@ -58,6 +58,14 @@ if {[info exists env(WAKEUP_CMD)]} { > > > >>> system "$env(WAKEUP_CMD)" > > > >>> } > > > >>> > > > >>> +if {[info exists env(EXPECT_TEXTS)]} { > > > >>> + set lines [split "$env(EXPECT_TEXTS)" "\n"] > > > >>> + foreach {exp snd} $lines { > > > >>> + expect -re "$exp" > > > >>> + send "$snd\n" > > > >>> + } > > > >>> +} > > > >>> + > > > >>> if {[info exists env(LOG_MSG)]} { > > > >>> expect { > > > >>> -notransfer -re "$env(PASSED)" { > > > >>> diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automatio= n/scripts/qemu-alpine-x86_64.sh > > > >>> index 60f5cc49fc..409a601c34 100755 > > > >>> --- a/automation/scripts/qemu-alpine-x86_64.sh > > > >>> +++ b/automation/scripts/qemu-alpine-x86_64.sh > > > >>> @@ -48,6 +48,28 @@ xl -vvv create -c /root/domU.cfg > > > >>> > > > >>> " > etc/local.d/xen.start > > > >>> chmod +x etc/local.d/xen.start > > > >>> + > > > >>> +# Script to test save and restore. > > > >>> +# It saves and restores domU domain twice to check if the domain= was corrupted > > > >>> +# during the first sequence. > > > >>> +# At the end open the console to check if the domain is working. > > > >>> +cat > root/save_restore_test << "EOF" > > > >>> +#!/bin/sh > > > >>> +set -ex > > > >>> +xl list | grep -q domU > > > >>> +rm -f save.dat > > > >>> +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.da= t /root/domU.cfg > > > >>> +xl restore /root/domU.cfg save.dat > > > >>> +xl list | grep -q domU > > > >>> +rm -f save.dat > > > >>> +xl save "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" save.da= t /root/domU.cfg > > > >>> +xl restore /root/domU.cfg save.dat > > > >>> +xl list | grep -q domU > > > >>> +rm -f save.dat > > > >>> +xl console "$(xl list | awk '$1=3D=3D"domU" { print $2 }')" > > > >>> +EOF > > > >>> +chmod +x root/save_restore_test > > > >>> + > > > >>> find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz > > > >>> cd ../.. > > > >>> > > > >>> @@ -70,9 +92,23 @@ export TEST_CMD=3D"qemu-system-x86_64 \ > > > >>> -device virtio-net-pci,netdev=3Dn0 \ > > > >>> -netdev user,id=3Dn0,tftp=3Dbinaries,bootfile=3D/pxelinux.0" > > > >>> > > > >>> +# Sequence of expect/send strings: > > > >>> +# 1. wait domain start and close console; > > > >>> +# 2. wait login prompt and login as root > > > >>> +# 3. wait login and launch save/restore test; > > > >>> +# 4. wait restore from domain console and send a command. > > > >> Why doing this interactively over serial, instead of adding to > > > >> etc/local.d/xen.start and then printing test result at the end? > > > >> > > > > I'm using expect to interact with the console. expect is not availa= ble > > > > inside the alpine root filesystem. > > > > Some failure I had during migration is that the VM crashed. In the > > > > script I interact with the console to check that the VM is still ab= le > > > > to run commands. > > > > > > We can add `expect` to the dom0 root filesystem if we find a need for > > > it, and it looks like this might be a good enough reason. You want a > > > patch to https://gitlab.com/xen-project/hardware/test-artifacts > > > images/alpine/*-x86_64-base.dockerfile to get it included. > > > > FWIW, my suspend test (which tests a similar thing) uses ping to check > > if domU is still alive: > > https://gitlab.com/xen-project/people/marmarek/xen/-/blob/2184be51d426b= 60f5e1a7e6e891d0f40e9488fc7/automation/scripts/qemu-alpine-domU-suspend-x86= _64.sh > > >=20 > Are you going to upstream the test? Yes, this branch (including a few more tests) waits for the other series to test-artifacts (already acked) to be pushed. Otherwise, it needs a hack with switching to alternative repos to work... I guess I can post it anyway, just with a disclaimer about pushing order... > Why sleep between commands? Worrying about possible races? Probably > there should be no race after the command exited so I personally would > remove. To cover also cases where crash happens only a moment later, not in the very second it's resumed. I had also a case where only one vcpu crashed, but otherwise domU appeared functional (this I solved with oops=3Dpanic on kernel cmdline, added in an earlier commit). > Using the network seems like a good idea. I also discovered that there > is nc and bash installed so something like >=20 > # nc -lk -p 8888 -e sh -c "echo Still alive" >=20 > and >=20 > # bash -c 'read -t 1 line < /dev/tcp/localhost/8888; echo $line' > Still alive >=20 > would even test if userspace is still working correctly Looks like a good idea. > > > But, for migration testing, this really wants to run on the real > > > hardware. Besides the main memory image, there's variations in regis= ter > > > state and validity which will vary between hardware. > > >=20 > Which scripts/jobs are run on real hardware (well, I suppose all that > starts with zen, kbl, xilink or adl). Are they all run for every > build? Yes. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --PkvxQL4DZhCcODI5 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmpyayIACgkQ24/THMrX 1yzH5wgAmZRzBema58TF1UQ6vJYm2229+7l8+o6tAnn9c2FtTvroOwskei0ZlrHZ 9xs3eaCWVyRIvVWrkl39dXF8CT7lwNa8F1CCJf391DGhwxT5pfwhULi6l6ylW+GM QpcYn9N3bgEFYdrDxcUeQf+VAOyNcEKutErtaFwb2BIhGbH6iPLQjBuZAm1Np1ZM GyEgEzKWJN6o4YUJ+NwHUvvV+1c/t+UCVhj9Ac0juGZ519wKOzxrU6XNTwvoW72E PLpkVL8O+kM4xEk3ICyDoGAkOVUv/W4XJkGyvfA6ut26u05/4gHZYzXvBFzXes3D TU0fuoxyU5sk57gyL8DtSCK3cCRs6w== =+wM4 -----END PGP SIGNATURE----- --PkvxQL4DZhCcODI5-- From xen-devel-bounces@lists.xenproject.org Tue Aug 04 23:38:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 04 Aug 2026 23:38:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382691.1626018 (Exim 4.92) (envelope-from ) id 1wrOiF-0007QY-HS; Tue, 04 Aug 2026 23:38:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382691.1626018; Tue, 04 Aug 2026 23:38:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrOiF-0007QR-E0; Tue, 04 Aug 2026 23:38:23 +0000 Received: by outflank-mailman (input) for mailman id 1382691; Tue, 04 Aug 2026 23:38:22 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <36XdyagYKCfwwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 1wrOiE-0007QL-0a for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 23:38:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrOiC-002ejV-4h for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 01:38:20 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <36XdyagYKCfwwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a7277cc-e002-0a2a0a5209dd-0a2a4504d3bc-14 for ; Wed, 05 Aug 2026 01:38:20 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <36XdyagYKCfwwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a7277ea-b57f-0a2a45040019-d155d2c6d0f4-3 for ; Wed, 05 Aug 2026 01:38:19 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8486c3411c8so432403b3a.2 for ; Tue, 04 Aug 2026 16:38:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785886698; x=1786491498; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=MCQeULnuxyizouUVujp9ZRZMwHTWkFpcMFYeBXRE7J4=; b=sYb+VhPgMeKWlobkFKPoJlB0RoNcWw5WMGQzmTEIjs0PvAZG668J1PZAD2XjEUzAbx fxy3OSwt63BVb5BJ723myCT9nxtiCjSz7lUi09bg6tT02yjbhkeYQkVXbciDCcnjUBEg 6e4p1DWCuxB77RDbvybFsMhcF3Gamcb9NTkdBoru/GseYt5FA7Q5I95sDvQ7NWk9+wsH CgENSTa0dRvVO9K/yyF+hbt6dRj5XQBV7gV0qjMJcFB/NcST9ABrb19rrbGNx5Se8tN4 AMjEvyCEcG/kplPqR0Cei3o6baoe8OrO2Ysad/If325tHgte9RIhNEFI8IaJ/fA8VwdA ZBiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785886698; x=1786491498; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MCQeULnuxyizouUVujp9ZRZMwHTWkFpcMFYeBXRE7J4=; b=JGPL1G+ive0LS/sx5HVijuswEe0sK1tMzitfR9eNWj7wCPxIiA/k43dNWj6oT20RZY cbwipMzhEZkL6kn593/dBbCyAWyKCaRQiV5WqAfEZkf9ae7d775FfZb34k2G8htDfSr/ kWZYmmG+Up8DV0TeiI0YRfBk1kYxG9Z01lxuhQPJpC3D4jdbbzyAWsx7Q/fLBO7VMHtB Rbx6qk6i/aAhq1LqPDOfWVovyXsM8HehJFOrkDYZANM4T1iVmBrUDvrCcCtynxQdacww YvYxQT7n/714VRntmfNDwBjj5w0fBA8pZKnvu4+buinoJKmv3z46EA0ZTRIitAEAWPAh tyow== X-Forwarded-Encrypted: i=1; AHgh+Rp0A43ac/WUxOwsaw6gOBNgMkouLk+5TvG5RJBVhSggTkz1yZk9VN1VB5LGn8+QJf4SCfJtpRp8dTc=@lists.xenproject.org X-Gm-Message-State: AOJu0YytBpQ2fqC/GfWGir/Jh73UnqgJb9uyu1k91L935q53GlnZTxOe YG1WSJt/T15d3JXYQ/NEh9nuRwA5FRmMSZJU5kDkkuIPrEOdeJJzsDK3t0EqR7Fz28IHOJsPyHg Sj4YK0g== X-Received: from pgig16.prod.google.com ([2002:a63:f410:0:b0:c92:11a5:bbce]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3a15:b0:84a:60a4:2651 with SMTP id d2e1a72fcca58-84f2dfc53efmr1961102b3a.6.1785886697620; Tue, 04 Aug 2026 16:38:17 -0700 (PDT) Date: Tue, 4 Aug 2026 16:38:17 -0700 In-Reply-To: Mime-Version: 1.0 References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-32-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v7 31/36] KVM: x86: Add KVM_[GS]ET_CLOCK_GUEST for accurate KVM clock migration From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ebf023/1785886699-C0CDFB50-B313748F/0/0 X-purgate-type: clean X-purgate-size: 1065 On Sat, Aug 01, 2026, David Woodhouse wrote: > On Fri, 2026-07-31 at 16:24 -0700, Sean Christopherson wrote: > >=20 > > > + /* > > > + * Allow for a discrepancy of 1 kHz either way between the TSC > > > + * frequency used to generate the user's pvclock and the current > > > + * host's measured frequency, since they may not precisely match. > > > + */ > > > + if (user_tsc_hz < curr_tsc_hz - 1000 || > > > + =C2=A0=C2=A0=C2=A0 user_tsc_hz > curr_tsc_hz + 1000) { > >=20 > > I don't follow, why is KVM restricting what frequency userspace can set= ? >=20 > Userspace actually sets the frequency with KVM_SET_TSC_KHZ. What KVM is > insisting upon here is that the input to KVM_SET_CLOCK_GUEST is > *consistent* with the guest's TSC frequency (within a little slop > caused by different host TSCs). Why does KVM care though? I know some people hate that KVM's uAPI is permi= ssive to a fault, but trying to "help" userspace often ends badly for everyone. = E.g. what happens if userspace does KVM_SET_TSC_KHZ after KVM_SET_CLOCK_GUEST? From xen-devel-bounces@lists.xenproject.org Wed Aug 05 00:07:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 00:07:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382702.1626027 (Exim 4.92) (envelope-from ) id 1wrP9y-00040f-9S; Wed, 05 Aug 2026 00:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382702.1626027; Wed, 05 Aug 2026 00:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrP9y-00040X-6R; Wed, 05 Aug 2026 00:07:02 +0000 Received: by outflank-mailman (input) for mailman id 1382702; Wed, 05 Aug 2026 00:07:00 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrP9w-00040R-73 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 00:07:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrP9v-00AAsM-53 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 02:06:59 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a727e98-2eae-0a2a0a5409dd-0a2a450ce694-6 for ; Wed, 05 Aug 2026 02:06:58 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a727ea0-f479-0a2a450c0019-aceafc1fe8cc-3 for ; Wed, 05 Aug 2026 02:06:57 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DB19F40AD8; Wed, 5 Aug 2026 00:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38F9A1F00A3D; Wed, 5 Aug 2026 00:06:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785888415; bh=fQGXTT1iD4XOXkRDxR3dG4pIjyvECfsrSvRyXf46TZw=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=VzgzDjhi9Ja1W5hLt58pREs7AZFSvpvy+GUFRil24u3tV25E8RAAKfLuev7/BOVmP vHrhIqZhEvjxvB+PAVngR+Oc7nuvxKikPu/g+GEGygo4OY3dKClZNCVXwp1HJEleR+ vxA09ZFsznPAeqmkWkTOlIEyfzrVBmq3rM33fMghLrZbdudoWcu0Fzdw3HRuXOwX21 Goe8hzAwyafEPHVULdX1pg5cN7/3/qGFxy4somCLRZzzRVSSf48H8Le4EmPr1PlG5Y T4jU8POAIlgo2zsnrojq27axy/FhY0EDnxLvcOMc844HsFlT2JPUauNxRn0NyO2qpZ po8godmRCI81g== Date: Tue, 4 Aug 2026 17:06:53 -0700 (PDT) From: Stefano Stabellini To: Yifei Gao cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , v9fs@lists.linux.dev, Christian Schoenebeck , Juergen Gross , Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] 9p/xen: fix refcount leak in p9_xen_response() on wrong tag In-Reply-To: <20260804213550.3409638-1-gyf161023@gmail.com> Message-ID: References: <20260804213550.3409638-1-gyf161023@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-d25034/1785888418-03AD4A5B-1C0A336A/0/0 X-purgate-type: clean X-purgate-size: 1717 On Tue, 4 Aug 2026, Yifei Gao wrote: > p9_xen_response() looks up the request for an incoming reply with > p9_tag_lookup(), which takes a reference on the returned p9_req_t. When > the tag does not resolve to a request in REQ_STATUS_SENT, the function > warns and continues the loop without dropping that reference, permanently > leaking the p9_req_t and its msize buffers. The reply header, including > the tag, is supplied by the backend, so a malicious or buggy 9P backend > can leak kernel memory on every crafted response. Most backend are trusted, including this. So I would avoid "malicious". > Drop the reference before continuing, mirroring the equivalent path in > trans_fd.c. It doesn't look like trans_fd.c behaves like this patch? > Fixes: f66c72bea129 ("xen/9pfs: receive responses") This should be 728356dedeff Aside from the above, the code change looks correct Reviewed-by: Stefano Stabellini > Cc: stable@vger.kernel.org > Assisted-by: Claude:claude-opus-4-8 > Signed-off-by: Yifei Gao > --- > net/9p/trans_xen.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c > index f9fb2db7a066..8eea0da8797f 100644 > --- a/net/9p/trans_xen.c > +++ b/net/9p/trans_xen.c > @@ -203,6 +203,8 @@ static void p9_xen_response(struct work_struct *work) > req = p9_tag_lookup(priv->client, h.tag); > if (!req || req->status != REQ_STATUS_SENT) { > dev_warn(&priv->dev->dev, "Wrong req tag=%x\n", h.tag); > + if (req) > + p9_req_put(priv->client, req); > cons += h.size; > virt_mb(); > ring->intf->in_cons = cons; > -- > 2.43.0 > From xen-devel-bounces@lists.xenproject.org Wed Aug 05 00:27:18 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 00:27:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382713.1626036 (Exim 4.92) (envelope-from ) id 1wrPTS-0008OT-Pn; Wed, 05 Aug 2026 00:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382713.1626036; Wed, 05 Aug 2026 00:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrPTS-0008OM-N9; Wed, 05 Aug 2026 00:27:10 +0000 Received: by outflank-mailman (input) for mailman id 1382713; Wed, 05 Aug 2026 00:27:09 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrPTQ-0008OF-Fs for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 00:27:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrPTP-005IWg-Dy for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 02:27:07 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7282fb-e002-0a2a0a5209dd-0a2a4502b432-30 for ; Wed, 05 Aug 2026 02:27:06 +0200 Received: from [52.101.125.91] (helo=TYVP286CU001.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a728357-6ca4-0a2a45020019-34657d5b7ba0-3 for ; Wed, 05 Aug 2026 02:27:05 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by TYCP286MB3435.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:302::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Wed, 5 Aug 2026 00:26:59 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0270.017; Wed, 5 Aug 2026 00:26:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=esolb2vq6t57XywXG5KcqiqOkUn1VICFSYPFlFwC2LA/FF0PU0NKYV+k606xZJkIt5AMJ1d/JGYITQpwz2FRRYmBRrsKmuFZ0xWIV9NUceTpH/K5oaGO/a1HnN0lxgPatcWR+u3UBBh5TQBmPIT5ntQ/CJhzkaUJUUwnalhydkzCfMyVL0iy1sqGqHur+MkcZvZOAgn0FiAJyfKyKXT8uTmbAcESP32ictmt0AEl67zR60+EmnJG/oRYXa4bKK/VizkhhIMgxNnX2Q+miIRD//BXpE5g7OWCL2EUsADsZQxcpxYwq014NAQrNt9OnHAxiZAo5jKrETJ8nB3/WTYs9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VQVNDcQbHIfCeMMPt/2Aw42fIIpin4DpaN8TSJP3ahA=; b=LArhckNG8QGOxH49rfjcGkG8dN2CKwMLiM+CFX6AcdG2ZIm8/K9ng6u7U07DzIqlSZIs2F1XiV1kiIVMxTr7FQPMEvP9chUsXHAbxMSLQ9rQ1LZiSmS/bJlrZ80IMPsEDjrl0L/RGu6DKVu6DH+jyo/rJZq+OEXbT5Hv7S7KfDSvmjMfCDrQlHjj+nfqDhGy7RATG3cLI0bMNIzyFvUB3SJ0DbxYREOhUdYG0LwtLANPVotuCeoFwj63BNw6Xd/baZswQrrn45TvLjwNkKDmO/Fw8A6Y4er4cvtFmcHYaadNpI0/H3Kv/j2Lk7dQQlENZ0QKs48WWfbt0K8XjvEQIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQVNDcQbHIfCeMMPt/2Aw42fIIpin4DpaN8TSJP3ahA=; b=jh9B9u+St2alfoVDHL8JyVOfMNaS4c9+hIZHks2CRc+B5l2FA5cdedlGaZkAmqOudx6L2Z6d2tK/KD9esNAKAio5WzGC1kuq5elXVUTq6bPFTv5yUQiMZ3PkFsE9tvnegqecICtc7n7/XGXqDV/+hxCAWsal1Q8JAq8a/lFakzU= From: Hirokazu Takahashi To: Bertrand Marquis CC: "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v5 0/4] xen/arm: Device Tree based CPU topology support Thread-Topic: [PATCH v5 0/4] xen/arm: Device Tree based CPU topology support Thread-Index: AQHdD+8pDj0XO3cy2kSCxVJYrFPzTbaELD+AgAqVLsA= Date: Wed, 5 Aug 2026 00:26:59 +0000 Message-ID: References: <20260709220552.646462-1-taka@valinux.co.jp> <07327966-7E81-44CA-A1EA-F227C1C9EA51@arm.com> In-Reply-To: <07327966-7E81-44CA-A1EA-F227C1C9EA51@arm.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS9P286MB7222:EE_|TYCP286MB3435:EE_ x-ms-office365-filtering-correlation-id: f978a03f-c5ea-46c6-a78b-08def288438f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|23010399003|376014|366016|1800799024|38070700021|56012099006|4143699003|10067099003|18002099003|22082099003; x-microsoft-antispam-message-info: GU8LUra/Xo+Wk3gHBPN5jFkS/ELuIIGSNHKRfzMKi3dy8BmTEw9W+SmFvF7Yf6ugj5g9z/lFM1Hwe16W2wT4Ln38wjvbEVzy5ltfED4+bU8YWgNOr5yfBD7Xs66o/j9pl2D5yHveJxOzT8jHrSg5HpVno6ky8Y/jvdqBluMUgibxWeV867amnOk7vThpo48Xbtj1gYQFEhs9enQCxfL7K77dTdmeKT8U9XlxPetXqtut1dbgNnTNGi5l41EikhJiY/tY+ck0k7cM7WDWkS8MR8VMAG20i1d7AdLbVPxbRdCxxtP5Rr+axmVQ2efHsCCMvbodhBlY8oZAobLcHVZN8HaSViTvvrj3J4lGoDgf2xuFvO+dkPIvfpysEySHTKMzLQ3nPztqNeJfmWlkESLeD5yxrZlJRBmKWkZ5ubp7jOimstXC4tYLtytoyjMQ3wmqJ0zTuSHuxrEeWFKAOt1dajgZ6dBMzvrAg658w5Bh3VqjFp/sr5lQah73v3Hb8a1zQRHOTcTpPCVLXcJAWZ9ByFqQP75w6D0bpr1Y37qSyoO6hx5NXxIz8WanD4iau3JLlmidby2auz3FTwbOQYSWqoyiMi8sy9eHSekhP34ALJuh9Eko8DtrPVfwNkbNiwAWjBnR0e66DPNizBXlVzKumkceWLPG1L6hV3cR3rMP/V0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(38070700021)(56012099006)(4143699003)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qdqRQlUW/TH8qXJnoNL7B28qGcyNAdXVJiHtqBg+RP+aXsZD7dyMQt/Txcrt?= =?us-ascii?Q?EihGfJ/CwMq8w0I8w+kBZu7BhXZVz4OGiz4KTIoNr1yAOJI1fJTcdytxxMoO?= =?us-ascii?Q?u/TcSeLKSGLX70bsW76z539E0HuFn2x5GrPxupTTB3ETzZGA1FWtcxswyn72?= =?us-ascii?Q?PyCE2YjmdepAuOVcuDkWCyIQv/5u4WURjZjCkMsezNW8DqKc7CBaMaSCMjYm?= =?us-ascii?Q?sAAmQ5cunKMspqBPQyGxiFdhdvIVujDdHEXHiTo2xsfMyuU7XWMy1LyVwNqT?= =?us-ascii?Q?0g+UYOq7foVMW7CbXJDzfUagSrW1Ks6MLDZUaKj9hdb58VrTKccZvit9ooEA?= =?us-ascii?Q?/LYrWuXuR7X5RXM1NU4o+/6L12xbDYQdH8YVGFXSQ+vfTXKYFqyIS6PvYoTp?= =?us-ascii?Q?ETGTwKpgQvTByowu9QkCdsqRmXmDn92gLULh0vg7kMGukIXoDeShZy8W29oE?= =?us-ascii?Q?15zE4/yI8AVt0bq5oeH2BeOt9GnvTjhGjvj9FWXbKGZL53uXPf6tzKYvc3cc?= =?us-ascii?Q?xGZj+UjpYZ3rTcQf6osYUX7xGM1UX3Qq4LmKIO8V5dYF662WwhLGFusLW4dV?= =?us-ascii?Q?3Bu0CNuAk20LxKaD3xcABw3E/hNZ39mpgbEss0hhDSTKSK38xW3HCYKkpc0Z?= =?us-ascii?Q?1cWDw4GaYukOkN3vegqhIfhXnFTOcGuerolY2BcvSdR62rjwNAWyu8uHpbiz?= =?us-ascii?Q?OfdVaHoNhMVNf33lmHWIekWZj1IcLnij9lGjWWJ55PN0kqfxZDpL2oOLvg52?= =?us-ascii?Q?KZRgJNQKuXE+jUqin+PQfI7EFIwPvTyuci2zoXjEr3ELs2nUAbXU2tp9lMdV?= =?us-ascii?Q?k4cIgtyNK/2cB/myG4lxVuB8KEhRg/JjqK9feSx/HtUOR/CNe3nHNd1DcBpD?= =?us-ascii?Q?+CtG+hGpo2uUT5B7KM3cBChj6cka6gO4diTwdAAoUTLKWk4TNyw1SHUmzWL6?= =?us-ascii?Q?XYsBw/RSnJlFOCVxQG2YOYH/osl0q3LWhGDQVKKQepnCDUukoBeJyZpNBJOu?= =?us-ascii?Q?dSqd0QSnxkmoprNpFnk4IDK6dXf3d8AJMdDLPnVhDvirHd07zS+vQyC6Pie7?= =?us-ascii?Q?PgXR1497oDHnKr1bT5UPndwQnrUSzy/ncLZ2CqPDOU6ga0nrXoxrj5Cktcl7?= =?us-ascii?Q?X9fCJbP+Inm3sUIf7fz+wI1II1BZzvJYfzZnBvVxSK3AP3i2t56Xx1uCS4B2?= =?us-ascii?Q?mXI0R+dFHwArpCqmDMKp+g9f3XpWFryDOBLDold4JKNKZQMOMZ1NFkZ+6Xp8?= =?us-ascii?Q?sfTtrsT8/n+GlmEv6dv4x/6yOGPcrjC87FzPXxKkOEoPOXkTOhPmZhBeaxe9?= =?us-ascii?Q?8xzagqHpmtmGY5i52ddmZVe3VojAq42W9p6E5xFHfekKrEvbPgJ4YOLE1Dsc?= =?us-ascii?Q?WiiYYs3OzqUqm455RIJnAv0r/l5z8nIULtrXM1yladJ5H2AMKSpKal1DjNTg?= =?us-ascii?Q?gk5HLFdENfPN19nHNfvhbY8GOs52gcyiU5amWjI+IfnKWNOogmrw5+cUvXD8?= =?us-ascii?Q?nKeY6IP5Da+yEN9mHUvtJSLgv7jLBkDXwHUI7oxSszWffNwHhP/dg7BCULxV?= =?us-ascii?Q?AG09HlPGW3yf0gMEvXgneOn6aBzHrtyrIvQnBYBYdiLPrXDTDFgaqQ/59UMP?= =?us-ascii?Q?bBdqALEvejyTh5rMr6v+RDOPRGvFnG9fN2gVRFxgnraWCtCbWK+ddNZcMvnO?= =?us-ascii?Q?LsWcQ08931GMezdiSSwkKV6k9gDefhaFeHPxUMwKfvOnyUa/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f978a03f-c5ea-46c6-a78b-08def288438f X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2026 00:26:59.5967 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HGpGs8CsioxzgJG2YnONHamVYg430ui9bbHCkiDkRFUtswFBj7B+IMs0w2WkEmuhMD4yGR4hahtBFyiSKc5byg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB3435 X-purgate-ID: tlsNG-720697/1785889625-F20A82AC-B1588DA5/0/0 X-purgate-type: clean X-purgate-size: 453 Hi, > Hi Hirokazu, >=20 > Please use the add_maintainers.pl script before sending to make sure the = right maintainers > are in copy of your patches otherwise some might miss your patches. Okay, I will make sure to use the add_maintainers.pl script. > https://xen.readthedocs.io/en/latest/contribute-xen/submit-patch.html#ste= p-2-use-add-maintainers-pl-or-get-maintainer-pl >=20 > Cheers > Bertrand Thank you, Hirokazu Takahashi. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 01:53:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 01:53:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382729.1626044 (Exim 4.92) (envelope-from ) id 1wrQoT-0007Ex-Pr; Wed, 05 Aug 2026 01:52:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382729.1626044; Wed, 05 Aug 2026 01:52:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQoT-0007Eq-NG; Wed, 05 Aug 2026 01:52:57 +0000 Received: by outflank-mailman (input) for mailman id 1382729; Wed, 05 Aug 2026 01:52:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQoS-0007Ek-PD for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 01:52:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrQoS-0068PF-1k for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 01:52:56 +0000 Received: from [203.221.94.45] (helo=Mac.tail87ea19.ts.net) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wrQoR-00CujO-2b for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 01:52:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:To:From; bh=x1Sp3yZQN5Q3kV7fZfg+oIULJI60NzjOq6ViWln5I7o=; b=jdUO+UwKAnwNwdG/itA1p46kMo 4LAQBfcukIBBnaLSpEiSBkQ5QGa2yHcOf3frP65ZppqANnJCJazsyoH8FfkzYaLEOVAutmdbtI3eo +zIQbdwVuVYMI1scogRS8aIg2Y4LrqeJLOg9pRQDV48ku6wzpeJaGbjt09EIva2IAE5Q=; From: George Dunlap To: xen-devel@lists.xenproject.org Subject: [PATCH 0/3] Add compile_commands.json target Date: Wed, 5 Aug 2026 11:52:37 +1000 Message-ID: <20260805015247.41943-1-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modern tools like emacs' `eglot` rely on compile_commands.json to gather information about the project. Import the build script from Linux, adapting it to the core Xen binary. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 01:53:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 01:53:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382730.1626055 (Exim 4.92) (envelope-from ) id 1wrQoZ-0007Rm-23; Wed, 05 Aug 2026 01:53:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382730.1626055; Wed, 05 Aug 2026 01:53:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQoY-0007Rf-Tc; Wed, 05 Aug 2026 01:53:02 +0000 Received: by outflank-mailman (input) for mailman id 1382730; Wed, 05 Aug 2026 01:53:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQoX-0007RR-1v for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 01:53:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrQoV-0068PJ-2h; Wed, 05 Aug 2026 01:52:59 +0000 Received: from [203.221.94.45] (helo=Mac.tail87ea19.ts.net) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wrQoU-00CujO-3C; Wed, 05 Aug 2026 01:52:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=Lee8YbDbDbQD/PEEAUhgQiCV3VG2M8ylKmtExRHl+xg=; b=IqME4ytnnjn9USk2eu1wJs0TiW tVlwldlurKihxRUiDhT/sRbDNyQLAW29RBAymV6JhKTZvKReFxWYB8qdUAS5RwMxJ7MAgPEcZ+iKi Wa3Ne1hYbrZAvb8D/GtmLGnoPN1jDeR8tEoQjcpY8o1pm7H18R6xVZKYyMKDVwoIn12A=; From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 1/3] xen/scripts: import gen_compile_commands.py from Linux Date: Wed, 5 Aug 2026 11:52:38 +1000 Message-ID: <20260805015247.41943-2-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805015247.41943-1-gwd@xenproject.org> References: <20260805015247.41943-1-gwd@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xen's Kbuild-derived build system records the exact command line used to compile each object in ..o.cmd files. That is everything needed to produce a compile_commands.json compilation database, the format clangd and other tooling consume to provide accurate cross-referencing (go to definition, find references, call hierarchy) in LSP-capable editors. Import scripts/clang-tools/gen_compile_commands.py from the Linux kernel, unmodified, so that the provenance of the code is easy to verify (commit 90efe2b9119f, Linux v6.16). As-is the script produces an empty database on a Xen tree, since Xen's compile command lines differ slightly from Linux's; the following patch adapts it. Assisted-by: LLM Signed-off-by: George Dunlap --- xen/scripts/gen_compile_commands.py | 228 ++++++++++++++++++++++++++++ 1 file changed, 228 insertions(+) create mode 100755 xen/scripts/gen_compile_commands.py diff --git a/xen/scripts/gen_compile_commands.py b/xen/scripts/gen_compile_commands.py new file mode 100755 index 0000000000..96e6e46ad1 --- /dev/null +++ b/xen/scripts/gen_compile_commands.py @@ -0,0 +1,228 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) Google LLC, 2018 +# +# Author: Tom Roeder +# +"""A tool for generating compile_commands.json in the Linux kernel.""" + +import argparse +import json +import logging +import os +import re +import subprocess +import sys + +_DEFAULT_OUTPUT = 'compile_commands.json' +_DEFAULT_LOG_LEVEL = 'WARNING' + +_FILENAME_PATTERN = r'^\..*\.cmd$' +_LINE_PATTERN = r'^(saved)?cmd_[^ ]*\.o := (?P.* )(?P[^ ]*\.[cS]) *(;|$)' +_VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] +# The tools/ directory adopts a different build system, and produces .cmd +# files in a different format. Do not support it. +_EXCLUDE_DIRS = ['.git', 'Documentation', 'include', 'tools'] + +def parse_arguments(): + """Sets up and parses command-line arguments. + + Returns: + log_level: A logging level to filter log output. + directory: The work directory where the objects were built. + ar: Command used for parsing .a archives. + output: Where to write the compile-commands JSON file. + paths: The list of files/directories to handle to find .cmd files. + """ + usage = 'Creates a compile_commands.json database from kernel .cmd files' + parser = argparse.ArgumentParser(description=usage) + + directory_help = ('specify the output directory used for the kernel build ' + '(defaults to the working directory)') + parser.add_argument('-d', '--directory', type=str, default='.', + help=directory_help) + + output_help = ('path to the output command database (defaults to ' + + _DEFAULT_OUTPUT + ')') + parser.add_argument('-o', '--output', type=str, default=_DEFAULT_OUTPUT, + help=output_help) + + log_level_help = ('the level of log messages to produce (defaults to ' + + _DEFAULT_LOG_LEVEL + ')') + parser.add_argument('--log_level', choices=_VALID_LOG_LEVELS, + default=_DEFAULT_LOG_LEVEL, help=log_level_help) + + ar_help = 'command used for parsing .a archives' + parser.add_argument('-a', '--ar', type=str, default='llvm-ar', help=ar_help) + + paths_help = ('directories to search or files to parse ' + '(files should be *.o, *.a, or modules.order). ' + 'If nothing is specified, the current directory is searched') + parser.add_argument('paths', type=str, nargs='*', help=paths_help) + + args = parser.parse_args() + + return (args.log_level, + os.path.realpath(args.directory), + args.output, + args.ar, + args.paths if len(args.paths) > 0 else [args.directory]) + + +def cmdfiles_in_dir(directory): + """Generate the iterator of .cmd files found under the directory. + + Walk under the given directory, and yield every .cmd file found. + + Args: + directory: The directory to search for .cmd files. + + Yields: + The path to a .cmd file. + """ + + filename_matcher = re.compile(_FILENAME_PATTERN) + exclude_dirs = [ os.path.join(directory, d) for d in _EXCLUDE_DIRS ] + + for dirpath, dirnames, filenames in os.walk(directory, topdown=True): + # Prune unwanted directories. + if dirpath in exclude_dirs: + dirnames[:] = [] + continue + + for filename in filenames: + if filename_matcher.match(filename): + yield os.path.join(dirpath, filename) + + +def to_cmdfile(path): + """Return the path of .cmd file used for the given build artifact + + Args: + Path: file path + + Returns: + The path to .cmd file + """ + dir, base = os.path.split(path) + return os.path.join(dir, '.' + base + '.cmd') + + +def cmdfiles_for_a(archive, ar): + """Generate the iterator of .cmd files associated with the archive. + + Parse the given archive, and yield every .cmd file used to build it. + + Args: + archive: The archive to parse + + Yields: + The path to every .cmd file found + """ + for obj in subprocess.check_output([ar, '-t', archive]).decode().split(): + yield to_cmdfile(obj) + + +def cmdfiles_for_modorder(modorder): + """Generate the iterator of .cmd files associated with the modules.order. + + Parse the given modules.order, and yield every .cmd file used to build the + contained modules. + + Args: + modorder: The modules.order file to parse + + Yields: + The path to every .cmd file found + """ + with open(modorder) as f: + for line in f: + obj = line.rstrip() + base, ext = os.path.splitext(obj) + if ext != '.o': + sys.exit('{}: module path must end with .o'.format(obj)) + mod = base + '.mod' + # Read from *.mod, to get a list of objects that compose the module. + with open(mod) as m: + for mod_line in m: + yield to_cmdfile(mod_line.rstrip()) + + +def process_line(root_directory, command_prefix, file_path): + """Extracts information from a .cmd line and creates an entry from it. + + Args: + root_directory: The directory that was searched for .cmd files. Usually + used directly in the "directory" entry in compile_commands.json. + command_prefix: The extracted command line, up to the last element. + file_path: The .c file from the end of the extracted command. + Usually relative to root_directory, but sometimes absolute. + + Returns: + An entry to append to compile_commands. + + Raises: + ValueError: Could not find the extracted file based on file_path and + root_directory or file_directory. + """ + # The .cmd files are intended to be included directly by Make, so they + # escape the pound sign '#' as '$(pound)'. The compile_commands.json file + # is not interepreted by Make, so this code replaces the escaped version + # with '#'. + prefix = command_prefix.replace('$(pound)', '#') + + # Return the canonical path, eliminating any symbolic links encountered in the path. + abs_path = os.path.realpath(os.path.join(root_directory, file_path)) + if not os.path.exists(abs_path): + raise ValueError('File %s not found' % abs_path) + return { + 'directory': root_directory, + 'file': abs_path, + 'command': prefix + file_path, + } + + +def main(): + """Walks through the directory and finds and parses .cmd files.""" + log_level, directory, output, ar, paths = parse_arguments() + + level = getattr(logging, log_level) + logging.basicConfig(format='%(levelname)s: %(message)s', level=level) + + line_matcher = re.compile(_LINE_PATTERN) + + compile_commands = [] + + for path in paths: + # If 'path' is a directory, handle all .cmd files under it. + # Otherwise, handle .cmd files associated with the file. + # built-in objects are linked via vmlinux.a + # Modules are listed in modules.order. + if os.path.isdir(path): + cmdfiles = cmdfiles_in_dir(path) + elif path.endswith('.a'): + cmdfiles = cmdfiles_for_a(path, ar) + elif path.endswith('modules.order'): + cmdfiles = cmdfiles_for_modorder(path) + else: + sys.exit('{}: unknown file type'.format(path)) + + for cmdfile in cmdfiles: + with open(cmdfile, 'rt') as f: + result = line_matcher.match(f.readline()) + if result: + try: + entry = process_line(directory, result.group('command_prefix'), + result.group('file_path')) + compile_commands.append(entry) + except ValueError as err: + logging.info('Could not add line from %s: %s', + cmdfile, err) + + with open(output, 'wt') as f: + json.dump(sorted(compile_commands, key=lambda x: x["file"]), f, indent=2, sort_keys=True) + + +if __name__ == '__main__': + main() -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 01:53:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 01:53:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382731.1626063 (Exim 4.92) (envelope-from ) id 1wrQob-0007fE-6h; Wed, 05 Aug 2026 01:53:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382731.1626063; Wed, 05 Aug 2026 01:53:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQob-0007f7-41; Wed, 05 Aug 2026 01:53:05 +0000 Received: by outflank-mailman (input) for mailman id 1382731; Wed, 05 Aug 2026 01:53:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQoZ-0007eX-Sp for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 01:53:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrQoY-0068QR-2v; Wed, 05 Aug 2026 01:53:02 +0000 Received: from [203.221.94.45] (helo=Mac.tail87ea19.ts.net) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wrQoY-00CujO-0D; Wed, 05 Aug 2026 01:53:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=EQ1BgccOExwdWoWHGsLFxtseXR3eMpL+XYbSkxSyAEo=; b=f/HIkpQwJwcgU1rtgixLQ1KwFo pv5nECO/LoGehysoJ5oMBZ5X0DQmHceC3R+tDZn+i+ccIf/w9PmcXom0dA8SL2AlyaYhXsQGgRe8r KNJk2QtuimWrMjZImPtGV9YYrydccrjp2zE4DAn+Nnug8CbZ/B3OZ5pVXteIEkauUEAU=; From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 2/3] xen/scripts: adapt gen_compile_commands.py to Xen Date: Wed, 5 Aug 2026 11:52:39 +1000 Message-ID: <20260805015247.41943-3-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805015247.41943-1-gwd@xenproject.org> References: <20260805015247.41943-1-gwd@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Two changes from the Linux original: - Linux's compiler invocations end with the source file ("... -c -o foo.o foo.c"), and the script's line pattern relies on that; Xen's cmd_cc_o_c places "-c $<" before "-o" and "-MQ", so on a Xen object tree the unmodified script matches nothing and produces an empty database. Adjust _LINE_PATTERN to capture the command up to and including "-c" plus the source file, dropping the remainder, which database consumers do not need. - Reword the docstring and help text to refer to Xen. The support for reading object lists from archives and modules.order is unused in Xen but retained to minimise divergence from the original. Assisted-by: LLM Signed-off-by: George Dunlap --- xen/scripts/gen_compile_commands.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/xen/scripts/gen_compile_commands.py b/xen/scripts/gen_compile_commands.py index 96e6e46ad1..9abc6410c1 100755 --- a/xen/scripts/gen_compile_commands.py +++ b/xen/scripts/gen_compile_commands.py @@ -5,7 +5,7 @@ # # Author: Tom Roeder # -"""A tool for generating compile_commands.json in the Linux kernel.""" +"""A tool for generating compile_commands.json for the Xen hypervisor.""" import argparse import json @@ -19,7 +19,10 @@ _DEFAULT_OUTPUT = 'compile_commands.json' _DEFAULT_LOG_LEVEL = 'WARNING' _FILENAME_PATTERN = r'^\..*\.cmd$' -_LINE_PATTERN = r'^(saved)?cmd_[^ ]*\.o := (?P.* )(?P[^ ]*\.[cS]) *(;|$)' +# Unlike Linux, Xen's compile commands do not end with the source file: +# cmd_cc_o_c places "-c $<" before "-o" and "-MQ". Capture the command up +# to and including "-c" plus the source file, and drop the remainder. +_LINE_PATTERN = r'^(saved)?cmd_[^ ]*\.o := (?P.* -c )(?P[^ ]*\.[cS])( .*)?$' _VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] # The tools/ directory adopts a different build system, and produces .cmd # files in a different format. Do not support it. @@ -35,10 +38,10 @@ def parse_arguments(): output: Where to write the compile-commands JSON file. paths: The list of files/directories to handle to find .cmd files. """ - usage = 'Creates a compile_commands.json database from kernel .cmd files' + usage = 'Creates a compile_commands.json database from Xen .cmd files' parser = argparse.ArgumentParser(description=usage) - directory_help = ('specify the output directory used for the kernel build ' + directory_help = ('specify the output directory used for the Xen build ' '(defaults to the working directory)') parser.add_argument('-d', '--directory', type=str, default='.', help=directory_help) -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 01:53:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 01:53:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382732.1626071 (Exim 4.92) (envelope-from ) id 1wrQod-0007tg-D5; Wed, 05 Aug 2026 01:53:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382732.1626071; Wed, 05 Aug 2026 01:53:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQod-0007tX-9v; Wed, 05 Aug 2026 01:53:07 +0000 Received: by outflank-mailman (input) for mailman id 1382732; Wed, 05 Aug 2026 01:53:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrQoc-0007t8-Th for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 01:53:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrQoc-0068Ru-0A; Wed, 05 Aug 2026 01:53:05 +0000 Received: from [203.221.94.45] (helo=Mac.tail87ea19.ts.net) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wrQob-00CujO-0m; Wed, 05 Aug 2026 01:53:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=+sgH7buv7ht5eYGRQ/eq/HiItqeiSBS/Osfxgw6BGz4=; b=lQ53XEufoqc9wMSfBo8QJ8NJ+6 JZSHlHlngaKGMD6BcpyCkI25g8GnpwGo/0lGkxge/wNU06nFkRJQKXgWlz8Td/uUpXpsPqRAqqIKe YUuN4jMGpTDetKyG9gZwTJpgyQDWVP54VAQ2p5w8qNuZLPrqc8VajPxFrYRH+sSYm3Pw=; From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 3/3] build: add compile_commands.json target Date: Wed, 5 Aug 2026 11:52:40 +1000 Message-ID: <20260805015247.41943-4-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805015247.41943-1-gwd@xenproject.org> References: <20260805015247.41943-1-gwd@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a phony convenience target generating the compilation database from a built object tree, alongside the other developer conveniences (tags, cscope, cloc -- the last of which already walks the same .cmd files): make -C xen compile_commands.json The output lands in the object tree root, where clangd and other consumers discover it automatically when opening files from an in-tree build. Note the database records the compiler invocations actually used. With a clang build it is consumable by clangd as-is; for a gcc build, clang-based tools may need a small .clangd configuration (CompileFlags: Remove/Add) dropping gcc-only flags. Also add the generated file to .gitignore. Assisted-by: LLM Signed-off-by: George Dunlap --- .gitignore | 1 + xen/Makefile | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/.gitignore b/.gitignore index bfc7bdf043..0aa9b801de 100644 --- a/.gitignore +++ b/.gitignore @@ -192,6 +192,7 @@ xen/arch/*/include/generated xen/build-dir-cppcheck/ xen/common/config_data.S xen/common/config.gz +xen/compile_commands.json xen/cppcheck-htmlreport/ xen/cppcheck-report/ xen/cppcheck-misra.* diff --git a/xen/Makefile b/xen/Makefile index d39bdfdd53..f87240f33c 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -685,6 +685,10 @@ cloc: done; \ done | cloc --list-file=- +.PHONY: compile_commands.json +compile_commands.json: + $(PYTHON) $(srctree)/scripts/gen_compile_commands.py -d $(objtree) + # Target used by xen-analysis.sh script to retrieve Xen build system variables export-variable-%: $(info $*=$($*)) -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 04:31:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 04:31:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382789.1626080 (Exim 4.92) (envelope-from ) id 1wrTI7-0004fu-Km; Wed, 05 Aug 2026 04:31:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382789.1626080; Wed, 05 Aug 2026 04:31:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrTI7-0004fn-I8; Wed, 05 Aug 2026 04:31:43 +0000 Received: by outflank-mailman (input) for mailman id 1382789; Wed, 05 Aug 2026 04:31:42 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrTI5-0004fa-5d for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 04:31:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrTI3-00GgVP-W3 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 06:31:40 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72bc93-e002-0a2a0a5209dd-0a2a45068884-24 for ; Wed, 05 Aug 2026 06:31:39 +0200 Received: from [52.101.228.94] (helo=OS0P286CU011.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72bca8-195a-0a2a45060019-3465e45eb222-3 for ; Wed, 05 Aug 2026 06:31:38 +0200 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:458::18) by OS9P286MB4891.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:2c1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Wed, 5 Aug 2026 04:31:34 +0000 Received: from OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6]) by OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM ([fe80::c8c9:25cd:8d13:96d6%6]) with mapi id 15.21.0270.017; Wed, 5 Aug 2026 04:31:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=valinux.co.jp header.i="@valinux.co.jp" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kK/iTdvDfV/p3i7iy1AGEslip0Q2W5J5X2MH9DNreQArwXN9JfG5eQSNdnJkNcxjMKOw9NggyD/donfIcAGZTZ8AF8ImE8aS0lIzgRV50nCHROj2Wxc6zUDA1+9lYurAgO/2Ub9DF1jU4WiqgoENluohVrKXuiQK9ZLThg5gVYRVBr3Wk05BwSzCVVtbu8Fk2YDv2ZV/L2ldVMyyqb1j5GXa9s3oXI7lY5kKkmspBs5rgkL6qtSevbud8sLYRJzu0byCg3eZxwjFHuF/pYld+tvL8AIWaZgrGCSUnuWqE+1D6hcJdcAeKFh7HOc/jMwMjhttyajv8apQ529nxpuqew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Bngy3RvD5jAQEeCq3S+xlBbepXg3MzqbFfz4C23Ujg=; b=V/rGH+5eaGcmBXmuKVXUjMG51SfsoZvhxOlEI3ggrOnthAINDDMktTnPrvspxp7nKzmCZSOGL8J7bcETQD5JxQTQTJ5sW98v0z/cJBdfrOKA8LPv0vPjz5r1ldv8zo+rodNsyBcmEL9oLmkamToTeon7d8J+GNrxR5xwsZ2nDrREMqfu3lUhWVmUEIS7VFnl9ko9uu6EcTrVMptw4Tdb5TyycwqofirZMGgnoVvwVUx1vLQa3uKfVBBVUrRsxY/e4lPEYStQ8+9bd/It+mg7MBsvQcRYsTwpiwJa7UIXWQCc8/kz5uWPl4ICnjVeAdAcByJUfZBz4O6Y8Q2/AfdoSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Bngy3RvD5jAQEeCq3S+xlBbepXg3MzqbFfz4C23Ujg=; b=bIleaxANhSNVC1RKDLnV0VFHSZ0JrOCKtaJBVkJY/Xsm8k3X+KCiz4KTRnM/+UYadpOm+JWrT4XeTKG09nwLWMTHaqoB8M4RdvjkMaZUWBQbBTCxnFGmM+3A6z9aKne3lFtdHkvxd1lLziQw/rslxMRwz/HGDnTSzIRv+7rAICQ= From: Hirokazu Takahashi To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: RE: [PATCH] xen/arm: Hide PMU feature Thread-Topic: [PATCH] xen/arm: Hide PMU feature Thread-Index: AQHdIuEazfVQgCaihUe50qminMMbcraL5wiAgAL2WTA= Date: Wed, 5 Aug 2026 04:31:33 +0000 Message-ID: References: <20260803004245.693844-1-taka@valinux.co.jp> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS9P286MB7222:EE_|OS9P286MB4891:EE_ x-ms-office365-filtering-correlation-id: 70d199a9-4b35-4d30-096e-08def2aa6e11 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|22082099003|18002099003|4143699003|3023799007|38070700021|6133799003|10067099003|56012099006; x-microsoft-antispam-message-info: SPDwRhCmFzfMpPvKby2NGFECLSxQxNCSDPjgcWNVEm1QkQAUusCkLfvyDWCym2T6YxX7cenwmCA8mCZo4Y1kEekYD9hIJv2PSS4CfAtSQHToVvtoFJVhrwKPuW/SsNI/1gTYtLsqm6pNl2l8MU9TcYmpjDwAiHGsgI7fmad7s9MjH21JqaTpNmYsox0+/+BB6lc+u6RdakJgSEKg+0Q9Nvxnw1mjPKOKgVAgkl1Iokg4X6FiYk7zSjNrRjyYfuYdXHjXCxuy/fnrOwnk4On41V/P9GpSuuEGGDCgj5louaCmt8buzmN1CfwjtLs0UKDfk6tq5VjI84f3nW67GZObY6sT1n8rOe2HWrE3C7RKM8jc5w/xryMSRVwVMj4cCBzbkGG+zyY9iMtNaKCBHmnPQ90e2ckiKAO4UHE7chjAXKUFomHSqt03ghgxykWgueOt0Pj00j+od8XlL5/On4dPJHK2p+vdFmaihwlaihoYrG7YMDw47BX4SGwZORvu1tVZa//qLZBcUszpV4WjYwpqC0aj0e+s1Quqk0fVuzjZYqO/xbsAIMVWKWeZQ3klFz5eYhQiuFRtLZ2MJj+OSxjJ8CMqpTWe/DxQMWUGHC9sniSveuOMyxyplRCysyMHhe8AHUouEzH822oYq8xmIUrg6x87YGoWe7KdVjV3vZutY87KahE5iHPW/M9TTnkO5uLWG5OoAcnSO6GWW2UuKlCi8prXJ804I8XDJI6zf12hoiA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(22082099003)(18002099003)(4143699003)(3023799007)(38070700021)(6133799003)(10067099003)(56012099006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZEZtdGpGbmpnQUwxSVBDTmRLVjFnUmowU1FHSC9HRi9Lb0lIV0N2QTlmZjJl?= =?utf-8?B?eHZBam1nREpBSFBDd1N3bU1Ha3dBczFmTWF5anhUaGMrZW0wMXd6YVl4WURJ?= =?utf-8?B?Y2svdGV0VVdMeDBBRnlYV0hkZUlSQVNxS0hqU2dLdS8rMjlBK3BHQ0p3TU5q?= =?utf-8?B?M3hpTFFLYTdLRE1Xb1lGYmNzZDF3QW10ZnkvYzJHazY2bVJIVXBTd3hMYU5C?= =?utf-8?B?dWk2TEtWZE9QK2ZFcjZGWUN2RnhjWDN2VGp3OEtYalpLeDhSajhLRDZFSFhj?= =?utf-8?B?TDNTMkJ5ZGptc25BL2lxZXo5dXZZL1VFcjRjTytHY2ZhRTcwT1BuQ3AzNU9o?= =?utf-8?B?dWtlS1RnSVhpRlRBMVpkcUFxMkgwQnlFY2tpdlFncjFBSGFkYzE4TGN5UWdw?= =?utf-8?B?SHlYOWJ4blBjWnNPMnAvOVpYMlJiUzhqenRwaXpGUmd1UnZlaGl0NEVrM3g5?= =?utf-8?B?TFY5K01sMlZ1WXlUb1BxVTNldXQrNEtnZytnMHdqU1NHTmp1MytLc1hsLzdO?= =?utf-8?B?eTE2WDNNaXNuT2IyZlhLWk1zRDJUK1U4UE1yWmJGUFRGNEJuKzZyd09sckZw?= =?utf-8?B?TUcrcmhFVEpyQTllemRXTGZEVnhMQlhPV08vSXEzNnh0eDAyaXV1MHJ1SXAy?= =?utf-8?B?dzRLaUw2YXBteTRoRVJ5VndEcTdLdVU4TjlXKzJTVFVtQVprOFRReGN5dzIz?= =?utf-8?B?MERkaWRNNXZVMVoyRm5CVDBlUFZxT3B3Ung5NkdHcEdRMmk1YVFwVmFMeEJk?= =?utf-8?B?aFpRWVBpYUVTemUrd2xCU3Q2MnlkYjNRN01MYytjSlMxc0VoN0MzQzE0dUdC?= =?utf-8?B?VWUvakNyOXNMbkV2VklGR3pTN3hENEQxd09LcHYxRml4MHJLYXd0RkwwREw2?= =?utf-8?B?Z0dueFBCRmtDWTNSbFlybzZ6ckMyb0dTSGdrc1ZhNjFkZnVHSDdKYVJTMUpD?= =?utf-8?B?ZFVwK2t5L1FuK2RQakZkSkZIZEdZamNXTGNxRlpYRlk3eC9WQlZEWEV2WVhR?= =?utf-8?B?RjV2amNKa2FrVk5ZSnNrekhhcE01M1dJOU0yWHY4ZzlhaWdWVy9nQU9wVDVt?= =?utf-8?B?VHhpbWtrK0FqZGNpVVNiMHZsUyttc0EybkljY2pwWTMxbzN6alM2Vy9nZzBy?= =?utf-8?B?cnFhMGkvR2d5cVQzUFJVRzNBYWZzV3dVam00bHpJdkJxaDVhUnF4bEMyZ2F5?= =?utf-8?B?WWxPVzVkZ0c1RG8zeFRxbFhhRFZGNkd6Z3phYldHdFg3SGlodW85R0haUjV0?= =?utf-8?B?WXJhNVcrQ2tOazc0OU9HU2tlbDZjT2N6TmNjSWEwQTZQRTExRHhIbGllOG51?= =?utf-8?B?dlp1SDluMmFnODgweGdIdDBoZHBvNjNFSHB5THBkUGhFSjdabzBTQ3RveUJk?= =?utf-8?B?N2YwcU5xanZCcVN1SmMwNVdudlRkSE90TE1UazhMcUc4cFFuUmlXVW5MY0Nw?= =?utf-8?B?aE1pYXYxeEZPOXg2dzFyYzYvNzFCcHdtMnhoTmYzQUlObm5PeVZNQ0ZsRlZq?= =?utf-8?B?TlduS2lZTWlLM0ordlVLSlYrVFNHNTVUN2pxQmhGWlpjS3hCbk03Tmt3Y2Zr?= =?utf-8?B?Qzh0YnBSaDZ1N0pQQXoyY2lGTGR1MXNwVVpPU01Vd3R4djF4OVlyVERFVk5D?= =?utf-8?B?RXdMMHJZbk4zTFBuZWJpazd2S24wYkl5andkVFBjekJVVEptV1Z3NHRDOG9V?= =?utf-8?B?OHdoalJRdXJSVi83Z0NSL09CMTVVMTBYQjVVbHk3bFV1MGkvL1dKOThPaXV0?= =?utf-8?B?eHdUODU4ZWw1UjRCYnF6eVpBQ2IyZytET2ZxVFp6Ykhnb3Q1bmlQcUNqZmxj?= =?utf-8?B?dU9oUXVkU3E1UmN5U0hOM1hVMldQd3JEQUd2cmxOL09wc0RrVzhvekJPZXE3?= =?utf-8?B?QkZJSDZ6aUgrR3V4eFBMWDhXSUtuNDlHR0xIYWZaYU1ZUEx6K0xwY21aTU5K?= =?utf-8?B?NUJNbVc5UHJOMTI1Uis1ZEI3MGtId1d2MGhSR1NjWCtQdDhKdk90QlVUWGc5?= =?utf-8?B?YThOS0dBVnExZDNnaGs1Y0VWNW5IamJZVk1vbm5MdUhLOFVsa0JMTnlnM3FG?= =?utf-8?B?VUMwaFpLMTBJRG5TSVNkaGh5UjI3bTBNbERSdFZMZXBNRnBNangxdkJYZzNS?= =?utf-8?B?LzdmNmdSRVNBdTNjYllVNWEvR0VFTWtqclVJazFDUkJZV3Z2N3RYQUk3ZVMx?= =?utf-8?B?M1M1cENHZEVDQUJTNG8wWlhPbzhoNnpBUUR2TWdsMnFHRWEvMmFRVnoreVdH?= =?utf-8?B?dEN4eHBKNXAvWGVqL2MvazArMmE5QTMrbUJCMlBjVDZKb3VmcWxHcWdqTmpt?= =?utf-8?Q?SA2KdVx/es187graRs?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS9P286MB7222.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 70d199a9-4b35-4d30-096e-08def2aa6e11 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2026 04:31:33.7351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8iiLBt/N6OMrU38Poxvceb4GGtyMcsFdfINBISNiY0mfB8fl1HQVOFw3+rgRdHDuojD1R9THUJ3tCFrygSxZ/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB4891 X-purgate-ID: tlsNG-16d1c6/1785904299-FEA7477B-8D14F3E6/0/0 X-purgate-type: clean X-purgate-size: 5178 SGksDQoNClRoYW5rIHlvdSBmb3IgdGhlIGNvbW1lbnRzLg0KDQo+ID4gRHVyaW5nIHRoaXMgcHJv YmUsIExpbnV4IGFjY2Vzc2VzIFBNTUlSX0VMMSwgd2hpY2ggY2F1c2VzIHVuaGFuZGxlZA0KPiA+ IHJlZ2lzdGVyIHRyYXBzIGFuZCBjcmFzaGVzIHRoZSBkb21haW4uIE1lcmVseSBhZGRpbmcgZW11 bGF0aW9uIGNvZGUNCj4gPiBmb3IgUE1NSVJfRUwxIGluIFhlbiBpcyBpbnN1ZmZpY2llbnQgdG8g Zml4IHRoZSBpc3N1ZSwgYXMgdGhlIGd1ZXN0DQo+ID4gUE1VIGRyaXZlciBzdWJzZXF1ZW50bHkg c3RhbGxzIGR1cmluZyBpdHMgaW5pdGlhbGl6YXRpb24gc2VxdWVuY2UuDQo+ID4NCj4gPiBGaXgg dGhpcyBieSBleHBsaWNpdGx5IG1hc2tpbmcgUE1VIGNhcGFiaWxpdHkgZmllbGRzIGluDQo+ID4g Y3JlYXRlX2RvbWFpbl9jcHVpbmZvKCkuIEFkZGl0aW9uYWxseSwgcHJlZW1wdGl2ZWx5IG1hc2sg b3RoZXINCj4gPiBjYXBhYmlsaXR5IGZpZWxkcyB0byBwcmV2ZW50IHNpbWlsYXIgcG90ZW50aWFs IGlzc3Vlcy4NCj4gDQo+IFdoaWxlIEkgYWdyZWUgWGVuIGRvZXNuJ3Qgc3VwcG9ydCBQTVUgY2Fw YWJpbGl0eSBmb3IgZXZlcnkgZ3Vlc3QsIEkNCj4gYmVsaWV2ZSB3ZSBhcmUgc3RpbGwgYWxsb3dp bmcgdG8gZXhwb3NlIHRoZSBQTVUgaW4gc29tZSBjYXNlcyAoc2VlDQo+IGNvbW1pdCBkYmI5NDgx MTBhICJ4ZW46IEV4cG9zZSB0aGUgUE1VIHRvIHRoZSBndWVzdHMiKS4gU28gd2UgY2FuJ3QNCj4g c2ltcGx5IG1hc2sgdGhlIGZlYXR1cmVzLiBTbyBJIHRoaW5rIC4uLg0KDQpJIHdpbGwgbW9kaWZ5 IHRoZSBzeXNyZWcgdHJhcCBoYW5kbGVyIGZvciBJRF9BQTY0REZSMF9FTDEgdG8gZHluYW1pY2Fs bHkNCm1hc2sgdGhlIGJhc2ljIFBNVSBjYXBhYmlsaXRpZXMgYmFzZWQgb24gdGhlIGRvbWFpbidz IHZQTVUNCmNvbmZpZ3VyYXRpb24uDQoNCj4gPiBGaXhlczogMzY2OWExY2I5NTk4ICJ4ZW4vYXJt OiBjcmVhdGUgYSBjcHVpbmZvIHN0cnVjdHVyZSBmb3IgZ3Vlc3QiDQo+ID4gU2lnbmVkLW9mZi1i eTogSGlyb2thenUgVGFrYWhhc2hpIDx0YWthQHZhbGludXguY28uanA+DQo+ID4gLS0tDQo+ID4g ICB4ZW4vYXJjaC9hcm0vY3B1ZmVhdHVyZS5jICAgICAgICAgICAgIHwgMTYgKysrKysrKysrKysr KysrKw0KPiA+ICAgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NwdWZlYXR1cmUuaCB8IDEwICsr KysrKy0tLS0NCj4gPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vY3B1ZmVhdHVyZS5j IGIveGVuL2FyY2gvYXJtL2NwdWZlYXR1cmUuYw0KPiA+IGluZGV4IDk0ZDE0ZmI2YTkuLjcxZDc0 NWQzY2IgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2NwdWZlYXR1cmUuYw0KPiA+ICsr KyBiL3hlbi9hcmNoL2FybS9jcHVmZWF0dXJlLmMNCj4gPiBAQCAtMjE5LDggKzIxOSwyNCBAQCBz dGF0aWMgaW50IF9faW5pdCBjcmVhdGVfZG9tYWluX2NwdWluZm8odm9pZCkNCj4gPiAgICAgICBk b21haW5fY3B1aW5mby5pc2E2NC5hcGkgPSAwOw0KPiA+ICAgICAgIGRvbWFpbl9jcHVpbmZvLmlz YTY0LmdwYSA9IDA7DQo+ID4gICAgICAgZG9tYWluX2NwdWluZm8uaXNhNjQuZ3BpID0gMDsNCj4g PiArDQo+ID4gKyAgICAvKiBIaWRlIFBNVXYzIHN1cHBvcnQgYXMgWGVuIGRvZXMgbm90IHN1cHBv cnQgaXQgKi8NCj4gPiArICAgIGRvbWFpbl9jcHVpbmZvLmRiZzY0LnBtdV92ZXIgPSAwOw0KPiA+ ICsgICAgZG9tYWluX2NwdWluZm8uZGJnNjQubXRwbXUgPSAwOw0KPiA+ICsgICAgZG9tYWluX2Nw dWluZm8uZGJnNjQucG1zcyA9IDA7DQo+IA0KPiAuLi4gdGhpcyBzZWN0aW9uIG5lZWRzIHRvIGJl IGNvbmRpdGlvbmFsLg0KDQpPa2F5Lg0KIA0KPiA+ICsNCj4gPiArICAgIC8qIEhpZGUgU1BFLCBU UkJFLCBCUkJFLCBhbmQgVHJhY2UgRXh0ZW5zaW9ucyAqLw0KPiA+ICsgICAgZG9tYWluX2NwdWlu Zm8uZGJnNjQucG1zX3ZlciA9IDA7DQo+ID4gKyAgICBkb21haW5fY3B1aW5mby5kYmc2NC50cmFj ZV92ZXIgPSAwOw0KPiA+ICsgICAgZG9tYWluX2NwdWluZm8uZGJnNjQudHJhY2VfZmlsdCA9IDA7 DQo+ID4gKyAgICBkb21haW5fY3B1aW5mby5kYmc2NC50cmFjZV9idWZmZXIgPSAwOw0KPiA+ICsg ICAgZG9tYWluX2NwdWluZm8uZGJnNjQuZXh0X3RyY19idWZmID0gMDsNCj4gPiArICAgIGRvbWFp bl9jcHVpbmZvLmRiZzY0LmJyYmUgPSAwOw0KPiANCj4gVGhpcyBzZWN0aW9uIHNob3VsZCBiZSBm aW5lIHRvIHVuY29uZGl0aW9uYWxseSBtYXNrLg0KDQpPa2F5Lg0KDQo+ID4gICAjZW5kaWYNCj4g Pg0KPiA+ICsgICAgLyogSGlkZSBQTVV2MSx2MiBzdXBwb3J0IGFzIFhlbiBkb2VzIG5vdCBzdXBw b3J0IGl0ICovDQo+ID4gKyAgICBkb21haW5fY3B1aW5mby5kYmczMi5wZXJmbW9uID0gMDsNCj4g PiArDQo+ID4gICAgICAgLyogSGlkZSBBTVUgc3VwcG9ydCAqLw0KPiA+ICAgI2lmZGVmIENPTkZJ R19BUk1fNjQNCj4gPiAgICAgICBkb21haW5fY3B1aW5mby5wZnI2NC5hbXUgPSAwOw0KPiA+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY3B1ZmVhdHVyZS5oDQo+IGIveGVu L2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NwdWZlYXR1cmUuaA0KPiA+IGluZGV4IGJmOTAyYTM5NzAu LmM5MmIyNjUxYzcgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2Nw dWZlYXR1cmUuaA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jcHVmZWF0dXJl LmgNCj4gPiBAQCAtMjE2LDE2ICsyMTYsMTggQEAgc3RydWN0IGNwdWluZm9fYXJtIHsNCj4gPiAg ICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgdHJhY2VfdmVyOjQ7DQo+ID4gICAgICAgICAgICAg ICB1bnNpZ25lZCBsb25nIHBtdV92ZXI6NDsNCj4gPiAgICAgICAgICAgICAgIHVuc2lnbmVkIGxv bmcgYnJwczo0Ow0KPiA+IC0gICAgICAgICAgICB1bnNpZ25lZCBsb25nIF9fcmVzMDo0Ow0KPiA+ ICsgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHBtc3M6NDsNCj4gPiAgICAgICAgICAgICAgIHVu c2lnbmVkIGxvbmcgd3Jwczo0Ow0KPiA+IC0gICAgICAgICAgICB1bnNpZ25lZCBsb25nIF9fcmVz MTo0Ow0KPiA+ICsgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHNlYmVwOjQ7DQo+ID4gICAgICAg ICAgICAgICB1bnNpZ25lZCBsb25nIGN0eF9jbXBzOjQ7DQo+ID4gICAgICAgICAgICAgICB1bnNp Z25lZCBsb25nIHBtc192ZXI6NDsNCj4gPiAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZG91 YmxlX2xvY2s6NDsNCj4gPiAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgdHJhY2VfZmlsdDo0 Ow0KPiA+IC0gICAgICAgICAgICB1bnNpZ25lZCBsb25nIF9fcmVzMjo0Ow0KPiA+ICsgICAgICAg ICAgICB1bnNpZ25lZCBsb25nIHRyYWNlX2J1ZmZlcjo0Ow0KPiA+ICAgICAgICAgICAgICAgdW5z aWduZWQgbG9uZyBtdHBtdTo0Ow0KPiA+IC0gICAgICAgICAgICB1bnNpZ25lZCBsb25nIF9fcmVz MzoxMjsNCj4gPiArICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBicmJlOjQ7DQo+ID4gKyAgICAg ICAgICAgIHVuc2lnbmVkIGxvbmcgZXh0X3RyY19idWZmOjQ7DQo+ID4gKyAgICAgICAgICAgIHVu c2lnbmVkIGxvbmcgaHBtbjA6NDsNCj4gPg0KPiA+ICAgICAgICAgICAgICAgLyogREZSMSAqLw0K PiA+ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBfX3JlczQ6NjQ7DQoNClRoYWsgeW91LA0K SGlyb2thenUgVGFrYWhhc2hpLg0K From xen-devel-bounces@lists.xenproject.org Wed Aug 05 05:33:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 05:33:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382807.1626090 (Exim 4.92) (envelope-from ) id 1wrUFs-0006hU-8J; Wed, 05 Aug 2026 05:33:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382807.1626090; Wed, 05 Aug 2026 05:33:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrUFs-0006hN-5P; Wed, 05 Aug 2026 05:33:28 +0000 Received: by outflank-mailman (input) for mailman id 1382807; Wed, 05 Aug 2026 05:33:27 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrUFr-0006hE-4N for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 05:33:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrUFq-00GpBj-AJ for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 07:33:26 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72cb08-5cb7-0a2a0a5109dd-0a2a45088926-42 for ; Wed, 05 Aug 2026 07:33:26 +0200 Received: from [209.85.208.54] (helo=mail-ed1-f54.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72cb25-f659-0a2a45080019-d155d036ec62-3 for ; Wed, 05 Aug 2026 07:33:25 +0200 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-69fab5a852cso801500a12.0 for ; Tue, 04 Aug 2026 22:33:25 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c203612f1d8sm82503166b.3.2026.08.04.22.33.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 22:33:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785908005; x=1786512805; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tKWy2di21eitj6RpqSuJfccPk2t+roA1WmKtrBhIFN0=; b=CM5y9aEgJiOrlP1IRM6t02i393SNm6yo84ZzXyg27w5tEgxBTMHiDvV3elZaoRSrMc n5cpssGNH950pzAAXh/Ra8c06cZA431qauzrIJgsk4JoVMZRcRzJmrewS/PtuWzBpDoW uWRJ9segEzOavJpkeijXtHz+bao2tBVejf6opCDfcgOxbrhb+4Llkpx9LilnY8AUT+sD 1iBDLi1lfsn2xtQze9STwUobdmveRqFKCyv3yGOdneLqzx+LAxbusc3ad3fpjttHdoaL N++bLpsBZG8Y/OU/Dhy4TH2cEUwsJC/kC1G+VO2vmh3a2tjWHBszHqyMOKhlcJoSTgjV RnLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785908005; x=1786512805; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tKWy2di21eitj6RpqSuJfccPk2t+roA1WmKtrBhIFN0=; b=M0rQKiN2eLmhneDrap6e6Ab9bOiilvIB8oVY0NzE/Qq+L1xGug7m4KFKt/aXlsZUJ1 L2XJhAM7QItxJyUg7Hkj6QfQmFZlWhVh6DiNrSTcivM6BHS96pqBeaqW5ZTcF6ktZri0 Y443a23ES17tTbmxgGjozLEqSKqfm6K5YZWhfGfskLLjMXvdBxZ5/f9YLsbIA6Yvo+fy FhALFWRYfRPnHTJyLHQK8nRTdo6s4fWe+BTIbEMqBQfiS6gUYXNMCqrnVzjAtDuGSoHp F91JLrp4LwP8uBchg5qB6hwlPTy2/nt7E7pPM0wEWlGdqrT5jILBKIyYOSStSNwL0hl4 kWQA== X-Forwarded-Encrypted: i=1; AHgh+RptpInvHrHJYyjF5gKBhQW/1PXluL92MMD50GoGzUdLpZnRbTJYpQ/s2Oa2A3I5970c0c//JvdB3V8=@lists.xenproject.org X-Gm-Message-State: AOJu0YygMBxpspL+LnY39ljNdCCiqnGhkJa+/FItRPk2nV/p7ebO+eIY DsPkNhuXf2HQ2w255gnccyvurd+7GdDBV9icN0kmQtdnhfVHj/NZuUIZZpQYn0XxJu8= X-Gm-Gg: AR+sD10wkZYbZyBkmuazzzCrKSEXsTgZ9j0X8qqRsb2SfUc99BgfvG5VjUrvz3ChdeZ nFBtDa/a2UPJ0UTI6yWwa/iFP+PYrZma6UpT9i5HAcTa62qM01N50aaV25/iVLjMzsTggyXOp9V 8WF7Ho8coCbABPAm2zZBrXgY6XEkyY7uSdYFKXx4jxioB2Obq3ADJw4gB+TjzkFgpAcanP6kTMw XssPHdEMETSqYeTsEP4rsS1ECcm/W51fpSQtIkQPK8eP+nOjRWVMGy5juBZZHiwCXr8yDCjnn++ 2ksuhyOjxnRX8hxijNvOv3aWRxJbG6T6jwqZGUNTQsh4gI4Jr9n6oTlJ8sSGwCDqK+YisOkAGhl A84NtaqVOQuvKGtVl5oA2mFE3HJ/V4ItziZguw9+w4kUsQXoCvvdXfsVWNJWnXsaPQsxCHfUC5I d4LxerIJQ95bvtjEuGZRTaldZR9fnSBQd3GAPTLgjhHQmNzvw1N56JlhohHdzKDvrgmkYVWTXBY OdaFL2gZdGp+Zw/h/hDROiaSB+kH44Sy0OrfvXWXCVKx8hjT1TefMp+wXAQGkb2CkCA2QCzGp+g Gp1QjVrOitDGIqIJd/EPoWMzdw== X-Received: by 2002:a17:906:9c89:b0:c19:6d4a:425b with SMTP id a640c23a62f3a-c2039ef0f6fmr172073066b.18.1785908002664; Tue, 04 Aug 2026 22:33:22 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 07:33:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: build failure after merge of the xen-tip tree To: Val Packett , Mark Brown , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Xen Devel Cc: Linux Kernel Mailing List , Linux Next Mailing List References: Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JLqJ0jN6d4byD0AanPRr2D3h" X-purgate-ID: tlsNG-c1860d/1785908006-D674387B-3D79B4D2/0/0 X-purgate-type: clean X-purgate-size: 7511 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JLqJ0jN6d4byD0AanPRr2D3h Content-Type: multipart/mixed; boundary="------------5DURXzF5G0iaAwCQsTZ541UC"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Val Packett , Mark Brown , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Xen Devel Cc: Linux Kernel Mailing List , Linux Next Mailing List Message-ID: Subject: Re: linux-next: build failure after merge of the xen-tip tree References: In-Reply-To: --------------5DURXzF5G0iaAwCQsTZ541UC Content-Type: multipart/mixed; boundary="------------Kk1bta0bi6MpK8PUQLmt4F5J" --------------Kk1bta0bi6MpK8PUQLmt4F5J Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjYgMjA6MDAsIFZhbCBQYWNrZXR0IHdyb3RlOg0KPiANCj4gDQo+IEVsIDQg ZGUgYWdvc3RvIGRlIDIwMjYgMToyODozNuKAr3AuwqBtLiBBUlQsIE1hcmsgQnJvd24gPGJy b29uaWVAa2VybmVsLm9yZz4gZXNjcmliacOzOg0KPj4gSGkgYWxsLA0KPj4NCj4+IEFmdGVy IG1lcmdpbmcgdGhlIHhlbi10aXAgdHJlZSwgdG9kYXkncyBsaW51eC1uZXh0IGJ1aWxkICh4 ODZfNjQNCj4+IGFsbG1vZGNvbmZpZykgZmFpbGVkIGxpa2UgdGhpczoNCj4+DQo+PiBFUlJP UjogbW9kcG9zdDogImluaXRfbW0iIFtkcml2ZXJzL3hlbi94ZW4tcHJpdmNtZC5rb10gdW5k ZWZpbmVkIQ0KPj4NCj4+IENhdXNlZCBieSBjb21taXQNCj4+DQo+PiAgIDY0ZDI2ZmIyYWQx ZjIgKHhlbjogcHJpdmNtZDogZml4IGlvZXZlbnRmZCBjcmFzaCB1bmRlciBQViBkb21haW4p DQo+Pg0KPj4gSSBoYXZlIHVzZWQgdGhlIHRyZWUgZnJvbSBuZXh0LTIwMjYwODAzIGluc3Rl YWQuDQo+IA0KPiBTb3JyeSBmb3IgdGhlIHRyb3VibGUhIERpZCBub3QgZXhwZWN0IHRoYXQg dG8gZ2V0IGFwcGxpZWQgc28gcXVpY2tseS4uIEkgaGFkIG5vdGljZWQgcmVjZW50bHkgaW4g bXkgb3duIHRlc3RpbmcgdGhhdCB0aGF0IHBhdGNoIHdhc24ndCBhY3R1YWxseSByZWFkeSB0 byBnbyBpbiBkdWUgdG8gdGhlIHN5bWJvbCB2aXNpYmlsaXR5IGlzc3VlLCByaWdodC4gSSds bCB3b3JrIG9uIHJlc29sdmluZyBpdC4NCj4gfnZhbA0KDQpJJ20gcHJldHR5IHN1cmUgbW0g bWFpbnRhaW5lcnMgd291bGRuJ3QgbGlrZSBpbml0X21tIHRvIGJlIGV4cG9ydGVkIHRvDQpt b2R1bGVzLg0KDQpJJ2QgZ28gZm9yIGEgc3BlY2lhbCB2YXJpYW50IG9mIHhlbl9yZW1hcF9k b21haW5fbWZuX2FycmF5KCkgbWFwcGluZyBqdXN0DQphIHNpbmdsZSBwZm4gaW50byBpbml0 X21tLiBUaGlzIGNvdWxkIGJlIGltcGxlbWVudGVkIGluIG1tdV9wdi5jIGF2b2lkaW5nDQp0 aGUgbmVlZCB0byBleHBvcnQgaW5pdF9tbS4NCg0KDQpKdWVyZ2VuDQo= --------------Kk1bta0bi6MpK8PUQLmt4F5J Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------Kk1bta0bi6MpK8PUQLmt4F5J-- --------------5DURXzF5G0iaAwCQsTZ541UC-- --------------JLqJ0jN6d4byD0AanPRr2D3h Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpyyyEFAwAAAAAACgkQsN6d1ii/Ey+7 xAf8DyuH/0FYNoBKX08hI0Fj1oCG+R2Wf2mrXSZvz90ygWXQNqMMvQslTAozg4xiNsZ48m+IHLY2 h5ivCHq9s9JsywfRcmADL6GDRkDeePa05Uns5qxeKIiid6XSd8oJG38ykJA/2zGcC8WzfBK86Ug8 VY52lrfzs/qiYs6FnwsoGWyY72wKrpA5gPgIypBGByr7AYhkJgi97gDwWTSF+q1tws7i3LK1TYgG BBLdfpIvez3xLCTrICIZeJIaNZRAAQnIONISyXi4QfQ/usHkmDSxHGMdpyBli0A6glxH47xZsH5A gK7ZrcHVogzqSK3E/wfCvlVACTQvzXnH/bJiWzz5wg== =XVKV -----END PGP SIGNATURE----- --------------JLqJ0jN6d4byD0AanPRr2D3h-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 06:04:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 06:04:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382821.1626099 (Exim 4.92) (envelope-from ) id 1wrUjp-0002WL-M6; Wed, 05 Aug 2026 06:04:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382821.1626099; Wed, 05 Aug 2026 06:04:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrUjp-0002WE-JI; Wed, 05 Aug 2026 06:04:25 +0000 Received: by outflank-mailman (input) for mailman id 1382821; Wed, 05 Aug 2026 06:04:24 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrUjo-0002W7-Ji for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 06:04:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrUjo-00HIcz-0L for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:04:24 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72d267-5cb7-0a2a0a5109dd-0a2a4502d022-0 for ; Wed, 05 Aug 2026 08:04:23 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72d267-6ca4-0a2a45020019-d155dd2dcd3c-3 for ; Wed, 05 Aug 2026 08:04:23 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47c2b362ee2so393889f8f.1 for ; Tue, 04 Aug 2026 23:04:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e2e4sm5507675f8f.25.2026.08.04.23.04.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 23:04:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785909863; x=1786514663; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XBygFyzYJYS5+ICqbXp5tbWEYq5wUoX0qFqph9ian3g=; b=IpoICVJ22gglvXwLNqCWPAj/+Ho8PSRUvhaDk7uSNUytl7gFR+g5p172ZHtfz7msrG dokWiU8B5bcCz81lgwQFYn1elKRdQOgXkqu/t+71ebuxLDpCMMJmPcE2y3wj/DfbFI2r soh5RtuifBrgD1tQ4aGvQFWNiohaTNPgZe3dXnVsU8wWvJHgSYzIZLM7WphjszcmZXGe AxM9enOSLl3SbLkL/wLlcx/4WFFxSTWmbxlt6+qs0lDqmlTAFUrzH6RQh7UX6F+0sb+2 V43w7dx8Jbqapgi3CYEFndtR2Sb3vKQHypfn6pW41nTK4cl2bKeUasVUQukiE++nzVog VMWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785909863; x=1786514663; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XBygFyzYJYS5+ICqbXp5tbWEYq5wUoX0qFqph9ian3g=; b=pV8EyPg7NfA9BIAtiim/uVVqZsx5FpankDChlcDXAO+4JgJ95j8vyvLoXQT0sYGhmn oPhu7yADvQx/FBhtws63fGMVk8HhROU86gBPA5nmgQQpLf2FOURF+AhRVRs5qnK7w4V2 2luaayIbCccsBpEX2ThF1k3mIzpLLhjyiLmZeclNAwzShuKAqo6l9z3h5zkjKQg+aNx/ hZKHN+vJu6b0Qlqg3gtxNVZiJVfva8jfLgrS8AHSsJ+zEjWs+7rrEV8ytuSX85Xq+kcd iDUs7qWLDP7dOL7POTYH7e8pwY3Sd8L9dQXvzJa1jIyLydw7Devu8ThRbXirmoPbhLgd bPNw== X-Forwarded-Encrypted: i=1; AHgh+RpptCaLq9A3p7do19SNzy4yIAqkpT3K24r60km1fXqu6JvH98pbtgbnEoGuMUsIBePFac5nj2MW4Qs=@lists.xenproject.org X-Gm-Message-State: AOJu0YxBa49D6V47pAphyVzAAtijEBTfOhOoxVXlW08zNH8o77TGXJG7 dsRm7gBNjzjSrnjATmc82E9y8Fqmaavv4lNLlbu5g+FEUd4FGxe9r/uqtTLnFujWjoF6pF5bB+G ex8vbiQ== X-Gm-Gg: AR+sD10oIyX+jVK0rdX+5yRZiDN+YpuV0RE/1o8SJVc60V0U60XvqceedyD0ScJbVui y5vcwm/eoW7hwdut0HvsWCjfRQbr8TmtjOU2X/HleRgdvQ9MggDxsURdkMXp4lDzLLR7XbFZ3EW TylAzDW/aWW6TPiDDQY6lvV01WEstqPsSOjoCkhf/Xb0dIOCVDgNoZbM/9XmYOAEqKqrnxCKtTz 64Va/M+SA21o0k2vZO6XUlxa56x9Zh8dr8I3o/ffirvph31RDBwCE40rvSJfiTVXbGW9Dp3/dT4 eaCqSq8M8Ggoq8cVI+lxDaexWPuo3Owll1JgtxADoUeMg30VEXPZqZQeEJ78k6alsIloc0+giNd 3ciDg65lOEnbHRfQLG0QeFN3enS+NcbmSk7QMfUE8n9c1oJQpKFtvM3CL7q4VcU6gRcLFIGauF9 HgyT2mfRY6+aB/ilWGtyEUbXRZp1K3ivwd6t/ixuc5YIUl6e7Os9HnN9JOKuAxiIvHd4tiG/HeW IXtOZVPGzejNX/zwm+tySdYbhove+U/e0LPEBlJj0yiLUm9paU2 X-Received: by 2002:a05:6000:491d:b0:47f:ec8a:214f with SMTP id ffacd0b85a97d-47fec8a2195mr6168363f8f.15.1785909863308; Tue, 04 Aug 2026 23:04:23 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 08:04:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] x86/alternatives: Rework get_ideal_nops() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Xen-devel References: <20250522150015.555492-1-andrew.cooper3@citrix.com> <20250522150015.555492-3-andrew.cooper3@citrix.com> <99a39800-dbba-4d37-afcb-ae041af648f4@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1785909863-674BE2AC-A40A59FF/0/0 X-purgate-type: clean X-purgate-size: 1898 On 04.08.2026 19:13, Andrew Cooper wrote: > On 02/06/2025 10:57 am, Jan Beulich wrote: >> On 22.05.2025 17:00, Andrew Cooper wrote: >>> --- a/xen/arch/x86/alternative.c >>> +++ b/xen/arch/x86/alternative.c >>> @@ -20,7 +20,7 @@ >>> #define MAX_PATCH_LEN (255-1) >>> >>> #ifdef K8_NOP1 >>> -static const unsigned char k8nops[] init_or_livepatch_const = { >>> +static const unsigned char k8_nops[] init_or_livepatch_const = { >>> K8_NOP1, >>> K8_NOP2, >>> K8_NOP3, >>> @@ -31,22 +31,10 @@ static const unsigned char k8nops[] init_or_livepatch_const = { >>> K8_NOP8, >>> K8_NOP9, >>> }; >>> -static const unsigned char * const k8_nops[ASM_NOP_MAX+1] init_or_livepatch_constrel = { >> ... the (at least visual) connection to ASM_NOP_MAX. Could I talk you into >> adding build time array-size checks for both arrays, to restore the >> connection? > > Sorry, but I have no idea what you're asking for here. BUILD_BUG_ON(ARRAY_SIZE(k8_nops) != ASM_NOP_MAX); BUILD_BUG_ON(ARRAY_SIZE(p6_nops) != ASM_NOP_MAX); > The use of ASM_NOP_MAX was latently buggy before; it was easy to create > a NULL deference if the initialiser wasn't filled in when ASM_NOP_MAX > changed. Partly, yes. But why make it worse when it can be made at least somewhat better? Omitted inner entries are reasonably easy to spot. Omitted trailing entries aren't, hence why even in the original code omitting the array dimension in the definitions and instead having such BUILD_BUG_ON()s would have been more robust. Also note how I said "(at least visual)" - by adding the BUILD_BUG_ON()s, grep-ing for ASM_NOP_MAX will hit here, providing links to the controlled arrays. Personally I consider it entirely plausible to possibly bump ASM_NOP_MAX, as technically we could go up to 15. (Whether going that far is efficient is a separate question.) Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 06:24:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 06:24:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382831.1626108 (Exim 4.92) (envelope-from ) id 1wrV3C-0005kA-8E; Wed, 05 Aug 2026 06:24:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382831.1626108; Wed, 05 Aug 2026 06:24:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrV3C-0005k3-4S; Wed, 05 Aug 2026 06:24:26 +0000 Received: by outflank-mailman (input) for mailman id 1382831; Wed, 05 Aug 2026 06:24:24 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrV3A-0005jx-R2 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 06:24:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrV38-005ySU-NT for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:24:22 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72d709-5cb7-0a2a0a5109dd-0a2a4508c4ec-24 for ; Wed, 05 Aug 2026 08:24:22 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72d716-f659-0a2a45080019-d1558034e9bb-3 for ; Wed, 05 Aug 2026 08:24:22 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4955de8797cso3486835e9.3 for ; Tue, 04 Aug 2026 23:24:22 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e0356d4sm66585515e9.10.2026.08.04.23.24.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 23:24:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785911062; x=1786515862; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tYw3nMG1tYUoCk6J6SHQzZAAsmfDb/DNYKs0P2jRYvU=; b=BKw+klG0iOZHY7/p6fSGWI9gIoLKUs1y3OmBVDlbHJUKdunninKJRXFF54d7IXhk4X nzEQLwUthSQfbUZaNMNHcNVp8BIysHX+gmf1LoxNr4hDCuukfhIr5wn2yPHkqULhGI0H HgLzR0UehJaGJS7aPsJElBrSbkMwm9tEOP8TCBgzhaKPb/DRexD4T7dpw2/i3gmoaxnc mUDObE5c7rdk5o1w0Pt4V2C+cFg36rgEBFC4Rj4UYFUZx+OySY55yNxR/JFLwB/Cp3X3 7xNH2FCoxhs8MQu3PY5RhZsn28Kz0GbmNw/S5ZQRjzud1DjHU9zjMFfNfptfOiZoNh/r L8UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785911062; x=1786515862; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tYw3nMG1tYUoCk6J6SHQzZAAsmfDb/DNYKs0P2jRYvU=; b=Mtg0wE63BuVG6d8R/+TqaZzrLjVcoYC/WYTiAtAd4LrkHIpZ1Z6TDtMpx7gICsY+bJ fdGr1DIAe8/tCDHXgUoEpIhTm5JJYmLpHuCWdu7VIu/JNYL2yeJuAFx0HZDx9+0JzE9/ ML2eg2zP2bJIww9Ctc+h8+xLJlsFFQJ5TDACJqnfn9h4g22G/9QrDjaKY8L3G8j3jQ6n phsVwe65x+lE0tTdCXpioOvOrcHvL9ENcjieySp8Wbaezdrl72nOriDs6rCnUu8hmwaF 2yLuqSE/rbsxGG/gEizkGalOFoUrM8Ypc7mDnYgxuCFMvaB+c9Zd6CN9tdSDovh3ZMIV EsxQ== X-Forwarded-Encrypted: i=1; AHgh+RrIDiufsIns3wDkRvCO9IiGGj/5jbLs6ZyrqUtq0xZzusMfhS/2BXg9rInQVleeNdVHqmLXczQXsgQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YycAXbT2Vvw+Om3C6awHVdVu0zMXUXZzubJMSOIKCWsTll9uqGn TE/V9I8Ikmn1Vl9WXBrkXo3Fdeb5h+NCg1whuKoK9M0ccH4JgJO7j+5MPhBTtejQNA== X-Gm-Gg: AR+sD1165FJ64qxUhY7ODPgmZmd93tlY2O9wHN88siVX42EhOfNmSjpvWv83PectX0z HqAGmmtnhLf4RWeH1AGazWFOYNXnNiB8j6c9dpgFsuvY6zmRTxwcnqF5FRjf+ck4D0fGjgndyIz Xy4DeSF9MQheP4ST3AndccJd8n+cBRkanaZy7AAJzqf/poVb66Z5BgyQcgfS6iFtIlX1DTJRAzW Qnf32P+ZZ6YdsWqYZyzLuvx7PW6frj+/5ewHPhlPXaRXydub3+bHkvizQ4wH8XAsiY+UMHGIDlI VfNUAB3H3qWIeBRnGL5FYgNymciQq/FGNBXd5Wxa+U6fTj7HYvyI56Feu+3d0HwY07xxSZ9M0n/ hP38PasfYzj1TWO1/bQd9KLrQ9P72oWcn6eTMvRX3PMyWRx0oadDyBZhfPYnkLeC8FRkNHVwdGL cgtIRg7+Jd+vUG6MJhIyf+5o1Pr6ygf79vcUFRhoupEZqXoWo86cLLha0DfJNxvDpxIcXiRlCgG HV/o1xX11JkPfUiDB9/7XRpLSDl8ytQv4i3pJmz5xJhOHL1OpQyJGyubbcVhyM= X-Received: by 2002:a05:600c:529b:b0:493:a613:56b2 with SMTP id 5b1f17b1804b1-4994e71d3e5mr47925195e9.8.1785911061197; Tue, 04 Aug 2026 23:24:21 -0700 (PDT) Message-ID: <205b4024-c42f-48b6-a106-913b06485e53@suse.com> Date: Wed, 5 Aug 2026 08:24:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] x86/emul: Introduce x86_decode_lite() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Xen-devel References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-2-andrew.cooper3@citrix.com> <01b27228-fdc0-4546-aa23-2bcdafb22727@suse.com> <1e1a1c4d-5ffc-44b1-b26c-244c9af1f250@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1e1a1c4d-5ffc-44b1-b26c-244c9af1f250@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785911062-D6F5F87B-3799B6E3/0/0 X-purgate-type: clean X-purgate-size: 8566 On 04.08.2026 20:56, Andrew Cooper wrote: > On 03/08/2026 4:26 pm, Jan Beulich wrote: >>> + [0x50 ... 0x5f] = (Known), /* PUSH/POP %reg */ >>> + >>> + [0x62] = 0, /* BOUND, but also EVEX prefix, not implemented. */ >>> + [0x63] = (Known|ModRM), /* MOVSxd */ >>> + >>> + [0x68] = (Known|Imm), /* PUSH $imm */ >>> + [0x69] = (Known|ModRM|Imm), /* IMUL $imm */ >>> + [0x6a] = (Known|Imm8), /* PUSH $imm8 */ >>> + [0x6b] = (Known|ModRM|Imm8), /* PUSH $imm8 */ >>> + [0x6c ... 0x6f] = (Known), /* INS/OUTS */ >>> + [0x70 ... 0x7f] = (Known|Branch|Imm8), /* Jcc disp8 */ >>> + [0x80] = (Known|ModRM|Imm8), /* Grp1 */ >>> + [0x81] = (Known|ModRM|Imm), /* Grp1 */ >>> + >>> + [0x83] = (Known|ModRM|Imm8), /* Grp1 */ >>> + [0x84 ... 0x8e] = (Known|ModRM), /* TEST/XCHG/MOV/MOV-SREG/LEA */ >>> + [0x8f] = 0, /* Grp1A - POP but also XOP prefix, not implemented. */ >> POP doesn't look all that unlikely to be used in inline assembly, and >> hence in alternatives. That said, of course using it with a memory >> operand requires quite a bit of care. > > We have no alternatives playing with the stack (beyond CALL > instructions), and no alternatives which have any net %rsp delta. > > PUSH/POP MEM are rare in general and Xen doesn't have any at all. Well, okay then. Nevertheless I'd like to mention that the encoding can also be used for REG forms. If needed for size reasons, that may or may not be more efficient than adding a NOP or no-op prefix. >>> + [0x90 ... 0x99] = (Known), /* NOP/XCHG %rAX/CLTQ/CQTO */ >>> + >>> + [0x9b ... 0x9f] = (Known), /* FWAIT/PUSHF/POPF/SAHF/LAHF */ >>> + [0xa0 ... 0xa3] = (Known|Moffs), /* MOVABS */ >>> + [0xa4 ... 0xa7] = (Known), /* MOVS/CMPS */ >>> + [0xa8] = (Known|Imm8), /* TEST %al */ >>> + [0xa9] = (Known|Imm), /* TEST %rAX */ >>> + [0xaa ... 0xaf] = (Known), /* STOS/LODS/SCAS */ >>> + [0xb0 ... 0xb7] = (Known|Imm8), /* MOV $imm8, %reg */ >>> + [0xb8 ... 0xbf] = (Known|Imm), /* MOV $imm{16,32,64}, %reg */ >>> + [0xc0 ... 0xc1] = (Known|ModRM|Imm8), /* Grp2 (ROL..SAR $imm8, %reg) */ >>> + >>> + [0xc3] = (Known), /* RET */ >>> + [0xc4 ... 0xc5] = 0, /* LES/LDS but also VEX prefixes, not implemented. */ >> This may bite us sooner or later, due to the VEX-encoded integer insns >> that there are. Of course as long as we don't use this function on >> compiled code, and as long as my "x86: allow Kconfig control over psABI >> level" doesn't come close to going in, that's merely a theoretical >> concern. >> >> Same goes for not supporting the 3-byte opcodes, which also encode >> certain integer insns. > > I have no doubt that we're going to need to add support eventually. > > But, > a) I don't have time right now > b) We have real bugs/limitations right now needing this functionality to > address (patch 5, and the xsave fixes, and bus lock trap enablement) > c) GitlabCI will reliably notice any new alternative instructions that > this can't decode (patch 3) > d) This function is a fastpath during the alternatives patching critical > region (patch 4) > > Option d alone is a good reason not to decode VEX prefixes yet. Personally I think a is most relevant. As said in the later reply, once we start using MSR-IMM insns, at least VEX3 map 7 will need decoding anyway. >>> + [0xe4 ... 0xe7] = (Known|Imm8), /* IN/OUT $imm8 */ >>> + [0xe8 ... 0xe9] = (Known|Branch|Imm), /* CALL/JMP disp32 */ >>> + >>> + [0xeb] = (Known|Branch|Imm8), /* JMP disp8 */ >>> + [0xec ... 0xef] = (Known), /* IN/OUT %dx */ >>> + >>> + [0xf1] = (Known), /* ICEBP */ >>> + >>> + [0xf4] = (Known), /* HLT */ >>> + [0xf5] = (Known), /* CMC */ >>> + [0xf6 ... 0xf7] = (Known|ModRM), /* Grp3, Further ModRM decode */ >>> + [0xf8 ... 0xfd] = (Known), /* CLC ... STD */ >>> + [0xfe ... 0xff] = (Known|ModRM), /* Grp4 */ >>> + }; >>> + static const uint8_t init_or_livepatch_const twobyte[256] = { >>> + [0x00 ... 0x03] = (Known|ModRM), /* Grp6/Grp7/LAR/LSL */ >> Leaving out INVD is surely find, but WBINVD? > > Given now expensive WBINVD is, what possible reason can you think for > having it in an alternative ? It's more like e.g. WBNOINVD, which could appear in an alternative in principle, if its encoding didn't mean WBINVD anyway on older hardware. >>> + [0x0b] = (Known), /* UD2 */ >>> + >>> + [0x18 ... 0x1f] = (Known|ModRM), /* Grp16 (Hint Nop) */ >>> + [0x20 ... 0x23] = (Known|ModRM), /* MOV %cr/%dr */ >>> + >>> + [0x30 ... 0x33] = (Known), /* WRMSR/RDTSC/RDMSR/RDPMC */ >>> + >>> + [0x40 ... 0x4f] = (Known|ModRM), /* CMOVcc */ >>> + >>> + [0x80 ... 0x8f] = (Known|Branch|Imm), /* Jcc disp32 */ >>> + [0x90 ... 0x9f] = (Known|ModRM), /* SETcc */ >>> + >>> + [0xa0 ... 0xa2] = (Known), /* PUSH/POP %fs/CPUID */ >>> + [0xa3] = (Known|ModRM), /* BT */ >>> + [0xa4] = (Known|ModRM|Imm8), /* SHLD $imm8 */ >>> + [0xa5] = (Known|ModRM), /* SHLD %cl */ >>> + >>> + [0xa8 ... 0xa9] = (Known), /* PUSH/POP %gs */ >>> + >>> + [0xab] = (Known|ModRM), /* BTS */ >>> + [0xac] = (Known|ModRM|Imm8), /* SHRD $imm8 */ >>> + [0xad ... 0xaf] = (Known|ModRM), /* SHRD %cl/Grp15/IMUL */ >>> + >>> + [0xb0 ... 0xb9] = (Known|ModRM), /* CMPXCHG/LSS/BTR/LFS/LGS/MOVZxx/POPCNT/UD1 */ >>> + [0xba] = (Known|ModRM|Imm8), /* Grp8 */ >>> + [0xbb ... 0xbf] = (Known|ModRM), /* BTC/BSF/BSR/MOVSX */ >>> + [0xc0 ... 0xc1] = (Known|ModRM), /* XADD */ >> What about MOVNTI? > > I judged that to be on the unlikely side to be needed. Hmm, I'm not going to insist, but I think we'd better have it right away. >>> + [0xc7] = (Known|ModRM), /* Grp9 */ >>> + [0xc8 ... 0xcf] = (Known), /* BSWAP */ >>> + }; >> What about UD0? > > UD0 differs between vendors and product lines from Intel. Would you mind leaving a commented (to this effect) 0 entry? >>> + if ( mod == 1 ) /* disp8 */ >>> + FETCH(int8_t); >>> + else if ( mod == 2 ) /* disp32 */ >>> + { >>> + disp32: >>> + FETCH(int32_t); >>> + } >> In several cases the FETCH()ed value isn't used. Compilers as well as Eclair >> (and alike) are happy with that? > > Yes.  The cover letter has a fully passing pipeline. Which you know as well as I do, says next to nothing, as we don't even come close to covering the complete version range. That said, it's likely good enough. I'm merely surprised no tool has to say anything about these unused "return" values of the macro. >>> --- a/xen/arch/x86/x86_emulate/x86_emulate.h >>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.h >>> @@ -835,4 +835,18 @@ static inline void x86_emul_reset_event(struct x86_emulate_ctxt *ctxt) >>> ctxt->event = (struct x86_event){}; >>> } >>> >>> +/* >>> + * x86_decode_lite(). Very minimal decoder for managing alternatives. >>> + * >>> + * @len is 0 on error, or nonzero on success. If the instruction has a >>> + * relative field, @rel_sz is nonzero, and @rel points at the field. >>> + */ >>> +typedef struct { >>> + uint8_t len; >>> + uint8_t rel_sz; /* bytes: 0, 1 or 4 */ >> Perhaps use bitfields in favor of fixed-width integers, seeing what >> ./CODING_STYLE says? > > No.  That destroys the code generation improvements gained by returning > a pair like this in the first place. I was under the pretty clear impression that halfway recent compilers treat 8-bit bitfields the same as uint8_t ordinary fields. (And no, I did by no means suggest to shrink the width of the fields.) Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 06:34:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 06:34:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382842.1626117 (Exim 4.92) (envelope-from ) id 1wrVCl-0007Xk-6z; Wed, 05 Aug 2026 06:34:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382842.1626117; Wed, 05 Aug 2026 06:34:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVCl-0007Xd-3s; Wed, 05 Aug 2026 06:34:19 +0000 Received: by outflank-mailman (input) for mailman id 1382842; Wed, 05 Aug 2026 06:34:17 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVCj-0007XE-HE for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 06:34:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrVCi-00Gy9x-5H for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:34:16 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72d95b-e002-0a2a0a5209dd-0a2a4509e9e4-30 for ; Wed, 05 Aug 2026 08:34:16 +0200 Received: from [40.107.208.18] (helo=PH0PR06CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72d964-be1a-0a2a45090019-286bd0120776-3 for ; Wed, 05 Aug 2026 08:34:13 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by SJ0PR03MB5390.namprd03.prod.outlook.com (2603:10b6:a03:283::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Wed, 5 Aug 2026 06:34:10 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Wed, 5 Aug 2026 06:34:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lTVC3FtCvy+VigUE4FqzJ62CA+rpBXz039+lraKmhc1s29p/jQz3Ftj8XGNTVaFX2amJFNEuCk0e0SArgENnl9STmUZzUx1Gugk2UNtxBSBwyCW+APthsOP5JmWv5/e6bvGlsQeswgcCsPY16l4s2sG/INW1hVJPBmf1LdhCYjYRmg+bmwtieGhxT+7yRGqcIWiWm7uHkRBDoMhCOxoY+/Bg7teNSLuU45tLXqxJjtF38agDh0rYrJ7Y140eiV/goJ33TwRMTGhV6x07XbaXEplp3IC7ZJK+2MdNRJKfFwUfMjPQXQlyMNv/BG3fPL0p03Jr7Wfmtt+xkf65NGeciA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GLC7heUy9BDy1rqMYEtuJeVL80ZKUo5HkS3gzicNHuc=; b=QM6JLM09VXeMnfOnnKXBYi0mnrmDfhExdoDs9xCBFA60XXZcH8KfV1Q01r7MgtPhMp3bdxs28XPSgeg40hOtByZLjggNmJr28uux+mQQBsmOUW/RBtKQdRJmHwOPOgcpAB8cRQiftaJFWO50H2fSNAbxMwZxMcF6RN0bIaqVYGVebti07MMxZvyLAsKtHgBwgJ4K0B2oYIma8qgDUYtZpTeZPs4bhkcjHx7WEu36WWQFk7w9LKsK2+CYw40ltxq1nSyogxRb09M71poufoHv1aJQ3PX013sXbb3BZIal3FKmaX52b6OaNfuG0Y7EAodnhPeK+IBn0lUSGDUE6w099Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLC7heUy9BDy1rqMYEtuJeVL80ZKUo5HkS3gzicNHuc=; b=0ncq+SGxjDYfBQuE17MDuQaFshKpO7Lk2fMqyco+rcVATt7zQy0mGZbm3oywDGj3yKxgklkYbUI1vcyHiom1CGv8VEOb44mTVdR+KABfvwIvtOH14t4d6Tx3VfE5bYDLHKAEkLiSuoHpKFDhTgNt3xaYqQg+lAmQTYzLXsNSzt8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5d62cfe6-3d97-44f4-9a5f-94b77514b6a3@citrix.com> Date: Wed, 5 Aug 2026 07:34:07 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Xen-devel Subject: Re: [PATCH 2/3] x86/alternatives: Rework get_ideal_nops() To: Jan Beulich References: <20250522150015.555492-1-andrew.cooper3@citrix.com> <20250522150015.555492-3-andrew.cooper3@citrix.com> <99a39800-dbba-4d37-afcb-ae041af648f4@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0349.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::12) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|SJ0PR03MB5390:EE_ X-MS-Office365-Filtering-Correlation-Id: f169db0f-e7c0-4ff6-a43b-08def2bb8ecc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|22082099003|18002099003|4143699003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: UfjzMX1qQVDhLtkP6UitkOyfB46TynpEaxj1ORrxUb0L38i+IPytyCY4glh1y2nA8B9P0BUhYvz8yh0MjFtV9EFZff+zCN5+/j4AgTaWEjSkguxFMdJxT4B2IEGYkx/YlIYwR7lQy987o2kem5kibOrTky3SQGtyjOoHoQhL2VpV1Eoj8X9OAZ+ZErscCfmIYMs8LBU+mYEyYjXnNakbO3mkF6vhTISZunnDJ3458asZiXOPABYKD6Zuor81yZpJXTiMjHAuVvhyYlADr2/yFuG+jMzJkN1cBmxHytaD+yYfcrsYvUgMCrRrODYAgf1ZKEqyzFZToTUTPR3+E/zE/1BG5AHL8eNifx2IEnmcKbEJ0q28iIZwGZWrAKD3Sb7KlyNLrPwOsKhsMcvCwrheZCDtWuqRrvy8Eb+Xx1IKVTTXybW8Wo5b389/4T4D5V7qF7AK78CH8R6hAwgblRc9TXJN/WurUJ5ZhbY44FJkpVOVBOMgpXUFbupfm1SbmaYlcXhxUOGfQCtww9UUdIlF4uOr61Dk6HjG/nxQlB7vF0yxMgJrI18sqbFuh395k21fYOX1b5dGbZxGppWBtig9mifhhxObs3KkVotMObZjFQId+9e1HY03ymUgPLWIQFsmot2l+HDNKSxnupqXLEPV0N6afa6ZXlmuTxymTac5j08= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(22082099003)(18002099003)(4143699003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3pyakJHeEE2V2QyU2ZvUzF0cXVYSzREOEpNc1FFcWJRNHhpb3hNdGdQVjAx?= =?utf-8?B?NTEwdnNBWE5NbXNWemRud1J5N1ZOb1VmMmhVVEtqdytUaTFlTGFYM1UzdTBJ?= =?utf-8?B?ZjIzeHJhaGFUaVlMT3pZSEZUMC9sWm1SWWtkSDFYY2puNFlKcUtBSEtkK3VC?= =?utf-8?B?ZE1RZXlXUUZVNFBUSWJWQ0s2K29vN21KeFJGQVROYk5kOHNISnNUQ2IrMXBx?= =?utf-8?B?clo1c1g2TmhDdHNkN2tsbnJEZEZKOTZOb213VEdubDlrQWlINmUzOTZwYVVL?= =?utf-8?B?TjZYZGRRS2daMEw0K2dFZTU2eWdFWnZWdkJ4RHQ0STNyVVUybEtub3doZmFB?= =?utf-8?B?cjZaREVEWHQ4TDhjL1FzR3J2UEpzK2Z1cXdYMGRyK212Z1Y2V01FWjdueVFK?= =?utf-8?B?TFVxaVpSaHE2Sk1SY2pURVBOTzhtVGlXQStlZXdTVVMweHhCTnBjcnE4ZVIx?= =?utf-8?B?NUlsNm5uTU5uVWJZSllyVG9sWlYwSC91Ym5MN3ZGd2NjTGVSNXAzQkUxL1Rr?= =?utf-8?B?dUlGY3NrdzNPVmJ2VDFJUzlNcVkzUnF6OU9tTjh4S0duYW5TRDJZUzFzaXZ4?= =?utf-8?B?YlU3TytLZmNKWXpsNGVHRGVVMWYraUFXcDJuR1BvZ3Y4RXNuUmZ4UXZpSnJm?= =?utf-8?B?SkpvajZiMWdaRThhREhFd1MyTHQrdlJRRFBBVG5TMU9aRzRoVndWek1IVTdL?= =?utf-8?B?Y0lEamw4M3hweUFRWFFPZm5yZnQweURLYnpic3E5b0U1Uzc2MXg2TkZmVXBF?= =?utf-8?B?QmNYN2tndDlqb2ZaczdkSld6MGpDa29VSVBuR2x2WWljbGlxYllrOWtjbFFj?= =?utf-8?B?dHhYSEFwRFBlZnpPNnlOV0JNRzd3OXpYWVRDZGprWWZNVUVsZms0SENvYU4z?= =?utf-8?B?SzVtNTYrUHpuOGlPTkQ3Nm11bGFRNGUvTytRU0tWc0xvVlM2c1BqakJwYity?= =?utf-8?B?bWFQUUh3YTRSUnd4V2RFcnFQeVFIcU81R0xOVGZUL1BMM0dCSDVGWkdLL003?= =?utf-8?B?aFBkeXNFWFFPOFk2TUYxN2NtV3EycVI4SVF1Vi8zamFmSmd2SVZEeUMwbHJ4?= =?utf-8?B?UEdPNnVQZ2Z2UWZSanNsQm9OTks5V0phR0Nuc3V3cVA5ei9hVytMYUd1WVRK?= =?utf-8?B?TTBGaGRTdUMwQStxUDlvUllCMmNLbWVLbzNFdDBpUnd6ZUhYWTdVOGwrWm9i?= =?utf-8?B?M0l2VVdraHNJSlRWL1JOakFTQXdQdDF5U2RBRG5ORjZkanhzZXZrRU8zMGVn?= =?utf-8?B?N09yVk9kaEpsMUFzNmNFTitjbzQ4RmhLUTI3KzJZODd4SjF3eXVDMVRNU2Jo?= =?utf-8?B?eW5aLzNDaE9WNThKbnlzck4vNnFlZHI1bFNtSVB0a3BiZ002UUl2bG45aVRu?= =?utf-8?B?eFY5bk1laFhZUGFGV2EydmVIZTBQY0E4Tnlpa2VnMndzbFB6TUlvL1RVUW9q?= =?utf-8?B?akI3WkY4SUxKMmk0TUplUkFXSjB0RXNjRDdPeHdLSk1zMDFGMW1PNjFneSt5?= =?utf-8?B?RCsrMXBnclVrN0dLS2cvZW5TUE5TbU5WKzd5amNGVzFSUE93T2wvOHdHeVpV?= =?utf-8?B?eUhMNWEzUEtIc0ZBc2pqRk9CZ2d0NzRQbXFCMFdFVEE0WEw1VTUram5xd1JG?= =?utf-8?B?eEszKzUzSmR0K2xqNk5uNUlTL3E4bWhRcUFFemsrWUk1b3U0Z3Z5WFJPdUU4?= =?utf-8?B?SzV0VGZkRWlFMC9UYU1aYnVLTjk0OXBLWWw5NHZOYjUvU1BjNElXZlRhYk96?= =?utf-8?B?aFA5U1hJVmhHQWEvRElrem5OVXZhNU53cGxObGE0ZzRrNVZub25CTFpubE5L?= =?utf-8?B?cnZBcTAvaU56ekEzY2gxVmM2MkZsYWtDUyt4TGpmb1hrQzJmdEZNV3l6NlhE?= =?utf-8?B?VmtRWDM1N0pVQlVVNGlVemhuWGRnUmxoYUI3ZktkSFBUekZWNlYyaWVnbE1Y?= =?utf-8?B?eElLazhOdnZpVGZxMi84ZEsrN2g4UDhFUlBCMm5PRDFKUlcyZ0EwcjRWN3Nq?= =?utf-8?B?d0xGMnJJRHdsK1dYaEdGWTgva25TRmY2RUhUTSs0RCt4V2lpYmx4MURyelAv?= =?utf-8?B?NE9KeTdnM3NvVW5mTXdEMlRxd1pwT2RZcUIxSHRDNHhQcVJQb2Z1RnFZbXNQ?= =?utf-8?B?VXh1NW0vQ3E4TUZvVTN4RlBkSlRQV0Q2RGdCdkFXeVU3UWNPb0dnbW5RaUpo?= =?utf-8?B?RS9FTW94UnpsV2FrNzVURklNaUZXNXBLZVhta3k2Q1NhenZCLzhLVko4Rllk?= =?utf-8?B?S0pheUE1YjY4R04wcDQyUk9EVEEyZ2hibnVCcVpUV0d5OTFKMTY0ODRlWW53?= =?utf-8?B?ak9Zbk9FK1ZoeE8zbVUvKzRPNldOemVhM0xyVXNZNnNnYStkSkkyYktHKzU3?= =?utf-8?Q?Wn3xmJXuw2vPXprI=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f169db0f-e7c0-4ff6-a43b-08def2bb8ecc X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 06:34:10.2548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LX3taPssTcnlDsPKLVJpkD5s3NR7FrdXicefjtY4w9Q0he22/nS5r5pb+72k/yFgGovU4rl0DWZMG0Ys2Q5rSB0WPn2RrsbASJ3XDJAFjEg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5390 X-purgate-ID: tlsNG-bad1c0/1785911654-BEEDE034-37D86F9B/0/0 X-purgate-type: clean X-purgate-size: 1622 On 05/08/2026 7:04 am, Jan Beulich wrote: > On 04.08.2026 19:13, Andrew Cooper wrote: >> On 02/06/2025 10:57 am, Jan Beulich wrote: >>> On 22.05.2025 17:00, Andrew Cooper wrote: >>>> --- a/xen/arch/x86/alternative.c >>>> +++ b/xen/arch/x86/alternative.c >>>> @@ -20,7 +20,7 @@ >>>> #define MAX_PATCH_LEN (255-1) >>>> >>>> #ifdef K8_NOP1 >>>> -static const unsigned char k8nops[] init_or_livepatch_const = { >>>> +static const unsigned char k8_nops[] init_or_livepatch_const = { >>>> K8_NOP1, >>>> K8_NOP2, >>>> K8_NOP3, >>>> @@ -31,22 +31,10 @@ static const unsigned char k8nops[] init_or_livepatch_const = { >>>> K8_NOP8, >>>> K8_NOP9, >>>> }; >>>> -static const unsigned char * const k8_nops[ASM_NOP_MAX+1] init_or_livepatch_constrel = { >>> ... the (at least visual) connection to ASM_NOP_MAX. Could I talk you into >>> adding build time array-size checks for both arrays, to restore the >>> connection? >> Sorry, but I have no idea what you're asking for here. > BUILD_BUG_ON(ARRAY_SIZE(k8_nops) != ASM_NOP_MAX); > BUILD_BUG_ON(ARRAY_SIZE(p6_nops) != ASM_NOP_MAX); The arrays are 45 bytes (and elements) long.  ASM_NOP_MAX is 9. > >> The use of ASM_NOP_MAX was latently buggy before; it was easy to create >> a NULL deference if the initialiser wasn't filled in when ASM_NOP_MAX >> changed. > Partly, yes. But why make it worse when it can be made at least somewhat > better? On the contrary, I've removed an incorrect (and ineffective) attempt to tie to ASM_NOP_MAX, and consider this form better than what was there before. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 06:45:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 06:45:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382851.1626125 (Exim 4.92) (envelope-from ) id 1wrVNe-0000yE-4o; Wed, 05 Aug 2026 06:45:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382851.1626125; Wed, 05 Aug 2026 06:45:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVNe-0000y7-2C; Wed, 05 Aug 2026 06:45:34 +0000 Received: by outflank-mailman (input) for mailman id 1382851; Wed, 05 Aug 2026 06:45:32 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVNc-0000y1-8o for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 06:45:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrVNb-00B8I4-1D for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:45:31 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72dc07-5cb7-0a2a0a5109dd-0a2a450bed12-14 for ; Wed, 05 Aug 2026 08:45:30 +0200 Received: from [209.85.221.50] (helo=mail-wr1-f50.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72dc0a-b7e8-0a2a450b0019-d155dd32f15f-3 for ; Wed, 05 Aug 2026 08:45:30 +0200 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47f7872abb6so275049f8f.3 for ; Tue, 04 Aug 2026 23:45:30 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfda0d7sm5935370f8f.2.2026.08.04.23.45.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 23:45:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785912330; x=1786517130; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LdT17TjKaxzE87YoDYMRL848nK49edta2evd9yGu/dI=; b=YZpqR9qDSxMDRClRcahcKvJSkgQTLv+4UM7S+rCunLQGcVzdaOHlBHpy6gfWJLNB7M 6m2DSEgBCBYfJYVpIdUOnV95yDIVIMvf9JHmm3eKBPCChabzLAK3Uc3CHuee27bB2fJF tM4Fyw+VKSAays2G9cHIWAtw7ddZHIxNzHfdwg6ABk0NEDUowl+uabGAQD5P6ikxrNur afb0UwKycuLneVGvyqQaiih1ZWaszGt6LsagXPsuI5F+u+RFHN3Tmnms67OfLVAO0vrt PW0uLcH/wjdldv2I6VGgG7X1arMgv8fSpbPWCRJVw7l/8JSlS/b5IFrviUBEaiilbZaJ G6yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785912330; x=1786517130; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LdT17TjKaxzE87YoDYMRL848nK49edta2evd9yGu/dI=; b=XpoSoBmFKB/wMHgSk4x5QIKma6f7Vle0NdE9eH2k7ww2p1MAeWZYra0+AKzZzE2872 FgEe2v13JBYr2PNZsXkoQaalL9efNE0YHT4g8W+cycwuwwhAjZdGuzRusL3TfPm+2Qj0 LmYPHJzNVTxu0qYySiNNJLhqn/iJFDNnGqw+YC20bcnrtJP7IDSleuFTYERjpxglZCMK tcFxbsfJ2LIlMxnGiwuyhkosd1wSjBi178YLOGXiVmcVoDFpFx+uBe6lvhmWqfHAAjSh iBExTm2eT7igz8XePkiD8on5LzCpduQWSppwWr7Dq8jVsFE9dnkOAtqWJw13BXlxgtKB 6jTw== X-Forwarded-Encrypted: i=1; AHgh+RpJ/XkPwCOUKOQV+pgXArRgfXfkwrjgzdIt8SZXCS1bOmZoI6gYIsVF+DuhsN8afeStWYAevEVzwqI=@lists.xenproject.org X-Gm-Message-State: AOJu0YyID3S67iv4nS7YDwHonZjpcXIEvp9nlNTvKw8yJKp9DYoBX2Tu z6/0yfkojW09L+li3VSQ3PbtSzoGTNuCWhWbEx1TXmAygECjKn8LVnJ2BnoTvprYVoGLEEu/tiU 5aJGVfg== X-Gm-Gg: AR+sD107p/W1NTaZOYaEUU5SogbOtAWzxHDusXVB6/OBfvdXtGa++z5vKh1dvxpzodn vsi+Qc9nXf29ySZszhUmURNNSc67npQsnUWqQY3YvPQLkmy1HtFS6MVgZumV47POuKBX+KEogC6 4qjtN4msCX4gPj8/DrB/O4GW4j+DuMeYuoMWOD3i7gFYkygTObi0YDE8fs2UPYxTkx+mclIIeRv Df/aSgSAl2WSoeESlcdJ4vQK+SONtytvY/WSuf3DCBmveWPI1/Zkqp+sNwX4tB75P0kCK2FbhJV eFmKxuZEEywwoUcD3PvPWXSJ4n2l7Irj9/4oHIIr54jQS/25zr4VlcPMSGUURh/QfTFE+k0UmIV mM1iWH995ZvIhEzsjCUe2hlznBDwmtKvM4j2ab8PVwgN3OaWrMHzYfiGNa6NhPROZzrYB6m+dv0 YJ+m8lARog3pHYNPTxOXQBVSPlN7lkiQVKxVqKyARiccJGn2PhwU8/1PlKq5kFWu3unA4Ha8Pcj exEfbu4QvroZJ6xaolUQQF2D64CcYXdsjLy5s/yhAOMb9GhE4pd X-Received: by 2002:a05:6000:601:b0:47f:81c4:36b4 with SMTP id ffacd0b85a97d-47fec52172amr6515452f8f.14.1785912330171; Tue, 04 Aug 2026 23:45:30 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 08:45:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] tests/x86: Introduce a userspace test harness for x86_decode_lite() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Xen-devel References: <20260803072006.9678-1-andrew.cooper3@citrix.com> <20260803072006.9678-3-andrew.cooper3@citrix.com> <21d3fae8-e9b0-4c8a-a7b9-483a0257e44e@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <21d3fae8-e9b0-4c8a-a7b9-483a0257e44e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785912330-A9EC69EA-AD3522B9/0/0 X-purgate-type: clean X-purgate-size: 13130 On 04.08.2026 21:37, Andrew Cooper wrote: > On 03/08/2026 5:03 pm, Jan Beulich wrote: >> On 03.08.2026 09:20, Andrew Cooper wrote: >>> --- /dev/null >>> +++ b/tools/tests/x86-decode-lite/insns.S >>> @@ -0,0 +1,703 @@ >>> +#include "macro-magic.h" >>> + >>> + .code64 >>> + >>> + .allow_index_reg >>> + >>> + .text >>> + >>> +DECL(tests_rel0) >>> +modrm: >>> + /* Mod=0, Reg=0, RM {0..f} */ >>> + _ add %al, (%rax) >>> + _ add %al, (%rcx) >>> + _ add %al, (%rdx) >>> + _ add %al, (%rbx) >>> + _ add %al, (%rsp) /* SIB */ >>> + /*add %al, (%rbp) RIP --> tests_rel4 */ >>> + _ add %al, (%rsi) >>> + _ add %al, (%rdi) >>> + _ add %al, (%r8) >>> + _ add %al, (%r9) >>> + _ add %al, (%r10) >>> + _ add %al, (%r11) >>> + _ add %al, (%r12) /* SIB */ >>> + /*add %al, (%r13) RIP --> tests_rel4 */ >>> + _ add %al, (%r14) >>> + _ add %al, (%r15) >>> + >>> + /* Mod=1, Reg=0, RM {0..f} */ >>> + _ add %al, 0x01(%rax) >>> + _ add %al, 0x01(%rcx) >>> + _ add %al, 0x01(%rdx) >>> + _ add %al, 0x01(%rbx) >>> + _ add %al, 0x01(%rsp) /* SIB */ >>> + _ add %al, 0x01(%rbp) >>> + _ add %al, 0x01(%rsi) >>> + _ add %al, 0x01(%rdi) >>> + _ add %al, 0x01(%r8) >>> + _ add %al, 0x01(%r9) >>> + _ add %al, 0x01(%r10) >>> + _ add %al, 0x01(%r11) >>> + _ add %al, 0x01(%r12) /* SIB */ >>> + _ add %al, 0x01(%r13) >>> + _ add %al, 0x01(%r14) >>> + _ add %al, 0x01(%r15) >>> + >>> + /* Mod=2, Reg=0, RM {0..f} */ >>> + _ add %al, 0x7f000001(%rax) >>> + _ add %al, 0x7f000001(%rcx) >>> + _ add %al, 0x7f000001(%rdx) >>> + _ add %al, 0x7f000001(%rbx) >>> + _ add %al, 0x7f000001(%rsp) /* SIB */ >>> + _ add %al, 0x7f000001(%rbp) >>> + _ add %al, 0x7f000001(%rsi) >>> + _ add %al, 0x7f000001(%rdi) >>> + _ add %al, 0x7f000001(%r8) >>> + _ add %al, 0x7f000001(%r9) >>> + _ add %al, 0x7f000001(%r10) >>> + _ add %al, 0x7f000001(%r11) >>> + _ add %al, 0x7f000001(%r12) /* SIB */ >>> + _ add %al, 0x7f000001(%r13) >>> + _ add %al, 0x7f000001(%r14) >>> + _ add %al, 0x7f000001(%r15) >>> + >>> + /* Mod=3, Reg=0, RM {0..f} */ >>> + _ add %al, %al >>> + _ add %al, %cl >>> + _ add %al, %dl >>> + _ add %al, %bl >>> + _ add %al, %ah >>> + _ add %al, %ch >>> + _ add %al, %dh >>> + _ add %al, %dl >> Perhaps also include %bpl, %sil, and %dil? > > They're not relevant to this test, and interfere with the intentional > pattern set up. Hmm, how does a particular pattern matter here? I don't think you test those cases (or more generally an empty REX prefix) anywhere else. >>> +DECL(tests_rel1) >>> +disp8: >>> +1: >>> + _ jo 1b >>> + _ jno 1b >>> + _ jb 1b >>> + _ jae 1b >>> + _ je 1b >>> + _ jne 1b >>> + _ jbe 1b >>> + _ ja 1b >>> + _ js 1b >>> + _ jns 1b >>> + _ jp 1b >>> + _ jnp 1b >>> + _ jl 1b >>> + _ jge 1b >>> + _ jle 1b >>> + _ jg 1b >>> + _ jmp 1b >>> + >>> +disp8_rex: >>> + _ rex.w jo 1b >>> + _ rex.w jno 1b >>> + _ rex.w jb 1b >>> + _ rex.w jae 1b >>> + _ rex.w je 1b >>> + _ rex.w jne 1b >>> + _ rex.w jbe 1b >>> + _ rex.w ja 1b >>> + _ rex.w js 1b >>> + _ rex.w jns 1b >>> + _ rex.w jp 1b >>> + _ rex.w jnp 1b >>> + _ rex.w jl 1b >>> + _ rex.w jge 1b >>> + _ rex.w jle 1b >>> + _ rex.w jg 1b >>> + _ rex.w jmp 1b >>> +END(tests_rel1) >> What's the idea behind the separate REX.W testing? > > Testing osize handling vs Imm8/Imm. I see, albeit I very much hope osize would never, ever have an effect on Imm8 encodings, as far as the size of the immediate goes. >> It almost suggests that >> tests with an operand size prefix also may want adding. Except that's >> difficult, because of ... >> >>> +DECL(tests_rel4) >>> +disp32: >>> + _ call other_section >>> + _ jmp other_section >>> + _ jo other_section >>> + _ jno other_section >>> + _ jb other_section >>> + _ jae other_section >>> + _ je other_section >>> + _ jne other_section >>> + _ jbe other_section >>> + _ ja other_section >>> + _ js other_section >>> + _ jns other_section >>> + _ jp other_section >>> + _ jnp other_section >>> + _ jl other_section >>> + _ jge other_section >>> + _ jle other_section >>> + _ jg other_section >>> + _ xbegin other_section >>> + >>> +disp32_rex: >>> + _ rex.w call other_section >>> + _ rex.w jmp other_section >>> + _ rex.w jo other_section >>> + _ rex.w jno other_section >>> + _ rex.w jb other_section >>> + _ rex.w jae other_section >>> + _ rex.w je other_section >>> + _ rex.w jne other_section >>> + _ rex.w jbe other_section >>> + _ rex.w ja other_section >>> + _ rex.w js other_section >>> + _ rex.w jns other_section >>> + _ rex.w jp other_section >>> + _ rex.w jnp other_section >>> + _ rex.w jl other_section >>> + _ rex.w jge other_section >>> + _ rex.w jle other_section >>> + _ rex.w jg other_section >>> + _ rex.w xbegin other_section >> ... vendor differences here. Perhaps the decoder itself would better >> reject handling of operand-size-prefixed branches. > > Excluding 66-prefix is easy, but excluding rex.w on jumps is hard and > would require extra logic. To exclude 66 is all I was suggesting. REX.W isn't treated differently by the vendors, afaik, likely simply because it's meaningless altogether for these insns. >>> +opsize_branch: /* 66-prefixed branches are decoded differently by vendors */ >>> + _ data16 call other_section >>> + _ data16 jmp other_section >>> + _ data16 jo other_section >>> + _ data16 jno other_section >>> + _ data16 jb other_section >>> + _ data16 jae other_section >>> + _ data16 je other_section >>> + _ data16 jne other_section >>> + _ data16 jbe other_section >>> + _ data16 ja other_section >>> + _ data16 js other_section >>> + _ data16 jns other_section >>> + _ data16 jp other_section >>> + _ data16 jnp other_section >>> + _ data16 jl other_section >>> + _ data16 jge other_section >>> + _ data16 jle other_section >>> + _ data16 jg other_section >>> + _ data16 xbegin other_section >> Oh, you even cover the case here. For XBEGIN, however, this can only be pure >> guesswork as to AMD behavior, I suppose. > > Remember that RTM is available on Zen2 if you know which chickenbits to > clobber. > > I've not tried.  I expect it's more likely that they behave consistently > than differently. > >> I also don't see how you force which form you want. > > Binutils always produces AMD behaviour.  (As far as I can see.) By default, yes. Quite some time ago CALL and JMP were covered more correctly, via the -mamd64 / -mintel64 cmdline options. Not very long ago I realized we had never extended that to Jcc. > This is in the negative-tests section, which confirms that > x86_decode_lite() rejects the byte pattern. > > If Binutils changes behaviour, the test will start failing. Changing the default behavior seems extremely unlikely to me. Changing the non default behavior, otoh, has happened (and if need be could happen again). Anyway, all of this is becoming moot if 66 was rejected on branches. >>> --- /dev/null >>> +++ b/tools/tests/x86-decode-lite/main.c >>> @@ -0,0 +1,111 @@ >>> +/* >>> + * Userspace test harness for x86_decode_lite(). >>> + */ >>> +#include >>> + >>> +#include "x86-emulate.h" >>> + >>> +static unsigned int nr_failures; >>> +#define fail(t, fmt, ...) \ >>> +({ \ >>> + const unsigned char *insn = (t)->ip; \ >>> + \ >>> + nr_failures++; \ >>> + \ >>> + (void)printf(" Fail '%s' [%02x", (t)->name, *insn); \ >>> + for ( unsigned int i = 1; i < (t)->len; i++ ) \ >>> + printf(" %02x", insn[i]); \ >>> + printf("]\n"); \ >>> + \ >>> + (void)printf(fmt, ##__VA_ARGS__); \ >>> +}) >>> + >>> +struct test { >>> + const char *name; >>> + void *ip; >>> + unsigned long len; >>> +}; >>> + >>> +extern const struct test >>> +/* Defined in insns.S, ends with sentinel */ >>> + tests_rel0[], /* No relocatable entry */ >>> + tests_rel1[], /* disp8 */ >>> + tests_rel4[], /* disp32 or RIP-relative */ >>> + tests_unsup[]; /* Unsupported instructions */ >>> + >>> +static inline void run_tests(const struct test *tests, unsigned int rel_sz) >>> +{ >>> + printf("Test rel%u\n", rel_sz); >>> + >>> + for ( unsigned int i = 0; tests[i].name; ++i ) >>> + { >>> + const struct test *t = &tests[i]; >>> + x86_decode_lite_t r; >>> + >>> + /* >>> + * Don't end strictly at t->len. This provides better diagnostics if >>> + * too many bytes end up getting consumed. >>> + */ >>> + r = x86_decode_lite(t->ip, t->ip + /* t->len */ 20); >> For the excess bytes to at least be legitimate to access (not causing UB), >> shouldn't finish_arr emit enough filler bytes? > > finish_arr is the wrong place, but I've folded in: > > diff --git a/tools/tests/x86-decode-lite/insns.S b/tools/tests/x86-decode-lite/insns.S > index e52c2934c8d8..dc017016b2d2 100644 > --- a/tools/tests/x86-decode-lite/insns.S > +++ b/tools/tests/x86-decode-lite/insns.S > @@ -695,6 +695,13 @@ unsup_insn: /* Instructions that would complicated decode, or shouldn't be used >   >  END(tests_unsup) >   > +        /* > +         * For improved diagnostics, we allow some overreading of the > +         * instruction under test.  Ensure there are good bytes to read. > +         */ > +overread_padding: > +        .skip 20 > + >          /* This is here to cause jmps to use their disp32 form. */ >          .section .text.other_section, "ax", @progbits >  other_section: How would this help? run_tests() is never invoked with tests_unsup[] as argument. And run_tests_unsup() wants to only fetch up to t->len. >>> --- /dev/null >>> +++ b/tools/tests/x86-decode-lite/x86-emulate.h >>> @@ -0,0 +1,27 @@ >>> +#ifndef X86_EMULATE_H >>> +#define X86_EMULATE_H >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +#define ASSERT assert >>> + >>> +#define printk(...) >>> + >>> +#define likely >>> +#define unlikely >>> +#define cf_check >>> +#define init_or_livepatch >>> +#define init_or_livepatch_const >>> + >>> +#include "x86_emulate/x86_emulate.h" >> Why does this end up being needed? > > Well, this for starters: > > main.c: In function ‘run_tests’: > main.c:43:9: error: unknown type name ‘x86_decode_lite_t’ >    43 |         x86_decode_lite_t r; >       |         ^~~~~~~~~~~~~~~~~ > main.c:49:13: error: implicit declaration of function ‘x86_decode_lite’ [-Werror=implicit-function-declaration] >    49 |         r = x86_decode_lite(t->ip, t->ip + /* t->len */ 20); >       |             ^~~~~~~~~~~~~~~ Hmm, yes, that should have been obvious, if only I didn't expect decode-lite to be largely (up to entirely) independent of the core emulator, irrespective of its placement in the same dir. x86_emulate/x86_emulate.h is a pretty involved header, which I think would be nice to avoid growing more dependencies on. Then again it looks as if about every object file already depends on it (which imo is bad). Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 06:49:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 06:49:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382860.1626134 (Exim 4.92) (envelope-from ) id 1wrVRO-0001fj-Lx; Wed, 05 Aug 2026 06:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382860.1626134; Wed, 05 Aug 2026 06:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVRO-0001fc-JN; Wed, 05 Aug 2026 06:49:26 +0000 Received: by outflank-mailman (input) for mailman id 1382860; Wed, 05 Aug 2026 06:49:25 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVRN-0001fW-Gh for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 06:49:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrVRM-0063uC-BP for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:49:24 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72dce3-bab6-0a2a0a5309dd-0a2a450cbd62-46 for ; Wed, 05 Aug 2026 08:49:24 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72dcf4-f479-0a2a450c0019-d1558036b104-3 for ; Wed, 05 Aug 2026 08:49:24 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49545ba3d4eso2926475e9.3 for ; Tue, 04 Aug 2026 23:49:24 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e9ad922sm24994565e9.4.2026.08.04.23.49.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 23:49:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785912564; x=1786517364; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5Jhv8pkezYCrgt9JiHXX1n8n4He1/X32jhyGT/X0o+E=; b=Sfd40lHvtRhfDwYrXlZw0jnPuVYono3VgNH5zStwyWBfDHbkVX7ht/rlWQ5kyTgwoT oJKDPaoBWKgwGAm7qNeLNjYZzN4/qg0gLQYA5ImNWFdgAL5T9td8N48tG5YK8moGvTNH uGVQ7DJVSvi/WxXK1VKuf/k7DqQ7G5uI8eEC5mIZtSK2LyUzxYYr5Ma0wostFDjPJoDu BUsQgVxekE5xzc7YgZLQigjcnHeVNByLcHEc9Dfzqp0UZ679Kusy64osNT8uraTSJSvl WsKyPpiBGhBjm0LBGzQmBS7a8mG1cxtnu9XX7EH5wzMMNN4LETanT3aW85YykRRu/LCI e4bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785912564; x=1786517364; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Jhv8pkezYCrgt9JiHXX1n8n4He1/X32jhyGT/X0o+E=; b=cQXSFmelzG/qLPifqvUEys/cg4WU7TY+RpXO3xqzohRyk3ecxtF8iiIx5uzicNLqjf FElksV5sqxsFpHAULmuukvkOupBN235u0npUmv/xNTsmVX2xh11wxn1HCEBOtpLGoduA 5Hs5pbFmQ2xwUpv5K7Vug07HpHC+N04YvHVi9bykiJgtTgo/HvTyd1k+zbjZSXUnapQO kExMElS3Jk0IhkoD6rxQAFQ6iecsLr+8julcWCzt9Jn1EHYDELzwLenZxMMng/ZtPlXv xB73PhwhjBVFBb0VwusDZEsoAtfaVbnFq/5k/1aBhZJZ49cSajnHqsW4/nxOKk+/pDJC PsdA== X-Forwarded-Encrypted: i=1; AHgh+RokGE/voe6uD6z8Hc2RQbMpJMUuW7DC56/e7/EqCtO1b7pxpgz3Sn9+GB6OqjUy0mPabkxeb3n5ac0=@lists.xenproject.org X-Gm-Message-State: AOJu0YwR/aCY0zZ9BgghIwFDrQ5wpw9a0x8ECksHVzKXxTuItdw1k2tK lko5SQuIzDjhU3EG+oZ5/spMXZirXnL9oDPMrbKrNzezWrpncKk/G4dCDQ9aF37hhA== X-Gm-Gg: AR+sD108WU3JhUscCWr6153TphdVGQat9eWNmPy69AGa79jFdHT8k/UGZyDUYDExOO9 7ZXJPpTLnRtFsHzASjRlfDMxrHbEowNQCYRLhQ+j07b8N8a+4l5DmEkysX3A/mM4APk/6httlxE GrFOXAS/QHFuhGuO1uMmHwtaglUPTmt+BcYXaUI0iPbagk1aq34tBfuJf6CpgTiAPsaC8n3X5AC nqIucmeZyp+6YANIaobiz3Vzz2vJhcdJ7JUwIoAbLQ7ANwMtNmRxUg8iiNKiOgn4TBCynGL2F3e wYmbwbEaxIhfVW01EKqua3TucltCptvcEB4GdYWwo/MB2W/F6OTbvU5GQ/DyahONYmFOBq2CLAt nuKhKVmednotkw7y261chhirXYKuwr6vetHtMszM48pr6X0nHq1QEYHcqmuxMjMvrb5vQ6xmPp6 sgzpn5trVKpfnCIV3AMKoryWl3C4IMCB6HKz9JOFAEiwGDt5BxQTFYzN8027DeDIkFwO2z7htXB 9Fd8/NoeCdHR5+dgw9PfIwy/Y3kdCw0WJvazkd7GfX6VhPUkcGu3X/901w+QD0= X-Received: by 2002:a05:600c:1d10:b0:495:7a23:1eee with SMTP id 5b1f17b1804b1-4994e7ba86amr37703665e9.12.1785912563813; Tue, 04 Aug 2026 23:49:23 -0700 (PDT) Message-ID: <3ff21b60-fc6a-46f9-94b7-89393cd77933@suse.com> Date: Wed, 5 Aug 2026 08:49:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] x86/alternatives: Rework get_ideal_nops() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Xen-devel References: <20250522150015.555492-1-andrew.cooper3@citrix.com> <20250522150015.555492-3-andrew.cooper3@citrix.com> <99a39800-dbba-4d37-afcb-ae041af648f4@suse.com> <5d62cfe6-3d97-44f4-9a5f-94b77514b6a3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5d62cfe6-3d97-44f4-9a5f-94b77514b6a3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1785912564-01CC3A5B-E8FA380B/0/0 X-purgate-type: clean X-purgate-size: 1469 On 05.08.2026 08:34, Andrew Cooper wrote: > On 05/08/2026 7:04 am, Jan Beulich wrote: >> On 04.08.2026 19:13, Andrew Cooper wrote: >>> On 02/06/2025 10:57 am, Jan Beulich wrote: >>>> On 22.05.2025 17:00, Andrew Cooper wrote: >>>>> --- a/xen/arch/x86/alternative.c >>>>> +++ b/xen/arch/x86/alternative.c >>>>> @@ -20,7 +20,7 @@ >>>>> #define MAX_PATCH_LEN (255-1) >>>>> >>>>> #ifdef K8_NOP1 >>>>> -static const unsigned char k8nops[] init_or_livepatch_const = { >>>>> +static const unsigned char k8_nops[] init_or_livepatch_const = { >>>>> K8_NOP1, >>>>> K8_NOP2, >>>>> K8_NOP3, >>>>> @@ -31,22 +31,10 @@ static const unsigned char k8nops[] init_or_livepatch_const = { >>>>> K8_NOP8, >>>>> K8_NOP9, >>>>> }; >>>>> -static const unsigned char * const k8_nops[ASM_NOP_MAX+1] init_or_livepatch_constrel = { >>>> ... the (at least visual) connection to ASM_NOP_MAX. Could I talk you into >>>> adding build time array-size checks for both arrays, to restore the >>>> connection? >>> Sorry, but I have no idea what you're asking for here. >> BUILD_BUG_ON(ARRAY_SIZE(k8_nops) != ASM_NOP_MAX); >> BUILD_BUG_ON(ARRAY_SIZE(p6_nops) != ASM_NOP_MAX); > > The arrays are 45 bytes (and elements) long.  ASM_NOP_MAX is 9. Oh, right, sorry: BUILD_BUG_ON(ARRAY_SIZE(k8_nops) != (ASM_NOP_MAX * (ASM_NOP_MAX + 1)) / 2); BUILD_BUG_ON(ARRAY_SIZE(p6_nops) != (ASM_NOP_MAX * (ASM_NOP_MAX + 1)) / 2); Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:06:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 07:06:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382651.1626144 (Exim 4.92) (envelope-from ) id 1wrVha-0004lJ-1B; Wed, 05 Aug 2026 07:06:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382651.1626144; Wed, 05 Aug 2026 07:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVhZ-0004lC-UP; Wed, 05 Aug 2026 07:06:09 +0000 Received: by outflank-mailman (input) for mailman id 1382651; Tue, 04 Aug 2026 21:36:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrMnq-0007Ho-H7 for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 21:36:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrMno-00A65A-UO for xen-devel@lists.xenproject.org; Tue, 04 Aug 2026 23:36:00 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a725b2c-5cb7-0a2a0a5109dd-0a2a4507af30-18 for ; Tue, 04 Aug 2026 23:36:00 +0200 Received: from [209.85.216.41] (helo=mail-pj1-f41.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a725b3f-b4ea-0a2a45070019-d155d829c11a-3 for ; Tue, 04 Aug 2026 23:36:00 +0200 Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3811f512167so293683a91.3 for ; Tue, 04 Aug 2026 14:36:00 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586447d52sm7628775eec.12.2026.08.04.14.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 14:35:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785879358; x=1786484158; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QH2K5FogbEg2Pu5YlCvSeafRigFtD0Kz01lkbZ2ZcwI=; b=e3oalOmoaqQ8EzJ8TAiy6yWYzjW3Zg8NowW2Q502DhBk8Z0pHOxJueLingJBTMFNkc WQJxqwhm3BJt4ZGN7EX6zlM4A+dx+mS1FNmxOc+77XOxyjWdCAoRv0gEktWXyL34Punq Js6uHyPpPgIgnMbSxOyoUl253h2BNwSRKo76bCr3McFKUJGX9EFEahfRrTAyS4+SSZ04 OcoKUDScsE9lQBBuFjXq+b9Fn4tPKtX/EZeG/VKt4bM9uw5A5xINGi7J+CZqa7NDw9GE fL8fIXbK2DPj9EgvCnvF0W0x51o4n7N8gFpuIy31rFct/Ft8muq8UmaP/gUGchkLJTcW 1jcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785879358; x=1786484158; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QH2K5FogbEg2Pu5YlCvSeafRigFtD0Kz01lkbZ2ZcwI=; b=pBIpWKgt5qu0tAnEBsE/+BDWdVnbRRQ9ERKT+0ZTIfWnGZ+H6prRWl33ce4TShNqJA CYLkYR7EQWcXEboiKQ4olrBVsOtjpqGWLiAkSsC34ybB9WhkmE/HpBZe9o1W0P8+/4AX YH7Pf4i+mXOjgFMSpDWWuge5m4Up3f6weme7+UxO8VD4tbFLAn0NZS84UzxVYo5NlKpH x4jXO7R+/w8pc/tzbPaWE0q3bieHXg77n05LBrrbnv6AV29M6Cd4CXWWqlHyV5lq8bdM Xpe2OANp7klwXWGeX/B8l1zdXJ86R9qJwHTAzozH+bE1U9tVjVQQuL4wN6CZi6NM/mRk egig== X-Forwarded-Encrypted: i=1; AHgh+RoI3+Dc1AwZ40fF2o6+TJ4Pi2rdBIlDWtLI9K3yA+1m9z4Oo+Z6r9K6nJ9+RBfXPOQRoDV8cNcg2iQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YyuqgDbxqNQBMWbz45oVZ0GZtLEStGcH9uh5A9X0yFzzHNIwU9p Eigd1qWlmor22Vo0OP0TvCrOym83TInyngumG+8fD/kOosXNuOdNOcHU X-Gm-Gg: AR+sD13WEgdRQ0BaWHaEf2nkfhhxgHXztkeJDcF/OMPs2dRsIkWfdLkXcFil6ku2meL /SrGpOcOAv/OslNsOEkHIGUwfguvaEQDqiksESJCf0cisYyHWHgr2K3a3VvaAR1APNIy2gpQg/p nUMFEM3f3VTquatrjrzDyQEV4RNhSvp3okbg7f58RCXQmqBwb0E+7i2mWmozHRjMOZVgTS3mr07 edeDz7IDNJSg8/h3uwNo+i5MpyeHo0m0JD1vOUMzZ3H/S1onvcVBuFRb/p1lVXhaD1y2za+wxe4 LUA7zhWYJHq6JWzhdVecpUB9CnhTrfofYzVPnWhgdo39tthu4urcj+fwQ/9lBeUfYpxWVpf7ycf 6k0wOnsJRp9XMUCS6WJ+XiOUuyTv+Fn3F9ytVXtYdp3KkW1zgvvzeEeS/fw4uJ7JhEfc1nC2E4D Ocyq95UqywJePt1FMtNWhg7W9cOxk299PH1m96ZmLRgFnqCOPqzVeNDnh/CJN4cb9TF4F61/VgH P3G6A+aNYEtyaZ4nltiU9qbD6FAZRS3Uz+5wP9Bvpg= X-Received: by 2002:a05:6a21:50b:b0:3c3:8aa8:6caf with SMTP id adf61e73a8af0-3cb85efb72bmr1956240637.27.1785879358555; Tue, 04 Aug 2026 14:35:58 -0700 (PDT) From: Yifei Gao To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , v9fs@lists.linux.dev Cc: Christian Schoenebeck , Juergen Gross , Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Yifei Gao , stable@vger.kernel.org Subject: [PATCH] 9p/xen: fix refcount leak in p9_xen_response() on wrong tag Date: Tue, 4 Aug 2026 21:35:49 +0000 Message-ID: <20260804213550.3409638-1-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1785879360-A72DCAE4-3827DD67/0/0 X-purgate-type: clean X-purgate-size: 1323 p9_xen_response() looks up the request for an incoming reply with p9_tag_lookup(), which takes a reference on the returned p9_req_t. When the tag does not resolve to a request in REQ_STATUS_SENT, the function warns and continues the loop without dropping that reference, permanently leaking the p9_req_t and its msize buffers. The reply header, including the tag, is supplied by the backend, so a malicious or buggy 9P backend can leak kernel memory on every crafted response. Drop the reference before continuing, mirroring the equivalent path in trans_fd.c. Fixes: f66c72bea129 ("xen/9pfs: receive responses") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Yifei Gao --- net/9p/trans_xen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index f9fb2db7a066..8eea0da8797f 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c @@ -203,6 +203,8 @@ static void p9_xen_response(struct work_struct *work) req = p9_tag_lookup(priv->client, h.tag); if (!req || req->status != REQ_STATUS_SENT) { dev_warn(&priv->dev->dev, "Wrong req tag=%x\n", h.tag); + if (req) + p9_req_put(priv->client, req); cons += h.size; virt_mb(); ring->intf->in_cons = cons; -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:06:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 07:06:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382798.1626153 (Exim 4.92) (envelope-from ) id 1wrVhl-00050V-8K; Wed, 05 Aug 2026 07:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382798.1626153; Wed, 05 Aug 2026 07:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVhl-00050O-5Q; Wed, 05 Aug 2026 07:06:21 +0000 Received: by outflank-mailman (input) for mailman id 1382798; Wed, 05 Aug 2026 04:46:18 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrTWE-0006vT-0K for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 04:46:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrTWB-00H8EK-T5 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 06:46:15 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72c000-bab6-0a2a0a5309dd-0a2a450ca66e-26 for ; Wed, 05 Aug 2026 06:46:15 +0200 Received: from [209.85.210.181] (helo=mail-pf1-f181.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72c016-f479-0a2a450c0019-d155d2b5d47c-3 for ; Wed, 05 Aug 2026 06:46:15 +0200 Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-84e3007a2b7so519790b3a.0 for ; Tue, 04 Aug 2026 21:46:15 -0700 (PDT) Received: from spider.bream-herring.ts.net ([103.252.203.158]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe707e577bsm617891a12.9.2026.08.04.21.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 21:46:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785905174; x=1786509974; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pf+KaQef3aLdqIRGS+SN0ScWkjmFB+xo03zP2W7SUl4=; b=UwlqUyxkiwWEUbPlhU7mBvpwcUGFC3Ix7CSD44RFzIG2r5HAssgZHVACbxb3Y0qH6s qTbReqGpiCrKTOHm+aXomcZ1pgRHERXiIe3u9CGzCJ+Qc5rg+e8CupHirOfCVrO3j1kO mI+ieQIvboXDwkJdaQf/WlmnAKSP3xyaYDG07HEwVTRLxDBYq2/uDc/O3ZA7iuk12d+P TSABsu/hGvQ5kipKmp5j0/cp6H+aXQL/Lb4vAxgdm2HX+zkqqhvqFXZJI49b2i78p4/5 UmzDni4hTsAuK8W34PMORTms7+lqYiLKzT81hKMUpWhyWbIUcL0+uIg5qC/izidDl3U6 Ut9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785905174; x=1786509974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=pf+KaQef3aLdqIRGS+SN0ScWkjmFB+xo03zP2W7SUl4=; b=gJLeh5laBebO9TVi2LXAdx23ulY0ZeuyhcNL/CdmRp1Q19Qi6aNRf+TwBOS5UaVIkj Uki24OY9xlUPMX32DNLWWU1FC0z+ZKd5KXtdOgP7G9egaFoEx63N3d2wJeAMR2hLkJMy UwpK3QbXl5xKYhv4BdvN7pIwMR6MPJTBWLepoiJ4KiGKdsR4iyIKnWcywstg6C/IxkCE cZjro3Y9hfELv/Mmc4ugPzlE3Lj4x1VwPieLxiOledrQmlkmo8QbgGnVf3yc5YVqNrtT hYZysBZOmDofnVvtMgh0Qp8BF2W33iqMyUO1sg5Ex9AselcyR2edy5KmvwCvAKqutjfF Fc+g== X-Forwarded-Encrypted: i=1; AHgh+RrouvLHK44syrD8y2FN2eQ3pc4qfH3G3xWjrVkCWgnev4tz9ay4MtQZso276O4dOqnCwuDdwwZAj7s=@lists.xenproject.org X-Gm-Message-State: AOJu0YwNwgOyqOSV4lCq1sAPbsDDKf1+n1d6zidLscJSLp5FB3cjiBtq BqloZ3gHUZWwBZ70m/MaSK4HlMpTsrBjZuIGRNHnF5u/+gIkqV+d5fFN X-Gm-Gg: AR+sD10QgB+vRNvQGxsVX6jCnH6RmnQSGD4pMMvR/2dCNVDl5LWvsmtzw7D/lo94Fsg Y3vtkCdLOvfyfumSrV4lFfUSsEZQqEwiXJrEFfyPxqlByHgPiHifVOZWIeNgAWe0rB27lGpFm0K DeP+VmU2BBrrTJ17HRPoW8Hrn30bjsRw24PRmFh4Uqf2ryu5Pln2nC5G82CyaB88lAUthBRU16q 07xMBzATqYBac/k2RPpUqx7XTY109oXNylZrgzkQqpYYji79qwwCWEn4Byujat9jgK83PJZu5RR ilaqxhBqo+mLUL+nNVTN98WYZWMzm6phdsAy4RcdQtNhIEtY+W18OVr0q/0BzuZi5JkDUKeE+zO PhIv6Nc/8xjRxtKRnI+SXoWKb6lrWDF6VPJ4r6pb4cM9kSCQUGyShmYGTjznrLdEfxmgoXZedkX wRpGva/pzh0dNPZujtnM18nqQM8Uao3qZLRp6juJN4O+GkDXx9mOs1KBgDbWs72L7bbxI/hx5eN CFg7neFr7aecAcehJKoTNKFB2XQa48Whji9KFf/RSnf8k/frcY7O/V0b9J9iTj52Y/6YBriEiu3 bkO4bXzC4Z7Jeslir7LgDMZRGBOJvh7vqRFDVRkWJaQ0CUNmSLZB X-Received: by 2002:a05:6a00:2d8b:b0:848:3e74:85eb with SMTP id d2e1a72fcca58-84f2e014749mr4032775b3a.1.1785905173552; Tue, 04 Aug 2026 21:46:13 -0700 (PDT) From: Matthias Goergens To: Roger Pau Monne Cc: Matthias Goergens , Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Yannick Martin , Thorsten Leemhuis , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH] x86/xen: fix init of balloon stats for PV guests with memory != maxmem Date: Wed, 5 Aug 2026 12:46:07 +0800 Message-ID: <20260805044607.2564210-1-matthias.goergens@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730143548.39320-1-roger@xenproject.org> References: <20260730143548.39320-1-roger@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1785905175-006CEA5B-EF30FEE9/0/0 X-purgate-type: clean X-purgate-size: 2111 Hi Roger, thanks for picking this up, and Juergen, thanks for the quick review. Two things I believe are still worth addressing; the Fixes: tag can of course also be fixed up on application. I think the Fixes: tag should point to 0949c646d646 ("Partial revert \"x86/xen: fix balloon target initialization for PVH dom0\""). Commit 87af633689ce changed the initial-page calculation and the extra-region subtraction together, so those two operations were coherent: the PV initial count then came from get_num_physpages(), which includes the extra regions. 0949c646d646 restored the PV start_info->nr_pages calculation, which excludes the extra regions, but retained the subtraction. Its 6.12.y backport is also the reporter's identified regression, first seen in 6.12.75. Applying this patch in a tree that has 87af633689ce but not 0949c646d646 (for example a 6.17-based distro tree) would double-account the extra region. This likely also wants Cc: stable@vger.kernel.org, since both 6.12.y and 6.18.y carry the 0949c646d646 regression. Separately, and not something this patch introduces: PVH dom0 has the same shape of problem on mainline since b13cd24c15d7. A successful XENMEM_current_reservation supplies current_pages for both PV and PVH dom0, and that count excludes the unpopulated xen_extra_mem, so the xen_pv_domain()-only branch leaves PVH dom0 subtracting those pages again (-ERANGE, or a silently wrong target, when CONFIG_XEN_UNPOPULATED_ALLOC=n leaves the regions for the balloon driver). I am happy to pursue that as its own thread once this one lands. Would it be safer to pass balloon_add_regions() an explicit indication of whether the chosen initial-page count includes the extra physmap regions? That would cover PV, PVH dom0, and the XENMEM_current_reservation fallback without deriving the accounting rule solely from the domain type. On hypercall failure PVH dom0 falls back to get_num_physpages(), which includes the extra regions, so keying the accounting on the source of the count keeps the fallback correct as well. Thanks, Matthias From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:06:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 07:06:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382805.1626159 (Exim 4.92) (envelope-from ) id 1wrVhl-00053m-Jy; Wed, 05 Aug 2026 07:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382805.1626159; Wed, 05 Aug 2026 07:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVhl-000528-DN; Wed, 05 Aug 2026 07:06:21 +0000 Received: by outflank-mailman (input) for mailman id 1382805; Wed, 05 Aug 2026 05:27:36 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrUAB-0005Uw-Tc for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 05:27:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrUAA-008Ny1-CD for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 07:27:34 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72c9c0-5cb7-0a2a0a5109dd-0a2a4503deda-14 for ; Wed, 05 Aug 2026 07:27:33 +0200 Received: from [52.101.56.16] (helo=BN1PR04CU002.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72c9c4-fae8-0a2a45030019-346538106acf-3 for ; Wed, 05 Aug 2026 07:27:33 +0200 Received: from MW4PR03CA0089.namprd03.prod.outlook.com (2603:10b6:303:b6::34) by PH7PR12MB6635.namprd12.prod.outlook.com (2603:10b6:510:210::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Wed, 5 Aug 2026 05:27:28 +0000 Received: from MWH0EPF000A672F.namprd04.prod.outlook.com (2603:10b6:303:b6:cafe::5f) by MW4PR03CA0089.outlook.office365.com (2603:10b6:303:b6::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.16 via Frontend Transport; Wed, 5 Aug 2026 05:27:28 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000A672F.mail.protection.outlook.com (10.167.249.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Wed, 5 Aug 2026 05:27:27 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 00:27:26 -0500 Received: from xirengwts12.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 5 Aug 2026 00:27:25 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vUIhDr0P2zEH7KJpJf3ZDHyc2k84JFqZ6awhZo/Er3VKiNWN1IGJMqTOwyklesbA8bbIKxY5ADhgr9qG3VadNK3ud0DR+o5AqRVt9qxNjbY6a+rEViEgQAhFWHFu2WQVFAoxMvw6uA6KPfXwh7CmdkWPeyb+mliseOaJ5rLmdH70347nNHQ74INjWQpYNuaYZP1vDDnK5rxaWr7gFnyUWH2BPWDiJvshSZ+bmKIDQQcvfsVD0h2W6Xud6IZbiu5cN0vuESC4vQwIm353myIsfapYX5m7XiWvFEy0E3nDJrDlK/gUn2Z10Ib47YN5FlGkeeI3Rz97B22dZ/Zs0PIHhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E/X3j+vLBycBqra0d59r8vxbnNUi3Klkubhz67O4PTY=; b=XyEWQaRVR1u68A3e5OviNXFkEtg402ACHSm64CVNrAnI07E01ncctTrzQto/6XL1YnysXR2rWs+XeOxf9qqWVEErC8hmxasJ+lw1j6JCezNz/vlmt/QC/xGbaRbca94nvBrnMX1aNPUrL3Q7NFt6ew9dDSx65JHQY9vl7C8WorR3aoVTmA3X6hcbDL/FlK8k4TlWv6AeXub8EjZCbly85XJTMgzYDl9CEYjMxhBn9vnPPgmmy+8ruvEiw6vfOlExl7uV17xYnlN0FvULI82BaxtTxJuu/3J4lU5EYqHthBahthrmUQ5lMLUGmU7mkWvNxXrXMTH52xJIk6GQlb6Ctw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E/X3j+vLBycBqra0d59r8vxbnNUi3Klkubhz67O4PTY=; b=je5PJT27QMl0w0JKoAr8eAL8tjMi3WUAe3uWVX3fDK7RqD4GADAXyURUZAfWbesCZRsQJUnbczsKBlJjevkDuwgG3VFjV6yQxTJ31732joPkMtgw34xGyCt0wusLraEmU7GGPQMk+Fx40swkxWByS6GfFk4cvy3naWl4zsDj5K0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Neal Frager To: CC: , , , , , , , , , , Neal Frager Subject: [PATCH v1 1/1] include/hw/xen/xen_native.h: downgrade include-order assertion to warning Date: Wed, 5 Aug 2026 06:27:22 +0100 Message-ID: <20260805052723.2823538-1-neal.frager@amd.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A672F:EE_|PH7PR12MB6635:EE_ X-MS-Office365-Filtering-Correlation-Id: 94bc0f2d-cca2-446a-818b-08def2b23d1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700016|23010399003|18002099003|11063799006|13003099007|6133799003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: /Z3P7akN7im+GzxTWp5kAYnL6QyZsZVIz+otKjWhGN4R2w16LIhEReH5uNR9ylFsaJk0eFYoUByBaCShjyv0N9KzbJdjKC6AR2dLUPoocgBLJv7ULlc9e4NBpZ9jqxcZDJH0H9MUP0las13iP0fPvri+lf70uFfvvkESeLTN0JAVMCQmG5R5HoN45tOe2PChyULr2dQ0224CkDWrGqDVt/FSM5g/xjSQw5stAZqb64Z2MxS6KEbqmk2ErtHUYNbUwhxqoHduYxd6fMIhxRmOkqUuKusp2tkkUihpTc5zOGu8219LGathe24rifqnM/MDaUGtFH12VplOmJDvuoApTGQl6esVRP6ecuoJue18CSlWLrsT/YFrM7LgzntQPYCeu9dJo9B3WM6FJKFWXHDeWWVAf/nEOJzSQX2scX7MnrLSsxge4Q2PS5KX2CU6q5l/WytV8OhTTvb13UhzjHHoYfuScmZJQu6SupNHsZAOVdlYgy8wl0Ctdit69pGHD/G7i39c833OGt5IKEkaqyjMKrZL7eBF6mL6d8ePdntEbAExgaKVx+zdkX1i6VWyCo2VSKbOzZBfbse1f2SFPVArYnbw1Ju/yr+vTQhHSTallgldsZB4LNfseGGnlmA2JBE1Ep8RRBrwoACRx2eMpJontEpPkEkeZNOhZiCbFhiVbfDzgYiSWUayxwFrIlaRTEcLGnv8o5U4xgh/oP2GcEXyxw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700016)(23010399003)(18002099003)(11063799006)(13003099007)(6133799003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1K/A2tkKp6+CpEoquoBIHfxeiKXkfVqGeCjGN/vbUqV5HAKBcHh3k2Y7FPCZZ3yHyOwpCKuoaEoI7IH3HzJb9op9h9gllhpnznz9x6hz6nb1OOJ0anUmCqKrR/cCcJc9GG2hpW8PsrLaRMBiWbXUnUwvzOE0/pqjhcg0nPurWcfr4efk39Doo8d/N3rxV0krmeqEpEzABSXGf6sF26+rS5gtME3mKjJXA+aiUnXQ41aGPj6EUNOE1qhRrLdGpGw6T7qO621E6vA9ZdFsvqcfgV93OjaaXL4QTRPjTsIDqTHYBmtaB894WongnuDCThZo3W9oN59ayNV/FiPZDX28zR6x/CghuvgJv3nSVzY42Cv1XDCfPOKMNxrmB2D0gpg+4OgIFfEiHjZ9uWMHrMJAUe56FGlFxiN9H33K0ufe+I6gTdzo0BVLzOestAF0cJQA X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 05:27:27.5347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94bc0f2d-cca2-446a-818b-08def2b23d1e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6635 X-purgate-ID: tlsNG-33051d/1785907653-76EF74E9-4D521809/0/0 X-purgate-type: clean X-purgate-size: 962 The -I$(XEN_ROOT)/tools/include added to QEMU's extra-cflags causes __XEN_INTERFACE_VERSION__ to be defined before xen_native.h is included, triggering an include-order assertion. Downgrade to a warning since the version is consistent in cross-compile. Ref: https://github.com/qemu/qemu/commit/e2abfe5ec6 Signed-off-by: Neal Frager Signed-off-by: Vincent Stehlé --- include/hw/xen/xen_native.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h index 5caf91a616..3e1137efc1 100644 --- a/include/hw/xen/xen_native.h +++ b/include/hw/xen/xen_native.h @@ -2,7 +2,7 @@ #define QEMU_HW_XEN_NATIVE_H #ifdef __XEN_INTERFACE_VERSION__ -#error In Xen native files, include xen_native.h before other Xen headers +#warning In Xen native files, include xen_native.h before other Xen headers #endif /* -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:13:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 07:13:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382894.1626171 (Exim 4.92) (envelope-from ) id 1wrVol-0007dV-Eg; Wed, 05 Aug 2026 07:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382894.1626171; Wed, 05 Aug 2026 07:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVol-0007dO-Bu; Wed, 05 Aug 2026 07:13:35 +0000 Received: by outflank-mailman (input) for mailman id 1382894; Wed, 05 Aug 2026 07:13:34 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVok-0007dH-Gj for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 07:13:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrVoj-00H5sf-Hg for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:13:33 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72e299-2eae-0a2a0a5409dd-0a2a4507bd98-8 for ; Wed, 05 Aug 2026 09:13:33 +0200 Received: from [209.85.208.45] (helo=mail-ed1-f45.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72e29d-b4ea-0a2a45070019-d155d02db8e6-3 for ; Wed, 05 Aug 2026 09:13:33 +0200 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-698ae09e356so788350a12.2 for ; Wed, 05 Aug 2026 00:13:33 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a145c49044sm1419460a12.9.2026.08.05.00.13.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 00:13:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785914013; x=1786518813; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=drHrC+qdqsi+PR/0lRsf/Ub+SUFkFlPx++QVFcFYlko=; b=DghiHlLh9toRgS1ioirUzAyrduOKQSQGfgEEjTdrPeuAXjqjvn/DmUKeadBWJGb+Yg yFbruMHZszkAHz1qAoVnrhVULJkUqT1UxqE7IfnQhS0Y4S85ddNYBdZyp1Ev1OW2c9td BFHQIXl0bemaS9UKxCw3DqzcPRQi4ru0jNMQOUf5u6R9/FCHu5Twkr1sEqja6eCzIECM Nt7yf1Ee3rs0mS1dpi3BznYsUwWnW7wPqTz6EJYcAxwoXe9g9D090hi3lPGVhJQLgTiU H4UN9xmHChpwOmHm0QFpYD4WkZb+0f176PI5Zm2xlwW/bRLlRf2ZFsPl8DPRRZ7LCOB3 TS8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785914013; x=1786518813; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=drHrC+qdqsi+PR/0lRsf/Ub+SUFkFlPx++QVFcFYlko=; b=JESnQ44ZLGgwZ41/t9bzuNzUkFmD71eNY08gx+KxFS7BKrTGRW7e/imWGY/PDrU7Zx o2A2fvdfn4tbj1EtEzYjyEOYfvH0X0CG/Kli5ReTa0JK2wCd9prG5jIa9OZpzU6NeDQq Wl4YSeWiqQPOzAtteEqfcPg6ilZfMyMQNfX2j3nPbUS4ACJ61GV43UGox/Q+YFKgSwI2 UOovGaULyKvogQwnwYqQQBAfEXNiW18D/sVnyKBKHym7Oi23A2P6i9ONSxKc3wTK5/L7 2U6IyGn4lUs5emO0Qrf6F+Ht+MWpAyqh3KAN+1tkMa2P5imGAFP5+ocnaH8+2XWQNI0Z x1Qw== X-Forwarded-Encrypted: i=1; AHgh+RrWferFIRVN2GSNXxwNXY/xuZS6bM67NrwfNySOfbOCOZrxkiiwm3CRIR/BQhUXkTAbo189euteaVI=@lists.xenproject.org X-Gm-Message-State: AOJu0YyrSuh2m+CnQTF8D5yFvVM/I0/jmB+0bMst8uRTDMDod9QdV7UI eycQDcJwCWb9bjNr+A6/kt1IFR3j1XxhhZCCibG3L/o9VlGWFfTXd+hvAt3nq94rM3g= X-Gm-Gg: AR+sD12gJXUGVK8rgIuLonF0a1cFjEGga3TVUQUX9kUtFtkq715cdRFgjYscZ0DS3+w aCPmJHK0xrDmPmy10T/UG1xbGs1Q/6IuZwgDkU6j18FrAI8exjgorMtPsymNaame8OsB+B1f4b+ rAWlGAu6BWB4wtndZAvL+a9E8zJ2oEX6ry37W8sh5bEG6s9H9H2tFv6Lp4AWg/Y565C+7RrOLfs mYXr14fW/qo+Swytb8BMqnV7kZbDrrjNKJ61Kiqsv3Dke3pTL0cE0+FFV7iJr3L0F80z/rdfVpa wjZhcSkMptNW3oYTb4V3xkGIzII273UIQ1Qa2Ot7SI9eVB8I9c0cvwyFo5aWIcV1ylokjD5RNGj nYMzhcKMH4MK7fFeZbpIB91gb67VqK8JnBPLZVWgP3Hz8eqUfboberGxUQTjmmXnXLG+z8Nyjrm lPy0RTx/g1CzflExrJ+dZfhU4o8lBQ/TF/ntD+dI0Greh7KGpL5VQaOXn4GJcDjSCOTSXXREfTW EzJz/nrob64A0PujWai31jBJNCIffg8ZR9B9tCPRo7GXKlkdgsnqXuwSEtk01faJfD7AlvNaDt3 7eNigp4kThbi+ZGCcpTUPfJUVg== X-Received: by 2002:a05:6402:1586:b0:6a0:a4be:6ed0 with SMTP id 4fb4d7f45d1cf-6a14f14c601mr2107256a12.17.1785914012808; Wed, 05 Aug 2026 00:13:32 -0700 (PDT) Message-ID: <931b763d-2ee6-4fbf-9222-c5b75f35ec47@suse.com> Date: Wed, 5 Aug 2026 09:13:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] 9p/xen: fix refcount leak in p9_xen_response() on wrong tag To: Stefano Stabellini , Yifei Gao Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , v9fs@lists.linux.dev, Christian Schoenebeck , Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260804213550.3409638-1-gyf161023@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8si6pc96wSFhwkSY5O2H0kme" X-purgate-ID: tlsNG-ef75cf/1785914013-35EC6AE4-85C07DC9/0/0 X-purgate-type: clean X-purgate-size: 7753 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8si6pc96wSFhwkSY5O2H0kme Content-Type: multipart/mixed; boundary="------------VvTq5HqiTdsegQZQBXC4lBJZ"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Stefano Stabellini , Yifei Gao Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , v9fs@lists.linux.dev, Christian Schoenebeck , Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: <931b763d-2ee6-4fbf-9222-c5b75f35ec47@suse.com> Subject: Re: [PATCH] 9p/xen: fix refcount leak in p9_xen_response() on wrong tag References: <20260804213550.3409638-1-gyf161023@gmail.com> In-Reply-To: --------------VvTq5HqiTdsegQZQBXC4lBJZ Content-Type: multipart/mixed; boundary="------------292XJsm8x0UioVDewQdpX8cO" --------------292XJsm8x0UioVDewQdpX8cO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMDI6MDYsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gVHVl LCA0IEF1ZyAyMDI2LCBZaWZlaSBHYW8gd3JvdGU6DQo+PiBwOV94ZW5fcmVzcG9uc2UoKSBs b29rcyB1cCB0aGUgcmVxdWVzdCBmb3IgYW4gaW5jb21pbmcgcmVwbHkgd2l0aA0KPj4gcDlf dGFnX2xvb2t1cCgpLCB3aGljaCB0YWtlcyBhIHJlZmVyZW5jZSBvbiB0aGUgcmV0dXJuZWQg cDlfcmVxX3QuIFdoZW4NCj4+IHRoZSB0YWcgZG9lcyBub3QgcmVzb2x2ZSB0byBhIHJlcXVl c3QgaW4gUkVRX1NUQVRVU19TRU5ULCB0aGUgZnVuY3Rpb24NCj4+IHdhcm5zIGFuZCBjb250 aW51ZXMgdGhlIGxvb3Agd2l0aG91dCBkcm9wcGluZyB0aGF0IHJlZmVyZW5jZSwgcGVybWFu ZW50bHkNCj4+IGxlYWtpbmcgdGhlIHA5X3JlcV90IGFuZCBpdHMgbXNpemUgYnVmZmVycy4g VGhlIHJlcGx5IGhlYWRlciwgaW5jbHVkaW5nDQo+PiB0aGUgdGFnLCBpcyBzdXBwbGllZCBi eSB0aGUgYmFja2VuZCwgc28gYSBtYWxpY2lvdXMgb3IgYnVnZ3kgOVAgYmFja2VuZA0KPj4g Y2FuIGxlYWsga2VybmVsIG1lbW9yeSBvbiBldmVyeSBjcmFmdGVkIHJlc3BvbnNlLg0KPiAN Cj4gTW9zdCBiYWNrZW5kIGFyZSB0cnVzdGVkLCBpbmNsdWRpbmcgdGhpcy4gU28gSSB3b3Vs ZCBhdm9pZCAibWFsaWNpb3VzIi4NCg0KTm8sIEkgdGhpbmsgdGhpcyBpcyBmaW5lLg0KDQpF c3BlY2lhbGx5IHdpdGggZHJpdmVyIGRvbWFpbnMgbWFsaWNpb3VzIGJhY2tlbmRzIGFyZSBh IHRoaW5nLiBUaGV5IHNob3VsZA0Kb25seSBiZSBjYXBhYmxlIHRvIGRlbGl2ZXIgd3Jvbmcg b3Igbm8gZGF0YSB0byB0aGUgZnJvbnRlbmQsIGJ1dCBpZGVhbGx5DQp0aGUgZnJvbnRlbmQg c2hvdWxkIG5vdCB0cnVzdCB0aGUgYmFja2VuZC4NCg0KQW55IHdvcmsgdG93YXJkcyB0aGF0 IGdvYWwgaXMgdG8gYmUgc3VwcG9ydGVkIElNSE8sIGFuZCB0aGVyZSBhcmUgYWxyZWFkeQ0K ZnJvbnRlbmRzIGxpc3RlZCBpbiBYZW4ncyBzdXBwb3J0IHN0YXRlbWVudCBmb2xsb3dpbmcg dGhpcyBydWxlLCBzbyBhbnkNCnZpb2xhdGlvbiBvZiB0aGF0IHByaW5jaXBsZSBpbiB0aG9z ZSBmcm9udGVuZHMgd2lsbCBiZSByZWdhcmRlZCB0byBiZSBhDQpzZWN1cml0eSBpc3N1ZSB3 b3J0aCBhbiBYU0EuDQoNCg0KSnVlcmdlbg0K --------------292XJsm8x0UioVDewQdpX8cO Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------292XJsm8x0UioVDewQdpX8cO-- --------------VvTq5HqiTdsegQZQBXC4lBJZ-- --------------8si6pc96wSFhwkSY5O2H0kme Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpy4pwFAwAAAAAACgkQsN6d1ii/Ey+H KggAg6nytSOOYq8z0ItP8CPzGV2WeFi552GEXsho0t5VEJrJrI24Ujyyy954xFTbzaXtOHsU8fTJ +URN3WaLFrA8LEz0IzTnDjNdR4sXwJT0QVuBlCzSo/XOKzQXR1xnZVk6rfS2rTy6v0caigYk2MlX yYU3nUCUsR3IQJYAIY7E6PEM9MGAr9Xk6Vhv8iJHk2twCq5cXqfwSTQowOtgCI9T0HQufnz1wy7Q cbxZfpclY4ahGtES2b/+saK8J54DPMFr2cwKJ5svBREmlL6o9YO7LWASnFdo9d7MEcP+mWXRq0hl ZXBWLiXuEZW643jzUprYwwrrojFXqrubr9OIRM+3wA== =DfBT -----END PGP SIGNATURE----- --------------8si6pc96wSFhwkSY5O2H0kme-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:18:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 07:18:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382904.1626180 (Exim 4.92) (envelope-from ) id 1wrVtX-0008Qe-WE; Wed, 05 Aug 2026 07:18:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382904.1626180; Wed, 05 Aug 2026 07:18:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVtX-0008QX-Su; Wed, 05 Aug 2026 07:18:31 +0000 Received: by outflank-mailman (input) for mailman id 1382904; Wed, 05 Aug 2026 07:18:30 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrVtW-0008QR-Nn for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 07:18:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrVtV-002tHM-Ls for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:18:29 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72e3bb-5cb7-0a2a0a5109dd-0a2a4509d8b2-24 for ; Wed, 05 Aug 2026 09:18:29 +0200 Received: from [209.85.218.51] (helo=mail-ej1-f51.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72e3c5-be1a-0a2a45090019-d155da33e9ad-3 for ; Wed, 05 Aug 2026 09:18:29 +0200 Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-c1670dad7a8so103074166b.3 for ; Wed, 05 Aug 2026 00:18:29 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2036276e58sm83701266b.28.2026.08.05.00.18.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 00:18:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785914309; x=1786519109; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=esFyuAFubsfqFMhJEZXWNUGl8u3Au7VYmA42/rCClR8=; b=LAnQ3dNRtmsPr7y9exiEhdmXeDktO4PfTS1cAyTXS2iRN83vXxvc+dS0HiBeosItPp ztTnD0GhiSAVrZTwENN2vR0uDFMJ0V8Mt0TEkZti+BeU4HmFiwB+z1UKbBDxGdb04WpS p8CRTyGo4w8JyYHaQ0cH79b3GDfhPJuVFGlZpjfmbNy7/m5HH/x7Mr+Crl0jGA3MZsL9 wj9aEVvpwXMCpjpRMq9gMTNNobqh9Or+GdYzhScChR8J6vaqfdwFNpE6+4BP+mCaoJrD 5/5YtvnxTIripaY5qNwpORQp58u7H3jE5ookrmuEe9h2XUWbjnivM46oO5bAzLma3rED YPtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785914309; x=1786519109; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=esFyuAFubsfqFMhJEZXWNUGl8u3Au7VYmA42/rCClR8=; b=Kn1IJnZtSPJk2ceJcADVrxewEUHfYU7GpRIGUndtgWFCqjafIgaubwkaWcL6z7KUm6 gQRmU+f8n5UYroAafoEyYq2cp4MXjk78rUArxyGbAKUN3bfFvwZKLvSQEF3qeEQzCNSH xO4qNDkQjLp4my2STmgMsyavnUE25+V689fejWD4jN+YfDTt1B8jbmJvFoGNyFECCHAJ J0UuzqHbUP+d+14BOiJ1BrvP9CgwxR0sULUSPPTn/CO/ZZRysj1DtX+uD0m4T4qXqiQ/ 3TR6K/wOFKYne7j8OwUHZthzPk2LoA9GlF0b06d+V9I8WICzvau9kUJJkZIM6CtPCEbU +k8w== X-Forwarded-Encrypted: i=1; AHgh+RpUvL8wNfL58mlCsBEhRFrBK38AhWzguYPbQsA12kWk/Iwf+0foXq01CkN6PlPotS4bqBgRXfvWW6A=@lists.xenproject.org X-Gm-Message-State: AOJu0YxEKhSx8wKojE7CXAtmuaOLriBNA0wwBWiMx6bZ/2Hvg/bFFXor oF8YdsX8SLhAFuKIpyai5Anfa+ktK93aWdqJXGAzOtHgnxcxWqmVOP91o8dzYPkeqD0= X-Gm-Gg: AR+sD116znp8lTbs3C4XBqXIZym+u8CVqyi6bFF1rVFFbrTpvX/AlWLRXBfAf6MBOiG BUM+P0xK27myszfi3caYutChGzwq900fjxGTxrGmj/t/6/Tvz1mk10aixMefdmVmFUXsicbkmRJ ne+Ey7m7LlJ0RkRx2fvcPzNIMA1W1wVkKC7RXy63pmcSdlcKh9/cwFeDTEKGWHQ2ir8DBW3GEN/ 1fd03VrG6pDJPp9ObTO8rVXAwBkqDKDRUs70L6VQRUffTSeO/D1CERd7Z3X0chj/K3I8QSkJHBG F6CaGyw6akRTGkUxxXq68r6wQnalEW3J9/rQpWAkcpfWLxJsQmURyMZ2kguTx8GlDFqwUp2eH3f RYI64ZXRSoSablD4Z36S3FYUEf1iseMAcrMrpZ4DAWVBwUG16MC2wNZzvc5zQqKjLPBGuAMD9sX Vspz7RfijU+J6Y42x7JPVfQw4tEZARvAeJz4S49f1ro2tWyxI4aXWBpXXE0FYOXuP5T8TZfQnvN ePR04UF3JZtnsdff/f6TN8Tb0a0o6GDcILHMaa9Zgx4ZKKgvkWE64aiXENJQBgBtXagFWfvCxM9 rPfbAM1K3uRbLrB++1LF7cGRTA== X-Received: by 2002:a17:906:eec4:b0:c1c:2ee9:5e6d with SMTP id a640c23a62f3a-c2039c39717mr221970566b.17.1785914308967; Wed, 05 Aug 2026 00:18:28 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 09:18:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: build failure after merge of the xen-tip tree To: Mark Brown , Val Packett , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Xen Devel Cc: Linux Kernel Mailing List , Linux Next Mailing List References: Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------L7qBEoEZ6lPklBnqZkcGdVog" X-purgate-ID: tlsNG-bad1c0/1785914309-3A8D9034-236C979F/0/0 X-purgate-type: clean X-purgate-size: 6658 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------L7qBEoEZ6lPklBnqZkcGdVog Content-Type: multipart/mixed; boundary="------------ZcgnOy51QMT7gJN76OXrlRf3"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Mark Brown , Val Packett , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Xen Devel Cc: Linux Kernel Mailing List , Linux Next Mailing List Message-ID: Subject: Re: linux-next: build failure after merge of the xen-tip tree References: In-Reply-To: --------------ZcgnOy51QMT7gJN76OXrlRf3 Content-Type: multipart/mixed; boundary="------------qchc6mwxCU6mnmvcmLbmokzs" --------------qchc6mwxCU6mnmvcmLbmokzs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjYgMTg6MjgsIE1hcmsgQnJvd24gd3JvdGU6DQo+IEhpIGFsbCwNCj4gDQo+ IEFmdGVyIG1lcmdpbmcgdGhlIHhlbi10aXAgdHJlZSwgdG9kYXkncyBsaW51eC1uZXh0IGJ1 aWxkICh4ODZfNjQNCj4gYWxsbW9kY29uZmlnKSBmYWlsZWQgbGlrZSB0aGlzOg0KPiANCj4g RVJST1I6IG1vZHBvc3Q6ICJpbml0X21tIiBbZHJpdmVycy94ZW4veGVuLXByaXZjbWQua29d IHVuZGVmaW5lZCENCj4gDQo+IENhdXNlZCBieSBjb21taXQNCj4gDQo+ICAgIDY0ZDI2ZmIy YWQxZjIgKHhlbjogcHJpdmNtZDogZml4IGlvZXZlbnRmZCBjcmFzaCB1bmRlciBQViBkb21h aW4pDQo+IA0KPiBJIGhhdmUgdXNlZCB0aGUgdHJlZSBmcm9tIG5leHQtMjAyNjA4MDMgaW5z dGVhZC4NCg0KSSBoYXZlIGRyb3BwZWQgdGhlIG9mZmVuZGluZyBwYXRjaCBmcm9tIHRoZSB4 ZW4tdGlwIHRyZWUuDQoNCg0KSnVlcmdlbg0K --------------qchc6mwxCU6mnmvcmLbmokzs Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------qchc6mwxCU6mnmvcmLbmokzs-- --------------ZcgnOy51QMT7gJN76OXrlRf3-- --------------L7qBEoEZ6lPklBnqZkcGdVog Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpy48MFAwAAAAAACgkQsN6d1ii/Ey9R 7wf9EnPpdhTlTSVTBo1XfcO3WLaKMCfAgydfl0DD0cEZZj9aFaRzq+tF8ImI6z0Fv6wjjacd/uX/ 46sX/I8Pe7iLweHDhkW1F5/0TFutOTy8Mi2zQMQ0geK7F8gVHV8Hl/jBpZ2boYlqlMiU0nUzqOYb YKS9aoqJ3HtholZxj4BoOcigsqojd7912AZ+pEiiEF5OVTyk/QfyunOvXmk3qQ/KjqAdwezEKU3Y sy9iQABE8SZSwXcQQSn/0Vw4DjlzUk1KwpgMou/VhGKY0Q8Dd3OZdnswMMlggZtjrP6uxnzjaR+w 01iC1kheI/gztx4Hhf6wHFB4dS0888S66aR0QSjw2Q== =NrhC -----END PGP SIGNATURE----- --------------L7qBEoEZ6lPklBnqZkcGdVog-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 07:53:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 07:53:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382922.1626190 (Exim 4.92) (envelope-from ) id 1wrWR6-0005ai-Hg; Wed, 05 Aug 2026 07:53:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382922.1626190; Wed, 05 Aug 2026 07:53:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWR6-0005ab-DY; Wed, 05 Aug 2026 07:53:12 +0000 Received: by outflank-mailman (input) for mailman id 1382922; Wed, 05 Aug 2026 07:53:11 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWR5-0005aV-EF for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 07:53:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrWR4-00E4m8-HD for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:53:10 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72ebe5-bab6-0a2a0a5309dd-0a2a450c84a8-6 for ; Wed, 05 Aug 2026 09:53:10 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72ebe6-f479-0a2a450c0019-d1558031eda4-3 for ; Wed, 05 Aug 2026 09:53:10 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49553515a8bso9179445e9.1 for ; Wed, 05 Aug 2026 00:53:10 -0700 (PDT) Received: from andrew-laptop.. ([157.231.70.114]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a0f7b86sm160254105e9.10.2026.08.05.00.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 00:53:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785916390; x=1786521190; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1VYSxA8qmfZtawmM+q3vCQMEETV4GCOYeujyXp2mk/o=; b=qKnCDFfwitDtmsHf4P3URc2QzB2KPb+oV57PtaehctpY1MsxpgY6SKCyPRiFYqgZMY jsJHO/WHFC2wUnRX9XTHzDwS61jS2pvV5zPM3mkOKqbqRkpLkvehmSM9f5eCYlM99/Eq r7BabXbs2ZhnqLvIft+Bd8BWlpHi3gnjiI9r4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785916390; x=1786521190; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1VYSxA8qmfZtawmM+q3vCQMEETV4GCOYeujyXp2mk/o=; b=Txf7mRBgGzPN7V8aujsne9pgTEnLbu3yXgeCM6/Vy2WSDxQK5V7FVYEj3MWPAfifbp toqr4Ff87jmjAuPTu0Lt6+mE3yNRmWZPVEjAGzINJEbBgmLxMShsagipS3pzfWfy8b/z xTOPWDyqiVtpBbNpyhFztvVWSrBKJiSauKJ9N7eYHT5F9ZJjUEgUXq1vuS22UhtUBRSa hK37AXFaoy+BjeCTXAZvvfde5uSgvwD0e7S5cDOUBu8bHkwpzI/n9QwJ/EYkJ/RqlA8s SrF/UDyFlsLrVNSXeWkUo9l1jmh6p0dL5N1YOlX+IHu81NRx/5sVByQD+lYZ3xr6dCLl iSmQ== X-Gm-Message-State: AOJu0Yx5YTz3dPFZ4x3WAcZP6bn+7Dd25ie5Qm/5pJCjXTpm8uLpoxnU X7R5EelatuvKGGxrqF6xP90RSrU7S2SYbR7hVbNORDVckvzvcUvwaJKaaYn2y2wFD54+dLDkFS6 hiawKxz8= X-Gm-Gg: AR+sD11YCVhhoKIz+84m2sIXX4tX8gco1nxvvj/mbjE9G+9LCljTYTwhZwrkrpQ3Ixh 4PY4Y6J49adpOSOM8f8U80ToD3bqwUr/qa77e1qCbZHXjUGg0TeAdGnHhQmELbLNHp8YiwE1MyP wXrbLYlqDQcWYlmVnEA4xhqRxJVcDJtlvaXGPoLz+cczXoKKIJvniBNzE43gzdSY+t+TplQruOb PpKcS3glSVOu0vci1pxyyH3RHrIF3a01oug1/g54HrOntvUvbt3diW81cVl0Kn8otthVTVPANmB MKIJDZ+U9O3SNlhwAKFaA5Tpw2nFhrvW1kntbzKwRHygjJK8rGbENuClMLR7P9eiU8CXfx/hW31 pfGIwpddCBgFU3BTEukIF1bG0jRf0Seu2wfX3rPDfksT6gtyMt1sZIYAcC4mOhDPBSxse8ZO+88 quy2fzQ7LoC4wGV5vUiRGm/En0VlOMYMGPofumTxyOE3R06YQx8TjEbvCMz5LpZqA7u8MElAXQ X-Received: by 2002:a05:600c:3150:b0:496:ca1f:a428 with SMTP id 5b1f17b1804b1-4994e7f3562mr41132765e9.19.1785916389368; Wed, 05 Aug 2026 00:53:09 -0700 (PDT) From: Andrew Cooper To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 2/3] x86/alternatives: Rework get_ideal_nops() Date: Wed, 5 Aug 2026 08:53:03 +0100 Message-Id: <20260805075303.23105-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250522150015.555492-3-andrew.cooper3@citrix.com> References: <20250522150015.555492-3-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1785916390-01EC2A5B-6928294C/0/0 X-purgate-type: clean X-purgate-size: 3469 The {k8,p6}_nops[] arrays are both 80-byte structures indexing 45-byte structures. Furthermore, perhaps unusually for C, the source layout is an obvious hint about the triangular nature of the structure. Therefore, we can replace the pointer chase with some simple arithmetic. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné v2: * Add build assertion. --- xen/arch/x86/alternative.c | 48 ++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index f0644055d3d3..30c5ccaa8b16 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -20,7 +20,7 @@ #define MAX_PATCH_LEN (255-1) #ifdef K8_NOP1 -static const unsigned char k8nops[] init_or_livepatch_const = { +static const unsigned char k8_nops[] init_or_livepatch_const = { K8_NOP1, K8_NOP2, K8_NOP3, @@ -31,22 +31,10 @@ static const unsigned char k8nops[] init_or_livepatch_const = { K8_NOP8, K8_NOP9, }; -static const unsigned char * const k8_nops[ASM_NOP_MAX+1] init_or_livepatch_constrel = { - NULL, - k8nops, - k8nops + 1, - k8nops + 1 + 2, - k8nops + 1 + 2 + 3, - k8nops + 1 + 2 + 3 + 4, - k8nops + 1 + 2 + 3 + 4 + 5, - k8nops + 1 + 2 + 3 + 4 + 5 + 6, - k8nops + 1 + 2 + 3 + 4 + 5 + 6 + 7, - k8nops + 1 + 2 + 3 + 4 + 5 + 6 + 7 + 8, -}; #endif #ifdef P6_NOP1 -static const unsigned char p6nops[] init_or_livepatch_const = { +static const unsigned char p6_nops[] init_or_livepatch_const = { P6_NOP1, P6_NOP2, P6_NOP3, @@ -57,21 +45,9 @@ static const unsigned char p6nops[] init_or_livepatch_const = { P6_NOP8, P6_NOP9, }; -static const unsigned char * const p6_nops[ASM_NOP_MAX+1] init_or_livepatch_constrel = { - NULL, - p6nops, - p6nops + 1, - p6nops + 1 + 2, - p6nops + 1 + 2 + 3, - p6nops + 1 + 2 + 3 + 4, - p6nops + 1 + 2 + 3 + 4 + 5, - p6nops + 1 + 2 + 3 + 4 + 5 + 6, - p6nops + 1 + 2 + 3 + 4 + 5 + 6 + 7, - p6nops + 1 + 2 + 3 + 4 + 5 + 6 + 7 + 8, -}; #endif -static const unsigned char * const *ideal_nops init_or_livepatch_data = p6_nops; +static const unsigned char *ideal_nops init_or_livepatch_data = p6_nops; #ifdef HAVE_AS_NOPS_DIRECTIVE @@ -86,9 +62,19 @@ static bool init_or_livepatch_read_mostly toolchain_nops_are_ideal; # define toolchain_nops_are_ideal false #endif +#define TRIANGLE(x) (((x) * ((x) + 1)) / 2) + +/* + * Both k8_nops[] and p6_nops[] are flattened triangular data structures, + * making the offsets easy to calculate. + * + * To get the start of NOP $N, we want to calculate TRIANGLE($N - 1) + */ static const unsigned char *init_or_livepatch get_ideal_nops(unsigned int noplen) { - return ideal_nops[noplen]; + unsigned int offset = TRIANGLE(noplen - 1); + + return &ideal_nops[offset]; } static void __init arch_init_ideal_nops(void) @@ -601,3 +587,9 @@ void __init boot_apply_alt_calls(void) _alternative_instructions(ALT_CALLS); local_irq_enable(); } + +static void __init __maybe_unused build_assertions(void) +{ + BUILD_BUG_ON(ARRAY_SIZE(k8_nops) != TRIANGLE(ASM_NOP_MAX)); + BUILD_BUG_ON(ARRAY_SIZE(p6_nops) != TRIANGLE(ASM_NOP_MAX)); +} -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:21:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:21:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382948.1626199 (Exim 4.92) (envelope-from ) id 1wrWsq-0002Jz-AM; Wed, 05 Aug 2026 08:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382948.1626199; Wed, 05 Aug 2026 08:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWsq-0002Js-6A; Wed, 05 Aug 2026 08:21:52 +0000 Received: by outflank-mailman (input) for mailman id 1382948; Wed, 05 Aug 2026 08:21:50 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWso-0002Jm-TE for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:21:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrWsn-008ug1-L9 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:21:49 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f28e-e002-0a2a0a5209dd-0a2a4507cbc0-22 for ; Wed, 05 Aug 2026 10:21:49 +0200 Received: from [195.135.223.130] (helo=smtp-out1.suse.de) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f29d-b4ea-0a2a45070019-c387df8296f8-3 for ; Wed, 05 Aug 2026 10:21:49 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E3F857F5C0; Wed, 5 Aug 2026 08:21:40 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8EFEB779B6; Wed, 5 Aug 2026 08:21:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bGmkIZTycmp4cAAAD6G6ig (envelope-from ); Wed, 05 Aug 2026 08:21:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ZlUiHzlOl4D77WVfNuxjUhwnv12jrJ8nA6UzE76W4yk=; b=WsxYk3InzEJgbAlhQcGmvBYnUe2QV6mzoQ38UT2XAHuE4I7tDyVj4oQgfJSDfmZcbSGC9j UUVJ/UQH5X7YP7oQviFKvGS3ET+q9NRaG8ZerzpxH680VLNQWUfskFQRlzT4XtaPFFzhUU 5TLpqI+c/bHHwA/9ijuvwIm2vNfmqfU= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ZlUiHzlOl4D77WVfNuxjUhwnv12jrJ8nA6UzE76W4yk=; b=Vue1K1DGhfIcM6sZ6/HbN2d7OJcgitsjyHaAfuNYZKeSeiHlNrNPo5R0wg2rTYgbm4wwS+ MMh8k1ywscF/NfCV+iCdDJgGRdX0I+Vqt9mbSEY1QHdvRJdYaJnsnClszaBRU/A4I4fEsp 3C1qNfq6ssxQG9Moi+JvFJZSCPajJo8= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH 0/4] xen: cleanup config files Date: Wed, 5 Aug 2026 10:21:33 +0200 Message-ID: <20260805082137.1214967-1-jgross@suse.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.79 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.19)[-0.954]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[12]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:mid]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Spam-Score: -2.79 X-Spam-Level: X-purgate-ID: tlsNG-ef75cf/1785918109-A6CDFAE4-4DA1D8EB/0/0 X-purgate-type: clean X-purgate-size: 941 Do a cleanup of the Xen related Kconfig entries. Juergen Gross (4): x86/xen: Remove redundant config dependency on X86_LOCAL_APIC xen: Drop CONFIG_XEN_PVHVM xen: Drop CONFIG_XEN_AUTO_XLATE x86/xen: Drop CONFIG_XEN_PVHVM_SMP arch/x86/include/asm/idtentry.h | 2 +- arch/x86/kernel/cpu/hypervisor.c | 2 +- arch/x86/xen/Kconfig | 12 ++---------- arch/x86/xen/Makefile | 11 +++++------ arch/x86/xen/time.c | 2 -- arch/x86/xen/xen-ops.h | 4 ---- drivers/xen/Kconfig | 6 ------ drivers/xen/Makefile | 2 +- drivers/xen/events/events_base.c | 7 ------- drivers/xen/privcmd.c | 4 ++-- drivers/xen/xenbus/xenbus_probe.c | 2 +- include/xen/platform_pci.h | 6 +++--- include/xen/xen-ops.h | 22 ---------------------- 13 files changed, 16 insertions(+), 66 deletions(-) -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:21:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:21:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382949.1626208 (Exim 4.92) (envelope-from ) id 1wrWsv-0002XA-H9; Wed, 05 Aug 2026 08:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382949.1626208; Wed, 05 Aug 2026 08:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWsv-0002X1-D4; Wed, 05 Aug 2026 08:21:57 +0000 Received: by outflank-mailman (input) for mailman id 1382949; Wed, 05 Aug 2026 08:21:56 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWsu-0002Wa-Fi for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:21:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrWst-00BT1X-BI for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:21:55 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f296-bab6-0a2a0a5309dd-0a2a4508bcde-32 for ; Wed, 05 Aug 2026 10:21:55 +0200 Received: from [195.135.223.131] (helo=smtp-out2.suse.de) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f2a3-f659-0a2a45080019-c387df83d376-3 for ; Wed, 05 Aug 2026 10:21:55 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9A9A03EE8; Wed, 5 Aug 2026 08:21:46 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 441B5779C3; Wed, 5 Aug 2026 08:21:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iCFSD5rycmoKcQAAD6G6ig (envelope-from ); Wed, 05 Aug 2026 08:21:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918110; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OnKrqMmp33/ctRIhxID+//YqIMVJKj3PyOBSZaP2xuU=; b=U0We0YVgtE6Lxr5fhgkZV4EPZV4UcNMdx3VBu/3Izclwsm7Hnj9w7gorTh5rQe13AD+/69 xXh21lfM+lTYYlEGZH0XpHEhCoLJicV76a8THubZMQ0w7UsuNrynMImvBie915Rl1dzayG W50M4W4wCMy1AZoEUW1rFEympNqdWJ8= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918106; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OnKrqMmp33/ctRIhxID+//YqIMVJKj3PyOBSZaP2xuU=; b=d/1ekcpK9nnUZFXy4S14oeT+Xd9XtV0nWExr3VJY/OyzjkbB7z++Xy5zWJxldQAaNRQ6w9 8lPrfsBJqWdxX4WbBOBk8xqYbHC3PINbhZA+wZLnPIuG0NKpPyx9VrCIjTXAGg7NvTpBfP bknonSPBSw93SQAOzDJLLpO+jfnj3Dk= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH 1/4] x86/xen: Remove redundant config dependency on X86_LOCAL_APIC Date: Wed, 5 Aug 2026 10:21:34 +0200 Message-ID: <20260805082137.1214967-2-jgross@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805082137.1214967-1-jgross@suse.com> References: <20260805082137.1214967-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.79 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-6.79 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.19)[-0.957]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,suse.com:mid,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-purgate-ID: tlsNG-c1860d/1785918115-CDD4887B-6AB42BB5/0/0 X-purgate-type: clean X-purgate-size: 607 CONFIG_XEN depends on CONFIG_X86_LOCAL_APIC already, so the dependency of CONFIG_XEN_PVHVM on CONFIG_X86_LOCAL_APIC can be dropped. Signed-off-by: Juergen Gross --- arch/x86/xen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 99b06f5c47cd..bb420a4cb75f 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -52,7 +52,7 @@ config XEN_PV_DOM0 config XEN_PVHVM def_bool y - depends on XEN && X86_LOCAL_APIC + depends on XEN config XEN_PVHVM_SMP def_bool y -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:22:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:22:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382950.1626216 (Exim 4.92) (envelope-from ) id 1wrWt1-0002nQ-NL; Wed, 05 Aug 2026 08:22:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382950.1626216; Wed, 05 Aug 2026 08:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWt1-0002nJ-K6; Wed, 05 Aug 2026 08:22:03 +0000 Received: by outflank-mailman (input) for mailman id 1382950; Wed, 05 Aug 2026 08:22:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWsz-0002mC-Sk for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:22:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrWsz-00BT6F-9N for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:22:01 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f2a8-bab6-0a2a0a5309dd-0a2a4507c5d6-4 for ; Wed, 05 Aug 2026 10:22:01 +0200 Received: from [195.135.223.131] (helo=smtp-out2.suse.de) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f2a8-b4ea-0a2a45070019-c387df83dff2-3 for ; Wed, 05 Aug 2026 10:22:00 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 47C4C3F15; Wed, 5 Aug 2026 08:21:52 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EC717779B6; Wed, 5 Aug 2026 08:21:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vQ1QOJ/ycmoPcQAAD6G6ig (envelope-from ); Wed, 05 Aug 2026 08:21:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QTV4RA7a/5E53gmfFy4/nD7fff7Xl7GxWpiD9bWHF94=; b=Icw1np+Iuhkh3s+vA0MCKTbiRgi95UQZZMNkcXwb1/IcajlD9mm0uNFnpDGWuNBJXGFFkL awCxHi8KyyJ2XsACjgHcqjED1D7WAzdZMrROIc2MSOFnpWjRHS2rdnYoMRGJ/392d+4Prk r3ZXc5Jl5rjd9iP0PLnUf/sbfjjXmSE= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QTV4RA7a/5E53gmfFy4/nD7fff7Xl7GxWpiD9bWHF94=; b=uagAu9Tw6T6dPEjLyaJcTFNAs5xlAvIeSFOvl1jQwWRVjHj//uFbTJBNd8O9U/pZ8Grgat bKfoZSJ8Yo4lMT9NYfMpXjJy9fQmfT2ElgeW41BcReoxF0WdDpAujPkQTibTaONqQmejct IIEgjgt6AGcsH3KQnnmLwyOqbMYmUeQ= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: [PATCH 2/4] xen: Drop CONFIG_XEN_PVHVM Date: Wed, 5 Aug 2026 10:21:35 +0200 Message-ID: <20260805082137.1214967-3-jgross@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805082137.1214967-1-jgross@suse.com> References: <20260805082137.1214967-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.79 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-6.79 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.19)[-0.958]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLfdszjqhz8kzzb9uwpzdm8png)]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:email,suse.com:mid]; RCVD_TLS_ALL(0.00)[] X-purgate-ID: tlsNG-ef75cf/1785918120-A7AD0AE4-5CAD2280/0/0 X-purgate-type: clean X-purgate-size: 7220 On x86 CONFIG_XEN_PVHVM is now a synonym of CONFIG_XEN. In Xen specific x86 code it can be just dropped, in non-Xen specific x86 code it can be replaced with CONFIG_XEN. In architecture independent code it is used only where CONFIG_XEN is defined, so it can be replaced with CONFIG_X86 there. Signed-off-by: Juergen Gross --- arch/x86/include/asm/idtentry.h | 2 +- arch/x86/kernel/cpu/hypervisor.c | 2 +- arch/x86/xen/Kconfig | 10 +++------- arch/x86/xen/Makefile | 9 ++++----- arch/x86/xen/time.c | 2 -- arch/x86/xen/xen-ops.h | 4 ---- drivers/xen/Kconfig | 2 +- drivers/xen/events/events_base.c | 7 ------- drivers/xen/xenbus/xenbus_probe.c | 2 +- include/xen/platform_pci.h | 6 +++--- 10 files changed, 14 insertions(+), 32 deletions(-) diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h index 20f548702404..f400cfac69a6 100644 --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -745,7 +745,7 @@ DECLARE_IDTENTRY_SYSVEC(HYPERV_STIMER0_VECTOR, sysvec_hyperv_stimer0); DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); #endif -#ifdef CONFIG_XEN_PVHVM +#ifdef CONFIG_XEN DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, sysvec_xen_hvm_callback); #endif diff --git a/arch/x86/kernel/cpu/hypervisor.c b/arch/x86/kernel/cpu/hypervisor.c index f3e9219845e8..73428afca796 100644 --- a/arch/x86/kernel/cpu/hypervisor.c +++ b/arch/x86/kernel/cpu/hypervisor.c @@ -31,7 +31,7 @@ static const __initconst struct hypervisor_x86 * const hypervisors[] = #ifdef CONFIG_XEN_PV &x86_hyper_xen_pv, #endif -#ifdef CONFIG_XEN_PVHVM +#ifdef CONFIG_XEN &x86_hyper_xen_hvm, #endif &x86_hyper_vmware, diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index bb420a4cb75f..9e5bb51eecf4 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -50,24 +50,20 @@ config XEN_PV_DOM0 def_bool y depends on XEN_PV && XEN_DOM0 -config XEN_PVHVM - def_bool y - depends on XEN - config XEN_PVHVM_SMP def_bool y - depends on XEN_PVHVM && SMP + depends on XEN && SMP config XEN_PVHVM_GUEST bool "Xen PVHVM guest support" default y - depends on XEN_PVHVM && PCI + depends on XEN && PCI help Support running as a Xen PVHVM guest. config XEN_PVH bool "Xen PVH guest support" - depends on XEN && XEN_PVHVM && ACPI + depends on XEN && ACPI select PVH help Support for running as a Xen PVH guest. diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 717264ae269b..32d651aa9bc2 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -16,11 +16,10 @@ obj-y += mmu.o obj-y += time.o obj-y += grant-table.o obj-y += suspend.o - -obj-$(CONFIG_XEN_PVHVM) += enlighten_hvm.o -obj-$(CONFIG_XEN_PVHVM) += mmu_hvm.o -obj-$(CONFIG_XEN_PVHVM) += suspend_hvm.o -obj-$(CONFIG_XEN_PVHVM) += platform-pci-unplug.o +obj-y += enlighten_hvm.o +obj-y += mmu_hvm.o +obj-y += suspend_hvm.o +obj-y += platform-pci-unplug.o obj-$(CONFIG_XEN_PV) += setup.o obj-$(CONFIG_XEN_PV) += apic.o diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index d62c14334b35..5c7822254a01 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -586,7 +586,6 @@ void __init xen_init_time_ops(void) x86_platform.set_wallclock = xen_set_wallclock; } -#ifdef CONFIG_XEN_PVHVM static void xen_hvm_setup_cpu_clockevents(void) { int cpu = smp_processor_id(); @@ -643,7 +642,6 @@ void __init xen_hvm_init_time_ops(void) hvm_time_initialized = true; } -#endif /* Kernel parameter to specify Xen timer slop */ static int __init parse_xen_timer_slop(char *ptr) diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h index dc265bdda24d..47eebbb3684a 100644 --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@ -236,11 +236,7 @@ void xen_pin_vcpu(int cpu); void xen_emergency_restart(void); -#ifdef CONFIG_XEN_PVHVM void xen_hvm_post_suspend(int suspend_cancelled); -#else -static inline void xen_hvm_post_suspend(int suspend_cancelled) {} -#endif /* * The maximum amount of extra memory compared to the base size. The diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index f9a35ed266ec..cfb517cd77dc 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -311,7 +311,7 @@ config XEN_EFI config XEN_AUTO_XLATE def_bool y - depends on ARM || ARM64 || XEN_PVHVM + depends on ARM || ARM64 || X86 help Support for auto-translated physmap guests. diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 6ea945508a89..fd16d652c81f 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -2180,7 +2180,6 @@ static struct irq_chip xen_percpu_chip __read_mostly = { }; #ifdef CONFIG_X86 -#ifdef CONFIG_XEN_PVHVM /* Vector callbacks are better than PCI interrupts to receive event * channel notifications because we can receive vector callbacks on any * vcpu and we don't need PCI support or APIC interactions. */ @@ -2242,12 +2241,6 @@ static __init void xen_alloc_callback_vector(void) pr_info("Xen HVM callback vector for event delivery is enabled\n"); sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_xen_hvm_callback); } -#else -void xen_setup_callback_vector(void) {} -static inline void xen_init_setup_upcall_vector(void) {} -int xen_set_upcall_vector(unsigned int cpu) {} -static inline void xen_alloc_callback_vector(void) {} -#endif /* CONFIG_XEN_PVHVM */ #endif /* CONFIG_X86 */ bool xen_fifo_events = true; diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index fafb2b84fa5c..082b8c1fee8e 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -831,7 +831,7 @@ static void xenbus_probe(void) */ static bool xs_hvm_defer_init_for_callback(void) { -#ifdef CONFIG_XEN_PVHVM +#ifdef CONFIG_X86 return xen_store_domain_type == XS_HVM && !xen_have_vector_callback; #else diff --git a/include/xen/platform_pci.h b/include/xen/platform_pci.h index e51e7cb71a85..267040c1f504 100644 --- a/include/xen/platform_pci.h +++ b/include/xen/platform_pci.h @@ -30,7 +30,7 @@ static inline int xen_must_unplug_nics(void) { #if (defined(CONFIG_XEN_NETDEV_FRONTEND) || \ defined(CONFIG_XEN_NETDEV_FRONTEND_MODULE)) && \ - defined(CONFIG_XEN_PVHVM) + defined(CONFIG_X86) return 1; #else return 0; @@ -40,14 +40,14 @@ static inline int xen_must_unplug_nics(void) { static inline int xen_must_unplug_disks(void) { #if (defined(CONFIG_XEN_BLKDEV_FRONTEND) || \ defined(CONFIG_XEN_BLKDEV_FRONTEND_MODULE)) && \ - defined(CONFIG_XEN_PVHVM) + defined(CONFIG_X86) return 1; #else return 0; #endif } -#if defined(CONFIG_XEN_PVHVM) +#if defined(CONFIG_X86) extern bool xen_has_pv_devices(void); extern bool xen_has_pv_disk_devices(void); extern bool xen_has_pv_nic_devices(void); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:22:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382952.1626224 (Exim 4.92) (envelope-from ) id 1wrWt6-000379-UM; Wed, 05 Aug 2026 08:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382952.1626224; Wed, 05 Aug 2026 08:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWt6-00036y-R4; Wed, 05 Aug 2026 08:22:08 +0000 Received: by outflank-mailman (input) for mailman id 1382952; Wed, 05 Aug 2026 08:22:07 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWt5-00033d-2w for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:22:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrWt4-00BT5q-Fi for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:22:06 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f2ac-5cb7-0a2a0a5109dd-0a2a4506c88a-12 for ; Wed, 05 Aug 2026 10:22:06 +0200 Received: from [195.135.223.130] (helo=smtp-out1.suse.de) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f2ae-195a-0a2a45060019-c387df82848e-3 for ; Wed, 05 Aug 2026 10:22:06 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD87B7FC54; Wed, 5 Aug 2026 08:21:57 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A2099779C2; Wed, 5 Aug 2026 08:21:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sW4hJqXycmobcQAAD6G6ig (envelope-from ); Wed, 05 Aug 2026 08:21:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918121; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S6wRDsn8zV14CO6Sq0N2+3DPezIzqVg17lA8ie3S0eU=; b=Un5S22ckkkMJV+DlydoaTV76Mst3f0Mr745x2lsvZTgHTbZ2DxOFRNna5KaPLtdY/mp+Nh vuAyKT3ikDFEgkC40MNnRXHIjTpDf/iCQoa4/rEV+61AKT3jMUoYsL3ZrAmsMqVhORMArP Btm09DVWxJzk5PFBlU4wxaBMmsYTWeo= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S6wRDsn8zV14CO6Sq0N2+3DPezIzqVg17lA8ie3S0eU=; b=aDNX1xHePNwswx+9Pi36xqmHVw1AeMuAKP4+T7bm2glLOOcnbtQ2dCSMwPoz21GQbBRONH nImWX83UwYbG8rfNzz9sy+zpogUnOZC/3L81GCVvwidEmDqUpYkR8L4AQxm1dcfwXJvNB4 G1fURSmZMBIYonryH72LDCm3UB/9RZY= From: Juergen Gross To: linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: [PATCH 3/4] xen: Drop CONFIG_XEN_AUTO_XLATE Date: Wed, 5 Aug 2026 10:21:36 +0200 Message-ID: <20260805082137.1214967-4-jgross@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805082137.1214967-1-jgross@suse.com> References: <20260805082137.1214967-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-6.79 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.19)[-0.966]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:mid,suse.com:email]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Spam-Score: -6.79 X-Spam-Level: X-purgate-ID: tlsNG-16d1c6/1785918126-1FACA77B-7E098417/0/0 X-purgate-type: clean X-purgate-size: 3777 CONFIG_XEN_AUTO_XLATE is referenced only in code built with CONFIG_XEN enabled. As it is enabled for all architectures supporting Xen, it can be just dropped. Signed-off-by: Juergen Gross --- drivers/xen/Kconfig | 6 ------ drivers/xen/Makefile | 2 +- drivers/xen/privcmd.c | 4 ++-- include/xen/xen-ops.h | 22 ---------------------- 4 files changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index cfb517cd77dc..32e35a8580ee 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -309,12 +309,6 @@ config XEN_EFI def_bool y depends on (ARM || ARM64 || X86_64) && EFI -config XEN_AUTO_XLATE - def_bool y - depends on ARM || ARM64 || X86 - help - Support for auto-translated physmap guests. - config XEN_ACPI def_bool y depends on X86 && ACPI diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index c0503f1c7d5b..6ce2e2a52d47 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -2,6 +2,7 @@ obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o obj-y += grant-table.o features.o balloon.o manage.o time.o obj-y += mem-reservation.o +obj-y += xlate_mmu.o obj-y += events/ obj-y += xenbus/ @@ -29,7 +30,6 @@ obj-$(CONFIG_XEN_PRIVCMD) += xen-privcmd.o obj-$(CONFIG_XEN_ACPI_PROCESSOR) += xen-acpi-processor.o obj-$(CONFIG_XEN_EFI) += efi.o obj-$(CONFIG_XEN_SCSI_BACKEND) += xen-scsiback.o -obj-$(CONFIG_XEN_AUTO_XLATE) += xlate_mmu.o obj-$(CONFIG_XEN_PVCALLS_BACKEND) += pvcalls-back.o obj-$(CONFIG_XEN_PVCALLS_FRONTEND) += pvcalls-front.o xen-evtchn-y := evtchn.o diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 725a49a0eee7..7cfc28f1bb86 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -794,7 +794,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, goto out; } - if (IS_ENABLED(CONFIG_XEN_AUTO_XLATE) && !xen_pv_domain()) { + if (!xen_pv_domain()) { unsigned int nr = DIV_ROUND_UP(kdata.num, XEN_PFN_PER_PAGE); struct page **pages; unsigned int i; @@ -825,7 +825,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, if (rc) goto out; - if (IS_ENABLED(CONFIG_XEN_AUTO_XLATE) && !xen_pv_domain()) { + if (!xen_pv_domain()) { rc = xen_remap_vma_range(vma, kdata.addr, kdata.num << PAGE_SHIFT); } else { unsigned int domid = diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index 496e6013c689..15e0c3f4b7bb 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -59,7 +59,6 @@ static inline int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr, struct vm_area_struct; -#ifdef CONFIG_XEN_AUTO_XLATE int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, unsigned long addr, xen_pfn_t *gfn, int nr, @@ -68,27 +67,6 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, struct page **pages); int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma, int nr, struct page **pages); -#else -/* - * These two functions are called from arch/x86/xen/mmu.c and so stubs - * are needed for a configuration not specifying CONFIG_XEN_AUTO_XLATE. - */ -static inline int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, - unsigned long addr, - xen_pfn_t *gfn, int nr, - int *err_ptr, pgprot_t prot, - unsigned int domid, - struct page **pages) -{ - return -EOPNOTSUPP; -} - -static inline int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma, - int nr, struct page **pages) -{ - return -EOPNOTSUPP; -} -#endif int xen_remap_vma_range(struct vm_area_struct *vma, unsigned long addr, unsigned long len); -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:22:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:22:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382957.1626234 (Exim 4.92) (envelope-from ) id 1wrWtC-0003U5-AH; Wed, 05 Aug 2026 08:22:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382957.1626234; Wed, 05 Aug 2026 08:22:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWtC-0003Tt-72; Wed, 05 Aug 2026 08:22:14 +0000 Received: by outflank-mailman (input) for mailman id 1382957; Wed, 05 Aug 2026 08:22:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWtA-0003QP-QT for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:22:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrWt9-0036dz-Ud for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:22:11 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f2b1-5cb7-0a2a0a5109dd-0a2a450aa3f2-18 for ; Wed, 05 Aug 2026 10:22:11 +0200 Received: from [195.135.223.130] (helo=smtp-out1.suse.de) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f2b3-f2d2-0a2a450a0019-c387df8285d6-3 for ; Wed, 05 Aug 2026 10:22:11 +0200 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 717A67FC46; Wed, 5 Aug 2026 08:22:03 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2AD8B779B6; Wed, 5 Aug 2026 08:22:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kWcaCavycmohcQAAD6G6ig (envelope-from ); Wed, 05 Aug 2026 08:22:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References"; dkim=pass header.s=susede1 header.d=suse.com header.i="@suse.com" header.h="From:Date:Message-ID:To:Cc:MIME-Version:Content-Transfer-Encoding:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPDqya+4UA57J3GUJhbUC4MCTBzBvrkl/Z2toy8Sr1k=; b=ZoGUiQsj0jyqR8egDB6TgaUfolmQBnQi1EashLbUpEn9JMdtMrIgLSHNpTtJXjrYXCeDKw R3YHsrovTBo+1vz/RXS20N/cv10G2LLDnDVoozg98STi8eOF8ZpSZuE9Z5HiJQTJzuNYju tq5iViYKyQrSu0vC9Cx984N5YONY5Nc= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1785918123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rPDqya+4UA57J3GUJhbUC4MCTBzBvrkl/Z2toy8Sr1k=; b=mo44s7jJ01TikRPeLn+M7SzLNQoKze3eAxQ4UHYFODcY4riiv0QCSJnyczh3TFIu1NDoOy HMcPUpmkdfSt0h+nx86nxIPWVbyGP0dvshsoT8uyF88sKCYLQGR/NY4BXdU6YQYC5UaKVJ Y3cGuKyyN+V46bgtJruvIgsMvqkW4YI= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP Date: Wed, 5 Aug 2026 10:21:37 +0200 Message-ID: <20260805082137.1214967-5-jgross@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805082137.1214967-1-jgross@suse.com> References: <20260805082137.1214967-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.79 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-6.79 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.19)[-0.958]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:email,suse.com:mid]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; FROM_EQ_ENVFROM(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLfdszjqhz8kzzb9uwpzdm8png)]; RCPT_COUNT_SEVEN(0.00)[10]; RCVD_TLS_ALL(0.00)[] X-purgate-ID: tlsNG-4011c0/1785918131-59DDFCFC-F698A839/0/0 X-purgate-type: clean X-purgate-size: 1145 CONFIG_XEN_PVHVM_SMP is referenced only on x86 in Xen specific code, so it can be replaced with CONFIG_SMP. Signed-off-by: Juergen Gross --- arch/x86/xen/Kconfig | 4 ---- arch/x86/xen/Makefile | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 9e5bb51eecf4..609e79942fcb 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -50,10 +50,6 @@ config XEN_PV_DOM0 def_bool y depends on XEN_PV && XEN_DOM0 -config XEN_PVHVM_SMP - def_bool y - depends on XEN && SMP - config XEN_PVHVM_GUEST bool "Xen PVHVM guest support" default y diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 32d651aa9bc2..9c7e9ffffb85 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -37,8 +37,8 @@ obj-$(CONFIG_XEN_PVH) += enlighten_pvh.o obj-$(CONFIG_EVENT_TRACING) += trace.o obj-$(CONFIG_SMP) += smp.o +obj-$(CONFIG_SMP) += smp_hvm.o obj-$(CONFIG_XEN_PV_SMP) += smp_pv.o -obj-$(CONFIG_XEN_PVHVM_SMP) += smp_hvm.o obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:29:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:29:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382989.1626243 (Exim 4.92) (envelope-from ) id 1wrWzu-00051I-00; Wed, 05 Aug 2026 08:29:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382989.1626243; Wed, 05 Aug 2026 08:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWzt-00051B-Tg; Wed, 05 Aug 2026 08:29:09 +0000 Received: by outflank-mailman (input) for mailman id 1382989; Wed, 05 Aug 2026 08:29:08 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrWzs-000515-KW for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:29:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrWzs-00BUsu-1H for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:29:08 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f44c-e002-0a2a0a5209dd-0a2a450cdf62-16 for ; Wed, 05 Aug 2026 10:29:07 +0200 Received: from [40.93.201.62] (helo=CY3PR05CU001.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f450-f479-0a2a450c0019-285dc93ebed9-3 for ; Wed, 05 Aug 2026 10:29:05 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by DS0PR03MB8200.namprd03.prod.outlook.com (2603:10b6:8:293::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Wed, 5 Aug 2026 08:29:03 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Wed, 5 Aug 2026 08:29:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nPJ1TbLNTdv6viWLD3koI5xTNKI7wWR1p/UVLidU4tbYZdiQ/NA42uujDx2HP/U+SbjB6YUqX0TIcACSaULGWcEThyZ1rYiPrf0I/0ZUFxrc+52YETvsA5ksMXIktTsecNX3ZdzbEnQd3rztcxT/0toWH55XGn19Gu68pLi00DLBAtMvyAmwMvrLRW5E0qFfmTzLO1y+6svwwYTbPq+R913qIgFT74q927AqFn21xWHWezmxdRC3vmxwfXT4kXg1KE5plgfxN+uyV8pgbFo4YqY3V784EMwB4M5FGdPSKZzDCxx4ND56tFw1Xrk7ZX0BP7rLmvldlxQokmsxNjlXTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zp/pgBZDH+Lb5CV4YMTtHDjw9PCQLOyzUIdgVtTacZo=; b=y0u8zX0vqIQ9gS819nqF2CYWSkB3L7PE8lyCFdfsmdYR3w2/nBAHRo082Zb9GXFZcDUoQXvzwRvvk36c6rM8XPa+i2Elk5cFADtOxkMTSduW9qvhaltVlvmxe4+Azp3R0ykIZOj5ntrQAl7qXwSnFQ/MRf1ckZXmNiZYDMhZX/TK8MoEpvXmDgrFdFo0sYqMziu9LGM1Myu4kIgd3F9L44qCefel2wx0Y6M1GG6LJS/GNKEJxJ/s2/OzewPFJYb4SS0iazjlBmBL1y3COkyDanS3tFjIOULZWIqhfU1mRJaaN6HZWjmgxtLXGF0Yv5yPAzSW58oUUasQfjXcYzwLeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zp/pgBZDH+Lb5CV4YMTtHDjw9PCQLOyzUIdgVtTacZo=; b=leoN1A5FCrGr46CLtKoG/rdEdx1yCNNk7cO3Hgh/HJGU3J23Bc5MxPd6TWk7bsbE1lsIMdYFvVmAAMmdIjJuqjnDn4W2tvo9Uj2qVal5VuUW2kMkhphNZjW5+bYOP/X1aLSpsLAocvTC6RZaaDMurX2ksIH0QrRcji0o2bDwDxw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7179e004-76df-42be-94fd-f314614e65cd@citrix.com> Date: Wed, 5 Aug 2026 09:28:58 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/4] xen: Drop CONFIG_XEN_PVHVM To: Juergen Gross , linux-kernel@vger.kernel.org, x86@kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-3-jgross@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260805082137.1214967-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0006.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::15) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|DS0PR03MB8200:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e5c4a25-2d68-494e-3309-08def2cb9b1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|7416014|366016|10067099003|4143699003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ROBnaTTJpTdEkEkWEZ6ZWx34O5Fvyweh5G753wFmi3yYPvwQY92t6fW7ZBsr/96q4CG61a4qaRq6sbEtsw60wtRfLX4fH4pgLUPSUyU4+XfzYlUgLBSuKmG7oxz4ZwbVLCs3/YRMcASbLfEryVPHdOQisf/i2EJhHqZEsqRCjY7tUKnQ9QwHrVucmSNOf1wQ54bXP5fT4tIZ88H+hIKv6sQA7feFsIxomTbePoRB+vm12Zt/9PxczpydfVyiEjwz6CUD3ccl/YyQVrWmaTzQyu4pfH8Mmw4b3NFAMWAUot3M2PCGPPMvgbjC1LpF5j1xTRg1miUt0A2LJF+JYm53TA8KMHmSoyNET53+VaMT1xDdfBX7XWDGydvUL4uqqcirW7xw//S6KwhRh+/lprsatcD2+Zs7Sj/FC5Rzk82l0LMbnF8PkSbVuOpzzwzx+6LWJg6hEsK3HsR6sioijmu9Y54n6+QKo1o3dJc+wywtdcjsOHR38x9zxI/ZW2hyEVb4UZurELvihC+3PYAIWTr0Cu3FILXseF+IXssL+JXc/tc9lV+RyFWsCdu63L/hzoOYutDYLFIr31etGiQ9ciNYIvf+AFv2xD1uokBQwiUeA83h+pLsGvORDEUHPEkdh4vE0U+9xy43dHomDbm+AfR0hGb+eg66hi0MCr6QaImlY3I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(7416014)(366016)(10067099003)(4143699003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YndXcnFBUmJYN1N5dUhqRnhtZFpDMUlpVVJkTUhnTk5jOExpRUY3Y2EvSnhX?= =?utf-8?B?a3dKOGZ3RUVaNHJBSnpQWUlDN3hZMUxTRjdFSjJiMUZMaVBmaU9ndjFwSGNG?= =?utf-8?B?NWJIRlJnNldMdkliZStVL24xaTFwbkdwUTFReHYyeUZrWHRBUkZKUGxrT2ZY?= =?utf-8?B?MVVJTFRZQ3RhSThHc1NDODRZTk1QcUdsZDcwZDRjTE14RmozbThPZE1YWnp2?= =?utf-8?B?QzBKVHIrYmtqTEdTN055NGp6RzMvai82L2sxQnpWNlVycVdkeDNVTFdaSEhJ?= =?utf-8?B?ZnRyNUkzYzdRYWUxZ2JmeTIwZjNZQm1XMm9GTzJWUTRaOTZ2UEZRanhWWisw?= =?utf-8?B?amtJZWVLQk9lZlpOZXJSN3RJbjhzeHJwK2NBb0VZNEJMcW9XTWN6YUhCV2ZD?= =?utf-8?B?QTFBcUtZZmNYUTh1Mzl1ekl5dlRicEcwSWZEdzlJRzFuTGlpRi92N3hlaUFO?= =?utf-8?B?QmFtQllUZXUzVXNHaVBBZmcrLzZvUHU2bHBPaGxJYjY3dXRrSHExaWJjZ096?= =?utf-8?B?N1JFRnhiQTZGTk94c3E4UVd6NW90YS93dWJNTjFQVE5hV1lKd3o2aU5TVzFs?= =?utf-8?B?NTJ1b0JCQkZvV3VBMEtSc0xqeGE4ZDBKVmNWTzVHcTEvTWtkR1lGMVo3TnFu?= =?utf-8?B?ZlpRQzRkemlVeXBiRTZobGlhNndIOURTd0FES0c5b2tiS0cyU1ZaUURmeks3?= =?utf-8?B?UjhSYW9xdVZHL3dNaEJ6Y1RMZTgxeXROYmptbUZkMS8zNHk3MEJISC9VTXJS?= =?utf-8?B?TTlQbGhKRG9FZFY5RHR0cWxhbW5WT25KbkV3V1lCSkRRQVRKZWtFKzJWQVJD?= =?utf-8?B?bDNKWEZmdW5zKzVqcFBqUG9ZYXNlM1VEeUNTVkRQZGx0Q1NVZkQraXM2QzU0?= =?utf-8?B?UlJ4TG5NcC9CNVJZekNkU3QwV1hKNGJEMHo4c1pjaWM5MnNLWGpvR3hiZ25o?= =?utf-8?B?OUZLdU9GV3g0U1lWWTJhM0pHcVluWUdCRUxQM3g5eTNsdkxJWkUyKzJ3TWtW?= =?utf-8?B?dTA5SnZBSGV1ZnBsd1FBTDBTOTg5blNjTllIcUdYekptdWZyZzJhYVg0anJ0?= =?utf-8?B?MFU0VmZQV3lndlp1N3p6WnAycGorRGUxMnNBTm1QSGg0OFVHakZmSTN1ejFP?= =?utf-8?B?MWJEL3NUdjFET3BXczEwVlRVYXgvSnhuRDBLQ3dvK1V1S0F4TEh5cjE4SkY2?= =?utf-8?B?d3B1KzlyZitWbnREYWltL0dzMEFCS3hNZ0hIVk51V3EvU2ZZOG9BV1ZZR1o1?= =?utf-8?B?ck1DOWYydVcwQzU2a1hxQkxuQ1NEeGxPMlhqc1JKNDN5bytQam9CanJMdDBC?= =?utf-8?B?dmx2Z3lENkNQNUZrUkpJalovU3dCVG84c2xQK1NYbjRjYnlEVmVUTjV3VE53?= =?utf-8?B?aHc2OTZ2UCtLcVRyWkhYa1FESGdva3FreUZTSjhCWWsybHRlakR2MVFvNG1D?= =?utf-8?B?TmRJUUVieFlTZ0ZLb3MvQTNvdnRlb2RGTkp1aGt0YmFiek10VkcxbStITUdN?= =?utf-8?B?WWExVnNaNHdUbHBIZkdmL2lYN096M2RPeXZGcmdrQzBIL3I0eVNkU2w4UjJI?= =?utf-8?B?TlRsNVRWTldjNVphcEU4eHJtV0tqTkdHNDNlYkNjcHVSVUJDbERicjduMDBL?= =?utf-8?B?ZkFQWjZ0aTdmNGdnb015TGZ6SEtqM21qUDhicE5qdE4vanc5dW5yRE82K1Qr?= =?utf-8?B?V2JHdVNxL2dnazZ4VXFRNjgzdXA3NHJOKzc3TitUWXZVRlhFY2cycHRrdEpn?= =?utf-8?B?MUZXUDRwWllQTkJkWlZVU0dwa251dDUzbStUY3lhakI2cTI4NncwanNBL05I?= =?utf-8?B?ZWkySzNibWxld1lDUW5ldTlCc1RKRDFhNUpXWHArWld0U1c1S09WK2R4WmFz?= =?utf-8?B?SURES0ZRTWxkTDBBZnZYcnJaT3dmNkV4UlU1RzVQVnVXWkR1TW9yMDNMMEJ1?= =?utf-8?B?SVZrWVc1NkR0ajV6ZnY1WGhFVDJURUp1THhRZnNSLzFLNmc2Z21PVXlSS1h4?= =?utf-8?B?bUExWkxaUGg1SjlMTGQxTGVIQUdhSksxcDRwL2tUbXcxNmNrbm10NW9VQUdD?= =?utf-8?B?eEwwRGk3WXM4REpwZ29kcjJYUmlKc1FXcUlXZkRxd3JHMzRGUWoyVkxJZ1Nq?= =?utf-8?B?bER6YjFWamdQV3VzRVVLQjQxQ1RaNkRxbkNpbmhRUU8zSldwM3Jpb1JIS25i?= =?utf-8?B?NmR6cklZUlZNRUFaTWZ1TDUybWVydmxkY0pxWm1IRUd5SU85a3hscXAyWjJo?= =?utf-8?B?cmsrczdvcFFnMmtLMkpPSnpVUGdROEFWVTUwU1JnaTVQeVh6eGFEcno3Mkdp?= =?utf-8?B?dmZUVS9kaWU5b0h4TUE5Nm9CVzlNNXNaMXBDMWNnZ1R4ZUZCYXoyWVhUVHJx?= =?utf-8?Q?TsRf4a0Uk6kyvqpQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5c4a25-2d68-494e-3309-08def2cb9b1c X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 08:29:02.9384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HERn3Vt9+OjSsnyeOfZMaWYTZ8aZbnTaa9KV26QeQg/1znFjAI/B07/ItGBQgIXz+8MEauJM9+Ojdri2I2KnRjdScCTp/m/hoI+7I+Q0xHM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR03MB8200 X-purgate-ID: tlsNG-d25034/1785918546-00CCBA5B-FBA10572/0/0 X-purgate-type: clean X-purgate-size: 1206 On 05/08/2026 9:21 am, Juergen Gross wrote: > On x86 CONFIG_XEN_PVHVM is now a synonym of CONFIG_XEN. > > In Xen specific x86 code it can be just dropped, in non-Xen specific > x86 code it can be replaced with CONFIG_XEN. > > In architecture independent code it is used only where CONFIG_XEN is > defined, so it can be replaced with CONFIG_X86 there. > > Signed-off-by: Juergen Gross > > diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h > index 20f548702404..f400cfac69a6 100644 > --- a/arch/x86/include/asm/idtentry.h > +++ b/arch/x86/include/asm/idtentry.h > @@ -745,7 +745,7 @@ DECLARE_IDTENTRY_SYSVEC(HYPERV_STIMER0_VECTOR, sysvec_hyperv_stimer0); > DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); > #endif > > -#ifdef CONFIG_XEN_PVHVM > +#ifdef CONFIG_XEN > DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, sysvec_xen_hvm_callback); > #endif I'm very happy to see a reduction in the number of Kconfig symbols for Xen (there are definitely too many), but this looks wonky. Or are you saying that there really is no way to build a Xen PV guest excluding the HVM-only bits? ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:29:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:29:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1382997.1626252 (Exim 4.92) (envelope-from ) id 1wrX0X-0005W6-7f; Wed, 05 Aug 2026 08:29:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1382997.1626252; Wed, 05 Aug 2026 08:29:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrX0X-0005Vz-4r; Wed, 05 Aug 2026 08:29:49 +0000 Received: by outflank-mailman (input) for mailman id 1382997; Wed, 05 Aug 2026 08:29:48 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrX0W-0005Vt-6Y for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:29:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrX0V-0038D2-JZ for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:29:47 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f46f-2eae-0a2a0a5409dd-0a2a45099aea-42 for ; Wed, 05 Aug 2026 10:29:47 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f47b-be1a-0a2a45090019-d155dd2ab9ab-3 for ; Wed, 05 Aug 2026 10:29:47 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f84023916so585398f8f.3 for ; Wed, 05 Aug 2026 01:29:47 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfe5d7csm7306200f8f.15.2026.08.05.01.29.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:29:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:Autocrypt:Subject:From:Cc:To:Content-Language:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785918587; x=1786523387; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=cAYu0/I5sBdxVDFVz3zsOh9BrRmirAGTcNyUBffNHFs=; b=KNXpGbxyvXhdsAnZlOnygETV9HzqBRF48vBEK7vCGiCnZ0cg9s/O6qW+c2wDG8zDp3 c7n/YNwFBa9Zz/NHaFNS8FEGNynMK6UFLV3Ln5O0C+Fw7maA7o0FZn9PBFY7NDGx1LC/ JTuKqOyhPwbOVXnr/AS6TkcpZyZITOJ9J6/p3uMvNYF6rRQ5uQe8s7X2KBWcRWBaA0U6 03AIIMi15Bzo286LJ7nlncx8W5TRvJ5sWb7bh77wku5pJJ72PV9lscjVP+BFG4B+3N// qjhD53RCgqv8uY0OKj6QCAVk+gqBr6cXR2Uo/A8CaSonIBDZEdg6lLtDEuoqkFynATlK 0Kpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785918587; x=1786523387; h=content-transfer-encoding:content-type:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cAYu0/I5sBdxVDFVz3zsOh9BrRmirAGTcNyUBffNHFs=; b=BXsgIfnTuczky4IfoA+ZB4nwWDiU8SqHiIAhqCXUeYPknKW6mV1L3iOWfMTciWYMga w02SejC9Qm2KHa2o6bAyNjXzV8aJHB0nO03QB00HwKcanejtEKnBqjq+zaHdXYJ+Z/6+ OWGo+sFlMpPjNFmPB92lakIpaoBTLVhaJL3bKM1SMvTjnMPx7+vOecDSQl7V5eihE1NK Umc3z5bGvNjOTuIim/ZGtCeT1DrsKOQOI+lWNPyYCFs9JyjIhyh9teUONRkO0pZFyPd4 BomHu2g3vWlFCYOJRYuXMMxjJpB9dnDRDHh9jCNS0/jLC5F/LgEc4E2LUf6J2+Ug21fD l0gw== X-Gm-Message-State: AOJu0YwLrwYl7/VAw/if8LPUijlp5eV4zyJw9SJIMtjyiTwpZgwQyU5W jYZ/8+8Mllra8L+SCz+GlAOgms/MQ0GzblVlhIu8ocGYS5Km7sfSN9k6GlLyrOFjrsGI9FYNUTJ TWB59vA== X-Gm-Gg: AR+sD10ZADqSR4fdXab7GzTcRJQ5yIKBoskNr+GMlz8ACKpLkhPatsPZyes1kI2pU/M AzpQrC26a4N0Qt+azs8q8202U8HUo5B/BBxUH99s64hRdY1ltv1cwElsdVHlW7yrQPGRMFck6Of QYOlUwQ+g4WU+9gSHyUfuDr5ajafi6z19F8Mi80rGkdBpiEui/fICksRIPo6LWFMf5vEXovDJKa 333d75bJna2jXh9vfXK2yzsaRzYS8sTFq64GYYLcXDZTWU60N95oSIOHUtTd8E9r26M10W+Lqc/ vGAuIrBI9IAsrblCJBFjAEVHNZGqP6xA1fyCwGyNWaM5mjsCAUDLYf0acrKZaCCULrwpPDjf7Bi PWB/O+RkJ9QwaY+UUhlLNQSAO83tr4WUg6qFZsDer9yX2hCKLuLl4/ROosSWebz54Dgxm/meAKN HC49eiXk1cz0XC0BULypKz8/Mz/kFBjNjQ+GFYylpn4MBgjYhkHKnN0j2cJwIg437VaSF3RtSFV 3TzBHEMlGEwzo8Ecz/oT9fiq5PJxC8vTkJUbBvZyW+GWG+g3Pe2 X-Received: by 2002:adf:e005:0:10b0:47f:d0fb:ea40 with SMTP id ffacd0b85a97d-47fec532b81mr6611273f8f.21.1785918586889; Wed, 05 Aug 2026 01:29:46 -0700 (PDT) Message-ID: <2a4d839d-44ce-40fb-af7b-5becd878c9fc@suse.com> Date: Wed, 5 Aug 2026 10:29:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] x86: reduce dependencies on x86_emulate/x86_emulate.h Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1785918587-FDA6E034-C3C315E6/0/0 X-purgate-type: clean X-purgate-size: 13038 Split out struct x86_event to an entirely separate header, and move a few other items describing the architecture to a new x86-types.h. With a few forward decls of structures and with a fair number of new #include-s in .c files, the inclusion of x86_emulate.h (and hence x86_emulate/x86_emulate.h) can be dropped from all header files except hvm/emulate.h; it needs additionally adding to hvm/ioreq.h though. Signed-off-by: Jan Beulich --- The use in drivers/vpci/msix.c is certainly somewhat bogus, but as long as X86EMUL_OKAY etc are used directly there, that's the way to go. Like done for IOREQ, some abstraction will be needed here if this file was to be re-used by non-x86. --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @@ -305,7 +305,7 @@ $(call cc-option-add,HOSTCFLAGS-x86_64,H HOSTCFLAGS += $(CFLAGS_xeninclude) -I. $(HOSTCFLAGS-$(XEN_COMPILE_ARCH)) x86.h := $(addprefix $(XEN_ROOT)/tools/include/xen/asm/,\ - x86-vendors.h x86-defns.h msr-index.h) \ + x86-vendors.h x86-defns.h x86-types.h x86-event.h msr-index.h) \ $(addprefix $(XEN_ROOT)/tools/include/xen/lib/x86/, \ cpu-policy.h cpuid-autogen.h) x86_emulate.h := x86-emulate.h x86_emulate/x86_emulate.h x86_emulate/private.h $(x86.h) --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -38,6 +38,8 @@ #include #include +#include +#include #include #include --- a/xen/arch/x86/emul-i8254.c +++ b/xen/arch/x86/emul-i8254.c @@ -37,6 +37,7 @@ #include #include #include +#include #define domain_vpit(x) (&(x)->arch.vpit) #define vcpu_vpit(x) (domain_vpit((x)->domain)) --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -11,6 +11,8 @@ #include #include #include +#include + #include #include #include --- a/xen/arch/x86/hvm/mmio.c +++ b/xen/arch/x86/hvm/mmio.c @@ -9,6 +9,7 @@ #include #include +#include static int cf_check subpage_mmio_accept(struct vcpu *v, unsigned long addr) { --- a/xen/arch/x86/hvm/pmtimer.c +++ b/xen/arch/x86/hvm/pmtimer.c @@ -11,6 +11,8 @@ #include #include #include /* for hvm_acpi_power_button prototype */ +#include + #include /* Slightly more readable port I/O addresses for the registers we intercept */ --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -23,12 +23,15 @@ */ #include -#include -#include +#include + #include #include +#include #include -#include +#include +#include + #include #define USEC_PER_SEC 1000000UL --- a/xen/arch/x86/hvm/stdvga.c +++ b/xen/arch/x86/hvm/stdvga.c @@ -34,6 +34,8 @@ #include #include +#include + #define VGA_MEM_BASE 0xa0000 #define VGA_MEM_SIZE 0x20000 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -38,6 +38,7 @@ #include #include #include +#include /* HACK: Route IRQ0 only to VCPU0 to prevent time jumps. */ #define IRQ0_SPECIAL_ROUTING 1 --- a/xen/arch/x86/hvm/viridian/private.h +++ b/xen/arch/x86/hvm/viridian/private.h @@ -5,6 +5,8 @@ #include #include +#include + #include int viridian_synic_wrmsr(struct vcpu *v, uint32_t idx, uint64_t val); --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -18,6 +18,7 @@ #include #include #include +#include static DEFINE_PER_CPU(u64 *, vvmcs_buf); --- a/xen/arch/x86/hvm/vpic.c +++ b/xen/arch/x86/hvm/vpic.c @@ -33,6 +33,7 @@ #include #include #include +#include #define vpic_domain(v) (container_of((v), struct domain, \ arch.hvm.vpic[!(v)->is_master])) --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -8,7 +8,8 @@ #include #include #include -#include +#include + #include #include --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -16,11 +16,13 @@ #include #include #include -#include +#include +#include struct pirq; /* needed by pi_update_irte */ struct hvm_hw_cpu; struct xen_domctl_createdomain; +struct x86_event; #ifdef CONFIG_HVM_FEP /* Permit use of the Forced Emulation Prefix in HVM guests */ --- a/xen/arch/x86/include/asm/hvm/ioreq.h +++ b/xen/arch/x86/include/asm/hvm/ioreq.h @@ -8,6 +8,8 @@ #ifndef __ASM_X86_HVM_IOREQ_H__ #define __ASM_X86_HVM_IOREQ_H__ +#include + /* This correlation must not be altered */ #define IOREQ_STATUS_HANDLED X86EMUL_OKAY #define IOREQ_STATUS_UNHANDLED X86EMUL_UNHANDLEABLE --- a/xen/arch/x86/include/asm/hvm/vcpu.h +++ b/xen/arch/x86/include/asm/hvm/vcpu.h @@ -14,6 +14,8 @@ #include #include #include +#include + #include struct hvm_vcpu_asid { --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -9,6 +9,8 @@ #include +#include + extern void vmcs_dump_vcpu(struct vcpu *v); extern int vmx_vmcs_init(void); int cf_check vmx_cpu_up_prepare(unsigned int cpu); --- a/xen/arch/x86/include/asm/mce.h +++ b/xen/arch/x86/include/asm/mce.h @@ -35,6 +35,7 @@ struct vmce { struct domain; struct vcpu; +struct hvm_vmce_vcpu; /* Guest vMCE MSRs virtualization */ extern void vmce_init_vcpu(struct vcpu *v); --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -8,7 +8,6 @@ #include #include #include -#include /* * Per-page-frame information. --- /dev/null +++ b/xen/arch/x86/include/asm/x86-event.h @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * x86-event.h + * + * Helper definitions for event handling, which aren't prescribed by the + * architecture itself. + */ + +#ifndef X86_X86_EVENT_H +#define X86_X86_EVENT_H + +#ifdef __XEN__ +# include +#else +# include +#endif + +#define X86_EVENT_NO_EC (-1) /* No error code. */ + +struct x86_event { + int16_t vector; + uint8_t type; /* X86_ET_* */ + uint8_t insn_len; /* Instruction length */ + int32_t error_code; /* X86_EVENT_NO_EC if n/a */ + union { + unsigned long cr2; /* #PF */ + unsigned long pending_dbg; /* #DB (new DR6 bits, positive polarity) */ + }; +}; + +#endif /* X86_X86_EVENT_H */ --- /dev/null +++ b/xen/arch/x86/include/asm/x86-types.h @@ -0,0 +1,76 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * x86-types.h + * + * Type definitions and basic helpers which are more or less directly + * describing aspects of the architecture. + */ + +#ifndef X86_X86_TYPES_H +#define X86_X86_TYPES_H + +#ifdef __XEN__ +# include +#else +# include +#endif + +/* + * Comprehensive enumeration of x86 segment registers. Various bits of code + * rely on this order (general purpose before system, tr at the beginning of + * system). + */ +enum x86_segment { + /* General purpose. Matches the SReg3 encoding in opcode/ModRM bytes. */ + x86_seg_es, + x86_seg_cs, + x86_seg_ss, + x86_seg_ds, + x86_seg_fs, + x86_seg_gs, + /* System: Valid to use for implicit table references. */ + x86_seg_tr, + x86_seg_ldtr, + x86_seg_gdtr, + x86_seg_idtr, + /* No Segment: For (system/normal) accesses which are already linear. */ + x86_seg_sys, + x86_seg_none +}; + +static inline bool is_x86_user_segment(enum x86_segment seg) +{ + unsigned int idx = seg; + + return idx <= x86_seg_gs; +} +static inline bool is_x86_system_segment(enum x86_segment seg) +{ + return seg >= x86_seg_tr && seg < x86_seg_none; +} + +/* + * Full state of a segment register (visible and hidden portions). + * Chosen to match the format of an AMD SVM VMCB. + */ +struct segment_register { + uint16_t sel; + union { + uint16_t attr; + struct { + uint16_t type:4; + uint16_t s: 1; + uint16_t dpl: 2; + uint16_t p: 1; + uint16_t avl: 1; + uint16_t l: 1; + uint16_t db: 1; + uint16_t g: 1; + uint16_t pad: 4; + }; + }; + uint32_t limit; + uint64_t base; +}; + +#endif /* X86_X86_TYPES_H */ --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include --- a/xen/arch/x86/pv/misc-hypercalls.c +++ b/xen/arch/x86/pv/misc-hypercalls.c @@ -12,6 +12,7 @@ #include #include #include +#include long do_set_debugreg(int reg, unsigned long value) { --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -13,6 +13,11 @@ #include +#ifdef __XEN__ +# include +# include +#endif + #define MAX_INST_LEN 15 #if defined(__i386__) @@ -25,77 +30,6 @@ struct x86_emulate_ctxt; -/* - * Comprehensive enumeration of x86 segment registers. Various bits of code - * rely on this order (general purpose before system, tr at the beginning of - * system). - */ -enum x86_segment { - /* General purpose. Matches the SReg3 encoding in opcode/ModRM bytes. */ - x86_seg_es, - x86_seg_cs, - x86_seg_ss, - x86_seg_ds, - x86_seg_fs, - x86_seg_gs, - /* System: Valid to use for implicit table references. */ - x86_seg_tr, - x86_seg_ldtr, - x86_seg_gdtr, - x86_seg_idtr, - /* No Segment: For (system/normal) accesses which are already linear. */ - x86_seg_sys, - x86_seg_none -}; - -static inline bool is_x86_user_segment(enum x86_segment seg) -{ - unsigned int idx = seg; - - return idx <= x86_seg_gs; -} -static inline bool is_x86_system_segment(enum x86_segment seg) -{ - return seg >= x86_seg_tr && seg < x86_seg_none; -} - -#define X86_EVENT_NO_EC (-1) /* No error code. */ - -struct x86_event { - int16_t vector; - uint8_t type; /* X86_ET_* */ - uint8_t insn_len; /* Instruction length */ - int32_t error_code; /* X86_EVENT_NO_EC if n/a */ - union { - unsigned long cr2; /* #PF */ - unsigned long pending_dbg; /* #DB (new DR6 bits, positive polarity) */ - }; -}; - -/* - * Full state of a segment register (visible and hidden portions). - * Chosen to match the format of an AMD SVM VMCB. - */ -struct segment_register { - uint16_t sel; - union { - uint16_t attr; - struct { - uint16_t type:4; - uint16_t s: 1; - uint16_t dpl: 2; - uint16_t p: 1; - uint16_t avl: 1; - uint16_t l: 1; - uint16_t db: 1; - uint16_t g: 1; - uint16_t pad: 4; - }; - }; - uint32_t limit; - uint64_t base; -}; - struct x86_emul_fpu_aux { unsigned long ip, dp; uint16_t cs, ds; --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -25,6 +25,7 @@ #include #include +#include #define VMSIX_ADDR_IN_RANGE(addr, vpci, nr) \ ((addr) >= vmsix_table_addr(vpci, nr) && \ From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:36:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:36:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383010.1626260 (Exim 4.92) (envelope-from ) id 1wrX77-0007SY-01; Wed, 05 Aug 2026 08:36:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383010.1626260; Wed, 05 Aug 2026 08:36:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrX76-0007SR-TR; Wed, 05 Aug 2026 08:36:36 +0000 Received: by outflank-mailman (input) for mailman id 1383010; Wed, 05 Aug 2026 08:36:35 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrX75-0007SI-Jc for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:36:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrX74-00HNgL-KO for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:36:34 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f611-bab6-0a2a0a5309dd-0a2a450cd29c-2 for ; Wed, 05 Aug 2026 10:36:34 +0200 Received: from [209.85.218.45] (helo=mail-ej1-f45.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f612-f479-0a2a450c0019-d155da2db119-3 for ; Wed, 05 Aug 2026 10:36:34 +0200 Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-c167aa9500dso116662666b.3 for ; Wed, 05 Aug 2026 01:36:34 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2035e23afcsm89067666b.0.2026.08.05.01.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:36:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785918994; x=1786523794; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=x9EKI6NPBJG8Y7nbkj7ihhK4/1jMO++H4iDHuFnaf2I=; b=fYAkHzayNo91kYj5u5WCG6iINZ8L0MqiTpo+I9Ivu7HxWdAuAujZigeoxZIAceOyOM GJmsKTsycPiGiQXZ/y5oXiyAQIz7bpbPnWxB1g2maEcI4Fxb/nu4EKgft567iwkQUVbb SFIMMFHUKuMYWUXcQwZtzsJ9ilVWZXW9Lo5zVQZc0OU0PNLjML3dYqpJbXs2WN5nT3OV 4gkt+B7i4gyRtNi+MUu74sro2QujIh4GTfuJUxwdmIIFBtBNyQ95l8+Lny2numHYsUkP LGsZYMzPyuxkgNtqa3oPao3sXgqiO/7WMJg+smBPlWM0MMTwlc1UIRZGYbe6qO2sK7KE ydSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785918994; x=1786523794; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x9EKI6NPBJG8Y7nbkj7ihhK4/1jMO++H4iDHuFnaf2I=; b=WEfxiQLnaFuOKvcVhkcvDrQClFs+SEdGWW71IVmkOdqp6Fc1DqIDapU3yQ8P1X321w 4s74hNxvzWC4l2DR7l1m4D1Ag0KDBgdnHdqbyFogL217X1+3jjdoZ5GJQogUCJbgQFiY Dif54AKfeQey+Ur0LhFYP2OqRfu7NhniQ4EdkZ2FuRtLcU2cL+LaKwiixJreGn8fyGiH 2dbIu5usj3YyMgFljxDs4E3ROWLKloH0jwE4rzlyQA9u9mOxPLiRFXvlrzfZwFkk3Q93 vEW9qrLoPN5GsSXFO/yYx6AVV3t24ownVOmgMHgDXsun09hq/LsyIT5PkFvlkvxvuAqC DQ0w== X-Forwarded-Encrypted: i=1; AHgh+RqIG0WljcnYr+W72tBdd7t4bs35kuC0auCfIQJeijjNbQp+ikpoHAVWl4YR0lEtoG17kFESqQTqEeY=@lists.xenproject.org X-Gm-Message-State: AOJu0YzNn9jQQjR/5IItKylSvyvuxZgTnud8xiscg/cNl0QmlkF5peqm GAYdcWjlsVZqwhISEibMLMQQY41WSaxxWKpHuQIwu0ZkHyCzhLfqPHuMiFJn6THby/o= X-Gm-Gg: AR+sD12ZS78mO6Pid9a9wmVFuR7qhZDpsp4jBLN6z1Fnr89wA/q3MuTNIVAYow+0z9H 5foG4wA4aUqQLsTm+yBRRlSiaVzlbFnUQKvVbWj+XNpN/Ufv9wEiMYuDoCUm7MVwJVyr62/8NOG /u5MlStNIEBA/KMovifeGaPB/JqwUldK8COHoLuZsGhbdSNvexY0KiQyTEiPpAq/YjilNtei9Km uLYnGBsf2O1K71QFDYE5PmaeikhhK2jAClKAD26DJtIEPCr2cJijyx5CaVzk1tdjsKw5nZzf5W2 C7YZip5WENoP0wnOOwGXoa7oMEaX0aXdg7IvrdGZcECkPtGqIRkLS/zrhsHPIhUKFJkPDR4TULD OXwMKw4owlF8iJAb94HSI76MKWbwUsQAS25EGhO1GCd6I7u8kfZAUqly2puBBvvCkeeSZvrs8VZ 6Ch0TJbaUQOGDXOd/CcT+D1ac8wg0HOLVRe5Yea+ECs8G9T9EwJqjzqeP/Nddj8sXdrn6sPBUWA LLdfhMMBuG4V9NIPrLOkOTClNQGg/rWshcb7Keh31WW658Oc9bXIBDPVrrN2p2x0xOtEpw8C/5U +4RZZzLkerklJJY= X-Received: by 2002:a17:907:ea8b:b0:c16:126b:98b4 with SMTP id a640c23a62f3a-c2039c03283mr237087466b.3.1785918993934; Wed, 05 Aug 2026 01:36:33 -0700 (PDT) Message-ID: <15824536-dff6-426d-b54c-6a1f362adaa2@suse.com> Date: Wed, 5 Aug 2026 10:36:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] xen: Drop CONFIG_XEN_PVHVM To: Andrew Cooper , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-3-jgross@suse.com> <7179e004-76df-42be-94fd-f314614e65cd@citrix.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <7179e004-76df-42be-94fd-f314614e65cd@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------03hIooiG2e5DB35vNVoqR7Vu" X-purgate-ID: tlsNG-d25034/1785918994-774D7A5B-045C80CA/0/0 X-purgate-type: clean X-purgate-size: 8222 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------03hIooiG2e5DB35vNVoqR7Vu Content-Type: multipart/mixed; boundary="------------dsfviep0ZNxgC3wnR9IF0PBk"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Message-ID: <15824536-dff6-426d-b54c-6a1f362adaa2@suse.com> Subject: Re: [PATCH 2/4] xen: Drop CONFIG_XEN_PVHVM References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-3-jgross@suse.com> <7179e004-76df-42be-94fd-f314614e65cd@citrix.com> In-Reply-To: <7179e004-76df-42be-94fd-f314614e65cd@citrix.com> --------------dsfviep0ZNxgC3wnR9IF0PBk Content-Type: multipart/mixed; boundary="------------cjd2b7oUonfOwrhy1dlPiUfP" --------------cjd2b7oUonfOwrhy1dlPiUfP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTA6MjgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA1LzA4LzIw MjYgOToyMSBhbSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IE9uIHg4NiBDT05GSUdfWEVO X1BWSFZNIGlzIG5vdyBhIHN5bm9ueW0gb2YgQ09ORklHX1hFTi4NCj4+DQo+PiBJbiBYZW4g c3BlY2lmaWMgeDg2IGNvZGUgaXQgY2FuIGJlIGp1c3QgZHJvcHBlZCwgaW4gbm9uLVhlbiBz cGVjaWZpYw0KPj4geDg2IGNvZGUgaXQgY2FuIGJlIHJlcGxhY2VkIHdpdGggQ09ORklHX1hF Ti4NCj4+DQo+PiBJbiBhcmNoaXRlY3R1cmUgaW5kZXBlbmRlbnQgY29kZSBpdCBpcyB1c2Vk IG9ubHkgd2hlcmUgQ09ORklHX1hFTiBpcw0KPj4gZGVmaW5lZCwgc28gaXQgY2FuIGJlIHJl cGxhY2VkIHdpdGggQ09ORklHX1g4NiB0aGVyZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBK dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2Fy Y2gveDg2L2luY2x1ZGUvYXNtL2lkdGVudHJ5LmggYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9p ZHRlbnRyeS5oDQo+PiBpbmRleCAyMGY1NDg3MDI0MDQuLmY0MDBjZmFjNjlhNiAxMDA2NDQN Cj4+IC0tLSBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL2lkdGVudHJ5LmgNCj4+ICsrKyBiL2Fy Y2gveDg2L2luY2x1ZGUvYXNtL2lkdGVudHJ5LmgNCj4+IEBAIC03NDUsNyArNzQ1LDcgQEAg REVDTEFSRV9JRFRFTlRSWV9TWVNWRUMoSFlQRVJWX1NUSU1FUjBfVkVDVE9SLAkJc3lzdmVj X2h5cGVydl9zdGltZXIwKTsNCj4+ICAgREVDTEFSRV9JRFRFTlRSWV9TWVNWRUMoSFlQRVJW SVNPUl9DQUxMQkFDS19WRUNUT1IsCXN5c3ZlY19hY3JuX2h2X2NhbGxiYWNrKTsNCj4+ICAg I2VuZGlmDQo+PiAgIA0KPj4gLSNpZmRlZiBDT05GSUdfWEVOX1BWSFZNDQo+PiArI2lmZGVm IENPTkZJR19YRU4NCj4+ICAgREVDTEFSRV9JRFRFTlRSWV9TWVNWRUMoSFlQRVJWSVNPUl9D QUxMQkFDS19WRUNUT1IsCXN5c3ZlY194ZW5faHZtX2NhbGxiYWNrKTsNCj4+ICAgI2VuZGlm DQo+IA0KPiBJJ20gdmVyeSBoYXBweSB0byBzZWUgYSByZWR1Y3Rpb24gaW4gdGhlIG51bWJl ciBvZiBLY29uZmlnIHN5bWJvbHMgZm9yDQo+IFhlbiAodGhlcmUgYXJlIGRlZmluaXRlbHkg dG9vIG1hbnkpLCBidXQgdGhpcyBsb29rcyB3b25reS4NCj4gDQo+IE9yIGFyZSB5b3Ugc2F5 aW5nIHRoYXQgdGhlcmUgcmVhbGx5IGlzIG5vIHdheSB0byBidWlsZCBhIFhlbiBQViBndWVz dA0KPiBleGNsdWRpbmcgdGhlIEhWTS1vbmx5IGJpdHM/DQoNClNlZW1zIHNvLCB5ZXMuDQoN ClRoaXMgaGFzIGJlZW4gbGlrZSB0aGlzIGZvciBhdCBsZWFzdCBzZXZlcmFsIHllYXJzIG5v dy4NCg0KV2hhdCB5b3UgY2FuIGRvIGlzIHRvIGNvbmZpZ3VyZSB0aGUga2VybmVsIHRvIGV4 Y2x1ZGUgdGhlIFhlbiBwbGF0Zm9ybSBQQ0kNCmRldmljZSAoQ09ORklHX1hFTl9QVkhWTV9H VUVTVD1uKS4NCg0KDQpKdWVyZ2VuDQo= --------------cjd2b7oUonfOwrhy1dlPiUfP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------cjd2b7oUonfOwrhy1dlPiUfP-- --------------dsfviep0ZNxgC3wnR9IF0PBk-- --------------03hIooiG2e5DB35vNVoqR7Vu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpy9hEFAwAAAAAACgkQsN6d1ii/Ey+o lwf/ZILi9GqY0ASMTn4+F5mdqH6HoBgZNN8A+OfdA1+17y9CliPpJyiKtL0udlK3bOKxohVmIfKZ Q3uWtADSqNY510idPN+fWMd9jpZjBEPmTJsGuArUx+i848GfvSm3A260oIhf2U15Pu7s/BGXjAiO renbxyOoIRaXJkXnrokmXMfs64bRolirMHBWDyO+sVdmXeM2hze9HJzXg3eDy27YOqcNAj3mZg6H q/2lTFRIu3P5RouIyhB7KoA7Ct1uqLuaiPL8cGNnxGI4TKrXiOSG4+PHi4xaYBB4BLRZ9GLgamSh XbOVOZSEJZ0m6en6Pys6Y+uZBPbg1uc4x2gr35dFPw== =Hyf+ -----END PGP SIGNATURE----- --------------03hIooiG2e5DB35vNVoqR7Vu-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:37:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:37:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383016.1626269 (Exim 4.92) (envelope-from ) id 1wrX86-0007z5-7g; Wed, 05 Aug 2026 08:37:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383016.1626269; Wed, 05 Aug 2026 08:37:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrX86-0007yy-5A; Wed, 05 Aug 2026 08:37:38 +0000 Received: by outflank-mailman (input) for mailman id 1383016; Wed, 05 Aug 2026 08:37:36 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrX84-0007xU-1Y for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:37:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrX83-00BHWz-E2 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:37:35 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f647-e002-0a2a0a5209dd-0a2a4502e3b8-34 for ; Wed, 05 Aug 2026 10:37:35 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f64f-6ca4-0a2a45020019-d155802fbcf7-3 for ; Wed, 05 Aug 2026 10:37:35 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so5468145e9.0 for ; Wed, 05 Aug 2026 01:37:35 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb0c5sm142089105e9.4.2026.08.05.01.37.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:37:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785919055; x=1786523855; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=paXBUFX35ESCakqZniHvS5VX9ri+1pb6qV9fxpbxAvA=; b=WDoPQLN71qNMTw3HQM1k8wrovR2z8Ny6b4chreQid9+xz0q/M9sp7Pf6U5By8jDa5k GMbqyj/G2YhlQdN58bXd5G1KrHORRMUqUArEIs2o35vxqvkGDCAriOkhS6qu/1CwOVnc 8XgmEnXKtzFNoCDQFNfzroBTme1MjLZpx/b8XErpSdDfz5vYfA7o1QVT1lorV+TRf43Q TQKDJaW9n8SNljpfekr/BfQmWrgFkDl4ufOe+ErLRFnAmvFSAbJ3ns6pBS7kJlrFm+Of 6YPwAUtQIzwcyy/bg1NSC47BzZjDCpTyX3ZibIbb/Q22HuL29QIrfsxGsdkwQ5eALzNd x6rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785919055; x=1786523855; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=paXBUFX35ESCakqZniHvS5VX9ri+1pb6qV9fxpbxAvA=; b=WQOQlklx7bYAMf/FcVQ1phi5uOPUhEKu+iwJhdvQuwgp78FijHcrEqb4f/NvxDD9i8 L0LovVyoXA9emR2MoGhVijCwiIEWf/yS2qF6lygLgKJHu3mZYU3UEKhFn9jtqF61ixtF u1NejSykxXG0o4TnhG7erZeZr2o/SdS+3qNUTSh/oEnq0TuEnGgHR+OjLFQcVjYRIROu BuNyvBaBKGtKDJNSvH/m9+R75mW+1bFWac4qu6hKSks39y3Oa/mzftiMUjrwQu4NW+e0 uBNma9N7rDdvV+HtcNcwmEhhZnCE0yKh/YRMv9dkOuCC2GQH4B9zchK9IBRqW8Fvkebj j8hA== X-Forwarded-Encrypted: i=1; AHgh+RoEKaOzhz0ZO7R5jitVPKpr9lUJ44ghCl/LUJCO11vetP5oyNXX9TGNC9gnFI+bup9v8CFqLxDb9+k=@lists.xenproject.org X-Gm-Message-State: AOJu0YzmobcZagVCtWLCKmGGwU2E5zQ+RDat8GZNOA/ajAGVn3CLcVs5 u4ko7EriXPW+qziub3887mDCEjKpKFMx+G6TMvCDm6Y2ATSvHRugf+XdTvD+WGHOkA== X-Gm-Gg: AR+sD10rBDBsElnvtFn/I2Z+UMqVanfa9QcOyqaInTgBTy2jUWVX0q2mBtAyOqGuyVT R9PT+V27LsPEqHXCYYqZBf854uwG/Q79m1Vu9ftVKXP8RM8qHibr26C2SWxaRODFN4XVt0qn4PB A9DANvxBAfmxhajwMAqxRedfdXTkUnJg/nkH70lnOTg89XZOjK2/hF8apDepGBTF0ulUnfh6b6a r9aISAo27iXql8JfJXK7zu9CW/kTNRRo+L3aDKoGPtun6lqcoCYO9+l7mbFTUthiYA4l+vYt572 sJj0XzAs10LDB6fUyVTpYFdhRdJIdvlrgbCTFWRzwDmMyTnwwgz1cyy6gBwp2gDD06Ils9btu6f C4M/G5n+43XV5ivRD7DVgz+gPYiRzxYJ5abGdmFbgadaBUQfx04NEJZGVc0iZ2EwxewqlvX4jfn bjsY/36eYeoA6Xf1yyJVLOdDHImZRSUGPdlIeoVYCaQqOtA6vCfaN4S54xsGCza9+XfVLZsr/pg 2hspXlsHBWOBUsyP8QJMJhkLNDclBzPuq6g08Bh2cZMwHESmL0RZ58rF8V+pwc= X-Received: by 2002:a05:600c:8b35:b0:493:c634:952 with SMTP id 5b1f17b1804b1-4994e79e668mr52852615e9.7.1785919054873; Wed, 05 Aug 2026 01:37:34 -0700 (PDT) Message-ID: <08441834-6087-4cfe-8d56-ba660564384e@suse.com> Date: Wed, 5 Aug 2026 10:37:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] x86/xen: Remove redundant config dependency on X86_LOCAL_APIC To: Juergen Gross Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-2-jgross@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805082137.1214967-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1785919055-F38BC2AC-E256C409/0/0 X-purgate-type: clean X-purgate-size: 406 On 05.08.2026 10:21, Juergen Gross wrote: > CONFIG_XEN depends on CONFIG_X86_LOCAL_APIC already, so the dependency > of CONFIG_XEN_PVHVM on CONFIG_X86_LOCAL_APIC can be dropped. > > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich I've been noticing this every once in a while, but it never felt quite important enough to make a patch, sorry. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:40:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:40:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383024.1626280 (Exim 4.92) (envelope-from ) id 1wrXAX-0001Io-Li; Wed, 05 Aug 2026 08:40:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383024.1626280; Wed, 05 Aug 2026 08:40:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXAX-0001Ih-H2; Wed, 05 Aug 2026 08:40:09 +0000 Received: by outflank-mailman (input) for mailman id 1383024; Wed, 05 Aug 2026 08:40:08 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXAW-0001Ia-O3 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:40:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXAU-00EDlS-Ud for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:40:06 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f6e4-5cb7-0a2a0a5109dd-0a2a450a8f22-12 for ; Wed, 05 Aug 2026 10:40:06 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f6e6-f2d2-0a2a450a0019-d155802eddcc-3 for ; Wed, 05 Aug 2026 10:40:06 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49802c418b5so6480415e9.1 for ; Wed, 05 Aug 2026 01:40:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e04c2a1sm73635405e9.14.2026.08.05.01.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:40:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785919206; x=1786524006; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jA5HpDKU3mE94gRzH25Q1Upi+BYpu+RmxlAHFb4abds=; b=cyv7L5cS6mKU22GIR2JWZ8UDuGiFX3CaDLNKUZG0zTJ8yjHrD/O7AjKs4GYG89cfKy vI8RNjPRqVniu8xpUJAy5HTlejRx0ty4pbcLLhhwCZVZKBEMBYcW17+jwo2R2RhR7f3M SCMBwT/gyhfPY4dhZnhv+1tKOc/B1xA1Y3fBhn17DFyqNYneC2ItN9MEHtKfs4UpnUtc 9UciQhvEke5QJu/V4Ii7CcgN21DJkFUbfrm4twkFhGSOqlBJqsO/CQwm8cX3T3Z/LB7j Ufkymgf+eEMkTy3dgHwbPdqFBmkQkYMFNg/Bt6lc1uW3nfeCsWRFiMs38tYC8P6pEdAl kPHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785919206; x=1786524006; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=jA5HpDKU3mE94gRzH25Q1Upi+BYpu+RmxlAHFb4abds=; b=f7UpKW/5VG7ksQ14FAjuS+6f7NrjR+lnFlSSLIWDYd0j8sWfrKTe+IgwvKMhr9unPQ s7IO6xqBW0Z7uMKIjmpG1HQ8VG+CaQLKoJIBzj//ziYDRWUfdYJSf0cah6Dv84BVE8h4 Tchm2roVgOldKSSxZI7QWF8VvGqAakHxBvZb3EECo0cSrSAoyxt4GsIivnsPMXW76HgN wqp7Jb0Khs6Ht+oi4DuG36yT3Sxyw1PuFVGtbt5XRxb75HT2cJI9H3YL5wZ+G0MetX1A OSXFgznO1MEQlo3zfFO09UY2FcLkBEPLngZ/f2nGuV9AcrC4xDeryIg4kJ6OwRfTxTKy ruTg== X-Forwarded-Encrypted: i=1; AHgh+Rrj/po9QEjOpHd6WoZvNn1+fLz83rvaR95Ftwtmz0kUbtImpr+wbBpm4CayC5gOiFek0iMF7XkA8/c=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx+cpvUGWsvmmouwWnnovTLSMi3Cmt1REIobt4j/ZDo6ANqxpAZ Rn++WIbL3TM0HUyEuQl4mExj+0VsgYnHRV81CuCvbcWnPgzw43k6jssI194mwZnlbA== X-Gm-Gg: AR+sD13E5FdnD7EBbHTZd89LDWyFe0p/d5u42jBO/xvkR7mfQnTFA/eu1hVBhMcIms+ yY4BXM8Wed+smjhZbbbYbkfkDzgPrnxe7Tdf7HW0TQRWez+/h8RY8Eky4XN4AzFi04J+qZRsmmB uF3NOAsRh+r/vR8xZZLdIfeEkX/ccOy5Iy5gm/0eF+UqqWAwPFhSFXcUVZYAQG4aPh4Z8NOHsWB fXTbUe3J3t7xQxgFp+qL62MVtqXwd7r0LFQvlYMzW7UH+GGl11RyT09vxjUQ3Y1EhByoRmlzD/q 0J/XjOzQbKudKmWko7XTZbeALPDAelCHN+2bvia3TgJBbI5cYUTr3DjimbY2/edTNESMZGnbbnr Oci5X2JNy2NlT1w8ry6g0Yiio3nfGqJVRmqm6R/dGfRIJEZ4B/KHbMlIITOiju/KgfqnLghtcEm BOT6OA6BQzPTOmazbHsxWJvtstBGiGJGdW63bnIgniXmWHpK9w+n1wN9o0YzSTSzXZLVWRw0WI+ t1/8fmmPTOg5t6l+95Qz6kqRiG209NGRCTuIwgVaXX17jcntjrk X-Received: by 2002:a05:600c:1d0a:b0:495:78af:78e5 with SMTP id 5b1f17b1804b1-4994e70de03mr55446075e9.1.1785919206212; Wed, 05 Aug 2026 01:40:06 -0700 (PDT) Message-ID: <5e7d500e-7403-4a64-8e4d-50f1031716ba@suse.com> Date: Wed, 5 Aug 2026 10:40:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] x86/xen: Remove redundant config dependency on X86_LOCAL_APIC From: Jan Beulich To: Juergen Gross Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-2-jgross@suse.com> <08441834-6087-4cfe-8d56-ba660564384e@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <08441834-6087-4cfe-8d56-ba660564384e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1785919206-4ABD8CFC-B6B09FA4/0/0 X-purgate-type: clean X-purgate-size: 478 On 05.08.2026 10:37, Jan Beulich wrote: > On 05.08.2026 10:21, Juergen Gross wrote: >> CONFIG_XEN depends on CONFIG_X86_LOCAL_APIC already, so the dependency >> of CONFIG_XEN_PVHVM on CONFIG_X86_LOCAL_APIC can be dropped. >> >> Signed-off-by: Juergen Gross > > Reviewed-by: Jan Beulich Hmm, looking at patch 2 I wonder: Isn't it XEN's dependency which wants dropping? XEN_PV shouldn't require X86_LOCAL_APIC, should it? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:42:36 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:42:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383033.1626288 (Exim 4.92) (envelope-from ) id 1wrXCp-0001uk-5Z; Wed, 05 Aug 2026 08:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383033.1626288; Wed, 05 Aug 2026 08:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXCp-0001ud-2r; Wed, 05 Aug 2026 08:42:31 +0000 Received: by outflank-mailman (input) for mailman id 1383033; Wed, 05 Aug 2026 08:42:30 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXCo-0001uX-0I for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:42:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXCn-00BIZw-DI for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:42:29 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f76b-2eae-0a2a0a5409dd-0a2a450ae862-48 for ; Wed, 05 Aug 2026 10:42:29 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f775-f2d2-0a2a450a0019-d155dd31b8f2-3 for ; Wed, 05 Aug 2026 10:42:29 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47362928f65so584672f8f.2 for ; Wed, 05 Aug 2026 01:42:29 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfe5bb9sm7083286f8f.10.2026.08.05.01.42.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:42:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785919349; x=1786524149; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mHvHXoMiEfHV0d3+ZZnPlHNwbEsyLi1F3w1mF+3Pqnk=; b=WsGS3itvdN8PGg1HAxbcRaENlDP2zDhNXFZCh67pqro9Zpq4S+o166H+VdlAT5JVmc e269PZ36ide8Fgcg0tUcsZdSv+TlTFzLCFn/So6RAI3Ijn8/lfLp/FPscXZtmFs6tYW1 2u3DtTYIwpm1p0AkOt2BQBfr44GP+KtOEp89ybFBzNlfw3VtJZN67hOSwgL6A62K9uqK +/HGSkrl4J9UiaASAflsQQeE+EqvueOMwpS1dLeL/ha8j/gWbcHwYPMkCyVXiFAVq7wy 5Jb6vjSYEcEfjivgtZE5L2Ycev9Ce5h7qlO/JbeiWi0I+dXAfAdn+p+Uhq5D0DCxdrcG 2xBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785919349; x=1786524149; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mHvHXoMiEfHV0d3+ZZnPlHNwbEsyLi1F3w1mF+3Pqnk=; b=WeMK4XG56yVYdseDhm6pM35xPd/B4yqP8ugCSSdHzB8ZVXlwpA6dX3Rdwj/Lzk9+5P Qno+MfpDcmost450ChJufiUOy5HhdFxcWl9slRlG9UlTAXJvGuQSonwJ/dRxt3MTnov2 OLt4njj/a44zK9H5tPdKB1s5Q785el1n/xfNquV/qYTv8og29e/+fj8QzdIO3uR6BfAW yh0n3XIjfpy7RhsdTQ7O37aE/k6+P/qEA2SeP2IOXUXo+cU7pH6u5aZqlDRHRcNru+1H YU6AKbu6iTLSZSalN8pQ4DVsl7Ue1kauQLtXHQHVgWvVZFJdTLDjmTTY4ThP1+d3nr8e 5dKQ== X-Forwarded-Encrypted: i=1; AHgh+Rpd31sxX4hh59ztyDjvS+sZS2QQBfxsOE0V8yWkCY1S01u8oBSBU12uGDn03MaWfplKKhU6YwIp8FU=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx3cn8ZQ6RMgpczBfDb7muKYUnjJ1k1f2WS6iTHtob1xYiuRah6 6YVkc6NEsOGHlnLKmkfWhJT3i6kqamyQxAeS610V27CCK3CcAjUqE96YRdGsVdUEyQ== X-Gm-Gg: AR+sD102sXZ+0OnTLMEn38MTQTbdxyu98gYhTIRPOHlyxJ61cqjMikCLbV75pk2sreH xXCLtnw3Cxq204zFg0WudkqBVcuUj557fJNhVffXBeJBJblCUOc/A3ZQ11IGbg5k19vIyvoPni4 0Dswn2Y3fsM5IWO2id3kVLEPbUN+0icj5wgjVF6FBN7043vWwU1stdQ3w3MHhMUOow5J7hRKhXd ZeYyHYjrcCSs+DjMZ78Swl/93LaFa1ygqOLpo7iGQO+SU67BeiHB62j0hI7VSlRkds23hwA98Tr QaRgq/33qNX/o3qfQHSW1q+KcKjFwJP4M5jp1BDpQ4CTV+pGKX+qQgXY+RKDX3ogrCqnKvTc9mX uao7N7Lj/C6CGRIeaftVGVzlKtzQDZOwE2FpEJWYH0i18vs5OslaO0DZEjWLEgeV0ztCx6bxUnU vjqIQXEPnr/+ebgiNRZby7VsDAolXINtxD0xetL1v2821u2x85TuO7rXpBIvLjsllNqavJwxtuH ASCkOsIFdwiC7q97qLwHJZ6PAKl/9mPGL8IdsIxjla+zDxIESwU X-Received: by 2002:a05:6000:2c0d:b0:47f:6f9e:1e82 with SMTP id ffacd0b85a97d-47fec4f11cbmr8645151f8f.9.1785919348735; Wed, 05 Aug 2026 01:42:28 -0700 (PDT) Message-ID: <4ca560cd-c43b-4893-bec6-800a33cd1bb7@suse.com> Date: Wed, 5 Aug 2026 10:42:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] xen: Drop CONFIG_XEN_AUTO_XLATE To: Juergen Gross Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-4-jgross@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805082137.1214967-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1785919349-50ECACFC-25EEF3BC/0/0 X-purgate-type: clean X-purgate-size: 366 On 05.08.2026 10:21, Juergen Gross wrote: > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -309,12 +309,6 @@ config XEN_EFI > def_bool y > depends on (ARM || ARM64 || X86_64) && EFI > > -config XEN_AUTO_XLATE > - def_bool y > - depends on ARM || ARM64 || X86 Yet is/was X86 correct here? Shouldn't that exclude PV-only configs? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:43:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:43:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383039.1626298 (Exim 4.92) (envelope-from ) id 1wrXDi-0002Mp-GE; Wed, 05 Aug 2026 08:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383039.1626298; Wed, 05 Aug 2026 08:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXDi-0002Mi-Ay; Wed, 05 Aug 2026 08:43:26 +0000 Received: by outflank-mailman (input) for mailman id 1383039; Wed, 05 Aug 2026 08:43:24 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXDg-0002MN-Dx for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:43:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXDf-008yvM-Qv for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:43:23 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f7a8-5cb7-0a2a0a5109dd-0a2a450a81c8-4 for ; Wed, 05 Aug 2026 10:43:23 +0200 Received: from [52.101.48.69] (helo=MW6PR02CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f7a9-f2d2-0a2a450a0019-3465304536bf-3 for ; Wed, 05 Aug 2026 10:43:23 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by SAWPR03MB989599.namprd03.prod.outlook.com (2603:10b6:806:55c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Wed, 5 Aug 2026 08:43:19 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Wed, 5 Aug 2026 08:43:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EvVsttTWUj647XbRZLCHNglDPkLrMD2EzpTCINOJ7HDD0wkdBsIrdZL4TT/ogCUKnp7oqtL4mhX3YS5HpCH9JGq0+eYDxnJkIbqCYBfxbWZ78AZsUEegLOeWc3c9JEqtk553iJWAdYnKsfWcLahlLW7Xz+E0p02ve1ThdvutI6W+G9dPdAwhdoUdv+d1eTHKeo7GcLNLVnk4ZtP7L680yr8KNUPg1pr32sZSkIUppKzX4/zlPDRPUNr4imyJ+2E/Mq9NKKgqTckWx6dA9M+6mNUfPWMWgpn6bU1PZDt1olk+qWAzcdKq198EwB84wxlkY5ZzSxyNfaOWTmGO6YgBYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j/RvCbaRfhs5kTs2/OCvfUueUwM9lcgQflO749DQY4Q=; b=cjY5nTsu4OBFZRuRIeORPXYKet3ZhKPcJsFn6or8Vhojn05iRGpTU2p7KMFra1xClCXqEvuPAmyIwL1OViu7qb8xmX0xQrrUZaD4GhlZjUAJQi0oHWwAFLthJTez1pvJ4cK5b+aQNlG7CZ4SvjNHRMokrNarIraX0f2ZaBC40DLLhJ12pQ5KKW0iyZlx+zoX3xTI1kHceFYzWxbdewg7XB/5XI/FSz86t3I3lKxlIy9f5zxgo9dzqcqAN+SExstZXI4LzyeusKlz2hkv0B9JekAG5QwpaUdrM8jlTnQST3OySNLMlvwwuxuq4ipXnEEHP8b4g5GYDO5SwNpPykyEyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j/RvCbaRfhs5kTs2/OCvfUueUwM9lcgQflO749DQY4Q=; b=sHR/ZhOMgnkuV0u4iAjwUW/j+xDmFEg0s3MVxRYOOOOnQsKd4KPxwll6i0ZbSD60YTHlMM3rCGHGRvtkvdavq3giPsWcADN0qhPIbIJcl1tX63QTuO32J64kCQ2laUpnt8nATmtYk6WwWU2zoGGJUz0bOW9sUZud490XA0L9/0o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 5 Aug 2026 09:43:15 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 1/4] x86/xen: Remove redundant config dependency on X86_LOCAL_APIC To: Jan Beulich , Juergen Gross References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-2-jgross@suse.com> <08441834-6087-4cfe-8d56-ba660564384e@suse.com> <5e7d500e-7403-4a64-8e4d-50f1031716ba@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <5e7d500e-7403-4a64-8e4d-50f1031716ba@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0180.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::23) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|SAWPR03MB989599:EE_ X-MS-Office365-Filtering-Correlation-Id: 22eff28a-ad6d-4997-c5d1-08def2cd998b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|366016|376014|1800799024|56012099006|10067099003|4143699003|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: soc8V89rktikwsKPTbEUOLSSI/WTVsJGX8KJcQzxEEbrJqBWhPPH9rL5H6BSL1+HxNw2CLAANoFcLgFYZi17Px4jHaBDNTIFjNHo5dgtFBZVbHMDkKWkGTu/HOzodRg6s71DeJsc5/UTS9Vuxozjgz9FZZ+K0yQlWS5wzuRuagsz42RtuODl0JSD8XCWXx5J06DxAgeTLQbFrhsYKT5zrWIvyGLJdoUcW2QXs4rZy/V2K0XIfq3jJm7sPhHKoXxpPk5Az33uuK2Icy/vN6faiAkQeknyBwKI0sE2x9sS999CrF92vsZl5w3V+/zcA6k2jY+YL3uqEBwh1rqUl4auSI67tbmg40o7uLnjDQGTtG8iiUXgJZMWdoOPcuZqv9fw09N+IDn8wPBUqR78CpOdwtiEXg/bNoPqPuPODrGp3SNFtYsOJ4UMwzO5ea5yrEReHn2acwtdRJU7FZY55kpVYAl48KNg+3yIGYYrkvksyV3ugLORfC56toLhARllWR92hmRp7dPNOKEFMaKKpC52ihS56VoughO1aNqfQ62CXe0K28EqwFWGxeiYkX331WoqVrfXG34X9Bz/swtbm71ov1WYcR2G7HBEWHOK4JGfhfcfThmER/f3pT53m5OzlE/TZyMqESJJp9StafEeknNodg3OwopD05K9MMPaETz6B4U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(366016)(376014)(1800799024)(56012099006)(10067099003)(4143699003)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXRQZXcrRFlDdWE4TXlOT1I2dTk0SGdBVTdrclFlREJmODQzSjRHUnJJNStR?= =?utf-8?B?S0YwUnpXRmdGWU5uTkVjZXB1MEkva3VTcXdhNSt2Wm5JcDlGVDUyN00vUUM2?= =?utf-8?B?c2V1ZVpTeVVCdEM0SlgyM1NvQXNmOU1IUXJsNTh3Q1FVSUx2YUlENEpNb2Jm?= =?utf-8?B?SG53bm9ONmtHVDdDQUwrdndYZjdWdlhZS3F0UlRkSFpwaWUrWkQ5cjdwL3lG?= =?utf-8?B?L3E4ZzhHT3p4VE9vaXl6T1lobnRndlVTOTQ0dWlzU0xhQmlrb1pFWUk0SWpy?= =?utf-8?B?VzdRT2hnZkxNVW5SUGozclcvdzNFWnhQZTFDZ3JvdG1yZ3NnMCtLN1JDTjRy?= =?utf-8?B?QVBFQlc0clF2WHJOaTIyczYrVVAxSjA0T25EWm9vWWNMSkFhU0Z3eFRlUDY5?= =?utf-8?B?M1lDQy9TYjV6R01hc2NScmRvbEtBSzJ3TVNjK3RCSS9mT2dRcCtXN3B1c1dJ?= =?utf-8?B?QVh0MGJISWl1TXhId1hvdUpXNmJkYkVkaE9OMW1JLzdGUHBJT2ZtRGJENnFi?= =?utf-8?B?YjVoQVpGbVMwaDYyNmtOMTk2LzQyR3R2cmk1bzRydDZ3bmthdGlBTCtLOVdH?= =?utf-8?B?WVErelRvVWRqd21nbC96bnEvZENGNVhkTXBCYzBzZGNyaVVueHlsbHJ3RXhQ?= =?utf-8?B?b2FyWEpMd1NqdTY2bFdoeUZOT2JJSG13TzRWSFZPenBvWkU4WDZidURyeXZy?= =?utf-8?B?bFJKV0VaRktSU2d1dFlLODJNT0FrZDdJVkNnckZaUHRneHgweWd2NlNqeTUy?= =?utf-8?B?OTZOZ2o4UDJaUWI0R0xLYThJdU5LN2ZDM3lSQnJoeVJXOWRuNEx0YkdLSmYx?= =?utf-8?B?Y2RrdUF3OGlnb05ZN3pLS1BrSGU3K2x3bXAyVWtBbk15SktlNS93eWhvenpi?= =?utf-8?B?dGl0NVBDVzRCTnI3SHRJNk5uVTNheVZzb2pEa3ZQVFlXMDF2OU9hV1FsOFNR?= =?utf-8?B?U1dLNExPZk45ZE5NQlFZOURRSFdGbGcwalNlaG1lUytkaEk3RU5KVFlXNkNV?= =?utf-8?B?Zm9OOHFlQ05ya1lpd1c5a3hMMGJBci9mcGtyL1RSRjVPd1BWWmNOS3VkUHdp?= =?utf-8?B?Y0liUUI4WFFoV0Y3bW9QOVhEUU5jSWptRW55ZGlDRnE5cktFUkNkWHpWWEZQ?= =?utf-8?B?RzNLa0NiTjFCSGdZSUh2d1lzak00UGJBYkZ0MXJHNW42a29UckxRUUs4bFdo?= =?utf-8?B?cGJCb0MxVVZFVW5BOXJ6QmsrK1Q0N3Q5cGY2TWE0UFFPTHRISDF2cTVhWkhS?= =?utf-8?B?am52Z1JtRDdzd3NESC8yVHVpbEhzZnBtMXZaeXVMZ1NINVBIMnovcXowVCtq?= =?utf-8?B?b2tkV0FXV2loUXNNRjNCNGVlZ0ZLb0JNR0ozMjcrUXZNL25LV3dVTEExYXJU?= =?utf-8?B?dmNzc1loTlhRT0FGMHFPbmhLL0xubTJoQytseElzb1NRaWt1WGJ5TDl6bnIy?= =?utf-8?B?U1pvWUNFaHZ2cW1tOEFEbVdlTUdWanUrRnFaTjNlWVRpNisxejJIN2NwYU1I?= =?utf-8?B?Y0QyL1Exck1GaDZWT0o2TEJzTDdnbzV3YlBFV09xcnBYQnErbTZTVGNPaVZu?= =?utf-8?B?RUJFU3NSNXdPbG8vdktOUzF1YnNHRlA2TWhCOURRK3pEQ1VUdC9YOWVRMmw3?= =?utf-8?B?K1NtaVF4VmoyMS9SbTlvdGtSZytiTDJmVUQ3NEJBMHRwRUFZOGRZM3dQdFlo?= =?utf-8?B?MThaUGgvckp4eVlDd3J3UUw1cXp6Q01NOTFxbkppejJvcWV6MVJ1VVkzb0xq?= =?utf-8?B?bmJzdGlVdkdWWWtsUkdhS3ZoaWxmY3dHNGRZT3FlcmczR2E1SDEvenJEd1Rk?= =?utf-8?B?aTNVZ3dSd255STVwVmlVYlpxY1ZMc2N6ejZBWjRZT2szQmw3WjJ5N1p0WTF3?= =?utf-8?B?dnFHMzNEd0lQUk5wSitsSmlmd0l2UTNEM25Ob1VUdlZNdjlhbWpGaUZQSC80?= =?utf-8?B?UjdHbDlVNTJHdTh1TitMZFVLTlNsUEFmRkNub3JUQklEaVI4Vk1ZYnpzZXdO?= =?utf-8?B?aHYzZ3hyNVhGdUFYMHlHbERESW1qSWNYV3pyTUo5MCtoWnM4Z3ZvUUFtbncz?= =?utf-8?B?bEZPZjdsOFRsM25PUzBMR0tMSzlTVHpSOWtOaHpvN1FhdzNMbUZLZmdtSHVK?= =?utf-8?B?TzZnV3o4NEYyZTYybmdiOEY3STg1eHhWSVl1UDNVZWhGY1JBT2J2SGpXUUxV?= =?utf-8?B?UmV2clhUUTB1MUpoSEVPQ0VlWHg1V0J5bWRWeFNtcWxHTjFlY0podjkzWC9E?= =?utf-8?B?R0NKejZTSit1d3pZOGt1M0VTQ1hNYzh6aDZYVDBpckJzQnhXMTg3cXlWVGpo?= =?utf-8?B?S0xicGpBamJuV3RLbEFGTHFsZllIVm1SdFA4MTF5V21KWVI0OC9LR2hxQ1RB?= =?utf-8?Q?jx5IffTO09Hbljwk=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22eff28a-ad6d-4997-c5d1-08def2cd998b X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 08:43:19.3057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oDeE5ScGhUy9wWrt/c2uWei42siiV+NNsyNpZyYlABt34lerARRDwSQwbigAsItyeTG5lCAdfiEAvnaa+itu0rIiWIRuE47wTRx0sZcZJEg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SAWPR03MB989599 X-purgate-ID: tlsNG-4011c0/1785919403-4BED2CFC-F23D01E6/0/0 X-purgate-type: clean X-purgate-size: 765 On 05/08/2026 9:40 am, Jan Beulich wrote: > On 05.08.2026 10:37, Jan Beulich wrote: >> On 05.08.2026 10:21, Juergen Gross wrote: >>> CONFIG_XEN depends on CONFIG_X86_LOCAL_APIC already, so the dependency >>> of CONFIG_XEN_PVHVM on CONFIG_X86_LOCAL_APIC can be dropped. >>> >>> Signed-off-by: Juergen Gross >> Reviewed-by: Jan Beulich > Hmm, looking at patch 2 I wonder: Isn't it XEN's dependency which wants > dropping? XEN_PV shouldn't require X86_LOCAL_APIC, should it? In Linux terms, XEN_PV does need X86_LOCAL_APIC. While the PV guest doesn't have an APIC directly, other areas (parsing the ACPI tables, configuring device interrupts) require Linux to think it's on a normal APIC-like system. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:44:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:44:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383046.1626305 (Exim 4.92) (envelope-from ) id 1wrXER-0002uR-Le; Wed, 05 Aug 2026 08:44:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383046.1626305; Wed, 05 Aug 2026 08:44:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXER-0002uK-Ik; Wed, 05 Aug 2026 08:44:11 +0000 Received: by outflank-mailman (input) for mailman id 1383046; Wed, 05 Aug 2026 08:44:09 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXEP-0002t1-So for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:44:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXEP-008z9Q-9e for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:44:09 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f7d1-bab6-0a2a0a5309dd-0a2a4504de10-14 for ; Wed, 05 Aug 2026 10:44:09 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f7d6-b57f-0a2a45040019-d1558030dc52-3 for ; Wed, 05 Aug 2026 10:44:06 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4954afac04bso7361125e9.0 for ; Wed, 05 Aug 2026 01:44:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a0f7bf4sm162465895e9.11.2026.08.05.01.44.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:44:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785919446; x=1786524246; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=P9r862YZOyOGjhCsS+AtVypyNoqeUq1wkQoy8TnKSRE=; b=cklmco0fPAljN8a1UZG4uJl68sB3k507e+FWImXeGmxBn00zEohwt0nfgtHamxesHE ojeWDsWjOsH2V3+dpF/F3aWF+CmGGFvcbcjpWULutI+EbyxWramQZV3AJGfeaK4litl7 AunN0+iD1g3M7l1Gl2Men4Jzzuc9uQ/YSigthBI+sxxSND0cC0hWZ9ay3UACCe/ClOnS Lz2Ao2KtHcSnfaN1lXYWN5t8o0ZqWRLEtDfvxpappn/hhrABDK1/8iJcPUaCMlpmzoPb 9DA7AZhvIAmLLClf/62k657Z6aZgXtVim+jJTxX3Ml1yMzTathfpXFF4eER6Svaot7OK 8Rdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785919446; x=1786524246; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P9r862YZOyOGjhCsS+AtVypyNoqeUq1wkQoy8TnKSRE=; b=a2O7edOEJRXOH8YEglCJ3513Shs9Nrp7u56gbCY3G+dfx19NRZUGgd9t2BD3Ak1RF1 ZTtKyKtojX4xPAUxAwfDPXQTbdp+TprKomgjy48Ng4RzztJDioi2KLvBgVkNFUG5RajH gr/WvgyPV/i5DTKIR3tGbIGQMaO57qAVLSGsFPReC8IcKmJ3rJG825PZbxe2E3vuYXg6 vaoR0yWZ/ezaXCdjXVInaqmBC2ChYJOSXl0MWewnJM2TC+aNni8UePeB1z3I993rmUa8 umD2Gc+0Ab3ll7rgnixmbZzKfMZjP0XmeT+/JE/7Eoir3KyUU6EBulVfU3ksqyAe6BQY R1Lg== X-Forwarded-Encrypted: i=1; AHgh+RrpwKvD3UleDzIZHCR6TN7xu57VJMdU6c5gzLWbrwEpPbjJOM0zBuU66FZNspF+uKBNo5zXHX8uMB8=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw3eDx8CtSdMaDs5bHYfLNO0MEGvsaPD3XQq9K8l1OfCjU1ssML hioUube77aHur8g0hGhOYI6lDzozeFnDy0lOWcDoZinuosJ/6IeGtgBW3c/1qiO4Ew== X-Gm-Gg: AR+sD11kY2KJDiT161SUSF32iDuLEaorvbbDw/YDn7ZO17KokZs5f40tzx0/CbDhXcM WQTJ7iQGFCSaetZWUbiqE/zpThGEiQww9w1jqE24xB/K26eO558o2o6CUJuFntQBbKae6YgCjib 9EDH+D0h+m67wbExW2ZNgvjV+LJ71zwgDUH8+PJeVI4hPffa6KSFEl+JorwCLxBX8qtjiU+KYKm epl5HfM3gbmyN1lfStMNXKRs5tNqjAHSCKP1UIqU3u7KU8hDvldV+wSbW9Kp1VHdKwrQf/2eulZ mtIRKrCYhviYp7SMTsqQrr7fo7x3edE9PEE4o0WF5NVe7ukNHwE5TL05+4DGSIvhukSOXthGPF7 K7K1+5JTvYk1Dhr1bJIJEft9RSitlxZPXwsmtpfPJQ9Asq4vUcTh8/NyX0+NksMaypor2Nt2QQf +7z50QIiwAVhFF5eblqPh6+KrKLL/nL2VlQvceNrxYgXgcfYijTC9+ltdWf0XNX2T9U2koINSNv bIyGYYoA5Ts0y0bWlSoIaEYWYzhopSjMkHSIT+2RmI0Ja+16yxl X-Received: by 2002:a05:600c:8b23:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-4994e7bb12dmr49451095e9.12.1785919446376; Wed, 05 Aug 2026 01:44:06 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 10:44:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP To: Juergen Gross Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805082137.1214967-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1785919446-C1ED6B50-E9AD63C3/0/0 X-purgate-type: clean X-purgate-size: 476 On 05.08.2026 10:21, Juergen Gross wrote: > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -37,8 +37,8 @@ obj-$(CONFIG_XEN_PVH) += enlighten_pvh.o > obj-$(CONFIG_EVENT_TRACING) += trace.o > > obj-$(CONFIG_SMP) += smp.o > +obj-$(CONFIG_SMP) += smp_hvm.o > obj-$(CONFIG_XEN_PV_SMP) += smp_pv.o > -obj-$(CONFIG_XEN_PVHVM_SMP) += smp_hvm.o Similar issue here - in a PV-only config smp_hvm.o doesn't want / shouldn't need building. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:47:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:47:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383053.1626314 (Exim 4.92) (envelope-from ) id 1wrXH9-0003Ye-1Z; Wed, 05 Aug 2026 08:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383053.1626314; Wed, 05 Aug 2026 08:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXH8-0003YX-VJ; Wed, 05 Aug 2026 08:46:58 +0000 Received: by outflank-mailman (input) for mailman id 1383053; Wed, 05 Aug 2026 08:46:58 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXH7-0003YR-Vo for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:46:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXH7-006QlE-8t for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:46:57 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72f877-bab6-0a2a0a5309dd-0a2a45038e04-48 for ; Wed, 05 Aug 2026 10:46:57 +0200 Received: from [209.85.221.46] (helo=mail-wr1-f46.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72f880-fae8-0a2a45030019-d155dd2ea416-3 for ; Wed, 05 Aug 2026 10:46:56 +0200 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47fde295992so578161f8f.0 for ; Wed, 05 Aug 2026 01:46:56 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfe5e85sm6963759f8f.14.2026.08.05.01.46.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:46:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785919616; x=1786524416; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9K2nghcFTEoUumQc+qv00dhERm+3wC5Gi0zPR+wU7p0=; b=RdP+6138DK3Y+tiUYh9roc/kYhroYANfewd/5RapZtnqVVZ8UQilgZZGMtbZrmTkG7 8o263Ed2iZqsDlBksFc5e/4vib8OpX7lSsvI2ZMeTgp2G94yJO/n+lVglE8PC14tlY8j u4ryZDyJZemW3daz7ZUjrOa2I2vvro09daqqgYTCkj9cZ++/UjvjW7qe2Yuz8gOQcJEj g+S+BH99QFGDgtu29m2TBYCcNv0cuPn0DiUYFHLM1RJK6tSi+SENPEQpBJMiBcevbc4I KZC1qTzopI2S+0daQKIdjGNOE/ptwBMYVFGnqqUbpty/7V05BK/k3rCi4Tfo/3dKWTL+ Rn/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785919616; x=1786524416; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9K2nghcFTEoUumQc+qv00dhERm+3wC5Gi0zPR+wU7p0=; b=A2LgVD2C351H1SHCMW89EiDNRvOr5Q59Y4xVzzL4y8JjKSYzRU2Fwb/Tj3bMVxlblz 4YUYoW4iy+F6uBYVb1+KfgA2W48OvdRqwmOIalSdjvQY9NI2CjvcTl1jP6v15mBePTi/ bCfG2EYHLcZWNTDyvAk3bwGYq/AZpdOk8ImfvjGCAIH1yZTyRlEVvjns59TOnW4RV/Fb 2ZtIaF7jJp8Q071eixCtrWWbd4fW1b88i38fzUR3a3M9Cx3IZjOeMsWplKVKV29hQLoS ph+bhLiLNjd0trM+Z9/MX5Ba36fYFG/cfTcHAWABf6lINOLc0PsQX53TlQs2L4U5wiJz UwgA== X-Forwarded-Encrypted: i=1; AHgh+Ro2RWAwbpThX3q+Exye57n2en8yHdNhiC8auLzv6sZDQBdFN4MoDfwrozQspRwpRC1mBDG9THu0wMY=@lists.xenproject.org X-Gm-Message-State: AOJu0YxfGLpmMwhe6qsnAKasTob7HUC2Jy2niXkiW5ulFaoKVlOATDXD xDKTFyfkowilR+d3hKhEK0GAJU84FR+V473zRBshdl0h54u5n/NukYqVtG2wXIV5jQ== X-Gm-Gg: AR+sD11s65pZln/MaSSCjWHUmwADzJcZ8rFL2ZOtSuaxFp1I7nvu0HpJDZHWQMy4ULi aAj86Nrc9jOmij3+n62dP8EDTLh+pM1+VW2qcUtGKl64L8c/w+dj3qVT1KaIXW0Q3CDXfb1MrYb W6zGWygGtQJI7Tny4pw3SAYxIGNAjlwVLFwz6/H4+LhXc0Vhgvur0JaSZBKhnxBlzP9zaBTcfsK +WozO8Zqgdxjj4TDqmThlmBXQPP08mcXrOEjcJtpJzP4eYqA6fBOpu7ax5MF4xGkZLNTOWgvljk CtUJO6F+Jq9bsUDrYXU+pCFKfRxLBD1rigWw2kDJd5GUC/yXE0ZPGtzegA0IK9VbqCmqQqbWzsX 2iHkaXWjA1tmIBxDyK6mcFErpYhUSfROvTIAsrqIJdkAdY0aPy7XlEE6dkF//kWY/0x4rkNDyDV 06Mys9zPA0LBa497MIY3EwS8/FicSW/Ex7Hpfq7nu5hwWxipqy17v8cQ/m/++AGhQJWA1NZ+TPa QkkrgdBVSBboAS6muMrTWftGsylYPPe3VCFGeCLgd9CjfIPZaAyjOKIahe9zsy1 X-Received: by 2002:a05:6000:2282:b0:47f:9158:5924 with SMTP id ffacd0b85a97d-47fec517023mr7487875f8f.9.1785919616177; Wed, 05 Aug 2026 01:46:56 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 10:46:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] x86/alternatives: Rework get_ideal_nops() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <20250522150015.555492-3-andrew.cooper3@citrix.com> <20260805075303.23105-1-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805075303.23105-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1785919616-776F34E9-7F2E92D1/0/0 X-purgate-type: clean X-purgate-size: 480 On 05.08.2026 09:53, Andrew Cooper wrote: > The {k8,p6}_nops[] arrays are both 80-byte structures indexing 45-byte > structures. Furthermore, perhaps unusually for C, the source layout is an > obvious hint about the triangular nature of the structure. > > Therefore, we can replace the pointer chase with some simple arithmetic. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:47:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:47:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383054.1626325 (Exim 4.92) (envelope-from ) id 1wrXHH-0003oI-Fd; Wed, 05 Aug 2026 08:47:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383054.1626325; Wed, 05 Aug 2026 08:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXHH-0003o8-AX; Wed, 05 Aug 2026 08:47:07 +0000 Received: by outflank-mailman (input) for mailman id 1383054; Wed, 05 Aug 2026 08:47:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXHG-0003nU-5P for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:47:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrXHE-006HEQ-0g; Wed, 05 Aug 2026 08:47:03 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wrXHD-00EwxE-1o; Wed, 05 Aug 2026 08:47:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=iNMWi0XtRBKOmYDv/Tp647cKGq+rA0jxZoCfmdFSxzg=; b=NJUzcebrvZ2GAaVE3sdR/cw3jG amx6gjPYPB8x1GFQdlD6blgf30WK4vhrJM7wwnk9y++g/YjLcVLOuMrlUnaqjiZjVE17Kd1+Aep8Y KS8UBxDvfc9Pm+N3pfcd+mVXJJbii6bb5cFfURvvdGSzF54f+eZppiv9E8Bx3iPVmaUE=; Date: Wed, 5 Aug 2026 10:43:29 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Matthias Goergens Cc: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Yannick Martin , Thorsten Leemhuis , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH] x86/xen: fix init of balloon stats for PV guests with memory != maxmem Message-ID: References: <20260730143548.39320-1-roger@xenproject.org> <20260805044607.2564210-1-matthias.goergens@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260805044607.2564210-1-matthias.goergens@gmail.com> On Wed, Aug 05, 2026 at 12:46:07PM +0800, Matthias Goergens wrote: > Hi Roger, > > thanks for picking this up, and Juergen, thanks for the quick review. Two > things I believe are still worth addressing; the Fixes: tag can of course > also be fixed up on application. > > I think the Fixes: tag should point to 0949c646d646 ("Partial revert > \"x86/xen: fix balloon target initialization for PVH dom0\""). Commit > 87af633689ce changed the initial-page calculation and the extra-region > subtraction together, so those two operations were coherent: the PV initial > count then came from get_num_physpages(), which includes the extra regions. > 0949c646d646 restored the PV start_info->nr_pages calculation, which > excludes the extra regions, but retained the subtraction. I've got the same doubts about which commit to reference in the Fixes tag. Here is my reasoning for picking the original bogus commit, and not the subsequent attempt at fixing it: Even if 87af633689ce was coherent in the usage of initial pages vs extra regions, it was still wrong, and that's why it was (partially) reverted. I assume that anyone who picks the change in this patch will also have picked 0949c646d646, otherwise they have a problem with how they do backports. > Its 6.12.y > backport is also the reporter's identified regression, first seen in > 6.12.75. Applying this patch in a tree that has 87af633689ce but not > 0949c646d646 (for example a 6.17-based distro tree) would double-account > the extra region. Why would someone apply this fix but not the preceding one? It makes no sense, you either pick backports consistently, or need to be very careful at knowing what to pick (and assume that sometimes stuff will break). > This likely also wants Cc: stable@vger.kernel.org, since > both 6.12.y and 6.18.y carry the 0949c646d646 regression. > > Separately, and not something this patch introduces: PVH dom0 has the same > shape of problem on mainline since b13cd24c15d7. A successful > XENMEM_current_reservation supplies current_pages for both PV and PVH dom0, > and that count excludes the unpopulated xen_extra_mem, so the > xen_pv_domain()-only branch leaves PVH dom0 subtracting those pages again > (-ERANGE, or a silently wrong target, when CONFIG_XEN_UNPOPULATED_ALLOC=n > leaves the regions for the balloon driver). I am happy to pursue that as > its own thread once this one lands. Hm, I see. Running a PVH dom0 without CONFIG_XEN_UNPOPULATED_ALLOC will be a very bad idea anyway, as the kernel would likely end up triggering an OOM as all pages would be ballooned out to create grant/foreign mappings. > Would it be safer to pass balloon_add_regions() an explicit indication of > whether the chosen initial-page count includes the extra physmap regions? > That would cover PV, PVH dom0, and the XENMEM_current_reservation fallback > without deriving the accounting rule solely from the domain type. On > hypercall failure PVH dom0 falls back to get_num_physpages(), which > includes the extra regions, so keying the accounting on the source of the > count keeps the fallback correct as well. Possibly, this has grown organically to accommodate for the lack of proper interface to do memory balloon accounting. I will send v2 attempting to take care of the PVH corner case and the error fallback. It's IMO best if we can get all the related fixes here in a single patch to backport. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:56:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:56:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383074.1626333 (Exim 4.92) (envelope-from ) id 1wrXPq-0006JX-5g; Wed, 05 Aug 2026 08:55:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383074.1626333; Wed, 05 Aug 2026 08:55:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXPq-0006JQ-2Q; Wed, 05 Aug 2026 08:55:58 +0000 Received: by outflank-mailman (input) for mailman id 1383074; Wed, 05 Aug 2026 08:55:56 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXPo-0006JJ-L9 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:55:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXPo-00BKzZ-1r for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:55:56 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72fa83-bab6-0a2a0a5309dd-0a2a4506cf2e-44 for ; Wed, 05 Aug 2026 10:55:55 +0200 Received: from [209.85.208.48] (helo=mail-ed1-f48.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72fa9b-195a-0a2a45060019-d155d030bd83-3 for ; Wed, 05 Aug 2026 10:55:55 +0200 Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6983f20a8bfso1163729a12.1 for ; Wed, 05 Aug 2026 01:55:55 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a166335dfbsm1118557a12.14.2026.08.05.01.55.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:55:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785920155; x=1786524955; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Ymuh0DcPl2Ots+UHLDeP+fBlqnU5QkdY5IPw7VnqIzk=; b=ZJRagDwMfDjEig5odpzlSC2iUk7DCuJihQLqODAvkSPcUZ3zw78qo7p6pYLAl2t/y7 kW6dt1edRcRaKRpxbOOWw9hMYf32I/qxjDmgayDxhXtNfEi/+qhbIIptd4AR5t6Rv/a+ FdJegkC7nz9KfSfPzNF7qTiUKdvaOCFZbO3WieIFOlzNAvUGzIEVYmL35RNmri3xhYOA oo+eS/3Qz5q2GMy/Z5Kei7PkunJZ1W7f3I1Hk5bYMsUDijjW1xbXCrgEiqOsInhlgA1Z tO4Mey+oZ8f0PeUKYC5+wwBo4EJ4/FlmgCsR5I+odaV60wmRMVEBn0oRiYpZRkcnf3i4 438w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785920155; x=1786524955; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ymuh0DcPl2Ots+UHLDeP+fBlqnU5QkdY5IPw7VnqIzk=; b=kGV2TKQdGkj3KC5lnyntRSVlt4YbyJ3PlV34k4enHNDyNilk3E7oq9cg2RFCeWQWmk RXFNGMli2eB61RrUKOjIr1SG9NoxZ/IBDo/ftnFMYdl1xq7iO+IJZj3jJcdPMK12p86D 4SxongwG6fe6ayWmKYHRSmxVeSX28tFQMEJSKL1w2rqeYU5zgV871FgMv8tFb327ZBCp e/61vB3Obw6Jf6sYVrlWwj/GpqDZmMZ1saY/a3vuSj7u5Vqf/cGJOXDL3wj/siyfudoh ITWTOqrFyHz3eYlRbssHh3HU7dWA1QUb39iVC23L24RZZIUgzHvktGza9yCh6EV7W6ab EgNw== X-Forwarded-Encrypted: i=1; AHgh+RovcqL1L1YCrHs7l3qYVP0h4t6AVmWFd64rBRnTx2x2xs2GeUZSqmXvjdOeX8UWtc6Mc4C9Cfk1xK8=@lists.xenproject.org X-Gm-Message-State: AOJu0YyGSnXa5ZeLRt8MjLURXGyh5yFuilA96O5WZMG9gPiQrY8mpGxo GoINcNIQsxf0kchCkP+adFsdL6LTytoZMrFR6s9LizvF5utfVI6OBLDCv/LhwM5WKDE= X-Gm-Gg: AR+sD13wgU6g6UHkv9UD0nknC3dWlprYnoV062KGlh8kODkj+QR3vosmIrhAsOAXNiN sykZl+T+8gsfrxg679xMBCbGTq3S5i/+4RXsr3a6qT1JY5cW488HlAwc5g5ThXMiXgM+Si0pR4d NMXbbAZwxyxH365jkS0sBPMsjDC37ihVafuQrJXdAGXoT14R1BoaXgOumPJFVxoq/Gl6OkxraCi zqwTh0OO3FH2SpOFYngSO38Kjlh/fBeUtSsae/DryjTzJEFSuogoKc97O5HQ0AbLDiIJpEFo/wq gqFPKf/UARyJwL3Tz4w5h5jg00Yj1M/bGr9h1ogjZslRUfAU3a0kwlXMX64v7K/k7xh+Y4OyCXJ EkL9WusBi0fOitGiDUzxewhugYukXU1WMaWrRlE3eP7Jj7ydbN71Yy30HS6v4j8JV/A2/5bHYVD whfdoZeRd/uQNxjR/wZ63OmtAVhpP4rUR+vHbtZosPbSjPcT9cYI8r+6XtrpGJElGJ6jH/yrOyt dkkk7F5z2c+iQYMJ1J++hlzQ2CzZmROyfsOXoPiEn8dGG+TaGITZzyURkwjjp+CaVMTXIYL4301 iMIoN0HZhB612hg= X-Received: by 2002:a05:6402:4550:b0:698:3dd2:6802 with SMTP id 4fb4d7f45d1cf-6a14f13c034mr2005116a12.12.1785920155301; Wed, 05 Aug 2026 01:55:55 -0700 (PDT) Message-ID: <5febc2c0-4355-48d9-9342-52d590041500@suse.com> Date: Wed, 5 Aug 2026 10:55:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP To: Jan Beulich Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3An0i0jnKJ9M07xQcN6POwJ4" X-purgate-ID: tlsNG-16d1c6/1785920155-F70C777B-7686AAAA/0/0 X-purgate-type: clean X-purgate-size: 9485 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3An0i0jnKJ9M07xQcN6POwJ4 Content-Type: multipart/mixed; boundary="------------4WW0qjN3x6DNZ0llnQU8epAf"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org Message-ID: <5febc2c0-4355-48d9-9342-52d590041500@suse.com> Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> In-Reply-To: Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------4WW0qjN3x6DNZ0llnQU8epAf Content-Type: multipart/mixed; boundary="------------U7EZUbIJg56Wv00dnzU6nCTX" --------------U7EZUbIJg56Wv00dnzU6nCTX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTA6NDQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNS4wOC4yMDI2 IDEwOjIxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEvYXJjaC94ODYveGVuL01h a2VmaWxlDQo+PiArKysgYi9hcmNoL3g4Ni94ZW4vTWFrZWZpbGUNCj4+IEBAIC0zNyw4ICsz Nyw4IEBAIG9iai0kKENPTkZJR19YRU5fUFZIKQkJKz0gZW5saWdodGVuX3B2aC5vDQo+PiAg IG9iai0kKENPTkZJR19FVkVOVF9UUkFDSU5HKQkrPSB0cmFjZS5vDQo+PiAgIA0KPj4gICBv YmotJChDT05GSUdfU01QKQkJKz0gc21wLm8NCj4+ICtvYmotJChDT05GSUdfU01QKQkJKz0g c21wX2h2bS5vDQo+PiAgIG9iai0kKENPTkZJR19YRU5fUFZfU01QKSAgCSs9IHNtcF9wdi5v DQo+PiAtb2JqLSQoQ09ORklHX1hFTl9QVkhWTV9TTVApICAJKz0gc21wX2h2bS5vDQo+IA0K PiBTaW1pbGFyIGlzc3VlIGhlcmUgLSBpbiBhIFBWLW9ubHkgY29uZmlnIHNtcF9odm0ubyBk b2Vzbid0IHdhbnQgLyBzaG91bGRuJ3QNCj4gbmVlZCBidWlsZGluZy4NCg0KTm90ZSB0aGF0 IEkgZGlkbid0IGNoYW5nZSBhbnkgZnVuY3Rpb25hbGl0eS4NCg0KSSBhZ3JlZSB0aGF0IGl0 IHNlZW1zIGEgbGl0dGxlIGJpdCBzdHJhbmdlLCBidXQgaW4gdGhlIGVuZCBJIGJlbGlldmUN CnRoZSBjdXJyZW50IHN0YXR1cyBpcyBva2F5LWlzaC4gUFYtb25seSBoYXNuJ3QgYmVlbiBz b21ldGhpbmcgaW4gdXBzdHJlYW0NCkxpbnV4IHNpbmNlIFhlbiBzdXBwb3J0IHdhcyBhZGRl ZCwgYXMgUFYgd2FzIGFsd2F5cyBtZWFudCB0byBiZSBhbg0KYWx0ZXJuYXRpdmUgdG8gYmFy ZSBtZXRhbCBzdXBwb3J0IHZpYSBwYXJhdmlydCBwYXRjaGluZy4gSXQgbWlnaHQgaGF2ZQ0K YmVlbiBwb3NzaWJsZSB0byBidWlsZCBhIGtlcm5lbCBub3QgcmVhbGx5IGZ1bmN0aW9uYWwg b24gYmFyZSBtZXRhbCwgYnV0DQp0aGlzIHdhcyBtb3JlIGxpa2UgdGhlIGFiaWxpdHkgdG8g YnVpbGQgYSB4ODYga2VybmVsIG5vdCB3b3JraW5nIG9uIGFueQ0KZXhpc3RpbmcgbWFjaGlu ZS4NCg0KSU1PIHRoZSBYZW4ga2VybmVsIGNvbmZpZyBvcHRpb25zIHNob3VsZCBhbGxvdyBm b3IgYWRkaW5nIFhlbi1zcGVjaWZpYw0KZmVhdHVyZXMsIGJ1dCBtaW5pbXVtIFhlbiBzdXBw b3J0IHNob3VsZCBhbHdheXMgaGF2ZSBiYXNpYyBIVk0gc3VwcG9ydCwNCndoaWNoIGluY2x1 ZGVzIHRoZSBYZW4gc3BlY2lmaWMgcGVyZm9ybWFuY2UgZW5oYW5jZW1lbnRzLg0KDQoNCkp1 ZXJnZW4NCg== --------------U7EZUbIJg56Wv00dnzU6nCTX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------U7EZUbIJg56Wv00dnzU6nCTX-- --------------4WW0qjN3x6DNZ0llnQU8epAf-- --------------3An0i0jnKJ9M07xQcN6POwJ4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpy+poFAwAAAAAACgkQsN6d1ii/Ey9l 6wf/W3HihkA9Uswmcrucb7tqvb9cOHanp54LuaclrG8FpHgmia/XK9kqYKucq8x/PjndxPRRw7iR tOMrc8W+tFk+XoFiPSL20Py+7dy8Gx1QVCCnCigJtCZB2lQNI5kem5MHtHz67Tfeol5ECFyI4QcZ RTyT+QOQzr1I0lZkFOjG7XJSneJxE+w+p5bS6kkoL3hW+MX3Jg2r/ZMlJGKkSS1Ox229E5FdLYhM worPO50+LlSCLD7yv3dsOCl5UtTFgLJhucCae9ETY6SGYEguxWR1/73YNOHC4rSBGkWVDSFIlHYR BahBO/dX9OJjLhhhfcGUhITJJA7rF1BLqz2AY+ZPRw== =GhTB -----END PGP SIGNATURE----- --------------3An0i0jnKJ9M07xQcN6POwJ4-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 08:56:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 08:56:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383079.1626343 (Exim 4.92) (envelope-from ) id 1wrXQO-0006hw-Dv; Wed, 05 Aug 2026 08:56:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383079.1626343; Wed, 05 Aug 2026 08:56:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXQO-0006hp-AJ; Wed, 05 Aug 2026 08:56:32 +0000 Received: by outflank-mailman (input) for mailman id 1383079; Wed, 05 Aug 2026 08:56:31 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXQN-0006hQ-04 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 08:56:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXQM-00BL75-CP for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:56:30 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72fabd-bab6-0a2a0a5309dd-0a2a45089ac0-2 for ; Wed, 05 Aug 2026 10:56:30 +0200 Received: from [209.85.218.53] (helo=mail-ej1-f53.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72fabe-f659-0a2a45080019-d155da35c801-3 for ; Wed, 05 Aug 2026 10:56:30 +0200 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-c1712a04ddaso126059566b.2 for ; Wed, 05 Aug 2026 01:56:30 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a17bf29168sm631551a12.23.2026.08.05.01.56.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 01:56:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785920190; x=1786524990; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=/WAzVNKrEa94ZkoIMZwJA/XwMsXDf68SL8hYPTUGjw0=; b=PjJaIPIWCrdPtzmk/+rekj44mvHUCuPeMUyDXYmhjQtlRgDh1dFI65RWOarYsRVPnh rCqjI41xUTIzekIJjKYCbvWV/IAPoIxkFjQO2xlbxkd9O1H3jYSZE/jj8a6cOOMcx3KO bM+fq0uG1M0S2Qom19SdH9SI8gQofFP3qm0+VbvLeYi0tfZVlVWsTP7r1N20EBFvnSb+ pguqoO5MXoxOiEs5HHhYrBgSDivlfLpoUCGEtzublOhYXyEK9w+pClNHTV0pLbGflrXc 0bHSFjiFz24xETuo9p5wDFe7251hATkeXY3yv5IgF+pGl7OYvu5NtGyWJHz5lI3xJz41 Mvxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785920190; x=1786524990; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/WAzVNKrEa94ZkoIMZwJA/XwMsXDf68SL8hYPTUGjw0=; b=kYYzhdBinC+opWBaKoDMXfaUH9vmJFVMWPFNkb3fcm7GCOwt1IePDzmeocbTKNRsC6 ARn1kaTvK9fRNH9cmrwUeCAr6zeGMOq+YNTMIRuu4HaYubjgrw4JQWeiGpQG6W3kuGPD yRMIcrp8/rXgZSc9HfOSVp9bXUZtIPj0L2w7hUF0JBzSNd+BchzNjYHGyGL5vm/bhz5l aNY9TOAmfJu43b+znBJQl2ryxRD/QshDmjLGnjTvtrI1sYJmtITRkS2w8t6Pgwurdoaw bFkFtRD1MRaP2Jgford+WYEAupWE0D4HjXrH5RjiU1LRe18RWYoOpUWhx8XhS6FfcCKD RFAQ== X-Forwarded-Encrypted: i=1; AHgh+Rp07VOr6alxwlhqE5EpzOLxvP8Fm9U9ZQycpnMGhORmC8u8pto6/VsL+28GbvNmgg/gD7wyiAnrro4=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw0wf9e75HZC2b7OgmaeCk0FKRW1BATmwEPFV6ve+/MzdLhQCCr GrVeBLaGx60QQsPFwl1nBEuzWXgZOjJGNPyknIFLLOBcYx0b3KMg2e+KRWRICJAU3eM= X-Gm-Gg: AR+sD103pa2fS3/fhRgtyrhuPeWg6Yu6fTafjpKI2FYcAdEFbSI1eQEPndg15IeuczE qBKJKX3I8o1xCg/DyUO/9SY8uMA65QALQsLoi50jNB2q2YtAIiIaegAJ5qEaN/ecB8xtTeOjCp8 u5NIq8ZvuBibhcG+ZhaH+Yc4wYoxj0vlNoPoK9L9Oq5Qh8gjCGs1WsVfM0M3obFmyvd70qb1F3r Y545Y8C6ANYgNQtfZZOfnZRDsmvfdGXz6CytOL/qUK3ztJrqmWDyhrub++rYixd8snt+3vtvFyM ASM1iek+qcEjRQAx6YOc6iP3F8z03Cga3Ymnjpjc5h33ejBDoZ6PISMQEvk7NL4F0TZw/7sX59n DSrqbxTS7DPseDcKSCSVH0teiis+YfqbrpJ87zKt9jI2JuQ7a20zxia6XZ7JJyrHu/nB2CiO4nM KzJr2aitqh0+BHbxnLwkNeDj3rNDn40yZbFLKBBlSRcZDZ+DByXoa3Mf1ZuG+QQZUQZE/rkPBxi 97V2Np41FuMhPQ8dIgQk7D+aaa0d3Xz4BvWYwJP9vyf2j/Vu6KGD5Kcb5FWSW8DzBMceb6b/cEz KekU26+eiOzt7hJtT30E5jk1FQ== X-Received: by 2002:a17:907:1688:b0:c20:331c:cf0a with SMTP id a640c23a62f3a-c2039ad0de7mr189773966b.5.1785920189622; Wed, 05 Aug 2026 01:56:29 -0700 (PDT) Message-ID: <2b144df0-c54e-41e1-afbc-5a6a0d5dad9f@suse.com> Date: Wed, 5 Aug 2026 10:56:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] xen: Drop CONFIG_XEN_AUTO_XLATE To: Jan Beulich Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-4-jgross@suse.com> <4ca560cd-c43b-4893-bec6-800a33cd1bb7@suse.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <4ca560cd-c43b-4893-bec6-800a33cd1bb7@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------OfdoGTk13Cdl1qpBKjD05yeu" X-purgate-ID: tlsNG-c1860d/1785920190-CF75B87B-98DCF980/0/0 X-purgate-type: clean X-purgate-size: 8253 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------OfdoGTk13Cdl1qpBKjD05yeu Content-Type: multipart/mixed; boundary="------------cyLXlascjfZ1ZpIXhc0dfFvc"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <2b144df0-c54e-41e1-afbc-5a6a0d5dad9f@suse.com> Subject: Re: [PATCH 3/4] xen: Drop CONFIG_XEN_AUTO_XLATE References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-4-jgross@suse.com> <4ca560cd-c43b-4893-bec6-800a33cd1bb7@suse.com> In-Reply-To: <4ca560cd-c43b-4893-bec6-800a33cd1bb7@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------cyLXlascjfZ1ZpIXhc0dfFvc Content-Type: multipart/mixed; boundary="------------jMfJPo22aNSLaYa00xjt5SLN" --------------jMfJPo22aNSLaYa00xjt5SLN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTA6NDIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNS4wOC4yMDI2 IDEwOjIxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEvZHJpdmVycy94ZW4vS2Nv bmZpZw0KPj4gKysrIGIvZHJpdmVycy94ZW4vS2NvbmZpZw0KPj4gQEAgLTMwOSwxMiArMzA5 LDYgQEAgY29uZmlnIFhFTl9FRkkNCj4+ICAgCWRlZl9ib29sIHkNCj4+ICAgCWRlcGVuZHMg b24gKEFSTSB8fCBBUk02NCB8fCBYODZfNjQpICYmIEVGSQ0KPj4gICANCj4+IC1jb25maWcg WEVOX0FVVE9fWExBVEUNCj4+IC0JZGVmX2Jvb2wgeQ0KPj4gLQlkZXBlbmRzIG9uIEFSTSB8 fCBBUk02NCB8fCBYODYNCj4gDQo+IFlldCBpcy93YXMgWDg2IGNvcnJlY3QgaGVyZT8gU2hv dWxkbid0IHRoYXQgZXhjbHVkZSBQVi1vbmx5IGNvbmZpZ3M/DQoNCkFnYWluLCB0aG9zZSBk b24ndCBleGlzdC4NCg0KDQpKdWVyZ2VuDQo= --------------jMfJPo22aNSLaYa00xjt5SLN Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------jMfJPo22aNSLaYa00xjt5SLN-- --------------cyLXlascjfZ1ZpIXhc0dfFvc-- --------------OfdoGTk13Cdl1qpBKjD05yeu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpy+r0FAwAAAAAACgkQsN6d1ii/Ey9g 3Qf/TduT6P4Atx2oGLx/o2nDSVO14yCzVmoZPOXvuWesvK5Duqgn4P0T/x6tBEBN7iEZp7dtuhq/ SqUw3tuWeG65jj2nGLQxTa98odBw8uMh71Zh/qhwclD96Lggoz0ieKlHN0JUleEiO9EG4S04eL6v aRELJK3V+gh98+l6SCLTicSWKi1jNes6shGW9k6Aso8f6TeTyVgG/GOPyrbiTezf/e22+Tb1vIgC +A5IwnqTzAlUKMyP7ZER8mKmkVRsa5PJYliK8ycD1b/ojErtbSvy31X4z+DfrJ4V2orXDJFLOwwI Ynb+i3db+iO87tEWSuW3ZQeCx3i0h1TcUgkZiKV+cA== =QLSH -----END PGP SIGNATURE----- --------------OfdoGTk13Cdl1qpBKjD05yeu-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:04:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:04:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383095.1626351 (Exim 4.92) (envelope-from ) id 1wrXXt-0000RX-8i; Wed, 05 Aug 2026 09:04:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383095.1626351; Wed, 05 Aug 2026 09:04:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXXt-0000RQ-5P; Wed, 05 Aug 2026 09:04:17 +0000 Received: by outflank-mailman (input) for mailman id 1383095; Wed, 05 Aug 2026 09:04:15 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXXr-0000RJ-RQ for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:04:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXXq-003Ex0-JW for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:04:14 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72fc89-e002-0a2a0a5209dd-0a2a450499a2-18 for ; Wed, 05 Aug 2026 11:04:14 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72fc8e-b57f-0a2a45040019-d155802fbd04-3 for ; Wed, 05 Aug 2026 11:04:14 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso4591765e9.1 for ; Wed, 05 Aug 2026 02:04:14 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23ede6sm7230911f8f.30.2026.08.05.02.04.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:04:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785920654; x=1786525454; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CcWPV/2C/noLJiB/mvTSLtIwjRvaHYyVNz5lIaVixS4=; b=eLL9tBzCCsDqDeWiq93199XJ/U6NjXuklWLUBNSM7IkY4ZoE91vjibio8JheXKXHiD /8YO4KtdbOy9h5zkuL+NJtLEQgHn1Ux5SYrEvmMX/eKgq5nDy//RfubH/+d+Ft6TOMv4 7aNx5F1oyYM2CO+KGp+169Onj5AZ9OCE315LhN1ccr7vK+mKbw3DFJO7MDy9JWpkdIu1 SWOe/6SZPY1Gwh5v/tBlsLGnsS9BD7oQfLb+unCDtORxv+rLHceaWokXRa51SvdUffKv EKnHBPtSvjyEhO8TvTJXB2xK8nKkkuRoLZcmb+nqvZI+1zbnRLwuPOsh2juhbqOUEG7g Cuug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785920654; x=1786525454; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CcWPV/2C/noLJiB/mvTSLtIwjRvaHYyVNz5lIaVixS4=; b=ZxYsjU/m8QhPtsU2upPsb7tL9iw3NT1//QnQt9QrerlLzuMutIrs5xiMFdjunobSSe BtCXHT+gBNjIIfog+3NnNCv8Xnoh9BrjDGH0zcsj+CejxL8i1BYvMnZt6oQnDQutPXlT DdD8Sy7ehreywAERocrj5GHzazG54R0GMLugOWrgHA08ttlCIRQITKWH7bn9l+2kDzU1 Vjnr1l+pAslVeAiLRC2gt2ZfVrhsUETip5FBefTPtFRDwWTd15Dh8SifsgS8cq41X8aC lbwfDggmgFKTcbFoY9Iwg8i/IflOl58HuHW5bzwI9PlNGq28qXZj+gBqWQ5SAFnTPyso qkkA== X-Forwarded-Encrypted: i=1; AHgh+RqpexKbYGAMql7ShjY0WTRcPPAountQP4gUFc4ePY8NnqVkxVZZhRlnO7NrNgdRxKEx4XEhId17bvo=@lists.xenproject.org X-Gm-Message-State: AOJu0Yye18rfQNRSpt8U3YoSjWAFMgU8uI+FiuOOXcu2v73cTRFqjWg0 t76dJgnQp29qOkXYrDOtKBWVWFo8106rlXDtl5xXtNn/bNwBuxNkaO7sH2nsYJVtuw== X-Gm-Gg: AR+sD11z+sGvQv408WCvZrvsOw4/f7oNP97NDcRJPI6zDfh9hMFrGcaZjdC5YMNju4D pVaFGPeI0/JdKNo0sKBGMmVkAtip7C2L/v5bA6fze/3wuIBJZj8kROQwPzsPFgsrDeyg+Ja8zSD SpR71W8Naa1JvnzF2ieNCmaRcrgzfN0AUxZNe5oHJIVA55u6fnzbajSMkusRlxp84UrW9vZjz8j yy6RqMQnfM2izz8aTK0kZv9pAjftzhAXrNUTFr1Z6Quqt46mnrGbQADItXiYwyOrWsN9IuO/dzZ JTnrqgK3ascCU2nutqF5AAJ1YDTVJ29MPyFqJC++VM8xka++uGi2CrFi8gMNvMzowtrXZ2W3gym xCZPtJehNe+/LsG7HEY8JYpy4f8sR/312lzOctw+gZlquccdxysOqPWeUPrCv/p7vQYGTX5tm+M GHLFqnfAbB1nKmaKXn0P1wzOR1LsqlnWU3ja5yb46UYhJS1J2J62mvJSIsL6Ao5OxREpIr3P0h4 Hz4vGM1Vp8PaYkajrZnpjpxx0XCAYphgQ+bLNOogayoaN2tStNh X-Received: by 2002:a05:600c:4688:b0:495:6bc9:62b0 with SMTP id 5b1f17b1804b1-4994e7d1487mr55628955e9.17.1785920653939; Wed, 05 Aug 2026 02:04:13 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 11:04:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP To: Juergen Gross Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> <5febc2c0-4355-48d9-9342-52d590041500@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5febc2c0-4355-48d9-9342-52d590041500@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1785920654-520D5B50-1A0B19E4/0/0 X-purgate-type: clean X-purgate-size: 1558 On 05.08.2026 10:55, Juergen Gross wrote: > On 05.08.26 10:44, Jan Beulich wrote: >> On 05.08.2026 10:21, Juergen Gross wrote: >>> --- a/arch/x86/xen/Makefile >>> +++ b/arch/x86/xen/Makefile >>> @@ -37,8 +37,8 @@ obj-$(CONFIG_XEN_PVH) += enlighten_pvh.o >>> obj-$(CONFIG_EVENT_TRACING) += trace.o >>> >>> obj-$(CONFIG_SMP) += smp.o >>> +obj-$(CONFIG_SMP) += smp_hvm.o >>> obj-$(CONFIG_XEN_PV_SMP) += smp_pv.o >>> -obj-$(CONFIG_XEN_PVHVM_SMP) += smp_hvm.o >> >> Similar issue here - in a PV-only config smp_hvm.o doesn't want / shouldn't >> need building. > > Note that I didn't change any functionality. > > I agree that it seems a little bit strange, but in the end I believe > the current status is okay-ish. PV-only hasn't been something in upstream > Linux since Xen support was added, as PV was always meant to be an > alternative to bare metal support via paravirt patching. It might have > been possible to build a kernel not really functional on bare metal, but > this was more like the ability to build a x86 kernel not working on any > existing machine. > > IMO the Xen kernel config options should allow for adding Xen-specific > features, but minimum Xen support should always have basic HVM support, > which includes the Xen specific performance enhancements. I fear I don't understand this. If I want a kernel just to run as PV Dom0, why would it need to carry anything HVM-ish? That is (or should be) entirely unrelated to being able to also run this same kernel on baremetal then. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:11:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:11:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383107.1626360 (Exim 4.92) (envelope-from ) id 1wrXeW-0002Ul-TG; Wed, 05 Aug 2026 09:11:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383107.1626360; Wed, 05 Aug 2026 09:11:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXeW-0002Ue-Qb; Wed, 05 Aug 2026 09:11:08 +0000 Received: by outflank-mailman (input) for mailman id 1383107; Wed, 05 Aug 2026 09:11:07 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXeV-0002UY-Lp for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:11:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXeV-0095Bc-2j for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:11:07 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a72fe1b-2eae-0a2a0a5409dd-0a2a450ca3c4-46 for ; Wed, 05 Aug 2026 11:11:07 +0200 Received: from [209.85.221.43] (helo=mail-wr1-f43.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a72fe2a-f479-0a2a450c0019-d155dd2bf1a6-3 for ; Wed, 05 Aug 2026 11:11:06 +0200 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47f7872abb6so353885f8f.3 for ; Wed, 05 Aug 2026 02:11:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec231f5csm7197501f8f.23.2026.08.05.02.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:11:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921066; x=1786525866; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VGV25APuoOGYWcIc/TeUgn93qgV5jI1K78UHmfRhA/k=; b=TYSsoK44bQmVSZ/0zdgRnzZCZhGwyJxLd1J8tcozyCdobYwJal/t9+kC811PYOn+fN IqNlwvtiXhadQF4witff2IwCZ9U/O8yjIeXxrQp9wgRfpfarOeeekIePUIrq3jcmRibS JBzGTnmtMG+rJ76Pe9xv4YAOGHM6zRA/q8lprV1tbcPUU8cRZBUIYmTg8W1ytCVkACxM 0Sd/J/62lTV5LPJtCf/abIniVKz4rG5AwiX3KnOICgY7L9JTH91SWWheEk265u3e97Zh hiLhlAgFNAPqj4gxfst2pPh8RwPLOrpOQMHkLNVsMwL027hCfIXpGp8c/wgg2GySfWYB WsLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921066; x=1786525866; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VGV25APuoOGYWcIc/TeUgn93qgV5jI1K78UHmfRhA/k=; b=SCiGtYgtBxlCLg9es0OD3hQ7JbB3GVQnRFp0NzqN+iHoSNdwZupJNfLihDyQHMYEwB jjlScQWhNMg0oqryk1Gbsp+XbVSWqlqpSkEHMCQuzqzet/S0jo2t2jGXUDCZnbpCHxAI NL7rDnSvv7+FKN5Ki4qpgZD7HR+9N5bn20WgQsYZEBObZkqoH2K/oivklLuty0fJd2ZP TzDoKxfTPPqUcsuLi2RFCl0FE7qVLPBQdQlhUTvTGENZqInpu/PdUiuB+CW8TKZuSFEa r0brTpBXgd+kaPiNA+Nhu49+EVPHN1z+BMKBRgejfrx9ImaDiA8/E7MwekuLuRU8DBDA szFQ== X-Gm-Message-State: AOJu0YweteyBDw5aG6wQuqYlPXQ1V7YmLVLtvThh0+1zDfrxNOKy7HBQ lHJvoZ5LI4J72nI3MACeo+YFro3M8Ra9uJLqa15PphNlFwTbU26KNlfF76VRMn6L8A== X-Gm-Gg: AR+sD10noqeDvxrbRSTFPOwUxk94gkBbAvM8rah+Z6PW38ZykO9nvSEO5fYchWCVL/H zqCMdOlKw+7CEBWVU1Y0B/9wxbNO9/2dCMy8cUflpH7GciDjBJqAXw56U3O4JeKtr50pxJNaKgI H6cKY0vUHKQWV8LiS1vt4onlDusQG0Z9jF9rrKZKq5izzi5JyT8jvKpmZe3HwhIi2aLTqbp+ebK XLUE6K/xFwgyoaTXTDoeadwUJJeXer4UKVq+Q/skS6uGOw9iHJQN9rGnJ/rBEQEsXhh+BdNuw18 tZCmZYgkhxU9ZwAsTyOcuUhLKTGsJCZh8t5RoxniOiekTEPUsJWnf4f5Plag7ITIPqBsDQ/skl8 hgkL5XJtOGsT9ZlpnBF7eQgP8Wtd7NWI4VLfADMbLJEw7gUNUSr+kRDGW+VCg7zE1esZxAxQsLk TJ3RWTj33976LjBhgYnGPc2KPsrnrbsMMo7kbhN2E2GLYqPrOY22zbhqcxdWYWS76I+fiX+wnug +8Cyz78Rbk6zyHrVezoE+dP8subgdxvGs33sti95qDwQnGNM6BdVUkv3C6DWbk= X-Received: by 2002:a05:6000:4718:b0:47f:93fc:2d27 with SMTP id ffacd0b85a97d-47fec62c7e1mr8485530f8f.30.1785921066305; Wed, 05 Aug 2026 02:11:06 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 11:11:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: Jason Andryuk , Daniel Smith Cc: "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> <8097d8e8-42ec-463a-8247-56c9e4d834cd@suse.com> <57bb7281-5898-4243-837a-1236b25e761e@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <57bb7281-5898-4243-837a-1236b25e761e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1785921067-016C6A5B-CD5B4504/0/0 X-purgate-type: clean X-purgate-size: 4124 On 04.08.2026 16:27, Jason Andryuk wrote: > On 2026-08-04 03:53, Jan Beulich wrote: >> On 03.08.2026 23:01, Jason Andryuk wrote: >>> On 2026-07-28 09:22, Jan Beulich wrote: >>>> --- a/xen/include/xsm/dummy.h >>>> +++ b/xen/include/xsm/dummy.h >>> >>>> @@ -751,27 +751,32 @@ static XSM_INLINE int xsm_dm_op(XSM_DEFA >>>> #endif >>>> >>>> #ifdef CONFIG_ARGO >>>> -static XSM_INLINE int xsm_argo_enable(const struct domain *d) >>>> + >>>> +static XSM_INLINE int xsm_argo_enable(XSM_DEFAULT_ARG const struct domain *d) >>>> { >>>> - return 0; >>>> + XSM_ASSERT_ACTION(XSM_HOOK); >>>> + return xsm_default_action(action, current->domain, d); >>> >>> This one I think should be >>> return xsm_default_action(action, d, NULL); >>> >>> Usually current is passed in for the check, but for domain_create() -> >>> argo_init() it is the under-construction domain. >> >> And in that case we want to make sure that current->domain may enable Argo >> for d. > > It's not a hook for current to enable for d, but more of a hook "is d > allowed to use argo." > > In the hypercall entry path, it use is clear - "is this domain allowed > to make argo hypercalls." > > In argo_init(), it is more of an optimization. Only initialize if d is > allowed to use argo. I think this use is questionable, but it is the > current code. > > In flask, the source is d, the target is xen_t: > allow domain_type xen_t:argo enable > > So it is not an operation between domains. > >>>> } >>>> >>>> static XSM_INLINE int xsm_argo_register_single_source( >>>> - const struct domain *d, const struct domain *t) >>>> + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) >>>> { >>>> - return 0; >>>> + XSM_ASSERT_ACTION(XSM_HOOK); >>>> + return xsm_default_action(action, d, t); >>>> } >>>> >>>> static XSM_INLINE int xsm_argo_register_any_source( >>>> - const struct domain *d) >>>> + XSM_DEFAULT_ARG const struct domain *d) >>>> { >>>> - return 0; >>>> + XSM_ASSERT_ACTION(XSM_HOOK); >>>> + return xsm_default_action(action, current->domain, d); >>> >>> Similarly: >>> return xsm_default_action(action, d, NULL); >>> >>> The single call is: >>> xsm_argo_register_any_source(currd); >> >> There being just a single call puts this on the edge. If there was another >> one not passing current->domain, I think the same argument as above would >> hold here. And the general concept is what I think should matter when >> writing the dummy implementations. > > For flask, we have xen as the target again: > allow domain_type xen_t:argo register_any_source; > > ... since a wildcard ring doesn't have a known target domain. > >>> These argo hooks all pass in their arguments explicitly, so I think we >>> should do that and not use current. (The send and register hooks could >>> use current, and that could make sense as those map to hypercalls. But >>> it is correct today with the explicit arguments.) >>> >>> With the changes: >>> Reviewed-by: Jason Andryuk >> >> Thanks, but no - unless I misunderstand how permissions are intended to >> work here, I don't think I can make the changes requested, and hence I >> can't apply the R-b. > Understandable. > > It seems to me that the XSM hooks have two styles. Either implicit args > (using current) or explicit args. Today, the argo hooks take explicit > like the grant hooks for instance. Yes, which doesn't make things any easier. I follow your argumentation as one of the possible interpretations, but I think I really need Daniel's verdict (as XSM maintainer) here in order to know whether to adjust the proposed code. (It is true that what you suggest comes closer to the blanket "return 0" that were previously there in all the Argo hooks, leaving aside that due to it being XSM_HOOK all of this is cosmetic / doc only anyway. There is certainly also the option to retain those, but it feels that doing it like this was wrong from the start.) Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:21:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:21:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383118.1626368 (Exim 4.92) (envelope-from ) id 1wrXon-0004NI-R8; Wed, 05 Aug 2026 09:21:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383118.1626368; Wed, 05 Aug 2026 09:21:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXon-0004NB-O2; Wed, 05 Aug 2026 09:21:45 +0000 Received: by outflank-mailman (input) for mailman id 1383118; Wed, 05 Aug 2026 09:21:44 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXom-0004N5-Fz for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:21:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXol-00HW9a-AS for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:21:43 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7300a4-5cb7-0a2a0a5109dd-0a2a4505af8c-22 for ; Wed, 05 Aug 2026 11:21:43 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7300a6-4cb1-0a2a45050019-d155802fd509-3 for ; Wed, 05 Aug 2026 11:21:42 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so6086135e9.1 for ; Wed, 05 Aug 2026 02:21:42 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfdd383sm6701110f8f.8.2026.08.05.02.21.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:21:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:Autocrypt:Content-Language:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921702; x=1786526502; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:autocrypt:content-language :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=TsYpXoA+xmQ+uT37K3y8LI1YqP2UpTicdeqYAxlPxBE=; b=QzY8PYXbwweH/TOKGQUbKM4ayT2a/rbGGFyq8YK2srDY3xjnD6v+JLz9QPTN8cu+UD KkfUxMlXbRqWBQNuIieim6Wj4Yuf6GIJPDGZWf0I08spJkYQDTYBwA5jR7XVXhbPAJby NWySf+mfMYCZuRxETn2KJEJPaXqnbf3kZGaDOH5qbygpClmkOIW9IQ29R5OGUrFXVhQM dZusQms1RkCnVOwqbPz8xdF12s628H8gLIPmLbfSjrFwbrHQBUkwmHno0q4Ki9jIMcKR aNFvKr87P5cwNhQZQk5HSOS8vjIp7nzDx9RYrcx42TvFFvrPZl7bGVIOyRUACUx2mBKO psOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921702; x=1786526502; h=content-transfer-encoding:content-type:autocrypt:content-language :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TsYpXoA+xmQ+uT37K3y8LI1YqP2UpTicdeqYAxlPxBE=; b=ZZwnT3wHoFmbF8ZbnWmtFjsEJ5Nx+C8tMrBAg40IC/txcigHSp0IdLQcOyPKDN+blm tePzRJrJaVQ6uxHHccZRwnhO7GkgUx07Rgwl/11MUsxvfnTcnDP6m84WCHXxnYswGPgh AG5faS+a9No2/R7rapUTGUz38zkkAqYZdhR+/b5rQv+/tfToXXfA+McIQtzCQHpmcJyv WoA5j41QfRomRCguxlnwQVC9NuWQEIzAa5g+92yiujwfrxOkKeskZKUsuoO1Z0J0IPGb oj2esTS3ZqeV5IOCrJCxb2IKDWpXgw1XeINanY62TPf1xQlBh4VXQgeXclqVEag+RSym ALZA== X-Gm-Message-State: AOJu0YwU5ciRN8uzh/GlySKBILda4LrAoe8aRbHyOjYQxLhPjs0nkTr1 KnRwM+qDe6rmiNzDTZ5MDfWUpiyL9xwyNAL5LsX+WMDLxLLs7foFxFqYa/gQfLag3MfbG2ax4RI T6rT67g== X-Gm-Gg: AR+sD13iVQwnD4k5Pd3PXhVnORZtSptFZx4Ge8j29E5CCQ7mGFVzG3E7J1lf17Z9ak3 +WfZWP3HFRxDu37WOObSCfFgYypMyaO4h3H0FlQxCygVJ4osVyDMYuxoBRylcvmPW5NEGUMS3jG 40BsK4SwGUma/EP+D6kTcKTH/5oaJ23ajGm8Q8rezHBgpIoCoLR6tnOQLPl37QZ/hzfwxTmh8i0 vWSwlHfxLnZMQuaaZhT5ds6X2UsVegyGRSIQ18l/bwLGLZMuTNL4UoKGwRzUBxHG7+lnSGUOLuU mQjGkRiFFuQTQKOmbLiCy1VIAIOFjXjtEHc2jwI3Axqe3yv6CA88sCm9VsEFFTh99CIuoyH7U8N GxufVppTPS9nGh9uM41oceUH/vPrJ/8Gm9IZK1riQREo9KveoQVr6d7qe5N5P404SsBGVvb3kan FQnNCEAqqRCGNQPWkJJO0y175v5c5hFCysCvKe5rQTxDdaKXt9AEYCMGeCGnEvMUpMEhBAQCodz WXq1lDOR1l7LRKCj2F/qhN4TAgfwGt3FaGyqRrdceC47FKeG4aV X-Received: by 2002:a05:600c:5694:b0:495:503f:cf9a with SMTP id 5b1f17b1804b1-4994e7bab0emr40018255e9.9.1785921702104; Wed, 05 Aug 2026 02:21:42 -0700 (PDT) Message-ID: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Date: Wed, 5 Aug 2026 11:21:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Beulich Subject: [PATCH v10 0/6] x86emul: misc additions (MSR accesses) To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1785921702-F74BC2A1-2A83EC49/0/0 X-purgate-type: clean X-purgate-size: 233 01: x86emul+VMX: support {RD,WR}MSRLIST 02: x86emul: support USER-MSR instructions 03: x86/cpu-policy: re-arrange no-VMX logic 04: VMX: support USER-MSR 05: x86emul: support MSR-IMM instructions 06: VMX: support MSR-IMM Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:22:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:22:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383125.1626377 (Exim 4.92) (envelope-from ) id 1wrXpd-0004od-2o; Wed, 05 Aug 2026 09:22:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383125.1626377; Wed, 05 Aug 2026 09:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXpc-0004oW-WF; Wed, 05 Aug 2026 09:22:37 +0000 Received: by outflank-mailman (input) for mailman id 1383125; Wed, 05 Aug 2026 09:22:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXpb-0004oM-SA for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:22:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXpb-003xUi-5I for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:22:35 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7300d3-2eae-0a2a0a5409dd-0a2a4505b946-36 for ; Wed, 05 Aug 2026 11:22:35 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7300da-4cb1-0a2a45050019-d155802ba8ba-3 for ; Wed, 05 Aug 2026 11:22:35 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso13701115e9.0 for ; Wed, 05 Aug 2026 02:22:35 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23ec2fsm7161507f8f.29.2026.08.05.02.22.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:22:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921754; x=1786526554; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=fjs9sHGquZQF/L9bQ2CBvHTyahS9kvnKV++jSks/hjg=; b=aTi2DlL5iPdfdH0pnVUgeZHz5PewJmSA5XIEdpeqAEhwAH0eGoQq+mgM7ADhEZWE94 8ESS91/JXM2YYrxa8fsSJPN9uDJ7Mirs1UREg7AoTDm6rBqjSU6CKdJt3lbmQJVMK0FC /YSVX2Wy877OHcqmkOAdMjOPYpC5r/XyEINzwMVE+Pi/MQGI+WLQZI8wLcc4dDvLIlWU AjbnKxCGr5LQ4W2mOfTILLcj4BRIoy1NOptTxQ8oNyBNUDowe2wWeziNCSwWPm2HQki1 v3glK+QxdvB/1WqmYeaCz+Ssr2CDss7nNryhh8HBSk+lyYUEUtdDIIVN4dLpV3ipKF30 FXZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921754; x=1786526554; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=fjs9sHGquZQF/L9bQ2CBvHTyahS9kvnKV++jSks/hjg=; b=e5vSWvOkY2SQ+XjIJqh5R8i5M+vWHUdUAM/zl37Zd644JlGlc+++TRGWr59jvuOLea jocPsDe57g7gJHXb6Hh3d5HLay+bzasIoQ4w00/GRfiLnDPKzlygIrwpv790jKmS8r1v GosAAyiVVTQhrAsr1G0bsxIXUuW8ULMDI/RCOiH5fykqz0RcugE0e2LSIGl5wHZ8WbAW JJnD4fMJbZW0fRet8e0vXxoKa2O7Mur5Hdb8lxMZVQx/IrpP3mB9/niypW12j9nT56ol ZuQ0AaJy2lKjTzirPLBbg/PHaVvSVTpcrP4seKwom30dgBgEaAxZnyUjPIaej1sMTqQI q1Zw== X-Gm-Message-State: AOJu0YwR+OxwVKaOXgbe0FrW2ffvKeMhn3KR6teodYYlCpU/od51cKoV t/HfPvfFvtaxIxXGSOdTF4P77ROMWAWgSCgk2i/LRQRgZud5NQyG2x1ZZJ370UhafG0ZzoFEOFL ESOLD8Q== X-Gm-Gg: AR+sD104OH90ORHdPj8+mbUZL21z+Z2r4m0u4LB2cwZdbUU812Hj0GD136B8/SLjjlI GuFTKRB8qfG2xnDiicUA5ziMAjD4fpL7oEnufImhhQ09H6zYDxbEZCWRDM2aRDt0UXOTSupXvan +r2bBjHZTM7TUHj2JWIMidawKAw89cOt5eJ/osawx29FWQHJF2cUeycJLelGceFN/Vvg8N8XXSY YpTxKth3euRdiNhLbhH3orjvmuP27VfNwbEUsK2xfcCoECEx1fa3wgU7BAz8+sAKdHLr5T1wqIZ orj9HiPYFr/J71NAmYtqAK7mRjQMVwXXiNo/Or1E2YUV2rWF3IIdREe/1k+uZMYRtnAcSJjloJo iucqm2o7QY2WKHI+WSSr4sOqtQb7RDTKdCKV1ZDef9SradVihzwnLEoF28hSSoc62lFpiBu/SW7 GxbAXhaUrxSfNb5ob8CQn5HlXyfM/0ZJ9BdfA3sz7GNiyh1i3p2s9zLTkZNwN8205kKnlLv2NCs SeAt0GMh8/o+8TiLdhh2CrMcMWSG4OJjEXQHhjrNhH4SXQGWYEW X-Received: by 2002:a05:600c:c042:b0:495:4f89:8117 with SMTP id 5b1f17b1804b1-49949fd9848mr140595665e9.1.1785921754483; Wed, 05 Aug 2026 02:22:34 -0700 (PDT) Message-ID: <28b5b379-0577-4244-b660-d03cfb5ccc93@suse.com> Date: Wed, 5 Aug 2026 11:22:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v10 1/6] x86emul+VMX: support {RD,WR}MSRLIST From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1785921755-F7CB82A1-C1C4B105/0/0 X-purgate-type: clean X-purgate-size: 18832 These are "compound" instructions to issue a series of RDMSR / WRMSR respectively. In the emulator we can therefore implement them by using the existing msr_{read,write}() hooks. The memory accesses utilize that the HVM ->read() / ->write() hooks are already linear-address (x86_seg_none) aware (by way of hvmemul_virtual_to_linear() handling this case). Preemption is being checked for in WRMSRLIST handling only, as only MSR writes are expected to possibly take long. Signed-off-by: Jan Beulich --- RFC: In vmx_vmexit_handler() handling is forwarded to the emulator blindly. Alternatively we could consult the exit qualification and process just a single MSR at a time (without involving the emulator), exiting back to the guest after every iteration. (I don't think a mix of both models makes a lot of sense.) The precise behavior of MSR_BARRIER is still not spelled out in ISE 050, so the (minimal) implementation continues to be a guess for now. Wouldn't calculate_hvm_max_policy() for MPX better behave the same way as done here, at least from an abstract perspective (assuming that AMD won't add such functionality now that Intel have deprecated it)? --- v10: fuzz_{read,write}() adjustment. Non-default-expose the feature. Re-base. v8: Re-base. v6: Use MSR constants in test harness. Re-base. v5: Add missing vmx_init_vmcs_config() and construct_vmcs() adjustments. Avoid unnecessary uses of r(). Re-base. v3: Add dependency on LM. Limit exposure to HVM. Utilize new info from ISE 050. Re-base. v2: Use X86_EXC_*. Add preemption checking to WRMSRLIST handling. Remove the feature from "max" when the VMX counterpart isn't available. --- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c +++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c @@ -171,7 +171,7 @@ static int fuzz_read( struct x86_emulate_ctxt *ctxt) { /* Reads expected for all user and system segments. */ - if ( is_x86_user_segment(seg) ) + if ( is_x86_user_segment(seg) || seg == x86_seg_none ) assert(ctxt->addr_size == 64 || !(offset >> 32)); else if ( seg == x86_seg_tr ) /* @@ -340,7 +340,7 @@ static int fuzz_write( struct x86_emulate_ctxt *ctxt) { /* Writes not expected for any system segments. */ - assert(is_x86_user_segment(seg)); + assert(is_x86_user_segment(seg) || seg == x86_seg_none); assert(ctxt->addr_size == 64 || !(offset >> 32)); return maybe_fail(ctxt, "write", true); --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -342,6 +342,8 @@ static const struct { { { 0x01, 0xc4 }, { 2, 2 }, F, N }, /* vmxoff */ { { 0x01, 0xc5 }, { 2, 2 }, F, N }, /* pconfig */ { { 0x01, 0xc6 }, { 2, 2 }, F, N }, /* wrmsrns */ + { { 0x01, 0xc6 }, { 0, 2 }, F, W, pfx_f2 }, /* rdmsrlist */ + { { 0x01, 0xc6 }, { 0, 2 }, F, R, pfx_f3 }, /* wrmsrlist */ { { 0x01, 0xc8 }, { 2, 2 }, F, N }, /* monitor */ { { 0x01, 0xc9 }, { 2, 2 }, F, N }, /* mwait */ { { 0x01, 0xca }, { 2, 2 }, F, N }, /* clac */ --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -626,7 +626,7 @@ static int write( if ( verbose ) printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, bytes); - if ( !is_x86_user_segment(seg) ) + if ( !is_x86_user_segment(seg) && seg != x86_seg_none ) return X86EMUL_UNHANDLEABLE; memcpy((void *)offset, p_data, bytes); return X86EMUL_OKAY; @@ -713,6 +713,10 @@ static int read_msr( { switch ( reg ) { + case MSR_BARRIER: + *val = 0; + return X86EMUL_OKAY; + case MSR_EFER: *val = ctxt->addr_size > 32 ? EFER_LME | EFER_LMA : 0; return X86EMUL_OKAY; @@ -1431,9 +1435,53 @@ int main(int argc, char **argv) (gs_base != 0x0000111122224444UL) || gs_base_shadow ) goto fail; + printf("okay\n"); cpu_policy.extd.nscb = i; emulops.write_segment = NULL; + + printf("%-40s", "Testing rdmsrlist..."); + instr[0] = 0xf2; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; + regs.rip = (unsigned long)&instr[0]; + regs.rsi = (unsigned long)(res + 0x80); + regs.rdi = (unsigned long)(res + 0x80 + 0x40 * 2); + regs.rcx = 0x0002000100008000UL; + gs_base_shadow = 0x0000222244446666UL; + memset(res + 0x80, ~0, 0x40 * 8 * 2); + res[0x80 + 0x0f * 2] = MSR_GS_BASE; + res[0x80 + 0x0f * 2 + 1] = 0; + res[0x80 + 0x20 * 2] = MSR_SHADOW_GS_BASE; + res[0x80 + 0x20 * 2 + 1] = 0; + res[0x80 + 0x31 * 2] = MSR_BARRIER; + res[0x80 + 0x31 * 2 + 1] = 0; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[4]) || + regs.rcx || + (res[0x80 + (0x40 + 0x0f) * 2] != (unsigned int)gs_base) || + (res[0x80 + (0x40 + 0x0f) * 2 + 1] != (gs_base >> (8 * sizeof(int)))) || + (res[0x80 + (0x40 + 0x20) * 2] != (unsigned int)gs_base_shadow) || + (res[0x80 + (0x40 + 0x20) * 2 + 1] != (gs_base_shadow >> (8 * sizeof(int)))) || + res[0x80 + (0x40 + 0x31) * 2] || res[0x80 + (0x40 + 0x31) * 2 + 1] ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing wrmsrlist..."); + instr[0] = 0xf3; instr[1] = 0x0f; instr[2] = 0x01; instr[3] = 0xc6; + regs.eip = (unsigned long)&instr[0]; + regs.rsi -= 0x11 * 8; + regs.rdi -= 0x11 * 8; + regs.rcx = 0x0002000100000000UL; + res[0x80 + 0x0f * 2] = MSR_SHADOW_GS_BASE; + res[0x80 + 0x20 * 2] = MSR_GS_BASE; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[4]) || + regs.rcx || + (gs_base != 0x0000222244446666UL) || + (gs_base_shadow != 0x0000111122224444UL) ) + goto fail; + emulops.write_msr = NULL; #endif printf("okay\n"); --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -66,6 +66,7 @@ bool emul_test_init(void) cpu_policy.feat.rdpid = true; cpu_policy.feat.lkgs = true; cpu_policy.feat.wrmsrns = true; + cpu_policy.feat.msrlist = true; cpu_policy.extd.clzero = true; if ( cpu_has_xsave ) --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -824,6 +824,9 @@ static void __init calculate_hvm_max_pol __clear_bit(X86_FEATURE_XSAVES, fs); } + if ( !cpu_has_vmx_msrlist ) + __clear_bit(X86_FEATURE_MSRLIST, fs); + /* * Xen doesn't use PKS, so the guest support for it has opted to not use * the VMCS load/save controls for efficiency reasons. This depends on --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -363,8 +363,9 @@ static int vmx_init_vmcs_config(bool bsp if ( caps.cpu_based_exec_control & CPU_BASED_ACTIVATE_TERTIARY_CONTROLS ) { - uint64_t opt = (TERTIARY_EXEC_VIRT_SPEC_CTRL | - TERTIARY_EXEC_EPT_PAGING_WRITE); + uint64_t opt = TERTIARY_EXEC_EPT_PAGING_WRITE | + TERTIARY_EXEC_ENABLE_MSRLIST | + TERTIARY_EXEC_VIRT_SPEC_CTRL; caps.tertiary_exec_control = adjust_vmx_controls2( "Tertiary Exec Control", 0, opt, @@ -1121,7 +1122,8 @@ static int construct_vmcs(struct vcpu *v v->arch.hvm.vmx.exec_control |= CPU_BASED_RDTSC_EXITING; v->arch.hvm.vmx.secondary_exec_control = vmx_caps.secondary_exec_control; - v->arch.hvm.vmx.tertiary_exec_control = vmx_caps.tertiary_exec_control; + v->arch.hvm.vmx.tertiary_exec_control = vmx_caps.tertiary_exec_control & + ~TERTIARY_EXEC_ENABLE_MSRLIST; /* * Disable features which we don't want active by default: --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -894,6 +894,20 @@ static void cf_check vmx_cpuid_policy_ch else vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + if ( cp->feat.msrlist ) + { + vmx_clear_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); + v->arch.hvm.vmx.tertiary_exec_control |= TERTIARY_EXEC_ENABLE_MSRLIST; + vmx_update_tertiary_exec_control(v); + } + else if ( v->arch.hvm.vmx.tertiary_exec_control & + TERTIARY_EXEC_ENABLE_MSRLIST ) + { + vmx_set_msr_intercept(v, MSR_BARRIER, VMX_MSR_RW); + v->arch.hvm.vmx.tertiary_exec_control &= ~TERTIARY_EXEC_ENABLE_MSRLIST; + vmx_update_tertiary_exec_control(v); + } + out: vmx_vmcs_exit(v); @@ -3846,6 +3860,22 @@ gp_fault: return X86EMUL_EXCEPTION; } +static bool cf_check is_msrlist( + const struct x86_emulate_state *state, const struct x86_emulate_ctxt *ctxt) +{ + + if ( ctxt->opcode == X86EMUL_OPC(0x0f, 0x01) ) + { + unsigned int rm, reg; + int mode = x86_insn_modrm(state, &rm, ®); + + /* This also includes WRMSRNS; should be okay. */ + return mode == 3 && rm == 6 && !reg; + } + + return false; +} + static void vmx_do_extint(struct cpu_user_regs *regs) { unsigned long vector; @@ -4656,6 +4686,17 @@ void asmlinkage vmx_vmexit_handler(struc } break; + case EXIT_REASON_RDMSRLIST: + case EXIT_REASON_WRMSRLIST: + if ( vmx_guest_x86_mode(v) != 8 || !currd->arch.cpuid->feat.msrlist ) + { + ASSERT_UNREACHABLE(); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); + } + else if ( !hvm_emulate_one_insn(is_msrlist, "MSR list") ) + hvm_inject_hw_exception(X86_EXC_GP, 0); + break; + case EXIT_REASON_VMXOFF: case EXIT_REASON_VMXON: case EXIT_REASON_VMCLEAR: --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -275,8 +275,13 @@ void vmx_vmcs_reload(struct vcpu *v); #define TERTIARY_EXEC_EPT_PAGING_WRITE BIT(2, UL) #define TERTIARY_EXEC_GUEST_PAGING_VERIFY BIT(3, UL) #define TERTIARY_EXEC_IPI_VIRT BIT(4, UL) +#define TERTIARY_EXEC_ENABLE_MSRLIST BIT(6, UL) #define TERTIARY_EXEC_VIRT_SPEC_CTRL BIT(7, UL) +#define cpu_has_vmx_msrlist \ + (IS_ENABLED(CONFIG_INTEL_VMX) && \ + (vmx_caps.tertiary_exec_control & TERTIARY_EXEC_ENABLE_MSRLIST)) + #define cpu_has_vmx_virt_spec_ctrl \ (vmx_caps.tertiary_exec_control & TERTIARY_EXEC_VIRT_SPEC_CTRL) --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -201,6 +201,8 @@ static inline void pi_clear_sn(struct pi #define EXIT_REASON_XRSTORS 64 #define EXIT_REASON_BUS_LOCK 74 #define EXIT_REASON_NOTIFY 75 +#define EXIT_REASON_RDMSRLIST 78 +#define EXIT_REASON_WRMSRLIST 79 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -24,6 +24,8 @@ #define APIC_BASE_ENABLE (_AC(1, ULL) << 11) #define APIC_BASE_ADDR_MASK _AC(0x000ffffffffff000, ULL) +#define MSR_BARRIER 0x0000002f + #define MSR_TEST_CTRL 0x00000033 #define TEST_CTRL_SPLITLOCK_DETECT (_AC(1, ULL) << 29) #define TEST_CTRL_SPLITLOCK_DISABLE (_AC(1, ULL) << 31) --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 76 +#define VMX_PERF_EXIT_REASON_SIZE 80 #define VMEXIT_NPF_PERFC 166 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -148,6 +148,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t case MSR_AMD_PPIN: goto gp_fault; + case MSR_BARRIER: + if ( !cp->feat.msrlist ) + goto gp_fault; + *val = 0; + break; + case MSR_IA32_FEATURE_CONTROL: /* * Architecturally, availability of this MSR is enumerated by the @@ -427,6 +433,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t uint64_t rsvd; /* Read-only */ + case MSR_BARRIER: case MSR_IA32_PLATFORM_ID: case MSR_CORE_CAPABILITIES: case MSR_INTEL_CORE_THREAD_COUNT: --- a/xen/arch/x86/x86_emulate/0f01.c +++ b/xen/arch/x86/x86_emulate/0f01.c @@ -11,6 +11,7 @@ #include "private.h" #ifdef __XEN__ +#include #include #endif @@ -28,6 +29,7 @@ int x86emul_0f01(struct x86_emulate_stat switch ( s->modrm ) { unsigned long base, limit, cr0, cr0w, cr4; + unsigned int n; struct segment_register sreg; uint64_t msr_val; @@ -42,6 +44,65 @@ int x86emul_0f01(struct x86_emulate_stat ((uint64_t)regs->r(dx) << 32) | regs->eax, ctxt, true); goto done; + + case vex_f3: /* wrmsrlist */ + vcpu_must_have(msrlist); + generate_exception_if(!mode_64bit(), X86_EXC_UD); + generate_exception_if(!mode_ring0() || (regs->esi & 7) || + (regs->edi & 7), + X86_EXC_GP, 0); + fail_if(!ops->write_msr); + while ( regs->r(cx) ) + { + n = __builtin_ffsl(regs->r(cx)) - 1; + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + generate_exception_if(msr_val != (uint32_t)msr_val, + X86_EXC_GP, 0); + base = msr_val; + if ( (rc = ops->read(x86_seg_none, regs->r(di) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY || + (rc = ops->write_msr(base, msr_val, ctxt, + true)) != X86EMUL_OKAY ) + break; + regs->r(cx) &= ~(1UL << n); + +#ifdef __XEN__ + if ( regs->r(cx) && local_events_need_delivery() ) + { + rc = X86EMUL_RETRY; + break; + } +#endif + } + goto done; + + case vex_f2: /* rdmsrlist */ + vcpu_must_have(msrlist); + generate_exception_if(!mode_64bit(), X86_EXC_UD); + generate_exception_if(!mode_ring0() || (regs->esi & 7) || + (regs->edi & 7), + X86_EXC_GP, 0); + fail_if(!ops->read_msr || !ops->write); + while ( regs->r(cx) ) + { + n = __builtin_ffsl(regs->r(cx)) - 1; + if ( (rc = ops->read(x86_seg_none, regs->r(si) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + generate_exception_if(msr_val != (uint32_t)msr_val, + X86_EXC_GP, 0); + if ( (rc = ops->read_msr(msr_val, &msr_val, + ctxt)) != X86EMUL_OKAY || + (rc = ops->write(x86_seg_none, regs->r(di) + n * 8, + &msr_val, 8, ctxt)) != X86EMUL_OKAY ) + break; + regs->r(cx) &= ~(1UL << n); + } + if ( rc != X86EMUL_OKAY ) + ctxt->regs->r(cx) = regs->r(cx); + goto done; } generate_exception(X86_EXC_UD); --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -612,6 +612,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_lkgs() (ctxt->cpuid->feat.lkgs) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) +#define vcpu_has_msrlist() (ctxt->cpuid->feat.msrlist) #define vcpu_has_movrs() (ctxt->cpuid->feat.movrs) #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) #define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) --- a/xen/arch/x86/x86_emulate/util.c +++ b/xen/arch/x86/x86_emulate/util.c @@ -100,6 +100,9 @@ bool cf_check x86_insn_is_mem_access(con break; case X86EMUL_OPC(0x0f, 0x01): + /* {RD,WR}MSRLIST */ + if ( mode_64bit() && s->modrm == 0xc6 ) + return s->vex.pfx >= vex_f3; /* Cover CLZERO. */ return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; } @@ -160,7 +163,11 @@ bool cf_check x86_insn_is_mem_write(cons case 0xff: /* Grp5 */ break; - case X86EMUL_OPC(0x0f, 0x01): /* CLZERO is the odd one. */ + case X86EMUL_OPC(0x0f, 0x01): + /* RDMSRLIST */ + if ( mode_64bit() && s->modrm == 0xc6 ) + return s->vex.pfx == vex_f2; + /* CLZERO is another odd one. */ return (s->modrm_rm & 7) == 4 && (s->modrm_reg & 7) == 7; default: --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -317,7 +317,7 @@ XEN_CPUFEATURE(NMI_SRC, 10*32+20) / XEN_CPUFEATURE(AMX_FP16, 10*32+21) /* AMX FP16 instruction */ XEN_CPUFEATURE(AVX_IFMA, 10*32+23) /*A AVX-IFMA Instructions */ XEN_CPUFEATURE(LAM, 10*32+26) /* Linear Address Masking */ -XEN_CPUFEATURE(MSRLIST, 10*32+27) /* {RD,WR}MSRLIST instructions */ +XEN_CPUFEATURE(MSRLIST, 10*32+27) /*s {RD,WR}MSRLIST instructions */ XEN_CPUFEATURE(NO_INVD, 10*32+30) /* INVD instruction unusable */ XEN_CPUFEATURE(MOVRS, 10*32+31) /*a MOV-read-shared instructions */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -283,7 +283,7 @@ def crunch_numbers(state): # NO_LMSL indicates the absense of Long Mode Segment Limits, which # have been dropped in hardware. LM: [CX16, PCID, LAHF_LM, PAGE1GB, PKU, NO_LMSL, AMX_TILE, CMPCCXADD, - LKGS, MOVRS], + LKGS, MOVRS, MSRLIST], # AMD K6-2+ and K6-III processors shipped with 3DNow+, beyond the # standard 3DNow in the earlier K6 processors. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:23:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383132.1626388 (Exim 4.92) (envelope-from ) id 1wrXqC-0005JD-F4; Wed, 05 Aug 2026 09:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383132.1626388; Wed, 05 Aug 2026 09:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXqC-0005J6-Ay; Wed, 05 Aug 2026 09:23:12 +0000 Received: by outflank-mailman (input) for mailman id 1383132; Wed, 05 Aug 2026 09:23:10 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXqA-0005Im-LL for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:23:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXqA-003xnS-29 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:23:10 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7300fc-e002-0a2a0a5209dd-0a2a4504c0fc-20 for ; Wed, 05 Aug 2026 11:23:10 +0200 Received: from [209.85.221.45] (helo=mail-wr1-f45.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7300fd-b57f-0a2a45040019-d155dd2dacf7-3 for ; Wed, 05 Aug 2026 11:23:09 +0200 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso360398f8f.0 for ; Wed, 05 Aug 2026 02:23:09 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfd9f74sm7511626f8f.4.2026.08.05.02.23.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:23:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921789; x=1786526589; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=2SIGc7gedCikC6tD+F90xKM08ODZSCL6uvs5Cbn5Yv0=; b=HozyeeAAj38rSAgoH2Q+CArAhkYnlBpXgnTXYF63KSiYVy8xQevs6KQ3XlJPyxPj5s mWBkRqLeacdR/tL/3u234Ux/3q8f0+zqbXEYJnTCCwM7RDCwEKdOI+Ybr4UvXA8qCwNC OK9XsTkH06Sk969ZuJG6xbwiK3k7HDZQB2Q8jRwvt+TOWyHCJLHW8KrNVGr5oZLsqLu/ BoWATxHYCOZgj5APo90dYhKXbfcorvJdpcZiPvRK/kgJHwO3qWDDmLODshl6Qn9DYtea FsDBHJS1llqLrv9ASiYv8l6kKu5XHJVugzm9d79cU+Dbhg0o4U7z0HI1snK2yKZpTVCl fxrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921789; x=1786526589; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=2SIGc7gedCikC6tD+F90xKM08ODZSCL6uvs5Cbn5Yv0=; b=DWj6Jjyxq0r7sOYQU+X3+WtkA9PNrsxP7K9DNTAJmXwnh4OMQrAeJ2hSxpqQS39cEm jM0ncbRX/UqR7iTLQx6EFa9h+BNXh3oNFberTn86croXhslBFIgSqxCcyWxFzlriCwth w00HGIe9aKIbhtwqjhfA/PDbFeoCNeNvmd5Z69p2N5nZcYmjiGT79sB6fL2D8HAZq7nk tTHOucCvkvqWXEcOw563hnIa+FPvvEJn1q4TnMPP5bK3ODvijMsHKjWgXdWmy12kYbnS IBVwo4225j1eyb1Vwg5dJb+aLA6SPAsdv28jhCKt/iqQ86L/eQD8CFn4uD4Q4xUbPNEL sGsQ== X-Gm-Message-State: AOJu0Yy9f1490YIJu76FdnO5SaQzXzK57CyQFafu7kNhZiMIIgq8Yrvq 0TgCTXNY100JvgnQDxIYp2Kgt9Xp81Fp/XrJc2AiRlZ93KJRHCzV6jljv9jVsT8mmxJH/MmDa/q SnEQpKA== X-Gm-Gg: AR+sD10kJ7/wYwb10cNq4Vd5rD0sgM7dGiT6KOL4o4okU6ufvdGEPoOtztQ2TIdz+oW Gj0CqWm1L1c1qhphT6UOSVUpjfPlNu6zswYPpmTBmew6fp9iKtW3u659FrJDF74RWzKeFX1DSP4 zB4duh15ZTVaH3Wce4tLvjb7t2tXKtt8ej1NpFDeD/PIXrfIUAuLKSdd6vlWl/rRfeH2wCcPpPM VzM9LmiAT42uOE+uLTnXxmZOuking0Z7OVPNCOPqGaIGLnPjVejIrDAYibIRdhSgpXVZSNnP+n5 lrSYwMj9lc8/zqYdukP1KiGchCBJ7HfcfB1bi4eOq0T02BDiicqpFoX2fdqI3EHvyRzgUbC2WNc +reKCnndBYtjQ4S2JISIqFOQbfuW9NPM5ydWCS8InP/+CkByx1XLpL6UrTeDStrShOrdN3p0iPo CsNu6Ri8DmSbQVBByfRGY+VT9iXWOplVuCFGK5GGduV0u+lrPg37PgSEYJgpBrtvHTHupKGRLgO eGZD7bcEBsLa7Evh0aW7bQpmsl0yezuPcsvdDzLMa1cyvJeIDQk X-Received: by 2002:a5d:5541:0:b0:47a:b86f:3ed1 with SMTP id ffacd0b85a97d-47fec62bacamr6533357f8f.21.1785921788871; Wed, 05 Aug 2026 02:23:08 -0700 (PDT) Message-ID: <5cd53809-9762-4187-85e5-56a6a6d37a94@suse.com> Date: Wed, 5 Aug 2026 11:23:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v10 2/6] x86emul: support USER-MSR instructions From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1785921789-C3AC0B50-3A53D68A/0/0 X-purgate-type: clean X-purgate-size: 18726 While UWRMSR probably isn't of much use as long as we don't support UINTR, URDMSR may well be useful to guests even without that (depending on what OSes are willing to permit access to). Since the two VEX encodings introduce a lonely opcode point in map 7, for now don't bother introducing a full 256-entry table. In the test harness use the UINTR_TIMER MSR despite the UINTR and UTMR features being removed from the architecture. Using UARCH_MISC_CTL would constrain usable values overly much. Signed-off-by: Jan Beulich --- The retaining of (possible) #PF from the bitmap access is "speculative" (the spec doesn't mention #PF as a possible exception; conceivably this might also need converting to #GP). I'm a little wary of the "MSRs Writeable by UWRMSR" table that the spec has, and that our code thus also enforces: As new MSRs are added to that table, we'll need piecemeal updates to that switch() statement. The forced setting of cpu_policy.feat.utmr could likely be done globally, i.e. early in main(). Limiting its scope is merely "just in case". Thoughts? --- v10: Use msr-index.h constants also in x86_emulate(). Re-base. v8: Switch to using fallthrough pseudo-keyword. Re-base. v7.1: Add MSR-specific feature checks for UWRMSR (incl the UTMR feature bit and its overriding in the test harness). v7: Add missing vcpu_must_have() and override in emul_test_init(). Use MSR constants even more. v6: Add MSR_UINTR_TIMER to header. Use MSR constants in test harness. Re-base. v5: Correct ModR/M.reg check for VEX-encoded forms. Cosmetic test harness adjustment. Re-base. v4: MSR index input regs are 64-bit (albeit only the APX spec has it this way for now). v3: New. --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -867,7 +867,9 @@ static const struct { { { 0xf6 }, { 2, 2 }, T, R, pfx_66 }, /* adcx */ { { 0xf6 }, { 2, 2 }, T, R, pfx_f3 }, /* adox */ { { 0xf8 }, { 2, 2 }, F, W, pfx_66 }, /* movdir64b */ + { { 0xf8, 0xc0 }, { 0, 2 }, F, N, pfx_f3 }, /* uwrmsr */ { { 0xf8 }, { 2, 2 }, F, W, pfx_f3 }, /* enqcmds */ + { { 0xf8, 0xc0 }, { 0, 2 }, F, N, pfx_f2 }, /* urdmsr */ { { 0xf8 }, { 2, 2 }, F, W, pfx_f2 }, /* enqcmd */ { { 0xf9 }, { 2, 2 }, F, W }, /* movdiri */ }; @@ -1519,6 +1521,9 @@ static const struct vex { { { 0xde }, 3, T, R, pfx_66, W0, L0 }, /* vsm3rnds2 */ { { 0xdf }, 3, T, R, pfx_66, WIG, Ln }, /* vaeskeygenassist */ { { 0xf0 }, 3, T, R, pfx_f2, Wn, L0 }, /* rorx */ +}, vex_map7[] = { + { { 0xf8, 0xc0 }, 6, F, N, pfx_f3, W0, L0 }, /* uwrmsr */ + { { 0xf8, 0xc0 }, 6, F, N, pfx_f2, W0, L0 }, /* urdmsr */ }; static const struct { @@ -1528,6 +1533,10 @@ static const struct { { vex_0f, ARRAY_SIZE(vex_0f) }, { vex_0f38, ARRAY_SIZE(vex_0f38) }, { vex_0f3a, ARRAY_SIZE(vex_0f3a) }, + { NULL, 0 }, /* map 4 */ + { NULL, 0 }, /* map 5 */ + { NULL, 0 }, /* map 6 */ + { vex_map7, ARRAY_SIZE(vex_map7) }, }; static const struct xop { @@ -2426,7 +2435,8 @@ void predicates_test(void *instr, struct if ( vex[x].tbl[t].w == WIG || (vex[x].tbl[t].w & W0) ) { - memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + memcpy(ptr, vex[x].tbl[t].opc, + MIN(vex[x].tbl[t].len, ARRAY_SIZE(vex->tbl->opc))); if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L0) ) do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), @@ -2436,7 +2446,8 @@ void predicates_test(void *instr, struct if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L1) ) { ptr[-1] |= 4; - memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + memcpy(ptr, vex[x].tbl[t].opc, + MIN(vex[x].tbl[t].len, ARRAY_SIZE(vex->tbl->opc))); do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), vex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, @@ -2447,7 +2458,8 @@ void predicates_test(void *instr, struct if ( vex[x].tbl[t].w == WIG || (vex[x].tbl[t].w & W1) ) { ptr[-1] = 0xf8 | vex[x].tbl[t].pfx; - memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + memcpy(ptr, vex[x].tbl[t].opc, + MIN(vex[x].tbl[t].len, ARRAY_SIZE(vex->tbl->opc))); if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L0) ) do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), @@ -2457,7 +2469,8 @@ void predicates_test(void *instr, struct if ( vex[x].tbl[t].l == LIG || (vex[x].tbl[t].l & L1) ) { ptr[-1] |= 4; - memcpy(ptr, vex[x].tbl[t].opc, vex[x].tbl[t].len); + memcpy(ptr, vex[x].tbl[t].opc, + MIN(vex[x].tbl[t].len, ARRAY_SIZE(vex->tbl->opc))); do_test(instr, vex[x].tbl[t].len + ((void *)ptr - instr), vex[x].tbl[t].modrm ? (void *)ptr - instr + 1 : 0, --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -675,6 +675,7 @@ static int blk( #ifdef __x86_64__ static unsigned long gs_base, gs_base_shadow; +static unsigned long uintr_timer; #endif static int read_segment( @@ -704,6 +705,15 @@ static int write_segment( return X86EMUL_OKAY; } + +static const uint8_t __attribute__((aligned(0x1000))) umsr_bitmap[0x1000] = { +#define RD(msr) [(msr) >> 3] = 1 << ((msr) & 7) +#define WR(msr) [0x800 + ((msr) >> 3)] = 1 << ((msr) & 7) + RD(MSR_IA32_APERF), + WR(MSR_UINTR_TIMER), +#undef WR +#undef RD +}; #endif static int read_msr( @@ -713,10 +723,22 @@ static int read_msr( { switch ( reg ) { +#ifdef __x86_64__ + case MSR_USER_MSR_CTL: + *val = (unsigned long)umsr_bitmap | 1; + return X86EMUL_OKAY; +#endif + case MSR_BARRIER: *val = 0; return X86EMUL_OKAY; + case MSR_IA32_APERF: +#define APERF_LO_VALUE 0xAEAEAEAE +#define APERF_HI_VALUE 0xEAEAEAEA + *val = ((uint64_t)APERF_HI_VALUE << 32) | APERF_LO_VALUE; + return X86EMUL_OKAY; + case MSR_EFER: *val = ctxt->addr_size > 32 ? EFER_LME | EFER_LMA : 0; return X86EMUL_OKAY; @@ -753,6 +775,12 @@ static int write_msr( { switch ( reg ) { + case MSR_UINTR_TIMER: + if ( ctxt->addr_size < 64 ) + break; + uintr_timer = val; + return X86EMUL_OKAY; + case MSR_GS_BASE: if ( ctxt->addr_size < 64 || !is_canonical_address(val) ) break; @@ -1481,6 +1509,68 @@ int main(int argc, char **argv) (gs_base != 0x0000222244446666UL) || (gs_base_shadow != 0x0000111122224444UL) ) goto fail; + printf("okay\n"); + + printf("%-40s", "Testing urdmsr %rdx,%rcx..."); + instr[0] = 0xf2; instr[1] = 0x0f; instr[2] = 0x38; instr[3] = 0xf8; instr[4] = 0xd1; + regs.rip = (unsigned long)&instr[0]; + regs.rdx = MSR_IA32_APERF; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[5]) || + (regs.rcx != (((uint64_t)APERF_HI_VALUE << 32) | APERF_LO_VALUE)) ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing urdmsr $MSR_IA32_APERF,%rdx..."); + instr[0] = 0xc4; instr[1] = 0xe7; instr[2] = 0x7b; instr[3] = 0xf8; instr[4] = 0xc2; + *(uint32_t *)&instr[5] = MSR_IA32_APERF; + regs.rip = (unsigned long)&instr[0]; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[9]) || + (regs.rdx != (((uint64_t)APERF_HI_VALUE << 32) | APERF_LO_VALUE)) ) + goto fail; + printf("okay\n"); + + /* Our write_msr() knows of MSR_UINTR_TIMER. */ + i = cpu_policy.feat.utmr; + cpu_policy.feat.utmr = true; + + printf("%-40s", "Testing uwrmsr %rdi,%rsi..."); + instr[0] = 0xf3; instr[1] = 0x0f; instr[2] = 0x38; instr[3] = 0xf8; instr[4] = 0xf7; + regs.rip = (unsigned long)&instr[0]; + regs.rsi = MSR_UINTR_TIMER; + regs.rdi = 0x0011223344556677UL; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[5]) || + (uintr_timer != 0x0011223344556677UL) ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing uwrmsr %rsi,$MSR_UINTR_TIMER..."); + instr[0] = 0xc4; instr[1] = 0xe7; instr[2] = 0x7a; instr[3] = 0xf8; instr[4] = 0xc6; + *(uint32_t *)&instr[5] = MSR_UINTR_TIMER; + regs.rip = (unsigned long)&instr[0]; + regs.rsi = 0x8877665544332211UL; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[9]) || + (uintr_timer != 0x8877665544332211UL) ) + goto fail; + printf("okay\n"); + + cpu_policy.feat.utmr = i; + + printf("%-40s", "Testing uwrmsr %rsi,$MSR_UARCH_MISC_CTRL..."); + *(uint32_t *)&instr[5] = MSR_UARCH_MISC_CTRL; + regs.rip = (unsigned long)&instr[0]; + regs.rsi = 0; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_EXCEPTION) || + (regs.rip != (unsigned long)&instr[0]) ) + goto fail; emulops.write_msr = NULL; #endif --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -67,6 +67,7 @@ bool emul_test_init(void) cpu_policy.feat.lkgs = true; cpu_policy.feat.wrmsrns = true; cpu_policy.feat.msrlist = true; + cpu_policy.feat.user_msr = true; cpu_policy.extd.clzero = true; if ( cpu_has_xsave ) --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -24,6 +24,10 @@ #define APIC_BASE_ENABLE (_AC(1, ULL) << 11) #define APIC_BASE_ADDR_MASK _AC(0x000ffffffffff000, ULL) +#define MSR_USER_MSR_CTL 0x0000001c +#define USER_MSR_ENABLE (_AC(1, ULL) << 0) +#define USER_MSR_ADDR_MASK 0xfffffffffffff000ULL + #define MSR_BARRIER 0x0000002f #define MSR_TEST_CTRL 0x00000033 @@ -209,6 +213,8 @@ #define MCU_CONTROL_DIS_MCU_LOAD (_AC(1, ULL) << 1) #define MCU_CONTROL_EN_SMM_BYPASS (_AC(1, ULL) << 2) +#define MSR_UINTR_TIMER 0x00001b00 + #define MSR_UARCH_MISC_CTRL 0x00001b01 #define UARCH_CTRL_DOITM (_AC(1, ULL) << 0) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -905,7 +905,7 @@ decode_0f38(struct x86_emulate_state *s, case 0x00 ... 0x89: case 0x8c ... 0xef: case 0xf2 ... 0xf5: - case 0xf7 ... 0xf8: + case 0xf7: case 0xfa ... 0xff: s->op_bytes = 0; /* fall through */ @@ -957,6 +957,18 @@ decode_0f38(struct x86_emulate_state *s, case X86EMUL_OPC_VEX_F2(0, 0xf7): /* shrx */ break; + case 0xf8: + if ( s->modrm_mod == 3 ) /* u{rd,wr}msr */ + { + s->desc = DstMem | SrcReg | Mov; + s->op_bytes = 8; + s->simd_size = simd_none; + } + else /* movdir64b / enqcmd{,s} */ + s->op_bytes = 0; + ctxt->opcode |= MASK_INSR(s->vex.pfx, X86EMUL_OPC_PFX_MASK); + break; + default: s->op_bytes = 0; break; @@ -1255,6 +1267,16 @@ int x86emul_decode(struct x86_emulate_st */ d = twobyte_table[0x38].desc; break; + + case vex_map7: + opcode |= MASK_INSR(7, X86EMUL_OPC_EXT_MASK); + /* + * No table lookup here for now, as there's only a single + * opcode point (0xf8) populated in map 7. + */ + d = DstMem | SrcImm | ModRM | Mov; + s->op_bytes = 8; + break; } } else if ( s->ext < ext_8f08 + ARRAY_SIZE(xop_table) ) @@ -1611,6 +1633,7 @@ int x86emul_decode(struct x86_emulate_st s->simd_size = ext8f09_table[b].simd_size; break; + case ext_map7: case ext_8f08: case ext_8f0a: /* @@ -1825,6 +1848,7 @@ int x86emul_decode(struct x86_emulate_st case ext_map5: case ext_map6: + case ext_map7: case ext_8f09: case ext_8f0a: break; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -202,6 +202,7 @@ enum vex_opcx { vex_0f3a, evex_map5 = 5, evex_map6, + vex_map7, }; enum vex_pfx { @@ -259,6 +260,7 @@ struct x86_emulate_state { ext_0f3a = vex_0f3a, ext_map5 = evex_map5, ext_map6 = evex_map6, + ext_map7 = vex_map7, /* * For XOP use values such that the respective instruction field * can be used without adjustment. @@ -617,6 +619,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) #define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) #define vcpu_has_avx_vnni_int16() (ctxt->cpuid->feat.avx_vnni_int16) +#define vcpu_has_user_msr() (ctxt->cpuid->feat.user_msr) #define vcpu_must_have(feat) \ generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -7086,10 +7086,74 @@ x86_emulate( state->simd_size = simd_none; break; - case X86EMUL_OPC_F2(0x0f38, 0xf8): /* enqcmd r,m512 */ - case X86EMUL_OPC_F3(0x0f38, 0xf8): /* enqcmds r,m512 */ + case X86EMUL_OPC_F3(0x0f38, 0xf8): /* enqcmds r,m512 / uwrmsr r64,r32 */ + case X86EMUL_OPC_F2(0x0f38, 0xf8): /* enqcmd r,m512 / urdmsr r32,r64 */ + if ( ea.type == OP_MEM ) + goto enqcmd; + imm1 = src.val; + fallthrough; + case X86EMUL_OPC_VEX_F3(7, 0xf8): /* uwrmsr r64,imm32 */ + case X86EMUL_OPC_VEX_F2(7, 0xf8): /* urdmsr imm32,r64 */ + generate_exception_if(!mode_64bit() || ea.type != OP_REG, X86_EXC_UD); + generate_exception_if(vex.l || vex.w, X86_EXC_UD); + generate_exception_if(vex.opcx && ((modrm_reg & 7) || vex.reg != 0xf), + X86_EXC_UD); + vcpu_must_have(user_msr); + fail_if(!ops->read_msr); + if ( ops->read_msr(MSR_USER_MSR_CTL, &msr_val, ctxt) != X86EMUL_OKAY ) + { + x86_emul_reset_event(ctxt); + msr_val = 0; + } + generate_exception_if(!(msr_val & USER_MSR_ENABLE), X86_EXC_UD); + generate_exception_if(imm1 & ~0x3fff, X86_EXC_GP, 0); + + /* Check the corresponding bitmap. */ + ea.mem.off = msr_val & ~0xfff; + if ( vex.pfx != vex_f2 ) + ea.mem.off += 0x800; + ea.mem.off += imm1 >> 3; + if ( (rc = ops->read(x86_seg_sys, ea.mem.off, &b, 1, + ctxt)) != X86EMUL_OKAY ) + goto done; + generate_exception_if(!(b & (1 << (imm1 & 7))), X86_EXC_GP, 0); + + /* Carry out the actual MSR access. */ + if ( vex.pfx == vex_f2 ) + { + /* urdmsr */ + if ( (rc = ops->read_msr(imm1, &msr_val, ctxt)) != X86EMUL_OKAY ) + goto done; + dst.val = msr_val; + ASSERT(dst.type == OP_REG); + dst.bytes = 8; + } + else + { + /* uwrmsr */ + switch ( imm1 ) + { + case MSR_UINTR_TIMER: + generate_exception_if(!cp->feat.utmr, X86_EXC_GP, 0); + break; + + case MSR_UARCH_MISC_CTRL: + generate_exception_if(!cp->arch_caps.doitm, X86_EXC_GP, 0); + break; + + default: + generate_exception(X86_EXC_GP, 0); + } + fail_if(!ops->write_msr); + if ( (rc = ops->write_msr(imm1, dst.val, ctxt, + true)) != X86EMUL_OKAY ) + goto done; + dst.type = OP_NONE; + } + break; + + enqcmd: vcpu_must_have(enqcmd); - generate_exception_if(ea.type != OP_MEM, X86_EXC_UD); generate_exception_if(vex.pfx != vex_f2 && !mode_ring0(), X86_EXC_GP, 0); src.val = truncate_ea(*dst.reg); generate_exception_if(!is_aligned(x86_seg_es, src.val, 64, ctxt, ops), --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -360,7 +360,9 @@ XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32 XEN_CPUFEATURE(AVX_NE_CONVERT, 15*32+ 5) /*A AVX-NE-CONVERT Instructions */ XEN_CPUFEATURE(AMX_COMPLEX, 15*32+ 8) /* AMX Complex Instructions */ XEN_CPUFEATURE(AVX_VNNI_INT16, 15*32+10) /*A AVX-VNNI-INT16 Instructions */ +XEN_CPUFEATURE(UTMR, 15*32+13) /* User Timer */ XEN_CPUFEATURE(PREFETCHI, 15*32+14) /*A PREFETCHIT{0,1} Instructions */ +XEN_CPUFEATURE(USER_MSR, 15*32+15) /* U{RD,WR}MSR Instructions */ XEN_CPUFEATURE(UIRET_UIF, 15*32+17) /* UIRET updates UIF */ XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow Stacks safe to use */ XEN_CPUFEATURE(SLSM, 15*32+24) /* Static Lockstep Mode */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -283,7 +283,7 @@ def crunch_numbers(state): # NO_LMSL indicates the absense of Long Mode Segment Limits, which # have been dropped in hardware. LM: [CX16, PCID, LAHF_LM, PAGE1GB, PKU, NO_LMSL, AMX_TILE, CMPCCXADD, - LKGS, MOVRS, MSRLIST], + LKGS, MOVRS, MSRLIST, USER_MSR], # AMD K6-2+ and K6-III processors shipped with 3DNow+, beyond the # standard 3DNow in the earlier K6 processors. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:23:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:23:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383136.1626396 (Exim 4.92) (envelope-from ) id 1wrXqU-0005kG-LC; Wed, 05 Aug 2026 09:23:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383136.1626396; Wed, 05 Aug 2026 09:23:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXqU-0005k8-Hl; Wed, 05 Aug 2026 09:23:30 +0000 Received: by outflank-mailman (input) for mailman id 1383136; Wed, 05 Aug 2026 09:23:29 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXqT-0005iN-AD for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:23:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXqS-00HWZS-N8 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:23:28 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a730109-5cb7-0a2a0a5109dd-0a2a4505dd44-18 for ; Wed, 05 Aug 2026 11:23:28 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730110-4cb1-0a2a45050019-d1558034a518-3 for ; Wed, 05 Aug 2026 11:23:28 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-495437bb891so7358885e9.1 for ; Wed, 05 Aug 2026 02:23:28 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfd9f74sm7513106f8f.4.2026.08.05.02.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:23:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921808; x=1786526608; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jQFpsonGz2MRoYUli6F1ue9CHvjmUgngklOxuIXC4is=; b=GhHNJ/0eAhELRPNZoQGm69d1qPcI2ZValB7n3/xOURDlbD5nwTLA+iCEG28F3RoDxO fn2kwzl7+CBt7wRPnAJ9gsG3JLILLIz9cJ2x4nlqwWAs2mH0mg35FbhPe63xclTmEgsO d25cMTpj+9ktimI+N18Gep6hmZ5qjDzk5NeqPeRHXyABwuvtzRDBmADQdqUjTmAWLkLi qur1U9RmXBvv20GkawlfTGC8tCbuhdKAzTWQF65VCp+pV/vrJ+b/bavgWc/grPWviVu0 RYSPA3tGKj2zEsIaegG86CgT/zkDpR+Rs2O6GZYzq6EPRUl0584S6BrcjUYW9qNbgkq5 NIZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921808; x=1786526608; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=jQFpsonGz2MRoYUli6F1ue9CHvjmUgngklOxuIXC4is=; b=JimxecVc3J+r6dA8HJfSkS0JILau3yj5KYaWm4iAz+ux2cwP43V9knCS7VfBU5K3gN AiQGK4JBwj4P6UPFfRntwx5qJw1j7/u237ULuc4o+XJCssgWB8rhYpDit+Wy3HKZjo4b fbCz1aMHCCIebyAnrM1EYsP7URMFBE+cSHeowONMkEXcHG70xMX9YMgIgBEWH16QVzTs HJI7/mX29uqKKNA7iX7iTTiQW3/jmZjocw6b4MXOobQ06hGZKvtnjN1cdy95hp0nIhiv JIqqpP51AgErEIjWLeJcCefrNRiqTa/C7xBHKFWccT8rMUfjDjIeS+Swq9T3huGzUYCZ 9ANw== X-Gm-Message-State: AOJu0Yz4tEgiak8lRvV6FEb6H9d86yea66tatBSqq9zz9svTgkk2kxtY SL2Mx26GEtoJbMKEP6WWxNfEEp/NQsQJ6D5pXUDnMEwjVl1/W97VSVf7SKDsVnCmbdXWlis0Xlh efkFfUg== X-Gm-Gg: AR+sD11Ys2AZvuD0yIr2200ilccmKItrFG3Q9UAzZdCUK3qf6AL9MUtpaWcYLDxmCEz vRyq4m4VMFAs/AdFGW12T6bJghrHZrgJvdpSIGeMkw/aOmS0Q1ege9Mec8HinqJmK2rE+uTAe+N xvMXkjKOd3OGbg1xEzPibCatJccsR8d0Dxwq7j6piX6/o0PlNQxxF1eUTiwxGYp3YDcYOCT5OEQ /3kuw83aCHOOTM6mmQ2Ndpu2IupVg2afdB4CCu6rWRgmnV8hfbfer4/q2KAxLSaNvUkj6yMyveP WPlPsJZsmZMpnIZbpOMQ6qfnwfJeS5sCW57MmOP7lxB0FVG9r2cNu/oE2XQDIIdLtchKldkMg3U t493L7bVVe0LhIdTxER7HeMj1tQFULQ5HuVFcCtnFUiq4m91B0f/DvJ9QDpcZvRKjWMSancpH4i vJh6goXLDItLjFMMKlVKvWPQX3DBGqJfx2XHxTdTUy/wRSwNtleFCXH0JfLnujpUpSRBuBvn9PX osrQRll+GjHN1FIR7p9dnDzFTtdfVOic2bmKyjTaGT6IwGcHwKb X-Received: by 2002:a7b:ce81:0:b0:495:41ea:f6e with SMTP id 5b1f17b1804b1-4994a107e2amr161122715e9.8.1785921807917; Wed, 05 Aug 2026 02:23:27 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 11:23:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v10 3/6] x86/cpu-policy: re-arrange no-VMX logic From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1785921808-F54AC2A1-E5632010/0/0 X-purgate-type: clean X-purgate-size: 1478 Move the PKS check into an "else" for the corresponding "if()", such that further adjustments (like for USER_MSR) can easily be put there as well. Signed-off-by: Jan Beulich --- v5: Re-base. v4: New. --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -823,19 +823,20 @@ static void __init calculate_hvm_max_pol if ( !cpu_has_vmx_xsaves ) __clear_bit(X86_FEATURE_XSAVES, fs); } + else + { + /* + * Xen doesn't use PKS, so the guest support for it has opted to not use + * the VMCS load/save controls for efficiency reasons. This depends on + * the exact vmentry/exit behaviour, so don't expose PKS in other + * situations until someone has cross-checked the behaviour for safety. + */ + __clear_bit(X86_FEATURE_PKS, fs); + } if ( !cpu_has_vmx_msrlist ) __clear_bit(X86_FEATURE_MSRLIST, fs); - /* - * Xen doesn't use PKS, so the guest support for it has opted to not use - * the VMCS load/save controls for efficiency reasons. This depends on - * the exact vmentry/exit behaviour, so don't expose PKS in other - * situations until someone has cross-checked the behaviour for safety. - */ - if ( !cpu_has_vmx ) - __clear_bit(X86_FEATURE_PKS, fs); - /* * Make adjustments to possible (nested) virtualization features exposed * to the guest From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:24:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:24:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383150.1626404 (Exim 4.92) (envelope-from ) id 1wrXrB-0006Mj-0z; Wed, 05 Aug 2026 09:24:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383150.1626404; Wed, 05 Aug 2026 09:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXrA-0006Mc-UX; Wed, 05 Aug 2026 09:24:12 +0000 Received: by outflank-mailman (input) for mailman id 1383150; Wed, 05 Aug 2026 09:24:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXr9-0006MK-RU for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:24:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXr9-00Bfeu-4Y for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:24:11 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a730139-5cb7-0a2a0a5109dd-0a2a4502e53e-6 for ; Wed, 05 Aug 2026 11:24:11 +0200 Received: from [209.85.221.48] (helo=mail-wr1-f48.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73013a-6ca4-0a2a45020019-d155dd30e1ba-3 for ; Wed, 05 Aug 2026 11:24:11 +0200 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-47de0093c42so541686f8f.3 for ; Wed, 05 Aug 2026 02:24:11 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfd9f74sm7517005f8f.4.2026.08.05.02.24.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:24:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921850; x=1786526650; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=/Igknh5+Nb88vcTcf1O5GexgYDuFGQ/RpiAXNqKISPo=; b=edu+C/cPcctMr8EOIquuOT/3qc4Dm9rn7aFRGcQNgaMwrohxGGr7LycEakeq6CypCe Jg2OzyGJh8z1TyQCNcur7/chqzwKKamffuEgShV3zb38tUAclh6Ea6PYs+yroI6AjYOO YkYuszLvWcVJm8cbY1LzgBWUhrQ6Oiz41jcV3nTCtowIxOKjjd3sc8DKybxgdcQ6YoH+ CfCpa6tklkQZf9ZORP2sq3/53APyHji0hINyAHMx48Sm+gDpKKRGhx52+JprADoLEc8C hmzxz6ArSuCv/FUR+f6x1xGUI0dkX+jOaxWPznuC/AmMRFd1X53x/0pphIzA8r5SShfh aOPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921850; x=1786526650; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=/Igknh5+Nb88vcTcf1O5GexgYDuFGQ/RpiAXNqKISPo=; b=sFHVGdM4uuODDwwvQbuyjv6tdIpW8qsohanIeQLcIWCCT5AaOCycaO6MMZ9ED9b6Bb r9aLdgBBnprlUE3zhZSNVThBe7NvQuzyG6eN8xgeCDGSja5J/oswMeHoAttd5TY3Avp8 +EMk9HZzUvUl2nL0u7tr1DKcb+6n8pC4cjdylm2SA76LwuSdAd2w0JW4hs6fhgCICGVJ 5k+UvWSUDvWZ3Vgjw8rGXo7ao53onhw/w86xAq6WEwAWeYgGbhaujet44cWoY+BMzpnx yjyTaT0HlxyV02XBzx6oonvfL2xLBHFjmxtKumw4gumD+5Mab6kxO4tX8YrXUc+uLwyM WRkQ== X-Gm-Message-State: AOJu0YyN79vTOlKqpMnWM9P1Uihhni1rnwYW6XEwCi4EzY5+Dj6CptyL 2yoQrOZkjISZ3tpwODDOwyzzc6LSMOKX2ARvbAsgXMKtBGGPNnOixAizsWJk0GP1anQL3qJFcEG i0jJ8kA== X-Gm-Gg: AR+sD12V+PZaXNWX1xZY1NdZc9cAn972CCcTJYd6WJAh5izrJYVbHvOlFfrBmfrvjop OZNLPAKS38ozasf+0ouSV7oDk3nkzVTvl0nJkr18vEbyfHhJ+UyfB4VhSkQE5wclFv+DAauoXi7 VY8N4x6Zzv7gBw70KRHDJGUUoi9ksG83HtAx+9Dw4dqSaysW9E1uItRUtR7UW1hO1wkskIHy4yl YW6RfjUvI+bYcIg1aLEMBgG9bAOmeVxyNgKxZ9VXQyDvUdwt6xcRJ/tPlaSOAjGrqj/8sP+jHSf 8AIhivHJgELWv3mbD5YY969tDe0r6WHIIkAyfcGALyXf62Q7+aFxZIGfQSyYtYP8vCd0QCLJAnP Ff98efXVOoDmCz0NQcymf5ydT4bfHBxwOUwTGWVHeAzkEX7qO0DbGACHJpMnIic5tiSTkWRqkBF vyZG2k0Fpoyezk+FEQQ6rUB6qKDXw86VO0td4Emaf4zaCsQzWtjfjSY6ujJ7UeIBQyhTWpNydW/ aSzRZzZUIar/1TCCDWNtKM9mBv+OIekCvPzE+5Lk1NbdDTMx5XgdL1ZlJtgWds= X-Received: by 2002:adf:e992:0:b0:47f:c648:e280 with SMTP id ffacd0b85a97d-47fec519539mr7084576f8f.18.1785921850450; Wed, 05 Aug 2026 02:24:10 -0700 (PDT) Message-ID: <87a7505c-4883-48b7-9bc0-60444b9b6b05@suse.com> Date: Wed, 5 Aug 2026 11:24:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v10 4/6] VMX: support USER-MSR From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1785921851-674BE2AC-85FAD874/0/0 X-purgate-type: clean X-purgate-size: 10566 Hook up the new VM exit codes and handle guest accesses, context switch, and save/restore. At least for now don't allow the guest direct access to the control MSR; this may need changing if guests were to frequently access it (e.g. on their own context switch path). While there also correct a one-off in union ldt_or_tr_instr_info's comment. Signed-off-by: Jan Beulich --- Needing to change two places in hvm.c continues to be unhelpful; I recall I already did forget to also adjust hvm_load_cpu_msrs() for XFD. Considering that MSRs typically arrive in the order the table has it, couldn't we incrementally look up the incoming MSR index there, falling back to a full lookup only when the incremental lookup failed (and thus not normally re-iterating through the initial part of the array)? Said comment in union ldt_or_tr_instr_info is further odd (same for union gdt_or_idt_instr_info's) in that Instruction Information is only a 32-bit field. Hence bits 32-63 aren't undefined, but simply don't exist. RFC: The wee attempt to "deal" with nested is likely wrong, but I'm afraid I simply don't know where such enforcement would be done properly. Returning an error there is also commented out, for domain_cpu_policy_changed() returning void without "x86/xstate: re-size save area when CPUID policy changes" in place. --- v10: Replace __vmread() by vmread(). Add commentsto case labels in vmx_vmexit_handler(). Re-base. v9: Use wrmsrns(). Do renames where bits are also going to be used for MSR-IMM. Re-base. v8: Re-base. v5: Introduce user_msr_gpr(). v4: New. --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -832,6 +832,12 @@ static void __init calculate_hvm_max_pol * situations until someone has cross-checked the behaviour for safety. */ __clear_bit(X86_FEATURE_PKS, fs); + + /* + * Don't expose USER-MSR until it is known how (if at all) it is + * virtualized on SVM. + */ + __clear_bit(X86_FEATURE_USER_MSR, fs); } if ( !cpu_has_vmx_msrlist ) --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -452,6 +452,10 @@ void domain_cpu_policy_changed(struct do } } + /* Nested doesn't have the necessary processing, yet. */ + if ( nestedhvm_enabled(d) && p->feat.user_msr ) + return /* -EINVAL */; + for_each_vcpu ( d, v ) { cpu_policy_updated(v); --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1393,6 +1393,7 @@ static int cf_check hvm_load_cpu_xsave_s #define HVM_CPU_MSR_SIZE(cnt) offsetof(struct hvm_msr, msr[cnt]) static const uint32_t msrs_to_send[] = { + MSR_USER_MSR_CTL, MSR_SPEC_CTRL, MSR_INTEL_MISC_FEATURES_ENABLES, MSR_PKRS, @@ -1547,6 +1548,7 @@ static int cf_check hvm_load_cpu_msrs(st { int rc; + case MSR_USER_MSR_CTL: case MSR_SPEC_CTRL: case MSR_INTEL_MISC_FEATURES_ENABLES: case MSR_PKRS: --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -696,13 +696,18 @@ static void cf_check vmx_vcpu_destroy(st } /* - * To avoid MSR save/restore at every VM exit/entry time, we restore - * the x86_64 specific MSRs at domain switch time. Since these MSRs - * are not modified once set for para domains, we don't save them, - * but simply reset them to values set in percpu_traps_init(). + * To avoid MSR save/restore at every VM exit/entry time, we restore the + * x86_64 specific MSRs at vcpu switch time. Since these MSRs are not + * modified once set for para domains, we don't save them, but simply clear + * them or reset them to values set in percpu_traps_init(). */ -static void vmx_restore_host_msrs(void) +static void vmx_restore_host_msrs(const struct vcpu *v) { + const struct vcpu_msrs *msrs = v->arch.msrs; + + if ( msrs->user_msr_ctl.enable ) + wrmsrns(MSR_USER_MSR_CTL, 0); + /* No PV guests? No need to restore host SYSCALL infrastructure. */ if ( !IS_ENABLED(CONFIG_PV) ) return; @@ -760,6 +765,9 @@ static void vmx_restore_guest_msrs(struc if ( cp->feat.pks ) wrpkrs(msrs->pkrs); + + if ( msrs->user_msr_ctl.enable ) + wrmsrns(MSR_USER_MSR_CTL, msrs->user_msr_ctl.raw); } void vmx_update_cpu_exec_control(struct vcpu *v) @@ -1165,7 +1173,7 @@ static void cf_check vmx_ctxt_switch_fro } vmx_save_guest_msrs(v); - vmx_restore_host_msrs(); + vmx_restore_host_msrs(v); vmx_save_dr(v); if ( v->domain->arch.hvm.pi_ops.flags & PI_CSW_FROM ) @@ -4194,6 +4202,13 @@ static int vmx_handle_apic_write(void) return vlapic_apicv_write(current, exit_qualification & 0xfff); } +static unsigned int msr_imm_gpr(void) +{ + msr_imm_instr_info_t info = { .raw = vmread(VMX_INSTRUCTION_INFO) }; + + return info.gpr; +} + static void undo_nmis_unblocked_by_iret(void) { unsigned long guest_info; @@ -4697,6 +4712,41 @@ void asmlinkage vmx_vmexit_handler(struc hvm_inject_hw_exception(X86_EXC_GP, 0); break; + case EXIT_REASON_URDMSR: /* NB: User-MSR bitmap was checked by the CPU. */ + { + uint64_t msr_content = 0; + + switch ( hvm_msr_read_intercept(vmread(EXIT_QUALIFICATION), + &msr_content) ) + { + case X86EMUL_OKAY: + *decode_gpr(regs, msr_imm_gpr()) = msr_content; + update_guest_eip(); /* Safe: URDMSR */ + break; + + case X86EMUL_EXCEPTION: + hvm_inject_hw_exception(X86_EXC_GP, 0); + break; + } + break; + } + + case EXIT_REASON_UWRMSR: /* NB: User-MSR bitmap was checked by the CPU. */ + exit_qualification = vmread(EXIT_QUALIFICATION); + switch ( hvm_msr_write_intercept(exit_qualification, + *decode_gpr(regs, msr_imm_gpr()), + true) ) + { + case X86EMUL_OKAY: + update_guest_eip(); /* Safe: UWRMSR */ + break; + + case X86EMUL_EXCEPTION: + hvm_inject_hw_exception(X86_EXC_GP, 0); + break; + } + break; + case EXIT_REASON_VMXOFF: case EXIT_REASON_VMXON: case EXIT_REASON_VMCLEAR: --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -203,6 +203,8 @@ static inline void pi_clear_sn(struct pi #define EXIT_REASON_NOTIFY 75 #define EXIT_REASON_RDMSRLIST 78 #define EXIT_REASON_WRMSRLIST 79 +#define EXIT_REASON_URDMSR 80 +#define EXIT_REASON_UWRMSR 81 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* @@ -578,8 +580,18 @@ typedef union ldt_or_tr_instr_info { base_reg_invalid :1, /* bit 27 - Base register invalid */ instr_identity :1, /* bit 28 - 0:LDT, 1:TR */ instr_write :1, /* bit 29 - 0:store, 1:load */ - :34; /* bits 31:63 - Undefined */ + :34; /* bits 30:63 - Undefined */ }; } ldt_or_tr_instr_info_t; +/* VM-Exit instruction info for URDMSR and UWRMSR */ +typedef union msr_imm_instr_info { + unsigned long raw; + struct { + unsigned int :3, /* Bits 0:2 - Undefined */ + gpr :4, /* Bits 3:6 - Source/Destination register */ + :25; /* bits 7:31 - Undefined */ + }; +} msr_imm_instr_info_t; + #endif /* __ASM_X86_HVM_VMX_VMX_H__ */ --- a/xen/arch/x86/include/asm/guest-msr.h +++ b/xen/arch/x86/include/asm/guest-msr.h @@ -8,6 +8,20 @@ struct vcpu_msrs { /* + * 0x0000001c - MSR_USER_MSR_CTL + * + * Value is guest chosen, and always loaded in vcpu context. + */ + union { + uint64_t raw; + struct { + bool enable:1; + unsigned int :11; + unsigned long bitmap:52; + }; + } user_msr_ctl; + + /* * 0x00000048 - MSR_SPEC_CTRL * 0xc001011f - MSR_VIRT_SPEC_CTRL (if X86_FEATURE_AMD_SSBD) * --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 80 +#define VMX_PERF_EXIT_REASON_SIZE 82 #define VMEXIT_NPF_PERFC 166 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -278,6 +278,12 @@ int guest_rdmsr(struct vcpu *v, uint32_t *val = msrs->xss.raw; break; + case MSR_USER_MSR_CTL: + if ( !cp->feat.user_msr ) + goto gp_fault; + *val = msrs->user_msr_ctl.raw; + break; + case 0x40000000 ... 0x400001ff: if ( is_viridian_domain(d) ) { @@ -616,6 +622,19 @@ int guest_wrmsr(struct vcpu *v, uint32_t msrs->xss.raw = val; break; + case MSR_USER_MSR_CTL: + if ( !cp->feat.user_msr ) + goto gp_fault; + + if ( (val & ~(USER_MSR_ENABLE | USER_MSR_ADDR_MASK)) || + !is_canonical_address(val) ) + goto gp_fault; + + msrs->user_msr_ctl.raw = val; + if ( v == curr ) + wrmsrns(MSR_USER_MSR_CTL, val); + break; + case 0x40000000 ... 0x400001ff: if ( is_viridian_domain(d) ) { --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -362,7 +362,7 @@ XEN_CPUFEATURE(AMX_COMPLEX, 15*32 XEN_CPUFEATURE(AVX_VNNI_INT16, 15*32+10) /*A AVX-VNNI-INT16 Instructions */ XEN_CPUFEATURE(UTMR, 15*32+13) /* User Timer */ XEN_CPUFEATURE(PREFETCHI, 15*32+14) /*A PREFETCHIT{0,1} Instructions */ -XEN_CPUFEATURE(USER_MSR, 15*32+15) /* U{RD,WR}MSR Instructions */ +XEN_CPUFEATURE(USER_MSR, 15*32+15) /*s U{RD,WR}MSR Instructions */ XEN_CPUFEATURE(UIRET_UIF, 15*32+17) /* UIRET updates UIF */ XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow Stacks safe to use */ XEN_CPUFEATURE(SLSM, 15*32+24) /* Static Lockstep Mode */ From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:24:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:24:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383155.1626414 (Exim 4.92) (envelope-from ) id 1wrXrW-0006ou-90; Wed, 05 Aug 2026 09:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383155.1626414; Wed, 05 Aug 2026 09:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXrW-0006on-69; Wed, 05 Aug 2026 09:24:34 +0000 Received: by outflank-mailman (input) for mailman id 1383155; Wed, 05 Aug 2026 09:24:33 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXrV-0006oU-HA for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:24:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXrU-00HWng-U1 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:24:32 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a730150-e002-0a2a0a5209dd-0a2a450ccecc-2 for ; Wed, 05 Aug 2026 11:24:32 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730150-f479-0a2a450c0019-d155dd31e523-3 for ; Wed, 05 Aug 2026 11:24:32 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47fdd674e17so433959f8f.1 for ; Wed, 05 Aug 2026 02:24:32 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfe5d7csm7756543f8f.15.2026.08.05.02.24.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:24:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921872; x=1786526672; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Yh5sgqmpsiDgmmWKbLvnKvsyVo9fXTHQYMZ46x1tb84=; b=S13YAMA4Sq3UqVAGo2NUs01F4Db/yaayCQ0DugXLpk+haMa9504+qCWsIghznJgp4M FujhkJ3xfviyKy303eOU/AKomKe9M4dOTTwEyAhAKiNPHD2PY8vgQIEJi0HiRAZ33IHL UWIdhE9JGICCJ0yTzVUBHKc2lYJPPv6ZUZYc2wya/Bo/aUXhKpv6ktJWXsoyoiyoXeuh Ts+XHVGCYUbSLIaddn3qoQCZEe6RqRUoq/7l7qOEgNLw1p4ZYw54riv1HbTh/7FwE8eY fZBddbzRQKYGDXNTiridvoEmLi2oFvn0auYTlU6n3epIOdHpksZol6xWIZ6awTcPNfMh z2YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921872; x=1786526672; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Yh5sgqmpsiDgmmWKbLvnKvsyVo9fXTHQYMZ46x1tb84=; b=AN6kakfyv4KtavxfME1wy4dGWQfRc4GZpNr79pCPCVaMabpubb985eIKPILf1cJMgj f+uKW3ajxPFSy46ErJy3wGC9xxXem8Du6lQaHAQFDGOZG40b8o66er31T4pTtlJJVyEj VrlDrg/M0rDp2RfpoiYgdfrvFUwuEyqklGKUk6rgP6ZWzCKETkcnK9KAhv7Ds/Z5H51n a7GIdMt/Z4QzV18nAwe7fMWH8MIbYreKonrW8X1sIZ0p31vs30t5LLmfWBJzYpi+AfXa yWxJPmDvHlU55GROOvI17VuUG6rjcbDC/EIVYP8H9MihjnZ6ArMO92de0YPHgYrg1ZhG 1vmA== X-Gm-Message-State: AOJu0YxCbM6Rzh1lAmfyJ0K0SB73t2rHuUFD1iX0mDfXPdurrdcbwSEc FTRq7Um+4PUlytHEm0TmJQaGlTAWF+uvmiSEVmavNGbQP0u72efhIzHLH5D/2p2VLPaKvKjxL7r nmX+QIw== X-Gm-Gg: AR+sD13XywLOfX4kjMkV5F7lUZdZWZ9n8bOZeJwpcDOkFhdhLdM5y/d3/GQJzy3Vsb2 9yNgQE9Kx4JH901VzU/wlQWBgsHR0JT4eNomWAUciiUUk+fFdJf9vgq/3nHDhaIFNSKJFWVahTa naCxex2RvtdeQOUX6MVPj5nI/LYkwWaQTvse/ygwAOoYpnva7lkKxynY4gbVizUQmK101rQW/H9 N5j6dPVTCwfJGN09erUhQgHvEhsIu+WhmhdIX4VGbBpwgRMweRTsTPGg5UK+RELRTv1DNEYEqTD 2OnuD7tAokHrX8bsBoNK0EhLpWMOeV4v0kLZ2I3DTBQQihLMLxsqU6txwazjroCeChBY9qVYGOx eVFB1ETxZCD68UYas6G2QYc+NtUuhP0eXSt7h6DpxaVHGUGU8gIIW3OaAlTZAnv4yo/X5fceq5X /AjIw4pvpee/JnEhYl++/Td7qojwCjAndz6jJLuw3RnWk86PzWIB5XUGDBLaWlTjAPl6qzfA64H lRkmLByXaxST9yBUTc0FW/teIjEVqsYtntJ/RpF6+p5U8QG9uB/ X-Received: by 2002:a05:6000:29d5:b0:47f:c648:e27b with SMTP id ffacd0b85a97d-47fec4e6fbcmr6793319f8f.2.1785921872105; Wed, 05 Aug 2026 02:24:32 -0700 (PDT) Message-ID: <818b1fd4-ade7-4702-9dc6-f75fb0cfc575@suse.com> Date: Wed, 5 Aug 2026 11:24:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v10 5/6] x86emul: support MSR-IMM instructions From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1785921872-022C0A5B-BC100AB1/0/0 X-purgate-type: clean X-purgate-size: 6509 Encoding-wise these are very similar to URDMSR/UWRMSR, so existing logic is easy to extend. Signed-off-by: Jan Beulich --- v10: Drop vex.opcx part of #UD check (wrongly copied from USER-MSR code). Re-base. v8: Don't mark the feature 's' just yet. Re-base. v7: New. --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1522,6 +1522,8 @@ static const struct vex { { { 0xdf }, 3, T, R, pfx_66, WIG, Ln }, /* vaeskeygenassist */ { { 0xf0 }, 3, T, R, pfx_f2, Wn, L0 }, /* rorx */ }, vex_map7[] = { + { { 0xf6, 0xc0 }, 6, F, N, pfx_f3, W0, L0 }, /* wrmsrns */ + { { 0xf6, 0xc0 }, 6, F, N, pfx_f2, W0, L0 }, /* rdmsr */ { { 0xf8, 0xc0 }, 6, F, N, pfx_f3, W0, L0 }, /* uwrmsr */ { { 0xf8, 0xc0 }, 6, F, N, pfx_f2, W0, L0 }, /* urdmsr */ }; --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -1571,6 +1571,30 @@ int main(int argc, char **argv) if ( (rc != X86EMUL_EXCEPTION) || (regs.rip != (unsigned long)&instr[0]) ) goto fail; + printf("okay\n"); + + printf("%-40s", "Testing rdmsr $MSR_GS_BASE,%rdx..."); + instr[0] = 0xc4; instr[1] = 0xe7; instr[2] = 0x7b; instr[3] = 0xf6; instr[4] = 0xc2; + *(uint32_t *)&instr[5] = MSR_GS_BASE; + regs.rip = (unsigned long)&instr[0]; + regs.rdx = ~gs_base; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[9]) || + (regs.rdx != gs_base) ) + goto fail; + printf("okay\n"); + + printf("%-40s", "Testing wrmsrns %rsi,$MSR_SHADOW_GS_BASE..."); + instr[0] = 0xc4; instr[1] = 0xe7; instr[2] = 0x7a; instr[3] = 0xf6; instr[4] = 0xc6; + *(uint32_t *)&instr[5] = MSR_SHADOW_GS_BASE; + regs.rip = (unsigned long)&instr[0]; + regs.rsi = 0x665544332211UL; + rc = x86_emulate(&ctxt, &emulops); + if ( (rc != X86EMUL_OKAY) || + (regs.rip != (unsigned long)&instr[9]) || + (gs_base_shadow != 0x665544332211UL) ) + goto fail; emulops.write_msr = NULL; #endif --- a/tools/tests/x86_emulator/x86-emulate.c +++ b/tools/tests/x86_emulator/x86-emulate.c @@ -67,6 +67,7 @@ bool emul_test_init(void) cpu_policy.feat.lkgs = true; cpu_policy.feat.wrmsrns = true; cpu_policy.feat.msrlist = true; + cpu_policy.feat.msr_imm = true; cpu_policy.feat.user_msr = true; cpu_policy.extd.clzero = true; --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -1271,8 +1271,9 @@ int x86emul_decode(struct x86_emulate_st case vex_map7: opcode |= MASK_INSR(7, X86EMUL_OPC_EXT_MASK); /* - * No table lookup here for now, as there's only a single - * opcode point (0xf8) populated in map 7. + * No table lookup here for now, as there are only two + * (very similar) opcode points (0xf6, 0xf8) populated + * in map 7. */ d = DstMem | SrcImm | ModRM | Mov; s->op_bytes = 8; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -616,6 +616,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) #define vcpu_has_msrlist() (ctxt->cpuid->feat.msrlist) #define vcpu_has_movrs() (ctxt->cpuid->feat.movrs) +#define vcpu_has_msr_imm() (ctxt->cpuid->feat.msr_imm) #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) #define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) #define vcpu_has_avx_vnni_int16() (ctxt->cpuid->feat.avx_vnni_int16) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -7086,6 +7086,35 @@ x86_emulate( state->simd_size = simd_none; break; + case X86EMUL_OPC_VEX_F3(7, 0xf6): /* wrmsrns r64,imm32 */ + case X86EMUL_OPC_VEX_F2(7, 0xf6): /* rdmsr imm32,r64 */ + generate_exception_if((!mode_64bit() || ea.type != OP_REG || + (modrm_reg & 7) || + vex.l || vex.w || vex.reg != 0xf), + X86_EXC_UD); + vcpu_must_have(msr_imm); + generate_exception_if(!mode_ring0(), X86_EXC_GP, 0); + if ( vex.pfx == vex_f2 ) + { + /* urdmsr */ + fail_if(!ops->read_msr); + if ( (rc = ops->read_msr(imm1, &msr_val, ctxt)) != X86EMUL_OKAY ) + goto done; + dst.val = msr_val; + ASSERT(dst.type == OP_REG); + dst.bytes = 8; + } + else + { + /* wrmsrns */ + fail_if(!ops->write_msr); + if ( (rc = ops->write_msr(imm1, dst.val, ctxt, + true)) != X86EMUL_OKAY ) + goto done; + dst.type = OP_NONE; + } + break; + case X86EMUL_OPC_F3(0x0f38, 0xf8): /* enqcmds r,m512 / uwrmsr r64,r32 */ case X86EMUL_OPC_F2(0x0f38, 0xf8): /* enqcmd r,m512 / urdmsr r32,r64 */ if ( ea.type == OP_MEM ) --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -354,6 +354,7 @@ XEN_CPUFEATURE(MCDT_NO, 13*32 XEN_CPUFEATURE(UC_LOCK_DIS, 13*32+ 6) /* UC-lock disable */ /* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ +XEN_CPUFEATURE(MSR_IMM, 14*32+ 5) /* RDMSR/WRMSRNS with immediate operand */ /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32+ 4) /*A AVX-VNNI-INT8 Instructions */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -283,7 +283,7 @@ def crunch_numbers(state): # NO_LMSL indicates the absense of Long Mode Segment Limits, which # have been dropped in hardware. LM: [CX16, PCID, LAHF_LM, PAGE1GB, PKU, NO_LMSL, AMX_TILE, CMPCCXADD, - LKGS, MOVRS, MSRLIST, USER_MSR], + LKGS, MOVRS, MSRLIST, USER_MSR, MSR_IMM], # AMD K6-2+ and K6-III processors shipped with 3DNow+, beyond the # standard 3DNow in the earlier K6 processors. From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:24:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:24:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383163.1626423 (Exim 4.92) (envelope-from ) id 1wrXrs-0007Mi-Ji; Wed, 05 Aug 2026 09:24:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383163.1626423; Wed, 05 Aug 2026 09:24:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXrs-0007Ma-Gd; Wed, 05 Aug 2026 09:24:56 +0000 Received: by outflank-mailman (input) for mailman id 1383163; Wed, 05 Aug 2026 09:24:55 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXrq-0007Kl-Um for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:24:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXrq-006ZxT-BP for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:24:54 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73015e-2eae-0a2a0a5409dd-0a2a450ca81c-14 for ; Wed, 05 Aug 2026 11:24:54 +0200 Received: from [209.85.221.53] (helo=mail-wr1-f53.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730166-f479-0a2a450c0019-d155dd35a468-3 for ; Wed, 05 Aug 2026 11:24:54 +0200 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-47fde295992so609364f8f.0 for ; Wed, 05 Aug 2026 02:24:54 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfda0bfsm7238538f8f.5.2026.08.05.02.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:24:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785921894; x=1786526694; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=0P8KtrMj33FZR9rXeuoR9W9HprP82JFkO8XpOVKL9W4=; b=WPTDfsHNT8Z/EIrSOINwOfKJpAGhXfcA0SpipIh8GZfrLtsW/etJkbFroeZJ8dBDvW h/Vj2fztfzLh5RXJOg0MwsR+OGNp2EwwWrAWOZvpUPNGGYMQws2yRfnA48I7eHtb8NmJ 8IKiZboOeVqKIUNq0K9WqCcfTN+ExCvwjkp5qfg/ZzPlrj5l/LayeeG/llHg6uo/ibH8 Tw0EY3r/wTea3Hyxf9zb498JktsDFq17f2InIPpCU32AhcDoGUJUCjueZf6ziCPq5bHH JJNsDlXH7PAvi5r5nNAau+eu28qkRzLPx58a9UhZN4DYvgjAEykx6+/YBDQQWE1D46M2 BO+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785921894; x=1786526694; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0P8KtrMj33FZR9rXeuoR9W9HprP82JFkO8XpOVKL9W4=; b=MfyVl3XqwW4Q3mjlkWd0OCcL328Owe8ziRlhx14eTe/18kC8YQL8N9cJyB849k0VLz RF4qzBTmh3LU7bsS1Qo1klyvCUAlPbnXX5QR1THyg83IFukXiXlk/vTCyUKdOfqBFz7c qfdOZs//ECBUKmsZ6s9d+F7ZxeAuly6U5Qa2bMpMFYSYgdmGa2LzPwtyr4aNzXxdbIKQ zhphKMxq9jxvZxylDQwUd4BpqrMeHgLt0wRo+B2CY//i7Rc7kMndt/6zNguvBpDSXTz4 iJu6MTyA9LEup1uV7uzD28BgEuCbvY14ZqcM/2gU9INkw3N9leqG5pfJ6sC9CSQ89P7g f1kQ== X-Gm-Message-State: AOJu0Yw2o3zguHjSGs9XvlrTFq21LRczrE64u8x4UklDSSg+vVKTO8LQ tgE/UHtcdPwTfB6dumXUklLq3YjUIMxKd6R6DKDBHRVhvh8jWNb6rO5ex7w7/z2ui4FupVDD7sF PO/nlOA== X-Gm-Gg: AR+sD11+z7NlHEjhl3rIYHAZd9Xbv/i2Z+xNnw6cwUhEd3JZCX7znl6Mn/EVz3MuUDm 9IvocjZo9DeS5c4D9WlssYUDaFVhwDm3hmrB3OVoSd25mkMbH6mqoLsvl7omOeGYfCYGRxNl26f JK3zl+yrhTQl0yMi4amjSYGuUQdyqOR7t09LS1mHnWM3EYAmCMey+lk9mXK8LhON4Hof0OeM8+r gbGmXaQhns829JGLhj5yeiTicikf3Y45lGQLeHqgo2dlSONOeQEcCOJ4CfBmf+gA5cRrL9Y1Qxb 1OESrqMohTikynF2Jr0Ql1uHnbKOyEGB5PgGxL9gFv/oFOydniId40HQmcezsy54yvBco2KnGuG quKcIMPUT4u0C+IooT1vTSNRSbcWc0LOnfmLNWK0Cjn+mlMeaviE8Iw8Ftk+ZGqKEMtRJkKe2xg YYRXjKRMNR1EHJfV8oP+Ks+b8fCOvVuPcyKcB5njM1ADIsmlgGPjY9Tt1D9pJd+7aAntjkpYeei 1JigzF/0m7UbXNQzFWUVH8AobWMvwGN+o3Z/Zsb4toOWqNu9rSA X-Received: by 2002:a05:6000:480f:b0:47f:8554:a341 with SMTP id ffacd0b85a97d-47fe81d131emr23983559f8f.13.1785921893765; Wed, 05 Aug 2026 02:24:53 -0700 (PDT) Message-ID: <2ccead84-eaa4-428a-8684-da26874c05e9@suse.com> Date: Wed, 5 Aug 2026 11:24:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v10 6/6] VMX: support MSR-IMM From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <81a2c636-5a74-41c3-81a2-3f49ed717744@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d25034/1785921894-00ACCA5B-A4C27296/0/0 X-purgate-type: clean X-purgate-size: 4687 Hook up the new VM exit codes and handle guest uses of the insns. Signed-off-by: Jan Beulich --- v10: Check feature bit in exit handler. v9: New. --- The lack of an enable bit is concerning; at least for the nested case that's a security issue afaict (when L0 isn't aware of the insns, or more specifically the exit codes). --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -834,10 +834,11 @@ static void __init calculate_hvm_max_pol __clear_bit(X86_FEATURE_PKS, fs); /* - * Don't expose USER-MSR until it is known how (if at all) it is - * virtualized on SVM. + * Don't expose USER-MSR and MSR-IMM until it is known how (if at all) + * they are virtualized on SVM. */ __clear_bit(X86_FEATURE_USER_MSR, fs); + __clear_bit(X86_FEATURE_MSR_IMM, fs); } if ( !cpu_has_vmx_msrlist ) --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -453,7 +453,7 @@ void domain_cpu_policy_changed(struct do } /* Nested doesn't have the necessary processing, yet. */ - if ( nestedhvm_enabled(d) && p->feat.user_msr ) + if ( nestedhvm_enabled(d) && (p->feat.user_msr || p->feat.msr_imm) ) return /* -EINVAL */; for_each_vcpu ( d, v ) --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4712,6 +4712,14 @@ void asmlinkage vmx_vmexit_handler(struc hvm_inject_hw_exception(X86_EXC_GP, 0); break; + case EXIT_REASON_RDMSR_IMM: + /* Check the feature bit in lieu of an enable one. */ + if ( !currd->arch.cpuid->feat.msr_imm ) + { + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); + break; + } + fallthrough; case EXIT_REASON_URDMSR: /* NB: User-MSR bitmap was checked by the CPU. */ { uint64_t msr_content = 0; @@ -4721,7 +4729,7 @@ void asmlinkage vmx_vmexit_handler(struc { case X86EMUL_OKAY: *decode_gpr(regs, msr_imm_gpr()) = msr_content; - update_guest_eip(); /* Safe: URDMSR */ + update_guest_eip(); /* Safe: URDMSR / RDMSR */ break; case X86EMUL_EXCEPTION: @@ -4731,6 +4739,14 @@ void asmlinkage vmx_vmexit_handler(struc break; } + case EXIT_REASON_WRMSRNS_IMM: + /* Check the feature bit in lieu of an enable one. */ + if ( !currd->arch.cpuid->feat.msr_imm ) + { + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); + break; + } + fallthrough; case EXIT_REASON_UWRMSR: /* NB: User-MSR bitmap was checked by the CPU. */ exit_qualification = vmread(EXIT_QUALIFICATION); switch ( hvm_msr_write_intercept(exit_qualification, @@ -4738,7 +4754,7 @@ void asmlinkage vmx_vmexit_handler(struc true) ) { case X86EMUL_OKAY: - update_guest_eip(); /* Safe: UWRMSR */ + update_guest_eip(); /* Safe: UWRMSR / WRMSRNS */ break; case X86EMUL_EXCEPTION: --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -205,6 +205,8 @@ static inline void pi_clear_sn(struct pi #define EXIT_REASON_WRMSRLIST 79 #define EXIT_REASON_URDMSR 80 #define EXIT_REASON_UWRMSR 81 +#define EXIT_REASON_RDMSR_IMM 84 +#define EXIT_REASON_WRMSRNS_IMM 85 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 82 +#define VMX_PERF_EXIT_REASON_SIZE 86 #define VMEXIT_NPF_PERFC 166 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -354,7 +354,7 @@ XEN_CPUFEATURE(MCDT_NO, 13*32 XEN_CPUFEATURE(UC_LOCK_DIS, 13*32+ 6) /* UC-lock disable */ /* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ -XEN_CPUFEATURE(MSR_IMM, 14*32+ 5) /* RDMSR/WRMSRNS with immediate operand */ +XEN_CPUFEATURE(MSR_IMM, 14*32+ 5) /*s RDMSR/WRMSRNS with immediate operand */ /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32+ 4) /*A AVX-VNNI-INT8 Instructions */ From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:31:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:31:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383176.1626432 (Exim 4.92) (envelope-from ) id 1wrXyb-00018u-9H; Wed, 05 Aug 2026 09:31:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383176.1626432; Wed, 05 Aug 2026 09:31:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXyb-00018n-5z; Wed, 05 Aug 2026 09:31:53 +0000 Received: by outflank-mailman (input) for mailman id 1383176; Wed, 05 Aug 2026 09:31:51 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrXyZ-00018h-NR for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:31:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrXyZ-003zSv-3w for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:31:51 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7302fe-bab6-0a2a0a5309dd-0a2a4505ead8-36 for ; Wed, 05 Aug 2026 11:31:50 +0200 Received: from [209.85.221.51] (helo=mail-wr1-f51.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730306-4cb1-0a2a45050019-d155dd33d4c9-3 for ; Wed, 05 Aug 2026 11:31:50 +0200 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47f93b2fe4cso501931f8f.0 for ; Wed, 05 Aug 2026 02:31:50 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfda6afsm6884988f8f.3.2026.08.05.02.31.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:31:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785922310; x=1786527110; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=m5ZVt/TEvWa5Y4pw8CpVX3kraK6kJ4ZA2MBNk4yY93o=; b=bsIggRdbkHqfEY7/rucbcqg/z9p3SuUyitrX2+KkbyADEAfK/mXrNgdaMhXunZ7rI6 BgPLlGmtpRC/bSJa070F1aoIGiXRK8hUNun2c97QD1UMPV2SV+UM++6jYC+V+dSwBqZO UKd3Yz8JeBJgDG7H4+2+Ue4h3eUn8vrtV0f9txyfATuAYgObmatLcK/bGPIHgiwP8NFO KYiY/yO3eBIhNhHDWNVEbgCdMBgP7KiowmFB+qr6Bw65df209wniSGBWgq9JS/cYGV3g b07UruCv0sZAUhA9nr4hl0gzgDdUxxKOUucYTrB0xTOhaY6/5q7wXJSioKRDmnil1GC4 Os0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785922310; x=1786527110; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m5ZVt/TEvWa5Y4pw8CpVX3kraK6kJ4ZA2MBNk4yY93o=; b=lyyvmcDGLIDDJ9FpWCbTLoBAFZFQbTFO3b+zgASt3rV5tnsHsGpxMcndsZut74yvsw IGDqDEEv0yAQgZF5yV0PqqTTSzLfqX2Gc1dTLPaVtLGYcfgtZbVjZmjdKevkXMsAmhJU EkV+CM9U0cpCYz6sqPZpD5l7F/Dqdg6dX3iK52ucbvuhVcEsTEjbS5rUdPY5x/gmjj53 /dRqUspa3tCg/pK1gxinT3abLjzC/ljOx+WkboWWtc5uobglIhJ+VgXpx6YrowGGm36i TvsCILCk7V5aGH6attf9ShWFWY+GBRl7hg68jqUReEe/WSFWksiRLXowl90ru0Nrx/j7 Snng== X-Forwarded-Encrypted: i=1; AHgh+Rp86nBZTpxIiAoJxGl+9eH4PfxKnWjM5psMP4mBZ/PdZ/w90HbspgoIYheRy+UFoJin/TbTwI0KVNw=@lists.xenproject.org X-Gm-Message-State: AOJu0YwMjpZh2EMCAKk5Z/XQv14cOPd/oaHdxtcs5h3CUYZbD41E8ZUp 2kmxY88liA3D8wxgEHFQxrC+c1oBlo6SjMqtiQ8B9LQ0GmXGaIpVl4ED27+CYJvKrw== X-Gm-Gg: AR+sD10uLH+HJodJ2qjosv4Sp25+3DZ8sNqWSyreTc0FdoYexYr6srswZPN2aEkyTW+ wF0ZdyZ0AJHo3KjjyjF+QzoYl9VYc1yQ3FM4WmwMa1lbvixOpq/iGEkHXW9O6d5xCeJU98iXO4s Eb4wv4tfM49jnN2YiSX+xsTdW5Y7M0Tb+9wmz3gp4iFAkjYSk6wYgvBQNFyjkD0tRl4H9CzIH7n HwIO1obJTYoZSuTUwkjoYGZ8+0UpnyziidsrSWw1nhhLjbKo+MvevPePAO3TMocyrrDAa49O6t2 PXzJBxeDzQv/U6A+zgZj+OUkwC2jjTvX2aq7cNMf4jHY2lqqGW95b+H3Y3XUDWQrBFsOsvf+oGG k10uUnYLN1kAP2suHparb8AajycR+C/OcWtM1+qtc3t5OjmkDVecpf5Iaeo3Qwb6yGEj8jUB14n d9KiZta7n5mz1gD8w4NzZXrkhoUwFcGWdOUP9gAPHE149hlCO8i/tcbheom5NusAaCcfz31/VGt BKgX7nUVYEpFjiU5eG9w5iFdQ51JlaGqFPoZW9M3n5WXK1ZmMwB X-Received: by 2002:a05:6000:1842:b0:47f:8d71:210a with SMTP id ffacd0b85a97d-47fec634b38mr8662442f8f.15.1785922310377; Wed, 05 Aug 2026 02:31:50 -0700 (PDT) Message-ID: <07e4cde9-cbbe-4ca3-878b-1c72038e4530@suse.com> Date: Wed, 5 Aug 2026 11:31:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] vtd: Print originating iommu on faults To: Teddy Astie Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319342.8631fc262581453bbf619ec5b2062170.19fad533fa5000e099@vates.tech> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1785319342.8631fc262581453bbf619ec5b2062170.19fad533fa5000e099@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1785922310-F7EB92A1-14438234/0/0 X-purgate-type: clean X-purgate-size: 650 On 29.07.2026 11:59, Teddy Astie wrote: > When a fault occurs on a IOMMU, print the IOMMU the fault is coming from. > > Signed-off-by: Teddy Astie Acked-by: Jan Beulich Nevertheless I think this doesn't go quite far enough - this internal index, to be helpful, would need associating back to the respective firmware data. What iommu_alloc() logs is not only limited to verbose mode, but also doesn't include the index. I think something need doing there, and then we need to be more consistent throughout to include the IOMMU index in log messages pertaining to a particular IOMMU. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:34:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:34:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383184.1626440 (Exim 4.92) (envelope-from ) id 1wrY1K-0001ha-KR; Wed, 05 Aug 2026 09:34:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383184.1626440; Wed, 05 Aug 2026 09:34:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrY1K-0001hT-HQ; Wed, 05 Aug 2026 09:34:42 +0000 Received: by outflank-mailman (input) for mailman id 1383184; Wed, 05 Aug 2026 09:34:41 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrY1F-0001hG-IP for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:34:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrY16-0040CN-JQ; Wed, 05 Aug 2026 11:34:36 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a730392-5cb7-0a2a0a5109dd-0a2a4506cc64-40 for ; Wed, 05 Aug 2026 11:34:28 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7303a3-195a-0a2a45060019-5a9b3222e264-3 for ; Wed, 05 Aug 2026 11:34:28 +0200 Received: from [2a07:aa00:8c:e0:2ef0:7ea2:4f15:3280] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrXtU-00000001ABs-2rNZ; Wed, 05 Aug 2026 09:26:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HCP6mO+wKKfIvYSWgV3yoR0hiLYWZQCLwXNtJuiZRtM=; b=jhXinj0CchuihGOKOsi5MD6O4W u+At7TWxLwHWZ3B6/Gu53v8QbU8MF7wc6mubv18a/7llwgDbUTK4o2l9pTEoKzPZNxhTsp6IXYZW1 34UGn9+6hCOBNkXnyllVTAVvqzrbK+MenGznX5Z0AV05Ovwzahhsd6cWVADXSH0PVimAwVsMynMRO YxxdS+qtR/HRGBrYoZb9ggUG1LsPb5CWp4Iakz1AAyal6SuzahPza41YtGfgUOVcif/6dpbEAOvak 3B3cNx4fYOe2YP8o3Ys98BjnwUBBl1f72Q+qSLeDu4q7aLEvOBMBFnNSuJyNNxs6SSOuQnLvns6q3 Vo6/Hqmg==; Message-ID: <38e16d4386a5ca428366a55ffa83ab34e0e1b72a.camel@infradead.org> Subject: Re: [PATCH v7 31/36] KVM: x86: Add KVM_[GS]ET_CLOCK_GUEST for accurate KVM clock migration From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Wed, 05 Aug 2026 11:26:30 +0200 In-Reply-To: References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-32-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-oAGZuj5i7ES/IfXkCZMt" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-16d1c6/1785922468-1EAC277B-C1621CBB/0/0 X-purgate-type: clean X-purgate-size: 10712 --=-oAGZuj5i7ES/IfXkCZMt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2026-08-04 at 16:38 -0700, Sean Christopherson wrote: > On Sat, Aug 01, 2026, David Woodhouse wrote: > > On Fri, 2026-07-31 at 16:24 -0700, Sean Christopherson wrote: > > >=20 > > > > + /* > > > > + * Allow for a discrepancy of 1 kHz either way between the TSC > > > > + * frequency used to generate the user's pvclock and the current > > > > + * host's measured frequency, since they may not precisely match. > > > > + */ > > > > + if (user_tsc_hz < curr_tsc_hz - 1000 || > > > > + =C2=A0=C2=A0=C2=A0 user_tsc_hz > curr_tsc_hz + 1000) { > > >=20 > > > I don't follow, why is KVM restricting what frequency userspace can s= et? > >=20 > > Userspace actually sets the frequency with KVM_SET_TSC_KHZ. What KVM is > > insisting upon here is that the input to KVM_SET_CLOCK_GUEST is > > *consistent* with the guest's TSC frequency (within a little slop > > caused by different host TSCs). >=20 > Why does KVM care though?=C2=A0 I know some people hate that KVM's uAPI i= s permissive > to a fault, but trying to "help" userspace often ends badly for everyone.= =C2=A0 E.g. > what happens if userspace does KVM_SET_TSC_KHZ after KVM_SET_CLOCK_GUEST? The two operations have to be considered in isolation, at the time they happen. The KVM clock provides a y=3Dmx+c relationship from TSC (x) to kvmclock (y), where the rate (m) depends on the TSC frequency. The KVM_SET_CLOCK_GUEST function provides an equivalent y=3Dmx+c relationship, instructing the kernel to make them match. If the rates are the *same* then this is basically a case of adjusting the constant epoch (c) to make the two parallel lines coincide. If they *aren't* parallel, then what is KVM_SET_CLOCK_GUEST even asking for? I guess the kernel can adjust the guest's kvmclock so that it *intersects* the requested line at some point around now, but that really isn't what KVM_SET_CLOCK_GUEST exists for. --=-oAGZuj5i7ES/IfXkCZMt Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDUwOTI2MzBaMC8GCSqGSIb3DQEJBDEiBCDrMFuo3LMQwgzSkoKKUNMxtBxlyjvN 7KZ2Dl4YbaXEJzCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAkOdbfLkZuku+SQVaoiGVaHf6YcFf5yzLX87vOO9o/+sDyzbNJ2Zu REjNQ+5aojh9XoZcgeiWMi5e7VXN2WdEkSqtBBKsfNY982ZOLWo2uitaEdKaV4YgOe2xt/NZ2qWc OWV3T4Cg8bUinS+IcMGkWhyZrbraASc1MJcM5d22cJ93gls9ovwf4jtbDyCZOjT4poCDMR+T9jqH qkTBLtG+tso/Yw9Wp3ME4ZB2WPtaT39H2c63mrXIAMVQISPw8HQavnhB3z50Ns4cwLNkQVT03ZEu kJG5MweXfkfgS9TqHS6YLTenDY6OiPEet5R5qY5TTdUHFc3eGcjLQXSNmM+WvQnFRyCDUVxw8mZA WXhnp6QtN1VYMDJvFAmwj0l/HS7hBkKGEzf7wsuOpM46sa0hjhIuzCsGDsPVVYdPTgsbXbYiOTRi w0ByXpLtlEzLDrP9JnrU/D/r8TOtfr3XubQvKJMFWkTkucYEhRV+QkupvIkEyR7840rPPJuESPEK QxvQfJsUJlcbsPzg3thAE5TMCF7IOEKkUJZ+8ZPbgd3kuzpHvOCq319byh3dNTu+N+VAwjBG+nVk PIu6y0roSGeVTegr8bwUeTIj6VplZgAkZNuB3PopN4/nVlvkjLOuH9SjTJVooMHu/Cm92It9VMhI h/TFd2tqzGcQBYemqXDhjKcAAAAAAAA= --=-oAGZuj5i7ES/IfXkCZMt-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:40:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:40:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383193.1626449 (Exim 4.92) (envelope-from ) id 1wrY76-0003eh-AE; Wed, 05 Aug 2026 09:40:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383193.1626449; Wed, 05 Aug 2026 09:40:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrY76-0003ea-7f; Wed, 05 Aug 2026 09:40:40 +0000 Received: by outflank-mailman (input) for mailman id 1383193; Wed, 05 Aug 2026 09:40:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrY75-0003eU-Hq for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:40:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrY72-006IBs-32; Wed, 05 Aug 2026 09:40:36 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wrY72-00FGrj-18; Wed, 05 Aug 2026 09:40:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=jqWNmZY06DVMjdGxIRpnMRf2z1reaDJOSpTrbBkvv8c=; b=Rz/Fywb9AY5sDD9He27t1Qc5k2 RRLgVyzgKt6l6h3C7jNH0drpNd+kl0uZZKYtPt3ybteq3VJImA/JPSCDOwYFsKpWvwIvFmKquewtp ud3QY0S6HTbjv2yVc3EgHFTnekJymgHrZpge7sFIVCqzIjlfT0KP6S7FcjlRKbpMe30Y=; From: Roger Pau Monne To: Juergen Gross , Roger Pau Monne , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Roger Pau Monne , stable@vger.kernel.org, Yannick Martin , "Thorsten Leemhuis" , Matthias Goergens , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v2] x86/xen: fix init of balloon stats again Date: Wed, 5 Aug 2026 11:40:07 +0200 Message-ID: <20260805094008.95778-1-roger@xenproject.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The handling of extra memory regions done in balloon_add_regions() is not correct for PV guests, since the initial target is set to reflect the real memory the system has, not what's described on the memory map, which can be higher if memory != maxmem. Introduce separate logic for addition vs subtraction in balloon_add_regions() and handle extra regions correctly by adding them to the total amount of pages, instead of subtracting from the current and target pages amounts. In the common case PV domU/dom0 and PVH dom0 will use the addition path, since the initial target reflects the real assigned memory. HVM and PVH domUs use the subtraction path, since the target is set based on the amount of memory reported in the memory map, without accounting for released regions. Fixes: 87af633689ce ("x86/xen: fix balloon target initialization for PVH dom0") Fixes: 0949c646d646 ("Partial revert "x86/xen: fix balloon target initialization for PVH dom0"") Signed-off-by: Roger Pau Monné Cc: stable@vger.kernel.org --- Cc: Yannick Martin Cc: "Thorsten Leemhuis" Cc: Matthias Goergens --- Changes since v1: - Also fix PVH dom0 without unpopulated pages support. - Account for XENMEM_current_reservation possibly failing. --- drivers/xen/balloon.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index e7f1d4ca6d75..e7f74ea7cd5e 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -679,7 +679,7 @@ void xen_free_ballooned_pages(unsigned int nr_pages, struct page **pages) } EXPORT_SYMBOL(xen_free_ballooned_pages); -static int __init balloon_add_regions(void) +static int __init balloon_add_regions(bool append) { unsigned long start_pfn, pages; unsigned long pfn, extra_pfn_end; @@ -703,19 +703,26 @@ static int __init balloon_add_regions(void) balloon_append(pfn_to_page(pfn)); /* - * Extra regions are accounted for in the physmap, but need - * decreasing from current_pages and target_pages to balloon - * down the initial allocation, because they are already - * accounted for in total_pages. + * There are two different use-cases depending on how the + * initial memory target is fetched. For PVH dom0 and PV the + * target is usually set to reflect the domain assigned memory, + * and hence extra regions need adding. + * + * OTOH for HVM and PVH domU the target is set to the amount of + * RAM reported in the memory map, and hence extra regions need + * subtracting to reflect the real memory usage. */ pages = extra_pfn_end - start_pfn; - if (pages >= balloon_stats.current_pages || - pages >= balloon_stats.target_pages) { + if (append) { + balloon_stats.total_pages += pages; + } else if (pages >= balloon_stats.current_pages || + pages >= balloon_stats.target_pages) { WARN(1, "Extra pages underflow current target"); return -ERANGE; + } else { + balloon_stats.current_pages -= pages; + balloon_stats.target_pages -= pages; } - balloon_stats.current_pages -= pages; - balloon_stats.target_pages -= pages; } return 0; @@ -726,6 +733,7 @@ static int __init balloon_init(void) struct task_struct *task; long current_pages = 0; domid_t domid = DOMID_SELF; + bool append = true; int rc; if (!xen_domain()) @@ -745,6 +753,7 @@ static int __init balloon_init(void) } else { if (xen_unpopulated_pages >= get_num_physpages()) goto underflow; + append = false; current_pages = get_num_physpages() - xen_unpopulated_pages; } @@ -767,7 +776,7 @@ static int __init balloon_init(void) register_sysctl_init("xen/balloon", balloon_table); #endif - rc = balloon_add_regions(); + rc = balloon_add_regions(append); if (rc) return rc; -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:41:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383200.1626459 (Exim 4.92) (envelope-from ) id 1wrY7k-00045p-Ir; Wed, 05 Aug 2026 09:41:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383200.1626459; Wed, 05 Aug 2026 09:41:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrY7k-00045i-FH; Wed, 05 Aug 2026 09:41:20 +0000 Received: by outflank-mailman (input) for mailman id 1383200; Wed, 05 Aug 2026 09:41:19 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrY7j-00045c-FK for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:41:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrY7i-00EPDH-Rn for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:41:18 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73053a-5cb7-0a2a0a5109dd-0a2a4508c91c-6 for ; Wed, 05 Aug 2026 11:41:18 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73053e-f659-0a2a45080019-d1558031e553-3 for ; Wed, 05 Aug 2026 11:41:18 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4957eefd361so5497635e9.1 for ; Wed, 05 Aug 2026 02:41:18 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb46esm187293975e9.5.2026.08.05.02.41.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:41:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785922878; x=1786527678; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MiIQ7czv9lPQAjuP9ijWUuHHGqlX/VIo/pd5dCsI4+4=; b=dfFHuO/qG248KrBOEo4zwyFFRTaJgXvtz6Hohm2mJd2N1qTmFGTbJOx7fwmal8Re/6 O6pr4b0PJr0pvxjnwBl8BVHe4yNuSMMg0CiMt/4Jj+nGw4aAtHbGC77cjzKdlQuLrvPY zFVeoVTmYC6Ne83HjHbD/tf8fkSFm0whLtE/nZS8jX+ayfV6/zlRWryJFBWvgF2VEiYL rKz/+IV1QWwURM46Tgsj3m+n4RZBd201n5DixMDOS5R6QedDwX2SqOo/mdlmZ50mGu/0 nTYfLcyD/eu6xdP0wGahKj9Wr//H9i5b57R5prN3FPSfylQSDpeds6H+4w9BxlIPVJTT SVVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785922878; x=1786527678; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MiIQ7czv9lPQAjuP9ijWUuHHGqlX/VIo/pd5dCsI4+4=; b=dNH2wZGUBRZId8p2l5uOHWMqvZInzWqv07X77v8YlPgPKv27ViTeDFnUgw07r+k9Sx 7vPZxhvvWFmYbKpo2ov39dbekantc/ie2GSgjoOj4UEY//4gE7cuac6ynTtMADkkWKhF /fkKA7jwEqoSIb0Ukw9M5o+gEOsizp3UlT4hajrgKZnlHbcO3fWOBHwt+xL8qOuUL1RE 7UNMyvkWJYZD5LWSFY0ErJCjgjf3bogxuPlNe/3VY4GZUWXcE1X/Y/K+4OuSIUFQzT/Q FTeUnl2RVwf9sUiBUdf1+UVJeXcfLP6QTnwwsUlHEj6w0v73t5/AhVJcCjswuRpmhoOQ oKmg== X-Forwarded-Encrypted: i=1; AHgh+RrE9bkw3Q0bU6n+TNGtd2+xLVtKq6Ne3Ytcde++nV/Yx2yEEUO2x37Q7S24EheNQkW04BMjqBCIxQA=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz03Q1M+vljj3tNzRW7vsAW70O9TQr5cECgDVvPhabZKS2wqv4m Bj2jm/tfD+aO8KiQt5SZjMjR2xZu/L71BWMqgww1BeqLqkicaEmgRYjRLNzOvRWWZg== X-Gm-Gg: AR+sD12VBbv3JhRZ5JM3SwBmFinT0ErFClDvK2XIh8UuiOkEB0FcqSm6mjiELQ8giMd KTxlfhV7YAjE7ROiwhXWTXEKx48oWPeTO0qOkDO99xqghaJ2jghiUOJdyKcqcPHhRNrXL2tDZ8v +ZBbkx040zmcZnCGx+f0GJ9MY3cyZ26XkmbMRKxP6C7YoutVTgoiNd+iqr7OBux1zFoYno+3oFi pOIZvTfBZAMOYzCrDcnhFQ0pWlaPCSF/3hdm9L+tf7k2EMB6sXEjQyJZW0gKaUMAcjLJ9feo8yf 1cCgZ5jU4cW0/i1zaTeEzydQbh5nadRcRgfD6knp3ZFQTKkEKhXSb0sUxW1zF8aCqM6hrzLUw+O U0C4/wCf6JcDxyAZnj99GotP3S4MxPHVrufvi870yQuhS/FrUNvLVOGknkKNiZBg9Nixwy0ztQu iu9a0ZuIPT/EkdI8Bjeoeg0q0XeA3hh+ckTKKaX/4305DXvAb2UNPITdt6E+/Zy4/WfMu6wgI8U VQjmpJ9Q0MqNHN2K5iiR+G7pqoK5PD7VG4DEeXLXPlDqEbHGgyR X-Received: by 2002:a05:600c:3b29:b0:495:4811:7998 with SMTP id 5b1f17b1804b1-4994e7d389emr49613065e9.17.1785922878278; Wed, 05 Aug 2026 02:41:18 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 11:41:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] vtd: Don't disable hwdom passthrough on unhandled SAGAW bits To: Teddy Astie Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319342.8631fc262581453bbf619ec5b2062170.19fad53421a000e099@vates.tech> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1785319342.8631fc262581453bbf619ec5b2062170.19fad53421a000e099@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c1860d/1785922878-D594A87B-4457EC51/0/0 X-purgate-type: clean X-purgate-size: 1550 On 29.07.2026 11:59, Teddy Astie wrote: > On recent VT-d spec, bit 3 indicates support for 5-level pagetables, > this is currently considered unhandled and causes "hwdom passthrough" > to be disabled, even though it's unrelated. > > Given these are is capability bits, we don't need to consider unhandled > bits, but only make sure that the ones we want (e.g 39-bit or 48-bit AGAW) > are set. > > Fixes: 474fc7d3c652 ("iommu/vt-d: fix SAGAW capability parsing") The description of that commit explains pretty well why pass-through mode does need disabling in that case. If there's anything wrong with that explanation, this would need calling out here. Additionally I can only repeat my proposal to finally default to strict mode. In strict mode, pass-through mode is disabled anyway. (IOW there's the additional question of why you need pass-through mode in the first place.) > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1327,14 +1327,7 @@ int __init iommu_alloc(struct acpi_drhd_unit *drhd) > } > > if ( sagaw >> 3 ) > - { > - printk_once(XENLOG_WARNING VTDPREFIX > - " Unhandled bits in SAGAW %#x%s\n", > - sagaw, > - iommu_hwdom_passthrough ? ", disabling passthrough" : ""); > - > - iommu_hwdom_passthrough = false; > - } > + printk_once(XENLOG_WARNING VTDPREFIX " Unhandled bits in SAGAW %#x\n", sagaw); Also please adhere to the line length limit. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:44:06 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:44:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383208.1626467 (Exim 4.92) (envelope-from ) id 1wrYAN-0004iX-UD; Wed, 05 Aug 2026 09:44:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383208.1626467; Wed, 05 Aug 2026 09:44:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYAN-0004iQ-RX; Wed, 05 Aug 2026 09:44:03 +0000 Received: by outflank-mailman (input) for mailman id 1383208; Wed, 05 Aug 2026 09:44:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYAM-0004iK-BD for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:44:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrYAL-0041xN-Jb for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:44:01 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7305b8-2eae-0a2a0a5409dd-0a2a4503ce90-44 for ; Wed, 05 Aug 2026 11:44:01 +0200 Received: from [209.85.218.41] (helo=mail-ej1-f41.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7305e1-fae8-0a2a45030019-d155da29c161-3 for ; Wed, 05 Aug 2026 11:44:01 +0200 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c1c4c7ddaf6so136317566b.3 for ; Wed, 05 Aug 2026 02:44:01 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c20363e6e8fsm91963166b.39.2026.08.05.02.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:44:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785923041; x=1786527841; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=fIxT2QYlt7MhR6tH5xbR++rCxhH8SJlguVhp+ZQ3HcE=; b=TB68hf9lg726mk2jjJKMyJjrPpCfpnS+SXRdAAolAvU7saGO1H3uxf0KHwhlcVzZOq YCFjTpMxFBbtkcbpT2mkZQcgnkWy27WpnUqLpx5t7FZ+Gyfz8TZkJWr3ri4NnSzPZlyW 5vqFk2rckVHgfkXsr6uiOtfNua+3mwhkKdGTvuJSI8UT88wI2Xq/+M/+feV/Qrn/nI+T N0j3UCJjNauvCdS2qp4988utffYzsCB6rcnfBsTwVK+QrIY+sotGKz6OFZFUa+Mr5Iuo jUevN0xc+5Ejkux4SHmZO/RIF4ei1bZCT5DD0xdu19D7QQnmkehFbq01TPWTgj4Ap2Mt hadw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785923041; x=1786527841; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fIxT2QYlt7MhR6tH5xbR++rCxhH8SJlguVhp+ZQ3HcE=; b=PLSgfYXb8Iol1QdVoriPtFYl3ep2E9kw1SOmrhSGIM1Ju2iIUHlNB01PgJ+cKcyphP 0Lndd/TBW79fPTfArbJE+bo4CL2go4yi6wl1BtLMBqsqQwE1zmaZsp1UfsbbO4l7VqoT +M0euj+SJPogaaRHVAymRjv2/uHU+Lg4Uh3o3i4p93li6tQNpIAg2fJoNYHeLrFqdu2/ 1JF9QQoOZINWMkJiCh0qwY6dqcJj92FyrUOnJasW5cawjf8bvwTWtGYdi9zuASQrEDNa 0atAE6cQNnNrpkQMAtNdetF3GG0atZT0QLfZWSD9fwBY+Xs0nhNFQIFd8vi2cx4stAaB bNYQ== X-Forwarded-Encrypted: i=1; AHgh+RrI8OzIVgXIxMljQgVxcodzC3bFN9HV5Xa80B1N1pnnCqiAoogjDK68s5n9FqkbEDDNRHCGTFwEM+k=@lists.xenproject.org X-Gm-Message-State: AOJu0YxyFjylmlLt9uTOs2zKvKD8ULP41HbyltVNi3usBEFWzgDyv5Nt sWkdAgzLCWHKKDahkRgA80L/3paXKdZ32Im4J9sLO9X7W0cFYUpTZjLfQuKu68XVLzk= X-Gm-Gg: AR+sD12gTfwxSCIW8rLXTW3FDIdMHUg1dvk+Fuoz7f/ecVBlke46pWiXlWRQ6/hjK8y hAJul2Sc0nofVJFcY1kHIJP4ZqfvgpZnI8F7C5sf6ueizFlNHUo0hzGku0dPd6o6suexZXGmOAm 4y9+HiSdnZzuYsM6iUGJAcdJPe++cUQrRKwSDWYZA01leDCvT3HzmKAAWK/O3hKMRNRGGZTUJoE NDkyqizdqBIb9da5cElSzkUwJv5Byd3uTGC0To66NYnFKjBAjJi/b4IZ19dze6xFO/SI9ZN1aJu yRMh+4dcgrnIvhZQEKerlvp53fK4fgYlgUfauq2FZKjOcvBIUzIL2CkpUNmAEty/U8FM+IErnhD H4FXlT10bqa/DJnsmfmZbHuPPZKoO1ZpDbeFDDHTabr9ysEmYZkctwQiyWNu5noiKjGFa3i1ZWO 9G6C6VeAsi/RoyZj2O0QyETEZBk0X4cocAj3ZMdgh0qRrO2BFQBN6hfscaplA4JdK/+LdRogWc/ tnS2JN4Uj5gkcjMdWq9VZMq3r4XzVKyIo3qIMJkdY3CDv3zR5hsNRK/bc/Qetzph8p/WzHnpNBC hJuHxuEq7AcZ7Ww= X-Received: by 2002:a17:907:1b04:b0:c12:1651:17b2 with SMTP id a640c23a62f3a-c2039d256e2mr229300166b.9.1785923040816; Wed, 05 Aug 2026 02:44:00 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 11:44:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP To: Jan Beulich Cc: Boris Ostrovsky , xen-devel@lists.xenproject.org, Thomas Gleixner , IngoMolnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , lkml , X86 ML References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> <5febc2c0-4355-48d9-9342-52d590041500@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JLsQo2xsfStlXt0qsnHsk5Ct" X-purgate-ID: tlsNG-33051d/1785923041-6CCDB4E9-0E4393B9/0/0 X-purgate-type: clean X-purgate-size: 11313 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JLsQo2xsfStlXt0qsnHsk5Ct Content-Type: multipart/mixed; boundary="------------0mvgBLd6VDmor8xQK9Xed228"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Boris Ostrovsky , xen-devel@lists.xenproject.org, Thomas Gleixner , IngoMolnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , lkml , X86 ML Message-ID: Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> <5febc2c0-4355-48d9-9342-52d590041500@suse.com> In-Reply-To: Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------0mvgBLd6VDmor8xQK9Xed228 Content-Type: multipart/mixed; boundary="------------aNYvgKSbnjvWNPRRggTG00UI" --------------aNYvgKSbnjvWNPRRggTG00UI Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTE6MDQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNS4wOC4yMDI2 IDEwOjU1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDUuMDguMjYgMTA6NDQsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA1LjA4LjIwMjYgMTA6MjEsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IC0tLSBhL2FyY2gveDg2L3hlbi9NYWtlZmlsZQ0KPj4+PiArKysg Yi9hcmNoL3g4Ni94ZW4vTWFrZWZpbGUNCj4+Pj4gQEAgLTM3LDggKzM3LDggQEAgb2JqLSQo Q09ORklHX1hFTl9QVkgpCQkrPSBlbmxpZ2h0ZW5fcHZoLm8NCj4+Pj4gICAgb2JqLSQoQ09O RklHX0VWRU5UX1RSQUNJTkcpCSs9IHRyYWNlLm8NCj4+Pj4gICAgDQo+Pj4+ICAgIG9iai0k KENPTkZJR19TTVApCQkrPSBzbXAubw0KPj4+PiArb2JqLSQoQ09ORklHX1NNUCkJCSs9IHNt cF9odm0ubw0KPj4+PiAgICBvYmotJChDT05GSUdfWEVOX1BWX1NNUCkgIAkrPSBzbXBfcHYu bw0KPj4+PiAtb2JqLSQoQ09ORklHX1hFTl9QVkhWTV9TTVApICAJKz0gc21wX2h2bS5vDQo+ Pj4NCj4+PiBTaW1pbGFyIGlzc3VlIGhlcmUgLSBpbiBhIFBWLW9ubHkgY29uZmlnIHNtcF9o dm0ubyBkb2Vzbid0IHdhbnQgLyBzaG91bGRuJ3QNCj4+PiBuZWVkIGJ1aWxkaW5nLg0KPj4N Cj4+IE5vdGUgdGhhdCBJIGRpZG4ndCBjaGFuZ2UgYW55IGZ1bmN0aW9uYWxpdHkuDQo+Pg0K Pj4gSSBhZ3JlZSB0aGF0IGl0IHNlZW1zIGEgbGl0dGxlIGJpdCBzdHJhbmdlLCBidXQgaW4g dGhlIGVuZCBJIGJlbGlldmUNCj4+IHRoZSBjdXJyZW50IHN0YXR1cyBpcyBva2F5LWlzaC4g UFYtb25seSBoYXNuJ3QgYmVlbiBzb21ldGhpbmcgaW4gdXBzdHJlYW0NCj4+IExpbnV4IHNp bmNlIFhlbiBzdXBwb3J0IHdhcyBhZGRlZCwgYXMgUFYgd2FzIGFsd2F5cyBtZWFudCB0byBi ZSBhbg0KPj4gYWx0ZXJuYXRpdmUgdG8gYmFyZSBtZXRhbCBzdXBwb3J0IHZpYSBwYXJhdmly dCBwYXRjaGluZy4gSXQgbWlnaHQgaGF2ZQ0KPj4gYmVlbiBwb3NzaWJsZSB0byBidWlsZCBh IGtlcm5lbCBub3QgcmVhbGx5IGZ1bmN0aW9uYWwgb24gYmFyZSBtZXRhbCwgYnV0DQo+PiB0 aGlzIHdhcyBtb3JlIGxpa2UgdGhlIGFiaWxpdHkgdG8gYnVpbGQgYSB4ODYga2VybmVsIG5v dCB3b3JraW5nIG9uIGFueQ0KPj4gZXhpc3RpbmcgbWFjaGluZS4NCj4+DQo+PiBJTU8gdGhl IFhlbiBrZXJuZWwgY29uZmlnIG9wdGlvbnMgc2hvdWxkIGFsbG93IGZvciBhZGRpbmcgWGVu LXNwZWNpZmljDQo+PiBmZWF0dXJlcywgYnV0IG1pbmltdW0gWGVuIHN1cHBvcnQgc2hvdWxk IGFsd2F5cyBoYXZlIGJhc2ljIEhWTSBzdXBwb3J0LA0KPj4gd2hpY2ggaW5jbHVkZXMgdGhl IFhlbiBzcGVjaWZpYyBwZXJmb3JtYW5jZSBlbmhhbmNlbWVudHMuDQo+IA0KPiBJIGZlYXIg SSBkb24ndCB1bmRlcnN0YW5kIHRoaXMuIElmIEkgd2FudCBhIGtlcm5lbCBqdXN0IHRvIHJ1 biBhcyBQViBEb20wLA0KPiB3aHkgd291bGQgaXQgbmVlZCB0byBjYXJyeSBhbnl0aGluZyBI Vk0taXNoPyBUaGF0IGlzIChvciBzaG91bGQgYmUpDQo+IGVudGlyZWx5IHVucmVsYXRlZCB0 byBiZWluZyBhYmxlIHRvIGFsc28gcnVuIHRoaXMgc2FtZSBrZXJuZWwgb24gYmFyZW1ldGFs DQo+IHRoZW4uDQoNClRoZSBmYWN0IGlzIHRoYXQgWGVuIFBWLW1vZGUgd2FzIGFsd2F5cyBh IGZlYXR1cmUgbm90IHJlYWxseSBsaWtlZCBlc3BlY2lhbGx5DQpieSB4ODYgbWFpbnRhaW5l cnMgKHRoaXMgaXMgdGhlIHBvbGl0ZSB3YXkgdG8gcGhyYXNlIGl0KS4NCg0KQ2hhbmdpbmcg c29tZXRoaW5nIG91dHNpZGUgb2YgeGVuLXNwZWNpZmljIHBhcnRzIG9mIHRoZSBrZXJuZWwg aW4gZmF2b3Igb2YgUFYgaXMNCm5lYXJseSBhbHdheXMgYSBmaWdodCBhbmQgSSdtIHByZXR0 eSBzdXJlIEkgb25seSBnZXQgY2hhbmdlcyBpbiBieSBwbGF5aW5nIG5pY2UNCihub3QgY2hh bmdpbmcgbW9yZSB0aGFuIGFic29sdXRlbHkgbmVjZXNzYXJ5IGFuZCBjbGVhbmluZyB1cCBj b25zdGFudGx5KS4gSSB3aWxsDQpjZXJ0YWlubHkgbm90IHRyeSB0byBwdXNoIGZvciBhICJQ Vi1vbmx5IiBrZXJuZWwgd2hpbGUgdGhlIGhvcGUgb2YgdGhlIHg4Ng0KbWFpbnRhaW5lcnMg aXMgbW9yZSAiUFYgd2lsbCBnbyBhd2F5IHNvbWUgdGltZSBpbiBmdXR1cmUiLg0KDQpUaGUg Y2FwYWJpbGl0eSB0byBjb25maWd1cmUgdGhlIGtlcm5lbCB3aXRob3V0IEhWTSBzdHVmZiBi dXQgd2l0aCBYZW4gc3VwcG9ydA0KaXMgdGhlIHdheSBpdCBoYXMgYmVlbiBzaW5jZSBtYW55 IHllYXJzIG5vdy4gTm9ib2R5IGhhcyBtaXNzZWQgYSBQVi1vbmx5IGtlcm5lbCwNCnNvIEkg Y29uY2x1ZGUgdGhlcmUgaXMgbm8gbmVlZCBmb3IgdGhhdC4gVGhlIGNsb3Nlc3Qgd2Ugd2ls bCBnZXQgaGVyZSBpcyBhIFBWSA0Kb25seSBrZXJuZWwsIGFuZCB0aGlzIGlzIHBvc3NpYmxl IGJ5IG5vdCBlbmFibGluZyBDT05GSUdfWEVOX1BWSFZNX0dVRVNULg0KDQoNCkp1ZXJnZW4N Cg== --------------aNYvgKSbnjvWNPRRggTG00UI Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------aNYvgKSbnjvWNPRRggTG00UI-- --------------0mvgBLd6VDmor8xQK9Xed228-- --------------JLsQo2xsfStlXt0qsnHsk5Ct Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpzBeAFAwAAAAAACgkQsN6d1ii/Ey/q kwgAlENLixbffh1SBVhe3sWFz6j0uq2XADYRYKiwTMK9ic7L3Vvuu9roHT56SIivEKim2BzkL/7t rBMTAV61qkqJs0DxOLajX5HcpYLX8nNxYGuSMNclukSCnEvuXpGSBoa5eZlizASZNyjWm3IpeSuO E+FuxJfOEuN80H625y9YWocJmjRpTyW4fD/507Y5jCn9OWl/R65fQWwtZkM9WxR/iseqvibHGxg1 NWzOKzqOu+IEVQ1oUhjyN0iS43afKKe4wCf//LcULbgqahIxdawQ2y2wpC7mDOu2577h8ffiIdPH PaiAx/zpbIj7xLAK7QQLlBELXKo/gw9bD3YKbiigbw== =yloA -----END PGP SIGNATURE----- --------------JLsQo2xsfStlXt0qsnHsk5Ct-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:44:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:44:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383217.1626477 (Exim 4.92) (envelope-from ) id 1wrYBC-0005Fi-97; Wed, 05 Aug 2026 09:44:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383217.1626477; Wed, 05 Aug 2026 09:44:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYBC-0005Fb-6W; Wed, 05 Aug 2026 09:44:54 +0000 Received: by outflank-mailman (input) for mailman id 1383217; Wed, 05 Aug 2026 09:44:52 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYBA-0005FQ-De for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:44:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrYB9-00BWKw-Qi for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:44:51 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a730610-5cb7-0a2a0a5109dd-0a2a4502d992-16 for ; Wed, 05 Aug 2026 11:44:51 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730613-6ca4-0a2a45020019-d1558036b490-3 for ; Wed, 05 Aug 2026 11:44:51 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-495635a85d2so6730735e9.0 for ; Wed, 05 Aug 2026 02:44:51 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23ec2fsm7302644f8f.29.2026.08.05.02.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:44:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785923091; x=1786527891; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6/xC07hUjUOekDJMrhIxHqIepT3gweD/QF3bDgW0CRo=; b=INfxI3FhVW17vRpVGr4mLaypV40YA7P1zjppeiYtLDpx/YmUjGKSH4L9db0I1Lb83f t6oXuo/tHhjbDgFsHVz9aJpFD1mZq7jxxKatEvySISQ7qDhTxg1qI18Li9Y7jRlfB6DG dDmvLPDz5vIksJEd/4uyy144EVChwRImezorhj5l1H2QiEtL6oxHA+pDGZlWW+Xs+R4/ 8YO5iMQyGVYDmM5N2dLJ6gNlcWGer4E2+SyBjJpPWNHWtoDbMK8aPJKbH3ytU6ys8yfh yamKlm5dju50H2SaorYWhLwqdWOqvBzgcDUz3Ea3j1gCKeaSKuG88/g8X/A7POihRpIF mY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785923091; x=1786527891; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6/xC07hUjUOekDJMrhIxHqIepT3gweD/QF3bDgW0CRo=; b=fGJkW82/0Deg2WGmP62oWVgBpKbH0j3c0c/m/s0UKHmlukBjgMCCXZmtVxq+6xI1h3 26i8ToT37/u7XkSzmSWnk3DhWbo2rHfTseX7FISXoJKqb88lnsz8zyZPXMcpjZna8ORy rrE6tUT+/Dzlpimf/FCtkt4vmhnrgG723WHOWX3eA7LTT0XPVbk+BrLCFy/Oypooy2Qo Rwbed4etJ57fC8Wk42NnjdzrMmWG+Un7z2YPvtUHvrCUryAn+ttH25S312wrtkyPl0RF 5a+f45crwuQ5tVF5PohqYn3TDsDYaJtJgTVYaaaNTPSxkXM4l8vMhkMGx56NgBnmGRIa oCaQ== X-Forwarded-Encrypted: i=1; AHgh+Rp/IP0iIWd4g8Kg0S4xHLiSc7p9seTbEduSVC0cqVwcbdNlUwbyKVNaIlR824gEH4AIdR6gNgRCALg=@lists.xenproject.org X-Gm-Message-State: AOJu0Yytg6xOdoZiPJXoeO6b+HN0bE9lydWl5OqJ02872T4OLeBUXeXX RZN8dvHKtBQ+aH+ldJHHBCkV6vF7fzfIDbUacoARtvY2c8QwdYzzToewv7UakMVO8w== X-Gm-Gg: AR+sD13/okSiDjk9Ud/Kl+XeWToTUX2BU9arXggmB+9eAp30cN3yfaz961YU9EOAKNV jrr8UnxL72GW7uDqeYfm57/W30vfPJ0eXoi82MTwhpz1M/1yvfozHMIv5UWHwjJu2aGyK6MWaVD jrjvl7c2GTKRmyxWubuCoIinGzxWxpcTuQlaGbRhEQ+lMkYmTvgUoHhMIeyIIIH1Wn7OxHfryyU /oSKrpiHHQbVS2PxVGGF1yTD5MAgxadfUVI1EEmzQrCrghc6PVgGOECvW3FtEzMS5E9XdXi+C5V xRILd6Bjy+OTQPJAlJcKoVYpToClRim069gkvJsnPZosrrLpFxmfk6iprbG2M7zzW5jtexNxTgn ZVvTy1BQZ6UwF6k5UQ1jdE3ykjuByC8U4LgAr4ly7QDz901ynZ1Iubc1A1FfQv16ncArA09Vz1D +3gZUq27fGZVB2QlH+B3zTQAnrTLke0XgntJxkyfNsN99DbooA2amCJInK5ny4hkviASXgKKTk0 nxgv3ccatvVX2upLCrKeuD0Si70b7MOgODB1HGZ4tZQab9tXDHj X-Received: by 2002:a05:600c:620e:b0:495:6274:56c2 with SMTP id 5b1f17b1804b1-4994e70a6f5mr73830555e9.2.1785923091196; Wed, 05 Aug 2026 02:44:51 -0700 (PDT) Message-ID: <451978a5-7dfd-4b91-a241-eb13caf6d394@suse.com> Date: Wed, 5 Aug 2026 11:44:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] vtd: Move intremap table to xenheap To: Teddy Astie Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319343.8631fc262581453bbf619ec5b2062170.19fad5345fc000e099@vates.tech> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1785319343.8631fc262581453bbf619ec5b2062170.19fad5345fc000e099@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1785923091-303C42AC-842312A3/0/0 X-purgate-type: clean X-purgate-size: 741 On 29.07.2026 11:59, Teddy Astie wrote: > Interrupt remapping entries often needs to be accessed, and we're creating > pointers to it on demand, which brings a lot of complexity (e.g > GET_IREMAP_ENTRY() macro), move it to xenheap such that it's persistently > mapped and we won't have to worry about mapping and unmapping individual > intremap table pages. Afaic: No movement from domheap to xenheap except for _very_ good reasons. For the case here that is - maybe establish a permanent mapping using vmap(), but no change in where the memory is to come from. Whether such a permanent mapping is really worthwhile may also want supporting by numbers. You say "often", but you don't qualify / quantify this any further. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 09:55:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 09:55:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383229.1626493 (Exim 4.92) (envelope-from ) id 1wrYLJ-0007J1-8j; Wed, 05 Aug 2026 09:55:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383229.1626493; Wed, 05 Aug 2026 09:55:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYLJ-0007Iu-5e; Wed, 05 Aug 2026 09:55:21 +0000 Received: by outflank-mailman (input) for mailman id 1383229; Wed, 05 Aug 2026 09:55:19 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYLH-0007IQ-AR for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 09:55:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrYLG-00ESqr-6z for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:55:18 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73087d-bab6-0a2a0a5309dd-0a2a4505ae3a-24 for ; Wed, 05 Aug 2026 11:55:18 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730885-4cb1-0a2a45050019-d1558033c1ae-3 for ; Wed, 05 Aug 2026 11:55:17 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4954aff6088so7909135e9.3 for ; Wed, 05 Aug 2026 02:55:17 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec24a24fsm8080783f8f.36.2026.08.05.02.55.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 02:55:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785923717; x=1786528517; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7k23JfBGtG8w8FZKJzglvJRq6dDsmFwVnAzVqjhZ8JM=; b=FZulFFenbwbAp/KQsRasxbwl3tEHwsOECEkaj4GBZwykcRfSWb7ie5GACUHQR1Y/pe MbRFChmSboUTcG0lhjIXGK/Mt30ya8wWIIx/pd2P5667CVz6f7UdWtzDJxE2ezfvAIXd v9EMiP+iYMSZBaahRoGQeQ0K0S3UJ3FnYNd5r9k3n/+i+Z/R3pMF+cht/caYtQQtfgFB /OvPtB3d1nJFWVM7x9oPRmqB6LbrsA1vlYf6YxFpv4qHOAsI5GTM5qX5Ltci5iGGsw7D GZF6TuwXdgDXCjMcLjfBoGQI+5gAUANaGQDO4KUjQuHnpKvXKI7U2xHOzvn6ubu8pxpM ucNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785923717; x=1786528517; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7k23JfBGtG8w8FZKJzglvJRq6dDsmFwVnAzVqjhZ8JM=; b=NSQl5ikGlkRzvlfT/1QbtXtLnwRVqbAZK3fNtsSnLOCE0KBRPO9hNGEeig+LN6I3SC d4FsCUI+XXK6R/dFQZRcqDKXxVuVDOE8DVRi8uZqV7HwSbBnfYzWQ+XI+jhcIJJYPQHF DLRyinTgmXshSoDEih9OqE223Nq6vA1jIJNDSw81EVgC7tOsh0GhS44FvKd4DdNr0ECF 9HzSzieD8Ahy+ZWZ6B2I4ipdQawFp1MmtdOmNqrCysGFjQMr8dak8hJ9kow7Xvrz4uU6 2fyd3LZv7wwLMIbBUrtQ/vSeDVe8Zje4R2lQ+Ms2nrI9SR64OvgA5MXGrD+obOMsvzu8 nA6A== X-Forwarded-Encrypted: i=1; AHgh+RqV5UnCzqYJ8nN6zhxlWBaASS7+cqZdEGiLUTve0hNz5Nja+GQNuE0J+gqocBq7qQSdfr0Zq47FIv0=@lists.xenproject.org X-Gm-Message-State: AOJu0YyavtesLQeqznFbugux04G/u/Iiy7beZMAFuKQXLdlkQGfX2O/2 bHRBNMqgS+OsOhX00Q9YV5wYXyakALo3Xbo2DHMU/GmnpmvE4h39EEieYhhdYvTBB2pzD0EJlN+ saWlOGA== X-Gm-Gg: AR+sD12fkEUFoURY4bAk9o7jyF4wjwbzre/6ZHlm7Oig/953uYdelv6PBXfrk+y4EyD 5CDMHIxArb8JAYZXbpZgsKmmWyZOJiEAglKem13yw+vErxUzTzFMFV47LLKlgy97XOoV5Vrtzpz Q1gQi0URn1YeV1GYZVV5Bvlsf4TRQDgIfobhK9iCV5FDk5NJ3+fO8GAJDNZLMjZ5IuuOVIyWCEl h7C6WrNmXPpMqSm9dQ6BoLUOJiVchOH/MYJ9z0epcEwYqPU+sfKb1/vv43UGUnw0Z5eLA7+RRVG egjyaev8NZOUcavXxUdQzvWqhtaH8IToWcrEPMFqrkxYHzu/CX/DycC2bBCUsleUFOJW1b1sVeg 0oh9eaq9LL/byDHraUmjEqjoKf47cNqaX2/o26jTyYcsCH89GyN6asuFiY7twR2kQl3NGe9/cdw OhdAjKyMUmT18JUzo/hNYCPyWxxCBfStljLmZVbfY5YAOon0Hzh0Z33I59SknqugLje4GfXYpFj wZFZfBU9AANU05Ifta20wh3NW5Bb1xTj+cxNPQWutr3MOzqAJLn X-Received: by 2002:a05:600c:1383:b0:493:bfad:9d99 with SMTP id 5b1f17b1804b1-4994e7caf7cmr55828995e9.13.1785923716237; Wed, 05 Aug 2026 02:55:16 -0700 (PDT) Message-ID: <38863d15-c6d3-426d-b09c-3dbed9f2f0b0@suse.com> Date: Wed, 5 Aug 2026 11:55:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Boris Ostrovsky , xen-devel@lists.xenproject.org, Thomas Gleixner , IngoMolnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , lkml , X86 ML References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> <5febc2c0-4355-48d9-9342-52d590041500@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1785923717-732B32A1-0584B9CF/0/0 X-purgate-type: clean X-purgate-size: 2699 On 05.08.2026 11:44, Jürgen Groß wrote: > On 05.08.26 11:04, Jan Beulich wrote: >> On 05.08.2026 10:55, Juergen Gross wrote: >>> On 05.08.26 10:44, Jan Beulich wrote: >>>> On 05.08.2026 10:21, Juergen Gross wrote: >>>>> --- a/arch/x86/xen/Makefile >>>>> +++ b/arch/x86/xen/Makefile >>>>> @@ -37,8 +37,8 @@ obj-$(CONFIG_XEN_PVH) += enlighten_pvh.o >>>>> obj-$(CONFIG_EVENT_TRACING) += trace.o >>>>> >>>>> obj-$(CONFIG_SMP) += smp.o >>>>> +obj-$(CONFIG_SMP) += smp_hvm.o >>>>> obj-$(CONFIG_XEN_PV_SMP) += smp_pv.o >>>>> -obj-$(CONFIG_XEN_PVHVM_SMP) += smp_hvm.o >>>> >>>> Similar issue here - in a PV-only config smp_hvm.o doesn't want / shouldn't >>>> need building. >>> >>> Note that I didn't change any functionality. >>> >>> I agree that it seems a little bit strange, but in the end I believe >>> the current status is okay-ish. PV-only hasn't been something in upstream >>> Linux since Xen support was added, as PV was always meant to be an >>> alternative to bare metal support via paravirt patching. It might have >>> been possible to build a kernel not really functional on bare metal, but >>> this was more like the ability to build a x86 kernel not working on any >>> existing machine. >>> >>> IMO the Xen kernel config options should allow for adding Xen-specific >>> features, but minimum Xen support should always have basic HVM support, >>> which includes the Xen specific performance enhancements. >> >> I fear I don't understand this. If I want a kernel just to run as PV Dom0, >> why would it need to carry anything HVM-ish? That is (or should be) >> entirely unrelated to being able to also run this same kernel on baremetal >> then. > > The fact is that Xen PV-mode was always a feature not really liked especially > by x86 maintainers (this is the polite way to phrase it). > > Changing something outside of xen-specific parts of the kernel in favor of PV is > nearly always a fight and I'm pretty sure I only get changes in by playing nice > (not changing more than absolutely necessary and cleaning up constantly). I will > certainly not try to push for a "PV-only" kernel while the hope of the x86 > maintainers is more "PV will go away some time in future". > > The capability to configure the kernel without HVM stuff but with Xen support > is the way it has been since many years now. Nobody has missed a PV-only kernel, > so I conclude there is no need for that. Just FTR - I did, even if maybe I never said so explicitly. But as it's just me ... Jan > The closest we will get here is a PVH > only kernel, and this is possible by not enabling CONFIG_XEN_PVHVM_GUEST. > > > Juergen From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:07:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 10:07:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383238.1626507 (Exim 4.92) (envelope-from ) id 1wrYWV-000111-7x; Wed, 05 Aug 2026 10:06:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383238.1626507; Wed, 05 Aug 2026 10:06:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYWV-00010u-5R; Wed, 05 Aug 2026 10:06:55 +0000 Received: by outflank-mailman (input) for mailman id 1383238; Wed, 05 Aug 2026 10:06:54 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYWU-00010m-45 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:06:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrYWS-00EVwl-QM for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:06:52 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a730b31-5cb7-0a2a0a5109dd-0a2a4504c2d0-34 for ; Wed, 05 Aug 2026 12:06:52 +0200 Received: from [52.101.53.26] (helo=BL0PR03CU003.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730b3a-b57f-0a2a45040019-3465351a0a1b-4 for ; Wed, 05 Aug 2026 12:06:52 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by SJ0PR03MB5934.namprd03.prod.outlook.com (2603:10b6:a03:2d7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Wed, 5 Aug 2026 10:06:48 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Wed, 5 Aug 2026 10:06:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rZpW0BROxTfHjzuJU4o1GkK8FP1LTcwLhbe0ORRr/6owjGw86iXsl0O+ZXE8ltdHeP2sqDFcAUKuQ7iY5Z0+zCwGG+In7ByXobsRlSljMiGOkaElnPND1Y4wlzKpAKLVd1EHWR8Qx/1xh+nXm8+o3jCJQutuWh3KLdZO1Fy3xpg8/kC7myyuw5FYGQegqvDWgkCAbUboGIDPYDuoYb5hSM7dSx0VoP5ZZ12lqjGmedVULivHNKnsi8J6h5pIMstzBdBVDzLcMGdrVCjJYoiYbAKH21hyGqe6Ok44jG+cItP6wMVOA/iYNWKV8NgMw92VW9b/w7heeis0JPFbQVwt+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ngLbiuAqbM9UA+pFpFmc+uYb8kAOJKSP7HZondo4IE=; b=SU79PPMnLEXMkygTdWYzxWbjgfl/CDQP3uVRRtuAqd3Owt/mgEGonjilqlKqS+3VkNqCRMpw1MpVSuWapnU3W7WowEN7aKdLqC9YfdGivCyBB6hirYb4Uw1+x7flEtC7MppMIudRfqyZnwTGeQmY8hRsTIrEeNNqC6cFmXXrAukSxcByKfdwI3Og1o2c+k/lJrPktNVGqwyeviiAdGxre3evlCOuoba9pYPLoprI+VErp7WO0I9YOAtWFr/BeoKCWpPKnpVk+D+UfEiZwdxSW/C9cyiOZCUhKnYqxrFYtWMFvCqb4pRhBODX3qe/qCprzC2GPsQIaBr7cS1SQZPu5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ngLbiuAqbM9UA+pFpFmc+uYb8kAOJKSP7HZondo4IE=; b=ptx8NVG/S7FsCtDsFQzBvrs4/3ZOFPSIs6yROOn/vX4LsQGTlu4WAdijuZZrmkt6fVoSQrI/VcQKQoF2WBCjFmK81zPajGTFS90QTXSAdRKtcJH2JM+ru6dNSpu2g1gHQivv79jAUMpF2YowToMcoPfLNWeJWMkcDcxpSVk2ZjM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <59d0de8f-2d97-4f65-af16-876be20398fa@citrix.com> Date: Wed, 5 Aug 2026 11:06:45 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org, George Dunlap Subject: Re: [PATCH 5/5] vtd: Move intremap table to xenheap To: Jan Beulich , Teddy Astie References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319343.8631fc262581453bbf619ec5b2062170.19fad5345fc000e099@vates.tech> <451978a5-7dfd-4b91-a241-eb13caf6d394@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <451978a5-7dfd-4b91-a241-eb13caf6d394@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P123CA0031.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::10) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|SJ0PR03MB5934:EE_ X-MS-Office365-Filtering-Correlation-Id: 00404da1-281d-4aab-e806-08def2d9435d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|1800799024|6133799003|56012099006|10067099003|4143699003|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: NZDK67+P31eRWs/XL9YxnZy8QNfGQ97iYJ9YMjT1ybptJCdQP6QOr/8tuIAqWK8p5AwK8HoMBKMOZ7Ixz+2u4qkYcqjjpId8BSzHdO9e2/REON2EBykS8qM3Krcv7qH9TnkIRjpoqpsMYTftdc/g+xc/E3ILwuCdFx3Bh81OLEJvzRZOOu+fMUa9gj0Rsfifqi7Q+KCw5gsEfSGNyCh79okpCXWwl6PiHF4FQlIav0Juf9kmJzF+HTiaB5pUxhDyP79crRRchTj10UHpPhEQr+vO7xscNZboqUiEXIWDCuWJFHrQkYZKj00wJ1ELVT/6OsJi+UF8srfIvubu74/KSyPEwkqZkT02Q98PjTBHDpwQOJmeYtS4cjtgBy+4zgXwfNBOUsb9eS+2Fv4eC4c/PAdK2dVPo+j48MQuf5vXBAi0BkZNe16KujfeJqFgfW09VndVjLwD/4UnG6SCbSbeJ9i3ZAofNphMss70sQlixA4ofFq/Jwqy7epjztLm7W4Dg0/dPCks2UyObozjmvea1/a3+GtutD9Q8XFbqyksbcEyWmZUrdQxi+RPKBoxnj/PIDohEZi1DXutTAKQ51lD8I11ytHlQaHrlBdqk5pi2a3PQIN0KC9Pnkb05bCBJVRH5dgYdqySr134LGb/N/xwAg/nEC3trSwFdqe7PNLT0rY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(6133799003)(56012099006)(10067099003)(4143699003)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUpMa0FUU1VER05VOHk2aEpKUlVHQ2JqNjZ2cnA1Tk9TYm1Ob1JrT3NPN0lZ?= =?utf-8?B?Y0FDZ0FrQkpYRjZ4cmEwNWo1OEJySGMycWdWc3JBZnJxQlhYaXhFbk9TQlQ5?= =?utf-8?B?d3VlVk92Q0dxazV0clFTbXRSRDZXbmxmOTRnSWJvZVNETUJ6SnI0SER4UStm?= =?utf-8?B?c0pySkgvV2NhNkZjN3d1VkZVWGRqdjNsNkdrQzNWNkg0NlRzeGxyS1praUZL?= =?utf-8?B?SVl0Qkg5eWpSOG9RYVN2Y2VEekpzM09ldjZCdml1QWpBcDhrd29DL05jWkRQ?= =?utf-8?B?V01Kd1pTUFBQRHE3dVQ0bFpwWlJqUVBmSFFGS3EzUVQveDFsN3MzM2VCcWtR?= =?utf-8?B?QVBESnJuMHFrRFM2WmlKQmZXdmhTSHZEdHdqencrV25lZThpMXp4NGk0L0o4?= =?utf-8?B?cDB0b1VmU3prUWhCWmxIaGwyYitBaEdNdUs1dE92UEsxMnJxVmRmTEF0Zk93?= =?utf-8?B?WGY1VktzZzQ5NXVGUVdjTFhnZE9yTEZaYkU2TEdhajBlUElYSExibmFjSDg5?= =?utf-8?B?MmNFTU5EOFdQVis5ZHFYWTgzZE5sQS9UdmRHcE5VQnF5dHlUTG40UitkNjRY?= =?utf-8?B?TTQxZDlBOWN3dTdNM0hWM0RVV2FlNnJpbWZScFVNVzVrTjh6VzJPVGZ0R2Nz?= =?utf-8?B?WWlHWVMzelU5aWlSV0tzMWlVR0dDK1RaQ0ZDMFp1R3VUQ3gvd0d5NWtDa1RD?= =?utf-8?B?eEM4bThNZWlZUVk5b2loYVU2U1d3cmd1cHZtZ2ZNbk1sSnRNejlIWFhCNVdy?= =?utf-8?B?bGxmQjZ4VXhrdkNWQ0RadHdld3RqOVhmZlZubEwyQXNSUUtGSlBGak9Fbm9K?= =?utf-8?B?Vlp2VW05enBBQ0xCTy9VSVFmN01vQTAzNWVJOW8wNmU1SnBrSzlnVmljMzlC?= =?utf-8?B?WndhMndUUW55ckhnMmJrNnd3aTR3VnQ2eFZWNnJTckR6L2lEUFJNcWZNYVR5?= =?utf-8?B?amJjT2UzSWhVdlhwWlNJaWpJbW0vOEdTWnJIeTNsYW9vUlhySHZ4Q0FMQlRQ?= =?utf-8?B?SExxaVdSbkkxcHFsajdEc25ieFBXTkpsSHBiUndLT1pJUzRxRU9KRmJlZnNs?= =?utf-8?B?aFVUOEhabTE3V0hRSW02b3o0M0krT2dxc2ZrbVFNQkQvcEkxSElzZTA3ZWRa?= =?utf-8?B?d1Bld3ZCY1hxSlhqZi93VXE5YlVUNEFwL082NVEva0hwV1pUZkxmTkF2VEJz?= =?utf-8?B?SXZsWC9HeC9idHFFUVZGQU9qenVKUVlCdU5rdUV4RFo2UCtXZUFZWFl4T1RB?= =?utf-8?B?QzRjQ3pmaU8zSk5IQmRVYVNRQnhIK09CWXlSbUErdWs0UGxxUEd5TnVaaFgw?= =?utf-8?B?V3BPQkVtMC8vWHdRWjFNUXpaVTRmcnFYaWV4Nng3cStGMHZKNFlTSWtnYnRI?= =?utf-8?B?YzZ5WXFvVmFqWEs0WjZOSVdSSnJFbXhsLzlYbVpzZURHTUdJQVdXbGVJZ09Q?= =?utf-8?B?T09IVzFxdDBDc0xCeTV5djB0RnRJVGNrcGIzZ1NFWHlmUDZQV3hHazQ4Qjhy?= =?utf-8?B?QkR2enBqTnE2RHZiR1pyd2ZWNWRRUExYN3N0TGd1cG1qNy92emhMcXZ2TkhG?= =?utf-8?B?cEJJVFF0UXhDdnZ1bnZuUHJpWnBUVUFwSE5XTXRibG9zeWpGcWtwRnNOZ3Fv?= =?utf-8?B?V0lOWnJmSWRrdzg0M2ppeEJoR2NmZ09mNjMrNCt2bVBNUFBnV2NTcDUrV3oz?= =?utf-8?B?amhsc3A2WXl1cFdoR2pGVUd4cTk4a0F6N2tUTGh0Q0pHZWRxYnorVlMweHZ1?= =?utf-8?B?ZEZvNW5ZTmtMQlhoWjAxSTRhdThSZmNKZFk0TGZlMU8wc212azMvQm1pdE9r?= =?utf-8?B?UEx3clNiNmJLLzV3QlczeGJNRkVIdldBMUhnMDlYVWk3c0k5T0k3MWVadUVr?= =?utf-8?B?S1dnTDBlZ0V0SFVyK3dBV3drQ3FJUFV6YXdTcU1xZmJwUXYwVGpsYVl5MGpJ?= =?utf-8?B?RXFNazVWaGNqdzZHVnRSbis2bHZjU21oeVpxYjBuenFmeDE4TzhUSVlZY2NU?= =?utf-8?B?VkVlTGRRTlRkNlR2Si9lemRvOVRiZmZiM3grMzNZc3orNUFGNnNRNUdxOTZJ?= =?utf-8?B?ejEzN01WeDduYVZKZmkrTGQzYmRmMkRTb05wL3RoNEpSYjJHS2RKZElXYklI?= =?utf-8?B?bW5Ccks1MGZwckt6dndWbDBraXhPVDRYVGN4ZzB0enFBSWlqdWdLSzMxN0xV?= =?utf-8?B?alMzOURDUmdoeW04Mm1JMVorZStzaFNNWVFSYXU5TU5VSGVSR0d5TjBoNDd2?= =?utf-8?B?YWF3SVhRUi9rRDh6UWdCWVNrejlkK2w0c1ZGMnFHdnEwU1BWT09NLzV1S09E?= =?utf-8?B?TENScHZsTFk5aGx6cXY4c1Mzb1VBNGE1UmEwZ3pSU1VWOURaSjZyS2VEdGVU?= =?utf-8?Q?uGeaMyYmGgluv8lg=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00404da1-281d-4aab-e806-08def2d9435d X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 10:06:48.6855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xi/qAKsVZtzFpjbb9EwtP/JeNaykidKn+Na7v+39dYVrsa48NtHPtMWAc4MQgzPvWe9FUabqJezjEMOzKBORi27i1Zon4S3mcGK5gTOnIS0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5934 X-purgate-ID: tlsNG-ebf023/1785924412-C3EC6B50-0B76682F/0/0 X-purgate-type: clean X-purgate-size: 1432 On 05/08/2026 10:44 am, Jan Beulich wrote: > On 29.07.2026 11:59, Teddy Astie wrote: >> Interrupt remapping entries often needs to be accessed, and we're creating >> pointers to it on demand, which brings a lot of complexity (e.g >> GET_IREMAP_ENTRY() macro), move it to xenheap such that it's persistently >> mapped and we won't have to worry about mapping and unmapping individual >> intremap table pages. > Afaic: No movement from domheap to xenheap except for _very_ good reasons. > For the case here that is - maybe establish a permanent mapping using > vmap(), but no change in where the memory is to come from. Whether such a > permanent mapping is really worthwhile may also want supporting by numbers. > You say "often", but you don't qualify / quantify this any further. To expand on the "why" a bit more. For systems with all RAM below the 4T boundary, domheap and xenheap are equivalent.  We have 5T of directmap, but xenheap allocations have a width restriction which is a power-of-2. For systems with any RAM above the 4T boundary, you can't have xenheap allocations be NUMA-local for all NUMA nodes. As for "often", the IRTEs are modified every time a vCPU moves to a different PCPU, because the target addresses need updating.  While it probably doesn't matter much today, in the context of ASI it's something which would want mapping permanently, rather than on-demand. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:18:44 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 10:18:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383250.1626515 (Exim 4.92) (envelope-from ) id 1wrYhp-0003JS-9l; Wed, 05 Aug 2026 10:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383250.1626515; Wed, 05 Aug 2026 10:18:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYhp-0003JL-7D; Wed, 05 Aug 2026 10:18:37 +0000 Received: by outflank-mailman (input) for mailman id 1383250; Wed, 05 Aug 2026 10:18:36 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYho-0003JF-47 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:18:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrYhn-006kKh-1o for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:18:35 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a730de4-e002-0a2a0a5209dd-0a2a450bc846-38 for ; Wed, 05 Aug 2026 12:18:34 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a730dfa-b7e8-0a2a450b0019-d1558034a4dd-3 for ; Wed, 05 Aug 2026 12:18:34 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4994c49f588so8219105e9.0 for ; Wed, 05 Aug 2026 03:18:34 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e52d819sm36549685e9.1.2026.08.05.03.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 03:18:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785925114; x=1786529914; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KgX6bksTA+tpxqRFpettIyoHBmuDk3+MMPRxWFaS8nQ=; b=XKe6TalWKGw5laz8btxNAQY6Efuwnu2T7Q4q/cfliOHU5kKsG+JUUNMj9xwPLlSNRR jjS3yfcsIGgZiH2BXqV6Kxz1aOZwkUozwJIl1lU1AGGUaJDJGEjqtwJeg5dOaFeKbm/j e0MNWgTaVzvgGq3gyZj33cvt2e8pb7ccFWoae2Gv2KSkfCy5di49R89d8+fsoIHXQTAM EC32N/p05g5lHqFPR+Ymfqi9/Fpi6Eq1xoiXKH5OLYjBSZOWzs6hwwGQGyUaM3RDHBVe EnkOR2dNvuKbf8iHN+OE1rfNiNm+UFIo3Rh22GkKKXQZig9mPLD3R5b5UWQBk8RnWEPO iaIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785925114; x=1786529914; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KgX6bksTA+tpxqRFpettIyoHBmuDk3+MMPRxWFaS8nQ=; b=ZCOy73LCHQzgz1T0PdVqZxLdc6TlYXmcMtQp9RhG0oro+ydxk/jWXlvwBx6NN1S2en XGPNVQJYekxnaEgwKS6QCKSSXqr6lNqhN/lS6yfradDyt+wRQCgvaVnO0Z5CPGB7mwEv hgOM1kMZB/QVWYVmZtQnbPiGJ+SKisn4oR5cIsg7Jlqg2/TYXC7eDMXpzd/8B0Wj6rHC paiAg3ChwKTQPTlQl7FX49t5G1cFT5S3KuTRBxicEpkuvH+l9VXewZSv4VRYGK6En/eB xD9wk/fvZlxlK0AIHVRQmG1mfbqfo9+znOWogKkscv4UJkUNZVr8AKQpzMntXDtOLWyb GcaA== X-Forwarded-Encrypted: i=1; AHgh+RqoIa5aSvCAzGEqlTKBahrkzsZCe4HBHuibe+0vCFG9C7843KzshBv3WEyaiRCq7AM0oT/Odw0rFKg=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy2JKhb0mblJR8tj3rhOyBHt+kT5LwugPc5jK7U68VrRKR5SBZZ gGmZ9OK1lIdqjWuLJAcP1N1SWybFXMfvemZxmdYxCBqSJ+boDWNkX2zGSa0+iK89NQ== X-Gm-Gg: AR+sD12s7XECbUlpiY5TRXC8QwlxeSqa5y8fMtsFHvomO68HUuxxRDdDzMnO21nCbZE LO23wDY2Un67SVnJbwoSFzVzU1FnH9U/Xt/dAK4aEWYVuG6gP/QYWKHS5htvOcwRh3WSPIb26Oa SWwIdCNi7nz10tx7VeYgvNzgEKtbxqkHypS6PPGeLvFU2y6GhwQziv7AqAxg2QnrW4Hxs6VPBLO St0PZUdFe8lI8tznuH7q0Bi1ZegvT7g+g2mcvABpLKbTCLmFdZubEanrhCM16oXoY3HnLDqKpW5 hqtRkTIvTtPm2wf0YxAwKwJc3YeryKWZlB4XfYFz6SSDC1YyHQgcF56p60+jFH6obBbgaM86OQH mTIR1u0WisEBxXkEAGfq8CwOdFGRlGtnQT6OUgBKWpF8lyoo3LAPnqMifR4GRH3sBeUe2A2Gbys hQWetmYm00jQ8yHtVKQcCZOTIzM4X87XMgkrbSr4Qn6aufjzLfEwbpq5klkz+ebqNBI05x88+VN XQKGLY4W+s7Udcf7ghmtWuUsKm8m6BWSfh6EtmoKxs1KcIvySZB2Q1Jvj9HU+A= X-Received: by 2002:a05:600c:468d:b0:493:f478:4c71 with SMTP id 5b1f17b1804b1-4994e382cacmr65576365e9.7.1785925114418; Wed, 05 Aug 2026 03:18:34 -0700 (PDT) Message-ID: <0491d3fa-ea8f-4cd7-822a-9c5a9be8d8fd@suse.com> Date: Wed, 5 Aug 2026 12:18:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] acpi: reboot: log reset parameters To: dmukhin@ford.com Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, xen-devel@lists.xenproject.org References: <20260801031737.344756-3-dmukhin@ford.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260801031737.344756-3-dmukhin@ford.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1785925114-1B6D29EA-20318E4D/0/0 X-purgate-type: clean X-purgate-size: 1659 On 01.08.2026 05:17, dmukhin@ford.com wrote: > From: Denis Mukhin > > Xen does not provide much details for system reset debugging in case > system reset happens via ACPI subsystem. > > Log reset I/O address and reset value. > > While here, add the missing default case, add breaks between case > statements and drop full stops in the loglines. > > Signed-off-by: Denis Mukhin > --- > - v1: https://lore.kernel.org/xen-devel/20260730001854.905354-2-dmukhin@ford.com/ > - CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2723268852 > > Changes since v1: > - removed wrong ASSERT_UNREACHABLE() And you replaced it with a printk(), which I don't view as helpful. If we want to diagnose the address violating the spec, that should be done elsewhere. > @@ -21,17 +22,30 @@ void acpi_reboot(void) > * on a device on bus 0. */ > switch (rr->space_id) { > case ACPI_ADR_SPACE_PCI_CONFIG: > - printk("Resetting with ACPI PCI RESET_REG.\n"); > + sbdf = PCI_SBDF(0, 0, rr->address >> 32, rr->address >> 16); > + printk("Resetting with ACPI PCI %pp RESET_REG at %#lx (%#x)\n", > + &sbdf, rr->address & 0xff, reset_value); rr->address is u64, and the code here isn't arch-specific. Yes, the file is built for x86 only right now, so 'l' as format modifier is kind of okay for the time being. But really PRIx64 would want using. (I'm sorry for not noticing this on v1 already.) Preferably with that adjustment and with the excess log message dropped again (I can certainly do so while committing): Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:36:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 10:36:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383262.1626525 (Exim 4.92) (envelope-from ) id 1wrYyu-0006GO-MG; Wed, 05 Aug 2026 10:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383262.1626525; Wed, 05 Aug 2026 10:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYyu-0006GH-JM; Wed, 05 Aug 2026 10:36:16 +0000 Received: by outflank-mailman (input) for mailman id 1383262; Wed, 05 Aug 2026 10:36:15 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrYyt-0006GA-5d for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:36:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrYys-00BgL6-Ek for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:36:14 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a731210-5cb7-0a2a0a5109dd-0a2a4501c8c8-40 for ; Wed, 05 Aug 2026 12:36:14 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73121e-5984-0a2a45010019-d1558036e589-3 for ; Wed, 05 Aug 2026 12:36:14 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4957eefd361so5911415e9.1 for ; Wed, 05 Aug 2026 03:36:14 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994dfe64e0sm78375335e9.6.2026.08.05.03.36.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 03:36:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785926174; x=1786530974; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cxgXNItvPHboV3BvDE9sEHj4kQfZuokLFmgUl2MM48c=; b=PTIw2ISP6anGSWdHxqsktqe9s+Apk04SNSgAhixjYnEzH1SfbJynFruxJxsKcSt5L2 6ygWa2KUbpbCdePdB6TSse+jsWvLa0efYKQMiEXNQ4mVEKgcYVgsJr2SB3kLCE/G9nD7 98xDvsB39jxSiGFDLi/PQXwQfkdPoSELnHLGU4NuJMDUosZRT5ndvWPkdzxMaKrYW56D JvrHbdXp+lz5q+STG4js623YN99obSe3PjdPzAi/qbPCMZEgYLixBrgjEJJ/2SbBD5VV K1cihG+GKjvKpz9j2gXl1v8ztOa5rFwntTMTu83Hrd68/VPOveVujJrjoFgu643f0tfd VzpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785926174; x=1786530974; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cxgXNItvPHboV3BvDE9sEHj4kQfZuokLFmgUl2MM48c=; b=drQqmZOnGlFjjVQ1h/132pNlm1YT0cuG0HsWTD6BHTco0cKsJ+RoUU23FSRyi/9mSk 9WdeZfxNRDwgeP/39nwADOJHQrV1x+0Qx/dfflzeWCH4NoXryRsjTp2GciCKvrQPfnaK T6SktSxLLUvrBafccIXg4wRJfIGONcfjDV6WN59Xf8KCAJsHppoXwIc47o4i9XGCxfPU b4GahYFJH4qdkhVnnmhPyQh+SbIWETW2LDFz+qSoJHPN+UHGkHfa0WTt20TpoobAF40s 3EWbm3VRcuvEEyxML1whtax9v6cnHA3ABFejzulci6VC/geYy64FfSr8FnEnkxfhItlg tflA== X-Forwarded-Encrypted: i=1; AHgh+RqGcfdOd+xg9XonUkHzhRMMR8ilwAsoLxYq4xZlCxv8BJ7C+RGil07gRRFeR8jF+6vFMHO0OX5FtSo=@lists.xenproject.org X-Gm-Message-State: AOJu0YxhW+besQ8XKP+XaIRS96alWF07vCHqQfcrGOvJmaqQtnmw5pE+ 2SOztQxaJHgBzGjkwjjQ2l1d+MdwsUe5KNCByC35on0mkNr6jr8OEfC1Obw7SyElBw== X-Gm-Gg: AR+sD10PWvyNBptxLntow9xQHo3qIUSccOE3ciOtdjyjlVGsbxN7HZENtIPOCpQY8rO 4fS91wCzPHjll8svRotvqXTrNKSJ7WandCG8Qu7zXHQmlcXuh4tqy85s2XCHm6BMeSPbpD5YV0i OtGjdh3Te8pfef5n7mIldbTVPhWI/VbOneQ718l7vUxWF4s2NxzSbRfCvPnkSR8iGvOFiPVloJV t1MPMGb1dfpHxDGQ78DzGtUifIJrtlglLiDi7kmCdgXQ9NKJeNK0lBTNTkeQU4y2y+4rzO5H2cG Uc7VrCrv1MbcxpeBXmHMSsdPu9t/wHLmIXnedr3ELG+aQEng8vILdP0EH1DKjBKus3UNgkNvV+v Loeks8AHntEjnPl4yK8L/nIdan18MWJvPcxEQwIETTUTl7BVRVAQxx/eR9AhKwPzM/MACVloJyM UUJtouen8JzVFsMGnpjxJO5nkZgei2oeL5IRkVrLrC1ZTbbDxZoyuQy2fu7Iztq8nfvuw2ijkQw vixidO3C9IT0P25J9HY32mzI3B9/1JuKfTVWqvM1iH/TEI3vrhu X-Received: by 2002:a05:600c:524a:b0:495:5890:8f6c with SMTP id 5b1f17b1804b1-4994e71d349mr54947375e9.7.1785926173790; Wed, 05 Aug 2026 03:36:13 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 12:36:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86/nSVM: Check the L1 IOPM_BASE and MSRPM_BASE assigned physical addresses To: Abdelkareem Abdelsaamad Cc: andrew.cooper3@citrix.com, jason.andryuk@amd.com, teddy.astie@vates.tech, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <966e58864089efbe30e9b900f09005fe13c74729.1785335079.git.abdelkareem.abdelsaamad@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <966e58864089efbe30e9b900f09005fe13c74729.1785335079.git.abdelkareem.abdelsaamad@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1785926174-BF66C757-4FD77AB2/0/0 X-purgate-type: clean X-purgate-size: 1487 On 29.07.2026 16:38, Abdelkareem Abdelsaamad wrote: > @@ -294,6 +296,24 @@ static int nsvm_vmrun_permissionmap(struct vcpu *v, bool viopm) > enum hvm_translation_result ret; > unsigned long *ns_viomap; > bool ioport_80 = true, ioport_ed = true; > + gfn_t ns_iopm_end = > + gfn_add(gaddr_to_gfn(ns_vmcb->_iopm_base_pa), (IOPM_PAGES_COUNT - 1)); > + gfn_t ns_msrpm_end = > + gfn_add(gaddr_to_gfn(ns_vmcb->_msrpm_base_pa), (MSRPM_PAGES_COUNT - 1)); Nit: Why the excess parentheses around the 2nd arguments each? Without them the 2nd instance also more obviously stays within line length limits. > + if ( gfn_x(ns_iopm_end) > domain_get_maximum_gpfn(v->domain) ) I don't think using domain_get_maximum_gpfn() is correct here. Imo you want to merely check against what the guest is told in CPUID. Everything else ought to be properly covered by hvm_copy_from_guest_phys() / hvm_map_guest_frame_ro() already. In fact for the MSR bitmap I thus can't see why further checking would be needed. And for the I/O bitmap it looks to be a matter of better error handling, rather than introducing extra checking. > + { > + gdprintk(XENLOG_ERR, "%s invalid _iopm_base_pa address (%#"PRIx64")\n", > + __func__, ns_vmcb->_iopm_base_pa); > + return 1; Why literal 1? Yes, there is another such return in the function, but no, we don't want to extend that. Aiui NSVM_ERROR_VVMCB is meant here. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:39:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 10:39:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383271.1626533 (Exim 4.92) (envelope-from ) id 1wrZ1e-0006pN-2E; Wed, 05 Aug 2026 10:39:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383271.1626533; Wed, 05 Aug 2026 10:39:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrZ1d-0006pG-VP; Wed, 05 Aug 2026 10:39:05 +0000 Received: by outflank-mailman (input) for mailman id 1383271; Wed, 05 Aug 2026 10:39:04 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrZ1c-0006p4-5f for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:39:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrZ1b-006oEi-FL for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:39:03 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7312b8-bab6-0a2a0a5309dd-0a2a45099690-28 for ; Wed, 05 Aug 2026 12:39:03 +0200 Received: from [40.93.194.57] (helo=SN4PR0501CU005.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7312c5-be1a-0a2a45090019-285dc239327e-3 for ; Wed, 05 Aug 2026 12:39:02 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by MWHPR03MB989486.namprd03.prod.outlook.com (2603:10b6:303:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Wed, 5 Aug 2026 10:38:57 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.013; Wed, 5 Aug 2026 10:38:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W+W0g7/jedY1MAiWaM+j/HHgLKK43EDgPP5ZKUZbA+0GpBGx3TqCYZBruDtefgL+DoYkpIeOh/NArljBSAKBJgT/vje5qKaRr7VeEZ1/487v/B/R56mBEic5csRIIV9qNFXfQgUJqpAtlkR9ZkWFb9kTssxtZVOIOG3x/AoCV0DP2ahZhs55+9JvodhUz8scNUmbH6QtXyj/3pBQd0nDo/XHbH2E8vhxsgroJnRdggtfri89fkIKH3G8AgB/sROWbfmQQbG0xnN7/JHFrRvKQwcpB4veloBgiatApP2YjS40o8Uf/tnRp/2tQvpNj0cs0/yvavvOmg2m4YSB2VLXiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2G36z5DJb7tx78qIdEDFAy0U8RinsowMaCbqdgXZMPI=; b=WYFOCygKpXVYtEJG5krxU9Mo3MGwgkEmxDpnNzlgUOhy/fZN9BiQ4SxKQKypwPXMqn0GlwpQaEEPIbKRsZBTblptXvABhZQzi2+/zVnZHWM5FOVxOd2ZDpF2UAneYxK7Awcn62mcfls/Z4mjzTKdT+DwHzEFpQtgKfNfCnEVLNhl2WNrcfEpE8yKYnCB4ds/suPAuh3U8FJrPfqIGbB71rgKaaZLs+K5ksqEqdLyELac+AtfneDYjaUImf08JyGk1zeDWYX94MlP2DI6z8mR0VGkh5xQwGUIsrwwff7sN9r3H0t/80D4UNnTffjvIF1RPp89o4KcW+tfGIEoiP9uWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2G36z5DJb7tx78qIdEDFAy0U8RinsowMaCbqdgXZMPI=; b=A89ChuRU3tzrBtdAZT20KNxmV90Bq9ZIg9PajTv6v/+9zQg5YAm3pRWtnpDSdbGAytSs8YIN8l4uVDEMo2J1mbfTY12R96AeaI4/tXCYVPpRn5I+QFkOK1wtCgXY8BoLbpvqXU5tVHnJhh68wk1AypCQ1CE+kKAw/igeUs7Y9Ug= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <81729a84-dccc-4470-ba91-4e7689c387fa@citrix.com> Date: Wed, 5 Aug 2026 11:38:53 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [PATCH] x86: reduce dependencies on x86_emulate/x86_emulate.h To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <2a4d839d-44ce-40fb-af7b-5becd878c9fc@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <2a4d839d-44ce-40fb-af7b-5becd878c9fc@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0059.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::10) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|MWHPR03MB989486:EE_ X-MS-Office365-Filtering-Correlation-Id: 074451f2-4208-40ac-5bb5-08def2ddc0a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|366016|1800799024|10067099003|11063799006|5023799004|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: m/YUzdVTEsZR0jLwB89c3a2t3NCf4AhImO3LMjphJaVgAdFEGqlCZiC1qk1Z0+ehyBrI2CZWJOWXNF8q5IYcrM3OAMYNh7mluVpX46csquPT0dLapsa3RpRaTi9ViXqTgXjJyKOD8tj0kQCY+0DEif3JGg5TWpug9JR7bjQVfXFhxxbqGiQwzX0ERXmiHJ3QbSIDHwGATo7VSWXCD36s42er+n9OJ4PerFQCOsU2d0VlkzAT2e7UXtpphj7o9TPTjgVUlQL8jtF0yc2CoX1JfpR1f9ku45LA9j4ZUMdt0YHAdYV4cIMFQyf8RC+/3COFO/jZzJqW/P7o2Q95RCYAb8F0qvxSzdHq//vEhQGRtrNPfEbaaQLk368PRug0pNpnH9lRXpJ135qjrM3u/PXFqVIr8A21wPdKMc/itZ6NkR5AnYG7KCDwbJ663jt+i/kPudsPDLzgj0Jift0gXk1NQyie5y2nV8WBofTSFWB67jeWnsNtZZea8jjyj5KKFKtJIF0SWnXUjc0uGG/+w2TZbrXUbcAAv0z/lLQHaYdJ16rFxM/m+C7HvlGqfnBidLqU4rVSxj5SvsbkeXiUHRhvL3b14g1tiH9NATGfGnsSQbnyxF3BCWbaszmvojnIc95GIBSufzEFvKWruKeVuMKOauNqXxD+LVKu64lIRAqo6xA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(10067099003)(11063799006)(5023799004)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2g1SnBWajBuc01URzgzcWNQdmUxem1IdjNFQm9HNDNQQUhtbUlFRWlKS1Bk?= =?utf-8?B?WlRUalMzQ3hpZ0V4STMzNk1ZNEE2eU9pR0ZJSTloVUNRbU0zVnlLc3Q5N0pz?= =?utf-8?B?WU54T1ozMlRmaVpjVDVQOGRack5pcjZ2WE14MFZOaFBSSmw0UGNuS01nVDZR?= =?utf-8?B?K3hQT3hqTWpIV2x5WGZZZkVFVG5zK1JBN3ZuRzJROHRhUS93UERLQW54U2ZK?= =?utf-8?B?RTF0TnVnQnhsZGVMSEUwVEQ1VzlKNjBVMTA5RldOVEczZ21lQ0xWRTduZGRl?= =?utf-8?B?M0RacnhkNFJEUmxOTnZQRU1pd3RDRWRpZGYzcWt0d3JucWJaeEVxOStZWXUv?= =?utf-8?B?VHgrY3hlekxSSkl6TGxvN015VDR1aklNVHpiS3k4Rm1VaitROFduNjdYTWhw?= =?utf-8?B?RUM0Z0JadW1HR1NYQUlnZk00R0V0am1lZTdUcmN6R1BKclozdy91SUxGUGd4?= =?utf-8?B?VUpJWkhnaGY3Uk9qWGF3TUtKWTBaTXREWUdOL3ZTMk9qQWl1c0NGU3VIb3NH?= =?utf-8?B?NHdrWThDMGI5WHpLNlY4RlhLWVN6anVLbEhrbGdsc3ROSm96S1AwMk9DOXNr?= =?utf-8?B?NzJWbldzWTYvNlBLSDJ3aisyUnp0Wml2OVJheG5CVWk3Wkg3ZWJ4bGhSRkUv?= =?utf-8?B?M2tQeDVFbGxnUWNOenpmMzRJWWtEVEYveUdzRjI5UExmVHUySTlXckpseTdy?= =?utf-8?B?VUc1QzcyUFNmUEtIbWFwZjYwdEtMUi95Wng4TVo5amh4dDJjYmtUeVhSVFY4?= =?utf-8?B?Q3dIaFIwQTdLbWEvbVU1SGk1REpUdUE1Wk9DTFJIdC9wdE1KNUlMRkxOWU9S?= =?utf-8?B?ZnJSMnpRMXR1RXZVei84blF0R2RpdG5FeExmRFViYkN4eUxFNC9tdURjc25s?= =?utf-8?B?Qk1nTm1zbkZqK2pjb2FvTmtlY2ErR0pYVnhqRUkrTnEyTmVqdkdERmQxYzdW?= =?utf-8?B?RkhnQlI0U21EYTZZL0hlZnRiS211ZVFoNDV6SlZkZGF3T3AybDFseFhra0sw?= =?utf-8?B?YUY0ODg5UytkZGRNK3pRT2lWVjJRSmRyZExiUnFrM1RudXBiSldtbGg1dmx4?= =?utf-8?B?ZnhqMTloTENNVWhreTFNQnY4UnJqM2lUaUwxRktzR0xLcnNGWE9xdXFMb0Va?= =?utf-8?B?bWtMV296cWZVNVRSQXZKYUEwajhNU05nUXRRNkxzakpzeVVyL1dMbTJBTXIz?= =?utf-8?B?SU5uTEdwbEJ0S0Jla1ZXNFhML0wzRDVodGRQOTE0VStxZXhybW5CejNBZ0Z0?= =?utf-8?B?dnFUWkxvZHRUdDEvYmtJcE1IMEh5OVgxczV0V3hlTVpOcTJPcWRVQjF1YTBo?= =?utf-8?B?blFjcGJ5RlJhOXdsaDFiYy9iWTdYYWZBeU03aXc0Q2xwK2ZkbFBCMVByU0ZK?= =?utf-8?B?K1lOcVZlU1d0bXlGYVd1S2MwYXlJSWwra00xMkorL3NackowRmpPZGVqRHo3?= =?utf-8?B?QXV4RCthM3FBWUZFdzRvckJxVHlIekNRTjdtRWUvZ3hBZjQ3Qm5kVnNScDk1?= =?utf-8?B?bktsUDdlczg1WkNqTU9PdzBQRG0rc0J0dlY1K3ZWdFZ4dzBjZkY5OVpHeUNw?= =?utf-8?B?M2VyeE1UQU83eGVMaUVXd3h5dlpJN081NXJFbitNK3pubWNReEUrS0hlQXJP?= =?utf-8?B?T1lzeDBJdkpCcnM0M2l6SXhLRkIxVjZuYkR4NERNaDI4RERva09BMWZHSGtr?= =?utf-8?B?TzZTQWlOUm9xdVBONGpmVkpJSnVyN05lUmVVSEpwbFQ3TnBDdXByVEo1TDlx?= =?utf-8?B?Rk96Mkc4Ri85VHoycUVWejY5eGVaN2FmaXQvQWovRUxiTWVVcTJSWFJOaUZu?= =?utf-8?B?cjFqTWwxT0JOZVlWclFHTUplai93TmN2MmdMZzNQZy96M1NuMzVMS1JlbXFT?= =?utf-8?B?TkdNQ0lGK2Rnbm01MXBmeG1KSHl6Sm5nWVJ4c3ZoK0JnT0lEazJqWE1mdmZP?= =?utf-8?B?cGhDNU1UdkxhZFZmTEpyWFBob09McFhVclhBbkhPWVc0WGNkZzNMTVJjQk1M?= =?utf-8?B?K0tuLzhPa0VrNUVDNm5QRnN6VWpTVDRDQVZvaDJHc1ViaEhnQ09rMklna0Jm?= =?utf-8?B?NTkrRU5jb1p2RDhwMm5sQ0RiNFVPMGtkZnFBUkZJWllXRHV3ZnJQUFpRYm9t?= =?utf-8?B?ZVRIdjdNVlNaYUpBajkwbTV5Q0I2T0F4RU0zS2NnVHEzb2ZDNTZTOXRQQkZu?= =?utf-8?B?YmRRdUQyMXFtQWNwTzRxMWcvY0diMkV1YTkxd3M4cEcrVXhEdzBQTEJma3hC?= =?utf-8?B?VjhCRVNwR0FYUmR3a2N5NU5hOEg1V1NmVkhLRjJ6cmVzdGJxRkIvYmhuTGh6?= =?utf-8?B?L2pGRSszcHE2Y1oxeXAxOGxHNnV1ZXpZUUVlZFI0SDZud1RPMTNweFB6OS9I?= =?utf-8?Q?vdoEJ7zdGT5EW6L4=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 074451f2-4208-40ac-5bb5-08def2ddc0a0 X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 10:38:56.8444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5OvAETnQXxiDsfe2NlywBbBmG5676F9GWlZM6FfBorXuRhQT4NprNJ4Hnr9/+O0PpUFwUFcXNIooH2Zvs/JSMZ1Kfc9y1dF/aTMRHJZlVvE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB989486 X-purgate-ID: tlsNG-bad1c0/1785926343-39CC7034-3817E674/0/0 X-purgate-type: clean X-purgate-size: 1540 On 05/08/2026 9:29 am, Jan Beulich wrote: > Split out struct x86_event to an entirely separate header, and move a few > other items describing the architecture to a new x86-types.h. With a few > forward decls of structures and with a fair number of new #include-s in > .c files, the inclusion of x86_emulate.h (and hence > x86_emulate/x86_emulate.h) can be dropped from all header files except > hvm/emulate.h; it needs additionally adding to hvm/ioreq.h though. > > Signed-off-by: Jan Beulich This looks broadly fine. However, I don't see any hunks downgrading arch/x86/hvm/svm/vmcb.h from x86_emulate.h to x86-types.h.  It needs struct segment_register, but nothing else I can spot. > --- /dev/null > +++ b/xen/arch/x86/include/asm/x86-types.h > @@ -0,0 +1,76 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * x86-types.h > + * > + * Type definitions and basic helpers which are more or less directly > + * describing aspects of the architecture. > + */ > + > +#ifndef X86_X86_TYPES_H > +#define X86_X86_TYPES_H > + > +#ifdef __XEN__ > +# include > +#else > +# include > +#endif > + > +/* > + * Comprehensive enumeration of x86 segment registers. This comment has become stale with the recent additions.  I'd be tempted to simply drop "registers" from this sentence while you move it. Due to the way we use these, we should even technically drop the trailing r from gdt/ldt/idt but I suspect that is going too far. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 10:43:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 10:43:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383281.1626543 (Exim 4.92) (envelope-from ) id 1wrZ5s-0008SM-Mn; Wed, 05 Aug 2026 10:43:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383281.1626543; Wed, 05 Aug 2026 10:43:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrZ5s-0008SF-JK; Wed, 05 Aug 2026 10:43:28 +0000 Received: by outflank-mailman (input) for mailman id 1383281; Wed, 05 Aug 2026 10:43:26 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrZ5q-0008S9-AU for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 10:43:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrZ5p-00Bh8Y-Ar for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:43:25 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7313c6-e002-0a2a0a5209dd-0a2a4506d6f2-28 for ; Wed, 05 Aug 2026 12:43:25 +0200 Received: from [209.85.221.43] (helo=mail-wr1-f43.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7313cc-195a-0a2a45060019-d155dd2bb919-3 for ; Wed, 05 Aug 2026 12:43:24 +0200 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47f84023916so705261f8f.3 for ; Wed, 05 Aug 2026 03:43:24 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfda0cbsm7652648f8f.6.2026.08.05.03.43.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 03:43:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785926604; x=1786531404; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w1Bb4vmR8cZXbl+BHofF+bpO39VFBzO9m9JaXAQs06w=; b=WGf1gFgCDF6dfHH31vFQ5XwdAgdfEabDfP26YBulucQaLizMy3S6Wvh1UsB1UKzuJi cjvAiXE+Hvx+zoAmStnWjR2TL47NSZtI+rbvTytyfFcwZ8Oxo6FXBCet3a/QDexHeQ1j 2CEa9288VdSjurveL1YmbiRASBhpQQxZgdPb5dd+X8L4pAB9iISjWIvmVs47emVoZ518 gKCxxz/fMGxVpBy/Afgjio20f/Ukz/u71Kk6fWf1md14MJcps+2ae8ZXu1DejWX4kznv oFCgFu5drZlQ1mqQnkPdSmUoMu2JIlgsAKD2Xd7dYoz2XwDgYLijo9DrhHn99GDDLLyn Qqaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785926604; x=1786531404; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=w1Bb4vmR8cZXbl+BHofF+bpO39VFBzO9m9JaXAQs06w=; b=OyXOmzjKXSli9g64F/fYdAd+QA4jBkvhH64YBR/JbV5ZITqGwePF0n0VCpE+Wm3xgm RRZWvHhWcqSZkkv/H6RQcbOecWsz+ElCtkmsUWwCnVd2udgpyeKdspw0vQgSoWClj0mE n+/5mzgUIt82MZMCNUNqkX6hG8+DQcyDemEuxkQbtEN5ZCE9Ouwl4syOkhtxXOuxIEgK 7wZ93GslwdvmaVM1Gtt0EW2P5PBauLnJFGbTWKK1QfGVrVj4632Bd4i0sa/EWHTaBKkJ 7c05ByIDr5Ov7iedrQfRydeDnlT2g+OtGSCH21xQ9Z9VbcVRfg8u3i3e1oMl6Z/wzPv5 OSCg== X-Forwarded-Encrypted: i=1; AHgh+RqvOtRO5mKJLGNifD8EAQAMmasTQf55JO06pP0nbqxhi4vS1b0HEvntKCGx7ZWugeCAJfo2rRMD0d0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxGm8c1FRg91xx+3MTaEsx7vX56z1drFfQjungwH3dXCeWPrwle 2NhK21QSM46C3J8qRL8oJckrnBn8LNxAWKWFzoS7SZWIPNor3BPv/yeA0TWoBOuos56s4RFJv2X aCDMOOQ== X-Gm-Gg: AR+sD10CL/ZKTbXG3CFWioEsKlJBslzAO/RgmxhAR/MtROlPDlKb1iiu2ikFjHCJJGe HLYpwV84vcuIM1Cs9Xh0+6UTjSiNDr4k+XaNyjU7kGgeSML4SHQQd0Pk2DE12CbWVROXwXSbAoD DIDCjBVYcFHivH1UBAc2+YhXUOIQRFY9mMXETO3cjg/Y6oyZdLi+WkPrPUc2+swg/UpVaLlG/yn Pn/53AsBD7cJ1daG+/v3+SJY3qwqgJAvUkNDzP3QKC0Ge4RS3rXRXRb128Z2VQUcVP+8FBL8c15 Wh41W81e6vAMaS1yiAYV/+Q9rgaDwLbpiJAcmXGwqKIoAxgOGjIsal4ZJFefIFCo5xZrqn/NgwB I+0r4CobndJ9j/OGCrk+vDjdtZef8bEOLhBFTcWZ37dFoYTyHoFhu08ThcCylEvlYbvZZ5u2r0y 3a1MTC85JUnkIw2tiaIYnn3HFoDikWqY/0zovDbBO+BUZzQvd+lZvPNnAFeP6+qpH8PJW/Qz25A ELkrJZDJp328EjpDoeTN4FdXestWYF3J+tjAsy3oYkmW6hALWrR X-Received: by 2002:adf:e6cc:0:b0:47f:97e9:fe60 with SMTP id ffacd0b85a97d-47fec51a252mr6403140f8f.15.1785926604441; Wed, 05 Aug 2026 03:43:24 -0700 (PDT) Message-ID: <13dd0296-95d4-43e4-9d79-3ffa113927ec@suse.com> Date: Wed, 5 Aug 2026 12:43:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: reduce dependencies on x86_emulate/x86_emulate.h To: Andrew Cooper Cc: Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <2a4d839d-44ce-40fb-af7b-5becd878c9fc@suse.com> <81729a84-dccc-4470-ba91-4e7689c387fa@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <81729a84-dccc-4470-ba91-4e7689c387fa@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1785926604-FD40B77B-5019A7A0/0/0 X-purgate-type: clean X-purgate-size: 1624 On 05.08.2026 12:38, Andrew Cooper wrote: > On 05/08/2026 9:29 am, Jan Beulich wrote: >> Split out struct x86_event to an entirely separate header, and move a few >> other items describing the architecture to a new x86-types.h. With a few >> forward decls of structures and with a fair number of new #include-s in >> .c files, the inclusion of x86_emulate.h (and hence >> x86_emulate/x86_emulate.h) can be dropped from all header files except >> hvm/emulate.h; it needs additionally adding to hvm/ioreq.h though. >> >> Signed-off-by: Jan Beulich > > This looks broadly fine. > > However, I don't see any hunks downgrading arch/x86/hvm/svm/vmcb.h from > x86_emulate.h to x86-types.h.  It needs struct segment_register, but > nothing else I can spot. Hmm, yes, I can apparently convert that as well. I was really after tidying non-private headers, primarily. >> --- /dev/null >> +++ b/xen/arch/x86/include/asm/x86-types.h >> @@ -0,0 +1,76 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +/* >> + * x86-types.h >> + * >> + * Type definitions and basic helpers which are more or less directly >> + * describing aspects of the architecture. >> + */ >> + >> +#ifndef X86_X86_TYPES_H >> +#define X86_X86_TYPES_H >> + >> +#ifdef __XEN__ >> +# include >> +#else >> +# include >> +#endif >> + >> +/* >> + * Comprehensive enumeration of x86 segment registers. > > This comment has become stale with the recent additions.  I'd be tempted > to simply drop "registers" from this sentence while you move it. Can do, sure. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 11:21:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 11:21:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383297.1626552 (Exim 4.92) (envelope-from ) id 1wrZg7-000627-D6; Wed, 05 Aug 2026 11:20:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383297.1626552; Wed, 05 Aug 2026 11:20:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrZg7-00061z-9m; Wed, 05 Aug 2026 11:20:55 +0000 Received: by outflank-mailman (input) for mailman id 1383297; Wed, 05 Aug 2026 11:20:54 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrZg6-00061t-HH for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:20:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrZg5-004Kzs-EH for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:20:53 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a731c8b-bab6-0a2a0a5309dd-0a2a4507d992-38 for ; Wed, 05 Aug 2026 13:20:53 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a731c95-b4ea-0a2a45070019-d155dd2ac0b0-3 for ; Wed, 05 Aug 2026 13:20:53 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f64ca1c2dso263173f8f.2 for ; Wed, 05 Aug 2026 04:20:53 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfe5b1bsm7185664f8f.12.2026.08.05.04.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 04:20:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785928853; x=1786533653; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TDLOIIhSUY69RWK+VPCe0WXj5DQ3s8AJzrsRVAB1iYw=; b=IboKLv8M/CM1IgP9QcnSxbl9l6wYB9qszsncKZ8mFrlvCBhISjJL8RI7KxlZe2Wy9/ S4ZNXi3RifWvzVsG2a5BEUGyGPp5h5U/C7+XNFB+cu2VqBtmwH34OV1aYjZkNmJfRUuR BitR53h2jw9krAMJCloElKUMUlVQw0DMC33CZB021eo566UgZ5v/VSNLfl9JNidf9/F6 LwEtZZpaPz2USxsh8qGnwjTS0dQeiCUINiHhTOOaBlmGyELp7AGC7NOSkWWrUO0geC1a ABx0vCWytam5qQVPwBOn0ESoezDZ0sATZVsg04wmc6Fwmsh5AwNItIRg3x+ClX9fN5rR DRgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785928853; x=1786533653; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TDLOIIhSUY69RWK+VPCe0WXj5DQ3s8AJzrsRVAB1iYw=; b=iyUCDs2PKcewM8YcRRufuqA8Q8sOwVrFMVVg5EIQagPR7zLe1Jj0B8Wy0nM1btUNcm GUI9Hh6cmMX8WyX77D57aEIluQvRkQcp7Yca7u24l2yZ0WmpaTxMGD4aAOtCotgWVjLe TNbWloB7tA/9Q5f3u0688EF5Z4xBevotuy0K7k14r9B+oEjkyMnpGntn5vl1i0nBbihD 07QY+7r1fUK8xhDIIsVL+FuOhpbLmj/DuxkAk7GPRINl9HVk7Ax3LqpsgvTlT6w+CtK4 MFWQhbCypHzUfUnSwwz6+zdtxIYIDlgbF4dhNvYsZkvF/Q7IhRA/4+B/t81yJhFRhNNb yWpQ== X-Forwarded-Encrypted: i=1; AHgh+RqeXwgsQ2TXw7CC0HkzP8eXk0e7YFlFfiR4zq8aHQNvB2WhGVd7GxmeKTsXV04VM4YSBfdnrnNpnZM=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxb0Osp9Z4mR/JIz3PITZNQ5sLrv5bkRen4E4+XoA/HuU4Ufhk1 +C0EGd0xQTbis5dASdQ952zyKjuZrcDVAWUxeUj3PlyJepsHrN50rYbH X-Gm-Gg: AR+sD101AwSFAMh0rJXbW0iK+c53eV2NFc4R/sQuzLdNS8ZS1tHmw5+77C8hCUQu7Jc jm1hP+4jrGV/774ELc2LQkxu1yWkR+eT4XcpAwyKGwiOT+/O3MSpMV8Fq+tlrN621jvrM3TwGgU DVuMadNuqk1xCDR/ywm/zvL9IMQBcEOAVnBYcUKrHY02FNgNCxMtVxm2imuOPmZfgvwvZ8+2PYl nrI18psWMJHDbm+Ypd5RYQ1e5amAQ/Y/bXGfY/7Wr3yeKMg7zX2n3Ru9X1FlxFB/BHduXqxG4K4 Voa0lawvDFxt/WX97ptobsMSj7uOr38wWMeIXkh1Krb9tesFV3yitYKYaGePXKIkMPXAuahKYqA cvC4Mm4ZFCZDcUi/g8XtU7s8J2o4211rEYH7XydXuHzNtDm55hXwLI/lRqFmaV5wZhsa/qHNHjq In8PNjHxcGxagHRwZKCEN4fazQFmGlU3EkcDXtZQIgE6Cl2qmOhylLmc7PbQULPZDBRUziv30yZ 2yfT0hBcAEnyQ3C2ieZP8rnjL7aE6J3F0kwFuHny9yzB5yqNBuQAA== X-Received: by 2002:a05:6000:4608:b0:47f:9ac6:ca60 with SMTP id ffacd0b85a97d-47fec484655mr10521923f8f.0.1785928852613; Wed, 05 Aug 2026 04:20:52 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 13:20:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/livepatch: Move init_or_livepatch_* into xen/init.h To: Andrew Cooper , Xen-devel Cc: Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Ross Lagerwall References: <20260803150925.408857-1-andrew.cooper3@citrix.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <20260803150925.408857-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1785928853-A74D3AE4-45DEA9BF/10/73395122804 X-purgate-type: spam X-purgate-size: 1184 On 8/3/26 5:09 PM, Andrew Cooper wrote: > xen/livepatch.h is a fairly heavyweight header pulling in public/sysctl.h, and > a reasonable number of users care only for the init_or_livepatch_* tags only. > > They're arguably more init than livepatch anyway, and by moving them to > init.h, we can remove a number of includes. > > The include in vsprintf was leftover from early versions of the work. In the > version committed, d5ccf4482e4f ("x86, xsplice: Print payload's symbol name > and payload name in backtraces"), symbol_lookup() had been adjusted to handle > the livepatch symbol names properly. > > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Anthony PERARD > CC: Michal Orzel > CC: Jan Beulich > CC: Julien Grall > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Oleksii Kurochko > CC: Ross Lagerwall > --- Reviewed-by: Oleksii Kurochko Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Aug 05 11:43:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 11:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383311.1626561 (Exim 4.92) (envelope-from ) id 1wra1f-0000Ub-UH; Wed, 05 Aug 2026 11:43:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383311.1626561; Wed, 05 Aug 2026 11:43:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wra1f-0000UU-R4; Wed, 05 Aug 2026 11:43:11 +0000 Received: by outflank-mailman (input) for mailman id 1383311; Wed, 05 Aug 2026 11:43:11 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wra1e-0000UL-SU for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:43:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wra1e-006zTo-2D for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:43:10 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7321c8-e002-0a2a0a5209dd-0a2a450a9cfe-20 for ; Wed, 05 Aug 2026 13:43:09 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7321cd-f2d2-0a2a450a0019-d155802ee1a7-3 for ; Wed, 05 Aug 2026 13:43:09 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso8042765e9.3 for ; Wed, 05 Aug 2026 04:43:09 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994dfda45asm102990935e9.4.2026.08.05.04.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 04:43:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785930189; x=1786534989; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1MMNEWYOK+POe4jOwV1jz677BcJ7a9OOCBTCoAEQmRw=; b=Nn/DxF1P5Dvt/wYGdJ1rO/LTjj0Ufa5cZrEdokwm1wBltHrRuCjnXWaO5Jvc0KcmGj fT3JoJKmWytKjqNV2KUog+m/7UrfKHHobJfX4/FL33s5vld8LwBMTK0QLqKgcTEZmTq3 2cXFjSiKW45IQvmNLW9y1sjgLoSIbA37L7dg+RziZRYJiM2GWMEP+BWW4hRGRg5MIuWf Iz/nj+PjDe/+dsqDwk1Vv+4tKjOR6p8sOIPpfR+6oB7PfGKGAbwZSTrVC1FKJnlOVg7+ P89TWlgO7pKsF/Z3edCTE12AiZdT9i45i/afBRre2HQSsJA1r8cIpG2lryuNKBWq8RdP /6YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785930189; x=1786534989; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1MMNEWYOK+POe4jOwV1jz677BcJ7a9OOCBTCoAEQmRw=; b=laRIUlQhhFPgJueAJfUWEQ27MLkOxEtGNye5iR5LYbcnD675KNbTxWbExXOqYqDbNm Fd+yd/AW6Ctc80pFYbWUECtx02xHaHIJHKsYhEcgjt1IEtwYd7vZig4k4EW6duxw+d0b DHQWjyTwd/dW//dT/Co55k+MpvoHp7GeGr4+2qJdfqaSpgxNxzsMBid5WNIdbV+C8m/P CnMZY2JsJb3bMzPHlN5ygob5G5IQmRoqdHYYHsmW6pd9U7pf+Zx5OB4K52QK6YEWC7zJ c0mLAMElh6Zns2AmcEciknriLyon5g9f+GOh57NbFcHT0ccbbR3euq7pyU/vbiR74T1T xKhw== X-Forwarded-Encrypted: i=1; AHgh+RqVQ/SB860RTHBVelZBly3YJECEA7OoYdXu5wg1avkgDBSdCKKpc0Ed+ee2zdDIrIhxqv9l/et7kYU=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy5ainJqPg/Ermt7xs9UCE6xfl7lbSZg30ltRgvggeVDcOwGtk0 32imtU9lCSytiGd2hvLNnYIfy+90E3eZjLffnXZMlO4D0G+fOetNCPs88SV8baSY9Q== X-Gm-Gg: AR+sD130IJHhl68CpdLXfzuuqkKPPV3V5Uh+pHskal8s9Shc72fp0PXHaotP9I4N/pX C+uVp/4rnpBQJywy/XazPUKy/v8lpIpBchARzBnGXfzM2WR2L3LM3gIGriYY3628UI7yGtDvwHH Z5ffteMZA3R23iHTMctBXraK2ILZ98XF3jLgrYR1ymxaUoSfAUhTus3LdUHof8mhyugiiAA2Oz6 ReRyKTeKVq0cOlFWQoZhfaUDD0iOpjV78FoFQhQTeu2Z7igrys3ViZcIbEH/vi5dDscfs6PpDSQ R6Y9hPuxUNy5OH5PpDlYc8OzbfzOCQfGrSAJXWPTQ/CNoTGzwa/EUSgF7X1tBUv9CNXAJPwEhNV UH7FKaadrI/86gVJpysE4fth8jBqo7dw1g9GwSPGtjvBpxRk3H/Pk7tn1vf4BP3vu9Ok7TCJZqv PnTG7TxN46gTHHpCJIe9HG5MIeWOvZKBDwJEJw6i7ZWe4VCLvxVHMmXhLfohvtbBoP88LVyt39c Az74krFgNLAddWrol+Fy1Y/07/ibMYJ0Omw7y7fI1wTQhXfl5Zq X-Received: by 2002:a05:600c:8b23:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-4994e7bb12dmr64911675e9.12.1785930188902; Wed, 05 Aug 2026 04:43:08 -0700 (PDT) Message-ID: <14dd261f-8d78-4c24-b927-f7f2c01dbdf8@suse.com> Date: Wed, 5 Aug 2026 13:43:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] xen/sched: rename scheduler registration symbols To: Furkan Caliskan Cc: andrew.cooper3@citrix.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, xen-devel@lists.xenproject.org References: <20260804055327.22119-1-frn1furkan10@gmail.com> <20260804055327.22119-3-frn1furkan10@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260804055327.22119-3-frn1furkan10@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-4011c0/1785930189-4B6D6CFC-18D1B315/0/0 X-purgate-type: clean X-purgate-size: 1311 On 04.08.2026 07:53, Furkan Caliskan wrote: > REGISTER_SCHEDULER(), schedulers[], NUM_SCHEDULERS, and the > per-arch SCHEDULER_ARRAY linker macro now register and hold > struct sched_ops instances rather than struct scheduler ones, > but still carry names describing the old type. > > Rename them to match the current behaviour. > No functional change. > > Signed-off-by: Furkan Caliskan > --- > xen/arch/arm/xen.lds.S | 2 +- > xen/arch/ppc/xen.lds.S | 2 +- > xen/arch/riscv/xen.lds.S | 2 +- > xen/arch/x86/xen.lds.S | 2 +- > xen/common/sched/arinc653.c | 2 +- > xen/common/sched/core.c | 33 +++++++++++++++++---------------- > xen/common/sched/credit.c | 2 +- > xen/common/sched/credit2.c | 2 +- > xen/common/sched/null.c | 2 +- > xen/common/sched/private.h | 4 ++-- > xen/common/sched/rt.c | 2 +- > xen/include/xen/xen.lds.h | 10 +++++----- > 12 files changed, 33 insertions(+), 32 deletions(-) I'm not quite sure if all of this is really useful. In many (all?) places I think "scheduler" as a term is still quite applicable. One (general) nit though: if already you touch malformed lines (overlong ones is which prompted this comment), please adjust them to be style- conformant. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 11:50:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 11:50:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383318.1626570 (Exim 4.92) (envelope-from ) id 1wra95-0002C4-KS; Wed, 05 Aug 2026 11:50:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383318.1626570; Wed, 05 Aug 2026 11:50:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wra95-0002Bx-H9; Wed, 05 Aug 2026 11:50:51 +0000 Received: by outflank-mailman (input) for mailman id 1383318; Wed, 05 Aug 2026 11:50:50 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wra94-0002Br-5b for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 11:50:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wra93-00EoM2-Dm for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:50:49 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73238f-bab6-0a2a0a5309dd-0a2a4506cdba-20 for ; Wed, 05 Aug 2026 13:50:49 +0200 Received: from [209.85.216.51] (helo=mail-pj1-f51.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a732397-195a-0a2a45060019-d155d833dd7d-3 for ; Wed, 05 Aug 2026 13:50:49 +0200 Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso782359a91.1 for ; Wed, 05 Aug 2026 04:50:48 -0700 (PDT) Received: from spider.bream-herring.ts.net ([103.252.203.158]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3903927db6esm2936674a91.10.2026.08.05.04.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 04:50:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785930647; x=1786535447; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9VOjG1qeqbpED3aclWfN9lJ5XhH5+1/8WZV2to/loYI=; b=KKR1bP08mU+SuGjic3P6//TyuUZDxrUn9Ytstok6joEPW/pUUciN+vt4yFwuI+iLjl ylmmr2O0ljuIsjdR8sKXRW1d2ba9+jvXYVVae/6Z79KlovdgmoLVxfnlq1hhBtf8JyRb ZMwvHouttC4MZumNX8+TQ75Pv6qux3DuVOGeWjskLAagRDkpxKwfxY9X+hjE1Fp1YSW2 Lqvf8Zr2ZNPjVtT5gGTyrRNH+mMlp2RCOmeWtHvabn1iozvPOGI38/rhE3iJ+mhocFXC d2g13h2YHAnQPD3j7puwkWdxZXFCEhwP3jcdr5JN/GSwrJ6ZSsEDmVxInHWhcZbEzHxB xc6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785930647; x=1786535447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9VOjG1qeqbpED3aclWfN9lJ5XhH5+1/8WZV2to/loYI=; b=bEQV+Li4vWyHNg8LLvlyXJWgpPjbm7OiQiO1iyayIqnk387xZb/r8ZHNbmgZdlC59o G1CwAU+byGGq2pCx7qnf1nx7HQY9209eUZUFzb805JChogkHdzOMihZ5Fr8ZWAnERSjW RGRYNXmJ+L52ZPezZ6HHWOfC3EJw7S8a9bLzoy4YpkmL7F0SCyPIi7ok+dtRForrshHV N2yfrqiXq3joeMA6AiZM+NKgwjun5SsnuHbryeUr6mzgi/uLHsSgJMJpVCewZQdQdyXm +e9dfbb7G1XgwPqizFmF1FeDs50vhNiLPqkPIctmhLDYTjCSUHv6ELRQUgUNOhRPqGmi ZHRQ== X-Forwarded-Encrypted: i=1; AHgh+RpDUIyktbVk7NKRGl5K+DM9eBCC9iFPOLwstFIEXmJkfU4zmUe2+tzOkV+dU98jufGZrJfm2NDD2ro=@lists.xenproject.org X-Gm-Message-State: AOJu0YzHq2z7dKLO3lSXUqKzkagw30mTXYN9BnhQevBB9fGGlWJzKPbf Z0Fh9KISfmgYXr80KhvFS6RihyTXU8WZGFO0UAhm6cimqCFzQsl6XggV X-Gm-Gg: AR+sD11k69vJlZItCT4mONKBT+SjNktcDFZVzcjYpaZDNAIgAxLv8Gxfc5SVHPw0xua LvJXBMKErySilrvSBvBAcaGF4SyX08SL4oqS89Q7H0/+WHBap0VF3c2O+Zwlm0wyzU8c1C/D0Qb lLsJJGAw8eoG+LCIPz4p63nHmUBlsswekj8WzOqXvxLAWk6CSKOBSriWDAGIN+IrXIiqsfb3fU6 VVYYf81F7wcRQVvOFxnLSglFrRKdfsCOooe8iDB3gxWx53EMz5/mSS1igkovxzV4Ep+S9xkI33Z LCYCxS7oDhikvHfkk5XsqA82XPeJ1vFCKl3KfFhAigpXNaZ8X6k8rAjuNNTK5FKtNYblsmQp8bN UrI5IXaAgfHSBIEPKXj74rC7eBhKX2X8s1v71GEqbiGm+e1inOyA6+WoOPK2PZRbnVLyIck+LOT cTbXatxpquGZkAewV585Xu3iOmk0PGLn/MJZ8jmuCRI+zamDcMpakHR1DjaTINjlx5BrZ04XpWx WQfMkvqafc1turj1bGYq+WDBJtRKzhoWTfZXemBdaj2FCilyceuliAJ831T5eBJ9OUAF0cA4KgW L1NNrmN/bZBQF6PXkE6xHVzm/nWTZuhHgkGHJqvZHBxXPZsmOJzo X-Received: by 2002:a17:90b:224e:b0:38e:9ef9:eb97 with SMTP id 98e67ed59e1d1-3903c5c443dmr5103146a91.16.1785930647103; Wed, 05 Aug 2026 04:50:47 -0700 (PDT) From: Matthias Goergens To: Roger Pau Monne Cc: Matthias Goergens , Juergen Gross , Roger Pau Monne , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yannick Martin , Thorsten Leemhuis , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2] x86/xen: fix init of balloon stats again Date: Wed, 5 Aug 2026 19:50:41 +0800 Message-ID: <20260805115041.409008-1-matthias.goergens@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805094008.95778-1-roger@xenproject.org> References: <20260730143548.39320-1-roger@xenproject.org> <20260805094008.95778-1-roger@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1785930649-F440377B-5E610B4F/0/0 X-purgate-type: clean X-purgate-size: 1104 Hi Roger, v2 looks good to me. Keying append on the source of the initial count covers every case I can construct: by inspection, a domU always enters the fallback branch (current_pages stays 0), so HVM/PVH domU and the dom0 hypercall-failure path share the subtraction branch, while the PV start_info path and a successful dom0 XENMEM_current_reservation append. I also ran it on a nested-KVM Xen rig (Xen 4.23-unstable, Linux 11028ab62899e as dom0, static busybox initramfs): - PV dom0, dom0_mem=2048M,max:4096M and 3072M,max:4096M, CONFIG_XEN_UNPOPULATED_ALLOC=n: no WARN, current_kb matches dom0_mem (2 and 3 GiB respectively). Same with =y. - PVH dom0, same two memory configurations, =n: v1 WARNed in balloon_init and returned -ERANGE in exactly these cases; v2 completes cleanly and the balloon driver initialises. (Scope note: PVH dom0 userspace stalls later in boot under nested KVM for an unrelated reason, so the PVH evidence is boot-time dmesg and the balloon sysfs state.) Tested-by: Matthias Goergens Thanks, Matthias From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:04:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:04:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383331.1626586 (Exim 4.92) (envelope-from ) id 1wraMX-0004GI-V1; Wed, 05 Aug 2026 12:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383331.1626586; Wed, 05 Aug 2026 12:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraMX-0004GB-SP; Wed, 05 Aug 2026 12:04:45 +0000 Received: by outflank-mailman (input) for mailman id 1383331; Wed, 05 Aug 2026 12:04:44 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraMW-0004G3-CH for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:04:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wraMV-00ErFj-Ot for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:04:43 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7326db-5cb7-0a2a0a5109dd-0a2a450a8a60-0 for ; Wed, 05 Aug 2026 14:04:43 +0200 Received: from [209.85.208.41] (helo=mail-ed1-f41.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7326db-f2d2-0a2a450a0019-d155d029ec63-3 for ; Wed, 05 Aug 2026 14:04:43 +0200 Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-69fab5a852cso1253176a12.0 for ; Wed, 05 Aug 2026 05:04:43 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a1453d3825sm1959506a12.0.2026.08.05.05.04.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 05:04:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785931483; x=1786536283; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=5j/I7AVi0xll2QqyeskKm0Pq/Bxqw77h9LnRP5nnM64=; b=cSeU8aMzDgz7nHP55H7Q9PROhsawDqPN5VSqoe9KsV5HLpFio9CPAS4QDWtV+6bwSP kdjJl0eFnyUcjGlNbJ7UqvApFqfP5ewGjP0PtA2Y0q8XbPTygLk0kWGZtomHarMiV8wq UkdYcPy0Z1lcR8RPViFH8dRhtNJK+55xVHx20c/VVYu0XjGw3XnSh2+bIwtHyxY2SOue aa1DCrscknfF/qaimd0eMbVPuUCLhDfHnuQk5To0UfQD8IChc5xgxpFzS120s9FceeOv p5rxnLax7GIv42hVxQ6yHEQVpFPCMzG4Utjb+vHPNghgQmaR3qZl+LLGlz1v+A8qL1UJ vmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785931483; x=1786536283; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5j/I7AVi0xll2QqyeskKm0Pq/Bxqw77h9LnRP5nnM64=; b=p88DiHMNj1Iynq/yu82blkLmyS/jzO2OL2UAnrhWe8Mn7W2xfMoSHzoZBXnBeuhWCL W0zPQfWtvXtdAPE8eOiJ1ChoXdHQVz6vahGdSHshaQgQ4Ur2nyXf8sLo8IZ9OBNhO/sj 4ECQLWdZ3Xy1K4CehZn1roOvUUKqj9MclRnJnFbo56wlL0r2SRu8BT0sfrhwCHjEha+s xpPOVd5/oxLjBEquxQrn/lRSocIsHgqeGL0VqDuin9JZU0MHHUfWm43PhHDtermEwDrA PNzNuW2Of4YiuNuP1nnfcqoEBd08ff3j0+DpL50svVFpFkC8pi/KgQP+1DxGAJAgSvKq htsw== X-Forwarded-Encrypted: i=1; AHgh+RqDg+M0tFQrEgJ44UUfXJ4V01hFSBPVqrt1s8f3HCRBPr98Juy5ZygHtAMNAWvjr/fOGMfgtCYv4/w=@lists.xenproject.org X-Gm-Message-State: AOJu0YxhHeDafwjw2bxOvycteCACijEJTk/UfjS9q300HLDEUzib3LIS i12ltdzIfwrim2QfyT/eKKFfWV9FP561KKIyxnqVnLwa9rJSWv+wQjmOKMsnNzF3NB8= X-Gm-Gg: AR+sD12hnxcYYQ2Iuux1o/rHyI6iQmXyjhaoq+xM0FI8N0nReUq3tBDhFRPMaNI0kKD eRL79Lkl73PDEeJlFSt8MTLz44zfsNKYdsfZGU6ieouIzw3faTEDA8NsumvPS5vCWCtpx/jRukx yetvUwEcX4+ZLafeIrKiJd25r4Dmn7V1vQXAXdSXEWa0u/Xj4VshydRQDwwir29a8HP3H2nwFA0 C3i0cMU4+bcRHNLnbRNzW0xUuLEJOrixW3oD7oNmmsEfE7PfqichqGmR19N5Fhe/ktQ/LjQhRfi 6OuduszGTTHZ3B7dRQ9M7MHAvT5j9pXUfP8fLefCGAsHllF9ul5QtkPQKOYIx+rAZ4P5IfSD4l5 TXIvhmEKYhmPBkmbvU0HVhR7lzTl7oSClINZtqrZUV8G74/IOxVGqZ++4zBUnwmCQJ3WAsyHnOp vRvTogsg6y0pZGBQKeE7nQKzW7JQaZJCl0ZpsGHPy573BTWmRW6ELu4WzzPHKn3JKaaYEx+0yzC nnuISEm0g1GLPjyGhPMznA5AepK/1zNsNfhmbmegKRIEXBFRlS8mjy+Qec2ecLn0NItaqfoaMv1 D9YGNiqQHPN6aE8= X-Received: by 2002:a05:6402:e0d:b0:69e:2d56:690a with SMTP id 4fb4d7f45d1cf-6a14f0bbe0cmr3187654a12.8.1785931483058; Wed, 05 Aug 2026 05:04:43 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 14:04:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86/xen: fix init of balloon stats again To: Roger Pau Monne , Roger Pau Monne , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Yannick Martin , Thorsten Leemhuis , Matthias Goergens , Stefano Stabellini , Oleksandr Tyshchenko References: <20260805094008.95778-1-roger@xenproject.org> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260805094008.95778-1-roger@xenproject.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------nrg9apKmLaIB11gz9qpYEwWd" X-purgate-ID: tlsNG-4011c0/1785931483-50CCBCFC-E207E094/0/0 X-purgate-type: clean X-purgate-size: 7677 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------nrg9apKmLaIB11gz9qpYEwWd Content-Type: multipart/mixed; boundary="------------D3cUtnDAbK80qUskmqQx0yJU"; protected-headers="v1" From: Juergen Gross To: Roger Pau Monne , Roger Pau Monne , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Yannick Martin , Thorsten Leemhuis , Matthias Goergens , Stefano Stabellini , Oleksandr Tyshchenko Message-ID: Subject: Re: [PATCH v2] x86/xen: fix init of balloon stats again References: <20260805094008.95778-1-roger@xenproject.org> In-Reply-To: <20260805094008.95778-1-roger@xenproject.org> --------------D3cUtnDAbK80qUskmqQx0yJU Content-Type: multipart/mixed; boundary="------------OE5OoLbEmJF7vthcfOs1YCtK" --------------OE5OoLbEmJF7vthcfOs1YCtK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTE6NDAsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4gVGhlIGhhbmRs aW5nIG9mIGV4dHJhIG1lbW9yeSByZWdpb25zIGRvbmUgaW4gYmFsbG9vbl9hZGRfcmVnaW9u cygpIGlzIG5vdA0KPiBjb3JyZWN0IGZvciBQViBndWVzdHMsIHNpbmNlIHRoZSBpbml0aWFs IHRhcmdldCBpcyBzZXQgdG8gcmVmbGVjdCB0aGUgcmVhbA0KPiBtZW1vcnkgdGhlIHN5c3Rl bSBoYXMsIG5vdCB3aGF0J3MgZGVzY3JpYmVkIG9uIHRoZSBtZW1vcnkgbWFwLCB3aGljaCBj YW4gYmUNCj4gaGlnaGVyIGlmIG1lbW9yeSAhPSBtYXhtZW0uDQo+IA0KPiBJbnRyb2R1Y2Ug c2VwYXJhdGUgbG9naWMgZm9yIGFkZGl0aW9uIHZzIHN1YnRyYWN0aW9uIGluDQo+IGJhbGxv b25fYWRkX3JlZ2lvbnMoKSBhbmQgaGFuZGxlIGV4dHJhIHJlZ2lvbnMgY29ycmVjdGx5IGJ5 IGFkZGluZyB0aGVtIHRvDQo+IHRoZSB0b3RhbCBhbW91bnQgb2YgcGFnZXMsIGluc3RlYWQg b2Ygc3VidHJhY3RpbmcgZnJvbSB0aGUgY3VycmVudCBhbmQNCj4gdGFyZ2V0IHBhZ2VzIGFt b3VudHMuDQo+IA0KPiBJbiB0aGUgY29tbW9uIGNhc2UgUFYgZG9tVS9kb20wIGFuZCBQVkgg ZG9tMCB3aWxsIHVzZSB0aGUgYWRkaXRpb24gcGF0aCwNCj4gc2luY2UgdGhlIGluaXRpYWwg dGFyZ2V0IHJlZmxlY3RzIHRoZSByZWFsIGFzc2lnbmVkIG1lbW9yeS4gIEhWTSBhbmQgUFZI DQo+IGRvbVVzIHVzZSB0aGUgc3VidHJhY3Rpb24gcGF0aCwgc2luY2UgdGhlIHRhcmdldCBp cyBzZXQgYmFzZWQgb24gdGhlIGFtb3VudA0KPiBvZiBtZW1vcnkgcmVwb3J0ZWQgaW4gdGhl IG1lbW9yeSBtYXAsIHdpdGhvdXQgYWNjb3VudGluZyBmb3IgcmVsZWFzZWQNCj4gcmVnaW9u cy4NCj4gDQo+IEZpeGVzOiA4N2FmNjMzNjg5Y2UgKCJ4ODYveGVuOiBmaXggYmFsbG9vbiB0 YXJnZXQgaW5pdGlhbGl6YXRpb24gZm9yIFBWSCBkb20wIikNCj4gRml4ZXM6IDA5NDljNjQ2 ZDY0NiAoIlBhcnRpYWwgcmV2ZXJ0ICJ4ODYveGVuOiBmaXggYmFsbG9vbiB0YXJnZXQgaW5p dGlhbGl6YXRpb24gZm9yIFBWSCBkb20wIiIpDQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBh dSBNb25uw6kgPHJvZ2VyQHhlbnByb2plY3Qub3JnPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdl biBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg== --------------OE5OoLbEmJF7vthcfOs1YCtK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------OE5OoLbEmJF7vthcfOs1YCtK-- --------------D3cUtnDAbK80qUskmqQx0yJU-- --------------nrg9apKmLaIB11gz9qpYEwWd Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpzJtoFAwAAAAAACgkQsN6d1ii/Ey/j bwf/fx2QwqDkGGCIigcGoZhn8yP3B7uDWZ+sZc7Bm1NfMoo/yOxkhdwtrt2Tz6AXVZNRcRiSNMil aI/cHFD+uTmUapvrFEk8BYKvrg6lJut7jSOIrlGxQgW1ymY3PNRidN3mYLiZMT4jBNIJLfm0a4Kr yxYxKgZrdc4Je8rqiak1mFCfsbvQZUzcaasimPbr78cfa+ssRXV9Cvhmsdk0fNKcsEyXvO3ugdBY ewD1FKFt5C60Sv3V9hg6q9BGlwzeDjQimm7z942/kx9xhxsK+8sv3W/wFhxSpRaQwSSsiO20gzlA OtZTMDPJCc0COKJi+cp1ZQk1MFbCIF+gH2ArpKtlXg== =TvOA -----END PGP SIGNATURE----- --------------nrg9apKmLaIB11gz9qpYEwWd-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:11:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383340.1626597 (Exim 4.92) (envelope-from ) id 1wraTH-00061e-L5; Wed, 05 Aug 2026 12:11:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383340.1626597; Wed, 05 Aug 2026 12:11:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraTH-00061X-HJ; Wed, 05 Aug 2026 12:11:43 +0000 Received: by outflank-mailman (input) for mailman id 1383340; Wed, 05 Aug 2026 12:11:41 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraTF-00061K-N0 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:11:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wraTD-000RKK-Fr for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:11:39 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a732873-bab6-0a2a0a5309dd-0a2a450ba03a-18 for ; Wed, 05 Aug 2026 14:11:39 +0200 Received: from [40.93.198.60] (helo=CY7PR03CU001.outbound.protection.outlook.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a732879-b7e8-0a2a450b0019-285dc63cc973-4 for ; Wed, 05 Aug 2026 14:11:38 +0200 Received: from BN9PR03CA0277.namprd03.prod.outlook.com (2603:10b6:408:f5::12) by LV3PR12MB9095.namprd12.prod.outlook.com (2603:10b6:408:1a6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.20; Wed, 5 Aug 2026 12:11:34 +0000 Received: from BN1PEPF00004680.namprd03.prod.outlook.com (2603:10b6:408:f5:cafe::15) by BN9PR03CA0277.outlook.office365.com (2603:10b6:408:f5::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.15 via Frontend Transport; Wed, 5 Aug 2026 12:11:34 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by BN1PEPF00004680.mail.protection.outlook.com (10.167.243.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Wed, 5 Aug 2026 12:11:33 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 07:11:33 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 07:11:32 -0500 Received: from APPOL-18KY0J4.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 5 Aug 2026 07:11:31 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Iq8h8IzjFckCyOTXJiuJ7qlHw9hvr9TUbx60pEibpOP6Kdu+EsVe6j2Kw80Lb78PfgsRDwJkGNVB6peip3vRmBRV7+j1gM735HPI/bKE3e/xZPa96DtHr7z4715VqjZ9aXhtsNEQxiT9JMtWnfAoyrz7RxDxkAvwbXGAFtagFGmD691B52V3a8x1iABX5bRo9eHCocmG6NyHn7hVPj0CJmNKkc7Q4v+dPz5OX4XfCDFLj4SYIgVh1V5c279o0OF8FQ855qHVWRKm8lxseGDSbebVpv+UeR5ZT6fp/Ij+WCcDgvDiSEEPjhxcspUxHMennYk3kaVQlSrye/slyECBjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=unubrNBuqj+l9w841dcepEg1+HSa6SRJQulOWbGXmbQ=; b=HxPIgH0f+9HrEyKUpVqGklGyWYFPLtPuCE744HupCsJPrCDVivftbbLxXq0pNDVrAJlBGaNxxi3AG8b9aYEt2kaCAyK3FBc5zwPPkuR3lhhfZKwB8mHu5ynS7J2DuChnwItHo0ooJhDfu+aUYQShqqS+TdtpZ1lL33/bbH/kI/J/Awyt3AVVHI8NF4QkTrlRvyNU3j/z7bNJ1M/tGShbpgaSFR8+rD+4vLn65/gH/6hpyH3AXcNhAj+BVPUCTV5O5NtrlJbQjBBWoJvtDSmCHlu12hatv/0Byw+kAwJ/rTpfEdopi94exGxHoVn1e+6/d1P7PV1ir3r5SYy2sFaAgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=unubrNBuqj+l9w841dcepEg1+HSa6SRJQulOWbGXmbQ=; b=OxzlD8e1ExXlTN3sVpBgGim+q1fFiR45FlSF1B5hwID/plXvgqNM28DRSFZjwpYVg7nIcl827NUzwjT9lBO6f8Nr/K8TrPXT/BJharvqnEN6UmBjobplgldREWlweiwYBEci+YmrZEdENQJTym7s9yJXf/Iiu9LQeZLlDRiJbXU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [PATCH] xen/dt: reject "xen,static-mem" when CONFIG_STATIC_MEMORY is disabled Date: Wed, 5 Aug 2026 14:11:24 +0200 Message-ID: <20260805121124.150017-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004680:EE_|LV3PR12MB9095:EE_ X-MS-Office365-Filtering-Correlation-Id: 29b49c11-5aa0-4d4d-7399-08def2eab0eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|376014|23010399003|18002099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: BB1sJBMTcNGyTgToF77qGmz342YlYFXjJEb+0nvHRfGhny39QBU7qq8rrq4H9o2J57d9z9fmgxSNjOXv7nPQqEUY9wfk0K0iW8U3UKkBILd4Px0BjuyEvWBGf3KXmLPx5xRTY0RzXoZkhTpZwjnW/aDy7ZSBd6UUDvJ1xd7klijMP8/YPTagtgM6w4ei4oKPt7bh/a0u35Pyv8nhsgG2+O5uzC03tlxXWTL+VldQjWk727T2qvmLmAJbxU1PrTING3PmxQOwF1uOJbinjTuGkp+GzR+WwHp86hA3dwE2yAt9yqDM5lKo6K4pSb+CVvs0SynB6xqTDqGw6mUGgbOeGoBPzCw+TFLiGJY/diN9aM0tpGk/hpNNU1QCY1hsdtlM76U/e26WmDkoS0hYZv4GGcnhWuiE7AX9TUKjPLoExKWHxTkNct5oUZ5hiIFhRU3k4cfzmhMuU4wn6AgB7mZ4AXY9d8fh8hIjthOaY+blQiajLQ2NRhcYbQOCU8CwRcL6ELDynDZbBrTqQzBOuDdFTpyEZ/XuNvhLZT2wf5q12io8BaTgujsTu1nw30GVvmUJwUuhYoT5phW6jdk2ju5VzmqCyqBfvkcEJlQFu9WsM8TzHA76ApNa2hfpp5Rjh57h+rioxw13PytYJsvZGHiqaYpxNHHf6tjx7OCnS9hqWYM/bsKTcXvZJaaQt7khIR+bLjA1/qD/zC0z40YU1K26Ew== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(376014)(23010399003)(18002099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WXekfs5cg5Ioaj0ZgKl4J5ksnPXL41yeJdUOGL9N31ff3OVMLWu6bf/WGHs/jwbLVgD6mUt9az6O58XcvMq7gmQmSrNHtkpmkZVOuL4ykZn9GXH9NF3gNSI6zmJl6RyT/1qom4kZKHtdUHUfZw9Rd+c3CP1UYxS+uPoIxT9RHmby8m9qonUUJrWNdvI5DE2DRMgaOudNLmGbahECMu4qz8Fs/f0qhVj9gsMrkxgKnG+ZBWoXcDRVHz7rncudoTtB7QAENL/31fWjHTvOZtRRc0yiZxZaWrU0A9PTqOk6fGKZA77U++5XOZH435QrBay74oTHDXtLU3s1w3APbrQi246Fuv14lho1MVy2spvPsEh9zYpDtx2nx7Pfr+120LCgdI/AXz+5sfiLOUb/csWAtqKtgTJirxAydMnLND5Fu0DUx7hzKMrhuAsqF9u5xevn X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 12:11:33.7245 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29b49c11-5aa0-4d4d-7399-08def2eab0eb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004680.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9095 X-purgate-ID: tlsNG-42698a/1785931899-18AC89EA-276021D3/0/0 X-purgate-type: clean X-purgate-size: 1483 process_domain_node() parses "xen,static-mem" regardless of CONFIG_STATIC_MEMORY. With the feature off, init_staticmem_pages() is a no-op stub, so boot carries on until construct_domU() reaches the ASSERT_UNREACHABLE() stubs of allocate_static_memory() / assign_static_memory_11(): a debug build trips the assertion, a production build gives the domain no memory at all. Bail out at parse time instead, like process_shm_node() already does for CONFIG_STATIC_SHM. Fixes: 41c031ff437b ("xen/arm: introduce domain on Static Allocation") Signed-off-by: Michal Orzel --- xen/common/device-tree/bootinfo-fdt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/common/device-tree/bootinfo-fdt.c b/xen/common/device-tree/bootinfo-fdt.c index 272b5a6c0ae6..ca64daf4cdc8 100644 --- a/xen/common/device-tree/bootinfo-fdt.c +++ b/xen/common/device-tree/bootinfo-fdt.c @@ -349,6 +349,12 @@ static int __init process_domain_node(const void *fdt, int node, /* No "xen,static-mem" present. */ return 0; + if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) ) + { + printk("CONFIG_STATIC_MEMORY must be enabled for parsing xen,static-mem\n"); + return -EINVAL; + } + return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, size_cells, bootinfo_get_reserved_mem(), MEMBANK_STATIC_DOMAIN); -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:15:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:15:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383347.1626605 (Exim 4.92) (envelope-from ) id 1wraXA-0006bv-2a; Wed, 05 Aug 2026 12:15:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383347.1626605; Wed, 05 Aug 2026 12:15:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraX9-0006bo-WE; Wed, 05 Aug 2026 12:15:44 +0000 Received: by outflank-mailman (input) for mailman id 1383347; Wed, 05 Aug 2026 12:15:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraX9-0006bi-9u for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:15:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wraX9-006L26-0A for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:15:42 +0000 Received: from mail-lf1-f47.google.com ([209.85.167.47]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wraX8-00GCzS-2K for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:15:42 +0000 Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5b28c91fba5so1192544e87.1 for ; Wed, 05 Aug 2026 05:15:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version; bh=IAx6f5biC3iTv+LdiiiwtGsshSnWp3OICO2uNsEBnTo=; b=mJPyro+NE58cJsdfG12gs5vvyr nkPuxedqJEQfj9Aa/lCavfquqgu9Z5hJHe2MZ3yO+/tdPHW/tTtVXS+3vj3USZGUHfisLKuIeOHCa M3oqRcCwBlrvOGeomeE6cA7lU/hEWcZ+8wmTvoDmmMireVCiw9/OxtimgPgYFxoKppf0=; X-Gm-Message-State: AOJu0Ywsymk96fTsFbkJwYb1wPVYUsNifo8QYybdlr2Jf8wBBhHlyrMd WzgY/MK7DGuEsfPT8khciycenr7OfaqQYmOSBXJdUit/pOzmQzS1qB5qREtRFuI+9g02tPBk2uM fhcFjajtyFF5vT9p7ljgx/cj+lkYnZrw= X-Received: by 2002:a05:6512:20c2:b0:5b2:c068:3530 with SMTP id 2adb3069b0e04-5b2f488ed8bmr531704e87.13.1785932141585; Wed, 05 Aug 2026 05:15:41 -0700 (PDT) MIME-Version: 1.0 References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> In-Reply-To: From: George Dunlap Date: Wed, 5 Aug 2026 22:15:27 +1000 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mxhzcbGZ8RteTnwsFS0o1a3r0nJXrgamS0cpFvyyutHHEhD_1DDg1EdDSM Message-ID: Subject: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: xen-devel Content-Type: multipart/mixed; boundary="000000000000e4836606584bba67" --000000000000e4836606584bba67 Content-Type: multipart/alternative; boundary="000000000000e4836406584bba65" --000000000000e4836406584bba65 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable [Adding back in xen-devel, since this is relevant] On Wed, Aug 5, 2026 at 9:15=E2=80=AFPM J=C3=BCrgen Gro=C3=9F wrote: > On 04.08.26 11:34, George Dunlap wrote: > > On Tue, Aug 4, 2026 at 6:45=E2=80=AFPM J=C3=BCrgen Gro=C3=9F > > wrote: > > > > > > P.S.: George, would it be possible to turn off HTML mails when > sending to > > xen-devel? > > > > > > I see both a text/plain part and a text/html part in the mail I sent; > isn't the > > presence of a text/plain version sufficient? > > > > Obviously sending patches is a different matter; but for that I'll be > using git- > > send-email. > > This is a reply to your mail using Thunderbird (which I have configured t= o > use > plain text format as the default, in order to comply with most mailing > lists > I'm using). > > I don't think Thunderbird is an exotic MUA, but please have a look how it > rendered your HTML reply to my original mail. I can't see clearly which > part > was written by me originally and was cited by you in this mail. > Thanks, this is what I was looking for. Attached is the message Gmail sent. As you can see, text/plain uses normal `>` for quotes. That makes me think that the problem is in Thunderbird. It should either take the text/plan part, and reply to that as though it were the only part it had received; or it should take the HTML part, and convert the quotes to text properly. Replying in HTML and then rendering it with only space indentations seems like a bug. Thunderbird certainly isn't exotic, but last time I used it it was definitely under-maintained. You're asking every person who sends an email to xen-devel to remember to take an action before sending the mail (or to send *all* mail as text/plain, even if it's not to xen-devel), because your MUA isn't handling the standard properly. Is that really reasonable? Couldn't you tell Thunderbird to ignore html and only render text/plain? -George --000000000000e4836406584bba65 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
[Adding back in xen-devel, sinc= e this is relevant]

On Wed, Aug= 5, 2026 at 9:15=E2=80=AFPM J=C3=BCrgen Gro=C3=9F <jgross@suse.com> wrote:
On 04.08.26 11:34, George Dunlap wrote:
> On Tue, Aug 4, 2026 at 6:45=E2=80=AFPM J=C3=BCrgen Gro=C3=9F <jgross@suse.com
> <mailto:jgross= @suse.com>> wrote:
>
>
>=C2=A0 =C2=A0 =C2=A0P.S.: George, would it be possible to turn off HTML= mails when sending to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0xen-devel?
>
>
> I see both a text/plain part and a text/html part in the mail I sent; = isn't the
> presence of a text/plain version sufficient?
>
> Obviously sending patches is a different matter; but for that I'll= be using git-
> send-email.

This is a reply to your mail using Thunderbird (which I have configured to = use
plain text format as the default, in order to comply with most mailing list= s
I'm using).

I don't think Thunderbird is an exotic MUA, but please have a look how = it
rendered your HTML reply to my original mail. I can't see clearly which= part
was written by me originally and was cited by you in this mail.

Thanks, this is what I was looking for.
=
Attached is the message Gmail sent.=C2=A0 As you can see, te= xt/plain uses normal `>` for quotes.

That makes= me think that the problem is in Thunderbird.=C2=A0=C2=A0It should either take the text/plan part, and re= ply to that as though it were the only part it had received; or it should t= ake the HTML part, and convert the quotes to text properly.=C2=A0 Replying = in HTML and then rendering it with only space indentations seems like a bug= .

Thunderbird certainly isn't exotic, b= ut last time I used it it was definitely under-maintained.

You're asking every person who sends an email to xen-devel to = remember to take an action before sending the mail (or to send *all* mail a= s text/plain, even if it's not to xen-devel), because your MUA isn'= t handling the standard properly.=C2=A0 Is that really reasonable?=C2=A0 Co= uldn't you tell Thunderbird to ignore html and only render text/plain?<= /div>

=C2=A0-George
--000000000000e4836406584bba65-- --000000000000e4836606584bba67 Content-Type: text/plain; charset="US-ASCII"; name="quoted-reply.txt" Content-Disposition: attachment; filename="quoted-reply.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_msg1t17q0 TUlNRS1WZXJzaW9uOiAxLjANCkRhdGU6IFR1ZSwgNCBBdWcgMjAyNiAxOTozNDoxMyArMTAwMA0K UmVmZXJlbmNlczogPENBRkxCeFpaTFl4azRaWlo5KytCOXFSbl9KOFg2b2NoYkhyNDAzN21iQzhz RGZzUnFEQUBtYWlsLmdtYWlsLmNvbT4NCgk8NjFiOWM5ZmItM2Q5Ny00NDgwLTgxNzEtYmNlOTg2 ZTY5OGE4QHN1c2UuY29tPg0KCTwzMTI2N2Q5Yi0wMjJmLTQ4YjUtYjU4My02ZDkzODBhMjI3NDBA c3VzZS5jb20+DQpJbi1SZXBseS1UbzogPDMxMjY3ZDliLTAyMmYtNDhiNS1iNTgzLTZkOTM4MGEy Mjc0MEBzdXNlLmNvbT4NCk1lc3NhZ2UtSUQ6IDxDQUZMQnhaWWZmYjNiT1M0Wno4bTJRWDUySjZW OS1ab25heFBDVUxvcXlSTHBQS2gtVlFAbWFpbC5nbWFpbC5jb20+DQpTdWJqZWN0OiBSZTogTGlu dXggUFYgZG9tVSB3aXRoID4xIHZDUFUgbmV2ZXIgcmVzdW1lcyBhZnRlciB4bCBzYXZlL3Jlc3Rv cmUNCkZyb206IEdlb3JnZSBEdW5sYXAgPGd3ZEB4ZW5wcm9qZWN0Lm9yZz4NClRvOiA9P1VURi04 P0I/U3NPOGNtZGxiaUJIY20vRG53PT0/PSA8amdyb3NzQHN1c2UuY29tPg0KQ29udGVudC1UeXBl OiBtdWx0aXBhcnQvYWx0ZXJuYXRpdmU7IGJvdW5kYXJ5PSIwMDAwMDAwMDAwMDA5YzcwMzUwNjU4 MzU1YjZmIg0KDQotLTAwMDAwMDAwMDAwMDljNzAzNTA2NTgzNTViNmYNCkNvbnRlbnQtVHlwZTog dGV4dC9wbGFpbjsgY2hhcnNldD0iVVRGLTgiDQpDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiBx dW90ZWQtcHJpbnRhYmxlDQoNCk9uIFR1ZSwgQXVnIDQsIDIwMjYgYXQgNjo0NT1FMj04MD1BRlBN IEo9QzM9QkNyZ2VuIEdybz1DMz05RiA8amdyb3NzQHN1c2UuYz0NCm9tPiB3cm90ZToNCg0KPg0K PiBQLlMuOiBHZW9yZ2UsIHdvdWxkIGl0IGJlIHBvc3NpYmxlIHRvIHR1cm4gb2ZmIEhUTUwgbWFp bHMgd2hlbiBzZW5kaW5nIHRvDQo+ICAgICAgICB4ZW4tZGV2ZWw/DQo+DQoNCkkgc2VlIGJvdGgg YSB0ZXh0L3BsYWluIHBhcnQgYW5kIGEgdGV4dC9odG1sIHBhcnQgaW4gdGhlIG1haWwgSSBzZW50 OyBpc24ndA0KdGhlIHByZXNlbmNlIG9mIGEgdGV4dC9wbGFpbiB2ZXJzaW9uIHN1ZmZpY2llbnQ/ DQoNCk9idmlvdXNseSBzZW5kaW5nIHBhdGNoZXMgaXMgYSBkaWZmZXJlbnQgbWF0dGVyOyBidXQg Zm9yIHRoYXQgSSdsbCBiZSB1c2luZw0KZ2l0LXNlbmQtZW1haWwuDQoNCiAtR2VvcmdlDQoNCi0t MDAwMDAwMDAwMDAwOWM3MDM1MDY1ODM1NWI2Zg0KQ29udGVudC1UeXBlOiB0ZXh0L2h0bWw7IGNo YXJzZXQ9IlVURi04Ig0KQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogcXVvdGVkLXByaW50YWJs ZQ0KDQo8ZGl2IGRpcj0zRCJsdHIiPjxkaXYgZGlyPTNEImx0ciI+PHNwYW4gc3R5bGU9M0QiYmFj a2dyb3VuZC1jb2xvcjp0cmFuc3BhcmU9DQpudCI+T24gVHVlLCBBdWcgNCwgMjAyNiBhdCA2OjQ1 PUUyPTgwPUFGUE0gSj1DMz1CQ3JnZW4gR3JvPUMzPTlGICZsdDs8YSBocmU9DQpmPTNEIm1haWx0 bzpqZ3Jvc3NAc3VzZS5jb20iPmpncm9zc0BzdXNlLmNvbTwvYT4mZ3Q7IHdyb3RlOjwvc3Bhbj48 L2Rpdj48ZGk9DQp2IGNsYXNzPTNEImdtYWlsX3F1b3RlIGdtYWlsX3F1b3RlX2NvbnRhaW5lciI+ PGJsb2NrcXVvdGUgY2xhc3M9M0QiZ21haWxfcXU9DQpvdGUiIHN0eWxlPTNEIm1hcmdpbjowcHgg MHB4IDBweCAwLjhleDtib3JkZXItbGVmdDoxcHggc29saWQgcmdiKDIwNCwyMDQsMjA9DQo0KTtw YWRkaW5nLWxlZnQ6MWV4Ij48YnI+DQpQLlMuOiBHZW9yZ2UsIHdvdWxkIGl0IGJlIHBvc3NpYmxl IHRvIHR1cm4gb2ZmIEhUTUwgbWFpbHMgd2hlbiBzZW5kaW5nIHRvPGI9DQpyPg0KPUMyPUEwID1D Mj1BMCA9QzI9QTAgPUMyPUEweGVuLWRldmVsPzxicj48L2Jsb2NrcXVvdGU+PGRpdj48YnI+PC9k aXY+PGRpdj5JPQ0KIHNlZSBib3RoIGEgdGV4dC9wbGFpbiBwYXJ0IGFuZCBhIHRleHQvaHRtbCBw YXJ0IGluIHRoZSBtYWlsIEkgc2VudDsgaXNuJiMzPQ0KOTt0IHRoZSBwcmVzZW5jZSBvZiBhIHRl eHQvcGxhaW4gdmVyc2lvbiBzdWZmaWNpZW50PzwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkPQ0KaXY+ T2J2aW91c2x5IHNlbmRpbmcgcGF0Y2hlcyBpcyBhIGRpZmZlcmVudCBtYXR0ZXI7IGJ1dCBmb3Ig dGhhdCBJJiMzOTtsbCBiPQ0KZSB1c2luZyBnaXQtc2VuZC1lbWFpbC48L2Rpdj48ZGl2Pjxicj48 L2Rpdj48ZGl2Pj1DMj1BMC1HZW9yZ2U8L2Rpdj48L2Rpdj48PQ0KL2Rpdj4NCg0KLS0wMDAwMDAw MDAwMDA5YzcwMzUwNjU4MzU1YjZmLS0NCg== --000000000000e4836606584bba67-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:37:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:37:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383360.1626615 (Exim 4.92) (envelope-from ) id 1wrars-0001QI-Sr; Wed, 05 Aug 2026 12:37:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383360.1626615; Wed, 05 Aug 2026 12:37:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrars-0001QB-Ov; Wed, 05 Aug 2026 12:37:08 +0000 Received: by outflank-mailman (input) for mailman id 1383360; Wed, 05 Aug 2026 12:37:07 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrarq-0001Q5-VL for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:37:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrarq-00CF1S-8Q for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:37:06 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a732e71-5cb7-0a2a0a5109dd-0a2a450ad472-4 for ; Wed, 05 Aug 2026 14:37:05 +0200 Received: from [52.101.65.71] (helo=DU2PR03CU002.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a732e6c-f2d2-0a2a450a0019-346541473830-3 for ; Wed, 05 Aug 2026 14:37:00 +0200 Received: from AS4P191CA0033.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:657::20) by DU2PR08MB10201.eurprd08.prod.outlook.com (2603:10a6:10:496::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Wed, 5 Aug 2026 12:36:55 +0000 Received: from AM4PEPF00027A6A.eurprd04.prod.outlook.com (2603:10a6:20b:657:cafe::4a) by AS4P191CA0033.outlook.office365.com (2603:10a6:20b:657::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.19 via Frontend Transport; Wed, 5 Aug 2026 12:36:55 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM4PEPF00027A6A.mail.protection.outlook.com (10.167.16.88) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Wed, 5 Aug 2026 12:36:54 +0000 Received: from PR3PR08MB5593.eurprd08.prod.outlook.com (2603:10a6:102:84::13) by GVXPR08MB11541.eurprd08.prod.outlook.com (2603:10a6:150:2e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Wed, 5 Aug 2026 12:36:22 +0000 Received: from PR3PR08MB5593.eurprd08.prod.outlook.com ([fe80::aae1:6871:afc4:620e]) by PR3PR08MB5593.eurprd08.prod.outlook.com ([fe80::aae1:6871:afc4:620e%6]) with mapi id 15.21.0292.018; Wed, 5 Aug 2026 12:36:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=h7odzjxf8BQ6ldplA6o9NJqYIJqIoAC54m/QDw7BQ+1rcsopagJShSfQRDeRr3W2cd6tQ/iFwbvJMk1GPTqlnrp5fHj/sqb1FZh3n4Rn8I7A/0wI7ii5Vs/KYDlwvIocx6i9/hI4zhhoyzBRJqb+34bwvMF9DAlLkHI0CrKgl2y/oxkKBtMPe6mdh/hPlemNHvGOl6QW37g1z2IUIWHw08rMX1K5hO1uGegp95SG8uxj/wVf6FG2ru8YMkI3K7FK6ppQp0BTcSZqru2ar+EzYJaxdl2OBpaeISiI9OJdAidoF3XvYIiDpQZ7BO2RL59Ru6QbjvOoWI8+Rw5T1aPzIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JDS7KKBKW4Tb50TD937EvBFtqo53hc8n1Bbyf2j1eKw=; b=ghW5l6iExF8jvHcUfAE1MbrYgm2gU46wSK6vJ5LNweDady4QSAKHL9S8EpN4TatP+JjRqNDKNxhhqVM6IFId7fM3Zm9481+JmsC2bkMyC6vpnOhCjyj4zsTMYjje13CmtCn+F45KiBv6W9Nbvhf4fpkDKyWRaFWGObb2KCqfUk+w/r34K3yRx9qH5wxlEYtU6Rc8dQLDH/JWH71nzEN69s6S2qIpuvZm7EWxWo9mT3mAGYBP5Z8/qsC7KK92z8DIjunyurODwonUnEZERm76o2LORQwYfcCbyvOAH1tesXmcVTjI57l3nmrNx8B9EoUKhG8VyYDZAGNktN6T0ihljQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JDS7KKBKW4Tb50TD937EvBFtqo53hc8n1Bbyf2j1eKw=; b=ACANzZEmhpaoSmtOEZ6JBoEGJ8c+Hz1BJPkip470x4r3cdkG0RSgOoQbinwStCBuqAnmKaN3VV0kXRRgWwAmysnLlzmUaurTT6qvBBe5LqGAopZ5eYZUhsN823lkIieYHCh/jf7zTrVDwg40lVeQF50X/Jd5Jo5Ie9SMXM+kCiw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D7c7zbuXW9vzrQJLSN2rh4u9z1DdD6l3vx9tACVFVRiG80+8dgH5XOZwvwPa1owJ1pBZsovcl5dkFEJetLlPg4h6oSAXLd7/JaEd+fHM9LaxwoItd2W7dA1l0X0BvgTZ7mA9PPPij/V0+3rnXuav6RKvKBpC9nmVRJw3KTAI/DznymGI2YFlc9IynmwB2OA/NWZ6OAVIJFt0Wjv8sn12SPFUjddP8XI7CLZzkQqZUimRPkB6c+5R9kbLtE4ZpNZ46uutiJ7/fDXpiBJNkLEo1G+HLfpCvLzpfeP9Iu1Z2AK0zfogTVYEFQxw4AxfyFEM19o5Ko2UmyCghC7RdsAdfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JDS7KKBKW4Tb50TD937EvBFtqo53hc8n1Bbyf2j1eKw=; b=e2N3WIBLsWHA1nWjid7sKr32/wSTSDKGtZ7F/OA+70T5XWkYUVT2EkXG5iBzMdUw43wVJImLm1a9Uucs9ai5wlAxN/MM6DQAxb9bmlVmF92+XpJJu0R9ir33XXz3itcswbP4DKyuaUPpYgbR3TerlLk84vOHDIk7VIEX8Wr4lvbC7fuNcTVTcFs7ViBqHifROUuEeq5riiRhbtWshaDomXzPDQZVu0aQKR1jliKohAF/6ecUYVpvGVDgjYuKJDvcwW6T8mzIYclsM7zwUoGXt5QEvtpwknDLW8W+jA6yLnnYj953XCClq0HF3D6oJ08Ga1G8E4dT8de39Wk0p7kvwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JDS7KKBKW4Tb50TD937EvBFtqo53hc8n1Bbyf2j1eKw=; b=ACANzZEmhpaoSmtOEZ6JBoEGJ8c+Hz1BJPkip470x4r3cdkG0RSgOoQbinwStCBuqAnmKaN3VV0kXRRgWwAmysnLlzmUaurTT6qvBBe5LqGAopZ5eYZUhsN823lkIieYHCh/jf7zTrVDwg40lVeQF50X/Jd5Jo5Ie9SMXM+kCiw= From: Bertrand Marquis To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall Subject: Re: [PATCH] xen/dt: reject "xen,static-mem" when CONFIG_STATIC_MEMORY is disabled Thread-Topic: [PATCH] xen/dt: reject "xen,static-mem" when CONFIG_STATIC_MEMORY is disabled Thread-Index: AQHdJNOUeuyw7dxJRkGaYTQIrzZGNraPZFaA Date: Wed, 5 Aug 2026 12:36:21 +0000 Message-ID: <040DF1FA-14D5-466D-8139-22FA3B6C86B0@arm.com> References: <20260805121124.150017-1-michal.orzel@amd.com> In-Reply-To: <20260805121124.150017-1-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3864.600.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PR3PR08MB5593:EE_|GVXPR08MB11541:EE_|AM4PEPF00027A6A:EE_|DU2PR08MB10201:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f4b0ada-5b17-4f34-6035-08def2ee3ba6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|22082099003|18002099003|11063799006|56012099006|38070700021|10067099003; X-Microsoft-Antispam-Message-Info-Original: TIDFX+z3m/b3vYTYKbaDpb136eYYyyyDqMHD0OkijxVkBFEj+v1y51ZisliATH/N8HKniy2hutSvqn6+dqOUXXYyekjWLWil1X4QOujQqbmPYK272ygGsxb8V8rxWHUk+49lKiAvkNzpo5ltHuWP7OD8DjvOh6f5RBmpNgNsNuQWoTi+Cw/VRoqL6ckytZ4o2UHQDP4XlZcyOzptmr6hEBd3aNxS0v8QQlSmdpZzrQkqBJrRE+cgNbT8+9yr4MiYb23glOaN+oZXrpqYKfelwThA3gffohZDPi7mIJ942+qpiPcbxuXo9ZKKQdAQ0EacN/94w7k99DAawTv6w1oHwLYeq6yzVrttlSUZRdacZ1xWEva3hhqtUZ5NYZnCufeQtxGwxI3XcxB9uR3/XLExxvbfEtFPo6bDYpL4CZL4Axvfqd10l8HvvEifFd5Qw73AKcsDQ4oT5DULhSomaJewN1D1+JCVeXWM7c+sGxKp/0f8ezqNwuFzV6UlejKHTBhGladUJr/fSSRA8kvLdbMyBT70sjFhuWGcJu7BgwfVvNkCVoQLGm5pcNay1Ttk0c/6Gn6P10kqJhJDwAeROYrY+LnBnNirp2uBkS4EAOkCCTtorQfvoeNrljX4SPfsOQGh/TENlRBqIEwsVcDLJlGm+RgiI7AFq372iwrA8+4EL2YrIdPiUkUEdOyn6PaBs7LeryIP55QojnIHVdhOWGYt7Vmzux6Hv7M+/JZW3w7wonI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PR3PR08MB5593.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(22082099003)(18002099003)(11063799006)(56012099006)(38070700021)(10067099003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: X7PtPt1MGD9At8nACIU2GidkG9yTyUQFdU/Zb2z5p6Ufu6sUFAlWwwmD47wrW3+i4MRR1ldhW2wcUcwHcR4s+pNttJxTs/k+VQ2PAlCQK86lwOy3Yd6Nchu/Ea3blYSwk5PPbs8grHIpS/5lMBZciWm49+dRP+BBPOMcQXpJGvGf0Bjwd+E17TFx3eIVHgUlStcmvOnjDVI5gSbw+4ahAJD9zTLoODY2WxbnSjPRYIxOOmrW7+KoEdH8G/yHNCW3RC1e6eppMq7UiDLIYJdAYe6UFhni4O2eRRMef4OAManr8WASG9Am3Bq49q2D5bgEpuG1B9B+FyBqiVnDFYjnRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11541 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A6A.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1bf17a0c-c981-452a-a2e1-08def2ee27ce X-Microsoft-Antispam: BCL:0;ARA:13230040|14060799003|35042699022|376014|82310400026|1800799024|23010399003|36860700016|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 0GkIquKFzGmVa1D95dnUQVCCOinErv/ewQ5JM+bpUqO/UbhVujyh57uwgAlX3xLCBPaMBNlrpS+7SLXAvOFCX7chacZCP2OTSKkWIWcDD9xPCyS3qwgu6UIPtpIJTv1R/DIE/hx4zi884My30bDLrcZuur6vjNGPdJ1NFXALQpv7vRMco3lv2p9zIfwXv3qopHYtogRCwyBVwvZCeGqHIcBahg5pPMxuyQsSL2idC10HYMhUTuSnmb95Wyzw5QCmpj8e1sxPYLNf5QxQWKQE+aKmpTyY55NdPe0/dEDmFOmSTiuU5HENOYfQ9Eh9x6OUvWgiIA8WPWeQpuO4qyLNZ9Nymtx1eTKu00zkb6trdNRMRzG2BWKeMe2QGjhGhH5AazOkRVBP5ycRpoI+Xm3BkV1rSnJij8tFR02FFtRrMzDW7TCFZ9TFB4vizAULTcvPz80EcNlRRqvvpswVU9UKQlFyBPQVX1nTS7cY2T5SR4g9EtVsQk8nnXQtZTIy6uAa9mf5xM9EH7cH0vzCwo8gBzyoRDuwu21hIHr8VLT9ybL6XknUYawM20GXKIGHedE0I91KvdeJQO7GU8CvgdGV+U5ysbHuXFzAcIjCf5XCtWlXOZ5Nim6uAMXn9C6+Aw9jnw+0cpmi3bL1B5VenNx6aG/TN3TWEZowGPLFYM8iAywWv7x+YnDX7OmOg5jFGPksGMlHWmV4XdEi0DdFYYByBg== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(14060799003)(35042699022)(376014)(82310400026)(1800799024)(23010399003)(36860700016)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2gPPcS+PgzxDd33T6BblDXVf5jxfhhE7qWGi7YSKuIbVwINACQu2ho4GolwwmuZt8Qp8QkbjYsFj6yU1K3vYx71wJkZ+NaF4d+sI9E7EfGdhDEeP+yyQnXnq8H4idD5VfpAGbji+Ui5NXarv6iI+Zb1aDs8pkxdibgsuo0uDCfxqZdJT0oSTNrlCCjO6aZoHOJLLqksgV13BabrS3HG2XDnpsJ6EvUMkpih8expzDtnn6E7r9TvUdBL6pCd0ph38L7pQjX6fQufWmZG/XRJ03gRnom2TgG/pbGOxsFBUESEplpRjOMnfI4rw1wHH9KFs+3B3UgiRh+oGcu9fMIYsqP7ABEYm/KFMU0ymtuFKu9B5Bcltm3/WN52pIzEpvyyU9jln00V+l19OifCfgc8EJpfHbkIYNN9VLDkB3ozn6Hs74HfaBdA5b92KKX4jglaH X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 12:36:54.9175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f4b0ada-5b17-4f34-6035-08def2ee3ba6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A6A.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10201 X-purgate-ID: tlsNG-4011c0/1785933425-50ACCCFC-51586234/0/0 X-purgate-type: clean X-purgate-size: 1749 Hi Michal, > On 5 Aug 2026, at 14:11, Michal Orzel wrote: >=20 > process_domain_node() parses "xen,static-mem" regardless of > CONFIG_STATIC_MEMORY. With the feature off, init_staticmem_pages() is a > no-op stub, so boot carries on until construct_domU() reaches the > ASSERT_UNREACHABLE() stubs of allocate_static_memory() / > assign_static_memory_11(): a debug build trips the assertion, a productio= n > build gives the domain no memory at all. >=20 > Bail out at parse time instead, like process_shm_node() already does for > CONFIG_STATIC_SHM. >=20 > Fixes: 41c031ff437b ("xen/arm: introduce domain on Static Allocation") > Signed-off-by: Michal Orzel Acked-by: Bertrand Marquis Cheers Bertrand > --- > xen/common/device-tree/bootinfo-fdt.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/xen/common/device-tree/bootinfo-fdt.c b/xen/common/device-tr= ee/bootinfo-fdt.c > index 272b5a6c0ae6..ca64daf4cdc8 100644 > --- a/xen/common/device-tree/bootinfo-fdt.c > +++ b/xen/common/device-tree/bootinfo-fdt.c > @@ -349,6 +349,12 @@ static int __init process_domain_node(const void *fd= t, int node, > /* No "xen,static-mem" present. */ > return 0; >=20 > + if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) ) > + { > + printk("CONFIG_STATIC_MEMORY must be enabled for parsing xen,sta= tic-mem\n"); > + return -EINVAL; > + } > + > return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_c= ells, > size_cells, bootinfo_get_reserved_mem(= ), > MEMBANK_STATIC_DOMAIN); > --=20 > 2.43.0 >=20 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:41:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:41:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383368.1626624 (Exim 4.92) (envelope-from ) id 1wrawC-00036e-Cl; Wed, 05 Aug 2026 12:41:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383368.1626624; Wed, 05 Aug 2026 12:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrawC-00036X-94; Wed, 05 Aug 2026 12:41:36 +0000 Received: by outflank-mailman (input) for mailman id 1383368; Wed, 05 Aug 2026 12:41:34 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrawA-00036E-OR for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:41:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wraw9-003tJ0-TB for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:41:33 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a732f66-2eae-0a2a0a5409dd-0a2a4505a08c-36 for ; Wed, 05 Aug 2026 14:41:33 +0200 Received: from [209.85.218.42] (helo=mail-ej1-f42.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a732f7d-4cb1-0a2a45050019-d155da2ac5dd-3 for ; Wed, 05 Aug 2026 14:41:33 +0200 Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-c1c24ec9525so159578466b.1 for ; Wed, 05 Aug 2026 05:41:33 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2036461395sm103784666b.62.2026.08.05.05.41.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 05:41:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785933693; x=1786538493; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0QaMmvum05DIEb1UosvTT9n8I5x15tm5IM4WzUyxoRw=; b=U9uNaUOkEi2Frt6B8MqqJE0Q6DKo4gh60p20aT/JWgPcj1pKEg6i17RzjmrDIpV+3/ Vd9R82bvR/3llIub20ItSfz6fN4bOescDRmAlfmw6iljxCmJse3TIqpHVfxZruIe4EtZ B8VG6QmUtOFt6J/ItQquSfSaoEfY/FdVZ3jH2x0qGxOhc4K0NJnP4SYat/2W5s3JqE4V fdFhPo2ZM9Qx8OrD76nQEnB5SdOfpWB5A7QU7vzvGBP+MHWG+2Dt+4LemhexPSvyZfG9 xhImJJ2zUjycHlW6Jf3LyyN+hr8vkctj2X8TTFUmGOOcXRGgbvm/PrHWrAKxXjZ+4umC Ji5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933693; x=1786538493; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0QaMmvum05DIEb1UosvTT9n8I5x15tm5IM4WzUyxoRw=; b=FoIXTIPI7E6BGxsD10KFnGxUuPwKckXp0osKcmz19WSM7s5Q584al5St7uBRoXbe/d nqNQkotA07zZ8C0yFu3wfum1xiLdTZ9lo1qCV3vUzfuuUovyUMJ2I/CRVToEpbTItfB0 Z039UmrIqVaCGxbi4QDYBe/ZC5ZHyHeBLhw0kHqKF8MpIIoqLaDUm981LCToJdOMi4Sg sObpiL8iPWXe8/ctN7avrk3Lo996YwSXspwfYJDXK4EPQ43PASW96wO4ZvVSPHgpjzRl NXDPSSv7T31nvk2tVMtDct1xurzk7ycd17sWsAbSqAs9ieUXrYTehboiyEnaSwDTjMrM kMcw== X-Gm-Message-State: AOJu0Yz2S1guTNX2kSLGJEvOwAU75nJA5VV8rlIFRylal0NGQusNoLp4 EE8FIIyDRLXdX9Go9tuvS6aExIzc8DLdi89j6LaM0LdnPo7kpMwZTbpqBZhTFTrInn0= X-Gm-Gg: AR+sD1076gGms7LPqPbfD+4kAVG2uU50l83GMgT8fvW6DTEMdNBuN4b2f36k5oBShyo PLlkcBFMgVRDgCEF/q1XovhrEUuvtUD3/iRcI4/QTuVk66Bep/1wIp456JBlcr+OJpH+tMeTjkB JJ0wY4dNSeNp5tZhqUHLcv1IX1K2mItgYW+mvd//lMjXSyf73LrTZ9IAsTAFBnkfYhSCFir3Fwk yi1OdTUGFPWuPoyxHunsI/ra7h2KrgCMrRerWmh4oPhCZNhmzs0sQQSg8S0390veKK58rWMZZen regDIdMVqt4pt0QWGl8TUggzuIYMEMbMBW4y/Blvn14QZ+6W1oQIy5SWKs8I2sr3OB3La+bABFh OptizJoM6iOTkbaKQESIdgdyL5aUzg9bOWiCOK5YTj/BAoVrcL741h2hlI4uEwgjyrqlkZ0U8Ql JdinRmH94wTTtyQltKebK1M2DADUXE0oWppHfgNK5IrVBpTMhOkQokH3mDa5n0SHJ87JWt+PsJF J2UourL7vv7H9VDM/34zlMNOJh+3wT6hIlyFuUy3bpbex1ltJ/l/dlwi008+o3R/9tQA7PitDB1 AxVwOMTBkW4jtec= X-Received: by 2002:a17:907:934b:b0:c20:768:af62 with SMTP id a640c23a62f3a-c2039c6c8a2mr341458166b.22.1785933692951; Wed, 05 Aug 2026 05:41:32 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 14:41:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) To: George Dunlap Cc: xen-devel References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZRJM6pLxAC9zdk5WjgZzPb3j" X-purgate-ID: tlsNG-c201ff/1785933693-F68B62A1-8C327E0F/0/0 X-purgate-type: clean X-purgate-size: 10094 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZRJM6pLxAC9zdk5WjgZzPb3j Content-Type: multipart/mixed; boundary="------------uvadjcU5bDKL9u0vra1EE0hE"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: George Dunlap Cc: xen-devel Message-ID: Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> In-Reply-To: --------------uvadjcU5bDKL9u0vra1EE0hE Content-Type: multipart/mixed; boundary="------------yjwpHgik2wtI91TARDmFirUE" --------------yjwpHgik2wtI91TARDmFirUE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTQ6MTUsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+IFtBZGRpbmcgYmFj ayBpbiB4ZW4tZGV2ZWwsIHNpbmNlIHRoaXMgaXMgcmVsZXZhbnRdDQo+IA0KPiBPbiBXZWQs IEF1ZyA1LCAyMDI2IGF0IDk6MTXigK9QTSBKw7xyZ2VuIEdyb8OfIDxqZ3Jvc3NAc3VzZS5j b20gDQo+IDxtYWlsdG86amdyb3NzQHN1c2UuY29tPj4gd3JvdGU6DQo+IA0KPiAgICAgT24g MDQuMDguMjYgMTE6MzQsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+ICAgICAgPiBPbiBUdWUs IEF1ZyA0LCAyMDI2IGF0IDY6NDXigK9QTSBKw7xyZ2VuIEdyb8OfIDxqZ3Jvc3NAc3VzZS5j b20NCj4gICAgIDxtYWlsdG86amdyb3NzQHN1c2UuY29tPg0KPiAgICAgID4gPG1haWx0bzpq Z3Jvc3NAc3VzZS5jb20gPG1haWx0bzpqZ3Jvc3NAc3VzZS5jb20+Pj4gd3JvdGU6DQo+ICAg ICAgPg0KPiAgICAgID4NCj4gICAgICA+wqAgwqAgwqBQLlMuOiBHZW9yZ2UsIHdvdWxkIGl0 IGJlIHBvc3NpYmxlIHRvIHR1cm4gb2ZmIEhUTUwgbWFpbHMgd2hlbiBzZW5kaW5nIHRvDQo+ ICAgICAgPsKgIMKgIMKgIMKgIMKgIMKgIMKgeGVuLWRldmVsPw0KPiAgICAgID4NCj4gICAg ICA+DQo+ICAgICAgPiBJIHNlZSBib3RoIGEgdGV4dC9wbGFpbiBwYXJ0IGFuZCBhIHRleHQv aHRtbCBwYXJ0IGluIHRoZSBtYWlsIEkgc2VudDsNCj4gICAgIGlzbid0IHRoZQ0KPiAgICAg ID4gcHJlc2VuY2Ugb2YgYSB0ZXh0L3BsYWluIHZlcnNpb24gc3VmZmljaWVudD8NCj4gICAg ICA+DQo+ICAgICAgPiBPYnZpb3VzbHkgc2VuZGluZyBwYXRjaGVzIGlzIGEgZGlmZmVyZW50 IG1hdHRlcjsgYnV0IGZvciB0aGF0IEknbGwgYmUNCj4gICAgIHVzaW5nIGdpdC0NCj4gICAg ICA+IHNlbmQtZW1haWwuDQo+IA0KPiAgICAgVGhpcyBpcyBhIHJlcGx5IHRvIHlvdXIgbWFp bCB1c2luZyBUaHVuZGVyYmlyZCAod2hpY2ggSSBoYXZlIGNvbmZpZ3VyZWQgdG8gdXNlDQo+ ICAgICBwbGFpbiB0ZXh0IGZvcm1hdCBhcyB0aGUgZGVmYXVsdCwgaW4gb3JkZXIgdG8gY29t cGx5IHdpdGggbW9zdCBtYWlsaW5nIGxpc3RzDQo+ICAgICBJJ20gdXNpbmcpLg0KPiANCj4g ICAgIEkgZG9uJ3QgdGhpbmsgVGh1bmRlcmJpcmQgaXMgYW4gZXhvdGljIE1VQSwgYnV0IHBs ZWFzZSBoYXZlIGEgbG9vayBob3cgaXQNCj4gICAgIHJlbmRlcmVkIHlvdXIgSFRNTCByZXBs eSB0byBteSBvcmlnaW5hbCBtYWlsLiBJIGNhbid0IHNlZSBjbGVhcmx5IHdoaWNoIHBhcnQN Cj4gICAgIHdhcyB3cml0dGVuIGJ5IG1lIG9yaWdpbmFsbHkgYW5kIHdhcyBjaXRlZCBieSB5 b3UgaW4gdGhpcyBtYWlsLg0KPiANCj4gDQo+IFRoYW5rcywgdGhpcyBpcyB3aGF0IEkgd2Fz IGxvb2tpbmcgZm9yLg0KPiANCj4gQXR0YWNoZWQgaXMgdGhlIG1lc3NhZ2UgR21haWwgc2Vu dC7CoCBBcyB5b3UgY2FuIHNlZSwgdGV4dC9wbGFpbiB1c2VzIG5vcm1hbCBgPmAgDQo+IGZv ciBxdW90ZXMuDQo+IA0KPiBUaGF0IG1ha2VzIG1lIHRoaW5rIHRoYXQgdGhlIHByb2JsZW0g aXMgaW4gVGh1bmRlcmJpcmQuIEl0IHNob3VsZCBlaXRoZXIgdGFrZSANCj4gdGhlIHRleHQv cGxhbiBwYXJ0LCBhbmQgcmVwbHkgdG8gdGhhdCBhcyB0aG91Z2ggaXQgd2VyZSB0aGUgb25s eSBwYXJ0IGl0IGhhZCANCj4gcmVjZWl2ZWQ7IG9yIGl0IHNob3VsZCB0YWtlIHRoZSBIVE1M IHBhcnQsIGFuZCBjb252ZXJ0IHRoZSBxdW90ZXMgdG8gdGV4dCANCj4gcHJvcGVybHkuwqAg UmVwbHlpbmcgaW4gSFRNTCBhbmQgdGhlbiByZW5kZXJpbmcgaXQgd2l0aCBvbmx5IHNwYWNl IGluZGVudGF0aW9ucyANCj4gc2VlbXMgbGlrZSBhIGJ1Zy4NCj4gDQo+IFRodW5kZXJiaXJk IGNlcnRhaW5seSBpc24ndCBleG90aWMsIGJ1dCBsYXN0IHRpbWUgSSB1c2VkIGl0IGl0IHdh cyBkZWZpbml0ZWx5IA0KPiB1bmRlci1tYWludGFpbmVkLg0KPiANCj4gWW91J3JlIGFza2lu ZyBldmVyeSBwZXJzb24gd2hvIHNlbmRzIGFuIGVtYWlsIHRvIHhlbi1kZXZlbCB0byByZW1l bWJlciB0byB0YWtlIA0KPiBhbiBhY3Rpb24gYmVmb3JlIHNlbmRpbmcgdGhlIG1haWwgKG9y IHRvIHNlbmQgKmFsbCogbWFpbCBhcyB0ZXh0L3BsYWluLCBldmVuIGlmIA0KPiBpdCdzIG5v dCB0byB4ZW4tZGV2ZWwpLCBiZWNhdXNlIHlvdXIgTVVBIGlzbid0IGhhbmRsaW5nIHRoZSBz dGFuZGFyZCBwcm9wZXJseS4gIA0KDQpBbmQgeW91IGFyZSBhc2tpbmcgZXZlcnkgVGh1bmRl cmJpcmQgdXNlciB0byBsaXZlIHdpdGggYmFkIHRocmVhZGluZyBvciB0bw0KdXNlIGEgZGlm ZmVyZW50IG1haWwgY2xpZW50Lg0KDQo+IElzIHRoYXQgcmVhbGx5IHJlYXNvbmFibGU/wqAg Q291bGRuJ3QgeW91IHRlbGwgVGh1bmRlcmJpcmQgdG8gaWdub3JlIGh0bWwgYW5kIA0KPiBv bmx5IHJlbmRlciB0ZXh0L3BsYWluPw0KDQpJIGRpZCBsb29rIGZvciBhIHNldHRpbmcgY29u dHJvbGxpbmcgdGhhdCwgYnV0IGNvdWxkbid0IGZpbmQgYW55LiBJJ20gYWxyZWFkeQ0KdXNp bmcgdG8gc2VuZCBwbGFpbiB0ZXh0IG9ubHkuIFRoZXJlIHNlZW1zIHRvIGJlIG5vIG9idmlv dXMgY29udHJvbCB0byBwcmVmZXINCnRleHQgb3ZlciBodG1sIGluIGFsdGVybmF0aXZlIGJv ZGllcy4NCg0KT24gTWF0cml4IHlvdSBzdGF0ZWQgeW91IGFyZSB1c2luZyB0aGUgc2FtZSBj b25maWd1cmF0aW9uIGZvciBzZW5kaW5nIG1haWxzIHRvDQp4ZW4tZGV2ZWwgc2luY2UgMjAw Ni4gSSdtIG5vdCBzdXJlIHRoaXMgaXMgdHJ1ZSwgYXMgbW9zdCBtYWlscyBJJ3ZlIHJlY2Vp dmVkDQpmcm9tIHlvdSB2aWEgeGVuLWRldmVsIGhhdmUgYmVlbiBzZW50IGZyb20geW91ciBD aXRyaXggYWNjb3VudCwgYW5kIHRob3NlIHdlcmUNCmFsbCB0ZXh0LW9ubHkuDQoNCg0KSnVl cmdlbg0K --------------yjwpHgik2wtI91TARDmFirUE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------yjwpHgik2wtI91TARDmFirUE-- --------------uvadjcU5bDKL9u0vra1EE0hE-- --------------ZRJM6pLxAC9zdk5WjgZzPb3j Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpzL3wFAwAAAAAACgkQsN6d1ii/Ey+N 0Qf+Oz+4knDaDZrFzTXvCPkf6w7xmSFDMubRRs8MfCp4BEZDgsOSHLHydn8dUR9kQg4FJiSicdJ5 RAXUTF2EBmlf0hhODc81xEWuY9rmipE3UUP2CMJi+C5CH4WY/tUl/ScyZ6NNBMSkxEfdp+t7nSsc ayo1aSgP26D37Newtjn5j4IR53Wd9YqnyjMFfYSsKPkz/iBd3w3DudQUwp9fBYmKih8oSLgcl7yh 8stny+MkQKvQDs43OoMduNUUL2BOYLVAF+YJQQoAYTUpSZ2U9U4lXVlv3At0O+LWy7y5Z+y13zAc C7swPP5I9E8J4QmIqw6TEDiPMbhJ77qfY7nW0kpMXA== =OSNP -----END PGP SIGNATURE----- --------------ZRJM6pLxAC9zdk5WjgZzPb3j-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:43:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:43:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383377.1626633 (Exim 4.92) (envelope-from ) id 1wraxW-0003ef-Om; Wed, 05 Aug 2026 12:42:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383377.1626633; Wed, 05 Aug 2026 12:42:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraxW-0003eY-LT; Wed, 05 Aug 2026 12:42:58 +0000 Received: by outflank-mailman (input) for mailman id 1383377; Wed, 05 Aug 2026 12:42:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wraxU-0003eP-It for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:42:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wraxT-00CG6T-FM for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:42:55 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a732fc6-5cb7-0a2a0a5109dd-0a2a4507c282-10 for ; Wed, 05 Aug 2026 14:42:55 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a732fce-b4ea-0a2a45070019-b9ff1c12ad2d-3 for ; Wed, 05 Aug 2026 14:42:54 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fd1f2bc52000e099.002 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 05 Aug 2026 12:42:53 +0000 Received: from [192.168.1.18] (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie) by mail2.vates.fr (Postfix) with ESMTPSA id 1DC4481FD3; Wed, 5 Aug 2026 14:42:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=gfMf2inEG6pdNO/k2iXwdhSdR+/CUahmyCFr9YdPWmo=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=sQQuJ+h2yWOqkFcO6QIYQiqoWBUOaH1wXsIcn1xeYOG8/qJXXEsct90dT/VHoxQgRxqmETXqc 2rapoTuDZjXMAAi+mA7jXhB+ir8ID31e0uQBEYlvKrRcwAt5rsrHu4k/IwULXMw4/BwQR+AYp2+ Gd7KFARXvb4chnUIcQHEli9SmIhG7N698+LM+aLixWYuvjB+XiM7PUXCjGtr+ePxMFIxSoL+B5D Jmn8maLXgixPshRs5izAv4ZhW/N8uKHodODgUPxQOjs1LX1JLVD08SLzS2M3OJ7va0oa22Gockj jZ9HmDC4NuKOSjWrCIvOVWrSARttnTXEqH6QeshXdW7A== X-Zone-Loop: 36e1f8791f1a1bf331bd4481293e85525dec21758348 x-campaign-type: default x-transaction-id: b89f5a5f-a33e-4a3d-b693-31f403d88185 x-swg-uid: 01-116444aa-9e67-4a48-979c-fff7f6abd1e3 X-Mailer: Sweego Message-ID: <1785933773.8631fc262581453bbf619ec5b2062170.19fd1f2bc52000e099@vates.tech> x-swg-bid: 1785933773.8631fc262581453bbf619ec5b2062170.19fd1f2bc52000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Wed, 5 Aug 2026 14:42:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] vtd: Move intremap table to xenheap To: Andrew Cooper , Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org, George Dunlap References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319343.8631fc262581453bbf619ec5b2062170.19fad5345fc000e099@vates.tech> <451978a5-7dfd-4b91-a241-eb13caf6d394@suse.com> <59d0de8f-2d97-4f65-af16-876be20398fa@citrix.com> Content-Language: en-US From: Teddy Astie Autocrypt: addr=teddy.astie@vates.tech; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa In-Reply-To: <59d0de8f-2d97-4f65-af16-876be20398fa@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------GTmS6zkj5FCxYf87Yo944WNQ" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1785933773255 X-purgate-ID: tlsNG-ef75cf/1785933775-372DCAE4-531C9AC0/0/0 X-purgate-type: clean X-purgate-size: 7403 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------GTmS6zkj5FCxYf87Yo944WNQ Content-Type: multipart/mixed; boundary="------------kRpbAI5tISuh33WXwkRqz3Cm"; protected-headers="v1" From: Teddy Astie To: Andrew Cooper , Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org, George Dunlap Message-ID: Subject: Re: [PATCH 5/5] vtd: Move intremap table to xenheap References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319343.8631fc262581453bbf619ec5b2062170.19fad5345fc000e099@vates.tech> <451978a5-7dfd-4b91-a241-eb13caf6d394@suse.com> <59d0de8f-2d97-4f65-af16-876be20398fa@citrix.com> In-Reply-To: <59d0de8f-2d97-4f65-af16-876be20398fa@citrix.com> --------------kRpbAI5tISuh33WXwkRqz3Cm Content-Type: multipart/mixed; boundary="------------8GEWshzGg3W6GDgYK8rnW80B" --------------8GEWshzGg3W6GDgYK8rnW80B Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 TGUgMDUvMDgvMjAyNiDDoCAxMjowOSwgQW5kcmV3IENvb3BlciBhIMOpY3JpdMKgOg0KPiBP biAwNS8wOC8yMDI2IDEwOjQ0IGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDI5LjA3 LjIwMjYgMTE6NTksIFRlZGR5IEFzdGllIHdyb3RlOg0KPj4+IEludGVycnVwdCByZW1hcHBp bmcgZW50cmllcyBvZnRlbiBuZWVkcyB0byBiZSBhY2Nlc3NlZCwgYW5kIHdlJ3JlIGNyZWF0 aW5nDQo+Pj4gcG9pbnRlcnMgdG8gaXQgb24gZGVtYW5kLCB3aGljaCBicmluZ3MgYSBsb3Qg b2YgY29tcGxleGl0eSAoZS5nDQo+Pj4gR0VUX0lSRU1BUF9FTlRSWSgpIG1hY3JvKSwgbW92 ZSBpdCB0byB4ZW5oZWFwIHN1Y2ggdGhhdCBpdCdzIHBlcnNpc3RlbnRseQ0KPj4+IG1hcHBl ZCBhbmQgd2Ugd29uJ3QgaGF2ZSB0byB3b3JyeSBhYm91dCBtYXBwaW5nIGFuZCB1bm1hcHBp bmcgaW5kaXZpZHVhbA0KPj4+IGludHJlbWFwIHRhYmxlIHBhZ2VzLg0KPj4gQWZhaWM6IE5v IG1vdmVtZW50IGZyb20gZG9taGVhcCB0byB4ZW5oZWFwIGV4Y2VwdCBmb3IgX3ZlcnlfIGdv b2QgcmVhc29ucy4NCj4+IEZvciB0aGUgY2FzZSBoZXJlIHRoYXQgaXMgLSBtYXliZSBlc3Rh Ymxpc2ggYSBwZXJtYW5lbnQgbWFwcGluZyB1c2luZw0KPj4gdm1hcCgpLCBidXQgbm8gY2hh bmdlIGluIHdoZXJlIHRoZSBtZW1vcnkgaXMgdG8gY29tZSBmcm9tLiBXaGV0aGVyIHN1Y2gg YQ0KPj4gcGVybWFuZW50IG1hcHBpbmcgaXMgcmVhbGx5IHdvcnRod2hpbGUgbWF5IGFsc28g d2FudCBzdXBwb3J0aW5nIGJ5IG51bWJlcnMuDQo+PiBZb3Ugc2F5ICJvZnRlbiIsIGJ1dCB5 b3UgZG9uJ3QgcXVhbGlmeSAvIHF1YW50aWZ5IHRoaXMgYW55IGZ1cnRoZXIuDQo+IA0KDQpJ IHRoaW5rIHRoZSByZWR1Y3Rpb24gdGhlIGNvbXBsZXhpdHkgb2YgdGhlIGxvZ2ljIGlzIGEg Z29vZCByZWFzb24gaW50byANCnVzaW5nIGEgcGVyc2lzdGVudCBtYXBwaW5nIGhlcmUgKGVz cGVjaWFsbHkgc2luY2UgaXQncyBub3QgYSANCnBhcnRpY3VsYXJseSBsYXJnZSBvbmUpLg0K DQo+IFRvIGV4cGFuZCBvbiB0aGUgIndoeSIgYSBiaXQgbW9yZS4NCj4gDQo+IEZvciBzeXN0 ZW1zIHdpdGggYWxsIFJBTSBiZWxvdyB0aGUgNFQgYm91bmRhcnksIGRvbWhlYXAgYW5kIHhl bmhlYXAgYXJlDQo+IGVxdWl2YWxlbnQuwqAgV2UgaGF2ZSA1VCBvZiBkaXJlY3RtYXAsIGJ1 dCB4ZW5oZWFwIGFsbG9jYXRpb25zIGhhdmUgYQ0KPiB3aWR0aCByZXN0cmljdGlvbiB3aGlj aCBpcyBhIHBvd2VyLW9mLTIuDQo+IA0KPiBGb3Igc3lzdGVtcyB3aXRoIGFueSBSQU0gYWJv dmUgdGhlIDRUIGJvdW5kYXJ5LCB5b3UgY2FuJ3QgaGF2ZSB4ZW5oZWFwDQo+IGFsbG9jYXRp b25zIGJlIE5VTUEtbG9jYWwgZm9yIGFsbCBOVU1BIG5vZGVzLg0KPiANCj4gDQo+IEFzIGZv ciAib2Z0ZW4iLCB0aGUgSVJURXMgYXJlIG1vZGlmaWVkIGV2ZXJ5IHRpbWUgYSB2Q1BVIG1v dmVzIHRvIGENCj4gZGlmZmVyZW50IFBDUFUsIGJlY2F1c2UgdGhlIHRhcmdldCBhZGRyZXNz ZXMgbmVlZCB1cGRhdGluZy7CoCBXaGlsZSBpdA0KPiBwcm9iYWJseSBkb2Vzbid0IG1hdHRl ciBtdWNoIHRvZGF5LCBpbiB0aGUgY29udGV4dCBvZiBBU0kgaXQncyBzb21ldGhpbmcNCj4g d2hpY2ggd291bGQgd2FudCBtYXBwaW5nIHBlcm1hbmVudGx5LCByYXRoZXIgdGhhbiBvbi1k ZW1hbmQuDQo+IA0KDQpPaywgc28gZG9taGVhcCB3aXRoIHZtYXAgd291bGQgYmUgcHJlZmVy YWJsZSBoZXJlLg0KDQo+IH5BbmRyZXc+DQoNClRlZGR5DQo= --------------8GEWshzGg3W6GDgYK8rnW80B Content-Type: application/pgp-keys; name="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Disposition: attachment; filename="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7L TBVHV/XOZw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJ T4ny+OGntnJntUoRKRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJA WicutjkkUgd28Bh6HV9EIumHtCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO 8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaTVqMdqul07o72m3eA2mf+LMu9a04FX/d4 wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/EoucejoZ5SH49ksmVAmKOLkt OaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+SPhHar7TPKjFz0G3D PNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89MXfQXZ3q t1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWj moACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNz uyOVCskwfUZPla6Zpd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp 0x0HfuhcYfAYPR46XHTvjaJEv99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuR OxdK8G+YHccJY8PvWSq2K2yiae2KGiAv1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50 wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhPeP3IdpfWc8cyRLXF06Rk46YM YCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcTUwgnYlFRk2FLq0Qe KEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9Egr/Wmu3 MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEM AKiQiZa3yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ 3DbVf+en3/FvdVZg2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTm etSG5/52AjtmPFtlXAk0NmLvfJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0 s3109sJeXT5ImVdphFs9cvyZyBT9t1PbRowv58EgV0zE4hbAeVkULAbxFV5b/ExT jjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKbYu6NCfiHfEyB3Xyg9hfdrRgj MRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ovXoK4jm+Py0FiUGUa A6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/eVtR2Q1w ZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWj moACGwwACgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiV oUiHYN5QwhnbZnsaJDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764Qxy X6rld2f2RcWkDuBHun55ZWXjby8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk /dS0XTOQi2wVUb17sW/+ybCEokdVacZGzOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fu oGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+lOWSvdNHgoEkWR0RXBPQjnGm LKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/OffO485NOTKwGOxyWb0 06cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR8ULR9nX0 LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa =3DlUIA -----END PGP PUBLIC KEY BLOCK----- --------------8GEWshzGg3W6GDgYK8rnW80B-- --------------kRpbAI5tISuh33WXwkRqz3Cm-- --------------GTmS6zkj5FCxYf87Yo944WNQ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmpzL8wFAwAAAAAACgkQZg+p0QLLz9DA 6gv7BltTaonVluo9LKHT9I/blqHpaofr38z4HkJzHm8CWcqWysnFLsdtJdZqedLwF3TcAkx8NCKm wasH4fZX1xMRiMULsFnrgntiUMJZz2v8IEfK44XKxo1Eb6s5bzUSRINraQ7LXo0wK2ukHbkd4JT6 zWHMmhg5kz9AdIPF2Rtoiq6X1qUrZjPvDKg4EILopPjbzzQC7Kvvi5Hgk8SYQYFylJ/8ybf3BFI7 IJ5D6Z0PzGsOPWtRbcMgnD6f4uoe5K5WJ8P/g+qPCXhkuULkhosqkqK2gmsdBWgPuGZ++AiR9fnQ ucUtYz3yMb86gFzrsreRhmJDqrXYCYBc1uQEBf54SQ8tJF1Nf8Xu0fHAGiCFZ+M0c3bR/hODQ38i LUVUPeb71H7p3EdmZl/z4CqJGZAJNmIoIeUQEwpsasCrpthkIz1YxtTFffsFjYDc1Pmm48J+7ypc SEaRaMo+pQSt2E2pS3kdh0gWSZZ4QIL2Vo9ZA3y6WWuP/UiL+Q1fT/n2vZca =U8KH -----END PGP SIGNATURE----- --------------GTmS6zkj5FCxYf87Yo944WNQ-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:45:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:45:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383390.1626666 (Exim 4.92) (envelope-from ) id 1wrazy-0004Sj-GN; Wed, 05 Aug 2026 12:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383390.1626666; Wed, 05 Aug 2026 12:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrazy-0004Sc-CX; Wed, 05 Aug 2026 12:45:30 +0000 Received: by outflank-mailman (input) for mailman id 1383390; Wed, 05 Aug 2026 12:45:29 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrazx-0004Pq-Pr for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:45:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrazx-004adb-5y for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:45:29 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733061-2eae-0a2a0a5409dd-0a2a450382f4-24 for ; Wed, 05 Aug 2026 14:45:29 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733069-fae8-0a2a45030019-d155dd31b952-3 for ; Wed, 05 Aug 2026 14:45:29 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47f84023916so817188f8f.3 for ; Wed, 05 Aug 2026 05:45:29 -0700 (PDT) Received: from andrew-laptop.. ([157.231.70.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e533sm8779762f8f.28.2026.08.05.05.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 05:45:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785933928; x=1786538728; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/9e6A8lC1tkLbZ56fkZqK4C1TbgXO56ls4av+lt8mI4=; b=oti0kg3AVl1LHrgzwn6xfD6lu0S2jgpc69Bd+ZBIvOSVfroggz8dqYvfnst7nuXXFo UMyhpBsLHmC4Vnipzvzb8T415oy8mBIUncblimuA1WVwvSPijU3H5u1DYcro28w8vVPk 7iJp6Z5EcMHiAw83+TTSBqyJp8xn9OHGzpnLk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933928; x=1786538728; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/9e6A8lC1tkLbZ56fkZqK4C1TbgXO56ls4av+lt8mI4=; b=hnnWWWadiWjrYGBTxZqXvcW3I+CDTKH9OHKagtZab/AQtLUBXrP/NhMWEoqt65gQRo fgWnmRo+H6/z+h5weXw5x6RPTIXuLaHoket1cN0mtGvNtBdJ6TFEHslkCL2O7Y2ayeWD qjQEyXfZDHxwhknubm8s3DsGd+8sGhTM2f5+/NbzbEGo2oYHS0T9pNEcX3rNgCcZGRjH +q6K1eR0iIwfPWzBs37LhRdzuKNCms7sGw5NVwfRFQUWM6i/5FT0RHB/vJH7ynzqRcU2 lRblTKWjK6g8ZkkZYnQSfG5OhtrRHDxYlxBL+l6rQFuVNBviJQinPnVS/oGOpvlJ/E66 uR1A== X-Gm-Message-State: AOJu0YzlZYhHPvL0585h8fHwFI7dOiTGkKqyKfCVMci8yscSIWY5L7fg iK2yVoIgHrnEQ+gPE3CidDPpJk6AfqTT2s8FqK/0uF4H70weyIdkCDGr3u0KK++Ooxj94dRv1Bz L7fMFLac= X-Gm-Gg: AR+sD10ewMCSIIVXo+EOLHika776xFvy9H0uFxwihmPCValhlx0EZBWVN+axV9vsmyZ FD94mZff9sAxUW2oJEpYgHTp0qCFQFHfC14XoJh1ucchBeSj/L1ZR/O/O8sYDrSZYxX33yElczs HweDrmDSwGWLqcf+YOLhO0ErBy9yoTbAhep+t5V4XCH3KC+zSxw0hA5b7FEn9IK4lZWQs0HPhvW OUSmGICOGAOZcO9oYX3dR46PLty9zjD8RtSwG9VDZlSNyd1tIXuNDw7nC/Og0Ul2zoDsgoeE828 VygqClMa/tBfbZEg9OJfn0+BHh3MuJo94HfnZpaoPIMltd88AHNHt35Sl9bGz6bDuGfOLL0eeV+ z8M5agQbXY5CdfRdsJKgl4xDFrJ7aNXvykrM+o0Y45H9El9d0rjEQzE1bD+e9d7MnLUWCagmi8O mCJVt7gKyOWtn0FxTYTbxBt/5pLpAWgVfubN+e4F8TDGkW+7u2DkXeFlgXyUGJZwBBFkwXzYQp X-Received: by 2002:a5d:5f09:0:b0:47f:7aee:ed3c with SMTP id ffacd0b85a97d-47fec4e2a1cmr12936314f8f.5.1785933928318; Wed, 05 Aug 2026 05:45:28 -0700 (PDT) From: Andrew Cooper To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH 1/5] x86/nmi: Drop {reserve,release}_lapic_nmi() Date: Wed, 5 Aug 2026 13:45:21 +0100 Message-Id: <20260805124525.105457-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260805124525.105457-1-andrew.cooper3@citrix.com> References: <20260805124525.105457-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785933929-768FA4E9-06458010/0/0 X-purgate-type: clean X-purgate-size: 3296 With Oprofile support dropped, there are no more users of these. Drop them. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie --- xen/arch/x86/include/asm/apic.h | 2 -- xen/arch/x86/nmi.c | 50 --------------------------------- 2 files changed, 52 deletions(-) diff --git a/xen/arch/x86/include/asm/apic.h b/xen/arch/x86/include/asm/apic.h index 918f1cee3567..f30d57ad22c5 100644 --- a/xen/arch/x86/include/asm/apic.h +++ b/xen/arch/x86/include/asm/apic.h @@ -174,8 +174,6 @@ extern void setup_boot_APIC_clock (void); extern void setup_secondary_APIC_clock (void); extern void setup_apic_nmi_watchdog (void); extern void disable_lapic_nmi_watchdog(void); -extern int reserve_lapic_nmi(void); -extern void release_lapic_nmi(void); extern void self_nmi(void); extern void disable_timer_nmi_watchdog(void); extern void enable_timer_nmi_watchdog(void); diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 91f95fe6d080..616bfdbc9029 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -89,20 +89,6 @@ static int __init cf_check parse_watchdog_timeout(const char *s) } custom_param("watchdog_timeout", parse_watchdog_timeout); -/* - * lapic_nmi_owner tracks the ownership of the lapic NMI hardware: - * - it may be reserved by some other driver, or not - * - when not reserved by some other driver, it may be used for - * the NMI watchdog, or not - * - * This is maintained separately from nmi_active because the NMI - * watchdog may also be driven from the I/O APIC timer. - */ -static DEFINE_SPINLOCK(lapic_nmi_owner_lock); -static unsigned int lapic_nmi_owner; -#define LAPIC_NMI_WATCHDOG (1<<0) -#define LAPIC_NMI_RESERVED (1<<1) - /* nmi_active: * +1: the lapic NMI watchdog is active, but can be disabled * 0: the lapic NMI watchdog has not been set up, and cannot @@ -239,41 +225,6 @@ void disable_lapic_nmi_watchdog(void) nmi_watchdog = NMI_NONE; } -static void enable_lapic_nmi_watchdog(void) -{ - if (nmi_active < 0) { - nmi_watchdog = NMI_LOCAL_APIC; - setup_apic_nmi_watchdog(); - } -} - -int reserve_lapic_nmi(void) -{ - unsigned int old_owner; - - spin_lock(&lapic_nmi_owner_lock); - old_owner = lapic_nmi_owner; - lapic_nmi_owner |= LAPIC_NMI_RESERVED; - spin_unlock(&lapic_nmi_owner_lock); - if (old_owner & LAPIC_NMI_RESERVED) - return -EBUSY; - if (old_owner & LAPIC_NMI_WATCHDOG) - disable_lapic_nmi_watchdog(); - return 0; -} - -void release_lapic_nmi(void) -{ - unsigned int new_owner; - - spin_lock(&lapic_nmi_owner_lock); - new_owner = lapic_nmi_owner & ~LAPIC_NMI_RESERVED; - lapic_nmi_owner = new_owner; - spin_unlock(&lapic_nmi_owner_lock); - if (new_owner & LAPIC_NMI_WATCHDOG) - enable_lapic_nmi_watchdog(); -} - /* * Activate the NMI watchdog via the local APIC. * Original code written by Keith Owens. @@ -417,7 +368,6 @@ void setup_apic_nmi_watchdog(void) return; } - lapic_nmi_owner = LAPIC_NMI_WATCHDOG; nmi_active = 1; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:45:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:45:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383389.1626660 (Exim 4.92) (envelope-from ) id 1wrazy-0004Q5-8K; Wed, 05 Aug 2026 12:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383389.1626660; Wed, 05 Aug 2026 12:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrazy-0004Py-5j; Wed, 05 Aug 2026 12:45:30 +0000 Received: by outflank-mailman (input) for mailman id 1383389; Wed, 05 Aug 2026 12:45:29 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrazx-0004Pk-CU for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:45:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrazw-007AOn-PI for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:45:28 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73305a-bab6-0a2a0a5309dd-0a2a4508d3fa-22 for ; Wed, 05 Aug 2026 14:45:28 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733068-f659-0a2a45080019-d155dd2aa57d-3 for ; Wed, 05 Aug 2026 14:45:28 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47de008b020so573330f8f.1 for ; Wed, 05 Aug 2026 05:45:28 -0700 (PDT) Received: from andrew-laptop.. ([157.231.70.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e533sm8779762f8f.28.2026.08.05.05.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 05:45:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785933928; x=1786538728; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qkOlx3mU5UhqIngqtbxU1MfSfxL2gIQyRof2hmDeYxw=; b=CWwbAXb961dFVc+q8Cjfpnmzg4H9KXGWmGd5IT3UL95w8OLN719HVBc+sdTC8Bwe4t nlIV3dbdCGsAQAvo8kD8JyeP3asFsGlj49/rS6vJnjIIbwpFPZmzIy6zXyTKthvxeh0/ j70YCHF1cdvQCfLDubDckbf8QIKbcTdknGPdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933928; x=1786538728; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qkOlx3mU5UhqIngqtbxU1MfSfxL2gIQyRof2hmDeYxw=; b=Sto+ZeFd9++sE6uASMPMMffTLiRhBkyz92gPQn0tCnT10+zM9xbJvq6C1QL0ZQXOhE cOdncjSHZ8afCm1JhbIsA208fawb/bHbe96HT39V4rjGotOZNrqXx4zMIKoN8pJ9c95Y fxjBZIsUa5sf+Wg/MBiJdtB9FjWp9DIhVkxyE8qN3b0Z0JDKVTF24iN41nqKuIZQqV7l 6NTzYpZUhS8pVN3I+RLoqfIz+VMcIoEgaEGPjl6XfG7XgvSCNJCzbU4neo3bGV8mUKSH y0OocBXQyNJLqrY+c0pADmSE3GmGnbm1tB9uleEyxGuOzRB9Hvatq6KPqg1w5HQ/gTfD TlnQ== X-Gm-Message-State: AOJu0YwGBDI7GihvxrAga2v3h311bFUuc064NeDV+kdj/MquXmUoTDT5 OhjWMx8zeS4P0kxUROvKTHH4El9gOjxPC5XuWTzvG1YVtIGLhij2ekGYhfXov9NgT+M826xNLx7 glyQo X-Gm-Gg: AR+sD13JaJvVugZiGAwpQa3zZch85z5FHOidHzXnJ9u4vzWMp4guc8giOtYNx5g7gVt gU5OfT/6g2/zFKiHz0YRP6YhDKJtWqkCTaPC8EUetQ9MJ84pNGCECxiO+1L7nHb4b1hCZeuEIxp rMB+0J9KV5JcIIHPB5abV51L9j4XrAIjrG+Ms+bdEFX4MybwfKBOhL7u0pgUebNaksjyubLfcfK cd/OKJ4h43Q1MPNxEPuil5vDQCAl6VLYTcG7bJLODV1OtbBiZ/zJ3+nJ+AIsGqrOPlIxiV/Bl1W pepiJiS2sqvjCBwSGJEFnclmQzOH4B0wC3Z5dYtYLD2H7OhxbxFmWDkZE3vSaD2IkSsp3gx9MYf a1JgA8yJNOiSGPWzqY26EMsRigfOXkvyUclRqE7QurETcFD7cX4qVVI1MxiI0i5wii0x2Pr1Jpb eicExxrHno8zVVeOSalKR+aBsC6W3D0vmQYZY8ooKq6FT1MmxwFQC+rsEkTvti7gvkz0YBn7UEj nCIUaPAw0U= X-Received: by 2002:a05:6000:2989:10b0:47f:7ea0:6c20 with SMTP id ffacd0b85a97d-47fec629365mr9292314f8f.15.1785933927607; Wed, 05 Aug 2026 05:45:27 -0700 (PDT) From: Andrew Cooper To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH 0/5] x86/nmi: Watchdog fixes/improvement Part 1 Date: Wed, 5 Aug 2026 13:45:20 +0100 Message-Id: <20260805124525.105457-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785933928-D6B4187B-A509A04A/0/0 X-purgate-type: clean X-purgate-size: 692 This is the start of a very long rabbit hole to address the mis-classification of some watchdog NMIs as non-watchdog NMIs. For now, just some simple and hopefully non-controvertial changes. https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/2733861049 Andrew Cooper (5): x86/nmi: Drop {reserve,release}_lapic_nmi() x86/nmi: Drop K7_NMI_EVENT x86/nmi: Misc style fixes x86/nmi: Check MSR_MISC_ENABLE for all Intel platforms x86/nmi: Don't configure EvtSel repeatedly xen/arch/x86/include/asm/apic.h | 2 - xen/arch/x86/nmi.c | 153 ++++++++++---------------------- 2 files changed, 47 insertions(+), 108 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:45:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383391.1626679 (Exim 4.92) (envelope-from ) id 1wrb00-0004qg-LR; Wed, 05 Aug 2026 12:45:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383391.1626679; Wed, 05 Aug 2026 12:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb00-0004qZ-Ig; Wed, 05 Aug 2026 12:45:32 +0000 Received: by outflank-mailman (input) for mailman id 1383391; Wed, 05 Aug 2026 12:45:31 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrazz-0004gP-5w for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:45:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrazy-007AOn-In for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:45:30 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73305a-bab6-0a2a0a5309dd-0a2a4508d3fa-28 for ; Wed, 05 Aug 2026 14:45:30 +0200 Received: from [209.85.221.50] (helo=mail-wr1-f50.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73306a-f659-0a2a45080019-d155dd32a5e5-3 for ; Wed, 05 Aug 2026 14:45:30 +0200 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47de008b020so573348f8f.1 for ; Wed, 05 Aug 2026 05:45:30 -0700 (PDT) Received: from andrew-laptop.. ([157.231.70.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e533sm8779762f8f.28.2026.08.05.05.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 05:45:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785933930; x=1786538730; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=v6YeRlTNauFBLjWJsxycUzL7eVgOm6WLxLhWDN+HbJU=; b=udEnqSmqzEKqr30c4WmlY74xN4zW4hVH132pJbsRK5cQxSgnZQ3id160fqebHx0u47 Q3aUIK2M/9K7BIAq0WaqexGzvJIndbZmgT4r950aqI6LPVXsjnQpBYv6gfmbR/WUuBoi U9wDyGy8aZwl0H5cHFYCFWkjHEGXGeGkRBAXw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933930; x=1786538730; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=v6YeRlTNauFBLjWJsxycUzL7eVgOm6WLxLhWDN+HbJU=; b=Y4LDSHYLhIxfj/E9MIV1aWqmKaMbL08f21Ay/TrYhC/cMVfYkxc0xMRqQn+k3t6vt2 5ounHtrVloUKoVIipdkpXwD52hbNYGu8XlKfjtaBZ4/rWNMAKpgwFmf6i8/6rQyXATxU fTuAD6BaI2SWLW5Ea6dXOhkIGqq2IqKDjImBPel3xzGvZJy8kFJd/IJ8od03rrdH3Tbq 5KXU5yRXnmo/xnww080+2OO2SCkKWy6fQWKIL/Ra4We52UcW/y55eaVIiSqO81NQmd5V LCWxnXxA6Zp7qaJQjMUdVU8QqNQkF6+OBTrwIDxMS/Lo8EcxynZyjqR//j9I+4J5pY62 3v9Q== X-Gm-Message-State: AOJu0YwU+WyBslh4iuS2yFY1uyk+EO4ujKVGFvEfuFMBFYHbbisAsdtt eeE4ytLnx/1C4RwODLahD1Pl4E9WADQrXYzYVR1eTkNX/c2tZxFiPuaz9dG2O/631HPAZMUzXia rg4NZ X-Gm-Gg: AR+sD10nAmiW4lY6lAbh5+HMlc3NmmardfZISMYoMAwSTx5K4XCw2QwGtkbdu07x5pO BvLawlNIt8sLBWc4iGsv2ErOhQ4bmScIp33gwS1pQtjbpaH8vFRgnlwS6VPJZ4k8HoxsPSA5j43 +8tGEyXDWlaIjnRRr8VP68a6PmJZOpGrAgW+BcgupnjehLH0tXdZx3aHxjyHiC5XdN/BdeIw4XY SAcCYYcZ9eXybsXhu6Dq4iHy8Jo9cLYWS90GR1GG+HiDyX6gLCj27/4bpgRztNEoPBBq5mtt1By 03NJ0B5nB0IKe/amiLZZDUmQ/IHxS3QuEhxtqUQ7Cletsqy7uLbc6/aLjlj9Jqpo1rPHekGT4CE QMd//Y5fJORqemRv2j6RKRwbj6eN3kScjOJqRKnYAsLV7v+vM5+fhHzJPRm+aHu1YfmmOqSQD9T 5vnU/trDav2pySsEBU76UfjCXvOAPgzRgf35rHEbx8DYLAMxp6IMsNUA211R7bLGIZ9DOedTeZ X-Received: by 2002:a05:6000:250b:b0:47f:7fe0:a287 with SMTP id ffacd0b85a97d-47fec4e739dmr11551387f8f.2.1785933929270; Wed, 05 Aug 2026 05:45:29 -0700 (PDT) From: Andrew Cooper To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH 2/5] x86/nmi: Drop K7_NMI_EVENT Date: Wed, 5 Aug 2026 13:45:22 +0100 Message-Id: <20260805124525.105457-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260805124525.105457-1-andrew.cooper3@citrix.com> References: <20260805124525.105457-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785933930-CC77387B-DFBF17D8/0/0 X-purgate-type: clean X-purgate-size: 1393 This name is misleading. It's not possible to configure NMI or not from the event select register; that comes from the APIC configuration for performance events. This name is "the thing we want to count for the NMI watchdog", but that's clearer to follow when it simply names the event. Drop the indirection. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie --- xen/arch/x86/nmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 616bfdbc9029..113e672c4f15 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -102,7 +102,6 @@ static int nmi_active; #define K7_EVNTSEL_OS (1 << 17) #define K7_EVNTSEL_USR (1 << 16) #define K7_EVENT_CYCLES_PROCESSOR_IS_RUNNING 0x76 -#define K7_NMI_EVENT K7_EVENT_CYCLES_PROCESSOR_IS_RUNNING #define K7_EVENT_WIDTH 32 #define P6_EVNTSEL0_ENABLE (1 << 22) @@ -259,7 +258,7 @@ static void setup_k7_watchdog(void) evntsel = K7_EVNTSEL_INT | K7_EVNTSEL_OS | K7_EVNTSEL_USR - | K7_NMI_EVENT; + | K7_EVENT_CYCLES_PROCESSOR_IS_RUNNING; wrmsrns(MSR_K7_EVNTSEL0, evntsel); write_watchdog_counter("K7_PERFCTR0"); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:45:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:45:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383392.1626684 (Exim 4.92) (envelope-from ) id 1wrb01-0004tX-0G; Wed, 05 Aug 2026 12:45:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383392.1626684; Wed, 05 Aug 2026 12:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb00-0004si-Pi; Wed, 05 Aug 2026 12:45:32 +0000 Received: by outflank-mailman (input) for mailman id 1383392; Wed, 05 Aug 2026 12:45:32 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrazz-0004pu-Sy for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:45:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrazz-004adb-9X for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:45:31 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73306b-2eae-0a2a0a5409dd-0a2a4509ba4e-0 for ; Wed, 05 Aug 2026 14:45:31 +0200 Received: from [209.85.221.52] (helo=mail-wr1-f52.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73306b-be1a-0a2a45090019-d155dd34c8a3-3 for ; Wed, 05 Aug 2026 14:45:31 +0200 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47f9ab7ee38so496183f8f.2 for ; Wed, 05 Aug 2026 05:45:31 -0700 (PDT) Received: from andrew-laptop.. ([157.231.70.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e533sm8779762f8f.28.2026.08.05.05.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 05:45:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785933931; x=1786538731; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lqsAtBET9oa8FmQopb1o6zNaXAFCZR7+pOGZSxtba0c=; b=IB3WkI6/nrEAOvOTS9+gWcGasd54tbrhgFLOVPT+klom1JpCm40QHP50iKno6uSAn3 9ms495ykJviGATEtbSp9l0gPF//jmm5h9Deby5Q6L0GFNIkt9c6h4zLMBbP1N7DZrRLq d9pTgzdE9AMaAdvXcyOoeQx/NcGv8u1NLaAb0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933931; x=1786538731; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lqsAtBET9oa8FmQopb1o6zNaXAFCZR7+pOGZSxtba0c=; b=p6MfRnZKcc2x0J3i1FK3TpfDOUeDqyjYTtCZft6WaFzRnh8KlRMbdQudJOvGZtCTed XABXAA3wTMR1X7plcrK0QL84+Ed0Qz9GEPoqRqPFnNfkoLuaCtCsYW+Oy9GvbbX+40SU O89QWmh8Qc3qOZg6bsP32OoP0PQjLYGLe3Ct0vX3u/Bk0JcS58GwVeebJjDnmgl+VqZp sq09+CARwCaqLyHTcDW7G8J3kaUWiCwgslNBPK4ahwd24c/CG17zep+10h2Tfg4+QkYR VVRrUStZT35PTaHP6CBI/31Ph9AlurChiITPnbijdoZVcP1I1i4/i0ZpEvDzt16k3Cn8 ZAog== X-Gm-Message-State: AOJu0YzCjspTZ5tgmIMd/qSpHh16ucGJ8DgJ1OWB7frFBkFvtwHOkGC/ rMVCQvEFffjwghKDFFfILsnDZy0TzIL8Y0aeMXCyKbw9W8PaGRQWQRppnny7w7yfIhy3KAcSnLe jaRXLIpw= X-Gm-Gg: AR+sD1016s42HIWxZ/Eo7AQb/amPaBK+I8ewFLn4ZkM11Qnr3ma1U+kvyfJvlyR8Bh0 x8OJtPIw9sYQOvpPDy2A0dcu42e/VtWcdEFLy7xRsnTDjX6E9B8PkMbRRn+09N0NdLqgnMWJ4BG dci7MNCdsMQmRzctj7B+Kuu+pipsPkbTGgXiz9Bfy6M6t9OYqVTVbWdFKLYjr9vCSv2XgzDYV25 MAaGrzmdnpMfLod6xdUe8aXxKdvG66rjFQwwDXrYVc9yeNGl/J8zsqDPpWxvoKVE73T888ZbvYQ Dlxe29f96ftaOM8CHjXCCiiPzPY9S72wkL7fRFVtRCtnNalxB3iOgVHiloot8L2feq7I+NDPOpc lmHDGD+73tjWO9NviZMEh6YOy5nHkcBNU/K8i5LMyjuqPYpHiJrBr84ahT3BHl3eNt4XoVNrN28 Gu37Cc4RqDkFtdAEZaU88DJD9gO7pYhdmW30UtTZQL9BlGoSVLCzrE4izQbMtRy1FnJteW2JkJ X-Received: by 2002:a05:6000:2489:b0:47f:6f9e:1e86 with SMTP id ffacd0b85a97d-47fec63481dmr10039143f8f.27.1785933930160; Wed, 05 Aug 2026 05:45:30 -0700 (PDT) From: Andrew Cooper To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH 3/5] x86/nmi: Misc style fixes Date: Wed, 5 Aug 2026 13:45:23 +0100 Message-Id: <20260805124525.105457-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260805124525.105457-1-andrew.cooper3@citrix.com> References: <20260805124525.105457-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785933931-BE4DB034-C4BD65E7/0/0 X-purgate-type: clean X-purgate-size: 5407 * Drop trailing whitespace * Sort includes, dropping asm/mc146818rtc.h and asm/div64.h as unused * Brace position, and types No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie --- xen/arch/x86/nmi.c | 54 ++++++++++++++++++++++++---------------------- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 113e672c4f15..d9d07870a333 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -13,26 +13,25 @@ * Mikael Pettersson : PM converted to driver model. Disable/enable API. */ +#include +#include +#include #include +#include +#include #include #include #include -#include -#include -#include #include -#include #include -#include +#include #include -#include + +#include #include -#include -#include #include +#include #include -#include -#include unsigned int nmi_watchdog = NMI_NONE; static unsigned int nmi_hz = HZ; @@ -124,10 +123,10 @@ static int nmi_active; #define P4_CCCR_REQUIRED (3<<16) #define P4_CCCR_ESCR_SELECT(N) ((N)<<13) #define P4_CCCR_ENABLE (1<<12) -/* +/* * Set up IQ_PERFCTR0 to behave like a clock, by having IQ_CCCR0 filter * CRU_ESCR0 (with any non-null event selector) through a complemented - * max threshold. [IA32-Vol3, Section 14.9.9] + * max threshold. [IA32-Vol3, Section 14.9.9] */ #define P4_NMI_CRU_ESCR0 P4_ESCR_EVENT_SELECT(0x3F) #define P4_NMI_IQ_CCCR0 \ @@ -182,7 +181,7 @@ void __init check_nmi_watchdog(void) * There's a limit to how slow we can go because writing the perfctr * MSRs only sets the low 32 bits, with the top 8 bits sign-extended * from those, so it's not possible to set up a delay larger than - * 2^31 cycles and smaller than (2^40 - 2^31) cycles. + * 2^31 cycles and smaller than (2^40 - 2^31) cycles. * (Intel SDM, section 18.22.2) */ if ( nmi_watchdog == NMI_LOCAL_APIC ) @@ -199,8 +198,9 @@ static void cf_check nmi_timer_fn(void *unused) void disable_lapic_nmi_watchdog(void) { - if (nmi_active <= 0) + if ( nmi_active <= 0 ) return; + switch ( boot_cpu_data.vendor ) { case X86_VENDOR_AMD: @@ -231,9 +231,7 @@ void disable_lapic_nmi_watchdog(void) static void clear_msr_range(unsigned int base, unsigned int n) { - unsigned int i; - - for (i = 0; i < n; i++) + for ( unsigned int i = 0; i < n; i++ ) wrmsrns(base + i, 0); } @@ -302,7 +300,7 @@ static void setup_p4_watchdog(void) uint64_t misc_enable; rdmsrl(MSR_IA32_MISC_ENABLE, misc_enable); - if (!(misc_enable & MSR_IA32_MISC_ENABLE_PERF_AVAIL)) + if ( !(misc_enable & MSR_IA32_MISC_ENABLE_PERF_AVAIL) ) return; nmi_perfctr_msr = MSR_P4_IQ_PERFCTR0; @@ -310,15 +308,18 @@ static void setup_p4_watchdog(void) if ( boot_cpu_data.x86_num_siblings == 2 ) nmi_p4_cccr_val |= P4_CCCR_OVF_PMI1; - if (!(misc_enable & MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL)) + if ( !(misc_enable & MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL) ) clear_msr_range(0x3F1, 2); /* MSR 0x3F0 seems to have a default value of 0xFC00, but current docs doesn't fully define it, so leave it alone for now. */ - if (boot_cpu_data.model >= 0x3) { + if ( boot_cpu_data.model >= 0x3 ) + { /* MSR_P4_IQ_ESCR0/1 (0x3ba/0x3bb) removed */ clear_msr_range(0x3A0, 26); clear_msr_range(0x3BC, 3); - } else { + } + else + { clear_msr_range(0x3A0, 31); } clear_msr_range(0x3C0, 6); @@ -393,7 +394,7 @@ static int cf_check cpu_nmi_callback( } static struct notifier_block cpu_nmi_nfb = { - .notifier_call = cpu_nmi_callback + .notifier_call = cpu_nmi_callback, }; static DEFINE_PER_CPU(unsigned int, last_irq_sums); @@ -444,15 +445,15 @@ bool nmi_watchdog_tick(const struct cpu_user_regs *regs) * before doing the oops ... */ this_cpu(alert_counter)++; - if ( this_cpu(alert_counter) == opt_watchdog_timeout*nmi_hz ) + if ( this_cpu(alert_counter) == opt_watchdog_timeout * nmi_hz ) { console_force_unlock(); printk("Watchdog timer detects that CPU%d is stuck!\n", smp_processor_id()); fatal_trap(regs, 1); } - } - else + } + else { this_cpu(last_irq_sums) = sum; this_cpu(alert_counter) = 0; @@ -512,7 +513,8 @@ bool nmi_watchdog_tick(const struct cpu_user_regs *regs) void self_nmi(void) { unsigned long flags; - u32 id = get_apic_id(); + uint32_t id = get_apic_id(); + local_irq_save(flags); apic_wait_icr_idle(); apic_icr_write(APIC_DM_NMI | APIC_DEST_PHYSICAL, id); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:45:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383393.1626696 (Exim 4.92) (envelope-from ) id 1wrb03-0005KG-BQ; Wed, 05 Aug 2026 12:45:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383393.1626696; Wed, 05 Aug 2026 12:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb03-0005K9-8h; Wed, 05 Aug 2026 12:45:35 +0000 Received: by outflank-mailman (input) for mailman id 1383393; Wed, 05 Aug 2026 12:45:33 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb01-0004qQ-A6 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:45:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrb00-009h29-1B for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:45:32 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733064-e002-0a2a0a5209dd-0a2a45029942-18 for ; Wed, 05 Aug 2026 14:45:31 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73306b-6ca4-0a2a45020019-d155dd2cbcf9-3 for ; Wed, 05 Aug 2026 14:45:31 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f96c5b722so540548f8f.0 for ; Wed, 05 Aug 2026 05:45:31 -0700 (PDT) Received: from andrew-laptop.. ([157.231.70.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e533sm8779762f8f.28.2026.08.05.05.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 05:45:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785933931; x=1786538731; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gfNjW9ZQ4iFlwv+IcWbWGLC4if7o3p4HypcYr/O3FIo=; b=j4nb/rXoyPeZIvZcycFCLsHvSo8ggmdJdpITXFhun2a5v9dRXpGQL2A2NxMpt/Qn9W N9DLKzOUBQGYqdEE0d/RBGvr+IdX5cRyX4JwviLRX//uP6X2mAImuJL4uEdM9DacYhmx XGI/pVoUGgaquKL0xrLMyEb+v9fwwHbBDiNVg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933931; x=1786538731; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gfNjW9ZQ4iFlwv+IcWbWGLC4if7o3p4HypcYr/O3FIo=; b=KAoo6+Itq4TOJ3gJ1u/KPPUvk3VoVb0WIEwo26IBBbdVMjxYynCETrq355IcRPAv92 m90Q2eoyN8ocmGP7B5dN9LDnxrmiLmnE23SpRS861PxVpEhIxeK16eYOr8xY4BbLcHCK JyoUPu0I6R7hvgn1h+JmVMp/5I+RSVloiPb4r0w4JwZy/z8SR7MP8lnD38XJ+Lnupjvh jllPq5dlqa5NVSFuZuLe02EN6og76q0WfxdLxbArI3dxF8YWU0hTotsjIeJjIKhlNfoY ahI2ZIB2undMe6id1YknLLYL5aoa8xvbf+ioE2Vxcz16itmxUUtkxwEBoS7Ma/iogEZy CrGw== X-Gm-Message-State: AOJu0YzxChSpPl1v8167gI4X0BFzEttrU8RrgizWsRzoOwKksnCOTrFh GjpEwHQYB1dc3kszCEww7HYLOsVhgDnqHvTemu3x2mde9pDrJ8XEtMp6Jaz8sFdHXa0xk+F7x5p rpJ8ceRk= X-Gm-Gg: AR+sD11RTdq1lVtRH1x9Xv3nE+TKTYDE2TMO+qn8fN8Suu0x6FMo9e6FrS2cXxcyV3E IZn3Oo9t2vqsRaOF9w+sXJKW43ahJG4vEErGwhvPdy4Sdinp0JqRr3R5FZtB3DJ78PyStXUbXyz FcWZeRNr86g37stLirw5D5nU6IheuOX06SBgi32cv1rLp5+rF/4PsIzVvNuc82Zuh+0F28J2SBf ESyBeXHbVrN2Jr9TtiFcf1IyCICI21XApbZX9gkRzXzyw1N9kltRZwATr05qL67HleERFyGQwaB qX/K01OdPLBODhN9VnhFAcHTpSpwWD+WPBA+Kn/zcDKoDjmMLV9I5gYaRyFRgRDt8bd2AscoscW eChd1+tBDQG9tvUXKlq5xuJMV272afE3UcZ4BlAt6f4TlArRJ1ULKmI96oJkLbBKkfq8eGEXSKD b51I31Tfn2PRc5Wubai2vNgKBTUR+l09RBNcXEfNZonzq0JPu1LeaxligIaDXg8MORwNZnsxLD X-Received: by 2002:adf:f311:0:b0:46e:7f72:b6fe with SMTP id ffacd0b85a97d-47fec523d07mr8462161f8f.19.1785933931038; Wed, 05 Aug 2026 05:45:31 -0700 (PDT) From: Andrew Cooper To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH 4/5] x86/nmi: Check MSR_MISC_ENABLE for all Intel platforms Date: Wed, 5 Aug 2026 13:45:24 +0100 Message-Id: <20260805124525.105457-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260805124525.105457-1-andrew.cooper3@citrix.com> References: <20260805124525.105457-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1785933931-F1EAB2AC-CB6B44DA/0/0 X-purgate-type: clean X-purgate-size: 2470 Right now it's only checked in setup_p4_watchdog(), and not in setup_p6_watchdog(). Perform the check in the common Intel path in setup_apic_nmi_watchdog(), and pass misc_enable as a parameter into setup_p4_watchdog() to aoid reading it twice. Fixes: 0dfba864fbff ("NMI watchdog support in Xen.") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie I presume this bug went unnoticed because watchdog is off-by-default. --- xen/arch/x86/nmi.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index d9d07870a333..a8b0d79c7cf2 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -295,14 +295,8 @@ static void setup_p6_watchdog(unsigned counter) wrmsrns(MSR_P6_EVNTSEL(0), evntsel); } -static void setup_p4_watchdog(void) +static void setup_p4_watchdog(uint64_t misc_enable) { - uint64_t misc_enable; - - rdmsrl(MSR_IA32_MISC_ENABLE, misc_enable); - if ( !(misc_enable & MSR_IA32_MISC_ENABLE_PERF_AVAIL) ) - return; - nmi_perfctr_msr = MSR_P4_IQ_PERFCTR0; nmi_p4_cccr_val = P4_NMI_IQ_CCCR0; if ( boot_cpu_data.x86_num_siblings == 2 ) @@ -337,6 +331,8 @@ static void setup_p4_watchdog(void) void setup_apic_nmi_watchdog(void) { + uint64_t misc; + if ( nmi_watchdog == NMI_NONE ) return; @@ -347,6 +343,14 @@ void setup_apic_nmi_watchdog(void) break; case X86_VENDOR_INTEL: + misc = rdmsr(MSR_IA32_MISC_ENABLE); + + if ( !(misc & MSR_IA32_MISC_ENABLE_PERF_AVAIL) ) + { + printk(XENLOG_WARNING "Intel Perfmon unavailable\n"); + goto disable; + } + switch ( boot_cpu_data.family ) { case 6: @@ -355,7 +359,7 @@ void setup_apic_nmi_watchdog(void) : CORE_EVENT_CPU_CLOCKS_NOT_HALTED); break; case 15: - setup_p4_watchdog(); + setup_p4_watchdog(misc); break; } break; @@ -363,6 +367,7 @@ void setup_apic_nmi_watchdog(void) if ( nmi_perfctr_msr == 0 ) { + disable: printk(XENLOG_WARNING "Failed to configure NMI watchdog\n"); nmi_watchdog = NMI_NONE; return; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:45:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383394.1626703 (Exim 4.92) (envelope-from ) id 1wrb03-0005NH-PI; Wed, 05 Aug 2026 12:45:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383394.1626703; Wed, 05 Aug 2026 12:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb03-0005M5-GC; Wed, 05 Aug 2026 12:45:35 +0000 Received: by outflank-mailman (input) for mailman id 1383394; Wed, 05 Aug 2026 12:45:33 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb01-00059f-TT for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:45:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrb01-009h29-A2 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:45:33 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733064-e002-0a2a0a5209dd-0a2a45029942-28 for ; Wed, 05 Aug 2026 14:45:33 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73306d-6ca4-0a2a45020019-d155dd2addd7-3 for ; Wed, 05 Aug 2026 14:45:33 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f7854678cso591338f8f.1 for ; Wed, 05 Aug 2026 05:45:33 -0700 (PDT) Received: from andrew-laptop.. ([157.231.70.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e533sm8779762f8f.28.2026.08.05.05.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 05:45:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1785933933; x=1786538733; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7770vZRJ4ZFGBtmI51IRg/58qd/H6KqbB1Rxt63P7kE=; b=s304l9ZBXdbG+N90oKjzRFvQmwbyWj3DNzRlz0DMfQbu+SGg5uNeROz1Di0mbsY17P vzz95s/g3mC+b3eZBevM6NbnAueDYHVD5vbpn3vpL604j6HPOUEkKcnLpDCFG3axPKX0 csPDP/lj3vVfRWdOjn/OCrnA/+e73FIOvxqx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785933933; x=1786538733; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7770vZRJ4ZFGBtmI51IRg/58qd/H6KqbB1Rxt63P7kE=; b=a7imZzMVvmwPOexWyxoOz0rHNwS9BLKu+veWRkWG7G1eARk7SU//48VTHsYwKbHH+A 6V2mHK/2oqR+jdoF4iWylfT8hv5Edg7Jpwby73eQkiONGtAImG/LDpvW9F3hH4lkTiJ8 xpaIqs86XASxUh6SSO92QVxi9lHtH6xEbt5r/t7i5JcRIeo3TwyzhUPr66DzjpvqTBIE 6BNoScfRnOcUA5cV2dc1u/1YUJJMnKh2hcip8vAXOdh/sVnxiEtS0o38FVucuk0tz2Zs wv3ef8byUYeX5oUWaxgJj/+floIaj7TSOcijjwDScjLoE5KK5Hv4LoNrSlxyOo+3jjGF AU1g== X-Gm-Message-State: AOJu0Yw3Ijxhg/Lzd+iWM9d+nAvYfjS4Hvk7lZEjq92VlGxyfC5VVEc3 fLrqO5OqB8na8Rbq6FpJ9dD6fhBpRSOCdB1i4s7A+PEC0Jzh16Bex4hVLqeXQFwFq4Ohq+ZxyON AzyP8 X-Gm-Gg: AR+sD12+Wl6Yke9FX6SLwmYr8qt7TjYkamDLyS5rbrZS6SEksDSHIfFFB3Xw/cuHAVG ZNepcxHS2p2q11MoNs3Gsrrl97Kpo9xMnZ+jLwdscRLd4MQIHpa9yxI5JHl+LGHW38uuqWiUvm2 PN801DMn40+kUuI1e40W3RuVPM5qr9q+Nas6zN0jsH/Bc3MWLNbvlpTCI54BgC4shRx1puLlJWP ueaKfmYZuVmixwg/jnLFXzrE55mqPTryWoqNKU4RmhjML5JYpvkbEyLhJbntAmHiIcHC5ou5cCB wNCPTxl3xlsBRKPHgHju7JMywDdFGOOAHRAzrkXWW8vVByRUXm8mbB5VmPSznBvSBEzoqLQGF7d m5pZwvD8sm2uSX0DanNh5HlhBL2vpjQbsHjEFJ92af7qYAjXPap7IGOwEx8zOnfx+EhG1YZ+qlW wbqf/QIJzSZT5zbslif80pjdfbP7WcKHeif9lg+t4nPRCLthTg5oW8j0g7T5Azr9QEt6K6Twr2 X-Received: by 2002:a05:6000:25ca:b0:47f:9568:ebf0 with SMTP id ffacd0b85a97d-47fec52786bmr10833838f8f.23.1785933932021; Wed, 05 Aug 2026 05:45:32 -0700 (PDT) From: Andrew Cooper To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH 5/5] x86/nmi: Don't configure EvtSel repeatedly Date: Wed, 5 Aug 2026 13:45:25 +0100 Message-Id: <20260805124525.105457-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260805124525.105457-1-andrew.cooper3@citrix.com> References: <20260805124525.105457-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1785933933-F38BC2AC-84BF9D56/0/0 X-purgate-type: clean X-purgate-size: 3266 In both setup_{k7,p6}_watchdog(), EvtSel0 is first zeroed, then written with everything but the enable bit, then written with the enable bit. setup_p4_watchdog() is slightly more complicated, owing to what appears to be a bug introduced by commit 2a2bd8de16b6 ("Clean up NMI watchdog handler."), which causes a second bit to be temporarily different too. The middle of the three writes is useless in all cases. Drop it. While doing this, rename the 'counter' parameter for setup_p6_watchdog(). It is the event which is passed in; the counter is always counter 0. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie --- xen/arch/x86/nmi.c | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index a8b0d79c7cf2..a697486b834d 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -246,29 +246,20 @@ static inline void write_watchdog_counter(const char *descr) static void setup_k7_watchdog(void) { - unsigned int evntsel; - nmi_perfctr_msr = MSR_K7_PERFCTR0; clear_msr_range(MSR_K7_EVNTSEL0, 4); clear_msr_range(MSR_K7_PERFCTR0, 4); - evntsel = K7_EVNTSEL_INT - | K7_EVNTSEL_OS - | K7_EVNTSEL_USR - | K7_EVENT_CYCLES_PROCESSOR_IS_RUNNING; - - wrmsrns(MSR_K7_EVNTSEL0, evntsel); write_watchdog_counter("K7_PERFCTR0"); apic_write(APIC_LVTPC, APIC_DM_NMI); - evntsel |= K7_EVNTSEL_ENABLE; - wrmsrns(MSR_K7_EVNTSEL0, evntsel); + wrmsrns(MSR_K7_EVNTSEL0, + K7_EVNTSEL_ENABLE | K7_EVNTSEL_INT | K7_EVNTSEL_OS | + K7_EVNTSEL_USR | K7_EVENT_CYCLES_PROCESSOR_IS_RUNNING); } -static void setup_p6_watchdog(unsigned counter) +static void setup_p6_watchdog(unsigned int event) { - unsigned int evntsel; - if ( !nmi_p6_event_width && current_cpu_data.cpuid_level >= 0xa ) nmi_p6_event_width = MASK_EXTR(cpuid_eax(0xa), P6_EVENT_WIDTH_MASK); if ( !nmi_p6_event_width ) @@ -283,16 +274,11 @@ static void setup_p6_watchdog(unsigned counter) clear_msr_range(MSR_P6_EVNTSEL(0), 2); clear_msr_range(MSR_P6_PERFCTR(0), 2); - evntsel = P6_EVNTSEL_INT - | P6_EVNTSEL_OS - | P6_EVNTSEL_USR - | counter; - - wrmsrns(MSR_P6_EVNTSEL(0), evntsel); write_watchdog_counter("P6_PERFCTR0"); apic_write(APIC_LVTPC, APIC_DM_NMI); - evntsel |= P6_EVNTSEL0_ENABLE; - wrmsrns(MSR_P6_EVNTSEL(0), evntsel); + wrmsrns(MSR_P6_EVNTSEL(0), + P6_EVNTSEL0_ENABLE | P6_EVNTSEL_INT | P6_EVNTSEL_OS | + P6_EVNTSEL_USR | event); } static void setup_p4_watchdog(uint64_t misc_enable) @@ -323,7 +309,6 @@ static void setup_p4_watchdog(uint64_t misc_enable) clear_msr_range(MSR_P4_BPU_PERFCTR0, 18); wrmsrl(MSR_P4_CRU_ESCR0, P4_NMI_CRU_ESCR0); - wrmsrl(MSR_P4_IQ_CCCR0, P4_NMI_IQ_CCCR0 & ~P4_CCCR_ENABLE); write_watchdog_counter("P4_IQ_COUNTER0"); apic_write(APIC_LVTPC, APIC_DM_NMI); wrmsrl(MSR_P4_IQ_CCCR0, nmi_p4_cccr_val); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:48:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:48:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383433.1626716 (Exim 4.92) (envelope-from ) id 1wrb2q-0007ix-4G; Wed, 05 Aug 2026 12:48:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383433.1626716; Wed, 05 Aug 2026 12:48:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb2p-0007iq-Vs; Wed, 05 Aug 2026 12:48:27 +0000 Received: by outflank-mailman (input) for mailman id 1383433; Wed, 05 Aug 2026 12:48:26 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrb2o-0007ik-JB for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:48:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrb2n-009hgA-RT for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:48:25 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733103-5cb7-0a2a0a5109dd-0a2a450ba28a-38 for ; Wed, 05 Aug 2026 14:48:25 +0200 Received: from [209.85.221.54] (helo=mail-wr1-f54.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733119-b7e8-0a2a450b0019-d155dd36d961-3 for ; Wed, 05 Aug 2026 14:48:25 +0200 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47f71156e1aso448147f8f.3 for ; Wed, 05 Aug 2026 05:48:25 -0700 (PDT) Received: from [192.168.1.109] ([88.241.184.235]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e533sm8799726f8f.28.2026.08.05.05.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 05:48:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785934105; x=1786538905; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4Fg5Jlc1jxaGcQAj3FbA1in17FLwTIaps3QCwd1CSKs=; b=CQLLvx4cRrVSugBPl3P9oSqPMh2sRVdebg6I7FuBJw9LP/NkuArW6wBqb2ziwYYtZD fuXsexzQMy7h9EnTHDmUtFf8jNpkbkMjKxnm8qfisWpcm9RmfMP+eIRigNi/5lCZTkhY QPRY3ZpVd5YaNLo09wpuufW6DCX5AR+G/pYgs/sIoQT90ZXAAnd6/QxLedcAYDAlRAcl yXc+75l86lEJ6cIwRH6/yqUKs5yAWU3krjgxzEl3xw/Gimil4Jc017FVhScV3zOZOQ4L QYS3gO3oblh+3VK5Qh+VbZxaU5v92ZGMn5sASMgrC3kbFLcDU3KmUWJpuGr0GVRGgBVT x0aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785934105; x=1786538905; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4Fg5Jlc1jxaGcQAj3FbA1in17FLwTIaps3QCwd1CSKs=; b=LnsRFjLDYz6tvk5Y5PQTZW0qpH0A3DdJl8u5KNoVwVGKh8YoO2hUoJipH+TDWmIeKo mrhEDRJvUZLlYSvsfNni6zJV1ZyzD3oCx0kWq9VmWK/EQ6GYnCoKBWGdqvAjM8c+a5PZ TLcTWxOuN5GgmiNMPnoNd1dJ2VRNljVBdf4Dvf5J37Nm7RgagRVnqmAEzheMKi9lduTk VCfWX6aqtGu72Xd4bkxM6a6d1nuq8Av1z4cHhCk+C9CYX4ZjsA5BPWTV08noABi1i1JE AOrgcOW8XT0kzofok3o/eLYkelq1mKo3e3kFk6dMqFZFImHB7mNZG4TioM19ZJv9tB6L nHrw== X-Forwarded-Encrypted: i=1; AHgh+RrQb/B9zTywgz+CkwwEtxrpygjGz5Cclhh8YcxOmMVWvszYMKO8o60eleg9tf7EsaOapW2bULzyI6s=@lists.xenproject.org X-Gm-Message-State: AOJu0YzWYuOo4NW0cgM9T2KROYWWMQzs1NLCLPl3ysi12/5GH1BUqdH6 YytNqHFXIyBftXRX6tAyYO280liRmcGtyoxhdfdlMNsy0z8pRGgTVHHE X-Gm-Gg: AR+sD12pTjDJhrznwhZ0sdvk85L1zuEy27C4z82YDCWUuj/LuRPVYurqrI0WeW+JVyE fjXMDaupylh2EEN/jTwUNOYwh2PHbhSKKshhD4yyTQvBzRPeokLdRrt3KqiVO+Ybj4K6XEML8RB O1qWX4BYfdmDbS98j/Bu+mmLyYLAAk8AE+tjIB8CnTW4Sc5FjM0R4+gl9jRqDjBnwnabqYzi/Sv ucwhA3+qcUG4pkh27JgkyZrX+vm23Bgi1rYQTSy0+N0qSSxxkXnZ/I0yDnhkB9aseRvdQ1GnoVU OSwVQNsXKhrTsV6/zANaTpzhHP+5dTpCsWZ7ioVudoim8e+23DteQXJDhhYnwjfMO4UMp961QEa p217JFxQbIWL83Oi7yH4m1sZpGLVdSNQ+O4frzIgOM2t9F8J4hdy3Du1yUb7kXkaysKuxFCQih4 VdEyaJB0A9XG+q9e/99geXPAycOpNF/k2EhByU9ADeEXDP8GgvzP8LTbEX5Sl0bNIfI61O X-Received: by 2002:a05:6000:41f7:b0:47f:4ac9:98bc with SMTP id ffacd0b85a97d-47fec63f8dbmr11018768f8f.24.1785934105000; Wed, 05 Aug 2026 05:48:25 -0700 (PDT) Message-ID: <3de6fbd2-0e2c-46ac-b858-d3987833d796@gmail.com> Date: Wed, 5 Aug 2026 15:48:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] xen/sched: rename scheduler registration symbols To: Jan Beulich Cc: andrew.cooper3@citrix.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, xen-devel@lists.xenproject.org References: <20260804055327.22119-1-frn1furkan10@gmail.com> <20260804055327.22119-3-frn1furkan10@gmail.com> <14dd261f-8d78-4c24-b927-f7f2c01dbdf8@suse.com> Content-Language: en-US From: =?UTF-8?B?RnVya2FuIMOHYWzEscWfa2Fu?= In-Reply-To: <14dd261f-8d78-4c24-b927-f7f2c01dbdf8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1785934105-192CC9EA-EC8BA660/0/0 X-purgate-type: clean X-purgate-size: 2059 Hi Jan, On 8/5/26 14:43, Jan Beulich wrote: > On 04.08.2026 07:53, Furkan Caliskan wrote: >> REGISTER_SCHEDULER(), schedulers[], NUM_SCHEDULERS, and the >> per-arch SCHEDULER_ARRAY linker macro now register and hold >> struct sched_ops instances rather than struct scheduler ones, >> but still carry names describing the old type. >> >> Rename them to match the current behaviour. >> No functional change. >> >> Signed-off-by: Furkan Caliskan >> --- >> xen/arch/arm/xen.lds.S | 2 +- >> xen/arch/ppc/xen.lds.S | 2 +- >> xen/arch/riscv/xen.lds.S | 2 +- >> xen/arch/x86/xen.lds.S | 2 +- >> xen/common/sched/arinc653.c | 2 +- >> xen/common/sched/core.c | 33 +++++++++++++++++---------------- >> xen/common/sched/credit.c | 2 +- >> xen/common/sched/credit2.c | 2 +- >> xen/common/sched/null.c | 2 +- >> xen/common/sched/private.h | 4 ++-- >> xen/common/sched/rt.c | 2 +- >> xen/include/xen/xen.lds.h | 10 +++++----- >> 12 files changed, 33 insertions(+), 32 deletions(-) > > I'm not quite sure if all of this is really useful. In many (all?) places > I think "scheduler" as a term is still quite applicable. > > One (general) nit though: if already you touch malformed lines (overlong > ones is which prompted this comment), please adjust them to be style- > conformant. > > Jan The main reason I renamed those symbols was type consistency - since 'struct scheduler' is now just the runtime per-cpupool object, keeping 'schedulers[]' and 'REGISTER_SCHEDULER()' around to hold 'struct sched_ops' pointers felt like it might confuse someone reading the code later. That said, I get your point. At a higher level, those macros and linker arrays are still just registering scheduler implementations, so keeping the names is okay too. If the maintainers prefer keeping the existing naming, patch 1 can simply be taken on its own without the second patch. Juergen, what do you think here? Thanks, Furkan Caliskan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 12:57:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 12:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383450.1626724 (Exim 4.92) (envelope-from ) id 1wrbBN-000115-0u; Wed, 05 Aug 2026 12:57:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383450.1626724; Wed, 05 Aug 2026 12:57:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbBM-00010y-TI; Wed, 05 Aug 2026 12:57:16 +0000 Received: by outflank-mailman (input) for mailman id 1383450; Wed, 05 Aug 2026 12:57:15 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbBL-00010s-DT for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 12:57:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrbBK-004dNI-Gr for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:14 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733324-e002-0a2a0a5209dd-0a2a450bd186-28 for ; Wed, 05 Aug 2026 14:57:11 +0200 Received: from [209.85.208.54] (helo=mail-ed1-f54.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733327-b7e8-0a2a450b0019-d155d036a42d-3 for ; Wed, 05 Aug 2026 14:57:11 +0200 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6a0a0466d12so2137761a12.0 for ; Wed, 05 Aug 2026 05:57:11 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a18b26b488sm264446a12.25.2026.08.05.05.57.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 05:57:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785934631; x=1786539431; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Uez3Y760HCQxEKEaZ9zt8WAYJlzXp3nbhVm+nYgHW9Y=; b=f4CU36V84buenv3rSqOhO31cqUt5mK1lh4wDDwgZOMuruFN9o1FfIgwQdxhEL4MNM2 9zKfVfKDFscBiJuV3eYzcAtaamM9iKMPLoUk16BhWCGO2FWFt7RlQ+dK4szkE4FoYtIQ zJVKjlEzhl44VUmfJW06AYNREl2/ChSc0kyebMQ0qdOxgHORcyBvtlUzGI7tDIBTdaxn LBeBii387W2TMsvjjasyYek5i/V+qYq0I8InyZKlbepUmE5FZfKcfhoSkRzCll0+woNV fqkdiPAV2vBk9xv4VsZwqox0iKqPAhs/QbYYKPJKK3svg1xvE11+x9r+QlWC+pxowsMl q4Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785934631; x=1786539431; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Uez3Y760HCQxEKEaZ9zt8WAYJlzXp3nbhVm+nYgHW9Y=; b=WQ44CjiONgieh6gDcLLu6lw3+yLcrK3Cpyfk7qyaIbgLlufj2YYnr9+1RioMoUr+fi RBi2xzCy+uYBk733sPfOTtKfMC8W/tosMD5pxJWIZC1Tphed8zojcuKZq3+z35pS47tq 4A9z5qzkShyVhQvbOTnktcFxq8nF5P/OK7MD7AzidQqA0mzU1VzI6YH4nVoIqc7nNe8d PAjJkoicyuf0e4o1BxUOJPwZg8YQpLWr1ZUdxGFO7LQN30WVoa7ZTaJecNl7Lxmrzh/1 q6y1LKRVlpSUyhL33mnj2Pk1eHSMVzJhu16cgsTJZ3nV3KvwatC/aWhbh9jQvcqTFdaf fZkA== X-Forwarded-Encrypted: i=1; AHgh+Ro90WSjoP34W4JmfVIPJL3ozU7W2ug9OPRvkaGmDhsQ0PUiSNs2VHf31cocXd7g4hPPbbaoC2cbnVQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YxFKxqShXUojhhpdcVVlN26SZrWdgJCqXFKehmIHbFhzUr49wbU uu3amZFvIy76CufxsJ6Ph6AngG7KDCj34wSQ94Q4fKQ6p0OWdcFy9nc9Jtj7akMqwdM= X-Gm-Gg: AR+sD10PhEwVEuufcys2MFEmecOgKgcrYndaY4W+AP835N30x0Hdfrq+5PWy5O6I0NF yJNegnle3Wo+UmMjbDsGriJ70gFHcTvaf1wXsfYTzTmHfKDoQMfU8v8Vp9Sf3yL5DOmOhxs3SMP R8scGm211kZLKT4bhkXJperXG600ipgQnjwEH/TGvH3Uah1sBs0BsCyT1VfoEJJ4Bs5BhGFBPhJ iXMZ1czV8kdSaDPcrfYl0cRSvh2qBwQs8tVkLm9I6XnByYSG23YhzttEpuEllt8OF2hywbonSVC n8yvKs/ZMjrgQtH2EXonWosJTlfeUfNpHjHH2ejbXd6zPZsJi7OVYJMJDpSGiwN0TuMbRwRjjpX NAmbkTzrsGE8iQ802JT9ATrX1XjKJeM10CZvTy9JG9TFGaKuE+0LaYGSgvDXT5ZJRZrCHrUQccy 1GUPd17asKm8KW5X+9nUfKqgqGYpw/u7PZZlM1f2MEnNitPUuSy2mN6LEneoOx9AHgBvucmnlnO yaK0EaORX8/Ov/13ALFzQPJN/s7j4rUJ7yo6GJ6r83hGT5QfBpGyHCSmZSvwZ9y9ojmMEOtMMwE ABlwi2uCk/Y6tSI= X-Received: by 2002:a05:6402:52cd:b0:697:8b0c:36e1 with SMTP id 4fb4d7f45d1cf-6a14ef2123bmr3632287a12.4.1785934630814; Wed, 05 Aug 2026 05:57:10 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 14:57:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] xen/sched: rename scheduler registration symbols To: =?UTF-8?B?RnVya2FuIMOHYWzEscWfa2Fu?= , Jan Beulich Cc: andrew.cooper3@citrix.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, xen-devel@lists.xenproject.org References: <20260804055327.22119-1-frn1furkan10@gmail.com> <20260804055327.22119-3-frn1furkan10@gmail.com> <14dd261f-8d78-4c24-b927-f7f2c01dbdf8@suse.com> <3de6fbd2-0e2c-46ac-b858-d3987833d796@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <3de6fbd2-0e2c-46ac-b858-d3987833d796@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8VDZGiCxvC0PohVfEt0ee0cV" X-purgate-ID: tlsNG-42698a/1785934631-A88C99EA-BCD349D8/0/0 X-purgate-type: clean X-purgate-size: 11470 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8VDZGiCxvC0PohVfEt0ee0cV Content-Type: multipart/mixed; boundary="------------Dt5H7KYGzgPxZyK0fqoYT3T4"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: =?UTF-8?B?RnVya2FuIMOHYWzEscWfa2Fu?= , Jan Beulich Cc: andrew.cooper3@citrix.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com, xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH v2 2/2] xen/sched: rename scheduler registration symbols References: <20260804055327.22119-1-frn1furkan10@gmail.com> <20260804055327.22119-3-frn1furkan10@gmail.com> <14dd261f-8d78-4c24-b927-f7f2c01dbdf8@suse.com> <3de6fbd2-0e2c-46ac-b858-d3987833d796@gmail.com> In-Reply-To: <3de6fbd2-0e2c-46ac-b858-d3987833d796@gmail.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------Dt5H7KYGzgPxZyK0fqoYT3T4 Content-Type: multipart/mixed; boundary="------------IRlJKDHBgdj9ad1hPAxHm6Jb" --------------IRlJKDHBgdj9ad1hPAxHm6Jb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTQ6NDgsIEZ1cmthbiDDh2FsxLHFn2thbiB3cm90ZToNCj4gSGkgSmFu LA0KPiANCj4gT24gOC81LzI2IDE0OjQzLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDA0 LjA4LjIwMjYgMDc6NTMsIEZ1cmthbiBDYWxpc2thbiB3cm90ZToNCj4+PiBSRUdJU1RFUl9T Q0hFRFVMRVIoKSwgc2NoZWR1bGVyc1tdLCBOVU1fU0NIRURVTEVSUywgYW5kIHRoZQ0KPj4+ IHBlci1hcmNoIFNDSEVEVUxFUl9BUlJBWSBsaW5rZXIgbWFjcm8gbm93IHJlZ2lzdGVyIGFu ZCBob2xkDQo+Pj4gc3RydWN0IHNjaGVkX29wcyBpbnN0YW5jZXMgcmF0aGVyIHRoYW4gc3Ry dWN0IHNjaGVkdWxlciBvbmVzLA0KPj4+IGJ1dCBzdGlsbCBjYXJyeSBuYW1lcyBkZXNjcmli aW5nIHRoZSBvbGQgdHlwZS4NCj4+Pg0KPj4+IFJlbmFtZSB0aGVtIHRvIG1hdGNoIHRoZSBj dXJyZW50IGJlaGF2aW91ci4NCj4+PiBObyBmdW5jdGlvbmFsIGNoYW5nZS4NCj4+Pg0KPj4+ IFNpZ25lZC1vZmYtYnk6IEZ1cmthbiBDYWxpc2thbiA8ZnJuMWZ1cmthbjEwQGdtYWlsLmNv bT4NCj4+PiAtLS0NCj4+PiAgIHhlbi9hcmNoL2FybS94ZW4ubGRzLlMgICAgICB8ICAyICst DQo+Pj4gICB4ZW4vYXJjaC9wcGMveGVuLmxkcy5TICAgICAgfCAgMiArLQ0KPj4+ICAgeGVu L2FyY2gvcmlzY3YveGVuLmxkcy5TICAgIHwgIDIgKy0NCj4+PiAgIHhlbi9hcmNoL3g4Ni94 ZW4ubGRzLlMgICAgICB8ICAyICstDQo+Pj4gICB4ZW4vY29tbW9uL3NjaGVkL2FyaW5jNjUz LmMgfCAgMiArLQ0KPj4+ICAgeGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMgICAgIHwgMzMgKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tDQo+Pj4gICB4ZW4vY29tbW9uL3NjaGVk L2NyZWRpdC5jICAgfCAgMiArLQ0KPj4+ICAgeGVuL2NvbW1vbi9zY2hlZC9jcmVkaXQyLmMg IHwgIDIgKy0NCj4+PiAgIHhlbi9jb21tb24vc2NoZWQvbnVsbC5jICAgICB8ICAyICstDQo+ Pj4gICB4ZW4vY29tbW9uL3NjaGVkL3ByaXZhdGUuaCAgfCAgNCArKy0tDQo+Pj4gICB4ZW4v Y29tbW9uL3NjaGVkL3J0LmMgICAgICAgfCAgMiArLQ0KPj4+ICAgeGVuL2luY2x1ZGUveGVu L3hlbi5sZHMuaCAgIHwgMTAgKysrKystLS0tLQ0KPj4+ICAgMTIgZmlsZXMgY2hhbmdlZCwg MzMgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pDQo+Pg0KPj4gSSdtIG5vdCBxdWl0 ZSBzdXJlIGlmIGFsbCBvZiB0aGlzIGlzIHJlYWxseSB1c2VmdWwuIEluIG1hbnkgKGFsbD8p IHBsYWNlcw0KPj4gSSB0aGluayAic2NoZWR1bGVyIiBhcyBhIHRlcm0gaXMgc3RpbGwgcXVp dGUgYXBwbGljYWJsZS4NCj4+DQo+PiBPbmUgKGdlbmVyYWwpIG5pdCB0aG91Z2g6IGlmIGFs cmVhZHkgeW91IHRvdWNoIG1hbGZvcm1lZCBsaW5lcyAob3ZlcmxvbmcNCj4+IG9uZXMgaXMg d2hpY2ggcHJvbXB0ZWQgdGhpcyBjb21tZW50KSwgcGxlYXNlIGFkanVzdCB0aGVtIHRvIGJl IHN0eWxlLQ0KPj4gY29uZm9ybWFudC4NCj4+DQo+PiBKYW4NCj4gDQo+IFRoZSBtYWluIHJl YXNvbiBJIHJlbmFtZWQgdGhvc2Ugc3ltYm9scyB3YXMgdHlwZSBjb25zaXN0ZW5jeSAtIHNp bmNlDQo+ICdzdHJ1Y3Qgc2NoZWR1bGVyJyBpcyBub3cganVzdCB0aGUgcnVudGltZSBwZXIt Y3B1cG9vbCBvYmplY3QsIGtlZXBpbmcNCj4gJ3NjaGVkdWxlcnNbXScgYW5kICdSRUdJU1RF Ul9TQ0hFRFVMRVIoKScgYXJvdW5kIHRvIGhvbGQgJ3N0cnVjdA0KPiBzY2hlZF9vcHMnIHBv aW50ZXJzIGZlbHQgbGlrZSBpdCBtaWdodCBjb25mdXNlIHNvbWVvbmUgcmVhZGluZyB0aGUg Y29kZQ0KPiBsYXRlci4NCj4gDQo+IFRoYXQgc2FpZCwgSSBnZXQgeW91ciBwb2ludC4gQXQg YSBoaWdoZXIgbGV2ZWwsIHRob3NlIG1hY3JvcyBhbmQgbGlua2VyDQo+IGFycmF5cyBhcmUg c3RpbGwganVzdCByZWdpc3RlcmluZyBzY2hlZHVsZXIgaW1wbGVtZW50YXRpb25zLCBzbyBr ZWVwaW5nDQo+IHRoZSBuYW1lcyBpcyBva2F5IHRvby4gSWYgdGhlIG1haW50YWluZXJzIHBy ZWZlciBrZWVwaW5nIHRoZSBleGlzdGluZw0KPiBuYW1pbmcsIHBhdGNoIDEgY2FuIHNpbXBs eSBiZSB0YWtlbiBvbiBpdHMgb3duIHdpdGhvdXQgdGhlIHNlY29uZCBwYXRjaC4NCj4gDQo+ IEp1ZXJnZW4sIHdoYXQgZG8geW91IHRoaW5rIGhlcmU/DQoNCkkgZG9uJ3QgdGhpbmsgZGlm ZmVyZW50IG5hbWVzIG1ha2UgYSByZWFsIGRpZmZlcmVuY2UuIEkgYWxyZWFkeSBleHBlY3Rl ZA0KdGhpcyByZW5hbWluZyB0byBiZSBxdWVzdGlvbmVkLCBoZW5jZSB0aGUgc3VnZ2VzdGlv biB0byBkbyBpdCBpbiBhbiBleHRyYQ0KcGF0Y2gsIGFsbG93aW5nIHRvIHRha2UgdGhlIG1h aW4gcmV3b3JrIGluZGVwZW5kZW50bHkgZnJvbSBpdC4gOi0pDQoNCklPVzogSSB3b3VsZG4n dCBvcHBvc2UgZG9pbmcgdGhlIHJlbmFtaW5nLCBidXQgSSdkIHRha2UgcmVwbGllcyBhcyBK YW4ncw0KYXMgYSBoaW50IG5vdCB0byBBY2sgdGhlIHBhdGNoLg0KDQoNCkp1ZXJnZW4NCg== --------------IRlJKDHBgdj9ad1hPAxHm6Jb Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------IRlJKDHBgdj9ad1hPAxHm6Jb-- --------------Dt5H7KYGzgPxZyK0fqoYT3T4-- --------------8VDZGiCxvC0PohVfEt0ee0cV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpzMyYFAwAAAAAACgkQsN6d1ii/Ey+K fAgAgIT4pyEw2GnM013+P1NM1eLKA/QPWRpp4aekdA2de4MHsNArJTP4YmBFqrtQWUvXm/rIMw3s tmXw9pWqNhbNCwb8opk8XYe61OTyb3xnKZWfZq/sBslexo697p0oIUJHL/BPIc6W3KNtGAChH0CJ w02F2NAmAsR2FtFVD2vJUzJr4hG0GXB+pMkTftm8UWxVTucD+PEWy44lUPae/GAdofHvsCa+LnTC 8evYpKctcPh+drlFbsJafVXVy8nXYD1GMXvt5sOTdB6DkZ+8LJs1N5yxz5KTLMlgp0ZL9KXAKg1F hzasZyhzf3qEpIeviolvLiSmi3WYF4I0WVkIUcncng== =qBl0 -----END PGP SIGNATURE----- --------------8VDZGiCxvC0PohVfEt0ee0cV-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:01:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383457.1626734 (Exim 4.92) (envelope-from ) id 1wrbF6-0002wF-Fr; Wed, 05 Aug 2026 13:01:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383457.1626734; Wed, 05 Aug 2026 13:01:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbF6-0002w8-CF; Wed, 05 Aug 2026 13:01:08 +0000 Received: by outflank-mailman (input) for mailman id 1383457; Wed, 05 Aug 2026 13:01:06 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbF4-0002w1-B2 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:01:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrbF3-00F0hI-Jl for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:01:05 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73340f-5cb7-0a2a0a5109dd-0a2a450cca3a-10 for ; Wed, 05 Aug 2026 15:01:05 +0200 Received: from [209.85.208.50] (helo=mail-ed1-f50.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733411-f479-0a2a450c0019-d155d032e8bf-3 for ; Wed, 05 Aug 2026 15:01:05 +0200 Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-6a097f5ab95so1386932a12.2 for ; Wed, 05 Aug 2026 06:01:05 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a1462c4432sm1966922a12.26.2026.08.05.06.01.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 06:01:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785934864; x=1786539664; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Dy7OAYKdpFSION1qK9mLR1WaGwo6ArtSEVtHpH3KkpM=; b=QQEf42qJnrTxfo1zRW2FSPqPD3+R4acarIimedep5XEd7SDJKp+981nbkjpxKz1eqL HObxr1QAG8EpkQPtnqfjflKePiVCoWUQFHeoW9kNQP/+nUvHaexVsURXj92Kw7yPnRPa 4tGaf6tt104+f1o32w5XjHwazbJ7d5EV89jkDukdRbKt07ZvBJoSqzCVO8cyXuiTI78Q ZOBF/EnzGunbJQUjtHIGVQKXoXQAZMBqfCbrJm+Xzs+IAx6xiaUbxC6ZY2RA5y9ZTwyn 2C38InWsC/WjudtPE9ybA23ur9/DKk8JcYa6GhaYMS1aiCODk37c+AjS8R/SqsMTksl6 rpiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785934864; x=1786539664; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Dy7OAYKdpFSION1qK9mLR1WaGwo6ArtSEVtHpH3KkpM=; b=Q4ovANe17yu7rglKxdLIvC9vhs0RUNZJq8ib1OhVcc8T8rABupDCIHT1UOZvOFcKTn sJbOlYM3Xt08J3e01c/k60Qe5kub4s+KeIRhOysJ1XhbZd+8u/XR7Eso6blJkqrl1hqY aXoviu7IG20UVn6XsXJKgE35muiDBts/E/6qhAWuUVIZQr0diffHyaxp0+LmxITLWGrG PDVytwBeQYeugNo1+Oy/WZFQ5nmfXwcrmLaISINyqKgkSccpVqkHkC8DJiLia75le4TS OHsdR/5JY+/jw2lWENKFIEr5Ko3pjjGGzObV6WvIaVd0l0Ishp2ZZx4/nzj4EOBnfjWs JK+w== X-Forwarded-Encrypted: i=1; AHgh+Roq46QCZtxZctSerCzozF5SCWdkj39e5z6JlrCPlXgAqVAoQUdCXIQjl7w0f45gseGjWDXrm+Zz4BU=@lists.xenproject.org X-Gm-Message-State: AOJu0YyW9bg1Y5hAu0WWgwXC8+h0phdvT/uHWzJbV/N7YcYYnUh85WXO bJk0hjZ49pqlUnKAHf7MeAoGSkgQ8LVkSd4Lx6IvzYH6wFkHEc/uZ7RdYYA0/J5T604B0ciSJoj k5sPPldE= X-Gm-Gg: AR+sD13hO26k4whFaJ2UmvtuZHlgkky2h158Zs/hyFBB66r1t/D00CcibFPH9TyIQ0w J/DBNArHw4vRcknpN8XdScW1J4ngPvr08tUFNjI1r6NZIidEFyhFSliUQ2xsvcluKUlpH+hu6dp cllAlRs5lYbE2jrnh4itKyFLWd5WhhxuC0cL3p5eK8ik4bjOtBMOErrFqUWlqZF+hgDJCffg+LJ XITDR0XTNA3CGcMcwOnWYWArrRtYT0fiVVZPpxZ12RzvITsCxcLH+fM4ZVxytYcLyqsjQoOHnFM NyMw66QFuViHzwoAjCZv4LLT+tljQzcPOaup/Z+z6xkC3WzXNmtZkRAo9AMayxDpyEsnKAIeFh5 eBxaDmMbps8c2TEKvyIaQjF1dRc5tdDLOoYM9wgVsJLhkuOerTOg/SMGkJNCANj1muzTFXk7F6c IsL25FHj1BeuZHItQmSFdUl+q7kZfP5h2KzCWU5X2t6JEaBoSIFMrPHsjxoQ8BNPrr5fa25YEIo TPH6YSKnww83SK+E2ERRHcgFGo0lhFczHpCtzyXmbsfx/Pejb0KbD0m4UzsifApzAUXsgo3iwcU nsf0BncCtf1BxAw= X-Received: by 2002:a05:6402:50cf:b0:6a0:7a06:302a with SMTP id 4fb4d7f45d1cf-6a14f0e51f6mr3480243a12.3.1785934863571; Wed, 05 Aug 2026 06:01:03 -0700 (PDT) Message-ID: <9ecb95f6-5235-4032-b0ab-c8b2f5a8830e@suse.com> Date: Wed, 5 Aug 2026 15:01:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] xen/sched: split scheduler vtable from struct scheduler To: Furkan Caliskan , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com References: <20260804055327.22119-1-frn1furkan10@gmail.com> <20260804055327.22119-2-frn1furkan10@gmail.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260804055327.22119-2-frn1furkan10@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MaBRrfc6bR2rpKhS7HyJH9hK" X-purgate-ID: tlsNG-d25034/1785934865-52331A5B-2BDD2FDC/0/0 X-purgate-type: clean X-purgate-size: 9864 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MaBRrfc6bR2rpKhS7HyJH9hK Content-Type: multipart/mixed; boundary="------------k00BdssbclEkhrLi90HNJ0s9"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Furkan Caliskan , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com Message-ID: <9ecb95f6-5235-4032-b0ab-c8b2f5a8830e@suse.com> Subject: Re: [PATCH v2 1/2] xen/sched: split scheduler vtable from struct scheduler References: <20260804055327.22119-1-frn1furkan10@gmail.com> <20260804055327.22119-2-frn1furkan10@gmail.com> In-Reply-To: <20260804055327.22119-2-frn1furkan10@gmail.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------k00BdssbclEkhrLi90HNJ0s9 Content-Type: multipart/mixed; boundary="------------CoTMydheAf7SCdPdQy3APn7A" --------------CoTMydheAf7SCdPdQy3APn7A Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjYgMDc6NTMsIEZ1cmthbiBDYWxpc2thbiB3cm90ZToNCj4gc3RydWN0IHNj aGVkdWxlciBjdXJyZW50bHkgc2VydmVzIHR3byBwdXJwb3NlczogaXQgaXMgdGhlIHN0YXRp Yw0KPiB2dGFibGUgYSBzY2hlZHVsZXIgYmFja2VuZCBkZWZpbmVzIChuYW1lLCBvcHRfbmFt ZSwgc2NoZWRfaWQsIGFuZA0KPiBhbGwgaXRzIGZ1bmN0aW9uIHBvaW50ZXJzKSwgYW5kIGl0 IGlzIGFsc28gdGhlIHBlci1jcHVwb29sIHJ1bnRpbWUNCj4gb2JqZWN0IHNjaGVkdWxlcl9h bGxvYygpIGFsbG9jYXRlcy4gQmVpbmcgdGhlIHNhbWUgdHlwZSBmb3JjZXMNCj4gc2NoZWR1 bGVyX2FsbG9jKCkgdG8gbWVtY3B5KCkgdGhlIHdob2xlIHZ0YWJsZSBpbnRvIGEgZnJlc2gN Cj4gYWxsb2NhdGlvbiBwZXIgY3B1cG9vbCwgZHVwbGljYXRpbmcgaWRlbnRpY2FsIGZ1bmN0 aW9uIHBvaW50ZXJzDQo+IGFjcm9zcyBldmVyeSBjcHVwb29sIHVzaW5nIHRoZSBzYW1lIHNj aGVkdWxlci4NCj4gDQo+IFNwbGl0IHRoZSB2dGFibGUgb3V0IGludG8gaXRzIG93biB0eXBl LCBzdHJ1Y3Qgc2NoZWRfb3BzLCBzbyBpdA0KPiBjYW4gYmUgc2hhcmVkIGJ5IGV2ZXJ5IGNw dXBvb2wgdXNpbmcgYSBnaXZlbiBzY2hlZHVsZXIgaW5zdGVhZCBvZg0KPiBjb3BpZWQgcGVy IGNwdXBvb2wuIHN0cnVjdCBzY2hlZHVsZXIgaXMgbGVmdCBob2xkaW5nIG9ubHkgd2hhdCBp cw0KPiBhY3R1YWxseSBwZXItaW5zdGFuY2U6IGEgcG9pbnRlciB0byB0aGUgc2hhcmVkIHNj aGVkX29wcywgcGx1cw0KPiBzY2hlZF9kYXRhIGFuZCBjcHVwb29sLiBzY2hlZHVsZXJfYWxs b2MoKSBub3cgc3RvcmVzIGEgcG9pbnRlciB0bw0KPiB0aGUgbWF0Y2hpbmcgc2NoZWRfb3Bz IGluc3RhbmNlIGluc3RlYWQgb2YgY29weWluZyBpdHMgZmllbGRzLCBhbmQNCj4gZXZlcnkg YWNjZXNzb3IgaW4gcHJpdmF0ZS5oIGlzIHVwZGF0ZWQgZnJvbSBzLT5maWVsZCB0bw0KPiBz LT5vcHMtPmZpZWxkIHRvIG1hdGNoLg0KPiANCj4gRXZlcnkgaW4tdHJlZSBzY2hlZHVsZXIg YmFja2VuZCAoY3JlZGl0LCBjcmVkaXQyLCBydGRzLCBhcmluYzY1MywNCj4gbnVsbCkgaXMg Y29udmVydGVkIGZyb20gc3RydWN0IHNjaGVkdWxlciB0byBzdHJ1Y3Qgc2NoZWRfb3BzLg0K PiANCj4gQSBoYW5kZnVsIG9mIGNhbGwgc2l0ZXMgZWxzZXdoZXJlIHJlYWQgYSBzY2hlZHVs ZXIncyBuYW1lLA0KPiBvcHRfbmFtZSBvciBzY2hlZF9pZCBkaXJlY3RseSBhbmQgYXJlIHVw ZGF0ZWQgdG8gZ28gdGhyb3VnaA0KPiAtPm9wcyBhcyB3ZWxsLg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogRnVya2FuIENhbGlza2FuIDxmcm4xZnVya2FuMTBAZ21haWwuY29tPg0KDQpSZXZp ZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4N Cg== --------------CoTMydheAf7SCdPdQy3APn7A Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------CoTMydheAf7SCdPdQy3APn7A-- --------------k00BdssbclEkhrLi90HNJ0s9-- --------------MaBRrfc6bR2rpKhS7HyJH9hK Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpzNA4FAwAAAAAACgkQsN6d1ii/Ey9K 2gf/aXMssP8XDAyhOIOkEt4YoePTHfdH5BPzbI3OLIYHRDSw6T/ynN4iw40h6HNRy10Hs8hG0X2i djTW6AqTlOXn3jtqAgWRa7DDy8abE06RJGt4euMXHR2z4eisXZqubSNmtpkSRf+AU05cqHqr/G2J CTxNz0fSbBVz6wClkxvZkF695w436XE2VzTedtU2/b1RZKeawnpBD8j/7LKgM7UgjbTKbjtHhWWe sxq/KCbElZVlu/cEBQp2mVf4RMz9BKVPcRvrcmIuiSqdkT6UmUzGRG0xgzLXlEKWwUQ0QCkqYgKW MrIjVQF14z9erj5FZUwEv93aB6W2k5A39pntEMY+xA== =OprQ -----END PGP SIGNATURE----- --------------MaBRrfc6bR2rpKhS7HyJH9hK-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:03:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:03:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383467.1626741 (Exim 4.92) (envelope-from ) id 1wrbHV-0003W1-UQ; Wed, 05 Aug 2026 13:03:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383467.1626741; Wed, 05 Aug 2026 13:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbHV-0003Vu-Rq; Wed, 05 Aug 2026 13:03:37 +0000 Received: by outflank-mailman (input) for mailman id 1383467; Wed, 05 Aug 2026 13:03:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbHU-0003Vk-RY for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:03:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrbHU-004exm-2c for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:03:36 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7334a4-2eae-0a2a0a5409dd-0a2a45038e3c-10 for ; Wed, 05 Aug 2026 15:03:35 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7334a6-fae8-0a2a45030019-b9ff1c12b033-3 for ; Wed, 05 Aug 2026 15:03:35 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fd205a597000e099.002 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 05 Aug 2026 13:03:33 +0000 Received: from [192.168.1.18] (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie) by mail2.vates.fr (Postfix) with ESMTPSA id 9855F83532; Wed, 5 Aug 2026 15:03:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=ZF6WP7UgFAc2NwspHi2jmBKrhGZX12HLI7355rllVlY=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=bKzS3fH8fcTgmTMH919eLmqA0iiG7PfxBrOy255DtkOcUW1uXnC6Ry+HCDzkrXJsah6t/IX0D rviASMjk5sX5nt9PKWVBm/6/utqWiBwCWXxYcaqQ+LJc8n7iNUpbH8igGhuiMzLLJK5wsGN6A9i bFhh8uc96KAVJcAVOBLaP4j/7D1P3KPERe7jZbt/PMTn52r/Xgnam2ZwEK9yh6ItIFAAubAqJLk Iz117q1924YM7GfVKV62NshJEvpP0V3JYP2zGd+G+8VqW8x7srEJrdKGbMQ6c5xjKHgwL0LprCk atSyPFQc9++P8qw0jPSG9HlCjkhC2x7IWytaJcDcggpA== X-Zone-Loop: 1aa6608b4569365f6f40efd511b4be805d3142dc85b3 x-campaign-type: default x-transaction-id: 87f2a609-f5fe-4793-b9ca-dd303678cb73 x-swg-uid: 01-5f0b3d50-284b-4c41-9694-8db580106f0a X-Mailer: Sweego Message-ID: <1785935013.8631fc262581453bbf619ec5b2062170.19fd205a597000e099@vates.tech> x-swg-bid: 1785935013.8631fc262581453bbf619ec5b2062170.19fd205a597000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Wed, 5 Aug 2026 15:03:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH 1/5] vtd: Ensure root entry is updated consistently To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319678.8631fc262581453bbf619ec5b2062170.19fad586037000e099@vates.tech> Content-Language: en-US From: Teddy Astie Autocrypt: addr=teddy.astie@vates.tech; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------mBz3RI5Xho308WveCHZtQD4r" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1785935012731 X-purgate-ID: tlsNG-33051d/1785935015-6E0D14E9-F747BA69/0/0 X-purgate-type: clean X-purgate-size: 7999 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------mBz3RI5Xho308WveCHZtQD4r Content-Type: multipart/mixed; boundary="------------6W4b2IEA0qJW7DYa5oUm8d4W"; protected-headers="v1" From: Teddy Astie To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org Message-ID: <60a9556b-4d2c-40ce-ada8-e20e7c28df43@vates.tech> Subject: Re: [RESEND PATCH 1/5] vtd: Ensure root entry is updated consistently References: <1785319236.8631fc262581453bbf619ec5b2062170.19fad51a4be000e099@vates.tech> <1785319678.8631fc262581453bbf619ec5b2062170.19fad586037000e099@vates.tech> In-Reply-To: --------------6W4b2IEA0qJW7DYa5oUm8d4W Content-Type: multipart/mixed; boundary="------------BXis0eJJqRvCkaDxo25jEDMC" --------------BXis0eJJqRvCkaDxo25jEDMC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 TGUgMDQvMDgvMjAyNiDDoCAxODowMCwgSmFuIEJldWxpY2ggYSDDqWNyaXTCoDoNCj4gT24g MjkuMDcuMjAyNiAxMjowNSwgVGVkZHkgQXN0aWUgd3JvdGU6DQo+PiAtLS0gYS94ZW4vZHJp dmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvcGFz c3Rocm91Z2gvdnRkL2lvbW11LmMNCj4+IEBAIC0yODEsMTMgKzI4MSwxMyBAQCB2b2lkIGZy ZWVfcGd0YWJsZV9tYWRkcih1NjQgbWFkZHIpDQo+PiAgIC8qIGNvbnRleHQgZW50cnkgaGFu ZGxpbmcgKi8NCj4+ICAgc3RhdGljIHU2NCBidXNfdG9fY29udGV4dF9tYWRkcihzdHJ1Y3Qg dnRkX2lvbW11ICppb21tdSwgdTggYnVzKQ0KPj4gICB7DQo+PiAtICAgIHN0cnVjdCByb290 X2VudHJ5ICpyb290LCAqcm9vdF9lbnRyaWVzOw0KPj4gKyAgICBzdHJ1Y3Qgcm9vdF9lbnRy eSByb290LCAqcm9vdF9lbnRyaWVzOw0KPj4gICAgICAgdTY0IG1hZGRyOw0KPj4gICANCj4+ ICAgICAgIEFTU0VSVChzcGluX2lzX2xvY2tlZCgmaW9tbXUtPmxvY2spKTsNCj4+ICAgICAg IHJvb3RfZW50cmllcyA9IChzdHJ1Y3Qgcm9vdF9lbnRyeSAqKW1hcF92dGRfZG9tYWluX3Bh Z2UoaW9tbXUtPnJvb3RfbWFkZHIpOw0KPj4gLSAgICByb290ID0gJnJvb3RfZW50cmllc1ti dXNdOw0KPj4gLSAgICBpZiAoICFyb290X3ByZXNlbnQoKnJvb3QpICkNCj4+ICsgICAgcm9v dC52YWwgPSBBQ0NFU1NfT05DRShyb290X2VudHJpZXNbYnVzXS52YWwpOw0KPiANCj4gSSdt IHByZXR0eSBjb25jZXJuZWQgYWJvdXQgdGhpczogWW91J3JlIHJlYWRpbmcgb25seSBoYWxm IG9mIHRoZSBlbnRyeSBoZXJlLA0KPiBhbmQgeW91J3JlIHdyaXRpbmcgb25seSBoYWxmIG9m IGl0IGZ1cnRoZXIgZG93bi4gVGhlIG90aGVyIGhhbGYgaXMgcmVzZXJ2ZWQNCj4gcmlnaHQg bm93LCBidXQgdGhlcmUncyBub3QgZXZlbiBhIGNvbW1lbnQgYmVpbmcgYWRkZWQgdG8gdGhp cyBlZmZlY3QuIChZZXQNCj4gZXZlbiB3aXRoIGEgY29tbWVudCwgSSdkIHN0aWxsIGJlIGNv bmNlcm5lZCwganVzdCBub3QgYXMgbXVjaC4pDQo+IA0KDQpUaGUgaWRlYSBpcyB0byBtYXRj aCB0aGUgb3JpZ2luYWwgbG9naWMgd2hpbGUgbWFraW5nIGl0IGFsd2F5cyBjb21waWxlIA0K Y29ycmVjdGx5LiBBcyB3ZSBkb24ndCBpbnRlcmFjdCB3aXRoIHRoZSBvdGhlciBwYXJ0IG9m IHRoZSByb290IGVudHJ5IA0KKHJlc2VydmVkLCBvciB1cHBlciBjb250ZXh0IHRhYmxlIHdp dGggU2NhbGFibGUtTW9kZSkuDQoNCklkZWFsbHksIGl0IHNob3VsZCBiZSB3cml0dGVuIHVz aW5nIGEgYml0ZmllbGQgc3RydWN0dXJlIGluc3RlYWQsIGJ1dCANCml0J3MgYSBtdWNoIGxh cmdlciBjaGFuZ2UuDQoNCj4+IEBAIC0yOTUsMTEgKzI5NSwxMiBAQCBzdGF0aWMgdTY0IGJ1 c190b19jb250ZXh0X21hZGRyKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11LCB1OCBidXMpDQo+ PiAgICAgICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShyb290X2VudHJpZXMpOw0K Pj4gICAgICAgICAgICAgICByZXR1cm4gMDsNCj4+ICAgICAgICAgICB9DQo+PiAtICAgICAg ICBzZXRfcm9vdF92YWx1ZSgqcm9vdCwgbWFkZHIpOw0KPj4gLSAgICAgICAgc2V0X3Jvb3Rf cHJlc2VudCgqcm9vdCk7DQo+PiAtICAgICAgICBpb21tdV9zeW5jX2NhY2hlKHJvb3QsIHNp emVvZihzdHJ1Y3Qgcm9vdF9lbnRyeSkpOw0KPj4gKyAgICAgICAgc2V0X3Jvb3RfdmFsdWUo cm9vdCwgbWFkZHIpOw0KPj4gKyAgICAgICAgc2V0X3Jvb3RfcHJlc2VudChyb290KTsNCj4+ ICsgICAgICAgIEFDQ0VTU19PTkNFKHJvb3RfZW50cmllc1tidXNdLnZhbCkgPSByb290LnZh bDsNCj4+ICsgICAgICAgIGlvbW11X3N5bmNfY2FjaGUoJnJvb3RfZW50cmllc1tidXNdLCBz aXplb2Yoc3RydWN0IHJvb3RfZW50cnkpKTsNCj4gDQo+IHNpemVvZig8ZXhwcmVzc2lvbj4p IHBsZWFzZSBpbiBmYXZvciBvZiBzaXplb2YoPHR5cGU+KSwgd2hlbmV2ZXIgcG9zc2libGUu DQo+IA0KPj4gICAgICAgfQ0KPj4gLSAgICBtYWRkciA9ICh1NjQpIGdldF9jb250ZXh0X2Fk ZHIoKnJvb3QpOw0KPj4gKyAgICBtYWRkciA9ICh1NjQpIGdldF9jb250ZXh0X2FkZHIocm9v dCk7DQo+IA0KPiBXaGlsZSB0aGVyZSwgZHJvcCB0aGUgcG9pbnRsZXNzIGNhc3RzLCB0aHVz IGdldHRpbmcgcmlkIG9mIHR3byBzdHlsZSBpc3N1ZXMNCj4gYXMgd2VsbD8NCj4gDQoNCkZp eGVkIGxvY2FsbHkuDQoNCj4gSmFuDQo+IA0KDQpUZWRkeQ0K --------------BXis0eJJqRvCkaDxo25jEDMC Content-Type: application/pgp-keys; name="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Disposition: attachment; filename="OpenPGP_0x660FA9D102CBCFD0.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7L TBVHV/XOZw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJ T4ny+OGntnJntUoRKRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJA WicutjkkUgd28Bh6HV9EIumHtCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO 8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaTVqMdqul07o72m3eA2mf+LMu9a04FX/d4 wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/EoucejoZ5SH49ksmVAmKOLkt OaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+SPhHar7TPKjFz0G3D PNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89MXfQXZ3q t1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWj moACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNz uyOVCskwfUZPla6Zpd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp 0x0HfuhcYfAYPR46XHTvjaJEv99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuR OxdK8G+YHccJY8PvWSq2K2yiae2KGiAv1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50 wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhPeP3IdpfWc8cyRLXF06Rk46YM YCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcTUwgnYlFRk2FLq0Qe KEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9Egr/Wmu3 MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEM AKiQiZa3yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ 3DbVf+en3/FvdVZg2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTm etSG5/52AjtmPFtlXAk0NmLvfJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0 s3109sJeXT5ImVdphFs9cvyZyBT9t1PbRowv58EgV0zE4hbAeVkULAbxFV5b/ExT jjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKbYu6NCfiHfEyB3Xyg9hfdrRgj MRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ovXoK4jm+Py0FiUGUa A6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/eVtR2Q1w ZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWj moACGwwACgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiV oUiHYN5QwhnbZnsaJDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764Qxy X6rld2f2RcWkDuBHun55ZWXjby8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk /dS0XTOQi2wVUb17sW/+ybCEokdVacZGzOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fu oGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+lOWSvdNHgoEkWR0RXBPQjnGm LKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/OffO485NOTKwGOxyWb0 06cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR8ULR9nX0 LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa =3DlUIA -----END PGP PUBLIC KEY BLOCK----- --------------BXis0eJJqRvCkaDxo25jEDMC-- --------------6W4b2IEA0qJW7DYa5oUm8d4W-- --------------mBz3RI5Xho308WveCHZtQD4r Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmpzNKQFAwAAAAAACgkQZg+p0QLLz9Cg ZAv8CejTcvdc2zq4YcBR1xmNNBKPx4ZBBe7qz5WPnbS+cOuKUWm5yxrbxwtWmItg9/L14Uho73Ws tKxdYHYanu0UzZ8gcGwtQ4nkhA+hKnDGlAJNp51msQCtYcfwWjw99y2crXOj4D5yE+v7nBSHHiM3 6HB6+Iv2k150B9Xwcerzj6AkWpYqzXDr3BEt7LDs1k+1jxvdsd87cuPDEMIgfkcSyQz1mpkXEagK g29wlRJ1CuXKtVzRGz6UydHevv3rQhDpCSS9/yf9us/B4JB1ondSTYOYEqjoJcOjy0lABKe61FT7 GM2D4TzkFqLe3JIUkdZ40/5GCsaBhN67EgCLhzu9Rewh0Y1U7WhInzZb2N4rdWrxLYvKRoQinu3u fRT5FbkZbuTK2CpTGfynmnf5IwSeUEVSeCaXak3yVT2JftFQEdvAQ1sTyskHBQNak8P70Jizi6zj JFME/W7nwPkf3m3z3v02CZJ+wWR/tEmTsYmBfEGHHPKyek5z6Absm8XjCacZ =emah -----END PGP SIGNATURE----- --------------mBz3RI5Xho308WveCHZtQD4r-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:21:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:21:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383477.1626751 (Exim 4.92) (envelope-from ) id 1wrbYd-0007IO-Ai; Wed, 05 Aug 2026 13:21:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383477.1626751; Wed, 05 Aug 2026 13:21:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbYd-0007IG-6U; Wed, 05 Aug 2026 13:21:19 +0000 Received: by outflank-mailman (input) for mailman id 1383477; Wed, 05 Aug 2026 13:21:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbYc-0007IA-4C for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:21:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrbYc-006MEa-0M for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:21:17 +0000 Received: from mail-lj1-f176.google.com ([209.85.208.176]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wrbYb-00Gga6-2U for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:21:17 +0000 Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-39ee96f8047so7161101fa.1 for ; Wed, 05 Aug 2026 06:21:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:Cc :To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version; bh=Aj2MapBS2f21v+Kw08Px43b1OXbhUlXb81lE0rDAxHA=; b=iOK0r0o1ehJVu/beuwHkNn58kD bT8NyB+fjAQ33jxQizlkZUWYUhjswdjwzqQbhG73nigXmLqKG6pJj5RZgixgH+LKewupJjOhp4yVa ybn3EgytdS0GNCw8k9Gn1O1SwZdjP7WhA6kcsVvcLQOyGlWAy/sSX0FAC3dANoadTuQw=; X-Gm-Message-State: AOJu0Yy1beqhDc8GA/BcVXJJxGeu/8yAMOxyyL0bPweqySOslv1F7Yaj aGsrxr3Skm3tmW6nE3fwldwzOiEUQkPqG8ToVsOENOXRwkgMYPu9bn0r2Xqoq0C2QRW9+F7aqM5 NA5uPlyyxTFI3t35NVll/E/PRHStmdEY= X-Received: by 2002:a05:651c:a388:10b0:39b:1a03:bcb0 with SMTP id 38308e7fff4ca-39fbb1e30c3mr7617981fa.10.1785936076704; Wed, 05 Aug 2026 06:21:16 -0700 (PDT) MIME-Version: 1.0 References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> In-Reply-To: From: George Dunlap Date: Wed, 5 Aug 2026 23:21:02 +1000 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mwH9odwJKdDNjCUl7vL4fcG7q9LlDV3AqgiQdkB-sGx8QqXswN89PeojV8 Message-ID: Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 5, 2026 at 10:41=E2=80=AFPM J=C3=BCrgen Gro=C3=9F wrote: > > On 05.08.26 14:15, George Dunlap wrote: > > [Adding back in xen-devel, since this is relevant] > > > > On Wed, Aug 5, 2026 at 9:15=E2=80=AFPM J=C3=BCrgen Gro=C3=9F > > wrote: > > > > On 04.08.26 11:34, George Dunlap wrote: > > > On Tue, Aug 4, 2026 at 6:45=E2=80=AFPM J=C3=BCrgen Gro=C3=9F > > > > >> wrote: > > > > > > > > > P.S.: George, would it be possible to turn off HTML mails wh= en sending to > > > xen-devel? > > > > > > > > > I see both a text/plain part and a text/html part in the mail I = sent; > > isn't the > > > presence of a text/plain version sufficient? > > > > > > Obviously sending patches is a different matter; but for that I'= ll be > > using git- > > > send-email. > > > > This is a reply to your mail using Thunderbird (which I have config= ured to use > > plain text format as the default, in order to comply with most mail= ing lists > > I'm using). > > > > I don't think Thunderbird is an exotic MUA, but please have a look = how it > > rendered your HTML reply to my original mail. I can't see clearly w= hich part > > was written by me originally and was cited by you in this mail. > > > > > > Thanks, this is what I was looking for. > > > > Attached is the message Gmail sent. As you can see, text/plain uses no= rmal `>` > > for quotes. > > > > That makes me think that the problem is in Thunderbird. It should eithe= r take > > the text/plan part, and reply to that as though it were the only part i= t had > > received; or it should take the HTML part, and convert the quotes to te= xt > > properly. Replying in HTML and then rendering it with only space inden= tations > > seems like a bug. > > > > Thunderbird certainly isn't exotic, but last time I used it it was defi= nitely > > under-maintained. > > > > You're asking every person who sends an email to xen-devel to remember = to take > > an action before sending the mail (or to send *all* mail as text/plain,= even if > > it's not to xen-devel), because your MUA isn't handling the standard pr= operly. > > And you are asking every Thunderbird user to live with bad threading or t= o > use a different mail client. Right, but Gmail is following the convention correctly, using nested > in plain text and nested
in html; Thunderbird (it would appear) is not following the convention, mis-rendering HTML blockquote into text as spaces instead of > (or instead of just using the plain text to reply to in the first place, rather than re-rendering the HTML into text badly). > > Is that really reasonable? Couldn't you tell Thunderbird to ignore htm= l and > > only render text/plain? > > I did look for a setting controlling that, but couldn't find any. I'm alr= eady > using to send plain text only. There seems to be no obvious control to pr= efer > text over html in alternative bodies. > > On Matrix you stated you are using the same configuration for sending mai= ls to > xen-devel since 2006. I'm not sure this is true, as most mails I've recei= ved > from you via xen-devel have been sent from your Citrix account, and those= were > all text-only. The last email I sent to the list in 2024 was dual format: https://marc.info/?l=3Dxen-devel&m=3D171405222718671 Basically, if I was writing a new email, or replying to one that I was cc'd on, I tended to use Apple Mail (and Thunderbird before that); but if I was responding to an email that I wasn't cc'd on, I used Google. Apple seems to have been configured to send text-only, while Gmail generally sends dual-format unless I ask it not to for specific messages. (I've done so for this message, we'll see what it looks like.) -George From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:28:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383487.1626760 (Exim 4.92) (envelope-from ) id 1wrbfY-00084k-Tl; Wed, 05 Aug 2026 13:28:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383487.1626760; Wed, 05 Aug 2026 13:28:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbfY-00084d-Qv; Wed, 05 Aug 2026 13:28:28 +0000 Received: by outflank-mailman (input) for mailman id 1383487; Wed, 05 Aug 2026 13:28:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbfY-00084X-5g for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:28:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrbfX-007Hib-Ib for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:28:27 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733a77-5cb7-0a2a0a5109dd-0a2a450393f0-16 for ; Wed, 05 Aug 2026 15:28:27 +0200 Received: from [209.85.221.48] (helo=mail-wr1-f48.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733a7b-fae8-0a2a45030019-d155dd30d5b3-3 for ; Wed, 05 Aug 2026 15:28:27 +0200 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso633357f8f.1 for ; Wed, 05 Aug 2026 06:28:27 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47febfda58fsm9094648f8f.7.2026.08.05.06.28.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 06:28:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785936507; x=1786541307; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uzXqEp59+17Vsqm1XWbN09ezWzAaeB9MVxhuAbnt2YA=; b=TEbMIZn6jPAZtas8+xHExBwQ5Z5p3rWzv9giujm9rgGccME/3G3v9dewsBQagGH3dv dInesvfjCqfSkPoImsScXKj9coRmgbjFh+wM4LsAQME6yuM6xLM2/P0RPcr1vW7c8nH7 DYLhr4lytZUyTPIZ1wOTX9G2Qvc0/TnpgKJ8D/V9VWCMm8keydO61cgsk71bgig5Tkv9 Vt3NP8nUFh82Bq6jtK79YT8YU53zk/w1ZATlnkBjvWThxcFo+zR09WHbDeHoMmH+Txvc 1FVrkPRovWfqeingZeKG65C+K0FkPxIN7VTwtHNJ5TCu6i4dEJK+b/CKcPQE6rR/EHI+ T22w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785936507; x=1786541307; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uzXqEp59+17Vsqm1XWbN09ezWzAaeB9MVxhuAbnt2YA=; b=fMmzDs3gy66WPiyOIinFsZqJMybsbs+6YcWv2t+NuWATkZYhePcFl2GxsY9T/901sq lCFjoSDKoB50iyz9fbIz/5IrKTIKFQ0nVajyeG0Xs3JUDzLakzOer9j366oipaZfFeso 5/2kgIGxdn6fwz0LjRupZjdPvfbk50EE1ZvBS4356mP9yM3Lxq85oNvZpf3vPfZjLsSp l+o6r9LH04IcLCSf9gs0dTqqwhs/iBc0NTXV27WARlj0XjvpvnbugwK7WWrT0ESFgBzr 90OfEuSOJzJ0dcK3X772xvb+kGTwXYpZfR4wBagfC0srORDnCi97WtS2NscvVOa4elKE RQjA== X-Gm-Message-State: AOJu0YxTEWZWWd6tCDF9elMc7NgS9++fHleNBQTnpUdRPVAuU1Qlh6jG LCR6aEtXEdvAdSWRfqgPgNt0oW09gd1oBmAY+JzmI1aJ3hujxeJ7XHuNGv0d0ZIj/g== X-Gm-Gg: AR+sD1372Ff9F/5ncpMQflEoB2E145nYQOsRtbkvysbW0A1KycOuFUyTSFefUKHxhOj N+QMQ4UpJVtG+HPaEkzCLu0KfBgxE7R+KIMiIzUuflTsZy2fJ0mymqf8ZhmiQQo2mdhhthb4irg RfjGzLxerDDZs8qoFI3g5Px1LcBAEt64i00P4DXCkGgy1pgcx8DmnivGxxaDvGLD7vNs4lmYXyI fQfmT+lDjl9BsLHmeKpsUtuSHycibzGb2lPyQc3v53/HptX3eaH+IkjMltpaWa98nh+bI/LTBSM SiPxS2Gk+BDyJSDwY3bV5m7pT0B2WbFGh2Dyd6FLQmjPw6WmbycHY7fg+PFDLb5dFwGb00JTkK4 wkKkIX+a1aoA/pQYLrire7TRB6FwzlpgliWoEKTUHbQYl72kZOd94XdAnXIPL1lLz39Z0l+ea6s mNlsTKg5VkbmzmaO+6N5Fu54gpdYDvD8PfUzds64obF/y2aw4DFhzIpUCZPv7GQ1075JS8x7OCA +Dqfy6686Fnckx1bQf6WZg4cMi6qKt25kq3o1wzTN2ZxF3d4CK7 X-Received: by 2002:a7b:ca4a:0:b0:499:4892:d022 with SMTP id 5b1f17b1804b1-4994e738af2mr70515625e9.8.1785936506898; Wed, 05 Aug 2026 06:28:26 -0700 (PDT) Message-ID: <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> Date: Wed, 5 Aug 2026 15:28:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) To: George Dunlap Cc: xen-devel , =?UTF-8?B?SsO8cmdlbiBHcm8=?= =?UTF-8?B?w58=?= References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1785936507-7428D4E9-1174FD0F/0/0 X-purgate-type: clean X-purgate-size: 1078 On 05.08.2026 14:15, George Dunlap wrote: > You're asking every person who sends an email to xen-devel to remember to > take an action before sending the mail You're by far not the first one to be asked this; you're the first one to have an issue with being asked, beyond some companies' IT getting in the way. (As to the latter point, I'm already combining my observations on xen-devel@ with those elsewhere.) > (or to send *all* mail as > text/plain, even if it's not to xen-devel), By default, that is. MUAs may or may not offer options to control this in the course of composing a message. > because your MUA isn't handling > the standard properly. Is that really reasonable? Couldn't you tell > Thunderbird to ignore html and only render text/plain? Both questions go together: text/plain as the only content is (not just by us) being asked for because that's the form known to work virtually everywhere. Wanting your mails to be properly handled at all receiving ends is - I think - not only reasonable, but also in your own interest? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:42:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:42:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383496.1626768 (Exim 4.92) (envelope-from ) id 1wrbt2-0002Zb-5V; Wed, 05 Aug 2026 13:42:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383496.1626768; Wed, 05 Aug 2026 13:42:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbt2-0002ZU-2f; Wed, 05 Aug 2026 13:42:24 +0000 Received: by outflank-mailman (input) for mailman id 1383496; Wed, 05 Aug 2026 13:42:22 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbt0-0002Z5-MB for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:42:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrbsz-0018PP-24 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:42:21 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733db3-2eae-0a2a0a5409dd-0a2a45098ae0-20 for ; Wed, 05 Aug 2026 15:42:20 +0200 Received: from [209.85.218.41] (helo=mail-ej1-f41.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733dbc-be1a-0a2a45090019-d155da29b591-3 for ; Wed, 05 Aug 2026 15:42:20 +0200 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c15f020a223so165436866b.1 for ; Wed, 05 Aug 2026 06:42:20 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c203625459dsm120745466b.20.2026.08.05.06.42.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 06:42:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785937340; x=1786542140; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Eh+aB4Fu1hQ4npYew960LgpTX0/RSp2uKRxnVc27sDs=; b=ei4VW/MOgQb/SM1Nm59KIH13r6zdr+1GKp2SGu47YR91/EsKHtrobFaHaq4NkWghh1 LZRSVFNwtaxdgHjsWa2fqTLvLGR3si7LwQXGKbnBhzKov87o4ac05vm9QWq2jjhH6iDZ PGbPJIj/+DU9YPusLyasz9k3+/45VgiJy3eX4BhMOpQcv7UrlFPH1kcqT3JMswuqtGP+ rjArJU4bHcoMPrPCMJgse3Vw4aylMkGh5BIr0sjDWBAtyXUgRG52HTX8dVkrhnQQlJtN 6RS3XMFcWMQuaVXfRzgHcnm5HkCF392J2kcefBSlCSe8gKerPlLThD1c/v4lq0CRe17d +OhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785937340; x=1786542140; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Eh+aB4Fu1hQ4npYew960LgpTX0/RSp2uKRxnVc27sDs=; b=hcOiOLtM8WEZnoHxIP4YO0A+5pQYenaTbCKXbP+icq0Wf7KnbWHe5TdaXdKG6meN8T yj4gx5yrnGh95qRjeGiNN3M1JurJFSaof/7srYO/yIWZwSa+5h0DzpanUPnBz1HDlMi1 +NjcbDovxF4wfKOn/6/WZtnyiXV3RwKAX9HKm4/hv1yZ7ckjKjaMYsKGugOBfsj8/Ms0 N+4DAvmouvXSMznvotUmebWvubf602rmYa7s3dAsDiCMuYkXk1CbO6kYk3EOW8A2GHbe FE3ADcB2tEWIC6H6QBiVZbxIKOLO3sv8OYfI6LalrbvThYu7tcmEe+Ha5hOAfBi+nvsM SaSg== X-Forwarded-Encrypted: i=1; AHgh+Rre7Hu1LlL+lYMTOJloRA+7lLBE7PCNF4QG/mbxTKvTDLNkAfaWIxGgJ9MOyLmUn7bwf/iKlguwMkw=@lists.xenproject.org X-Gm-Message-State: AOJu0Yyj8WWrqmvkLjsYF3HkLe5YoxqvCGeFWbPeGDlYBsi9qghxfgJM ukZ6/8tm7Qy07+RNtpXRjQ4oEEEMo2J9l6coo/u4C8r+8A+4JE9GW7TudZeoNRTdmJQtdXHblv+ poNK5EA== X-Gm-Gg: AR+sD11/74hcg5RhKo+dfMuLpPezhKnA0ciKj0yTFrHdbJv2g3wjerL8C3NbwQgW9tL PkT78m7DsKK/5EkqUOEPaWayQORiNkyFBSedCHqbIqhEvuLmaHedRruZRGpCIVcQTqcFK6Qq+7J vfiPk737mAzQcOO6ee/jOwN/gLJYCPWB7nIGReDgXpR7at/iaSyiYKOVgIeY6EP6MJMBCNmGb40 K4bn88Q9VZcl65E7KQeyJYkipLbWsmixSMgdCpHOC92aLD1IbqM+94jbpfydU5qHoALJI8nVoQ6 zPQjtqInw354Sx+4vNpr2mtCPJFxq116Ly82iUwbEAou6+8HIWaKY5BgjOq0KWUefoN1OsX4vRV NuM4TiEUPDIGdC1hhGrA6l1g6mArDZ8Z9GJisqdXl+m5yrFOGq91/4RH3aSQM9lyfMeL4VRImTx msQZiQF/7F5aaWOiTR2RC925yhYiESNAllB70bk53OWpATF+ICLiOzY/xzDJGoCGCUPril89Pjf pnpG+v6PZmF8PIiMollKUbWaYhkvVIAqZ8LNVm8YN93zDanBeHN X-Received: by 2002:a17:907:6d1b:b0:c16:242a:4722 with SMTP id a640c23a62f3a-c2039d1cae8mr291133066b.22.1785937340368; Wed, 05 Aug 2026 06:42:20 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 15:42:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] x86/nmi: Watchdog fixes/improvement Part 1 To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805124525.105457-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1785937340-BF2DC034-09D12C29/0/0 X-purgate-type: clean X-purgate-size: 1662 On 05.08.2026 14:45, Andrew Cooper wrote: > This is the start of a very long rabbit hole to address the > mis-classification of some watchdog NMIs as non-watchdog NMIs. For > now, just some simple and hopefully non-controvertial changes. > > https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/2733861049 > > Andrew Cooper (5): > x86/nmi: Drop {reserve,release}_lapic_nmi() > x86/nmi: Drop K7_NMI_EVENT > x86/nmi: Misc style fixes > x86/nmi: Check MSR_MISC_ENABLE for all Intel platforms > x86/nmi: Don't configure EvtSel repeatedly > > xen/arch/x86/include/asm/apic.h | 2 - > xen/arch/x86/nmi.c | 153 ++++++++++---------------------- > 2 files changed, 47 insertions(+), 108 deletions(-) This series, once again, is putting me in a difficult position: Should I look at it, or should I let it sit for two years or more, just like my earlier fixes in this area [1], [2] are? (Of course, as always so far, I will look at the patches, and I will likely also accept them going in ahead of mine. But I cannot exclude that at some point I might actually stop doing so, seeing how many of my patches are in that state. While at the same time none of yours are, afaict, i.e. as per the track record that I keep of what still needs responding to.) Yes, you did respond to [1], but is not being comfortable with a change really a reason to block it, when it _is_ an improvement, and when the alternative hasn't materialized in all the time? Jan [1] https://lists.xen.org/archives/html/xen-devel/2024-01/msg01365.html [2] https://lists.xen.org/archives/html/xen-devel/2024-04/msg00194.html From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:49:06 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:49:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383505.1626778 (Exim 4.92) (envelope-from ) id 1wrbzR-0003M7-Qr; Wed, 05 Aug 2026 13:49:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383505.1626778; Wed, 05 Aug 2026 13:49:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbzR-0003Lz-NZ; Wed, 05 Aug 2026 13:49:01 +0000 Received: by outflank-mailman (input) for mailman id 1383505; Wed, 05 Aug 2026 13:48:59 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrbzP-0003Lt-QA for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:48:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrbzO-00CExk-L3 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:48:58 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733f47-2eae-0a2a0a5409dd-0a2a4509a2f6-8 for ; Wed, 05 Aug 2026 15:48:58 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733f4a-be1a-0a2a45090019-d1558034c1c3-3 for ; Wed, 05 Aug 2026 15:48:58 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4954aff6088so10631145e9.3 for ; Wed, 05 Aug 2026 06:48:58 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e98adc4sm46474035e9.2.2026.08.05.06.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 06:48:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785937738; x=1786542538; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BojFhfKUlzIX2gMyZ1JO9FluxFCiamsA1rnpe2TZWSI=; b=V/3pHKj+PgK3pOH1IC5GpsLapJ5AP9kjPh9zh170sXT+1BD/2iD4uYdihF6bdvZP7v TqGzp8xg3AnSuC99FnHJB6GBJQa8ZTPTpeZbRDoOJ22f+K2Cw2nCuzqD3aGIIeherXcj mJKQlSK0vdLkmBuJPKoxs3j4URFluVEXiAWVBSdzGM4zo5wGx6gdURiey3YuOPgh+0Rb Ob874ACga8DZtNNQ7tiy4tlkRuxSb1wJtUfAeh1wj/ijAvMLFjHSuyzZ1TZWSQ7fkV+1 WtE9tymrKSz6G4jgX/2birPQH1ATz8Tgkwg3KUWR0XizgX/AzXcTlSyxEWy/rXL/PCm/ YPcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785937738; x=1786542538; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BojFhfKUlzIX2gMyZ1JO9FluxFCiamsA1rnpe2TZWSI=; b=OtBm9nVTxa6urTXl8Be54GXbFJ+DYuBJ3NVX4UMoBHeLdT9FLOapXgiNrhss8/PoJO bU+1xUtlTxlv8vwmlsezIANNNqweT7axVf5vgp6AFeWcirfwkLdDwTQ/s7HGU7bhBBTD ONDEcfqOHHPzvWEUkqv2Z8LTZFVvWLLLVopdGCpaKL+JmfBs+9eRVGBzNP040pOl5IZw OUu+WDnY5hULmjhoYWuWRzk/eYrSZaTxLGFIGf1CBgDdLQ/aZvZJtuu/JgA3BRkmFScM XSbJF6MIJPebxe1dB7H9egNlkEWbcKJbAb1atKoOEE1X7j5DeBy+E6cd370bXgl4MGkr 23bg== X-Forwarded-Encrypted: i=1; AHgh+RpuudY4SGVEvRQwGcwoxrMvV5U4IJfgTtiL74E80MQTNaxjrGWvqP4nb8c4P/7wQpw4n9PMNsFQvdc=@lists.xenproject.org X-Gm-Message-State: AOJu0YyRW/GT3XUTkfD29KREQ45hhBtwbv9K7Fu2SOl/zN2wrU5Pd5nf oqtRE1Ed11S/lPvbC+7THgVvHQiHpgl4SBktKpvA53/D91DsI7axBOgbhzvfCsQGMQ== X-Gm-Gg: AR+sD12xWGXbRWwFFVolSa2YZ0OGTMSctiCXxzQBIuSi81SMFBC1/tc5AxJMONwumL5 xmP7+xb1oGPT3rXod5t6QbFZeCpapIf2cez4+YBstl4R40VedQftb4m8dp32xlGvnfeEpyKETUH 4/Rbi3AcezFWnJikxKsJPsGSRgoWxX9XXmGLuJXNP2+B59ctcFf5k7rSMX+Ij91FMMVFKwJASCP sq1hY/pDDPbfXCU4skoOEPir86qIEQZZy0b9rhdsgNnwgcrUjP+GS92547pYTjXlPloE0MgOnMe c4ucPhgCSey77Va+T6aViq1uolhcu3km9W5ZSl2iOHk96FMmS6Lp67GPbrPM+g/AxfQpYIQC35/ sZYXmoyuBMlGbKK1ZGH9teHiyE3F/uewhi4UcbxqtcatVLxaCRZrQQPfAQpSiauQDpKHmSPFcgt AAjAd3uK1aOCfc6oHEkD7wTpD4t+yfu62Q5zXhi95Iu26WwDSFMleKSbFXsEOpMJKBJhNN8+hdK p+HWjSfdTFWvTvEm/1KC4C4I5EG+JfsoBvKBZrJYcrvha5edEyt X-Received: by 2002:a05:600c:1991:b0:493:e451:a9e1 with SMTP id 5b1f17b1804b1-4994e7448d9mr86234205e9.2.1785937737942; Wed, 05 Aug 2026 06:48:57 -0700 (PDT) Message-ID: <0e2707dd-4ced-4c77-9060-23bf7344a3e2@suse.com> Date: Wed, 5 Aug 2026 15:48:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] x86/nmi: Drop {reserve,release}_lapic_nmi() To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-2-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805124525.105457-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1785937738-3BAD0034-5176101A/0/0 X-purgate-type: clean X-purgate-size: 266 On 05.08.2026 14:45, Andrew Cooper wrote: > With Oprofile support dropped, there are no more users of these. Drop them. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:49:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383512.1626788 (Exim 4.92) (envelope-from ) id 1wrc0N-0003q5-4i; Wed, 05 Aug 2026 13:49:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383512.1626788; Wed, 05 Aug 2026 13:49:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrc0M-0003px-W6; Wed, 05 Aug 2026 13:49:58 +0000 Received: by outflank-mailman (input) for mailman id 1383512; Wed, 05 Aug 2026 13:49:58 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrc0M-0003pp-0W for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:49:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrc0L-000mCf-De for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:49:57 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a733f76-5cb7-0a2a0a5109dd-0a2a4503dc02-42 for ; Wed, 05 Aug 2026 15:49:57 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a733f85-fae8-0a2a45030019-d1558030ed8a-3 for ; Wed, 05 Aug 2026 15:49:57 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49553515a8bso14793265e9.1 for ; Wed, 05 Aug 2026 06:49:57 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e041b4bsm92452265e9.12.2026.08.05.06.49.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 06:49:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785937797; x=1786542597; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TvL2rOspMd85SySpoKUosK/j3GMuZB8mHcX/K39i1Kk=; b=MjjZ9+7m9htjO5pBkii5jLrAnSYf1JwGjv4L9vv61VnzT1t/vI3CcF4BU1GSfYhfUP Ko/Mn4664bFNLFlzfPyld042u+6zny8rmi4UgVrpZlGIDDoQ6ekBha4QuVBOgGMX2UBc EbgjwACcR1HjduwrY1KErOTD+r7rXzCRQDoSaXN+2xujZ4jcc03/9JyeUSQIlCLiTXCL MHc/3ntoJjP2qn98beAmZct9oTE+ggRe92raKgzr9wFPY0xOwVLiokIHI4bW1s1IoIO2 pN1sMtgypdrj56CGWXEcJFnz1jZylF7u3Pu9bgxxhsHnDWfwbLOMtLB4tGqVNiKYrOs2 X/PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785937797; x=1786542597; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TvL2rOspMd85SySpoKUosK/j3GMuZB8mHcX/K39i1Kk=; b=s3amUSQF2wslXzQNLK2gJolJiIlZd1c/+sOS2efcguNy4W3Gn2VZYlPEluL8lHBkvD oP0biA68qU+7sXiOpTfQLDcZS8zL5MkKMbfwGfnY6pBTgm4gjujcJ+4Ib1p/j4wwXSHu sZYQ6xDlJaGTM9vqdGVSTiEuud/iW7dvA20O7zzl4msCu2vW/QmLB5Yg688kcXXBQT1c 4DOnNsGloskc3QfwUS/39gRprDglV65XLYqmRoJTl6rtabzZ0s1OC6omrTOUtNpkVLeF jUQ/cOkzNG264/UTGTUrzGgYXHTNV/02BWesaPA/WcKMVdFEZ2R8kbmA5Q0H0X5/Jrdw MJTw== X-Forwarded-Encrypted: i=1; AHgh+RqHkp5jttNb2Piwg37dJfYYt8VOKs7Qn6Of1aYukVOaSPXZQrgPffEEP01xULXK+PmqOC+ijflRxFU=@lists.xenproject.org X-Gm-Message-State: AOJu0YxJQVB7d11FTJIywxjwbcKRSj4mSIH70BnN125sAqExaFeJ0xVA nq46dcb62Mr8l89IAi+MwNaoKdn8HCgioVUxLYHCKN666HT6eXiBX6PQhEnCOuTuag== X-Gm-Gg: AR+sD10MZ99UJxhWUURZ8hT5rnvSg+GDBAJSxonZT0zOG8ED79PMcjD+zeCMLcotKFq qBR7JLpuhjEK859/CkYBpfc8t2i6N3koAbfNrjoiLGlpwv2l74OFwTqEoTXP9T0PN65nPzz/M56 CMsbpW+dLYfAPWHrlmTUe0vs+RjtpxztqlnP8M5w6LYnD4xFYRiR3Vd8R24Uv1VWSTlXIbwbepN d6NK9h8t8JiBzHLDJXkpP4shZIOvCED9ABvUkOTC+6/5DbOMC5BwNBdeUaHmf1P3h7D7tQV++7e sNXrB4VF+10I7yTIIxKig9NIvJzv8Zg93X+Qf0H/3B6luD2qzhaFzD49XpbESDnSi0PbT6z7Npu Tftm92B48jCsS72DjafHl4DRPaYGPr776+ZQ3/puCTx/Ft4EvQBL3EAHZ91m6QJIu4ofmzuG2EM R4D7zKlb6c7mLtZwhyCuQAsoEIcjWQgX8yeT4NqnxP8BObuSEolm7BEPZiP5XoVk1ft6ag4577T cvYLILDSZxPpIklNQHLTrYw+4cue1RPIXAD3/qkntVh9ZtYgJj+ X-Received: by 2002:a05:600c:8b35:b0:499:518d:ebd6 with SMTP id 5b1f17b1804b1-499518decc7mr29528305e9.17.1785937796784; Wed, 05 Aug 2026 06:49:56 -0700 (PDT) Message-ID: <243ac905-6949-414d-823c-f6e183637bda@suse.com> Date: Wed, 5 Aug 2026 15:49:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] x86/nmi: Drop K7_NMI_EVENT To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-3-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805124525.105457-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1785937797-758824E9-CC757DF9/0/0 X-purgate-type: clean X-purgate-size: 516 On 05.08.2026 14:45, Andrew Cooper wrote: > This name is misleading. > > It's not possible to configure NMI or not from the event select register; that > comes from the APIC configuration for performance events. > > This name is "the thing we want to count for the NMI watchdog", but that's > clearer to follow when it simply names the event. Drop the indirection. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:53:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:53:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383519.1626796 (Exim 4.92) (envelope-from ) id 1wrc3J-0005Nc-G9; Wed, 05 Aug 2026 13:53:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383519.1626796; Wed, 05 Aug 2026 13:53:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrc3J-0005NV-DD; Wed, 05 Aug 2026 13:53:01 +0000 Received: by outflank-mailman (input) for mailman id 1383519; Wed, 05 Aug 2026 13:53:00 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrc3I-0005NO-HV for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:53:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrc3H-004o6f-Cu for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:52:59 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734010-2eae-0a2a0a5409dd-0a2a45098992-40 for ; Wed, 05 Aug 2026 15:52:59 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73403b-be1a-0a2a45090019-d155802fb4e8-3 for ; Wed, 05 Aug 2026 15:52:59 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-495635a85d2so8997825e9.0 for ; Wed, 05 Aug 2026 06:52:59 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fc2da2sm202715925e9.3.2026.08.05.06.52.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 06:52:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785937979; x=1786542779; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yHYw2W3qf29n9rzSQDKJYEq1mbdZ//fm9YT20zpV35c=; b=GwAIAcdDKLNoKqP1HyjYvHRObLiCL2VaLm8NEuxniOu9J0oo3LY5otJUjdk+WXNtwc 9KvAOdsdM6G+Ud64MNqV26vw0Apb+pm5CxH9TVwTpytIeazvbpmYFB7uS/8W35+dvM8C yJHCK6doo1pexFjGL7EJkszvQWR8aeZOg0fuqRC/RmyU4nJ1Ora5EW4C8DnoFDLoeQpm JwEjBk77ojm0Oj+IZn+U1zO2KthOkyEbxqrwlBL/eAcxRgZmzyMg5i0fNxgZFLCZJkjs +0mzLBcJ3m4WvoAtO1tYcc7SB5n0bNGNqVFbZVND4GKJvmll1GVfsW+VH2DHMmx3wDaK CucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785937979; x=1786542779; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yHYw2W3qf29n9rzSQDKJYEq1mbdZ//fm9YT20zpV35c=; b=Ae9P19rUgt1LEurz7LanP9ouWeEcLULdDXOKP01UEp9mT9XSFWHi3zPaG+XCNPEPHo Zytsj5bmuk7Dn84fy/yM+B+jOPZH84qyYxNMIgAp97p5y67E9r7LYKs0xnQZYmuvgKEj NlqSf7UCT/qYNOD385GW+KLRXkUB690OpIRRdClVNK22r3KOEFqTePxAqGYtjx/gYjnf OjuFUirX25QXWy//r1lINtaCJbbG0nsn/3538BC+poG6svD3gR8896ONY3jclfN6C9j2 eOLx+VK5EMhFwf0yYnI/2e7uM6lBfvaR9tJ6vTY6qjzWrGKHPkTSD3cT+sJoFHVciOES vtUg== X-Forwarded-Encrypted: i=1; AHgh+RpKJS1Cd7ZjZBbF9KGlOFLRwJsf9YHADDvPZrXXI98j6BWC/ZwnahM7Mpg29YCufOOgWEXONf3xrYw=@lists.xenproject.org X-Gm-Message-State: AOJu0YxUt/a5mlIOxDHJjpQB5xNzvV6LnJTo3eHn+zK32bNB6cO2chsE Ec5qL0y2L0bwK3F0GC+mNC+Oo2RwoK4s51S/CMMAVQ5h/AAqD5drhWmslb25ykRvVhZWkN0mvmi nQJuBZw== X-Gm-Gg: AR+sD12O14tAEQm9n6aYRUqfbc8NnP9Z2/VAZoX2Zs6Jp8yq1kFqyMSxIQI0PJzKoC5 BuKBLPiOBiLS6Rg6rGvCXFfn+xetVmm5wC3Z2dOTuo+4pEM0jramIK3iU6HmXGpysRcumzQoD5a DQl3x6bmDZ8KoOXvV4LP99WhYvplamK9+8PT6wxoZdXfMxUy8YO9jlM7xaJF03bGN5hfFdF5KCK dSe/qM/IFdnwVohHm9d9tFAcXefNk6S5pN1y/UJLRyB0qPTTh8TmbpGR/2bZLvAOq7Xz9kVREuE aS9D4bzgzEs25+lhOXvqo3ftpK1nksz6ayPT5d9vq2drEHJ9zb6jOJW1QIx6do6ORBtHECPFC6J MyufSguWrY77rgiirPuPcJ7E9mxCPD/Kz/80GrKGSnQRmqH9w8+I8ewmDfEjq8oIaF0myQGnCPN hIHiKKZq/Kix+IZnXtry836zUvGraNU83q5yqgSVzAie8NzlvFQB9Ph+tszHw5zkU5SWKbL01JU NMis2VrOCE3JKI8hOOE6fb5vIiEKVdnQ4rM5Bg0q/+RQcKRwHkK X-Received: by 2002:a05:600c:1553:b0:495:5045:39e6 with SMTP id 5b1f17b1804b1-4994e7d3080mr65359155e9.17.1785937978687; Wed, 05 Aug 2026 06:52:58 -0700 (PDT) Message-ID: <3e414c79-26cd-4fe4-a48e-73d80b02b4e2@suse.com> Date: Wed, 5 Aug 2026 15:52:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] x86/nmi: Misc style fixes To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-4-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805124525.105457-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1785937979-3BED6034-15F8B057/0/0 X-purgate-type: clean X-purgate-size: 1220 On 05.08.2026 14:45, Andrew Cooper wrote: > * Drop trailing whitespace > * Sort includes, dropping asm/mc146818rtc.h and asm/div64.h as unused > * Brace position, and types > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich albeit I would have suggested ... > @@ -310,15 +308,18 @@ static void setup_p4_watchdog(void) > if ( boot_cpu_data.x86_num_siblings == 2 ) > nmi_p4_cccr_val |= P4_CCCR_OVF_PMI1; > > - if (!(misc_enable & MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL)) > + if ( !(misc_enable & MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL) ) > clear_msr_range(0x3F1, 2); > /* MSR 0x3F0 seems to have a default value of 0xFC00, but current > docs doesn't fully define it, so leave it alone for now. */ > - if (boot_cpu_data.model >= 0x3) { > + if ( boot_cpu_data.model >= 0x3 ) > + { > /* MSR_P4_IQ_ESCR0/1 (0x3ba/0x3bb) removed */ > clear_msr_range(0x3A0, 26); > clear_msr_range(0x3BC, 3); > - } else { > + } > + else > + { > clear_msr_range(0x3A0, 31); > } ... to instead drop the figure braces here. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 13:55:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 13:55:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383529.1626805 (Exim 4.92) (envelope-from ) id 1wrc5g-0005yB-UH; Wed, 05 Aug 2026 13:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383529.1626805; Wed, 05 Aug 2026 13:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrc5g-0005y4-Rc; Wed, 05 Aug 2026 13:55:28 +0000 Received: by outflank-mailman (input) for mailman id 1383529; Wed, 05 Aug 2026 13:55:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrc5f-0005xy-TG for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 13:55:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrc5e-00FCef-Va for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:55:26 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7340c7-2eae-0a2a0a5409dd-0a2a4509e32c-18 for ; Wed, 05 Aug 2026 15:55:26 +0200 Received: from [209.85.160.51] (helo=mail-oa1-f51.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7340cd-be1a-0a2a45090019-d155a033c9d9-3 for ; Wed, 05 Aug 2026 15:55:26 +0200 Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-44cedfaab6bso490880fac.3 for ; Wed, 05 Aug 2026 06:55:26 -0700 (PDT) Received: from spider.bream-herring.ts.net ([103.252.203.158]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4599e5b7ec1sm2484235fac.12.2026.08.05.06.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 06:55:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785938125; x=1786542925; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=u4KVtir626gFVd35a54C+CtXHXFocgfKtNH4N3LL1vI=; b=JelmxEaNquBW0vHspdLQnmoyvaRtvZC5kJhF2vKJAh3lmmnqknhgRy0DfydtS+7lpw RLypQpMZ0P/NC21jZtiFS3aal+wq/Cs+9Yx3YRjLPiIDi22t0OGkUcrgKuAKPVews5NM oxkd96wLeMw5ZDDTwLfu6DTH/9dXthe/f8Fwl0F6G+3vJ0h9gp+S+wLAQT1+8ZQTD+xb wX2ckwP4EKVGbimyevz8/Cr8RrPLSy4HyzOIiR85BFGlMGJNjY4r5TMvER9pxArTX0na oo/r3OZpRm5LlO69QZYbJ0r5AmuchBCs/pHikRieSNQjAgK6I5AVwvOxCsVWJRAYrm+d EEYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785938125; x=1786542925; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=u4KVtir626gFVd35a54C+CtXHXFocgfKtNH4N3LL1vI=; b=XyREivLMG9eqnoRmjbt5dHNUQXuJb/ixs1KnnvTmbaHTeTrAx+UTuRtXikFsJcULh1 4pyqdCCF1Q2AmiZkU7/k3/w42XN0kLhFD/ORd7su8PXGO/W9V/WPFFHoMqt2klB86Wwi U44jUc4QZ9YNtYX6volaiLVYbEY2jEUxJgLsUkYGuZYImULeW+wSdrezay+mbjcgEAx3 sSBnfxB3XQSCDhEMrEPf+6mmCwM0nTDSD+ZmHy8iUMhT6SuhsRWXk5gRkA6ewWuU4J5z vm8rfRO7Jjrw40h690Z29i/hgcfPXg0mRoC/If9KgTmbd+UK1tdaAICJhsVgqA/kdIKc 0DdA== X-Gm-Message-State: AOJu0Yy7XVuu4JkGgf32zIhMoQ2tgwGFrUubpKPSYxCPfKwD8QhWG1kF bzGrugBHUjkcx/sIVqKr8ocY+qcWJbzEKVK0EPOLo+nGjlDz+gDAT/Pabz4oa0Mb X-Gm-Gg: AR+sD11NSSRAs/plcZ9++WU4ozN2j0rfHABBHWtzhO3E6+x0CqoZ/vtB6u6So+emLcD Ssl1P/p6bGT9UDvAiQ0/oQgtJl//xZe+Nr9IFZyyoFWIY1DafYRfnfCfL2GyPzY4GM9bzcECMjG CIGBUVoRC0tZqF0dISCbPg2G+8fqn65MzA3ekqYL+dCqFwA6WMMc+YmzHONWXJvJRhHRPSw/Rlg L+Vord9tTYVZsKAQfRoDgE0dsPK6gIWNweordpApAqo+wj4sKYnpUz5dPA16mxjAl2ygXQYsyd3 9xj0jd6KuaZW1OSN7k6w9BGILPwxTYhxAyio+cPpwp1lo81kAdyRFUWEjo8L5tH9L+BINPtwBB5 vNCCQHbsewo8QW8x5o+VMihHLncfoYh65YQNurrNRA6rXof9ZQQV75GrIyakthFFUn6g5fP1/9z AIBULk0fczEBmjgGAYtd0kj+8U1cFyLJW5UfPmnhlfEbILomznxMZ0um2j9CJmRwVUM5EY/vM10 NiSSd/keUfDxYJ4d19yWOt/zCqF8Dx3i9SF1lq9wAF5q0dY4UDUWDp51ktknfZJ5lVhlbutgOXK 1GCxfuAwiRLaIBybYjkbiTUIUwWPPJDaCiUJ0dJbs6U/KlecdWuf42LqgoG15YqF X-Received: by 2002:a05:6871:7996:b0:448:aaaa:6b93 with SMTP id 586e51a60fabf-4599f1246bamr3533288fac.17.1785938125108; Wed, 05 Aug 2026 06:55:25 -0700 (PDT) From: Matthias Goergens To: xen-devel@lists.xenproject.org Cc: anthony.perard@vates.tech, Matthias Goergens Subject: [PATCH] tools/xentop: reject invalid --delay and --iterations arguments Date: Wed, 5 Aug 2026 21:55:21 +0800 Message-ID: <20260805135521.790750-1-matthias.goergens@gmail.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785938126-BE4DB034-15ED710E/0/0 X-purgate-type: clean X-purgate-size: 4483 xentop parses -d/--delay and -i/--iterations with atoi(), so invalid input is silently accepted with surprising results: a fractional delay such as "-d 2.5" is truncated to 2; "-d abc" parses as 0, which in batch mode turns the output loop into a busy loop; "-d -1" wraps to an effective delay of about 136 years; and "-i 0" (or any unparsable iterations count) decrements an unsigned counter from zero, running for about 2^32 iterations. atoi() also has undefined behaviour on out-of-range input. Parse both options with strtoull() instead, and reject anything that is not a plain decimal integer in range: a sign, a fractional part, trailing junk or overflow now produce an error and exit rather than a silently wrong value. Compatibility considerations: "--delay 0" remains accepted, since updating as fast as possible is a plausible deliberate choice and works today; "--iterations 0" is rejected, since running the loop 2^32 times cannot be what the caller meant. The interactive 'D' prompt already validates its input and is unchanged. The only previously useful invocation this breaks is a fractional delay, which now fails loudly instead of silently rounding down - which is the point of the change. A patch documenting the --delay truncation was posted in 2010 but never applied: Link: https://lore.kernel.org/xen-devel/01ea26d2420e3562eb30.1292604768@chilopoda.uk.xensource.com/ Signed-off-by: Matthias Goergens --- Tested by compiling with -Wall -Wextra (no new warnings) and by running the parse helper, extracted verbatim from the patched file, against a 19-case input matrix covering both the accepted and the rejected inputs listed above. Not run against a live Xen host: the change is confined to command line parsing, ahead of any hypervisor interaction. Happy to add a CHANGELOG.md entry under "Changed" if that is wanted for a tools CLI change of this size. docs/man/xentop.1.pod | 5 +++-- tools/xentop/xentop.c | 27 +++++++++++++++++++++++++-- 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/docs/man/xentop.1.pod b/docs/man/xentop.1.pod index db64ceb..13f3f13 100644 --- a/docs/man/xentop.1.pod +++ b/docs/man/xentop.1.pod @@ -27,7 +27,7 @@ output version information and exit =item B<-d>, B<--delay>=I -seconds between updates (default 3) +seconds between updates (default 3); must be a non-negative integer =item B<-n>, B<--networks> @@ -55,7 +55,8 @@ output data in batch mode (to stdout) =item B<-i>, B<--iterations>=I -maximum number of iterations xentop should produce before ending +maximum number of iterations xentop should produce before ending; must +be a positive integer =item B<-z>, B<--dom0-first> diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c index addb1c7..c7fb4ca 100644 --- a/tools/xentop/xentop.c +++ b/tools/xentop/xentop.c @@ -23,6 +23,7 @@ #include #include +#include #include #include #include @@ -1297,6 +1298,28 @@ static void signal_exit_handler(int sig) signal_exit = 1; } +/* Parse a numeric command line argument as a plain decimal integer no + * smaller than min_val. Anything else - a sign, a fractional part, + * trailing junk, overflow - is fatal, rather than being silently + * accepted as a wrong value the way atoi() would. + */ +static unsigned int parse_uint_arg(const char *name, const char *arg, + unsigned int min_val) +{ + unsigned long long val; + char *end; + + errno = 0; + if (isdigit((unsigned char)arg[0])) { + val = strtoull(arg, &end, 10); + if (!errno && !*end && val >= min_val && val <= UINT_MAX) + return val; + } + fprintf(stderr, "xentop: invalid %s argument '%s': expected a %s decimal integer\n", + name, arg, min_val ? "positive" : "non-negative"); + exit(1); +} + int main(int argc, char **argv) { int opt, optind = 0; @@ -1347,7 +1370,7 @@ int main(int argc, char **argv) show_vcpus = 1; break; case 'd': - delay = atoi(optarg); + delay = parse_uint_arg("--delay", optarg, 0); break; case 'b': batch = 1; @@ -1356,7 +1379,7 @@ int main(int argc, char **argv) show_pcpus = 1; break; case 'i': - iterations = atoi(optarg); + iterations = parse_uint_arg("--iterations", optarg, 1); loop = 0; break; case 'f': -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:02:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383537.1626814 (Exim 4.92) (envelope-from ) id 1wrcCB-0007rJ-Jn; Wed, 05 Aug 2026 14:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383537.1626814; Wed, 05 Aug 2026 14:02:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcCB-0007rC-Gh; Wed, 05 Aug 2026 14:02:11 +0000 Received: by outflank-mailman (input) for mailman id 1383537; Wed, 05 Aug 2026 14:02:10 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcCA-0007r3-Ik for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:02:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrcC9-000nzY-Hq for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:02:09 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734257-bab6-0a2a0a5309dd-0a2a45028bae-40 for ; Wed, 05 Aug 2026 16:02:09 +0200 Received: from [209.85.208.45] (helo=mail-ed1-f45.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734261-6ca4-0a2a45020019-d155d02dd484-3 for ; Wed, 05 Aug 2026 16:02:09 +0200 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6a144c8eea2so1184316a12.0 for ; Wed, 05 Aug 2026 07:02:09 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff34da5c4sm888240f8f.5.2026.08.05.07.02.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 07:02:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785938529; x=1786543329; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UWqyquH56toU5J0j8tnzTyZp4IECkHmUybItXJUtOtc=; b=M9sZVGnhRQC4dmFZQPUgxSbo+54VMdcdVLVEdb3p2z66gG9IhilIneQetjz+UDkru8 cZGGVhHTYDczbq9x+BL1ztYurFNewo2i9OM5yy3NTzEMBWb/6Se8EvGZK7AIJPDaUNV1 /DcMrf8rsxYVjr1torrfNOjGUvWxqEmPAI8JHaFOcOLvOJGq+ZOY04njgsYjNV1epFp4 hGhF4fC+BdTDfCfr8Ch/QVehLJPJuDsKd/19W20/6siWfFYt5kxP2gwpZCrH/htWKe8Y RQleUAaupVKczsvOIVaIsWrGhhp/zR57YoQpSIVAj04X+M4l/7E8oYd9p1NLBtaRJ5rU ONoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785938529; x=1786543329; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UWqyquH56toU5J0j8tnzTyZp4IECkHmUybItXJUtOtc=; b=tB2TAPtNO5htYWdXpisGdkzrsA4LDQCs6WvVuzvzx5SP8ibYnAkv1kgPMGfPz46dKF Hs028Irk5bfMNV+iTGWyQwWIQgFiF876vjMVvVPAZse3SIDs86Mr7a6mFEg16CTaSFlQ slXnA4k4oB9Y+vRVggzWysDONisLo6RklUer3GW+qjeiHFb4aioCICA8DbtQbI4lxPz7 J9CvmQm9nN79xSv7IMd/1cMZCoGDHFd0NvHCV5SF9aXYj+0jd6m1kANu9t+dK5srZjM/ 2282jzNAPiRQ+G8Qkj061tpEC7TONEwz43koBT+fevGGDKVS8wOLeIXgHq00+MAshIf9 VHRw== X-Forwarded-Encrypted: i=1; AHgh+RrXSWL2uTgGbQTcEv4MYASRtCsbVeduYE6m/gN37cnmrWl75LGCDjiBA5c7cHHCEayVkuD/N5uXR/M=@lists.xenproject.org X-Gm-Message-State: AOJu0YzeSUqxxkth2S/k2oOKpe/y1H3NAl3DmOpMg0/8ZlWBNKJH+jnD y6aHQMcsW4faF8Fxj7mNVVDHPzGt55ljXlw3Z/Lqfd5J1dL1Y40+/+jmqGO2HbboMg== X-Gm-Gg: AR+sD138xgcpd5XqEmssjJfHf0nMMBh8oiuOtVFI6hOMCPKWx0kwFQVUfGw5Sal3Ip1 0708zlL4dLAEAxunOCpFy/I9zP8rSbdRBzqiv0uDLeIwSgmGXl1BuawNOmyjTtqXfuXFG/X/9KQ GAH7eiQW2gC2dmKDY9ZFE16RWrwf6Boju7YW+q75CQdox4u7Ht1BKHucnJsksbCsX4vEEzB41T7 ci2T9ZVhbKFbpzxh90ermlza0KXTuknM/6j2S12nHNvJPf5U2JL80q2SPr7MA6eEx7RjRWPcSqI fnRf3wa8wmsb2PHf4NAtPYkHSLx/pPtElEmb0sRWxTleDZ0N+Len/gvq3sgw6u17djdkKWLuz+8 M3VW3N8i2C9d9ikEzpGfHEWa8otan+F34nRVK1brU2M+lES/OtiRANRUJouaMPOWmHM+h1FxAeT dUwk+1Wn4iz2nn7/g7EC4iCF29q2yKcVX9wQNo2F/Cb/Kb/gZVqwStffPh/UlfhcYijOYL7hTvS UVYIoQ4KkOXJM1BMKKgzoX1esnjV8pnavIK1tJAZsPJv628XoEYBsGepiAWI7g= X-Received: by 2002:a17:907:961a:b0:c15:b67b:523e with SMTP id a640c23a62f3a-c2039e67177mr309632566b.19.1785938527924; Wed, 05 Aug 2026 07:02:07 -0700 (PDT) Message-ID: <13568d23-b742-4a38-89d1-d49b761fd88c@suse.com> Date: Wed, 5 Aug 2026 16:02:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] x86/nmi: Check MSR_MISC_ENABLE for all Intel platforms To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-5-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805124525.105457-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1785938529-305C52AC-BFDF0866/0/0 X-purgate-type: clean X-purgate-size: 1296 On 05.08.2026 14:45, Andrew Cooper wrote: > @@ -347,6 +343,14 @@ void setup_apic_nmi_watchdog(void) > break; > > case X86_VENDOR_INTEL: > + misc = rdmsr(MSR_IA32_MISC_ENABLE); > + > + if ( !(misc & MSR_IA32_MISC_ENABLE_PERF_AVAIL) ) > + { > + printk(XENLOG_WARNING "Intel Perfmon unavailable\n"); > + goto disable; > + } Please can we avoid "goto" when that's easily possible? You can use "break" here instead, and ... > switch ( boot_cpu_data.family ) > { > case 6: > @@ -355,7 +359,7 @@ void setup_apic_nmi_watchdog(void) > : CORE_EVENT_CPU_CLOCKS_NOT_HALTED); > break; > case 15: > - setup_p4_watchdog(); > + setup_p4_watchdog(misc); > break; > } > break; > @@ -363,6 +367,7 @@ void setup_apic_nmi_watchdog(void) > > if ( nmi_perfctr_msr == 0 ) > { > + disable: > printk(XENLOG_WARNING "Failed to configure NMI watchdog\n"); > nmi_watchdog = NMI_NONE; > return; ... we'll still end up here, as nmi_perfctr_msr won't be written. Preferably with that change: Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:03:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:03:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383544.1626823 (Exim 4.92) (envelope-from ) id 1wrcDO-0008JH-Sx; Wed, 05 Aug 2026 14:03:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383544.1626823; Wed, 05 Aug 2026 14:03:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcDO-0008JA-QA; Wed, 05 Aug 2026 14:03:26 +0000 Received: by outflank-mailman (input) for mailman id 1383544; Wed, 05 Aug 2026 14:03:25 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcDN-0008Iy-C6 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:03:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrcDM-00FEQe-LX for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:03:24 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73429e-2eae-0a2a0a5409dd-0a2a4502b42e-40 for ; Wed, 05 Aug 2026 16:03:24 +0200 Received: from [209.85.218.54] (helo=mail-ej1-f54.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7342ac-6ca4-0a2a45020019-d155da36f0e5-3 for ; Wed, 05 Aug 2026 16:03:24 +0200 Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c1fbe461f59so164280366b.2 for ; Wed, 05 Aug 2026 07:03:24 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2036422825sm125182766b.43.2026.08.05.07.03.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 07:03:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785938604; x=1786543404; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ZELl0gN6/oR6iSAb1frKORNtawYItp/FeUnGx75S0aY=; b=BWbUxHQc0M+iRrkLJvu/Z70QAL+UhyXJ3dyL+OxDsdgIJJJ2Ji+1m4VbVYqnbiJQYN C+3RlKubmlUTqQw6ewtkEaAncPBkvIwTz2d0tGIjBzHT7etfZ0kiZ6zsoucmDAyRJClv rMU7VUTL9SR1+Pawj4q99ESxKF1jtizsZfpAWX3W2A8PX3BfaPiI8nF0J5apWPRiDvXW p3dqHP2U0Wvwftngdb4bzFmi2Zte5J9Xb4+8dpCCUaGPSjeys/9PAYUSSx0+RDJ/i7Gl OVYpm1oYuM2bXPIZU/Ms6IzgZ6UgbttT0uxTDn2VgvTqQA7a/N3EuxOZkjVDjt9srtsR BgJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785938604; x=1786543404; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZELl0gN6/oR6iSAb1frKORNtawYItp/FeUnGx75S0aY=; b=NpF/AxW4Tj3/OIE8IolFuulzKjsgreFhiHlUHffwpgGK8n6rI7E0xc0vSqAJ56Rzj4 c03kb5VutiHm2/eL0RdRCypvleO5q+XMf697ksNf0wXefu/HDmkZuN4RFLKRW+l9gEhc 2a5BjX0DjyNV6j7ZYtqCNv6MMA/50plbU/dikDcZ9insRA9tN9+rWXovvbmBERBAGoON 4AjzAuC7/HtaHiiphVOl3gKUUKN/Gb4MEVrh67htennLf975dVJtRMCRTbq2JALHNWr1 s5zGt50+1Q/LClYcPn+4u323Xf1tmRkUQvMM365Bg1OIG7QjVMLzzh9cWVv/SKTjcChm 4sSA== X-Gm-Message-State: AOJu0YxHEh3JJ1d24iHlubzWzgPe5FDaLRYIEJHUaHSgNCkSQ7D+3muU RYWb3L3jMVdiho6AFmtH5LDu+TJ7TwvBfY8vbJ9Fze+5WGy3G/3TvZPDwPBWnpJzpgw= X-Gm-Gg: AR+sD112Wwp0cDKq4py6JvYcB/BSCQHhsPypqCkSOmuoNG9679bEio6pzLgoVKvwW/1 pdIaZSMi7zSgzdKbUDaXql6bIFNVxTk/pDNzGJoyJpQxqZrk1itR4pLMYQ84K1Xm3J4tTHDFckC ONmc7AEp5vOzp2OgwcgbQ/eBjPXqzi/Pqk0T3YuoENmRO1Lv2+/XWU59qr2Ht9pX12XTsoe+MtM 7dbV/4cWP+qGjGOkirLaQZUqiUAIxFffsXn1Y+i3nMl/0RIXdS4HWLengeVAzF/UJ65fBdiiKzv X7201AvG9s8vNbkdUp2r3bsIhwPLtO02Mzu8Vq2m312oJzeLk2/zxCnfivbqRpYtaYzs9ezlKZA 8U9K9BJIG3RYZt2B6D1v32sbqV4Y+hBrVWRujUCctnGlAfvhBDhlkLmd56pkJlWdthGb95dp28d HLomw+nh00NGCcqxqvkpaPD4qXEjmgUcXR9Oj0/H5bKWwYX6Qn15l9wCgncpRy3r25UQZPeIyyg GT4x2CiV5k9wwacBqCdVXUHLq94mDBTAWAm4czTdN2lNqO974YX6tZE1+XdTvv1Fhte611mmnmy VJn3YoPSHE80g70= X-Received: by 2002:a17:907:988:b0:c12:74af:51f3 with SMTP id a640c23a62f3a-c2039d1fb0emr364693266b.6.1785938603408; Wed, 05 Aug 2026 07:03:23 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 16:03:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) To: Jan Beulich , George Dunlap Cc: xen-devel References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Tz3rseFSLpEZJ5KWjMvgU50I" X-purgate-ID: tlsNG-720697/1785938604-303C42AC-6804DC65/0/0 X-purgate-type: clean X-purgate-size: 9164 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Tz3rseFSLpEZJ5KWjMvgU50I Content-Type: multipart/mixed; boundary="------------qWmVQ8kIsdZu0Frl0vYDN0ec"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich , George Dunlap Cc: xen-devel Message-ID: Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> In-Reply-To: <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------qWmVQ8kIsdZu0Frl0vYDN0ec Content-Type: multipart/mixed; boundary="------------f447bij2vWIY0iRtuYHiak0h" --------------f447bij2vWIY0iRtuYHiak0h Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDguMjYgMTU6MjgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNS4wOC4yMDI2 IDE0OjE1LCBHZW9yZ2UgRHVubGFwIHdyb3RlOg0KPj4gWW91J3JlIGFza2luZyBldmVyeSBw ZXJzb24gd2hvIHNlbmRzIGFuIGVtYWlsIHRvIHhlbi1kZXZlbCB0byByZW1lbWJlciB0bw0K Pj4gdGFrZSBhbiBhY3Rpb24gYmVmb3JlIHNlbmRpbmcgdGhlIG1haWwNCj4gDQo+IFlvdSdy ZSBieSBmYXIgbm90IHRoZSBmaXJzdCBvbmUgdG8gYmUgYXNrZWQgdGhpczsgeW91J3JlIHRo ZSBmaXJzdCBvbmUgdG8NCj4gaGF2ZSBhbiBpc3N1ZSB3aXRoIGJlaW5nIGFza2VkLCBiZXlv bmQgc29tZSBjb21wYW5pZXMnIElUIGdldHRpbmcgaW4gdGhlDQo+IHdheS4NClRvIHB1dCBp dCBkaWZmZXJlbnRseTogdGhlcmUgaXMgYSBzdGF0ZW1lbnQgb24gdGhlIFhlbiB3aWtpIGFz a2luZyB0byBzZW5kDQpvbmx5IHRleHQgZW1haWxzIHRvIHhlbi1kZXZlbC4gSSdtIG5vdCB0 aGUgb25lIHRvIGFzayB0byByZWxheCB0aGF0IHJ1bGUuDQpJZiB5b3Ugd2FudCB0aGlzIHJ1 bGUgdG8gYmUgZHJvcHBlZCwgeW91IHByb2JhYmx5IHNob3VsZCByYWlzZSB0aGlzIHRvcGlj DQpmb3IgZGlzY3Vzc2lvbi4NCg0KSU1ITyBpdCBpcyBmaW5lIHRvIHF1ZXN0aW9uIHN1Y2gg Z3VpZGVsaW5lcywgYnV0IGp1c3Qgc2F5aW5nIHlvdSBkb24ndA0KYmVsaWV2ZSB0aGV5IG1h a2Ugc2Vuc2UgYW5kIHRoZXJlZm9yIGlnbm9yaW5nIHRoZW0sIGVzcGVjaWFsbHkgYWZ0ZXIg aGF2aW5nDQpiZWVuIGFza2VkIHRvIG9iZXkgdGhlbSwgaXMga2luZCBvZiBydWRlLg0KDQpU aGlzIGlzIGp1c3QgbXkgb3BpbmlvbiBhbmQgSSBkb24ndCB3YW50IHRvIHdhc3RlIG15IHRp bWUgZGlzY3Vzc2luZyB0aGlzDQphbnkgbG9uZ2VyLg0KDQoNCkp1ZXJnZW4NCg== --------------f447bij2vWIY0iRtuYHiak0h Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------f447bij2vWIY0iRtuYHiak0h-- --------------qWmVQ8kIsdZu0Frl0vYDN0ec-- --------------Tz3rseFSLpEZJ5KWjMvgU50I Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmpzQqoFAwAAAAAACgkQsN6d1ii/Ey+O 2wf9ErHqLOST1ON4ayiBv8FDliAxo/xCj2g91Q/mMQTkMhPCxRpfdIOmB38aOtHBKEX3XhF6YN9G c5sXuOeyhVXVETK6nCI/efSts4GczH7ny68TdGQOH7nkc18OrXPLLZF9rLVE6IJFa1QEh3BqlTqK YnK4TfWcjNkk40/13YEDqWijc2+aBsE7R1qiYCBV7vT2DtWuHMcF8OMNMnre+1yX/h7lzYyvRxVn uAy6QsNq+7dEjOwCA9DPXbWooOK+cMPPVdVqIdQ2LP298Dte+pDATlq+jw4wfj5SdrQk+vJ85Fph a+rgxKvjQ7xlVQvE605v2k0lypyx2GEJTgoQ1jjqSw== =SKAW -----END PGP SIGNATURE----- --------------Tz3rseFSLpEZJ5KWjMvgU50I-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:04:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:04:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383551.1626831 (Exim 4.92) (envelope-from ) id 1wrcE2-0000KJ-8F; Wed, 05 Aug 2026 14:04:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383551.1626831; Wed, 05 Aug 2026 14:04:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcE2-0000Jw-5c; Wed, 05 Aug 2026 14:04:06 +0000 Received: by outflank-mailman (input) for mailman id 1383551; Wed, 05 Aug 2026 14:04:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcE1-0000Jm-T3 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:04:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrcE1-006NBO-2c for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:04:05 +0000 Received: from mail-lf1-f54.google.com ([209.85.167.54]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wrcE1-00H4TB-1a for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:04:05 +0000 Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5b0117d49dcso1282438e87.3 for ; Wed, 05 Aug 2026 07:04:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version; bh=3qLiuJFGpN11+MdjblulRfLKk+aAgO7+B5B9IdpRmA4=; b=0EAC0Wfaz2J7xsn6HBHrMcuE75 fKeBxfxoCC1N7wHRpy2hcaqbCC2YKyg3Zr5wcvA7OAdAT9L4m1LgpLlsCwEvTw+ro2jtc1XnlThuF J08MAiHvWjQtLxZ6MSOmJ+S17XZp/IHEFp/LHYC/ycqjY7+sp5aOiKQ9xKTRWHGSPy14=; X-Gm-Message-State: AOJu0YypqaiMLIOlE2MQ6NudXoVyacOl/DCRSqj7VBzuwkejwcPkSaPU 4Q+0wsOAtFHEPaVmQ5/Brl2DCPcUi/h6/oviPQQk/o0NM//TgQpp+lZHX++J5tOwPZ+CF279EO9 aFiMX3G4cXG5uWBbgI9NRJggRGpsgr8k= X-Received: by 2002:a05:6512:1327:b0:5ae:bc4f:d631 with SMTP id 2adb3069b0e04-5b2f4cd42dbmr1077274e87.44.1785938644416; Wed, 05 Aug 2026 07:04:04 -0700 (PDT) MIME-Version: 1.0 References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> In-Reply-To: <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> From: George Dunlap Date: Thu, 6 Aug 2026 00:03:52 +1000 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mzd6dBticIODYK7r_o4tlKgLtoPNRNzITXiNfwT22XduMBsW7Lo1OjTvAk Message-ID: Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) To: Jan Beulich Cc: xen-devel , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Content-Type: multipart/alternative; boundary="0000000000007dc03f06584d3e53" --0000000000007dc03f06584d3e53 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 5, 2026 at 11:28=E2=80=AFPM Jan Beulich wro= te: > On 05.08.2026 14:15, George Dunlap wrote: > > You're asking every person who sends an email to xen-devel to remember = to > > take an action before sending the mail > > You're by far not the first one to be asked this; you're the first one to > have an issue with being asked, beyond some companies' IT getting in the > way. (As to the latter point, I'm already combining my observations on > xen-devel@ with those elsewhere.) > And indeed, if I were sending to a community I was new to, I would just suck it up. I'm pushing back for two reasons: first, it wasn't an issue for the previous 18 years, so I'm trying to figure out why it's an issue now; secondly, whether it's a big barrier or not, it adds a barrier, which seems to me unnecessary. I do feel a bit weird starting an argument about this on my second or third public post coming back. But, the arguments put forth to support the "text/plain *only*" position don't seem to me (at the moment) to be justified; and in this community I'm in a position to push back in a way a newbie would not be. > > because your MUA isn't handling > > the standard properly. Is that really reasonable? Couldn't you tell > > Thunderbird to ignore html and only render text/plain? > > Both questions go together: text/plain as the only content is (not just b= y > us) being asked for because that's the form known to work virtually > everywhere. Wanting your mails to be properly handled at all receiving > ends is - I think - not only reasonable, but also in your own interest? > As I said in a sibling thread, the fact stands that (as far as I can tell) Gmail is following long-established mail conventions, and Thunderbird is not. Juergen can read my mail just fine. *His* MUA generates somewhat mangled responses, specifically because *it* is using HTML rather than text/plain; I don't see why that should be my issue. -George --0000000000007dc03f06584d3e53 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Aug 5, = 2026 at 11:28=E2=80=AFPM Jan Beulich <jbeulich@suse.com> wrote:
On 05.08.2026 14:15, George Dunlap wrote:
> You're asking every person who sends an email to xen-devel to reme= mber to
> take an action before sending the mail

You're by far not the first one to be asked this; you're the first = one to
have an issue with being asked, beyond some companies' IT getting in th= e
way. (As to the latter point, I'm already combining my observations on<= br> xen-devel@ with those elsewhere.)

And i= ndeed, if I were sending to a community I was new to, I would just suck it = up.=C2=A0 I'm pushing back for two reasons: first, it wasn't an iss= ue for the previous 18 years, so I'm trying to figure out why it's = an issue now; secondly, whether it's a big barrier or not, it adds a ba= rrier, which seems to me unnecessary.

I do feel a = bit weird starting an argument about this on my second or third public post= coming back.=C2=A0 But, the arguments put forth to support the "text/= plain *only*" position don't seem to me (at the moment) to be just= ified; and in this community I'm in a position to push back in a way a = newbie would not be.
=C2=A0
> because your MUA isn't handling
> the standard properly.=C2=A0 Is that really reasonable?=C2=A0 Couldn&#= 39;t you tell
> Thunderbird to ignore html and only render text/plain?

Both questions go together: text/plain as the only content is (not just by<= br> us) being asked for because that's the form known to work virtually
everywhere. Wanting your mails to be properly handled at all receiving
ends is - I think - not only reasonable, but also in your own interest?
=

As I said in a sibling thread, the fact st= ands that (as far as I can tell) Gmail is following long-established mail c= onventions, and Thunderbird is not.=C2=A0 Juergen can read my mail just fin= e.=C2=A0 *His* MUA generates somewhat mangled responses, specifically becau= se *it* is using HTML rather than text/plain; I don't see why that shou= ld be my issue.

=C2=A0-George
--0000000000007dc03f06584d3e53-- From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:21:06 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:21:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383569.1626842 (Exim 4.92) (envelope-from ) id 1wrcUO-0003ms-Mq; Wed, 05 Aug 2026 14:21:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383569.1626842; Wed, 05 Aug 2026 14:21:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcUO-0003ml-IY; Wed, 05 Aug 2026 14:21:00 +0000 Received: by outflank-mailman (input) for mailman id 1383569; Wed, 05 Aug 2026 14:20:59 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcUN-0003md-J4 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:20:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrcUM-004Azg-W2 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:20:59 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7346c1-e002-0a2a0a5209dd-0a2a4506d2d2-42 for ; Wed, 05 Aug 2026 16:20:58 +0200 Received: from [209.85.221.47] (helo=mail-wr1-f47.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7346ca-195a-0a2a45060019-d155dd2fe8e4-3 for ; Wed, 05 Aug 2026 16:20:58 +0200 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47f6609c657so532307f8f.2 for ; Wed, 05 Aug 2026 07:20:58 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec23e5efsm9339266f8f.27.2026.08.05.07.20.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 07:20:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785939658; x=1786544458; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ztlQGn8DvKCCDgciuvr4MBrBLBlPYBDCgdZ1t25z4Cw=; b=ayVM+D2Kxo4T09BKLOTN2LqLnpH42WWy7+KKpunvyIvUBVWs5trAZBZiHJ71LtcRvZ JoDxuDJAWMG3RvjhE3dvdf5+a7WQamMS61K7qOOg3fzSM5nt4h9BAPffQhV4CV7ELY2M ek/lqSFbz7jdolg4MISIs7sJlVGEuVc2XA4kSJHrZhPuN15mPQVRslKIn9ntBu1htGr2 BEr+0rrCIiORbigntd3FzGr9nykPRDDvdGmyusCl49vYXp7j5ry1U81bofubEwl5lBMx y9grbC/+NUf/bbI8aZg+pBCp4x/Qgff34W0ZKn82sv8VXNiZI1H+8FmNcB9NSH5QQlmh VjEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785939658; x=1786544458; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ztlQGn8DvKCCDgciuvr4MBrBLBlPYBDCgdZ1t25z4Cw=; b=MR+R40dwlBhsP2qqSoc8uoLIpKJxUPg42PQ64w3r9r5G19bBMGhcIlOKlmuXaceDpW eXNAEgQZidQ5V7h7KJXuWJ58qoKNSsog/Ejrnkf8VFAQXahxOY7v4tTFIvILT5hfo6RH KRNZpI9aCass5M/4crcNOw1M7Ro9I81R9pB72CWDgGR6RUHcid7eIGPHKBkRXPku+uUG Kw3Ose2e/6MTBHmfQOcOcqiVcmnOr6/3vecrqTqlPP8BeNmINspq/4PvdceW/j7Y29vF aDNbpx7g6ObVRaBmeTSc1vjnk1jiiak4e9dSIOTz+NBgHwW3YKwWq+2aGnpRWFoBFK/F MZHQ== X-Forwarded-Encrypted: i=1; AHgh+RqBp1P4A3S3svoAOgYdRYc1DQ8bFql9OuO7h9lW5o26hJSOcfI4HceRUd1nspFLC885QPyN1EAxmPs=@lists.xenproject.org X-Gm-Message-State: AOJu0YyuP9LqLhl5+qCpEN6B0tu5MkA09ivr4UNRCP2PHTfLS2JqRYrb RpkAuTrs/Y0QwJ0Er7dBFT3x9ApjW4dNJuSRgrrUo9/Ora1Ydn7OQVdBSf3IX1OE7w== X-Gm-Gg: AR+sD11BMzrcv2krFbha6zdtjOMrC9G1K3yK88cfAGmYStrXQigcHXt1+kAmNkAEs/T GJeWUIeAiuAmA9GMbHTeSpB5wM7sCimKOqFNn54RveQ/7afYF3/HGnXAPi0BkJsIwpYjimN3YJq zFthOVJsm0MABH4FThZLVr54/sN/SxxIV4eJqu2qqWnKO/0h8LKGeFdeWMR4yIHtxMnfahdQBuE rxG5SNj2vNFMf0lMTpFlai8Frfcy+ruWLsIBdtF2UztTVG+tJ3BBpDpj99Z3r6Pp2ychdMdP7x7 9eHNIwoK7dMIX6g7jYjz8M2INura6eVBu5bxd7Ys+icIYU2QficQkVF0FdbERwBTTW2/E3rAzt/ X2BmmCSlMBRpM0/mC4PL6Z3YVztvLttc1Z8WfM72UqbAv8v/wu1jkzPi67rj+NaAQX37cii+nxt 13fxfD8TRABy8Mx747Xz+MVoFktHjQ9NXURAmc8kleku2sm8dXQ5NduPT2d6LXy3miOLUUq+W9S ZKr+recQgFQRv5heoy2M5ZGAkEkNS8avaDR6GGAKRVDjkLdXSUs X-Received: by 2002:a05:6000:41d0:b0:45e:73eb:5119 with SMTP id ffacd0b85a97d-47fec62ea74mr13286445f8f.22.1785939658244; Wed, 05 Aug 2026 07:20:58 -0700 (PDT) Message-ID: Date: Wed, 5 Aug 2026 16:20:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] x86/nmi: Don't configure EvtSel repeatedly To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-6-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260805124525.105457-6-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1785939658-FCA0477B-568236C7/0/0 X-purgate-type: clean X-purgate-size: 1224 On 05.08.2026 14:45, Andrew Cooper wrote: > In both setup_{k7,p6}_watchdog(), EvtSel0 is first zeroed, then written with > everything but the enable bit, then written with the enable bit. > > setup_p4_watchdog() is slightly more complicated, owing to what > appears to be a bug introduced by commit 2a2bd8de16b6 ("Clean up NMI > watchdog handler."), which causes a second bit to be temporarily > different too. > > The middle of the three writes is useless in all cases. Drop it. Spotting the 1st write in setup_p4_watchdog() wasn't quite as easy, as MSR_P4_BPU_CCCR0 (as passed to clear_msr_range()) has nothing to do with MSR_P4_IQ_CCCR0. Using unrelated MSR names there is as unhelpful as using raw hex numbers. > While doing this, rename the 'counter' parameter for > setup_p6_watchdog(). It is the event which is passed in; the counter > is always counter 0. > > No functional change. These sequences of writes almost look as if they were trying to cover for errata. Are you sufficiently sure there are none anywhere, for this to truly be no functional change? If so, ... > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:24:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:24:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383578.1626850 (Exim 4.92) (envelope-from ) id 1wrcXR-0004Kg-2h; Wed, 05 Aug 2026 14:24:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383578.1626850; Wed, 05 Aug 2026 14:24:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcXQ-0004KZ-Va; Wed, 05 Aug 2026 14:24:08 +0000 Received: by outflank-mailman (input) for mailman id 1383578; Wed, 05 Aug 2026 14:24:07 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrcXP-0004KR-Cm for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:24:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrcXO-00CYWN-PY for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:24:06 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734775-5cb7-0a2a0a5109dd-0a2a4507e9dc-46 for ; Wed, 05 Aug 2026 16:24:06 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734786-b4ea-0a2a45070019-d1558031b5bf-3 for ; Wed, 05 Aug 2026 16:24:06 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49557167508so9697765e9.1 for ; Wed, 05 Aug 2026 07:24:06 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a100e14sm171303405e9.14.2026.08.05.07.24.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 07:24:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785939846; x=1786544646; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vbRVw62g8SNCcV8AekHEQaKPLBlLD87oFEQk+G4hP3c=; b=NGODxzB3nbbe9lBKUiIF1N+KcS4w/U8muYTDKADsjlAiQpRBVU735XU1G+QVUm+pLT OxIhbeC71kQNYAQTPQrfwX64Ml3W4z7o0ftSaMvo3DnyILPVqSfzl7T2L8cb9mWIyUDJ 5mtg5qTUS/FuqNdY1D+P53A35xqr8VFo+NYwvswWrNoc2wWZ2K4/W+ugNmp4FBUmw2xS 4V8qf/7TcsWg0I9lHCsDzGqWB2oEUvbDH7Q49yIkg/4vjwm07d/F0fIeLNYBdX5anlQp Rt5Q1lxDKXoFAJkHPk9CtnYTSgH5JMOwps6AlNkruI9PbIlQg14R033Jn1HZplXpXoPE UfDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785939846; x=1786544646; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vbRVw62g8SNCcV8AekHEQaKPLBlLD87oFEQk+G4hP3c=; b=YQ2Uwd4cS0W74zUX641JxTk3AyAiGHFyLony0Q8GV7nc6ykFT0NgeAWx2BJTRa/tAY 6XXVI7DxqiZUWRk6bd4dbjzWxcPYNKqIroy7KSrklnZdEugP2wkEJPV+4JVGuMaIAen/ +uGYCswvSE8SDYnV8GEwnJ33iCvcmrzi/IFo0+8xNK4VfY0+msO79BGtbB98EDR2ahvD bEXLxx2QDP6ZFvMkXR06bV9Y11c8u/ljUI4hlbbRFNmgwhgAd8xuLr4UU9jFX68HI1VP xgPJ9T2rL+LZDqdMZzB36mrv8kl/4RFRwPLCf0wpKSNLMFQUCMJZrmJCQHXjv6gBHgGS CmrQ== X-Forwarded-Encrypted: i=1; AHgh+RqRwoF8DcezR/YLeiI0ubYzn8B0Fp1iNdWoS2+45RPBrjPsDYgqCH2fwu+pSp8vCtGYORyPH32R1H8=@lists.xenproject.org X-Gm-Message-State: AOJu0YyNYOxhSHnk4bdUbiquEE1m3PUbAt7Ie6TWJ8IAmqH5S6j09BYd mJvqeW7yGbqf5O5iIppfF/cjK+InUejuh/SRpFmaKde+9OFFpjl0lHT6yowtahJ4lg== X-Gm-Gg: AR+sD12cFfbd/TVGaGaQ6qDldMrThNDhOM0NgSvNqSM4HyPGMRnmi3BMlSaT2QOO+v2 MOCTMhp32SWk/gCq4MjNZW1F6bWfMvsUbRNnnnvcwy0pCn9K1uVnXNKw8zC3hfytwllg2nG8xUE XwCoVt/yuPh3FLEq0yoxn9eood5pbrtmrke6cX0qK69v3s5CczKzCTpbcJeJwpY8MWBYZgELvSR foUIN52L9Dn7Qmmxz2eDMI/1B00vM6wbR2MzJtQuU3l2pmsM+TNAdC1DWAWPOoy/voot/vkkirN lKJ4DilMwbdYIsvmuYWPukFFgSujNxvLj5gAaLBPwVd0sCvDsM2XKpNLZIwEMaXIFsUDXRCG55d 2tjpstn4BhL9SToITBxEJ3PNcd07iCVD6KqufatHZ3GGEZfYcJqUg4twZxZYLfVos0qeedN1XMN nCIELQ74LZ3ozgFFytrnvTfnQ41HlthplGOUPNCYgClS04XXNTgjqL6Wl8VXflF77pbqrYtGUOT GzKtwz6aakBhGZDhShXtQRHLxTElb08DG7ImWj9S+sI9sXXnCRt X-Received: by 2002:a05:600c:1d23:b0:499:51b8:d649 with SMTP id 5b1f17b1804b1-49951b8d652mr25870305e9.3.1785939845902; Wed, 05 Aug 2026 07:24:05 -0700 (PDT) Message-ID: <5a444465-1d4b-4618-825e-1be612408009@suse.com> Date: Wed, 5 Aug 2026 16:24:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 4/4] xen/acpi: Parse PPTT to initialize CPU topology To: Hirokazu Takahashi Cc: Mykyta_Poturai@epam.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260728050642.411240-1-taka@valinux.co.jp> <20260728050642.411240-5-taka@valinux.co.jp> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260728050642.411240-5-taka@valinux.co.jp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1785939846-A7CD7AE4-C3F38FC4/0/0 X-purgate-type: clean X-purgate-size: 454 On 28.07.2026 07:06, Hirokazu Takahashi wrote: > Parse the ACPI PPTT (Processor Properties Topology Table) to > initialize the CPU topology. > > For ACPI 6.3 and later, the ACPI_PPTT_ACPI_PROCESSOR_IS_THREAD flag > is checked to determine the presence of threading. For ACPI 6.2 and > earlier, CPUs are assumed not to support threading. > > Signed-off-by: Hirokazu Takahashi Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383600.1626864 (Exim 4.92) (envelope-from ) id 1wrd3A-0000jb-Ls; Wed, 05 Aug 2026 14:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383600.1626864; Wed, 05 Aug 2026 14:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3A-0000j6-Hh; Wed, 05 Aug 2026 14:56:56 +0000 Received: by outflank-mailman (input) for mailman id 1383600; Wed, 05 Aug 2026 14:56:55 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd39-0000gL-3c for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:56:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd38-00Cdp1-GR for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:56:54 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f2b-e002-0a2a0a5209dd-0a2a4501c102-14 for ; Wed, 05 Aug 2026 16:56:54 +0200 Received: from [202.12.124.150] (helo=fout-b7-smtp.messagingengine.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f35-5984-0a2a45010019-ca0c7c969577-3 for ; Wed, 05 Aug 2026 16:56:54 +0200 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 0A1B61D00141; Wed, 5 Aug 2026 10:56:53 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 05 Aug 2026 10:56:53 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:56:51 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941812; x=1786028212; bh=ZR1d1bGRuW 7PkpYXNT/MSUaHwUt8D8/XKZCozOxnmOo=; b=vRq70RxyIF7I4jufZwP/UbDIMa ae5kBZB/LeAG7dK2DBrpmeSZOsg7CZ1GXg8BG44IxbEjq0eUPc/+jjXOomdtw5CJ HuiMn+jxtn0GOFJt1mxf+oMZ+dKJfxr97mgmDHN4VKH9OSOjJBohJAuTWnqJSO/e WSjOiLshyq32RGc2TLXv6H1G+BIEcBkZlhmWeg3Hz9Fh+VGY0AF1gDqSJAR4neVI hQBjQXxSiNGpZNmu2RPJwOX4inygBJ+J6Z5eM0leAjSmMvawR97apwChuvVYJAq/ kguPg9dLaUsT8mZfjGElriKcsVSNyfA+6o0SURqQ3xOb9GZFxAiM1S3o5U/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941812; x= 1786028212; bh=ZR1d1bGRuW7PkpYXNT/MSUaHwUt8D8/XKZCozOxnmOo=; b=O cpOX6rtQ1SWfMcY2UsgEx6B7W8piD3gKamXRpE3RKInvXLrCILucVG4Ja0MtAYLg 8Kgd7Qz78Y7q92b29uIvzLdRwdaG7wIbRTAYr8Fpgv79G85Tn3zsUvtE9dnGioc+ Mef1MSv1sU91TWk/c82e+Aq6JCw1+5yVhExS7X5lSl13t7Ix75TeKA6Hg1kk59mv ax4k2Ywhzb9KrK22iirYwtpBo0er/nt2xz1kQgUtc/gVm+Ib3T04c2voaWr/7cwc YjsXxCSc6AN8028R/DwECp/taSnJxnDts+K6fH0+HQyd2Aas6e51u7mzf9e7Xt1n R9chyGGrqFxFuyWwX5p8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFg5HWH/RDqdPpR88i/6M1gtPWzLlXDm7puE44YW+OQRkCu0ypR/9JOPRDl1te3/p 2ugUGdWUlQb8kocRthjZN7vvr6IWWNFcyKYmBFPe+BzKMnxGjKoBahL5VCHV3UAfs0EHAg nj3sYoDmr7GyZbFXABfsR3rbdQAxCafinJpMUI+6VqMVy7guc3dUP2M2goerpX03cWT8GB 3tIsn5JiFR3GjgHhPz/r2yz7V7NDg477JFOnzakkhw9w+L8/GP2qYPPRO39CHuug0G7Ubo N42GUSC5i0XOiRx9MufeivVdVi29Q812Jc2LJ90UxPjSbThjlODlkTjM/Zl+lF8/E+2aXQ K57x5zBbETIFSPxn/glgXCEXI5Rd5omb7Rl9K0RE2BeAtMwCZ0c8U4ZMWkXw9ZMEZTz0RL OKo0euqiJNUWJvCkgiR1XXxX8UjQn2EcgSU95KvZktQVlqmkSJW6SrX7eSZtO7u0FLxXFC +6eMrs9ZGOWvo0W6EVGjorhGjfSTq2dn2cyNLMf1aA79VNRk14OTFLmAUYBet/ylkfmWj6 bblUIr7WrdCSerBW2Kz1BrDyJW8KxJoQ2Q5Q0D7TfY49vlQQLtfThuXNYjePMTOZx9i96e iWsaoEND85aEUGHz6cEZEW4XI4r8UKX3UwdQ08gANR6AExLKijMDWrUcdCWA X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 01/13] CI: set LOG_MSG as end-of-test marker consistently Date: Wed, 5 Aug 2026 16:55:29 +0200 Message-ID: <6a0c80ab0f09bf471679f811e22ba51c034b29e2.1785941707.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1785941814-C5341757-CA20101A/0/0 X-purgate-type: clean X-purgate-size: 3715 Especially, do not set it to either empty string (not the same as unset), nor to a message found earlier in the test execution. This change will allow more consistent waiting for test end regardless of its result. Note for dom0less tests - waiting for dom0 prompt is not the right thing to do, as the actual test is executed in domU, and those are started asynchronously. Signed-off-by: Marek Marczykowski-Górecki --- New in v5 --- automation/scripts/qemu-alpine-x86_64.sh | 1 - automation/scripts/qemu-smoke-dom0-arm32.sh | 1 - automation/scripts/qemu-smoke-dom0-arm64.sh | 1 - automation/scripts/qemu-smoke-dom0less-arm32.sh | 5 ++++- automation/scripts/qemu-smoke-dom0less-arm64.sh | 1 - 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh index 242ffca693fe..0c60b2503858 100755 --- a/automation/scripts/qemu-alpine-x86_64.sh +++ b/automation/scripts/qemu-alpine-x86_64.sh @@ -81,7 +81,6 @@ export TEST_CMD="qemu-system-x86_64 \ export TEST_LOG="smoke.serial" export BOOT_MSG="Latest ChangeSet: " -export LOG_MSG="Domain-0" export PASSED="BusyBox" ./automation/scripts/console.exp |& sed 's/\r\+$//' diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 5dc348c71aa9..4cda80843a84 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -91,7 +91,6 @@ export TEST_CMD="qemu-system-arm \ export UBOOT_CMD="virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000" export TEST_LOG="${serial_log}" export BOOT_MSG="Latest ChangeSet: " -export LOG_MSG="Domain-0" export PASSED="/ #" ../automation/scripts/console.exp |& sed 's/\r\+$//' diff --git a/automation/scripts/qemu-smoke-dom0-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh index 1d673f184251..6defd51ca449 100755 --- a/automation/scripts/qemu-smoke-dom0-arm64.sh +++ b/automation/scripts/qemu-smoke-dom0-arm64.sh @@ -101,7 +101,6 @@ export TEST_CMD="qemu-system-aarch64 \ export UBOOT_CMD="virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000" export BOOT_MSG="Latest ChangeSet: " export TEST_LOG="smoke.serial" -export LOG_MSG="Domain-0" export PASSED="BusyBox" ./automation/scripts/console.exp |& sed 's/\r\+$//' diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index 20e43b4f049d..fff6d3b56df2 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -144,7 +144,10 @@ export TEST_CMD="qemu-system-arm \ export UBOOT_CMD="virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000" export BOOT_MSG="Latest ChangeSet: " export TEST_LOG="${serial_log}" -export LOG_MSG="${dom0_prompt}" export PASSED="${passed}" ../automation/scripts/console.exp |& sed 's/\r\+$//' + +if [ -n "$dom0_prompt" ]; then + grep "$dom0_prompt" "${serial_log}" +fi diff --git a/automation/scripts/qemu-smoke-dom0less-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh index a9e99f1ae392..0d1244d3dc90 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm64.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm64.sh @@ -213,7 +213,6 @@ export TEST_CMD="qemu-system-aarch64 \ export UBOOT_CMD="virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000" export TEST_LOG="smoke.serial" -export LOG_MSG="Welcome to Alpine Linux" export PASSED="${passed}" ./automation/scripts/console.exp |& sed 's/\r\+$//' -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383599.1626859 (Exim 4.92) (envelope-from ) id 1wrd3A-0000gZ-E9; Wed, 05 Aug 2026 14:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383599.1626859; Wed, 05 Aug 2026 14:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3A-0000gS-Ax; Wed, 05 Aug 2026 14:56:56 +0000 Received: by outflank-mailman (input) for mailman id 1383599; Wed, 05 Aug 2026 14:56:54 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd38-0000gF-Hx for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:56:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd37-004z8Z-DV for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:56:53 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f04-5cb7-0a2a0a5109dd-0a2a450beae0-18 for ; Wed, 05 Aug 2026 16:56:53 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f33-b7e8-0a2a450b0019-ca0c7c9883bd-3 for ; Wed, 05 Aug 2026 16:56:52 +0200 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 34C4D7A008E; Wed, 5 Aug 2026 10:56:51 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 05 Aug 2026 10:56:51 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:56:50 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:Message-ID:MIME-Version:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm2; t=1785941811; x=1786028211; bh=YEDuDEwDOK77MggXfQc8ZDeI/hZyM8at FiPKnftVAqg=; b=x7GlZqCsludFrj/q5XXF9teD8yNd7di7sCnKuAPP3waJ88oZ QJ3vP3pEEryJuIyC76dEtZqe4CibOsVj3WJDBN1cBcqJw+wl845AaNnQkzWRvit6 mYkG1sX16ZgipiWnL6GG/Mr2J9b2+stSas7/UkAunhJYmAd9x7K8WKO1KYCH+fKu AcLNPnVnibmoEVS+ynQieinyeNsv+xBPZe8A3XelaHEhtDiK/8Im+5UDOtUM1oUY R61uEdVMu6RicADqAK4DAGT1KjJgq3BOEeJjUV28q0eYQbihJ7RZ0K4PbJLjSDn1 sqjbWmzEECMASqwIAZzR9G9a5ZW3mEm789o9xA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1785941811; x=1786028211; bh=YEDuDEwDOK77MggXfQc8ZDeI/hZy M8atFiPKnftVAqg=; b=jb6orZKg4GFdwpW+oKBcCTkdbiYDujxp1sUaTZSL+Qqn In6xj3vPmti0SR7AdPWYs2r2hTYWH9uEbc/XeLoPhQ8v5Pzawp5PcJp5QF1PA7ND gknek+iPRjH+90JwVURw21X72RoRUt11X/JNDIlR8TIWsCyyKdVk4ffcmi5fGvdN aVXOYk/ZUktbopIbVgzMI7oeJ6PcqmzLS8d6sRc2xbUzuwRUrTefMCZSyrFsviU3 6mE5jtMyRcMN8LNoxsAmq+0KAOD5uzSf+w9XLutQ6KbvErHyJql0zJ6iHYa0Jm3G SYmWVIWthtqsEUTWbJsloYicWaleo3a9SGv6aHPgaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFS2I1DSF/oTs2YQfmubyAQWQKrS9o1T9OtKuY9CuWqDf88oVZfpzRXmQuQDDJlCl 9cmEs94RusrZIbcOtjToT0S5XlxTu0/NKy/T3ezOs80gUEweOM8EWQajxRiCc2sDk21uFi a4W+iCgUtDsR5dmCnaQ56nlW2fJozQqjHRcYXuCeeFL+jQmZGgs0ZNlC0/gFWKng4/Hr+C 8Gn0wpielhGrWVaWgN6OXQIoyclA+ItQI53S5PNvID0Kpf5iYNI3phx9/STnOHfBHybjoR bIZxgdoC1Dc79u2nQ91uWl/a9KidXZ1rnyWoT2gMs6tv7i5vCoPE48r/uiqnWUQ6JAxTpO dHLGpTRmNkGEgXxcid+oX7qhV5XmaLsm2Iobk/jPDr1Z+nFsKVGtKaXt1K6wqa/qBOMHm4 mKMX1+QC+rBgAHV1tMvUhHh+DnqvKq/ekWLMsp6J2o9LZbSFhHhzn6KsLWQoQ9xZiNbyZr ZsPlp++qS09qmFkioyY43rtam+hb7uSUGRHDf88kPTzzGXkPZWX1+f8HG9zphrA9B9tJQv lNETVsasGQxTMHgIk/IxD9XAvMMoITMXnVTCgYujClddSWU4DUREwXiF+1k9EM2XWcvrj+ A+gc5z/3jGby+q6Qw1cdQnHzBXvrUUeMMES1D2PLO8HcablrxcH89z+eK5Vw X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH v5 00/13] Add several more tests Date: Wed, 5 Aug 2026 16:55:28 +0200 Message-ID: X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785941813-A94C39EA-3731F3D2/0/0 X-purgate-type: clean X-purgate-size: 2791 This series used to be about just driver domains test, but over time got a few more. Now it includes: - fix to detect test failure early, instead of a timeout (at least in some cases) - simple driver domains test (network backend in domU) - UKI version of xen.efi booting from firmware directly and via grub2 - domU suspend/resume test (detects recent migration bug) - fix for macos build jobs being stuck in personal repos https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/2734175811 This series requires companion test-artifacts series pushed first (it's fully acked already): https://lore.kernel.org/xen-devel/cover.30e6171ddf1c6a72eadf4af0a77c892d4f18d811.1777898148.git-series.marmarek@invisiblethingslab.com/#r --- Cc: Andrew Cooper Marek Marczykowski-Górecki (13): CI: set LOG_MSG as end-of-test marker consistently CI: Reduce timeout on test failure CI: Add driver domains tests CI: Add configure --enable-systemd for full build CI: Run driver domains test on Debian too CI: extract building domU/dom0 out of qemu-alpine-x86_64.sh CI: add a smoke test for UKI xen.efi CI: add tests booting UKI via grub CI: enable xenconsoled logging in alpine tests CI: add oops=panic to smoke tests CI: Extend qemu-alpine-lib.sh to allow simple networking test CI: Add simple domU suspend test CI: gate macos build jobs with MACOS_JOBS variable automation/build/debian/13-x86_64.dockerfile | 4 +- automation/gitlab-ci/build.yaml | 6 +- automation/gitlab-ci/test.yaml | 51 ++++- automation/scripts/build | 1 +- automation/scripts/console.exp | 1 +- automation/scripts/qemu-alpine-domU-suspend-x86_64.sh | 71 +++++- automation/scripts/qemu-alpine-lib.sh | 86 ++++++- automation/scripts/qemu-alpine-x86_64.sh | 60 +---- automation/scripts/qemu-driverdomains-x86_64.sh | 149 +++++++++++- automation/scripts/qemu-smoke-dom0-arm32.sh | 1 +- automation/scripts/qemu-smoke-dom0-arm64.sh | 1 +- automation/scripts/qemu-smoke-dom0less-arm32.sh | 5 +- automation/scripts/qemu-smoke-dom0less-arm64.sh | 1 +- automation/scripts/qemu-smoke-x86-64-efi-uki.sh | 92 +++++++- 14 files changed, 468 insertions(+), 61 deletions(-) create mode 100755 automation/scripts/qemu-alpine-domU-suspend-x86_64.sh create mode 100755 automation/scripts/qemu-alpine-lib.sh create mode 100755 automation/scripts/qemu-driverdomains-x86_64.sh create mode 100755 automation/scripts/qemu-smoke-x86-64-efi-uki.sh base-commit: 0dc67f3aab0a080b756f9e54b8a58a4a887f702b -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383604.1626905 (Exim 4.92) (envelope-from ) id 1wrd3I-0001nP-0A; Wed, 05 Aug 2026 14:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383604.1626905; Wed, 05 Aug 2026 14:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3H-0001n8-OC; Wed, 05 Aug 2026 14:57:03 +0000 Received: by outflank-mailman (input) for mailman id 1383604; Wed, 05 Aug 2026 14:57:02 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3G-0001db-47 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3F-00A5Sr-HC for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:01 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f30-bab6-0a2a0a5309dd-0a2a4505ce0c-22 for ; Wed, 05 Aug 2026 16:57:01 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f3c-4cb1-0a2a45050019-ca0c7c98dfed-3 for ; Wed, 05 Aug 2026 16:57:01 +0200 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id F10037A008E; Wed, 5 Aug 2026 10:56:59 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 05 Aug 2026 10:57:00 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:56:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941819; x=1786028219; bh=VIHXaX1e+f fgdFqzeWyvSlfdqJI5vq9gFySsJjLA51g=; b=bulDFjky/O6MBmdY6opnGgaFXC UU08ORMuosrIGedJpG1TBpuidEYA2Ze8EWlvRaNU3PTos/5pShOmM47pl6NEetLV wYandMud6QOR5XR39HNtT2WsibgANJrbAju/VQzYEHsj4WjWjktUeSRbeis1gC4N XGcn4MSd08orJvYQkA9Cvh2iANFqLNWo1UzGTL7a55BMIJhn5fW78MzXQ7hiP/MH h9cHep4xx72Fiphka8co4WiOqeHlR+UbvQ7YDCDnvONjqaICrHz/B/duiOhcZ37/ 8IWuc7ka8jrCRhx7H0gQyWdQmBPYB0/AWi0zWqvbRL3cWJjlcAa+Ps3Cdm3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941819; x= 1786028219; bh=VIHXaX1e+ffgdFqzeWyvSlfdqJI5vq9gFySsJjLA51g=; b=C 2DmdOwu/f9N3SoLHK3Xs1vZ++r2SSALR0O1QAacHN0OXpnIADY0mw3lPcbRi2IZD 964+gVgyKREZ+jHjqyzFMeEI+oK3y8YsZqfWmAmIAKKiieicVUR6hu4sWGUWx5uL snmDhfh0rgsmbh7yAEB4QiNHOBOWMRzrj2waXnEb1R17oST/QsaDyOIEQesUBaZ+ D+zBd7NN3u43iumv8E6n8jz/2pxkpE7XI/Tf35Y9AC9eJ0NcicEnfxSTpkKgGJ/I nwdOfvQwnDvjo5VJOZVJkdSyjTMndb0ltKmoP6jqhfg/rQA8jAC/a8U5JAlPQJPz 0F2IOQNH9VHpGtMgOjsPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFg5HWH/RDqdPpR88i/6M1gtPWzLlXDm7puE44YW+OQRkCu0ypR/9JOPRDl1te3/p 2ugUGdWUlQb8kocRthjZN7vvr6IWWNFcyKYmBFPe+BzKMnxGjKoBahL5VCHV3UAfs0EHAg nj3sYoDmr7GyZbFXABfsR3rbdQAxCafinJpMUI+6VqMVy7guc3dUP2M2goerpX03cWT8GB 3tIsn5JiFR3GjgHhPz/r2yz7V7NDg477JFOnzakkhw9w+L8/GP2qYPPRO39CHuug0G7Ubo N42GUSC5i0XOiRx9MufeivVdVi29Q812Jc2LJ90UxPjSbThjlODlkTjM/Zl+lF8/E+2aqt yLt1OCe/nhAJMu2CJUS7qRdrtLxh2jFsE6WK4OVh+oT2+FC56uWyodULwj6z4RYpvXMpDn ewuSorjvwbszn0rU/9FzOXB23lxuSQdgnDfmmO00Hvw8LbpbTYmtiqViV7RFvxunh50c3G 8VXisn+B7wyNhjl+xzIq5pMSVC7JZtPn2QiYC9iodIB1U6smXPV4xHBYegFH/vB2XAhqIJ Dfq6UY98Zv5LIJAw15Ciy1EI0oCl+sMiLPNQ68YPpEzBsNGDmbcL5gnje631EYYPqZK7QR /bOjS3BtFN/loXp192R7t9b32urTvDsuoKVrkyU3gvTDrnQiaWpCtVqW/TfQ X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Stefano Stabellini , Doug Goldstein Subject: [PATCH v5 05/13] CI: Run driver domains test on Debian too Date: Wed, 5 Aug 2026 16:55:33 +0200 Message-ID: <372962629561e96b83fc87039b0e6e31e4f9b6e6.1785941707.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1785941821-F54AC2A1-1B0081E9/0/0 X-purgate-type: clean X-purgate-size: 3655 The recent failure affected only glibc-based systems, so do the test on Debian too. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Stefano Stabellini --- Changes in v3: - update to trixie Changes in v2: - use systemd in Debian Needs debian/13-x86_64 container rebuild. --- automation/build/debian/13-x86_64.dockerfile | 1 +- automation/gitlab-ci/test.yaml | 19 ++++++++++++++++++- automation/scripts/qemu-driverdomains-x86_64.sh | 18 +++++++++++++++-- 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/automation/build/debian/13-x86_64.dockerfile b/automation/build/debian/13-x86_64.dockerfile index 5088f7435c1e..8a36774f1155 100644 --- a/automation/build/debian/13-x86_64.dockerfile +++ b/automation/build/debian/13-x86_64.dockerfile @@ -61,6 +61,7 @@ RUN <&1 | tee ${LOGFILE} + needs: + - *debian-x86-64-test-needs + - debian-13-x86_64-gcc-debug + qemu-smoke-x86_64-gcc: extends: .qemu-smoke-x86_64 script: diff --git a/automation/scripts/qemu-driverdomains-x86_64.sh b/automation/scripts/qemu-driverdomains-x86_64.sh index bada6599842e..07bc617058f9 100755 --- a/automation/scripts/qemu-driverdomains-x86_64.sh +++ b/automation/scripts/qemu-driverdomains-x86_64.sh @@ -20,7 +20,11 @@ if grep -q test=backend /proc/cmdline; then brctl addbr xenbr0 ip link set xenbr0 up ip addr add 192.168.0.1/24 dev xenbr0 - bash /etc/init.d/xendriverdomain start + if [ -d /run/systemd ]; then + systemctl start xendriverdomain + else + bash /etc/init.d/xendriverdomain start + fi # log backend-related logs to the console tail -F /var/log/xen/xldevd.log /var/log/xen/xen-hotplug.log >>/dev/console 2>/dev/null & else @@ -83,7 +87,11 @@ cat > etc/local.d/xen.start << EOF set -x -bash /etc/init.d/xencommons start +if [ -d /run/systemd ]; then + systemctl start xen-init-dom0.service +else + bash /etc/init.d/xencommons start +fi xl list @@ -100,6 +108,12 @@ cp ../bzImage ./root/ mkdir -p etc/default echo 'XENCONSOLED_TRACE=all' >> etc/default/xencommons mkdir -p var/log/xen/console +if [ -e etc/systemd/system.conf ]; then + systemctl --root=. enable \ + xenstored.service \ + xenconsoled.service \ + xen-init-dom0.service +fi # this is a sparse file, not really using full 2GiB fakeroot -i ../fakeroot-save mkfs.ext4 -d . ../dom0-rootfs.img 2048M cd .. -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383602.1626886 (Exim 4.92) (envelope-from ) id 1wrd3E-0001JF-8B; Wed, 05 Aug 2026 14:57:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383602.1626886; Wed, 05 Aug 2026 14:57:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3E-0001J5-48; Wed, 05 Aug 2026 14:57:00 +0000 Received: by outflank-mailman (input) for mailman id 1383602; Wed, 05 Aug 2026 14:56:58 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3C-00015x-QJ for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:56:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3C-00Cdp1-6c for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:56:58 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f20-e002-0a2a0a5209dd-0a2a4503d7c8-38 for ; Wed, 05 Aug 2026 16:56:58 +0200 Received: from [202.12.124.150] (helo=fout-b7-smtp.messagingengine.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f39-fae8-0a2a45030019-ca0c7c96eddb-3 for ; Wed, 05 Aug 2026 16:56:57 +0200 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id A81F11D00112; Wed, 5 Aug 2026 10:56:56 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 05 Aug 2026 10:56:56 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:56:55 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941816; x=1786028216; bh=If8iCaUuEU VvExp6X8arU9RVZ07EdT9hQbyHaLfCGsI=; b=BKxRI+UeLWnwHMgldypAuxkp4B sAhPF4dDpp0+iZVUhwDc2eIxzKEIzToOoiNBuHrUHTnrr0FIMwlyhC0FAHpO1hkt mfmTUhOE7UOAscOiLYyW+M5l2aIMDA0ibf706YtQW8/Pux5GZ8kzeQLkXKTAnX2T lktIo8gbK5xfvQHqiDHw62gSM552SFZpUBq1AN5caiNKoX1U/z/IGQjgpCJo/wSQ hsTuzXp6/eBhgj2U6IA67dy6OBYFXEmBW/Fp1UE2+CJMkKsSoR+5f8Q3wKV5f9XW weCCruNpm1xUIwprX2IT1kn0ndQ4/qFdzIBdpE1Do3lpbF7Zf2BHjlaLo3LA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941816; x= 1786028216; bh=If8iCaUuEUVvExp6X8arU9RVZ07EdT9hQbyHaLfCGsI=; b=O l4tHmUjfe8ZhMaDLMq6E7KD+QxGkkIjsDCi9GBszronts+gyX4VsjansEpk3NS9F 9EFLCHX+JICZ/DRPwI6SpL/aSqWyVxuI/cBYQ92cFLJM59kccZ2ezug5bypNMAna 1pFQ1UExX/sL+2ulRE0GxYQgUd5ihQtbQhNPbCCt/cauvnu4IOrLl1UNSz9TGq3X gf3fBz8X7qS37i69Q/FVhKFJYM6VD4yABjB75a8wnT2VwuR6Hgaz8WfMbRaAYp0+ drMOnTHsj+RN531Qf0qkHMyz0R0QcHpuokLnxn30AjcNj3zLWyiY7Um+djoprceC I1F2AogWztUmgjuJopddg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFg5HWH/RDqdPpR88i/6M1gtPWzLlXDm7puE44YW+OQRkCu0ypR/9JOPRDl1te3/p 2ugUGdWUlQb8kocRthjZN7vvr6IWWNFcyKYmBFPe+BzKMnxGjKoBahL5VCHV3UAfs0EHAg nj3sYoDmr7GyZbFXABfsR3rbdQAxCafinJpMUI+6VqMVy7guc3dUP2M2goerpX03cWT8GB 3tIsn5JiFR3GjgHhPz/r2yz7V7NDg477JFOnzakkhw9w+L8/GP2qYPPRO39CHuug0G7Ubo N42GUSC5i0XOiRx9MufeivVdVi29Q812Jc2LJ90UxPjSbThjlODlkTjM/Zl+lF8/E+2ahn is+bRSV1dAKf+3WxH9+prVq11Vy45YWKlbNbiCrUBO4C04CBMR49ODI1BGXvU81EfFnMcR yJNuMZTdimaUPAfhBnBegsmDDqegTWMsNbq7Cf5fGuC4MzRrG5bsJh8ApZyuiKE548EiMP xHdto99MpuSSifVixRyp7mCJf2Y03CzI+zmXDa760m0p0lnAyGy4w/J98Dt1WBHQoGCZY4 dz90z4nsVqfSe8hnTtAsKKeRJst0PGohEAE8C9kRi8ZlKfyabM1ItPXG+rc5tNKazpDfrg ZrAIhGLT2jkoWixnEOZ0TH1Zk8GMSGeHV6DNSy0CSm++0JasOabEJFXXPgUQ X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 03/13] CI: Add driver domains tests Date: Wed, 5 Aug 2026 16:55:31 +0200 Message-ID: <20b70bd488f533cdaa8e72a92a69afc0d5de4d7d.1785941707.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785941818-6E2D04E9-85FFADF0/0/0 X-purgate-type: clean X-purgate-size: 6516 Setup a simple two domU system. One with network backend, running xendriverdomain service, and one with frontend, trying to ping the backend. Contrary to other similar tests, use disk image instead of initrd, to allow bigger rootfs without adding more RAM (for both dom0 and domU). But keep using pxelinux as a bootloader as it's easier to setup than installing grub on the disk. Theoretically, it could be started via direct kernel boot in QEMU, but pxelinux is slightly closer to real-world deployment. Use fakeroot to preserve file owners/permissions. This is especially important for suid binaries like /bin/mount - without fakeroot, they will end up as suid into non-root user. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v5: - add code comment about sparse files Changes in v3: - add fakeroot - run ldconfig at the disk image creation time, to avoid running it at dom0/domU boot time (which is much slower) Changes in v2: - use heredoc - limit ping loop iterations - use full "backend" / "frontend" in disk image names - print domU consoles directly to /dev/console, to avoid systemd-added messages prefix - terminate test on failure, don't wait for timeout Needs debian/13-x86_64 container rebuild. --- automation/build/debian/13-x86_64.dockerfile | 2 +- automation/gitlab-ci/test.yaml | 8 +- automation/scripts/qemu-driverdomains-x86_64.sh | 135 +++++++++++++++++- 3 files changed, 145 insertions(+) create mode 100755 automation/scripts/qemu-driverdomains-x86_64.sh diff --git a/automation/build/debian/13-x86_64.dockerfile b/automation/build/debian/13-x86_64.dockerfile index 784299d52dc3..5088f7435c1e 100644 --- a/automation/build/debian/13-x86_64.dockerfile +++ b/automation/build/debian/13-x86_64.dockerfile @@ -56,7 +56,9 @@ RUN <&1 | tee ${LOGFILE} + needs: + - *x86_64-test-needs + - alpine-3.24-x86_64-gcc + qemu-smoke-x86_64-gcc: extends: .qemu-smoke-x86_64 script: diff --git a/automation/scripts/qemu-driverdomains-x86_64.sh b/automation/scripts/qemu-driverdomains-x86_64.sh new file mode 100755 index 000000000000..bada6599842e --- /dev/null +++ b/automation/scripts/qemu-driverdomains-x86_64.sh @@ -0,0 +1,135 @@ +#!/bin/bash + +set -ex -o pipefail + +cd binaries + +# DomU rootfs + +mkdir -p rootfs +cd rootfs +mkdir -p etc/local.d +passed="ping test passed" +failed="TEST FAILED" +cat > etc/local.d/xen.start << EOF +#!/bin/bash + +set -x + +if grep -q test=backend /proc/cmdline; then + brctl addbr xenbr0 + ip link set xenbr0 up + ip addr add 192.168.0.1/24 dev xenbr0 + bash /etc/init.d/xendriverdomain start + # log backend-related logs to the console + tail -F /var/log/xen/xldevd.log /var/log/xen/xen-hotplug.log >>/dev/console 2>/dev/null & +else + ip link set eth0 up + ip addr add 192.168.0.2/24 dev eth0 + timeout=6 # 6*10s + until ping -c 10 192.168.0.1; do + sleep 1 + if [ \$timeout -le 0 ]; then + echo "${failed}" + exit 1 + fi + ((timeout--)) + done + echo "${passed}" +fi +EOF +chmod +x etc/local.d/xen.start +fakeroot sh -c " + zcat ../rootfs.cpio.gz | cpio -imd + zcat ../xen-tools.cpio.gz | cpio -imd + ldconfig -r . + touch etc/.updated + # this is a sparse file, not really using full 1GiB + mkfs.ext4 -d . ../domU-rootfs.img 1024M +" +cd .. +rm -rf rootfs + +# Dom0 rootfs +mkdir -p rootfs +cd rootfs +fakeroot -s ../fakeroot-save sh -c " + zcat ../rootfs.cpio.gz | cpio -imd + zcat ../xen-tools.cpio.gz | cpio -imd + ldconfig -r . + touch etc/.updated +" +mkdir -p root etc/local.d +cat > root/backend.cfg << EOF +name="backend" +memory=512 +vcpus=1 +kernel="/root/bzImage" +extra="console=hvc0 root=/dev/xvda net.ifnames=0 test=backend" +disk=[ '/root/domU-rootfs-backend.img,raw,xvda,rw' ] +EOF +cat > root/frontend.cfg << EOF +name="frontend" +memory=512 +vcpus=1 +kernel="/root/bzImage" +extra="console=hvc0 root=/dev/xvda net.ifnames=0 test=frontend" +disk=[ '/root/domU-rootfs-frontend.img,raw,xvda,rw' ] +vif=[ 'bridge=xenbr0,backend=backend' ] +EOF + +cat > etc/local.d/xen.start << EOF +#!/bin/bash + +set -x + +bash /etc/init.d/xencommons start + +xl list + +tail -F /var/log/xen/console/guest-backend.log 2>/dev/null | sed -e "s/^/(backend) /" >>/dev/console & +tail -F /var/log/xen/console/guest-frontend.log 2>/dev/null | sed -e "s/^/(frontend) /" >>/dev/console & +xl -vvv create /root/backend.cfg +xl -vvv create /root/frontend.cfg +EOF +chmod +x etc/local.d/xen.start + +cp ../domU-rootfs.img ./root/domU-rootfs-backend.img +cp ../domU-rootfs.img ./root/domU-rootfs-frontend.img +cp ../bzImage ./root/ +mkdir -p etc/default +echo 'XENCONSOLED_TRACE=all' >> etc/default/xencommons +mkdir -p var/log/xen/console +# this is a sparse file, not really using full 2GiB +fakeroot -i ../fakeroot-save mkfs.ext4 -d . ../dom0-rootfs.img 2048M +cd .. +rm -rf rootfs + +cd .. + +cat >> binaries/pxelinux.0 << EOF +#!ipxe + +kernel xen console=com1 console_timestamps=boot +module bzImage console=hvc0 root=/dev/sda net.ifnames=0 +boot +EOF + +# Run the test +rm -f smoke.serial +export TEST_CMD="qemu-system-x86_64 \ + -cpu qemu64,+svm \ + -m 2G -smp 2 \ + -monitor none -serial stdio \ + -nographic \ + -device virtio-net-pci,netdev=n0 \ + -netdev user,id=n0,tftp=binaries,bootfile=/pxelinux.0 \ + -drive file=binaries/dom0-rootfs.img,format=raw" + +export TEST_LOG="smoke.serial" +export BOOT_MSG="Latest ChangeSet: " +# exit early on test failure too, check if it was success below +export LOG_MSG="$passed|$failed" +export PASSED="$passed" + +./automation/scripts/console.exp | sed 's/\r\+$//' -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383605.1626913 (Exim 4.92) (envelope-from ) id 1wrd3J-00022O-4j; Wed, 05 Aug 2026 14:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383605.1626913; Wed, 05 Aug 2026 14:57:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3J-00021X-17; Wed, 05 Aug 2026 14:57:05 +0000 Received: by outflank-mailman (input) for mailman id 1383605; Wed, 05 Aug 2026 14:57:03 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3H-0001mW-Gs for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3G-004zD5-Tn for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:02 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f32-e002-0a2a0a5209dd-0a2a45079ea8-28 for ; Wed, 05 Aug 2026 16:57:02 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f3d-b4ea-0a2a45070019-ca0c7c98bcbd-3 for ; Wed, 05 Aug 2026 16:57:02 +0200 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.stl.internal (Postfix) with ESMTP id 7C30F7A00CD; Wed, 5 Aug 2026 10:57:01 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 05 Aug 2026 10:57:01 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:00 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941821; x=1786028221; bh=NJqCn/CpFS hQ4iywkQBEF1/M0+zfv/NLrkPB9AYJeCY=; b=0l/iKxUU+2hwwvEKxPktRRLuar Pfw/dYsXbJ571858vogWyyUq7IiHNpW6wDKcglyiSeYRHwxvS/CBtPv34WLIV1ZY rnvTW01Wq860M1V5zU1HXzAPikk9r88pu2rHNHOvHYgEf1B04Jn8tJEygqQ0877+ sMILnqr372ZS5vuPhhPRuqCICbWH9d08yMCFYF4Gf9XBNdp5DUdNOLJdrl+7g8py qmzQNzqfe48FitDQvkUQys4ktXbJcFV8Y3qiXuUWEFX3nJQT5R45Oh7sEQy9DAIw m0s+hR5LJ/zSPiMpjEeW2lcq2fbekEA4Lpr2w1lp/cReqxYsLCJghi3gRHgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941821; x= 1786028221; bh=NJqCn/CpFShQ4iywkQBEF1/M0+zfv/NLrkPB9AYJeCY=; b=H GzAdrxOkUp3hBBSaJwOHv5CfVzqSNaf/m8Qizq+/IrAHIJ0ZIP9MitMrHEwgGkd3 hW8vdzLmxddYXbUjHJhLhkp20djA4FX5xW+FXwzB/CWWNOOLxsssZ5fipijsKu1H OksV5W2vp5ExMCD6qeKuXFmyh042D2kQsoUko+kn/UGb3hyZPewkERd0YvY8zd8x MdgFOyAyTSID474PDSegCYfmw8zds8woS3Q7W6Y5Ai7sFfrxBQ14ZVwhvlQSybOO zbN0QSlGHrbO/ky8yBuPA576gX9DhRbUcrv06JBzH993sXo66RiD2oEqBgULXZqm cD9aWcMq+47J4mHuqGOIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTE1tKvhsT+Fhei0Yg+G27SZQPQVopYNzanoImCL8xkq2oL6bKpGea3H8hzYRKHrGC B6kQUNlF+nZ7bYZBt1/dQdXqlMW9NJlyslPcE0+Pa5JNi0jTkDFxiuq8QbvTIJJx2SeYvk MURT57H+uIHzESnQrqQOd471thhd85FLBD10JZToXtKcwAL2lIl13tKixe9zx9R8K6lDVh KmpaTBDrNZA6jwf9idIZL/vdHPuMsaLOe+zilHC5z0fnjufSdy4lnRs2QJOWeDUP+W5tLW UzmcKwTf1aOSEOg4bUbniMBRaVMDpagjyVQAluXe6sHMhg18pP5cC9VjXvgw8aCZHU5tcV JRg0Dl83yyuPeVOfv1CsBEx7Rt+EWXR/sDFDuKWCf7D2Fzsq7L0xpbqq95ejzCCqrSu5O7 YdglTevOLDxzB+X1v2mF5+NCpPaGwCX835GKY6koo1LlZ+ULHFm4jD3R+jsPdprbEgaihM /fw6zto9NmRt893XgnqD5y4J5qV8HITW5ZppAFXmfZbf6Z9eoTg5/UEEzGD4nKfIbymrpj zFUsBdy4F4VMb1RdPpDuv4mquGjr7D15Yn+Nfo0qxUBr1d3kVm8LaeNKsi7OKO/zr5EdDV 6LEzyNotZaaRUBZaIQ1/91fAtLdhqXj04aI4iG7VBuFhOmGX8sotuwl+RpzQ X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 06/13] CI: extract building domU/dom0 out of qemu-alpine-x86_64.sh Date: Wed, 5 Aug 2026 16:55:34 +0200 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1785941822-A50CDAE4-2B5DB2C4/0/0 X-purgate-type: clean X-purgate-size: 3993 Add qemu-alpine-lib.sh with utility functions that build dom0/domU out of container binaries. This will be used in further tests that re-use similar structure. Signed-off-by: Marek Marczykowski-Górecki --- New in v5 --- automation/scripts/qemu-alpine-lib.sh | 62 +++++++++++++++++++++++++- automation/scripts/qemu-alpine-x86_64.sh | 59 +----------------------- 2 files changed, 66 insertions(+), 55 deletions(-) create mode 100755 automation/scripts/qemu-alpine-lib.sh diff --git a/automation/scripts/qemu-alpine-lib.sh b/automation/scripts/qemu-alpine-lib.sh new file mode 100755 index 000000000000..29fdff4f562a --- /dev/null +++ b/automation/scripts/qemu-alpine-lib.sh @@ -0,0 +1,62 @@ +#!/bin/bash + +build_domU() { + # DomU Busybox + mkdir -p initrd + mkdir -p initrd/bin + mkdir -p initrd/sbin + mkdir -p initrd/etc + mkdir -p initrd/dev + mkdir -p initrd/proc + mkdir -p initrd/sys + mkdir -p initrd/lib + mkdir -p initrd/var + mkdir -p initrd/mnt + cp /bin/busybox initrd/bin/busybox + initrd/bin/busybox --install initrd/bin + echo "#!/bin/sh + +mount -t proc proc /proc +mount -t sysfs sysfs /sys +mount -t devtmpfs devtmpfs /dev +/bin/sh" > initrd/init + chmod +x initrd/init + # DomU rootfs + cd initrd + find . | cpio -R 0:0 -H newc -o | gzip > ../domU-rootfs.cpio.gz + cd .. +} + +build_dom0() { + # Dom0 rootfs + cp rootfs.cpio.gz dom0-rootfs.cpio.gz + cat xen-tools.cpio.gz >> dom0-rootfs.cpio.gz + + # test-local configuration + mkdir -p rootfs + cd rootfs + mkdir -p root etc/local.d + mv ../domU-rootfs.cpio.gz ./root + cp ../bzImage ./root + echo "name=\"domU\" + memory=512 + vcpus=1 + kernel=\"/root/bzImage\" + ramdisk=\"/root/domU-rootfs.cpio.gz\" + extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\" + " > root/domU.cfg + echo "#!/bin/bash + + set -x + + bash /etc/init.d/xencommons start + + xl list + + xl -vvv create -c /root/domU.cfg + + " > etc/local.d/xen.start + chmod +x etc/local.d/xen.start + find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz + cd .. +} diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh index 0c60b2503858..e1b5060f4490 100755 --- a/automation/scripts/qemu-alpine-x86_64.sh +++ b/automation/scripts/qemu-alpine-x86_64.sh @@ -2,64 +2,13 @@ set -ex -o pipefail -# DomU Busybox -cd binaries -mkdir -p initrd -mkdir -p initrd/bin -mkdir -p initrd/sbin -mkdir -p initrd/etc -mkdir -p initrd/dev -mkdir -p initrd/proc -mkdir -p initrd/sys -mkdir -p initrd/lib -mkdir -p initrd/var -mkdir -p initrd/mnt -cp /bin/busybox initrd/bin/busybox -initrd/bin/busybox --install initrd/bin -echo "#!/bin/sh +. "$(dirname "$0")"/qemu-alpine-lib.sh -mount -t proc proc /proc -mount -t sysfs sysfs /sys -mount -t devtmpfs devtmpfs /dev -/bin/sh" > initrd/init -chmod +x initrd/init -# DomU rootfs -cd initrd -find . | cpio -R 0:0 -H newc -o | gzip > ../domU-rootfs.cpio.gz +cd binaries +build_domU +build_dom0 cd .. -# Dom0 rootfs -cp rootfs.cpio.gz dom0-rootfs.cpio.gz -cat xen-tools.cpio.gz >> dom0-rootfs.cpio.gz - -# test-local configuration -mkdir -p rootfs -cd rootfs -mkdir -p root etc/local.d -mv ../domU-rootfs.cpio.gz ./root -cp ../bzImage ./root -echo "name=\"domU\" -memory=512 -vcpus=1 -kernel=\"/root/bzImage\" -ramdisk=\"/root/domU-rootfs.cpio.gz\" -extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\" -" > root/domU.cfg -echo "#!/bin/bash - -set -x - -bash /etc/init.d/xencommons start - -xl list - -xl -vvv create -c /root/domU.cfg - -" > etc/local.d/xen.start -chmod +x etc/local.d/xen.start -find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz -cd ../.. - cat >> binaries/pxelinux.0 << EOF #!ipxe -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383601.1626877 (Exim 4.92) (envelope-from ) id 1wrd3D-00016E-2u; Wed, 05 Aug 2026 14:56:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383601.1626877; Wed, 05 Aug 2026 14:56:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3C-000163-Tk; Wed, 05 Aug 2026 14:56:58 +0000 Received: by outflank-mailman (input) for mailman id 1383601; Wed, 05 Aug 2026 14:56:57 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3B-0000oe-Dq for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:56:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3A-00CQKb-CY for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:56:56 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f34-2eae-0a2a0a5409dd-0a2a4506baa6-22 for ; Wed, 05 Aug 2026 16:56:56 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f37-195a-0a2a45060019-ca0c7c98a5ef-3 for ; Wed, 05 Aug 2026 16:56:56 +0200 Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.stl.internal (Postfix) with ESMTP id E012B7A00D4; Wed, 5 Aug 2026 10:56:54 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Wed, 05 Aug 2026 10:56:55 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:56:53 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941814; x=1786028214; bh=6TXF8NBknI pzz7v8cLxu16DA3612q9rG5557ATJiwak=; b=Sb3H46GsSvOXvjLFOyX29JlQU4 ZWXRgpaqy4poyVxgoCf1giiPzFWlLouA9i0u69wmMVCudibDySNaPNrulk6qIBlw EqIMFyFcf/lZ/O/6S9x6MxwIrjT5M2m2uoqVnSO2ztc16z28mSX0uyQvI6jxdaDp KFmEKywQKk1YbKWp0kS0q8a+xUW1PaHGb52QOnLsdGPrN5Vy28oanLNRqYbOLOEZ yEikl78FBNyGEv/CLc9sxd+tutbPGjy97a84W/8chgNPC95HMWg3oK63gVNyDkAl mHD4yz9UIr1xtdr39R1mOdF+tF4IooGwuEBKG638uCnBHIy6pj0FxsX5JE8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941814; x= 1786028214; bh=6TXF8NBknIpzz7v8cLxu16DA3612q9rG5557ATJiwak=; b=E fRk2NPg0l8ET21oYuUJYmm2qib4u0HSEYV4VfbjipkYv2nKlXNVtjlf6kBc9+fpj JlKo2zzp5yvm+joVfBhoheI/KY0XZDTVCkgd/APvw0vvnr71f5b/s5FPhcMbuYI2 l9BvCfUxSOXWTIbWoOoDqHtIBXSQslvdtqXQTJQ82hBWEtScg4Z/HHYlJO3WbWnA YHG6lxUJtcD8eKOzkPesihBUi+zUAwoXN6wu4i+5tP3ybT+guCEnCpqUU/Hh1RMw r5UqgoDL99S3QSgA+OqnjTLEgG+YYTwDAcNzANdyS2RR1mj4ML7VUsdNcb6k8+Op PaKghpNffJ13OXFrMl8+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEdkvLxT+7ERUoKSapa1INrusQu2FZX/o9rqRP1XBK15rAw70yPydcC3NfqbA6Lrf 4puMmK5txEfuISPRuXWjpSCdsSeR+ufxTsazl6IC22b0hWJX0iKN7KSwQVuS2VSUUDH+Dj 2vVw9VAwzNzcOOEo/3GzaHvePPom9QgwnkPOERV+gliyvt2NHofrpPdQOkhW49z8fC8cgn 6kDdLCqxJkQ6dXm9LDBL8Zi+6SnAUc+9mUiuLRAzS1mwJNsan9xrkGOxbXhqopJIC+MZM1 sAWmGCMwjHA49BcUskgsz4gguRIIl/ww8SE206Z0mStY/oUSsgfAxoS44sAUZllLWOs9UM PUROGKfl1JuD7sVMVMUTtvEWjbrSP8wRxo1QtPYztct2Zd1WxPDkYL0LtWoaQCsIsvl6cd ZQEnFSWOR/CWxpbdxMm+pinEgdd+1wUB566ulqsvWis+MMlKid9QAUyIkIP2kVvEcnCt1d 7MjzIfSOWcXg9dbsIZoc4Pl/PY7L2cUAe6YPDB+0aL/Zx6biqAXw6FtDbV8EmHfjqyz7xl J6W21Nflen2Z7QeueBJBHrbJWTDVpFs78CjL7EEFactwScrmXpliOwBhVj+X/KSdWbnH4j dK8VVEJP0AGePaDhut8pji95e0QWjnlE0gu5kKMEThRLwxi7wXj0UWQ6MXAA X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 02/13] CI: Reduce timeout on test failure Date: Wed, 5 Aug 2026 16:55:30 +0200 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1785941816-1FCCD77B-1F28CA92/0/0 X-purgate-type: clean X-purgate-size: 1357 Tests can specify two expressions to look for: - PASSED variable: what to look for in a successful test - LOG_MSG variable: what marks end of test execution (regardless of the result) If the latter is found, do not wait full timeout for the former one (which will never be found in a failed test), but check for it with a short timeout instead. In a successful test it's supposed to be in the expect's buffer already, and in a failed test it will never arrive. This should reduce waiting time in case of a failed test. Note the other case (when PASSED is found first), the timeout should not be reduced, as test may execute some more after determining the result (for example it may collect logs for uploading). Signed-off-by: Marek Marczykowski-Górecki --- New in v5 --- automation/scripts/console.exp | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/scripts/console.exp b/automation/scripts/console.exp index e27886bbef23..d65f840a315e 100755 --- a/automation/scripts/console.exp +++ b/automation/scripts/console.exp @@ -65,6 +65,7 @@ if {[info exists env(LOG_MSG)]} { exit 0 } -notransfer -re "$env(LOG_MSG)" { + set timeout 10 expect -re "$env(PASSED)" exit 0 } -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383603.1626895 (Exim 4.92) (envelope-from ) id 1wrd3F-0001XK-IH; Wed, 05 Aug 2026 14:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383603.1626895; Wed, 05 Aug 2026 14:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3F-0001XD-Ee; Wed, 05 Aug 2026 14:57:01 +0000 Received: by outflank-mailman (input) for mailman id 1383603; Wed, 05 Aug 2026 14:57:00 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3E-0001JE-BI for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3D-004zD5-OO for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:56:59 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f20-e002-0a2a0a5209dd-0a2a4503d7c8-44 for ; Wed, 05 Aug 2026 16:56:59 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f3a-fae8-0a2a45030019-ca0c7c98b99b-3 for ; Wed, 05 Aug 2026 16:56:59 +0200 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 566847A0036; Wed, 5 Aug 2026 10:56:58 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Wed, 05 Aug 2026 10:56:58 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:56:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941818; x=1786028218; bh=NSW54GHtEO i9vl/a/xrx8zk65+87yD71z/uJn8Y/c8o=; b=kfGpXYhitUAtm/97ggczMUjKHR cgK1XTo6Z6e4pal2s0rAge7tokSNEkEkrtnJnW+5LRx1GWkcBRvnKDT/pMfXdYIZ 69qYIQ8M2prpIbXdKYkc3DxT8ZW7QLkhMpo2TiUc7487EV1q98mS0B2t2TH8qcZh CQU6kyf0IMhiGcJbML3SmLHxuQT2Fm2P//4y0m7AfvOIrWv1H1FF4bCNCWUdkeqp IKXU7zcV0IVa3H5xndaus7KrNj8TDBWCewQ95McrT8BfPsm3Lm2uAjJyCkkWMsVe d5e3ZUvULGQvb+FV4k769EsGKNAbW2Lg9Ktjlnt4G97/o4vG0BNYh6tN/vpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941818; x= 1786028218; bh=NSW54GHtEOi9vl/a/xrx8zk65+87yD71z/uJn8Y/c8o=; b=C Ba/F9bnraC1AP1UnFxXLMQKuEzKuMnYM6J7Vr0nFUu6HeErboBGiSjFTqKBEtQaI Rhqa/Z6PgJAy7r6BYzt+vmFlEOp4dXdn5KA6sWvd2Cuyn2RJ+reNpche5oksZiyD 5WOK991pl55bHe9UYvh01N4SODZ0Yndwg6+rOPB2CpKFAoITpvOZhuQEMNRVNlyX /rnxz65q3AIzRguLcvIELeEFaLEsCuan7+ih30XYnUpLNVEPLnwFNlpDAxnYX+A3 OzS1s4F4YD8j70q+se3R3eJhWRGFUaNTuEJroUXSjxmAYU2gI7TtlazbRzYC2SVb 0W3yA5PRnwuODrespeQWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEdkvLxT+7ERUoKSapa1INrusQu2FZX/o9rqRP1XBK15rAw70yPydcC3NfqbA6Lrf 4puMmK5txEfuISPRuXWjpSCdsSeR+ufxTsazl6IC22b0hWJX0iKN7KSwQVuS2VSUUDH+Dj 2vVw9VAwzNzcOOEo/3GzaHvePPom9QgwnkPOERV+gliyvt2NHofrpPdQOkhW49z8fC8cgn 6kDdLCqxJkQ6dXm9LDBL8Zi+6SnAUc+9mUiuLRAzS1mwJNsan9xrkGOxbXhqopJIC+MZM1 sAWmGCMwjHA49BcUskgsz4gguRIIl/ww8SE206Z0mStY/oUSsgfAxoS44sAUZllLWOs9dw TEDio0/XVTjbPYzt9Hux7zQESi9grPIq2OpQ0g+s41ZnxOnsEwBHOkjLzSSH8KYVzrLtNs QHgkT1s8qVUet1Kh70b40AQ5DhcwrtIYchkPCaZ2fDCIXDfV7ktrcFAkpSseEOvzTTb8F7 u+CMpnE1HWGjtzIrFhoiTgJ6rsGLOPkOklpm5SrTMQwSx3l3l2W12/Nh0G1EYeaN6yTeux T0iyTBqwSBlVzHNXnNH0N2f37Sk9cnwvBowhLnmsf7ytoIxwsR1TFrd6meSVvb+hRMFAGm o48p8yXGwFJF8gGJAkLFmrXnExpfJU4Mce1TEXFi2SBH80uc00zZGFUZU7wg X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Stefano Stabellini , Doug Goldstein Subject: [PATCH v5 04/13] CI: Add configure --enable-systemd for full build Date: Wed, 5 Aug 2026 16:55:32 +0200 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785941819-6E6CE4E9-A4A274D6/0/0 X-purgate-type: clean X-purgate-size: 889 This doesn't exclude sysvinit scripts, but allows testing systemd too. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Stefano Stabellini -- Changes in v4: - drop systemd-dev, add --enable-systemd always Changes in v3: - switch to trixie New in v2. --- automation/scripts/build | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/scripts/build b/automation/scripts/build index bdaab11c3722..33de967c4b9b 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -59,6 +59,7 @@ else # Full build. Figure out our ./configure options cfgargs=("--prefix=/usr") cfgargs+=("--enable-docs") + cfgargs+=("--enable-systemd") # booleans for which compiler is in use cc_is_gcc="$($cc --version | grep -q gcc && echo "y" || :)" -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383606.1626922 (Exim 4.92) (envelope-from ) id 1wrd3K-0002HS-DL; Wed, 05 Aug 2026 14:57:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383606.1626922; Wed, 05 Aug 2026 14:57:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3K-0002HD-8I; Wed, 05 Aug 2026 14:57:06 +0000 Received: by outflank-mailman (input) for mailman id 1383606; Wed, 05 Aug 2026 14:57:05 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3J-00020K-4a for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3I-00Cdrb-HA for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:04 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f34-5cb7-0a2a0a5109dd-0a2a45098958-38 for ; Wed, 05 Aug 2026 16:57:04 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f3f-be1a-0a2a45090019-ca0c7c98c8ef-3 for ; Wed, 05 Aug 2026 16:57:04 +0200 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.stl.internal (Postfix) with ESMTP id 1BECE7A008E; Wed, 5 Aug 2026 10:57:03 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 05 Aug 2026 10:57:03 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:01 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941822; x=1786028222; bh=D4TMGAPIXT KE8KLggURHTOvWsEJPhlI6eLx2c1m5BIU=; b=ohubngivkCKQVuc545HNXHpP6/ +s7e7NmX1I7isyjFwEj/Q3mdwiG95YuM6Y10dWhnVoP+67rxgOK6rrkEPP1xM4r7 GtVuLWk5fhet6HReTwVjb/6/i4eI0Y5ymga4qWHMYNEq2PcILh9r3/hREX6IZsM4 owpyy38F3LN2dIHxGxN6/55PXZbSAqBjrAiHmohqYhTY0oZECAgA7iDkyNZEzugZ nTF48K3cY/OCs6GgRtGR7avVu18fOn9cpJNKg5lnijXRxM7NroXYCthtFsxkDsWR Ja53xMXfJIbRi4z8UpzUP1qlb/SvqwdXZ8DKx/VEWFoqAg2AmUsejltqnEwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941822; x= 1786028222; bh=D4TMGAPIXTKE8KLggURHTOvWsEJPhlI6eLx2c1m5BIU=; b=j 0avhJJQ/IsdWWu4NSI5uVM1bY2HUiFuofzythMYdIKrKimDXtDO2JYvaxKv8KM0Y XpJK5PSyxLiTCNXdGuR5E9Pu0c3RFT+Nwc69kyN2Z8tZ8NGEALwnPttL4rjKLZRG gey0vQr5k6Zfa48Ku+juoueSQvY1fVOiolezkGnzXJQjlCP3WeK2l2syBCJdGdh7 RXveyDn50m3JDeOHOyNZsZONNmQTfLdHdAWZa7XEnP/zVlWnx/0iZ07dbUPZBWjj mp6b9O74gXGmDskT2hS3nAiMQPYPFqqM3mytToTuO/Ej5q7y8/luDlUnf3sx0BaN qzWrJL/yTN+em/aqcU5Sw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFg5HWH/RDqdPpR88i/6M1gtPWzLlXDm7puE44YW+OQRkCu0ypR/9JOPRDl1te3/p 2ugUGdWUlQb8kocRthjZN7vvr6IWWNFcyKYmBFPe+BzKMnxGjKoBahL5VCHV3UAfs0EHAg nj3sYoDmr7GyZbFXABfsR3rbdQAxCafinJpMUI+6VqMVy7guc3dUP2M2goerpX03cWT8GB 3tIsn5JiFR3GjgHhPz/r2yz7V7NDg477JFOnzakkhw9w+L8/GP2qYPPRO39CHuug0G7Ubo N42GUSC5i0XOiRx9MufeivVdVi29Q812Jc2LJ90UxPjSbThjlODlkTjM/Zl+lF8/E+2ajc I8e4yupEnk/I7m2P4LYPmY0lkBVs/oS6MiW8d+RZvksuW60ckAKttxjQebuSBcn7dNi7zi yYUrIntPstk/r96xUMuBjLaSpqpyqEEs81sxL765Hj2yE87S2VasrSZ305//Rm33ZjBu67 CjL5KLoeHME7mHkfB6nCh3KfETG7004vHb5/bFGf+uL1iTatYcZPuaGwv+/tMFetoYKKK5 u09P80XM9rJeJmjAhV0kZXFfAAUi4DQapWwdZTL0RTsTzTip+6WBQP0TEyqW7eK8iLrrIy hGRZ7ERl7bZVEesG8E+pvrbEmezSJaujXl8NHBlD6uQQf4yKBXgoopxhw11g X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 07/13] CI: add a smoke test for UKI xen.efi Date: Wed, 5 Aug 2026 16:55:35 +0200 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785941824-BE8D9034-63D63DDD/0/0 X-purgate-type: clean X-purgate-size: 3267 Combine xen.efi test with alpine smoke test. This one should not use XTF, as having initrd is an important part of the test. The command to build UKI is constructed based on the documentation. Signed-off-by: Marek Marczykowski-Górecki --- New in v5 The documentation says to put extra sections after .pad section, but I don't see it anymore... --- automation/gitlab-ci/test.yaml | 8 ++- automation/scripts/qemu-smoke-x86-64-efi-uki.sh | 62 ++++++++++++++++++- 2 files changed, 70 insertions(+) create mode 100755 automation/scripts/qemu-smoke-x86-64-efi-uki.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 184cf9b47d46..8e2db8c33528 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -804,6 +804,14 @@ qemu-xtf-argo-x86_64-gcc-debug: needs: - alpine-3.24-x86_64-gcc-debug +qemu-smoke-x86-64-gcc-efi-uki: + extends: .qemu-smoke-x86_64 + script: + - ./automation/scripts/qemu-smoke-x86-64-efi-uki.sh pv 2>&1 | tee ${LOGFILE} + needs: + - *x86_64-test-needs + - alpine-3.24-x86_64-gcc-debug + qemu-smoke-riscv64-gcc: extends: .qemu-riscv64 script: diff --git a/automation/scripts/qemu-smoke-x86-64-efi-uki.sh b/automation/scripts/qemu-smoke-x86-64-efi-uki.sh new file mode 100755 index 000000000000..8275dd1a81b3 --- /dev/null +++ b/automation/scripts/qemu-smoke-x86-64-efi-uki.sh @@ -0,0 +1,62 @@ +#!/bin/bash + +set -ex -o pipefail + +. "$(dirname "$0")"/qemu-alpine-lib.sh + +cd binaries +build_domU +build_dom0 + +# variant should be either pv or pvh +variant=$1 + +case $variant in + pvh) extra="dom0-iommu=none dom0=pvh" ;; + pv) extra= ;; + *) echo "Unknown test variant!" >&2; exit 2;; +esac + +mkdir -p boot-esp/EFI/BOOT + +cat > xen.cfg < Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383608.1626931 (Exim 4.92) (envelope-from ) id 1wrd3L-0002Y6-RY; Wed, 05 Aug 2026 14:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383608.1626931; Wed, 05 Aug 2026 14:57:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3L-0002Xl-Nj; Wed, 05 Aug 2026 14:57:07 +0000 Received: by outflank-mailman (input) for mailman id 1383608; Wed, 05 Aug 2026 14:57:06 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3K-0002Kl-Q5 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3K-00A5Sr-6T for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:06 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f41-bab6-0a2a0a5309dd-0a2a4506aaa0-4 for ; Wed, 05 Aug 2026 16:57:06 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f41-195a-0a2a45060019-ca0c7c98ac8f-3 for ; Wed, 05 Aug 2026 16:57:05 +0200 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id A90017A00C0; Wed, 5 Aug 2026 10:57:04 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 05 Aug 2026 10:57:04 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:03 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941824; x=1786028224; bh=llNtFQlQYr 7PILGy+20tguUtKJuL+FX+u1XXE52nbb0=; b=wu9hYmcLMZxkhllF1qZl+f4epq OXOA0ZcpGU1OFgPjGHtqevarlAzDzWlyL1R/66KONJop+0o3BadnQjMwo7fVdAyZ xOVYO0b1KDiVqHs/qpbEcC2pOrpTm3XIlBIqEsICnzeoJshqpcdYXeS7lRGljtta Rjpl6QMclcERy4+QBr1KcKuLBjtyZJ8Blm/9zJ0Cz3OxEhJXX09eOErdNM33BrAN bmnl6LYyfYSOhPWmSYkgMKbzqqt5MTBrhV+LNt/sOrUwJzeduuJFQaSlFqit9Pze VQeuUYjvL30iW9A4I1yeelnitZMut5MHW+rekHRZ6aeKtogjzSk0qYJWJz8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941824; x= 1786028224; bh=llNtFQlQYr7PILGy+20tguUtKJuL+FX+u1XXE52nbb0=; b=O HpOn8zBtsjG1XTpVSXWn8hCHW0f5fb67Y/D1+Mcd2E6EiVIJ8scIGiDtOvMqPaLs tmQ7mEPHunYsWJAQl5TAdeT658WUmHLrPx9+di9K5kEUu+nbOvo/hJPS6B+HeA3+ rQHjwVl+fNCrhrwkSvlJTgXhBSCZOh7b9PEza1ETkWJtG+uidWIaKhVNRP+qXznj S99Tc504t5C5LjMXW1Sl6XYb81KKboQLKMSbax0TKHLsCePvKE7PNyjZAfpe4bfM bHbczxDnmQ/ndZFfexZ5zrK5ToQITgBey9svvCEoKAhy1Qou/qAyt24mwyiYn+Dj 5+NEpx4oL4NPLfFbIYncw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFg5HWH/RDqdPpR88i/6M1gtPWzLlXDm7puE44YW+OQRkCu0ypR/9JOPRDl1te3/p 2ugUGdWUlQb8kocRthjZN7vvr6IWWNFcyKYmBFPe+BzKMnxGjKoBahL5VCHV3UAfs0EHAg nj3sYoDmr7GyZbFXABfsR3rbdQAxCafinJpMUI+6VqMVy7guc3dUP2M2goerpX03cWT8GB 3tIsn5JiFR3GjgHhPz/r2yz7V7NDg477JFOnzakkhw9w+L8/GP2qYPPRO39CHuug0G7Ubo N42GUSC5i0XOiRx9MufeivVdVi29Q812Jc2LJ90UxPjSbThjlODlkTjM/Zl+lF8/E+2aG7 aOyEBHoV8EgKgIvYVDmRxD7FYtA8R9JSO6Q6iTa1qhDfTedO6kcBPv2Zc7fFOGSBjVj4If EK9LBVBNO+tASBhg/3jgvdFnTHv19oF8tdtHz6iY9gcgZoN0LEy0UNhXaFqQ1lGv6zx5mk InjPTLPm44ggMAKBkGvYFgISlyb9HnoK0/6OxJTDDH0bSp36V0YHYUhP6qsYkx+ThWQPjs i854as250OH2ovH2HZgWjrxZ4rlm+uOXYtWtzCHg4aIMg5rOrLyZLUb/TpArYrI1PyO8VG seLT7bP+LnHOfcaE0JRpOnagI6j9WEgu3HoBCJFAQXGYJj5OjjqOWpwfEsoA X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 08/13] CI: add tests booting UKI via grub Date: Wed, 5 Aug 2026 16:55:36 +0200 Message-ID: <8f7e40b5f544677321d994fa6168e2090333635a.1785941707.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1785941826-F6A7477B-7C654A22/0/0 X-purgate-type: clean X-purgate-size: 3746 Test booting unified xen.efi via grub. The new test (grub2-pv) simply loads the same xen.efi as the earlier test but via Grub's "chainloader" command. In theory it should be the same as loading it directly from firmware, but practice shows there are some corner cases sometimes (especially before calling ExitBootServices). Signed-off-by: Marek Marczykowski-Górecki --- New in v5 Needs containers rebuild --- automation/build/debian/13-x86_64.dockerfile | 1 +- automation/gitlab-ci/test.yaml | 8 ++++- automation/scripts/qemu-smoke-x86-64-efi-uki.sh | 36 ++++++++++++++++-- 3 files changed, 42 insertions(+), 3 deletions(-) diff --git a/automation/build/debian/13-x86_64.dockerfile b/automation/build/debian/13-x86_64.dockerfile index 8a36774f1155..3ae1d27fb257 100644 --- a/automation/build/debian/13-x86_64.dockerfile +++ b/automation/build/debian/13-x86_64.dockerfile @@ -59,6 +59,7 @@ RUN <&1 | tee ${LOGFILE} + needs: + - *x86_64-test-needs + - alpine-3.24-x86_64-gcc-debug + qemu-smoke-riscv64-gcc: extends: .qemu-riscv64 script: diff --git a/automation/scripts/qemu-smoke-x86-64-efi-uki.sh b/automation/scripts/qemu-smoke-x86-64-efi-uki.sh index 8275dd1a81b3..82702fdcb682 100755 --- a/automation/scripts/qemu-smoke-x86-64-efi-uki.sh +++ b/automation/scripts/qemu-smoke-x86-64-efi-uki.sh @@ -11,9 +11,14 @@ build_dom0 # variant should be either pv or pvh variant=$1 +extra= +grub2_chain=false +grub2_linux=false + case $variant in pvh) extra="dom0-iommu=none dom0=pvh" ;; pv) extra= ;; + grub2-pv) grub2_chain=true; extra= ;; *) echo "Unknown test variant!" >&2; exit 2;; esac @@ -32,15 +37,40 @@ vma=$(objdump -h xen.efi \ | perl -ane 'if (/\..*/) { $vma=hex($F[2]) + hex($F[3]) } END { printf "0x%016x\n", ($vma + 0xfff) & ~0xfff }') +UKI_PATH=boot-esp/EFI/BOOT/BOOTX64.EFI +ramdisk_section=( + --add-section .ramdisk=dom0-rootfs.cpio.gz + --change-section-vma .ramdisk=$(( $vma + 0x2000000 )) +) +if $grub2_chain; then + grub-mkimage \ + -p /EFI/BOOT \ + -O x86_64-efi \ + -o boot-esp/EFI/BOOT/BOOTX64.EFI \ + chain \ + ext2 \ + fat \ + linux \ + normal \ + part_gpt \ + part_msdos + if $grub2_chain; then + echo "chainloader /EFI/BOOT/xen.efi" > boot-esp/EFI/BOOT/grub.cfg + echo "boot" >> boot-esp/EFI/BOOT/grub.cfg + UKI_PATH=boot-esp/EFI/BOOT/xen.efi + fi +fi + objcopy \ --add-section .config=xen.cfg \ --change-section-vma .config=$vma \ --add-section .kernel=bzImage \ --change-section-vma .kernel=$(( $vma + 0x100000 )) \ - --add-section .ramdisk=dom0-rootfs.cpio.gz \ - --change-section-vma .ramdisk=$(( $vma + 0x2000000 )) \ + "${ramdisk_section[@]}" \ xen.efi \ - boot-esp/EFI/BOOT/BOOTX64.EFI + $UKI_PATH + +ls -l boot-esp/EFI/BOOT/ ./ cp /usr/share/OVMF/OVMF_CODE_4M.fd OVMF_CODE.fd cp /usr/share/OVMF/OVMF_VARS_4M.fd OVMF_VARS.fd -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383610.1626940 (Exim 4.92) (envelope-from ) id 1wrd3Q-0002ya-3b; Wed, 05 Aug 2026 14:57:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383610.1626940; Wed, 05 Aug 2026 14:57:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3P-0002yN-WD; Wed, 05 Aug 2026 14:57:12 +0000 Received: by outflank-mailman (input) for mailman id 1383610; Wed, 05 Aug 2026 14:57:10 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3O-0002rq-2b for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3N-000x73-Eu for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:09 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f3c-5cb7-0a2a0a5109dd-0a2a45039e98-28 for ; Wed, 05 Aug 2026 16:57:09 +0200 Received: from [202.12.124.150] (helo=fout-b7-smtp.messagingengine.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f42-fae8-0a2a45030019-ca0c7c96e627-3 for ; Wed, 05 Aug 2026 16:57:07 +0200 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 4AC921D00189; Wed, 5 Aug 2026 10:57:06 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Wed, 05 Aug 2026 10:57:06 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:05 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941826; x=1786028226; bh=Tk4FR3C+E8 hj+04G0aqKUyY5BojG7M7wHi0BRJd3Wo8=; b=G6krjpI5q0lTW24JoT4zzJ3MLZ RMuG55LpdTKldC13FOHL9wy9RlCsDGBa9XfgwKDX4GhLVIySMXp8K0kwsc9x66Vx 4Qovm83h3h3UaUyyGWSCdfkPM2/x+f34qUMgd+Gj1WK56ms/JVPDXhJB4MtFuv/w +pyUKrtKKfksjwhZmGQ4pDdWPSWcjHydoIisRs+OBAfmIHjs5ijSaN9UG3/7BIR1 HlAZ3z/fK4wjwCjqgb3XVYeJHd7lNSq/ikY72AA7WWIyJnfU0SljMGT92gxAQ0qG aH6cJSY7AYtf5yTK45PocUDvUFn6jf7WGm2zbG7xcrGn30t08xfyKXSQw2+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941826; x= 1786028226; bh=Tk4FR3C+E8hj+04G0aqKUyY5BojG7M7wHi0BRJd3Wo8=; b=k SHS+j/4qg/4/oH+J3qjJIBKwahI+Dn132DNHzhYvh4XvcKIJOAYYanbzPaNr7R82 V9d4avt94PdTj9CaEMjnSrVH2B9SQsqIcyzU+yuBGHTCYly/SG5l0lUn5cXSEFy7 bXx+R1bk1OmXKoCIKX1/iOa9PSX4hCycBieGZOamOFH9g5jxOUV+bN0sCvpVGiNb yWNmgP4rTRD05FG0LCkdAKj9uN2awxazvyYvFteA+AuibL1Ug/9YER9vSXG1x1BP DKJpHt0y8sdJIzS6LerfZMOKYzXjmlWc5jUxyg/X/U3nMicZurq1la3i175m6Xu/ 6Ki7cgj537Cf6ikyKRNoA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEdkvLxT+7ERUoKSapa1INrusQu2FZX/o9rqRP1XBK15rAw70yPydcC3NfqbA6Lrf 4puMmK5txEfuISPRuXWjpSCdsSeR+ufxTsazl6IC22b0hWJX0iKN7KSwQVuS2VSUUDH+Dj 2vVw9VAwzNzcOOEo/3GzaHvePPom9QgwnkPOERV+gliyvt2NHofrpPdQOkhW49z8fC8cgn 6kDdLCqxJkQ6dXm9LDBL8Zi+6SnAUc+9mUiuLRAzS1mwJNsan9xrkGOxbXhqopJIC+MZM1 sAWmGCMwjHA49BcUskgsz4gguRIIl/ww8SE206Z0mStY/oUSsgfAxoS44sAUZllLWOs9kz M+2EhVPXnm463WsVTR7vt8wtFsLTgkuGJDU3ThGsfCB1pIk58dNk2MnZTWkzV+0r6EyUid 3cFDm8u+tw2qUoPfO2e2N5u2Qw9aNSNkAAPwTL+5/cpnqmIUxBSN/wNVqyEFM3dw3lYWxf ugbBPhIk5pay1bOoEMkySjQGW7G0pfq64fSYYFhMj+B/TphviwAtYZU2A7H4JrXOGI3X5K 4r4H4cVIF6zKxDT2JTPWoa1dSnjrX26d7LCYUHQL5hu+aQOvDIQcp8gMJDdtogbbWF7DeL ms67pWOxQyuVP2bd8952TxbN9PukkDImsreqa/7F19phu12IrgywSonlJCxw X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 09/13] CI: enable xenconsoled logging in alpine tests Date: Wed, 5 Aug 2026 16:55:37 +0200 Message-ID: <4a2974f971922780bf571547f137f2cf7cb102cf.1785941707.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785941827-74A894E9-94074D3F/0/0 X-purgate-type: clean X-purgate-size: 741 Signed-off-by: Marek Marczykowski-Górecki --- New in v5 --- automation/scripts/qemu-alpine-lib.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/scripts/qemu-alpine-lib.sh b/automation/scripts/qemu-alpine-lib.sh index 29fdff4f562a..5221b7dec1c6 100755 --- a/automation/scripts/qemu-alpine-lib.sh +++ b/automation/scripts/qemu-alpine-lib.sh @@ -38,6 +38,9 @@ build_dom0() { mkdir -p root etc/local.d mv ../domU-rootfs.cpio.gz ./root cp ../bzImage ./root + mkdir -p etc/default + echo "XENCONSOLED_TRACE=all" >> etc/default/xencommons + mkdir -p var/log/xen/console echo "name=\"domU\" memory=512 vcpus=1 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383611.1626942 (Exim 4.92) (envelope-from ) id 1wrd3Q-000328-Fb; Wed, 05 Aug 2026 14:57:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383611.1626942; Wed, 05 Aug 2026 14:57:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3Q-00031c-9d; Wed, 05 Aug 2026 14:57:12 +0000 Received: by outflank-mailman (input) for mailman id 1383611; Wed, 05 Aug 2026 14:57:10 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3O-0002sB-6t for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3N-000x73-JL for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:09 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f2b-5cb7-0a2a0a5109dd-0a2a450ab934-46 for ; Wed, 05 Aug 2026 16:57:09 +0200 Received: from [202.12.124.150] (helo=fout-b7-smtp.messagingengine.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f44-f2d2-0a2a450a0019-ca0c7c96c8a5-3 for ; Wed, 05 Aug 2026 16:57:09 +0200 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 2AB8D1D00112; Wed, 5 Aug 2026 10:57:08 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 05 Aug 2026 10:57:08 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:06 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941828; x=1786028228; bh=LtpC8kb3w5 sylrY5i2rJ1VyunzmKl36EvEgXZscahng=; b=DOfBreqSzAaPHKanjVbGt761Tz +7I46fmizfbtYd/ipmbF23pZabm8ENCYjb8axvtz9za3FYMZbWc1DbEmls30jD7o wDEmk6wWfKLIuyT1Eqv1xNVupv2/ZDDh+nNfouU1q1d7XUt34nSjqB+mc/RCg90h QiJGW1BOi0gWZwgIjFdfTvtFXBEjaL6j0BhQif60z1zRFinYoKam4T2mlcvjH7bQ 7wlEA8WUBtAUz/PfdYyzcNp3DIsna2Dv/pz0cW4nSDAKG53tk2ta998VPwL/yCMT ptmvm+OYNWvsRHlP1ilSzrEuX1Jr1ffDFYcV6RyFlQDttXt+NyxQ1lI2sV8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941828; x= 1786028228; bh=LtpC8kb3w5sylrY5i2rJ1VyunzmKl36EvEgXZscahng=; b=G kew2zVCRVR1po7pqQgJZpxm4l2hwgtCtFk7tbQSODqKIxXSRxOCChY2ZMORaHOEv rk+EZyuPViReXZQ9v++AQ6H24tTvgwSYFjITtg4ZcpjLC5DQL4l3s0nxkKNOZiHx Tt/TAZ4tiy41CSZrj0Wpiosbg3bQ9kCthExShPFURv84Wz+k4ujA/6EiEDoCZKzC gT9Gs7V4MZaNVQu2Ar0yJ9sZI7mUZYUkF/qAchU194cKsYbtDwUsWwL/ti7rmuvS DKRntgx8DYr0NdFyQYy65jYrYKCYZnbe6XL7MdaECMSKZESo2Fm+PsfBl3K1xYHS 0KSRopS8VsVzkj8Cqc+uA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEdkvLxT+7ERUoKSapa1INrusQu2FZX/o9rqRP1XBK15rAw70yPydcC3NfqbA6Lrf 4puMmK5txEfuISPRuXWjpSCdsSeR+ufxTsazl6IC22b0hWJX0iKN7KSwQVuS2VSUUDH+Dj 2vVw9VAwzNzcOOEo/3GzaHvePPom9QgwnkPOERV+gliyvt2NHofrpPdQOkhW49z8fC8cgn 6kDdLCqxJkQ6dXm9LDBL8Zi+6SnAUc+9mUiuLRAzS1mwJNsan9xrkGOxbXhqopJIC+MZM1 sAWmGCMwjHA49BcUskgsz4gguRIIl/ww8SE206Z0mStY/oUSsgfAxoS44sAUZllLWOs9ru v6SOT6ZGZq9hSagMNqMTFH8vdp6O/L5MrKzNDDi7nZLfVHJsioFEZTYyrXxjaY/AwAcAlk sXVAUjeaSNfQZbrzwtHrtgNuvYYSuP702NMIGsM/SNmdqTWhEkrct047Su+Bt5rTagGiiH gYUh30QkTBM+AxtRjABy1cfA/LferyWxei/VMJjU2wdPn1D6MkFvc0ewdrcPYb4+xgM4es RphFaJmrrBphLIWscDorA2sk5T7AlgsctwlQStyRrflabZGWm0q+dMBK0+/JZwY84IkGPG NrZ9G38eWZ3VJ2R4zC6vg4/QMeU4BIrD8fIg8DV4x2NNOlEVpFStkfN25FSQ X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 10/13] CI: add oops=panic to smoke tests Date: Wed, 5 Aug 2026 16:55:38 +0200 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1785941829-59BC0CFC-9A336D88/0/0 X-purgate-type: clean X-purgate-size: 783 Make it easier to detect failures. Signed-off-by: Marek Marczykowski-Górecki --- New in v5 --- automation/scripts/qemu-alpine-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-alpine-lib.sh b/automation/scripts/qemu-alpine-lib.sh index 5221b7dec1c6..2d306f384f6f 100755 --- a/automation/scripts/qemu-alpine-lib.sh +++ b/automation/scripts/qemu-alpine-lib.sh @@ -46,7 +46,7 @@ build_dom0() { vcpus=1 kernel=\"/root/bzImage\" ramdisk=\"/root/domU-rootfs.cpio.gz\" - extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\" + extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh oops=panic\" " > root/domU.cfg echo "#!/bin/bash -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383615.1626957 (Exim 4.92) (envelope-from ) id 1wrd3S-0003b0-Ty; Wed, 05 Aug 2026 14:57:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383615.1626957; Wed, 05 Aug 2026 14:57:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3S-0003aQ-Pd; Wed, 05 Aug 2026 14:57:14 +0000 Received: by outflank-mailman (input) for mailman id 1383615; Wed, 05 Aug 2026 14:57:13 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3R-0003Du-BJ for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3Q-000x73-Ns for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:12 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f3c-5cb7-0a2a0a5109dd-0a2a45039e98-32 for ; Wed, 05 Aug 2026 16:57:12 +0200 Received: from [202.12.124.152] (helo=fhigh-b1-smtp.messagingengine.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f47-fae8-0a2a45030019-ca0c7c98d795-3 for ; Wed, 05 Aug 2026 16:57:12 +0200 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 51A607A0036; Wed, 5 Aug 2026 10:57:11 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 05 Aug 2026 10:57:11 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941831; x=1786028231; bh=AtMWHKAIdG HRUVSdbCNClD81EvWMYyNJcMteHXAqTCA=; b=RlYV4alhVoFuXVE3Pd+sGcU+Fb SBq1fqrKR0MkQO7u2XaYtffJyWv3jnM2u9CyqP02qe9Pz9V4KsYP3U+mxk7Y/Q/F S0vqkWSXnYtaLtDJbjaSltW5mlQ/rXWlVbINAwnilVM1TGHhu56yx3oGCpF4h1n1 m5LWkVwzc+eC0D3jtayoog5RJOEwE6B7jP6iqw0+3QcYYUYBTLKy7kWeoUt7Bz8i hwxDK87NQjBHjpsLUQatZBbMbHEIiSnIl/nVDLextekJj1Csb21yZnAsxRmTzKy6 FpQJBNFE9ByE+S5xEAhjqfGBx2xhzUXQdv1rycB8KOBKbYo0OIgNLUQ0KXsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941831; x= 1786028231; bh=AtMWHKAIdGHRUVSdbCNClD81EvWMYyNJcMteHXAqTCA=; b=e IzWCS7WjIFceauE0YnCvNqNc9jT4CcUExCcULOwUEKXMzouNxiwEeqHmSI+SjqGb 3DZ6PEFMTuz+ynNv2KfZaeFbC4aIeu+1ORpTXHTNAd6+axQBYXKiCdE3RVIYv3cn pqbzaahjplYX3rE4PZ6nMVW+ag/qI8AYa34YXvSHvVmQDNK6lKeEnPeUPMQQ95O4 1Jf+FTOQ46J/TiXz6J8CKlr0RWk+H1XWLMlsbnFfcfYx2PfFHuyVOSNy92Z4RNzA F7gf8abr9b99hhrnP1zK+6PVc/t6nWENxI2pDpgnFYcSCTnhHhbAVESS5FkX+IS1 0Nr3OCeg2bOlhPok2f3cA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTE0EKbTjmPNLZDegeYJdEvPSKSCO9s22HLtuTKYZ7HLLcaPOQZvc2gjx+GpVjK1KQ jrioOGZanX06/wIhePYLadU4DobC5qkSj8L7MnsO15xCkd0z3P7cB6csRPqHGlKuTaZb5h bM8drPp/PFHwerIiCnTVd0Vgi6099jSCpXjCLjIJdn4zWBCVR6N9uvmLz0rWPjgF7BHWOt vZlPGCN6uONSy4YX7Yy4Wn3rLisBe4bDC6tE4xTe6rnrMqnP5QjyYvMtgRyYANegauBYoF kML4/02DYXlfbad4N9Brad2EsuDCdJwSnqfO7HDbcHdezGZGbNsN6UDmvsoEPXJBAd6vtz mYRIaVy7tNuBhjd4t1GM2v0qfBu6bmE9e3SxBcsv1S69ZJNVNK3r996hIL74kmOFL1NLfl PCG5FfvZl+akhjVy9VIK/zpS9sx5iBoeuuLSChYzkM0EQ86VRSCvxAVH3bd7xx7kuWT3FL XMSR6dNqO5XE/rxJb5VTp1/YazROxPPhiz84dADYQNrBJqLiRJZOcH3CGp0RbDzehJJS4+ 9AYchQUb0k4D/fCOLoc7CuO/GaQvUJaENnDARbzhsKip6aEAhLy6S7TZgjG7Lxcs8h6/xo /rRKQDTO7MIB3/7nveTu1R+YHrluFxy5YhOQLKVGMwYHgTnUAS7Erdz3rCdw X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 12/13] CI: Add simple domU suspend test Date: Wed, 5 Aug 2026 16:55:40 +0200 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1785941832-762FD4E9-E6B7DA1C/0/0 X-purgate-type: clean X-purgate-size: 2936 Regression test for https://lore.kernel.org/xen-devel/ajUm2SQtMD6Y-K9S@mail-itl/ Signed-off-by: Marek Marczykowski-Górecki --- New in v5 --- automation/gitlab-ci/test.yaml | 8 +- automation/scripts/qemu-alpine-domU-suspend-x86_64.sh | 71 ++++++++++++- 2 files changed, 79 insertions(+) create mode 100755 automation/scripts/qemu-alpine-domU-suspend-x86_64.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 1359d70ff2b4..b7cdb3a3eb09 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -752,6 +752,14 @@ qemu-alpine-driverdomains-x86_64-gcc: - *x86_64-test-needs - alpine-3.24-x86_64-gcc +qemu-alpine-domU-suspend-x86_64-gcc: + extends: .qemu-x86_64 + script: + - ./automation/scripts/qemu-alpine-domU-suspend-x86_64.sh 2>&1 | tee ${LOGFILE} + needs: + - *x86_64-test-needs + - alpine-3.24-x86_64-gcc + qemu-debian-13-driverdomains-x86_64-gcc: extends: .qemu-x86_64 script: diff --git a/automation/scripts/qemu-alpine-domU-suspend-x86_64.sh b/automation/scripts/qemu-alpine-domU-suspend-x86_64.sh new file mode 100755 index 000000000000..f46a40b67306 --- /dev/null +++ b/automation/scripts/qemu-alpine-domU-suspend-x86_64.sh @@ -0,0 +1,71 @@ +#!/bin/bash + +set -ex -o pipefail + +. "$(dirname "$0")"/qemu-alpine-lib.sh + +dom0_test=" + +$dom0_setup_network + +set -ex + +tail -F /var/log/xen/console/guest-domU.log 2>/dev/null | sed -e \"s/^/(domU) /\" & +xl -vvv create /root/domU.cfg +sleep 10 +ping -c 3 192.168.0.2 +xl -vvv suspend domU +sleep 2 +xl -vvv resume domU +sleep 2 +xl list domU +alive_test=\$(nc 192.168.0.2 8888 > binaries/pxelinux.0 << EOF +#!ipxe + +kernel xen console=com1 console_timestamps=boot dom0_mem=1024M +module bzImage console=hvc0 oops=panic +module dom0-rootfs.cpio.gz +boot +EOF + +# Run the test +rm -f smoke.serial +export TEST_CMD="qemu-system-x86_64 \ + -cpu qemu64,+svm \ + -m 2G -smp 2 \ + -monitor none -serial stdio \ + -nographic \ + -device virtio-net-pci,netdev=n0 \ + -netdev user,id=n0,tftp=binaries,bootfile=/pxelinux.0" + +export TEST_LOG="smoke.serial" +export BOOT_MSG="Latest ChangeSet: " +export LOG_MSG="Welcome to Alpine" +export PASSED="Test result: 0" +export TEST_TIMEOUT="180" + +./automation/scripts/console.exp |& sed 's/\r\+$//' -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383616.1626964 (Exim 4.92) (envelope-from ) id 1wrd3T-0003eS-Ni; Wed, 05 Aug 2026 14:57:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383616.1626964; Wed, 05 Aug 2026 14:57:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3T-0003dO-5U; Wed, 05 Aug 2026 14:57:15 +0000 Received: by outflank-mailman (input) for mailman id 1383616; Wed, 05 Aug 2026 14:57:13 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3R-0003Ff-Ee for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3Q-00A5Sr-RK for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:12 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f36-bab6-0a2a0a5309dd-0a2a4504c650-38 for ; Wed, 05 Aug 2026 16:57:12 +0200 Received: from [202.12.124.150] (helo=fout-b7-smtp.messagingengine.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f46-b57f-0a2a45040019-ca0c7c96abd5-3 for ; Wed, 05 Aug 2026 16:57:10 +0200 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id AF0361D00112; Wed, 5 Aug 2026 10:57:09 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 05 Aug 2026 10:57:09 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:08 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941829; x=1786028229; bh=KBUzmph2e2 g7I3mmWwGwHw/D0ca5oikmXyWa2C9D49g=; b=xu1sYIIreeAU8R7FTNLSiqLMoG 29pO+JjSoqH0ASq2tt54TPJ9tGW/ckQqXNTiD0R8+gpRmtc1Lzd+eAXqUWgXDm89 k8jL3b80CVAEsPGdyE+U9YRM0DrhoWS79YnvczA42lMSQ+VwFW7NJgp/EsZUCLXz 9elZIJFCg2yfDbackBH0K/myWxy9C35IJspThNsZ2mpQ87wPNfTm+j8WjIftj3vW a03Rduyp+y4CxH9XYGLctPFAl8PYHJUgb5U4FvFEOgPQRzBtGIHzzW4x5SkmHZsp s4lx18jOBFLUs7ICxLiHp7trj5awBrTwAtu03GD6g81U8SIfmKHKy4aZVBmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941829; x= 1786028229; bh=KBUzmph2e2g7I3mmWwGwHw/D0ca5oikmXyWa2C9D49g=; b=P K6gpp2S4gd3y+Ik7IUPwOwmYrYb2vDe/iknrK3BMduzhEL3aUZVv0KKpQHlxyzp0 5Mf4Op6nKEy5eiZ8Fp7O15lSY2k3uBmedQCdy2k01jA07MsM+xkxnvEwfb2uO1xP sc8X2lYfnT14hWrat83mO6D95tAmthmOojS7+P/Uk475R5YS10u0wd/1y/JbBjyB l2NimBuSyKfsOeYPs6BR1XAvhHaSjf+Ninb0TXrDJm81GFrcXBL8FsRDTjd70jle DsrDnL4x9jlTSCJ+AAoShzg7Q5rPU2vq8eUaHA/bxV9/lmTUi9SLfHi2ffEqoox8 UaezNEnVzwedcSs3ju1Fg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFg5HWH/RDqdPpR88i/6M1gtPWzLlXDm7puE44YW+OQRkCu0ypR/9JOPRDl1te3/p 2ugUGdWUlQb8kocRthjZN7vvr6IWWNFcyKYmBFPe+BzKMnxGjKoBahL5VCHV3UAfs0EHAg nj3sYoDmr7GyZbFXABfsR3rbdQAxCafinJpMUI+6VqMVy7guc3dUP2M2goerpX03cWT8GB 3tIsn5JiFR3GjgHhPz/r2yz7V7NDg477JFOnzakkhw9w+L8/GP2qYPPRO39CHuug0G7Ubo N42GUSC5i0XOiRx9MufeivVdVi29Q812Jc2LJ90UxPjSbThjlODlkTjM/Zl+lF8/E+2aWA rexhyc6F6J6Gg4kgL+ELyn4KdQJdvDLu9RZg5NJLg5n5i7/HT1VBjffulld9VrKKT8I4yw zn4vJPGmvQUAC0x+7g7TORoqIh/IrKo/gMepIB3an1eH4e9iWAS6pcj2OU9v4YslFGx2qz iA0zhbv/ofO32duhlX8Uv7QCSaESivnvSQOF72N1n6N8+/0nuGQ8Ypi53GsHpMwWWb0Yiq e9gLXwfhrfmXtBRE9FYpPW0vATiPvbD3+Xzo4oPZjIgvGhddca+y7vZK1oSSH3Wyh9n08+ nA1zDi73ncHshzXsSgCQnfsXjHLjyEnWP4q6WEta/3a4J/4V1RMWcXrh+clg X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 11/13] CI: Extend qemu-alpine-lib.sh to allow simple networking test Date: Wed, 5 Aug 2026 16:55:39 +0200 Message-ID: <22516b48ec472a1c507cf62a44856a4912037eaf.1785941707.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1785941831-C10DDB50-6305D1A3/0/0 X-purgate-type: clean X-purgate-size: 1842 Allow some tests do a little more reliable test if a domU is still alive. Signed-off-by: Marek Marczykowski-Górecki --- New in v5 --- automation/scripts/qemu-alpine-lib.sh | 31 +++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/automation/scripts/qemu-alpine-lib.sh b/automation/scripts/qemu-alpine-lib.sh index 2d306f384f6f..7f0046888325 100755 --- a/automation/scripts/qemu-alpine-lib.sh +++ b/automation/scripts/qemu-alpine-lib.sh @@ -1,5 +1,25 @@ #!/bin/bash +dom0_test=" +xl list + +xl -vvv create -c /root/domU.cfg +" + +domU_test="" +domU_config_add="" + +# snippets to be used in $dom[0U]_test +dom0_setup_network=" +brctl addbr xenbr0 +ip link set xenbr0 up +ip addr add 192.168.0.1/24 dev xenbr0 +" +domU_setup_network=" +ip link set eth0 up +ip addr add 192.168.0.2/24 dev eth0 +" + build_domU() { # DomU Busybox mkdir -p initrd @@ -19,6 +39,9 @@ build_domU() { mount -t proc proc /proc mount -t sysfs sysfs /sys mount -t devtmpfs devtmpfs /dev + +$domU_test + /bin/sh" > initrd/init chmod +x initrd/init # DomU rootfs @@ -46,7 +69,8 @@ build_dom0() { vcpus=1 kernel=\"/root/bzImage\" ramdisk=\"/root/domU-rootfs.cpio.gz\" - extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh oops=panic\" + extra=\"console=hvc0 root=/dev/ram0 rdinit=/init oops=panic\" + $domU_config_add " > root/domU.cfg echo "#!/bin/bash @@ -54,10 +78,7 @@ build_dom0() { bash /etc/init.d/xencommons start - xl list - - xl -vvv create -c /root/domU.cfg - + $dom0_test " > etc/local.d/xen.start chmod +x etc/local.d/xen.start find . | cpio -R 0:0 -H newc -o | gzip >> ../dom0-rootfs.cpio.gz -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 14:57:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 14:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383622.1626973 (Exim 4.92) (envelope-from ) id 1wrd3V-000455-BH; Wed, 05 Aug 2026 14:57:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383622.1626973; Wed, 05 Aug 2026 14:57:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3V-00044b-0a; Wed, 05 Aug 2026 14:57:17 +0000 Received: by outflank-mailman (input) for mailman id 1383622; Wed, 05 Aug 2026 14:57:15 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrd3S-0003aY-Vv for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 14:57:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrd3S-00A5WQ-CG for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 16:57:14 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a734f46-bab6-0a2a0a5309dd-0a2a450a919c-6 for ; Wed, 05 Aug 2026 16:57:14 +0200 Received: from [202.12.124.150] (helo=fout-b7-smtp.messagingengine.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a734f49-f2d2-0a2a450a0019-ca0c7c96d3d1-3 for ; Wed, 05 Aug 2026 16:57:14 +0200 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id E9A701D00112; Wed, 5 Aug 2026 10:57:12 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 05 Aug 2026 10:57:13 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Aug 2026 10:57:11 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=fm2 header.d=invisiblethingslab.com header.i="@invisiblethingslab.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=fm3 header.d=messagingengine.com header.i="@messagingengine.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:Feedback-ID:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To:X-ME-Proxy:X-ME-Sender" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1785941832; x=1786028232; bh=2Vy1lzpSY6 +3Xwm7/h9xeFzQJEpkpv/owElMc4Xp8Lc=; b=NYJbOasRE9L1E0wgi5mSk11pdQ ajDa8QGC6ERrlyAkrFHy5Y2tOk/b5yR0jQlN1RhLQAQy08MW7BBdi1tFrXNQgHje 7VrwMOUCy9+WZPsbWvOsbIWbPmfp1e7x7IH4RpUXF1TrwC2EAsFsWFhXEr6NTRWn /UKYHXc3ucsuOdz0QWMRQfatVmUcj5uF/smWMheZLvrTPWzD6KlZ0ctzuNcprrix qstweGiFOqtnyC4CgzMVlil+ZsGf/gjsUHFdcilfFGbtHwcH3oFkkz0dwURMLY/C 7j5Zgn6Y5orfGHLFc/x3pHhbahW8AJPhsCh4ndT86LB/uGHJZYyr4a1zWQFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1785941832; x= 1786028232; bh=2Vy1lzpSY6+3Xwm7/h9xeFzQJEpkpv/owElMc4Xp8Lc=; b=g k6TFj1XhbIeAqdIDcFDGnd9mwKCfGRerxAFZ9KeSOdPXMOvOI2rOhuDRlWa6fCAo yVowXJDdQxkRM094uyJl6r+XFw4l1hmUiWt3NXA4xy5WYMS1ld5quTNIqaaOb5T7 L0nB6EyYx85ZiLUm5N/ANXXSq2nwwNoXyy1d9d/sPiyKGVip7jN8WnvzLcEEiHh1 l2vT8GERixtm7JYFUi4ljvZ8/fMyOwfivegxZ0C7mQr5KwmjOgTdoNQUh+s+qrLN 51364xF+X0+rq673KbUHWhcm3kwJvQ/yG3O7HdwzzAQwCHw7KUM+BAs2ZcJhh9Js VyrEWrXQL9fQqOygpEZMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEFsr3fiWkpZYryqooLx3kbh+Ts4f345KkT9gdVvpd9ekszqJy7VWnjK2PbrFj5LQ NitBf0PdEIBI/suHvnS0zYo/R5qRsLDQBrEmW499IT3EzTl2MaahwXqbjmFFNYGZpxZ/5b p4B7pJg15sYbnlZBXco7mxb3X542gdkXCEqYlJa8P5WQQB/RtX317N4YIN9ziiRafDhlGc 89OM/jfJgDpS8wQRNYzsSDpchNxcRoX3QPKj3oUa0eRNoOX1hDQ02PPD1gK7dvYPchRjIC wwvd5eKYYqWlIYSB3GyrYxdAwo+eEieLgrN0OEb4P1KAx+i+QHw+JcyQdOgdE1KkSRVItB mkzmperyN8loa/AWp8P7Pk1f4qBZuhubAWJELqBgm1dUEJzT6AKDMTszOWO8Fs7Z2J3ynm vnc39N3M7rimyYF5McZ3rkDL1qWV52Ia6An64JFj5QboLVTOFuWonicd3WN55LMkwC6QWT p3AamUlSaYSUDJGgkCIrtHutRl5JaDUV8Zk9BSrcbPR7m4APkzjD9lP+7DJdlBGLRLUHjn jq0D/RSHxtpxJrrOZPAW3bw9lqaEg2vV7JfxfraS/J1NSC7B4mR3kI+oE8a3uMpleCBl9F aZTSNAJWiqTG9fxAcj0jIGEIZjoRrzCOC86VSpzL1NBylojRu2SoosdOraOQ X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 13/13] CI: gate macos build jobs with MACOS_JOBS variable Date: Wed, 5 Aug 2026 16:55:41 +0200 Message-ID: <1c63c71893b9cc2cb6cf2dacaad8fb96fab6cdb8.1785941707.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1785941834-536D6CFC-9DEF1200/0/0 X-purgate-type: clean X-purgate-size: 1483 The macos runners have limited availability (they aren't enabled for all repositories, and have a monthly usage limit). Do not schedule macos build jobs unless explicitly enabled with MACOS_JOBS=true variable. Note: just setting the variable is not enough to have macos builds, relevant runners need to be enabled too. Unfortunately there isn't any built-in variable signaling runners availability. Signed-off-by: Marek Marczykowski-Górecki --- New in v5 MACOS_JOBS=true wants to be set as a group variable in xen-project/hardware group. Specifically, on this page: https://gitlab.com/groups/xen-project/hardware/-/settings/ci_cd#ci-variables --- automation/gitlab-ci/build.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 27eefec5f9a5..85831f44838b 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -13,7 +13,7 @@ - '*/*.log' when: always needs: [] - rules: + rules: &build-rules - if: $BUILD_FOR_TESTS_ONLY when: never - if: $CI_JOB_NAME =~ $SELECTED_JOBS_ONLY @@ -806,6 +806,10 @@ debian-13-riscv64-gcc-randconfig: # macOS build jobs .macos-26: <<: *build + rules: + - if: $MACOS_JOBS != true + when: never + - *build-rules tags: - saas-macos-medium-m1 image: macos-26-xcode-26 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 05 15:37:37 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 15:37:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383719.1626985 (Exim 4.92) (envelope-from ) id 1wrdgM-0005yz-8W; Wed, 05 Aug 2026 15:37:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383719.1626985; Wed, 05 Aug 2026 15:37:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrdgM-0005ys-5h; Wed, 05 Aug 2026 15:37:26 +0000 Received: by outflank-mailman (input) for mailman id 1383719; Wed, 05 Aug 2026 15:37:25 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrdgK-0005yW-WE for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 15:37:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrdgI-00AAlK-5V for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 17:37:22 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7358a2-5cb7-0a2a0a5109dd-0a2a450b9a3c-26 for ; Wed, 05 Aug 2026 17:37:22 +0200 Received: from [52.101.61.63] (helo=DM1PR04CU001.outbound.protection.outlook.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7358b0-b7e8-0a2a450b0019-34653d3f75a3-3 for ; Wed, 05 Aug 2026 17:37:21 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by CO1PR03MB5937.namprd03.prod.outlook.com (2603:10b6:303:6e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Wed, 5 Aug 2026 15:37:18 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%5]) with mapi id 15.21.0292.018; Wed, 5 Aug 2026 15:37:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UBB/a+RoHluFkJF7rGfmEJDk6AgzwRcxJRoq7DafGICkamXXhVSICKkqhOB3MsjCvhuU0Udid8dBKi30lwnfZgawuam29jkb4QRST25BJXPj2S0TIqtPlxS5+F7UQvTB6/GgB7KHZ3xSFXh8EYRxLbPvuS2MBTZFi3YpgD15xtKVpWxXGBf3dJDXbsjoYtb6L+YH6rUBqFscXgmCh0uLKPA1B2ELBh46czcIeQ29/CRCvvgz/VX8DRH6qb08+NNIj80ISGYon/f6bMvk1ePEwBvLXx3vJ0F6jCHD5RZzEzgQjbsQdLjd90Ri5M49fmHjtPF0EoaIewkHxa9samyLnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OpJuoyeWX8X4J/xCvkd6XAjCDW5W2vgxIKAaH7xIHAI=; b=twUR1hHZaW9NSMFEo0SBTfoeAISL0pNV31JxaV9IsWfqnFkYfp74aS4jD4na2ZGcunleT8YcMC9ilclCMJ5FoZFKDBs1LUrCGYb8lz84TUZVeSBHRr1blpUUBCqY5IkVRPx6cnPSiU0Qyihnqqj9dYZPY0DwrYPfpz+qB0B4TXwcT/xpFKx9+d56wVcalVqsHdywk4OQgaKsBBkkUGxiuUUYB2E72ykB6glMfPcA7zBHAa9iRSdcsKOs9v053HT7eaQSyyJ8KDZy6w7qRupY++2kj919ATw3o9ni9hqu2rI5n83PXcv4Chpb1IlTWARlVsi1oZ6cN4ipoT9u7msfKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OpJuoyeWX8X4J/xCvkd6XAjCDW5W2vgxIKAaH7xIHAI=; b=caJSxtAhrFc+rwlQZucvGQRKn/2RExporS3MtAsMo/hGHTFQrGAF03ALc9lea+jcLLRwIjrMZCH+lBd1LpO8t55+N7dDMagGm9Fz/3XiVVu9tj1O6ITHu7pzQ++n3aVuTXyg8JFeLxsjiaoSd9UVxJWk70CknnSDEOPNtm/knQ0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 5 Aug 2026 16:37:15 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org Subject: Re: [PATCH 5/5] x86/nmi: Don't configure EvtSel repeatedly To: Jan Beulich References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-6-andrew.cooper3@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0203.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::10) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|CO1PR03MB5937:EE_ X-MS-Office365-Filtering-Correlation-Id: 194fc579-9724-4c52-e1f9-08def3076ed9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|18002099003|22082099003|5023799004|11063799006|4143699003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: J1ls53dVXlI5kO3RN9tk1OcaQxcDkPasxiLwXSFrYwPq46tgNuarPaU76P72rUye/L/Wq9XBgyDvvVHyYpCvoXh1NejM0bAglJ93+r2ZFEIV6CH03K2HVl40DwJ3JnqoUgbn5u3uKaZ8CjhWbJbnitzXq1iEJ+eoVlGOgUfKT8OVbHn88NSJAkdCipWN+3c7CfvWSe7zFF9f5od1+J+NG91a2T3t3w5ELSnLxJ0pL9Ia1m/6CVvoDpUKkx725/fYVttqAzyMgvDxKxsRrAaaZOWqOmFZSOgour5zhYKlYo7S+5g5t0In+8YkYrp2IDfaCya0aJXfesUNDrMGjsJiu1+g7ouaXIXm3OVYCU6/E6BAHH8Ljjkc/IpyylNd2LRG+1WZXZOiVI5xiEFQpqWyq96Ug7QdmuF1DMIsB00VX53MOFOJhpULI+BsOx8W1ZVZcLLGeLct9bRrOCkmCtityPhZTtckQj4rswcro2xXxYFOuQ1EJu4Pq1ggv+PfbsJl/I+LYF/tSRK75i3ZiilkxLn2sq9RPNnJ4lNOtllKPIL8MzQ0B80gfY5FWzIPAAF0fmdHLbDL3geQlTHpa6EKOKPnz08pw5L8n9wQfQLaFZgFmJlGCvGEmSaJ2JtCC1F+MDzF4Qt/aaIq86vWOdtiPHrIfY94BlpZCcNBLvmA3sE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(18002099003)(22082099003)(5023799004)(11063799006)(4143699003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnNINytmUFlXUmFoM3VNd3NBbHFGbGJXdWVEbWlUa0hrcUlhamh4WlRVOEIy?= =?utf-8?B?WXdCUk00SVJGalJ3QlBVWjRhZ2pLd2FWbXllL1dMbFN3SE4rdm41UkdieGZj?= =?utf-8?B?dlhtSlZnaUlTcFBVSEtyaGNVSW8vMGgvTFVNZkd4cmppL3hMV24yTDB4djV3?= =?utf-8?B?b1BXR0FERHVkL3hITTN2eWdiK1lGS00xWVhyejltUDNuMEdleExwbmpKOC9s?= =?utf-8?B?cU1oZnVxNTNESDFsRy9FMHlpZEtzU1NvUnJxeWZyZnQ0VU15aFRhdm90dGV1?= =?utf-8?B?NElKYUh3djJ2eXpqNTBwb0VMYjh6elYzbTM2Y3hrR2E2ZjNtWEpZRDN3ck1v?= =?utf-8?B?K3NPNzVycFVrUWJLN3FXOWsxaVMxbktkYWdKRFdGNEI4NG5EcnBWbnJzMnMx?= =?utf-8?B?SnhnOUgyVkN4L0pVdHFBSVdIamxBZkp1WDNGR0lPRjl0ZWdZTWExOWptTVNz?= =?utf-8?B?OW9KQVZiSS9uQ2sxSFlHVnNRTUdGMXdvdUdYNEZWTVlLenJqVENqanFWeGJT?= =?utf-8?B?OGxXR1FBQkVOa1E3WVAxc2hzNnVVckNUNzFMWmw4ejQvV21XaFhRWGlBNUta?= =?utf-8?B?TUJmdkh4NWt1M0JmM1d2cVBoY1dNa1dBaUUwL2JKWExKTTQ2RVdkSkY1STla?= =?utf-8?B?cDFlS2U0SGpyWHZiVC9VOGx2UGVzMEtHTUdvU0JYa0RkdzdPZ3JXdVUyakNU?= =?utf-8?B?ck1zNVAzbGdjMHU3KzB5dDIwMEFrTnNsOVdjRXQ0RWlqV1dSb1VWbjEzN1NG?= =?utf-8?B?ZGVtamdkZUpraEN0bkJOZGx4T2NxaVFlTUFOdlRqV2RVVE05bzhKd0tmQkxv?= =?utf-8?B?ZUJINXlOMGFQWllCUE9OajluMkRFanJOVExnWm5sbnR2em9OT1BpV1dkL20z?= =?utf-8?B?NmRvRHYrMDFrUnBIQjArUmtXZ2N2OFNQYWFaK2tMZ09ROXRhQ3FVY3c1NE4z?= =?utf-8?B?S1l6NHZ1NUtUOGh5RXYzaC9tTnJ5Uis0OTMyWXM5c1NvOXdUd1RzazlIVWl4?= =?utf-8?B?aCtrV09adm1wNndSam5MMU42eldQQllFQzZ2dWlmSGFURWxOdUlFcHBTTVVO?= =?utf-8?B?RFdnSXVXclRyOFRjOVRjSWxWVGpTTVN1NHpldGE5R3BUdEg2Yi9SV1pSWDlP?= =?utf-8?B?ZTdKRHd6Y3ZpdDdmdWRMZnl6Y3puZmpIS3BEbnN2UXJFQTJZL1kxRm9oUEFE?= =?utf-8?B?dnQvWGRGZTUzaHAzRTgwMGNJZlJ5OWhZQlVSVGdld1lhZ3NiaUl1SnJFU3hu?= =?utf-8?B?NXBLYmVtaTdySFVFaXNRWUxzcmNzZlFaS0VSUEpGcUNEY1pRdG5NUThYWUx2?= =?utf-8?B?cjk2MUQ0Q0ZxdFppb3R4Y3lxSGdMMGpVY2xQTUtKenNOMitEUW9iMTlYb3JU?= =?utf-8?B?UFdXVC9kNFUxMkxieXFQZjM1S2EwNFRwM2lzbFM2dkUzcDVxVk1TMFhLS3ln?= =?utf-8?B?UWp5d3VsNEJoVmNsd29GRTMwVW5YeG15R2R4L2RTQkI2STJBa2FoKzhmd05i?= =?utf-8?B?Y3VtVUhXbmNWT2xPRDVhSUR4eTdCc0s3ZWNRM0VtY2hZUEFPUlZXd2xrOXhy?= =?utf-8?B?Q2ZYU0grcGVtVDRzekFpSmpFS2oxREI3UFdTdG5VUzI0Z3UydER6Q0RKL2dO?= =?utf-8?B?WElYUlZ1NHlJZ3NMNWVaTEExdy9yK3pIUzFNRk85d1VzTldUUE83aWpldW92?= =?utf-8?B?bkxIVFk2cW5NZWxnLzNkT3h1dEtqK3BrbHBRY0lESE04QmZGbkhWSm1FTGo5?= =?utf-8?B?MFZobWg5aGU0eUtra2pxTDh6UEtiSVJZUjlRUzhpZ3BsS3RBM1V6KzdHSEJZ?= =?utf-8?B?UmtDdU9tWGo2T3lzd3dUaHpHVE1KMXNRVStpVTFXdGZwbmNJWE5tY0VialI2?= =?utf-8?B?WkhjaEp4WGNNVmVqL0hhU25tOWZPWGVQblR4Q0FRREUvT3dubGpVZW1FVEpy?= =?utf-8?B?VThEdFhHb2c1bTlqRFdRQTBVbWpoT29qMFhEb1RzUFdSRE1Yc1dDRGRoTTZh?= =?utf-8?B?MEp0UFR0RHhVUExFMFlaNWdWTXNDTUFHUzV3YkRxU1BSZzJZcnNGWTdLeXU1?= =?utf-8?B?cms4d0tLVnRqQzU2YW4ycThGcDlicUxOYXErZTRnd3NEaXI3Y2FFZzZhR1Nw?= =?utf-8?B?bjRrRTZ2NDl6RlBvTUVuWHgzUm5Vck9QQzQ5bTE3QitFRkowT0Y5ZzViQUJM?= =?utf-8?B?WmJYb0pPbGsyQ2prazIrZ2FCUHR5VUI5SEt0bkhCYjNKTkc0bFY2SkhkOFh3?= =?utf-8?B?UGJaNG5WTmd4Z3ZBNHNxR1U5RUZQOW40TS9SZVg3dmQ4NGtRYkd4Sk51Tis4?= =?utf-8?B?NkZmMGlrSy81MFBrVkFqWUt6YU05SVNXMVA2aCtNWDhSZUx1RDhNbnNYb0tG?= =?utf-8?Q?gyZiZXuaPI+x54yM=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 194fc579-9724-4c52-e1f9-08def3076ed9 X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 15:37:18.4413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nOqA4flYTpnk9H8GQhu7KJExGQTbxSQVDUbYgSfzCDrNE+LmKuOzsXcFU5XRwsCvjaZuI47UUEOSryyw1/yqHIiNb1FTlRINbHL4evBWdII= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5937 X-purgate-ID: tlsNG-42698a/1785944242-AB0DD9EA-2C67C515/0/0 X-purgate-type: clean X-purgate-size: 2252 On 05/08/2026 3:20 pm, Jan Beulich wrote: > On 05.08.2026 14:45, Andrew Cooper wrote: >> In both setup_{k7,p6}_watchdog(), EvtSel0 is first zeroed, then written with >> everything but the enable bit, then written with the enable bit. >> >> setup_p4_watchdog() is slightly more complicated, owing to what >> appears to be a bug introduced by commit 2a2bd8de16b6 ("Clean up NMI >> watchdog handler."), which causes a second bit to be temporarily >> different too. >> >> The middle of the three writes is useless in all cases. Drop it. > Spotting the 1st write in setup_p4_watchdog() wasn't quite as easy, as > MSR_P4_BPU_CCCR0 (as passed to clear_msr_range()) has nothing to do with > MSR_P4_IQ_CCCR0. Using unrelated MSR names there is as unhelpful as using > raw hex numbers. Perf counters on the P4 are utterly insane, but our local logic really doesn't help matters. Another option would be to remove P4 watchdog support, in the basis that we really can't test it. > >> While doing this, rename the 'counter' parameter for >> setup_p6_watchdog(). It is the event which is passed in; the counter >> is always counter 0. >> >> No functional change. > These sequences of writes almost look as if they were trying to cover for > errata. Are you sufficiently sure there are none anywhere, for this to > truly be no functional change? There is a reason to write logic in this form; it's just not applicable to us. The original P6 (besides being 32bit only) had two counters, but the enable bit was in counter 0 only and controlled both.  I.e. you needed to write logic to program EvtSel1 without the enable bit (it is strictly reserved), and then EvtSel0 with the enable bit, in that order.  This is in the SDM, just well hidden. I spoke to various people, including PeterZ who wrote the perf infrastructure in Linux (starting with Westmere, so it never ran on P6), and Linux has absolutely no logic of this form at all. I am reasonably confident that it's just copy&paste without due care and attention which has left us with the code in this form. > If so, ... > >> Signed-off-by: Andrew Cooper > Acked-by: Jan Beulich Thanks. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 17:57:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 17:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383811.1626993 (Exim 4.92) (envelope-from ) id 1wrfrA-0007oN-SE; Wed, 05 Aug 2026 17:56:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383811.1626993; Wed, 05 Aug 2026 17:56:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrfrA-0007oG-PQ; Wed, 05 Aug 2026 17:56:44 +0000 Received: by outflank-mailman (input) for mailman id 1383811; Wed, 05 Aug 2026 17:56:42 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrfr8-0007o9-Iz for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 17:56:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrfr7-007xQH-SF for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 19:56:42 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73792d-5cb7-0a2a0a5109dd-0a2a450b8752-36 for ; Wed, 05 Aug 2026 19:56:41 +0200 Received: from [52.101.43.59] (helo=SJ2PR03CU001.outbound.protection.outlook.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a737958-b7e8-0a2a450b0019-34652b3b670f-3 for ; Wed, 05 Aug 2026 19:56:41 +0200 Received: from IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) by BY5PR03MB5048.namprd03.prod.outlook.com (2603:10b6:a03:1e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Wed, 5 Aug 2026 17:56:37 +0000 Received: from IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599]) by IA1PR03MB8288.namprd03.prod.outlook.com ([fe80::b5ee:28c6:e04b:5599%5]) with mapi id 15.21.0292.018; Wed, 5 Aug 2026 17:56:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RynfGg/1BWj8KVgkYctZH3zjXUk57loPoTssB1aW7/WznBY7wfq+C3oRj9bDrzWwitUqZ4faj2QPiOSG2D4dABCZNG+6hrJy3gSpw5LuQ7LTrL+PAljiu6XSTPa9SwIU2iueXKV3o0q5N23b81oaezyMb7lNZ0cAUnA3t76EH41t/EWTjOPpxDHAEJ+d1dp1Mq3r2A0W/jU0XrCLC88CjKlSdJOmjkLiC4J+7eNy50OCppQvjxTxlvLhKtTnwwvyPSDIluPXCOq3uprnc33O1FZ93ReMEFi7XOr9mB15P5fOjQ1X1ZKKdwCpUJt6yjEopgnUCdXiZ0Mg7E3qEjnaxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWL4OLP8uDAfZ7Dt2Z1hIzCUXwvGDKhNOKb66JnPpNs=; b=vuWUWENJrTXyHUjN/QbW24zWbs+WPdFjSgr0dcf0M3UQrtINZ1meHQ2aPTLCMjCOUugUlDPJAj/2l3lu+v5OarTIOp53+Z/PIzIdeheM8pdh617fEE47m/76Gm+PK6SP4QaJK5Li3hwCCs6nRTdhs+DC4ajj5Qzp5FAD8hcFoirlwpnIOcc+EW2eeVRm4IXmTao1eKsNVeIiLLcz9044WbLK/Y4yj4nnOJUQ+wf7JIjD8QLf1pTUqG8Nlvd02S/9Gl8GaQssumD5e4yGyDiQwvcNGtZmnoIAiBCaCHlg/wlr7vmy1Sq/KPd+vCih9joFL41SrljDCwYxv1jSuH7OiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWL4OLP8uDAfZ7Dt2Z1hIzCUXwvGDKhNOKb66JnPpNs=; b=Gq2Y3Mgayoqq7J87XC7jdDYmQqt3vNKnF/+JFKjc9fN4aysHsP3/vzGeAIZoA4z2zJ/JlxD6kjAZoT/QByyyFq05rxVrgbd7JyTmH/iuzionSWzmzOO+hioLbVcUBuqQluRAzgr9QJeWsy0FMAStnBoDdN3WT5zwx6hi15jZh7k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <49738195-ad6f-4889-984d-b1eeb5372708@citrix.com> Date: Wed, 5 Aug 2026 18:56:34 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org Subject: Re: [PATCH 0/5] x86/nmi: Watchdog fixes/improvement Part 1 To: Jan Beulich References: <20260805124525.105457-1-andrew.cooper3@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0110.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::7) To IA1PR03MB8288.namprd03.prod.outlook.com (2603:10b6:208:59e::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR03MB8288:EE_|BY5PR03MB5048:EE_ X-MS-Office365-Filtering-Correlation-Id: 78f2b456-6a2f-48c2-393f-08def31ae503 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|366016|1800799024|6133799003|10067099003|4143699003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: DnuFKRt6lHemYsw6AkJW3boK+i9uwXTpqUrEu0tdjsc+48jDcUpTCs97Us9FcgPu1BBO4mdaecmpk8M1DWd0YClOZHbAELxAul4Ozn8PlVk+YN5yv1C8nhBODlGTTsMtDxgMES6HWWm2bzAHIzkIKfyX2S2O5pD1tSs/rk3ixjGLPl5D4I5VRiz6hksDGX98gTCI/Lziejp6HArP+7k1GRZ+DRR46SjEXkMDsMnIIsF7yvQDJl/YySaSKSAKPpnJ1j7PU5vEyD0Df/Pglt14E68LO+7LsGaS3zYRcScuxp3IoXhAInRQ+lesUdeWXG5tEh1fg2EoIBX0EJyHGrQQVLc1FO3TYQupiVE61g842nIOgWHzX5Yn/Q1dFlvHr4YBWkb7cPFC6Ug04a/3W51swzFRIWHyNnJ9bh3b/IHivfwRfuOTfBBOTV4oDZVX9EGqxGnFeLG9Tb9a9yBQw7Y6NcUvDfKCXpUMp0hsHYPbOtu+zAMT7XCGdezXUUB4guv4e9XY8OeL+ks2HZdheCQYlKId54ghAQGfFb80unq/eKf6E/ltOvjWx81vumIVGQWxzP28zDj7tDuvat3Nzec5CTAMeY1HRza6XVIpt6k1JwCyjB1tXeuTsoPP5gddr6FPJOkhqOUyavWdjn/dBKNrtwSvzUDD5nZFMTeQxeobbtM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR03MB8288.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(6133799003)(10067099003)(4143699003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkdRdzEyeGdKRnQ4Wkt5ZDZEd3FrdW1vUit3QmJqZ3N1RFBLRll2WWxsdTFK?= =?utf-8?B?U3ZhZUJGcXBhb2RBZzhRSloyM0xHekxnUVlzc3d1YjhSbHNkTjlxa0hQVGlB?= =?utf-8?B?K2piTlo5VllrM1pqYm5mM25RbXdHcFlNOExWTTJDM1ZVaW1USDltSjNqaGZu?= =?utf-8?B?WCt3S2NGNnVLeldVQi9GL2d0blhBUzVTd0NpRkl0Q1I5Q3NybVFrYTQ3U1dK?= =?utf-8?B?ZmpvZ0NLaW1ya2JXM0pVSnJNRXU5clMrK3ZPOW5JbTFEWXpJRDF0aFVySTVB?= =?utf-8?B?K0pIQ1JDWS9ONmpJQWwvUGRCUEdEaDdRUXFUS2toWGN1TTlhWkhNM2NtakpX?= =?utf-8?B?cDNTOUFVZ0htVkpydWZKQ3paM1lRbWlDZDRwb3B3NkNFZDRzNStKZE9YMDJH?= =?utf-8?B?dE1TR2JVUmZxdFlQcEUyRFpXRE1Ob2thY2tOY0JpckZpUVYyelF3d0RmTWdm?= =?utf-8?B?dVlnRmFPU1haL241cXZnbWNSeEp5ejIvYjB3ZG1xeGl5cXVPM2dLek50bmp5?= =?utf-8?B?SDRSa0dYKy9qSmNtZVlQQVQwMTZPOGR0eWw0Wk9aMW5MRTJQWmo0OS82U2Fu?= =?utf-8?B?UFIyM0U1cWJMcDliMzZtOVRNUWdObWZDMzVQMVF5TWxHTEFRelEraW5oc3V0?= =?utf-8?B?VGtsc1dUSlVDa0hDbXVVZ3k1TCtjbXpTYVlRUmMwUzgwQ0NwQlpNQ3M4cDdz?= =?utf-8?B?MnZBWlBCaHR4UEI0ejkzcUJUNEdGYzl0UGxBRlYyU1dNSEhHd2UxZGVtdkxZ?= =?utf-8?B?Wmt0aThTVEtrNlk3UjVOMERLdHZjR1VYaWFWbkR5TlM3aFhvRDBFZDNuazYz?= =?utf-8?B?OEdyTXhEb0FxbkluOU9jVEFadGZrclN3cmVyOXREdmZDTnlHejhnY0h2K0tL?= =?utf-8?B?a0F4dXZSbXhqOVFvcTZhZ1IwMzQ0alJsMC9MSnNydVJnUEtVUHRFZzdjckJG?= =?utf-8?B?dEJxTW1aRlUzSjExTFZBT0ZBblU0UWJvUFQ5Z2NncmdDT1JJMXM2UEN6UnJC?= =?utf-8?B?UytjVUZxeTgzMkRMZWEvajA5SXpKeXhDdS92WVk5Y0Jtc0xTZDNURmRlQm5J?= =?utf-8?B?Y3BkVWgrampwRVZqWUpJNWZBc2EzTjNPcVFhb1VxS1MyK3FpSmt2enE1N2ky?= =?utf-8?B?TFU0cDhONTE5WTM5VkJHK2hwQVlBRlFIdjJnZUFjeGJMcFRZcWZjNE9DOUFk?= =?utf-8?B?SXo2YUJjbjdMMXMvZzlzVC9Ld3EvVXJZWThKK0cvSWgxK2U4SDdvbUM4d28v?= =?utf-8?B?NnFJVmNwSDZDVlRPOXhUN0FxUjBxUGhyVytoWUgyMSs5SkFyWDVSZy9kdUYv?= =?utf-8?B?a3JYWS9JM2UyUEp1MkZkM0JrWmJSK2trNlFrQWlQRStCQWN0b2cxU2k4L0Zv?= =?utf-8?B?bHM4S0IxOEF6ZWZZYWFicVZ4R2UrTHV4ZEpiVlUydGNCdnJtNHFDcjJLMHNF?= =?utf-8?B?UC9HTUlyeU1KUk1MSjdLQlVmc3pJSVJ2ZzRXNkpsZEcxQjB2THNkSm50cnhM?= =?utf-8?B?cHRDdkxqUEZqcitTTitIQ2VZaHhBSlNuSmRRUm1XejU2UjNrT3lsTFBCb1Nv?= =?utf-8?B?NW05eHNzZlI1elNielJ0OVJSRW5sTWVZVUgxSmJBMEM3VVdJMHJUTDN2TmNs?= =?utf-8?B?T2h3Vm92R3ZYS3c0OTJ2bjZXMUdyeE9lSDg0d2orVk94L1VjbHp0RHJNV1A4?= =?utf-8?B?UUtGbFVvYnVHTDBMcExleXBKRE0wdDRkbVJnOWx4UzBDekNMVUR3TGJtV0hN?= =?utf-8?B?L3d4UzJWVjl3NWl1ZDZOazBHbXB6SCtoejRGdUo2MjhGU3FHeFZJNDdSeFdk?= =?utf-8?B?SEVNS1VPSGF0Y0E4RUJleE0yTjJxbi9iS2Ntb0VmcGxpdHk2R0lEQXJBcXND?= =?utf-8?B?b0JwT3pmamdzeCtuMUFlQ0xJWUw4M1VET1VKMVlQNXpFdFpra2RJVElNVTk4?= =?utf-8?B?T0VIOTViNHlFcXlaNmtoRmVSKzgwdUt6a2VPOFFVNE1heFdId2ZjSEtBZUdJ?= =?utf-8?B?T3Z5a29VcFRPcWJyNlJtZjlKR2dKQ3BEQnNveE54V1phWUhTOXExY1RuSFF6?= =?utf-8?B?VmtqNzFuM1pZZjV5OXpmVm9YV09PeXQ4bDBCKy9nZjJvRSt6S2Vndk5BT2Rs?= =?utf-8?B?VDJGanJvS3A5SDlmYkcwMEs2NVk1eDVrQjRMV3NudTB5RFRYczRzZG1ucXlB?= =?utf-8?B?d2w4TmxBZHcyMXgrdHFFaVZ1ako0TFg3OFJaNFZpS1l5SXgyNVFkSE9SZFN5?= =?utf-8?B?cmFvMXcwejlSMmlSRXBPbTBYeDZ0Vk1XRkNLL2FKQ01keFN2dlJLWm1DTE1z?= =?utf-8?B?dUxtOUYyL2JlRE40WWlyQkkwdWVMbnZSVkU5QlJRdWlpTGIxcy91QT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78f2b456-6a2f-48c2-393f-08def31ae503 X-MS-Exchange-CrossTenant-AuthSource: IA1PR03MB8288.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 17:56:37.1113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kvp7iL3S1er8kkuyeoMjXpJHYB6e154Yvy2Nj7YonjR5vz0hRb0ho/WWuuFzmb5HiK0wEmBtUh3mcgdp1vq5JAOIBC25xsvebdC4rx7GnLs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5048 X-purgate-ID: tlsNG-42698a/1785952601-1B2DC9EA-40C466E9/0/0 X-purgate-type: clean X-purgate-size: 3491 On 05/08/2026 2:42 pm, Jan Beulich wrote: > On 05.08.2026 14:45, Andrew Cooper wrote: >> This is the start of a very long rabbit hole to address the >> mis-classification of some watchdog NMIs as non-watchdog NMIs. For >> now, just some simple and hopefully non-controvertial changes. >> >> https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/2733861049 >> >> Andrew Cooper (5): >> x86/nmi: Drop {reserve,release}_lapic_nmi() >> x86/nmi: Drop K7_NMI_EVENT >> x86/nmi: Misc style fixes >> x86/nmi: Check MSR_MISC_ENABLE for all Intel platforms >> x86/nmi: Don't configure EvtSel repeatedly >> >> xen/arch/x86/include/asm/apic.h | 2 - >> xen/arch/x86/nmi.c | 153 ++++++++++---------------------- >> 2 files changed, 47 insertions(+), 108 deletions(-) > This series, once again, is putting me in a difficult position: Should I look > at it, or should I let it sit for two years or more, just like my earlier > fixes in this area [1], [2] are? (Of course, as always so far, I will look at > the patches, and I will likely also accept them going in ahead of mine. But I > cannot exclude that at some point I might actually stop doing so, seeing how > many of my patches are in that state. While at the same time none of yours > are, afaict, i.e. as per the track record that I keep of what still needs > responding to.) > > Yes, you did respond to [1], but is not being comfortable with a change really > a reason to block it, when it _is_ an improvement, and when the alternative > hasn't materialized in all the time? > > Jan > > [1] https://lists.xen.org/archives/html/xen-devel/2024-01/msg01365.html > [2] https://lists.xen.org/archives/html/xen-devel/2024-04/msg00194.html I'd forgotten about these. Patch 1, I'm (still) distinctly uneasy about, but I dispute your claim that it is an improvement.  You are adding complexity and not fixing anything AFAICT. The watchdog counts NMIs (and counts incorrectly; this is the root issue I'm needing to fix).  A timeout is declared when a fixed number of NMIs (10, in default configuration) pass without the timer softirq having run. The rate of NMIs varies with P states, including lower than cpu_khz, and differs between cores.  In some but not all hardware, we could switch from Unhalted Cycles to Unhalted Reference Cycles, but even that has a bit caveat saying that the definition changed in 12th Generation. You are making the rate of the timer softirq dynamic, but it is an arbitrary fixed rate still unconnected to the rate of NMIs. The only fix is to make it safe for the NMI handler to read real time.  Until that time, in a choice between your patch and saying "well don't set watchdog_timeout=1 then", I'd firmly favour the latter because at least it means there's less to revert when a real fix does come along. For patch 2, I had figured that bug out independently though inspection, and yes I do agree it's an issue.  I was debating removing watchdog_timeout=, and agree with that aspect of the patch.  However, watchdog_force needs deleting to fix the incorrect counting, and with your /* reset to defaults */ you're breaking the incremental property we have of command line parsing elsewhere; specifically "watchdog=force watchdog=10s" now sets force to false. I will make sure to address this bug in my series, but I think it will be a fairly different patch when the other dust has settled. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:30:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:30:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383908.1627004 (Exim 4.92) (envelope-from ) id 1wrk8I-000191-Iz; Wed, 05 Aug 2026 22:30:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383908.1627004; Wed, 05 Aug 2026 22:30:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrk8I-00018t-DF; Wed, 05 Aug 2026 22:30:42 +0000 Received: by outflank-mailman (input) for mailman id 1383908; Wed, 05 Aug 2026 22:30:40 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrk8G-00018n-RB for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:30:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrk8F-00GHO2-F1 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:30:39 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73b977-5cb7-0a2a0a5109dd-0a2a4504ea92-16 for ; Thu, 06 Aug 2026 00:30:39 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73b98e-b57f-0a2a45040019-ac6904fe9736-3 for ; Thu, 06 Aug 2026 00:30:39 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 860B260A63; Wed, 5 Aug 2026 22:30:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D8DF1F000E9; Wed, 5 Aug 2026 22:30:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785969037; bh=UyQFCcMMSY/nbGntlznDMnICY2Uy0xvxXdgPyh8X9mI=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=nA4o5PUKLu5Wv3Zh23xrawOuZwiesBL+Dxbv59c0yLNJxxlb9OzysC1lbb+pTmbEB Jm8covCACK8+kqbiKbYME+GvCT9MgbNSg4WB7gDBfYgjoVWys6Wgdq84DV2L/R9uig nFSryxPCP/KCqg41N/Shytj15TmmuTTGMfTqntCYL9lqGOX953dPQbkszejKiayb1Z LKdiFW6nJUBumNhq8lcUgJDPEhPh1/pcrzG4XclhhrkISxmLVRZDwjOGH87wkuUhzM EOXXiRuSqMxUOAh2+67Sx3xC89MNCXObS5C3QS7jmIMUWiUZ3JEOtkWU8cBf98XIZb eNvaTplYNP/zw== Date: Wed, 5 Aug 2026 15:30:31 -0700 (PDT) From: Stefano Stabellini To: Juergen Gross cc: linux-kernel@vger.kernel.org, x86@kernel.org, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/4] x86/xen: Remove redundant config dependency on X86_LOCAL_APIC In-Reply-To: <20260805082137.1214967-2-jgross@suse.com> Message-ID: <740aa008-a1ec-5c94-27cd-afad1f1b0495@kernel.org> References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-ebf023/1785969039-528C9B50-4F71B5FC/0/0 X-purgate-type: clean X-purgate-size: 765 On Wed, 5 Aug 2026, Juergen Gross wrote: > CONFIG_XEN depends on CONFIG_X86_LOCAL_APIC already, so the dependency > of CONFIG_XEN_PVHVM on CONFIG_X86_LOCAL_APIC can be dropped. > > Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini > --- > arch/x86/xen/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > index 99b06f5c47cd..bb420a4cb75f 100644 > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -52,7 +52,7 @@ config XEN_PV_DOM0 > > config XEN_PVHVM > def_bool y > - depends on XEN && X86_LOCAL_APIC > + depends on XEN > > config XEN_PVHVM_SMP > def_bool y > -- > 2.55.0 > > From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:38:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:38:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383920.1627012 (Exim 4.92) (envelope-from ) id 1wrkFq-0001lO-6Z; Wed, 05 Aug 2026 22:38:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383920.1627012; Wed, 05 Aug 2026 22:38:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkFq-0001lH-3r; Wed, 05 Aug 2026 22:38:30 +0000 Received: by outflank-mailman (input) for mailman id 1383920; Wed, 05 Aug 2026 22:38:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkFo-0001lB-5H for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:38:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkFn-008Rbs-90 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:38:27 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73bb0d-e002-0a2a0a5209dd-0a2a4503e7a4-46 for ; Thu, 06 Aug 2026 00:38:27 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73bb61-fae8-0a2a45030019-888fbc3352c7-3 for ; Thu, 06 Aug 2026 00:38:26 +0200 Received: by mx.zohomail.com with SMTPS id 1785969494811920.453860135087; Wed, 5 Aug 2026 15:38:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785969497; cv=none; d=zohomail.com; s=zohoarc; b=WMZ0tV0vDY58A1Y2BQNAxpQ7qR3vhS2nDHJ5z6vK3NggI2JpKZlUuxQRO/TCMlPqmHJJsek04N0NaydwJ3LvtleXKutHbvedcQNwRvGXZ1K+zJ5osbI6BE0IFs8F6no14EdfDpEm6Z4ucqKbXScKRWGwSJFzLqfD3RlzM75EWBg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785969497; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=ttnFYpU9leG8PdYp6bKDfbnCt02hGSvDeDU0wyx0J6M=; b=OZjP6ViM/UGD1VPRjqlJ33uVjm0uvOk7hDgLP7rt9h7NWTNa7wyzXfzQs0U0wZ91r6PYZT3mVTjNcM/MwsTMrJ46SvLAK+9Uy8Pwo7B6UmZ3SfJlkVDBnmFl9ppqjIAuzOF11yUgPDUddQ9jLV6/+46pj3lMPfSL75RbEVlLUHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785969497; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ttnFYpU9leG8PdYp6bKDfbnCt02hGSvDeDU0wyx0J6M=; b=Z8Ug7BYh1Rd3sa+dU5SlLQpddjmWhBCmFIkNoESM7vqEUhlSfW4k75gkeCjPsMO+ Wa4pC79On7+tJbqjKNlJ/D7uL7+8AYdPg/ZxZhuAKH8QIUrDkoM6a5u7kTSrRzwsiQF zaV/3XzCAUoQF9SBwunB0tryCPuFeW5lJWNxxFxk= Message-ID: Date: Wed, 5 Aug 2026 18:38:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/24] x86: restrict PHYSDEVOP_* when PV=n To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <5b3ba207-aa18-4ebe-9c8b-2ccf51240698@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <5b3ba207-aa18-4ebe-9c8b-2ccf51240698@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-33051d/1785969507-76AF94E9-E366E1AD/0/0 X-purgate-type: clean X-purgate-size: 5015 On 7/28/26 9:19 AM, Jan Beulich wrote: > hvm_physdev_op() permits through only a subset of sub-ops. The code > handling other sub-ops is therefore unreachable when PV=n, violating MISRA > C:2012 rule 2.1. With that the XSM .apic() hook also becomes unreachable / > dead when PV=n. > > Signed-off-by: Jan Beulich > --- > At least for the sub-ops using xsm_apic() IS_ENABLED() cannot be used. > Therefore #ifdef is used throughout. > > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -233,6 +233,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H > break; > } > > +#ifdef CONFIG_PV > + > case PHYSDEVOP_pirq_eoi_gmfn_v2: > case PHYSDEVOP_pirq_eoi_gmfn_v1: { > struct physdev_pirq_eoi_gmfn info; > @@ -281,6 +283,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H > break; > } > > +#endif /* CONFIG_PV */ > + > case PHYSDEVOP_irq_status_query: { > struct physdev_irq_status_query irq_status_query; > ret = -EFAULT; > @@ -379,6 +383,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H > break; > } > > +#ifdef CONFIG_PV > + > case PHYSDEVOP_apic_read: { > struct physdev_apic apic; > ret = -EFAULT; > @@ -524,6 +530,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H > break; > } > > +#endif /* CONFIG_PV */ > + > case PHYSDEVOP_pci_mmcfg_reserved: { > struct physdev_pci_mmcfg_reserved info; > > @@ -558,6 +566,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H > break; > } > > +#ifdef CONFIG_PV > + > case PHYSDEVOP_restore_msi: { > struct physdev_restore_msi restore_msi; > struct pci_dev *pdev; > @@ -589,6 +599,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H > break; > } > > +#endif /* CONFIG_PV */ > + > case PHYSDEVOP_setup_gsi: { > struct physdev_setup_gsi setup_gsi; > > @@ -608,6 +620,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H > setup_gsi.polarity); > break; > } > + > case PHYSDEVOP_get_free_pirq: { > struct physdev_get_free_pirq out; > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -648,13 +648,6 @@ static XSM_INLINE int cf_check xsm_mem_s > return xsm_default_action(action, current->domain, cd); > } > > -static XSM_INLINE int cf_check xsm_apic( > - XSM_DEFAULT_ARG struct domain *d, int cmd) > -{ > - XSM_ASSERT_ACTION(XSM_PRIV); > - return xsm_default_action(action, d, NULL); > -} > - > static XSM_INLINE int cf_check xsm_machine_memory_map(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > @@ -670,6 +663,13 @@ static XSM_INLINE int cf_check xsm_domai > > #ifdef CONFIG_PV > > +static XSM_INLINE int cf_check xsm_apic( > + XSM_DEFAULT_ARG struct domain *d, int cmd) > +{ > + XSM_ASSERT_ACTION(XSM_PRIV); > + return xsm_default_action(action, d, NULL); > +} > + > static XSM_INLINE int cf_check xsm_do_mca(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -131,10 +131,10 @@ XSM_HOOK(int, mem_sharing_op, struct dom > XSM_HOOK(int, platform_op, uint32_t) > > #ifdef CONFIG_X86 > -XSM_HOOK(int, apic, struct domain *, int) > XSM_HOOK(int, machine_memory_map) > XSM_HOOK(int, domain_memory_map, struct domain *) > #ifdef CONFIG_PV > +XSM_HOOK(int, apic, struct domain *, int) > XSM_HOOK(int, do_mca) > XSM_HOOK(int, mmu_update, struct domain *, struct domain *, struct domain *, > uint32_t) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1749,6 +1749,19 @@ static int cf_check flask_mem_sharing_op > } > #endif > > +static int cf_check flask_machine_memory_map(void) > +{ > + return avc_current_has_perm(SECINITSID_XEN, SECCLASS_MMU, MMU__MEMORYMAP, > + NULL); > +} > + > +static int cf_check flask_domain_memory_map(struct domain *d) > +{ > + return current_has_perm(d, SECCLASS_MMU, MMU__MEMORYMAP); > +} > + > +#ifdef CONFIG_PV > + > static int cf_check flask_apic(struct domain *d, int cmd) > { > uint32_t perm; > @@ -1769,18 +1782,6 @@ static int cf_check flask_apic(struct do > return domain_has_xen(d, perm); > } > > -static int cf_check flask_machine_memory_map(void) > -{ > - return avc_current_has_perm(SECINITSID_XEN, SECCLASS_MMU, MMU__MEMORYMAP, NULL); > -} > - > -static int cf_check flask_domain_memory_map(struct domain *d) > -{ > - return current_has_perm(d, SECCLASS_MMU, MMU__MEMORYMAP); > -} > - > -#ifdef CONFIG_PV > - > static int cf_check flask_do_mca(void) > { > return domain_has_xen(current->domain, XEN__MCA_OP); > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:39:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:39:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383926.1627021 (Exim 4.92) (envelope-from ) id 1wrkGx-0002GW-EC; Wed, 05 Aug 2026 22:39:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383926.1627021; Wed, 05 Aug 2026 22:39:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkGx-0002GP-BZ; Wed, 05 Aug 2026 22:39:39 +0000 Received: by outflank-mailman (input) for mailman id 1383926; Wed, 05 Aug 2026 22:39:37 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkGv-0002GC-Lz for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:39:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkGv-008Rbs-2v for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:39:37 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73bb8e-e002-0a2a0a5209dd-0a2a4506c7a2-18 for ; Thu, 06 Aug 2026 00:39:37 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73bba7-195a-0a2a45060019-888fbc3352cb-3 for ; Thu, 06 Aug 2026 00:39:36 +0200 Received: by mx.zohomail.com with SMTPS id 17859695700809.225365282640382; Wed, 5 Aug 2026 15:39:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785969572; cv=none; d=zohomail.com; s=zohoarc; b=DfC6AhuciVKP71ZJ6MlUTWDfiOrwlWYQrlJlx9nRhQMI3pHlZ/b6GkASfxkxzukVYn/oPr+d/Cnp0YNdtyyB5gFyIf/VuRf4Yy74SaMVLiHRR2xb0uyg5dEmm4+7NrkCYVikjAbp0cNe6Y4WklzJXn01IeVDLxfjH9daBGFt/20= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785969572; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=55C6XabZ5c/mpGx9kDIAwy5gjkAlqjWC61nxx1cPiSg=; b=EZ/Mr+o43rx1hFhK70VJem6hyiL0u/36Mw5EkTZ1Y9p9YMxG6b0bcpq36bIJA0LP5zT4u9C63FbPB8kQF39Tt/qpR/A6p7MgTUgnho55RvwSlrOvNh8t+YjYSL4zSvXf4X/Jq20jnsx1EnEHy6khW8ubXloRroa4ORHumRaTHss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785969572; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=55C6XabZ5c/mpGx9kDIAwy5gjkAlqjWC61nxx1cPiSg=; b=JQVP1zI4rs4dO2W4y23Jst5LQWCxXeMuP2TS905Z8890bopwCqGNb+9ZLTYI5W+m W43aiE+dNdwo30reEJr4R304guq6bF+xF4TVs4B7lIgLs6Au7AwDvsPyJKZjGjFUi+B WLZjKaDmIIn0ctAnjLfDNks0lClkPtqKOXg0v4DQ= Message-ID: <06a151ca-df45-4fc5-b52a-23f7b02f41b6@apertussolutions.com> Date: Wed, 5 Aug 2026 18:39:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/24] XSM/dummy: fold cf_check into XSM_INLINE To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <6c8f1317-5dd0-4f91-b1b1-820fb43b5c39@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <6c8f1317-5dd0-4f91-b1b1-820fb43b5c39@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-16d1c6/1785969577-FE87577B-3442C33D/0/0 X-purgate-type: clean X-purgate-size: 25615 On 7/28/26 9:19 AM, Jan Beulich wrote: > Use of cf_check together with always_inline is pretty pointless, and with > XSM=n none of the dummy handlers are supposed to have their address taken. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -54,7 +54,7 @@ void __xsm_action_mismatch_detected(void > * There is no xsm_default_t argument available, so the value from the assertion > * is used to initialize the variable. > */ > -#define XSM_INLINE __maybe_unused > +#define XSM_INLINE __maybe_unused cf_check > > #define XSM_DEFAULT_ARG /* */ > #define XSM_DEFAULT_VOID void > @@ -104,7 +104,7 @@ static always_inline int xsm_default_act > } > } > > -static XSM_INLINE int cf_check xsm_set_system_active(void) > +static XSM_INLINE int xsm_set_system_active(void) > { > struct domain *d = current->domain; > > @@ -121,34 +121,34 @@ static XSM_INLINE int cf_check xsm_set_s > return 0; > } > > -static XSM_INLINE void cf_check xsm_security_domaininfo( > +static XSM_INLINE void xsm_security_domaininfo( > struct domain *d, struct xen_domctl_getdomaininfo *info) > { > return; > } > > -static XSM_INLINE int cf_check xsm_domain_create( > +static XSM_INLINE int xsm_domain_create( > XSM_DEFAULT_ARG struct domain *d, uint32_t ssidref) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_getdomaininfo( > +static XSM_INLINE int xsm_getdomaininfo( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_XS_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_set_target( > +static XSM_INLINE int xsm_set_target( > XSM_DEFAULT_ARG struct domain *d, struct domain *e) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > > -static XSM_INLINE int cf_check xsm_domctl( > +static XSM_INLINE int xsm_domctl( > XSM_DEFAULT_ARG struct domain *d, struct xen_domctl *op) > { > XSM_ASSERT_ACTION(XSM_PRIV); > @@ -174,61 +174,61 @@ static XSM_INLINE int cf_check xsm_domct > } > } > > -static XSM_INLINE int cf_check xsm_sysctl( > +static XSM_INLINE int xsm_sysctl( > XSM_DEFAULT_ARG const struct xen_sysctl *op) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > > -static XSM_INLINE int cf_check xsm_alloc_security_domain(struct domain *d) > +static XSM_INLINE int xsm_alloc_security_domain(struct domain *d) > { > return 0; > } > > -static XSM_INLINE void cf_check xsm_free_security_domain(struct domain *d) > +static XSM_INLINE void xsm_free_security_domain(struct domain *d) > { > return; > } > > #ifdef CONFIG_GRANT_TABLE > > -static XSM_INLINE int cf_check xsm_grant_mapref( > +static XSM_INLINE int xsm_grant_mapref( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2, uint32_t flags) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_grant_unmapref( > +static XSM_INLINE int xsm_grant_unmapref( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_grant_setup( > +static XSM_INLINE int xsm_grant_setup( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_grant_transfer( > +static XSM_INLINE int xsm_grant_transfer( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_grant_copy( > +static XSM_INLINE int xsm_grant_copy( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_grant_query_size( > +static XSM_INLINE int xsm_grant_query_size( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > @@ -237,28 +237,28 @@ static XSM_INLINE int cf_check xsm_grant > > #endif /* CONFIG_GRANT_TABLE */ > > -static XSM_INLINE int cf_check xsm_memory_exchange( > +static XSM_INLINE int xsm_memory_exchange( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_memory_adjust_reservation( > +static XSM_INLINE int xsm_memory_adjust_reservation( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_memory_stat_reservation( > +static XSM_INLINE int xsm_memory_stat_reservation( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_console_io( > +static XSM_INLINE int xsm_console_io( > XSM_DEFAULT_ARG struct domain *d, int cmd) > { > XSM_ASSERT_ACTION(XSM_OTHER); > @@ -272,21 +272,21 @@ static XSM_INLINE int cf_check xsm_conso > } > > #ifdef CONFIG_KEXEC > -static XSM_INLINE int cf_check xsm_kexec(XSM_DEFAULT_VOID) > +static XSM_INLINE int xsm_kexec(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > #endif > > -static XSM_INLINE int cf_check xsm_schedop_shutdown( > +static XSM_INLINE int xsm_schedop_shutdown( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_memory_pin_page( > +static XSM_INLINE int xsm_memory_pin_page( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2, > struct page_info *page) > { > @@ -294,20 +294,20 @@ static XSM_INLINE int cf_check xsm_memor > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d) > +static XSM_INLINE int xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_evtchn_unbound( > +static XSM_INLINE int xsm_evtchn_unbound( > XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn, domid_t id2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_evtchn_interdomain( > +static XSM_INLINE int xsm_evtchn_interdomain( > XSM_DEFAULT_ARG struct domain *d1, struct evtchn *chan1, struct domain *d2, > struct evtchn *chan2) > { > @@ -315,72 +315,72 @@ static XSM_INLINE int cf_check xsm_evtch > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE void cf_check xsm_evtchn_close_post(struct evtchn *chn) > +static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn) > { > return; > } > > -static XSM_INLINE int cf_check xsm_evtchn_send( > +static XSM_INLINE int xsm_evtchn_send( > XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, d, NULL); > } > > -static XSM_INLINE int cf_check xsm_evtchn_status( > +static XSM_INLINE int xsm_evtchn_status( > XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_evtchn_reset( > +static XSM_INLINE int xsm_evtchn_reset( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_alloc_security_evtchns( > +static XSM_INLINE int xsm_alloc_security_evtchns( > struct evtchn chn[], unsigned int nr) > { > return 0; > } > > -static XSM_INLINE void cf_check xsm_free_security_evtchns( > +static XSM_INLINE void xsm_free_security_evtchns( > struct evtchn chn[], unsigned int nr) > { > return; > } > > -static XSM_INLINE char *cf_check xsm_show_security_evtchn( > +static XSM_INLINE char *xsm_show_security_evtchn( > struct domain *d, const struct evtchn *chn) > { > return NULL; > } > > -static XSM_INLINE int cf_check xsm_init_hardware_domain( > +static XSM_INLINE int xsm_init_hardware_domain( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_get_pod_target( > +static XSM_INLINE int xsm_get_pod_target( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_set_pod_target( > +static XSM_INLINE int xsm_set_pod_target( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_get_vnumainfo( > +static XSM_INLINE int xsm_get_vnumainfo( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_TARGET); > @@ -388,7 +388,7 @@ static XSM_INLINE int cf_check xsm_get_v > } > > #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) > -static XSM_INLINE int cf_check xsm_get_device_group( > +static XSM_INLINE int xsm_get_device_group( > XSM_DEFAULT_ARG uint32_t machine_bdf) > { > XSM_ASSERT_ACTION(XSM_PRIV); > @@ -398,14 +398,14 @@ static XSM_INLINE int cf_check xsm_get_d > > #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) > > -static XSM_INLINE int cf_check xsm_resource_plug_pci( > +static XSM_INLINE int xsm_resource_plug_pci( > XSM_DEFAULT_ARG uint32_t machine_bdf) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > > -static XSM_INLINE int cf_check xsm_resource_unplug_pci( > +static XSM_INLINE int xsm_resource_unplug_pci( > XSM_DEFAULT_ARG uint32_t machine_bdf) > { > XSM_ASSERT_ACTION(XSM_PRIV); > @@ -416,14 +416,14 @@ static XSM_INLINE int cf_check xsm_resou > > #ifdef CONFIG_HAS_PCI > > -static XSM_INLINE int cf_check xsm_resource_setup_pci( > +static XSM_INLINE int xsm_resource_setup_pci( > XSM_DEFAULT_ARG uint32_t machine_bdf) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > > -static XSM_INLINE int cf_check xsm_resource_setup_gsi(XSM_DEFAULT_ARG int gsi) > +static XSM_INLINE int xsm_resource_setup_gsi(XSM_DEFAULT_ARG int gsi) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > @@ -431,47 +431,47 @@ static XSM_INLINE int cf_check xsm_resou > > #endif /* CONFIG_HAS_PCI */ > > -static XSM_INLINE int cf_check xsm_resource_setup_misc(XSM_DEFAULT_VOID) > +static XSM_INLINE int xsm_resource_setup_misc(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > > #ifdef CONFIG_HYPFS > -static XSM_INLINE int cf_check xsm_hypfs_op(XSM_DEFAULT_VOID) > +static XSM_INLINE int xsm_hypfs_op(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > #endif > > -static XSM_INLINE long cf_check xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > +static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > { > return -ENOSYS; > } > > #ifdef CONFIG_COMPAT > -static XSM_INLINE int cf_check xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) > +static XSM_INLINE int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) > { > return -ENOSYS; > } > #endif > > -static XSM_INLINE char *cf_check xsm_show_irq_sid(int irq) > +static XSM_INLINE char *xsm_show_irq_sid(int irq) > { > return NULL; > } > > #ifdef CONFIG_HAS_PIRQ > > -static XSM_INLINE int cf_check xsm_map_domain_pirq( > +static XSM_INLINE int xsm_map_domain_pirq( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_unmap_domain_pirq( > +static XSM_INLINE int xsm_unmap_domain_pirq( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > @@ -480,49 +480,49 @@ static XSM_INLINE int cf_check xsm_unmap > > #endif /* CONFIG_HAS_PIRQ */ > > -static XSM_INLINE int cf_check xsm_map_domain_irq( > +static XSM_INLINE int xsm_map_domain_irq( > XSM_DEFAULT_ARG struct domain *d, int irq, const void *data) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_bind_pt_irq( > +static XSM_INLINE int xsm_bind_pt_irq( > XSM_DEFAULT_ARG struct domain *d, struct xen_domctl_bind_pt_irq *bind) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_unbind_pt_irq( > +static XSM_INLINE int xsm_unbind_pt_irq( > XSM_DEFAULT_ARG struct domain *d, struct xen_domctl_bind_pt_irq *bind) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_unmap_domain_irq( > +static XSM_INLINE int xsm_unmap_domain_irq( > XSM_DEFAULT_ARG struct domain *d, int irq, const void *data) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_irq_permission( > +static XSM_INLINE int xsm_irq_permission( > XSM_DEFAULT_ARG struct domain *d, int pirq, uint8_t allow) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_iomem_permission( > +static XSM_INLINE int xsm_iomem_permission( > XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_iomem_mapping( > +static XSM_INLINE int xsm_iomem_mapping( > XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > @@ -530,7 +530,7 @@ static XSM_INLINE int cf_check xsm_iomem > } > > #ifdef CONFIG_HAS_VPCI > -static XSM_INLINE int cf_check xsm_iomem_mapping_vpci( > +static XSM_INLINE int xsm_iomem_mapping_vpci( > XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) > { > XSM_ASSERT_ACTION(XSM_HOOK); > @@ -539,7 +539,7 @@ static XSM_INLINE int cf_check xsm_iomem > #endif > > #ifdef CONFIG_HAS_PCI > -static XSM_INLINE int cf_check xsm_pci_config_permission( > +static XSM_INLINE int xsm_pci_config_permission( > XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf, uint16_t start, > uint16_t end, uint8_t access) > { > @@ -548,21 +548,21 @@ static XSM_INLINE int cf_check xsm_pci_c > } > #endif /* CONFIG_HAS_PCI */ > > -static XSM_INLINE int cf_check xsm_add_to_physmap( > +static XSM_INLINE int xsm_add_to_physmap( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_remove_from_physmap( > +static XSM_INLINE int xsm_remove_from_physmap( > XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d1, d2); > } > > -static XSM_INLINE int cf_check xsm_map_gmfn_foreign( > +static XSM_INLINE int xsm_map_gmfn_foreign( > XSM_DEFAULT_ARG struct domain *d, struct domain *t) > { > XSM_ASSERT_ACTION(XSM_TARGET); > @@ -571,14 +571,14 @@ static XSM_INLINE int cf_check xsm_map_g > > #ifdef CONFIG_HVM > > -static XSM_INLINE int cf_check xsm_hvm_param( > +static XSM_INLINE int xsm_hvm_param( > XSM_DEFAULT_ARG struct domain *d, unsigned long op) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_hvm_param_altp2mhvm( > +static XSM_INLINE int xsm_hvm_param_altp2mhvm( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_PRIV); > @@ -588,7 +588,7 @@ static XSM_INLINE int cf_check xsm_hvm_p > #endif /* CONFIG_HVM */ > > #ifdef CONFIG_ALTP2M > -static XSM_INLINE int cf_check xsm_hvm_altp2mhvm_op( > +static XSM_INLINE int xsm_hvm_altp2mhvm_op( > XSM_DEFAULT_ARG struct domain *d, uint64_t mode, uint32_t op) > { > XSM_ASSERT_ACTION(XSM_OTHER); > @@ -610,7 +610,7 @@ static XSM_INLINE int cf_check xsm_hvm_a > #endif /* CONFIG_ALTP2M */ > > #ifdef CONFIG_VM_EVENT > -static XSM_INLINE int cf_check xsm_mem_access(XSM_DEFAULT_ARG struct domain *d) > +static XSM_INLINE int xsm_mem_access(XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > @@ -618,7 +618,7 @@ static XSM_INLINE int cf_check xsm_mem_a > #endif > > #ifdef CONFIG_MEM_PAGING > -static XSM_INLINE int cf_check xsm_mem_paging(XSM_DEFAULT_ARG struct domain *d) > +static XSM_INLINE int xsm_mem_paging(XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > @@ -626,14 +626,14 @@ static XSM_INLINE int cf_check xsm_mem_p > #endif > > #ifdef CONFIG_MEM_SHARING > -static XSM_INLINE int cf_check xsm_mem_sharing(XSM_DEFAULT_ARG struct domain *d) > +static XSM_INLINE int xsm_mem_sharing(XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > #endif > > -static XSM_INLINE int cf_check xsm_platform_op(XSM_DEFAULT_ARG uint32_t op) > +static XSM_INLINE int xsm_platform_op(XSM_DEFAULT_ARG uint32_t op) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > @@ -641,20 +641,20 @@ static XSM_INLINE int cf_check xsm_platf > > #ifdef CONFIG_X86 > > -static XSM_INLINE int cf_check xsm_mem_sharing_op( > +static XSM_INLINE int xsm_mem_sharing_op( > XSM_DEFAULT_ARG struct domain *d, struct domain *cd, int op) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, cd); > } > > -static XSM_INLINE int cf_check xsm_machine_memory_map(XSM_DEFAULT_VOID) > +static XSM_INLINE int xsm_machine_memory_map(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > > -static XSM_INLINE int cf_check xsm_domain_memory_map( > +static XSM_INLINE int xsm_domain_memory_map( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_TARGET); > @@ -663,20 +663,20 @@ static XSM_INLINE int cf_check xsm_domai > > #ifdef CONFIG_PV > > -static XSM_INLINE int cf_check xsm_apic( > +static XSM_INLINE int xsm_apic( > XSM_DEFAULT_ARG struct domain *d, int cmd) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, d, NULL); > } > > -static XSM_INLINE int cf_check xsm_do_mca(XSM_DEFAULT_VOID) > +static XSM_INLINE int xsm_do_mca(XSM_DEFAULT_VOID) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, NULL); > } > > -static XSM_INLINE int cf_check xsm_mmu_update( > +static XSM_INLINE int xsm_mmu_update( > XSM_DEFAULT_ARG struct domain *d, struct domain *t, struct domain *f, > uint32_t flags) > { > @@ -689,14 +689,14 @@ static XSM_INLINE int cf_check xsm_mmu_u > return rc; > } > > -static XSM_INLINE int cf_check xsm_mmuext_op( > +static XSM_INLINE int xsm_mmuext_op( > XSM_DEFAULT_ARG struct domain *d, struct domain *f) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d, f); > } > > -static XSM_INLINE int cf_check xsm_update_va_mapping( > +static XSM_INLINE int xsm_update_va_mapping( > XSM_DEFAULT_ARG struct domain *d, struct domain *f, l1_pgentry_t pte) > { > XSM_ASSERT_ACTION(XSM_TARGET); > @@ -706,7 +706,7 @@ static XSM_INLINE int cf_check xsm_updat > #endif /* CONFIG_PV */ > > #if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) > -static XSM_INLINE int cf_check xsm_priv_mapping( > +static XSM_INLINE int xsm_priv_mapping( > XSM_DEFAULT_ARG struct domain *d, struct domain *t) > { > XSM_ASSERT_ACTION(XSM_TARGET); > @@ -714,21 +714,21 @@ static XSM_INLINE int cf_check xsm_priv_ > } > #endif > > -static XSM_INLINE int cf_check xsm_ioport_permission( > +static XSM_INLINE int xsm_ioport_permission( > XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_ioport_mapping( > +static XSM_INLINE int xsm_ioport_mapping( > XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > -static XSM_INLINE int cf_check xsm_pmu_op( > +static XSM_INLINE int xsm_pmu_op( > XSM_DEFAULT_ARG struct domain *d, unsigned int op) > { > XSM_ASSERT_ACTION(XSM_OTHER); > @@ -747,7 +747,7 @@ static XSM_INLINE int cf_check xsm_pmu_o > #endif /* CONFIG_X86 */ > > #ifdef CONFIG_IOREQ_SERVER > -static XSM_INLINE int cf_check xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) > +static XSM_INLINE int xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > @@ -755,24 +755,24 @@ static XSM_INLINE int cf_check xsm_dm_op > #endif > > #ifdef CONFIG_ARGO > -static XSM_INLINE int cf_check xsm_argo_enable(const struct domain *d) > +static XSM_INLINE int xsm_argo_enable(const struct domain *d) > { > return 0; > } > > -static XSM_INLINE int cf_check xsm_argo_register_single_source( > +static XSM_INLINE int xsm_argo_register_single_source( > const struct domain *d, const struct domain *t) > { > return 0; > } > > -static XSM_INLINE int cf_check xsm_argo_register_any_source( > +static XSM_INLINE int xsm_argo_register_any_source( > const struct domain *d) > { > return 0; > } > > -static XSM_INLINE int cf_check xsm_argo_send( > +static XSM_INLINE int xsm_argo_send( > const struct domain *d, const struct domain *t) > { > return 0; > @@ -780,7 +780,7 @@ static XSM_INLINE int cf_check xsm_argo_ > > #endif /* CONFIG_ARGO */ > > -static XSM_INLINE int cf_check xsm_get_domain_state( > +static XSM_INLINE int xsm_get_domain_state( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_XS_PRIV); > @@ -788,7 +788,7 @@ static XSM_INLINE int cf_check xsm_get_d > } > > #include > -static XSM_INLINE int cf_check xsm_xen_version(XSM_DEFAULT_ARG uint32_t op) > +static XSM_INLINE int xsm_xen_version(XSM_DEFAULT_ARG uint32_t op) > { > XSM_ASSERT_ACTION(XSM_OTHER); > switch ( op ) > @@ -815,7 +815,7 @@ static XSM_INLINE int cf_check xsm_xen_v > } > } > > -static XSM_INLINE int cf_check xsm_domain_resource_map( > +static XSM_INLINE int xsm_domain_resource_map( > XSM_DEFAULT_ARG struct domain *d) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:40:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:40:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383935.1627029 (Exim 4.92) (envelope-from ) id 1wrkHi-0003kb-P2; Wed, 05 Aug 2026 22:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383935.1627029; Wed, 05 Aug 2026 22:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkHi-0003kU-MU; Wed, 05 Aug 2026 22:40:26 +0000 Received: by outflank-mailman (input) for mailman id 1383935; Wed, 05 Aug 2026 22:40:25 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkHh-0003kK-PW for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:40:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkHh-008Rno-6f for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:40:25 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73bb5e-bab6-0a2a0a5309dd-0a2a4504a8f0-48 for ; Thu, 06 Aug 2026 00:40:25 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73bbd7-b57f-0a2a45040019-888fbc3352ce-3 for ; Thu, 06 Aug 2026 00:40:24 +0200 Received: by mx.zohomail.com with SMTPS id 1785969620651244.58061568349672; Wed, 5 Aug 2026 15:40:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785969621; cv=none; d=zohomail.com; s=zohoarc; b=CP9Blk9FJeGRefQp4c4yqBJdZ14hNzBaYbAHq0DfWpYvAVDPl8x8DnSEYWBbw93C+IbkRTvKnyWYLiX373qgMkE4TZVvOhBmhF96ZWJ0B4hayGl7d2/PjkWEqvfPn4J03RQQ/Ip4QQlE0AcOScGi1XOZ1pkqUBffDzh+hD8u0dQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785969621; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=exdTnw8wAxnwKL2WEgMO2tqs2wU8iaIgCY+olaqOOdI=; b=DONCxbJeBfuy25e6KJglT1mpIFc0+dA8ENywiD8Q9k2NBi3YTyTI72ERk+9EZuDKw0JNbixMgOSC+xpnWjTu9XjOMYj5/fH+ia6wrM6Q6JMS4aL/33VUHm5MHjtcrzG8tpYI/1CGxQueKxaxkgJWCVeyRW1AqdbHncLkpJ21Yto= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785969621; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=exdTnw8wAxnwKL2WEgMO2tqs2wU8iaIgCY+olaqOOdI=; b=A2awKJGYKNjdvolabq9kmneyZdC8CK789na+aZia6l39MesECoIm+17UXjqcnXPT lJo0eQvpwHdi1I7zQ4bOBAIG7qf6sJVTn3LRNTSJiKC/MzT3xRIRA5LMyiYI3wZeuj1 lb/rEF/LaCMQAyrbrGLSyOESyDUtyilHnw7oQM7E= Message-ID: Date: Wed, 5 Aug 2026 18:40:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 15/24] XSM/dummy: drop redundant return statements To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-ebf023/1785969625-C10DDB50-BB59C97B/0/0 X-purgate-type: clean X-purgate-size: 1457 On 7/28/26 9:20 AM, Jan Beulich wrote: > They're meaningless when no value is returned. > > Signed-off-by: Jan Beulich > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -123,9 +123,7 @@ static XSM_INLINE int xsm_set_system_act > > static XSM_INLINE void xsm_security_domaininfo( > struct domain *d, struct xen_domctl_getdomaininfo *info) > -{ > - return; > -} > +{} > > static XSM_INLINE int xsm_domain_create( > XSM_DEFAULT_ARG struct domain *d, uint32_t ssidref) > @@ -187,9 +185,7 @@ static XSM_INLINE int xsm_alloc_security > } > > static XSM_INLINE void xsm_free_security_domain(struct domain *d) > -{ > - return; > -} > +{} > > #ifdef CONFIG_GRANT_TABLE > > @@ -316,9 +312,7 @@ static XSM_INLINE int xsm_evtchn_interdo > } > > static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn) > -{ > - return; > -} > +{} > > static XSM_INLINE int xsm_evtchn_send( > XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn) > @@ -349,9 +343,7 @@ static XSM_INLINE int xsm_alloc_security > > static XSM_INLINE void xsm_free_security_evtchns( > struct evtchn chn[], unsigned int nr) > -{ > - return; > -} > +{} > > static XSM_INLINE char *xsm_show_security_evtchn( > struct domain *d, const struct evtchn *chn) > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:42:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:42:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383946.1627040 (Exim 4.92) (envelope-from ) id 1wrkK0-0004IO-58; Wed, 05 Aug 2026 22:42:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383946.1627040; Wed, 05 Aug 2026 22:42:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkK0-0004IH-1F; Wed, 05 Aug 2026 22:42:48 +0000 Received: by outflank-mailman (input) for mailman id 1383946; Wed, 05 Aug 2026 22:42:47 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkJz-0004IA-6w for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:42:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkJx-00GIdT-Vw for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:42:45 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73bc64-2eae-0a2a0a5409dd-0a2a450b81b2-4 for ; Thu, 06 Aug 2026 00:42:45 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73bc64-b7e8-0a2a450b0019-888fbc335273-3 for ; Thu, 06 Aug 2026 00:42:45 +0200 Received: by mx.zohomail.com with SMTPS id 1785969752886426.49762714455005; Wed, 5 Aug 2026 15:42:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785969756; cv=none; d=zohomail.com; s=zohoarc; b=OtjRAeOB3W63X7nJO+6k23SAistada/5vTpF/PZIMtgwD0YaABmYuUFYNVKXvyjtj+v4i0gHXlWU7sa7o3/fssc1cGFO0grBBW1JO4csYdGIEwYQgRGmWhxHHVktQ4mbOE8TEvT008gqkc20LumRDKHW2/n4BXRJ1bOKABumwU8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785969756; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=lruKykF7Bez3AHxlAg46tPNe7nOSsS4PSeVZZpQY56U=; b=SUs/P0uuFq+gnC2gKkL2KfEZF9eLXnAQiHvjmv7tVVL4t3B016Sc6QzrT3Q3es5Y3AUeqqU++Mt221etNFzIgf1LXOe0V5wuizGE8/1UeXgx8i4GIVU2+XVECsKEXr3PM4q2weadv0A0uZ6WZ4PnD+3b+Pc8QhtBRz6rzWlWJXM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785969756; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=lruKykF7Bez3AHxlAg46tPNe7nOSsS4PSeVZZpQY56U=; b=GClTKLDY4y3an7YY3lUOwM//tackaflunC+/xBpeSNvDPPNtwEPjNSJMHBEO1fJ8 W11o17NJBMs0lRsijG0OfCzyHQDVd3JI/qTp6YbtgvSR8AC9xSlGE7GFUOhjiVNxOCf cBbga1ufKeBK/7iTE2VYHhQB/sstHRZ8jGF6r4Go= Message-ID: Date: Wed, 5 Aug 2026 18:42:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/24] XSM: suppress hypercall when XSM=n To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-42698a/1785969765-AB8D19EA-98C82AB8/0/0 X-purgate-type: clean X-purgate-size: 3089 On 7/28/26 9:20 AM, Jan Beulich wrote: > This can be easily done in hypercall-defs.c, thus avoiding the need to > dive into xsm/ when building Xen, just to add code which does what is done > for an absent hypercall handler anyway (returning -ENOSYS). > > Signed-off-by: Jan Beulich > > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -458,7 +458,7 @@ CFLAGS += -I$(objtree)/arch/$(SRCARCH)/i > ALL_OBJS-y := common/built_in.o > ALL_OBJS-y += drivers/built_in.o > ALL_OBJS-y += lib/built_in.o > -ALL_OBJS-y += xsm/built_in.o > +ALL_OBJS-$(CONFIG_XSM) += xsm/built_in.o > ALL_OBJS-y += arch/$(SRCARCH)/built_in.o > ALL_OBJS-$(CONFIG_CRYPTO) += crypto/built_in.o > > --- a/xen/include/hypercall-defs.c > +++ b/xen/include/hypercall-defs.c > @@ -119,7 +119,9 @@ prefix: do PREFIX_compat > xen_version(int cmd, void *arg) > vcpu_op(int cmd, unsigned int vcpuid, void *arg) > sched_op(int cmd, void *arg) > +#ifdef CONFIG_XSM > xsm_op(void *op) > +#endif > callback_op(int cmd, const void *arg) > #ifdef CONFIG_ARGO > argo_op(unsigned int cmd, void *arg1, void *arg2, unsigned long arg3, unsigned long arg4) > @@ -264,7 +266,9 @@ set_segment_base do:2 > #ifdef CONFIG_PV > mmuext_op compat:2 do:2 compat do - > #endif > +#ifdef CONFIG_XSM > xsm_op compat do compat do do > +#endif > nmi_op compat do - - - > sched_op compat do compat do do > callback_op compat do - - - > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -437,6 +437,8 @@ static XSM_INLINE int xsm_hypfs_op(XSM_D > } > #endif > > +#ifdef CONFIG_XSM > + > static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > { > return -ENOSYS; > @@ -449,6 +451,8 @@ static XSM_INLINE int xsm_do_compat_op(X > } > #endif > > +#endif /* CONFIG_XSM */ > + > static XSM_INLINE char *xsm_show_irq_sid(int irq) > { > return NULL; > --- a/xen/xsm/Makefile > +++ b/xen/xsm/Makefile > @@ -1,6 +1,6 @@ > obj-y += xsm_core.o > -obj-$(CONFIG_XSM) += xsm_policy.o > -obj-$(CONFIG_XSM) += dummy.o > +obj-y += xsm_policy.o > +obj-y += dummy.o > obj-$(CONFIG_XSM_SILO) += silo.o > > obj-$(CONFIG_XSM_FLASK) += flask/ > --- a/xen/xsm/xsm_core.c > +++ b/xen/xsm/xsm_core.c > @@ -18,8 +18,6 @@ > #include > #include > > -#ifdef CONFIG_XSM > - > #ifdef CONFIG_MULTIBOOT > #include > #include > @@ -216,8 +214,6 @@ bool __init has_xsm_magic(paddr_t start) > } > #endif > > -#endif > - > long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > { > return xsm_do_xsm_op(op); > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:45:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383955.1627048 (Exim 4.92) (envelope-from ) id 1wrkMZ-0004pq-Ha; Wed, 05 Aug 2026 22:45:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383955.1627048; Wed, 05 Aug 2026 22:45:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkMZ-0004pi-Du; Wed, 05 Aug 2026 22:45:27 +0000 Received: by outflank-mailman (input) for mailman id 1383955; Wed, 05 Aug 2026 22:45:26 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkMY-0004pc-5E for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:45:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkMX-001qHF-4f for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:45:25 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73bc77-2eae-0a2a0a5409dd-0a2a4504dc7a-30 for ; Thu, 06 Aug 2026 00:45:25 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73bd03-b57f-0a2a45040019-aceafc1fa802-3 for ; Thu, 06 Aug 2026 00:45:24 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A855B42E90; Wed, 5 Aug 2026 22:45:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E77F21F000E9; Wed, 5 Aug 2026 22:45:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785969922; bh=3d3XFROd8+sbFsK8tpt4qnvKUt7FVBYbqAtzzam2GJw=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=LlwwsD176RfWsrVexLR7F8hO3K5O5ZgRQ80M4oMI+GHkCpPu4qctzNdrfJjNz5AIq hLbqGEmh4+w4m+NZ2x11Zy1CoqM21IuaxZFGAJh4Nn6BZfKemNHEc9W2cGbeomRqAR dw1cFxbu3EFQaYy7DMemmVitp/Rvtwkt8ixSq2ITGNKkeunSLNRP/of+HiJB13b9cu zmvU5t0XceRKHATS0gnt7jQ9NCu4ZRPkUHrRmqj6Cs0XMlVAJyJ/zdbuuCDle56Lq/ i3fSpdq3GnHOsuVFH3Cg2b4N94YioS0fVUJciTtFC9yafnIuzy3amlu3lklgBl5XZu VrW5Sj8MFIOJw== Date: Wed, 5 Aug 2026 15:45:20 -0700 (PDT) From: Stefano Stabellini To: Juergen Gross cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/4] xen: Drop CONFIG_XEN_PVHVM In-Reply-To: <20260805082137.1214967-3-jgross@suse.com> Message-ID: <00aabcc8-cbdf-b7b9-b253-c7a1f46a22bd@kernel.org> References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-ebf023/1785969925-C30CDB50-B8D71824/0/0 X-purgate-type: clean X-purgate-size: 7958 On Wed, 5 Aug 2026, Juergen Gross wrote: > On x86 CONFIG_XEN_PVHVM is now a synonym of CONFIG_XEN. > > In Xen specific x86 code it can be just dropped, in non-Xen specific > x86 code it can be replaced with CONFIG_XEN. > > In architecture independent code it is used only where CONFIG_XEN is > defined, so it can be replaced with CONFIG_X86 there. > > Signed-off-by: Juergen Gross While I think there is value in compiling a tiny PV-only kernel (in fact I even have a real-world use case for it) the code addition is minimal and also considering your reply to Andrew: Reviewed-by: Stefano Stabellini > --- > arch/x86/include/asm/idtentry.h | 2 +- > arch/x86/kernel/cpu/hypervisor.c | 2 +- > arch/x86/xen/Kconfig | 10 +++------- > arch/x86/xen/Makefile | 9 ++++----- > arch/x86/xen/time.c | 2 -- > arch/x86/xen/xen-ops.h | 4 ---- > drivers/xen/Kconfig | 2 +- > drivers/xen/events/events_base.c | 7 ------- > drivers/xen/xenbus/xenbus_probe.c | 2 +- > include/xen/platform_pci.h | 6 +++--- > 10 files changed, 14 insertions(+), 32 deletions(-) > > diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h > index 20f548702404..f400cfac69a6 100644 > --- a/arch/x86/include/asm/idtentry.h > +++ b/arch/x86/include/asm/idtentry.h > @@ -745,7 +745,7 @@ DECLARE_IDTENTRY_SYSVEC(HYPERV_STIMER0_VECTOR, sysvec_hyperv_stimer0); > DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); > #endif > > -#ifdef CONFIG_XEN_PVHVM > +#ifdef CONFIG_XEN > DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, sysvec_xen_hvm_callback); > #endif > > diff --git a/arch/x86/kernel/cpu/hypervisor.c b/arch/x86/kernel/cpu/hypervisor.c > index f3e9219845e8..73428afca796 100644 > --- a/arch/x86/kernel/cpu/hypervisor.c > +++ b/arch/x86/kernel/cpu/hypervisor.c > @@ -31,7 +31,7 @@ static const __initconst struct hypervisor_x86 * const hypervisors[] = > #ifdef CONFIG_XEN_PV > &x86_hyper_xen_pv, > #endif > -#ifdef CONFIG_XEN_PVHVM > +#ifdef CONFIG_XEN > &x86_hyper_xen_hvm, > #endif > &x86_hyper_vmware, > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > index bb420a4cb75f..9e5bb51eecf4 100644 > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -50,24 +50,20 @@ config XEN_PV_DOM0 > def_bool y > depends on XEN_PV && XEN_DOM0 > > -config XEN_PVHVM > - def_bool y > - depends on XEN > - > config XEN_PVHVM_SMP > def_bool y > - depends on XEN_PVHVM && SMP > + depends on XEN && SMP > > config XEN_PVHVM_GUEST > bool "Xen PVHVM guest support" > default y > - depends on XEN_PVHVM && PCI > + depends on XEN && PCI > help > Support running as a Xen PVHVM guest. > > config XEN_PVH > bool "Xen PVH guest support" > - depends on XEN && XEN_PVHVM && ACPI > + depends on XEN && ACPI > select PVH > help > Support for running as a Xen PVH guest. > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > index 717264ae269b..32d651aa9bc2 100644 > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -16,11 +16,10 @@ obj-y += mmu.o > obj-y += time.o > obj-y += grant-table.o > obj-y += suspend.o > - > -obj-$(CONFIG_XEN_PVHVM) += enlighten_hvm.o > -obj-$(CONFIG_XEN_PVHVM) += mmu_hvm.o > -obj-$(CONFIG_XEN_PVHVM) += suspend_hvm.o > -obj-$(CONFIG_XEN_PVHVM) += platform-pci-unplug.o > +obj-y += enlighten_hvm.o > +obj-y += mmu_hvm.o > +obj-y += suspend_hvm.o > +obj-y += platform-pci-unplug.o > > obj-$(CONFIG_XEN_PV) += setup.o > obj-$(CONFIG_XEN_PV) += apic.o > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index d62c14334b35..5c7822254a01 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -586,7 +586,6 @@ void __init xen_init_time_ops(void) > x86_platform.set_wallclock = xen_set_wallclock; > } > > -#ifdef CONFIG_XEN_PVHVM > static void xen_hvm_setup_cpu_clockevents(void) > { > int cpu = smp_processor_id(); > @@ -643,7 +642,6 @@ void __init xen_hvm_init_time_ops(void) > > hvm_time_initialized = true; > } > -#endif > > /* Kernel parameter to specify Xen timer slop */ > static int __init parse_xen_timer_slop(char *ptr) > diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h > index dc265bdda24d..47eebbb3684a 100644 > --- a/arch/x86/xen/xen-ops.h > +++ b/arch/x86/xen/xen-ops.h > @@ -236,11 +236,7 @@ void xen_pin_vcpu(int cpu); > > void xen_emergency_restart(void); > > -#ifdef CONFIG_XEN_PVHVM > void xen_hvm_post_suspend(int suspend_cancelled); > -#else > -static inline void xen_hvm_post_suspend(int suspend_cancelled) {} > -#endif > > /* > * The maximum amount of extra memory compared to the base size. The > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index f9a35ed266ec..cfb517cd77dc 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -311,7 +311,7 @@ config XEN_EFI > > config XEN_AUTO_XLATE > def_bool y > - depends on ARM || ARM64 || XEN_PVHVM > + depends on ARM || ARM64 || X86 > help > Support for auto-translated physmap guests. > > diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c > index 6ea945508a89..fd16d652c81f 100644 > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -2180,7 +2180,6 @@ static struct irq_chip xen_percpu_chip __read_mostly = { > }; > > #ifdef CONFIG_X86 > -#ifdef CONFIG_XEN_PVHVM > /* Vector callbacks are better than PCI interrupts to receive event > * channel notifications because we can receive vector callbacks on any > * vcpu and we don't need PCI support or APIC interactions. */ > @@ -2242,12 +2241,6 @@ static __init void xen_alloc_callback_vector(void) > pr_info("Xen HVM callback vector for event delivery is enabled\n"); > sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_xen_hvm_callback); > } > -#else > -void xen_setup_callback_vector(void) {} > -static inline void xen_init_setup_upcall_vector(void) {} > -int xen_set_upcall_vector(unsigned int cpu) {} > -static inline void xen_alloc_callback_vector(void) {} > -#endif /* CONFIG_XEN_PVHVM */ > #endif /* CONFIG_X86 */ > > bool xen_fifo_events = true; > diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c > index fafb2b84fa5c..082b8c1fee8e 100644 > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -831,7 +831,7 @@ static void xenbus_probe(void) > */ > static bool xs_hvm_defer_init_for_callback(void) > { > -#ifdef CONFIG_XEN_PVHVM > +#ifdef CONFIG_X86 > return xen_store_domain_type == XS_HVM && > !xen_have_vector_callback; > #else > diff --git a/include/xen/platform_pci.h b/include/xen/platform_pci.h > index e51e7cb71a85..267040c1f504 100644 > --- a/include/xen/platform_pci.h > +++ b/include/xen/platform_pci.h > @@ -30,7 +30,7 @@ > static inline int xen_must_unplug_nics(void) { > #if (defined(CONFIG_XEN_NETDEV_FRONTEND) || \ > defined(CONFIG_XEN_NETDEV_FRONTEND_MODULE)) && \ > - defined(CONFIG_XEN_PVHVM) > + defined(CONFIG_X86) > return 1; > #else > return 0; > @@ -40,14 +40,14 @@ static inline int xen_must_unplug_nics(void) { > static inline int xen_must_unplug_disks(void) { > #if (defined(CONFIG_XEN_BLKDEV_FRONTEND) || \ > defined(CONFIG_XEN_BLKDEV_FRONTEND_MODULE)) && \ > - defined(CONFIG_XEN_PVHVM) > + defined(CONFIG_X86) > return 1; > #else > return 0; > #endif > } > > -#if defined(CONFIG_XEN_PVHVM) > +#if defined(CONFIG_X86) > extern bool xen_has_pv_devices(void); > extern bool xen_has_pv_disk_devices(void); > extern bool xen_has_pv_nic_devices(void); > -- > 2.55.0 > From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:47:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383962.1627057 (Exim 4.92) (envelope-from ) id 1wrkOG-0005SN-RQ; Wed, 05 Aug 2026 22:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383962.1627057; Wed, 05 Aug 2026 22:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkOG-0005SG-Nl; Wed, 05 Aug 2026 22:47:12 +0000 Received: by outflank-mailman (input) for mailman id 1383962; Wed, 05 Aug 2026 22:47:11 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkOF-0005SA-12 for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:47:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkOE-005shb-EJ for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:47:10 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73bd04-e002-0a2a0a5209dd-0a2a4508ab58-36 for ; Thu, 06 Aug 2026 00:47:10 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73bd6c-f659-0a2a45080019-aceafc1f8bae-3 for ; Thu, 06 Aug 2026 00:47:10 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 423C9439F0; Wed, 5 Aug 2026 22:47:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 636D81F000E9; Wed, 5 Aug 2026 22:47:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785970028; bh=fuuPEvAgsHQj9nsqLXSKpXJzZS7FnT2ffJxVGZb1cbA=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=cz/EpjzlrGUmxt+B0JJyEawyTl6rwJbKaxw6SkzKrj6S4yhYdGRNOsyxG2x4OD+jl yWCl4Kn26ujSZrB0Oh9FFklTurJ4MoF0dPRBOdv2DlbjGh02l/1jRlzTIR/8zcAFKH X2RZjl4NkdVKGtKl956zpqWN+23Io66ZlMChieQl4BWxpMmrYgBOlLfswWvmXtqudT MIdXFKwZwxG2Txe9XbdjsucTEQsEXoUrpzNQeIwZSBah2SZ/KSaz1quHzm/vTWiitT wH2+yCcRQ6hpDUI4CJq+YTeu0AfftbUJeEjDpUfK88+t+FJB98hG8kFu9FUgZOJbTE TXdV3qAiKby0w== Date: Wed, 5 Aug 2026 15:47:06 -0700 (PDT) From: Stefano Stabellini To: Juergen Gross cc: linux-kernel@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: Re: [PATCH 3/4] xen: Drop CONFIG_XEN_AUTO_XLATE In-Reply-To: <20260805082137.1214967-4-jgross@suse.com> Message-ID: References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-c1860d/1785970030-CFED287B-37B27DC7/0/0 X-purgate-type: clean X-purgate-size: 4109 On Wed, 5 Aug 2026, Juergen Gross wrote: > CONFIG_XEN_AUTO_XLATE is referenced only in code built with CONFIG_XEN > enabled. As it is enabled for all architectures supporting Xen, it can > be just dropped. > > Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini > --- > drivers/xen/Kconfig | 6 ------ > drivers/xen/Makefile | 2 +- > drivers/xen/privcmd.c | 4 ++-- > include/xen/xen-ops.h | 22 ---------------------- > 4 files changed, 3 insertions(+), 31 deletions(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index cfb517cd77dc..32e35a8580ee 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -309,12 +309,6 @@ config XEN_EFI > def_bool y > depends on (ARM || ARM64 || X86_64) && EFI > > -config XEN_AUTO_XLATE > - def_bool y > - depends on ARM || ARM64 || X86 > - help > - Support for auto-translated physmap guests. > - > config XEN_ACPI > def_bool y > depends on X86 && ACPI > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index c0503f1c7d5b..6ce2e2a52d47 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -2,6 +2,7 @@ > obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o > obj-y += grant-table.o features.o balloon.o manage.o time.o > obj-y += mem-reservation.o > +obj-y += xlate_mmu.o > obj-y += events/ > obj-y += xenbus/ > > @@ -29,7 +30,6 @@ obj-$(CONFIG_XEN_PRIVCMD) += xen-privcmd.o > obj-$(CONFIG_XEN_ACPI_PROCESSOR) += xen-acpi-processor.o > obj-$(CONFIG_XEN_EFI) += efi.o > obj-$(CONFIG_XEN_SCSI_BACKEND) += xen-scsiback.o > -obj-$(CONFIG_XEN_AUTO_XLATE) += xlate_mmu.o > obj-$(CONFIG_XEN_PVCALLS_BACKEND) += pvcalls-back.o > obj-$(CONFIG_XEN_PVCALLS_FRONTEND) += pvcalls-front.o > xen-evtchn-y := evtchn.o > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > index 725a49a0eee7..7cfc28f1bb86 100644 > --- a/drivers/xen/privcmd.c > +++ b/drivers/xen/privcmd.c > @@ -794,7 +794,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, > goto out; > } > > - if (IS_ENABLED(CONFIG_XEN_AUTO_XLATE) && !xen_pv_domain()) { > + if (!xen_pv_domain()) { > unsigned int nr = DIV_ROUND_UP(kdata.num, XEN_PFN_PER_PAGE); > struct page **pages; > unsigned int i; > @@ -825,7 +825,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, > if (rc) > goto out; > > - if (IS_ENABLED(CONFIG_XEN_AUTO_XLATE) && !xen_pv_domain()) { > + if (!xen_pv_domain()) { > rc = xen_remap_vma_range(vma, kdata.addr, kdata.num << PAGE_SHIFT); > } else { > unsigned int domid = > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h > index 496e6013c689..15e0c3f4b7bb 100644 > --- a/include/xen/xen-ops.h > +++ b/include/xen/xen-ops.h > @@ -59,7 +59,6 @@ static inline int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr, > > struct vm_area_struct; > > -#ifdef CONFIG_XEN_AUTO_XLATE > int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, > unsigned long addr, > xen_pfn_t *gfn, int nr, > @@ -68,27 +67,6 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, > struct page **pages); > int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma, > int nr, struct page **pages); > -#else > -/* > - * These two functions are called from arch/x86/xen/mmu.c and so stubs > - * are needed for a configuration not specifying CONFIG_XEN_AUTO_XLATE. > - */ > -static inline int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, > - unsigned long addr, > - xen_pfn_t *gfn, int nr, > - int *err_ptr, pgprot_t prot, > - unsigned int domid, > - struct page **pages) > -{ > - return -EOPNOTSUPP; > -} > - > -static inline int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma, > - int nr, struct page **pages) > -{ > - return -EOPNOTSUPP; > -} > -#endif > > int xen_remap_vma_range(struct vm_area_struct *vma, unsigned long addr, > unsigned long len); > -- > 2.55.0 > From xen-devel-bounces@lists.xenproject.org Wed Aug 05 22:49:36 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 22:49:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383971.1627066 (Exim 4.92) (envelope-from ) id 1wrkQZ-0006HU-8t; Wed, 05 Aug 2026 22:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383971.1627066; Wed, 05 Aug 2026 22:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkQZ-0006HN-61; Wed, 05 Aug 2026 22:49:35 +0000 Received: by outflank-mailman (input) for mailman id 1383971; Wed, 05 Aug 2026 22:49:33 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkQX-0006HG-PV for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 22:49:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkQW-00AyQD-W0 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:49:33 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73bdca-5cb7-0a2a0a5109dd-0a2a450584ba-34 for ; Thu, 06 Aug 2026 00:49:32 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73bdfb-4cb1-0a2a45050019-aceafc1fd156-3 for ; Thu, 06 Aug 2026 00:49:32 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0EA3940815; Wed, 5 Aug 2026 22:49:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88E261F000E9; Wed, 5 Aug 2026 22:49:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785970170; bh=fHVmsCi75+bOy9xF1TMBrC/j7NUcRqJEe7b8M5dGgho=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=Uq/0Az7dFA0DuUlaa/qWDjeOEXo6q0B1nwKSMlQpZbklPFPI5YVDoI7McTLLkVgCp wa98kE2yqy4Lwrf42VlFfsMO9k0G9YMqArWcqQO9CxT8VFUG53YadBfAvQMbSHZKfP E742IrgSoxWHH3/69/WZ/zhkuRZU0QwATTUMO9e5mVLkvn2546G0NWL53iChWNVXTS pCbHvmj/aVtyTikPcx7QAGHRsezXQmNp4XdN4FhnWLAW2N6mI/BgrlDCivQVG4thqu bqVZ4DZkCE+A/3uE1woFV98GEyVvBnUxDqBQnDwr0RdR/jtP8AGmox80U+jWGw7azY CVOX8j92u6zLA== Date: Wed, 5 Aug 2026 15:49:28 -0700 (PDT) From: Stefano Stabellini To: Juergen Gross cc: linux-kernel@vger.kernel.org, x86@kernel.org, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: Re: [PATCH 4/4] x86/xen: Drop CONFIG_XEN_PVHVM_SMP In-Reply-To: <20260805082137.1214967-5-jgross@suse.com> Message-ID: References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-c201ff/1785970172-F46A52A1-86B8FFDB/0/0 X-purgate-type: clean X-purgate-size: 1337 On Wed, 5 Aug 2026, Juergen Gross wrote: > CONFIG_XEN_PVHVM_SMP is referenced only on x86 in Xen specific code, > so it can be replaced with CONFIG_SMP. > > Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini > --- > arch/x86/xen/Kconfig | 4 ---- > arch/x86/xen/Makefile | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > index 9e5bb51eecf4..609e79942fcb 100644 > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -50,10 +50,6 @@ config XEN_PV_DOM0 > def_bool y > depends on XEN_PV && XEN_DOM0 > > -config XEN_PVHVM_SMP > - def_bool y > - depends on XEN && SMP > - > config XEN_PVHVM_GUEST > bool "Xen PVHVM guest support" > default y > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > index 32d651aa9bc2..9c7e9ffffb85 100644 > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -37,8 +37,8 @@ obj-$(CONFIG_XEN_PVH) += enlighten_pvh.o > obj-$(CONFIG_EVENT_TRACING) += trace.o > > obj-$(CONFIG_SMP) += smp.o > +obj-$(CONFIG_SMP) += smp_hvm.o > obj-$(CONFIG_XEN_PV_SMP) += smp_pv.o > -obj-$(CONFIG_XEN_PVHVM_SMP) += smp_hvm.o > > obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o > > -- > 2.55.0 > > From xen-devel-bounces@lists.xenproject.org Wed Aug 05 23:02:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 05 Aug 2026 23:02:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1383979.1627075 (Exim 4.92) (envelope-from ) id 1wrkcx-0000qD-Ay; Wed, 05 Aug 2026 23:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1383979.1627075; Wed, 05 Aug 2026 23:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkcx-0000q6-7a; Wed, 05 Aug 2026 23:02:23 +0000 Received: by outflank-mailman (input) for mailman id 1383979; Wed, 05 Aug 2026 23:02:22 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrkcv-0000q0-Tq for xen-devel@lists.xenproject.org; Wed, 05 Aug 2026 23:02:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrkcu-001sBx-P0 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:02:20 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73c0b3-bab6-0a2a0a5309dd-0a2a4503e538-44 for ; Thu, 06 Aug 2026 01:02:20 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73c0fa-fae8-0a2a45030019-888fbc335293-3 for ; Thu, 06 Aug 2026 01:02:19 +0200 Received: by mx.zohomail.com with SMTPS id 1785970931757862.8809731529432; Wed, 5 Aug 2026 16:02:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785970935; cv=none; d=zohomail.com; s=zohoarc; b=kjana2zBCDvLxbIF/c321U3JNAzvGg7Utwb47zDODFZvTSlMS4blq/7n97LS68hlqGjxm1kt7u4G2TBZKkgdKx2NwjBSChZcLUS6brU4fFICVChZuLx1s1hRpPGWBo+VTXhJAeAJrcl0XQyDpELpb6AE2bZDgIGhBbksqo7bxeE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785970935; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=QOAXveVRzSj2f6mnVcA49KXV+dsWmNXoVe0bGwk16xA=; b=lqJcMwuN9VeJGr7VwC90/hn/uPxbjBriiMjz/1FJcb0E4WTO+eV9pQkFifU2GK6kwxmh5o5bsZWmflJmkaSdbOCD0tHWprlK1IWtb6fEE+dFG2Wl864onuKhgE09PZVijxDlNcp5qc3hkeDLqfQsd4S5wwu5Kg5g6yJJVJsgYIA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785970935; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=QOAXveVRzSj2f6mnVcA49KXV+dsWmNXoVe0bGwk16xA=; b=rmvLsRYcn/qhWZmuOK/lINIzXBWq3tEVpFpiBxuFObRbommY31Bnk9+A45hKRuLm eWZKwJXhliOVScmDJq4fbdt1eorT76xJNLeUd6UtW+fYel+7+k9KHXwWZAFncPYgkLh AX+qd+zsYx3hGE/8ur0fI/jK16/kBX1zBAb9qvbU= Message-ID: <6991badc-dcc4-44b9-a048-29eb67c46d2e@apertussolutions.com> Date: Wed, 5 Aug 2026 19:02:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Jason Andryuk References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-33051d/1785970940-74E874E9-C409397B/0/0 X-purgate-type: clean X-purgate-size: 9013 On 7/28/26 9:22 AM, Jan Beulich wrote: > For whatever reason they didn't have an xsm_default_t first argument (to > cope with XSM=n mode), making it impossible to (easily) cover them in > xsm/hooks.h. > > To be able to retain the const on their function parameters, adjust > xsm_default_action() accordingly. > > Signed-off-by: Jan Beulich > > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -1341,7 +1341,7 @@ fill_ring_data(const struct domain *curr > * Don't supply information about rings that a guest is not > * allowed to send to. > */ > - ret = xsm_argo_send(currd, dst_d); > + ret = xsm_argo_send(XSM_HOOK, currd, dst_d); > if ( ret ) > goto out; > > @@ -1666,8 +1666,9 @@ register_ring(struct domain *currd, > > if ( reg.partner_id == XEN_ARGO_DOMID_ANY ) > { > - ret = opt_argo_mac_permissive ? xsm_argo_register_any_source(currd) : > - -EPERM; > + ret = opt_argo_mac_permissive > + ? xsm_argo_register_any_source(XSM_HOOK, currd) > + : -EPERM; > if ( ret ) > return ret; > } > @@ -1680,7 +1681,7 @@ register_ring(struct domain *currd, > return -ESRCH; > } > > - ret = xsm_argo_register_single_source(currd, dst_d); > + ret = xsm_argo_register_single_source(XSM_HOOK, currd, dst_d); > if ( ret ) > goto out; > > @@ -2002,7 +2003,7 @@ sendv(struct domain *src_d, xen_argo_add > if ( !dst_d ) > return -ESRCH; > > - ret = xsm_argo_send(src_d, dst_d); > + ret = xsm_argo_send(XSM_HOOK, src_d, dst_d); > if ( ret ) > { > gprintk(XENLOG_ERR, "argo: XSM REJECTED %i -> %i\n", > @@ -2100,7 +2101,7 @@ do_argo_op(unsigned int cmd, XEN_GUEST_H > if ( unlikely(!opt_argo) ) > return -EOPNOTSUPP; > > - rc = xsm_argo_enable(currd); > + rc = xsm_argo_enable(XSM_HOOK, currd); > if ( rc ) > return rc; > > @@ -2242,7 +2243,7 @@ compat_argo_op(unsigned int cmd, XEN_GUE > if ( unlikely(!opt_argo) ) > return -EOPNOTSUPP; > > - rc = xsm_argo_enable(currd); > + rc = xsm_argo_enable(XSM_HOOK, currd); > if ( rc ) > return rc; > > @@ -2307,7 +2308,7 @@ argo_init(struct domain *d) > { > struct argo_domain *argo; > > - if ( !opt_argo || xsm_argo_enable(d) ) > + if ( !opt_argo || xsm_argo_enable(XSM_HOOK, d) ) This question came up on another thread, so thought I might point it out that when FLASK is in use this can return a nubmer of error codes beyond an access deny. While I know it's the existing behavior, but if the error code is anything other than -EPERM, then it's not that the policy denied the access but something cause a fault in the security server. In that case the domain is still being allowed to construct with the assumption that it was a policy deny. At a minimum should the error code at least get reported, and perhaps it should be passed up to domain construction to allowing it to make an informed decision on construction? > { > argo_dprintk("argo disabled, domid: %u\n", d->domain_id); > return 0; > @@ -2365,8 +2366,8 @@ argo_soft_reset(struct domain *d) > wildcard_rings_pending_remove(d); > > /* > - * Since neither opt_argo or xsm_argo_enable(d) can change at runtime, > - * if d->argo is true then both opt_argo and xsm_argo_enable(d) must be > + * Since neither opt_argo nor xsm_argo_enable() can change at runtime, > + * if d->argo is true then both opt_argo and xsm_argo_enable() must be > * true, and we can assume that init is allowed to proceed again here. > */ > argo_domain_init(d->argo); > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -76,7 +76,7 @@ void __xsm_action_mismatch_detected(void > #endif /* CONFIG_XSM */ > > static always_inline int xsm_default_action( > - xsm_default_t action, struct domain *src, struct domain *target) > + xsm_default_t action, const struct domain *src, const struct domain *target) > { > switch ( action ) { > case XSM_HOOK: > @@ -751,27 +751,32 @@ static XSM_INLINE int xsm_dm_op(XSM_DEFA > #endif > > #ifdef CONFIG_ARGO > -static XSM_INLINE int xsm_argo_enable(const struct domain *d) > + > +static XSM_INLINE int xsm_argo_enable(XSM_DEFAULT_ARG const struct domain *d) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, current->domain, d); I will reply on Jason's thread. > } > > static XSM_INLINE int xsm_argo_register_single_source( > - const struct domain *d, const struct domain *t) > + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, d, t); > } > > static XSM_INLINE int xsm_argo_register_any_source( > - const struct domain *d) > + XSM_DEFAULT_ARG const struct domain *d) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, current->domain, d); > } > > static XSM_INLINE int xsm_argo_send( > - const struct domain *d, const struct domain *t) > + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) > { > - return 0; > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, d, t); > } > > #endif /* CONFIG_ARGO */ > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -156,6 +156,14 @@ XSM_HOOK(int, dm_op, struct domain *) > XSM_HOOK(int, xen_version, uint32_t) > XSM_HOOK(int, domain_resource_map, struct domain *) > > +#ifdef CONFIG_ARGO > +XSM_HOOK(int, argo_enable, const struct domain *) > +XSM_HOOK(int, argo_register_single_source, const struct domain *, > + const struct domain *) > +XSM_HOOK(int, argo_register_any_source, const struct domain *) > +XSM_HOOK(int, argo_send, const struct domain *, const struct domain *) > +#endif > + > #undef XSM_HOOK0 > #undef XSM_HOOK1 > #undef XSM_HOOK2 > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -90,14 +90,6 @@ struct xsm_ops { > #ifdef CONFIG_COMPAT > int (*do_compat_op)(XEN_GUEST_HANDLE_PARAM(void) op); > #endif > - > -#ifdef CONFIG_ARGO > - int (*argo_enable)(const struct domain *d); > - int (*argo_register_single_source)(const struct domain *d, > - const struct domain *t); > - int (*argo_register_any_source)(const struct domain *d); > - int (*argo_send)(const struct domain *d, const struct domain *t); > -#endif > }; > > #ifdef CONFIG_XSM > @@ -213,30 +205,6 @@ static inline int xsm_do_compat_op(XEN_G > } > #endif > > -#ifdef CONFIG_ARGO > -static inline int xsm_argo_enable(const struct domain *d) > -{ > - return alternative_call(xsm_ops.argo_enable, d); > -} > - > -static inline int xsm_argo_register_single_source( > - const struct domain *d, const struct domain *t) > -{ > - return alternative_call(xsm_ops.argo_register_single_source, d, t); > -} > - > -static inline int xsm_argo_register_any_source(const struct domain *d) > -{ > - return alternative_call(xsm_ops.argo_register_any_source, d); > -} > - > -static inline int xsm_argo_send(const struct domain *d, const struct domain *t) > -{ > - return alternative_call(xsm_ops.argo_send, d, t); > -} > - > -#endif /* CONFIG_ARGO */ > - > #endif /* XSM_NO_WRAPPERS */ > > #ifdef CONFIG_MULTIBOOT > --- a/xen/xsm/dummy.c > +++ b/xen/xsm/dummy.c > @@ -40,13 +40,6 @@ static const struct xsm_ops __initconst_ > #ifdef CONFIG_COMPAT > .do_compat_op = xsm_do_compat_op, > #endif > - > -#ifdef CONFIG_ARGO > - .argo_enable = xsm_argo_enable, > - .argo_register_single_source = xsm_argo_register_single_source, > - .argo_register_any_source = xsm_argo_register_any_source, > - .argo_send = xsm_argo_send, > -#endif > }; > > void __init xsm_fixup_ops(struct xsm_ops *ops) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1977,13 +1977,6 @@ static const struct xsm_ops __initconst_ > #ifdef CONFIG_COMPAT > .do_compat_op = compat_flask_op, > #endif > - > -#ifdef CONFIG_ARGO > - .argo_enable = flask_argo_enable, > - .argo_register_single_source = flask_argo_register_single_source, > - .argo_register_any_source = flask_argo_register_any_source, > - .argo_send = flask_argo_send, > -#endif > }; > > const struct xsm_ops *__init flask_init( > From xen-devel-bounces@lists.xenproject.org Thu Aug 06 00:37:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 00:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384007.1627084 (Exim 4.92) (envelope-from ) id 1wrm6f-00075b-DI; Thu, 06 Aug 2026 00:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384007.1627084; Thu, 06 Aug 2026 00:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrm6f-00075T-9F; Thu, 06 Aug 2026 00:37:09 +0000 Received: by outflank-mailman (input) for mailman id 1384007; Thu, 06 Aug 2026 00:37:07 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrm6d-00075M-Bc for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:37:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrm6c-00B99s-LJ for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 02:37:06 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73d725-bab6-0a2a0a5309dd-0a2a4501bc9c-12 for ; Thu, 06 Aug 2026 02:37:06 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73d730-5984-0a2a45010019-888fbc335282-3 for ; Thu, 06 Aug 2026 02:37:06 +0200 Received: by mx.zohomail.com with SMTPS id 1785976617233237.7105325983797; Wed, 5 Aug 2026 17:36:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785976619; cv=none; d=zohomail.com; s=zohoarc; b=Xk/U3OB0byKOg1m3hHzUVjM25Zod62w5PRAOq84C6xyAovu9W3YMWQxnWrh+PXrxui3G4B/EfdnjLtJeQ5W+4o9SWjgRWFhIsBkX/6nWMM9CUsOjylQYZJy67Vw9GRbW4sXoIuWpkgzbh+x/cvBkAZURNp/thcVgxGXuBSRMPOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785976619; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=oqa2ViCllzgOCvQN5qwRSj/4I/e66JiUdGJ48N8Wzro=; b=OJV84ze+RSTzOYS0NXhPv8NqpQTTY+Wj3iqTBssxfam87gT0cgq5q8f1oZqPKkagHiCYcWq5aKeGGJ0XmLLSHvfgSLYHdOe/4TdlQZZF5EvdRqMEdbwGgQcOCQ+NZM42oFzCklv5TlOYqsH0kw580DQAMIioEqxcvnia8HeZR8g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785976619; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=oqa2ViCllzgOCvQN5qwRSj/4I/e66JiUdGJ48N8Wzro=; b=OgRgsRBfljTgR7lOswZ9etHDS0I4SG6iYHfBVUHWFQR1/wjcZYfF8WjMz0IXmqeg MdJ9NjTuNQFkmBip4mn7uxyyck6NwOHbrQX6ToB5YVmjgwq3qdF1VpAnNckxwhzNVSz TWH2Cr+Hk6hbND5VoQNDBwob4TXkVrQfKKERJW88= Message-ID: <185b9a3a-2a54-4f45-8c22-5792666b2aa3@apertussolutions.com> Date: Wed, 5 Aug 2026 20:37:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: Jan Beulich , Jason Andryuk Cc: "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> <8097d8e8-42ec-463a-8247-56c9e4d834cd@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <8097d8e8-42ec-463a-8247-56c9e4d834cd@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-d62444/1785976626-1E867757-A83E8F75/0/0 X-purgate-type: clean X-purgate-size: 3026 On 8/4/26 3:53 AM, Jan Beulich wrote: > On 03.08.2026 23:01, Jason Andryuk wrote: >> On 2026-07-28 09:22, Jan Beulich wrote: >>> --- a/xen/include/xsm/dummy.h >>> +++ b/xen/include/xsm/dummy.h >> >>> @@ -751,27 +751,32 @@ static XSM_INLINE int xsm_dm_op(XSM_DEFA >>> #endif >>> >>> #ifdef CONFIG_ARGO >>> -static XSM_INLINE int xsm_argo_enable(const struct domain *d) >>> + >>> +static XSM_INLINE int xsm_argo_enable(XSM_DEFAULT_ARG const struct domain *d) >>> { >>> - return 0; >>> + XSM_ASSERT_ACTION(XSM_HOOK); >>> + return xsm_default_action(action, current->domain, d); >> >> This one I think should be >> return xsm_default_action(action, d, NULL); >> >> Usually current is passed in for the check, but for domain_create() -> >> argo_init() it is the under-construction domain. > > And in that case we want to make sure that current->domain may enable Argo > for d. > Jason is correct here, the design of Argo is that authorization is granted by the hypervisor and not by any domains. It's why we coined the term Hypervisor Mediated eXchange (HMX). The source of that authorization was designed to be XSM. As such the intent of this check is, "is d allowed to register rings". >>> } >>> >>> static XSM_INLINE int xsm_argo_register_single_source( >>> - const struct domain *d, const struct domain *t) >>> + XSM_DEFAULT_ARG const struct domain *d, const struct domain *t) >>> { >>> - return 0; >>> + XSM_ASSERT_ACTION(XSM_HOOK); >>> + return xsm_default_action(action, d, t); >>> } >>> >>> static XSM_INLINE int xsm_argo_register_any_source( >>> - const struct domain *d) >>> + XSM_DEFAULT_ARG const struct domain *d) >>> { >>> - return 0; >>> + XSM_ASSERT_ACTION(XSM_HOOK); >>> + return xsm_default_action(action, current->domain, d); >> >> Similarly: >> return xsm_default_action(action, d, NULL); >> >> The single call is: >> xsm_argo_register_any_source(currd); > > There being just a single call puts this on the edge. If there was another > one not passing current->domain, I think the same argument as above would > hold here. And the general concept is what I think should matter when > writing the dummy implementations. > As explained above, the check is asking the hypervisor if the domain currd is allowed to register wildcard rings. >> These argo hooks all pass in their arguments explicitly, so I think we >> should do that and not use current. (The send and register hooks could >> use current, and that could make sense as those map to hypercalls. But >> it is correct today with the explicit arguments.) >> >> With the changes: >> Reviewed-by: Jason Andryuk > > Thanks, but no - unless I misunderstand how permissions are intended to > work here, I don't think I can make the changes requested, and hence I > can't apply the R-b. > Please apply the changes requested. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 06 00:53:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 00:53:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384016.1627093 (Exim 4.92) (envelope-from ) id 1wrmMd-0001zA-Pp; Thu, 06 Aug 2026 00:53:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384016.1627093; Thu, 06 Aug 2026 00:53:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmMd-0001z3-NA; Thu, 06 Aug 2026 00:53:39 +0000 Received: by outflank-mailman (input) for mailman id 1384016; Thu, 06 Aug 2026 00:53:39 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmMc-0001yx-Uh for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:53:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmMb-00DUgw-CP for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 02:53:37 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73dada-e002-0a2a0a5209dd-0a2a4501ac28-10 for ; Thu, 06 Aug 2026 02:53:36 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73db0f-5984-0a2a45010019-888fbc33528d-3 for ; Thu, 06 Aug 2026 02:53:36 +0200 Received: by mx.zohomail.com with SMTPS id 1785977608866406.3191270237992; Wed, 5 Aug 2026 17:53:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785977612; cv=none; d=zohomail.com; s=zohoarc; b=CrAtIn+IHUM1Ck9odLMGFWWw8nOMYVzh7DDvqoVkp19P2qlNigCVH6E7tgWa3FuOrcA0BLIZsORutpAiqePzTLnWRRZEbNFvJQt1A1hszq/0l9LtZdolEsz2/RvJoqodDP+tEZqkFrYJ1OX2ndMBJXVyWS1KnqP9cv0VKXt3Uqg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785977612; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=gF+3hmcKcDN3bvGGKSRKUBSi2/vWsmYQYvFS3ztz2xQ=; b=jV7unf/R/qr6aJpzuR7LBktstArdrQCcYHmfJ4l8krPJKnKchf/2JhIgPVfLY8n6KQpZC/tzgkmr/b4SewxzKmgclMnC2hfIY81qAHhbHf+2OBIEKX4I0A28Z9RR4XglxyIwTnWQHG3XwtjysTNiX5LBh5fR0MzA1/tKGiQXogI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785977612; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=gF+3hmcKcDN3bvGGKSRKUBSi2/vWsmYQYvFS3ztz2xQ=; b=l4etnh0wGSmIfzd3VM0OWXvBgW39OhyudH0TCozJ0XoA+4NzG6v05sFNqi2SKDxN hdXdk+etzpKt84bxnIXePs3UF3vvYLZglFCe7JVyB8RKypFLgiPhzjmjGfYFkJe5kqw Lw3GiLHwphePkKaNuBHPTZM4P6zJxA2TlPjZqIuc= Message-ID: Date: Wed, 5 Aug 2026 20:53:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/24] XSM: make XSM hooks well-formed ones To: Jan Beulich , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <2c108d3c-eef1-4d4b-9874-b0721fd7560f@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <2c108d3c-eef1-4d4b-9874-b0721fd7560f@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-d62444/1785977616-BFA6E757-AEDC5DC6/0/0 X-purgate-type: clean X-purgate-size: 5926 On 7/28/26 9:22 AM, Jan Beulich wrote: > For whatever reason they didn't have an xsm_default_t first argument (to > cope with XSM=n mode), making it impossible to (easily) cover them in > xsm/hooks.h. > > flask_do_xsm_op() is also changed to return int, as all the function ever > returns is an int. This way no new machinery needs adding to xsm/hooks.h. > Instead one piece of compat machinery can then be dropped from > xsm/flask/flask_op.c. > > Signed-off-by: Jan Beulich > --- > Instead of XSM_HOOK, using XSM_OTHER may also be a sensible option here. > I would say XSM_HOOK is sufficient since at this point it doesn't matter what op is passed the dummy policy is just going to return the same value. If the dummy policy is extended to support an op, then at that point the implementer can switch it to XSM_OTHER. > Question is whether some/all of the other hooks still declared explicitly > in struct xsm_ops should follow suit. > I would say either comment these are exceptions or make them consistent, though I haven't studied if there would be any consequences (doubtful) changing the others. > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -439,7 +439,7 @@ static XSM_INLINE int xsm_hypfs_op(XSM_D > > #ifdef CONFIG_XSM > > -static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > +static XSM_INLINE int xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) With this change, should there be a comment that the int is going to get cast to long before return? > { > return -ENOSYS; > } > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -156,6 +156,11 @@ XSM_HOOK(int, dm_op, struct domain *) > XSM_HOOK(int, xen_version, uint32_t) > XSM_HOOK(int, domain_resource_map, struct domain *) > > +XSM_HOOK(int, do_xsm_op, XEN_GUEST_HANDLE_PARAM(void)) > +#ifdef CONFIG_COMPAT > +XSM_HOOK(int, do_compat_op, XEN_GUEST_HANDLE_PARAM(void)) > +#endif > + > #ifdef CONFIG_ARGO > XSM_HOOK(int, argo_enable, const struct domain *) > XSM_HOOK(int, argo_register_single_source, const struct domain *, > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -85,11 +85,6 @@ struct xsm_ops { > char *(*show_security_evtchn)(struct domain *d, const struct evtchn *chn); > > char *(*show_irq_sid)(int irq); > - > - long (*do_xsm_op)(XEN_GUEST_HANDLE_PARAM(void) op); > -#ifdef CONFIG_COMPAT > - int (*do_compat_op)(XEN_GUEST_HANDLE_PARAM(void) op); > -#endif > }; > > #ifdef CONFIG_XSM > @@ -193,18 +188,6 @@ static inline char *xsm_show_irq_sid(int > return alternative_call(xsm_ops.show_irq_sid, irq); > } > > -static inline long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > -{ > - return alternative_call(xsm_ops.do_xsm_op, op); > -} > - > -#ifdef CONFIG_COMPAT > -static inline int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) > -{ > - return alternative_call(xsm_ops.do_compat_op, op); > -} > -#endif > - > #endif /* XSM_NO_WRAPPERS */ > > #ifdef CONFIG_MULTIBOOT > --- a/xen/xsm/dummy.c > +++ b/xen/xsm/dummy.c > @@ -35,11 +35,6 @@ static const struct xsm_ops __initconst_ > .show_security_evtchn = xsm_show_security_evtchn, > > .show_irq_sid = xsm_show_irq_sid, > - > - .do_xsm_op = xsm_do_xsm_op, > -#ifdef CONFIG_COMPAT > - .do_compat_op = xsm_do_compat_op, > -#endif > }; > > void __init xsm_fixup_ops(struct xsm_ops *ops) > --- a/xen/xsm/flask/flask_op.c > +++ b/xen/xsm/flask/flask_op.c > @@ -23,7 +23,6 @@ > #include > #include "private.h" > > -#define ret_t long > #define _copy_to_guest copy_to_guest > #define _copy_from_guest copy_from_guest > > @@ -606,7 +605,7 @@ static int flask_relabel_domain(const st > > #endif /* !COMPAT */ > > -ret_t cf_check do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op) > +int cf_check flask_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op) > { > xen_flask_op_t op; > int rv; > @@ -772,9 +771,7 @@ CHECK_flask_transition; > #define flask_devicetree_label compat_devicetree_label > > #define xen_flask_op_t compat_flask_op_t > -#undef ret_t > -#define ret_t int > -#define do_flask_op compat_flask_op > +#define flask_do_xsm_op flask_do_compat_op > > #include "flask_op.c" > #endif > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1971,12 +1971,6 @@ static const struct xsm_ops __initconst_ > .show_security_evtchn = flask_show_security_evtchn, > > .show_irq_sid = flask_show_irq_sid, > - > - .do_xsm_op = do_flask_op, > - > -#ifdef CONFIG_COMPAT > - .do_compat_op = compat_flask_op, > -#endif > }; > > const struct xsm_ops *__init flask_init( > --- a/xen/xsm/flask/private.h > +++ b/xen/xsm/flask/private.h > @@ -3,7 +3,7 @@ > > #include > > -long cf_check do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); > -int cf_check compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); > +int cf_check flask_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); > +int cf_check flask_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); > > #endif /* XSM_FLASK_PRIVATE */ > --- a/xen/xsm/xsm_core.c > +++ b/xen/xsm/xsm_core.c > @@ -216,12 +216,12 @@ bool __init has_xsm_magic(paddr_t start) > > long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > { > - return xsm_do_xsm_op(op); > + return xsm_do_xsm_op(XSM_HOOK, op); > } > > #ifdef CONFIG_COMPAT > int compat_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > { > - return xsm_do_compat_op(op); > + return xsm_do_compat_op(XSM_HOOK, op); > } > #endif > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Thu Aug 06 00:56:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 00:56:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384025.1627103 (Exim 4.92) (envelope-from ) id 1wrmPm-0002cN-Cj; Thu, 06 Aug 2026 00:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384025.1627103; Thu, 06 Aug 2026 00:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmPm-0002cG-9D; Thu, 06 Aug 2026 00:56:54 +0000 Received: by outflank-mailman (input) for mailman id 1384025; Thu, 06 Aug 2026 00:56:53 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmPl-0002cA-5u for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 00:56:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmPk-008dks-JN for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 02:56:52 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73dbd4-5cb7-0a2a0a5109dd-0a2a450a9434-0 for ; Thu, 06 Aug 2026 02:56:52 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73dbd2-f2d2-0a2a450a0019-888fbc335296-3 for ; Thu, 06 Aug 2026 02:56:52 +0200 Received: by mx.zohomail.com with SMTPS id 1785977800385533.5825905966658; Wed, 5 Aug 2026 17:56:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785977802; cv=none; d=zohomail.com; s=zohoarc; b=iZsKCXGWV5ncS4CWyXh+taLTBrQs2p/s3mJdCXcF37pgFd49ikL+YxdR9iMjVzN46KwhTd8HnN7y3tKqUIR9HYgo0VJ4Txn3PAT/bP20vWF4JLkxulgnMr8r1fCTKa0qwYL6GHGt1rBoxh8dI2Ie83ipom5WCxCZZaEhu55hx8U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785977802; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=iueZ3QDZK5JeDTaKUrqRN8sWfPVwnmJv7o+5G5s4yXU=; b=IeZuRVaR3q8e7/tqgSZE3QnBZSTNroj7CrosfRKZ7JhoXiAgKC/4rs6dLSmlkgIxx86Xtr/BZ4gBzHwetxP2vu+wbtj3Blm3x8Z1BpiFyMzKLGyCZbxrVOMY9TFbK2WLp7Hwp2jjX+tctiY8B5g/PnPS3T3gDQ14vZLoLL3fyYM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785977802; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=iueZ3QDZK5JeDTaKUrqRN8sWfPVwnmJv7o+5G5s4yXU=; b=BiPQE1bEzIJPrdUlEo4olIewbTJetPUpSluO9mhdDIIDdmzqdNYKD3wl4z1jC87R GXRKZWLU7V9sIU5Xh5bkRtrj3TFUdAnQHt7WHloTseGvEhM9EJHHqvbvA/NWHRxS2Ud YOHVkUGJMniFoGEQFwDh23k+IjMAkX+94Kf3kQXg= Message-ID: <3b9803d1-5d07-42c4-8295-fb399b1cdd71@apertussolutions.com> Date: Wed, 5 Aug 2026 20:56:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/24] XSM: convert "allow" (Flask: "access") parameters to bool To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-4011c0/1785977812-59DDFCFC-1A9C3BDD/0/0 X-purgate-type: clean X-purgate-size: 10045 On 7/28/26 9:23 AM, Jan Beulich wrote: > These are boolean, so they should always have used bool (originally > bool_t), not uint8_t. Leverage recent changes to arrange for this with > (now) fewer places which need changing (within the XSM machinery itself). > Adjust call sites as well, where the conversion wasn't done so far. > > Signed-off-by: Jan Beulich > --- > Why is it that Arm doesn't use xsm_irq_permission() at all? Same for Arm64 > vs xsm_pci_config_permission(). > > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -235,7 +235,7 @@ long arch_do_domctl( > { > unsigned int fp = domctl->u.ioport_permission.first_port; > unsigned int np = domctl->u.ioport_permission.nr_ports; > - int allow = domctl->u.ioport_permission.allow_access; > + bool allow = domctl->u.ioport_permission.allow_access; > > ret = -EINVAL; > if ( (fp + np) <= fp || (fp + np) > MAX_IOPORTS ) > @@ -306,7 +306,8 @@ long arch_do_domctl( > break; > } > > - ret = xsm_irq_permission(XSM_PRIV, d, irq, flags); > + ret = xsm_irq_permission(XSM_PRIV, d, irq, > + flags & XEN_DOMCTL_GSI_ACTION_MASK); > if ( ret ) > break; > > @@ -687,7 +688,7 @@ long arch_do_domctl( > unsigned int fgp = domctl->u.ioport_mapping.first_gport; > unsigned int fmp = domctl->u.ioport_mapping.first_mport; > unsigned int np = domctl->u.ioport_mapping.nr_ports; > - unsigned int add = domctl->u.ioport_mapping.add_mapping; > + bool add = domctl->u.ioport_mapping.add_mapping; > struct hvm_domain *hvm; > struct g2m_ioport *g2m_ioport; > int found = 0; > --- a/xen/arch/x86/pci.c > +++ b/xen/arch/x86/pci.c > @@ -78,7 +78,7 @@ int pci_conf_write_intercept(unsigned in > { > struct pci_dev *pdev; > int rc = xsm_pci_config_permission(XSM_HOOK, current->domain, bdf, > - reg, reg + size - 1, 1); > + reg, reg + size - 1, true); > > if ( rc < 0 ) > return rc; > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -260,7 +260,7 @@ static bool pci_cfg_ok(struct domain *cu > > return !write ? > xsm_pci_config_permission(XSM_HOOK, currd, machine_bdf, > - start, start + size - 1, 0) == 0 : > + start, start + size - 1, false) == 0 : > pci_conf_write_intercept(0, machine_bdf, start, size, write) >= 0; > } > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -505,21 +505,21 @@ static XSM_INLINE int xsm_unmap_domain_i > } > > static XSM_INLINE int xsm_irq_permission( > - XSM_DEFAULT_ARG struct domain *d, int pirq, uint8_t allow) > + XSM_DEFAULT_ARG struct domain *d, int pirq, bool allow) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > static XSM_INLINE int xsm_iomem_permission( > - XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) > + XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, bool allow) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > static XSM_INLINE int xsm_iomem_mapping( > - XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) > + XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, bool allow) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > @@ -527,7 +527,7 @@ static XSM_INLINE int xsm_iomem_mapping( > > #ifdef CONFIG_HAS_VPCI > static XSM_INLINE int xsm_iomem_mapping_vpci( > - XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) > + XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, bool allow) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > @@ -537,7 +537,7 @@ static XSM_INLINE int xsm_iomem_mapping_ > #ifdef CONFIG_HAS_PCI > static XSM_INLINE int xsm_pci_config_permission( > XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf, uint16_t start, > - uint16_t end, uint8_t access) > + uint16_t end, bool access) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > @@ -711,14 +711,14 @@ static XSM_INLINE int xsm_priv_mapping( > #endif > > static XSM_INLINE int xsm_ioport_permission( > - XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow) > + XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, bool allow) > { > XSM_ASSERT_ACTION(XSM_PRIV); > return xsm_default_action(action, current->domain, d); > } > > static XSM_INLINE int xsm_ioport_mapping( > - XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow) > + XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, bool allow) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -77,12 +77,12 @@ XSM_HOOK(int, unmap_domain_irq, struct d > XSM_HOOK(int, bind_pt_irq, struct domain *, struct xen_domctl_bind_pt_irq *) > XSM_HOOK(int, unbind_pt_irq, struct domain *, struct xen_domctl_bind_pt_irq *) > > -XSM_HOOK(int, irq_permission, struct domain *, int, uint8_t) > -XSM_HOOK(int, iomem_permission, struct domain *, uint64_t, uint64_t, uint8_t) > +XSM_HOOK(int, irq_permission, struct domain *, int, bool) > +XSM_HOOK(int, iomem_permission, struct domain *, uint64_t, uint64_t, bool) > > -XSM_HOOK(int, iomem_mapping, struct domain *, uint64_t, uint64_t, uint8_t) > +XSM_HOOK(int, iomem_mapping, struct domain *, uint64_t, uint64_t, bool) > #ifdef CONFIG_HAS_VPCI > -XSM_HOOK(int, iomem_mapping_vpci, struct domain *, uint64_t, uint64_t, uint8_t) > +XSM_HOOK(int, iomem_mapping_vpci, struct domain *, uint64_t, uint64_t, bool) > #endif > > #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) > @@ -97,7 +97,7 @@ XSM_HOOK(int, resource_setup_misc) > XSM_HOOK(int, resource_setup_pci, uint32_t) > XSM_HOOK(int, resource_setup_gsi, int) > XSM_HOOK(int, pci_config_permission, struct domain *, uint32_t, uint16_t, > - uint16_t, uint8_t) > + uint16_t, bool) > #endif > > #ifdef CONFIG_HYPFS > @@ -144,8 +144,8 @@ XSM_HOOK(int, update_va_mapping, struct > #if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) > XSM_HOOK(int, priv_mapping, struct domain *, struct domain *) > #endif > -XSM_HOOK(int, ioport_permission, struct domain *, uint32_t, uint32_t, uint8_t) > -XSM_HOOK(int, ioport_mapping, struct domain *, uint32_t, uint32_t, uint8_t) > +XSM_HOOK(int, ioport_permission, struct domain *, uint32_t, uint32_t, bool) > +XSM_HOOK(int, ioport_mapping, struct domain *, uint32_t, uint32_t, bool) > XSM_HOOK(int, pmu_op, struct domain *, unsigned int) > #endif /* CONFIG_X86 */ > > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -998,7 +998,7 @@ static int cf_check flask_sysctl(const s > } > #endif /* CONFIG_SYSCTL */ > > -static inline uint32_t resource_to_perm(uint8_t access) > +static inline uint32_t resource_to_perm(bool access) > { > if ( access ) > return RESOURCE__ADD; > @@ -1166,7 +1166,7 @@ static int cf_check flask_unbind_pt_irq( > } > > static int cf_check flask_irq_permission( > - struct domain *d, int pirq, uint8_t access) > + struct domain *d, int pirq, bool access) > { > /* the PIRQ number is not useful; real IRQ is checked during mapping */ > return current_has_perm(d, SECCLASS_RESOURCE, resource_to_perm(access)); > @@ -1199,7 +1199,7 @@ static int cf_check _iomem_has_perm( > } > > static int cf_check flask_iomem_permission( > - struct domain *d, uint64_t start, uint64_t end, uint8_t access) > + struct domain *d, uint64_t start, uint64_t end, bool access) > { > struct iomem_has_perm_data data; > int rc; > @@ -1221,7 +1221,8 @@ static int cf_check flask_iomem_permissi > return security_iterate_iomem_sids(start, end, _iomem_has_perm, &data); > } > > -static int cf_check flask_iomem_mapping(struct domain *d, uint64_t start, uint64_t end, uint8_t access) > +static int cf_check flask_iomem_mapping( > + struct domain *d, uint64_t start, uint64_t end, bool access) > { > return flask_iomem_permission(d, start, end, access); > } > @@ -1230,7 +1231,7 @@ static int cf_check flask_iomem_mapping( > #ifdef CONFIG_HAS_PCI > static int cf_check flask_pci_config_permission( > struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, > - uint8_t access) > + bool access) > { > uint32_t dsid, rsid; > int rc = -EPERM; > @@ -1709,7 +1710,7 @@ static int cf_check _ioport_has_perm( > } > > static int cf_check flask_ioport_permission( > - struct domain *d, uint32_t start, uint32_t end, uint8_t access) > + struct domain *d, uint32_t start, uint32_t end, bool access) > { > int rc; > struct ioport_has_perm_data data; > @@ -1733,7 +1734,7 @@ static int cf_check flask_ioport_permiss > } > > static int cf_check flask_ioport_mapping( > - struct domain *d, uint32_t start, uint32_t end, uint8_t access) > + struct domain *d, uint32_t start, uint32_t end, bool access) > { > return flask_ioport_permission(d, start, end, access); > } > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:05:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384036.1627111 (Exim 4.92) (envelope-from ) id 1wrmXv-0004AU-4F; Thu, 06 Aug 2026 01:05:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384036.1627111; Thu, 06 Aug 2026 01:05:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmXv-0004AN-1R; Thu, 06 Aug 2026 01:05:19 +0000 Received: by outflank-mailman (input) for mailman id 1384036; Thu, 06 Aug 2026 01:05:17 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmXt-0004AH-Im for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:05:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmXs-002Rtw-Vt for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:05:16 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73ddba-5cb7-0a2a0a5109dd-0a2a4501e924-32 for ; Thu, 06 Aug 2026 03:05:16 +0200 Received: from [66.163.185.33] (helo=sonic313-10.consmr.mail.ne1.yahoo.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ddcb-5984-0a2a45010019-42a3b9219c87-3 for ; Thu, 06 Aug 2026 03:05:16 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 6 Aug 2026 01:05:14 +0000 Received: by hermes--production-bf1-54b5569bdc-xjdx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 734f0c8329adecc00a98ec91cc943adb; Thu, 06 Aug 2026 01:05:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785978314; bh=u2ICDeT8EkzZPEkZ0GkRz/PZQjnhXux/kxcij9AaLW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=q/G2BOr7WloM0VHKXN2nwJ0rDbxjY+y04yBIggP1Mgn2Y7OR2CGFfBoeairu/dufh8WlbcUEY6Z2/sciIZ6dqFa/+SASV3ri2Ab+tEeIa+k8k+A3xeqGV8f12y8jlJAUoqWewX/z0ntm4hlnXNQtSovCU2URfCoKcOEezI0PoKQ6DwJI1P2KCxMIBj3Vnswja30kIwJlOF0P+1PULgbRPuA6KonN4yE4fnQ0O7DiI2f7BIHq29AnbTQK55MZXEGhtZMChFu7RHKC9zmTkYnRqPzYy+S6CRuWFsGNbHGMXaeFy4vl55P1YKouRuvu4TJ5Q72Ba4yBWEtYvNLwA57SSg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785978314; bh=cHWT7ryeN9yIxVQ9xAUubGD/UkRKAGncO1k5XMUDO6e=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=O0rd0dKkVq4tpJT9hTf3se/kJZ17q2puZXxbjqBvuuSDBXUV+0IEKNPAHuRL5Y/E/mxOU4KPKwaFKCjZ2JeCGmQrD9OqOG5tdWDqI+CsR3wxIP4NuBq2DSOdeeJE/xCaFaiD+mnFriCGLbca39xSpYbP8F0pfhV772DaSSg9/EQtbQyJ5UdHX5OQtr3b+ARyBu/Z8/I8Lfv7/q+0f1XOzYYQXjdZt18FqlQxiLVX4nxPST3Mh3ngFf7MBWnmC5puHlvW6OPAa3NOZ+qFk2Uxy3qcSxol0EPAoozlUnwx+CMJSx1iUAGWx6Uc0Gjev00UyK7+/3iO3VasZMCAvTpHCw== X-YMail-OSG: uHAyLrIVM1mZELM3QZA_rjjFjQeZhI7GIk5ir7ZwfpD8woO2tdFJd3oV32S4I9F K2XpvLxjyaHCsGm5lhkVt09Z9P7303YQT4Q5ZwRJHwntssS_K3ic2tbbHpOKBeoVQtyLiisy615E csDiHLsrQU8EtCmfHbVykC5UYKAOrjRfP2P5qk1VxbbKmvxHch.HIu9eASabKw3iMBBzXRlKvJrW mhQgJossJjKDdlntNwQJIWvSgLOhaAeaEBUbG0HomTQRXfq6PSXegaupD8itEACXgRvArIlV8LIf P_h9cEBc_ciT4ba64b6m486boLteuybUOpOZuYzjVUoeEq4ZxOoqGFDa2pQGywtEv3Y8YKey06Y5 27yljMXpdI2eO0bo.ItreXOATlThMVr2jO5Px7dpFp28AsfIMw2OOi3K2Zss8orDSYaRhhNAVBtp tn0hsEsva7TF7gc8s.B.0XW223e9HiEel5_Upfh8lfP5mq7LVqJkXGTAzMB2gRzhEXkc0HiXYJRi grdExkne7VxFh21zuWy0u.soCIJ3ufsoNMpRbJvupc7.bwdE.CQ0lwLibfIWWamgcVwSo1fYFB0B SnI93oS4xdbQhmMfbUtYahifr1uW1SFE1_ekAkaxX8Wwza.5CrgPEdKCVn.D5f6HSp6G40zGZxJH tbPSecfhrVHOze4Y6wcV34.3up0tEAAsHMjcRMLP1SM0mBT7oaBcxtLliOEp5N6q2KL_2VMaprib iA1b7ydElQHUUyXxWXhWDPTSrLqEdlCsIxYt9dRLYC8qtljptTG05wBZM26OcNf56hLepRqvFR5A l1iPgWs5NWId1xUf9lkzhgsRcIQKa9sYSP2BidBQcO1Vs2uqd4cVzYK8DouYCK0rpTLyD2PzhkIr Ok8.xETvZL_NE1ZYj857hfYCFmFKzdYFP4BOKacRMfL7SOfN.a7ltErRM5_kZBzmP2m9jKxpOjWf k_j70SvhyGamQQN54hrIvygyjQZJ8giDp.Fw3SS_XFUf0sE7j0mAmZTZxZ_XiXUsSTx5dXylbINV bc5QjQm2IGVCi.62Eb96lwu9iFyWiy52amQ1L7UB0xswSlOakL3vC_SENQ9zXe_2xcySeX58d7lJ Soto98fB_2vcGdhXuRe9W3RkS7XgLKg1R1Dzofpy3AXrmvXuNNeOMDshs6TiLsL.Pueggk6kihu2 bFxK2xGsKHxfyKQ.b1YYoZ7LvnfMml5PfyqXzjc7bsDFx2N4veUqCEvYm4rwMbN.rCvd7u60eQLo jRlgir.3sh8QzmV9o9cqCd5dAWqXEhEk3erKpt4qK1VjmDC8MHRaizo_lXxc0McNEOkack75ImY9 up_6vHycvMTGkriXfLU7_hJFqHlgPKvISmpqNh4DgUzWmza1Ma7Ka3C5CWxV2BPB6zxQ6cU4b_b1 wtF81xthkg8Y7FIWJO.5h99P3D8n3CZgbl_T9ZiSsK_6ep1QRnWxMJkGBPFjgTTKb6DGGUU_DfX4 KtEdF6g6L1cHlaMQ3hSBQbac1a3E_TLk4v_RA7wl4UZIzYIKyJ.P9beAtfJvPKQP_dLg_7ARpMvz LyLCk_S.h3k.JP.gjKOVyuDRXW8kfLZLxOkIt9OND97EXP.16243DxddmeOXfs1UBdkUZVkM_At_ lRZ1b1rw6uiVFCSpNWE.bSa8N1vfdgLbbUwbR6s3unJpaRU7vWNimmusMHdpV_FAof4aeXZDPEC_ DwtlyamEGIpz0XvX5n8D2_GRAj_zpKfCp.vDNPb.IQix4qsjL0X76rGISbZnS6nLt7sSAAktgWEf pIN0gXy_dVekv2zE85l9.cKfQF0aj7GEABuAqYfN4HRWhcQOy3TxkP9OF.pBBau6u.sR7p79mTw2 FhBpFvS81qjLLQF.3k9sPSxlxtvxo4O70k.G2Ih0d5d11lNpXgMOcMcDhYng1N3iPGXYmiCEKtsQ EpLhaIGkXIiA26Aho8HO8uV74fUuyaxgQyRzuGeqarMoJT4SZY0hpH.k7b9uj3wEp89l4pothTBq mE0eKkaD2KqgH75ZlUyolwwPIVWOWb.UbWxtkzUVw6zueIQdv3NYXtEqBYYI2VqIWfyUMYaefW0R fMcGHtJxOyMTtc4LZ9N31U5Ro9ullIbn1WmeTAJufFC_D2lTJBOiGP4ybsnDlqx38QYjAF2Qx8i0 rkGJfGePAyZ3N7AGcjNUimxb2zhYj3ZsB5dfE.ItUDcLgSaCD7Csjck_J79W5itlfx0hZcGfa2Te VOOs9IVQcX0oDaJQ9axGTiCvllVH07pLyZ.56K5rz X-Sonic-MF: X-Sonic-ID: 3e58ec08-0dc8-4d98-83be-2a7e74387771 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v5 1/6] xen/igd: get PCH info from host sysfs Date: Wed, 5 Aug 2026 21:04:51 -0400 Message-ID: <20260806010506.492490-2-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806010506.492490-1-brchuckz@aol.com> References: <20260806010506.492490-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 5780 X-purgate-ID: tlsNG-d62444/1785978316-1DC79757-10579EBE/0/0 X-purgate-type: clean X-purgate-size: 5935 The igd_combo_id_infos[] data is out of date with many devices missing from igd_combo_id_infos[]. For newer devices not in igd_combo_id_infos[], get the infos from the host sysfs. If logging is configured, print log messages displaying the PCH info used for the guest. Introduce helper function xen_pt_get_host_pch_info() to facilitate getting the necessary information from sysfs. Treat failure to get the host PCH device id as an unrecoverable error that causes guest creation to fail. If access to the host PCH device revision id fails, print a warning message and use a default value of 0x1 in that case. Also, use errp in xen_igd_passthrough_isa_bridge_create() to set errors from xen_pt_get_host_pch_info() and cleanup on error path with xen_host_pci_device_put(&s->real_device) and object_unparent(OBJECT(&d->rom)) for errors when creating creating the IGD PCH bridge. Add cleanup with object_unparent(OBJECT(&d->rom)) for errors when setting up VGA BIOS for GFX passthrough. Signed-off-by: Chuck Zmudzinski --- Changes in v4: - re-wrote xen_pt_get_host_pch_info() using functions from xen-host-pci-device.h - add more error handling to clean up better after if errors occur - don't consider failure to get the PCH device revision id a fatal error but instead print a warning message and use a default value of 0x1 Changes in v5: - Shorten warn_report message to resolve checkpatch line length warning hw/xen/xen_pt.c | 10 +++++++++- hw/xen/xen_pt_graphics.c | 39 +++++++++++++++++++++++++++++++++++++-- include/hw/xen/xen_igd.h | 3 ++- 3 files changed, 48 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0fe9c0a..c8f08b5 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -862,12 +862,20 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) if (*errp) { error_append_hint(errp, "Setup VGA BIOS of passthrough" " GFX failed"); + object_unparent(OBJECT(&d->rom)); xen_host_pci_device_put(&s->real_device); return; } /* Register ISA bridge for passthrough GFX. */ - xen_igd_passthrough_isa_bridge_create(s, &s->real_device); + xen_igd_passthrough_isa_bridge_create(s, &s->real_device, errp); + if (*errp) { + error_append_hint(errp, "Failed to create PCH bridge" + " for passthrough GFX"); + object_unparent(OBJECT(&d->rom)); + xen_host_pci_device_put(&s->real_device); + return; + } } /* Handle real device's MMIO/PIO BARs */ diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index 7df9344..b37f9b7 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -2,6 +2,7 @@ * graphics passthrough */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "hw/xen/xen_pt.h" #include "hw/xen/xen_igd.h" @@ -376,8 +377,33 @@ static void pt_graphics_register_types(void) } type_init(pt_graphics_register_types) +static void xen_pt_get_host_pch_info(uint16_t *pch_dev_id, uint8_t *pch_rev_id, + Error **errp) +{ + g_autofree XenHostPCIDevice *pch_dev = g_new(XenHostPCIDevice, 1); + + xen_host_pci_device_get(pch_dev, 0, 0, 0x1f, 0, errp); + if (*errp) { + goto error; + } + + *pch_dev_id = pch_dev->device_id; + + if (xen_host_pci_get_byte(pch_dev, PCI_REVISION_ID, pch_rev_id)) { + *pch_rev_id = 0x1; + warn_report("IGD: failed to get host PCH revision, setting it to 0x1"); + } + + xen_host_pci_device_put(pch_dev); + return; + +error: + error_append_hint(errp, "failed to get host PCH device for Intel IGD"); +} + void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, - XenHostPCIDevice *dev) + XenHostPCIDevice *dev, + Error **errp) { PCIBus *bus = pci_get_bus(&s->dev); struct PCIDevice *bridge_dev; @@ -394,7 +420,16 @@ void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, } } + /* Newer devices get PCH infos from host sysfs */ + if ((pch_dev_id == 0xffff) || !pch_rev_id) { + xen_pt_get_host_pch_info(&pch_dev_id, &pch_rev_id, errp); + } + + XEN_PT_LOG(&s->dev, "PCH device id: 0x%x\n", pch_dev_id); + XEN_PT_LOG(&s->dev, "PCH revision: 0x%x\n", pch_rev_id); + if (pch_dev_id == 0xffff) { + error_setg(errp, "failed to get PCH device id"); return; } @@ -406,7 +441,7 @@ void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, * Note that vendor id is always PCI_VENDOR_ID_INTEL. */ if (!bridge_dev) { - fprintf(stderr, "set igd-passthrough-isa-bridge failed!\n"); + error_setg(errp, "set igd-passthrough-isa-bridge failed!"); return; } pci_config_set_device_id(bridge_dev->config, pch_dev_id); diff --git a/include/hw/xen/xen_igd.h b/include/hw/xen/xen_igd.h index 7ffca06..da51f09 100644 --- a/include/hw/xen/xen_igd.h +++ b/include/hw/xen/xen_igd.h @@ -22,7 +22,8 @@ uint32_t igd_read_opregion(XenPCIPassthroughState *s); void xen_igd_reserve_slot(PCIBus *pci_bus); void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, - XenHostPCIDevice *dev); + XenHostPCIDevice *dev, + Error **errp); static inline bool is_igd_vga_passthrough(XenHostPCIDevice *dev) { -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:05:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384037.1627121 (Exim 4.92) (envelope-from ) id 1wrmY0-0004O1-Cn; Thu, 06 Aug 2026 01:05:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384037.1627121; Thu, 06 Aug 2026 01:05:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY0-0004Nt-7h; Thu, 06 Aug 2026 01:05:24 +0000 Received: by outflank-mailman (input) for mailman id 1384037; Thu, 06 Aug 2026 01:05:22 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmXy-0004N9-QD for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:05:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmXx-008epB-NZ for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:05:21 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73dda4-2eae-0a2a0a5409dd-0a2a45059c28-38 for ; Thu, 06 Aug 2026 03:05:16 +0200 Received: from [66.163.184.148] (helo=sonic309-22.consmr.mail.ne1.yahoo.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ddcb-4cb1-0a2a45050019-42a3b894868f-3 for ; Thu, 06 Aug 2026 03:05:16 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Thu, 6 Aug 2026 01:05:15 +0000 Received: by hermes--production-bf1-54b5569bdc-xjdx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 734f0c8329adecc00a98ec91cc943adb; Thu, 06 Aug 2026 01:05:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785978315; bh=fw4HdPaoace2t+OlFHdLFzcl2NiVn/+uZd1DSdtjjQY=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=lpBzXO54AeZhZwpm97O/lgjN4Gr3Th1LXKX3gA4R48w7vBd+g18FjKHkRd0fdDvcLAWQQt1M4AjVWvsyP6BdVPSnjhG0ZpTrKO79NEHR+40umq4YOxBPM2hPl16n/VaN/UBg7wpZHRMnr9+pg/y7lzh5UshtMT8kQ54jUxGMdyAvj8eiQA+I9lBurvIJ9cDH5xTcxmSulY7BztygsSkv6Dn1Z+phMQzopZdsboh5hh3aFmF1ZvWerS7K27hdlWKxOY2o5ZFqkM/lIojuz/8A+bvc37k2rv5XlrRDfHcavlwVAkCkxSI4UPpht2LPXbXcgl3MWl0itOli9MbKoU3w/A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785978315; bh=OjKQGJpeXAI+iDr9u7zv+KwtGcuFJ0aLnWAIzROdy0U=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=N+9NBUvkHu3abSCTBrp8tHKMA4TKrNgF66gry3Gtg3Ib3RnFrqcPN7qL087GNup6l3y9v1daeeIvXuXdSD6Gt43quXGFs5qu3xohbdMxUQRL5fdZb7OcZBiu5DSiWoqo+Pxb5kXmQAES+t4g+3UNaHW+r8O5TmjKo8ffbCvIcqadVqQ/6RqDpJiB0AYKwZXT6M3EBvqMCD4kRwNaY3dB3CDlsyb9/OdK7Tca/d1Umz2fL6NOBndV3po0HLZ5le0mqVocLu0kjNWoGoaYA+U5NH2vxg2bAcGdnvQAzAjGEUu0T+JUi5KuuEEhM5DNMiljQZID17ZFDVywEXqtwXptVA== X-YMail-OSG: xqNcuykVM1l1WTx5uLZ.F2HoxO_Ro_7aK7ZBCq6T3BHtDa0hl3bajy9x40Hd3V7 3R27P7Ar41eEyBh.rxjGEJ4s0fPPIRRyYJmCaScZEnzpzl4mUq4UgYAatWujz1Q.oTbxzfV8Ilpk ZJMcWhMCP92LEYAmkoN8xESgFnSUQoL2Q1PVcqQ8bnE3TagICRy0L5velY4wHl4uiTpaZdniFcZt mniaRIxHNl7Slw8MIhQirWxy3y.19Oik2CcxMKiJGCJz1H_VLP.rKS1Or_nBvm3YlgZeE6WiGw.G LpuMw9GKgWHC9lY0v_nBpjC.1U9ZDSUY1Bos4LMjZWcblCXLH3kRAtGJOoRMV6Qg0UX3hAtlUBMr u3uMZfJaBDsypnj1qrQ9iYB5Kne5lWaRktG_c4dE3Kbdlsg4XS2ZJqNxiSw9ZpfcIcQqu6UEyZDj P2XGpWhsd3Q7H_TCL_VMYCA3pRthNaA9gOzOwQNjiU0EsCRB8eJzXtEyfA7wuJHzXf5XkPxeLLdD HhCyiKwOEJ3XdiRzlc8z6zBfl7olYAhs3QYTSGq5MDZnVrbVpkb7UHGlW_C23HFRLMmUDQ.GkQaU pI2_573A22uZvSuDaLmnMt6wyf23bujF722dBVa4a0w.6jE4O6UcQoyaJVIOfV7lY43GcypHUa8K 25Z4KXbrUkpBgBIY.yUik08IvCW.PyCxBSQXaafOsQcE7Lw7mFEX8IhYz0qDp7j8aeVIsuu7h55_ 72BbVnheQ6LEZhs66CCH.lmeFWYbqgWzZaP42d7xkSlfmiLl4n.hsG9_yuX7PnEyg1H3hVgWdZKl mQTgh9JQXGScN4Uw_LBNix6ooT5i.lB2.FSIaf7HOprkRZ4xHGU589euI9i9Y8OviSkgqPTWJUCY eaR40UMJ_aqLXsjwbRlxmc.SzBVYAAW35gPAEV_xJmAOxiarYmLoWWohCbvv2hMxY4Gl88MgiSxJ 0oxtsIlB1vaa1RVzI0SIVsgVhRviPqtYNZze4TSBirO2fPFpauitShrDYj6OPS3iIccyE.Ozbd.c V5dbLzCPCLsoOk6yu1W7fNvwtzqLSs5rFOnWjksHXMSm8AttaQZMVJoaMI0wXTmRmuF3bQEcLvSa hM8Kob_B5V8CkIwkzf1IK5n5PqTrrxzcuvz2tan0P8CSgtjZXGFm1gqOwg84GUqKW5n2THmaVfMz QYc1AurpEtVOcKdBKO.9X24mueXwylG5qSxRhd26vcuLckLhm0TAmZhyDM6CaQI_rA8aGY3.hiUr VNxBDAkE.kQ2zlUJp0m_EoKyzOcs3.xaxiT4BuQODnlx03ouSC2TGV5_MKnG0Nh0CGek670kgu7l QU2UNsm1MGQBM0bYD4nzoGOP2iN3_dqK5JIxrTz2aBi55trwYFwrKLA0jtALzoVon4_AIYldX9dr DiWI3N3cQwbybAyGC5rxTE39fNKoIPjCj93eyTd_8bBP8QnCh8TXN7J179zPHgmTG51hOVYbODZJ b7pqr.h9tjChP5sMzY0UhXb1ouZmYHlNkSQQIJxHX73WJsxS9T6nrfT71J0la.yzy_dYMGJZi761 FZAekQc1S30uZIrR7bGPGa8pVRlPjaigduxBaTQ3lK9YOSM3g5glF5okEqgs.dFJeOduVH6cZ3bT xwWbruwzTiRHeICwVftaTXvha.GAIdEYzz_QZ3xLq8mkWEzAT1o9Djn7xYmCaBTO3qOUbv4oT2gN zmQm2OmG9ahAn7CThj6kfihDcxDBthLefJdB92T6db9JmON_deVN_viafdb8uXacN9Gw.nMJpquh VJX5DYGoKTA.lpuk631VGItzp6oRQSBWeMTxsPKtnC4FIexDlIGm4cepPxgRH8NUXfp7fYLXFjml _C8mbvq9Vduob3ri0XDsGa8jBJHGBAlma9iDOfLcpv1S7PD0NsrqKNoAsbw4DGqDJ2Us8zCJkjw5 seIj4M.K8LWgQGOCMlEi1jJjHcY0o44PjVCPPcfiuxu13ag_zAe2b.ymWZFDGfPTMkc0aQhldouk BThRyoTDGsAngNqBRQcMOL4crTDHCqr2Ye2tHrIeM01Tbx3Rf7mGNRAfNxs5PgBgjTKwpfOKxTfC DyKMBf1auuSyXUDK5U08.uviVwwgkzXaE_P6KQTeNcHOR7gcLY.BdWY.N9jw5AmNRfG28IlOUUe5 XD2_r12rpi9J3K.XNBSgzyjtOIp.XBP0vfPrnUbFGHaFVP3SICP9XjTSpcisPSeN4cIYz2jWZxDb gZJqvnp7R62iWwKbBsng1Exsdlmr9aNvU6SdPEw-- X-Sonic-MF: X-Sonic-ID: ee9741dd-5910-4e33-8451-29e3ab64a197 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v5 0/6] xen/igd: fixes for Intel IGD passthrough Date: Wed, 5 Aug 2026 21:04:50 -0400 Message-ID: <20260806010506.492490-1-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <20260806010506.492490-1-brchuckz.ref@aol.com> Content-Length: 4947 X-purgate-ID: tlsNG-c201ff/1785978316-72AB72A1-79BB4FAB/0/0 X-purgate-type: clean X-purgate-size: 5058 Please note that Patch 5 of this series also requires a patch to hvmloader of Xen for the new support to take effect that is available here: https://lore.kernel.org/qemu-devel/20260802050824.10554-1-brchuckz@aol.com/ This patch series aims to fix long-standing bugs that need to be backported to all currently supported stable versions in order to support passthrough of both older and modern Intel IGD devices to Xen HVM guests. Note that previous versions of this patch series only fixed the bugs affecting older devices and the patches needed for newer devices were not included, so this is the first version of this patch series that is suitable for use and testing with newer devices that, for example, are designed by the manufacturer to only work with UEFI firmware. These patches fix several bugs that cause problems ranging from a dark screen in the guest until the guest OS graphics are loaded to an assert failure or other failures in newer devices that in many cases prevent guest creation from succeeding or cause other problems such as code 43 errors in Windows guests. To test the the third patch and verify it fixes the bug of no video output from Seabios, it is necessary to test with older Intel IGD devices that have support for legacy VGA bios (Seabios) because the newer devices, as far as I can tell, are not compatible with legacy VGA BIOS. The first three patches have been tested using Xen 4.21 and Seabios 1.17 on Fedora 44 using an older Intel NUC7i5BNK with an i5-7260U processor and have been verified to fix the bugs described in the individual patches. This device is compatible with legacy VGA BIOS and Seabios. With the fourth through sixth patches applied, it is possible to use/test with newer devices since, with those patches applied, the bugs that prevent guest creation from succeeding with many newer devices are fixed. All six patches have been tested on both the older Intel NUC7i5BNK mentioned above and a newer 14th Gen i5-14500 Raptor Lake processor in an ASRock board that, as far as I can tell, is not compatible with legacy VGA BIOS and Seabios, which means that, although one can successfully create a guest with Seabios for the guest with the newer device, there will be no graphics output from the guest until the guest OS loads the graphics drivers when using the newer device with Seabios. The sixth patch is provided for use with newer devices that require an EFI graphics output protocol (GOP) driver for graphics output during early boot. For more details, read the commit message and the accompanying notes in Patch 6. Two hints to help configuring Xen HVM guests with Intel IGD passthrough: - Increase the value of mmio_hole from its default value of 256 to at least 512 using the mmio_hole setting in the guest config. The value of 512 works well when the stolen memory is 256 MiB. If more stolen memory is used, the mmio_hole may need to be increased even more. - If there are rdm conflicts, lower the rdm_mem_boundary setting in the guest config from its default value of 2048 to a value at which all rdm conflicts are resolved. I have discovered that lowering it in 128 MiB increments works well. With the older device I needed to lower it to 1792 and with the newer one I needed to lower it to 1664. See the description of the rdm_mem_boundary setting in the xl.cfg(5) man page for more details. Changes in v2: - close open files before setting errp - improvements to readability and style - small corrections to the commit messages - add stable to Cc list Changes in v3: - whitespace fix in first patch - fix Cc address for qemu-stable Changes in v4: - add three patches to provide support for newer Intel IGD devices - edit the commit messages for better consistency of style - use 12 digits instead of 7 when referencing commit hashes - re-write xen_pt_get_host_pch_info() in patch 1 using the functions declared in xen-host-pci-device.h - handle errors in patch 1 that in previous versions of that patch were not handled - add a Fixes tag to the third patch - add two hints in the cover letter to help those who are trying to configure Xen HVM guests with an Intel IGD passed through Changes in v5: - fix style problems reported by checkpatch (see each patch for details) - update the link to the companion patch for Xen hvmloader Chuck Zmudzinski (6): xen/igd: get PCH info from host sysfs xen/igd: don't register rom bar twice xen/igd: fixup device id before registering rom xen/igd: enable guest creation when ROM read fails xen/igd: implement support for extended VBT xen/igd: use custom option ROM if provided hw/xen/xen_pt.c | 13 +- hw/xen/xen_pt_graphics.c | 282 +++++++++++++++++++++++++++++++++++++-- hw/xen/xen_pt_load_rom.c | 64 ++++++--- include/hw/xen/xen_igd.h | 3 +- 4 files changed, 327 insertions(+), 35 deletions(-) -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:05:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384038.1627125 (Exim 4.92) (envelope-from ) id 1wrmY0-0004RH-Le; Thu, 06 Aug 2026 01:05:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384038.1627125; Thu, 06 Aug 2026 01:05:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY0-0004QQ-G3; Thu, 06 Aug 2026 01:05:24 +0000 Received: by outflank-mailman (input) for mailman id 1384038; Thu, 06 Aug 2026 01:05:23 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmXz-0004NK-15 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:05:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmXy-00Dmiq-E7 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:05:22 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73ddca-e002-0a2a0a5209dd-0a2a4508a0e8-6 for ; Thu, 06 Aug 2026 03:05:18 +0200 Received: from [66.163.186.146] (helo=sonic302-20.consmr.mail.ne1.yahoo.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ddcd-f659-0a2a45080019-42a3ba928d83-3 for ; Thu, 06 Aug 2026 03:05:18 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Thu, 6 Aug 2026 01:05:16 +0000 Received: by hermes--production-bf1-54b5569bdc-xjdx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 734f0c8329adecc00a98ec91cc943adb; Thu, 06 Aug 2026 01:05:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785978316; bh=obmks52YmrFX3M/nOgH2+nRuVRmljJ9a96OvnoWzDN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=kh8tfiI5X2mLkXTltEf1/TcNAbw9dHgs2OXe6/Cx4f4Q2W6aW63BXJmSVUGkINreNcBD6FfkTh+LU/PZ/9ev/PPDIhFXlLEd5DF9qRH0ZT133j+EbvArqqLxdVG+CIYuBgZk87zNSAMfhBXeGs7TSvU4iQ0b4yTmxYhJCWMf35Xml1JursLU3YArBNZcnq06L792aANSeBpwycj45QA+42ABhE6pKl2XJwrrvkIHk/+NChuo4QrpzNRevFVwGoi2dY/qKiLP/Fg0A01edPoGhgAltg5IklPjIt6jt0yDOfQIw6DvU+RedQcECB3yfm/w+fbWJHmTkposNbKtQ7sIbw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785978316; bh=ck6kJNsZA5u6QunEVrirntyEJVzU70IKy2/Lw3IfRxB=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=seq5ZWIU5B6NV56rwGUzNRaiukH2pxkuBSHwIm5hFen4SIbMRS3ENPc4ZC5HG2zFkyDfYw+7H8SgJRr8ppyKspt5c+Xix+nMCLvw28oKcc+qUOMrrHWN09oRUtkmmAJnd/XsJ3R1cMJfqpVOSod/yacHuvYk/tzdQjxo6eU3r8djSoeeqOafayIiIcOgA8ANaGsxDIXI7j/YROY1dwuE/R040usL+uXjv6LQw5SXXEj1WHC0RVMJsA+ywcVHL5/YauFFy0VhTSVoYoM0OWCoRj4+bTfpDPzi1OzLla8XfeEAJuA6vARajc7CRv8mjST5gyrGsM6n7OYcR9pwZ77J5A== X-YMail-OSG: xe.__RgVM1l_hd0jAUIpXgp5HdcGo.Fg7qzC5hEqyLrEB6dmqcjtO7EnO83gYOE GdoUZIRcPl4682QnmcoLQDxFV1YiOxV7z10s9oiJciW3.BpnQ.xl6Lgs.cKFe9DEntPnhVV1Gflh R_vv_v5VsgTOgQTjb02wbhR7BaicgKG4m_5NYp0e7azVnegtsv2qznQfIXSZ49zCpPeVnSGepg7O fmpu1czhJ_Biamcu7HWQvW1Mtd.8RJGlHchC605NeDSR9t5VDe3vg1HrWv6DLy.3QmnAd39n07A8 .lKFqgozDDtOnri_pthmomKAXEiyEMQ8YkuspAETr67CtZR3EPi4SFc1msSD_8jcVPmqbtmDfIph 7b9_3yAdy6DCPrEfW4w9UN4MmRDCN7KcczKHG00eYBhCiBxrMlqEJ9sK0kt1tnO3XlKQeGtgSIIN wxAeuf49eyyqYUk.OHveIgmW_6luLMJOVxafp6gmx4XMS0Vlguc1Xwm.Z.xs._NrbIEU2q2mKpCs y6seMDNYU.ktsDUDJfy.ceAatpCRknL5pwf_0R_p.btzXt43FIgg5e6RMFfWfKgwKRgUPlgIby3y tgI0QlPDRbyRsnRDa.kY.iPAvTPehxuTQaaBGkIL6hiLSI72.0tcgw6x4Jr.LWK18RS.GBg5OnMQ 6JkXFbN3o.3YnKpKn2dioejzpgeRynZjC2o7y7Dl92drO.vdx6CHRQcEbVd8drtKjm16la502FUT xpAHW5IV9UCFOnyHi.MgIPUWKe1umqDPnbR3G31N1_nkIfSOqq7vKk5ke0EOOl4boXYe4gEPtLK. qcKeaSTJ4c_09WnQ9MC7R4DvUNJnqiXVMnJhncNhtZmdqvimtpw1kylQWUI4F7Lh1WlDHZdVVN6h pIO4ToiY3hi6msThigvzwkitiS5EfbihvX.ZRiVtw_OiLHQMtiAn6mpAsAjdHpPnNhClY8yOfUzu DzJZpcZvl0_N9QI0lTTfHoScNd08JMLERtnCJRwnR0UhIPQkVYRlRaL1iEBQjuDnjx4ehaCKgmky q.Vkq1.5lZAzuA0ERmMyV_YpQHn2h5qnNW.B4Jx4RaKF6g2JTqaMmgn.tW4nus77.m.PNufImZ.T UoYvMrVqEJfEWHgS_B6Vh8d0OJAPWHz24XFfojnZzjNai1NMg22qc7TWVkA8uliZFJ2_Lz6vNSb2 o1eMIYhugUrWwtaTUp78PY_BMTNclTpUHZLbIuF.XTz6Y6jrtZRjJaGcykPoBaHBWUzrIer0hxng 9Ob7D237hExdRe9MHXd6bofsbaTlAiX4LzcRY6lGqp7JTAJDgQhpSeAtBE11UbMV7F2dLYKjdCB8 kWEca00akBqg1IRbrp5MrzWZnrBKo7uqOH5vq6bjI_3RpnAycNPN11y02fmTv1Lzy6UuOMzeyuzR VzhkyxTLEMcNW3YqSZ3ZUTO5g6soWx0qu8CyL08K3.NvQTtDp8SBA9xRNJsunYksk6BEj0et1cRo dAzA739pPjyaG_oe9GgxB51kGjsfsgKNSkbM7eVQUMVmaIXToUsod553kFtJeIF2cLI1ZxtIrbpx rFtcrTKYuIbgmUfzxhstYUPtwFc.WIwNpFeBxzmsrikanf6LgzEakFK0sOn0u74SKYVyo4hvx1No eJZZ02NuN6jTEhvLoeTGPcLXcIVuueouRMUmOtUTRl9DFWvxpXahWS_hFhG1DRv4Ocycdp76Ywoe yVrQFO4OgRA_hewDljdN2taq7UP0CdkUirC7viQW9zPqdselF2hmN5zVP4boYIQz4tNufX_6FiBW vAP3XMiAnLXmXKBfU76WWUnbXrweMe4p_1TbsRcLodTHM8mrTor08pcS1.CyeclPwZZNe4Yx28Yg nyYk.DXoWZVX.FK9180XjYglAsD9HADqsiFeEVeQRqwuRTvYusctUptH_QxFWqMWG4l3FylIGUxq Ix4YdzqAbQOYT3i6YzrJygMfnKTskv7P4c.or6wbvNx8sXcVGQ5JHXweXIofznjQV_cdPh4Xo5hb YoYPZOOYmlxpFqCHO8QLyTGnCLSb5vgSjfQSHv6JW4cfmxMckt0B9Q8my7dPlHWYlbClCrUtZEBx PPY5Qk.SqfKiJCeGurO3y9X_Kln0_kUTQjRdaW14c2zavvGsmIA3bFBeDSNAJvaDRV1DRBUEqgDh h4afNOjFn7Oc5rmYt9ev15A3dYURu_esAZ9nUCCyBYkrEQ7at0wsBmIx0Zpelci_jnqmVAwxWS._ dFPtE9kCgzMSlHNYsqg9FDG2Odjjyg8YUroeIQb8- X-Sonic-MF: X-Sonic-ID: 446e3e3e-5ba5-48e7-8e09-de07860e2ac3 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v5 3/6] xen/igd: fixup device id before registering rom Date: Wed, 5 Aug 2026 21:04:53 -0400 Message-ID: <20260806010506.492490-4-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806010506.492490-1-brchuckz@aol.com> References: <20260806010506.492490-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 3210 X-purgate-ID: tlsNG-c1860d/1785978318-CCF4F87B-4E20A411/0/0 X-purgate-type: clean X-purgate-size: 3294 With the current implementation, Seabios does not see the fixup of the device id done here and consequently Seabios does not load the VGA bios and the guest screen does not light up until the guest OS graphics driver is loaded. So there is no VGA output from the passed through Intel IGD from either Seabios or the guest bootloader with the current implementation in cases when the device id needs fixing. Fix this by waiting until after doing fixup of the device id before registering the option ROM. With this patch, Seabios sees the fixup done here and loads the VGA bios, and both Seabios and the guest bootloader light up the guest screen in cases when fixup of the device id is needed. Also, remove unused header hw/core/loader.h. Fixes: 881213f1b9c5 ("xen, gfx passthrough: retrieve VGA BIOS to work") Signed-off-by: Chuck Zmudzinski --- Changes in v4: - Add a Fixes tag Changes in v5: - No changes to this patch hw/xen/xen_pt_graphics.c | 3 +++ hw/xen/xen_pt_load_rom.c | 18 ++++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index b37f9b7..0ae95cc 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -223,6 +223,9 @@ void xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev, } } + pci_register_bar(&s->dev, PCI_ROM_SLOT, 0, &s->dev.rom); + s->dev.has_rom = true; + /* Currently we fixed this address as a primary for legacy BIOS. */ physical_memory_write(0xc0000, bios, bios_size); } diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index 319efca..407b630 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -4,14 +4,22 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/error-report.h" -#include "hw/core/loader.h" #include "hw/pci/pci.h" #include "xen_pt.h" /* - * Scan the assigned devices for the devices that have an option ROM, and then - * load the corresponding ROM data to RAM. If an error occurs while loading an - * option ROM, we just ignore that option ROM and continue with the next one. + * Normally xen_pt_register_regions will handle loading the option ROM, + * but in some cases, such as for the Intel IGD, the option ROM might + * need to be modified. + * + * For such cases, use this function to get a pointer to the option ROM + * from sysfs. Caller has the responsibility to edit the option ROM as + * needed, call pci_register_bar to register the modified option ROM, + * and set has_rom to true for the PCI device. + * + * This function must be called before xen_pt_register_regions is called + * because if xen_pt_register_regions is called first, it will register + * the option ROM and any attempt to register it again will fail. */ void *pci_assign_dev_load_option_rom(PCIDevice *dev, int *size, unsigned int domain, @@ -76,8 +84,6 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, goto close_rom; } - pci_register_bar(dev, PCI_ROM_SLOT, 0, &dev->rom); - dev->has_rom = true; *size = st.st_size; close_rom: /* Write "0" to disable ROM */ -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:05:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:05:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384039.1627138 (Exim 4.92) (envelope-from ) id 1wrmY2-0004ph-0A; Thu, 06 Aug 2026 01:05:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384039.1627138; Thu, 06 Aug 2026 01:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY1-0004pT-T5; Thu, 06 Aug 2026 01:05:25 +0000 Received: by outflank-mailman (input) for mailman id 1384039; Thu, 06 Aug 2026 01:05:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY1-0004Zp-5k for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:05:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmY0-00Dmq5-IG for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:05:24 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73dd9e-e002-0a2a0a5209dd-0a2a450bc99e-30 for ; Thu, 06 Aug 2026 03:05:20 +0200 Received: from [74.6.131.125] (helo=sonic311-15.consmr.mail.bf2.yahoo.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ddcf-b7e8-0a2a450b0019-4a06837d9972-3 for ; Thu, 06 Aug 2026 03:05:20 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Thu, 6 Aug 2026 01:05:19 +0000 Received: by hermes--production-bf1-54b5569bdc-xjdx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 734f0c8329adecc00a98ec91cc943adb; Thu, 06 Aug 2026 01:05:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785978319; bh=h5QyMZ5Ty9ooeK2ctmMp9atdh7YP6qYwvti8uYhWKKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=WXNAtiY9RChQYvCGuuLGy7KGeXy4O9j6SP/y0MMsyyqqenPnDbYnoFLGfDrF5fVHHb1gmmsRPzK1Lz9Af4qI1Loal/uC6jTdtVsCA+EHctj2FC8sTzWwRl8SgPNv/NJMOWF4DKuiguWQY3hlwwZu+3tA4feJB5saI1xkQxHCdu4ySoClKu8vr8YvVrEWw2B23fEdFpL+ggpAoglcPwvLuOBjVlHpaRO4S84b6Fk+ITC/npzOSdIVqKCERgRM+HeH3yVSqw/T5SBa+8q6QjRbZULn4eDUOqZ1wGv4Qq5HH3+75yv0Bz9kWyU102qR2pquN8JiME/3ZU0ZicdruySTmA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785978319; bh=HtHedw0HjklR4Bxd03Z/oktcnxIu5kpeFcKt5A5jUx9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=sci23NeLeQW7/83wPOO2xYxrJrnIzvA1nCne+qp01PehatgfHclk9IQBzehCg/x9lN7XF1Xhwg89pyZLdxTctgs9u1D3DIYJrBb0lCA3MYiQHi97zp6MdBfZYh1Ia7wh14EmS0KZi061RkXmAqOAC46QwFtIdGwdUJZNjqX5ODGJAVEvgmDUOujEQ8tw6ubB2K3KltLYZeyY0rUJYW2E1xuAYuyl8ts4/pWr5swcrhgHHDh/9I2+ZbR588UKIu/DHoIFFMrxzd9wWhcyYrBBWniH/oLZZZodThbnFKnYVgCvNWqm4LP4vLSP/SrE7FzckSaghPTcbWUGAlffpHWPCQ== X-YMail-OSG: NjVK234VM1lD9.mUG.YoQ1naz2l046QG0gja2Xq3fbevJ7ptMpnQ.3EcZS3oYyn NhwfjfzgkSM7ZkTtioAD9keWSwSCStzoJAxvYag7LL.5zN51nW4NJyYOKgh6A_Po5i4KsrN86u6P pZqUoSBIr_SsMXRRc49x5tjkTKiaVc1T7uB940mTZrmGcEPSWibZrf482SnBnOtuPv8p.NdTEUQi ZtLT9c6IcJWwgCAAIwr4pUYIKnq28ozHaqd4l3MdriQrRRLGu79Vfu7bt6nlCRoykDfNgq95p80c XQoiuVbNB8KnrPrlAUgnZe9Xr0nrKWTyHRNhEteUjsvxn4bK2XvEJT.Mw3gb7dsPk8GxpjfydzyJ lPlacR4Oly.TtnsZmUUUym.4XrqCJdhk.7nySdVeqywdoAu3vAETdcJhjbhtHBrbyAU61hk7g6ZW mCKfXSeagiSrGBtX8M_t_8JHiRxVbO7yhx0d3iSPglkqm3XUzEY6TIPO5FqBI9FM6iADU90EQmkr CxBDDEFFBST4kOa5oPj7FR3hdiOOxxHjW0rOO0EFJGRq2kGXKfz7uit7ASoM5UKf_tIxKjGVaVjf u4lsJKgFWBttSL1tCvxIaMI83QfS_WzS074zbhymysSx4n5NZkFnFfeOQHvvwKFEgl5CrskUYE5E HIqdg9OOGb1oUCe4Qmm3lQI_unMugQP55LYYtAaDzBBfiwIyhjxKrstXAAqPB_YMTH4.TM9tlzHO JByQPb5Nlpx2B.xSMQfEckVgvOQIjBXY.sSeVhjt.so6Pk_8mDnZ4Bsvsj9MAJzmcVr0lDkIqcP8 fvGYjqiAyT2GELjU5PNae4djk4ZphG4hrnnKsHA7.Hb6ysoo9GELD4mtYt3debFIn0.xz8w6hVvC xcpc3ZWrptF29SKGUaQwAijwVJUSCueLE1BD9Fc2e39UF08TTcYRw4iHCLqWsr0.LjenWlD9.yGP c9KmoarKCFGAGV0ioLtksq2rAR6el_04YYGq1sSse4pNrG94.rbhem1NJcdpEKSgrf3KNIMAxG9Y T7DFotuHgwUCdxmo7spfxdmJ7DXIX7JWYuYYdKeyIiHa2VPwbRubXvyTkhkHposzL7w1ucCHloHr _Gk1z41Mic6aoC6bSyKZ8vt4s.qsz7AVl2YRO5sJDlYNaJEA1Th53gRShg.bnJUXvXZrdOmo3Fr8 kM7t75B1srS4Qh6AgYpkGg45kl85pePrRBqW5XfB_8v9P7D_LOz9UySUcR0n..APL5OAh164QtLM jqKiPnKDSPuD6YXjE3QXO45N0ukzjQ5jzAA3iBGnm_qgeuQyDRDM4S7ZEOR4SIs0YiQ0N.VKAFcq IfDXALKaQK9ZRKX_b0DJ7GRm5K6v3MvZwCDvTYK3VxJVpqIIb93fQuv8G80bK_hgkgNhBlR7qHaW 8dEQ50f2.PHapsTahNTchVhHVwph76zvUPF8uUzlfpuBh41snPpWf_FcwRYDizghVEYYl6AN0hcX efd_Tq9goGIMJGg7eVT.CHLop8VblyT59azRqBtIvrXqqKAVhcW_O60iB_NTzAzbg47M2taBg1jj 3ZtZH9ykhUOdgq8lBLPbQbHDKTFUIgDbzAreNhd56.atJ5SGdATudlourGtr6GaVBYKEGm489kwi tNUfKscmt5bilcr.7bjnWOcP3DCUM_Asxv8OwLyZPGe.PmmTJvzL4FRYpYqRKWUFNXGzF7Ydzxv7 yiihKuTJ7ifon0_PEskGgGwyAAgFllt2E29nviS5xdba.Hk7Xogx6hu0OSHiSbON13mZ_nMqaO.X 1KMjMA0vewPIFeVVRxc6bPs23aoJNPldQwwrxFXy5HF6p9EcuyYFfuUxAydYz4KflpQQiSEHxx4E X9O54dy1Ln7sf0X6ctLLJfHWS61dREG._tczC_CXwGmckDZgyOWPJPuHVhRoJlO23C31_nDjRf2A 6cmXuoMxeGXd5P_r2EupZqCj_VNlh03j0MK6EpNAxOXqD.eW7_aD8YFpYXIHojh4NGeLNMsv.vvq 4MTPisFmRRxCR9EDOGW60Zq0hWwH3Jpsa8ZBe_4CaG4.XH7A0eELt9DMjNUDCr21I_RPrDSJlg0w pfaeuzGNC4Boe69QUvMpU9jyvIxL.gENusIDMyvYGXeyhK4Ajr8j47btyu2lRIUGLzwJCTaiEKsj ITGG5.7L5LyWfXrpxHM0poUOaP.OPwpFDvHXjFp4XJypdJo9R_fZ0kJjJ.qeLNICSNzE5aM3IqTx OAw_.0S752jcQsBRsRfsXMqV1G8BHpg.7rQE95A-- X-Sonic-MF: X-Sonic-ID: 2529bb1c-5623-4262-a178-66bc47244aad From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v5 2/6] xen/igd: don't register rom bar twice Date: Wed, 5 Aug 2026 21:04:52 -0400 Message-ID: <20260806010506.492490-3-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806010506.492490-1-brchuckz@aol.com> References: <20260806010506.492490-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 1312 X-purgate-ID: tlsNG-42698a/1785978320-1A2C49EA-CF5DBA8D/0/0 X-purgate-type: clean X-purgate-size: 1353 This also fixes a failed assertion in pci [1] for Qemu version 10 and higher when passing through an Intel IGD with an option ROM to the guest. [1] f6fc01c78666 ("hw/pci: Assert a bar is not registered multiple times") Fixes: 881213f1b9c5 ("xen, gfx passthrough: retrieve VGA BIOS to work") Signed-off-by: Chuck Zmudzinski --- Changes in v4: - Use 12 digits for commit hashes Changes in v5: - No changes to this patch hw/xen/xen_pt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c8f08b5..4d159a2 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -459,6 +459,7 @@ static int xen_pt_register_regions(XenPCIPassthroughState *s, uint16_t *cmd) { int i = 0; XenHostPCIDevice *d = &s->real_device; + const pcibus_t romsize = s->dev.io_regions[PCI_ROM_SLOT].size; /* Register PIO/MMIO BARs */ for (i = 0; i < PCI_ROM_SLOT; i++) { @@ -495,7 +496,7 @@ static int xen_pt_register_regions(XenPCIPassthroughState *s, uint16_t *cmd) } /* Register expansion ROM address */ - if (d->rom.base_addr && d->rom.size) { + if (!romsize && d->rom.base_addr && d->rom.size) { uint32_t bar_data = 0; /* Re-set BAR reported by OS, otherwise ROM can't be read. */ -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:05:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384040.1627147 (Exim 4.92) (envelope-from ) id 1wrmY3-00054M-8Y; Thu, 06 Aug 2026 01:05:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384040.1627147; Thu, 06 Aug 2026 01:05:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY3-00054B-4f; Thu, 06 Aug 2026 01:05:27 +0000 Received: by outflank-mailman (input) for mailman id 1384040; Thu, 06 Aug 2026 01:05:25 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY1-0004dF-AL for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:05:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmY0-00GWgj-NP for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:05:24 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73dda4-2eae-0a2a0a5409dd-0a2a45059c28-42 for ; Thu, 06 Aug 2026 03:05:24 +0200 Received: from [66.163.191.148] (helo=sonic304-22.consmr.mail.ne1.yahoo.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ddd2-4cb1-0a2a45050019-42a3bf94939e-3 for ; Thu, 06 Aug 2026 03:05:24 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Thu, 6 Aug 2026 01:05:22 +0000 Received: by hermes--production-bf1-54b5569bdc-xjdx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 734f0c8329adecc00a98ec91cc943adb; Thu, 06 Aug 2026 01:05:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785978322; bh=evB25RMTSzQAfthgYsyzolI932AZpxXExd3y4km457k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=CGhAqESmK9usG95tKKWtvULiwhR46Cmj4l7Nr/fBR4x5IKPPJs6g38HCr2NM21HXJsUgAUJ8N6UWJ3eFdw9HzEchjDUGaIm4f8xt/2kvzrj+WFqJ3HywKjZ6P7wks6eMkEdDgcoK9EPjdQjRI9WPM++7WvzQj3ZXggg+bw86fE7eZWGkEF8U92+7krdc5x6ixZxk5oqhnFy50Jwt5TR0zxzQsp+4yHIm7Yrdxt2aUp1PoD12KMCqEcbz1yAnBsv4rxa4F7Bj2kERZSgLoXx5d20hd5PcASUj+J4eNybUcf2nGkLIK9cQfnVZnHuk5VFVUZ6Dn/VVwAMJETa2EKurgw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785978322; bh=UoVOmCdCQ4BIcpmuzCu7GbBrf0XMwYbjqiL6WaXGwGX=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=q/VFzd9fSN+dkVHeetwvtfjDntAAUUfkPKWOACKE+YSrmkYhahKW7eT7a6nfZtDIcM/CR99Y3AqmyniaMKSJUYi+4RXDum1eq/BV284MZiaNzbBVgUOdjnRInHRNHQ521t8vD050DiqUmp/N1tjhxQu31YXPvkDcnpWVgguNt5eiyqDm0cILdPd12A0efbjx00kFha4ymiyWfpv+YPBZ6DwcsUGrZF3xNdgcatRfXKoEJXiDniM8gs1HRChibjD/QfQPxx8ptuOXpkFTacf2mk8jsrEY/07p/MYe3cahlwdYvcqxWUJPb89FrGPJxH1c1IgkOfKXKpKkAWEdrC92xw== X-YMail-OSG: wKTvT74VM1l3.wJJxXa53Q_pbyAuRjVyoIJPGNVxZfNtF4hUodYF0AqMELrgeBi _sIDSjSMELVdo2CAcOMn9.eiXjo4r8w_VX4pguyV9XkDtXs4YdpH4NYJEnIijAuuSbyFSHwKRThY wyM5r_edXDMtcvauaZNwzgpxzyaqXd5bf1KWjcJH5sNkRcfp4RauVUG4xj0oItng9vkKZLrJjcFq IlxEay5ao8tNb4tEEM3BNN21FL17ax_wcsqu6PQjVPQSt7Fsvu.v27vmUrKRQx15pR68rB5qz66Z iVnXJ_BgeBEdfHG_yIJALoUt8zFRwn8ehHsyX1VzcvuT8Tli5IKmqfS6AsFcEGv4rrTi0oIagr54 K_alXnfMNPBJEE3WjV3l_UAP31OKKgYg5KXelX4UlQ8jj3Pt_2fXZRr8IunNV.x477cMNx0Tf3q7 HwgTSMXl6Cx2fsZkgaNw3yNtLO834M_vSgE7sZBICincNPBUeKx5.Ld.7BbY4ueQzoprYPUAIjH6 AaP_KkvsvBwsGgnKX0b6.MdoGmR76RajBwHsZr0LZINLN6b9R0rCFD1Z96y4xU4ssOFciDF2zNxu mJ24dBI0Ngz9IzrvkE9aNG3BCM3EK2JPIZtSfIOrM9TTtUVX8i.XChs6l0kzQZYJAQKPZ9o4uZTT Ia80MuUls17e0_DJkvQL_OrskRdzuwXGhFJkwCgyUEvh3ikO4cslWpFMJTujEoYOHuKTWl5exuGO X1ttqpvlzukQWmx7XdZHBIbUFAF999nUsqgO4te_cNMd6wurJ9o7.i61n_Q3_Y4Jt948OsjdP8sB 68iCOLZ4ygL55VywJSmM4G69ASSRs541BIV3D5jHhocPYxaOv7GASgMSdwaAmP3NLXHrNQpv3CUs AHIwXZabTe9T3IfeGkV9sfV1tcQu9hjKfm.Ob4YuBRSqbf5CbYg5h5I6Cz9t3fyqPNKHnqPVTSry r8Nb12mcHMJrNqg_8UxyZEbBjip0dj3VXMH4gSTUb.ixPig0kLDuLT9_JOS4X4NuS4syONJE2qel vQjaH4ENmBjpzA7HLPZEboIyLAztTspvzYV8VqlT0gAXgtZtqr6gzrcVO_qYg0BpaKfd4oTlm_1Q mU_IlTXLjCyXksDE3B_BibAAIHhYMv8V3j7BMATvCIuFxvfr8mXp5MKScNLBL8vSRq98BZjVXLdF w3e8psinkPI3k2Ve8v_Kj46l6JZke3l9dE39zx_YM7xxJdoKiENN01bZIOwdaB.g15W4gg4fvb6u iSNB69Z0LfQAxlith8Z7sqNyBWM7e3FByu9tdGj8tNUskVRerRLCALrg7_hDGeojtkbdZZRJbJlF xWfIewEfc_VzkgCJBx6zBbP0BVnCcW0TQYqLdXobVNzW_X2VAafQ1B8GoAOarcbkDAA8xxUVed2K svsZR8lwNSzuBGevM1oIR2nt_csErLLbwQM9cjYdw.D_dwwVrOJsUujRrWwaykrcuk0Eff8Ucii1 FBzP5Pz8YEZNqEcu5J2fYyyIIqSEeLUlhXu_3dfWuncrN.zw_G3ZKK7aZs16Urh3gHCwWErlQOaQ vH7zzFaaOHpsEkkiTPkkeFVOnP8sBwQ3alydE85Jq0d2RbXD5fRFLVWEj5LHAxBuhC1G0y30dmfa EFfPkAwXmfpcIzQNbelQDUvuZUbZqqI.TrQwmFYbRVX5I59FLHCOYqToK8Mlp70kKy0JSvHgbiMd WRvuOgCYNXul_KU3eO4ha6NHilwDP_kBbtBQHdYtI59FU2xEmCKf_oVDsH0_dKYkMgXKqxED2qTx hkh4XL9CaL5cuoR5tpoX6mzW9VwGHaq_mIXaU3Kaua5.XIEXUaU5Dhk.DUKwiBb45c6gYevdW4Lh SDh0Le2Z.AihHQCYIvlRK4B7N9ocQq1_Py6JjJNfYJwy7yaW6jh9tUPuVd7x6gc9adogTBxiUx0j qWVQJIk3h5.eh51CdStywHJQJkmd8oZ_PU3Hrg9gQAsfcLO_VWuyP2vHeG1qewFpV234E0KCnHd_ U2noFmL1g6ae.iV.kr4PtwQZSmWLDNakcws4CX3J0Vm9nDoX9z6RuHN6N.x.koGoITFtg3OXgBKF c8gsiZ7W53V0NQ3rHmGqjxwOs4w.F68jvUlGTJYrFAydsYLjTC.KvtMeDAzuakDINmvR0rm2TPXo FE74kE5q7P8OHqAoxHX2X9OLj_p9ucP2JTDNvT4mWRABeXyN6RnvWO_w5i.RgSz7CA87HmoVMvkI 0oVzK6KX9x9Nbkxo9r5PZhXsZkDi3eiyI5O.49vrt X-Sonic-MF: X-Sonic-ID: d6264233-3872-45c9-8ba3-4c440a588136 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v5 5/6] xen/igd: implement support for extended VBT Date: Wed, 5 Aug 2026 21:04:55 -0400 Message-ID: <20260806010506.492490-6-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806010506.492490-1-brchuckz@aol.com> References: <20260806010506.492490-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 14820 X-purgate-ID: tlsNG-c201ff/1785978324-720AA2A1-A7E3AB38/0/0 X-purgate-type: clean X-purgate-size: 15160 Newer devices with versions of the OpRegion >= 2 require an extended bios table (VBT) in some cases and also in some cases require modifications to the OpRegion for proper operation in the guest. This is in contrast to legacy devices in which the VBT is always embedded within the OpRegion. This makes the current approach of providing only the unmodified host OpRegion to the guest with no guest access to the VBT insufficient for proper support of devices with OpRegion version 2 or higher and an extended VBT. Support for extended VBT also depends on compatible support in hvmloader. If such support is lacking in hvmloader, fall back to the current protocol that does not provide support for extended VBT. To implement support for extended VBT: Instead of configuring the guest with access to the unmodified host OpRegion via hypervisor mapping of the OpRegion from the host to the guest, temporarily map the host OpRegion and VBT into the guest, allowing the guest (hvmloader) to get copies of the host OpRegion and VBT which hvmloader can modify as needed to support cases that require modifications to the OpRegion. In xen_pt_unregister_vga_regions(), do not try to unmap the OpRegion in cases when the OpRegion is not mapped during normal operation of the guest, and replace the constant '3' with the macro XEN_PCI_INTEL_OPREGION_PAGES which is defined to be 3. To implement this: Use 'done = true' to end further processing when the OpRegion does not need to be unmapped in xen_pt_unregister_vga_regions(), and use 'guest_supports_opregion2 = false' to end further processing when the OpRegion does need to be unmapped in xen_pt_unregister_vga_regions(). The OpRegion 2+ support that can be provided by this patch and a compatible patch to hvmloader is required to fix code 43 errors in Windows guests that have an Intel IGD with extended VBT passed through to the guest. Link: https://lore.kernel.org/kvm/20211012124855.52463-1-colin.xu@gmail.com/ Signed-off-by: Chuck Zmudzinski --- Changes in v4: - v4 is the first version of the series that has this patch Changes in v5: - fix style by adding braces to two if blocks and not initializing two static boolean variables to false - update the link to the companion patch for Xen hvmloader The companion patch to hvmloader that is needed to make this patch take effect is available here: https://lore.kernel.org/qemu-devel/20260802050824.10554-1-brchuckz@aol.com/ hw/xen/xen_pt_graphics.c | 233 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 225 insertions(+), 8 deletions(-) diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index a124233..3d2a94c 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -12,7 +12,26 @@ static unsigned long igd_guest_opregion; static unsigned long igd_host_opregion; +/* + * These are true until they are set to false when the guest first + * accesses the OpRegion address register for a read or write, + * respectively. + */ +static bool first_guest_opregion_read = true; +static bool first_guest_opregion_write = true; + +static uint32_t guest_opregion_extra_writes; +static bool guest_supports_opregion2; +static bool done; +static unsigned long rvda; /* absolute host VBT address */ +static unsigned long vbt_guest_pgbase; +static uint32_t vbt_nr_pages; + #define XEN_PCI_INTEL_OPREGION_MASK 0xfff +#define XEN_PCI_INTEL_OPREGION_PAGES 0x3 +#define XEN_PCI_INTEL_OPREGION_ENABLE_ACCESSED 0x1 +#define XEN_PCI_INTEL_OPREGION_DISABLE_ACCESS 0x0 +#define XEN_PCI_INTEL_OPREGION2_SUPPORT_MASK 0x1 typedef struct VGARegion { int type; /* Memory or port I/O */ @@ -117,11 +136,11 @@ int xen_pt_unregister_vga_regions(XenHostPCIDevice *dev) } } - if (igd_guest_opregion) { + if (!guest_supports_opregion2 && igd_guest_opregion) { ret = xc_domain_memory_mapping(xen_xc, xen_domid, (unsigned long)(igd_guest_opregion >> XC_PAGE_SHIFT), (unsigned long)(igd_host_opregion >> XC_PAGE_SHIFT), - 3, + XEN_PCI_INTEL_OPREGION_PAGES, DPCI_REMOVE_MAPPING); if (ret) { return ret; @@ -239,7 +258,31 @@ void xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev, uint32_t igd_read_opregion(XenPCIPassthroughState *s) { + if (!igd_host_opregion) { + /* We just work with LE. */ + xen_host_pci_get_block(&s->real_device, XEN_PCI_INTEL_OPREGION, + (uint8_t *)&igd_host_opregion, 4); + } + + /* + * By returning igd_host_opregion here instead of 0, we can + * indicate to hvmloader that we support OpRegion 2. + * + * The conditions are there to prevent returning igd_host_opregion + * to guests that have a version of hvmloader that lacks support + * for OpRegion 2. We do this to maintain backward compatibility for + * guests with earlier versions of hvmloader that always expect us + * to return 0 instead of igd_host_opregion when igd_guest_opregion + * is not yet set to a non-zero value. + */ + if (first_guest_opregion_read && !igd_guest_opregion && + first_guest_opregion_write) { + first_guest_opregion_read = false; + return igd_host_opregion; + } + uint32_t val = 0; + first_guest_opregion_read = false; if (!igd_guest_opregion) { return val; @@ -251,21 +294,195 @@ uint32_t igd_read_opregion(XenPCIPassthroughState *s) return val; } -#define XEN_PCI_INTEL_OPREGION_PAGES 0x3 -#define XEN_PCI_INTEL_OPREGION_ENABLE_ACCESSED 0x1 void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val) { int ret; - if (igd_guest_opregion) { + /* hvmloader with OpRegion 2 support uses lsb of val to indicate support */ + if ((val & XEN_PCI_INTEL_OPREGION2_SUPPORT_MASK) && + first_guest_opregion_write) { + guest_supports_opregion2 = true; + } else if (first_guest_opregion_write) { + XEN_PT_LOG(&s->dev, "hvmloader lacks extended VBT support, " + "continuing with legacy support only\n"); + } + + if ((!guest_supports_opregion2 && igd_guest_opregion) || done) { XEN_PT_LOG(&s->dev, "opregion register already been set, ignoring %x\n", val); return; } - /* We just work with LE. */ - xen_host_pci_get_block(&s->real_device, XEN_PCI_INTEL_OPREGION, - (uint8_t *)&igd_host_opregion, 4); + if (guest_supports_opregion2 && !first_guest_opregion_write) { + /* + * OpRegion 2 is supported and we are processing + * additional writes that the legacy protocol ignores. + * + * We should always return from this if block to prevent + * executing code below which is only for the first write + * when we map the host OpRegion into the guest. + */ + guest_opregion_extra_writes++; + switch (guest_opregion_extra_writes) { + case 1: + /* + * Hvmloader expects us to store the value as the least + * significant DWORD of rvda. + */ + rvda = (unsigned long)val; + break; + case 2: + /* + * Hvmloader expects us to store the value as the most + * significant DWORD of rvda and unmap the OpRegion if + * rvda is not equal to zero. + * + * If the unmapping fails, hvmloader will fall back to the + * behavior of older versions which simply map the OpRegion + * from the host to the guest without trying to configure + * the guest with OpRegion 2 with extended VBT support. + */ + rvda |= (unsigned long)(val) << 32; + if (rvda) { + ret = xc_domain_memory_mapping(xen_xc, xen_domid, + (unsigned long) + (igd_guest_opregion >> XC_PAGE_SHIFT), + (unsigned long) + (igd_host_opregion >> XC_PAGE_SHIFT), + XEN_PCI_INTEL_OPREGION_PAGES, + DPCI_REMOVE_MAPPING); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't unmap IGD host opregion:0x%lx" + " from guest opregion:0x%lx.\n", ret, + (unsigned long)(igd_host_opregion >> XC_PAGE_SHIFT), + (unsigned long)(igd_guest_opregion >> XC_PAGE_SHIFT)); + rvda = 0; + guest_supports_opregion2 = false; + } + ret = xc_domain_iomem_permission(xen_xc, xen_domid, + (unsigned long) + (igd_host_opregion >> XC_PAGE_SHIFT), + XEN_PCI_INTEL_OPREGION_PAGES, + XEN_PCI_INTEL_OPREGION_DISABLE_ACCESS); + if (ret) { + XEN_PT_WARN(&s->dev, "[%d]:Can't disable access to IGD host" + " OpRegion: 0x%x.\n", ret, + (unsigned long)(igd_host_opregion >> XC_PAGE_SHIFT)); + } + } else { + guest_supports_opregion2 = false; + } + break; + case 3: + /* + * Hvmloader expects us to store the value as the address + * to map the VBT to in the guest and to map the VBT at the + * provided address in the guest. Hvmloader encodes the number + * of pages to map in the least significant 12 bits of the + * provided address. + * + * If VBT verification fails, hvmloader can't determine if the + * VBT is mapped but corrupted or unmapped, so it crashes the + * guest as an unrecoverable error. + */ + + /* address (gfn) to map VBT to in the guest */ + vbt_guest_pgbase = val >> XC_PAGE_SHIFT; + vbt_nr_pages = val & XEN_PCI_INTEL_OPREGION_MASK; + ret = xc_domain_iomem_permission(xen_xc, xen_domid, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, + XEN_PCI_INTEL_OPREGION_ENABLE_ACCESSED); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't enable access to IGD host VBT:" + " 0x%lx.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT)), + rvda = 0; + vbt_guest_pgbase = 0; + vbt_nr_pages = 0; + done = true; + break; + } + ret = xc_domain_memory_mapping(xen_xc, xen_domid, + (unsigned long)vbt_guest_pgbase, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, DPCI_ADD_MAPPING); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't map IGD host VBT:0x%lx to" + " guest VBT:0x%lx.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + (unsigned long)vbt_guest_pgbase); + rvda = 0; + vbt_guest_pgbase = 0; + vbt_nr_pages = 0; + done = true; + break; + } + XEN_PT_LOG(&s->dev, "Map VBT: 0x%lx -> 0x%lx\n", + (unsigned long)(rvda >> XC_PAGE_SHIFT), + (unsigned long)vbt_guest_pgbase); + XEN_PT_LOG(&s->dev, "VBT host address: 0x%lx\n", rvda); + break; + case 4: + /* + * Hvmloader expects us to store the given value as the + * final value for the register that stores the OpRegion + * address in the guest. We also unmap the VBT since the + * guest now has its own copy of both it and the OpRegion. + * + * If the unmapping fails the VBT will be mapped where + * hvmloader needs to place the OpRegion plus VBT in the + * guest E820 map. In this case, hvmloader will crash with + * BUG() rather than try to use the mapped VBT with the + * guest's copy of the OpRegion. + */ + igd_guest_opregion = val; + ret = xc_domain_memory_mapping(xen_xc, xen_domid, + (unsigned long)vbt_guest_pgbase, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, DPCI_REMOVE_MAPPING); + if (ret) { + XEN_PT_ERR(&s->dev, "[%d]:Can't unmap IGD host VBT:0x%lx from" + " guest VBT:0x%lx.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + (unsigned long)vbt_guest_pgbase); + rvda = 0; + done = true; + break; + } + + ret = xc_domain_iomem_permission(xen_xc, xen_domid, + (unsigned long)(rvda >> XC_PAGE_SHIFT), + vbt_nr_pages, + XEN_PCI_INTEL_OPREGION_DISABLE_ACCESS); + if (ret) { + XEN_PT_WARN(&s->dev, "[%d]:Can't disable access to IGD host" + " VBT: 0x%x.\n", ret, + (unsigned long)(rvda >> XC_PAGE_SHIFT)); + } + + done = true; + break; + default: + break; + } + return; + } + + /* + * This code handles the first write to the register from the guest. + * It maps the host OpRegion into the guest. + * + * Set first_guest_opregion_write to false to enable more writes + * if OpRegion 2 is supported. + */ + first_guest_opregion_write = false; + + if (!igd_host_opregion) { + /* We just work with LE. */ + xen_host_pci_get_block(&s->real_device, XEN_PCI_INTEL_OPREGION, + (uint8_t *)&igd_host_opregion, 4); + } igd_guest_opregion = (unsigned long)(val & ~XEN_PCI_INTEL_OPREGION_MASK) | (igd_host_opregion & XEN_PCI_INTEL_OPREGION_MASK); -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:05:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384041.1627152 (Exim 4.92) (envelope-from ) id 1wrmY3-00057n-Ms; Thu, 06 Aug 2026 01:05:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384041.1627152; Thu, 06 Aug 2026 01:05:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY3-00057d-FH; Thu, 06 Aug 2026 01:05:27 +0000 Received: by outflank-mailman (input) for mailman id 1384041; Thu, 06 Aug 2026 01:05:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY1-0004gH-FC for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:05:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmY0-00Dmq5-SR for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:05:24 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73ddb4-e002-0a2a0a5209dd-0a2a4504b9fe-22 for ; Thu, 06 Aug 2026 03:05:24 +0200 Received: from [66.163.188.206] (helo=sonic311-25.consmr.mail.ne1.yahoo.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ddd3-b57f-0a2a45040019-42a3bcce86d4-3 for ; Thu, 06 Aug 2026 03:05:24 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Thu, 6 Aug 2026 01:05:22 +0000 Received: by hermes--production-bf1-54b5569bdc-xjdx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 734f0c8329adecc00a98ec91cc943adb; Thu, 06 Aug 2026 01:05:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785978322; bh=G3VmkipyMhZjj38uG/j4xipQ/TGQEWVZ1kywsdVeHas=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=sYh2bdc5USWGn/sFhSPBJe1EnhxZwUUrqvj6+oB/+JhLjRbMnVh3ubZYOYS5WoeKzb47Ne6IdsUr+VjRfAq1jQOMuqLmQDN5nDLtrS3DO/eKwtYyXyibDTdDvisZ0WRb8Xyyv7mON2D3Li4ATYkY5IfbFjubGkG5Q8wRdJ43aS7qp5mSvnjFRY+KskoQomSsIri5FNhgQghUnIYROeMM2Mp+/ugQzt/TlGlBgsHiTQW0emGg6+aqLt3B6JbGnfgVGTkmju/re4cvJSWOpM0gHj0RWDutE1O6iyiKsebTnLghagbWhAl7QvVLmwTJvQ9v7VbPNlDQAw5kkJhscqLP2w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785978323; bh=DZ9DSj/zpZJ3CsUxLDF6vIBJyRg0So43YHTPMQfuJzl=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=TAKI7iHY46DjDMy++WItmCEFlDeyjlPs21SUXO0aljNq/2YyX2/COoN7d0+2e2YIPHsw2g5FFMEDH8l75xCjHJgb9Z/zCGVy68wfROiuG3/OXveUYSM2rTBn6QuJbBvfbfUGrqG/CPsY/BTXWtGw9fLZo8E6jkplPHW0FQ/7IGtkun1/1F0v8dNNjgyaSbctYhseiz6/Ym9cvSgDT07oW+3x8V6fYm1QZgw3PE819oS91wLUcqMna8rCyrTiFd9ffPRd/rxP2ZVNE89g0NsWE+Dz1EPjkuSABRrLzTR2j1h+x9qoKRa6m+igpzNJ+TdBYfG/Wm7zvXUfNQbATfBUtQ== X-YMail-OSG: MK2xyiEVM1mskLxz7Nzv39526zcsIPBExeYJkJ6wwg4Pj7cCurKbGeeUSjkNAg5 Wg6SU9axyUHI.gGoWPw3yN.J9PfmYE42REwRg6sBTQzgu2NEa1PkSI71xSyPnmk6Nvx738HTf9w7 dUyDx9ZvQoqjsEhkQomCM9xunTW5RshlOICtH3y.dhV4Icz39Vgt4uuFdX4jbd2dnDqGj0vnxw31 TlDQbsVjdc2uC33HzYzumdCjHf0BFoMC3sqsIhMd8mXqY5Iwr6GWQ33QJRYFGCc_ClN2CK2e.FO5 CBNNHWiMSqA5X5lO5VbgbAP8WZJtuUgkDgULDS6VHqraDXhM.4F_Qq8OlcRGxUnGIiQB.RwIgR.m giAgfnSysr4GZdMwxhE4Sy.ylDeCtvO.Bxnjg_1KhYzUZLw53HJ4wEV.Xd4h.uulOl40wQFyugU7 TA4ye7aYvWJW3ybt4ACGEwzfLYTu6vIJJar1ABuktyaKu0YFlRQ3VNExJYRHwSfC8jER.KlXP2kK ehmQ0zkxeXl7FIjPY0KhhGRsAVDaLTFzu_w9iGLENNk.rSHaxJy92adtBp1DmMwXKC9vVe4BpTAw Pp.Ms2_WnYXp8G39Aio1cKvP4IZR7Nk3BlHkDfJ28sBOP1s4if.p3jmhLjnVQCh3htfQyhxtm56d EdLjfVqkyF3DyhD1K_KctZjXYVF_3Roq5AuxNkmJSEmoC.lVZnIm9GH_pMhF5tJSPMmqHLpyKcEs 30oX.OITe50tYOLvnf5Cd8rEf3tcoJCDeAYRUq80rinoSaaChYs1qZg6wCUxTqVQAQ_JRg6vBkq8 ghRpDSLtjLhRGvpV2Rr9GukwbQPjMJ2OzC2Vc5REMRcMAA8GjRazto24P0c6SBoJ.TGhTPeHW.ze .hB1FKxmTyyuesnANSBe2UFg3gi0gwgfho5OssocFgr2cHUdbsumdUsdvYoKvvWqltnG7yz3WBXM s5sgutRVx5S0pJdQ8NlhgkUnaR1JEmCXdd6xE20WSvfrs5xGjX9oX1GxQT60AU6exo2b_C4Lg.x3 oVo7No7MTuw2RM2oJYxuVxgqMa7i2FMmyuzFsA4CtFERiA.zmByC4ZNaPtwPibn9jttakKgmaymn CNhlbogFnNY7GNAulF_Mp0InKzXoTjVGPXLbjmSpoSn3R7pgowzThrHRLCVw3AArpKrZDxqbDk6p ULrXqTil2x5RJOOeeSqElUxMu.LX.Egf05mDG3yvnAT5eaD.pWpwkJIYELMQBQQ_TPY2TWGcPUzh Y0owemd.IPVo4aJ0kHg4gck8C.C1sXfOMYRpbzjYK3dQhv_Mam7aHTY.33orh6PSva82D1gbGr6X Ptw9wpn4IpM.H64I5A5G9jbVNkqzMcMSAkGOGGhHcY39hXJgxOt8MqLEbQZMF_QgJaaFiEZhvyMi bgBc.mnDx.2tz6LljKKrtvV.qDI1haWPf.9MD7gIwQu94tctzGm6QvJVgLl4CvVy4wtMwhC7OK46 y.9JsBpMNRxKaPFthdfwct_.pUYD0pNkk1jvObfQdPaelAVPthSq1d9DKeJlgQ8LQwQEOXAnOcaU 7ojhZAWihDIOhA1vEiTV3n9T4WYQBaTQPwT26YSYt4ocgp78AJOIhDgkJ3r_fEVZKPNwf1tHOHnC cTWqil54q1DiY36AFrqJed90uIiIK.TkwxCX9Ev91irKlcWsfLwH6iBCPPCVr4we99H1kHToEqeW MzO5pDyfaeNd83lNStHKneUBbBfFt5.c1N_h7CLeL26Q44apRYC5jk14fsryUIDrHO5Cnh6B9pvd jImYKbY2z3bPvVD3ZzHG5sj.616szDR88RkZ2jTgt_mtuCSu8mg07WC1gXAYIZARQvCpwbknHhUS MKMLYBKKDJU0U5zEoKPoOxtGF_dGkQD4gAF_5CjAp8K8Ptqhlnb4YTdsX.lxxHigF1LUD3p8L07R r6E6R_iUr5NBpacyKSJzYKXkoeeLfKbyMpCw4OJ0_4Fy.v3R1ADimO4uKo1ilUhtUTOcZ.WkRJV7 e4xuC9RwBAevbyvJM_8sESWSDgN4lRqcxBRwA3jjmqzUuod1onTzjLMlyh73OKpUJcSsYd8FiVMd yACclYtGNxBqeZWcHaMs80lwpWaE2QPMLnwEw4GhR.Rj_aKyatY2CLiyL.kpGePTCcT4yO8YGG0m 34C17PuwEmDDyXCxekBzXUchFB_QTyam7SK68sYCbjOmeoqJ2ZDwJg7aJmHV5 X-Sonic-MF: X-Sonic-ID: af215a46-7fce-4258-a2a7-e4fc20b5d1e5 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v5 4/6] xen/igd: enable guest creation when ROM read fails Date: Wed, 5 Aug 2026 21:04:54 -0400 Message-ID: <20260806010506.492490-5-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806010506.492490-1-brchuckz@aol.com> References: <20260806010506.492490-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 4888 X-purgate-ID: tlsNG-ebf023/1785978324-C04DBB50-D6FC651B/0/0 X-purgate-type: clean X-purgate-size: 4998 For newer IGD devices, the host option ROM is not readable from sysfs and this results in a call to error_fail() that causes Qemu to exit(1) so guest creation fails with the current implementation for many newer IGD devices. But this read failure need not be a fatal error causing guest creation to fail because the guest does not need the option ROM to successfully boot and run. The guest only needs the option ROM for getting graphics output from the guest during early boot before the guest OS loads the Intel IGD graphics drivers. To fix this, allow guest creation to continue by avoiding setting errp if the attempt to read the host ROM file from sysfs fails. In this case, the memory for the guest option ROM has been allocated so free that memory by calling object_unparent(OBJECT(&s->dev.rom)) before continuing. Replace the error_report() and error_printf() messages for this case when the option ROM cannot be read via sysfs with a suitable info_report() message. In the case when the host option ROM cannot be read via the sysfs interface, xen_pt_register_regions() will attempt to setup the option ROM for the guest the same way it would for any other Xen passthrough PCI device that has an option ROM. Signed-off-by: Chuck Zmudzinski --- Changes in v4: - v4 is the first version of the series that has this patch Changes in v5: - Shorten info_report message to resolve checkpatch line length warning This patch provides initial support for many newer Intel IGD devices so, at least, guest creation will not fail if such newer Intel IGD devices are passed through to a Xen HVM guest. But this patch alone is not sufficient for proper operation of the Intel IGD for many, if not all, of the newer Intel IGD devices when passed through to a Xen HVM guest. There are two main problems with more recent, modern devices: 1. The newer divices might require patches to the Intel OpRegion and also an extended video bios table (VBT). Without support for these aspects of the newer devices, the experience will not be great and in many cases the Intel IGD still will not function properly in the guest. 2. The newer devices only work with UEFI AFAICT, and the Ovmf* platforms provided by the upsream edk2 project do not provide support for the Intel IGD. It appears the problem is that the ekd2 project deems the fact that the hardware manufacturer does not provide the necessary firmware, the EFI graphics output protocol (GOP) driver, in the ordinary way by making the EFI GOP driver accessible in virtual environments via the option ROM of the real PCI device, to be a reason to reject patches that add support for the Intel IGD. This, however, is not a fatal problem since it only affects the guest during early boot when OVMF or the bootloader is running and the guest OS graphics drivers have not yet been loaded. Lack of support for the Intel IGD in OVMF does not seem to affect the experience negatively once the guest OS graphics drivers have been loaded. So efforts to address this problem are only important in cases when it is necessary to get graphics output from OVMF and/or the guest bootloader. The next two patches in this patchset address these two problems. Of those two patches, the first one is more necessary, and the second of those two patches is only needed to provide graphics output from the guest during early boot. hw/xen/xen_pt_graphics.c | 7 +++++++ hw/xen/xen_pt_load_rom.c | 5 +---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c index 0ae95cc..a124233 100644 --- a/hw/xen/xen_pt_graphics.c +++ b/hw/xen/xen_pt_graphics.c @@ -187,6 +187,13 @@ void xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev, return; } + /* Case when the host ROM file from sysfs could not be read */ + if (!bios_size) { + object_unparent(OBJECT(&s->dev.rom)); + bios = NULL; + return; + } + if (bios_size < sizeof(struct rom_header)) { error_setg(errp, "VGA: VBIOS image corrupt (too small)"); return; diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index 407b630..eaf0ae1 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -77,10 +77,7 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, memset(ptr, 0xff, dev->romsize); if (!fread(ptr, 1, st.st_size, fp)) { - error_report("pci-assign: Cannot read from host %s", rom_file); - error_printf("Device option ROM contents are probably invalid " - "(check dmesg).\nSkip option ROM probe with rombar=0, " - "or load from file with romfile=\n"); + info_report("pci-assign: Can't read Option ROM %s from host", rom_file); goto close_rom; } -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:05:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:05:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384043.1627165 (Exim 4.92) (envelope-from ) id 1wrmY6-0005aQ-3G; Thu, 06 Aug 2026 01:05:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384043.1627165; Thu, 06 Aug 2026 01:05:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY6-0005aH-0C; Thu, 06 Aug 2026 01:05:30 +0000 Received: by outflank-mailman (input) for mailman id 1384043; Thu, 06 Aug 2026 01:05:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmY4-0005Nq-MO for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:05:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmY4-00GWgj-3E for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:05:28 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73dda4-2eae-0a2a0a5409dd-0a2a45059c28-46 for ; Thu, 06 Aug 2026 03:05:28 +0200 Received: from [66.163.186.146] (helo=sonic302-20.consmr.mail.ne1.yahoo.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ddd6-4cb1-0a2a45050019-42a3ba928c39-3 for ; Thu, 06 Aug 2026 03:05:27 +0200 Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Thu, 6 Aug 2026 01:05:26 +0000 Received: by hermes--production-bf1-54b5569bdc-xjdx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 734f0c8329adecc00a98ec91cc943adb; Thu, 06 Aug 2026 01:05:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=a2048 header.d=aol.com header.i="@aol.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1785978326; bh=WVED5z9X3DhNfWYWPsssganxjMal/mDmQeJ0RW0UVpo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=ZocemVWyPNNRVCWp7tcTVgsj+okAl85RtnTc32+vJJ5sadpkFdJjGYhONhinL4v0zs+y+IwypGr20hAbhYz82xNsU+5MJVf7NWpB5o2LFRUZfsHpCu93egs1ixYs3kNRLbF6W/XJpFIgY5RMP4y+r0XOiixz1/MzjFYhn8+ovaC8s6o/6KDB8NIgdig7PcGQ7FRHRzp06DRAljcH2flA8PplF1h9GAGo0Hn5AtcDov9pSdGA82sL0FvnWrXVL1/13gYiNN04kw3IL9UmqxeHQIiAoOVwU/yRrGiyfxnGxxDxyaw4P7K7SVDzEJXVLtM8g7aPR0p627Fzr11HxMQZCg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1785978326; bh=7iBAhNNuxjWjoR7/fE95Vs5pQIIIvyJSx7pSZDa7+RG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=RNdXb/80spp6ENsUBxZI+42NUmGBdhNVnseX9RZtUI1LW2pzFeivMyNFP6yqM9RPGJ1/z6T/MCYOys8zdj5q9OyVwlpE0llOzSxclN62i+7AsrDqWaGxsLepTvuro9CuKjR0Tk4AXTut5OdGuwsoa7Ee8zqMICWW05o3BtGHirls/P+hzqk9yAOC19chNdfvrYuvMhnPUyKpr401hCLoSvaiLeJJjpKEIuj9+WC0wsJHe2bsscZtiy/eXR7NljIp2rbY1kLkSowLF7EsbeDS9JXSg2Q7MVY4Wsf0ka8tOzGEwm7TbUWtU6+9hh49QcvOR+DFaHdrFxxqINC2INxnxQ== X-YMail-OSG: Bt9JW_UVM1lR7EDyBjBA4WITfblYAyVeX6sJfDcmO2E6TQejB0h7rMfn06k5CMk ePEHp0_1iFs3i4ESLe02aQZo6cc_EbOXlyVBMIOMSSWcZM2zSvHENUIru3gS5CRGqBBSd3.iZc2w whauvyh.OKTC26zl5Gcp13d1FeER4Ftf7qGC4PpsYV7MXAPiOYQS2jcGesa_xLvzfkvYggDcJ2rg bcLAJQhNHUa5g0B.YnoK29i_Qzko2SxW62S2_dk53np1yaifCh5Ig3i1rxQvkZ8uSRjcO3LFC7sL HOC6t_HjSQ4dNlUZA1bTrtSJhOAa2MEZDnt5vO9dMKWvM4jT0o2QsPEk_lLWiAzs8aWoKwrUeUiU XVbpI08AuJo28209ycuW8wrdi7hhy_rwEZFxSX4YyVG8lhhoMdjAObKBlsAA8hRxyqgOf8tjMA7O G5q9rv0_W2HJP151u6fvHOE49T4Unmv0mW_c0rqLFaayslmq1yHdq.biUChcDgkw98XXL62d0Apz 2QF2.Pj_BSXWnLfUf.ok74zDZRuKDNaN.fTsFSlNQUWS8o7HiVBQD8Qj24XVjdFya_sqwrToDdOl Vk2Ly4STBXtMniRBxhDlVMcjkJbnmL1xMrQ9NBe31z.TrdUonhLd4HECLA.GUjwpVtp4oZv1Z8nC xkd3wXf9gGVdEDjJwQiSSbpp4mthgPFgvxIftnJwHhGjepewYjo4ne3tzUfflkx7xkmp80dhfKqy 4NJrzbw2JlHaNmOY1W..oceP5arvKi7CfSb57feAZ9aPA3ZHSZn6o7rtU3pQfeAoG8K5LtmyPRs3 _uPU4_E0suz0Yf1iq.Wg7x56A6cgtp9BpVRZF88qBGG8_XmNp_9Vaiu8sQcVYYqGK1.KadvCmFmR LUnfNL9KqUx_0REFtwJaV4WPWEd.1lmrb72pmQ6.5jjF3U5BCVHrjpqoJZAvqTvfEwCMPgBjaSiG VC5hK5kGcff7SfWcrMzfb8zW04Mc7Z72O3t3pYyU_L66Xp1mYvYuUlG.sh1kj6tSjAHASZiCMPvz 6zpeqEKcp1OFQ5ExRUzN.GpQYEX8N5Rcu_pNjLis03ZFSafJp6_NWUI4GeBWvGBq1pBC.HS0WgXX zhezKvPUaFNpeT9jh1QQwiqooi8kY2lMxReIg5SxSamLG5FmctKmfG9BPizGeFwNBZTN16JLjSPp tpZ0afekS9_09yjLXSSiNwcX8SQhKYl0ZG5176fA4HdZRhALbaN7GuimYglTpPAoXfysHu6YeKKt JEGGbJVQp4gsB5daHu5YJfAn6NFNkV7MsxXvs.6cT64cI2SXkVEzLx8oCLEzB65MCsrlBMsPgoHP nD2JR5xNQTgKIfniy20WZBz7IZmJr10A_R0kNYhbGqyOvnPYZuReA3tC3hohLmjr2VsI4.hlW5No hoU.iaE8.0Ni4rC88p29TUS5rnlC469QdQAtsb0uKqA2yMRIA4.ajIirQZRLQ6TU2OQm11x5UyJY f6huFuXm6eSBRlvVTfsagdnxWoo6ICAUVzGIQzp45MI2U41eNyGJ8RUnFU5qiU42tL9NI5i3xdTz 0L6be12TygPAfgiIDblB4zvby0K6SP_DBkP_RmkmotWWAEi2Ts3XrpYk8u1pekRTS33Bm.ko06wd soDlY9sAQYIEieX.7JU0cATWifWoLfcJS5O7EionM0m85RzoodGGZdlAKx7_8biI.GZJCL_qFmHj plIxPmwToxiPaOxC1tZ1wDUlJRwpUxEQ3kkrJkWCLjwhFEJ0CLdD7lvKXhHdQ_fMF1P2ZTSfrdvL qyPsuj0x.CDQMpggTsnfgKNdnGaMjqPWMGLJCuFnWvcK84UFfdJOJT89pALzbqDdU3bM6h_znBgU JXN0M6drr7GLt.aHUL7sCuD1snJEkznEzqEwFOUTmzYGzigQ9sizb6J3vuvCcyeQwETN9oMCw3J8 3sZb.j4j0Lhe63EN.L8FqFTdJtbMYm7EFH1Rq4kev0eC_vDQzQptA_72ml7g_gLXkF4FVVC0aYdR 73ulu5L7rRI.cn.q32eadpWxNvEi2VcMu7Q1d7mkEzn1q6b1rTob_1u52jDUxNmi8uoF.O5gG82h eQGgOQSK06ah8lTI6xYjO_2wE0uFrLinYUth33L8ND6Ey.Jx_lEtT7dEaBfPnXmpsEZBuoQU0FMW gpnwNHzWh1jiQaldlp5KQ6oRpSxjwYRqnlIzF.TZXQhXmOsIkECPQWnght4nZB2H1HMhJeeGrpcy 60bgAaiL64O0UuyZHGa8cfiYNBIOkhahnYCGd X-Sonic-MF: X-Sonic-ID: 1c24a953-a693-4bad-a4c9-6097629114f1 From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , "Edgar E . Iglesias" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Tomita Moeko Subject: [PATCH v5 6/6] xen/igd: use custom option ROM if provided Date: Wed, 5 Aug 2026 21:04:56 -0400 Message-ID: <20260806010506.492490-7-brchuckz@aol.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806010506.492490-1-brchuckz@aol.com> References: <20260806010506.492490-1-brchuckz@aol.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 8876 X-purgate-ID: tlsNG-c201ff/1785978328-F4AA72A1-E2944F08/0/0 X-purgate-type: clean X-purgate-size: 9089 Since in some cases the option ROM is not readable from sysfs on the host, provide the option to use a custom option ROM file instead that, for example, could be extracted from BIOS or UEFI firmware and modified as needed for use with a particular Intel IGD device. The file must be named "igd.rom" and be located in a directory configured at build time as a Qemu firmware directory and its size should be a power of two, and it must be compatible with the particular Intel IGD device being passed through. If provided, the "igd.rom" file will be used as the option ROM instead of the option ROM file epxosed in the host sysfs. If no "igd.rom" file is provided, this patch has no effect. Signed-off-by: Chuck Zmudzinski --- Changes in v4: - v4 is the first version of the series that has this patch Changes in v5: - Fix wrong whitespace in three places in a conditional block Sorry for the length of these notes but there are many things to say about this patch that are not obvious to persons without some experience of actually trying to use the option ROM of an Intel IGD when it is passed through to a Xen HVM guest. This patch is primarily for providing a way to add Intel IGD support for the OvmfXen platform to get graphics output during early boot from modern Intel IGD devices that are only compatible with UEFI for graphics output during early boot. Note this patch is not necessary for successful operation of the Intel IGD in the guest once the guest OS drivers have loaded. It is only needed as part of the patchset necessary to provide graphics output from the Intel IGD in the guest during early boot when using newer devices that are only compatible with UEFI for graphics output during early boot. Most older devices that are compatible with legacy VGA BIOS will work with Seabios without this patch, but they will need Patch 3 of this patchset to work with Seabios. Some notes on adding Intel IGD support for the OvmfXen platform: It is necessary to provide an EFI graphics output protocol (GOP) driver to the guest to get output from the Intel IGD before the guest OS loads the graphics drivers when the guest uses UEFI. This GOP driver is essentially the replacement of the VBIOS driver that applied to older devices that use legacy bios, as described here: https://www.intel.com/content/www/us/en/support/articles/000005749/graphics.html Unfortunately, with modern Intel IGD devices, the EFI GOP driver is not provided to the guest in the usual way of providing firmware for a PCI device in the option ROM of the real PCI device. So I included this patch in this patchset to provide a way to expose the EFI GOP driver to the guest. I was able to extract the GOP driver for my device using the UEFI bios update file from the motherboard manufacturer and the UEFITool available here: https://github.com/longsoft/uefitool That EFI driver can be wrapped into an option ROM using the EfiRom bin wrapper that is part of the edk2 project: https://github.com/tianocore/edk2/blob/master/BaseTools/BinWrappers/PosixLike/EfiRom I tried setting the 'romfile' member of the PCIDevice struct that is used by KVM/VFIO Qemu devices and emulated Qemu PCI devices, but that did not work with Xen PCI passthrough devices. Neither Seabios nor the OvmfXen platform could detect the option ROM in the guest with that method of exposing an option ROM to the guest. So I implemented this approach of substituting the 'rom' file exposed by sysfs with an administrator-provided file instead of using 'romfile'. In the commit message I mentioned the size of the rom file "should" be a power of two. I mentioned this because the code in pci.c that handles the 'romfile' setting for PCI devices enforces this requirement strictly on the romfile that Qemu emulated or VFIO devices use. However, I do not know for sure whether or not the rom file is strictly required to have a size of a power of two, so that is why I say it should be a power of two. In my testing, I zero pad the "igd.rom" file so it has a size of a power of two. I will accept the suggestions of experts on this question about the appropriate size of the option ROM file (I am not such an expert!). As mentioned in the message accompanying Patch 4 of this patchset, the official edk2 project does not provide support for the Intel IGD, but some OVMF patches for Intel IGD support are available online for KVM/VFIO guests, such as at the links below (they apply to the OvmfPkgX64 platform): https://github.com/cmd2001/build-edk2-gvtd https://eci.intel.com/docs/3.3/components/kvm-hypervisor.html#build-ovmf-fd-for-kvm https://github.com/LongQT-sea/intel-igpu-passthru With such patches it is reported that the passed through Intel IGD device lights up the display during early boot from OVMF and the guest bootloader in KVM/VFIO guests provided that the administrator provides the correct ROM file via the 'romfile' setting for the passed thorugh Intel iGD device and applies appropriate patches to the OvmfPkgX64 platform. It should also be possible to add Intel IGD support for the OvmfXen platform also but I have not seen any such patches online for OvmfXen and if anyone knows of such patches online I would be interested to be informed about them. I am also working on my own patches to add Intel IGD support to the OvmfXen platform, in private for now. If anyone is interested, I can make the work I have done so far toward this goal avalable online. hw/xen/xen_pt_load_rom.c | 47 +++++++++++++++++++++++++++------------- 1 file changed, 32 insertions(+), 15 deletions(-) diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index eaf0ae1..6c2aa8f 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -2,6 +2,7 @@ * This is splited from hw/i386/kvm/pci-assign.c */ #include "qemu/osdep.h" +#include "qemu/datadir.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "hw/pci/pci.h" @@ -13,9 +14,9 @@ * need to be modified. * * For such cases, use this function to get a pointer to the option ROM - * from sysfs. Caller has the responsibility to edit the option ROM as - * needed, call pci_register_bar to register the modified option ROM, - * and set has_rom to true for the PCI device. + * from a user provided romfile or sysfs. Caller has the responsibility + * to edit the option ROM as needed, call pci_register_bar to register + * the modified option ROM, and set has_rom to true for the PCI device. * * This function must be called before xen_pt_register_regions is called * because if xen_pt_register_regions is called first, it will register @@ -32,17 +33,27 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, struct stat st; void *ptr = NULL; Object *owner = OBJECT(dev); + g_autofree const char *fname = g_strdup("igd.rom"); + g_autofree const char *path = qemu_find_file(QEMU_FILE_TYPE_BIOS, fname); + bool sysfs = false; /* If loading ROM from file, pci handles it */ if (dev->romfile || !dev->rom_bar) { return NULL; } - snprintf(rom_file, sizeof(rom_file), - "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/rom", - domain, bus, slot, function); + if (path) { + snprintf(rom_file, sizeof(rom_file), "%s", path); + XEN_PT_LOG(dev, "Using Intel IGD romfile %s " + "(administratior provided)\n", path); + } else { + snprintf(rom_file, sizeof(rom_file), + "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/rom", + domain, bus, slot, function); + sysfs = true; + XEN_PT_LOG(dev, "Using Intel IGD romfile from host sysfs\n"); + } - /* Write "1" to the ROM file to enable it */ fp = fopen(rom_file, "r+"); if (fp == NULL) { if (errno != ENOENT) { @@ -55,10 +66,14 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, goto close_rom; } - val = 1; - if (fwrite(&val, 1, 1, fp) != 1) { - goto close_rom; + /* Write "1" to the ROM file to enable it if using ROM from sysfs */ + if (sysfs) { + val = 1; + if (fwrite(&val, 1, 1, fp) != 1) { + goto close_rom; + } } + fseek(fp, 0, SEEK_SET); if (dev->romsize != UINT_MAX) { @@ -83,11 +98,13 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, *size = st.st_size; close_rom: - /* Write "0" to disable ROM */ - fseek(fp, 0, SEEK_SET); - val = 0; - if (!fwrite(&val, 1, 1, fp)) { - XEN_PT_WARN(dev, "%s\n", "Failed to disable pci-sysfs rom file"); + /* Write "0" to disable ROM if using ROM from sysfs */ + if (sysfs) { + fseek(fp, 0, SEEK_SET); + val = 0; + if (!fwrite(&val, 1, 1, fp)) { + XEN_PT_WARN(dev, "%s\n", "Failed to disable pci-sysfs rom file"); + } } fclose(fp); -- 2.52.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:10:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:10:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384090.1627173 (Exim 4.92) (envelope-from ) id 1wrmck-0001CR-JY; Thu, 06 Aug 2026 01:10:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384090.1627173; Thu, 06 Aug 2026 01:10:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmck-0001CK-Gs; Thu, 06 Aug 2026 01:10:18 +0000 Received: by outflank-mailman (input) for mailman id 1384090; Thu, 06 Aug 2026 01:10:17 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmcj-0001CE-BP for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:10:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmci-008fJr-OZ for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:10:16 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73dee9-5cb7-0a2a0a5109dd-0a2a45068b46-6 for ; Thu, 06 Aug 2026 03:10:16 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73def6-195a-0a2a45060019-888fbc3352a0-3 for ; Thu, 06 Aug 2026 03:10:16 +0200 Received: by mx.zohomail.com with SMTPS id 17859786036791003.8173726789206; Wed, 5 Aug 2026 18:10:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785978606; cv=none; d=zohomail.com; s=zohoarc; b=BYDW82AB/c6PR6jHqfSPrXv/7tEAm9cd12rZVgegiYkRmLIT0aBa1eO7gHXtLY35eMuIwVkcGWTnQI9h6/c4lt8RGqEYxIROGdnNy7uzaXrw6iOO6SQY7rv2NZx2BKLDZuA4Nx+ajjZ19MFyWdsxeehjiegCV4dFRBYG3rwOpy0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785978606; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=WOVbCK6Sw64aXSe6a9720k6wPznzFto4aLH7lBPPGaE=; b=G1h2+wvyuBFGDSqU3NFu70bhzWaA3apVhXiJy6s+IK8aW1Dg/4Xd0sNFfbDX4nDJ8DNWDMX8FB6OKefUVh4IXYTIL74r6S/7tgFKdLt+9uqf6KZoatjMNox32KjlBFM2szcG1OjlZTJ6JnUI8BeqAWxafHqgPflBFxtRHFi2MOA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785978606; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WOVbCK6Sw64aXSe6a9720k6wPznzFto4aLH7lBPPGaE=; b=kU8l+lv9qZwRtUSAnywyH4J+Xja9pVCid2XnELAjlt055ur/UI7lL/rhTDUOy1Yw WuZVN5Idu77RjDNusz56yCmiy2UKyP+jBudAd6wy2BLGAwxTd2oIW34jmuo85dY2yAJ DQov7Dxr71EfGc+jOcy6wheAWcqkNJsDGi66idAw= Message-ID: Date: Wed, 5 Aug 2026 21:10:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/24] XSM: fold xsm_{,un}map_domain_pirq() hooks To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-16d1c6/1785978616-F520877B-2D071E36/0/0 X-purgate-type: clean X-purgate-size: 3101 On 7/28/26 9:23 AM, Jan Beulich wrote: > Like other resource management hooks they are different in just "add > resource" vs "remove resource". Hence like in other cases a single hook > can easily serve both purposes. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -109,7 +109,7 @@ int physdev_map_pirq(struct domain *d, i > return physdev_hvm_map_pirq(d, type, index, pirq_p); > } > > - ret = xsm_map_domain_pirq(XSM_DM_PRIV, d); > + ret = xsm_map_domain_pirq(XSM_DM_PRIV, d, true); > if ( ret ) > return ret; > > @@ -142,7 +142,7 @@ int physdev_unmap_pirq(struct domain *d, > int ret = 0; > > if ( d != current->domain || !is_hvm_domain(d) || !has_pirq(d) ) > - ret = xsm_unmap_domain_pirq(XSM_DM_PRIV, d); > + ret = xsm_map_domain_pirq(XSM_DM_PRIV, d, false); > if ( ret ) > return ret; > > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -461,14 +461,7 @@ static XSM_INLINE char *xsm_show_irq_sid > #ifdef CONFIG_HAS_PIRQ > static XSM_INLINE int xsm_map_domain_pirq( > - XSM_DEFAULT_ARG struct domain *d) > -{ > - XSM_ASSERT_ACTION(XSM_DM_PRIV); > - return xsm_default_action(action, current->domain, d); > -} > - > -static XSM_INLINE int xsm_unmap_domain_pirq( > - XSM_DEFAULT_ARG struct domain *d) > + XSM_DEFAULT_ARG struct domain *d, bool allow) > { > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -68,8 +68,7 @@ XSM_HOOK(int, kexec) > XSM_HOOK(int, schedop_shutdown, struct domain *, struct domain *) > > #ifdef CONFIG_HAS_PIRQ > -XSM_HOOK(int, map_domain_pirq, struct domain *) > -XSM_HOOK(int, unmap_domain_pirq, struct domain *) > +XSM_HOOK(int, map_domain_pirq, struct domain *, bool) > #endif > > XSM_HOOK(int, map_domain_irq, struct domain *, int, const void *) > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1022,14 +1022,9 @@ static char *cf_check flask_show_irq_sid > > #ifdef CONFIG_HAS_PIRQ > > -static int cf_check flask_map_domain_pirq(struct domain *d) > +static int cf_check flask_map_domain_pirq(struct domain *d, bool access) > { > - return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD); > -} > - > -static int cf_check flask_unmap_domain_pirq(struct domain *d) > -{ > - return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE); > + return current_has_perm(d, SECCLASS_RESOURCE, resource_to_perm(access)); > } > > #endif /* CONFIG_HAS_PIRQ */ > I am not opposed to collapsing the calls as long as the semantic is not lost, which I feel the reuse of the xsm_map_domain_pirq does looses it much less provides an opportunity for confusion. Something like xsm_domain_pirq(..., access) makes more semantic sense to me, as it would read, grant domain pirq access T/F. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 06 01:17:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 01:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384099.1627183 (Exim 4.92) (envelope-from ) id 1wrmjD-0001v2-BU; Thu, 06 Aug 2026 01:16:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384099.1627183; Thu, 06 Aug 2026 01:16:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmjD-0001uv-82; Thu, 06 Aug 2026 01:16:59 +0000 Received: by outflank-mailman (input) for mailman id 1384099; Thu, 06 Aug 2026 01:16:58 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrmjB-0001ul-Uv for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 01:16:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrmjA-00Do4S-Sw for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:16:56 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73e07b-2eae-0a2a0a5409dd-0a2a450983c2-12 for ; Thu, 06 Aug 2026 03:16:56 +0200 Received: from [136.143.188.51] (helo=sender4-of-o51.zoho.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73e087-be1a-0a2a45090019-888fbc3352a8-3 for ; Thu, 06 Aug 2026 03:16:56 +0200 Received: by mx.zohomail.com with SMTPS id 1785979003559740.7769617646599; Wed, 5 Aug 2026 18:16:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=zoho header.d=apertussolutions.com header.i="dpsmith@apertussolutions.com" header.h="Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To:Content-Type:Content-Transfer-Encoding" ARC-Seal: i=1; a=rsa-sha256; t=1785979007; cv=none; d=zohomail.com; s=zohoarc; b=R8gJm8Zm80GT4sAWpV5I+3zGT3kpCqyLu81aDqKdnfcXoGKuUQhIC7cOURejOCEdBteqjSpgMb+cBSP09G6p+2fdHMOcWL6ZDJ1h0FEbbZuHlhf7A0dKQCY9JB6wkvOG5CSpKKo/RCCb/blk+Icuy+9waBUzfLuMU7e3ipfTEEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785979007; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=V3/EhLMHE8sXOMAwNruXoiI8Fv5KpArkvZMGohzfTcI=; b=OHqb1uJF0Ed8BDeOMVq0srEpg3z/97mferUtYLBY2/HqA1LtXUyNpjv8W19ShVk/TaBpdSxGSkxUGgzvYytUhcaLOZHoLukGdecVa1f/ilLn4Y4CIBQ3xpoZaLPLLKv1BsYgUiJkODcfv+IWQZrTyhdgxwom0b3+2B9nF4VCkr0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785979007; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=V3/EhLMHE8sXOMAwNruXoiI8Fv5KpArkvZMGohzfTcI=; b=jSXjrsSsS/6dm8pqDxEP9JVXaG7q3bgisy2QlyMEMnMczZ7dlGAXGWo56aLzW6Hw 10bCJaH8Px3ezNxfHgwwGk5/MwULedB3Ogr2m6kau1jyeb8yY0gqLbwoL1dw9lULdtt N9zqGkrk0uvtZq5vhAD2kekK0hVPnpk6X84j7YAE= Message-ID: Date: Wed, 5 Aug 2026 21:16:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 22/24] XSM: pass just SBDF to xsm_{,un}map_domain_irq() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-purgate-ID: tlsNG-bad1c0/1785979016-BECDF034-D62AB649/0/0 X-purgate-type: clean X-purgate-size: 5386 On 7/28/26 9:25 AM, Jan Beulich wrote: > That's what Flask needs, and by unifying the hooks flask_map_domain_msi() > can then also serve both flask_{,un}map_domain_irq(). > > Signed-off-by: Jan Beulich > --- > How come Arm doesn't use xsm_unmap_domain_irq()? > I do not know, perhaps a gap in completeness. I would have to go study it to see if there was something more to it. > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -2214,7 +2214,7 @@ int map_domain_pirq( > return 0; > } > > - ret = xsm_map_domain_irq(XSM_HOOK, d, irq, msi); > + ret = xsm_map_domain_irq(XSM_HOOK, d, irq, msi ? &msi->sbdf : NULL); > if ( ret ) > { > dprintk(XENLOG_G_ERR, "dom%d: could not permit access to irq %d mapping to pirq %d\n", > @@ -2442,7 +2442,7 @@ int unmap_domain_pirq(struct domain *d, > */ > if ( !d->is_dying ) > ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq, > - msi_desc ? msi_desc->dev : NULL); > + msi_desc ? &msi_desc->dev->sbdf : NULL); > > if ( ret ) > goto done; > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -470,7 +470,7 @@ static XSM_INLINE int xsm_map_domain_pir > #endif /* CONFIG_HAS_PIRQ */ > > static XSM_INLINE int xsm_map_domain_irq( > - XSM_DEFAULT_ARG struct domain *d, int irq, const void *data) > + XSM_DEFAULT_ARG struct domain *d, int irq, const pci_sbdf_t *sbdf) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > @@ -491,7 +491,7 @@ static XSM_INLINE int xsm_unbind_pt_irq( > } > > static XSM_INLINE int xsm_unmap_domain_irq( > - XSM_DEFAULT_ARG struct domain *d, int irq, const void *data) > + XSM_DEFAULT_ARG struct domain *d, int irq, const pci_sbdf_t *sbdf) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, current->domain, d); > --- a/xen/include/xsm/hooks.h > +++ b/xen/include/xsm/hooks.h > @@ -71,8 +71,8 @@ XSM_HOOK(int, schedop_shutdown, struct d > XSM_HOOK(int, map_domain_pirq, struct domain *, bool) > #endif > > -XSM_HOOK(int, map_domain_irq, struct domain *, int, const void *) > -XSM_HOOK(int, unmap_domain_irq, struct domain *, int, const void *) > +XSM_HOOK(int, map_domain_irq, struct domain *, int, const pci_sbdf_t *) > +XSM_HOOK(int, unmap_domain_irq, struct domain *, int, const pci_sbdf_t *) > XSM_HOOK(int, bind_pt_irq, struct domain *, struct xen_domctl_bind_pt_irq *) > XSM_HOOK(int, unbind_pt_irq, struct domain *, struct xen_domctl_bind_pt_irq *) > > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1030,17 +1030,14 @@ static int cf_check flask_map_domain_pir > #endif /* CONFIG_HAS_PIRQ */ > > static int flask_map_domain_msi ( > - struct domain *d, int irq, const void *data, uint32_t *sid, > + struct domain *d, int irq, pci_sbdf_t sbdf, uint32_t *sid, > struct avc_audit_data *ad) > { > #ifdef CONFIG_HAS_PCI_MSI > - const struct msi_info *msi = data; > - uint32_t machine_bdf = msi->sbdf.sbdf; > - > AVC_AUDIT_DATA_INIT(ad, DEV); > - ad->device = machine_bdf; > + ad->device = sbdf.sbdf; > > - return security_device_sid(machine_bdf, sid); > + return security_device_sid(sbdf.sbdf, sid); > #else > return -EINVAL; > #endif > @@ -1066,15 +1063,15 @@ static uint32_t flask_iommu_resource_use > } > > static int cf_check flask_map_domain_irq( > - struct domain *d, int irq, const void *data) > + struct domain *d, int irq, const pci_sbdf_t *sbdf) > { > uint32_t sid, dsid; > int rc = -EPERM; > struct avc_audit_data ad; > uint32_t dperm = flask_iommu_resource_use_perm(d); > > - if ( irq >= nr_static_irqs && data ) > - rc = flask_map_domain_msi(d, irq, data, &sid, &ad); > + if ( irq >= nr_static_irqs && sbdf ) > + rc = flask_map_domain_msi(d, irq, *sbdf, &sid, &ad); > else > rc = get_irq_sid(irq, &sid, &ad); > > @@ -1091,32 +1088,15 @@ static int cf_check flask_map_domain_irq > return rc; > } > > -static int flask_unmap_domain_msi ( > - struct domain *d, int irq, const void *data, uint32_t *sid, > - struct avc_audit_data *ad) > -{ > -#ifdef CONFIG_HAS_PCI_MSI > - const struct pci_dev *pdev = data; > - uint32_t machine_bdf = (pdev->seg << 16) | (pdev->bus << 8) | pdev->devfn; > - > - AVC_AUDIT_DATA_INIT(ad, DEV); > - ad->device = machine_bdf; > - > - return security_device_sid(machine_bdf, sid); > -#else > - return -EINVAL; > -#endif > -} > - > static int cf_check flask_unmap_domain_irq( > - struct domain *d, int irq, const void *data) > + struct domain *d, int irq, const pci_sbdf_t *sbdf) > { > uint32_t sid; > int rc = -EPERM; > struct avc_audit_data ad; > > - if ( irq >= nr_static_irqs && data ) > - rc = flask_unmap_domain_msi(d, irq, data, &sid, &ad); > + if ( irq >= nr_static_irqs && sbdf ) > + rc = flask_map_domain_msi(d, irq, *sbdf, &sid, &ad); > else > rc = get_irq_sid(irq, &sid, &ad); > > Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Thu Aug 06 02:15:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 02:15:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384119.1627192 (Exim 4.92) (envelope-from ) id 1wrndE-0007bD-Bb; Thu, 06 Aug 2026 02:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384119.1627192; Thu, 06 Aug 2026 02:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrndE-0007b6-8l; Thu, 06 Aug 2026 02:14:52 +0000 Received: by outflank-mailman (input) for mailman id 1384119; Thu, 06 Aug 2026 02:14:50 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrndC-0007az-D4 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 02:14:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrndB-005SbK-QK for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 04:14:49 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73ed9f-2eae-0a2a0a5409dd-0a2a4508c090-42 for ; Thu, 06 Aug 2026 04:14:49 +0200 Received: from [40.93.201.62] (helo=CY3PR05CU001.outbound.protection.outlook.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ee17-f659-0a2a45080019-285dc93e5ab0-3 for ; Thu, 06 Aug 2026 04:14:49 +0200 Received: from BN1PR14CA0030.namprd14.prod.outlook.com (2603:10b6:408:e3::35) by CY8PR12MB7708.namprd12.prod.outlook.com (2603:10b6:930:87::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Thu, 6 Aug 2026 02:14:43 +0000 Received: from BN3PEPF0000B077.namprd04.prod.outlook.com (2603:10b6:408:e3:cafe::8f) by BN1PR14CA0030.outlook.office365.com (2603:10b6:408:e3::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.20 via Frontend Transport; Thu, 6 Aug 2026 02:14:42 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B077.mail.protection.outlook.com (10.167.243.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 02:14:42 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 21:14:42 -0500 Received: from [172.19.79.34] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 5 Aug 2026 21:14:41 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DO/bjLARzlv+5rkIBW7/wS8kN6Cmo/cKvRD1iwfO3MAqqWIdOqoGY+Cmnpk3Pmv5Fx/2VP8ScxF+t1CNPgh60krhudF7xydnya0a+lTyhbZtVMjaPNw9P3AlKKwlrcOLjToKurEZZs6uMK9f2VK/GnxLabF8DvyYXxYYM7W3z4QXluQLV0bPrS3VX0dAoXCX78/2TQKP9CuKQsQGH1/ZBV84duwFkZUX30bMAusR3C/lbzqeX8NkvNPUlc2Lbw3KnIiX1oxTzFnLnfz1K0j8X+C0IboSmLOpCo0IzN2pTvYTAT06Gs6aRLYH1IvWSv5UoovMB8PYblrRNUuxKWXwlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0P6fp9yfApqMGT/Drm+Sfrk8wWNTPqAvXMP5hletWlQ=; b=zL4/G5PcNin02TnDsfhULQvRftXDPHo5b5+aGnquY2aKI7ijB5f2MEs9cRiQh/1LyO5oX2I7lUmyVtf0tMA+OcKrwUSHGUUxZ4pKef69ZL1mjaFumxAi1Yts29nz3bHEVrTB7qB/zL8O2J1DWbY8bcxmNC1FOIRDO1nx+pwGJOzHVpABaY+39mp1Y3+t0pacoBycCJTlPSlzEVP2qUdypRBilI5gx4zpcwajRrFN4mq7Y0vm0JTTdlIvG0hUL+5V9E+CzxE/J01vqViAky4B8cuvQ/XHzFsjophVZlmgdalN5OS1Qfs3APX25tUP98M7ER1EX1xw5u/VgSqw4oZjyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0P6fp9yfApqMGT/Drm+Sfrk8wWNTPqAvXMP5hletWlQ=; b=4zo/WxPdPif9OwB8yQNv2lX4oohJQ2IluQSjTOTpAskU9119aed3JP+LCj9lstlvXKBCu42yEsbA/uPtsKr2Ay9peG8818g7sv3N0v4ZHrHSxvzC4mS7TihorSHDvrUfzbg5bY/pSdHKR0IMdRUQYh7o5UNpeXJtvgaZ+Sh3Hv0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Message-ID: Date: Wed, 5 Aug 2026 21:51:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] xen: Drop CONFIG_XEN_PVHVM To: Juergen Gross , Andrew Cooper , , CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Oleksandr Tyshchenko , References: <20260805082137.1214967-1-jgross@suse.com> <20260805082137.1214967-3-jgross@suse.com> <7179e004-76df-42be-94fd-f314614e65cd@citrix.com> <15824536-dff6-426d-b54c-6a1f362adaa2@suse.com> Content-Language: en-US From: Jason Andryuk In-Reply-To: <15824536-dff6-426d-b54c-6a1f362adaa2@suse.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B077:EE_|CY8PR12MB7708:EE_ X-MS-Office365-Filtering-Correlation-Id: 117afe2a-f8f9-4b26-fe0c-08def3607a3c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|82310400026|36860700016|1800799024|18002099003|22082099003|4143699003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: cDep0RmGVdJ+FSUDwi9N56Qf9kpKG3n/heqNoO25ONzqSllnxpGK23rJIZnNr4ZfyUS6Mn+wJOrn+hVMCshsCgYY7yeBcf+MQtAmcYTBziJPZfTQBIXTv52PvWsLm1FYaVZv50PeFo748gXXIIvRy/WnDFJAQsMAWU+m8WmZsIqc5uMtm7Tkc4OyVLL6S5zy00jg4ZVNtzWpZnk8V28FGAJhLcEuuLHn12f7YAdYegEWu1BxW7DTHK/tHLtIAKQ+peoWeK1qyXzUC9+zu6dIF8qCT/3xQqR9F1rVp2dY0QdYHMpHNb+U+LkbZshhPbvl7wdLuSCoKgO9+36gIlOuhC8wosvSgqAdPonjPQOJdNcHiULpOjVEMIdSQrGlQD3nlpCGyOIx+n7W5lEVEXzVPTOUzx0cUw87MIOg/5e09ICiAI571sdjsd50/kMghOzL5aXfKKh/OR5m1+iRXaDUjg197ZZIwUwW+OOomwcyM6tYS3A5CTEpZykZQmsqAVksL3n3Hxkavz6PnwW1im9vAdinH4+HO5FVCCX5eJui4FyGB48vPipTFRxFIwPGuonWX10isQHZs7Ju4GKzVRRT4zWeguCOqDwb4gbQ58rWgt/WSJ1UQ2ohxqlLurcwvFPdjESUO67p+66icKmYkrw4sVwGn/Z/wKTwXPUnTL17JYKQVFVGyzVtnK4iJlj6fk77wNkhQAOByFmn/BsiFJnH4Q== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(82310400026)(36860700016)(1800799024)(18002099003)(22082099003)(4143699003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xv+R/7yqZcLhE13Vq5fJu6lI/PUV0ZrbwRUN3fsGyVgHHPPr28PVk3tfIO/AK+uUlExFxHVBmJc+DtrVA2lkZeb4RFLP32314BcaPX3YbYmU6AA1AW5ieBLbzxW7EbsWCbiBWjo9Ul/vbZFWT1KWbQXehjZVb7yo6nj3gOAgRN1m4wmdlrqdwz+uMf5mzyveFSVJuX4FtguRLRqViS+PTJ4M8rTcBePhyIerZeM4V4T4iEmAf5dIV30iplNR7CmpNL0ETPHMh/5SC1ppzRkpJrYiyiUwi+lDpTSsGoRmloLfvzXB5sjfg7MzT8z0IlOXhp/ite4nFCxEIBIRz9A575rOUAiGKWxzyy4aAv/gVfoVL66vWFhp2QYdUKIyHjQhwguoNSDxeMQBo7pq6+a1e+MJ6wl4jPQ9fZFDmGs6rtHM0+3EADBW7lHgqqFinMmZ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 02:14:42.5971 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 117afe2a-f8f9-4b26-fe0c-08def3607a3c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B077.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7708 X-purgate-ID: tlsNG-c1860d/1785982489-CD74B87B-81BC9252/0/0 X-purgate-type: clean X-purgate-size: 1899 On 2026-08-05 04:36, Juergen Gross wrote: > On 05.08.26 10:28, Andrew Cooper wrote: >> On 05/08/2026 9:21 am, Juergen Gross wrote: >>> On x86 CONFIG_XEN_PVHVM is now a synonym of CONFIG_XEN. >>> >>> In Xen specific x86 code it can be just dropped, in non-Xen specific >>> x86 code it can be replaced with CONFIG_XEN. >>> >>> In architecture independent code it is used only where CONFIG_XEN is >>> defined, so it can be replaced with CONFIG_X86 there. >>> >>> Signed-off-by: Juergen Gross >>> >>> diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/ >>> idtentry.h >>> index 20f548702404..f400cfac69a6 100644 >>> --- a/arch/x86/include/asm/idtentry.h >>> +++ b/arch/x86/include/asm/idtentry.h >>> @@ -745,7 +745,7 @@ >>> DECLARE_IDTENTRY_SYSVEC(HYPERV_STIMER0_VECTOR, >>> sysvec_hyperv_stimer0); >>>   DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, >>> sysvec_acrn_hv_callback); >>>   #endif >>> -#ifdef CONFIG_XEN_PVHVM >>> +#ifdef CONFIG_XEN >>>   DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR, >>> sysvec_xen_hvm_callback); >>>   #endif >> >> I'm very happy to see a reduction in the number of Kconfig symbols for >> Xen (there are definitely too many), but this looks wonky. >> >> Or are you saying that there really is no way to build a Xen PV guest >> excluding the HVM-only bits? > > Seems so, yes. > > This has been like this for at least several years now. > > What you can do is to configure the kernel to exclude the Xen platform PCI > device (CONFIG_XEN_PVHVM_GUEST=n). I think I caused this inadvertently in 34aff14580d1 ("xen: Remove Xen PVH/PVHVM dependency on PCI") CONFIG_XEN_PVHVM should just be bool, and then XEN_PVH & XEN_PVHVM_GUEST can select it. Then it can be disabled for a PV only build. I'll send it out, so you can evaluate it. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu Aug 06 02:15:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 02:15:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384126.1627200 (Exim 4.92) (envelope-from ) id 1wrneH-00082A-Ko; Thu, 06 Aug 2026 02:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384126.1627200; Thu, 06 Aug 2026 02:15:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrneH-000823-IB; Thu, 06 Aug 2026 02:15:57 +0000 Received: by outflank-mailman (input) for mailman id 1384126; Thu, 06 Aug 2026 02:15:56 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrneG-00081o-CG for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 02:15:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrneF-006DJx-PG for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 04:15:55 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73ee22-bab6-0a2a0a5309dd-0a2a4508dc6e-44 for ; Thu, 06 Aug 2026 04:15:55 +0200 Received: from [52.101.53.63] (helo=BL0PR03CU003.outbound.protection.outlook.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ee5a-f659-0a2a45080019-3465353f0e4b-3 for ; Thu, 06 Aug 2026 04:15:55 +0200 Received: from MW4PR02CA0005.namprd02.prod.outlook.com (2603:10b6:303:16d::14) by SN7PR12MB6690.namprd12.prod.outlook.com (2603:10b6:806:272::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.17; Thu, 6 Aug 2026 02:15:46 +0000 Received: from SJ1PEPF000026C6.namprd04.prod.outlook.com (2603:10b6:303:16d:cafe::84) by MW4PR02CA0005.outlook.office365.com (2603:10b6:303:16d::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.19 via Frontend Transport; Thu, 6 Aug 2026 02:15:45 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF000026C6.mail.protection.outlook.com (10.167.244.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 02:15:45 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 21:15:45 -0500 Received: from fedora.mshome.net (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 5 Aug 2026 21:15:44 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ff7yCzeY2fiHOc+IDfZLIZuZVKwJyf4/hOzKyCR2UQeatP51RAUY/ypm3DwF0TlWqQdD0ybB2M+cnwf5+qqXqCmWl6OqeQPPDNo/ZHum41SK5TmkbBNeZqNNx4ao8z5cdBIzLTcMLt08oVynO3mvYn5HVu+KBbqMpOhEYSOnmw8jvojfvwyrXgqtHDI3qp/UpGqmoW3TIsRZQyYTJn29a1RvHeQ4mB2zb02w0Wvdf5AsINHcEiDwQiWO9wwvAT7yV0WlaBhfutAbnUFNRQ4kun3i/KALe6vGZfWXmdmYvBGxDomz5pVZ0zp20Yw5B+r+Wg4YiOJNorRKQjy9hSl29Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jX3bNwYFJtQHkDdoGtRpfMniKOM+GB0LphuiU0WB4hM=; b=PwLefr11JQpo56ryxxt9ZBgkoc6Wl5IzsNprJcdi20RHKqUuyo+k4cUUGRi3x1t25hGIIYz738whTx9K9dwzRe53O04oYMBt1nueP4a9KZoSokjjq2g9apR2APpldTJXq/NCk8Li+/ZT7Mps0Z5nrF0tTGW71vXDAhG/p44Yo3q6DYZkvKia8Vf300hovDhDDWyBWjTiJGJbkBJP9AyazCiMqON4vL3OLhfldYIFbzmTxoiQDqmy8cXrfq7UStCXIgrYldiryvkAE1n5NJ2MiaXed+JUnRI1z3fYzU1cfZCHnHaZcU7WdEX5w6bwBNJtYHAMrfLRmlkbtBFot9+1Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jX3bNwYFJtQHkDdoGtRpfMniKOM+GB0LphuiU0WB4hM=; b=iQn37Xgmzdm9FPhOiG2k1AohDPyRFVVAdw/Uzs1/rdMIl7x4LdLFO555q+ZiQZK8sCaEHBg4GDlTZczHSUFlt/qBJoeyP2rO//j0FnKd6ltpopaO1Sjyx015HqqpPZBnge7Mz9j8rtLGTTEdK4JflGndDRYSVkZz/f5GcYEqYTs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Jason Andryuk To: Stefano Stabellini , Juergen Gross , Oleksandr Tyshchenko , Boris Ostrovsky , Jane Malalane , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" CC: Andrew Cooper , Jason Andryuk , , Subject: [PATCH 0/2] xen: Fix PV-only build Date: Wed, 5 Aug 2026 21:52:29 -0400 Message-ID: <20260806015233.202486-1-jason.andryuk@amd.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C6:EE_|SN7PR12MB6690:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c36e370-57f2-458d-3902-08def3609ff6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|36860700016|7416014|376014|18002099003|11063799006|10067099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: Ibu/xr63siR0DF2AA2xQ7uGE3BrBlvSyupte6c0UjYGWkSstrwf6VPeBJrlGl9H9NV7C+/pXI7IvJeNxYIir7USqwVF7zkzT8J8TRuVHULCHv13udPolIeqkfHloRYw6CpMKWWu4rXYZ/S3gb7U9ZS/MhS6ajIoe/VDZxEt3ZsFMP6SX++0paaBLETZwu19H/5SOoduriVrcEirKU7ocWCEzzojq8lB3vd+q64nyyCeZuWzyIP6rejeoR+WY7IStt0swXVaGxPmV/g3SFRg2y4jo6rmwc/3PNdcs9SR4nnx6TrTAvkLFNoR58YMu1xUrLR1GKKJy89oZPyEa4LDk7LuQdvebE3ARdR9oQQZNcaC/8jnU1aXmoIQX9S4pILKJzcT25BSKIWKWaFWE/RJ93icXM4RSNRFCkkarIq370DHjUkWkQykx1nLF/6yonZw6+vchn4ZaHNAqvSt7BVnCwp9ekGHegODCwluWE8ef8atadUlqGHpYqyE9M2DhSDHrNlcEN3ZaxFsg3yQ0x/F3d38iFgxVdbb0vXZa6wxttrLz5Pvdlnx3jJj0tAMTbt/L+kuoPOM4cWsS2VJ4T9/5ZEM9njEjCtB5U9rggygdt611KT7MqVGGHnta7IPjUo4/Q09J6PqfENdiMn2Nlf60xXNMUNK9lG10SkK7ebk7HnyCgCgmuRs4Z1rjmky/1AQvIM3DekMdxcbd/3obACpQuUWTt1hWgqIH2/yLIgTPQsPV5uOw+4vXs7qGmPExbnDb X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(36860700016)(7416014)(376014)(18002099003)(11063799006)(10067099003)(56012099006)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Gk16PvomKptKGYo4kWQuqvF5e49bpUhBp4YmMi5zxirbK1zzsBtaU9htBbhOwoTVjnfdol8iZq/cDdZP/A5DlF9FL6XlosNdFYW2p1moE3FfiXgQmRkhsLamyJ8oHobNrBN0viciJs+al8wvU+KArssVM87frf0mA3hAM9rTGAKUS7szBO9cyvHchg7jV0MVzTHL5vWujab3VCcOq2XfTWJt1iMxSDMorN7Wh6vFt2zVuPlp1CKr1FSUqGHr6ymBhrviBM8efbjjbRDSAzmYpX5hjJ2s1IKs2XKRL4i6JxB1+diJ5kWa6yIpE5vyEJsYQipbaRQShdmCL+EWOF0GaVGx8nO/vCOBacRRPcLLPZoGRWxi2KeriIP9x0WbWHYnWpnxXvu/NRojDchgBKRhmqrtir2l2FQXKpTvJEDcsBQsfJhNltEAnDGbOTXf121b X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 02:15:45.8046 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c36e370-57f2-458d-3902-08def3609ff6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C6.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6690 X-purgate-ID: tlsNG-c1860d/1785982555-CEB4187B-A1B31A69/0/0 X-purgate-type: clean X-purgate-size: 363 Allow disabling XEN_PVHVM for a PV-only. A stub in the event channel code needs to be fixed first. Jason Andryuk (2): xen/events: Fix xen_set_upcall_vector stub xen/Kconfig: select XEN_PVHVM arch/x86/xen/Kconfig | 8 +++++--- drivers/xen/events/events_base.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 02:15:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 02:15:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384127.1627210 (Exim 4.92) (envelope-from ) id 1wrneI-0008F2-Sp; Thu, 06 Aug 2026 02:15:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384127.1627210; Thu, 06 Aug 2026 02:15:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrneI-0008Ev-Ot; Thu, 06 Aug 2026 02:15:58 +0000 Received: by outflank-mailman (input) for mailman id 1384127; Thu, 06 Aug 2026 02:15:58 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrneI-000822-3J for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 02:15:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrneG-00GdGF-WF for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 04:15:57 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73ee52-5cb7-0a2a0a5109dd-0a2a4505ebc2-2 for ; Thu, 06 Aug 2026 04:15:56 +0200 Received: from [40.107.208.28] (helo=PH0PR06CU001.outbound.protection.outlook.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ee5a-4cb1-0a2a45050019-286bd01c69af-3 for ; Thu, 06 Aug 2026 04:15:56 +0200 Received: from SJ0PR03CA0345.namprd03.prod.outlook.com (2603:10b6:a03:39c::20) by CY8PR12MB7099.namprd12.prod.outlook.com (2603:10b6:930:61::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 02:15:51 +0000 Received: from SJ1PEPF000026C9.namprd04.prod.outlook.com (2603:10b6:a03:39c:cafe::8d) by SJ0PR03CA0345.outlook.office365.com (2603:10b6:a03:39c::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.19 via Frontend Transport; Thu, 6 Aug 2026 02:15:51 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF000026C9.mail.protection.outlook.com (10.167.244.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Thu, 6 Aug 2026 02:15:51 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 21:15:50 -0500 Received: from fedora.mshome.net (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 5 Aug 2026 21:15:48 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xdo5L35LXODd09otAaJlr+S+QtR0J72oZRMdNbQdDuDizhVzbujhnl0H8/kAhYbT3RyEzipFdT38oEwZA5G9BylqSh/HQkoA9zarHkJJoO8v6v1A5cdYwNb0BepxmIQJbFnbDhH/WoR/XoQXUKvHCgxH8JI0JPnkJ45UMjoUqJB8TI0pCwyyesUPricqPqpLl4GN4C8Uk0kZFBEta3xVptQls+jddGyHhHt0RssKRaMGqGkt9aRNTzPzgDaqWVS4ZojxGmfPPRP+1rXcFoqEVuOeNwk1ZCzCNnPFlN6aK100iuTJ26cRXAKqsLLZ88IbmMWVBDcjw/KBY76fDSup7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXAvQeolZboNEWTS4fZrLvWfW/st6wbkjRYk4ih4T68=; b=QxV8HxKd4NbZjW/gd1JgFD60eTICMpYstSXbzZpr9eYvXP1gvpTi0CYnUL/ena2thrZ5i74C2m5KwE4KnUTxLkjpmQnkWI7wMITxhWJnFW2UdQ60K/W0aMUqq7MaVYNHQk7TDZ969fLZZdDN08CTexCO7L82w8UbZNh5b5hlnzVDPNVeHxLd6T5V3pek9A9JzxNJFJm3zPOeWr9KEwL/3YsO46SbNtNG2w6Y8kvaqR1AoRgb9HyJH0IXIVZh0LcxcqKU8uBTyv782gglVpF1tdg5m+dILId0Rwvp9jfucSa0cxC3oga5bIVu7ODySeG174FDalpXVBHz3D16P+xdfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXAvQeolZboNEWTS4fZrLvWfW/st6wbkjRYk4ih4T68=; b=pqryTsKuQaSM60OUjRqZR+vZ6Cj/CbqsgcGWs5tTeMFvDsYqVWlxLPzaTO1Ysq07c8h9sIK7v3xEFs//FnjJP548g7WRvZCc38u35KTctMWtY0sg0MjFiMvK1UdA8yix5B5edq7smNLcRlpsJ5q9pfNwKXROp2WAIXIqbkVKUc8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Jason Andryuk To: Stefano Stabellini , Juergen Gross , Oleksandr Tyshchenko , Boris Ostrovsky , Jane Malalane CC: Andrew Cooper , Jason Andryuk , , Subject: [PATCH 1/2] xen/events: Fix xen_set_upcall_vector stub Date: Wed, 5 Aug 2026 21:52:30 -0400 Message-ID: <20260806015233.202486-2-jason.andryuk@amd.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260806015233.202486-1-jason.andryuk@amd.com> References: <20260806015233.202486-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C9:EE_|CY8PR12MB7099:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d62d85c-85e0-4988-5a79-08def360a32f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|23010399003|11063799006|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: g+6irZcPPMyS5Z+fpScCudS5BQHP0IvueDRiFeFmCcr7kMfd77p/dz/COJ9n0EAEYE+zNspkroz6u+Cln13AHl1XhtODFA9yD1DlsEUU76VUuEXG5F8kkU9TRTzL0N6sISXpVwhNhJMdvYEHXOqAmd7m6A0UEiReomyNyz11XGHJ+pfLQr4kour9Aexqy/d2NOhWsPYCQ5+MUs5k4PW4f2GJmwddn9BswEyNZ8suCpl+NnOZzndFE4pzjwGvK5s3cujMj1+KtuHKi5cKmD80O6z2KPGNtGuKnZwpof61anHWH5CrTjYk219+iNDcEAyVSHfArQvv72zBBIYnmK1x7RcSQxxStG23LOBCCU57u6XSdzHaTmPz1hSrFPdMs9xGAotF6H+IqcUpTF+4sI8Z1Nr/diEc40nBDQqzfYkTkYvCUMHJ3v0h2TBfoqsr5jaeF5qhxWE/iMH3xTB31h5Q1OOSif6hpzoUCoTWP/j0FebzocZfsfXC+9OPqrHNnL5X2MDucvqPGwiam0BVQSDptNLY0jI3ME7mV8EkRhgsYHzjOAejf0/JdZq8+diGTr8BUyHNmzq6+goBlgN1sU1eP/JPYbZGAn3cyzISPXneYgMn1yiT230SfHD4eQVAOhxNq5UOrmL6/gCEex0MuqdZ6aTDC7FbNG1POE73QkWTPjzvNJSNuvcIIdOw5tRzBKkVs+xLPOOaFKm0XD/mS4fOMw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(23010399003)(11063799006)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ukc4V5iWWvD3oEDitPOUcApowXWrjpelPreuhinvzvw/Tx144JsAG0B486Vw74JwbOrzhI3m0AvWdSWxI0BnU94uMkMXg/5hUKffn/1pPFXJvBI05g8PShZQayE7U5UN/e6xHUFBCPd+8Dx4QFN9CH9XGUjhb9SEAFWq1rzG1GflsM8kb9CAZsSvFPrRb0caBj1gMRMJnalgxjQGR5xvMmUE05qHXASVF+FZgrLRz487XDCO3DrxG6d+Ny1cwz2yGHEH8upTLs908DNsnJiqU8Y7GR0p2vzQSFHkW5n8qnw32xk+UbcbLxKFvZQtRe/+gHf++VvYcQcXqhfSFtTdXyz3Kl/9YsTkrrNsHirNKNKRK3Fn4KMLuZaeJe/2C+O4tYZcCLLZxKMqGYSMSdBd1RhBlENiqCmAzsq0RJUvbQMda5rH85jrNVfODMxicd11 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 02:15:51.2124 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d62d85c-85e0-4988-5a79-08def360a32f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C9.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7099 X-purgate-ID: tlsNG-c201ff/1785982556-F6EB12A1-C7B14472/0/0 X-purgate-type: clean X-purgate-size: 1100 Building the xen_set_upcall_vector stub fails with error: control reaches end of non-void function. Return -EINVAL, which matches the hypercall's return for a non-HVM domain. This is needed to allow disabling CONFIG_XEN_PVHVM. Fixes: b1c3497e604d ("x86/xen: Add support for HVMOP_set_evtchn_upcall_vector") Signed-off-by: Jason Andryuk --- drivers/xen/events/events_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 6ea945508a89..3a5ae96e73cc 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -2245,7 +2245,7 @@ static __init void xen_alloc_callback_vector(void) #else void xen_setup_callback_vector(void) {} static inline void xen_init_setup_upcall_vector(void) {} -int xen_set_upcall_vector(unsigned int cpu) {} +int xen_set_upcall_vector(unsigned int cpu) { return -EINVAL; } static inline void xen_alloc_callback_vector(void) {} #endif /* CONFIG_XEN_PVHVM */ #endif /* CONFIG_X86 */ -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 02:16:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 02:16:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384131.1627220 (Exim 4.92) (envelope-from ) id 1wrneZ-0000Ge-8G; Thu, 06 Aug 2026 02:16:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384131.1627220; Thu, 06 Aug 2026 02:16:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrneZ-0000GU-3B; Thu, 06 Aug 2026 02:16:15 +0000 Received: by outflank-mailman (input) for mailman id 1384131; Thu, 06 Aug 2026 02:16:13 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrneX-0000Cx-JJ for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 02:16:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrneX-002APw-0D for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 04:16:13 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73ee4e-e002-0a2a0a5209dd-0a2a450ae860-14 for ; Thu, 06 Aug 2026 04:16:12 +0200 Received: from [52.101.85.64] (helo=BYAPR05CU005.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73ee6b-f2d2-0a2a450a0019-346555403318-3 for ; Thu, 06 Aug 2026 04:16:12 +0200 Received: from SJ0PR13CA0007.namprd13.prod.outlook.com (2603:10b6:a03:2c0::12) by MW4PR12MB6682.namprd12.prod.outlook.com (2603:10b6:303:1e3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 02:16:07 +0000 Received: from SJ1PEPF000026C4.namprd04.prod.outlook.com (2603:10b6:a03:2c0:cafe::40) by SJ0PR13CA0007.outlook.office365.com (2603:10b6:a03:2c0::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.7 via Frontend Transport; Thu, 6 Aug 2026 02:16:07 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF000026C4.mail.protection.outlook.com (10.167.244.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 02:16:07 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 21:15:53 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 21:15:53 -0500 Received: from fedora.mshome.net (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 5 Aug 2026 21:15:52 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kP+MY6reK9n+KgKtWgmIMQZFyiR3h066PE7t6+Fe2swwZB8ezOIBimzxayv3BIjEk5nUFzFjDh+o86IcqFXggVHnWLPXnnVCGe3oBKq/Iq8Iv3rR33Yba1ALCyvARUf4dAOrdY1x9vxmr6h9xnmcYFU7JKJe881l8Sgrknun7M5bbTX9D5IM/A6gvEzmcYfQgEjxnL/sayyKrFHvBfiqXs2Dla1/sIN0VWQ05IYI6hxf60i/blHF7Gt0zDfrYc1Ieo04y7wd8VTWOCHYJ/LfaDxvJMGVyvlVuTl/Ln4SpCnKNaDYJTh39pcaJJ6bep9tPx92n/o4B09IeO3ec9w9AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Xv0fA6/T7b3pIp+x7N+NA8yd+wXonHAePsFkZrVh0g=; b=QE2czA3MCUIEEfhUuWXe+4pCXBOaYFWuGcQB17Jdo/cTarpLrleY4VyVuGSj/w03pFWvtW35RJzAKLUnpUNGFxGAfh2wWmHYk4WHCbtnod565l5v4ARTBy40nsqJb6w6/qRHjiEj53a/+6GvfziuZgswHP3ufgHvhtWsWQR3Ob9Z0xD1evA3INFnTTW12Xde03QfxehfXcsqLQIQScHKeUxyph3mniVB14afhNcpfWsF3IVPwpvGGtDaLJ0mmcuwoFWI3YtDP0bvHQyd4zodbZ+D4wfi/T40Fq8obgBgYf5qlDtyTtVMV9DLbQvhTf4+Qv1DP9GAs04bhi/DJZ9l5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Xv0fA6/T7b3pIp+x7N+NA8yd+wXonHAePsFkZrVh0g=; b=QghUWubbjkvkU7KV6Da/m6iZVyH63MMkbZQ8B08xHsIm5Bb2NTK4ZwvsiDJlP5BYgxyA1PKymM12we2rrNQAxLsIWRrtpPcHp0p5aUSOuermjDarMrdeUAH1RB+rGIkfK9LQinZ7MlF8fCMV2tw7qH7ZHyA2hWZXoe6oUdQCCDM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C From: Jason Andryuk To: Stefano Stabellini , Juergen Gross , Boris Ostrovsky , "Thomas Gleixner" , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Jason Andryuk CC: Andrew Cooper , Jason Andryuk , , Subject: [PATCH 2/2] xen/Kconfig: select XEN_PVHVM Date: Wed, 5 Aug 2026 21:52:31 -0400 Message-ID: <20260806015233.202486-3-jason.andryuk@amd.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260806015233.202486-1-jason.andryuk@amd.com> References: <20260806015233.202486-1-jason.andryuk@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C4:EE_|MW4PR12MB6682:EE_ X-MS-Office365-Filtering-Correlation-Id: e7772e28-c9bc-4c2f-3f60-08def360acaf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|36860700016|82310400026|1800799024|921020|10067099003|5023799004|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: D3wvuUBQx835/K8ljV1ZOJgk+n0ph5OZ7/i5Esc+m4zOOoPoz2+p47cW//cRKeo/1Ylc5HA6tlckc+myPS7BM6cOu831kbSlTbx6EjWHfX0CFbUfw2gLbjtxKexaZKrpKP6RmwY8x1Mm0hxn6VQxdik+Ftv0VSopo/I+5oUTqW/um17UARbCd9tS99SoIVxLgIpefsHikvSpLZy2c2vbX8Eb91Pyon3U/egkg418he5fI+j/yTblvcf+MDA16vurBXEEkU6wd60jiCgBa1Xve5aywp7Ol9UnYPJXOR4GlV/dJYbE9nXbIpc8YTZ7KVs7YyXfvU9bG5PgfhPTe08bx1Wk3EsCqMJrZniPQnEmPT4PZz9qWkAigZ4AIkdfbuVYFtAe/MjZzZygXGxl6kJMA1nzdMf7OBP1ktMD3CCv/cVoMD/B5IfAAAFtJbp1HAlMm7YDqrB8KAcnkTcyq+LEWVqcL0KbMdqg6kyTECwzrhJ0tni4SoBsR7eRu9NQUaOPyrjOgymtc5zIEC10r/5NJUClAybb1EnwDIPBY+AJe8Ni3o5WgyEGiTMzgYHeDU6EUp3IbPntnpjp9A39q9l9obMB05EQ/x5KalkF21+3oPJetEWC5jsjHfRvjNxPIxf+r+ZEh+ASKyeQsLAFEMdYIsWvsTFoqkMR8j58+Ni/fGvo+VhdsBOZjn6uaX1sfPQiFcxrITk8zpZ2NeTbo/eQnDluDqZdXQ7k2YAp910IBOM5thxOPUrIJLjDOi+fDhVe X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(36860700016)(82310400026)(1800799024)(921020)(10067099003)(5023799004)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zdoew5idMZ/uCpHJb08mf+fDQOsptiovS67Kpj5VeFBDnq4MZZPhWbKlSq/lxHM0vTjtej5OIE19nZDywcEd/SyfRLsOuLxcCdiNBJcTqFGMhdByvqxFrWjBuhk3QJoc1FhrXVSHvdVRAug2qGUmD5ou1hM8SIHg9e8oI3w/n9mAIzD2CjSmzQcA1oYd92xlagpRuoHfI2g8ipAlnOjT80PIpgNtdi/bF92CJn6D5gAViLO7bWwlOjIdeL1xP6hvJGgkmMW5xyKp0EPmzLVDRNsHf4KyumwklL+qqVPL1zWU5Qn5aqBa6aPiGavKK5SOajwSsO9ITbEuOr3LCHhWdMbqXQhcCUczIFM0e9PjgsE+cLK1FXLaT9gW1URcvpkHZkgQiouwwwTXjAMiXFyF7KJCdeHCb5pYDraV6oiirJ7ZJrKZcAkM0eQB2dx7/zdz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 02:16:07.1414 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7772e28-c9bc-4c2f-3f60-08def360acaf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C4.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6682 X-purgate-ID: tlsNG-4011c0/1785982572-4AEDACFC-8E30C4D5/0/0 X-purgate-type: clean X-purgate-size: 1241 XEN_PVHVM cannot be disabled as it is a hidden variable with def_bool y. Switch XEN_PVHVM to a plain bool, and make XEN_PVH and XEN_PVHVM_GUEST select it. It will be pulled in as needed, and drop the code from PV-only builds. Fixes: 34aff14580d1 ("xen: Remove Xen PVH/PVHVM dependency on PCI") Signed-off-by: Jason Andryuk --- arch/x86/xen/Kconfig | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 99b06f5c47cd..7bdaa28ff232 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -51,7 +51,7 @@ config XEN_PV_DOM0 depends on XEN_PV && XEN_DOM0 config XEN_PVHVM - def_bool y + bool depends on XEN && X86_LOCAL_APIC config XEN_PVHVM_SMP @@ -61,13 +61,15 @@ config XEN_PVHVM_SMP config XEN_PVHVM_GUEST bool "Xen PVHVM guest support" default y - depends on XEN_PVHVM && PCI + depends on XEN && PCI + select XEN_PVHVM help Support running as a Xen PVHVM guest. config XEN_PVH bool "Xen PVH guest support" - depends on XEN && XEN_PVHVM && ACPI + depends on XEN && ACPI + select XEN_PVHVM select PVH help Support for running as a Xen PVH guest. -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 05:12:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 05:12:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384160.1627227 (Exim 4.92) (envelope-from ) id 1wrqP8-0004CW-7W; Thu, 06 Aug 2026 05:12:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384160.1627227; Thu, 06 Aug 2026 05:12:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrqP8-0004CP-4t; Thu, 06 Aug 2026 05:12:30 +0000 Received: by outflank-mailman (input) for mailman id 1384160; Thu, 06 Aug 2026 03:17:43 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wroc3-0005Wp-Gj for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 03:17:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wroc2-006J3Y-Gc for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 05:17:42 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a73fcb9-bab6-0a2a0a5309dd-0a2a4508b712-12 for ; Thu, 06 Aug 2026 05:17:42 +0200 Received: from [160.101.131.8] (helo=na1pdmzitismtp01.tibco.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a73fcd5-f659-0a2a45080019-a06583088c6e-3 for ; Thu, 06 Aug 2026 05:17:42 +0200 Received: from eddie6.eng.citrite.net (unknown [10.113.40.46]) by na1pdmzitismtp01.tibco.com (Postfix) with ESMTP id EE706448DDE0; Wed, 5 Aug 2026 23:16:02 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; none From: Chunjie Zhu To: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jason Andryuk , Teddy Astie Cc: Chunjie Zhu , xen-devel@lists.xenproject.org Subject: [PATCH] x86/svm: mandatory update VMCB nextrip for soft interrupts Date: Thu, 6 Aug 2026 03:17:24 +0000 Message-ID: <20260806031732.10242-1-chunjie.zhu@citrix.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785986262-DFAD487B-04C0ABD2/0/0 X-purgate-type: clean X-purgate-size: 1068 Signed-off-by: Chunjie Zhu --- xen/arch/x86/hvm/svm/nestedsvm.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index b06124c2c9ed..815713b8b506 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -449,7 +449,14 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) n2vmcb->virt_ext.bytes = n1vmcb->virt_ext.bytes | ns_vmcb->virt_ext.bytes; - /* NextRIP - only evaluated on #VMEXIT. */ + /* next_rip is consumed on VMRUN as the return address pushed on the + * stack·for·injected·soft·exceptions/interrupts. This assignment + * statement must be enforced, otherwise, it might cause vcpu wedge. + * + * APM Vol.2 Event Injection does not specifies what happens if NEXTRIP + * holds an invalid/garbage value. + */ + n2vmcb->nextrip = ns_vmcb->nextrip; /* * VMCB Save State Area -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 06:14:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 06:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384219.1627237 (Exim 4.92) (envelope-from ) id 1wrrMs-0001GA-Gs; Thu, 06 Aug 2026 06:14:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384219.1627237; Thu, 06 Aug 2026 06:14:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrrMs-0001G3-Du; Thu, 06 Aug 2026 06:14:14 +0000 Received: by outflank-mailman (input) for mailman id 1384219; Thu, 06 Aug 2026 06:14:13 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrrMr-0001Fx-AV for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 06:14:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrrMq-005t37-3W for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:14:12 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74262b-e002-0a2a0a5209dd-0a2a450890fe-24 for ; Thu, 06 Aug 2026 08:14:11 +0200 Received: from [209.85.128.43] (helo=mail-wm1-f43.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a742633-f659-0a2a45080019-d155802bb831-3 for ; Thu, 06 Aug 2026 08:14:11 +0200 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so20017235e9.2 for ; Wed, 05 Aug 2026 23:14:11 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff79a7302sm3526880f8f.1.2026.08.05.23.14.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 23:14:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785996851; x=1786601651; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q3NsvjRiIBbs/lup0KuOeVPgWmqzORz6pTEhOcQJm1U=; b=G3Wz+skJIpa2GoqTT/D6h5xTGwjn65+Q0WakCCHDw0aPeeIki2FnB80Ifd/qIUoE6S t3q4vS1zPtZMFshQNhi1U64N4oJcG65zW/hjcZV1UMx2gXygZzvsW/Nhq7qruJEMZm/3 BpUMn9NYLqB/GSTzBmomYCdYMFKISYbv8dLpA4iIj/T/eDkvCJVGbKCAKAi0aG/eXXNy jKM4yC3YmJeGnw55H4W81XwJd6XUC36CBtNQTnLdzBM5cQIr+DUtNVRvrSlYaVtT+vFy I4IFuDgkjbc/HJ8wPanwyFDZFGBIV+ooHfrGm3kHk137sNnREr4m8weCN4PM8Hx8Rwck CwcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785996851; x=1786601651; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q3NsvjRiIBbs/lup0KuOeVPgWmqzORz6pTEhOcQJm1U=; b=Y/XZ3Cc36NG6Qrdh7V2VQfjQ9+87l393oQbPqZiBzT5oFSYrgxpt8X6OLoJCi7UE9s iyXt005NVHxJOvHR08QFjkB4hi3Z8C9KZHzMfZ3R65Qsnk2KcBxsNXsCrt+NrVDfGKzS vxnzUCx3F76wMlfWSWWds/y+jqJVYgzaeSGXDCcAMLinaJB40EvAqwggBvuimexHw2yz 0oDiIcPVgbruAxyZo/QmXSowAWoAh3u5KpoBAz0sAnW/pRFB+CRSYFB+KoBUaf0R3VgC XWMwBWnO1SlM1kstMStOM1EctlL/oroAq3Ey+/67C8rLX36wtwfIBNizw56gD4ue2AYB n/Fg== X-Gm-Message-State: AOJu0YzL5B0LQFHT+OQ59BzsqWIUMFdCmsoSPYni05utBIvLVkxH8931 uSSPiGyTrGnsr4vMX0ccaGjvGwfnD18suHqBjWlIl5ttBISNpZ2qo8Jeh8CWI1OsHQ== X-Gm-Gg: AR+sD136Jcq8MC+hNYGgGfh9f6YiSqV+xfXm4pDQDQ4zTEEdi/t26RpQlUC/uuBnDEs IRfgfQxCrX3hEyFR/HtcQEAmblELY9ED+NgX2AuM/Un/O2C6ez1RDFtxiCARNzJqP8lHaSB2u9D 6ppluiGOfSr3NCuiIIy9bjhkOMWc5w8aGa3uOcpR3Sj2f9f0X4g11fBYj3/kQON0k/PHv7kCfRY ciazOVB4aWtDf8sQLnbRewuDvDUU9V7JPutsUuBDE8nyIcj7xGiPrufLSvAmyOz/cDXeaqC2YaV CXkmcgL9LB0yqoqrF+1sHbbCb7QHhGgvm2wBRR572ypRZQxPZa0uU85vU0h8IPrQRMkLpcpEZd+ tXlDgXsvzMKEKxWJH5ynj5MYKDjf6/J7EoV2jdtB9nU70ICVM8g8lHBagEyIXI9YBuYuR+43Ksp B+WbKRQ2QU1MnuKrJ1KwJRxE3d99f6G3hmMdZ+713Edq2MpmdtXvXJR2qGkQntLCiDH8lkiP2c1 8zCpLE3ArRZmVq10xx1ve+kDeAT5KQJBh9NPR1MKlqqTFjAOJxA X-Received: by 2002:a05:600c:8b75:b0:495:4fd4:619b with SMTP id 5b1f17b1804b1-4994e70a6eamr191952195e9.1.1785996851313; Wed, 05 Aug 2026 23:14:11 -0700 (PDT) Message-ID: <27d57a69-360d-4247-a5c2-0fa2c3482b13@suse.com> Date: Thu, 6 Aug 2026 08:14:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/svm: mandatory update VMCB nextrip for soft interrupts To: Chunjie Zhu Cc: xen-devel@lists.xenproject.org, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jason Andryuk , Teddy Astie References: <20260806031732.10242-1-chunjie.zhu@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260806031732.10242-1-chunjie.zhu@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1785996851-CC77387B-61A32AC0/0/0 X-purgate-type: clean X-purgate-size: 1367 On 06.08.2026 05:17, Chunjie Zhu wrote: > Signed-off-by: Chunjie Zhu > --- > xen/arch/x86/hvm/svm/nestedsvm.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) Several (formal) issues: First, please adhere to patch submission guidelines: To: the list, with maintainers Cc:-ed. > --- a/xen/arch/x86/hvm/svm/nestedsvm.c > +++ b/xen/arch/x86/hvm/svm/nestedsvm.c > @@ -449,7 +449,14 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) > n2vmcb->virt_ext.bytes = > n1vmcb->virt_ext.bytes | ns_vmcb->virt_ext.bytes; > > - /* NextRIP - only evaluated on #VMEXIT. */ > + /* next_rip is consumed on VMRUN as the return address pushed on the > + * stack·for·injected·soft·exceptions/interrupts. This assignment > + * statement must be enforced, otherwise, it might cause vcpu wedge. > + * > + * APM Vol.2 Event Injection does not specifies what happens if NEXTRIP > + * holds an invalid/garbage value. > + */ > + n2vmcb->nextrip = ns_vmcb->nextrip; Then, much of the comment looks like it wants to be the patch description instead. Any remaining comment here then wants to follow style as set forth by ./CODING_STYLE. And finally the unusual not-exactly-space characters ('·') likely aren't justified to use here. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 06:20:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 06:20:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384227.1627246 (Exim 4.92) (envelope-from ) id 1wrrSj-0003fk-1W; Thu, 06 Aug 2026 06:20:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384227.1627246; Thu, 06 Aug 2026 06:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrrSi-0003fd-Uu; Thu, 06 Aug 2026 06:20:16 +0000 Received: by outflank-mailman (input) for mailman id 1384227; Thu, 06 Aug 2026 06:20:16 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrrSi-0003fX-6O for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 06:20:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrrSh-005tz5-FX for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:20:15 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a742799-bab6-0a2a0a5309dd-0a2a450bcf9c-24 for ; Thu, 06 Aug 2026 08:20:15 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a74279f-b7e8-0a2a450b0019-d1558034dc48-3 for ; Thu, 06 Aug 2026 08:20:15 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4954afac04bso19210135e9.0 for ; Wed, 05 Aug 2026 23:20:15 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542241c4sm34174345e9.11.2026.08.05.23.20.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 23:20:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785997215; x=1786602015; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aAuvnCD1uphQa04NcpaDiUaJGfs6oUj2xypwAwI1W/U=; b=I1Ph6eM/eflyoE1aHXqNYUHcR5iIod4dWqnCgDPjB9O+RjB2ua6LzmHe5NLebxj/gz 5UKQQx9JtSkZHW8VrctFuh1g9aSjf64ClvxXihNQbhU9CXhVli7plCCmRqJE7qysKGIy FznPAPhnMqSZeEzHFvYcR2T8BYvxlNfCvRAQRLXVGcOZpJKp/uDpTqlMQ3UW0//s46Jv XwPD/tPWyISPne+/nI+W1JUYP6SNIA5YtdUbzkQJGakr7SGqmqzZ1j1cqWtD4jmzFh2R yRzQC21C+d3K332mVcrMqcXcZtkawYo2i0q4oBFZg+e9GIQh7uocBc10TkgePecWYzc8 EoBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785997215; x=1786602015; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aAuvnCD1uphQa04NcpaDiUaJGfs6oUj2xypwAwI1W/U=; b=mKHxcnVaWrTb5eZdn3OusZ2Ny8uZsFPhaela7NqmSwNg/PYdAP7RaR8NmTuq9WH31r Y/yEnx6HWBb4cxQXf/EV17mgar47X90hjrODXG2mqMaqz4i2Sk3Z9UON60/AN5DWJTKy aTes6av6fiU83ycrLaiQLVasVpeKrVOSRkFK1p0rEKVZ8+mjOBRVmffxHvsE3/lRhbGy NF4PjuS73Wnb3g9ka7HBSg7js49tG0bl60EmsIt6sx8oyMxLBTGweHe8mVlFl1Jtyc18 J0eOcOtI4MWjLpkIm3KyAcOiLY4lgY0xK9htfSy1VJBFa9YZsaLkK4u42sGZXONMlyj2 vXTA== X-Forwarded-Encrypted: i=1; AHgh+Rpti235/SPfveZpjzhE9SrGFiYiRZJRVdRQqcGjyEPhcwhvFTVUtNIidL18s9K2ByESvtvwuPpNL+Q=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx/r8z05yVyYHrCUdLUg6SLGl8HG2b8hvPsISXrDPE2Zs8BL6A7 b/0h8M4BFSBqGsc5UZ6k0/w90zNLTYBDoKcA4eJQ4dl4VJuYDGFuNxScxwsIY19vYw== X-Gm-Gg: AR+sD10phROJdTqYNFevz/H9ChSDGMefSgtQwFz/GqpnT4qHLDkyjEWta8K33RWtN2F vZ1/X+YSsfo8hasN8zGaHezfiCSy2Sif7/eVzpF6WViFWE0eGQ2CjHxyzLuc5eb/oATquKSzunP 4oljWRvgSnEp1EYgu9VKd3qiiu0s+gIhohzRvar26Df0X8mM4bJM2c10SCq4S8zz6unfj/uFzd2 nn51/P3hIWmfFL17rkMklFJG/+ovqWVU8rHp/T7DeTDqWCAwegeScyc0JtqLfnJML+Zh18qYHHZ YENH9e0mOwgfqqGqA0uozFbRYGErDQMvXi9tLkbHn//zdu3Z2i9veI+mbw2b+nXRrIYcKcb2c1P Gcw+LtDInuIv76xRMv5jKYU1/ssYFfkHSBJ8sNrTe5XKuW2VAGKmZ4Tsop4TPsypirZlWt5aWB5 V3DCwTNgZ7eBq3UEzIru6XiTMisPnGrvnmxCAEKdWZU9w+ekx/DpaEH39rKcdeNfWZ8DrXTjm25 iBnOY9dKZEBKpf4vOooj6nEiAfBqCIKXjg6v9hjOIyD9qoUfdje X-Received: by 2002:a05:600c:35c4:b0:499:4dca:aa4 with SMTP id 5b1f17b1804b1-4994e70ed73mr161340535e9.4.1785997214876; Wed, 05 Aug 2026 23:20:14 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 08:20:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] xen/Kconfig: select XEN_PVHVM To: Jason Andryuk Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Stefano Stabellini , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jason Andryuk References: <20260806015233.202486-1-jason.andryuk@amd.com> <20260806015233.202486-3-jason.andryuk@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260806015233.202486-3-jason.andryuk@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1785997215-1A0C59EA-8F1AA1F4/0/0 X-purgate-type: clean X-purgate-size: 1161 On 06.08.2026 03:52, Jason Andryuk wrote: > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -51,7 +51,7 @@ config XEN_PV_DOM0 > depends on XEN_PV && XEN_DOM0 > > config XEN_PVHVM > - def_bool y > + bool > depends on XEN && X86_LOCAL_APIC Imo "depends on" on prompt-less, default-off options are at best unhelpful in the common case. (Aiui it can be helpful when "imply" is used instead of "select".) Hence I think this dependency wants dropping right in this patch, justified further by ... > @@ -61,13 +61,15 @@ config XEN_PVHVM_SMP > config XEN_PVHVM_GUEST > bool "Xen PVHVM guest support" > default y > - depends on XEN_PVHVM && PCI > + depends on XEN && PCI > + select XEN_PVHVM > help > Support running as a Xen PVHVM guest. > > config XEN_PVH > bool "Xen PVH guest support" > - depends on XEN && XEN_PVHVM && ACPI > + depends on XEN && ACPI > + select XEN_PVHVM > select PVH > help > Support for running as a Xen PVH guest. ... the XEN dependency being in both of the options selecting XEN_PVHVM and, as per Jürgen's patch, X86_LOCAL_APIC being redundant anyway. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 06:44:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 06:44:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384241.1627255 (Exim 4.92) (envelope-from ) id 1wrrpo-0000pZ-U4; Thu, 06 Aug 2026 06:44:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384241.1627255; Thu, 06 Aug 2026 06:44:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrrpo-0000pS-QT; Thu, 06 Aug 2026 06:44:08 +0000 Received: by outflank-mailman (input) for mailman id 1384241; Thu, 06 Aug 2026 06:44:07 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrrpn-0000pM-93 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 06:44:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrrpl-0034mA-V4 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:44:05 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a742d1d-2eae-0a2a0a5409dd-0a2a4509bb38-42 for ; Thu, 06 Aug 2026 08:44:05 +0200 Received: from [209.85.221.49] (helo=mail-wr1-f49.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a742d35-be1a-0a2a45090019-d155dd31ed9b-3 for ; Thu, 06 Aug 2026 08:44:05 +0200 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so1646017f8f.1 for ; Wed, 05 Aug 2026 23:44:05 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff79b529fsm4174563f8f.12.2026.08.05.23.44.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 23:44:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785998645; x=1786603445; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EfQIuo25alYydqJl7CsWTFV1Lp4Og1ZUqJTTMZut3GU=; b=gJ1wps/A3muG8mBgg2W9yZWuF8IBc9LS1Mz4NYPCB4CeuuVAHm9TR18VjR/mh2cdpX iT+sqXCAt45zr0yRIOWpyR7KbwNKMWquE7I4+bg0dZpkq6osnsCxSD2ffoIGr+RPpqxm Lif+mqhXkeML7HGAkRA3klGZ3Nfg1HzYsKBWG9jVK+w4jY1ybykRbR5Hkpq7TjLZZqp8 WWa9bv5iASBxv1PKcr5RSAaWYv7NvkW1FA1bQy5o1qWpv8NA0+VbOUKjgSAQDCUFGkWC YOwvGFP0AyCnMds3xUvnWgc+k5+6JPykgKjQ2EO682p86AIcxbTCfQtrGrRXjiRgGjLM f82Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785998645; x=1786603445; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EfQIuo25alYydqJl7CsWTFV1Lp4Og1ZUqJTTMZut3GU=; b=Ie1ti86TZGrglMP3nT+kRuYl78/qBdkn42tZOCOy+j4xkMxHeluFN3NsBBIJveeAvg iN+Rn7rPPwvYU760HaHh4y2SHxsR1h8ofGC7fTxoN+DY4WurDTp3y75hbT/gGmSNRz9u mMGhdSLNOd+SvsUrp+cbR8Q3U9myusSC9HPwKHqUPEJHC8uBp/GgbC+2oNPH9grtm2LM Kq+Oq6Z8ZRKdKQXjO7na0RQy1xXJVPS+KDAieiEmPHcHmE4fgCv9BS7M5JX/l4xmxmvq La4OLZwuFc07CRnxzNnARBtVGueTLbF+AfTIexkbxvrE4JA9ki0clTydG79e6hbHGgFZ m+Dg== X-Forwarded-Encrypted: i=1; AHgh+RpdiDEdH3nnSIPMpCYy7mGON2Wt5v1QRRvFi3WHIQniTraH5t/wESUE1TAW2iipZsxdp9RhPAlDnpI=@lists.xenproject.org X-Gm-Message-State: AOJu0YxH6JWiU5wxlS68I1aKnkZ+JigukOZ1mo/Q72XNtVVnS2lPMXRW o823srUMcdSPU+lFx3KzWsIxjW/b/bz/YEFA1uqDDWUjtqFoNe06UdbhS3evRDs33w== X-Gm-Gg: AR+sD13hWvLZcam+bqJ5uEJtQnIdCqRYM3R48RQmZ7bHTb3EmdoSIae+tG2d0x5++eH uFe1wuuWy5fw1zLO2hrjM922a8sJxYjiX9C9n2DArRDxnhbc6RkHa22eCOL1KIZcA8X24CcOtES wRbJ8Ebx7f8nMxVZjWHh8g+uEnf9r1IRPhOSLug9armU+kUawcbHQPf7xg57xpp7Do6/+7So8gu QwB9W6BZyZ+Yv8umkhHHxXmtgBErBtCuj4FFLKSf1zHLOCL4nJlBabL4iLQ7EbQ8AhKZSKVlZWO nDGC9st8avQRUkVQtDJhQv4+eLLnEUE7EPJBM8D8Y+lBodOHzdTRaOh8iy3C9c0F7HWUNFQ1R8Y oZs9XRgxOMdktNsgIDljkkfznbU5ubrpKwH4zWr5yRaPKUjSNriO/rWZFboZ3JtiwUhS3OpdPep Vi0z3EVTm2zkMw1RdO599dPyMJm+w8wA2wUHsizO2zvHvYzdnwtomNvBIs9TKv+GZfSyABE01Yx oTPm/++JounCi8uR9C7RURo4ZnRGDDClIDo/ZXl24yrsylYLRtm X-Received: by 2002:a05:6000:18c:b0:47f:7c50:2222 with SMTP id ffacd0b85a97d-47fec53259emr17005053f8f.24.1785998645277; Wed, 05 Aug 2026 23:44:05 -0700 (PDT) Message-ID: <8c2e2d27-2802-4ba5-9b91-cb6cf8a5fa1a@suse.com> Date: Thu, 6 Aug 2026 08:44:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] x86/nmi: Watchdog fixes/improvement Part 1 To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <49738195-ad6f-4889-984d-b1eeb5372708@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <49738195-ad6f-4889-984d-b1eeb5372708@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1785998645-FC212034-CF05F789/0/0 X-purgate-type: clean X-purgate-size: 4238 On 05.08.2026 19:56, Andrew Cooper wrote: > On 05/08/2026 2:42 pm, Jan Beulich wrote: >> On 05.08.2026 14:45, Andrew Cooper wrote: >>> This is the start of a very long rabbit hole to address the >>> mis-classification of some watchdog NMIs as non-watchdog NMIs. For >>> now, just some simple and hopefully non-controvertial changes. >>> >>> https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/2733861049 >>> >>> Andrew Cooper (5): >>> x86/nmi: Drop {reserve,release}_lapic_nmi() >>> x86/nmi: Drop K7_NMI_EVENT >>> x86/nmi: Misc style fixes >>> x86/nmi: Check MSR_MISC_ENABLE for all Intel platforms >>> x86/nmi: Don't configure EvtSel repeatedly >>> >>> xen/arch/x86/include/asm/apic.h | 2 - >>> xen/arch/x86/nmi.c | 153 ++++++++++---------------------- >>> 2 files changed, 47 insertions(+), 108 deletions(-) >> This series, once again, is putting me in a difficult position: Should I look >> at it, or should I let it sit for two years or more, just like my earlier >> fixes in this area [1], [2] are? (Of course, as always so far, I will look at >> the patches, and I will likely also accept them going in ahead of mine. But I >> cannot exclude that at some point I might actually stop doing so, seeing how >> many of my patches are in that state. While at the same time none of yours >> are, afaict, i.e. as per the track record that I keep of what still needs >> responding to.) >> >> Yes, you did respond to [1], but is not being comfortable with a change really >> a reason to block it, when it _is_ an improvement, and when the alternative >> hasn't materialized in all the time? >> >> Jan >> >> [1] https://lists.xen.org/archives/html/xen-devel/2024-01/msg01365.html >> [2] https://lists.xen.org/archives/html/xen-devel/2024-04/msg00194.html > > I'd forgotten about these. > > Patch 1, I'm (still) distinctly uneasy about, but I dispute your claim > that it is an improvement.  You are adding complexity and not fixing > anything AFAICT. > > The watchdog counts NMIs (and counts incorrectly; this is the root issue > I'm needing to fix).  A timeout is declared when a fixed number of NMIs > (10, in default configuration) pass without the timer softirq having run. > > The rate of NMIs varies with P states, including lower than cpu_khz, and > differs between cores.  In some but not all hardware, we could switch > from Unhalted Cycles to Unhalted Reference Cycles, but even that has a > bit caveat saying that the definition changed in 12th Generation. > > You are making the rate of the timer softirq dynamic, but it is an > arbitrary fixed rate still unconnected to the rate of NMIs. And I'm not claiming to address that (independent) issue. What the patch does fix is a watchdog timeout occurring too early when a CPU runs in turbo mode for perhaps an extended period of time. > The only fix is to make it safe for the NMI handler to read real time.  > Until that time, in a choice between your patch and saying "well don't > set watchdog_timeout=1 then", I'd firmly favour the latter because at > least it means there's less to revert when a real fix does come along. As said in the description, if the ratio between max and normal is high enough, even the default of 5 could be a problem. > For patch 2, I had figured that bug out independently though inspection, > and yes I do agree it's an issue.  I was debating removing > watchdog_timeout=, and agree with that aspect of the patch.  However, > watchdog_force needs deleting to fix the incorrect counting, and with > your /* reset to defaults */ you're breaking the incremental property we > have of command line parsing elsewhere; specifically "watchdog=force > watchdog=10s" now sets force to false. > > I will make sure to address this bug in my series, but I think it will > be a fairly different patch when the other dust has settled. Okay, we'll see if and when that arrives. With your intent to address this differently, I don't see a reason then to try and adjust the cmdline behavior. FTR, with watchdog= in particular I'm rather uncertain whether the common (but unwritten) "incremental" policy is appropriate. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 06:57:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 06:57:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384249.1627264 (Exim 4.92) (envelope-from ) id 1wrs2h-00045Z-0h; Thu, 06 Aug 2026 06:57:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384249.1627264; Thu, 06 Aug 2026 06:57:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrs2g-00045R-Tk; Thu, 06 Aug 2026 06:57:26 +0000 Received: by outflank-mailman (input) for mailman id 1384249; Thu, 06 Aug 2026 06:57:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrs2f-00044G-CS for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 06:57:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrs2d-006mfY-Ot for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:57:23 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74304e-5cb7-0a2a0a5109dd-0a2a4505e1c2-24 for ; Thu, 06 Aug 2026 08:57:23 +0200 Received: from [209.85.221.47] (helo=mail-wr1-f47.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a743052-4cb1-0a2a45050019-d155dd2fdd8e-3 for ; Thu, 06 Aug 2026 08:57:23 +0200 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47f7854678cso1117281f8f.1 for ; Wed, 05 Aug 2026 23:57:23 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff7b1809csm3173036f8f.18.2026.08.05.23.57.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 23:57:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785999442; x=1786604242; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5xl4BRyTVRm2AXv14x5ldoaieV1jo7UO/WRkwMTRXvk=; b=WnskGpLCh7TobAX64mgB9lCYOC4IjYZfhTdt7wtFYvfOKxIRKHQzdh36Q0hl78d5wD yjoh9+qBSLye9VbZQhlRFw8XmNPQZgTNVp5nQUUjymPNfVHVmYI3JDGw30W67bhtTzyM uDYt5lKKfbbo+K7cghwynkUmQyNgpNHSF/O3EmMffRx3Ytr6ujnHjHHcgaECi8c2v5cx GgP6/+rI12XZcYA5jqFqDuTvomBDvjDj8dEGxFiQvNIyv+OMZ5lRvGgs8xbnj15G3xfL slbGtA0QGVdW+8PK+GRB3I8ROru+i+evKX7UMhbV1GNB09d8sGUo62J+5HkqoEwi19xj JrjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785999442; x=1786604242; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5xl4BRyTVRm2AXv14x5ldoaieV1jo7UO/WRkwMTRXvk=; b=kTr/gwgWsndnG2dRxJuVwSRN53deW/lWe58IkykX84dIrka36tNHaoDXriVVIqW/vv MMwwFRIbBsmsn+SV74YO6Q8evMZs4kJ2ogeIqg+EVh1Ms796Khji8o0Jpc9aDYmN667S IYtVX+ZPzKzJmdCO6XAGIEz2Rp0xBZzhzFYaTzH8WrGIQFrHsIwzt4OBO7epq0JrVtST x99qkHVZ58puPUo+fPB6m4nnRXbHmfN8qwujbMMeQMkDec8eJIDpckZ6wn1/eBvHPgnY KqZK/h91Qoe7Iiheoc/8tqFaZbS/R5paCpyM9a9X+wM13TzD4kzFY3oVQmhp651+WnIY Gesw== X-Forwarded-Encrypted: i=1; AHgh+RrzBfbEs5qORfjEx2BrfwpS4d3llfbP0+u97I6t98wCp/lMMOg78lj3u9EFQh0n+av6nEx8OKZQycI=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz7gatpJFXNDQtzG+iQyY1ejO8dQkwcfmbKgevJwR1cyCkzgqEm kpWiv7yCPnmjvpoTGdTyJgxlNt3StmEvZ8AJqjaRSDMy9z96s2ehhDinwz8hGBZFbY893Wt3wfh /Vp1jxA== X-Gm-Gg: AR+sD10rikYar2HuUa8Hp+aOTHei/ZipZFaJCStxz9jk3H7tG8PLcAkQyVIa/xOqNpP BIqBV9x4nALSmBcMXqfKrhjOX9G9kIZMYFcYNY/JizpSkKIztGrSz6OWEzdigIjOsBZIAHYAFtE tKmu4iH/U4lCz/KDBi5kMPCDN9NWe8vluPpwKyDeuFg0kg8FFj/rx6WxFZvnpqtiEvbgOlj9fj8 BUirUJ0FwzsRABIbnhopklqK5xJQcdeAssMO9QGcwceOu9h7baxMso1ECtH/5sd4vO4Okf7kZVc L0JND2hpqrqwnZoIyYVNiiTRtPLgFDFnUsRXRVzJCPLqCTeAcbolpHUKNefkeRoCq0lV30FKbRP aEPfHwdwNs7oyMHQOe0M+yK9/oMcjfQAoCr1SR5iL9YPVboqyw+9q6D++ksFjUqn+ByvnNlT156 uZskM/tikzEc2CYqjmNLVsTf8StAi6ckntx4n4y423tnr7mKCtj4AM55yw2wy+qWl4Rp4GmZFZL Cd6KsI2q8C2TkhVA7hQhIRThjmIxFZuddfnaD4ZJpjnY7fjnm+92eZYrKCywwQ= X-Received: by 2002:a5d:62c5:0:b0:47f:8fb6:c32f with SMTP id ffacd0b85a97d-47fec52a71cmr15377387f8f.24.1785999442600; Wed, 05 Aug 2026 23:57:22 -0700 (PDT) Message-ID: <0b38417e-2c59-4df1-8429-ec7c98ce22d6@suse.com> Date: Thu, 6 Aug 2026 08:57:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] x86/nmi: Don't configure EvtSel repeatedly To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-6-andrew.cooper3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1785999443-24F1F2A1-F266D2C3/0/0 X-purgate-type: clean X-purgate-size: 1155 On 05.08.2026 17:37, Andrew Cooper wrote: > On 05/08/2026 3:20 pm, Jan Beulich wrote: >> On 05.08.2026 14:45, Andrew Cooper wrote: >>> In both setup_{k7,p6}_watchdog(), EvtSel0 is first zeroed, then written with >>> everything but the enable bit, then written with the enable bit. >>> >>> setup_p4_watchdog() is slightly more complicated, owing to what >>> appears to be a bug introduced by commit 2a2bd8de16b6 ("Clean up NMI >>> watchdog handler."), which causes a second bit to be temporarily >>> different too. >>> >>> The middle of the three writes is useless in all cases. Drop it. >> Spotting the 1st write in setup_p4_watchdog() wasn't quite as easy, as >> MSR_P4_BPU_CCCR0 (as passed to clear_msr_range()) has nothing to do with >> MSR_P4_IQ_CCCR0. Using unrelated MSR names there is as unhelpful as using >> raw hex numbers. > > Perf counters on the P4 are utterly insane, but our local logic really > doesn't help matters. > > Another option would be to remove P4 watchdog support, in the basis that > we really can't test it. Well, my Tulsa system is still alive, and the watchdog looks to be working there. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 07:17:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 07:17:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384262.1627276 (Exim 4.92) (envelope-from ) id 1wrsLN-0000s1-Gt; Thu, 06 Aug 2026 07:16:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384262.1627276; Thu, 06 Aug 2026 07:16:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrsLN-0000rt-Di; Thu, 06 Aug 2026 07:16:45 +0000 Received: by outflank-mailman (input) for mailman id 1384262; Thu, 06 Aug 2026 07:16:43 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrsLL-0000rn-Qc for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 07:16:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrsLK-009R4U-L3 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 09:16:42 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7434c9-bab6-0a2a0a5309dd-0a2a4509b588-44 for ; Thu, 06 Aug 2026 09:16:42 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7434da-be1a-0a2a45090019-d155dd2cddf0-3 for ; Thu, 06 Aug 2026 09:16:42 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f7854678cso1130104f8f.1 for ; Thu, 06 Aug 2026 00:16:42 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49954228a47sm58644065e9.12.2026.08.06.00.16.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 00:16:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786000602; x=1786605402; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=afWRBDy6f/MYpbm8V8ND9nRxMaDsHk8GOgxRDVlc6g8=; b=IOHVQhLPbH/ZeFyOs8PNb/I516WzGBk97S+5dTFX28ODBWhONY1yWOYK6GUAw7251p pAMg05VTNT1CVO8OBOIHYzINXLCtuDvnmJNnLYW5OgFOsdSLIz7l9WBXLzkYoagkWB5Z FH+aGK0RJ+e4XPdyT2YXdZc4ypb0E0jr//d+vDsOE9slKpxRmfKoSNkMiCbXtmZt+yrI b2nVhMxK0FSHVt04PpeRuo7uGk5iy9H8qVcd8vEnsW7DbXn0KFMtVovmUhLV2gMkmPIF yqZwcnNm9QKSi1YUy7oxi1itncN+/ptPiJcjSgbtzcwBoS17nvCaySC3Ddr7dgyqnpPX OAtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786000602; x=1786605402; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=afWRBDy6f/MYpbm8V8ND9nRxMaDsHk8GOgxRDVlc6g8=; b=D7pNpfL+E8cJsNuUjTJJSmSHbJ02VmCCzzH4nJrVpOzjg1aVGXo6kE24GMXFhD/Nn8 8cF2sl23H7qPJJ3Yu3qUqGzuQq4/CY8Kxe4/FhLbL4g3ppocBY6Vh/hkTFa2ZEipw6ny sv3Vu358TRm34gYfHvpEIcZwp0MYcdZ9vurbaO14RN3CmwBKQYgKLC31ikh0qjYM0/OG zfdP+RcJZcOUpyqCsQeh49eszEShjO5oKwpSY6iAnNEjOCotSmM+RgJnNqwhWty26tKo svzv3XOwpe4O2CjnwBVFhCKVBYJFBDcPTV7LTREgbE4yPHbnEBOCm0/Zo/jKe9EroP4R 2frA== X-Forwarded-Encrypted: i=1; AHgh+RqmQ42yFp6s6Flo5sXzobxOV18yXG7I4c9Yttvqae+8YyFlLiVN0n22x4RTN3HeiqxZUPBWHbp7YhM=@lists.xenproject.org X-Gm-Message-State: AOJu0YwFT/x4QB7KdqCQDmnK2XyWMZ9JMuHLYKqwNoUnbjJs1Jx8T98R SqvYXHU3qQVRA0Ocdk0Jx1z88W1STBSUwgoGfkWbndq0+Wh5WOBIeBfSpwJAllT5XR1WaAKcoHr EOh/NZw== X-Gm-Gg: AR+sD112NOjNHdOu7Mexm3U1+vNEUs3v3VDVBBATDEAmddSPAAJaN1hOcESsNy9reCV 1tgXK8bmHXSv1J5UegqDNO3ist8Dj/ssiavaIAw3qrlZWp0fCpI+UhzVxPIt/iTmjzAWyB1wM0a 2O3hOn9UBYlJoYkUD9WCIfp2e5DgraLuBi0OHh/GrOSgSD4l63Nduv1mu0cugn4ZGCdkvH7LiwB kVvaJqehmwBMjMs4rzINNdcc4YCQu1mVEDPJfunkS/fJQgP7vMkMwoUm5mmzsh1DP6R31Mof4WH LbVKQj1hMNIFYDYMzsQ8XpnxRkO0PQvcvIYNEFDHOvXeu3iB+S4PmKf72S0XRweXoaWTd3IGC+p IaH5d9uldclscEnsa0v09Rxp4VY0oJaBc5aqOSK7UPoY0VavicgfSN+aFK5EgfRmlgJhQInxKZn g4hWcxuIblhiXLl7fvn4T+dAAGKvlSqKkLLEjVQr2vknUdvsdCCFmPR8Q9QxxI0ytA3ej4xH/Fm cfhymPoXlowiBpDClhRddaF05zZ+8QsRZdkM08geQGbilOCDzCM97R/WKIIT6w= X-Received: by 2002:a05:600d:8489:10b0:495:4749:16a7 with SMTP id 5b1f17b1804b1-4994e7c5e9bmr143037545e9.14.1786000601911; Thu, 06 Aug 2026 00:16:41 -0700 (PDT) Message-ID: <7762513c-0d3a-465a-abd9-73e3ba586556@suse.com> Date: Thu, 6 Aug 2026 09:16:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: "Daniel P. Smith" Cc: Jason Andryuk , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> <6991badc-dcc4-44b9-a048-29eb67c46d2e@apertussolutions.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6991badc-dcc4-44b9-a048-29eb67c46d2e@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-bad1c0/1786000602-BD2CC034-198D6D2D/0/0 X-purgate-type: clean X-purgate-size: 1053 On 06.08.2026 01:02, Daniel P. Smith wrote: > On 7/28/26 9:22 AM, Jan Beulich wrote: >> @@ -2307,7 +2308,7 @@ argo_init(struct domain *d) >> { >> struct argo_domain *argo; >> >> - if ( !opt_argo || xsm_argo_enable(d) ) >> + if ( !opt_argo || xsm_argo_enable(XSM_HOOK, d) ) > > This question came up on another thread, so thought I might point it out > that when FLASK is in use this can return a nubmer of error codes beyond > an access deny. While I know it's the existing behavior, but if the > error code is anything other than -EPERM, then it's not that the policy > denied the access but something cause a fault in the security server. In > that case the domain is still being allowed to construct with the > assumption that it was a policy deny. At a minimum should the error code > at least get reported, and perhaps it should be passed up to domain > construction to allowing it to make an informed decision on construction? Sounds plausible, but definitely wants doing in a separate patch. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 07:23:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 07:23:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384272.1627285 (Exim 4.92) (envelope-from ) id 1wrsRS-0003Uh-48; Thu, 06 Aug 2026 07:23:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384272.1627285; Thu, 06 Aug 2026 07:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrsRS-0003Ua-1S; Thu, 06 Aug 2026 07:23:02 +0000 Received: by outflank-mailman (input) for mailman id 1384272; Thu, 06 Aug 2026 07:23:01 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrsRR-0003UU-6P for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 07:23:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrsRQ-003CiB-Fs for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 09:23:00 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74364f-5cb7-0a2a0a5109dd-0a2a450be154-10 for ; Thu, 06 Aug 2026 09:23:00 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a743654-b7e8-0a2a450b0019-d1558030ad3c-3 for ; Thu, 06 Aug 2026 09:23:00 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49558ce01afso12892895e9.1 for ; Thu, 06 Aug 2026 00:23:00 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995421b1e2sm48667145e9.8.2026.08.06.00.22.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 00:22:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Cc:Content-Language:References:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786000980; x=1786605780; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :cc:content-language:references:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ckcvMovW0LtLyQPM832KezdfHJgVxcVYWAXZjbEPPA0=; b=Jspyi1LwmoRHKL3zEurc8Dyv0ohM3Ariqo2FkRhpPJNepLuU4Eedy94ewrJcxeAnOe 5vuT/UFBA/Bk874BNB3MwMLFxpyqsvNuKjsKjm7wuueKWIn4NjC/5Jt40hNTA9U8Jzdd eQwyMZEOvkck6KqgN7vE4yFztQNl/sYi2DJAc7+FkHPNhSsLV4fvnsDPjGeK4sz5bSou KPETM99CeYqHcFClqsGAwLenjnTZho8n/Cp9vUNYhzyKs8U+8tfJ3EH0ycnweaBZD+kT m3ZTrL68AmIt5EYl0BKb4zOnDLj2O6MMpjTarFDSX3GLoe69wHLHakp8p8tqXbRjS/ix oO6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786000980; x=1786605780; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :cc:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ckcvMovW0LtLyQPM832KezdfHJgVxcVYWAXZjbEPPA0=; b=sPGFb2QqykmUgmW2WAEahINmmSdeR7Hfqj2jSru0/+/RSbJLn4s9oxVwtIajv89ZVN 5mJZcNXMNsS4m+tDs9q0bQoAGhAuzqDpkNghcRz2JQxttJ8brrI0p3UxzHZlUuO6Dw4G 6x6OjfR7YTy4KADX8GRjOBvzoCc1fNyeojHuJYq3TTXcfRJDBh2rYRZnNU/UtJa1Gl4U i5eb1ui08EPUtEk0WOALIhMHje9c9l81BOABuHvtEvZwgdJeM0rvbFx1AcCi0kPIbd3X 7h8rmoiVQY91TIfzgSoMd6w+kUx1JpoDl36oZHWUdZzkiqbV4/7fj09l3yxvjdILuMdb yQnA== X-Gm-Message-State: AOJu0YwkLtT0zLEUd8nA8INyAP/cXOxO06kB9+oK90FedZY/vtLSum+1 ZF/BC/yemwZcMNlAqhaZrUpRxNr3QDOxmskWzBD0Sx3RP+PyRCU0CDzIdz988bdbEn6RWLLjh4u mtS9K7A== X-Gm-Gg: AR+sD13mfRBaC/FeWVivKELSCl4n264IcYLj/2gx797yg9v4d89whdB/1Qy9pwCuwLx zwihPteap9c0eubv90YhFmyu0EZ74F7bidCqN3asR51afQKYFdyT2Y6CzYU6KfiJQIM9j3YZz2j hhdE/VipGBQ3jndruAbdngExDE4VdOeZ0ij6710z42AvzxEqvxLwvBuIUkxWpY3I+XOJvrJZb53 +BD45SJ+OC01s43YBkdjt2jLwcpvynJbx0/GJyvA2TuzkRC2GEdirTY77korG8KjrmIehUL6R3e xvz4uz/QjKLzUCxcsMdrd+AFyeJDPc5nqpaikjAXQcDGGP5lJafZG4tYTOow5//koxwPrVYo1w9 uf+XwC8YB7/x7woEVbtY6okq85yTbPMRC927pFpxkfxB+kGs/yhh4kzbd5TEUP1fl7LdTRkGM0s vMC4hiSnXM0a/J4OmtrpuWJhNaWazbKL1XSLB3iJvTSh9xDnqDdiGOfbdsdQtD9qr2MHBFFgmvJ QGuWczWZU9zKCY8tCvODsSI2eeAfU72s/QO8wgPkw76mnpx3dFeUMIT6mPcMGs= X-Received: by 2002:a05:600c:c043:b0:495:7a5a:d96c with SMTP id 5b1f17b1804b1-4994e7d89cfmr131608205e9.18.1786000979800; Thu, 06 Aug 2026 00:22:59 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 09:22:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/24] XSM: make XSM hooks well-formed ones To: "Daniel P. Smith" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <2c108d3c-eef1-4d4b-9874-b0721fd7560f@suse.com> Content-Language: en-US Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1786000980-AACDF9EA-89DFB1E8/0/0 X-purgate-type: clean X-purgate-size: 2406 On 06.08.2026 02:53, Daniel P. Smith wrote: > On 7/28/26 9:22 AM, Jan Beulich wrote: >> For whatever reason they didn't have an xsm_default_t first argument (to >> cope with XSM=n mode), making it impossible to (easily) cover them in >> xsm/hooks.h. >> >> flask_do_xsm_op() is also changed to return int, as all the function ever >> returns is an int. This way no new machinery needs adding to xsm/hooks.h. >> Instead one piece of compat machinery can then be dropped from >> xsm/flask/flask_op.c. >> >> Signed-off-by: Jan Beulich >> --- >> Instead of XSM_HOOK, using XSM_OTHER may also be a sensible option here. > > I would say XSM_HOOK is sufficient since at this point it doesn't matter > what op is passed the dummy policy is just going to return the same > value. If the dummy policy is extended to support an op, then at that > point the implementer can switch it to XSM_OTHER. Good. >> Question is whether some/all of the other hooks still declared explicitly >> in struct xsm_ops should follow suit. > > I would say either comment these are exceptions or make them consistent, > though I haven't studied if there would be any consequences (doubtful) > changing the others. As I've now added patches to convert the remaining hooks, this remark is gone anyway. Hence comments there aren't going to be needed (unless those extra patches would be rejected, once posted). >> --- a/xen/include/xsm/dummy.h >> +++ b/xen/include/xsm/dummy.h >> @@ -439,7 +439,7 @@ static XSM_INLINE int xsm_hypfs_op(XSM_D >> >> #ifdef CONFIG_XSM >> >> -static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) >> +static XSM_INLINE int xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) > > With this change, should there be a comment that the int is going to get > cast to long before return? Not in my opinion, but if you strictly think such is needed, I can certainly add a comment. > Acked-by: Daniel P. Smith Thanks, including (again) for all the others. Nevertheless a request here: Especially when an ack is the only part of a reply, could you please trim reply context much like (most) others do? Without that, every reader has to scroll through the entire reply context, just to find the single line at the bottom. That can be a lot of scrolling with larger patches. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 07:37:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 07:37:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384286.1627294 (Exim 4.92) (envelope-from ) id 1wrsf0-0006bx-BB; Thu, 06 Aug 2026 07:37:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384286.1627294; Thu, 06 Aug 2026 07:37:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrsf0-0006bq-8Y; Thu, 06 Aug 2026 07:37:02 +0000 Received: by outflank-mailman (input) for mailman id 1384286; Thu, 06 Aug 2026 07:37:01 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrsez-0006bk-8e for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 07:37:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrsey-00EejD-LT for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 09:37:00 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a743997-e002-0a2a0a5209dd-0a2a45079c08-10 for ; Thu, 06 Aug 2026 09:37:00 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a74399c-b4ea-0a2a45070019-d1558036f1ef-3 for ; Thu, 06 Aug 2026 09:37:00 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49800c6a846so14946355e9.3 for ; Thu, 06 Aug 2026 00:37:00 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542135cesm42363935e9.4.2026.08.06.00.36.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 00:36:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786001820; x=1786606620; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ViL4VHVHnGZCDBTWYy/BbLFUaSoqso542Mz4ZuHRR0k=; b=KIuLmYYbHUfxRC/XsvUjm/KXzPIi4iHsP3Cr4muM2r6JdqGhVUuwfGuUF7QFGxbRTN NzlMaNHlHoOmeXYyZLZXdiPuIAEXgQsUwuRo4VmAsozwzniSkCP7S/1ur8H/Y8Zyv4lj ziaI+RDRYg4doUGW43qcOIIdh5rrsUbwKGgCxym8BngX78CV/UyGtyZNPQ9rdOW+Gmk/ Yf0Y9oT0mBB3kvFclG8VQrSjiEe/gYXxjKGdd71U3fqJV/D+4Vb7ow5CWEGX/LkgfRs6 aJj4caaZbqha9Kv8Gmp5wqUpJWhYwLzNKdEYV77vu98k1MOLXsSSRomyni3PpfB61zFq ATIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786001820; x=1786606620; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ViL4VHVHnGZCDBTWYy/BbLFUaSoqso542Mz4ZuHRR0k=; b=qy2eFLRbhnBhG0e+J5VU91Ho0VjmBo0y+0zZZuZmBpxSeClP1C/B/jr4O76ueT02kU GP3vVgOdSktseRHhpvHFhJKeNcXS0BDavmWv7p3gzD6D9Zb4i5kEKs+DoITv1G3zDfPj lJARkDCG+PSlMqxZYjdV19WvHb95LcpDp1PGrmbRT/wkVe36IeSzQS3oVgo8FPBgQLp7 ObdrVv/uYGtFN/EMjStBQ6kVxx7cdOmbfom5x0LU1OLlEhBCn80RSQYoNiiT82RDglyU IXpHOjgswhrHhJRsj5HbhU2gMYyiuov3mfh8RI2E66wX/SAnucqViNiEmcv5gqmMOdJJ fP3w== X-Forwarded-Encrypted: i=1; AHgh+RrgKAr37uK9ZkkTekM/wnXV6E2Ck1jLnI3DqAFGjQ/crIUZxTYxpet9sKBCBBXN/JWT3R822eKT0AU=@lists.xenproject.org X-Gm-Message-State: AOJu0YwUs7VXkNHbyg6PJ0Qkfp7kINbSuJ2qMwAqvO3++gFaAmmAoVnA xOXyargz/McvILT1f8iMTiBV9XIGV1yrKn6IB+7Gu8A3K4J+dOtQh3WE0Rc/OzCxgg== X-Gm-Gg: AR+sD131UxgVKAMm6L2AD5mtK0pFXYa+lfr1F4ekMWRO3bPMw4diJOp14RBMolKmqtn j/frcYDQ94QW9JQPIXpRvbg4UBFvxbrRXD8Kl1DGxdD8uG+Dn1S8Rq7dZp9EOzIVsTeQPT4yvy2 y09tlFhGfsbuF/aMME6MnaLuLyA2bl3I93E/wWBwSxPvqdslGINQtrGcV8qVHehYyy7obPmUkA0 D+vq2OLXXjfti5n6yVm5k5WgghVrE4rplU/YYSwjSNnIi1E19jSZGhxZXPD5yzmmibW6VWlfVWU +0vJSo8cE65FjxzIb9+kr2cB4goZPPczMY9+6gVYLwAcaYoom/UZLxqQhWe29B30HzMzb8a46hK WYE8lH7588ryTSvc00ZEZoJ1prbm++o3h9R8k4qhF2n9u9l1VDs0SX1NcbMMSWl4UtIfdWHwNpE wQq6NqG7B8Vl5yiACTUS7Tx0wzDqlUDe4AbiVtOYZ4yn2ZkgDPfiOf0kspBnMYR7+58RYM3Myg7 6uzY6xW14IqU+8/XyRdWwNSOyowzSTXapoiTgCIWJYcemNLnB9f X-Received: by 2002:a05:600c:348a:b0:490:c6c2:52 with SMTP id 5b1f17b1804b1-4994e79b9c0mr185355295e9.3.1786001819346; Thu, 06 Aug 2026 00:36:59 -0700 (PDT) Message-ID: <274a27cb-13f0-47c3-aa73-1534925dc350@suse.com> Date: Thu, 6 Aug 2026 09:36:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/24] XSM: fold xsm_{,un}map_domain_pirq() hooks To: "Daniel P. Smith" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1786001820-A6CDFAE4-CE4363B4/0/0 X-purgate-type: clean X-purgate-size: 1869 On 06.08.2026 03:10, Daniel P. Smith wrote: > On 7/28/26 9:23 AM, Jan Beulich wrote: >> --- a/xen/xsm/flask/hooks.c >> +++ b/xen/xsm/flask/hooks.c >> @@ -1022,14 +1022,9 @@ static char *cf_check flask_show_irq_sid >> >> #ifdef CONFIG_HAS_PIRQ >> >> -static int cf_check flask_map_domain_pirq(struct domain *d) >> +static int cf_check flask_map_domain_pirq(struct domain *d, bool access) >> { >> - return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD); >> -} >> - >> -static int cf_check flask_unmap_domain_pirq(struct domain *d) >> -{ >> - return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE); >> + return current_has_perm(d, SECCLASS_RESOURCE, resource_to_perm(access)); >> } >> >> #endif /* CONFIG_HAS_PIRQ */ >> > > I am not opposed to collapsing the calls as long as the semantic is not > lost, which I feel the reuse of the xsm_map_domain_pirq does looses it > much less provides an opportunity for confusion. Something like > xsm_domain_pirq(..., access) makes more semantic sense to me, as it > would read, grant domain pirq access T/F. In fact I was as well wondering about naming (and a possible name change) here. I decided against it because of the other hooks (touched by patch 19), which all follow a similar model of their names really more expressing the "positive" form than the "negative" one. Further, entirely losing "map" from the name also doesn't look quite right, as physdev_{,un}map_pirq() is where they're called from. To follow the naming of some of the other hook, maybe xsm_domain_pirq_mapping(..., bool map)? Possibly even with "domain" dropped from the name, fully fitting xsm_io{mem,port}_mapping()? Which would then further raise the question whether patch 19 should maybe rename the parameters of those two hooks to "map" at the same time. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:02:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384333.1627316 (Exim 4.92) (envelope-from ) id 1wrt3v-000625-Vc; Thu, 06 Aug 2026 08:02:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384333.1627316; Thu, 06 Aug 2026 08:02:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrt3v-00061y-SV; Thu, 06 Aug 2026 08:02:47 +0000 Received: by outflank-mailman (input) for mailman id 1384333; Thu, 06 Aug 2026 08:02:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrt3v-00061s-9n for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:02:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrt3u-00EmAW-Mo for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:02:46 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a743f9f-5cb7-0a2a0a5109dd-0a2a45078852-38 for ; Thu, 06 Aug 2026 10:02:46 +0200 Received: from [209.85.221.47] (helo=mail-wr1-f47.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a743fa6-b4ea-0a2a45070019-d155dd2fd027-3 for ; Thu, 06 Aug 2026 10:02:46 +0200 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-4799b3f7c83so1125769f8f.2 for ; Thu, 06 Aug 2026 01:02:46 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff79b32cbsm4274844f8f.10.2026.08.06.01.02.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 01:02:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:Content-Language:References:Cc:To:From:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786003366; x=1786608166; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=3qC2koAO6M5d9qfd2TP0PWbB9YVhSs3GAciczfY0x2w=; b=I/Aq02b6ZaJEFEzXrGHHy5NCot2aiv7oKbvefORiHOwgS/Z/MrmLLkALC0JiEwYto4 6PHpZ33slz7BEP+8Fy8i1Bm4Xf3z3coS9BYhMmXSi8WcXi2i/21O2kfnrffXfmGOHEwj U7muqe9kFMtbafTb21rAR9/hFTGmVBFkKdmls51QmgtI98djyuS4LfdD7BChO75q/TQA lRkga4Yx2lQMlItcHkVFvMOOuPLLeqWXq1vGP5P5WNnzI4qN0ST2oDRws+JrJF5r0pT+ ux17+FsGfnmP500bp2GOMRSXeyKvVWDlcPTrtrlozsVJzNyo/69eCQmh3p16H15b0/xs 8BIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786003366; x=1786608166; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3qC2koAO6M5d9qfd2TP0PWbB9YVhSs3GAciczfY0x2w=; b=oZvZAH9AH+R+AEiprew/vYrgFPdeeXC9svokQtppmnd5ZIvWk20GUwG9DhiL/kMiHD E+Po6kZnLioU2885woFD1GgU6mGcUrY8PvhUP7MdTRel7mdWQsW4A4XI+pHHl7QPZkDE DN1buDppZws63OC6RiDm+YJeVSrM9LiXLEB9+8FFIiopHcDQRr/bJjvcddbWb/HQMEQt bQTokizWbxM7C3JonMunzXl4rxJW1sF/eFWZbMVQIAbrAY7iqeaEykuRuzqcv1cdFdF/ CbutsKvfcRPFOC+1rJKTIzBUOqbkrYog4WLsH/AjZmw+r6h0AzNzgqDE6CENE+xNw+bg nasQ== X-Forwarded-Encrypted: i=1; AHgh+RqE8XOo7E8R/unKLpqux5p1lAp0LTIoTQzAVZfI4VIfQXrHcVBWHK4JpHmF37wklEhLTbwfvvvxg90=@lists.xenproject.org X-Gm-Message-State: AOJu0YwdnIA4E/lJgpY7yryC2eB3nXnWJbDRICb/4sMvYjmvYM1jhqtS LV1DI5HSuQxS4hAjlMeyG2VmaYyFUEtglwxNBzqXypBCQYn6EZnQCzzo1vWVf06/RA== X-Gm-Gg: AR+sD10N7cbtlNZwTRBQ8jHak6vPOeeO9NPp77lg4J/KHUsxZuCJ2pyljv0hvtp2nOj GL3ZqLs2+11aMhNFjA8WL43bacs8TxMysDgex27R0cSS0KoVKEqPcnJSkvyV19xLhhU3cKTMsnv Ilve9EVJAm8vTfA6I283yrAqlzVJs/DnBBU3g1rJb/aNqH3f7audGYNEgTx7z5y+pC9QfgzrmcF earL+QuwiTSSeb7A7begUWGj0sSlnH9XPgk59BMQI2nzF0k0nJAHudpkUp0zVmISJ7BcWS+x5j4 fdYD/5qBMbvfc5nYAptct8gDdo3y9Ov0rrsIU0zOvdAJ4tD/5xUGfyLwaci3IE7dreAQhGi/5mE oZipJr0EhiWsvjqyPSGaNVb4+EB5MQK0epHE+MA6jYkS0F4eNYgrVLc36Jtu8iVa+aNmzGM/9ax uQrk6wrZhhyh8eLW1GpL/fzfrQ8AH44P6Zy3nU5/MA7trK0TObnoHPTwKofiog5vDgwhHQ0r3cZ 458K35o5wjHm+QupgNQ11olUFpSa8Tk6RA+S8I5yCC2EYAhItWnJ6phYBs1KYQ= X-Received: by 2002:a05:6000:3113:b0:47f:80f0:8d33 with SMTP id ffacd0b85a97d-47fec6457camr19128500f8f.30.1786003365298; Thu, 06 Aug 2026 01:02:45 -0700 (PDT) Message-ID: <7bfe23f3-b7cc-4821-b4a8-1d1793ffaa92@suse.com> Date: Thu, 6 Aug 2026 10:02:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/24] XSM: fold xsm_{,un}map_domain_pirq() hooks From: Jan Beulich To: "Daniel P. Smith" Cc: Andrew Cooper , Teddy Astie , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <274a27cb-13f0-47c3-aa73-1534925dc350@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <274a27cb-13f0-47c3-aa73-1534925dc350@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1786003366-374D3AE4-6B3AF600/0/0 X-purgate-type: clean X-purgate-size: 2058 On 06.08.2026 09:36, Jan Beulich wrote: > On 06.08.2026 03:10, Daniel P. Smith wrote: >> On 7/28/26 9:23 AM, Jan Beulich wrote: >>> --- a/xen/xsm/flask/hooks.c >>> +++ b/xen/xsm/flask/hooks.c >>> @@ -1022,14 +1022,9 @@ static char *cf_check flask_show_irq_sid >>> >>> #ifdef CONFIG_HAS_PIRQ >>> >>> -static int cf_check flask_map_domain_pirq(struct domain *d) >>> +static int cf_check flask_map_domain_pirq(struct domain *d, bool access) >>> { >>> - return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__ADD); >>> -} >>> - >>> -static int cf_check flask_unmap_domain_pirq(struct domain *d) >>> -{ >>> - return current_has_perm(d, SECCLASS_RESOURCE, RESOURCE__REMOVE); >>> + return current_has_perm(d, SECCLASS_RESOURCE, resource_to_perm(access)); >>> } >>> >>> #endif /* CONFIG_HAS_PIRQ */ >>> >> >> I am not opposed to collapsing the calls as long as the semantic is not >> lost, which I feel the reuse of the xsm_map_domain_pirq does looses it >> much less provides an opportunity for confusion. Something like >> xsm_domain_pirq(..., access) makes more semantic sense to me, as it >> would read, grant domain pirq access T/F. > > In fact I was as well wondering about naming (and a possible name change) > here. I decided against it because of the other hooks (touched by patch > 19), which all follow a similar model of their names really more expressing > the "positive" form than the "negative" one. Further, entirely losing "map" > from the name also doesn't look quite right, as physdev_{,un}map_pirq() is > where they're called from. To follow the naming of some of the other hook, > maybe xsm_domain_pirq_mapping(..., bool map)? Possibly even with "domain" > dropped from the name, fully fitting xsm_io{mem,port}_mapping()? And then xsm_irq_mapping() in patch 23 and xsm_pt_irq_binding() in patch 24? Jan > Which > would then further raise the question whether patch 19 should maybe rename > the parameters of those two hooks to "map" at the same time. > > Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384362.1627334 (Exim 4.92) (envelope-from ) id 1wrte2-0006dA-2C; Thu, 06 Aug 2026 08:40:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384362.1627334; Thu, 06 Aug 2026 08:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrte1-0006ci-Uk; Thu, 06 Aug 2026 08:40:05 +0000 Received: by outflank-mailman (input) for mailman id 1384362; Thu, 06 Aug 2026 08:40:04 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrte0-0006IA-9a for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:40:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrtdz-007961-ML for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:03 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a744862-e002-0a2a0a5209dd-0a2a4505856c-4 for ; Thu, 06 Aug 2026 10:40:03 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a744862-4cb1-0a2a45050019-d98c6eacde50-1 for ; Thu, 06 Aug 2026 10:40:02 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91F4019F0; Thu, 6 Aug 2026 01:39:57 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D66C63F632; Thu, 6 Aug 2026 01:39:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005601; bh=iynuOAJCPNuRyHhHF6oGom9ZpKtzcvQOC1dJwzRcJvM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PZG9EdTY1k5yypy3196H+wqk2/KNoPtVM/b9UYaFI6ZI3d24qfuLCJzRICQkyCkLc sFKziULNcmx7SYfTqR1bq57rbn7/KNqG7/Xk/gSlWU94DTBYVqXEPKUndhrDA8EsJE 22M3TfK+4A1Hh9u1/kuRYdSEUGb4ZkLFgLd50Kg4= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 1/9] mm: introduce hw_pte_t for PTE table storage Date: Thu, 6 Aug 2026 09:38:39 +0100 Message-ID: <20260806083926.1807279-2-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1786005603-243112A1-4377233D/0/0 X-purgate-type: clean X-purgate-size: 2610 pte_t is used both for logical PTE values and for entries stored in a PTE table, so pte_t * does not distinguish a pointer to a copied value from a pointer to table storage. Introduce hw_pte_t as the generic name for a PTE table element. Define it as a macro alias of pte_t by default. When an architecture selects ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead. This preserves the representation while allowing converted architectures to enforce the distinction at compile time. Keep the C type definitions behind an __ASSEMBLY__ check because architecture assembly sources can include this header indirectly. Include asm/page.h so consumers such as linux/vmalloc.h retain the page definitions they previously obtained from that header. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Add the ARCH_HAS_HW_PTE_T opt-in and generic wrapper definition. - Exclude the C type definitions from assembly sources. - Update the description for the new opt-in model. --- MAINTAINERS | 1 + include/linux/pgtable_types.h | 17 +++++++++++++++++ mm/Kconfig | 3 +++ 3 files changed, 21 insertions(+) create mode 100644 include/linux/pgtable_types.h diff --git a/MAINTAINERS b/MAINTAINERS index e9c8567308a75..7169bea968cf5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16982,6 +16982,7 @@ F: include/linux/mmu_notifier.h F: include/linux/pagewalk.h F: include/linux/pgalloc.h F: include/linux/pgtable.h +F: include/linux/pgtable_types.h F: include/linux/ptdump.h F: include/linux/vmpressure.h F: include/linux/vmstat.h diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h new file mode 100644 index 0000000000000..70c3edd00a01b --- /dev/null +++ b/include/linux/pgtable_types.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_PGTABLE_TYPES_H +#define _LINUX_PGTABLE_TYPES_H + +#include + +#ifndef __ASSEMBLY__ + +#ifdef CONFIG_ARCH_HAS_HW_PTE_T +typedef struct { pte_t __pte; } hw_pte_t; +#else +#define hw_pte_t pte_t +#endif + +#endif /* !__ASSEMBLY__ */ + +#endif /* _LINUX_PGTABLE_TYPES_H */ diff --git a/mm/Kconfig b/mm/Kconfig index 331daf7fcfab5..31ba9ebf4aafd 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -1316,6 +1316,9 @@ comment "GUP_TEST needs to have DEBUG_FS enabled" config GUP_GET_PXX_LOW_HIGH bool +config ARCH_HAS_HW_PTE_T + bool + config DMAPOOL_TEST tristate "Enable a module to run time tests on dma_pool" depends on HAS_DMA -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384361.1627325 (Exim 4.92) (envelope-from ) id 1wrtdt-0005XE-NC; Thu, 06 Aug 2026 08:39:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384361.1627325; Thu, 06 Aug 2026 08:39:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrtdt-0005X6-Jj; Thu, 06 Aug 2026 08:39:57 +0000 Received: by outflank-mailman (input) for mailman id 1384361; Thu, 06 Aug 2026 08:39:56 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrtds-0005Vv-6l for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:39:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrtdr-00790P-Jg for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:39:55 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a744842-e002-0a2a0a5209dd-0a2a450a8a14-44 for ; Thu, 06 Aug 2026 10:39:55 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a74485a-f2d2-0a2a450a0019-d98c6eacdb06-1 for ; Thu, 06 Aug 2026 10:39:54 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 836C4153B; Thu, 6 Aug 2026 01:39:49 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C4F063F632; Thu, 6 Aug 2026 01:39:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005593; bh=1/GXhzlocZP3RO99ssHRo2N31fXX+evtIf1AglwmeYk=; h=From:To:Cc:Subject:Date:From; b=XAD0GC3BFV+aOtURbErU8rEzfMbSmdJMzfNwzK/FHv0gx1gos8TDz/dRjKI0JzDR0 AQ4BuCvKLoJi+XVzKw+vUT1ULkUCtkTdaFTQUlv601HAIs75njL9FmO8WmoPB+Psrr TDc5b83VZ6vnRuzuzlPGu/pmjS3BAMBtce5CKFQo= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 0/9] mm: distinguish PTE table storage from PTE values Date: Thu, 6 Aug 2026 09:38:38 +0100 Message-ID: <20260806083926.1807279-1-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1786005595-502F0CFC-4C0B5F46/0/0 X-purgate-type: clean X-purgate-size: 12117 Hi, pte_t currently describes both a logical PTE value and an element stored in a PTE table. Consequently, pte_t * can point either to a standalone value, often a stack copy, or to a PTE-table slot. The compiler cannot distinguish these cases. A value pointer can therefore be passed to an interface that expects table storage, while table storage can be read by direct dereference instead of the architecture accessor. This series begins a staged conversion at the PTE level. It introduces hw_pte_t as the element type for PTE-table storage and converts generic MM to use hw_pte_t *. Logical PTE values remain pte_t. Interfaces that intentionally return a value through pte_t *, such as install_pte, remain value interfaces; the relevant parameters are named ptentp to make that distinction explicit. The generic definition aliases hw_pte_t to pte_t unless an architecture selects ARCH_HAS_HW_PTE_T, which enables a distinct generic wrapper. No architecture selects it in this series, so the representation and behaviour of every architecture are preserved. ptep_get() keeps its existing READ_ONCE() semantics and converts the stored element through __pte_from_hw(). An architecture can later select the option and convert its PTE interfaces to make the distinction compiler-enforced. Architecture PTE implementations and most architecture code are deliberately left for those later opt-in conversions. Here, hw_pte_t identifies PTE-table storage rather than table lifetime: complete PTE tables use hw_pte_t whether or not they are currently linked into a page-table hierarchy, while standalone copied values use pte_t. The distinction between complete but unlinked tables and hardware-reachable tables was raised during discussion and remains an important point for review. PMD, PUD, P4D and PGD storage are deliberately out of scope. They can be converted in later series after the PTE boundary is agreed, avoiding the PMD-specific cases that made an all-level conversion difficult to review. Most mechanical pointer conversions were generated with the Coccinelle script included below, then audited and fixed by hand. This series does not add a second ptep_get_once() accessor and does not remove or replace STRICT_MM_TYPECHECKS. The design discussion is available at [1]; while the original idea came from [2]. I've the patches here [3] for arm64 conversion which I used to find usages in generic code which I missed during development. These would be sent separately. [1] https://lore.kernel.org/all/6110202c-057b-4701-8c04-1a76ee7bb9ab@arm.com/ [2] https://lore.kernel.org/all/a063f6c5-2785-4a9f-8079-25edb3e54cef@arm.com [3] https://github.com/musamaanjum/linux/commits/pte0_arm/ Thanks, Usama --- Changes since RFC v1: - Add ARCH_HAS_HW_PTE_T so architectures can opt in to a distinct PTE-table storage type. - Define the distinct hw_pte_t wrapper and its conversion helpers in generic code instead of requiring each architecture to define them. - Read hw_pte_t through READ_ONCE() before converting it to pte_t. - Drop the previous mremap patch in favour of [a]. Apply [a] first if it is not already present. - Drop the previous two dead-code conversion patches; the affected code was cleaned up separately in [b] and [c]. [a] https://lore.kernel.org/linux-mm/20260720141633.501799-1-agordeev@linux.ibm.com/ [b] https://lore.kernel.org/all/20260730111316.3672672-1-usama.anjum@arm.com [c] https://lore.kernel.org/all/20260730094501.3002718-1-usama.anjum@arm.com --- // SPDX-License-Identifier: GPL-2.0-only /// /// Rename raw PTE pointer types to hardware PTE pointer types. /// /// This is a mechanical type rename. It converts common declarations, /// function parameters, prototypes, return types and casts from "pte_t *" /// to "hw_pte_t *". Plain "pte_t" objects are intentionally left unchanged. /// Pointers named "ptentp" refer to temporary logical PTE values and are /// intentionally ignored in all modes. /// Re-run in context mode afterwards to audit remaining raw pte_t pointers /// and cases that need hand conversion, such as trace macros and mixed /// declarations. /// /// Confidence: Moderate // Options: --no-includes --include-headers virtual patch virtual report virtual context @local_decl depends on patch@ identifier x != ptentp; @@ - pte_t *x; + hw_pte_t *x; @local_decl_init depends on patch@ identifier x != ptentp; expression e; @@ - pte_t *x = e; + hw_pte_t *x = e; @param_proto depends on patch@ identifier f; identifier x != ptentp; type R; @@ R f(..., - pte_t *x + hw_pte_t *x ,...); @param_proto_unnamed depends on patch@ identifier f; type R; @@ R f(..., - pte_t * + hw_pte_t * ,...); @param_def depends on patch@ identifier f; identifier x != ptentp; type R; @@ R f(..., - pte_t *x + hw_pte_t *x ,...) { ... } @ret_proto depends on patch@ identifier f; parameter list ps; @@ - pte_t * + hw_pte_t * f(ps); @ret_def depends on patch@ identifier f; parameter list ps; @@ - pte_t * + hw_pte_t * f(ps) { ... } @struct_member depends on patch@ identifier S; identifier x != ptentp; @@ struct S { ... - pte_t *x; + hw_pte_t *x; ... }; @union_member depends on patch@ identifier x != ptentp; @@ union { ... - pte_t *x; + hw_pte_t *x; ... }; @union_member_in_struct depends on patch@ identifier S; identifier x != ptentp; @@ struct S { ... union { ... - pte_t *x; + hw_pte_t *x; ... }; ... }; @fnptr_struct_member depends on patch@ identifier S,f; identifier x != ptentp; type R; @@ struct S { ... R (*f)(..., - pte_t *x + hw_pte_t *x ,...); ... }; @fnptr_typedef_pte_fn_t depends on patch@ identifier x != ptentp; @@ typedef int (*pte_fn_t)(..., - pte_t *x + hw_pte_t *x ,...); @cast depends on patch@ expression e; @@ - (pte_t *)e + (hw_pte_t *)e @remaining_decl depends on context || report@ identifier x != ptentp; position p; @@ * pte_t *x@p; @remaining_decl_init depends on context || report@ identifier x != ptentp; expression e; position p; @@ * pte_t *x@p = e; @remaining_param_proto depends on context || report@ identifier f; identifier x != ptentp; type R; position p; @@ R f(..., * pte_t *x@p ,...); @remaining_param_proto_unnamed depends on context || report@ identifier f; type R; position p; @@ R f(..., * pte_t *@p ,...); @remaining_param_def depends on context || report@ identifier f; identifier x != ptentp; type R; position p; @@ R f(..., * pte_t *x@p ,...) { ... } @remaining_ret_proto depends on context || report@ identifier f; parameter list ps; position p; @@ * pte_t *f@p(ps); @remaining_ret_def depends on context || report@ identifier f; parameter list ps; position p; @@ * pte_t *f@p(ps) { ... } @remaining_struct_member depends on context || report@ identifier S; identifier x != ptentp; position p; @@ struct S { ... * pte_t *x@p; ... }; @remaining_union_member depends on context || report@ identifier x != ptentp; position p; @@ union { ... * pte_t *x@p; ... }; @remaining_union_member_in_struct depends on context || report@ identifier S; identifier x != ptentp; position p; @@ struct S { ... union { ... * pte_t *x@p; ... }; ... }; @remaining_fnptr_struct_member depends on context || report@ identifier S,f; identifier x != ptentp; type R; position p; @@ struct S { ... R (*f)(..., * pte_t *x@p ,...); ... }; @remaining_fnptr_typedef_pte_fn_t depends on context || report@ identifier x != ptentp; position p; @@ typedef int (*pte_fn_t)(..., * pte_t *x@p ,...); Muhammad Usama Anjum (9): mm: introduce hw_pte_t for PTE table storage mm: make hw_pte_t visible to generic PTE interfaces mm: name pointers to copied PTE values ptentp mm: use hw_pte_t for generic PTE table storage mm: convert PTE table entries in ptep_get() mm: convert PTE table entry to pte mm/kasan: use hw_pte_t for the early shadow PTE table drm/i915: use hw_pte_t for PTE range callbacks xen: use hw_pte_t for PTE range callbacks MAINTAINERS | 1 + .../drm/i915/gem/selftests/i915_gem_mman.c | 4 +- drivers/gpu/drm/i915/i915_mm.c | 4 +- drivers/xen/gntdev.c | 2 +- drivers/xen/privcmd.c | 2 +- drivers/xen/xenbus/xenbus_client.c | 2 +- drivers/xen/xlate_mmu.c | 4 +- fs/hugetlbfs/inode.c | 3 +- fs/proc/task_mmu.c | 33 ++++---- include/asm-generic/hugetlb.h | 15 ++-- include/asm-generic/pgalloc.h | 6 +- include/asm-generic/tlb.h | 5 +- include/linux/hugetlb.h | 52 ++++++------ include/linux/kasan.h | 2 +- include/linux/mm.h | 26 +++--- include/linux/page_table_check.h | 10 ++- include/linux/pagewalk.h | 10 +-- include/linux/pgtable.h | 81 ++++++++++--------- include/linux/pgtable_types.h | 19 +++++ include/linux/rmap.h | 2 +- include/linux/swapops.h | 6 +- include/linux/vmalloc.h | 4 +- include/trace/events/xen.h | 10 +-- kernel/bpf/arena.c | 9 ++- kernel/events/core.c | 3 +- mm/Kconfig | 3 + mm/damon/ops-common.c | 2 +- mm/damon/ops-common.h | 2 +- mm/damon/vaddr.c | 20 ++--- mm/debug_vm_pgtable.c | 2 +- mm/filemap.c | 4 +- mm/gup.c | 9 ++- mm/highmem.c | 15 ++-- mm/hmm.c | 6 +- mm/huge_memory.c | 4 +- mm/hugetlb.c | 60 +++++++------- mm/hugetlb_vmemmap.c | 13 +-- mm/internal.h | 16 ++-- mm/kasan/init.c | 14 ++-- mm/kasan/shadow.c | 6 +- mm/khugepaged.c | 24 +++--- mm/ksm.c | 11 +-- mm/madvise.c | 18 +++-- mm/mapping_dirty_helpers.c | 4 +- mm/memory-failure.c | 6 +- mm/memory.c | 78 +++++++++--------- mm/mempolicy.c | 4 +- mm/migrate.c | 4 +- mm/migrate_device.c | 4 +- mm/mincore.c | 4 +- mm/mlock.c | 4 +- mm/mprotect.c | 19 ++--- mm/mremap.c | 4 +- mm/page_table_check.c | 4 +- mm/pagewalk.c | 9 ++- mm/percpu.c | 2 +- mm/pgtable-generic.c | 20 ++--- mm/ptdump.c | 4 +- mm/rmap.c | 6 +- mm/sparse-vmemmap.c | 24 +++--- mm/swap_state.c | 3 +- mm/swapfile.c | 5 +- mm/userfaultfd.c | 32 ++++---- mm/util.c | 2 +- mm/vmalloc.c | 13 +-- mm/vmscan.c | 6 +- 66 files changed, 437 insertions(+), 368 deletions(-) create mode 100644 include/linux/pgtable_types.h -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384364.1627343 (Exim 4.92) (envelope-from ) id 1wrteB-00072n-8z; Thu, 06 Aug 2026 08:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384364.1627343; Thu, 06 Aug 2026 08:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteB-00072g-5o; Thu, 06 Aug 2026 08:40:15 +0000 Received: by outflank-mailman (input) for mailman id 1384364; Thu, 06 Aug 2026 08:40:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrte9-00071H-6B for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:40:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrte8-00HXWH-J7 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:12 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74486a-2eae-0a2a0a5409dd-0a2a450b8d92-6 for ; Thu, 06 Aug 2026 10:40:11 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a74486a-b7e8-0a2a450b0019-d98c6eacb280-1 for ; Thu, 06 Aug 2026 10:40:11 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E7E7153B; Thu, 6 Aug 2026 01:40:05 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E349C3F632; Thu, 6 Aug 2026 01:40:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005609; bh=iJ1Ndc5V3Xfq1tWscZTZQDNLVYCcoKPyTZqTCUohTZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SCDN3dhSTWUZvm7NxWd7kT2BoSqz+CVAJ52EjmPO3XFFI5DgzdxTKarmA8W7w8CCM vAytJ56KvsfJiBpTM3sWcsX5b4vufVL2p6PVM/2YavA5VjzU41jcEC/tN2j35rLOND s5OV5gCpv0HvNaWN+KVLCNsfqo1phtuKS4Aoj7Iw= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 2/9] mm: make hw_pte_t visible to generic PTE interfaces Date: Thu, 6 Aug 2026 09:38:40 +0100 Message-ID: <20260806083926.1807279-3-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1786005611-A86CA9EA-8529D4D7/0/0 X-purgate-type: clean X-purgate-size: 1999 Later conversions use hw_pte_t in page-table checking, generic page-table helpers, and vmalloc interfaces. Include linux/pgtable_types.h from the headers that declare those interfaces before changing their types. For vmalloc.h, replace the direct asm/page.h include with linux/pgtable_types.h. The latter includes asm/page.h, so pgprot_t remains available. It also provides either the default alias or the opted-in hw_pte_t wrapper. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Clarify that the header provides both generic hw_pte_t definitions. --- include/linux/page_table_check.h | 2 ++ include/linux/pgtable.h | 1 + include/linux/vmalloc.h | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h index 12268a32e8be1..12ee6d16ad339 100644 --- a/include/linux/page_table_check.h +++ b/include/linux/page_table_check.h @@ -7,6 +7,8 @@ #ifndef __LINUX_PAGE_TABLE_CHECK_H #define __LINUX_PAGE_TABLE_CHECK_H +#include + #ifdef CONFIG_PAGE_TABLE_CHECK #include diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 8c093c119e5a8..cf595608cc4c4 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -4,6 +4,7 @@ #include #include +#include #define PMD_ORDER (PMD_SHIFT - PAGE_SHIFT) #define PUD_ORDER (PUD_SHIFT - PAGE_SHIFT) diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index aed121d729b01..b068e6ade4207 100644 --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -8,7 +8,7 @@ #include #include #include -#include /* pgprot_t */ +#include /* pgprot_t, hw_pte_t */ #include #include -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384366.1627352 (Exim 4.92) (envelope-from ) id 1wrteH-0007O3-GC; Thu, 06 Aug 2026 08:40:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384366.1627352; Thu, 06 Aug 2026 08:40:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteH-0007Nq-Cn; Thu, 06 Aug 2026 08:40:21 +0000 Received: by outflank-mailman (input) for mailman id 1384366; Thu, 06 Aug 2026 08:40:19 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteF-0007J6-LW for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:40:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrteF-009i3R-24 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:19 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74486e-5cb7-0a2a0a5109dd-0a2a450c952a-14 for ; Thu, 06 Aug 2026 10:40:19 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a744872-f479-0a2a450c0019-d98c6eacde30-1 for ; Thu, 06 Aug 2026 10:40:18 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8879176C; Thu, 6 Aug 2026 01:40:13 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EF03D3F632; Thu, 6 Aug 2026 01:40:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005617; bh=kDSHwmzLBaSmEkZSi49/oE6mr/pQwSNTv0JlBRbim1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iRLwcLlHzWWbx5Qhr2Q5N2yfBSglhNBHPcd7h0s5kOdYERPY7KTBCkBr+hcYbbhK4 U8v8vfKwbyB14RWAIzfzO9dXyKyK4cPchCL93DUg0JYZDnVP/bmKmDJDFD/ZKVGJnS ia0P1AlmZO2FcO7EoUGQ6dM9k9gIa9RXeahhrylM= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 3/9] mm: name pointers to copied PTE values ptentp Date: Thu, 6 Aug 2026 09:38:41 +0100 Message-ID: <20260806083926.1807279-4-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1786005619-5113AA5B-BC21F25D/0/0 X-purgate-type: clean X-purgate-size: 2575 The hw_pte_t conversion must retain pte_t * for pointers to standalone PTE values. Name the value parameters ptentp in the install_pte callback, write_protect_page(), and guard_install_set_pte() so the later mechanical conversion can distinguish them from pointers to PTE table storage. Some functions already use the ptentp name, including: - madvise_folio_pte_batch() - folio_pte_batch_flags() No need to convert them. This is a naming-only change. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Update the description for the architecture opt-in conversion. --- include/linux/pagewalk.h | 2 +- mm/ksm.c | 4 ++-- mm/madvise.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h index b41d7265c01bc..c34d826c5e4a2 100644 --- a/include/linux/pagewalk.h +++ b/include/linux/pagewalk.h @@ -89,7 +89,7 @@ struct mm_walk_ops { struct mm_walk *walk); void (*post_vma)(struct mm_walk *walk); int (*install_pte)(unsigned long addr, unsigned long next, - pte_t *ptep, struct mm_walk *walk); + pte_t *ptentp, struct mm_walk *walk); enum page_walk_lock walk_lock; }; diff --git a/mm/ksm.c b/mm/ksm.c index ad05d7791307e..11d50518d02e9 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1292,7 +1292,7 @@ static u32 calc_checksum(struct page *page) } static int write_protect_page(struct vm_area_struct *vma, struct folio *folio, - pte_t *orig_pte) + pte_t *ptentp) { struct mm_struct *mm = vma->vm_mm; DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, 0, 0); @@ -1371,7 +1371,7 @@ static int write_protect_page(struct vm_area_struct *vma, struct folio *folio, set_pte_at(mm, pvmw.address, pvmw.pte, entry); } - *orig_pte = entry; + *ptentp = entry; err = 0; out_unlock: diff --git a/mm/madvise.c b/mm/madvise.c index 07a21ca31bad4..c324cc991f841 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1101,12 +1101,12 @@ static int guard_install_pte_entry(pte_t *pte, unsigned long addr, } static int guard_install_set_pte(unsigned long addr, unsigned long next, - pte_t *ptep, struct mm_walk *walk) + pte_t *ptentp, struct mm_walk *walk) { unsigned long *nr_pages = (unsigned long *)walk->private; /* Simply install a PTE marker, this causes segfault on access. */ - *ptep = make_pte_marker(PTE_MARKER_GUARD); + *ptentp = make_pte_marker(PTE_MARKER_GUARD); (*nr_pages)++; return 0; -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384374.1627361 (Exim 4.92) (envelope-from ) id 1wrteP-0007qL-OY; Thu, 06 Aug 2026 08:40:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384374.1627361; Thu, 06 Aug 2026 08:40:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteP-0007pp-JF; Thu, 06 Aug 2026 08:40:29 +0000 Received: by outflank-mailman (input) for mailman id 1384374; Thu, 06 Aug 2026 08:40:29 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteO-0007ot-Qa for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:40:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrteO-00Etan-6x for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:28 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a744870-bab6-0a2a0a5309dd-0a2a45019188-46 for ; Thu, 06 Aug 2026 10:40:28 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a74487a-5984-0a2a45010019-d98c6eacdf26-1 for ; Thu, 06 Aug 2026 10:40:27 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69FED16F2; Thu, 6 Aug 2026 01:40:22 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 07CB63F632; Thu, 6 Aug 2026 01:40:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005626; bh=d6puQD0Mlx5ltItzd5udaSgPV/9XlOWc9bnV0b+nB4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cOeZ8WDEB0HIOoXZjJUkBEVwqKv1KMVSpbMDuFZbx0FnRdsYjSLepXZyHqpvJsuh6 WZa6EuxYoWzXD2kpI13QAxmR890RAa2Lh3SeS+mmMtr+t+8p7GVjpetwVjTSm3dgtR RKhiPlUrHrdv/m9Axp1IccPBL2vZheuHoOXHlCdM= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 4/9] mm: use hw_pte_t for generic PTE table storage Date: Thu, 6 Aug 2026 09:38:42 +0100 Message-ID: <20260806083926.1807279-5-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1786005628-BF0634F7-678253F3/0/0 X-purgate-type: clean X-purgate-size: 122503 Generic page-table interfaces use pte_t * for both pointers to PTE table storage and pointers to standalone PTE values. Convert the generic declarations and their MM, fs, and kernel users together so parameters, return types, callbacks, and local pointers that designate table storage use hw_pte_t *. Keep logical PTE values as pte_t and retain pte_t * for value interfaces. No architecture selects ARCH_HAS_HW_PTE_T at this point, so hw_pte_t remains an alias of pte_t and this changes the interface vocabulary without changing representation or behavior. Most of this mechanical conversion was generated with the Coccinelle script included in the cover letter. The script deliberately ignores pte_t * pointers named ptentp because they designate standalone PTE values. The result was then audited, and sites the script could not convert were updated by hand. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Clarify that the distinct generic definition is activated by an architecture opt-in. --- fs/hugetlbfs/inode.c | 3 +- fs/proc/task_mmu.c | 33 +++++++------- include/asm-generic/hugetlb.h | 15 +++--- include/asm-generic/pgalloc.h | 6 +-- include/asm-generic/tlb.h | 5 +- include/linux/hugetlb.h | 50 +++++++++++--------- include/linux/mm.h | 26 +++++------ include/linux/page_table_check.h | 8 ++-- include/linux/pagewalk.h | 8 ++-- include/linux/pgtable.h | 78 +++++++++++++++++--------------- include/linux/rmap.h | 2 +- include/linux/swapops.h | 6 ++- include/linux/vmalloc.h | 2 +- include/trace/events/xen.h | 10 ++-- kernel/bpf/arena.c | 9 ++-- kernel/events/core.c | 3 +- mm/damon/ops-common.c | 2 +- mm/damon/ops-common.h | 2 +- mm/damon/vaddr.c | 20 ++++---- mm/debug_vm_pgtable.c | 2 +- mm/filemap.c | 4 +- mm/gup.c | 9 ++-- mm/highmem.c | 15 +++--- mm/hmm.c | 6 +-- mm/huge_memory.c | 4 +- mm/hugetlb.c | 60 ++++++++++++------------ mm/hugetlb_vmemmap.c | 13 +++--- mm/internal.h | 16 +++---- mm/kasan/init.c | 12 ++--- mm/kasan/shadow.c | 6 +-- mm/khugepaged.c | 24 +++++----- mm/ksm.c | 7 +-- mm/madvise.c | 14 +++--- mm/mapping_dirty_helpers.c | 4 +- mm/memory-failure.c | 6 +-- mm/memory.c | 78 ++++++++++++++++---------------- mm/mempolicy.c | 4 +- mm/migrate.c | 4 +- mm/migrate_device.c | 4 +- mm/mincore.c | 4 +- mm/mlock.c | 4 +- mm/mprotect.c | 19 ++++---- mm/mremap.c | 4 +- mm/page_table_check.c | 4 +- mm/pagewalk.c | 9 ++-- mm/percpu.c | 2 +- mm/pgtable-generic.c | 20 ++++---- mm/ptdump.c | 2 +- mm/rmap.c | 6 +-- mm/sparse-vmemmap.c | 24 +++++----- mm/swap_state.c | 3 +- mm/swapfile.c | 5 +- mm/userfaultfd.c | 32 +++++++------ mm/util.c | 2 +- mm/vmalloc.c | 13 +++--- mm/vmscan.c | 6 +-- 56 files changed, 391 insertions(+), 348 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index a578fba8e2fca..03a538352229b 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -328,7 +328,8 @@ static void hugetlb_delete_from_page_cache(struct folio *folio) static bool hugetlb_vma_maps_pfn(struct vm_area_struct *vma, unsigned long addr, unsigned long pfn) { - pte_t *ptep, pte; + hw_pte_t *ptep; + pte_t pte; ptep = hugetlb_walk(vma, addr, huge_page_size(hstate_vma(vma))); if (!ptep) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 817e3e0f91943..4118138f08c8e 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1046,7 +1046,7 @@ static void smaps_pte_hole_lookup(unsigned long addr, struct mm_walk *walk) #endif } -static void smaps_pte_entry(pte_t *pte, unsigned long addr, +static void smaps_pte_entry(hw_pte_t *pte, unsigned long addr, struct mm_walk *walk) { struct mem_size_stats *mss = walk->private; @@ -1140,7 +1140,7 @@ static int smaps_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, struct mm_walk *walk) { struct vm_area_struct *vma = walk->vma; - pte_t *pte; + hw_pte_t *pte; spinlock_t *ptl; ptl = pmd_trans_huge_lock(pmd, vma); @@ -1263,7 +1263,7 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) } #ifdef CONFIG_HUGETLB_PAGE -static int smaps_hugetlb_range(pte_t *pte, unsigned long hmask, +static int smaps_hugetlb_range(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { @@ -1704,7 +1704,7 @@ static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, } static inline void clear_soft_dirty(struct vm_area_struct *vma, - unsigned long addr, pte_t *pte) + unsigned long addr, hw_pte_t *pte) { if (!pgtable_supports_soft_dirty()) return; @@ -1772,7 +1772,8 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr, { struct clear_refs_private *cp = walk->private; struct vm_area_struct *vma = walk->vma; - pte_t *pte, ptent; + hw_pte_t *pte; + pte_t ptent; spinlock_t *ptl; struct folio *folio; @@ -2172,7 +2173,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, struct vm_area_struct *vma = walk->vma; struct pagemapread *pm = walk->private; spinlock_t *ptl; - pte_t *pte, *orig_pte; + hw_pte_t *pte, *orig_pte; int err = 0; #ifdef CONFIG_TRANSPARENT_HUGEPAGE @@ -2210,7 +2211,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, #ifdef CONFIG_HUGETLB_PAGE /* This function walks within one hugetlb entry in the single call */ -static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask, +static int pagemap_hugetlb_range(hw_pte_t *ptep, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { @@ -2501,7 +2502,7 @@ static unsigned long pagemap_page_category(struct pagemap_scan_private *p, } static void make_uffd_wp_pte(struct vm_area_struct *vma, - unsigned long addr, pte_t *pte, pte_t ptent) + unsigned long addr, hw_pte_t *pte, pte_t ptent) { if (pte_present(ptent)) { pte_t old_pte; @@ -2634,7 +2635,7 @@ static unsigned long pagemap_hugetlb_category(struct vm_area_struct *vma, } static void make_uffd_wp_huge_pte(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, + unsigned long addr, hw_pte_t *ptep, pte_t ptent) { const unsigned long psize = huge_page_size(hstate_vma(vma)); @@ -2868,7 +2869,7 @@ static int pagemap_scan_pmd_entry(pmd_t *pmd, unsigned long start, struct pagemap_scan_private *p = walk->private; struct vm_area_struct *vma = walk->vma; unsigned long addr, flush_end = 0; - pte_t *pte, *start_pte; + hw_pte_t *pte, *start_pte; spinlock_t *ptl; int ret; @@ -2962,7 +2963,7 @@ static int pagemap_scan_pmd_entry(pmd_t *pmd, unsigned long start, } #ifdef CONFIG_HUGETLB_PAGE -static int pagemap_scan_hugetlb_entry(pte_t *ptep, unsigned long hmask, +static int pagemap_scan_hugetlb_entry(hw_pte_t *ptep, unsigned long hmask, unsigned long start, unsigned long end, struct mm_walk *walk) { @@ -3043,7 +3044,7 @@ static int pagemap_scan_hugetlb_hole_wp(struct vm_area_struct *vma, unsigned long psize = huge_page_size(h); struct mm_struct *mm = vma->vm_mm; spinlock_t *ptl; - pte_t *ptep; + hw_pte_t *ptep; pte_t pte; for (addr = ALIGN_DOWN(addr, psize); addr < end; addr += psize) { @@ -3427,8 +3428,8 @@ static int gather_pte_stats(pmd_t *pmd, unsigned long addr, struct numa_maps *md = walk->private; struct vm_area_struct *vma = walk->vma; spinlock_t *ptl; - pte_t *orig_pte; - pte_t *pte; + hw_pte_t *orig_pte; + hw_pte_t *pte; #ifdef CONFIG_TRANSPARENT_HUGEPAGE ptl = pmd_trans_huge_lock(pmd, vma); @@ -3461,7 +3462,7 @@ static int gather_pte_stats(pmd_t *pmd, unsigned long addr, return 0; } #ifdef CONFIG_HUGETLB_PAGE -static int gather_hugetlb_stats(pte_t *pte, unsigned long hmask, +static int gather_hugetlb_stats(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { pte_t huge_pte; @@ -3484,7 +3485,7 @@ static int gather_hugetlb_stats(pte_t *pte, unsigned long hmask, } #else -static int gather_hugetlb_stats(pte_t *pte, unsigned long hmask, +static int gather_hugetlb_stats(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { return 0; diff --git a/include/asm-generic/hugetlb.h b/include/asm-generic/hugetlb.h index 635c41cc34797..3bfad4a99b64d 100644 --- a/include/asm-generic/hugetlb.h +++ b/include/asm-generic/hugetlb.h @@ -60,7 +60,7 @@ static inline int huge_pte_uffd(pte_t pte) #ifndef __HAVE_ARCH_HUGE_PTE_CLEAR static inline void huge_pte_clear(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, unsigned long sz) + hw_pte_t *ptep, unsigned long sz) { pte_clear(mm, addr, ptep); } @@ -68,7 +68,7 @@ static inline void huge_pte_clear(struct mm_struct *mm, unsigned long addr, #ifndef __HAVE_ARCH_HUGE_SET_HUGE_PTE_AT static inline void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pte, unsigned long sz) + hw_pte_t *ptep, pte_t pte, unsigned long sz) { set_pte_at(mm, addr, ptep, pte); } @@ -76,7 +76,7 @@ static inline void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, #ifndef __HAVE_ARCH_HUGE_PTEP_GET_AND_CLEAR static inline pte_t huge_ptep_get_and_clear(struct mm_struct *mm, - unsigned long addr, pte_t *ptep, unsigned long sz) + unsigned long addr, hw_pte_t *ptep, unsigned long sz) { return ptep_get_and_clear(mm, addr, ptep); } @@ -84,7 +84,7 @@ static inline pte_t huge_ptep_get_and_clear(struct mm_struct *mm, #ifndef __HAVE_ARCH_HUGE_PTEP_CLEAR_FLUSH static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep) + unsigned long addr, hw_pte_t *ptep) { return ptep_clear_flush(vma, addr, ptep); } @@ -99,7 +99,7 @@ static inline int huge_pte_none(pte_t pte) #ifndef __HAVE_ARCH_HUGE_PTEP_SET_WRPROTECT static inline void huge_ptep_set_wrprotect(struct mm_struct *mm, - unsigned long addr, pte_t *ptep) + unsigned long addr, hw_pte_t *ptep) { ptep_set_wrprotect(mm, addr, ptep); } @@ -107,7 +107,7 @@ static inline void huge_ptep_set_wrprotect(struct mm_struct *mm, #ifndef __HAVE_ARCH_HUGE_PTEP_SET_ACCESS_FLAGS static inline int huge_ptep_set_access_flags(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, + unsigned long addr, hw_pte_t *ptep, pte_t pte, int dirty) { return ptep_set_access_flags(vma, addr, ptep, pte, dirty); @@ -115,7 +115,8 @@ static inline int huge_ptep_set_access_flags(struct vm_area_struct *vma, #endif #ifndef __HAVE_ARCH_HUGE_PTEP_GET -static inline pte_t huge_ptep_get(struct mm_struct *mm, unsigned long addr, pte_t *ptep) +static inline pte_t huge_ptep_get(struct mm_struct *mm, unsigned long addr, + hw_pte_t *ptep) { return ptep_get(ptep); } diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h index 051aa1331051c..b35e5a2158ada 100644 --- a/include/asm-generic/pgalloc.h +++ b/include/asm-generic/pgalloc.h @@ -16,7 +16,7 @@ * * Return: pointer to the allocated memory or %NULL on error */ -static inline pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm) +static inline hw_pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm) { struct ptdesc *ptdesc = pagetable_alloc_noprof(GFP_PGTABLE_KERNEL, 0); @@ -40,7 +40,7 @@ static inline pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm) * * Return: pointer to the allocated memory or %NULL on error */ -static inline pte_t *pte_alloc_one_kernel_noprof(struct mm_struct *mm) +static inline hw_pte_t *pte_alloc_one_kernel_noprof(struct mm_struct *mm) { return __pte_alloc_one_kernel_noprof(mm); } @@ -52,7 +52,7 @@ static inline pte_t *pte_alloc_one_kernel_noprof(struct mm_struct *mm) * @mm: the mm_struct of the current context * @pte: pointer to the memory containing the page table */ -static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) +static inline void pte_free_kernel(struct mm_struct *mm, hw_pte_t *pte) { pagetable_dtor_free(virt_to_ptdesc(pte)); } diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index bdcc2778ac64f..2c3517800a9a8 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -644,7 +644,8 @@ static inline void tlb_flush_p4d_range(struct mmu_gather *tlb, } #ifndef __tlb_remove_tlb_entry -static inline void __tlb_remove_tlb_entry(struct mmu_gather *tlb, pte_t *ptep, unsigned long address) +static inline void __tlb_remove_tlb_entry(struct mmu_gather *tlb, + hw_pte_t *ptep, unsigned long address) { } #endif @@ -670,7 +671,7 @@ static inline void __tlb_remove_tlb_entry(struct mmu_gather *tlb, pte_t *ptep, u * consecutive ptes instead of only a single one. */ static inline void tlb_remove_tlb_entries(struct mmu_gather *tlb, - pte_t *ptep, unsigned int nr, unsigned long address) + hw_pte_t *ptep, unsigned int nr, unsigned long address) { tlb_flush_pte_range(tlb, address, PAGE_SIZE * nr); for (;;) { diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 16c4c4caa126c..bc0b9c65aa1d0 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -141,7 +141,7 @@ unsigned long hugetlb_total_pages(void); vm_fault_t hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long address, unsigned int flags); #ifdef CONFIG_USERFAULTFD -int hugetlb_mfill_atomic_pte(pte_t *dst_pte, +int hugetlb_mfill_atomic_pte(hw_pte_t *dst_pte, struct vm_area_struct *dst_vma, unsigned long dst_addr, unsigned long src_addr, @@ -161,7 +161,7 @@ void hugetlb_fix_reserve_counts(struct inode *inode); extern struct mutex *hugetlb_fault_mutex_table; u32 hugetlb_fault_mutex_hash(struct address_space *mapping, pgoff_t idx); -pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, +hw_pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, pud_t *pud); bool hugetlbfs_pagecache_present(struct hstate *h, struct vm_area_struct *vma, @@ -186,22 +186,22 @@ void hugetlb_bootmem_set_nodes(void); * which may go down to the lowest PTE level in their huge_pte_offset() and * huge_pte_alloc(): to avoid reliance on pte_offset_map() without pte_unmap(). */ -static inline pte_t *pte_offset_huge(pmd_t *pmd, unsigned long address) +static inline hw_pte_t *pte_offset_huge(pmd_t *pmd, unsigned long address) { return pte_offset_kernel(pmd, address); } -static inline pte_t *pte_alloc_huge(struct mm_struct *mm, pmd_t *pmd, +static inline hw_pte_t *pte_alloc_huge(struct mm_struct *mm, pmd_t *pmd, unsigned long address) { return pte_alloc(mm, pmd) ? NULL : pte_offset_huge(pmd, address); } #endif -pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, +hw_pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, unsigned long sz); /* * huge_pte_offset(): Walk the hugetlb pgtable until the last level PTE. - * Returns the pte_t* if found, or NULL if the address is not mapped. + * Returns the hw_pte_t* if found, or NULL if the address is not mapped. * * IMPORTANT: we should normally not directly call this function, instead * this is only a common interface to implement arch-specific @@ -236,11 +236,11 @@ pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, * a concurrent pmd unshare, but it makes sure the pgtable page is safe to * access. */ -pte_t *huge_pte_offset(struct mm_struct *mm, +hw_pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr, unsigned long sz); unsigned long hugetlb_mask_last_page(struct hstate *h); int huge_pmd_unshare(struct mmu_gather *tlb, struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep); + unsigned long addr, hw_pte_t *ptep); void huge_pmd_unshare_flush(struct mmu_gather *tlb, struct vm_area_struct *vma); void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma, unsigned long *start, unsigned long *end); @@ -302,7 +302,8 @@ static inline struct address_space *hugetlb_folio_mapping_lock_write( } static inline int huge_pmd_unshare(struct mmu_gather *tlb, - struct vm_area_struct *vma, unsigned long addr, pte_t *ptep) + struct vm_area_struct *vma, unsigned long addr, + hw_pte_t *ptep) { return 0; } @@ -394,7 +395,7 @@ static inline int is_hugepage_only_range(struct mm_struct *mm, } #ifdef CONFIG_USERFAULTFD -static inline int hugetlb_mfill_atomic_pte(pte_t *dst_pte, +static inline int hugetlb_mfill_atomic_pte(hw_pte_t *dst_pte, struct vm_area_struct *dst_vma, unsigned long dst_addr, unsigned long src_addr, @@ -406,7 +407,7 @@ static inline int hugetlb_mfill_atomic_pte(pte_t *dst_pte, } #endif /* CONFIG_USERFAULTFD */ -static inline pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr, +static inline hw_pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr, unsigned long sz) { return NULL; @@ -989,7 +990,8 @@ static inline bool htlb_allow_alloc_fallback(enum migrate_reason reason) } static inline spinlock_t *huge_pte_lockptr(struct hstate *h, - struct mm_struct *mm, pte_t *pte) + struct mm_struct *mm, + hw_pte_t *pte) { const unsigned long size = huge_page_size(h); @@ -1053,7 +1055,8 @@ static inline void hugetlb_count_sub(long l, struct mm_struct *mm) #ifndef huge_ptep_modify_prot_start #define huge_ptep_modify_prot_start huge_ptep_modify_prot_start static inline pte_t huge_ptep_modify_prot_start(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep) + unsigned long addr, + hw_pte_t *ptep) { unsigned long psize = huge_page_size(hstate_vma(vma)); @@ -1064,7 +1067,8 @@ static inline pte_t huge_ptep_modify_prot_start(struct vm_area_struct *vma, #ifndef huge_ptep_modify_prot_commit #define huge_ptep_modify_prot_commit huge_ptep_modify_prot_commit static inline void huge_ptep_modify_prot_commit(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, + unsigned long addr, + hw_pte_t *ptep, pte_t old_pte, pte_t pte) { unsigned long psize = huge_page_size(hstate_vma(vma)); @@ -1252,7 +1256,8 @@ static inline bool htlb_allow_alloc_fallback(enum migrate_reason reason) } static inline spinlock_t *huge_pte_lockptr(struct hstate *h, - struct mm_struct *mm, pte_t *pte) + struct mm_struct *mm, + hw_pte_t *pte) { return &mm->page_table_lock; } @@ -1269,11 +1274,11 @@ static inline void hugetlb_count_sub(long l, struct mm_struct *mm) { } -pte_t huge_ptep_get(struct mm_struct *mm, unsigned long addr, pte_t *ptep); +pte_t huge_ptep_get(struct mm_struct *mm, unsigned long addr, hw_pte_t *ptep); unsigned long huge_pte_dirty(pte_t pte); static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep) + unsigned long addr, hw_pte_t *ptep) { #ifdef CONFIG_MMU return ptep_get(ptep); @@ -1283,7 +1288,8 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, } static inline void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pte, unsigned long sz) + hw_pte_t *ptep, pte_t pte, + unsigned long sz) { } @@ -1311,7 +1317,7 @@ static inline void hugetlb_bootmem_struct_page_init(void) #endif /* CONFIG_HUGETLB_PAGE */ static inline spinlock_t *huge_pte_lock(struct hstate *h, - struct mm_struct *mm, pte_t *pte) + struct mm_struct *mm, hw_pte_t *pte) { spinlock_t *ptl; @@ -1329,12 +1335,12 @@ static inline __init void hugetlb_cma_reserve(void) #endif #ifdef CONFIG_HUGETLB_PMD_PAGE_TABLE_SHARING -static inline bool hugetlb_pmd_shared(pte_t *pte) +static inline bool hugetlb_pmd_shared(hw_pte_t *pte) { return ptdesc_pmd_is_shared(virt_to_ptdesc(pte)); } #else -static inline bool hugetlb_pmd_shared(pte_t *pte) +static inline bool hugetlb_pmd_shared(hw_pte_t *pte) { return false; } @@ -1361,7 +1367,7 @@ bool __vma_private_lock(struct vm_area_struct *vma); * Safe version of huge_pte_offset() to check the locks. See comments * above huge_pte_offset(). */ -static inline pte_t * +static inline hw_pte_t * hugetlb_walk(struct vm_area_struct *vma, unsigned long addr, unsigned long sz) { #if defined(CONFIG_HUGETLB_PMD_PAGE_TABLE_SHARING) && defined(CONFIG_LOCKDEP) diff --git a/include/linux/mm.h b/include/linux/mm.h index 7fabe6c66b4b7..f41441c4a5a3b 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -782,7 +782,7 @@ struct vm_fault { * VM_FAULT_ERROR). */ /* These three entries are valid only while holding ptl lock */ - pte_t *pte; /* Pointer to pte entry matching + hw_pte_t *pte; /* Pointer to pte entry matching * the 'address'. NULL if the page * table hasn't been allocated. */ @@ -3188,7 +3188,7 @@ struct follow_pfnmap_args { * The caller shouldn't touch any of these. */ spinlock_t *lock; - pte_t *ptep; + hw_pte_t *ptep; /** * Outputs: * @@ -3525,7 +3525,7 @@ static inline pud_t pud_mkspecial(pud_t pud) } #endif /* CONFIG_ARCH_SUPPORTS_PUD_PFNMAP */ -extern pte_t *get_locked_pte(struct mm_struct *mm, unsigned long addr, +extern hw_pte_t *get_locked_pte(struct mm_struct *mm, unsigned long addr, spinlock_t **ptl); #ifdef __PAGETABLE_P4D_FOLDED @@ -3803,7 +3803,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); } -static inline spinlock_t *ptep_lockptr(struct mm_struct *mm, pte_t *pte) +static inline spinlock_t *ptep_lockptr(struct mm_struct *mm, hw_pte_t *pte) { BUILD_BUG_ON(IS_ENABLED(CONFIG_HIGHPTE)); BUILD_BUG_ON(MAX_PTRS_PER_PTE * sizeof(pte_t) > PAGE_SIZE); @@ -3834,7 +3834,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) { return &mm->page_table_lock; } -static inline spinlock_t *ptep_lockptr(struct mm_struct *mm, pte_t *pte) +static inline spinlock_t *ptep_lockptr(struct mm_struct *mm, hw_pte_t *pte) { return &mm->page_table_lock; } @@ -3875,19 +3875,19 @@ static inline bool pagetable_pte_ctor(struct mm_struct *mm, return true; } -pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp); +hw_pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp); -static inline pte_t *pte_offset_map(pmd_t *pmd, unsigned long addr) +static inline hw_pte_t *pte_offset_map(pmd_t *pmd, unsigned long addr) { return __pte_offset_map(pmd, addr, NULL); } -pte_t *pte_offset_map_lock(struct mm_struct *mm, pmd_t *pmd, +hw_pte_t *pte_offset_map_lock(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, spinlock_t **ptlp); -pte_t *pte_offset_map_ro_nolock(struct mm_struct *mm, pmd_t *pmd, +hw_pte_t *pte_offset_map_ro_nolock(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, spinlock_t **ptlp); -pte_t *pte_offset_map_rw_nolock(struct mm_struct *mm, pmd_t *pmd, +hw_pte_t *pte_offset_map_rw_nolock(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp, spinlock_t **ptlp); @@ -4836,7 +4836,7 @@ static inline bool gup_can_follow_protnone(const struct vm_area_struct *vma, return !vma_is_accessible(vma); } -typedef int (*pte_fn_t)(pte_t *pte, unsigned long addr, void *data); +typedef int (*pte_fn_t)(hw_pte_t *pte, unsigned long addr, void *data); extern int apply_to_page_range(struct mm_struct *mm, unsigned long address, unsigned long size, pte_fn_t fn, void *data); extern int apply_to_existing_page_range(struct mm_struct *mm, @@ -5086,7 +5086,7 @@ void *vmemmap_alloc_block(unsigned long size, int node); struct vmem_altmap; void *vmemmap_alloc_block_buf(unsigned long size, int node, struct vmem_altmap *altmap); -void vmemmap_verify(pte_t *, int, unsigned long, unsigned long); +void vmemmap_verify(hw_pte_t *, int, unsigned long, unsigned long); void vmemmap_set_pmd(pmd_t *pmd, void *p, int node, unsigned long addr, unsigned long next); int vmemmap_check_pmd(pmd_t *pmd, int node, @@ -5454,7 +5454,7 @@ static inline bool snapshot_page_is_faithful(const struct page_snapshot *ps) void snapshot_page(struct page_snapshot *ps, const struct page *page); -void map_anon_folio_pte_nopf(struct folio *folio, pte_t *pte, +void map_anon_folio_pte_nopf(struct folio *folio, hw_pte_t *pte, struct vm_area_struct *vma, unsigned long addr, bool uffd_wp); diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h index 12ee6d16ad339..933c1028c2232 100644 --- a/include/linux/page_table_check.h +++ b/include/linux/page_table_check.h @@ -23,7 +23,7 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, pud_t pud); void __page_table_check_ptes_set(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pte, unsigned int nr); + hw_pte_t *ptep, pte_t pte, unsigned int nr); void __page_table_check_pmds_set(struct mm_struct *mm, unsigned long addr, pmd_t *pmdp, pmd_t pmd, unsigned int nr); void __page_table_check_puds_set(struct mm_struct *mm, unsigned long addr, @@ -76,7 +76,8 @@ static inline void page_table_check_pud_clear(struct mm_struct *mm, } static inline void page_table_check_ptes_set(struct mm_struct *mm, - unsigned long addr, pte_t *ptep, + unsigned long addr, + hw_pte_t *ptep, pte_t pte, unsigned int nr) { if (static_branch_likely(&page_table_check_disabled)) @@ -139,7 +140,8 @@ static inline void page_table_check_pud_clear(struct mm_struct *mm, } static inline void page_table_check_ptes_set(struct mm_struct *mm, - unsigned long addr, pte_t *ptep, + unsigned long addr, + hw_pte_t *ptep, pte_t pte, unsigned int nr) { } diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h index c34d826c5e4a2..7ab2eb39e02c0 100644 --- a/include/linux/pagewalk.h +++ b/include/linux/pagewalk.h @@ -38,7 +38,7 @@ enum page_walk_lock { * not trigger for any populated ranges. * @hugetlb_entry: if set, called for each hugetlb entry. This hook * function is called with the vma lock held, in order to - * protect against a concurrent freeing of the pte_t* or + * protect against a concurrent freeing of the hw_pte_t* or * the ptl. In some cases, the hook function needs to drop * and retake the vma lock in order to avoid deadlocks * while calling other functions. In such cases the hook @@ -76,11 +76,11 @@ struct mm_walk_ops { unsigned long next, struct mm_walk *walk); int (*pmd_entry)(pmd_t *pmd, unsigned long addr, unsigned long next, struct mm_walk *walk); - int (*pte_entry)(pte_t *pte, unsigned long addr, + int (*pte_entry)(hw_pte_t *pte, unsigned long addr, unsigned long next, struct mm_walk *walk); int (*pte_hole)(unsigned long addr, unsigned long next, int depth, struct mm_walk *walk); - int (*hugetlb_entry)(pte_t *pte, unsigned long hmask, + int (*hugetlb_entry)(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long next, struct mm_walk *walk); int (*test_walk)(unsigned long addr, unsigned long next, @@ -173,7 +173,7 @@ struct folio_walk { struct page *page; enum folio_walk_level level; union { - pte_t *ptep; + hw_pte_t *ptep; pud_t *pudp; pmd_t *pmdp; }; diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index cf595608cc4c4..dad80d264aac2 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -94,26 +94,26 @@ static inline void pud_init(void *addr) #endif #ifndef pte_offset_kernel -static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address) +static inline hw_pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address) { - return (pte_t *)pmd_page_vaddr(*pmd) + pte_index(address); + return (hw_pte_t *)pmd_page_vaddr(*pmd) + pte_index(address); } #define pte_offset_kernel pte_offset_kernel #endif #ifdef CONFIG_HIGHPTE #define __pte_map(pmd, address) \ - ((pte_t *)kmap_local_page(pmd_page(*(pmd))) + pte_index((address))) + ((hw_pte_t *)kmap_local_page(pmd_page(*(pmd))) + pte_index((address))) #define pte_unmap(pte) do { \ kunmap_local((pte)); \ rcu_read_unlock(); \ } while (0) #else -static inline pte_t *__pte_map(pmd_t *pmd, unsigned long address) +static inline hw_pte_t *__pte_map(pmd_t *pmd, unsigned long address) { return pte_offset_kernel(pmd, address); } -static inline void pte_unmap(pte_t *pte) +static inline void pte_unmap(hw_pte_t *pte) { rcu_read_unlock(); } @@ -173,7 +173,7 @@ static inline pmd_t *pmd_off_k(unsigned long va) return pmd_offset(pud_offset(p4d_offset(pgd_offset_k(va), va), va), va); } -static inline pte_t *virt_to_kpte(unsigned long vaddr) +static inline hw_pte_t *virt_to_kpte(unsigned long vaddr) { pmd_t *pmd = pmd_off_k(vaddr); @@ -408,7 +408,7 @@ static inline void lazy_mmu_mode_resume(void) {} * * May be overridden by the architecture, else pte_batch_hint is always 1. */ -static inline unsigned int pte_batch_hint(pte_t *ptep, pte_t pte) +static inline unsigned int pte_batch_hint(hw_pte_t *ptep, pte_t pte) { return 1; } @@ -443,7 +443,7 @@ static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) * to the same folio. The PTEs are all in the same PMD. */ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pte, unsigned int nr) + hw_pte_t *ptep, pte_t pte, unsigned int nr) { page_table_check_ptes_set(mm, addr, ptep, pte, nr); @@ -460,7 +460,7 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, #ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS extern int ptep_set_access_flags(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep, + unsigned long address, hw_pte_t *ptep, pte_t entry, int dirty); #endif @@ -491,7 +491,7 @@ static inline int pudp_set_access_flags(struct vm_area_struct *vma, #endif #ifndef ptep_get -static inline pte_t ptep_get(pte_t *ptep) +static inline pte_t ptep_get(hw_pte_t *ptep) { return READ_ONCE(*ptep); } @@ -527,7 +527,7 @@ static inline pgd_t pgdp_get(pgd_t *pgdp) #ifndef __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG static inline bool ptep_test_and_clear_young(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep) + unsigned long address, hw_pte_t *ptep) { pte_t pte = ptep_get(ptep); bool young = true; @@ -566,7 +566,7 @@ static inline bool pmdp_test_and_clear_young(struct vm_area_struct *vma, #ifndef __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH bool ptep_clear_flush_young(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep); + unsigned long address, hw_pte_t *ptep); #endif #ifndef __HAVE_ARCH_PMDP_CLEAR_YOUNG_FLUSH @@ -645,7 +645,7 @@ static inline void arch_check_zapped_pud(struct vm_area_struct *vma, pud_t pud) #ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR static inline pte_t ptep_get_and_clear(struct mm_struct *mm, unsigned long address, - pte_t *ptep) + hw_pte_t *ptep) { pte_t pte = ptep_get(ptep); pte_clear(mm, address, ptep); @@ -674,7 +674,7 @@ static inline pte_t ptep_get_and_clear(struct mm_struct *mm, * pages that belong to the same folio. The PTEs are all in the same PMD. */ static inline void clear_young_dirty_ptes(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, + unsigned long addr, hw_pte_t *ptep, unsigned int nr, cydp_t flags) { pte_t pte; @@ -699,7 +699,7 @@ static inline void clear_young_dirty_ptes(struct vm_area_struct *vma, #endif static inline void ptep_clear(struct mm_struct *mm, unsigned long addr, - pte_t *ptep) + hw_pte_t *ptep) { pte_t pte = ptep_get(ptep); @@ -740,7 +740,7 @@ static inline void ptep_clear(struct mm_struct *mm, unsigned long addr, * present bit set *unless* it is 'l'. Because get_user_pages_fast() only * operates on present ptes we're safe. */ -static inline pte_t ptep_get_lockless(pte_t *ptep) +static inline pte_t ptep_get_lockless(hw_pte_t *ptep) { pte_t pte; @@ -778,7 +778,7 @@ static inline pmd_t pmdp_get_lockless(pmd_t *pmdp) * We require that the PTE can be read atomically. */ #ifndef ptep_get_lockless -static inline pte_t ptep_get_lockless(pte_t *ptep) +static inline pte_t ptep_get_lockless(hw_pte_t *ptep) { return ptep_get(ptep); } @@ -845,7 +845,8 @@ static inline pud_t pudp_huge_get_and_clear_full(struct vm_area_struct *vma, #ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR_FULL static inline pte_t ptep_get_and_clear_full(struct mm_struct *mm, - unsigned long address, pte_t *ptep, + unsigned long address, + hw_pte_t *ptep, int full) { return ptep_get_and_clear(mm, address, ptep); @@ -873,7 +874,7 @@ static inline pte_t ptep_get_and_clear_full(struct mm_struct *mm, * pages that belong to the same folio. The PTEs are all in the same PMD. */ static inline pte_t get_and_clear_full_ptes(struct mm_struct *mm, - unsigned long addr, pte_t *ptep, unsigned int nr, int full) + unsigned long addr, hw_pte_t *ptep, unsigned int nr, int full) { pte_t pte, tmp_pte; @@ -909,7 +910,7 @@ static inline pte_t get_and_clear_full_ptes(struct mm_struct *mm, * pages that belong to the same folio. The PTEs are all in the same PMD. */ static inline pte_t get_and_clear_ptes(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, unsigned int nr) + hw_pte_t *ptep, unsigned int nr) { return get_and_clear_full_ptes(mm, addr, ptep, nr, 0); } @@ -934,7 +935,7 @@ static inline pte_t get_and_clear_ptes(struct mm_struct *mm, unsigned long addr, * pages that belong to the same folio. The PTEs are all in the same PMD. */ static inline void clear_full_ptes(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, unsigned int nr, int full) + hw_pte_t *ptep, unsigned int nr, int full) { for (;;) { ptep_get_and_clear_full(mm, addr, ptep, full); @@ -963,7 +964,7 @@ static inline void clear_full_ptes(struct mm_struct *mm, unsigned long addr, * pages that belong to the same folio. The PTEs are all in the same PMD. */ static inline void clear_ptes(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, unsigned int nr) + hw_pte_t *ptep, unsigned int nr) { clear_full_ptes(mm, addr, ptep, nr, 0); } @@ -978,13 +979,14 @@ static inline void clear_ptes(struct mm_struct *mm, unsigned long addr, */ #ifndef update_mmu_tlb_range static inline void update_mmu_tlb_range(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep, unsigned int nr) + unsigned long address, hw_pte_t *ptep, + unsigned int nr) { } #endif static inline void update_mmu_tlb(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep) + unsigned long address, hw_pte_t *ptep) { update_mmu_tlb_range(vma, address, ptep, 1); } @@ -1001,7 +1003,7 @@ static inline void update_mmu_tlb(struct vm_area_struct *vma, * The PTEs are all in the same PMD. */ static inline void clear_nonpresent_ptes(struct mm_struct *mm, - unsigned long addr, pte_t *ptep, unsigned int nr) + unsigned long addr, hw_pte_t *ptep, unsigned int nr) { (void)addr; @@ -1017,7 +1019,7 @@ static inline void clear_nonpresent_ptes(struct mm_struct *mm, #ifndef __HAVE_ARCH_PTEP_CLEAR_FLUSH extern pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address, - pte_t *ptep); + hw_pte_t *ptep); #endif #ifndef __HAVE_ARCH_PMDP_HUGE_CLEAR_FLUSH @@ -1045,7 +1047,8 @@ static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) #ifndef __HAVE_ARCH_PTEP_SET_WRPROTECT struct mm_struct; -static inline void ptep_set_wrprotect(struct mm_struct *mm, unsigned long address, pte_t *ptep) +static inline void ptep_set_wrprotect(struct mm_struct *mm, unsigned long address, + hw_pte_t *ptep) { pte_t old_pte = ptep_get(ptep); set_pte_at(mm, address, ptep, pte_wrprotect(old_pte)); @@ -1071,7 +1074,7 @@ static inline void ptep_set_wrprotect(struct mm_struct *mm, unsigned long addres * ptep_try_set as an identity macro. The generic stub returns false, which is * correct for callers that fall through to oops on failure. */ -static inline bool ptep_try_set(pte_t *ptep, pte_t new_pte) +static inline bool ptep_try_set(hw_pte_t *ptep, pte_t new_pte) { return false; } @@ -1114,7 +1117,7 @@ static inline void flush_tlb_before_set(unsigned long addr) * pages that belong to the same folio. The PTEs are all in the same PMD. */ static inline void wrprotect_ptes(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, unsigned int nr) + hw_pte_t *ptep, unsigned int nr) { for (;;) { ptep_set_wrprotect(mm, addr, ptep); @@ -1145,7 +1148,7 @@ static inline void wrprotect_ptes(struct mm_struct *mm, unsigned long addr, * pages that belong to the same folio. The PTEs are all in the same PMD. */ static inline bool clear_flush_young_ptes(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, unsigned int nr) + unsigned long addr, hw_pte_t *ptep, unsigned int nr) { bool young = false; @@ -1182,7 +1185,7 @@ static inline bool clear_flush_young_ptes(struct vm_area_struct *vma, * Returns: whether any PTE was young. */ static inline bool test_and_clear_young_ptes(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, unsigned int nr) + unsigned long addr, hw_pte_t *ptep, unsigned int nr) { bool young = false; @@ -1586,7 +1589,7 @@ static inline int pmd_none_or_clear_bad(pmd_t *pmd) static inline pte_t __ptep_modify_prot_start(struct vm_area_struct *vma, unsigned long addr, - pte_t *ptep) + hw_pte_t *ptep) { /* * Get the current pte state, but zero it out to make it @@ -1598,7 +1601,7 @@ static inline pte_t __ptep_modify_prot_start(struct vm_area_struct *vma, static inline void __ptep_modify_prot_commit(struct vm_area_struct *vma, unsigned long addr, - pte_t *ptep, pte_t pte) + hw_pte_t *ptep, pte_t pte) { /* * The pte is non-present, so there's no hardware state to @@ -1624,7 +1627,7 @@ static inline void __ptep_modify_prot_commit(struct vm_area_struct *vma, */ static inline pte_t ptep_modify_prot_start(struct vm_area_struct *vma, unsigned long addr, - pte_t *ptep) + hw_pte_t *ptep) { return __ptep_modify_prot_start(vma, addr, ptep); } @@ -1637,7 +1640,8 @@ static inline pte_t ptep_modify_prot_start(struct vm_area_struct *vma, */ static inline void ptep_modify_prot_commit(struct vm_area_struct *vma, unsigned long addr, - pte_t *ptep, pte_t old_pte, pte_t pte) + hw_pte_t *ptep, pte_t old_pte, + pte_t pte) { __ptep_modify_prot_commit(vma, addr, ptep, pte); } @@ -1668,7 +1672,7 @@ static inline void ptep_modify_prot_commit(struct vm_area_struct *vma, */ #ifndef modify_prot_start_ptes static inline pte_t modify_prot_start_ptes(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, unsigned int nr) + unsigned long addr, hw_pte_t *ptep, unsigned int nr) { pte_t pte, tmp_pte; @@ -1708,7 +1712,7 @@ static inline pte_t modify_prot_start_ptes(struct vm_area_struct *vma, */ #ifndef modify_prot_commit_ptes static inline void modify_prot_commit_ptes(struct vm_area_struct *vma, unsigned long addr, - pte_t *ptep, pte_t old_pte, pte_t pte, unsigned int nr) + hw_pte_t *ptep, pte_t old_pte, pte_t pte, unsigned int nr) { int i; diff --git a/include/linux/rmap.h b/include/linux/rmap.h index a174758f77775..1fc64074283d6 100644 --- a/include/linux/rmap.h +++ b/include/linux/rmap.h @@ -868,7 +868,7 @@ struct page_vma_mapped_walk { struct vm_area_struct *vma; unsigned long address; pmd_t *pmd; - pte_t *pte; + hw_pte_t *pte; spinlock_t *ptl; unsigned int flags; bool is_anon_walk; diff --git a/include/linux/swapops.h b/include/linux/swapops.h index c956bc445ee01..aeba03c96da1f 100644 --- a/include/linux/swapops.h +++ b/include/linux/swapops.h @@ -215,7 +215,8 @@ static inline swp_entry_t make_migration_entry_dirty(swp_entry_t entry) extern void migration_entry_wait(struct mm_struct *mm, pmd_t *pmd, unsigned long address); -extern void migration_entry_wait_huge(struct vm_area_struct *vma, unsigned long addr, pte_t *pte); +extern void migration_entry_wait_huge(struct vm_area_struct *vma, unsigned long addr, + hw_pte_t *pte); #else /* CONFIG_MIGRATION */ static inline swp_entry_t make_readable_migration_entry(pgoff_t offset) { @@ -235,7 +236,8 @@ static inline swp_entry_t make_writable_migration_entry(pgoff_t offset) static inline void migration_entry_wait(struct mm_struct *mm, pmd_t *pmd, unsigned long address) { } static inline void migration_entry_wait_huge(struct vm_area_struct *vma, - unsigned long addr, pte_t *pte) { } + unsigned long addr, + hw_pte_t *pte) { } static inline swp_entry_t make_migration_entry_young(swp_entry_t entry) { diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index b068e6ade4207..666ff2b3741da 100644 --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -120,7 +120,7 @@ static inline unsigned long arch_vmap_pte_range_map_size(unsigned long addr, uns #ifndef arch_vmap_pte_range_unmap_size static inline unsigned long arch_vmap_pte_range_unmap_size(unsigned long addr, - pte_t *ptep) + hw_pte_t *ptep) { return PAGE_SIZE; } diff --git a/include/trace/events/xen.h b/include/trace/events/xen.h index ad384969e2cb2..1972d50b043a5 100644 --- a/include/trace/events/xen.h +++ b/include/trace/events/xen.h @@ -138,10 +138,10 @@ TRACE_EVENT(xen_mc_extend_args, TRACE_DEFINE_SIZEOF(pteval_t); TRACE_EVENT(xen_mmu_set_pte, - TP_PROTO(pte_t *ptep, pte_t pteval), + TP_PROTO(hw_pte_t *ptep, pte_t pteval), TP_ARGS(ptep, pteval), TP_STRUCT__entry( - __field(pte_t *, ptep) + __field(hw_pte_t *, ptep) __field(pteval_t, pteval) ), TP_fast_assign(__entry->ptep = ptep; @@ -207,12 +207,12 @@ TRACE_EVENT(xen_mmu_set_p4d, DECLARE_EVENT_CLASS(xen_mmu_ptep_modify_prot, TP_PROTO(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pteval), + hw_pte_t *ptep, pte_t pteval), TP_ARGS(mm, addr, ptep, pteval), TP_STRUCT__entry( __field(struct mm_struct *, mm) __field(unsigned long, addr) - __field(pte_t *, ptep) + __field(hw_pte_t *, ptep) __field(pteval_t, pteval) ), TP_fast_assign(__entry->mm = mm; @@ -227,7 +227,7 @@ DECLARE_EVENT_CLASS(xen_mmu_ptep_modify_prot, #define DEFINE_XEN_MMU_PTEP_MODIFY_PROT(name) \ DEFINE_EVENT(xen_mmu_ptep_modify_prot, name, \ TP_PROTO(struct mm_struct *mm, unsigned long addr, \ - pte_t *ptep, pte_t pteval), \ + hw_pte_t *ptep, pte_t pteval), \ TP_ARGS(mm, addr, ptep, pteval)) DEFINE_XEN_MMU_PTEP_MODIFY_PROT(xen_mmu_ptep_modify_prot_start); diff --git a/kernel/bpf/arena.c b/kernel/bpf/arena.c index 80b7b8a694464..c554c07b15592 100644 --- a/kernel/bpf/arena.c +++ b/kernel/bpf/arena.c @@ -153,7 +153,7 @@ struct clear_range_data { struct page *scratch_page; }; -static int apply_range_set_cb(pte_t *pte, unsigned long addr, void *data) +static int apply_range_set_cb(hw_pte_t *pte, unsigned long addr, void *data) { struct apply_range_data *d = data; struct page *page; @@ -204,7 +204,7 @@ static void flush_vmap_cache(unsigned long start, unsigned long size) flush_cache_vmap(start, start + size); } -static int apply_range_clear_cb(pte_t *pte, unsigned long addr, void *data) +static int apply_range_clear_cb(hw_pte_t *pte, unsigned long addr, void *data) { struct clear_range_data *d = data; pte_t old_pte; @@ -234,7 +234,8 @@ static int apply_range_clear_cb(pte_t *pte, unsigned long addr, void *data) return 0; } -static int apply_range_set_scratch_cb(pte_t *pte, unsigned long addr, void *data) +static int apply_range_set_scratch_cb(hw_pte_t *pte, unsigned long addr, + void *data) { struct page *scratch_page = data; @@ -336,7 +337,7 @@ static struct bpf_map *arena_map_alloc(union bpf_attr *attr) return ERR_PTR(err); } -static int existing_page_cb(pte_t *ptep, unsigned long addr, void *data) +static int existing_page_cb(hw_pte_t *ptep, unsigned long addr, void *data) { struct bpf_arena *arena = data; struct page *page; diff --git a/kernel/events/core.c b/kernel/events/core.c index cf78e892a4bb0..5413c3919935c 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8488,7 +8488,8 @@ static u64 perf_get_pgtable_size(struct mm_struct *mm, unsigned long addr) p4d_t *p4dp, p4d; pud_t *pudp, pud; pmd_t *pmdp, pmd; - pte_t *ptep, pte; + hw_pte_t *ptep; + pte_t pte; pgdp = pgd_offset(mm, addr); pgd = pgdp_get(pgdp); diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index fbda70d8ea4d0..d7093500fdee4 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -39,7 +39,7 @@ struct folio *damon_get_folio(unsigned long pfn) return folio; } -void damon_ptep_mkold(pte_t *pte, struct vm_area_struct *vma, unsigned long addr) +void damon_ptep_mkold(hw_pte_t *pte, struct vm_area_struct *vma, unsigned long addr) { pte_t pteval = ptep_get(pte); struct folio *folio; diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h index 38d295488fa18..34b7e5715fcf9 100644 --- a/mm/damon/ops-common.h +++ b/mm/damon/ops-common.h @@ -7,7 +7,7 @@ struct folio *damon_get_folio(unsigned long pfn); -void damon_ptep_mkold(pte_t *pte, struct vm_area_struct *vma, unsigned long addr); +void damon_ptep_mkold(hw_pte_t *pte, struct vm_area_struct *vma, unsigned long addr); void damon_pmdp_mkold(pmd_t *pmd, struct vm_area_struct *vma, unsigned long addr); void damon_folio_mkold(struct folio *folio); bool damon_folio_young(struct folio *folio); diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 0648400b2d65b..e32b914720d5c 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -268,7 +268,7 @@ static void damon_va_walk_page_range(struct mm_struct *mm, unsigned long start, static int damon_mkold_pmd_entry(pmd_t *pmd, unsigned long addr, unsigned long next, struct mm_walk *walk) { - pte_t *pte; + hw_pte_t *pte; spinlock_t *ptl; ptl = pmd_trans_huge_lock(pmd, walk->vma); @@ -293,7 +293,7 @@ static int damon_mkold_pmd_entry(pmd_t *pmd, unsigned long addr, } #ifdef CONFIG_HUGETLB_PAGE -static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, +static void damon_hugetlb_mkold(hw_pte_t *pte, struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr) { bool referenced = false; @@ -320,7 +320,7 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, folio_put(folio); } -static int damon_mkold_hugetlb_entry(pte_t *pte, unsigned long hmask, +static int damon_mkold_hugetlb_entry(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { @@ -389,7 +389,7 @@ struct damon_young_walk_private { static int damon_young_pmd_entry(pmd_t *pmd, unsigned long addr, unsigned long next, struct mm_walk *walk) { - pte_t *pte; + hw_pte_t *pte; pte_t ptent; spinlock_t *ptl; struct folio *folio; @@ -433,7 +433,7 @@ static int damon_young_pmd_entry(pmd_t *pmd, unsigned long addr, } #ifdef CONFIG_HUGETLB_PAGE -static int damon_young_hugetlb_entry(pte_t *pte, unsigned long hmask, +static int damon_young_hugetlb_entry(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { @@ -522,7 +522,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) static bool damos_va_filter_young_match(struct damos_filter *filter, struct folio *folio, struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, pmd_t *pmdp) + unsigned long addr, hw_pte_t *ptep, pmd_t *pmdp) { bool young = false; @@ -544,7 +544,7 @@ static bool damos_va_filter_young_match(struct damos_filter *filter, static bool damos_va_filter_out(struct damos *scheme, struct folio *folio, struct vm_area_struct *vma, unsigned long addr, - pte_t *ptep, pmd_t *pmdp) + hw_pte_t *ptep, pmd_t *pmdp) { struct damos_filter *filter; bool matched; @@ -641,7 +641,8 @@ static int damos_va_migrate_pmd_entry(pmd_t *pmd, unsigned long addr, struct damos_migrate_dests *dests = &s->migrate_dests; struct folio *folio; spinlock_t *ptl; - pte_t *start_pte, *pte, ptent; + hw_pte_t *start_pte, *pte; + pte_t ptent; int nr; #ifdef CONFIG_TRANSPARENT_HUGEPAGE @@ -801,7 +802,8 @@ static int damos_va_stat_pmd_entry(pmd_t *pmd, unsigned long addr, struct vm_area_struct *vma = walk->vma; struct folio *folio; spinlock_t *ptl; - pte_t *start_pte, *pte, ptent; + hw_pte_t *start_pte, *pte; + pte_t ptent; int nr; #ifdef CONFIG_TRANSPARENT_HUGEPAGE diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index 2875fd22d7bb0..54e194d2a5854 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -50,7 +50,7 @@ struct pgtable_debug_args { p4d_t *p4dp; pud_t *pudp; pmd_t *pmdp; - pte_t *ptep; + hw_pte_t *ptep; p4d_t *start_p4dp; pud_t *start_pudp; diff --git a/mm/filemap.c b/mm/filemap.c index 6afec636881fb..636fcc0add26c 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3490,7 +3490,7 @@ static vm_fault_t filemap_fault_recheck_pte_none(struct vm_fault *vmf) { struct vm_area_struct *vma = vmf->vma; vm_fault_t ret = 0; - pte_t *ptep; + hw_pte_t *ptep; /* * We might have COW'ed a pagecache folio and might now have an mlocked @@ -3796,7 +3796,7 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, vm_fault_t ret = 0; struct page *page = folio_page(folio, start); unsigned int count = 0; - pte_t *old_ptep = vmf->pte; + hw_pte_t *old_ptep = vmf->pte; unsigned long addr0; /* diff --git a/mm/gup.c b/mm/gup.c index d110f30d9bf42..c7eb459b29375 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -761,7 +761,7 @@ static struct page *follow_huge_pmd(struct vm_area_struct *vma, #endif /* CONFIG_PGTABLE_HAS_HUGE_LEAVES */ static int follow_pfn_pte(struct vm_area_struct *vma, unsigned long address, - pte_t *pte, unsigned int flags) + hw_pte_t *pte, unsigned int flags) { if (flags & FOLL_TOUCH) { pte_t orig_entry = ptep_get(pte); @@ -806,7 +806,8 @@ static struct page *follow_page_pte(struct vm_area_struct *vma, struct folio *folio; struct page *page; spinlock_t *ptl; - pte_t *ptep, pte; + hw_pte_t *ptep; + pte_t pte; int ret; ptep = pte_offset_map_lock(mm, pmd, address, &ptl); @@ -1035,7 +1036,7 @@ static int get_gate_page(struct mm_struct *mm, unsigned long address, p4d_t *p4d; pud_t *pud; pmd_t *pmd; - pte_t *pte; + hw_pte_t *pte; pte_t entry; int ret = -EFAULT; @@ -2849,7 +2850,7 @@ static int gup_fast_pte_range(pmd_t pmd, pmd_t *pmdp, unsigned long addr, int *nr) { int ret = 0; - pte_t *ptep, *ptem; + hw_pte_t *ptep, *ptem; ptem = ptep = pte_offset_map(&pmd, addr); if (!ptep) diff --git a/mm/highmem.c b/mm/highmem.c index a33e411839517..87f94cac6106b 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -141,7 +141,7 @@ EXPORT_SYMBOL(__totalhigh_pages); static int pkmap_count[LAST_PKMAP]; static __cacheline_aligned_in_smp DEFINE_SPINLOCK(kmap_lock); -pte_t *pkmap_page_table; +hw_pte_t *pkmap_page_table; /* * Most architectures have no use for kmap_high_get(), so let's abstract @@ -532,9 +532,9 @@ static inline bool kmap_high_unmap_local(unsigned long vaddr) return false; } -static pte_t *__kmap_pte; +static hw_pte_t *__kmap_pte; -static pte_t *kmap_get_pte(unsigned long vaddr, int idx) +static hw_pte_t *kmap_get_pte(unsigned long vaddr, int idx) { if (IS_ENABLED(CONFIG_KMAP_LOCAL_NON_LINEAR_PTE_ARRAY)) /* @@ -549,8 +549,9 @@ static pte_t *kmap_get_pte(unsigned long vaddr, int idx) void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) { - pte_t pteval, *kmap_pte; unsigned long vaddr; + hw_pte_t *kmap_pte; + pte_t pteval; int idx; /* @@ -597,7 +598,7 @@ EXPORT_SYMBOL(__kmap_local_page_prot); void kunmap_local_indexed(const void *vaddr) { unsigned long addr = (unsigned long) vaddr & PAGE_MASK; - pte_t *kmap_pte; + hw_pte_t *kmap_pte; int idx; if (addr < __fix_to_virt(FIX_KMAP_END) || @@ -646,7 +647,7 @@ EXPORT_SYMBOL(kunmap_local_indexed); void __kmap_local_sched_out(void) { struct task_struct *tsk = current; - pte_t *kmap_pte; + hw_pte_t *kmap_pte; int i; /* Clear kmaps */ @@ -683,7 +684,7 @@ void __kmap_local_sched_out(void) void __kmap_local_sched_in(void) { struct task_struct *tsk = current; - pte_t *kmap_pte; + hw_pte_t *kmap_pte; int i; /* Restore kmaps */ diff --git a/mm/hmm.c b/mm/hmm.c index 2b05c53b82dc3..56208cd603c2a 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -240,7 +240,7 @@ static inline unsigned long pte_to_hmm_pfn_flags(struct hmm_range *range, } static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, - unsigned long end, pmd_t *pmdp, pte_t *ptep, + unsigned long end, pmd_t *pmdp, hw_pte_t *ptep, unsigned long *hmm_pfn) { struct hmm_vma_walk *hmm_vma_walk = walk->private; @@ -411,7 +411,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, &range->hmm_pfns[(start - range->start) >> PAGE_SHIFT]; unsigned long npages = (end - start) >> PAGE_SHIFT; unsigned long addr = start; - pte_t *ptep; + hw_pte_t *ptep; pmd_t pmd; again: @@ -547,7 +547,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end, #endif #ifdef CONFIG_HUGETLB_PAGE -static int hmm_vma_walk_hugetlb_entry(pte_t *pte, unsigned long hmask, +static int hmm_vma_walk_hugetlb_entry(hw_pte_t *pte, unsigned long hmask, unsigned long start, unsigned long end, struct mm_walk *walk) { diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 804b8f6aa5570..6a68739fffe06 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3099,7 +3099,7 @@ static void __split_huge_zero_page_pmd(struct vm_area_struct *vma, pgtable_t pgtable; pmd_t _pmd, old_pmd; unsigned long addr; - pte_t *pte; + hw_pte_t *pte; int i; /* @@ -3149,7 +3149,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, bool soft_dirty, uffd_wp = false, young = false, write = false; bool anon_exclusive = false, dirty = false; unsigned long addr; - pte_t *pte; + hw_pte_t *pte; int i; VM_BUG_ON(haddr & ~HPAGE_PMD_MASK); diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e6a210920637d..c954b60dfbdd4 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -120,7 +120,7 @@ static void hugetlb_vma_lock_free(struct vm_area_struct *vma); static void hugetlb_vma_lock_alloc(struct vm_area_struct *vma); static void __hugetlb_vma_unlock_write_free(struct vm_area_struct *vma); static int __huge_pmd_unshare(struct mmu_gather *tlb, - struct vm_area_struct *vma, unsigned long addr, pte_t *ptep, + struct vm_area_struct *vma, unsigned long addr, hw_pte_t *ptep, bool check_locks); static void hugetlb_unshare_pmds(struct vm_area_struct *vma, unsigned long start, unsigned long end, bool take_locks); @@ -4852,7 +4852,7 @@ static pte_t make_huge_pte(struct vm_area_struct *vma, struct folio *folio, } static void set_huge_ptep_writable(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep) + unsigned long address, hw_pte_t *ptep) { pte_t entry; @@ -4862,14 +4862,14 @@ static void set_huge_ptep_writable(struct vm_area_struct *vma, } static void set_huge_ptep_maybe_writable(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep) + unsigned long address, hw_pte_t *ptep) { if (vma->vm_flags & VM_WRITE) set_huge_ptep_writable(vma, address, ptep); } static void -hugetlb_install_folio(struct vm_area_struct *vma, pte_t *ptep, unsigned long addr, +hugetlb_install_folio(struct vm_area_struct *vma, hw_pte_t *ptep, unsigned long addr, struct folio *new_folio, pte_t old, unsigned long sz) { pte_t newpte = make_huge_pte(vma, new_folio, true); @@ -4895,7 +4895,8 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma) { - pte_t *src_pte, *dst_pte, entry; + hw_pte_t *src_pte, *dst_pte; + pte_t entry; struct folio *pte_folio; unsigned long addr; bool cow = is_cow_mapping(src_vma->vm_flags); @@ -5087,7 +5088,8 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, } static void move_huge_pte(struct vm_area_struct *vma, unsigned long old_addr, - unsigned long new_addr, pte_t *src_pte, pte_t *dst_pte, + unsigned long new_addr, hw_pte_t *src_pte, + hw_pte_t *dst_pte, unsigned long sz) { bool need_clear_uffd_wp = vma_has_uffd_without_event_remap(vma); @@ -5149,7 +5151,7 @@ int move_hugetlb_page_tables(struct vm_area_struct *vma, struct mm_struct *mm = vma->vm_mm; unsigned long old_end = old_addr + len; unsigned long last_addr_mask; - pte_t *src_pte, *dst_pte; + hw_pte_t *src_pte, *dst_pte; struct mmu_notifier_range range; struct mmu_gather tlb; @@ -5210,7 +5212,7 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, struct mm_struct *mm = vma->vm_mm; const bool folio_provided = !!folio; unsigned long address; - pte_t *ptep; + hw_pte_t *ptep; pte_t pte; spinlock_t *ptl; struct hstate *h = hstate_vma(vma); @@ -5744,7 +5746,7 @@ static inline vm_fault_t hugetlb_handle_userfault(struct vm_fault *vmf, * false if pte changed or is changing. */ static bool hugetlb_pte_stable(struct hstate *h, struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t old_pte) + hw_pte_t *ptep, pte_t old_pte) { spinlock_t *ptl; bool same; @@ -6269,7 +6271,7 @@ static struct folio *alloc_hugetlb_folio_vma(struct hstate *h, * Used by userfaultfd UFFDIO_* ioctls. Based on userfaultfd's mfill_atomic_pte * with modifications for hugetlb pages. */ -int hugetlb_mfill_atomic_pte(pte_t *dst_pte, +int hugetlb_mfill_atomic_pte(hw_pte_t *dst_pte, struct vm_area_struct *dst_vma, unsigned long dst_addr, unsigned long src_addr, @@ -6328,7 +6330,7 @@ int hugetlb_mfill_atomic_pte(pte_t *dst_pte, folio = alloc_hugetlb_folio(dst_vma, dst_addr, false); if (IS_ERR(folio)) { - pte_t *actual_pte = hugetlb_walk(dst_vma, dst_addr, PMD_SIZE); + hw_pte_t *actual_pte = hugetlb_walk(dst_vma, dst_addr, PMD_SIZE); if (actual_pte) { ret = -EEXIST; goto out; @@ -6496,7 +6498,7 @@ long hugetlb_change_protection(struct vm_area_struct *vma, { struct mm_struct *mm = vma->vm_mm; unsigned long start = address; - pte_t *ptep; + hw_pte_t *ptep; pte_t pte; struct hstate *h = hstate_vma(vma); long pages = 0, psize = huge_page_size(h); @@ -6981,15 +6983,15 @@ void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma, * racing tasks could either miss the sharing (see huge_pte_offset) or select a * bad pmd for sharing. */ -pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, +hw_pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, pud_t *pud) { struct address_space *mapping = vma->vm_file->f_mapping; const pgoff_t idx = linear_page_index(vma, addr); struct vm_area_struct *svma; unsigned long saddr; - pte_t *spte = NULL; - pte_t *pte; + hw_pte_t *spte = NULL; + hw_pte_t *pte; i_mmap_lock_read(mapping); mapping_rmap_tree_foreach(svma, mapping, idx, idx) { @@ -7020,13 +7022,13 @@ pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, } spin_unlock(&mm->page_table_lock); out: - pte = (pte_t *)pmd_alloc(mm, pud, addr); + pte = (hw_pte_t *)pmd_alloc(mm, pud, addr); i_mmap_unlock_read(mapping); return pte; } static int __huge_pmd_unshare(struct mmu_gather *tlb, - struct vm_area_struct *vma, unsigned long addr, pte_t *ptep, + struct vm_area_struct *vma, unsigned long addr, hw_pte_t *ptep, bool check_locks) { unsigned long sz = huge_page_size(hstate_vma(vma)); @@ -7067,7 +7069,7 @@ static int __huge_pmd_unshare(struct mmu_gather *tlb, * was not a shared PMD table. */ int huge_pmd_unshare(struct mmu_gather *tlb, struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep) + unsigned long addr, hw_pte_t *ptep) { return __huge_pmd_unshare(tlb, vma, addr, ptep, /*check_locks=*/true); } @@ -7097,21 +7099,21 @@ void huge_pmd_unshare_flush(struct mmu_gather *tlb, struct vm_area_struct *vma) #else /* !CONFIG_HUGETLB_PMD_PAGE_TABLE_SHARING */ -pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, +hw_pte_t *huge_pmd_share(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, pud_t *pud) { return NULL; } static int __huge_pmd_unshare(struct mmu_gather *tlb, - struct vm_area_struct *vma, unsigned long addr, pte_t *ptep, + struct vm_area_struct *vma, unsigned long addr, hw_pte_t *ptep, bool check_locks) { return 0; } int huge_pmd_unshare(struct mmu_gather *tlb, struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep) + unsigned long addr, hw_pte_t *ptep) { return 0; } @@ -7132,13 +7134,13 @@ bool want_pmd_share(struct vm_area_struct *vma, unsigned long addr) #endif /* CONFIG_HUGETLB_PMD_PAGE_TABLE_SHARING */ #ifdef CONFIG_ARCH_WANT_GENERAL_HUGETLB -pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, +hw_pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, unsigned long sz) { pgd_t *pgd; p4d_t *p4d; pud_t *pud; - pte_t *pte = NULL; + hw_pte_t *pte = NULL; pgd = pgd_offset(mm, addr); p4d = p4d_alloc(mm, pgd, addr); @@ -7147,13 +7149,13 @@ pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, pud = pud_alloc(mm, p4d, addr); if (pud) { if (sz == PUD_SIZE) { - pte = (pte_t *)pud; + pte = (hw_pte_t *)pud; } else { BUG_ON(sz != PMD_SIZE); if (want_pmd_share(vma, addr) && pud_none(*pud)) pte = huge_pmd_share(mm, vma, addr, pud); else - pte = (pte_t *)pmd_alloc(mm, pud, addr); + pte = (hw_pte_t *)pmd_alloc(mm, pud, addr); } } @@ -7175,7 +7177,7 @@ pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, * size @sz doesn't match the hugepage size at this level of the page * table. */ -pte_t *huge_pte_offset(struct mm_struct *mm, +hw_pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr, unsigned long sz) { pgd_t *pgd; @@ -7193,14 +7195,14 @@ pte_t *huge_pte_offset(struct mm_struct *mm, pud = pud_offset(p4d, addr); if (sz == PUD_SIZE) /* must be pud huge, non-present or none */ - return (pte_t *)pud; + return (hw_pte_t *)pud; if (!pud_present(*pud)) return NULL; /* must have a valid entry and size to go further */ pmd = pmd_offset(pud, addr); /* must be pmd huge, non-present or none */ - return (pte_t *)pmd; + return (hw_pte_t *)pmd; } /* @@ -7379,7 +7381,7 @@ static void hugetlb_unshare_pmds(struct vm_area_struct *vma, struct mmu_gather tlb; unsigned long address; spinlock_t *ptl; - pte_t *ptep; + hw_pte_t *ptep; if (!(vma->vm_flags & VM_MAYSHARE)) return; diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 917db0984143c..2850c19c45287 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -33,7 +33,7 @@ * operations. */ struct vmemmap_remap_walk { - void (*remap_pte)(pte_t *pte, unsigned long addr, + void (*remap_pte)(hw_pte_t *pte, unsigned long addr, struct vmemmap_remap_walk *walk); unsigned long nr_walked; @@ -55,7 +55,7 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start, pmd_t __pmd; int i; unsigned long addr = start; - pte_t *pgtable; + hw_pte_t *pgtable; pgtable = pte_alloc_one_kernel(&init_mm); if (!pgtable) @@ -64,7 +64,8 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start, pmd_populate_kernel(&init_mm, &__pmd, pgtable); for (i = 0; i < PTRS_PER_PTE; i++, addr += PAGE_SIZE) { - pte_t entry, *pte; + pte_t entry; + hw_pte_t *pte; pgprot_t pgprot = PAGE_KERNEL; entry = mk_pte(head + i, pgprot); @@ -136,7 +137,7 @@ static int vmemmap_pmd_entry(pmd_t *pmd, unsigned long addr, return vmemmap_split_pmd(pmd, head, addr & PMD_MASK, vmemmap_walk); } -static int vmemmap_pte_entry(pte_t *pte, unsigned long addr, +static int vmemmap_pte_entry(hw_pte_t *pte, unsigned long addr, unsigned long next, struct mm_walk *walk) { struct vmemmap_remap_walk *vmemmap_walk = walk->private; @@ -198,7 +199,7 @@ static void free_vmemmap_page_list(struct list_head *list) free_vmemmap_page(page); } -static void vmemmap_remap_pte(pte_t *pte, unsigned long addr, +static void vmemmap_remap_pte(hw_pte_t *pte, unsigned long addr, struct vmemmap_remap_walk *walk) { struct page *page = pte_page(ptep_get(pte)); @@ -232,7 +233,7 @@ static void vmemmap_remap_pte(pte_t *pte, unsigned long addr, set_pte_at(&init_mm, addr, pte, entry); } -static void vmemmap_restore_pte(pte_t *pte, unsigned long addr, +static void vmemmap_restore_pte(hw_pte_t *pte, unsigned long addr, struct vmemmap_remap_walk *walk) { struct page *src = pte_page(ptep_get(pte)), *dst; diff --git a/mm/internal.h b/mm/internal.h index f47f06c555481..46039190db8bf 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -278,7 +278,7 @@ void unmap_vmas(struct mmu_gather *tlb, struct unmap_desc *unmap); #ifdef CONFIG_MMU bool cond_install_uffd_wp_ptes(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, pte_t pte, + unsigned long addr, hw_pte_t *ptep, pte_t pte, unsigned long nr_ptes); static inline void get_anon_vma(struct anon_vma *anon_vma) @@ -414,7 +414,7 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) * Return: the number of table entries in the batch. */ static inline unsigned int folio_pte_batch_flags(struct folio *folio, - struct vm_area_struct *vma, pte_t *ptep, pte_t *ptentp, + struct vm_area_struct *vma, hw_pte_t *ptep, pte_t *ptentp, unsigned int max_nr, fpb_t flags) { bool any_writable = false, any_young = false, any_dirty = false; @@ -468,7 +468,7 @@ static inline unsigned int folio_pte_batch_flags(struct folio *folio, return min(nr, max_nr); } -unsigned int folio_pte_batch(struct folio *folio, pte_t *ptep, pte_t pte, +unsigned int folio_pte_batch(struct folio *folio, hw_pte_t *ptep, pte_t pte, unsigned int max_nr); /** @@ -525,11 +525,11 @@ static inline pte_t pte_next_swp_offset(pte_t pte) * * Return: the number of table entries in the batch. */ -static inline int swap_pte_batch(pte_t *start_ptep, int max_nr, pte_t pte) +static inline int swap_pte_batch(hw_pte_t *start_ptep, int max_nr, pte_t pte) { pte_t expected_pte = pte_next_swp_offset(pte); - const pte_t *end_ptep = start_ptep + max_nr; - pte_t *ptep = start_ptep + 1; + const hw_pte_t *end_ptep = start_ptep + max_nr; + hw_pte_t *ptep = start_ptep + 1; VM_WARN_ON(max_nr < 1); VM_WARN_ON(!softleaf_is_swap(softleaf_from_pte(pte))); @@ -1569,7 +1569,7 @@ static inline void maybe_rmap_unlock_action(struct vm_area_struct *vma, #ifdef CONFIG_MMU_NOTIFIER static inline bool clear_flush_young_ptes_notify(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, unsigned int nr) + unsigned long addr, hw_pte_t *ptep, unsigned int nr) { bool young; @@ -1590,7 +1590,7 @@ static inline bool pmdp_clear_flush_young_notify(struct vm_area_struct *vma, } static inline bool test_and_clear_young_ptes_notify(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, unsigned int nr) + unsigned long addr, hw_pte_t *ptep, unsigned int nr) { bool young; diff --git a/mm/kasan/init.c b/mm/kasan/init.c index 66a8838879876..30c5266eaf37e 100644 --- a/mm/kasan/init.c +++ b/mm/kasan/init.c @@ -92,7 +92,7 @@ static __init void *early_alloc(size_t size, int node) static void __ref zero_pte_populate(pmd_t *pmd, unsigned long addr, unsigned long end) { - pte_t *pte = pte_offset_kernel(pmd, addr); + hw_pte_t *pte = pte_offset_kernel(pmd, addr); pte_t zero_pte; zero_pte = pfn_pte(PFN_DOWN(__pa_symbol(kasan_early_shadow_page)), @@ -122,7 +122,7 @@ static int __ref zero_pmd_populate(pud_t *pud, unsigned long addr, } if (pmd_none(*pmd)) { - pte_t *p; + hw_pte_t *p; if (slab_is_available()) p = pte_alloc_one_kernel(&init_mm); @@ -281,9 +281,9 @@ int __ref kasan_populate_early_shadow(const void *shadow_start, return 0; } -static void kasan_free_pte(pte_t *pte_start, pmd_t *pmd) +static void kasan_free_pte(hw_pte_t *pte_start, pmd_t *pmd) { - pte_t *pte; + hw_pte_t *pte; int i; for (i = 0; i < PTRS_PER_PTE; i++) { @@ -341,7 +341,7 @@ static void kasan_free_p4d(p4d_t *p4d_start, pgd_t *pgd) pgd_clear(pgd); } -static void kasan_remove_pte_table(pte_t *pte, unsigned long addr, +static void kasan_remove_pte_table(hw_pte_t *pte, unsigned long addr, unsigned long end) { unsigned long next; @@ -369,7 +369,7 @@ static void kasan_remove_pmd_table(pmd_t *pmd, unsigned long addr, unsigned long next; for (; addr < end; addr = next, pmd++) { - pte_t *pte; + hw_pte_t *pte; next = pmd_addr_end(addr, end); diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c index d286e0a045437..86fc7ed45dcd0 100644 --- a/mm/kasan/shadow.c +++ b/mm/kasan/shadow.c @@ -189,7 +189,7 @@ static bool shadow_mapped(unsigned long addr) p4d_t *p4d; pud_t *pud; pmd_t *pmd; - pte_t *pte; + hw_pte_t *pte; if (pgd_none(*pgd)) return false; @@ -297,7 +297,7 @@ struct vmalloc_populate_data { struct page **pages; }; -static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, +static int kasan_populate_vmalloc_pte(hw_pte_t *ptep, unsigned long addr, void *_data) { struct vmalloc_populate_data *data = _data; @@ -465,7 +465,7 @@ int __kasan_populate_vmalloc(unsigned long addr, unsigned long size, gfp_t gfp_m return 0; } -static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr, +static int kasan_depopulate_vmalloc_pte(hw_pte_t *ptep, unsigned long addr, void *unused) { pte_t pte; diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 3338e9dc11dd0..d1a4a40bef9ea 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -665,7 +665,7 @@ static void release_pte_folio(struct folio *folio) folio_putback_lru(folio); } -static void release_pte_pages(pte_t *pte, pte_t *_pte, +static void release_pte_pages(hw_pte_t *pte, hw_pte_t *_pte, struct list_head *compound_pagelist) { struct folio *folio, *tmp; @@ -811,13 +811,14 @@ static enum pte_check_result collapse_check_pte(pte_t pteval, } static enum scan_result __collapse_huge_page_isolate(struct vm_area_struct *vma, - unsigned long start_addr, pte_t *pte, struct collapse_control *cc, + unsigned long start_addr, hw_pte_t *pte, struct collapse_control *cc, unsigned int order, struct list_head *compound_pagelist) { const unsigned long nr_pages = 1UL << order; struct folio *folio = NULL; unsigned long addr = start_addr; - pte_t *_pte, pteval; + hw_pte_t *_pte; + pte_t pteval; int referenced = 0; enum scan_result result = SCAN_FAIL; enum pte_check_result pte_check; @@ -929,7 +930,7 @@ static enum scan_result __collapse_huge_page_isolate(struct vm_area_struct *vma, return result; } -static void __collapse_huge_page_copy_succeeded(pte_t *pte, +static void __collapse_huge_page_copy_succeeded(hw_pte_t *pte, struct vm_area_struct *vma, unsigned long address, spinlock_t *ptl, unsigned int order, struct list_head *compound_pagelist) @@ -938,7 +939,7 @@ static void __collapse_huge_page_copy_succeeded(pte_t *pte, unsigned long end = address + (PAGE_SIZE * nr_pages); struct folio *src, *tmp; pte_t pteval; - pte_t *_pte; + hw_pte_t *_pte; unsigned int nr_ptes; for (_pte = pte; _pte < pte + nr_pages; _pte += nr_ptes, @@ -993,7 +994,7 @@ static void __collapse_huge_page_copy_succeeded(pte_t *pte, } } -static void __collapse_huge_page_copy_failed(pte_t *pte, +static void __collapse_huge_page_copy_failed(hw_pte_t *pte, pmd_t *pmd, pmd_t orig_pmd, struct vm_area_struct *vma, unsigned int order, struct list_head *compound_pagelist) { @@ -1031,7 +1032,7 @@ static void __collapse_huge_page_copy_failed(pte_t *pte, * @ptl: lock on raw pages' PTEs * @compound_pagelist: list that stores compound pages */ -static enum scan_result __collapse_huge_page_copy(pte_t *pte, struct folio *folio, +static enum scan_result __collapse_huge_page_copy(hw_pte_t *pte, struct folio *folio, pmd_t *pmd, pmd_t orig_pmd, struct vm_area_struct *vma, unsigned long address, spinlock_t *ptl, unsigned int order, struct list_head *compound_pagelist) @@ -1253,7 +1254,7 @@ static enum scan_result __collapse_huge_page_swapin(struct mm_struct *mm, vm_fault_t ret = 0; unsigned long addr, end = start_addr + (PAGE_SIZE << order); enum scan_result result; - pte_t *pte = NULL; + hw_pte_t *pte = NULL; spinlock_t *ptl; for (addr = start_addr; addr < end; addr += PAGE_SIZE) { @@ -1381,7 +1382,7 @@ static enum scan_result collapse_huge_page(struct mm_struct *mm, unsigned long s const unsigned long end_addr = start_addr + (PAGE_SIZE << order); LIST_HEAD(compound_pagelist); pmd_t *pmd, _pmd; - pte_t *pte = NULL; + hw_pte_t *pte = NULL; pgtable_t pgtable; struct folio *folio; spinlock_t *pmd_ptl, *pte_ptl; @@ -1692,7 +1693,8 @@ static enum scan_result collapse_scan_pmd(struct mm_struct *mm, { enum tva_type tva_flags = cc->is_khugepaged ? TVA_KHUGEPAGED : TVA_FORCED_COLLAPSE; pmd_t *pmd; - pte_t *pte, *_pte, pteval; + hw_pte_t *pte, *_pte; + pte_t pteval; int i; struct folio *folio = NULL; int referenced = 0; @@ -1887,7 +1889,7 @@ static enum scan_result try_collapse_pte_mapped_thp(struct mm_struct *mm, unsign unsigned long end = haddr + HPAGE_PMD_SIZE; struct vm_area_struct *vma = vma_lookup(mm, haddr); struct folio *folio; - pte_t *start_pte, *pte; + hw_pte_t *start_pte, *pte; pmd_t *pmd, pgt_pmd; spinlock_t *pml = NULL, *ptl; int i; diff --git a/mm/ksm.c b/mm/ksm.c index 11d50518d02e9..744024cc5bf02 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -618,7 +618,7 @@ static int break_ksm_pmd_entry(pmd_t *pmdp, unsigned long addr, unsigned long en { unsigned long *found_addr = (unsigned long *) walk->private; struct mm_struct *mm = walk->mm; - pte_t *start_ptep, *ptep; + hw_pte_t *start_ptep, *ptep; spinlock_t *ptl; int found = 0; @@ -1399,7 +1399,7 @@ static int replace_page(struct vm_area_struct *vma, struct page *page, struct folio *folio = page_folio(page); pmd_t *pmd; pmd_t pmde; - pte_t *ptep; + hw_pte_t *ptep; pte_t newpte; spinlock_t *ptl; unsigned long addr; @@ -2531,7 +2531,8 @@ static int ksm_next_page_pmd_entry(pmd_t *pmdp, unsigned long addr, unsigned lon { struct ksm_next_page_arg *private = walk->private; struct vm_area_struct *vma = walk->vma; - pte_t *start_ptep = NULL, *ptep, pte; + hw_pte_t *start_ptep = NULL, *ptep; + pte_t pte; struct mm_struct *mm = walk->mm; struct folio *folio; struct page *page; diff --git a/mm/madvise.c b/mm/madvise.c index c324cc991f841..6f99cef91b6bd 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -189,7 +189,7 @@ static int swapin_walk_pmd_entry(pmd_t *pmd, unsigned long start, { struct vm_area_struct *vma = walk->private; struct swap_io_ctx ctx = {}; - pte_t *ptep = NULL; + hw_pte_t *ptep = NULL; spinlock_t *ptl; unsigned long addr; @@ -341,7 +341,7 @@ static inline bool can_do_file_pageout(struct vm_area_struct *vma) } static inline int madvise_folio_pte_batch(unsigned long addr, unsigned long end, - struct folio *folio, pte_t *ptep, + struct folio *folio, hw_pte_t *ptep, pte_t *ptentp) { int max_nr = (end - addr) / PAGE_SIZE; @@ -359,7 +359,8 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, bool pageout = private->pageout; struct mm_struct *mm = tlb->mm; struct vm_area_struct *vma = walk->vma; - pte_t *start_pte, *pte, ptent; + hw_pte_t *start_pte, *pte; + pte_t ptent; spinlock_t *ptl; struct folio *folio = NULL; LIST_HEAD(folio_list); @@ -658,7 +659,8 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, struct mm_struct *mm = tlb->mm; struct vm_area_struct *vma = walk->vma; spinlock_t *ptl; - pte_t *start_pte, *pte, ptent; + hw_pte_t *start_pte, *pte; + pte_t ptent; struct folio *folio; int nr_swap = 0; unsigned long next; @@ -1083,7 +1085,7 @@ static int guard_install_pmd_entry(pmd_t *pmd, unsigned long addr, return pmd_trans_huge(pmdval); } -static int guard_install_pte_entry(pte_t *pte, unsigned long addr, +static int guard_install_pte_entry(hw_pte_t *pte, unsigned long addr, unsigned long next, struct mm_walk *walk) { pte_t pteval = ptep_get(pte); @@ -1226,7 +1228,7 @@ static int guard_remove_pmd_entry(pmd_t *pmd, unsigned long addr, return 0; } -static int guard_remove_pte_entry(pte_t *pte, unsigned long addr, +static int guard_remove_pte_entry(hw_pte_t *pte, unsigned long addr, unsigned long next, struct mm_walk *walk) { pte_t ptent = ptep_get(pte); diff --git a/mm/mapping_dirty_helpers.c b/mm/mapping_dirty_helpers.c index e0efa36e0a076..dcbd39912f819 100644 --- a/mm/mapping_dirty_helpers.c +++ b/mm/mapping_dirty_helpers.c @@ -31,7 +31,7 @@ struct wp_walk { * The function write-protects a pte and records the range in * virtual address space of touched ptes for efficient range TLB flushes. */ -static int wp_pte(pte_t *pte, unsigned long addr, unsigned long end, +static int wp_pte(hw_pte_t *pte, unsigned long addr, unsigned long end, struct mm_walk *walk) { struct wp_walk *wpwalk = walk->private; @@ -86,7 +86,7 @@ struct clean_walk { * in the address_space, as well as the first and last of the bits * touched. */ -static int clean_record_pte(pte_t *pte, unsigned long addr, +static int clean_record_pte(hw_pte_t *pte, unsigned long addr, unsigned long end, struct mm_walk *walk) { struct wp_walk *wpwalk = walk->private; diff --git a/mm/memory-failure.c b/mm/memory-failure.c index d4d967dd08ea1..f45bd3d1f0dd8 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -342,7 +342,7 @@ static unsigned long dev_pagemap_mapping_shift(struct vm_area_struct *vma, p4d_t *p4d; pud_t *pud; pmd_t *pmd; - pte_t *pte; + hw_pte_t *pte; pte_t ptent; VM_BUG_ON_VMA(address == -EFAULT, vma); @@ -742,7 +742,7 @@ static int hwpoison_pte_range(pmd_t *pmdp, unsigned long addr, { struct hwpoison_walk *hwp = walk->private; int ret = 0; - pte_t *ptep, *mapped_pte; + hw_pte_t *ptep, *mapped_pte; spinlock_t *ptl; ptl = pmd_trans_huge_lock(pmdp, walk->vma); @@ -770,7 +770,7 @@ static int hwpoison_pte_range(pmd_t *pmdp, unsigned long addr, } #ifdef CONFIG_HUGETLB_PAGE -static int hwpoison_hugetlb_range(pte_t *ptep, unsigned long hmask, +static int hwpoison_hugetlb_range(hw_pte_t *ptep, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { diff --git a/mm/memory.c b/mm/memory.c index b735fbf5e323c..c5b54d98e5635 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -462,7 +462,7 @@ int __pte_alloc(struct mm_struct *mm, pmd_t *pmd) int __pte_alloc_kernel(pmd_t *pmd) { - pte_t *new = pte_alloc_one_kernel(&init_mm); + hw_pte_t *new = pte_alloc_one_kernel(&init_mm); if (!new) return -ENOMEM; @@ -941,7 +941,7 @@ struct page *vm_normal_page_pud(struct vm_area_struct *vma, */ static void restore_exclusive_pte(struct vm_area_struct *vma, struct folio *folio, struct page *page, unsigned long address, - pte_t *ptep, pte_t orig_pte) + hw_pte_t *ptep, pte_t orig_pte) { pte_t pte; @@ -978,7 +978,7 @@ static void restore_exclusive_pte(struct vm_area_struct *vma, * sleeping. */ static int try_restore_exclusive_pte(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, pte_t orig_pte) + unsigned long addr, hw_pte_t *ptep, pte_t orig_pte) { const softleaf_t entry = softleaf_from_pte(orig_pte); struct page *page = softleaf_to_page(entry); @@ -1001,7 +1001,7 @@ static int try_restore_exclusive_pte(struct vm_area_struct *vma, static unsigned long copy_nonpresent_pte(struct mm_struct *dst_mm, struct mm_struct *src_mm, - pte_t *dst_pte, pte_t *src_pte, struct vm_area_struct *dst_vma, + hw_pte_t *dst_pte, hw_pte_t *src_pte, struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, unsigned long addr, int *rss) { vm_flags_t vm_flags = dst_vma->vm_flags; @@ -1116,7 +1116,7 @@ copy_nonpresent_pte(struct mm_struct *dst_mm, struct mm_struct *src_mm, */ static inline int copy_present_page(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, - pte_t *dst_pte, pte_t *src_pte, unsigned long addr, int *rss, + hw_pte_t *dst_pte, hw_pte_t *src_pte, unsigned long addr, int *rss, struct folio **prealloc, struct page *page) { struct folio *new_folio; @@ -1155,7 +1155,7 @@ copy_present_page(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma } static __always_inline void __copy_present_ptes(struct vm_area_struct *dst_vma, - struct vm_area_struct *src_vma, pte_t *dst_pte, pte_t *src_pte, + struct vm_area_struct *src_vma, hw_pte_t *dst_pte, hw_pte_t *src_pte, pte_t pte, unsigned long addr, int nr) { struct mm_struct *src_mm = src_vma->vm_mm; @@ -1205,7 +1205,7 @@ static __always_inline void __copy_present_ptes(struct vm_area_struct *dst_vma, */ static inline int copy_present_ptes(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, - pte_t *dst_pte, pte_t *src_pte, pte_t pte, unsigned long addr, + hw_pte_t *dst_pte, hw_pte_t *src_pte, pte_t pte, unsigned long addr, int max_nr, int *rss, struct folio **prealloc) { fpb_t flags = FPB_MERGE_WRITE; @@ -1305,8 +1305,8 @@ copy_pte_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, { struct mm_struct *dst_mm = dst_vma->vm_mm; struct mm_struct *src_mm = src_vma->vm_mm; - pte_t *orig_src_pte, *orig_dst_pte; - pte_t *src_pte, *dst_pte; + hw_pte_t *orig_src_pte, *orig_dst_pte; + hw_pte_t *src_pte, *dst_pte; pmd_t dummy_pmdval; pte_t ptent; spinlock_t *src_ptl, *dst_ptl; @@ -1699,7 +1699,7 @@ static inline bool zap_drop_markers(struct zap_details *details) * Returns true if uffd-wp PTEs were installed, false otherwise. */ bool cond_install_uffd_wp_ptes(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, pte_t pte, + unsigned long addr, hw_pte_t *ptep, pte_t pte, unsigned long nr_ptes) { bool arm_uffd_pte = false; @@ -1753,7 +1753,7 @@ bool cond_install_uffd_wp_ptes(struct vm_area_struct *vma, */ static inline bool zap_install_uffd_wp_if_needed(struct vm_area_struct *vma, - unsigned long addr, pte_t *pte, int nr, + unsigned long addr, hw_pte_t *pte, int nr, struct zap_details *details, pte_t pteval) { if (zap_drop_markers(details)) @@ -1764,7 +1764,7 @@ zap_install_uffd_wp_if_needed(struct vm_area_struct *vma, static __always_inline void zap_present_folio_ptes(struct mmu_gather *tlb, struct vm_area_struct *vma, struct folio *folio, - struct page *page, pte_t *pte, pte_t ptent, unsigned int nr, + struct page *page, hw_pte_t *pte, pte_t ptent, unsigned int nr, unsigned long addr, struct zap_details *details, int *rss, bool *force_flush, bool *force_break, bool *any_skipped) { @@ -1814,7 +1814,7 @@ static __always_inline void zap_present_folio_ptes(struct mmu_gather *tlb, * Returns the number of processed (skipped or zapped) PTEs (at least 1). */ static inline int zap_present_ptes(struct mmu_gather *tlb, - struct vm_area_struct *vma, pte_t *pte, pte_t ptent, + struct vm_area_struct *vma, hw_pte_t *pte, pte_t ptent, unsigned int max_nr, unsigned long addr, struct zap_details *details, int *rss, bool *force_flush, bool *force_break, bool *any_skipped) @@ -1860,7 +1860,7 @@ static inline int zap_present_ptes(struct mmu_gather *tlb, } static inline int zap_nonpresent_ptes(struct mmu_gather *tlb, - struct vm_area_struct *vma, pte_t *pte, pte_t ptent, + struct vm_area_struct *vma, hw_pte_t *pte, pte_t ptent, unsigned int max_nr, unsigned long addr, struct zap_details *details, int *rss, bool *any_skipped) { @@ -1931,7 +1931,7 @@ static inline int zap_nonpresent_ptes(struct mmu_gather *tlb, } static inline int do_zap_pte_range(struct mmu_gather *tlb, - struct vm_area_struct *vma, pte_t *pte, + struct vm_area_struct *vma, hw_pte_t *pte, unsigned long addr, unsigned long end, struct zap_details *details, int *rss, bool *force_flush, bool *force_break, @@ -1994,7 +1994,7 @@ static bool zap_pte_table_if_empty(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, pmd_t *pmdval) { spinlock_t *pml, *ptl = NULL; - pte_t *start_pte, *pte; + hw_pte_t *start_pte, *pte; int i; pml = pmd_lock(mm, pmd); @@ -2034,8 +2034,8 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, struct mm_struct *mm = tlb->mm; int rss[NR_MM_COUNTERS]; spinlock_t *ptl; - pte_t *start_pte; - pte_t *pte; + hw_pte_t *start_pte; + hw_pte_t *pte; pmd_t pmdval; unsigned long start = addr; bool direct_reclaim = true; @@ -2417,7 +2417,7 @@ static pmd_t *walk_to_pmd(struct mm_struct *mm, unsigned long addr) return pmd; } -pte_t *get_locked_pte(struct mm_struct *mm, unsigned long addr, +hw_pte_t *get_locked_pte(struct mm_struct *mm, unsigned long addr, spinlock_t **ptl) { pmd_t *pmd = walk_to_pmd(mm, addr); @@ -2475,7 +2475,7 @@ static int validate_page_before_insert(struct vm_area_struct *vma, return 0; } -static int insert_page_into_pte_locked(struct vm_area_struct *vma, pte_t *pte, +static int insert_page_into_pte_locked(struct vm_area_struct *vma, hw_pte_t *pte, unsigned long addr, struct page *page, pgprot_t prot, bool mkwrite) { @@ -2520,7 +2520,7 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, struct page *page, pgprot_t prot, bool mkwrite) { int retval; - pte_t *pte; + hw_pte_t *pte; spinlock_t *ptl; retval = validate_page_before_insert(vma, page); @@ -2537,7 +2537,7 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, return retval; } -static int insert_page_in_batch_locked(struct vm_area_struct *vma, pte_t *pte, +static int insert_page_in_batch_locked(struct vm_area_struct *vma, hw_pte_t *pte, unsigned long addr, struct page *page, pgprot_t prot) { int err; @@ -2555,7 +2555,7 @@ static int insert_pages(struct vm_area_struct *vma, unsigned long addr, struct page **pages, unsigned long *num, pgprot_t prot) { pmd_t *pmd = NULL; - pte_t *start_pte, *pte; + hw_pte_t *start_pte, *pte; spinlock_t *pte_lock; struct mm_struct *const mm = vma->vm_mm; unsigned long curr_page_idx = 0; @@ -2798,7 +2798,8 @@ static vm_fault_t insert_pfn(struct vm_area_struct *vma, unsigned long addr, unsigned long pfn, pgprot_t prot, bool mkwrite) { struct mm_struct *mm = vma->vm_mm; - pte_t *pte, entry; + hw_pte_t *pte; + pte_t entry; spinlock_t *ptl; pte = get_locked_pte(mm, addr, &ptl); @@ -3039,7 +3040,7 @@ static int remap_pte_range(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, unsigned long end, unsigned long pfn, pgprot_t prot) { - pte_t *pte, *mapped_pte; + hw_pte_t *pte, *mapped_pte; spinlock_t *ptl; int err = 0; @@ -3440,7 +3441,7 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd, pte_fn_t fn, void *data, bool create, pgtbl_mod_mask *mask) { - pte_t *pte, *mapped_pte; + hw_pte_t *pte, *mapped_pte; int err = 0; spinlock_t *ptl; @@ -4743,7 +4744,7 @@ static vm_fault_t handle_pte_marker(struct vm_fault *vmf) /* * Check if the PTEs within a range are contiguous swap entries. */ -static bool can_swapin_thp(struct vm_fault *vmf, pte_t *ptep, int nr_pages) +static bool can_swapin_thp(struct vm_fault *vmf, hw_pte_t *ptep, int nr_pages) { unsigned long addr; int idx; @@ -4795,7 +4796,7 @@ static unsigned long thp_swapin_suitable_orders(struct vm_fault *vmf) unsigned long addr; softleaf_t entry; spinlock_t *ptl; - pte_t *pte; + hw_pte_t *pte; int order; /* @@ -4889,7 +4890,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) int nr_pages; unsigned long page_idx; unsigned long address; - pte_t *ptep; + hw_pte_t *ptep; if (!pte_unmap_same(vmf)) goto out; @@ -5053,7 +5054,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) unsigned long idx = folio_page_idx(folio, page); unsigned long folio_start = address - idx * PAGE_SIZE; unsigned long folio_end = folio_start + nr * PAGE_SIZE; - pte_t *folio_ptep; + hw_pte_t *folio_ptep; pte_t folio_pte; if (unlikely(folio_start < max(address & PMD_MASK, vma->vm_start))) @@ -5283,7 +5284,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) return ret; } -static bool pte_range_none(pte_t *pte, int nr_pages) +static bool pte_range_none(hw_pte_t *pte, int nr_pages) { int i; @@ -5302,7 +5303,7 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) unsigned long orders; struct folio *folio; unsigned long addr; - pte_t *pte; + hw_pte_t *pte; gfp_t gfp; int order; @@ -5384,7 +5385,7 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) return folio_prealloc(vma->vm_mm, vma, vmf->address, true); } -void map_anon_folio_pte_nopf(struct folio *folio, pte_t *pte, +void map_anon_folio_pte_nopf(struct folio *folio, hw_pte_t *pte, struct vm_area_struct *vma, unsigned long addr, bool uffd_wp) { @@ -5405,7 +5406,7 @@ void map_anon_folio_pte_nopf(struct folio *folio, pte_t *pte, update_mmu_cache_range(NULL, vma, addr, pte, nr_pages); } -static void map_anon_folio_pte_pf(struct folio *folio, pte_t *pte, +static void map_anon_folio_pte_pf(struct folio *folio, hw_pte_t *pte, struct vm_area_struct *vma, unsigned long addr, bool uffd_wp) { const unsigned int order = folio_order(folio); @@ -6190,7 +6191,7 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, } static void numa_rebuild_single_mapping(struct vm_fault *vmf, struct vm_area_struct *vma, - unsigned long fault_addr, pte_t *fault_pte, + unsigned long fault_addr, hw_pte_t *fault_pte, bool writable) { pte_t pte, old_pte; @@ -6212,7 +6213,7 @@ static void numa_rebuild_large_mapping(struct vm_fault *vmf, struct vm_area_stru unsigned long start, end, addr = vmf->address; unsigned long addr_start = addr - (nr << PAGE_SHIFT); unsigned long pt_start = ALIGN_DOWN(addr, PMD_SIZE); - pte_t *start_ptep; + hw_pte_t *start_ptep; /* Stay within the VMA and within the page table. */ start = max3(addr_start, pt_start, vma->vm_start); @@ -6974,7 +6975,7 @@ int __pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long address) #endif /* __PAGETABLE_PMD_FOLDED */ static inline void pfnmap_args_setup(struct follow_pfnmap_args *args, - spinlock_t *lock, pte_t *ptep, + spinlock_t *lock, hw_pte_t *ptep, pgprot_t pgprot, unsigned long pfn_base, unsigned long addr_mask, bool writable, bool special) @@ -7043,7 +7044,8 @@ int follow_pfnmap_start(struct follow_pfnmap_args *args) p4d_t *p4dp, p4d; pud_t *pudp, pud; pmd_t *pmdp, pmd; - pte_t *ptep, pte; + hw_pte_t *ptep; + pte_t pte; pfnmap_lockdep_assert(vma); diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 5720f7f54d942..729a600132386 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -691,7 +691,7 @@ static int queue_folios_pte_range(pmd_t *pmd, unsigned long addr, struct folio *folio; struct queue_pages *qp = walk->private; unsigned long flags = qp->flags; - pte_t *pte, *mapped_pte; + hw_pte_t *pte, *mapped_pte; pte_t ptent; spinlock_t *ptl; int max_nr, nr; @@ -771,7 +771,7 @@ static int queue_folios_pte_range(pmd_t *pmd, unsigned long addr, return 0; } -static int queue_folios_hugetlb(pte_t *pte, unsigned long hmask, +static int queue_folios_hugetlb(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { diff --git a/mm/migrate.c b/mm/migrate.c index b937cbd764808..bc2ca59ecf9cd 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -497,7 +497,7 @@ void migration_entry_wait(struct mm_struct *mm, pmd_t *pmd, unsigned long address) { spinlock_t *ptl; - pte_t *ptep; + hw_pte_t *ptep; pte_t pte; softleaf_t entry; @@ -528,7 +528,7 @@ void migration_entry_wait(struct mm_struct *mm, pmd_t *pmd, * * This function will release the vma lock before returning. */ -void migration_entry_wait_huge(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep) +void migration_entry_wait_huge(struct vm_area_struct *vma, unsigned long addr, hw_pte_t *ptep) { spinlock_t *ptl = huge_pte_lockptr(hstate_vma(vma), vma->vm_mm, ptep); softleaf_t entry; diff --git a/mm/migrate_device.c b/mm/migrate_device.c index 9a346162c6881..27c761e433d65 100644 --- a/mm/migrate_device.c +++ b/mm/migrate_device.c @@ -254,7 +254,7 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, spinlock_t *ptl; struct folio *fault_folio = migrate->fault_page ? page_folio(migrate->fault_page) : NULL; - pte_t *ptep; + hw_pte_t *ptep; again: if (pmd_trans_huge(*pmdp) || !pmd_present(*pmdp)) { @@ -989,7 +989,7 @@ static void migrate_vma_insert_page(struct migrate_vma *migrate, p4d_t *p4dp; pud_t *pudp; pmd_t *pmdp; - pte_t *ptep; + hw_pte_t *ptep; pte_t orig_pte; /* Only allow populating anonymous memory */ diff --git a/mm/mincore.c b/mm/mincore.c index ff4ac82817683..15454ced345ab 100644 --- a/mm/mincore.c +++ b/mm/mincore.c @@ -24,7 +24,7 @@ #include "swap.h" #include "internal.h" -static int mincore_hugetlb(pte_t *pte, unsigned long hmask, unsigned long addr, +static int mincore_hugetlb(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long end, struct mm_walk *walk) { #ifdef CONFIG_HUGETLB_PAGE @@ -164,7 +164,7 @@ static int mincore_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, { spinlock_t *ptl; struct vm_area_struct *vma = walk->vma; - pte_t *ptep; + hw_pte_t *ptep; unsigned char *vec = walk->private; int nr = (end - addr) >> PAGE_SHIFT; int step, i; diff --git a/mm/mlock.c b/mm/mlock.c index efa6716e4dfbd..36002b80382a9 100644 --- a/mm/mlock.c +++ b/mm/mlock.c @@ -305,7 +305,7 @@ void munlock_folio(struct folio *folio) } static inline unsigned int folio_mlock_step(struct folio *folio, - pte_t *pte, unsigned long addr, unsigned long end) + hw_pte_t *pte, unsigned long addr, unsigned long end) { unsigned int count = (end - addr) >> PAGE_SHIFT; pte_t ptent = ptep_get(pte); @@ -353,7 +353,7 @@ static int mlock_pte_range(pmd_t *pmd, unsigned long addr, { struct vm_area_struct *vma = walk->vma; spinlock_t *ptl; - pte_t *start_pte, *pte; + hw_pte_t *start_pte, *pte; pte_t ptent; struct folio *folio; unsigned int step = 1; diff --git a/mm/mprotect.c b/mm/mprotect.c index 2888ee638d872..1d23475e0bb76 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -103,7 +103,7 @@ bool can_change_pte_writable(struct vm_area_struct *vma, unsigned long addr, return can_change_shared_pte_writable(vma, pte); } -static int mprotect_folio_pte_batch(struct folio *folio, pte_t *ptep, +static int mprotect_folio_pte_batch(struct folio *folio, hw_pte_t *ptep, pte_t pte, int max_nr_ptes, fpb_t flags) { /* No underlying folio, so cannot batch */ @@ -118,7 +118,7 @@ static int mprotect_folio_pte_batch(struct folio *folio, pte_t *ptep, /* Set nr_ptes number of ptes, starting from idx */ static __always_inline void prot_commit_flush_ptes(struct vm_area_struct *vma, - unsigned long addr, pte_t *ptep, pte_t oldpte, pte_t ptent, + unsigned long addr, hw_pte_t *ptep, pte_t oldpte, pte_t ptent, int nr_ptes, int idx, bool set_write, struct mmu_gather *tlb) { /* @@ -170,7 +170,7 @@ static __always_inline int page_anon_exclusive_batch(int start_idx, int max_len, * retrieve sub-batches. */ static __always_inline void commit_anon_folio_batch(struct vm_area_struct *vma, - struct folio *folio, struct page *first_page, unsigned long addr, pte_t *ptep, + struct folio *folio, struct page *first_page, unsigned long addr, hw_pte_t *ptep, pte_t oldpte, pte_t ptent, int nr_ptes, struct mmu_gather *tlb) { bool expected_anon_exclusive; @@ -189,7 +189,7 @@ static __always_inline void commit_anon_folio_batch(struct vm_area_struct *vma, } static __always_inline void set_write_prot_commit_flush_ptes(struct vm_area_struct *vma, - struct folio *folio, struct page *page, unsigned long addr, pte_t *ptep, + struct folio *folio, struct page *page, unsigned long addr, hw_pte_t *ptep, pte_t oldpte, pte_t ptent, int nr_ptes, struct mmu_gather *tlb) { bool set_write; @@ -212,7 +212,7 @@ static __always_inline void set_write_prot_commit_flush_ptes(struct vm_area_stru } static long change_softleaf_pte(struct vm_area_struct *vma, - unsigned long addr, pte_t *pte, pte_t oldpte, unsigned long cp_flags) + unsigned long addr, hw_pte_t *pte, pte_t oldpte, unsigned long cp_flags) { const bool uffd_prot = cp_flags & (MM_CP_UFFD_WP | MM_CP_UFFD_RWP); const bool uffd_prot_resolve = cp_flags & @@ -279,7 +279,7 @@ static long change_softleaf_pte(struct vm_area_struct *vma, } static __always_inline void change_present_ptes(struct mmu_gather *tlb, - struct vm_area_struct *vma, unsigned long addr, pte_t *ptep, + struct vm_area_struct *vma, unsigned long addr, hw_pte_t *ptep, int nr_ptes, unsigned long end, pgprot_t newprot, struct folio *folio, struct page *page, unsigned long cp_flags) { @@ -332,7 +332,8 @@ static long change_pte_range(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_t *pmd, unsigned long addr, unsigned long end, pgprot_t newprot, unsigned long cp_flags) { - pte_t *pte, oldpte; + hw_pte_t *pte; + pte_t oldpte; spinlock_t *ptl; long pages = 0; bool is_private_single_threaded; @@ -727,7 +728,7 @@ long change_protection(struct mmu_gather *tlb, return pages; } -static int prot_none_pte_entry(pte_t *pte, unsigned long addr, +static int prot_none_pte_entry(hw_pte_t *pte, unsigned long addr, unsigned long next, struct mm_walk *walk) { return pfn_modify_allowed(pte_pfn(ptep_get(pte)), @@ -736,7 +737,7 @@ static int prot_none_pte_entry(pte_t *pte, unsigned long addr, } #ifdef CONFIG_HUGETLB_PAGE -static int prot_none_hugetlb_entry(pte_t *pte, unsigned long hmask, +static int prot_none_hugetlb_entry(hw_pte_t *pte, unsigned long hmask, unsigned long addr, unsigned long next, struct mm_walk *walk) { diff --git a/mm/mremap.c b/mm/mremap.c index 464bed198bf93..ecb90ccee6fdd 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -176,7 +176,7 @@ static pte_t move_soft_dirty_pte(pte_t pte) } static int mremap_folio_pte_batch(struct vm_area_struct *vma, unsigned long addr, - pte_t *ptep, pte_t pte, int max_nr) + hw_pte_t *ptep, pte_t pte, int max_nr) { struct folio *folio; @@ -200,7 +200,7 @@ static int move_ptes(struct pagetable_move_control *pmc, struct vm_area_struct *vma = pmc->old; bool need_clear_uffd_wp = vma_has_uffd_without_event_remap(vma); struct mm_struct *mm = vma->vm_mm; - pte_t *old_ptep, *new_ptep; + hw_pte_t *old_ptep, *new_ptep; pte_t old_pte, pte; pmd_t dummy_pmdval; spinlock_t *old_ptl, *new_ptl; diff --git a/mm/page_table_check.c b/mm/page_table_check.c index 6ffc536359cd0..70984b4e3cde3 100644 --- a/mm/page_table_check.c +++ b/mm/page_table_check.c @@ -208,7 +208,7 @@ static void page_table_check_pte_flags(pte_t pte) } void __page_table_check_ptes_set(struct mm_struct *mm, unsigned long addr, - pte_t *ptep, pte_t pte, unsigned int nr) + hw_pte_t *ptep, pte_t pte, unsigned int nr) { unsigned int i; @@ -279,7 +279,7 @@ void __page_table_check_pte_clear_range(struct mm_struct *mm, return; if (!pmd_bad(pmd) && !pmd_leaf(pmd)) { - pte_t *ptep = pte_offset_map(&pmd, addr); + hw_pte_t *ptep = pte_offset_map(&pmd, addr); unsigned long i; if (WARN_ON(!ptep)) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index ed4860c01936c..172addf9e6558 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -26,7 +26,7 @@ static int real_depth(int depth) return depth; } -static int walk_pte_range_inner(pte_t *pte, unsigned long addr, +static int walk_pte_range_inner(hw_pte_t *pte, unsigned long addr, unsigned long end, struct mm_walk *walk) { const struct mm_walk_ops *ops = walk->ops; @@ -61,7 +61,7 @@ static int walk_pte_range_inner(pte_t *pte, unsigned long addr, static int walk_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, struct mm_walk *walk) { - pte_t *pte; + hw_pte_t *pte; int err = 0; spinlock_t *ptl; @@ -343,7 +343,7 @@ static int walk_hugetlb_range(unsigned long addr, unsigned long end, unsigned long next; unsigned long hmask = huge_page_mask(h); unsigned long sz = huge_page_size(h); - pte_t *pte; + hw_pte_t *pte; const struct mm_walk_ops *ops = walk->ops; int err = 0; @@ -909,7 +909,8 @@ struct folio *folio_walk_start(struct folio_walk *fw, struct page *page; pud_t *pudp, pud; pmd_t *pmdp, pmd; - pte_t *ptep, pte; + hw_pte_t *ptep; + pte_t pte; spinlock_t *ptl; pgd_t *pgdp; p4d_t *p4dp; diff --git a/mm/percpu.c b/mm/percpu.c index a802d72c116fb..fa79a1295c5bf 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -3176,7 +3176,7 @@ void __init __weak pcpu_populate_pte(unsigned long addr) pmd = pmd_offset(pud, addr); if (!pmd_present(*pmd)) { - pte_t *new; + hw_pte_t *new; new = memblock_alloc_or_panic(PTE_TABLE_SIZE, PTE_TABLE_SIZE); pmd_populate_kernel(&init_mm, pmd, new); diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c index b91b1a98029c7..52f286da3eec6 100644 --- a/mm/pgtable-generic.c +++ b/mm/pgtable-generic.c @@ -68,7 +68,7 @@ void pmd_clear_bad(pmd_t *pmd) * force that call on sun4c so we changed this macro slightly */ int ptep_set_access_flags(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep, + unsigned long address, hw_pte_t *ptep, pte_t entry, int dirty) { int changed = !pte_same(ptep_get(ptep), entry); @@ -82,7 +82,7 @@ int ptep_set_access_flags(struct vm_area_struct *vma, #ifndef __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH bool ptep_clear_flush_young(struct vm_area_struct *vma, - unsigned long address, pte_t *ptep) + unsigned long address, hw_pte_t *ptep) { bool young; @@ -95,7 +95,7 @@ bool ptep_clear_flush_young(struct vm_area_struct *vma, #ifndef __HAVE_ARCH_PTEP_CLEAR_FLUSH pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address, - pte_t *ptep) + hw_pte_t *ptep) { struct mm_struct *mm = (vma)->vm_mm; pte_t pte; @@ -282,7 +282,7 @@ static unsigned long pmdp_get_lockless_start(void) { return 0; } static void pmdp_get_lockless_end(unsigned long irqflags) { } #endif -pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp) +hw_pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp) { unsigned long irqflags; pmd_t pmdval; @@ -308,11 +308,11 @@ pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp) return NULL; } -pte_t *pte_offset_map_ro_nolock(struct mm_struct *mm, pmd_t *pmd, +hw_pte_t *pte_offset_map_ro_nolock(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, spinlock_t **ptlp) { pmd_t pmdval; - pte_t *pte; + hw_pte_t *pte; pte = __pte_offset_map(pmd, addr, &pmdval); if (likely(pte)) @@ -320,11 +320,11 @@ pte_t *pte_offset_map_ro_nolock(struct mm_struct *mm, pmd_t *pmd, return pte; } -pte_t *pte_offset_map_rw_nolock(struct mm_struct *mm, pmd_t *pmd, +hw_pte_t *pte_offset_map_rw_nolock(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp, spinlock_t **ptlp) { - pte_t *pte; + hw_pte_t *pte; VM_WARN_ON_ONCE(!pmdvalp); pte = __pte_offset_map(pmd, addr, pmdvalp); @@ -390,12 +390,12 @@ pte_t *pte_offset_map_rw_nolock(struct mm_struct *mm, pmd_t *pmd, * table, and may not use RCU at all: "outsiders" like khugepaged should avoid * pte_offset_map() and co once the vma is detached from mm or mm_users is zero. */ -pte_t *pte_offset_map_lock(struct mm_struct *mm, pmd_t *pmd, +hw_pte_t *pte_offset_map_lock(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, spinlock_t **ptlp) { spinlock_t *ptl; pmd_t pmdval; - pte_t *pte; + hw_pte_t *pte; again: pte = __pte_offset_map(pmd, addr, &pmdval); if (unlikely(!pte)) diff --git a/mm/ptdump.c b/mm/ptdump.c index 5851096e6f656..376880071ca2a 100644 --- a/mm/ptdump.c +++ b/mm/ptdump.c @@ -117,7 +117,7 @@ static int ptdump_pmd_entry(pmd_t *pmd, unsigned long addr, return 0; } -static int ptdump_pte_entry(pte_t *pte, unsigned long addr, +static int ptdump_pte_entry(hw_pte_t *pte, unsigned long addr, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st = walk->private; diff --git a/mm/rmap.c b/mm/rmap.c index b917431759ee0..4d19caa5f8c84 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1124,7 +1124,7 @@ static int page_vma_mkclean_one(struct page_vma_mapped_walk *pvmw) address = pvmw->address; if (pvmw->pte) { - pte_t *pte = pvmw->pte; + hw_pte_t *pte = pvmw->pte; pte_t entry = ptep_get(pte); /* @@ -2141,7 +2141,7 @@ static pte_t swp_pte_prepare(swp_entry_t entry, pte_t old_pte, static bool ttu_anon_swapbacked_folio(struct vm_area_struct *vma, struct folio *folio, struct page *page, unsigned long address, - pte_t *ptep, pte_t pteval) + hw_pte_t *ptep, pte_t pteval) { const bool anon_exclusive = folio_test_anon(folio) && PageAnonExclusive(page); @@ -2176,7 +2176,7 @@ static bool ttu_anon_swapbacked_folio(struct vm_area_struct *vma, } static bool ttu_anon_folio(struct vm_area_struct *vma, struct folio *folio, - struct page *page, unsigned long address, pte_t *ptep, + struct page *page, unsigned long address, hw_pte_t *ptep, pte_t pteval, unsigned long nr_pages) { /* diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 5a2469fb1838c..2bbf7adef511d 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -137,7 +137,7 @@ static void * __meminit altmap_alloc_block_buf(unsigned long size, return __va(__pfn_to_phys(pfn)); } -void __meminit vmemmap_verify(pte_t *pte, int node, +void __meminit vmemmap_verify(hw_pte_t *pte, int node, unsigned long start, unsigned long end) { unsigned long pfn = pte_pfn(ptep_get(pte)); @@ -148,11 +148,11 @@ void __meminit vmemmap_verify(pte_t *pte, int node, start, end - 1); } -static pte_t * __meminit vmemmap_pte_populate(pmd_t *pmd, unsigned long addr, int node, +static hw_pte_t * __meminit vmemmap_pte_populate(pmd_t *pmd, unsigned long addr, int node, struct vmem_altmap *altmap, unsigned long ptpfn, unsigned long flags) { - pte_t *pte = pte_offset_kernel(pmd, addr); + hw_pte_t *pte = pte_offset_kernel(pmd, addr); if (pte_none(ptep_get(pte))) { pte_t entry; void *p; @@ -243,7 +243,7 @@ static pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node) return pgd; } -static pte_t * __meminit vmemmap_populate_address(unsigned long addr, int node, +static hw_pte_t * __meminit vmemmap_populate_address(unsigned long addr, int node, struct vmem_altmap *altmap, unsigned long ptpfn, unsigned long flags) @@ -252,7 +252,7 @@ static pte_t * __meminit vmemmap_populate_address(unsigned long addr, int node, p4d_t *p4d; pud_t *pud; pmd_t *pmd; - pte_t *pte; + hw_pte_t *pte; pgd = vmemmap_pgd_populate(addr, node); if (!pgd) @@ -281,7 +281,7 @@ static int __meminit vmemmap_populate_range(unsigned long start, unsigned long flags) { unsigned long addr = start; - pte_t *pte; + hw_pte_t *pte; for (; addr < end; addr += PAGE_SIZE) { pte = vmemmap_populate_address(addr, node, altmap, @@ -314,7 +314,7 @@ void vmemmap_wrprotect_hvo(unsigned long addr, unsigned long end, int node, unsigned long headsize) { unsigned long maddr; - pte_t *pte; + hw_pte_t *pte; for (maddr = addr + headsize; maddr < end; maddr += PAGE_SIZE) { pte = virt_to_kpte(maddr); @@ -364,7 +364,7 @@ int __meminit vmemmap_populate_hvo(unsigned long addr, unsigned long end, { unsigned long maddr; struct page *tail; - pte_t *pte; + hw_pte_t *pte; int node = zone_to_nid(zone); tail = vmemmap_get_tail(order, zone); @@ -396,7 +396,7 @@ int __weak __meminit vmemmap_check_pmd(pmd_t *pmd, int node, { if (!pmd_leaf(pmdp_get(pmd))) return 0; - vmemmap_verify((pte_t *)pmd, node, addr, next); + vmemmap_verify((hw_pte_t *)pmd, node, addr, next); return 1; } @@ -474,9 +474,9 @@ static bool __meminit reuse_compound_section(unsigned long start_pfn, return !IS_ALIGNED(offset, nr_pages) && nr_pages > PAGES_PER_SUBSECTION; } -static pte_t * __meminit compound_section_tail_page(unsigned long addr) +static hw_pte_t * __meminit compound_section_tail_page(unsigned long addr) { - pte_t *pte; + hw_pte_t *pte; addr -= PAGE_SIZE; @@ -497,7 +497,7 @@ static int __meminit vmemmap_populate_compound_pages(unsigned long start_pfn, struct dev_pagemap *pgmap) { unsigned long size, addr; - pte_t *pte; + hw_pte_t *pte; int rc; if (reuse_compound_section(start_pfn, pgmap)) { diff --git a/mm/swap_state.c b/mm/swap_state.c index 5be825911e645..cb1b2d434a581 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -917,7 +917,8 @@ static struct folio *swap_vma_readahead(swp_entry_t targ_entry, gfp_t gfp_mask, struct swap_io_ctx ctx = {}; struct blk_plug plug; struct folio *folio; - pte_t *pte = NULL, pentry; + hw_pte_t *pte = NULL; + pte_t pentry; int win; unsigned long start, end, addr; pgoff_t ilx = targ_ilx; diff --git a/mm/swapfile.c b/mm/swapfile.c index dea2d3b36e06f..9644878c82fec 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -2476,7 +2476,8 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, struct page *page; struct folio *swapcache; spinlock_t *ptl; - pte_t *pte, new_pte, old_pte; + hw_pte_t *pte; + pte_t new_pte, old_pte; bool hwpoisoned = false; int ret = 1; @@ -2587,7 +2588,7 @@ static int unuse_pte_range(struct vm_area_struct *vma, pmd_t *pmd, unsigned long addr, unsigned long end, unsigned int type) { - pte_t *pte = NULL; + hw_pte_t *pte = NULL; do { struct folio *folio; diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 258b03182a780..f22cfb2ccb07d 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -361,13 +361,13 @@ static int mfill_atomic_install_pte(pmd_t *dst_pmd, { int ret; struct mm_struct *dst_mm = dst_vma->vm_mm; - pte_t _dst_pte, *dst_pte; + hw_pte_t *dst_pte; bool writable = dst_vma->vm_flags & VM_WRITE; bool vm_shared = dst_vma->vm_flags & VM_SHARED; spinlock_t *ptl; struct folio *folio = page_folio(page); bool page_in_cache = folio_mapping(folio); - pte_t dst_ptep; + pte_t _dst_pte, dst_ptep; _dst_pte = mk_pte(page, dst_vma->vm_page_prot); _dst_pte = pte_mkdirty(_dst_pte); @@ -656,7 +656,8 @@ static int mfill_atomic_pte_zeropage(struct mfill_state *state) struct vm_area_struct *dst_vma = state->vma; unsigned long dst_addr = state->dst_addr; pmd_t *dst_pmd = state->pmd; - pte_t _dst_pte, *dst_pte; + hw_pte_t *dst_pte; + pte_t _dst_pte; spinlock_t *ptl; int ret; @@ -737,7 +738,8 @@ static int mfill_atomic_pte_poison(struct mfill_state *state) struct mm_struct *dst_mm = dst_vma->vm_mm; unsigned long dst_addr = state->dst_addr; pmd_t *dst_pmd = state->pmd; - pte_t _dst_pte, *dst_pte; + hw_pte_t *dst_pte; + pte_t _dst_pte; spinlock_t *ptl; int ret; @@ -784,7 +786,7 @@ static __always_inline ssize_t mfill_atomic_hugetlb( { struct mm_struct *dst_mm = dst_vma->vm_mm; ssize_t err; - pte_t *dst_pte; + hw_pte_t *dst_pte; unsigned long src_addr, dst_addr; long copied; struct folio *folio; @@ -1261,7 +1263,7 @@ void double_pt_unlock(spinlock_t *ptl1, __release(ptl2); } -static inline bool is_pte_pages_stable(pte_t *dst_pte, pte_t *src_pte, +static inline bool is_pte_pages_stable(hw_pte_t *dst_pte, hw_pte_t *src_pte, pte_t orig_dst_pte, pte_t orig_src_pte, pmd_t *dst_pmd, pmd_t dst_pmdval) { @@ -1279,7 +1281,8 @@ static inline bool is_pte_pages_stable(pte_t *dst_pte, pte_t *src_pte, */ static struct folio *check_ptes_for_batched_move(struct vm_area_struct *src_vma, unsigned long src_addr, - pte_t *src_pte, pte_t *dst_pte) + hw_pte_t *src_pte, + hw_pte_t *dst_pte) { pte_t orig_dst_pte, orig_src_pte; struct folio *folio; @@ -1310,7 +1313,7 @@ static long move_present_ptes(struct mm_struct *mm, struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, unsigned long dst_addr, unsigned long src_addr, - pte_t *dst_pte, pte_t *src_pte, + hw_pte_t *dst_pte, hw_pte_t *src_pte, pte_t orig_dst_pte, pte_t orig_src_pte, pmd_t *dst_pmd, pmd_t dst_pmdval, spinlock_t *dst_ptl, spinlock_t *src_ptl, @@ -1398,7 +1401,7 @@ static long move_present_ptes(struct mm_struct *mm, static int move_swap_pte(struct mm_struct *mm, struct vm_area_struct *dst_vma, unsigned long dst_addr, unsigned long src_addr, - pte_t *dst_pte, pte_t *src_pte, + hw_pte_t *dst_pte, hw_pte_t *src_pte, pte_t orig_dst_pte, pte_t orig_src_pte, pmd_t *dst_pmd, pmd_t dst_pmdval, spinlock_t *dst_ptl, spinlock_t *src_ptl, @@ -1464,7 +1467,7 @@ static int move_zeropage_pte(struct mm_struct *mm, struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, unsigned long dst_addr, unsigned long src_addr, - pte_t *dst_pte, pte_t *src_pte, + hw_pte_t *dst_pte, hw_pte_t *src_pte, pte_t orig_dst_pte, pte_t orig_src_pte, pmd_t *dst_pmd, pmd_t dst_pmdval, spinlock_t *dst_ptl, spinlock_t *src_ptl) @@ -1510,8 +1513,8 @@ static long move_pages_ptes(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd pte_t orig_src_pte, orig_dst_pte; pte_t src_folio_pte; spinlock_t *src_ptl, *dst_ptl; - pte_t *src_pte = NULL; - pte_t *dst_pte = NULL; + hw_pte_t *src_pte = NULL; + hw_pte_t *dst_pte = NULL; pmd_t dummy_pmdval; pmd_t dst_pmdval; struct folio *src_folio = NULL; @@ -2658,7 +2661,8 @@ static inline bool userfaultfd_huge_must_wait(struct userfaultfd_ctx *ctx, unsigned long reason) { struct vm_area_struct *vma = vmf->vma; - pte_t *ptep, pte; + hw_pte_t *ptep; + pte_t pte; assert_fault_locked(vmf); @@ -2731,7 +2735,7 @@ static inline bool userfaultfd_must_wait(struct userfaultfd_ctx *ctx, p4d_t *p4d; pud_t *pud; pmd_t *pmd, _pmd; - pte_t *pte; + hw_pte_t *pte; pte_t ptent; bool ret; diff --git a/mm/util.c b/mm/util.c index bf0513d1d3d08..cc253050f6892 100644 --- a/mm/util.c +++ b/mm/util.c @@ -1564,7 +1564,7 @@ EXPORT_SYMBOL(mmap_action_complete); * * Return: the number of table entries in the batch. */ -unsigned int folio_pte_batch(struct folio *folio, pte_t *ptep, pte_t pte, +unsigned int folio_pte_batch(struct folio *folio, hw_pte_t *ptep, pte_t pte, unsigned int max_nr) { return folio_pte_batch_flags(folio, NULL, ptep, &pte, max_nr, 0); diff --git a/mm/vmalloc.c b/mm/vmalloc.c index c5d4deae8084f..a94392053e2e9 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -100,7 +100,7 @@ static DEFINE_PER_CPU(struct vfree_deferred, vfree_deferred); * * Return: mapping size. */ -static __always_inline unsigned long vmap_set_ptes(pte_t *pte, +static __always_inline unsigned long vmap_set_ptes(hw_pte_t *pte, unsigned long addr, unsigned long end, u64 pfn, pgprot_t prot, unsigned int max_page_shift) { @@ -124,7 +124,7 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, phys_addr_t phys_addr, pgprot_t prot, unsigned int max_page_shift, pgtbl_mod_mask *mask) { - pte_t *pte; + hw_pte_t *pte; u64 pfn; struct page *page; unsigned long size; @@ -406,7 +406,7 @@ int ioremap_page_range(unsigned long addr, unsigned long end, static void vunmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, pgtbl_mod_mask *mask) { - pte_t *pte; + hw_pte_t *pte; pte_t ptent; unsigned long size = PAGE_SIZE; @@ -569,7 +569,7 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, unsigned long pfn, size; unsigned int steps; int err = 0; - pte_t *pte; + hw_pte_t *pte; /* * nr is a running index into the array which helps higher level @@ -862,7 +862,8 @@ struct page *vmalloc_to_page(const void *vmalloc_addr) p4d_t *p4d; pud_t *pud; pmd_t *pmd; - pte_t *ptep, pte; + hw_pte_t *ptep; + pte_t pte; /* * XXX we might need to change this if we add VIRTUAL_BUG_ON for @@ -3759,7 +3760,7 @@ struct vmap_pfn_data { unsigned int idx; }; -static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private) +static int vmap_pfn_apply(hw_pte_t *pte, unsigned long addr, void *private) { struct vmap_pfn_data *data = private; unsigned long pfn = data->pfns[data->idx]; diff --git a/mm/vmscan.c b/mm/vmscan.c index 17d2b793cbfc4..85b6ab60d830b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3539,7 +3539,7 @@ static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, { int i; bool dirty; - pte_t *pte; + hw_pte_t *pte; spinlock_t *ptl; unsigned long addr; int total = 0; @@ -3572,7 +3572,7 @@ static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, for (i = pte_index(start), addr = start; addr != end; i += nr, addr += nr * PAGE_SIZE) { unsigned long pfn; struct folio *folio; - pte_t *cur_pte = pte + i; + hw_pte_t *cur_pte = pte + i; pte_t ptent = ptep_get(cur_pte); nr = 1; @@ -4261,7 +4261,7 @@ bool lru_gen_look_around(struct page_vma_mapped_walk *pvmw, unsigned int nr) struct lru_gen_mm_walk *walk; struct folio *last = NULL; int young = 1; - pte_t *pte = pvmw->pte; + hw_pte_t *pte = pvmw->pte; unsigned long addr = pvmw->address; struct vm_area_struct *vma = pvmw->vma; struct folio *folio = pfn_folio(pvmw->pfn); -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384384.1627370 (Exim 4.92) (envelope-from ) id 1wrteY-0008NV-8S; Thu, 06 Aug 2026 08:40:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384384.1627370; Thu, 06 Aug 2026 08:40:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteY-0008NL-1c; Thu, 06 Aug 2026 08:40:38 +0000 Received: by outflank-mailman (input) for mailman id 1384384; Thu, 06 Aug 2026 08:40:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteW-0008Ka-Uu for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:40:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrteW-003Rvn-Bg for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:36 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a744874-e002-0a2a0a5209dd-0a2a450ad1d0-32 for ; Thu, 06 Aug 2026 10:40:36 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a744882-f2d2-0a2a450a0019-d98c6eac8546-1 for ; Thu, 06 Aug 2026 10:40:35 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09CBB176C; Thu, 6 Aug 2026 01:40:30 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4AF5F3F9A2; Thu, 6 Aug 2026 01:40:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005634; bh=N7Kx8cypRY/4tgLqgkZyPCXbOC37nDVo81ML0oOq7lc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tagQFezCw9aBUWT7bOfI3ipYrSvBgGoc0nvAu5XpEVT8jAWZTUXoDkAzn54+nSZu/ C0359lFjQAXDgtRxm2t3RSVQ591J+t3FxW0ZNLk6ZGX5bMdhv/n3Wr7ekNo3EB6nJi fG5//UTE+Z1Arn0RcPLdaPIBOCt1BQtKZG1psE+U= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 5/9] mm: convert PTE table entries in ptep_get() Date: Thu, 6 Aug 2026 09:38:43 +0100 Message-ID: <20260806083926.1807279-6-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1786005636-4B0D9CFC-A15E1982/0/0 X-purgate-type: clean X-purgate-size: 1459 ptep_get() now accepts a pointer to hw_pte_t storage but must continue to return a logical pte_t value. Add __pte_from_hw for both generic hw_pte_t definitions. Read the hw_pte_t table element atomically before converting it to pte_t. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Define __pte_from_hw for the opted-in generic wrapper. - Apply READ_ONCE() to hw_pte_t before converting it to pte_t. --- include/linux/pgtable.h | 2 +- include/linux/pgtable_types.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index dad80d264aac2..1768421755a9c 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -493,7 +493,7 @@ static inline int pudp_set_access_flags(struct vm_area_struct *vma, #ifndef ptep_get static inline pte_t ptep_get(hw_pte_t *ptep) { - return READ_ONCE(*ptep); + return __pte_from_hw(READ_ONCE(*ptep)); } #endif diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h index 70c3edd00a01b..a625516fd67b1 100644 --- a/include/linux/pgtable_types.h +++ b/include/linux/pgtable_types.h @@ -8,8 +8,10 @@ #ifdef CONFIG_ARCH_HAS_HW_PTE_T typedef struct { pte_t __pte; } hw_pte_t; +#define __pte_from_hw(pte) ((pte).__pte) #else #define hw_pte_t pte_t +#define __pte_from_hw(pte) (pte) #endif #endif /* !__ASSEMBLY__ */ -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384393.1627378 (Exim 4.92) (envelope-from ) id 1wrteg-0000OR-EG; Thu, 06 Aug 2026 08:40:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384393.1627378; Thu, 06 Aug 2026 08:40:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteg-0000OK-BG; Thu, 06 Aug 2026 08:40:46 +0000 Received: by outflank-mailman (input) for mailman id 1384393; Thu, 06 Aug 2026 08:40:45 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrtef-0000NF-9N for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:40:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrtee-00HXhn-M9 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:44 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a744866-2eae-0a2a0a5409dd-0a2a4507ce48-46 for ; Thu, 06 Aug 2026 10:40:44 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a74488a-b4ea-0a2a45070019-d98c6eac85b6-1 for ; Thu, 06 Aug 2026 10:40:44 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 125021A00; Thu, 6 Aug 2026 01:40:38 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 58AF73F632; Thu, 6 Aug 2026 01:40:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005642; bh=QpJOEY7MAUNTQ3U6qtfA/cSosGpAOafJ7uPgYOeWuHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LH0Y7EZ8u+Hxz4ct2u7B3pbaW7kO2q9mCmBpSc3Gc5aIuRyHyNcQBmJ6i/FKIN1mG dO0EeHj+xqiekdjfLTdjC448G/b6+B4ErFjOTWEV9jERZSZ8hTZnDekIxcwtofLf58 Qhbc4ZPDILqETQxHx0gtUFWmYjKyy7XySo97FBTY= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 6/9] mm: convert PTE table entry to pte Date: Thu, 6 Aug 2026 09:38:44 +0100 Message-ID: <20260806083926.1807279-7-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1786005644-A52CCAE4-190B13BD/0/0 X-purgate-type: clean X-purgate-size: 685 The non-MMU stub receives hw_pte_t but returns a logical pte_t value. Convert the stored entry through __pte_from_hw() before returning. Signed-off-by: Muhammad Usama Anjum --- include/linux/hugetlb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index bc0b9c65aa1d0..9e8b391aa4bc9 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -1283,7 +1283,7 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, #ifdef CONFIG_MMU return ptep_get(ptep); #else - return *ptep; + return __pte_from_hw(*ptep); #endif } -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:40:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:40:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384400.1627387 (Exim 4.92) (envelope-from ) id 1wrten-0000ra-MJ; Thu, 06 Aug 2026 08:40:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384400.1627387; Thu, 06 Aug 2026 08:40:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrten-0000rP-Iv; Thu, 06 Aug 2026 08:40:53 +0000 Received: by outflank-mailman (input) for mailman id 1384400; Thu, 06 Aug 2026 08:40:52 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrtem-0000ov-2N for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:40:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrtel-009iCj-F2 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:51 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a744892-5cb7-0a2a0a5109dd-0a2a4505d84a-6 for ; Thu, 06 Aug 2026 10:40:51 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a744892-4cb1-0a2a45050019-d98c6eaceb6c-1 for ; Thu, 06 Aug 2026 10:40:51 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2184016F2; Thu, 6 Aug 2026 01:40:46 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 643063F632; Thu, 6 Aug 2026 01:40:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005650; bh=DTTtIRekIWF5l2t5St3KvKIy8eTeym6aWT0fxyUq96k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t/Ynr+ejNvl4R99JThgrl19rvWFbBsiFV4hn5i1ECdKW0th4VOZ7KbW1N62KnLaza TGn2qP6Pu9ZcqkbElZvF+YoQ4TJ4dUl2ixVRmZMzHmEnq7CwFY1Ip2FbKjsKbj8QSs SKPo2pQcwBYzu1+FTzMJdgVouKkCbA21MTO5pHvM= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 7/9] mm/kasan: use hw_pte_t for the early shadow PTE table Date: Thu, 6 Aug 2026 09:38:45 +0100 Message-ID: <20260806083926.1807279-8-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1786005651-F70B22A1-D909486F/0/0 X-purgate-type: clean X-purgate-size: 2312 kasan_early_shadow_pte is a complete PTE table rather than a standalone PTE value. Declare and define its elements as hw_pte_t so the object uses the PTE table storage type. Read the first element through ptep_get(), which returns the logical pte_t value expected by note_page_pte(), instead of accessing hw_pte_t storage directly. This also uses the accessor selected by the architecture. No architecture selects ARCH_HAS_HW_PTE_T at this point, so the storage representation remains unchanged. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Update the description for the architecture opt-in model. --- include/linux/kasan.h | 2 +- mm/kasan/init.c | 2 +- mm/ptdump.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/kasan.h b/include/linux/kasan.h index bf233bde68c7e..ff41949c0ac08 100644 --- a/include/linux/kasan.h +++ b/include/linux/kasan.h @@ -51,7 +51,7 @@ typedef unsigned int __bitwise kasan_vmalloc_flags_t; #endif extern unsigned char kasan_early_shadow_page[PAGE_SIZE]; -extern pte_t kasan_early_shadow_pte[MAX_PTRS_PER_PTE + PTE_HWTABLE_PTRS]; +extern hw_pte_t kasan_early_shadow_pte[MAX_PTRS_PER_PTE + PTE_HWTABLE_PTRS]; extern pmd_t kasan_early_shadow_pmd[MAX_PTRS_PER_PMD]; extern pud_t kasan_early_shadow_pud[MAX_PTRS_PER_PUD]; extern p4d_t kasan_early_shadow_p4d[MAX_PTRS_PER_P4D]; diff --git a/mm/kasan/init.c b/mm/kasan/init.c index 30c5266eaf37e..9bbc2a41d23f0 100644 --- a/mm/kasan/init.c +++ b/mm/kasan/init.c @@ -64,7 +64,7 @@ static inline bool kasan_pmd_table(pud_t pud) return false; } #endif -pte_t kasan_early_shadow_pte[MAX_PTRS_PER_PTE + PTE_HWTABLE_PTRS] +hw_pte_t kasan_early_shadow_pte[MAX_PTRS_PER_PTE + PTE_HWTABLE_PTRS] __bss_pgtbl; static inline bool kasan_pte_table(pmd_t pmd) diff --git a/mm/ptdump.c b/mm/ptdump.c index 376880071ca2a..8f19f20be3c44 100644 --- a/mm/ptdump.c +++ b/mm/ptdump.c @@ -19,7 +19,7 @@ static inline int note_kasan_page_table(struct mm_walk *walk, { struct ptdump_state *st = walk->private; - st->note_page_pte(st, addr, kasan_early_shadow_pte[0]); + st->note_page_pte(st, addr, ptep_get(kasan_early_shadow_pte)); walk->action = ACTION_CONTINUE; -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:41:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:41:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384407.1627397 (Exim 4.92) (envelope-from ) id 1wrteu-0001H3-Ta; Thu, 06 Aug 2026 08:41:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384407.1627397; Thu, 06 Aug 2026 08:41:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteu-0001Gu-QG; Thu, 06 Aug 2026 08:41:00 +0000 Received: by outflank-mailman (input) for mailman id 1384407; Thu, 06 Aug 2026 08:41:00 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrteu-0001Ep-1f for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:41:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrtet-003S2w-Ec for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:40:59 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74489a-2eae-0a2a0a5409dd-0a2a4507d156-6 for ; Thu, 06 Aug 2026 10:40:59 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a74489a-b4ea-0a2a45070019-d98c6eacb468-1 for ; Thu, 06 Aug 2026 10:40:59 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 289F5176C; Thu, 6 Aug 2026 01:40:54 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 712203F632; Thu, 6 Aug 2026 01:40:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005658; bh=Jt3lY9Rfe2qE4RAnGMFG9uUvIQ7Ln1RzFK0qs/6Pya4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=luByc3jtbBV3gUID39iGf/O7Ordl38J04J9ScF6tTrQH2SAyJst4PI5/HEx/+oO2M tC4u2VpNMwnUKS+GMCR24TnNoqgA1Zh5W58AIkL2KnpnrIKANxQnj1eS3ryjCi4BDm nxuZnsP5XbydqmOlfXFKlJJcGS7jqx3QJB3bT6Ww= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 8/9] drm/i915: use hw_pte_t for PTE range callbacks Date: Thu, 6 Aug 2026 09:38:46 +0100 Message-ID: <20260806083926.1807279-9-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1786005659-A48C9AE4-C3315845/0/0 X-purgate-type: clean X-purgate-size: 2379 apply_to_page_range() now passes PTE table storage to its callback as hw_pte_t *. Update the i915 remap and selftest callbacks to match the new type. Continue to use ptep_get() for logical values and set_pte_at() for updates. The type remains an alias of pte_t on x86 until that architecture opts in. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Clarify the effect on architectures that have not opted in. --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 ++-- drivers/gpu/drm/i915/i915_mm.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c index d01acfb7d93d0..056faf4a3618b 100644 --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c @@ -1690,7 +1690,7 @@ static int igt_mmap_gpu(void *arg) return 0; } -static int check_present_pte(pte_t *pte, unsigned long addr, void *data) +static int check_present_pte(hw_pte_t *pte, unsigned long addr, void *data) { pte_t ptent = ptep_get(pte); @@ -1703,7 +1703,7 @@ static int check_present_pte(pte_t *pte, unsigned long addr, void *data) return 0; } -static int check_absent_pte(pte_t *pte, unsigned long addr, void *data) +static int check_absent_pte(hw_pte_t *pte, unsigned long addr, void *data) { pte_t ptent = ptep_get(pte); diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c index fd89e7c7d8d6f..aab88e8edf946 100644 --- a/drivers/gpu/drm/i915/i915_mm.c +++ b/drivers/gpu/drm/i915/i915_mm.c @@ -48,7 +48,7 @@ static inline unsigned long sgt_pfn(const struct remap_pfn *r) return r->sgt.pfn + (r->sgt.curr >> PAGE_SHIFT); } -static int remap_sg(pte_t *pte, unsigned long addr, void *data) +static int remap_sg(hw_pte_t *pte, unsigned long addr, void *data) { struct remap_pfn *r = data; @@ -70,7 +70,7 @@ static int remap_sg(pte_t *pte, unsigned long addr, void *data) #define EXPECTED_FLAGS (VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP) #if IS_ENABLED(CONFIG_X86) -static int remap_pfn(pte_t *pte, unsigned long addr, void *data) +static int remap_pfn(hw_pte_t *pte, unsigned long addr, void *data) { struct remap_pfn *r = data; -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 08:41:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 08:41:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384415.1627406 (Exim 4.92) (envelope-from ) id 1wrtf6-0001vI-5X; Thu, 06 Aug 2026 08:41:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384415.1627406; Thu, 06 Aug 2026 08:41:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrtf6-0001ut-1q; Thu, 06 Aug 2026 08:41:12 +0000 Received: by outflank-mailman (input) for mailman id 1384415; Thu, 06 Aug 2026 08:41:11 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrtf5-0001q0-6l for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 08:41:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrtf4-0034l4-0O for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:41:10 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74489f-2eae-0a2a0a5409dd-0a2a450c9f88-28 for ; Thu, 06 Aug 2026 10:41:09 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a7448a2-f479-0a2a450c0019-d98c6eac8690-1 for ; Thu, 06 Aug 2026 10:41:07 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34C59153B; Thu, 6 Aug 2026 01:41:02 -0700 (PDT) Received: from e142334-100.cambridge.arm.com (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7CABF3F632; Thu, 6 Aug 2026 01:40:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="From:To:Cc:Subject:Date:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786005666; bh=26js+M9zWrHNC4a3AjcYSrQ4VRwzJZBtm9+Mxf/tKbk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TTBSkLercTTP8PzXx2W54PajQtmr3ocTbHrCDjoVYDyhLdl97U7CcPQ3qilKSBkf9 vIh9ep96aTHrl1x02wMw5yGa/VgSgdxL9PNbjwHpeKiFJfhkPl82/MnNvLvZO9B0+j c9NuO4Hhw/STBkgcZsI3sprKusZaJGcpuNEKybDo= From: Muhammad Usama Anjum To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: [PATCH 9/9] xen: use hw_pte_t for PTE range callbacks Date: Thu, 6 Aug 2026 09:38:47 +0100 Message-ID: <20260806083926.1807279-10-usama.anjum@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806083926.1807279-1-usama.anjum@arm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1786005667-03AD4A5B-5E84EDC5/0/0 X-purgate-type: clean X-purgate-size: 3287 Generic PTE range and remapping helpers now pass pointers to PTE table storage as hw_pte_t *. Update the Xen callbacks to match those interfaces. Keep logical PTE values as pte_t and continue to access them through the existing PTE helpers. This is required when Xen is built for an architecture that selects the distinct hw_pte_t wrapper. Signed-off-by: Muhammad Usama Anjum --- Changes since RFC v1: - Clarify why the callback conversion is required after architecture opt-in. --- drivers/xen/gntdev.c | 2 +- drivers/xen/privcmd.c | 2 +- drivers/xen/xenbus/xenbus_client.c | 2 +- drivers/xen/xlate_mmu.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 1dcc4675580ed..b013bcad99b5b 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -301,7 +301,7 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map) /* ------------------------------------------------------------------ */ -static int find_grant_ptes(pte_t *pte, unsigned long addr, void *data) +static int find_grant_ptes(hw_pte_t *pte, unsigned long addr, void *data) { struct gntdev_grant_map *map = data; unsigned int pgnr = (addr - map->pages_vm_start) >> PAGE_SHIFT; diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 725a49a0eee72..b4a487dcc9ecb 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -1658,7 +1658,7 @@ static int privcmd_mmap(struct file *file, struct vm_area_struct *vma) * on a per pfn/pte basis. Mapping calls that fail with ENOENT * can be then retried until success. */ -static int is_mapped_fn(pte_t *pte, unsigned long addr, void *data) +static int is_mapped_fn(hw_pte_t *pte, unsigned long addr, void *data) { return pte_none(ptep_get(pte)) ? 0 : -EBUSY; } diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c index 27682cb5e58ab..387f97a555594 100644 --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c @@ -749,7 +749,7 @@ int xenbus_unmap_ring_vfree(struct xenbus_device *dev, void *vaddr) EXPORT_SYMBOL_GPL(xenbus_unmap_ring_vfree); #ifdef CONFIG_XEN_PV -static int map_ring_apply(pte_t *pte, unsigned long addr, void *data) +static int map_ring_apply(hw_pte_t *pte, unsigned long addr, void *data) { struct map_ring_valloc *info = data; diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c index 8efd7b55223fb..d7244f9f9a545 100644 --- a/drivers/xen/xlate_mmu.c +++ b/drivers/xen/xlate_mmu.c @@ -93,7 +93,7 @@ static void setup_hparams(unsigned long gfn, void *data) info->fgfn++; } -static int remap_pte_fn(pte_t *ptep, unsigned long addr, void *data) +static int remap_pte_fn(hw_pte_t *ptep, unsigned long addr, void *data) { struct remap_data *info = data; struct page *page = info->pages[info->index++]; @@ -269,7 +269,7 @@ struct remap_pfn { unsigned long i; }; -static int remap_pfn_fn(pte_t *ptep, unsigned long addr, void *data) +static int remap_pfn_fn(hw_pte_t *ptep, unsigned long addr, void *data) { struct remap_pfn *r = data; struct page *page = r->pages[r->i]; -- 2.47.3 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:32:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 09:32:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384465.1627415 (Exim 4.92) (envelope-from ) id 1wruSG-0007St-S7; Thu, 06 Aug 2026 09:32:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384465.1627415; Thu, 06 Aug 2026 09:32:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wruSG-0007Sm-On; Thu, 06 Aug 2026 09:32:00 +0000 Received: by outflank-mailman (input) for mailman id 1384465; Thu, 06 Aug 2026 09:31:59 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wruSF-0007Sg-0H for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 09:31:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wruSD-00F3hd-SX for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 11:31:57 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74547e-e002-0a2a0a5209dd-0a2a4501ddde-46 for ; Thu, 06 Aug 2026 11:31:57 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a74548c-5984-0a2a45010019-b9ff1c238c9b-3 for ; Thu, 06 Aug 2026 11:31:57 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fd66a3fd5000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 06 Aug 2026 09:31:55 +0000 Received: from [192.168.1.18] (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie) by mail2.vates.fr (Postfix) with ESMTPSA id 7341280143; Thu, 6 Aug 2026 11:31:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=H1/fDbtueoAwVW3NxBpCSNwTTB+L6V1ifVuLniu1eT0=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=lRkORnFdwoF3/T8ot2U0iQSVIAPMq407z+wV9lvfVRbARHPNBoDpMUSDMvqFwSyAljBV39ErJ 6lVLdY3l9IcHEpc5ILwwPv1IWm1JxPjRmBjvFrl34GPdBP97M2sTcCjWNQnNTulADrtomg2NaEQ NpP9zqYf8vAabQ7V6vMv68VUdUs1DSpJuBJa6NjeFub5BIRvmgJ0h/6C3/sPgKeVAELE/PhZQ5Q AEQSS46KY5qI4DBK0H2iH4MR/bh18Z0j94EpVmC01LK89X/n9nElV5WepvpNoNbWNSeClxEYDUb a45WJnehuCSPK7u1CHsHcc5c8NfGFoB162atyOqEFgQA== X-Zone-Loop: 6287a73f1fb7823a2cc539e32ecfd4b93bb4fd248b5d x-campaign-type: default x-transaction-id: 658cb477-1178-4c71-b777-d4b628fef0ed x-swg-uid: 01-34470f5a-29de-496a-aa18-199d4b415288 X-Mailer: Sweego Message-ID: <1786008715.8631fc262581453bbf619ec5b2062170.19fd66a3fd5000e099@vates.tech> x-swg-bid: 1786008715.8631fc262581453bbf619ec5b2062170.19fd66a3fd5000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Thu, 6 Aug 2026 11:31:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/svm: mandatory update VMCB nextrip for soft interrupts To: Chunjie Zhu , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jason Andryuk Cc: xen-devel@lists.xenproject.org References: <20260806031732.10242-1-chunjie.zhu@citrix.com> Content-Language: en-US From: Teddy Astie Autocrypt: addr=teddy.astie@vates.tech; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa In-Reply-To: <20260806031732.10242-1-chunjie.zhu@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RQ0cKYyiZfxQAjq0mGLb0A08" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786008714614 X-purgate-ID: tlsNG-d62444/1786008717-BFE68757-CF656530/0/0 X-purgate-type: clean X-purgate-size: 6615 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RQ0cKYyiZfxQAjq0mGLb0A08 Content-Type: multipart/mixed; boundary="------------2ihUYEGYZ0TyVk9YM9E0oq6X"; protected-headers="v1"; hp="clear" Message-ID: <37659b5a-486e-48e0-b4a4-1ff4819598b1@vates.tech> Date: Thu, 6 Aug 2026 11:31:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/svm: mandatory update VMCB nextrip for soft interrupts To: Chunjie Zhu , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jason Andryuk Cc: xen-devel@lists.xenproject.org References: <20260806031732.10242-1-chunjie.zhu@citrix.com> Content-Language: en-US From: Teddy Astie Autocrypt: addr=teddy.astie@vates.tech; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa In-Reply-To: <20260806031732.10242-1-chunjie.zhu@citrix.com> --------------2ihUYEGYZ0TyVk9YM9E0oq6X Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 TGUgMDYvMDgvMjAyNiDDoCAwNToxNywgQ2h1bmppZSBaaHUgYSDDqWNyaXTCoDoNCj4gU2ln bmVkLW9mZi1ieTogQ2h1bmppZSBaaHUgPGNodW5qaWUuemh1QGNpdHJpeC5jb20+DQo+IC0t LQ0KPiAgIHhlbi9hcmNoL3g4Ni9odm0vc3ZtL25lc3RlZHN2bS5jIHwgOSArKysrKysrKy0N Cj4gICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+ IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9zdm0vbmVzdGVkc3ZtLmMgYi94 ZW4vYXJjaC94ODYvaHZtL3N2bS9uZXN0ZWRzdm0uYw0KPiBpbmRleCBiMDYxMjRjMmM5ZWQu LjgxNTcxM2I4YjUwNiAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS9zdm0vbmVz dGVkc3ZtLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS9zdm0vbmVzdGVkc3ZtLmMNCj4g QEAgLTQ0OSw3ICs0NDksMTQgQEAgc3RhdGljIGludCBuc3ZtX3ZtY2JfcHJlcGFyZTR2bXJ1 bihzdHJ1Y3QgdmNwdSAqdiwgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpDQo+ICAgICAg IG4ydm1jYi0+dmlydF9leHQuYnl0ZXMgPQ0KPiAgICAgICAgICAgbjF2bWNiLT52aXJ0X2V4 dC5ieXRlcyB8IG5zX3ZtY2ItPnZpcnRfZXh0LmJ5dGVzOw0KPiAgIA0KPiAtICAgIC8qIE5l eHRSSVAgLSBvbmx5IGV2YWx1YXRlZCBvbiAjVk1FWElULiAqLw0KPiArICAgIC8qIG5leHRf cmlwIGlzIGNvbnN1bWVkIG9uIFZNUlVOIGFzIHRoZSByZXR1cm4gYWRkcmVzcyBwdXNoZWQg b24gdGhlDQo+ICsgICAgICogc3RhY2vCt2ZvcsK3aW5qZWN0ZWTCt3NvZnTCt2V4Y2VwdGlv bnMvaW50ZXJydXB0cy4gVGhpcyBhc3NpZ25tZW50DQo+ICsgICAgICogc3RhdGVtZW50IG11 c3QgYmUgZW5mb3JjZWQsIG90aGVyd2lzZSwgaXQgbWlnaHQgY2F1c2UgdmNwdSB3ZWRnZS4N Cj4gKyAgICAgKg0KDQpXZWxsLCBpdCdzIG1vcmUgdGhhdCBucmlwIHNlbWFudGljcyByZXF1 aXJlcyBucmlwIHRvIGJlIHByb3Blcmx5IA0KY29uZmlndXJlZCBpbiB0aGUgdm1jYi4gVGhh dCBsb29rcyBsaWtlIGEgbWlzc2luZyBwaWVjZSwgYnV0IHdlIG1heSANCnN0aWxsIHdhbnQg dG8ga2VlcCBzb21lIGluZm9ybWF0aW9ucyBhYm91dCB3aGF0IGhhcHBlbnMgb24gdGhlICNW TUVYSVQgc2lkZS4NCg0KPiArICAgICAqIEFQTSBWb2wuMiBFdmVudCBJbmplY3Rpb24gZG9l cyBub3Qgc3BlY2lmaWVzIHdoYXQgaGFwcGVucyBpZiBORVhUUklQDQo+ICsgICAgICogaG9s ZHMgYW4gaW52YWxpZC9nYXJiYWdlIHZhbHVlLg0KDQpUbyBtZSwgaXQncyBzaW1pbGFyIHRv IHNldHRpbmcgUklQIGRpcmVjdGx5IHRvIGEgYm9ndXMgdmFsdWUuIG5yaXAgaXMgDQpqdXN0 IGEgIm5leHQgaW5zdHJ1Y3Rpb24gcmlwIiBiYXNpY2FsbHkgKHdydCBldmVudCBpbmplY3Rp b24sIC4uLikuDQoNCj4gKyAgICAgKi8NCj4gKyAgICBuMnZtY2ItPm5leHRyaXAgPSBuc192 bWNiLT5uZXh0cmlwOw0KPiAgIA0KPiAgICAgICAvKg0KPiAgICAgICAgKiBWTUNCIFNhdmUg U3RhdGUgQXJlYQ0KDQpUZWRkeQ0K --------------2ihUYEGYZ0TyVk9YM9E0oq6X-- --------------RQ0cKYyiZfxQAjq0mGLb0A08 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmp0VIkFAwAAAAAACgkQZg+p0QLLz9D1 OAv8CTskpTSydVdROIYyIF8Mf17Yj/Tqg8xy9XWovx3ENaMf77enPEB4WK8cj7Ch9oPR25s9HNtO oruWr9d94kW+EsroKP3TvcVlhX6zV0T5lst0it2c7HSHgiPc1oWhNigRbOQzbIhlCw9mBUJ968sc 28APvzUunNizul5VQ2YIuaGanELbW67ZEJxR8ueMotQPnJAJgpoUAESDdAD3AlqV+q5TtTqpTZWJ uJX06Pq4IfL8FPlhlGLedQhxImhGHYJplIJX5AvN6TiNpWEZmQUQlKVLFiLPZJchRYH1VXBclt5h 1Wxulj3fEH2tL981/Oe6ySG4RHHbrY5IFdWVumMW53ePKWSCRR97Z45uF9EBDbIjJNao7oenSDF+ GSM2cnM3yvM9oAjROtNxTI6J9S+M4WN+ZmvG/ziyiRsMBrG+viWeG8CK4gbhOZG+RCoPGLcGClKL qeePJ4Aou0FbyadIMH0JJR5dJZhVJs6pp1cqD44IjilzBf7AFEiQK2QYD4W2 =mrhF -----END PGP SIGNATURE----- --------------RQ0cKYyiZfxQAjq0mGLb0A08-- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 09:40:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 09:40:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384478.1627424 (Exim 4.92) (envelope-from ) id 1wruaD-0001ip-Km; Thu, 06 Aug 2026 09:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384478.1627424; Thu, 06 Aug 2026 09:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wruaD-0001ii-H0; Thu, 06 Aug 2026 09:40:13 +0000 Received: by outflank-mailman (input) for mailman id 1384478; Thu, 06 Aug 2026 09:40:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wruaC-0001ia-3i for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 09:40:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wruaB-003eUK-Gm for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 11:40:11 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a745675-5cb7-0a2a0a5109dd-0a2a4506d7c6-8 for ; Thu, 06 Aug 2026 11:40:11 +0200 Received: from [52.101.43.44] (helo=SJ2PR03CU001.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a745679-195a-0a2a45060019-34652b2cf386-4 for ; Thu, 06 Aug 2026 11:40:10 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by LV1PR03MB989626.namprd03.prod.outlook.com (2603:10b6:408:3f8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Thu, 6 Aug 2026 09:40:06 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.019; Thu, 6 Aug 2026 09:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dFe+kXS/DunfMfIlyc/I2JaQNHUwKjfl3rBafT6AiFi0UrppemzPsQFaTAeo6uQvqwyiZtjHybEcSRGI3OdvWYvo77aDowp8a0qZh4+fSXwIum8Xty3feGN5wALOPPo3m82c0tZyU/cBUe+ORjUQZc9TsC7YfTEplwCnPsOt2jCV0Il7pW7oYTJXYZt4fNQCEvfbpQr41kWaflSSXsqO8uyDMqmKkE9gz1E3YlvioRBG0YOjiiy6s7/uB5YjLtp7pPwbxNBNOvr8VrN8CQDBk2wo6H2tcwIm8YZ7guziOPvLiv6GImGbmjhKL9mU7D2QXSREcGXv1MFVZUCGECGRhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sQBE6PmyIsgW0exlUidMoLkPd7iub8pgxLjMotEfFkY=; b=pCWl3+NzWIVRG1tMyH3essZU8iu5LRZin5qNv9lBIrcNENATygzp/GoS9MlMRQhv83cJ1OHXY2cRnrJyVD4fMoFBm0yCtTKUE3Chu8dNfw5mU1zqztFWa3azz1Saot2G5gBRnDviD6iqY1A+j/OAfHb/NBYaCJDdXwhwao5wscEaZPF6bLfn84B/T+3xRLRmX2jPOQNSvlAooZ1pt9jpYOEonIt0Ni1D3iB2XWtLui1w6uuuO4R56YQzLy+zcwHCREOdhXcTUS7xRxCOM8Y6/mu4rq4CL9A5VIZd3xm5MFo7UzVi9vh9OF98lKzi/AwDHqQ8lvXID4go7SlT6tgx8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sQBE6PmyIsgW0exlUidMoLkPd7iub8pgxLjMotEfFkY=; b=fauHB9+wzoLKDIjGVg63CYXD8enma692aCrS0qGxk9XCebMKNn1aPfY1upaaYGHFKY3gaEVpbvJ3M+MR1cj4vi1dxPmeeYtuFqAO3duWnpIpTm+r9QSeZOIyCtmt2KpfYGIuhwPnh8WhKrYFaSwr7XW2O5OFYgpPGs+RLn/5rJo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 6 Aug 2026 10:40:03 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , xen-devel@lists.xenproject.org Subject: Re: [PATCH 5/5] x86/nmi: Don't configure EvtSel repeatedly To: Jan Beulich References: <20260805124525.105457-1-andrew.cooper3@citrix.com> <20260805124525.105457-6-andrew.cooper3@citrix.com> <0b38417e-2c59-4df1-8429-ec7c98ce22d6@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <0b38417e-2c59-4df1-8429-ec7c98ce22d6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0548.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::11) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|LV1PR03MB989626:EE_ X-MS-Office365-Filtering-Correlation-Id: 192567b1-1fb6-4044-a964-08def39eb2a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|366016|1800799024|10067099003|56012099006|11063799006|5023799004|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: LmJxxGPFVEFIS1AYsUQDDOVkAqQRz4fWcygsNamIXxJEKmVnuId6uBVNudOuET1LDaeK5/BEMiTAQMsBI2lReW1xohu3LCiywIYSVH5kdXZlkSqjD4QhdXndcJeSsFD3gbG9jnLWzKPhx14z5Qk2G+Oy0qtjwtlcRprJ0XOXlBJRy+FxvYDBR5eGhBlFNKdXyt7dbHjqeV7mHkyPBAVDkEQes/Y8kjtTbRlYzAXJwc3nFUgEnQXTjxbF9suCjM/9NBBfIbFC5mH4/jf6nAn403mZvMXuUX0adYf6HtMnNGqcjF5O/pDHHO4cm8+n9f9yzw+ulCXD1LkNN544KFWEMyiAw8tn0aa8zbnd+ajXXDNH9FsLJHvblb75Q0K0R/aLQHEPUi1G53n13gwdIO2w/ANQTdyUFvdlWt8ahoMQSLuTlGQA1yd96mspMuhhUyDkEfcMpjyUIDYSDKZiKMbihCl7dW6iXGwW1Ax58SK9xJU/e3yGdcvYiWWhQAFwSab7hbCF63yfll1TN8uDY3iYRt0H34M3tG67d5/xXkpx7lImVC6uGwOEnxshK4FXWguvcmG+uhv6KKZEDTFqKDElM2fVm0Cu27sRe1aSIpy6iKbVQHjB7cDo87UdoxzqtVcylC/tO/jzUbP1O9pTzElcT+De7cUpBhKagVTwjt4qmZ0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(10067099003)(56012099006)(11063799006)(5023799004)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vm9la3NPdHArbWVEWlNMZFNCTUo3eCs3Zi9xUnVGQzI1S3dvNDY3ZVYzY3Vy?= =?utf-8?B?a1loMG5aU1I1THVVWFg2b1lmQUpqbjdmclNYcU1BUHdRVHMydDBESTdwWS9q?= =?utf-8?B?d2VuNVpncFUwSjdVbTRYS0RXVU1YYXpMeTNLams4MzJsL3h2OEZ4T0kwYS8r?= =?utf-8?B?WjVlRWFaak9pN1JYaloxbkRFejJuRWkwckt0SWVnazVCTWNpQzF5SzFLZmdK?= =?utf-8?B?YTZlTnlsYXRRaFpha0Z0N045YmR2TzBGSCsrd3o1ZXdhTjFYVFpSM3BSd0ZF?= =?utf-8?B?TS9yeHpBZUFTOXBjNGQvVDRVUjFFQXQ5bjdkbnljd3ZoYjU4UU5sNEdsc3hV?= =?utf-8?B?NFp6c2dVQ1VGV2ljZEJkVzR6VU5qT1E0aEhCWUM2UjVDWEdWbHNCbE94Z29E?= =?utf-8?B?M3RINk1VNkg1VnR4RXJjSDQ0c0pRMkgycndXVzlhYmFDWTdKRHpRZzZvRWNv?= =?utf-8?B?N2s2cVpwTU82SHZWSGRLTm1vMlZkRTRCOHpORHlmWHhURXFpeFVKZ1cyYXdR?= =?utf-8?B?akliVWV6aURvc1VxdVpleXc2OUFKMWxreW5vWlI3UzBuY0xqRmtiNnl3Q1Vk?= =?utf-8?B?LzNVZDhhblNodmRlRThYZHBzV05xODZISElDT05URnhjVDhnTXdzZzcwRkZX?= =?utf-8?B?Y2tJRURiRUdOVkwwRU1QS1ZQd1QveHNxRC9CaCtwV0NQT1BxeGJGREk1cHBY?= =?utf-8?B?RVFVaVloQ09oVWxhMlN5a1RzdEFSeWQySFhnTDB0MFFFTUUwbHVLZGdTME9V?= =?utf-8?B?MTNBMVM3cWZVSTJucmVVYlY0M0EwanZ3NDY4ZEVQUU8wZFc5YUVMRDRaSmhZ?= =?utf-8?B?R05ERkQ4eGVCYlkvTDVvU2lYOUQzSW5aSTVhRnlqaUxDQ2pzZjF4dDN4K1Jl?= =?utf-8?B?UFVybVVnSTBIM1RYYXhzemhMWU92VEtMTFBNb0UvbGQvREQ0MURBSCt1T1ky?= =?utf-8?B?YnA3MFhSVU1VcWMvZitrT3V6TjJSc013WTlXWFZIbVh4dEQrR2NjZUplRENv?= =?utf-8?B?WTRzYWk1RWYvN210Ukt5bWoreXZFRktJVitqcC8vQUVNM0t1UzB4SlJOUlRq?= =?utf-8?B?UzZqRE8rZy8vcUVBWjJnSGZyT0lqc1lyNmtGeXJwRlhUMi9PanNCNjJFTG1V?= =?utf-8?B?bE9rdE5XSkxRb0xkclhnVGJia2NIanoxZVJCRndHTWNpaE9FcnkyU254SjFY?= =?utf-8?B?Q1pxNVJ3ZXNnOTJKcExzNkoyR29PSUFNeWJLajJjdDVwdUVDMXhxNElsQVA5?= =?utf-8?B?V1hzb2ttV2pwaWI4d0JwNVJiVjR1SHU3SVVHWXluYXVUczMvTURVK1Ywd0Vo?= =?utf-8?B?Y2R6U3Z5bFE5UFhOaE43Uk9WZmVQazhkcW0vTlo1NjFUWXNwai83N3dBYjB2?= =?utf-8?B?T3dzalp1S2lDYm1rVVVnWHBpaXpBNUh5UitJVVFWdk81YXByM1pHdjlDWkFu?= =?utf-8?B?dkVQUVh6UjVuZUZtQnZCRDlQUVdLQm1jQVl5c25ObXc3dU9WQVh0RHZCL2VJ?= =?utf-8?B?RGRhRG91cGZxY2pNV2JtNXZGZjcxTkFrUUFwNXkyYVB2a2NvOE44ajJoM0FB?= =?utf-8?B?MGFHTWtmZEUrb3lpcUVpUUVWY2lqY2N2ZFQxaUJIUFgxQUJ0enMvRGc4U1h5?= =?utf-8?B?cW55U0VmSUZUcUVsK2FnOHo0TVFCWkdORG1DSEdRYmdtSWZJU0txdHl0eFdm?= =?utf-8?B?bjFES1hrVFNzMWVDSEdjOVQ0b2tEa0xxbGIwbTB2M0JxMW1GdU9HMDlScGpw?= =?utf-8?B?dW9yMFM4WWhXNzhtYXh4VXRQdjYyR2VDM1VacmJzU2RYZThDakJGN3liaUZ4?= =?utf-8?B?cjQzTldUUUN3VEpoY0s2Q1NzeWRpc051TFZjQWtKaHpIenJpT1QrZTBVVmVv?= =?utf-8?B?dWtYWDk0M3JvRGJ0aGl5a1J3dEhXclFQWDlWVVNDMWcvdkwwcjdxSUF4NmpF?= =?utf-8?B?WllPZm13U24ycUZmQ1NnNjRnRnZzNFpyU3RJcDJ0Wkw0Q05GWlF1a2JjTXpG?= =?utf-8?B?QmFuazQ5WU9KRi8yZjBLano1Nlc1NEdIUVVHa2xYbzhoY3o1SndKL3YvdGg2?= =?utf-8?B?MkV4OXYzYlpKR01TNS9hMnEzOE1sVG8yL1pxeDl0TnNNK0RycmRYcElONnN0?= =?utf-8?B?UXI3dU1mTGNDM0l6MDBZcEQ0a1EydkdjNENCTHVOaEZWMXpjVjZUMjNBQUUw?= =?utf-8?B?MUVucStNVitJY2F6TldPWVlML0tnY1hMdUZUakFIdUd3SlY4SDRNSnowSXp3?= =?utf-8?B?WWtqYm9IZ2kzdXJMY1RNc2wzeVA0S2Faa3AwRUlLcGdhOWRiVjUzSGQzN2wz?= =?utf-8?B?QVA3WTNXdW13M0NpNHlIRGQ0em9tWThueUZHdHBNaW9DQTRneGptQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 192567b1-1fb6-4044-a964-08def39eb2a5 X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 09:40:06.1614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mwz+k5e4PI+fH0GSjsLQJtqOsyUR5ssr5Pl1Y19ShP3X9VxhJs87bY+H6xKZWcf+s++ZBKdu3VY8dVI/T/4Vb1tjxkGZX0hbb2V2F05wvCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV1PR03MB989626 X-purgate-ID: tlsNG-16d1c6/1786009211-F580D77B-4BB27AB1/0/0 X-purgate-type: clean X-purgate-size: 1283 On 06/08/2026 7:57 am, Jan Beulich wrote: > On 05.08.2026 17:37, Andrew Cooper wrote: >> On 05/08/2026 3:20 pm, Jan Beulich wrote: >>> On 05.08.2026 14:45, Andrew Cooper wrote: >>>> In both setup_{k7,p6}_watchdog(), EvtSel0 is first zeroed, then written with >>>> everything but the enable bit, then written with the enable bit. >>>> >>>> setup_p4_watchdog() is slightly more complicated, owing to what >>>> appears to be a bug introduced by commit 2a2bd8de16b6 ("Clean up NMI >>>> watchdog handler."), which causes a second bit to be temporarily >>>> different too. >>>> >>>> The middle of the three writes is useless in all cases. Drop it. >>> Spotting the 1st write in setup_p4_watchdog() wasn't quite as easy, as >>> MSR_P4_BPU_CCCR0 (as passed to clear_msr_range()) has nothing to do with >>> MSR_P4_IQ_CCCR0. Using unrelated MSR names there is as unhelpful as using >>> raw hex numbers. >> Perf counters on the P4 are utterly insane, but our local logic really >> doesn't help matters. >> >> Another option would be to remove P4 watchdog support, in the basis that >> we really can't test it. > Well, my Tulsa system is still alive, and the watchdog looks to be working > there. Oh, if you're still able to test, then that's even better. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 06 10:44:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 10:44:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384562.1627440 (Exim 4.92) (envelope-from ) id 1wrva0-0000Wp-5E; Thu, 06 Aug 2026 10:44:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384562.1627440; Thu, 06 Aug 2026 10:44:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrva0-0000Wi-2S; Thu, 06 Aug 2026 10:44:04 +0000 Received: by outflank-mailman (input) for mailman id 1384562; Thu, 06 Aug 2026 10:44:03 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvZz-0000Wc-7P for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:44:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrvZy-007XZa-4H for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 12:44:02 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74655b-e002-0a2a0a5209dd-0a2a450be1d8-44 for ; Thu, 06 Aug 2026 12:44:02 +0200 Received: from [40.93.196.65] (helo=SA9PR02CU001.outbound.protection.outlook.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a746570-b7e8-0a2a450b0019-285dc441fe8b-3 for ; Thu, 06 Aug 2026 12:44:01 +0200 Received: from CH8PR03MB8274.namprd03.prod.outlook.com (2603:10b6:610:2ba::5) by SJ0PR03MB5503.namprd03.prod.outlook.com (2603:10b6:a03:288::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Thu, 6 Aug 2026 10:43:57 +0000 Received: from CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096]) by CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096%7]) with mapi id 15.21.0292.019; Thu, 6 Aug 2026 10:43:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e+WjnN1x62m821yepLlTypVVUw2lA5aoIKF/Aj+OADbpN6Gfk4SSjKzzA3DzRWdEvaNse+5gFNj+3Q7fx11NjKhDSC+pKppLP8UEkmbGuat2pAL+1lE5AwjumN91IrN/9sVBVEAOLVhLJQsc4mHhk+9+r19lumR4fESbpeGvAOHnesGqTd930fH8MQ7s7yTnaeufBpNxDBLeYKu5Xf3UbHa+o73oDNndWYloFbbP3GOjo7BWj6FU9NIWi9uh+a/mv+14HlTGKDnNU3jeH54ttfnpCXzkQ/nQGgKIYE27xY/qczx8GfoSqji76KJJg2gqj+JVIt8dIi0N5fkPtwFcaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7rJ/ii9+zYru9tGxrnZ9ThdtN66dT0Yw8UgDRDt0hto=; b=EDfjIMxn+reGV3AAwKWSJbsSMUSd2W//FxwBoWORVU4FKHStWsWScrebw7vxXxRwMgOUAg/hF+M0caLqM8R167ByV/nP4IpBSvmGtF1SxTLcSS+8IiDmGLbQZEfkvvNClm46Ww/KxcqmOSV6smQWK1kKfiPth03tQgoACpZ/GzVFBzcAVfHwMW7mx6InFORj91WgNy3Y6TopLsVJsXBxLKMYV3XicoiFz19djMkfFX5zFQvHgGYTIo6f58vYIqp3KeEAwm6zcfPrUWpJpOjv69rpRWGiZoZV9ThOAO/j00e7L2sNLIy4jZ2DNDpNwoQRkvW7fgcv60quHQE2onvX1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7rJ/ii9+zYru9tGxrnZ9ThdtN66dT0Yw8UgDRDt0hto=; b=0IMavQE5UjYj+VpvNUvqtKvMX7939XpLDT9D4p6vFPXXtTv3Rc6Q0GcRTv27AGvbfaB+TDW1mM7JypX1c0dR1z6bt2BD9bCugGL43j8Rnq+R6O/y/dG8f1qLT12AI2wwPiXT8UVbElHORKWtL3A//k3PcpG5c+0TRswOTEuIP7w= From: Ross Lagerwall To: Andrew Cooper , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Roger Pau Monne , Jason Andryuk , Teddy Astie Subject: Re: [PATCH v1 1/6] nestedsvm: Fix CR3 MBZ check Thread-Topic: [PATCH v1 1/6] nestedsvm: Fix CR3 MBZ check Thread-Index: AQHc7Qzj6Zyg1vqVRkydd+9Jb6lnwrYgRXUAgAAGJoCAcPgFxA== Date: Thu, 6 Aug 2026 10:43:56 +0000 Message-ID: References: <20260526124027.573412-1-ross.lagerwall@citrix.com> <20260526124027.573412-2-ross.lagerwall@citrix.com> <6e81d92d-cef7-43e4-8dfc-08c5edbb504d@citrix.com> In-Reply-To: <6e81d92d-cef7-43e4-8dfc-08c5edbb504d@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH8PR03MB8274:EE_|SJ0PR03MB5503:EE_ x-ms-office365-filtering-correlation-id: b8e387ad-18e9-4930-33ea-08def3a79db3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|56012099006|11063799006|4143699003|10067099003|22082099003|18002099003|38070700021; x-microsoft-antispam-message-info: nVk/XadbjvbD4dlpOG/3qfpklA81R6BhOTF+CdQOJ6UEUbXICWst23Eq5ss5IZRD9eZEht01l1ckxSKVN8JxFqNBPECbgejEEML6R2pLbNm0kzbHqBg62jR+k7K4LP2dOu2XKQVHTH4KjrPRZUSriYdWraed4QmudJafSOFCJUis//5HAY9853e+6JCdWkZYraAl+DGx/7d1XZZHRhb9h9FmXcEmd83lAKZK4wt7ofP6guaWVpTNaOA7I9jzMtpj22BYTtfIRq1uXLVPVOmCqPjsAXuVDQNGGFb8T+PaKC8O4zaeE1DD4FU96s2En7Glu1zO9rIZgcI1+tc9b5Ecu8LWk8iqTK/N+c34DZt8fdrLYpPI1AhTG6s/xTk2A46n14Ri0j4U+fAbzE3G0Cw9pgpyNAvarPEBgTt8l5ach06pA8gUbwre0DDwl/iLzoK3RPp7LPgWBckTvc0wkuBfx7pQiQFf0wQtYma4D+4pmXK7uz5POUX6SYCAFei/TkFpE62nMhQ69u2JLIb9mkJjFfJFR0sZAiSvjJ6cmtIsGAZWV6oLzMiN1PwrEsj/7mkHnIuqGm7qqkpAUl0tDbAF43GiyjQ/sDuviefoWgeKPrOBs/24M8IgnDVYPP8OjbVhHle6SpsTPiY2c8MZzwu9Pv2X6t3VMdoA73aHesDVIpSsd4Ir5Io95rNEVfjhLomUZis6qMS2ybSzB95u7ljsxfL/F70lqFCfmHAkL4510ok= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8274.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(56012099006)(11063799006)(4143699003)(10067099003)(22082099003)(18002099003)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?4MsTEWwLufj0XGW0kg4xA8JQV5HbfCK99up3iyykBGpVMwwOZc4L63C6pC?= =?iso-8859-1?Q?iRroVpdPwltGDc35/Olmvva5sxJUSPphrMtvwtrJVo3esqL0iOChRaPArO?= =?iso-8859-1?Q?7WbTMvOBWOzXtJw+fyNzMoJiCFmiRn56oCdLJfEmNFVgfEI4qzDp6nsxU3?= =?iso-8859-1?Q?6GjxIQrdB5WN2AkMUihxWrz19Rk1aMGOg0o9Rcfjxhvb91wZHPYynFiz+d?= =?iso-8859-1?Q?TSgo4WUnf6j8M7jw11PAwQQgX+ex9Qu8sTH3qifu+G41TXXumWuxAc+CyQ?= =?iso-8859-1?Q?NUGQPFA991qSPm4X4gk+aj8PZBNHPAvmC162mWRK710SlBE4kLrYnJn/PC?= =?iso-8859-1?Q?52/4gJai5w56sBiE+LoMFVmhpiUwOPl3RNPVFYKc1xgzRnlw659me78Imt?= =?iso-8859-1?Q?P3ogKm5B7UjG4SP67CrrMVYiW52vudi2xknE0ZG3dQL7xZtv6fHiVbRHRH?= =?iso-8859-1?Q?UiKXyytloIrapCVOgdF4b9jLRvjOuAUP5oH4VhikuGfHZdGHy1h8YCY6I8?= =?iso-8859-1?Q?dEMjv//8oG7vgZc5J6TRaYEVvyP4JnFN2Y52d3kzVLOLhkTX196xvXAf67?= =?iso-8859-1?Q?Zx/VlSrdTH/zSUuG8J2SzU4JKeg1AAGKA/GuxRtoMhfdulyL/sXa8S+WjX?= =?iso-8859-1?Q?dKZQaHp7HAZ5mU0LozCIa4c/KIpmZZyX+zOok+mgx7RSlgthKa2Y6aigZG?= =?iso-8859-1?Q?V2nTApoqLu6XVSXU+QHEZ0zXYQTEvWrHxlSg0WpCHy6ckgHubgQC1UWPHI?= =?iso-8859-1?Q?Qm1iIbf/UItwI6ZsSLy5dhIJPwU68upkkrEYm8q8QjNvhLfpNRf1vpoKU9?= =?iso-8859-1?Q?SOj19Vin/3BVd0EKeUgDvUEiV0O1Wss12rY1Ayl2+yT5ljiMGtqBJoY2dy?= =?iso-8859-1?Q?wojmTgWDgJUtYbXPtDsUHLEwd0gK31esC8uWLJGUo0I/LnSrJd9yUShOuQ?= =?iso-8859-1?Q?ARdg/DKg0KyWYCZjMUUZRM0a9nE12odacvyI2eVM6BscH+dYSgr0UVV/o5?= =?iso-8859-1?Q?u62YFNMVVOurr4b1Kgrn2lBXTgBhyQnC2xOM+6LwH9SfrkDoiTPLuECQYv?= =?iso-8859-1?Q?0SBXh5ZCOyFDPkHkLYtQW8lWArEGGSsrWs6V2MOhhpV3IRQ1R22jFmLXuU?= =?iso-8859-1?Q?Qy3c4TyjJqXKTJ8ml8T8yEBj9teVW81xSGysNoW0oI3eL6QXx8rxej8THL?= =?iso-8859-1?Q?2ga1aGDvbzZDrC2H10OxH3j2jqMVfTBkAiC2ij1RsDIXER4+nkcE67Dzam?= =?iso-8859-1?Q?3EC2b/6eNHQy5PAqg9fZBZ6qhbGZHBlps9APq/9TrOzBFP5aYrgpOpuzLT?= =?iso-8859-1?Q?6qHF6EV1yr8mWTlOAeeVj5robtoAuloVK6Olevha3Jc81wpMGdXVACnO49?= =?iso-8859-1?Q?YLQDDMm5x+NIyPGypcy2PAYvN38Hx8iOwH+zZyOwkUQAfDvIJcSxcfTjLi?= =?iso-8859-1?Q?7rDMUVS93QMEqTeDYIqLhBYaxtv+Fbv4icnv7XEkuDaIMMEubN+Ks+7eYT?= =?iso-8859-1?Q?BwNAo/rWRT3MFgBwlGzOEVzNpCW7b3wgDU8jNXVcKimzkTePtbIBx5S6J4?= =?iso-8859-1?Q?SEVhAFaitaqx8RSmntR+a5z5Xy9SY+VsvKgSrhrGj/qzL/RuvanPKL4x2j?= =?iso-8859-1?Q?pIuuiF5PvIgP4BEewy3mPhqSA9UBPzrXFkKA0Bv1dztBAaJKgfhsGOvkNO?= =?iso-8859-1?Q?+FqVu5JYSoYYt4ATFrhIlcYn8ltcxL8f4zQt39CQw/G2JlPcxyJHv3QSh9?= =?iso-8859-1?Q?ZOBuwEV3kyjx3NR1VkVvLtx7SI0pSOcFvFlj6clFXpKYHsVfF1v+t1zMgO?= =?iso-8859-1?Q?cjLBBye1vA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8274.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8e387ad-18e9-4930-33ea-08def3a79db3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2026 10:43:56.3654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KQtrGXFI+BKnqPnlGYMBbEg32qCJAn5NOcRQPVxoSqTuwYrLqx7B/hPql9pVYh7nuStlOoDWH6mrQothEa+90EFjxXyToyuorEHiNYt8MWQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5503 X-purgate-ID: tlsNG-42698a/1786013042-A98C19EA-BEBCB92D/0/0 X-purgate-type: clean X-purgate-size: 3155 > From: Ross Lagerwall=0A= > Sent: Tuesday, May 26, 2026 2:23 PM=0A= > To: Andrew Cooper; xen-devel@lists.xenproject.org=0A= > Cc: Jan Beulich; Roger Pau Monne; Jason Andryuk; Teddy Astie=0A= > Subject: Re: [PATCH v1 1/6] nestedsvm: Fix CR3 MBZ check=0A= > =0A= > On 5/26/26 2:01 PM, Andrew Cooper wrote:=0A= > > On 26/05/2026 1:40 pm, Ross Lagerwall wrote:=0A= > >> The existing code checks for any reserved bit set while the APM only= =0A= > >> considers it invalid if an MBZ bit is set. Relax the check to match th= e=0A= > >> APM and hardware.=0A= > >>=0A= > >> Some of the reserved bits were observed to be set running Rocky Linux= =0A= > >> 10.1 on Xen on Xen.=0A= > >>=0A= > >> Fixes: 9a779e4fc161 ("Implement SVM specific part for Nested Virtualiz= ation")=0A= > >> Signed-off-by: Ross Lagerwall =0A= > >> ---=0A= > >> xen/arch/x86/hvm/svm/vmcb.c | 6 ++----=0A= > >> 1 file changed, 2 insertions(+), 4 deletions(-)=0A= > >>=0A= > >> diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c= =0A= > >> index 975a1eaef806..9ada491e57db 100644=0A= > >> --- a/xen/arch/x86/hvm/svm/vmcb.c=0A= > >> +++ b/xen/arch/x86/hvm/svm/vmcb.c=0A= > >> @@ -347,10 +347,8 @@ bool svm_vmcb_isvalid(=0A= > >> PRINTF("CR0: bits [63:32] are not zero (%#"PRIx64")\n", cr0)= ;=0A= > >>=0A= > >> if ( (cr0 & X86_CR0_PG) &&=0A= > >> - ((cr3 & 7) ||=0A= > >> - ((!(cr4 & X86_CR4_PAE) || (efer & EFER_LMA)) && (cr3 & 0xfe= 0)) ||=0A= > >> - ((efer & EFER_LMA) &&=0A= > >> - (cr3 >> v->domain->arch.cpuid->extd.maxphysaddr))) )=0A= > >> + ((efer & EFER_LMA) &&=0A= > >> + (cr3 >> v->domain->arch.cpuid->extd.maxphysaddr)) )=0A= > >> PRINTF("CR3: MBZ bits are set (%#"PRIx64")\n", cr3);=0A= > >>=0A= > >> valid =3D hvm_cr4_guest_valid_bits(v->domain);=0A= > >=0A= > > The APM does say MBZ for VMRUN, but the end result of a VMEntry (virtua= l=0A= > > or otherwise) must be a legal CR3 value.=0A= > >=0A= > > For 5.2.1 CR3 Register (Legacy) and 5.3.2 CR3 (Long), the APM states:= =0A= > >=0A= > > Reserved Bits. Reserved fields should be cleared to 0 by software when= =0A= > > writing CR3.=0A= > >=0A= > > What's the real behaviour for trying to set a reserved, non-MBZ bit in= =0A= > > CR3? On Intel it's strictly a #GP, and I really hope it's the same on = AMD.=0A= > >=0A= > > i.e. I really hope this is a documentation error on AMD's behalf, and= =0A= > > not a misfeature we need to support.=0A= > >=0A= > =0A= > An hvm32pae XTF test that does this...=0A= > =0A= > write_cr3(read_cr3() | 1);=0A= > printk("cr3 is %lx\n", read_cr3());=0A= > =0A= > ... succeeds and prints:=0A= > =0A= > cr3 is 105001=0A= > =0A= > This was similarly observed by the KVM folks in this thread:=0A= > https://patchwork.kernel.org/project/kvm/patch/20200713043908.39605-1-nam= it@vmware.com/#23578493=0A= =0A= Ping, Andrew?=0A= =0A= The existing check doesn't mirror what hardware does and causes real-world = failures.=0A= Can this patch go in?=0A= =0A= Ross= From xen-devel-bounces@lists.xenproject.org Thu Aug 06 10:46:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 10:46:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384571.1627448 (Exim 4.92) (envelope-from ) id 1wrvcG-00018c-Ih; Thu, 06 Aug 2026 10:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384571.1627448; Thu, 06 Aug 2026 10:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvcG-00018V-G4; Thu, 06 Aug 2026 10:46:24 +0000 Received: by outflank-mailman (input) for mailman id 1384571; Thu, 06 Aug 2026 10:46:23 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvcF-00018L-Lg for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:46:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrvcF-00FJJc-2K for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 12:46:23 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7465f0-5cb7-0a2a0a5109dd-0a2a450ce2a2-30 for ; Thu, 06 Aug 2026 12:46:23 +0200 Received: from [40.93.196.47] (helo=SA9PR02CU001.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7465fd-f479-0a2a450c0019-285dc42fd2aa-4 for ; Thu, 06 Aug 2026 12:46:22 +0200 Received: from CH8PR03MB8274.namprd03.prod.outlook.com (2603:10b6:610:2ba::5) by SJ0PR03MB5503.namprd03.prod.outlook.com (2603:10b6:a03:288::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Thu, 6 Aug 2026 10:46:19 +0000 Received: from CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096]) by CH8PR03MB8274.namprd03.prod.outlook.com ([fe80::ebe2:32c1:d2be:a096%7]) with mapi id 15.21.0292.019; Thu, 6 Aug 2026 10:46:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n7PpmMRu13Cb0988JUFHrsR4dEaVBYXtkf5REmmf5G5iBQvsBgzUZUliI+lsgJhZcy2BVLB1GjmanNebzkaptef8Q/7+Vl9lHHVSm53lSSdRkNGAo8eDVYc0YozKplWi/zWuQVvOlQfSA490M31CaDc899uDhn23nIfVvn5V2juVT6CaGxlcYfHMYY3yGk0VULv8ZDnP0sImEHqJZd/5yqSOulDbARCfC6rPY8QO2y/LL6wS/DotYOBJPD/rb+C1/FyvQMoHkRzXgasXOo+kHZdTExWvUD6ilV1kJggyo/iABT1O7KT5GKOJUY5JWS5r+7Hy5gPnq2dI2/KnUigS5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zeAbZflcsgtYbs0Djv2pO3bp8Pg7BdliWHPU2oAikOk=; b=qz/QEIGNBEmaO7lLsFIJX6wfjlgwMIycEqvkpj+TeVMs97mbN/sg3j/ViKI8AoMReDA1x7CqCFkkBWtURbV2FTt2EgzclkkeLWF/l951Ks3X1Fz67hMTl8SU22Iq5mIOJ9oA2HqXCyijQLOX6P15wY76jcNP7ukwlqucgCuWSnEf/d7U0yo9doJ2HAlfN1OzeeBjGQEL8E038N7Tm7IU1X2RRQ3X0Hw1+FcZBZ2z964ZcFWy5Lxd+e+7+YBShCpXl4L590T1yRKbnf9XJGd+rYkepIkXg4ptSYpySlzagpuy9BORriWiPSrHxILgxQbM5yKYnHUuGilqs8fZjotJ1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zeAbZflcsgtYbs0Djv2pO3bp8Pg7BdliWHPU2oAikOk=; b=hedUaixTku8z3Y2Qq8I9RsS3bBCDxiVBPipExXoeamqRlmx9t8tfUeVbHt2O72DNxI2jVuy1el2OPVPYNFeBBBuYQnxUA1L+Wth6d4ET6F1/uA/8CRtb70uparNrrlaSzb2gIRyeqUKubkBonFSgvEJ5tRztTiMKmp4ODkGcJ7I= From: Ross Lagerwall To: "xen-devel@lists.xenproject.org" CC: Jan Beulich , Andrew Cooper , Roger Pau Monne , Jason Andryuk , Teddy Astie Subject: Re: [PATCH v1 0/6] nestedsvm: Misc fixes Thread-Topic: [PATCH v1 0/6] nestedsvm: Misc fixes Thread-Index: AQHc7QzgdzWBfRT220y6Z9wl6s7+W7aRRvIr Date: Thu, 6 Aug 2026 10:46:19 +0000 Message-ID: References: <20260526124027.573412-1-ross.lagerwall@citrix.com> In-Reply-To: <20260526124027.573412-1-ross.lagerwall@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH8PR03MB8274:EE_|SJ0PR03MB5503:EE_ x-ms-office365-filtering-correlation-id: e545e8d1-cc4e-4d33-467f-08def3a7f337 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|56012099006|11063799006|5023799004|10067099003|22082099003|18002099003|38070700021; x-microsoft-antispam-message-info: +DBpt7k6bS8bMBa2Sm226Sf4SWa5djM80KgbdvWdf6PAVO6a6fiAsi9+L+jbf5K/6zhg8jsvWN4TV9RQnbmi8kjfOtXgLK29R9wb/YLxcvYIK1gzo10cS7lXaxYIVkljygkZ4kkZOYULQtzkWA/2ISZuOtrQ0uJATriY5J365ftJ8YYxYHxMzWHARPVeml+FONeKXWSkozi8kdbMROyehJkQ7ak0H58efYdpqFiXHhWow+1wnVC1Os4iY4CDWCCWJ9BJGtoQ/RZ8kKGM4r/Coc4MyjYMyYVrsTAsNjEqpgMYhXp4rgl2bgFXlzBR8LfNDK1sNJ2yfwRg0XkyHnVnRIvuhI5FWQbrML9qYFRqtEEWygzBcHgVQDynQQpt/e8Y9xy+NZlcitYXJ+GRMh81hUEuSkXSQuz0Uq3nNcF3auPxVNOlHgPp/Ti+0I9a2r0Bkq1wju6KqRnnvhaw0bOMrW/HB3i2hg+MhKXzjr3hQ56G0Z35Pkkfz2lst/lfr+LawsesYrPGwj1oPmviVi9bcKkET20zbe5wDIAGsB888F43tTGJYqUVXR+j8zDokxpzUHyXBjT+QSHwo2347afbIkA22sGB7p1GlxQWFgN9JMDNmCck3zB+mR5VtqlkZCGlnfkEEVgecw1gh7fOSS/hp6rxmwK2JumY2crTQCdsBfV1iHLRdwURUGiEp98Qdi2BZ/uIbqMnhWRu1GYHcC9dvhsC43a40Q7HRdU6ijL0ZUs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8274.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(56012099006)(11063799006)(5023799004)(10067099003)(22082099003)(18002099003)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?qEGHupsILwS+48f/krHsv4ZXJ2RdoZUgVTwsmm2jNninBGw4M/cHG1U6G8?= =?iso-8859-1?Q?peI9JMYYB/R/5TCJNqo+I27IaVixvFQxyJjHCTw3ME0qxyiZUG5j/zSGXB?= =?iso-8859-1?Q?1dSckOz706OYjoR16js0Z72cpyQpEBASdSiGIvvIUf2IjB/WcerbJGMLYt?= =?iso-8859-1?Q?PobAKZD2d/DVWFam323VbCTHmdq2tVDTta03AZqCmTA6us7E52aexwUwP9?= =?iso-8859-1?Q?3V32FKnvSoAX/li2yeyY+0NPsExZAXS4MvA7itVie06rPeTOvH/nYB7bc8?= =?iso-8859-1?Q?w/GvCL8taIKAbfaM0NCs7YkWYVIw9shZ6rAf4EKEowh3D2HfoVzXsjjBnX?= =?iso-8859-1?Q?w8jUiv+7HquPB6DEoKQNDNWjOJ9NHP0dGMV5tBYo9dOrUbIOw25mcyJT0E?= =?iso-8859-1?Q?yndjyk/85p1XOFT30PQq0rqn1UqFZelnC4InSzl5otVrW2X+BIEzzS06RZ?= =?iso-8859-1?Q?KvBY/pfwX4lUMSz0fbEV5xJQKfVXLr2lkSIvoiJw5T6XSI+3lOvLORdTUN?= =?iso-8859-1?Q?/QFNKqzoXyK2DXWJ3sNbTQi94OSm+8ZZDMGclBQJUCItOvc+RF7ZN5si4Z?= =?iso-8859-1?Q?xuiP2YnUY+DNJMRVZxLE32Nu8aQCjWxFFgkW6mViogqTCWk9+8S7IFlUUL?= =?iso-8859-1?Q?+WIH/vdRPwMxUVnc+Jqy8zz8Qz/FmJGvPBcEaaj7kShvvGJk/s+1EAfY01?= =?iso-8859-1?Q?khyIHjYoRVP9IcTB2EvuHRh8S2eAbpwwBcng2RJjPmy5LLTf+dmDVvVRFP?= =?iso-8859-1?Q?7umxuFaT+SRfxrpZCZkFlbjbKDPfx8etPIgSOA29UoGZ8Tac7WSn/S9WQU?= =?iso-8859-1?Q?pyqlb8l4KHJEmnxEM4EMo4mXZv69LuzciG7wBK8orgaKQ0tW7afGRfYgLy?= =?iso-8859-1?Q?XaqKLsznnqzHgLqjSTr49KoxmspdoPN31gOdfzmN3bNeQPRXHQyWv3KIrW?= =?iso-8859-1?Q?di28O+BXwSBfr7I3+rMGiwy8ur5xH7GsqbEv+TEgjKcgIyY7ygICAU0jhK?= =?iso-8859-1?Q?JVvOv+NqjqHLj6ZWz0PuV89Mqzf6kLRJR6M4PHuWf50+kisIXuvVt7MJYA?= =?iso-8859-1?Q?XpbDC6/+58oxyN4YuF5GXNa7xXEKScZ81kSsg9J4YpnDUMDwSZLeWE7fRQ?= =?iso-8859-1?Q?+riDaWFJz25B/k4FnB4+STjnheU50DOBA7TkB/0IgNAszTpp79p/MEdze9?= =?iso-8859-1?Q?cDA6eNebsrUoPeELNuoPNtAVkO60vC6y3oMn+n0xWtyf9cuB37CRKpmeeA?= =?iso-8859-1?Q?Bx3Mudn3nofceQ/2ogNReoB24rsco4oJvC+FKqzPF67s7vvi4w3HJpnjOo?= =?iso-8859-1?Q?YH6FIdNDTLGjMplSvKuqCxVJndNrthyvoZuD1wb5amV+GCm+dIxHD6XgaK?= =?iso-8859-1?Q?2aM7mBEEjBaRdjh5zawlQWPICYDrRO/hAchtO6U0MZc72LIcbMXmKTiIgQ?= =?iso-8859-1?Q?5imvlw1ZI/kdmuxoYdWFqygTuPrsUIWcnfoYYahkyviLjJVPHZj8f972oR?= =?iso-8859-1?Q?4Kch14qjHPB8P/xGqMy243Ijo0pTHYDo0GX3MkWbCfFK7k5K01LeV0qfgQ?= =?iso-8859-1?Q?cu3T9OEvRATRQm3eExVkiHtrFydDnnY4RLVRsTbHTGAJQSvhCVzXdXX7Zt?= =?iso-8859-1?Q?wFSujHVuzKJ/RRrqECeqfNoRqlTWYsLKqmApfeyHBy/S/3B3/5DqI2WJ79?= =?iso-8859-1?Q?oE6o+FkFJmGswbUx40EgUMmSCWR/fQHCSdvLm6oouPaPOIcKkzddEAKBS1?= =?iso-8859-1?Q?R3P8CPFISmW1SJtpgZgoNmBkdH2aCpCuYz/y5Q2lmPLjHEdKfAL/b6C8SP?= =?iso-8859-1?Q?7WF9JJz1fg=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8274.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e545e8d1-cc4e-4d33-467f-08def3a7f337 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2026 10:46:19.8251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qV6bCrhHmZxwy4xS/4ljTBTPkh+bg0tQtIkWjNOnl9CIF7F6kUiL9dpCrn/fKiN9J8eWeNqGieBSh72szuA5Ye/OQVE6CxlcsdIoTM88IyI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5503 X-purgate-ID: tlsNG-d25034/1786013182-032D8A5B-C2D00A0C/0/0 X-purgate-type: clean X-purgate-size: 1234 > From: Ross Lagerwall=0A= > Sent: Tuesday, May 26, 2026 1:40 PM=0A= > To: xen-devel@lists.xenproject.org=0A= > Cc: Ross Lagerwall; Jan Beulich; Andrew Cooper; Roger Pau Monne; Jason An= dryuk; Teddy Astie=0A= > Subject: [PATCH v1 0/6] nestedsvm: Misc fixes=0A= > =0A= > Before this series, running Linux on Xen on Xen on a modern AMD=0A= > processor would lock up L1 shortly after L2 reached the bootloader.=0A= > Furthermore, L1's domain could not be destroyed.=0A= > =0A= > After this series, repeating the same results in L2 crashing shortly=0A= > after it reaches the Linux kernel but L1 survives and its domain can be= =0A= > properly destroyed. This is not great but is at least some small amount= =0A= > of progress.=0A= > =0A= > Thanks,=0A= > Ross=0A= > =0A= > Ross Lagerwall (6):=0A= > nestedsvm: Fix CR3 MBZ check=0A= > nestedsvm: Adjust L2's DR intercept when adjusting L1=0A= > nestedsvm: Use the correct VMCB for vGIF=0A= > nestedsvm: Set GIF during VMRUN if vGIF is enabled=0A= > nestedsvm: Fix deferred event injection=0A= > nestedsvm: Allow destroying the domain fully=0A= =0A= Ping? Can I please get some reviews on patches 3, 4, and 5 please?=0A= =0A= Thanks,=0A= Ross= From xen-devel-bounces@lists.xenproject.org Thu Aug 06 10:55:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 10:55:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384586.1627459 (Exim 4.92) (envelope-from ) id 1wrvlP-0003xH-FD; Thu, 06 Aug 2026 10:55:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384586.1627459; Thu, 06 Aug 2026 10:55:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvlP-0003xA-Af; Thu, 06 Aug 2026 10:55:51 +0000 Received: by outflank-mailman (input) for mailman id 1384586; Thu, 06 Aug 2026 10:55:50 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvlO-0003x4-FH for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 10:55:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrvlN-00A61n-SW for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 12:55:49 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74682d-2eae-0a2a0a5409dd-0a2a4507b530-20 for ; Thu, 06 Aug 2026 12:55:49 +0200 Received: from [209.85.218.54] (helo=mail-ej1-f54.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a746835-b4ea-0a2a45070019-d155da36c597-3 for ; Thu, 06 Aug 2026 12:55:49 +0200 Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c1c24ec9525so325530266b.1 for ; Thu, 06 Aug 2026 03:55:49 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c203642435dsm235407766b.44.2026.08.06.03.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 03:55:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786013749; x=1786618549; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=xWlyahj/sMjy6rjl58blxQkLJ8D2LwIzxmQQ1iH7RK8=; b=cRTT9L98pyCyyGRAr6yVPOiK359gWpF2b2nft3GqSddxkIar1MIPIknJvbS7TK4jKP 855O6hhyrnn9JbUFEdPRuK1VMURhRrqrZMQ+R/19Mgx3wkx1fp1D7upSMdg0frNJm+aO 4Ve/2h8Ry44MtgLBNBToUYVKBtLNkHZVCh7zNJ5RnywA1wZfV6Ow3lHFINjqx0EcBQ4L M5J15y6VJXw4jrMutQ4yN5WibrLsCrHxzxzmI3Wp7fUSuPdivxgU3D1ZHb4RqmmLkzFF IpVcCmxYXQmPdIS3iPwc7NoCzKRq0W9CEq+N2/Ox0XkPSBdilKlecl7r41+g3d+ejUo6 N5UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786013749; x=1786618549; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xWlyahj/sMjy6rjl58blxQkLJ8D2LwIzxmQQ1iH7RK8=; b=UdWe0/toFAPhcrvHMCcydKwLlAE6RXxOx1FwP2v8FLedSF/3EuSOthbWxjNG89uctu WwZdQBL0TxAnBvSz7o9juh2NKjTqh1yaB4xGdz8lio5Df/9BCUi3T22YknlENoMhgxls QzwMc2ZVicwoF1heX9c28VxenwguEnyg6yd641isGFa9ojBIpzuzrZgCIpz7th4f4tsb ezABykdD17dNl61DKLG/jBO4JgWaQemeRUSnOWH+ykpb8uuvCY2cIEEZWkRYDzTSM2vB FyDimyMwNA+w5OI5SUe1Or6zyS86So/renk3PZFKRYutbSkH3F7wFiNwiAYQcCuMqj++ PpWg== X-Forwarded-Encrypted: i=1; AHgh+RpInJmP+NdGVN9CIhpjf2PobKusA9KkfOcWT4oEuZ9fApm5WeywJObR0hLQzG/jGI6z0DkZOajJp3Q=@lists.xenproject.org X-Gm-Message-State: AOJu0YyeDmjqe+aaY2CjhJnf6s4iviTKRpX8nbEyAf11afn/ruSEAPpx oigzfLhtMwBATTq7JsEyEA+T63d2GothCdklqL03fNNvHfRlu/li4KOmSeeqbfkxyg0= X-Gm-Gg: AR+sD12NeMn0m1dmIB1CInzMIbI73CV6fYoGnPmMzbY3b0S6ggmoOpWmTDaWDQ/JYkt TC4j7f6PyyCIlPMmAbNWdslHfzJSeGnbytPilIwv0ioXWgHvTjqbbGO7Tz1EFSWhMvI/oIJA2Lx 4Vl9X7IMqzfmNlxla4uCa2Y/LWieBlU73UUryIf2DZguh8/0qHzb5QmWsEOvrMTDOnGIj7bfi0o aOre6Wp4nLcQhhSxoI+98Mi0idhWPCSk8FaZgSVI8n5SC2Ammswl0OlOAeqI1z6mAQ9gZmvfj4f fiA5GZWpO8I85OY+Z8khI8rpYtyMbD/QBGbyOAev2Pe5+lME8WhvM4u5pxLxE3UipvQH6QJtRjK /4w5ZWHHr8BZ4sXbEUKhYn1We/zl0//45WTVgfjBtm7PqTPZArvyNFdEggzIoIN/PlPwYxPVm9t iEVNYW9WgRcYCHQXqSnVD3XJLwro/defxF5bUv4uoYgDoz/cIIhDf5apXzhyAiBFDM4WNVGIe45 cHcK1kmCvGniHuPYortlCEQCrqne5wOVg3dPv+DISUzGH2KpS8Ch81dhgWvL9PrhgBa+fJbR/kn CKyAcGx6oWVb7IPilmOtX41eNUE= X-Received: by 2002:a17:907:97d3:b0:c15:e33b:8c4d with SMTP id a640c23a62f3a-c2039ad16a9mr695343566b.4.1786013749295; Thu, 06 Aug 2026 03:55:49 -0700 (PDT) Message-ID: <083db883-558a-4000-b404-bf170c8309ee@suse.com> Date: Thu, 6 Aug 2026 12:55:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] xen: Fix PV-only build To: Jason Andryuk , Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Jane Malalane , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20260806015233.202486-1-jason.andryuk@amd.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <20260806015233.202486-1-jason.andryuk@amd.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------gzu0resIcHTErGXU9L6jffqY" X-purgate-ID: tlsNG-ef75cf/1786013749-A7AD0AE4-1F58DC6E/0/0 X-purgate-type: clean X-purgate-size: 7261 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------gzu0resIcHTErGXU9L6jffqY Content-Type: multipart/mixed; boundary="------------L5O05nTVmBw2yqdmWVg9WV73"; protected-headers="v1" From: Juergen Gross To: Jason Andryuk , Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Jane Malalane , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <083db883-558a-4000-b404-bf170c8309ee@suse.com> Subject: Re: [PATCH 0/2] xen: Fix PV-only build References: <20260806015233.202486-1-jason.andryuk@amd.com> In-Reply-To: <20260806015233.202486-1-jason.andryuk@amd.com> --------------L5O05nTVmBw2yqdmWVg9WV73 Content-Type: multipart/mixed; boundary="------------dAXaIYIpph80x9DFkCdb7Wm8" --------------dAXaIYIpph80x9DFkCdb7Wm8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDguMjYgMDM6NTIsIEphc29uIEFuZHJ5dWsgd3JvdGU6DQo+IEFsbG93IGRpc2Fi bGluZyBYRU5fUFZIVk0gZm9yIGEgUFYtb25seS4gIEEgc3R1YiBpbiB0aGUgZXZlbnQgY2hh bm5lbA0KPiBjb2RlIG5lZWRzIHRvIGJlIGZpeGVkIGZpcnN0Lg0KPiANCj4gSmFzb24gQW5k cnl1ayAoMik6DQo+ICAgIHhlbi9ldmVudHM6IEZpeCB4ZW5fc2V0X3VwY2FsbF92ZWN0b3Ig c3R1Yg0KPiAgICB4ZW4vS2NvbmZpZzogc2VsZWN0IFhFTl9QVkhWTQ0KPiANCj4gICBhcmNo L3g4Ni94ZW4vS2NvbmZpZyAgICAgICAgICAgICB8IDggKysrKystLS0NCj4gICBkcml2ZXJz L3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYyB8IDIgKy0NCj4gICAyIGZpbGVzIGNoYW5nZWQs IDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gDQoNCkkgZGlkIGEgY29tcGFy aXNvbiBvZiBhIGtlcm5lbCBidWlsdCB3aXRoIHlvdXIgcGF0Y2hlcyBkaXNhYmxpbmcgWEVO X1BWSFZNDQphbmQgbXkgcGF0Y2hlcyB3aXRoIFhFTl9QVkhWTV9HVUVTVCBkaXNhYmxlZC4N Cg0KVGhlIGtlcm5lbCBidWlsdCB3aXRoIG15IHBhdGNoZXMgaXMgNiBieXRlcyBzbWFsbGVy IHRoYW4gdGhlIG9uZSB3aXRoIHlvdXINCnBhdGNoZXMuDQoNClNvIEkgZG9uJ3Qgc2VlIGFu eSByZWFzb24gdG8gdGFrZSB5b3VyIHBhdGNoZXMsIHdoaWNoIGNvbmZsaWN0IHdpdGggbWlu ZSwNCmVzcGVjaWFsbHkgYXMgbXkgcGF0Y2hlcyBoYXZlIGEgbmVnYXRpdmUgZGlmZnN0YXQg b24gc291cmNlIGxldmVsLCB0b28uDQoNCg0KSnVlcmdlbg0K --------------dAXaIYIpph80x9DFkCdb7Wm8 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------dAXaIYIpph80x9DFkCdb7Wm8-- --------------L5O05nTVmBw2yqdmWVg9WV73-- --------------gzu0resIcHTErGXU9L6jffqY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmp0aDQFAwAAAAAACgkQsN6d1ii/Ey+b ZQf/eR48/c6KEp1olIh7+JTTsmH0G/RHs3eVKzlrAUmx17yAJxXhxEBiCbNuFtTdpRc4SFAWWi2d XLjAxZtiokcZc5oGlpwzz/wgcoKdlAmbUeEdUHo/dHPeWh2SHHK51pEPMq0QCr/mawOqo85QqtGp hG0KNePaAbCA7n/sQWbU5ZBmZ7dZfkpK/bksP5KWv198P4M4QsdAIV+xZnzGLf5ffnV8e7LjGu+j j3QLat8JdlvwVnI14qguA8Ce8D9GQopQXd497qZqGhLWtP7UZWxSLU2FVVGL0I2LN7XFsVbTDJqm +WltejLIAw3PP+bhWWUuu7eWKoonlNWr0jlf50QEDA== =Bbn+ -----END PGP SIGNATURE----- --------------gzu0resIcHTErGXU9L6jffqY-- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:00:09 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 11:00:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384596.1627467 (Exim 4.92) (envelope-from ) id 1wrvpX-0006V1-U5; Thu, 06 Aug 2026 11:00:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384596.1627467; Thu, 06 Aug 2026 11:00:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvpX-0006Uu-QR; Thu, 06 Aug 2026 11:00:07 +0000 Received: by outflank-mailman (input) for mailman id 1384596; Thu, 06 Aug 2026 11:00:06 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvpW-0006Ou-GT for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 11:00:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrvpV-003tIU-TI for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:00:05 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74692f-2eae-0a2a0a5409dd-0a2a4506aafe-12 for ; Thu, 06 Aug 2026 13:00:05 +0200 Received: from [52.101.193.22] (helo=CH1PR05CU001.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a74692f-195a-0a2a45060019-3465c1164473-4 for ; Thu, 06 Aug 2026 13:00:00 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by BN8PR03MB5009.namprd03.prod.outlook.com (2603:10b6:408:d7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Thu, 6 Aug 2026 10:59:57 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.019; Thu, 6 Aug 2026 10:59:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pm7bPBJMXXONYi0I88alJYlXPKHEETQns2Lq6MM6ufsf5Zujl8aLgqn2olczTwjJx8JmJ9DG2LFzpDuExmSvSad6l5w145/vejTxtUcAoLFs/IUJ1QF+UHMH502w8OTEUIbG7HvmKyt7C+IT/6fC1CuzzHBr9t6wTYo0qwQQvqHbhjSW3biYRZ7iezwRbKqXTlBkvK1s5FiAw1fzbO44/OkNOfgk3dem8iCtkOmiwYDfxzjE5oM9iJUmaAIUTOItV6EMmBLdOeXrBAs3oNXmd6MQJU+SWQzj9udMT3vza3hfQjnn+rwX9//xNzWY8Rie3V6vnO1zegsm/nrA2Y0+1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4+YmngKR9FGyhYhU7floGTmr7QgSYAhmIaPMsg8CLI=; b=A9SZ8niV58ojXzUZEeKcS1Pe+41DqNE206ry1slePt3vLbi8KFlrxIaJew7zv8N5NdfbfQ25XATzpKSMOnqNyYWs+8+zhJk8RcR5GJjBUIBsnX1kqs7acWlpt0fyPbWnsJs2GJ+PlWOMm7t58lzf/ZhJU6Am2OrmAZK2yviJhCEQCVynk60HaiOg8/+ylv4UhDpadEAQNA6cNQogsjEjFXaJ/S1q4EWZjAgaE6Kd8/YMPVPEZppjx2MkJXPLZYmYITMUPQZ7o1KjERBpp8nJ6TU6h33dsg496kqPrvWAB7p6PZI1s8rSMl2ysD+oJTjphvmAfvh+rkeWBhb6dyVpGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4+YmngKR9FGyhYhU7floGTmr7QgSYAhmIaPMsg8CLI=; b=zS7Az9w2rM6lKS/CnPueFkKbl+w+5u/3hJHSDdQNTTa3YBBLdeAZuBCPsiB4TT7C0Dumlv0cDsLOH2okPykWnpyWc1MYxRdp6szaNhSYJUkySztnATeIUdAhxA3b0eilRFazOpTjnhgTCH/MK8I8rJIUSRJoweO1qP7jL9hAoiI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0835710d-f67d-4678-ba39-4597b9c9c7f7@citrix.com> Date: Thu, 6 Aug 2026 11:59:53 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/svm: mandatory update VMCB nextrip for soft interrupts To: Chunjie Zhu , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jason Andryuk , Teddy Astie , Ross Lagerwall References: <20260806031732.10242-1-chunjie.zhu@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260806031732.10242-1-chunjie.zhu@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0022.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::15) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|BN8PR03MB5009:EE_ X-MS-Office365-Filtering-Correlation-Id: ee720e00-172b-483a-e881-08def3a9da3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|18002099003|22082099003|3023799007|56012099006|5023799004|11063799006|10067099003|6133799003; X-Microsoft-Antispam-Message-Info: BX95SAXDWNVICk1QG2ta7bzegnXgdzlBWLxE9qH2++UPqC6GDzxeeoFBiO2iLA+l+T86AMjBsB7Uwy+BCT2bVMzty62XrA17JBBvfN8KaEN+W3PIOCf4MtiNXOYVRO7kGHTenqVPqYW5JMBMmu6Qz8Hx2W8n4a5aNcfbwpE4PW2hJ2xS2oUrburjh8T3gAYAY7NbSqdD/634e0SaMLG1xkvbkeaAccgxLTKp+tJaJWrwiprYbIKVwYNmJg9kz5nIqlvJ7BRcGaJACNdYSqBiXWLxcgdW6orMjnzBuOrt2PfvYxVbQ8QO/b2GkWrqA8F0HZ6GVlG4uj7Mz3JdJJqV35qx7lkUJUONPdaKmIMdEfJcvFPNb6KaYD9+DOsXsgL6WFiQm1nIdRoO1CvRdh2ul/YkYxXHH5pPr0Rvyd+dFxCGf6fp9zD8jEewUTopwfsTcD3ddEevq9d0uBLfSPMk0xpQe/krRDcOm7edkqOFhtaxDYNFn77anDMuaBFE66alXjC5tP66CIbQWFag1uLS4XfFi20mMHtqTD6bF0tcvqcYgBF9uO+mo1QGMAbu45481iZGl/q2NsNSzb2O642QovLj1ibVaR5jIxLeFg7Z962olwP3dchqr/c1UmBD0+ehJ6eIAp95BPn6bebWbqLyEsJ95WEwFwsV8uKgKr+T0WM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(18002099003)(22082099003)(3023799007)(56012099006)(5023799004)(11063799006)(10067099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHR0bzNlQmxwZmcvdFM0OWF5N3dERnNDcVhMVmpVQWQ4M1A4NU5jWjdadjNt?= =?utf-8?B?VUwwdHFuSUYycnViVklzV2ZpVy9yVVE2NzhHdjJSYVNUb0JBTTNnWkxXODFr?= =?utf-8?B?VjJqcXRzWUFIL0hYRmZCUWpPZTBWUHZJTGxoV1JvN3k1bzBlMUhpdmFVRXNi?= =?utf-8?B?N2ZqRDUvcyt3bWh5anZ2VWJNaGdLTkZvSmV5UmFweVZvVmxUcnc1NDhjVVBi?= =?utf-8?B?RVUyWHRYT1VhS2JJZ1I3S1EzbDk0d1RUNitLTFErUDV6TUhJN0JYRzc1OUxH?= =?utf-8?B?bkV0RFVqdW5OSzV5Yyt5MzgxdndxeTIzSFZMMUdPUzlqaUpTdVVHTThXZE1I?= =?utf-8?B?eXRlNGY5V2ppWHJ4MXhZYWZmWklaU0xhUUJFNEhRVnhtVnp6WWlTV2MwWFYx?= =?utf-8?B?dnd0c2NnSWlyTEtNNURObzdsTkVGdWlJSWNCeml1OGlTUkNNdUl3L0hHZXJN?= =?utf-8?B?b3FPSXlNUDRIMHh5N2dlQ2M5WU9YTWRGNW5kbG1kL3BDdVFDajhWN1JBSEYx?= =?utf-8?B?ZzJrNW81c055RmxhVDVjenNNR1hXbW5PYk01SmdCemx4RG1rZnZPc2xEQjhS?= =?utf-8?B?VG9HQnR2MlNXWFVzM1oxeDg5V0crc2tPM25RUEFhTHZXaDBzL1hpMVBLek1n?= =?utf-8?B?c210Ykl4cGRSUm1sNXhyN3FlS0pNaUh3MDhHWmc5ck8vS3Bhd1NwOWRoSXhW?= =?utf-8?B?UEllZW5ZY3hjZWpWQUVPVmlrR2I1aW9PVk45Rk95bTBjRmdXVnlIeW9rS1JP?= =?utf-8?B?Tjl2UGZ5VGFkelNvVlJYbzhLbHh0TlBwbml0RkVzYmx4MndlRHRtQmE5cnV2?= =?utf-8?B?bXBEc2dxTFJtREFEL2VkU3BQeGZ4OGRQaFp0SDdzdVliOTA5ME0xUjlWYlI3?= =?utf-8?B?Tm8xU3NkUUI5empGWVdZbGJwTkxvazc5bDdMQ1VpYzVvMkNMQWRrL2NZOHJZ?= =?utf-8?B?TDIzZEZ0QTNzQ1FHUkorTnd6bEdld21USUJYZVpZclRHZitrYUszak5Id3Np?= =?utf-8?B?cC9SaUh3bGZEWnJ2WTVsY2J5RXVtWVVhRnd0WTgrQUNYRXllM2RBdGFNUVNR?= =?utf-8?B?U0xxOFNuVWlpWVJhVUMwUTc0L3MrZk80clBRYTl4SkhhWWhpdXh0cy9FYS8w?= =?utf-8?B?SXNUTzBocTFLQjY2SDM0dk1paTQyVG9DRkRlR0VxSmYxZ1F3eVpVSVRRcU41?= =?utf-8?B?UzExWFZna3ZqdEVsQklBV20zZnRvTTNxdzdwSTlabkg2dnA2Y29yemdDUFo3?= =?utf-8?B?d0Y5ZUZjUmt4SGdtMysybGdEWUZmMHRyc1lIa2s3TWp6MFd1Ry82WmE1VmVP?= =?utf-8?B?US9tV25Dd3U1STZpUlZGSkYvY1Qxc2ZGRWJuTCtpREkxaEM3VHJhemcxTVdk?= =?utf-8?B?blNlZXFrZTViK0VFZW9mV2lJUFpQUXRoSXNwb3dqQ1Ezd2kwRGJWc0hHb2xa?= =?utf-8?B?djdEK25pZUlRUHA4OFNlZWNva1FUOEFrUWZXN3NvWm9Wam5qVzh5M2Y3emJn?= =?utf-8?B?L09QT3dGSkpxV2tmTmNCQ2ZBajRCTUwvQjEvbXhsU1V3dzJuV3ArcEZOcUlO?= =?utf-8?B?WTQ4d0RvWUJhNFE2Tjg4dzBySmU1dGprMlAyTm5Wb08yRGhIdnZWVi9GVGR6?= =?utf-8?B?cEFMWCtjTlh1bVk2SzUwRDFUZllTajhnTVhDeEFKWUtveVptdTFaVHErSnpM?= =?utf-8?B?eFJhMkhLWjR0MGc0WHNOTGNLR0FFcDZ3ZXQxNllnMERPbS9jd2FxS2gyS1k5?= =?utf-8?B?cVVyZCticWs0Y0NlWmhxYlJNdFNMZUtkV1VtV2dKdStOeE8xYWhWRk5OcVVu?= =?utf-8?B?WVZrRlFrbURveFR4NFpaSmRtcGJmQTR2QXlHU2xUK2h0UFpmZEFPYlpwU3VC?= =?utf-8?B?aUQvM2lOZkRWOTdTWGxPSko1SldiVDFCblVmb01TMFpuZEN4QzZaSXZDNVkv?= =?utf-8?B?cTlsVkNUZ1JZM3VlRExKZkp2OURMZWIwOGtJb3RJR2c4S3JqVWkyTFdyblh2?= =?utf-8?B?eHg1NlFVNWluNDkzOW04aVpER3Fmb29rR2ZiUDFkZDhON08vakJSS05jUFV4?= =?utf-8?B?TDVKL2JIeTlUY1hDZnVFSjZRdDZvOXF3NzhlK3poRGJXdHRjcEZXamRvOWVH?= =?utf-8?B?SmZtbm82VllrMGJnSVNFMFEwL0tkUm1mTDN5OWJpaWFRc3F5Zmpkbnp3NGtv?= =?utf-8?B?TUs3UitvWVVxVmVRK1d2Y0VQa0JaTG0rS1EycWg1Rk9NTmgxMDJ0bWZxTjNa?= =?utf-8?B?ZGl6N05EbHhYZFIyUUxHeVE3YXo4NWJhUUsvWXNrdTgzVitqR1g4SmlVcXBF?= =?utf-8?B?TXBaVnJxWFhua3cyTExUbmtzU1phbXhBNTFld3N0OE5oeFl1VThMUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee720e00-172b-483a-e881-08def3a9da3f X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 10:59:57.0560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T60YekYCeS5qEIpYwVwc5V5fumLbO9EI2tMvM9GH1P5qS34enDdRpROebXhU4cLA3CeMeNkMzu8WywBZ61dnTiJ7mY5SiKvH8WZ6HR0T2zQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5009 X-purgate-ID: tlsNG-16d1c6/1786014000-F72C677B-10A13D00/0/0 X-purgate-type: clean X-purgate-size: 3058 On 06/08/2026 4:17 am, Chunjie Zhu wrote: > Signed-off-by: Chunjie Zhu > --- > xen/arch/x86/hvm/svm/nestedsvm.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c > index b06124c2c9ed..815713b8b506 100644 > --- a/xen/arch/x86/hvm/svm/nestedsvm.c > +++ b/xen/arch/x86/hvm/svm/nestedsvm.c > @@ -449,7 +449,14 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) > n2vmcb->virt_ext.bytes = > n1vmcb->virt_ext.bytes | ns_vmcb->virt_ext.bytes; > > - /* NextRIP - only evaluated on #VMEXIT. */ > + /* next_rip is consumed on VMRUN as the return address pushed on the > + * stack·for·injected·soft·exceptions/interrupts. This assignment > + * statement must be enforced, otherwise, it might cause vcpu wedge. > + * > + * APM Vol.2 Event Injection does not specifies what happens if NEXTRIP > + * holds an invalid/garbage value. > + */ > + n2vmcb->nextrip = ns_vmcb->nextrip; The old comment is indeed wrong.  However, this comment is distinctly out-of-character for the function too. As for the text, your subject probably wants to be "x86/svm: Sync nextrip during virtual VMRUN". The commit message needs to say that the NextRIP field is consumed during event injection, with the L1 hypervisor being required to configure it appropriately.  For a garbage value, the APM does say; it states that nextrip is always what's used for traps.  Nothing checks that ->rip and ->nextrip are within 15 bytes, and you can it to arbitrary values and hardware will put the value on the stack. Finally, there is a fun problem when running an L1 hypervisor which can't see NRIPS on hardware which does have NRIPS.  In that case, the correct sync is actually:     n2vmcb->nextrip = cp->extd.nrips ? ns_vmcb->nextrip : ns_vmcb->rip; because for event injection the L1 hypervisor will have had to move ->rip forwards for anything with trap semantics, but the real VMRUN will still read ->nextrip even if the L1 hypervisor didn't know about it. Note, we don't actually have the cp->extd.nrips field yet.  I need to dust off another series to get that fixed. NRIPs has been around almost forever in SVM terms.  It was also a breaking change when AMD added it to hardware; while you can ignore the field for the purposes of instruction length calculations, event injection still requires it to be set correctly. We only offer nested virt on NRIPS-capable hardware, but we don't have any interlock concerning the guest visibility of NRIPS.  Given it's age, I suggest we don't try and care about guests which can't see NRIPS, so our safety reasoning becomes: * Nested Virt is only available on hardware with NRIPS * NRIPS is required to be advertised [*] * Therefore the L1 hypervisor is required to set ->nrips correctly * Therefore we can just do a simple sync with no conditionals ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:05:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 11:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384608.1627475 (Exim 4.92) (envelope-from ) id 1wrvuc-0007Dv-IC; Thu, 06 Aug 2026 11:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384608.1627475; Thu, 06 Aug 2026 11:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvuc-0007Do-FB; Thu, 06 Aug 2026 11:05:22 +0000 Received: by outflank-mailman (input) for mailman id 1384608; Thu, 06 Aug 2026 11:05:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrvub-0007Di-AD for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 11:05:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wrvua-007xdk-2a; Thu, 06 Aug 2026 11:05:20 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wrvua-006MK2-0Z; Thu, 06 Aug 2026 11:05:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=QlpYR75WSAkB6qNHLmK4Eu1sVy+Cr3Q5Xsy/wys7VpI=; b=OCtwmyFrgRPtR/T/HCZqPBnM2S wYU91bwXJQ0GXSE8J2OgKx5+CvbP6QfjzMuL3tBQtcBGxi1j1QwZk+raB15HZ4uLyWLwJSuvzWGZH wD9KSdxjAFL0hx483+GBX77eWMN5ZmBPeF07V8uKbtQn14tT59WaSL0jc0Zxe6i0ArbE=; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Anthony PERARD , Jan Beulich , Andrew Cooper , Teddy Astie , Stewart Hildebrand , Jason Andryuk Subject: [PATCH] xen/vpci: allow unaligned accesses by the hardware domain Date: Thu, 6 Aug 2026 13:04:01 +0200 Message-ID: <20260806110401.19615-1-roger@xenproject.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's possible for domains to generate unaligned PCI config space accesses when using ECAM, and hence vPCI should support those at least for the hardware domain. Such unaligned accesses to the PCI config space have been reported to come from ACPI logic. Relax the checking in vpci_access_allowed() to allow such accesses for the hardware domain, and fix the handling in pci_conf_{read,write}{16,32}() to fulfill them using MMCFG. MMCFG regions are identity exposed to the hardware domain, and hence such unaligned accesses can only come as a result of the host having MMCFG in the first place, as otherwise MMCFG won't be exposed to the hardware domain either. Reported-by: Jason Andryuk Signed-off-by: Roger Pau Monné --- tools/include/xen-tools/common-macros.h | 2 ++ xen/arch/x86/x86_64/pci.c | 8 ++++---- xen/drivers/vpci/vpci.c | 4 +++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/include/xen-tools/common-macros.h b/tools/include/xen-tools/common-macros.h index 88b4a0e5a693..1f9146b23b0e 100644 --- a/tools/include/xen-tools/common-macros.h +++ b/tools/include/xen-tools/common-macros.h @@ -68,6 +68,8 @@ }) #endif +#define IS_ALIGNED(val, align) (!((val) & ((align) - 1))) + #define ROUNDUP(x, a) (((x) + (a) - 1) & ~((a) - 1)) #define ROUNDDOWN(x, a) ((x) & ~((a) - 1)) diff --git a/xen/arch/x86/x86_64/pci.c b/xen/arch/x86/x86_64/pci.c index 8d33429103b9..6298141c3ca7 100644 --- a/xen/arch/x86/x86_64/pci.c +++ b/xen/arch/x86/x86_64/pci.c @@ -26,7 +26,7 @@ uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg) uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) { uint32_t value; @@ -39,7 +39,7 @@ uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) uint32_t pci_conf_read32(pci_sbdf_t sbdf, unsigned int reg) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 4) ) { uint32_t value; @@ -60,7 +60,7 @@ void pci_conf_write8(pci_sbdf_t sbdf, unsigned int reg, uint8_t data) void pci_conf_write16(pci_sbdf_t sbdf, unsigned int reg, uint16_t data) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) pci_mmcfg_write(sbdf.seg, sbdf.bus, sbdf.devfn, reg, 2, data); else pci_conf_write(PCI_CONF_ADDRESS(sbdf, reg), reg & 2, 2, data); @@ -68,7 +68,7 @@ void pci_conf_write16(pci_sbdf_t sbdf, unsigned int reg, uint16_t data) void pci_conf_write32(pci_sbdf_t sbdf, unsigned int reg, uint32_t data) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 4) ) pci_mmcfg_write(sbdf.seg, sbdf.bus, sbdf.devfn, reg, 4, data); else pci_conf_write(PCI_CONF_ADDRESS(sbdf, reg), 0, 4, data); diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 0ac9ec8b0475..b4e053bb4946 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -685,6 +685,8 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size, /* Helper function to check an access size and alignment on vpci space. */ bool vpci_access_allowed(unsigned int reg, unsigned int len) { + const struct domain *currd = current->domain; + /* Check access size. */ if ( len != 1 && len != 2 && len != 4 && len != 8 ) return false; @@ -696,7 +698,7 @@ bool vpci_access_allowed(unsigned int reg, unsigned int len) #endif /* Check that access is size aligned. */ - if ( (reg & (len - 1)) ) + if ( !is_hardware_domain(currd) && !IS_ALIGNED(reg, len) ) return false; return true; -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:32:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 11:32:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384624.1627485 (Exim 4.92) (envelope-from ) id 1wrwKK-0005XV-Fh; Thu, 06 Aug 2026 11:31:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384624.1627485; Thu, 06 Aug 2026 11:31:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrwKK-0005XO-Cj; Thu, 06 Aug 2026 11:31:56 +0000 Received: by outflank-mailman (input) for mailman id 1384624; Thu, 06 Aug 2026 11:31:55 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrwKJ-0005XI-2U for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 11:31:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrwKI-00AD88-FF for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:31:54 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7470a1-2eae-0a2a0a5409dd-0a2a4502c222-34 for ; Thu, 06 Aug 2026 13:31:54 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7470aa-6ca4-0a2a45020019-d1558029c164-3 for ; Thu, 06 Aug 2026 13:31:54 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4954aff6088so21092675e9.3 for ; Thu, 06 Aug 2026 04:31:54 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49954246f9dsm65439275e9.15.2026.08.06.04.31.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 04:31:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786015914; x=1786620714; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Imj1BdRczFgTNSp3crVFriTNBqw2cpBDb5vyHLuAegU=; b=WASbFKQoK8i4+xbQZ1M/3yLVdyRbeL09ZHCObsPKkGdHf6v+1gtw2i7GTjEO7Tw/vN 7zOxLhWrYsaCBc1CtpjvlWAVIV8LadAOGFprKcelhCTjDO6yM6vXi6q3guIAseo2grpt XbAjhSODbszSrq3T41oOAVl9XZLHVeG5v/Ft7IXTcxV0r100yxbIIj0wso6isS4Sumua vtmOfgew5UkYInlP4tTsm3Cb4lAiL25pXU0zjJbMCyvnfxmieSXGF/FqjUdeoh1EK525 HMNv6zclns6ASr4TqF6Jmkcnxr8evi1VdwtRZKo2Zudcfjf3b/dMSrGxs3kUKCWa63cW BuSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786015914; x=1786620714; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Imj1BdRczFgTNSp3crVFriTNBqw2cpBDb5vyHLuAegU=; b=RRTxdSn/tn7D17d02bJjUhvuYqD4dSsMy+Bgz1PSQMK/jCY2ZbTbE7+nAIEYWD6oSs XmXjWhMzg70FTQsgdhvaEekUaroJCMC0C+tBh4SsadyetyNGVmdf0OLMyElf0fHTqZgy RzHQl0yfsVcfYhlikb0WoGSIvbgtKEObzuz8nw7foDPTMYFZAj2aPyg9wmf4LXZ8Vn5C LKRIyR2hByL8xin1yQ1nZKPmvdLPBEOmfGjWurelNJPHEWgxKyhm1UanHC9/q0je38XK AThiUBl6ad8qAajFqAIciUwcF6w3zSvnm7ox/pq1wts73BFiD9xvpnKLvs/d35VkhC5B WyXQ== X-Forwarded-Encrypted: i=1; AHgh+RrcMohXZS+kDQ9RflgEZCPwSQAz8UmP1KoYCvyjBz8zi/bkmzNfr0ZUV+Irp6ynZjxHFedmriIGNkU=@lists.xenproject.org X-Gm-Message-State: AOJu0YwYtVsOQgc7hsNje/zh2ITJ+oLdcnXAOxMJ8MF2sNJ39aJxEi9P pdI6gpInhqSlAuaFcqEIXjH54Ud2fDWRWtc6tBvFn61bxqIyFyW3M6P9P8FeEa2FCA== X-Gm-Gg: AR+sD13rJvGM5ii2Rv9OmFEeJa2rmFPvw85+zFFyBbKvnRi1kVoiM44Nem4OrOYZ28v tbDWx+5RtTw7LSl2qOJanfNCwep8/MC2DUm6szWAgX2u1lxheK79O0MBrx6ZYPXN8fF8QBymdPl aBYmBOZsVEQrzLQcI6pQt6AE9xxXrYKGRCvIUhMmgXo/cUUttc4X+/tWKoGrkNiEszaWzwHfZRQ d26UHHVPzcg97WC4MZjYwwVs5tryA9SDD0tkv4f/UynotXrICb2HRP9mWZjuR6o1VtWD0HEvVn3 FBDausMCCS3CC17RHVFbSIaIZHD2DtXeKSKZFPrbp+vXHtYT4dxjOdp/sYYzMmhmz/ZCZexfAj8 sIG76zQDhby0cQpk/vmwo0Rfe9jzVuA5cunnSx4HekuQAeUQa+hbbj6ov0LAiGGnBaosZQCqawo vDIhqOUv8qeFY4LhT76JYn0PkBg8nT6IOytGvN/gRopObtcQvCsH2ZSTxlUN5wuPnyMu53sSC7N d9OWrmr0OveC98Pd4EbTmzCnpKtWvjHY8cKlV55NDUdmRkpDED5 X-Received: by 2002:a05:600c:630c:b0:499:4d4a:4990 with SMTP id 5b1f17b1804b1-4994e74566bmr147562345e9.3.1786015913665; Thu, 06 Aug 2026 04:31:53 -0700 (PDT) Message-ID: <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> Date: Thu, 6 Aug 2026 13:31:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] xen: Fix PV-only build To: Juergen Gross Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jason Andryuk , Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" References: <20260806015233.202486-1-jason.andryuk@amd.com> <083db883-558a-4000-b404-bf170c8309ee@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <083db883-558a-4000-b404-bf170c8309ee@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1786015914-F18AC2AC-E996FB79/0/0 X-purgate-type: clean X-purgate-size: 1083 On 06.08.2026 12:55, Juergen Gross wrote: > On 06.08.26 03:52, Jason Andryuk wrote: >> Allow disabling XEN_PVHVM for a PV-only. A stub in the event channel >> code needs to be fixed first. >> >> Jason Andryuk (2): >> xen/events: Fix xen_set_upcall_vector stub >> xen/Kconfig: select XEN_PVHVM >> >> arch/x86/xen/Kconfig | 8 +++++--- >> drivers/xen/events/events_base.c | 2 +- >> 2 files changed, 6 insertions(+), 4 deletions(-) >> > > I did a comparison of a kernel built with your patches disabling XEN_PVHVM > and my patches with XEN_PVHVM_GUEST disabled. > > The kernel built with my patches is 6 bytes smaller than the one with your > patches. Isn't this a sign of something else needing tweaking, somewhere? > So I don't see any reason to take your patches, which conflict with mine, > especially as my patches have a negative diffstat on source level, too. Hmm, Jason's patches look to move things into a more adequate direction, though. In which case I think a negative diffstat becomes an irrelevant argument? Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 11:48:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 11:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384648.1627493 (Exim 4.92) (envelope-from ) id 1wrwaD-0000ZP-N0; Thu, 06 Aug 2026 11:48:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384648.1627493; Thu, 06 Aug 2026 11:48:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrwaD-0000ZI-K4; Thu, 06 Aug 2026 11:48:21 +0000 Received: by outflank-mailman (input) for mailman id 1384648; Thu, 06 Aug 2026 11:48:20 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrwaC-0000Wk-4G for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 11:48:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrwaB-00F8Za-H7 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:48:19 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74747f-5cb7-0a2a0a5109dd-0a2a4503b636-22 for ; Thu, 06 Aug 2026 13:48:19 +0200 Received: from [52.101.85.32] (helo=BYAPR05CU005.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a747481-fae8-0a2a45030019-346555209f12-3 for ; Thu, 06 Aug 2026 13:48:19 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by SA1PR03MB787740.namprd03.prod.outlook.com (2603:10b6:806:51c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Thu, 6 Aug 2026 11:48:15 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.019; Thu, 6 Aug 2026 11:48:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lgbZqSciwmw9km0Qt+B6NDfLVd6aZdTKWwFbDkpFyRnZWoqpb+fHU4JKlewRnMj/pimoi6Oi0xazZyuDqQpJth6sqsI0r0q9tvoi+v9eczouLLPX0aNt/VIjv4lcIu2y1jTdDYkKhwv7nndRx8gQ246UwcKsFaBsW08rDvWTzhoFYQiuuleGHXheOo+9CHjSzlReDyQYAv8lI2drtYs3EtW2pWzneihwGy3MJPx+26RpEl4Fs/hTZIPv8VEor9sYV35yG7d11y9M6+6Zv8cIeOzV0lRFmDunJqrAFR3SMfK3Z83Udw8/cvgzmbD/rudMLoT8OVIbLne8RIcmTzYgRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LJHuwZp7A9ScOnrOoEHuY8gDSLlZRB842wSSW8st0xM=; b=PWp8jLelefc3sVUBuaW/wVkfkwiuDtrR2gEqh0WpJ9utr9FjQ8+8bFK+KOubMbKoiENaSlsuS9tXRF1ubCxKjTBbV8b3wg4hocFwjZFbKyAsYvvStKMRVN7q6gQetMNvUUS9JYdPQJoNuSpUwe3bM4K5bxOBsyM/AYjK4C7rAYXKDdkBLWVkyXwJK9Rat10OwWHYpGx4HB/YI2gSRBDOdMaBlJkOqI4qaJOuh43Zhdc3bTYjzWBqd1IZ9VHz7MWqjdbI7KrS51lRms3d1DWiQhTbHAS2Do/4CJoTQ9TxRTiofw4HaCZ5NsOaKPteAKOYkk0lzktEtSFX40CYg7vV+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJHuwZp7A9ScOnrOoEHuY8gDSLlZRB842wSSW8st0xM=; b=GhBOSebTaZyHoyJ6msnqSO4XU+KC+RfWFtPh0dmMfji0Pz2ItEnyuBo8XmrUvCw0/r3pw10gaEnMhRpAJLiHo8ojacYeiyPXmfvNQ5hh4hNhFqp1CROOApoIuREi5Vt70IFLDMJ2Le7ysssLAqH56IGp3s87PEGvTpTsZngnzlc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 6 Aug 2026 12:48:12 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Anthony PERARD , Jan Beulich , Teddy Astie , Stewart Hildebrand , Jason Andryuk Subject: Re: [PATCH] xen/vpci: allow unaligned accesses by the hardware domain To: Roger Pau Monne , xen-devel@lists.xenproject.org References: <20260806110401.19615-1-roger@xenproject.org> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260806110401.19615-1-roger@xenproject.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0492.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::17) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|SA1PR03MB787740:EE_ X-MS-Office365-Filtering-Correlation-Id: cb437712-bc1f-4dae-0aca-08def3b099ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|366016|1800799024|6133799003|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: KnHUCbxltax4cC4T5QGZJkHVekeLRxupPAWrSNxVoICfzqx4HLQ2Mo/Kxtv+xzjF/vLP3meRvHEiUMk8qjBhB9IFjLjTR9oxiWvcFty6uE8R8fI5nRnib4TL4GkwfJAoVKV8V5AJc7tl5K01kD1dK+S1D3NGPWL99JmaGKtAhgXIjhJZcs3e2tZ0NIJPIgMDrjWwS/I8bqt3rby98fhA00qDZxBqx5uWtRmfcFJ3rwDL4f+sBnFLILLFvSzZDAC09UnK9oEV6HOX+I26MTsm7PYveTDe3Gc9t0PJkSKCeMsASI1/oZBMaZ5+9vXQr67q7JAks33cGaPoNg3J6sl410bXh2r551tDHfBUn2b2Kf4xY5byGOeEZsuUkTti1oT2ks/2EKJxN56G0Yq3UbKFDVWCpA8pN8KwxMBxsWNqWp9JBAjGc0FZRZGJK7s6Orjcyhmks0RTpLA+oEj0AlyIbwKHRua5Y61p1LxzUipXPAQ0kx/dxuCcrgajFdXNuSHfTeUQMd1/2gcORRfL4ErL1yCATXjujs73f0/LtQRv/jdt6HDwREvuh++0+o6QhdOKa9Dyv/ZTbH0eq6oIGsz+uCbHXJS/NqZFZGdAEVh1t19+ATB4yoZd3JtPtk7TRtZLOaDWRKHcaCcRNT1QTncawHzQKi6eRmMYf3Z/geH3pv8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(6133799003)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTBZaWJ6akVyMk9QaHkrc2cvTFQycUFVSjN5ZHgyU2g1aXZhVEFDaGFpYmhK?= =?utf-8?B?ZURDTjNMTzc0NW9PN3BIbk9YRCtEWi9IUmNZWlVCcWpXWUtRQnRsMm5IVHJ3?= =?utf-8?B?ZVBTUFlIRkE2U2FrMEhnOVFOUmZIYUxoK1dGb2R6K0pZTU5mWGcwa0dLNzJm?= =?utf-8?B?dk8rSy9YeXNta1psWk5qb0ZlSFNCRklYSnc1SlBlTGJTMFhIYzBSb2I0ODB1?= =?utf-8?B?bFI4d2hqcXFhV1dpQ3hVdCtJZjNod05Xdm9zRktpRkllajdOTXE5QktpbnZX?= =?utf-8?B?eld5UGlwL3E0bjhleWZFczlYSkhhNmdJeWY3U2hib1p0UEJTaHFEeHUxV1BZ?= =?utf-8?B?Ym9LWUIxVUg2MStiOUpZQTNzTFIrdEJUU294U2owK1ZrWE1iWmt0L0xFN2Rm?= =?utf-8?B?a0FFTC96NFdaRm81ZDdNdEwyT2xPK1NnL1NXUWJqaXJld093WGZDTFZES2xH?= =?utf-8?B?NUt3NjVyMVNucGtKSGNtbFQxSEE5dkNJbzVUaDQrMUxyaHVDTjV3U0lKN3RG?= =?utf-8?B?dFBVbWFyMmhLVEtqUnFkRnkvRWZjdkRBOVZ0TjVwTUdBNWpmckhaaEtsMGRn?= =?utf-8?B?bEdnTFdyODlEV1pmWHFXaXpoMFVndzFYUWt6V3ZIWEt0VmJ1YzlhR0xLWkxp?= =?utf-8?B?L0pYWTNxSHQxTDhyV1M2c2dlMjZLN3ZBZWxiL1JQSTNnSDlIYVVvOTkxKzlt?= =?utf-8?B?ODN6dHM2VHM0V242Sm9xYmMxSzJYQ3hkQUZacDU3ZG8vZ1RiTE5JL05ucjBu?= =?utf-8?B?MHBwdlFQcjBPbjdrN0FWMlFEYzdaNmNmZ0VzRXRqUHBUQzc0OWllTnVtVm9h?= =?utf-8?B?Vm5NUGxESkU2Q0YwcEs0cTZZQisveDJnSXZoMC9JQmxPUnFqcldROGE0OTZG?= =?utf-8?B?bWZCaGRGbUszRFhQdWROcEJ5cnRENTlVaEhIeEcrUWI3YXFUSWhxMllHZ2cy?= =?utf-8?B?WHN3bkVhK0VPcHJpdVZFellxdkpZaGx0MDZkYmhjc2hld2JXQjRMdURLNitm?= =?utf-8?B?VnJIM3k2NHZuQWhpU1h4YnhzYnZROTN4ZWVuSU80STVET05sOXVrMHN5eUdR?= =?utf-8?B?cWg1RGlGNVBYOURVekZmbUFZL3NVRFBWY0dTRDFiemQ4WXpGVHdnVGVVU29C?= =?utf-8?B?YW5OeDVMbnA5MitiT3c3ek9UUDg1ZW92NksvQm10bWs1ZnlsQWlQaHB1RjVC?= =?utf-8?B?cWE1UUdHc0RwcTRqb2VjaWdhR3FrT2VLT3VWR3FHcFZJaDBQQnRtTkhtbVRt?= =?utf-8?B?cnIrR2pKRXF4eWI2WWdLajFid3luL0l2VXp5d3pEMlNNeVlOaEdWTVFMMFdt?= =?utf-8?B?T0NvZStHcGkyOENxWlIzN3piZVdVTDZoWFN2cGQ5WnpnZzhxSkhlZWxaeElF?= =?utf-8?B?ZEJLUHVjVzZDRUlDN0Z5YlMvUkRNNGY3Y3JnSnJMaHQvVWhsUDhTTTd6Uzdi?= =?utf-8?B?bFY0THFsMkZOdjdzaG8rWUx0L0Z1UzZGVVVoeW8yMzZjTVQ3MDk1dFAwSk9Q?= =?utf-8?B?T3pLREEwYUgxcDZGN1ZISWZRa1lpYkxsU1NLc2tSeXBDV2NIK2pxcnJZTkpx?= =?utf-8?B?R2RDT1NCaGhoVzNTVFhvM1hrUmlPTXFBSzN1Vk5VL2JmbkhzMUJFcTJuRk5F?= =?utf-8?B?RjZiUlpCVkVIdmhBQWJtYmM2NlRRQUQ1OFFXT3AwOS8yRnB6ODVaYjFYZ2U1?= =?utf-8?B?c3Mxc1Fub2NsLzYxVnBZcUxRUzRpWWpicUYwVnFaY3RpU2EvdmMwSGthYXZZ?= =?utf-8?B?SjluOS8wWUF0cTRDT2l5Y0NnV1Ixb0loWkVucHV6ckxyV1dTd3cySFZJUHNa?= =?utf-8?B?WTNtbkFCT0NDMXJXY2FwZkU2ZWRZaEFxc0lYcWdrWU5SVTJLay9ITWxROGJO?= =?utf-8?B?Wk5WWW5raE5NYWJxczYvQmZ1VGJsNWppN1JGYkhnSW1vTWRISi81M2JBejYz?= =?utf-8?B?UkRvUWJVSmpuTEtjanoyOEI5VTYwSHc1K29Ja1RGVWt3bVhyRDRyWEl4ZjdU?= =?utf-8?B?clVITXVGaFh5UXNLQzJrNW1wTTBhRlE2ZTVSRlhWaWIxcERFdnZML3luNGVL?= =?utf-8?B?L0hzZmdOS3FzWEl3bVFvQ0dWMTRrUGlycmI1WCtHU3FsdGJ1OFNQYTBjNUh1?= =?utf-8?B?d0YvZUhaTlhYM0JoN0xFaitMR3dzTDAxdG9PMjhFcTlvaWlqNmdUd3Q3akdu?= =?utf-8?B?YkEzTEQ1VTM2YUpiZE9JaGlIUTA0L0JnVVg0SmdEaHFMZVF6eVQ2L3hJWkxW?= =?utf-8?B?TmM3S1J0Tjd5emxpRFBtcU5XYVpNMVZua1JTTjVZR0pZS2JYdVFreW5oNHk3?= =?utf-8?B?VU1kTk11QlV4dlpudHI3RUJLOVBIblkwcTVDeFdSZ2I2b1FHQSsxQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb437712-bc1f-4dae-0aca-08def3b099ba X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 11:48:15.2924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O2IPFVcHoZWWeThh/Lgr9TA3BrPy2/TrWu5zomY+Q9RCTzh1TkEqE+8+Xjur2AOpkiaKcoLf3g4e8sqzgpeFW/KBEny7Ql69Zl5vHRdYwfU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB787740 X-purgate-ID: tlsNG-33051d/1786016899-6F8C54E9-DF4E9F66/0/0 X-purgate-type: clean X-purgate-size: 3001 On 06/08/2026 12:04 pm, Roger Pau Monne wrote: > It's possible for domains to generate unaligned PCI config space accesses > when using ECAM, and hence vPCI should support those at least for the > hardware domain. Such unaligned accesses to the PCI config space have been > reported to come from ACPI logic. By this, I presume you mean AML from the DSDT/SSDT ? Misaligned ECAM accesses have undefined behaviour.  On a particular platform this probably means implementation defined, and for an access wholly within a single devices CFG window it might even work.  But, misaligning allows you to have one access hitting two devices, and this really can't be a good thing. I presume "fix your BIOS" isn't on the cards, even if it would be for the greater good? > > Relax the checking in vpci_access_allowed() to allow such accesses for the > hardware domain, and fix the handling in pci_conf_{read,write}{16,32}() to > fulfill them using MMCFG. > > MMCFG regions are identity exposed to the hardware domain, and hence such > unaligned accesses can only come as a result of the host having MMCFG in the > first place, as otherwise MMCFG won't be exposed to the hardware domain > either. > > Reported-by: Jason Andryuk > Signed-off-by: Roger Pau Monné > --- > tools/include/xen-tools/common-macros.h | 2 ++ > xen/arch/x86/x86_64/pci.c | 8 ++++---- > xen/drivers/vpci/vpci.c | 4 +++- > 3 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/xen/arch/x86/x86_64/pci.c b/xen/arch/x86/x86_64/pci.c > index 8d33429103b9..6298141c3ca7 100644 > --- a/xen/arch/x86/x86_64/pci.c > +++ b/xen/arch/x86/x86_64/pci.c > @@ -26,7 +26,7 @@ uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg) > > uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) > { > - if ( sbdf.seg || reg > 255 ) > + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) > { > uint32_t value; > Personally, I think this is making a bad situation worse. Baring quirks (i.e. K10 era), there is never a case where we want to use the IO Ports when we've got ECAM.  Furthermore, on AMD systems when we're lacking ECAM we can still access Extended Config Space; something which Xen currently gets wrong in several ways. The IO ports require a global spinlock in Xen, and then a global resource in hardware just to be able to translate the IO access back into the ECAM access we passed on originally.  i.e. from a safety non-interference point of view, you want to veto any use of the IO ports by Xen. Xen needs to use ECAM, and only fall back to IO Ports if we think there isn't ECAM covering the target sbdf.  This will cause (mis)alignment to get fixed automatically.  It will also be a substantial perf boost in the general case; all the MSI/MSI-X editing we do (far too frequently) is in Legacy Config Space just uses IO Ports. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:00:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 12:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384673.1627504 (Exim 4.92) (envelope-from ) id 1wrwlt-0005Aq-To; Thu, 06 Aug 2026 12:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384673.1627504; Thu, 06 Aug 2026 12:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrwlt-0005Aj-QG; Thu, 06 Aug 2026 12:00:25 +0000 Received: by outflank-mailman (input) for mailman id 1384673; Thu, 06 Aug 2026 12:00:24 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrwls-0005Ad-PD for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 12:00:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrwls-003fam-5W for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 14:00:24 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a747752-bab6-0a2a0a5309dd-0a2a45058f22-46 for ; Thu, 06 Aug 2026 14:00:24 +0200 Received: from [209.85.218.43] (helo=mail-ej1-f43.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a747757-4cb1-0a2a45050019-d155da2bcdd3-3 for ; Thu, 06 Aug 2026 14:00:24 +0200 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c1677c91969so245824166b.1 for ; Thu, 06 Aug 2026 05:00:24 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2036428e13sm239555266b.45.2026.08.06.05.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 05:00:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786017623; x=1786622423; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0Ybdpf8/wjx+iaseSxODwkj4wcj0Z9/yn9laCTF9dtE=; b=cj5KX/oBukMy+reKPdK2YcOGux12slEYV06ZLr5gXcd4qWEbH5XHSOJ+RHaraUZ6xa qLDvTnk/NxX3uI0BdfKg4zmIYvBBwOY5gsuAzwh2llAucrjepgS88SadimH5j+pGxJ/h aqwdKZp6ncQOYPiQiwxVWBRiwsMd40Xlw19WId+MQ/H6bWJ2z8GTIuE7So7p1Adb0qaU qWOZjg0t0W+zCh3Sz14aEk/pF/zlYMXcAmgHr3Nx+H1dzWgpsAbuvwrX/bW/xDrXxH+O 96w1y2wsFyq6EF8w/qdBIu294QW2sIAVYelajTi+Y1A4i0AP5SaudzuUh3Ff9WxwwSzv 1fcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786017623; x=1786622423; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0Ybdpf8/wjx+iaseSxODwkj4wcj0Z9/yn9laCTF9dtE=; b=qQ0xDOMZ1Wj8mgkPjeg9wHhgxe52ETbb20hMMLlWJVBTeJ7ohjTXtL6yfdqwgShOsd 6siXbus+DfZSWMFJsmpTQoIK7oVitK1y1hZwATnN6LzXYdRfg6/ejd/h8dzM3JcWa1z9 wKyURb6O8BTMSQ0VJNFL23I5zjeWWKVCBDswx0xVb6ONa1bbZ35sVOnAip7Kyfbzz9is kxSXSosQsMI/Rr5fbPnaOTXN8LwAFIlwn+rg/oZbs5yBYQA7fy15f9JyCD/dMZSqYqQr ITsrgwk+9f+yChtRQAmqpS2r6YvBybNV+TzA2f3O1foXjdfKPrj8d4l6+7Civo9Fj2VM YzCw== X-Forwarded-Encrypted: i=1; AHgh+Ro7IAZ3WA3wTD8J6UUN8anNDhBXAM/vcR84mmyzadhiEqcABzenD7X6+9R784zE19VfuBtUKOq0aBE=@lists.xenproject.org X-Gm-Message-State: AOJu0YwGzP4G5vbcq6zt2Yr9eWiw+tb2C8ebK+v/6pY1VPA5Ohq8S+aa MDSCLXsejJBEBcNkENat7uo2WetioYjWx/UzD5prPX4bsSmtetr/9hkJ3F06wGeFVOE= X-Gm-Gg: AR+sD13fsOFDJvvpelzTbp8pKhyY7vvkyTYwLwEjTh89P3ItB6OuHSx3dRNztaJ4qYH luUxa6O6Bu7T2/z6m1iSwjItU74J8PMTuAiGlZ3puKIuAUmRGhavxfNyIokzAJLU/nlQSY+Tc5l 6a6SLs3XjIuLbk0znvPeJPho0WeUu0fBFApV/ZsLAG5Nx4hW5jcpkmtfXI1BzoIXkSOpmbyAivr uY0DCnjsgwULwPiqTw/k/LkGoqqh1gX7mU1fwrmoT9CzlZtY/dY35DklzgBszgTkWB2a+WcWTkl 535bS8UwUJLVF8jJ0SEtt7uYs9nwXJlqq9xfxZwpl3CXvoLMN9D2jz0ocf7E/R68LYRWMjWcL5P IsT03XEQCUlJpFgyT9AoAOPry/MCWCNUfHQo8ph55kvACwJfYSFFrJcdFSEJnTWkqYvAP/0TkPn vYQoaBZicv966llHa6WIYHyk8hSGuPOg7dditVbnND7zFK8vTB/bpZS42KPmkrbP36Cs38ZzyUD bn9Z2Kgoh7NyeKMZY+HqBKepISPcwrfNJ5BfMhP+ewaDFQYJRfUstUhDrhy8GNumwEt4zxavdX9 wmu4yKgRBTHLeWDq7ie+CaaxKgY= X-Received: by 2002:a17:906:9fc5:b0:c12:12b7:84de with SMTP id a640c23a62f3a-c2039c4a959mr598128466b.17.1786017623286; Thu, 06 Aug 2026 05:00:23 -0700 (PDT) Message-ID: <967208c9-8d51-4380-8cb4-298f5c313d35@suse.com> Date: Thu, 6 Aug 2026 14:00:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] xen: Fix PV-only build To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jason Andryuk , Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" References: <20260806015233.202486-1-jason.andryuk@amd.com> <083db883-558a-4000-b404-bf170c8309ee@suse.com> <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> Content-Language: en-US From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------uxNiNwuKyqiy8WT2Z6TKl64T" X-purgate-ID: tlsNG-c201ff/1786017624-F6EB12A1-F0DA8FFD/0/0 X-purgate-type: clean X-purgate-size: 10903 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------uxNiNwuKyqiy8WT2Z6TKl64T Content-Type: multipart/mixed; boundary="------------qkri4ZR0n1B8ZcmddgEmCyAY"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jason Andryuk , Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Message-ID: <967208c9-8d51-4380-8cb4-298f5c313d35@suse.com> Subject: Re: [PATCH 0/2] xen: Fix PV-only build References: <20260806015233.202486-1-jason.andryuk@amd.com> <083db883-558a-4000-b404-bf170c8309ee@suse.com> <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> In-Reply-To: <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------qkri4ZR0n1B8ZcmddgEmCyAY Content-Type: multipart/mixed; boundary="------------hcsGsDhH3CmWe1jsW0yEqvuR" --------------hcsGsDhH3CmWe1jsW0yEqvuR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDguMjYgMTM6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNi4wOC4yMDI2 IDEyOjU1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDYuMDguMjYgMDM6NTIsIEph c29uIEFuZHJ5dWsgd3JvdGU6DQo+Pj4gQWxsb3cgZGlzYWJsaW5nIFhFTl9QVkhWTSBmb3Ig YSBQVi1vbmx5LiAgQSBzdHViIGluIHRoZSBldmVudCBjaGFubmVsDQo+Pj4gY29kZSBuZWVk cyB0byBiZSBmaXhlZCBmaXJzdC4NCj4+Pg0KPj4+IEphc29uIEFuZHJ5dWsgKDIpOg0KPj4+ ICAgICB4ZW4vZXZlbnRzOiBGaXggeGVuX3NldF91cGNhbGxfdmVjdG9yIHN0dWINCj4+PiAg ICAgeGVuL0tjb25maWc6IHNlbGVjdCBYRU5fUFZIVk0NCj4+Pg0KPj4+ICAgIGFyY2gveDg2 L3hlbi9LY29uZmlnICAgICAgICAgICAgIHwgOCArKysrKy0tLQ0KPj4+ICAgIGRyaXZlcnMv eGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jIHwgMiArLQ0KPj4+ICAgIDIgZmlsZXMgY2hhbmdl ZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQ0KPj4+DQo+Pg0KPj4gSSBkaWQg YSBjb21wYXJpc29uIG9mIGEga2VybmVsIGJ1aWx0IHdpdGggeW91ciBwYXRjaGVzIGRpc2Fi bGluZyBYRU5fUFZIVk0NCj4+IGFuZCBteSBwYXRjaGVzIHdpdGggWEVOX1BWSFZNX0dVRVNU IGRpc2FibGVkLg0KPj4NCj4+IFRoZSBrZXJuZWwgYnVpbHQgd2l0aCBteSBwYXRjaGVzIGlz IDYgYnl0ZXMgc21hbGxlciB0aGFuIHRoZSBvbmUgd2l0aCB5b3VyDQo+PiBwYXRjaGVzLg0K PiANCj4gSXNuJ3QgdGhpcyBhIHNpZ24gb2Ygc29tZXRoaW5nIGVsc2UgbmVlZGluZyB0d2Vh a2luZywgc29tZXdoZXJlPw0KDQpUaGlzIGlzIGEgc2lnbiB0aGF0IHRoZXJlIGFyZSBwcm9i YWJseSBvbmx5IHZlcnkgZmV3IHJlYWxseSBIVk0gc3BlY2lmaWMgcGF0aHMNCihpbiB0aGUg c2Vuc2Ugb2Y6IGV4cGxpY2l0bHkgbm90IG1hcmtlZCBhcyBpcnJlbGV2YW50IGZvciBQVikg aW4gdGhlIGtlcm5lbC4NClllcywgSSdtIHN1cmUgeW91IGNhbiBmaW5kIHNvbWUgbW9yZSwg YnV0IEknbSByZWFsbHkgbm90IHN1cmUgdGhpcyBpcyByZWxldmFudA0KZm9yIG1vcmUgdGhh biBhIGhhbmRmdWwgb2YgdXNlcnMuDQoNCj4+IFNvIEkgZG9uJ3Qgc2VlIGFueSByZWFzb24g dG8gdGFrZSB5b3VyIHBhdGNoZXMsIHdoaWNoIGNvbmZsaWN0IHdpdGggbWluZSwNCj4+IGVz cGVjaWFsbHkgYXMgbXkgcGF0Y2hlcyBoYXZlIGEgbmVnYXRpdmUgZGlmZnN0YXQgb24gc291 cmNlIGxldmVsLCB0b28uDQo+IA0KPiBIbW0sIEphc29uJ3MgcGF0Y2hlcyBsb29rIHRvIG1v dmUgdGhpbmdzIGludG8gYSBtb3JlIGFkZXF1YXRlIGRpcmVjdGlvbiwNCj4gdGhvdWdoLiBJ biB3aGljaCBjYXNlIEkgdGhpbmsgYSBuZWdhdGl2ZSBkaWZmc3RhdCBiZWNvbWVzIGFuIGly cmVsZXZhbnQNCj4gYXJndW1lbnQ/DQoNCkRlcGVuZHMgb24gd2hhdCB5b3UgYXJlIGxvb2tp bmcgZm9yLg0KDQpNeSB0YWtlIGZyb20gdGhpcyBpcyB0aGF0IGEgUFYtb25seSBrZXJuZWwg d2l0aCBKYXNvbidzIHBhdGNoZXMgaXMgbm90IHJlYWxseQ0KYWRkaW5nIGFueSB2YWx1ZSwg d2hpbGUgbXkgc2ltcGxpZmljYXRpb24gaXMgYXQgbGVhc3QgbWFraW5nIHRoaW5ncyBzaW1w bGVyDQppbiB0ZXJtcyBvZiBjb2RlIHZvbHVtZSBhbmQgbnVtYmVyIG9mIFhlbiByZWxhdGVk IGNvbmZpZyBvcHRpb25zLg0KDQpPZiBjb3Vyc2UgaXQgd291bGQgYmUgcG9zc2libGUgdG8g aGF2ZSBhIHNtYWxsZXIgUFYtb25seSBrZXJuZWwsIGJ1dCBhcyBJIHNhaWQNCmFscmVhZHks IHRoZXJlIGhhcyBiZWVuIG5vIHB1YmxpYyBkZW1hbmQgZm9yIHRoYXQgaW4gdGhlIGxhc3Qg eWVhcnMgYW5kIHRoZQ0KZG93bnNpZGVzIElNSE8gZmFyIG91dHdlaWdoIHRoZSBwb3RlbnRp YWwgZ2Fpbi4NCg0KSU1PIHRoZSAiYWRlcXVhdGUgZGlyZWN0aW9uIiByZWdhcmRpbmcgWGVu IHNwZWNpZmljIGtlcm5lbCBjb2RlIGlzIHRvd2FyZHMgUFZIDQphbmQgbm90IHRvd2FyZHMg bW9yZSBQViBzcGVjaWZpYyB0d2Vha2luZy4gQW5kIEknbSB2ZXJ5IHN1cmUgdGhlIGtlcm5l bA0KY29tbXVuaXR5IG91dHNpZGUgb2YgdGhlIFhlbiBjb21tdW5pdHkgaXMgYWdyZWVpbmcg d2l0aCBtZSBoZXJlLg0KDQoNCkp1ZXJnZW4NCg== --------------hcsGsDhH3CmWe1jsW0yEqvuR Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------hcsGsDhH3CmWe1jsW0yEqvuR-- --------------qkri4ZR0n1B8ZcmddgEmCyAY-- --------------uxNiNwuKyqiy8WT2Z6TKl64T Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmp0d1YFAwAAAAAACgkQsN6d1ii/Ey/s PQf/RmWSU8PmAFvgouFrYfNYILXmJGZhWhBd2gHdpMWHSOjgQFAmKhqIK42bjsNnyh1eF0crr+g7 m9O8qY+fd+fXcI6iwPa+RWDZHTGLxdYuI6TQX7OMsuaDRnTzHk+WacAwVfOSqvkDx0f2uagfxqef sFhirnvS0wyiSKd9Qo3UGmFJGvKfiVdVYKfDb4y9TuOdxtM4E0BiFcyzYqWIWh+SHA3yoZXzwnAf pyBpj/WERJZex8/+SEshJz1weNKMe7Z56P/12K2e4m83nndEF+qNOXRA89YAW5FCCb+Ri11VEJcm AFCuNSIEYM1ZLI/qAx+nNLRZ8K75WKQrhe+gbd+/Ug== =vN2B -----END PGP SIGNATURE----- --------------uxNiNwuKyqiy8WT2Z6TKl64T-- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 12:15:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 12:15:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384689.1627511 (Exim 4.92) (envelope-from ) id 1wrx05-0008BF-32; Thu, 06 Aug 2026 12:15:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384689.1627511; Thu, 06 Aug 2026 12:15:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrx04-0008B8-W2; Thu, 06 Aug 2026 12:15:04 +0000 Received: by outflank-mailman (input) for mailman id 1384689; Thu, 06 Aug 2026 12:15:03 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrx03-0008B2-PA for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 12:15:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrx03-00FZMR-4w for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 14:15:03 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a747ac5-bab6-0a2a0a5309dd-0a2a4509d75c-4 for ; Thu, 06 Aug 2026 14:15:03 +0200 Received: from [209.85.128.54] (helo=mail-wm1-f54.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a747ac6-be1a-0a2a45090019-d1558036e9f4-3 for ; Thu, 06 Aug 2026 14:15:02 +0200 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4955de8797cso14202675e9.3 for ; Thu, 06 Aug 2026 05:15:02 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499541b86f5sm59244655e9.0.2026.08.06.05.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 05:15:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786018502; x=1786623302; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3R0vA+IQ+bdFfwfHDI/nIiFtIJi+isNnUOnVQX7C3yc=; b=MADXWPqvEscO9DbC8WHrOoPlDFDZ04z9wpoEs1J7t0+zbG7DYCunqPHKlKJnDuDoZN QMIMt0xZF+i4u95BjtOR3DDY/FCSo9R8o6knSoimQslK6Cg1KBiFlsHyIttNz1YaFJHr mnGnN6PHwuc+LtR0nQvhvpdERU7vAHfsr1ZNhxxQfb/foVHD09uNXQeDRNuHtrIzM/Bb BBsYw8EbVI3iiOODrB7t8hAUiOvji5XJrykrjUXow58wHPCOolyBNgP81Ka55urQDvQ7 aZxq8Sd4N5EwmS/teB2NTN0ag1bnvPFzMpkhXGuHS8hbqSJQimCRF101DCNnnztcDNCz BGlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786018502; x=1786623302; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3R0vA+IQ+bdFfwfHDI/nIiFtIJi+isNnUOnVQX7C3yc=; b=Vk4KOZlMQYxqaR9O79ZvpAzG5Ux9nsIlNdFsuuQ42JXnt4G+8yxcBfpxvOvF1Q+e0e FBBP95Xy5B43Hc8yNF/z222oa0rXxDayV8P4yDclXXFQMpAYXO7IRE9XKl/+Irp34tGD D4v/jwWWw+StncJanP8zYhwEEKW5nD/9F6NTLmUDrDJufY0Ef/ExK4cTsTM2oenRHJMT SxxSkuxetQ3mZDLboNBK7mEN8kZ5+MYv4hoAs3m+53xHrCaTdA1sSH4QvToyNKaXxWyw 1wDvF6CSoNgDzNpfJ1oH0sraxEVHwiHIoXXqUIME2ubGZ5f6AS6vRu9eVQGSVm2h4oHS piBQ== X-Forwarded-Encrypted: i=1; AHgh+RqrTmyow76wEiJxexkTrQ5TbCeKPQjrrWVIG1DhRKV9BttHqXA4HveJO7wMEfncRurc0hsDyQjuRMk=@lists.xenproject.org X-Gm-Message-State: AOJu0YxNIzIGbm3pIc1+w0PGpI9HnWQDjR2hcEFtpjezIem9wjBYs7ZA M7WAVULl9DIbYODsoyFZPZZItO+blMLAjb2zOmVOKYj018aXZRNrqTdMxVpRL8Pzzw== X-Gm-Gg: AR+sD10n3oA6q4UUTwRQmqQaKCAd9bo1BkIgNeLDVBRtHfU1w8Ogj4nJzwMwuWJ1hdV /fQfutrFUtmpy0OLL1sKmVCsKPfxy+RbAMMkNIMTbQdWYQg42vKi7qr7fLr8CRL+Wmrczo9+F74 +k43Lhf5MTzIOnlvhsRQM5mv/mYRdn1CmmKOZItGcsyEXCAKsG7vx3YjYiIitluux765vT7aN01 ZT/x78IWMKAo+BemKvYeq5ggexhpR0rCRJneEtGinoquSWZMNtd2DUP4LevbIO1jYwxNKNB8lM4 Ndt44irHKtlGVsychsiUkDdKq22H8Mdc1AU8TPGDzg34gQW03Ec5lhKmeCBAR9w/K+7ar3+NNnE DMpoCZesdI5MrDD1wx4cv0Yteh63FPJUR2Z69P/msC0IePV8K4mjgBAClIXRiqN+5Gp/LOnckP3 hHTwfJdOEChHvfb5f7WTJSmwsPNoM4co4BzoB2l+KJvhZFFBXD+Q6vPhKRw5PHcMVvz8ecZYI50 1Ldtc9j64d4aiO3iJ/6ZABH9RKWozCEcmTJz6nmap0LPB/HKETe X-Received: by 2002:a05:600c:4fca:b0:496:c2fd:1731 with SMTP id 5b1f17b1804b1-4994e711309mr172456795e9.1.1786018502050; Thu, 06 Aug 2026 05:15:02 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 14:15:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/vpci: allow unaligned accesses by the hardware domain To: Andrew Cooper , Roger Pau Monne Cc: Anthony PERARD , Teddy Astie , Stewart Hildebrand , Jason Andryuk , xen-devel@lists.xenproject.org References: <20260806110401.19615-1-roger@xenproject.org> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1786018502-3BCD7034-5A9AB471/0/0 X-purgate-type: clean X-purgate-size: 1745 On 06.08.2026 13:48, Andrew Cooper wrote: > On 06/08/2026 12:04 pm, Roger Pau Monne wrote: >> --- a/xen/arch/x86/x86_64/pci.c >> +++ b/xen/arch/x86/x86_64/pci.c >> @@ -26,7 +26,7 @@ uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg) >> >> uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) >> { >> - if ( sbdf.seg || reg > 255 ) >> + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) >> { >> uint32_t value; >> > > Personally, I think this is making a bad situation worse. > > Baring quirks (i.e. K10 era), there is never a case where we want to use > the IO Ports when we've got ECAM.  Furthermore, on AMD systems when > we're lacking ECAM we can still access Extended Config Space; something > which Xen currently gets wrong in several ways. > > The IO ports require a global spinlock in Xen, and then a global > resource in hardware just to be able to translate the IO access back > into the ECAM access we passed on originally.  i.e. from a safety > non-interference point of view, you want to veto any use of the IO ports > by Xen. > > Xen needs to use ECAM, and only fall back to IO Ports if we think there > isn't ECAM covering the target sbdf.  This will cause (mis)alignment to > get fixed automatically.  It will also be a substantial perf boost in > the general case; all the MSI/MSI-X editing we do (far too frequently) > is in Legacy Config Space just uses IO Ports. While I agree, that's a bigger change which likely is going to be unsuitable for (immediate) backporting. Nevertheless the cross-device access that the changes as presented could cause needs preventing, by altering the checks at the start of pci_mmcfg_{read,write}(). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:21:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:21:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384730.1627520 (Exim 4.92) (envelope-from ) id 1wry1t-0007Fl-KP; Thu, 06 Aug 2026 13:21:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384730.1627520; Thu, 06 Aug 2026 13:21:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wry1t-0007Fe-HC; Thu, 06 Aug 2026 13:21:01 +0000 Received: by outflank-mailman (input) for mailman id 1384730; Thu, 06 Aug 2026 13:20:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wry1r-0007FY-Lt for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:20:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wry1r-0080BL-0A; Thu, 06 Aug 2026 13:20:58 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wry1q-0077Km-1L; Thu, 06 Aug 2026 13:20:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=V9I8wN3vFwmrsijFohcDbSfGEb54X0VqpVhd06JB0DM=; b=qbMm5RDrShyacGJPQC/eUzRe/i A0EkPoJZYyKhST4ZbttF7Bg4jeSIRTNKG1BAcYpqOb/2PWTkdhip11i1NBGFnypffvhfix1swWVza hYJS9BVTMS8mw9oUOJlpD1zDSoSMpDv3uHnE0G/B42cOR9YefLYIVlMIAeHwXCLpTmjA=; Date: Thu, 6 Aug 2026 15:20:47 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Anthony PERARD , Jan Beulich , Teddy Astie , Stewart Hildebrand , Jason Andryuk Subject: Re: [PATCH] xen/vpci: allow unaligned accesses by the hardware domain Message-ID: References: <20260806110401.19615-1-roger@xenproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Aug 06, 2026 at 12:48:12PM +0100, Andrew Cooper wrote: > On 06/08/2026 12:04 pm, Roger Pau Monne wrote: > > It's possible for domains to generate unaligned PCI config space accesses > > when using ECAM, and hence vPCI should support those at least for the > > hardware domain. Such unaligned accesses to the PCI config space have been > > reported to come from ACPI logic. > > By this, I presume you mean AML from the DSDT/SSDT ? That's my understanding yes, I can't confirm whether it's from the DSDST/SSDT or maybe one of the OEM tables. > Misaligned ECAM accesses have undefined behaviour.  On a particular > platform this probably means implementation defined, and for an access > wholly within a single devices CFG window it might even work.  But, > misaligning allows you to have one access hitting two devices, and this > really can't be a good thing. Well, for the hardware domain I merely wanted to replay the access, but it's true that for access control (that we still do in the hardware domain case) an access targeting two different devices would require extra checking that we don't do. I think it's possibly best to not relax the check in vpci_access_allowed() as much as I did, and refuse cross-device accesses. > I presume "fix your BIOS" isn't on the cards, even if it would be for > the greater good? I don't know really, maybe it's possible to get this one fixed. But it's likely Xen would hit this again, and most people would attribute the issue to Xen, because it works with plain Linux, but doesn't when running as a hardware domain (as the unaligned access is ignored or reads all 1s). We have always said that for the hardware domain we would attempt to get as less as possible in the way of it interacting with devices. I think this is just one more instance of such avoidance of interference from hardware domain accesses. > > > > Relax the checking in vpci_access_allowed() to allow such accesses for the > > hardware domain, and fix the handling in pci_conf_{read,write}{16,32}() to > > fulfill them using MMCFG. > > > > MMCFG regions are identity exposed to the hardware domain, and hence such > > unaligned accesses can only come as a result of the host having MMCFG in the > > first place, as otherwise MMCFG won't be exposed to the hardware domain > > either. > > > > Reported-by: Jason Andryuk > > Signed-off-by: Roger Pau Monné > > --- > > tools/include/xen-tools/common-macros.h | 2 ++ > > xen/arch/x86/x86_64/pci.c | 8 ++++---- > > xen/drivers/vpci/vpci.c | 4 +++- > > 3 files changed, 9 insertions(+), 5 deletions(-) > > > > diff --git a/xen/arch/x86/x86_64/pci.c b/xen/arch/x86/x86_64/pci.c > > index 8d33429103b9..6298141c3ca7 100644 > > --- a/xen/arch/x86/x86_64/pci.c > > +++ b/xen/arch/x86/x86_64/pci.c > > @@ -26,7 +26,7 @@ uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg) > > > > uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) > > { > > - if ( sbdf.seg || reg > 255 ) > > + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) > > { > > uint32_t value; > > > > Personally, I think this is making a bad situation worse. > > Baring quirks (i.e. K10 era), there is never a case where we want to use > the IO Ports when we've got ECAM.  Furthermore, on AMD systems when > we're lacking ECAM we can still access Extended Config Space; something > which Xen currently gets wrong in several ways. > > The IO ports require a global spinlock in Xen, and then a global > resource in hardware just to be able to translate the IO access back > into the ECAM access we passed on originally.  i.e. from a safety > non-interference point of view, you want to veto any use of the IO ports > by Xen. > > Xen needs to use ECAM, and only fall back to IO Ports if we think there > isn't ECAM covering the target sbdf.  This will cause (mis)alignment to > get fixed automatically.  It will also be a substantial perf boost in > the general case; all the MSI/MSI-X editing we do (far too frequently) > is in Legacy Config Space just uses IO Ports. I've wondered the same myself for some time, but I was also a bit puzzled by Linux using the same approach, and preferring the IO ports for accesses to the non-extended space. Overall I think we would widen the hardware domain accesses _before_ ahead of switching PCI accesses to prefer ECAM over IO ports. So that the former can be backported without depending on the latter. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:24:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384739.1627531 (Exim 4.92) (envelope-from ) id 1wry5P-00083z-7C; Thu, 06 Aug 2026 13:24:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384739.1627531; Thu, 06 Aug 2026 13:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wry5P-00083s-3n; Thu, 06 Aug 2026 13:24:39 +0000 Received: by outflank-mailman (input) for mailman id 1384739; Thu, 06 Aug 2026 13:24:38 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wry5N-00083k-S5 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:24:38 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wry5M-00D6Wn-VM for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:24:36 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a748b0b-5cb7-0a2a0a5109dd-0a2a4506908c-16 for ; Thu, 06 Aug 2026 15:24:36 +0200 Received: from [52.101.53.19] (helo=BL0PR03CU003.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a748b12-195a-0a2a45060019-346535137015-3 for ; Thu, 06 Aug 2026 15:24:35 +0200 Received: from BL1PR13CA0166.namprd13.prod.outlook.com (2603:10b6:208:2bd::21) by SAWPR12MB999115.namprd12.prod.outlook.com (2603:10b6:806:4e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 13:24:31 +0000 Received: from MN1PEPF0000F0E2.namprd04.prod.outlook.com (2603:10b6:208:2bd:cafe::74) by BL1PR13CA0166.outlook.office365.com (2603:10b6:208:2bd::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.8 via Frontend Transport; Thu, 6 Aug 2026 13:24:30 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by MN1PEPF0000F0E2.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 13:24:30 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 08:24:30 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 08:24:30 -0500 Received: from [172.19.79.34] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 08:24:29 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cTMz2uCOe150771s0ea9CpVcK9ABgIvKotVY3DV9CH9zxw/1hPcgqcy/1IygGVZ7Np6iIJtG3wSwczlSy2jSQthXGXC7mAzwhPitABy6gKreDnH9Kn2cBoMsyuA64LeDl0CtWk36TBpVYNBmVaAD58CmHffkxJYcGkJQjvceieVPFej2avl/GjCH3HR5uabJjkpwLbbhpsBL5JoWeCfLLn8cNYjJ60beffeBAvwnCquIZn/q7SOIHu5pks0rC+c3F7GfekPbg0idFjreNcFUcqeL1R4XAthX0iHEv8ft2jUeTaznJh4W/PCh4/bzzdFu8UDGKLkE2wxAfGNsQ1XyCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VqnVCxBV0rWSAz2hpAfkfFUUEiUk19P4xvnLAhsWtzY=; b=BmezDUTZ5Hprw6OF+nVrjMp/jNg2dMeVvFru+loo/Ncx7KUyHqOGt1Ol0wacP+66KesyosO4Bq9odgwnMkd7jBRPbhIrWX+TrwaaeOIVGN5SydNqBMED6L4hW6FnM10PzIZII77Bdy+dVnauXcpsmIYemIhI8ZscMBdGs2MrEaCnxadkq7v4LGIdwHFhlcIiflylL6U0D66nFrBlbGuGXnMzZPBvZ0lf6XGEBh+BXApI0UA3CmLjLGtuY+kd7aoD2iQCRCey7cQWUtVI/OZxu3HHwPklka96R+pLHCs38sozd5A0eZ6VOyVGDiaeTYBK5BJdVvypXlEBxwzV3cOhMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VqnVCxBV0rWSAz2hpAfkfFUUEiUk19P4xvnLAhsWtzY=; b=tkwa01y8Tb/U/5rJ/toka0qQgmrK2n/2ukfcsRg9qaCx00TGir0r0KfavIqcMCB+zyn4YjztJjpJnmnYx3AfTTiRorWBCkRfozSYLiSF3O2eXCPT+LZ+xI/y6W/09t3HsQUeWDffsZ8S7f1PEYt6VqfnFCHRVRKjXLZvSeMFOzY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Message-ID: Date: Thu, 6 Aug 2026 09:24:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] xen: Fix PV-only build To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Jan Beulich CC: Andrew Cooper , , , "Stefano Stabellini" , Oleksandr Tyshchenko , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" References: <20260806015233.202486-1-jason.andryuk@amd.com> <083db883-558a-4000-b404-bf170c8309ee@suse.com> <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> <967208c9-8d51-4380-8cb4-298f5c313d35@suse.com> Content-Language: en-US From: Jason Andryuk In-Reply-To: <967208c9-8d51-4380-8cb4-298f5c313d35@suse.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E2:EE_|SAWPR12MB999115:EE_ X-MS-Office365-Filtering-Correlation-Id: 519541e7-654c-4ad3-ec19-08def3be0c45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|7416014|1800799024|376014|36860700016|4143699003|56012099006|10067099003|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ssmviAh4UlGbLMVR9qrVzGMffOV+F93ogJBOiX2JmxPorOV/wZD2YNcTH6+snAgGYByvpg3c13rL8jGnIlSR7Tt6UKR1ulTAFIjmGyjGChBGpwTsM7TgwfzfM7JB3D2M0B6t42wd5nBFRyU3boD8JKSJWullescDG2oZG5CCrSinnVcNNC9cM5M5D1vkN9ObJYDagXl1rYys/5X1rG+9bYTliJsm4l1ON3XUt7xLinXkI7+Nm+pjkh5SRtOmbl9THGaigJf1W4tsMdh3RIV3a4lYhs2/swUUlxurAtIWKyQPod5vb5bGrY7JtJFOX1BFKNc7LD3YtYOyKg59nNVCZlCPiDHPz/x15OQaXzlC0ddjWjzuBEinjB2oWHILMrcDi7jDqvC6UFK7ZP5ZHbTsrxCyLzI7qLTZKv/ufAaMrUX97Wp1tc6fbpLNBRlRy0q6Xf/cXi3ULLmIgutYkfHAdCcMGbBBn1iVRQ7RsTOwoDD2zLJt+AQ8Kn/ch33R8l1IFbGgjG//IqkkSWHsWaZfm0ZNj8SQS+9DW1aoaXQLF5TH3DNdPueWkXF96TIyul1ZqBQGZMsfVIz0fnGDa5uGOWL6hW5N29N/xLnFOQeJzIkCFxWUFYw0yVTOGOrpDz6dlpIq0umcvLG9pfSE9rtMYokONSkOpPB18/Mol1quDJisR1XtmedbO3o22+qh7aPF0ICXCe4Axwb47B5zb23A2g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(7416014)(1800799024)(376014)(36860700016)(4143699003)(56012099006)(10067099003)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IuKYHvvcTRYFO/KZfmFoO/sm6r+TPgmOi/Np8cb7Bhat02kwhhP2Qt63hD/yxQntVyKbkqvfS5i0jrOS2NU72YA6232HMDiJD2G4VvgPZXmODeoqe6KOr1oda/jZRrMu1c6i99o0FfDfeTR9Rm8Ehjx6F5obJzESmtBLlkBOlOqBmxpKbKiiK7exXj8EYDDRpPOE0atZM52ca2+oE/7uZxAt6QpKk5fuqdBUfWxbdP+R1OH0mwlDuiHg3JlkD+eKASC9kmO2zsbhxn7Xzv5qt1CCBzMN/IZkY+Oi5U2PJLajPniUAYHTKSFm+iwsuN4k7DB+IcvinwIzfE+3y6a7GHqz0mgpqz9AJZvOqBevlAab4hgW6eWCcIHC5VxatK96eS9fez8fS5yL31epkGRvfduKVTZIRTMkdyJBIxELh+4kOXdK7rUuc/MJdhTlrO9X X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 13:24:30.7985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 519541e7-654c-4ad3-ec19-08def3be0c45 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SAWPR12MB999115 X-purgate-ID: tlsNG-16d1c6/1786022676-F5C0F77B-6412BB99/0/0 X-purgate-type: clean X-purgate-size: 2949 On 2026-08-06 08:00, Jürgen Groß wrote: > On 06.08.26 13:31, Jan Beulich wrote: >> On 06.08.2026 12:55, Juergen Gross wrote: >>> On 06.08.26 03:52, Jason Andryuk wrote: >>>> Allow disabling XEN_PVHVM for a PV-only.  A stub in the event channel >>>> code needs to be fixed first. >>>> >>>> Jason Andryuk (2): >>>>     xen/events: Fix xen_set_upcall_vector stub >>>>     xen/Kconfig: select XEN_PVHVM >>>> >>>>    arch/x86/xen/Kconfig             | 8 +++++--- >>>>    drivers/xen/events/events_base.c | 2 +- >>>>    2 files changed, 6 insertions(+), 4 deletions(-) >>>> >>> >>> I did a comparison of a kernel built with your patches disabling >>> XEN_PVHVM >>> and my patches with XEN_PVHVM_GUEST disabled. >>> >>> The kernel built with my patches is 6 bytes smaller than the one with >>> your >>> patches. >> >> Isn't this a sign of something else needing tweaking, somewhere? > > This is a sign that there are probably only very few really HVM specific > paths > (in the sense of: explicitly not marked as irrelevant for PV) in the > kernel. > Yes, I'm sure you can find some more, but I'm really not sure this is > relevant > for more than a handful of users. I see more reduction: 15029248 - arch/x86/boot/bzImage 15021056 - arch/x86/boot/bzImage.after ~8k 52542480 - vmlinux 52523184 - vmlinux.after ~18k $ ../linux/scripts/bloat-o-meter vmlinux vmlinux.after add/remove: 1/136 grow/shrink: 14/48 up/down: 15902/-22430 (-6528) >>> So I don't see any reason to take your patches, which conflict with >>> mine, >>> especially as my patches have a negative diffstat on source level, too. >> >> Hmm, Jason's patches look to move things into a more adequate direction, >> though. In which case I think a negative diffstat becomes an irrelevant >> argument? > > Depends on what you are looking for. > > My take from this is that a PV-only kernel with Jason's patches is not > really > adding any value, while my simplification is at least making things simpler > in terms of code volume and number of Xen related config options. > > Of course it would be possible to have a smaller PV-only kernel, but as > I said > already, there has been no public demand for that in the last years and the > downsides IMHO far outweigh the potential gain. > > IMO the "adequate direction" regarding Xen specific kernel code is > towards PVH > and not towards more PV specific tweaking. And I'm very sure the kernel > community outside of the Xen community is agreeing with me here. I don't need PV-only kernels, so I am fine with not pursuing this patch set. Mainly I wanted to post this alternative since restoring PV-only is possible (and I inadvertently broke it). Converting CONFIG_XEN_PVHVM to CONFIG_XEN looked wrong when it didn't apply to PV. Pursuing your patches for the reasons you give also makes sense. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:28:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:28:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384746.1627540 (Exim 4.92) (envelope-from ) id 1wry8f-00012o-N2; Thu, 06 Aug 2026 13:28:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384746.1627540; Thu, 06 Aug 2026 13:28:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wry8f-00012g-Hm; Thu, 06 Aug 2026 13:28:01 +0000 Received: by outflank-mailman (input) for mailman id 1384746; Thu, 06 Aug 2026 13:28:00 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wry8e-00012Z-Dw for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:28:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wry8d-00D7Jb-I3 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:27:59 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a748bbe-e002-0a2a0a5209dd-0a2a4508860c-16 for ; Thu, 06 Aug 2026 15:27:59 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a748bde-f659-0a2a45080019-b9ff1c238b09-3 for ; Thu, 06 Aug 2026 15:27:59 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fd7425a8b000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 06 Aug 2026 13:27:57 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 1441B82386; Thu, 6 Aug 2026 15:27:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=fjcOJJ9BNo78EaWRAyLGoUF/eBtBx/DiG9665z3EPtU=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=f6UMgWaqhRFqVgHx1QmH/JtT16Z/dYDma5hx456VQEJwCfM58H7RWZ9927IY1YnnpGHslFAN2 m8WQhguhqtuE9U23n56xaJTuprJKI6LYvsEWjEwkkHWZzd026uc0aiXEEXD0rl4ImbCm0sW9gc+ RA6QJBgcOQYEnAFsdUely1De6CxpkJjd5zycpyzQa3QgBlHgoa6IoGJnbMr7973QXFnL5MBxTeP 9qm00Y5jW5wdzoyvaNXQ3+8p5Na69+7C03+P8md36mcsV993eKZZ+Gp3XJR0gWXemPykD1ILE3y wreEwz0HsjEgSLE9CDBY9OJAy0iVg1F9SVixDba+Zasw== X-Zone-Loop: dec621bc5d807e9562f8be292c276d08a94a153578e9 x-campaign-type: default x-transaction-id: 927a11e6-6598-4bd5-af17-fdf5ba979995 x-swg-uid: 01-e21cba5d-2040-4d00-bfdf-fd5ca1d1d74f X-Mailer: Sweego Message-ID: <1786022877.8631fc262581453bbf619ec5b2062170.19fd7425a8b000e099@vates.tech> x-swg-bid: 1786022877.8631fc262581453bbf619ec5b2062170.19fd7425a8b000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Thu, 6 Aug 2026 15:27:56 +0200 From: Anthony PERARD To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini Subject: Re: [PATCH 2/3] xen/scripts: adapt gen_compile_commands.py to Xen References: <20260805015247.41943-1-gwd@xenproject.org> <20260805015247.41943-3-gwd@xenproject.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260805015247.41943-3-gwd@xenproject.org> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.1dd4.114358bb8e9b1a69.19fd742582f.9b2b9f1f500dbd5c=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786022877231 X-purgate-ID: tlsNG-c1860d/1786022879-CDF4787B-4101139F/0/0 X-purgate-type: clean X-purgate-size: 4002 ---=Part.1dd4.114358bb8e9b1a69.19fd742582f.9b2b9f1f500dbd5c=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2026 at 11:52:39AM +1000, George Dunlap wrote: > Two changes from the Linux original: >=20 > - Linux's compiler invocations end with the source file > ("=2E=2E=2E -c -o foo=2Eo foo=2Ec"), and the script's line pattern re= lies > on that; Xen's cmd_cc_o_c places "-c $<" before "-o" and "-MQ", > so on a Xen object tree the unmodified script matches nothing and > produces an empty database=2E Adjust _LINE_PATTERN to capture the > command up to and including "-c" plus the source file, dropping > the remainder, which database consumers do not need=2E >=20 > - Reword the docstring and help text to refer to Xen=2E >=20 > The support for reading object lists from archives and modules=2Eorder > is unused in Xen but retained to minimise divergence from the > original=2E >=20 > Assisted-by: LLM > Signed-off-by: George Dunlap > --- > xen/scripts/gen_compile_commands=2Epy | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) >=20 > diff --git a/xen/scripts/gen_compile_commands=2Epy b/xen/scripts/gen_com= pile_commands=2Epy > index 96e6e46ad1=2E=2E9abc6410c1 100755 > --- a/xen/scripts/gen_compile_commands=2Epy > +++ b/xen/scripts/gen_compile_commands=2Epy > @@ -5,7 +5,7 @@ > # > # Author: Tom Roeder > # > -"""A tool for generating compile_commands=2Ejson in the Linux kernel=2E= """ > +"""A tool for generating compile_commands=2Ejson for the Xen hypervisor= =2E""" > =20 > import argparse > import json > @@ -19,7 +19,10 @@ _DEFAULT_OUTPUT =3D 'compile_commands=2Ejson' > _DEFAULT_LOG_LEVEL =3D 'WARNING' > =20 > _FILENAME_PATTERN =3D r'^\=2E=2E*\=2Ecmd$' > -_LINE_PATTERN =3D r'^(saved)?cmd_[^ ]*\=2Eo :=3D (?P=2E= * )(?P[^ ]*\=2E[cS]) *(;|$)' > +# Unlike Linux, Xen's compile commands do not end with the source file: > +# cmd_cc_o_c places "-c $<" before "-o" and "-MQ"=2E This looks like a comment for the patch rather than the pattern in the following line=2E So it doesn't seems useful here=2E > Capture the command= up > +# to and including "-c" plus the source file, and drop the remainder=2E Here, I think it would be worth it to explain what the remainder is, which in turn would help explain why it is dropped at all=2E Besides that, the patch description and the other changes looks fine to me=2E > +_LINE_PATTERN =3D r'^(saved)?cmd_[^ ]*\=2Eo :=3D (?P=2E= * -c )(?P[^ ]*\=2E[cS])( =2E*)?$' > _VALID_LOG_LEVELS =3D ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] > # The tools/ directory adopts a different build system, and produces = =2Ecmd > # files in a different format=2E Do not support it=2E > @@ -35,10 +38,10 @@ def parse_arguments(): > output: Where to write the compile-commands JSON file=2E > paths: The list of files/directories to handle to find =2Ecmd f= iles=2E > """ > - usage =3D 'Creates a compile_commands=2Ejson database from kernel = =2Ecmd files' > + usage =3D 'Creates a compile_commands=2Ejson database from Xen =2Ec= md files' > parser =3D argparse=2EArgumentParser(description=3Dusage) > =20 > - directory_help =3D ('specify the output directory used for the kern= el build ' > + directory_help =3D ('specify the output directory used for the Xen = build ' > '(defaults to the working directory)') > parser=2Eadd_argument('-d', '--directory', type=3Dstr, default=3D'= =2E', > help=3Ddirectory_help) Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.1dd4.114358bb8e9b1a69.19fd742582f.9b2b9f1f500dbd5c=--- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:30:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:30:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384754.1627549 (Exim 4.92) (envelope-from ) id 1wryAk-0002dR-1L; Thu, 06 Aug 2026 13:30:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384754.1627549; Thu, 06 Aug 2026 13:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wryAj-0002dK-T0; Thu, 06 Aug 2026 13:30:09 +0000 Received: by outflank-mailman (input) for mailman id 1384754; Thu, 06 Aug 2026 13:30:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wryAi-0002dB-Sa for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:30:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wryAg-0080Mb-0z; Thu, 06 Aug 2026 13:30:06 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wryAf-0078oR-2M; Thu, 06 Aug 2026 13:30:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=qS5CrHMRnqXJOO0K6atLjDsVfa8CL8D+bDKEO+jgW5E=; b=SbJv5Ej9gb+LPNvByrr+01ow3O zLoTXKs/Y3yVijsGi++K55YDAXWCZig8OLkNGOTNQPOmOgR0TmQXqgo0AxRbWkAD54B0uSD8BRqS/ TZbmvRyp/2Cni4IvRk415alc0QC55IROgUVq6bnhTPSoogROCXTLwThjbfoOTWvBqJ/Q=; Date: Thu, 6 Aug 2026 15:26:32 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Anthony PERARD , Teddy Astie , Stewart Hildebrand , Jason Andryuk , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen/vpci: allow unaligned accesses by the hardware domain Message-ID: References: <20260806110401.19615-1-roger@xenproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Aug 06, 2026 at 02:15:02PM +0200, Jan Beulich wrote: > On 06.08.2026 13:48, Andrew Cooper wrote: > > On 06/08/2026 12:04 pm, Roger Pau Monne wrote: > >> --- a/xen/arch/x86/x86_64/pci.c > >> +++ b/xen/arch/x86/x86_64/pci.c > >> @@ -26,7 +26,7 @@ uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg) > >> > >> uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) > >> { > >> - if ( sbdf.seg || reg > 255 ) > >> + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) > >> { > >> uint32_t value; > >> > > > > Personally, I think this is making a bad situation worse. > > > > Baring quirks (i.e. K10 era), there is never a case where we want to use > > the IO Ports when we've got ECAM.  Furthermore, on AMD systems when > > we're lacking ECAM we can still access Extended Config Space; something > > which Xen currently gets wrong in several ways. > > > > The IO ports require a global spinlock in Xen, and then a global > > resource in hardware just to be able to translate the IO access back > > into the ECAM access we passed on originally.  i.e. from a safety > > non-interference point of view, you want to veto any use of the IO ports > > by Xen. > > > > Xen needs to use ECAM, and only fall back to IO Ports if we think there > > isn't ECAM covering the target sbdf.  This will cause (mis)alignment to > > get fixed automatically.  It will also be a substantial perf boost in > > the general case; all the MSI/MSI-X editing we do (far too frequently) > > is in Legacy Config Space just uses IO Ports. > > While I agree, that's a bigger change which likely is going to be unsuitable > for (immediate) backporting. Nevertheless the cross-device access that the > changes as presented could cause needs preventing, by altering the checks at > the start of pci_mmcfg_{read,write}(). Hm, OK. I was planning to be a bit mire strict in vpci_access_allowed(), but I can also adjust pci_mmcfg_{read,write}(). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:32:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:32:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384760.1627557 (Exim 4.92) (envelope-from ) id 1wryCV-0003EQ-9u; Thu, 06 Aug 2026 13:31:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384760.1627557; Thu, 06 Aug 2026 13:31:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wryCV-0003EJ-6q; Thu, 06 Aug 2026 13:31:59 +0000 Received: by outflank-mailman (input) for mailman id 1384760; Thu, 06 Aug 2026 13:31:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wryCT-0003EA-Al for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:31:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wryCS-004LYS-Bc for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:31:56 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a748cb7-e002-0a2a0a5209dd-0a2a45039d68-46 for ; Thu, 06 Aug 2026 15:31:56 +0200 Received: from [209.85.208.42] (helo=mail-ed1-f42.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a748ccc-fae8-0a2a45030019-d155d02aed7c-3 for ; Thu, 06 Aug 2026 15:31:56 +0200 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-6a1a546a6bbso803594a12.1 for ; Thu, 06 Aug 2026 06:31:56 -0700 (PDT) Received: from ?IPV6:2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112? (2a00-12d0-af5d-ad01-5d3f-14e6-9bcb-5112.ip.tng.de. [2a00:12d0:af5d:ad01:5d3f:14e6:9bcb:5112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a196aed253sm837140a12.29.2026.08.06.06.31.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 06:31:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786023116; x=1786627916; darn=lists.xenproject.org; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ER2daL09LDBbo/3gJph6npA5SXNYn5TQtVyv8ie4GOI=; b=Uj5hrzuz5pSSU2Ysz/r3qdndk+DRSuWv9vHuJyNvKaunObvZ2FyDq+PmZiapEdcxuj AB22/V5g/OiwFp/cFGpT6LqV5sF8To/CA2dhGE9RSlKD8sG6BTywtLSVmUGr352cwph0 RvIm3dG8zEWNy1v/51TdYPbms2abyXkE8OTGegKzx3XjOkoEZlIMeiRZGo11QK8zci1Y XZTvkuHsYvvSS2H1qCUv1hUpU1JB+6FI5UNfqSLOJhQdvhBhlKQijhiS4uH4nfjqBY73 O700zfsah7egsfiLpgQ/kvovCiWOOyTnzXzYdaga94ZMmacVu4KRHq5ssmNWgAfL8qsy jTsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786023116; x=1786627916; h=content-type:in-reply-to:autocrypt:from:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ER2daL09LDBbo/3gJph6npA5SXNYn5TQtVyv8ie4GOI=; b=Hr+/W7wr04FUcwiZwKYPZ8yDix36eLcdJWbafEEDV16v4FzlsCoFq3Ypi6aI73cbZd 1URs/OBx7SH6fzhBxHR7+OqbwrX8//PQNXXnSL7OVsy9mlr7cacA/J+1wvaNaAiWoONh iMyd9CG7lN8kttZ6aklHt7PD9xh3dlKl4plVL6/TEScIVzD0mXEgEh1MQqgIQvzpka2Q ozjCiO93eNNwWTV4ylza0PX+c5MONr2Z3sTTBBJ3SApcrGlFan/KSKqq97/DqeA88r19 J/uQIOUP22BGpURuAIZkgq/S4vF5/v0oznqF/DtUnZUU1DBvHtVQI20nPwK7ylHxni33 vzww== X-Forwarded-Encrypted: i=1; AHgh+RoEWaP5JJZWjvzCS6rp4zLy1hzr+IcWfH4Vn4r6IBLH/x6PfT9eDPvwufs/ZuI4M7vYKst2TiseStE=@lists.xenproject.org X-Gm-Message-State: AOJu0YxhXNNNQ8gjsLr7NKsoTzBwkQlWjzANd/xpoCaIUqPznNvdJmOc /jgMEvaRrtqSWjVR2IjLhCb0k4Wt7DeXThpDl2uZ1mdiU99FMGIRwqNHAIltqLHvoOQ= X-Gm-Gg: AR+sD10dEOAAgS40a7qPNKakHPnZH3JDcu9Kdn/O+cv5gCfK+NFpjoRp13yatls+jQr OoDSs/gwnqf4FAFSGxtQtdBVQue5VHAiGW1p+X0+8zqgNarYxXaKG2zWAlmOQ7q9j3sGxo2H9JO W28OulPO+tIefUM7K4E+FWGqtWo2FgmTJHmnsOZ2LI23y/j/nEQARImxHAl9ONo5GvjME/LgV47 lwP1qhfZtIicy9ctkOXYSvXYyfFsVzcGJRQAP14UnUMLCUMSVvwgfSVBxMxnZwbWSBKzsPXYpLh luShwpgT0owrXbrGYAFupO6Elho6OqSgdEUAxhrjX3CVrc/7WhIkXAcNUSgile/JTwfk3NnEEO9 9Z7Sd+/UglUyZT/w7pASMMsIZ0s6RSAE+MwCd+MlCEYp/xVUw2w6hdUe5YsZn9uU2n8BWibz06h 9Ecupm9BwkOgb3NpEggwVMQI/RTYwid2bJrGbxNMhPWcCFZ1RGEnWo5CDraTxxpYVEgbz18lbd2 Qw3lbmDYv8ncA+aGWihMeDftJl2ey2GNQxKmLDzQ8Zgu7VDsqpvJbPZCL/cSWDQdYLkAENsTQJL SuEWOl4h4ZYZZ/k= X-Received: by 2002:a05:6402:518f:b0:6a1:8ec3:766d with SMTP id 4fb4d7f45d1cf-6a1b4bad1f5mr742692a12.19.1786023115597; Thu, 06 Aug 2026 06:31:55 -0700 (PDT) Message-ID: <3206813c-33fc-476f-a553-4d3f319459aa@suse.com> Date: Thu, 6 Aug 2026 15:31:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] xen: Fix PV-only build To: Jason Andryuk , Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" References: <20260806015233.202486-1-jason.andryuk@amd.com> <083db883-558a-4000-b404-bf170c8309ee@suse.com> <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> <967208c9-8d51-4380-8cb4-298f5c313d35@suse.com> Content-Language: en-US From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RBWR0lk1dgQ1uIbaPM46ZDwI" X-purgate-ID: tlsNG-33051d/1786023116-6CEDA4E9-1AE071EA/0/0 X-purgate-type: clean X-purgate-size: 12320 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RBWR0lk1dgQ1uIbaPM46ZDwI Content-Type: multipart/mixed; boundary="------------tzV1pVdD3C6cGm0x2ChdpT1y"; protected-headers="v1" From: Juergen Gross To: Jason Andryuk , Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Message-ID: <3206813c-33fc-476f-a553-4d3f319459aa@suse.com> Subject: Re: [PATCH 0/2] xen: Fix PV-only build References: <20260806015233.202486-1-jason.andryuk@amd.com> <083db883-558a-4000-b404-bf170c8309ee@suse.com> <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> <967208c9-8d51-4380-8cb4-298f5c313d35@suse.com> In-Reply-To: Autocrypt-Gossip: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJ3BBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AAIQkQoDSui/t3IH4WIQQ+pJkfkcoLMCa4X6CgNK6L+3cgfgn7AJ9DmMd0SMJE ePbc7/m22D2v04iu7ACffXTdZQhNl557tJuDXZSBxDmW/tLOwU0EWTecRBAIAIK5OMKMU5R2 Lk2bbjgX7vyQuCFFyKf9rC/4itNwhYWFSlKzVj3WJBDsoi2KvPm7AI+XB6NIkNAkshL5C0kd pcNd5Xo0jRR5/WE/bT7LyrJ0OJWS/qUit5eNNvsO+SxGAk28KRa1ieVLeZi9D03NL0+HIAtZ tecfqwgl3Y72UpLUyt+r7LQhcI/XR5IUUaD4C/chB4Vq2QkDKO7Q8+2HJOrFIjiVli4lU+Sf OBp64m//Y1xys++Z4ODoKh7tkh5DxiO3QBHG7bHK0CSQsJ6XUvPVYubAuy1XfSDzSeSBl//C v78Fclb+gi9GWidSTG/4hsEzd1fY5XwCZG/XJJY9M/sAAwUH/09Ar9W2U1Qm+DwZeP2ii3Ou 14Z9VlVVPhcEmR/AFykL9dw/OV2O/7cdi52+l00reUu6Nd4Dl8s4f5n8b1YFzmkVVIyhwjvU jxtPyUgDOt6DRa+RaDlXZZmxQyWcMv2anAgYWGVszeB8Myzsw8y7xhBEVV1S+1KloCzw4V8Z DSJrcsZlyMDoiTb7FyqxwQnM0f6qHxWbmOOnbzJmBqpNpFuDcz/4xNsymJylm6oXiucHQBAP Xb/cE1YNHpuaH4SRhIxwQilCYEznWowQphNAbJtEKOmcocY7EbSt8VjXTzmYENkIfkrHRyXQ dUm5AoL51XZljkCqNwrADGkTvkwsWSvCSQQYEQIACQUCWTecRAIbDAAKCRCgNK6L+3cgfuef AJ9wlZQNQUp0KwEf8Tl37RmcxCL4bQCcC5alCSMzUBJ5DBIcR4BY+CyQFAs= --------------tzV1pVdD3C6cGm0x2ChdpT1y Content-Type: multipart/mixed; boundary="------------UgvAncgvKwTDoFqxTDog8p7a" --------------UgvAncgvKwTDoFqxTDog8p7a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDguMjYgMTU6MjQsIEphc29uIEFuZHJ5dWsgd3JvdGU6DQo+IE9uIDIwMjYtMDgt MDYgMDg6MDAsIErDvHJnZW4gR3Jvw58gd3JvdGU6DQo+PiBPbiAwNi4wOC4yNiAxMzozMSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDYuMDguMjAyNiAxMjo1NSwgSnVlcmdlbiBH cm9zcyB3cm90ZToNCj4+Pj4gT24gMDYuMDguMjYgMDM6NTIsIEphc29uIEFuZHJ5dWsgd3Jv dGU6DQo+Pj4+PiBBbGxvdyBkaXNhYmxpbmcgWEVOX1BWSFZNIGZvciBhIFBWLW9ubHkuwqAg QSBzdHViIGluIHRoZSBldmVudCBjaGFubmVsDQo+Pj4+PiBjb2RlIG5lZWRzIHRvIGJlIGZp eGVkIGZpcnN0Lg0KPj4+Pj4NCj4+Pj4+IEphc29uIEFuZHJ5dWsgKDIpOg0KPj4+Pj4gwqDC oMKgIHhlbi9ldmVudHM6IEZpeCB4ZW5fc2V0X3VwY2FsbF92ZWN0b3Igc3R1Yg0KPj4+Pj4g wqDCoMKgIHhlbi9LY29uZmlnOiBzZWxlY3QgWEVOX1BWSFZNDQo+Pj4+Pg0KPj4+Pj4gwqDC oCBhcmNoL3g4Ni94ZW4vS2NvbmZpZ8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IDggKysr KystLS0NCj4+Pj4+IMKgwqAgZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMgfCAy ICstDQo+Pj4+PiDCoMKgIDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRl bGV0aW9ucygtKQ0KPj4+Pj4NCj4+Pj4NCj4+Pj4gSSBkaWQgYSBjb21wYXJpc29uIG9mIGEg a2VybmVsIGJ1aWx0IHdpdGggeW91ciBwYXRjaGVzIGRpc2FibGluZyBYRU5fUFZIVk0NCj4+ Pj4gYW5kIG15IHBhdGNoZXMgd2l0aCBYRU5fUFZIVk1fR1VFU1QgZGlzYWJsZWQuDQo+Pj4+ DQo+Pj4+IFRoZSBrZXJuZWwgYnVpbHQgd2l0aCBteSBwYXRjaGVzIGlzIDYgYnl0ZXMgc21h bGxlciB0aGFuIHRoZSBvbmUgd2l0aCB5b3VyDQo+Pj4+IHBhdGNoZXMuDQo+Pj4NCj4+PiBJ c24ndCB0aGlzIGEgc2lnbiBvZiBzb21ldGhpbmcgZWxzZSBuZWVkaW5nIHR3ZWFraW5nLCBz b21ld2hlcmU/DQo+Pg0KPj4gVGhpcyBpcyBhIHNpZ24gdGhhdCB0aGVyZSBhcmUgcHJvYmFi bHkgb25seSB2ZXJ5IGZldyByZWFsbHkgSFZNIHNwZWNpZmljIHBhdGhzDQo+PiAoaW4gdGhl IHNlbnNlIG9mOiBleHBsaWNpdGx5IG5vdCBtYXJrZWQgYXMgaXJyZWxldmFudCBmb3IgUFYp IGluIHRoZSBrZXJuZWwuDQo+PiBZZXMsIEknbSBzdXJlIHlvdSBjYW4gZmluZCBzb21lIG1v cmUsIGJ1dCBJJ20gcmVhbGx5IG5vdCBzdXJlIHRoaXMgaXMgcmVsZXZhbnQNCj4+IGZvciBt b3JlIHRoYW4gYSBoYW5kZnVsIG9mIHVzZXJzLg0KPiANCj4gSSBzZWUgbW9yZSByZWR1Y3Rp b246DQo+IDE1MDI5MjQ4IC0gYXJjaC94ODYvYm9vdC9iekltYWdlDQo+IDE1MDIxMDU2IC0g YXJjaC94ODYvYm9vdC9iekltYWdlLmFmdGVyDQo+IA0KPiB+OGsNCj4gDQo+IDUyNTQyNDgw IC0gdm1saW51eA0KPiA1MjUyMzE4NCAtIHZtbGludXguYWZ0ZXINCj4gDQo+IH4xOGsNCj4g DQo+ICQgLi4vbGludXgvc2NyaXB0cy9ibG9hdC1vLW1ldGVyIHZtbGludXggdm1saW51eC5h ZnRlcg0KPiBhZGQvcmVtb3ZlOiAxLzEzNiBncm93L3NocmluazogMTQvNDggdXAvZG93bjog MTU5MDIvLTIyNDMwICgtNjUyOCkNCg0KRGlkIHlvdSBkaXNhYmxlIENPTkZJR19YRU5fUFZI Vk1fR1VFU1QgaW4gdGhlIGJlZm9yZSBrZXJuZWwsIHRvbz8NCg0KPiANCj4+Pj4gU28gSSBk b24ndCBzZWUgYW55IHJlYXNvbiB0byB0YWtlIHlvdXIgcGF0Y2hlcywgd2hpY2ggY29uZmxp Y3Qgd2l0aCBtaW5lLA0KPj4+PiBlc3BlY2lhbGx5IGFzIG15IHBhdGNoZXMgaGF2ZSBhIG5l Z2F0aXZlIGRpZmZzdGF0IG9uIHNvdXJjZSBsZXZlbCwgdG9vLg0KPj4+DQo+Pj4gSG1tLCBK YXNvbidzIHBhdGNoZXMgbG9vayB0byBtb3ZlIHRoaW5ncyBpbnRvIGEgbW9yZSBhZGVxdWF0 ZSBkaXJlY3Rpb24sDQo+Pj4gdGhvdWdoLiBJbiB3aGljaCBjYXNlIEkgdGhpbmsgYSBuZWdh dGl2ZSBkaWZmc3RhdCBiZWNvbWVzIGFuIGlycmVsZXZhbnQNCj4+PiBhcmd1bWVudD8NCj4+ DQo+PiBEZXBlbmRzIG9uIHdoYXQgeW91IGFyZSBsb29raW5nIGZvci4NCj4+DQo+PiBNeSB0 YWtlIGZyb20gdGhpcyBpcyB0aGF0IGEgUFYtb25seSBrZXJuZWwgd2l0aCBKYXNvbidzIHBh dGNoZXMgaXMgbm90IHJlYWxseQ0KPj4gYWRkaW5nIGFueSB2YWx1ZSwgd2hpbGUgbXkgc2lt cGxpZmljYXRpb24gaXMgYXQgbGVhc3QgbWFraW5nIHRoaW5ncyBzaW1wbGVyDQo+PiBpbiB0 ZXJtcyBvZiBjb2RlIHZvbHVtZSBhbmQgbnVtYmVyIG9mIFhlbiByZWxhdGVkIGNvbmZpZyBv cHRpb25zLg0KPj4NCj4+IE9mIGNvdXJzZSBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byBoYXZl IGEgc21hbGxlciBQVi1vbmx5IGtlcm5lbCwgYnV0IGFzIEkgc2FpZA0KPj4gYWxyZWFkeSwg dGhlcmUgaGFzIGJlZW4gbm8gcHVibGljIGRlbWFuZCBmb3IgdGhhdCBpbiB0aGUgbGFzdCB5 ZWFycyBhbmQgdGhlDQo+PiBkb3duc2lkZXMgSU1ITyBmYXIgb3V0d2VpZ2ggdGhlIHBvdGVu dGlhbCBnYWluLg0KPj4NCj4+IElNTyB0aGUgImFkZXF1YXRlIGRpcmVjdGlvbiIgcmVnYXJk aW5nIFhlbiBzcGVjaWZpYyBrZXJuZWwgY29kZSBpcyB0b3dhcmRzIFBWSA0KPj4gYW5kIG5v dCB0b3dhcmRzIG1vcmUgUFYgc3BlY2lmaWMgdHdlYWtpbmcuIEFuZCBJJ20gdmVyeSBzdXJl IHRoZSBrZXJuZWwNCj4+IGNvbW11bml0eSBvdXRzaWRlIG9mIHRoZSBYZW4gY29tbXVuaXR5 IGlzIGFncmVlaW5nIHdpdGggbWUgaGVyZS4NCj4gSSBkb24ndCBuZWVkIFBWLW9ubHkga2Vy bmVscywgc28gSSBhbSBmaW5lIHdpdGggbm90IHB1cnN1aW5nIHRoaXMgcGF0Y2ggc2V0Lg0K PiANCj4gTWFpbmx5IEkgd2FudGVkIHRvIHBvc3QgdGhpcyBhbHRlcm5hdGl2ZSBzaW5jZSBy ZXN0b3JpbmcgUFYtb25seSBpcyBwb3NzaWJsZSANCj4gKGFuZCBJIGluYWR2ZXJ0ZW50bHkg YnJva2UgaXQpLsKgIENvbnZlcnRpbmcgQ09ORklHX1hFTl9QVkhWTSB0byBDT05GSUdfWEVO IA0KPiBsb29rZWQgd3Jvbmcgd2hlbiBpdCBkaWRuJ3QgYXBwbHkgdG8gUFYuDQo+IA0KPiBQ dXJzdWluZyB5b3VyIHBhdGNoZXMgZm9yIHRoZSByZWFzb25zIHlvdSBnaXZlIGFsc28gbWFr ZXMgc2Vuc2UuDQoNClRoYW5rcywNCg0KDQpKdWVyZ2VuDQo= --------------UgvAncgvKwTDoFqxTDog8p7a Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R3/CwO0EGAEIACAWIQSFEmdy6PYElKXQl/ew3p3W KL8TLwUCWt3w0AIbAgCBCRCw3p3WKL8TL3YgBBkWCAAdFiEEUy2wekH2OPMeOLge gFxhu0/YY74FAlrd8NAACgkQgFxhu0/YY75NiwD/fQf/RXpyv9ZX4n8UJrKDq422 bcwkujisT6jix2mOOwYBAKiip9+mAD6W5NPXdhk1XraECcIspcf2ff5kCAlG0DIN aTUH/RIwNWzXDG58yQoLdD/UPcFgi8GWtNUp0Fhc/GeBxGipXYnvuWxwS+Qs1Qay 7/Nbal/v4/eZZaWs8wl2VtrHTS96/IF6q2o0qMey0dq2AxnZbQIULiEndgR625EF RFg+IbO4ldSkB3trsF2ypYLij4ZObm2casLIP7iB8NKmQ5PndL8Y07TtiQ+Sb/wn g4GgV+BJoKdDWLPCAlCMilwbZ88Ijb+HF/aipc9hsqvW/hnXC2GajJSAY3Qs9Mib 4Hm91jzbAjmp7243pQ4bJMfYHemFFBRaoLC7ayqQjcsttN2ufINlqLFPZPR/i3IX kt+z4drzFUyEjLM1vVvIMjkUoJs=3D =3DeeAB -----END PGP PUBLIC KEY BLOCK----- --------------UgvAncgvKwTDoFqxTDog8p7a-- --------------tzV1pVdD3C6cGm0x2ChdpT1y-- --------------RBWR0lk1dgQ1uIbaPM46ZDwI Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmp0jMoFAwAAAAAACgkQsN6d1ii/Ey+w 0QgAgWFtwLXHbZiI2x6rwpaNKVn9HGdNEHtNajXZkomknhdnC4BlDSPqQtnqp0Sai0mrHWwfD4+I c/N5h+PLnRGs4QT2KvS5/XNu0AYdNkb7W+Aml2Ac/gLMXoMnn6p8XpvGydDJxKph7tWyBrZH556F YQCYOX8w+UjjZukEuw9riSvjdZliFdS7HU6jmBgkubbRTHTQBq1bDFGmC72/Tqo7yaDlivE0QJxe m7t0cIWPOAr/5TPzpjV+TxH7rAbJqznPpFPh8eZRzGWN6y1HrEC4QmMry7XjWdfK88z99SEA1/PA 2qYSKDk2aZYDR4tw0+nHEnxrZLB8hbLcmxIMWqdmwg== =odcF -----END PGP SIGNATURE----- --------------RBWR0lk1dgQ1uIbaPM46ZDwI-- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:48:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:48:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384780.1627565 (Exim 4.92) (envelope-from ) id 1wrySI-00070E-NT; Thu, 06 Aug 2026 13:48:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384780.1627565; Thu, 06 Aug 2026 13:48:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrySI-000707-Km; Thu, 06 Aug 2026 13:48:18 +0000 Received: by outflank-mailman (input) for mailman id 1384780; Thu, 06 Aug 2026 13:48:17 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrySG-0006ym-Va for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:48:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrySG-00875C-8C for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:48:16 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74907d-2eae-0a2a0a5409dd-0a2a4503e2e8-48 for ; Thu, 06 Aug 2026 15:48:16 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a74909f-fae8-0a2a45030019-b9ff1c238131-3 for ; Thu, 06 Aug 2026 15:48:15 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fd754d83e000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 06 Aug 2026 13:48:09 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 0609782116; Thu, 6 Aug 2026 15:48:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=WHDYfvmtJwvA3xxIRm+9ijAb7jiUxc5x/W+7GWYTxbk=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=FrPItnuDc6hnKwl+QsTrEyWkX4l7VoK76o9SOivGkvYO2Re9ClUFGZSOmFFBmG8TwKK3sPnp/ sReawACDZ5R330BFwOqwkcnANk7G8NAyimNdhFmaT0jwjfsC8QjPCBC9SddENaoXh0bRkHQBTPj CCk/i9jHhNi68QMpFHBMi/uF3u7zCqUQigVMwZQbmKgQSjmv6Tw0DuFIQPXbY1CZlEbqGRtcBGx m/PgS4GP1F1XI3FEabI2ca0lAuaTRx8KnnTpscS0I8D8OAWu2ygc92jCDinGUVxp96wfw35tQVl 1l1jK+hKf7qafEQZZn5bJ6LhvkO5I1R3cyhH8oiPNH4g== X-Zone-Loop: 34273c20037e853124b395c6f5f59e81331e7e35d82e x-campaign-type: default x-transaction-id: 3d320ad8-8c15-4596-afe2-33d0285e86f5 x-swg-uid: 01-ac6c1f46-bacf-4631-a6ac-d8f06165d54e X-Mailer: Sweego Message-ID: <1786024089.8631fc262581453bbf619ec5b2062170.19fd754d83e000e099@vates.tech> x-swg-bid: 1786024089.8631fc262581453bbf619ec5b2062170.19fd754d83e000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Thu, 6 Aug 2026 15:48:08 +0200 From: Anthony PERARD To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini Subject: Re: [PATCH 3/3] build: add compile_commands.json target References: <20260805015247.41943-1-gwd@xenproject.org> <20260805015247.41943-4-gwd@xenproject.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260805015247.41943-4-gwd@xenproject.org> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.1ddb.a4f82da285c3bf95.19fd754d655.e0a61ca139faa02a=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786024089174 X-purgate-ID: tlsNG-33051d/1786024096-6F2C84E9-58D5D385/0/0 X-purgate-type: clean X-purgate-size: 2439 ---=Part.1ddb.a4f82da285c3bf95.19fd754d655.e0a61ca139faa02a=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2026 at 11:52:40AM +1000, George Dunlap wrote: > Add a phony convenience target generating the compilation database "phony convenience target", that a funny way to put it :-) the target isn't phony, it just use the Make keyword "phony" to have it ignore the existing target=2E > from a built object tree, alongside the other developer conveniences > (tags, cscope, cloc -- the last of which already walks the same =2Ecmd > files): >=20 > make -C xen compile_commands=2Ejson >=20 > The output lands in the object tree root, where clangd and other > consumers discover it automatically when opening files from an > in-tree build=2E What about out-of-tree build? :-) that first part of the sentence almost seems to acknowledge their existence=2E Anyway, one can create a symlink=2E > Note the database records the compiler invocations actually used=2E > With a clang build it is consumable by clangd as-is; for a gcc build, > clang-based tools may need a small =2Eclangd configuration > (CompileFlags: Remove/Add) dropping gcc-only flags=2E >=20 > Also add the generated file to =2Egitignore=2E >=20 > Assisted-by: LLM > Signed-off-by: George Dunlap > --- > =2Egitignore | 1 + > xen/Makefile | 4 ++++ > 2 files changed, 5 insertions(+) >=20 > diff --git a/=2Egitignore b/=2Egitignore > index bfc7bdf043=2E=2E0aa9b801de 100644 > --- a/=2Egitignore > +++ b/=2Egitignore > @@ -192,6 +192,7 @@ xen/arch/*/include/generated > xen/build-dir-cppcheck/ > xen/common/config_data=2ES > xen/common/config=2Egz > +xen/compile_commands=2Ejson > xen/cppcheck-htmlreport/ > xen/cppcheck-report/ > xen/cppcheck-misra=2E* > diff --git a/xen/Makefile b/xen/Makefile > index d39bdfdd53=2E=2Ef87240f33c 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -685,6 +685,10 @@ cloc: > done; \ > done | cloc --list-file=3D- > =20 > +=2EPHONY: compile_commands=2Ejson > +compile_commands=2Ejson: Could you use FORCE instead =2EPHONY? That is just: +compile_commands=2Ejson: FORCE Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.1ddb.a4f82da285c3bf95.19fd754d655.e0a61ca139faa02a=--- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:54:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:54:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384804.1627576 (Exim 4.92) (envelope-from ) id 1wryY4-0000RS-Bs; Thu, 06 Aug 2026 13:54:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384804.1627576; Thu, 06 Aug 2026 13:54:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wryY4-0000RL-7K; Thu, 06 Aug 2026 13:54:16 +0000 Received: by outflank-mailman (input) for mailman id 1384804; Thu, 06 Aug 2026 13:54:15 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wryY3-0000RF-HW for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:54:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wryY2-00DByA-UF for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:54:14 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7491ea-5cb7-0a2a0a5109dd-0a2a450a894c-42 for ; Thu, 06 Aug 2026 15:54:14 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a749203-f2d2-0a2a450a0019-b9ff1c238685-3 for ; Thu, 06 Aug 2026 15:54:11 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fd75a4b75000e099.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 06 Aug 2026 13:54:06 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 3B939835D7; Thu, 6 Aug 2026 15:54:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=fRUrVE630RsEJS6ZLH/6Y7mCfFS4TvhyflfWwJQ0YOg=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=kLMgsXDIZTafA0fkFQjJNbTLoLEaf7fp1foPgZ9xOQUW7urHLmD5hT9jAETdnXeNBO5iuRLdJ P+sXO3AQLdDG/r5smJMoMoIPnqLHya4z9Ua7aR1D9JqHtXURYzAOO+mSU7OH9ixexUA4il63yhh J73maPUXHSUeNT6YTHnq0rMdPpFwP4vtLrpPs8ZNH1NAaaHv2JocbkcMV4q4NXNcPtf0jVHtCC2 fc6pPXleytR4Khjm2Fd3yDeyrkmFDQF0Xxwd/DrtPjXu6ptdomJ2WOjxll8ZvOhG5JUa7HEj9Qs jjAIdJ8dUacyCJAVZhiz9ktrGVjFxbidLZd6UbAkjQVg== X-Zone-Loop: d4caa2c739aea8cb86290f11f27ffc1973338f8f1048 x-campaign-type: default x-transaction-id: 56243759-dbbc-4dce-bb13-071b2c860a6b x-swg-uid: 01-1f5bf399-c575-4415-aa71-d7a76acc85b8 X-Mailer: Sweego Message-ID: <1786024446.8631fc262581453bbf619ec5b2062170.19fd75a4b75000e099@vates.tech> x-swg-bid: 1786024446.8631fc262581453bbf619ec5b2062170.19fd75a4b75000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Thu, 6 Aug 2026 15:54:06 +0200 From: Anthony PERARD To: George Dunlap Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH 0/3] Add compile_commands.json target References: <20260805015247.41943-1-gwd@xenproject.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260805015247.41943-1-gwd@xenproject.org> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.1de0.9fcff84f069bedcf.19fd75a4985.d81b5e994d9e9a15=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786024446342 X-purgate-ID: tlsNG-4011c0/1786024451-583CCCFC-A45D6261/0/0 X-purgate-type: clean X-purgate-size: 772 ---=Part.1de0.9fcff84f069bedcf.19fd75a4985.d81b5e994d9e9a15=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2026 at 11:52:37AM +1000, George Dunlap wrote: > Modern tools like emacs' `eglot` rely on compile_commands=2Ejson to > gather information about the project=2E Import the build script from Li= nux, > adapting it to the core Xen binary=2E Thanks=2E I've looked at using that script, but since it wasn't going to be useful for the tool side, I didn't do anything and just used `bear` instead=2E Cheers, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.1de0.9fcff84f069bedcf.19fd75a4985.d81b5e994d9e9a15=--- From xen-devel-bounces@lists.xenproject.org Thu Aug 06 13:58:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 13:58:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384813.1627584 (Exim 4.92) (envelope-from ) id 1wrycQ-0001ws-Qa; Thu, 06 Aug 2026 13:58:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384813.1627584; Thu, 06 Aug 2026 13:58:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrycQ-0001wl-Ni; Thu, 06 Aug 2026 13:58:46 +0000 Received: by outflank-mailman (input) for mailman id 1384813; Thu, 06 Aug 2026 13:58:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrycP-0001wf-90 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 13:58:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrycO-004Qcb-8j for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:58:44 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a749302-bab6-0a2a0a5309dd-0a2a450cd4ce-34 for ; Thu, 06 Aug 2026 15:58:43 +0200 Received: from [52.101.48.35] (helo=MW6PR02CU001.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a749310-f479-0a2a450c0019-346530230f97-3 for ; Thu, 06 Aug 2026 15:58:43 +0200 Received: from BN9PR03CA0424.namprd03.prod.outlook.com (2603:10b6:408:113::9) by SJ2PR12MB8881.namprd12.prod.outlook.com (2603:10b6:a03:546::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 13:58:35 +0000 Received: from BN3PEPF0000B076.namprd04.prod.outlook.com (2603:10b6:408:113:cafe::11) by BN9PR03CA0424.outlook.office365.com (2603:10b6:408:113::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.21 via Frontend Transport; Thu, 6 Aug 2026 13:58:35 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BN3PEPF0000B076.mail.protection.outlook.com (10.167.243.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 13:58:35 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 08:58:34 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 08:58:34 -0500 Received: from [172.19.79.34] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 08:58:33 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QNyqNc4cNXJqFGmKKpucAn7dxtzWQR8l6bC4Y3MPmh0hmf7bcYwKK667TyeY/j7z/ZdICMnkFKUFhpo6om4DDdiCZ0nHatHfzNVaD03tU5ZqEIlRY9JZWUX1zSLIIxZvPKvAkuFvu4LQpzkG62hy99hNu8m+FIB/a9VdCpuQwDBBgO2enaaU/HilQE6XkY06pzPEN0XUofCNIRVqLc7btYW3LKo+24LgUGl+YoTvT3m/MhVor4JlwqPG8tYag7M/xuH8p6bx4ioWxWI64ruYLkPnJ0TjDHP3QkxyTGQkv4xWnzbwD9VU4DU9dkA5sXnFolFtC6xGkIuzxqmZI819Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ps0ZJGdu/nNFySK1kD7HgjTQDo++3/DWtEi+//fDIvA=; b=y45vNvRTpJTLmAyxbxs1GOR64tC3WT1RCLBufVbf9Z2ZZJ5BkOaq95vfF5bztfDuuR1oqigzQ+R1vkA6HCORlsnv2rVSZ0MxgvROqJpaI/JY+veZa0E7TUgz3RIQJp55IjDynhHP4EqtGHtbwaY2w+5pQvUH42tArG1GrI0Q1wZoEBW8vFZLZYIMcPGDb3s3vuI+OE80H+IVVWg1O7tpl+K/QaH7zsHo+6XRyIZino2X7IiChn9hrqdPouBzfIe/prFMMqZTbaRi5vUtAGyEyEA2ff/u5DxPA04sDEZeE+SG0h0Tpoh3JLwy+Mp1WGYZe1HnTBROVwU4GgtpKY8zrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ps0ZJGdu/nNFySK1kD7HgjTQDo++3/DWtEi+//fDIvA=; b=Upl9+7iGl29zwCjUP5s0SPMrBRyKu4T/wFl8XgW6K+USwxpWSmQ91M19G6Nru8l6rsddT/KAVcJnFAHr9UYS3tNxgF+5/+J3GuWDOKDjJqLt8A93WjZ509l3MubTI8SrnNvY+0Bj1fG0eUCtylzSUKEZrsqY/bXkHN8NEKArrXA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Message-ID: <9f2588a1-b585-47dc-b825-993c31ab3fd6@amd.com> Date: Thu, 6 Aug 2026 09:58:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] xen: Fix PV-only build To: Juergen Gross , Jan Beulich CC: Andrew Cooper , , , "Stefano Stabellini" , Oleksandr Tyshchenko , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" References: <20260806015233.202486-1-jason.andryuk@amd.com> <083db883-558a-4000-b404-bf170c8309ee@suse.com> <62b5117f-928d-4908-9217-cc16d9cf15f9@suse.com> <967208c9-8d51-4380-8cb4-298f5c313d35@suse.com> <3206813c-33fc-476f-a553-4d3f319459aa@suse.com> Content-Language: en-US From: Jason Andryuk In-Reply-To: <3206813c-33fc-476f-a553-4d3f319459aa@suse.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B076:EE_|SJ2PR12MB8881:EE_ X-MS-Office365-Filtering-Correlation-Id: f3c6461b-1d28-43cc-22d0-08def3c2cebb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|36860700016|82310400026|376014|23010399003|1800799024|10067099003|56012099006|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 1CP4srme/UHBIZGwwigWh27iMkxSgnH8KnZR+Z6lRwdzyEmO3jDsL7g11H20DH0zJsmSrYWXu87oRXUtKsqf0dLK2KR4gMaxOCUyR59I6RiZKVfIcnaPouPCIfx+dVY5w+qyO2mNmpXKQ2UVJys+szvD82NptQxc05IhBzjErmRQqCUsU2zDe5yekVHNIu0S/QWpiPV/eOA0sZwC16Jb3RZ60EShNLZLsqCWcV+i3mhw5NBYkU/c9lKl5Xf6yAcovk4kughjseetQK7qNZC42xNLWr5rf1iPsmKYrMC2qGrpKEOZ9iOV7JzLJm7+/+OFlyDTa8+OeJfljZMdUzyhxVqo1is2D/sZC108QL1/zqqn/3b/zLPpf0nMXAsTB4khuGGh8TaE2zTdXlUO9hdrONtg+789oTPnXO67opkquXHqcI/HmUZ18Z94p4Ukmh1ivtGHope3p4qD8+8C/XxCHx4KkrPIuxDxumNpr/5IqWZ8afzjjuL0jm+BkF+nfVuhQXfOHA7HF99hHTkh6X9QqnPFmiTdhx4GkITiUTG6hIfkEJKr4BsNsI3RJNZ9rDB/JM7dicyuuEO6UGdPCGJFKrhFH92AiTKbbrFp3vH0SxsgnLbe2A6xmxxyC6vINFIftzGRFC0cIlXOaE7L59YoU5/94uRAb/xYi4AY5UHLp9Od+JMYTUK7JHasP+9AO3AQ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(36860700016)(82310400026)(376014)(23010399003)(1800799024)(10067099003)(56012099006)(11063799006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k1G1CMbkAWeDRKUcpL9U6a5ZkMlBqQ0lfIdWEzQs9SEm4hCMYmfZRAbhdBN5Pl8WilMkQ6vJKypVT69PSFkwm4Deex68hAFC2yALUMJ5HAZQdKZd5WrbSSUb1QsIrFeOMHcHbOKoGJoHAaRZ2oFdHf+8B20MzpP1Tl7EEP5VCxm5u1eNSQ62JfIQeSQaiRYIW5NAKAYZJ1rHFdgprnkNvVmoLI3g9QlKVtIRsjV2wfNKIeQB/+nevp+IuP51sIeJMA+UplboLDt4dytCv0vPoVLKhRraMEUXFegGXKT5yhs6KkqH6guTrjP99MdQUIfm7isrpITGGdolc+jdKHHMbrVB/lMkNUwUcuhjOcpOD8IgLHdZZs6ZZkF9hsT22EOvswAFal71mTlsZitArm6k7VfKBZsBkbGU46pvPVqUHG0KowWrKJJuH0+29JKLEuQS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 13:58:35.0349 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3c6461b-1d28-43cc-22d0-08def3c2cebb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B076.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8881 X-purgate-ID: tlsNG-d25034/1786024723-77ED2A5B-765E4CD0/0/0 X-purgate-type: clean X-purgate-size: 2175 On 2026-08-06 09:31, Juergen Gross wrote: > On 06.08.26 15:24, Jason Andryuk wrote: >> On 2026-08-06 08:00, Jürgen Groß wrote: >>> On 06.08.26 13:31, Jan Beulich wrote: >>>> On 06.08.2026 12:55, Juergen Gross wrote: >>>>> On 06.08.26 03:52, Jason Andryuk wrote: >>>>>> Allow disabling XEN_PVHVM for a PV-only.  A stub in the event channel >>>>>> code needs to be fixed first. >>>>>> >>>>>> Jason Andryuk (2): >>>>>>     xen/events: Fix xen_set_upcall_vector stub >>>>>>     xen/Kconfig: select XEN_PVHVM >>>>>> >>>>>>    arch/x86/xen/Kconfig             | 8 +++++--- >>>>>>    drivers/xen/events/events_base.c | 2 +- >>>>>>    2 files changed, 6 insertions(+), 4 deletions(-) >>>>>> >>>>> >>>>> I did a comparison of a kernel built with your patches disabling >>>>> XEN_PVHVM >>>>> and my patches with XEN_PVHVM_GUEST disabled. >>>>> >>>>> The kernel built with my patches is 6 bytes smaller than the one >>>>> with your >>>>> patches. >>>> >>>> Isn't this a sign of something else needing tweaking, somewhere? >>> >>> This is a sign that there are probably only very few really HVM >>> specific paths >>> (in the sense of: explicitly not marked as irrelevant for PV) in the >>> kernel. >>> Yes, I'm sure you can find some more, but I'm really not sure this is >>> relevant >>> for more than a handful of users. >> >> I see more reduction: >> 15029248 - arch/x86/boot/bzImage >> 15021056 - arch/x86/boot/bzImage.after >> >> ~8k >> >> 52542480 - vmlinux >> 52523184 - vmlinux.after >> >> ~18k >> >> $ ../linux/scripts/bloat-o-meter vmlinux vmlinux.after >> add/remove: 1/136 grow/shrink: 14/48 up/down: 15902/-22430 (-6528) > > Did you disable CONFIG_XEN_PVHVM_GUEST in the before kernel, too? Yes $ grep PVHVM config-before config-after config-pvh-before:CONFIG_XEN_PVHVM=y config-pvh-before:CONFIG_XEN_PVHVM_SMP=y config-pvh-before:# CONFIG_XEN_PVHVM_GUEST is not set config-pvh-after:# CONFIG_XEN_PVHVM_GUEST is not set These three options change: $ diff -u config-before config-after -CONFIG_XEN_PVHVM=y -CONFIG_XEN_PVHVM_SMP=y -CONFIG_XEN_AUTO_XLATE=y Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:09:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 14:09:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384826.1627592 (Exim 4.92) (envelope-from ) id 1wrymz-0004zs-PG; Thu, 06 Aug 2026 14:09:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384826.1627592; Thu, 06 Aug 2026 14:09:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrymz-0004zl-Lt; Thu, 06 Aug 2026 14:09:41 +0000 Received: by outflank-mailman (input) for mailman id 1384826; Thu, 06 Aug 2026 14:09:40 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrymy-0004zb-01 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 14:09:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrymx-0045I7-9h for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 16:09:39 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74959f-2eae-0a2a0a5409dd-0a2a4502ddec-10 for ; Thu, 06 Aug 2026 16:09:38 +0200 Received: from [52.101.43.6] (helo=SJ2PR03CU001.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7495a0-6ca4-0a2a45020019-34652b06de94-4 for ; Thu, 06 Aug 2026 16:09:38 +0200 Received: from SJ0PR03CA0045.namprd03.prod.outlook.com (2603:10b6:a03:33e::20) by CH3PR12MB7593.namprd12.prod.outlook.com (2603:10b6:610:141::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 14:09:25 +0000 Received: from CO1PEPF00012E63.namprd05.prod.outlook.com (2603:10b6:a03:33e:cafe::73) by SJ0PR03CA0045.outlook.office365.com (2603:10b6:a03:33e::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.20 via Frontend Transport; Thu, 6 Aug 2026 14:09:25 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by CO1PEPF00012E63.mail.protection.outlook.com (10.167.249.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 14:09:24 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 09:09:24 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 6 Aug 2026 09:09:24 -0500 Received: from [172.19.79.34] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 6 Aug 2026 09:09:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fhipckk14ODah3M+iu7gSTZr3+Ig0ZIvkTY0vt94EUexvA9iVdvc4/wU/XNd4P0T7F60KXOfz/fL7rLTGQgwMa7QrvF35TZELIYZAEC0UxPPH6+YlhQTX8B4/C/xcdZz4IEh4Ne+/A/3e5ecz7f1l29HV3tBcuWqufMsCDZ2G/+TbqJV+LJk6LYGvOSA18P3ZK48rqHu1xe3WjpbQcSsCSdDM3sp5ijhctazKv55bx9c3VlWweLMi0wFEUqrzdFDKDoyy7fbM6GtjGhJWCN9Uv3mG+L8lFsKnRJp45Ps/tVlLfJ5ReT26Mt8+DlzgdSvX7aBa/KhappmaRD+XCU+wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HTnl1ehLlzrWHapilZ0dYORgkBNrPt2rSXy3za9bZWQ=; b=xCmKOP8vnqehGKTrcRLz9Hzz+OpQ7iF2H4wCKHn1/9qS94l4osWOG0RqouEATG2EQmiARUNoCnYlJi627OhQFkW/C++XZbeDzFIyEsI78V+GpwQH5CEjZlVTna5s3yaQTYdi13HaSl3FBFeshEwSbn77DgUpKxfAi89xHzQbh3qaVglmSqdS8FfpWdcVxDH6cpZGuuLKS1Ztk7vRameYhm6a7GBxbF+ngxFikjs8xOLXALcfUdcpcLTHRJo+/vF7/a056zQRsww4PO2x5NXISaxWF0wrB6PGIgrEJIoX5URjQ81zDPf8IAl9zYjvVrdULYwRtzqWSvK0lnaIV/QtoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTnl1ehLlzrWHapilZ0dYORgkBNrPt2rSXy3za9bZWQ=; b=AXzJ2L9BESrjHHLc8H1jmMT5u7t324uyHtXMWrQmnE1Wg/0aPI7RM43CcJM/sF9eoldLyrqY5MESySZuFDhaudHrFIcMWieN5PoanMi5b1ctYaPMNIaNHbUH3oSaJW9HeN1FPFCq/QELhkA3tjJ/6PCIGWOtIr6d30Nay6FnUxo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Message-ID: <29546ca9-1875-4c20-b42b-39c886f3d41c@amd.com> Date: Thu, 6 Aug 2026 10:09:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/24] XSM: make Argo hooks well-formed ones To: Jan Beulich , "Daniel P. Smith" CC: "xen-devel@lists.xenproject.org" References: <758c8410-a18e-45dc-8944-5913e5832397@suse.com> <4bd4e7f7-e005-45b4-a543-98597a9de707@suse.com> <6991badc-dcc4-44b9-a048-29eb67c46d2e@apertussolutions.com> <7762513c-0d3a-465a-abd9-73e3ba586556@suse.com> Content-Language: en-US From: Jason Andryuk In-Reply-To: <7762513c-0d3a-465a-abd9-73e3ba586556@suse.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E63:EE_|CH3PR12MB7593:EE_ X-MS-Office365-Filtering-Correlation-Id: 9101fe5a-ffa0-47c3-15e9-08def3c45222 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|1800799024|23010399003|376014|82310400026|18002099003|22082099003|13003099007|6133799003|11063799006|56012099006|4143699003|10067099003; X-Microsoft-Antispam-Message-Info: hKBiHbgit6k4kFJ097hW7JSzVb3zwUdux7kATasSulqR6VowylzBdYQkrZp4huXes8ZdiStaJnfvwosrmJpnbbgq/cTaew1ECHht7i25Ihc3ieFUVKlD9UTLq9f2sWGj2LD10RTXNqujUmaZpJ7cIFitLB75rzB7cxWIhGZQ6SXlSWW72n2rKmYhoKB9HPskQ2vwGZxaf9j9dIugCtVJIS52LmIfhbH9gJ0omFSA8My/gYUZmA6GYc9eXRN8WNexqiHix7VFUODshdfuLqWA1bj6YN3seVKob6VjObKAIJqoPNWAFzWCHMVOJ9uU7aHbZfl8Bg5ik9ic92IwKnNysPhGxEyj2isU6+uzqgrWKRjkCYabDZmktYqZQFUdTwMSgBs4pv+DQnATIZf7pNvtweL+/me5MUUPR+RX/gv0/+PM5+AS6YDv6sQ42aXUDC2d+bDqQj5b6HX00SdX7CadTczIqUKFCwNmeB53egNQYfAtMsNeDQ/DuQIo/4nqtdUJDaiz3GMYdpuudb5q5W46vBDcL/+sHH/89OFIo3au8/ErewqawoFPz7ATHtap+nntVlk41QBkuPHgEMrOyexHzaQYbnI0dzAv2tVu/fXePJwzrrbYNL2cjacrzeS140KSmXi8UGcNY4EfeU9a2IP3yE6DaHS0xFjEO1oTmd3USO8cM/g2qTgzs4s/dO4m4uzMBT4xjrbPh6Ivs4dQpdO3og== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(1800799024)(23010399003)(376014)(82310400026)(18002099003)(22082099003)(13003099007)(6133799003)(11063799006)(56012099006)(4143699003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BpZliNvyeF/EbtP3QEncxDe//U4smaiwL6D0lijgMAA5V22EtZIsDmjn9p/z4AJx3qDolcLxoHD6h3DbzjZ0OyJo8hbsSoFQF+n9yPYjfQBJ9lnAAvThJt78sDF/OSOWquYUIzVt3Z3713nL6WvQ/aDcKQWH93hNvlQ2rAIBUK9SmeGdZolbZXircbo17L97bXcbeL0uOVWFSCndPOlku0nse5QKJul/B+wvKY/iNZQZteMEeyQpey160QGQHiivWalOOC5Py2G2Vx2HM83WjD0XiGzpbZaFgVH4PONB2AKFwutwA0P2GOS0JH4CHwXHvOpbiom+bO5rKvGoEIcJ/pQTwPtw8Pn2FQnY+NDJwDXQO76hgzZ+wbGTShL/km0PHcRWawiTuimUQlLn24GEn9MjOw5n4iRr9Mb+mnFYdwVVxXgbhp5UhI1tXcPc2USP X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 14:09:24.9445 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9101fe5a-ffa0-47c3-15e9-08def3c45222 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E63.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7593 X-purgate-ID: tlsNG-720697/1786025378-F38BC2AC-692CF31A/0/0 X-purgate-type: clean X-purgate-size: 2036 On 2026-08-06 03:16, Jan Beulich wrote: > On 06.08.2026 01:02, Daniel P. Smith wrote: >> On 7/28/26 9:22 AM, Jan Beulich wrote: >>> @@ -2307,7 +2308,7 @@ argo_init(struct domain *d) >>> { >>> struct argo_domain *argo; >>> >>> - if ( !opt_argo || xsm_argo_enable(d) ) >>> + if ( !opt_argo || xsm_argo_enable(XSM_HOOK, d) ) >> >> This question came up on another thread, so thought I might point it out >> that when FLASK is in use this can return a nubmer of error codes beyond >> an access deny. While I know it's the existing behavior, but if the >> error code is anything other than -EPERM, then it's not that the policy >> denied the access but something cause a fault in the security server. In >> that case the domain is still being allowed to construct with the >> assumption that it was a policy deny. At a minimum should the error code >> at least get reported, and perhaps it should be passed up to domain >> construction to allowing it to make an informed decision on construction? > > Sounds plausible, but definitely wants doing in a separate patch. I think this is a mis-use of xsm_argo_enable(). As I wrote in [1], this isn't an access decision, but an ~optimization to skip initializing argo data structures when a domain is not allowed to use argo. With Flask, this prints an AVC denial during domain construction when the domain doesn't have argo enabled. That is misleading as it isn't the domain's action causing the access. In OpenXT, I wrote a patch to add a noaudit variant to hide the denial. I didn't upstream it because I didn't really like it. The issue is really the conditional initialization of d->argo. It seems like it would be simpler to always initialized argo for all domains. xsm_argo_enable() would still prevent using it, but internal checking of d->argo could be removed. Regards, Jason [1] https://lore.kernel.org/xen-devel/758c8410-a18e-45dc-8944-5913e5832397@suse.com/T/#m149e1571b819a0cf481eea558c6220a5a24d5285 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:29:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 14:29:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384854.1627601 (Exim 4.92) (envelope-from ) id 1wrz5h-0001h5-GJ; Thu, 06 Aug 2026 14:29:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384854.1627601; Thu, 06 Aug 2026 14:29:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrz5h-0001gy-Cm; Thu, 06 Aug 2026 14:29:01 +0000 Received: by outflank-mailman (input) for mailman id 1384854; Thu, 06 Aug 2026 14:28:59 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrz5f-0001gs-6e for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 14:28:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrz5e-0010z3-8W for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 16:28:58 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a749a15-e002-0a2a0a5209dd-0a2a450baf20-34 for ; Thu, 06 Aug 2026 16:28:58 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a749a29-b7e8-0a2a450b0019-d1558034c551-3 for ; Thu, 06 Aug 2026 16:28:58 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4980dc26022so22404025e9.1 for ; Thu, 06 Aug 2026 07:28:58 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995420cb4esm66193295e9.2.2026.08.06.07.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 07:28:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786026537; x=1786631337; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dzaRPmaEHzQlkduFv0nG4HxLqJX6MeEmdM6T+7huPik=; b=DFDXbM9al6GvAxyc97QaUfXDdsy03XUaENB5pEkvO6BM0/2cbyfZJLQdKDNMj4sUFg nivnqICUE265WOUvlkL/Jbx3KDm4WgYC7sC/07S3/kXP6EsF2ODxap6mbDQc6abyn9eI N4Ujd2ncAusUhqS8aMOh1xeS2wsoChHEQsV80z2v6mRJt1/ykn2Cd87DLHE8+y4Bm4w2 kwy6W65dccgkNGKEQWwRho8e0DfeVRt+uqL6vISvGmCHytcuEJuKwJZabVMeE/vUOe3U O3T5v3eOCMt1TCTVajk3T2ip/Yy2yzalLyb/CMOg3TyG6YySIiPwTeCVCZkNSISY3kb1 E6sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786026537; x=1786631337; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dzaRPmaEHzQlkduFv0nG4HxLqJX6MeEmdM6T+7huPik=; b=WuPkYtDZFAO3tbocjREMXi5F6IUmdVuvPew0acE/I0O6R8DgnKZBzqv3A8yfchcZoh jy6dVt2ZQYsKhwhEmecnidHlTalQwmgLYYvdHLlrIVFY28JBFHftnET5MQfchh+L1zeT 46UQY8+zEHq+J1ab+B1LmsTHjj6iIrvTOAHA3YvZoXamPo/m+HgG/8pYBGEmsQjVBz+z wkFO8rLp1W0qSTy1BCAtvPQzW/Y9mClboFcmItNDZ6k0pvNVZMKiju82qeDI6Q36HUlw Uc6qYKEWnP3XzURY8GMh0mSWF8BQQh4iwzgF9JTXMmdokiol/aFVRuCdWlhNJFZw3Onc Afkg== X-Forwarded-Encrypted: i=1; AHgh+Rrw8SooQIS5okhP67Z/CzyCJ+PvwMumn2IjHsJXd4Jk+OiiaQAePD/E0icHty93T0kMRWxBd2Xs20I=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz+gl7DBvxNOF7jkhSNpUAIAWjDe0gRCFuozoh+nOXxOPwARQuT 21vAq0f5fqi10CgIarTwA+u7g0iW8ZkTdx668UMDJtfDAIIqSNWR3zpwrUf/w2sERA== X-Gm-Gg: AR+sD12iupUHXs2gsXDXU9MCY/AUy84EPpaJH5TMG4BIJFBk30DSQbq4tKUIgkNTRcy FwRI2Wbn/oV5VrOy2kLegcimQk3wGRERSuCil/2ARaqmggkz1dAr1JiAfdER1j1J8wvCpOYnX5A 20/x8dm1JgRaYNPrK/7FLvrJZsuT0JOHo3i5y5dmjGeW18rRFMQuUgis2nPThXS4suz+xu7YtGw bf8OzJz7c8s7WKHi+htczcOo/MiCQSFuS/uWahPDvI7/6uUjZ53N0kiimrYWXsDN0P5XbMBDU5v 251mzbNIH5tAK0l/+61xbAVK5G9ep4j5SIkcvWsJGR3cp6OQlOR1rORWsjGjig1zqLDZAnSsrpU a67iwbDZU6srUxHYcjUVJFYY/tMXtR+UBJ5rKbmoGZVE3Za2PiPt7NL0Qr2vaa1/IBld6CNS6hy txWxkMfV9wrP7nxDPdCYI6gHHflRPmGRTeMFIVWKORsV3kXEzdE/leLcCBIfpKeB6oUWOfe2qrM pAdtwbbaQdpDQUwGsYqcF5pPbbQDgxXZWudvN45TGT9DqbUr4Tx X-Received: by 2002:a05:600c:474f:b0:499:5210:c537 with SMTP id 5b1f17b1804b1-4995210c57fmr106068785e9.1.1786026537383; Thu, 06 Aug 2026 07:28:57 -0700 (PDT) Message-ID: <57793423-aadd-4786-90fd-2923925b766d@suse.com> Date: Thu, 6 Aug 2026 16:28:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 05/17] xen/riscv: implement virtual APLIC MMIO emulation To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <5571644f1d3a4277dc95fe85099563a145d1d935.1784560663.git.oleksii.kurochko@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5571644f1d3a4277dc95fe85099563a145d1d935.1784560663.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-42698a/1786026538-AB4D39EA-C2C9447D/10/73395122804 X-purgate-type: spam X-purgate-size: 14636 On 20.07.2026 18:02, Oleksii Kurochko wrote: > Guests running under Xen program interrupt routing by writing to APLIC > MMIO registers. Xen must intercept these accesses to enforce interrupt > isolation between domains and to translate guest routing intent into the > underlying physical MSI topology. > > Writes are gated by the domain's authorised interrupt bitmap so that a > guest cannot affect interrupts it does not own. TARGET register writes > additionally require translation of the hart and IMSIC guest-file > indices from virtual to physical, as the APLIC uses these fields > directly to compute the MSI delivery address. > > Delegation (APLIC_SOURCECFG_D) is not yet supported. > > Co-developed-by: Romain Caritey > Signed-off-by: Oleksii Kurochko > --- > Reviewed-by: Baptiste Le Duc # vaplic_mmio_{read,write} For this tag to have any meaning, it should move ahead of the --- above; the explanations ... > The downstream changes related to `vaplic_mmio_{read,write}` were originally > in a separate patch (which was reviewed by Baptiste). However, before > upstreaming, it was decided to merge them into the current patch. > I added `Reviewed-by: Baptiste` in this form for now, but Baptiste will > probably review the remaining changes as well. > Once that happens, I'll simply move the `Reviewed-by` tag up and > remove the `#`. ... here rather explain the restriction on the R-b, not its odd placement. > --- > Changes in v3: As this looks to be recurring - please get versioning of your series right. The series is supposedly v1, but here you give the impression of it being v3. If there really was an earlier v2 posting, why isn't the entire series here v3? > --- a/xen/arch/riscv/aplic-priv.h > +++ b/xen/arch/riscv/aplic-priv.h > @@ -48,4 +48,6 @@ struct aplic_priv { > */ > extern unsigned int guest_aplic_num_sources; > > +uint32_t aplic_msi_target_gen(const struct vcpu *target_vcpu, uint32_t base_val); PLease can you, before submitting, self-review your patches? I'm really getting tired of having to repeatedly point out basic style issues, like the overlong line here. > @@ -38,6 +39,60 @@ static struct intc_info __ro_after_init aplic_info = { > .hw_variant = INTC_APLIC, > }; > > +static unsigned long aplic_hart_field(unsigned long hartid) > +{ > + const struct imsic_config *imsic = imsic_get_config(); > + unsigned int lhxw = imsic->hart_index_bits; > + unsigned int hhxw = imsic->group_index_bits; It extends to the other local variables here, but I'll use these two to try to make my point: I'm struggling to associate the names with the values they are set to. Likely "hxw" is an abbreviation of hart index width, but (a) what's the leading 'l' then and (b) why is there no 'g' in "hhxw"? By using hard to grasp names, you make it hard to actually understand the subsequent expressions, in particular ... > + unsigned int hhxs = > + imsic->group_index_shift - APLIC_xMSICFGADDR_PPN_SHIFT * 2; > + unsigned long tppn = > + imsic->msi[hartid].base_addr >> APLIC_xMSICFGADDR_PPN_SHIFT; > + unsigned long group_index = > + (tppn >> APLIC_xMSICFGADDR_PPN_HHX_SHIFT(hhxs)) & > + APLIC_xMSICFGADDR_PPN_HHX_MASK(hhxw); > + > + return (group_index << lhxw) | hartid; ... these last two. As it stands, they may be easier to understand if you didn't have the local variables at all, despite them then getting textually longer. > +uint32_t aplic_msi_target_gen(const struct vcpu *target_vcpu, uint32_t base_val) Same issue as with the decl. > +{ > + unsigned int guest_id = vcpu_guest_file_id(target_vcpu); > + unsigned long hart_id = cpuid_to_hartid(target_vcpu->processor); > + unsigned long hart_field = aplic_hart_field(hart_id); > + > + base_val &= APLIC_TARGET_EIID_MASK; > + base_val |= MASK_INSR(guest_id, APLIC_TARGET_GUEST_IDX_MASK); > + base_val |= MASK_INSR(hart_field, APLIC_TARGET_HART_IDX_MASK); > + > + return base_val; > +} > + > +uint32_t aplic_hw_read_reg(unsigned int offset, uint32_t mask) > +{ > + unsigned long flags; > + uint32_t val; > + > + ASSERT((offset < aplic.size) && IS_ALIGNED(offset, sizeof(uint32_t))); > + > + spin_lock_irqsave(&aplic.lock, flags); > + val = readl((volatile void __iomem *)aplic.regs + offset) & mask; Wouldn't this applying of a mask better be done in those callers which actually need it? It's not the least the asymmetry with ... > + spin_unlock_irqrestore(&aplic.lock, flags); > + > + return val; > +} > + > +void aplic_hw_write_reg(unsigned int offset, uint32_t value) ... this which I consider unhelpful. > --- a/xen/arch/riscv/include/asm/aplic.h > +++ b/xen/arch/riscv/include/asm/aplic.h > @@ -28,6 +28,8 @@ > #define APLIC_DOMAINCFG_BE BIT(0, U) > > /* sourcecfg register fields */ > +#define APLIC_SOURCECFG_D BIT(10, U) As to the comment - this indeed looks to be a field, but ... > #define APLIC_SOURCECFG_SM_INACTIVE 0x0 > #define APLIC_SOURCECFG_SM_DETACH 0x1 > #define APLIC_SOURCECFG_SM_EDGE_RISE 0x4 ... these look to be values of some other field which isn't described. Please may I (again) ask that definitions are their commentary at the very least not misguide readers? > --- a/xen/arch/riscv/include/asm/imsic.h > +++ b/xen/arch/riscv/include/asm/imsic.h > @@ -40,6 +40,16 @@ struct imsic_config { > /* Base address */ > paddr_t base_addr; > > + /* > + * MSI Target Address Scheme > + * > + * XLEN-1 12 0 > + * | | | > + * ------------------------------------------------------------- > + * |xxxxxx|Group Index|xxxxxxxxxxx|HART Index|Guest Index| 0 | > + * ------------------------------------------------------------- > + */ And the xxx-es in here mean what exactly? Don't care? Some other, unrelated values? Yet something else? > --- a/xen/arch/riscv/vaplic.c > +++ b/xen/arch/riscv/vaplic.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > > #include "aplic-priv.h" > @@ -27,6 +28,256 @@ unsigned int __ro_after_init guest_aplic_num_sources; > > #define FDT_VAPLIC_INT_CELLS 2 > > +#define AUTH_IRQ_BIT(d, irqn) ( \ > + ((irqn) < (d)->arch.vintc->nr_virqs) && \ > + test_bit(irqn, (d)->arch.vintc->used_irqs) ) Nit: Indentation. > +/* > + * Convert a byte offset (within a SETIP/CLRIP/SETIE/CLRIE register group) to > + * a 32-bit word index into the allocated_irqs bitmap. Each word covers 32 > + * interrupt sources. For SOURCECFG and TARGET groups the same division also > + * yields the interrupt number directly, because those arrays store one 32-bit > + * register per source. > + */ > +#define regoffset_to_word_idx(reg_val) ((reg_val) / sizeof(uint32_t)) > + > +static inline uint32_t generate_auth_mask(const struct domain *d, > + unsigned int word_idx) > +{ > + unsigned int first_bit = word_idx * sizeof(uint32_t) * BITS_PER_BYTE; > + > + if ( word_idx >= DIV_ROUND_UP(d->arch.vintc->nr_virqs, > + sizeof(uint32_t) * BITS_PER_BYTE) ) > + { > + dprintk(XENLOG_DEBUG, "incorrect word_idx(%u) is passed\n", word_idx); Is this really meant to stay? > + return 0U; The U suffix is mainly (even if only slightly) obfuscating things, I think. > + } > + > + return (uint32_t)(d->arch.vintc->used_irqs[first_bit / BITS_PER_LONG] >> > + (first_bit % BITS_PER_LONG)); I don't quite understand the need for the cast. > +static int cf_check vaplic_emulate_load(const struct vcpu *v, Why the cf_check (also for the store counterpart)? > +static int cf_check vaplic_emulate_store(const struct vcpu *v, > + unsigned long addr, uint32_t value) > +{ > + int rc = -EINVAL; > + const struct domain *d = v->domain; > + unsigned int offset = addr & APLIC_REG_OFFSET_MASK; > + > + switch ( offset ) > + { > + case APLIC_SETIP_BASE ... APLIC_SETIP_LAST: > + case APLIC_CLRIP_BASE ... APLIC_CLRIP_LAST: > + case APLIC_SETIE_BASE ... APLIC_SETIE_LAST: > + case APLIC_CLRIE_BASE ... APLIC_CLRIE_LAST: > + { > + unsigned int word_idx = > + regoffset_to_word_idx(offset & APLIC_SETCLR_OFFSET_MASK); > + > + value &= generate_auth_mask(d, word_idx); > + > + break; > + } > + > + case APLIC_SOURCECFG_BASE ... APLIC_SOURCECFG_LAST: > + if ( value & APLIC_SOURCECFG_D ) > + { > + rc = -EOPNOTSUPP; > + > + dprintk(XENLOG_ERR, "APLIC_SOURCECFG_D isn't supported\n"); > + > + goto fail; > + } > + > + /* > + * As sourcecfg register starts from 1: > + * 0x0000 domaincfg > + * 0x0004 sourcecfg[1] > + * 0x0008 sourcecfg[2] > + * ... > + * 0x0FFC sourcecfg[1023] > + * It is necessary to calculate an interrupt number by subtracting > + * APLIC_DOMAINCFG instead of APLIC_SOURCECFG_BASE. > + */ > + if ( !AUTH_IRQ_BIT(d, regoffset_to_word_idx(offset - APLIC_DOMAINCFG)) ) > + /* Interrupt not enabled, ignore it */ > + return 0; > + > + if ( value > APLIC_SOURCECFG_SM_LEVEL_LOW ) > + { > + gdprintk(XENLOG_ERR, > + "value(%u) is incorrect for sourcecfg register\n", value); > + > + return 0; > + } > + > + break; > + > + case APLIC_TARGET_BASE ... APLIC_TARGET_LAST: > + { > + struct vcpu *target_vcpu = NULL; > + unsigned int hart_idx = value >> APLIC_TARGET_HART_IDX_SHIFT; > + > + /* > + * Look at vaplic_emulate_load() for explanation why > + * APLIC_GENMSI is subtracted. > + */ > + if ( !AUTH_IRQ_BIT(d, regoffset_to_word_idx(offset - APLIC_GENMSI)) ) > + /* Interrupt not enabled, ignore it */ > + return 0; > + > + if ( hart_idx < v->domain->max_vcpus ) You have d as a local variable. > + target_vcpu = v->domain->vcpu[hart_idx]; Use domain_vcpu()? > + if ( !target_vcpu ) > + { > + dprintk(XENLOG_ERR, "Invalid vCPU id in target register\n"); > + > + /* Ignore such writings */ > + return 0; > + } > + > + value = aplic_msi_target_gen(target_vcpu, value); > + > + break; > + } > + > + case APLIC_SETIPNUM: > + case APLIC_SETIPNUM_LE: > + case APLIC_CLRIPNUM: > + case APLIC_SETIENUM: > + case APLIC_CLRIENUM: > + if ( !value || !AUTH_IRQ_BIT(d, value) ) > + return 0; > + > + break; > + > + case APLIC_DOMAINCFG: > + { > + struct vaplic *vaplic = to_vaplic(v->domain); > + > + /* > + * The domaincfg register has this format: > + * bits 31:24 read-only 0x80 > + * bit 8 IE > + * bit 7 read-only 0 > + * bit 2 DM (WARL) > + * bit 0 BE (WARL) > + * > + * The most interesting bit for us is IE(Interrupt Enable) bit. > + * At the moment, at least, Linux doesn't use domaincfg.IE bit to > + * disable interrupts globally, but if one day someone will use it > + * then extra actions should be done. > + * > + * Only DM (bit 2) and IE (bit 8) are writable here. They are assigned > + * (not OR-ed) so that a write of 0 can also clear them (WARL), and the > + * read-only high byte (0x80) is always kept set on read-back. > + */ > + if ( value & ~(APLIC_DOMAINCFG_RO | APLIC_DOMAINCFG_DM | > + APLIC_DOMAINCFG_IE) ) > + printk_once("%s: Ignore writes to non-writable domaincfg bits as " > + "they are set by aplic during initialization in Xen\n", > + __func__); > + > + vaplic->regs.domaincfg = APLIC_DOMAINCFG_RO | > + (value & (APLIC_DOMAINCFG_DM | > + APLIC_DOMAINCFG_IE)); > + > + return 0; > + } > + > + default: > + goto fail; Instead of this goto, I think you simply want to move the label here. That'll also make the function more similar to its load counterpart. > @@ -105,6 +356,50 @@ static const struct vintc_init_ops __initconstrel init_ops = { > .make_domu_dt_node = vaplic_make_domu_dt_node, > }; > > +static enum io_state cf_check vaplic_mmio_read(struct vcpu *v, mmio_info_t *info, > + register_t *r) > +{ > + uint32_t data = 0; > + > + if ( info->len != sizeof(uint32_t) || > + !IS_ALIGNED(info->gpa, sizeof(uint32_t)) ) > + { > + gdprintk(XENLOG_DEBUG, > + "VAPLIC: unaligned/wrong-width read gpa=%"PRIpaddr" len=%u\n", > + info->gpa, info->len); You have v passed in here, but you'd log current. If passing in v is necessary (i.e. here or elsewhere it may be other than current), then you need to either ASSERT(v == current) at the top of the funciton or otherwise handle v != current correctly. > + return IO_ABORT; > + } > + > + if ( vaplic_emulate_load(v, info->gpa, &data) < 0 ) If all you care about is a boolean result, why not make the function return bool? > + return IO_ABORT; > + > + *r = data; > + return IO_HANDLED; Nit: Blank line please ahead of . > +static enum io_state cf_check vaplic_mmio_write(struct vcpu *v, mmio_info_t *info, > + register_t r) > +{ > + if ( info->len != sizeof(uint32_t) || > + !IS_ALIGNED(info->gpa, sizeof(uint32_t)) ) > + { > + gdprintk(XENLOG_DEBUG, > + "VAPLIC: unaligned/wrong-width write gpa=%"PRIpaddr" len=%u\n", > + info->gpa, info->len); > + return IO_ABORT; > + } > + > + if ( vaplic_emulate_store(v, info->gpa, r) < 0 ) Same here. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:43:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 14:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384867.1627611 (Exim 4.92) (envelope-from ) id 1wrzJV-0005cO-Kp; Thu, 06 Aug 2026 14:43:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384867.1627611; Thu, 06 Aug 2026 14:43:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrzJV-0005cH-I0; Thu, 06 Aug 2026 14:43:17 +0000 Received: by outflank-mailman (input) for mailman id 1384867; Thu, 06 Aug 2026 14:43:16 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrzJU-0005cB-P2 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 14:43:16 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrzJT-004AKZ-J6 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 16:43:15 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a749d72-bab6-0a2a0a5309dd-0a2a4506e8b2-28 for ; Thu, 06 Aug 2026 16:43:15 +0200 Received: from [209.85.222.173] (helo=mail-qk1-f173.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a749d82-195a-0a2a45060019-d155deade5ac-3 for ; Thu, 06 Aug 2026 16:43:15 +0200 Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-92ed3993c1eso122815385a.1 for ; Thu, 06 Aug 2026 07:43:15 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9088a219ea8sm35070376d6.37.2026.08.06.07.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 07:43:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786027394; x=1786632194; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mQCss4lFgE6Dwf1NizCh8ZHT2e94D2G9yvtYGo+Xll0=; b=aZTJbtITyY6Y9eLkwnxb/0uNSxHV9TlnK46I6nZZlacGx7iw6pF50IiTJ2AlvipjKg mTm/XJxazqQaxEmFgMxN0uQ4RV4fHtWHGNfvfPz3rVsjGJ3vrQKR3hMwU7ByG3JeGh7j Gm1BNYsT0IelzmgpWAGNuQvPQRej+6GY3ur3lz+Mf/E1A+DGgGE6O+gVoNiGZAPbeRPC VFEQUtOlMVO89hNXHa+1mtK7qI4pynvM1WU8o8cJpOabrDQ/8j5iIONM0fE2ToUpvScc /3VhdH881N0NvCdhmyr7VtaCLGvDE8Tu7rzHPXRyMZ0ErjVnRnxtnLmJNWRxgEt+QwX1 abvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786027394; x=1786632194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mQCss4lFgE6Dwf1NizCh8ZHT2e94D2G9yvtYGo+Xll0=; b=oK6s9JO0IOKa+xvGp8sSOGC6cwmGIHekoguGABCWFD3Dk6JC5l/RwHFagNSOhcKjDq 29abejOqKAIHtk2bSbGp9kvy53eSZalIp+PBcurvlD3a5JsxkVTiu2CDvD+94gB6a18g zz8Vhx88dKyWoFxomu5Lo6nsFVyJojSKmtS3sEKkfPRj7KDcFkk31jlkvrtzlRpOcX6l iY0tQ7LgpF4qJQzARjfxaI0W6vSbARHRGFwDA+SURlsEaR8ZuTQGo+Ckmr3eqP/jx03I o08BlXyOOq1210mn9Vn1Isjp2dL56vDztuI8VK3sZapTmVSj9/wCFyi76qYpXx704xp+ RkyA== X-Forwarded-Encrypted: i=1; AHgh+RrN4cePeeUnr2lLzt7++JGHkzr81cb2luWu7ZHUJjuHk1JBxSOptfpNP0y80CpcdYSmdBmbcy9+33E=@lists.xenproject.org X-Gm-Message-State: AOJu0YzWXZea0WTBQgYCyQnon6Fpx1yyQJxnysUJD9upH5ppH52fyHhg jqQbHudbI/oi6FfA0RADMJNHdw76lLSq0Q9vMAPefv6IdhqC150TwYgB X-Gm-Gg: AR+sD13ehG1dJqKT2D8czvE7C515ikDZT2fo2fnngX8e8mxkMklw7IT7JuAEqWfe0iq Net49qIfPQ4AafuIcekEQctuEmGfsMifi/zkHkcEtxQ14wPhhzwbT1RjtVMyVCwyyOkyTUr+vl5 DBYVOFueyyNXAscoh0/NKxu2VH3tKXCx2e3O9cA9KpvGjQ0YCJPRLfbrrFkP2fqF9COC7I/baLS WKLB2CyFv847wGqTvvdVPsvmFgJc5TjmdVmObaT+y2rjZ3oPuwcgiNpiR4Wd438DAREymGm5Jgk QwFk9Y/xd0HkW2Io/Sohor8pwQI44e2Gd95Z+/UKHNAEWjqonoJH9NtFvqriPfqycY3uS/fC/3p VhwC93DMQ/ja7LzZ9Hdd3f4KpCXEPV3TfSbwIeFuorU0osLNwEAFNIE9bhIkC0GEypY2HfQEZfY JYG2+RhaONi81BzdUfWUOvJvfvxgf9iIIkxqdYP2Zsi/rI8994/FQLDdFGd7zMsj32p0dB8gpsv xJyAED0HaI2IV85K+UlOSJ5H74h6l58R0cHL2iD3J8= X-Received: by 2002:ac8:5e08:0:b0:527:f0a:ccbc with SMTP id d75a77b69052e-52ce5fa28acmr159831981cf.18.1786027393869; Thu, 06 Aug 2026 07:43:13 -0700 (PDT) From: Yifei Gao To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , v9fs@lists.linux.dev Cc: Christian Schoenebeck , Juergen Gross , Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yifei Gao Subject: [PATCH v2] 9p/xen: fix refcount leak in p9_xen_response() on wrong tag Date: Thu, 6 Aug 2026 14:42:54 +0000 Message-ID: <20260806144255.4167019-1-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804213550.3409638-1-gyf161023@gmail.com> References: <20260804213550.3409638-1-gyf161023@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1786027395-FE27077B-8C9B03B3/0/0 X-purgate-type: clean X-purgate-size: 1515 p9_xen_response() looks up the request for an incoming reply with p9_tag_lookup(), which takes a reference on the returned p9_req_t. When the tag does not resolve to a request in REQ_STATUS_SENT, the function warns and continues the loop without dropping that reference, permanently leaking the p9_req_t and its msize buffers. The reply header, including the tag, is supplied by the backend, so a malicious or buggy 9P backend can leak kernel memory on every crafted response. Drop the reference before continuing. Fixes: 728356dedeff ("9p: Add refcount to p9_req_t") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Yifei Gao Reviewed-by: Stefano Stabellini --- v2: - Fix Fixes: tag to reference the correct commit (728356dedeff). - Drop the inaccurate trans_fd.c comparison from the changelog. - Add Reviewed-by from Stefano. net/9p/trans_xen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index f9fb2db7a066..8eea0da8797f 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c @@ -203,6 +203,8 @@ static void p9_xen_response(struct work_struct *work) req = p9_tag_lookup(priv->client, h.tag); if (!req || req->status != REQ_STATUS_SENT) { dev_warn(&priv->dev->dev, "Wrong req tag=%x\n", h.tag); + if (req) + p9_req_put(priv->client, req); cons += h.size; virt_mb(); ring->intf->in_cons = cons; -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:48:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 14:48:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384886.1627619 (Exim 4.92) (envelope-from ) id 1wrzOD-00077P-5L; Thu, 06 Aug 2026 14:48:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384886.1627619; Thu, 06 Aug 2026 14:48:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrzOD-00077I-2G; Thu, 06 Aug 2026 14:48:09 +0000 Received: by outflank-mailman (input) for mailman id 1384886; Thu, 06 Aug 2026 14:48:08 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wrzOB-00077C-RX for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 14:48:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrzOB-004XwN-1c for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 16:48:07 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a749ea0-e002-0a2a0a5209dd-0a2a45029324-6 for ; Thu, 06 Aug 2026 16:48:03 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a749ea3-6ca4-0a2a45020019-d1558035e41a-3 for ; Thu, 06 Aug 2026 16:48:03 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso17093035e9.0 for ; Thu, 06 Aug 2026 07:48:03 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995422b741sm73799625e9.14.2026.08.06.07.48.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 07:48:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786027683; x=1786632483; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yeruhxuIPamUdYkWP7spwzBqzWKRPoiRPaCXYfXcQp4=; b=dou3MvI95s38manyguIPx5CCo8HLb1khLoieNt7hO81g/hqEDn2NVvc1pUKXF28RsM lxHNvl12EsZUKBQ2z6Jg3zJpQrbkG3r+wxVy0BuXAkzTgM7sTgcOZ7Cmsyv5w0E7RCYy kwuTPudOCY14pmuoXg4tRMUFb9Vypiv1Q2lhVX2uSl+BC81BHQF4p0HDtpW4meJPBNB2 9zdkRkxChi60itToUt+Nm+KFCbrY0LFFtNl8SwaLU+onWRvWFXwZcPL9ytKkrENhhc1a qTqVNCoVo/as2OLIRGSmTkGRZkyy/gU6WtB34OIeolYuHhOYlVjl4cBsJaUdc5X6af8a qY3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786027683; x=1786632483; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yeruhxuIPamUdYkWP7spwzBqzWKRPoiRPaCXYfXcQp4=; b=O1HOhLlnle8u2bfsYCVWBNnrybn3A/y+1tWh4zvog1v42NLAcUFkm5Mi/t9cWM+YNY 1xHN2l4hCANmFwOeHMfcMt9UYYLgD5ZIelwzeguMuyPpcL0q3QdO5i8x4iLAt22sFa42 XNTeb5M3PgC3DjWYcwEu7mMEPe2++yqsf6OfvkJwRhBtnqEBzfZom0HFSnUSQsEQiEy5 9GVEy+FgTi7wQkpEwfoVgCKFKsHXDs3IkZtTUEtTrmm8yPgtC0pweZtScCoUhJYexR0X v5rYgO9FTW2FCaWdcwXfpbS2NZyEiY59XGvH+XjPKCg9HoLj71igDjzbxIEG5CyzNID5 Obpg== X-Forwarded-Encrypted: i=1; AHgh+RrqQ4azrhovjs1hvnKvCRlMHiJMvUIY/oh8QgllwkU7Qdaga4fVon4/nt9pJ/nAdxunOncVtBgVRyI=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw8skxZG+9bwKkthBV9ElagHg2nGW4QWdUG7akV5yjOYUiCNDRc O5jaZm6oohixLrNHPOKyIDB3qm2YeLlBshot75/pNBIfVvwPRBr0OdOTfCPcNaUBog== X-Gm-Gg: AR+sD12yQcK0l2bcglV5IJ1Ku9nKw4KBZ3NytuMwjmmA7u7PCYawmKWAEyPU+Tw00+f hJTIxJz0zJrY8gCz+UPBU9n4GmVPo6XTDXdsc6aIiY8p7eNdLlAWfktfDnXpooIE83enNJIneRR //ATvRP7NpXd/gvRC5pam4bqqFvWY/JmqXITTEx0hWAwc/L5OBdXage8WfAvplIrogm5qlkYy1u h7Eq+ISpRVt9YAG1fpUodVo4NnBYPKVJ8MEIa0P9pk8XP4dD0+NPJn1tGQF4dBNK4LDztbKX0su Ac8HPjXKaolYUiyHj3LU0lF9XHSDqRFSfXG4Hcgcs/z+REdkDhTiet2doUlZzRjugMz3z4OLyhD aalcGKz+AydIfK9ySeLQTrkRPu6IhwVLryUJwafFvY74zxejqMI1UyXhSL73foNomuTQ2WNudtV jyIpCEqbXEiiQsM6j8abcbaRlGK+EQWjn005/qh9vDnDWSEcZTt5ntDFsnUNC9ex8e/f+4m7sTt Braur25KSNGUfN25QsyGC1K2VCIv+FEQGEWpvsgILAfysIl9fxN X-Received: by 2002:a05:600c:529b:b0:493:a613:56b2 with SMTP id 5b1f17b1804b1-4994e71d3e5mr224238625e9.8.1786027682662; Thu, 06 Aug 2026 07:48:02 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 16:48:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/17] xen/riscv: map IMSIC interrupt file for vCPUs To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <254f470ae2e2b2a4affa7c405be8c07a7d8b300e.1784560663.git.oleksii.kurochko@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <254f470ae2e2b2a4affa7c405be8c07a7d8b300e.1784560663.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-720697/1786027683-307C22AC-0DD0A8B4/10/73395122804 X-purgate-type: spam X-purgate-size: 4328 On 20.07.2026 18:02, Oleksii Kurochko wrote: > A guest running in VS-mode expects its own IMSIC S-file at offset 0 of its > guest-physical IMSIC block. Physically, the guest-file (G-file) assigned to > this vCPU lives at a hart-relative offset given by guest_file_id (assigned > via the vGEIN allocator). Therefore, imsic_map_guest_file() uses stage-2 > translation to redirect the guest's fixed per-vCPU GPA page (offset 0) to > the specific physical guest-file page. > > Signed-off-by: Oleksii Kurochko > --- > The corresponding unmap of the IMSIC interrupt file will be introduced > separately when the need arises. Doesn't the need exist right away? There is ... > @@ -342,6 +344,67 @@ static int __init imsic_parse_node(const struct dt_device_node *node, > return 0; > } > > +/* > + * Map the physical IMSIC guest interrupt file (G-file) assigned to vCPU v > + * into the domain's stage-2 guest-physical address space. > + * > + * In the machine's physical address space (SPA), each hart's IMSIC > + * supervisor-level file (S-file) is located at offset 0 of its address block, > + * followed contiguously by GEILEN guest files at offsets of 1, 2, ..., N pages. > + * > + * Because a guest OS running in VS-mode expects its own supervisor-level > + * interrupt file to be at offset 0 of its guest-physical IMSIC block, the > + * hypervisor must use stage-2 address translation to map the vCPU's > + * guest-physical "supervisor" page (GPA offset 0) to the specific > + * physical guest file page (SPA offset guest_file_id) on the physical hart. > + * > + * Xen pins each vCPU to a pCPU (v->processor) and assigns it a physical ... an apparently wrong assumption here: Xen doesn't normally pin vCPU-s. When a vCPU migrates between pCPU-s, clearly the mapping referencing the page associated with the old hart needs tearing down again. That said, since the new mapping will appear at the same GFN, the original mapping may simply end up being replaced. If such direct replacement is legitimate to do, maybe this could actually be mentioned here? > + * guest file index (guest_file_id) from the vGEIN allocator. A guest_file_id > + * of 0 indicates that no hardware guest file is selected (matching the > + * architectural behavior where vGEIN = 0 in the hstatus CSR selects no > + * guest external interrupt source), requiring the VS-file to be emulated > + * in software. > + * > + * The base guest-physical address advertised to the guest in the device > + * tree matches offset 0 of the vCPU's virtual IMSIC block. Stage-2 > + * translation ensures that guest supervisor accesses to this page are > + * transparently routed to the real hardware VS-file granted to it on > + * the current pCPU. > + */ > +int imsic_map_guest_file(struct vcpu *v, unsigned int vsfile_id) > +{ > + int res = 0; > + struct domain *d = v->domain; > + unsigned int cpu = v->processor; > + vaddr_t gaddr = imsic_cfg.base_addr + (IMSIC_MMIO_PAGE_SZ * v->vcpu_id); > + paddr_t paddr; > + unsigned long guest_stride; > + > + /* Nothing to map in the case of sw interrupt file. */ > + if ( !vsfile_id ) > + return res; > + > + guest_stride = vsfile_id * IMSIC_MMIO_PAGE_SZ; To me "stride" feels the wrong term here, as there's nothing that repeats. "offset" likely would be better, assuming the use of this local variable is really deemed worth it, as it's used ... > + paddr = imsic_cfg.msi[cpu].base_addr + imsic_cfg.msi[cpu].offset + > + guest_stride; ... only here. > +#ifdef IMSIC_DEBUG > + printk("%s: %pv: ga(%#lx) -> pa(%#lx), cpu(%#x), guest_file_id(%d) " > + "base_addr(%#lx) offset(%#lx)\n", __func__, v, gaddr, paddr, cpu, > + vsfile_id, imsic_cfg.msi[cpu].base_addr, imsic_cfg.msi[cpu].offset); > +#endif > + > + res = map_regions_p2mt(d, gaddr_to_gfn(gaddr), > + PFN_DOWN(IMSIC_MMIO_PAGE_SZ), maddr_to_mfn(paddr), > + arch_dt_passthrough_p2m_type()); > + if ( res ) > + printk("%s: Failed to map %#lx to the guest at %#lx\n", > + __func__, paddr, gaddr); I think you mean to use PRIpaddr with paddr_t (oddly enough there's no PRIgaddr). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 14:56:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 14:56:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384898.1627629 (Exim 4.92) (envelope-from ) id 1wrzWb-0000fS-2G; Thu, 06 Aug 2026 14:56:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384898.1627629; Thu, 06 Aug 2026 14:56:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrzWa-0000fL-Up; Thu, 06 Aug 2026 14:56:48 +0000 Received: by outflank-mailman (input) for mailman id 1384898; Thu, 06 Aug 2026 14:56:47 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wrzWZ-0000fF-Ou for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 14:56:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wrzWZ-004CAw-5Y for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 16:56:47 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74a09e-5cb7-0a2a0a5109dd-0a2a4501df4a-32 for ; Thu, 06 Aug 2026 16:56:47 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a74a0ae-5984-0a2a45010019-d1558030e075-3 for ; Thu, 06 Aug 2026 16:56:47 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4956242332dso18106905e9.2 for ; Thu, 06 Aug 2026 07:56:47 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49954206d72sm100063155e9.1.2026.08.06.07.56.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 07:56:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786028206; x=1786633006; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pMXs6HRqpuYzHBhbiGaH5JuzeeH9ysfL+n/X4NDredY=; b=AIF5yAQ3fReRo96L/XGDOpQjmUEbWK5rY8eu3+BCbra8lFDmMT7bpGHuB+Se8pvxBc IyT/fSihpd/C2Tp8xtynMx152QYkJHmBF3kWF0UhQoZl2dQnlwNglplZgbvNLjJCifXX vDdxNQfX/luMGaCSwoepBadlHFXsU68mstnAMPFNkQ5FhWnlmtgYLYv4jtauttyERd56 mkbKTVaQsHE44lTyeXm+9M2vMM5Rs/Zq8vNYy2z11v+73o7XyA0pBW8sV1OfpVVZlrzL 0VI1TaaJOMy1bVxdzZkgDGEPKo6q414j2G9ja0vt7/b2lMGpw4Ld6w0JntwXLOExUYxO xDNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786028206; x=1786633006; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pMXs6HRqpuYzHBhbiGaH5JuzeeH9ysfL+n/X4NDredY=; b=SOPX7IssFeNmx69kCIj7q72FTmejQo1Ctr09CU4GKdYZTMEfuR0J6VX62x5oKbosa1 BDHC9lq0+1XIM3RVx8cNE9Vu1WvBJdlvOF+sEW3a1xYvyT6WuOLM8ENrcwuMdFYtNZcW R6ux5hZo/cIF6veMHlafTxyIl7WNjh3YzuOozRxhP1QEt+Uk9ZasU/8qJg9EpuCqxFnv GkPA/Wzuv6aTmOHRAEgu4kH3bABGgq0Uo2XA64uqJfEiUNirSJkHhVLwgIxs5rCiFuLY vE/EwOutoIn9xWuKQVF+cq517lBUV/tHcJitp2foodlpW8Rz+12ZdMfplUnzvSm8YihF VQHg== X-Forwarded-Encrypted: i=1; AHgh+RrOziqSp3CcH1f/qxP/vbOshbZHAepvgY5m49o9tlCVi5h+xyw1D4YP9E0LFFp29YUCLc4wsEw2JmU=@lists.xenproject.org X-Gm-Message-State: AOJu0YxVdxnvoLnaIWWW8xrJkdBz3WwUMlsxkg4GVCdb+RIHmVBo+lTx /S2diz4CB+LEUKMR78FAYzp/zacQ/pb3F3ob8USGln2ezSJGXAUcpzgejA9I9xMDAQ== X-Gm-Gg: AR+sD121w6ZnScminG6oo4o2p0D7vTBl3gv9GJSS9HTl0C2v3mJ+MvUDvolZElZr9wX ttjX3zXK+SigkpaItkA6UjHgqsVDvmArBTQBNWn7S/ifEd/kZ0YL2LfwUYNeBKyVcKgHCmgUwnu D0SprppXylNN8RPouVRSpWIMqY/3mmCPtzmlpqIuXF4DJ2hoTU5zjbN8mIXVwvrD613t4SjHuV0 oKW1hj+Q67ZzV7JieJCt+I9dyBLuN9Nzqe3rTCxuOAVy9+LczL5rz44UMvzDVjuXUIJEdc9ud6/ 0E7YIlt+lD9hinEGdL2Jeg4EsVM7gRCYpyk50OKGcdZiBLPdd3F2W0Q9YB15sbgrbvcWz9Lfx77 4dR4iTxBSO/i2r+Zl/ODRE/fzpV0A0YF7j0C6Nlcn3IUEFbnnEU56XvYxD024kqIu/oMVMlZI6t 1G/KQDor8cXPDe/aN4XCcVz0tlzV12G0pE7T4fjs4YyPXyXw0ImP2UghXhG2ubZCGVmwDX8KrBT bAMy8Y+YRjsdg1oUsToC8G32W2YSbjeCGiBuJdtNKbmBNtjkcL1 X-Received: by 2002:a05:600c:1992:b0:496:c378:6420 with SMTP id 5b1f17b1804b1-4994e71a1c9mr188832845e9.8.1786028206534; Thu, 06 Aug 2026 07:56:46 -0700 (PDT) Message-ID: Date: Thu, 6 Aug 2026 16:56:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/17] xen/riscv: introduce vCPU AIA initialization To: Oleksii Kurochko Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1786028207-BD146757-FB7EF3BC/0/0 X-purgate-type: clean X-purgate-size: 3096 On 20.07.2026 18:02, Oleksii Kurochko wrote: > Introduce vcpu_aia_init() to initialize the AIA-related state needed > for a vCPU to have a working guest interrupt file. > > A guest (VS) interrupt file must be mapped to one of a pCPU's > hardware interrupt files (if they exist), so the pCPU a vCPU will actually > run on needs to be known first. arch_vcpu_create() is therefore not a > suitable place to call vcpu_aia_init(), since the pCPU assigned to a > vCPU can still change before it is first scheduled. To avoid > reassigning the VS interrupt file id and remapping it to a different > pCPU's hardware interrupt file, vcpu_aia_init() will instead be > called from a later point in the scheduling path (e.g. > continue_to_new_vcpu()), to be introduced in a follow-up patch. Since > it will end up being called from a non-__init context, it is not > itself marked __init. If it's called during scheduling, perhaps vcpu_aia_init() simply isn't an appropriate name, and that issue is then also reflected in a misleading patch subject? > @@ -36,6 +37,35 @@ bool aia_usable(void) > return _aia_usable; > } > > +void vcpu_aia_init(struct vcpu *v) > +{ > + unsigned int new_vsfile_id; > + int rc; > + > + if ( !aia_usable() ) > + return; > + > + new_vsfile_id = vgein_assign(v); > + > + /* > + * vgein_assign() returns 0 when no free h/w guest interrupt file is > + * available (including GEILEN == 0); imsic_map_guest_file() maps nothing > + * in that case. > + */ > + rc = imsic_map_guest_file(v, new_vsfile_id); > + if ( rc ) > + { > + /* Can't continue w/o correctly mapped IMSIC interrupt file */ > + domain_crash(v->domain); > + return; > + } > + > + vcpu_guest_cpu_user_regs(v)->hstatus |= > + MASK_INSR(new_vsfile_id, HSTATUS_VGEIN); Looks like you're assuming that no other ID was previously stored in that field. That can't be quite right when the function is called after the vCPU moved to a different pCPU. > --- a/xen/arch/riscv/imsic.c > +++ b/xen/arch/riscv/imsic.c > @@ -83,6 +83,19 @@ unsigned int vcpu_guest_file_id(const struct vcpu *v) > return ACCESS_ONCE(v->arch.vimsic_state->guest_file_id); > } > > +void imsic_update_state(struct vcpu *v, unsigned int guest_file_id) > +{ > + unsigned long flags; > + struct vimsic_state *vimsic_state = v->arch.vimsic_state; > + unsigned long pcpu = ( !guest_file_id ) ? > + NR_CPUS : cpuid_to_hartid(v->processor); "pcpu" as a name is misleading when what you store is a hart ID. NR_CPUS then also isn't a suitable sentinel. Also, style nit: The parentheses aren't really needed around the conditional. But what's definitely wrong are the blanks immediately inside them. > + write_lock_irqsave(&vimsic_state->vsfile_lock, flags); > + vimsic_state->guest_file_id = guest_file_id; > + vimsic_state->vsfile_pcpu = pcpu; By implication from the remark above, the field name stored into then also is misnamed. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 06 15:49:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 15:49:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384954.1627646 (Exim 4.92) (envelope-from ) id 1ws0LY-0004t2-Vq; Thu, 06 Aug 2026 15:49:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384954.1627646; Thu, 06 Aug 2026 15:49:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws0LY-0004ss-TF; Thu, 06 Aug 2026 15:49:28 +0000 Received: by outflank-mailman (input) for mailman id 1384954; Thu, 06 Aug 2026 15:49:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws0LX-0004sV-Pv for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:49:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1ws0LX-00834N-1a; Thu, 06 Aug 2026 15:49:27 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ws0LW-009qdZ-2z; Thu, 06 Aug 2026 15:49:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=4D0z06vjOYg9blHCRUsB77y4tATWODBBrawlmczEE3k=; b=1FpGpzkxrMGxAJSJ6Ab7WQRMjd SFsrpewCbERnt7CjwpKqp4f2Wq8cXbDeMLDvxEUV+HGSVDzrhWRsgoUe1Eg+wqrLYzdWaTWwBnSHj YHYBpLyrI5rf8h38BaHm7Fu3MORoI+ikSlF0XUrKdCsNYDTXB8lfSyDfetTtrFTy8HWo=; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Teddy Astie Subject: [PATCH v2 1/2] x86/pci: prevent cross-device accesses in pci_mmcfg_{read,write}() Date: Thu, 6 Aug 2026 17:26:18 +0200 Message-ID: <20260806152619.23881-2-roger@xenproject.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260806152619.23881-1-roger@xenproject.org> References: <20260806152619.23881-1-roger@xenproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Introduce a specific check that prevents an accesses from spilling across two devices. Signed-off-by: Roger Pau Monné --- Changes since v1: - New in this version. --- xen/arch/x86/x86_64/mmconfig_64.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/x86_64/mmconfig_64.c b/xen/arch/x86/x86_64/mmconfig_64.c index 940cf6d7471b..91b1a398e646 100644 --- a/xen/arch/x86/x86_64/mmconfig_64.c +++ b/xen/arch/x86/x86_64/mmconfig_64.c @@ -61,7 +61,8 @@ int pci_mmcfg_read(unsigned int seg, unsigned int bus, char __iomem *addr; /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ - if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) { + if (unlikely((bus > 255) || (devfn > 255) || + (reg + len > PCI_CFG_SPACE_EXP_SIZE))) { err: *value = -1; return -EINVAL; } @@ -91,7 +92,8 @@ int pci_mmcfg_write(unsigned int seg, unsigned int bus, char __iomem *addr; /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ - if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) + if (unlikely((bus > 255) || (devfn > 255) || + (reg + len > PCI_CFG_SPACE_EXP_SIZE))) return -EINVAL; addr = pci_dev_base(seg, bus, devfn); -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 15:49:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 15:49:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384955.1627656 (Exim 4.92) (envelope-from ) id 1ws0Le-000588-98; Thu, 06 Aug 2026 15:49:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384955.1627656; Thu, 06 Aug 2026 15:49:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws0Le-000580-4X; Thu, 06 Aug 2026 15:49:34 +0000 Received: by outflank-mailman (input) for mailman id 1384955; Thu, 06 Aug 2026 15:49:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws0Lc-000579-S3 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:49:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1ws0Lc-00834V-28; Thu, 06 Aug 2026 15:49:32 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ws0Lc-009r6I-0L; Thu, 06 Aug 2026 15:49:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=v8h1wppUhC/u/nkKEBQJ22KAaFfqUX8DZenk5l0qwSs=; b=E3djs5jXPwiXuhHLhTg9/Zkj/V BUEnWf+1Uz1xhEse4IKMmlZxHISKW5NFHqUzbijq8DDScnvR9y0sEWsKLv8kojb/QLURb9HkRHnSy rnEfu87ivdlfZDUnuXA9O+B1qTT17bpzIEnCU0sJrQuMFPphb0CdfikQg+O24mSr+w2s=; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Anthony PERARD , Jan Beulich , Andrew Cooper , Teddy Astie , Stewart Hildebrand , Jason Andryuk Subject: [PATCH v2 2/2] xen/vpci: allow unaligned accesses by the hardware domain Date: Thu, 6 Aug 2026 17:26:19 +0200 Message-ID: <20260806152619.23881-3-roger@xenproject.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260806152619.23881-1-roger@xenproject.org> References: <20260806152619.23881-1-roger@xenproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's possible for domains to generate unaligned PCI config space accesses when using ECAM, and hence vPCI should support those at least for the hardware domain. Such unaligned accesses to the PCI config space have been reported to come from ACPI logic. Relax the checking in vpci_access_allowed() to allow such accesses for the hardware domain, and fix the handling in pci_conf_{read,write}{16,32}() to fulfill them using MMCFG. MMCFG regions are identity exposed to the hardware domain, and hence such unaligned accesses can only come as a result of the host having MMCFG in the first place, as otherwise MMCFG won't be exposed to the hardware domain either. Note that vpci_ecam_{read,write}() already refuse accesses that cross a device boundary unconditionally. Reported-by: Jason Andryuk Signed-off-by: Roger Pau Monné --- tools/include/xen-tools/common-macros.h | 2 ++ xen/arch/x86/x86_64/pci.c | 8 ++++---- xen/drivers/vpci/vpci.c | 6 ++++-- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tools/include/xen-tools/common-macros.h b/tools/include/xen-tools/common-macros.h index 88b4a0e5a693..1f9146b23b0e 100644 --- a/tools/include/xen-tools/common-macros.h +++ b/tools/include/xen-tools/common-macros.h @@ -68,6 +68,8 @@ }) #endif +#define IS_ALIGNED(val, align) (!((val) & ((align) - 1))) + #define ROUNDUP(x, a) (((x) + (a) - 1) & ~((a) - 1)) #define ROUNDDOWN(x, a) ((x) & ~((a) - 1)) diff --git a/xen/arch/x86/x86_64/pci.c b/xen/arch/x86/x86_64/pci.c index 8d33429103b9..6298141c3ca7 100644 --- a/xen/arch/x86/x86_64/pci.c +++ b/xen/arch/x86/x86_64/pci.c @@ -26,7 +26,7 @@ uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg) uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) { uint32_t value; @@ -39,7 +39,7 @@ uint16_t pci_conf_read16(pci_sbdf_t sbdf, unsigned int reg) uint32_t pci_conf_read32(pci_sbdf_t sbdf, unsigned int reg) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 4) ) { uint32_t value; @@ -60,7 +60,7 @@ void pci_conf_write8(pci_sbdf_t sbdf, unsigned int reg, uint8_t data) void pci_conf_write16(pci_sbdf_t sbdf, unsigned int reg, uint16_t data) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 2) ) pci_mmcfg_write(sbdf.seg, sbdf.bus, sbdf.devfn, reg, 2, data); else pci_conf_write(PCI_CONF_ADDRESS(sbdf, reg), reg & 2, 2, data); @@ -68,7 +68,7 @@ void pci_conf_write16(pci_sbdf_t sbdf, unsigned int reg, uint16_t data) void pci_conf_write32(pci_sbdf_t sbdf, unsigned int reg, uint32_t data) { - if ( sbdf.seg || reg > 255 ) + if ( sbdf.seg || reg > 255 || !IS_ALIGNED(reg, 4) ) pci_mmcfg_write(sbdf.seg, sbdf.bus, sbdf.devfn, reg, 4, data); else pci_conf_write(PCI_CONF_ADDRESS(sbdf, reg), 0, 4, data); diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 0ac9ec8b0475..9e2c27e3a300 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -685,6 +685,8 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size, /* Helper function to check an access size and alignment on vpci space. */ bool vpci_access_allowed(unsigned int reg, unsigned int len) { + const struct domain *currd = current->domain; + /* Check access size. */ if ( len != 1 && len != 2 && len != 4 && len != 8 ) return false; @@ -695,8 +697,8 @@ bool vpci_access_allowed(unsigned int reg, unsigned int len) return false; #endif - /* Check that access is size aligned. */ - if ( (reg & (len - 1)) ) + /* Refuse unaligned accesses for non-hardware domains. */ + if ( !is_hardware_domain(currd) && !IS_ALIGNED(reg, len) ) return false; return true; -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 15:49:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 15:49:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1384953.1627637 (Exim 4.92) (envelope-from ) id 1ws0LU-0004ei-PJ; Thu, 06 Aug 2026 15:49:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1384953.1627637; Thu, 06 Aug 2026 15:49:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws0LU-0004eb-Mm; Thu, 06 Aug 2026 15:49:24 +0000 Received: by outflank-mailman (input) for mailman id 1384953; Thu, 06 Aug 2026 15:49:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws0LT-0004eV-8A for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 15:49:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1ws0LS-00834C-17; Thu, 06 Aug 2026 15:49:22 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ws0LR-009pwT-2L; Thu, 06 Aug 2026 15:49:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=o3yaR1bb4+BXLENjHX+LaY79Q3ebPt+U4+8LUNnuhlg=; b=U+WUsv/klw2chglEXJrFunuuZj jjfotCwxIuFrB1FafeC9rma3Pf2/BhyJY/fK5so3EzomddTISydRL2Bn04NuoaovFK2R6XTLPE9F8 ZmMftCC1raQ4/fYGX4SBmBWWYO89O5rrsV2IoX/xeMFI1aXkVGCp9y+miPNqLFEuu/eY=; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Teddy Astie , Anthony PERARD , Stewart Hildebrand Subject: [PATCH v2 0/2] vpci: allow unaligned accesses by the hardware domain Date: Thu, 6 Aug 2026 17:26:17 +0200 Message-ID: <20260806152619.23881-1-roger@xenproject.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello, Mostly the same as v1, plus an additional patch that refuses accesses that cross a device boundary in pci_mmcfg_{read,write}() itself. Thanks, Roger. Roger Pau Monne (2): x86/pci: prevent cross-device accesses in pci_mmcfg_{read,write}() xen/vpci: allow unaligned accesses by the hardware domain tools/include/xen-tools/common-macros.h | 2 ++ xen/arch/x86/x86_64/mmconfig_64.c | 6 ++++-- xen/arch/x86/x86_64/pci.c | 8 ++++---- xen/drivers/vpci/vpci.c | 6 ++++-- 4 files changed, 14 insertions(+), 8 deletions(-) -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 17:27:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 17:27:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385047.1627665 (Exim 4.92) (envelope-from ) id 1ws1rn-0002g5-21; Thu, 06 Aug 2026 17:26:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385047.1627665; Thu, 06 Aug 2026 17:26:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws1rm-0002fy-Vf; Thu, 06 Aug 2026 17:26:50 +0000 Received: by outflank-mailman (input) for mailman id 1385047; Thu, 06 Aug 2026 17:26:49 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws1rl-0002fs-Cc for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 17:26:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws1rk-00Dhsu-Lm for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 19:26:48 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a74c3ba-e002-0a2a0a5209dd-0a2a4502ca6a-18 for ; Thu, 06 Aug 2026 19:26:48 +0200 Received: from [160.101.131.8] (helo=na1pdmzitismtp01.tibco.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a74c3d7-6ca4-0a2a45020019-a06583088ea4-3 for ; Thu, 06 Aug 2026 19:26:48 +0200 Received: from fedora.eng.citrite.net (unknown [10.113.40.46]) by na1pdmzitismtp01.tibco.com (Postfix) with ESMTP id A6381444E917; Thu, 6 Aug 2026 13:25:08 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; none From: Abdelkareem Abdelsaamad To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, jason.andryuk@amd.com, teddy.astie@vates.tech, Abdelkareem Abdelsaamad Subject: [PATCH v3] x86/nSVM: Check injected event consistency Date: Thu, 6 Aug 2026 18:23:32 +0100 Message-ID: <95abc420acac6eefc1b97c3c98753d510930ce8a.1785933566.git.abdelkareem.abdelsaamad@citrix.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1786037208-317CA2AC-6869F7CD/0/0 X-purgate-type: clean X-purgate-size: 6067 On the AMD platforms, allowing a VMRUN instruction with a malformed VMCB has debugging complications, security and performance implications. The APM volume #2 15.20 (40332-Rev. 4.10-July 2026) states the two possibilities that result in a VMRUN exit with VMEXIT_INVALID due to the injected event. These are • Reserved values of TYPE have been specified. • TYPE = 3 (exception) has been specified with a vector that does not correspond to an exception (this includes vector 2, which is an NMI, not an exception). Extend the VMCB validation to check for such inconsistency. The collection of the invalid exception vectors are ported from the upstream KVM commit ("7e79f71bca5c" KVM: nSVM: Add missing consistency check for EVENTINJ). Adjust the checks from the commit to align with the APM Volume #2 and Volume #3 (40332—Rev. 4.40—July 2026) for the X86_EXC_OF and X86_EXC_BR vectors which should not be valid on the x86 64-bit (long mode) platforms. The adjustment is posted to the KVM mailing commit patch thread https://lore.kernel.org/all/20260803225402.2324595-1-abdelkareem.abdelsaamad@citrix.com/ Signed-off-by: Abdelkareem Abdelsaamad --- Changes in v3: - Restricted X86_EXC_OF (4) and X86_EXC_BR (5) vector injections to non-64-bit guests to prevent impossible guest-mode state injections per AMD APM Volumes 2 & 3. - Refactored exception vector validation from if-conditions to a switch statement to improve readability and extensibility. - Restricted X86_EXC_CP (21) vector injection to hosts with enabled CET to prevent VMRUN failures on hardware without CET support. Changes in v2: - Remove the redundant SVM_EVENT_INJ_TYPE_MASK and SVM_EVENT_INJ_VEC_MASK constants. - Correct the Injected Event Type consistency check to disallow the injection of reserved type 1 events. --- Testing: - Using a locally developed XTF nested virt setup, I manually tested VMRUN instruction handling with a malformed VMCB: 1) Inject event with the type (7). The hypervisor logs show the message (XEN) [ 645.155609] d2v0[nsvm_vmcb_prepare4vmrun]: eventinj: Invalid Injected Event Type: (0x7) 2) Inject event with the exception value (3) and the vector value (2) for NMI. The hypervisor logs show the message (XEN) [ 645.157277] d2v0[nsvm_vmcb_prepare4vmrun]: eventinj: Invalid Injected Event. Exception type: (0x3), with a vector: (0x2) does not belong to an exception on the platform. 3) Inject event with the exception value (3) and the vector value (21) for the X86_EXC_CP (Control-Flow Protection). Without the changes included: On the Naples host, where the vector was not yet known to the hardware. VMRUN immediately triggers VMEXIT_INVALID. On the Genoa host, VMRUN immediately triggers VMEXIT_VMMCALL. With the changes included: On the Naples host and the Genoa host, VMEXIT_INVALID is reported back without VMRUN execution. - CI tests: https://gitlab.com/xen-project/people/aabdelsa/xen/-/pipelines/2734283788 --- xen/arch/x86/hvm/svm/vmcb.c | 51 +++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 975a1eaef8..4379bbef09 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -320,6 +320,41 @@ void svm_vmcb_dump(const char *from, const struct vmcb_struct *vmcb) svm_dump_sel(" TR", &vmcb->tr); } +static bool is_valid_svm_vmcb_injected_exception_vector( + const struct vmcb_struct *vmcb, uint8_t vmcb_injected_vector) +{ + switch ( vmcb_injected_vector ) + { + case X86_EXC_DE: + case X86_EXC_DB: + case X86_EXC_BP: + case X86_EXC_UD: + case X86_EXC_NM: + case X86_EXC_DF: + case X86_EXC_TS: + case X86_EXC_NP: + case X86_EXC_SS: + case X86_EXC_GP: + case X86_EXC_PF: + case X86_EXC_MF: + case X86_EXC_AC: + case X86_EXC_MC: + case X86_EXC_XM: + case X86_EXC_HV: + case X86_EXC_SX: + return true; + case X86_EXC_OF: + case X86_EXC_BR: + return !(vmcb_get_efer(vmcb) & EFER_LMA) || !(vmcb->cs.l); + case X86_EXC_VC: + return vmcb_get_sev_es(vmcb); + case X86_EXC_CP: + return !!(vmcb_get_cr4(vmcb) & X86_CR4_CET); + default: + return false; + } +} + bool svm_vmcb_isvalid( const char *from, const struct vmcb_struct *vmcb, const struct vcpu *v, bool verbose) @@ -330,6 +365,12 @@ bool svm_vmcb_isvalid( unsigned long cr4 = vmcb_get_cr4(vmcb); unsigned long valid; uint64_t efer = vmcb_get_efer(vmcb); + uint8_t vmcb_injected_type = vmcb->event_inj.type; + uint8_t vmcb_injected_vector = vmcb->event_inj.vector; + uint8_t vmcb_valid_event_inj_types_mask = (1 << X86_ET_EXT_INTR) | + (1 << X86_ET_NMI) | + (1 << X86_ET_HW_EXC) | + (1 << X86_ET_SW_INT); #define PRINTF(fmt, args...) do { \ if ( !verbose ) return true; \ @@ -392,6 +433,16 @@ bool svm_vmcb_isvalid( PRINTF("eventinj: MBZ bits are set (%#"PRIx64")\n", vmcb->event_inj.raw); + if ( !((1 << vmcb_injected_type) & vmcb_valid_event_inj_types_mask) ) + PRINTF("eventinj: Invalid Injected Event Type: (%#"PRIx8")\n", + vmcb_injected_type); + + if ( (vmcb_injected_type == X86_ET_HW_EXC) && + !is_valid_svm_vmcb_injected_exception_vector( + vmcb, vmcb_injected_vector) ) + PRINTF("eventinj: Invalid Injected Event. Exception type: (%#"PRIx8")," + " with a vector: (%#"PRIx8") does not belong to an exception on" + " the platform \n", vmcb_injected_type, vmcb_injected_vector); #undef PRINTF return ret; } -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 06 22:18:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 22:18:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385234.1627674 (Exim 4.92) (envelope-from ) id 1ws6Pi-0006qM-I3; Thu, 06 Aug 2026 22:18:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385234.1627674; Thu, 06 Aug 2026 22:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws6Pi-0006qE-Er; Thu, 06 Aug 2026 22:18:10 +0000 Received: by outflank-mailman (input) for mailman id 1385234; Thu, 06 Aug 2026 22:18:08 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3HQh1agYKCVwM84HD6AIIAF8.6IGR8H-78P8FFCMNM.R8HJLID86N.ILA@flex--seanjc.bounces.google.com>) id 1ws6Pg-0006q7-QR for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 22:18:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws6Pg-00Bhhc-79 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 00:18:08 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3HQh1agYKCVwM84HD6AIIAF8.6IGR8H-78P8FFCMNM.R8HJLID86N.ILA@flex--seanjc.bounces.google.com>) id 6a7507d5-e002-0a2a0a5209dd-0a2a450181b4-42 for ; Fri, 07 Aug 2026 00:18:08 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3HQh1agYKCVwM84HD6AIIAF8.6IGR8H-78P8FFCMNM.R8HJLID86N.ILA@flex--seanjc.bounces.google.com>) id 6a75081e-5984-0a2a45010019-d155d2c5c0cd-3 for ; Fri, 07 Aug 2026 00:18:07 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84eccf9d899so3597352b3a.2 for ; Thu, 06 Aug 2026 15:18:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786054686; x=1786659486; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/BEVvi4/7i6XDSu/QYDIwcuZoEPs9pbAb29S0DeOBes=; b=MyQHE4rFqyN3m4oFV5xa7RNhfCtFhVjlKYGIK0a6ZRDBcuC2ZO0BIsmG0Wloe8j4st ejAUwT6Y5q/EoIbebz/BZ4gjgBhQAzR6EuyWkuN9Tazjzo2uANonA30vIU0BNZoY4OzT 9h3ohjJMbN9xkIgJOUrN3NfKP+HRBFAtmkel30D9O0wFRVKjjdsrq7b4uAjYvT6fKmJm M/116vDGMLT7gzo89YXWdn93m0oshXZe5onSQJjnlhCW2JLGK5FKSTn5ZxhC+CSU4s1u nxlYe5GyRwVXUb18JFd5srq+QUIXCtoArfBLw3M4+XuUYWYW1dwH4r71fuafxTNR0m5o M43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786054686; x=1786659486; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/BEVvi4/7i6XDSu/QYDIwcuZoEPs9pbAb29S0DeOBes=; b=sejdI5255W3AWBybJU0QBV9Ucv1hcANohmmto+YT7s5P4dVfjRb5F5yG5wW5jBZeIZ tExJVbO5/akNw/mJrPByzAgIbsA08VpEfx+DNm4ghbGE2RBLgnO6QcgxoxVmJgY83jIE yxKHnzJqW1hZr567yQqTmsZ3sPJlTsNYaizrs3j7XD0StFgAlGS32B41HOEQJ8sj6xbT 3TnC3yLgc0NYpgM1uNZbVuFC89xJQdSjPqFdzDeK5lEJda/O68Fi6AaGRJpoTHkH1/Gw +2PwoulwVgPeXdtDAB2ARnHdgeYXcJVAqy6eKyiCrP+js9P1gg71rxblnbQYPUKFUCIt c9ng== X-Forwarded-Encrypted: i=1; AHgh+RrFnw5PHqidxRYUsrHDoF5OcfDQVW6SqieHSjuS7oLcSX0ZY3UocY6YR+40UeHUs36NWNPkZ7CniqY=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw3TuYDJIzb/xjyVmnIkJqGRrAjgqdoJumMgVabgI+FoaQ7TiYl roT6YyB8Kv8c5tRYY46bBl/30qJoEU6jkIbKXUY0ZUYU8bYPxj2Me0H3OHztTs2wj2SkPVWoDSP Vvv03ww== X-Received: from pfbln15.prod.google.com ([2002:a05:6a00:3ccf:b0:848:5415:1869]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3a0f:b0:848:3f07:c5a2 with SMTP id d2e1a72fcca58-84f2dfd0a06mr18297213b3a.4.1786054685697; Thu, 06 Aug 2026 15:18:05 -0700 (PDT) Date: Thu, 6 Aug 2026 15:18:05 -0700 In-Reply-To: Mime-Version: 1.0 References: <20260701193212.749551-1-seanjc@google.com> <20260701193212.749551-48-seanjc@google.com> Message-ID: Subject: Re: [PATCH v5 47/51] x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC From: Sean Christopherson To: Michael Kelley Cc: Jonathan Corbet , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Kiryl Shutsemau , Rick Edgecombe , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , John Stultz , Shuah Khan , "H. Peter Anvin" , Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , "linux-doc@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "virtualization@lists.linux.dev" , "xen-devel@lists.xenproject.org" , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-d62444/1786054688-C5146757-6D791EC4/0/0 X-purgate-type: clean X-purgate-size: 2223 On Thu, Jul 02, 2026, Michael Kelley wrote: > From: Sean Christopherson Sent: Wednesday, July 1, 2026 12:32 PM > > > > Silently ignore attempts to switch to a paravirt sched_clock when running > > as a CoCo guest with trusted TSC. In hand-wavy theory, a misbehaving > > hypervisor could attack the guest by manipulating the PV clock to affect > > guest scheduling in some weird and/or predictable way. More importantly, > > reading TSC on such platforms is faster than any PV clock, and sched_clock > > is all about speed. > > > > Reviewed-by: David Woodhouse > > Signed-off-by: Sean Christopherson > > --- > > arch/x86/kernel/tsc.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > > index 012321fed5e5..a146fc7b5e74 100644 > > --- a/arch/x86/kernel/tsc.c > > +++ b/arch/x86/kernel/tsc.c > > @@ -283,6 +283,15 @@ bool using_native_sched_clock(void) > > int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, > > void (*save)(void), void (*restore)(void)) > > { > > + /* > > + * Don't replace TSC with a PV clock when running as a CoCo guest and > > + * the TSC is secure/trusted; PV clocks are emulated by the hypervisor, > > + * which isn't in the guest's TCB. > > + */ > > + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC) || > > + boot_cpu_has(X86_FEATURE_TDX_GUEST)) > > + return -EPERM; > > Do a pr_warn() in the error case? Your commit message says to do the ignore > silently, but I wonder if that's a good idea. At least for Hyper-V, the error > case shouldn't happen. I agree it's not a great idea, but unfortunately it's pretty much guaranteed to fire on KVM-based setups. The KVM world hasn't been anywhere near as aggressive as Hyper-V in terms of killing off PV features when running SNP/TDX guests (which is largely how this series came to be in the first place). So while I'm conceptually not opposed to the idea of printing an error message, in practice I'm pretty strong against it because odds are very good I'll end up dealing with "bug" reports due to less-than-awesome setups. From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385269.1627715 (Exim 4.92) (envelope-from ) id 1ws7dY-0007Em-49; Thu, 06 Aug 2026 23:36:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385269.1627715; Thu, 06 Aug 2026 23:36:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dX-0007E0-TO; Thu, 06 Aug 2026 23:36:31 +0000 Received: by outflank-mailman (input) for mailman id 1385269; Thu, 06 Aug 2026 23:36:31 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3fBp1agYKCd8TFBOKDHPPHMF.DPNYFO-EFWFMMJTUT.YFOQSPKFDU.PSH@flex--seanjc.bounces.google.com>) id 1ws7dX-000791-D8 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dW-00GcaU-QT for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:30 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3fBp1agYKCd8TFBOKDHPPHMF.DPNYFO-EFWFMMJTUT.YFOQSPKFDU.PSH@flex--seanjc.bounces.google.com>) id 6a751a49-bab6-0a2a0a5309dd-0a2a4501d568-32 for ; Fri, 07 Aug 2026 01:36:30 +0200 Received: from [209.85.214.200] (helo=mail-pl1-f200.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3fBp1agYKCd8TFBOKDHPPHMF.DPNYFO-EFWFMMJTUT.YFOQSPKFDU.PSH@flex--seanjc.bounces.google.com>) id 6a751a7d-5984-0a2a45010019-d155d6c8f1f5-3 for ; Fri, 07 Aug 2026 01:36:30 +0200 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cfc52ddc55so34439545ad.3 for ; Thu, 06 Aug 2026 16:36:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059389; x=1786664189; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Bl6f0kmYO+QvCHyY9ZYfUQzYrQcYJLjL3x7Z6ExdFrE=; b=Z+aQxQiE+OE1I3dn5dzeeW95DU07hYNTCDlCxjhYO+Aq6aPRS2RNr/2klJwuC+E4/x ftWoVyu/tz0Lb5p5trYqxrefnuqxmAPLuys0tsQNmUc8O9TEM4uQ2kqDWdXTJjIGpWeZ in5zUOHqVdgEBr56INMLsc79On8vJWHIGiI1yBfh+D/5A729uwtac9xfMdhtJsFofvys kjWroSa9NWPmsvak+Mm+bnXpbGt3Iq2j4PQwu0nA21rYUDWMV2zyw+B+mcCjgIVahJl9 tKVwvrZARasr9fVInvqmhj3+0e1/EZEJ3T/aczJDP4zCxVK2fvk7e/zgWMdGcEbOqP4d +R1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059389; x=1786664189; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Bl6f0kmYO+QvCHyY9ZYfUQzYrQcYJLjL3x7Z6ExdFrE=; b=rrfebHGB4boAlvbqG3TrCdJj6XBNdiWhphIGVZwILC02WTPUNts2T6ARI/n4i62AdH wLlwjXhN3oyhDPdSBeTkfLDrrXunRj07HjHvMIBpOSfB1vJI9BKEtWdZs8CPKJL/2rRR VzaKY3KVjL/FO8hpWctDoVZBx+vHPcbtpgjMOh2MxYukUPd1WjWu+DCaruZ+IFmE9Ugt 5DVhtuTxdPUixHADkQXQP5p7C3MfJMQNJEafpCepR97MCvapIQa6DFtDtXnFvkGsonQz XMSe/7aL6TeW3h/1quRu2sFC2qZ3a+X4iDw8GdqdkgLu1JN4tLkBsP7gqczxfmzO+01F 1ZRg== X-Forwarded-Encrypted: i=1; AHgh+RrtFcl/L/ifj9/+w2Wdu35WGtEEKCvO69d6wRHt52dGO1j9cZERVjZFE4zMJSCgK+I+t32JZtw3Hrg=@lists.xenproject.org X-Gm-Message-State: AOJu0YzoK51m8zmU8itLWqjEfP5u7DJdKiwdt2Ze543xRr6TO7SUlETY lzJPsKh4v2ruDxIpUKyBsfeMHjlc2FM953+P3THHKbnk+CGLWQFf/2QGpyKSJOgOy3sCU0EnoX5 z80ihaA== X-Received: from pgav2.prod.google.com ([2002:a05:6a02:2dc2:b0:c85:9dd2:d11e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7349:b0:3c6:3c5b:f2e1 with SMTP id adf61e73a8af0-3cbadcfcacfmr5222309637.32.1786059388428; Thu, 06 Aug 2026 16:36:28 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:21 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-5-seanjc@google.com> Subject: [PATCH v6 04/51] x86/tsc: Restrict recalibrate_cpu_khz() export to p4-clockmod and powernow-k7 From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1786059390-BCB45757-AB75D175/0/0 X-purgate-type: clean X-purgate-size: 833 Export recalibrate_cpu_khz() only for its two users, p4-clockmod.ko and powernow-k7.ko, to help document that recalibration is relevant only to ancient CPUs. For all intents and purposes, no functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index bc4348585194..09bf10f322ba 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -943,7 +943,7 @@ void recalibrate_cpu_khz(void) cpu_khz_old, cpu_khz); #endif } -EXPORT_SYMBOL_GPL(recalibrate_cpu_khz); +EXPORT_SYMBOL_FOR_MODULES(recalibrate_cpu_khz, "p4-clockmod,powernow-k7"); static unsigned long long cyc2ns_suspend; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385266.1627688 (Exim 4.92) (envelope-from ) id 1ws7dV-0006cw-8c; Thu, 06 Aug 2026 23:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385266.1627688; Thu, 06 Aug 2026 23:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dV-0006cj-42; Thu, 06 Aug 2026 23:36:29 +0000 Received: by outflank-mailman (input) for mailman id 1385266; Thu, 06 Aug 2026 23:36:28 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3eBp1agYKCdsPB7KG9DLLDIB.9LJUBK-ABSBIIFPQP.UBKMOLGB9Q.LOD@flex--seanjc.bounces.google.com>) id 1ws7dU-0006a3-4O for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dT-00BpFw-Hd for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:27 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3eBp1agYKCdsPB7KG9DLLDIB.9LJUBK-ABSBIIFPQP.UBKMOLGB9Q.LOD@flex--seanjc.bounces.google.com>) id 6a751a44-2eae-0a2a0a5409dd-0a2a45069178-32 for ; Fri, 07 Aug 2026 01:36:27 +0200 Received: from [209.85.214.199] (helo=mail-pl1-f199.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3eBp1agYKCdsPB7KG9DLLDIB.9LJUBK-ABSBIIFPQP.UBKMOLGB9Q.LOD@flex--seanjc.bounces.google.com>) id 6a751a79-195a-0a2a45060019-d155d6c7c0f2-3 for ; Fri, 07 Aug 2026 01:36:27 +0200 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ce8a76df2dso47495605ad.2 for ; Thu, 06 Aug 2026 16:36:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059385; x=1786664185; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=VnGiMJAeWdyvdLpQdGy9NuKyd6BkLuzFrwi8wF2quVo=; b=d+kiInm2fADfglJT76haTsw7CHKZ07SSlfYuJorup/spRNvkTY9+7JQteJU8USu07z 6eSMkWGRG+aiz56Kc9Ha/crhehSxXv3+vsPcbXYyt5R1qGCbYDhBKiCm6hZFx4GBAsPr ijTSulVZ0wddVnHDbiyIZq64dIfriYX4xRuYX5J2M4b+GIHM70YJAMDYTqg85XwjEacI 1ZP3pkm2sXGUS4ws1fvA9sLlvNmVaGiF9ejmthB4btiobAnbFGFBl6pN2YooYKoik2v4 KeYrzxS6avNoYx4g0PUaI9KJQQsslE+cyil1an85ANPTS+iQHcPid/qxFMz2CrTiQKDE If0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059385; x=1786664185; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VnGiMJAeWdyvdLpQdGy9NuKyd6BkLuzFrwi8wF2quVo=; b=kTXKFnutqIdMf597YTHTM9S+SU6v4DoHat1Fkms8lj8bnac+mCWDiUkSvlNtTGEQlu RFVloznxVka9uSJpsoSmba5+lRFIBEN4Ld+KtjJdfb+TIQDgWK6OGjMSlm8YARq8DUe/ f2J+gylE07u42sJgTM4i9aWMe1yeKL6xAos3sKrlxzCvwPQ+DABqqlkf25iGw9zD9Nzo qbmYVoPhaSiTRjrMum7KIdDD+LgbqjFmyhfn4YNUqW9N1l1FwXX0a8QGRBpEWtA1Dsc8 IRMUVmZFYdS7lhBNHITPCieibWbXG/oT3wqzBvI2XfNzdYKhGfMHtWFuQHnyrz3Oh8vO JZAA== X-Forwarded-Encrypted: i=1; AHgh+RrArYAKB3SyFv9KZ/8D+XVk8At5Rs2Jmw9b9W/clwIfbULicIoXHMDrXiFmPQiFFv3s85StiAdCgHI=@lists.xenproject.org X-Gm-Message-State: AOJu0YxjlmpxxqhyFHPK7vn0aeRXThlmLMk5kfo8JxsFEkXHDVED4gOM /efZwP88fLXQTRmETKAvNA7CoJeqXn8VTtW3JWfrnbeQjhqlgZpXgYD7mMGLbtvAiMcCBIbwoR+ 6l+zw1Q== X-Received: from plzw6.prod.google.com ([2002:a17:902:9046:b0:2cc:6ddb:debc]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:dac1:b0:2c0:e5ee:f554 with SMTP id d9443c01a7336-2d0ca71b3d7mr204312595ad.8.1786059384888; Thu, 06 Aug 2026 16:36:24 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:18 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-2-seanjc@google.com> Subject: [PATCH v6 01/51] x86/apic: Provide helpers to set local APIC timer frequency in hz and khz From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1786059387-FD20877B-5EBF9333/0/0 X-purgate-type: clean X-purgate-size: 6199 Add and use APIs to set the local APIC timer period (given a frequency) instead of open coding the subtle HZ math in all external callers, and make lapic_timer_period local to apic.c. Provide APIs to specify the frequency in both hertz and kilohertz so that Hyper-V and VMware code aren't forced to lose precision. Opportunistically take the frequency as a u64 to harden against the possibility that the frequency (in Khz) is greater than 4294967, i.e. if the APIC timer runs at ~4.29 GHz. As pointed out by Sashiko, 4294968 * 1000 == 0x1_000002c0, and thus a Khz period of 4294968 would silently overflow the 32-bit unsigned integer used by most callers. Print out who set the period to maintain equivalent Hyper-V and VMware functionality, and in general to make it easier to triage/debug issues. Cc: Michael Kelley Signed-off-by: Sean Christopherson --- arch/x86/include/asm/apic.h | 3 ++- arch/x86/kernel/apic/apic.c | 19 ++++++++++++++++++- arch/x86/kernel/cpu/mshyperv.c | 5 +---- arch/x86/kernel/cpu/vmware.c | 4 +--- arch/x86/kernel/jailhouse.c | 2 +- arch/x86/kernel/tsc.c | 2 +- arch/x86/kernel/tsc_msr.c | 2 +- 7 files changed, 25 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index 9cd493d467d4..6946220a6008 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -63,7 +63,6 @@ extern int apic_verbosity; extern int local_apic_timer_c2_ok; extern bool apic_is_disabled; -extern unsigned int lapic_timer_period; extern enum apic_intr_mode_id apic_intr_mode; enum apic_intr_mode_id { @@ -138,6 +137,8 @@ void register_lapic_address(unsigned long address); extern void setup_boot_APIC_clock(void); extern void setup_secondary_APIC_clock(void); extern void lapic_update_tsc_freq(void); +extern void apic_set_timer_frequency_hz(u64 freq_hz, const char *source); +extern void apic_set_timer_frequency_khz(u64 freq_khz, const char *source); #ifdef CONFIG_X86_64 static inline bool apic_force_enable(unsigned long addr) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 90025451ace2..9239dca91c41 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -37,6 +37,7 @@ #include #include #include +#include #include @@ -176,7 +177,7 @@ static struct resource lapic_resource = { }; /* Measured in ticks per HZ. */ -unsigned int lapic_timer_period = 0; +static unsigned int lapic_timer_period; static void apic_pm_activate(void); @@ -796,6 +797,22 @@ bool __init apic_needs_pit(void) return lapic_timer_period == 0; } +void apic_set_timer_frequency_hz(u64 freq_hz, const char *source) +{ + u32 f_remainder; + u64 f_khz = div_u64_rem(freq_hz, HZ_PER_KHZ, &f_remainder); + + lapic_timer_period = div_u64(freq_hz, HZ); + + pr_info("Local APIC Timer Frequency set to %llu.%03u KHz (from '%s').\n", + f_khz, f_remainder, source); +} + +void apic_set_timer_frequency_khz(u64 freq_khz, const char *source) +{ + apic_set_timer_frequency_hz(freq_khz * HZ_PER_KHZ, source); +} + static int __init calibrate_APIC_clock(void) { struct clock_event_device *levt = this_cpu_ptr(&lapic_events); diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 185d4f677ec0..cadc7f872b4f 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -646,10 +646,7 @@ static void __init ms_hyperv_init_platform(void) u64 hv_lapic_frequency; rdmsrq(HV_X64_MSR_APIC_FREQUENCY, hv_lapic_frequency); - hv_lapic_frequency = div_u64(hv_lapic_frequency, HZ); - lapic_timer_period = hv_lapic_frequency; - pr_info("Hyper-V: LAPIC Timer Frequency: %#x\n", - lapic_timer_period); + apic_set_timer_frequency_hz(hv_lapic_frequency, "Hyper-V hypervisor"); } register_nmi_handler(NMI_UNKNOWN, hv_nmi_unknown, NMI_FLAG_FIRST, diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 34b73573b108..22842bf5b59e 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -424,9 +424,7 @@ static void __init vmware_platform_setup(void) #ifdef CONFIG_X86_LOCAL_APIC /* Skip lapic calibration since we know the bus frequency. */ - lapic_timer_period = ecx / HZ; - pr_info("Host bus clock speed read from hypervisor : %u Hz\n", - ecx); + apic_set_timer_frequency_hz(ecx, "VMware hypervisor"); #endif } else { pr_warn("Failed to get TSC freq from the hypervisor\n"); diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c index f58ce9220e0f..615a1f25c83a 100644 --- a/arch/x86/kernel/jailhouse.c +++ b/arch/x86/kernel/jailhouse.c @@ -65,7 +65,7 @@ static void jailhouse_get_wallclock(struct timespec64 *now) static void __init jailhouse_timer_init(void) { - lapic_timer_period = setup_data.v1.apic_khz * (1000 / HZ); + apic_set_timer_frequency_khz(setup_data.v1.apic_khz, "Jailhouse hypervisor"); } static unsigned long jailhouse_get_tsc(void) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 723347e2cf7f..63e26805f8dd 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -717,7 +717,7 @@ unsigned long native_calibrate_tsc(void) * lapic_timer_period here to avoid having to calibrate the APIC * timer later. */ - lapic_timer_period = crystal_khz * 1000 / HZ; + apic_set_timer_frequency_khz(crystal_khz, "CPUID 0x15/0x16"); #endif return crystal_khz * ebx_numerator / eax_denominator; diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c index d74743c8d2a4..4bd5f2ae656b 100644 --- a/arch/x86/kernel/tsc_msr.c +++ b/arch/x86/kernel/tsc_msr.c @@ -212,7 +212,7 @@ unsigned long cpu_khz_from_msr(void) pr_err("Error MSR_FSB_FREQ index %d is unknown\n", index); #ifdef CONFIG_X86_LOCAL_APIC - lapic_timer_period = (freq * 1000) / HZ; + apic_set_timer_frequency_khz(freq, "MSR_FSB_FREQ"); #endif /* -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385271.1627737 (Exim 4.92) (envelope-from ) id 1ws7dc-0007we-M6; Thu, 06 Aug 2026 23:36:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385271.1627737; Thu, 06 Aug 2026 23:36:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dc-0007wT-IX; Thu, 06 Aug 2026 23:36:36 +0000 Received: by outflank-mailman (input) for mailman id 1385271; Thu, 06 Aug 2026 23:36:34 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3fxp1agYKCeIWIERNGKSSKPI.GSQbIR-HIZIPPMWXW.bIRTVSNIGX.SVK@flex--seanjc.bounces.google.com>) id 1ws7da-0007gB-Mn for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7da-00GcaU-3n for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:34 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3fxp1agYKCeIWIERNGKSSKPI.GSQbIR-HIZIPPMWXW.bIRTVSNIGX.SVK@flex--seanjc.bounces.google.com>) id 6a751a70-bab6-0a2a0a5309dd-0a2a450ae97a-10 for ; Fri, 07 Aug 2026 01:36:34 +0200 Received: from [209.85.210.199] (helo=mail-pf1-f199.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3fxp1agYKCeIWIERNGKSSKPI.GSQbIR-HIZIPPMWXW.bIRTVSNIGX.SVK@flex--seanjc.bounces.google.com>) id 6a751a80-f2d2-0a2a450a0019-d155d2c7ed64-3 for ; Fri, 07 Aug 2026 01:36:33 +0200 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8484f26852dso3084112b3a.1 for ; Thu, 06 Aug 2026 16:36:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059392; x=1786664192; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tcL8w1SVbwtFzoahyKqy3HGwkprj7A9nnDUrJsX64pM=; b=DgFqVJTosbcOR4sDQQ29htYcgOWEzPZte/iAOYmjWIG7mDh/jCAcfKdpEU1WPqXEfW uzlYtZZTbPUGuKzQ5p4DTKIvYsa/qWOJ2feqFnsGE60Vrjf++givTPJBx4vIFQ/s1++m 15bJYnVFP0nO7WJYVShFD+vE5qvah1xnLNTNmLijiBGPSaBFPm038qagJ+BLXK/lryY+ ZStvDzWPy1fbwiMmpqhvg/3YDasTXNbQFtcUyYZcWFPZX/ZMP9yxkemEpAxgnSLx4s+a 4uu0a1jRF6M5SmetfaoN+QiGvUDstlrfdJ5tNHdeXC5CRiURfXZo4NqVnd4vHdvzXtg6 YBBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059392; x=1786664192; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tcL8w1SVbwtFzoahyKqy3HGwkprj7A9nnDUrJsX64pM=; b=UTTijzli51J1/FrMrWRJLvi1OtkPHxXBEBrgMeMs52Q2FXOtpZYNa8ePWVRAdh8kKv xWliQ485rSWlTCtehZniitUQnPnOp97KT8vGha6PPqEYW/BKnnM/gNT5WSdi5+NB8XZI bYMtglH/+Tu9H7/q2lg0aCQ2l+p6aDD2s9vVmvydmqkfG6wosrOvNCehJwPtvFrHMWOb 2vJooTfLovoogWMZ9XnMeES5UMLmiyEmrLq9Mt4EKklpwJ3jGag9Xn3UBr6kg9ti63zM /V5aX6hQYPjNK85B49aPMPUC9PtjYIaH2PBDUYuLQnJcXPIphLRSDFq7XGmvqe6kBSvz wFZg== X-Forwarded-Encrypted: i=1; AHgh+RoMuNLEXsoD8oLR7S8pbCTqXq1ZmKaDxuu4DR71chipMQq/876Ze5/HDCjuDp1SPY7vIB213mR6q4M=@lists.xenproject.org X-Gm-Message-State: AOJu0YxjKRyfwq0ZYndv3+PbQJyM5je+eDCqcFkOYLZeU3ZuvZG3L30d cgzOfs+iQCj3ZFrChdyHbyto3K/RnyWyeUgi5bpZL9Wo8FfGRElZIScfFS9KaIMMPc+ZHhJ/zqX yWheV8Q== X-Received: from pgmc14.prod.google.com ([2002:a63:1c4e:0:b0:cbb:8a1e:efa4]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:10cd:b0:848:8445:6956 with SMTP id d2e1a72fcca58-84f4fe9f90emr5350899b3a.18.1786059391731; Thu, 06 Aug 2026 16:36:31 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:23 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-7-seanjc@google.com> Subject: [PATCH v6 06/51] x86/sev: Don't override CPU frequency calibration for SNP's Secure TSC From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059394-53ED2CFC-FFA6726C/0/0 X-purgate-type: clean X-purgate-size: 1503 Don't override the kernel's CPU frequency calibration routine when registering SNP's Secure TSC calibration routine. SNP (the architecture) provides zero guarantees that the CPU runs at the same frequency as the TSC. The justification for clobbering the CPU routine was: Since the difference between CPU base and TSC frequency does not apply in this case, the same callback is being used. but that's simply not true. E.g. if APERF/MPERF is exposed to the VM, then the CPU frequency absolutely does matter. While relying on heuristics and/or the untrusted hypervisor to provide the CPU frequency isn't ideal, it's at least not outright wrong. Fixes: 73bbf3b0fbba ("x86/tsc: Init the TSC for Secure TSC guests") Cc: Nikunj A Dadhania Cc: Tom Lendacky Reviewed-by: Nikunj A Dadhania Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index ed0ac52a765e..665de1aea0ee 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2046,7 +2046,6 @@ void __init snp_secure_tsc_init(void) snp_tsc_freq_khz = SNP_SCALE_TSC_FREQ(tsc_freq_mhz * 1000, secrets->tsc_factor); - x86_platform.calibrate_cpu = securetsc_get_tsc_khz; x86_platform.calibrate_tsc = securetsc_get_tsc_khz; early_memunmap(mem, PAGE_SIZE); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385270.1627728 (Exim 4.92) (envelope-from ) id 1ws7db-0007hN-Ao; Thu, 06 Aug 2026 23:36:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385270.1627728; Thu, 06 Aug 2026 23:36:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7db-0007hC-6f; Thu, 06 Aug 2026 23:36:35 +0000 Received: by outflank-mailman (input) for mailman id 1385270; Thu, 06 Aug 2026 23:36:33 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3fhp1agYKCeEVHDQMFJRRJOH.FRPaHQ-GHYHOOLVWV.aHQSURMHFW.RUJ@flex--seanjc.bounces.google.com>) id 1ws7dZ-0007dT-KO for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dZ-00GcVS-1I for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:33 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3fhp1agYKCeEVHDQMFJRRJOH.FRPaHQ-GHYHOOLVWV.aHQSURMHFW.RUJ@flex--seanjc.bounces.google.com>) id 6a751a81-e002-0a2a0a5209dd-0a2a450c8794-0 for ; Fri, 07 Aug 2026 01:36:33 +0200 Received: from [209.85.214.198] (helo=mail-pl1-f198.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3fhp1agYKCeEVHDQMFJRRJOH.FRPaHQ-GHYHOOLVWV.aHQSURMHFW.RUJ@flex--seanjc.bounces.google.com>) id 6a751a7f-f479-0a2a450c0019-d155d6c6e99d-3 for ; Fri, 07 Aug 2026 01:36:32 +0200 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2caf4173b1cso48599815ad.3 for ; Thu, 06 Aug 2026 16:36:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059391; x=1786664191; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=JiQKL/d/a0vrWgDwSPI6P4lMZN4rNkkCCv7n67xdKiQ=; b=LR3ZngN0m0wafXvHznKSeHMsej0U8P7i0l+F9WvFiM2vXPABkAhlt2exRf4LiG2hC6 xge3aKkxCuAV3HkitlFMidsda69rjtPVNJz7WLh2k87ANrpOmluGxtrWewEt/+CswuBC GK21YW9wMpW9KGsQ5D7aI+1TOEmmguXmhjQaWV2cBNIalMIdDTlWXovVgqYCWxyixJ3J lE1dqeuPFpluWyzD2rgxSj2QdU+ywu688/t6azOfRWdHWWSVOd1S4C3qYCV8t6NwgVk+ iS9jnv3JcKW8IlZUwptc0DKPqDPWpFMmGdK7Kx7I4KcCfYdxBJRQ3htQ1ps9NLE/Pfsk DLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059391; x=1786664191; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JiQKL/d/a0vrWgDwSPI6P4lMZN4rNkkCCv7n67xdKiQ=; b=iPR9EyKUNXVQD4LIwKmhD2YotvBCEdSMcXec48rEuk8Lv8VLYI+pxDjhkj9FH7O5lo CCcaNTkFR7acMnxSP4iWXJQhE3Mt0LLyeP/mXG3++FPfgogfC89Hnse7ZzaUXpjk+1aF 6QoHBu8ZL4JXI3OXxDJ6cX9Vk7c/V0Xvu6y2dyA5RcXx+TDYBVeRR7P7vYU+Fo1T6n6j u64pZT8Ap/sqO88OV2Y0EfDLBM0GGPevGjvm9kZfKGNDjKD6EKp76KkgsjNkKegFkcxp IwLuc+AAnDfo3lnjGZqrO1qv4vcJ46ZGS7nOQ1T2/PPRDZZmutJDC2EpRnPsMA9yGmCt 5tXw== X-Forwarded-Encrypted: i=1; AHgh+RqvHo0k1SY5K3AzkZwDIQRinMBD52hifIomn2awZaTSvAPfdlzmflinyo2oIxrcCLnpZvr+PTZBUBE=@lists.xenproject.org X-Gm-Message-State: AOJu0YwmIGeV4JylSUyFChQ8A63TY0hu4ATt7DjPInf0EV4ET2Nc3znv 8USV5lgSf0BeOuJVjrnwa7xGvBes1ua/QJz/ioXMnxzhOM9uL5dj7EskE2NRHd6N926XoBgQvzc Q7M9OGg== X-Received: from pjbsr12.prod.google.com ([2002:a17:90b:4e8c:b0:383:a728:1317]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:ec86:b0:38e:bbf1:de34 with SMTP id 98e67ed59e1d1-3903c537a12mr20234960a91.7.1786059390540; Thu, 06 Aug 2026 16:36:30 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:22 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-6-seanjc@google.com> Subject: [PATCH v6 05/51] x86/sev: Mark TSC as reliable when configuring Secure TSC From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d25034/1786059393-024DFA5B-0FE27686/0/0 X-purgate-type: clean X-purgate-size: 1723 Move the code to mark the TSC as reliable from sme_early_init() to snp_secure_tsc_init(). The only reader of TSC_RELIABLE is the aptly named check_system_tsc_reliable(), which runs in tsc_init(), i.e. after snp_secure_tsc_init(). This will allow consolidating the handling of TSC_KNOWN_FREQ and TSC_RELIABLE when overriding the TSC calibration routine. Cc: Tom Lendacky Reviewed-by: Nikunj A Dadhania Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 2 ++ arch/x86/mm/mem_encrypt_amd.c | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index ecd77d3217f3..ed0ac52a765e 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2037,6 +2037,8 @@ void __init snp_secure_tsc_init(void) secrets = (__force struct snp_secrets_page *)mem; setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); + setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); + rdmsrq(MSR_AMD64_GUEST_TSC_FREQ, tsc_freq_mhz); /* Extract the GUEST TSC MHZ from BIT[17:0], rest is reserved space */ diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c index 2f8c32173972..6c3af974c7c2 100644 --- a/arch/x86/mm/mem_encrypt_amd.c +++ b/arch/x86/mm/mem_encrypt_amd.c @@ -535,9 +535,6 @@ void __init sme_early_init(void) */ x86_init.resources.dmi_setup = snp_dmi_setup; } - - if (sev_status & MSR_AMD64_SNP_SECURE_TSC) - setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); } void __init mem_encrypt_free_decrypted_mem(void) -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385267.1627700 (Exim 4.92) (envelope-from ) id 1ws7dW-0006zf-I0; Thu, 06 Aug 2026 23:36:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385267.1627700; Thu, 06 Aug 2026 23:36:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dW-0006zW-F0; Thu, 06 Aug 2026 23:36:30 +0000 Received: by outflank-mailman (input) for mailman id 1385267; Thu, 06 Aug 2026 23:36:29 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3eRp1agYKCdwQC8LHAEMMEJC.AMKVCL-BCTCJJGQRQ.VCLNPMHCAR.MPE@flex--seanjc.bounces.google.com>) id 1ws7dV-0006aA-8Y for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dU-00GcVS-D4 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:28 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3eRp1agYKCdwQC8LHAEMMEJC.AMKVCL-BCTCJJGQRQ.VCLNPMHCAR.MPE@flex--seanjc.bounces.google.com>) id 6a7519b9-e002-0a2a0a5209dd-0a2a450cbaea-48 for ; Fri, 07 Aug 2026 01:36:28 +0200 Received: from [209.85.210.200] (helo=mail-pf1-f200.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3eRp1agYKCdwQC8LHAEMMEJC.AMKVCL-BCTCJJGQRQ.VCLNPMHCAR.MPE@flex--seanjc.bounces.google.com>) id 6a751a7a-f479-0a2a450c0019-d155d2c8dcb1-3 for ; Fri, 07 Aug 2026 01:36:28 +0200 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8487ed7f7beso3066060b3a.0 for ; Thu, 06 Aug 2026 16:36:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059386; x=1786664186; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=lGVITa15iYf7ywTb6PznrnwE5mV86GVcr9KZACd8UjM=; b=P5Mmiu0kxT8zdJ6oMfjjzlKWJroER5Z8qJszJtCnI2Jxz7iUDBTB3K8wrQxURhee4y TFvC3RmcKkPExJwp7RL8zPWMmRCiodcOQYp4hnzVMwn8pK7jmpiYsFXsvvlfnBrRE/bG q9ce8HmgSIuFqBWD3UpxgqiMSioNTTffVV1fNp7bmaM2s3UjuZ+jqI/yN5S8U1sQPSxr 4z0UGnN4goFFn0TNpGEVfs3W+obqbRGp3g+wh5pTEVqhM1cYZXDCQnQRR9JWTTfwBPon hz9vbrWXQElGSmTbtYWChUBSJxIdNuPZTOMU7MW5bm+Zo5it2ypgdqSccpeS7FAr4KT1 9lng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059386; x=1786664186; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lGVITa15iYf7ywTb6PznrnwE5mV86GVcr9KZACd8UjM=; b=oYjhB2ufCvUpRN6n9DsIcH7pg4iNIqQhpMsBiDymnoHD35lFLWHQ2MTWDkdjIMYMSY PU44GNzi0qivY1e1q41wTUchIwxgxajhrI2IStJLiRfka4tdMYx70VFEvL1PC3Oa8JFO AMSSATUfkveQYVqSgEfu9kh5s2WjZrRveCuvgvo2KSc3YrSF8JzQqxXS5MhU0JhRWpWM BLxJUply9SUGlyfRXblEy4OxjTYlfaVO0xl/aMbsh8HgoLHP2Vp0cE1HoQuIYpKuEVO0 R37E6tdjW+WVqlF6z45e6YfZCRTW26d/uhIUeZzbNm5W9+R+G330RcOInG/58hklljY6 3CDw== X-Forwarded-Encrypted: i=1; AHgh+RqR3Z+eXpPjXcO1wdYD5FBGRDSIrqNWByrDds3nyojF24++tQOQpIrU+K74uCdvpY6JszardIfzgns=@lists.xenproject.org X-Gm-Message-State: AOJu0YxA284ru0lfGMc+tHOqqMJamVLF7AlI+9LCYSHVvFKum5GfTsYC Kx62gZs6B515tGmK87ZZNZGiDa2AD4q31HkW4AVumKsr/OBwel+5XEO54FuxKWKbrQXgLqdQ6DI wWptxAQ== X-Received: from pgnc18.prod.google.com ([2002:a63:7252:0:b0:c9e:6c82:64e8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1310:b0:84e:216d:7e52 with SMTP id d2e1a72fcca58-84f2e03175emr20642138b3a.14.1786059385989; Thu, 06 Aug 2026 16:36:25 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:19 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-3-seanjc@google.com> Subject: [PATCH v6 02/51] x86/apic: Add CONFIG_X86_LOCAL_APIC=n stubs for APIC timer frequency APIs From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d25034/1786059388-52530A5B-E5B61271/0/0 X-purgate-type: clean X-purgate-size: 3092 Add stubs for the apic_set_timer_frequency_{,k}hz() APIs when the kernel is built without support for a local APIC, and drop #ifdefs in callers that don't need to check CONFIG_X86_LOCAL_APIC for other reasons. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/include/asm/apic.h | 2 ++ arch/x86/kernel/cpu/vmware.c | 2 -- arch/x86/kernel/tsc.c | 2 -- arch/x86/kernel/tsc_msr.c | 2 -- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index 6946220a6008..9c5084f3317f 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -189,6 +189,8 @@ static inline void disable_local_APIC(void) { } # define setup_boot_APIC_clock x86_init_noop # define setup_secondary_APIC_clock x86_init_noop static inline void lapic_update_tsc_freq(void) { } +static inline void apic_set_timer_frequency_hz(u64 freq_hz, const char *source) { } +static inline void apic_set_timer_frequency_khz(u64 freq_khz, const char *source) { } static inline void init_bsp_APIC(void) { } static inline void apic_intr_mode_select(void) { } static inline void apic_intr_mode_init(void) { } diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 22842bf5b59e..2225df67d45f 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -422,10 +422,8 @@ static void __init vmware_platform_setup(void) x86_platform.calibrate_tsc = vmware_get_tsc_khz; x86_platform.calibrate_cpu = vmware_get_tsc_khz; -#ifdef CONFIG_X86_LOCAL_APIC /* Skip lapic calibration since we know the bus frequency. */ apic_set_timer_frequency_hz(ecx, "VMware hypervisor"); -#endif } else { pr_warn("Failed to get TSC freq from the hypervisor\n"); } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 63e26805f8dd..4392fddd616e 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -710,7 +710,6 @@ unsigned long native_calibrate_tsc(void) if (boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT) setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); -#ifdef CONFIG_X86_LOCAL_APIC /* * The local APIC appears to be fed by the core crystal clock * (which sounds entirely sensible). We can set the global @@ -718,7 +717,6 @@ unsigned long native_calibrate_tsc(void) * timer later. */ apic_set_timer_frequency_khz(crystal_khz, "CPUID 0x15/0x16"); -#endif return crystal_khz * ebx_numerator / eax_denominator; } diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c index 4bd5f2ae656b..179e3a331ef9 100644 --- a/arch/x86/kernel/tsc_msr.c +++ b/arch/x86/kernel/tsc_msr.c @@ -211,9 +211,7 @@ unsigned long cpu_khz_from_msr(void) if (freq == 0) pr_err("Error MSR_FSB_FREQ index %d is unknown\n", index); -#ifdef CONFIG_X86_LOCAL_APIC apic_set_timer_frequency_khz(freq, "MSR_FSB_FREQ"); -#endif /* * TSC frequency determined by MSR is always considered "known" -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385272.1627746 (Exim 4.92) (envelope-from ) id 1ws7de-0008Bc-0D; Thu, 06 Aug 2026 23:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385272.1627746; Thu, 06 Aug 2026 23:36:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dd-0008Ak-QD; Thu, 06 Aug 2026 23:36:37 +0000 Received: by outflank-mailman (input) for mailman id 1385272; Thu, 06 Aug 2026 23:36:35 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3gBp1agYKCeMXJFSOHLTTLQJ.HTRcJS-IJaJQQNXYX.cJSUWTOJHY.TWL@flex--seanjc.bounces.google.com>) id 1ws7db-0007kf-Nb for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7db-00GcVS-4X for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:35 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3gBp1agYKCeMXJFSOHLTTLQJ.HTRcJS-IJaJQQNXYX.cJSUWTOJHY.TWL@flex--seanjc.bounces.google.com>) id 6a751a81-e002-0a2a0a5209dd-0a2a450c8794-2 for ; Fri, 07 Aug 2026 01:36:35 +0200 Received: from [209.85.214.197] (helo=mail-pl1-f197.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3gBp1agYKCeMXJFSOHLTTLQJ.HTRcJS-IJaJQQNXYX.cJSUWTOJHY.TWL@flex--seanjc.bounces.google.com>) id 6a751a81-f479-0a2a450c0019-d155d6c5e156-3 for ; Fri, 07 Aug 2026 01:36:34 +0200 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cee1ec30f2so33068775ad.3 for ; Thu, 06 Aug 2026 16:36:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059393; x=1786664193; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=AA+qmVUXq1UZoUYGqhY11Guml9As0mrU+L3gWPkVgC8=; b=ixyfPz9/AtOU4gqhTNmQ7HEQbdluEmTCxFLp+2HsWDMb5m45kBlLXlQNlFII7dXEX7 pgYR+A0LWZO3abD7o0wWkpnenkpEbPLUidL9hw1t2FK0nv06h1mVGl8Bwft1b/WpDRIH e5jL/4X0cXdPjikP9B8ohzyJWqzDOU04M1IHCEU2YtUOT2udCqd7TPVol6KwRNmV4ENf Wl1lNsTWaZLxspm4OjCVjKAlKpYRS1PAGeaA2QhGxqcogoZ+Rycrmktvhtjp1F8K3xf/ d4jFkOZ7UnCDsQIWLXHgi969584ZimWhdcmlfElI7fxUU1McJ+vz8YhDRrTRi9wTHt2Z wlmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059393; x=1786664193; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AA+qmVUXq1UZoUYGqhY11Guml9As0mrU+L3gWPkVgC8=; b=WRg7SJ5wxcOo+Ls7TCcws1EJcOE1XljSG8YzVyzG8rQBN4v9mY1hfSXWYJzW/IOp+X j5xOwqO/t7mqGe2MHUDdYLlwQpmhj5XSI7ni8j2zZZPjR+lt6kPQcvGtALfH654Ax/bD lPzW3czQm3dmb8YdMMD230rVTAxN+ef335KPXEyC0+ne8bAnaCV6vAaoviB2XZedLdqC gYdNoycOPyKAZ6XxyMs82yON0lKX6rCjvrxMP/SXhc3wmSFUJZ44OpJp2O0IhPOt+wpY Tv75sMDTKXbTjkroAG2UGkn0aap6Hc3TLCgnYI0m+rLY0k3WNk+Hj6IFdaD/bNE0rQNx 1rdw== X-Forwarded-Encrypted: i=1; AHgh+Rp4n2aiK4iAKjkEpEHpDdP8nwPGxKU+5ypyrc+u3BpXTc0dcktfAPGJq+LcWuX+NWfxhTr9hR3rg8A=@lists.xenproject.org X-Gm-Message-State: AOJu0YzKZGBU/gjf9tvDNzYJjflLE7MAWqrsYzXPJ05Zacr2s1KvoPRz qymHYX03/AuWt8BFGNKoAIiK8cXpEbHscYkJJjl24eG02b292t8VWOKrgjKibWnoImK9KCsgFPV kPzXbkg== X-Received: from plbjc21.prod.google.com ([2002:a17:903:25d5:b0:2ca:d66c:97b2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ef0a:b0:2c9:c517:d070 with SMTP id d9443c01a7336-2d0ca7afebcmr224927325ad.3.1786059392825; Thu, 06 Aug 2026 16:36:32 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:24 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-8-seanjc@google.com> Subject: [PATCH v6 07/51] x86/sev: Move check for SNP Secure TSC support to tsc_early_init() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d25034/1786059395-77ED2A5B-32AC4DBD/0/0 X-purgate-type: clean X-purgate-size: 1583 Move the check on having a Secure TSC to the common tsc_early_init() so that it's obvious that having a Secure TSC is conditional, and to prepare for adding TDX to the mix (blindly initializing *both* SNP and TDX TSC logic looks especially weird). No functional change intended. Cc: Tom Lendacky Reviewed-by: Nikunj A Dadhania Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 3 --- arch/x86/kernel/tsc.c | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 665de1aea0ee..403dcea86452 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2025,9 +2025,6 @@ void __init snp_secure_tsc_init(void) unsigned long tsc_freq_mhz; void *mem; - if (!cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) - return; - mem = early_memremap_encrypted(sev_secrets_pa, PAGE_SIZE); if (!mem) { pr_err("Unable to get TSC_FACTOR: failed to map the SNP secrets page.\n"); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 09bf10f322ba..c710c71a1bdf 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1509,7 +1509,8 @@ void __init tsc_early_init(void) if (is_early_uv_system()) return; - snp_secure_tsc_init(); + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) + snp_secure_tsc_init(); if (!determine_cpu_tsc_frequencies(true)) return; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385274.1627751 (Exim 4.92) (envelope-from ) id 1ws7de-0008Fe-GG; Thu, 06 Aug 2026 23:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385274.1627751; Thu, 06 Aug 2026 23:36:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7de-0008EQ-6p; Thu, 06 Aug 2026 23:36:38 +0000 Received: by outflank-mailman (input) for mailman id 1385274; Thu, 06 Aug 2026 23:36:37 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3gRp1agYKCeQYKGTPIMUUMRK.IUSdKT-JKbKRROYZY.dKTVXUPKIZ.UXM@flex--seanjc.bounces.google.com>) id 1ws7dc-0007wv-Sl for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dc-00GcaU-9U for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:36 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3gRp1agYKCeQYKGTPIMUUMRK.IUSdKT-JKbKRROYZY.dKTVXUPKIZ.UXM@flex--seanjc.bounces.google.com>) id 6a751a49-bab6-0a2a0a5309dd-0a2a4501d568-40 for ; Fri, 07 Aug 2026 01:36:36 +0200 Received: from [209.85.210.200] (helo=mail-pf1-f200.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3gRp1agYKCeQYKGTPIMUUMRK.IUSdKT-JKbKRROYZY.dKTVXUPKIZ.UXM@flex--seanjc.bounces.google.com>) id 6a751a82-5984-0a2a45010019-d155d2c8bc06-3 for ; Fri, 07 Aug 2026 01:36:36 +0200 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-848d21bbb55so4633309b3a.0 for ; Thu, 06 Aug 2026 16:36:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059394; x=1786664194; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=kH88onT2XQPjPMTP9foWuf2kpVwGIl3qVDy3ZQ/XBNk=; b=WgpBj2tnuNJ8SKIkDltzyjZYZdaZ4+v5LrHck/UlzPGVAaC0Y+kWkaw7cQoy0DjGB/ Koa0/gX/mEToB0MINePIOkunIjb6f6S7sdX0pL1Fy67Y9pARoXS5xt4df38bIU6LwBAd maiiV7PBAT3ShzRssQ/ghWB8VQLcM+zhMAraRJ95hmS6IBKFowXlwJBPpPwSBaetWY/U nqnM5X6M9fSZvCaCJS0kBFWoxZ44BehTNxPe1eiAhL+XKnZoNX3F+SxvUXp606yW6Nm/ XwYAXiihNRxJDzwwVvmRDnWjFSOxfreg2UYK/RMOx2wPux5Bijeq6bxP44qD1IuF9I3s apQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059394; x=1786664194; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kH88onT2XQPjPMTP9foWuf2kpVwGIl3qVDy3ZQ/XBNk=; b=ZQuOQh9JBLwvjrb/DXSmp3fLrCv4pUxkuiUf871DeJ3ItpP62L2Lt+0TcJT1+t6NvY 4hSz3K6cpOpj1bQhxtgKMf1ZaB+aoi9QIqEIOkCN/kYaCMZSfkYXn7jJd9efzvWkRMUb uw3D05cEJw2ZqnE42/5nIquxx5vVkpSUFiAdC4EXTD+eVlfiEfym4soIF7vpb5jRKPfh RFSkDVOpfeGaE/edDg8gdGvImdltTnrluVL8QT/cqN2bHQGKNrQMFKCFzsPERcxdithO Ev8GdVs3oGqND+WUJhqhueUfiTmiTEj1b8N1jGxDNKCRpAO4fPA9R9UUk5VFMAv35I01 rFHg== X-Forwarded-Encrypted: i=1; AHgh+RpZMiycyxlC7LBHRni2KqoN/d82d1ecAJ8JS3qiAH9HczEmWCxym2W6TbBOplgdppSWTBXpyZ3YY5E=@lists.xenproject.org X-Gm-Message-State: AOJu0YyAvwnQIc5B1tAHSQNLfEbgzMJK0aYXa5SJNUEK25YUzIQwuId5 U2GSOvcLaQPcM2Tg6UQaq6t35I+jfQlpCieiwIKZ0QlBtz275PP3T/AGEm9ako0ZGOR0M1g2bC2 lzoyWEA== X-Received: from pgei3.prod.google.com ([2002:a05:6a02:5263:b0:c82:7761:9936]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1ca2:b0:847:8ccc:d7c6 with SMTP id d2e1a72fcca58-84f2e0278d5mr21014018b3a.31.1786059393911; Thu, 06 Aug 2026 16:36:33 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:25 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-9-seanjc@google.com> Subject: [PATCH v6 08/51] x86/sev: Shove SNP's secure/trusted TSC frequency directly into "calibration" From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1786059396-BEA66757-721236B2/0/0 X-purgate-type: clean X-purgate-size: 7245 As a first step towards dropping .calibrate_{cpu,tsc}() and explicitly defining precedence/priority for "calibration" routines, pass the secure TSC frequency obtained from SNP firmware directly to determine_cpu_tsc_frequencies() instead of overriding the .calibrate_tsc() hook. Unlike the native calibration routines, all of the paravirtual overrides, including SNP and TDX, are constant in the sense that the frequency provided by the hypervisor or trusted firmware is fixed, known, and always available during early boot. More importantly, for CoCo (SNP and TDX) VMs, it's imperative that the kernel uses the frequency provided by the trusted firmware, not by the untrusted hypervisor. Enforcing the priority between sources by carefully ordering seemingly unrelated init calls, so that the trusted override "wins", is brittle and all but impossible to follow. Explicitly ignore tsc_early_khz if the exact TSC frequency was obtained from trusted firmware, as per commit bd35c77e32e4 ("x86/tsc: Add tsc_early_khz command line parameter"), the goal of the param is to play nice with setups that provide partial frequency information in CPUID, i.e. is NOT intended to be a hard override. Neither SNP's secure TSC nor TDX was supported when commit bd35c77e32e4 landed back in 2020, i.e. lack of consideration for the interaction was purely due to oversight when SNP and TDX support came along. Reviewed-by: Nikunj A Dadhania Tested-by: Nikunj A Dadhania Signed-off-by: Sean Christopherson --- .../admin-guide/kernel-parameters.txt | 4 +++ arch/x86/coco/sev/core.c | 14 +++-------- arch/x86/include/asm/sev.h | 4 +-- arch/x86/kernel/tsc.c | 25 ++++++++++++++----- 4 files changed, 29 insertions(+), 18 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 87bb1fb31696..aa4eb568d9fb 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -7946,6 +7946,10 @@ Kernel parameters with CPUID.16h support and partial CPUID.15h support. Format: + Note, tsc_early_khz is ignored if the TSC frequency is + provided by trusted firmware when running as an SNP + guest. + tsx= [X86] Control Transactional Synchronization Extensions (TSX) feature in Intel processors that support TSX control. diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 403dcea86452..bc5ae9ef74da 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -99,7 +99,6 @@ static const char * const sev_status_feat_names[] = { */ static u64 snp_tsc_scale __ro_after_init; static u64 snp_tsc_offset __ro_after_init; -static unsigned long snp_tsc_freq_khz __ro_after_init; DEFINE_PER_CPU(struct sev_es_runtime_data*, runtime_data); DEFINE_PER_CPU(struct sev_es_save_area *, sev_vmsa); @@ -2014,15 +2013,10 @@ void __init snp_secure_tsc_prepare(void) pr_debug("SecureTSC enabled"); } -static unsigned long securetsc_get_tsc_khz(void) -{ - return snp_tsc_freq_khz; -} - -void __init snp_secure_tsc_init(void) +unsigned int __init snp_secure_tsc_init(void) { + unsigned long snp_tsc_freq_khz, tsc_freq_mhz; struct snp_secrets_page *secrets; - unsigned long tsc_freq_mhz; void *mem; mem = early_memremap_encrypted(sev_secrets_pa, PAGE_SIZE); @@ -2043,7 +2037,7 @@ void __init snp_secure_tsc_init(void) snp_tsc_freq_khz = SNP_SCALE_TSC_FREQ(tsc_freq_mhz * 1000, secrets->tsc_factor); - x86_platform.calibrate_tsc = securetsc_get_tsc_khz; - early_memunmap(mem, PAGE_SIZE); + + return snp_tsc_freq_khz; } diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h index 594cfa19cbd4..05ebf0b73ef4 100644 --- a/arch/x86/include/asm/sev.h +++ b/arch/x86/include/asm/sev.h @@ -530,7 +530,7 @@ int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_req *req int snp_svsm_vtpm_send_command(u8 *buffer); void __init snp_secure_tsc_prepare(void); -void __init snp_secure_tsc_init(void); +unsigned int snp_secure_tsc_init(void); enum es_result savic_register_gpa(u64 gpa); enum es_result savic_unregister_gpa(u64 *gpa); u64 savic_ghcb_msr_read(u32 reg); @@ -637,7 +637,7 @@ static inline int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_req *req) { return -ENODEV; } static inline int snp_svsm_vtpm_send_command(u8 *buffer) { return -ENODEV; } static inline void __init snp_secure_tsc_prepare(void) { } -static inline void __init snp_secure_tsc_init(void) { } +static inline unsigned int __init snp_secure_tsc_init(void) { return 0; } static inline void sev_evict_cache(void *va, int npages) {} static inline enum es_result savic_register_gpa(u64 gpa) { return ES_UNSUPPORTED; } static inline enum es_result savic_unregister_gpa(u64 *gpa) { return ES_UNSUPPORTED; } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index c710c71a1bdf..6898584610a7 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1440,15 +1440,16 @@ static int __init init_tsc_clocksource(void) */ device_initcall(init_tsc_clocksource); -static bool __init determine_cpu_tsc_frequencies(bool early) +static bool __init determine_cpu_tsc_frequencies(bool early, + unsigned int known_tsc_khz) { /* Make sure that cpu and tsc are not already calibrated */ WARN_ON(cpu_khz || tsc_khz); if (early) { cpu_khz = x86_platform.calibrate_cpu(); - if (tsc_early_khz) - tsc_khz = tsc_early_khz; + if (known_tsc_khz) + tsc_khz = known_tsc_khz; else tsc_khz = x86_platform.calibrate_tsc(); } else { @@ -1503,6 +1504,8 @@ static void __init tsc_enable_sched_clock(void) void __init tsc_early_init(void) { + unsigned int known_tsc_khz = 0; + if (!boot_cpu_has(X86_FEATURE_TSC)) return; /* Don't change UV TSC multi-chassis synchronization */ @@ -1510,9 +1513,19 @@ void __init tsc_early_init(void) return; if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) - snp_secure_tsc_init(); + known_tsc_khz = snp_secure_tsc_init(); - if (!determine_cpu_tsc_frequencies(true)) + /* + * Ignore the user-provided TSC frequency if the exact frequency was + * obtained from trusted firmware, as the user-provided frequency is + * intended as a "starting point", not a known, guaranteed frequency. + */ + if (!known_tsc_khz) + known_tsc_khz = tsc_early_khz; + else if (tsc_early_khz) + pr_err("Ignoring 'tsc_early_khz' in favor of trusted firmware.\n"); + + if (!determine_cpu_tsc_frequencies(true, known_tsc_khz)) return; tsc_enable_sched_clock(); } @@ -1533,7 +1546,7 @@ void __init tsc_init(void) if (!tsc_khz) { /* We failed to determine frequencies earlier, try again */ - if (!determine_cpu_tsc_frequencies(false)) { + if (!determine_cpu_tsc_frequencies(false, 0)) { mark_tsc_unstable("could not calculate TSC khz"); setup_clear_cpu_cap(X86_FEATURE_TSC_DEADLINE_TIMER); return; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385265.1627683 (Exim 4.92) (envelope-from ) id 1ws7dV-0006aJ-0d; Thu, 06 Aug 2026 23:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385265.1627683; Thu, 06 Aug 2026 23:36:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dU-0006aB-TV; Thu, 06 Aug 2026 23:36:28 +0000 Received: by outflank-mailman (input) for mailman id 1385265; Thu, 06 Aug 2026 23:36:27 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3dxp1agYKCdoOA6JF8CKKCHA.8KITAJ-9ARAHHEOPO.TAJLNKFA8P.KNC@flex--seanjc.bounces.google.com>) id 1ws7dT-0006Zy-Lz for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dS-00BpFw-9T for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:26 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3dxp1agYKCdoOA6JF8CKKCHA.8KITAJ-9ARAHHEOPO.TAJLNKFA8P.KNC@flex--seanjc.bounces.google.com>) id 6a751a68-2eae-0a2a0a5409dd-0a2a4503dca0-10 for ; Fri, 07 Aug 2026 01:36:26 +0200 Received: from [209.85.216.69] (helo=mail-pj1-f69.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3dxp1agYKCdoOA6JF8CKKCHA.8KITAJ-9ARAHHEOPO.TAJLNKFA8P.KNC@flex--seanjc.bounces.google.com>) id 6a751a78-fae8-0a2a45030019-d155d845e936-3 for ; Fri, 07 Aug 2026 01:36:26 +0200 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38dbf293831so5540470a91.3 for ; Thu, 06 Aug 2026 16:36:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:Mime-Version:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059384; x=1786664184; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:mime-version:date :reply-to:from:to:cc:subject:date:message-id:reply-to:content-type; bh=keDa3uiMUyNdngDUOX3bQBFQQi+1yM63Rcdpk9ukwB4=; b=evNv5RETlj1UOHaSOKKCIijsDCTxuFZDIAZT3RVZZLC5O6ov2gBfb8+QnUjAWSx+Sg lKcA1ZpM5Kp1DmprbJ7LuHbp05r6bLJfcW1pjPgnKVm9olO81iDNlew5MimIrOnaEDQt JML5n+xAmY+7syhDwI12nFuqbKO+f0R14jRMLrP+dodG/VvW0FBcout0pr7emD1FTl0U VWtjKgDf0+aUEKrFfoX8sDmlabfHyugIWy3hV3wprr4r4/xatFHuU6Po86yNK4vD3DO4 MQ9nWf18H1/hh2aqU/tK1xhi0/YnN4TmRL6AbtbNYKgXBdEqyubzSdkY9EOnvSQnRoEy oSBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059384; x=1786664184; h=content-type:cc:to:from:subject:message-id:mime-version:date :reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=keDa3uiMUyNdngDUOX3bQBFQQi+1yM63Rcdpk9ukwB4=; b=NLQpp7U35yRcC+4JqKrhWnDeHPzIVmso/SDR/A7B0OSbwAUJ5qVFK165T51kZVaSGi BZplOnYGaHZpxNyk6Of59e9H/bqCW21EgpZ2U3AKpAWct6BGnWXoFKZa5RM1cey+aH4y fmRPP252nNPQy8mMJ8Rtc2nD4ee1LW7PhVHEqap822YLvOQ6SJDbp26pT/8WIdEhvfIT ND8jPoO7SBmpFmWAeRr/S55Vs91LFgy5VXDG7s1kuQwbRbQzTD4p1hkUrM2uDEUiCyv1 a8yNRHil3AbQDWLGO9fol4TMxe3FYx/ESk6FWApJwDcoEsoBrF5yIyyInnCQgvDx/56w K64w== X-Forwarded-Encrypted: i=1; AHgh+RrC8bAWgq5QcqyZ54Do+hmbbJR6LWfMeIlRR7u+qAYTM56/bP5glrhRCx9/UFMaUxWqfFjCb7jjzOM=@lists.xenproject.org X-Gm-Message-State: AOJu0YxB+yCS0RNvhEOs8ffWXO2QqK/PU4Rtwf5JZJUHy/gJigVk6uut 9lsXOKP3NIX7CPFvgbsep0T5YiXWtXWqQjQJSoAd0IR+IK7fltLQLSDxvSiOFZsJoUvzecYeabw YCoeIJQ== X-Received: from pjnu1.prod.google.com ([2002:a17:90a:8901:b0:383:c59b:fc00]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:278c:b0:381:792d:f993 with SMTP id 98e67ed59e1d1-3903c5bf6fbmr20025179a91.17.1786059383863; Thu, 06 Aug 2026 16:36:23 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:17 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-1-seanjc@google.com> Subject: [PATCH v6 00/51] x86: Try to wrangle PV clocks vs. TSC From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1786059386-766FB4E9-CEA7D76F/0/0 X-purgate-type: clean X-purgate-size: 11039 The primary goal of this series to fix flaws with SNP and TDX guests where a PV clock provided by the untrusted hypervisor is used instead of the secure TSC that is controlled by trusted firmware. The secondary goal is modernize running under KVM. Currently, KVM guests will use TSC for clocksource, but not sched_clock. And Linux-as-a-KVM-guest doesn't support paravirt enumeration of the TSC/APIC frequencies, even though QEMU provides that information by default. The tertiary goal is to clean up the PV clock code to deduplicate logic across hypervisors, and to hopefully make it all easier to maintain going forward. The quaternary goal is to clean up the TSC calibration code, which was made stupidly hard to follow by hypervisor code mixing in with the native calibration routines, instead of being implemented as a pure alternative. Note, the VMware and Xen changes still probably should get acks from those maintainers, as my understanding of what they're trying to do may be flawed. Lots more background on the SNP/TDX motiviation: https://lore.kernel.org/all/20250106124633.1418972-13-nikunj@amd.com As before, I deliberately omitted jailhouse-dev@googlegroups.com from the To/Cc, as those emails bounced on v1, AFAICT nothing has changed. v5: - Use cpu_feature_enabled() instead of boot_cpu_has(). [Boris] - WARN if recalibrate_cpu_khz() runs on a system with TSC_KNOWN_FREQ. [Thomas] - Opportunistically drop a line break in native_calibrate_tsc(). [Thomas] - Rely on callers of cpuid_get_tsc_info() to check the result instead of unnecessarily zeroing the structure. [Boris] - Ignore tsc_early_khz if the TSC frequency is provided by trusted firmware or by the hypervisor. [Thomas, Sashiko] - Cache CPUID output in acrn_init_platform() to avoid introducing a transient bug where TSC_KNOWN_FREQ could be set even if the ACRN hypervisor didn't actually provide the frequency. [Sashiko] - Drop kvmclock's useless/dead check_tsc_unstable() call (it occurs before the command line parameter is parsed). [Sashiko] - Add helpers to set lapic_timer_period, to fix not-so-theoretical overflow in the various "khz * 1000 / HZ" patterns. [Sashiko] - Drop the "x86/xen: Obtain TSC frequency from CPUID if present" patch as it doesn't have any dependencies/conflicts on/with this series, and Sashiko had concerns about the assumptions it was making. [Sashiko] - Collect reviews. [David] (Kirill's got dropped because the patch he reviewed got completely rewritten). v4: - Use x86_init_noop() to skip save/restore on VMware and Xen instead of nullifying x86_platform.{save,restore}_sched_clock_state. [Sashiko] - Use '0' to indicate "failure" when getting the CPU frequency from CPUID, to avoid using an out-param and thus make it all but impossible to unintentionally clobber the global cpu_khz (which v3 did). [Sashiko] - Rename cpuid_get_cpu_freq() => __cpu_khz_from_cpuid() to capture its relationship with cpu_khz_from_cpuid(). - Compute lapic_timer_period in units of ticks, not Khz. [Sashiko] - Kill off x86_platform_ops.calibrate_{cpu,tsc}(), and instead use dedicated hooks for hypervisor code, and direct calls for TDX and SNP. [David, loosely] - Drop SNP's secure TSC override of _CPU_ calibration, as there's zero evidence it's justified or a net positive. - Collect reviews/acks. [David, Wei] - Decouple getting TSC/APIC frequencies from KVM PV CPUID from kvmclock. [David] - Fix an amusing number of Opportunistically misspellings. [David] - Set kvm_sched_clock_offset _before_ registering kvmclock as sched_clock, and add a comment to guard against future goofs. [Sashiko] - Keep "setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE)" in Hyper-V's handling of HV_ACCESS_TSC_INVARIANT, as it's technically possible to have a VM with HV_ACCESS_TSC_INVARIANT but not HV_ACCESS_FREQUENCY_MSRS. Though as a _very_ nice side effect of using dedicated sequencing for selecting the TSC frequency source, this would have naturally happened anyways. [Sashiko] v3: - https://lore.kernel.org/all/20260515191942.1892718-1-seanjc@google.com - Collect reviews. [Michael, Thomas] - Use Hyper-V reference counter / refcounter instead of Hyper-V timer. [Michael] - Use the paravirt CPUID interface first proposed by VMware for KVM's "official" mechanism for communicating frequency to KVM-aware guests, instead of abusing Intel's CPUID leafs. [David] - Deal with paravirt code being moved into asm/timers.h and arch/x86/kernel/tsc.c. v2: - https://lore.kernel.org/all/Z8YWttWDtvkyCtdJ@google.com - Add struct to hold the TSC CPUID output. [Boris] - Don't pointlessly inline the TSC CPUID helpers. [Boris] - Fix a variable goof in a helper, hopefully for real this time. [Dan] - Collect reviews. [Nikunj] - Override the sched_clock save/restore hooks if and only if a PV clock is successfully registered. - During resome, restore clocksources before reading persistent time. - Clean up more warts created by kvmclock. - Fix more bugs in kvmclock's suspend/resume handling. - Try to harden kvmclock against future bugs. v1: https://lore.kernel.org/all/20250201021718.699411-1-seanjc@google.com David Woodhouse (2): KVM: x86: Officially define CPUID 0x40000010 as PV Timing Info (TSC and Bus) x86/kvm: Obtain TSC frequency from PV CPUID if present Sean Christopherson (49): x86/apic: Provide helpers to set local APIC timer frequency in hz and khz x86/apic: Add CONFIG_X86_LOCAL_APIC=n stubs for APIC timer frequency APIs x86/tsc: Ensure that TSC recalibration doesn't run if TSC frequency is known x86/tsc: Restrict recalibrate_cpu_khz() export to p4-clockmod and powernow-k7 x86/sev: Mark TSC as reliable when configuring Secure TSC x86/sev: Don't override CPU frequency calibration for SNP's Secure TSC x86/sev: Move check for SNP Secure TSC support to tsc_early_init() x86/sev: Shove SNP's secure/trusted TSC frequency directly into "calibration" x86/tsc: Add a standalone helper for getting TSC info from CPUID.0x15 x86/tdx: Force TSC frequency with CPUID-based info provided by the TDX-Module x86/tsc: Add dedicated hypervisor hooks for getting known TSC/CPU frequencies x86/acrn: Register TSC/CPU frequency callbacks iff frequency is actually in CPUID x86/acrn: Mark TSC frequency as known when using ACRN for calibration x86/tsc: Consolidate forcing of X86_FEATURE_TSC_KNOWN_FREQ for PV code x86/tsc: Kill off x86_platform_ops.calibrate_{cpu,tsc}() hooks x86/tsc: Rename pit_hpet_ptimer_calibrate_cpu() => native_calibrate_cpu_late() x86/tsc: Fold native_calibrate_cpu() into recalibrate_cpu_khz() x86/kvmclock: Rename kvm_get_tsc_khz() to kvmclock_get_tsc_khz() x86/kvmclock: Drop dead check on TSC being unstable during kvmclock_init() x86/kvm: Mark TSC as reliable when it's constant and nonstop x86/tsc: Add standalone helper for getting CPU frequency from CPUID x86/kvm: Get CPU base frequency from CPUID when it's available clocksource: hyper-v: Register sched_clock save/restore iff it's necessary clocksource: hyper-v: Drop wrappers to sched_clock save/restore helpers clocksource: hyper-v: Don't save/restore TSC offset when using HV sched_clock x86/kvmclock: Setup kvmclock for secondary CPUs iff CONFIG_SMP=y x86/kvm: Don't disable kvmclock on BSP in syscore_suspend() x86/paravirt: Remove unnecessary PARAVIRT=n stub for paravirt_set_sched_clock() x86/paravirt: Move handling of unstable PV clocks into paravirt_set_sched_clock() x86/kvmclock: Move sched_clock save/restore helpers up in kvmclock.c x86/xen/time: NOP-ify x86_platform's sched_clock save/restore hooks x86/vmware: NOP-ify save/restore hooks when using VMware's sched_clock x86/tsc: WARN if TSC sched_clock save/restore used with PV sched_clock x86/paravirt: Pass sched_clock save/restore helpers during registration x86/kvmclock: Move kvm_sched_clock_init() down in kvmclock.c x86/xen/time: Mark xen_setup_vsyscall_time_info() as __init x86/pvclock: Mark setup helpers and related various as __init/__ro_after_init x86/pvclock: WARN if pvclock's valid_flags are overwritten x86/kvmclock: Refactor handling of PVCLOCK_TSC_STABLE_BIT during kvmclock_init() timekeeping: Resume clocksources before reading persistent clock x86/kvmclock: Hook clocksource.suspend/resume when kvmclock isn't sched_clock x86/kvmclock: WARN if wall clock is read while kvmclock is suspended x86/paravirt: Mark __paravirt_set_sched_clock() as __init x86/paravirt: Plumb a return code into __paravirt_set_sched_clock() x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC x86/kvmclock: Use TSC for sched_clock if it's constant and non-stop x86/kvmclock: Plumb in AP-online and BSP-resume to kvmlock, for documentation x86/paravirt: Move using_native_sched_clock() stub into timer.h x86/kvm: Get local APIC bus frequency from PV CPUID Timing Info .../admin-guide/kernel-parameters.txt | 5 + Documentation/virt/kvm/x86/cpuid.rst | 12 + arch/x86/coco/sev/core.c | 21 +- arch/x86/coco/tdx/tdx.c | 19 +- arch/x86/include/asm/acrn.h | 5 - arch/x86/include/asm/apic.h | 5 +- arch/x86/include/asm/kvm_para.h | 12 +- arch/x86/include/asm/sev.h | 4 +- arch/x86/include/asm/tdx.h | 2 + arch/x86/include/asm/timer.h | 15 +- arch/x86/include/asm/tsc.h | 10 +- arch/x86/include/asm/x86_init.h | 8 +- arch/x86/include/uapi/asm/kvm_para.h | 11 + arch/x86/kernel/apic/apic.c | 19 +- arch/x86/kernel/cpu/acrn.c | 14 +- arch/x86/kernel/cpu/mshyperv.c | 70 +----- arch/x86/kernel/cpu/vmware.c | 19 +- arch/x86/kernel/jailhouse.c | 9 +- arch/x86/kernel/kvm.c | 101 ++++++-- arch/x86/kernel/kvmclock.c | 208 +++++++++++------ arch/x86/kernel/pvclock.c | 9 +- arch/x86/kernel/tsc.c | 218 +++++++++++------- arch/x86/kernel/tsc_msr.c | 4 +- arch/x86/kernel/x86_init.c | 2 - arch/x86/mm/mem_encrypt_amd.c | 3 - arch/x86/xen/time.c | 14 +- drivers/clocksource/hyperv_timer.c | 38 ++- include/clocksource/hyperv_timer.h | 2 - kernel/time/timekeeping.c | 9 +- 29 files changed, 547 insertions(+), 321 deletions(-) base-commit: 6949feed6e32823a6628873000602988a4cafe06 -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385268.1627710 (Exim 4.92) (envelope-from ) id 1ws7dX-0007Cp-Qh; Thu, 06 Aug 2026 23:36:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385268.1627710; Thu, 06 Aug 2026 23:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dX-0007Ci-Me; Thu, 06 Aug 2026 23:36:31 +0000 Received: by outflank-mailman (input) for mailman id 1385268; Thu, 06 Aug 2026 23:36:30 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3exp1agYKCd4SEANJCGOOGLE.COMXEN-DEVELLISTS.XENPROJECT.ORG@flex--seanjc.bounces.google.com>) id 1ws7dW-0006wt-B6 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dV-00BpFw-OJ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:29 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3exp1agYKCd4SEANJCGOOGLE.COMXEN-DEVELLISTS.XENPROJECT.ORG@flex--seanjc.bounces.google.com>) id 6a751a68-2eae-0a2a0a5409dd-0a2a4503dca0-12 for ; Fri, 07 Aug 2026 01:36:29 +0200 Received: from [209.85.210.200] (helo=mail-pf1-f200.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3exp1agYKCd4SEANJCGOOGLE.COMXEN-DEVELLISTS.XENPROJECT.ORG@flex--seanjc.bounces.google.com>) id 6a751a7c-fae8-0a2a45030019-d155d2c8b58b-3 for ; Fri, 07 Aug 2026 01:36:29 +0200 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8486ffba174so6231388b3a.1 for ; Thu, 06 Aug 2026 16:36:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059388; x=1786664188; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=2SJsprQma6tQ2oU494vKbTkDMI4EE2yRA8rYyHQJqoI=; b=n4Hy1f/s0tj0vRdDTiDRCu5VS4gfXmQLfJcrwbMBZNuQ1kBE1EfSQHspcOCwyptVeh 51Lzvt8S3VPVfbT1F1KoYQjCe/GhJQG6viwMeGV3xGi+N8MfMTI0ceECgJqTDZkjECtU ta+xAIrWdDfw7GN5P1dsBm9AeLTkOX4Z608KT1OZP7r17f/3zmEiC+PpJufshDrPCcL8 tGKt+doHE/NO9mcYomTCl7se1XT+TxBEY+nSB284+o97Nr8HdRqRYJ+CZuMFPnni1fTm THxCHFxaraKTcWIEQNwuh+S5VomxDPy9qjBMt6nWTIB9MqrXBIbjB/ttQV1/o6e3dV3G nmvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059388; x=1786664188; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2SJsprQma6tQ2oU494vKbTkDMI4EE2yRA8rYyHQJqoI=; b=ibixDnDakB/lb5yqDOOHzevpuGGtGIdDaQxW8FPvaeIqVkGWxKD8EIXxhpSIO0gVm0 m56uSa7nzD0vMWoGt0a9AltgTlUla5KJ9AcART2v5vPiuMZBsDAAncCqX23jFFjGML7t 79MBakHKYWFf/aTPE4ZU3zSnLIVH3rfdrtdANNyzn9a02MRy2EvW7bzWnqGfN+gJ/88N 551vMaoztgi5MMyy85StUw6+04UNsj/C41k7WOGI0PppBN5sTl64GdI8H1ejQSPm8gSQ mQz/Jhrk8WVIgkckiSRkjnQg15n6yHXqkvQRM4NYlBkKIbS9gLLPNzGhAF4DSY4Ra/Z3 inKw== X-Forwarded-Encrypted: i=1; AHgh+RrLYLgL9ESakyj5CZCuWRQ995Lii1QhVLGVwbR4CB7M1A9DWIIago0RWoz3gNsmPF36YLRZSQXXfj4=@lists.xenproject.org X-Gm-Message-State: AOJu0YysDo6Y9Z8pw9wMpQw+qnck42nc+ZdbVbArX7jONWwCm14O+GIr vQFkmRZ1zZYhYv19C9zGqQ24hqlINTTNCBzsPVxSZYWgRAfE3C9WU5Lx+JrcN0B4lwLWSMTextw KkRimug== X-Received: from pglr15.prod.google.com ([2002:a63:514f:0:b0:c9a:7d72:c316]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2d0c:b0:84e:2382:f4f0 with SMTP id d2e1a72fcca58-84f2dfc8ed4mr19812672b3a.4.1786059387185; Thu, 06 Aug 2026 16:36:27 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:20 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-4-seanjc@google.com> Subject: [PATCH v6 03/51] x86/tsc: Ensure that TSC recalibration doesn't run if TSC frequency is known From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1786059389-764FC4E9-10560814/0/0 X-purgate-type: clean X-purgate-size: 1414 When attempting TSC recalibration post-boot, which is only done for ancient CPUS (P4 and K7) on SMP=n kernels, assert that the TSC frequency isn't known (explicitly provided by hardware) by way of MSR or CPUID, and bail if the impossible happens. In practice, recalibration and TSC_KNOWN_FREQ are mutually exclusive, as TSC_KNOWN_FREQ will only be set when running on hardware that was released decades after recalibration was obsoleted, but but it's hard to see that, especially when looking at just the TSC code. Note, the WARN can likely be tripped by running in a virtual machine and concocting an impossible CPU model, e.g. by combining a P4 signature with CPUID 0x15. This is working as intended, as such a virtual CPU model is wildly out-of-spec and is not supported. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 4392fddd616e..bc4348585194 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -930,6 +930,9 @@ void recalibrate_cpu_khz(void) if (!boot_cpu_has(X86_FEATURE_TSC)) return; + if (WARN_ON_ONCE(cpu_feature_enabled(X86_FEATURE_TSC_KNOWN_FREQ))) + return; + cpu_khz = x86_platform.calibrate_cpu(); tsc_khz = x86_platform.calibrate_tsc(); if (tsc_khz == 0) -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385276.1627765 (Exim 4.92) (envelope-from ) id 1ws7dg-0000KK-RF; Thu, 06 Aug 2026 23:36:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385276.1627765; Thu, 06 Aug 2026 23:36:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dg-0000Jt-JL; Thu, 06 Aug 2026 23:36:40 +0000 Received: by outflank-mailman (input) for mailman id 1385276; Thu, 06 Aug 2026 23:36:39 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3hBp1agYKCecbNJWSLPXXPUN.LXVgNW-MNeNUURbcb.gNWYaXSNLc.XaP@flex--seanjc.bounces.google.com>) id 1ws7df-0008UC-A3 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7de-00GcaU-Mr for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:38 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3hBp1agYKCecbNJWSLPXXPUN.LXVgNW-MNeNUURbcb.gNWYaXSNLc.XaP@flex--seanjc.bounces.google.com>) id 6a751a70-bab6-0a2a0a5309dd-0a2a450ae97a-16 for ; Fri, 07 Aug 2026 01:36:38 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3hBp1agYKCecbNJWSLPXXPUN.LXVgNW-MNeNUURbcb.gNWYaXSNLc.XaP@flex--seanjc.bounces.google.com>) id 6a751a85-f2d2-0a2a450a0019-d155d2c5cd50-3 for ; Fri, 07 Aug 2026 01:36:38 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84857446424so4590880b3a.1 for ; Thu, 06 Aug 2026 16:36:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059397; x=1786664197; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:reply-to:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QkWxTw8zJYn5bKvqCmD8koA0mP/8bnNFfn6ySpGUKjQ=; b=fJHLnSiqbKcx+tpzrPBosh7ZXY5G0rsX5Fvcp+/DjjmreXQ05GHGKbRh3/7mkj0MQN z7qH/WwlM22VEphBuA6YD2eOwtCqDNeDCd7DEenINVqwTX1jXd6FKmwTGiP6Cdn7JZac wViJoOks7DytdFEfLEaHOGQFaLRd6UF0V/LZyxZpFRCpzisGeWGvNonNv+GwzjDD4i9h zzv3ee5xwQPoaTmFERWhAiABc0OaxIfbQdWr1ScJq5E7OfB3kgsKBVlsLlmBrTz5NbHn 4Odd8jfoQQERmhNXiMgy0Paq5YIY8d5HFoFd+LNXm/cufEeUAqeGj8ntCCnf9ADsS+jT C+4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059397; x=1786664197; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QkWxTw8zJYn5bKvqCmD8koA0mP/8bnNFfn6ySpGUKjQ=; b=BD35hR5geCUCSlAfpimeafDg4+LIuOYL0Bo5XNbdMjfBfx2Oku7WCHcUxdmbHb6Ibp bek1NoFtcBHl0kVN86X8V6zi869rjQZe7Cr45G9HzLJZmb63Yzm4x3Ab67FYhUhkKHL+ /m1XO+tB+bTxiRdEbjsDHTOerrV/EG+PPr1+5sQMmxlxbjsZmOtsNDdpBjnMn8brKevH hmU84mVSI5z6/2rPeK92BZXJV86eqHA9mDXd7wUWBGIepR0oH+Q7yhz4Y4NDo5xqnZIP x+B2eYZ2Pg2dMEqaOGuIBbwEZSLlQv0oxRUmctWRKQjMIWF0wJO38kUg0yYR/d4OUwCF gqCA== X-Forwarded-Encrypted: i=1; AHgh+RooYxWkuyztSGgLJZP3xr9nYLVOaZHvxt4W2rFPsrAw/kGFHub70xudot8gsebQcC66Tc3MKHvTGqk=@lists.xenproject.org X-Gm-Message-State: AOJu0YzPHCq/YLkJmclDPoiAk4fy3LraDYvd6GFVLlLgDfAKHyLdVQ6G ZQAc4KI+OwkeOzbauUIKuHLf6H7LQyGaf68X9Np81ibWwxOKZb+UfDFhY4mbFvjIqmWq0PPjmE6 Cl1AmCA== X-Received: from pfqy1.prod.google.com ([2002:aa7:9e01:0:b0:848:46e6:1aac]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3692:b0:84e:24f:2677 with SMTP id d2e1a72fcca58-84f2dfc0601mr21949181b3a.4.1786059396135; Thu, 06 Aug 2026 16:36:36 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:27 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-11-seanjc@google.com> Subject: [PATCH v6 10/51] x86/tdx: Force TSC frequency with CPUID-based info provided by the TDX-Module From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-4011c0/1786059398-52EDACFC-0339FAF7/0/0 X-purgate-type: clean X-purgate-size: 6604 When running as a TDX guest, explicitly set the TSC frequency to a known value, using CPUID-based information, instead of potentially relying on a hypervisor-controlled PV routine. For TDX guests, CPUID.0x15 is always emulated by the TDX-Module, i.e. the information from CPUID is more trustworthy than the information provided by the hypervisor. To maintain backwards compatibility with TDX guest kernels that use native calibration, and because it's the least awful option, retain native_calibrate_tsc()'s stuffing of the local APIC bus period using the core crystal frequency. While it's entirely possible for the hypervisor to emulate the APIC timer at a different frequency than the core crystal frequency, the commonly accepted interpretation of Intel's SDM is that APIC timer runs at the core crystal frequency when that latter is enumerated via CPUID: The APIC timer frequency will be the processor=E2=80=99s bus clock or cor= e crystal clock frequency (when TSC/core crystal clock ratio is enumerated in CPUID leaf 0x15). If the hypervisor is malicious and deliberately runs the APIC timer at the wrong frequency, nothing would stop the hypervisor from modifying the frequency at any time, i.e. attempting to manually calibrate the frequency out of paranoia would be futile. Deliberately leave CPU frequency calibration as is, since the TDX-Module doesn't provide any guarantees with respect to CPUID.0x16. Expose and use cpuid_get_tsc_info() instead of providing a wrapper to get the TSC and core crystal frequency, as TDX is the only anticipated user outside of the TSC code, i.e. adding a helper to dedup the math won't actually dedup anything. Having TDX use "struct cpuid_tsc_info" also avoids the temptation of declaring a local "tsc_khz" variable and thus unintentionally creating a shadow of the global "tsc_khz". Cc: Kiryl Shutsemau (Meta) Signed-off-by: Sean Christopherson --- .../admin-guide/kernel-parameters.txt | 4 ++-- arch/x86/coco/tdx/tdx.c | 20 ++++++++++++++++--- arch/x86/include/asm/tdx.h | 2 ++ arch/x86/include/asm/tsc.h | 7 +++++++ arch/x86/kernel/tsc.c | 11 ++++------ 5 files changed, 32 insertions(+), 12 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentatio= n/admin-guide/kernel-parameters.txt index aa4eb568d9fb..5a3d40a4a4ec 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -7947,8 +7947,8 @@ Kernel parameters Format: =20 Note, tsc_early_khz is ignored if the TSC frequency is - provided by trusted firmware when running as an SNP - guest. + provided by trusted firmware when running as an SNP or + TDX guest. =20 tsx=3D [X86] Control Transactional Synchronization Extensions (TSX) feature in Intel processors that diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c index f904a636d449..ec28a15e26ac 100644 --- a/arch/x86/coco/tdx/tdx.c +++ b/arch/x86/coco/tdx/tdx.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -1121,9 +1122,6 @@ void __init tdx_early_init(void) =20 setup_force_cpu_cap(X86_FEATURE_TDX_GUEST); =20 - /* TSC is the only reliable clock in TDX guest */ - setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); - cc_vendor =3D CC_VENDOR_INTEL; =20 /* Configure the TD */ @@ -1193,3 +1191,19 @@ void __init tdx_early_init(void) =20 tdx_announce(); } + +unsigned int __init tdx_tsc_init(void) +{ + struct cpuid_tsc_info info; + + if (WARN_ON_ONCE(cpuid_get_tsc_info(&info) || !info.crystal_khz)) + return 0; + + apic_set_timer_frequency_khz(info.crystal_khz, "TDX-Module via CPUID"); + + /* TSC is the only reliable clock in TDX guest */ + setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); + setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); + + return info.crystal_khz * info.numerator / info.denominator; +} diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h index 89e97d5761d8..d23ff06db41a 100644 --- a/arch/x86/include/asm/tdx.h +++ b/arch/x86/include/asm/tdx.h @@ -68,6 +68,7 @@ struct ve_info { #ifdef CONFIG_INTEL_TDX_GUEST =20 void __init tdx_early_init(void); +unsigned int __init tdx_tsc_init(void); =20 void tdx_get_ve_info(struct ve_info *ve); =20 @@ -89,6 +90,7 @@ void __init tdx_dump_td_ctls(u64 td_ctls); #else =20 static inline void tdx_early_init(void) { }; +static inline unsigned int tdx_tsc_init(void) { return 0; } static inline void tdx_halt(void) { }; =20 static inline bool tdx_early_handle_ve(struct pt_regs *regs) { return fals= e; } diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h index 4d2d2f21ff06..b6b86e24e1bf 100644 --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -82,6 +82,13 @@ static inline cycles_t get_cycles(void) } #define get_cycles get_cycles =20 +struct cpuid_tsc_info { + unsigned int denominator; + unsigned int numerator; + unsigned int crystal_khz; +}; +extern int cpuid_get_tsc_info(struct cpuid_tsc_info *info); + extern void tsc_early_init(void); extern void tsc_init(void); extern void mark_tsc_unstable(char *reason); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index d405ff4e45e0..f3febe406fa8 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -34,6 +34,7 @@ #include #include #include +#include =20 unsigned int __read_mostly cpu_khz; /* TSC clocks / usec, not used here */ EXPORT_SYMBOL(cpu_khz); @@ -645,13 +646,7 @@ static unsigned long quick_pit_calibrate(void) return delta; } =20 -struct cpuid_tsc_info { - unsigned int denominator; - unsigned int numerator; - unsigned int crystal_khz; -}; - -static int cpuid_get_tsc_info(struct cpuid_tsc_info *info) +int cpuid_get_tsc_info(struct cpuid_tsc_info *info) { unsigned int ecx_hz, edx; =20 @@ -1529,6 +1524,8 @@ void __init tsc_early_init(void) =20 if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) known_tsc_khz =3D snp_secure_tsc_init(); + else if (boot_cpu_has(X86_FEATURE_TDX_GUEST)) + known_tsc_khz =3D tdx_tsc_init(); =20 /* * Ignore the user-provided TSC frequency if the exact frequency was --=20 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385278.1627771 (Exim 4.92) (envelope-from ) id 1ws7di-0000aC-Bk; Thu, 06 Aug 2026 23:36:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385278.1627771; Thu, 06 Aug 2026 23:36:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7di-0000Z9-66; Thu, 06 Aug 2026 23:36:42 +0000 Received: by outflank-mailman (input) for mailman id 1385278; Thu, 06 Aug 2026 23:36:40 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3hRp1agYKCegcOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 1ws7dg-0000Ig-F2 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7df-00GcT3-Ro for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:39 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3hRp1agYKCegcOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 6a751a35-5cb7-0a2a0a5109dd-0a2a450bb002-36 for ; Fri, 07 Aug 2026 01:36:39 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3hRp1agYKCegcOKXTMQYYQVO.MYWhOX-NOfOVVScdc.hOXZbYTOMd.YbQ@flex--seanjc.bounces.google.com>) id 6a751a86-b7e8-0a2a450b0019-d155d2c5ed0a-3 for ; Fri, 07 Aug 2026 01:36:39 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8484f26852dso3084165b3a.1 for ; Thu, 06 Aug 2026 16:36:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059398; x=1786664198; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=BTA01HvIZtLfKHw73sD4lcjm5hs9HMIraXdGO98hTIs=; b=KLzF5lYbfJcAarXUGcqkhaTeNAVsD0XO0D6/e+mae/DJPv1S3Smidgd+lbVDRvXfoG 58IJ69eubmfkaiRLxzmAm8CjRwaCdR3DUmTTory+Y46AS0JPIEXQRtJkduoY+fG0CLue J+Ku5KDeNUVB7rTATBJsLuVXoBQmbNc/KsHJ+jRoZ85aHqfsIcNEMaar6wO+/k6LYv7i QUHeivxexhweFpGmqeQ0nDK5OUg1WS8tnoBpOUj/r/q0hGd2dYAn6Ju9uJcTj+AcLtfZ nXsLrML1KVOB1++MD4rWDHsNX/YoozWMAPE/4aZR6OdtTOUIYLEMy2Ot1th6R7tFdiNy Oe7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059398; x=1786664198; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BTA01HvIZtLfKHw73sD4lcjm5hs9HMIraXdGO98hTIs=; b=Ybeaf0DXjTwFIe/UQ4lX2D3RyrL4ykKtAb136CtzSdSh/zpVnFoYrD9CXnxWiid4RW IxMP/FAfBoYgzEE5Z8xbgoLPGtzhnpAXZLcLdO8Y8oolgAmdhT/3vmfxLwtoq+3A8rtv RKiciaj0nIhXGn8mR2MVawBB6fT8SdmHXdiPl+XurNmI1UatxcdVZQX5TWCWSpxWBfwL s9pIPcWQHwICn7+fYdphtShf44gB2b52d9LTOH6R67k1iGCDbwOuldvGQ9FEGE42dbBo QeYK5l2OzQ4o2K//btKEG9hXtsHYdZmJvmvAoAQM3lKn6g1mBlLZ/rhjZ3bqpc7CBfGh Qt0Q== X-Forwarded-Encrypted: i=1; AHgh+Rpx/1cvQGXP96dTDgwqx8AMY9QPaT3M+ZqPLVtlLsZJoAaFGkX0xKR9Ltxc5Lkss/jT59Yu4QFx4LQ=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy8BZLLU5UB6pxdEy/2PUhZP0aWdPS6JPRvFbBY5R4xIjWXUEfr dTyvRIrbx7BwW3eaYKNcHvTpXAD3VqkFzf5qKP4CrOvS2/H37lfXlvnXwORcX3llf6uirWZOGYs 4JsckFA== X-Received: from pfbkx25.prod.google.com ([2002:a05:6a00:6f19:b0:847:8449:eef1]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1388:b0:848:30c3:45dd with SMTP id d2e1a72fcca58-84f4fdbf18amr5180418b3a.11.1786059397399; Thu, 06 Aug 2026 16:36:37 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:28 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-12-seanjc@google.com> Subject: [PATCH v6 11/51] x86/tsc: Add dedicated hypervisor hooks for getting known TSC/CPU frequencies From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-42698a/1786059399-1B6D29EA-230C55CD/0/0 X-purgate-type: clean X-purgate-size: 12640 Add dedicated hypervisor hooks for getting known TSC/CPU frequencies instead of overriding seemingly generic platform hooks, and explicitly prioritize hypervisor-provided frequencies over native methods, but do NOT clobber the frequency obtained from trusted firmware. While shuffling the hooks around is arguably "six of one, half dozen of the other", scoping them to x86_hyper_init makes their purpose more obvious, and allows for explicitly defining the priority of sources (as is done here). As is already done when trusted firmware provides the TSC frequency, ignore tsc_early_khz if the exact TSC frequency was obtained from the hypervisor, as attempting to refine the TSC frequency when running in a VM is all but guaranteed to cause problems sooner or later due to the calibration sources being emulated devices in the vast majority of setups. Cc: David Woodhouse Reviewed-by: Michael Kelley Signed-off-by: Sean Christopherson --- .../admin-guide/kernel-parameters.txt | 3 +- arch/x86/include/asm/acrn.h | 5 ---- arch/x86/include/asm/x86_init.h | 4 +++ arch/x86/kernel/cpu/acrn.c | 10 +++++-- arch/x86/kernel/cpu/mshyperv.c | 6 ++-- arch/x86/kernel/cpu/vmware.c | 8 ++--- arch/x86/kernel/jailhouse.c | 6 ++-- arch/x86/kernel/kvmclock.c | 6 ++-- arch/x86/kernel/tsc.c | 29 ++++++++++++++----- arch/x86/xen/time.c | 4 +-- 10 files changed, 50 insertions(+), 31 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 5a3d40a4a4ec..1ab56fbdc35d 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -7948,7 +7948,8 @@ Kernel parameters Note, tsc_early_khz is ignored if the TSC frequency is provided by trusted firmware when running as an SNP or - TDX guest. + TDX guest, or when the hypervisor provides the exact + frequency via a paravirtual interface. tsx= [X86] Control Transactional Synchronization Extensions (TSX) feature in Intel processors that diff --git a/arch/x86/include/asm/acrn.h b/arch/x86/include/asm/acrn.h index db42b477c41d..a892179c61c6 100644 --- a/arch/x86/include/asm/acrn.h +++ b/arch/x86/include/asm/acrn.h @@ -32,11 +32,6 @@ static inline u32 acrn_cpuid_base(void) return 0; } -static inline unsigned long acrn_get_tsc_khz(void) -{ - return cpuid_eax(ACRN_CPUID_TIMING_INFO); -} - /* * Hypercalls for ACRN * diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 953d3199408a..0c89bf40f507 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -123,6 +123,8 @@ struct x86_init_pci { * @msi_ext_dest_id: MSI supports 15-bit APIC IDs * @init_mem_mapping: setup early mappings during init_mem_mapping() * @init_after_bootmem: guest init after boot allocator is finished + * @get_tsc_khz: get the TSC frequency (returns 0 if frequency is unknown) + * @get_cpu_khz: get the CPU frequency (returns 0 if frequency is unknown) */ struct x86_hyper_init { void (*init_platform)(void); @@ -131,6 +133,8 @@ struct x86_hyper_init { bool (*msi_ext_dest_id)(void); void (*init_mem_mapping)(void); void (*init_after_bootmem)(void); + unsigned int (*get_tsc_khz)(void); + unsigned int (*get_cpu_khz)(void); }; /** diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index dc119af83524..ad8f2da8003b 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -24,13 +24,15 @@ static u32 __init acrn_detect(void) return acrn_cpuid_base(); } +static unsigned int __init acrn_get_tsc_khz(void) +{ + return cpuid_eax(ACRN_CPUID_TIMING_INFO); +} + static void __init acrn_init_platform(void) { /* Install system interrupt handler for ACRN hypervisor callback */ sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); - - x86_platform.calibrate_tsc = acrn_get_tsc_khz; - x86_platform.calibrate_cpu = acrn_get_tsc_khz; } static bool acrn_x2apic_available(void) @@ -78,4 +80,6 @@ const __initconst struct hypervisor_x86 x86_hyper_acrn = { .type = X86_HYPER_ACRN, .init.init_platform = acrn_init_platform, .init.x2apic_available = acrn_x2apic_available, + .init.get_tsc_khz = acrn_get_tsc_khz, + .init.get_cpu_khz = acrn_get_tsc_khz, }; diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index cadc7f872b4f..4a0cdda0c49e 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -395,7 +395,7 @@ static int hv_nmi_unknown(unsigned int val, struct pt_regs *regs) } #endif -static unsigned long hv_get_tsc_khz(void) +static unsigned int __init hv_get_tsc_khz(void) { unsigned long freq; @@ -573,8 +573,8 @@ static void __init ms_hyperv_init_platform(void) if (ms_hyperv.features & HV_ACCESS_FREQUENCY_MSRS && ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) { - x86_platform.calibrate_tsc = hv_get_tsc_khz; - x86_platform.calibrate_cpu = hv_get_tsc_khz; + x86_init.hyper.get_tsc_khz = hv_get_tsc_khz; + x86_init.hyper.get_cpu_khz = hv_get_tsc_khz; setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 2225df67d45f..3f1dab69d90e 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -64,7 +64,7 @@ struct vmware_steal_time { u64 reserved[7]; }; -static unsigned long vmware_tsc_khz __ro_after_init; +static unsigned long vmware_tsc_khz __initdata; static u8 vmware_hypercall_mode __ro_after_init; unsigned long vmware_hypercall_slow(unsigned long cmd, @@ -137,7 +137,7 @@ static inline int __vmware_platform(void) return eax != UINT_MAX && ebx == VMWARE_HYPERVISOR_MAGIC; } -static unsigned long vmware_get_tsc_khz(void) +static unsigned int __init vmware_get_tsc_khz(void) { return vmware_tsc_khz; } @@ -419,8 +419,8 @@ static void __init vmware_platform_setup(void) } vmware_tsc_khz = tsc_khz; - x86_platform.calibrate_tsc = vmware_get_tsc_khz; - x86_platform.calibrate_cpu = vmware_get_tsc_khz; + x86_init.hyper.get_tsc_khz = vmware_get_tsc_khz; + x86_init.hyper.get_cpu_khz = vmware_get_tsc_khz; /* Skip lapic calibration since we know the bus frequency. */ apic_set_timer_frequency_hz(ecx, "VMware hypervisor"); diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c index 615a1f25c83a..595cd28f9a9f 100644 --- a/arch/x86/kernel/jailhouse.c +++ b/arch/x86/kernel/jailhouse.c @@ -68,7 +68,7 @@ static void __init jailhouse_timer_init(void) apic_set_timer_frequency_khz(setup_data.v1.apic_khz, "Jailhouse hypervisor"); } -static unsigned long jailhouse_get_tsc(void) +static unsigned int __init jailhouse_get_tsc(void) { return precalibrated_tsc_khz; } @@ -210,8 +210,6 @@ static void __init jailhouse_init_platform(void) x86_init.mpparse.parse_smp_cfg = jailhouse_parse_smp_config; x86_init.pci.arch_init = jailhouse_pci_arch_init; - x86_platform.calibrate_cpu = jailhouse_get_tsc; - x86_platform.calibrate_tsc = jailhouse_get_tsc; x86_platform.get_wallclock = jailhouse_get_wallclock; x86_platform.legacy.rtc = 0; x86_platform.legacy.warm_reset = 0; @@ -293,5 +291,7 @@ const struct hypervisor_x86 x86_hyper_jailhouse __refconst = { .detect = jailhouse_detect, .init.init_platform = jailhouse_init_platform, .init.x2apic_available = jailhouse_x2apic_available, + .init.get_tsc_khz = jailhouse_get_tsc, + .init.get_cpu_khz = jailhouse_get_tsc, .ignore_nopv = true, }; diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index cb3d0ca1fa22..4f8299303a19 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -136,7 +136,7 @@ static inline void kvm_sched_clock_init(bool stable) * poll of guests can be running and trouble each other. So we preset * lpj here */ -static unsigned long kvm_get_tsc_khz(void) +static unsigned int __init kvm_get_tsc_khz(void) { setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return pvclock_tsc_khz(this_cpu_pvti()); @@ -343,8 +343,8 @@ void __init kvmclock_init(void) flags = pvclock_read_flags(&hv_clock_boot[0].pvti); kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); - x86_platform.calibrate_tsc = kvm_get_tsc_khz; - x86_platform.calibrate_cpu = kvm_get_tsc_khz; + x86_init.hyper.get_tsc_khz = kvm_get_tsc_khz; + x86_init.hyper.get_cpu_khz = kvm_get_tsc_khz; x86_platform.get_wallclock = kvm_get_wallclock; x86_platform.set_wallclock = kvm_set_wallclock; #ifdef CONFIG_X86_LOCAL_APIC diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index f3febe406fa8..7f1ca6df0004 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1451,13 +1451,17 @@ static int __init init_tsc_clocksource(void) device_initcall(init_tsc_clocksource); static bool __init determine_cpu_tsc_frequencies(bool early, + unsigned int known_cpu_khz, unsigned int known_tsc_khz) { /* Make sure that cpu and tsc are not already calibrated */ WARN_ON(cpu_khz || tsc_khz); if (early) { - cpu_khz = x86_platform.calibrate_cpu(); + if (known_cpu_khz) + cpu_khz = known_cpu_khz; + else + cpu_khz = x86_platform.calibrate_cpu(); if (known_tsc_khz) tsc_khz = known_tsc_khz; else @@ -1514,7 +1518,7 @@ static void __init tsc_enable_sched_clock(void) void __init tsc_early_init(void) { - unsigned int known_tsc_khz = 0; + unsigned int known_cpu_khz = 0, known_tsc_khz = 0; if (!boot_cpu_has(X86_FEATURE_TSC)) return; @@ -1522,22 +1526,33 @@ void __init tsc_early_init(void) if (is_early_uv_system()) return; + if (x86_init.hyper.get_cpu_khz) + known_cpu_khz = x86_init.hyper.get_cpu_khz(); + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC)) known_tsc_khz = snp_secure_tsc_init(); else if (boot_cpu_has(X86_FEATURE_TDX_GUEST)) known_tsc_khz = tdx_tsc_init(); + /* + * If the TSC frequency wasn't provided by trusted firmware, try to get + * it from the hypervisor (which is untrusted when running as a CoCo guest). + */ + if (!known_tsc_khz && x86_init.hyper.get_tsc_khz) + known_tsc_khz = x86_init.hyper.get_tsc_khz(); + /* * Ignore the user-provided TSC frequency if the exact frequency was - * obtained from trusted firmware, as the user-provided frequency is - * intended as a "starting point", not a known, guaranteed frequency. + * obtained from trusted firmware or the hypervisor, as the user- + * provided frequency is intended as a "starting point", not a known, + * guaranteed frequency. */ if (!known_tsc_khz) known_tsc_khz = tsc_early_khz; else if (tsc_early_khz) - pr_err("Ignoring 'tsc_early_khz' in favor of trusted firmware.\n"); + pr_err("Ignoring 'tsc_early_khz' in favor of firmware/hypervisor.\n"); - if (!determine_cpu_tsc_frequencies(true, known_tsc_khz)) + if (!determine_cpu_tsc_frequencies(true, known_cpu_khz, known_tsc_khz)) return; tsc_enable_sched_clock(); } @@ -1558,7 +1573,7 @@ void __init tsc_init(void) if (!tsc_khz) { /* We failed to determine frequencies earlier, try again */ - if (!determine_cpu_tsc_frequencies(false, 0)) { + if (!determine_cpu_tsc_frequencies(false, 0, 0)) { mark_tsc_unstable("could not calculate TSC khz"); setup_clear_cpu_cap(X86_FEATURE_TSC_DEADLINE_TIMER); return; diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index d62c14334b35..1adb44fdddb2 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -38,7 +38,7 @@ static u64 xen_sched_clock_offset __read_mostly; /* Get the TSC speed from Xen */ -static unsigned long xen_tsc_khz(void) +static unsigned int __init xen_tsc_khz(void) { struct pvclock_vcpu_time_info *info = &HYPERVISOR_shared_info->vcpu_info[0].time; @@ -569,7 +569,7 @@ static void __init xen_init_time_common(void) static_call_update(pv_steal_clock, xen_steal_clock); paravirt_set_sched_clock(xen_sched_clock); - x86_platform.calibrate_tsc = xen_tsc_khz; + x86_init.hyper.get_tsc_khz = xen_tsc_khz; x86_platform.get_wallclock = xen_get_wallclock; } -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385284.1627782 (Exim 4.92) (envelope-from ) id 1ws7dm-000177-Re; Thu, 06 Aug 2026 23:36:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385284.1627782; Thu, 06 Aug 2026 23:36:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dm-00016d-M3; Thu, 06 Aug 2026 23:36:46 +0000 Received: by outflank-mailman (input) for mailman id 1385284; Thu, 06 Aug 2026 23:36:45 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3ihp1agYKCe0hTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 1ws7dl-0000zb-1s for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dk-00GcT3-Eh for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:44 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3ihp1agYKCe0hTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 6a751a63-5cb7-0a2a0a5109dd-0a2a45099b3a-14 for ; Fri, 07 Aug 2026 01:36:44 +0200 Received: from [209.85.216.71] (helo=mail-pj1-f71.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3ihp1agYKCe0hTPcYRVddVaT.RdbmTc-STkTaaXhih.mTcegdYTRi.dgV@flex--seanjc.bounces.google.com>) id 6a751a8a-be1a-0a2a45090019-d155d847b8c1-3 for ; Fri, 07 Aug 2026 01:36:44 +0200 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e667368f0so4358162a91.2 for ; Thu, 06 Aug 2026 16:36:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059402; x=1786664202; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=wbY0NuQ4jmVaTb967BiKKQEFZ81rzIFWsnI6s/GLKnk=; b=wU0/80f/2tfxf6oVmy6NECSHzNhhT0Ndg5wkXXqKAGhqPiuL+EINjJO3oVS8DLXj1p /HUcwVU/OTHEEuAovapscHBEkt7Wtwu1nYVMGW2ob28WO1fsIRTFGqIBLPV+2D/iMSBT XyYnb2rxXP0GLJ6De2Cjka/B7+TO0fHWSmmGQnHMcRK/oxwRzEEVSaZdC6v56cipmKn6 b0ZGtLc0UiD8gwnViVlsB9S/ClDqx2tTPJFqH2XulN8Yr7nfRpwy3Tfo+PAyOkgn9/Z+ 5ynifEuCAm/y2nu8IBT2YeRs7dyv79e5r5QY91HeBIswEB7wL7XMWJXj+jbHGl2+PqWK t9Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059402; x=1786664202; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wbY0NuQ4jmVaTb967BiKKQEFZ81rzIFWsnI6s/GLKnk=; b=CZbx8Mx958nQAE7y4AfTwtE5qYUn2BHzwCvm02wpOrzwOBf44xo5cPY+jeiNiI4T1P RWaatoZ/4WOy05zk1ABLwL4QiikvEXff9UM1kIlaZ6azwG6t+LPsNsOfJ/jebj9IrAiM V4h/hD7thojso+ZJ7POOIDBx083F1DNHLOx+Us1B73PlB9X5UC48mh5V1pRmEiaNv5Uz KwhEkull4TmWOkd/XWrgcoM8lCLPue1dQvlQ7QBpi82/Pef6kA1ZVSjxIlroHyGxCHp1 EW+kqX1K8Up8LpqJU4T12YgKsYICxqnsRJ5Lba78zQZ6udunjfsDCAzlpCHWkHN5uixx vr9g== X-Forwarded-Encrypted: i=1; AHgh+Ro10JlYN7uXMq5wdLHHq8IBB/8dlHc9PEDgagA202qntvLP6zSx07oBNhOUFPjwMubOmkafvTSvGt4=@lists.xenproject.org X-Gm-Message-State: AOJu0YwrUa3B3M5+sxN7NrfYUw6JHoKaGB/vhwafgGBarCgAm53lpsLq ryrXsQrTp6dyF/4g8sbZT3731EXww3qFuPAD4HRu/ThidEL37fWsSeqrl8pY5YL7TvjPT8jc5or bThwn2g== X-Received: from pjbcv18.prod.google.com ([2002:a17:90a:fd12:b0:38e:7f2c:2c4b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:264c:b0:37f:e326:6557 with SMTP id 98e67ed59e1d1-3903c598e8amr20096574a91.4.1786059402046; Thu, 06 Aug 2026 16:36:42 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:32 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-16-seanjc@google.com> Subject: [PATCH v6 15/51] x86/tsc: Kill off x86_platform_ops.calibrate_{cpu,tsc}() hooks From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1786059404-BEAD8034-89559CF6/0/0 X-purgate-type: clean X-purgate-size: 5639 Now that getting the CPU and/or TSC frequencies from the hypervisor uses dedicated hooks, drop x86_platform_ops.calibrate_{cpu,tsc}() and instead directly invoke the correct helper at each phase of (re)calibration. In addition to eliminating unnecessary code, this makes it a bit more obvious when the "late" path invokes pit_hpet_ptimer_calibrate_cpu() instead of x86_platform_ops.calibrate_cpu(). No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/include/asm/tsc.h | 2 -- arch/x86/include/asm/x86_init.h | 4 ---- arch/x86/kernel/tsc.c | 28 ++++++++++++---------------- arch/x86/kernel/x86_init.c | 2 -- 4 files changed, 12 insertions(+), 24 deletions(-) diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h index b6b86e24e1bf..c09ec485abcd 100644 --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -95,8 +95,6 @@ extern void mark_tsc_unstable(char *reason); extern int unsynchronized_tsc(void); extern int check_tsc_unstable(void); extern void mark_tsc_async_resets(char *reason); -extern unsigned long native_calibrate_cpu_early(void); -extern unsigned long native_calibrate_tsc(void); extern unsigned long long native_sched_clock_from_tsc(u64 tsc); extern int tsc_clocksource_reliable; diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 0c89bf40f507..e879e6e83428 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -295,8 +295,6 @@ struct x86_hyper_runtime { /** * struct x86_platform_ops - platform specific runtime functions - * @calibrate_cpu: calibrate CPU - * @calibrate_tsc: calibrate TSC, if different from CPU * @get_wallclock: get time from HW clock like RTC etc. * @set_wallclock: set time back to HW clock * @iommu_shutdown: set by an IOMMU driver for shutdown if necessary @@ -320,8 +318,6 @@ struct x86_hyper_runtime { * @guest: guest incarnations callbacks */ struct x86_platform_ops { - unsigned long (*calibrate_cpu)(void); - unsigned long (*calibrate_tsc)(void); void (*get_wallclock)(struct timespec64 *ts); int (*set_wallclock)(const struct timespec64 *ts); void (*iommu_shutdown)(void); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index f42872c9ae99..1d41ef1db27c 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -672,7 +672,7 @@ int cpuid_get_tsc_info(struct cpuid_tsc_info *info) * native_calibrate_tsc - determine TSC frequency * Determine TSC frequency via CPUID, else return 0. */ -unsigned long native_calibrate_tsc(void) +static unsigned long native_calibrate_tsc(void) { struct cpuid_tsc_info info; @@ -904,7 +904,7 @@ static unsigned long pit_hpet_ptimer_calibrate_cpu(void) /** * native_calibrate_cpu_early - can calibrate the cpu early in boot */ -unsigned long native_calibrate_cpu_early(void) +static unsigned long native_calibrate_cpu_early(void) { unsigned long flags, fast_calibrate = cpu_khz_from_cpuid(); @@ -918,7 +918,7 @@ unsigned long native_calibrate_cpu_early(void) return fast_calibrate; } - +#ifndef CONFIG_SMP /** * native_calibrate_cpu - calibrate the cpu */ @@ -931,6 +931,7 @@ static unsigned long native_calibrate_cpu(void) return tsc_freq; } +#endif void recalibrate_cpu_khz(void) { @@ -943,8 +944,8 @@ void recalibrate_cpu_khz(void) if (WARN_ON_ONCE(cpu_feature_enabled(X86_FEATURE_TSC_KNOWN_FREQ))) return; - cpu_khz = x86_platform.calibrate_cpu(); - tsc_khz = x86_platform.calibrate_tsc(); + cpu_khz = native_calibrate_cpu(); + tsc_khz = native_calibrate_tsc(); if (tsc_khz == 0) tsc_khz = cpu_khz; else if (abs(cpu_khz - tsc_khz) * 10 > tsc_khz) @@ -1458,17 +1459,19 @@ static bool __init determine_cpu_tsc_frequencies(bool early, WARN_ON(cpu_khz || tsc_khz); if (early) { + /* + * Early CPU calibration can only use methods that are available + * early in boot (obviously). + */ if (known_cpu_khz) cpu_khz = known_cpu_khz; else - cpu_khz = x86_platform.calibrate_cpu(); + cpu_khz = native_calibrate_cpu_early(); if (known_tsc_khz) tsc_khz = known_tsc_khz; else - tsc_khz = x86_platform.calibrate_tsc(); + tsc_khz = native_calibrate_tsc(); } else { - /* We should not be here with non-native cpu calibration */ - WARN_ON(x86_platform.calibrate_cpu != native_calibrate_cpu); cpu_khz = pit_hpet_ptimer_calibrate_cpu(); } @@ -1571,13 +1574,6 @@ void __init tsc_init(void) return; } - /* - * native_calibrate_cpu_early can only calibrate using methods that are - * available early in boot. - */ - if (x86_platform.calibrate_cpu == native_calibrate_cpu_early) - x86_platform.calibrate_cpu = native_calibrate_cpu; - if (!tsc_khz) { /* We failed to determine frequencies earlier, try again */ if (!determine_cpu_tsc_frequencies(false, 0, 0)) { diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index 252c5827d063..b7a48e622f48 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -147,8 +147,6 @@ static void enc_kexec_finish_noop(void) {} static bool is_private_mmio_noop(u64 addr) {return false; } struct x86_platform_ops x86_platform __ro_after_init = { - .calibrate_cpu = native_calibrate_cpu_early, - .calibrate_tsc = native_calibrate_tsc, .get_wallclock = mach_get_cmos_time, .set_wallclock = mach_set_cmos_time, .iommu_shutdown = iommu_shutdown_noop, -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385295.1627792 (Exim 4.92) (envelope-from ) id 1ws7dr-0001tl-CF; Thu, 06 Aug 2026 23:36:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385295.1627792; Thu, 06 Aug 2026 23:36:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dr-0001so-2g; Thu, 06 Aug 2026 23:36:51 +0000 Received: by outflank-mailman (input) for mailman id 1385295; Thu, 06 Aug 2026 23:36:49 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3jhp1agYKCfElXTgcVZhhZeX.VhfqXg-WXoXeeblml.qXgikhcXVm.hkZ@flex--seanjc.bounces.google.com>) id 1ws7dp-0001fJ-7C for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7do-00GcaU-KN for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:48 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3jhp1agYKCfElXTgcVZhhZeX.VhfqXg-WXoXeeblml.qXgikhcXVm.hkZ@flex--seanjc.bounces.google.com>) id 6a751a70-bab6-0a2a0a5309dd-0a2a450ae97a-20 for ; Fri, 07 Aug 2026 01:36:48 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3jhp1agYKCfElXTgcVZhhZeX.VhfqXg-WXoXeeblml.qXgikhcXVm.hkZ@flex--seanjc.bounces.google.com>) id 6a751a8f-f2d2-0a2a450a0019-d155d2c6c9e2-3 for ; Fri, 07 Aug 2026 01:36:48 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84870e7f498so2970699b3a.3 for ; Thu, 06 Aug 2026 16:36:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059406; x=1786664206; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=bafmbn4x7WGy8QY/EzYypINgs3wQBC6UPHmanD+knFs=; b=rNz8Q677rJoZ53N2qPQKXwQ4hihCKOhYUY0cOKrxQCTX9Sv4UtbSK8zEcLdS0x5dOx T2xb4CBhnfLY02gHuc07ZH71Rypw4KgmKocMe3LutsWkBY7sd2SvJfZVO7YEUjrsk6z4 u99+lEP4h5AmoxeFSSxhmvlf0HvdDsByL5MtKQh56Q8TT9dh5tlh9EzPE/0YMtZAjrmK vzKEYupH+3jWbRaHa8ItwDpPi5WcyBqPz8cS/v6hmBbkfL9yGpeiXEF8+7v5DnhkRURZ PQppwq2wiGHAiKAFR0i3ptxJdVBoW9BPr52oompLchMKyuj1pMlIOaDCjeauPxlg5Qfj ZYOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059406; x=1786664206; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bafmbn4x7WGy8QY/EzYypINgs3wQBC6UPHmanD+knFs=; b=II875WJVKpdRzEtpR9yD6JVz+pW1GHLdCAI9iFgnHvB1YdY8igW6zLYZqsrC+1YbwB zbyv158JDlaECfww9tySMqLS2PwLsn9KoEfwtK1lrYTnXi2z6PriwJKfO9Iqf0tZePzo bhWlAePf3AH5yoWs2UDeE3Q/RId268AJBB7SoJZfvZNhVh4v5Y+IUzrR2CA2JjeV8zqG 9zBSX7r54rng+Y/kSCBRN61q9uvFTzeqDxEv9EduFituVavHZbnbb3Y2tS94PNBl2cRE /uLU71mxHlloRC+Dm3D8evJ0fhbgzD9Rgz9YWLRF1wxijrcbSxcMFuo36ygEKwtXBhVF IOnQ== X-Forwarded-Encrypted: i=1; AHgh+RobKBeDVUH67WbiI62fAP+DbH0Fk7wnF9ceDVzVwsow4+YpSzzZUKPUETs/VJnsA8+RKjzlLrTGoPI=@lists.xenproject.org X-Gm-Message-State: AOJu0YzcAlwINBmIij8UKpae1EU5T2tNBB5l0GSpxfDrOCNP0zXwuxyX wepC5m2ge3NMUfmQRybnoEicQ+q6l5hr9ubCbNBQ5uJdaDsXxknxE3gcOPXl959ifSkIKupHQD4 Z9ti3UA== X-Received: from pfks7.prod.google.com ([2002:a05:6a00:1947:b0:84e:2400:dc7d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:409b:b0:842:5b63:6112 with SMTP id d2e1a72fcca58-84f2e12d036mr22581852b3a.32.1786059406261; Thu, 06 Aug 2026 16:36:46 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:35 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-19-seanjc@google.com> Subject: [PATCH v6 18/51] x86/kvmclock: Rename kvm_get_tsc_khz() to kvmclock_get_tsc_khz() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059408-508CDCFC-68200CFA/0/0 X-purgate-type: clean X-purgate-size: 1630 Rename kvm_get_tsc_khz() to kvmclock_get_tsc_khz() in anticipation of adding support for getting TSC info from PV CPUID, i.e. in a KVM specific way, but without non-kvmclock. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 35a879d33e9e..061a22d31dea 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -136,7 +136,7 @@ static inline void kvm_sched_clock_init(bool stable) * poll of guests can be running and trouble each other. So we preset * lpj here */ -static unsigned int __init kvm_get_tsc_khz(void) +static unsigned int __init kvmclock_get_tsc_khz(void) { return pvclock_tsc_khz(this_cpu_pvti()); } @@ -146,7 +146,7 @@ static void __init kvm_get_preset_lpj(void) unsigned long khz; u64 lpj; - khz = kvm_get_tsc_khz(); + khz = kvmclock_get_tsc_khz(); lpj = ((u64)khz * 1000); do_div(lpj, HZ); @@ -342,8 +342,8 @@ void __init kvmclock_init(void) flags = pvclock_read_flags(&hv_clock_boot[0].pvti); kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); - x86_init.hyper.get_tsc_khz = kvm_get_tsc_khz; - x86_init.hyper.get_cpu_khz = kvm_get_tsc_khz; + x86_init.hyper.get_tsc_khz = kvmclock_get_tsc_khz; + x86_init.hyper.get_cpu_khz = kvmclock_get_tsc_khz; x86_platform.get_wallclock = kvm_get_wallclock; x86_platform.set_wallclock = kvm_set_wallclock; #ifdef CONFIG_X86_LOCAL_APIC -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385304.1627800 (Exim 4.92) (envelope-from ) id 1ws7dt-0002NH-KU; Thu, 06 Aug 2026 23:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385304.1627800; Thu, 06 Aug 2026 23:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dt-0002N7-GK; Thu, 06 Aug 2026 23:36:53 +0000 Received: by outflank-mailman (input) for mailman id 1385304; Thu, 06 Aug 2026 23:36:52 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3kRp1agYKCfQoaWjfYckkcha.Ykitaj-Zarahheopo.tajlnkfaYp.knc@flex--seanjc.bounces.google.com>) id 1ws7ds-0002Ay-Bw for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dr-005BVk-OV for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:51 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3kRp1agYKCfQoaWjfYckkcha.Ykitaj-Zarahheopo.tajlnkfaYp.knc@flex--seanjc.bounces.google.com>) id 6a751a63-5cb7-0a2a0a5109dd-0a2a45099b3a-22 for ; Fri, 07 Aug 2026 01:36:51 +0200 Received: from [209.85.216.71] (helo=mail-pj1-f71.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3kRp1agYKCfQoaWjfYckkcha.Ykitaj-Zarahheopo.tajlnkfaYp.knc@flex--seanjc.bounces.google.com>) id 6a751a92-be1a-0a2a45090019-d155d847f0b3-3 for ; Fri, 07 Aug 2026 01:36:51 +0200 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e11baa66eso2407878a91.2 for ; Thu, 06 Aug 2026 16:36:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059410; x=1786664210; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=eYIjdKzjgH3nVD0iNsx5sVBVp8XFdFFsnkR62+s/p+Q=; b=E5LLqXiTKfzr8w4IqDOo0QY+iuqgo807Di4c0I7wK/4WJ1kEtAr1iBNZ5Co/adFgd7 g9urHpdWNoBF625p4u+bzb+hRk+OsRZQj/yhe8zZBiPKaahmUMqCCDjaeCKmjMmz6ye9 dmp2/sMqpu4rCeGpyX4nHdggjfTtmecinVOb9X30S3uUgLgVqD6L7eh9E2iSllqOm8bN Sf7tOm0pAb7a2Q6O0zvos0/+MTdvhdcN0ODVxx4Wmx7w4JQUKb2kULU2pH3ugQ1IHSlg ICwAJW3Uv1iyLFl81CYS6S03Vhfmll9oYOhowG6BqV0g87YU8XYGxkl417TzFIQvUwE9 XN9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059410; x=1786664210; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eYIjdKzjgH3nVD0iNsx5sVBVp8XFdFFsnkR62+s/p+Q=; b=aojaK7+BgMLo+SOsVlGT+yu67L3XJcLffNpnPSTr/pq407ZEGFlr8OcvWqVJR/u7gk TcH4sHntzj2BasUFEUGh0RQYHyvKWhbj+GyraKQ82vJSeYQQ8iGAFR9JQx09jSwU/+if JrKJtbAiaK+WPapRrMzjG+YjdpDTlcTVjAVBU4V97KxLVF78fkTUeb46nd2iDdn0r6W8 uDWm+agfUHrhoWv43Walgd3hXpbOUPoFizIWW/k9c4aDuRh4lyFbcNHP5tdvVPYBU14i GnkyZ4tGAJ1gZYVs6JlE6PjEIQUK1kbdBfcXeKc+GtWMQ/MREtccVZBINX9LPOX/6e02 SHcg== X-Forwarded-Encrypted: i=1; AHgh+RqQUZ8OwWDYlSNYhqZGCYaWsTyA9pOE3f+blw6hStF5CEFjKPFwnBxCsB4KHiIUGEWPCjST6DM99lk=@lists.xenproject.org X-Gm-Message-State: AOJu0YwpTHW9Vso1wNanHWQpCnJQ1IF6wDKoXCGdmmoFjwtK8hy9zZdN ugB21nk58bD7586574X8ENdSBaZRz7f0LI6rpAlMVoFOMW0/SmGR/lrpmWdNvqqnUcYgaU/Kad2 1bCA+YQ== X-Received: from pjji3.prod.google.com ([2002:a17:90a:6503:b0:381:224:393a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:c106:b0:38e:250b:122f with SMTP id 98e67ed59e1d1-3909d8d5993mr5453558a91.16.1786059409368; Thu, 06 Aug 2026 16:36:49 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:37 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-21-seanjc@google.com> Subject: [PATCH v6 20/51] KVM: x86: Officially define CPUID 0x40000010 as PV Timing Info (TSC and Bus) From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-bad1c0/1786059411-BDAC0034-07F8BD3C/0/0 X-purgate-type: clean X-purgate-size: 3769 From: David Woodhouse Formally define and document CPUID 0x40000010 as providing TSC and local APIC bus frequency information for KVM's PV CPUID range. Way back in 2008, VMware proposed (https://lkml.org/lkml/2008/10/1/246) carving out a range of CPUID leaves for use by hypervisors. While the broader proposal from VMware was mostly shot down in flames, use of CPUID 0x40000010 to provide TSC and local APIC bus frequency information survived and made it's way into multiple guest operating systems. XNU unconditionally assumes CPUID 0x40000010 contains the frequency information, if it's present on any hypervisor: https://github.com/apple/darwin-xnu/blob/main/osfmk/i386/cpuid.c As does FreeBSD: https://github.com/freebsd/freebsd-src/commit/4a432614f68 More importantly, QEMU (the de facto "reference" VMM for KVM) has conditionally provided timing information in CPUID 0x40000010 for almost 9 years, since commit 9954a1582e ("x86-KVM: Supply TSC and APIC clock rates to guest like VMWare"). So at this point it would be daft for KVM (or any hypervisor) to expose 0x40000010 for any *other* content. Officially carve out and define the CPUID leaf so that Linux-as-a-guest can follow suit and pull TSC and Local APIC Bus frequency information from CPUID. Defer providing userspace with the necessary information needed to precisely and accurately enumerate the _actual_ configured TSC frequency to the guest (that exact information, along with the scaled ratio, isn't exposed to userspace). As evidenced by QEMU, providing CPUID 0x40000010 without help from KVM is entirely possible, just not ideal. Link: https://lore.kernel.org/all/ea0d7f43d910cee9600b254e303f468722fa355b.camel@infradead.org Signed-off-by: David Woodhouse [sean: drop KVM filling of CPUID, add documentation, massage changelog] Signed-off-by: Sean Christopherson --- Documentation/virt/kvm/x86/cpuid.rst | 12 ++++++++++++ arch/x86/include/uapi/asm/kvm_para.h | 11 +++++++++++ 2 files changed, 23 insertions(+) diff --git a/Documentation/virt/kvm/x86/cpuid.rst b/Documentation/virt/kvm/x86/cpuid.rst index bda3e3e737d7..a5ee8ff052ce 100644 --- a/Documentation/virt/kvm/x86/cpuid.rst +++ b/Documentation/virt/kvm/x86/cpuid.rst @@ -122,3 +122,15 @@ KVM_HINTS_REALTIME 0 guest checks this feature bit to preempted for an unlimited time allowing optimizations ================== ============ ================================= + +function: KVM_CPUID_TIMING_INFO (0x40000010) + +returns:: + + eax = (Virtual) TSC frequency in kHz + ebx = (Virtual) Bus (local APIC timer) frequency in kHz + ecx = 0 (Reserved) + edx = 0 (Reserved) + +Note, KVM only defines the semantics of KVM_CPUID_TIMING_INFO; KVM does NOT +advertise support via KVM_GET_SUPPORTED_CPUID. diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h index a1efa7907a0b..c3a384711f3a 100644 --- a/arch/x86/include/uapi/asm/kvm_para.h +++ b/arch/x86/include/uapi/asm/kvm_para.h @@ -44,6 +44,17 @@ */ #define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 24 +/* + * The timing information leaf provides TSC and local APIC timer frequency + * information to the guest. Note, userspace is responsible for filling the + * leaf with the correct information. + * + * # EAX: (Virtual) TSC frequency in kHz. + * # EBX: (Virtual) Bus (local APIC timer) frequency in kHz. + * # ECX, EDX: Reserved (must be zero). + */ +#define KVM_CPUID_TIMING_INFO 0x40000010 + #define MSR_KVM_WALL_CLOCK 0x11 #define MSR_KVM_SYSTEM_TIME 0x12 -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385307.1627807 (Exim 4.92) (envelope-from ) id 1ws7dv-0002fV-4a; Thu, 06 Aug 2026 23:36:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385307.1627807; Thu, 06 Aug 2026 23:36:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7du-0002en-UD; Thu, 06 Aug 2026 23:36:54 +0000 Received: by outflank-mailman (input) for mailman id 1385307; Thu, 06 Aug 2026 23:36:53 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3khp1agYKCfUpbXkgZdlldib.Zljubk-absbiifpqp.ubkmolgbZq.lod@flex--seanjc.bounces.google.com>) id 1ws7dt-0002Ml-FF for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7ds-00Gcdg-SP for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:52 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3khp1agYKCfUpbXkgZdlldib.Zljubk-absbiifpqp.ubkmolgbZq.lod@flex--seanjc.bounces.google.com>) id 6a751a4d-e002-0a2a0a5209dd-0a2a45078cde-40 for ; Fri, 07 Aug 2026 01:36:52 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3khp1agYKCfUpbXkgZdlldib.Zljubk-absbiifpqp.ubkmolgbZq.lod@flex--seanjc.bounces.google.com>) id 6a751a93-b4ea-0a2a45070019-d155d2c5e5a2-3 for ; Fri, 07 Aug 2026 01:36:52 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84e4ef9a74aso4706501b3a.1 for ; Thu, 06 Aug 2026 16:36:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059411; x=1786664211; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:reply-to:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GbCVidvwQkuTYRlTXFKmfz6LBshlnXLBUNEqveo1L6E=; b=CSCErPHu++GbfzI1KqY2HMp3e75UFu3AB5KOlsWAiRQTbuPqmt+lmQSiUGA/61iJtl J5fh5giRXJbwBgjcfI9RkXhsPlFnjfJEvxBfsJWyyreULgT8Mpz4VAabaepS+G73xuEM Y3QkqWD4RcxEG1vkthJUggExzKUXcNWk440LHra7kW/Snl2uER9dcLP6pXdDhh01Jk7u ljaCGbAJLI/UrGV6tOsQN9m9trzNzsUngAqqwiXmXLgxS5Gl7LzUtxRQhfGDR9vkCox7 Salk9YHE2TxAHmKgEmZlymHjp92YZ983s8K6a+fEqFbFMdme+s19nHCaf4bjWXZJPO8C ujuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059411; x=1786664211; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GbCVidvwQkuTYRlTXFKmfz6LBshlnXLBUNEqveo1L6E=; b=MMJUd3+Mb4i9+oIwHhTE6oakdUR3BiyYKBhLI8KvnSsGZFQ1fy8bzfg911QeOmM66V /D6kFQjBTWQOkKXygJi0N9TOEYDWbTNC22Ybec+ZcShE/fC6bwEX3/G4xpjI9DlAD7td tYj2x8XNdmEbIqDw7DDsdRnYRJGj1jqYDLp2IksmABAZ0NylIr5QcqX4WCWjkCa8b9G7 diwHBoX7rZP8JEL7dq+UhrZI69sRLIt06A9dftzEGgVd16CKy0NvyelvNgzqFYJjutai WtuZBsizVDM7rp05F9NgtSui4TL4wGvLpNcZV4peCHK+ZfVduoz0s/fLohXr7OV42atq 40/A== X-Forwarded-Encrypted: i=1; AHgh+RonBZB76IHxKDosIlXJMTlZKWKJVdVVB4H+Cic+SZRW+UrbCpiaUKIh1o1mUqF9y817No/DZGtDyzc=@lists.xenproject.org X-Gm-Message-State: AOJu0YzSAQDp1YBXPwXNtp0uRcLtz1eoQbazySYmiFJ+5amaZKpM+Iqa 1rELmb4Rsi985GKjxDF+1jSPM+WglFVBu7gHiNNMdyyTQTh+PplEexdtW5crzRMubdJqhjuXLNX +BOHzRQ== X-Received: from pfbll6.prod.google.com ([2002:a05:6a00:7286:b0:84e:a25:1e6b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3a12:b0:848:354f:4f8f with SMTP id d2e1a72fcca58-84f2dff3015mr20822585b3a.22.1786059410525; Thu, 06 Aug 2026 16:36:50 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:38 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-22-seanjc@google.com> Subject: [PATCH v6 21/51] x86/kvm: Obtain TSC frequency from PV CPUID if present From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-ef75cf/1786059412-354C3AE4-331BC121/0/0 X-purgate-type: clean X-purgate-size: 5045 From: David Woodhouse In https://lkml.org/lkml/2008/10/1/246 a proposal was made for generic CPUID conventions across hypervisors. It was mostly shot down in flames, but the leaf at 0x40000010 containing timing information didn't die. It's used by XNU and FreeBSD guests under all hypervisors=C2=B9=C2=B2 to de= termine the TSC frequency, and also exposed by the EC2 Nitro hypervisor (as well as, presumably, VMware). FreeBSD's Bhyve is probably just about to start exposing it too. Use it under KVM to obtain the TSC frequency more accurately, instead of reverse-calculating the frequency from the mul/shift values in the KVM clock. Use the information to get the CPU frequency as well (kvmclock feeds in kvm_get_tsc_khz() for both TSC and CPU calibration), as the info from CPUID is superior in every way; whether or not kvmclock should be overriding CPU calibration in the first place is an entirely different question. Use the info from CPUID even if the user explicitly disables kvmclock, or if it's unsupported. The PV CPUID leaf has no dependency on kvmclock, and is in fact more useful if kvmclock is disabled since the kernel won't be able to use kvmclock to derive a derive the TSC frequency. Before: [ 0.000020] tsc: Detected 2900.014 MHz processor After: [ 0.000020] tsc: Detected 2900.015 MHz processor $ cpuid -1 -l 0x40000010 CPU: hypervisor generic timing information (0x40000010): TSC frequency (Hz) =3D 2900015 bus frequency (Hz) =3D 1000000 Note! *Independently* query for non-null get_{cpu,tsc}_khz() overrides so that kvmclock doesn't clobber x86_init.hyper.get_cpu_khz() if/when KVM adds support for getting the CPU frequency separately from the TSC frequency. =C2=B9 https://github.com/apple/darwin-xnu/blob/main/osfmk/i386/cpuid.c =C2=B2 https://github.com/freebsd/freebsd-src/commit/4a432614f68 Signed-off-by: David Woodhouse Co-developed-by: Sean Christopherson Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvm.c | 33 +++++++++++++++++++++++++++++++++ arch/x86/kernel/kvmclock.c | 6 ++++-- 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 5b554e480c0e..8ed02f4f5775 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -49,6 +49,8 @@ #include #include =20 +static unsigned int kvm_tsc_khz_cpuid __initdata; + DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled); =20 static int kvmapf =3D 1; @@ -913,6 +915,21 @@ bool kvm_para_available(void) } EXPORT_SYMBOL_GPL(kvm_para_available); =20 +static u32 __init kvm_cpuid_timing_info_leaf(void) +{ + u32 base =3D kvm_cpuid_base(); + + if (!base || cpuid_eax(base) < (base | KVM_CPUID_TIMING_INFO)) + return 0; + + return base | KVM_CPUID_TIMING_INFO; +} + +static unsigned int __init kvm_get_tsc_khz(void) +{ + return kvm_tsc_khz_cpuid; +} + unsigned int kvm_arch_para_features(void) { return cpuid_eax(kvm_cpuid_base() | KVM_CPUID_FEATURES); @@ -962,6 +979,7 @@ static void __init kvm_init_platform(void) .mask_lo =3D (u32)(~(SZ_4G - tolud - 1)) | MTRR_PHYSMASK_V, .mask_hi =3D (BIT_ULL(boot_cpu_data.x86_phys_bits) - 1) >> 32, }; + u32 timing_info_leaf; =20 if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) && kvm_para_has_feature(KVM_FEATURE_MIGRATION_CONTROL)) { @@ -1009,6 +1027,21 @@ static void __init kvm_init_platform(void) wrmsrq(MSR_KVM_MIGRATION_CONTROL, KVM_MIGRATION_READY); } + + /* + * If KVM advertises the frequency directly in CPUID, use that instead + * of reverse-calculating it from the KVM clock data, or worse, trying + * to calibratate the TSC using an emulated device. + */ + timing_info_leaf =3D kvm_cpuid_timing_info_leaf(); + if (timing_info_leaf) { + kvm_tsc_khz_cpuid =3D cpuid_eax(timing_info_leaf); + if (kvm_tsc_khz_cpuid) { + x86_init.hyper.get_tsc_khz =3D kvm_get_tsc_khz; + x86_init.hyper.get_cpu_khz =3D kvm_get_tsc_khz; + } + } + kvmclock_init(); x86_platform.apic_post_init =3D kvm_apic_init; =20 diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 29ca37e9a3bc..f55d0305d1f3 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -342,8 +342,10 @@ void __init kvmclock_init(void) flags =3D pvclock_read_flags(&hv_clock_boot[0].pvti); kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); =20 - x86_init.hyper.get_tsc_khz =3D kvmclock_get_tsc_khz; - x86_init.hyper.get_cpu_khz =3D kvmclock_get_tsc_khz; + if (!x86_init.hyper.get_tsc_khz) + x86_init.hyper.get_tsc_khz =3D kvmclock_get_tsc_khz; + if (!x86_init.hyper.get_cpu_khz) + x86_init.hyper.get_cpu_khz =3D kvmclock_get_tsc_khz; x86_platform.get_wallclock =3D kvm_get_wallclock; x86_platform.set_wallclock =3D kvm_set_wallclock; #ifdef CONFIG_X86_LOCAL_APIC --=20 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:36:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:36:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385320.1627818 (Exim 4.92) (envelope-from ) id 1ws7dy-0003N6-KL; Thu, 06 Aug 2026 23:36:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385320.1627818; Thu, 06 Aug 2026 23:36:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7dy-0003Mh-Dz; Thu, 06 Aug 2026 23:36:58 +0000 Received: by outflank-mailman (input) for mailman id 1385320; Thu, 06 Aug 2026 23:36:57 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3lhp1agYKCfktfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 1ws7dx-00037d-0B for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dw-00Gcdg-Cl for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:56 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3lhp1agYKCfktfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 6a751a4d-e002-0a2a0a5209dd-0a2a45078cde-42 for ; Fri, 07 Aug 2026 01:36:56 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3lhp1agYKCfktfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 6a751a96-b4ea-0a2a45070019-d155d2c5e556-3 for ; Fri, 07 Aug 2026 01:36:56 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84e4ef9a74aso4706560b3a.1 for ; Thu, 06 Aug 2026 16:36:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059414; x=1786664214; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=RXgfgHNb2M05mbaK7fzwXMNXNJyNMqWfUYS+q8iqpyw=; b=n0LdWODQkNSZbGoDZGntD8WKnws5alyJdnc/uxbP/j+r+CdCJeqvgYDQDltEnnErwP Ey8JJjM0qHUTEi/HFHzjNvv61q3CpUQZXq0GCM+jpvF7R2UK0HRwtHAit7nzNEMdk89U qGg8Ihh7B8pjzS5Fb9ukDY/VRETSXgYMMbsOMwQWSiJ2lvAa9GFd/d9bAwMjB0uwy+mJ zC+SwbELrj4bv3Uei9loxb5isZE6l+dFqbUH0H6QAh337ncH+H2LeLY6mXnrkEWSai82 b3sXi/DD6pZdAZE0MY6O2+MVT91IPObgNI3AWSws+KEA4o4sLhirFwp6Zen2BoaFhuwi d41g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059414; x=1786664214; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RXgfgHNb2M05mbaK7fzwXMNXNJyNMqWfUYS+q8iqpyw=; b=f+EUNDwLQsuv4GPY2eElSzZBzVNsdKNzVxYgqybMjtwU5/Q/H92ehicekPCyC/2LV6 Rle714ArsDuDjB2RX9zwOgXfKyA8DyV4qOeAFvOeVFcdLobiRXGyprHnhNj1A2wIc+Mz 8ERWlUNyhjMk8iVherKd14pX/0M3UnXCnAZItKSqbEG0pYBBIrYDQTt2p9UhtmAFMhQT D//saACs2ysGuZnCJwo2Sghpm5+hZFG4SYz7KJzoy4a0lohNzpQC1S2BtR2eMZlvjdlK aYhjU/CQShYK6wdyRWnjDJ2f5jJfabd7PP6p2j3k/pvGLq+ht+oOdAhNQZ4/A0gA2tmb TKLg== X-Forwarded-Encrypted: i=1; AHgh+Rpq6KWhDx8TcgourNkGdeFapvF2mg1s/Nss16Y/EMMFXVfx9XJHe1nvm4huR8sB8E0PSOBs9sWuDVA=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzj2WvDiylOCf7k5j65NCtPSHtpmVgrWCRIR8ycTeGEAZlmDl6A CubXjdrCI5t9+n29gMF7het3yooUbox04RpM1h7gYedmfw2TtCI1vncW73vETLmlVPXZZR89zAf UnY3RYQ== X-Received: from pfcy7.prod.google.com ([2002:a05:6a00:93c7:b0:845:e683:1287]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:6e81:b0:84e:2bb:2d3e with SMTP id d2e1a72fcca58-84f2dfb4e50mr16994834b3a.9.1786059414067; Thu, 06 Aug 2026 16:36:54 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:41 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-25-seanjc@google.com> Subject: [PATCH v6 24/51] x86/kvm: Get CPU base frequency from CPUID when it's available From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1786059416-A60C5AE4-38FBD5C8/0/0 X-purgate-type: clean X-purgate-size: 1756 If CPUID.0x16 is present and valid, use the CPU frequency provided by CPUID instead of assuming that the virtual CPU runs at the same frequency as TSC and/or kvmclock. Back before constant TSCs were a thing, treating the TSC and CPU frequencies as one and the same was somewhat reasonable, but now it's nonsensical, especially if the hypervisor explicitly enumerates the CPU frequency. Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvm.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 255a24a99f28..83b9351f2810 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -50,6 +50,7 @@ #include static unsigned int kvm_tsc_khz_cpuid __initdata; +static unsigned int kvm_cpu_khz_cpuid __initdata; DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled); @@ -930,6 +931,11 @@ static unsigned int __init kvm_get_tsc_khz(void) return kvm_tsc_khz_cpuid; } +static unsigned int __init kvm_get_cpu_khz(void) +{ + return kvm_cpu_khz_cpuid; +} + unsigned int kvm_arch_para_features(void) { return cpuid_eax(kvm_cpuid_base() | KVM_CPUID_FEATURES); @@ -1043,6 +1049,14 @@ static void __init kvm_init_platform(void) } } + /* + * Prefer CPUID.0x16 over KVM's PV CPUID when possible, as the base CPU + * frequency isn't necessarily the same as the TSC frequency. + */ + kvm_cpu_khz_cpuid = __cpu_khz_from_cpuid(); + if (kvm_cpu_khz_cpuid) + x86_init.hyper.get_cpu_khz = kvm_get_cpu_khz; + /* * If the TSC counts at a constant frequency across P/T states and in * deep C-states, treat the TSC reliable, as guaranteed by KVM. -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:37:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:37:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385330.1627827 (Exim 4.92) (envelope-from ) id 1ws7e1-0003oo-Vo; Thu, 06 Aug 2026 23:37:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385330.1627827; Thu, 06 Aug 2026 23:37:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7e1-0003oc-Q6; Thu, 06 Aug 2026 23:37:01 +0000 Received: by outflank-mailman (input) for mailman id 1385330; Thu, 06 Aug 2026 23:36:59 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3mBp1agYKCfsvhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 1ws7dz-0003Va-EL for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:36:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7dy-005BVk-Ra for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:36:58 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3mBp1agYKCfsvhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 6a751a9a-5cb7-0a2a0a5109dd-0a2a4507ada8-0 for ; Fri, 07 Aug 2026 01:36:58 +0200 Received: from [209.85.215.197] (helo=mail-pg1-f197.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3mBp1agYKCfsvhdqmfjrrjoh.frp0hq-ghyhoolvwv.0hqsurmhfw.ruj@flex--seanjc.bounces.google.com>) id 6a751a99-b4ea-0a2a45070019-d155d7c5c430-3 for ; Fri, 07 Aug 2026 01:36:58 +0200 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb11535e6a1so2334989a12.0 for ; Thu, 06 Aug 2026 16:36:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059417; x=1786664217; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=mGO2RWCI+1OC1QgQlwRZRpcTYMYFszJFieAT3RQjORg=; b=E12iinLPKW0UPbyF7VCB8n5hfuuRtfdwFrg9iU/wapa7Q9dCWo4alPhYiw7A0xXwoL 6pOZgajVAaF7i5HzK9rTaUBXJB/jhshj+5fUGV13O41fexyzGrNySi2KpLErs3cNtrmM KZqwhUG9meUtzNPnT36BoIYdMKfh9l4NaULqtRgfrBiaurXgOVZQAjocUH+PMp/r7nI9 GNFmQUubVoM6phDJBNDuWJgIL7a4j7+2kWGK1Hh58GRyFIxCT1nhQ/6wMzbb4nVltiq1 oO7t3QlXe8t3hG3+EvKOdyGK9WWLQ5DG2Zz94AhMpqkAW4TuBdyVB+6SjAP8J/QFFr0B tyfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059417; x=1786664217; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mGO2RWCI+1OC1QgQlwRZRpcTYMYFszJFieAT3RQjORg=; b=P/dXzTyyDX2V4dHwUMfBWRtdHOmmlR6fRFXPHQx0OA56W0CzbqDH4aN9L9qEz3tMko Z7LUVXQdljd09Sa84IGMjZ4var2+EAElJtpZwLJV9VrPv3HLZK+PFDEhstyeVPFZLd0K A1Jr6QPh4w2lLSHGGHYQaHz+Opi2oon//XhUbgN9egGCGzSQC+4G36V5B7p7Q5VrtBhq bUrnpvq2+ObgngYlrrcj7pxhRlbcc/93gcZL6eZjiFnRx4fWq+4zpUX5+ZXiwnLtTNi7 X/Eg4NebNXIespVgx100H8pMH+An1rYRRG/H7avyxQU8AZfRJl6IjJkFMHYX/k0U7Cd+ RpyQ== X-Forwarded-Encrypted: i=1; AHgh+RrzZzQoPb7p2MJf89ByKSyVgbvVj6Ai/DjGfynbNk+N8/rl8St6BTXtxRRgHahf+o3vCrjUTQZo5x8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzOTdsxwvCX475/20fxShqiXq9tyz6RRZ2f9BxL65vt/RQtfF3S oQOjayOzRTS+VFI48sIaVA3p7LuWpe+nwEJoZWPwMPN35pFcI7JY3RCcJKvSaeWgYVp1BQsRXjU 3qmNDYw== X-Received: from pgmj25.prod.google.com ([2002:a63:5959:0:b0:c9e:364c:61a2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:329c:b0:3c3:8315:80b7 with SMTP id adf61e73a8af0-3cb85e9757amr21773483637.9.1786059416350; Thu, 06 Aug 2026 16:36:56 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:43 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-27-seanjc@google.com> Subject: [PATCH v6 26/51] clocksource: hyper-v: Drop wrappers to sched_clock save/restore helpers From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1786059418-A76D2AE4-D9FCF316/0/0 X-purgate-type: clean X-purgate-size: 3432 Now that all of the Hyper-V reference counter sched_clock code is located in a single file, drop the superfluous wrappers for the save/restore flows. No functional change intended. Reviewed-by: Michael Kelley Tested-by: Michael Kelley Acked-by: Wei Liu Signed-off-by: Sean Christopherson --- drivers/clocksource/hyperv_timer.c | 34 +++++------------------------- include/clocksource/hyperv_timer.h | 2 -- 2 files changed, 5 insertions(+), 31 deletions(-) diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index 4293173c3a27..daa8cbfe61ee 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -488,17 +488,6 @@ static void resume_hv_clock_tsc(struct clocksource *arg) hv_set_msr(HV_MSR_REFERENCE_TSC, tsc_msr.as_uint64); } -/* - * Called during resume from hibernation, from overridden - * x86_platform.restore_sched_clock_state routine. This is to adjust offsets - * used to calculate time for hv tsc page based sched_clock, to account for - * time spent before hibernation. - */ -void hv_adj_sched_clock_offset(u64 offset) -{ - hv_sched_clock_offset -= offset; -} - #ifdef HAVE_VDSO_CLOCKMODE_HVCLOCK static int hv_cs_enable(struct clocksource *cs) { @@ -565,12 +554,14 @@ static void (*old_restore_sched_clock_state)(void); * based clocksource, proceeds from where it left off during suspend and * it shows correct time for the timestamps of kernel messages after resume. */ -static void save_hv_clock_tsc_state(void) +static void hv_save_sched_clock_state(void) { + old_save_sched_clock_state(); + hv_ref_counter_at_suspend = hv_read_reference_counter(); } -static void restore_hv_clock_tsc_state(void) +static void hv_restore_sched_clock_state(void) { /* * Adjust the offsets used by hv tsc clocksource to @@ -578,23 +569,8 @@ static void restore_hv_clock_tsc_state(void) * adjusted value = reference counter (time) at suspend * - reference counter (time) now. */ - hv_adj_sched_clock_offset(hv_ref_counter_at_suspend - hv_read_reference_counter()); -} -/* - * Functions to override save_sched_clock_state and restore_sched_clock_state - * functions of x86_platform. The Hyper-V clock counter is reset during - * suspend-resume and the offset used to measure time needs to be - * corrected, post resume. - */ -static void hv_save_sched_clock_state(void) -{ - old_save_sched_clock_state(); - save_hv_clock_tsc_state(); -} + hv_sched_clock_offset -= (hv_ref_counter_at_suspend - hv_read_reference_counter()); -static void hv_restore_sched_clock_state(void) -{ - restore_hv_clock_tsc_state(); old_restore_sched_clock_state(); } diff --git a/include/clocksource/hyperv_timer.h b/include/clocksource/hyperv_timer.h index d48dd4176fd3..a4c81a60f53d 100644 --- a/include/clocksource/hyperv_timer.h +++ b/include/clocksource/hyperv_timer.h @@ -38,8 +38,6 @@ extern void hv_remap_tsc_clocksource(void); extern unsigned long hv_get_tsc_pfn(void); extern struct ms_hyperv_tsc_page *hv_get_tsc_page(void); -extern void hv_adj_sched_clock_offset(u64 offset); - static __always_inline bool hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page *tsc_pg, u64 *cur_tsc, u64 *time) -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:37:17 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:37:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385367.1627835 (Exim 4.92) (envelope-from ) id 1ws7eH-0005E1-EI; Thu, 06 Aug 2026 23:37:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385367.1627835; Thu, 06 Aug 2026 23:37:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7eH-0005Dq-At; Thu, 06 Aug 2026 23:37:17 +0000 Received: by outflank-mailman (input) for mailman id 1385367; Thu, 06 Aug 2026 23:37:16 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3qRp1agYKCQ46so1xqu22uzs.q20Bs1-rs9szzw676.Bs1352xsq7.25u@flex--seanjc.bounces.google.com>) id 1ws7eF-00056Z-VC for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:37:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7eF-00Gchi-CG for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:37:15 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3qRp1agYKCQ46so1xqu22uzs.q20Bs1-rs9szzw676.Bs1352xsq7.25u@flex--seanjc.bounces.google.com>) id 6a751aa2-bab6-0a2a0a5309dd-0a2a4505a808-16 for ; Fri, 07 Aug 2026 01:37:15 +0200 Received: from [209.85.216.70] (helo=mail-pj1-f70.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3qRp1agYKCQ46so1xqu22uzs.q20Bs1-rs9szzw676.Bs1352xsq7.25u@flex--seanjc.bounces.google.com>) id 6a751aa9-4cb1-0a2a45050019-d155d846b569-3 for ; Fri, 07 Aug 2026 01:37:15 +0200 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38f5ac7354dso3867268a91.1 for ; Thu, 06 Aug 2026 16:37:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059433; x=1786664233; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=rt852L9wHdv0bDRlKJAMITX85TrVIH1oxytQu/w6xUg=; b=hB1cuZKpyyowQkIuPIQPK4SDD3mNXcl+F3g0EdPblRujk6bQ6RazudGIEWHYIcZtgo sIMC2Cqxg5QFcEi7nwmq7Y9ACLV8OUHwqovnj/Ey3b8eY50flNmugiB+24pDA6I8YJcf NHf8TctOk5YPbVDomx7BJ8KxYa7y0/pR0DPMYLuN8YyWn3fi8B8rVU3iqsBGoP+zE6IV yx6EGhn0qSrooSOUiInhsdSPGWt7Wd84kQt1kVvsb26qWjPuDZmOylfQcHQfs6YXgfeC CA8gtN1RtiODWWbMqZnHkxVhLFlccxwlsMKQdJ3KylbjOAzqHW3tL/bAlY8rSFhUFeIi S9rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059433; x=1786664233; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rt852L9wHdv0bDRlKJAMITX85TrVIH1oxytQu/w6xUg=; b=daDMgkg9YrrssARbkmqGLyFrDHPb6Js6uCb7ektGKD2hmL6hczZrqRnVvDSmPBMlLi Ak803lbErSVzGPQAL7ficTzY4HZta3dTrsVasUeqxKdXpE/D2SOmK4l/Dj5aZdaOSxTy P9UGEEUz6Py+casuPqOjevbEq10PqRKldoZXCitf8q6Nsl25NegQmAa47UohTeOwWJjo rJnYoKe9n9VXtClSQvXc9L/WSYXUARbEb950NyO3S+WUOS5jCzFsY1bFN1ss781Id/yx cojWbWlHk9U5kct5wfgfolnJ2yGgPZa8iZn/NiWXbngz0beXFTy/t1T0o4qI8UAmDNje t95Q== X-Forwarded-Encrypted: i=1; AHgh+RrF30tF+Z4W+fml7WgPHbKrPibBg7yOEdrF+Hairo4bSKf7RZTgJGBXui1W8LW6AYhkGTI88Lwuso4=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzy1PesDviqwhZeAAltjENPqzSZ3jQYOF1fuVZ6m795kuqBiHpY G0LW3n7e4VHyvHLfOgRWN4OrO+yfIaJoD3MT9SbeGkoKWFuQnWbIQ1KDdIEBFgHOqHRGgUBZAUn QgDO1sA== X-Received: from pgkd23.prod.google.com ([2002:a63:f257:0:b0:cbe:7907:901]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:d52c:b0:3c3:812a:2198 with SMTP id adf61e73a8af0-3cb85df190amr24070365637.4.1786059433092; Thu, 06 Aug 2026 16:37:13 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:56 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-40-seanjc@google.com> Subject: [PATCH v6 39/51] x86/pvclock: Mark setup helpers and related various as __init/__ro_after_init From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c201ff/1786059435-F62AB2A1-C6F9C289/0/0 X-purgate-type: clean X-purgate-size: 1384 Now that Xen PV clock and kvmclock explicitly do setup only during init, tag the common PV clock flags/vsyscall variables and their mutators with __init. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/pvclock.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c index b3f81379c2fc..a51adce67f92 100644 --- a/arch/x86/kernel/pvclock.c +++ b/arch/x86/kernel/pvclock.c @@ -16,10 +16,10 @@ #include #include -static u8 valid_flags __read_mostly = 0; -static struct pvclock_vsyscall_time_info *pvti_cpu0_va __read_mostly; +static u8 valid_flags __ro_after_init = 0; +static struct pvclock_vsyscall_time_info *pvti_cpu0_va __ro_after_init; -void pvclock_set_flags(u8 flags) +void __init pvclock_set_flags(u8 flags) { valid_flags = flags; } @@ -153,7 +153,7 @@ void pvclock_read_wallclock(struct pvclock_wall_clock *wall_clock, set_normalized_timespec64(ts, now.tv_sec, now.tv_nsec); } -void pvclock_set_pvti_cpu0_va(struct pvclock_vsyscall_time_info *pvti) +void __init pvclock_set_pvti_cpu0_va(struct pvclock_vsyscall_time_info *pvti) { WARN_ON(vclock_was_used(VDSO_CLOCKMODE_PVCLOCK)); pvti_cpu0_va = pvti; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:37:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:37:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385396.1627845 (Exim 4.92) (envelope-from ) id 1ws7ed-0006gr-MS; Thu, 06 Aug 2026 23:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385396.1627845; Thu, 06 Aug 2026 23:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7ed-0006gk-Iw; Thu, 06 Aug 2026 23:37:39 +0000 Received: by outflank-mailman (input) for mailman id 1385396; Thu, 06 Aug 2026 23:37:38 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3gxp1agYKCeYaMIVRKOWWOTM.KWUfMV-LMdMTTQaba.fMVXZWRMKb.WZO@flex--seanjc.bounces.google.com>) id 1ws7ec-0006d5-23 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:37:38 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7eb-005Ba1-FM for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:37:37 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3gxp1agYKCeYaMIVRKOWWOTM.KWUfMV-LMdMTTQaba.fMVXZWRMKb.WZO@flex--seanjc.bounces.google.com>) id 6a751a9a-5cb7-0a2a0a5109dd-0a2a4507ada8-40 for ; Fri, 07 Aug 2026 01:37:37 +0200 Received: from [209.85.216.72] (helo=mail-pj1-f72.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3gxp1agYKCeYaMIVRKOWWOTM.KWUfMV-LMdMTTQaba.fMVXZWRMKb.WZO@flex--seanjc.bounces.google.com>) id 6a751a83-b4ea-0a2a45070019-d155d848c1f7-3 for ; Fri, 07 Aug 2026 01:36:37 +0200 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38827cee19eso3452825a91.3 for ; Thu, 06 Aug 2026 16:36:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059395; x=1786664195; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=rOLPH8cbFzmNmyBMg+VXArbJGugFBL/MCFG1XvEwkdc=; b=lwAodFCpFUQJmlJC04f9nWHxfIs2WuX48vI7pZAX3odWybVzRnOc9+pvkw9adIymUO urQewPv6r80YNXWtBIZWn5TeLv4dPcbdWkXBxYL9hJiwh33Tb1jqx2xR7gTdozfL73t7 8lpXkNITCI2X3eK2x0NqN7Q/uhni37bTCuG7nPN1ZKFeEve9bR4VgWr9mq5iqhuScLeL Pu3AY/DRdLi9QZlGB/atYjL4b4F/nvMija/y1BDGiIYa9dhRwuvZCkbhuTkNetb8uCD4 qk/NR9grTk7NDvX7USf5T/vjJChs4aNiOoig8Y8mgEx4YfsmDyj1EjcQ81KEDRz0Pmhv I/6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059395; x=1786664195; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rOLPH8cbFzmNmyBMg+VXArbJGugFBL/MCFG1XvEwkdc=; b=qaXXaPH5DDU4772U9XXg6CijfGjBYEf26VshQnb0Q5MOIHfGeLdBgMwkkQgh1J7T1B Rs9H1VRJoKaH88oeMXGXED7OTxlPQarWgUTYqRMixNiel6/6TbVoLTMHnh8RKTI9mrkH NoIR+HtLfl+GsVzZpyO/tcW5vjsewJJHR9rTk0UAHLV0M9nCQL3mtdgfAKd/uOFvZQFQ 8OZMTki0tD5mPH8BYsi7MLIxpJ7q6GHvXjj37O5frLvlJBXtIYgoYXhxZqoEOU5fFi7A aCTFQapq5QKahCCWAsE3jEAv9gv51LtxH2yRy63kSsX4nWCCVm/eHqCLG7QmPpefn0Ga KSRA== X-Forwarded-Encrypted: i=1; AHgh+Rr2Jt8VQKmwafNOzsyuH5kJng+W2TegCZI/a1GtkdgXzbriMUI2aNvFEbNOlJapq7XHElGPtq6faII=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy6ftfqQzK45nudAlBUnntuOSKc6Ebwf3mOYu2fboWJAxVSIGGU nJIdIK4BerXDJbNRnNN1pUXZvXvVkGC8fmBllXerOUmChJCPlasjV3nsTCSbLModMSay95xgegt nxlUpSw== X-Received: from pjte20.prod.google.com ([2002:a17:90a:c214:b0:38e:7f69:82cf]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5683:b0:38e:6aa7:68ad with SMTP id 98e67ed59e1d1-3903c54fbc4mr18735745a91.5.1786059395009; Thu, 06 Aug 2026 16:36:35 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:26 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-10-seanjc@google.com> Subject: [PATCH v6 09/51] x86/tsc: Add a standalone helper for getting TSC info from CPUID.0x15 From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1786059397-A62C4AE4-EF248B82/13/0 X-purgate-type: clean X-purgate-size: 4246 Extract retrieval of TSC frequency information from CPUID into a standalone helper so that TDX guest support can reuse the logic. Opportunistically drop native_calibrate_tsc()'s "== 0" and "!= 0" checks in favor of the kernel's preferred style. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 61 +++++++++++++++++++++++++++---------------- 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 6898584610a7..d405ff4e45e0 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -645,46 +645,62 @@ static unsigned long quick_pit_calibrate(void) return delta; } +struct cpuid_tsc_info { + unsigned int denominator; + unsigned int numerator; + unsigned int crystal_khz; +}; + +static int cpuid_get_tsc_info(struct cpuid_tsc_info *info) +{ + unsigned int ecx_hz, edx; + + if (boot_cpu_data.cpuid_level < CPUID_LEAF_TSC) + return -ENOENT; + + /* CPUID 15H TSC/Crystal ratio, plus optionally Crystal Hz */ + cpuid(CPUID_LEAF_TSC, &info->denominator, &info->numerator, &ecx_hz, &edx); + + if (!info->denominator || !info->numerator) + return -ENOENT; + + /* + * Note: some CPUs provide the multiplier information, but not the core + * crystal frequency. The multiplier information is still useful for + * such CPUs, as the crystal frequency can be gleaned from CPUID.0x16. + */ + info->crystal_khz = ecx_hz / 1000; + return 0; +} + /** * native_calibrate_tsc - determine TSC frequency * Determine TSC frequency via CPUID, else return 0. */ unsigned long native_calibrate_tsc(void) { - unsigned int eax_denominator, ebx_numerator, ecx_hz, edx; - unsigned int crystal_khz; + struct cpuid_tsc_info info; if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) return 0; - if (boot_cpu_data.cpuid_level < CPUID_LEAF_TSC) + if (cpuid_get_tsc_info(&info)) return 0; - eax_denominator = ebx_numerator = ecx_hz = edx = 0; - - /* CPUID 15H TSC/Crystal ratio, plus optionally Crystal Hz */ - cpuid(CPUID_LEAF_TSC, &eax_denominator, &ebx_numerator, &ecx_hz, &edx); - - if (ebx_numerator == 0 || eax_denominator == 0) - return 0; - - crystal_khz = ecx_hz / 1000; - /* * Denverton SoCs don't report crystal clock, and also don't support * CPUID_LEAF_FREQ for the calculation below, so hardcode the 25MHz * crystal clock. */ - if (crystal_khz == 0 && - boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT_D) - crystal_khz = 25000; + if (!info.crystal_khz && boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT_D) + info.crystal_khz = 25000; /* * TSC frequency reported directly by CPUID is a "hardware reported" * frequency and is the most accurate one so far we have. This * is considered a known frequency. */ - if (crystal_khz != 0) + if (info.crystal_khz) setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); /* @@ -692,15 +708,14 @@ unsigned long native_calibrate_tsc(void) * clock, but we can easily calculate it to a high degree of accuracy * by considering the crystal ratio and the CPU speed. */ - if (crystal_khz == 0 && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) { + if (!info.crystal_khz && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) { unsigned int eax_base_mhz, ebx, ecx, edx; cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx, &ecx, &edx); - crystal_khz = eax_base_mhz * 1000 * - eax_denominator / ebx_numerator; + info.crystal_khz = eax_base_mhz * 1000 * info.denominator / info.numerator; } - if (crystal_khz == 0) + if (!info.crystal_khz) return 0; /* @@ -716,9 +731,9 @@ unsigned long native_calibrate_tsc(void) * lapic_timer_period here to avoid having to calibrate the APIC * timer later. */ - apic_set_timer_frequency_khz(crystal_khz, "CPUID 0x15/0x16"); + apic_set_timer_frequency_khz(info.crystal_khz, "CPUID 0x15/0x16"); - return crystal_khz * ebx_numerator / eax_denominator; + return info.crystal_khz * info.numerator / info.denominator; } static unsigned long cpu_khz_from_cpuid(void) -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:37:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:37:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385400.1627854 (Exim 4.92) (envelope-from ) id 1ws7eg-0007EM-U6; Thu, 06 Aug 2026 23:37:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385400.1627854; Thu, 06 Aug 2026 23:37:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7eg-0007EE-Qv; Thu, 06 Aug 2026 23:37:42 +0000 Received: by outflank-mailman (input) for mailman id 1385400; Thu, 06 Aug 2026 23:37:41 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3hhp1agYKCekdPLYUNRZZRWP.NZXiPY-OPgPWWTded.iPYacZUPNe.ZcR@flex--seanjc.bounces.google.com>) id 1ws7ef-0007C5-H1 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:37:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7ee-005Ba1-UG for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:37:40 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3hhp1agYKCekdPLYUNRZZRWP.NZXiPY-OPgPWWTded.iPYacZUPNe.ZcR@flex--seanjc.bounces.google.com>) id 6a751a9a-5cb7-0a2a0a5109dd-0a2a4507ada8-46 for ; Fri, 07 Aug 2026 01:37:40 +0200 Received: from [209.85.216.70] (helo=mail-pj1-f70.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3hhp1agYKCekdPLYUNRZZRWP.NZXiPY-OPgPWWTded.iPYacZUPNe.ZcR@flex--seanjc.bounces.google.com>) id 6a751a87-b4ea-0a2a45070019-d155d846e5fb-3 for ; Fri, 07 Aug 2026 01:36:40 +0200 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3811279d51aso4526963a91.1 for ; Thu, 06 Aug 2026 16:36:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059399; x=1786664199; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=yV4aOROKwLK4YUA2A0rPmI+8Xp1hkN/OxQzRiMqFKuI=; b=Ih1hwm2k2Rkv49kqy7aXuFUm2Xr7H64db2H163AG0uodO0EPKODbA/UZ9gKh/vbVRa L7RvN4RKp34VICoQbth75MJ6Ho5qE4meAjBT47lcThaGytdruq4eAwxHRM92nfgqfGdV 8/YvWFinMeaRoN8hhYcFc/1tltLqp8ON6UdQ8BfcmV6HYhT9cKBQ7b4miGRaKiEp57NX fCvBEt3GvdmQPBsC/gpeYIrapXGHWxp1CHFforqky8RF6Wm1lI0OTnIcfnpMOfOmCmUF 5kfkVa9AJFhok/xxtFiHF67887uP93mxqk3Wl4I2radt1HJwB+Ie0w4gyqUAmNKV9ZdI fQXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059399; x=1786664199; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=yV4aOROKwLK4YUA2A0rPmI+8Xp1hkN/OxQzRiMqFKuI=; b=sOFEGUFl9gEr415oPIh+wFA1es+LXUoAfSrs1n6KmEcrw+/dF7BuZDIJmEBdP8a5WC HpE1GHq3LlAPocBg9Ij4i/bTfFHurzCEEc+i6ToQka+Z0lWJCthe/FMeOWwurKS7y9Rg F8Qx2rm4hCoI13mRAhlwF+jSS9PunDaEspUHw0R3jawG92A/Oox/Fp7XqThXWkEDl0GZ 17/jOIvVAkw/lPhhfKXwTA8Yh+NPsP73RgvihZLE937VrdRqDfQCftiUuxzqHT5Opi6E rz3QvDWKJyVlcNsMGW/jRkoOmPpOxZDUXLu045nrWJNq/kr+zFJv0iJWZ7Rj6dSVAg6B FMSA== X-Forwarded-Encrypted: i=1; AHgh+RqgG2QEPKUv/06J2cXOQFFuJgbE6r+043DWTeAyT5KC0Z+6lovHhyBZ+8jiSvC4H0cKXeT3SieDv0s=@lists.xenproject.org X-Gm-Message-State: AOJu0YxTpzjEVN8Pj7cIjstv+vRD8nLBZQ587qjmTf61eUumsxtlWuoy DtkLAwaft0CFFi66/io9enMafqq6youWP/oU1DMWz7jwSRLDnrcjJN045MfjIgfpKL799tUYOoQ 5RF/CdQ== X-Received: from pjbqa7.prod.google.com ([2002:a17:90b:4fc7:b0:38e:bbd1:f3c8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:c88e:b0:38e:488f:7068 with SMTP id 98e67ed59e1d1-3903c5373b4mr20563002a91.2.1786059398528; Thu, 06 Aug 2026 16:36:38 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:29 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-13-seanjc@google.com> Subject: [PATCH v6 12/51] x86/acrn: Register TSC/CPU frequency callbacks iff frequency is actually in CPUID From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1786059400-360C5AE4-60DE75CB/13/0 X-purgate-type: clean X-purgate-size: 1812 Register ACRN's TSC/CPU frequency overrides if and only if the exact TSC frequency is actually provided in CPUID. This will allow marking the TSC as reliable as appropriate, and avoids relying on the caller to handle "failure". For all intents and purposes, no functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/acrn.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index ad8f2da8003b..dc71a6fdd461 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -19,6 +19,8 @@ #include #include +static unsigned int acrn_tsc_khz_cpuid __initdata; + static u32 __init acrn_detect(void) { return acrn_cpuid_base(); @@ -26,13 +28,19 @@ static u32 __init acrn_detect(void) static unsigned int __init acrn_get_tsc_khz(void) { - return cpuid_eax(ACRN_CPUID_TIMING_INFO); + return acrn_tsc_khz_cpuid; } static void __init acrn_init_platform(void) { /* Install system interrupt handler for ACRN hypervisor callback */ sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); + + acrn_tsc_khz_cpuid = cpuid_eax(ACRN_CPUID_TIMING_INFO); + if (acrn_tsc_khz_cpuid) { + x86_init.hyper.get_tsc_khz = acrn_get_tsc_khz; + x86_init.hyper.get_cpu_khz = acrn_get_tsc_khz; + } } static bool acrn_x2apic_available(void) @@ -80,6 +88,4 @@ const __initconst struct hypervisor_x86 x86_hyper_acrn = { .type = X86_HYPER_ACRN, .init.init_platform = acrn_init_platform, .init.x2apic_available = acrn_x2apic_available, - .init.get_tsc_khz = acrn_get_tsc_khz, - .init.get_cpu_khz = acrn_get_tsc_khz, }; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:37:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385403.1627864 (Exim 4.92) (envelope-from ) id 1ws7em-0007x0-AS; Thu, 06 Aug 2026 23:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385403.1627864; Thu, 06 Aug 2026 23:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7em-0007w3-5V; Thu, 06 Aug 2026 23:37:48 +0000 Received: by outflank-mailman (input) for mailman id 1385403; Thu, 06 Aug 2026 23:37:46 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3ixp1agYKCe4iUQdZSWeeWbU.SecnUd-TUlUbbYiji.nUdfheZUSj.ehW@flex--seanjc.bounces.google.com>) id 1ws7ek-0007la-Rq for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:37:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7ek-009HY2-4A for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:37:46 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3ixp1agYKCe4iUQdZSWeeWbU.SecnUd-TUlUbbYiji.nUdfheZUSj.ehW@flex--seanjc.bounces.google.com>) id 6a751aa4-e002-0a2a0a5209dd-0a2a4503b82a-16 for ; Fri, 07 Aug 2026 01:37:46 +0200 Received: from [209.85.216.69] (helo=mail-pj1-f69.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3ixp1agYKCe4iUQdZSWeeWbU.SecnUd-TUlUbbYiji.nUdfheZUSj.ehW@flex--seanjc.bounces.google.com>) id 6a751a8c-fae8-0a2a45030019-d155d845c026-3 for ; Fri, 07 Aug 2026 01:36:45 +0200 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38ce7fabf76so4358982a91.2 for ; Thu, 06 Aug 2026 16:36:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059404; x=1786664204; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=VAfqOqpweyKvsFpq/agEYC9CEWnfcmlui4k8L8ZR5pE=; b=l8v/bFCH5DueBriRFBLsBOvg00nFAJB1SYanY2hZ0S51HjAOZSeZcZzMAJSXKw60b5 ZQqEkG0nLm43ahHa02+ZXd86NibWujsh6PEouC3li5X5QZB6q8RZlWS/221/IfoNW2Yb xZSHiCmSQxxG7Y/Zc0xXbI6JRg7NPsbFKhwCgy0un/4cnV9f2w25e2Nx84WE7PGEg9FL HEg5tVPkMXp6JvtUq8fdBbreljIsgyp//3q/cmCcRVw42ECTiEjLTQtI/+QVPpriPW5G sdRhqrZCD7Vk2fO8TXDMwvYOqM3SWkw7yLyanEsb2G+Fcry6wiQ3mIvED5rzA/KqEyd3 j74Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059404; x=1786664204; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=VAfqOqpweyKvsFpq/agEYC9CEWnfcmlui4k8L8ZR5pE=; b=hTEKz2SBgBT/9LDb45Qm1dWH5PGYsTlQ/V0KzAWFvtV+Dmr7M2av5isoo6GDoEDzyQ SqEEB0bm3WNcU50GvqyGRMP1utVBAWI9OV4nbz6P/YxzpcjHYELjljTQTsCQOtQ4oWHs k5pQ8ooHXPMz71+0tNeVkmF1TdG0A9sG4hC/dKRknkVs9kN7R9Jns4hKtkxDMjYOn+ce n9T2ppfhbX+EvDhF5O0XtLDO6zP4HiMeL74RQFbpFkqYsohBd1A2RhPv4OPJAyN1AvlU YTAcV1inC4DpgY6Fg/GYVwwfxbaO4ltsMLiKJeJsT4BOMT6wB3+4pFGJzAzCd/epOEYo G0Pg== X-Forwarded-Encrypted: i=1; AHgh+RrISvcwfZAvUTl5UmR9J848KKtuOR0UvSBrWDPxa7TzkUgUULzDXLU8l0XAuh2kSk81DieEaoYspUw=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxsd2U6QacbHWYWiRHYcn2H55q40HSsE2ggVVPAaH+cK6ixku2q nFNeb6rJAjMdb5gqNH5Bys1LBFPo41doJfqbynpDuBj0P6Ttyk82rj514k7JuLVyLJrp0phnYCR gywRr+A== X-Received: from pjbcu4.prod.google.com ([2002:a17:90a:fa84:b0:381:7fb0:5a60]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:288b:b0:38e:8300:af51 with SMTP id 98e67ed59e1d1-3903c54d040mr19813478a91.8.1786059403683; Thu, 06 Aug 2026 16:36:43 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:33 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-17-seanjc@google.com> Subject: [PATCH v6 16/51] x86/tsc: Rename pit_hpet_ptimer_calibrate_cpu() => native_calibrate_cpu_late() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1786059406-6F6C64E9-EC6DA9E6/13/0 X-purgate-type: clean X-purgate-size: 1430 Rename the late CPU calibration routine so that its relationship to the early routine is more obvious and intuitive. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 1d41ef1db27c..dd9e04e325d6 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -752,7 +752,7 @@ static unsigned long cpu_khz_from_cpuid(void) * calibrate cpu using pit, hpet, and ptimer methods. They are available * later in boot after acpi is initialized. */ -static unsigned long pit_hpet_ptimer_calibrate_cpu(void) +static unsigned long native_calibrate_cpu_late(void) { u64 tsc1, tsc2, delta, ref1, ref2; unsigned long tsc_pit_min = ULONG_MAX, tsc_ref_min = ULONG_MAX; @@ -927,7 +927,7 @@ static unsigned long native_calibrate_cpu(void) unsigned long tsc_freq = native_calibrate_cpu_early(); if (!tsc_freq) - tsc_freq = pit_hpet_ptimer_calibrate_cpu(); + tsc_freq = native_calibrate_cpu_late(); return tsc_freq; } @@ -1472,7 +1472,7 @@ static bool __init determine_cpu_tsc_frequencies(bool early, else tsc_khz = native_calibrate_tsc(); } else { - cpu_khz = pit_hpet_ptimer_calibrate_cpu(); + cpu_khz = native_calibrate_cpu_late(); } /* -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:38:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:38:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385420.1627872 (Exim 4.92) (envelope-from ) id 1ws7fA-0001fu-LW; Thu, 06 Aug 2026 23:38:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385420.1627872; Thu, 06 Aug 2026 23:38:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7fA-0001fn-Ij; Thu, 06 Aug 2026 23:38:12 +0000 Received: by outflank-mailman (input) for mailman id 1385420; Thu, 06 Aug 2026 23:38:11 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3pBp1agYKCQk1njwslpxxpun.lxv6nw-mn4nuur121.6nwy0xsnl2.x0p@flex--seanjc.bounces.google.com>) id 1ws7f9-0001bN-1H for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:38:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7f8-005Ba1-ET for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:38:10 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3pBp1agYKCQk1njwslpxxpun.lxv6nw-mn4nuur121.6nwy0xsnl2.x0p@flex--seanjc.bounces.google.com>) id 6a751aa4-5cb7-0a2a0a5109dd-0a2a450adfc0-34 for ; Fri, 07 Aug 2026 01:38:10 +0200 Received: from [209.85.216.70] (helo=mail-pj1-f70.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3pBp1agYKCQk1njwslpxxpun.lxv6nw-mn4nuur121.6nwy0xsnl2.x0p@flex--seanjc.bounces.google.com>) id 6a751aa4-f2d2-0a2a450a0019-d155d846e865-3 for ; Fri, 07 Aug 2026 01:37:10 +0200 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38ec0f510a9so5941233a91.2 for ; Thu, 06 Aug 2026 16:37:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059428; x=1786664228; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=aQ8musMrPFB3W7GZXrEzufcFO/9G0XUPjz13+bRyF/M=; b=UayW8GJqxBg5VG1/3FkRkdLbU/2Q1/1qHyI5vIVC/GbO5PPRtRDKjWLyMghueaSpKl tIBca+4/VLzOePgFa64RrbfAk8Wx28TjH5GgQ0MCkPzLJKsq2ZW9sDgQ6yVdJk935OZm 9CKbJXpIXGhyUr6oHG7BeOhdCeCjCCjyjVdB7SmtLJI2h2Ly0AKm7Y2c5rCTRH/6ANaN v72Brr4zf60WJ3d6yArfwjZQwVPeA+15qxyWwHi9IuS/HJBs61JVPVHqM32t2X2L7V6Q /qE4eW3xZ5h9GSbln+eHUpOTLi8hmy68ww2bxVFWAKaJGOFARCo0sxigvGjRjkVd58qR 9weQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059428; x=1786664228; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aQ8musMrPFB3W7GZXrEzufcFO/9G0XUPjz13+bRyF/M=; b=qPRsFaIMFfzAsy/lpq4ksJWyzM3RpNEs47upMXraBuV0xPuDNv3gzp7LFowgBco6RS D03CZoLNlDd6kDvZ08Rno5Zj9HgfAS/VAntTqfuvX+Eiub8wWHMuuHfnu41b8pQnj1g9 6M4xcs3m7xJ0wC1tmno0lPSTVPWc/4JgdFnuKl5u4HFPeaDUJtEw3XZ6vibYR83epYsH +eQuWDT7X0DbHeryWBmT2TmFFIKKTGT6OLMjZth9gwi2VLzFhPIpc6FcYeO4qNUnuGp7 IJ6xI8lpnsbPX+VN0q0XRdAJHI3E4UqUQf2penOKegUzZPSPQC1keelNKBLnM4oHVXtm FE1g== X-Forwarded-Encrypted: i=1; AHgh+RqV3WM3YMlzA9Fs/fTJ8sT5+Ry653AxlUMsqk5FwRN5s8LFJ3jF1XQFTavtzuiKUAxDZrTXDT5OLkU=@lists.xenproject.org X-Gm-Message-State: AOJu0YwQPgCrl6wuG+TG4Pn3MHIqVkcGazOQbpO5t3z7EDOFSIXlvJ/U eSDb7klEwevVQdRCblOeWY0WNhITYeKs3knZE+XTdE61IygtHcJwgkhp4ktFdhX479oTMj8XnLO mTliHhw== X-Received: from pjpq20.prod.google.com ([2002:a17:90a:a014:b0:38e:befb:90c6]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:264b:b0:38a:c3f:3b87 with SMTP id 98e67ed59e1d1-3903c58a6femr19988163a91.12.1786059428057; Thu, 06 Aug 2026 16:37:08 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:52 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-36-seanjc@google.com> Subject: [PATCH v6 35/51] x86/tsc: WARN if TSC sched_clock save/restore used with PV sched_clock From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059430-514C7CFC-831FA0FF/13/0 X-purgate-type: clean X-purgate-size: 1422 Now that all PV clocksources override the sched_clock save/restore hooks when overriding sched_clock, WARN if the "default" TSC hooks are invoked when using a PV sched_clock, e.g. to guard against regressions. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 964f3d6c2c71..60fcc3020792 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -947,9 +947,17 @@ EXPORT_SYMBOL_FOR_MODULES(recalibrate_cpu_khz, "p4-clockmod,powernow-k7"); static unsigned long long cyc2ns_suspend; +static __always_inline bool tsc_is_save_restore_needed(void) +{ + if (WARN_ON_ONCE(!using_native_sched_clock())) + return false; + + return static_branch_likely(&__use_tsc) || sched_clock_stable(); +} + void tsc_save_sched_clock_state(void) { - if (!static_branch_likely(&__use_tsc) && !sched_clock_stable()) + if (!tsc_is_save_restore_needed()) return; cyc2ns_suspend = sched_clock(); @@ -969,7 +977,7 @@ void tsc_restore_sched_clock_state(void) unsigned long flags; int cpu; - if (!static_branch_likely(&__use_tsc) && !sched_clock_stable()) + if (!tsc_is_save_restore_needed()) return; local_irq_save(flags); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:38:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:38:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385424.1627880 (Exim 4.92) (envelope-from ) id 1ws7fD-0001wt-UF; Thu, 06 Aug 2026 23:38:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385424.1627880; Thu, 06 Aug 2026 23:38:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7fD-0001wm-RV; Thu, 06 Aug 2026 23:38:15 +0000 Received: by outflank-mailman (input) for mailman id 1385424; Thu, 06 Aug 2026 23:38:14 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3pxp1agYKCQw4qmzvos00sxq.o0y9qz-pq7qxxu454.9qz130vqo5.03s@flex--seanjc.bounces.google.com>) id 1ws7fC-0001vM-Ib for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:38:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7fB-009HY2-W0 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:38:13 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3pxp1agYKCQw4qmzvos00sxq.o0y9qz-pq7qxxu454.9qz130vqo5.03s@flex--seanjc.bounces.google.com>) id 6a751a81-e002-0a2a0a5209dd-0a2a450c8794-30 for ; Fri, 07 Aug 2026 01:38:13 +0200 Received: from [209.85.216.71] (helo=mail-pj1-f71.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3pxp1agYKCQw4qmzvos00sxq.o0y9qz-pq7qxxu454.9qz130vqo5.03s@flex--seanjc.bounces.google.com>) id 6a751aa8-f479-0a2a450c0019-d155d847e594-3 for ; Fri, 07 Aug 2026 01:37:13 +0200 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3811279d51aso4527477a91.1 for ; Thu, 06 Aug 2026 16:37:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059432; x=1786664232; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=4ag8yTwNbmjHFkBZxZL+JA4uvidx3vZA6IwgDKjMnAQ=; b=Piom0kQr4Kh+m63x/ZDynnRPc3ANRDeOmA8b5i3ynVjtawdp6zNesqbmKdBBckGXlE FEBmzy5g6Q9GgCIvoWgxzw/KDt3aztVW0MuXULpub0v2dlnqzxo+w2pIRdAggZRyY32y uccTRGfIgs7SQNRJ/xiPNwwkd+eG9LILp062arAvUkYQxayO+wi+GeeBFG34XNt1miHm 5N72PBq9xhkMWuqkR7YBSEWUoZiXqPymjlSxkbeuWhSQO8niEzjaQq2pb9ApPCjRXO/w +nobWh0e5euzsYaxfPqvY4vMEQOOSKWdQBHEYFIzFFjGsYtOJA8hM8O07wYz6uIWLpsP XVng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059432; x=1786664232; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=4ag8yTwNbmjHFkBZxZL+JA4uvidx3vZA6IwgDKjMnAQ=; b=kFcGcf7mDmof3Szcu0toB/lJ4Sy6cCmNEFDrSWOixmOD1FoCozLawuSmk6KzanJo22 NfDeLHx+XuSSVXcGRQHYF6PwKB2B95zafUAqrOGBiGc8zA9t70L79agCba5EDLQf0ZjE fcrMkEpR+W7AXOpsTXvEgKi14oMuBnIebv0Q5Fi8pRRGd4Zuo0tHjazaZJtjQL7BvEZG OVmhHLDsQmBtcJpEjmX5XRAYldwutuM1dV27W3qSm1jj71jJbLSf8ArPjLJJ9IuPO1sG d1BuGxqiHPlXWn9dW+mtHkkmL8PsuuovH0cAIKMqWvnwvX+QXDKIk0VuSvVq79h0uNGJ Oe+Q== X-Forwarded-Encrypted: i=1; AHgh+RqIGLQCqMDY9UKRuXHfGptwxBZdDZqtogpM5OnRr8ZsBqEnlpiZ9YcGM4Bq/ZanHHKi8rdrsoDsQJQ=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxvf1tkChgyLxhk9HKxFyfyTa+bVreFjKa6tPX3iR8fID38O3Cx KKSoA3OJFK/VAh1zm6FrzLuOOZ0Mi02psffd+umP4bjYRCdDnsxCbGQEknsZF904xTe2qHjXSst R98eRXw== X-Received: from pjbqb12.prod.google.com ([2002:a17:90b:280c:b0:38f:2874:84ed]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:c88e:b0:38e:488f:7068 with SMTP id 98e67ed59e1d1-3903c5373b4mr20565740a91.2.1786059431685; Thu, 06 Aug 2026 16:37:11 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:55 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-39-seanjc@google.com> Subject: [PATCH v6 38/51] x86/xen/time: Mark xen_setup_vsyscall_time_info() as __init From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d25034/1786059433-51D34A5B-46BCA67A/13/0 X-purgate-type: clean X-purgate-size: 879 Annotate xen_setup_vsyscall_time_info() as being used only during kernel initialization; it's called only by xen_time_init(), which is already tagged __init. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/xen/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 8cd8bfaf1320..bc26f00fc53e 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -443,7 +443,7 @@ void xen_restore_time_memory_area(void) xen_sched_clock_offset = xen_clocksource_read() - xen_clock_value_saved; } -static void xen_setup_vsyscall_time_info(void) +static void __init xen_setup_vsyscall_time_info(void) { struct vcpu_register_time_memory_area t; struct pvclock_vsyscall_time_info *ti; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:39:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:39:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385440.1627890 (Exim 4.92) (envelope-from ) id 1ws7gM-00034P-8s; Thu, 06 Aug 2026 23:39:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385440.1627890; Thu, 06 Aug 2026 23:39:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7gM-00034I-5f; Thu, 06 Aug 2026 23:39:26 +0000 Received: by outflank-mailman (input) for mailman id 1385440; Thu, 06 Aug 2026 23:39:24 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3sRp1agYKCRYE0w95y2AA270.yA8J09-z0H0774EFE.J09BDA50yF.AD2@flex--seanjc.bounces.google.com>) id 1ws7gK-00033h-ED for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:39:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7gJ-009Hfj-RS for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:39:23 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3sRp1agYKCRYE0w95y2AA270.yA8J09-z0H0774EFE.J09BDA50yF.AD2@flex--seanjc.bounces.google.com>) id 6a751afa-e002-0a2a0a5209dd-0a2a4505b878-20 for ; Fri, 07 Aug 2026 01:39:23 +0200 Received: from [209.85.216.72] (helo=mail-pj1-f72.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3sRp1agYKCRYE0w95y2AA270.yA8J09-z0H0774EFE.J09BDA50yF.AD2@flex--seanjc.bounces.google.com>) id 6a751ab2-4cb1-0a2a45050019-d155d848cc55-3 for ; Fri, 07 Aug 2026 01:37:23 +0200 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-388b404eaa4so3501845a91.0 for ; Thu, 06 Aug 2026 16:37:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059442; x=1786664242; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=+in/CASVMXdQrSwySi/14FWqsmLN6M2d30MjdmJLYfo=; b=OtHCkTjQxkkxyfCvqdDCUZdlyaK+F0dFQbQ1rOYrnoNGnxNn5379nb/BfO9c20Rfz5 4d6Qd47Ldu9xpsSFUAb6N+jE1UqU6r8WlI6tIYsqy6hiaC5KWKiRwRgcID6yBZaMxPxU PyeazyC4cvo4FMvnLTJCDGHieClID73xCQHFC1zQd/+Xk8tfRAzA43Fp+r51bycPwDmb pJ/gsNklohVYnpBmOr3x0JrNnZGONH/y5fGR73pizyP7WKyFW+uOOVgVXdwqzDiU6XF3 6XjA3LiKI0pCvFUMqfMzUw/ZBSYiv02MGFwZRJopu+gxa+Ijdy4Mfi+m7dBmqAYkdcdH pYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059442; x=1786664242; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+in/CASVMXdQrSwySi/14FWqsmLN6M2d30MjdmJLYfo=; b=FCJVi7HTZcGj8sfFd9rynZy4XzqNH9RjOqCU6h0UjW5y25TmrIhPZH4jGSuxW4iJsl Wsw/ve0HQr8jipWAVzHSCSekXRd/ZFxmFX7Tz3zmsjwSxv01+DPz7j9fANXR2t5tWbyp Ntw3X+WCH50jExI8tODW1twA2HnWr7wvZgLQTiqo8Dr6+xqnj5W6T4wqRMRsKQaxliZ6 l+KO5+QhnKciBxgBMx0mRm6FlzYOkA+WbodruRc8chRGaDVRY2rlYSDwXE7feJ41UjTx BmZ5laBZqMAzlzox0HI5TMGRjzqDhGbAXngHpsn+7EmPU4Pl2h0UUYeuFuAcNwEiITYQ tyWg== X-Forwarded-Encrypted: i=1; AHgh+RpDGKKi6BYMkKksgsogcYhMVpvkHrF3dY9uEoJOzsxvqBl8mlvIN7GNla2svSZviN8UGFr9BrXNn/s=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy6trUhJps5x5wWXmQzQK3DcaNbleTjWVb+khprWAvrvRSPF5Es zYButhdL3TS8ZTKt+v8LxslhcIyyQXk2xE9waxitXYLW0fGyq3FAO32UksCuZl6f+0yQsYr7LSJ gdbfJjw== X-Received: from pgii4.prod.google.com ([2002:a63:2204:0:b0:c8d:62a8:ee35]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:7a9c:b0:3bf:983d:e9b4 with SMTP id adf61e73a8af0-3cb8603af0dmr21846910637.33.1786059441366; Thu, 06 Aug 2026 16:37:21 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:03 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-47-seanjc@google.com> Subject: [PATCH v6 46/51] x86/paravirt: Plumb a return code into __paravirt_set_sched_clock() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c201ff/1786059443-732B32A1-47A3F831/13/0 X-purgate-type: clean X-purgate-size: 3365 Add a return code to __paravirt_set_sched_clock() so that the kernel can reject attempts to use a PV sched_clock without breaking the caller. E.g. when running as a CoCo VM with a secure TSC, using a PV clock is generally undesirable. Note, kvmclock is the only PV clock that does anything "extra" beyond simply registering itself as sched_clock, i.e. is the only caller that needs to check the new return value. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 6 +++--- arch/x86/kernel/kvmclock.c | 9 ++++++--- arch/x86/kernel/tsc.c | 5 +++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index 96ae7feac47c..ca5c95d48c03 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,14 +14,14 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)); +int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)); static __always_inline void paravirt_set_sched_clock(u64 (*func)(void), void (*save)(void), void (*restore)(void)) { - __paravirt_set_sched_clock(func, true, save, restore); + (void)__paravirt_set_sched_clock(func, true, save, restore); } #endif diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 2cc3dd2ba355..22e8855fcd4d 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -332,10 +332,13 @@ static int kvmclock_setup_percpu(unsigned int cpu) static __init void kvm_sched_clock_init(bool stable) { + /* Ensure the offset is configured before making kvmclock visible! */ kvm_sched_clock_offset = kvm_clock_read(); - __paravirt_set_sched_clock(kvm_sched_clock_read, stable, - kvm_save_sched_clock_state, - kvm_restore_sched_clock_state); + + if (__paravirt_set_sched_clock(kvm_sched_clock_read, stable, + kvm_save_sched_clock_state, + kvm_restore_sched_clock_state)) + return; /* * The BSP's clock is managed via dedicated sched_clock save/restore diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 363145c83919..fcf331ffd874 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,8 +280,8 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)) +int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)) { if (!stable) clear_sched_clock_stable(); @@ -289,6 +289,7 @@ void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, static_call_update(pv_sched_clock, func); x86_platform.save_sched_clock_state = save; x86_platform.restore_sched_clock_state = restore; + return 0; } #else u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:39:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:39:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385441.1627900 (Exim 4.92) (envelope-from ) id 1ws7gQ-0003KW-GI; Thu, 06 Aug 2026 23:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385441.1627900; Thu, 06 Aug 2026 23:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7gQ-0003KP-CC; Thu, 06 Aug 2026 23:39:30 +0000 Received: by outflank-mailman (input) for mailman id 1385441; Thu, 06 Aug 2026 23:39:29 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3thp1agYKCRsJ51EA37FF7C5.3FDO5E-45M5CC9JKJ.O5EGIFA53K.FI7@flex--seanjc.bounces.google.com>) id 1ws7gP-0003JY-0u for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:39:29 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7gO-008NwO-E3 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:39:28 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3thp1agYKCRsJ51EA37FF7C5.3FDO5E-45M5CC9JKJ.O5EGIFA53K.FI7@flex--seanjc.bounces.google.com>) id 6a751ae6-5cb7-0a2a0a5109dd-0a2a4501dcf8-16 for ; Fri, 07 Aug 2026 01:39:28 +0200 Received: from [209.85.216.72] (helo=mail-pj1-f72.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3thp1agYKCRsJ51EA37FF7C5.3FDO5E-45M5CC9JKJ.O5EGIFA53K.FI7@flex--seanjc.bounces.google.com>) id 6a751ab6-5984-0a2a45010019-d155d848bc7f-3 for ; Fri, 07 Aug 2026 01:37:28 +0200 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38e22137fb3so3727924a91.0 for ; Thu, 06 Aug 2026 16:37:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059446; x=1786664246; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=yUUzKej44hzjMWM7byUMUm3T8+/2OB7FMHfj7k4gSDk=; b=QZI/nV7PAFv/pPThl5nZ4RPWlJsnkOb7y6J7quwQbDi7/wn5/47jyI+C89Lk123cLW gd8Q6y8cRwJajOs0bwx3ZanhJ4g0FCFi9tS3/DvgANYrqEO7Th2J+rOenzzYmB1Ptxeo JrA+TQJ7wkbOzGv36YqZKfOmaxjB2Lvu75ud32X8UYJMTv2cZWvTOVuy+0GXSjsR/uiU tWBVR+vdJSAC7bh6Qv+mh3rY0FCkrVcnvUpPc+/ElPgQYVpvT0kNONS5Ui4PApqS8HYy Wh8o/00pcrhYddpAbkOX9tiyC6nw0O6GerycAR2PHT0d8j54zyVSbI+ltkZsRHdUrd0X eeYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059446; x=1786664246; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=yUUzKej44hzjMWM7byUMUm3T8+/2OB7FMHfj7k4gSDk=; b=B4W/3kg5C3w86yDh48zk/PPI+9pDp8xMXRBV2gOQDbCSWKIMf3zSD4clDGS+StuXFS CsJZF4+AvfW731soMeJmD5fQsZrX/FR9Whg99TuoFLUlHfuNU4xkHLGqDEz5EuaGD1IF rWFAuQ9ci+ufx15u01E0YWAeUpCCFU2zyY0xugmNbuiNavcdV66pM/K/6C7N7A9R+Rhr k+lsYOEyXMBO2zqsXqb2c1eiwlQTETtXr1YtvdOEYNcwqq3KQNeEPIY6bke8nLScR0/k nU53twn+h56mSacWhNYzJmbqzKno+rMTpV3USDaEoPghfqbZL59Kf2n89KQ1hi6LYPNK Ek5Q== X-Forwarded-Encrypted: i=1; AHgh+RoygyQERN3NgLw7YsnBAGpNR+tTy6zTd+v6kUdzvNFGRH1P3R4hyrLTb14xN5QUGV8I//hr2nZY0Hg=@lists.xenproject.org X-Gm-Message-State: AOJu0YwGhKK97N07ygs7xiHIRPP4/NA8+NmX5g1LHhHpXrNbcosDpsx/ TGQmHzv2Q2UwkEQUq1X5f9bwUb/wZPWb1ctwRznPRImptjP/5Gy+YDPfp7X2D/vo6WChJjmI4Ap LJXZYfg== X-Received: from pjzp16.prod.google.com ([2002:a17:90b:110:b0:382:7fcd:a18a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:520a:b0:38f:5828:a40c with SMTP id 98e67ed59e1d1-3903c59a6eemr19079453a91.10.1786059446038; Thu, 06 Aug 2026 16:37:26 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:07 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-51-seanjc@google.com> Subject: [PATCH v6 50/51] x86/paravirt: Move using_native_sched_clock() stub into timer.h From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1786059448-1E867757-C00BCBAE/13/0 X-purgate-type: clean X-purgate-size: 1710 Now that timer.h ended up with CONFIG_PARAVIRT #ifdeffery anyways, move the PARAVIRT=n using_native_sched_clock() stub into timer.h as a "free" optimization. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 6 ++++-- arch/x86/kernel/tsc.c | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index ca5c95d48c03..a52388af6055 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -11,9 +11,9 @@ extern void recalibrate_cpu_khz(void); extern int no_timer_check; -extern bool using_native_sched_clock(void); - #ifdef CONFIG_PARAVIRT +extern bool using_native_sched_clock(void); + int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, void (*save)(void), void (*restore)(void)); @@ -23,6 +23,8 @@ static __always_inline void paravirt_set_sched_clock(u64 (*func)(void), { (void)__paravirt_set_sched_clock(func, true, save, restore); } +#else +static inline bool using_native_sched_clock(void) { return true; } #endif /* diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index c0e4485484f2..74298e8ffa1f 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -302,8 +302,6 @@ int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, } #else u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); - -bool using_native_sched_clock(void) { return true; } #endif notrace u64 sched_clock(void) -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:39:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:39:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385450.1627907 (Exim 4.92) (envelope-from ) id 1ws7gi-0003vs-Rp; Thu, 06 Aug 2026 23:39:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385450.1627907; Thu, 06 Aug 2026 23:39:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7gi-0003vl-Ot; Thu, 06 Aug 2026 23:39:48 +0000 Received: by outflank-mailman (input) for mailman id 1385450; Thu, 06 Aug 2026 23:39:48 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3jRp1agYKCfAkWSfbUYggYdW.UgepWf-VWnWddaklk.pWfhjgbWUl.gjY@flex--seanjc.bounces.google.com>) id 1ws7gi-0003u5-6G for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:39:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7gh-008O38-Jc for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:39:47 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3jRp1agYKCfAkWSfbUYggYdW.UgepWf-VWnWddaklk.pWfhjgbWUl.gjY@flex--seanjc.bounces.google.com>) id 6a751b32-2eae-0a2a0a5409dd-0a2a4506abfa-14 for ; Fri, 07 Aug 2026 01:39:47 +0200 Received: from [209.85.214.197] (helo=mail-pl1-f197.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3jRp1agYKCfAkWSfbUYggYdW.UgepWf-VWnWddaklk.pWfhjgbWUl.gjY@flex--seanjc.bounces.google.com>) id 6a751a8d-195a-0a2a45060019-d155d6c5bdc7-3 for ; Fri, 07 Aug 2026 01:36:47 +0200 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cca3673560so40738305ad.1 for ; Thu, 06 Aug 2026 16:36:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059405; x=1786664205; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=as+YzjPRM0DAZztxhbx3Raa/ax9+dW0ZzZ4Dw8q0B68=; b=kWfa/AsaHAaOPijm2y8OJA5bnjUNwAVvFc2FCCHiOfYHYxYau4I6t8DRERbCxhIL4C KovV1Z8rv7f09cwCN1BvnhH4b3oWB7BoQh55xgPJeL2h+QLJ2l3zdMfnFcalfOCo0anO qkqCbCpddeWtMMBR+h1FXUrf9rlvHIgy0rmidcqkQ6k+zJ6krhnmQB965ZaXrgSGb6sr /GOkVO5X79wL4eOWSgYalsbg6nDCq11U5wvKuaPoq1sbInlElaBOiQCgwwBWHfBFMS4/ P9plgmNFfGKUJ5ZI5E7j/n2+wNAm82UHzxOCSTV9N02X+RN/YLFbufdo4SiWuou174QN HSbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059405; x=1786664205; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=as+YzjPRM0DAZztxhbx3Raa/ax9+dW0ZzZ4Dw8q0B68=; b=YsjkKpmc+hwYoRm2sRI8yyrzGzIi6OFaYv9Uz5tzQmyqzVZrs+kKDCGdVqn2MOrQSd I7vvkAnTE/LbanNsKkeZVzSexKQd3GnbIGCLudEXHydapG7dghd6WzrHBsvg1OUV9dy7 5DBKPyOg30m9xmyT8YPnYKyEORw38Gn3Plx9XT88iwhaOdTdxCjd8r/bF4n49yXizc/p cwjxiAL9CHDQX9Y1V7WAsN1PTGY+4TmsvGjnM58b+7RhGeGkKl5lwopNwzICKDvDLSDS SM5d0MPGX8HyxtpmcraqdmnJGg+XJOSGJ3dtY1zaWJz2qqLHdB7RHtNvrZEXJcz4K8qx LCzQ== X-Forwarded-Encrypted: i=1; AHgh+Rr23BhP8yqt3AE8tmwpbtvsCxCIS5h2cCbWiDFz+BNtwF467ylp3uWFWdfXrsEPBitN+P84Jnb2ey0=@lists.xenproject.org X-Gm-Message-State: AOJu0YyoPnfZX8rSbjTwnrsPo/Q7m4CxCOWswD/LEEf9HHUj/GzEqpsg LKzo2X06eTIIfiyWR68N0aqm0/CqjpPzJNzCXJRvYjrta3EBOiWZ/Op/ZxhTARK+EBlye9Cfs4c RrXEbHA== X-Received: from plblh12.prod.google.com ([2002:a17:903:290c:b0:2cf:277e:c60c]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f708:b0:2ba:6518:a6d4 with SMTP id d9443c01a7336-2d0ca9624bdmr224800085ad.20.1786059405010; Thu, 06 Aug 2026 16:36:45 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:34 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-18-seanjc@google.com> Subject: [PATCH v6 17/51] x86/tsc: Fold native_calibrate_cpu() into recalibrate_cpu_khz() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1786059407-1ECC577B-EE81E4AE/0/0 X-purgate-type: clean X-purgate-size: 1493 Fold the guts of native_calibrate_cpu() into its sole remaining caller, recalibrate_cpu_khz() to eliminate the extra SMP=n #ifdef, and so that it's more obvious that directly invoking the early vs. late calibration routines in determine_cpu_tsc_frequencies() is intentional. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index dd9e04e325d6..d95e4f059f17 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -918,21 +918,6 @@ static unsigned long native_calibrate_cpu_early(void) return fast_calibrate; } -#ifndef CONFIG_SMP -/** - * native_calibrate_cpu - calibrate the cpu - */ -static unsigned long native_calibrate_cpu(void) -{ - unsigned long tsc_freq = native_calibrate_cpu_early(); - - if (!tsc_freq) - tsc_freq = native_calibrate_cpu_late(); - - return tsc_freq; -} -#endif - void recalibrate_cpu_khz(void) { #ifndef CONFIG_SMP @@ -944,7 +929,9 @@ void recalibrate_cpu_khz(void) if (WARN_ON_ONCE(cpu_feature_enabled(X86_FEATURE_TSC_KNOWN_FREQ))) return; - cpu_khz = native_calibrate_cpu(); + cpu_khz = native_calibrate_cpu_early(); + if (!cpu_khz) + cpu_khz = native_calibrate_cpu_late(); tsc_khz = native_calibrate_tsc(); if (tsc_khz == 0) tsc_khz = cpu_khz; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:40:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:40:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385459.1627917 (Exim 4.92) (envelope-from ) id 1ws7h1-0005MG-4o; Thu, 06 Aug 2026 23:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385459.1627917; Thu, 06 Aug 2026 23:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7h1-0005Lb-0F; Thu, 06 Aug 2026 23:40:07 +0000 Received: by outflank-mailman (input) for mailman id 1385459; Thu, 06 Aug 2026 23:40:06 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3nxp1agYKCQQwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 1ws7h0-0005Ip-4K for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:40:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7gz-008O38-HU for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:40:05 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3nxp1agYKCQQwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a751b32-2eae-0a2a0a5409dd-0a2a4506abfa-32 for ; Fri, 07 Aug 2026 01:40:05 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3nxp1agYKCQQwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a751a9f-195a-0a2a45060019-d155d2c6d4bf-3 for ; Fri, 07 Aug 2026 01:37:05 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84eee2147ffso3479047b3a.0 for ; Thu, 06 Aug 2026 16:37:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059423; x=1786664223; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=vn6W6kHEL1s4RiTIjTKhQPQXVLtQ6/4gpgI7E1htjZ4=; b=L+lNhrIiLPPkrx9RhTXHgKpvAT8p1sItqamBUWfrX2xvWk3lLOs7XTlq+piC9SQNz3 nnkdSsknXF2qnBCK6kp4Ejrj9wlD15lMSHPUxFvLduy4auSofNxJRCeeQcS8g3wvRF6N OTwYl37lmpHoGboe+cRTrYnpMrym4+lPiI+K9YRMHAPHlYNMbxntdRuju/NcFBj+J/c/ LQkVftSXJ+7/8Jhg7vCCgostOmAzjZMyQiiyViOjm3C4USbhlEobSeztEu24X26OzKe1 ZLEXp0sqmS69ms5DUGtuatdsmLuOedEkOkh2DsxXuJ/F8RsVjwM8VBPqcIHRoS1rRfXe eVog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059423; x=1786664223; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vn6W6kHEL1s4RiTIjTKhQPQXVLtQ6/4gpgI7E1htjZ4=; b=sUB/3jO4ke7db79uU3aHqqZg00ow/al4n0c9Bww7ECkAy1dPcg6x8fOuFB/wq8gjaV sZTtbTWMhtvr1ypWSepS32n8Lhu/2mEXUMrk6mzeyiR3/R3xejEyT/jVy4HV6lv8FWvC kTxcGgQlOH3pmSb7zgECE43A3+8m9onyDASdv9NrxemlHXtCZPrdHndtSUMKaEi5y/LN tF/WNkOPPiHrHOxozADBKM4NE7tEKsnSB3BOWO9j7/n+1WdUF9kbI0h3Wdc1dsIjq8OC Yo9yaroM/4d37V+fueL6cqWGM8W4SuP0U5zc/GHxuJ/A8k2hlmP1uhsK2dPom8sTpLjd dCGg== X-Forwarded-Encrypted: i=1; AHgh+Rrm/b1JUdNzrGZKXysurfUr9FnuzKCxIk3dWlBnQmdPsj9TMMhS9Ky3/sOEeSpXE73HFhGCOaR3QsQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YxQp18155z5eXyWRUwrPsQy9pWyWJJErVE15X6u6YOuSbVUZ5tt STdxygpzb+CGK+oZR9gVcIoblc5Vz5BkdbtV2bUwahwLItViBT1L9YDDvKOkzFinowbh6Ermj4c qpYsBew== X-Received: from pfbbx10.prod.google.com ([2002:a05:6a00:428a:b0:848:2e0e:62e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1daa:b0:848:401c:98e with SMTP id d2e1a72fcca58-84f2e0432a7mr20883954b3a.15.1786059423013; Thu, 06 Aug 2026 16:37:03 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:48 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-32-seanjc@google.com> Subject: [PATCH v6 31/51] x86/paravirt: Move handling of unstable PV clocks into paravirt_set_sched_clock() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1786059425-F4A0477B-06BBC8DE/0/0 X-purgate-type: clean X-purgate-size: 2569 Move the handling of unstable PV clocks, of which kvmclock is the only example, into paravirt_set_sched_clock(). This will allow modifying paravirt_set_sched_clock() to keep using the TSC for sched_clock in certain scenarios without unintentionally marking the TSC-based clock as unstable. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 7 ++++++- arch/x86/kernel/kvmclock.c | 5 +---- arch/x86/kernel/tsc.c | 5 ++++- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index c71b466d6ace..fe41d40a9ae6 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,7 +14,12 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void paravirt_set_sched_clock(u64 (*func)(void)); +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable); + +static inline void paravirt_set_sched_clock(u64 (*func)(void)) +{ + __paravirt_set_sched_clock(func, true); +} #endif /* diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index a3ec298d56d7..4bc0495f1f9e 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -115,10 +114,8 @@ static noinstr u64 kvm_sched_clock_read(void) static inline void kvm_sched_clock_init(bool stable) { - if (!stable) - clear_sched_clock_stable(); kvm_sched_clock_offset = kvm_clock_read(); - paravirt_set_sched_clock(kvm_sched_clock_read); + __paravirt_set_sched_clock(kvm_sched_clock_read, stable); pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index e0bea58b6658..964f3d6c2c71 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,8 +280,11 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void paravirt_set_sched_clock(u64 (*func)(void)) +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable) { + if (!stable) + clear_sched_clock_stable(); + static_call_update(pv_sched_clock, func); } #else -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:40:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:40:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385463.1627926 (Exim 4.92) (envelope-from ) id 1ws7h5-0005jq-B3; Thu, 06 Aug 2026 23:40:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385463.1627926; Thu, 06 Aug 2026 23:40:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7h5-0005jh-8F; Thu, 06 Aug 2026 23:40:11 +0000 Received: by outflank-mailman (input) for mailman id 1385463; Thu, 06 Aug 2026 23:40:10 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3ohp1agYKCQczlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 1ws7h3-0005ir-Vh for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:40:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7h3-008O38-Cc for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:40:09 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3ohp1agYKCQczlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 6a751b32-2eae-0a2a0a5409dd-0a2a4506abfa-34 for ; Fri, 07 Aug 2026 01:40:09 +0200 Received: from [209.85.214.197] (helo=mail-pl1-f197.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3ohp1agYKCQczlhuqjnvvnsl.jvt4lu-kl2lsspz0z.4luwyvqlj0.vyn@flex--seanjc.bounces.google.com>) id 6a751aa3-195a-0a2a45060019-d155d6c5e826-3 for ; Fri, 07 Aug 2026 01:37:08 +0200 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cfa4e4684bso67531345ad.2 for ; Thu, 06 Aug 2026 16:37:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059427; x=1786664227; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=f+UXuTD6z7zajVoSPLixW+N3kzbQtDvz4+hCO4pCJ+c=; b=pT6jUOebSWW9nxnOIAVPDQrEqpOFzWNjRwR1nXVUasyB6WDZ7hb7tKIY5doc33hl8u AuhAb3Zk0o1DYfPs3/n3pvBAO/WM/LXyHwST9k9r+2XM/KyetHSmftWIONPH+CNV/lZX YMaF23Bh42ShopbgkEZdFs24i+XNqoSagY2H5ch0bUMxI6XlBO5HVGPR+TtgUfvx/s3h l5kZklvVZMhLKDeAspINDjDpYeQM67VmElHfVFO7GPTbJx3bXHyJfs3WOKXtjj6ghpYz DMX5QxLApLCbWBt1/Emx8AkWRHDw0U+H/6dWjgorT6iRPq6NHubWHF3od5IHpDnhKvRi IMfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059427; x=1786664227; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=f+UXuTD6z7zajVoSPLixW+N3kzbQtDvz4+hCO4pCJ+c=; b=V910eu6cD3/8AHTLn44d3bPSB05HBuCjOuADf+hzm2xc8IpnYNKoqlj3x0vGVbOBcU 3ujPOsrD+/ikRKhc2lBUvSVOVTPAYjkOO1FbAq16NWITIa7B8oTKpaWVj4HzqjxRn3IQ tE1r04wG5bBZ5ewxW4x3ZbaR6Tf+GpLjRvFUQ6mIA0qXMNf2UxUU8QMnc0Bx2re0Wots DxfjHzEjlPLe2yy/4/Z7SekiZihIELeenjckGNzieEghenCSgNvjdd1xogmp57TdGbI5 BuIagvp/QQGoQPFa8uQCgz9g2Ib54x/wUq+USOotkxcv6qXtPa/V2wXx0D0nmFJmVIeJ 73JQ== X-Forwarded-Encrypted: i=1; AHgh+Rrqah0YF/OR58460WB0WpZ7xkMelmPOunoNRIt9INoy5t4GTxgNHOB04biEYsQWmUzxb9FZ647Oksw=@lists.xenproject.org X-Gm-Message-State: AOJu0YxyOz6XD2cWNp/AIGE0d4JYvTU9/fHEx/Kabhadbyqv+KW1uXxd DwbcCpdqWUgjXQl/TJ/bIYTf0iZOqQ9YuhimSeDVbu4cd7mlC5fL9VDpagh28H0848NRJG5ubDE DLWEcBQ== X-Received: from plbi11.prod.google.com ([2002:a17:903:20cb:b0:2cc:6da3:442d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f546:b0:2cc:aa36:c046 with SMTP id d9443c01a7336-2d0ca77ece3mr197228075ad.14.1786059426608; Thu, 06 Aug 2026 16:37:06 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:51 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-35-seanjc@google.com> Subject: [PATCH v6 34/51] x86/vmware: NOP-ify save/restore hooks when using VMware's sched_clock From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1786059429-F687577B-A5130C9C/0/0 X-purgate-type: clean X-purgate-size: 1263 NOP-ify the sched_clock save/restore hooks when using VMware's version of sched_clock. This will allow extending paravirt_set_sched_clock() to set the save/restore hooks, without having to simultaneously change the behavior of VMware guests. Note, it's not at all obvious that it's safe/correct for VMware guests to do nothing on suspend/resume, but that's a pre-existing problem. Leave it for a VMware expert to sort out. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/vmware.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index cbe8b59ab79f..94fec990a02c 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -347,8 +347,11 @@ static void __init vmware_paravirt_ops_setup(void) vmware_cyc2ns_setup(); - if (vmw_sched_clock) + if (vmw_sched_clock) { paravirt_set_sched_clock(vmware_sched_clock); + x86_platform.save_sched_clock_state = x86_init_noop; + x86_platform.restore_sched_clock_state = x86_init_noop; + } if (vmware_is_stealclock_available()) { has_steal_clock = true; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:40:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:40:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385467.1627934 (Exim 4.92) (envelope-from ) id 1ws7hH-00068X-Ha; Thu, 06 Aug 2026 23:40:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385467.1627934; Thu, 06 Aug 2026 23:40:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7hH-00068O-Eu; Thu, 06 Aug 2026 23:40:23 +0000 Received: by outflank-mailman (input) for mailman id 1385467; Thu, 06 Aug 2026 23:40:22 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3rhp1agYKCRMBxt62vz77z4x.v75Gx6-wxEx441BCB.Gx68A72xvC.7Az@flex--seanjc.bounces.google.com>) id 1ws7hG-00066O-6k for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:40:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7hF-009HnE-Jv for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:40:21 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3rhp1agYKCRMBxt62vz77z4x.v75Gx6-wxEx441BCB.Gx68A72xvC.7Az@flex--seanjc.bounces.google.com>) id 6a751b63-e002-0a2a0a5209dd-0a2a4506acd4-2 for ; Fri, 07 Aug 2026 01:40:21 +0200 Received: from [209.85.210.200] (helo=mail-pf1-f200.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3rhp1agYKCRMBxt62vz77z4x.v75Gx6-wxEx441BCB.Gx68A72xvC.7Az@flex--seanjc.bounces.google.com>) id 6a751aaf-195a-0a2a45060019-d155d2c8b1ac-3 for ; Fri, 07 Aug 2026 01:37:21 +0200 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84a3514f912so4400199b3a.3 for ; Thu, 06 Aug 2026 16:37:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059439; x=1786664239; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=+wCYK2twR3W1N/eNELl9D0JNBeD1Zbsv+o0OdDwvKek=; b=bXA5lh07ACzBAI6MdJBK8aiPQlJNNE8vJ90Lvl2817WkJcLPJaC/aihGFacbAy9/zh nk0DiViZVxb4CFgJppNC7vTx4NalXtLocbrA98Ndkc6Rsh89LDGYp9O6XLJ4zkpup0r2 tq1xbdLGBBBDmCZmk+ix/Bg4pB3vWIM+R/iINeRDsrMf8I7ZRMWTFQ7JazfacAxWK/48 P5BYkLdZQOZ83Htw0jZ+VY5O31f3C2z+T+RyS8xwcdm/Ypd/12xkjInxnj3sbmU1+GIz 917J4Qc/6cchBlJRHtODlPPUYQz2Uy5G7VeBcrlc5QhSEm6aIvUxsndNHV77atWUIwce hcIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059439; x=1786664239; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+wCYK2twR3W1N/eNELl9D0JNBeD1Zbsv+o0OdDwvKek=; b=OMShWt/yzAmdFwvH+STbsLxolBlBmK2KGwQCXmIg8xWSecVc5vq9oqXcaeYLjJjdNp X5SByMhPLIP7/g5cdUnUGcreWqczCohRImPu98hlnfV9UHWNLAh+vnzNUBIjstjLPHF7 4OLxiK4zPvztvB8MjRbsIyE1qsySR4D8Gr3kBZv+R4Nj6KKpXjv4K4TcBuX+vDqHwMOS q2LbYFj7SuzbpfKfq5R1xQYpnNi2wPMBxIZ7XyrrJl39Dvo6V6mvLRzjDobT92i78dkQ /15iRLSJNIjCdVoC1cUG3Ug/+5J2oa0gcvLHYlWlv0LcMk2CNtw/kt8CPqAvIhYnlY8p Xniw== X-Forwarded-Encrypted: i=1; AHgh+RrIQlS5O/uOMbetS1Z1UWIebl7lIrjavg9JQ+PToAyAjKfeaKiKhRmxET5vSJlK4/oWffJLuHLHAoA=@lists.xenproject.org X-Gm-Message-State: AOJu0Yyphl5Sb5f7vVIbg2USZ9jfx7YiILU4LQjhfzQppfH2h4LKHvul dPxD1bVEH8IvZDh4EB42159N1QYXsvT/YlTudLbMvkNqZgfYs4KBtHY113CQWMXWSNjQGGQ2nbl bvwFGJg== X-Received: from pfn34.prod.google.com ([2002:a05:6a00:a222:b0:84a:31b0:7544]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3d4b:b0:84e:89a:b8f7 with SMTP id d2e1a72fcca58-84f2dff69eemr17547973b3a.11.1786059438943; Thu, 06 Aug 2026 16:37:18 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:01 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-45-seanjc@google.com> Subject: [PATCH v6 44/51] x86/kvmclock: WARN if wall clock is read while kvmclock is suspended From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-16d1c6/1786059441-F5A0C77B-106E8E26/0/0 X-purgate-type: clean X-purgate-size: 2065 WARN if kvmclock is still suspended when its wallclock is read, i.e. when the kernel reads its persistent clock. The wallclock subtly depends on the BSP's kvmclock being enabled, and returns garbage if kvmclock is disabled. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 41aff709b90a..2cc3dd2ba355 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -53,6 +53,8 @@ static struct pvclock_vsyscall_time_info *hvclock_mem; DEFINE_PER_CPU(struct pvclock_vsyscall_time_info *, hv_clock_per_cpu); EXPORT_PER_CPU_SYMBOL_GPL(hv_clock_per_cpu); +static bool kvmclock_suspended; + /* * The wallclock is the time of day when we booted. Since then, some time may * have elapsed since the hypervisor wrote the data. So we try to account for @@ -60,6 +62,7 @@ EXPORT_PER_CPU_SYMBOL_GPL(hv_clock_per_cpu); */ static void kvm_get_wallclock(struct timespec64 *now) { + WARN_ON_ONCE(kvmclock_suspended); wrmsrq(msr_kvm_wall_clock, slow_virt_to_phys(&wall_clock)); preempt_disable(); pvclock_read_wallclock(&wall_clock, this_cpu_pvti(), now); @@ -140,6 +143,7 @@ static void kvm_save_sched_clock_state(void) * to the old address prior to reconfiguring kvmclock would clobber * random memory. */ + kvmclock_suspended = true; kvmclock_disable(); } @@ -152,16 +156,19 @@ static void kvm_setup_secondary_clock(void) static void kvm_restore_sched_clock_state(void) { + kvmclock_suspended = false; kvm_register_clock("primary cpu, sched_clock resume"); } static void kvmclock_suspend(struct clocksource *cs) { + kvmclock_suspended = true; kvmclock_disable(); } static void kvmclock_resume(struct clocksource *cs) { + kvmclock_suspended = false; kvm_register_clock("primary cpu, clocksource resume"); } -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385486.1627944 (Exim 4.92) (envelope-from ) id 1ws7hx-00074g-Tg; Thu, 06 Aug 2026 23:41:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385486.1627944; Thu, 06 Aug 2026 23:41:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7hx-00074Z-QB; Thu, 06 Aug 2026 23:41:05 +0000 Received: by outflank-mailman (input) for mailman id 1385486; Thu, 06 Aug 2026 23:41:04 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3nRp1agYKCQIugcpleiqqing.eqozgp-fgxgnnkuvu.zgprtqlgev.qti@flex--seanjc.bounces.google.com>) id 1ws7hw-000747-Hs for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7hv-008OCw-V3 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:03 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3nRp1agYKCQIugcpleiqqing.eqozgp-fgxgnnkuvu.zgprtqlgev.qti@flex--seanjc.bounces.google.com>) id 6a751b54-2eae-0a2a0a5409dd-0a2a4501e234-26 for ; Fri, 07 Aug 2026 01:41:03 +0200 Received: from [209.85.210.200] (helo=mail-pf1-f200.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3nRp1agYKCQIugcpleiqqing.eqozgp-fgxgnnkuvu.zgprtqlgev.qti@flex--seanjc.bounces.google.com>) id 6a751a9e-5984-0a2a45010019-d155d2c8b455-3 for ; Fri, 07 Aug 2026 01:37:03 +0200 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-848568a6f62so4588798b3a.0 for ; Thu, 06 Aug 2026 16:37:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059422; x=1786664222; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=3J0zUIaWZrZleLZttsrL9ykC8Y4xnIiv8MkXpJdWFpw=; b=sdwf+hdnPk8M/0AF0lBHccc4p6Y9Ik5dPM0XPEuzGms0GaXsNtIfI+xnYuATdYKmb1 FVLtZTBP+pT40BUnlVkYj39XCkQcHw82Z2kVKGZIQHyDjlo2WpS/OB0exHrfHo4/7/xR fMjCoM52OmQC0E0mubLNOJ9cuSx0upgRK1Fgg1H8KYRqyonpSQ5C59fWOB42h/m4adHw DbbrBmaNjW/PA5yD8HNI+lCEiQAh4T36yIIUcVHvbsUV3X4LvGm+dMH+CP0UMdLLHTpC 8EmXFPJR/A30ajTM9BeOypvgqBzowb8Y+IUX2DptsN0CQYmKUn4fdtTaJYjFa8ipN97i Js/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059422; x=1786664222; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3J0zUIaWZrZleLZttsrL9ykC8Y4xnIiv8MkXpJdWFpw=; b=NVHMznmnYgi0wOicAkbFPXv0iJQmb3kCDTRWe+FKMHYfl0TmBSiQsVyq1Gx1dbUmAD F6+kgSNudSRlfTw+Lv+pUfmxttaKMAc0cRdFis3rC9JC1bkZr7intzl4u15CzyRYtafk 8LpgYy6RHr2kS67Fh4paFLIzQbd/SCONiWqtXZXOwGsNO0OWaKgBXxyffB1nmZRz0WUk TuguapvyG+JsEkfjo0pG/91Dsa0hNPeZ5uSKvP9MaOHIZo50D9Ih6J7hv0CnsQXz5I6J 9qn8VvUAGH6KtLiFYUiXuARLSIPTupbQjq5t0bxxN9wXFUE6/TdSBeLXcr8yitkLFOTM zRhA== X-Forwarded-Encrypted: i=1; AHgh+Ro/0aATLLG60Lft9v7prygMxyoV1MIY05jSP4Bc366Lb/RP42jxF+cNXHgvYWXB7VxAw9073VfR12g=@lists.xenproject.org X-Gm-Message-State: AOJu0YyM6Q3s+hYRWJywn4pvHxrY3Wj+lUsnhbHUfsyi0Kgnoz5XrDr9 kCbqNCoQcMiYD4jzIu2YGYiHIU0IQEluTC2nCKLDDPw/AvRix6tcQ3yerE56OleYg5qZchdUOu4 BPfNa3g== X-Received: from pfbcz13.prod.google.com ([2002:aa7:930d:0:b0:848:2e05:6161]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:a58f:b0:848:3fe2:c88b with SMTP id d2e1a72fcca58-84f2dfc8fa4mr23126519b3a.6.1786059421552; Thu, 06 Aug 2026 16:37:01 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:47 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-31-seanjc@google.com> Subject: [PATCH v6 30/51] x86/paravirt: Remove unnecessary PARAVIRT=n stub for paravirt_set_sched_clock() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1786059423-C475B757-413D17DB/0/0 X-purgate-type: clean X-purgate-size: 1570 Remove the unnecessary paravirt_set_sched_clock() stub for PARAVIRT=n, as all callers are gated by PARAVIRT=y. Eliminating the stub will avoid a pile of pointless churn as the "real" implementation evolves. No functional change intended. Fixes: 39965afb1151 ("x86/paravirt: Move paravirt_sched_clock() related code into tsc.c") Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 3 +++ arch/x86/kernel/tsc.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index fda18bcb19b4..c71b466d6ace 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -12,7 +12,10 @@ extern void recalibrate_cpu_khz(void); extern int no_timer_check; extern bool using_native_sched_clock(void); + +#ifdef CONFIG_PARAVIRT void paravirt_set_sched_clock(u64 (*func)(void)); +#endif /* * We use the full linear equation: f(x) = a + b*x, in order to allow diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 4c5328d19ebe..e0bea58b6658 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -288,7 +288,6 @@ void paravirt_set_sched_clock(u64 (*func)(void)) u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); bool using_native_sched_clock(void) { return true; } -void paravirt_set_sched_clock(u64 (*func)(void)) { } #endif notrace u64 sched_clock(void) -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385487.1627953 (Exim 4.92) (envelope-from ) id 1ws7i5-0007LH-4U; Thu, 06 Aug 2026 23:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385487.1627953; Thu, 06 Aug 2026 23:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7i5-0007L6-1L; Thu, 06 Aug 2026 23:41:13 +0000 Received: by outflank-mailman (input) for mailman id 1385487; Thu, 06 Aug 2026 23:41:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3pRp1agYKCQo2okxtmqyyqvo.myw7ox-no5ovvs232.7oxz1ytom3.y1q@flex--seanjc.bounces.google.com>) id 1ws7i4-0007KV-Cv for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7i3-008OCw-Q5 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:11 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3pRp1agYKCQo2okxtmqyyqvo.myw7ox-no5ovvs232.7oxz1ytom3.y1q@flex--seanjc.bounces.google.com>) id 6a751b54-2eae-0a2a0a5409dd-0a2a4501e234-30 for ; Fri, 07 Aug 2026 01:41:11 +0200 Received: from [209.85.214.198] (helo=mail-pl1-f198.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3pRp1agYKCQo2okxtmqyyqvo.myw7ox-no5ovvs232.7oxz1ytom3.y1q@flex--seanjc.bounces.google.com>) id 6a751aa6-5984-0a2a45010019-d155d6c6ad1b-3 for ; Fri, 07 Aug 2026 01:37:11 +0200 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cc5faecf01so51050895ad.1 for ; Thu, 06 Aug 2026 16:37:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059429; x=1786664229; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=bZd2/vTLw6kP6aan4oVP2ByAHPA3GmOMxUTn1c9gmLc=; b=JwPsMS2qePbuLpzxHWVdn8VaL8zbSDsTDuvkoD7xlWQyw13kHqKVLpdhbptw+HsRYY m1Ey/HsdQMsonzyBppLMgyXePpjjFsCgK9d2Pa4NbM0dMJL6r1436kNF733cLrg9qvR7 JgZ1NQo3B2QJ/WlgyKA9Y9/ICIeW6NKRoprz5+TyP8OfNeDknekzFFmLfBlkQO+mGl0m MLOmpd44lko0zLcNwQCFHfgxnmUCxgK9GF6+z0pGakvEwGwakTLKd3uyzjCM6U/+GDma R0oh6Zw1n6Sy3vuNOgMZu1VxKy6YUw6cSx2riEkyqQ9uhAafzzDjikM72hTQ/383dftp 80Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059429; x=1786664229; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bZd2/vTLw6kP6aan4oVP2ByAHPA3GmOMxUTn1c9gmLc=; b=rphPptBVjmGjeewxawFUOm8qxfUwfVfTy+XybJxyJVvspABKLK9vKl/cUCal8V6Fws 7cnMos9eO1jPIY+ovskMT4yx2qUZ0aRwkDu8v6xC7rZWacfGipppvzWNjDgKvdLOX6W/ 3xOckocujP/s4sJlzd6MKZm7Fbdc4pbvamlNC2vW1vvoyxLDe5ZbrfskCBSRwHq7dNR1 viEzAIjv5TO/BIDH/YRg04LTzSmoG/EyaXkwjGMZ/lDp08EsaeyItOfF25gcjSFc18lA sFdMbODhO+L/ErSqBk73u3dNdN3Gbcd0gLs7zF5vfuC7zcAnJZ8BPk3WoUhQN/pWCN5h qVgw== X-Forwarded-Encrypted: i=1; AHgh+RogyYbq65Q3wW7SPjjNTMkdhR4zV8OrTeJ9x0X+MFliyp5vQIpluUxXkiIbvUelk/nfMEZleQn+iJ0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxurvRWL+YNBynMez2zFmofEdNqjXkg0xv3g9Z0e5gKCP4SYfyO ElTBJJJg3uPOGLoO68z0FL8F6CFrR1nLe7nBEFUejm8pGUQs3utsuaxt/32OKRll3nEXv9WVdp5 UYGWUEA== X-Received: from pjtz20.prod.google.com ([2002:a17:90a:cb14:b0:36b:7f07:6fcd]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1c84:b0:38f:1e1a:515e with SMTP id 98e67ed59e1d1-3903c5b1688mr16494071a91.14.1786059429092; Thu, 06 Aug 2026 16:37:09 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:53 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-37-seanjc@google.com> Subject: [PATCH v6 36/51] x86/paravirt: Pass sched_clock save/restore helpers during registration From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1786059431-BF46D757-901C4318/0/0 X-purgate-type: clean X-purgate-size: 5767 Pass in a PV clock's save/restore helpers when configuring sched_clock instead of relying on each PV clock to manually set the save/restore hooks. In addition to bringing sanity to the code, this will allow gracefully "rejecting" a PV sched_clock, e.g. when running as a CoCo guest that has access to a "secure" TSC. No functional change intended. Reviewed-by: David Woodhouse Reviewed-by: Michael Kelley Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 9 ++++++--- arch/x86/kernel/cpu/vmware.c | 8 +++----- arch/x86/kernel/kvmclock.c | 6 +++--- arch/x86/kernel/tsc.c | 5 ++++- arch/x86/xen/time.c | 5 ++--- drivers/clocksource/hyperv_timer.c | 6 ++---- 6 files changed, 20 insertions(+), 19 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index fe41d40a9ae6..e97cd1ae03d1 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,11 +14,14 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable); +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)); -static inline void paravirt_set_sched_clock(u64 (*func)(void)) +static inline void paravirt_set_sched_clock(u64 (*func)(void), + void (*save)(void), + void (*restore)(void)) { - __paravirt_set_sched_clock(func, true); + __paravirt_set_sched_clock(func, true, save, restore); } #endif diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 94fec990a02c..3598de5297f8 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -347,11 +347,9 @@ static void __init vmware_paravirt_ops_setup(void) vmware_cyc2ns_setup(); - if (vmw_sched_clock) { - paravirt_set_sched_clock(vmware_sched_clock); - x86_platform.save_sched_clock_state = x86_init_noop; - x86_platform.restore_sched_clock_state = x86_init_noop; - } + if (vmw_sched_clock) + paravirt_set_sched_clock(vmware_sched_clock, + x86_init_noop, x86_init_noop); if (vmware_is_stealclock_available()) { has_steal_clock = true; diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 07e875738c39..5b9955343199 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -158,7 +158,9 @@ static void kvm_restore_sched_clock_state(void) static inline void kvm_sched_clock_init(bool stable) { kvm_sched_clock_offset = kvm_clock_read(); - __paravirt_set_sched_clock(kvm_sched_clock_read, stable); + __paravirt_set_sched_clock(kvm_sched_clock_read, stable, + kvm_save_sched_clock_state, + kvm_restore_sched_clock_state); pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); @@ -367,8 +369,6 @@ void __init kvmclock_init(bool prefer_tsc) #ifdef CONFIG_SMP x86_cpuinit.early_percpu_clock_init = kvm_setup_secondary_clock; #endif - x86_platform.save_sched_clock_state = kvm_save_sched_clock_state; - x86_platform.restore_sched_clock_state = kvm_restore_sched_clock_state; kvm_get_preset_lpj(); /* diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 60fcc3020792..d4f7cb127235 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,12 +280,15 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable) +void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)) { if (!stable) clear_sched_clock_stable(); static_call_update(pv_sched_clock, func); + x86_platform.save_sched_clock_state = save; + x86_platform.restore_sched_clock_state = restore; } #else u64 sched_clock_noinstr(void) __attribute__((alias("native_sched_clock"))); diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 477441752f40..8cd8bfaf1320 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -566,13 +566,12 @@ static void __init xen_init_time_common(void) { xen_sched_clock_offset = xen_clocksource_read(); static_call_update(pv_steal_clock, xen_steal_clock); - paravirt_set_sched_clock(xen_sched_clock); + /* * Xen has paravirtualized suspend/resume and so doesn't use the common * x86 sched_clock save/restore hooks. */ - x86_platform.save_sched_clock_state = x86_init_noop; - x86_platform.restore_sched_clock_state = x86_init_noop; + paravirt_set_sched_clock(xen_sched_clock, x86_init_noop, x86_init_noop); x86_init.hyper.get_tsc_khz = xen_tsc_khz; x86_platform.get_wallclock = xen_get_wallclock; diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index 220668207d19..8ee7a9de0f4f 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -570,10 +570,8 @@ static void hv_restore_sched_clock_state(void) static __always_inline void hv_setup_sched_clock(void *sched_clock) { /* We're on x86/x64 *and* using PV ops */ - paravirt_set_sched_clock(sched_clock); - - x86_platform.save_sched_clock_state = hv_save_sched_clock_state; - x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; + paravirt_set_sched_clock(sched_clock, hv_save_sched_clock_state, + hv_restore_sched_clock_state); } #else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */ static __always_inline void hv_setup_sched_clock(void *sched_clock) {} -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385489.1627962 (Exim 4.92) (envelope-from ) id 1ws7iB-0007dy-Bx; Thu, 06 Aug 2026 23:41:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385489.1627962; Thu, 06 Aug 2026 23:41:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iB-0007dr-8a; Thu, 06 Aug 2026 23:41:19 +0000 Received: by outflank-mailman (input) for mailman id 1385489; Thu, 06 Aug 2026 23:41:18 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3qxp1agYKCRA8uq3zsw44w1u.s42Du3-tuBu11y898.Du3574zus9.47w@flex--seanjc.bounces.google.com>) id 1ws7iA-0007d6-HU for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7i9-008OCw-Ue for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:17 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3qxp1agYKCRA8uq3zsw44w1u.s42Du3-tuBu11y898.Du3574zus9.47w@flex--seanjc.bounces.google.com>) id 6a751b54-2eae-0a2a0a5409dd-0a2a4501e234-32 for ; Fri, 07 Aug 2026 01:41:17 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3qxp1agYKCRA8uq3zsw44w1u.s42Du3-tuBu11y898.Du3574zus9.47w@flex--seanjc.bounces.google.com>) id 6a751aac-5984-0a2a45010019-d155d2c6c949-3 for ; Fri, 07 Aug 2026 01:37:17 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84870e7f498so2971196b3a.3 for ; Thu, 06 Aug 2026 16:37:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059436; x=1786664236; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=DfVsK4/eNAzlqgTkif/k+3bkJqkVsqeG8riFv7GGWx4=; b=bSzLM4/00PB1CxAEp+IcCxGjD269tSdqycIW8zekVxv/OHABbdfOVwmR21q1fU72Gu xWG0asr0bVIqogTS9CAp6hKw4Er6job4QcWphqUaAqrJ0v7w6tRDhsDApgiFWux61LeX Xo/m5u6OdwsRkK2gk3Dch3TrdC26HLeGXmarzNiFFDuZzTlpAWYM8z8V4QuTOaIUqkst bbycINGQ8Ttc51/A8YmosKo2uXXY/uapTFHHq6kwSDhuq5LDu4MPqYcRusVZYQAKoBgN uneXgX8i+tn9c8fvpfzzrevbid5x45eHtze6qLRYT6Ycz/l+Qw34saXgBiS3demKloU1 0AjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059436; x=1786664236; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DfVsK4/eNAzlqgTkif/k+3bkJqkVsqeG8riFv7GGWx4=; b=XrVylOJaUFaH0HD4BLoBkL3anAzv6QnXRw5rM+invhm9YL5q82TSoWSEHTmomyfN3Q fs0bBCTEhLngJXrhkkdAeRyYbJKqBOy2V6tC9NvanuOrnL1AZ/tfyM/A0PPe5tIyMojf L+b5YZQLhkrmeUrzAN3Ke5w2OVK/piztWuNhhOP53qD2XYV1kC2IMcNvrDuM7ynfElD7 JlBx9lceW4gsYddXOBhCeSd4kM6k2T7wxtUTA/+J6NOLiBD5KCjGCQjyA6RM9jzJGLvr zpebVJ9P9+OcnljFBxpnA397F3k8rqWUFPeGnonU28iK7HRU3PU4PCusoJ+ElMW/JfR1 fP5Q== X-Forwarded-Encrypted: i=1; AHgh+RqN63UmZBGi/fEqUt03MJMG0USpSWvFIAbBWzGc4OV0SsVESxCMx6wxFHZjbyv67FT6xZIsMzWALJM=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx/9uVhU+JKFAssWnuBEDzjoWO4GAPzDlcrI7lO0hCWV5wtzuUT Akdecpif2+7spua3OfUM2dnTtoxFc/CDZlSNZMij3vUNCvw8UeGVo8fEBNk08Z8HZL99SROAT/D 3P7nMdA== X-Received: from pfbko19.prod.google.com ([2002:a05:6a00:4613:b0:847:926b:dc17]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1886:b0:847:99a7:c751 with SMTP id d2e1a72fcca58-84f2e05d02dmr18083285b3a.25.1786059435385; Thu, 06 Aug 2026 16:37:15 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:58 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-42-seanjc@google.com> Subject: [PATCH v6 41/51] x86/kvmclock: Refactor handling of PVCLOCK_TSC_STABLE_BIT during kvmclock_init() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1786059437-BF063757-6D3BDBFE/0/0 X-purgate-type: clean X-purgate-size: 1894 Clean up the setting of PVCLOCK_TSC_STABLE_BIT during kvmclock init to make it somewhat obvious that pvclock_read_flags() must be called *after* pvclock_set_flags(). Note, in theory, a different PV clock could have set PVCLOCK_TSC_STABLE_BIT in the supported flags, i.e. reading flags only if KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is set could very, very theoretically result in a change in behavior. In practice, the kernel only supports a single PV clock. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 5220d205abc7..61d4d943fe74 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -327,7 +327,7 @@ static __init void kvm_sched_clock_init(bool stable) void __init kvmclock_init(bool prefer_tsc) { - u8 flags; + bool stable = false; if (!kvm_para_available() || !kvmclock) return; @@ -354,11 +354,18 @@ void __init kvmclock_init(bool prefer_tsc) kvm_register_clock("primary cpu clock"); pvclock_set_pvti_cpu0_va(hv_clock_boot); - if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT)) + if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT)) { pvclock_set_flags(PVCLOCK_TSC_STABLE_BIT); - flags = pvclock_read_flags(&hv_clock_boot[0].pvti); - kvm_sched_clock_init(flags & PVCLOCK_TSC_STABLE_BIT); + /* + * Check if the clock is stable *after* marking TSC_STABLE as a + * valid flag. + */ + stable = pvclock_read_flags(&hv_clock_boot[0].pvti) & + PVCLOCK_TSC_STABLE_BIT; + } + + kvm_sched_clock_init(stable); if (!x86_init.hyper.get_tsc_khz) x86_init.hyper.get_tsc_khz = kvmclock_get_tsc_khz; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385491.1627971 (Exim 4.92) (envelope-from ) id 1ws7iE-0007vt-In; Thu, 06 Aug 2026 23:41:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385491.1627971; Thu, 06 Aug 2026 23:41:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iE-0007vh-FN; Thu, 06 Aug 2026 23:41:22 +0000 Received: by outflank-mailman (input) for mailman id 1385491; Thu, 06 Aug 2026 23:41:21 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3rRp1agYKCRIAws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 1ws7iD-0007sA-1P for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iC-00EM9p-El for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:20 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3rRp1agYKCRIAws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 6a751b54-bab6-0a2a0a5309dd-0a2a450297c0-16 for ; Fri, 07 Aug 2026 01:41:20 +0200 Received: from [209.85.214.197] (helo=mail-pl1-f197.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3rRp1agYKCRIAws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 6a751aae-6ca4-0a2a45020019-d155d6c5ac6e-3 for ; Fri, 07 Aug 2026 01:37:19 +0200 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ce7dfd33ffso32943235ad.0 for ; Thu, 06 Aug 2026 16:37:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059438; x=1786664238; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=LM+bFo6oZyT6hMjeOJv5/5C5Sfvue9FfV0H+MNWzQd0=; b=bwdii+XOuYFQh4W5s+gsVBsTZlabSvuKjQ7targ/TP2zDDQ29IqcxdMYeWzQOol/kO YovjPed21L0/DoJSf1iMqruWYB4ppxFfBpj0cA3FsUXLVuqyJgnivh3lcdK8jZVAbrjU eLW88Iy/7lk89HGbBFcVUIdCqzPk00OPU+O2XMBB7f8+hPO0h+yISxMtkakbWFQ1L0gB ZDLrPbelxa+1qMDXX3sgO1qd7ESAkrJ8+efgy1JiBrSyfSz2wb5E04EGRdW6WK4SrRbx U0kyfBtefF6bR8roiyH+iUnMIVN/QJjmLLDzUzqNQTwOjMqf9Vw9y+XRtDoQYfn/59Yt sgKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059438; x=1786664238; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LM+bFo6oZyT6hMjeOJv5/5C5Sfvue9FfV0H+MNWzQd0=; b=E3Fd3WsSUxfm4bzQWFRnTD+r1cWem2efhi3I9tG5ylNlaZdpw8wfDmx8APZBio5tap 0iI6/SLJ/59B0AkVSNWZSXd7LIShXYEsE7Iu/d0eb2M6hSC9CrJWjaWi9TCQH+hYigDh Ke7OdtXIqKw/kaSYJlUm4ncbsb8UHPXcExv1+NwTm1mf7nMd7iNqQZD/g6gsk5cRmo7Z RArMv8usgwnN27HbR8pzFouS/Ia4jYTnGsqA1VDs1YwOZ/09gwgM4Ry5dh9VII15Qnbz 7Tfx0i5wDqhD0sQ+PoAAMrulepmnL5MPwQySEG199Qw7WQqU3ZYnbM0zKY7t8k6tC5jH 1wuA== X-Forwarded-Encrypted: i=1; AHgh+RoHQeaPcC8nKZDBR2S/rGJkgSWFGMozsdFjua6XYqBu5wk+uoxclvA2XakCy2VqGGNhgIkz7skuOCg=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw3LKCPX17aaspYoI0/WKPI/tnLafwevWYGmguMp7++vMAzcwhE 0RhNHzgJybzkcQy/68yNn+isIURL4f75Xjj+MCf1Pokj7bYtvsWjyrDNk5CLyATfDxVuz1zXBoX qRuy5vQ== X-Received: from pjuf1.prod.google.com ([2002:a17:90a:ce01:b0:38e:aa86:7cac]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5447:b0:380:83fc:4315 with SMTP id 98e67ed59e1d1-3903c66b3bfmr20385633a91.21.1786059437671; Thu, 06 Aug 2026 16:37:17 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:00 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-44-seanjc@google.com> Subject: [PATCH v6 43/51] x86/kvmclock: Hook clocksource.suspend/resume when kvmclock isn't sched_clock From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-720697/1786059440-30BC02AC-D92D305D/0/0 X-purgate-type: clean X-purgate-size: 2030 Save/restore kvmclock across suspend/resume via clocksource hooks when kvmclock isn't being used for sched_clock. This will allow using kvmclock as a clocksource (or for wallclock!) without also using it for sched_clock. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 61d4d943fe74..41aff709b90a 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -152,7 +152,17 @@ static void kvm_setup_secondary_clock(void) static void kvm_restore_sched_clock_state(void) { - kvm_register_clock("primary cpu clock, resume"); + kvm_register_clock("primary cpu, sched_clock resume"); +} + +static void kvmclock_suspend(struct clocksource *cs) +{ + kvmclock_disable(); +} + +static void kvmclock_resume(struct clocksource *cs) +{ + kvm_register_clock("primary cpu, clocksource resume"); } void kvmclock_cpu_action(enum kvm_guest_cpu_action action) @@ -223,6 +233,8 @@ static struct clocksource kvm_clock = { .flags = CLOCK_SOURCE_IS_CONTINUOUS, .id = CSID_X86_KVM_CLK, .enable = kvm_cs_enable, + .suspend = kvmclock_suspend, + .resume = kvmclock_resume, }; static void __init kvmclock_init_mem(void) @@ -318,6 +330,15 @@ static __init void kvm_sched_clock_init(bool stable) kvm_save_sched_clock_state, kvm_restore_sched_clock_state); + /* + * The BSP's clock is managed via dedicated sched_clock save/restore + * hooks when kvmclock is used as sched_clock, as sched_clock needs to + * be kept alive until the very end of suspend entry, and restored as + * quickly as possible after resume. + */ + kvm_clock.suspend = NULL; + kvm_clock.resume = NULL; + pr_info("kvm-clock: using sched offset of %llu cycles", kvm_sched_clock_offset); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385492.1627980 (Exim 4.92) (envelope-from ) id 1ws7iH-0008DB-0O; Thu, 06 Aug 2026 23:41:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385492.1627980; Thu, 06 Aug 2026 23:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iG-0008Cz-SH; Thu, 06 Aug 2026 23:41:24 +0000 Received: by outflank-mailman (input) for mailman id 1385492; Thu, 06 Aug 2026 23:41:23 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3sBp1agYKCRUDzv84x19916z.x97Iz8-yzGz663DED.Iz8AC94zxE.9C1@flex--seanjc.bounces.google.com>) id 1ws7iF-000875-K5 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iF-00EM9p-0p for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:23 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3sBp1agYKCRUDzv84x19916z.x97Iz8-yzGz663DED.Iz8AC94zxE.9C1@flex--seanjc.bounces.google.com>) id 6a751b43-bab6-0a2a0a5309dd-0a2a4503de86-44 for ; Fri, 07 Aug 2026 01:41:23 +0200 Received: from [209.85.214.197] (helo=mail-pl1-f197.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3sBp1agYKCRUDzv84x19916z.x97Iz8-yzGz663DED.Iz8AC94zxE.9C1@flex--seanjc.bounces.google.com>) id 6a751ab1-fae8-0a2a45030019-d155d6c5dd76-3 for ; Fri, 07 Aug 2026 01:37:22 +0200 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cc640dfde3so31468195ad.1 for ; Thu, 06 Aug 2026 16:37:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059440; x=1786664240; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ITopxW07/FQizEWlsu5JVYhKtG4YNcRGYaSiNeAs44w=; b=OEOiy4AadltqPg7dktu1ig2gjTVOJ0LY1Lt0Ni40UNEkqd0+CE1V41tpxoY2jaiul1 +hF3dJjSmkWxh369YXpBPYEkwstgq3YfsiF0+8od4igD9KchpP71c9YupRc7YhRYcdrf 34LIBIuzG5UMLBQfwwzhfYw+c0cNLvLXBfxWtz/7SLWQzBZ8ZkyYjlzaBuHH2Ot6LiZf naRH33EQ2pDgbdpS7d33OOCO1Z9cFdPF+v4UNPrv6wIN3cOba/PwZcLGs2hmH5snsAJm m/1yCOXoqIqSIGYcOvgzRJwhPue5ujtHNzx8YBXM6/QPb+hnmSRt4XB1LVsgtUJwPyAY NHRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059440; x=1786664240; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ITopxW07/FQizEWlsu5JVYhKtG4YNcRGYaSiNeAs44w=; b=fHpsTz6TW6asDxr1wL7rvjMdO6UTIvx9J7+VP+FJitTHIdXYDofhiFvLlrIAZrbG/m e42afvqdvTVN0Q2+gKuYmEAKNPIbcNPA3BOR6vvTnfW91LtR53EHkGLMIph5MgrmJ1c8 XtKRLH83YPX9wZbaRZS5yO73Lb7Fyc0hjKyVK70HOHnKDt3951AJlvfB/cMZbIs7Cuow eomiFcrcmfDYGP9+CBloHp0CZ1QeK5LqjoXJIF8WbDFll6KQtsagjWBf654p9pF+HXan /fsy+PsLJfMGmOnGOT8o9+cYeIU+YDtwOvniRv2E8ns7koxutT0xiv9ACe1xLKoMz2UZ y8Tg== X-Forwarded-Encrypted: i=1; AHgh+RrPln7+KZu6/nyWteNpYj1huCIqnT6XkRGcKX52cwbYoS27EKbm9nV9c09ZxleIN2Ge1+ROLplERes=@lists.xenproject.org X-Gm-Message-State: AOJu0YyAZB4RWFKKaBMhzTm/WIsYsFgqCf/vbx8zfb7Gy5Ew9UaCtrdF SFEYLRK3hy6zK72AEJ1V4Ev14LXb1w86tmJ+6qjVM7V/j9PneOL6qI4YRns1EG/3MK6KbqPgpw3 QmIFGzw== X-Received: from pljs12.prod.google.com ([2002:a17:903:3bac:b0:2ca:e163:e0c8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:41ce:b0:2cf:afa5:b19a with SMTP id d9443c01a7336-2d0ca7f8e9amr186517945ad.11.1786059440120; Thu, 06 Aug 2026 16:37:20 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:02 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-46-seanjc@google.com> Subject: [PATCH v6 45/51] x86/paravirt: Mark __paravirt_set_sched_clock() as __init From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1786059442-6DED24E9-0AC77DE5/0/0 X-purgate-type: clean X-purgate-size: 2068 Annotate __paravirt_set_sched_clock() as __init, and make its wrapper __always_inline to ensure sanitizers don't result in a non-inline version hanging around. All callers run during __init, and changing sched_clock after boot would be all kinds of crazy. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/timer.h | 10 +++++----- arch/x86/kernel/tsc.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index e97cd1ae03d1..96ae7feac47c 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h @@ -14,12 +14,12 @@ extern int no_timer_check; extern bool using_native_sched_clock(void); #ifdef CONFIG_PARAVIRT -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)); +void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)); -static inline void paravirt_set_sched_clock(u64 (*func)(void), - void (*save)(void), - void (*restore)(void)) +static __always_inline void paravirt_set_sched_clock(u64 (*func)(void), + void (*save)(void), + void (*restore)(void)) { __paravirt_set_sched_clock(func, true, save, restore); } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index d4f7cb127235..363145c83919 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -280,8 +280,8 @@ bool using_native_sched_clock(void) return static_call_query(pv_sched_clock) == native_sched_clock; } -void __paravirt_set_sched_clock(u64 (*func)(void), bool stable, - void (*save)(void), void (*restore)(void)) +void __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, + void (*save)(void), void (*restore)(void)) { if (!stable) clear_sched_clock_stable(); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385493.1627988 (Exim 4.92) (envelope-from ) id 1ws7iJ-0008V2-9o; Thu, 06 Aug 2026 23:41:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385493.1627988; Thu, 06 Aug 2026 23:41:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iJ-0008U8-5M; Thu, 06 Aug 2026 23:41:27 +0000 Received: by outflank-mailman (input) for mailman id 1385493; Thu, 06 Aug 2026 23:41:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3shp1agYKCRcF1xA6z3BB381.zB9K1A-01I1885FGF.K1ACEB61zG.BE3@flex--seanjc.bounces.google.com>) id 1ws7iH-0008Nb-Rw for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iH-00H1om-8Y for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:25 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3shp1agYKCRcF1xA6z3BB381.zB9K1A-01I1885FGF.K1ACEB61zG.BE3@flex--seanjc.bounces.google.com>) id 6a751b6a-5cb7-0a2a0a5109dd-0a2a45058b62-16 for ; Fri, 07 Aug 2026 01:41:25 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3shp1agYKCRcF1xA6z3BB381.zB9K1A-01I1885FGF.K1ACEB61zG.BE3@flex--seanjc.bounces.google.com>) id 6a751ab3-4cb1-0a2a45050019-d155d2c6b8a6-3 for ; Fri, 07 Aug 2026 01:37:24 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84e375d9736so3450990b3a.2 for ; Thu, 06 Aug 2026 16:37:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059443; x=1786664243; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=NcgEnPBxyGviYS1Y0BEogKtyt4exk2sJiTd88Re19eg=; b=gk79UyMXWHbVx8Tg7IcacASgySWpa/8r9P+UNNN10lXzRr0rRCNjsZ241i87iur94m kXlpfambj0vZ4aDfXBL3hYXwf5mKnZ2E4g2HeCALcLv8PjZiz3azvG9X6Kny5FclVUjL 5B0Yl1up8lStw3KDb4u6h/ZLNXrnipkOimgf86rICGHF5aCo/BQxDn7G0KcSsgIQUBh+ /8wZDNsoNBkHtz8MXYUxzcfyfVbxSBl2fuMgVUx2aa5DiRHw5QDjGcX2R9xQqgLstMV5 gXwXP0F7y0nvA51e0Nh1jCtyb1jThSomHSkr7x00z7HT4dgpY+JHzv76Z/cjrdqK+2V0 Vuig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059443; x=1786664243; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NcgEnPBxyGviYS1Y0BEogKtyt4exk2sJiTd88Re19eg=; b=VjNkqZFhRQoZMrBfNT7KNRa1r5jsW8V0VFXUn9a1+PIThyoE5SyZBd1/PNAkuBKJ6p uWM6HfKIBroMcFShj1edGoezLU1zVsBr0JnIFYKqzjhXb9y5f9ZYysPHoT6s7Ul6+AZi bgph83kxDKKXt3/i8pa0fzg9VC5ThGiEfsEgUQI66CSBk1ChS3L/musn2g0gFX0Ccxx5 85XylLC8W0DPBIaoVybYKsVb1nkkGahLaVpGpmxRUOJJPTkGn4BPD2S5vJtV0FFz8xGY M/xSoLHfYBSMY3tRxoQDlYuG0fgZNTmRQIDUOBXF9ryiQLiG1fxhXHnpVeAvohTbbbtT LNTg== X-Forwarded-Encrypted: i=1; AHgh+RoFvNBDNGWUwZJHIN8zbhFn779uCQM809fUfj6m/JBfhm5lO1mKJpvRRfsGbnyTvMtxoCAINonAtNQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YzXB72d8kGe9B7dVIPWZW/42lrYKvX/h2Gag9h3gtBolp9EUKWI hk/nZFBt1DyK+p7hqH1E/Om1pA6jwG1eBo/K4k7ZY3Hmnk2dWciHDp2+uv7AomVyFymoAonHouL 1XvZ5yA== X-Received: from pfbcw11.prod.google.com ([2002:a05:6a00:450b:b0:848:51a7:e8bb]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2999:b0:848:67ca:bfd with SMTP id d2e1a72fcca58-84f2dff1913mr22778991b3a.16.1786059442569; Thu, 06 Aug 2026 16:37:22 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:04 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-48-seanjc@google.com> Subject: [PATCH v6 47/51] x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c201ff/1786059444-71EA92A1-D7CF7710/0/0 X-purgate-type: clean X-purgate-size: 1384 Silently ignore attempts to switch to a paravirt sched_clock when running as a CoCo guest with trusted TSC. In hand-wavy theory, a misbehaving hypervisor could attack the guest by manipulating the PV clock to affect guest scheduling in some weird and/or predictable way. More importantly, reading TSC on such platforms is faster than any PV clock, and sched_clock is all about speed. Reviewed-by: David Woodhouse Reviewed-by: Nikunj A Dadhania Signed-off-by: Sean Christopherson --- arch/x86/kernel/tsc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index fcf331ffd874..c0e4485484f2 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -283,6 +283,15 @@ bool using_native_sched_clock(void) int __init __paravirt_set_sched_clock(u64 (*func)(void), bool stable, void (*save)(void), void (*restore)(void)) { + /* + * Don't replace TSC with a PV clock when running as a CoCo guest and + * the TSC is secure/trusted; PV clocks are emulated by the hypervisor, + * which isn't in the guest's TCB. + */ + if (cc_platform_has(CC_ATTR_GUEST_SNP_SECURE_TSC) || + boot_cpu_has(X86_FEATURE_TDX_GUEST)) + return -EPERM; + if (!stable) clear_sched_clock_stable(); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385494.1627998 (Exim 4.92) (envelope-from ) id 1ws7iK-0000Mf-Li; Thu, 06 Aug 2026 23:41:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385494.1627998; Thu, 06 Aug 2026 23:41:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iK-0000Lt-Ej; Thu, 06 Aug 2026 23:41:28 +0000 Received: by outflank-mailman (input) for mailman id 1385494; Thu, 06 Aug 2026 23:41:27 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3sxp1agYKCRgG2yB704CC492.0CAL2B-12J2996GHG.L2BDFC720H.CF4@flex--seanjc.bounces.google.com>) id 1ws7iI-0008T8-W7 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iI-00EM9p-D4 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:26 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3sxp1agYKCRgG2yB704CC492.0CAL2B-12J2996GHG.L2BDFC720H.CF4@flex--seanjc.bounces.google.com>) id 6a751b54-bab6-0a2a0a5309dd-0a2a450297c0-18 for ; Fri, 07 Aug 2026 01:41:26 +0200 Received: from [209.85.215.199] (helo=mail-pg1-f199.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3sxp1agYKCRgG2yB704CC492.0CAL2B-12J2996GHG.L2BDFC720H.CF4@flex--seanjc.bounces.google.com>) id 6a751ab4-6ca4-0a2a45020019-d155d7c7b07f-3 for ; Fri, 07 Aug 2026 01:37:25 +0200 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb733fc5024so3799739a12.2 for ; Thu, 06 Aug 2026 16:37:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059444; x=1786664244; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ZEuUzNS+h+uJbnucj4BSLPHP7Njp50j+oXkHsgjPk/g=; b=L6L5D/GQ3gaL/LVb4vPxChzBzNid+DgXTN5AY8HZiN9dR+uGu6op0q1L8Q0GR21wd3 rQ6AgC2JasMNQ0Ui75vzttHkhcOkXynjG8okz7vSWrV1ro5SMxw7QilFAUrOHRykWbjG H5F6npHvSPRyC6gmkfuGPbfRuHJciEanKtS7++SJxFDZI/6vOjJ6HMMFeUKI4LXbcHEK Wij7OqV6yM0U0tlUyrre4x6q7tf5gIchSsqCICTXRSE1PL8iMopd/wC1K9Suoq9EJjUD Iplv5T6lXlSr94GG1mu/z4JiMjcgXsnLIQy88NiJBBhM8Eh19iv4M7OmDNaklChYMbSV h/yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059444; x=1786664244; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ZEuUzNS+h+uJbnucj4BSLPHP7Njp50j+oXkHsgjPk/g=; b=KOyo6VN4wwQmVBmhR9zKHObQSuAzn1rQ4jXlYcpG7A2qBGyXpirqfvcxCRR6mgJaCA mgv+S2iwAIroB2jpVSzUYH4t38IiQk+MjV3AVXL3rgEw4lg0oHhR7NAb9gcVq8M0X+Hb nuck6YbcdbzXYMHkb8QuCUtLIkWKMdecwwYe5UztYKMkP1Jw8IS7Af1ViI6aluPuYbtn ex2S7g3s+OjGG4BLbNl4r5f8FNo9ob5YM/yvvQLh4NvoZc5y0slj2IMU16sqdY7e4GgP 4NeJkrCWRQuL//1mdGYbHbFz5n4+qY1NDCXUjsDykV+YxYswfsbMd25Dqro7H0d7iKnN Zb1g== X-Forwarded-Encrypted: i=1; AHgh+RpB54QCTu930IlnMc0AaUIMkXWEWb2PV2fhCrxjhOAqSvRmFdS/cZQhsJjtNXHI1msYth4xvnrGfxs=@lists.xenproject.org X-Gm-Message-State: AOJu0YzrH40Sr805+PNleITevinm9W+lyRpTzwzuikwSoCyv4pNrqoSl QBxEHZ2/lQugKf/OO/mzZF4OvI7Hf0+w7kgPCOlIBwscj+WEo9c1PIyS8TYp14j6VDNBAFG0kwO j1WHCgg== X-Received: from pgng29.prod.google.com ([2002:a63:375d:0:b0:c9a:c533:8329]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:4309:b0:3c8:ead5:bf7b with SMTP id adf61e73a8af0-3cb85ded991mr21268446637.4.1786059443651; Thu, 06 Aug 2026 16:37:23 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:05 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-49-seanjc@google.com> Subject: [PATCH v6 48/51] x86/kvmclock: Use TSC for sched_clock if it's constant and non-stop From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-720697/1786059446-67ABD2AC-0AC34026/13/0 X-purgate-type: clean X-purgate-size: 2191 Prefer the TSC over kvmclock for sched_clock if the TSC is constant and nonstop. I.e. use the same criteria as tweaking the clocksource rating so that TSC is preferred over kvmclock. Per the below comment from native_sched_clock(), sched_clock is more tolerant of slop than clocksource; using TSC for clocksource but not sched_clock makes little to no sense, especially now that KVM CoCo guests with a trusted TSC use TSC, not kvmclock. /* * Fall back to jiffies if there's no TSC available: * ( But note that we still use it if the TSC is marked * unstable. We do this because unlike Time Of Day, * the scheduler clock tolerates small errors and it's * very important for it to be as fast as the platform * can achieve it. ) */ The only advantage of using kvmclock is that doing so allows for early and common detection of PVCLOCK_GUEST_STOPPED, but that code has been broken for over two years with nary a complaint, i.e. it can't be _that_ valuable. And as above, certain types of KVM guests are losing the functionality regardless, i.e. acknowledging PVCLOCK_GUEST_STOPPED needs to be decoupled from sched_clock() no matter what. Link: https://lore.kernel.org/all/Z4hDK27OV7wK572A@google.com Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 22e8855fcd4d..bc98ebb8587d 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -396,7 +396,6 @@ void __init kvmclock_init(bool prefer_tsc) PVCLOCK_TSC_STABLE_BIT; } - kvm_sched_clock_init(stable); if (!x86_init.hyper.get_tsc_khz) x86_init.hyper.get_tsc_khz = kvmclock_get_tsc_khz; @@ -416,6 +415,8 @@ void __init kvmclock_init(bool prefer_tsc) */ if (prefer_tsc) kvm_clock.rating = 299; + else + kvm_sched_clock_init(stable); clocksource_register_hz(&kvm_clock, NSEC_PER_SEC); pv_info.name = "KVM"; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385500.1628007 (Exim 4.92) (envelope-from ) id 1ws7iL-0000da-Tm; Thu, 06 Aug 2026 23:41:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385500.1628007; Thu, 06 Aug 2026 23:41:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iL-0000cu-OB; Thu, 06 Aug 2026 23:41:29 +0000 Received: by outflank-mailman (input) for mailman id 1385500; Thu, 06 Aug 2026 23:41:28 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3tBp1agYKCRkH3zC815DD5A3.1DBM3C-23K3AA7HIH.M3CEGD831I.DG5@flex--seanjc.bounces.google.com>) id 1ws7iK-0000Hg-CK for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iJ-00EM9p-Lx for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:27 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3tBp1agYKCRkH3zC815DD5A3.1DBM3C-23K3AA7HIH.M3CEGD831I.DG5@flex--seanjc.bounces.google.com>) id 6a751b7a-bab6-0a2a0a5309dd-0a2a4504bd98-22 for ; Fri, 07 Aug 2026 01:41:27 +0200 Received: from [209.85.214.200] (helo=mail-pl1-f200.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3tBp1agYKCRkH3zC815DD5A3.1DBM3C-23K3AA7HIH.M3CEGD831I.DG5@flex--seanjc.bounces.google.com>) id 6a751ab5-b57f-0a2a45040019-d155d6c8e0ce-3 for ; Fri, 07 Aug 2026 01:37:27 +0200 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cfca8558d2so38193835ad.2 for ; Thu, 06 Aug 2026 16:37:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059445; x=1786664245; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=/TxUyuE9/koLQyW6zcM5dMaQ+pcBou93eYQoJAAWN+E=; b=py92CSIgyIhcjgfTx2xOs1Vcu3Mzaz8ATWpS5/tETq28W/m6sIKylWGyEndVB8Rvnr tfN3y+ayFk984f/50g3cHAz6iJUHhASw/ocOVFqfOW0KUTUmq423VpuaI9pFoRrqOPzo FvSNiM922zAjK7Sb8hBIoC6315AX6aG9htVQ5Ll9DtTUHUts07NbMLFd6e34ZBqtJY9k BGA7zJPbjh0QP7OhJ5TUCQCpa+ieAvCAMvDLC7j06BjveIgpf1LlAzDdtzaKvyeGxt0w N8RM3Fa2OWxsUfZFzQ/4BSgDNpSTjdjj2v7eNIXtwgwYDAhKivBwM9I2SZAXXe7m1VQ3 UHAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059445; x=1786664245; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/TxUyuE9/koLQyW6zcM5dMaQ+pcBou93eYQoJAAWN+E=; b=HB/zEO4WrAkbFIiMtOmap7ioFIEX/mVao0Ri/eMJybRuaRtGX9ZnehfdqLHXFmjez1 Xcbupq5qemb2tMEPjNgATOyCtqLZs9NIwnsVBLsWquP5wLAHay7f7mlQYIrB7iFlnh3F 8LsAv4i10esxlBIAeq0odME2sz+cSQqg8oPGBPm0ftFR1jL8yr9foVsf1jpGGTpkF5lm ZmEQXmmOT97FM3a+z1/LPou1SPn97Wss4U0E7oHGWNo3mDtVM7he44axRH8/IziUF2Wq lb/cBiJaboOuC55YreYeqOzR7UAhY75AyNqDkwrGb2d8y979cs9C21xoM2dkSDGYPsTs W6ww== X-Forwarded-Encrypted: i=1; AHgh+RqdIkRmN+ymEEYUsy3nAxZy0Dk3M2jHPzRVpnbWMHTTh4U+inHvzxJk0y07btHe+iUA3I8A/HGY9fo=@lists.xenproject.org X-Gm-Message-State: AOJu0YwM9poZNYrEdq4ijRdwTIYGKKK03fDllfdx11zmA1lVCF3uj5qe CHUc1J0Wkc9XMOGlOuiM9amgkn50IRmrK68P7VaOgHE9jsSgbEbenY2mIcYTKy0LSjv+tAuVE53 mFcwxgA== X-Received: from plgi9.prod.google.com ([2002:a17:902:cf09:b0:2c7:e06e:86f6]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:c402:b0:2c9:c952:6e9 with SMTP id d9443c01a7336-2d0ca7b024fmr202039245ad.2.1786059444816; Thu, 06 Aug 2026 16:37:24 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:06 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-50-seanjc@google.com> Subject: [PATCH v6 49/51] x86/kvmclock: Plumb in AP-online and BSP-resume to kvmlock, for documentation From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1786059447-50AD8B50-855BEA99/0/0 X-purgate-type: clean X-purgate-size: 4589 Invoke kvmclock_cpu_action() with AP_ONLINE and BSP_RESUME, even though kvmclock doesn't need to do anything in either case, so that the asymmetry of kvmclock is a detail buried in kvmclock, and to explicitly document that doing nothing during those phases is intentional and correct. For all intents and purposes, no functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_para.h | 2 ++ arch/x86/kernel/kvm.c | 22 +++++++++++++------- arch/x86/kernel/kvmclock.c | 37 ++++++++++++++++++++++++++------- 3 files changed, 45 insertions(+), 16 deletions(-) diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h index 08686ff19caa..763ed017738a 100644 --- a/arch/x86/include/asm/kvm_para.h +++ b/arch/x86/include/asm/kvm_para.h @@ -120,6 +120,8 @@ static inline long kvm_sev_hypercall3(unsigned int nr, unsigned long p1, #ifdef CONFIG_KVM_GUEST enum kvm_guest_cpu_action { KVM_GUEST_BSP_SUSPEND, + KVM_GUEST_BSP_RESUME, + KVM_GUEST_AP_ONLINE, KVM_GUEST_AP_OFFLINE, KVM_GUEST_SHUTDOWN, }; diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 9c0b2fc98cc9..b954238b09fc 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -474,18 +474,24 @@ static void kvm_guest_cpu_offline(enum kvm_guest_cpu_action action) kvmclock_cpu_action(action); } +static void __kvm_cpu_online(unsigned int cpu, enum kvm_guest_cpu_action action) +{ + unsigned long flags; + + local_irq_save(flags); + kvmclock_cpu_action(action); + kvm_guest_cpu_init(); + local_irq_restore(flags); +} + +#ifdef CONFIG_SMP + static int kvm_cpu_online(unsigned int cpu) { - unsigned long flags; - - local_irq_save(flags); - kvm_guest_cpu_init(); - local_irq_restore(flags); + __kvm_cpu_online(cpu, KVM_GUEST_AP_ONLINE); return 0; } -#ifdef CONFIG_SMP - static DEFINE_PER_CPU(cpumask_var_t, __pv_cpu_mask); static bool pv_tlb_flush_supported(void) @@ -752,7 +758,7 @@ static int kvm_suspend(void *data) static void kvm_resume(void *data) { - kvm_cpu_online(raw_smp_processor_id()); + __kvm_cpu_online(raw_smp_processor_id(), KVM_GUEST_BSP_RESUME); #ifdef CONFIG_ARCH_CPUIDLE_HALTPOLL if (kvm_para_has_feature(KVM_FEATURE_POLL_CONTROL) && has_guest_poll) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index bc98ebb8587d..842f38c5f6ca 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -150,7 +150,7 @@ static void kvm_save_sched_clock_state(void) #ifdef CONFIG_SMP static void kvm_setup_secondary_clock(void) { - kvm_register_clock("secondary cpu clock"); + kvm_register_clock("secondary cpu, startup"); } #endif @@ -174,13 +174,34 @@ static void kvmclock_resume(struct clocksource *cs) void kvmclock_cpu_action(enum kvm_guest_cpu_action action) { - /* - * Don't disable kvmclock on the BSP during suspend. If kvmclock is - * being used for sched_clock, then it needs to be kept alive until the - * last minute, and restored as quickly as possible after resume. - */ - if (action != KVM_GUEST_BSP_SUSPEND) + switch (action) { + /* + * The BSP's clock is managed via clocksource suspend/resume, + * to ensure it's enabled/disabled when timekeeping needs it + * to be, e.g. before reading wallclock (which uses kvmclock). + */ + case KVM_GUEST_BSP_SUSPEND: + case KVM_GUEST_BSP_RESUME: + break; + case KVM_GUEST_AP_ONLINE: + /* + * Secondary CPUs use a dedicated hook to enable kvmclock early + * during bringup, there's nothing to be done during CPU online + * (which runs at CPUHP_AP_ONLINE_DYN). When kvmclock is being + * used as sched_clock, kvmclock must be enabled *very* early, + * and even when kvmclock is "only" being used for the main + * clocksource, it still needs to be enabled long before the + * dynamic CPUHP calls are made. + */ + break; + case KVM_GUEST_AP_OFFLINE: + case KVM_GUEST_SHUTDOWN: kvmclock_disable(); + break; + default: + WARN_ON_ONCE(1); + break; + } } /* @@ -382,7 +403,7 @@ void __init kvmclock_init(bool prefer_tsc) msr_kvm_system_time, msr_kvm_wall_clock); this_cpu_write(hv_clock_per_cpu, &hv_clock_boot[0]); - kvm_register_clock("primary cpu clock"); + kvm_register_clock("primary cpu, online"); pvclock_set_pvti_cpu0_va(hv_clock_boot); if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT)) { -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385503.1628016 (Exim 4.92) (envelope-from ) id 1ws7iN-0000wk-FK; Thu, 06 Aug 2026 23:41:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385503.1628016; Thu, 06 Aug 2026 23:41:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iN-0000vE-8F; Thu, 06 Aug 2026 23:41:31 +0000 Received: by outflank-mailman (input) for mailman id 1385503; Thu, 06 Aug 2026 23:41:30 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3txp1agYKCRwK62FB48GG8D6.4GEP6F-56N6DDAKLK.P6FHJGB64L.GJ8@flex--seanjc.bounces.google.com>) id 1ws7iM-0000k9-Er for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iL-00EM9p-Ra for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:29 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3txp1agYKCRwK62FB48GG8D6.4GEP6F-56N6DDAKLK.P6FHJGB64L.GJ8@flex--seanjc.bounces.google.com>) id 6a751b7a-bab6-0a2a0a5309dd-0a2a4504bd98-24 for ; Fri, 07 Aug 2026 01:41:29 +0200 Received: from [209.85.215.200] (helo=mail-pg1-f200.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3txp1agYKCRwK62FB48GG8D6.4GEP6F-56N6DDAKLK.P6FHJGB64L.GJ8@flex--seanjc.bounces.google.com>) id 6a751ab8-b57f-0a2a45040019-d155d7c8b14a-3 for ; Fri, 07 Aug 2026 01:37:29 +0200 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-ca8aee88725so3901087a12.3 for ; Thu, 06 Aug 2026 16:37:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059447; x=1786664247; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=WG6tzs8/D5vUVAMD7J6BXfy7SNaM+XPXtfc+RTelhM8=; b=uilflh9oNcI4wX1XQh3mgOAdnBE24/Vkfwf1yWU7PcpqnqFe/kuZbMpRi1pLfb2KZ0 VZ/LwfvIbGr73tCz8kC9XDoP4N0aL7L1e/lfHrCAK/sJ/CNF/ejoaiHDbv14ZZmsR+Qi 0akxKxKPHK6tNL4fzdTwl7wdvSb2PahL+HPR6675LOh+Geqya/hbBQjlJqwcGq/ZvXKW NxCY6munzfMmtwwiEu714ucw9sj+5PcGW+jlA/GefI5t1B62/7jQhRcfu4ZhJvrM4fIq nuyrXU/spECm3FpJo4AkqFiS14fSP+4ADS3yoBCQm4ap8b0lGKt3Kb6Xc4puF3yeATII z3pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059447; x=1786664247; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WG6tzs8/D5vUVAMD7J6BXfy7SNaM+XPXtfc+RTelhM8=; b=fUOnWZXl9RGTuQtHKDL3QLa22mkfWAuhmYhlgtxAn4vFoiTWSFtkqX4foOxS1zR1Kd OwDB52Uxa7q3U8MSVDCkEWc0yv66xLTOmnHp3z3kiKhAw4mplXp5tQMM4EiqN/mNxe2u wj0+eELNirKDqfTp73vaUa5pNOPvHMFHPLHuCDi1zYllBUBw9t73kXR5lrKA8bXCnBiF 3GvdG8ysiSgT+BPZTQw+aU7e/kUs3C3fTOznQKyUEf7hl4j9JSgBphAbKjuXyWxUUt1K igJpmnoPs6njjS0DGV/WLbxbb0YueZhGpH/wwntUfT4SGd/TZCnXzjnGjdv9TkcBTtfl GkpQ== X-Forwarded-Encrypted: i=1; AHgh+Rqpu1q9OfFdUa8n/Gtrq3JOWx3bUVKLY5vx1YjDRDZ/2wA7HJzHNWg2u9HHrRMSKyJt/CEnEJEspdI=@lists.xenproject.org X-Gm-Message-State: AOJu0YyhT79nc8LkzpxtycXFq4cT+jFMNHCgivAamPwH57Hkmnw0w5kT RzMB3Sdun9HXl21ZVO8Kz7oTPQ//0lq0ZFUVr7iBNvhBKgIsm6Oe47ehehSOOfRtvv2pO8VkwaL 4QWXmlw== X-Received: from pjgg14.prod.google.com ([2002:a17:90b:57ce:b0:380:f969:825e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2590:b0:38f:2168:b9cb with SMTP id 98e67ed59e1d1-3903c572a05mr18788898a91.9.1786059447175; Thu, 06 Aug 2026 16:37:27 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:36:08 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-52-seanjc@google.com> Subject: [PATCH v6 51/51] x86/kvm: Get local APIC bus frequency from PV CPUID Timing Info From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1786059449-C24CBB50-6CCD359A/13/0 X-purgate-type: clean X-purgate-size: 1406 When running as a KVM guest with PV timing info provided by the host, stuff the APIC timer period/frequency with the local APIC bus frequency reported in CPUID.0x40000010.EBX instead of trying to calibrate/guess the frequency. See Documentation/virt/kvm/x86/cpuid.rst for details. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index b954238b09fc..edeff41c03c2 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -992,7 +992,7 @@ static void __init kvm_init_platform(void) .mask_lo = (u32)(~(SZ_4G - tolud - 1)) | MTRR_PHYSMASK_V, .mask_hi = (BIT_ULL(boot_cpu_data.x86_phys_bits) - 1) >> 32, }; - u32 timing_info_leaf; + u32 timing_info_leaf, apic_khz; bool tsc_is_reliable; if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) && @@ -1054,6 +1054,11 @@ static void __init kvm_init_platform(void) x86_init.hyper.get_tsc_khz = kvm_get_tsc_khz; x86_init.hyper.get_cpu_khz = kvm_get_tsc_khz; } + + /* The leaf also includes the local APIC bus/timer frequency.*/ + apic_khz = cpuid_ebx(timing_info_leaf); + if (apic_khz) + apic_set_timer_frequency_khz(apic_khz, "KVM hypervisor"); } /* -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385528.1628034 (Exim 4.92) (envelope-from ) id 1ws7id-0002Ot-39; Thu, 06 Aug 2026 23:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385528.1628034; Thu, 06 Aug 2026 23:41:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7ic-0002Nb-TD; Thu, 06 Aug 2026 23:41:46 +0000 Received: by outflank-mailman (input) for mailman id 1385528; Thu, 06 Aug 2026 23:41:45 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3iBp1agYKCesfRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 1ws7ia-00021x-V2 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7ia-00EMEo-Bf for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:44 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3iBp1agYKCesfRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 6a751b7b-e002-0a2a0a5209dd-0a2a4507ba7e-24 for ; Fri, 07 Aug 2026 01:41:44 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3iBp1agYKCesfRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 6a751a89-b4ea-0a2a45070019-d155d2c6c536-3 for ; Fri, 07 Aug 2026 01:36:43 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84f0d3ab2f4so2320951b3a.1 for ; Thu, 06 Aug 2026 16:36:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059401; x=1786664201; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=xHY7WhZzoR4x+WtFqsSoEfBU4PaM9Rhz3R83jbux6ZU=; b=l3AxvYlcIv5t4p50ACKgOr8BmfXFznkGjO5XzZmRCFmzcGJq3TSAPfjGHop+KsftGV kTKG6IdfHqwUDcy4EJyLFd98+3NdcqEnL+9scHbYGCu15m6NQQ6GdVabg5T0chaQKLuN i/Q6tU/MJuYI1DTZPYUqlyqZxHkqhmj/qmrPrkNbxaMCt1gEQmrf36QGq8PKMoIWEtG1 Ke1BAcIkU93DqZFd7UPXpEaPccAk1xpK5fBr06eGQU4yTR47oT6W7uZCnIZljhUTMlhv 9bFy3PlZXzyKnUYVY+McaJqB+KkSnz+P7Z0HwZ3XxgAOqGU4Ib0MNzM2FicFnijUzbVx TykA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059401; x=1786664201; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xHY7WhZzoR4x+WtFqsSoEfBU4PaM9Rhz3R83jbux6ZU=; b=TcgjIMVicxErgAmMoOcd3icYrz/FER5Hi5DAmOHGPieLjVRf72NZdsqCweDz4PVbim GNCQz/bJhio2c0fsXdPJuUKH48/KE91Os80s6p93I1/uemsDnW4UmzrWxZTkQWvgQHVG EAqa/sqstbxZW4cFT2IurULTAMQZ5cynCqoInAnKh+hRxv9DpC2o2ZFCJtz51bPJhXs/ U+aZ+YaEIwnMEzZVBfFrTH0GEUIMk99PB3WPOQ4SK4l+iSliq20BKFbUvwad/90NcUHd 1L0hYFBRTf+c65HFP3KYM9Dk+/1ABsDQUUew09lNgc7VKjR9/2BonBGxIv2/sE/iWoPd kt/g== X-Forwarded-Encrypted: i=1; AHgh+RqaWv1QSgaOPxyuzXfUuA1V91XGUinzCJKMZOI6M6V4Wvs/rDJtFL7eWEpdgXoOC21dGMFlY0gz00A=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx3RhHNuXPlQdI6Sl8ypKy6H/RkexgUAiPqhIBW9R9Ecsm0JvCY 9nsseWsu+rQL5hIFW+RWrbUpjS4yDts9Z+zrNNYNJeZqy0KIMdSm9/wEbj0fSigb4uSGywcdpqQ aBoBkdg== X-Received: from pfbbu11.prod.google.com ([2002:a05:6a00:410b:b0:848:8b16:23d6]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2383:b0:842:5b66:3c7f with SMTP id d2e1a72fcca58-84f2dedf356mr20263411b3a.0.1786059400868; Thu, 06 Aug 2026 16:36:40 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:31 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-15-seanjc@google.com> Subject: [PATCH v6 14/51] x86/tsc: Consolidate forcing of X86_FEATURE_TSC_KNOWN_FREQ for PV code From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1786059403-A50CDAE4-3B769141/0/0 X-purgate-type: clean X-purgate-size: 5920 Now that all paravirt code that explicitly specifies the TSC frequency also sets X86_FEATURE_TSC_KNOWN_FREQ, replace all of the one-off code and simply set X86_FEATURE_TSC_KNOWN_FREQ if the TSC frequency is known. Do NOT force set TSC_KNOWN_FREQ if the "known" TSC frequency was provided by the user. Per commit bd35c77e32e4 ("x86/tsc: Add tsc_early_khz command line parameter"), one of the goals of the param is to allow the refined calibration work "to do meaningful error checking". No functional change intended. Reviewed-by: Michael Kelley Signed-off-by: Sean Christopherson --- arch/x86/coco/sev/core.c | 1 - arch/x86/coco/tdx/tdx.c | 1 - arch/x86/kernel/cpu/acrn.c | 1 - arch/x86/kernel/cpu/mshyperv.c | 1 - arch/x86/kernel/cpu/vmware.c | 2 -- arch/x86/kernel/jailhouse.c | 1 - arch/x86/kernel/kvmclock.c | 1 - arch/x86/kernel/tsc.c | 13 ++++++++++--- arch/x86/xen/time.c | 1 - 9 files changed, 10 insertions(+), 12 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index bc5ae9ef74da..72313b36b6f5 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2027,7 +2027,6 @@ unsigned int __init snp_secure_tsc_init(void) secrets = (__force struct snp_secrets_page *)mem; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); rdmsrq(MSR_AMD64_GUEST_TSC_FREQ, tsc_freq_mhz); diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c index ec28a15e26ac..21a574e60e0f 100644 --- a/arch/x86/coco/tdx/tdx.c +++ b/arch/x86/coco/tdx/tdx.c @@ -1203,7 +1203,6 @@ unsigned int __init tdx_tsc_init(void) /* TSC is the only reliable clock in TDX guest */ setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return info.crystal_khz * info.numerator / info.denominator; } diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index 3818f6ae0629..dc71a6fdd461 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -40,7 +40,6 @@ static void __init acrn_init_platform(void) if (acrn_tsc_khz_cpuid) { x86_init.hyper.get_tsc_khz = acrn_get_tsc_khz; x86_init.hyper.get_cpu_khz = acrn_get_tsc_khz; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } } diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 4a0cdda0c49e..3bca987e05c3 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -575,7 +575,6 @@ static void __init ms_hyperv_init_platform(void) ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABLE) { x86_init.hyper.get_tsc_khz = hv_get_tsc_khz; x86_init.hyper.get_cpu_khz = hv_get_tsc_khz; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } if (ms_hyperv.priv_high & HV_ISOLATION) { diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 3f1dab69d90e..cbe8b59ab79f 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -390,8 +390,6 @@ static void __init vmware_set_capabilities(void) { setup_force_cpu_cap(X86_FEATURE_CONSTANT_TSC); setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); - if (vmware_tsc_khz) - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); if (vmware_hypercall_mode == CPUID_VMWARE_FEATURES_ECX_VMCALL) setup_force_cpu_cap(X86_FEATURE_VMCALL); else if (vmware_hypercall_mode == CPUID_VMWARE_FEATURES_ECX_VMMCALL) diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c index 595cd28f9a9f..8107c28eb2bc 100644 --- a/arch/x86/kernel/jailhouse.c +++ b/arch/x86/kernel/jailhouse.c @@ -255,7 +255,6 @@ static void __init jailhouse_init_platform(void) pr_debug("Jailhouse: PM-Timer IO Port: %#x\n", pmtmr_ioport); precalibrated_tsc_khz = setup_data.v1.tsc_khz; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); pci_probe = 0; diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 4f8299303a19..35a879d33e9e 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -138,7 +138,6 @@ static inline void kvm_sched_clock_init(bool stable) */ static unsigned int __init kvm_get_tsc_khz(void) { - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return pvclock_tsc_khz(this_cpu_pvti()); } diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 7f1ca6df0004..f42872c9ae99 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -1541,11 +1541,18 @@ void __init tsc_early_init(void) if (!known_tsc_khz && x86_init.hyper.get_tsc_khz) known_tsc_khz = x86_init.hyper.get_tsc_khz(); + /* + * Mark the TSC frequency as known if it was obtained from a hypervisor + * or trusted firmware. + */ + if (known_tsc_khz) + setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); + /* * Ignore the user-provided TSC frequency if the exact frequency was - * obtained from trusted firmware or the hypervisor, as the user- - * provided frequency is intended as a "starting point", not a known, - * guaranteed frequency. + * obtained from trusted firmware or the hypervisor, and don't mark the + * frequency as known, as the user-provided frequency is intended as a + * "starting point", not a known, guaranteed frequency */ if (!known_tsc_khz) known_tsc_khz = tsc_early_khz; diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 1adb44fdddb2..487ad838c441 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -43,7 +43,6 @@ static unsigned int __init xen_tsc_khz(void) struct pvclock_vcpu_time_info *info = &HYPERVISOR_shared_info->vcpu_info[0].time; - setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); return pvclock_tsc_khz(info); } -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385522.1628026 (Exim 4.92) (envelope-from ) id 1ws7ia-00021T-QN; Thu, 06 Aug 2026 23:41:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385522.1628026; Thu, 06 Aug 2026 23:41:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7ia-000206-Jg; Thu, 06 Aug 2026 23:41:44 +0000 Received: by outflank-mailman (input) for mailman id 1385522; Thu, 06 Aug 2026 23:41:43 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3hxp1agYKCeoeQMZVOSaaSXQ.OaYjQZ-PQhQXXUefe.jQZbdaVQOf.adS@flex--seanjc.bounces.google.com>) id 1ws7iZ-0001u2-8S for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iY-00H1om-LX for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:42 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3hxp1agYKCeoeQMZVOSaaSXQ.OaYjQZ-PQhQXXUefe.jQZbdaVQOf.adS@flex--seanjc.bounces.google.com>) id 6a751b81-5cb7-0a2a0a5109dd-0a2a450b92be-16 for ; Fri, 07 Aug 2026 01:41:42 +0200 Received: from [209.85.210.200] (helo=mail-pf1-f200.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3hxp1agYKCeoeQMZVOSaaSXQ.OaYjQZ-PQhQXXUefe.jQZbdaVQOf.adS@flex--seanjc.bounces.google.com>) id 6a751a88-b7e8-0a2a450b0019-d155d2c8a497-3 for ; Fri, 07 Aug 2026 01:36:41 +0200 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-848474825ffso2105024b3a.0 for ; Thu, 06 Aug 2026 16:36:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059400; x=1786664200; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=kmrkRlf4iOUyRYugkcn9gxIXBFL0cMozIwMb4/CeDNQ=; b=WxEH38kt8trdGNMyInAbF5tr2ZeIhc6gKC3b0nC1gjlTOkmEGr8zGh6rlHvqOGqo31 SBA2xCvvczxNopG3jCVl6MQ2s1xvFMiETO1XNST+HX7kv4JJrMMpPuDk9mjDjUszAg0q XqQucByNypUdwm4AWh7162V1j4B3CqjkK3fS6n7ihH78jYrSAzjku35tM3kcTKwQwJPl rKYHTcQKZS7W1PHBR9kdM8iFyv82ZZY1OYfTqzNl2x7GaEXQRfJBdsZ04pf13cjHK358 Tf+njsvjKeQyDb01OhVLdZ4DLIFxrX++b3GKWDe4g+/rGscUNxpkGUhcKCusD36VXUKX 5vCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059400; x=1786664200; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kmrkRlf4iOUyRYugkcn9gxIXBFL0cMozIwMb4/CeDNQ=; b=L/dY02vG3ogMwrTh7AeBk7JvtnNlLY+PKS5uYQahdoS5hEeysL+3euuOKPgKVH9e4M SiLTirc7AZbqwC5lLowJXY0Y/355o3jUbOHt6GW8M9n3y3R4HkKyykH0MJujLlhvBsqL wMVpdiHa9OfGxixl2wVRXwbQKwLSIdsTuSMsgKIp8mATPfylXGkpd4pn+zgbb2QTtrio BQ4X7mTZSZ5de8C91PoAevtwncI8Q9briNl9XqvCyd64gxsd5sRZJcyPztqiywJ6kvAx VN2iOz4uLBwNY4R1KrNi+08UIMH3sTuZyIx12tQINs+r5HDyz6JSLshVptTX3D9sUsEb W93Q== X-Forwarded-Encrypted: i=1; AHgh+RoZrF8/hlPQcEmlruUHLlkQN/avZ1P1wBOcw/kr9XggM1GkCaNzEB/NGzDmy3r568/8b7LWHb+758k=@lists.xenproject.org X-Gm-Message-State: AOJu0Yyq97ujbmtdgKd1l4wxcld/rR5bXsY6XkGTxRhTlej4u52MEuRo b1m+zZ10vIOlXtUBcYqf+yA5pWlr27f457fcqwN0+x0kr5Xq4VMDqguO8DphNU/C4juzUgv/IHF 35ubDbQ== X-Received: from pfbcz9.prod.google.com ([2002:aa7:9309:0:b0:847:aa6c:47fc]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4648:b0:842:63f5:d097 with SMTP id d2e1a72fcca58-84f41ba51c5mr11209793b3a.3.1786059399712; Thu, 06 Aug 2026 16:36:39 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:30 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-14-seanjc@google.com> Subject: [PATCH v6 13/51] x86/acrn: Mark TSC frequency as known when using ACRN for calibration From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-42698a/1786059402-A9EC69EA-8845AC6D/0/0 X-purgate-type: clean X-purgate-size: 812 Mark the TSC frequency as known when using ACRN's PV CPUID information. Per commit 81a71f51b89e ("x86/acrn: Set up timekeeping") and common sense, the TSC freq is explicitly provided by the hypervisor. Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/acrn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index dc71a6fdd461..3818f6ae0629 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -40,6 +40,7 @@ static void __init acrn_init_platform(void) if (acrn_tsc_khz_cpuid) { x86_init.hyper.get_tsc_khz = acrn_get_tsc_khz; x86_init.hyper.get_cpu_khz = acrn_get_tsc_khz; + setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ); } } -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385540.1628043 (Exim 4.92) (envelope-from ) id 1ws7ij-00034B-Ef; Thu, 06 Aug 2026 23:41:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385540.1628043; Thu, 06 Aug 2026 23:41:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7ij-00033Z-AH; Thu, 06 Aug 2026 23:41:53 +0000 Received: by outflank-mailman (input) for mailman id 1385540; Thu, 06 Aug 2026 23:41:51 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3kBp1agYKCfMnZVieXbjjbgZ.XjhsZi-YZqZggdnon.sZikmjeZXo.jmb@flex--seanjc.bounces.google.com>) id 1ws7ih-0002wK-CD for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7ig-008OCw-PP for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:50 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3kBp1agYKCfMnZVieXbjjbgZ.XjhsZi-YZqZggdnon.sZikmjeZXo.jmb@flex--seanjc.bounces.google.com>) id 6a751ba5-2eae-0a2a0a5409dd-0a2a450a9b14-16 for ; Fri, 07 Aug 2026 01:41:50 +0200 Received: from [209.85.210.200] (helo=mail-pf1-f200.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3kBp1agYKCfMnZVieXbjjbgZ.XjhsZi-YZqZggdnon.sZikmjeZXo.jmb@flex--seanjc.bounces.google.com>) id 6a751a91-f2d2-0a2a450a0019-d155d2c8c457-3 for ; Fri, 07 Aug 2026 01:36:50 +0200 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84865f326efso3250044b3a.0 for ; Thu, 06 Aug 2026 16:36:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059408; x=1786664208; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=kOFXKheX158XT5RdBZeZqj6PvfchU0LO18FYNMDj3A4=; b=gZd/+F2G6OlP23WLTRA/RMd/lhy3+ox1hcLkW1lN8p3NWHRGsyEGnNR7cJ2tNbcGAW smdZvOvZbOxcj7Dl78ycJqVVFfuNN0pHVSuTBwzPY60W6Q0tVmv3cybbHdNlILWHu9f4 xQrRrPO0jkMS1lni94cmMF3g5N5YNUZtWnlqElhYF3QDnEFXI0ypEZNBsCbXiTss9Uej mkXrOkeRvGHGBorhyLzfHCabWi8KxMFcyrhN7RKOihlGcNagtcph4GbHt8rw6oZKFK0Q rwrmFQKk0EY0P/rn/uNEBZ9XyA8xizoybwL9M1qj36SO58cEAdRmp+aM6hnFIkU0qjqH G0Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059408; x=1786664208; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kOFXKheX158XT5RdBZeZqj6PvfchU0LO18FYNMDj3A4=; b=jVHNP4Ii/DJCdBU95UK0GsredK2+WXi2uIP9MjpESoXwms36MNAo4Lv0RHOp7ecIAe rMofFMMeUKJwvfnrsPiX2vuNkMdmR1M64Q1Y+NNnBy7rEYVqw44+QXZ3q4zouswzzr0j AB1EdcgHtSwBYM+HiOVTu5ZWCcPJHVd3QvJBPg1o8XpU8LxUpFEK8uY2ZpizJnZ6pSDW gCF6Vqs4Ya5ABmfjXpSYxG6s6tYEZ12vydBIQqcZXS+qUXDHLYgyfBITeIUVWZgapP+p Ls0EpNtlCc6aDzDJRy3lWAHXDWNL2LPb6vR2FItclurtD1QjfJR1HYMilKdLfWqtv72W i0fw== X-Forwarded-Encrypted: i=1; AHgh+RphbPeKrUD7Yiy+oLFMgXFDi1Z/xceIYBTVWBz6PAyrHSHYxStaNf+BrSeTTXgXfwgZiNKyi3B9iOs=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz0AUbxenQEKwk73e+skrhVfUbPhFlxiJn2TPuOcBx43Yy40tLc /eF73gVJ4IzXFJlEqvedysWBf3hT9CwiEzNJspyuZ3YI7qJVI5PBJipvIZ4gyU+s4nava/LqTT+ mSEx4UQ== X-Received: from pgay6.prod.google.com ([2002:a05:6a02:4966:b0:cbb:8616:5536]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3d4f:b0:847:9188:e492 with SMTP id d2e1a72fcca58-84f2e04d173mr18898130b3a.22.1786059408172; Thu, 06 Aug 2026 16:36:48 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:36 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-20-seanjc@google.com> Subject: [PATCH v6 19/51] x86/kvmclock: Drop dead check on TSC being unstable during kvmclock_init() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059410-53CD3CFC-F03526C2/0/0 X-purgate-type: clean X-purgate-size: 1729 As pointed out by Sashiko[*], kvmclock_init() runs before __setup() and thus before notsc_setup() or tsc_setup() can mark the TSC unstable. kvmclock_init() also runs well before tsc_init(), and even before tsc_early_init(). Simply delete the check, as it's been dead code since it was introduced. Note, odds are good the check_tsc_unstable() call was copied from Xen's xen_time_init()+xen_tsc_safe_clocksource() logic (as so much of KVM's PV code was). However, xen_time_init() runs via x86_init.timers.timer_init(), which is invoke from x86_late_time_init(), and thus after params have been parsed. Alternatively, kvmclock could register itself later on, or tsc_setup() could be parsed as an early param. Given that there's zero evidence there was any meaningful intent or need to actually check for an unstable TSC, go with the simplest option. Fixes: 7539b174aef4 ("x86: kvmguest: use TSC clocksource if invariant TSC is exposed") Link: https://lore.kernel.org/all/20260529181213.0B27A1F00893@smtp.kernel.org [*] Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 061a22d31dea..29ca37e9a3bc 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -362,8 +362,7 @@ void __init kvmclock_init(void) * */ if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC) && - boot_cpu_has(X86_FEATURE_NONSTOP_TSC) && - !check_tsc_unstable()) + boot_cpu_has(X86_FEATURE_NONSTOP_TSC)) kvm_clock.rating = 299; clocksource_register_hz(&kvm_clock, NSEC_PER_SEC); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:57 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385550.1628052 (Exim 4.92) (envelope-from ) id 1ws7im-0003W6-Tc; Thu, 06 Aug 2026 23:41:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385550.1628052; Thu, 06 Aug 2026 23:41:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7im-0003Vt-Pp; Thu, 06 Aug 2026 23:41:56 +0000 Received: by outflank-mailman (input) for mailman id 1385550; Thu, 06 Aug 2026 23:41:55 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3kxp1agYKCfYqcYlhaemmejc.amkvcl-bctcjjgqrq.vclnpmhcar.mpe@flex--seanjc.bounces.google.com>) id 1ws7il-0003Oy-1v for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:55 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7ik-00H1om-Eo for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:54 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3kxp1agYKCfYqcYlhaemmejc.amkvcl-bctcjjgqrq.vclnpmhcar.mpe@flex--seanjc.bounces.google.com>) id 6a751b81-5cb7-0a2a0a5109dd-0a2a450b92be-26 for ; Fri, 07 Aug 2026 01:41:54 +0200 Received: from [209.85.214.199] (helo=mail-pl1-f199.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3kxp1agYKCfYqcYlhaemmejc.amkvcl-bctcjjgqrq.vclnpmhcar.mpe@flex--seanjc.bounces.google.com>) id 6a751a94-b7e8-0a2a450b0019-d155d6c7d513-3 for ; Fri, 07 Aug 2026 01:36:53 +0200 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cca5e0a0c9so47575325ad.1 for ; Thu, 06 Aug 2026 16:36:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059412; x=1786664212; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=9lHEbI53WDwynue0wsp+pOzdIE1KL/OlJm0qjHY+exI=; b=SFr28XEaSt6UgjRIJoKY55daRUKXCrTvedZjMBPb5ELN8tdLyF99ykPorQrN4PunXf lWb2SctUmfzZtPhw9pc74mHAMbS+onyvOdtY2igX8QeGYCfJ2BBGGQzzRf794R2DFC1Q XuKDyH0s2G3U+VTY4iLvydW6/QwOJCMLx2SMjB/DBceU1Irc3hJSwhsJil5iGRiLA8v0 oegUVkoJpLQi6PSwOsPcR14PANswABwTYkTEErJ+fh+nVu9v0AXpx3Qi/+XVl4u6q3td IAarnfYbq7wSaV15TTAv8u+tAtmmkRk1Pw79v/mH1T8Jm5BncZ2TeJ5FmgzKsF3mzWPL eufQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059412; x=1786664212; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9lHEbI53WDwynue0wsp+pOzdIE1KL/OlJm0qjHY+exI=; b=r5saDU2HOuzbTPEpvpc3D4FlpoLURxL6U3GuReQ5V+R/as/05fe2IwBB5Zi/oO/JGK aGq2osKChExJ85V0NKCON74DRJtZQE4AqZGVNmnW3PoU4kdN5hEc4Z/5AqmYk5slFaa4 i2UERrr9VmXXIvmtu5oZeDgKvyPUEVMClKLxmTKAU8rzSBARW+brK0rWqsOihECH+wNR hzCJmlMim0uYrVvc4xWQ/PGa+dAewbLh2XdAg06SnjlQem+6rZ1i4eQfJf1RbLE0lvzd pz4eBPfZYCZoKrAOOnCn/p9EQBSowxJx0bIlqtT4U/NpLYnEjCTl3yHIjJhjuCR6c9tP Lorg== X-Forwarded-Encrypted: i=1; AHgh+RrKKNzvrFmim61+43g7QgSrA2wU1ZNC4TDLodZd13Usb2XTgh67o24Fx7++b0ABqW7VJSM26/38NnM=@lists.xenproject.org X-Gm-Message-State: AOJu0YxGVtV1I7NJhCACMPe9xa5WkBPLG7Np+54UB0wafDgpQ1aNnTvc aD3OD6AEGpZ2+1uMOGFwA2T97HoTBcVqNgZ8vHnYs3vm4T6J2fSWPu2179/PHqFKrk+wSmtTIg8 5PFL64Q== X-Received: from plpn24.prod.google.com ([2002:a17:902:9698:b0:2cc:ae2b:c324]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3d0d:b0:2d0:4021:bb6b with SMTP id d9443c01a7336-2d0ca15c87amr222771235ad.0.1786059411603; Thu, 06 Aug 2026 16:36:51 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:39 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-23-seanjc@google.com> Subject: [PATCH v6 22/51] x86/kvm: Mark TSC as reliable when it's constant and nonstop From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-42698a/1786059413-194C39EA-07710684/0/0 X-purgate-type: clean X-purgate-size: 3764 Mark the TSC as reliable if the hypervisor (KVM) has enumerated the TSC as constant and nonstop. Like most (all?) virtualization setups, any secondary clocksource that's used as a watchdog is guaranteed to be less reliable than a constant, nonstop TSC, as all clocksources the kernel uses as a watchdog are all but guaranteed to be emulated when running as a KVM guest. I.e. any observed discrepancies between the TSC and watchdog will be due to jitter in the watchdog. This is especially true for KVM, as the watchdog clocksource is usually emulated in host userspace, i.e. reading the clock incurs a roundtrip cost of thousands of cycles. Marking the TSC reliable addresses a flaw where the TSC will occasionally be marked unstable if the host is under moderate/heavy load. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_para.h | 2 +- arch/x86/kernel/kvm.c | 12 +++++++++++- arch/x86/kernel/kvmclock.c | 14 +++++--------- 3 files changed, 17 insertions(+), 11 deletions(-) diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h index 4a47c16e2df8..4a49fc286b4c 100644 --- a/arch/x86/include/asm/kvm_para.h +++ b/arch/x86/include/asm/kvm_para.h @@ -118,7 +118,7 @@ static inline long kvm_sev_hypercall3(unsigned int nr, unsigned long p1, } #ifdef CONFIG_KVM_GUEST -void kvmclock_init(void); +void kvmclock_init(bool prefer_tsc); void kvmclock_disable(void); bool kvm_para_available(void); unsigned int kvm_arch_para_features(void); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 8ed02f4f5775..255a24a99f28 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -980,6 +980,7 @@ static void __init kvm_init_platform(void) .mask_hi = (BIT_ULL(boot_cpu_data.x86_phys_bits) - 1) >> 32, }; u32 timing_info_leaf; + bool tsc_is_reliable; if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) && kvm_para_has_feature(KVM_FEATURE_MIGRATION_CONTROL)) { @@ -1042,7 +1043,16 @@ static void __init kvm_init_platform(void) } } - kvmclock_init(); + /* + * If the TSC counts at a constant frequency across P/T states and in + * deep C-states, treat the TSC reliable, as guaranteed by KVM. + */ + tsc_is_reliable = boot_cpu_has(X86_FEATURE_CONSTANT_TSC) && + boot_cpu_has(X86_FEATURE_NONSTOP_TSC); + if (tsc_is_reliable) + setup_force_cpu_cap(X86_FEATURE_TSC_RELIABLE); + + kvmclock_init(tsc_is_reliable); x86_platform.apic_post_init = kvm_apic_init; /* diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index f55d0305d1f3..2e7ab54cb9dc 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -307,7 +307,7 @@ static int kvmclock_setup_percpu(unsigned int cpu) return p ? 0 : -ENOMEM; } -void __init kvmclock_init(void) +void __init kvmclock_init(bool prefer_tsc) { u8 flags; @@ -356,15 +356,11 @@ void __init kvmclock_init(void) kvm_get_preset_lpj(); /* - * X86_FEATURE_NONSTOP_TSC is TSC runs at constant rate - * with P/T states and does not stop in deep C-states. - * - * Invariant TSC exposed by host means kvmclock is not necessary: - * can use TSC as clocksource. - * + * If TSC is preferred over kvmlock, drop kvmclock's rating so that TSC + * is chosen as the clocksource (but still register kvmclock in case + * the kernel doesn't want to use TSC for whatever reason). */ - if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC) && - boot_cpu_has(X86_FEATURE_NONSTOP_TSC)) + if (prefer_tsc) kvm_clock.rating = 299; clocksource_register_hz(&kvm_clock, NSEC_PER_SEC); -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:41:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:41:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385555.1628061 (Exim 4.92) (envelope-from ) id 1ws7io-0003mb-6D; Thu, 06 Aug 2026 23:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385555.1628061; Thu, 06 Aug 2026 23:41:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7io-0003lx-20; Thu, 06 Aug 2026 23:41:58 +0000 Received: by outflank-mailman (input) for mailman id 1385555; Thu, 06 Aug 2026 23:41:56 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3lBp1agYKCfcrdZmibfnnfkd.bnlwdm-cdudkkhrsr.wdmoqnidbs.nqf@flex--seanjc.bounces.google.com>) id 1ws7im-0003Uh-Ay for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7il-00EMEo-OJ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:55 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3lBp1agYKCfcrdZmibfnnfkd.bnlwdm-cdudkkhrsr.wdmoqnidbs.nqf@flex--seanjc.bounces.google.com>) id 6a751b45-e002-0a2a0a5209dd-0a2a450cbd60-46 for ; Fri, 07 Aug 2026 01:41:55 +0200 Received: from [209.85.215.198] (helo=mail-pg1-f198.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3lBp1agYKCfcrdZmibfnnfkd.bnlwdm-cdudkkhrsr.wdmoqnidbs.nqf@flex--seanjc.bounces.google.com>) id 6a751a95-f479-0a2a450c0019-d155d7c6eddc-3 for ; Fri, 07 Aug 2026 01:36:55 +0200 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c88cfe287e1so2212099a12.1 for ; Thu, 06 Aug 2026 16:36:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059413; x=1786664213; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=gK3sjM001OyHimEt3r9e3MTxT5BkhagjBxMzBV7doNU=; b=fciNCWp1Dx0DOh61gLXEdpIpN6AoB9zvLad0YYA5tHxBbineEnVN1fMpe64CvhZPic z2br75Z1ZwItMC9hAmcvldKj5N0yQ2ymv5JC2RIYRyK6tlT1goIAOkWpNV+WdaBnGaJc H2Q3cL3DrIydLaM9C2lgcB7eJLRkHVj0z76IX7dC8bEixLgpVR5EeS8EsWWJTTFWfRXc iOikwNMO2IPhRTMkfXP+x7PwOkQdGmKzubSQI/g6aLlwBqFI2RlWLTDz6QSgB4oKMW5o 7DcO9WLrWyktw1k8k/NZ9L8RP9/QnRowzA/WMcQwCmtgE8Shxzre20FW7SSqTs0YkZwf xIBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059413; x=1786664213; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gK3sjM001OyHimEt3r9e3MTxT5BkhagjBxMzBV7doNU=; b=aHodXI43os7+Mhn0RISDOuwukRJ+oHk6hgCjSi3ys7JXa/cLSwy0qK37oHupvQ/ZzB 6LxlcX2k9BtBACkw8rXsc+6kj6dvo2hDr4I7ySrcwyws/9xadxCd+5YGPT02BJ4pzcFU NJH9/w7f2X0kcjMrtDtBlltzYlS4jpWBgUeX8AYUkT8zu023fail7jdVthVSHWuB45Q7 Fod2zO/Md1SP/NgfuWcE2hZuBjx5vgKKtZCSGQwkAh662eW+VYOtsitQUixyRRUozzKp YrULZf1+44vC+jmWZLybAkO4dyQuF+cHnoxo/738BSGbWab33XkN2m8sXn+yNzcG8ppI WGvg== X-Forwarded-Encrypted: i=1; AHgh+RrWcFYKG+bTo8Owytd6b46jCy6Xxg0V/vj0TtJ2072NviIFIcIMouOvzj+kOZuBMunA/0hRwvJX/CQ=@lists.xenproject.org X-Gm-Message-State: AOJu0Yya0zsFzKNL6T95JS6U3gGKfplK/uEenHlSj3Seb4YDP8ZC7hOU l3q6lcQQ12FeodFaJ2qkKr6E8kFtilq4wJIz0gC6XH/4Jruuy5y9vA4waEJ7BdoQXko78EpDqQa dLzqwwA== X-Received: from pglu1.prod.google.com ([2002:a63:1401:0:b0:c99:aff5:7078]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:6da8:b0:3c3:bee9:8eec with SMTP id adf61e73a8af0-3cbadc10910mr5429156637.19.1786059412806; Thu, 06 Aug 2026 16:36:52 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:40 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-24-seanjc@google.com> Subject: [PATCH v6 23/51] x86/tsc: Add standalone helper for getting CPU frequency from CPUID From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d25034/1786059415-01EC2A5B-4D077EA2/0/0 X-purgate-type: clean X-purgate-size: 2814 Extract the guts of cpu_khz_from_cpuid() to a standalone helper that doesn't restrict the usage to Intel CPUs. This will allow sharing the core logic with KVM-as-a-guest, as KVM generally doesn't restrict CPUID based on vendor. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/tsc.h | 1 + arch/x86/kernel/tsc.c | 31 +++++++++++++++---------------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h index c09ec485abcd..cb682f097ea7 100644 --- a/arch/x86/include/asm/tsc.h +++ b/arch/x86/include/asm/tsc.h @@ -88,6 +88,7 @@ struct cpuid_tsc_info { unsigned int crystal_khz; }; extern int cpuid_get_tsc_info(struct cpuid_tsc_info *info); +extern unsigned int __cpu_khz_from_cpuid(void); extern void tsc_early_init(void); extern void tsc_init(void); diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index d95e4f059f17..4c5328d19ebe 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -668,6 +668,18 @@ int cpuid_get_tsc_info(struct cpuid_tsc_info *info) return 0; } +unsigned int __cpu_khz_from_cpuid(void) +{ + unsigned int eax_base_mhz, ebx, ecx, edx; + + if (boot_cpu_data.cpuid_level < CPUID_LEAF_FREQ) + return 0; + + cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx, &ecx, &edx); + + return eax_base_mhz * 1000; +} + /** * native_calibrate_tsc - determine TSC frequency * Determine TSC frequency via CPUID, else return 0. @@ -703,12 +715,8 @@ static unsigned long native_calibrate_tsc(void) * clock, but we can easily calculate it to a high degree of accuracy * by considering the crystal ratio and the CPU speed. */ - if (!info.crystal_khz && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) { - unsigned int eax_base_mhz, ebx, ecx, edx; - - cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx, &ecx, &edx); - info.crystal_khz = eax_base_mhz * 1000 * info.denominator / info.numerator; - } + if (!info.crystal_khz) + info.crystal_khz = __cpu_khz_from_cpuid() * info.denominator / info.numerator; if (!info.crystal_khz) return 0; @@ -733,19 +741,10 @@ static unsigned long native_calibrate_tsc(void) static unsigned long cpu_khz_from_cpuid(void) { - unsigned int eax_base_mhz, ebx_max_mhz, ecx_bus_mhz, edx; - if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) return 0; - if (boot_cpu_data.cpuid_level < CPUID_LEAF_FREQ) - return 0; - - eax_base_mhz = ebx_max_mhz = ecx_bus_mhz = edx = 0; - - cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx_max_mhz, &ecx_bus_mhz, &edx); - - return eax_base_mhz * 1000; + return __cpu_khz_from_cpuid(); } /* -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385558.1628070 (Exim 4.92) (envelope-from ) id 1ws7iq-00044g-Cc; Thu, 06 Aug 2026 23:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385558.1628070; Thu, 06 Aug 2026 23:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iq-00044Q-9B; Thu, 06 Aug 2026 23:42:00 +0000 Received: by outflank-mailman (input) for mailman id 1385558; Thu, 06 Aug 2026 23:41:58 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3lxp1agYKCfougcpleiqqing.eqozgp-fgxgnnkuvu.zgprtqlgev.qti@flex--seanjc.bounces.google.com>) id 1ws7io-0003nQ-Do for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:41:58 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7in-00EMFx-Qw for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:41:57 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3lxp1agYKCfougcpleiqqing.eqozgp-fgxgnnkuvu.zgprtqlgev.qti@flex--seanjc.bounces.google.com>) id 6a751ba5-2eae-0a2a0a5409dd-0a2a450a9b14-18 for ; Fri, 07 Aug 2026 01:41:57 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3lxp1agYKCfougcpleiqqing.eqozgp-fgxgnnkuvu.zgprtqlgev.qti@flex--seanjc.bounces.google.com>) id 6a751a98-f2d2-0a2a450a0019-d155d2c6ed27-3 for ; Fri, 07 Aug 2026 01:36:57 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8484f26852dso3084354b3a.1 for ; Thu, 06 Aug 2026 16:36:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059415; x=1786664215; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=LVVzZOjwmw/JiJ4qXIbPAPAp0QWxfKUo2q2D7ecTrQM=; b=hTF2lT9DqHChkWBoxQa6p7zWaLa7LIZl/5shX6RsHLEQ/zw7GV8qWvbKld/xvU1jrq FAt5i2xJ0s3sJweKxBycUrYGuGcaztCusxD37uJGPLTFNQj7TAK9EbEm4fvwRgd2jHJq TCFcHPGYZwz5xJiSAYk3WK0gCBbOQUlwFYiVPfaq26lAs2c79Vsn4LHaiNhLFDaSx4Q8 E8FHJn+rzf4csVPliwWOfMERPgaXBj+n5guogY2OcxYB7xryoa9mVy4ATcSVLIslVOp2 WqBBSKIWnNvanSHhEGNRmKRiuodKyc79Dh8v4mnwLTfmpG/fawW3a0wpF1/OlIAek3O+ br2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059415; x=1786664215; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LVVzZOjwmw/JiJ4qXIbPAPAp0QWxfKUo2q2D7ecTrQM=; b=V9HhinPOprV4JIMVYhbHor0vSZ6UNuw72zQGdlhXSwfTZReMYSpq+iaQlYIzhKHXRE GOhmcb4Dmt2d1iaiJuhXPU7iTMbPaATsPgnXzk7L8mzCRt/QyYGIUYziTv3e1icnf+hA meUhyvoOZgl/R47ruouLZO7T4YPwPkrWwdINboVT1jLSYNyEE/okSiRuS0zkZxeDlv7o eJSB0uKvUuChJ+5dtG2VMqpRkTRo/pkz1bwf2GSzkPj3+DF/lqkGZPzuH2MHUaz5d7w/ iOzTbgA5uYWLrEBRfDw7+HjDz38fuhrdqZgs/N0HFoy8d6GRj7m4g1KtdbzVIazvZRjb gJIQ== X-Forwarded-Encrypted: i=1; AHgh+RrJDcOXr6lrwKNHWzUnKQr8RBnLctSglnJp7MmyDUXOo9Bw7Qi872Wk6Eiy0tH2W3F0ZgYER2Jv2Rs=@lists.xenproject.org X-Gm-Message-State: AOJu0Yw323y/D4ruGMCDaEUjg3O8Pq7IKkpb2RUtSPeqqC3dB7YpVRdX gOXmz3IWIlMiLfu0ncDns+T4i5HetZDmL7PAlu4NbGPfP5senAJAfYDRHt6gDNBjtf23SQuiBnm LOKhvig== X-Received: from pfcy22.prod.google.com ([2002:a05:6a00:93d6:b0:84b:be30:8d22]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:8019:b0:848:4a48:9f9f with SMTP id d2e1a72fcca58-84f4fee000fmr6402250b3a.34.1786059415266; Thu, 06 Aug 2026 16:36:55 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:42 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-26-seanjc@google.com> Subject: [PATCH v6 25/51] clocksource: hyper-v: Register sched_clock save/restore iff it's necessary From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059417-4ACDBCFC-72ED3FAD/0/0 X-purgate-type: clean X-purgate-size: 6603 Register the Hyper-V reference counter (refcounter) callbacks for saving and restoring its PV sched_clock, if and only if the refcounter is actually being used for sched_clock. Currently, Hyper-V overrides the save/restore hooks if the reference TSC available, whereas the Hyper-V refcounter code only overrides sched_clock if the reference TSC is available *and* it's not invariant. The flaw is effectively papered over by invoking the "old" save/restore callbacks as part of save/restore, but that's unnecessary and fragile. To avoid introducing more complexity, and to allow for additional cleanups of the PV sched_clock code, move the save/restore hooks and logic into hyperv_timer.c and simply wire up the hooks when overriding sched_clock itself. Note, while the Hyper-V refcounter code is intended to be architecture neutral, CONFIG_PARAVIRT is firmly x86-only, i.e. adding a small amount of x86 specific code (which will be reduced in future cleanups) doesn't meaningfully pollute generic code. Reviewed-by: Michael Kelley Tested-by: Michael Kelley Acked-by: Wei Liu Signed-off-by: Sean Christopherson --- arch/x86/kernel/cpu/mshyperv.c | 58 ------------------------------ drivers/clocksource/hyperv_timer.c | 50 ++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 58 deletions(-) diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 3bca987e05c3..d704496d0409 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -275,63 +275,6 @@ static void hv_guest_crash_shutdown(struct pt_regs *regs) } #endif /* CONFIG_CRASH_DUMP */ -static u64 hv_ref_counter_at_suspend; -static void (*old_save_sched_clock_state)(void); -static void (*old_restore_sched_clock_state)(void); - -/* - * Hyper-V clock counter resets during hibernation. Save and restore clock - * offset during suspend/resume, while also considering the time passed - * before suspend. This is to make sure that sched_clock using hv tsc page - * based clocksource, proceeds from where it left off during suspend and - * it shows correct time for the timestamps of kernel messages after resume. - */ -static void save_hv_clock_tsc_state(void) -{ - hv_ref_counter_at_suspend = hv_read_reference_counter(); -} - -static void restore_hv_clock_tsc_state(void) -{ - /* - * Adjust the offsets used by hv tsc clocksource to - * account for the time spent before hibernation. - * adjusted value = reference counter (time) at suspend - * - reference counter (time) now. - */ - hv_adj_sched_clock_offset(hv_ref_counter_at_suspend - hv_read_reference_counter()); -} - -/* - * Functions to override save_sched_clock_state and restore_sched_clock_state - * functions of x86_platform. The Hyper-V clock counter is reset during - * suspend-resume and the offset used to measure time needs to be - * corrected, post resume. - */ -static void hv_save_sched_clock_state(void) -{ - old_save_sched_clock_state(); - save_hv_clock_tsc_state(); -} - -static void hv_restore_sched_clock_state(void) -{ - restore_hv_clock_tsc_state(); - old_restore_sched_clock_state(); -} - -static void __init x86_setup_ops_for_tsc_pg_clock(void) -{ - if (!(ms_hyperv.features & HV_MSR_REFERENCE_TSC_AVAILABLE)) - return; - - old_save_sched_clock_state = x86_platform.save_sched_clock_state; - x86_platform.save_sched_clock_state = hv_save_sched_clock_state; - - old_restore_sched_clock_state = x86_platform.restore_sched_clock_state; - x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; -} - #ifdef CONFIG_X86_64 DEFINE_STATIC_CALL(hv_hypercall, hv_std_hypercall); EXPORT_STATIC_CALL_TRAMP_GPL(hv_hypercall); @@ -736,7 +679,6 @@ static void __init ms_hyperv_init_platform(void) /* Register Hyper-V specific clocksource */ hv_init_clocksource(); - x86_setup_ops_for_tsc_pg_clock(); hv_vtl_init_platform(); #endif /* diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index df567795d175..4293173c3a27 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -554,10 +554,60 @@ static __always_inline void hv_setup_sched_clock(void *sched_clock) #elif defined CONFIG_PARAVIRT #include +static u64 hv_ref_counter_at_suspend; +static void (*old_save_sched_clock_state)(void); +static void (*old_restore_sched_clock_state)(void); + +/* + * Hyper-V clock counter resets during hibernation. Save and restore clock + * offset during suspend/resume, while also considering the time passed + * before suspend. This is to make sure that sched_clock using hv tsc page + * based clocksource, proceeds from where it left off during suspend and + * it shows correct time for the timestamps of kernel messages after resume. + */ +static void save_hv_clock_tsc_state(void) +{ + hv_ref_counter_at_suspend = hv_read_reference_counter(); +} + +static void restore_hv_clock_tsc_state(void) +{ + /* + * Adjust the offsets used by hv tsc clocksource to + * account for the time spent before hibernation. + * adjusted value = reference counter (time) at suspend + * - reference counter (time) now. + */ + hv_adj_sched_clock_offset(hv_ref_counter_at_suspend - hv_read_reference_counter()); +} +/* + * Functions to override save_sched_clock_state and restore_sched_clock_state + * functions of x86_platform. The Hyper-V clock counter is reset during + * suspend-resume and the offset used to measure time needs to be + * corrected, post resume. + */ +static void hv_save_sched_clock_state(void) +{ + old_save_sched_clock_state(); + save_hv_clock_tsc_state(); +} + +static void hv_restore_sched_clock_state(void) +{ + restore_hv_clock_tsc_state(); + old_restore_sched_clock_state(); +} + static __always_inline void hv_setup_sched_clock(void *sched_clock) { /* We're on x86/x64 *and* using PV ops */ paravirt_set_sched_clock(sched_clock); + + old_save_sched_clock_state = x86_platform.save_sched_clock_state; + x86_platform.save_sched_clock_state = hv_save_sched_clock_state; + + old_restore_sched_clock_state = x86_platform.restore_sched_clock_state; + x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; } #else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */ static __always_inline void hv_setup_sched_clock(void *sched_clock) {} -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385561.1628079 (Exim 4.92) (envelope-from ) id 1ws7ir-0004Kt-Rc; Thu, 06 Aug 2026 23:42:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385561.1628079; Thu, 06 Aug 2026 23:42:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7ir-0004KJ-MX; Thu, 06 Aug 2026 23:42:01 +0000 Received: by outflank-mailman (input) for mailman id 1385561; Thu, 06 Aug 2026 23:42:00 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3mRp1agYKCfwwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 1ws7iq-00047c-QD for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iq-00EMFx-6l for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:00 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3mRp1agYKCfwwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a751ba5-2eae-0a2a0a5409dd-0a2a450a9b14-20 for ; Fri, 07 Aug 2026 01:42:00 +0200 Received: from [209.85.215.198] (helo=mail-pg1-f198.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3mRp1agYKCfwwierngksskpi.gsq1ir-hizippmwxw.1irtvsnigx.svk@flex--seanjc.bounces.google.com>) id 6a751a9a-f2d2-0a2a450a0019-d155d7c6c01f-3 for ; Fri, 07 Aug 2026 01:36:59 +0200 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb5ea36f969so2798106a12.2 for ; Thu, 06 Aug 2026 16:36:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059418; x=1786664218; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=heSuqSIgeH92pLRWbhNi7GYX8HqrNShkMIs22IEn4aI=; b=BIIBZnGlGffTWkDS2scCLpiOfDiJwvzTr6PGVhYlq5AWmczdDm77AuAqCHdUnGwYy4 5OyTPcurT16+KqdtBumy4hMZl5SyOOz2Mw8Nc3InEtinjV7pXtBL4+jKFsqmrY8/FOY3 qfpTtHc4jDWhZ5ACkz03AFX842sVVG0PtfgVVIRF9kwnnwfrgtpZuBSyLuR9BMrQvDMF YOG8B3YhzYawkabeweEikBblZRovSFbBBDTdU39Z30qHe2JNCte2+RWThgpBZXcVCtTg 4QpAPX7NksJsSX7SrDmyMkCSLS8VZKtx/gX16eABXyC+cauiq7mVZmuT92OWSN2r4bX6 1M7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059418; x=1786664218; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=heSuqSIgeH92pLRWbhNi7GYX8HqrNShkMIs22IEn4aI=; b=iAWT92RYLqG13YCmWmpW9XhFdiP4+c+9Cn7u1bL6xjcIsrDF/2HHrSYqMH6vkR6P0U wYJzNOQlfBuLcS3kRjnRbcom3O5Mw3px7J6f3TVcDymh4bcTp+WNaCDEutfNuKY2oInX /z1IzssBuy+x5Et5UtD1aIyqLvFzcl2nNhTizJArKSQBZSk8aM75U4/fBr8oCY0ke8/W wo3rIsSdV2M8+/d6FrSsHJlAowvi9GmbKt5nNDsLLKaMktbU8jJUNXxI6+bxUBEw8WG3 BFU6Zw5Y218/WHM/RG4C/EAevYDwB7p5oBWw62tE+2CUgGZR6Y1jRK58T821/ja/ZBZc s4+g== X-Forwarded-Encrypted: i=1; AHgh+RqFGQC/U1F3YCDAg55dZZxzVIhwM//TJfBnQcKfSVifl3VwUbrPPMunizee48H/7Pw8sC4oWv0tqng=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz2Tt27bUjjFV2olajzLngT9jWedYJ8l2zjis5HW0WkQWR9em0Z RIQCevI+FwIEaVON8aRop6W6pRnAGkg/cfwk4yZQx8HRqhicMn+yB/bDrEDHaLG2nVIG4+FQ/zi gCL8aHw== X-Received: from pgmc19.prod.google.com ([2002:a63:1c53:0:b0:c98:2639:852e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7344:b0:3bf:6acf:2940 with SMTP id adf61e73a8af0-3cb85df0a1bmr20575846637.11.1786059417589; Thu, 06 Aug 2026 16:36:57 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:44 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-28-seanjc@google.com> Subject: [PATCH v6 27/51] clocksource: hyper-v: Don't save/restore TSC offset when using HV sched_clock From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059419-591C5CFC-42B8086B/0/0 X-purgate-type: clean X-purgate-size: 2763 Now that Hyper-V overrides the sched_clock save/restore hooks if and only sched_clock itself is set to the Hyper-V reference counter, drop the invocation of the "old" save/restore callbacks. When the registration of the PV sched_clock was done separately from overriding the save/restore hooks, it was possible for Hyper-V to clobber the TSC save/restore callbacks without actually switching to the Hyper-V refcounter. Enabling a PV sched_clock is a one-way street, i.e. the kernel will never revert to using TSC for sched_clock, and so there is no need to invoke the TSC save/restore hooks (and if there was, it belongs in common PV code). Reviewed-by: Michael Kelley Tested-by: Michael Kelley Reviewed-by: David Woodhouse Acked-by: Wei Liu Signed-off-by: Sean Christopherson --- drivers/clocksource/hyperv_timer.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/clocksource/hyperv_timer.c b/drivers/clocksource/hyperv_timer.c index daa8cbfe61ee..220668207d19 100644 --- a/drivers/clocksource/hyperv_timer.c +++ b/drivers/clocksource/hyperv_timer.c @@ -544,9 +544,6 @@ static __always_inline void hv_setup_sched_clock(void *sched_clock) #include static u64 hv_ref_counter_at_suspend; -static void (*old_save_sched_clock_state)(void); -static void (*old_restore_sched_clock_state)(void); - /* * Hyper-V clock counter resets during hibernation. Save and restore clock * offset during suspend/resume, while also considering the time passed @@ -556,8 +553,6 @@ static void (*old_restore_sched_clock_state)(void); */ static void hv_save_sched_clock_state(void) { - old_save_sched_clock_state(); - hv_ref_counter_at_suspend = hv_read_reference_counter(); } @@ -570,8 +565,6 @@ static void hv_restore_sched_clock_state(void) * - reference counter (time) now. */ hv_sched_clock_offset -= (hv_ref_counter_at_suspend - hv_read_reference_counter()); - - old_restore_sched_clock_state(); } static __always_inline void hv_setup_sched_clock(void *sched_clock) @@ -579,10 +572,7 @@ static __always_inline void hv_setup_sched_clock(void *sched_clock) /* We're on x86/x64 *and* using PV ops */ paravirt_set_sched_clock(sched_clock); - old_save_sched_clock_state = x86_platform.save_sched_clock_state; x86_platform.save_sched_clock_state = hv_save_sched_clock_state; - - old_restore_sched_clock_state = x86_platform.restore_sched_clock_state; x86_platform.restore_sched_clock_state = hv_restore_sched_clock_state; } #else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */ -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:03 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385563.1628087 (Exim 4.92) (envelope-from ) id 1ws7it-0004em-Ak; Thu, 06 Aug 2026 23:42:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385563.1628087; Thu, 06 Aug 2026 23:42:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7it-0004dr-4R; Thu, 06 Aug 2026 23:42:03 +0000 Received: by outflank-mailman (input) for mailman id 1385563; Thu, 06 Aug 2026 23:42:02 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3mhp1agYKCf0xjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 1ws7is-0004OP-6c for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7ir-00EMEo-JB for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:01 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3mhp1agYKCf0xjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a751b7b-e002-0a2a0a5209dd-0a2a4507ba7e-30 for ; Fri, 07 Aug 2026 01:42:01 +0200 Received: from [209.85.215.199] (helo=mail-pg1-f199.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3mhp1agYKCf0xjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a751a9b-b4ea-0a2a45070019-d155d7c7e533-3 for ; Fri, 07 Aug 2026 01:37:00 +0200 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb4cdf95b5aso4647022a12.1 for ; Thu, 06 Aug 2026 16:37:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059419; x=1786664219; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=IDybt2K9QzXIIF0RtAPpPcNbJv3nyQQRnp+0cGRBepM=; b=U8zn6oj+pXJ4i7lMeXnmYvIAyYJ8t5d1ncj+BkYYksenQJB87we/ljatLfLlEpLjpW 1kkcaJ/b+1Kv6/uPDGPjz1m4eaoMR4+PeeLejCauvmQ2yjKRRJIISybf5zd3KtNt441a +tpIpzPOrdKvPr5pxx2ZvlY7KFgl0X30ELsDeUZkS1ivDszQ8rbpOfDCELg+OoCHLDFs Wb5H6aeRz9FG+BCHEoCpNSaqD78+d+3syeg/LHEoDOU5kYRtR7Kg/zPwHYQDvqAtYmCS gOx2kFCp8o22y8ZBVLp+4ETojLRfQL5YcGTAP5M1/6BA8rW5h7HyusMtYUv5F2/aoR7q Shxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059419; x=1786664219; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=IDybt2K9QzXIIF0RtAPpPcNbJv3nyQQRnp+0cGRBepM=; b=fdAcdOcx6nlYcKjQgKUDaw/3HnDSxjNRCRcPo1v8N+pKxxw0kubViUnwcj1O72jFVe kL/un9HkVF+mPZ8GRYov1vU8W+2Z0NgX6b90sbkbxaT8eRCrBWk5e6YpRbq4WPmjbS44 TEcvvSEysCuHUnbqFhI6kG8WkC9ijdmbnUOeqLt2OeoIGy6dSfWAd/knqcDTBFbLncpp ReBLwMcE5MUDtM4VUnBpt6kUJTWKMutW8l9Ex6PmMbRl8gZOHrI5lRiVTtumfCCdAjgK H6vo9vAvV0E+yNEG4Z+uvZQX79iAoAQ8WFwOvDl2T8thz1KT2r9DGQncDpBjKC2stGm8 Q/Gw== X-Forwarded-Encrypted: i=1; AHgh+Rq+1eEzdwbjlIRtiZ3mEJK67j/JstHIbotRWnNzLAVVqkaono5FO85WxFMOANcAnHpqbtvQJkngzG8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzqBMytgyFZqs1AINCBwPOj4ynFkmebec6V/loqSnuIcQtqSowT E5pUu3K1dd/MzKNeJ1iOQAEfoupFEAKwGGQfwawCrGCWtiwD6oxwdpuyGFZpNzlD6oRGHZMIBwd lcvVxOQ== X-Received: from pgbcp2.prod.google.com ([2002:a05:6a02:4002:b0:c8b:fa4f:f001]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:4314:b0:3c3:89ce:b5bc with SMTP id adf61e73a8af0-3cb85e28fd0mr22042606637.15.1786059418706; Thu, 06 Aug 2026 16:36:58 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:45 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-29-seanjc@google.com> Subject: [PATCH v6 28/51] x86/kvmclock: Setup kvmclock for secondary CPUs iff CONFIG_SMP=y From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1786059421-356C2AE4-6803097E/0/0 X-purgate-type: clean X-purgate-size: 1438 Gate kvmclock's secondary CPU code on CONFIG_SMP, not CONFIG_X86_LOCAL_APIC. Originally, kvmclock piggybacked PV APIC ops to setup secondary CPUs. When that wart was fixed by commit df156f90a0f9 ("x86: Introduce x86_cpuinit.early_percpu_clock_init hook"), the dependency on a local APIC got carried forward unnecessarily. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 2e7ab54cb9dc..b0c871ba8232 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -208,7 +208,7 @@ static void kvm_restore_sched_clock_state(void) kvm_register_clock("primary cpu clock, resume"); } -#ifdef CONFIG_X86_LOCAL_APIC +#ifdef CONFIG_SMP static void kvm_setup_secondary_clock(void) { kvm_register_clock("secondary cpu clock"); @@ -348,7 +348,7 @@ void __init kvmclock_init(bool prefer_tsc) x86_init.hyper.get_cpu_khz = kvmclock_get_tsc_khz; x86_platform.get_wallclock = kvm_get_wallclock; x86_platform.set_wallclock = kvm_set_wallclock; -#ifdef CONFIG_X86_LOCAL_APIC +#ifdef CONFIG_SMP x86_cpuinit.early_percpu_clock_init = kvm_setup_secondary_clock; #endif x86_platform.save_sched_clock_state = kvm_save_sched_clock_state; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385567.1628097 (Exim 4.92) (envelope-from ) id 1ws7iv-00054V-M5; Thu, 06 Aug 2026 23:42:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385567.1628097; Thu, 06 Aug 2026 23:42:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iv-00054I-I5; Thu, 06 Aug 2026 23:42:05 +0000 Received: by outflank-mailman (input) for mailman id 1385567; Thu, 06 Aug 2026 23:42:04 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3nBp1agYKCQEtfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 1ws7it-0004kF-Se for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:03 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7it-008OLI-9U for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:03 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3nBp1agYKCQEtfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 6a751b7a-bab6-0a2a0a5309dd-0a2a4504bd98-40 for ; Fri, 07 Aug 2026 01:42:03 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3nBp1agYKCQEtfbokdhpphmf.dpnyfo-efwfmmjtut.yfoqspkfdu.psh@flex--seanjc.bounces.google.com>) id 6a751a9d-b57f-0a2a45040019-d155d2c5d912-3 for ; Fri, 07 Aug 2026 01:37:02 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84a67b16217so4508395b3a.3 for ; Thu, 06 Aug 2026 16:37:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059421; x=1786664221; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=o8F+mGATSkCnO7RB7Nrhalcr3db+GPA7pyXAMrOPMa0=; b=TU8gvqp2Xs2TI9bhAeX4P+HrTuHBER0l6RwBZhwwm+Vdi8PQK6WfW8l1h/Q9w8HNPl NaTt4COG/0MZ5MlPnKoaHVAWhAcvVJNTv1RkTPI+TJdkDCnxzZ0XTL8yoOnCzUsyHGIE OW0DclQsdPi7f/O8GrTdYUVlQ/xCC5rJOb97VXN0QW6N8h/qiz91ApB3Pftn+CiU3x2Y iwxb8biObr5TVwUfaz4AOcFKmuQOIX33rGIrxxn8WtV6H+G2N4Kt2AHocb0nc6G4WXOU xgm/iYwZtUYTSjBJlngZfMDXw6JbAUkErlUJKt2ntLIbsABQGjQgkXmEs5+Q/pnbK3eO hW/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059421; x=1786664221; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=o8F+mGATSkCnO7RB7Nrhalcr3db+GPA7pyXAMrOPMa0=; b=Dn9HTRyT+QTl9OyM9PIUAKtpim93EP5BXvLKw0XTP6pS7m4iOjj69anpfyWlMFCuYA FtqW4C34iIHngbBSVyxBLYnzw5Sus4x3hvNb2xUdN9MGqCpvH7mdQbQqlPgtcGShoEUR 8AtFJkBHpV5LTK6uW7sU5VpjgBbdOpKAhvVSwaNPArgu8E8cBz3AI6Ip/QXA4M9QV7Cp 4yPIpCA75JJxlzo1N8HHZT4LMbWlTeMCaAWVjC6PMlTJw39goes1060FALvoWwo3eY+A i9J8T1ar62MIJbULgFUb5RKJPDtAyG5FhFRxwp0XL4TJn3qFQIObn6WN9X6uQZ/+ibX7 iwbQ== X-Forwarded-Encrypted: i=1; AHgh+Ro5cI0txA7pmFjtxGTa4TnVJs25ZU0OjeUCqjY+hUcv5CpHQmnB4LndKcG85GE3+gfONsr6YlYGKP0=@lists.xenproject.org X-Gm-Message-State: AOJu0YyL+4p8l6Eszz/G5brakP0VTolzhUzpnqKg0MDSs2Z7PBF16Gdl MMaIqrKjNrCm2ikSuT7mspEevNGYvmHBlqtvIxsGZJhPhLpGzmj9qC1Bfr4o8Kf1PX6PHEaC9cO gup0aLw== X-Received: from pfwp49.prod.google.com ([2002:a05:6a00:26f1:b0:84a:894f:23f2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1daa:b0:848:401c:98e with SMTP id d2e1a72fcca58-84f2e0432a7mr20883725b3a.15.1786059420393; Thu, 06 Aug 2026 16:37:00 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:46 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-30-seanjc@google.com> Subject: [PATCH v6 29/51] x86/kvm: Don't disable kvmclock on BSP in syscore_suspend() From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ebf023/1786059422-522D4B50-BCD4A772/0/0 X-purgate-type: clean X-purgate-size: 5413 Don't disable kvmclock on the BSP during syscore_suspend(), as the BSP's clock is NOT restored during syscore_resume(), but is instead restored earlier via the sched_clock restore callback. If suspend is aborted, e.g. due to a late wakeup, the BSP will run without its clock enabled, which "works" only because KVM-the-hypervisor is kind enough to not clobber the shared memory when the clock is disabled. But over time, the BSP's view of time will drift from APs. Plumb in an "action" to KVM-as-a-guest and kvmclock code in preparation for additional cleanups to kvmclock's suspend/resume logic. Fixes: c02027b5742b ("x86/kvm: Disable kvmclock on all CPUs on shutdown") Cc: stable@vger.kernel.org Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/include/asm/kvm_para.h | 8 +++++++- arch/x86/kernel/kvm.c | 15 ++++++++------- arch/x86/kernel/kvmclock.c | 31 +++++++++++++++++++++++++------ 3 files changed, 40 insertions(+), 14 deletions(-) diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h index 4a49fc286b4c..08686ff19caa 100644 --- a/arch/x86/include/asm/kvm_para.h +++ b/arch/x86/include/asm/kvm_para.h @@ -118,8 +118,14 @@ static inline long kvm_sev_hypercall3(unsigned int nr, unsigned long p1, } #ifdef CONFIG_KVM_GUEST +enum kvm_guest_cpu_action { + KVM_GUEST_BSP_SUSPEND, + KVM_GUEST_AP_OFFLINE, + KVM_GUEST_SHUTDOWN, +}; + void kvmclock_init(bool prefer_tsc); -void kvmclock_disable(void); +void kvmclock_cpu_action(enum kvm_guest_cpu_action action); bool kvm_para_available(void); unsigned int kvm_arch_para_features(void); unsigned int kvm_arch_para_hints(void); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 83b9351f2810..9c0b2fc98cc9 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -460,7 +460,7 @@ static void __init sev_map_percpu_data(void) } } -static void kvm_guest_cpu_offline(bool shutdown) +static void kvm_guest_cpu_offline(enum kvm_guest_cpu_action action) { kvm_disable_steal_time(); if (kvm_para_has_feature(KVM_FEATURE_PV_EOI)) @@ -468,9 +468,10 @@ static void kvm_guest_cpu_offline(bool shutdown) if (kvm_para_has_feature(KVM_FEATURE_MIGRATION_CONTROL)) wrmsrq(MSR_KVM_MIGRATION_CONTROL, 0); kvm_pv_disable_apf(); - if (!shutdown) + if (action != KVM_GUEST_SHUTDOWN) apf_task_wake_all(); - kvmclock_disable(); + + kvmclock_cpu_action(action); } static int kvm_cpu_online(unsigned int cpu) @@ -728,7 +729,7 @@ static int kvm_cpu_down_prepare(unsigned int cpu) unsigned long flags; local_irq_save(flags); - kvm_guest_cpu_offline(false); + kvm_guest_cpu_offline(KVM_GUEST_AP_OFFLINE); local_irq_restore(flags); return 0; } @@ -739,7 +740,7 @@ static int kvm_suspend(void *data) { u64 val = 0; - kvm_guest_cpu_offline(false); + kvm_guest_cpu_offline(KVM_GUEST_BSP_SUSPEND); #ifdef CONFIG_ARCH_CPUIDLE_HALTPOLL if (kvm_para_has_feature(KVM_FEATURE_POLL_CONTROL)) @@ -770,7 +771,7 @@ static struct syscore kvm_syscore = { static void kvm_pv_guest_cpu_reboot(void *unused) { - kvm_guest_cpu_offline(true); + kvm_guest_cpu_offline(KVM_GUEST_SHUTDOWN); } static int kvm_pv_reboot_notify(struct notifier_block *nb, @@ -794,7 +795,7 @@ static struct notifier_block kvm_pv_reboot_nb = { #ifdef CONFIG_CRASH_DUMP static void kvm_crash_shutdown(struct pt_regs *regs) { - kvm_guest_cpu_offline(true); + kvm_guest_cpu_offline(KVM_GUEST_SHUTDOWN); native_machine_crash_shutdown(regs); } #endif diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index b0c871ba8232..a3ec298d56d7 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -199,8 +199,22 @@ static void kvm_register_clock(char *txt) pr_debug("kvm-clock: cpu %d, msr %llx, %s", smp_processor_id(), pa, txt); } +static void kvmclock_disable(void) +{ + if (msr_kvm_system_time) + native_write_msr(msr_kvm_system_time, 0); +} + static void kvm_save_sched_clock_state(void) { + /* + * Stop host writes to kvmclock immediately prior to suspend/hibernate. + * If the system is hibernating, then kvmclock will likely reside at a + * different physical address when the system awakens, and host writes + * to the old address prior to reconfiguring kvmclock would clobber + * random memory. + */ + kvmclock_disable(); } static void kvm_restore_sched_clock_state(void) @@ -208,6 +222,17 @@ static void kvm_restore_sched_clock_state(void) kvm_register_clock("primary cpu clock, resume"); } +void kvmclock_cpu_action(enum kvm_guest_cpu_action action) +{ + /* + * Don't disable kvmclock on the BSP during suspend. If kvmclock is + * being used for sched_clock, then it needs to be kept alive until the + * last minute, and restored as quickly as possible after resume. + */ + if (action != KVM_GUEST_BSP_SUSPEND) + kvmclock_disable(); +} + #ifdef CONFIG_SMP static void kvm_setup_secondary_clock(void) { @@ -215,12 +240,6 @@ static void kvm_setup_secondary_clock(void) } #endif -void kvmclock_disable(void) -{ - if (msr_kvm_system_time) - native_write_msr(msr_kvm_system_time, 0); -} - static void __init kvmclock_init_mem(void) { unsigned long ncpus; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385577.1628106 (Exim 4.92) (envelope-from ) id 1ws7j0-0005eF-5b; Thu, 06 Aug 2026 23:42:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385577.1628106; Thu, 06 Aug 2026 23:42:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7iz-0005dt-Uw; Thu, 06 Aug 2026 23:42:09 +0000 Received: by outflank-mailman (input) for mailman id 1385577; Thu, 06 Aug 2026 23:42:08 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3oRp1agYKCQYykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 1ws7iy-0005YJ-Nj for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iy-00EMFx-4g for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:08 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3oRp1agYKCQYykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 6a751ba5-2eae-0a2a0a5409dd-0a2a450a9b14-32 for ; Fri, 07 Aug 2026 01:42:08 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3oRp1agYKCQYykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 6a751aa2-f2d2-0a2a450a0019-d155d2c5a962-3 for ; Fri, 07 Aug 2026 01:37:07 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84a251c2e3eso1816043b3a.1 for ; Thu, 06 Aug 2026 16:37:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059426; x=1786664226; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=7lbZxAdhwKhuj6TvbAGr7x+TgvyyRrRPdrrP8vwGefI=; b=gb840K9NfEn/C6h5FHraJYb1bYxHmL0lL+af7n2/IFou3Kddqy4nMf5Ls0/rzrR+Rh O57JCe6jNvrDt2PxW9Ntz/Jnnk14mue4Ky9ZMMlfbdVyBUCaHE/Vw4QjJe3XhmHquu10 H6UOmZyctytwi238Kt7fvPObnMYSMjvMWkf8B1flf/zQXnUWiGpsv8h9RBpvbovbpZrB vTFbLPQM0cz8azR/0xmxg/TBTFcLGflRK5w8wMly5OYTl9inaOsayMykDjYkEfBu3IgT DryCKtvmQZ6icLzs/KBXjTDeaOLFLBNWNwZmi8P/9JVHcr9dETHo9pvVqZbnQdq7tRF3 Dh4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059426; x=1786664226; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7lbZxAdhwKhuj6TvbAGr7x+TgvyyRrRPdrrP8vwGefI=; b=j8CWkRjmb5WyasPnc+QPuULC+T+L2Y6u56UwPnFK5Zxj2CZ2fQ1graYNYyqFj0BV8F SHj4908dJCK2izyyCKamZXuSCPjIu8/V8r53L1vUn15LFCImNm3CtV8xMaPCx806UnR0 ydLC9EiL6oUQILMizJxCpqsi9BkWdbDF8d8nEYGkWKmVU5rkAkQ/DiazSBBpWLWZs7yi OOdmKjtvsfLJv2VwmMt/TabmfPacFcmZDcYLivnY1S8f0pnmiWRKDO9g5JOAyLduOnlU mMriHQ1gpC1N5ZmMNYMsyH+qFZcnjgWMbzdpAgeXzZ/c0v4p/vEuWfkcW0w4HACA8jaf MK5w== X-Forwarded-Encrypted: i=1; AHgh+RrkXt6iv5Dy51jvtrZA+b6E+kLKTlSz1LQQvAfdufIee1L5uBPMHvjgjPrNb05Eu47CrXz12F+zYyo=@lists.xenproject.org X-Gm-Message-State: AOJu0Ywxkui/WVTwdm/W9p9Q//zVB6WD/BDAhNQclStWIJHtQru8A8B2 jhZ3uzP4hrkzHB0Hxx4WAS/rcSwmzfWf8rc7x4RbodH5kjNp+oHbmz4/W0ynQFtuDPCbeejcN6W N5Z3dAA== X-Received: from pgmt23.prod.google.com ([2002:a63:2257:0:b0:c86:61a1:3390]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:7105:b0:3bf:651d:fee0 with SMTP id adf61e73a8af0-3cba2b5d6a7mr10015839637.19.1786059425491; Thu, 06 Aug 2026 16:37:05 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:50 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-34-seanjc@google.com> Subject: [PATCH v6 33/51] x86/xen/time: NOP-ify x86_platform's sched_clock save/restore hooks From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059427-51EC2CFC-B6E954E2/0/0 X-purgate-type: clean X-purgate-size: 1153 NOP-ify the x86_platform sched_clock save/restore hooks when setting up Xen's PV clock to make it somewhat obvious the hooks aren't used when running as a Xen guest (Xen uses a paravirtualized suspend/resume flow). Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/xen/time.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 487ad838c441..477441752f40 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -567,6 +567,12 @@ static void __init xen_init_time_common(void) xen_sched_clock_offset = xen_clocksource_read(); static_call_update(pv_steal_clock, xen_steal_clock); paravirt_set_sched_clock(xen_sched_clock); + /* + * Xen has paravirtualized suspend/resume and so doesn't use the common + * x86 sched_clock save/restore hooks. + */ + x86_platform.save_sched_clock_state = x86_init_noop; + x86_platform.restore_sched_clock_state = x86_init_noop; x86_init.hyper.get_tsc_khz = xen_tsc_khz; x86_platform.get_wallclock = xen_get_wallclock; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385578.1628114 (Exim 4.92) (envelope-from ) id 1ws7j1-0005wC-Lz; Thu, 06 Aug 2026 23:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385578.1628114; Thu, 06 Aug 2026 23:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7j1-0005vG-F5; Thu, 06 Aug 2026 23:42:11 +0000 Received: by outflank-mailman (input) for mailman id 1385578; Thu, 06 Aug 2026 23:42:09 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3oBp1agYKCQUxjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 1ws7iz-0005cX-NB for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7iz-00EMEo-4A for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:09 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3oBp1agYKCQUxjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a751b7b-e002-0a2a0a5209dd-0a2a4507ba7e-32 for ; Fri, 07 Aug 2026 01:42:09 +0200 Received: from [209.85.210.198] (helo=mail-pf1-f198.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3oBp1agYKCQUxjfsohlttlqj.htr2js-ij0jqqnxyx.2jsuwtojhy.twl@flex--seanjc.bounces.google.com>) id 6a751aa1-b4ea-0a2a45070019-d155d2c6dc9f-3 for ; Fri, 07 Aug 2026 01:37:06 +0200 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8487ed7f7beso3066702b3a.0 for ; Thu, 06 Aug 2026 16:37:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059425; x=1786664225; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=EB+XxHVCdw85PrkaMnB06pus7nsirHAVeqpBTRH+yt8=; b=XhC8vE42GHi+5vCSKyifOCJlEJLI3t5FZystoXY5ojkacL6DebBjtEp0Ddts3Fin7R XS9RUq4lIMCNNcGW+F4qcY/sgewf/MfyjHQJgdr7kqlFDW/VFYOF7lIkk2Ytn9nfghnC mCKD581PxuUU755Hcc9VolXuwL2oU2TGzPuXeJSfBYpOCzJx2OSgitQhnSpg3CX3WUhU KW2hX2JRmVKVXOohb8uA80pc5rrUeO1ndbXT0pYk6jOFstIEsEXAKyZrujBDnDwygxoi UoL9DlkWeqrnqMzOGpGU/azMr5VAjrsjb4m8xXQiKC9sER06nwqfPlcgq4M/lZl9znxQ ZeiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059425; x=1786664225; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EB+XxHVCdw85PrkaMnB06pus7nsirHAVeqpBTRH+yt8=; b=elFBD3FU3K4voGsqh7GEA1LmxC0Lx0RVuWn/qbrPF0lB4Yf83zENgfe3mrRe6yulKU oM6ST81XRe4OTOQS6Cz3anNgL1/Ih7hKSS9PWBeHY834fzudIuHBoCAZGAeHO7779vUE FoG/ROYXwKiE0XTUP9e/BPZTFnVBx4Q72fhSQo+5U9rn9sdbADNUc3igHwrTXiIBxdyJ TPX6B1aSZKm5H5ddSYWFtjmYftt9Qvh+l09vRu9D3CS3XpKUK3xWE71u5mizN8PrrNBz JJnW47Bnd+OfMTxGt2KaUFFVc2SC55zhTi+Wf757s4LII+CKsRntRVse2K/2zjA4IKuF I+qw== X-Forwarded-Encrypted: i=1; AHgh+RoVwlC3nooX7heHAPtWMwm9icV9ekzgXjXKFx0vzlfOOwYTEL8G3jOxBlBLNAFlBBsmw6O/mR/YBxU=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy6l+pBldenHktCu3QJfTK7bLdIVrJx0fLYaTv/fWJhL4a3YDll +sNGBOW/91wiTs1PwESm/HQIDpLb9BO2dwmbwD1Bc2t786ej6NFmT43rwhumqXz2CFMSsharLWz /0EOjNw== X-Received: from pfbmc40.prod.google.com ([2002:a05:6a00:76a8:b0:84c:1460:ab72]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2441:b0:848:5951:ff78 with SMTP id d2e1a72fcca58-84f2e1525d0mr19690745b3a.36.1786059424271; Thu, 06 Aug 2026 16:37:04 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:49 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-33-seanjc@google.com> Subject: [PATCH v6 32/51] x86/kvmclock: Move sched_clock save/restore helpers up in kvmclock.c From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-ef75cf/1786059426-A78D1AE4-23391718/0/0 X-purgate-type: clean X-purgate-size: 4420 Move kvmclock's sched_clock save/restore helper "up" so that they can (eventually) be referenced by kvm_sched_clock_init(). No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 108 ++++++++++++++++++------------------- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 4bc0495f1f9e..07e875738c39 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -71,6 +71,25 @@ static int kvm_set_wallclock(const struct timespec64 *now) return -ENODEV; } +static void kvm_register_clock(char *txt) +{ + struct pvclock_vsyscall_time_info *src = this_cpu_hvclock(); + u64 pa; + + if (!src) + return; + + pa = slow_virt_to_phys(&src->pvti) | 0x01ULL; + wrmsrq(msr_kvm_system_time, pa); + pr_debug("kvm-clock: cpu %d, msr %llx, %s", smp_processor_id(), pa, txt); +} + +static void kvmclock_disable(void) +{ + if (msr_kvm_system_time) + native_write_msr(msr_kvm_system_time, 0); +} + static u64 kvm_clock_read(void) { u64 ret; @@ -112,6 +131,30 @@ static noinstr u64 kvm_sched_clock_read(void) return pvclock_clocksource_read_nowd(this_cpu_pvti()) - kvm_sched_clock_offset; } +static void kvm_save_sched_clock_state(void) +{ + /* + * Stop host writes to kvmclock immediately prior to suspend/hibernate. + * If the system is hibernating, then kvmclock will likely reside at a + * different physical address when the system awakens, and host writes + * to the old address prior to reconfiguring kvmclock would clobber + * random memory. + */ + kvmclock_disable(); +} + +#ifdef CONFIG_SMP +static void kvm_setup_secondary_clock(void) +{ + kvm_register_clock("secondary cpu clock"); +} +#endif + +static void kvm_restore_sched_clock_state(void) +{ + kvm_register_clock("primary cpu clock, resume"); +} + static inline void kvm_sched_clock_init(bool stable) { kvm_sched_clock_offset = kvm_clock_read(); @@ -124,6 +167,17 @@ static inline void kvm_sched_clock_init(bool stable) sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); } +void kvmclock_cpu_action(enum kvm_guest_cpu_action action) +{ + /* + * Don't disable kvmclock on the BSP during suspend. If kvmclock is + * being used for sched_clock, then it needs to be kept alive until the + * last minute, and restored as quickly as possible after resume. + */ + if (action != KVM_GUEST_BSP_SUSPEND) + kvmclock_disable(); +} + /* * If we don't do that, there is the possibility that the guest * will calibrate under heavy load - thus, getting a lower lpj - @@ -183,60 +237,6 @@ static struct clocksource kvm_clock = { .enable = kvm_cs_enable, }; -static void kvm_register_clock(char *txt) -{ - struct pvclock_vsyscall_time_info *src = this_cpu_hvclock(); - u64 pa; - - if (!src) - return; - - pa = slow_virt_to_phys(&src->pvti) | 0x01ULL; - wrmsrq(msr_kvm_system_time, pa); - pr_debug("kvm-clock: cpu %d, msr %llx, %s", smp_processor_id(), pa, txt); -} - -static void kvmclock_disable(void) -{ - if (msr_kvm_system_time) - native_write_msr(msr_kvm_system_time, 0); -} - -static void kvm_save_sched_clock_state(void) -{ - /* - * Stop host writes to kvmclock immediately prior to suspend/hibernate. - * If the system is hibernating, then kvmclock will likely reside at a - * different physical address when the system awakens, and host writes - * to the old address prior to reconfiguring kvmclock would clobber - * random memory. - */ - kvmclock_disable(); -} - -static void kvm_restore_sched_clock_state(void) -{ - kvm_register_clock("primary cpu clock, resume"); -} - -void kvmclock_cpu_action(enum kvm_guest_cpu_action action) -{ - /* - * Don't disable kvmclock on the BSP during suspend. If kvmclock is - * being used for sched_clock, then it needs to be kept alive until the - * last minute, and restored as quickly as possible after resume. - */ - if (action != KVM_GUEST_BSP_SUSPEND) - kvmclock_disable(); -} - -#ifdef CONFIG_SMP -static void kvm_setup_secondary_clock(void) -{ - kvm_register_clock("secondary cpu clock"); -} -#endif - static void __init kvmclock_init_mem(void) { unsigned long ncpus; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385586.1628124 (Exim 4.92) (envelope-from ) id 1ws7j6-0006Xe-1G; Thu, 06 Aug 2026 23:42:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385586.1628124; Thu, 06 Aug 2026 23:42:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7j5-0006XH-Qu; Thu, 06 Aug 2026 23:42:15 +0000 Received: by outflank-mailman (input) for mailman id 1385586; Thu, 06 Aug 2026 23:42:13 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3php1agYKCQs3plyunrzzrwp.nzx8py-op6pwwt343.8py02zupn4.z2r@flex--seanjc.bounces.google.com>) id 1ws7j3-0006JR-T4 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7j3-00EMEo-9g for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:13 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3php1agYKCQs3plyunrzzrwp.nzx8py-op6pwwt343.8py02zupn4.z2r@flex--seanjc.bounces.google.com>) id 6a751bae-e002-0a2a0a5209dd-0a2a4503e136-26 for ; Fri, 07 Aug 2026 01:42:13 +0200 Received: from [209.85.214.198] (helo=mail-pl1-f198.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3php1agYKCQs3plyunrzzrwp.nzx8py-op6pwwt343.8py02zupn4.z2r@flex--seanjc.bounces.google.com>) id 6a751aa7-fae8-0a2a45030019-d155d6c6ad5d-3 for ; Fri, 07 Aug 2026 01:37:12 +0200 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cc5faecf01so51051255ad.1 for ; Thu, 06 Aug 2026 16:37:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059431; x=1786664231; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=dLl1t0qRZTm556OBeVqKVx/DHfexmKODeXAiUOaDm4I=; b=ln7BlPKUPiOO/cp4dV5mxjLgoz+Vyp23kyPFqwsk+elJtcPFrpcLepHogTzrv3GqRt j2JUtiidAiBz4/pMrBPzzdZqoK4dNw3S+Blha7EtBpnF443vs2aT7n2KpIrdAszljvkK C5BaGsrYvMlYI3RbhfKb9HtKbaZ24AagDQaKfZJZ1qv86YLnefDX+a0YdPJtkylPh0TX AVNKkD9RYbRTuPQiqGvxWUVAzw9R2v0LMOlmPqnFMrqeIWiju1SWviJa7NK+xM5ClBGO UdYfKONlGTAbsIDcm1K27/Bgc+whh1G0JIxjiTG3DFvH5w7Mwj4HKDgsaP0ZIYKl85SG Y4/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059431; x=1786664231; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=dLl1t0qRZTm556OBeVqKVx/DHfexmKODeXAiUOaDm4I=; b=jiRdE5uef4VzH9yeYjFcXpXov5OSc+eXAuCAp+rJblTbQ+DZNCymotlzEd1mJI3lpT 1R4wijZ545e5s2M+MgVGEd7+6HHBzHITgxqhM3wn6qx3D0UqaOY0cBZU/RbZIvBEOzE+ Pz+QGOumkmK4wLt5Z3fEvtoW87hLAhUUiO+lXr1PHfklxfNKCoVhHt288nz7mssTTdJK JTyjT5V2Vy0VwdST+m0SSwhk/NfmOsc/2iU815erdSq/hYAbPzYuLZ9l2Y3Awm0djUxc jgyghvJTLAjnFz2cwckURDGiRitlDsGKGClfWyHYYz8DhLEujlPHsNk0C+UNRLhn6xcr 7Zmg== X-Forwarded-Encrypted: i=1; AHgh+Ro9iegpaXyxjhDozmkhSSzneAg2mniL+pEZGc0bvT+nncByT3iQAMFVHvdYhQUV8L8g0fM2MHyYGys=@lists.xenproject.org X-Gm-Message-State: AOJu0YxlxbnLvdVezlMjlUqO8aZVyW246GdEHsmVrQWz+j3Litjhfmpr h4HH1dPRNoR5tzViUNX3iU3rU+rONO0PN91/SF71alOCmLuWbr8OJ3EWOdkPoGojnPkRDlOMvCf 0as/T1A== X-Received: from pjzg4.prod.google.com ([2002:a17:90a:e584:b0:38e:b470:e6db]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2590:b0:38f:2168:b9cb with SMTP id 98e67ed59e1d1-3903c572a05mr18787499a91.9.1786059430539; Thu, 06 Aug 2026 16:37:10 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:54 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-38-seanjc@google.com> Subject: [PATCH v6 37/51] x86/kvmclock: Move kvm_sched_clock_init() down in kvmclock.c From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-33051d/1786059432-77AC44E9-8818F214/0/0 X-purgate-type: clean X-purgate-size: 2297 Move kvm_sched_clock_init() "down" so that it can reference the global kvm_clock structure without needing a forward declaration. Opportunistically mark the helper as "__init" instead of "inline" to make its usage more obvious; modern compilers don't need a hint to inline a single-use function, and an extra CALL+RET pair during boot is a complete non-issue. And, if the compiler ignores the hint and does NOT inline the function, the resulting code may not get discarded after boot due lack of an __init annotation. No functional change intended. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/kvmclock.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c index 5b9955343199..5220d205abc7 100644 --- a/arch/x86/kernel/kvmclock.c +++ b/arch/x86/kernel/kvmclock.c @@ -155,20 +155,6 @@ static void kvm_restore_sched_clock_state(void) kvm_register_clock("primary cpu clock, resume"); } -static inline void kvm_sched_clock_init(bool stable) -{ - kvm_sched_clock_offset = kvm_clock_read(); - __paravirt_set_sched_clock(kvm_sched_clock_read, stable, - kvm_save_sched_clock_state, - kvm_restore_sched_clock_state); - - pr_info("kvm-clock: using sched offset of %llu cycles", - kvm_sched_clock_offset); - - BUILD_BUG_ON(sizeof(kvm_sched_clock_offset) > - sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); -} - void kvmclock_cpu_action(enum kvm_guest_cpu_action action) { /* @@ -325,6 +311,20 @@ static int kvmclock_setup_percpu(unsigned int cpu) return p ? 0 : -ENOMEM; } +static __init void kvm_sched_clock_init(bool stable) +{ + kvm_sched_clock_offset = kvm_clock_read(); + __paravirt_set_sched_clock(kvm_sched_clock_read, stable, + kvm_save_sched_clock_state, + kvm_restore_sched_clock_state); + + pr_info("kvm-clock: using sched offset of %llu cycles", + kvm_sched_clock_offset); + + BUILD_BUG_ON(sizeof(kvm_sched_clock_offset) > + sizeof(((struct pvclock_vcpu_time_info *)NULL)->system_time)); +} + void __init kvmclock_init(bool prefer_tsc) { u8 flags; -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:21 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385600.1628134 (Exim 4.92) (envelope-from ) id 1ws7jB-0007Dh-E5; Thu, 06 Aug 2026 23:42:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385600.1628134; Thu, 06 Aug 2026 23:42:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7jB-0007D1-5l; Thu, 06 Aug 2026 23:42:21 +0000 Received: by outflank-mailman (input) for mailman id 1385600; Thu, 06 Aug 2026 23:42:20 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3rBp1agYKCRE9vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 1ws7jA-00077X-06 for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7j9-00H1om-DF for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:19 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3rBp1agYKCRE9vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a751b6a-5cb7-0a2a0a5109dd-0a2a45058b62-42 for ; Fri, 07 Aug 2026 01:42:19 +0200 Received: from [209.85.215.199] (helo=mail-pg1-f199.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3rBp1agYKCRE9vr40tx55x2v.t53Ev4-uvCv22z9A9.Ev46850vtA.58x@flex--seanjc.bounces.google.com>) id 6a751aad-4cb1-0a2a45050019-d155d7c7c87d-3 for ; Fri, 07 Aug 2026 01:37:18 +0200 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cbe62e01567so2346093a12.2 for ; Thu, 06 Aug 2026 16:37:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059437; x=1786664237; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=qISz6FBmFt+Rjc4N/P+Kp805/IDsq2ZStMxtEE1uDRQ=; b=khAI2sx07TzbmQEw6txieutghq3rpZ+AQVw90UMqkHZhFed1yn/lwVe1KoASch7LR6 kgXrdwQ/QHM5lheLbgs1O99YVOZizjfxGkdhJ0rf46PBrmLZdrsEa9zlu5qOsENd4Y3y YVlcMIh/j2nEo3XDHvqJ4tYT51cLVr6bLVhvf0QiA5XunPOUssF2ukbfuD8mKfvM32D6 T0l5l/EkJWYRr6neF1E786kEmtGV2tHRuY6BcpWxgq9c4hj/wEwzt81iInHIsw0g1VHk tGbv8fJqko+cznyBtjt3w3efNsWPjjSjV9fgYG8MSAVviVVIrfbykAUoBHR9//9ZPsIa cskA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059437; x=1786664237; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qISz6FBmFt+Rjc4N/P+Kp805/IDsq2ZStMxtEE1uDRQ=; b=a4gDH3zilvz6psJlPfimaccTRWt4FSGU9Ixdq5gxQOQCG16h0/Ec1jaPtW4z4yCMZU fupSt3HjLpmybbvwOBeQ5RWnESdOeqjW1tQvQtQ/pf8GzVdjbD0/u4gwqB5AxXwXDu7/ hYZ/PXCpTJzrMYCYL4/hzLmdsUOf9sOFYrHa1ecZa9lkugBmLc0M6JY2abSfSBvdeeS1 cp70a2oRmS3ajwmYeO3CgdaXFeLfrjqQEqzoDMkIfhQQM9lZGhFSOLnjk4F+S9t9zdMi 2v+8QQBxUOkW18Tr1Df0G4Li/+RU+pxAn0cBEo/IMsf35+rRcG3ciGKwuB23CWKdaaAx HfHg== X-Forwarded-Encrypted: i=1; AHgh+Rpcjmqouk2srAGMannHyFL81UuKPtQ7SFBX/JN2sQo3beGoQzeBhIRG7R8hxaYL/baDdFQS59tPqCM=@lists.xenproject.org X-Gm-Message-State: AOJu0YxE1zeLni3+dnu/NlJOvYX1SpDYDLNt+s05AJXOxEEMkB+7u7n1 QczARDNgk0g4YzK2h0x9YuBHCq9R5aMcczGww7M7FuMdGm1cPNowJRDq8/Q/sOLL0fdOOsMvZlR utbFUVQ== X-Received: from pgbep6.prod.google.com ([2002:a05:6a02:2646:b0:c99:90dc:7b3f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:6112:b0:3b4:e4f6:4f15 with SMTP id adf61e73a8af0-3cb85e9922cmr22668021637.5.1786059436589; Thu, 06 Aug 2026 16:37:16 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:59 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-43-seanjc@google.com> Subject: [PATCH v6 42/51] timekeeping: Resume clocksources before reading persistent clock From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-c201ff/1786059438-F6AB72A1-D1235742/13/0 X-purgate-type: clean X-purgate-size: 1667 When resuming timekeeping after suspend, restore clocksources prior to reading the persistent clock. Paravirt clocks, e.g. kvmclock, tie the validity of a PV persistent clock to a clocksource, i.e. reading the PV persistent clock will return garbage if the underlying PV clocksource hasn't been enabled. The flaw has gone unnoticed because kvmclock is a mess and uses its own suspend/resume hooks instead of the clocksource suspend/resume hooks, which happens to work by sheer dumb luck (the kvmclock resume hook runs before timekeeping_resume()). Note, there is no evidence that any clocksource supported by the kernel depends on a persistent clock. Reviewed-by: Thomas Gleixner Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- kernel/time/timekeeping.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 97db2e9393f9..585525f5c1f6 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -2226,11 +2226,16 @@ void timekeeping_resume(void) u64 cycle_now, nsec; unsigned long flags; - read_persistent_clock64(&ts_new); - clockevents_resume(); clocksource_resume(); + /* + * Read persistent time after clocksources have been resumed. Paravirt + * clocks have a nasty habit of piggybacking a persistent clock on a + * system clock, and may return garbage if the system clock is suspended. + */ + read_persistent_clock64(&ts_new); + raw_spin_lock_irqsave(&tk_core.lock, flags); /* -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Thu Aug 06 23:42:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 06 Aug 2026 23:42:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385603.1628141 (Exim 4.92) (envelope-from ) id 1ws7jC-0007VZ-QY; Thu, 06 Aug 2026 23:42:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385603.1628141; Thu, 06 Aug 2026 23:42:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ws7jC-0007VH-Ie; Thu, 06 Aug 2026 23:42:22 +0000 Received: by outflank-mailman (input) for mailman id 1385603; Thu, 06 Aug 2026 23:42:21 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3qhp1agYKCQ87tp2yrv33v0t.r31Ct2-stAt00x787.Ct2463ytr8.36v@flex--seanjc.bounces.google.com>) id 1ws7jB-0007C8-1p for xen-devel@lists.xenproject.org; Thu, 06 Aug 2026 23:42:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1ws7jA-00EMFx-Ey for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 01:42:20 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3qhp1agYKCQ87tp2yrv33v0t.r31Ct2-stAt00x787.Ct2463ytr8.36v@flex--seanjc.bounces.google.com>) id 6a751ba5-2eae-0a2a0a5409dd-0a2a450a9b14-44 for ; Fri, 07 Aug 2026 01:42:20 +0200 Received: from [209.85.210.199] (helo=mail-pf1-f199.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3qhp1agYKCQ87tp2yrv33v0t.r31Ct2-stAt00x787.Ct2463ytr8.36v@flex--seanjc.bounces.google.com>) id 6a751aab-f2d2-0a2a450a0019-d155d2c7e928-3 for ; Fri, 07 Aug 2026 01:37:16 +0200 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84e3d575d6eso4633580b3a.3 for ; Thu, 06 Aug 2026 16:37:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786059434; x=1786664234; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=gswAR/5wSepHR0W/S6/oLzBYH0wiOXioT7kjM1AQclw=; b=ditBFt2pCyTk3Lwqeow5V9ILHsm3qtTn0mOvL72447NgS25l7p2yLkWXNAXeCwUu/c B0BqLBaYRI/7PxK9Vtq1qT69Wub2AjDSLTrHVbUzss90rE3KIzkxgtBqHNkjxgJf7tXv uFyK5nC09ZyFlkVePY8eP+y9Jxlea3aL/645AmHsfLTkzUWB69xuei4gtlZKBd6Gw5bs hPoydVOX8MniXlOZhpfCQBw0AbucCNZmFckVZrEvBD1NX5b40T0MIdpP+u3cdM8FLhtk 9eRnzJQo9Mu4Y16N0OWOHCrAOFyWwc3qJ0y9GiwR1SkmbYVhR81gIWy+F3t+gJP66yqY tmUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786059434; x=1786664234; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gswAR/5wSepHR0W/S6/oLzBYH0wiOXioT7kjM1AQclw=; b=KVyIwsJWS45tCncstCMLiuaGwKqUQ0u97XDioZr+vswXtR/pQ4EyA2tUINqDL7liE5 sRR9kZTBQQ8bCN7n1lZlZ7vabAfw5Ld0+kBUXMmrQ8oAJBlhILF48uNppkZVDhKNK2Rx ur1dqpcERHqxhfOEWbUwPIrQkOlIgQwvCaIPzgFK1lrZNPk2+FNDITAhoT27rN1cW/TX 8w9NM5bi4PWTCZ5PCkUAPFxXUu9+ijz3Wx8+IHpr7sC8RX3u/7PUYKzMl+AZwohuqfbJ P+N0bN2eYz4D3Mpu2b47hTj2zpAzTl7qGJakHOcWm145a5dF0EZJzuEVmJ5Tk0kZEyNm /bLA== X-Forwarded-Encrypted: i=1; AHgh+RqHi0L2msiSVT29fORRrIRzV87igwW1xJ1Y++EIWAXlPP0VdbO003eGehNtRf4XfJ1YXmTBZ8vymeA=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzsq2sXIJbs6xGM55XG29cpMsV5z2mnqKyMPEngGm9RNrjQaoXv H+vQypukfCsxPP/i81JoiuE7f6nTOzZSrwMN0NFcvv2rj24ppk7ghZiFCTGIRifrctmIPrZc9Wc RvOg3EQ== X-Received: from pfjt11.prod.google.com ([2002:a05:6a00:21cb:b0:84e:2062:2edb]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:9506:b0:84a:29a7:f64c with SMTP id d2e1a72fcca58-84f2de45511mr20003910b3a.0.1786059434181; Thu, 06 Aug 2026 16:37:14 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 6 Aug 2026 16:35:57 -0700 In-Reply-To: <20260806233609.212337-1-seanjc@google.com> Mime-Version: 1.0 References: <20260806233609.212337-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260806233609.212337-41-seanjc@google.com> Subject: [PATCH v6 40/51] x86/pvclock: WARN if pvclock's valid_flags are overwritten From: Sean Christopherson To: Kiryl Shutsemau , Rick Edgecombe , Sean Christopherson , Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Kaher , Alexey Makhalov , Jan Kiszka , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Juergen Gross , Daniel Lezcano , Thomas Gleixner , John Stultz Cc: Vitaly Kuznetsov , Broadcom internal kernel review list , Boris Ostrovsky , Stephen Boyd , Miroslav Lichvar , x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley , Tom Lendacky , Nikunj A Dadhania , David Woodhouse , David Woodhouse , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-4011c0/1786059436-524DFCFC-23BCB0E7/13/0 X-purgate-type: clean X-purgate-size: 780 WARN if the common PV clock valid_flags are overwritten; all PV clocks expect that they are the one and only PV clock, i.e. don't guard against another PV clock having modified the flags. Reviewed-by: David Woodhouse Signed-off-by: Sean Christopherson --- arch/x86/kernel/pvclock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c index a51adce67f92..8d098841a225 100644 --- a/arch/x86/kernel/pvclock.c +++ b/arch/x86/kernel/pvclock.c @@ -21,6 +21,7 @@ static struct pvclock_vsyscall_time_info *pvti_cpu0_va __ro_after_init; void __init pvclock_set_flags(u8 flags) { + WARN_ON(valid_flags); valid_flags = flags; } -- 2.55.0.679.g6767b8d81c-goog From xen-devel-bounces@lists.xenproject.org Fri Aug 07 05:22:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 05:22:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385725.1628151 (Exim 4.92) (envelope-from ) id 1wsD2O-0002sa-UF; Fri, 07 Aug 2026 05:22:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385725.1628151; Fri, 07 Aug 2026 05:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsD2O-0002sS-Qg; Fri, 07 Aug 2026 05:22:32 +0000 Received: by outflank-mailman (input) for mailman id 1385725; Fri, 07 Aug 2026 03:23:35 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsBBH-0001eF-Fl for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 03:23:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsBBG-00GxkT-5W for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 05:23:34 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a754faf-e002-0a2a0a5209dd-0a2a450a958c-2 for ; Fri, 07 Aug 2026 05:23:34 +0200 Received: from [209.85.160.171] (helo=mail-qt1-f171.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a754fb5-f2d2-0a2a450a0019-d155a0abe157-3 for ; Fri, 07 Aug 2026 05:23:33 +0200 Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-52b4e988c77so19005511cf.3 for ; Thu, 06 Aug 2026 20:23:33 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d1663e9e1sm3438561cf.30.2026.08.06.20.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 20:23:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786073012; x=1786677812; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=T5tWYfkrSYEAFJzgjYou2Lj+31bzExLORMbEtdMFcLw=; b=K2tIR2uxsfa+PGMPzJQddWSF//kpOlHCmsCoaNIOjt/UrHoGlPzx/g8LsaRyV9nZiI HtUhp7xaUPKjLMWbNgkduFKWS4LDL9kiFQ5Dh12zCnH2pG6HNcuSYDKhsu7eWBciyh7e jk+ZRHXQgRgTT5U5iuuxj9Xs6BszIJSSbJwbBUm4AgJJM9Kp1iKUoUGMGMYVImjwBnPg ExoDppTRna+zCeTdQ0zGuHFlPzlRIARCrSzIoJyCZqMjRUYuJ8aQQZZINMQ0uKBEHGKR XgwUmviMsfNWNBvFDilE0w9FiEpEqJQlRlMqmMsQt41MosAd9nLU/mb/EKE5ByHqSICF FFxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786073012; x=1786677812; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T5tWYfkrSYEAFJzgjYou2Lj+31bzExLORMbEtdMFcLw=; b=gD2IQQlTfn6UZbIh8j9W7SzmyLtn44TqzWv71evRS4kVDb5G3yyCHBev8z9Ute6Ngr Yvw74QPbkk73z4ZYyK0xEwJK10hU2q9YiVHiwdomTCZwED684ArGXKUoNO6EyW4xjktU QPOn3gp0hyLIM3+Csc4/4U/6bYp+lLhuRATJHqYppqZpYOJFgYiCh8DRHEGB8R8QyI2e mNACg7Yge2/+Mi6Ock6YqE2j9+oiZakQZa4uu7Qnvo9rlOPfgIzPru/8xOyHIn36hLDJ ao8Q2dtuHHHRSVICkUf1cSclhReAtq7hqtUZkN9ffUNdSGPnxv44gq3lJQ4qNKtRmc7+ AZKA== X-Forwarded-Encrypted: i=1; AHgh+RpcElaMLWmbEakA4zuqHOUDmj85H7drWTznBrHfP8liIBujiEBo3wEk3RVw02bZgBo/+Fe1yEbGQBc=@lists.xenproject.org X-Gm-Message-State: AOJu0YwyzAw0k9Jw2i4u5WmQBEGnRxmXi16yQ4eFLcrFsNjIsKisgx3o kEB3MdUy7evKl2/jspocY9QWJ4muRRLkLpMxZk99c2BP4cZcgAuESzH2 X-Gm-Gg: AR+sD13iYVBdptK2G5BYPyijNXD2ybPPdixxc5uMPPYCmd31E66ZoBCpm0MeHNf645d KSvEIKsJAPWuY3QgLaOjLGvMK3YMuP4PJrBNnzt0kqlNIDzRkDKFNttzbGvGTXQW2ZSagumzTmY XaSuywRXrLfviI8B9RMynOoy8caU7YrYIm8Jo3DMueuLEZySgFhwoHxvGvHq76Nx9+/1EJ+pVYs heRpXWiobNYIrx1j/MQnq6+7X7ZO7VpYu/2e1r1Q7qh/unfGHaa43mTck72WIMnWnz07wXo4c6Q Bnpyv608zJbSTuT6gKjl4gnjpUv/pavwsEaAfD5Mxz/RzMKjv+vzMBT+fwgxDCArZIO7dEZEFx5 LUjL8Fqtuoo0pU06fy/pj0HBXJYFmkFb4ue4tGiS/SSMyPzcOEQ1JcXjE2WXqgWM+h8Xd61m2Cy ZWKTZNemXSRVdt9N+pB2VjpEVXd0RP5ai2WKvY8L01KWmGYUeWa7QkYn2yaIcdGPDsiX3A0PyK7 LfOJiq+5w8WoXsJiP8U8c06FoO3e9flcQuo95oXb4476qhfxf1atg5B7S2HinI= X-Received: by 2002:a05:622a:8cb:b0:51c:d1c:10e3 with SMTP id d75a77b69052e-52ce619a1c0mr217368161cf.35.1786073012343; Thu, 06 Aug 2026 20:23:32 -0700 (PDT) From: Yuho Choi To: jgross@suse.com Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, thorsten.blum@linux.dev, jason.andryuk@amd.com, alhouseenyousef@gmail.com, kees@kernel.org, darwi@linutronix.de, jpoimboe@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, alhouseenyoursef@gmail.com, Yuho Choi Subject: [PATCH v1] xenbus: Unregister reboot notifier on init failure Date: Thu, 6 Aug 2026 23:23:26 -0400 Message-ID: <20260807032326.940377-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1786073013-502F0CFC-77C0471A/0/0 X-purgate-type: clean X-purgate-size: 1551 xs_init() registers xs_reboot_nb before initializing XenStore communications and starting xenwatch. If either operation fails, the notifier remains registered and a later initialization attempt can hit a duplicate registration. Check the notifier registration result and unregister it on every subsequent failure path. Fixes: fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") Signed-off-by: Yuho Choi --- drivers/xen/xenbus/xenbus_xs.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c index d1cca4acb6f3..62274d377b3a 100644 --- a/drivers/xen/xenbus/xenbus_xs.c +++ b/drivers/xen/xenbus/xenbus_xs.c @@ -915,19 +915,27 @@ int xs_init(void) int err; struct task_struct *task; - register_reboot_notifier(&xs_reboot_nb); + err = register_reboot_notifier(&xs_reboot_nb); + if (err) + return err; /* Initialize the shared memory rings to talk to xenstored */ err = xb_init_comms(); if (err) - return err; + goto err_unregister_reboot_notifier; task = kthread_run(xenwatch_thread, NULL, "xenwatch"); - if (IS_ERR(task)) - return PTR_ERR(task); + if (IS_ERR(task)) { + err = PTR_ERR(task); + goto err_unregister_reboot_notifier; + } /* shutdown watches for kexec boot */ xs_reset_watches(); return 0; + +err_unregister_reboot_notifier: + unregister_reboot_notifier(&xs_reboot_nb); + return err; } -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 06:23:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 06:23:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385762.1628159 (Exim 4.92) (envelope-from ) id 1wsDyi-0006NO-4x; Fri, 07 Aug 2026 06:22:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385762.1628159; Fri, 07 Aug 2026 06:22:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsDyi-0006NH-1s; Fri, 07 Aug 2026 06:22:48 +0000 Received: by outflank-mailman (input) for mailman id 1385762; Fri, 07 Aug 2026 06:22:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsDyh-0006N9-3p for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 06:22:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsDyg-009zRA-CJ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 08:22:46 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7579ad-e002-0a2a0a5209dd-0a2a4506a050-6 for ; Fri, 07 Aug 2026 08:22:46 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7579b6-195a-0a2a45060019-d1558031d130-3 for ; Fri, 07 Aug 2026 08:22:46 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4995b0343c1so6166875e9.3 for ; Thu, 06 Aug 2026 23:22:46 -0700 (PDT) Received: from ?IPV6:2003:ca:b70d:300d:c60:b520:be19:f863? (p200300cab70d300d0c60b520be19f863.dip0.t-ipconnect.de. [2003:ca:b70d:300d:c60:b520:be19:f863]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995ea2d84csm7397145e9.12.2026.08.06.23.22.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 23:22:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786083766; x=1786688566; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2Mju8ec2JsULKhgYsZxe4dHqgEj7FEBGGh4W6raF2x0=; b=aFb6OKuPHp38Vnm3K/ztincFsJ6AnlKzVeGrBp+CZQZYrCmpTPevw5/GmPOv9RqDIf z6Pzv8WfiawoaTA2EdNMa7S5mfgSmseVKl9uIFgPi69K6Tz0iaVveG6ks4HrY+YqD5hT ynFrcnzIFgIS/YMwAhca2W8WFHnrlLeYTsBCNRAlXmsTkQWWckzFscOQ+GyABqWgEpXS C3UueuYuGf30jnCilqdt8wQFV9YMRQxAngLFDLSBjCN6zNItILpB26/8CAyOjtJlrkYa uGII/8Va0+fhDs5YVr+8bNK8DDVhMI9ItAG8e4OH0yBaedxX95H0Lr5T/lXRRySwvIDD aBHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786083766; x=1786688566; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2Mju8ec2JsULKhgYsZxe4dHqgEj7FEBGGh4W6raF2x0=; b=l1FF8xIXuJP1P9ZumO1d2znM4LAgAZJRqMp5+GN5hHuaC8bqrBf61mYDJUWSU/drvm 9UIFaZByt8uPk0MXIDiVvv4nNHI234XEBpotReJhygZP7c5/xERbUyrXr5shmRmCnGB8 TChYGpCos4/4Ep0C8eOqMRjrZ7qrgqSveii+kVFJwWKWOiEOQFXIKu54DQdPLnlYkImH BfpacMfoId2cMOHYT/G3Jhn8NZjDG4cOCiCWbpJe/Zu06jKYb84LSrIttzHZl3mKokZF Zaitrc4kx77Wv7hELmjh8fPTyHaCiFEfnthQJ95u5nEP7JvGGauRy3bifnUKI6OfGlA5 jLLg== X-Forwarded-Encrypted: i=1; AHgh+Rqo3PhH0J+UhsQWAVINLkUafapKkyKMHsUFdd7NjkPXRHSW6yNjCKVfGrtT3adgurEeT/aMCNRLayo=@lists.xenproject.org X-Gm-Message-State: AOJu0YyYwYslfZEmzuHVWS2fS/HJzDTR1KAV/pi4/XioElbdaqr0xOkQ 03Teydyz6iCG1WoR5zIQBhTVHf0slDpJKJnYb0pWb26gERPatcyGvKVBiAIv74S97NVi4onP1fN LeYQ= X-Gm-Gg: AR+sD11vFDdVezDIwOCN3IiWDFpFZWwjs8XeX+t4SCILtmtU0JLYoQHthzCXTDhIyjp E9Uxc5uxPGiu5LzdOUSifhslLNeDpxDMiEU6veuvhBQReOk4phpcmziKeW4u+pdGUG7Knn+e11E LTqzII2Np4XPIyeXZStPVTNinQydx2fZHfohxXQQ59oqbyjzDEF0840rpYW/L2oE1wD/16TK2T/ LEAco4BO3+1AyVhSqsJ/MKqaqg5wHmFGl+DNxwLg/mK+MtHHkLf9IlLUd4bcl+ado8pqYq/tNz+ 71Lfz+/qVIKzbtmAvO7YNvBBTs6+5J7VVWkvasEfi0D37SHdloJDI5HPOsfxTeFgOIHJcVvOGFN cCZ6z50sbjk/HVewjFC+/b2io4pWC088ATGqPEJ79jRXYJpMO/O8b2aSKN+TlMjOzikX9zR1DRq 8iuIzqHS/JERaX29J2DF0U5HeFbSXjWBOptktT8HFDqxEAsITQ0qnXAmma2efQ+MRrIj0dH6Lsf 2+8vfbOgVQ8T0Qvf/9mdAKEGqNihxBiJisWZj4LxyFs4wXZz7emkgYsAi5nwtHegnlZHtC37Fs4 Hk2dV468UmyvVcvY3L8= X-Received: by 2002:a05:600c:198f:b0:492:4e09:9fc1 with SMTP id 5b1f17b1804b1-4994e7cc5a4mr272904255e9.15.1786083765693; Thu, 06 Aug 2026 23:22:45 -0700 (PDT) Message-ID: Date: Fri, 7 Aug 2026 08:22:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] x86/pci: prevent cross-device accesses in pci_mmcfg_{read,write}() To: Roger Pau Monne Cc: Andrew Cooper , Teddy Astie , xen-devel@lists.xenproject.org References: <20260806152619.23881-1-roger@xenproject.org> <20260806152619.23881-2-roger@xenproject.org> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260806152619.23881-2-roger@xenproject.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-16d1c6/1786083766-FD20877B-0B928D98/0/0 X-purgate-type: clean X-purgate-size: 1528 On 06.08.2026 17:26, Roger Pau Monne wrote: > Introduce a specific check that prevents an accesses from spilling across > two devices. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich albeit with a remark: > --- a/xen/arch/x86/x86_64/mmconfig_64.c > +++ b/xen/arch/x86/x86_64/mmconfig_64.c > @@ -61,7 +61,8 @@ int pci_mmcfg_read(unsigned int seg, unsigned int bus, > char __iomem *addr; > > /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ > - if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) { > + if (unlikely((bus > 255) || (devfn > 255) || > + (reg + len > PCI_CFG_SPACE_EXP_SIZE))) { > err: *value = -1; > return -EINVAL; > } > @@ -91,7 +92,8 @@ int pci_mmcfg_write(unsigned int seg, unsigned int bus, > char __iomem *addr; > > /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ > - if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) > + if (unlikely((bus > 255) || (devfn > 255) || > + (reg + len > PCI_CFG_SPACE_EXP_SIZE))) > return -EINVAL; > > addr = pci_dev_base(seg, bus, devfn); In both cases the unlikely() uses won't have the intended effect, from all I know. They would help as used here only if the compiler managed to fold all three parts of the ||-expression into a single conditional branch, which I don't think it would end up doing. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 06:40:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 06:40:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385772.1628170 (Exim 4.92) (envelope-from ) id 1wsEFS-0001uN-J8; Fri, 07 Aug 2026 06:40:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385772.1628170; Fri, 07 Aug 2026 06:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsEFS-0001uF-EY; Fri, 07 Aug 2026 06:40:06 +0000 Received: by outflank-mailman (input) for mailman id 1385772; Fri, 07 Aug 2026 06:40:05 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsEFR-0001g4-5m for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 06:40:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsEFQ-002pOb-HF for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 08:40:04 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a757dbc-bab6-0a2a0a5309dd-0a2a4508c8e0-8 for ; Fri, 07 Aug 2026 08:40:00 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a757dc0-f659-0a2a45080019-d1558032b01a-3 for ; Fri, 07 Aug 2026 08:40:00 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4954d29264cso15562365e9.2 for ; Thu, 06 Aug 2026 23:40:00 -0700 (PDT) Received: from ?IPV6:2003:ca:b70d:300d:c60:b520:be19:f863? (p200300cab70d300d0c60b520be19f863.dip0.t-ipconnect.de. [2003:ca:b70d:300d:c60:b520:be19:f863]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48002206effsm2648301f8f.32.2026.08.06.23.39.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 23:39:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786084800; x=1786689600; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Zpl041G9bgvH6HkJ+ZJLgBdw/y0qwr5ssc4m7Dc70ag=; b=JSXapQwAvzEr+zCvkg+nhPdobWfH2z8yDn26/yF1oucTxa4JJB4FST943JdTvkkxqf cOVHJAlu+BaYoDwZYeOPIskwWHfwvob6+QGWZg2cn/75z7NAKtUI8KQqZ69sP9iOXEZr WjAWuZEw47Bip+yNzUSokwJXyKu/c/S+/4av4l2XKjwVfjyOYMlwTUCUo6zViTI/2FOP KJwMCXm+NMgLmI5Tdv+lzccZmLMrW0TWr5GbWuXWxoHFLzOg5jAH/yd6vtNJhJZ1TokX 1c9LPipJN7N1gjHQsGnzoyQws18kuDryRWIJElp5A8H4Qf33rAdrgTKTgCT4H2Oz0DUf GUPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786084800; x=1786689600; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Zpl041G9bgvH6HkJ+ZJLgBdw/y0qwr5ssc4m7Dc70ag=; b=OODCyslZq/pNhEptAOxmSx2Nk/UXSp/IZQnlm877sMqZOhsDSejgwTYHnNiLIOEnzs yQEqk2Z6F6wXmDtaEXu/B1AH2zlt7p1ieLm8TBa/IAKGVORA00LxHNqTIn5OVr14PzW6 8stV1eVf+ypHPRY6P73pWP5QEf7h62Ilo6HKTaZOLRFbxKEmpCCt/rDwq+UdD6eX6w5z SpxdC2Bgrs3PBEcBPWEsAGw+3UgjVbJRmhXNh/5HllTOd2Om16RTfpwk3qY7StaWBFyt 8zzYplzdI7RzwXxWpfG0KNh8pKWOojKaNUkTU5WYZIv3+dXtlQn6vvUai5618PWu2vPR w6AQ== X-Forwarded-Encrypted: i=1; AHgh+RqKVCoOw5v/sp+t6oD1bEAHyncz7n8E0WH4gAUKAEynaikXjols3+nO8VGfsFbmPtsc7GdJACgUrtE=@lists.xenproject.org X-Gm-Message-State: AOJu0Yyy874pry3Ga4Ci7lVw6fSxWEinokM7QINzuyJgV/Qy8QCXM1j+ Ld7qvSI8p34BgRh3jx1fTkMtXxUTCo8Z7/mQ5IsS45RYF04Ypva470fC5CGYxcv43w== X-Gm-Gg: AR+sD10ixeQLUe1SsAgT7LR5ICDMAuTSolgvJbVM7JNkXv1lat4B7xV328xfPsKcoe1 VEr+y0Sj6Su5tYxjlSQRGFWcJ9NBf/n+s7SJQXszXgfeWgqXlKasHBtFb2kLjT9tq1UaBFL92vU 1KhNFoqOu8rHJHfAYapOagM8gd0BSK93Tue8IseaX9GSv6fpw++2hxgVmblyQ8wpUx9r1RSNUnG euU0sAgNd71fThCx1jBy8IZrIyZUL1RBQeDdlKAm0Y96AjrHLeBWxd71T8mGVVnAdbJK/bIYViQ Q0/pv6cen1V9xVBvW1kQuLffjMQDa8YqGhLcxFU9hohd6Yj4CrJLpRtUAnP55vkAVe0w7nzdVrc zOAsXZKZyneiJiqbMtUdaI9T2qb+AK6JSBacLbmd+2kED8f04XULuPluLvP7hcoskoWC1P/SIv8 t6Ze37J9cCMS+KU41lRvH9SlUvjWj4gvvHGBRu0jDmGbBn4nfKy5Ri4X+Ew1rLFYtWMoKCpEc5I qyJvgGPY0kKRj3DT0/buG0g8yDnFog2SixsfQrGLkPpBX/pRCR+SfYLgS/3fsVs3rMi3OnLzynL E+gynpTah4IaM8egViw= X-Received: by 2002:a05:600c:5246:b0:495:52dc:73a9 with SMTP id 5b1f17b1804b1-4994e7ba79dmr240349585e9.11.1786084799851; Thu, 06 Aug 2026 23:39:59 -0700 (PDT) Message-ID: <62a2d0ec-648c-4b2b-b456-077d3967771f@suse.com> Date: Fri, 7 Aug 2026 08:39:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] xen/vpci: allow unaligned accesses by the hardware domain To: Roger Pau Monne Cc: Anthony PERARD , Andrew Cooper , Teddy Astie , Stewart Hildebrand , Jason Andryuk , xen-devel@lists.xenproject.org References: <20260806152619.23881-1-roger@xenproject.org> <20260806152619.23881-3-roger@xenproject.org> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260806152619.23881-3-roger@xenproject.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c1860d/1786084800-CE34587B-00B02BB7/0/0 X-purgate-type: clean X-purgate-size: 1115 On 06.08.2026 17:26, Roger Pau Monne wrote: > It's possible for domains to generate unaligned PCI config space accesses > when using ECAM, and hence vPCI should support those at least for the > hardware domain. Such unaligned accesses to the PCI config space have been > reported to come from ACPI logic. > > Relax the checking in vpci_access_allowed() to allow such accesses for the > hardware domain, and fix the handling in pci_conf_{read,write}{16,32}() to > fulfill them using MMCFG. > > MMCFG regions are identity exposed to the hardware domain, and hence such > unaligned accesses can only come as a result of the host having MMCFG in the > first place, as otherwise MMCFG won't be exposed to the hardware domain > either. > > Note that vpci_ecam_{read,write}() already refuse accesses that cross a > device boundary unconditionally. > > Reported-by: Jason Andryuk > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Albeit without the intent to override possible remaining objections by Andrew. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 06:59:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 06:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385781.1628178 (Exim 4.92) (envelope-from ) id 1wsEXz-0005Cn-1d; Fri, 07 Aug 2026 06:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385781.1628178; Fri, 07 Aug 2026 06:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsEXy-0005Cg-V8; Fri, 07 Aug 2026 06:59:14 +0000 Received: by outflank-mailman (input) for mailman id 1385781; Fri, 07 Aug 2026 06:59:14 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsEXx-0005Ca-T6 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 06:59:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsEXx-00A4qv-9T for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 08:59:13 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a758240-2eae-0a2a0a5409dd-0a2a4509baf2-2 for ; Fri, 07 Aug 2026 08:59:13 +0200 Received: from [148.163.158.5] (helo=mx0b-001b2d01.pphosted.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a75823f-be1a-0a2a45090019-94a39e05d40c-3 for ; Fri, 07 Aug 2026 08:59:12 +0200 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6770Huoo016275; Fri, 7 Aug 2026 06:58:32 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fvy00am7a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2026 06:58:32 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6776uLDe003221; Fri, 7 Aug 2026 06:58:31 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4fsu4qxspg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2026 06:58:31 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6776wSir33882500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Aug 2026 06:58:29 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D3B0620040; Fri, 7 Aug 2026 06:58:28 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4351E20043; Fri, 7 Aug 2026 06:58:26 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.111.55.180]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 7 Aug 2026 06:58:26 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=pp1 header.d=ibm.com header.i="@ibm.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=Ra4H8CAbtiN9wPr1aKFBAag6HNf0qB uveAYY5O5upyA=; b=b6abVgzghGiyJP2Wlz0QxQ4Xlm4EEGD9Kpi/bbrlqUSFBE peaClBZE7a6uUDxpMzlqxLdBYmzJ2Zv0Gov1Z/ABs95zQALrNBxETA0/pEucil/j W+YyJwlwpe3OK1MAOCII7fcp3YeD9G589urjh/7H6praJpDu3PDyifCYlbxg55Wq kegIhHrXFaKgEStmSWQn7LYsur2nUZn/xPNaUh2EUQxX/E75LETTqXwjtCkcIvTM 6z2V+hipWhFW5E/1SdFcNJm3hHGg12nD12POK8woGUy/Cd3cVuoSGV0jyJiT1nQe XgoPgNhStcc1pjBG2Dfbs0hQJW5cw8oy/wETB5bQ== Date: Fri, 7 Aug 2026 08:58:24 +0200 From: Alexander Gordeev To: Muhammad Usama Anjum Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 6/9] mm: convert PTE table entry to pte Message-ID: References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-7-usama.anjum@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806083926.1807279-7-usama.anjum@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDA0OSBTYWx0ZWRfX3Npn1dSDlp+R fqhR9MpXZOAAKnyVJ8e3VxdJ3uPpsfM7vsZzpddpvCei+hGCUgHlBFVERXxX+W23gcpS04A1TAu ZsTRXf6ZMD17BVZmsTCM0lUCa3PumjU= X-Authority-Analysis: v=2.4 cv=VPTtWdPX c=1 sm=1 tr=0 ts=6a758218 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VwQbUJbxAAAA:8 a=7CQSdrXTAAAA:8 a=VnNF1IyMAAAA:8 a=MkxDnzPc83ckttyupOUA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-ORIG-GUID: 9g22-5Yiq-VIyR9utDe_g8M8U8wsuEOd X-Proofpoint-GUID: 9g22-5Yiq-VIyR9utDe_g8M8U8wsuEOd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDA0OSBTYWx0ZWRfX4qeGdjjX3Iob oR2d/W90tNYt47jYoawp2wnB7y1FcZkNxxg7/PT57hDZR5feFluugIlRZ22mBQ/td/U5spNK5Sw r8fBBZDJMOMHDyBDHn28hS5vFD1IBzJcw9uh6xxZ9XoecZCsQnhJUSSf9noMzRB2RMvDZxhPIkf XMKQ1X4w4JsUHL/vsYXt9nxlaz1I/q7ljQgCtXwMvAVt1kijbs35mMQ7c76oGi39I1XSIpxXjmb kIMcLde1EyTpmQmaPbN+E3LbUk4M/lkkgjjjvsZIBgTXWy3e0GMD7NaUrStoYwo4ESb8Z4Wsdqh +581CUAUBwBVUa2TokmdsZzGbrL67tdrfft71SfQsy0ZlWFNR+iL1PR2Oez6zshpb+e7rynA9dG f8FbSxO38FmGhTq0nvrdQcjHK2fKXR2vKx64CE0UHGLhgbh7cUWWpBSkiNUoiKjHZV0BphvCO4H jlupay2/A2mIbK8uZUQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_01,2026-08-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070049 X-purgate-ID: tlsNG-bad1c0/1786085953-BC6CA034-5FC34A1E/0/0 X-purgate-type: clean X-purgate-size: 1822 On Thu, Aug 06, 2026 at 09:38:44AM +0100, Muhammad Usama Anjum wrote: > The non-MMU stub receives hw_pte_t but returns a logical pte_t > value. Convert the stored entry through __pte_from_hw() before > returning. > > Signed-off-by: Muhammad Usama Anjum > --- > include/linux/hugetlb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index bc0b9c65aa1d0..9e8b391aa4bc9 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -1283,7 +1283,7 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, > #ifdef CONFIG_MMU > return ptep_get(ptep); > #else > - return *ptep; > + return __pte_from_hw(*ptep); But this is a direct dereferencing, which breaks the whole point, isn't it? What about introducing something like pte_t ptep_get_sw(hw_pte_t *ptep) to be used in exactly situations like this? With that the semantics of hw_pte_t pointers becomes straightforward and closes the still ongoing "storage vs lifetime" discussion: hw_pte_t* points to HW-formatted page table entries ptep_get() is used to obtain HW-linked/attached entries, and may wire extra code like [1] or [2] ptep_get_sw() is used to obtain HW-unlinked/unattached entries and in most cases is just a direct dereference The caller should always know whether the entry is attached or not, so confusions like [3] are avoided. 1. https://lore.kernel.org/linux-mm/20260526-kpkeys-v8-21-eaaacdacc67c@arm.com/ 2. https://lore.kernel.org/linux-s390/650903a4-0dd9-4e6b-9d4b-3c32c5657236-agordeev@linux.ibm.com/ 3. https://lore.kernel.org/linux-s390/b44e071d-7c9d-4e7e-a84d-4af3499a5a05@arm.com/ > #endif > } > > -- > 2.47.3 > From xen-devel-bounces@lists.xenproject.org Fri Aug 07 07:10:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 07:10:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385791.1628186 (Exim 4.92) (envelope-from ) id 1wsEiN-0007oo-1a; Fri, 07 Aug 2026 07:09:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385791.1628186; Fri, 07 Aug 2026 07:09:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsEiM-0007oh-V2; Fri, 07 Aug 2026 07:09:58 +0000 Received: by outflank-mailman (input) for mailman id 1385791; Fri, 07 Aug 2026 07:09:57 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsEiK-0007ob-VU for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 07:09:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsEiH-00604c-VG for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 09:09:53 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7584b8-2eae-0a2a0a5409dd-0a2a450cdfc0-10 for ; Fri, 07 Aug 2026 09:09:53 +0200 Received: from [148.163.158.5] (helo=mx0b-001b2d01.pphosted.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7584c0-f479-0a2a450c0019-94a39e059bbc-3 for ; Fri, 07 Aug 2026 09:09:53 +0200 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6770JZQv4064146; Fri, 7 Aug 2026 07:09:19 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fvy02anmy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2026 07:09:18 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6776uIAD024920; Fri, 7 Aug 2026 07:09:17 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fsvmhpmkb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2026 07:09:17 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67779F7T51315084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Aug 2026 07:09:15 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 668A020040; Fri, 7 Aug 2026 07:09:15 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA50320043; Fri, 7 Aug 2026 07:09:12 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.111.55.180]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 7 Aug 2026 07:09:12 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=pp1 header.d=ibm.com header.i="@ibm.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=jpeOcxycXBTAlw8xEd8qyVhgpwcjWF NB4soWtck85Pw=; b=Qh6BCzQcqD/AGOqi1hTQHgQVz6HuWuBJB87Gbu8R2QRIrL ftEfzBmybSkNntrd41XE524cbuEjupU7byCqaB7YxW9kBgydkUCxBhrhTSiwT6H+ U4OKIllzATyLLGfNArjEOqj0akgLZ0asqOkSM0XKJyYYoIst8JvDseeB2sH706u4 hhs9ueI6JSC+Ld/f6qPFOuLXDpab+v18Jf4LeEQIr4j5+MFCFi1kjnwg8/MvRqx/ KhT+u3vzeF7qrRG7dH6ram2Pu9RQGcAByOzaawNWn2aii58OGSRM1hM7xmzHRjNe Si5vdvDt7lOVvC8K31hkxayAWljo7JjlQf3ZTeQg== Date: Fri, 7 Aug 2026 09:09:11 +0200 From: Alexander Gordeev To: Muhammad Usama Anjum Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 1/9] mm: introduce hw_pte_t for PTE table storage Message-ID: <3db8233c-3785-444e-b2eb-3e5fc5cb2f17-agordeev@linux.ibm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-2-usama.anjum@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806083926.1807279-2-usama.anjum@arm.com> X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=G6ws1dk5 c=1 sm=1 tr=0 ts=6a75849e cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=7CQSdrXTAAAA:8 a=knT6YJskkHJV9nTHl7IA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDA0OSBTYWx0ZWRfX0nP+lx57+9VF 1gmEHMdPT9FDdcpiQyi8SmdcwszvdSJS7mABzCaLeNrHd5Sn8+sTGSPk7wgKar3hoAN1E4B/pVx bnXvboS9h3/hfmNoqiGrVCRZoMjtdCQHGGcTi/BUQBFwhU3T8reyBMtbDszvLlwmh+wtmaSZLqp yvHKwixzlq6G3K0WuaMTKb0rV/vx4p/+UD+c1HQ1XyaQGUDlAtP+qGdAxuohRKj+obB6JSz4pJf zR2/7yIz+BcCrmWWxRtyEAkQu5yJbla8dkOuZTNT+Te2QfvIou3iP7qEQNN4GRIU2Q5uHMR6b+I Dj47k0jZ1vEd4+qsmknTL/rQ5DO0GSFvsjQsVYtZ2xV19zVeKyvXq+fRINOYMQUEmIHFL/MkEMn a61cmrTNbkwX+us4u3c+MP3DMEixACEHjWeKrnFUAYotTcrys6EiCMj8gXkAJjhYM+ZfvANLuAs LDq51urlTaBYjwemYPw== X-Proofpoint-ORIG-GUID: 24rCQEgxgE9QBP75I4HmK7CgK28n9dSJ X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDA0OSBTYWx0ZWRfX1i5aYO825ZYa TwQN6H3jwP2QZ+OLP/IGdT3C7Slc5GOjV5747KQtgAdatwi/16p60JYaM2efb4DysHgyipihWtH 8fPlfABrpBSxaw7p4kLOdK2+bYjkzog= X-Proofpoint-GUID: 24rCQEgxgE9QBP75I4HmK7CgK28n9dSJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_01,2026-08-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070049 X-purgate-ID: tlsNG-d25034/1786086593-030D9A5B-0DAC0A19/0/0 X-purgate-type: clean X-purgate-size: 3174 On Thu, Aug 06, 2026 at 09:38:39AM +0100, Muhammad Usama Anjum wrote: > pte_t is used both for logical PTE values and for entries stored in a PTE > table, so pte_t * does not distinguish a pointer to a copied value from a > pointer to table storage. > > Introduce hw_pte_t as the generic name for a PTE table element. Define it > as a macro alias of pte_t by default. When an architecture selects > ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead. > This preserves the representation while allowing converted architectures > to enforce the distinction at compile time. > > Keep the C type definitions behind an __ASSEMBLY__ check because > architecture assembly sources can include this header indirectly. Include > asm/page.h so consumers such as linux/vmalloc.h retain the page definitions > they previously obtained from that header. > > Signed-off-by: Muhammad Usama Anjum > --- > Changes since RFC v1: > - Add the ARCH_HAS_HW_PTE_T opt-in and generic wrapper definition. > - Exclude the C type definitions from assembly sources. > - Update the description for the new opt-in model. > --- > MAINTAINERS | 1 + > include/linux/pgtable_types.h | 17 +++++++++++++++++ > mm/Kconfig | 3 +++ > 3 files changed, 21 insertions(+) > create mode 100644 include/linux/pgtable_types.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index e9c8567308a75..7169bea968cf5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16982,6 +16982,7 @@ F: include/linux/mmu_notifier.h > F: include/linux/pagewalk.h > F: include/linux/pgalloc.h > F: include/linux/pgtable.h > +F: include/linux/pgtable_types.h > F: include/linux/ptdump.h > F: include/linux/vmpressure.h > F: include/linux/vmstat.h > diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h > new file mode 100644 > index 0000000000000..70c3edd00a01b > --- /dev/null > +++ b/include/linux/pgtable_types.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_PGTABLE_TYPES_H > +#define _LINUX_PGTABLE_TYPES_H > + > +#include > + > +#ifndef __ASSEMBLY__ > + > +#ifdef CONFIG_ARCH_HAS_HW_PTE_T > +typedef struct { pte_t __pte; } hw_pte_t; On s390 it fails to compile once we do typedef hw_pte_t *pgtable_t in asm/page.h. m68k, powerpc and sparc may also have such problem. The below declaration helps to resolve it using forward declaration and without meddling with headers, though I do not like it much: typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; > +#else > +#define hw_pte_t pte_t > +#endif > + > +#endif /* !__ASSEMBLY__ */ > + > +#endif /* _LINUX_PGTABLE_TYPES_H */ > diff --git a/mm/Kconfig b/mm/Kconfig > index 331daf7fcfab5..31ba9ebf4aafd 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1316,6 +1316,9 @@ comment "GUP_TEST needs to have DEBUG_FS enabled" > config GUP_GET_PXX_LOW_HIGH > bool > > +config ARCH_HAS_HW_PTE_T > + bool > + > config DMAPOOL_TEST > tristate "Enable a module to run time tests on dma_pool" > depends on HAS_DMA > -- > 2.47.3 > From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:01:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 08:01:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385819.1628197 (Exim 4.92) (envelope-from ) id 1wsFWK-0002Bj-9X; Fri, 07 Aug 2026 08:01:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385819.1628197; Fri, 07 Aug 2026 08:01:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsFWK-0002Bc-5w; Fri, 07 Aug 2026 08:01:36 +0000 Received: by outflank-mailman (input) for mailman id 1385819; Fri, 07 Aug 2026 08:01:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsFWJ-0002BS-BQ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 08:01:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wsFWH-009ZSo-2l; Fri, 07 Aug 2026 08:01:33 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wsFWH-006LIO-0i; Fri, 07 Aug 2026 08:01:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=jiIZkAdiXaojC9R+XVALoX8ou523o/rMMDXXJG8HhLk=; b=AJ+PSt3VdhGDN7nodq+ohX29Vk rJmfvtCMZ6Zgor4Al/IKLlYAZlqDmcUrd7TiDG2S1VBNb9QKk9DUYxUh2iHoqYrSyEGNuseulGmop y3/SnZeyO9M3/Lq+9pxhRbs3lGxlA/CI28pak5Di2QZp+1bpfAp8WyJeFmXXEk0TMmYI=; Date: Fri, 7 Aug 2026 10:01:27 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Teddy Astie , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 1/2] x86/pci: prevent cross-device accesses in pci_mmcfg_{read,write}() Message-ID: References: <20260806152619.23881-1-roger@xenproject.org> <20260806152619.23881-2-roger@xenproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Aug 07, 2026 at 08:22:44AM +0200, Jan Beulich wrote: > On 06.08.2026 17:26, Roger Pau Monne wrote: > > Introduce a specific check that prevents an accesses from spilling across > > two devices. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > albeit with a remark: > > > --- a/xen/arch/x86/x86_64/mmconfig_64.c > > +++ b/xen/arch/x86/x86_64/mmconfig_64.c > > @@ -61,7 +61,8 @@ int pci_mmcfg_read(unsigned int seg, unsigned int bus, > > char __iomem *addr; > > > > /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ > > - if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) { > > + if (unlikely((bus > 255) || (devfn > 255) || > > + (reg + len > PCI_CFG_SPACE_EXP_SIZE))) { > > err: *value = -1; > > return -EINVAL; > > } > > @@ -91,7 +92,8 @@ int pci_mmcfg_write(unsigned int seg, unsigned int bus, > > char __iomem *addr; > > > > /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ > > - if (unlikely((bus > 255) || (devfn > 255) || (reg > 4095))) > > + if (unlikely((bus > 255) || (devfn > 255) || > > + (reg + len > PCI_CFG_SPACE_EXP_SIZE))) > > return -EINVAL; > > > > addr = pci_dev_base(seg, bus, devfn); > > In both cases the unlikely() uses won't have the intended effect, from all I > know. They would help as used here only if the compiler managed to fold all > three parts of the ||-expression into a single conditional branch, which I > don't think it would end up doing. I don't mind dropping the unlikely() while changing the line. I tend to leave those alone if present, even when I'm not sure they are actually helpful. The comment ahead of the check is also not very useful IMO, but I've decided to leave it alone. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Aug 07 08:08:55 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 08:08:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385832.1628205 (Exim 4.92) (envelope-from ) id 1wsFdK-0003RW-V8; Fri, 07 Aug 2026 08:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385832.1628205; Fri, 07 Aug 2026 08:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsFdK-0003RP-SS; Fri, 07 Aug 2026 08:08:50 +0000 Received: by outflank-mailman (input) for mailman id 1385832; Fri, 07 Aug 2026 08:08:49 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsFdJ-0003Pv-AV for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 08:08:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsFdI-006B0U-B4 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 10:08:48 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a75928f-bab6-0a2a0a5309dd-0a2a4502c0aa-0 for ; Fri, 07 Aug 2026 10:08:47 +0200 Received: from [40.93.198.2] (helo=CY7PR03CU001.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a75928d-6ca4-0a2a45020019-285dc6022029-3 for ; Fri, 07 Aug 2026 10:08:47 +0200 Received: from PH7PR12MB6467.namprd12.prod.outlook.com (2603:10b6:510:1f5::14) by SN7PR12MB7346.namprd12.prod.outlook.com (2603:10b6:806:299::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.23; Fri, 7 Aug 2026 08:08:41 +0000 Received: from PH7PR12MB6467.namprd12.prod.outlook.com ([fe80::7b8:36ff:4c76:46de]) by PH7PR12MB6467.namprd12.prod.outlook.com ([fe80::7b8:36ff:4c76:46de%6]) with mapi id 15.21.0292.019; Fri, 7 Aug 2026 08:08:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=woM3NgpM3IidDHJtcHG76LyptG9cHNCLdJe8t4awZ1RimG1eeHx5r7Wcq7J/2E8klYapX2ifihugV9rSbXpZjZE/fv1cy8dD8qp9YSP+QwkkYtNk1eMKqylbEE9twth5I3WLRPmPxIOpcG1Fhzmca2eOexOjKFfoOsdtDZ68ML2lSYViMk0IOljnf2NvCV2B1IUe43PkF7TKot/GyjFtAijRE+TcwkS0YloZxwnj8AXEDQ4LxUDdHcXjMkE05PMtwRSCVyS/nxCpzlh/aTHdordzhJre69rwBAoD6F+6auUvxFXaKE1pTHlA4zZwEcGwaoXZ3xF84oPRFG2zFkn6iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LuG3C0E+vQjBn+CrawwxKulOSJySFub1hoxtYYsjEb0=; b=tmeEmLCdK4kgo4w9zYL00RM5scGa+OqMYTkq/dNk2/41rZUwqf1uPzzErIsg+dfMfOQcafp8MOzd6LWAeh4WzDEnIjkROpqgWwTgbGu7b+edxMfusKh7Fhy8z2s32eMOBTDLhyNujKQSvx40Pd7ewXtNtYnHbkOpZ8JG5as+bcGZWgFac+kyrGJ48UIC9wLY+PO/TD2B6zuSUA0xNoaFcY2L0aO9bVLCtJtNjxCm04XANmzLHw5cL/pQSy+U0rZgWOE4hIS3Qgu8FoxG4QH+B1Iuingss1+RRb+0Ynz0/JndZDiG8B9TThua1ZCfqgLnr/rtA2NSMmP7tobrGQNXPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LuG3C0E+vQjBn+CrawwxKulOSJySFub1hoxtYYsjEb0=; b=cp+IXF3kYg6P4nLaytA9sLwd3wmmwL+lJVXt4h6mYPwNXrB3G0gdOTREQW0LvSDskTwpvRjveIanbyToD8gKrnLt/tmgSeitSdgzDAE0hpZL0LYWsNWIwKSKang8GbuREpjpmZ5Nh/8FyFgHEMPvAGYk+CofZwxeGN7L/wUPoAc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Fri, 7 Aug 2026 10:08:32 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] xen/sched: split scheduler vtable from struct scheduler To: Furkan Caliskan , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, tpearson@raptorengineering.com, alistair.francis@wdc.com, connojdavis@gmail.com References: <20260804055327.22119-1-frn1furkan10@gmail.com> <20260804055327.22119-2-frn1furkan10@gmail.com> Content-Language: en-US From: Stewart Hildebrand In-Reply-To: <20260804055327.22119-2-frn1furkan10@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL1PR13CA0092.namprd13.prod.outlook.com (2603:10b6:208:2b9::7) To PH7PR12MB6467.namprd12.prod.outlook.com (2603:10b6:510:1f5::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB6467:EE_|SN7PR12MB7346:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f8b5865-96a7-4389-f84b-08def45b172f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|7416014|6133799003|4143699003|56012099006|11063799006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ey/7PWvsiJCg+mfjTAsMXyDW1YZr70I008K94rLw7DpgmxNLV7lxtLu73uwzbKnOsbPw96/tfTpodFJgKAgma9U5JWKVMWFHPhSU/RCjLifif4EkvzgCYQGp+a54BrKXRKbQb8aEoxcNlsZGvWlB3rZRpqHztjPJey28bTlcBJ2OTnTmo8N5weO79zJ8x/mlKR+NsqIyON8GvYgZYJ9JvW1PaHSWKCeAqTZrDq8owA6jWmkCgbe8P+O9b+oM6ZmvucpzNWC1glN9F6LTT+YJgOEv3hhT6gE6KPYNJ6jsV3CFfoToGQpYFeX29opkhZn9SiizX9pKWHZUpdNPGQgMwHB6FLdqZ70NzqknTkQ/WN9nZcAuH4XfC3m8HMbGJRKbeLSueyCv5ilz5sUGQYSXUXrbsWYmBRpmkrujbbSfh6CgNit1EH1qeKYmoH1JpWR7kfM3D57mZzOA5euRKxJmCSF2tVCNTWLOAO2HaCt7FDo99K86kv3uME+KMYxPC4sVNY6afbTCwMHxFa5rvRM/+oZjMMlnqrlrCBn3irEJ+iAGktbxjR+Fhaica8ctzLppajKKZuWFc3wJ5kjJukQWaHm4yjaCyqsHn/lNROZYMfl4x/4MBsGpJMH/JOuY2aj+roni27li2qjXUT/sbCUM/twTI2SjQFVLpBgSUl/TVa4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6467.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(7416014)(6133799003)(4143699003)(56012099006)(11063799006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXJQSnAydGwvWk5veXdkMS93cEp5MFlqbHdnZmxPNWJEL3lwL1ZzNDRSR2Ur?= =?utf-8?B?dUpDQndzcmp3VXFpQmFlR1B5VFJKYU1aTWdWOCtNTC9SWks1R0ZibkZnTStT?= =?utf-8?B?S2hYRlY4RFBBc0NYNElCanhNZGtGb0ZyMXNNVHpOT3Z0RVQ1cU81QWpQdjdk?= =?utf-8?B?UzNlcXd0ZDZ4RUhXQTYvallPbmxtTlpxRWk3MVNrdDdqQUVVcXBLWGdEWmEz?= =?utf-8?B?UjNSai94dU03WG84dU8wVmMvNVhYa1BuZ2JJa1VpNE1PWjlQWkFEaFFFNTg3?= =?utf-8?B?WklJa0V5aGhXd2w1UjN1YUoxSjZsUUtmS2ZVMXZTeUJFTGJZS1B1U2o2TWQ2?= =?utf-8?B?LzhkOEdhWHVmczU3d0cxQUhPajJ2SlZzdWFGSGdQVi91ZUowQmhnbDhnU3A2?= =?utf-8?B?dzBQSEE3Q0lVdzNmVWtCZTE5QkthTXpEcXRLZkI2WkYvUTd0UlpzZkxJTFpa?= =?utf-8?B?YWtETG9jYkJPYU91anJROURxTjJ4Z2pnTWFNTnZGTkNpeGNFYkQ4QXk1Nmd0?= =?utf-8?B?Uzd3dXNRSEJ0emlkdnRBZUJpcENjS2UrTWR2OG8wcitCbXZQYjBpVCs0Wk5J?= =?utf-8?B?S1N6Y2VrZGFLOUxueXNtaGZEaHd5WmQzSnFOSDlyQWE5Unl1bUlNcFlXRlA3?= =?utf-8?B?WFFWelVVbGZZNk1oN3llYkNkMlVLTXZqcW5WUHFwTUJMbHJwdk5zemRzU2wr?= =?utf-8?B?SEFmcm1LTytkY2V4L2lSdHF1N3NvRzJCWDNYTThRdERneE55RjFNSEZHMjRj?= =?utf-8?B?cXZNYW5yUC9BeGxtaDI1R00vWkxodE52bnJ0dzMwV0xrK21zS0VxQkJpUjRx?= =?utf-8?B?VFRqUVU4QjNLY2dUWlN2bmFqdDB2YXFScWowMWt3Tk5LYmU2dC9pQlZXeEt1?= =?utf-8?B?ZnRqaGxoRW9LdkVuTmtvTkpRaytUdGRBNVJhZ3JBM3o1R1NIeWtVRWtjanRw?= =?utf-8?B?ditPREJpRXZYNGI0OVZ2NlJCU3Y2QjZMbTFJYXNKOXJMR3hmUnl1QmtrbTBT?= =?utf-8?B?OWJ2b0lRVUxsNlRWeHpzbjJZUTk2OVcxVS9MZDlQVVpaSVlaZENZRVIrdElw?= =?utf-8?B?bDkyU1dsR200V2U0ZFdrNVk3L0h5aVdtQVprQ2ZFdERvYTBjck1zaHVCN3FB?= =?utf-8?B?T05DQUFrektEc0thWXBtNWxDVVc4ME9zNkRycXBMWU9jc1lFTFYzanZLeXQv?= =?utf-8?B?NStvOVNGb2RuVEtBYS9BVzNCaXdjSE9lUk1Gc2hxZkVRcXAyWlpNVmJxOWMr?= =?utf-8?B?SmRLQlp6MHZhTTFPdURJRTBVZVl4WGI2ZDkrd3ZuVjFOZFFxTWNRbkUyU0hw?= =?utf-8?B?dE9tNzdsSXVTOHNpeEFuUG9jdWdqL0tOYXIxRE1GQ0xXblZwSVBaTXRkRDI5?= =?utf-8?B?U2E0YUg3a04rNUNOTkQzQzgzS0tVYU5TZmVPcU45bkxUdzlDd0dVS3h6V05X?= =?utf-8?B?NUlwc2J3clhZNEdGRElpVU5jb1Z2dUc2NE4zbHN3YmwxK2lqRGtPU1huVE1V?= =?utf-8?B?SEJYbGJhTEZoWGNHSk9WNW5BcTljODlnYURCOTN2OWdneW9IU3F6NUEwL1My?= =?utf-8?B?a2tza2JWQmhPQUIyWU1hMEIyenh6aHg3bUtZcXZjZVdhK0NVNmxSMzgxckph?= =?utf-8?B?Rm1FczZVVXdEVWJHNVJYSERKTWpGNlYydkFDNUtwcFNCWFJTN0N5ZFVWOU1z?= =?utf-8?B?Q0MyOTJHak1YVzV6QW5hRDNCZzQyUTNuUE4rcXlXRTY3cjVONlFvSCthVFBM?= =?utf-8?B?MjRNV0taODQzUGRITnlla0RVaGtlaGRPVWI0cG80eDVHcnlweGlhY1MveUdD?= =?utf-8?B?YUorY1ZqTTZTM2RmSGhSWHBYbk1DWDA3cnpIb1ZDSGlPeUo2RUN6V3gzR3My?= =?utf-8?B?MUsvVldadlJvZXo1ZjE0amRnUW01MnpTR0Jpd0Nodm1rbEZMVVg5V3g3R2wv?= =?utf-8?B?OThCQnpnaUtmbmZTRmc0Q2lGeW5xYnRYbDZIZ2dPZHorSUZFRTA5NFRlaTRk?= =?utf-8?B?THVjNmVXM2RRWU9SMXp4V2ZpcXY3a1dzMXBLTU9NWUIxN3NGMTJBMUVUYXZ6?= =?utf-8?B?di9seUFyWGt1b0VxWnZGZ1p3dnl2ZEF6WHVpQk1kV2F2L1hGbXpkTmVMNEdN?= =?utf-8?B?WmZGTUx4M09MQnBUTDc2ZEZBWHVpZFNYY1NsV0VFQzJaNnFqeWJvbzhVUnFB?= =?utf-8?B?UkNqeEZMVk85NEJLVFRMSHpYS3Z2SzVJR2ZjT1RvRXdqaHBXUHRhMkdhUzdJ?= =?utf-8?B?ekFLZEJqM1lpMUl5N3UzVXdNemtYZWNZeHR6czFIbGpGUVlZMHJaUVR4SERq?= =?utf-8?Q?/wN/3sqvLuQYrjOx3q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f8b5865-96a7-4389-f84b-08def45b172f X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6467.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2026 08:08:40.6399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1jgvzTlOKLO4TQ1/pJuXJVVWe53JqY+ZXP/HIEUsNpHvcZ1NxMvNKaIoX6/S9SrGXm4GrWqsjUwVX2oaM9zAqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7346 X-purgate-ID: tlsNG-720697/1786090127-F06A72AC-02582F36/0/0 X-purgate-type: clean X-purgate-size: 13945 On 8/4/26 07:53, Furkan Caliskan wrote: > struct scheduler currently serves two purposes: it is the static > vtable a scheduler backend defines (name, opt_name, sched_id, and > all its function pointers), and it is also the per-cpupool runtime > object scheduler_alloc() allocates. Being the same type forces > scheduler_alloc() to memcpy() the whole vtable into a fresh > allocation per cpupool, duplicating identical function pointers > across every cpupool using the same scheduler. > > Split the vtable out into its own type, struct sched_ops, so it > can be shared by every cpupool using a given scheduler instead of > copied per cpupool. struct scheduler is left holding only what is > actually per-instance: a pointer to the shared sched_ops, plus > sched_data and cpupool. scheduler_alloc() now stores a pointer to > the matching sched_ops instance instead of copying its fields, and > every accessor in private.h is updated from s->field to > s->ops->field to match. > > Every in-tree scheduler backend (credit, credit2, rtds, arinc653, > null) is converted from struct scheduler to struct sched_ops. > > A handful of call sites elsewhere read a scheduler's name, > opt_name or sched_id directly and are updated to go through > ->ops as well. > > Signed-off-by: Furkan Caliskan > --- > xen/common/sched/arinc653.c | 9 +--- > xen/common/sched/core.c | 52 +++++++++++--------- > xen/common/sched/cpupool.c | 7 +-- > xen/common/sched/credit.c | 3 +- > xen/common/sched/credit2.c | 3 +- > xen/common/sched/null.c | 3 +- > xen/common/sched/private.h | 98 +++++++++++++++++++------------------ > xen/common/sched/rt.c | 3 +- > 8 files changed, 89 insertions(+), 89 deletions(-) > > diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c > index 32c596a23c..746963806e 100644 > --- a/xen/common/sched/arinc653.c > +++ b/xen/common/sched/arinc653.c > @@ -702,17 +702,10 @@ a653sched_adjust_global(const struct scheduler *ops, > } > #endif /* CONFIG_SYSCTL */ > > -/** > - * This structure defines our scheduler for Xen. > - * The entries tell Xen where to find our scheduler-specific > - * callback functions. > - * The symbol must be visible to the rest of Xen at link time. > - */ The removal of the comment about symbol visibility is a definite improvement, and I'm okay with the overall comment removal. However, next time I'd prefer this to be mentioned in the commit message. For now, I don't want to delay this any further, so for ARINC 653: Acked-by: Stewart Hildebrand I will still give some additional remarks below, but I don't consider them blocking since they are nit/cosmetic and Juergen already gave his R-b. > -static const struct scheduler sched_arinc653_def = { > +static const struct sched_ops sched_arinc653_def = { > .name = "ARINC 653 Scheduler", > .opt_name = "arinc653", > .sched_id = XEN_SCHEDULER_ARINC653, > - .sched_data = NULL, > > .init = a653sched_init, > .deinit = a653sched_deinit, > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c > index 9ccf5811bf..5cdae0415c 100644 > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -87,7 +87,7 @@ DEFINE_PER_CPU(cpumask_t, cpumask_scratch); > /* How many urgent vcpus. */ > DEFINE_PER_CPU(atomic_t, sched_urgent_count); > > -extern const struct scheduler *__start_schedulers_array[], *__end_schedulers_array[]; > +extern const struct sched_ops *__start_schedulers_array[], *__end_schedulers_array[]; > #define NUM_SCHEDULERS (__end_schedulers_array - __start_schedulers_array) > #define schedulers __start_schedulers_array > > @@ -127,10 +127,9 @@ static void cf_check sched_idle_schedule( > unit->next_task = sched_idle_unit(cpu); > } > > -static struct scheduler sched_idle_ops = { > +static struct sched_ops sched_idle_sched_ops = { > .name = "Idle Scheduler", > .opt_name = "idle", > - .sched_data = NULL, > > .pick_resource = sched_idle_res_pick, > .do_schedule = sched_idle_schedule, > @@ -139,6 +138,11 @@ static struct scheduler sched_idle_ops = { > .free_udata = sched_idle_free_udata, > }; > > +static struct scheduler sched_idle_ops = { > + .ops = &sched_idle_sched_ops, > + .sched_data = NULL, > +}; > + > static inline struct vcpu *unit2vcpu_cpu(const struct sched_unit *unit, > unsigned int cpu) > { > @@ -2081,7 +2085,7 @@ long do_set_timer_op(s_time_t timeout) > /* scheduler_id - fetch ID of current scheduler */ > int scheduler_id(void) > { > - return operations.sched_id; > + return operations.ops->sched_id; > } > #endif > > @@ -2090,7 +2094,7 @@ long sched_adjust(struct domain *d, struct xen_domctl_scheduler_op *op) > { > long ret; > > - if ( op->sched_id != dom_scheduler(d)->sched_id ) > + if ( op->sched_id != dom_scheduler(d)->ops->sched_id ) > return -EINVAL; > > switch ( op->cmd ) > @@ -2132,7 +2136,7 @@ long sched_adjust_global(struct xen_sysctl_scheduler_op *op) > > rcu_read_lock(&sched_res_rculock); > > - rc = ((op->sched_id == pool->sched->sched_id) > + rc = ((op->sched_id == pool->sched->ops->sched_id) > ? sched_adjust_cpupool(pool->sched, op) : -EINVAL); > > rcu_read_unlock(&sched_res_rculock); > @@ -2299,7 +2303,7 @@ static struct sched_unit *do_schedule(struct sched_unit *prev, s_time_t now, > struct sched_unit *next; > > /* get policy-specific decision on scheduling... */ > - sched->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); > + sched->ops->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); > > next = prev->next_task; > > @@ -2989,10 +2993,9 @@ void scheduler_enable(void) > } > > static inline > -const struct scheduler *__init sched_get_by_name(const char *sched_name) > +const struct sched_ops *__init sched_ops_get_by_name(const char* sched_name) Nit: whitespace: const char *sched_name > { > unsigned int i; > - Nit: please retain the newline here > for ( i = 0; i < NUM_SCHEDULERS; i++ ) > if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) ) > return schedulers[i]; > @@ -3002,16 +3005,15 @@ const struct scheduler *__init sched_get_by_name(const char *sched_name) > > int __init sched_get_id_by_name(const char *sched_name) > { > - const struct scheduler *scheduler = sched_get_by_name(sched_name); > - > - return scheduler ? scheduler->sched_id : -1; > + const struct sched_ops *ops = sched_ops_get_by_name(sched_name); Nit: newline > + return ops ? ops->sched_id : -1; > } > > /* Initialise the data structures. */ > void __init scheduler_init(void) > { > struct domain *idle_domain; > - const struct scheduler *scheduler; > + const struct sched_ops *ops; > int i; > > scheduler_enable(); > @@ -3044,21 +3046,23 @@ void __init scheduler_init(void) > } > } > > - scheduler = sched_get_by_name(opt_sched); > - if ( !scheduler ) > + ops = sched_ops_get_by_name(opt_sched); > + if ( !ops ) > { > printk("Could not find scheduler: %s\n", opt_sched); > - scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT); > - BUG_ON(!scheduler); > - printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name); > + ops = sched_ops_get_by_name(CONFIG_SCHED_DEFAULT); > + BUG_ON(!ops); > + printk("Using '%s' (%s)\n", ops->name, ops->opt_name); > } > - operations = *scheduler; > + > + operations.ops = ops; > > if ( cpu_schedule_up(0) ) > BUG(); > register_cpu_notifier(&cpu_schedule_nfb); > > - printk("Using scheduler: %s (%s)\n", operations.name, operations.opt_name); > + printk("Using scheduler: %s (%s)\n", > + operations.ops->name, operations.ops->opt_name); > if ( sched_init(&operations) ) > panic("scheduler returned error on init\n"); > > @@ -3411,12 +3415,14 @@ struct scheduler *scheduler_alloc(unsigned int sched_id) > for ( i = 0; i < NUM_SCHEDULERS; i++ ) > if ( schedulers[i] && schedulers[i]->sched_id == sched_id ) > goto found; > + > return ERR_PTR(-ENOENT); > > found: > - if ( (sched = xmalloc(struct scheduler)) == NULL ) > + if ( (sched = xzalloc(struct scheduler)) == NULL ) The change to xzalloc deserves a mention in the commit message. > return ERR_PTR(-ENOMEM); > - memcpy(sched, schedulers[i], sizeof(*sched)); > + sched->ops = schedulers[i]; > + > if ( (ret = sched_init(sched)) != 0 ) > { > xfree(sched); > @@ -3447,7 +3453,7 @@ void schedule_dump(struct cpupool *c) > { > sched = c->sched; > cpus = c->res_valid; > - printk("Scheduler: %s (%s)\n", sched->name, sched->opt_name); > + printk("Scheduler: %s (%s)\n", sched->ops->name, sched->ops->opt_name); > sched_dump_settings(sched); > } > else > diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c > index 081e1053eb..640578201f 100644 > --- a/xen/common/sched/cpupool.c > +++ b/xen/common/sched/cpupool.c > @@ -338,7 +338,8 @@ static struct cpupool *cpupool_create(unsigned int poolid, > spin_unlock(&cpupool_lock); > > debugtrace_printk("Created cpupool %u with scheduler %s (%s)\n", > - c->cpupool_id, c->sched->name, c->sched->opt_name); > + c->cpupool_id, c->sched->ops->name, > + c->sched->ops->opt_name); > > return c; > > @@ -862,7 +863,7 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) > if ( c == NULL ) > break; > op->cpupool_id = c->cpupool_id; > - op->sched_id = c->sched->sched_id; > + op->sched_id = c->sched->ops->sched_id; > op->n_dom = c->n_dom; > ret = cpumask_to_xenctl_bitmap(&op->cpumap, c->cpu_valid); > cpupool_put(c); > @@ -1294,7 +1295,7 @@ struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id) > struct cpupool *pool; > > if ( sched_id < 0 ) > - sched_id = scheduler_get_default()->sched_id; > + sched_id = scheduler_get_default()->ops->sched_id; > > pool = cpupool_create(pool_id, sched_id); > > diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c > index 4dde2ede12..8df746bf6b 100644 > --- a/xen/common/sched/credit.c > +++ b/xen/common/sched/credit.c > @@ -2277,11 +2277,10 @@ csched_deinit(struct scheduler *ops) > } > } > > -static const struct scheduler sched_credit_def = { > +static const struct sched_ops sched_credit_def = { > .name = "SMP Credit Scheduler", > .opt_name = "credit", > .sched_id = XEN_SCHEDULER_CREDIT, > - .sched_data = NULL, > > .global_init = csched_global_init, > > diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c > index 95946634d1..4949606881 100644 > --- a/xen/common/sched/credit2.c > +++ b/xen/common/sched/credit2.c > @@ -4230,11 +4230,10 @@ csched2_deinit(struct scheduler *ops) > xfree(prv); > } > > -static const struct scheduler sched_credit2_def = { > +static const struct sched_ops sched_credit2_def = { > .name = "SMP Credit Scheduler rev2", > .opt_name = "credit2", > .sched_id = XEN_SCHEDULER_CREDIT2, > - .sched_data = NULL, > > .global_init = csched2_global_init, > > diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c > index 952bb47444..b3c6651fb1 100644 > --- a/xen/common/sched/null.c > +++ b/xen/common/sched/null.c > @@ -1037,11 +1037,10 @@ static void cf_check null_dump(const struct scheduler *ops) > spin_unlock_irqrestore(&prv->lock, flags); > } > > -static const struct scheduler sched_null_def = { > +static const struct sched_ops sched_null_def = { > .name = "null Scheduler", > .opt_name = "null", > .sched_id = XEN_SCHEDULER_NULL, > - .sched_data = NULL, > > .init = null_init, > .deinit = null_deinit, > diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h > index d6884550cd..0c5181891c 100644 > --- a/xen/common/sched/private.h > +++ b/xen/common/sched/private.h > @@ -294,12 +294,10 @@ static inline spinlock_t *pcpu_schedule_trylock(unsigned int cpu) > return NULL; > } > > -struct scheduler { > - const char *name; /* full name for this scheduler */ > - const char *opt_name; /* option name for this scheduler */ > - unsigned int sched_id; /* ID for this scheduler */ > - void *sched_data; /* global data pointer */ > - struct cpupool *cpupool;/* points to this scheduler's pool */ > +struct sched_ops { > + const char *name; /* full name for this sched_ops */ > + const char *opt_name; /* option name for this sched_ops */ > + unsigned int sched_id; /* ID for this sched_ops */ > > int (*global_init) (void); > > @@ -366,127 +364,133 @@ struct scheduler { > struct sched_resource *sr); > }; > > +struct scheduler { > + const struct sched_ops *ops; /* shared, read-only dispatch table */ > + void *sched_data; /* global data pointer */ Isn't it a scheduler instance data pointer, not global? From xen-devel-bounces@lists.xenproject.org Fri Aug 07 09:33:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 09:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385875.1628213 (Exim 4.92) (envelope-from ) id 1wsGwl-0002i6-Ur; Fri, 07 Aug 2026 09:32:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385875.1628213; Fri, 07 Aug 2026 09:32:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsGwl-0002hz-S9; Fri, 07 Aug 2026 09:32:59 +0000 Received: by outflank-mailman (input) for mailman id 1385875; Fri, 07 Aug 2026 09:32:59 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsGwk-0002ht-Li for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 09:32:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsGwk-00AXZx-2W for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 11:32:58 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a75a649-bab6-0a2a0a5309dd-0a2a4507b28e-6 for ; Fri, 07 Aug 2026 11:32:57 +0200 Received: from [131.159.0.202] (helo=mailout2.rbg.tum.de) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a75a649-b4ea-0a2a45070019-839f00cae863-3 for ; Fri, 07 Aug 2026 11:32:57 +0200 Received: from mailrelay1n.ito.cit.tum.de (mailrelay.in.tum.de [131.159.254.10]) by mailout2.rbg.tum.de (Postfix) with ESMTPS id E856C4C0285; Fri, 7 Aug 2026 11:32:56 +0200 (CEST) Received: from mail.in.tum.de (vmrbg426.in.tum.de [131.159.0.73]) by mailrelay1n.ito.cit.tum.de (Postfix) with ESMTPS id 4hGf885Wngz2xTS; Fri, 7 Aug 2026 11:32:56 +0200 (CEST) Received: by mail.in.tum.de (Postfix, from userid 112) id BC2E04A04C1; Fri, 7 Aug 2026 11:32:56 +0200 (CEST) Received: (Authenticated sender: hoepf) by mail.in.tum.de (Postfix) with ESMTPSA id 903A74A0425; Fri, 7 Aug 2026 11:32:56 +0200 (CEST) (Extended-Queue-bit xtech_ja@fff.in.tum.de) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20220209 header.d=cit.tum.de header.i="@cit.tum.de" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cit.tum.de; s=20220209; t=1786095176; bh=Z3p8olyxZ32+8cGkN/ra6kddtLV2OiPHtOEbdJxzTvw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OVrl0+BRIokrzr4rCeMINBhIvom/UiDN0tOeYeRH4VE675ijh06oyIQHhBrdnadlh /RhojvqJZ7cFaGk9pIaeWiNQ1rz2N+6d8keSh9et9y3gytnofPNjIphXF24seNqvIQ ICyfWJf6gyXY+FVpHDRFZ/H7/UmvlqzQKOrNpVnBiq95D8+WEuhrQHBqnWLPomQL4Q u9mX13Qt22FbdgJ7EBZmTbLF2g74E5W0KhJ/CD6vMqS9hHLGWj5GveDh23+3u47KS6 jMUxp1TgNKgNIS53FfYyE2ZtJZswY8EsAjGWizR20aqZ7RdT47cbkV/5PcXKL4/Hbt Fg3+RvFjxNrog== Date: Fri, 7 Aug 2026 11:32:55 +0200 From: Johann =?utf-8?Q?H=C3=B6pfner?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Teddy Astie Subject: [PATCH] vvmx: Fix uninitialised writeback to vmcs12 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Virus-Scanned: clamav-milter 1.5.3 at itovm121 X-Virus-Status: Clean X-purgate-ID: tlsNG-ef75cf/1786095177-348C9AE4-312987C3/0/0 X-purgate-type: clean X-purgate-size: 2381 nvmx_handle_vmwrite leaves local eight byte variable 'operand' uninitialised to be written as an out-parameter by decode_vmx_inst. In cases where the operand to vmwrite is a 32 bit memory operand, the invokation of hvm_copy_from_guest_linear leaves the upper half of *poperandS uninitialised. The resulting eight byte value is consequently written to the vmcs12 leaking the four uninitialised bytes into guest physical memory. Initialize the stack-space passed to decode_vmx_inst to avoid this issue. Fixes: 2b2793d3ae44 ("nEPT: handle invept instruction from L1 VMM") Fixes: d4c5b9db5a85 ("Nested VMX: Emulation of guest VMWRITE") Fixes: 9ccf55307868 ("nVMX: virutalize VPID capability to nested VMM") Signed-off-by: Johann Höpfner --- > In any event - why don't you make your proposed change into a proper patch > (primary piece missing is your S-o-b, and perhaps we also would want a > suitable Fixes: tag)? Sorry to have kept you waiting. Here is the formatted patch. I included the invvpid case still, though I believe only vmwrite remains after the patch you linked is merged, right? xen/arch/x86/hvm/vmx/vvmx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index e4cdfe55c1..68c5df6658 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -1968,7 +1968,7 @@ static int nvmx_handle_vmwrite(struct cpu_user_regs *regs) { struct vcpu *v = current; struct vmx_inst_decoded decode; - unsigned long operand; + unsigned long operand = 0; u64 vmcs_encoding; enum vmx_insn_errno err; int rc; @@ -2012,7 +2012,7 @@ static int nvmx_handle_vmwrite(struct cpu_user_regs *regs) static int nvmx_handle_invept(struct cpu_user_regs *regs) { struct vmx_inst_decoded decode; - unsigned long eptp; + unsigned long eptp = 0; int ret; if ( (ret = decode_vmx_inst(regs, &decode, &eptp)) != X86EMUL_OKAY ) @@ -2040,7 +2040,7 @@ static int nvmx_handle_invept(struct cpu_user_regs *regs) static int nvmx_handle_invvpid(struct cpu_user_regs *regs) { struct vmx_inst_decoded decode; - unsigned long vpid; + unsigned long vpid = 0; int ret; if ( (ret = decode_vmx_inst(regs, &decode, &vpid)) != X86EMUL_OKAY ) -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 09:57:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 09:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1385882.1628222 (Exim 4.92) (envelope-from ) id 1wsHKP-0007Wi-RM; Fri, 07 Aug 2026 09:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1385882.1628222; Fri, 07 Aug 2026 09:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsHKP-0007Wb-Oj; Fri, 07 Aug 2026 09:57:25 +0000 Received: by outflank-mailman (input) for mailman id 1385882; Fri, 07 Aug 2026 09:36:32 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsH0B-0003Sy-T3 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 09:36:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsH0B-00AYi3-5o for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 11:36:31 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a75a715-8faa-0a2a0a5109dd-0a2a450cde46-48 for ; Fri, 07 Aug 2026 11:36:31 +0200 Received: from [52.101.69.90] (helo=AM0PR83CU005.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a75a71e-f479-0a2a450c0019-3465455a8e61-3 for ; Fri, 07 Aug 2026 11:36:30 +0200 Received: from AM9PR05MB7665.eurprd05.prod.outlook.com (2603:10a6:20b:2cd::14) by PAXPR05MB8781.eurprd05.prod.outlook.com (2603:10a6:102:210::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.23; Fri, 7 Aug 2026 09:36:29 +0000 Received: from AM9PR05MB7665.eurprd05.prod.outlook.com ([fe80::48e2:5393:ed5a:3b3e]) by AM9PR05MB7665.eurprd05.prod.outlook.com ([fe80::48e2:5393:ed5a:3b3e%4]) with mapi id 15.21.0292.022; Fri, 7 Aug 2026 09:36:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=hunenet.nl header.i="@hunenet.nl" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q2XrPJ7h6OtVWZFU/dHqXyF3SvS9kmam6c/PexFcI6BMVrr7W4+jHbykO6c4O9YTZ+9xG+C11AFfQ9yH6fYSDbWr+o5mXY2yVRZZged+Sz8DsvyvGLx+U52pJw8sYs+AmRXBJX0slRANtkns9pMmTRv+bC8HY9rT13OnO6XVgjEQpzP17cA2roirEPTgeJVZvqUZHKnV4CqyVbGkzQ2buiA+vzeyVo+9YT2LFmuJYwsTiltF+oEQ77WseHuqZZT+5XKMBL+WDb+bR5fw1U/QnAGXSqQr7Uy4DpEmHTIhW1m281gIYcr8VEPxv092dlhDHK8IoZ+6nx8A438w+h3EfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/o1g/Dd7HtR4QqtG9BroF9eIcDTquPeoIVlm/S0voQ=; b=J7uGlNUsoHq7CWi9JQHNChp5rLPG3F2in9CbriPFRCniBeahxRveeJqdHQj7O7Ugcjjk9XaUYKeY+V0PfJ9MKsLCxXMsa2V0Hx1wvrId0+ti/60kqRLiBFw39fLVwAGviZ9Sx74B7sIIJ5uKBWbURUCqXtwtBM47+psCSqfpoZdA8BlLjrSxlPsHZiIPOphNlt7adWjcI3PD5o81mhgDMYvcmRDCvzkM43m43my+yEhsghP4OUVm5URugg+sgqxUAA6ITG2hsaXOFzR4Hu/zDv9Jb7sLAgF2iMLt5nN+6Thvfn1TtnNJEJEUrR4UgSHlFrWduFYg8NzcDBWARjWQNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hunenet.nl; dmarc=pass action=none header.from=hunenet.nl; dkim=pass header.d=hunenet.nl; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hunenet.nl; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e/o1g/Dd7HtR4QqtG9BroF9eIcDTquPeoIVlm/S0voQ=; b=giJ9xBI+tX1GKF8WzyjimvmQnaJMXicBYTi+zRCA33s2vZa+BxpS/jUODp13nwo0UCTigt5YRdYJshvCKFW976waxZDH7RYm7mz0DtWTzTlsBE9Ml5qhyp4fXZHzyIjKH1zSkynge0ozy3UiGklPtn1omRIwWjspAzp7weeXLWFEn7uJQ73qOUCbc9ECTpVSzov90JzyHZKvRDfUdyj+CIJyWUVKz18zKnAhqb5MqjVuHQPHWqAvooRlojB7+UUh+bO6WHNfQrDFgktUv1pEchVWNyV+1ObxRvvLsZCDFXOgMue6a6v/H0MyphS3NkZKzb7YJRvM2vsdkVhlbjTOaA== From: "H. Bakker - Hunenet B.V." To: "xen-devel@lists.xenproject.org" Subject: help Windows PV Drivers and Windows Server 2025 Thread-Topic: help Windows PV Drivers and Windows Server 2025 Thread-Index: Ad0mT/qwzqiDr4LQQ4SZEldj1o5M7Q== Date: Fri, 7 Aug 2026 09:36:29 +0000 Message-ID: Accept-Language: nl-NL, en-US Content-Language: nl-NL X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=hunenet.nl; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9PR05MB7665:EE_|PAXPR05MB8781:EE_ x-ms-office365-filtering-correlation-id: ded94f0f-b30c-4bf4-0146-08def4675bfc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|18002099003|38070700021|8096899003|10067099003|56012099006; x-microsoft-antispam-message-info: eqqxxP/57iBa4NFu4279BYEiwwnzQrFKO1kJDD/lWWSlwa/GyDO1ILnkt9wGFcmOZpme8iPSlEwW/tVDgIFWL4ZFoAR1PWqqtBvf91sn1LPzbSdd8bIQrVWFAZ2szdhsllg/l2tkN6Rqau71na9VJYBhHcziNHD5Bj13RvVHKhTOBhZSrNuc68h4CJYrrrfclvrS+9olKbXf0JXk4EDf2AnuraO8PiNV5UC81ld5Lb+dCfRR6LGqah2LLSIkfTFZVNi0AuSlIIo2azkMGN/mepyMXCB6Gsu+qHH7d1PROccvXHqwhaOhR+VlvnnqMZ6ErI2NB7dc67RqQcKjKZCphUA3SY7BNvbYTk5kn1E8ZsIIJYYh5Mm1mMmLasOcZcMolK/Max9n5C0rr3Nl73dtkXVS9Goxs00XqkwzdHGSuLT6WSUhIQ5mGt8MKqD4ZrT9Uojc7lMSOc22GoAoaBKE0r4sAMdOYA6374U6wvR6ZDV8UPIZe4BDffBwcIW7gFRW64/a8rFrJ6nDT4tVhj4H+oHK8FfP0L6toK1BYpugejue6n/svpZjU6WyoJ1XJLspC6OPbOI6KJfQDsiQiKDNbsGeQdbSKlGQwfJtr5Y3mFEOwQtpf0PwRHCsmf3vWqjam0m9zpf74JJIEIUWlYC1uGmuNjqONQ0fN1sOceM3++8FHL750F4a2why2f5PcQG/MFOQAFL9bX77ug4QHNAhuQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR05MB7665.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(18002099003)(38070700021)(8096899003)(10067099003)(56012099006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aTR5RVBZazZsblFUSy9mRkY3T0JmTFNhc2h2RTdqRHFtaEs1dlFFaG05L3dF?= =?utf-8?B?R1hwYTZSM25xODYwaGVaV0JDenZYTklWVDdVbFRickJmRCs1d1hDNnFqOGRk?= =?utf-8?B?U3pBWUU1eGpKUXQ1d1N4YkYrN0I1WGV5UVRDM240NjJBQWZHOGU0ZWpkZk8w?= =?utf-8?B?MTlzRXdHWjZQcko2b0ZJcE9GUGQ4VXdmSW9jeHQ5V09VZk9Rb1NzZURRbno4?= =?utf-8?B?SS9keFhESWZJUHZHQ1pIUHRCWnZmQjg1WVJSWm5MQ3Nrd2l1WXQrQ0NZdXNY?= =?utf-8?B?Qi9OSWMydWFTS3p4cHE5OWVPdzM3OEpBd3ZjZWQvb0xQcUxwOFArcVA0MXZS?= =?utf-8?B?UXlPbjhiSlUrS09GN0VESkNFdTlsUFZXcjh5d1U3UkZWQ2o5VnZET0x3Y0pn?= =?utf-8?B?VTdETGFnUVd5M0pYWkZ6dHQyK2wzYjhlZndkczZHaERheWE2L3RyV3htV09N?= =?utf-8?B?ZkxCN0FyN0VteFQ2RmcybXhhWGwrcnNQNkJhNTd2eWEvaktRcFpTWXpLYmtY?= =?utf-8?B?UWdkVjRaNUVMaldWbzY5amp1NHhVNGllNHV4cm41ODFVR2F3RnhYdHNKbEpE?= =?utf-8?B?aWQ2cjZYTmdCZ2EycnVXbUNCaVVCR3o5Ui9kTUhONmg4MGI5US9zREZPY2wr?= =?utf-8?B?SVRWenEvSVdqVE54VkNtK2ZkVkhSaDdrR1FZY1ppZ01Jb0h2bHRteHFua3ZR?= =?utf-8?B?YUpsR05QZ1E0Q1k5T0orRUkrU0Zjd2kvRGxRQnA4TTMzQnk2cU8za2V4WHM2?= =?utf-8?B?dmtHYnFaRWJLVHhSUm0wVmZQUmhxdzRqSVFOb3VLTCtBSVQwK0ZLTzNTanZL?= =?utf-8?B?YjNZY0RiK2J1U2tWdGY2MXJhclNLeTZPOHQ3YWpxYUdHbm4vY0cyTzkzeTBj?= =?utf-8?B?bEl5SUdjSUlpRTUyZVF2eDNJVnZScU5DcDdNKys3Wk42VmVUQ3ZEblpINFFQ?= =?utf-8?B?YjE0VFJiRTBmc0MzaHAxaWZIa29NSTU0aWkyUlFlMjVDTTRnb2p6MzNTZkpp?= =?utf-8?B?aVRGSlczRXZDMzBDalNTUVdoVHhuOG9jNE9KUmVEZnZaWTk2ZE9RRndTQjA0?= =?utf-8?B?MTZXZGlvUVJKRTRhUDBnNVYxWnc1bFgyY2pqM3Rzc2ZZNndZSVg3d2pKSjF5?= =?utf-8?B?Nk92UnhndHIxS3dWWG9QOHUzbmYvd0lRRzJVUzlmL1lMY2JKRUwrSEhCS2I4?= =?utf-8?B?TmNiK2NDVFYxMU1KSzBKeEQ1RlQrTW5yWlZaeHI4dmNTMTlrdERLb0JJcUM3?= =?utf-8?B?ZXpVMDJFdENjL015YVNVRWg1cEduOGhPSlU3RVVvVElsZFZKUWE0L2FkbUt1?= =?utf-8?B?YzRnaDh0aEd0c1NPTVhVZHQxQ0hBckZRV0YvbDZPdWdnZm16TGtTd0Y4eS9q?= =?utf-8?B?M2oyWUpGcUEyWDdGNG5EK3BhUFovTGUzL1k1clpiQXJ2ckp4V1FMYmVtZmpU?= =?utf-8?B?VTlNaEdKcDA2L0RGTnlnWDBWSmFPWVRzb211WDU2OWFiV2tqVlp1Yks2bDJl?= =?utf-8?B?T05TMVE2aWF5dGFRektzSXU5N1FFTFp4d2NtLzc3bTVGdXRPcWdwT3h1ZmlI?= =?utf-8?B?QW4vM21rOGF0Y3MvOGhYVzJFelNxS1ZFaDhDR09NNi9LOVBJMXhBQzFXSFJl?= =?utf-8?B?VWNHajNXTEFFempnTkxFWnZaWk9vNVFrOGpKR2R3UjRNMmNTOHFtdVd6ZXNV?= =?utf-8?B?RGEwQ0NRQ3VXOGFCb2dyaGNXdXE2TnpsZFI3NVBJZjk1bGFBcmJUOU1wNElv?= =?utf-8?B?dEVRSVdkT05WcXVWQjB6TDkvazc1bmpyLzJwRFkwbTJyYlZ4b0Q5cmJRM25k?= =?utf-8?B?Q2licTdtbnB1R0NRcGZLK1hKeFA3aWxGLy84TjFod0R6YXczOGE0TVBRMk5p?= =?utf-8?B?RG1Qc3NxUUt2bUVJV3NzRlkwRTdjS2tvdWExd1gxeUtGbC9nNDJ4K1dUV0Nl?= =?utf-8?B?VWpHRTlBa01VbHJkU3lQYjBrWE5lbDBmQkREeVJhbUpXeFhac2lGWEh5dEg3?= =?utf-8?B?UGZCSTY2VUk3WTU0bWdVMUNOazI3TWwwMDFhcWxFTENLMjU2T2IwSGY1QXky?= =?utf-8?B?TEZEZlkzWjZCRUQxSko2Z3E3NEw2TkxKTWVMU1FqaityWmdSMWZZczZ4bkUz?= =?utf-8?B?NmdFbWM3azdZS0pjbUs0LzF3MDVoaVNzdWRZUk54ZTJKeGcxWStwdnhlSmt1?= =?utf-8?B?dnU1WHpSczA0d3JHUEI2L1orQTkxZ2JkV1ZPNGxBc3FYOUlCUXdibmI3TERD?= =?utf-8?B?dmJQWk9lZlRsOENpRlZBc24yeEV5YlFMd1BCTElkc1ZYREEzUUZHSVdDSm9u?= =?utf-8?B?Q01CU3NWNC9wa0RJNEV1YmZvNjFIaXVXcENmQjI1Z0FtWDdtN3ROZz09?= Content-Type: multipart/alternative; boundary="_000_AM9PR05MB7665DF8E88357A35E50C1CA6EDD12AM9PR05MB7665eurp_" MIME-Version: 1.0 X-OriginatorOrg: hunenet.nl X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR05MB7665.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ded94f0f-b30c-4bf4-0146-08def4675bfc X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2026 09:36:29.4771 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 887aa16f-e08f-4cfb-bc70-8f3f25a72a41 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DrB+QvkdfxGl9uaSjXP0+C762tRRfgEHo598UzvoAuuUvJURFLVAfNUAKAiO4BnM60lsO74YL6fkOox/9DLdnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR05MB8781 X-purgate-ID: tlsNG-d25034/1786095391-01AC4A5B-CE6FEE1B/0/0 X-purgate-type: clean X-purgate-size: 4652 --_000_AM9PR05MB7665DF8E88357A35E50C1CA6EDD12AM9PR05MB7665eurp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 VGhpcyBjb25jZXJucyB0aGUgaW5zdGFsbGF0aW9uIG9mIHRoZSBXaW5kb3dzIFBWIERyaXZlcnMg b24gV2luZG93cyBTZXJ2ZXIgMjAyNS4NCg0KV2hlbiBydW5uaW5nICJkcGluc3QuZXhlIiwgdGhl IGluc3RhbGxhdGlvbiBmYWlscyB3aXRoIHRoZSBtZXNzYWdlICJJbnN0YWxsIGZhaWxlZCIuDQoN ClRoZSBhZmZlY3RlZCBkcml2ZXIgdmVyc2lvbiBpczoNCkRyaXZlclZlcj0wNy8xMy8yMDIzLDku MS4wLjENCg0KSSBhbSBjdXJyZW50bHkgdXNpbmcgYW4gb2xkZXIgdmVyc2lvbiB0aGF0IHdvcmtz IGNvcnJlY3RseToNCkRyaXZlclZlcj0xMi8wNS8yMDE5LDkuMC4wLjINCktpbmQgcmVnYXJkcywg SGVucnkgQmFra2VyLg0KDQo= --_000_AM9PR05MB7665DF8E88357A35E50C1CA6EDD12AM9PR05MB7665eurp_ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: base64 PGh0bWwgeG1sbnM6dj0idXJuOnNjaGVtYXMtbWljcm9zb2Z0LWNvbTp2bWwiIHhtbG5zOm89InVy bjpzY2hlbWFzLW1pY3Jvc29mdC1jb206b2ZmaWNlOm9mZmljZSIgeG1sbnM6dz0idXJuOnNjaGVt YXMtbWljcm9zb2Z0LWNvbTpvZmZpY2U6d29yZCIgeG1sbnM6bT0iaHR0cDovL3NjaGVtYXMubWlj cm9zb2Z0LmNvbS9vZmZpY2UvMjAwNC8xMi9vbW1sIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv VFIvUkVDLWh0bWw0MCI+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIg Y29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjxtZXRhIG5hbWU9IkdlbmVyYXRv ciIgY29udGVudD0iTWljcm9zb2Z0IFdvcmQgMTUgKGZpbHRlcmVkIG1lZGl1bSkiPg0KPHN0eWxl PjwhLS0NCi8qIEZvbnQgRGVmaW5pdGlvbnMgKi8NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6 IkNhbWJyaWEgTWF0aCI7DQoJcGFub3NlLTE6MiA0IDUgMyA1IDQgNiAzIDIgNDt9DQpAZm9udC1m YWNlDQoJe2ZvbnQtZmFtaWx5OkNhbGlicmk7DQoJcGFub3NlLTE6MiAxNSA1IDIgMiAyIDQgMyAy IDQ7fQ0KQGZvbnQtZmFjZQ0KCXtmb250LWZhbWlseTpBcHRvczt9DQovKiBTdHlsZSBEZWZpbml0 aW9ucyAqLw0KcC5Nc29Ob3JtYWwsIGxpLk1zb05vcm1hbCwgZGl2Lk1zb05vcm1hbA0KCXttYXJn aW46MGNtOw0KCWZvbnQtc2l6ZToxMS4wcHQ7DQoJZm9udC1mYW1pbHk6IkFwdG9zIixzYW5zLXNl cmlmOw0KCW1zby1saWdhdHVyZXM6c3RhbmRhcmRjb250ZXh0dWFsOw0KCW1zby1mYXJlYXN0LWxh bmd1YWdlOkVOLVVTO30NCnNwYW4uRS1tYWlsU3RpamwxOA0KCXttc28tc3R5bGUtdHlwZTpwZXJz b25hbC1jb21wb3NlOw0KCWZvbnQtZmFtaWx5OiJBcHRvcyIsc2Fucy1zZXJpZjsNCgljb2xvcjp3 aW5kb3d0ZXh0O30NCi5Nc29DaHBEZWZhdWx0DQoJe21zby1zdHlsZS10eXBlOmV4cG9ydC1vbmx5 Ow0KCWZvbnQtc2l6ZToxMC4wcHQ7DQoJbXNvLWxpZ2F0dXJlczpub25lO30NCkBwYWdlIFdvcmRT ZWN0aW9uMQ0KCXtzaXplOjYxMi4wcHQgNzkyLjBwdDsNCgltYXJnaW46NzAuODVwdCA3MC44NXB0 IDcwLjg1cHQgNzAuODVwdDt9DQpkaXYuV29yZFNlY3Rpb24xDQoJe3BhZ2U6V29yZFNlY3Rpb24x O30NCi0tPjwvc3R5bGU+PCEtLVtpZiBndGUgbXNvIDldPjx4bWw+DQo8bzpzaGFwZWRlZmF1bHRz IHY6ZXh0PSJlZGl0IiBzcGlkbWF4PSIxMDI2IiAvPg0KPC94bWw+PCFbZW5kaWZdLS0+PCEtLVtp ZiBndGUgbXNvIDldPjx4bWw+DQo8bzpzaGFwZWxheW91dCB2OmV4dD0iZWRpdCI+DQo8bzppZG1h cCB2OmV4dD0iZWRpdCIgZGF0YT0iMSIgLz4NCjwvbzpzaGFwZWxheW91dD48L3htbD48IVtlbmRp Zl0tLT4NCjwvaGVhZD4NCjxib2R5IGxhbmc9Ik5MIiBsaW5rPSIjNDY3ODg2IiB2bGluaz0iIzk2 NjA3RCIgc3R5bGU9IndvcmQtd3JhcDpicmVhay13b3JkIj4NCjxkaXYgY2xhc3M9IldvcmRTZWN0 aW9uMSI+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48c3BhbiBsYW5nPSJFTi1VUyI+VGhpcyBjb25j ZXJucyB0aGUgaW5zdGFsbGF0aW9uIG9mIHRoZSBXaW5kb3dzIFBWIERyaXZlcnMgb24gV2luZG93 cyBTZXJ2ZXIgMjAyNS48bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFs Ij48c3BhbiBsYW5nPSJFTi1VUyI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9wPg0KPHAgY2xh c3M9Ik1zb05vcm1hbCI+PHNwYW4gbGFuZz0iRU4tVVMiPldoZW4gcnVubmluZyA8Yj4mcXVvdDtk cGluc3QuZXhlJnF1b3Q7PC9iPiwgdGhlIGluc3RhbGxhdGlvbiBmYWlscyB3aXRoIHRoZSBtZXNz YWdlDQo8Yj4mcXVvdDtJbnN0YWxsIGZhaWxlZCZxdW90OzwvYj4uPG86cD48L286cD48L3NwYW4+ PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gbGFuZz0iRU4tVVMiPjxvOnA+Jm5ic3A7 PC9vOnA+PC9zcGFuPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxzcGFuIGxhbmc9IkVOLVVT Ij5UaGUgYWZmZWN0ZWQgZHJpdmVyIHZlcnNpb24gaXM6PGJyPg0KPGI+RHJpdmVyVmVyPTA3LzEz LzIwMjMsOS4xLjAuMTxvOnA+PC9vOnA+PC9iPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0iTXNvTm9y bWFsIj48c3BhbiBsYW5nPSJFTi1VUyI+PG86cD4mbmJzcDs8L286cD48L3NwYW4+PC9wPg0KPHAg Y2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gbGFuZz0iRU4tVVMiPkkgYW0gY3VycmVudGx5IHVzaW5n IGFuIG9sZGVyIHZlcnNpb24gdGhhdCB3b3JrcyBjb3JyZWN0bHk6PGJyPg0KPGI+RHJpdmVyVmVy PTEyLzA1LzIwMTksOS4wLjAuMjwvYj48bzpwPjwvbzpwPjwvc3Bhbj48L3A+DQo8cCBjbGFzcz0i TXNvTm9ybWFsIiBzdHlsZT0ibXNvLW1hcmdpbi10b3AtYWx0OmF1dG87bXNvLW1hcmdpbi1ib3R0 b20tYWx0OmF1dG8iPjxzcGFuIHN0eWxlPSJtc28tbGlnYXR1cmVzOm5vbmU7bXNvLWZhcmVhc3Qt bGFuZ3VhZ2U6TkwiPktpbmQgcmVnYXJkcywgSGVucnkgQmFra2VyLjwvc3Bhbj48c3BhbiBzdHls ZT0iZm9udC1mYW1pbHk6JnF1b3Q7Q2FsaWJyaSZxdW90OyxzYW5zLXNlcmlmO21zby1saWdhdHVy ZXM6bm9uZTttc28tZmFyZWFzdC1sYW5ndWFnZTpOTCI+PG86cD48L286cD48L3NwYW4+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMi4wcHQ7bXNvLWxp Z2F0dXJlczpub25lO21zby1mYXJlYXN0LWxhbmd1YWdlOk5MIj4mbmJzcDs8L3NwYW4+PG86cD48 L286cD48L3A+DQo8L2Rpdj4NCjwvYm9keT4NCjwvaHRtbD4NCg== --_000_AM9PR05MB7665DF8E88357A35E50C1CA6EDD12AM9PR05MB7665eurp_-- From xen-devel-bounces@lists.xenproject.org Fri Aug 07 14:28:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 14:28:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386041.1628240 (Exim 4.92) (envelope-from ) id 1wsLYM-0006cI-4w; Fri, 07 Aug 2026 14:28:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386041.1628240; Fri, 07 Aug 2026 14:28:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsLYM-0006cA-1i; Fri, 07 Aug 2026 14:28:06 +0000 Received: by outflank-mailman (input) for mailman id 1386041; Fri, 07 Aug 2026 14:28:04 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsLYK-0006aw-Ep for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 14:28:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsLYJ-001Pe9-Rs for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 16:28:03 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a75eb73-e002-0a2a0a5209dd-0a2a450bc9b0-0 for ; Fri, 07 Aug 2026 16:28:03 +0200 Received: from [160.101.131.8] (helo=na1pdmzitismtp01.tibco.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a75eb72-b7e8-0a2a450b0019-a0658308cbf4-3 for ; Fri, 07 Aug 2026 16:28:03 +0200 Received: from fedora.eng.citrite.net (unknown [10.113.40.46]) by na1pdmzitismtp01.tibco.com (Postfix) with ESMTP id 9001C44BABEF; Fri, 7 Aug 2026 10:26:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; none From: Abdelkareem Abdelsaamad To: xen-devel@lists.xenproject.org, jbeulich@suse.com Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, jason.andryuk@amd.com, teddy.astie@vates.tech Subject: Re: Re: [PATCH v2] x86/nSVM: Check the L1 IOPM_BASE and MSRPM_BASE Date: Fri, 7 Aug 2026 15:24:44 +0100 Message-ID: <20260807142444.2510849-1-abdelkareem.abdelsaamad@citrix.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1786112883-19CC79EA-F6BB306F/0/0 X-purgate-type: clean X-purgate-size: 2182 On 05.08.2026 10:36, Jan Beulich wrote: >On 29.07.2026 16:38, Abdelkareem Abdelsaamad wrote: >> @@ -294,6 +296,24 @@ static int nsvm_vmrun_permissionmap(struct vcpu *v, bool viopm) >> enum hvm_translation_result ret; >> unsigned long *ns_viomap; >> bool ioport_80 = true, ioport_ed = true; >> + gfn_t ns_iopm_end = >> + gfn_add(gaddr_to_gfn(ns_vmcb->_iopm_base_pa), (IOPM_PAGES_COUNT - 1)); >> + gfn_t ns_msrpm_end = >> + gfn_add(gaddr_to_gfn(ns_vmcb->_msrpm_base_pa), (MSRPM_PAGES_COUNT - 1)); > >Nit: Why the excess parentheses around the 2nd arguments each? Without them >the 2nd instance also more obviously stays within line length limits. > I will address in V3. >> + if ( gfn_x(ns_iopm_end) > domain_get_maximum_gpfn(v->domain) ) > >I don't think using domain_get_maximum_gpfn() is correct here. Imo you want >to merely check against what the guest is told in CPUID. I will switch to using gfn_valid() in V3 to properly align with what is valid for the guest. >...Everything else >ought to be properly covered by hvm_copy_from_guest_phys() / >hvm_map_guest_frame_ro() already. In fact for the MSR bitmap I thus can't >see why further checking would be needed. Indeed, I rechecked the call and confirmed that an invalid address should be caught downstream in __hvm_copy() -> hvm_translate_get_page(). I will drop this check in V3. >..And for the I/O bitmap it looks >to be a matter of better error handling, rather than introducing extra >checking. > I tested with the address (0xffffffffffffffffUL) assigned to the VMCB::IOPM and this just passes successfully without any error reported because it is all the time mapped to a valid host address. So, I think an explicit extra check is required here rather than just better error reporting. > + { > + gdprintk(XENLOG_ERR, "%s invalid _iopm_base_pa address (%#"PRIx64")\n", > + __func__, ns_vmcb->_iopm_base_pa); > + return 1; >Why literal 1? Yes, there is another such return in the function, but no, we >don't want to extend that. Aiui NSVM_ERROR_VVMCB is meant here. I will change both in V3. >Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 07 15:24:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 15:24:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386107.1628250 (Exim 4.92) (envelope-from ) id 1wsMRJ-0000hY-5X; Fri, 07 Aug 2026 15:24:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386107.1628250; Fri, 07 Aug 2026 15:24:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsMRJ-0000hR-0p; Fri, 07 Aug 2026 15:24:53 +0000 Received: by outflank-mailman (input) for mailman id 1386107; Fri, 07 Aug 2026 15:24:52 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsMRH-0000hJ-S9 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 15:24:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsMRG-004DkZ-BJ for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 17:24:50 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a75f8ba-2eae-0a2a0a5409dd-0a2a4507d61e-10 for ; Fri, 07 Aug 2026 17:24:49 +0200 Received: from [52.101.65.59] (helo=DU2PR03CU002.outbound.protection.outlook.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a75f8c0-b4ea-0a2a45070019-3465413b253b-3 for ; Fri, 07 Aug 2026 17:24:49 +0200 Received: from DU2PR04CA0029.eurprd04.prod.outlook.com (2603:10a6:10:3b::34) by VI0PR08MB10800.eurprd08.prod.outlook.com (2603:10a6:800:205::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.23; Fri, 7 Aug 2026 15:24:43 +0000 Received: from DU2PEPF00028D12.eurprd03.prod.outlook.com (2603:10a6:10:3b:cafe::3a) by DU2PR04CA0029.outlook.office365.com (2603:10a6:10:3b::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.21 via Frontend Transport; Fri, 7 Aug 2026 15:24:43 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU2PEPF00028D12.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Fri, 7 Aug 2026 15:24:42 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) by DU0PR08MB10360.eurprd08.prod.outlook.com (2603:10a6:10:417::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.23; Fri, 7 Aug 2026 15:24:04 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4]) by VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4%3]) with mapi id 15.21.0292.018; Fri, 7 Aug 2026 15:24:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=YgYEf8/SAqc2pFNvqaD4dDMa/gsJUU+5MZOxScmIqgUj/Tx7t4IlrtLsb91lNcg69MR7dVZoeSppBCkkBgQGOqwkJ6OWWJ+MTzZdA5kBb1VsrAvpI2lcKR4S8ceD0HjUcj+ESfu4Zd+1mIbJMlJ0ibLEGcuwKGy8JlCK2FsT3toHWjiGadnfZeBoOXcXciv/bmssMN5WrVhJFvGs2j8vQzPbqaxRjQSaxJiLt+8aMVo0WuXLmER0/KfgBnTJb7H6E9NhxpSG9VS6y01FqG904amkoWg43Gzd4regFez2fl/jNZpv5RUfsY46/OvfjqvHaibmSbVVst2yCnM5oUxUZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=214jEOHDvbqO65kJp7R9WvTe7aHGn+ywbFPey8CpPng=; b=y+TPSW3BkJ1wUWEQ2sdPKNn62KbZXzdE/RRRrao+EOsUTJgTZtUkfUNwGiKVCpF39Swbmbd5wxX4F7TgHkMR/eHuxNXfS60q5y3z2KCSD9V/rFsOQDDkPkOxMtAaMC1vEvORGD77NqqZuZ2t6zVYfxHh0tSrPjjxPy9iwHrAy4mekd47nKe08vlEsLMc2/53MckeG+WHt9Rd9/5SqaDvyL1zYObh9cIOBQysoAOscfpwXLhOEJffH1pZiNbV5UxBhASGtAXqrZpIylWQ3A2qq07ZT5YNmb3jKWs8dOpSPNEgnZPRyVJAFWTYhgQlasMIEbdxCVJtRCfD4iGbYwH77Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=214jEOHDvbqO65kJp7R9WvTe7aHGn+ywbFPey8CpPng=; b=enPJXwJauFv1oQ+Zsu+QSANwW3vkwSHO6idG1f9lavXYCMDiQj7zALU9r7ZrSNwB83ddazzAia7berLLBPNVREmY+i8jUOiFiAzFgVdPhUoiSCQgYnEuLgSz9qoiTNaXORSa7/hhnbz2uAkAxi6hltZwGxaaMH2YsrtnaxNGBH4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nyb2Zb/LWU68b4QGwWAhlcQocb72STHW3uhfNyJ/g64lELJLAmSW96qAz/OMx/oWcaZqLK49ey50C0zOyinM7uz2f7t/rswIfJA3on937Xr6rhZb33gq8yhF4bo6zdBOVTLTTmBkHDZqbrhB1LfT98VZ4UuY+vRsvJGn47rpYM2oVFn7z917NcM2U9kmEetzF9c++WTMl6VCBZgLdoLH5eaGhWUVZSpGlwrGUhQRbJUXUyod4ZZbXfyj0kyvcfN7N4KwVdsxEpfT0a5ugq9b0gRmqdJdpiXUKBiRnGKrU20+fpbtbBQlvm3ws17MFXcdqwsLv/8+HoZLqlMT5UlyGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=214jEOHDvbqO65kJp7R9WvTe7aHGn+ywbFPey8CpPng=; b=Iq5uLCPRY95NgPG05ec3/v2umI3pqGev6OJlMs7JnoSZa/9RU2leY3JSX/bYvrQkD0I7P1+cm78rMIHmjbqvjBW7B9mXVoMfVYbF+opAu4V+XE2BHctMeSKfr2XeJY44FM3zl1dqPfSUlfEMG+B6CiPQfIIlotdibkE9UBosH1EJPtygjT0yjeDg+eI5L/m71FQd9x8g57J2U6XhfKwPEIWMwIrh1riSh2LF+rAZ7E22DOaKucwUf1CTatrBeX0rJ5Q5DU7hX6WqB6NmLRg7PAqNEZZ6AHGC1dUBwtSis4KZ/YYk69flyBa7kLy0fsZiiWBcyjtBZR0lPz6uPGvmLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=214jEOHDvbqO65kJp7R9WvTe7aHGn+ywbFPey8CpPng=; b=enPJXwJauFv1oQ+Zsu+QSANwW3vkwSHO6idG1f9lavXYCMDiQj7zALU9r7ZrSNwB83ddazzAia7berLLBPNVREmY+i8jUOiFiAzFgVdPhUoiSCQgYnEuLgSz9qoiTNaXORSa7/hhnbz2uAkAxi6hltZwGxaaMH2YsrtnaxNGBH4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Fri, 7 Aug 2026 16:24:00 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 1/9] mm: introduce hw_pte_t for PTE table storage To: Alexander Gordeev References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-2-usama.anjum@arm.com> <3db8233c-3785-444e-b2eb-3e5fc5cb2f17-agordeev@linux.ibm.com> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: <3db8233c-3785-444e-b2eb-3e5fc5cb2f17-agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0612.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::6) To VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3421:EE_|DU0PR08MB10360:EE_|DU2PEPF00028D12:EE_|VI0PR08MB10800:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b1f1875-57fb-491d-136b-08def4980165 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|7416014|22082099003|18002099003|56012099006|4143699003|11063799006|10067099003|6133799003; X-Microsoft-Antispam-Message-Info-Original: 2t3nqJ+jv2XLoMl6etGaV134C/dZQIRkfbXAbpMvG3W60rxh9JNS7vnG7JumwZOuXshH8/Khuk3XFmNjAOvraHt1FiMxY6SDqUc2bwJ7gjYZ8RtOPYKcClF0QM+zYRhnM2CHCrpr7hoXmeUcNK1NloD1WpyVejEgA1J4jgFzdItq9u6OyZXdImufdWj+LEBGS6IBmv+6/BB4ye4g2SKWQIknvPuEDBuj1QJcOVK16BBecyhY/ujuWGSnNHP185oWRvXeO9VonLi2CbWPODWWJ6+GNA1EHlmq0Q4ZqO2p+w3c5VO7/ibcU56cA9Zm1BPAr5gV3dSiIY5gBrrO0GhJM/Nz6RG84n0RW8uE6xU5lIhiU0aD67U5Nv3EgUz3WjaosLO/zSgKYoBUWVByOz+9Priy7ZB1ksCjLvXt3lJinMQPrFeYsVK6CNwe9nME7chQkisUZPHEKJn9+l8p6tsQWo4cFJaBq/z/0EYkPFoVR0A8yv0iaX3Wc+ux7aTJ/42G09Rj3Dead4InmbspUi+Ht3U8qdwytMOXQUE/LL9p10Moqf0AmvqZoPncIsUwaQ4XpIbvzZ39tWHKbpiuDcdyBJ5WqoGT7NG2PDYTvLuVLzk29GuoAKjCGC+s6nyChN0n+dYaspSn0T4UGPXwMasE55ULyoI/4NgyGnNil4b9eEY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3421.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(7416014)(22082099003)(18002099003)(56012099006)(4143699003)(11063799006)(10067099003)(6133799003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: dlDyhQkPRofMsLRSwwlNt05buGPmBxT0qhTwS66CFq8RqMH9JnrYeuRl/dIwLMTa3S0/tZc6rtzklCAqGaMnZaEqdUOy9ty+kky5eI4h+1Wf1WKIT0YHlFeHr0vRqQZTfCnso0G6QzigOOedxx6gMxysMT0bK0ziCJd0J1RyfKzdTW8odKVbcKEuWC5tBK5BP8pSTpUvb9bqjJt22KWmnNAWz2ZwHUnOCAJKWRrFwk8vXvlbNdJcHpB5C7uykx7jnsyv/KXKYdJZ+mj0wHCvlqXKkXG1OQs27M0t8YC/n8p+GVaGFyr5QH2Su5t2Nu/Vrv2mfXu8Eux58avYedux6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10360 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D12.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 78010af5-117a-4010-9bc3-08def497e9d7 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|35042699022|14060799003|376014|7416014|1800799024|36860700016|4143699003|10067099003|11063799006|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: x2l+m/+TZiN5WDcR3BKopXymxFpy1n/w8zewuFb2y9Ds335w4O4Ipg3KOXg2n4Xh8Z6ZlmT7QUcRkLaff92m3Ne0kmAudKqF1i7KCM0DsFpx3DuUqfjaP7aF7OmXLIxPwJDeNR1W4aFtqQsMzj6mGeLYmKeqqcSPNPzag2ub2GOj2/bK/1pDOYTo1K/k4bk0vhAynOwzYNa1Nx7/1WC7PI3jL/TJiYXFCp8dpLng+J/aNdOXoAm/RLQNmFW4ljg84owYqlCIOCcbCANBBRVgveRdJU0JPGD82Od0h/a0+Oq0aW9pFkmA0o2dCO+bzsekY0s+7XFX1ZHLlI1HQN6ViBp6bPK1ybVXLSu1PwTi4Vv4eNXkBTJx5fk3hzwhU3PHuJhxB8mxgL9ZTTpSgQzsxo0vJKN+HlDTJEuEoUX6pfOPCHlhyvD80zyfKVHQsdUVjHubTkpPRxB7j+LSyo5f9JriQn5T2mpl7uwyUXioFUweqjQAZskVMuoQcyTxNU0O/sqBdp2Ce9+PHxvT6pLO2MVwmDJigEVSUruzu7+RQG81CMOio5AB+p4ZhsqB7FVhLbsM5WPYVMbMbGTGhrHYk4RU/s8FcW61yPwCV/Jr+M0S2432PHauUfoUr4fKduq/SZoY6dd/CSw7MzOR563j+j2GQhVfmsDKgWE1s4d62IKk5MiyhpQkdB08qiAYJIzxAsYqQudlQv3BkGSoxsFW4w== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(35042699022)(14060799003)(376014)(7416014)(1800799024)(36860700016)(4143699003)(10067099003)(11063799006)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: g6sLusA9X41u1ejA18zr5/0Hh+oxjNblxuqvfooYrhKJWuytwsqkYM4RBDsVD6JUPG5ejrRcqnr5/e7tppZJbWyjdo7t0o+y6z68tsoif+F1MBaBmgNHyyctH3CIoA/SkECaXcG16VOwlN9BPUQ0jemKU5fquWEAgHzOiZRFYVgG6EPWjni/TQvwedDSSGb8Razw3w014ZbBUH6R3/c0wWm24LvnYzQv+O7tSwf+LD8ovZuboPDpk0K2qUMKcAzXRFN5Agl8K8bfESJXk4tJL+oyf7av+q6WK2Br07wYwX8iCuY6olsVmayuluAaae4jxdx6l7Rfd0Sxs1FZSgFIEBdpvTlmClNis1jG6i1BiVLn1AWIPxbDqedfdPJx2hH9vhU5ko2RaVILr1JHK4cc51ZlbJ7gAPev9zfv7mGajHlpjSLdLi8QeNSS211id+sa X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2026 15:24:42.8031 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b1f1875-57fb-491d-136b-08def4980165 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D12.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10800 X-purgate-ID: tlsNG-ef75cf/1786116289-3C411AE4-3B9B8F8D/0/0 X-purgate-type: clean X-purgate-size: 3647 On 07/08/2026 8:09 am, Alexander Gordeev wrote: > On Thu, Aug 06, 2026 at 09:38:39AM +0100, Muhammad Usama Anjum wrote: >> pte_t is used both for logical PTE values and for entries stored in a PTE >> table, so pte_t * does not distinguish a pointer to a copied value from a >> pointer to table storage. >> >> Introduce hw_pte_t as the generic name for a PTE table element. Define it >> as a macro alias of pte_t by default. When an architecture selects >> ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead. >> This preserves the representation while allowing converted architectures >> to enforce the distinction at compile time. >> >> Keep the C type definitions behind an __ASSEMBLY__ check because >> architecture assembly sources can include this header indirectly. Include >> asm/page.h so consumers such as linux/vmalloc.h retain the page definitions >> they previously obtained from that header. >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> Changes since RFC v1: >> - Add the ARCH_HAS_HW_PTE_T opt-in and generic wrapper definition. >> - Exclude the C type definitions from assembly sources. >> - Update the description for the new opt-in model. >> --- >> MAINTAINERS | 1 + >> include/linux/pgtable_types.h | 17 +++++++++++++++++ >> mm/Kconfig | 3 +++ >> 3 files changed, 21 insertions(+) >> create mode 100644 include/linux/pgtable_types.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e9c8567308a75..7169bea968cf5 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -16982,6 +16982,7 @@ F: include/linux/mmu_notifier.h >> F: include/linux/pagewalk.h >> F: include/linux/pgalloc.h >> F: include/linux/pgtable.h >> +F: include/linux/pgtable_types.h >> F: include/linux/ptdump.h >> F: include/linux/vmpressure.h >> F: include/linux/vmstat.h >> diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h >> new file mode 100644 >> index 0000000000000..70c3edd00a01b >> --- /dev/null >> +++ b/include/linux/pgtable_types.h >> @@ -0,0 +1,17 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef _LINUX_PGTABLE_TYPES_H >> +#define _LINUX_PGTABLE_TYPES_H >> + >> +#include >> + >> +#ifndef __ASSEMBLY__ >> + >> +#ifdef CONFIG_ARCH_HAS_HW_PTE_T >> +typedef struct { pte_t __pte; } hw_pte_t; > > On s390 it fails to compile once we do typedef hw_pte_t *pgtable_t > in asm/page.h. m68k, powerpc and sparc may also have such problem. > > The below declaration helps to resolve it using forward declaration > and without meddling with headers, though I do not like it much: > > typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; Thank you for testing it out on s390. As __hw_pte_t isn't being used yet in this series, would s390 enablement patches add __hw_pte_t to this definition? This could have been avoided if each architecture defined its own hw_pte_t. But for now we are keeping the generic definition of hw_pte_t. > >> +#else >> +#define hw_pte_t pte_t >> +#endif >> + >> +#endif /* !__ASSEMBLY__ */ >> + >> +#endif /* _LINUX_PGTABLE_TYPES_H */ >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 331daf7fcfab5..31ba9ebf4aafd 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -1316,6 +1316,9 @@ comment "GUP_TEST needs to have DEBUG_FS enabled" >> config GUP_GET_PXX_LOW_HIGH >> bool >> >> +config ARCH_HAS_HW_PTE_T >> + bool >> + >> config DMAPOOL_TEST >> tristate "Enable a module to run time tests on dma_pool" >> depends on HAS_DMA >> -- >> 2.47.3 >> -- Thanks, Usama From xen-devel-bounces@lists.xenproject.org Fri Aug 07 16:02:30 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 16:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386132.1628258 (Exim 4.92) (envelope-from ) id 1wsN1N-0000dC-Pa; Fri, 07 Aug 2026 16:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386132.1628258; Fri, 07 Aug 2026 16:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsN1N-0000d5-MA; Fri, 07 Aug 2026 16:02:09 +0000 Received: by outflank-mailman (input) for mailman id 1386132; Fri, 07 Aug 2026 16:02:09 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsN1N-0000cx-3K for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 16:02:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsN1K-007QSw-N5 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 18:02:06 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a760178-e002-0a2a0a5209dd-0a2a450ae87e-14 for ; Fri, 07 Aug 2026 18:02:06 +0200 Received: from [160.101.131.8] (helo=na1pdmzitismtp01.tibco.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a76017d-f2d2-0a2a450a0019-a0658308b224-3 for ; Fri, 07 Aug 2026 18:02:06 +0200 Received: from fedora.eng.citrite.net (unknown [10.113.40.46]) by na1pdmzitismtp01.tibco.com (Postfix) with ESMTP id 8E8D444BFF9D; Fri, 7 Aug 2026 12:00:25 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; none From: Abdelkareem Abdelsaamad To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, jason.andryuk@amd.com, teddy.astie@vates.tech, Abdelkareem Abdelsaamad , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3] x86/nSVM: Check the L1 IOPM_BASE assigned physical address Date: Fri, 7 Aug 2026 16:58:43 +0100 Message-ID: X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1786118526-506CECFC-4DBDBEBC/0/0 X-purgate-type: clean X-purgate-size: 4957 The Xen nested virtualization code maps the physical address assigned by the L1 guests, for IOPM_BASE, directly to valid host address without sanity checks. Add sanity checks to verify the L1 assigned address is a valid guest address. This check also makes the bahavior compliant with the Hardware handling of the assigned addresses. The hardware is expected to trigger VMEXIT_INVALID with IOPM_BASE address greater than or qual to the maximum supported physical address, see the APM volume #2 (40332—Rev. 4.40—July 2026). While at it, clean up the code. Remove the unused bool viopm and the svm_vcpu::ns_oiomap_pa. Change nsvm_vmrun_permissionmap return error from literal 1 to NSVM_ERROR_VVMCB. Signed-off-by: Abdelkareem Abdelsaamad --- Changes in V3: - Switch to using gfn_valid() instead of domain_get_maximum_gpfn() to align with what is told to the guest in the CPUID. - Change nsvm_vmrun_permissionmap return error from literal 1 to NSVM_ERROR_VVMCB. - Remove parentheses (IOPM_PAGES_COUNT - 1). Changes in V2: - Rename IOPM_MAX_PAGES_DIFF and MSRPM_MAX_PAGES_DIFF constants to IOPM_PAGES_COUNT and MSRPM_PAGES_COUNT. - Drop the 2-pages for domain check. - Change the IOPM and MSRPM boundary checks. - Use gaddr_to_gfn instead of open-coding >> PAGE_SHIFT. - Use __func__ instead of hardcoding raw function names. --- Testing: - Using a locally developed XTF nested virt setup, I manually tested VMRUN instruction handling with the address value (0xffffffffffffffffUL) assigned to VMCB::iopm_base_pa: - Without the changes the address is mapped by the Xen code to the address 0x604b634000 and it completes the execution without any reported errors. - With the changes, the VMRUN execution fails and VMEXIT_INVALID is reported back in the ns_vmexit.exitcode. - CI tests: https://gitlab.com/xen-project/people/aabdelsa/xen/-/pipelines/2741283982 --- xen/arch/x86/hvm/svm/nestedsvm.c | 17 +++++++++++++---- xen/arch/x86/include/asm/hvm/svm-types.h | 2 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index b06124c2c9..e895cf12c4 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -18,6 +18,7 @@ #define NSVM_ERROR_VVMCB 1 #define NSVM_ERROR_VMENTRY 2 +#define IOPM_PAGES_COUNT 3 int nestedsvm_vmcb_map(struct vcpu *v, uint64_t vmcbaddr) { @@ -282,7 +283,7 @@ static int nsvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs) return 0; } -static int nsvm_vmrun_permissionmap(struct vcpu *v, bool viopm) +static int nsvm_vmrun_permissionmap(struct vcpu *v) { struct svm_vcpu *arch_svm = &v->arch.hvm.svm; struct nestedsvm *svm = &vcpu_nestedsvm(v); @@ -294,6 +295,15 @@ static int nsvm_vmrun_permissionmap(struct vcpu *v, bool viopm) enum hvm_translation_result ret; unsigned long *ns_viomap; bool ioport_80 = true, ioport_ed = true; + gfn_t ns_iopm_end = + gfn_add(gaddr_to_gfn(ns_vmcb->_iopm_base_pa), IOPM_PAGES_COUNT - 1); + + if ( !gfn_valid(v->domain, ns_iopm_end) ) + { + gdprintk(XENLOG_ERR, "%s invalid _iopm_base_pa address (%#"PRIx64")\n", + __func__, ns_vmcb->_iopm_base_pa); + return NSVM_ERROR_VVMCB; + } ns_msrpm_ptr = (unsigned long *)svm->ns_cached_msrpm; @@ -302,13 +312,12 @@ static int nsvm_vmrun_permissionmap(struct vcpu *v, bool viopm) if ( ret != HVMTRANS_okay ) { gdprintk(XENLOG_ERR, "hvm_copy_from_guest_phys msrpm %u\n", ret); - return 1; + return NSVM_ERROR_VVMCB; } /* Check l1 guest io permission map and get a shadow one based on * if l1 guest intercepts io ports 0x80 and/or 0xED. */ - svm->ns_oiomap_pa = svm->ns_iomap_pa; svm->ns_iomap_pa = ns_vmcb->_iopm_base_pa; ns_viomap = hvm_map_guest_frame_ro(svm->ns_iomap_pa >> PAGE_SHIFT, 0); @@ -418,7 +427,7 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) n2vmcb->_tsc_offset = n1vmcb->_tsc_offset + ns_vmcb->_tsc_offset; /* Nested IO permission bitmaps */ - rc = nsvm_vmrun_permissionmap(v, clean.iopm); + rc = nsvm_vmrun_permissionmap(v); if ( rc ) return rc; diff --git a/xen/arch/x86/include/asm/hvm/svm-types.h b/xen/arch/x86/include/asm/hvm/svm-types.h index 8acadb9dcc..beab9a3af2 100644 --- a/xen/arch/x86/include/asm/hvm/svm-types.h +++ b/xen/arch/x86/include/asm/hvm/svm-types.h @@ -51,7 +51,7 @@ struct nestedsvm { unsigned long *ns_merged_msrpm; /* guest physical address of virtual io permission map */ - paddr_t ns_iomap_pa, ns_oiomap_pa; + paddr_t ns_iomap_pa; /* Shadow io permission map */ unsigned long *ns_iomap; -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Fri Aug 07 16:08:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 16:08:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386165.1628268 (Exim 4.92) (envelope-from ) id 1wsN7S-0001hq-I0; Fri, 07 Aug 2026 16:08:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386165.1628268; Fri, 07 Aug 2026 16:08:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsN7S-0001hj-Dn; Fri, 07 Aug 2026 16:08:26 +0000 Received: by outflank-mailman (input) for mailman id 1386165; Fri, 07 Aug 2026 16:08:24 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wsN7Q-0001hd-DH for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 16:08:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsN7P-001cXz-QF for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 18:08:23 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7602e0-bab6-0a2a0a5309dd-0a2a450cc8de-22 for ; Fri, 07 Aug 2026 18:08:23 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7602f7-f479-0a2a450c0019-d155dd2aacab-3 for ; Fri, 07 Aug 2026 18:08:23 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso1901116f8f.0 for ; Fri, 07 Aug 2026 09:08:23 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021e8c5asm7639218f8f.18.2026.08.07.09.08.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 09:08:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Content-Language:References:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786118903; x=1786723703; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xcaFk3ixeEuYgcoQ8XLn+8G7y+rECFC1WUDOEimqWVw=; b=JY7iI8SiBhtmh9V6/DQvfRRLNJZtSHkcWwvRIlPSe/PUOMSq2TYAeAPIo5DFXbZe3e yRQu2YhoVOqeFGwDpAqEJ+2KGKXf7PnShta+rvgtuk0DV4ZqUWwl5YtU/tyeMyuTVXw4 jIseGjiYwEfjN2gDKN1Fv8/+4MQ/42pt2vWnsI7Y86XmhQuZp5AmU17VxTCctV3Q1/xt HnwYUymLfp+pFyBoWt6zHJQ5GEgkBSBeupWbXys1AUFmYeza29sjqvrMVx979GMkQVRH S6f7u6+w9Ex/HrH77tO+naMJ4GQUCV2pm/D+Q7bD+l4Obxr0eBAVVC3aMFrooNfQw7EI e2MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786118903; x=1786723703; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xcaFk3ixeEuYgcoQ8XLn+8G7y+rECFC1WUDOEimqWVw=; b=H8OcBTqCGTOjXZErhxLConT/sOXKG6j+H/Qcz/It2ky7JFW+gJiBVdr3bKD6tr228D Yse+fC9Wx/pKmfSLoB6vBzi7NOd5sOGgwIu5DUbUnttJDjLFSnvrsS8Zt53jiNZ9Xmx7 sHf3eIi8d2XC+2Vu+m/iz9J8TIhlQwI2XPH0hv6oln2ynCkJ2MiokSnx5lBbTvX3im+X 1QMQDQb84DdSL8mpa9kylPrw/Dij4HdBeDikv6OwiWCinQr3ck6/mZYuHBSxZGoZq/Ng 0yT3oYVaZuUuLMaKcR1TWr1Rnt4/DYTYiFZoYnhCE0b6vTj9XUpU08OetC8U/NI2dRx4 Ewgg== X-Forwarded-Encrypted: i=1; AHgh+RqiS/N5KYWZR/JJaS5KOte/BlKnQtTuX7o3RJPve97BR7bp7niRgPsxiQyLzRa2rKOKX6PRdIbrlXY=@lists.xenproject.org X-Gm-Message-State: AOJu0YzGsl5DKTFD05SScnNnK3JEnxAooCYdl8ZwHK4PxQymyDtgP5HO a7KcyYJ0VTVVTp9WwQrDIgqdquotO3xbAggOt/EN2NPJ9dLybiYhbTJ1vFf1aQ== X-Gm-Gg: AR+sD12NXLxoPxIZGBTIMsuanMKyi8u4fFqZOscbmE4SCaXBKoKDTtjPjuUnym4VVGU URQTl/uc1I4S8lUPbFGpLO7VPnU0+P0apzcx04ll0/OichUbnI0hnkXgI0acSOEFEZD/2Wy9N43 RCbtF2ENWJTCqd1DkUYi8UKemfq1wHpGwm07YvajTUu1bs9Ec2MEjQnCur3ILroJH8YaJ50rZco iPi6yn2plj65IzIpVL9u/bkLF6+EI8d+u6dopWD86Dd+iWAj3DFK/B8fqjac5ehSK+WbNh0exwG CSP+eZSZo5pQMh9b7jFHOfbxQnbJqWD9cYf1kbgEWoyA7micE560HyArjfJzK7FnldKtOiu4roY t2Bw7CO23509PLMhmTvHvR/lpuamDyXCWNCqkiMUSw5eFt+mLW85KwEaax9RzxR022A11ryrbMa nH8WXu55eHIYSrUq6DHAH6toFslF2Ze5/q6fLoP78sV5O1FhSUB5wxsmWvuj2d5Oq2HmnR93S5z gvaL53kOI18SGoby/j+kn8hvVm8xnqxUquliFJAE5o= X-Received: by 2002:a05:6000:1787:b0:47f:8802:c182 with SMTP id ffacd0b85a97d-47fec63cdd1mr36686966f8f.29.1786118902822; Fri, 07 Aug 2026 09:08:22 -0700 (PDT) Message-ID: <4c62661a-f944-4806-824a-e74bcbaea3df@gmail.com> Date: Fri, 7 Aug 2026 18:08:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Oleksii Kurochko Subject: Re: [PATCH v1 05/17] xen/riscv: implement virtual APLIC MMIO emulation To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <5571644f1d3a4277dc95fe85099563a145d1d935.1784560663.git.oleksii.kurochko@gmail.com> <57793423-aadd-4786-90fd-2923925b766d@suse.com> Content-Language: en-US In-Reply-To: <57793423-aadd-4786-90fd-2923925b766d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1786118903-52530A5B-98AD61D7/10/73395122804 X-purgate-type: spam X-purgate-size: 20273 On 8/6/26 4:28 PM, Jan Beulich wrote: > On 20.07.2026 18:02, Oleksii Kurochko wrote: >> Guests running under Xen program interrupt routing by writing to APLIC >> MMIO registers. Xen must intercept these accesses to enforce interrupt >> isolation between domains and to translate guest routing intent into the >> underlying physical MSI topology. >> >> Writes are gated by the domain's authorised interrupt bitmap so that a >> guest cannot affect interrupts it does not own. TARGET register writes >> additionally require translation of the hart and IMSIC guest-file >> indices from virtual to physical, as the APLIC uses these fields >> directly to compute the MSI delivery address. >> >> Delegation (APLIC_SOURCECFG_D) is not yet supported. >> >> Co-developed-by: Romain Caritey >> Signed-off-by: Oleksii Kurochko >> --- >> Reviewed-by: Baptiste Le Duc # vaplic_mmio_{read,write} > > For this tag to have any meaning, it should move ahead of the --- above; > the explanations ... > >> The downstream changes related to `vaplic_mmio_{read,write}` were originally >> in a separate patch (which was reviewed by Baptiste). However, before >> upstreaming, it was decided to merge them into the current patch. >> I added `Reviewed-by: Baptiste` in this form for now, but Baptiste will >> probably review the remaining changes as well. >> Once that happens, I'll simply move the `Reviewed-by` tag up and >> remove the `#`. > > ... here rather explain the restriction on the R-b, not its odd placement. > >> --- >> Changes in v3: > > As this looks to be recurring - please get versioning of your series right. > The series is supposedly v1, but here you give the impression of it being > v3. If there really was an earlier v2 posting, why isn't the entire series > here v3? It is v3 before before it was a part of another patch series connected to dom0less config enablement. Would it be better to just write in "Change in v3" that it is moved from another patch series + link to that patch series? Or it will be enough just to drop "Changes in v2 and v1" and just start from v1? > >> --- a/xen/arch/riscv/aplic-priv.h >> +++ b/xen/arch/riscv/aplic-priv.h >> @@ -48,4 +48,6 @@ struct aplic_priv { >> */ >> extern unsigned int guest_aplic_num_sources; >> >> +uint32_t aplic_msi_target_gen(const struct vcpu *target_vcpu, uint32_t base_val); > > PLease can you, before submitting, self-review your patches? I'm really > getting tired of having to repeatedly point out basic style issues, like > the overlong line here. Sorry for that, I will write an extra checker for such cases to not miss them. > >> @@ -38,6 +39,60 @@ static struct intc_info __ro_after_init aplic_info = { >> .hw_variant = INTC_APLIC, >> }; >> >> +static unsigned long aplic_hart_field(unsigned long hartid) >> +{ >> + const struct imsic_config *imsic = imsic_get_config(); >> + unsigned int lhxw = imsic->hart_index_bits; >> + unsigned int hhxw = imsic->group_index_bits; > > It extends to the other local variables here, but I'll use these two to > try to make my point: I'm struggling to associate the names with the > values they are set to. Likely "hxw" is an abbreviation of hart index > width, but (a) what's the leading 'l' then and (b) why is there no 'g' > in "hhxw"? By using hard to grasp names, you make it hard to actually > understand the subsequent expressions, in particular ... The names it taken directly from AIA spec: The use of this value and fields HHXS (High Hart Index Shift), LHXS (Low Hart Index Shift), HHXW (High Hart Index Width), and LHXW (Low Hart Index Width) for determining target addresses for MSIs is described later, in Section 4.9.1. The AIA specification interprets the machine-level hart index as a combination of the **group index** (`g`) and the **hart index within the group** (`h`), according to the following formulas: ``` (1) g = (machine-level hart index >> LHXW) & (2^HHXW − 1) (2) h = machine-level hart index & (2^LHXW − 1) ``` (In our case, the machine-level hart index is equal to `mhartid`, i.e. the hart index.) For systems that use IMSIC groups, the IMSIC address layout is defined by the following parameters: * `lhxw` (Low Hart Index Width, or *k*): the number of bits used for the hart number within a group. * `hhxw` (High Hart Index Width, or *j*): the number of bits used for the group number. * `hhxs` (High Hart Index Shift): the bit offset of the combined hart/group index field within the physical address. To extract the group index, we first shift the address by `hhxs` so that the group index bits are aligned, and then apply a mask derived from `hhxw` to isolate those bits. The hardware performs the same operation to extract the hart index from the MSI address. However, in our case we already know which hart should receive the interrupt (`hartid`), so there is no need to extract the hart index from the base address. We only need to recover the group index and combine it with `hartid` to construct the value expected by the `target` register. > >> + unsigned int hhxs = >> + imsic->group_index_shift - APLIC_xMSICFGADDR_PPN_SHIFT * 2; >> + unsigned long tppn = >> + imsic->msi[hartid].base_addr >> APLIC_xMSICFGADDR_PPN_SHIFT; >> + unsigned long group_index = >> + (tppn >> APLIC_xMSICFGADDR_PPN_HHX_SHIFT(hhxs)) & >> + APLIC_xMSICFGADDR_PPN_HHX_MASK(hhxw); >> + >> + return (group_index << lhxw) | hartid; > > ... these last two. As it stands, they may be easier to understand if > you didn't have the local variables at all, despite them then getting > textually longer. With the explanation above, do the variable names make sense? To be closer to AIA spec I think it would be better to rename group_index to g and hart_id to h. Does it make sense to you? >> + >> +uint32_t aplic_hw_read_reg(unsigned int offset, uint32_t mask) >> +{ >> + unsigned long flags; >> + uint32_t val; >> + >> + ASSERT((offset < aplic.size) && IS_ALIGNED(offset, sizeof(uint32_t))); >> + >> + spin_lock_irqsave(&aplic.lock, flags); >> + val = readl((volatile void __iomem *)aplic.regs + offset) & mask; > > Wouldn't this applying of a mask better be done in those callers which > actually need it? It's not the least the asymmetry with ... Agree, that to be in sync, I will drop mask argument and apply it on caller side. > >> + spin_unlock_irqrestore(&aplic.lock, flags); >> + >> + return val; >> +} >> + >> +void aplic_hw_write_reg(unsigned int offset, uint32_t value) > > ... this which I consider unhelpful. > >> --- a/xen/arch/riscv/include/asm/aplic.h >> +++ b/xen/arch/riscv/include/asm/aplic.h >> @@ -28,6 +28,8 @@ >> #define APLIC_DOMAINCFG_BE BIT(0, U) >> >> /* sourcecfg register fields */ >> +#define APLIC_SOURCECFG_D BIT(10, U) > > As to the comment - this indeed looks to be a field, but ... > >> #define APLIC_SOURCECFG_SM_INACTIVE 0x0 >> #define APLIC_SOURCECFG_SM_DETACH 0x1 >> #define APLIC_SOURCECFG_SM_EDGE_RISE 0x4 > > ... these look to be values of some other field which isn't described. Please > may I (again) ask that definitions are their commentary at the very least not > misguide readers? Thanks for pointing this out. You're right, the comment is misleading as written. APLIC_SOURCECFG_D is a field, whereas the APLIC_SOURCECFG_SM_* definitions are values for the source mode (SM) field, and the comment doesn't make that distinction. I'll update the comments to describe the fields more accurately: #define APLIC_SOURCECFG_BASE 0x0004 #define APLIC_SOURCECFG_LAST 0x0ffc /* * sourcecfg[] register fields: * - bit 10 (D) selects the layout of the remaining bits; * - D = 1: bits [9:0] hold the Child Index, i.e. the source is delegated * to a child domain (unsupported by Xen); * - D = 0: bits [2:0] hold the source mode SM (WARL). */ #define APLIC_SOURCECFG_D BIT(10, U) /* SM field values (0x2 and 0x3 are reserved): */ #define APLIC_SOURCECFG_SM_INACTIVE 0x0 #define APLIC_SOURCECFG_SM_DETACH 0x1 #define APLIC_SOURCECFG_SM_EDGE_RISE 0x4 #define APLIC_SOURCECFG_SM_EDGE_FALL 0x5 #define APLIC_SOURCECFG_SM_LEVEL_HIGH 0x6 #define APLIC_SOURCECFG_SM_LEVEL_LOW 0x7 Does it look better? Probably there is not sense for two extra spaces for APLIC_SOURCECFG_SM_*. I want to show by such identation that it is values for SM field of APLIC_SOURCECFG. > >> --- a/xen/arch/riscv/include/asm/imsic.h >> +++ b/xen/arch/riscv/include/asm/imsic.h >> @@ -40,6 +40,16 @@ struct imsic_config { >> /* Base address */ >> paddr_t base_addr; >> >> + /* >> + * MSI Target Address Scheme >> + * >> + * XLEN-1 12 0 >> + * | | | >> + * ------------------------------------------------------------- >> + * |xxxxxx|Group Index|xxxxxxxxxxx|HART Index|Guest Index| 0 | >> + * ------------------------------------------------------------- >> + */ > > And the xxx-es in here mean what exactly? Don't care? Some other, unrelated > values? Yet something else? The `x` bits denote address bits that are constant across all IMSIC interrupt files. They are not used to encode the group, HART, or guest index; instead, they correspond to the fixed portion of the IMSIC address determined by the platform's memory map. For example, consider the IMSIC DT binding: interrupt-controller@28000000 { compatible = "qemu,imsics", "riscv,imsics"; interrupts-extended = <&cpu1_intc 9>, <&cpu2_intc 9>, <&cpu3_intc 9>, <&cpu4_intc 9>; reg = <0x28000000 0x2000>, /* Group0 IMSICs */ <0x29000000 0x2000>; /* Group1 IMSICs */ interrupt-controller; #interrupt-cells = <0>; msi-controller; #msi-cells = <0>; riscv,num-ids = <127>; riscv,group-index-bits = <1>; riscv,group-index-shift = <24>; }; Here, `hart_index_bits = 2` (4 CPUs) and `guest_index_bits = 0`, so the address layout becomes: 31 25 24 23 14 13 12 11 0 +-------------+-+-------------+-----+-------------+ | constant |G| constant |HART | zeros | +-------------+-+-------------+-----+-------------+ I can update the comment to say: "x denotes bits that are constant across all interrupt file addresses." or, if you think it's clearer: "x denotes bits whose values are platform-defined and common to all interrupt file addresses." Does it make sense any of suggested options? > >> --- a/xen/arch/riscv/vaplic.c >> +++ b/xen/arch/riscv/vaplic.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> #include "aplic-priv.h" >> @@ -27,6 +28,256 @@ unsigned int __ro_after_init guest_aplic_num_sources; >> >> #define FDT_VAPLIC_INT_CELLS 2 >> >> +#define AUTH_IRQ_BIT(d, irqn) ( \ >> + ((irqn) < (d)->arch.vintc->nr_virqs) && \ >> + test_bit(irqn, (d)->arch.vintc->used_irqs) ) > > Nit: Indentation. I will use the following indentation: ... (((irqn) < (d)->arch.vintc->nr_virqs) && \ test_bit(irqn, (d)->arch.vintc->used_irqs)) > >> +/* >> + * Convert a byte offset (within a SETIP/CLRIP/SETIE/CLRIE register group) to >> + * a 32-bit word index into the allocated_irqs bitmap. Each word covers 32 >> + * interrupt sources. For SOURCECFG and TARGET groups the same division also >> + * yields the interrupt number directly, because those arrays store one 32-bit >> + * register per source. >> + */ >> +#define regoffset_to_word_idx(reg_val) ((reg_val) / sizeof(uint32_t)) >> + >> +static inline uint32_t generate_auth_mask(const struct domain *d, >> + unsigned int word_idx) >> +{ >> + unsigned int first_bit = word_idx * sizeof(uint32_t) * BITS_PER_BYTE; >> + >> + if ( word_idx >= DIV_ROUND_UP(d->arch.vintc->nr_virqs, >> + sizeof(uint32_t) * BITS_PER_BYTE) ) >> + { >> + dprintk(XENLOG_DEBUG, "incorrect word_idx(%u) is passed\n", word_idx); > > Is this really meant to stay? For debug purpose it could be useful, so I prefer to have it with changing it to gprintk(XENLOG_DEBUG, ...) to understand which domain is trying to access something wrong. > >> + return 0U; > > The U suffix is mainly (even if only slightly) obfuscating things, I think. Agree, I will drop U. > >> + } >> + >> + return (uint32_t)(d->arch.vintc->used_irqs[first_bit / BITS_PER_LONG] >> >> + (first_bit % BITS_PER_LONG)); > > I don't quite understand the need for the cast. Functionally it isn't need but it documents that it is expected that translation from unsinged long to uint32_t will happen. I will drop the cast. > >> +static int cf_check vaplic_emulate_load(const struct vcpu *v, > > Why the cf_check (also for the store counterpart)? Missed to drop. Before vaplic_emulate_load() was used to initialize vints_ops. It should be dropped here. > >> +static int cf_check vaplic_emulate_store(const struct vcpu *v, >> + unsigned long addr, uint32_t value) >> +{ >> + int rc = -EINVAL; >> + const struct domain *d = v->domain; >> + unsigned int offset = addr & APLIC_REG_OFFSET_MASK; >> + >> + switch ( offset ) >> + { >> + case APLIC_SETIP_BASE ... APLIC_SETIP_LAST: >> + case APLIC_CLRIP_BASE ... APLIC_CLRIP_LAST: >> + case APLIC_SETIE_BASE ... APLIC_SETIE_LAST: >> + case APLIC_CLRIE_BASE ... APLIC_CLRIE_LAST: >> + { >> + unsigned int word_idx = >> + regoffset_to_word_idx(offset & APLIC_SETCLR_OFFSET_MASK); >> + >> + value &= generate_auth_mask(d, word_idx); >> + >> + break; >> + } >> + >> + case APLIC_SOURCECFG_BASE ... APLIC_SOURCECFG_LAST: >> + if ( value & APLIC_SOURCECFG_D ) >> + { >> + rc = -EOPNOTSUPP; >> + >> + dprintk(XENLOG_ERR, "APLIC_SOURCECFG_D isn't supported\n"); >> + >> + goto fail; >> + } >> + >> + /* >> + * As sourcecfg register starts from 1: >> + * 0x0000 domaincfg >> + * 0x0004 sourcecfg[1] >> + * 0x0008 sourcecfg[2] >> + * ... >> + * 0x0FFC sourcecfg[1023] >> + * It is necessary to calculate an interrupt number by subtracting >> + * APLIC_DOMAINCFG instead of APLIC_SOURCECFG_BASE. >> + */ >> + if ( !AUTH_IRQ_BIT(d, regoffset_to_word_idx(offset - APLIC_DOMAINCFG)) ) >> + /* Interrupt not enabled, ignore it */ >> + return 0; >> + >> + if ( value > APLIC_SOURCECFG_SM_LEVEL_LOW ) >> + { >> + gdprintk(XENLOG_ERR, >> + "value(%u) is incorrect for sourcecfg register\n", value); >> + >> + return 0; >> + } >> + >> + break; >> + >> + case APLIC_TARGET_BASE ... APLIC_TARGET_LAST: >> + { >> + struct vcpu *target_vcpu = NULL; >> + unsigned int hart_idx = value >> APLIC_TARGET_HART_IDX_SHIFT; >> + >> + /* >> + * Look at vaplic_emulate_load() for explanation why >> + * APLIC_GENMSI is subtracted. >> + */ >> + if ( !AUTH_IRQ_BIT(d, regoffset_to_word_idx(offset - APLIC_GENMSI)) ) >> + /* Interrupt not enabled, ignore it */ >> + return 0; >> + >> + if ( hart_idx < v->domain->max_vcpus ) > > You have d as a local variable. > >> + target_vcpu = v->domain->vcpu[hart_idx]; > > Use domain_vcpu()? It will be better, thanks. > >> + if ( !target_vcpu ) >> + { >> + dprintk(XENLOG_ERR, "Invalid vCPU id in target register\n"); >> + >> + /* Ignore such writings */ >> + return 0; >> + } >> + >> + value = aplic_msi_target_gen(target_vcpu, value); >> + >> + break; >> + } >> + >> + case APLIC_SETIPNUM: >> + case APLIC_SETIPNUM_LE: >> + case APLIC_CLRIPNUM: >> + case APLIC_SETIENUM: >> + case APLIC_CLRIENUM: >> + if ( !value || !AUTH_IRQ_BIT(d, value) ) >> + return 0; >> + >> + break; >> + >> + case APLIC_DOMAINCFG: >> + { >> + struct vaplic *vaplic = to_vaplic(v->domain); >> + >> + /* >> + * The domaincfg register has this format: >> + * bits 31:24 read-only 0x80 >> + * bit 8 IE >> + * bit 7 read-only 0 >> + * bit 2 DM (WARL) >> + * bit 0 BE (WARL) >> + * >> + * The most interesting bit for us is IE(Interrupt Enable) bit. >> + * At the moment, at least, Linux doesn't use domaincfg.IE bit to >> + * disable interrupts globally, but if one day someone will use it >> + * then extra actions should be done. >> + * >> + * Only DM (bit 2) and IE (bit 8) are writable here. They are assigned >> + * (not OR-ed) so that a write of 0 can also clear them (WARL), and the >> + * read-only high byte (0x80) is always kept set on read-back. >> + */ >> + if ( value & ~(APLIC_DOMAINCFG_RO | APLIC_DOMAINCFG_DM | >> + APLIC_DOMAINCFG_IE) ) >> + printk_once("%s: Ignore writes to non-writable domaincfg bits as " >> + "they are set by aplic during initialization in Xen\n", >> + __func__); >> + >> + vaplic->regs.domaincfg = APLIC_DOMAINCFG_RO | >> + (value & (APLIC_DOMAINCFG_DM | >> + APLIC_DOMAINCFG_IE)); >> + >> + return 0; >> + } >> + >> + default: >> + goto fail; > > Instead of this goto, I think you simply want to move the label here. > That'll also make the function more similar to its load counterpart. Good point. I am curious how fail label should be aligned: default: fail: gdprintk(XENLOG_WARNING, "Unhandled APLIC write at offset %#x (value %#x)\n", offset, value); return rc; } or default: fail: ? > >> @@ -105,6 +356,50 @@ static const struct vintc_init_ops __initconstrel init_ops = { >> .make_domu_dt_node = vaplic_make_domu_dt_node, >> }; >> >> +static enum io_state cf_check vaplic_mmio_read(struct vcpu *v, mmio_info_t *info, >> + register_t *r) >> +{ >> + uint32_t data = 0; >> + >> + if ( info->len != sizeof(uint32_t) || >> + !IS_ALIGNED(info->gpa, sizeof(uint32_t)) ) >> + { >> + gdprintk(XENLOG_DEBUG, >> + "VAPLIC: unaligned/wrong-width read gpa=%"PRIpaddr" len=%u\n", >> + info->gpa, info->len); > > You have v passed in here, but you'd log current. If passing in v is > necessary (i.e. here or elsewhere it may be other than current), then you > need to either ASSERT(v == current) at the top of the funciton or otherwise > handle v != current correctly. It makes sense. I will add ASSERT(v == current) here and for vaplic_mmio_write(). > >> + return IO_ABORT; >> + } >> + >> + if ( vaplic_emulate_load(v, info->gpa, &data) < 0 ) > > If all you care about is a boolean result, why not make the function return > bool? Agree, bool will be enough for vaplic_emulate_load() and vaplic_emulate_save(). Thanks! ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Aug 07 16:27:00 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 16:27:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386187.1628276 (Exim 4.92) (envelope-from ) id 1wsNPJ-00060H-VS; Fri, 07 Aug 2026 16:26:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386187.1628276; Fri, 07 Aug 2026 16:26:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsNPJ-00060A-SW; Fri, 07 Aug 2026 16:26:53 +0000 Received: by outflank-mailman (input) for mailman id 1386187; Fri, 07 Aug 2026 16:26:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsNPI-000604-7i for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 16:26:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsNPH-001esW-9S for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 18:26:51 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7606fd-8faa-0a2a0a5109dd-0a2a45018012-40 for ; Fri, 07 Aug 2026 18:26:50 +0200 Received: from [52.101.69.58] (helo=AM0PR83CU005.outbound.protection.outlook.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a76074a-5984-0a2a45010019-3465453a316f-3 for ; Fri, 07 Aug 2026 18:26:50 +0200 Received: from AS4P192CA0049.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::22) by PAXPR08MB7442.eurprd08.prod.outlook.com (2603:10a6:102:2b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.16; Fri, 7 Aug 2026 16:26:44 +0000 Received: from AMS0EPF00000199.eurprd05.prod.outlook.com (2603:10a6:20b:658:cafe::5) by AS4P192CA0049.outlook.office365.com (2603:10a6:20b:658::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.23 via Frontend Transport; Fri, 7 Aug 2026 16:26:44 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS0EPF00000199.mail.protection.outlook.com (10.167.16.245) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Fri, 7 Aug 2026 16:26:44 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) by VI0PR08MB10655.eurprd08.prod.outlook.com (2603:10a6:800:209::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.23; Fri, 7 Aug 2026 16:26:07 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4]) by VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4%3]) with mapi id 15.21.0292.018; Fri, 7 Aug 2026 16:26:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=S1XfxwbdoezrGNtcj8UyE3GCZXPXBdAlOWQPBP28V+8tyrszTTGsxfqldiEGqWUtuUE3vGD6hP9N8iWgN/hWSoqJbKvP7dCnk5mClR/jGw+Xd8ULlXemEMgYLQG5a8+SX+zAiRD/IiLlYYyj9WdOPaiYjjvyJLvzn4300I63UoltiCDj8Jg0P5yNqhROTB5cT1IJ66IKetoBSUH9ZlAkDZ0jb1JhqadNZhlcWhQg0uXCf1ZZJUT/3VejedLWxaDFhoB7eXKVxueFE8+BcEVbJjRFeKflCsN6qbZXJGnduh1MfFIEI7/GxeHQ+Rq3Rlf9McLwZh3G/s7I32c5KxrR3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MS1lmnXLC+3vPC4LjFRguif+C4PkJMlmWukiMTyIh2c=; b=QoPWnMGbeaEPY70JHB5FQkhZMhNEsKVxusaXcu3ZHcrzDdOsIH9+aABL25xarJ2p0BlpVUxRf6Rgne1yLcv5zGx6QYZC0BurUyoI26KRLxEWfz7BT1WkTKdGln9XQj+21bbKcTWU5FdswTkyPLbGGfARa3gbWsvHVimPUlPOEt/SW7LYQCODLdiyL+SIffv0U//X6j+iV2CRM+LdaMa6FV/uONol3kF+A/EQq4DM41RU4LgJE6M4FV88hSW9/TUJWGaUuxL5/L7o/ivebYQhF9bO3h+hR2CNByMmIjCJr6HDtFMzZtLfkA/9O71rEd8cKcmANziXxWRrfApO7Lw8Fw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MS1lmnXLC+3vPC4LjFRguif+C4PkJMlmWukiMTyIh2c=; b=LbE4HoBxjfRtlY7c6ZHDXc95qdWRroP7GkPtXzaFqe+eQxYuiOQOAwMBr7zadR4TuTA5v2UTuXmiECUnpZtueKfuejTnnfUkBfLrYjyJgXAvWpK0ohfjKh71EC1IompC0jkrflMssKe0/wRqt9RdzegAqcf5Dc1XBW/fb9/q1tA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FBDF7vggKyg/P39qymfNUnPXNLSQX3uZtATlVOwaLtC8TwntOHJPr284gwOOE6pZfD9pmyFHAa1UmVfQW8bWlKsBhgNU/ouiGX+26VsQpjWXWZ03OJBCOzmApMN/ySTKE8mQDBvgdWMFtoxsru3C01DYlr7vL3iyKVBB5c54bw0QQucf/VJGVkwhwn0z/NmQitzGga1XjI0FH3FYglUvWzdpCvBaLvOiejWwJW7tBPnR8nOSG9qg1A/4DhkmlwKTNOGQjqPvIBUIIUSuFkWtbpulF3P6v2SWp5fzB49KalXQ7i7JhAcvUoHoajLSseZYDQIz+xv6ilzZFCFfYm3ztg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MS1lmnXLC+3vPC4LjFRguif+C4PkJMlmWukiMTyIh2c=; b=RvoYgMTkY2CEpoffjFhgvcG6DOqoHwEYbJ3Ie40Y2aRdAowA7ORsQl6ZnFxPWEiRodcf+LQDB5UOCktktQ+uxJAXXkH3XltD1V1wzgI2rtyhQsrVcO8xIqGBAnRZ+pnWcT0zs6U3BkS0mNhhnOV96LiBzjqE7VbRskZWsDvkN+P1KzSRZcbvzKEh42wx0U5sjamKWFkxFTgC6XqVLLTJ//iITABk8mNNNio7hfW87kMwg27jLdrB+/9eJLsIyVTVEgYOvUXJ1zW80G/r81Ak3LDbRkKk/TMVrZf9o1etFK7qrsmJCJNLp2hUG362ZxNhsBXDxRQjMohSfbormJVZnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MS1lmnXLC+3vPC4LjFRguif+C4PkJMlmWukiMTyIh2c=; b=LbE4HoBxjfRtlY7c6ZHDXc95qdWRroP7GkPtXzaFqe+eQxYuiOQOAwMBr7zadR4TuTA5v2UTuXmiECUnpZtueKfuejTnnfUkBfLrYjyJgXAvWpK0ohfjKh71EC1IompC0jkrflMssKe0/wRqt9RdzegAqcf5Dc1XBW/fb9/q1tA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <5c329236-7761-4e42-a549-b822e43b4358@arm.com> Date: Fri, 7 Aug 2026 17:26:04 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 6/9] mm: convert PTE table entry to pte To: Alexander Gordeev References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-7-usama.anjum@arm.com> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0420.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::11) To VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3421:EE_|VI0PR08MB10655:EE_|AMS0EPF00000199:EE_|PAXPR08MB7442:EE_ X-MS-Office365-Filtering-Correlation-Id: 18b46daa-e409-4390-8a75-08def4a0abaf x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|23010399003|18002099003|22082099003|4143699003|11063799006|56012099006|3023799007|10067099003; X-Microsoft-Antispam-Message-Info-Original: 1mEC+1GW7muqv9YRUa+5/AFrrrerVojSEnd0ecaTJkfa3ovLhwzSUtq/5/iXk3EltNs1VIgCRf8Zh7GTAr6czHLzj1LlHiHnMTDT5Dcb24wAlC09Mw+6D5YHPspvL2sx1EVI20obl2sTrjQoXjDCgA7aBVp0HoJDluRDuV7/B58aAjYrXiLYtdilyVB/c4ILJZct9XSAPErba2JDglH3GKJD4ype/UD4mcHzequXHk1JMOE06O16tguwAUEIG0u+MJ8ggTWNqgYTzNOd6MVIq6sd2hHoWdX2Y2qjuTpQTX+YA2OBeZDzPK349/Ui6sl0RztQtbMC3yY/MuAf8RC0UbnnCeYg8DCCD41dNdhUatK+JRo5T3IK1KmdaqJIqc1SsTX08C88FG2Lg8b1iyt7B2jUsYSIVllojrtRN+9N6ntm73XxGeP7W/EKk2HijMVLt/zJ00cBPF+s6ehrAwUuLcXR3bFWdCxqikr9Hu5qgLqNLiBeQyU9LZ3Rn0uE/AjKJr7KxBolhiCVsfoUtLoROh7bFHlrC6EFaGGtVgi1y6ZHnr30Pd2XXuuZe89Ym83TMhdg1ihZmFB2EXbHj6gKjLziMPVkfqXTj4k6Xt+iMxg68NNxRNU+gVap/tVp0ZnjQsNUaocWwqx1SokpwWWnu8VdsKL2mjWzZqYQVxBsrn0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3421.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(23010399003)(18002099003)(22082099003)(4143699003)(11063799006)(56012099006)(3023799007)(10067099003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: dn/YewereVVzC5A5tIWzHJtVSWhBYpgpDSi5ALQzfsiowfVbPFqVXI1S32+w2Gf3hBalkT4ScA+EB4sUwudcOtIJhjhR9aueBLUTgRnHXPmr0dbhEUDZJ+v2rrucvP3u7iERclCslQl2A5NyoZhvKU3h4jrT3J9OorOozCFUP/qcN/HdbFVtvnLxCOyew+JGCZ6WkqiuZJrWgmbPl2r9U72xSp7bx/EmXd8DnNf3SnfIcujY2BMitEtNTLz7u55xSDP2vPsc11Dyxs/oe8ZFQ05c4AHjsCyEnqkcV8VIhBM96NYmH5IBO7uCDB0P5KyPkh6gWTBXXIEFZ97AzZVXsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10655 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000199.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0a4a3d81-f480-4118-d51a-08def4a09582 X-Microsoft-Antispam: BCL:0;ARA:13230040|14060799003|7416014|82310400026|23010399003|376014|35042699022|1800799024|36860700016|13003099007|10067099003|11063799006|56012099006|4143699003|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 3ee23sDBvCMpGWS4TDHQCLYyUuSwv+AYpmfNHpcECbYwo+er0pcuW0YBJ/JGlzMVJsYwX+sABSXsOIooXGv1Z0M+CPTlgjlg8l/Ty/wmwVr9lgrVojIjexEIkm6+ajX+jCaGQkEO1zUJo0wXkMoWdebOCQaVpddKqpa301BXJrr6TFCTFHFnP4U3N8xqK/Yw3VDWz/HR+Tmja6qer8yUgdSzdJJOcu3WoyKS89aiOVle25K9alBtrNPHYoQoWKJ06NlFBf751x6aeo652mwomwBFkHSiU2zKXMeAFWuaxSYXq1glMto7hAF/gOGGTL2KsodAfMs/ljrXF2CelpRYmy7dwl871eDCtbhP7HZoQm95AyQDVHiuS6igbUrWVHInoFmIcSSYQ/pKGROsSzIS9uHKiT7mjVo4I+Jt8RhdN6Qu7v9+iowjNrvL73d5s7jF/NcJvL+dVY88XcquKU700NMF0mYZsemFR7s3WLsgCe9H7NzHlwj0UTfVbvv+b/p3fSGye2GK0W+Cf5h6XQwGCOInM1gxaeD2SAmf6gEEMx0eI5VC946Ussig+Y5WXGfBzdXeBSVELZFMUB3Mrj0zZ87rzh8sgxNwXrn0iQFJEUDkZkzpkge9bwfairbgtuVQtzayx75zCTl1VV7FA1Sk9FfxIDz8ceClCSD8heLSBoia02CVnceaJ5LQ/HpxSzWGxbG6EIome9u0k4ClWpNNmw== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(14060799003)(7416014)(82310400026)(23010399003)(376014)(35042699022)(1800799024)(36860700016)(13003099007)(10067099003)(11063799006)(56012099006)(4143699003)(3023799007)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: d+88svJ5Haq6WSE5QYn4CZJyPMiUwhrt6t1V2RHk3Ee1c9prJyx4tb+QtGTj3UbgmutI/PnhCtEHsr35ZeMYJIjsJ1kttUusNFj9C44KxueqFhTUJy1pVRJjR7gJbqZb0XMMkZZBV8qaszUzoOYuG3Fmn74WxXMTHpIniau7xxMzQqqH+IEnWJ+LM/afEF7mm1UuFtpi61Es1j6qU/6DdzZefnT+s7uMDbLXE75755Yr3IgrwazWn4HlBUcwVZSyzmwFVXX+7IB10zw772A9Uc0UPJ5QKASwy6/zQ3PJ05eo7i0EfLOboN8P005OBeG3KiQdN6k/85+GF3+NgIOzozCldvxfEbHC+2lhiRP1hysiIPiJVK+xNnkfisRuPDTC/zUrbgJfQU3UTvywsjWWCl89sfVDR1zg4iJA8cEZxL45be/o2DGrtvgTNcV8TyCA X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2026 16:26:44.4840 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18b46daa-e409-4390-8a75-08def4a0abaf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000199.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7442 X-purgate-ID: tlsNG-d62444/1786120010-1E07B757-3A9DD1AB/0/0 X-purgate-type: clean X-purgate-size: 2574 On 07/08/2026 7:58 am, Alexander Gordeev wrote: > On Thu, Aug 06, 2026 at 09:38:44AM +0100, Muhammad Usama Anjum wrote: >> The non-MMU stub receives hw_pte_t but returns a logical pte_t >> value. Convert the stored entry through __pte_from_hw() before >> returning. >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> include/linux/hugetlb.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index bc0b9c65aa1d0..9e8b391aa4bc9 100644 >> --- a/include/linux/hugetlb.h >> +++ b/include/linux/hugetlb.h >> @@ -1283,7 +1283,7 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, >> #ifdef CONFIG_MMU >> return ptep_get(ptep); >> #else >> - return *ptep; >> + return __pte_from_hw(*ptep); > > But this is a direct dereferencing, which breaks the whole point, isn't it? Yes, this is particular line is for non MMU. In this case, CONIFG_ARCH_HAS_HW_PTE would never be defined. Hence hw_pte_t is just pte_t and direct dereference is allowed. I'd thought a lot about it; is better to leave direct dereference here or use some helper. Then used __pte_from_hw() was already being used in generic ptep_get(). There are only two users of __pte_from_hw() at this time. > > What about introducing something like pte_t ptep_get_sw(hw_pte_t *ptep) > to be used in exactly situations like this? With that the semantics of > hw_pte_t pointers becomes straightforward and closes the still ongoing > "storage vs lifetime" discussion: > > hw_pte_t* points to HW-formatted page table entries > > ptep_get() is used to obtain HW-linked/attached entries, and may wire > extra code like [1] or [2] > > ptep_get_sw() is used to obtain HW-unlinked/unattached entries and in > most cases is just a direct dereference ptep_get_sw() or ptep_get_deref() is better name here? I thought __pte_from_hw() is ugly enough that if someone tries to use it wrongly, it'll be noticed pretty easily. I'm fine with any other name. > > The caller should always know whether the entry is attached or not, so > confusions like [3] are avoided. > > 1. https://lore.kernel.org/linux-mm/20260526-kpkeys-v8-21-eaaacdacc67c@arm.com/ > 2. https://lore.kernel.org/linux-s390/650903a4-0dd9-4e6b-9d4b-3c32c5657236-agordeev@linux.ibm.com/ > 3. https://lore.kernel.org/linux-s390/b44e071d-7c9d-4e7e-a84d-4af3499a5a05@arm.com/ > >> #endif >> } >> >> -- >> 2.47.3 >> -- Thanks, Usama From xen-devel-bounces@lists.xenproject.org Fri Aug 07 18:11:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 18:11:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386265.1628285 (Exim 4.92) (envelope-from ) id 1wsP2K-0001Lh-7P; Fri, 07 Aug 2026 18:11:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386265.1628285; Fri, 07 Aug 2026 18:11:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsP2K-0001La-43; Fri, 07 Aug 2026 18:11:16 +0000 Received: by outflank-mailman (input) for mailman id 1386265; Fri, 07 Aug 2026 18:11:15 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsP2H-0001LU-Mn for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 18:11:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsP2G-004Xa2-K4 for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 20:11:12 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a761fb9-e002-0a2a0a5209dd-0a2a4509cb34-2 for ; Fri, 07 Aug 2026 20:11:07 +0200 Received: from [148.163.143.241] (helo=mx0b-00498f03.pphosted.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a761fb5-be1a-0a2a45090019-94a38ff133ca-3 for ; Fri, 07 Aug 2026 20:11:02 +0200 Received: from pps.filterd (m0367130.ppops.net [127.0.0.1]) by mx0b-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 677GPY6I687294 for ; Fri, 7 Aug 2026 18:11:01 GMT Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013000.outbound.protection.outlook.com [40.93.196.0]) by mx0b-00498f03.pphosted.com (PPS) with ESMTPS id 4fwh9ytarq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Fri, 07 Aug 2026 18:11:01 +0000 (GMT) Received: from BY1P220CA0026.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::17) by DS4PR16MB935079.namprd16.prod.outlook.com (2603:10b6:8:34b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Fri, 7 Aug 2026 18:10:57 +0000 Received: from SJ1PEPF000026C7.namprd04.prod.outlook.com (2603:10b6:a03:5c3::4) by BY1P220CA0026.outlook.office365.com (2603:10b6:a03:5c3::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.24 via Frontend Transport; Fri, 7 Aug 2026 18:10:56 +0000 Received: from mx0b-00498f04.pphosted.com (148.163.138.245) by SJ1PEPF000026C7.mail.protection.outlook.com (10.167.244.104) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Fri, 7 Aug 2026 18:10:56 +0000 Received: from pps.filterd (m0426316.ppops.net [127.0.0.1]) by mx0b-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 677GPpos735195 for ; Fri, 7 Aug 2026 14:10:55 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-use.ser.proofpoint.com [3.215.31.156]) by mx0b-00498f04.pphosted.com (PPS) with ESMTPS id 4fwht505re-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 14:10:55 -0400 (EDT) Received: from localhost ([19.12.76.221]) by cmsmtp with ESMTPSA id sP1xwLQNMQLYTsP1yw4Ucm; Fri, 07 Aug 2026 18:10:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=ppford; bh=TlrCq8h8VLV4J0xBkPzKOMs+OF2 Q33B6BaooHIRCSes=; b=dSNxbnYlbOfMQ/i3QdM16QIbLUGyMPY8QiCqTa/9mYc 4xGg637+10oRqg5Ez0Gkv0TGYcDoP4Ag4bLNSP74DBcR5/vxXzf5lgQ7A4ikziLt WgXv+dlOLnExp40t0EXCxsPINAkvMGbcwf8ZK1hIOGKLfdYq/ONDDrtCw0HkMeT2 Oi9TEyfDF0P3n6tXMa6FaeS88lNmgr2I1IMBghv2duijnRLEuM/CSQ7lxgA0BKv0 12l21jn72RMVfFtZm4f3rUY6tcYw0g5mvVOuRzh8YgXSYWP98hMLuixj4lAZReHr /tk5y9Ghl2U1AbfLk2RKUiiHAYh3ub5D1qGmUk02Fxg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lPolVldk7IM3D2km7fe4T51PyP8/3j+YwrXq6DwlVLkd4YkU7jcnJzffjtO+0nkxi7yEscx1hp/1RQ4FESR8QpfY53YqO2Iu2Uq0eDTp/PFQQ0WYUeP5nyFqVcT8+/IPLL5HUcBHtVbBBo2EARGBBrOwxANH7YygheAAP/gQ8W0wxDl8Vde+b0jVySZg+V3pRWLLvcbhi+y77mMks9hoVXJB1h5YFeJ1lCViDFzl/jV+ivDFG2efYEx86lWRc0se2PU9W/3khIBBVlpiu6GrUjG/n6iwy1xZl1Zqzcc5k7T02Xh5K2hImnUrXGDCpKnTQoxKzV+Wkm04mCEHhjbpng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TlrCq8h8VLV4J0xBkPzKOMs+OF2Q33B6BaooHIRCSes=; b=mLeTJLPq5e0gIwTVdBevH2yrvoEA3al+wZXy+ocxKneQ2AaxU2nqD0sCsnRKUJfC7jPKWdwjcRn6l7oOozz+RdP+HyUZbskg/pa5ky3OB2fqpuA1h6MFL2ALrsgMQjEJqNsdJ/XmhuAD+MdSBaIYQ5OE6YqMTWi6doyRxlQSCmBEAOj7LKYWQQwH4CZCHKBaNnk89c2CF+o3eoFX1Den43NXDcdfIXuqnI/UE8PtPTyNiI4MEt0ENBXjlCXMr05F29DldMEe81gC9nDxpvstSi1S6WmP7Deq0GFV11XERJdluWm6+leQKooVrVnlgxGyJbpT+AB2fjdqiCmg6iNcjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TlrCq8h8VLV4J0xBkPzKOMs+OF2Q33B6BaooHIRCSes=; b=FCkKc98XClcLVRupCG2uF9z6+6WNW8eSe+9CR39Y0gxlPlifEnsKf1KSwbie93/IG9k8osUhd5TuTNa8gidgI1Qj+XEy9S4rWLLHcnkrfSQP+8Zf1Ym2uEwaUj5tNxmIHAmLoS0f8eFHRf/LXgDwol16fQR0GjBOAATu0MXIWWo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 148.163.138.245) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 148.163.138.245 as permitted sender) receiver=protection.outlook.com; client-ip=148.163.138.245; helo=mx0b-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=ppserprodsaar; bh=TlrCq8h8VLV4J0xBkPzKOMs+OF2Q33B6BaooHIRCSes=; b=V/5aAixlQ+It bX2EfjGhBOHGGl6ok9T6b5weqvYrCAJH9nY17x7rEQ5ZQBwT7yjA80CSEVAo5j0S bte6KoHvDodtSM5z9L+bXRqHQhMgxakp/pf9dcmiG25eD8+mDkocN6nl+Znxke6l TEjSKwY0CpBEjicfeCn7332jrWm5VnCC1VWDvsJpPszDkaK9iy6+cdxbp6v13mrl ni/7+54HfPFsuWDxhAYh+cHF3KOpYCvSjXLenHGE6LN1nxFDKVBBzUj9NZncSzM3 2ZjK2Dt/2UueuiTe+inw5Sg6djTVcmQagnKPuj/k9+jzfSXTHLWiSUU8ao4MSDCf OtQCnUSCRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=ppfserpocford; bh=TlrCq8h8VLV4J0xBkPzK OMs+OF2Q33B6BaooHIRCSes=; b=JtgH0VxNYzBf8r8lcqxqrhP0YiLtSa2Y1IhG I9V/HwEjRsWXMIaxIuBhTOeR6oYHhXZ9uIPGPj6VbaYlntAVpG4F/FDLLmlIMkY1 e2feQqS+zqfLZDR+KJmhVDE/5n2lvr8iOCu9GU/Vm5gtjFBlI7dn9FSVDcW5d2N7 o/pZV6BFwEVM3zKnH8i5R1/Ybl4duEX+Y5/EpM0UIJ42/C0ty9Tltp48BIBBGlGc M5sXSFKHIjyIi0rQ2XlSIoiR5Lt4o0sR4tme9Ykk/a/1vU8oe+L0ljXBQI3wJoVS blTzUA4+Pjl9M2bu3LYBW34I0sRJkni3QzSr2Dhmxy78JtLQ8A== X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: sP1xwLQNMQLYTsP1yw4Ucm X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com Date: Fri, 7 Aug 2026 11:10:52 -0700 To: Jan Beulich Cc: dmukhin@ford.com, andrew.cooper3@citrix.com, anthony.perard@vates.tech, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] acpi: reboot: log reset parameters Message-ID: References: <20260801031737.344756-3-dmukhin@ford.com> <0491d3fa-ea8f-4cd7-822a-9c5a9be8d8fd@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0491d3fa-ea8f-4cd7-822a-9c5a9be8d8fd@suse.com> PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_03,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070142 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C7:EE_|DS4PR16MB935079:EE_ X-MS-Office365-Filtering-Correlation-Id: 41fbe0de-83e6-48d5-1601-08def4af3a60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|376014|23010399003|18002099003|22082099003|4143699003|11063799006|56012099006|13003099007|10067099003; X-Microsoft-Antispam-Message-Info: uYxjCVJfNd6gFypYbtjtQ94sZU49xJmIcqaSdTwPBEum31K0peJZUCwiMwQgJqFS2lLf4Qk0siBOXm0EyrIYgadLD9oIo+T2JDvmEdn6uR6w5o1QTaIhbyRv6fuoiFlfgSWx+bfRVpf65pNfgaQnMdKEzGlPlzG4jdTfOWCjyv/WQQLEHvxR7KVJLiXP41hKfhY1/NS9stiLdQLQRtLiAP8x7vZ2Gkz3hrRc9limypHMtCbnSzp4WwEE3QtPedHKix1cHsVhsRQRmaB9BHkPw2e2IRnHG8uSXpxyQkLB7msqo0kTwY5ZIf/7Xo25mGA2AyJ1zz6+tiWZseYQNharQj8m4dbsAjCTXWgYsIyEoXKN+p4I18O9pm2RMRuSKM7Hlj5VyhW3uNPFVvbe1d6VskaN4JsKVHZ5liIurNSLfvcutFg+aJtXrhAuvuTi6Ow4Cq0XzUuEziI3hd46wr24BuoZY7flAhZs2GnZ4s75fzoxk5Cu85HiglmvL+YeE8wplCSxzGNgz494e8dT6l2/FYUg5G9RaSB5KtKrW6ee0tDKZspcal68J79O5TWGWoS9wPw1XZr4AOFeQvPVG8L33aRtWSqWodI6tCdzJitvVTi6fHz1E1jRsgzEOMcGI0Mqxzo8WkM40qjS4NLWX0dtZIhBaTgFHU7DZRdjHeHrUt39oQEr/n4kICiv3ubajY9kYkzqdh9K3DBMfOESr8NHhg== X-Forefront-Antispam-Report: CIP:148.163.138.245;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0b-00498f04.pphosted.com;PTR:mx0b-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(376014)(23010399003)(18002099003)(22082099003)(4143699003)(11063799006)(56012099006)(13003099007)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ni41hoY3aOp2ceXs5ViB1HR4xkl5pe/eRfpWIzelALq5HTrfMjdz8YDBNT9678ecaHlkC/ALVZ6Rsg9w2WPwoySHgVuqzlFRPiklXNuwVEkvlMG437FUVf2uihOccEvWeceR9bhS/4CZoX4jy4kwPx9Npf9wO8BwC/H1vtp0h2hU8+i034YZx2bdIPc130Ixx3bn5Z9mD0yZa0g7duUFj0BWSxaddQ9J/7nbfrW9sgrxQ6MnJHmlopj3CAHFb+xBEnzllF290F/x0eW9QIrm05mxzDQSyqIf0IVojEBnq1vAPeUoNJw0WnMKMpEKEI3BJoCNN+cMbekigz0WNH0dcnZ+6mpgn29efqnB90djEZKVSFzIFoTL7EsQNHpym/pPt2yhBucZCyr2ZNyh31LhJIY26fCRT+jKsTUVdgq+0B9ptKonurwP+YxLuYJDalh+ X-Exchange-RoutingPolicyChecked: jQ1cU4rIQFld1UAwkXLl84P3hWPTaGBsC6hSZ1KvzTdd+ajIcBk2HTvd+BocnL/Y9rxwqke0cakkhJQTJfrlMUqoLzQFBYZ9mugmJr3ddUSNWsE63EfxUvIiggX8oNkukn7ljsOqIAGN7LwC/+8IMRIN3LdPde4CTb7oKO06Aou/QAGyNc373wI75ixu/hvW1NsqbSavC9CFNnIswv3s+MY3KYD6OWA/+viUXO8UrZyfeBlAtt7Sh+1IWF7K4UUobthnwxmQj9nlklWOAu4J0M/cpXdItOqWFQHlRzhHrdXTVRKZFhT06isjuePHjjIqMRIAAasM/1la61I5JYod1A== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: B5iaohBeSYtfk4oZY9P60S6bpcF6f+c7BWOOYm5VBoLRMGW8xRL0I0kWmhEMU6xx9Qdkp1Qfefq2sL6M+RkEpCwuFQEAhcHnDqDj7Tidk81HNQ+yOm0xy8VWObx16g6K1nRt/1dzOtYs3G3fLWxSi3+iyBxU6S6NQ7npUesEBgi3Al8yJCTCi9wu94xPjHb3r4L7dcqd9XSuUH2Szn6Ze5ejTpzK0Zd/xWOkK6f77CUtLttzOx07e+tswFo3YjIf62NGcNuXAcDnbUuVmws7at4DFRKmZpD5ulOgtYFlO+z14/2P/bVTtq1F15NR2d8BuWJSywSriheFlaw0MB4nH6IosBguOyuZN8hXTQOi05SwiGRVee/ZSm9seJ8Jv9do4XlvxMWJ7xv4hTxH5/oS6OW5BrETmHaa8uyDfwN0kTrDmK72sRr0KdybRwlVtmzlL7GmEu3bccgIlvvBG1xpr30ag2AJRw4jCBiOOoY/w8LtESFiO147PyiKrrmuvnsdg4HOXQI70Fdo5neklXwQUsv0VfOC7t1tXi55CXS9Lf9sQjigAftYx+s9pczPVzVrSp9LBv0xX1niaYaJXKTn1seNIkQEeZz2iwqDXNaap6QpX/rbMW6q9wtrmWJECtl2 X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2026 18:10:56.6268 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41fbe0de-83e6-48d5-1601-08def4af3a60 X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[148.163.138.245];Helo=[mx0b-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C7.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR16MB935079 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDE0MiBTYWx0ZWRfX1kvezEFzi9K5 Pv39NhfYMOnGofOqXjldIxYSWKZNzr7CkAWtCq3IydKcvw8Nl1t9trFbTWvJbx/Qm4mx/UwJiGA WC7p4ZZmx5PEXzijuqGqOuZxeIQHmndhmEerJ5zmKxReLCpybwTwQQzQEAwNbqgGe4AasRPAx30 ddC5zZX6dWrnxJDUL5XCu3ojrQvb3Vyb4fSGwU7owRbT736vNO6j3m+eqv0jQkmGSk2MQATNd/w 9hz6VLzd1sGagID5lihzlzONOimCTTYXqR893bb1Yp7/XnQJSPCiDoQaJwac0rewYP+IB2eJGUk m5MhSwLgiZNfIGPNBPwXGQsvS4CEuW+qb6idyLuISRKgQKdj5h+JE2HbRPiJCAOS4begnUfIBMI z+BMfzYjjxVmLlvUeHvM3VBJb6kHY7YYvXcHZH/PMATbQDohg53vrwV6H3vpR5cLRDlilkrJRNK RPMHdhJscq1qGFN2UWg== X-Authority-Analysis: v=2.4 cv=S/7pBosP c=1 sm=1 tr=0 ts=6a761fb5 cx=c_pps a=9AjoWhdl+q7f6/Aw5qa/DQ==:117 a=b7IhknPlfT0FN1EembXvig==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=vnUQfov-gS4s1L7hHvr-:22 a=VwQbUJbxAAAA:8 a=cbNQJ9GKAAAA:8 a=p0WdMEafAAAA:8 a=iox4zFpeAAAA:8 a=gQpY9S37BheUtGlbrbAA:9 a=CjuIK1q_8ugA:10 a=G69WFyCBNqGPyalROSdv:22 a=WzC6qhA0u3u7Ye7llzcV:22 X-Proofpoint-ORIG-GUID: t_oamdVL4yaJ6Gqd0i7c3CS87yG68LkV X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDE0MiBTYWx0ZWRfX1/xQPnQ1Rlfy Yisj+ESKJTIKL+6zXAjbvfwISOmurLUBUuYy3IZEz9MLuFTNdSUOILsR85DGpO48ql9VFg8RC9K Mfmg2kFIhkR2SvihXiFfcL2VUV+Y8JnHGJFXLlgonyYEqASLHgHw X-Proofpoint-GUID: t_oamdVL4yaJ6Gqd0i7c3CS87yG68LkV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_03,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070142 X-purgate-ID: tlsNG-bad1c0/1786126267-3B6D2034-DAB91B74/0/0 X-purgate-type: clean X-purgate-size: 1900 On Wed, Aug 05, 2026 at 12:18:33PM +0200, Jan Beulich wrote: > On 01.08.2026 05:17, dmukhin@ford.com wrote: > > From: Denis Mukhin > > > > Xen does not provide much details for system reset debugging in case > > system reset happens via ACPI subsystem. > > > > Log reset I/O address and reset value. > > > > While here, add the missing default case, add breaks between case > > statements and drop full stops in the loglines. > > > > Signed-off-by: Denis Mukhin > > --- > > - v1: https://lore.kernel.org/xen-devel/20260730001854.905354-2-dmukhin@ford.com/ > > - CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2723268852 > > > > Changes since v1: > > - removed wrong ASSERT_UNREACHABLE() > > And you replaced it with a printk(), which I don't view as helpful. If we > want to diagnose the address violating the spec, that should be done > elsewhere. Ack. > > > @@ -21,17 +22,30 @@ void acpi_reboot(void) > > * on a device on bus 0. */ > > switch (rr->space_id) { > > case ACPI_ADR_SPACE_PCI_CONFIG: > > - printk("Resetting with ACPI PCI RESET_REG.\n"); > > + sbdf = PCI_SBDF(0, 0, rr->address >> 32, rr->address >> 16); > > + printk("Resetting with ACPI PCI %pp RESET_REG at %#lx (%#x)\n", > > + &sbdf, rr->address & 0xff, reset_value); > > rr->address is u64, and the code here isn't arch-specific. Yes, the file is > built for x86 only right now, so 'l' as format modifier is kind of okay for > the time being. But really PRIx64 would want using. (I'm sorry for not > noticing this on v1 already.) I had doubts on that one, but decided to go with 'l' in v2. > > Preferably with that adjustment and with the excess log message dropped > again (I can certainly do so while committing): > Reviewed-by: Jan Beulich Thank you! > > Jan > From xen-devel-bounces@lists.xenproject.org Fri Aug 07 21:29:07 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 07 Aug 2026 21:29:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386340.1628293 (Exim 4.92) (envelope-from ) id 1wsS7U-0000IL-GY; Fri, 07 Aug 2026 21:28:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386340.1628293; Fri, 07 Aug 2026 21:28:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsS7U-0000IE-DV; Fri, 07 Aug 2026 21:28:48 +0000 Received: by outflank-mailman (input) for mailman id 1386340; Fri, 07 Aug 2026 21:28:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsS7S-0000I7-SF for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 21:28:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsS7R-008FS8-JY for xen-devel@lists.xenproject.org; Fri, 07 Aug 2026 23:28:45 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a764dc4-2eae-0a2a0a5409dd-0a2a4502dd92-32 for ; Fri, 07 Aug 2026 23:28:45 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a764e0c-6ca4-0a2a45020019-b9ff1c239c41-3 for ; Fri, 07 Aug 2026 23:28:45 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fde20d3e4000e099.005 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 07 Aug 2026 21:28:41 +0000 Received: from localhost.localdomain (88-188-240-210.subs.proxad.net [88.188.240.210]) (Authenticated sender: teddy.astie@vates.tech) by mail2.vates.fr (Postfix) with ESMTPSA id 540A1835D6; Fri, 7 Aug 2026 23:28:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=siQjNhS1rXHQWa6eDG4c4KcvJWFe9SWt3KniEaLmaqw=; h=from:subject:date:message-id:to:cc:mime-version:content-type:feedback-id; b=oOchjdIjqNY73vWIm+X3lBJirJzsJpZnFCh+IN2ROdO7Nm4qe4Qv5qUmQ5mWndQQ3DHXGwTK6 PytkPhENDY8BW2FP5j/tKa1hD1XvZHfFBJFgx6p6csPsOgZxFK4HJ61RosdYGe5DW///shObQjq cEmHuNsc/b+1jmJ06gaY15+OI6/crVWEuyvrNt8lZ6YGwRrcRSX0LN9hZAho+4UYrazo/GOANUD qgf3hP1+dChhmszwOi+Pld/h6+3lunu67hDyN1lhymUhpdOSxENItYXUfU3bv6KjtEne/T2jp4+ 1UqtERyGqjcJTPp9XZPGip8FxCqn4B3bvQqYSJHgxUeQ== X-Zone-Loop: 0f7696cbc95cc987e045f65c6e6af76de5cb2c0eb37c x-campaign-type: default x-transaction-id: fd0e310a-1f27-4724-be14-41255f131e87 x-swg-uid: 01-db421d96-5e6c-44da-b753-4c378dd236cc X-Mailer: Sweego Message-ID: <1786138121.8631fc262581453bbf619ec5b2062170.19fde20d3e4000e099@vates.tech> x-swg-bid: 1786138121.8631fc262581453bbf619ec5b2062170.19fde20d3e4000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Teddy Astie To: xen-devel@lists.xenproject.org Cc: Teddy Astie , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Kevin Lampis Subject: [PATCH] public/xen.h: Update comment on mmu_update sub-command size and PTE alignment Date: Fri, 7 Aug 2026 23:28:10 +0200 MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.1f09.34907377b737dadc.19fde20d17d.acbe1d96dc5fb6c6=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786138120576 X-purgate-ID: tlsNG-720697/1786138125-323D42AC-1DCA6395/0/0 X-purgate-type: clean X-purgate-size: 4436 ---=Part.1f09.34907377b737dadc.19fde20d17d.acbe1d96dc5fb6c6=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable HYPERVISOR_mmu_update passes a set of request, where each request has a poi= nter to the PTE along with a sub-command=2E The PTE alignment padding is used to transport the sub-command while the r= est is used as a address to a PTE entry=2E The current documentation state tha= t the 2 first bits are used for sub-command, hence the other ones for PTE which imply here a 4-bytes alignment on PTEs=2E On PV64 and PV32-PAE guests, all pagetable PTEs are 8-bytes aligned, hence off-by-4 PTEs addresses are always incorrect=2E Non-PAE PV32 guests used "legacy pagetables" which had 4-byte aligned PTEs=2E However, support had been completely removed since Xen 4=2E0, and were only available when Xen = was built in 32-bits non-PAE mode [1]=2E Current Xen logic behave as if 3 bits are used as sub-command, thus all off-by-4 PTEs are actually rejected as being unknown sub-commands=2E Adjust the documentation to match the current logic implemented in Xen, also expanding the documented sub-command parameter to 3 bits=2E [1] 84d54d5d8b31 ("i386: Remove non-PAE hypervisor build target=2E") Signed-off-by: Teddy Astie --- This happens to be a complete rewording of [2]=2E I'm not sure what to do = exactly regarding the signed-off=2E CC: Kevin Lampis This now expanded sub-command field can be used for your "unmap_page_range= optimisation" series to avoid having to introduce a new dedicated hypercall=2E [2] https://lore=2Ekernel=2Eorg/xen-devel/20260528075539=2E10209-3-fredian= o=2Eziglio@cloud=2Ecom/ xen/include/public/xen=2Eh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/include/public/xen=2Eh b/xen/include/public/xen=2Eh index 2149b8dd38=2E=2Eb4fef2c5ba 100644 --- a/xen/include/public/xen=2Eh +++ b/xen/include/public/xen=2Eh @@ -218,16 +218,16 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); * x =3D=3D 0 =3D> PFD =3D=3D DOMID_SELF * x !=3D 0 =3D> PFD =3D=3D x - 1 * - * Sub-commands: ptr[1:0] specifies the appropriate MMU_* command=2E + * Sub-commands: ptr[2:0] specifies the appropriate MMU_* command=2E * ------------- - * ptr[1:0] =3D=3D MMU_NORMAL_PT_UPDATE: + * ptr[2:0] =3D=3D MMU_NORMAL_PT_UPDATE: * Updates an entry in a page table belonging to PFD=2E If updating an L1= table, * and the new table entry is valid/present, the mapped frame must belong= to * FD=2E If attempting to map an I/O page then the caller assumes the pri= vilege * of the FD=2E * FD =3D=3D DOMID_IO: Permit /only/ I/O mappings, at the priv level of t= he caller=2E * FD =3D=3D DOMID_XEN: Map restricted areas of Xen's heap space=2E - * ptr[:2] -- Machine address of the page-table entry to modify=2E + * ptr[:3] -- Machine address of the page-table entry to modify=2E * val -- Value to write=2E * * There also certain implicit requirements when using this hypercall=2E = The @@ -264,17 +264,17 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); * mentioned above=2E The argument is MMUEXT_UNPIN_TABLE for all levels a= nd the * pagetable MUST not be in use (meaning that the cr3 is not set to it)= =2E * - * ptr[1:0] =3D=3D MMU_MACHPHYS_UPDATE: + * ptr[2:0] =3D=3D MMU_MACHPHYS_UPDATE: * Updates an entry in the machine->pseudo-physical mapping table=2E - * ptr[:2] -- Machine address within the frame whose mapping to modify= =2E + * ptr[:3] -- Machine address within the frame whose mapping to modify= =2E * The frame must belong to the FD, if one is specified=2E * val -- Value to write into the mapping entry=2E * - * ptr[1:0] =3D=3D MMU_PT_UPDATE_PRESERVE_AD: + * ptr[2:0] =3D=3D MMU_PT_UPDATE_PRESERVE_AD: * As MMU_NORMAL_PT_UPDATE above, but A/D bits currently in the PTE are O= Red * with those in @val=2E * - * ptr[1:0] =3D=3D MMU_PT_UPDATE_NO_TRANSLATE: + * ptr[2:0] =3D=3D MMU_PT_UPDATE_NO_TRANSLATE: * As MMU_NORMAL_PT_UPDATE above, but @val is not translated though FD * page tables=2E * --=20 2=2E54=2E0 -- | Vates XCP-ng & Xen Orchestra - Vates solutions web: https://vate= s=2Etech ---=Part.1f09.34907377b737dadc.19fde20d17d.acbe1d96dc5fb6c6=--- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 00:45:06 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 00:45:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386379.1628304 (Exim 4.92) (envelope-from ) id 1wsVBD-0001P5-Fa; Sat, 08 Aug 2026 00:44:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386379.1628304; Sat, 08 Aug 2026 00:44:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsVBD-0001Ou-Ac; Sat, 08 Aug 2026 00:44:51 +0000 Received: by outflank-mailman (input) for mailman id 1386379; Sat, 08 Aug 2026 00:44:49 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsVBB-0001Oo-UA for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 00:44:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsVBA-00EqqD-He for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 02:44:48 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a767b46-bab6-0a2a0a5309dd-0a2a4501de6c-48 for ; Sat, 08 Aug 2026 02:44:48 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a767bff-5984-0a2a45010019-ac6904fea2e6-3 for ; Sat, 08 Aug 2026 02:44:48 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id AC356600B1; Sat, 8 Aug 2026 00:44:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA8411F000E9; Sat, 8 Aug 2026 00:44:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786149886; bh=yOkvWs6dZIhxOfDfv+/i3ba1lORp8hpNwzvQJIvho3Y=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=GPyJ0bnryF6XL37qew3mlhH2YarbNIa+tif4ZHxlR6k/ZKXZPFYXTHA544WFRgRUT fllp2pOJ34aPwoxXlMDq9v4g5OYYm3qkmS5ic0vq9YICLX5w4kqhqkwPZJXNMdJXPC IEiIbDXI1pP2CUsiKeKTPgsENJRL6Ukyjd59GmCMLn1+tX4TerJOvcKtdGvfw7clad gljQZ4OOwtP1nPuJ2JG7Gy5J+joJzq/rMU1pESq/27meriQ89Ng+dIxxI1/noOj9wL rSFqe3/IMHIeT73ZjBaSPuE2suLmy5cAXtgv6h9g0/xxYcQEc3hkyO4Q8aPYbodo0T 8z+VnjvoLXL5Q== Date: Fri, 7 Aug 2026 17:44:41 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org Subject: Re: [PATCH v2 2/2] xen/common: add keyhandler to show Xen command line In-Reply-To: <20260803070047.3097846-3-dmukhin@ford.com> Message-ID: References: <20260803070047.3097846-1-dmukhin@ford.com> <20260803070047.3097846-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-d62444/1786149888-BCF47757-C0EA106E/0/0 X-purgate-type: clean X-purgate-size: 1929 On Mon, 3 Aug 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > Currently there's no way to print Xen command line on the emergency > console for debugging purposes (e.g. 'xl' is not available in dom0). > > Add new keyhander 'X' to do command line printout. > > Signed-off-by: Denis Mukhin > --- > v1: https://lore.kernel.org/xen-devel/20260730061459.2702672-2-dmukhin@ford.com/ > > Changes since v1: > - moved implementation into kernel.c > --- > xen/common/kernel.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/xen/common/kernel.c b/xen/common/kernel.c > index d1bef9ac2b2b..9f334c92e3ab 100644 > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -505,6 +506,21 @@ static int __init cf_check param_init(void) > __initcall(param_init); > #endif > > +static void cf_check show_hypervisor_info(unsigned char key) > +{ > + printk("'%c' pressed -> showing hypervisor information\n", key); > + printk("Command line: %s\n", saved_cmdline); if CONFIG_CMDLINE_OVERRIDE is defined, saved_cmdline is empty. We could at least do this: #ifdef CONFIG_CMDLINE_OVERRIDE printk("Bootloader command line ignored (CONFIG_CMDLINE_OVERRIDE=y)\n"); #else printk("Command line: %s\n", saved_cmdline); #endif Other than that it is fine for me > +} > + > +static int __init cf_check misc_init(void) > +{ > + register_keyhandler('X', show_hypervisor_info, > + "show hypervisor information", 0); > + > + return 0; > +} > +__initcall(misc_init); > + > static long xenver_varbuf_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > { > struct xen_varbuf user_str; > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Sat Aug 08 02:38:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 02:38:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386416.1628312 (Exim 4.92) (envelope-from ) id 1wsWxN-0001y9-C3; Sat, 08 Aug 2026 02:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386416.1628312; Sat, 08 Aug 2026 02:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsWxN-0001y1-6u; Sat, 08 Aug 2026 02:38:41 +0000 Received: by outflank-mailman (input) for mailman id 1386416; Sat, 08 Aug 2026 02:38:39 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsWxL-0001xv-5f for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 02:38:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsWxK-002dkF-4n for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 04:38:38 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7696a2-2eae-0a2a0a5409dd-0a2a450387fa-2 for ; Sat, 08 Aug 2026 04:38:38 +0200 Received: from [148.163.146.23] (helo=mx0a-00498f03.pphosted.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7696ac-fae8-0a2a45030019-94a39217ca32-3 for ; Sat, 08 Aug 2026 04:38:37 +0200 Received: from pps.filterd (m0367124.ppops.net [127.0.0.1]) by mx0a-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6780jSmm1685007 for ; Sat, 8 Aug 2026 02:38:35 GMT Received: from ph7pr06cu001.outbound.protection.outlook.com (mail-westus3azon11010018.outbound.protection.outlook.com [52.101.201.18]) by mx0a-00498f03.pphosted.com (PPS) with ESMTPS id 4fwmjyap7y-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Sat, 08 Aug 2026 02:38:35 +0000 (GMT) Received: from MN0PR05CA0018.namprd05.prod.outlook.com (2603:10b6:208:52c::30) by BLAPR16MB3843.namprd16.prod.outlook.com (2603:10b6:208:27c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Sat, 8 Aug 2026 02:38:32 +0000 Received: from BL6PEPF00022571.namprd02.prod.outlook.com (2603:10b6:208:52c:cafe::97) by MN0PR05CA0018.outlook.office365.com (2603:10b6:208:52c::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.10 via Frontend Transport; Sat, 8 Aug 2026 02:38:32 +0000 Received: from mx0a-00498f04.pphosted.com (205.220.161.53) by BL6PEPF00022571.mail.protection.outlook.com (10.167.249.39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Sat, 8 Aug 2026 02:38:32 +0000 Received: from pps.filterd (m0426317.ppops.net [127.0.0.1]) by mx0a-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6780l5xw1815968 for ; Fri, 7 Aug 2026 22:38:31 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-use.ser.proofpoint.com [3.215.31.156]) by mx0a-00498f04.pphosted.com (PPS) with ESMTPS id 4fsyvwg463-7 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 22:38:31 -0400 (EDT) Received: from localhost ([19.12.92.222]) by cmsmtp with ESMTPSA id sWxBwTb4fSqacsWxBwv8E7; Sat, 08 Aug 2026 02:38:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=ppford; bh=VVocyPjs5xADxPDxMphRRc5RXD7 ku5EpzkZWOv5SIjQ=; b=m75gY0m49hZT3uNrqSt4mog4Kxa1csBrgs4fyw2tXok anKQkyGva47M56lf17AZhOwcuKcfwq+wNBW6MXlz4idRi75zsnMWL3iNEDazfpM+ FDPcoVEp5e1Y9L25ftJYrVhKvSGNaA7SMJ/4V6avHbz0WyupBqYbT+jkRxirSx2e Omt/Ip521u88RdnIw8NOf+CulZzUnUXtdRUAgUUmPAxgFkVROhe21mnC4fS2VB6t G73TAO9U4hSlGuJp1+ArA/ibnxkcmYh40HpcHTYyG4TZx5ylJ7u7uBN1KUAjxmgN Y7vhWp4uDtethozEe+Swb3bBX+dNeNrshVP0hFjLHew== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o2hZhpHS6/VsLyAbbbfh1MyiVI90ia7LsJEwmFJ4hnacOaliaf1rT1uOKcHhxTfaSJXK19uV2adC0oyv34P4FN7U2rxGOY6ZWnyKNN/ninrBSWjySoVpv/csoeINC87mG0g86V4DJF+OdLBajtH/RBXIZGrEn6qPNeBeK+UimFx9H5zZlNf4F6NiTcH3Ii9Mu/11IUadXj8SLK+q3udWyV6t8npLqvEPraqbo1boilOjnUesMbdKyxhRy1byb93G6LbdXUoin9+qvSLpPCW0yeM1z2b/STKyEQ989+0rY3ZAWLw9P7CZOH0+DShrzp+7fYUxUBU8Ie0I5R+c0rnIPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VVocyPjs5xADxPDxMphRRc5RXD7ku5EpzkZWOv5SIjQ=; b=jDrGTTkI/hEvCffUQ0Oi+g8KQSi31J9erkQ3ZFD/AEGeNsGW5tySuDThWpZdpbBkiUtUXmYSy8grFnk1H7b3GlwTbwLlWQkqjsMfj4vkEDmznoFgev0qd0gbdo9lCs9ShWG/QQCYLG2+QCh1u8hglf9WsInQK2ebDkQ2uF63gPOFF0mXqf/wiSDYzni+iPEBPIekqrQUwLvFgis4/HnYfVeGTfrOp2E7UxNcFNKojIQAhPuymcOILkfpiZntQ1/OYu3gmxjxtysxdcxQNlnEG8elK+oD1Xfm0YNBg61q6z7ZCxL4vyA3BHtDyfjdbPCFW0nQJ5qxegDls0a2+CsU9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 205.220.161.53) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VVocyPjs5xADxPDxMphRRc5RXD7ku5EpzkZWOv5SIjQ=; b=KaGOw8ALV/QCf6xIA0uJIpxjmd5tgibm1TWWrcNc0TxW40+gpNFAdBUIkltfSid3DkGOXEchhJvY2nIblPJw9AaJ2cKJClY3IoNfssc9cHSpXcykipIUJr3wM5mucue/egqNbk+axWmjWnFem0IOwXY54k5NqGEOM2WDaJ9qtWs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 205.220.161.53) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 205.220.161.53 as permitted sender) receiver=protection.outlook.com; client-ip=205.220.161.53; helo=mx0a-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=ppserprodsaar; bh=VVocyPjs5xADxPDxMphRRc5RXD7ku5EpzkZWOv5SIjQ=; b=B+gu6SccxuV9 Z8eE4fjHPdQxpqXWQbGoxAe3Fwa6NgwZnKqMg1xE1kFP4DU/pBAsLss+Wnzw4H2B jtP4AqPxi518ErzH+ln70iHbrVXiNCrdNBTkLj5zxa88PTlfhjS81l12tTr0TUGO wAKEtVCT0w4tOD3aw16RENT3JfUhiENk7pHfO4oLcP3ONqZyeYx48oJbm0gslGbC Tn46rOJSaO3pc+L+/QdSHZD6jWdEQxeitwJL+rmpPoCaw5Un+JNyNnLyNvWJDj9e HVQQbDlPXO2qLiy+Zl2pg/kD1q50NTzigaOg47Caq1NXhVPBQqBM4B0KjcokPhAH GSOFTatMaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=ppfserpocford; bh=VVocyPjs5xADxPDxMphR Rc5RXD7ku5EpzkZWOv5SIjQ=; b=Aqo+lMzp0GtEvJWv/r2AKR1vfmDRZCAnPULi OXZjh+/AIbORYk89jRnePNc7Lf4gwgKDXxTKyihSJC/j7+kv7Jw6NbHvFmEnZg/8 Xaf8AI0O7cqJbQIVtnbJdhanu7kOCIEp8EdeZip7Gv8cZesTjJ/4ndCFoHId9az9 Ja+VQFrhHdZvPusRG2mi4GqC26df07zQYyTxsZamcOcrc4Tz4gilGBS3Xx1P9rvU 0sKKJbb479hZTJtAChSSdEi4JG1AH12vuaAOCSdtfcjL1w01CzX2savpxHGWlvy1 9Dci+4/sf7NrBSRtvYPXwvhY6A8KrPsvDmJslxLPzHfH/NPQuw== X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: sWxBwTb4fSqacsWxBwv8E7 X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com Date: Fri, 7 Aug 2026 19:38:28 -0700 To: Stefano Stabellini Cc: dmukhin@ford.com, xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org Subject: Re: [PATCH v2 2/2] xen/common: add keyhandler to show Xen command line Message-ID: References: <20260803070047.3097846-1-dmukhin@ford.com> <20260803070047.3097846-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-08_01,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608080019 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022571:EE_|BLAPR16MB3843:EE_ X-MS-Office365-Filtering-Correlation-Id: 37698fbd-f206-4af6-c3b0-08def4f62374 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|36860700016|82310400026|13003099007|56012099006|4143699003|11063799006|10067099003|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: MlAmNTfO8wAQMFmPiYJc+it6uKR0nq6u3z8HLJWQAzChB0bDuEV/Xz03ucgB37WPJ0p/p7nqY0u4imlock7ea5JpsUDZK22SEoq7bYvj68GzssXfwDr4WcThXgffiPIjVg+vStem7STyGnpQqHbqRRS6+O0Ad7YavISPB2mKEsi6Gff/A+IvXTYUsMwHrvYwTnNv7hNscyICqzhkABmHCwuePmklu7/YR2h01S8h3icFFSI+b+wZAc9iYUUEdq1qDeicv66DQUyx66zVnTARFM+JSv2VJC12ETiiIV1dqct5SeQCwMwv8Hvn8Ny6GZwjwYa0K1mn8NLjClSRwkbCzvNzybi0gNiCz/YlrGOKgl3ffMPN+diaqiX3nh3n0xKfIZW74pQTiMZpKVQ+55BgTdHPLyvacoU+ZPRJ/mW38aBCLg3UOH1F2ub8LbvfhbdZDA58eq4c8hSFSHWal8+36ytpmUBrS45vZy3ct5W3Sc5A88IMsUVTUKaJrR6yhfm/sdRtUszcoqtNszqxNiYjOlMK57uI4/VnTzUNuaULbfMwG3XFa+MK1XIIF8GTduGR62ZSjVZEaxWnd9NyCA5gF74HQDnZV5fKgIBvpV4zTX1zVxR99SbJ7rhpmM/+fYWMXx5Cr5wSg3KOo1it63Plx9XRvtUPEpX10RYgZrm/NSr2EfrgrNMteVFJQJ5cafuPgkxAxzakbVKPmpQnb+W5qw== X-Forefront-Antispam-Report: CIP:205.220.161.53;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0a-00498f04.pphosted.com;PTR:mx0a-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(36860700016)(82310400026)(13003099007)(56012099006)(4143699003)(11063799006)(10067099003)(18002099003)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: y8oeqO9haz5v/5BpcdEnvV8tFjAHSOJxVp02xba5XozKr5MsIpejqpIN+aIS/8DF7586oc0xp1Ti0Wi6OyNDTxsHpl28gHWOngq1CwZpbrs42kZ3fb2yub99IhifH/3WI4hCACNNZYznl2axG2PhJw75Cr8rfqv7CFg+T591R+navkTF6QqRX4wJJTKTj2a0DK5hLBJdEF6oU1g3H4qHH6/Fc02oPHybOauaoyGOFecN3RwenGwuYIGR883RjfhDt8gHIkuDUdToi9Dxsbvp0V+3m/Bk4zpZwgqMs8xFc28n2cr4c6nRe/fp3PkqTxRNd1DHXCi7R9W7hnLI96hb+rFpktG0pq6Bg0BQ/czdaIfErEydwqwPZQ2QzqteOAb0gcPGuu9qvOEtcs/y51ly3VtjpMfQKGpCb9xRxCzd2lQPQJRxgi+706u57hZ/AUAF X-Exchange-RoutingPolicyChecked: gXddJERaxPSpqJMgy1pO3stgbF1xrMNYT+SWc914Qiu/w6Ze8yOQqTEX+yvYSb56qTs4wD1vPY4z4ABeD6ruVfcKnKmaT3Zg/7Jllr4qbCp16w7VqKfCt/7fxzTiHpD+824+l/xzYeHjekpLbevtid4a3qyEe88k3qmzhCEnJMfcIN17fVDhD1wLjsjJxY1e5M79ZyMgS3suM1L5qK1gmNO1qGKb3uJvmslj4cjJywadf/D+5KAtJ9o5flegNCAKgDBoUTfSxNzeoqjzwcGjZDJzXYaHWra4Ey6tluE9+APZrV0J2zl1vYyiZwODtYGugeJvSRwxAzq56CKgyRVaTQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: M0rORpk7GN9cEZRzEHKS1XXnHoyQ93XSsyZP4Mg+2Pw/4YkxU/CzUBgnUUd5o9zriiOmnKe+hS39yLmNVGxizymX//SsRE4Oej4iUQweQKGkoqzx4OgLWpPPTxeKi6/2PrOf+f8YjWficWmMZE2DNCKrvKavQ/mRNkpPQxZQrQ9LGX5cVkIUrQc8JQAIrt655+yE9hRP8IxFPA/7Pr6MWDx8RqN7Of3CQQ5gPqSAVJOWVroQKlYIyDz0POZqzpKBSCGUoHvFbLrue73xdNvXCeckbGv62rl9ZxqwR7JMRyGijJcw894engZAEtrh7DHnWptjUFFkjyLa80HFGPpkFdC8YBi3eB/qpIfPwLjxj/cKI1WVQ2/Y71YIZt+HsDzWUzu+NfBWGl4zRbrvZwYPXo055pEk5KRYGaP9e11TG73DRvUhL61XsOBEF0TjoE+WbmIENm0HRdVWmvP+S38XMtaAVy6ZSq4VAOM1Ct4SszLxoSQFR7HYg4grNDPyO0ewt9I3fFD9kDvOct7uliLiHXHiIuKZxtPjUPOxRJQCkjriRKuIfqYQDHA0Pl/hcFdkbN0Tki1m+TXrqACj2L5j/rs4hmVhK89qQiz+cIdHgyyIr9+T3umfXwvd+WSgSCAh X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2026 02:38:32.4014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37698fbd-f206-4af6-c3b0-08def4f62374 X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[205.220.161.53];Helo=[mx0a-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022571.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR16MB3843 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA4MDAxOSBTYWx0ZWRfX3xjDHc05s/a9 8N2OSC/yW3YNiy3LBwl84FFCX+nYgb5lb0tkVIl1yPueV6xhydnXi6TFsHSAYpKPy12aJEV2i5t VbshUYTNqbepWltFgES8pdcfgRgAM46hQ+Gj9JkMyXcgy5aIDyuJ X-Authority-Analysis: v=2.4 cv=dJ+WXuZb c=1 sm=1 tr=0 ts=6a7696ab cx=c_pps a=mOf1MaddDbw/YSD//5QIpg==:117 a=lOEMawUel/sSvQipkIvNbg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=YJXg7OVxOWrJwj3yZo-i:22 a=VwQbUJbxAAAA:8 a=cbNQJ9GKAAAA:8 a=aJccLSbELdoR-C0BZckA:9 a=CjuIK1q_8ugA:10 a=G69WFyCBNqGPyalROSdv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA4MDAxOSBTYWx0ZWRfX0VBqGGVrRB6v JPg6cEBCkFx3vdL+Vp1MIVMd5QbMa9V007yeFTcVqIx7t9mKF8RCM0q3fHwIqsvFyzWRzL93AW0 ZmMxBpyPN4bAcRmI8GzQOVqJ+GWuS1TvGo4cwKjsqZeRQMq1/LfDBPZJC49TixE0mpXMcSyYRgN y67cGAJqNseRIO4qZ3wDg189VJqZTxbgZ/ObYHZUdNlCXiXKhqNahc83GEc76hJSSN4316sv0iF GnyMdzZBwuCCIgRSy7ma1bbq7P5AM5BjnSxVNCsysc26rYVECNGf+1EN/gqA5XZR5vgc35gENa5 Ix7SiikZghbA7cjnYzaU+EYJBdVUQ0JJRa0+D9RIDL8VO8R6KKfLD24kSHK132bR6VQbyXPnbgZ 38dbRZ5hL8SJSyFAa5L8FPOeg9s1TyTvXIY15LxP0hvfQWc9ZIZsK2JJzPi9kuPPK1pQokVa/J3 /pnsk9mx0bPqJc+804A== X-Proofpoint-ORIG-GUID: EIlE6y0uOYUcrdH2QAEHziZwBEFPlzUi X-Proofpoint-GUID: EIlE6y0uOYUcrdH2QAEHziZwBEFPlzUi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-08_01,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608080019 X-purgate-ID: tlsNG-33051d/1786156718-6F6C64E9-16307A8C/0/0 X-purgate-type: clean X-purgate-size: 2444 On Fri, Aug 07, 2026 at 05:44:41PM -0700, Stefano Stabellini wrote: > On Mon, 3 Aug 2026, dmukhin@ford.com wrote: > > From: Denis Mukhin > > > > Currently there's no way to print Xen command line on the emergency > > console for debugging purposes (e.g. 'xl' is not available in dom0). > > > > Add new keyhander 'X' to do command line printout. > > > > Signed-off-by: Denis Mukhin > > --- > > v1: https://lore.kernel.org/xen-devel/20260730061459.2702672-2-dmukhin@ford.com/ > > > > Changes since v1: > > - moved implementation into kernel.c > > --- > > xen/common/kernel.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/xen/common/kernel.c b/xen/common/kernel.c > > index d1bef9ac2b2b..9f334c92e3ab 100644 > > --- a/xen/common/kernel.c > > +++ b/xen/common/kernel.c > > @@ -5,6 +5,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -505,6 +506,21 @@ static int __init cf_check param_init(void) > > __initcall(param_init); > > #endif > > > > +static void cf_check show_hypervisor_info(unsigned char key) > > +{ > > + printk("'%c' pressed -> showing hypervisor information\n", key); > > + printk("Command line: %s\n", saved_cmdline); > > if CONFIG_CMDLINE_OVERRIDE is defined, saved_cmdline is empty. We could > at least do this: > > #ifdef CONFIG_CMDLINE_OVERRIDE > printk("Bootloader command line ignored (CONFIG_CMDLINE_OVERRIDE=y)\n"); > #else > printk("Command line: %s\n", saved_cmdline); > #endif Actually, CONFIG_CMDLINE can set the built-in command line which can be non-empty. Perhaps, something like this: printk("Command line (built-in): %s\n", opt_builtin_cmdline); #ifndef CONFIG_CMDLINE_OVERRIDE printk("Command line: %s\n", saved_cmdline); #endif What do you think? > > Other than that it is fine for me > > > > > +} > > + > > +static int __init cf_check misc_init(void) > > +{ > > + register_keyhandler('X', show_hypervisor_info, > > + "show hypervisor information", 0); > > + > > + return 0; > > +} > > +__initcall(misc_init); > > + > > static long xenver_varbuf_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > > { > > struct xen_varbuf user_str; > > -- > > 2.54.0 > > > From xen-devel-bounces@lists.xenproject.org Sat Aug 08 06:41:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 06:41:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386466.1628321 (Exim 4.92) (envelope-from ) id 1wsakK-0006We-Nc; Sat, 08 Aug 2026 06:41:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386466.1628321; Sat, 08 Aug 2026 06:41:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsakK-0006WN-IG; Sat, 08 Aug 2026 06:41:28 +0000 Received: by outflank-mailman (input) for mailman id 1386466; Sat, 08 Aug 2026 06:41:26 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsakI-0006WE-He for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 06:41:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsakH-0091b7-Uk for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 08:41:25 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a76cf95-2eae-0a2a0a5409dd-0a2a4508a826-0 for ; Sat, 08 Aug 2026 08:41:25 +0200 Received: from [209.85.128.180] (helo=mail-yw1-f180.google.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a76cf94-f659-0a2a45080019-d15580b4c591-3 for ; Sat, 08 Aug 2026 08:41:25 +0200 Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-81ecf499af9so3572887b3.1 for ; Fri, 07 Aug 2026 23:41:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1786171284; cv=none; d=google.com; s=arc-20260327; b=Sb6dl+QXVy3YRSDc0669Gdd5we154J9Bmi3TfZQeeeHQrzm8REsqO7/KBAO8AKxs/Y JVrwP/ollsKnfSCteINcoqTz3ipoMTfwJR/YfNeYwoQupoaREdNu4Rkde7+Zy3mx9hbf iLSjAvGYUI3Nd9lDoVYMBAAMyG70gZsDggvpk7Dtb0RDGLkCEDTCjN/AG6SjJMtEMkoB SkbGIdZ86aAD2NH0tQMpJxBU0boed0G8LiB1rrgWhDmhaH/hk2mv9EBgyPB0r0kpN2NL CME7OTMupcnH9hU9ifmPJKIzSXQ1H87Gk4CwiUFCmu4+lDYrGDDk7/0gAIBvVgRnULAL DYKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=brAEPTkTQJOk5s9dmGcGn0aA5cl+Wfl2BWYesPthOS8=; fh=gKNe9p6CUigmZ3hfEbBZPSHY3Mosr9iEmW1Mh4pK8Uo=; b=f4pGPcNVR1ELSiTv1/5B9HiSg7wS31Gl5H6EJUPtzccjQmUgiM142Iy9Mhs2tnglJP f/uayeTQk+4uKUxTCvqnWHQyo8NzTToyq6aV72S4V88ZYAgIC5QfljpFv4lr9OnoJAvn pO/JO4PxenvYnXGp+vV9yuaW9bHThCEr5JL+Alt7BmIT6D6NaoydZBnvUTGSumAme/k2 NYd+V0nMwCqCzkTHGo4bjaCFHLsZzDspehBjagqgjidg96djfT5keRJ1XRGqrVBC2S/4 so10GGazjKUejwH28BOR0o/Lw5T1rJybyZU2NIQqAc7xAV7qUbBFPvwckrf2mFUDWDMN a/CA==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786171284; x=1786776084; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=brAEPTkTQJOk5s9dmGcGn0aA5cl+Wfl2BWYesPthOS8=; b=rxIXKgN/tEvlg+Ne5hGF0Dn2JgfevxaBIDCLmF+aRSNSmU3rShDDxrhb+N43+dRYUF ySxV6whzb5LkHVJgfeRtLknApfiaeULI5BozEORBH2SQsy22G15Rsn1Nh6JEd0rucEfK 0P+dXDKqLcNBssyDP5rLu2gcfzRCkxL1N9q5LKO/ryDflGaHySP/CuKWd+2SdVFSsQpd OhETg5BpTmzAn1K7jqVqxTwIeQv0oQ1uUjbbFVIv5OOX5C6fPEDQISY4kaOXOulypLOj tNezjYkQzfdfsjkl+QnJ0ciFrY1O2RJ2IA2KQlayLzlzEXLCrR/bphp3FRV3VWnmu9Rv o/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786171284; x=1786776084; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=brAEPTkTQJOk5s9dmGcGn0aA5cl+Wfl2BWYesPthOS8=; b=oOOMULCOAOfAnRX7gxYfUm8UtLZCbH+NLpo6ugSNzrcfBxCKOqadLSPiKkLaUYMmfk MxJZkQGIKwp9f75HyFAYaCpgcFw2bg40nI0LK/QpyLpOhdNl2eNXkTyWbXjoaBJ42dxB jYI44FZJpiKr//rDfeJ9bH0guP8FScuBbmE0Qc9Mli+TLDPpxbZimCV1Tt9VvyRJ9w1U WiCGFQi2ee2YFWH2MDm27eukXx/DpyFiBU6g6yDgM1BLdHGhfV0DdU9/tNBVEBC64zdV jdkkjeVGXch5VmhnzZqn2yfgkKwsgwI+0EiKQf+GEQelEkY+WjgQZwY4+Fmdfrrfc2zt Ochw== X-Gm-Message-State: AOJu0Yzu+AV5m21LT6gYBgdCeOVtT9PvewK4CLDn1jhfC7QDs+3onZ69 Rt3c04fFllgM0zjvqudEs2x5BehKR7MMrkxbFHCSHWTeoEY4C1bFRmAJULzjlAS/+tggdmD+1TJ Br6ofApzyD2RYjPw84mkcCF8H/v0Ohv1cdkPx X-Gm-Gg: AR+sD11WmNWCERp1MoJeZfqYvWqNif/R67c9LAI76GcPbW6fGiXuCLAGfocd/YRQHAY Fwft4xEImrXzlvkuP5Nzhto77dFFuJ7UnogKrqKzgUMKrKI9Y2yuWryUB5sCpB0ym3rtAYnVXhs VFqxZchActqMlZbTo0Ifo2VMatj3bQyivvbjVzB3qVnwfNIowXebw5sVGrNhIUHnQVFz/rgzNiY D98INrW+WxBCe5kAQYQ3xJpIZ9B70eRE5PqL8iB6hnfzzn2/7YhmIGNWdZ5ON/5Px/qk+pwu5w3 qw3IBoX/rSG5QWHwO9M51SIuC5+PDl+hT2qXUl6PuAkir0dk7uqFyZicfs97udWfviMeeQGFLPn Viw== X-Received: by 2002:a05:690c:e3ed:b0:81f:d505:8ea4 with SMTP id 00721157ae682-8202243d372mr183759337b3.18.1786171284309; Fri, 07 Aug 2026 23:41:24 -0700 (PDT) MIME-Version: 1.0 References: <20260715062206.328049-1-frediano.ziglio@citrix.com> In-Reply-To: <20260715062206.328049-1-frediano.ziglio@citrix.com> From: Frediano Ziglio Date: Sat, 8 Aug 2026 07:41:11 +0100 X-Gm-Features: AUfX_mzZA91mCnnCMSoV-jVtHsRISJpZXkdZfeKuQnapIB88c-QFN9wkflUB9TE Message-ID: Subject: Re: [PATCH v8 0/4] Various patches to improve Secure Boot support To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Michal Orzel , Julien Grall , Stefano Stabellini , "Daniel P. Smith" , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c1860d/1786171285-D715E87B-E74CC900/0/0 X-purgate-type: clean X-purgate-size: 1734 On Wed, 15 Jul 2026 at 07:22, Frediano Ziglio wrote: > > These patches improve support for Secure boot. > UEFI CA memory mitigation requires memory pages to be not executable and > writable at the same time. So changing permissions and splitting some sec= tion > is required. > Remove multiboot pieces from EFI executable. > > Changes since v1: > - improved some comments; > - merged 2 pacthes removing multiboot support in x86 PE; > - removed a patch dealing with SBAT; > - other minor changes (see single patches). > > Changes since v2: > - improved some comments. > > Changes since v3: > - Added Acked-by; > - Improve commit message. > > Changes since v4: > - Messages updates; > - Clean some dependencies cause by code removal; > - Add small commit to remove a possibly unused string. > > Changes since v5: > - removed merged commit; > - remove more code/data from xen.efi output. > > Changes since v6: > - fix commit message. > > Changes since v7: > - added Acked-by, all commit are now acked. > > Frediano Ziglio (2): > Align relevant sections to 4KB > x86: Split .init section to satisfy UEFI CA memory mitigation > > Roger Pau Monn=C3=A9 (2): > x86/efi: discard multiboot and PVH support for PE binary > x86/efi: avoid a relocation in efi_arch_post_exit_boot() > > docs/hypervisor-guide/x86/how-xen-boots.rst | 6 ----- > xen/arch/x86/boot/head.S | 8 +++---- > xen/arch/x86/efi/efi-boot.h | 7 ++++-- > xen/arch/x86/xen.lds.S | 25 ++++++++++++--------- > xen/tools/combine_two_binaries.py | 2 +- > 5 files changed, 25 insertions(+), 23 deletions(-) > Ping Frediano From xen-devel-bounces@lists.xenproject.org Sat Aug 08 10:37:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 10:37:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386553.1628330 (Exim 4.92) (envelope-from ) id 1wseQ5-0006th-Vn; Sat, 08 Aug 2026 10:36:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386553.1628330; Sat, 08 Aug 2026 10:36:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wseQ5-0006tW-QO; Sat, 08 Aug 2026 10:36:49 +0000 Received: by outflank-mailman (input) for mailman id 1386553; Sat, 08 Aug 2026 10:36:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wseQ1-0006tQ-Ke for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 10:36:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wseQ1-00FlFN-19 for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 12:36:45 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a770674-2eae-0a2a0a5409dd-0a2a4509c79c-16 for ; Sat, 08 Aug 2026 12:36:44 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7706bb-be1a-0a2a45090019-5a9b32229f8a-3 for ; Sat, 08 Aug 2026 12:36:43 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsePo-00000006Fn4-0KfB; Sat, 08 Aug 2026 10:36:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=mrC+xOT3bpITTMAExjiGGBzjrg3sW5ihiujwcUvw5oE=; b=MiHbwmDIzYwEe6BwoNHGeNjHq7 f65veJY5YjTHd83AKNHa4qlLhl2EUZpbVBaKqJiRZbtmu20uTY06o1B9vUPmy9ooa0TSwVbO5SmyB Xy0GLrvdIYt0ZVf9LjZ9Y5CZGlIdKAAMhY3vBTHKxjBRud+sPw9U/bCbRI6kAK+1MRJ14Lqdn74XU imEjrXxYVgSdeKhaTEfdqtWfdcNVAMSL8GeyMQWoCow4VfoKrqiLLHSIhmsGgpzr51rHAAQTat189 ObgOshNFcjyaEjVmhcISSqs8Yd6VuRoErbndkGqxAkVjftfRavz/HKtgRiucilnU6E14iBEd/ZZjN z8nvzx4A==; Message-ID: Subject: Re: [PATCH v6 01/51] x86/apic: Provide helpers to set local APIC timer frequency in hz and khz From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 11:36:30 +0100 In-Reply-To: <20260806233609.212337-2-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-+oD9ig9rliifEw/S0oU7" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-bad1c0/1786185404-BF2DC034-66616C4B/0/0 X-purgate-type: clean X-purgate-size: 9860 --=-+oD9ig9rliifEw/S0oU7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Add and use APIs to set the local APIC timer period (given a frequency) > instead of open coding the subtle HZ math in all external callers, and > make lapic_timer_period local to apic.c. Provide APIs to specify the > frequency in both hertz and kilohertz so that Hyper-V and VMware code > aren't forced to lose precision. > > Opportunistically take the frequency as a u64 to harden against the > possibility that the frequency (in Khz) is greater than 4294967, i.e. if > the APIC timer runs at ~4.29 GHz. As pointed out by Sashiko, > 4294968 * 1000 =3D=3D 0x1_000002c0, and thus a Khz period of 4294968 woul= d > silently overflow the 32-bit unsigned integer used by most callers. > > Print out who set the period to maintain equivalent Hyper-V and VMware > functionality, and in general to make it easier to triage/debug issues. > > Cc: Michael Kelley > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-+oD9ig9rliifEw/S0oU7 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxMDM2MzBaMC8GCSqGSIb3DQEJBDEiBCDZfXqeVG3VulW1SDf7vKX5fGconm3X N2jFMhL1JOKjFzCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIADj/qkDRDOXKU7m9R5GVeBXirw935MPsnVjsswGqUR0qI7rfbDsus C317c59+rHUVhQ/RGvTbt9QTl6+kEeB8nPqpJWdyR7FUrMxTJruHZcYI9/6a74QSnQLgq9205z+o DrXBGzO1WLxZFNe5uBZGUoUgSfp1gFh1jQKOr93lavH+1uuEHKOv3MNR2V/ZxtwagTvX7rMszWsG T8auRZCEEZZQK8Nx62U4lYCn7usBnyDuR+kAgW4kcjbMDDahpdxVZKoBDNBehOoxyvWyoYjiBz8e L8FB00fFYf8rLer7VsIPPxyQNW71hVMZQfCfyr4mhnRVhEU2E/DoyeHtk0gX1LD7Ge7cs12zyqgd VGvamvr1MZT5Afvi629Y8yAfNIUPmKCp1mIcvyzob+5R7iKc6x1BYUerssfWqNl4gpt8qC3o6RFF ECLljyC2cmS/EXxxA9WZimyf5/dmKwOeO+Jn2JiLd6+i3FeK60BUu0Oph/5uZ5dOD+o/RPk3IiFC aEk+qOBVog+J++klFK7mdzacPy58SEMgWHwcQM5wRDyMJNpz51edFxxfrSLG/odY9wmI0p1mwwRx +xgd46fmnh8z3xees84PdNwk973eSCR0oaDg5ApNb+uvCPkspUT1rlOcINqHiRivu7WCn2Ll4RH/ KYW1bIAgIYcNvvK8GmKR4aQAAAAAAAA= --=-+oD9ig9rliifEw/S0oU7-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 10:37:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 10:37:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386559.1628339 (Exim 4.92) (envelope-from ) id 1wseQg-0007M1-8L; Sat, 08 Aug 2026 10:37:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386559.1628339; Sat, 08 Aug 2026 10:37:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wseQg-0007Lu-5i; Sat, 08 Aug 2026 10:37:26 +0000 Received: by outflank-mailman (input) for mailman id 1386559; Sat, 08 Aug 2026 10:37:25 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wseQe-0007KK-S9 for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 10:37:24 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wseQe-00FlFN-91 for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 12:37:24 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7706a1-2eae-0a2a0a5409dd-0a2a4508a3d4-40 for ; Sat, 08 Aug 2026 12:37:23 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7706e3-f659-0a2a45080019-5a9b3222de06-3 for ; Sat, 08 Aug 2026 12:37:23 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wseQX-00000006Fq7-0f75; Sat, 08 Aug 2026 10:37:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=f29rvv9+wlkntIPT5Ps4cFH0UXO7Vv52XKOfUHOb+Q0=; b=D2svqsHAXm4sBiBfJCyb7jCc5/ 2wMus2zAWLXhTf14y5qyPC4zugp6/m6ba1ITEUNUoKUQbjx3piavkex81lXXz4JHO/+kzvfoKKjuz WwcK/33N1SB7z6NbpQ9pe3t3ae8GqEeyNrOxP4E9VRrOzW/Mo/ig3ukPpQUke9rHChYuko6251JX0 ofhLEfsxvEh9VGdfXpONsOssRrjQ3zqdSsH7kxVdMA/F21SHMISVjgRZleSmm9JR9WXcC2nW9qXyt f9fp6iq0Nl5JMmnCJpS/CalLFw2DacVaSsjzq8fCuc/VRfMCGbDCli/r7hPfrM4Evg49V/If4+8da 2S0sG7pQ==; Message-ID: <3203fdfd32780c24eb084b6210ecbb6757ffde4d.camel@infradead.org> Subject: Re: [PATCH v6 02/51] x86/apic: Add CONFIG_X86_LOCAL_APIC=n stubs for APIC timer frequency APIs From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 11:37:16 +0100 In-Reply-To: <20260806233609.212337-3-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-xuPnJagTwLip0w74n07K" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-c1860d/1786185443-D574B87B-D715DF6B/0/0 X-purgate-type: clean X-purgate-size: 9224 --=-xuPnJagTwLip0w74n07K Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Add stubs for the apic_set_timer_frequency_{,k}hz() APIs when the kernel = is > built without support for a local APIC, and drop #ifdefs in callers that > don't need to check CONFIG_X86_LOCAL_APIC for other reasons. > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-xuPnJagTwLip0w74n07K Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxMDM3MTZaMC8GCSqGSIb3DQEJBDEiBCDqMNTrhIQcYeugvtTx9Nml3TBZja4Z MoH1u5VFH23opjCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIACpDMdxTrh/nlXzCRYR7RK5tgv/Hap8079kw9mZGcxh2T4wpY0E23 y7NBF1BFXOtAun11AXyLSjlLiJtXw3eaBJrlkc9y8OTY3t4FHSCEglOrHQh7hEYaJ98qcLkZnqnY RUXjhGNpgJv05Rx+xx1TTTAdnhvjZzruuUGTAoRGNLbSuKTqFmgwwLEwMOgEG+x6oohxkjND8mQT qgpiKi208SkPGQLQbmDKmBAT/jLjNkAUWphmht56yj3r/2i0N96GSM58zX0fa084gz4acBl2BQsY KaLH1EK6YFSjl0XdU17xBFzyqjxx1b7iQz99faWQrjR7puDMpU3ThsbpyCOV5ctjjSINjt6vQcBa 5mC5Le5E1XkdpDiqjJghuWQN1em25UeSMN7c7LY8KUmmkDENXbKoic/vm55zijHWf/Pa9vXUHBxH 8QtPvCctx4PDHz5NKUE6Xv+LJf74aaNIVbvROMNdlqojoezkJDoKMgqwEdQ0riSa3m+vd5d1ID4B QIAPdyHbP3IHHNswQOQYtQCsfDQ7R0h7NFeA4tWa3MQ143dHPNDRhzEjZ+V/bBrtQdXK5a8zzyx4 JW8WiD5oKkRRT9zD37uzo2rqWXnmJqIRWxj8UhEoXRchfz1SJRSveC4NhcjbzghCcCjLug52iLZy kl915kfTy426nEBLZ+qMrkIAAAAAAAA= --=-xuPnJagTwLip0w74n07K-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 14:40:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 14:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386662.1628348 (Exim 4.92) (envelope-from ) id 1wsiD9-0006Wn-Py; Sat, 08 Aug 2026 14:39:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386662.1628348; Sat, 08 Aug 2026 14:39:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiD9-0006Wf-LL; Sat, 08 Aug 2026 14:39:43 +0000 Received: by outflank-mailman (input) for mailman id 1386662; Sat, 08 Aug 2026 14:39:43 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiD7-0006WV-5h for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 14:39:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiD6-009kza-1B for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 16:39:40 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a773fab-e002-0a2a0a5209dd-0a2a4506b280-0 for ; Sat, 08 Aug 2026 16:39:39 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a773faa-195a-0a2a45060019-5a9b3222a42e-3 for ; Sat, 08 Aug 2026 16:39:38 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiCt-00000006XD2-20no; Sat, 08 Aug 2026 14:39:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=zcSx2XSdEAVzm2aLWJJxByNSKo4VAVjMXcHmClS1zuA=; b=Opz4fZKQr5mQdoa8mNtwrphERm UZxNV7GFNsZh6vj3rokfMu6jtiLmubRDSITaBu8i2vMFC4BdxWrHUGnKFVKsSNOJQFB12LYt0vfMq dCibvfzWu9c73U4QJ3LdLjdmZ1lcxgSFnbGlX1nK3+KVAwYhldPl4TvCe3UT4aVTUFMzkjNvjN6Cr ZF3n0ORlBUF19jlI7BqM1Vf7pzx+rHebNIfh3nrnYOZIFE5JTfh23ZcMzB2YGkolb68Obj4BtlK8t fjMNEebsqkNEwhbtKuudD1/ZatUZXMZUJcJR1HqBfYhmBZEmlmLqUzeGzdHh/nPVyJ6j+n4VyoKBw cJC26uNA==; Message-ID: <1309dea94c39c3eeaa09cb394abd8bf2d9b3d8af.camel@infradead.org> Subject: Re: [PATCH v6 04/51] x86/tsc: Restrict recalibrate_cpu_khz() export to p4-clockmod and powernow-k7 From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 15:39:26 +0100 In-Reply-To: <20260806233609.212337-5-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-+ggM4Pf5WdSfLKU8iKJa" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-16d1c6/1786199979-F7CCD77B-E05B8D16/0/0 X-purgate-type: clean X-purgate-size: 9199 --=-+ggM4Pf5WdSfLKU8iKJa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Export recalibrate_cpu_khz() only for its two users, p4-clockmod.ko and > powernow-k7.ko, to help document that recalibration is relevant only to > ancient CPUs. > > For all intents and purposes, no functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-+ggM4Pf5WdSfLKU8iKJa Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNDM5MjZaMC8GCSqGSIb3DQEJBDEiBCBBdQiKFmqXnTh3gQJ7xEHfosgUxTx5 vAPUivWkWYWhQjCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAII6kynXVCZ++SWypAd2Klh0RLvXDGvSVylQVsLJInxyXi4zN214F 69potnIz6FJoY3TtvszmTmZHsq7eX9jR1gYLV0QvI5JXeFOjqqG8B04Hge3GF6bJjPvDFVzdcokQ UI47DP+qc4C6Cuy+dkCvpIV0ZmEIgGfiJZyTN/Xfs++hwoAZrySxDcnxtxp6KovtQwB7xtCqqOj0 KUEWgJaLNhdb9ThuW3bn8QfeRS9cAK8WbnR/QLUNv56WR8FJjY9Ko0MVojQxcK595bSAohvHrh1d fgnfRGA3WwlNDaE70oq4NpxQUkUwDry7dD+BaT3OPRtHV8x+lR968zhpEqvrMH+nRbVEW3mlfXoN +XHI7iKz+8zfzU6gFD+t7H2PZSFMufuNNQeMF7D1aR85XpJEkqbXOdbwH7cuEb1xIzDjAGxJPBf2 pbuwIOh9gT14amUq0rVfvqbbCXkyWpV1mecBcgjEsM0kbVfPRC01IEY/qychxc5U08v0Ew0OTkXJ dtL1vVzGz9w8vneB1Ny6hXPFgktpfa0HwL3CQZof7Rvoh0xJ/LBG/xBicRuuS96EPhKfDaMuB3IA Fx42/Oe5ByXBhgdYcFcfG60qdllOIV5GB0tzjmqv4/9m9lKDoB7WVeFpenhuI3NMoftMcc2MsuYo iNGNcSU68Vx0IK8E98Y/kYoAAAAAAAA= --=-+ggM4Pf5WdSfLKU8iKJa-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 14:48:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 14:48:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386671.1628357 (Exim 4.92) (envelope-from ) id 1wsiLk-00005H-Hk; Sat, 08 Aug 2026 14:48:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386671.1628357; Sat, 08 Aug 2026 14:48:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiLk-000054-EA; Sat, 08 Aug 2026 14:48:36 +0000 Received: by outflank-mailman (input) for mailman id 1386671; Sat, 08 Aug 2026 14:48:35 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiLj-00004x-2Q for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 14:48:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiLi-009le7-8Y for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 16:48:34 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7741bf-bab6-0a2a0a5309dd-0a2a45038ac8-2 for ; Sat, 08 Aug 2026 16:48:34 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7741c1-fae8-0a2a45030019-5a9b3222a534-3 for ; Sat, 08 Aug 2026 16:48:34 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiLa-00000006Xtt-3R8T; Sat, 08 Aug 2026 14:48:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=xY4a+9HON7tEJc6vDtf+k5V2duOaIaUpGsGxjtTbvEs=; b=rBOnKBSIfNIiJWrONCIgb0BG7F ylD/TZimAGdzgAEI5IcIkgHTwd38AKwrBjjDHK8RPKNMPRaT9gi1rOQtAp05FECP4gcBXxbNwzcSZ 9K27YZmoAcmeXzFZbU20BTS3wuazn5qthvl0pxWs4WDw/ylYlQ2xWJAbT4yeFH5q1J6dotOsWD9zv Gw2YN5cSgII8IIvzUEpcFxm3DuG52OAn33VXMWJ3hERGDovRuCgWlAPGLJEZdsGJpRpaPO5YFDLS9 DRRdXewcmsvVBmteeZFBT4Cgu1Y+bg5IWGwaCxnEw4fvEWMHCdYIM/mH9CPBQhK2PprWvfr/4eohc 0wwE4hEA==; Message-ID: <58d4607c93e72094d0394c09c976142e7e179cb5.camel@infradead.org> Subject: Re: [PATCH v6 06/51] x86/sev: Don't override CPU frequency calibration for SNP's Secure TSC From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, nikunj@amd.com, thomas.lendacky@amd.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 15:48:25 +0100 In-Reply-To: <20260806233609.212337-7-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-2WHVA9tRtaaaro8+TEvx" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1786200514-75A814E9-A0852725/0/0 X-purgate-type: clean X-purgate-size: 10036 --=-2WHVA9tRtaaaro8+TEvx Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Don't override the kernel's CPU frequency calibration routine when > registering SNP's Secure TSC calibration routine. SNP (the architecture) > provides zero guarantees that the CPU runs at the same frequency as the > TSC. The justification for clobbering the CPU routine was: > > Since the difference between CPU base and TSC frequency does not apply > in this case, the same callback is being used. > > but that's simply not true. E.g. if APERF/MPERF is exposed to the VM, th= en > the CPU frequency absolutely does matter. > > While relying on heuristics and/or the untrusted hypervisor to provide th= e > CPU frequency isn't ideal, it's at least not outright wrong. > > Fixes: 73bbf3b0fbba ("x86/tsc: Init the TSC for Secure TSC guests") > Cc: Nikunj A Dadhania > Cc: Tom Lendacky > Reviewed-by: Nikunj A Dadhania > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse I don't think I care about Sashiko's complaint. Even if we still clamp it in generic code, I think that's better than having those in the platform-specific code. --=-2WHVA9tRtaaaro8+TEvx Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNDQ4MjVaMC8GCSqGSIb3DQEJBDEiBCCQubn/jFA3eSBfXv3QWaqzwBRRhkIm IOwbMGknJhY/TjCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAffxk/dqrhP4HMbv3HB1zGSpyStJ1EN+hO7+2zJd431JlQJq9VWW4 3vGaA3GFtSotn2ZYoZAGBd54XyqIbzafd0AV3MzDJGn1GU1rbYPIHEjnuF0pysFI+gSl4aRiHrOI GubT6zS8vJxttEIOXf1QRzl5NK/OMXiAik6SSimZo+c0e/dRM9wYO77QSGx53XW5NVKPIB8u1r6H xNHW+CA5qDIRam5Q+xk0juc0RZxaCnMJbWdmB9rDk3iVY+dv5gv28S2CQtOhfXIZx2i6q6C38bKd jmxZ6TtEWOgvqpQkwT0uH+r/AaB88xVUK0ywNaj1lRSx861QTwNsyyC2HmexOL5ON2jVN8nm5tXL l7xDZ4vWogvwguJ1sp8pnW85snUD0ngU5ANvdIZoUqi6rvgDrLWSZgOuc6i/Ka0cPdd+mhp4wJYd IHSOY564LDqmU1t3MoBbWxchW/UvYUOM4uU4uvaIZwsK1gFG/LTA9CnOoyIrvCawEPaxuFZsVMxS hDl1qqxQt9XtJJBiFN8gfcR1oUStsWwFxKX4g2hESwRn+pY+5mLYPTbezB5ZyH05xXlbzYMVfpdA gtSY8/ATfqNHJGFtt6UqvfuSRe/8gMoc6WwJlQb5d8TsTO+Oz7V548z2X3fFOkVtfiaU0IQ0480b ebvE1iHCFgXC+N29aIfPgLEAAAAAAAA= --=-2WHVA9tRtaaaro8+TEvx-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 14:50:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 14:50:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386678.1628366 (Exim 4.92) (envelope-from ) id 1wsiNU-0001bj-S4; Sat, 08 Aug 2026 14:50:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386678.1628366; Sat, 08 Aug 2026 14:50:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiNU-0001bc-Oi; Sat, 08 Aug 2026 14:50:24 +0000 Received: by outflank-mailman (input) for mailman id 1386678; Sat, 08 Aug 2026 14:50:23 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiNT-0001bS-5N for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 14:50:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiNQ-009lvu-17 for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 16:50:20 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7741e1-2eae-0a2a0a5409dd-0a2a45029296-38 for ; Sat, 08 Aug 2026 16:50:19 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a77422b-6ca4-0a2a45020019-5a9b32228bcc-3 for ; Sat, 08 Aug 2026 16:50:19 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiNI-00000006Y8K-1AmE; Sat, 08 Aug 2026 14:50:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=bnJWUG/JPui2uKucDdDHwnUhtYzLmNsoiXZpYxk9nBU=; b=XTFvbD+5iS6pcriqXmD8agcern 2FWv3Ir1GasPqGWKF61v/VQd6u2VdUgnlRwC0CcW6lzrEk8qKHOS3F10tdhT3WYBAXA2hb5XBNHok bFLrhfZbt41DRqScoE19op5dRHSpEuwAo+yDPi4a1JpUBMVMKRhTOEYvUbAjaKLiDQWgHQjVVGx/g cAi9Q9g+iOCA1tWwOzgfN/5xZo3zRtfebUDQP2MNsYwdRKmusewzwtnJTPBsnvEuN0aUEibgi5Skh fUpO1VmwLCDPjl9S4jB5tjFamBmVI2sA2tGjGpPR1UoH3nUQ/zYtpO29WBFHHPMNW+UDk0FXX7zKK XtRCOGEw==; Message-ID: <0f3e31008c86e07e020dbcdfc5a279ab76498695.camel@infradead.org> Subject: Re: [PATCH v6 08/51] x86/sev: Shove SNP's secure/trusted TSC frequency directly into "calibration" From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, nikunj@amd.com, thomas.lendacky@amd.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 15:50:10 +0100 In-Reply-To: <20260806233609.212337-9-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-mi0iPdDBicy/0pphTprS" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-720697/1786200619-F32B12AC-D4C1D000/0/0 X-purgate-type: clean X-purgate-size: 10550 --=-mi0iPdDBicy/0pphTprS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > As a first step towards dropping .calibrate_{cpu,tsc}() and explicitly > defining precedence/priority for "calibration" routines, pass the secure > TSC frequency obtained from SNP firmware directly to > determine_cpu_tsc_frequencies() instead of overriding the .calibrate_tsc(= ) > hook. > > Unlike the native calibration routines, all of the paravirtual overrides, > including SNP and TDX, are constant in the sense that the frequency > provided by the hypervisor or trusted firmware is fixed, known, and alway= s > available during early boot. More importantly, for CoCo (SNP and TDX) VM= s, > it's imperative that the kernel uses the frequency provided by the truste= d > firmware, not by the untrusted hypervisor. Enforcing the priority betwee= n > sources by carefully ordering seemingly unrelated init calls, so that the > trusted override "wins", is brittle and all but impossible to follow. > > Explicitly ignore tsc_early_khz if the exact TSC frequency was obtained > from trusted firmware, as per commit bd35c77e32e4 ("x86/tsc: Add > tsc_early_khz command line parameter"), the goal of the param is to play > nice with setups that provide partial frequency information in CPUID, i.e= . > is NOT intended to be a hard override. Neither SNP's secure TSC nor TDX > was supported when commit bd35c77e32e4 landed back in 2020, i.e. lack of > consideration for the interaction was purely due to oversight when SNP an= d > TDX support came along. > > Reviewed-by: Nikunj A Dadhania > Tested-by: Nikunj A Dadhania > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-mi0iPdDBicy/0pphTprS Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNDUwMTBaMC8GCSqGSIb3DQEJBDEiBCBXwFXXgl/z9qBpWUhMcnA7RIlh7ihZ bd+UGk7JfRe7djCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAAJnHOpJupW9mJZGzq/kZvUu4BPry95maA6XY7JFXlHcdvpFIPkBc j6z4VU1YqlFRNpDCyMzjzucpoF6y1OsLeM20pTRwDp5uQFb8XnCyyGFRPjcAaPO5t66piomh+5nT +1K01m6O3Pk9jb9akYiq8l1YjMvCOhRnNb19TV+W33ZanaHloNUxNpFHSMCbk7lm29XRAlj4gcWI eMYiF54O/PIGrzoS4S4Pcda0IaqsQvLzC4nQFV3DOOnh8Vyx6hasMqffi6z/dECSBWIlkM2Tr0+Y FtwdtnWAZvoNMrxI63dmkAUAWjWgb8fIHttZGvJxVyrZkDbk7FfDtESnyclNgJ7POmFzcxj67tmI ZNsLhYdlS2a4qz+rcPfVcsDG1NfQv5R8q9xZ7lj6WxgHQdMgFwyYxRVZpN8PA114ywECvKXfJSq/ WrZsgW9imgpB0xa5uDTO7RCDhLnctmlqsQoWpq8hArSn5liJ2zWeD+KislrBAOIk2445l3ciJAVS ZPFwl8gotWgmUgRIGW6CURWQFBjK2CgPKNEhiEl2EMgvz93uEt2BHmbV9ACmqvNl52HIW5zT9uFt SEedWaoPTUw+SHT47gZPbre9HSPx56N5EH0TcROiyi/46oaxBY0k3mqvRlshxXhOK1PyMc06a01A CvZEvf56ddFQXuDGNuyMrM4AAAAAAAA= --=-mi0iPdDBicy/0pphTprS-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 14:54:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 14:54:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386688.1628375 (Exim 4.92) (envelope-from ) id 1wsiR6-0002HY-EU; Sat, 08 Aug 2026 14:54:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386688.1628375; Sat, 08 Aug 2026 14:54:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiR6-0002HR-B0; Sat, 08 Aug 2026 14:54:08 +0000 Received: by outflank-mailman (input) for mailman id 1386688; Sat, 08 Aug 2026 14:54:07 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiR4-0002HL-Vt for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 14:54:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiR4-009mCq-6P for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 16:54:06 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7742c0-8faa-0a2a0a5109dd-0a2a4504a59a-38 for ; Sat, 08 Aug 2026 16:54:05 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a77430d-b57f-0a2a45040019-5a9b3222e7c0-3 for ; Sat, 08 Aug 2026 16:54:05 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiQw-00000006YJq-463R; Sat, 08 Aug 2026 14:53:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=Cuh+2guypgME3E5tPAMft+l41S7Z051cLycWAT64MZc=; b=KvnfyU3Kg+Hyujh2eKk8oY/xbS AWycnumVzq2JvmDw3H2xzJa7LvtAG2SLujPf8ebnAmlYv/VsGtvSs3wpeNL7ayKVAxPPqElMyIJko U44CufxlA0UUnsperbJHSupH+gpofgP1UCW9i2OBfzSOa5NrLm4WS6Ax0O4fPYn2+th94CJfDbuPs 3wl4u5tKMYlIHHqSB1dKSjrrVK/jYFzrqIUAT8f/OjvqjTrqH2iH3kFRpWZkTsNc5CYyQMuEj6/13 Xyv1qVAulf5sk3wfXHTi6gQV83zct5cCkUVVefEKGJ6/B4xRIH8dApgUX9dVLLdHsKv+5AX+HoLje AhoVhZzg==; Message-ID: Subject: Re: [PATCH v6 10/51] x86/tdx: Force TSC frequency with CPUID-based info provided by the TDX-Module From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 15:53:57 +0100 In-Reply-To: <20260806233609.212337-11-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-t9ptKw29GmA8+P6aeY7O" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ebf023/1786200845-50EDEB50-A5B25CBE/0/0 X-purgate-type: clean X-purgate-size: 11230 --=-t9ptKw29GmA8+P6aeY7O Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > When running as a TDX guest, explicitly set the TSC frequency to a known > value, using CPUID-based information, instead of potentially relying on a > hypervisor-controlled PV routine. For TDX guests, CPUID.0x15 is always > emulated by the TDX-Module, i.e. the information from CPUID is more > trustworthy than the information provided by the hypervisor. > > To maintain backwards compatibility with TDX guest kernels that use nativ= e > calibration, and because it's the least awful option, retain > native_calibrate_tsc()'s stuffing of the local APIC bus period using the > core crystal frequency. While it's entirely possible for the hypervisor > to emulate the APIC timer at a different frequency than the core crystal > frequency, the commonly accepted interpretation of Intel's SDM is that AP= IC > timer runs at the core crystal frequency when that latter is enumerated v= ia > CPUID: > > The APIC timer frequency will be the processor's bus clock or core > crystal clock frequency (when TSC/core crystal clock ratio is enumerate= d > in CPUID leaf 0x15). > > If the hypervisor is malicious and deliberately runs the APIC timer at th= e > wrong frequency, nothing would stop the hypervisor from modifying the > frequency at any time, i.e. attempting to manually calibrate the frequenc= y > out of paranoia would be futile. > > Deliberately leave CPU frequency calibration as is, since the TDX-Module > doesn't provide any guarantees with respect to CPUID.0x16. > > Expose and use cpuid_get_tsc_info() instead of providing a wrapper to > get the TSC and core crystal frequency, as TDX is the only anticipated > user outside of the TSC code, i.e. adding a helper to dedup the math won'= t > actually dedup anything. Having TDX use "struct cpuid_tsc_info" also > avoids the temptation of declaring a local "tsc_khz" variable and thus > unintentionally creating a shadow of the global "tsc_khz". > > Cc: Kiryl Shutsemau (Meta) > Signed-off-by: Sean Christopherson I don't know if we should set X86_FEATURE_TSC_RELIABLE before bailing out in the case where cpuid_get_tsc_info() fails, or just not care about that because it Can Never Happen=E2=84=A2? Previously it was set unconditionally from tdx_early_init(). Whatever... Reviewed-by: David Woodhouse --=-t9ptKw29GmA8+P6aeY7O Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNDUzNTdaMC8GCSqGSIb3DQEJBDEiBCB128CVBJN8xuT3FiKKePSSmD1dGYDR PbTRvv3V0qPdhzCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAONQVsVqcQyHMNv3ndBzrZgpCILyQP+t1HaHjvmV8XwFE+1n+c6wZ 5kxata2TXbey92bUtsTg6WpP4/A56MFfNWaTRjFxxOS0ZeWWsryymaD1XDpdHdhWpOZPUfdq7VWm ctAXsM8mdlD2tMk/L7KYvgx1WsdEGiE+ZKtTlMmZjuxCkOGMh07ZbhY+dzm7VJk6ybiw+D8R57hu BLcjmDEhLbxIs/MWasr6lY9NXe4qyMmRcT4L9f+ppQ+t2QhcZ/MktdHhop+YXdl2K1oRzvUU7SHf Vpf7t3taxR2mrqscOxwmu4E2s5Qi9CQGJ7kvEuE+FqKfTjjcusg3jZ0VMItrxNR5lLoAx8MZ9PTD xUMNUJzhDE2Crh55kbSkkEkfxz1mILKWBNhK7+tQ+7mXIi/8fJ+qzUE0hW4kLV4A7iU1PS8pAF8p pjYPlVws/cqXhoj2iEaT8SAT5aICcXZ+LWq3lmZKSPhTvls4l5oKfsD2Sx3Jy5OtTshtwV8HRsU3 tXmsaZxeq2vYQVIvDGy6IoNvUSfK67W23VCWaVINNRgRok7Qd0paFBZz2OTwgU5fEm/LAUlQe+1s 3SOg6XMHVDD61w/MDzNmbysf9L6bH795bXTEalXqwhR4qd51LhACF09ku60FvSWPbgUdTE+f/rvE Exg5EaO7qp5P7n9DQ5PyO44AAAAAAAA= --=-t9ptKw29GmA8+P6aeY7O-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 14:55:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 14:55:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386695.1628384 (Exim 4.92) (envelope-from ) id 1wsiSX-0002qR-NL; Sat, 08 Aug 2026 14:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386695.1628384; Sat, 08 Aug 2026 14:55:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiSX-0002qJ-K5; Sat, 08 Aug 2026 14:55:37 +0000 Received: by outflank-mailman (input) for mailman id 1386695; Sat, 08 Aug 2026 14:55:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiSX-0002qB-2I for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 14:55:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiSW-003ngs-Bw for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 16:55:36 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a77430e-bab6-0a2a0a5309dd-0a2a450cd2ac-24 for ; Sat, 08 Aug 2026 16:55:35 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a774367-f479-0a2a450c0019-5a9b3222a388-3 for ; Sat, 08 Aug 2026 16:55:35 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiSN-00000006YVa-3vur; Sat, 08 Aug 2026 14:55:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=9ZmoEJU8Nj3R7GEBPZuKKQOrDJ9kwjJLRhMvX9eg2b0=; b=qJnOvhH/oom5NnirTM1L3sqRet zFy6+LaUk6eYcTvcX776vouIX3Nf3O+yd9Q4oxOXRrt3y7NfCMk4gArdnMLxdVZTpnP68AWbUF5DB zc7NOWZS42fketVNwBjHe6GRIGAIv/JxbK38FwAK9iu15FChMR+PBll/RDaQidTWi2LKz7z7iUD0e 3IrdyOVumQ6UC8zb0+WKukb+yb3wM+eY3DZboLvHuvSJfw9KWQo/swQCBB7uW35Rnvy2fDG0wcPOO v7DzUoGoCgbe3/quqnGwJ6G1W3fTY6gObp0ieJ81dufGHnoXcU4yhekVl3jsLTp2sfPosHVYctUvV xv8gXpuQ==; Message-ID: <91341b40020a6c12c380651f2658897d3e4c6345.camel@infradead.org> Subject: Re: [PATCH v6 11/51] x86/tsc: Add dedicated hypervisor hooks for getting known TSC/CPU frequencies From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, mhklinux@outlook.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 15:55:26 +0100 In-Reply-To: <20260806233609.212337-12-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-rqA7MqJn6IlGbHYL5W9W" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d25034/1786200935-034D7A5B-5809F31A/0/0 X-purgate-type: clean X-purgate-size: 9971 --=-rqA7MqJn6IlGbHYL5W9W Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Add dedicated hypervisor hooks for getting known TSC/CPU frequencies > instead of overriding seemingly generic platform hooks, and explicitly > prioritize hypervisor-provided frequencies over native methods, but do NO= T > clobber the frequency obtained from trusted firmware. While shuffling th= e > hooks around is arguably "six of one, half dozen of the other", scoping > them to x86_hyper_init makes their purpose more obvious, and allows for > explicitly defining the priority of sources (as is done here). > > As is already done when trusted firmware provides the TSC frequency, igno= re > tsc_early_khz if the exact TSC frequency was obtained from the hypervisor= , > as attempting to refine the TSC frequency when running in a VM is all but > guaranteed to cause problems sooner or later due to the calibration sourc= es > being emulated devices in the vast majority of setups. > > Cc: David Woodhouse > Reviewed-by: Michael Kelley > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-rqA7MqJn6IlGbHYL5W9W Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNDU1MjZaMC8GCSqGSIb3DQEJBDEiBCBXj2pOn7w99V9/APxOjyywOoy1tNze sBNaxAitVZEENTCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAkLLvuDi2xErhAXmhGRxhKl29cHidfsYNi+OvY8o/YUo20MCbwkOf Y0Wldj9/dOacpxTtEp218iwxL3Y/45pYGTaBXv+PjgVn+Epet+g8T7t78DhaX+FZ/13VpB30The7 f+v/V+mvS49kI/4EG7NDd3B1LSVgxH1eYRXvakdAP0o7R7lAz9eEln5j6lKi4s/33yK3iwRo+dmc Fsm9oGVP7Jyom1aZ6gkm0Tuf1ZFmDjoPdemkXQblVXahYM8JiR4PXUkC75ANioqfF3G6u/qpbaxc U/g8hhJMlcnjhZaBgxkZby2K0i094zvRrcZhbJaMtM2VWU6FODUTS0z0chxbpkFAT2eUaNRipZcM KsJYWe6SHfIXoa+TGeBd3gvBfEaPJFzFl0WNb0G8xeMjvVg0LqhVaLg2DVMPCSZbB7nqZf62+t1Y eHyS+QGunPqYXkWgYGrULorsiz0AhgiARJr7Z6DMc8YD/Ecy1LX2F0eSQ0v0AiDZ9kYYQIBFbpHZ LGPBPXjGFhisUoNW+RYzOsFuiZKtSpzb+zpEp2gYDR8nioFjd4zih3xmXLQ7/xNvfhcbyibGNbPC XVK4j6hKT53M+636FeKveRHYpFQon4cUH9qAbrOzdZg6AzV08g1Q7cOgD+WsYxNm5DQm4W4TTJJ8 mPEnWr/Iz/Fi0iFJQu669ckAAAAAAAA= --=-rqA7MqJn6IlGbHYL5W9W-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 14:57:35 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 14:57:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386703.1628392 (Exim 4.92) (envelope-from ) id 1wsiUQ-0003SD-1k; Sat, 08 Aug 2026 14:57:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386703.1628392; Sat, 08 Aug 2026 14:57:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiUP-0003S6-VS; Sat, 08 Aug 2026 14:57:33 +0000 Received: by outflank-mailman (input) for mailman id 1386703; Sat, 08 Aug 2026 14:57:32 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiUO-0003Rz-I8 for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 14:57:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiUN-009cCv-Jr for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 16:57:31 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7743ca-8faa-0a2a0a5109dd-0a2a4505d93a-14 for ; Sat, 08 Aug 2026 16:57:31 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7743db-4cb1-0a2a45050019-5a9b3222846e-3 for ; Sat, 08 Aug 2026 16:57:31 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiUH-00000006Yb7-1FD8; Sat, 08 Aug 2026 14:57:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=goIfeKepOMWSzakf5pw+sPdIm1bWS35DFpCXt8MSupo=; b=p96FcflViCat4ySTi/DsnOVH7Y OWUql4bbp1fOAfACeyXPzIVujSGn405GbbS4XQTkAqsF2Ee2T3pBBDM/RwsgjvCGdvcrF62P8k0Qv +j0ziw5KY27pi7xiKTjKBHqJGqJUTI7cHxBZwd1MEbOC+nCwFEHpdO8vxU01ELVLyu8OMc/Y8ttSG ujZwU5OWZiUa3FHl7UNQi+aMTAE82JTY8X0rEd6tzu7d0ZC1W9/fXWcXDZhB/kwgIqRJF5yrXMls/ TH8GVTZh9RgDpqvMF4ddigrlzTvF0XLyvNWVpLCLIGTBZFSJ02e6EbcP1NxXxgqxlylWlBkd2y9h0 4VFw87uA==; Message-ID: <890afcaebda8688d5b642e312da2c27a3731354a.camel@infradead.org> Subject: Re: [PATCH v6 12/51] x86/acrn: Register TSC/CPU frequency callbacks iff frequency is actually in CPUID From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 15:57:23 +0100 In-Reply-To: <20260806233609.212337-13-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-Y57aRO+CU11wowyiP33M" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-c201ff/1786201051-72AB72A1-5598AD23/0/0 X-purgate-type: clean X-purgate-size: 9273 --=-Y57aRO+CU11wowyiP33M Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Register ACRN's TSC/CPU frequency overrides if and only if the exact TSC > frequency is actually provided in CPUID. This will allow marking the TSC > as reliable as appropriate, and avoids relying on the caller to handle > "failure". > > For all intents and purposes, no functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-Y57aRO+CU11wowyiP33M Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNDU3MjNaMC8GCSqGSIb3DQEJBDEiBCBNe8sZhW1r/oYnm1j0YO2K+/rjRNSD 8xlcT1C2Jk9SWjCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAxo9YW8AOod7cWia03OVU4V4JE2q4NqDOHa+dlXSm6gdzeweMYKJT bgDzyK6WOJMYCUmmLylQWR2E7EAZE8WMaCblt5YcZL725mGJjcnTnirsJ6dGUR14Ml+2TcucWFoD tmk7T5bV+6r5DQRvRJCVqNb3enFVlBsBgFicBwUTCtoFsco8OTd7pK3z5INuUMPCfST6/u2rAE4i f083BhwEJx2DtefyoF4z55pXibZltA9HCcjNTj5DwuWgq16Tygmn/R1A3M6+OZof1WTBY4gM9big C5j3MeXrDgKw0M0umhybNRMbIHN5be/SwlZg5Cgk73f4Swz8Ww5Td6gc6kfvzhQNeVfDt2m5vyEf jJeKijtinMX5UibLbHr+CVTWX/dF5C1/Yo/ShXNoEyXNEbMO/TTduFAs7HUN0Xh8Ph8Ab/4Q5Voa zu31O1OapaIo1ab6s26WguagVWDoQlsKw3N3FFAhU6Czzt5/39ewzAvTaTZFUOOVNnToa01jrH2x QC7Bs3ALzWfOMVMqXk+5zTAStTjV0PzvU2FJBvdxDMO42f8MzADaC5PHVyIB9FvVKJ3niFe/iKq6 Pte0y22JM/UbGSu3Ut8EkrAMnY9mK8N02l20fZ7e4LWq6wiPUsjQC81/lfM0HNgYl6J25KULmMBA zS/JkQqcCXwG9s8K8lOlLcYAAAAAAAA= --=-Y57aRO+CU11wowyiP33M-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 15:01:10 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 15:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386716.1628401 (Exim 4.92) (envelope-from ) id 1wsiXm-0005Cf-Ic; Sat, 08 Aug 2026 15:01:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386716.1628401; Sat, 08 Aug 2026 15:01:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiXm-0005CY-Fz; Sat, 08 Aug 2026 15:01:02 +0000 Received: by outflank-mailman (input) for mailman id 1386716; Sat, 08 Aug 2026 15:01:01 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiXl-0005CS-BF for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 15:01:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiXk-0019mN-OU for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 17:01:00 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7744ac-e002-0a2a0a5209dd-0a2a4508c1ec-0 for ; Sat, 08 Aug 2026 17:01:00 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7744ab-f659-0a2a45080019-5a9b32229dec-3 for ; Sat, 08 Aug 2026 17:00:59 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiXc-00000006Yv6-3MY3; Sat, 08 Aug 2026 15:00:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=c4buHOPZ0bv4R4NaEGhdIQQVpZl513kZ0VUZz72Z6nQ=; b=idGrWCohNRmBgA/YGZOQqJxDsA k3wQhrj0VjDBMG8JodKxYbYtLSGI/kmklqklDXk+DXeCeV50NV43iFpkW8y2PSr9WvW7Jrhwwvgrz VxzS1EQVP0o/gk087C8CXi5i34Y+xLX0UBpSz4d1hvvTVXkAm1gC+jbWE+LMfyFcN8OR9dBEX6I+I ndK7de7kJSwGsyuVrYgo6LTi1uB4bIjFoE+Dl59NSdmrqbrSXXfmUX9F+ZcRQofgOWgS+mTBwRcMU ogVkhgo0HacPcds+kv+1mOrhrU2h5nsSVpwH0LzXeK/6rFtcu++iFfns+JQT27PeoCXa0fYqsSQPl +VWnLgog==; Message-ID: Subject: Re: [PATCH v6 14/51] x86/tsc: Consolidate forcing of X86_FEATURE_TSC_KNOWN_FREQ for PV code From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, mhklinux@outlook.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 16:00:51 +0100 In-Reply-To: <20260806233609.212337-15-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-8/mRcnFKKGOky2orgg6e" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-c1860d/1786201259-D5F4787B-156574D3/0/0 X-purgate-type: clean X-purgate-size: 9570 --=-8/mRcnFKKGOky2orgg6e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Now that all paravirt code that explicitly specifies the TSC frequency > also sets X86_FEATURE_TSC_KNOWN_FREQ, replace all of the one-off code > and simply set X86_FEATURE_TSC_KNOWN_FREQ if the TSC frequency is known. > > Do NOT force set TSC_KNOWN_FREQ if the "known" TSC frequency was provided > by the user. Per commit bd35c77e32e4 ("x86/tsc: Add tsc_early_khz comman= d > line parameter"), one of the goals of the param is to allow the refined > calibration work "to do meaningful error checking". > > No functional change intended. > > Reviewed-by: Michael Kelley > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-8/mRcnFKKGOky2orgg6e Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNTAwNTFaMC8GCSqGSIb3DQEJBDEiBCDTAZMeDB5NUudSa1SgH3uYEQRYZrGc iAMarKDxBeHsjDCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAgFQM/AN8fHVMioNBRlOChv5+9L+91ZtiHLMzRfe74UjeZTaBnrEW l8MjDT9KP3yloTgeGY1Kq+GMQdc9yWNZ2IEi7SJfJ3GXwNFG8ci6jRxjX4/GvzHZPQoY5Ylzsvzi lNjngUSINtSTrMWk8vfWl9Da3hNH+Mcr7XB1ycn7ci7jOQamSQ/5vyazW7P/AZLHdcXmMsTt0p4+ HKMteIKaavmItYrj4GSJo8f104PNWrTTIgmEzXfWAscqY3XKIfKnHTa0amZX5MkT04frZ8ePCltp 3CofcDopJzT5e5VGh3ALgOjyceW13n7naBVUxbj5JlJ9uWm9FBw5D++xasvBlx//MypdExRZqPAw mi62dTv6A1ukCivEwjQUMWvUqlqbvcFRcl0kHf9khvLzSD/gsBEBCqTP6eszoZWG/YOKYC9ap1Ih I+eHmnksk5EfzOMxKU9679sGvS+daA4LtNUqLAsF5C0Hj3LFLgTkM+g8LqOMlU22amqRDukl02Ls NyPIDP3ip3epzIixnD5/bxxTE2FlYHglsv+zE/Wr84HMccfvPM7mSru68wSA/bSf7xWQuz3xQI3N rOTTpwKkynO83J6DoX2cJsCugLO8seIXuID6KRQO1dLGPKRQPp0+ibMi3dips3kXm3HAn4gVzUNZ o+BkaAi2Rel3KHiQvNzOB7oAAAAAAAA= --=-8/mRcnFKKGOky2orgg6e-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 15:01:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 15:01:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386723.1628411 (Exim 4.92) (envelope-from ) id 1wsiYc-0005gQ-Qt; Sat, 08 Aug 2026 15:01:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386723.1628411; Sat, 08 Aug 2026 15:01:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiYc-0005gJ-O9; Sat, 08 Aug 2026 15:01:54 +0000 Received: by outflank-mailman (input) for mailman id 1386723; Sat, 08 Aug 2026 15:01:53 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiYb-0005g3-9h for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 15:01:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiYa-0019rA-Mn for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 17:01:52 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7744c0-e002-0a2a0a5209dd-0a2a4501b2d8-24 for ; Sat, 08 Aug 2026 17:01:52 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7744df-5984-0a2a45010019-5a9b3222d77a-3 for ; Sat, 08 Aug 2026 17:01:52 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiYV-00000006YxH-0R1J; Sat, 08 Aug 2026 15:01:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=cHemq+R8kBm2N1D7zG41iiZY974/e28EH+HY3NEkjlY=; b=RQl6FO1TyeVj01qXv3h/XfhhJx dAHGFabC35mI/v7f6ZF5yH+HKPBOeuP/bWSBVFV5as4PSm1Bv8io5zjFliFY0HcIylgKGiHaC748n zu9G33Xwug60AG3WOjt2XjSME+LG4diie634BCniVnH1TVMNv2fbzCzsFf8oNNZDe6AwxB6pBZ/1R p24TokgsZ2p0tkHnytpq5r6cCg+Q/byy6DfZuj8jh3RxuE5Q3IIJz5ucstMPbT1hyxOfCnCMH+1W6 dLkKOEN7clgBbyoNP5OHrVenrk6iCo/mr+l9IkUlE1t5n2u1m6JWn9JvaL1ZfHw/7VSutADt9Rpqn n2jjdCVQ==; Message-ID: <8cdb54e0c25494e9574559d858a81916cc461863.camel@infradead.org> Subject: Re: [PATCH v6 15/51] x86/tsc: Kill off x86_platform_ops.calibrate_{cpu,tsc}() hooks From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 16:01:45 +0100 In-Reply-To: <20260806233609.212337-16-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-pJV6LuA8JirWt+CeIJA2" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d62444/1786201312-1E27A757-3F0C0830/0/0 X-purgate-type: clean X-purgate-size: 9423 --=-pJV6LuA8JirWt+CeIJA2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Now that getting the CPU and/or TSC frequencies from the hypervisor uses > dedicated hooks, drop x86_platform_ops.calibrate_{cpu,tsc}() and instead > directly invoke the correct helper at each phase of (re)calibration. In > addition to eliminating unnecessary code, this makes it a bit more obviou= s > when the "late" path invokes pit_hpet_ptimer_calibrate_cpu() instead of > x86_platform_ops.calibrate_cpu(). > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-pJV6LuA8JirWt+CeIJA2 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNTAxNDVaMC8GCSqGSIb3DQEJBDEiBCD6U2t+qvpPAReeHMywFnP+Wc79R2Uj KxqBjf4L3+z40DCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAAy3K89cKEOtHZsOjH0NMIQUudmikHtnnYwiYb4UJ2XjXJt1UOcWy bt9n7ZC4GFpOjb8SbQ8pcL2H7+QL2SvmrOnzxk/+k4Q1gf1xTAk/veIK31v1K74zzsM7vxBue7lg 4K01P7Dqei6rlTkS+tX4E/C95L9bC2SGgk8E72GWfeAKvywnIc8MtJXhIk7l958gY/PFPIzcUOj8 TMWGz2CKMdvMGlCUD4d0sJAjxZKHfHunykJDVzJsyjB/NH5oTXndyvmqZt/S9Cuk1Pxl3PR0ipGX nAC1ieRnd9rFGgMkmSuNo+S76vaNTNsYXx5ubha1gSfBOLAIbNFc3wrksW0oriE/U7cJeec0ePXr 9BlD26Q56z/grlOSwUCP3hMmGUiymPZbj2rI626kexeCleFFszCQnJQJ57YQujNY4HGEInWpwGGc Bk1C8zMunpNRKBshfQKM5hJ78yg5PwiMQED8jwqfN0YZ+Xi20GcjUSeS/vnhAa4ICp+n+B35P/IS RQzo3I47LKoHzGhLSqtrLaehP5pzoxsVlz/Gvbxj0lWZ1WKcVu9ZI/VhbQacslUKk0x/Pkti0NkU tyJKN+pgCpBZyet6g+e7ERgeqAJzJ6/BSve5aa4+wF/K4rEEJRt+7/bcG4bUdCpqTMfOJtrzTnm6 SnNxS0tHcFCE4mXozVOfHnMAAAAAAAA= --=-pJV6LuA8JirWt+CeIJA2-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 15:02:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 15:02:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386732.1628420 (Exim 4.92) (envelope-from ) id 1wsiZb-0006B6-37; Sat, 08 Aug 2026 15:02:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386732.1628420; Sat, 08 Aug 2026 15:02:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsiZb-0006Az-0D; Sat, 08 Aug 2026 15:02:55 +0000 Received: by outflank-mailman (input) for mailman id 1386732; Sat, 08 Aug 2026 15:02:53 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wsiZZ-0006Ap-CG for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 15:02:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsiZY-00CiCT-An for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 17:02:52 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7744fd-bab6-0a2a0a5309dd-0a2a4505913a-22 for ; Sat, 08 Aug 2026 17:02:51 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a774467-4cb1-0a2a45050019-5a9b3222b638-3 for ; Sat, 08 Aug 2026 16:59:51 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiWX-00000006YkS-3zRH; Sat, 08 Aug 2026 14:59:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=cjqV/irGmZd8w6lcxaSK+6WNSve4cl+1LpivEBexyMQ=; b=hJpYeLKwSuZ8Qt4awuG8YSOdQo xVSJPwo++/8O48Hidkh6qkd4vfwndvt5tv3FsleZzl/6+hsZ9miZQNetemQqNScue7dAL0AePNPk2 G5b1VSuOTXNHIdHIB9DCctSB5NyYM97seEvg1RZ0Z2DTElK97RQXOhYfeIxxa+oAxBSk2zHLkSq56 1iN0lU8zLe/+6oKFdHzMMO58Of+Nfcy2Ek466haCQ97dxvgd6ch6EwMBfCi5JIUlVt88T1follGIr si/DBu0pJpIh10OdJlEfXZzm9YBO9v7aQpUwIm0IEA6B7lY05B3UmAL1QhYnkvSncyNu2BFhf5AjY JL50e9mw==; Message-ID: Subject: Re: [PATCH v6 13/51] x86/acrn: Mark TSC frequency as known when using ACRN for calibration From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 15:59:44 +0100 In-Reply-To: <20260806233609.212337-14-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-swfj4Wc+2w/NxQrUPIhf" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-c201ff/1786201191-F44A42A1-38606B23/13/0 X-purgate-type: clean.bounce X-purgate-size: 9335 --=-swfj4Wc+2w/NxQrUPIhf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Mark the TSC frequency as known when using ACRN's PV CPUID information. > Per commit 81a71f51b89e ("x86/acrn: Set up timekeeping") and common sense= , > the TSC freq is explicitly provided by the hypervisor. > > Signed-off-by: Sean Christopherson Huh... does this literally get reverted completely in the very *next* patch in the series? Kind of weird, but I guess in some ways it makes sense... Reviewed-by: David Woodhouse --=-swfj4Wc+2w/NxQrUPIhf Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNDU5NDRaMC8GCSqGSIb3DQEJBDEiBCCLHDsVEr47QLniCvl1BHh7jULcWyP1 JFbCuD+qwvoPNzCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAR8KWcORVTZQasIgxPzemsBTyXMobtaBuoDyuKdNegOlt6B+9r/34 lQPmQzpYXE2c+M0nMbA1C0t8XTSPGRQ6pbu3enjsm6Etlto/EFiyfkZDZok4WFauDbalheV1+gRj p8HmX8Nfp5sv5Ou7dwCk7Lh8mJcuH+4z4jyIKyNKJOVMuQVG26Pc0r6eoQP1c49xGbSzuJ4ntzl8 ZSwSUQKulQtOhOYo7qtctV2sdsb9c4cuhUGZLtIJy2nO7qflZKDQ7+9HEZR5t8KesfGpykHuHweU kYqIbShxhI14dCTVeVey+ijIatUBBghH0irBc50ML5mxiH0z0T4tsFIITE5Pocpd7oNa7KmKEgVs RjDfd4sggGjWXRM33apHgvLK4Y1PjlhqnkgaIas3Q4GrCyOiuMsI8yAoRIHmyS3jN3d4UqULiYLh 6RRnFiazWuzuEMwjo9qdJabZ5A/4FCcFFsborS0n8Tqlo6/54ohHwSMmDIp4ZctOH+SofAokgqZM Usz5v+HDUnM5pnF89Q3YiWIcAj45mVI8fhxqsfcsv0VLQ82ljqkOa0X7nh1CIOWcsoHtI9VlRbZt pp45qlJKWW2wO706FStcVF+doACf1LiRgmI8KuOZdZhXDV1lFfdkBq+8ENFdyUTh87arS/jLshbP L9KEvoOBTrQ3mDfQa9VMYCoAAAAAAAA= --=-swfj4Wc+2w/NxQrUPIhf-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 15:06:18 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 15:06:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386743.1628430 (Exim 4.92) (envelope-from ) id 1wsico-0006zW-LT; Sat, 08 Aug 2026 15:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386743.1628430; Sat, 08 Aug 2026 15:06:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsico-0006zP-Gc; Sat, 08 Aug 2026 15:06:14 +0000 Received: by outflank-mailman (input) for mailman id 1386743; Sat, 08 Aug 2026 15:06:13 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wsicn-0006zJ-9o for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 15:06:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsicm-001ALT-Mx for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 17:06:12 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a774581-bab6-0a2a0a5309dd-0a2a450ac5a4-40 for ; Sat, 08 Aug 2026 17:06:12 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a77452f-f2d2-0a2a450a0019-5a9b3222c3aa-3 for ; Sat, 08 Aug 2026 17:03:12 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsiZm-00000006Z4O-0oAc; Sat, 08 Aug 2026 15:03:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=Wa7Hzq2JSx29IaNuU/muzEjzSoG8OuGbp+agE00B49Q=; b=rmnS9mZpeKjdGdBlUegOL51BkB pKn5oJgOcQodQGcg9eGzYS2wFJKM/KZYTLkRAEyutqxfbi+pYDyPRfMgJhLYKI+EuWlRgRoRyYfNc gB9wfCiu9XDZZY5sijChUtaNjzq/Hizp3Xi21sQmf8gP5yzKSs1ZrH+tu0MvunYWQFsBl61TOp7wa 1NMeK9CQnYQPVKHz+rLmD0X0f42m9xhYRZt6G1ylOv/6rQBcCOCAiCVJxtjJdOOJjA3rlyb8iempC QZ+0RuqumEp7/7WkG25rcVsZk2rQU1EaGpdE73GctG0VJeeEsQLb+QQ3YykGJVWsaRKaTqcKcQBfY 6x4NhTqA==; Message-ID: Subject: Re: [PATCH v6 17/51] x86/tsc: Fold native_calibrate_cpu() into recalibrate_cpu_khz() From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 16:03:04 +0100 In-Reply-To: <20260806233609.212337-18-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-3h8ypXMqBwC7mZwWnyZO" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-4011c0/1786201392-591C5CFC-C4802DC2/13/0 X-purgate-type: clean.bounce X-purgate-size: 9297 --=-3h8ypXMqBwC7mZwWnyZO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > Fold the guts of native_calibrate_cpu() into its sole remaining caller, > recalibrate_cpu_khz() to eliminate the extra SMP=3Dn #ifdef, and so that = it's > more obvious that directly invoking the early vs. late calibration routin= es > in determine_cpu_tsc_frequencies() is intentional. > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-3h8ypXMqBwC7mZwWnyZO Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNTAzMDRaMC8GCSqGSIb3DQEJBDEiBCDwb5m5oE9xtGsjsdRmZNgxK62hdyL4 WC3aSn2DOLO7iDCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIACx2XiWqoOsyRHJvHYpRHx2KK8aqyfD7+x4R0BLQ0PVFMU3qilduU RfgooqwW+L0+Gv6dMwsC1wlZipXcALB+wp+0tK72qgMitY4A/SYQa02Ycy80m/CldZhFh4ntn6K3 EzQXz2sg95KiE+0JgNYZJXY+92ur0y8i/3qRPcZWZW7fwiASskS3RX5+o9Pz0u8HeaA8MMHe647A wpw1qBKUtlBrUidL7AMOG9kfbBC3g2bOrKdGgmPT59OKny0rnTYjXrSEmlvOBz7YDidbEGSwOTHT EUfFzCME58zSPxiGE86zuIfIrs+vOnKqjwbQWZO65IFJYqiAGiqoUWkTOxdS9l8rlfah72m+Y/Lu O+XDzCujaGwZ4XpTf5dhM1sojJNDx+syG1ColZz6SkmFroS8UPSGna7qMMtNWyXxU9okHTVcVQgL uLdFMNY2+rn9ImFgfsG8eC4c2wDRuBDmvVbSXBsji4kmKfDlnpw43G6dCpuLYv8rbLz5Cct6PcAB S005/n00xCdXREcIxwzgkWKhUBw7dWhlvbGRq6B0qxbRZtlqBAuZ+5H2lzppx0tVgUEUw41qKEXy tBQMmFNP7HsDhb7B9l8kn96VPVC+xTzU+c2hA9icEM3N/G5nCuTPcLP/kB2rxA31Zt30G3ii9rAJ eqD95h+YeobJ1DGZJK81JbAAAAAAAAA= --=-3h8ypXMqBwC7mZwWnyZO-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 15:06:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 15:06:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386752.1628438 (Exim 4.92) (envelope-from ) id 1wsidG-0007R9-RW; Sat, 08 Aug 2026 15:06:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386752.1628438; Sat, 08 Aug 2026 15:06:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsidG-0007R2-O8; Sat, 08 Aug 2026 15:06:42 +0000 Received: by outflank-mailman (input) for mailman id 1386752; Sat, 08 Aug 2026 15:06:42 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsidG-0007Qs-4W for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 15:06:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsidF-003ojO-Hl for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 17:06:41 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7745f0-e002-0a2a0a5209dd-0a2a4509ab24-6 for ; Sat, 08 Aug 2026 17:06:40 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7745c4-be1a-0a2a45090019-5a9b3222ed76-3 for ; Sat, 08 Aug 2026 17:05:40 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsicA-00000006ZIm-2rcE; Sat, 08 Aug 2026 15:05:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=k+OamkYrv2Q/1Mc6CsMtTvPptfqZvc3HFc+EwxszCfc=; b=hlYPBpotHaB95aCGdAYb8rWrKG KNI9+ZVShJ4Ay6zxwsOUpNJWjPvdGkEG9NwAn5zoMv/eGYSvR8AsXsfffEJnoQQKlLgd8Qnqa+OuU mNBgEL6qPs8Sy5mGvzbmNMGWGa5UTCuk+md58+H01r5jM5AK1pWT0DaOtuNRDOHr73p7f1P0IZ0M+ o7WyiBkfKf5TLyq50c7Vf+G/sgGEej2IoI5tPmWAxAiqI0RBo5N6/54mpQLYJZRAVwIPTw6oNahu9 5zcqtF1+uci6tRLFYlZNAc25hy+I4btFu/um7mbNPifcJ2HzQC9bkx4VrQuxV6KOmh0d9aHxfdQv7 GcrajjZA==; Message-ID: <91c9ca8c1ab7f3facc12fd7a033d79254d4a181d.camel@infradead.org> Subject: Re: [PATCH v6 19/51] x86/kvmclock: Drop dead check on TSC being unstable during kvmclock_init() From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 16:05:33 +0100 In-Reply-To: <20260806233609.212337-20-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-jL4BIGsiNKeXF0OKBwg7" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-bad1c0/1786201540-FD86F034-C11D5310/0/0 X-purgate-type: clean X-purgate-size: 10053 --=-jL4BIGsiNKeXF0OKBwg7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > As pointed out by Sashiko[*], kvmclock_init() runs before __setup() and > thus before notsc_setup() or tsc_setup() can mark the TSC unstable. > kvmclock_init() also runs well before tsc_init(), and even before > tsc_early_init(). Simply delete the check, as it's been dead code since > it was introduced. > > Note, odds are good the check_tsc_unstable() call was copied from Xen's > xen_time_init()+xen_tsc_safe_clocksource() logic (as so much of KVM's PV > code was). However, xen_time_init() runs via x86_init.timers.timer_init(= ), > which is invoke from x86_late_time_init(), and thus after params have bee= n > parsed. > > Alternatively, kvmclock could register itself later on, or tsc_setup() > could be parsed as an early param. Given that there's zero evidence ther= e > was any meaningful intent or need to actually check for an unstable TSC, > go with the simplest option. > > Fixes: 7539b174aef4 ("x86: kvmguest: use TSC clocksource if invariant TSC= is exposed") > Link: https://lore.kernel.org/all/20260529181213.0B27A1F00893@smtp.kernel= .org [*] > Signed-off-by: Sean Christopherson Reviewed-by: David Woodhouse --=-jL4BIGsiNKeXF0OKBwg7 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNTA1MzNaMC8GCSqGSIb3DQEJBDEiBCBPg/28/nMAA7kD8KB7YWidZV5ltXud WC5ifsuEkfezqjCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIA0VHY3rUJsG/wBPTSPREp9yqeyqejmyR/heT+mqB8BWh225fhd04z ioB0PkU7vEaPfZcTY/8jq/iJWAkLqQrFJrkPoZOdQ0ahcn5xe8H+dPFK8qaZ93V2rKJ1wIl9/Uxi bsJs3B2GFpvGnsppMORG5oYNiqz1VZcT6o40tKq5Z5UyehSaMmb5ZBRdq4EMo7dgF2WpAlLllQsm aM5GYWUhFjUMD0MGY5HWWLwL08otRfdVO+QrMGgxV6Kq3I4VknD5cVHj9AWbWFWoQMfurpoL53Ua ggqemoRyZCctjEMwcGa0mldjBFzt7O44GEqcrQj/sulmDwZT4r7vsB2aR+RdgeMqODtpUSFrfCKN y1FGIIY4ya0vyUZ7wnNj9Om5iTKEa/mCTvWUEzA/blotqYzgXQTEPekqB7y/fDgzvFW/Y3AnU+v5 srizsBxsxt9SBKLre1D3DFheyAM0hqwMONtqf+udkfLTYx46gveIE9diCSUlNWXMb8AQb8e/4OU1 81mzeXpMe4DHVsd0veZZ+/DQNa6gnh7qnDzvWln7ZE4OPUDxIt6/ZPWFoUUDVHwdAl0fQAgM5E3Y v+BY9BVoViYVBRC69H0YKScpNOOF00/QgKLRpGafit9TWGdrVcJ5YS9V3YXkiahKAAyi4aNV4Eqb ArTRJFANS1EAwPtGmF7Q3zUAAAAAAAA= --=-jL4BIGsiNKeXF0OKBwg7-- From xen-devel-bounces@lists.xenproject.org Sat Aug 08 15:10:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 08 Aug 2026 15:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386759.1628447 (Exim 4.92) (envelope-from ) id 1wsigY-0000dO-BE; Sat, 08 Aug 2026 15:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386759.1628447; Sat, 08 Aug 2026 15:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsigY-0000dG-62; Sat, 08 Aug 2026 15:10:06 +0000 Received: by outflank-mailman (input) for mailman id 1386759; Sat, 08 Aug 2026 15:10:05 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wsigW-0000Md-Vs for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 15:10:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsigW-00Cip4-8D for xen-devel@lists.xenproject.org; Sat, 08 Aug 2026 17:10:04 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a774658-8faa-0a2a0a5109dd-0a2a45038e70-18 for ; Sat, 08 Aug 2026 17:10:03 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a774617-fae8-0a2a45030019-5a9b3222aae4-3 for ; Sat, 08 Aug 2026 17:07:03 +0200 Received: from [54.239.6.187] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsidV-00000006ZMH-1xgd; Sat, 08 Aug 2026 15:06:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:References; bh=5/jyAha6D+U5zzU3W+cCpJ3j4Z4I6ySL2lxtV4bdMdQ=; b=YoP6gRksn/p59tVjUCAEqmph19 weP9rQo8AlW5WV2KQS0n5f4YHgiz2Pl+8aPdOGfzFhagy5y5Ssii1oWx+2ScxbgznxW9qpWhhA/0A ajwu5drZGj+3XNpCbCT46fXxUbrOlkD2uJ83sZVbE1SzC7/Di1WJW6k7VapxZ+2HdMQAaQlznVIEV +UQAWE1PdzjUoASLyv+2+mTRbnshLC2mqyc36EQJN0F4qjxxBpnPX2O1viAXFperEWI4HRTjeTjR6 xIeK1PAAwGivwf9G5AboB23MahXCwnXhFTAhLz7GC1wb64934IM9q5kZI67h4UKuWxz1s50LqEWAp oaelbJ3g==; Message-ID: <908a4fd0ec4498c907decfd105e1662fb4ce19eb.camel@infradead.org> Subject: Re: [PATCH v6 24/51] x86/kvm: Get CPU base frequency from CPUID when it's available From: David Woodhouse To: seanjc@google.com Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Sat, 08 Aug 2026 16:06:56 +0100 In-Reply-To: <20260806233609.212337-25-seanjc@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-5qVG4UC9E8Q5nQrvV8Pq" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-33051d/1786201623-6E2D04E9-01568F36/13/0 X-purgate-type: clean.bounce X-purgate-size: 9427 --=-5qVG4UC9E8Q5nQrvV8Pq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > If CPUID.0x16 is present and valid, use the CPU frequency provided by > CPUID instead of assuming that the virtual CPU runs at the same > frequency as TSC and/or kvmclock. Back before constant TSCs were a > thing, treating the TSC and CPU frequencies as one and the same was > somewhat reasonable, but now it's nonsensical, especially if the > hypervisor explicitly enumerates the CPU frequency. > > Signed-off-by: Sean Christopherson I still don't think I care about Sashiko's complaint. Reviewed-by: David Woodhouse --=-5qVG4UC9E8Q5nQrvV8Pq Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MDgxNTA2NTZaMC8GCSqGSIb3DQEJBDEiBCAkPGP3r5uT4tS4OGDg5LaRCyG2yz/P /Lwudtzg4ZoebTCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAuRtAu48d3cDEH8Yyruawqxjo+2bBjXqiN17kaxj+u6IcLAW0Nrdo nzxRSU7g63188lVFEYlyVH1mR8e/jnhuLNbISNodetQLsVn48QsKDnvjTf03Qg8EfWMW2Q9XPflg ujjMSLOjY+oy5TCeXl1MiYwiYhOnWAMOikQybdXiN4yKyu8d7Gkydo8xr8ru8/a0TF2KKhfu3I1d 2xkI268NxH6+Cv9y5+bGCHzpe9uLgPsEbl59gRqxfxGFniNgDb1s9nmrA0sHNkZ8USM/MDh/KsrM qWJWvxLIurJ+Xn7Y9irqlMbA+JP7v6yMYDH2QAHMvxVpw4iaIo0L7UCAFb37/HI6YK7Trdk1GJgF HAshq0ZDzPYkkNFl3HBbQldIf4Jy3Eu8QiizlbiiDOvp4HqKCgS0bnBtcjHtx86Ord4r/mzm04qY 8HDk7icEUoMyxTMJlntkJCEtLvBfQ0SkEACFQmxcXDqaI/EqUzt4YuNYdo7Tp2GAeCyYIDdDMI4H ELDUg1Q+jdabA45cKulihQLMEC/5aOkrJGZaPeSwx1uueapFNBUUHdSwIMeXuUdrjVm9IcLgum3c YfU7Cd9T4E0dqkggIiLcvkwBSeKK4Ev3lDN6cNSSNzRRQbWp8aMqd6eIh5r9zVWMgsJwnB0UEjBs snTppZI8KQqD0ALD+ClLQUYAAAAAAAA= --=-5qVG4UC9E8Q5nQrvV8Pq-- From xen-devel-bounces@lists.xenproject.org Sun Aug 09 01:04:33 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2026 01:04:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1386894.1628456 (Exim 4.92) (envelope-from ) id 1wsrxU-0005uA-Ii; Sun, 09 Aug 2026 01:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1386894.1628456; Sun, 09 Aug 2026 01:04:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsrxU-0005u2-Ds; Sun, 09 Aug 2026 01:04:12 +0000 Received: by outflank-mailman (input) for mailman id 1386894; Sun, 09 Aug 2026 01:04:12 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wsrxT-0005tw-VG for xen-devel@lists.xenproject.org; Sun, 09 Aug 2026 01:04:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wsrxS-00DY1u-Mm for xen-devel@lists.xenproject.org; Sun, 09 Aug 2026 03:04:10 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a77d1f4-2eae-0a2a0a5409dd-0a2a4501d6f6-16 for ; Sun, 09 Aug 2026 03:04:10 +0200 Received: from [209.85.128.182] (helo=mail-yw1-f182.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a77d208-5984-0a2a45010019-d15580b6a9da-3 for ; Sun, 09 Aug 2026 03:04:09 +0200 Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-81e6f2ee60bso46448447b3.1 for ; Sat, 08 Aug 2026 18:04:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version" ARC-Seal: i=1; a=rsa-sha256; t=1786237448; cv=none; d=google.com; s=arc-20260327; b=U9DIo9+dqt2Bo0uacPSOf4OmnTbwhmIzG+r3MXzkhj1U/jv8fq9S59LbA2tSz/Nr7x yc00w1C6N7mpjUXJke0V6VcCpLa0Dl33FwbyxvGp2mbfCU6G5i9pWQnX2pC5eWLpcwVB wc+5h6OVFZWr3QS7oxgIXbtdF+b1BytR35MCxY8ez9NYQksGO7dntuHmNhtrLxZCHXgA XP46mldXpjn6dCetfk2wkcYZXS0egeKx3uM5oY4KYbJObNKmR/q+gKFVN9MEzCTYgRb4 u6oQWxhpoo8blkkvz7Etg/oPJVGgTFUTO0cHaDXrT8gQLI4CMiC1k6Phrd2dg/EhyAr6 40rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=/ooYtvOl/yrpSWjC6UMdC3vC8WtM8ahkSkG9Lt94FP0=; fh=A7KicbXY4441il0jhjM7233yohb6a4hGn+JPZkGjASc=; b=HCK0nIn5dJIsqxCNBoaCl+Tbypf+sjRDvFCSDbPxPu5ykw+h/ZcoqtVbBFsgXejD4c CPCpYMPnthSOt1hnNs6eZJgW3FA+qkkgs0pLefGNa82nvKSBaD+C1v+gOjS1yk45ZUzR 5PaTI5PRx+B6pjX9rOnJXYfgxmuLyHXqVmg5CZG9wt2Ty+3Mr+KA3CGOEVy8Fl4T9WE2 oA+OxqobnJf5R2P+dFKRGTFzKZAn7x2dwb1cc0GIxFvyXqNOFeYQHe1ax7jp3cXse2sX sigGL1V6hr4VOybs9X8oVIgOkfGUohHqDaMwXTsOWPo1FCvrsMR2PXQbNWn/LbpwDIZ3 Nz2A==; darn=lists.xenproject.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786237448; x=1786842248; darn=lists.xenproject.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/ooYtvOl/yrpSWjC6UMdC3vC8WtM8ahkSkG9Lt94FP0=; b=JeUTH5XoBZ/8ZEH8/whm25A9Cze3n3Fqy0k7Z+RmtnMrkWUHUSdrIbnPfV3KTftY7K xVAPplCVzLln0l3RXqeTCUWoeq4MsBOB/VMZZlbTdjTGY+L0CpNdJhmP/Sdd4nuny+Mo BQ+bskDzHm0AfaVYyccg/9prXeRohhF0/a/SvZegFH584mijtaAN3UVFSIt6c7TRaI7t +ykxN1fxkB2KKeqVDkJ4BoQhSSy0PpKH+CxlJPo6+6isW2J/QB4NFDtosFSd/gwDy3bi udnFD6FzdptL+BDec750YXG3HQxk0FTF3p2vBzQ3E1XnoL/E0R+OQ9tPvVxjTKmoqXVC Z2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786237448; x=1786842248; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=/ooYtvOl/yrpSWjC6UMdC3vC8WtM8ahkSkG9Lt94FP0=; b=Tw0sDXPXqmE74RqGS3jaNS/MxuCNq96ZXQ6m3eKlisUMVCgpSIbJXYZb2pCgdYjaKJ o2G4A481ncBSCT0CZ89P65E1GOy7PdzK68m+6bwI2mslvD7GO9oiUfkEejk234QAKBK4 vsEzoAm8LJlZz1Tf586oeNz7wAe2XPg8jCA86olwKSGUIdk8R+iX/4o3SkrSkLq1l2F9 eRozKbrDPjctouAmg7Mj0nGtRqheaBB4RTjdwzHIhOamcnWhFnKU8nh20ZEkImh36O4N x//bkaPUecI7LlIwsoUgz5K03yC2p4on1o7QWhWPiIGhsGNKkjkh6Hz89evq4oEGYHD3 LgoQ== X-Gm-Message-State: AOJu0Yzmrtvks2fmnCChHfSuYu2lSCgUruxVt9uhtBHqdCSihKNQzJ6N BgKtLNt9b62+zW7tt1adW3F/g3wnPEBU+YmUdALSMqe1VVvtmvalhjG7qQmNkr1PW/PFUWlniTK F7usyGLpI5WiekhpTzjLbgX8GhMd86CQ= X-Gm-Gg: AR+sD13FmIxRxODsp5dFvVLlmN+1kFlAEnsuqzrfjNej/zDgAbKzPwH8h7pjJeaheW+ yOrRWKCv2BEG18DD8iDuoY1sXBf0t4IPo5+TYJ5InmwTEKAVFrmJNO4TUGyBDRGt5pym1BKkANu xWAwvuFJD1D4tYzDYBs0ApwEg0/5qC6PZqpEcgEuvGZ02fIBLORft2aTCG/atrayGJeyuC/y5QU fS/F5yBzm1wQZk21QSd1H3/SyN+dOpAOMJA2jrakW+injrn3NYvz+dUecweHRBzw7CbPW4J7QKX hUYR4sIZXmos2h7SjxwesZzrIaOc5nn45upXmYRpys+nMoCN4vmBc/0Bu0Lp6redA5rrFZsRuth s X-Received: by 2002:a05:690c:d84:b0:826:9d78:a0cf with SMTP id 00721157ae682-8269d78a480mr35873217b3.9.1786237448260; Sat, 08 Aug 2026 18:04:08 -0700 (PDT) MIME-Version: 1.0 References: <1786138121.8631fc262581453bbf619ec5b2062170.19fde20d3e4000e099@vates.tech> In-Reply-To: <1786138121.8631fc262581453bbf619ec5b2062170.19fde20d3e4000e099@vates.tech> From: Frediano Ziglio Date: Sun, 9 Aug 2026 02:03:53 +0100 X-Gm-Features: AUfX_mx9bSVYxMwwHMrbKF5yAn2YZdvWOCF1zck5pvGNc3a3_Tsf6-V73c6L2Ok Message-ID: Subject: Re: [PATCH] public/xen.h: Update comment on mmu_update sub-command size and PTE alignment To: Teddy Astie Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Kevin Lampis Content-Type: text/plain; charset="UTF-8" X-purgate-ID: tlsNG-d62444/1786237449-BE867757-15D9DBB8/0/0 X-purgate-type: clean X-purgate-size: 4229 On Fri, 7 Aug 2026 at 22:29, Teddy Astie wrote: > > HYPERVISOR_mmu_update passes a set of request, where each request has a pointer > to the PTE along with a sub-command. > > The PTE alignment padding is used to transport the sub-command while the rest > is used as a address to a PTE entry. The current documentation state that the "an address" > 2 first bits are used for sub-command, hence the other ones for PTE which > imply here a 4-bytes alignment on PTEs. > > On PV64 and PV32-PAE guests, all pagetable PTEs are 8-bytes aligned, hence > off-by-4 PTEs addresses are always incorrect. Non-PAE PV32 guests used > "legacy pagetables" which had 4-byte aligned PTEs. However, support had > been completely removed since Xen 4.0, and were only available when Xen was "was only available" > built in 32-bits non-PAE mode [1]. > > Current Xen logic behave as if 3 bits are used as sub-command, thus all "behaves" > off-by-4 PTEs are actually rejected as being unknown sub-commands. > > Adjust the documentation to match the current logic implemented in Xen, > also expanding the documented sub-command parameter to 3 bits. > > [1] 84d54d5d8b31 ("i386: Remove non-PAE hypervisor build target.") > > Signed-off-by: Teddy Astie > --- > This happens to be a complete rewording of [2]. I'm not sure what to do exactly > regarding the signed-off. > You should use them both. > CC: Kevin Lampis > This now expanded sub-command field can be used for your "unmap_page_range optimisation" > series to avoid having to introduce a new dedicated hypercall. > > [2] https://lore.kernel.org/xen-devel/20260528075539.10209-3-frediano.ziglio@cloud.com/ > > xen/include/public/xen.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h > index 2149b8dd38..b4fef2c5ba 100644 > --- a/xen/include/public/xen.h > +++ b/xen/include/public/xen.h > @@ -218,16 +218,16 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); > * x == 0 => PFD == DOMID_SELF > * x != 0 => PFD == x - 1 > * > - * Sub-commands: ptr[1:0] specifies the appropriate MMU_* command. > + * Sub-commands: ptr[2:0] specifies the appropriate MMU_* command. > * ------------- > - * ptr[1:0] == MMU_NORMAL_PT_UPDATE: > + * ptr[2:0] == MMU_NORMAL_PT_UPDATE: > * Updates an entry in a page table belonging to PFD. If updating an L1 table, > * and the new table entry is valid/present, the mapped frame must belong to > * FD. If attempting to map an I/O page then the caller assumes the privilege > * of the FD. > * FD == DOMID_IO: Permit /only/ I/O mappings, at the priv level of the caller. > * FD == DOMID_XEN: Map restricted areas of Xen's heap space. > - * ptr[:2] -- Machine address of the page-table entry to modify. > + * ptr[:3] -- Machine address of the page-table entry to modify. > * val -- Value to write. > * > * There also certain implicit requirements when using this hypercall. The > @@ -264,17 +264,17 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t); > * mentioned above. The argument is MMUEXT_UNPIN_TABLE for all levels and the > * pagetable MUST not be in use (meaning that the cr3 is not set to it). > * > - * ptr[1:0] == MMU_MACHPHYS_UPDATE: > + * ptr[2:0] == MMU_MACHPHYS_UPDATE: > * Updates an entry in the machine->pseudo-physical mapping table. > - * ptr[:2] -- Machine address within the frame whose mapping to modify. > + * ptr[:3] -- Machine address within the frame whose mapping to modify. > * The frame must belong to the FD, if one is specified. > * val -- Value to write into the mapping entry. > * > - * ptr[1:0] == MMU_PT_UPDATE_PRESERVE_AD: > + * ptr[2:0] == MMU_PT_UPDATE_PRESERVE_AD: > * As MMU_NORMAL_PT_UPDATE above, but A/D bits currently in the PTE are ORed > * with those in @val. > * > - * ptr[1:0] == MMU_PT_UPDATE_NO_TRANSLATE: > + * ptr[2:0] == MMU_PT_UPDATE_NO_TRANSLATE: > * As MMU_NORMAL_PT_UPDATE above, but @val is not translated though FD > * page tables. > * Frediano From xen-devel-bounces@lists.xenproject.org Sun Aug 09 17:46:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2026 17:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387126.1628465 (Exim 4.92) (envelope-from ) id 1wt7bW-0006hh-Uw; Sun, 09 Aug 2026 17:46:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387126.1628465; Sun, 09 Aug 2026 17:46:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wt7bW-0006hZ-Pp; Sun, 09 Aug 2026 17:46:34 +0000 Received: by outflank-mailman (input) for mailman id 1387126; Sun, 09 Aug 2026 17:46:33 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wt7bU-0006hT-RN for xen-devel@lists.xenproject.org; Sun, 09 Aug 2026 17:46:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wt7bT-00F1qH-T7 for xen-devel@lists.xenproject.org; Sun, 09 Aug 2026 19:46:31 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a78bcb8-2eae-0a2a0a5409dd-0a2a450ccd8e-10 for ; Sun, 09 Aug 2026 19:46:31 +0200 Received: from [148.163.156.1] (helo=mx0a-001b2d01.pphosted.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a78bcf5-f479-0a2a450c0019-94a39c01e0a8-3 for ; Sun, 09 Aug 2026 19:46:31 +0200 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 679FW1sE3277678; Sun, 9 Aug 2026 17:45:49 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fwvq94twx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 09 Aug 2026 17:45:48 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 679HfJG7012053; Sun, 9 Aug 2026 17:45:47 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fxf5vt2bb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 09 Aug 2026 17:45:47 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 679HjjQR34275656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 9 Aug 2026 17:45:45 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0842520040; Sun, 9 Aug 2026 17:45:45 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7C40720043; Sun, 9 Aug 2026 17:45:42 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.87.135.220]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sun, 9 Aug 2026 17:45:42 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=pp1 header.d=ibm.com header.i="@ibm.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=1V46XsJ2ASYOMqPQa9NRG149ty7O7K B1wPG7dfwq0b8=; b=UabY2i2O0DFebgnB5Itk1pRi3/Htbxgsnj9zfMhYyXAq+k yF4QkmQIRPAjVGN5n1TRYRA93L73U7SajNdDfI3dDHHhuVPIhOocLrBCQRPGo6fO zRUesLej41tQv0v/OKC288JhXJxpOKbIav1Tz2cpvXyghY1uWfY3xJlpLdnQWSkO g9By3jcVfZdNthUqy8R7s35WFAUQpmZ+ICuM5XKofi9TBR9lWHWDncMDr7e2p4Pd ahAwkkpqBsFsqnU9UxNpc/YeN9/xorzOtztL+lqAorMkbJvqxaDn+ti/Ykb1NS4P GkIfLBl2FlcgU/0FYB7OxhPqwp9WpNOjoazF1Vnw== Date: Sun, 9 Aug 2026 19:45:41 +0200 From: Alexander Gordeev To: Muhammad Usama Anjum Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 1/9] mm: introduce hw_pte_t for PTE table storage Message-ID: <4a42c498-58ca-46f4-819f-da14cfba154f-agordeev@linux.ibm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-2-usama.anjum@arm.com> <3db8233c-3785-444e-b2eb-3e5fc5cb2f17-agordeev@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ehRYw8QMBCJQ6XIfQUmc1xOZ8VBocr8y X-Authority-Analysis: v=2.4 cv=PbDPQChd c=1 sm=1 tr=0 ts=6a78bccc cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=7CQSdrXTAAAA:8 a=7ZejAh3qsUrew3BXsuMA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA5MDE1OCBTYWx0ZWRfX8PAJydAF9Sdz 7Q3LQNawdCCW5p3S9Cbrhno/+8i0akWT9oxXen6S0nUhBQsH880/7RsGl95VX21rT54x9YhFqi1 20KERD3HCbwvoqxx4T70j96cVKwA2YxlZ6l2xOFcmMWRehBEI40oNe5oKbokVHGzUV8t5ZkpMSK ns0C/90GTY6G7Afmg3i4iWKGKI/x2MSzhpkhUmia4LUS0tqD/uSG8uJudCOs75ncoAMtIyBtPts SBc2vAEfXkhI2UuaiCwcdAwFVnvK8EgubcrGc/SgeNggiVPjDgs5qWQ8+vOIPtcC9cEpr02poOB Lg7APmO3Rx8vA6tguusRIZ4Fs8vWJdm8vnK+m2H0UOB6WahoA26KXbJqrB0927hzkoKT62s0AOf RGde2c8tcj7xMXKNQULCZu1ZlHt1NIVwRcJ45XzbncbVNxXZWhcoK8gsn97hT6hSSx+Fo3N5VVF ELeKceQfHYIaUoeswKw== X-Proofpoint-ORIG-GUID: ehRYw8QMBCJQ6XIfQUmc1xOZ8VBocr8y X-Proofpoint-Spam-Info: AW1haW4tMjYwODA5MDE1OCBTYWx0ZWRfX40Jd01nPAYq/ 0UVJDKsUAxNz/IYIJFjnAhSgQRETCQqeUcuCeVy3WJaqKm5o/wyOjpQIKh0TKZ3HawAxontKM5X Anm2JSFRi6CK3bLpHrJPHohn6MgFj5w= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-09_05,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608090158 X-purgate-ID: tlsNG-d25034/1786297591-03CD3A5B-548D1899/0/0 X-purgate-type: clean X-purgate-size: 4168 On Fri, Aug 07, 2026 at 04:24:00PM +0100, Muhammad Usama Anjum wrote: > On 07/08/2026 8:09 am, Alexander Gordeev wrote: > > On Thu, Aug 06, 2026 at 09:38:39AM +0100, Muhammad Usama Anjum wrote: > >> pte_t is used both for logical PTE values and for entries stored in a PTE > >> table, so pte_t * does not distinguish a pointer to a copied value from a > >> pointer to table storage. > >> > >> Introduce hw_pte_t as the generic name for a PTE table element. Define it > >> as a macro alias of pte_t by default. When an architecture selects > >> ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead. > >> This preserves the representation while allowing converted architectures > >> to enforce the distinction at compile time. > >> > >> Keep the C type definitions behind an __ASSEMBLY__ check because > >> architecture assembly sources can include this header indirectly. Include > >> asm/page.h so consumers such as linux/vmalloc.h retain the page definitions > >> they previously obtained from that header. > >> > >> Signed-off-by: Muhammad Usama Anjum > >> --- > >> Changes since RFC v1: > >> - Add the ARCH_HAS_HW_PTE_T opt-in and generic wrapper definition. > >> - Exclude the C type definitions from assembly sources. > >> - Update the description for the new opt-in model. > >> --- > >> MAINTAINERS | 1 + > >> include/linux/pgtable_types.h | 17 +++++++++++++++++ > >> mm/Kconfig | 3 +++ > >> 3 files changed, 21 insertions(+) > >> create mode 100644 include/linux/pgtable_types.h > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index e9c8567308a75..7169bea968cf5 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -16982,6 +16982,7 @@ F: include/linux/mmu_notifier.h > >> F: include/linux/pagewalk.h > >> F: include/linux/pgalloc.h > >> F: include/linux/pgtable.h > >> +F: include/linux/pgtable_types.h > >> F: include/linux/ptdump.h > >> F: include/linux/vmpressure.h > >> F: include/linux/vmstat.h > >> diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h > >> new file mode 100644 > >> index 0000000000000..70c3edd00a01b > >> --- /dev/null > >> +++ b/include/linux/pgtable_types.h > >> @@ -0,0 +1,17 @@ > >> +/* SPDX-License-Identifier: GPL-2.0 */ > >> +#ifndef _LINUX_PGTABLE_TYPES_H > >> +#define _LINUX_PGTABLE_TYPES_H > >> + > >> +#include > >> + > >> +#ifndef __ASSEMBLY__ > >> + > >> +#ifdef CONFIG_ARCH_HAS_HW_PTE_T > >> +typedef struct { pte_t __pte; } hw_pte_t; > > > > On s390 it fails to compile once we do typedef hw_pte_t *pgtable_t > > in asm/page.h. m68k, powerpc and sparc may also have such problem. > > > > The below declaration helps to resolve it using forward declaration > > and without meddling with headers, though I do not like it much: > > > > typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; > Thank you for testing it out on s390. > > As __hw_pte_t isn't being used yet in this series, would s390 enablement > patches add __hw_pte_t to this definition? I hope there is a better solution. As I noted m68k, powerpc and sparc may also be affected, so I would suggest to look into those as well. I would prefer s390 to use the generic one rather than circumvent a compile error in a custom way. > This could have been avoided if each architecture defined its own hw_pte_t. > But for now we are keeping the generic definition of hw_pte_t. > > > > >> +#else > >> +#define hw_pte_t pte_t > >> +#endif > >> + > >> +#endif /* !__ASSEMBLY__ */ > >> + > >> +#endif /* _LINUX_PGTABLE_TYPES_H */ > >> diff --git a/mm/Kconfig b/mm/Kconfig > >> index 331daf7fcfab5..31ba9ebf4aafd 100644 > >> --- a/mm/Kconfig > >> +++ b/mm/Kconfig > >> @@ -1316,6 +1316,9 @@ comment "GUP_TEST needs to have DEBUG_FS enabled" > >> config GUP_GET_PXX_LOW_HIGH > >> bool > >> > >> +config ARCH_HAS_HW_PTE_T > >> + bool > >> + > >> config DMAPOOL_TEST > >> tristate "Enable a module to run time tests on dma_pool" > >> depends on HAS_DMA > >> -- > >> 2.47.3 > >> > > -- > Thanks, > Usama > From xen-devel-bounces@lists.xenproject.org Sun Aug 09 22:38:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 09 Aug 2026 22:38:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387167.1628474 (Exim 4.92) (envelope-from ) id 1wtC9z-0007eK-3i; Sun, 09 Aug 2026 22:38:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387167.1628474; Sun, 09 Aug 2026 22:38:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtC9y-0007e9-V5; Sun, 09 Aug 2026 22:38:26 +0000 Received: by outflank-mailman (input) for mailman id 1387167; Sun, 09 Aug 2026 22:38:25 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtC9w-0007e3-Ga for xen-devel@lists.xenproject.org; Sun, 09 Aug 2026 22:38:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtC9u-00CROE-KE for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 00:38:22 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a790098-2eae-0a2a0a5409dd-0a2a4502bc58-30 for ; Mon, 10 Aug 2026 00:38:22 +0200 Received: from [131.159.0.202] (helo=mailout2.rbg.tum.de) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79015d-6ca4-0a2a45020019-839f00cab431-3 for ; Mon, 10 Aug 2026 00:38:21 +0200 Received: from mailrelay1n.ito.cit.tum.de (mailrelay1.in.tum.de [IPv6:2a09:80c0:254::14]) by mailout2.rbg.tum.de (Postfix) with ESMTPS id 8515E4C0240; Mon, 10 Aug 2026 00:38:21 +0200 (CEST) Received: from mail.in.tum.de (mailproxy.in.tum.de [IPv6:2a09:80c0::78]) by mailrelay1n.ito.cit.tum.de (Postfix) with ESMTPS id 4hJCTT2g9qz2xRH; Mon, 10 Aug 2026 00:38:21 +0200 (CEST) Received: by mail.in.tum.de (Postfix, from userid 112) id 55F894A03EE; Mon, 10 Aug 2026 00:38:21 +0200 (CEST) Received: (Authenticated sender: hoepf) by mail.in.tum.de (Postfix) with ESMTPSA id 030B74A008B; Mon, 10 Aug 2026 00:38:20 +0200 (CEST) (Extended-Queue-bit xtech_zn@fff.in.tum.de) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20220209 header.d=cit.tum.de header.i="@cit.tum.de" header.h="Date:From:To:Cc:Subject" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cit.tum.de; s=20220209; t=1786315101; bh=eWB0xF/Ua9gI7/dD9vLvBWcZzJ0BdDJBvA6sapEdlxU=; h=Date:From:To:Cc:Subject:From; b=TnMpww/Ilp+dvn2ZFWEpI6LGQ7bm0TCzfDvwr/HVki05fz/S1zXUx98gQCm5DQdaY 4tUq2wZA2y2h85+lrfQ6KjxDd9UhyCswyYqazCS5SxeMrzGVMmGcEDK7xj0lASBpAM /hL/aSEhbWoOOWDUd/6seLBfq3I4ukHttLCRqtSFzfk+U3qqwYa+kb34D3pF1p7/VO CX75jC47tMsxiBTAXAjMcU0/2YAGMDDaFtgeixVgb5H/mBckbk/UFS3GK6IOMD9w4x cUt9wG9kMZJsKfHUi1l4skAzFuZS/ARSZXG8OJYYmglTo5b35+bq7BK9ZKMok5FEFV IYl19WyXcJ96A== Date: Mon, 10 Aug 2026 00:38:19 +0200 From: Johann =?utf-8?Q?H=C3=B6pfner?= To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Teddy Astie Subject: [PATCH] x86/domctl: Fix unitialized copyback in XEN_DOMCTL_PSR_GET_* Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 1.5.3 at itovm121 X-Virus-Status: Clean X-purgate-ID: tlsNG-720697/1786315102-F12A12AC-150EB9B3/0/0 X-purgate-type: clean X-purgate-size: 1148 domctl_psr_get_val() copies unitialized stack space back if psr_get_val fails. Fix by zero-initializing v_. Fixes: 03f30dc193c8 ("x86: refactor psr: L3 CAT: implement get value flow.") Signed-off-by: Johann Höpfner --- Consider instead removing the local variable indirection introduced by 03f30dc193c8 and passing &(domctl)->u.psr_alloc.data to psr_get_val instead or only conditionally setting copyback true. xen/arch/x86/domctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index f26990208d..6e42fa383c 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -1347,7 +1347,7 @@ long arch_do_domctl( break; #define domctl_psr_get_val(d, domctl, type, copyback) ({ \ - uint32_t v_; \ + uint32_t v_ = 0; \ int r_ = psr_get_val((d), (domctl)->u.psr_alloc.target, \ &v_, (type)); \ \ -- 2.53.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 05:15:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 05:15:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387205.1628483 (Exim 4.92) (envelope-from ) id 1wtIMD-0002e3-0o; Mon, 10 Aug 2026 05:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387205.1628483; Mon, 10 Aug 2026 05:15:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtIMC-0002dv-SM; Mon, 10 Aug 2026 05:15:28 +0000 Received: by outflank-mailman (input) for mailman id 1387205; Mon, 10 Aug 2026 05:15:27 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtIMB-0002dp-75 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 05:15:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtIM9-00Gsoa-PH for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 07:15:25 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a795e33-2eae-0a2a0a5409dd-0a2a4502c6b6-40 for ; Mon, 10 Aug 2026 07:15:25 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a795e6d-6ca4-0a2a45020019-d155802eaca2-3 for ; Mon, 10 Aug 2026 07:15:25 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-495590dde14so17152245e9.0 for ; Sun, 09 Aug 2026 22:15:25 -0700 (PDT) Received: from notebook.. ([85.107.103.196]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995c7b2898sm207058025e9.4.2026.08.09.22.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 22:15:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786338925; x=1786943725; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Hm21pwCcSfBBYRAiBMC0UPopMsN4Ck6e6kpf8prhvNs=; b=JcvtXyA0X/GesC39VpBb5fdi4h4EN9cHYNgaWdB0dq4iCe7cxw4ZYEByjvBMvqsI7t 2R63aodwNHqP29G/9ZG5Q8HSWOQWqRkQMXwjhHqfC+pNDv6IYyAvQNX8XRnpa9ERwtcR EAa3gsFX/6v1kxtl+S5vsmW4/NvYyDlYRXfI9VntPeeUtcQv6zJqIPmeqnsx5bA5ZzCO klWQuCcMqQrSq4udvnXsivvbAsoe+lil7gmtZPxDf4PWCVH8zZZk++PuqMDCxhSrtRR6 9n5CYd+mEgxct755ZaTLsMlTM0swpZniXvh97993Ic4fM/MXrhipac4DH6Qm+tZbcq08 rjBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786338925; x=1786943725; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Hm21pwCcSfBBYRAiBMC0UPopMsN4Ck6e6kpf8prhvNs=; b=Wlruec5uU3tVKdJbuVh+6vjDSdOTy1UELV/f8B2VF8dpzRCJF3lQn5VWod/dkJChzd Srq5MK2ifRrHdn6hFXGFne4hn37ZJTQlJB49AWSn2D3pQjNA6ej6cL+dQZxCoKZCAPjI VNr6WB1hgR2zPI5B54KMyo+fWVWlEUtp9ktxghCXD+AI2uNdVMaIvcpKWxpw+1qEMA/4 UjLaIolRa1PnGPZaDTOKv5qvfBMmWeSs/BcqNK649dIfUngtVsGfBv2QgLBjqkWnYue0 GUfgria91/ZM1E9utoTwSGT3KtumxUso69z07urdHy3bVmpZ3GKfdeQIIrDAH2hk83UF 1O9A== X-Gm-Message-State: AOJu0YwlLac9RoOrsh5EKncI9InalflfPQXr7RjbrC5jh7/gSg+UqMTC IjnNYcgQZYjeEpaHNONDdLtAy6k3btaAianAiM3V/dlG7Ha7wUYYlmJa3rPEwQ== X-Gm-Gg: AR+sD10c7RpZiztVukDTFrzltY3jSSwzBhr0QfXTYWSDPajsH9RtCbyZRbjua0pmcaP jrxbWy8yNuZpllGqszfrrlmxgdYHRr23ODbtfhWjQEx8ERQbcyRrd2GYb92XFi0w+K1CIoRDdAJ VeBIzbplrjS6Snv7ft+SfrKmbhvjX6ZjA//mA7bvxNy908zC6irZS39fWaMRwdQIhjiVn1QIncl JjR8TH5ZT8pdsMA6M/KkmRRFXbKcjVAr5gGPMpFhME7Y7+JnYwCyiSB/sMCrKix95Jy7rnVrvrn Jnz0oUKykcIhQajeC/Z5gu2oBhSzDDqJ78A54MASic50dE6Ryn9saY9UeWjFTzrJZ5hxTpj8mQz Kps4s/BT4zHV2NWc8xAvvEBjY2ydRdkM1LbJQFeU2+psajbexx6ph6Xgvov2QGZ5/jJiI8A1qAD gsrgCCv6sVxBgsZevPNN2PKZSJMFXVxVMyhII2Zb3DX60o2TryhUf/Izc2YaO+Rg== X-Received: by 2002:a05:600c:4ed3:b0:493:e983:806e with SMTP id 5b1f17b1804b1-4994e72f795mr544276295e9.3.1786338924899; Sun, 09 Aug 2026 22:15:24 -0700 (PDT) From: Furkan Caliskan To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, jgross@suse.com, gwd@xenproject.org, dfaggioli@suse.com, stewart.hildebrand@amd.com, nathan.studer@dornerworks.com, roger@xenproject.org, anthony.perard@vates.tech, julien@xen.org, sstabellini@kernel.org, michal.orzel@amd.com, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, teddy.astie@vates.tech, Furkan Caliskan Subject: [PATCH v3] xen/sched: split scheduler vtable from struct scheduler Date: Mon, 10 Aug 2026 08:15:01 +0300 Message-Id: <20260810051501.6282-1-frn1furkan10@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1786338925-F0AA52AC-51B1DC04/0/0 X-purgate-type: clean X-purgate-size: 20320 struct scheduler currently serves two purposes: it is the static vtable a scheduler backend defines (name, opt_name, sched_id, and all its function pointers), and it is also the per-cpupool runtime object scheduler_alloc() allocates. Being the same type forces scheduler_alloc() to memcpy() the whole vtable into a fresh allocation per cpupool, duplicating identical function pointers across every cpupool using the same scheduler. Split the vtable out into its own type, struct sched_ops, so it can be shared by every cpupool using a given scheduler instead of copied per cpupool. struct scheduler is left holding only what is actually per-instance: a pointer to the shared sched_ops, plus sched_data and cpupool. scheduler_alloc() now stores a pointer to the matching sched_ops instance instead of copying its fields and uses xzalloc() to zero-initialize the struct. Every accessor in private.h is updated from s->field to s->ops->field to match. Every in-tree scheduler backend (credit, credit2, rtds, arinc653, null) is converted from struct scheduler to struct sched_ops. Also drop the generic comment in arinc653.c. A handful of call sites elsewhere read a scheduler's name, opt_name or sched_id directly and are updated to go through ->ops as well. Signed-off-by: Furkan Caliskan Reviewed-by: Juergen Gross Acked-by: Stewart Hildebrand --- v3: * fixed whitespace and blank-lines * mentioned the xzalloc() change and the arinc653 comment removal * fixed the overlong lines. --- xen/common/sched/arinc653.c | 9 +--- xen/common/sched/core.c | 51 +++++++++++-------- xen/common/sched/cpupool.c | 7 +-- xen/common/sched/credit.c | 3 +- xen/common/sched/credit2.c | 3 +- xen/common/sched/null.c | 3 +- xen/common/sched/private.h | 98 +++++++++++++++++++------------------ xen/common/sched/rt.c | 3 +- 8 files changed, 90 insertions(+), 87 deletions(-) diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c index 32c596a23c..746963806e 100644 --- a/xen/common/sched/arinc653.c +++ b/xen/common/sched/arinc653.c @@ -702,17 +702,10 @@ a653sched_adjust_global(const struct scheduler *ops, } #endif /* CONFIG_SYSCTL */ -/** - * This structure defines our scheduler for Xen. - * The entries tell Xen where to find our scheduler-specific - * callback functions. - * The symbol must be visible to the rest of Xen at link time. - */ -static const struct scheduler sched_arinc653_def = { +static const struct sched_ops sched_arinc653_def = { .name = "ARINC 653 Scheduler", .opt_name = "arinc653", .sched_id = XEN_SCHEDULER_ARINC653, - .sched_data = NULL, .init = a653sched_init, .deinit = a653sched_deinit, diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 9ccf5811bf..e4e4da95d8 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -87,7 +87,8 @@ DEFINE_PER_CPU(cpumask_t, cpumask_scratch); /* How many urgent vcpus. */ DEFINE_PER_CPU(atomic_t, sched_urgent_count); -extern const struct scheduler *__start_schedulers_array[], *__end_schedulers_array[]; +extern const struct sched_ops *__start_schedulers_array[]; +extern const struct sched_ops *__end_schedulers_array[]; #define NUM_SCHEDULERS (__end_schedulers_array - __start_schedulers_array) #define schedulers __start_schedulers_array @@ -127,10 +128,9 @@ static void cf_check sched_idle_schedule( unit->next_task = sched_idle_unit(cpu); } -static struct scheduler sched_idle_ops = { +static struct sched_ops sched_idle_sched_ops = { .name = "Idle Scheduler", .opt_name = "idle", - .sched_data = NULL, .pick_resource = sched_idle_res_pick, .do_schedule = sched_idle_schedule, @@ -139,6 +139,11 @@ static struct scheduler sched_idle_ops = { .free_udata = sched_idle_free_udata, }; +static struct scheduler sched_idle_ops = { + .ops = &sched_idle_sched_ops, + .sched_data = NULL, +}; + static inline struct vcpu *unit2vcpu_cpu(const struct sched_unit *unit, unsigned int cpu) { @@ -2081,7 +2086,7 @@ long do_set_timer_op(s_time_t timeout) /* scheduler_id - fetch ID of current scheduler */ int scheduler_id(void) { - return operations.sched_id; + return operations.ops->sched_id; } #endif @@ -2090,7 +2095,7 @@ long sched_adjust(struct domain *d, struct xen_domctl_scheduler_op *op) { long ret; - if ( op->sched_id != dom_scheduler(d)->sched_id ) + if ( op->sched_id != dom_scheduler(d)->ops->sched_id ) return -EINVAL; switch ( op->cmd ) @@ -2132,7 +2137,7 @@ long sched_adjust_global(struct xen_sysctl_scheduler_op *op) rcu_read_lock(&sched_res_rculock); - rc = ((op->sched_id == pool->sched->sched_id) + rc = ((op->sched_id == pool->sched->ops->sched_id) ? sched_adjust_cpupool(pool->sched, op) : -EINVAL); rcu_read_unlock(&sched_res_rculock); @@ -2299,7 +2304,7 @@ static struct sched_unit *do_schedule(struct sched_unit *prev, s_time_t now, struct sched_unit *next; /* get policy-specific decision on scheduling... */ - sched->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); + sched->ops->do_schedule(sched, prev, now, sched_tasklet_check(cpu)); next = prev->next_task; @@ -2989,7 +2994,7 @@ void scheduler_enable(void) } static inline -const struct scheduler *__init sched_get_by_name(const char *sched_name) +const struct sched_ops *__init sched_ops_get_by_name(const char *sched_name) { unsigned int i; @@ -3002,16 +3007,16 @@ const struct scheduler *__init sched_get_by_name(const char *sched_name) int __init sched_get_id_by_name(const char *sched_name) { - const struct scheduler *scheduler = sched_get_by_name(sched_name); + const struct sched_ops *ops = sched_ops_get_by_name(sched_name); - return scheduler ? scheduler->sched_id : -1; + return ops ? ops->sched_id : -1; } /* Initialise the data structures. */ void __init scheduler_init(void) { struct domain *idle_domain; - const struct scheduler *scheduler; + const struct sched_ops *ops; int i; scheduler_enable(); @@ -3044,21 +3049,23 @@ void __init scheduler_init(void) } } - scheduler = sched_get_by_name(opt_sched); - if ( !scheduler ) + ops = sched_ops_get_by_name(opt_sched); + if ( !ops ) { printk("Could not find scheduler: %s\n", opt_sched); - scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT); - BUG_ON(!scheduler); - printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name); + ops = sched_ops_get_by_name(CONFIG_SCHED_DEFAULT); + BUG_ON(!ops); + printk("Using '%s' (%s)\n", ops->name, ops->opt_name); } - operations = *scheduler; + + operations.ops = ops; if ( cpu_schedule_up(0) ) BUG(); register_cpu_notifier(&cpu_schedule_nfb); - printk("Using scheduler: %s (%s)\n", operations.name, operations.opt_name); + printk("Using scheduler: %s (%s)\n", + operations.ops->name, operations.ops->opt_name); if ( sched_init(&operations) ) panic("scheduler returned error on init\n"); @@ -3411,12 +3418,14 @@ struct scheduler *scheduler_alloc(unsigned int sched_id) for ( i = 0; i < NUM_SCHEDULERS; i++ ) if ( schedulers[i] && schedulers[i]->sched_id == sched_id ) goto found; + return ERR_PTR(-ENOENT); found: - if ( (sched = xmalloc(struct scheduler)) == NULL ) + if ( (sched = xzalloc(struct scheduler)) == NULL ) return ERR_PTR(-ENOMEM); - memcpy(sched, schedulers[i], sizeof(*sched)); + sched->ops = schedulers[i]; + if ( (ret = sched_init(sched)) != 0 ) { xfree(sched); @@ -3447,7 +3456,7 @@ void schedule_dump(struct cpupool *c) { sched = c->sched; cpus = c->res_valid; - printk("Scheduler: %s (%s)\n", sched->name, sched->opt_name); + printk("Scheduler: %s (%s)\n", sched->ops->name, sched->ops->opt_name); sched_dump_settings(sched); } else diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 081e1053eb..640578201f 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -338,7 +338,8 @@ static struct cpupool *cpupool_create(unsigned int poolid, spin_unlock(&cpupool_lock); debugtrace_printk("Created cpupool %u with scheduler %s (%s)\n", - c->cpupool_id, c->sched->name, c->sched->opt_name); + c->cpupool_id, c->sched->ops->name, + c->sched->ops->opt_name); return c; @@ -862,7 +863,7 @@ int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op) if ( c == NULL ) break; op->cpupool_id = c->cpupool_id; - op->sched_id = c->sched->sched_id; + op->sched_id = c->sched->ops->sched_id; op->n_dom = c->n_dom; ret = cpumask_to_xenctl_bitmap(&op->cpumap, c->cpu_valid); cpupool_put(c); @@ -1294,7 +1295,7 @@ struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id) struct cpupool *pool; if ( sched_id < 0 ) - sched_id = scheduler_get_default()->sched_id; + sched_id = scheduler_get_default()->ops->sched_id; pool = cpupool_create(pool_id, sched_id); diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 4dde2ede12..8df746bf6b 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -2277,11 +2277,10 @@ csched_deinit(struct scheduler *ops) } } -static const struct scheduler sched_credit_def = { +static const struct sched_ops sched_credit_def = { .name = "SMP Credit Scheduler", .opt_name = "credit", .sched_id = XEN_SCHEDULER_CREDIT, - .sched_data = NULL, .global_init = csched_global_init, diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index 95946634d1..4949606881 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -4230,11 +4230,10 @@ csched2_deinit(struct scheduler *ops) xfree(prv); } -static const struct scheduler sched_credit2_def = { +static const struct sched_ops sched_credit2_def = { .name = "SMP Credit Scheduler rev2", .opt_name = "credit2", .sched_id = XEN_SCHEDULER_CREDIT2, - .sched_data = NULL, .global_init = csched2_global_init, diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index 952bb47444..b3c6651fb1 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -1037,11 +1037,10 @@ static void cf_check null_dump(const struct scheduler *ops) spin_unlock_irqrestore(&prv->lock, flags); } -static const struct scheduler sched_null_def = { +static const struct sched_ops sched_null_def = { .name = "null Scheduler", .opt_name = "null", .sched_id = XEN_SCHEDULER_NULL, - .sched_data = NULL, .init = null_init, .deinit = null_deinit, diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index d6884550cd..18ccab183e 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -294,12 +294,10 @@ static inline spinlock_t *pcpu_schedule_trylock(unsigned int cpu) return NULL; } -struct scheduler { - const char *name; /* full name for this scheduler */ - const char *opt_name; /* option name for this scheduler */ - unsigned int sched_id; /* ID for this scheduler */ - void *sched_data; /* global data pointer */ - struct cpupool *cpupool;/* points to this scheduler's pool */ +struct sched_ops { + const char *name; /* full name for this sched_ops */ + const char *opt_name; /* option name for this sched_ops */ + unsigned int sched_id; /* ID for this sched_ops */ int (*global_init) (void); @@ -366,127 +364,133 @@ struct scheduler { struct sched_resource *sr); }; +struct scheduler { + const struct sched_ops *ops; /* shared, read-only dispatch table */ + void *sched_data; /* per-cpupool scheduler-private data */ + struct cpupool *cpupool; /* points to this scheduler's pool */ +}; + static inline int sched_init(struct scheduler *s) { - return s->init(s); + return s->ops->init(s); } static inline void sched_deinit(struct scheduler *s) { - s->deinit(s); + s->ops->deinit(s); } static inline spinlock_t *sched_switch_sched(struct scheduler *s, unsigned int cpu, void *pdata, void *vdata) { - return s->switch_sched(s, cpu, pdata, vdata); + return s->ops->switch_sched(s, cpu, pdata, vdata); } static inline void sched_dump_settings(const struct scheduler *s) { - if ( s->dump_settings ) - s->dump_settings(s); + if ( s->ops->dump_settings ) + s->ops->dump_settings(s); } static inline void sched_dump_cpu_state(const struct scheduler *s, int cpu) { - if ( s->dump_cpu_state ) - s->dump_cpu_state(s, cpu); + if ( s->ops->dump_cpu_state ) + s->ops->dump_cpu_state(s, cpu); } static inline void *sched_alloc_domdata(const struct scheduler *s, struct domain *d) { - return s->alloc_domdata ? s->alloc_domdata(s, d) : NULL; + return s->ops->alloc_domdata ? s->ops->alloc_domdata(s, d) : NULL; } static inline void sched_free_domdata(const struct scheduler *s, void *data) { - ASSERT(s->free_domdata || !data); - if ( s->free_domdata ) - s->free_domdata(s, data); + ASSERT(s->ops->free_domdata || !data); + if ( s->ops->free_domdata ) + s->ops->free_domdata(s, data); } static inline void *sched_alloc_pdata(const struct scheduler *s, int cpu) { - return s->alloc_pdata ? s->alloc_pdata(s, cpu) : NULL; + return s->ops->alloc_pdata ? s->ops->alloc_pdata(s, cpu) : NULL; } static inline void sched_free_pdata(const struct scheduler *s, void *data, int cpu) { - ASSERT(s->free_pdata || !data); - if ( s->free_pdata ) - s->free_pdata(s, data, cpu); + ASSERT(s->ops->free_pdata || !data); + if ( s->ops->free_pdata ) + s->ops->free_pdata(s, data, cpu); } static inline void sched_deinit_pdata(const struct scheduler *s, void *data, int cpu) { - if ( s->deinit_pdata ) - s->deinit_pdata(s, data, cpu); + if ( s->ops->deinit_pdata ) + s->ops->deinit_pdata(s, data, cpu); } static inline void *sched_alloc_udata(const struct scheduler *s, struct sched_unit *unit, void *dom_data) { - return s->alloc_udata(s, unit, dom_data); + return s->ops->alloc_udata(s, unit, dom_data); } static inline void sched_free_udata(const struct scheduler *s, void *data) { - s->free_udata(s, data); + s->ops->free_udata(s, data); } static inline void sched_insert_unit(const struct scheduler *s, struct sched_unit *unit) { - if ( s->insert_unit ) - s->insert_unit(s, unit); + if ( s->ops->insert_unit ) + s->ops->insert_unit(s, unit); } static inline void sched_remove_unit(const struct scheduler *s, struct sched_unit *unit) { - if ( s->remove_unit ) - s->remove_unit(s, unit); + if ( s->ops->remove_unit ) + s->ops->remove_unit(s, unit); } static inline void sched_sleep(const struct scheduler *s, struct sched_unit *unit) { - if ( s->sleep ) - s->sleep(s, unit); + if ( s->ops->sleep ) + s->ops->sleep(s, unit); } static inline void sched_wake(const struct scheduler *s, struct sched_unit *unit) { - if ( s->wake ) - s->wake(s, unit); + if ( s->ops->wake ) + s->ops->wake(s, unit); } static inline void sched_yield(const struct scheduler *s, struct sched_unit *unit) { - if ( s->yield ) - s->yield(s, unit); + if ( s->ops->yield ) + s->ops->yield(s, unit); } static inline void sched_context_saved(const struct scheduler *s, struct sched_unit *unit) { - if ( s->context_saved ) - s->context_saved(s, unit); + if ( s->ops->context_saved ) + s->ops->context_saved(s, unit); } static inline void sched_migrate(const struct scheduler *s, struct sched_unit *unit, unsigned int cpu) { - if ( s->migrate ) - s->migrate(s, unit, cpu); + if ( s->ops->migrate ) + s->ops->migrate(s, unit, cpu); else sched_set_res(unit, get_sched_res(cpu)); } @@ -494,7 +498,7 @@ static inline void sched_migrate(const struct scheduler *s, static inline struct sched_resource *sched_pick_resource( const struct scheduler *s, const struct sched_unit *unit) { - return s->pick_resource(s, unit); + return s->ops->pick_resource(s, unit); } static inline void sched_adjust_affinity(const struct scheduler *s, @@ -502,29 +506,29 @@ static inline void sched_adjust_affinity(const struct scheduler *s, const cpumask_t *hard, const cpumask_t *soft) { - if ( s->adjust_affinity ) - s->adjust_affinity(s, unit, hard, soft); + if ( s->ops->adjust_affinity ) + s->ops->adjust_affinity(s, unit, hard, soft); } static inline int sched_adjust_dom(const struct scheduler *s, struct domain *d, struct xen_domctl_scheduler_op *op) { - return s->adjust ? s->adjust(s, d, op) : 0; + return s->ops->adjust ? s->ops->adjust(s, d, op) : 0; } #ifdef CONFIG_SYSCTL static inline int sched_adjust_cpupool(const struct scheduler *s, struct xen_sysctl_scheduler_op *op) { - return s->adjust_global ? s->adjust_global(s, op) : 0; + return s->ops->adjust_global ? s->ops->adjust_global(s, op) : 0; } #endif static inline void sched_move_timers(const struct scheduler *s, struct sched_resource *sr) { - if ( s->move_timers ) - s->move_timers(s, sr); + if ( s->ops->move_timers ) + s->ops->move_timers(s, sr); } static inline void sched_unit_pause_nosync(const struct sched_unit *unit) @@ -543,7 +547,7 @@ static inline void sched_unit_unpause(const struct sched_unit *unit) vcpu_unpause(v); } -#define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \ +#define REGISTER_SCHEDULER(x) static const struct sched_ops *x##_entry \ __used_section(".data.schedulers") = &(x) struct cpupool diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index 744f214173..0e9f04ea72 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -1617,11 +1617,10 @@ static void cf_check repl_timer_handler(void *data) spin_unlock_irq(&prv->lock); } -static const struct scheduler sched_rtds_def = { +static const struct sched_ops sched_rtds_def = { .name = "SMP RTDS Scheduler", .opt_name = "rtds", .sched_id = XEN_SCHEDULER_RTDS, - .sched_data = NULL, .dump_cpu_state = rt_dump_pcpu, .dump_settings = rt_dump, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 06:45:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 06:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387220.1628492 (Exim 4.92) (envelope-from ) id 1wtJl9-0007sd-Cx; Mon, 10 Aug 2026 06:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387220.1628492; Mon, 10 Aug 2026 06:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtJl9-0007sV-8m; Mon, 10 Aug 2026 06:45:19 +0000 Received: by outflank-mailman (input) for mailman id 1387220; Mon, 10 Aug 2026 06:45:18 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtJl8-0007sP-Jf for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 06:45:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtJl6-002EPF-NU for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 08:45:16 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79735d-e002-0a2a0a5209dd-0a2a4507af76-44 for ; Mon, 10 Aug 2026 08:45:16 +0200 Received: from [148.163.156.1] (helo=mx0a-001b2d01.pphosted.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79737a-b4ea-0a2a45070019-94a39c01c418-3 for ; Mon, 10 Aug 2026 08:45:16 +0200 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67A5VYZX3085069; Mon, 10 Aug 2026 06:44:38 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fwvjypkqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Aug 2026 06:44:37 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67A6ffw0026503; Mon, 10 Aug 2026 06:44:36 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4fxhfxueyp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Aug 2026 06:44:36 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67A6iYQG34930976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Aug 2026 06:44:34 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 17B532004B; Mon, 10 Aug 2026 06:44:34 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2335D20043; Mon, 10 Aug 2026 06:44:31 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.87.135.220]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 10 Aug 2026 06:44:31 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=pp1 header.d=ibm.com header.i="@ibm.com" header.h="Cc:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=vVPGPVZ23NsreeExE7+jGCM0ud2bcA JA4ypv1DILR34=; b=cP2dX1rqRgJGyJQPsc4KFbE1PC99K1ErC8LoPBcJX/kDVk D9Jo4Iz1SXdFchU8Ko5W4WB9COXrRcti5DpxhwdI5dfEePzz5UmgRzT8EYYyBi07 KU36zRJaFsP0Akw7apyJ4SCl4IAb1VRGvP8L0mKhwBZnn0XUkDZ2PW7t9oviZUQq bN2tmVBhSWNgiSiSi7ymdtf6iKh4gNTCCXIweHK0Tg6HF6KYslOZj/J1AEcJVHnf kWNlsq5fwLgQr2DlUZF0whZYM5XqlyiEV4xJgAR6wPkWOH+OEMcVL/bVHH8IYS6D MxDe73qz6EXJrcPmB5P+oxGbZoA1keo68zERDcAg== Date: Mon, 10 Aug 2026 08:44:29 +0200 From: Alexander Gordeev To: Muhammad Usama Anjum Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 6/9] mm: convert PTE table entry to pte Message-ID: <2599c5b3-e8ac-4865-993b-d41e6f060d52-agordeev@linux.ibm.com> References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-7-usama.anjum@arm.com> <5c329236-7761-4e42-a549-b822e43b4358@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c329236-7761-4e42-a549-b822e43b4358@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDA1NCBTYWx0ZWRfXxI/cthX2D0Wc iHPLS8hc2Kj/zk+XaKiAAFgipdFaX6yt5ULiZYFw9cMykKZhsGzYdz8Ozez/WjJFTxNxMxdlY+Z xRKD8hb46fc3eq4T3zk/Ay2gFewaqBQyLERBaqjOrmguPqyfrY4V/sj3PMJQSwHxbC9gQ3JPdGp nwoFQng/LWfi/b2CNXX0ejbyTRbXCpU6ISkPy5ReFIqwletsdYxZQh3JZdOlQrUjBCsND1GblNt G/4DaSrhSqHIA4lB3PliH1JLOCq/gqtakESjF4VI9bapYhuQXt1SuBKOBQMvOtnuq4THGnpYdaA 9DlU8ZKdg0fttjy6cWWMXxwJNMzsJQnfWACC9mQPG3O4x/cS3d0NgAmCjmdVYfXi8XGUV9/5PxJ HdlkuRfRyvN/kE+SQ4EeTy+wa+g6t6URPTCSrkC11WsiBzyO9FuJFEs1QK/7K/rvQyfHrqCYbs4 iMEVrVdUzEx5zR0r21A== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDA1NCBTYWx0ZWRfX9Ko1NY31ilHb y/krrlO5A2ANnAiXusNks5NMrWI4UvS7c1Y7yzgoGS6CxTGjDGRyAu8EHxJ1ITitPdxPjbMc8pe lyb7xPyJDB1SIBriSbnTKYVPxMcf33w= X-Authority-Analysis: v=2.4 cv=RqD16imK c=1 sm=1 tr=0 ts=6a797355 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VwQbUJbxAAAA:8 a=7CQSdrXTAAAA:8 a=VnNF1IyMAAAA:8 a=2hzp2EkNZNX3k9pX5ccA:9 a=CjuIK1q_8ugA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: YbHEwP5JTLZr3QYF8zr2RkJeozrhuIz7 X-Proofpoint-ORIG-GUID: YbHEwP5JTLZr3QYF8zr2RkJeozrhuIz7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_01,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100054 X-purgate-ID: tlsNG-ef75cf/1786344316-A50CDAE4-BE82F9CE/0/0 X-purgate-type: clean X-purgate-size: 3062 On Fri, Aug 07, 2026 at 05:26:04PM +0100, Muhammad Usama Anjum wrote: > On 07/08/2026 7:58 am, Alexander Gordeev wrote: > > On Thu, Aug 06, 2026 at 09:38:44AM +0100, Muhammad Usama Anjum wrote: > >> The non-MMU stub receives hw_pte_t but returns a logical pte_t > >> value. Convert the stored entry through __pte_from_hw() before > >> returning. > >> > >> Signed-off-by: Muhammad Usama Anjum > >> --- > >> include/linux/hugetlb.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > >> index bc0b9c65aa1d0..9e8b391aa4bc9 100644 > >> --- a/include/linux/hugetlb.h > >> +++ b/include/linux/hugetlb.h > >> @@ -1283,7 +1283,7 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, > >> #ifdef CONFIG_MMU > >> return ptep_get(ptep); > >> #else > >> - return *ptep; > >> + return __pte_from_hw(*ptep); > > > > But this is a direct dereferencing, which breaks the whole point, isn't it? > Yes, this is particular line is for non MMU. In this case, CONIFG_ARCH_HAS_HW_PTE > would never be defined. Hence hw_pte_t is just pte_t and direct dereference is > allowed. I'd thought a lot about it; is better to leave direct dereference here > or use some helper. Then used __pte_from_hw() was already being used in generic > ptep_get(). But in case CONIFG_ARCH_HAS_HW_PTE=n __pte_from_hw() is still gets called. That looks inconsistent to me. Why not just call ptep_deref() (see below)? > There are only two users of __pte_from_hw() at this time. > > > > > What about introducing something like pte_t ptep_get_sw(hw_pte_t *ptep) > > to be used in exactly situations like this? With that the semantics of > > hw_pte_t pointers becomes straightforward and closes the still ongoing > > "storage vs lifetime" discussion: > > > > hw_pte_t* points to HW-formatted page table entries > > > > ptep_get() is used to obtain HW-linked/attached entries, and may wire > > extra code like [1] or [2] > > > > ptep_get_sw() is used to obtain HW-unlinked/unattached entries and in > > most cases is just a direct dereference > ptep_get_sw() or ptep_get_deref() is better name here? ptep_deref() would be it. Do you agree to the suggested API requirements? > I thought __pte_from_hw() is ugly enough that if someone tries to use it > wrongly, it'll be noticed pretty easily. I'm fine with any other name. The name may be not perfect, but it is the way it is used above looks wrong to me. > > The caller should always know whether the entry is attached or not, so > > confusions like [3] are avoided. > > > > 1. https://lore.kernel.org/linux-mm/20260526-kpkeys-v8-21-eaaacdacc67c@arm.com/ > > 2. https://lore.kernel.org/linux-s390/650903a4-0dd9-4e6b-9d4b-3c32c5657236-agordeev@linux.ibm.com/ > > 3. https://lore.kernel.org/linux-s390/b44e071d-7c9d-4e7e-a84d-4af3499a5a05@arm.com/ > > > >> #endif > >> } Thanks! > -- > Thanks, > Usama > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 08:50:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 08:50:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387244.1628501 (Exim 4.92) (envelope-from ) id 1wtLiH-0000iM-8s; Mon, 10 Aug 2026 08:50:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387244.1628501; Mon, 10 Aug 2026 08:50:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtLiH-0000iF-5g; Mon, 10 Aug 2026 08:50:29 +0000 Received: by outflank-mailman (input) for mailman id 1387244; Mon, 10 Aug 2026 08:50:27 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtLiF-0000i9-3R for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 08:50:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtLiE-007vGO-19 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:50:26 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7990cb-8faa-0a2a0a5109dd-0a2a4509b816-12 for ; Mon, 10 Aug 2026 10:50:25 +0200 Received: from [209.85.128.42] (helo=mail-wm1-f42.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7990d1-be1a-0a2a45090019-d155802adc97-3 for ; Mon, 10 Aug 2026 10:50:25 +0200 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4954afac04bso17657615e9.0 for ; Mon, 10 Aug 2026 01:50:25 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995e9ea92csm278572485e9.4.2026.08.10.01.50.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 01:50:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786351825; x=1786956625; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=v7DOr//1UMzxx+qvWjE8pgs9kDMNMgbOq3Hi6M6TC7U=; b=PIkVWlyC5Z2NveOk3zRh6zl9TAajdIZVGZs9uadB0jOK+g+SGkVwgf8x1bEty0N37U qBSmAw2VakRIsNyoGDiTg+cDxBT5NOwJs7I94hu66wWbcCB02/JQU1bRP0z/7IfikzEc kSP+MbAXk74dYmQJuJ9PWE8jFb3p0SJ4DD947DrfhtrOjEqK5161v7dKu1neQMFhQ9AB IRJVntugLJEhSeqSjuD7l3VeNTMiJ6O3f9ZdWj6AFAo/wdDSIW1BEvf0GslEZTMP1tkE IFl9AK1aCC8BVO7oZ/Rdncn6falRo1ZF3o/79xquL6Vv+wpGngIJsDgyU7yuMN/jVOKc vmeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786351825; x=1786956625; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v7DOr//1UMzxx+qvWjE8pgs9kDMNMgbOq3Hi6M6TC7U=; b=DliCiWilLdvx6BO+2Q03j2ybSnsVR+sEj95jm7hhpjj44wGY6UvG1D6fGAv3kGi5Wb ZHtHZYXSlzh8tYIaOqyZYgxfnlhvX7Q/UW+6e5B3kXGE3rLycMNokoSoXQeMjZK4ITAn tv1UexvcWtKV4aAJ8lCCwplEFhLnsOSXau9f/q2PuSkUaB/i5SqhWUsT73jaomOn/s41 gUEMwV4mJujI4VKSHXj86vPdKqAhcY+47lY+ydtA/itt+RHwE0fxZcBe0shgVgStNQjo GURpPZy2Xw611IKYV8KBzhLmhuDpioPOzUQ64Oc3BdITh3JPJL6BxOU82+s0ijijkGEE JE0A== X-Forwarded-Encrypted: i=1; AHgh+RoslYNr19aqX6Ln3VER5AA0NArTUts/InTHZz0oJgTeIVeVIvoQmeVsJfeTI2uZj6YhnZQfjMwafwo=@lists.xenproject.org X-Gm-Message-State: AOJu0YwEuUiUVDxQ9n2UnINSLqv2HanOeWo7TyMi/MAoXnh6DrUdTNha LrOQZWblkTAc7A4V5PffwLtV5geCOfT7HViRROwbZKFzosxIUcdt8vC+ X-Gm-Gg: AR+sD13uygAh7FUrjSMepfj8zKQTc1Hqb590JV6oZFzQISAB7l2DNMg/WqAHeZB7Noo GB5cW8LeZ09RUFLWcATnXZiUOGDXwlspkJM/2XZ6goUkD8IaH4UHnvon1cG2BpAp46cvGjSA8Mf 8ca80g0LD5tObO6NKugpml6MK9QRkIjTRNiNRaoUFvSp7ZHnQwkRhUTzPbAw0cFCJAU/IOy3/TU F4C9EkrLSFMxddLyVzjYRt/z2oB6OR3B0Kzl12jXw2X45uWT2wn0tRn5tK1tnAdB4cL87/lSnVZ 5wL0RvzqV/VGyXwCyA1SOaFccoimhN/aIhdK/4JIxOODEji2lLf9Ho2oCcTXRL1PC6jpoHGLAtH IXfiCRi6DCaGoXjon9v/XKlwt+iqjkZuheGs3w/TKJAFEo5ypvYGTFUIG1lN664GFbOfvx6FZRz A7KZG4hJx2vSEvPD8vcb7oOy8tsvbwvhG6l5wHxoN0pJ6ENFqxx8BHBiFVDyLWImXuKIG/PdJLC qPjE6Gkub/JWHuN9ScBtvwLrTskeU0sD6SB9PmswV1UtqJhNExwvzA= X-Received: by 2002:a05:600c:4e88:b0:495:4491:b8c2 with SMTP id 5b1f17b1804b1-4996194e257mr217755905e9.3.1786351824681; Mon, 10 Aug 2026 01:50:24 -0700 (PDT) Message-ID: <2071e8f2-4994-4b8f-affb-999376250e35@gmail.com> Date: Mon, 10 Aug 2026 10:50:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/17] xen/riscv: map IMSIC interrupt file for vCPUs To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <254f470ae2e2b2a4affa7c405be8c07a7d8b300e.1784560663.git.oleksii.kurochko@gmail.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1786351825-3A2C4034-AA4EDBFB/10/73395122804 X-purgate-type: spam X-purgate-size: 6384 On 8/6/26 4:48 PM, Jan Beulich wrote: > On 20.07.2026 18:02, Oleksii Kurochko wrote: >> A guest running in VS-mode expects its own IMSIC S-file at offset 0 of its >> guest-physical IMSIC block. Physically, the guest-file (G-file) assigned to >> this vCPU lives at a hart-relative offset given by guest_file_id (assigned >> via the vGEIN allocator). Therefore, imsic_map_guest_file() uses stage-2 >> translation to redirect the guest's fixed per-vCPU GPA page (offset 0) to >> the specific physical guest-file page. >> >> Signed-off-by: Oleksii Kurochko >> --- >> The corresponding unmap of the IMSIC interrupt file will be introduced >> separately when the need arises. > > Doesn't the need exist right away? There is ... > >> @@ -342,6 +344,67 @@ static int __init imsic_parse_node(const struct dt_device_node *node, >> return 0; >> } >> >> +/* >> + * Map the physical IMSIC guest interrupt file (G-file) assigned to vCPU v >> + * into the domain's stage-2 guest-physical address space. >> + * >> + * In the machine's physical address space (SPA), each hart's IMSIC >> + * supervisor-level file (S-file) is located at offset 0 of its address block, >> + * followed contiguously by GEILEN guest files at offsets of 1, 2, ..., N pages. >> + * >> + * Because a guest OS running in VS-mode expects its own supervisor-level >> + * interrupt file to be at offset 0 of its guest-physical IMSIC block, the >> + * hypervisor must use stage-2 address translation to map the vCPU's >> + * guest-physical "supervisor" page (GPA offset 0) to the specific >> + * physical guest file page (SPA offset guest_file_id) on the physical hart. >> + * >> + * Xen pins each vCPU to a pCPU (v->processor) and assigns it a physical > > ... an apparently wrong assumption here: Xen doesn't normally pin vCPU-s. > When a vCPU migrates between pCPU-s, clearly the mapping referencing the > page associated with the old hart needs tearing down again. The word “pin” was incorrect to use here. What I meant is that a vCPU is assigned to a pCPU by scheduler and of course it could be re-scheduled by a scheduler to another pCPU (maybe for NULL scheduler such re-scheduling don't happen...), and after this assignment happens, the IMSIC interrupt file mapping needs to be recalculated. > > That said, since the new mapping will appear at the same GFN, the original > mapping may simply end up being replaced. If such direct replacement is > legitimate to do, maybe this could actually be mentioned here? Yes, the GFN isn’t changed for a vCPU. The plan was for map_regions_p2mt() to simply replace the corresponding PTE for the GFN, which is why imsic_unmap_guest_file() isn’t really needed now. I will re-phrase this paragraph to: * A vCPU runs on the pCPU the scheduler picked for it (v->processor), and * the guest file it is given (guest_file_id, from the vGEIN allocator) * belongs to that very pCPU's IMSIC. A guest_file_id of 0 indicates that no * hardware guest file is selected (matching the architectural behavior where * vGEIN = 0 in the hstatus CSR selects no guest external interrupt source), * requiring the VS-file to be emulated in software. * * Consequently the mapping installed here is only valid as long as the vCPU * stays on that pCPU. When it migrates, a VS-file is acquired on the new * pCPU and mapped at the very same GFN, so the stale mapping needs no * explicit tear-down: it is simply replaced. > >> + * guest file index (guest_file_id) from the vGEIN allocator. A guest_file_id >> + * of 0 indicates that no hardware guest file is selected (matching the >> + * architectural behavior where vGEIN = 0 in the hstatus CSR selects no >> + * guest external interrupt source), requiring the VS-file to be emulated >> + * in software. >> + * >> + * The base guest-physical address advertised to the guest in the device >> + * tree matches offset 0 of the vCPU's virtual IMSIC block. Stage-2 >> + * translation ensures that guest supervisor accesses to this page are >> + * transparently routed to the real hardware VS-file granted to it on >> + * the current pCPU. >> + */ >> +int imsic_map_guest_file(struct vcpu *v, unsigned int vsfile_id) >> +{ >> + int res = 0; >> + struct domain *d = v->domain; >> + unsigned int cpu = v->processor; >> + vaddr_t gaddr = imsic_cfg.base_addr + (IMSIC_MMIO_PAGE_SZ * v->vcpu_id); I just noticed that imsic_cfg.base_addr isn't really good to use here. It should be GUEST_IMSIC_S_BASE instead. >> + paddr_t paddr; >> + unsigned long guest_stride; >> + >> + /* Nothing to map in the case of sw interrupt file. */ >> + if ( !vsfile_id ) >> + return res; >> + >> + guest_stride = vsfile_id * IMSIC_MMIO_PAGE_SZ; > > To me "stride" feels the wrong term here, as there's nothing that repeats. > "offset" likely would be better, assuming the use of this local variable is > really deemed worth it, as it's used ... > >> + paddr = imsic_cfg.msi[cpu].base_addr + imsic_cfg.msi[cpu].offset + >> + guest_stride; > > ... only here. I will apply your suggestion. > >> +#ifdef IMSIC_DEBUG >> + printk("%s: %pv: ga(%#lx) -> pa(%#lx), cpu(%#x), guest_file_id(%d) " >> + "base_addr(%#lx) offset(%#lx)\n", __func__, v, gaddr, paddr, cpu, >> + vsfile_id, imsic_cfg.msi[cpu].base_addr, imsic_cfg.msi[cpu].offset); >> +#endif >> + >> + res = map_regions_p2mt(d, gaddr_to_gfn(gaddr), >> + PFN_DOWN(IMSIC_MMIO_PAGE_SZ), maddr_to_mfn(paddr), >> + arch_dt_passthrough_p2m_type()); >> + if ( res ) >> + printk("%s: Failed to map %#lx to the guest at %#lx\n", >> + __func__, paddr, gaddr); > > I think you mean to use PRIpaddr with paddr_t (oddly enough there's no > PRIgaddr). I’m wondering if it wouldn’t be better to use paddr_t for gaddr as well, since technically it is a guest *physical address*. In that case, PRIpaddr could be used to print both paddr and gaddr variables. Also, could this be the reason why PRIgaddr doesn’t exist? Basically, a GPA could be considered a physical address, while for a GVA there is already PRIvaddr. Thanks! Best regards, Oleksii From xen-devel-bounces@lists.xenproject.org Mon Aug 10 08:53:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 08:53:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387250.1628510 (Exim 4.92) (envelope-from ) id 1wtLku-0001Bp-KD; Mon, 10 Aug 2026 08:53:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387250.1628510; Mon, 10 Aug 2026 08:53:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtLku-0001Bi-HV; Mon, 10 Aug 2026 08:53:12 +0000 Received: by outflank-mailman (input) for mailman id 1387250; Mon, 10 Aug 2026 08:53:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtLks-0001BZ-Jj for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 08:53:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtLks-00EdxF-1d for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 08:53:10 +0000 Received: from mail-lf1-f50.google.com ([209.85.167.50]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1wtLks-001BkH-0e for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 08:53:10 +0000 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5b0f19bea2fso1675167e87.1 for ; Mon, 10 Aug 2026 01:53:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:Cc :To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version; bh=r1aA22qzwxz1bQAx6+Cvagz7egcF6XzF1zJxl+kpU2g=; b=FD5RHpb99RW+ivE3vpPO7FN0/a lj7oRsPzYdXH9zdXGFVIait2s/TtE8+K5S0bebOb36crZjgOW05jEfXT6/mGd7y6Yip/VKfL94TVq XtU1PRpupnw8IJ5lr4typFSxKMJmet/QhzI1M9YXFdzcNN9/fXV/EIBjs0W35f8+1Rj4=; X-Forwarded-Encrypted: i=1; AHgh+Rr+oSphyZLvEIYCmw9YNvT0mADyKGm22t3KXBP7UGQWffdQLJ09kNxara6N1yp01+695XRpg2xudFc=@lists.xenproject.org X-Gm-Message-State: AOJu0YySX8KPtVKx0q3/SMGFz4tj+dUkzDOKwvUVRdFO/El2Ux9MCrDL U132lQeD7llHOXgae28b3V26FROLDjpyljN9w/v2gMglf1PxkYm0T9oHJ+6lLEfgkjXECoKvc1W fIKhT6NaXzJM/i6rzuTnpm3l42IRWEac= X-Received: by 2002:a05:6512:1294:b0:5ae:bd66:553b with SMTP id 2adb3069b0e04-5b3092e3ca5mr2591964e87.38.1786351989102; Mon, 10 Aug 2026 01:53:09 -0700 (PDT) MIME-Version: 1.0 References: <61b9c9fb-3d97-4480-8171-bce986e698a8@suse.com> <31267d9b-022f-48b5-b583-6d9380a22740@suse.com> <0f821f2d-70ea-4616-a82e-73a6fe19829e@suse.com> In-Reply-To: From: George Dunlap Date: Mon, 10 Aug 2026 09:52:56 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mwg3PTOPUZCBTiSB7Si3ubD5yD3n8sM02G1vEYIRJzzj9hrSt2wIjsU7Bc Message-ID: Subject: Re: Dual content (text/plain and text/html) on xen-devel (was Re: Linux PV domU with >1 vCPU never resumes after xl save/restore) To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Cc: Jan Beulich , xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 5, 2026 at 3:03=E2=80=AFPM J=C3=BCrgen Gro=C3=9F wrote: > > On 05.08.26 15:28, Jan Beulich wrote: > > On 05.08.2026 14:15, George Dunlap wrote: > >> You're asking every person who sends an email to xen-devel to remember= to > >> take an action before sending the mail > > > > You're by far not the first one to be asked this; you're the first one = to > > have an issue with being asked, beyond some companies' IT getting in th= e > > way. > To put it differently: there is a statement on the Xen wiki asking to sen= d > only text emails to xen-devel. I'm not the one to ask to relax that rule. > If you want this rule to be dropped, you probably should raise this topic > for discussion. > > IMHO it is fine to question such guidelines, but just saying you don't > believe they make sense and therefor ignoring them, especially after havi= ng > been asked to obey them, is kind of rude. The rule seems ambiguous to me. Here it is for those following along at home [1]: > Please post in plain text (i.e. not HTML), word-wrapped to somewehere aro= und 72 characters. It never says "only". Recall that frequently, mailers are configured to send *only* HTML emails; or, they send HTML emails with plain-text attachments that do not reflect everything in the HTML version of the email (perhaps because people actually use the mark-up to convey information). Given that, the rule could mean two things: 1. Please post at least plain-text, and expect that the plain-text version will be the only one read. Do not post HTML-only, and do not post an email where the plain text is difficult to read (mis-formatted or garbled) or is missing information present in the HTML version. 2. Please post in *only* plain text; mail to xen-devel should contain no HTML attachment whatsoever. Either way, it seems to me like the expectations could be clarified. It looks like I can send plain-text only by selecting it for each individual message. I may try to do that, but knowing the way my brain works, I wouldn't be surprised if I frequently forget. -George [1] https://wiki.xenproject.org/wiki/Asking_Developer_Questions From xen-devel-bounces@lists.xenproject.org Mon Aug 10 09:51:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 09:51:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387270.1628546 (Exim 4.92) (envelope-from ) id 1wtMex-0003P1-CP; Mon, 10 Aug 2026 09:51:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387270.1628546; Mon, 10 Aug 2026 09:51:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMex-0003Oo-92; Mon, 10 Aug 2026 09:51:07 +0000 Received: by outflank-mailman (input) for mailman id 1387270; Mon, 10 Aug 2026 09:51:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMev-00038U-JV for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 09:51:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtMeu-00Ef1f-34; Mon, 10 Aug 2026 09:51:04 +0000 Received: from [217.155.165.12] (helo=localhost.localdomain) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wtMeu-0066Tx-1O; Mon, 10 Aug 2026 09:51:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=sLc17oTn+YSlEdecd+yFeeelQCBxepbt0iFKxuboJsM=; b=WdIje4qxZOspjwdk9yTSKiONQ5 /1cO8SG4QFUpLyMuhoijKzQcyjVSaC5D8xbTb60afH0NVTgfPa4s/cYVFq0UqtAPOBetluqSLR6RB sJgiu/YlcF04cRI6fRrXHG16WiSGm4cUFADAXkS4Zj6GspLGlXVfHAo64ovT+eDuAVh4=; From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v2 3/3] build: add compile_commands.json target Date: Mon, 10 Aug 2026 10:49:45 +0100 Message-ID: <20260810095056.29884-4-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260810095056.29884-1-gwd@xenproject.org> References: <20260810095056.29884-1-gwd@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a convenience target generating the compilation database from a built object tree, alongside the other developer conveniences (tags, cscope, cloc -- the last of which already walks the same .cmd files): make -C xen compile_commands.json The output lands in the object tree root. For an in-tree build, clangd and other consumers discover it there automatically when opening files; for an out-of-tree build, symlink it into the source tree root (consumers search the ancestors of the file being edited). Note the database records the compiler invocations actually used. With a clang build it is consumable by clangd as-is; for a gcc build, clang-based tools may need a small .clangd configuration (CompileFlags: Remove/Add) dropping gcc-only flags. Also add the generated file to .gitignore. Assisted-by: LLM Signed-off-by: George Dunlap --- v2: - Make compile_commands.json a file target forced via FORCE rather than declaring it .PHONY, matching the local idiom and Linux's rule for the same target - Commit message: the target is not phony; cover out-of-tree builds --- .gitignore | 1 + xen/Makefile | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index bfc7bdf043..0aa9b801de 100644 --- a/.gitignore +++ b/.gitignore @@ -192,6 +192,7 @@ xen/arch/*/include/generated xen/build-dir-cppcheck/ xen/common/config_data.S xen/common/config.gz +xen/compile_commands.json xen/cppcheck-htmlreport/ xen/cppcheck-report/ xen/cppcheck-misra.* diff --git a/xen/Makefile b/xen/Makefile index d39bdfdd53..d10c29162f 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -685,6 +685,9 @@ cloc: done; \ done | cloc --list-file=- +compile_commands.json: FORCE + $(PYTHON) $(srctree)/scripts/gen_compile_commands.py -d $(objtree) + # Target used by xen-analysis.sh script to retrieve Xen build system variables export-variable-%: $(info $*=$($*)) -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 09:51:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 09:51:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387268.1628527 (Exim 4.92) (envelope-from ) id 1wtMeu-0002yt-VZ; Mon, 10 Aug 2026 09:51:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387268.1628527; Mon, 10 Aug 2026 09:51:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMeu-0002ym-T2; Mon, 10 Aug 2026 09:51:04 +0000 Received: by outflank-mailman (input) for mailman id 1387268; Mon, 10 Aug 2026 09:51:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMeu-0002yS-46 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 09:51:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtMes-00Ef1R-1B; Mon, 10 Aug 2026 09:51:02 +0000 Received: from [217.155.165.12] (helo=localhost.localdomain) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wtMer-0066Tx-2V; Mon, 10 Aug 2026 09:51:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=Lee8YbDbDbQD/PEEAUhgQiCV3VG2M8ylKmtExRHl+xg=; b=rhhNW8QKc6pgPjBx97lRlSd+06 uTwG8e4Wb8L6wbm3TkCTEMvZOmN6xF9jVdobMxidsjyTnfKoEgstkpUj72mdWvMELH50f/XXrq9kF Pt8eIbh/PncyV6spL/WmZBKxElkk072jRANCLK7Rx36w0eOQZe24nLiLjG1Sm6AT3KU0=; From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v2 1/3] xen/scripts: import gen_compile_commands.py from Linux Date: Mon, 10 Aug 2026 10:49:43 +0100 Message-ID: <20260810095056.29884-2-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260810095056.29884-1-gwd@xenproject.org> References: <20260810095056.29884-1-gwd@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xen's Kbuild-derived build system records the exact command line used to compile each object in ..o.cmd files. That is everything needed to produce a compile_commands.json compilation database, the format clangd and other tooling consume to provide accurate cross-referencing (go to definition, find references, call hierarchy) in LSP-capable editors. Import scripts/clang-tools/gen_compile_commands.py from the Linux kernel, unmodified, so that the provenance of the code is easy to verify (commit 90efe2b9119f, Linux v6.16). As-is the script produces an empty database on a Xen tree, since Xen's compile command lines differ slightly from Linux's; the following patch adapts it. Assisted-by: LLM Signed-off-by: George Dunlap --- xen/scripts/gen_compile_commands.py | 228 ++++++++++++++++++++++++++++ 1 file changed, 228 insertions(+) create mode 100755 xen/scripts/gen_compile_commands.py diff --git a/xen/scripts/gen_compile_commands.py b/xen/scripts/gen_compile_commands.py new file mode 100755 index 0000000000..96e6e46ad1 --- /dev/null +++ b/xen/scripts/gen_compile_commands.py @@ -0,0 +1,228 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) Google LLC, 2018 +# +# Author: Tom Roeder +# +"""A tool for generating compile_commands.json in the Linux kernel.""" + +import argparse +import json +import logging +import os +import re +import subprocess +import sys + +_DEFAULT_OUTPUT = 'compile_commands.json' +_DEFAULT_LOG_LEVEL = 'WARNING' + +_FILENAME_PATTERN = r'^\..*\.cmd$' +_LINE_PATTERN = r'^(saved)?cmd_[^ ]*\.o := (?P.* )(?P[^ ]*\.[cS]) *(;|$)' +_VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] +# The tools/ directory adopts a different build system, and produces .cmd +# files in a different format. Do not support it. +_EXCLUDE_DIRS = ['.git', 'Documentation', 'include', 'tools'] + +def parse_arguments(): + """Sets up and parses command-line arguments. + + Returns: + log_level: A logging level to filter log output. + directory: The work directory where the objects were built. + ar: Command used for parsing .a archives. + output: Where to write the compile-commands JSON file. + paths: The list of files/directories to handle to find .cmd files. + """ + usage = 'Creates a compile_commands.json database from kernel .cmd files' + parser = argparse.ArgumentParser(description=usage) + + directory_help = ('specify the output directory used for the kernel build ' + '(defaults to the working directory)') + parser.add_argument('-d', '--directory', type=str, default='.', + help=directory_help) + + output_help = ('path to the output command database (defaults to ' + + _DEFAULT_OUTPUT + ')') + parser.add_argument('-o', '--output', type=str, default=_DEFAULT_OUTPUT, + help=output_help) + + log_level_help = ('the level of log messages to produce (defaults to ' + + _DEFAULT_LOG_LEVEL + ')') + parser.add_argument('--log_level', choices=_VALID_LOG_LEVELS, + default=_DEFAULT_LOG_LEVEL, help=log_level_help) + + ar_help = 'command used for parsing .a archives' + parser.add_argument('-a', '--ar', type=str, default='llvm-ar', help=ar_help) + + paths_help = ('directories to search or files to parse ' + '(files should be *.o, *.a, or modules.order). ' + 'If nothing is specified, the current directory is searched') + parser.add_argument('paths', type=str, nargs='*', help=paths_help) + + args = parser.parse_args() + + return (args.log_level, + os.path.realpath(args.directory), + args.output, + args.ar, + args.paths if len(args.paths) > 0 else [args.directory]) + + +def cmdfiles_in_dir(directory): + """Generate the iterator of .cmd files found under the directory. + + Walk under the given directory, and yield every .cmd file found. + + Args: + directory: The directory to search for .cmd files. + + Yields: + The path to a .cmd file. + """ + + filename_matcher = re.compile(_FILENAME_PATTERN) + exclude_dirs = [ os.path.join(directory, d) for d in _EXCLUDE_DIRS ] + + for dirpath, dirnames, filenames in os.walk(directory, topdown=True): + # Prune unwanted directories. + if dirpath in exclude_dirs: + dirnames[:] = [] + continue + + for filename in filenames: + if filename_matcher.match(filename): + yield os.path.join(dirpath, filename) + + +def to_cmdfile(path): + """Return the path of .cmd file used for the given build artifact + + Args: + Path: file path + + Returns: + The path to .cmd file + """ + dir, base = os.path.split(path) + return os.path.join(dir, '.' + base + '.cmd') + + +def cmdfiles_for_a(archive, ar): + """Generate the iterator of .cmd files associated with the archive. + + Parse the given archive, and yield every .cmd file used to build it. + + Args: + archive: The archive to parse + + Yields: + The path to every .cmd file found + """ + for obj in subprocess.check_output([ar, '-t', archive]).decode().split(): + yield to_cmdfile(obj) + + +def cmdfiles_for_modorder(modorder): + """Generate the iterator of .cmd files associated with the modules.order. + + Parse the given modules.order, and yield every .cmd file used to build the + contained modules. + + Args: + modorder: The modules.order file to parse + + Yields: + The path to every .cmd file found + """ + with open(modorder) as f: + for line in f: + obj = line.rstrip() + base, ext = os.path.splitext(obj) + if ext != '.o': + sys.exit('{}: module path must end with .o'.format(obj)) + mod = base + '.mod' + # Read from *.mod, to get a list of objects that compose the module. + with open(mod) as m: + for mod_line in m: + yield to_cmdfile(mod_line.rstrip()) + + +def process_line(root_directory, command_prefix, file_path): + """Extracts information from a .cmd line and creates an entry from it. + + Args: + root_directory: The directory that was searched for .cmd files. Usually + used directly in the "directory" entry in compile_commands.json. + command_prefix: The extracted command line, up to the last element. + file_path: The .c file from the end of the extracted command. + Usually relative to root_directory, but sometimes absolute. + + Returns: + An entry to append to compile_commands. + + Raises: + ValueError: Could not find the extracted file based on file_path and + root_directory or file_directory. + """ + # The .cmd files are intended to be included directly by Make, so they + # escape the pound sign '#' as '$(pound)'. The compile_commands.json file + # is not interepreted by Make, so this code replaces the escaped version + # with '#'. + prefix = command_prefix.replace('$(pound)', '#') + + # Return the canonical path, eliminating any symbolic links encountered in the path. + abs_path = os.path.realpath(os.path.join(root_directory, file_path)) + if not os.path.exists(abs_path): + raise ValueError('File %s not found' % abs_path) + return { + 'directory': root_directory, + 'file': abs_path, + 'command': prefix + file_path, + } + + +def main(): + """Walks through the directory and finds and parses .cmd files.""" + log_level, directory, output, ar, paths = parse_arguments() + + level = getattr(logging, log_level) + logging.basicConfig(format='%(levelname)s: %(message)s', level=level) + + line_matcher = re.compile(_LINE_PATTERN) + + compile_commands = [] + + for path in paths: + # If 'path' is a directory, handle all .cmd files under it. + # Otherwise, handle .cmd files associated with the file. + # built-in objects are linked via vmlinux.a + # Modules are listed in modules.order. + if os.path.isdir(path): + cmdfiles = cmdfiles_in_dir(path) + elif path.endswith('.a'): + cmdfiles = cmdfiles_for_a(path, ar) + elif path.endswith('modules.order'): + cmdfiles = cmdfiles_for_modorder(path) + else: + sys.exit('{}: unknown file type'.format(path)) + + for cmdfile in cmdfiles: + with open(cmdfile, 'rt') as f: + result = line_matcher.match(f.readline()) + if result: + try: + entry = process_line(directory, result.group('command_prefix'), + result.group('file_path')) + compile_commands.append(entry) + except ValueError as err: + logging.info('Could not add line from %s: %s', + cmdfile, err) + + with open(output, 'wt') as f: + json.dump(sorted(compile_commands, key=lambda x: x["file"]), f, indent=2, sort_keys=True) + + +if __name__ == '__main__': + main() -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 09:51:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 09:51:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387269.1628537 (Exim 4.92) (envelope-from ) id 1wtMew-0003Bp-66; Mon, 10 Aug 2026 09:51:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387269.1628537; Mon, 10 Aug 2026 09:51:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMew-0003Bi-2w; Mon, 10 Aug 2026 09:51:06 +0000 Received: by outflank-mailman (input) for mailman id 1387269; Mon, 10 Aug 2026 09:51:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMeu-0002ya-H7 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 09:51:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtMet-00Ef1T-21; Mon, 10 Aug 2026 09:51:03 +0000 Received: from [217.155.165.12] (helo=localhost.localdomain) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wtMet-0066Tx-0J; Mon, 10 Aug 2026 09:51:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From; bh=LeEkJR3wDbFHkguioVrXqEE8FwRBWi05Kbj07PLC7cQ=; b=H0+YJe1MKYv4xfnK6X3L3qR+TV MeoyYG7k9NupZWxt2mQDA9UXMVZbsr5hNkvOw13kPfxWgQfCVHyAXdTLKYIhE37qSoBU+wZ6R1xae ttW/9mrJUlm+dQ3s6vxsvTcQTTgmsAoTGYpGFofRTqcynUf8vI8G9C0XJhqTDptI3AyM=; From: George Dunlap To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH v2 2/3] xen/scripts: adapt gen_compile_commands.py to Xen Date: Mon, 10 Aug 2026 10:49:44 +0100 Message-ID: <20260810095056.29884-3-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260810095056.29884-1-gwd@xenproject.org> References: <20260810095056.29884-1-gwd@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Two changes from the Linux original: - Linux's compiler invocations end with the source file ("... -c -o foo.o foo.c"), and the script's line pattern relies on that; Xen's cmd_cc_o_c places "-c $<" before "-o" and "-MQ", so on a Xen object tree the unmodified script matches nothing and produces an empty database. Adjust _LINE_PATTERN to capture the command up to and including "-c" plus the source file, dropping the remainder, which database consumers do not need. - Reword the docstring and help text to refer to Xen. The support for reading object lists from archives and modules.order is unused in Xen but retained to minimise divergence from the original. Assisted-by: LLM Signed-off-by: George Dunlap --- v2: Reword the _LINE_PATTERN comment to describe what the dropped remainder is, rather than commenting on the change relative to Linux. --- xen/scripts/gen_compile_commands.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/xen/scripts/gen_compile_commands.py b/xen/scripts/gen_compile_commands.py index 96e6e46ad1..1c9b05e4dd 100755 --- a/xen/scripts/gen_compile_commands.py +++ b/xen/scripts/gen_compile_commands.py @@ -5,7 +5,7 @@ # # Author: Tom Roeder # -"""A tool for generating compile_commands.json in the Linux kernel.""" +"""A tool for generating compile_commands.json for the Xen hypervisor.""" import argparse import json @@ -19,7 +19,11 @@ _DEFAULT_OUTPUT = 'compile_commands.json' _DEFAULT_LOG_LEVEL = 'WARNING' _FILENAME_PATTERN = r'^\..*\.cmd$' -_LINE_PATTERN = r'^(saved)?cmd_[^ ]*\.o := (?P.* )(?P[^ ]*\.[cS]) *(;|$)' +# Capture the command up to and including "-c" plus the source file, and +# drop the remainder: all that follows the source file is the output +# location and dependency-tracking arguments ("-o ...", "-MQ ..."), which +# database consumers do not need. +_LINE_PATTERN = r'^(saved)?cmd_[^ ]*\.o := (?P.* -c )(?P[^ ]*\.[cS])( .*)?$' _VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] # The tools/ directory adopts a different build system, and produces .cmd # files in a different format. Do not support it. @@ -35,10 +39,10 @@ def parse_arguments(): output: Where to write the compile-commands JSON file. paths: The list of files/directories to handle to find .cmd files. """ - usage = 'Creates a compile_commands.json database from kernel .cmd files' + usage = 'Creates a compile_commands.json database from Xen .cmd files' parser = argparse.ArgumentParser(description=usage) - directory_help = ('specify the output directory used for the kernel build ' + directory_help = ('specify the output directory used for the Xen build ' '(defaults to the working directory)') parser.add_argument('-d', '--directory', type=str, default='.', help=directory_help) -- 2.55.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 09:51:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 09:51:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387267.1628519 (Exim 4.92) (envelope-from ) id 1wtMer-0002lo-N6; Mon, 10 Aug 2026 09:51:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387267.1628519; Mon, 10 Aug 2026 09:51:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMer-0002lh-K6; Mon, 10 Aug 2026 09:51:01 +0000 Received: by outflank-mailman (input) for mailman id 1387267; Mon, 10 Aug 2026 09:51:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMeq-0002lb-Tb for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 09:51:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtMeq-00Ef1C-3A for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 09:51:00 +0000 Received: from [217.155.165.12] (helo=localhost.localdomain) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1wtMeq-0066Tx-1X for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 09:51:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:To:From; bh=x1Sp3yZQN5Q3kV7fZfg+oIULJI60NzjOq6ViWln5I7o=; b=e6n0K73pr/L+zZD0Civ/2UCMPB 8FqMFMjtGFxM1BTedfF+LInuz7cLZhtshkPh+PMfmIVaO+4e6ibJMvMIBYmVuhVW+K0LZtPWkCQIf r/M+d5b6jUWVz1SegN/RlXxTSMbqDBBFO3tyg4E8rdk0a0TRFYubPDwpjODXHODT2MAA=; From: George Dunlap To: xen-devel@lists.xenproject.org Subject: [PATCH v2 0/3] Add compile_commands.json target Date: Mon, 10 Aug 2026 10:49:42 +0100 Message-ID: <20260810095056.29884-1-gwd@xenproject.org> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modern tools like emacs' `eglot` rely on compile_commands.json to gather information about the project. Import the build script from Linux, adapting it to the core Xen binary. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:01:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:01:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387297.1628555 (Exim 4.92) (envelope-from ) id 1wtMoz-0006De-8U; Mon, 10 Aug 2026 10:01:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387297.1628555; Mon, 10 Aug 2026 10:01:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMoz-0006DX-5Z; Mon, 10 Aug 2026 10:01:29 +0000 Received: by outflank-mailman (input) for mailman id 1387297; Mon, 10 Aug 2026 10:01:27 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtMox-0006DR-Da for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:01:27 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtMow-00Dt4l-0w for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:01:26 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a16e-bab6-0a2a0a5309dd-0a2a45018e30-22 for ; Mon, 10 Aug 2026 12:01:25 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a175-5984-0a2a45010019-d155dd2cb803-3 for ; Mon, 10 Aug 2026 12:01:25 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47362928f65so1390297f8f.2 for ; Mon, 10 Aug 2026 03:01:25 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48002145839sm32564405f8f.7.2026.08.10.03.01.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 03:01:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786356085; x=1786960885; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KXQIqdRVAv8DGRTLU1MiBZfEi64arVF7ua5/ksd67b4=; b=dVjJaIM2+gdjvKVMk3ahl5PpWQVmT6hiSh6KB7BgVmKXcc86FBCpcsPxToHdi3beFo Iy4GNslUXEEYVo6D+oWvkPUziinCcGDOO1dPmmp/RqprbRRwVwxmP9Jr2Q6DBQV5uk44 SiyqBIQHFeuVAnDp071MhFpF1Y89wU1e5jd1Tr8fMt3eAzAONvksis7xmcBfCAESSTI0 ZCDXa5yUuNQI+YJZn/+Qzq8gGjY6XnmX1T/bEOlUxi/gaY89czcPI0O7hF6fp0t4/VoT KH3AfYxmxnS0hmug3A55vX16oeGm3d/MXedHQxbfIVeN7G3JqfUqvrI0vJKK0cD7viu9 3a7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786356085; x=1786960885; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KXQIqdRVAv8DGRTLU1MiBZfEi64arVF7ua5/ksd67b4=; b=W27yEKzeHVfBBJwEJAmql18XO3GmrY4lcEdWQkKpMsi+XmKwHB/gyb7ev8Dd+AUhFp HK63gKaQrjwX1KbpSpArYvH5D04PZ06oB/vsmkRsy3+wb6GkW9ii0VqGzYBronh4UUhu xl0cpocWysQNFBWiH/4qnxkhmO5cWQBHvZlLlxfaib0qqBdMaP/IVRDviOp9OnX8VuGX F0UUZFEFzxmEgRtTb/0IZWqT7CWAjVCsRLiBqL0+oZiXbqihQ/qpERqKGGLblpxGDcpL NEEh+JDXFaI0RFzS9W4pbLCfuaStRFXbA6XVSmhPvywCqxyCmLpTzDopgHbi8+qpV6lb YNyQ== X-Forwarded-Encrypted: i=1; AHgh+RqQj6MYV1Kj7W4vr1Lub3a1lU34okqL6O5+Klnk0mJ/hoCXQr7eTbt3dNNHK/jXIkEsqtrOCL9Mpjw=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy4Mr41BDuVmlopKjALyO8j8xZCj81Pa3udt6ah8Dg+R24L1WVo Kv7svPKhjvcqxtFBU5SnLDb/lteZvux/S2WeKrsHaUSRy5fGCPjn95Q3tFMF1Q== X-Gm-Gg: AR+sD11VpJq9wwZx0z72s5kcpS7Yl+40F5u81dkbcNsMpyS4FP7/morShGOo4chhPtc fKfRKZ1EtFIMSAhRT0/sfZrOPt3hBdJh9x3Yd3qYcIKdk86JahUq65f/gdwRrEIlpX0ShkQIom2 YBj+cuxrNdeL/91E+G+d5whRM9sPMFpS8PGInnHgt9xcp4HCowOHT5FgeoO8KXio7Ixsjn1Aw9e HC8BduPZIW30wd8aFkXA8lr59yIcw/ZTuIfVZkrCzriM6+QM3qM12GV3zRKRvXJLPk186SQQ23/ OLDz6+SF0ruLA348OqPCqmdMl7UpkrxdHGoHDR7WXzm7jklsy69OwVLydAxC2+20BavsLoO9xZW 3MqoW2nLvGuc1YnuUSCRASyypniRRlWUfDmF52LptMhcdBAPOOLaUpeBOQRj+3U/Vm5NeB26byz 22Q855Fb7cgeuV0JZg879TT7WY1tObXeFxquCkrLW5J209aT37Bz9c6ll+qUBfPf6jswN+vLkzf vzapaKo7NDCZ97+W2y7dQ6NZm6ACz4yJbx6NbFfjhM= X-Received: by 2002:a05:6000:491e:b0:47d:ee9d:90c8 with SMTP id ffacd0b85a97d-47fec4e2910mr68258764f8f.3.1786356071544; Mon, 10 Aug 2026 03:01:11 -0700 (PDT) Message-ID: <55d800f3-6211-4c18-95b6-8682ecfe3330@gmail.com> Date: Mon, 10 Aug 2026 12:01:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/17] xen/riscv: introduce vCPU AIA initialization To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1786356085-C5540757-6A469E5C/10/73395122804 X-purgate-type: spam X-purgate-size: 4800 On 8/6/26 4:56 PM, Jan Beulich wrote: > On 20.07.2026 18:02, Oleksii Kurochko wrote: >> Introduce vcpu_aia_init() to initialize the AIA-related state needed >> for a vCPU to have a working guest interrupt file. >> >> A guest (VS) interrupt file must be mapped to one of a pCPU's >> hardware interrupt files (if they exist), so the pCPU a vCPU will actually >> run on needs to be known first. arch_vcpu_create() is therefore not a >> suitable place to call vcpu_aia_init(), since the pCPU assigned to a >> vCPU can still change before it is first scheduled. To avoid >> reassigning the VS interrupt file id and remapping it to a different >> pCPU's hardware interrupt file, vcpu_aia_init() will instead be >> called from a later point in the scheduling path (e.g. >> continue_to_new_vcpu()), to be introduced in a follow-up patch. Since >> it will end up being called from a non-__init context, it is not >> itself marked __init. > > If it's called during scheduling, perhaps vcpu_aia_init() simply isn't > an appropriate name, and that issue is then also reflected in a > misleading patch subject?z I also thought about that while working on the IMSIC interrupt file support, but I was thinking of moving it to imsic.c. Regarding the function name, a better name would be vcpu_imsic_hw_vsfile_attach(). Alternatively, we could use a slightly more architectural term, such as HGEI/VGEIN, and call it vcpu_imsic_hgei_attach(). I think I prefer vcpu_imsic_hw_vsfile_attach(). Considering your observation and question, it could also be placed where it will actually be called from continue_new() in the future, so riscv/domain.c might be the right place for it but at the moment I think it will be better to put it in imsic.c closer to other IMSIC functionality. > >> @@ -36,6 +37,35 @@ bool aia_usable(void) >> return _aia_usable; >> } >> >> +void vcpu_aia_init(struct vcpu *v) >> +{ >> + unsigned int new_vsfile_id; >> + int rc; >> + >> + if ( !aia_usable() ) >> + return; >> + >> + new_vsfile_id = vgein_assign(v); I will add here also the check that if new_vsfile_id = 0 then we don't need to map guest file. >> + >> + /* >> + * vgein_assign() returns 0 when no free h/w guest interrupt file is >> + * available (including GEILEN == 0); imsic_map_guest_file() maps nothing >> + * in that case. >> + */ >> + rc = imsic_map_guest_file(v, new_vsfile_id); >> + if ( rc ) >> + { I missed here vgein_release(). >> + /* Can't continue w/o correctly mapped IMSIC interrupt file */ >> + domain_crash(v->domain); >> + return; >> + } >> + >> + vcpu_guest_cpu_user_regs(v)->hstatus |= >> + MASK_INSR(new_vsfile_id, HSTATUS_VGEIN); > > Looks like you're assuming that no other ID was previously stored in that > field. That can't be quite right when the function is called after the > vCPU moved to a different pCPU. I don't use it during the migration process as during migration it is a little bit different sequence of how all of that inside the function is called; I use it only jumping to new vCPU (continue_new_cpu()), where I expect ->hstatus.vgein to be zero because of how the area for the vCPU registers is allocated, via vzalloc(). Probably I should consider to rework that and make it re-usable for both creating/jumping_to_new_vcpu and migration process. > >> --- a/xen/arch/riscv/imsic.c >> +++ b/xen/arch/riscv/imsic.c >> @@ -83,6 +83,19 @@ unsigned int vcpu_guest_file_id(const struct vcpu *v) >> return ACCESS_ONCE(v->arch.vimsic_state->guest_file_id); >> } >> >> +void imsic_update_state(struct vcpu *v, unsigned int guest_file_id) >> +{ >> + unsigned long flags; >> + struct vimsic_state *vimsic_state = v->arch.vimsic_state; >> + unsigned long pcpu = ( !guest_file_id ) ? >> + NR_CPUS : cpuid_to_hartid(v->processor); > > "pcpu" as a name is misleading when what you store is a hart ID. NR_CPUS > then also isn't a suitable sentinel. > Agree. I will store here v->processor and NR_CPUS if s/w interrupt file is used and then use cpuid_to_hartid() when it will be necessary. > Also, style nit: The parentheses aren't really needed around the conditional. > But what's definitely wrong are the blanks immediately inside them. I will deal with that. > >> + write_lock_irqsave(&vimsic_state->vsfile_lock, flags); >> + vimsic_state->guest_file_id = guest_file_id; >> + vimsic_state->vsfile_pcpu = pcpu; > > By implication from the remark above, the field name stored into then also > is misnamed. I think with the suggested changed above here everything will be fine. Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:10:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:10:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387307.1628564 (Exim 4.92) (envelope-from ) id 1wtMxS-0008Bi-5b; Mon, 10 Aug 2026 10:10:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387307.1628564; Mon, 10 Aug 2026 10:10:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMxS-0008Bb-26; Mon, 10 Aug 2026 10:10:14 +0000 Received: by outflank-mailman (input) for mailman id 1387307; Mon, 10 Aug 2026 10:10:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtMxQ-0008BV-P0 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:10:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtMxP-00Ah7v-RK for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:10:12 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a382-bab6-0a2a0a5309dd-0a2a4502d82e-4 for ; Mon, 10 Aug 2026 12:10:11 +0200 Received: from [52.101.65.63] (helo=DU2PR03CU002.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a382-6ca4-0a2a45020019-3465413fe6fa-3 for ; Mon, 10 Aug 2026 12:10:10 +0200 Received: from AS4P191CA0001.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::14) by AS4PR08MB7831.eurprd08.prod.outlook.com (2603:10a6:20b:51b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 10:10:02 +0000 Received: from DB5PEPF00014B90.eurprd02.prod.outlook.com (2603:10a6:20b:5d5:cafe::71) by AS4P191CA0001.outlook.office365.com (2603:10a6:20b:5d5::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 10:10:02 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB5PEPF00014B90.mail.protection.outlook.com (10.167.8.228) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 10:10:02 +0000 Received: from AM6PR08MB3414.eurprd08.prod.outlook.com (2603:10a6:20b:49::10) by GV2PR08MB11418.eurprd08.prod.outlook.com (2603:10a6:150:2c9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 10:09:26 +0000 Received: from AM6PR08MB3414.eurprd08.prod.outlook.com ([fe80::dde8:bf0b:1dc:2a2]) by AM6PR08MB3414.eurprd08.prod.outlook.com ([fe80::dde8:bf0b:1dc:2a2%2]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 10:09:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=S2VIJpv8VwAb5nGpLGZco2CwJBxJrdyYG0R62U+CUHku9g3BmuTtMlMlIalp3nI4J7nE7zlNG9ZnMtfOtlZTFLneApMOEKjlMD7Ql6qnWhXJ5IFseiPtR3Th4DDKJaIdYvVWj+X5pw9qFiTe80e8kNtxtL1olXtIBI3mcZ2ZElrHCmVnqKWUHhryztxnYN0XtDj5KDUStZ/CpJ6yD0+vXzgXcAwh1p1jNY18syNeP+u+6Rf/JgIh83qOelSMLB2jjsipz2iZkbwTgJWDRyaE6sg6dhDLCsQdETz/8GqmSbYDfiWc4ukfs2V7R+KGM1DLVLPyWp1yBhymet1S8Hy/JQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sGHMm995GRpz8U1PURPcj9ORNaGW0JAp4jH7dTCsP5Q=; b=v1zz21/zgnctBGF04WoXuyaVM+n5aAJ7fY9Xa8kNx9OlnPNxnTdtI9JDT7zRBWR/jESJ5pyShmr0RkuG8+nyLXgWakdbtpE2OZVWzZ+eUDTQyRgEFqA3aCf6liib8Hhtfj3vm2AaqDgdCwqXGXm6YlZZ4tAndD3O+JqoGjcLEYi6cXk3oeCc+meBuwwtRzHf6MriVf+TGaj+b1lUnvcmgr69NfqY2+Aar+yk2YHMoJzcW8QcAQnz9B6smEzBJWx9MuUyohXKTF3uwtUk9MHvCgWX99gHiROvfAMFeXf6r9ur7ozd0DQq4BAbt/wBySamT6N9dGd2+/2GoSoA3Hewxg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGHMm995GRpz8U1PURPcj9ORNaGW0JAp4jH7dTCsP5Q=; b=X/TDbJ7ebcrgT+EhFqFMXkZrLW/4YZDc8WqKTw7e75/PXAK8hVBv6C+G4sRbqAlFtYUqJEtd2tPQmUS9T18h/wXtC2aoCPud+bRck2pQq9CYkNqoCovk3ytIAzcRbI1Snb/v7MuNLuEi4ToSBvjeB4IQeWdFklu/yB6MC0uCDmQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lu7ea3NWDFQpIQidj/jgqt5/KcmZz0+/1a76oNtofgRKQtEybTY1fyBCnkJjwDsyW7/qX3L6SuD9Uh5OOHCJZv4AsAKYRa7pqgYV5bpV89zK0ET5xvFNA69JUYBVaBtP0v7tg2VZAyWAiuyhnRXyRJmyI6iJTXkdrK8qzmLAX72W8xQB1C86P44R4flTtnd2wfkhUaNejYRyNyzz7kDmWdH4jUVPDlAovM32wCDcB9FIoKAtzVEOFXG21H0s8vbW8kpr9DkQcw+l1uc4z2ouPB+PKPpQgUkqAgSo7BymZKjTQDr1YQgtlWllUFntTrZaE/f0vUEuw7WNLHE7NfbLKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sGHMm995GRpz8U1PURPcj9ORNaGW0JAp4jH7dTCsP5Q=; b=INpxTaXgNxtQiT573C05qSNgM1vbGnG8XOl2r9kZCWWdSH5g6G1tsg4YtDB2RnlUfjNClceUU3wo9Klb9vEyafV39ILI5xqT1mB40WqPtm3NOuPUzwS5rBds59divY4qpTl7kf1EzwOf8HLDVNq5OTM7M6etkjs2xop/w+dMmKowx8ZP6A7DWAFSqY0QuOdrj5QS8eOgAYJv13UTwNieAv7yjfEIN10iM0PeUyIVFvRpY3+skcHmBU15LSyj0evBb/FYsMgrn8p9G/rw5d2z6CVDr0Xv7YlNJpp1GNZQl4fgnkZvyFgrCH78oR/UhFhwGdFC2APICbt2IEP03StPWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGHMm995GRpz8U1PURPcj9ORNaGW0JAp4jH7dTCsP5Q=; b=X/TDbJ7ebcrgT+EhFqFMXkZrLW/4YZDc8WqKTw7e75/PXAK8hVBv6C+G4sRbqAlFtYUqJEtd2tPQmUS9T18h/wXtC2aoCPud+bRck2pQq9CYkNqoCovk3ytIAzcRbI1Snb/v7MuNLuEi4ToSBvjeB4IQeWdFklu/yB6MC0uCDmQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <52b5066c-64f6-40bb-9bce-365a18f24265@arm.com> Date: Mon, 10 Aug 2026 11:09:24 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 1/9] mm: introduce hw_pte_t for PTE table storage To: Alexander Gordeev References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-2-usama.anjum@arm.com> <3db8233c-3785-444e-b2eb-3e5fc5cb2f17-agordeev@linux.ibm.com> <4a42c498-58ca-46f4-819f-da14cfba154f-agordeev@linux.ibm.com> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: <4a42c498-58ca-46f4-819f-da14cfba154f-agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0541.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::12) To AM6PR08MB3414.eurprd08.prod.outlook.com (2603:10a6:20b:49::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AM6PR08MB3414:EE_|GV2PR08MB11418:EE_|DB5PEPF00014B90:EE_|AS4PR08MB7831:EE_ X-MS-Office365-Filtering-Correlation-Id: 96d6ff17-0376-40a1-bf75-08def6c78b22 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|366016|7416014|1800799024|23010399003|6133799003|4143699003|11063799006|56012099006|10067099003|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: mSQv7AaybVdP8lh1lVFlcXP3kGG1cksbK7NhWTSFCBI3T0vZN0VuY2xwLDoDTGWs3W5PpK1u3qICDytNzKUqK9SDvSv7mOhBGz8mCm/T4p9TZ37PTi68WrHC7SBnCBiKxzCJ1ggOVHo04CZfBzLVji6+kBvSiujrzeh5gmb35+T9IoDVoY8YoaoS6y3IVsR/GNlvmGtl5h83qJwaCQGveRteXDi/EkCuqvbd5zatwi9ASQA/qgf3VrS4W7mHxiqhY/nlY5S2wjkycoMVtJy07vAqhKdVMsdnlL25x/Iwz4DXtgLyS6aJ6fYrNzxhQ3+eeZbR9SXZ64cp+5Kn89v3W3otEbkLRadT3SUQngLaRqNN8wIsqyOU8D4Yz99lvY6ZDxbtPq7pRcf3CTk8/Al5XLIF1V5sHok4sc9I5uDs30xNOq+ymqN4IBv9JdPHOaSs/1do4M34tKTFM41rHL/hmWIhHTdx8kq07vwMPgvnN5p7o+qmmoZSROUn3GPPhVdKXZ/LpJhu+sxmyl/Sx++vGNwaHa6REVMYmcFmZNeFvyZ/Y3jMrZuslEQMs0LbQZ2M5AtlfuTDIL4Je4PJTXc6RkGhF6yffaGrIBjR+RmxDHg5eXT2WqHRIQ6DcoTZIfTUIKxMWJPNuZkweSPQ7vN4An9Dr/hNzavgZ0covaVZmjI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3414.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024)(23010399003)(6133799003)(4143699003)(11063799006)(56012099006)(10067099003)(3023799007)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: opP+uzSVHSCRZK1SnjoVnNSw+fDPOATCeo/EkQ/9TKyIWl0BioAAzSjZhW8oRWRhh0VP/Q1IhuRQUxZSxCsMBYVxG/vcaCq1wzUNu0nQPwwWo+QE2KhmS9+j4egy16LiRS4nTmRLKN+XuBdurSLoP+kaCOoDnMKd3pxwSOThge4lF9ONak39/a4lKk8vojL/Ah1HFZ0d8Go5NuqSGNowzXBjnKGdIXTD/jk32PsEmyqcNbc2TwzdKXhRdNZujBGi+KEGdynA/VP0mrbFbmrciAva+eyNqKFeXEVWYbI8GKT7kDRSysVn0Mgym+JU9ctCXZkrSk7GbR3mC+NkBpOOug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB11418 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B90.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b22ca400-de72-440a-7983-08def6c77506 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|23010399003|82310400026|14060799003|36860700016|35042699022|22082099003|18002099003|56012099006|10067099003|3023799007|11063799006|4143699003|6133799003; X-Microsoft-Antispam-Message-Info: cRrjktM/0DgtNP+E1PYP/0TkmX3sW8qhpY9DcxvRfNeCDy8AXNMKLuDb4jtrpgipjzOzFQliODcOOY4RT92OTAXEaRCQ7E8drxYE9301ePLgTjvbj5KSRwz5uxaT8ET0eGm6NCQdUL4MwmspJAR/K/koXYxEQR8PpkShv+2mLpdO/hvV2vVx5phfc7TjVBx1COc/IpRWuf2G9XfZZks0y1EN2Q34OgU0Am9DiPRHRbT6k1rn9/q6qNa5cEuxA1CBtpe3HM/na9j3mE3HhYOgZLW96Ez7DsV+rlaQV0o5bVbUzSqItNRYQhG7ggz04xHaeOzU7WiE1ZHXzQDL9LHzaOccmv9e29M6u4Lu404ORpzuva9lnkueRswUV+7NHztVd2TdweKlYHqyHaQV32baOQHtWWgOCzxPP/i8y2k1EdqfeVivtE+SUotRzWqX4b+wFKf8TE1x6gs3kJEt1vD0O6iQaetLgtFPOD9lcztBFADSza/1D1T64EPGO/iULK9iV+gQ+WcfsG9Xet7UAWNF4verB7aZ71XjTFFAH10J705ZwKAORUbP9qntrVwLy7R5q2qJXHXiMYH28W9O8rJf8X981Y/FdjlFG7a8rlCqezM9+Vx8/f1ahn1fMI1qpujZx87DZcCRqB+fAUZ9biioHBrXp6PqYCzMzAlkIXMokzwZFfsfSA0aonNvmQ21odrDzgb8d/ug7NM2gwuGhDfScw== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(23010399003)(82310400026)(14060799003)(36860700016)(35042699022)(22082099003)(18002099003)(56012099006)(10067099003)(3023799007)(11063799006)(4143699003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RZu5a05QZ2FkwUV+f3u/xNJ5M977oWBQ8C7GFk7ktc47z+21uudAEAHRHlGSo5AXhoiep89PdJZItSNMVMKzhUWkAzOcbK1aDFW/Mi7N4e8tpvPJlry/aLrtdxgCK6kaQFJRAsOgE/+7N3cXDyiQfUZw+1Gee/0CnYC2dvf05U3qAEsjAQfdrCTHKQKH5tBZy+2KPL7OM2eCxrNi9Gz0AbGh/+NomfeCMStvdy//InA+bHcfFAOJZTvNIE6SEqd15SnoxmQPwOC0MKvmF+jgtvEYJ1/QNCoj4vbau8Q6BterG7888HbRyE6pSP2pgILQsPNbTd+Am8BVwld3VFN6zngsr09c3yxKP3xFmqxE/jdbWplTagyu0d+50/ntJpmFUgC5AEPtB0UZ7gK6HWiys18iUs6JwL3+Gige/sROB32Eq1eo0jD5flZ0SUXOiW8/ X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 10:10:02.5666 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 96d6ff17-0376-40a1-bf75-08def6c78b22 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B90.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7831 X-purgate-ID: tlsNG-720697/1786356610-F04A62AC-69D85AD0/0/0 X-purgate-type: clean X-purgate-size: 3798 On 09/08/2026 6:45 pm, Alexander Gordeev wrote: > On Fri, Aug 07, 2026 at 04:24:00PM +0100, Muhammad Usama Anjum wrote: >> On 07/08/2026 8:09 am, Alexander Gordeev wrote: >>> On Thu, Aug 06, 2026 at 09:38:39AM +0100, Muhammad Usama Anjum wrote: >>>> pte_t is used both for logical PTE values and for entries stored in a PTE >>>> table, so pte_t * does not distinguish a pointer to a copied value from a >>>> pointer to table storage. >>>> >>>> Introduce hw_pte_t as the generic name for a PTE table element. Define it >>>> as a macro alias of pte_t by default. When an architecture selects >>>> ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead. >>>> This preserves the representation while allowing converted architectures >>>> to enforce the distinction at compile time. >>>> >>>> Keep the C type definitions behind an __ASSEMBLY__ check because >>>> architecture assembly sources can include this header indirectly. Include >>>> asm/page.h so consumers such as linux/vmalloc.h retain the page definitions >>>> they previously obtained from that header. >>>> >>>> Signed-off-by: Muhammad Usama Anjum >>>> --- >>>> Changes since RFC v1: >>>> - Add the ARCH_HAS_HW_PTE_T opt-in and generic wrapper definition. >>>> - Exclude the C type definitions from assembly sources. >>>> - Update the description for the new opt-in model. >>>> --- >>>> MAINTAINERS | 1 + >>>> include/linux/pgtable_types.h | 17 +++++++++++++++++ >>>> mm/Kconfig | 3 +++ >>>> 3 files changed, 21 insertions(+) >>>> create mode 100644 include/linux/pgtable_types.h >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index e9c8567308a75..7169bea968cf5 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -16982,6 +16982,7 @@ F: include/linux/mmu_notifier.h >>>> F: include/linux/pagewalk.h >>>> F: include/linux/pgalloc.h >>>> F: include/linux/pgtable.h >>>> +F: include/linux/pgtable_types.h >>>> F: include/linux/ptdump.h >>>> F: include/linux/vmpressure.h >>>> F: include/linux/vmstat.h >>>> diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h >>>> new file mode 100644 >>>> index 0000000000000..70c3edd00a01b >>>> --- /dev/null >>>> +++ b/include/linux/pgtable_types.h >>>> @@ -0,0 +1,17 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>> +#ifndef _LINUX_PGTABLE_TYPES_H >>>> +#define _LINUX_PGTABLE_TYPES_H >>>> + >>>> +#include >>>> + >>>> +#ifndef __ASSEMBLY__ >>>> + >>>> +#ifdef CONFIG_ARCH_HAS_HW_PTE_T >>>> +typedef struct { pte_t __pte; } hw_pte_t; >>> >>> On s390 it fails to compile once we do typedef hw_pte_t *pgtable_t >>> in asm/page.h. m68k, powerpc and sparc may also have such problem. >>> >>> The below declaration helps to resolve it using forward declaration >>> and without meddling with headers, though I do not like it much: >>> >>> typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; >> Thank you for testing it out on s390. >> >> As __hw_pte_t isn't being used yet in this series, would s390 enablement >> patches add __hw_pte_t to this definition? > > I hope there is a better solution. As I noted m68k, powerpc and sparc > may also be affected, so I would suggest to look into those as well. > I would prefer s390 to use the generic one rather than circumvent a > compile error in a custom way. I've just checked all of these architectures by doing dirty conversion and reached to same conclusion that __hw_pte_t must be defined like: typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; I'lll add __hw_pte_t to this series. (Initially on last email I'd thought that the first user would add __hw_pte_t. But it seems sensible to add it now) -- Thanks, Usama From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:20:26 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:20:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387316.1628572 (Exim 4.92) (envelope-from ) id 1wtN7F-0001on-0t; Mon, 10 Aug 2026 10:20:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387316.1628572; Mon, 10 Aug 2026 10:20:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtN7E-0001og-UP; Mon, 10 Aug 2026 10:20:20 +0000 Received: by outflank-mailman (input) for mailman id 1387316; Mon, 10 Aug 2026 10:20:19 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtN7D-0001oZ-6v for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:20:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtN7C-00Dzem-De for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:20:18 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a5cb-8faa-0a2a0a5109dd-0a2a45048b74-34 for ; Mon, 10 Aug 2026 12:20:18 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a5e1-b57f-0a2a45040019-b9ff1c2396d3-3 for ; Mon, 10 Aug 2026 12:20:18 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19feb2ff2f9000e099.002 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 10:20:15 +0000 Received: from [192.168.1.61] (155.223.66.37.rev.sfr.net [37.66.223.155]) (Authenticated sender: ngoc-tu.dinh@vates.tech) by mail2.vates.fr (Postfix) with ESMTPSA id 60F3B81C5E; Mon, 10 Aug 2026 12:20:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=dwh4fyIqqBY7gZ43AJfLXV5jUYa61S3uFDhcudB0Tfk=; h=from:subject:date:message-id:to:mime-version:content-type:in-reply-to:references:feedback-id; b=YGu7j7qiGvDn7d/nUlypyg4U69Pen65i0Y9F1mJzQjg0Igl8Syhv2Y1oYdEicqoWkGVx4uKUt lRTgzYrTwlz7swJRNJTTKQMfDYKBJoHQM0y8HOV+CNtgb/FLGfFLbesI2QREHPwsx3u3gC3/FAa oX5xj+diAH7Gyb7DCH6FSLAGtiXLEqIM7hR4mNFsixDvyQtoMIpLnfi3ZID3JiMeXGKE6qbeRP0 6H1ewuIX8ZfSqp4tNGYvnvx/mGjOdIv38km7p5C9JmMNRIo/eEG8ndciRt8Rltl5WHI0NVwfW6A Zl9hcPcQd+waNuNlhaoaCnjCYmypLsvm0JAQjaAf6RDw== X-Zone-Loop: 3e4d87dda4f87756c6df8b0e14db86ef75f8ee700b9e x-campaign-type: default x-transaction-id: 1d10f385-683d-41bf-a44c-f7a4b66d3af9 x-swg-uid: 01-b4e90962-d767-4f93-96db-19a98ff1c15a X-Mailer: Sweego Message-ID: <1786357216.8631fc262581453bbf619ec5b2062170.19feb2ff2f9000e099@vates.tech> x-swg-bid: 1786357216.8631fc262581453bbf619ec5b2062170.19feb2ff2f9000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Mon, 10 Aug 2026 12:20:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: help Windows PV Drivers and Windows Server 2025 To: "H. Bakker - Hunenet B.V." , "xen-devel@lists.xenproject.org" References: Content-Language: en-US From: Tu Dinh In-Reply-To: X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.1fe4.78f79b667744f805.19feb2ff0d7.9ad1b47bc5e7f8fb=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786357215448 X-purgate-ID: tlsNG-ebf023/1786357218-52ECEB50-8C6F1673/0/0 X-purgate-type: clean X-purgate-size: 1312 ---=Part.1fe4.78f79b667744f805.19feb2ff0d7.9ad1b47bc5e7f8fb=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/08/2026 11:59, H=2E Bakker - Hunenet B=2EV=2E wrote: > This concerns the installation of the Windows PV Drivers on Windows=20 > Server 2025=2E >=20 > When running *"dpinst=2Eexe"*, the installation fails with the message= =20 > *"Install failed"*=2E >=20 > The affected driver version is: > *DriverVer=3D07/13/2023,9=2E1=2E0=2E1* >=20 > I am currently using an older version that works correctly: > *DriverVer=3D12/05/2019,9=2E0=2E0=2E2* >=20 > Kind regards, Henry Bakker=2E >=20 Hello, Looks like you're trying to install the downloads from the Xen Project=20 website (xenbus=2Etar and related)=2E These downloads are not digitally=20 signed, nor are they kept up-to-date with upstream development=2E You can= =20 rebuild the drivers from source repos [1] (requires enabling testsigned=20 mode), or download a signed build from downstream distributions=2E [1] https://xenbits=2Exen=2Eorg/gitweb/?a=3Dproject_list;pf=3Dpvdrivers/wi= n -- Ngoc Tu Dinh | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates = solutions web: https://vates=2Etech ---=Part.1fe4.78f79b667744f805.19feb2ff0d7.9ad1b47bc5e7f8fb=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387324.1628582 (Exim 4.92) (envelope-from ) id 1wtNHE-00041L-TU; Mon, 10 Aug 2026 10:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387324.1628582; Mon, 10 Aug 2026 10:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHE-00041E-Qn; Mon, 10 Aug 2026 10:30:40 +0000 Received: by outflank-mailman (input) for mailman id 1387324; Mon, 10 Aug 2026 10:30:39 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHD-000411-A5 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHC-00DyfU-Bz for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:38 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a842-bab6-0a2a0a5309dd-0a2a4504c9d8-8 for ; Mon, 10 Aug 2026 12:30:38 +0200 Received: from [209.85.128.48] (helo=mail-wm1-f48.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a84e-b57f-0a2a45040019-d1558030e42d-3 for ; Mon, 10 Aug 2026 12:30:38 +0200 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso12486365e9.0 for ; Mon, 10 Aug 2026 03:30:38 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357838; x=1786962638; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0MRp6EbxOKuhWqTL6XGBFd4TDttNHZTC51Obk9EfEk8=; b=XyDVjGAa3f48bZvE+Htj4K9LJd27o2MOr+PnzjgH+eM3CvACnc+m18z18ZlNUpv7S6 1YTcjHdvsffy2QEU/kK4q5u4gGic1qTpzA1cgjcUzO88hiUfWD+bqScJK+8HiGIanW+x kishQga3hBQ4YlOXk3wIJ5K0UTsbj6QXVJOS3F/FhyDKAV1McuGggR2s+3/brSQV6own Oxdmq3k2LGPTKiG57ImAtuebH3Xtf84eaV0OfdJXg+QFBUJKUw1LC19CwSRaeNchLqNP 5YR48i6u+FNu71dTLGByG0X087ctvIZv6EYUWEXfmtTjklv0N5/2s5Z7z2D6VRGTUi/6 73lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357838; x=1786962638; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0MRp6EbxOKuhWqTL6XGBFd4TDttNHZTC51Obk9EfEk8=; b=nyQ6ARqwrHOZOOcJYhqDmM+KQ7GSJ3yIQ1nYPvW/hul1Y47uwkhZiAjLb4QwU/6bnM hcvhRz6x0/84sieCvfRW0VZJ1QyGijLGHHdEdmYTMTDcSikEIUtAMaiAn+sSovZnPiEZ CaH6DggkxGRcrmYCBLVDegZ4VOHsRV3KFy7BDZiG0LK9/fbm9mejd4mlWd5lNBxKdJY3 BiDW8pWK7OTVZ5WtoOM2vWEfiiJffE38GIb8/NiB8JyupwcPwdu1utJsMgdTJ5S14n3V g+kdHgIFAvkZAvSOzW0LDrskEFupHaMAkVdC2gGPlW626Q4khSCqoXCG7uRDeb9vP+L7 szuA== X-Gm-Message-State: AOJu0YxqBXt1hMEVQ7AgJX86SOdqNoNdkOaEgmESy9j8EbmPsRSyzaLk J3AsdSZULoO/yLc+hvuhAnrlHjl5YMs96eRyErPoDlNNdzYR3/C4zdkSgT/XEzCoqEQ= X-Gm-Gg: AR+sD110pFA3YKSNouIQCb6Uqd0v1QppYfRss7xrG77Jum+7NOcL3XavUZ3HiOwvfhj 4dzxjvDyE7sGCpJ2tKi9eaXwP7LpypIvj2N/45ix1NSAsVvlSeYaDCqOaP2iuK9e64EpN3jhJ3p AvTtUD53/a/lUDgom57XWrQmWHDChqVH+/w7e/n0ZKxeHu2AFwNJ+wY/HlEc8dSnRn1pHSFEsCi oFX3xK6UuIgtijPCpkqUyN5PddCGFA/1sSTqATz3KqV9PDMhQDn/NT7bso9p94V5fAYLHbaoKNT mMN0wdUWid9fi9fBBn/nNzb2F5+/mjzcjyp74LDVxTAE7uLgeMvy7werGHaTbDrSno7bHDyz611 iC5kFhx1i04O+PhtTuERFyIHMAwliCu5qR4GxbTQFd8HmXCs0HktI7+0Mo7P2qVPlDqx8CaLzYb uOQb/KMkeLeEbkIJp8QwjQTz1KA0SRvfnlhkbPh0x2IydwGfp5qNPAQ3TFrmBX54vQ+sK3poWnj C97aU1JGsDIVvWEKnjr/dL7AGz3g7tkl0XQ8Czn7TUi2FE4kRA= X-Received: by 2002:a05:600c:4f49:b0:499:4892:e84e with SMTP id 5b1f17b1804b1-4995e0d03a8mr270212795e9.11.1786357837543; Mon, 10 Aug 2026 03:30:37 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: [PATCH v10 0/10] xenguest optimisations Date: Mon, 10 Aug 2026 11:30:03 +0100 Message-ID: <20260810103018.54564-1-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1786357838-530CDB50-1831BAB8/0/0 X-purgate-type: clean X-purgate-size: 3210 Reduce number of allocations sending memory state. Implement and use new Xen and Linux kernel ABI to copy foreign memory. This new ABI allows to replace the expensive map/copy/unmap sequence with a single call. Changes since v1: - add commit to cache up to 4 pages in hypercall; - add other 2 commits reducing chunks passed to write/writev. Changes since v2: - update patches commit prefixes; - add other 2 optisations. Changes since v3: - address some comments; - add patches for foreign copy optimisation. Changes since v4: - added Reviewed-by; - improved commit messages; - other minor fixes, see individual commits. Changes since v5: - avoids potential buffer underflow if nr_pages is 0 calling cache_alloc; - do not overwrite errno if xenforeignmemory_map fails; - lot of changes to "implement new foreign copy hypercall", see specific commit. Changes since v6: - removed merged patch; - keep only optimization commits for now; - improve comments; - merged "fill directly iov structure collapsing them" and moved it; - split "allocate various migration arrays just once"; - add a commit for memory checks using Valgrind. Changes since v7: - removed merged commits; - minor style fixes. Changes since v8: - added Reviewed-by; - remove useless check; - remove useless memset; - initialize variables while declaring them. Changes since v9: - add back commits for foreign copy; - rework page permissions check; - do not limit domain for new hypercall; - add back some memory check using Valgrind and sanitizers; - fixed compatibility for ARM; - minor fixes. Edwin Török (3): libs/call: cache up to 4 pages in hypercall bounce buffers libs/guest: allocate various migration arrays just once libs/guest: use foreign copy API during migration Frediano Ziglio (6): libs/guest: move batch_pfns into a separate structure libs/guest: use Valgrind or sanitizers to detect various buffer overflows libs/guest: add xg_foreignmemory_copy_{from,to} xen: implement new foreign copy hypercall privcmd: Add definition for new Linux privcmd to access new Xen hypercall libs/guest: use new hypercall if available tools/config.h.in | 6 ++ tools/configure | 12 +++ tools/configure.ac | 3 +- tools/include/xen-sys/Linux/privcmd.h | 10 ++ tools/libs/call/buffer.c | 34 ++++-- tools/libs/call/core.c | 3 +- tools/libs/call/private.h | 8 +- tools/libs/ctrl/xc_private.h | 61 ++++++++++- tools/libs/guest/xg_sr_common.c | 86 +++++++++++++++ tools/libs/guest/xg_sr_common.h | 25 ++++- tools/libs/guest/xg_sr_restore.c | 78 +++++++------- tools/libs/guest/xg_sr_save.c | 134 +++++++++++------------ xen/common/memory.c | 149 ++++++++++++++++++++++++++ xen/include/public/memory.h | 45 +++++++- xen/include/xsm/dummy.h | 14 +++ xen/include/xsm/hooks.h | 2 + xen/xsm/flask/hooks.c | 10 ++ 17 files changed, 552 insertions(+), 128 deletions(-) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387325.1628587 (Exim 4.92) (envelope-from ) id 1wtNHF-00043N-4S; Mon, 10 Aug 2026 10:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387325.1628587; Mon, 10 Aug 2026 10:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHF-00042i-0W; Mon, 10 Aug 2026 10:30:41 +0000 Received: by outflank-mailman (input) for mailman id 1387325; Mon, 10 Aug 2026 10:30:40 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHD-000418-UB for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHD-00GuV3-Au for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:39 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a84a-8faa-0a2a0a5109dd-0a2a4505b244-16 for ; Mon, 10 Aug 2026 12:30:39 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a84f-4cb1-0a2a45050019-d1558032e1c9-3 for ; Mon, 10 Aug 2026 12:30:39 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso16345825e9.3 for ; Mon, 10 Aug 2026 03:30:39 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357839; x=1786962639; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wimWBVOYQqwPaXI8zWtV5Ue4b9r9c1tb/eSNhf7mAu8=; b=pMUY2/gLuvqcZpxqSH9bQjQUMiMRz7VNj44/wMATq5FDXfYlUUIHNtcIYMkFnioD7g aTT7jQdzjZTihTKOfEo5Pde+rm00UqxP/T6/VySpfQCWoX4K6Qzn2O9x2BZLzaqZC3LE o2GDwMlUqxmJDBYBGkLxOMhS67xdP3Yr92cBGltYdV30jY4wMiTrqd6RMwafWIpYmhgC QbCjAn1IrLBuL3Sj2Bl3pJGKvcZNsJvOuTenpekm0z+GLT2/eDyfRVEIgJFEvA6t0/+r l53C1HVlx9ekfr58cJ/+vf9Iwl386KtspUwcUzQ9UMYYbPRBhoLPT1gMo2ujAg2ZC0v4 YB+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357839; x=1786962639; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wimWBVOYQqwPaXI8zWtV5Ue4b9r9c1tb/eSNhf7mAu8=; b=OB+K3eIcuyxWNy5hXxSBPTa5HvZRO4xdTQKS0ZumNLvtq3H6LSdwywjghNP5TwinWm shTrgpYsiPBoFP5Yy+2uYh2pQnFJHFBrC4MgpULSflAPDnobXJNQr9CKykfyXTASr8qa +P3jzh0JBxrdMmwQQfFg6NWS1Gay+Dfui03gxNOONBL3kZzFpAzjIadPgS0+x7AM+t/P tZmJ/W5pW/ptP7+wuBIHvV02xU/vzs1w/thrAq1pDWwtY0WgZkafNTvhwPEwALl7cyPf oL4NdBgx7EJEXeppUuyhewiBCSoLsPZRPPIrWwL1cO8boF9ABuNfp1/1JJUV3zyNmyIs zVPQ== X-Gm-Message-State: AOJu0Yz80MEPM5A+eXTfuMOoSkluJ7x7I0HaSViyJSG6dPAhixzQiX7z oRAY0/UFQMVUYP8+kjitNrqb0RSQtPafWrrLVa1PZ7hxztYgKpbWoxgi7qAFjHP8RRs= X-Gm-Gg: AR+sD114K50KmHlnBQk48gKRilgm2Wm66uS171Rf1h2CNmYJa9PpVK/zYZliOswxEQ9 l/bYD8WRLmqVmSCNDDpuyMGWXCkJXXhukzMIoH40CNVCzXaY/AUAUVSVi/7CoF6o+0t9xSZHsFW g6qOf3N5HBsWWlqfLVFiTva2P991QUpWsdtfk7Fq6Pgsx1n2Mt6XPsgblGl9RMB7rt38/fsbEKr TkW7JEp/wFE3pzoWMwQCVUnM3xUXVwzhpd/5ozVe/rU68EFnbkNpqXBz3tLdSd9AZUGzAqe5i7e sW5c1J1PkbD9/kh5dh8br6dubNV7GepIL5cU815WYQbeFj3j53YyUlMbg/akOwksKc0UKVKDmrD DeKkXWxOjAAAtZzK3wMA1JH7uG5RVB6W8lX39f6xB9tx45RoUfGNMOYgeeLbcTWKmO7Glw1srKl 1eiNevzc/ozaUyKqlHSaWCPAVk5xkeMzbnoJp2M1Dwc3mU+uDEKTsb2qeexS9qTeFQs6HgNYGuy 9W6yeV7NTFqkzXwiAFsH1dRkFWF0VJ6QViN7ID+OgwYgRT/Jxza X-Received: by 2002:a05:600c:4715:b0:493:cefc:d113 with SMTP id 5b1f17b1804b1-4996195884bmr212355625e9.5.1786357838544; Mon, 10 Aug 2026 03:30:38 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross , Frediano Ziglio Subject: [PATCH v10 1/10] libs/call: cache up to 4 pages in hypercall bounce buffers Date: Mon, 10 Aug 2026 11:30:04 +0100 Message-ID: <20260810103018.54564-2-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-c201ff/1786357839-F74BC2A1-E42AB6FA/0/0 X-purgate-type: clean X-purgate-size: 5706 From: Edwin Török During migration there are a lot of mmap/munmap calls, because xc_get_pfn_type_batch() exceeds the default hypercall bounce buffer cache size, and needs to allocate every time it is called. munmap() is slow, especially in a PV Dom0 (takes an emulation fault), so is best avoided. Eventually it'd be good if the memory pool from xmalloc_tlsf.c was reused here, but for now make it handle the commonly encountered sizes (so far up to 4 pages). Signed-off-by: Edwin Török Signed-off-by: Frediano Ziglio Reviewed-by: Anthony PERARD --- Changes since v2: - change prefix in subject. Changes since v4: - fix off-by-one bug. Changes since v5: - avoids potential buffer underflow if nr_pages is 0 calling cache_alloc. Changes since v6: - align changes made to cache_alloc to cache_free. Changes since v7: - use "unsigned int" instead of "unsigned". Changes since v8: - added Reviewed-by. --- tools/libs/call/buffer.c | 34 +++++++++++++++++++++++----------- tools/libs/call/core.c | 3 ++- tools/libs/call/private.h | 8 +++++--- 3 files changed, 30 insertions(+), 15 deletions(-) diff --git a/tools/libs/call/buffer.c b/tools/libs/call/buffer.c index 155e4f9d43..b7d00185c4 100644 --- a/tools/libs/call/buffer.c +++ b/tools/libs/call/buffer.c @@ -49,6 +49,9 @@ static void *cache_alloc(xencall_handle *xcall, size_t nr_pages) { void *p = NULL; + if ( nr_pages == 0 ) + return NULL; + cache_lock(xcall); xcall->buffer_total_allocations++; @@ -56,13 +59,13 @@ static void *cache_alloc(xencall_handle *xcall, size_t nr_pages) if ( xcall->buffer_current_allocations > xcall->buffer_maximum_allocations ) xcall->buffer_maximum_allocations = xcall->buffer_current_allocations; - if ( nr_pages > 1 ) + if ( nr_pages > ARRAY_SIZE(xcall->buffer_cache) ) { xcall->buffer_cache_toobig++; } - else if ( xcall->buffer_cache_nr > 0 ) + else if ( xcall->buffer_cache_nr[nr_pages-1] > 0 ) { - p = xcall->buffer_cache[--xcall->buffer_cache_nr]; + p = xcall->buffer_cache[nr_pages-1][--xcall->buffer_cache_nr[nr_pages-1]]; xcall->buffer_cache_hits++; } else @@ -79,15 +82,18 @@ static int cache_free(xencall_handle *xcall, void *p, size_t nr_pages) { int rc = 0; + if ( nr_pages == 0 ) + return 0; + cache_lock(xcall); xcall->buffer_total_releases++; xcall->buffer_current_allocations--; - if ( nr_pages == 1 && - xcall->buffer_cache_nr < BUFFER_CACHE_SIZE ) + if ( nr_pages && nr_pages <= ARRAY_SIZE(xcall->buffer_cache) && + xcall->buffer_cache_nr[nr_pages-1] < BUFFER_CACHE_SIZE ) { - xcall->buffer_cache[xcall->buffer_cache_nr++] = p; + xcall->buffer_cache[nr_pages-1][xcall->buffer_cache_nr[nr_pages-1]++] = p; rc = 1; } @@ -108,17 +114,23 @@ void buffer_release_cache(xencall_handle *xcall) DBGPRINTF("current allocations:%d maximum allocations:%d", xcall->buffer_current_allocations, xcall->buffer_maximum_allocations); - DBGPRINTF("cache current size:%d", - xcall->buffer_cache_nr); + for ( unsigned int i = 0; i < ARRAY_SIZE(xcall->buffer_cache_nr); ++i ) + { + DBGPRINTF("cache current size[%u pages]:%d", i+1, + xcall->buffer_cache_nr[i]); + } DBGPRINTF("cache hits:%d misses:%d toobig:%d", xcall->buffer_cache_hits, xcall->buffer_cache_misses, xcall->buffer_cache_toobig); - while ( xcall->buffer_cache_nr > 0 ) + for ( unsigned int i = 0; i < ARRAY_SIZE(xcall->buffer_cache_nr); ++i ) { - p = xcall->buffer_cache[--xcall->buffer_cache_nr]; - osdep_free_pages(xcall, p, 1); + while ( xcall->buffer_cache_nr[i] > 0 ) + { + p = xcall->buffer_cache[i][--xcall->buffer_cache_nr[i]]; + osdep_free_pages(xcall, p, i + 1); + } } cache_unlock(xcall); diff --git a/tools/libs/call/core.c b/tools/libs/call/core.c index 02c4f8e1ae..dd8877c1a0 100644 --- a/tools/libs/call/core.c +++ b/tools/libs/call/core.c @@ -14,6 +14,7 @@ */ #include +#include #include "private.h" @@ -44,7 +45,7 @@ xencall_handle *xencall_open(xentoollog_logger *logger, unsigned open_flags) xentoolcore__register_active_handle(&xcall->tc_ah); xcall->flags = open_flags; - xcall->buffer_cache_nr = 0; + memset(xcall->buffer_cache_nr, 0, sizeof(xcall->buffer_cache_nr)); xcall->buffer_total_allocations = 0; xcall->buffer_total_releases = 0; diff --git a/tools/libs/call/private.h b/tools/libs/call/private.h index 9c3aa432ef..8e6a208975 100644 --- a/tools/libs/call/private.h +++ b/tools/libs/call/private.h @@ -31,13 +31,15 @@ struct xencall_handle { Xentoolcore__Active_Handle tc_ah; /* - * A simple cache of unused, single page, hypercall buffers + * A simple cache of unused, small, hypercall buffers + * buffer_cache[i]'s size is (i+1) pages * * Protected by a global lock. */ #define BUFFER_CACHE_SIZE 4 - int buffer_cache_nr; - void *buffer_cache[BUFFER_CACHE_SIZE]; +#define BUFFER_CACHE_NRPAGES 4 + int buffer_cache_nr[BUFFER_CACHE_NRPAGES]; + void *buffer_cache[BUFFER_CACHE_NRPAGES][BUFFER_CACHE_SIZE]; /* * Hypercall buffer statistics. All protected by the global -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387327.1628609 (Exim 4.92) (envelope-from ) id 1wtNHI-0004eP-LO; Mon, 10 Aug 2026 10:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387327.1628609; Mon, 10 Aug 2026 10:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHI-0004eF-H9; Mon, 10 Aug 2026 10:30:44 +0000 Received: by outflank-mailman (input) for mailman id 1387327; Mon, 10 Aug 2026 10:30:43 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHH-0004Qx-Cx for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:43 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHG-000B9X-Pv for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:42 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a84d-2eae-0a2a0a5409dd-0a2a450ce5b4-16 for ; Mon, 10 Aug 2026 12:30:42 +0200 Received: from [209.85.128.47] (helo=mail-wm1-f47.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a852-f479-0a2a450c0019-d155802fe454-3 for ; Mon, 10 Aug 2026 12:30:42 +0200 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso12486915e9.0 for ; Mon, 10 Aug 2026 03:30:42 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357842; x=1786962642; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2NxxLpvMxvCVNIhMLzqk93Yy2TTgs6s75lOWPEK4aL8=; b=WWMY34C84Gr2gIQEaxu6lLq5DNlTNwYhWCjGo99tLHoTTAvvrEBhKdpXVAbhAER/dI xShAcUzSH6rwIcYm8/jy0ws8yXx3PHzxsdqcnLu9p6Rb0sJl9/ZlsXwRzaKKOKdODe/4 J9uRIaqeGCwJM8sbY+y7+si3q4684NniBbD+rI5k567JdZnhd3bEkF7Xa6ghzFaLtKCQ tT8WhcB1XQlMhrssCb9KlpBt6P/u9vm3nYM1M7e5wpiSZcZaA4KfkceT1D0cUwKUBsQX 81rDHFTEYpQ5FXn2siLlCQUWryUYDOpzVtczDUlX70JZsJFUW0HTuq10BSELoc7RQsdS 8cuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357842; x=1786962642; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2NxxLpvMxvCVNIhMLzqk93Yy2TTgs6s75lOWPEK4aL8=; b=U7Ob54e4udQPEf4hbQRTlSHgq9WxFYvsq03m0qBkGVFVETVl4Ivo/8qhTQOA6/iVNn NXsuhZD9lxC4+mojFx+Ex/s+nsuYPMBSK2cIYtSWQfEwJN7ZG0V974NK0HIhQzqev7HI nzQ4AtzUAuHYamubwQiBHJZ5M32zL30vy8ADHht9NxRM5l8M5Jb1ghr1YWbSK4e7xkjL CyFqYVIAMIk+wwomy3235oUGmUQKKU9+XZSwTtHx6yjis9MdHFc8/g/4SBosJG0HE4/K 2OG0/PfZjjfr0b7y5DX1ptWw0WJqBPpMw0a0iEttFYkzDDu1YnkPBljW9hXi2EMRr/+k 3MPQ== X-Gm-Message-State: AOJu0YzhzZyR7f75N2MndHdI5Ud08seJEGcnNv9H1zjFOj4tqTPU5QR/ 4b3juZr/SJiP6s/I8wP2KYGCXshnWLGKPbmhIHBddunDTr6ripkibmUxaNtPtC5RRwg= X-Gm-Gg: AR+sD13xEAgsLrqQ2r8yol4nTt/olGWo8B0mM7KXqF5WR1W9ONmPHWLJSS/8lMXVmlF Ptae/Ae/9/Dn2P/t/hIwydTf0VCpyq/PZCF2wPRVMA9x6es2bVLSv1n5mQtIa2yp8bXM2nfzCSG LKmkrIjEJ/b0y+0qWnnT+A3xtrnc5loBoeUHOOhIrj+Mp8SUpHNHjvfC8Dqh+SnkVoOXCCOXLjO XE2/qbTHDt3g8u9oJm42wqzV4oU/rP0AN14GWC2XzNY9OiUwSSVONBEDSo1neeOGK3HioC/odcx 1RCHpCsVLkTbOspK+EHsIF+Q4ViSdVGYhfr9YF53cmIEVCOsCwLbF0f21vxn1vuzwMGFgs6eVMA FnJDinlqHbKshAYE2j5Xo5WKB01LxSV2/+SBPfK1wscaGbQmJqgx2Jv8ep/0na14bWRcU8AogS3 GpKFk6mFUZ7IOIRoqNLuk2HrB482qESPoXKaaFd2wt+CsViwCHMhM1ZcR5jF+iBUWgtHJr5e9zK bLzcwvdlDH6l/ICD0H5jNKheqV97FpGEM+P0aPd X-Received: by 2002:a05:600c:4fcb:b0:495:5890:8f6c with SMTP id 5b1f17b1804b1-4995e084875mr253273375e9.7.1786357841888; Mon, 10 Aug 2026 03:30:41 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross , Frediano Ziglio Subject: [PATCH v10 3/10] libs/guest: allocate various migration arrays just once Date: Mon, 10 Aug 2026 11:30:06 +0100 Message-ID: <20260810103018.54564-4-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1786357842-034D7A5B-FE0536AF/0/0 X-purgate-type: clean X-purgate-size: 4898 From: Edwin Török Allocate these array just once at the start of migration, using the maximum batch size, and free them at the end. Signed-off-by: Edwin Török Signed-off-by: Frediano Ziglio Reviewed-by: Anthony PERARD --- Changes since v2: - change prefix in subject. Changes since v3: - fix comment style Changes since v4: - change order of fields in structure. Changes since v6: - split preparation commit. Changes since v8: - remove useless memset; - initialize variables while declaring them. Changes since v9: - added Reviewed-by. --- tools/libs/guest/xg_sr_common.h | 6 +++++ tools/libs/guest/xg_sr_save.c | 45 ++++++++++++--------------------- 2 files changed, 22 insertions(+), 29 deletions(-) diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index 7574c9f5b6..c07c6db59e 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -246,6 +246,12 @@ struct xc_sr_context struct xc_sr_context_save_buffers { xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; + xen_pfn_t mfns[MAX_BATCH_SIZE]; + xen_pfn_t types[MAX_BATCH_SIZE]; + void *local_pages[MAX_BATCH_SIZE]; + struct iovec iov[MAX_BATCH_SIZE + 2]; /* Headers + data. */ + uint64_t rec_pfns[MAX_BATCH_SIZE]; + int errors[MAX_BATCH_SIZE]; } *buffers; } save; diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 22348db445..6a77e33a47 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -86,15 +86,12 @@ static int write_checkpoint_record(struct xc_sr_context *ctx) static int write_batch(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; - xen_pfn_t *mfns = NULL, *types = NULL; void *guest_mapping = NULL; - void **local_pages = NULL; - int *errors = NULL, rc = -1; + int rc = -1; unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; unsigned int nr_pfns = ctx->save.nr_batch_pfns; void *page, *orig_page; - uint64_t *rec_pfns = NULL; - struct iovec *iov = NULL; int iovcnt = 0; + int iovcnt = 0; xen_pfn_t *const batch_pfns = ctx->save.buffers->batch_pfns; struct { struct xc_sr_rhdr rec; @@ -110,28 +107,21 @@ static int write_batch(struct xc_sr_context *ctx) }, }; - assert(nr_pfns != 0); - assert(nr_pfns <= MAX_BATCH_SIZE); - /* Mfns of the batch pfns. */ - mfns = malloc(nr_pfns * sizeof(*mfns)); + xen_pfn_t *const mfns = ctx->save.buffers->mfns; /* Types of the batch pfns. */ - types = malloc(nr_pfns * sizeof(*types)); + xen_pfn_t *const types = ctx->save.buffers->types; /* Errors from attempting to map the gfns. */ - errors = malloc(nr_pfns * sizeof(*errors)); + int *const errors = ctx->save.buffers->errors; /* Pointers to locally allocated pages. Need freeing. */ - local_pages = calloc(nr_pfns, sizeof(*local_pages)); + void **const local_pages = ctx->save.buffers->local_pages; /* iovec[] for writev(). */ - iov = malloc((nr_pfns + 2) * sizeof(*iov)); + struct iovec *const iov = ctx->save.buffers->iov; /* page_data record PFNs list */ - rec_pfns = malloc(nr_pfns * sizeof(*rec_pfns)); + uint64_t *const rec_pfns = ctx->save.buffers->rec_pfns; - if ( !mfns || !types || !errors || !local_pages || !iov || !rec_pfns ) - { - ERROR("Unable to allocate arrays for a batch of %u pages", - nr_pfns); - goto err; - } + assert(nr_pfns != 0); + assert(nr_pfns <= MAX_BATCH_SIZE); iov[0].iov_base = &hdrs; iov[0].iov_len = sizeof(hdrs); @@ -249,14 +239,11 @@ static int write_batch(struct xc_sr_context *ctx) err: if ( guest_mapping ) xenforeignmemory_unmap(xch->fmem, guest_mapping, nr_pages_mapped); - for ( i = 0; local_pages && i < nr_pfns; ++i ) + for ( i = 0; i < nr_pfns; ++i ) + { free(local_pages[i]); - free(rec_pfns); - free(iov); - free(local_pages); - free(errors); - free(types); - free(mfns); + local_pages[i] = NULL; + } return rc; } @@ -790,8 +777,8 @@ static int setup(struct xc_sr_context *ctx) if ( !ctx->save.buffers || !dirty_bitmap || !ctx->save.deferred_pages ) { - ERROR("Unable to allocate memory for dirty bitmaps, batch pfns and" - " deferred pages"); + ERROR("Unable to allocate memory for dirty bitmaps, deferred pages" + " and various batch buffers"); rc = -1; errno = ENOMEM; goto err; -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387326.1628600 (Exim 4.92) (envelope-from ) id 1wtNHH-0004R7-E0; Mon, 10 Aug 2026 10:30:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387326.1628600; Mon, 10 Aug 2026 10:30:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHH-0004R0-AT; Mon, 10 Aug 2026 10:30:43 +0000 Received: by outflank-mailman (input) for mailman id 1387326; Mon, 10 Aug 2026 10:30:42 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHF-0004A8-UM for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHE-00AlTW-T7 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:40 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a84a-e002-0a2a0a5209dd-0a2a450bb4c2-14 for ; Mon, 10 Aug 2026 12:30:40 +0200 Received: from [209.85.128.49] (helo=mail-wm1-f49.google.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a850-b7e8-0a2a450b0019-d1558031dcd9-3 for ; Mon, 10 Aug 2026 12:30:40 +0200 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4954afac04bso18664995e9.0 for ; Mon, 10 Aug 2026 03:30:40 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357840; x=1786962640; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GVzljfbFKFoNV9C92LIEgW8vPbCFaLYksP7zU4eJtPg=; b=mAuUos2CXlYTXPWJltByqIPNA33B+CgqhMp2167Xx6dyFfepDXvO40fF5An+0q0o+E uz5ssDPs9wHWyjOEuw0W47iT063PE9BajXSY4saCCbn67KO0or2rvSbQJQ0/nmWvEtYu 29x5+3XxesexNMqS1Hlhrw6ivLT41PTv/ZYWqquuyz3xXN3ZyLfkkQCWmXHeqI+kOTuG UoUZB09yML3HC5v0LcswG8hslDVMAhhja4J9qEsXImnRQhvRN3U9c2gCCC/D6MpowiG3 3cVxCL2ngY/gBz5rlntqxpmxVJnQBOO9uPTrIbSIegc4g80J0B0oJPzZHdt6nsLYRAmy r1FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357840; x=1786962640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GVzljfbFKFoNV9C92LIEgW8vPbCFaLYksP7zU4eJtPg=; b=nKglD52EDNS4oY59KtjyIiwDFYVjuHitrDfoS/imn8nWV6O6V1+nMEhU/EDEEj7ALm ZK0VAcOW/gq48pCS1ier5vzBWxBsPSctZp37ru4C4iPCS3O2VxCp8H8CtELny4Q9qleq cW2fC30yQfS1J9dpS7jw+g7QRlohlW85zU99FqrZdbRHrq5VJawzZHgueXg+h7KsvRN0 aqK7qGI3teKPN/IfGJDpLlnh5kwRe0EAJGr82jVvsh3WtBGhZku0YMwdRhHY6b3v1heq JCkZ3EUutgrlRbfTT6tLWIYDDGJlFf2hM7W1Adhtg3FUzQVkdXqP6dBJUMXcwORgomvY pTZQ== X-Gm-Message-State: AOJu0YyWDgjO99Ob7zCEhPbbyI3Pes52LgD7lnsGJYz6G+4rsiGGgHhQ MgM/74PG6m9z5E75hMKZgWdwDreLOwP0/DHa/ePEOlmG6JH4F971mVAVRpCgK6etzQg= X-Gm-Gg: AR+sD13RNGobMQJo3WwOBOMTB3HvYO7+pHv1fR3QB0TyrK6n6qDh+3UtqbSE4Jah4e5 qniKf7rnb248cqvTB8k7Bi2BvZseXROq/iDzLqEHfATrAKu4CQpLWJnAHcwLv6VWFR/WoWJThu9 /7uFcnYmjZ8k7fQKjpC43PJDXIDAvTK+1sjQPPS8JyFEjpSgR32+AD0E9uAetJxGXIxSnQIEcNj wvmnO1/aQ3CkTO6z/5r2mCB+RBvPskwF6fO4+hgRPxEV7dobfyVIIOWik9jfbDksyjKxM6RAXhO PaXFHoPz8Lhe69ZMN2z33uqoCr1p5db9OLp10A0d0+EXi8w+Ratoql/mdljKo8ubhIxZcZrR1GG /7fKfDYCKuAhr6nppLbjqdSQFZsVP4MoE7n2QyC+VFHckCwWKVw0cetiEm1Cv7Djagi714MigSy OCnC7hX7hQ/gJseYZ3U1mkp6akij6ahAibWoXFwPyLaX7l12WzXEfOEjVEEZ10bD4GI6zeTZh+k ZItuQPBeIcBz5mDVUrNkLD4c/9kfAfV2DHvkdIp X-Received: by 2002:a05:600c:3555:b0:499:521d:bff1 with SMTP id 5b1f17b1804b1-4996194e53emr251879455e9.2.1786357840167; Mon, 10 Aug 2026 03:30:40 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: [PATCH v10 2/10] libs/guest: move batch_pfns into a separate structure Date: Mon, 10 Aug 2026 11:30:05 +0100 Message-ID: <20260810103018.54564-3-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-42698a/1786357840-AB0DD9EA-63863286/0/0 X-purgate-type: clean X-purgate-size: 6125 Preparation for a followup patch "libs/guest: allocate various migration arrays just once". Signed-off-by: Frediano Ziglio Reviewed-by: Anthony PERARD --- Changes since v6: - split from "libs/guest: allocate various migration arrays just once". Changes since v7: - initialize "batch_pfns" on declaration. Changes since v8: - remove useless check; - added Reviewed-by. --- tools/libs/guest/xg_sr_common.h | 5 ++++- tools/libs/guest/xg_sr_save.c | 28 ++++++++++++++-------------- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index f1573aefcb..7574c9f5b6 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -239,11 +239,14 @@ struct xc_sr_context struct precopy_stats stats; - xen_pfn_t *batch_pfns; unsigned int nr_batch_pfns; unsigned long *deferred_pages; unsigned long nr_deferred_pages; xc_hypercall_buffer_t dirty_bitmap_hbuf; + struct xc_sr_context_save_buffers + { + xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; + } *buffers; } save; struct /* Restore data. */ diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 84fdbe4140..22348db445 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -75,7 +75,7 @@ static int write_checkpoint_record(struct xc_sr_context *ctx) /* * Writes a batch of memory as a PAGE_DATA record into the stream. The batch - * is constructed in ctx->save.batch_pfns. + * is constructed in ctx->save.buffers->batch_pfns. * * This function: * - gets the types for each pfn in the batch. @@ -95,6 +95,7 @@ static int write_batch(struct xc_sr_context *ctx) void *page, *orig_page; uint64_t *rec_pfns = NULL; struct iovec *iov = NULL; int iovcnt = 0; + xen_pfn_t *const batch_pfns = ctx->save.buffers->batch_pfns; struct { struct xc_sr_rhdr rec; struct xc_sr_rec_page_data_header page_data; @@ -110,6 +111,7 @@ static int write_batch(struct xc_sr_context *ctx) }; assert(nr_pfns != 0); + assert(nr_pfns <= MAX_BATCH_SIZE); /* Mfns of the batch pfns. */ mfns = malloc(nr_pfns * sizeof(*mfns)); @@ -141,13 +143,12 @@ static int write_batch(struct xc_sr_context *ctx) for ( i = 0; i < nr_pfns; ++i ) { - types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, - ctx->save.batch_pfns[i]); + types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, batch_pfns[i]); /* Likely a ballooned page. */ if ( mfns[i] == INVALID_MFN ) { - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); + set_bit(batch_pfns[i], ctx->save.deferred_pages); ++ctx->save.nr_deferred_pages; } } @@ -193,7 +194,7 @@ static int write_batch(struct xc_sr_context *ctx) if ( errors[p] ) { ERROR("Mapping of pfn %#"PRIpfn" (mfn %#"PRIpfn") failed %d", - ctx->save.batch_pfns[i], mfns[p], errors[p]); + batch_pfns[i], mfns[p], errors[p]); goto err; } @@ -207,7 +208,7 @@ static int write_batch(struct xc_sr_context *ctx) { if ( rc == -1 && errno == EAGAIN ) { - set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages); + set_bit(batch_pfns[i], ctx->save.deferred_pages); ++ctx->save.nr_deferred_pages; types[i] = XEN_DOMCTL_PFINFO_XTAB; --nr_pages; @@ -235,7 +236,7 @@ static int write_batch(struct xc_sr_context *ctx) hdrs.rec.length += nr_pages * PAGE_SIZE; for ( i = 0; i < nr_pfns; ++i ) - rec_pfns[i] = ((uint64_t)(types[i]) << 32) | ctx->save.batch_pfns[i]; + rec_pfns[i] = ((uint64_t)(types[i]) << 32) | batch_pfns[i]; if ( writev_exact(ctx->fd, iov, iovcnt) ) { @@ -274,9 +275,9 @@ static int flush_batch(struct xc_sr_context *ctx) if ( !rc ) { - VALGRIND_MAKE_MEM_UNDEFINED(ctx->save.batch_pfns, + VALGRIND_MAKE_MEM_UNDEFINED(ctx->save.buffers->batch_pfns, MAX_BATCH_SIZE * - sizeof(*ctx->save.batch_pfns)); + sizeof(*ctx->save.buffers->batch_pfns)); } return rc; @@ -293,7 +294,7 @@ static int add_to_batch(struct xc_sr_context *ctx, xen_pfn_t pfn) rc = flush_batch(ctx); if ( rc == 0 ) - ctx->save.batch_pfns[ctx->save.nr_batch_pfns++] = pfn; + ctx->save.buffers->batch_pfns[ctx->save.nr_batch_pfns++] = pfn; return rc; } @@ -784,11 +785,10 @@ static int setup(struct xc_sr_context *ctx) dirty_bitmap = xc_hypercall_buffer_alloc_pages( xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); - ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE * - sizeof(*ctx->save.batch_pfns)); ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); + ctx->save.buffers = calloc(1, sizeof(*ctx->save.buffers)); - if ( !ctx->save.batch_pfns || !dirty_bitmap || !ctx->save.deferred_pages ) + if ( !ctx->save.buffers || !dirty_bitmap || !ctx->save.deferred_pages ) { ERROR("Unable to allocate memory for dirty bitmaps, batch pfns and" " deferred pages"); @@ -819,7 +819,7 @@ static void cleanup(struct xc_sr_context *ctx) xc_hypercall_buffer_free_pages(xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); free(ctx->save.deferred_pages); - free(ctx->save.batch_pfns); + free(ctx->save.buffers); } /* -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387328.1628618 (Exim 4.92) (envelope-from ) id 1wtNHK-0004tl-4h; Mon, 10 Aug 2026 10:30:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387328.1628618; Mon, 10 Aug 2026 10:30:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHJ-0004tc-W6; Mon, 10 Aug 2026 10:30:45 +0000 Received: by outflank-mailman (input) for mailman id 1387328; Mon, 10 Aug 2026 10:30:45 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHJ-0004ir-4M for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHI-00Dyin-HR for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:44 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a842-bab6-0a2a0a5309dd-0a2a4504c9d8-22 for ; Mon, 10 Aug 2026 12:30:44 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a854-b57f-0a2a45040019-d155802dd551-3 for ; Mon, 10 Aug 2026 12:30:44 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so10862685e9.1 for ; Mon, 10 Aug 2026 03:30:44 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357843; x=1786962643; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mmYKOwc9TBhHBw9HKQnv11v7wtvX4hGi6xT3sze3LxM=; b=c9eyfgznDHwu2KFRkAc50rBNR8rftgT1J23Rmqp97Z0WRxm+RhDwY4K+l+l8xrh0KU 3wAJTBHeSYDR7lbdOzXKEp6kc+MwZ9Cb8pzvqL2wGJHafopwqyHAPJO4xg+pXlIJsubl oLYNOt8Z7IqNqU5ieODubmMRUCgAI5uNHGHRIvtseOfAKVlV3K0lQcXiApzVQ2mbTRz5 fPAoQKxB+bLAQmTX05YupoK1dBAi8VEAcnTI1MmixNtHEdq+7x6dLdNCrkotcQP8zt0x d0/Zgqs4nOSnjYTA3dLDd3h5taJN31VvraEpvYvqycakpQKwmO+D+vOmgJb/7OitpQez /G4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357843; x=1786962643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mmYKOwc9TBhHBw9HKQnv11v7wtvX4hGi6xT3sze3LxM=; b=eQbLOBpe3qmqiK840BMANpP87LpQOxDhANMOP79RDNOW888qcBWGPD0WtmqYgeyhqU VtkkpqRmY8f/PrHgHyXUG0ixgi61TJC1JtjKH4uDCby8/POaNjrytJPnT31s0vh0OQmv x4aovnk620OtPQi35dVIIbHIFq7AMluEs2RcRWHJKycjKKy7AzTLP490QZPxgbW2Z0YE Gnt2xATrLl3hM5ieB1qBKCMGlZ2r31xW7OdGQACmF4fxdm106a4Sd3M4xIinmlM05Es8 MbuheIvHOSPIEqdLeSUE1gfMM/qwrKJ38h8wcsoSfhKE4VdIZeyI4LD5sEFIfpId6cML Fi2Q== X-Gm-Message-State: AOJu0YwazFJExIbwzBquVb/tz0lWRsommcT/GEouq4yGbYbH7FkBkCjt Fap1xZPvHdRf+jBQIBmmd5rW8CRh/SsgfqfPA/rNGLofCSaRqDHNjB53IOZfkt/94c0= X-Gm-Gg: AR+sD12WBUM0fMkuAJQxxc27YUthk2n0YcsD+ozU5BEMLrwThQOm8bjUV9ctpvKOmQx xUKp76U7IKcH+Ly5OOtyLaTg3NOAk5qDR7Vj6LPBUHt4PKTxe9liJzXSAC9W0G4rOvh67NoV0u7 nMxQP6dohXPMrn1MQYs5qhJ0BRtDDOZxG2Au45OL4Xbk20WrvHD2i2ZJ2U5o013F4Bj/WQDvVNS rse0152W5JHykR2OuhlYNZ7qC+QtJyV/TETbkN4ETMLu/W4wlKIP2RFNDaU9TAroDRGKd4pI7Ua F7uQ+4meHclH+H4vzCLdodelCwPi0U6W7ToUetJGz2DmphxH0RzLUYxG7Qs/1/fjXvUlgCftJgT ks007RO3ufT3uyWv8OvIJnwo5/1v3420Ku8k+x7J48+6FR8LTZUo+++SKFTfa0LRixSypYV3Aq+ gT1fGT+VXt1HTfu4EqzilXArKql1+FYnu0JY0/SN8RkQ7SZqE8+6TyYbPJgHIAjp/JTJa4z03si VmnmKUr37H4T54m1G9NTcGkwOfnPRroruRaxs6v X-Received: by 2002:a05:600c:6298:b0:495:503f:cf9a with SMTP id 5b1f17b1804b1-499619839d6mr196524995e9.9.1786357843492; Mon, 10 Aug 2026 03:30:43 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: [PATCH v10 4/10] libs/guest: use Valgrind or sanitizers to detect various buffer overflows Date: Mon, 10 Aug 2026 11:30:07 +0100 Message-ID: <20260810103018.54564-5-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ebf023/1786357844-C0EDEB50-0D7D9B2F/0/0 X-purgate-type: clean X-purgate-size: 7329 Previously this was done as buffers were allocated separately. Signed-off-by: Frediano Ziglio --- Changes since v9: - add support for sanitizers also; - remove some unneeded check buffers. --- tools/config.h.in | 6 ++++ tools/configure | 12 +++++++ tools/configure.ac | 3 +- tools/libs/ctrl/xc_private.h | 61 +++++++++++++++++++++++++++++++-- tools/libs/guest/xg_sr_common.h | 6 ++++ tools/libs/guest/xg_sr_save.c | 11 ++++++ 6 files changed, 96 insertions(+), 3 deletions(-) diff --git a/tools/config.h.in b/tools/config.h.in index ed0042018d..d51816453b 100644 --- a/tools/config.h.in +++ b/tools/config.h.in @@ -48,6 +48,12 @@ /* ROMBIOS enabled */ #undef HAVE_ROMBIOS +/* Define to 1 if you have the header file. */ +#undef HAVE_SANITIZER_ASAN_INTERFACE_H + +/* Define to 1 if you have the header file. */ +#undef HAVE_SANITIZER_MSAN_INTERFACE_H + /* Define to 1 if you have the header file. */ #undef HAVE_STDINT_H diff --git a/tools/configure b/tools/configure index cd989925ed..94e630665f 100755 --- a/tools/configure +++ b/tools/configure @@ -10203,6 +10203,18 @@ then : printf "%s\n" "#define HAVE_UTMP_H 1" >>confdefs.h fi +ac_fn_c_check_header_compile "$LINENO" "sanitizer/asan_interface.h" "ac_cv_header_sanitizer_asan_interface_h" "$ac_includes_default" +if test "x$ac_cv_header_sanitizer_asan_interface_h" = xyes +then : + printf "%s\n" "#define HAVE_SANITIZER_ASAN_INTERFACE_H 1" >>confdefs.h + +fi +ac_fn_c_check_header_compile "$LINENO" "sanitizer/msan_interface.h" "ac_cv_header_sanitizer_msan_interface_h" "$ac_includes_default" +if test "x$ac_cv_header_sanitizer_msan_interface_h" = xyes +then : + printf "%s\n" "#define HAVE_SANITIZER_MSAN_INTERFACE_H 1" >>confdefs.h + +fi # Check for libnl3 >=3.2.8. If present enable remus network buffering. diff --git a/tools/configure.ac b/tools/configure.ac index 74b9f56025..5346ff6129 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -454,7 +454,8 @@ AC_CHECK_DECLS([fdt_property_u32],,,[#include ]) esac # Checks for header files. -AC_CHECK_HEADERS([yajl/yajl_version.h sys/eventfd.h valgrind/memcheck.h utmp.h]) +AC_CHECK_HEADERS([yajl/yajl_version.h sys/eventfd.h valgrind/memcheck.h \ + utmp.h sanitizer/asan_interface.h sanitizer/msan_interface.h]) # Check for libnl3 >=3.2.8. If present enable remus network buffering. PKG_CHECK_MODULES(LIBNL3, [libnl-3.0 >= 3.2.8 libnl-route-3.0 >= 3.2.8], diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index 8a325c17b0..7803192599 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -42,13 +42,70 @@ #include -#if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) && !defined(__MINIOS__) +#undef XEN_USE_MEM_NOACCESS +#if !defined(NDEBUG) && !defined(__MINIOS__) + +#if !defined(__has_feature) +#define __has_feature(x) 0 +#endif + +#if defined(HAVE_SANITIZER_ASAN_INTERFACE_H) && \ + (__has_feature(address_sanitizer) || defined(__SANITIZE_ADDRESS__)) +#include +#define XEN_USE_MEM_NOACCESS 1 +#elif defined(HAVE_SANITIZER_MSAN_INTERFACE_H) && \ + __has_feature(memory_sanitizer) +#include +#define XEN_USE_MEM_NOACCESS 1 +#endif +#if defined(HAVE_VALGRIND_MEMCHECK_H) /* Compile in Valgrind client requests? */ #include -#else +#define XEN_USE_MEM_NOACCESS 1 +#endif + +#endif + +#if !defined(HAVE_VALGRIND_MEMCHECK_H) || defined(NDEBUG) || defined(__MINIOS__) #define VALGRIND_MAKE_MEM_UNDEFINED(addr, len) /* addr, len */ #endif +#if defined(XEN_USE_MEM_NOACCESS) +#define MEM_NOACCESS_BUFFER(name, size) uint8_t name[size]; +#if defined(HAVE_VALGRIND_MEMCHECK_H) +#define MEM_NOACCESS_INIT_VALGRIND(field) \ + VALGRIND_MAKE_MEM_NOACCESS(field, sizeof(field)) +#else +#define MEM_NOACCESS_INIT_VALGRIND(field) +#endif +#if defined(HAVE_SANITIZER_ASAN_INTERFACE_H) && \ + (__has_feature(address_sanitizer) || defined(__SANITIZE_ADDRESS__)) +#define MEM_NOACCESS_INIT_SANITIZER(field) \ + ASAN_POISON_MEMORY_REGION(field, sizeof(field)) +#else +#define MEM_NOACCESS_INIT_SANITIZER(field) +#endif +#if defined(HAVE_SANITIZER_MSAN_INTERFACE_H) && \ + __has_feature(memory_sanitizer) +#define MEM_UNDEFINED_INIT_SANITIZER(field) \ + __msan_poison(field, sizeof(field)) +#else +#define MEM_UNDEFINED_INIT_SANITIZER(field) +#endif +#define MEM_NOACCESS_INIT(field) do { \ + MEM_NOACCESS_INIT_VALGRIND(field); \ + MEM_NOACCESS_INIT_SANITIZER(field); \ +} while(0) +#define MEM_UNDEFINED_INIT(field) do { \ + VALGRIND_MAKE_MEM_UNDEFINED(field, sizeof(field)); \ + MEM_UNDEFINED_INIT_SANITIZER(field); \ +} while(0) +#else +#define MEM_NOACCESS_BUFFER(name, size) +#define MEM_NOACCESS_INIT(field) do {} while(0) +#define MEM_UNDEFINED_INIT(field) do {} while(0) +#endif + #if defined(__MINIOS__) /* * MiniOS's libc doesn't know about sys/uio.h or writev(). diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index c07c6db59e..020b1a5272 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -246,11 +246,17 @@ struct xc_sr_context struct xc_sr_context_save_buffers { xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; + MEM_NOACCESS_BUFFER(na0, 64); xen_pfn_t mfns[MAX_BATCH_SIZE]; + MEM_NOACCESS_BUFFER(na1, 64); xen_pfn_t types[MAX_BATCH_SIZE]; + MEM_NOACCESS_BUFFER(na2, 64); void *local_pages[MAX_BATCH_SIZE]; + MEM_NOACCESS_BUFFER(na3, 64); struct iovec iov[MAX_BATCH_SIZE + 2]; /* Headers + data. */ + MEM_NOACCESS_BUFFER(na4, 64); uint64_t rec_pfns[MAX_BATCH_SIZE]; + MEM_NOACCESS_BUFFER(na5, 64); int errors[MAX_BATCH_SIZE]; } *buffers; } save; diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 6a77e33a47..96d7e9e2f8 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -123,6 +123,11 @@ static int write_batch(struct xc_sr_context *ctx) assert(nr_pfns != 0); assert(nr_pfns <= MAX_BATCH_SIZE); + MEM_UNDEFINED_INIT(ctx->save.buffers->mfns); + MEM_UNDEFINED_INIT(ctx->save.buffers->types); + MEM_UNDEFINED_INIT(ctx->save.buffers->iov); + MEM_UNDEFINED_INIT(ctx->save.buffers->rec_pfns); + iov[0].iov_base = &hdrs; iov[0].iov_len = sizeof(hdrs); @@ -783,6 +788,12 @@ static int setup(struct xc_sr_context *ctx) errno = ENOMEM; goto err; } + MEM_NOACCESS_INIT(ctx->save.buffers->na0); + MEM_NOACCESS_INIT(ctx->save.buffers->na1); + MEM_NOACCESS_INIT(ctx->save.buffers->na2); + MEM_NOACCESS_INIT(ctx->save.buffers->na3); + MEM_NOACCESS_INIT(ctx->save.buffers->na4); + MEM_NOACCESS_INIT(ctx->save.buffers->na5); rc = 0; -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387329.1628627 (Exim 4.92) (envelope-from ) id 1wtNHL-00058Z-CE; Mon, 10 Aug 2026 10:30:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387329.1628627; Mon, 10 Aug 2026 10:30:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHL-00058O-8P; Mon, 10 Aug 2026 10:30:47 +0000 Received: by outflank-mailman (input) for mailman id 1387329; Mon, 10 Aug 2026 10:30:46 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHJ-0004t8-UU for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHJ-000B9X-Ay for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:45 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a854-2eae-0a2a0a5409dd-0a2a4509bf7e-10 for ; Mon, 10 Aug 2026 12:30:45 +0200 Received: from [209.85.128.46] (helo=mail-wm1-f46.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a855-be1a-0a2a45090019-d155802ec06a-3 for ; Mon, 10 Aug 2026 12:30:45 +0200 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4996f1ee4a4so6106325e9.2 for ; Mon, 10 Aug 2026 03:30:45 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357845; x=1786962645; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DkECl6LDMDGOPn0+PvCj6l9ySrP1BztPa+S0NKPl8lo=; b=XK4ZZmLdPIeRTaxO29DQeKvE5Yq9F2kKDoE/51xEgGvfJCOhc3VQTU2SsUf693ssh3 LWKzwQ5/ARqHDrv/6JIt2VFglMMitk6P6GACT3nmFz/NHxrI0UWpWTmJm9uxF9d7TfqQ H+7EvhagApP6OKFXWJNOP0dxpmXNU8Y6XP09b/6QkKzfI5eks1x+2MQxJCJLpJCIFygF saU1GAgFTaq9QBfcL202wcg6/4Vf85nXDw/zcr7OnmMFHnz/lyazsqyUs5mQlAJTq400 BQP1lz8bjADlFNOsIJ9rfBAhLa8csd3VFRpNrzbyEi09/7+dSBMfH4q5wXFoRImD9rni jXwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357845; x=1786962645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DkECl6LDMDGOPn0+PvCj6l9ySrP1BztPa+S0NKPl8lo=; b=smh4Dds/2tE2EFxDV9SxuowfUvow7zxwImZh+/EEkEpEhKggFxYPysMUsvcBWWHMy1 APpvwp8LiGE10ECBlM+9l9S4LctnaoUCuVN4EYyYP4zHnTbRbOEV0T44MWPnd1bSMrNp B11GDHqss8FeIY4Gtgh/CVyQy7cVob8yez0c+a4MYMhreCi1ly5eiYdNXxwkZgND691k pIaHahjd/VbKXUgGw6DJKaoF87p1W816zotfn2oTSjKr+y8IqpLLg+h909P76lFiF8rA UOiFXPHcqWwfQt/Tyn26CAr7S2IzdH39cw6TZe6BW1ErIfOR3r73swobpHOAxRoytvVn srwA== X-Gm-Message-State: AOJu0YyIRu+n3IiHtAB6wzM5Q4OsziYbEoM14VLijSYUw5PZMO3tGsLJ v3zEJLFalBn05ZluDnb2LK6lDXM9GxzcWIVJoWz8S/sQ2ezrj4K+w4FiDcSC0RpWqXk= X-Gm-Gg: AR+sD10bp/jD1AEj8oWHDVxrLEyn8C8E7QjgnZcAP/Qlxg/UwaInUKk+ekX4r9emFuK s9awuR06gsyyAeTg2Frm/Nkkr9GU32ZaLlimqDyGmtDMnsfkGRhdmvdY8oWkutBz0tMvG9GtAsH W0GLsc8kNf4tuXGYfriZjU0/ivXLrIia48zfz7gMvlu6lcns9Ha1pWB3QJPRDZbZWd887ZWk1IB 0UI1tpVBuvqR6MUeCuCn7GlN63N9q/7AO995krbgT1ufC8yRo4dB9w8uVk1Phd5QQcEMkDSNmN4 KiR3fcXXRF4R9o0kjTjLy5Qgqv1dp02q0Sb2BhXUi6IRE7n3yvVL+CpPdcCymVl4UWpekCskFEA RFq58/cP4ZDfn5GZgwhrIxNTZkzLfKz1zHsBtyCqtUgIJGXTZBPVHAl5UC1t2UsQRUpDDTBZYrY Nuvuj7u+W69lFUfl76NGsxV+ZRVEHM8qzGcoLZsZG4zCoOQ1uU5bbiiyiAKFD8ahscBTph07FMe 1UaYkytL4EG3EMv+koplDndrTaMPMpfxfYXqmRm X-Received: by 2002:a05:600c:3b93:b0:495:6a50:3fb8 with SMTP id 5b1f17b1804b1-499727417c7mr9643525e9.1.1786357844497; Mon, 10 Aug 2026 03:30:44 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: [PATCH v10 5/10] libs/guest: add xg_foreignmemory_copy_{from,to} Date: Mon, 10 Aug 2026 11:30:08 +0100 Message-ID: <20260810103018.54564-6-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1786357845-3A8D9034-D08973B3/0/0 X-purgate-type: clean X-purgate-size: 4001 This change prepare code to use a new "foreign copy" hypercall. The new hypercall will copy memory from/to a foreign domain. The new hypercall can be emulated with a sequence of: - map foreign memory; - copy memory; - unmap foreign memory. The reason to introduce the emulation first is that you can refactor on the emulation without having to introduce the new hypercall. Introducing the hypercall first would make testing more complicated as bugs on the hypercall have to be taken into account and considered. Also it is easier that way to enable or disable new code. For instance you want to test for performance regression (in this case the code emulated should not perform worse). Signed-off-by: Frediano Ziglio --- Changes since v5: - Do not overwrite errno if xenforeignmemory_map fails. Changes since v6: - improve commit message, explain order and changes. --- tools/libs/guest/xg_sr_common.c | 57 +++++++++++++++++++++++++++++++++ tools/libs/guest/xg_sr_common.h | 8 +++++ 2 files changed, 65 insertions(+) diff --git a/tools/libs/guest/xg_sr_common.c b/tools/libs/guest/xg_sr_common.c index 9b2782b5cf..90da21c35f 100644 --- a/tools/libs/guest/xg_sr_common.c +++ b/tools/libs/guest/xg_sr_common.c @@ -156,6 +156,63 @@ static void __attribute__((unused)) build_assertions(void) BUILD_BUG_ON(sizeof(struct xc_sr_rec_hvm_params) != 8); } +enum { + foreigncopy_from, + foreigncopy_to +}; + +static int xg_foreignmemory_copy(xc_interface *xch, domid_t domid, + int dir, size_t nr_pages, void *buffer, + const xen_pfn_t foreign_pfns[nr_pages]) +{ + if ( nr_pages == 0 ) + return 0; + + if ( !buffer || !foreign_pfns ) + { + errno = EINVAL; + return -1; + } + + int err[nr_pages]; + const int prot = (dir == foreigncopy_from) ? PROT_READ : PROT_READ|PROT_WRITE; + + void *p = xenforeignmemory_map(xch->fmem, domid, prot, nr_pages, foreign_pfns, err); + if ( !p ) + return -1; + + for ( size_t n = 0; n < nr_pages; ++n ) + if ( err[n] ) + { + xenforeignmemory_unmap(xch->fmem, p, nr_pages); + errno = -err[n]; + return -1; + } + + if ( dir == foreigncopy_from ) + memcpy(buffer, p, nr_pages * XC_PAGE_SIZE); + else + memcpy(p, buffer, nr_pages * XC_PAGE_SIZE); + + return xenforeignmemory_unmap(xch->fmem, p, nr_pages); +} + +int xg_foreignmemory_copy_from(xc_interface *xch, domid_t dom, + size_t nr_pages, void *dest, + const xen_pfn_t source[nr_pages]) +{ + return xg_foreignmemory_copy(xch, dom, foreigncopy_from, + nr_pages, dest, source); +} + +int xg_foreignmemory_copy_to(xc_interface *xch, domid_t dom, + size_t nr_pages, const xen_pfn_t dest[nr_pages], + const void *source) +{ + return xg_foreignmemory_copy(xch, dom, foreigncopy_to, + nr_pages, (void *) source, dest); +} + /* * Local variables: * mode: C diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index 020b1a5272..50f235ba87 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -556,6 +556,14 @@ static inline bool page_type_has_stream_data(uint32_t type) } } +int xg_foreignmemory_copy_from(xc_interface *xch, domid_t dom, + size_t nr_pages, void *dest, + const xen_pfn_t source[nr_pages]); + +int xg_foreignmemory_copy_to(xc_interface *xch, domid_t dom, + size_t nr_pages, const xen_pfn_t dest[nr_pages], + const void *source); + #endif /* * Local variables: -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387330.1628636 (Exim 4.92) (envelope-from ) id 1wtNHM-0005Nb-Jb; Mon, 10 Aug 2026 10:30:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387330.1628636; Mon, 10 Aug 2026 10:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHM-0005NI-FW; Mon, 10 Aug 2026 10:30:48 +0000 Received: by outflank-mailman (input) for mailman id 1387330; Mon, 10 Aug 2026 10:30:47 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHL-00056B-5W for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:47 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHK-00Dyin-IZ for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:46 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a854-bab6-0a2a0a5309dd-0a2a450799ec-8 for ; Mon, 10 Aug 2026 12:30:46 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a856-b4ea-0a2a45070019-d1558033dd86-3 for ; Mon, 10 Aug 2026 12:30:46 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49802c418b5so16277125e9.1 for ; Mon, 10 Aug 2026 03:30:46 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357846; x=1786962646; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=noFi4Nk2/RkhWge/ysH4KvzMVBLDNZGcIPZ/3WMBXro=; b=Imf5WD3OT3FoiLQZlFAhUwHzfItTrfwcC805OQe8ZgUajU6edQ48oxW1Fp/lfVgGfK qweM9sP1zGrsbgXTalSCme7QTKxTV0IcW0HIHzupvYTAZAQOPq8ikTOPLYM+J6AusguP U+1dN7vFfDumlHhVs8RwAaZc++wxf2V0Y0YQ11RtZjFvId3XePbwPn2sMebNOYXZlkD7 NBepaUPBSB721VMjuGJL+V1u7ZuHTg0QVXqjfLJt6EmCpqt8FkX4N3XPOa4JyOagawoq psE6/XJzxu+dXGJzy8CN2VX79RLp+QIKi0fNncf6WBcxTZiD7T5uqt2mMNk5UTwBFWFD UbGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357846; x=1786962646; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=noFi4Nk2/RkhWge/ysH4KvzMVBLDNZGcIPZ/3WMBXro=; b=bfL7TnJxG2kVKz+iUOkJkJG5IXuXG6lwoL+YhCgQLefxQASALSLUxEZQy3oIxRelRq u7dop67zjyem7dsc/FqvYdwUOP/hP4JjxsFU1WbPJeOBjIAg/xXyREcURSx+FP6SuCg+ 8rg4FJAC66JPrjRVGsIEshY8YeTwaPA/VLY2Z2nROqz6CTCx/9CMwYGLH/AaJ84ASV0K 44w1T1oDCZLqKLELYwJ7UY6qOWuz59bNDz1V64u8IILKFtNWSCfXisetZGNYHoHrAziH AdcY7avMvoD8BnUT18bxvIZOXGBuTKENLXAMOWnYWR5W4uKXzZiVTLXUdSpfqQwvClGA tKxw== X-Gm-Message-State: AOJu0Yx19SGQ/cWTb7+JmUyMs49hgk34uzecIY8k3CPdzwJlcTrJOFiQ 3u8QJDHnB/V01y8Gp9JAWQC121qlynJ7y1CpHB5RkSzI/1lEVc9VZq8w8Z/h1hBvrlI= X-Gm-Gg: AR+sD12WeVVYwl5ZtZG/KZif3EoxcPUp/Owu9vs1dmpdEEmg9ef57g7wH0sKIRaIxCG Ua4mFNUQ1zY+iZ/AAipP+op/DlIZAzmh+itZlF7xfi1ZtrM9jV5HfLGacmt5DioTNap3K3aTSsZ VgjvRPzlKMgrqo+PZGt+X7BSlLf0O2jk+AM5TLQTAz2zq2PuGya8L4SqqpmYk7suBPQc51fHM5X aUbJFBLXBmNrNr/KGTvur21ymH7nRElsQIANCdZn/RMJwEjqcUaHntLKPot39bTkY2KdRL4Kf9+ e345jt/LYg9xAVfYZ508IyYn9qOh2aoeiySI9g0YFVhjuV3H0kGWQyOlYfb+BpRkZzo5DQbIEI+ KKZ4o7btN7r19HCsA01qZ12PdzpKVSBK3na8AAKOdh5vfqaYWwLbBNdchUgFSGgs/6VXVlI7g0A C+3WfTe45Zf2M5O06AzoSyyRCt6ctlc5HkSWy+8FoLDINdtEL7KudvswVy/ODa/IYTYDSmvUKIY AH9ilWkwM4auEZqcvqGvVoNdODgUcQQPySX4HoV X-Received: by 2002:a05:600c:1391:b0:499:4dca:aa4 with SMTP id 5b1f17b1804b1-4996194deb6mr204011195e9.4.1786357845569; Mon, 10 Aug 2026 03:30:45 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross , Frediano Ziglio Subject: [PATCH v10 6/10] libs/guest: use foreign copy API during migration Date: Mon, 10 Aug 2026 11:30:09 +0100 Message-ID: <20260810103018.54564-7-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1786357846-378D1AE4-808F9804/0/0 X-purgate-type: clean X-purgate-size: 13400 From: Edwin Török Use foreign code emulation code provided by previous commit to prepare to use new hypercall. This to make sure there are no regression in both functionality and performance. In particular tested: - HVM VM; - PV VM; - verification code. Migration times did not change. Signed-off-by: Edwin Török Signed-off-by: Frediano Ziglio --- Changes since v6: - merge with "finalize PoC" to remove the PoC; - remove statistics, old and not clear at all how they were made; - describe tests made. --- tools/libs/guest/xg_sr_common.h | 4 +- tools/libs/guest/xg_sr_restore.c | 78 +++++++++++++++++--------------- tools/libs/guest/xg_sr_save.c | 62 +++++++++++-------------- 3 files changed, 71 insertions(+), 73 deletions(-) diff --git a/tools/libs/guest/xg_sr_common.h b/tools/libs/guest/xg_sr_common.h index 50f235ba87..ec3435790a 100644 --- a/tools/libs/guest/xg_sr_common.h +++ b/tools/libs/guest/xg_sr_common.h @@ -243,6 +243,7 @@ struct xc_sr_context unsigned long *deferred_pages; unsigned long nr_deferred_pages; xc_hypercall_buffer_t dirty_bitmap_hbuf; + xc_hypercall_buffer_t dest_buf; struct xc_sr_context_save_buffers { xen_pfn_t batch_pfns[MAX_BATCH_SIZE]; @@ -256,8 +257,6 @@ struct xc_sr_context struct iovec iov[MAX_BATCH_SIZE + 2]; /* Headers + data. */ MEM_NOACCESS_BUFFER(na4, 64); uint64_t rec_pfns[MAX_BATCH_SIZE]; - MEM_NOACCESS_BUFFER(na5, 64); - int errors[MAX_BATCH_SIZE]; } *buffers; } save; @@ -269,6 +268,7 @@ struct xc_sr_context int send_back_fd; unsigned long p2m_size; xc_hypercall_buffer_t dirty_bitmap_hbuf; + xc_hypercall_buffer_t verify_buf; /* From Image Header. */ uint32_t format_version; diff --git a/tools/libs/guest/xg_sr_restore.c b/tools/libs/guest/xg_sr_restore.c index 458eaa5992..af97f3d466 100644 --- a/tools/libs/guest/xg_sr_restore.c +++ b/tools/libs/guest/xg_sr_restore.c @@ -257,16 +257,15 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, { xc_interface *xch = ctx->xch; xen_pfn_t *mfns = malloc(count * sizeof(*mfns)); - int *map_errs = malloc(count * sizeof(*map_errs)); int rc; - void *mapping = NULL, *guest_page = NULL; unsigned int nr_pages = 0; + void *const source = page_data; - if ( !mfns || !map_errs ) + if ( !mfns ) { rc = -1; ERROR("Failed to allocate %zu bytes to process page data", - count * (sizeof(*mfns) + sizeof(*map_errs))); + count * sizeof(*mfns)); goto err; } @@ -294,27 +293,8 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, if ( nr_pages == 0 ) goto done; - mapping = guest_page = xenforeignmemory_map( - xch->fmem, ctx->domid, PROT_READ | PROT_WRITE, - nr_pages, mfns, map_errs); - if ( !mapping ) - { - rc = -1; - PERROR("Unable to map %u mfns for %u pages of data", - nr_pages, count); - goto err; - } - for ( unsigned int i = 0; i < nr_pages; ++i ) { - if ( map_errs[i] ) - { - rc = -1; - ERROR("Mapping pfn %#"PRIpfn" (mfn %#"PRIpfn", type %#"PRIx32") failed with %d", - pfns[i], mfns[i], types[i], map_errs[i]); - goto err; - } - /* Undo page normalisation done by the saver. */ rc = ctx->restore.ops.localise_page(ctx, types[i], page_data); if ( rc ) @@ -324,31 +304,41 @@ static int process_page_data(struct xc_sr_context *ctx, unsigned int count, goto err; } - if ( ctx->restore.verify ) + page_data += PAGE_SIZE; + } + if ( !ctx->restore.verify ) + { + rc = xg_foreignmemory_copy_to(xch, ctx->domid, nr_pages, mfns, source); + if ( rc < 0 ) + goto err; + } + else + { + DECLARE_HYPERCALL_BUFFER_SHADOW(uint8_t, verify_buf, + &ctx->restore.verify_buf); + void *guest_page = verify_buf; + + rc = xg_foreignmemory_copy_from(xch, ctx->domid, nr_pages, verify_buf, mfns); + if ( rc < 0 ) + goto err; + + page_data = source; + for ( unsigned int i = 0; i < nr_pages; ++i ) { /* Verify mode - compare incoming data to what we already have. */ if ( memcmp(guest_page, page_data, PAGE_SIZE) ) ERROR("verify pfn %#"PRIpfn" failed (type %#"PRIx32")", pfns[i], types[i] >> XEN_DOMCTL_PFINFO_LTAB_SHIFT); - } - else - { - /* Regular mode - copy incoming data into place. */ - memcpy(guest_page, page_data, PAGE_SIZE); - } - guest_page += PAGE_SIZE; - page_data += PAGE_SIZE; + guest_page += PAGE_SIZE; + page_data += PAGE_SIZE; + } } done: rc = 0; err: - if ( mapping ) - xenforeignmemory_unmap(xch->fmem, mapping, nr_pages); - - free(map_errs); free(mfns); return rc; @@ -738,6 +728,18 @@ static int setup(struct xc_sr_context *ctx) int rc; DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, &ctx->restore.dirty_bitmap_hbuf); + DECLARE_HYPERCALL_BUFFER_SHADOW(uint8_t, verify_buf, + &ctx->restore.verify_buf); + + verify_buf = xc_hypercall_buffer_alloc_pages( + xch, verify_buf, MAX_BATCH_SIZE); + + if ( !verify_buf ) + { + ERROR("Unable to allocate memory for test buffer"); + rc = -1; + goto err; + } if ( ctx->stream_type == XC_STREAM_COLO ) { @@ -786,6 +788,8 @@ static void cleanup(struct xc_sr_context *ctx) unsigned int i; DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, &ctx->restore.dirty_bitmap_hbuf); + DECLARE_HYPERCALL_BUFFER_SHADOW(uint8_t, verify_buf, + &ctx->restore.verify_buf); for ( i = 0; i < ctx->restore.buffered_rec_num; i++ ) free(ctx->restore.buffered_records[i].data); @@ -794,6 +798,8 @@ static void cleanup(struct xc_sr_context *ctx) xc_hypercall_buffer_free_pages( xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->restore.p2m_size))); + xc_hypercall_buffer_free_pages(xch, verify_buf, MAX_BATCH_SIZE); + free(ctx->restore.buffered_records); free(ctx->restore.populated_pfns); diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c index 96d7e9e2f8..6b381f0219 100644 --- a/tools/libs/guest/xg_sr_save.c +++ b/tools/libs/guest/xg_sr_save.c @@ -86,11 +86,9 @@ static int write_checkpoint_record(struct xc_sr_context *ctx) static int write_batch(struct xc_sr_context *ctx) { xc_interface *xch = ctx->xch; - void *guest_mapping = NULL; int rc = -1; - unsigned int i, p, nr_pages = 0, nr_pages_mapped = 0; + unsigned int i, nr_pages = 0; unsigned int nr_pfns = ctx->save.nr_batch_pfns; - void *page, *orig_page; int iovcnt = 0; xen_pfn_t *const batch_pfns = ctx->save.buffers->batch_pfns; struct { @@ -111,8 +109,6 @@ static int write_batch(struct xc_sr_context *ctx) xen_pfn_t *const mfns = ctx->save.buffers->mfns; /* Types of the batch pfns. */ xen_pfn_t *const types = ctx->save.buffers->types; - /* Errors from attempting to map the gfns. */ - int *const errors = ctx->save.buffers->errors; /* Pointers to locally allocated pages. Need freeing. */ void **const local_pages = ctx->save.buffers->local_pages; /* iovec[] for writev(). */ @@ -170,30 +166,26 @@ static int write_batch(struct xc_sr_context *ctx) mfns[nr_pages++] = mfns[i]; } - if ( nr_pages > 0 ) + if ( nr_pages ) { - guest_mapping = xenforeignmemory_map( - xch->fmem, ctx->domid, PROT_READ, nr_pages, mfns, errors); - if ( !guest_mapping ) + DECLARE_HYPERCALL_BUFFER_SHADOW(uint8_t, dest_buf, + &ctx->save.dest_buf); + + rc = xg_foreignmemory_copy_from(xch, ctx->domid, nr_pages, dest_buf, mfns); + if ( rc < 0 ) { - PERROR("Failed to map guest pages"); + ERROR("xg_foreignmemory_copy_from failed"); goto err; } - nr_pages_mapped = nr_pages; - for ( i = 0, p = 0; i < nr_pfns; ++i ) + for ( unsigned int i = 0, p = 0; i < nr_pfns; ++i ) { + void *page, *orig_page; + if ( !page_type_has_stream_data(types[i]) ) continue; - if ( errors[p] ) - { - ERROR("Mapping of pfn %#"PRIpfn" (mfn %#"PRIpfn") failed %d", - batch_pfns[i], mfns[p], errors[p]); - goto err; - } - - orig_page = page = guest_mapping + (p * PAGE_SIZE); + orig_page = page = dest_buf + (p * PAGE_SIZE); rc = ctx->save.ops.normalise_page(ctx, types[i], &page); if ( orig_page != page ) @@ -201,15 +193,13 @@ static int write_batch(struct xc_sr_context *ctx) if ( rc ) { - if ( rc == -1 && errno == EAGAIN ) - { - set_bit(batch_pfns[i], ctx->save.deferred_pages); - ++ctx->save.nr_deferred_pages; - types[i] = XEN_DOMCTL_PFINFO_XTAB; - --nr_pages; - } - else + if ( rc != -1 || errno != EAGAIN ) goto err; + + set_bit(batch_pfns[i], ctx->save.deferred_pages); + ++ctx->save.nr_deferred_pages; + types[i] = XEN_DOMCTL_PFINFO_XTAB; + --nr_pages; } else if ( iov[iovcnt - 1].iov_base + iov[iovcnt - 1].iov_len != page ) @@ -222,8 +212,6 @@ static int write_batch(struct xc_sr_context *ctx) { iov[iovcnt - 1].iov_len += PAGE_SIZE; } - - rc = -1; ++p; } } @@ -236,14 +224,13 @@ static int write_batch(struct xc_sr_context *ctx) if ( writev_exact(ctx->fd, iov, iovcnt) ) { PERROR("Failed to write page data to stream"); + rc = -1; goto err; } rc = ctx->save.nr_batch_pfns = 0; err: - if ( guest_mapping ) - xenforeignmemory_unmap(xch->fmem, guest_mapping, nr_pages_mapped); for ( i = 0; i < nr_pfns; ++i ) { free(local_pages[i]); @@ -770,17 +757,21 @@ static int setup(struct xc_sr_context *ctx) int rc; DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, &ctx->save.dirty_bitmap_hbuf); + DECLARE_HYPERCALL_BUFFER_SHADOW(uint8_t, dest_buf, + &ctx->save.dest_buf); rc = ctx->save.ops.setup(ctx); if ( rc ) goto err; + dest_buf = xc_hypercall_buffer_alloc_pages( + xch, dest_buf, MAX_BATCH_SIZE); dirty_bitmap = xc_hypercall_buffer_alloc_pages( xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size); ctx->save.buffers = calloc(1, sizeof(*ctx->save.buffers)); - if ( !ctx->save.buffers || !dirty_bitmap || !ctx->save.deferred_pages ) + if ( !ctx->save.buffers || !dirty_bitmap || !ctx->save.deferred_pages || !dest_buf ) { ERROR("Unable to allocate memory for dirty bitmaps, deferred pages" " and various batch buffers"); @@ -793,7 +784,6 @@ static int setup(struct xc_sr_context *ctx) MEM_NOACCESS_INIT(ctx->save.buffers->na2); MEM_NOACCESS_INIT(ctx->save.buffers->na3); MEM_NOACCESS_INIT(ctx->save.buffers->na4); - MEM_NOACCESS_INIT(ctx->save.buffers->na5); rc = 0; @@ -806,7 +796,8 @@ static void cleanup(struct xc_sr_context *ctx) xc_interface *xch = ctx->xch; DECLARE_HYPERCALL_BUFFER_SHADOW(unsigned long, dirty_bitmap, &ctx->save.dirty_bitmap_hbuf); - + DECLARE_HYPERCALL_BUFFER_SHADOW(uint8_t, dest_buf, + &ctx->save.dest_buf); xc_shadow_control(xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_OFF, NULL, 0); @@ -816,6 +807,7 @@ static void cleanup(struct xc_sr_context *ctx) xc_hypercall_buffer_free_pages(xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size))); + xc_hypercall_buffer_free_pages(xch, dest_buf, MAX_BATCH_SIZE); free(ctx->save.deferred_pages); free(ctx->save.buffers); } -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:50 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387331.1628645 (Exim 4.92) (envelope-from ) id 1wtNHN-0005di-Vt; Mon, 10 Aug 2026 10:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387331.1628645; Mon, 10 Aug 2026 10:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHN-0005dR-Si; Mon, 10 Aug 2026 10:30:49 +0000 Received: by outflank-mailman (input) for mailman id 1387331; Mon, 10 Aug 2026 10:30:48 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHM-0005NJ-LC for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:48 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHM-00AlYD-1S for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:48 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a84f-e002-0a2a0a5209dd-0a2a450394e8-34 for ; Mon, 10 Aug 2026 12:30:48 +0200 Received: from [209.85.128.51] (helo=mail-wm1-f51.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a857-fae8-0a2a45030019-d1558033b954-3 for ; Mon, 10 Aug 2026 12:30:47 +0200 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4954a2e73a9so10218785e9.3 for ; Mon, 10 Aug 2026 03:30:47 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357847; x=1786962647; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qkv0EX1DlL9MRRhP+Wk/CTJgzWiZHG9SS1IgseXcsTo=; b=dssgC8bYdRsy1rv6mnHpmk95qopnTHYfBG03RycozOpT7Xmo8dQHhxB4Sl82MMD8Ky SL7nAtNBYvO64eJ8Wt1qRqhU5ylZ/0T9PIM5ZVbIe0qPqRVbfHUqhKxncYSJRrNaihlo 9v3m550Ved+iR0qBsQwToFNObsJ2CDpgnY/2X2a9hRmv05Omh6rTU4ymTtMGwU1nGMwz ylLreFa3surfadgv7cEnSYpIXW5p14mpny2mXs1DodIOw71itLZgmVidYsN+fM2s37K/ L/ACBDLCjUKnZFA4MKbauic9HfS9fKKO0j3uGCRlAXRRdgtQCJwHTEQi7Sa276EHiyqk dQSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357847; x=1786962647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qkv0EX1DlL9MRRhP+Wk/CTJgzWiZHG9SS1IgseXcsTo=; b=dUjd7OW6kr4BH7uGzI12euWAKiRyleMJxRQlElE1/X9oFlnevP7pkjKzn/b6UohWY+ kREO8Tk39mH2zuwsn23LahkgcEE3XxUn2pJ3abjM2rmJxhaoBK49wkJXNNj8/UOeEMtT BvRUA16pxopJePk5Tf0udlLubNxl/EPay75/QeY2rTuKusdsTV61KG6Dq70/MNh1k7r3 2qCt7VHkjQqbSbjv67MqFTW9UrnC/XehxXlIgmqy8n/3tK+t9EFyjl0hJhucU/+9dZJ8 XTuSE928tNz+VfvXaIyJUGUB3AJ8l72iLFik6bTmjjM2fSIoII6N8U1Hqwiqxr4739Ua zTwg== X-Gm-Message-State: AOJu0Yxbfd396HTgZ9Dei6HV0dGyxCccFE0393rBFMqGnlzB+FsOiDCG yMyYJSfZIetHeNkT2NSyIeUmTy9dcAHmikh437yZXjlN4lU2qaDvLiVeQeqQ2T46Mig= X-Gm-Gg: AR+sD10RbCtaaPoqbfSabvQh9WZMXwhuYE0KepEB/FZ+LWAIO8Sxl8ZJrcRBiVM1upM WhUN2jP0Y9jsAxbV7KbFpTZVSr9JUwsVUm5ag6wwTmF8DGWO9xuYPQOfJMVzLKbPEcFKin72s1j sT2uKMD78B0rc0mCAzHDtyi3/Et+K4pe/w41DJduCq13EayJ3CKXwDwJijPLhEsqdOKWtJNl1dZ aZxtTjox4zWeJOQAx5+G+GRYtzLEtYMswz8p1l2T3foSdy2tTtznrFTGjyDlyQISsiUCaln1TEo 4vdxEFFYNd+g4ORzafx/5SRPkvieQtmxMA2cX49I4yIAbY+FwGUChZ7Xiez/ysRv0b3EaDzyW9o W8lRZ6vNnEWAWqHXGkphlYcBb3piQzhzo4dUVvKRSBurOM+Iks6UpcbTKXBDH2yXSeYEkjjLxWS WtOlZo5YvIynE4h6JrCKx2g1J0BtfsZpTojVcuDjc9dDQkGj+bzTvb7VkRPHl7XggVuuARmrabz dia0edVq2QMvMcHedzLF+t6VT4iFMUMGwkeH/P5 X-Received: by 2002:a05:600c:1553:b0:495:5045:39e6 with SMTP id 5b1f17b1804b1-4994e7d3080mr453921205e9.17.1786357847166; Mon, 10 Aug 2026 03:30:47 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross , "Daniel P . Smith" Subject: [PATCH v10 7/10] xen: implement new foreign copy hypercall Date: Mon, 10 Aug 2026 11:30:10 +0100 Message-ID: <20260810103018.54564-8-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1786357847-74C884E9-DCD50404/0/0 X-purgate-type: clean X-purgate-size: 10676 Add a sub hypercall to __HYPERVISOR_memory_op to allow to read/write memory from/to a foreign domain. Extending MMUEXT_COPY_PAGE seems better on first sight but considering that MMUEXT is meant for PV only and trying to change that sub-op this solution is better. Signed-off-by: Frediano Ziglio --- Changes since v4: - Fix typo in comment. Changes since v5: - update xen_foreigncopy structure comments; - move check for no frames after checking the domain; - use mnemonic instead of 1U; - fix page type checks; - do not overwrite error copying back structure; - latch MFN value; - improved commit message. Changes since v6: - check permissions before nr_frames; - different flag for read or write; - print error as negative for coherence; - update some comments; - different page types for different architectures. Changes since v9: - page permission checks like MMU_UPDATE; - new XSM settings; - do not restrict domain; - different explanation why HVM guests are not supported. --- xen/common/memory.c | 149 ++++++++++++++++++++++++++++++++++++ xen/include/public/memory.h | 45 ++++++++++- xen/include/xsm/dummy.h | 14 ++++ xen/include/xsm/hooks.h | 2 + xen/xsm/flask/hooks.c | 10 +++ 5 files changed, 219 insertions(+), 1 deletion(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index 9443e35a7f..29a70d99b1 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1548,6 +1548,141 @@ static int acquire_resource( return rc; } +/* + * The "noinline" qualifier avoids the compiler to create a large function + * consuming quite a lot of stack. + */ +static int noinline mem_foreigncopy( + XEN_GUEST_HANDLE_PARAM(xen_foreigncopy_t) arg) +{ + struct domain *d, *const currd = current->domain; + xen_foreigncopy_t copy; + int rc, direction; + + if ( copy_from_guest(©, arg, 1) ) + return -EFAULT; + + if ( copy.flags & ~XENMEM_foreigncopy_direction ) + return -EINVAL; + + direction = copy.flags & XENMEM_foreigncopy_direction; + + d = rcu_lock_domain_by_any_id(copy.domid); + if ( !d ) + return -ESRCH; + + /* + * Check we are allowed to map and access these foreign pages. + */ + if ( direction == XENMEM_foreigncopy_from ) + rc = xsm_foreigncopy_from(XSM_TARGET, currd, d); + else + rc = xsm_foreigncopy_to(XSM_TARGET, currd, d); + if ( rc ) + goto out; + + while ( copy.nr_frames ) + { + /* + * Arbitrary size. Not too much stack space, and a reasonable stride + * for continuation checks. + */ + xen_pfn_t gfn_list[32]; + unsigned int todo = MIN(ARRAY_SIZE(gfn_list), copy.nr_frames); + + rc = -EFAULT; + if ( copy_from_guest(gfn_list, copy.frame_list, todo) ) + goto out; + + for ( unsigned int i = 0; i < todo; i++ ) + { + struct page_info *foreign_page; + mfn_t foreign_mfn; + void *foreign; + p2m_type_t p2mt; + p2m_query_t q = (direction == XENMEM_foreigncopy_to) ? + P2M_ALLOC | P2M_UNSHARE : P2M_ALLOC; + + foreign_page = get_page_from_gfn(d, gfn_list[i], &p2mt, q); + + if ( unlikely(p2m_is_paged(p2mt)) ) + { + if ( foreign_page ) + put_page(foreign_page); + p2m_mem_paging_populate(d, _gfn(gfn_list[i])); + p2mt = p2m_ram_paging_in; + foreign_page = NULL; + } + + if ( unlikely(!foreign_page) ) + { + rc = -ENOENT; + if ( p2mt != p2m_ram_paging_in ) + { + gdprintk(XENLOG_WARNING, + "Error accessing foreign gfn %" PRI_gfn "\n", + gfn_list[i]); + rc = -EINVAL; + } + copy.nr_frames -= i; + guest_handle_add_offset(copy.frame_list, i); + goto out; + } + + foreign_mfn = page_to_mfn(foreign_page); + + /* A page is dirtied when it's being copied to. */ + if ( direction == XENMEM_foreigncopy_to ) + paging_mark_dirty(d, foreign_mfn); + + foreign = map_domain_page(foreign_mfn); + if ( direction == XENMEM_foreigncopy_from ) + rc = copy_to_guest(copy.buffer, foreign, PAGE_SIZE); + else + rc = copy_from_guest(foreign, copy.buffer, PAGE_SIZE); + unmap_domain_page(foreign); + put_page(foreign_page); + + if ( unlikely(rc) ) + { + gdprintk(XENLOG_WARNING, + "Error %d copying gfn %" PRI_gfn "\n", + rc, gfn_list[i]); + copy.nr_frames -= i; + guest_handle_add_offset(copy.frame_list, i); + goto out; + } + + guest_handle_add_offset(copy.buffer, PAGE_SIZE); + } + + copy.nr_frames -= todo; + guest_handle_add_offset(copy.frame_list, todo); + + if ( copy.nr_frames && hypercall_preempt_check() ) + { + rc = hypercall_create_continuation( + __HYPERVISOR_memory_op, "lh", XENMEM_foreigncopy, arg); + goto out; + } + } + + rc = 0; + + out: + rcu_unlock_domain(d); + + /* + * Update in all cases, it allows the caller to know how many + * frames were successfully copied and the continuation to + * continue correctly. + */ + if ( __copy_to_guest(arg, ©, 1) && rc >= 0 ) + rc = -EFAULT; + + return rc; +} + long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { struct domain *d, *curr_d = current->domain; @@ -2027,6 +2162,20 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) start_extent); break; + case XENMEM_foreigncopy: + /* + * Instead of using "start_extent" for the continuation, we update + * the xen_foreigncopy structure back, so we are not constrained by + * MEMOP_EXTENT_SHIFT. + * We copy it back also to tell the caller where the copy stopped + * (either for error or because all frames were copied). + */ + if ( unlikely(start_extent) ) + return -EINVAL; + + rc = mem_foreigncopy(guest_handle_cast(arg, xen_foreigncopy_t)); + break; + default: rc = arch_memory_op(cmd, arg); break; diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h index bd9fc37b52..66bd2a6c42 100644 --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -740,7 +740,50 @@ struct xen_vnuma_topology_info { typedef struct xen_vnuma_topology_info xen_vnuma_topology_info_t; DEFINE_XEN_GUEST_HANDLE(xen_vnuma_topology_info_t); -/* Next available subop number is 29 */ +/* + * Copy memory from/to a given domain. + * This calls is meant to replace expensive operations during migration which + * are only supported for PV guests. + */ +#define XENMEM_foreigncopy 29 +struct xen_foreigncopy { + /* IN - The domain whose memory is to be copied. */ + domid_t domid; + + /* IN - Flags. */ +#define XENMEM_foreigncopy_from 0 +#define XENMEM_foreigncopy_to 1 +#define XENMEM_foreigncopy_direction 1 + uint16_t flags; + + /* + * IN/OUT + * + * As an IN parameter number of frames of the domain to be copied. + * On output updated number of frames left (0 if success). + */ + uint32_t nr_frames; + + /* + * IN/OUT + * + * Frames to be copied. + * On output updated to point to the first frame unhandled, if any. + */ + XEN_GUEST_HANDLE(xen_pfn_t) frame_list; + + /* + * IN/OUT + * + * Guest buffer to read/write from. + * On output updated to point to the first page pointer unhandled. + */ + XEN_GUEST_HANDLE(uint8) buffer; +}; +typedef struct xen_foreigncopy xen_foreigncopy_t; +DEFINE_XEN_GUEST_HANDLE(xen_foreigncopy_t); + +/* Next available subop number is 30 */ #endif /* __XEN_PUBLIC_MEMORY_H__ */ diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 131631cb27..dcdb7f5396 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -569,6 +569,20 @@ static XSM_INLINE int cf_check xsm_map_gmfn_foreign( return xsm_default_action(action, d, t); } +static XSM_INLINE int cf_check xsm_foreigncopy_from( + XSM_DEFAULT_ARG struct domain *d, struct domain *t) +{ + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, t); +} + +static XSM_INLINE int cf_check xsm_foreigncopy_to( + XSM_DEFAULT_ARG struct domain *d, struct domain *t) +{ + XSM_ASSERT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, t); +} + #ifdef CONFIG_HVM static XSM_INLINE int cf_check xsm_hvm_param( diff --git a/xen/include/xsm/hooks.h b/xen/include/xsm/hooks.h index 5bdb23f26d..63e2831d31 100644 --- a/xen/include/xsm/hooks.h +++ b/xen/include/xsm/hooks.h @@ -58,6 +58,8 @@ XSM_HOOK(int, add_to_physmap, struct domain *, struct domain *) XSM_HOOK(int, remove_from_physmap, struct domain *, struct domain *) XSM_HOOK(int, map_gmfn_foreign, struct domain *, struct domain *) XSM_HOOK(int, claim_pages, struct domain *) +XSM_HOOK(int, foreigncopy_from, struct domain *, struct domain *); +XSM_HOOK(int, foreigncopy_to, struct domain *, struct domain *); XSM_HOOK(int, console_io, struct domain *, int) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 3cfdf6bf08..281800e176 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1368,6 +1368,16 @@ static int cf_check flask_map_gmfn_foreign(struct domain *d, struct domain *t) return domain_has_perm(d, t, SECCLASS_MMU, MMU__MAP_READ | MMU__MAP_WRITE); } +static int cf_check flask_foreigncopy_from(struct domain *d, struct domain *t) +{ + return domain_has_perm(d, t, SECCLASS_MMU, MMU__MAP_READ); +} + +static int cf_check flask_foreigncopy_to(struct domain *d, struct domain *t) +{ + return domain_has_perm(d, t, SECCLASS_MMU, MMU__MAP_READ | MMU__MAP_WRITE); +} + #ifdef CONFIG_HVM static int cf_check flask_hvm_param(struct domain *d, unsigned long op) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:52 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387332.1628653 (Exim 4.92) (envelope-from ) id 1wtNHQ-0005wj-BT; Mon, 10 Aug 2026 10:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387332.1628653; Mon, 10 Aug 2026 10:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHQ-0005wW-7O; Mon, 10 Aug 2026 10:30:52 +0000 Received: by outflank-mailman (input) for mailman id 1387332; Mon, 10 Aug 2026 10:30:50 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHO-0005mI-Re for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHO-00Dyin-8C for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:50 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a854-bab6-0a2a0a5309dd-0a2a450799ec-14 for ; Mon, 10 Aug 2026 12:30:50 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a85a-b4ea-0a2a45070019-d1558035a911-3 for ; Mon, 10 Aug 2026 12:30:50 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4954a9e8490so22911205e9.1 for ; Mon, 10 Aug 2026 03:30:50 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357849; x=1786962649; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3+Xmp4HOhS3Pe3sNnwkV9Nev075F3jzmTYNfYLmJyJ8=; b=gtDSvt3XLEF0+lvQmQpagPOxD+0HfyCi9SY4SgOtI34Q71fF520A50KI3R6asKiy7o EcYlQ3rf4vzvzkchvPC01UnKK++WMHlUXH5OH706GiBiqvJmi+8U6zknAp+RHmOuY0Tm Hdp4ppYkczqspONQlul4iFdjhg/pVXFFOo/CPqeM5m/7HBN2E8w5pSC17iPxKzAgZ25S uOKOV4HqmTJFIXMyJVIfJgSyvCcNZ4r+OpQMO9LMWYVp1FgrISAx7+4gLTMyaTZqnoay hAkRBTQPbtx2qHVGzVMwATUKSGA7uhSiwtjyvijDYIQCm9+fuL6BKjsmeJ/nvGY5rMYo icZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357849; x=1786962649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3+Xmp4HOhS3Pe3sNnwkV9Nev075F3jzmTYNfYLmJyJ8=; b=nNMea2ZxnrskLsVM7ZtZTuExUNL9p7rztECnxYx/Jyh9bjzpg5GpAPiPipHYJ/Qpik EMZ3yoAbdHImBimhP0g8Hc5mlCUW5vkXbLUij9OSBdgsf4riDudsERx6HrqpejkAqFDF iv7X3xzGZJ50P5crPIcj1xzbh/MvcsOPtIk6QJL9u5kEaVM/fN6EWlj0BQSBOOKBDUte fk+vMm3m7Tm0engIlvzKElhTuWl1ITEiKfzw7j0YabFyH6JTadG0mlf7C70IC4D5fFnd brNLTg3s76yB8zvmRP7qA0RHIf8TjXNPQiWKcS7duVSCGH/11Ux1qruDJ8/yMfcG+qRk 9Zdw== X-Gm-Message-State: AOJu0YyhS9Da4dMD8o5+/DCwl3AeCosrtOZm0jGpyyVd74k48sUEVIBm Pfbcaps3+vtKSJSk4oK1i7D8WHeRBM7YInfadNtMttnFqAys1LWEhCv546Wn0ljjjFs= X-Gm-Gg: AR+sD11E9+7ILZ58VGN/7jJlVXLWJNpaGETrhUnec912ha4u18E6sqbVHs5zAhEYzsB TM1YunT6CHuk1seD3h+az2jpbweExOvp2Ui0X6UMWw47+GAdIMTfyYdESfF4FSXZ3TXxEsDfdGz msitmMpjZVoatZYA6WCr0EWYmXTreM55GGnx4sqRv89hxakWY5/0edBZ687FOXHi04TkUqWD1CN U3xFJ8OgmR9NlHmDZc98w92yo0oBvxNnj14n3w8f67SDBCra55FaiyEWyFtPpMT3f7JYjqcpBLs cJgIcOy6CoWtr6gj/WWBAY35lKSWhimmbXi3vRjanX/JovtP2p/yFdDQCNl/jD6Bfhkx3llsLBc q1YDmTlUsgQVDGXaGTb9tu41AByUxiybfpJ0+68mHoZoCRhKNHwxAG4hqK7drROyrtJ/0Oc12Ut 8MGGOiG7MofJyEwlmspeDEyxIQv7mfXQw4r26RdhNOuVjy+MOE7MLeCr4P3ba6yF7u27Pcp1VAy YVnfjMOzSG1VJaixXneYAEIWJZPJT1nFaLOoVFm X-Received: by 2002:a05:600c:3154:b0:495:3bc6:d381 with SMTP id 5b1f17b1804b1-49962453c45mr201315725e9.2.1786357848475; Mon, 10 Aug 2026 03:30:48 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: [PATCH v10 8/10] privcmd: Add definition for new Linux privcmd to access new Xen hypercall Date: Mon, 10 Aug 2026 11:30:11 +0100 Message-ID: <20260810103018.54564-9-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-ef75cf/1786357850-374D3AE4-0A5726EE/0/0 X-purgate-type: clean X-purgate-size: 1401 Userspace should use new ioctl to access new hypercall. Signed-off-by: Frediano Ziglio --- Changes since v4: - update comment. --- tools/include/xen-sys/Linux/privcmd.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/include/xen-sys/Linux/privcmd.h b/tools/include/xen-sys/Linux/privcmd.h index 607dfa2287..7a3c41308b 100644 --- a/tools/include/xen-sys/Linux/privcmd.h +++ b/tools/include/xen-sys/Linux/privcmd.h @@ -100,6 +100,14 @@ typedef struct privcmd_pcidev_get_gsi { __u32 gsi; } privcmd_pcidev_get_gsi_t; +typedef struct privcmd_foreigncopy { + domid_t dom; /* Foreign domain. */ + __u16 dir; /* Direction, 0 from, 1 to. */ + __u32 num; /* Number of pages to copy. */ + const xen_pfn_t __user *pfns; /* Array of pfns. */ + void __user *buffer; /* Buffer to copy to/from. */ +} privcmd_foreigncopy_t; + /* * @cmd: IOCTL_PRIVCMD_HYPERCALL * @arg: &privcmd_hypercall_t @@ -121,6 +129,8 @@ typedef struct privcmd_pcidev_get_gsi { _IOC(_IOC_NONE, 'P', 7, sizeof(privcmd_mmap_resource_t)) #define IOCTL_PRIVCMD_PCIDEV_GET_GSI \ _IOC(_IOC_NONE, 'P', 10, sizeof(privcmd_pcidev_get_gsi_t)) +#define IOCTL_PRIVCMD_FOREIGNCOPY \ + _IOWR('P', 11, privcmd_foreigncopy_t) #define IOCTL_PRIVCMD_UNIMPLEMENTED \ _IOC(_IOC_NONE, 'P', 0xFF, 0) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387334.1628660 (Exim 4.92) (envelope-from ) id 1wtNHQ-0005zd-S1; Mon, 10 Aug 2026 10:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387334.1628660; Mon, 10 Aug 2026 10:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHQ-0005yb-GH; Mon, 10 Aug 2026 10:30:52 +0000 Received: by outflank-mailman (input) for mailman id 1387334; Mon, 10 Aug 2026 10:30:51 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHP-0005rk-Bq for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHO-00Dyin-Oq for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:50 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a85a-bab6-0a2a0a5309dd-0a2a450ce3f8-0 for ; Mon, 10 Aug 2026 12:30:50 +0200 Received: from [209.85.128.50] (helo=mail-wm1-f50.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a85a-f479-0a2a450c0019-d1558032ad5d-3 for ; Mon, 10 Aug 2026 12:30:50 +0200 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49558ce01afso13250535e9.1 for ; Mon, 10 Aug 2026 03:30:50 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357850; x=1786962650; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kAXV9ixt1kgi3GnwQ2iOZUoRsAZqt/4+AFDCaE6CjSg=; b=P5iCpsfNaVH88Si13CsIDlLOFZztr6wXx6/QCdl1ZFuI4R/OZccH+ZMMxp5OAFoS2/ IQsUMSmvlVryFWImXqacDwF/dXwMabeeRyrSsqyRmyCaDxSgT2MRpkerCM/tdLkE3bA4 pHO693NJptx9bwrdUmbznIh8L0PrUL0nGGGYF+9zfCA9+SlcohYv5LiDaZ3X/8JTG5k4 lPl4aplLUymxPbI55R8UpTejLhm2ybPnjL7xF8QJCkWygt9ZcVVOQgarR6ELVijkoort mS8oyYbSqkhIhhgT0Fn35QTFIiy6Bma7f8pmcOUcrTHtKkdSSxZggFwjpaMC1ieAxNqC pe/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357850; x=1786962650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kAXV9ixt1kgi3GnwQ2iOZUoRsAZqt/4+AFDCaE6CjSg=; b=rY/hK24RFYvWKtj+nJpwj03KxQepQ0sGNqDpP6PnG2hHUWHMazsQ3VXQ+WLGybocg7 oxIC3p7LD41aiEU/+mzNqI30WPF0riSlXcsgevmDYo6jsGF3EmPCIJkSfL6SV3Mg9YSy k8gXbsS2yMGJX8v4OGr909Q9mQG52Zx9uYCdme6ONg7Yy5O5PW+N+DCQpNYp7KnQPcHB z8MQlwrQNYtvU+STulPuJurlhP72Ahlhg/4xNyxiTzJ7tzSBRJajXxTz+QLC7BR5wk6X wysYMoeHEM2x3PLsPWXdAYdIHc37ZFmFxBjp1G2rE3tUwH/lN76BrnC+gm1EoMzI8ifc Fnmw== X-Gm-Message-State: AOJu0YzncX2+NPhg9m9OZTiQgTtN53M6hpXdS0fmTUkOCQ7h43ioOg5W YzQjJpHOg7z9gB4eUsop3w4HUtkqwfXbLQCpLEmbyfKCKlZLd23Cetew9PFZSal2T6s= X-Gm-Gg: AR+sD11ZoQpDWYJWdZduz8EPTTu2UDEv+8gGN6W3lT3OZLoGxmLGxIqtzLTuPqzTumh G8x4ISKAgJLt0Sz/WiA55jMZS5pUdnvoRDFgHoy5RKuzHPD7f2ay0VkTJA07sgi3+FDGch8wK2N +CinvDQ2iLAA4CgqFt9pZoSxabkrAmU0kUeHQ743AvGZySd/t+gPgQgPufO+/0Ub0ddKgIcrFsC GiORVZfh1uP5Ap9mdN5rNCIzrwfuYwPVn7j54wE8dO9v/j+5TKWOwo9jZzzqsGpRpTs313sX1P/ osto5luJSZWm+0/B3vqJPn2Z39PqIXWUKwTeIsfn6U8S0lde8jUO/kz7T6E9JRzyCI9QjbH773p fepH99Yx93OIwHAKwBTSC+tMRSohwMM67SEogEGkRWgvmswSk0OszqtRoKo1T8Hw1wkBBp11v7e rCZa+7L0VNk1NTkD5hUXWRgFla0Wo8Gt/k3KT913+QL5q3Q1k21QYX7TLOYZzOT06RqcXfkCuuU VUv4VheoKXoxPdPBeyQpRKk4auOfKPdtJdIbbBD X-Received: by 2002:a05:600c:35c8:b0:499:593b:a15b with SMTP id 5b1f17b1804b1-499593ba192mr395987645e9.1.1786357850038; Mon, 10 Aug 2026 03:30:50 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: [PATCH v10 9/10] libs/guest: use new hypercall if available Date: Mon, 10 Aug 2026 11:30:12 +0100 Message-ID: <20260810103018.54564-10-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1786357850-51D34A5B-337B1D1C/0/0 X-purgate-type: clean X-purgate-size: 4281 Use new hypercall if available, otherwise fall back to map+copy+unmap sequence. I took some statistics while migrating some machines instrumenting the code to use new and old code and doing it 5 times in a row for each and the raw operation takes at least 4 (from) or 5 (to) times less. Specifically for a test done with a machine with Intel Xeon Sapphire Rapids CPUs and migrating a Windows 10 machine with 12 GB of RAM the ratios were: - 4.9 times faster copying from guest to dom0; - 5.3 times faster copying to guest from dom0. The test was repeated multiple times resulting consistent in all rans. Signed-off-by: Frediano Ziglio --- Changes since v4: - use int8_t instead of char for signed type. Changes since v6: - add some statistics. Changes since v9: - fixed a pointer initialization. --- tools/libs/guest/xg_sr_common.c | 47 ++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/tools/libs/guest/xg_sr_common.c b/tools/libs/guest/xg_sr_common.c index 90da21c35f..ce5026c707 100644 --- a/tools/libs/guest/xg_sr_common.c +++ b/tools/libs/guest/xg_sr_common.c @@ -156,11 +156,6 @@ static void __attribute__((unused)) build_assertions(void) BUILD_BUG_ON(sizeof(struct xc_sr_rec_hvm_params) != 8); } -enum { - foreigncopy_from, - foreigncopy_to -}; - static int xg_foreignmemory_copy(xc_interface *xch, domid_t domid, int dir, size_t nr_pages, void *buffer, const xen_pfn_t foreign_pfns[nr_pages]) @@ -174,8 +169,42 @@ static int xg_foreignmemory_copy(xc_interface *xch, domid_t domid, return -1; } + /* + * If foreign copy is supported, -1 not initialized, 0 not supported, + * 1 supported. + */ + static int8_t foreign_copy_supported = -1; + + if ( foreign_copy_supported ) + { + int rc; + privcmd_foreigncopy_t copy = { + .dom = domid, + .dir = dir, + .num = nr_pages, + .buffer = buffer, + }; + DECLARE_HYPERCALL_BOUNCE_IN(foreign_pfns, nr_pages * sizeof(xen_pfn_t)); + + if ( xc_hypercall_bounce_pre(xch, foreign_pfns) ) + return -1; + + copy.pfns = (xen_pfn_t *)HYPERCALL_BUFFER_AS_ARG(foreign_pfns); + + rc = ioctl(xencall_fd(xch->xcall), IOCTL_PRIVCMD_FOREIGNCOPY, ©); + if ( foreign_copy_supported < 0 ) + foreign_copy_supported = + (!rc || (errno != ENOTTY && errno != ENOSYS)); + + xc_hypercall_bounce_post(xch, foreign_pfns); + + if ( foreign_copy_supported ) + return rc; + } + + /* Fallback, emulate. */ int err[nr_pages]; - const int prot = (dir == foreigncopy_from) ? PROT_READ : PROT_READ|PROT_WRITE; + const int prot = (dir == XENMEM_foreigncopy_from) ? PROT_READ : PROT_READ|PROT_WRITE; void *p = xenforeignmemory_map(xch->fmem, domid, prot, nr_pages, foreign_pfns, err); if ( !p ) @@ -189,7 +218,7 @@ static int xg_foreignmemory_copy(xc_interface *xch, domid_t domid, return -1; } - if ( dir == foreigncopy_from ) + if ( dir == XENMEM_foreigncopy_from ) memcpy(buffer, p, nr_pages * XC_PAGE_SIZE); else memcpy(p, buffer, nr_pages * XC_PAGE_SIZE); @@ -201,7 +230,7 @@ int xg_foreignmemory_copy_from(xc_interface *xch, domid_t dom, size_t nr_pages, void *dest, const xen_pfn_t source[nr_pages]) { - return xg_foreignmemory_copy(xch, dom, foreigncopy_from, + return xg_foreignmemory_copy(xch, dom, XENMEM_foreigncopy_from, nr_pages, dest, source); } @@ -209,7 +238,7 @@ int xg_foreignmemory_copy_to(xc_interface *xch, domid_t dom, size_t nr_pages, const xen_pfn_t dest[nr_pages], const void *source) { - return xg_foreignmemory_copy(xch, dom, foreigncopy_to, + return xg_foreignmemory_copy(xch, dom, XENMEM_foreigncopy_to, nr_pages, (void *) source, dest); } -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 10:30:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 10:30:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387336.1628668 (Exim 4.92) (envelope-from ) id 1wtNHS-0006LE-8S; Mon, 10 Aug 2026 10:30:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387336.1628668; Mon, 10 Aug 2026 10:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHS-0006Jf-1g; Mon, 10 Aug 2026 10:30:54 +0000 Received: by outflank-mailman (input) for mailman id 1387336; Mon, 10 Aug 2026 10:30:53 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNHQ-0005zg-Q5 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 10:30:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNHQ-000BDZ-6F for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 12:30:52 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79a854-2eae-0a2a0a5409dd-0a2a4509bf7e-46 for ; Mon, 10 Aug 2026 12:30:52 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79a85c-be1a-0a2a45090019-d1558029d1c2-3 for ; Mon, 10 Aug 2026 12:30:52 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4995b0343c1so14895985e9.3 for ; Mon, 10 Aug 2026 03:30:52 -0700 (PDT) Received: from localhost.localdomain ([31.111.172.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995bb8b668sm218478455e9.0.2026.08.10.03.30.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 03:30:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786357851; x=1786962651; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UVOrYo9kwDL27bIBgSRi6l0uRZVsLr0xOhtweF06SqI=; b=OFQuNM/CI3Ms3ghElvx6gHV113l9f8rJdEPvrkjHSnPr/Fl7VuGVd6HOrhKZpudEKU VsgqdHY0flt9zyRLmzpU3zwUbLIFBp9EZbBad5flLsliatOf50DNxMxyg677h6eo1y3u 3eBdyqtLeFbwqQaoXR1QI0rPH2jiTj5M6CFsCINN7apxor5ivpAXUffe9YK9aD8NLkez I1BlKtfemqzeT86jBU74TXh14bntZGjYqziICDDf/UWuHWRPYFG8+aEpjLVEbE1SrmL6 1ffu1VoSwkJqfXG18P0PtsNvUfbf4A7gbAFSR9KbqHaGp6IbHlzS4FdknKZcrzh9cqRK H2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786357851; x=1786962651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UVOrYo9kwDL27bIBgSRi6l0uRZVsLr0xOhtweF06SqI=; b=qbYnE6xRPVHuZ0s8uCRbR6NBYLuLocC1ujczkNtCKV8hdSu1hh3zzqgVNvG7QA1LUx 3RCbQdjx0Aq9YF18MXMvRSnhst9c2OVM+I213AlWA1wIIUIxRWyw37lHPwrdg7KQKlQv T6O79/1xDX1l2b9Dmtvp24yOQtHUj2G3qGF596SEeo8cXV9P0tdWSfPUqUayfldq15nx ljxl/RBwUDUkmSBFd3Pl4B/D1+ywUJMuZ/YMYKF8QdO95W+qrcAa2MqNDf3ClD6UF5as BDeBabtQT0bB9LT/4VrddCly6NZkcgu/sqozD6TVWWQcWwNovyxbz0XCrdtEBctI9147 SpXw== X-Gm-Message-State: AOJu0YzUxup0D13r3gziyWX8EzSqjidParyWHBB24FpMtibY8S030vGI e1vn9bgyQOgMSux978Stui3mtbvqCAFMbpwQHB9N1fCz9UXKl5DIo7dIEcBnLe6kWVk= X-Gm-Gg: AR+sD12cUWJyexX2URDj4+cUh5U9q2py+t52F6gRZjy3syVxB00j1zvGu1dFvljZWfI jNS8D3nX/Hw26AoBjLHPyfqreAiGOHsj8iGVlk5y8bTkHCw2mvzC1xIczWi4hdwMD3ybxqrVf4j nsfzynpIQUWCJ0QD3Y0RaAG2RSu+IRIVJK9okYT0HyCuPfVFpVM0Gs4B0Zbnpltr+BHMZjfdNEe LKKLL8ZbVjfFzef+8s8dH6usgZmDt1TMsFKyVsvWXuHt4v3c9XSTQuEdaUECy/8kYtXN99HlHBs /rskhkG98SRMFfLTmvpQpz2XfBstRgGAN4VYFISTVYlrZez1tdmjk8hTkIKRVWIiEzBOkg5ep1w c9soKxsffV/4+ixIczmR4R3JhA3g0UGYImo/JkAmZ/P6pNoAbRmOR9TA38PlL4rsmcFw16bm1+x Fz3i5OosHXGPfMQPsXEYL1D/AZDeYLv1COiZeSDN0NA58W54gXeYgwSB5skyIhUOVWkz5+jESN+ pFjPc4pGWyBRIrsoP2BTjOBiU35Vy4mAneEVCkm X-Received: by 2002:a05:600c:4f45:b0:493:c47f:3c55 with SMTP id 5b1f17b1804b1-49972764ed2mr11520785e9.5.1786357851500; Mon, 10 Aug 2026 03:30:51 -0700 (PDT) From: Frediano Ziglio X-Google-Original-From: Frediano Ziglio To: xen-devel@lists.xenproject.org Cc: Frediano Ziglio , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie , Anthony PERARD , Juergen Gross Subject: [PATCH Linux v6 10/10] xen/privcmd: Add new ABI to allow copying foreign memory Date: Mon, 10 Aug 2026 11:30:13 +0100 Message-ID: <20260810103018.54564-11-frediano.ziglio@citrix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-bad1c0/1786357852-BCAC8034-8D57BA6A/0/0 X-purgate-type: clean X-purgate-size: 6569 This new ABI allows to copy foreign domain memory to/from a buffer. This avoids having to map/copy/unmap foreign memory which is expensive. This operation is done particularly when migrating VMs. Signed-off-by: Frediano Ziglio -- Changes since v4: - fix wrong assign; - use set_xen_guest_handle to set handle; - wrap slow hypercall with xen_preemptible_hcall_{begin,end}; - use _IOWR for ioctl code to be more specific; - use __copy_to_user if buffer already checked. Changes since v6: - compatibility ARM/x86. --- arch/x86/include/asm/xen/interface.h | 3 ++ drivers/xen/privcmd.c | 49 ++++++++++++++++++++++++++++ include/uapi/xen/privcmd.h | 10 ++++++ include/xen/arm/interface.h | 2 ++ include/xen/interface/memory.h | 37 +++++++++++++++++++++ 5 files changed, 101 insertions(+) diff --git a/arch/x86/include/asm/xen/interface.h b/arch/x86/include/asm/xen/interface.h index a078a2b0f032..fc76fac8fb16 100644 --- a/arch/x86/include/asm/xen/interface.h +++ b/arch/x86/include/asm/xen/interface.h @@ -59,6 +59,7 @@ #elif defined(__x86_64__) #define set_xen_guest_handle(hnd, val) do { (hnd).p = val; } while (0) #endif +#define get_xen_guest_handle(hnd) ((hnd).p) #else #if defined(__i386__) #define set_xen_guest_handle(hnd, val) \ @@ -70,6 +71,7 @@ #elif defined(__x86_64__) #define set_xen_guest_handle(hnd, val) do { (hnd) = val; } while (0) #endif +#define get_xen_guest_handle(hnd) (hnd) #endif #ifndef __ASSEMBLER__ @@ -91,6 +93,7 @@ DEFINE_GUEST_HANDLE(int); DEFINE_GUEST_HANDLE(void); DEFINE_GUEST_HANDLE(uint64_t); DEFINE_GUEST_HANDLE(uint32_t); +DEFINE_GUEST_HANDLE(uint8_t); DEFINE_GUEST_HANDLE(xen_pfn_t); DEFINE_GUEST_HANDLE(xen_ulong_t); #endif diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 725a49a0eee7..55364801ba2e 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -1522,6 +1522,51 @@ static inline void privcmd_ioeventfd_exit(void) } #endif /* CONFIG_XEN_PRIVCMD_EVENTFD */ +static long privcmd_ioctl_foreigncopy( + struct file *file, void __user *udata) +{ + const struct privcmd_data *const data = file->private_data; + long ret; + struct privcmd_foreigncopy copy; + struct xen_foreigncopy xcopy; + + if (copy_from_user(©, udata, sizeof(copy))) + return -EFAULT; + if (copy.dir & ~1u) + return -EINVAL; + if (copy.num >= U32_MAX >> PAGE_SHIFT) + return -EINVAL; + if (!access_ok(copy.pfns, copy.num * sizeof(*copy.pfns))) + return -EFAULT; + if (!access_ok(copy.buffer, copy.num << PAGE_SHIFT)) + return -EFAULT; + + /* If restriction is in place, check the domid matches */ + if (data->domid != DOMID_INVALID && data->domid != copy.dom) + return -EPERM; + + xcopy.domid = copy.dom; + xcopy.flags = copy.dir; + xcopy.nr_frames = copy.num; + set_xen_guest_handle(xcopy.frame_list, (__force xen_pfn_t *)copy.pfns); + set_xen_guest_handle(xcopy.buffer, (__force uint8_t *)copy.buffer); + + xen_preemptible_hcall_begin(); + ret = HYPERVISOR_memory_op(XENMEM_foreigncopy, &xcopy); + xen_preemptible_hcall_end(); + + /* copy values back in case of error */ + if (ret) { + copy.num = xcopy.nr_frames; + copy.pfns = get_xen_guest_handle(xcopy.frame_list); + copy.buffer = get_xen_guest_handle(xcopy.buffer); + if (__copy_to_user(udata, ©, sizeof(copy))) + ret = -EFAULT; + } + + return ret; +} + static long privcmd_ioctl(struct file *file, unsigned int cmd, unsigned long data) { @@ -1569,6 +1614,10 @@ static long privcmd_ioctl(struct file *file, ret = privcmd_ioctl_pcidev_get_gsi(file, udata); break; + case IOCTL_PRIVCMD_FOREIGNCOPY: + ret = privcmd_ioctl_foreigncopy(file, udata); + break; + default: break; } diff --git a/include/uapi/xen/privcmd.h b/include/uapi/xen/privcmd.h index 8e2c8fd44764..993b501e35bf 100644 --- a/include/uapi/xen/privcmd.h +++ b/include/uapi/xen/privcmd.h @@ -131,6 +131,14 @@ struct privcmd_pcidev_get_gsi { __u32 gsi; }; +struct privcmd_foreigncopy { + domid_t dom; /* foreign domain */ + __u16 dir; /* direction, 0 from, 1 to */ + __u32 num; /* number of pages to copy */ + const xen_pfn_t __user *pfns; /* array of pfns */ + void __user *buffer; /* buffer to copy to/from */ +}; + /* * @cmd: IOCTL_PRIVCMD_HYPERCALL * @arg: &privcmd_hypercall_t @@ -164,5 +172,7 @@ struct privcmd_pcidev_get_gsi { _IOW('P', 9, struct privcmd_ioeventfd) #define IOCTL_PRIVCMD_PCIDEV_GET_GSI \ _IOC(_IOC_NONE, 'P', 10, sizeof(struct privcmd_pcidev_get_gsi)) +#define IOCTL_PRIVCMD_FOREIGNCOPY \ + _IOWR('P', 11, struct privcmd_foreigncopy) #endif /* __LINUX_PUBLIC_PRIVCMD_H__ */ diff --git a/include/xen/arm/interface.h b/include/xen/arm/interface.h index 61360b89da40..20ee1ed44436 100644 --- a/include/xen/arm/interface.h +++ b/include/xen/arm/interface.h @@ -27,6 +27,7 @@ *(uint64_t *)&(hnd) = 0; \ (hnd).p = val; \ } while (0) +#define get_xen_guest_handle(hnd) ((hnd).p) #define __HYPERVISOR_platform_op_raw __HYPERVISOR_platform_op @@ -53,6 +54,7 @@ DEFINE_GUEST_HANDLE(int); DEFINE_GUEST_HANDLE(void); DEFINE_GUEST_HANDLE(uint64_t); DEFINE_GUEST_HANDLE(uint32_t); +DEFINE_GUEST_HANDLE(uint8_t); DEFINE_GUEST_HANDLE(xen_pfn_t); DEFINE_GUEST_HANDLE(xen_ulong_t); diff --git a/include/xen/interface/memory.h b/include/xen/interface/memory.h index 1a371a825c55..5981402fccde 100644 --- a/include/xen/interface/memory.h +++ b/include/xen/interface/memory.h @@ -325,4 +325,41 @@ struct xen_mem_acquire_resource { }; DEFINE_GUEST_HANDLE_STRUCT(xen_mem_acquire_resource); +/* + * Copy memory from/to a given domain. + */ +#define XENMEM_foreigncopy 29 +struct xen_foreigncopy { + /* IN - The domain whose resource is to be copied */ + domid_t domid; + + /* IN - Flags */ +#define XENMEM_foreigncopy_from 0 +#define XENMEM_foreigncopy_to 1 +#define XENMEM_foreigncopy_direction 1 + uint16_t flags; + + /* + * IN + * + * As an IN parameter number of frames of the domain to be copied. + */ + uint32_t nr_frames; + + /* + * IN + * + * Frames to be copied. + */ + GUEST_HANDLE(xen_pfn_t) frame_list; + + /* + * IN/OUT + * + * Userspace buffer to read/write from. + */ + GUEST_HANDLE(uint8_t) buffer; +}; +DEFINE_GUEST_HANDLE_STRUCT(xen_foreigncopy); + #endif /* __XEN_PUBLIC_MEMORY_H__ */ -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:07:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 11:07:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387415.1628681 (Exim 4.92) (envelope-from ) id 1wtNqx-0006gu-SU; Mon, 10 Aug 2026 11:07:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387415.1628681; Mon, 10 Aug 2026 11:07:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNqx-0006gn-PG; Mon, 10 Aug 2026 11:07:35 +0000 Received: by outflank-mailman (input) for mailman id 1387415; Mon, 10 Aug 2026 11:07:34 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtNqw-0006ft-0N for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 11:07:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtNqs-0034BO-OA for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:07:30 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79b0e7-2eae-0a2a0a5409dd-0a2a4509d582-26 for ; Mon, 10 Aug 2026 13:07:30 +0200 Received: from [40.107.130.48] (helo=MRWPR03CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79b0f1-be1a-0a2a45090019-286b823060bf-3 for ; Mon, 10 Aug 2026 13:07:29 +0200 Received: from DU6P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::15) by AM0PR08MB5473.eurprd08.prod.outlook.com (2603:10a6:208:180::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 11:07:23 +0000 Received: from DB1PEPF0003922F.eurprd03.prod.outlook.com (2603:10a6:10:540:cafe::48) by DU6P191CA0014.outlook.office365.com (2603:10a6:10:540::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 11:07:23 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF0003922F.mail.protection.outlook.com (10.167.8.102) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Mon, 10 Aug 2026 11:07:22 +0000 Received: from AM6PR08MB3414.eurprd08.prod.outlook.com (2603:10a6:20b:49::10) by VI0PR08MB10485.eurprd08.prod.outlook.com (2603:10a6:800:1b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 11:06:41 +0000 Received: from AM6PR08MB3414.eurprd08.prod.outlook.com ([fe80::dde8:bf0b:1dc:2a2]) by AM6PR08MB3414.eurprd08.prod.outlook.com ([fe80::dde8:bf0b:1dc:2a2%2]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 11:06:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=NpfveSg/8h0SZbLFOQkd9a23PTo9LDt9y+bWfMh9J2+KQ80xwXGIx2B+WmDxkOTlFdPMn9r3AUQrASz7wbWOVso69P75Ftpp2ZuW0uadEWi3ULKuuNCXT3UDo/MlPmBHD6+nR7vThRvrHpmX+XfcH+okPBXjn2EiHm3DLtJnSfZL2kRK5ebWvkwJi6y0+oXilnoS04k+uqH5AqQkrBGxKTXh1lN22oU0gb8TQWEFHM6utJA105mYrmHpMHos1igY/vRJWkOSMz7+fibMeeAWrhjRc178ZFOCB5MVEONnWquzfdhZi8u9jPDAQg+YggpyzOJUC0oGgLg509lWVZrHZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BnQqdXX1ZyOUKKU4li9Bc+RBJzrUk6RyawcfqsSj/Eo=; b=G+FkAECJjVw0S0GHsHYBzilgEhx+mh3nMjHEmm3/QIsdHJuFaqOpe7EWTpH/cIUsAcDUJe5YGHTq9H0Mv6vxDe4cUXZ/lxFnlfuCyYwf14o1x20iWGXYw8co5Qtoa7sTdmQfm+dg0efhWdP8B/tltGRDVog1K04qF7Ba2EewOo/Oqezxs9Jss462e6DuhRO1JjRFbNeISoIdqmM6wO8n/tWoMivh28F7lDgxxSGQfgLXNBPImvDgGR/zOB3tPl2CRDbR8juQv3PiO0bH0xi4lMtTwizYvC6VGayanrxr+pVY+Y8Dz2UgpZOnoQeDPdv1LMgmNGjqO+C9rdorbSqtIQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnQqdXX1ZyOUKKU4li9Bc+RBJzrUk6RyawcfqsSj/Eo=; b=kPqHrKjbFDa0OLbzp0kgLoxHv44vUa1iZaGhbeDApeXGB9si5HckD9jCUzXFUvjwQ6ya/WFbbblYxXJlQHpxAODd9pB0y6zyz/xt54rLMTBPk10MHoPyHEicMGmUNuP6ZNCcHkdYwPp2GXqM5wrurn9J2iWj+66UzgYkF/HfI7U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ziuome5/djtyBQzLEzz0klmAysoiBI5ZAwdG5vnb3nMr09jdV9VGv97x/PZogNuexDHgr5Xo5nw3XjHMCCjfiOoa3inGpsNMEfFzlW8yKZg8LiwfBlpVURriB1zGsB2mAyZBoQUt4prjIke7q/FWySr+Ygo8QBVmuE6d+O/0OjpAKTIxOIjcOkraqFpDsBHE4rCU647hc4e0D6FVP0Kv4noUVajpvIWXLH9litFTkeZXuLKIJYC12llbrMGJ4d2Dt8a8LFKPaUChAGM6/FefuJTy4GvU/zRGIvq3uWLhj4xlGe29JKudC2FebNsOezbu0guaNOMNCGQI/DuWebZESA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BnQqdXX1ZyOUKKU4li9Bc+RBJzrUk6RyawcfqsSj/Eo=; b=GdzwAUCegwRfCxVii+ZLGkAHtO3xXp4tzYPyF0iDSnfrKkoUNGEAMGhyDAQb39r1zcUcsMnxah9Xs/c0/bOPAN64IsYrxlHANrH0uiSvjthio3zxLLdIAClSLHTCk/a2+wLIy/0MPUkjKdt2o8mrBSwHvXehtjU2VwCbcamMxE5XsWs9w1H5IV6kNrcPdqkbq5Q6QOTzInJZbqCCym37I5EOnc2q7D/bPp1USuGxXPCX3As3bQ2IIjG6tgAGC81jJJmeoYrKOCrspJs2VC20PJ0vlwKKSWXEZu3j4/LNx5lQiLcRbzue4l6uOentjCiBOvApUlYxv4u6XBCNs2j9Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnQqdXX1ZyOUKKU4li9Bc+RBJzrUk6RyawcfqsSj/Eo=; b=kPqHrKjbFDa0OLbzp0kgLoxHv44vUa1iZaGhbeDApeXGB9si5HckD9jCUzXFUvjwQ6ya/WFbbblYxXJlQHpxAODd9pB0y6zyz/xt54rLMTBPk10MHoPyHEicMGmUNuP6ZNCcHkdYwPp2GXqM5wrurn9J2iWj+66UzgYkF/HfI7U= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Mon, 10 Aug 2026 12:06:39 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 6/9] mm: convert PTE table entry to pte To: Alexander Gordeev References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-7-usama.anjum@arm.com> <5c329236-7761-4e42-a549-b822e43b4358@arm.com> <2599c5b3-e8ac-4865-993b-d41e6f060d52-agordeev@linux.ibm.com> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: <2599c5b3-e8ac-4865-993b-d41e6f060d52-agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0240.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::11) To AM6PR08MB3414.eurprd08.prod.outlook.com (2603:10a6:20b:49::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AM6PR08MB3414:EE_|VI0PR08MB10485:EE_|DB1PEPF0003922F:EE_|AM0PR08MB5473:EE_ X-MS-Office365-Filtering-Correlation-Id: a953ce51-28e1-48aa-165f-08def6cf8d94 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|23010399003|376014|7416014|1800799024|366016|6133799003|10067099003|4143699003|56012099006|11063799006|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info-Original: lQ0hyfxi02b4F9VwRxN8Znn5OAewgjlyPjRZcVcEUaWc/2czU2/V4NIVgJiRy5t4QbhGiEJ0KwtaSe7jPvxwE+NAtXM/byDqA7dfUzahbycT7I25PzR5jhkw4frdVt9oxMHTuT5akKF8RzZ33dyxm3YumgOMNPXleL3/6dgR5gVsXlm7rW/4NEmneY9iocIiXc9AJnfTRej+kH5hV/eFNjczN84h/tHRt+GWHZjzpSAoJPL9JYvhN2uJY/S+VrzqF+CWj+0w5yWDWDTqJ2PBgzAAUUUZs2kukSyhTiklg5Og1PLgZuW6iLLN9l3sFHSU2tcSI9gz7kEmj/CGBr9gAEUkaYQ39JJiiB4jvVQCheZ+7eOV/F/NBXKAzFVSt5gbfbkSknaem3qoa0pI/BVUw5qogKsLivyhv9KJhur+AwUg3Hgnw5miP0aiKhBTfaPE0nfqcrLZgmGWMPvil7+FlI8U60XhaDqEly8cC0jIpSQvVcvtGMEalbBtDiQFFCEDkDZUFQgjRdmfVg8KexBPyscLIZeZnbQZrbdecvE8TcK0E/1c/PBQ2CN+jz7B3aX/bKPp9LZqOK57affgO+aFBh9J1aTXDH4Sj/DOUdJRckS46M4BPeWnU89+1GK6l1c08XjUtoEwa9L+S8w73BiSAlNMsrmS1vmLGiUwtdwZAdU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3414.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(1800799024)(366016)(6133799003)(10067099003)(4143699003)(56012099006)(11063799006)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: cPVi6hN5aavRhhAswfgv28wAXtZ6qeLTlP8q/AgWsrYcs7+vK+svJwSvC9NxV7RCHctlS0aIjO7/jx28wsEyjQwzfPGHOGPv1O1cSupSolWeBAX4rw+U98JrzgQTU06aoDW97oqwj+5onDZpDRYSBHwBov2+hRwPNJzrr2UbtXUdSOHd+PD4+E88nTrZSLjZV/sS2M1LGA2uVyfjDBfSo+DAoVyrKGPcprIh6Cee/RdcDdxZjE1/fY7YTLbnfllaV7GL+zNTiE62tYtPGYGbhMmEk7fG0EHHuqShM2REU2EwVZP0Wify25HFm73akjgX+cx6WziW0ou0CWTB9iKpKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10485 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF0003922F.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ca79a833-59da-449f-a5ec-08def6cf7495 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|14060799003|35042699022|1800799024|23010399003|82310400026|36860700016|6133799003|56012099006|10067099003|11063799006|4143699003|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: aB9doTRqRN7kd9TfOrTQxmun2zbzD4oTTuD1y4OqC14UyKyJNSMCGw36kf1xi38PqJ9Rtp0jlNKym4r2OvGN7Mdrix8L0sWVy1R3t6kLJaHIHqtZQGtm9crMkpQLwvqLi2JgPsgruMFGtOnAnNv3RQ3jd0sHJDccJkUb6R1CgSG5NjxGfKwCzdTVzH0f7NMXHC32MDDQrfjyaYntV5Z6MTlqnp74aBu1/Vfz2aUWF1CyaM76flGKf/iR3DBVz4zXlZ8gFMj5t7TWKAJYlfH2RHQyl1+ejF9TEC0M1d3EUUSKNIcAXS2+B6uwgaDjBF9YYZPsBe3x+8jsnEctfOzx5+LgWISUO8YhGuEFvPM/zwSeQ/ZhMN9x2dHjXnduF7LZAfeeCdXdli081Iv3yl6OxpFpBdzWQzTDA8t3zPUqrfsxQqi4pJn9BIAcFetfFrc1SZhlCQIvXZF5riUG97QLoOgJ5jTFlh2d6z5sTdXhjEujrl1WgCaQb26YYn0WAFkV5x7f+IKzUmVPkdVDWwLvrqlJA5wR2gYDNc+HKbuzIcI1SMN0BthkYebkD7uyDh23PB+OSWYO5+W8R7TMXcL4WzHNl8Ib05dzPcPnUmL6C1ZLD8qMzrvGTZ2v73Td3vbzSktxFDUeAgTLYg7gm00imt20iVjJbxchyo81jYXSiun4qm4IeZsyVNCM67/xrcFUHwajnV6IM3mpC+M3quGFmg== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(14060799003)(35042699022)(1800799024)(23010399003)(82310400026)(36860700016)(6133799003)(56012099006)(10067099003)(11063799006)(4143699003)(3023799007)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BtLaHivFG2MjBv8/s8qRcGiJDKiPENYB+2PYjmVYu+THljKaOqxVe40MzKEcSJKsZWVaiKFtOKgq9S7joX+TrjW4CONkg8omF1hSH5KQcXcggLJulUwFxWbo+WyIVRRnie8RGxdM8oI9wId9eGQEVsIa2lyk7lpRNcmJSduk+6bTsON6zLC1kFnHFKOPdQWuDJ+5gvPtkQH4gI0OcploDbbXUEAvdfQjGSf1ocLCBOu97QcYTPG0/hDWOR8EDViud7W10iQ+bgqduvXMyNwOhAmdDEZ01OiYXqqsUfO2i2bLso0Pv0p/qqXtnpvfSJ2dA7uAlOKWN9wQfclNiV893SiPpDWiKNOkuyLlnRCSZuEXEGiiQknPj+wo2iq8eG6Smx9xZv6RYcEamsBsfgmbep0Y20LINnYyBgOzRLzRtRNvmy3fgDmgtJD0KNuUHASX X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 11:07:22.6360 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a953ce51-28e1-48aa-165f-08def6cf8d94 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF0003922F.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5473 X-purgate-ID: tlsNG-bad1c0/1786360050-BFCD7034-43D8616F/0/0 X-purgate-type: clean X-purgate-size: 3835 On 10/08/2026 7:44 am, Alexander Gordeev wrote: > On Fri, Aug 07, 2026 at 05:26:04PM +0100, Muhammad Usama Anjum wrote: >> On 07/08/2026 7:58 am, Alexander Gordeev wrote: >>> On Thu, Aug 06, 2026 at 09:38:44AM +0100, Muhammad Usama Anjum wrote: >>>> The non-MMU stub receives hw_pte_t but returns a logical pte_t >>>> value. Convert the stored entry through __pte_from_hw() before >>>> returning. >>>> >>>> Signed-off-by: Muhammad Usama Anjum >>>> --- >>>> include/linux/hugetlb.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >>>> index bc0b9c65aa1d0..9e8b391aa4bc9 100644 >>>> --- a/include/linux/hugetlb.h >>>> +++ b/include/linux/hugetlb.h >>>> @@ -1283,7 +1283,7 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, >>>> #ifdef CONFIG_MMU >>>> return ptep_get(ptep); >>>> #else >>>> - return *ptep; >>>> + return __pte_from_hw(*ptep); >>> >>> But this is a direct dereferencing, which breaks the whole point, isn't it? >> Yes, this is particular line is for non MMU. In this case, CONIFG_ARCH_HAS_HW_PTE >> would never be defined. Hence hw_pte_t is just pte_t and direct dereference is >> allowed. I'd thought a lot about it; is better to leave direct dereference here >> or use some helper. Then used __pte_from_hw() was already being used in generic >> ptep_get(). > > But in case CONIFG_ARCH_HAS_HW_PTE=n __pte_from_hw() is still gets called. > That looks inconsistent to me. Why not just call ptep_deref() (see below)? Agreed. Calling __pte_from_hw() directly exposes the representation conversion at the call site. I will introduce ptep_deref() and use it here. > >> There are only two users of __pte_from_hw() at this time. >> >>> >>> What about introducing something like pte_t ptep_get_sw(hw_pte_t *ptep) >>> to be used in exactly situations like this? With that the semantics of >>> hw_pte_t pointers becomes straightforward and closes the still ongoing >>> "storage vs lifetime" discussion: >>> >>> hw_pte_t* points to HW-formatted page table entries >>> >>> ptep_get() is used to obtain HW-linked/attached entries, and may wire >>> extra code like [1] or [2] >>> >>> ptep_get_sw() is used to obtain HW-unlinked/unattached entries and in >>> most cases is just a direct dereference >> ptep_get_sw() or ptep_get_deref() is better name here? > > ptep_deref() would be it. > > Do you agree to the suggested API requirements? Yes. hw_pte_t * identifies storage containing hardware-formatted PTEs, regardless of whether it is attached. ptep_get() is used for attached entries and may provide additional architecture-specific handling. ptep_deref() is used for unattached entries and performs only the raw storage-to-value conversion. For review, this patch would become: diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index bc0b9c65aa1d0..ce900d2652d91 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -1283,7 +1283,7 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, #ifdef CONFIG_MMU return ptep_get(ptep); #else - return *ptep; + return ptep_deref(ptep); #endif } diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 1768421755a9c..08613593f3320 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -490,6 +490,13 @@ static inline int pudp_set_access_flags(struct vm_area_struct *vma, #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif +#ifndef ptep_deref +static inline pte_t ptep_deref(hw_pte_t *ptep) +{ + return __pte_from_hw(*ptep); +} +#endif + #ifndef ptep_get static inline pte_t ptep_get(hw_pte_t *ptep) { -- Thanks, Usama From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:20:27 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 11:20:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387424.1628691 (Exim 4.92) (envelope-from ) id 1wtO3L-0001L0-1f; Mon, 10 Aug 2026 11:20:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387424.1628691; Mon, 10 Aug 2026 11:20:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtO3K-0001Kt-UI; Mon, 10 Aug 2026 11:20:22 +0000 Received: by outflank-mailman (input) for mailman id 1387424; Mon, 10 Aug 2026 11:20:21 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtO3J-0001Kn-0z for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 11:20:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtO3H-00H3rN-Nc for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:20:19 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79b3f1-e002-0a2a0a5209dd-0a2a4504b020-12 for ; Mon, 10 Aug 2026 13:20:19 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79b3f1-b57f-0a2a45040019-aceafc1fd3a6-3 for ; Mon, 10 Aug 2026 13:20:19 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C481943CFA; Mon, 10 Aug 2026 11:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E03C31F000E9; Mon, 10 Aug 2026 11:20:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:Subject:To:Cc:References:From:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786360816; bh=TulNsLyt4vpxh4RnOYY8l7zFcFvhf8Jk6fhq8antiP0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=ORpkNGg2BSqzSD3++4ACU0dyFe22rkPiIMoU4R5mPSk3EtaJZnBfm9B7KMXy3Cpn9 EBzrW+XdYiOLcXC12dWCfufaWEf7uVo5F5Q6l7B+x/SQi1hrzOx4P+TYRuRH2K86BY EfLvOXfLrutZagBlSPjyDUJkCKXGlFDn/fYq15/QO3Le0ZwBaPaPuveYBVCq+WTVCt s/E5qciIPs+zNCp4IRtoqZMK6oa1m3Sf8hMh6hsAiXBqO/D1CFH8Tu73oGhIbOK+dX wYEgqUXRoWzuwdYwzU5h1IrGCcweUrkLEbvSZcd0YLdh/1LHqiZFAtpgbOXTQGITRC MZDRGV6O/Lpbw== Message-ID: Date: Mon, 10 Aug 2026 13:20:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] mm: introduce hw_pte_t for PTE table storage To: Muhammad Usama Anjum , Alexander Gordeev Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-2-usama.anjum@arm.com> <3db8233c-3785-444e-b2eb-3e5fc5cb2f17-agordeev@linux.ibm.com> <4a42c498-58ca-46f4-819f-da14cfba154f-agordeev@linux.ibm.com> <52b5066c-64f6-40bb-9bce-365a18f24265@arm.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <52b5066c-64f6-40bb-9bce-365a18f24265@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ebf023/1786360819-C3EC6B50-2CA773C0/0/0 X-purgate-type: clean X-purgate-size: 1123 On 8/10/26 12:09, Muhammad Usama Anjum wrote: > On 09/08/2026 6:45 pm, Alexander Gordeev wrote: >> On Fri, Aug 07, 2026 at 04:24:00PM +0100, Muhammad Usama Anjum wrote: >>> Thank you for testing it out on s390. >>> >>> As __hw_pte_t isn't being used yet in this series, would s390 enablement >>> patches add __hw_pte_t to this definition? >> >> I hope there is a better solution. As I noted m68k, powerpc and sparc >> may also be affected, so I would suggest to look into those as well. >> I would prefer s390 to use the generic one rather than circumvent a >> compile error in a custom way. > I've just checked all of these architectures by doing dirty conversion and > reached to same conclusion that __hw_pte_t must be defined like: > > typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; > > I'lll add __hw_pte_t to this series. (Initially on last email I'd thought > that the first user would add __hw_pte_t. But it seems sensible to add it > now) Yes, do it as part of the introduction. Also a good idea to mention in the patch description *why* that is required. -- Cheers, David From xen-devel-bounces@lists.xenproject.org Mon Aug 10 11:50:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 11:50:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387433.1628699 (Exim 4.92) (envelope-from ) id 1wtOWP-0005mS-8L; Mon, 10 Aug 2026 11:50:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387433.1628699; Mon, 10 Aug 2026 11:50:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtOWP-0005mL-4w; Mon, 10 Aug 2026 11:50:25 +0000 Received: by outflank-mailman (input) for mailman id 1387433; Mon, 10 Aug 2026 11:50:23 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtOWN-0005mF-3y for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 11:50:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtOWM-00Azn7-3N for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:50:22 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79baea-2eae-0a2a0a5409dd-0a2a4507bcd6-46 for ; Mon, 10 Aug 2026 13:50:22 +0200 Received: from [209.85.218.44] (helo=mail-ej1-f44.google.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79bafd-b4ea-0a2a45070019-d155da2cd88f-3 for ; Mon, 10 Aug 2026 13:50:22 +0200 Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c197e7e4e94so283959966b.2 for ; Mon, 10 Aug 2026 04:50:22 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a1e7d48ce7sm4332394a12.16.2026.08.10.04.50.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 04:50:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786362621; x=1786967421; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q4mNRdlCUxidZFH38/qGNOT5l90EeTySOEWFVi0lnRs=; b=fog+lRMEWPtM2qAq/ABYxRkIgCV9Zy5H43B7xo3OVWp1FfRORmSgqzahdov4+zrM+w rUkRWvDX3pWhAaTYzMikoxCP9t+K0LV5213vzPMbK93mi8/keVhAgH7LvEnYsIlZnd5A JLxWGlYP/3gYU4x9eDBdtKQfFvP7bDzx8NE9OI0VTABWTUkCWbz8YFhcGmwnLY/zJDRk iaKg6/IqWapiEgZUqRSrVkmZqKvJ63JKqGx4JbKN1YWuX/lGNN8qeavbwYeThNoktmLj yzZAOFACZDB7nr57kyyU82a1krUWA5J7zZUa8+MnTnDhh7XbcpvQpdpvg2JMHnct79Md y2uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786362621; x=1786967421; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q4mNRdlCUxidZFH38/qGNOT5l90EeTySOEWFVi0lnRs=; b=dy5OOmn9zxEyoDURr12b96UkHpFavg5lsRK9K3Pk2TuVcW9IIRei3wGCzJjEHFGb4p JAvyNfrsfv9CvC0MmZaKz7DdE0tigvptwqsUgUWv9sQoT27S9dEW8akiiL8HJIIrQ3yN 9offDw5PEIO/kplN5OrJp/S2xYoVVB+nohJOYtPuFvARl/e1P0m2I5rb5TSDWPRPzN05 tLzbVog+NLf3873gRDYDp8jpB3s/MSefZeyWgsq4gbszVbhDOJeqDLzkK5XIJ2t5oOUw jeo3xOoZqd5Ty229XCi2+9de8n5O2b4M3R46/8fplfDl33QC8hESc2LtqJLUZs0jfHaL 3+Pg== X-Gm-Message-State: AOJu0YxsY3MjWBIgdbsgyWtlC2RFnwGw4wt1D86wZJtao5864M61K3h2 8VPXwzB7EUHG9ixzEVDM+pXOd30P+ykDGoLFeBkuo1KVT5uMVC8gJiJD X-Gm-Gg: AR+sD13sSoYaDHXWgdiQko7kG1Clnh8Y/5scr8QDbWl+KTFulDGMykbGo9q9JXuLlXB wK053kPnF/mFJHtYKkHeEoxBRYLXuFknvlnyB6MyN0D08JcQ7colUcGsnZxQGy9zrf3F9BU2IuU 9waQ3+u/l1ClH8pmJHOCGlN7tkbtCq7v3NgsDcE9TEnGTiye/FrgbwE/bh7JDkF4D2NF3Z9J0NT DrHrVSqwiWj2PzOv892lUX70b7A1xb+H7TLHhaL9SQYbZFwB4p4tjhVwj4XvN6vrirT1OSqq33U SVvffumzebp5RhsCAqRP3n8zh/CbpTaktESMDTdCvuXhMgQTwtPzhOUEd80ffE6Ov0wuwDI16wb TRjfEVFLf8Hyhke4QaUwa3zFKrDhfkh1zntlw0Sf6jaJJjGqB+RBs84vdUxo83oSH7zErIykArH gXqie6fHpTy3cy4w18PJi/Wa4/bWO+Ol4KIo8AHCiMwy+yaRYyokuxCwBmf1qr02GxqUxapGqHV 8yUA9KPyUMpbfr67ZVCucVJMrE+OaFeUV8iZYLXHzo= X-Received: by 2002:a17:906:4786:b0:c20:af9d:454a with SMTP id a640c23a62f3a-c20af9d54a7mr449512766b.16.1786362621434; Mon, 10 Aug 2026 04:50:21 -0700 (PDT) Message-ID: <1282e93e-df55-4d22-9327-8454ef181588@gmail.com> Date: Mon, 10 Aug 2026 13:50:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] xen/common: add keyhandler to show Xen command line To: dmukhin@ford.com Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, Stefano Stabellini References: <20260803070047.3097846-1-dmukhin@ford.com> <20260803070047.3097846-3-dmukhin@ford.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-ef75cf/1786362622-A4CCFAE4-6DBD73C8/10/73395122804 X-purgate-type: spam X-purgate-size: 2351 On 8/8/26 4:38 AM, dmukhin@ford.com wrote: > On Fri, Aug 07, 2026 at 05:44:41PM -0700, Stefano Stabellini wrote: >> On Mon, 3 Aug 2026, dmukhin@ford.com wrote: >>> From: Denis Mukhin >>> >>> Currently there's no way to print Xen command line on the emergency >>> console for debugging purposes (e.g. 'xl' is not available in dom0). >>> >>> Add new keyhander 'X' to do command line printout. >>> >>> Signed-off-by: Denis Mukhin >>> --- >>> v1: https://lore.kernel.org/xen-devel/20260730061459.2702672-2-dmukhin@ford.com/ >>> >>> Changes since v1: >>> - moved implementation into kernel.c >>> --- >>> xen/common/kernel.c | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/xen/common/kernel.c b/xen/common/kernel.c >>> index d1bef9ac2b2b..9f334c92e3ab 100644 >>> --- a/xen/common/kernel.c >>> +++ b/xen/common/kernel.c >>> @@ -5,6 +5,7 @@ >>> */ >>> >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -505,6 +506,21 @@ static int __init cf_check param_init(void) >>> __initcall(param_init); >>> #endif >>> >>> +static void cf_check show_hypervisor_info(unsigned char key) >>> +{ >>> + printk("'%c' pressed -> showing hypervisor information\n", key); >>> + printk("Command line: %s\n", saved_cmdline); >> >> if CONFIG_CMDLINE_OVERRIDE is defined, saved_cmdline is empty. We could >> at least do this: >> >> #ifdef CONFIG_CMDLINE_OVERRIDE >> printk("Bootloader command line ignored (CONFIG_CMDLINE_OVERRIDE=y)\n"); >> #else >> printk("Command line: %s\n", saved_cmdline); >> #endif > > Actually, CONFIG_CMDLINE can set the built-in command line which can be > non-empty. > > Perhaps, something like this: > > printk("Command line (built-in): %s\n", opt_builtin_cmdline); > #ifndef CONFIG_CMDLINE_OVERRIDE > printk("Command line: %s\n", saved_cmdline); > #endif > > What do you think? Considering that opt_builtin_cmdline is declared as __initconst won't it be an issue to print it in non-init function (show_hypervisor_info())? In other words, I expected that __init section should be freed at some point and I expect that it should be data abort here. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:06:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:06:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387454.1628707 (Exim 4.92) (envelope-from ) id 1wtPhL-0007QS-Gz; Mon, 10 Aug 2026 13:05:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387454.1628707; Mon, 10 Aug 2026 13:05:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtPhL-0007QL-EH; Mon, 10 Aug 2026 13:05:47 +0000 Received: by outflank-mailman (input) for mailman id 1387454; Mon, 10 Aug 2026 13:05:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtPhK-0007QF-JN for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:05:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtPhF-00Eilq-0J; Mon, 10 Aug 2026 13:05:40 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wtPhE-00EO51-1g; Mon, 10 Aug 2026 13:05:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=luRJpyLb9INx6Asvxsh+vF1/7s+qu9Bs4HzlyKTfIh4=; b=Ak7BNB85M51zQGSTv+WNSiZG0Q 22l8cSRSdtkpE50IPsNtIxAZ69Dilkk4GDVjO2tAAHsX8DcuKgRzKrv1qfdbqIuwieabqkpgEc1n5 NAIDngqZHwgnltLL5U0hB3+j6iRYN8eE3GVdafVdXRz63cAdSonuu/AcZqgdAyGd4cGU=; Date: Mon, 10 Aug 2026 15:05:34 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: dmukhin@ford.com Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, sstabellini@kernel.org Subject: Re: [PATCH v4 1/2] xen/console: correct leaky-bucket rate limiter Message-ID: References: <20260729072520.1556970-1-dmukhin@ford.com> <20260729072520.1556970-2-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: You mention "correct" in the subject, but there's no fixes tag, and it's not clear exactly what this patch corrects. On Wed, Jul 29, 2026 at 12:25:19AM -0700, dmukhin@ford.com wrote: > From: Denis Mukhin > > Use existing 'ratelimit_ms' and 'ratelimit_burst' variables in > do_printk_ratelimit() instead of hardcoded values 5000 and 10 respectively. > > Ensure rate limiter is disabled if either 'ratelimit_ms' or 'ratelimit_burst' > is 0. > > Account for integer overflow in the rate-limiter logic. > > Signed-off-by: Denis Mukhin > --- > Changes since v3: > - fixed types > - fixed integer division logic - I used DIM_MUL2() from xvmalloc.h > I hope this is fine given another pending patch which will include xvmalloc.h > for heap allocations > - fixed potential problem w/ overflow of toks (introduced elapsed) > - fixed potential problem with toks == 0 which is also "uninitialized" > state. > --- > xen/drivers/char/console.c | 37 ++++++++++++++++++++++++++++++------- > 1 file changed, 30 insertions(+), 7 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index ea4e3ff34178..76a1681670c1 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > > #ifdef CONFIG_X86 > #include > @@ -1286,21 +1287,43 @@ bool __printk_ratelimit(unsigned int ratelimit_ms, > unsigned int ratelimit_burst) > { > static DEFINE_SPINLOCK(ratelimit_lock); > - static unsigned long toks = 10 * 5 * 1000; > + static unsigned long toks; > static unsigned long last_msg; > static unsigned int missed; > + static bool initialized; > + unsigned long limit; > unsigned long flags; > - unsigned long long now = NOW(); /* ns */ > unsigned long ms; > + s_time_t now; > > - do_div(now, 1000000); > - ms = (unsigned long)now; > + if ( !ratelimit_ms || !ratelimit_burst ) > + return true; > + > + limit = DIM_MUL2(ratelimit_burst, ratelimit_ms); > + > + now = NOW(); /* ns */ > + do_div(now, MILLISECS(1)); > + ms = now; > > spin_lock_irqsave(&ratelimit_lock, flags); > - toks += ms - last_msg; > + > + if ( initialized ) > + { > + unsigned long elapsed = ms - last_msg; > + > + if ( toks >= limit || elapsed >= limit - toks ) > + toks = limit; > + else > + toks += elapsed; > + } > + else > + { > + toks = limit; > + initialized = true; > + } I'm not sure you need the `initialized` static variable. You could set the initial value of toks = ~0, and then if the limit is set to a lower value it would already get adjusted as part of the toks >= limit check? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:06:41 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387461.1628717 (Exim 4.92) (envelope-from ) id 1wtPiD-0007ro-QA; Mon, 10 Aug 2026 13:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387461.1628717; Mon, 10 Aug 2026 13:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtPiD-0007rg-Mb; Mon, 10 Aug 2026 13:06:41 +0000 Received: by outflank-mailman (input) for mailman id 1387461; Mon, 10 Aug 2026 13:06:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtPiD-0007rS-2u for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:06:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtPiC-00Eima-1A; Mon, 10 Aug 2026 13:06:40 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wtPiB-00EPaK-2b; Mon, 10 Aug 2026 13:06:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=i4Ix+U9e9KBV/c/msUl5WKDJGozI83ZXi5f8mrs4zgM=; b=sv93cXzy6g7FwRkbsdP1K1OHjC wjvE6+E5n5+vJMz0GQQQ7n9/HnA5vh3xh03Zox94MZVLg7hMyEuMXmg9gEY7KizF0ToKnqXgrr/3g 0ARLvunHlGM7Y5SIdhH44MLTlRCLuKPI9ivchEymACicF2m/H8HAiaQ4aLRnOvtClycQ=; Date: Mon, 10 Aug 2026 15:06:35 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: dmukhin@ford.com Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, sstabellini@kernel.org Subject: Re: [PATCH v4 2/2] xen/console: add compile-time rate-limiting controls Message-ID: References: <20260729072520.1556970-1-dmukhin@ford.com> <20260729072520.1556970-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Jul 29, 2026 at 12:25:20AM -0700, dmukhin@ford.com wrote: > From: Denis Mukhin > > Introduce CONFIG_PRINTK_RATELIMIT_MS and CONFIG_PRINTK_RATELIMIT_BURST > for configuring rate-limiting policy at the compile time. > > Use symbols for global rate-limiting initialization in the console driver. > > Signed-off-by: Denis Mukhin > --- > Changes since v3: > - added note on security support for non-standard configurations > - gated menu with EXPERT > > I kept both settings for now. > --- > xen/common/Kconfig | 36 ++++++++++++++++++++++++++++++++++++ > xen/drivers/char/console.c | 6 ++++-- > 2 files changed, 40 insertions(+), 2 deletions(-) > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index da80fdba8469..749d3bfb08e0 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -672,4 +672,40 @@ config PM_STATS > Enable collection of performance management statistics to aid in > analyzing and tuning power/performance characteristics of the system > > +menu "Console rate-limiting" > + visible if EXPERT No strong opinion, but there's a drivers/char/Kconfig which might be a more natural place for those option to live, and then there's no reason for the extra menu? > + > +config PRINTK_RATELIMIT_MS > + int "printk rate-limiting time window (milliseconds)" > + default 5000 > + help > + Specifies the time window, in milliseconds, for rate-limited [*] printk > + messages. No more than `CONFIG_PRINTK_RATELIMIT_BURST` messages will be > + printed within this window. > + > + Setting this value to 0 disables rate-limiting entirely. > + > + Configurations using a value other than the default of 5000 are not > + security supported. > + > + [*] Rate-limited messages are those controlled by the `loglvl` and > + `guest_loglvl` command-line parameters. > + > +config PRINTK_RATELIMIT_BURST > + int "printk rate-limited message burst size" > + default 10 > + help > + Defines the maximum number of rate-limited [*] printk messages that may > + be printed within each `CONFIG_PRINTK_RATELIMIT_MS` time window. > + > + Setting this value to 0 disables rate-limiting entirely. > + > + Configurations using a value other than the default of 10 are not > + security supported. > + > + [*] Rate-limited messages are those controlled by the `loglvl` and > + `guest_loglvl` command-line parameters. Is it common to use footnotes in Kconfig options? It seems a bit weird to me, I would probably just expand inside parenthesis if needed. Also, I'm a bit confused by the mention of loglvl and guest_loglvl explicitly here: messages outside of the selected level are just discarded, and hence it's kind of obvious that just messages inside the selected level are controlled by this rate-limiting. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:28:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:28:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387470.1628727 (Exim 4.92) (envelope-from ) id 1wtQ3M-0003K6-Dy; Mon, 10 Aug 2026 13:28:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387470.1628727; Mon, 10 Aug 2026 13:28:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQ3M-0003Jz-AH; Mon, 10 Aug 2026 13:28:32 +0000 Received: by outflank-mailman (input) for mailman id 1387470; Mon, 10 Aug 2026 13:28:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQ3L-0003Jt-3H for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:28:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wtQ3H-00EjD9-1v; Mon, 10 Aug 2026 13:28:27 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wtQ3G-00F0LR-3A; Mon, 10 Aug 2026 13:28:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=ORu4AAR8UbgfOu7JMv6ASKuKTn1N0oTYlJ6YRXD8Evk=; b=aVU9hUqACLE+XANhM8RiRhB8uq 4FiNc71SfvbnSGv1+BeJAMk9qkwNhsQOwbh3gH31RnZYBRh1pgRWpPVQXiQNdwjPzaf7ZPStuWTzM MKfsjR+SsnNdDJHXoBI6EQ++6IZs4zSPPuL7WpPFevLwWpbLi3Ccqz8JxHHpkttJlewA=; Date: Mon, 10 Aug 2026 15:28:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: dmukhin@ford.com Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com Subject: Re: [PATCH v2 2/2] xen/common: add keyhandler to show Xen command line Message-ID: References: <20260803070047.3097846-1-dmukhin@ford.com> <20260803070047.3097846-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Aug 07, 2026 at 07:38:28PM -0700, dmukhin@ford.com wrote: > On Fri, Aug 07, 2026 at 05:44:41PM -0700, Stefano Stabellini wrote: > > On Mon, 3 Aug 2026, dmukhin@ford.com wrote: > > > From: Denis Mukhin > > > > > > Currently there's no way to print Xen command line on the emergency > > > console for debugging purposes (e.g. 'xl' is not available in dom0). > > > > > > Add new keyhander 'X' to do command line printout. > > > > > > Signed-off-by: Denis Mukhin > > > --- > > > v1: https://lore.kernel.org/xen-devel/20260730061459.2702672-2-dmukhin@ford.com/ > > > > > > Changes since v1: > > > - moved implementation into kernel.c > > > --- > > > xen/common/kernel.c | 16 ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > > > > diff --git a/xen/common/kernel.c b/xen/common/kernel.c > > > index d1bef9ac2b2b..9f334c92e3ab 100644 > > > --- a/xen/common/kernel.c > > > +++ b/xen/common/kernel.c > > > @@ -5,6 +5,7 @@ > > > */ > > > > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -505,6 +506,21 @@ static int __init cf_check param_init(void) > > > __initcall(param_init); > > > #endif > > > > > > +static void cf_check show_hypervisor_info(unsigned char key) > > > +{ > > > + printk("'%c' pressed -> showing hypervisor information\n", key); > > > + printk("Command line: %s\n", saved_cmdline); > > > > if CONFIG_CMDLINE_OVERRIDE is defined, saved_cmdline is empty. We could > > at least do this: > > > > #ifdef CONFIG_CMDLINE_OVERRIDE > > printk("Bootloader command line ignored (CONFIG_CMDLINE_OVERRIDE=y)\n"); > > #else > > printk("Command line: %s\n", saved_cmdline); > > #endif > > Actually, CONFIG_CMDLINE can set the built-in command line which can be > non-empty. > > Perhaps, something like this: > > printk("Command line (built-in): %s\n", opt_builtin_cmdline); > #ifndef CONFIG_CMDLINE_OVERRIDE > printk("Command line: %s\n", saved_cmdline); > #endif Aside from the remark from Oleksii, can you use IS_ENABLED() here instead of preprocessor conditionals? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:32:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387477.1628735 (Exim 4.92) (envelope-from ) id 1wtQ7K-00057L-T6; Mon, 10 Aug 2026 13:32:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387477.1628735; Mon, 10 Aug 2026 13:32:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQ7K-00057E-PV; Mon, 10 Aug 2026 13:32:38 +0000 Received: by outflank-mailman (input) for mailman id 1387477; Mon, 10 Aug 2026 13:32:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtQ7J-000578-MX for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:32:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQ7I-00EVma-Ts for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:32:36 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79d2f4-8faa-0a2a0a5109dd-0a2a4505d9b0-2 for ; Mon, 10 Aug 2026 15:32:36 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79d2f0-4cb1-0a2a45050019-b9ff1c228ecb-3 for ; Mon, 10 Aug 2026 15:32:32 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19febdfec57000e099.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 13:32:28 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id CF80880611; Mon, 10 Aug 2026 15:32:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=9T81Ju4UB2/Vn420Il4Co/BASrpk2PZLpayGASNpGIg=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=kj8htTYBNhWfrmZuOk9batNxqHmH+h5+0tz9w1zCqi6GzVsz+LUZ2YdGGuxYegBePuGBjgExC E99QuhJlS/H6qOMOipraT7H8pBOd4t/NUKfIGRueZYHSZG1J1TpKwC75Mjy8jsvKanOrMXHpeXz FlDz06wARapPp4zSWQnta5Bpwqhb+ij/1D7tX8ihBFpaWNjjqD5v3YsMgXNbteDu1AUbxodE6vk Ppn21jc8QGBNbB0tB1FFcrr+cvQAIcnzhYIcxwO/F4QC1yvPNxWknXk/xOvW9QO6qKJbLJNY77q g22mLpNpV01MyIG70k3kL54YM/5dbqRcuEiHzFiVYDYA== X-Zone-Loop: a6eedb683102cb253a4f04589759be9d313423c8b3e7 x-campaign-type: default x-transaction-id: 7e602ab6-55e8-4678-9ee2-11771dbc2b49 x-swg-uid: 01-ef17d2ef-e34c-4b43-8045-07519d2a2185 X-Mailer: Sweego Message-ID: <1786368748.8631fc262581453bbf619ec5b2062170.19febdfec57000e099@vates.tech> x-swg-bid: 1786368748.8631fc262581453bbf619ec5b2062170.19febdfec57000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Subject: Re: [PATCH v1 01/17] xen/riscv: manage IRQ_DISABLED flag in APLIC irq enable/disable callbacks From: Baptiste Le Duc To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: References: Date: Mon, 10 Aug 2026 15:32:21 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786368747; l=772; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=z02B9/tgz4LcVlE41Cj6lNYEwulnqWqQ/cFrEUrfPxI=; b=ocjRHBv4tBaTWtOhs11xzsQVxbm2E83P6NRd0rGksdzE+B3IXqDDd1nHNRk5T7A7kUc4bp9nJ gXCqLnMAk5yBbPSsLqWVTtVXkkprXt70UZFGw2KuHuZ6vwkkeWa/3QF X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2010.886a82330ba67ff7.19febdfea13.ce5d1f6ba744cb64=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786368748052 X-purgate-ID: tlsNG-c201ff/1786368752-F62AB2A1-828BBD7D/10/73395122804 X-purgate-type: spam X-purgate-size: 1148 ---=Part.2010.886a82330ba67ff7.19febdfea13.ce5d1f6ba744cb64=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 20 Jul 2026 18:01:59 +0200, Oleksii Kurochko wrote: > desc->status is only set once during setup_irq(), but interrupts can be > enabled/disabled at runtime, so update it in the corresponding callbacks= =2E >=20 > For the purposes of the FENCE instruction, CSR read accesses are > classified as device input (I) and CSR write accesses as device output > (O), while the barriers used by spin locks (fence rw,rw) only order > normal memory accesses=2E An explicit wmb() (fence ow,ow) is therefore > added in aplic_irq_{enable,disable}() to order the desc->status update > with respect to the IMSIC CSR write=2E >=20 > [=2E=2E=2E] Reviewed-by: Baptiste Le Duc --=20 Baptiste Le Duc -- Baptiste Le Duc | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates = solutions web: https://vates=2Etech ---=Part.2010.886a82330ba67ff7.19febdfea13.ce5d1f6ba744cb64=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:32:42 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:32:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387478.1628744 (Exim 4.92) (envelope-from ) id 1wtQ7O-0005L1-3T; Mon, 10 Aug 2026 13:32:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387478.1628744; Mon, 10 Aug 2026 13:32:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQ7N-0005Ku-W0; Mon, 10 Aug 2026 13:32:42 +0000 Received: by outflank-mailman (input) for mailman id 1387478; Mon, 10 Aug 2026 13:32:40 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtQ7M-0005Jj-Ff for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:32:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQ7L-003Xnu-CF for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:32:39 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79d2e5-e002-0a2a0a5209dd-0a2a450b9eba-46 for ; Mon, 10 Aug 2026 15:32:39 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79d2f6-b7e8-0a2a450b0019-b9ff1c239bd9-3 for ; Mon, 10 Aug 2026 15:32:39 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19febdfed5f000e099.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 13:32:28 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 47F0E83637; Mon, 10 Aug 2026 15:32:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=B8XqmmZKLgCncAIlKFa+leieV2tUIHyhNz/C3/qNJGs=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=pZNYPkxfV70VJUsy+ECFCpciVklxEExPfYLKixHgVUjfeRUC/QKIz3ACOEwprpUx7GOYrlamD QdmhiKDvI8B07IPeVCrxXQkwaM0iaC3KX/6vTbFaC+0AJxXSTZa+I1ONeiq1IqchO2q/Y+rTF+s o6vs5A2jac+2RGZm/8hNsc/+DXCPxoYd05taZSloj4NI8Sx1rDWSQfWmUpRFIx7yhnVexVH4+IE /wpMFZ5UiClhr2B6/XeQrKmMPE5SB13JOA7Kp9EAhdcuSP5pKty++1shRekW63n4hdbeCt9GARQ QJzlYHdNikGORlS5ayOVqO6PIcMl48v2QstXzKM5fq9g== X-Zone-Loop: fe21c313ec40f27de269a635cf4985c6e5078b28f485 x-campaign-type: default x-transaction-id: b1f5b066-9d13-4ffc-abea-aac0c1b45edc x-swg-uid: 01-550e9b3e-0583-468c-bdd3-090d8980b5bd X-Mailer: Sweego Message-ID: <1786368748.8631fc262581453bbf619ec5b2062170.19febdfed5f000e099@vates.tech> x-swg-bid: 1786368748.8631fc262581453bbf619ec5b2062170.19febdfed5f000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Subject: Re: [PATCH v1 02/17] xen/riscv: add basic VGEIN management for AIA guests From: Baptiste Le Duc To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: References: Date: Mon, 10 Aug 2026 15:32:21 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786368747; l=8037; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=/suDN280+hL3fCZDTTxmVx1ex2fURVPekHgQ4TonBYQ=; b=LxrofuYjYUYpV9+IlCKbegOA9u3AzG9yWlEYI6U54VAfbZCs+ZBSihrthJCDn1VYKRkD2bnZq CJtnANvazd5BVdBY3hEyWhxTI5pZRy60WU5QqicxkHzQwCF2Bc4mPYv X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2011.76c267eae0dd40.19febdfebbd.80b0a5b8f4d6725b=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786368748477 X-purgate-ID: tlsNG-42698a/1786368759-1BCD79EA-D9CAAED3/10/73395122804 X-purgate-type: spam X-purgate-size: 8646 ---=Part.2011.76c267eae0dd40.19febdfebbd.80b0a5b8f4d6725b=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > It was decided to add support for IMSIC from the start instead of having = APLIC > operate in direct delivery mode, as it requires a trap-and-emulation app= roach, > which is not optimal from a performance standpoint=2E >=20 > AIA provides a hardware-accelerated mechanism for delivering external > interrupts to domains via "guest interrupt files" located in IMSIC=2E > A single physical hart can implement multiple such files (up to GEILEN), > allowing several virtual harts to receive interrupts directly from hardw= are=2E >=20 > Introduce per-CPU tracking of guest interrupt file identifiers (VGEIN) > for systems implementing AIA specification=2E Each CPU maintains > a bitmap describing which guest interrupt files are currently in use=2E >=20 > Add helpers to initialize the bitmap based on the number of available > guest interrupt files (GEILEN), assign a VGEIN to a vCPU, and release it > when no longer needed=2E When assigning a VGEIN, the corresponding value > is written to the VGEIN field of the guest hstatus register so that > VS-level external interrupts are delivered from the selected interrupt > file=2E >=20 > Signed-off-by: Oleksii Kurochko > > diff --git a/xen/arch/riscv/aia=2Ec b/xen/arch/riscv/aia=2Ec > index e31c9c2d24=2E=2E4f7f46f58f 100644 > --- a/xen/arch/riscv/aia=2Ec > +++ b/xen/arch/riscv/aia=2Ec > @@ -1,11 +1,33 @@ > /* SPDX-License-Identifier: GPL-2=2E0-only */ > =20 > +#include > +#include > #include > #include Add a #include here instead of in aia=2Eh=2E > #include > +#include > +#include > #include > +#include > =20 > +#include > #include > +#include > +#include > + > +struct vgein_ctrl { > + unsigned long bmp; > + spinlock_t lock; > + struct vcpu **owners; > + /* The least-significant bits are implemented first, apart from bit= 0 */ > + unsigned int geilen; > +}; > + > +/* > + * VGEIN control structure for each physical CPU to track which VS (gue= st) > + * interrupt file IDs are in use=2E > + */ > +static DEFINE_PER_CPU(struct vgein_ctrl, vgein); > =20 > static bool __ro_after_init _aia_usable; > =20 > @@ -14,10 +36,133 @@ bool aia_usable(void) > return _aia_usable; > } > =20 > +static int vgein_init(unsigned int cpu) Could we call this function with a different cpu arg than the current one running? If yes, we would read hgeie of not the cpu we wanted=2E > +{ > + struct vgein_ctrl *vgein =3D &per_cpu(vgein, cpu); > + > + csr_write(CSR_HGEIE, -1UL); > + vgein->geilen =3D flsl(csr_read(CSR_HGEIE) >> 1); > + csr_write(CSR_HGEIE, 0); > + > + printk("cpu%u=2Egeilen=3D%u\n", cpu, vgein->geilen); > + > + if ( !vgein->geilen ) > + return -EOPNOTSUPP; > + > + vgein->owners =3D xvzalloc_array(struct vcpu *, vgein->geilen); > + if ( !vgein->owners ) > + return -ENOMEM; > + > + spin_lock_init(&vgein->lock); > + > + return 0; > +} > + > +static int cf_check cpu_callback(struct notifier_block *nfb, unsigned l= ong action, > + void *hcpu) > +{ > + unsigned int cpu =3D (unsigned long)hcpu; > + int rc =3D 0; > + > + switch ( action ) > + { > + case CPU_STARTING: > + rc =3D vgein_init(cpu); > + if ( rc ) > + printk("AIA: failed to init vgein for CPU%u\n", cpu); > + break; > + } > + > + return notifier_from_errno(rc); > +} > + > +static struct notifier_block cpu_nfb =3D { > + =2Enotifier_call =3D cpu_callback, > +}; > + > void __init aia_init(void) > { > + int rc; > + > if ( !riscv_isa_extension_available(NULL, RISCV_ISA_EXT_ssaia) ) > + { > + dprintk(XENLOG_WARNING, "SSAIA isn't present in riscv,isa\n"); > return; > + } > + > + if ( (rc =3D vgein_init(0)) ) Why `0` rather than smp_processor_id()? As described above vgein_init() re= ads CSR_HGEIE of the current hart but stores the result into per_cpu(vgein, cpu), so the= two must agree=2E > + { > + dprintk(XENLOG_ERR, "vgein_init() failed: %d\n", rc); > + return; > + } > =20 > _aia_usable =3D true; > + > + register_cpu_notifier(&cpu_nfb); > +} > + > +unsigned int vgein_assign(struct vcpu *v) > +{ > + unsigned int vgein_id; > + struct vgein_ctrl *vgein =3D &per_cpu(vgein, v->processor); What happens if v->processor change between vgein_assign() and vgein_release? Because it seems in such case the release will hit a different pCPU's bitmap: the original bit will leak and an unrelated CPU's bit will be cleared under another vCPU's feet=2E > + unsigned long *bmp =3D &vgein->bmp; > + unsigned long flags; > + > + if ( !vgein->geilen ) > + return 0; > + > + spin_lock_irqsave(&vgein->lock, flags); > + /* > + * The vgein_id shouldn't be zero, as it will indicate that no gues= t > + * external interrupt source is selected for VS-level external inte= rrupts > + * according to RISC-V privileged spec: > + * Hypervisor Status Register (hstatus) in RISC-V privileged spec= : > + * > + * The VGEIN (Virtual Guest External Interrupt Number) field sele= cts > + * a guest external interrupt source for VS-level external interr= upts=2E > + * VGEIN is a WLRL field that must be able to hold values between= zero > + * and the maximum guest external interrupt number (known as GEIL= EN), > + * inclusive=2E > + * When VGEIN=3D0, no guest external interrupt source is selected= for > + * VS-level external interrupts=2E > + * > + * So start to search from bit number 1=2E > + */ > + vgein_id =3D find_next_zero_bit(bmp, vgein->geilen + 1, 1); > + > + if ( vgein_id > vgein->geilen ) > + vgein_id =3D 0; > + else > + { Potential index error, because above you did: vgein->owners =3D xvzalloc_array(struct vcpu*, vgein->geilen) so valid index are 0=2E=2E=2E(vgein->geilen-1)=2E Adopt either one of those two options: 1=2E vgein->owners[vgein_id-1] =3D v 2=2E vgein->owners =3D xvzalloc_array(struct vcpu *, vgein->geilen+1) = in vgein_init() I think `2` could be better to have vgein->owners replicated hgeie CSR but it would left the first entry read-only=2E > + __set_bit(vgein_id, bmp); > + vgein->owners[vgein_id] =3D v; > + } > + > + spin_unlock_irqrestore(&vgein->lock, flags); > + > +#ifdef VGEIN_DEBUG VGEIN_DEBUG is not defined anywhere in the patch, please use gdprintk(XENLOG_DEBUG, =2E=2E=2E) directly, or drop this branch=2E > + gprintk(XENLOG_DEBUG, "%s: %pv: vgein_id(%u), xen_cpu%u_bmp=3D%#lx\= n", > + __func__, v, vgein_id, v->processor, *bmp); > +#endif > + > + return vgein_id; > +} > + > +void vgein_release(struct vcpu *v, unsigned int vgein_id) > +{ > + unsigned long flags; > + struct vgein_ctrl *vgein =3D &per_cpu(vgein, v->processor); > + > + if ( !vgein_id ) > + return; > + > + spin_lock_irqsave(&vgein->lock, flags); > + __clear_bit(vgein_id, &vgein->bmp); > + vgein->owners[vgein_id] =3D NULL; > + spin_unlock_irqrestore(&vgein->lock, flags); > + > +#ifdef VGEIN_DEBUG > + gprintk(XENLOG_DEBUG, "%s: vgein_id(%u), xen_cpu%u_bmp=3D%#lx\n", > + __func__, vgein_id, v->processor, vgein->bmp); > +#endif > } > diff --git a/xen/arch/riscv/include/asm/aia=2Eh b/xen/arch/riscv/include= /asm/aia=2Eh > index aaa4bf91fc=2E=2Ec67be0069a 100644 > --- a/xen/arch/riscv/include/asm/aia=2Eh > +++ b/xen/arch/riscv/include/asm/aia=2Eh > @@ -3,8 +3,16 @@ > #ifndef RISCV_AIA_H > #define RISCV_AIA_H > =20 > +#include asm/aia=2Eh needs neither nor as struc= t vgein_ctrl and the per-CPU variable both live in aia=2Ec=2E Please drop th= em and add in aia=2Ec --=20 Baptiste Le Duc -- Baptiste Le Duc | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates = solutions web: https://vates=2Etech ---=Part.2011.76c267eae0dd40.19febdfebbd.80b0a5b8f4d6725b=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:45:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:45:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387494.1628753 (Exim 4.92) (envelope-from ) id 1wtQJx-0007zm-94; Mon, 10 Aug 2026 13:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387494.1628753; Mon, 10 Aug 2026 13:45:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQJx-0007zf-5s; Mon, 10 Aug 2026 13:45:41 +0000 Received: by outflank-mailman (input) for mailman id 1387494; Mon, 10 Aug 2026 13:45:40 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtQJw-0007zF-9z for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:45:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQJu-00BJvF-Tf for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:45:38 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79d5ea-e002-0a2a0a5209dd-0a2a45029048-40 for ; Mon, 10 Aug 2026 15:45:38 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79d602-6ca4-0a2a45020019-b9ff1c12a695-3 for ; Mon, 10 Aug 2026 15:45:38 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19febebe536000e099.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 13:45:33 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 7B54581C91; Mon, 10 Aug 2026 15:45:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=AuvJ46ZXsKaVPL6J4UJsdpNDRwM9r7zXEul3tg/qrhg=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=QiO85++4v8Y0lcf+26gHwHqOOxEpKOzB7Tel7kFHD1MMG0uvKBigYgOBre1qR8Vecc7GOC09b l2WgyirxCAy1JA63gF2PDn2MoOC5YSvv0nMCypjYg+zCCWZtjJdmKSjDB6CpAMWrdqGyNGgb53a QAnroT+JUJiv/uxHawaJ2hga2kOYehIQejhO/1KIb7Q/Yqpwn/lRkYSsqCLTbJ/FLOLCo1uZob7 2VMvgGHEUF85fATItRcN7zB6PrshPwb5XEWEIfN5i9e/PkqOqw9J5KhuV7Kv+qH6aEwXe2g14xo HkFEs5u4RtuOakboWPLUL0H6/Z8+pIqVMRoRO3NZbqGA== X-Zone-Loop: 2ad11547e23e446bcfd583493630f987771b4a341e0e x-campaign-type: default x-transaction-id: 49d14ca0-9328-4204-9a9d-4a365047c0a7 x-swg-uid: 01-f33560e1-6228-48de-99f9-2e09ee78e2bb X-Mailer: Sweego Message-ID: <1786369533.8631fc262581453bbf619ec5b2062170.19febebe536000e099@vates.tech> x-swg-bid: 1786369533.8631fc262581453bbf619ec5b2062170.19febebe536000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Subject: Re: [PATCH v1 03/17] xen/riscv: add missing APLIC register offsets, masks to asm/aplic.h From: Baptiste Le Duc To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: References: Date: Mon, 10 Aug 2026 15:45:23 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786369532; l=932; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=cyL2Gx4dqiwndaPOMigFbRN7tCrMS1O7Fo6s0xPhDnk=; b=O4qqs96ENfYIcotiry1NxIU6yitbUjcvnH+bbR4hn57vCMEXo+h6u+P02qXTVknyUCZ4PNlf1 f99f2rx/kAJDK8gMmYGSLZvi+Yx7MLS+v4lote35pS5mg5qDDysYWkk X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2018.943d49f9532550e2.19febebe324.69f557a2f31343bb=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786369532709 X-purgate-ID: tlsNG-720697/1786369538-31FD62AC-03C5A3EB/10/73395122804 X-purgate-type: spam X-purgate-size: 1317 ---=Part.2018.943d49f9532550e2.19febebe324.69f557a2f31343bb=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > These definitions are required for correct decoding of APLIC MMIO > accesses and target configuration, and will be used by both the > physical and virtual APLIC implementations=2E >=20 > No functional change is intended by this patch; it only centralises > hardware definitions that were previously missing=2E >=20 > Co-developed-by: Romain Caritey > Signed-off-by: Oleksii Kurochko > > diff --git a/xen/arch/riscv/include/asm/aplic=2Eh b/xen/arch/riscv/inclu= de/asm/aplic=2Eh > index 07318aaac2=2E=2Ef22622b9a2 100644 > --- a/xen/arch/riscv/include/asm/aplic=2Eh > +++ b/xen/arch/riscv/include/asm/aplic=2Eh > @@ -15,6 +15,8 @@ > =20 > #include > =20 > +#define APLIC_REG_OFFSET_MASK 0x3fff _REG stands for memory-mapped control "region" as explained in spec? If yes, it'd be better to add a comment=2E --=20 Baptiste Le Duc -- Baptiste Le Duc | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates = solutions web: https://vates=2Etech ---=Part.2018.943d49f9532550e2.19febebe324.69f557a2f31343bb=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:55:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:55:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387502.1628761 (Exim 4.92) (envelope-from ) id 1wtQSw-0001fH-2d; Mon, 10 Aug 2026 13:54:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387502.1628761; Mon, 10 Aug 2026 13:54:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQSv-0001fA-W3; Mon, 10 Aug 2026 13:54:57 +0000 Received: by outflank-mailman (input) for mailman id 1387502; Mon, 10 Aug 2026 13:54:56 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQSu-0001f4-R4 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:54:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQSu-003bn7-1G for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:54:56 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79d828-8faa-0a2a0a5109dd-0a2a4502cb30-16 for ; Mon, 10 Aug 2026 15:54:56 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79d82f-6ca4-0a2a45020019-b9ff1c2299a1-3 for ; Mon, 10 Aug 2026 15:54:55 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19febf4636c000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 13:54:49 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 33FCE836B7; Mon, 10 Aug 2026 15:54:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=qYZlMcdmRV5gUuAWGbMRzHbSRcI58EU4VevDR3Dt7GE=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=XCFbg2XCWFLGGR27dXrp6Q4WGZ9rV+6OoxX+Uw7FQe9HoBZn7PfTdBZYqUaDS8ZsbnYAhrqCU thWTcPsI+YMIRL5KuL3ckNPz+CnxocMgOTT4AOcKg3JINFp+uHjG1xpLfZXcyLJnxmdhdW6yn/u 0xaWhLRLJV6gfNYsvtsrDHLREOm+/gERZKjxkRoR2e04a6LUzcPuaBuV1t0OBO8RHr+DNmDrn+s iGUgb+matMPlXXnxteV/2ZM+CLCw5KdgVkhYebwslmEUtZvA17J62ZFJmXUgDTbvfN/L3lmE0Vr Gxa2llKzC0sm1qzY/M+pVowGF33wFG96zE1b6YArfySw== X-Zone-Loop: 12ac97beabf66f61959a1ab1a95b9d6c178d7839e040 x-campaign-type: default x-transaction-id: bff11c7e-85d3-4528-b2de-57a1e2ce49b8 x-swg-uid: 01-ba4e17f1-c418-4ef8-b15c-4e1af4467c88 X-Mailer: Sweego Message-ID: <1786370089.8631fc262581453bbf619ec5b2062170.19febf4636c000e099@vates.tech> x-swg-bid: 1786370089.8631fc262581453bbf619ec5b2062170.19febf4636c000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Mon, 10 Aug 2026 15:54:48 +0200 From: Anthony PERARD To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Teddy Astie , Oleksii Kurochko Subject: Re: [PATCH v3 1/2] x86/domctl: don't imply I/O port permissions from I/O port mapping References: <65f69026-f284-4cfd-b502-8d8955b412f5@suse.com> <724bd14c-ebba-4e29-be7c-012aa7aa82b2@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <724bd14c-ebba-4e29-be7c-012aa7aa82b2@suse.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2020.8836ca613bbf8c64.19febf46169.4adba427c2485d41=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786370089321 X-purgate-ID: tlsNG-720697/1786370095-30DC12AC-4A3917C6/0/0 X-purgate-type: clean X-purgate-size: 2019 ---=Part.2020.8836ca613bbf8c64.19febf46169.4adba427c2485d41=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jun 30, 2026 at 03:54:04PM +0200, Jan Beulich wrote: > Rather than granting permissions when mapping (an operation that DM-s ar= e > allowed to carry out, while they can't invoke ioport-permission), check > whether permissions actually were granted when adding a mapping=2E This = then > also allows relaxing the necessary locking=2E >=20 > While no longer granting permissions upon mapping is "only" at risk of > breaking guests, no longer revoking permissions upon unmapping strictly > requires callers to additionally invoke XEN_DOMCTL_ioport_permission=2E = Or > else a security issue would arise=2E In-tree code already does so=2E >=20 > While there switch to using %pd in the two log messages=2E >=20 > Fixes: 192c4dabc344 ("domctl and p2m changes for PCI passthru") > Signed-off-by: Jan Beulich > --- > libxl has libxl__grant_vga_iomem_permission(), but I can't spot any I/O > port equivalent (nor a revoke counterpart, btw)=2E Everywhere else MMIO = and > I/O ports look to be treated equally=2E >=20 > Qemu uses both xc_domain_{iomem_permission,memory_mapping}() in > igd_write_opregion(), but only xc_domain_{memory,ioport}_mapping() in > xen_pt_region_update() and xen_pt_{,un}register_vga_regions()=2E Is the = IGD > region special in any way? Clearly this can't work from a stubdom=2E Yes, the IGD opregion is special, it's not something that exist on every PCI devices, just some Intel graphic devices, it's probably not part of any spec=2E Other region are just PCI bar, or the VGA region=2E I guess the toolstack could handle that device and call iomem_perission instead of QEMU, if needed=2E -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.2020.8836ca613bbf8c64.19febf46169.4adba427c2485d41=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 13:56:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 13:56:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387509.1628771 (Exim 4.92) (envelope-from ) id 1wtQUX-0002Ey-CC; Mon, 10 Aug 2026 13:56:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387509.1628771; Mon, 10 Aug 2026 13:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQUX-0002Er-9f; Mon, 10 Aug 2026 13:56:37 +0000 Received: by outflank-mailman (input) for mailman id 1387509; Mon, 10 Aug 2026 13:56:35 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3j9h5agYKCYIykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 1wtQUV-0002Eh-SL for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 13:56:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQUT-00EaMq-TR for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:56:33 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3j9h5agYKCYIykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 6a79d889-e002-0a2a0a5209dd-0a2a4505e71e-30 for ; Mon, 10 Aug 2026 15:56:33 +0200 Received: from [209.85.214.200] (helo=mail-pl1-f200.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3j9h5agYKCYIykgtpimuumrk.ius3kt-jk1krroyzy.3ktvxupkiz.uxm@flex--seanjc.bounces.google.com>) id 6a79d890-4cb1-0a2a45050019-d155d6c8ccb9-3 for ; Mon, 10 Aug 2026 15:56:33 +0200 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cacd6d37edso31874985ad.0 for ; Mon, 10 Aug 2026 06:56:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786370192; x=1786974992; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=scUOSvWK83pq1cJ9Y23cB7+1ZF4+W+kSdr2X3LP0fns=; b=Btw3EVE0HPrzXezXN8OZpzVtRs6G+8xuttQe0mJUOu8hc7KcFEPRSWnd9WSxLNRWBI 9GspDDOsCJIVD8dB23HSAAQ9H+lNeiS3VZA1ZyMWb5HbCLO028zIBj1Dp4bP6KPWRC1l koUk3Gvbruyp8VLAdTBXD7CCCnahk4Jtx15NgK4l+UqA9j1omZvwuQ+kJxSh+trEWi/D 19AXPFpY+NFf+BAQq4NLPb2q14O/Qzkpu526C/dhHfcD7k+fygUDAYwpjG7utyzXEzHO 4XYUtp6A2vse944RP/FePCNa2BVO/cv8svX1JoWM+L1mJo5mGuvqdsZq9HLSw8EuKdvs 2Xlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786370192; x=1786974992; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=scUOSvWK83pq1cJ9Y23cB7+1ZF4+W+kSdr2X3LP0fns=; b=mLoGQjaVMaOsxvOskj9X2QA7B0bRnpT0h2vtmXlDVlRSSrY1tPKJwB4tHv3PHb4EWg Z59/NkwFBEtra78lmL586nOd2zBl326tGpHw2rCSfIh/jgxtVDCkAIrt1fOjxmoiBG5+ pueIA84/o2Coi9MR0ZfBi5S18rCfPQlS8x45J5JY1L0Hn5+6gfcoJUFG/0h1YzV0T5GA 4+pDCBC84uRBTVNm38VMvZDUJ6AsmS+bZPpoJETzZU+e4UpI8aYld1WI5gfsZ4Zy+26s DMQetZvQ1A5MH/VARXwnnh4e55rRQD2V8el8EKKsW5zDgF0RmaZhfyLGjZ0oDvBic9rp 3esw== X-Forwarded-Encrypted: i=1; AHgh+RpJcUuNE3bLAl8wev9Gc+9Yj1OnPmn1AwV0kMcNhQNF/A566RI+HigjuMOIFpT1LODTR469GuPCtmc=@lists.xenproject.org X-Gm-Message-State: AOJu0YxceE7SkJdcEp0Hr2dHBZzgrO9NtPTqW9FJgrDe5UZiNmLhdzkB TIYK0MMJhI90sypr+fR4T2Ng4pGwSoiRjgiRqcvj5fWKJGF/bACWxPu+bhII8TxoZ7bQIlOsr7d gTZg6nA== X-Received: from plml3.prod.google.com ([2002:a17:903:1843:b0:2cc:7ef7:ea41]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:13c7:b0:2ce:9c48:22d3 with SMTP id d9443c01a7336-2d30033718fmr21913835ad.11.1786370191619; Mon, 10 Aug 2026 06:56:31 -0700 (PDT) Date: Mon, 10 Aug 2026 06:56:31 -0700 In-Reply-To: Mime-Version: 1.0 References: <20260806233609.212337-14-seanjc@google.com> Message-ID: Subject: Re: [PATCH v6 13/51] x86/acrn: Mark TSC frequency as known when using ACRN for calibration From: Sean Christopherson To: David Woodhouse Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-c201ff/1786370193-716AD2A1-C2E3E16F/0/0 X-purgate-type: clean X-purgate-size: 876 On Sat, Aug 08, 2026, David Woodhouse wrote: > On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > > Mark the TSC frequency as known when using ACRN's PV CPUID information. > > Per commit 81a71f51b89e ("x86/acrn: Set up timekeeping") and common sense, > > the TSC freq is explicitly provided by the hypervisor. > > > > Signed-off-by: Sean Christopherson > > Huh... does this literally get reverted completely in the very *next* > patch in the series? Kind of weird, but I guess in some ways it makes > sense... The literal code gets reverted, but the functional change does not. Before this change, ACRN is the only guest-side PV code that doesn't set X86_FEATURE_TSC_KNOWN_FREQ when the hypervisor provides the exact frequency. I.e. this patch allows for making the "No functional change intended" claim in the next patch. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:24:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 14:24:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387521.1628779 (Exim 4.92) (envelope-from ) id 1wtQvE-0007KW-Cn; Mon, 10 Aug 2026 14:24:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387521.1628779; Mon, 10 Aug 2026 14:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQvE-0007KP-9h; Mon, 10 Aug 2026 14:24:12 +0000 Received: by outflank-mailman (input) for mailman id 1387521; Mon, 10 Aug 2026 14:24:11 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQvC-0007JE-Sz for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 14:24:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQvB-008vgD-Rc for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:24:09 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79df00-2eae-0a2a0a5409dd-0a2a4508b484-30 for ; Mon, 10 Aug 2026 16:24:09 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79df09-f659-0a2a45080019-b9ff1c128abf-3 for ; Mon, 10 Aug 2026 16:24:09 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec0f24d6000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 14:24:03 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 9079F83723; Mon, 10 Aug 2026 16:24:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=w3Us9nesQGAMRB6+hb7KVElnxo3+BAlMCfqBlWxluIU=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=sLomAFoEh0VD9jNswyxRCc0EHebV2qsMrWrQ23ZSKUDgeF/ZDPCpz0rWQJ/Q9On0T7kKhBt1D Itnn9mYI509sRMhynAWL8uLqM8WNcTONiWh898tDmGmduMou2m3Gmd38vzOUU9wTdJVa6JZ7yeh kJL6LmJK9SqUEBtWaTxQ4CyT9T7EYpwGEypSya+wlbv+0ClTbBHOfYfl1imNxYknNgF2GE4hx/3 xgqFcfdTa6rve3EFQihoVQ34fyroWtSlMjyNjdOKnuNVzNoRrNWzgvKT+CjusVn5tgszCOiUFra p/VI9XzeFA7e18OKxcAffnHRia4vFx2imhkEDzm2wWBQ== X-Zone-Loop: 64e6ac7acbbe1721415925217bf7e9260646a46776ea x-campaign-type: default x-transaction-id: 0942e2cc-63eb-4493-9f70-8b571d7cadb0 x-swg-uid: 01-816107dc-484d-40c0-bc0a-0c1d64c0ec7e X-Mailer: Sweego Message-ID: <1786371843.8631fc262581453bbf619ec5b2062170.19fec0f24d6000e099@vates.tech> x-swg-bid: 1786371843.8631fc262581453bbf619ec5b2062170.19fec0f24d6000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Mon, 10 Aug 2026 16:24:02 +0200 From: Anthony PERARD To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini Subject: Re: [PATCH v2 1/3] xen/scripts: import gen_compile_commands.py from Linux References: <20260810095056.29884-1-gwd@xenproject.org> <20260810095056.29884-2-gwd@xenproject.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810095056.29884-2-gwd@xenproject.org> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2029.9152c53835ec1e0f.19fec0f22a8.f9e5d48b8774318a=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786371842728 X-purgate-ID: tlsNG-c1860d/1786371849-CF15E87B-9B6DBEA1/0/0 X-purgate-type: clean X-purgate-size: 1319 ---=Part.2029.9152c53835ec1e0f.19fec0f22a8.f9e5d48b8774318a=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2026 at 10:49:43AM +0100, George Dunlap wrote: > Xen's Kbuild-derived build system records the exact command line used > to compile each object in =2E=2Eo=2Ecmd files=2E That is everyt= hing > needed to produce a compile_commands=2Ejson compilation database, the > format clangd and other tooling consume to provide accurate > cross-referencing (go to definition, find references, call hierarchy) > in LSP-capable editors=2E >=20 > Import scripts/clang-tools/gen_compile_commands=2Epy from the Linux > kernel, unmodified, so that the provenance of the code is easy to > verify (commit 90efe2b9119f, Linux v6=2E16)=2E >=20 > As-is the script produces an empty database on a Xen tree, since > Xen's compile command lines differ slightly from Linux's; the > following patch adapts it=2E >=20 > Assisted-by: LLM > Signed-off-by: George Dunlap Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.2029.9152c53835ec1e0f.19fec0f22a8.f9e5d48b8774318a=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:24:29 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 14:24:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387522.1628788 (Exim 4.92) (envelope-from ) id 1wtQvP-0007Zr-Iq; Mon, 10 Aug 2026 14:24:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387522.1628788; Mon, 10 Aug 2026 14:24:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQvP-0007Zk-G1; Mon, 10 Aug 2026 14:24:23 +0000 Received: by outflank-mailman (input) for mailman id 1387522; Mon, 10 Aug 2026 14:24:22 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQvO-0007ZB-Fl for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 14:24:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQvN-003hT6-Sf for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:24:21 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79defc-8faa-0a2a0a5109dd-0a2a4509b7d8-46 for ; Mon, 10 Aug 2026 16:24:21 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79df15-be1a-0a2a45090019-b9ff1c2298b3-3 for ; Mon, 10 Aug 2026 16:24:21 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec0f65df000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 14:24:19 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 4972583725; Mon, 10 Aug 2026 16:24:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=04I6Hu+440OeMPdcU+TDpogAnzI3pS1YCoJF4T84N+4=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=Iig7tMnTtsAQ1YfCjsshDExFGGfEw30lhyH1+hRLo5nmzcVnVTdQIz6G26q/XquHTAAMAodGh A+5xOuNF15+s0fDlg1fOZ9W1jccSX6S1UOnXxx1AQCP5JFe4UDITydmcJ+4EA/lES73BHhUdW6g 6J8OSS1412myjXX2SWW/CkBsdxCQmI/6uZ9U1eSK7eag95wS9/KbF/RTrc+XFDO9dRBEAP8YYwW aMenGrJ2Fi6rM0kaXEh5nG5RC8Me7s2AMOoHOKPNOc3BE6bgMrYE74FziYb5j4NwbzeY7G94cKN E3M7OFGvzauhlUpWCo9KeFt3zhW2iF1vtakrPNkfyagw== X-Zone-Loop: 9d0be436b5d9daf2dfb7e39491816da8b6c27f56a948 x-campaign-type: default x-transaction-id: 0c5de289-a693-4dda-b2de-1c0f95263859 x-swg-uid: 01-6602d102-7a6f-4bfb-92f4-564e150c8a96 X-Mailer: Sweego Message-ID: <1786371860.8631fc262581453bbf619ec5b2062170.19fec0f65df000e099@vates.tech> x-swg-bid: 1786371860.8631fc262581453bbf619ec5b2062170.19fec0f65df000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Mon, 10 Aug 2026 16:24:19 +0200 From: Anthony PERARD To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini Subject: Re: [PATCH v2 2/3] xen/scripts: adapt gen_compile_commands.py to Xen References: <20260810095056.29884-1-gwd@xenproject.org> <20260810095056.29884-3-gwd@xenproject.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810095056.29884-3-gwd@xenproject.org> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.202a.e62aed357f894a53.19fec0f63e6.8e7d40e4d9946ad=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786371859430 X-purgate-ID: tlsNG-bad1c0/1786371861-FC610034-4EC8FEAF/0/0 X-purgate-type: clean X-purgate-size: 1320 ---=Part.202a.e62aed357f894a53.19fec0f63e6.8e7d40e4d9946ad=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2026 at 10:49:44AM +0100, George Dunlap wrote: > Two changes from the Linux original: >=20 > - Linux's compiler invocations end with the source file > ("=2E=2E=2E -c -o foo=2Eo foo=2Ec"), and the script's line pattern re= lies > on that; Xen's cmd_cc_o_c places "-c $<" before "-o" and "-MQ", > so on a Xen object tree the unmodified script matches nothing and > produces an empty database=2E Adjust _LINE_PATTERN to capture the > command up to and including "-c" plus the source file, dropping > the remainder, which database consumers do not need=2E >=20 > - Reword the docstring and help text to refer to Xen=2E >=20 > The support for reading object lists from archives and modules=2Eorder > is unused in Xen but retained to minimise divergence from the > original=2E >=20 > Assisted-by: LLM > Signed-off-by: George Dunlap Reviewed-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.202a.e62aed357f894a53.19fec0f63e6.8e7d40e4d9946ad=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:24:36 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 14:24:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387525.1628797 (Exim 4.92) (envelope-from ) id 1wtQvc-0007y7-S9; Mon, 10 Aug 2026 14:24:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387525.1628797; Mon, 10 Aug 2026 14:24:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQvc-0007xz-PS; Mon, 10 Aug 2026 14:24:36 +0000 Received: by outflank-mailman (input) for mailman id 1387525; Mon, 10 Aug 2026 14:24:34 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtQva-0007up-NE for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 14:24:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtQva-008vjl-2h for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:24:34 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79df15-2eae-0a2a0a5409dd-0a2a4507c85c-46 for ; Mon, 10 Aug 2026 16:24:33 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79df21-b4ea-0a2a45070019-b9ff1c12b527-3 for ; Mon, 10 Aug 2026 16:24:33 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec0f92fc000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 14:24:31 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id E2C7183723; Mon, 10 Aug 2026 16:24:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=ipFeHvE57IAsAWSsNWzZuqCIDNnFW9Ndjb+yWQWlc1U=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=DBweDEdn4CifiahFKFPNlF+TeE3vA4Mpbhwla78HlQzT8f76yrRsRlKXJOZnpRPyBQnzON+6S odtufhIQdC8vr9xtI6jJW1T6WFuAqKLahEDbunaZcFXEfM6XYMGRF+avGHcQC8b3l1PmSFCeLlJ 4s1UlWDY9fcHFhtZbSd/Lt0GsPGr3T+RuJqI+tg/LrV+8Dk3IqGPYTJ1z+j2PUU6tGY6nA5/hlS W4qK1KDTjuKiJc0lPVpTEhvDHvF8dS9fo6hicW7st+H+wW/qYvIbf4PdkkazDFrFlSWJ0p0Glis EcO4eXxcbk7pcud0Uz8Z133n5JhH/bZ+Tq2OsHXCkApw== X-Zone-Loop: c68e55a2f3f3038df9810e67bca596aaae5f8543d083 x-campaign-type: default x-transaction-id: f23847f2-c3a6-4677-b231-080ca9acecf4 x-swg-uid: 01-58a8410e-2e16-4d41-ad90-e7d6de06d9dc X-Mailer: Sweego Message-ID: <1786371871.8631fc262581453bbf619ec5b2062170.19fec0f92fc000e099@vates.tech> x-swg-bid: 1786371871.8631fc262581453bbf619ec5b2062170.19fec0f92fc000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Mon, 10 Aug 2026 16:24:30 +0200 From: Anthony PERARD To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini Subject: Re: [PATCH v2 3/3] build: add compile_commands.json target References: <20260810095056.29884-1-gwd@xenproject.org> <20260810095056.29884-4-gwd@xenproject.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810095056.29884-4-gwd@xenproject.org> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.202b.b5ca387bdc25a7b2.19fec0f914f.d3edfe96f7118aa8=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786371871055 X-purgate-ID: tlsNG-ef75cf/1786371873-374D3AE4-9C644EFB/0/0 X-purgate-type: clean X-purgate-size: 1441 ---=Part.202b.b5ca387bdc25a7b2.19fec0f914f.d3edfe96f7118aa8=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2026 at 10:49:45AM +0100, George Dunlap wrote: > Add a convenience target generating the compilation database from a > built object tree, alongside the other developer conveniences (tags, > cscope, cloc -- the last of which already walks the same =2Ecmd files): >=20 > make -C xen compile_commands=2Ejson >=20 > The output lands in the object tree root=2E For an in-tree build, > clangd and other consumers discover it there automatically when > opening files; for an out-of-tree build, symlink it into the source > tree root (consumers search the ancestors of the file being edited)=2E >=20 > Note the database records the compiler invocations actually used=2E > With a clang build it is consumable by clangd as-is; for a gcc build, > clang-based tools may need a small =2Eclangd configuration > (CompileFlags: Remove/Add) dropping gcc-only flags=2E >=20 > Also add the generated file to =2Egitignore=2E >=20 > Assisted-by: LLM > Signed-off-by: George Dunlap Reviewed-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.202b.b5ca387bdc25a7b2.19fec0f914f.d3edfe96f7118aa8=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:30:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 14:30:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387544.1628806 (Exim 4.92) (envelope-from ) id 1wtR0z-0001hA-EB; Mon, 10 Aug 2026 14:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387544.1628806; Mon, 10 Aug 2026 14:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtR0z-0001h3-Ba; Mon, 10 Aug 2026 14:30:09 +0000 Received: by outflank-mailman (input) for mailman id 1387544; Mon, 10 Aug 2026 14:30:08 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3beB5agYKCXAgSObXQUccUZS.QcalSb-RSjSZZWghg.lSbdfcXSQh.cfU@flex--seanjc.bounces.google.com>) id 1wtR0y-0001gx-OA for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 14:30:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtR0y-003iou-0l for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:30:08 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3beB5agYKCXAgSObXQUccUZS.QcalSb-RSjSZZWghg.lSbdfcXSQh.cfU@flex--seanjc.bounces.google.com>) id 6a79e04b-2eae-0a2a0a5409dd-0a2a4505cff8-42 for ; Mon, 10 Aug 2026 16:30:07 +0200 Received: from [209.85.215.197] (helo=mail-pg1-f197.google.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3beB5agYKCXAgSObXQUccUZS.QcalSb-RSjSZZWghg.lSbdfcXSQh.cfU@flex--seanjc.bounces.google.com>) id 6a79e06e-4cb1-0a2a45050019-d155d7c5e039-3 for ; Mon, 10 Aug 2026 16:30:07 +0200 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c856470fe9fso1448938a12.2 for ; Mon, 10 Aug 2026 07:30:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786372206; x=1786977006; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Pt4y4GsIfgXju50y9aE1V5oqKvyqhzjPLlHBnjvlrwI=; b=LGFverQ9ixFZDnqSr2+C8XTmo954m86TKoh7xjZnMoyE0apo/oikqD9OPbJf9iCxxF oEAJZaF8FJZpbbLOXFhmr8gQrTPJDJ9A91LI9+x1TvlszL4e+8C2AxP5vy3GIeMfJh99 O4d0ZIDHMGa0mX5zeW8A92BjpUThvha+HNDlNoguwRgvmrk4MPLZ1m/BluhGUnck94iI ThT2YygDWMETP/Sc0ExmZFIipC967HZqQSkhcr+pz3ZoHODUdMwLSfbAAmP50IdA6F6I c1vrvRMHiX6p1Os4YHYmbbpDe9cKJfJjLwocQf4L3Ehl5nhUTkGh3vxUGfdFqiXoRj3N JTnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786372206; x=1786977006; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pt4y4GsIfgXju50y9aE1V5oqKvyqhzjPLlHBnjvlrwI=; b=O/O0mf+yx8dPblnG9a/fLjbnMM0w7eqcJsVGamqsHt3MvcaESml/4JCgZjYL8JDYP1 r3u5k16yEIqJ/mO62nE3MDPzE3UuVQi2Yb3rIG7qxQzEof85swHFCYNgLtv4kSO04rG2 opqlJdiTbKjyb8WDWqp62HzgDq2klkxrIn0QxRqVwa/3EG/nf3i1Cja2jZ9mda9tMF0V QoyyzsJagHCSfOYbQkud1/aYWSklCT2TjzYgBubOsR7EE477kluLreMknU5UIAbDb7J+ 8ZtOhkADOllAOwg6AW1FrBp6JrS9K5rjOQSOwgElVJvs45dgFrt0PRZ1JrRUBDFzD5Tf NkUQ== X-Forwarded-Encrypted: i=1; AHgh+Rolpmiq8dKpYkrYHoODd9bdC9qWUoXJdkZu1k+jHETVQFuOnuc4D3BVc2yCfBw3MFxSQ8D8j6kxu0M=@lists.xenproject.org X-Gm-Message-State: AOJu0YyXPK23p6rBzwedzkMxxFEHHIFsPpR9taUtksRnSUZICVsjqV0F jJABi7Pv3p8hSZE4+HDS6EPy6KbRwOIevhIseeex3cKVLqS8Xb0BlfIBVie1XJxSyFhPXNG8jgr H94NB+g== X-Received: from pgmo14.prod.google.com ([2002:a63:5d4e:0:b0:cbe:7df7:35b0]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7fa0:b0:3c3:76a8:c0f with SMTP id adf61e73a8af0-3cbce6f17b9mr20503675637.4.1786372205374; Mon, 10 Aug 2026 07:30:05 -0700 (PDT) Date: Mon, 10 Aug 2026 07:30:04 -0700 In-Reply-To: Mime-Version: 1.0 References: <20260806233609.212337-11-seanjc@google.com> Message-ID: Subject: Re: [PATCH v6 10/51] x86/tdx: Force TSC frequency with CPUID-based info provided by the TDX-Module From: Sean Christopherson To: David Woodhouse Cc: kas@kernel.org, rick.p.edgecombe@intel.com, pbonzini@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, jan.kiszka@siemens.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, jgross@suse.com, daniel.lezcano@kernel.org, tglx@kernel.org, jstultz@google.com, x86@kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-c201ff/1786372207-71CA82A1-EC93AD19/0/0 X-purgate-type: clean X-purgate-size: 2896 On Sat, Aug 08, 2026, David Woodhouse wrote: > On Thu, 2026-08-06 at 16:35 -0700, Sean Christopherson wrote: > > When running as a TDX guest, explicitly set the TSC frequency to a know= n > > value, using CPUID-based information, instead of potentially relying on= a > > hypervisor-controlled PV routine. For TDX guests, CPUID.0x15 is always > > emulated by the TDX-Module, i.e. the information from CPUID is more > > trustworthy than the information provided by the hypervisor. > > > > To maintain backwards compatibility with TDX guest kernels that use nat= ive > > calibration, and because it's the least awful option, retain > > native_calibrate_tsc()'s stuffing of the local APIC bus period using th= e > > core crystal frequency. While it's entirely possible for the hyperviso= r > > to emulate the APIC timer at a different frequency than the core crysta= l > > frequency, the commonly accepted interpretation of Intel's SDM is that = APIC > > timer runs at the core crystal frequency when that latter is enumerated= via > > CPUID: > > > > The APIC timer frequency will be the processor's bus clock or core > > crystal clock frequency (when TSC/core crystal clock ratio is enumera= ted > > in CPUID leaf 0x15). > > > > If the hypervisor is malicious and deliberately runs the APIC timer at = the > > wrong frequency, nothing would stop the hypervisor from modifying the > > frequency at any time, i.e. attempting to manually calibrate the freque= ncy > > out of paranoia would be futile. > > > > Deliberately leave CPU frequency calibration as is, since the TDX-Modul= e > > doesn't provide any guarantees with respect to CPUID.0x16. > > > > Expose and use cpuid_get_tsc_info() instead of providing a wrapper to > > get the TSC and core crystal frequency, as TDX is the only anticipated > > user outside of the TSC code, i.e. adding a helper to dedup the math wo= n't > > actually dedup anything. Having TDX use "struct cpuid_tsc_info" also > > avoids the temptation of declaring a local "tsc_khz" variable and thus > > unintentionally creating a shadow of the global "tsc_khz". > > > > Cc: Kiryl Shutsemau (Meta) > > Signed-off-by: Sean Christopherson >=20 > I don't know if we should set X86_FEATURE_TSC_RELIABLE before bailing > out in the case where cpuid_get_tsc_info() fails, or just not care > about that because it Can Never Happen=E2=84=A2? Previously it was set > unconditionally from tdx_early_init(). >=20 > Whatever... Heh, yeah, "whatever" is about my thought exactly. I could go either way. = I would buy an argument that the TSC itself is still reliable even if the fre= quency isn't known. On the other hand, the frequency could be computed via calibr= ation, at which point the frequency is no longer reliable and arguably should be s= anity checked. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:45:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 14:45:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387553.1628816 (Exim 4.92) (envelope-from ) id 1wtRFn-0003XE-LP; Mon, 10 Aug 2026 14:45:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387553.1628816; Mon, 10 Aug 2026 14:45:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtRFn-0003X7-IH; Mon, 10 Aug 2026 14:45:27 +0000 Received: by outflank-mailman (input) for mailman id 1387553; Mon, 10 Aug 2026 14:45:26 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtRFm-0003X1-Qk for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 14:45:26 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtRFl-00ElvR-KI for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:45:25 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79e3fd-2eae-0a2a0a5409dd-0a2a4503da2a-30 for ; Mon, 10 Aug 2026 16:45:25 +0200 Received: from [209.85.221.44] (helo=mail-wr1-f44.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79e405-fae8-0a2a45030019-d155dd2ce41c-3 for ; Mon, 10 Aug 2026 16:45:25 +0200 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f703a9d05so1477577f8f.0 for ; Mon, 10 Aug 2026 07:45:25 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48002150952sm31371763f8f.15.2026.08.10.07.45.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 07:45:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786373125; x=1786977925; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1zR4+Ndao50WlK7Io6aceA3WQTvXsw/XX3ZCuxEEkqA=; b=TtJ6eU9F7hOoTZJLb1mW/rQWz2GuHn69+vzwOuBnc3oiEaUo9XN5ssjyuAoEF8VbND JEkEU6ejWRkotnOdDzJW/bIq+RUcly5EwBy3GS1FW91AeJDTOq9wcp04iw+9vxlAJON2 vHLO7873nOCuwNUdZOzI8+Od7MQg5AzmARv1Cw142qlr9mf1KNlbVjshsT2JtUvTPEe0 dEXjjg4yrRQ5URmS3twZquPKP+P0ush8kiAFKtVTO+Ogdd+qMiZ+rUiNjL3TghOmSp3w 0P1FUxpAHy5aEfsqSsgCuMqcmEgJ1Lo0g3XA6vMXj/8X5k1l25wW0JFF0atDVyE9qORC b0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786373125; x=1786977925; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1zR4+Ndao50WlK7Io6aceA3WQTvXsw/XX3ZCuxEEkqA=; b=XEMU4fjO2L6WMh3XD9L4hF9bv5DNFNHQauuXac7Nf4t9AeJCOqc2v92qCRzIFuIwKg seVpk4QKJdMS75TIFsLlXdw25hI4F2HCEKFJ8FcNVeyN6On40LXLjb9PUCp2vJAaph4D XPY/Gec6PM8TIeJZhG/KLur+xJsqNjXWRb+NqLx02xY3A3BVOLccO+z8v/60jT55pPud 2bQGexBBXoMYCnnQzSpj/o/VNOZ/9aZr/taQCxfEPi87dZk2IGnsHXzNEmhc38i43oBt mC4bvC1m1lp5wsrNWWctlDMk3J84oq6zWuw96FMKd8oycdXfLKwMNSSjL4OotYU4GCz5 YVWQ== X-Gm-Message-State: AOJu0YwTHWL7EJNY5yL/04zFluow5tbiSSt6xVBmfzKeOCEGCp9MjayL noFdu7ZOLJSkxUaODmt9wq4DO9NY5z/8dzQfqv70iv1JDQtzPbYYHXii X-Gm-Gg: AR+sD13tYwpYyp/HFV1tM8Rl/QABVPFu59Mgkf1Rw2Iigo3KZtR5IwfvIugQ/nHe/II imo2AMo+30nlMU3NZ8RigIuVN1rPebIE68DZuvwVZm7oLAxyENH3nvdYTSqVkT14ZQRL9vRNms3 FVy4Q38o50K/4PK/VutOxQts9I5D+a8qyOoBK0A1QVtBthPNSzfOsyZ79R8zxsL1oi4wWVj140F B+YagwVzdoHOjhjMpgE2vZ292YQJfJO0ucAzZZGHt1OFwiAijVOiI8zXiHCxgfsfyiW/uqezhKW 09RJUG+345zGFCwL4PkwSSH/TN7rXEALrcCUAoXdUsK49jvR2AKWT6NFbPrJRZOZqnUyS1oeEzE sZc19j4FRBh7yYsIkUwKQA7YT1Vvjo3iAzcH5u2Cuc3hUx3kjpxtOrzp8Bs1omR0RJ9I8XeXAWK wecVjGdgArTsDzFJyUVwNTXZ1o5ipz41Q041pQKc5b1qW4R8f0vHZyl8z2K8mj8K5koo2QoxCD2 kymkmMgne7qCFt7WFs0ZBm+/rIqv+1r+k2vwxUTULE= X-Received: by 2002:a05:6000:4715:b0:47f:86af:8fdd with SMTP id ffacd0b85a97d-48002670a9fmr35995155f8f.3.1786373125080; Mon, 10 Aug 2026 07:45:25 -0700 (PDT) Message-ID: Date: Mon, 10 Aug 2026 16:45:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/17] xen/riscv: add missing APLIC register offsets, masks to asm/aplic.h To: Baptiste Le Duc Cc: xen-devel@lists.xenproject.org, Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini References: <1786369533.8631fc262581453bbf619ec5b2062170.19febebe536000e099@vates.tech> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <1786369533.8631fc262581453bbf619ec5b2062170.19febebe536000e099@vates.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-33051d/1786373125-758824E9-CD6F66F3/10/73395122804 X-purgate-type: spam X-purgate-size: 1723 On 8/10/26 3:45 PM, Baptiste Le Duc wrote: >> These definitions are required for correct decoding of APLIC MMIO >> accesses and target configuration, and will be used by both the >> physical and virtual APLIC implementations. >> >> No functional change is intended by this patch; it only centralises >> hardware definitions that were previously missing. >> >> Co-developed-by: Romain Caritey >> Signed-off-by: Oleksii Kurochko >> >> diff --git a/xen/arch/riscv/include/asm/aplic.h b/xen/arch/riscv/include/asm/aplic.h >> index 07318aaac2..f22622b9a2 100644 >> --- a/xen/arch/riscv/include/asm/aplic.h >> +++ b/xen/arch/riscv/include/asm/aplic.h >> @@ -15,6 +15,8 @@ >> >> #include >> >> +#define APLIC_REG_OFFSET_MASK 0x3fff > > _REG stands for memory-mapped control "region" as explained in spec? If > yes, it'd be better to add a comment. > Yes, it is a mask that allows us to get the offsets for the registers of an interrupt domain’s memory-mapped control region. IMO, if the problem is with the name of the macro, it would be better to use a clearer name instead of adding a comment. For example, `APLIC_CTRL_REGION_OFFSET_MASK` sounds self-explanatory to me. If you’re still not happy with the suggested name and it isn't self-explanatory, then: /* * Offsets of the registers of an interrupt domain's memory-mapped control * region, which is APLIC_MIN_SIZE bytes large. */ #define APLIC_CTRL_REGION_OFFSET_MASK 0x3fff Alternatively, I could keep the old name (APLIC_REG_OFFSET_MASK) and use the suggested comment. Which option do you prefer? ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:49:45 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 14:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387559.1628826 (Exim 4.92) (envelope-from ) id 1wtRJw-0004Bb-5N; Mon, 10 Aug 2026 14:49:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387559.1628826; Mon, 10 Aug 2026 14:49:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtRJw-0004BU-1k; Mon, 10 Aug 2026 14:49:44 +0000 Received: by outflank-mailman (input) for mailman id 1387559; Mon, 10 Aug 2026 14:49:43 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtRJu-0004BO-SP for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 14:49:42 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtRJu-0001Yw-5F for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:49:42 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79e501-8faa-0a2a0a5109dd-0a2a4501d10a-2 for ; Mon, 10 Aug 2026 16:49:42 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79e505-5984-0a2a45010019-b9ff1c2396c9-3 for ; Mon, 10 Aug 2026 16:49:41 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec268e07000e099.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 14:49:37 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id C63A882207; Mon, 10 Aug 2026 16:49:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=8hzj2NizrqUYvebWcKT36+ktgNDru+858dceapaxZhg=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=nQrpnSdu08xzASFK1N2seAmvfyAc4BdmSZkG+5iv0YPjjuvbQI/CL7ul8IBWlzJBrnpGwX9Vc 811cKku0kEhi4VOLLH9qkpODaBmE7jP6qEY9C4mAi7To2WbLHhkTENmyKfYdGYaAZKU0gYnAqE4 oiTaaOHsjWSEETdPqG/agsJDAHrRZk/t40QM9TsLAriG2+9boOmx0idRCNOmsQqwQQ7EVn645Bp ecIDLp516qxwdeSRD412gQZEei6Ra0rzzA/JWqwxONbD7tuD5lGrFzLRTimEdbbAqAXDUwCdFQB obUI0prf7qu5vb7wgURsHP0eQFq8AfKRGz60q+bGyACg== X-Zone-Loop: e37e6a050a64299685ac3f4f3c4e3dbfecd4d29a4ca3 x-campaign-type: default x-transaction-id: c97014f1-4772-476b-98f1-0d3f9e539b8f x-swg-uid: 01-52b058f6-6e36-46e4-9a58-f129f24452a5 X-Mailer: Sweego Message-ID: <1786373377.8631fc262581453bbf619ec5b2062170.19fec268e07000e099@vates.tech> x-swg-bid: 1786373377.8631fc262581453bbf619ec5b2062170.19fec268e07000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Subject: Re: [PATCH v1 04/17] xen/riscv: introduce device-agnostic MMIO emulation dispatch From: Baptiste Le Duc To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: References: Date: Mon, 10 Aug 2026 16:49:30 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786373376; l=5445; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=fmPG1sGGrW14MnmDh+vw1K0FhMsncCr8M+mT56ERHzk=; b=gOK7CD1jOyWuCSsquECy+s1gQu7CQBdyDNn07ynxTxy0ADI6qdVLbYeVOGc8VYl9u3f+FyORO aSv0c2I2J1NC8fFyC5PQZVAafquChPCDoDoWSPnrgmav8Kn2sGEIvrT X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2039.d3a9d985718257a9.19fec268bf5.69e8bf0c8ca29046=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786373377014 X-purgate-ID: tlsNG-d62444/1786373381-BEA66757-4173BB55/10/73395122804 X-purgate-type: spam X-purgate-size: 6007 ---=Part.2039.d3a9d985718257a9.19fec268bf5.69e8bf0c8ca29046=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > RISC-V guests can expose several virtual interrupt controllers at > distinct GPA ranges: vPLIC (hasn't been introduced yet) for legacy machi= nes, > vAPLIC and vIMSIC for AIA-compliant ones (is being introduced in the fol= low > up patches)=2E Routing MMIO faults via a per-device is_access() check in= the > trap handler would couple it to every device it must serve, requiring a > new conditional branch in the fault path each time a new emulated device= is > added=2E >=20 > Introduce a per-domain MMIO handler registration table, modeled > after the equivalent ARM framework, so that virtual devices > self-register their GPA ranges and read/write callbacks at domain > creation time=2E The MMIO fault path delegates to a single > try_handle_mmio() entry point and remains agnostic of which device > owns a particular address=2E >=20 > Subsequent patches wire this into arch_domain_create() and the MMIO faul= t > path in traps=2Ec=2E >=20 > Signed-off-by: Oleksii Kurochko > Reviewed-by: Baptiste Le Duc > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 046f73f4d8=2E=2Ec452ebc3cf 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -14,6 +14,7 @@ obj-y +=3D intc=2Eo > obj-y +=3D irq=2Eo > obj-y +=3D kernel=2Einit=2Eo > obj-y +=3D mm=2Eo > +obj-y +=3D mmio=2Eo > obj-y +=3D p2m=2Eo > obj-y +=3D paging=2Eo > obj-y +=3D pt=2Eo > diff --git a/xen/arch/riscv/domain=2Ec b/xen/arch/riscv/domain=2Ec > index 4db9c28662=2E=2E1e6f0ef66c 100644 > --- a/xen/arch/riscv/domain=2Ec > +++ b/xen/arch/riscv/domain=2Ec > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > =20 > @@ -308,6 +309,9 @@ int arch_domain_create(struct domain *d, > if ( (rc =3D p2m_init(d, config)) !=3D 0) > goto fail; > =20 > + if ( (rc =3D domain_io_init(d, MAX_IO_HANDLER)) !=3D 0 ) > + goto fail; > + > if ( (rc =3D domain_vintc_init(d)) ) > goto fail; > =20 > diff --git a/xen/arch/riscv/include/asm/domain=2Eh b/xen/arch/riscv/incl= ude/asm/domain=2Eh > index e035b33ddf=2E=2E15e8fa1968 100644 > --- a/xen/arch/riscv/include/asm/domain=2Eh > +++ b/xen/arch/riscv/include/asm/domain=2Eh > @@ -9,6 +9,7 @@ > =20 > #include > #include > +#include > #include > #include > =20 > @@ -101,6 +102,8 @@ struct arch_domain { > const unsigned long *isa; > =20 > struct vintc *vintc; > + > + struct vmmio vmmio; > }; > =20 > #include > diff --git a/xen/arch/riscv/include/asm/mmio=2Eh b/xen/arch/riscv/includ= e/asm/mmio=2Eh > new file mode 100644 > index 0000000000=2E=2E18df1133e6 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/mmio=2Eh > @@ -0,0 +1,63 @@ > +/* SPDX-License-Identifier: GPL-2=2E0-or-later */ According to coding style, it should be GPL-2=2E0-only=2E > +#ifndef RISCV_MMIO_H > +#define RISCV_MMIO_H > + > +#include > +#include > + > +#define MAX_IO_HANDLER 16 > + > +typedef struct { > + paddr_t gpa; > + unsigned int len; /* access width in bytes (1, 2, 4, 8) */ > + bool is_write; > + register_t data; /* store: value to write; load: value read (set = by handler) */ Nit: line too long (85) > +} mmio_info_t; > + > +enum io_state > +{ > + IO_ABORT, /* The IO was handled and led to an abort=2E */ > + IO_HANDLED, /* The IO was successfully handled=2E */ > + IO_UNHANDLED, /* No handler found for the IO=2E */ > +}; > + > +typedef enum io_state (*mmio_read_t)(struct vcpu *v, mmio_info_t *info, > + register_t *r); > +typedef enum io_state (*mmio_write_t)(struct vcpu *v, mmio_info_t *info= , > + register_t r); > + > +struct mmio_handler_ops { > + mmio_read_t read; > + mmio_write_t write; > +}; > + > +struct mmio_handler { > + paddr_t addr; > + paddr_t size; > + const struct mmio_handler_ops *ops; > +}; > + > +struct vmmio { > + unsigned int num_entries; > + unsigned int max_num_entries; > + rwlock_t lock; > + struct mmio_handler *handlers; > +}; > + > +enum io_state try_handle_mmio(mmio_info_t *info); > +void register_mmio_handler(struct domain *d, > + const struct mmio_handler_ops *ops, > + paddr_t addr, paddr_t size); > +int domain_io_init(struct domain *d, unsigned int max_count); > +void domain_io_free(struct domain *d); > + > +#endif /* RISCV_MMIO_H */ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/riscv/mmio=2Ec b/xen/arch/riscv/mmio=2Ec > new file mode 100644 > index 0000000000=2E=2E7d56bc8b27 > --- /dev/null > +++ b/xen/arch/riscv/mmio=2Ec > @@ -0,0 +1,145 @@ > +/* SPDX-License-Identifier: GPL-2=2E0-or-later */ Should be GPL-2=2E0-only=2E > +/* > + * Copyright (C) Vates > + */ Why have you included a copyright notice here, but not in the other files? I don=E2=80=99t know if you can keep it, but I just wanted to point= out that there are other files where this type of copyright notice includes the year=2E --=20 Baptiste Le Duc -- Baptiste Le Duc | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates = solutions web: https://vates=2Etech ---=Part.2039.d3a9d985718257a9.19fec268bf5.69e8bf0c8ca29046=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 14:51:59 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 14:51:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387569.1628833 (Exim 4.92) (envelope-from ) id 1wtRLt-0005ha-IH; Mon, 10 Aug 2026 14:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387569.1628833; Mon, 10 Aug 2026 14:51:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtRLt-0005hT-Ff; Mon, 10 Aug 2026 14:51:45 +0000 Received: by outflank-mailman (input) for mailman id 1387569; Mon, 10 Aug 2026 14:51:44 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtRLs-0005hN-6B for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 14:51:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtRLr-006Ghm-JO for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:51:43 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79e56c-bab6-0a2a0a5309dd-0a2a4506bcdc-38 for ; Mon, 10 Aug 2026 16:51:43 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79e57f-195a-0a2a45060019-b9ff1c22a46d-3 for ; Mon, 10 Aug 2026 16:51:43 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec2874e4000e099.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 14:51:42 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 8D79083700; Mon, 10 Aug 2026 16:51:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=oh2DgB3SGnmWnc2owIE3IXRTnj2Ospz9Wo6bD61coCI=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=Yxq0k2NkBG/y6/LnMmUtoLQlYXSzEbNlFcxyWo2V81C4swoHO7E1K1e/ewl0IK+wZvPuzb/87 5aKTb9qtTBt9+ssfl9/MR1NZFx4/BHMe1eQ73DTZu/rpHDxMgxYiXpSqfeLIarEdI9smRHlAHP0 qAQzBEcXhmR7U9MHoM3/2POMhwpJcurI5kfM8EpAHneFU1IQ1JMR81A/ZXprYVaIufmn2DEh9qP 8NTUyczUE/z+Vergwi7OeHFlNTPGhDQGDF+51zxKj1VF/zUWxJCY++9I8n2pRrKJ2oVmxpXO2ln fJZ/i0wo8U+PIRluzvEC5klb10qMNxFEevz/M8HzcKwg== X-Zone-Loop: 7c266bd4a239a061645f15bae85c0dec40ef71421f58 x-campaign-type: default x-transaction-id: f8fdb848-13b6-4ca6-9b1c-6c2355ef87f4 x-swg-uid: 01-ea7f7148-5ec1-4575-a726-5ff57c40b051 X-Mailer: Sweego Message-ID: <1786373502.8631fc262581453bbf619ec5b2062170.19fec2874e4000e099@vates.tech> x-swg-bid: 1786373502.8631fc262581453bbf619ec5b2062170.19fec2874e4000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Subject: Re: [PATCH v1 03/17] xen/riscv: add missing APLIC register offsets, masks to asm/aplic.h From: Baptiste Le Duc To: Oleksii Kurochko Cc: Baptiste Le Duc , xen-devel@lists.xenproject.org, Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: References: <1786369533.8631fc262581453bbf619ec5b2062170.19febebe536000e099@vates.tech> Date: Mon, 10 Aug 2026 16:51:36 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786373501; l=1226; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=pX3pIsTRAJ2uAndkfmMJyp9wTrk95aLN1X+NZ0w8Kss=; b=EaiCKGGunu/86m+j2fMlnTVPNsbjQbBrvKECZnFYfMrCb5ZStVfupaQcICKo6v08UUMPM2aiq aM+mRefYqwPA1RKVqZmNr3pXWumVMgLRI8N3JIY3ZYQouTr5YdwZvWp X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.203c.e671b9931e088f51.19fec287342.7804da051366af2a=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786373501762 X-purgate-ID: tlsNG-16d1c6/1786373503-FEA7477B-10D815E7/0/0 X-purgate-type: clean X-purgate-size: 1642 ---=Part.203c.e671b9931e088f51.19fec287342.7804da051366af2a=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2026-08-10 16:45:23+02:00, Oleksii Kurochko wrote: > On 8/10/26 3:45 PM, Baptiste Le Duc wrote: >=20 > >> These definitions are required for correct decoding of APLIC MMIO > >=20 > > _REG stands for memory-mapped control "region" as explained in spec? I= f > > yes, it'd be better to add a comment=2E >=20 > Yes, it is a mask that allows us to get the offsets for the registers of= =20 > an interrupt domain=E2=80=99s memory-mapped control region=2E >=20 > IMO, if the problem is with the name of the macro, it would be better to= =20 > use a clearer name instead of adding a comment=2E For example,=20 > `APLIC_CTRL_REGION_OFFSET_MASK` sounds self-explanatory to me=2E I think the rename of the macro is enough=2E Lets keep this: #define APLIC_CTRL_REGION_OFFSET_MASK 0x3fff >=20 > If you=E2=80=99re still not happy with the suggested name and it isn't= =20 > self-explanatory, then: >=20 > /* > * Offsets of the registers of an interrupt domain's memory-mapped cont= rol > * region, which is APLIC_MIN_SIZE bytes large=2E > */ > #define APLIC_CTRL_REGION_OFFSET_MASK 0x3fff >=20 > Alternatively, I could keep the old name (APLIC_REG_OFFSET_MASK) and use= =20 > the suggested comment=2E >=20 > Which option do you prefer? >=20 > ~ Oleksii -- Baptiste Le Duc | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates = solutions web: https://vates=2Etech ---=Part.203c.e671b9931e088f51.19fec287342.7804da051366af2a=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 15:05:04 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 15:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387579.1628843 (Exim 4.92) (envelope-from ) id 1wtRYW-0007b8-KA; Mon, 10 Aug 2026 15:04:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387579.1628843; Mon, 10 Aug 2026 15:04:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtRYW-0007b1-H2; Mon, 10 Aug 2026 15:04:48 +0000 Received: by outflank-mailman (input) for mailman id 1387579; Mon, 10 Aug 2026 15:04:46 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtRYU-0007av-Oh for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:04:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtRYT-003qFa-O0 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 17:04:45 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79e883-8faa-0a2a0a5109dd-0a2a450aafe0-48 for ; Mon, 10 Aug 2026 17:04:45 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79e88d-f2d2-0a2a450a0019-d1558029a806-3 for ; Mon, 10 Aug 2026 17:04:45 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso31576355e9.0 for ; Mon, 10 Aug 2026 08:04:45 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995420bd1csm441680165e9.3.2026.08.10.08.04.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 08:04:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786374285; x=1786979085; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=skTb9mvllojkrjztHhBL1PK1ndFafhM1LatERGnQ4Fg=; b=qKFRnzlqlpR0qTaa6/gwyMv89LUAPHW5ZIyNT0eLlaGIQfpZ2YgKYyWxnWXW4TZyaA zOK9rdcumyTFR+nWjN2zhRXhDhXeHj4bC8Z9nz11IS1hpOaytiB2gVweAhGVDAWv4Cvt Tbl14Rk54e8tT8bHFIoMZF5eQo6TdEQXhJw8tMqL5lrm7Hiz2ibtcBtO4WNlRuJfWHOX 3BApc2uI24RgDIJ+MBm9LJ29Fsa4KcOSR9zHf8rbb/qRKhmEJwjTLXejIBllKx9oEIUl IbB9FOKtdWKgQg6nqQDaF9yB0LbTGWr8n5X3KoL14dFtcqIUtpI+aA6GcUJPIo7EB46P Q8wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786374285; x=1786979085; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=skTb9mvllojkrjztHhBL1PK1ndFafhM1LatERGnQ4Fg=; b=IU/egJf5m3pwV6q/MlELzaePYE+6yZL5ujErFBNVzPo+OMeMo4tl+rxWXNc0E9AWYi xUQJ8siqOQMVfn2INGp2Y67Zo5lXXwpg6atVi0TMTBZcdd5FQkaL922GdIi7jE7OAnaT ZubFlPixz9pcNECRixjopOKDtIlokH/WcLw1UFb2fArPKY5QxMLdt+NC10aeBaeRUKTO CHxtNM6bU4Dooz0jj7hN+bg0S/bhf5o8kDZALRSUKEsIREf/Gmv284Uy0UVwaPrl3gCy u+qGUPGt5TBA5vQ6J9Ppir2ZjEQCeH+0FBvWx3/3hu2eclB9eB5EDW5a8ESd2wzMn7kW mInA== X-Gm-Message-State: AOJu0YzG+o8i3GhWOzfMEfGYVFm/mtQwIe0sBkeRMCDal4L5Tm9R2fR3 2K2skqj9tlp0VxNgM51+7X973HM1Y163M4TuxGbvU6cr8NLPf+llRECX X-Gm-Gg: AR+sD12CAbceWdfhQqI/klZ/4Wp9RHeOQOljFw44b0iAci/W9Wu2jibJ4GC6Pmn9Jt2 2PeMwLHJH+iD15zFeOm0N9ngqa53aqRVC/llJDcJvv6TSLBVUCvEUN3Z/O7ZMN9g+LV9Uu1Jx7n 93uE8stYZpTw9d9sx1v6reUNdHcJTNY9EB/qCZFrPURaKWqFCHyfMg8Ig760Xv0VL7bUQl4VLSM z66m39YL5R39tDdATvuDeOb6oK1FT+2f6t5JZUh6T6TvNubpdham5DR+2wc+MZVg1QezDM4KfGZ 0T3LqkKfMqDpnT+UfC4M8XxgfHR45aRZrh6XGLU8vidr3+2yulLVcCaZiOyAFf2JFQCmevZdDjp U1k3kuZPjabkBvU7ySeiXQFG6ucAJhClAi5MDsEaO6Mh+RmTRw/wELwp+BxpvbPp2ViG/7kX6me ZixoA7LE9QZof79Uxz/dwi39LhW/4d8/FGAgGHgqY9x8aUX8WlX+pe1HdI6joR805Eio6JpupK3 lWQ0I3omNwIAmYIlm502FDeF9InLrz+el00MomdRac= X-Received: by 2002:a05:600c:45d5:b0:495:69eb:27d3 with SMTP id 5b1f17b1804b1-4996247a563mr23707995e9.8.1786374284985; Mon, 10 Aug 2026 08:04:44 -0700 (PDT) Message-ID: <293a08d8-ff96-4726-b713-bc2d14973ca4@gmail.com> Date: Mon, 10 Aug 2026 17:04:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/17] xen/riscv: add basic VGEIN management for AIA guests To: Baptiste Le Duc Cc: xen-devel@lists.xenproject.org, Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini References: <1786368748.8631fc262581453bbf619ec5b2062170.19febdfed5f000e099@vates.tech> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <1786368748.8631fc262581453bbf619ec5b2062170.19febdfed5f000e099@vates.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-4011c0/1786374285-53CD3CFC-7EC80455/10/73395122804 X-purgate-type: spam X-purgate-size: 9889 On 8/10/26 3:32 PM, Baptiste Le Duc wrote: >> It was decided to add support for IMSIC from the start instead of having APLIC >> operate in direct delivery mode, as it requires a trap-and-emulation approach, >> which is not optimal from a performance standpoint. >> >> AIA provides a hardware-accelerated mechanism for delivering external >> interrupts to domains via "guest interrupt files" located in IMSIC. >> A single physical hart can implement multiple such files (up to GEILEN), >> allowing several virtual harts to receive interrupts directly from hardware. >> >> Introduce per-CPU tracking of guest interrupt file identifiers (VGEIN) >> for systems implementing AIA specification. Each CPU maintains >> a bitmap describing which guest interrupt files are currently in use. >> >> Add helpers to initialize the bitmap based on the number of available >> guest interrupt files (GEILEN), assign a VGEIN to a vCPU, and release it >> when no longer needed. When assigning a VGEIN, the corresponding value >> is written to the VGEIN field of the guest hstatus register so that >> VS-level external interrupts are delivered from the selected interrupt >> file. >> >> Signed-off-by: Oleksii Kurochko >> >> diff --git a/xen/arch/riscv/aia.c b/xen/arch/riscv/aia.c >> index e31c9c2d24..4f7f46f58f 100644 >> --- a/xen/arch/riscv/aia.c >> +++ b/xen/arch/riscv/aia.c >> @@ -1,11 +1,33 @@ >> /* SPDX-License-Identifier: GPL-2.0-only */ >> >> +#include >> +#include >> #include >> #include > > Add a #include here instead of in aia.h. Sorry, but I’m a little confused here. doesn’t include . > >> #include >> +#include >> +#include >> #include >> +#include >> >> +#include >> #include >> +#include >> +#include >> + >> +struct vgein_ctrl { >> + unsigned long bmp; >> + spinlock_t lock; >> + struct vcpu **owners; >> + /* The least-significant bits are implemented first, apart from bit 0 */ >> + unsigned int geilen; >> +}; >> + >> +/* >> + * VGEIN control structure for each physical CPU to track which VS (guest) >> + * interrupt file IDs are in use. >> + */ >> +static DEFINE_PER_CPU(struct vgein_ctrl, vgein); >> >> static bool __ro_after_init _aia_usable; >> >> @@ -14,10 +36,133 @@ bool aia_usable(void) >> return _aia_usable; >> } >> >> +static int vgein_init(unsigned int cpu) > > Could we call this function with a different cpu arg than the current > one running? If yes, we would read hgeie of not the cpu we wanted. Considering that it touches the CSR_HGIEI register, it can only be called on the currently running CPU. That’s why I suggested in one of my replies to Jan B. that I would drop the argument altogether for this function. >> +{ >> + struct vgein_ctrl *vgein = &per_cpu(vgein, cpu); >> + >> + csr_write(CSR_HGEIE, -1UL); >> + vgein->geilen = flsl(csr_read(CSR_HGEIE) >> 1); >> + csr_write(CSR_HGEIE, 0); >> + >> + printk("cpu%u.geilen=%u\n", cpu, vgein->geilen); > >> + >> + if ( !vgein->geilen ) >> + return -EOPNOTSUPP; >> + >> + vgein->owners = xvzalloc_array(struct vcpu *, vgein->geilen); >> + if ( !vgein->owners ) >> + return -ENOMEM; >> + >> + spin_lock_init(&vgein->lock); >> + >> + return 0; >> +} >> + >> +static int cf_check cpu_callback(struct notifier_block *nfb, unsigned long action, >> + void *hcpu) >> +{ >> + unsigned int cpu = (unsigned long)hcpu; >> + int rc = 0; >> + >> + switch ( action ) >> + { >> + case CPU_STARTING: >> + rc = vgein_init(cpu); >> + if ( rc ) >> + printk("AIA: failed to init vgein for CPU%u\n", cpu); >> + break; >> + } >> + >> + return notifier_from_errno(rc); >> +} >> + >> +static struct notifier_block cpu_nfb = { >> + .notifier_call = cpu_callback, >> +}; >> + >> void __init aia_init(void) >> { >> + int rc; >> + >> if ( !riscv_isa_extension_available(NULL, RISCV_ISA_EXT_ssaia) ) >> + { >> + dprintk(XENLOG_WARNING, "SSAIA isn't present in riscv,isa\n"); >> return; >> + } >> + >> + if ( (rc = vgein_init(0)) ) > > Why `0` rather than smp_processor_id()? As described above vgein_init() reads CSR_HGEIE > of the current hart but stores the result into per_cpu(vgein, cpu), so the two > must agree. aia_init() is executed on boot cpu only so it uses 0 as Xen boot cpu is always 0. But it won't be an issue anymore as I mentioned above an argument of vgein_init() will be dropped anyway so it will be guaranteed that a correct CPU is used. > >> + { >> + dprintk(XENLOG_ERR, "vgein_init() failed: %d\n", rc); >> + return; >> + } >> >> _aia_usable = true; >> + >> + register_cpu_notifier(&cpu_nfb); >> +} >> + >> +unsigned int vgein_assign(struct vcpu *v) >> +{ >> + unsigned int vgein_id; >> + struct vgein_ctrl *vgein = &per_cpu(vgein, v->processor); > > What happens if v->processor change between vgein_assign() and > vgein_release? Because it seems in such case the release will hit a > different pCPU's bitmap: the original bit will leak and an unrelated > CPU's bit will be cleared under another vCPU's feet. So, if v->processor changes between the calls to vgein_assign() and vgein_release(), it means that migration has happened. If migration has happened, then it is the responsibility of the migration code to properly assign the new vgein and release the previous one. All other cases where vgein_release() is called are when the vCPU is dying, so everything is okay there as migration cannot happen. > >> + unsigned long *bmp = &vgein->bmp; >> + unsigned long flags; >> + >> + if ( !vgein->geilen ) >> + return 0; >> + >> + spin_lock_irqsave(&vgein->lock, flags); >> + /* >> + * The vgein_id shouldn't be zero, as it will indicate that no guest >> + * external interrupt source is selected for VS-level external interrupts >> + * according to RISC-V privileged spec: >> + * Hypervisor Status Register (hstatus) in RISC-V privileged spec: >> + * >> + * The VGEIN (Virtual Guest External Interrupt Number) field selects >> + * a guest external interrupt source for VS-level external interrupts. >> + * VGEIN is a WLRL field that must be able to hold values between zero >> + * and the maximum guest external interrupt number (known as GEILEN), >> + * inclusive. >> + * When VGEIN=0, no guest external interrupt source is selected for >> + * VS-level external interrupts. >> + * >> + * So start to search from bit number 1. >> + */ >> + vgein_id = find_next_zero_bit(bmp, vgein->geilen + 1, 1); >> + >> + if ( vgein_id > vgein->geilen ) >> + vgein_id = 0; >> + else >> + { > > Potential index error, because above you did: > > vgein->owners = xvzalloc_array(struct vcpu*, vgein->geilen) > > so valid index are 0...(vgein->geilen-1). Adopt either > one of those two options: > 1. vgein->owners[vgein_id-1] = v > 2. vgein->owners = xvzalloc_array(struct vcpu *, vgein->geilen+1) in > vgein_init() > > I think `2` could be better to have vgein->owners replicated hgeie CSR but > it would left the first entry read-only. I've found that too during prepare a reply to Jan B. so fixed it already in v2. I've decided to go with what you suggested in 2. > >> + __set_bit(vgein_id, bmp); >> + vgein->owners[vgein_id] = v; >> + } >> + >> + spin_unlock_irqrestore(&vgein->lock, flags); >> + >> +#ifdef VGEIN_DEBUG > > VGEIN_DEBUG is not defined anywhere in the patch, please use > gdprintk(XENLOG_DEBUG, ...) directly, or drop this branch. It is intentionally not defined. If a user needs additional VGEIN debug information, they should define it themselves, as it can produce a pretty large amount of logs due to, for example, the migration process, where vgein_assign() and vgein_release() are used quite actively. > >> + gprintk(XENLOG_DEBUG, "%s: %pv: vgein_id(%u), xen_cpu%u_bmp=%#lx\n", >> + __func__, v, vgein_id, v->processor, *bmp); >> +#endif >> + >> + return vgein_id; >> +} >> + >> +void vgein_release(struct vcpu *v, unsigned int vgein_id) >> +{ >> + unsigned long flags; >> + struct vgein_ctrl *vgein = &per_cpu(vgein, v->processor); >> + >> + if ( !vgein_id ) >> + return; >> + >> + spin_lock_irqsave(&vgein->lock, flags); >> + __clear_bit(vgein_id, &vgein->bmp); >> + vgein->owners[vgein_id] = NULL; >> + spin_unlock_irqrestore(&vgein->lock, flags); >> + >> +#ifdef VGEIN_DEBUG >> + gprintk(XENLOG_DEBUG, "%s: vgein_id(%u), xen_cpu%u_bmp=%#lx\n", >> + __func__, vgein_id, v->processor, vgein->bmp); >> +#endif >> } >> diff --git a/xen/arch/riscv/include/asm/aia.h b/xen/arch/riscv/include/asm/aia.h >> index aaa4bf91fc..c67be0069a 100644 >> --- a/xen/arch/riscv/include/asm/aia.h >> +++ b/xen/arch/riscv/include/asm/aia.h >> @@ -3,8 +3,16 @@ >> #ifndef RISCV_AIA_H >> #define RISCV_AIA_H >> >> +#include > > asm/aia.h needs neither nor as struct > vgein_ctrl and the per-CPU variable both live in aia.c. Please drop them > and add in aia.c > Yes, it is redundant code that I missed removing. I’ve already noticed it and removed it in v2. Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Aug 10 15:37:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 15:37:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387594.1628853 (Exim 4.92) (envelope-from ) id 1wtS3g-00040L-1D; Mon, 10 Aug 2026 15:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387594.1628853; Mon, 10 Aug 2026 15:36:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtS3f-00040D-TQ; Mon, 10 Aug 2026 15:36:59 +0000 Received: by outflank-mailman (input) for mailman id 1387594; Mon, 10 Aug 2026 15:36:59 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtS3f-000406-7K for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:36:59 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtS3e-0008Z4-KM for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 17:36:58 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f00c-8faa-0a2a0a5109dd-0a2a4502d55e-26 for ; Mon, 10 Aug 2026 17:36:58 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f01a-6ca4-0a2a45020019-d1558034e947-3 for ; Mon, 10 Aug 2026 17:36:58 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4955de8797cso13750495e9.3 for ; Mon, 10 Aug 2026 08:36:58 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499740c1e65sm1464585e9.4.2026.08.10.08.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 08:36:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786376218; x=1786981018; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Nt96e5JrhJ37b+v36cltLHlfFI5f1cPCJ8WVk3Ws90Q=; b=ApNhojU0wAfZm7igbZOBXK7zC4xOddYjslB/BTguXJAU4xQpmOcU90sECLaYlXTHCN qzQjJGfUDaFom9zR20PoLTp48pMZml1TvZegtTKEQCObqtK86OoOT/0yE7L02Wti7GjM oIYi5zb1BB/ktdpyrZNjDLykBkFj7NdbVkGvi7TA/cqYt6CorJhmBBPK4AMpJTgSuTkQ ctz+0CVhByWpKbxX+XZ3R/MspZ3Xv/Ot+UK8hQafxV5zy72qNpZNFbxwTYyKw7d4lhBK e92LxYhFozDC1SqBRzLuwe5Yr2vkqQJ5bSNmWx9wiQE+tChOBYjTo2W+bkkqYI5KHD4N 9fng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786376218; x=1786981018; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Nt96e5JrhJ37b+v36cltLHlfFI5f1cPCJ8WVk3Ws90Q=; b=nRoHgNcZGldvNCB7f5FPBPLr4vsjes6q0/vDOSvrUOn6kGTR40PbJRA5j3HOt1j/lx pEcqQGj/wKs3lXfSu2uhZ41rZLxQleUtJNgzZvHu6IqjV8Ya5DF+x4yn82B0a8wO20fA 0ThXlWaZe051tDpSV7fWxKXwz8gwbAh9gjM2NYD7t1ohMfwkfDlSxWlWEsa3aaz2Q163 YttGbYHWgHZnsx077TLJkro8lpFuyacBju1uMz2ZRWz8GzX1bmZ8BYWkvjmEyImEXJcV +0foGGuMVPFpY6Yd0NODK37+NXkrOZjmnK4wsHIGZ+KBo/RNp5V05pgIKTKhFnIoNo6T 6WJA== X-Gm-Message-State: AOJu0YzzsKdd76Bfz/Zq6QquEh0yfBwFwQxmRTciNGn3YzgG+lRh2+MD r3doU7+5NWnbSre/uwI6l76IfwxxEBaNhTxOcmAe5m7F7I6U50NHei1p X-Gm-Gg: AR+sD10VpZDdjufcEkch5j3S9M2/cTnY2Em1HbAQ44vvNnwVgD6GdKWqmZd6C1SDmF3 yQ2jMLMz+kH+GozYcx8Mm+X899NXXhQ5u7pAC4c/rIrReBprhqRsdvUGmQhsKlASigQ5V90C252 tqWuD/kB5R9VjENCujbEQis9qtVHRZm2tbTz2PEBWZKiG0yC8+MM3Cyn3CvozgtFsoD8OG/jdZC trWWOTNEj5SAAJkL/cML6jA6BVyCruh3f+ol+S7PmKn3zKiVrgvsNveVcQXiaHvGLmCBKya1SNm UdmQPMchWfm6oaBbukCznaMEy/yEPrPFvU+pt7ZzXo9AOhPsSG/UwQGjejbA12qNp8zz8Lra1nt tASZECf3rFnXs9Aqco4MYjLGoUbv3fQQmjPf0jx9on8RorYyJLdPf4YFDOIp+cJrsZ+cbbV4qp+ 3egs0OXSVBbAunHKpZjVN2UE/EJEpxKI+Adg7XXYRu/jf6fU1biCExD9dGCcLSjZGkGgInaJXA/ 2AuAq+Mu6gju0Vm6pxCPWebUkaPnNKrxAU9eeFMFEg= X-Received: by 2002:a05:600c:c050:b0:493:a613:56b2 with SMTP id 5b1f17b1804b1-4995e08e537mr216929085e9.8.1786376217831; Mon, 10 Aug 2026 08:36:57 -0700 (PDT) Message-ID: <05283ea0-de82-4160-a3f9-5fc1292a20a5@gmail.com> Date: Mon, 10 Aug 2026 17:36:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/17] xen/riscv: introduce device-agnostic MMIO emulation dispatch To: Baptiste Le Duc Cc: xen-devel@lists.xenproject.org, Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini References: <1786373377.8631fc262581453bbf619ec5b2062170.19fec268e07000e099@vates.tech> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <1786373377.8631fc262581453bbf619ec5b2062170.19fec268e07000e099@vates.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1786376218-666B72AC-03B528EE/10/73395122804 X-purgate-type: spam X-purgate-size: 2760 On 8/10/26 4:49 PM, Baptiste Le Duc wrote: >> diff --git a/xen/arch/riscv/include/asm/mmio.h b/xen/arch/riscv/include/asm/mmio.h >> new file mode 100644 >> index 0000000000..18df1133e6 >> --- /dev/null >> +++ b/xen/arch/riscv/include/asm/mmio.h >> @@ -0,0 +1,63 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > According to coding style, it should be GPL-2.0-only. Could you please point me to the line in the coding style document where this is mentioned? If you are referring to: New files should start with a single-line SPDX comment to express the license, e.g.: /* SPDX-License-Identifier: GPL-2.0-only */ See LICENSES/ for a list of licenses and SPDX tags currently used. Then my understanding is that /* SPDX-License-Identifier: GPL-2.0-only */ is used only as an example, and I can choose any license from LICENSES/. There, it is mentioned: Valid-License-Identifier: LGPL-2.0-only Valid-License-Identifier: LGPL-2.0-or-later I am pretty sure that I am free to choose any license that does not conflict with the other licenses used in the project. >> +#ifndef RISCV_MMIO_H >> +#define RISCV_MMIO_H >> + >> +#include >> +#include >> + >> +#define MAX_IO_HANDLER 16 >> + >> +typedef struct { >> + paddr_t gpa; >> + unsigned int len; /* access width in bytes (1, 2, 4, 8) */ >> + bool is_write; >> + register_t data; /* store: value to write; load: value read (set by handler) */ > > Nit: line too long (85) I will apply that. Actually I've already fixed that by putting the comment above: /* store: value to write; load: value read (set by handler) */ register_t data; >> diff --git a/xen/arch/riscv/mmio.c b/xen/arch/riscv/mmio.c >> new file mode 100644 >> index 0000000000..7d56bc8b27 >> --- /dev/null >> +++ b/xen/arch/riscv/mmio.c >> @@ -0,0 +1,145 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ > Should be GPL-2.0-only. Regarding license I've wrote a comment above so lets continue discussion there. >> +/* >> + * Copyright (C) Vates >> + */ > Why have you included a copyright notice here, but not in the other > files? So I just decided to do that for new files as I am not using corporate e-mail. I don’t know if you can keep it, Good point, I have to ask then someone from our legal department... but I just wanted to point out > that there are other files where this type of copyright notice includes > the year. > Before, I used to include the year, but someone pointed out (or perhaps I misunderstood) that there isn’t much point in including it and that it is enough to have just (c) . Thanks. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Aug 10 15:40:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 15:40:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387602.1628860 (Exim 4.92) (envelope-from ) id 1wtS75-0005l9-G8; Mon, 10 Aug 2026 15:40:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387602.1628860; Mon, 10 Aug 2026 15:40:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtS75-0005l2-DJ; Mon, 10 Aug 2026 15:40:31 +0000 Received: by outflank-mailman (input) for mailman id 1387602; Mon, 10 Aug 2026 15:40:30 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtS74-0005kw-5v for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:40:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtS73-0098Dt-33 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 17:40:29 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f0eb-8faa-0a2a0a5109dd-0a2a4507aa5c-6 for ; Mon, 10 Aug 2026 17:40:28 +0200 Received: from [52.101.57.56] (helo=BN8PR05CU002.outbound.protection.outlook.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f0eb-b4ea-0a2a45070019-34653938efdf-3 for ; Mon, 10 Aug 2026 17:40:28 +0200 Received: from DM4PR12MB6472.namprd12.prod.outlook.com (2603:10b6:8:bc::7) by LV3PR12MB9439.namprd12.prod.outlook.com (2603:10b6:408:20e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 15:40:25 +0000 Received: from DM4PR12MB6472.namprd12.prod.outlook.com ([fe80::4a4d:4208:3862:fb7a]) by DM4PR12MB6472.namprd12.prod.outlook.com ([fe80::4a4d:4208:3862:fb7a%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 15:40:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tiipi1qKGKHbHC7MFEX9/lXtkyks5yGkPFq5xazp5UdaqNu+Sj78hKxTLEGmbVYs9XJ9KlbWHA9hZZu8DIW5YLHXfHJiaz8FhKSGAY2XnU9YBbkysZxBdqGA4Z2RM5iKizLXyN3j9r0ijfDHKbGbOTf4NGw+ampk4ZHqc3qI73WTHXQ2adzuPFF0LY5nnQumzlUpFPf2bV/ZLjivgPSa34DwB1UcfBJpz/pRPVxPvaemdMIF0EB4jRK2DZpx4HoiAoZOAxEz00VDedXGpM2ZrThwv4IfACmayqR7D1YcozRWLMS0vDxBNc6BiyVeBtAm2xodSl5fHo9AMGPj/q6CxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JLQH6i+1RsBXNMnLQnCymGu9+MWr54FLe3zoM/hw45o=; b=fZy6xoGPH9CD0a3bqTCNdbPARgjA9Htu5NRUzuaSOABpzH2AUMGxFj7gpYTMNCpzUMwzyXHrSwxVhzVDQPs7moh7ZbYiv/QQgIbnDyfqAGJZvS3ehtTHniZZgQn0oBYcX4zY/YqBdRS8Gkg95SL680PsoaZsEOWe+BsmvSSOSHtyn0dTKayI5Ix+QQSYCk/2FAGO8oaasuJfJAEFCC6TKd3QJDsQ9SiU5H+mPK8luEu5aXyG0u7FYVi0UnAkzmp8hL2hahRaDe5dXCB9eqm1sXhQoSm4EljRSMvZn455UhLPS1OCc+CEoqROwKPy7AtnKRANe0ffudUXzVw43GIqzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLQH6i+1RsBXNMnLQnCymGu9+MWr54FLe3zoM/hw45o=; b=tfP61KIBOa2spXuLjZipld4ySrKWt2J4KTSCgACDp8ajq47l+tJx6ZmqQc8UwPw6FQrqqbR+7xPvOzMQAUrqbKzsTxIye4dMRj/52xB2Go1NBYOqYE4OCkoFZ1qhunpdr9hdFOzJWtJtUygWgVNCsGqg7pG2lkSoyBBfq3gqJHM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <3a3267a3-01e9-419c-9d82-dd4867056732@amd.com> Date: Mon, 10 Aug 2026 17:40:18 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] x86/pci: prevent cross-device accesses in pci_mmcfg_{read,write}() To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Teddy Astie References: <20260806152619.23881-1-roger@xenproject.org> <20260806152619.23881-2-roger@xenproject.org> Content-Language: en-US From: Stewart Hildebrand In-Reply-To: <20260806152619.23881-2-roger@xenproject.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CPCP307CA0007.DNKP307.PROD.OUTLOOK.COM (2603:10a6:380::7) To DM4PR12MB6472.namprd12.prod.outlook.com (2603:10b6:8:bc::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6472:EE_|LV3PR12MB9439:EE_ X-MS-Office365-Filtering-Correlation-Id: b4a66409-c7e4-45ba-42c5-08def6f5b0d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|23010399003|18002099003|22082099003|11063799006|56012099006|3023799007|4143699003|10067099003; X-Microsoft-Antispam-Message-Info: D5oSoCxy9edBa7t7iaUrgk6Zm0+ljEXAMMsEAhSWFio7GSTq/DNkrN9g26ibwGicrkuf/iK7FzqocPPDtOJq6NizMAxlHP+lPFgf6cSZE2kpIm6JYBorfGNYRt3T/s9fpX7CmmFIjQRTo/KpXHYUgYVwc7s9S2i+pu/ngHekS6bNgI7eekVZAaZrLBSoNmdxaTCwNnv714pmG3yia+pr6sxvVWNINiXnePs1ZQ9R9K5wxgiP/HZ/BjG4Lys+rEEpZzINgKW8H7PRci4elopOvO77RgJ8LSLKX6hHMkZ70zmmTQuQmilcoK3OkrTDghrI/Bh8J4UfqyFgmGTxVhSf4xxKNg657JGUmfrl4lTVhpJ00QSb+l907TLYpgHCR6myekamvlpJ75ZLcrusBVar2mzv51CQ1pGVyr0Ue3l8ADZlvTmXed09H6V1wcqc4b64Nwq3ssKL5f8UIyBUpEeNiBsGiN6ZpyZYY1CDPZSsAci6l3XfNNLGl6OTNsVatx3pE0OO0XIyFSNbiXj40OFld4jw/cpakBLqW6XcxDyCy7g8Vtnj5vgAgLVFcCEhiNf1ghW+vaBhQstTD5vEPGxv0QL0UK0b31dhmLkk6RagbUCgIBlbcgjrYMnizYsrE+bI6x8q7ZbOmbU+jxxbC26SfSaX0h3STOyd4nKC+jv2uVk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6472.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(3023799007)(4143699003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFhnSUtTaVFnMU5EeFhNUzMzbklsSDBJOHBVcHpNQVBNOElCSWtaM0wzb2Vw?= =?utf-8?B?VVVoVlliL0lRckxnbnlPTTBnbThrV053bWQrbmhPSi9KQzI1K2lsVU9rRU9Y?= =?utf-8?B?dkNKTTRwVlAvQ202dUVUR1ozZU5GNU1rVExYY0FrRjdObGk2K3lwa0tSK1Fv?= =?utf-8?B?RzZVYnpNdFhPT1F1bUZmakdFODdqM2xMd000S1U2c2dGODdCb3VEbVpUUU1Q?= =?utf-8?B?UkZtYkM0dVRpKzRoUE5EbDQvTkp3MVBoUk84MVVaOGNwT1UyMU9DRWZxY1NT?= =?utf-8?B?YmZZa2ZIUzVUOTNCbVVoM1AxejJReEc5NzFnOUVENFIwdlpGMXRDS3FTTHJp?= =?utf-8?B?c3hJZlc1bWE4cmdOWDh4ZnRUbDM2d2lLZ1lIeFpjR0FleVdEb28wdU96dzJu?= =?utf-8?B?eWJocFBJV2xFSHErWkM1Q2h0emZ3UnVkR2JyWWF0VTZTTDF6UHBqN1Z3Zmpz?= =?utf-8?B?ZGFUWjlhQ3FyV0I5cWUxeVpEcEZ4Z0N6Ykdnay9oQ2xFb1ZtSmp0NHYwVVBV?= =?utf-8?B?MExtUHFWVnNNQk8zc2kvUENOV0dxMHVnNVJncXRDd1ZjbnJyRlZhWXNBYUUv?= =?utf-8?B?cFEzZUYveHJGbWFvLzNPR0l5VVhvTnphcmdQd2ZqNFN2Z2p4cTBoNm5IWE9D?= =?utf-8?B?S1lpSG9WTXRzNDBQekpDd090MXBCeXU5S2gzejk0YmdNWjZoNXBoTWNYU1d3?= =?utf-8?B?Qis0SnFySThZakdITkZ0NzVoT3VHbE1WdFcxTkVPdURpNlN4MEZPb3gvMGhY?= =?utf-8?B?aHF4dFMwNmlSTmh5Yk91RjlMRzE2NkdGMFNCWWZNTzF3dUU3RFBBdk5QQTBt?= =?utf-8?B?THJHbXZWL3paMjBRWGo3VW1KN2xvRlArY2VhSmZRQzZLeUpUSjJJQmRuWXBk?= =?utf-8?B?TGNMbGF3SVdsRDhnWkRLVWtRVmRQaWNoN25XYU1LQ0dDM096SkNsb1pQQTA0?= =?utf-8?B?bjlkb0dyQmJ0eDluRnF5WDF3S2FKcE9rZzB2SC9Gcmk2RkhOWVlZb0E2VVg2?= =?utf-8?B?TTdqbmwyY29tUjNJeVh1RThjRzNaa3FVaVZ1bWVpcWh3VDRRWXVvSnI1azdj?= =?utf-8?B?em0wK0hlTUhDYlp0TkRDL3lvbXZjY2ZodlpUZUlBSDNTc2d5dUhGaUlIZVdn?= =?utf-8?B?cDJxZGRic1F2M1FEWUZDK3pDR3QvVmsydTFveEg2RmVTTVlNdHpQQWpVcldH?= =?utf-8?B?dGVleWZIRHkzNVJ2YmphMEdiTFV2cWdTNWQyVDM4SEY3eUpObm0rWWJySnpm?= =?utf-8?B?WGZ5OElMQkhNbW52azVXbUVvSmpTSGJSR0pRSzNZUnN2a3U5TlhqOHpDU1Nu?= =?utf-8?B?M29RZlk3aVZ2Wkc5eUxlTWFwMDl6RFYwbjFKQmFiMlJtRXJORkFvd2pDbzUz?= =?utf-8?B?ZnlISW1scHhmVGFNVzE5L2JkZUVMalJTdkdMVzI3WFFOdFhJWVRoWm9WbCt1?= =?utf-8?B?UTl4R3lYMVJpeVBuNU1rNi81bDFDTWVhZTdQL3F1YUJMK0xiYlVJeUNOOXVX?= =?utf-8?B?ckhXQjBoMU93bC9mdmpSeUg3YkJJOERnaTE5SXhCTHdsMkdlWVBBREtwQkR3?= =?utf-8?B?UVZwKzRCQXRpSUsxMXRXR01iQlpQVXdXbkRCM3UyRjc4RC9GaXV5Z2RqU1N1?= =?utf-8?B?Y2tMa055T0hPZk5ZZUdFczdaOVJxVWlNUFFkYTFaUk1IYlZvOExrOXUzc0ZX?= =?utf-8?B?Rzh4SzJ5TDZRQVREcEJjNzZRT3YraDhOb0xuekc4QzJNMUtqdnJzUU9wcC8w?= =?utf-8?B?cEFlNExVQ0xNRFphRER3SGMydGZBYzIzOHZYK0FadktrcTM5YlNLdEZHc0Vh?= =?utf-8?B?TGVobGRQelduWW1RSUpMVStoWGZGc1ZJT0REVWtWZFFGajRoditUNmoyL1Jj?= =?utf-8?B?cXY3Y3kydDAvSVNNWno3S3ptWmswYzNLbFg4OTF3T2o4b2xDdXV6eUhvSlE1?= =?utf-8?B?TTJsN3JVMlkwRHdNcDI0NmVyb0RxS2I4ZUNzeGlWdmRGdXZUbEhKeTZqSTQ5?= =?utf-8?B?M3kwL2dUeWVwRzhwaFhndGlMQWVsNWJHZmJEbm41M0FTem80TmJvRVhzNi9j?= =?utf-8?B?QzRnK1U3L0tBNjVPbUJiWHlhS2xXQ2t1aE5wb3dTeHNXMEQ1MnEvUm9XdFNY?= =?utf-8?B?cmtKWFFrUkdXUnpYNHBXTWdGWlRnSDR3UWt3YWNuNWlSazU2cjVrVWNpNXA0?= =?utf-8?B?dU1jWlNPZU9YZFV6T0swQlhJRCtDKzF3bHZEalNPSjNZVlAvVThnQWIvZ0Jh?= =?utf-8?B?cUlrRExXakMrM3lOYnBXOEJYRVZGbVV3TVVrWnpTdENFekloanp4aHEwQnND?= =?utf-8?B?dHFFNXVKOHdXZ2diL1NiYzA5Y2Y4T3lrc0NLQ0Y1YkhBSFh5cy9XQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4a66409-c7e4-45ba-42c5-08def6f5b0d2 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6472.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 15:40:22.8949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 71eXWvjvt/PAnXEWqY6KapE6yQbpSABIRRX1lnoQRmYcL6PSz/31uLp0C6hKVEQFvw/LxPEDjL7F6so/sF8Sew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9439 X-purgate-ID: tlsNG-ef75cf/1786376428-350CDAE4-5AD3C65B/0/0 X-purgate-type: clean X-purgate-size: 258 On 8/6/26 17:26, Roger Pau Monne wrote: > Introduce a specific check that prevents an accesses from spilling across > two devices. > > Signed-off-by: Roger Pau Monné Reviewed-by: Stewart Hildebrand From xen-devel-bounces@lists.xenproject.org Mon Aug 10 15:41:54 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 15:41:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387609.1628871 (Exim 4.92) (envelope-from ) id 1wtS8O-0006ER-RW; Mon, 10 Aug 2026 15:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387609.1628871; Mon, 10 Aug 2026 15:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtS8O-0006EK-NT; Mon, 10 Aug 2026 15:41:52 +0000 Received: by outflank-mailman (input) for mailman id 1387609; Mon, 10 Aug 2026 15:41:52 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtS8N-0006EE-Tt for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 15:41:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtS8N-00ErSm-Ah for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 17:41:51 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f12b-bab6-0a2a0a5309dd-0a2a4509aaea-34 for ; Mon, 10 Aug 2026 17:41:50 +0200 Received: from [52.101.201.14] (helo=PH7PR06CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f13d-be1a-0a2a45090019-3465c90e8ff0-3 for ; Mon, 10 Aug 2026 17:41:50 +0200 Received: from DM4PR12MB6472.namprd12.prod.outlook.com (2603:10b6:8:bc::7) by MN0PR12MB6054.namprd12.prod.outlook.com (2603:10b6:208:3ce::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 15:41:45 +0000 Received: from DM4PR12MB6472.namprd12.prod.outlook.com ([fe80::4a4d:4208:3862:fb7a]) by DM4PR12MB6472.namprd12.prod.outlook.com ([fe80::4a4d:4208:3862:fb7a%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 15:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jOeRiICe3BP3G+FrsYmqCglQP6oUN+t03VhmnVtkiuGhojVrOktgPumNCUyHT/u4XVJV+JSY4fQ8/I7LHCgPL6Koj4H3VEa617THlF3I53CTZZX3QkBMChBWNUqHRmPuKJ8bM9lyOjJh24Zua2Cfvyu63mKEL4ZWPE9zNrAFJbYAcHkahdgY9FyW39JGnVTGnJmKcEtWWDhYJsdt8p5vlCb9l/ACKMXuqbF7bhHq2Gt3ZuGwTY5V5JuMLqTrIEFEXh9h/yCrplRcQwqlhJM/wcW/eAmZQBiCgSK43RXrdaBIocXecHN0ObXq5ZDv10Q48Xg0HL7ssZthl0hXwTXJMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eycNA89dKo9QWALjfwVpOmoCniYD7R5v+ovAdxRCMFU=; b=FwZ56anSXG4WUDD0EEJo0H2+KgxjfZXd/QpyVNz6JCK/8ArR5DRL1ctvtBwkKJihW9rsMz604Ae3DYwacH058AChQATVVly57aotmmX1LJKlnlhrL+I9EfLVWgyvoaz1WBVmAAh8pdy04HIRt/QiXhvAMXw+xTMsg6UHp6w2Og3eJ1aE8NPuzVy5lhqcAfMJxNXFa5eIKkRjK1IHntD/P7fwRCML3mcEICa+yBi9Grx7mA909epBXxCa/vM/ss4fSnEsr+yAOODfOmoLlLMp7ZdXh5YhVsNqEp35m1rAgVxmhZyBwRaIboMuDTpTT6tMFEyGJABKGjGNIfN/9Y3WuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eycNA89dKo9QWALjfwVpOmoCniYD7R5v+ovAdxRCMFU=; b=qIhpT0Dyz3Vs0vgAPMAlZVmg0+s9p9aJDnplOVSKxkp8AlA5KS0AXgRabJUagJVcqg5EifhSCsaa5zRdF+9IKgxfF7z2S42k2t/JU3JDwVS1DG1e+Kty5oGn/V9x1GnnRPqQ1Sw3uvZn4aapUwjVeAzF42Ta3zpKtrRWINXIUO0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <9191c840-5d9f-4780-a9f9-918459454cff@amd.com> Date: Mon, 10 Aug 2026 17:41:40 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] xen/vpci: allow unaligned accesses by the hardware domain To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Anthony PERARD , Jan Beulich , Andrew Cooper , Teddy Astie , Jason Andryuk References: <20260806152619.23881-1-roger@xenproject.org> <20260806152619.23881-3-roger@xenproject.org> Content-Language: en-US From: Stewart Hildebrand In-Reply-To: <20260806152619.23881-3-roger@xenproject.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CPCP307CA0002.DNKP307.PROD.OUTLOOK.COM (2603:10a6:380::15) To DM4PR12MB6472.namprd12.prod.outlook.com (2603:10b6:8:bc::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6472:EE_|MN0PR12MB6054:EE_ X-MS-Office365-Filtering-Correlation-Id: 32963758-a488-47f3-e55b-08def6f5e1ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|23010399003|18002099003|22082099003|11063799006|56012099006|6133799003|4143699003|10067099003; X-Microsoft-Antispam-Message-Info: Tt8DrEBwWDHaZbiLNkaTcMtEK6yUQP+Xi5hV+hIXN+oBnTU0huTLQjrxbNv+P4d/ZlJdXPMyw4+LYFuckoIjnOvsSgu/AlynrkJxs/3dGBzBcpARpV13WQuUYI3Uoyz4E2iYyPRV441AKoJK4BEv9TAfB1HHvOYOeEoQ8h3JiK2OnIiqPf5j8LR6fKYZuv4Z308QBmQ3KJRwrZsqVUNIX72nad7G5KKdP2DVOWGXrbh3Y40mHgDRralNKAgB1vNFy+u7bmqnOBfedgpPiRMCssVYjw/vowgLmR3V0v3OP/AYXx5SonKTTKlDnfCIa653ownU87qQUpGk0vhzCVKGrYUU/V2NwVyWF9BiVDKkHL6CNn8kb5Pd97mOJ8FV+36mMTWL0FJLP55IKqyMwoLU2fs1wDrrhRR7e19S/TtCzmJ40tFl906rO/TbFa9rPHKzjKQSXqstLgYScbZSINII7tSug/CRbpyM89xx2OsRBAS7BTuMn5TS2MX/h4lKY6sk32j8Hz31Y1XPRBw+RrvicxWzCYQJfvCQSmE/6MTlU5l1gK5A1EHx6q5gZ4jQS5ZFD12qgl3FXVVlABy6+j+8sXiM/qr3QPRZd8Mv1Q631IQIWYjSJUCcNgULI0j+5UkCvgEZWZ4ttA/51XZzmF/QNPvou6Q8WVG2cvVW9/Nwy1k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6472.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(6133799003)(4143699003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tlg0ejJjbjA5eXhQYW1UT0JRK290TlJJK2RhaVUra2s2dUF1UzJVL3k1ZFpO?= =?utf-8?B?dThFMHVnSmVWblVId2E2NCtlNTRoV1U4bEEzdFpJT1JaQ0RLRlp2UlFPMUxk?= =?utf-8?B?UjJ1WkdSOWFENzdrSHZYdWdRTmJJTUlwV3JjTTdsNllEcVQ0QzhxWDBkRVNH?= =?utf-8?B?b0V6dzJjSXBNNEtPdzdoMHlrM0djRFZLMTJZSWdmdVVVWVh3d3pqRjdmU1l1?= =?utf-8?B?UE9KVlM2amNab0JmbzZGa2o1b2RFcS9SN0ZGRWJnYVNzdXA0NDVHeHBhVTJw?= =?utf-8?B?SWJOUzdzcDN0R2REOVg0U0tpRTI0a2N0TEtHc3o1bS9BYjkwdGdXR2lpSkVJ?= =?utf-8?B?MUlhcGtZZFhsSXRvZzEzSTJHVmw5R3F0QnpkN0hkS1hsZi9RNzUzMER6SDEv?= =?utf-8?B?cDdGVWh3UW1yeEhSS3R2RHFTdFVzWEhRdDF0aU45aDJnbjhucE8wdnZhVVc5?= =?utf-8?B?N2RJMkxPWHNtWHpxUlNEdGJ2UE54MktSaFNNbmdQRkx5cjRaNkEwUlluSWp4?= =?utf-8?B?MnY4S1R1TmEvTmRwZWxKZ1Y0ZHloOHYxOWNmUXNObTI5ZVUzQkJrWHBMUGEx?= =?utf-8?B?clozNjhKNmdjNS9ZaCsvY1p3bWZDOFRDQ3B6ZThvMFhOKzJjd2ErTUgvbnNx?= =?utf-8?B?N0d3MHJ0QWJJNDFqMGhGOGFHcTdEVTA5M2ttT3N4bk5WR2tRcU0xNDZVREZK?= =?utf-8?B?SFNqS3BrZFZTMnpPN0FRalZJMHNzUFFLdEFOMWI4OExDNXUzU1ZkVmFnbkRh?= =?utf-8?B?UWtFTGpzOFVFMFR3OUxsVEJxN1F2bFJlbDlmRFNVdFV6YzNwejRNb2tvWXZS?= =?utf-8?B?ZnZ5bGVNVnJaNDRsRnBYZ0VEM2xrYzdOd1FZaStFeE84R2pQOU1NV3M5Q1J5?= =?utf-8?B?L3hMRzkwL1VEMTdXV0l3TUhBRWtXVWl6NWxQWVA5eVRyNHZPZFRxYUNkZ21F?= =?utf-8?B?WEpmZG81MVFNYjlEUHlUalJDNmFPSzZxK3hhQnVQR2tDSXAzMTdrNnpydFdE?= =?utf-8?B?cFZXTjZRaHJJblJKamc4OXJleEpGU3Q3L2xtNFpBZUExWTFOaHBJRTdoYW4x?= =?utf-8?B?blpNaXhoc25sUWV6R1IvKzVtcVR4Z0dMRHFKTG9UMEdkR2lCM0w0a0xiWFhX?= =?utf-8?B?UHNXMkNWRjMrMFIzblJXZmhWRnNUdW90aGNrNlI5alBFb3hOSHNFYytZOUJx?= =?utf-8?B?NXBrUjJMcGRGRWV6WU9QN2ZFTDlrN09wci9EaGFyYUFVVURQa2xuWXJZTW4z?= =?utf-8?B?VjdieFBhSDNBSHhoRzROaWM0Z3BnVVBQWXcvMkFXaURoYXBJdndPaWlzTVg1?= =?utf-8?B?U2w2dnZESlhCclV3YjMzeEVic1hYL1ZyNFBDSFVLdHRmT1NXbUZqc2pQU2Za?= =?utf-8?B?MTFjS3o4allHS2prRlQ1VmhIYmN3SS95SU1XSkgrbFlkNW84dCtzcm5RcklB?= =?utf-8?B?T0hRcENHNTRBMldPQkpGTmRLZVczd3JCcUhPMXNzUXlYTmJ4d3dTRVhWY1V6?= =?utf-8?B?b0o4SUtYN0o1NDVNZTR2MExUcU16WUFtdVdtbC9sRzhLYU1vM3IzVFByQk94?= =?utf-8?B?anNKRnRtNHFFb1Ercm5WSi9wZVpQbWQ1eUlBd25VcmY2dGNJQWdWQkNDb3BP?= =?utf-8?B?OGY5cXBEOUlxcG1tZ2dTUllscWc5a283amx4aGNaNE45bEJORVBGc1ZhRFNw?= =?utf-8?B?L3RrSnhiYzZ1SUJuRTVwNDdmQ0wyRU8vYjRaN2hJclY3a2twNWFzSDJPamE4?= =?utf-8?B?dlN0b0pCS3BGTU1JRTVnZERnODRaSGpNM0gvWkppTmdDb0dnNWIrMjNWTUpt?= =?utf-8?B?ZWVrbU4wYUFPN251Tzl0QzRtYUtXcmNOYnZhU2tMMzVlcW9QVUtFd2lvWFIz?= =?utf-8?B?WXcwTVJkdmJzK05lekdIT3RPeWJTcndwQlJ6ZkRFL1RCNmFYYlRVWWpxWW5O?= =?utf-8?B?UUVEUnA0TzRLdTlSbGVlaERocWoxRjNPWmgzVVhxQnFmM2Vydm5LMGVvK1V3?= =?utf-8?B?TFhpc3dpalZmd0tkeFRpSk41dng0TEw2dEpYQ01iUnc4TDcxdUhhRHRrdUNi?= =?utf-8?B?cFE1aVF0Q1JlN2tLeGJYbGppUXlFNTNtY1lYM0J4UmNBUjhDd3ZEdFlyWE0y?= =?utf-8?B?c3gxamxPWlhJbm9BRE5ieU1tWGRMRFlKS1RxSGgwZzZ1K0FtNUExNkFhNytN?= =?utf-8?B?Qkl2QnMyY0NKRlZsNzhnOE9CZUdCTm5ISklNU1JaY0doSnJqZVVUdXFkYkVs?= =?utf-8?B?T1dkbmVsU01LdUxiN3ErRGpEZExOdW5NcUQwblJKcTY5b0lFNHBnYW1JUWlI?= =?utf-8?B?Uks0a29lQ3FJMWlPTEtHa0JDMEtpZDM2aUoreUtkSGt6cnh6T1pEUT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32963758-a488-47f3-e55b-08def6f5e1ce X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6472.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 15:41:45.1002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ge29tHxVBQ4Qk6I50SD//CgDemzT3X0tzCwpDeeB5o2REGw36PoV9itEl0OhPMZMGC6P5gWbr3hemTQYmxRmUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6054 X-purgate-ID: tlsNG-bad1c0/1786376510-BC2F4034-DB415B39/0/0 X-purgate-type: clean X-purgate-size: 1036 On 8/6/26 17:26, Roger Pau Monne wrote: > It's possible for domains to generate unaligned PCI config space accesses > when using ECAM, and hence vPCI should support those at least for the > hardware domain. Such unaligned accesses to the PCI config space have been > reported to come from ACPI logic. > > Relax the checking in vpci_access_allowed() to allow such accesses for the > hardware domain, and fix the handling in pci_conf_{read,write}{16,32}() to > fulfill them using MMCFG. > > MMCFG regions are identity exposed to the hardware domain, and hence such > unaligned accesses can only come as a result of the host having MMCFG in the > first place, as otherwise MMCFG won't be exposed to the hardware domain > either. > > Note that vpci_ecam_{read,write}() already refuse accesses that cross a > device boundary unconditionally. > > Reported-by: Jason Andryuk > Signed-off-by: Roger Pau Monné Reviewed-by: Stewart Hildebrand From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:02:02 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387623.1628880 (Exim 4.92) (envelope-from ) id 1wtSRn-0001XO-E3; Mon, 10 Aug 2026 16:01:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387623.1628880; Mon, 10 Aug 2026 16:01:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSRn-0001XH-A9; Mon, 10 Aug 2026 16:01:55 +0000 Received: by outflank-mailman (input) for mailman id 1387623; Mon, 10 Aug 2026 16:01:53 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSRl-0001XB-I1 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:01:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSRk-003yAp-KY for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:01:52 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f5e1-2eae-0a2a0a5409dd-0a2a45018502-42 for ; Mon, 10 Aug 2026 18:01:52 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f5f0-5984-0a2a45010019-b9ff1c1283ff-3 for ; Mon, 10 Aug 2026 18:01:52 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec689f7e000e099.002 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:01:47 +0000 Received: from leducb (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id CDEB880143; Mon, 10 Aug 2026 18:01:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=mDWDY8uCcNpOoWchPUgPLSC3AhEIumSbEE6oZEH4OMs=; h=from:subject:date:message-id:to:cc:mime-version:content-type:feedback-id; b=orkGOrmvBqXcC5/yo/UFmyKqN0YxWs3qMjSf7eltUIA3lif439MB9sezVO9uvIMpUWf/yNLG4 tb1vU3/5FovEcCh5MiACrbkZkzzopSKOHbusdvkAPjfk/0H3OguhFuwuC1Vu2q7USAnHrEuuSNE iz6jocWQQsI5QE16Y8UQ/R5Tk5Z/Wu7pUyHIWoyDsCDOujwDYWvM2+KNBXnZZD2/rcoFmakZuZL AT7KDZtI91esKRgkJ7wqdA36vx8vJC4xCireKx+L8xpca1x7kAQPiPrGnVt1nNXC6WTgu3b/+Kg IdFihvX3tXavbvQw0tTVsKmcYVLkqi/ti0OlU7ep3llQ== X-Zone-Loop: c8e3ca4d7798ec05392c0dd2ef91c4d0587d2a8872c6 x-campaign-type: default x-transaction-id: ab6c9570-46a5-487a-a4d1-af9b08c5d184 x-swg-uid: 01-3221a14d-cc91-447f-964c-cd7f08f435e1 X-Mailer: Sweego Message-ID: <1786377707.8631fc262581453bbf619ec5b2062170.19fec689f7e000e099@vates.tech> x-swg-bid: 1786377707.8631fc262581453bbf619ec5b2062170.19fec689f7e000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Baptiste Le Duc To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Baptiste Le Duc Subject: [PATCH 0/6] automation: add QTB test framework for riscv64 smoke tests Date: Mon, 10 Aug 2026 18:01:13 +0200 MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2047.9748927987cc8332.19fec6899c0.104ee129b456d5ba=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786377705920 X-purgate-ID: tlsNG-d62444/1786377712-1E07B757-9824E1D3/0/0 X-purgate-type: clean X-purgate-size: 8391 ---=Part.2047.9748927987cc8332.19fec6899c0.104ee129b456d5ba=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Xen is being made safety certifiable to IEC 61508 SIL 3 and ISO 26262 ASIL D, with Arm and x86 as the current targets [1]=2E Evidence at those levels= is requirements based testing plus structural coverage, produced automaticall= y and repeatably in CI=2E QTB (QEMU Test Bench) [2] is the framework AMD wrote for it as part of the Xen safety initiative=2E It drives a live QEMU instance over qtest, QMP an= d GDB, so a test has full access to the machine while emulation runs: read and write the consoles, inspect registers and memory, inject interrupts an= d faults, all from Python and all reproducible in a pipeline=2E QTB is not upstream in QEMU yet, but is planned to be=2E RISC-V is not in the certification scope today=2E It is also the youngest port, so it has close to no test infrastructure to undo, which makes it th= e cheapest place to adopt QTB=2E Starting the riscv64 tests on the framework now means the port grows its tests in the shape certification asks for as the port itself grows, instead of a pile of expect scripts to convert late= r if riscv64 ever becomes a certification target=2E It also puts a second architecture on QTB, which is useful to the framework itself before it is proposed to QEMU upstream=2E Concretely, the riscv64 CI coverage today is one expect script, automation/scripts/qemu-smoke-riscv64=2Esh, which boots Xen alone under QE= MU and greps a single string out of one serial console=2E The machine it boot= s is hardcoded, so a second configuration means a second script, and a test with a DomU in it means growing guest handling from scratch=2E This series replaces that script with a data-driven framework using QTB=2E= A machine is a YAML entry (pcpus, scheduler, interrupt controller, boot arguments), a test type is a small Python class saying what to do with a booted machine, and a test binds a machine to that type's expectations=2E Adding a configuration to CI is then a config change and a job stanza=2E Patch 1 goes to test-artifacts [3] and must land first, since patches 2-6 run inside the container it adds=2E Patches 2-6 go to xen=2Egit=2E qemu-smoke-riscv64-gcc also pulls the riscv64 QEMU and OpenSBI binaries from the qemu-9=2E0=2E0-riscv64 job in test-artifacts, which is not in test-artifacts master yet and has to land there too=2E test-artifacts [3]: - Add a QTB container to run the Xen riscv64 tests debian:13-qtb-riscv64, carrying qemu=2Eqtb from AMD's QEMU fork and th= e dtc/fdt dependencies the framework needs at run time=2E xen=2Egit: - automation/qtb: add jinja2 device trees for riscv64 smoke tests The host tree varies with hart count, MMU type and device set, so it i= s rendered per machine from a template rather than shipping one static =2Edts per configuration=2E - automation/qtb: add Python QTB framework with the console-test type The base layer every test type builds on (machine catalog lookup, host DT generation, QEMU invocation, per-console log capture) plus the firs= t test type, which asserts every string listed in console-test=2Eyaml is printed on the expected console=2E - automation/qtb: add unit tests for the QTB framework pytest coverage of the QEMU-agnostic parts, for developers only=2E - automation/qtb: add QTB framework README How to add a machine, add a test type and run one locally=2E - CI: run the riscv64 smoke test via QTB framework console-test Repoints qemu-smoke-riscv64-gcc at the framework and drops qemu-smoke-riscv64=2Esh, which then has no caller left=2E Testing: QEMU only, as the existing riscv64 CI does=2E qemu-smoke-riscv64-gcc runs the same check as before=2E The catalog ships a single Xen-only machine, since Xen cannot boot a DomU on RISC-V yet=2E DomU machines plus an irq-test type using QTest interrupt injection follow once DomU support lands=2E [1] https://elisa=2Etech/blog/2026/07/22/the-final-phase-of-xen-safety-sol= ving-coverage-and-residual-gaps-stefano-stabellini-amd/ [2] https://gitlab=2Ecom/xen-project/people/amd/qemu/-/tree/safety [3] https://gitlab=2Ecom/xen-project/hardware/test-artifacts CI test: https://gitlab=2Ecom/xen-project/people/baptleduc/xen/-/pipelines/27408369= 46 Baptiste Le Duc (5): automation/qtb: add jinja2 device trees for riscv64 smoke tests automation/qtb: add Python QTB framework with the console-test type automation/qtb: add unit tests for the QTB framework automation/qtb: add QTB framework README CI: run the riscv64 smoke test via QTB framework console-test =2Egitlab-ci=2Eyml | 3 + automation/gitlab-ci/test=2Eyaml | 26 ++- automation/scripts/qemu-smoke-riscv64=2Esh | 19 -- automation/scripts/qemu_smoke_riscv64=2Epy | 122 ++++++++++ automation/scripts/qtb/__init__=2Epy | 2 + automation/scripts/qtb/riscv/README=2Emd | 182 +++++++++++++++ automation/scripts/qtb/riscv/__init__=2Epy | 9 + automation/scripts/qtb/riscv/config=2Epy | 125 ++++++++++ automation/scripts/qtb/riscv/config=2Eyaml | 19 ++ =2E=2E=2E/qtb/riscv/console_test/__init__=2Epy | 4 + =2E=2E=2E/qtb/riscv/console_test/console-test=2Eyaml | 18 ++ =2E=2E=2E/qtb/riscv/console_test/console_test=2Epy | 145 ++++++++++++ automation/scripts/qtb/riscv/dt=2Epy | 57 +++++ =2E=2E=2E/scripts/qtb/riscv/dts/qemu-host=2Edts=2Ej2 | 160 +++++++++++= ++ automation/scripts/qtb/riscv/machine=2Epy | 56 +++++ automation/scripts/qtb/riscv/paths=2Epy | 51 ++++ automation/scripts/qtb/riscv/qtb_test=2Epy | 53 +++++ automation/scripts/qtb/riscv/unit/__init__=2Epy | 2 + automation/scripts/qtb/riscv/unit/conftest=2Epy | 42 ++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_config=2Epy | 128 +++++++++++ =2E=2E=2E/qtb/riscv/unit/test_console_test=2Epy | 217 +++++++++++++= +++++ automation/scripts/qtb/riscv/unit/test_dt=2Epy | 99 ++++++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_machine=2Epy | 58 +++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_temp_dir=2Epy | 42 ++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_xen_dt=2Epy | 46 ++++ automation/scripts/qtb/riscv/xen_dt=2Epy | 58 +++++ 26 files changed, 1718 insertions(+), 25 deletions(-) delete mode 100755 automation/scripts/qemu-smoke-riscv64=2Esh create mode 100755 automation/scripts/qemu_smoke_riscv64=2Epy create mode 100644 automation/scripts/qtb/__init__=2Epy create mode 100644 automation/scripts/qtb/riscv/README=2Emd create mode 100644 automation/scripts/qtb/riscv/__init__=2Epy create mode 100644 automation/scripts/qtb/riscv/config=2Epy create mode 100644 automation/scripts/qtb/riscv/config=2Eyaml create mode 100644 automation/scripts/qtb/riscv/console_test/__init__=2Ep= y create mode 100644 automation/scripts/qtb/riscv/console_test/console-test= =2Eyaml create mode 100644 automation/scripts/qtb/riscv/console_test/console_test= =2Epy create mode 100644 automation/scripts/qtb/riscv/dt=2Epy create mode 100644 automation/scripts/qtb/riscv/dts/qemu-host=2Edts=2Ej2 create mode 100644 automation/scripts/qtb/riscv/machine=2Epy create mode 100644 automation/scripts/qtb/riscv/paths=2Epy create mode 100644 automation/scripts/qtb/riscv/qtb_test=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/__init__=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/conftest=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_config=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_console_test=2E= py create mode 100644 automation/scripts/qtb/riscv/unit/test_dt=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_machine=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_temp_dir=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_xen_dt=2Epy create mode 100644 automation/scripts/qtb/riscv/xen_dt=2Epy --=20 2=2E55=2E0 -- Baptiste Le Duc | Vates Hypervisor & Kernel Engineer XCP-ng & Xen Orc= hestra - Vates solutions web: https://vates=2Etech ---=Part.2047.9748927987cc8332.19fec6899c0.104ee129b456d5ba=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:10:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:10:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387635.1628894 (Exim 4.92) (envelope-from ) id 1wtSZw-0003Tb-Hf; Mon, 10 Aug 2026 16:10:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387635.1628894; Mon, 10 Aug 2026 16:10:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZw-0003TR-B3; Mon, 10 Aug 2026 16:10:20 +0000 Received: by outflank-mailman (input) for mailman id 1387635; Mon, 10 Aug 2026 16:10:18 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZu-0003Qj-Oj for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:10:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSZt-008NAc-Sr for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:10:17 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f7dd-bab6-0a2a0a5309dd-0a2a45049fd2-26 for ; Mon, 10 Aug 2026 18:10:17 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f7e9-b57f-0a2a45040019-b9ff1c128dc1-3 for ; Mon, 10 Aug 2026 18:10:17 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec70581a000e099.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:10:13 +0000 Received: from leducb (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 9AB75836CA; Mon, 10 Aug 2026 18:10:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=0V35KKyCyWU/Pb/pFIo83QM223XPnac1kuZzpR5VrJw=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=QWbdslD1TykVDm7ZCK6mB87orQiy+XeG9IQ9BRqhFO1t1CTlxu2zCEzbMzPhmoQcWA5j7PS8n 9Zq7c5RD+NPoHoJ8p8/n7qA6tSTjVJwIwTLpxy/QC91NN3vS0ZXs0GKcJbpH/H9VE2jIdiR6mCS n7MAvlJePywnAYtmFjVJ2EAlRlkQTPa7laFkwXrJpjVaUySq0V2G+VXBdwJ6SEBx6rT7TmMgwag U9oqF2+Fa1/+iDseQFr4vZ0xGAnSsLtQQftjJc3GBTPDp9hxxAvNN6YLvbGWTba7Pqmf25+28BC Q8nCWfX1DP2oUsMASMuOKxJ/QId20FayXpqQzQqKqFgQ== X-Zone-Loop: c24006a88a476bd7b77c74e0bbcfebe1aa929b85d8b1 x-campaign-type: default x-transaction-id: 05a9d833-b609-4159-b82d-147cbcfeed1a x-swg-uid: 01-de0d33b5-f43e-4c41-bd42-d2c4f0d67d31 X-Mailer: Sweego Message-ID: <1786378213.8631fc262581453bbf619ec5b2062170.19fec70581a000e099@vates.tech> x-swg-bid: 1786378213.8631fc262581453bbf619ec5b2062170.19fec70581a000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Baptiste Le Duc To: xen-devel@lists.xenproject.org Cc: Baptiste Le Duc , Doug Goldstein , Stefano Stabellini Subject: [PATCH 2/6] automation/qtb: add jinja2 device trees for riscv64 smoke tests Date: Mon, 10 Aug 2026 18:09:52 +0200 In-Reply-To: <20260810155543.927954-1-baptiste.le-duc@vates.tech> References: <20260810155543.927954-1-baptiste.le-duc@vates.tech> MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2049.93281b3fe6baf6b5.19fec705570.451b9a4538daf6f6=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786378212720 X-purgate-ID: tlsNG-ebf023/1786378217-C32CCB50-25BB999F/0/0 X-purgate-type: clean X-purgate-size: 7543 ---=Part.2049.93281b3fe6baf6b5.19fec705570.451b9a4538daf6f6=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The dom0less RISC-V smoke tests need a host device tree describing the platform (CPUs, APLIC/IMSIC, uart)=2E It varies per machine (hart count, M= MU type), so a single static =2Edts cannot cover the test matrix=2E Add dts/qemu-host=2Edts=2Ej2, a template of the QEMU virt platform in aia=3Daplic-imsic mode: per-hart cpu/cpu-intc nodes, the M- and S-mode APL= IC and IMSIC pairs, CLINT and the ns16550a uart=2E It takes ncpus, mmu_type a= nd xen_bootargs as arguments=2E Values QEMU hardcodes are set as named constants matching their source symbols (QEMU_UART0_IRQ, QEMU_IRQCHIP_NUM_SOURCES, =2E=2E=2E) rather than open-coded, so a QEMU-side change is easy to trace=2E The template is inert on its own: the generated dtb will be used in next patch=2E Assisted-by: Claude:claude-opus-5 Signed-off-by: Baptiste Le Duc --- =2E=2E=2E/scripts/qtb/riscv/dts/qemu-host=2Edts=2Ej2 | 160 +++++++++++= +++++++ 1 file changed, 160 insertions(+) create mode 100644 automation/scripts/qtb/riscv/dts/qemu-host=2Edts=2Ej2 diff --git a/automation/scripts/qtb/riscv/dts/qemu-host=2Edts=2Ej2 b/autom= ation/scripts/qtb/riscv/dts/qemu-host=2Edts=2Ej2 new file mode 100644 index 0000000000=2E=2E13a8e983ce --- /dev/null +++ b/automation/scripts/qtb/riscv/dts/qemu-host=2Edts=2Ej2 @@ -0,0 +1,160 @@ +/dts-v1/; + +{#- + * Jinja2 QEMU "virt" platform device tree for Xen RISC-V tests=2E + * + * Interrupt controller: APLIC in MSI mode + IMSIC + * (QEMU -M virt,aia=3Daplic-imsic)=2E + * + * Rendered by xen_dt=2Epy=2E + * + * Variables: + * ncpus - number of physical harts (int, >=3D 1) + * mmu_type - Xen host MMU type, e=2Eg=2E "sv39" (string) + * xen_bootargs - Xen command line (string) + * + * Per-hart nodes are labelled cpu / cpu_intc and referenced with &= label=2E + * + * No `aia-guests=3DN`, so no VS-mode guest files: IMSIC reg size is + * ncpus * page size=2E +-#} +{#- Values QEMU hardcodes, need to be described to Xen -#} +{%- set QEMU_TIMEBASE_FREQUENCY =3D 10000000 %} {#- RISCV_ACLINT_DEFAUL= T_TIMEBASE_FREQ -#} +{%- set QEMU_IRQCHIP_NUM_SOURCES =3D 96 %} {#- VIRT_IRQCHIP_NUM_SO= URCES (virt=2Eh) -#} +{%- set QEMU_IRQCHIP_NUM_MSIS =3D 255 %} {#- VIRT_IRQCHIP_NUM_MS= IS -#} +{%- set QEMU_UART_CLOCK_FREQUENCY =3D 3686400 %} {#- create_fdt_uart() -= #} +{%- set QEMU_UART0_IRQ =3D 10 %} {#- UART0_IRQ -#} +{%- set QEMU_IMSIC_PAGE_SZ =3D 0x1000 %} {#- IMSIC_MMIO_PAGE_SZ = -#} + +{%- set IRQ_TYPE_LEVEL_HIGH =3D 4 %} +{%- set APLIC_IRQ_CELLS =3D 2 %} + +{%- set IRQ_M_SOFT =3D 3 %} +{%- set IRQ_M_TIMER =3D 7 %} +{%- set IRQ_S_EXT =3D 9 %} +{%- set IRQ_M_EXT =3D 11 %} + +/ { + #address-cells =3D <0x02>; + #size-cells =3D <0x02>; + compatible =3D "riscv-virtio"; + model =3D "riscv-virtio,qemu"; + + memory@80000000 { + device_type =3D "memory"; + reg =3D <0x00 0x80000000 0x00 0x80000000>; + }; + + cpus { + #address-cells =3D <0x01>; + #size-cells =3D <0x00>; + timebase-frequency =3D <{{ QEMU_TIMEBASE_FREQUENCY }}>; +{% for i in range(ncpus) %} + cpu{{ i }}: cpu@{{ i }} { + device_type =3D "cpu"; + reg =3D <0x{{ '%x' % i }}>; + status =3D "okay"; + compatible =3D "riscv"; + riscv,cbop-block-size =3D <0x40>; + riscv,cboz-block-size =3D <0x40>; + riscv,cbom-block-size =3D <0x40>; + riscv,isa =3D "rv64imafdch_zicntr_zicsr_zifencei_zihintpause_= zihpm_zba_zbb_zbs_smstateen_svpbmt_smaia_ssaia"; + mmu-type =3D "riscv,{{ mmu_type }}"; + + cpu{{ i }}_intc: interrupt-controller@{{ i }} { + #interrupt-cells =3D <0x01>; + interrupt-controller; + compatible =3D "riscv,cpu-intc"; + }; + }; +{% endfor %} + cpu-map { + + cluster0 { +{% for i in range(ncpus) %} + core{{ i }} { + cpu =3D <&cpu{{ i }}>; + }; +{% endfor %} + }; + }; + }; + + soc { + #address-cells =3D <0x02>; + #size-cells =3D <0x02>; + compatible =3D "simple-bus"; + ranges; + + serial@10000000 { + interrupts =3D <{{ QEMU_UART0_IRQ }} {{ IRQ_TYPE_LEVEL_HIGH }= }>; + interrupt-parent =3D <&aplic_s>; + clock-frequency =3D <{{ QEMU_UART_CLOCK_FREQUENCY }}>; + reg =3D <0x00 0x10000000 0x00 0x100>; + compatible =3D "ns16550a"; + }; + + aplic_s: aplic@d000000 { + riscv,num-sources =3D <{{ QEMU_IRQCHIP_NUM_SOURCES }}>; + reg =3D <0x00 0xd000000 0x00 0x8000>; + msi-parent =3D <&imsic_s>; + interrupt-controller; + #interrupt-cells =3D <{{ APLIC_IRQ_CELLS }}>; + compatible =3D "riscv,aplic"; + }; + + aplic@c000000 { + riscv,delegate =3D <&aplic_s 0x01 {{ QEMU_IRQCHIP_NUM_SOURCES= }}>; + riscv,children =3D <&aplic_s>; + riscv,num-sources =3D <{{ QEMU_IRQCHIP_NUM_SOURCES }}>; + reg =3D <0x00 0xc000000 0x00 0x8000>; + msi-parent =3D <&imsic_m>; + interrupt-controller; + #interrupt-cells =3D <{{ APLIC_IRQ_CELLS }}>; + compatible =3D "riscv,aplic"; + }; + + imsic_s: imsics@28000000 { + riscv,num-ids =3D <{{ QEMU_IRQCHIP_NUM_MSIS }}>; + reg =3D <0x00 0x28000000 0x00 0x{{ '%x' % (ncpus * QEMU_IMSIC= _PAGE_SZ) }}>; + interrupts-extended =3D < + {%- for i in range(ncpus) %} + &cpu{{ i }}_intc {{ IRQ_S_EXT }} + {%- endfor %} + >; + msi-controller; + interrupt-controller; + #interrupt-cells =3D <0x00>; + compatible =3D "riscv,imsics"; + }; + + imsic_m: imsics@24000000 { + riscv,num-ids =3D <{{ QEMU_IRQCHIP_NUM_MSIS }}>; + reg =3D <0x00 0x24000000 0x00 0x{{ '%x' % (ncpus * QEMU_IMSIC= _PAGE_SZ) }}>; + interrupts-extended =3D < + {%- for i in range(ncpus) %} + &cpu{{ i }}_intc {{ IRQ_M_EXT }} + {%- endfor %} + >; + msi-controller; + interrupt-controller; + #interrupt-cells =3D <0x00>; + compatible =3D "riscv,imsics"; + }; + + clint@2000000 { + interrupts-extended =3D < + {%- for i in range(ncpus) %} + &cpu{{ i }}_intc {{ IRQ_M_SOFT }} &cpu{{ i }}_intc {{= IRQ_M_TIMER }} + {%- endfor %} + >; + reg =3D <0x00 0x2000000 0x00 0x10000>; + compatible =3D "sifive,clint0", "riscv,clint0"; + }; + }; + + chosen { + stdout-path =3D "/soc/serial@10000000"; + xen,xen-bootargs =3D "{{ xen_bootargs }}"; + }; +}; -- Baptiste Le Duc | Vates Hypervisor & Kernel Engineer XCP-ng & Xen Orc= hestra - Vates solutions web: https://vates=2Etech ---=Part.2049.93281b3fe6baf6b5.19fec705570.451b9a4538daf6f6=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:10:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:10:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387637.1628915 (Exim 4.92) (envelope-from ) id 1wtSZz-00043g-35; Mon, 10 Aug 2026 16:10:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387637.1628915; Mon, 10 Aug 2026 16:10:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZy-00043Z-Vt; Mon, 10 Aug 2026 16:10:22 +0000 Received: by outflank-mailman (input) for mailman id 1387637; Mon, 10 Aug 2026 16:10:21 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZx-0003e4-0E for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:10:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSZw-00Exz0-D2 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:10:20 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f79b-e002-0a2a0a5209dd-0a2a45018e00-40 for ; Mon, 10 Aug 2026 18:10:20 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f7e7-5984-0a2a45010019-b9ff1c23956d-4 for ; Mon, 10 Aug 2026 18:10:20 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec705b96000e099.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:10:14 +0000 Received: from leducb (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 8BD63836CA; Mon, 10 Aug 2026 18:10:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=2bfsoiEs2rAdY4I4Kp7G6nvU3IQk8zu75BYtS3wxPMU=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=fAyLc397XD5acd0FvQWQnTjkI0Fj/7gzULhacda+HOeTumzNfTtCYDw7+LWdUiS8dmUbeMVE0 tJnuF5ie+W7b6jV4Sv+IcUxjgt8DMILEdt2TGPrgt7n8E1ztI/dJ+qUH/V2M7NmWADg4zvtBL9N SvYMyV152VL9SAzyv07Ipb65t8l1P8ziNnTE+3gTm29khg4LZrr/RMtuLmxfFdmDwPE0oqbfOl2 ow0L46E2Qpzu1tTtkWinWoCKYleB/RggdaEVQbwx59zsrueWdcNCwFSx8bLBjbaAtmpKFDklDCQ 0lN8ESxIq4VvuCUyJVx76wSMZD+plIp0PZ3JJoe9HFXQ== X-Zone-Loop: fe2e1731f33cf08b1ea41793c6cbaffb04564bcafc2b x-campaign-type: default x-transaction-id: 074ba940-8969-42e1-b2e3-2204decf4e2a x-swg-uid: 01-3cd3a695-e1d4-474c-8385-3d852215669b X-Mailer: Sweego Message-ID: <1786378214.8631fc262581453bbf619ec5b2062170.19fec705b96000e099@vates.tech> x-swg-bid: 1786378214.8631fc262581453bbf619ec5b2062170.19fec705b96000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Baptiste Le Duc To: xen-devel@lists.xenproject.org Cc: Baptiste Le Duc , Doug Goldstein , Stefano Stabellini Subject: [PATCH 4/6] automation/qtb: add unit tests for the QTB framework Date: Mon, 10 Aug 2026 18:09:54 +0200 In-Reply-To: <20260810155543.927954-1-baptiste.le-duc@vates.tech> References: <20260810155543.927954-1-baptiste.le-duc@vates.tech> MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.204b.877beba074a48ee1.19fec70591b.fc1f12a78ffda386=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786378213659 X-purgate-ID: tlsNG-d62444/1786378220-BDC79757-45D141D2/0/0 X-purgate-type: clean X-purgate-size: 26123 ---=Part.204b.877beba074a48ee1.19fec70591b.fc1f12a78ffda386=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The QTB framework is meant to be extended: new test types, new machines and new device trees aim to be added by other people=2E Add pytest coverage of the framework's functions, and of the console-test type's config validation and expect/retry loop, so that such changes get immediate feedback and existing behaviour does not silently regress=2E The suite covers 100% of the framework's statements, so a new code path added without a test shows up as a coverage drop=2E The tests are meant to be run locally, from the Xen tree root: python3 -m pytest automation/scripts/qtb/riscv/unit/ and, with pytest-cov installed, the coverage report is: python3 -m pytest --cov=3Dautomation/scripts/qtb \ automation/scripts/qtb/riscv/unit/ The tests drive fakes rather than QEMU, so they need no artifacts to run= =2E Assisted-by: Claude:claude-opus-5 Signed-off-by: Baptiste Le Duc --- automation/scripts/qtb/riscv/unit/__init__=2Epy | 2 + automation/scripts/qtb/riscv/unit/conftest=2Epy | 42 ++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_config=2Epy | 128 +++++++++++ =2E=2E=2E/qtb/riscv/unit/test_console_test=2Epy | 217 +++++++++++++= +++++ automation/scripts/qtb/riscv/unit/test_dt=2Epy | 99 ++++++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_machine=2Epy | 58 +++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_temp_dir=2Epy | 42 ++++ =2E=2E=2E/scripts/qtb/riscv/unit/test_xen_dt=2Epy | 46 ++++ 8 files changed, 634 insertions(+) create mode 100644 automation/scripts/qtb/riscv/unit/__init__=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/conftest=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_config=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_console_test=2E= py create mode 100644 automation/scripts/qtb/riscv/unit/test_dt=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_machine=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_temp_dir=2Epy create mode 100644 automation/scripts/qtb/riscv/unit/test_xen_dt=2Epy diff --git a/automation/scripts/qtb/riscv/unit/__init__=2Epy b/automation/= scripts/qtb/riscv/unit/__init__=2Epy new file mode 100644 index 0000000000=2E=2Eb234dc5303 --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/__init__=2Epy @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""pytest tests of the framework's own logic=2E""" diff --git a/automation/scripts/qtb/riscv/unit/conftest=2Epy b/automation/= scripts/qtb/riscv/unit/conftest=2Epy new file mode 100644 index 0000000000=2E=2E576eaf13b1 --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/conftest=2Epy @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Shared pytest fixtures for the qtb unit tests=2E""" + +from __future__ import annotations + +import pytest + +from =2E=2Econfig import MachineConfig + + +@pytest=2Efixture +def make_file(tmp_path): + """Return a factory creating a file of `size` bytes, yielding its pat= h=2E""" + + def _make(name: str, size: int =3D 16) -> str: + p =3D tmp_path / name + p=2Ewrite_bytes(b"\0" * size) + return str(p) + + return _make + + +@pytest=2Efixture +def make_machine(): + """Return a factory building a MachineConfig for tests=2E""" + + def _make( + *, + name=3D"m", + binaries=3DNone, + mmu=3D"sv48", + xen_bootargs=3D"", + ) -> MachineConfig: + return MachineConfig( + name=3Dname, + pcpu=3D4, + binaries=3Dbinaries, + mmu_type=3Dmmu, + xen_bootargs=3Dxen_bootargs, + ) + + return _make diff --git a/automation/scripts/qtb/riscv/unit/test_config=2Epy b/automati= on/scripts/qtb/riscv/unit/test_config=2Epy new file mode 100644 index 0000000000=2E=2E790328a13f --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/test_config=2Epy @@ -0,0 +1,128 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Unit tests for the YAML machine-catalog parser=2E""" + +from __future__ import annotations + +from pathlib import Path + +import pytest +import yaml + +from =2E=2Econfig import ( + XEN_BOOTARGS_DEFAULT, + XEN_MMU_TYPE_DEFAULT, + MachineConfig, + _parse_binaries, +) + + +@pytest=2Efixture +def binaries(make_file): + """Raw binaries dict pointing at three existing files=2E""" + return { + "qemu": make_file("qemu-system-riscv64"), + "firmware": make_file("fw=2Ebin"), + "xen": make_file("xen"), + } + + +# ---- _parse_binaries ---- + + +def test_parse_binaries_resolves_existing_paths(binaries): + cfg =3D _parse_binaries(binaries) + assert cfg=2Eqemu =3D=3D Path(binaries["qemu"]) + assert cfg=2Efirmware =3D=3D Path(binaries["firmware"]) + assert cfg=2Exen =3D=3D Path(binaries["xen"]) + + +def test_parse_binaries_missing_key_raises(binaries): + del binaries["xen"] + with pytest=2Eraises(ValueError, match=3D"missing keys"): + _parse_binaries(binaries) + + +def test_parse_binaries_missing_file_raises(binaries, tmp_path): + binaries["xen"] =3D str(tmp_path / "absent") + with pytest=2Eraises(FileNotFoundError): + _parse_binaries(binaries) + + +# ---- MachineConfig=2Efrom_config ---- + + +def _write_yaml(tmp_path, binaries, name=3D"machine-a", **machine_overrid= es): + machine =3D { + "pcpu": 1, + "xen_bootargs": "com1=3Dpoll sched=3Dnull", + } + machine=2Eupdate(machine_overrides) + doc =3D {"binaries": binaries, "machines": {name: machine}} + path =3D tmp_path / "config=2Eyaml" + path=2Ewrite_text(yaml=2Esafe_dump(doc)) + return str(path) + + +def test_from_config_builds_machineconfig(tmp_path, binaries): + path =3D _write_yaml(tmp_path, binaries) + + mc =3D MachineConfig=2Efrom_config(path, "machine-a") + + assert mc=2Ename =3D=3D "machine-a" + assert mc=2Epcpu =3D=3D 1 + assert mc=2Exen_bootargs =3D=3D "com1=3Dpoll sched=3Dnull" + assert mc=2Ebinaries=2Eqemu =3D=3D Path(binaries["qemu"]) + + +def test_from_config_applies_optional_defaults(tmp_path, binaries): + # A machine with only the required keys falls back to the module defa= ults=2E + path =3D _write_yaml( + tmp_path, + binaries, + name=3D"bare", + mmu_type=3DNone, + xen_bootargs=3DNone, + ) + # Drop the keys set to None so the parser sees them as absent=2E + doc =3D yaml=2Esafe_load(Path(path)=2Eread_text()) + for k in ("mmu_type", "xen_bootargs"): + doc["machines"]["bare"]=2Epop(k, None) + Path(path)=2Ewrite_text(yaml=2Esafe_dump(doc)) + + mc =3D MachineConfig=2Efrom_config(path, "bare") + + assert mc=2Emmu_type =3D=3D XEN_MMU_TYPE_DEFAULT + assert mc=2Exen_bootargs =3D=3D XEN_BOOTARGS_DEFAULT + + +def test_from_config_missing_machine_key_raises(tmp_path, binaries): + path =3D _write_yaml(tmp_path, binaries, name=3D"bare") + doc =3D yaml=2Esafe_load(Path(path)=2Eread_text()) + del doc["machines"]["bare"]["pcpu"] + Path(path)=2Ewrite_text(yaml=2Esafe_dump(doc)) + + with pytest=2Eraises(ValueError, match=3D"machine config missing keys= "): + MachineConfig=2Efrom_config(path, "bare") + + +def test_from_config_missing_top_level_key_raises(tmp_path, binaries): + path =3D _write_yaml(tmp_path, binaries) + doc =3D yaml=2Esafe_load(Path(path)=2Eread_text()) + del doc["binaries"] + Path(path)=2Ewrite_text(yaml=2Esafe_dump(doc)) + + with pytest=2Eraises(ValueError, match=3D"missing keys: \\['binaries'= \\]"): + MachineConfig=2Efrom_config(path, "machine-a") + + +def test_from_config_unknown_machine_raises(tmp_path, binaries): + path =3D _write_yaml(tmp_path, binaries) + with pytest=2Eraises(ValueError, match=3D"unknown machine 'nope'"): + MachineConfig=2Efrom_config(path, "nope") + + +def test_from_config_missing_binary_raises(tmp_path, binaries): + binaries["qemu"] =3D str(tmp_path / "gone") + path =3D _write_yaml(tmp_path, binaries) + with pytest=2Eraises(FileNotFoundError): + MachineConfig=2Efrom_config(path, "machine-a") diff --git a/automation/scripts/qtb/riscv/unit/test_console_test=2Epy b/au= tomation/scripts/qtb/riscv/unit/test_console_test=2Epy new file mode 100644 index 0000000000=2E=2Ecf15ed3b1b --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/test_console_test=2Epy @@ -0,0 +1,217 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Unit tests for the console-test test type (console_test=2Epy)=2E""" + +from __future__ import annotations + +from itertools import chain, repeat +from unittest import mock + +import pexpect +import pytest + +from =2E=2Econsole_test=2Econsole_test import ConsoleTest +from =2E=2Econfig import MachineConfig + + +# ---- helpers ---- + + +def _parse_test_data(machine, expect, name=3D"dummy"): + """Validate `expect` against `machine`, without reading a catalog fil= e=2E""" + test_data =3D {"machine": "box", "expect": expect} + with mock=2Epatch=2Eobject(MachineConfig, "from_config", return_value= =3Dmachine): + return ConsoleTest=2E_parse_test_data("config=2Eyaml", test_data,= name) + + +def _console(fail_times: int =3D 0, matches: int =3D 1) -> mock=2EMock: + """Stand in for a pexpect spawn: `fail_times` timeouts, then `matches= ` hits=2E + + Every wait past `matches` times out, so a test that waits more often = than it + should fails instead of silently passing=2E + """ + cons =3D mock=2EMock() + cons=2Eexpect_exact=2Eside_effect =3D chain( + [pexpect=2ETIMEOUT("nope")] * fail_times, + [None] * matches, + repeat(pexpect=2ETIMEOUT("nope")), + ) + return cons + + +def _asked(cons: mock=2EMock) -> list[str]: + """The strings waited for on `cons`, one entry per attempt (matched o= r not)=2E""" + return [call=2Eargs[0] for call in cons=2Eexpect_exact=2Ecall_args_li= st] + + +def _test(expect, machine, **opts): + """Build a ConsoleTest bound to `machine`, skipping the YAML read=2E"= "" + raw =3D { + "machine_catalog": "config=2Eyaml", + "tests": {"dummy": {"machine": "box", "expect": expect, **opts}}, + } + with mock=2Epatch=2Eobject(MachineConfig, "from_config", return_value= =3Dmachine): + return ConsoleTest(raw, "dummy") + + +# ---- _parse_test_data ---- + + +def test_parse_test_data_accepts_a_list_of_strings(make_machine): + machine =3D make_machine() + name, data, got =3D _parse_test_data(machine, {0: ["Hello", "All set = up"]}) + assert (name, got) =3D=3D ("dummy", machine) + assert data["expect"] =3D=3D {0: ["Hello", "All set up"]} + + +def test_parse_test_data_bare_string_raises(make_machine): + # A bare string is refused, not wrapped: the YAML must spell out the = list=2E + machine =3D make_machine() + with pytest=2Eraises(ValueError, match=3D"expects a list of string"): + _parse_test_data(machine, {0: "All set up"}) + + +@pytest=2Emark=2Eparametrize( + "expect", + [ + {-1: ["All set up"]}, # console index below Xen's + {1: ["All set up"]}, # console index above Xen's + {0: ["All set up"], 1: ["More"]}, # Xen's + another unknown + ["All set up"], # no console index + None, + "All set up", # not a map at all + ], +) +def test_parse_test_data_not_the_xen_console_map_raises(expect, make_mach= ine): + machine =3D make_machine() + with pytest=2Eraises(ValueError, match=3D"must map console index 0"): + _parse_test_data(machine, expect) + + +def test_parse_test_data_empty_list_raises(make_machine): + machine =3D make_machine() + with pytest=2Eraises(ValueError, match=3D"Xen has no expected string"= ): + _parse_test_data(machine, {0: []}) + + +def test_parse_test_data_empty_string_in_list_raises(make_machine): + machine =3D make_machine() + with pytest=2Eraises(ValueError, match=3D"Xen expects non-empty strin= gs"): + _parse_test_data(machine, {0: ["All set up", ""]}) + + +def test_parse_test_data_missing_expect_raises(): + with pytest=2Eraises(ValueError, match=3D"missing keys"): + ConsoleTest=2E_parse_test_data("config=2Eyaml", {"machine": "box"= }, "dummy") + + +# ---- _parse_test_cfg ---- + + +def test_parse_test_cfg_missing_machine_catalog_raises(): + with pytest=2Eraises(ValueError, match=3D"missing keys"): + ConsoleTest=2E_parse_test_cfg({"tests": {}}, "dummy") + + +def test_parse_test_cfg_unknown_test_raises(): + raw =3D {"machine_catalog": "config=2Eyaml", "tests": {"a": {}}} + with pytest=2Eraises(ValueError, match=3D"unknown test 'dummy'"): + ConsoleTest=2E_parse_test_cfg(raw, "dummy") + + +# ---- __init__ ---- + + +def test_timeout_and_attempts_are_read(make_machine): + test =3D _test({0: ["All set up"]}, make_machine(), timeout=3D7, atte= mpts=3D2) + assert (test=2Etimeout, test=2Eattempts) =3D=3D (7, 2) + + +def test_timeout_below_one_raises(make_machine): + with pytest=2Eraises(ValueError, match=3D"timeout < 1"): + _test({0: ["All set up"]}, make_machine(), timeout=3D0) + + +def test_attempts_below_one_raises(make_machine): + with pytest=2Eraises(ValueError, match=3D"attempts < 1"): + _test({0: ["All set up"]}, make_machine(), attempts=3D0) + + +# ---- run ---- + + +def test_run_expects_each_string_in_order_on_con0(make_machine): + test =3D _test({0: ["first", "then"]}, make_machine()) + vm =3D mock=2EMock(console=3D_console(matches=3D2)) + + test=2Erun(vm) + + assert _asked(vm=2Econsole) =3D=3D ["first", "then"] + + +def test_run_xen_console_not_wired_raises(make_machine): + test =3D _test({0: ["All set up"]}, make_machine()) + vm =3D mock=2EMock(console=3DNone) + + with pytest=2Eraises(RuntimeError, match=3D"not launched"): + test=2Erun(vm) + + +# ---- _expect_string ---- + + +def test_expect_string_retries_after_a_timeout(make_machine): + test =3D _test({0: ["All set up"]}, make_machine(), attempts=3D3) + cons =3D _console(fail_times=3D2) + + test=2E_expect_string(cons, "All set up") + + assert _asked(cons) =3D=3D ["All set up"] * 3 + + +def test_expect_string_raises_once_attempts_are_spent(make_machine): + test =3D _test({0: ["All set up"]}, make_machine(), attempts=3D2) + cons =3D _console(matches=3D0) + + with pytest=2Eraises(pexpect=2ETIMEOUT): + test=2E_expect_string(cons, "All set up") + + assert _asked(cons) =3D=3D ["All set up"] * 2 + + +# ---- config IO ---- + + +def test_list_tests_reads_the_type_yaml(): + names =3D ConsoleTest=2Elist_tests("console_test/console-test=2Eyaml"= ) + assert "dom0less-1smp-0domu-1vcpu-aplic-imsic-null" in names + + +def test_list_tests_without_a_tests_key_returns_empty(): + with mock=2Epatch=2Eobject(ConsoleTest, "_load_yaml", return_value=3D= {}): + assert ConsoleTest=2Elist_tests("console-test=2Eyaml") =3D=3D [] + + +def test_from_config_builds_instance(make_machine): + machine =3D make_machine() + + raw =3D { + "machine_catalog": "config=2Eyaml", + "tests": {"dummy": {"machine": "box", "expect": {0: ["All set up"= ]}}}, + } + # Mock the YAML read and the catalog lookup: only the build logic is = under test=2E + with ( + mock=2Epatch=2Eobject(ConsoleTest, "_load_yaml", return_value=3Dr= aw), + mock=2Epatch=2Eobject(MachineConfig, "from_config", return_value= =3Dmachine), + ): + test =3D ConsoleTest=2Efrom_config("console-test=2Eyaml", "dummy"= ) + + assert test=2Ename =3D=3D "dummy" + assert test=2Etype_id =3D=3D "console-test" + assert test=2Emachine is machine + assert test=2Eexpect =3D=3D {0: ["All set up"]} + + +def test_from_config_unknown_test_raises(): + # Also pins from_config's argument order (config file, then test name= )=2E + with pytest=2Eraises(ValueError, match=3D"unknown test 'nope'"): + ConsoleTest=2Efrom_config("console_test/console-test=2Eyaml", "no= pe") diff --git a/automation/scripts/qtb/riscv/unit/test_dt=2Epy b/automation/s= cripts/qtb/riscv/unit/test_dt=2Epy new file mode 100644 index 0000000000=2E=2E2201a8651f --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/test_dt=2Epy @@ -0,0 +1,99 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Unit tests for the device-tree compile path (dt=2Epy)=2E""" + +from __future__ import annotations + +import shutil +from unittest import mock + +import pytest + +from =2E=2E import dt + +_HAS_DTC =3D shutil=2Ewhich("dtc") is not None +_MINIMAL_DTS =3D "/dts-v1/;\n/ { };\n" + + +# ---- _compile_dts (dtc wrapper) ---- + + +def test_compile_dts_invokes_dtc(tmp_path): + src =3D tmp_path / "in=2Edts" + src=2Ewrite_text(_MINIMAL_DTS) + dtb =3D tmp_path / "in=2Edtb" + + with mock=2Epatch=2Eobject(dt=2Esubprocess, "run") as run: + dt=2E_compile_dts(src, dtb) + + run=2Eassert_called_once() + argv =3D run=2Ecall_args=2Eargs[0] + assert argv =3D=3D ["dtc", "-I", "dts", "-O", "dtb", "-o", str(dtb), = str(src)] + assert run=2Ecall_args=2Ekwargs["check"] is True + assert run=2Ecall_args=2Ekwargs["capture_output"] is True + + +def test_compile_dts_missing_dtc_raises_runtimeerror(tmp_path): + src, dtb =3D tmp_path / "a=2Edts", tmp_path / "a=2Edtb" + src=2Ewrite_text(_MINIMAL_DTS) + + with mock=2Epatch=2Eobject(dt=2Esubprocess, "run", side_effect=3DFile= NotFoundError): + with pytest=2Eraises(RuntimeError, match=3D"dtc not found"): + dt=2E_compile_dts(src, dtb) + + +def test_compile_dts_dtc_failure_raises_runtimeerror(tmp_path): + src, dtb =3D tmp_path / "a=2Edts", tmp_path / "a=2Edtb" + src=2Ewrite_text(_MINIMAL_DTS) + err =3D dt=2Esubprocess=2ECalledProcessError(1, "dtc", output=3D"out"= , stderr=3D"syntax error") + + with mock=2Epatch=2Eobject(dt=2Esubprocess, "run", side_effect=3Derr)= : + with pytest=2Eraises(RuntimeError, match=3D"syntax error"): + dt=2E_compile_dts(src, dtb) + + +# ---- compile_to_dtb path handling ---- + + +def test_compile_to_dtb_missing_source_raises_filenotfound(tmp_path): + with pytest=2Eraises(FileNotFoundError, match=3D"not found"): + dt=2Ecompile_to_dtb(tmp_path / "nope=2Edts", tmp_path) + + +def test_compile_to_dtb_missing_out_dir_raises_filenotfound(tmp_path): + src =3D tmp_path / "a=2Edts" + src=2Ewrite_text(_MINIMAL_DTS) + + with pytest=2Eraises(FileNotFoundError, match=3D"doesn't exist"): + dt=2Ecompile_to_dtb(src, tmp_path / "absent") + + +def test_compile_to_dtb_source_goes_to_out_dir_with_dtb_suffix(tmp_path): + src =3D tmp_path / "host-1smp=2Edts" + src=2Ewrite_text(_MINIMAL_DTS) + out =3D tmp_path / "binaries" + out=2Emkdir() + + with mock=2Epatch=2Eobject(dt, "_compile_dts") as compile_mock: + result =3D dt=2Ecompile_to_dtb(src, out) + + assert result =3D=3D out / "host-1smp=2Edtb" + compile_mock=2Eassert_called_once_with(src, out / "host-1smp=2Edtb") + + +# ---- write_dts ---- + + +def test_write_dts_writes_source_under_out_dir(tmp_path): + src =3D dt=2Ewrite_dts(_MINIMAL_DTS, name=3D"unit", out_dir=3Dtmp_pat= h) + + assert src =3D=3D tmp_path / "unit=2Edts" + assert src=2Eread_text() =3D=3D _MINIMAL_DTS + + +@pytest=2Emark=2Eskipif(not _HAS_DTC, reason=3D"dtc not installed") +def test_write_then_compile_produces_dtb(tmp_path): + src =3D dt=2Ewrite_dts(_MINIMAL_DTS, name=3D"unit", out_dir=3Dtmp_pat= h) + dtb =3D dt=2Ecompile_to_dtb(src, tmp_path) + + assert dtb=2Eis_file() + assert dtb=2Esuffix =3D=3D "=2Edtb" diff --git a/automation/scripts/qtb/riscv/unit/test_machine=2Epy b/automat= ion/scripts/qtb/riscv/unit/test_machine=2Epy new file mode 100644 index 0000000000=2E=2E0a90a5545b --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/test_machine=2Epy @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Unit tests for RiscvTestMachine QEMU argument assembly=2E""" + +from __future__ import annotations + +from unittest import mock + +from =2E=2Emachine import RiscvTestMachine +from =2E=2Econfig import MACHINE_MEMORY, BinariesConfig + + +def _binaries(tmp_path): + paths =3D {} + for name in ("qemu", "firmware", "xen"): + p =3D tmp_path / name + p=2Ewrite_bytes(b"") + paths[name] =3D str(p) + return BinariesConfig(**paths) + + +def _machine(mc) -> RiscvTestMachine: + """Build the machine with QtbMachine=2E__init__ stubbed out (it spawn= s QEMU)=2E""" + with mock=2Epatch("qemu=2Eqtb=2EQtbMachine=2E__init__", return_value= =3DNone): + return RiscvTestMachine(mc, timeout=3D30) + + +def test_init_forwards_cpus_to_qtbmachine(tmp_path, make_machine): + mc =3D make_machine(name=3D"machine", binaries=3D_binaries(tmp_path)) + + with mock=2Epatch("qemu=2Eqtb=2EQtbMachine=2E__init__", return_value= =3DNone) as base_init: + vm =3D RiscvTestMachine(mc, timeout=3D30, log_dir=3D"/logs") + + assert vm=2Emachine_conf is mc + assert base_init=2Ecall_args=2Ekwargs =3D=3D { + "memory": MACHINE_MEMORY, + "cpus": mc=2Epcpu, + "mirror_console": False, + "timeout": 30, + "log_dir": "/logs", + } + + +def test_resolve_binary_is_the_configured_qemu(tmp_path, make_machine): + mc =3D make_machine(name=3D"machine", binaries=3D_binaries(tmp_path)) + + assert _machine(mc)=2E_resolve_binary() =3D=3D str(mc=2Ebinaries=2Eqe= mu) + + +def test_machine_args_wires_firmware_kernel_and_dtb(tmp_path, make_machin= e): + mc =3D make_machine(name=3D"machine", binaries=3D_binaries(tmp_path)) + + args =3D list(_machine(mc)=2E_machine_args(memory=3D2048, cpus=3D4)) + + assert args[args=2Eindex("-bios") + 1] =3D=3D str(mc=2Ebinaries=2Efir= mware) + assert args[args=2Eindex("-kernel") + 1] =3D=3D str(mc=2Ebinaries=2Ex= en) + assert args[args=2Eindex("-dtb") + 1] =3D=3D str(mc=2Edt=2Edtb) + assert args[args=2Eindex("-m") + 1] =3D=3D "2048" + assert args[args=2Eindex("-smp") + 1] =3D=3D "4" diff --git a/automation/scripts/qtb/riscv/unit/test_temp_dir=2Epy b/automa= tion/scripts/qtb/riscv/unit/test_temp_dir=2Epy new file mode 100644 index 0000000000=2E=2Ed595d824d7 --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/test_temp_dir=2Epy @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Unit tests for the temp_dir scratch-directory singleton=2E""" + +from __future__ import annotations + +import pytest + +from =2E=2E import paths + + +@pytest=2Efixture(autouse=3DTrue) +def _reset_singleton(): + # Force each test to begin with fresh temp dir + yield + paths=2Ecleanup_temp_dir() + + +def test_temp_dir_exists_and_prefixed(): + d =3D paths=2Etemp_dir() + assert d=2Eis_dir() + assert d=2Ename=2Estartswith("qtb-") + + +def test_temp_dir_is_singleton(): + assert paths=2Etemp_dir() =3D=3D paths=2Etemp_dir() + + +def test_temp_dir_handle_kept_alive(): + h =3D paths=2E_temp_dir_handle() + assert h is paths=2E_temp_dir_handle() + assert h=2Ename =3D=3D str(paths=2Etemp_dir()) + + +def test_cleanup_temp_dir_removes_and_resets(): + d =3D paths=2Etemp_dir() + assert d=2Eis_dir() + paths=2Ecleanup_temp_dir() + assert not d=2Eexists() + # Cache reset: next call builds a fresh, existing dir, not the gone o= ne=2E + fresh =3D paths=2Etemp_dir() + assert fresh=2Eis_dir() + assert fresh !=3D d diff --git a/automation/scripts/qtb/riscv/unit/test_xen_dt=2Epy b/automati= on/scripts/qtb/riscv/unit/test_xen_dt=2Epy new file mode 100644 index 0000000000=2E=2E37c4055b31 --- /dev/null +++ b/automation/scripts/qtb/riscv/unit/test_xen_dt=2Epy @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Unit tests for xen_dt device-tree generation=2E""" + +from __future__ import annotations + +from unittest import mock + +from =2E=2E import xen_dt + + +# ---- _render_xen_dts ---- + + +def test_render_injects_bootargs(make_machine): + machine =3D make_machine(xen_bootargs=3D"com1=3Dpoll sched=3Dnull") + out =3D xen_dt=2E_render_xen_dts(machine) + + assert 'xen,xen-bootargs =3D "com1=3Dpoll sched=3Dnull";' in out + + +def test_render_injects_xen_mmu_type(make_machine): + machine =3D make_machine(mmu=3D"sv39") + out =3D xen_dt=2E_render_xen_dts(machine) + + assert 'mmu-type =3D "riscv,sv39";' in out + + +# ---- build_xen_device_tree ---- + + +def test_build_xen_device_tree_compiles(tmp_path, make_machine): + machine =3D make_machine(name=3D"unit-test") + dts =3D tmp_path / "unit-test=2Edts" + dtb =3D tmp_path / "unit-test=2Edtb" + with ( + mock=2Epatch=2Eobject(xen_dt, "temp_dir", return_value=3Dtmp_path= ), + mock=2Epatch=2Eobject(xen_dt, "write_dts", return_value=3Ddts) as= write_dts, + mock=2Epatch=2Eobject(xen_dt, "compile_to_dtb", return_value=3Ddt= b) as compile_to_dtb, + ): + result =3D xen_dt=2Ebuild_xen_device_tree(machine) + + write_dts=2Eassert_called_once() + assert write_dts=2Ecall_args=2Eargs[1] =3D=3D machine=2Ename + compile_to_dtb=2Eassert_called_once_with(dts, tmp_path) + assert result=2Edts =3D=3D dts + assert result=2Edtb =3D=3D dtb -- Baptiste Le Duc | Vates Hypervisor & Kernel Engineer XCP-ng & Xen Orc= hestra - Vates solutions web: https://vates=2Etech ---=Part.204b.877beba074a48ee1.19fec70591b.fc1f12a78ffda386=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:10:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:10:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387636.1628906 (Exim 4.92) (envelope-from ) id 1wtSZx-0003q4-N0; Mon, 10 Aug 2026 16:10:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387636.1628906; Mon, 10 Aug 2026 16:10:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZx-0003px-JW; Mon, 10 Aug 2026 16:10:21 +0000 Received: by outflank-mailman (input) for mailman id 1387636; Mon, 10 Aug 2026 16:10:20 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZw-0003V4-M9 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:10:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSZw-008NAc-2g for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:10:20 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f7dd-bab6-0a2a0a5309dd-0a2a45049fd2-30 for ; Mon, 10 Aug 2026 18:10:20 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f7e9-b57f-0a2a45040019-b9ff1c128dc1-4 for ; Mon, 10 Aug 2026 18:10:19 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec7059c4000e099.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:10:13 +0000 Received: from leducb (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 17DBA83637; Mon, 10 Aug 2026 18:10:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=4gwMD6zXp3l+68wW5VATdQU87ALcOqMpO+ibR2khxMk=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=qoT8XPsVnYTVy3ZrL7EMcKfbekmhFjlYs+vYaEbWIkE2S6AB/dYx3k6w/IsiqAmpaj9m9Her3 Q/5jhKRN/kThgy/9RW/r4TqYU/SaKWPKxZIyoZZTmfYsd71S5hYxl0TCocyt+mT6W4P8HtDVuJq v8qMYdWyiZxX2ydCPKK6xpZiAmycYLQK8KTaOm9gB6i7Oek3U3NWFvuv2s8tiLz/H6bEmre05ez Y6w3FXK2nMNonZs83EhWtQWe1BYRzRRaBvKa/rMAfFLdurEDWglzubjkKVisfmzAArVPIf69E9t wnIHsdXEnK8/e4/1uIc/TzIltv1AMIcPFo/v1EkOPZpg== X-Zone-Loop: 6278c9a605463988f0e2096657a2f01e6a13ac656913 x-campaign-type: default x-transaction-id: 2f24dc91-d34a-4ced-b8d8-e3a2d1e72128 x-swg-uid: 01-78e2c1f4-9781-4c1e-a18a-116b488b716b X-Mailer: Sweego Message-ID: <1786378213.8631fc262581453bbf619ec5b2062170.19fec7059c4000e099@vates.tech> x-swg-bid: 1786378213.8631fc262581453bbf619ec5b2062170.19fec7059c4000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Baptiste Le Duc To: xen-devel@lists.xenproject.org Cc: Baptiste Le Duc , Doug Goldstein , Stefano Stabellini Subject: [PATCH 3/6] automation/qtb: add Python QTB framework with the console-test type Date: Mon, 10 Aug 2026 18:09:53 +0200 In-Reply-To: <20260810155543.927954-1-baptiste.le-duc@vates.tech> References: <20260810155543.927954-1-baptiste.le-duc@vates.tech> MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.204a.3666f13f27356d06.19fec70574c.2d6a0cec16cef1a9=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786378213196 X-purgate-ID: tlsNG-ebf023/1786378220-528C9B50-72A61DF8/0/0 X-purgate-type: clean X-purgate-size: 32316 ---=Part.204a.3666f13f27356d06.19fec70574c.2d6a0cec16cef1a9=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Port qemu-smoke-riscv64=2Esh from shell to a Python QTB framework that driv= es QEMU over qtest/QMP and the console to run riscv64 smoke tests=2E The framework is based on AMD's QTB (QEMU Test Bench) framework, which is not yet upstream in QEMU but is planned to be soon=2E This is a riscv64 adaptation of it=2E The framework: - parses a test config (config=2Eyaml) into typed machine descriptions (config=2Epy)=2E The host device tree of a machine is compiled on firs= t use of MachineConfig=2Edt, so a run that never boots (`list`, or a config error) does not invoke dtc=2E - generates the Xen host device tree from a Jinja2 template and compiles it to a DTB with dtc (xen_dt=2Epy, dt=2Epy)=2E - assembles the QEMU command line in RiscvTestMachine (machine=2Epy), resolving artifact paths via paths=2Epy=2E - defines an abstract RiscvQtbTest base shared by every test type (qtb_test=2Epy)=2E - wires it together behind a CLI: the test type is a leading positional with `list` and `run` subcommands (qemu_smoke_riscv64=2Epy)=2E console-test test type comes with it=2E It boots a machine from the shared catalog and asserts every expected string is printed on Xen's own console within the timeout=2E Its tests live in console-test=2Eyaml, which maps co= nsole indices to the expected output strings=2E This makes it straightforward to add support for a domU console index once Xen provides it=2E Assisted-by: Claude:claude-opus-5 Signed-off-by: Baptiste Le Duc --- automation/scripts/qemu_smoke_riscv64=2Epy | 122 +++++++++++++++ automation/scripts/qtb/__init__=2Epy | 2 + automation/scripts/qtb/riscv/__init__=2Epy | 9 ++ automation/scripts/qtb/riscv/config=2Epy | 125 +++++++++++++++ automation/scripts/qtb/riscv/config=2Eyaml | 19 +++ =2E=2E=2E/qtb/riscv/console_test/__init__=2Epy | 4 + =2E=2E=2E/qtb/riscv/console_test/console-test=2Eyaml | 18 +++ =2E=2E=2E/qtb/riscv/console_test/console_test=2Epy | 145 +++++++++++++= +++++ automation/scripts/qtb/riscv/dt=2Epy | 57 +++++++ automation/scripts/qtb/riscv/machine=2Epy | 56 +++++++ automation/scripts/qtb/riscv/paths=2Epy | 51 ++++++ automation/scripts/qtb/riscv/qtb_test=2Epy | 53 +++++++ automation/scripts/qtb/riscv/xen_dt=2Epy | 58 +++++++ 13 files changed, 719 insertions(+) create mode 100755 automation/scripts/qemu_smoke_riscv64=2Epy create mode 100644 automation/scripts/qtb/__init__=2Epy create mode 100644 automation/scripts/qtb/riscv/__init__=2Epy create mode 100644 automation/scripts/qtb/riscv/config=2Epy create mode 100644 automation/scripts/qtb/riscv/config=2Eyaml create mode 100644 automation/scripts/qtb/riscv/console_test/__init__=2Ep= y create mode 100644 automation/scripts/qtb/riscv/console_test/console-test= =2Eyaml create mode 100644 automation/scripts/qtb/riscv/console_test/console_test= =2Epy create mode 100644 automation/scripts/qtb/riscv/dt=2Epy create mode 100644 automation/scripts/qtb/riscv/machine=2Epy create mode 100644 automation/scripts/qtb/riscv/paths=2Epy create mode 100644 automation/scripts/qtb/riscv/qtb_test=2Epy create mode 100644 automation/scripts/qtb/riscv/xen_dt=2Epy diff --git a/automation/scripts/qemu_smoke_riscv64=2Epy b/automation/scrip= ts/qemu_smoke_riscv64=2Epy new file mode 100755 index 0000000000=2E=2Ef338fafcc2 --- /dev/null +++ b/automation/scripts/qemu_smoke_riscv64=2Epy @@ -0,0 +1,122 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2=2E0-only +"""CLI launcher for the qtb riscv64 dom0less tests=2E + +The test type comes first (e=2Eg=2E `console-test`), then a command=2E Ea= ch type +reads its own config file, which ships with the type=2E + +Commands: + list Print every test the type defines in the config, then exit=2E + run Boot one test's machine under QEMU and drive it to a pass/fail + verdict=2E + +Usage: + =2E/qemu_smoke_riscv64=2Epy console-test list + =2E/qemu_smoke_riscv64=2Epy console-test run dom0less-1smp-0domu-1vcp= u-aplic-imsic-null +""" + +from __future__ import annotations + +import argparse +import logging +import sys +from collections=2Eabc import Sequence +from traceback import extract_tb, format_exc + +from qtb=2Eriscv import RiscvQtbTest, TEST_TYPES, RiscvTestMachine, clean= up_temp_dir + +logger =3D logging=2EgetLogger(__name__) + + +def _run_test(test: RiscvQtbTest, log_dir: str | None) -> int: + """Compile the machine's device trees, boot it, and run the test=2E""= " + vm =3D RiscvTestMachine(test=2Emachine, timeout=3Dtest=2Etimeout, log= _dir=3Dlog_dir) + try: + with vm: + vm=2Elaunch() + test=2Erun(vm) + except Exception as exc: + print( + f"FAIL: {test=2Ename}: {type(exc)=2E__name__}: {exc}", + file=3Dsys=2Estderr, + flush=3DTrue, + ) + return 1 + + print(f"PASS: {test=2Ename}", flush=3DTrue) + return 0 + + +def _cmd_list(ns: argparse=2ENamespace) -> int: + """` list`: print every test the type defines=2E""" + for name in ns=2Ecls=2Elist_tests(ns=2Ecls=2Econfig_file): + print(name) + return 0 + + +def _cmd_run(ns: argparse=2ENamespace) -> int: + """` run`: build the named test and drive it to a verdict=2E""" + test =3D ns=2Ecls=2Efrom_config(ns=2Ecls=2Econfig_file, ns=2Etest) + return _run_test(test, ns=2Elog_dir) + + +def setup_parser() -> argparse=2EArgumentParser: + parser =3D argparse=2EArgumentParser( + description=3D"Launch a qtb riscv64 dom0less test: " + "qemu_smoke_riscv64=2Epy =2E", + ) + common_args =3D argparse=2EArgumentParser(add_help=3DFalse) + common_args=2Eadd_argument( + "-v", "--verbose", action=3D"store_true", help=3D"Print debug out= put" + ) + run_args =3D argparse=2EArgumentParser(add_help=3DFalse) + run_args=2Eadd_argument("test", help=3D"Name of the test to run=2E") + run_args=2Eadd_argument( + "--log-dir", + default=3DNone, + metavar=3D"DIR", + help=3D"Directory for all logs (QEMU process log, qtest, and the = " + "consoles as con=2Elog)=2E When unset, no logs are written=2E"= , + ) + + # qemu_smoke_riscv64=2Epy + types =3D parser=2Eadd_subparsers(dest=3D"type", required=3DTrue) + for cls in TEST_TYPES: + desc =3D cls=2Edescription + cmds =3D types=2Eadd_parser( + cls=2Etype_id, help=3Ddesc, description=3Ddesc + )=2Eadd_subparsers(dest=3D"command", required=3DTrue) + cmds=2Eadd_parser( + "list", + parents=3D[common_args], + description=3Ddesc, + help=3D"List the tests for the type and exit=2E", + )=2Eset_defaults(func=3D_cmd_list, cls=3Dcls) + cmds=2Eadd_parser( + "run", + parents=3D[common_args, run_args], + description=3Ddesc, + help=3D"Run one test=2E", + )=2Eset_defaults(func=3D_cmd_run, cls=3Dcls) + + return parser + + +def main(argv: Sequence[str] | None =3D None) -> int: + ns =3D setup_parser()=2Eparse_args(argv) + logging=2EbasicConfig( + level=3Dlogging=2EDEBUG if ns=2Everbose else logging=2EWARNING, f= ormat=3D"%(message)s" + ) + try: + return ns=2Efunc(ns) + except Exception as exc: + logger=2Edebug(format_exc()) + frame =3D extract_tb(exc=2E__traceback__)[-1] + print(f"{frame=2Efilename}:{frame=2Elineno}: {exc}") + return 2 + finally: + cleanup_temp_dir() + + +if __name__ =3D=3D "__main__": + sys=2Eexit(main()) diff --git a/automation/scripts/qtb/__init__=2Epy b/automation/scripts/qtb= /__init__=2Epy new file mode 100644 index 0000000000=2E=2Ea0e6e76cb2 --- /dev/null +++ b/automation/scripts/qtb/__init__=2Epy @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""QTB (QEMU Test Bench) test frameworks=2E""" diff --git a/automation/scripts/qtb/riscv/__init__=2Epy b/automation/scrip= ts/qtb/riscv/__init__=2Epy new file mode 100644 index 0000000000=2E=2E6a6c48be32 --- /dev/null +++ b/automation/scripts/qtb/riscv/__init__=2Epy @@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""QTB riscv64 test framework package=2E""" + +from =2Eqtb_test import RiscvQtbTest +from =2Econsole_test import ConsoleTest +from =2Emachine import RiscvTestMachine +from =2Epaths import cleanup_temp_dir + +TEST_TYPES: tuple[type[RiscvQtbTest], =2E=2E=2E] =3D (ConsoleTest,) diff --git a/automation/scripts/qtb/riscv/config=2Epy b/automation/scripts= /qtb/riscv/config=2Epy new file mode 100644 index 0000000000=2E=2E92b5ea0f55 --- /dev/null +++ b/automation/scripts/qtb/riscv/config=2Epy @@ -0,0 +1,125 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""YAML config parser for qtb-based Xen riscv64 tests=2E + +Parsing steps: + - validate the YAML + - build the dataclasses: the host device tree is compiled on first us= e + of MachineConfig=2Edt +""" + +from __future__ import annotations + +import functools +import inspect +from dataclasses import dataclass +from functools import cached_property +from pathlib import Path + +import yaml + +from =2Epaths import resolve_binary, resolve_path +from =2Exen_dt import DeviceTree, build_xen_device_tree + +XEN_MMU_TYPE_DEFAULT: str =3D "sv48" +XEN_BOOTARGS_DEFAULT: str =3D "" + +MACHINE_MEMORY: int =3D 2048 +MACHINE_INTERRUPT_CONTROLLER: str =3D "aplic-imsic" + + +def required_keys(argument_name: str, keys: set, label: str =3D ""): + """Validate the dict passed as `argument_name` has every key in `keys= `=2E""" + keys =3D set(keys) + + def decorate(func): + sig =3D inspect=2Esignature(func) + + @functools=2Ewraps(func) + def wrapper(*args, **kwargs): + arg =3D sig=2Ebind(*args, **kwargs)=2Earguments[argument_name= ] + missing =3D keys - arg=2Ekeys() + if missing: + raise ValueError( + f"{label or func=2E__name__} missing keys: {sorted(mi= ssing)}" + ) + return func(*args, **kwargs) + + return wrapper + + return decorate + + +@dataclass +class BinariesConfig: + qemu: Path + firmware: Path + xen: Path + + +@required_keys("raw", {"qemu", "firmware", "xen"}, label=3D"binaries conf= ig") +def _parse_binaries(raw: dict) -> BinariesConfig: + return BinariesConfig( + qemu=3Dresolve_binary(raw["qemu"]), + firmware=3Dresolve_binary(raw["firmware"]), + xen=3Dresolve_binary(raw["xen"]), + ) + + +@required_keys("raw", {"pcpu"}, label=3D"machine config") +def _parse_machine( + raw: dict, + binaries: BinariesConfig, + machine: str, +) -> MachineConfig: + return MachineConfig( + name=3Dmachine, + pcpu=3Draw["pcpu"], + binaries=3Dbinaries, + mmu_type=3Draw=2Eget("mmu_type", XEN_MMU_TYPE_DEFAULT), + xen_bootargs=3Draw=2Eget("xen_bootargs", XEN_BOOTARGS_DEFAULT), + ) + + +@dataclass(frozen=3DTrue) +class MachineConfig: + """One named machine: the test-agnostic description of what to boot= =2E + + A machine is reusable across test types; a test (see RiscvQtbTest + subclasses) picks a machine by name and layers its own parameters on = top=2E + """ + + name: str + pcpu: int + binaries: BinariesConfig + mmu_type: str # Xen (host) MMU type, injected into the host dts cpus= =2E + xen_bootargs: str + + @classmethod + def from_config(cls, file_name: str, machine: str) -> MachineConfig: + """Build only the single named machine from the catalog at `path`= =2E + + A test run boots one machine, so there is no need to construct th= e + whole catalog: parse the YAML, validate the shared binaries, and + build just the requested entry=2E + """ + fpath: Path =3D resolve_path(file_name) + raw: dict =3D yaml=2Esafe_load(fpath=2Eread_text()) + + required =3D ("binaries", "machines") + missing =3D [k for k in required if k not in raw] + if missing: + raise ValueError(f"Global config {file_name} missing keys: {m= issing}") + + binaries: BinariesConfig =3D _parse_binaries(raw["binaries"]) + + machines =3D raw["machines"] + if machine not in machines: + known =3D ", "=2Ejoin(sorted(machines)) or "(none)" + raise ValueError(f"unknown machine {machine!r}; known machine= s: {known}") + + return _parse_machine(machines[machine], binaries, machine) + + @cached_property + def dt(self) -> DeviceTree: + """Host device tree, compiled on first use=2E""" + return build_xen_device_tree(self) diff --git a/automation/scripts/qtb/riscv/config=2Eyaml b/automation/scrip= ts/qtb/riscv/config=2Eyaml new file mode 100644 index 0000000000=2E=2Ec1b69ad441 --- /dev/null +++ b/automation/scripts/qtb/riscv/config=2Eyaml @@ -0,0 +1,19 @@ +# Shared config for the qtb riscv64 tests +# +# A machine is the test-agnostic description of what to boot (cpus, Xen c= ommand +# line)=2E Test YAMLs (e=2Eg=2E console-test=2Eyaml) pick a machine by na= me and layer +# their own parameters on top=2E +# +# Path resolution (see paths=2Epy): `binaries:` entries resolve against +# $QTB_BINARIES_DIR env var if defined else `binaries`=2E Absolute paths = used +# as-is=2E + +binaries: + qemu: qemu-system-riscv64 + firmware: opensbi-riscv64-generic-fw_dynamic=2Ebin + xen: xen + +machines: + dom0less-1smp-0domu-1vcpu-aplic-imsic-null: + xen_bootargs: "sched=3Dnull" + pcpu: 1 diff --git a/automation/scripts/qtb/riscv/console_test/__init__=2Epy b/aut= omation/scripts/qtb/riscv/console_test/__init__=2Epy new file mode 100644 index 0000000000=2E=2E5db5569965 --- /dev/null +++ b/automation/scripts/qtb/riscv/console_test/__init__=2Epy @@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""console-test type package=2E""" + +from =2Econsole_test import ConsoleTest diff --git a/automation/scripts/qtb/riscv/console_test/console-test=2Eyaml= b/automation/scripts/qtb/riscv/console_test/console-test=2Eyaml new file mode 100644 index 0000000000=2E=2Ecec0edc510 --- /dev/null +++ b/automation/scripts/qtb/riscv/console_test/console-test=2Eyaml @@ -0,0 +1,18 @@ +# Console string expectation test (run with: qemu_smoke_riscv64=2Epy cons= ole-test run )=2E +# +# Each test uses a machine from config=2Eyaml and maps a console index to= the list +# of string(s) expected on that console: 0 is Xen's own console=2E The ru= nner boots +# the machine and asserts each string is printed within the timeout=2E No= thing is +# injected=2E +# +# Test options: +# timeout: int # timeout between each string match (in seconds) +# attempts: int # number of tries for a wait before failing=2E Default = 3 (min =3D 1) + +machine_catalog: config=2Eyaml + +tests: + dom0less-1smp-0domu-1vcpu-aplic-imsic-null: + machine: dom0less-1smp-0domu-1vcpu-aplic-imsic-null + expect: + 0: ["All set up"] diff --git a/automation/scripts/qtb/riscv/console_test/console_test=2Epy b= /automation/scripts/qtb/riscv/console_test/console_test=2Epy new file mode 100644 index 0000000000=2E=2E95540fd388 --- /dev/null +++ b/automation/scripts/qtb/riscv/console_test/console_test=2Epy @@ -0,0 +1,145 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Console string expectation test (`type: console-test`)=2E + +Per console: assert each expected string is printed within the timeout=2E +Nothing is injected; this only watches console output=2E + +YAML (console-test=2Eyaml): each test names the machine it boots (tests m= ay +share one) and maps a console index to the string(s) expected on it: 0 is +Xen's own console=2E + + machine_catalog: config=2Eyaml + tests: + dom0less-1smp-0domu-1vcpu-aplic-imsic-null: # test name (run posit= ional) + machine: dom0less-1smp-0domu-1vcpu-aplic-imsic-null # from confi= g=2Eyaml + expect: # console index -> str= ing(s) + 0: [All set up] +""" + +from __future__ import annotations + +import logging +from typing import ClassVar + +import pexpect +import yaml + +from =2E=2Epaths import resolve_path +from =2E=2Econfig import MachineConfig, required_keys +from =2E=2Eqtb_test import TIMEOUT_DEFAULT, RiscvQtbTest +from =2E=2Emachine import RiscvTestMachine + +logger =3D logging=2EgetLogger(__name__) + +TYPE_ID: str =3D "console-test" + +CONFIG_FILE_DEFAULT: str =3D "console_test/console-test=2Eyaml" +DESCRIPTION_DEFAULT: str =3D "Assert expected string(s) are printed on th= e Xen console" +ATTEMPTS_DEFAULT: int =3D 3 + +XEN_CONS_IDX: int =3D 0 + + +class ConsoleTest(RiscvQtbTest): + type_id: ClassVar[str] =3D TYPE_ID + description: ClassVar[str] =3D DESCRIPTION_DEFAULT + config_file: ClassVar[str] =3D CONFIG_FILE_DEFAULT + + def __init__(self, raw: dict, test_name: str) -> None: + self=2Ename, self=2Edata, self=2Emachine =3D self=2E_parse_test_c= fg(raw, test_name) + + self=2Eexpect =3D self=2Edata["expect"] # expected console strin= g + + self=2Etimeout =3D int(self=2Edata=2Eget("timeout", TIMEOUT_DEFAU= LT)) + if self=2Etimeout < 1: + raise ValueError("timeout < 1, must be at least 1") + + self=2Eattempts =3D int(self=2Edata=2Eget("attempts", ATTEMPTS_DE= FAULT)) + if self=2Eattempts < 1: + raise ValueError("attempts < 1, must be at least 1") + + @staticmethod + def _load_yaml(path) -> dict: + return yaml=2Esafe_load(resolve_path(path)=2Eread_text()) + + @classmethod + def from_config(cls, config_file: str, test_name: str) -> ConsoleTest= : + return cls(cls=2E_load_yaml(config_file), test_name) + + @staticmethod + @required_keys("test_data", {"machine", "expect"}) + def _parse_test_data( + machine_catalog: str, test_data: dict, test_name: str + ) -> tuple[str, dict, MachineConfig]: + """Parse test data dictionary""" + test_machine =3D MachineConfig=2Efrom_config(machine_catalog, tes= t_data["machine"]) + + def invalid(why: str) -> ValueError: + return ValueError( + f"test {test_name!r}: {why}; expected " + f"{{{XEN_CONS_IDX}: ['str1', 'str2', =2E=2E=2E]}}" + ) + + expect =3D test_data["expect"] + if not isinstance(expect, dict) or expect=2Ekeys() !=3D {XEN_CONS= _IDX}: + raise invalid( + f"expect must map console index {XEN_CONS_IDX} (Xen's own= " + f"console, the only one) and nothing else, got {expect!r}= " + ) + strings =3D expect[XEN_CONS_IDX] + if not isinstance(strings, list): + raise invalid( + f"{ConsoleTest=2Econfig_file} expects a list of string(s)= , " + f"got {type(strings)=2E__name__}" + ) + if not strings: + raise invalid("Xen has no expected string") + if not all(isinstance(s, str) and s for s in strings): + raise invalid(f"Xen expects non-empty strings, got {strings!r= }") + return (test_name, test_data, test_machine) + + @staticmethod + @required_keys("raw", {"machine_catalog", "tests"}) + def _parse_test_cfg(raw: dict, test_name: str) -> tuple[str, dict, Ma= chineConfig]: + """Read the config: return the named test dict and its machine=2E= """ + + tests =3D raw["tests"] + if test_name not in tests: + known =3D ", "=2Ejoin(sorted(tests)) or "(none)" + raise ValueError(f"unknown test {test_name!r}; known tests: {= known}") + + test_data =3D tests[test_name] + return ConsoleTest=2E_parse_test_data( + raw["machine_catalog"], test_data, test_name + ) + + @staticmethod + def list_tests(config_file: str) -> list[str]: + tests =3D ConsoleTest=2E_load_yaml(config_file)=2Eget("tests") + if not tests: + logger=2Ewarning("no 'tests' key found in %s", config_file) + return [] + return list(tests) + + @staticmethod + def _console(vm: RiscvTestMachine): + """Xen's own console (con0)=2E""" + if vm=2Econsole is None: + raise RuntimeError("Xen console not wired up, machine not lau= nched?") + return vm=2Econsole + + def run(self, vm: RiscvTestMachine) -> None: + cons =3D self=2E_console(vm) + for strings in self=2Eexpect=2Evalues(): + for s in strings: + self=2E_expect_string(cons, s) + + def _expect_string(self, cons, expected: str) -> None: + """Wait for `expected` on the console, retrying on timeout=2E""" + for attempt in range(self=2Eattempts): + try: + cons=2Eexpect_exact(expected, timeout=3Dself=2Etimeout) + return + except pexpect=2ETIMEOUT: + if attempt =3D=3D self=2Eattempts - 1: + raise diff --git a/automation/scripts/qtb/riscv/dt=2Epy b/automation/scripts/qtb= /riscv/dt=2Epy new file mode 100644 index 0000000000=2E=2Ef0376979e5 --- /dev/null +++ b/automation/scripts/qtb/riscv/dt=2Epy @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Device tree (DT) handling: compile a =2Edts source into a =2Edtb""" + +from __future__ import annotations + +import logging +import subprocess +from pathlib import Path + +logger =3D logging=2EgetLogger(__name__) + + +def _compile_dts(src: Path, out: Path): + """Run dtc to compile =2Edts `src` into the =2Edtb file at `out`""" + try: + p =3D subprocess=2Erun( + ["dtc", "-I", "dts", "-O", "dtb", "-o", str(out), str(src)], + check=3DTrue, + capture_output=3DTrue, + text=3DTrue, + ) + logger=2Edebug("dtc %s: stdout: %s stderr: %s", src, p=2Estdout, = p=2Estderr) + + except FileNotFoundError as e: + raise RuntimeError("dtc not found in PATH; install device-tree-co= mpiler") from e + except subprocess=2ECalledProcessError as e: + raise RuntimeError( + f"dtc failed on {str(src)!r} (exit {e=2Ereturncode}):\n" + f" stdout: {e=2Estdout}\n stderr: {e=2Estderr}" + ) from e + + +def compile_to_dtb(src: Path, out: Path) -> Path: + """ + Compile a =2Edts source to a =2Edtb under out dir and return the =2Ed= tb path=2E + + Raises FileNotFoundError if `src` or `out` don't exist=2E + """ + if not src=2Eexists(): + raise FileNotFoundError( + f"Device tree source {str(src)!r} not found" + ) + + if not out=2Eexists(): + raise FileNotFoundError(f"Device Tree output dir: {out} doesn't e= xist") + + dtb =3D out / (src=2Estem + "=2Edtb") + _compile_dts(src, dtb) + return dtb + + +def write_dts(text: str, name: str, out_dir: Path) -> Path: + """Write generated =2Edts text to /=2Edts; return its = path=2E""" + src =3D out_dir / f"{name}=2Edts" + src=2Eparent=2Emkdir(parents=3DTrue, exist_ok=3DTrue) + src=2Ewrite_text(text) + return src diff --git a/automation/scripts/qtb/riscv/machine=2Epy b/automation/script= s/qtb/riscv/machine=2Epy new file mode 100644 index 0000000000=2E=2E9ea44ffc4e --- /dev/null +++ b/automation/scripts/qtb/riscv/machine=2Epy @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""QtbMachine for riscv64=2E""" + +from __future__ import annotations + +from collections=2Eabc import Sequence + +from qemu=2Eqtb import QtbMachine + +from =2Econfig import MACHINE_INTERRUPT_CONTROLLER, MACHINE_MEMORY, Machi= neConfig + + +class RiscvTestMachine(QtbMachine): + arch_name =3D "riscv64" + gdb_arch =3D "riscv:rv64" + + def __init__( + self, + mc: MachineConfig, + *, + timeout: int, + log_dir: str | None =3D None, + ) -> None: + self=2Emachine_conf =3D mc + super()=2E__init__( + memory=3DMACHINE_MEMORY, + cpus=3Dmc=2Epcpu, + mirror_console=3DFalse, + timeout=3Dtimeout, + log_dir=3Dlog_dir, + ) + + def _machine_args(self, memory: int, cpus: int) -> Sequence[str]: + machine =3D self=2Emachine_conf + machine_opt =3D f"virt,aclint=3Doff,aia=3D{MACHINE_INTERRUPT_CONT= ROLLER}" + # Xen has no sstc support yet=2E + cpu_opt =3D "rv64,svpbmt=3Don,smstateen=3Don,sstc=3Doff" + return [ + "-dtb", + str(machine=2Edt=2Edtb), + "-M", + machine_opt, + "-cpu", + cpu_opt, + "-smp", + str(cpus), + "-m", + str(memory), + "-bios", + str(machine=2Ebinaries=2Efirmware), + "-kernel", + str(machine=2Ebinaries=2Exen), + ] + + def _resolve_binary(self) -> str: + return str(self=2Emachine_conf=2Ebinaries=2Eqemu) diff --git a/automation/scripts/qtb/riscv/paths=2Epy b/automation/scripts/= qtb/riscv/paths=2Epy new file mode 100644 index 0000000000=2E=2E94a134530f --- /dev/null +++ b/automation/scripts/qtb/riscv/paths=2Epy @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Path helpers: resolve pkg-relative paths=2E""" + +from __future__ import annotations + +import os +import tempfile +from functools import lru_cache +from pathlib import Path + +# Every relative path in this module is resolved against this base=2E +_BASE =3D Path(__file__)=2Eresolve()=2Eparent + +# Build artifacts (qemu, firmware, xen) base, overridable for CI=2E +_BINARIES_BASE =3D Path(os=2Eenviron=2Eget("QTB_BINARIES_DIR") or _BASE /= "binaries") + + +@lru_cache(maxsize=3D1) +def _temp_dir_handle() -> tempfile=2ETemporaryDirectory: + return tempfile=2ETemporaryDirectory(prefix=3D"qtb-") + + +def temp_dir() -> Path: + """Process-wide scratch dir for generated/compiled artifacts (singlet= on)=2E""" + return Path(_temp_dir_handle()=2Ename) + + +def cleanup_temp_dir() -> None: + """Remove the scratch dir, if one was created, and clear the cache=2E= """ + if _temp_dir_handle=2Ecache_info()=2Ecurrsize: + _temp_dir_handle()=2Ecleanup() + _temp_dir_handle=2Ecache_clear() + + +def resolve_path(file_name: str) -> Path: + """Resolve `file_name` against _BASE, absolute paths pass through=2E"= "" + return _resolve_under(file_name, _BASE) + + +def resolve_binary(file_name: str) -> Path: + """Resolve a build artifact against _BINARIES_BASE, absolute paths pa= ss through=2E""" + return _resolve_under(file_name, _BINARIES_BASE) + + +def _resolve_under(file_name: str, base: Path) -> Path: + """Resolve `file_name` against `base`, absolute paths pass through=2E= """ + p =3D Path(file_name) + path =3D p if p=2Eis_absolute() else base / p + if not path=2Eexists(): + raise FileNotFoundError(f"cannot resolve {str(path)!r}: does not = exist") + return path diff --git a/automation/scripts/qtb/riscv/qtb_test=2Epy b/automation/scrip= ts/qtb/riscv/qtb_test=2Epy new file mode 100644 index 0000000000=2E=2E872fbc2fa9 --- /dev/null +++ b/automation/scripts/qtb/riscv/qtb_test=2Epy @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Abstract base for the qtb riscv64 test types=2E + +A test type is a RiscvQtbTest subclass owning a config file that describe= s its +tests, each bound to a machine from the shared catalog=2E +""" + +from __future__ import annotations + +from abc import ABC, abstractmethod +from typing import ClassVar + +from =2Econfig import MachineConfig +from =2Emachine import RiscvTestMachine + +# Default per-test timeout (seconds) +TIMEOUT_DEFAULT: int =3D 120 + + +class RiscvQtbTest(ABC): + """One runnable test bound to the machine it boots=2E + + A subclass sets `type_id`, `description`, and `config_file`, and impl= ements + `from_config` to parse its config file, `list_tests` to enumerate the= tests + it declares, and `run` to drive the test logic=2E + """ + + # Set by each concrete subclass=2E + type_id: ClassVar[str] =3D "" + # One-line summary of what the type does, shown in the CLI help=2E + description: ClassVar[str] =3D "" + # Config file the type reads its tests from, resolved pkg-relative=2E + config_file: ClassVar[str] =3D "" + + # Set by the subclass parser=2E + name: str + data: dict + machine: MachineConfig + timeout: int =3D TIMEOUT_DEFAULT + + @classmethod + @abstractmethod + def from_config(cls, config_file: str, test_name: str) -> RiscvQtbTes= t: + """Build the test named `test_name` from `config_file`=2E""" + + @staticmethod + @abstractmethod + def list_tests(config_file: str) -> list[str]: + """Return the names of every test declared in the config file=2E"= "" + + @abstractmethod + def run(self, vm: RiscvTestMachine) -> None: + """Drive the running machine and assert the expected result=2E""" diff --git a/automation/scripts/qtb/riscv/xen_dt=2Epy b/automation/scripts= /qtb/riscv/xen_dt=2Epy new file mode 100644 index 0000000000=2E=2E8881b01b36 --- /dev/null +++ b/automation/scripts/qtb/riscv/xen_dt=2Epy @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: GPL-2=2E0-only +"""Build the Xen host device tree for a MachineConfig=2E + +The tree is rendered from its Jinja2 template (dts/qemu-host=2Edts=2Ej2),= which +takes the hart count, the Xen MMU type and the Xen command line, then com= piled +to a DTB with dtc=2E +""" + +from __future__ import annotations + +from dataclasses import dataclass +from functools import lru_cache +from pathlib import Path +from typing import TYPE_CHECKING +from jinja2 import Environment, FileSystemLoader + +from =2Epaths import resolve_path, temp_dir +from =2Edt import compile_to_dtb, write_dts + +if TYPE_CHECKING: # config imports this module, so only import it for ty= ping=2E + from =2Econfig import MachineConfig + +# Directory holding the Jinja2 platform device tree templates=2E +_DTS_DIR =3D "dts" + + +@dataclass(frozen=3DTrue) +class DeviceTree: + """Compiled device trees for one machine launch=2E""" + + dts: Path + dtb: Path + + +@lru_cache(maxsize=3D1) +def _env() -> Environment: + return Environment( + loader=3DFileSystemLoader(resolve_path(_DTS_DIR)), + keep_trailing_newline=3DTrue, + ) + + +def _render_xen_dts(machine: MachineConfig) -> str: + """Render the Xen host device tree source text for `machine`=2E""" + tmpl =3D _env()=2Eget_template("qemu-host=2Edts=2Ej2") + return tmpl=2Erender( + ncpus=3Dmachine=2Epcpu, + mmu_type=3Dmachine=2Emmu_type, + xen_bootargs=3Dmachine=2Exen_bootargs, + ) + + +def build_xen_device_tree(machine: MachineConfig) -> DeviceTree: + """Compile `machine` device tree into the shared scratch dir=2E""" + out =3D temp_dir() + dts: Path =3D write_dts(_render_xen_dts(machine), machine=2Ename, out= ) + dtb: Path =3D compile_to_dtb(dts, out) + return DeviceTree(dts=3Ddts, dtb=3Ddtb) -- Baptiste Le Duc | Vates Hypervisor & Kernel Engineer XCP-ng & Xen Orc= hestra - Vates solutions web: https://vates=2Etech ---=Part.204a.3666f13f27356d06.19fec70574c.2d6a0cec16cef1a9=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:10:24 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:10:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387634.1628888 (Exim 4.92) (envelope-from ) id 1wtSZw-0003Qy-7s; Mon, 10 Aug 2026 16:10:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387634.1628888; Mon, 10 Aug 2026 16:10:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZw-0003Qr-5F; Mon, 10 Aug 2026 16:10:20 +0000 Received: by outflank-mailman (input) for mailman id 1387634; Mon, 10 Aug 2026 16:10:18 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtSZu-0003Qe-57 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:10:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSZs-00Exue-DC for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:10:16 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f79b-e002-0a2a0a5209dd-0a2a45018e00-36 for ; Mon, 10 Aug 2026 18:10:16 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f7e7-5984-0a2a45010019-b9ff1c23956d-3 for ; Mon, 10 Aug 2026 18:10:16 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec705643000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:10:12 +0000 Received: from leducb (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 1015683637; Mon, 10 Aug 2026 18:10:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=HPY5KGo/VIwCujbKN7MPUq1fMcqLDozezWN+GUEapgE=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=NmKVVJOZy+xIPZzg6dOvGfZBZk48PkhyGPAQSxFQ/Y6IptkNe1TMzrJ3IOLKZPlCInxryPJAk 5AJ60KQ9Pif7ELtmqjukClyNlq7eFfG62KsDXIZuSTaWpL92FsppVRGF8c/ox7sDX4bTuzpzOAe DWX3nIjmvRg+FA/+TDrUQyYPbAhDmtv/pHfJYCaNit1cA+Xv/zMlLcBtebAsTHfTmUZzT/vbTTW h89tyJmKqb1qVWott6OapujF5lJ11O6rg0OXpdo0i/O8DCWxVOEh5g0kc3MM1LQi7rP2Fh6MciX 2VzEboj+5r1jKzrCCHfkmXuRH6EIWApZEHbTsRvClzfw== X-Zone-Loop: 8daa169fd0630ec516f0a8d154ab406ac16cf6fa2551 x-campaign-type: default x-transaction-id: 467ac744-8f84-4df0-8cbc-3a4c19cac1eb x-swg-uid: 01-ed8ec477-e6d0-4af5-85db-9867530b7a14 X-Mailer: Sweego Message-ID: <1786378213.8631fc262581453bbf619ec5b2062170.19fec705643000e099@vates.tech> x-swg-bid: 1786378213.8631fc262581453bbf619ec5b2062170.19fec705643000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Baptiste Le Duc To: xen-devel@lists.xenproject.org Cc: Baptiste Le Duc , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 1/6 TEST-ARTIFACTS] Add a QTB container to run the Xen riscv64 tests Date: Mon, 10 Aug 2026 18:09:51 +0200 In-Reply-To: <20260810155543.927954-1-baptiste.le-duc@vates.tech> References: <20260810155543.927954-1-baptiste.le-duc@vates.tech> MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.2048.292bd88b0601f785.19fec705373.26d4cb990fb59c26=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786378212212 X-purgate-ID: tlsNG-d62444/1786378216-1F86F757-4B913EE8/10/63158204843 X-purgate-type: spam X-purgate-size: 3421 ---=Part.2048.292bd88b0601f785.19fec705373.26d4cb990fb59c26=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable QTB (QEMU Test Bench) is a Python framework, developed as part of AMD's Xen safety initiative, that drives a live QEMU instance over qtest and QMP=2E = It gives a test full access to the machine while the emulation runs: read and write the consoles, inspect the registers and the memory, inject interrupt= s=2E For now the riscv64 CI tests only use it to read the Xen console in the smoke test, since DomU is not supported yet=2E Once it is, the same framework will read and write the DomU consoles and inject IRQs, so the tests can assert an interrupt reaches the expected guest and vCPU=2E QTB is not upstream in QEMU yet, though it is planned to be, so get the framework from AMD's fork gitlab=2Ecom/xen-project/people/amd/qemu and pip-installs qemu=2Eqtb from it=2E Signed-off-by: Baptiste Le Duc --- containerize | 1 + images/debian/13-qtb-riscv64=2Edockerfile | 45 +++++++++++++++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 images/debian/13-qtb-riscv64=2Edockerfile diff --git a/containerize b/containerize index dad9afa=2E=2E477b670 100755 --- a/containerize +++ b/containerize @@ -31,6 +31,7 @@ case "_${CONTAINER}" in _alpine-3=2E24-arm64-base) CONTAINER=3D"${BASE}/alpine:3=2E24-arm64-b= ase" ;; _alpine-3=2E24-arm64-build) CONTAINER=3D"${BASE}/alpine:3=2E24-arm64-= build" ;; _alpine-3=2E24-x86_64-base) CONTAINER=3D"${BASE}/alpine:3=2E24-x86_64= -base" ;; + _debian-13-qtb-riscv64) CONTAINER=3D"${BASE}/debian:13-qtb-riscv64" ;= ; _alpine-3=2E24-x86_64-build|_) CONTAINER=3D"${BASE}/alpine:3=2E24-x86= _64-build" ;; esac =20 diff --git a/images/debian/13-qtb-riscv64=2Edockerfile b/images/debian/13-= qtb-riscv64=2Edockerfile new file mode 100644 index 0000000=2E=2E86215d3 --- /dev/null +++ b/images/debian/13-qtb-riscv64=2Edockerfile @@ -0,0 +1,45 @@ +# syntax=3Ddocker/dockerfile:1 +FROM --platform=3Dlinux/amd64 debian:trixie-slim +LABEL maintainer=2Ename=3D"The Xen Project" +LABEL maintainer=2Eemail=3D"xen-devel@lists=2Exenproject=2Eorg" + +ENV DEBIAN_FRONTEND=3Dnoninteractive + +ARG QEMU_REPO=3Dhttps://gitlab=2Ecom/xen-project/people/amd/qemu=2Egit +ARG QEMU_COMMIT=3D24cd7e5c0d7e4db8e651f091d0b9da2e7c58dbab + +RUN < Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:10:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387638.1628924 (Exim 4.92) (envelope-from ) id 1wtSa1-0004Jd-8L; Mon, 10 Aug 2026 16:10:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387638.1628924; Mon, 10 Aug 2026 16:10:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSa1-0004JW-5Z; Mon, 10 Aug 2026 16:10:25 +0000 Received: by outflank-mailman (input) for mailman id 1387638; Mon, 10 Aug 2026 16:10:23 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZz-00043O-34 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:10:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSZy-00Exz0-GH for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:10:22 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f79b-e002-0a2a0a5209dd-0a2a45018e00-44 for ; Mon, 10 Aug 2026 18:10:22 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f7e7-5984-0a2a45010019-b9ff1c23956d-5 for ; Mon, 10 Aug 2026 18:10:22 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec705d4f000e099.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:10:14 +0000 Received: from leducb (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 05DC283637; Mon, 10 Aug 2026 18:10:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=9di4me1yvbuqspU7BIqnNXEvi4rg8NzN9nAZG65MC1c=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=S4iKRsLkA2y1u2Ia4FcWyfUJVnRPLSFSxmsw8CDHpDLBHBlUfrKtd8sSSpprTlK4YF0/jD6Ki ccAz9hHgpmjeVe7ImQPNOTq2qH9Pa8F9jWM9aBH9DGLShlqzig9vMB5/BfZQtlxD+9x2o19t+Wi FOmXH3+PPEljfBQJhQC1letP/Ce6V22t/XjueAb15pQnwAUt/iZqdNzoZSezQ6yyf60+tl28vro UnF//RRdAxCEt47u2jgiTPOQAV2pVjuwNW0HzoSvsy2ZGkdgmVlYaKtyaFqQB4AkWURqaDKaBXv ru3sd8M36u/UUxEQlaKIAlwpB5uwiS+iQEx6AA7+ssWQ== X-Zone-Loop: ab6935da73f37db8225160c8308ea7678a0ff97380b8 x-campaign-type: default x-transaction-id: 52953e68-b175-457e-a583-68c71d0e9933 x-swg-uid: 01-a6312d36-96ce-43c8-831e-5c6f590a83d4 X-Mailer: Sweego Message-ID: <1786378214.8631fc262581453bbf619ec5b2062170.19fec705d4f000e099@vates.tech> x-swg-bid: 1786378214.8631fc262581453bbf619ec5b2062170.19fec705d4f000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Baptiste Le Duc To: xen-devel@lists.xenproject.org Cc: Baptiste Le Duc , Doug Goldstein , Stefano Stabellini Subject: [PATCH 5/6] automation/qtb: add QTB framework README Date: Mon, 10 Aug 2026 18:09:55 +0200 In-Reply-To: <20260810155543.927954-1-baptiste.le-duc@vates.tech> References: <20260810155543.927954-1-baptiste.le-duc@vates.tech> MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.204c.8057a2cfa8722de8.19fec705adb.8862fb7305d5dccf=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786378214107 X-purgate-ID: tlsNG-d62444/1786378222-1FE68757-1E8E5302/0/0 X-purgate-type: clean X-purgate-size: 8331 ---=Part.204c.8057a2cfa8722de8.19fec705adb.8862fb7305d5dccf=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Document the qtb riscv64 test framework in a README=2E It covers: - the core concepts (machine, test type, test) and how they map to files - the source files layout - the CLI: `qemu_smoke_riscv64=2Epy `, with "console-tes= t" as the type - the config files: the machine catalog and a type's own `=2Eyaml` - the Jinja2 device-tree templates under dts/ - how to add a test (config-only) and how to add a new test type=2E Assisted-by: Claude:claude-opus-5 Signed-off-by: Baptiste Le Duc --- automation/scripts/qtb/riscv/README=2Emd | 182 +++++++++++++++++++++++++ 1 file changed, 182 insertions(+) create mode 100644 automation/scripts/qtb/riscv/README=2Emd diff --git a/automation/scripts/qtb/riscv/README=2Emd b/automation/scripts= /qtb/riscv/README=2Emd new file mode 100644 index 0000000000=2E=2Effcb027bbc --- /dev/null +++ b/automation/scripts/qtb/riscv/README=2Emd @@ -0,0 +1,182 @@ +qtb riscv64 test framework +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D + +A small framework that boots Xen under QEMU on riscv64 and drives it to a +pass/fail verdict automatically from its console output=2E + +It is built on QEMU's qtb (QEMU Test Bench) Python package, which gives +programmatic control of a QEMU process over QMP and qtest, plus access to= the +consoles=2E + +What it does +------------ + +1=2E Reads a machine description (what to boot: cpus, Xen command line) a= nd a + test description (what to assert)=2E +2=2E Generates the host device tree=2E +3=2E Launches QEMU with Xen and the firmware wired in=2E +4=2E Reads the console and checks what Xen printed=2E + +Core concepts +------------- + +- Machine: test-agnostic description of what to boot=2E Reusable across t= est + types=2E `config=2Eyaml` -> `MachineConfig`=2E +- Test type: a `RiscvQtbTest` subclass implementing the logic of a kind o= f test + (e=2Eg=2E `console-test`)=2E Identified by `type_id`=2E See `console_te= st/`=2E +- Test: one named, runnable instance of a type: a machine plus the type's + parameters=2E Lives in the type's `=2Eyaml`=2E + +A test type owns a config file describing its tests, each test names a ma= chine +from the shared catalog (`config=2Eyaml`) and layers its own parameters o= n top=2E + +Layout +------ + +``` +qemu_smoke_riscv64=2Epy CLI entry point ( run | list) + +qtb/riscv/ This framework + __init__=2Epy Public API + qtb_test=2Epy RiscvQtbTest ABC every test type derives f= rom + config=2Epy Machine catalog parser -> MachineConfig + xen_dt=2Epy Generates the host device tree from its Ji= nja2 template + dt=2Epy Compile =2Edts -> =2Edtb with dtc + paths=2Epy Path resolution (pkg-relative) + machine=2Epy RiscvTestMachine: assembles the QEMU comma= nd line + + config=2Eyaml The machine catalog (shared across test ty= pes) + dts/ Jinja2 device-tree templates (host, common) + + console_test/ The console-test type + __init__=2Epy + console_test=2Epy ConsoleTest implementation + console-test=2Eyaml Its tests + + unit/ pytest unit tests of the framework logic its= elf +``` + +How a type is selected +---------------------- + +The test type is the first positional argument (`qemu_smoke_riscv64=2Epy = console-test run +=2E=2E=2E`)=2E The CLI builds one subcommand per entry of `TEST_TYPES` (`= __init__=2Epy`), +named after the type's `type_id`=2E + +Each type declares the `config_file` it reads its tests from=2E + +Prerequisites +------------- + +- `qemu=2Eqtb`, QEMU's Python package (`python/` in the QEMU tree) +- `jinja2`, `pyyaml`, `pexpect` +- `dtc` (device-tree-compiler) +- the binaries a machine boots: `qemu-system-riscv64`, the firmware + (OpenSBI) and `xen` + +CLI usage +--------- + +Run from `automation/scripts/`, or give the full path from the Xen tree r= oot +(`=2E/automation/scripts/qemu_smoke_riscv64=2Epy =2E=2E=2E`), which is wh= at CI does=2E + +``` +# List every test the type defines in its config: +=2E/qemu_smoke_riscv64=2Epy console-test list + +# Run one test (drives it to PASS/FAIL, exit 0/1): +=2E/qemu_smoke_riscv64=2Epy console-test run dom0less-1smp-0domu-1vcpu-ap= lic-imsic-null \ + --log-dir qtb-logs +``` + +`--log-dir` (run only) collects the QEMU process log, the qtest log, and = each +console as `con=2Elog`: `con0=2Elog` is Xen's own console, the only on= e wired +up today=2E Omit it to write no logs=2E `-v/--verbose` raises the +log level to debug=2E + +Config files +------------ + +`config=2Eyaml` is the machine catalog=2E `binaries:` are build artifacts= resolved +under `binaries/` (overridable with `$QTB_BINARIES_DIR`); absolute paths = pass +through=2E + +Machine entries omit any optional field left at its default=2E +Here are the parameters: + +- `pcpu` (required): host physical cpus=2E +- `mmu_type` (default `sv48`): Xen host MMU type=2E +- `xen_bootargs` (default `""`): Xen command line=2E + +`=2Eyaml` describes the tests of that type=2E + +`console-test` +-------------- + +A test names a machine and maps a console index to the string(s) expected= on +that console: index 0 is Xen's own console (`con0`, logged as `con0=2Elog= `)=2E + +``` +machine_catalog: config=2Eyaml # the catalog to resolve machine names = against +tests: + dom0less-1smp-0domu-1vcpu-aplic-imsic-null: + machine: dom0less-1smp-0domu-1vcpu-aplic-imsic-null # a name in con= fig=2Eyaml + expect: + 0: [All set up] # Xen itself must print "All set up" +``` + +Logic, per console: + +1=2E read the console +2=2E wait for each expected string in turn, in the order listed +3=2E bound each wait by `timeout` seconds, retrying a timed-out wait up t= o + `attempts` times + +The map itself must not be empty, otherwise the test would pass without +asserting anything=2E + +Device trees (dts/) +------------------- + +Jinja2 template, generated per machine and compiled with dtc: + +- `qemu-host=2Edts=2Ej2` - the Xen host tree: the hart count, the host MM= U type and + the Xen command line=2E + +Adding a test +------------- + +To add a test to an existing type (e=2Eg=2E `console-test`): + +1=2E Pick a machine from `config=2Eyaml`, or add a new one under `machine= s:` (set + `pcpu`, and any optional field that differs from its default =E2=80=94= see the + field list above)=2E +2=2E Add a test entry under `tests:` in the type's `=2Eyaml`, namin= g that + machine and supplying the type's own parameters (for `console-test`, o= ne + `expect` list per console)=2E +3=2E Run it: `=2E/qemu_smoke_riscv64=2Epy console-test run `=2E + +No code change is needed, a test is pure config=2E + +Adding a new test type +---------------------- + +1=2E Create `mytype/` with `mytype=2Epy` defining a `RiscvQtbTest` subcla= ss: set + `type_id`, `description`, and `config_file`, and implement `from_confi= g`, + `list_tests`, and `run(vm)`=2E +2=2E Add `mytype/__init__=2Epy` that does `from =2Emytype import MyType`= =2E +3=2E Add `MyType` to `TEST_TYPES` in `__init__=2Epy` so the CLI exposes i= t=2E + +Unit tests +---------- + +The `unit/` directory holds pytest tests of the framework's own logic (co= nfig +parsing, device-tree rendering, QEMU arg assembly)=2E They do not boot QE= MU and +are independent of the CI smoke tests, but they import the framework, so = they +need the prerequisites above plus `pytest`=2E + +Run from the Xen tree root: + +``` +python3 -m pytest automation/scripts/qtb/riscv/unit/ +``` -- Baptiste Le Duc | Vates Hypervisor & Kernel Engineer XCP-ng & Xen Orc= hestra - Vates solutions web: https://vates=2Etech ---=Part.204c.8057a2cfa8722de8.19fec705adb.8862fb7305d5dccf=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:10:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:10:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387639.1628928 (Exim 4.92) (envelope-from ) id 1wtSa1-0004Mr-JI; Mon, 10 Aug 2026 16:10:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387639.1628928; Mon, 10 Aug 2026 16:10:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSa1-0004LP-DU; Mon, 10 Aug 2026 16:10:25 +0000 Received: by outflank-mailman (input) for mailman id 1387639; Mon, 10 Aug 2026 16:10:23 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSZz-00046c-Dv for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:10:23 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSZy-00Exz0-Qy for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:10:22 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79f79b-e002-0a2a0a5209dd-0a2a45018e00-46 for ; Mon, 10 Aug 2026 18:10:22 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79f7e7-5984-0a2a45010019-b9ff1c23956d-6 for ; Mon, 10 Aug 2026 18:10:22 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec705e62000e099.003 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:10:15 +0000 Received: from leducb (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 718B5836CA; Mon, 10 Aug 2026 18:10:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=b8uUu5RVBX4cAl4lJFvLAs2NLoZ3l9PfrUwp54rMNoY=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=EN0WKQPt5ZeZQht5quSPoVwqugNHnkC+k/xdLPn7T/H09/ivM2dM8Q6FSiRUOWNrIKfh+5bNY yL+h7c+Z7K0xtzZkkmGklgNLxZ7Mby7p8xD9ry6hwCaqcnmSh8Zl601tKO9YZFtW/OWPvVBD0Nw dgmIII4IfGXahumpMkVjpyZq/67lgLblpY8+rrRM37Qoqp1Cw+1QBLmFmF0uZItDijzMt8WW5Nt 2xccH4LLYbzugr/IQeCc9ZujydqFmqhCokxSnK4UVQyYpKqDaKYY9av0A7arVrR5IH5YD0hT1qy EAFKjw7jb5Bq70EwVEUn9+S3wxG4rOxU4DFACcwulJ/Q== X-Zone-Loop: 5e910abe6b09df3b0635cd623e41b48cfcda30c2ec62 x-campaign-type: default x-transaction-id: bd1c45bf-91a7-4f09-a9d4-206f924aa378 x-swg-uid: 01-a5039f13-fdab-4e2c-b90b-809608327dcb X-Mailer: Sweego Message-ID: <1786378215.8631fc262581453bbf619ec5b2062170.19fec705e62000e099@vates.tech> x-swg-bid: 1786378215.8631fc262581453bbf619ec5b2062170.19fec705e62000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] From: Baptiste Le Duc To: xen-devel@lists.xenproject.org Cc: Baptiste Le Duc , Doug Goldstein , Stefano Stabellini Subject: [PATCH 6/6] CI: run the riscv64 smoke test via QTB framework console-test Date: Mon, 10 Aug 2026 18:09:56 +0200 In-Reply-To: <20260810155543.927954-1-baptiste.le-duc@vates.tech> References: <20260810155543.927954-1-baptiste.le-duc@vates.tech> MIME-Version: 1.0 X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.204d.96642db73297cb4b.19fec705c90.6ffbbdec5d88f335=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786378214544 X-purgate-ID: tlsNG-d62444/1786378222-BD67C757-D7FE074B/0/0 X-purgate-type: clean X-purgate-size: 5029 ---=Part.204d.96642db73297cb4b.19fec705c90.6ffbbdec5d88f335=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable qemu-smoke-riscv64-gcc drove QEMU through automation/scripts/qemu-smoke-riscv64=2Esh, an expect wrapper whose machin= e description (cpus, memory, device tree, console wiring) lived in the scrip= t itself=2E The QTB framework now owns all of that: machines come from the shared catalog, expectations from the test type's own YAML=2E Turn =2Eqemu-riscv64 into a template running qemu_smoke_riscv64=2Epy run in the qtb-riscv64 container, machine and test picked per job through QTB_TEST_TYPE/QTB_TEST=2E The container comes from the test-artifa= cts registry, hence the new ARTIFACTS_REGISTRY next to the existing ARTIFACTS_REPO/ARTIFACTS_BRANCH=2E QTB_BINARIES_DIR points at the artifact= s of the job in the new =2Eriscv64-test-needs anchor (QEMU and its firmware)= , and QTB_LOG_DIR collects the per-console logs, kept on failure and on success=2E Point qemu-smoke-riscv64-gcc at that template, running the console-test type on dom0less-1smp-0domu-1vcpu-aplic-imsic-null: a Xen-only machine, so the smoke check is Xen's own "All set up" on console 0, the same string th= e expect script waited for=2E Drop automation/scripts/qemu-smoke-riscv64=2Esh as it has no caller left i= n the CI after this patch and drop smoke=2Eserial from the =2Eqemu-riscv64 artifacts since no riscv64 job uses it anymore, the logs are now kept unde= r QTB_LOG_DIR=2E Assisted-by: Claude:claude-opus-5 Signed-off-by: Baptiste Le Duc --- =2Egitlab-ci=2Eyml | 3 +++ automation/gitlab-ci/test=2Eyaml | 26 ++++++++++++++++++------ automation/scripts/qemu-smoke-riscv64=2Esh | 19 ----------------- 3 files changed, 23 insertions(+), 25 deletions(-) delete mode 100755 automation/scripts/qemu-smoke-riscv64=2Esh diff --git a/=2Egitlab-ci=2Eyml b/=2Egitlab-ci=2Eyml index f42a9abeaa=2E=2E15f93b8634 100644 --- a/=2Egitlab-ci=2Eyml +++ b/=2Egitlab-ci=2Eyml @@ -11,6 +11,9 @@ variables: ARTIFACTS_BRANCH: description: "Branch in test-artifacts to use" value: master + ARTIFACTS_REGISTRY: + description: "Registry holding the test-artifacts containers" + value: registry=2Egitlab=2Ecom/xen-project/hardware/test-artifacts LINUX_JOB_X86_64: description: "Job name in test-artifacts to use for Linux x86_64" value: linux-6=2E6=2E56-x86_64 diff --git a/automation/gitlab-ci/test=2Eyaml b/automation/gitlab-ci/test= =2Eyaml index 61adc1baff=2E=2E4775d2cc4e 100644 --- a/automation/gitlab-ci/test=2Eyaml +++ b/automation/gitlab-ci/test=2Eyaml @@ -5,6 +5,11 @@ - if: $CI_JOB_NAME =3D~ $SELECTED_JOBS_ONLY when: on_success =20 +=2Eriscv64-test-needs: &riscv64-test-needs + - project: $ARTIFACTS_REPO + job: qemu-9=2E0=2E0-riscv64 + ref: $ARTIFACTS_BRANCH + =2Earm64-test-needs: &arm64-test-needs - project: $ARTIFACTS_REPO job: $LINUX_JOB_ARM64 @@ -72,14 +77,21 @@ TEST_TIMEOUT_OVERRIDE: 120 =20 =2Eqemu-riscv64: + image: ${ARTIFACTS_REGISTRY}/${CONTAINER} extends: =2Etest-jobs-common variables: - CONTAINER: debian:13-riscv64 - LOGFILE: qemu-smoke-riscv64=2Elog + CONTAINER: debian:13-qtb-riscv64 + QTB_LOG_DIR: qtb-logs + QTB_BINARIES_DIR: ${CI_PROJECT_DIR}/binaries + script: + - =2E/automation/scripts/qemu_smoke_riscv64=2Epy + ${QTB_TEST_TYPE} + run + ${QTB_TEST} + --log-dir ${QTB_LOG_DIR} artifacts: paths: - - smoke=2Eserial - - '*=2Elog' + - ${QTB_LOG_DIR} when: always tags: - x86_64 @@ -779,9 +791,11 @@ qemu-xtf-argo-x86_64-gcc-debug: =20 qemu-smoke-riscv64-gcc: extends: =2Eqemu-riscv64 - script: - - =2E/automation/scripts/qemu-smoke-riscv64=2Esh 2>&1 | tee ${LOGFILE= } + variables: + QTB_TEST_TYPE: console-test + QTB_TEST: dom0less-1smp-0domu-1vcpu-aplic-imsic-null needs: + - *riscv64-test-needs - debian-13-riscv64-gcc-debug =20 qemu-smoke-ppc64le-powernv9-gcc: diff --git a/automation/scripts/qemu-smoke-riscv64=2Esh b/automation/scrip= ts/qemu-smoke-riscv64=2Esh deleted file mode 100755 index c0b1082a08=2E=2E0000000000 --- a/automation/scripts/qemu-smoke-riscv64=2Esh +++ /dev/null @@ -1,19 +0,0 @@ -#!/bin/bash - -set -ex -o pipefail - -# Run the test -rm -f smoke=2Eserial - -export TEST_CMD=3D"qemu-system-riscv64 \ - -M virt,aia=3Daplic-imsic \ - -cpu rv64,svpbmt=3Don \ - -smp 1 \ - -nographic \ - -m 2g \ - -kernel binaries/xen" - -export TEST_LOG=3D"smoke=2Eserial" -export PASSED=3D"All set up" - -=2E/automation/scripts/console=2Eexp |& sed 's/\r\+$//' -- Baptiste Le Duc | Vates Hypervisor & Kernel Engineer XCP-ng & Xen Orc= hestra - Vates solutions web: https://vates=2Etech ---=Part.204d.96642db73297cb4b.19fec705c90.6ffbbdec5d88f335=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:20:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:20:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387682.1628941 (Exim 4.92) (envelope-from ) id 1wtSjX-0007s6-LG; Mon, 10 Aug 2026 16:20:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387682.1628941; Mon, 10 Aug 2026 16:20:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtSjX-0007rz-IP; Mon, 10 Aug 2026 16:20:15 +0000 Received: by outflank-mailman (input) for mailman id 1387682; Mon, 10 Aug 2026 16:20:14 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtSjV-0007rt-Vu for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:20:14 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtSjU-009EC3-Np for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:20:12 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a79fa27-bab6-0a2a0a5309dd-0a2a4509e39c-32 for ; Mon, 10 Aug 2026 18:20:12 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a79fa3c-be1a-0a2a45090019-b9ff1c2389c7-3 for ; Mon, 10 Aug 2026 18:20:12 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fec796ecb000e099.004 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 10 Aug 2026 16:20:09 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 4BA8681C91; Mon, 10 Aug 2026 18:20:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=gbPx00y3KZQyqLCbi95Q/5Iy/Nq3Js6/1jBe0l/XbHA=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=iZwvScOPNDwRHidRp1D1sBZ6sAaWavesjr+nrAcchvwJoRfxfC7d42mfuAk4aVq7jQgEeQs93 S237qv22SzkAxewfAiB5gx7j9EIoQJwYmVWYFRptRSKpJ7mhm/lN1ArrE+sgMMd3i3Ju0q3tdJn r+zmgPpPisrmMnJ9oXdiOnBVnTaTh8dr33EKUoMIBAumuzQqzRkkuvR41h7SC9XUMxM7NZAcYhn vDdzk+lO8SqNJa5egSRQwrI79efwyHAd9xmWsMVao3gxpEZH0nwiF9k2E1ZW+/XbsfIXitOpdZb WMge6hw5gDDEzVyVUqS/VK/tttg/uv7USUr8cP66MQjQ== X-Zone-Loop: 821d28af57f8c5ba89765fecf76785c21a5a07a45059 x-campaign-type: default x-transaction-id: f2e13ac5-9ad7-45dd-96ea-845289fefced x-swg-uid: 01-717e97ef-b827-4be6-9117-ec1f3973f62b X-Mailer: Sweego Message-ID: <1786378809.8631fc262581453bbf619ec5b2062170.19fec796ecb000e099@vates.tech> x-swg-bid: 1786378809.8631fc262581453bbf619ec5b2062170.19fec796ecb000e099 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Subject: Re: [PATCH 1/6 TEST-ARTIFACTS] Add a QTB container to run the Xen riscv64 tests From: Baptiste Le Duc To: Baptiste Le Duc Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: <1786378213.8631fc262581453bbf619ec5b2062170.19fec705643000e099@vates.tech> References: <20260810155543.927954-1-baptiste.le-duc@vates.tech> <1786378213.8631fc262581453bbf619ec5b2062170.19fec705643000e099@vates.tech> Date: Mon, 10 Aug 2026 18:20:02 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786378808; l=3567; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=wul/TDdovu7bl+ESViJYK6YcweHy78HHk6jvpWvPtOM=; b=fF48VRfAUCey5J/4cr/xdAMb6PnjkgzuejEjKbtCbEI6j7279KYJiFw3L0VAjUxQSDaLaAYSP hkgcjspy5j5DLWtbwU8HHYA5h6/+tBBGgvG9eUSiWEqe5ft7ptAgfvo X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.204e.d8cf671d69c5fb59.19fec796c82.bff95559d196618f=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786378808450 X-purgate-ID: tlsNG-bad1c0/1786378812-FD668034-52B069E3/10/63158204843 X-purgate-type: spam X-purgate-size: 4084 ---=Part.204e.d8cf671d69c5fb59.19fec796c82.bff95559d196618f=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi everyone, Apologies for the broken threading, my SMTP relay rewrote the Message-IDs=2E Cover letter is here: https://lore=2Ekernel=2Eorg/xen-devel/1786377707=2E8631fc262581453bbf619ec= 5b2062170=2E19fec689f7e000e099@vates=2Etech/T/#u Kind regards, On 2026-08-10 18:09 +0200, Baptiste Le Duc wrote: > QTB (QEMU Test Bench) is a Python framework, developed as part of AMD's = Xen > safety initiative, that drives a live QEMU instance over qtest and QMP= =2E It > gives a test full access to the machine while the emulation runs: read a= nd > write the consoles, inspect the registers and the memory, inject interru= pts=2E >=20 > For now the riscv64 CI tests only use it to read the Xen console in the > smoke test, since DomU is not supported yet=2E Once it is, the same > framework will read and write the DomU consoles and inject IRQs, so the > tests can assert an interrupt reaches the expected guest and vCPU=2E >=20 > QTB is not upstream in QEMU yet, though it is planned to be, so get the > framework from AMD's fork gitlab=2Ecom/xen-project/people/amd/qemu and > pip-installs qemu=2Eqtb from it=2E >=20 > Signed-off-by: Baptiste Le Duc > --- > containerize | 1 + > images/debian/13-qtb-riscv64=2Edockerfile | 45 ++++++++++++++++++++++++= + > 2 files changed, 46 insertions(+) > create mode 100644 images/debian/13-qtb-riscv64=2Edockerfile >=20 > diff --git a/containerize b/containerize > index dad9afa=2E=2E477b670 100755 > --- a/containerize > +++ b/containerize > @@ -31,6 +31,7 @@ case "_${CONTAINER}" in > _alpine-3=2E24-arm64-base) CONTAINER=3D"${BASE}/alpine:3=2E24-arm64= -base" ;; > _alpine-3=2E24-arm64-build) CONTAINER=3D"${BASE}/alpine:3=2E24-arm6= 4-build" ;; > _alpine-3=2E24-x86_64-base) CONTAINER=3D"${BASE}/alpine:3=2E24-x86_= 64-base" ;; > + _debian-13-qtb-riscv64) CONTAINER=3D"${BASE}/debian:13-qtb-riscv64"= ;; > _alpine-3=2E24-x86_64-build|_) CONTAINER=3D"${BASE}/alpine:3=2E24-x= 86_64-build" ;; > esac > =20 > diff --git a/images/debian/13-qtb-riscv64=2Edockerfile b/images/debian/1= 3-qtb-riscv64=2Edockerfile > new file mode 100644 > index 0000000=2E=2E86215d3 > --- /dev/null > +++ b/images/debian/13-qtb-riscv64=2Edockerfile > @@ -0,0 +1,45 @@ > +# syntax=3Ddocker/dockerfile:1 > +FROM --platform=3Dlinux/amd64 debian:trixie-slim > +LABEL maintainer=2Ename=3D"The Xen Project" > +LABEL maintainer=2Eemail=3D"xen-devel@lists=2Exenproject=2Eorg" > + > +ENV DEBIAN_FRONTEND=3Dnoninteractive > + > +ARG QEMU_REPO=3Dhttps://gitlab=2Ecom/xen-project/people/amd/qemu=2Egit > +ARG QEMU_COMMIT=3D24cd7e5c0d7e4db8e651f091d0b9da2e7c58dbab > + > +RUN < +#!/bin/bash > + set -eu > + > + useradd --create-home user > + > + apt-get update > + > + DEPS=3D(# Base environment > + ca-certificates > + device-tree-compiler > + git > + python3-jinja2 > + python3-minimal > + python3-pip > + python3-yaml > + > + # Qemu for test phase > + qemu-system-riscv64 > + ) > + > + apt-get -y --no-install-recommends install "${DEPS[@]}" > + > + # QTB framework > + git init /tmp/qemu > + git -C /tmp/qemu fetch --depth 1 "$QEMU_REPO" "$QEMU_COMMIT" > + git -C /tmp/qemu checkout FETCH_HEAD > + pip install --break-system-packages /tmp/qemu/python[qtb] > + > + rm -rf /tmp/qemu > + rm -rf /var/lib/apt/lists/* > +EOF > + > +USER user > +WORKDIR /build >=20 >=20 > --=20 > Baptiste Le Duc | Vates Hypervisor & Kernel Engineer >=20 > XCP-ng & Xen Orchestra - Vates solutions >=20 > web: https://vates=2Etech -- Baptiste Le Duc | Vates Hypervisor & Kernel Engineer XCP-ng & Xen Orc= hestra - Vates solutions web: https://vates=2Etech ---=Part.204e.d8cf671d69c5fb59.19fec796c82.bff95559d196618f=--- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 16:42:53 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 16:42:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387696.1628951 (Exim 4.92) (envelope-from ) id 1wtT57-0002x9-B1; Mon, 10 Aug 2026 16:42:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387696.1628951; Mon, 10 Aug 2026 16:42:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtT57-0002x2-86; Mon, 10 Aug 2026 16:42:33 +0000 Received: by outflank-mailman (input) for mailman id 1387696; Mon, 10 Aug 2026 16:42:31 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3c_95agYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 1wtT55-0002ww-Mp for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 16:42:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtT53-00434s-Pt for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:42:29 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3c_95agYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 6a79ff6c-2eae-0a2a0a5409dd-0a2a4506e2d8-12 for ; Mon, 10 Aug 2026 18:42:29 +0200 Received: from [209.85.210.197] (helo=mail-pf1-f197.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3c_95agYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 6a79ff74-195a-0a2a45060019-d155d2c5ec63-3 for ; Mon, 10 Aug 2026 18:42:29 +0200 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-848544a8496so2343430b3a.0 for ; Mon, 10 Aug 2026 09:42:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786380148; x=1786984948; darn=lists.xenproject.org; h=content-type:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1aMkrKlnySSkZTh98FOauiGYQlFOQqftaK5JuEjFP4g=; b=atN7bTXZeZzv7IrVzyQngYnKgJjlmMoz52g9gAW169OJK86ZDfItMpwKhrTBKVKIQy bwhcRRVKdLxPiYFHvuHHummmrJoNTCVyp4BsS2OZTOB1xjBylnsxOBF+kYPdct4kTiK0 pndTJ1Pnh6qcof3c8FwwFT6wzf2bUas/2KIptcHLhsqKi7luKhMCZi8y7EvkkiDEAnCa bqAdEks9R9dOWyFfoIFkuRnevy7FHYDp8SrWDX0Yg9PmHbldsZZcRGFbNZIg/5aMr8iq WwlNmKfs6uaSvfqHsiqHkmKfm4UwKa4KmfjRaGOB2eTbLUBmKI4r5gflp3szNIWklF1q K3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786380148; x=1786984948; h=content-type:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1aMkrKlnySSkZTh98FOauiGYQlFOQqftaK5JuEjFP4g=; b=hVgMfAJcA6qA5XHLvJEYhFYrLH9Cy5RgPK+wSJx3BUSpxM4QlQGOSsZY4vB8Pso4Th p9fue90myBTIgEv1M3Tx7atUHp5NOUpkZCPouzsOmHwWkrMghOYCmS6XQxoRzEw9B+sn kBkwQL7GcVu2GXr9U+bROAKXUmaIrSLd0HTQZFocMDDEPLvQcFJp7iqecVAhS7/sHy3j pHqD+fyuyqWenPwvHNyz+PjhpWPBAX71+k0bMK3ohh83O9p9F8L7UsfHGBUrqFoqMO+/ jljQfnidsMG7M3xM48ctYn1xuuPc6tDz5gHYY5aRiIecmFwW4ZJwv7jbngi9m55AiwSy DMEg== X-Forwarded-Encrypted: i=1; AHgh+RomswLUx+Ltg65YDGmmilA8UBsDS2J9Z9gByC6N90O6QaJmrYN9DmWTG6j5oiphr3OOPyBc4G9cObw=@lists.xenproject.org X-Gm-Message-State: AOJu0Yxw5UyxdrtA/zle/J0sWMihzIJ9wg2ggrA0x0E6+g6wlgo7/OUZ 0vpMKoSQbafTEY+J/jvDx78zUJvQUKpmQdjxFpqxVQmNg7aotmnAlCO80DTPGsSnFtTRN6ZdGQd ICtVfkQ== X-Received: from pfbkr10.prod.google.com ([2002:a05:6a00:4b4a:b0:848:569f:3464]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3cc5:b0:847:8dec:1427 with SMTP id d2e1a72fcca58-84f4fd9f647mr32987651b3a.8.1786380147208; Mon, 10 Aug 2026 09:42:27 -0700 (PDT) Date: Mon, 10 Aug 2026 09:42:21 -0700 In-Reply-To: <20260728144954.355376-1-dwmw2@infradead.org> Mime-Version: 1.0 References: <20260728144954.355376-1-dwmw2@infradead.org> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <178637989949.703398.16006467247639187150.b4-ty@google.com> Subject: Re: [PATCH v7 00/36] Cleaning up the KVM clock mess From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org, David Woodhouse Content-Type: text/plain; charset="utf-8" X-purgate-ID: tlsNG-16d1c6/1786380149-FD60A77B-0AA3C434/0/0 X-purgate-type: clean X-purgate-size: 1327 On Tue, 28 Jul 2026 15:39:40 +0100, David Woodhouse wrote: > This is v7 of the series to clean up the KVM clock, rebased onto > kvm-x86/next (patch 1 of v6 is already merged there as commit > 710b3a30f407). > > The KVM clock has historically suffered from three problems: > > 1. Imprecision: get_kvmclock_ns() computed the clock from the *host* > TSC without applying guest TSC scaling, causing systemic drift from > the values the guest computes from its own TSC. > > [...] Applied two more Xen patches to kvm-x86 clocks. Given that KVM was updating the wrong sub-leaf (which amused me greatly), I didn't see any point in waiting for the new uAPI updates to yank out the CPUID updates. Holler if you feel strongly that that change in particular should be bundled with the kernel that adds the TSC scaling uAPI, omitting these changes from 7.3 and waiting for 7.4 is trivial. I'm just trying to reduce the number of in-flight patches we need to keep track of. Thanks! [20/36] KVM: x86/xen: Prevent runstate times from becoming negative https://github.com/kvm-x86/linux/commit/36a85200643e ... [22/36] KVM: x86: Remove runtime Xen TSC frequency CPUID update https://github.com/kvm-x86/linux/commit/7d3bd21e457b -- https://github.com/kvm-x86/linux/tree/next From xen-devel-bounces@lists.xenproject.org Mon Aug 10 17:01:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 17:01:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387708.1628961 (Exim 4.92) (envelope-from ) id 1wtTNI-00067K-R2; Mon, 10 Aug 2026 17:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387708.1628961; Mon, 10 Aug 2026 17:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtTNI-00067D-Mq; Mon, 10 Aug 2026 17:01:20 +0000 Received: by outflank-mailman (input) for mailman id 1387708; Mon, 10 Aug 2026 17:01:19 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtTNE-000677-D8 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 17:01:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtTND-001GeV-6W; Mon, 10 Aug 2026 19:01:15 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a03bb-8faa-0a2a0a5109dd-0a2a450ca636-46 for ; Mon, 10 Aug 2026 19:01:13 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a03d8-f479-0a2a450c0019-5a9b3222ba68-3 for ; Mon, 10 Aug 2026 19:01:12 +0200 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtTIe-0000000FsrG-3EQh; Mon, 10 Aug 2026 16:56:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F7K1udkVZU92GKtfiKiXkKfBInmHr+hymLHX/Ey5Ckw=; b=PE46M4nRVtFgPxlNu0c9dSQEMW VvDkhDdmKfzplsEXmqnxF6LZId3EsY1ahIcEPrkowD/ABrNFFCqDT0rLlLDjWy/+YWLi2CZev4zF8 RpmlJSP0bhrOnmLZRmoxzEaW3Macd5S1LtVtO0iegHDApVsLOSvGNTcxE/NjzQHafA1zdaqLw4YzH JDLhZPmZ0mGX++kZUkDn4tLSQ7kRdWBjSGmm5zFb9uNWJEUoybiDyC0fpHHKxqrh0IZOjCxBQZymV 9yrKrCpJx1XvAK6YVwRc3x22nfNvRZc652VHJkHK9NbVBabjd8JGROt7qZAQFQvCyyW3yc2uptICr LHpalZdQ==; Message-ID: <8e7b756145d047e7a7da7804263eaf4a83f67e1b.camel@infradead.org> Subject: Re: [PATCH v7 00/36] Cleaning up the KVM clock mess From: David Woodhouse To: Sean Christopherson , Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Mon, 10 Aug 2026 17:56:23 +0100 In-Reply-To: <178637989949.703398.16006467247639187150.b4-ty@google.com> References: <20260728144954.355376-1-dwmw2@infradead.org> <178637989949.703398.16006467247639187150.b4-ty@google.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-Ym+XPLy3h0xTCiX5d9Zd" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-d25034/1786381273-76CDBA5B-91548E1C/0/0 X-purgate-type: clean X-purgate-size: 9630 --=-Ym+XPLy3h0xTCiX5d9Zd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2026-08-10 at 09:42 -0700, Sean Christopherson wrote: >=20 > Applied two more Xen patches to kvm-x86 clocks. >=20 > Given that KVM was updating the wrong sub-leaf (which amused me greatly),= I > didn't see any point in waiting for the new uAPI updates to yank out the = CPUID > updates.=C2=A0 Holler if you feel strongly that that change in particular= should be > bundled with the kernel that adds the TSC scaling uAPI, omitting these ch= anges > from 7.3 and waiting for 7.4 is trivial.=C2=A0 I'm just trying to reduce = the number > of in-flight patches we need to keep track of. Sounds good. Let me know when the dust has settled, and I can look at rebasing the remaining parts on top of part 1. In the meantime I shall continue to polish the GPC/RCU stuff, which looks like it's working quite nicely now. --=-Ym+XPLy3h0xTCiX5d9Zd Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MTAxNjU2MjNaMC8GCSqGSIb3DQEJBDEiBCAybwx1QWRoKMDiRyZ64eaKw51fEKZI /kvexMNutyvnZTCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAx/53F7uaU7YMdDo0sjw5EeKzwlz0DNt6fbdQkKbfXgNXjdKJHTOU 4kSEhoBJpzr87r9nyStsTxM/F0mvtQjqGjFUggbsZ9YEwtdDpEriE18ixibCW1MXxh9lS9AHrPdA i+3BhK0+WfK8P8VyXP8jq0MqpTx+1x2ZZ2zoTZjktUrUqYaVlHhImboCKZex8qFXBUg8aa5qgnbc wFpnz4stsBTRQ+WgkHigmlKGlWe76MpmgEfvBuvzM2lm497AAq88I0Nk0F1NgviJeE4leuCDQLhB W3SRCLxePsHKwgp2SR1nkpPCHR1HHccoI7R8DwlL7d+Ptqty+dyACtxdwLXpoIueV5oWdzLa9jOC KHODCLSCujLgYCh94bfvIOmBCo+51Haah/3TZKi1WZrkeLzt7UFHAMYl1cqernHNkDuqKeUIxSLl Oxu4mFqIJUMQ+0UyOL+/nTfr4fCPlYE0+KA7AdBXkNVF0H+EN0QOPV8ZY8PxYMgqqudR4Z2J6mba TbbM8YhLFq8nE4Tm69jhSN8y7WNXdLH18GZSmcXS4rm75Vvk34gMlGuB2Fa3jNcE2e3yqJhzBgbC etj3LeM9Ji7kEoNrnhJsFVL03Cl7E6M+WNGsniZa+j28riIMcgidlPJuz5ONf3LOB9xaTMmEyzTR vhB20ETalyiujq48e8jsfJUAAAAAAAA= --=-Ym+XPLy3h0xTCiX5d9Zd-- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 17:48:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 17:48:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387727.1628970 (Exim 4.92) (envelope-from ) id 1wtU6X-0004IL-80; Mon, 10 Aug 2026 17:48:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387727.1628970; Mon, 10 Aug 2026 17:48:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtU6X-0004IE-3r; Mon, 10 Aug 2026 17:48:05 +0000 Received: by outflank-mailman (input) for mailman id 1387727; Mon, 10 Aug 2026 17:48:04 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <30A56agYKCTEfRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 1wtU6V-0004H0-Uq for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 17:48:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtU6V-00Bt7l-2E for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 19:48:03 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <30A56agYKCTEfRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 6a7a0eb2-e002-0a2a0a5209dd-0a2a4504d570-42 for ; Mon, 10 Aug 2026 19:48:02 +0200 Received: from [209.85.214.199] (helo=mail-pl1-f199.google.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <30A56agYKCTEfRNaWPTbbTYR.PbZkRa-QRiRYYVfgf.kRacebWRPg.beT@flex--seanjc.bounces.google.com>) id 6a7a0ed1-b57f-0a2a45040019-d155d6c7ec70-3 for ; Mon, 10 Aug 2026 19:48:02 +0200 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cacf17c7e0so31032415ad.0 for ; Mon, 10 Aug 2026 10:48:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786384081; x=1786988881; darn=lists.xenproject.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SniDEAr8Q0oZEkC+DBXZ7AH2ONN7iandHQRV9KjayUM=; b=D46kqTkDEKuBRi2F4mjHWOZBsvIc0JTutWxM5i5TjMq5VBJ/RYbmr4FA0A5EeNUYBA SvQpaEYUlWFtksoCDmNEfsIV+n7uM/DOrMLxkNOabvesDvEycbcRuCTArvhz+iO2Tu4i Y4m4buNbSZTpCOW0g1sKruMMaOxXkNOATjpf69Ykdv8ELwQ96hhln9jSo27DU57YZ1os 7avBWkPH/iz/s9QamMSmJjNw2NZUjQLX7NcMPGFvAcE6dFzJSLX30ZP+ARhcNI6w5i+N qgqonlFaEeRNl7Jr4skixvrhclln2q+u+nKvBPCBQC/jpEA9zAEyXAA7SpE6w7LZXprb iJUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786384081; x=1786988881; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SniDEAr8Q0oZEkC+DBXZ7AH2ONN7iandHQRV9KjayUM=; b=p9TgHWasbejSZ6cRD3A+nNDESCHwukSGinpM0FCSahAT34N4N8CQLzv+3SZimR7AGK /jvkZSLozGumlW8cdMVLWs0m0wcq17OFtqLFu5obN3cC3zwU0Uj/eQKBzbXtf+eFVhzI OmAgHB0wmt1a5IBim1Y5cSmraIt9RtkDCqVXM4tDyBeEy5x49ZXfjrY5YCLJz8eWXOv7 B1XIl3n4/5pgaTmpu8jI89fP4Rs5m7e0iIEjYfs9MBPHGN2NjzauluKMFpimPH9G7SY5 ZjTyaOsKzEmE8ZuTNb0420TN3YlDkENi/xI4MRHMmrBi6Tl+kGWgtRPkcuZ+ExUS9Zhs pevQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8V+NYJDaTB0G6Pm9GOtiuCz8oGT5+Ul7uUyjv7X23YcEHZx3r+17Cl43Wdak2762ektlSNXH1064=@lists.xenproject.org X-Gm-Message-State: AOJu0YxMLbDsiMF6ntgmUgbDPUOBsayZFmdIPRN8LokcDfe0xzy7dMsB 2xORxWe08tKurIi/mug6ZEU/UDjP3tTH+OmPbg7eCM/W+WbA6tqny3pvfO26W/YsHTlPT+KpNKW WC48R8Q== X-Received: from plof2.prod.google.com ([2002:a17:902:8602:b0:2ca:f171:2082]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ea0d:b0:2c6:a012:6241 with SMTP id d9443c01a7336-2d106a7e616mr344060945ad.6.1786384080573; Mon, 10 Aug 2026 10:48:00 -0700 (PDT) Date: Mon, 10 Aug 2026 10:47:59 -0700 In-Reply-To: <20260728144954.355376-18-dwmw2@infradead.org> Mime-Version: 1.0 References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-18-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v7 17/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-purgate-ID: tlsNG-ebf023/1786384082-C1CD7B50-0587739D/0/0 X-purgate-type: clean X-purgate-size: 2413 On Tue, Jul 28, 2026, David Woodhouse wrote: > From: David Woodhouse > > Previously, a guest writing different TSC values on different vCPUs could > force KVM out of master clock mode. With this change, only a frequency > mismatch disables master clock. The only ways for non-master-clock mode > to happen now are archaic hardware without a TSC-based clocksource, a > VMM that sets different TSC frequencies across vCPUs, or a guest using > the legacy MSR_KVM_SYSTEM_TIME (which could be addressed in future by > simply updating tsc_timestamp more frequently rather than falling out of > master clock mode entirely). > > Running at a different frequency would lead to a systemic skew between > the clock(s) as observed by different vCPUs due to arithmetic precision > in the scaling. So that should indeed force the clock to be based on the > host's CLOCK_MONOTONIC_RAW instead of being in masterclock mode where it > is defined by the guest TSC. > > But when the vCPUs merely have a different TSC *offset*, that's not a > problem. The offset is applied to that vCPU's kvmclock->tsc_timestamp > field, and it all comes out in the wash. It's not though? The value stored in kvmclock->tsc_timestamp is per-VM, not per-vCPU, when using the master clock. It's a little easier to see once the master clock TSC isn't shoved into host_tsc: do { seq = read_seqcount_begin(&ka->pvclock_sc); use_master_clock = ka->use_master_clock; if (!use_master_clock) continue; if (!kvm_get_time_and_clockread(&kernel_ns, &host_tsc)) { use_master_clock = false; continue; } master_tsc = ka->master_cycle_now; master_ns = ka->master_kernel_ns; } while (read_seqcount_retry(&ka->pvclock_sc, seq)); ... if (use_master_clock) { hv_clock.tsc_timestamp = kvm_read_l1_tsc(v, master_tsc); hv_clock.system_time = master_ns + v->kvm->arch.kvmclock_offset; } else { hv_clock.tsc_timestamp = tsc_timestamp; hv_clock.system_time = kernel_ns + v->kvm->arch.kvmclock_offset; } To allow different offsets, KVM would need to track a per-vCPU offset to the master clock and apply that in kvm_guest_time_update() (and maybe other places?). Which is doable, but it's not clear to me why we'd want to support that (though I haven't fully processed the back half ot his series, so it's very possible I'm missing something obvious). From xen-devel-bounces@lists.xenproject.org Mon Aug 10 17:56:34 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 17:56:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387737.1628977 (Exim 4.92) (envelope-from ) id 1wtUEf-0005yF-Um; Mon, 10 Aug 2026 17:56:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387737.1628977; Mon, 10 Aug 2026 17:56:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUEf-0005y8-SC; Mon, 10 Aug 2026 17:56:29 +0000 Received: by outflank-mailman (input) for mailman id 1387737; Mon, 10 Aug 2026 17:56:28 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUEd-0005y1-PW for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 17:56:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtUEd-008Ycq-6S for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 19:56:27 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a10a9-2eae-0a2a0a5409dd-0a2a4506d452-32 for ; Mon, 10 Aug 2026 19:56:27 +0200 Received: from [148.163.146.23] (helo=mx0a-00498f03.pphosted.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a10c9-195a-0a2a45060019-94a392179362-3 for ; Mon, 10 Aug 2026 19:56:26 +0200 Received: from pps.filterd (m0367123.ppops.net [127.0.0.1]) by mx0a-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AGEb9Z1908470 for ; Mon, 10 Aug 2026 17:56:25 GMT Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012061.outbound.protection.outlook.com [52.101.53.61]) by mx0a-00498f03.pphosted.com (PPS) with ESMTPS id 4fyha31x2w-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Mon, 10 Aug 2026 17:56:24 +0000 (GMT) Received: from DS1PR04CA0008.namprd04.prod.outlook.com (2603:10b6:8:44f::15) by SJ2PR16MB6251.namprd16.prod.outlook.com (2603:10b6:a03:592::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 17:56:19 +0000 Received: from DS2PEPF000061C3.namprd02.prod.outlook.com (2603:10b6:8:44f:cafe::26) by DS1PR04CA0008.outlook.office365.com (2603:10b6:8:44f::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 17:56:19 +0000 Received: from mx0b-00498f04.pphosted.com (148.163.138.245) by DS2PEPF000061C3.mail.protection.outlook.com (10.167.23.70) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 17:56:19 +0000 Received: from pps.filterd (m0426315.ppops.net [127.0.0.1]) by mx0b-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AGFTA3499565 for ; Mon, 10 Aug 2026 13:56:18 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-use.ser.proofpoint.com [3.215.31.156]) by mx0b-00498f04.pphosted.com (PPS) with ESMTPS id 4fxpbshp02-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 13:56:18 -0400 (EDT) Received: from localhost ([19.12.92.222]) by cmsmtp with ESMTPSA id tUESwf7SGQLYTtUETw1jGb; Mon, 10 Aug 2026 17:56:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=fail header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=ppford; bh=Gz6 pDUp5rLV7SS4lZjhFrNaNaJ+FdUpeMI3ZZ3G7QvE=; b=tX28oPUFqdjZqIBuy7s 8hO2V0D0Fdxe1+5BmA0I82FucKEr1g3LOcjrrfb4UI1Jzvhq9EHDRksKxEToZZLo g1GVOBXLtkbVbJ3tQLU0jH/zStInnS3t4u1X94Hp0+eE/cSEXolhwbMKM+RakZYO qBtiwgQjF0OAnOJaJNuHMdLB8WHGHzLaX1zNwF1cx+x+2/qeJvZZ5ysk80mVuQMJ SJNqMA8ELD+rHlxEXS9hnhWY1BySUuzDZv3rx4geCiG2VYjiynCNXlsXYe21SjKL etQvcPXsCku2VYJ3ANZ3/46eajcc6TW16eo/IGE13EC/71++CHYZ4KUkZBi/udzb j/Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VZ1LKXPtRVbKqm1hOmFUycC0ZinT1rZHtxollgPIxUoFI++RCMiCPrQlNZ4NFC+swUDaVngGF2bFBrJ4P/AlptCA///Y87J/z3j1BpEQSFjlImA7Op3tjDsgfAiCeQlkss+YDyH0n3cu70zt7ML0u3++LCb0/uuP6R9wlO36Ex7k2TYoHztbB9Ow4aMuMFP3re3lSMtUjlNm05qQ4XWQ657sYudjO6cf/g9cog/orrlO9rgVEaRPnpzgEwrNu0vrbqTamN3A9L18xmB++iOPSB1DUYPShkDCTSND5LLQpY1XFSuEfBTQQWQl5DIQ/eMgxKHOkMSxi7ECL6HfKhZM9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=90aLdj9xpoZAg+4D/L3YjgL0OFuZL96uidt3wVPvCGE=; b=qWhj0UzYYZVp3G2S4/F/7QqkmaO4ExmjOSqVLY+f+xqd4zkjoZrkGdErt5DgMdQUvvhd05FJDs7w8I2dNLDzpdV/su2wCsX3VYz6udRYVnAVjTb+Z/CHwfvfqHI6C2qnB/NvSKfWlG7lRwe29h6fGLSICR7CUHpaSzxfhzLEDscVYvk0iG9IWt95MA35/JOU9X/x6CuixKMXkfESUjCWG+vUnHDh9LbtBzqVri6enAF61q4NkUO4WHSQZzbk9S4b3vyR0956LfyueQkOcHqJtcvYeyfTEEeYJmsR+FKKx4+4nAuXL0nqR0MTN+BkC/zoEka8vUnq3Fr07whz9YTyUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 148.163.138.245) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=90aLdj9xpoZAg+4D/L3YjgL0OFuZL96uidt3wVPvCGE=; b=IFwI0mRl5CyJBN34mujWY8FwjF9vuHDOqFoVO+ffUCLIJIqRnkO4nRRRzAoDnTjGMIHHhCZ/MvUfUZ/z38MP6mEHIQFEWHWrZjNLxQZnbQsCI/8HXOO3YSCdGIPhjcjKilaTatZuO7EIeVWK81tg0nLJ3VEgwO4kKWwwEa78pdg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 148.163.138.245) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 148.163.138.245 as permitted sender) receiver=protection.outlook.com; client-ip=148.163.138.245; helo=mx0b-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to; s=ppserprodsaar; bh=Gz6pDUp5rLV7SS4lZjhFrNaNaJ+FdUp eMI3ZZ3G7QvE=; b=OLdYk/+GyQolBDt6NFuzr+SZEaN7vQ1z8Ures+SvUH0Y31x i1eK+1NgKrzXDrd7f7jRMx2K+k2/KztIFdWrE77hMVuHASc2DIsw0A8DJ9xufuPF p9Ccw2y0TgU0PpY1PWepdWnfIW9pWEBESjgy+nAiSNCRi2oOe1SrKztwAiMwiO0l uJmJkXRLJkfjBdIlqjkVNOJs1d1SiwB+e1XVdU+E/yZKiq1K5bWN7WCtDaJtsnSt v/HOnsFDr5Y7R/MCs251lIjgQnTh2oohHf5g4s2pI53i/7KuIlUSG5bQmQJl9lgJ N5c9sRQvuaqJZ2ZoTR689vdI13gXCbDneTEG0tQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=ppfserpocford; bh=Gz6pDUp5rLV7SS4lZjhFrNaNaJ+FdUpeMI3ZZ3G7QvE=; b=I0tzNdRZXj7U myx5gR9XNF/qC29a3zRs0vt/24FkwXp/+eOcThd/BZObOCjaJzkvJmNaBHWUEK46 fqIMqSxZpA08S+QB4AbtPlmkgdSm0VVR3LvmBjOItpxMm0tSek709rgBLYqwxWsX +om2fldlkpxCaVoDArPlELW2vN70wgacsnzQn+lk1Ic96VsL+48vWUJJQU3KxEEr bFGh2x7dK2/yzDdpcs/87aHi111cO/s1c2MTurlx435n4GgL85HcfyLmJzIk/vAA iy0Yw/pJq6axNrG0SjG63vye5gpcScBgy8qLn8o0seBY8Ftqm5CgESIoQZQ1/Pbe 2Pv1vJm5aw== X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: tUESwf7SGQLYTtUETw1jGb X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com Date: Mon, 10 Aug 2026 10:56:15 -0700 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: dmukhin@ford.com, xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, sstabellini@kernel.org Subject: Re: [PATCH v4 2/2] xen/console: add compile-time rate-limiting controls Message-ID: References: <20260729072520.1556970-1-dmukhin@ford.com> <20260729072520.1556970-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_04,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 lowpriorityscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100153 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C3:EE_|SJ2PR16MB6251:EE_ X-MS-Office365-Filtering-Correlation-Id: c5900d05-ce6b-475f-0908-08def708ae78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|23010399003|36860700016|82310400026|18002099003|22082099003|56012099006|11063799006|3023799007|6133799003|10067099003|4143699003; X-Microsoft-Antispam-Message-Info: of+8K6UXo6HVjp/yQGV0USQZWukpLUfxKzy10o43BOsVvRHW2o5yGrXXOfacT2dWTvELFoAzIzxXCMdL22TEVHGrVyyXI+8Cz5YzTcyBzIuN7RTa8n1P6mebnzFQsS3mKjszdtcgT4DOt1LCN8Nm1wpcRoMAQ7XL+GlDVVkgDM3kaheKX9HO5omHwntN1m4gpMCWafil/EY+mJYp+x3pGkdPdHK9aczWjkqHivPDjJtgtSQBzF/3DlRyvF5+9E4KXAEjo+5edq2ysE/2T/QpXixej1GrtdZ6Bgz/OuyqMQHKTqnYk6+VyVDOj8lPp77k+XL1xfP8HukAypXIoWj2u4NS6mDh6RQoIlH6Qhws4vlDADiAio/sTXiZ1Iva+0gfxlTOQfUh/qk8dDg036LSFkNEObH2SJJRDqEC+m8CZ6utWpAxFUGIRQoIdVAW5M2a3nXvsityO+mQSMBUu2mG4YaQGHDp0PfUGuqzb/gUBDQUJnjphV2oYzZ22UsOX8CQicnV2oadsjmeoPsrciCklM5HscKD35pyP0oqM+L55loLwxPTK3gC/HnKG6bEtQei/zV4kVJipI3R6pnhmep1H9C9+3z3u/zWPaa8DyYpyNb/i7EUm02/5ugC8XFOw6E2Sj62yknhA/7381tK7A2gNImtzBeIBnwym4GJxPMy4Oy4Z57cIX+auhVPN6QHcow9x4dVNiyR7BgmZAQjM2Q8aQ== X-Forefront-Antispam-Report: CIP:148.163.138.245;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0b-00498f04.pphosted.com;PTR:mx0b-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(23010399003)(36860700016)(82310400026)(18002099003)(22082099003)(56012099006)(11063799006)(3023799007)(6133799003)(10067099003)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mjMwknj/dCb6IVPpUDxCywhz7ZPgeGL1/TUhATS6OzNd64IDymuOFGkhAeofO1FkAwQhwPy3FQXHobP6fICgO6JB3TGjVbZwxEX6BKYUueK/FMB5M1zvK8yTX/UooSm/9uTXoRSc/ZdNDASn2xIfB9bgj7YW1TSgj5RvtfSFkl/FzZ9YQ99I6HfU7TiC+8u8+C76ZnuqgEXja3n01dUCUiIsPFTal3GXZAJmsR26rgR/nJG2CjNuWHHfNO/vnhOi3y7l29UgRjXkUEFYOCVXXtIQKCmpjTLrkBQtOevcJLZ46Zo5Cn+J+W63k921MiIx63VBrgeY5o7Yg8xG2oQq5j/XD+ucuJDr6BDQvnfGrH82J/vEf+uM/7bFo8eCuCCV/8/1u8vGHFbKAb9Cw+tkevOLe0ldL5iJA91lSh+0LxiCnsQoucGElpsSAKe6xSU2 X-Exchange-RoutingPolicyChecked: cAMGfj9UUkhjo34bWMXF0gnGvE9ak5Yk11oDnbdtAVCrAdKBblsyVUCMxqE0bDo5mC2p/pKy5trTmsoJk7xhTq5HGGxbqthmFCxyqFMMm8Tk3gwTda3O7tLgrjYidCwQK2k3GrzJ3YOm23XumJlj8cQ3vmIT8dh4+4Rf/wXOMHS3m6UttHjYbF54Be8xfXQLViMWXYtpitHVAcQ6g+WxI75xogAZw2kaGyGAZCcM7Jm6Svu9KDRFyfeB7Df7Y2pqr3p85N+Y/HuZZp7oIPwniOOxGn9nzSgY8zki+8VVVkoWiwhQdk19tGv9aj9iyo6/0/A4fhunwyr7Pz4VQYYybA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6IQ2hPZ3WeT0LSG5sCPASC+BmMwkm7orVC/SmvIX6E7iZmgpIUPgYcxzfpb+ywvBmC2bX7hJadoOhMEMMmMn6LL0FhMH7exp/sxhQQGIQLuTN8FNW4Itq0Eyo2ep7zCU/dXy6WtlZRw5Ws3omlh/jq68b3Fk0s7DlPjhGB8ae9NfUijex2St0CTH4SlUQ5/L8DTJFp99z3ej11F1ybfX2T+3cUYq9FZ29kDW0h3Qv7Y6QmGEwCVVL0ssF9CKn1pLlTwJlplV3AYQvQjOC6fV8PZOrGUE/YZhVqsJndHw+2fUxxZGIhanbZyrTejag77AaCMi1uFpDbn/T4J8tkFwjVoXA5qqF+FMwTVI6FWDl23JVMAkXR+K+efcPwZpBngagdD6YVLoYaZGk92kGhCOA2P9bEa12DqBYQLgdVD4L1/P9cJFOUxwCQIYSDTknDaz83qm8oNj1eGEFbvc5GbsKbA056zHLLe53Kb4ZZYgcxxwI4HGwJhdPOPhe8UiMCKMuBA6Y1RPZ2SCmWevGxI0tieeGwetU33ys3ZWAH2erQgHNj1nrf5B5hsH+iDW7aVPJMKqDg1aEumJUElDSmsYF+7otquJrydQT8F43mGLE6PgJ01ObdVpJhIt7q2o1N0oBa5IiseulgFKmaB67ts7hA== X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 17:56:19.0102 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5900d05-ce6b-475f-0908-08def708ae78 X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[148.163.138.245];Helo=[mx0b-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF000061C3.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR16MB6251 X-Authority-Analysis: v=2.4 cv=AL134PXh c=1 sm=1 tr=0 ts=6a7a10c8 cx=c_pps a=HO36DfDzC3pv6rVb14NK+A==:117 a=b7IhknPlfT0FN1EembXvig==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=8nJEP1OIZ-IA:10 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=N9_n2FxmZfwfyRXvS9-E:22 a=VwQbUJbxAAAA:8 a=iox4zFpeAAAA:8 a=cbNQJ9GKAAAA:8 a=7fQNACYqGrSk0fLGjlEA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=G69WFyCBNqGPyalROSdv:22 a=WzC6qhA0u3u7Ye7llzcV:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDE1MyBTYWx0ZWRfX3N1ivz/zpM8Y KHWjz6nnh3yhq2y4KU2wDXimjCNrJLr7qT6dIBdWUFCdqNxgbdAaucRGEsJDB130g+suHobDA5q R34r1ZzonGkXey1/mMwXD8jh7DESsxMSt2zzsoeVHPskolsm2rW/TRlmhkRtSPjTZ+6pgD9fyE8 lTs3pV+pbAM+yUPhOddSIJKtuVZczOpQcuiG2RvtamT+TF/q4qhXxtoKf14jKPmihYNgNZYzzjf 0qZ3ySTC4I183cWx/tNiKy7AXtxyVM3X0byeoxJeY+Th/m2uKeJ7APAN4XsroKtj3/ZPL0/TPNW VBQampdKIt6B50UXC/CGE7gH/cdxxqj9ebCYYdES2aOSr13d5JH8stsJnSRahlX+0OLTvPu48E5 ExYfc61LEWV4dsCzylsIdZGJK8IgJDvqRxGOk+JmcWNy93Kn39+2h7DkOLx+GaYWsTv0EdHYVvt n7Y9Rb0hpaM5f+qQtaA== X-Proofpoint-ORIG-GUID: j3-rNN05blIRF6n3b-F9A1nz0TBaf4qP X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDE1MyBTYWx0ZWRfX3UzmaHIIOv88 F7QQX5eKzCA8Qm7cd+8oPRRdoIDYR3pc0pf5LLYFCmUrjWjRwWdYbzT6RJ+a8pRm1wCTkVMuc3d Xubnm5Ub5YzqcclnYVXmI01MAxKtftkqvgunLYMgbzAG5PlCXYKk X-Proofpoint-GUID: j3-rNN05blIRF6n3b-F9A1nz0TBaf4qP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_04,2026-08-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100153 X-purgate-ID: tlsNG-16d1c6/1786384587-FC20077B-C2303150/0/0 X-purgate-type: clean X-purgate-size: 3335 On Mon, Aug 10, 2026 at 03:06:35PM +0200, Roger Pau Monn wrote: > On Wed, Jul 29, 2026 at 12:25:20AM -0700, dmukhin@ford.com wrote: > > From: Denis Mukhin > > > > Introduce CONFIG_PRINTK_RATELIMIT_MS and CONFIG_PRINTK_RATELIMIT_BURST > > for configuring rate-limiting policy at the compile time. > > > > Use symbols for global rate-limiting initialization in the console driver. > > > > Signed-off-by: Denis Mukhin > > --- > > Changes since v3: > > - added note on security support for non-standard configurations > > - gated menu with EXPERT > > > > I kept both settings for now. > > --- > > xen/common/Kconfig | 36 ++++++++++++++++++++++++++++++++++++ > > xen/drivers/char/console.c | 6 ++++-- > > 2 files changed, 40 insertions(+), 2 deletions(-) > > > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > > index da80fdba8469..749d3bfb08e0 100644 > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -672,4 +672,40 @@ config PM_STATS > > Enable collection of performance management statistics to aid in > > analyzing and tuning power/performance characteristics of the system > > > > +menu "Console rate-limiting" > > + visible if EXPERT > > No strong opinion, but there's a drivers/char/Kconfig which might be a > more natural place for those option to live, and then there's no > reason for the extra menu? I had the knob initially in drivers/char/Kconfig, but moved to common/Kconfig to address Jan's feedback: https://lore.kernel.org/xen-devel/2eba7de1-a8e2-4c45-affb-8ecb91278707@suse.com/ > > > + > > +config PRINTK_RATELIMIT_MS > > + int "printk rate-limiting time window (milliseconds)" > > + default 5000 > > + help > > + Specifies the time window, in milliseconds, for rate-limited [*] printk > > + messages. No more than `CONFIG_PRINTK_RATELIMIT_BURST` messages will be > > + printed within this window. > > + > > + Setting this value to 0 disables rate-limiting entirely. > > + > > + Configurations using a value other than the default of 5000 are not > > + security supported. > > + > > + [*] Rate-limited messages are those controlled by the `loglvl` and > > + `guest_loglvl` command-line parameters. > > + > > +config PRINTK_RATELIMIT_BURST > > + int "printk rate-limited message burst size" > > + default 10 > > + help > > + Defines the maximum number of rate-limited [*] printk messages that may > > + be printed within each `CONFIG_PRINTK_RATELIMIT_MS` time window. > > + > > + Setting this value to 0 disables rate-limiting entirely. > > + > > + Configurations using a value other than the default of 10 are not > > + security supported. > > + > > + [*] Rate-limited messages are those controlled by the `loglvl` and > > + `guest_loglvl` command-line parameters. > > Is it common to use footnotes in Kconfig options? It seems a bit > weird to me, I would probably just expand inside parenthesis if > needed. I'll just drop extra text. > > Also, I'm a bit confused by the mention of loglvl and guest_loglvl > explicitly here: messages outside of the selected level are just > discarded, and hence it's kind of obvious that just messages inside > the selected level are controlled by this rate-limiting. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:39:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 18:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387758.1628995 (Exim 4.92) (envelope-from ) id 1wtUu0-00044K-6N; Mon, 10 Aug 2026 18:39:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387758.1628995; Mon, 10 Aug 2026 18:39:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUu0-00044A-3E; Mon, 10 Aug 2026 18:39:12 +0000 Received: by outflank-mailman (input) for mailman id 1387758; Mon, 10 Aug 2026 18:39:10 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUty-0003vl-AR for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:39:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtUtx-004GdX-Nh for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:39:09 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a1ab1-8faa-0a2a0a5109dd-0a2a450cdb52-10 for ; Mon, 10 Aug 2026 20:39:09 +0200 Received: from [52.101.70.108] (helo=AS8PR04CU009.outbound.protection.outlook.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a1acd-f479-0a2a450c0019-3465466c25df-3 for ; Mon, 10 Aug 2026 20:39:09 +0200 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) by GVXPR03MB11092.eurprd03.prod.outlook.com (2603:10a6:150:2a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 18:39:07 +0000 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7]) by AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 18:39:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MkuD/4uC1xz1LgDqjFjLm9BB+pFe8iDtLQSjSZXM2QWKDdVM1RdmJMsOBx8vOx8W4GfD5iMXOAer1k9NOoqEErYMO54CcCiWJMG8AyfLOvLBIAVIwLg8U3/2NutkHV/lGh0jTDw0Uy61O2GOKa/WDoD3YuhHRcoEB9jAhyMdOq/ivqxlty33oAfCvMkd1NUzUzaEPSEsToSib+olYEYCDN4WQ/G63BAVmj2CSIhUlKJimw2Q40du4oL8dn4jmGrZU8WCsz9vlnNpCiRsPzT2wCVhoHo++Nn742Q28A5kkeKxqqUAsuvR6iHXVKUvFsA3z32VRIhELKQQF2j2SiFUQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kVyUwzxHfI4tTSVlImEGxF+daEm0IvBED5qt0xYcoeM=; b=a1lvWneZW2ld6z2L4txc4Av537scTG3wBQ0HEn3pWvxgd21Dts0/lp4zJ17yWCjMwMWiWYTvJsVQuQNIL8A3dFtVFsOKXYsoSaJ3g03qv+/IabUMIWdE3+lKzizXSB4QT4jQBfaFNtrxrD+LAWIpzmy1Erdke0TYXInfTNFD68eAQj/Ey9XLeCvZeA6MffSexNZiKpPNd/io8YyLzjq6+DQ8rU4Yvof8dfXRSd90LaWwhP/wqAK7pOZYI/SWWyQHpHVz9Y7RjdqCskhXzPB4yEo/kFjeNLVtrAy5R4nmu6uYQJpG3t6A6H5wJ/dfPto7yuoSEouQtRanPawcc0qUtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVyUwzxHfI4tTSVlImEGxF+daEm0IvBED5qt0xYcoeM=; b=piJhzkEDpo90vyz5ZbtXC9IGOoBH5okMIm4+4GYVqeDe7z1QXYmZBwWbwXzr0DQl+XtjM3sWwXLWd1596rNW/yhQqYAZ+AfbWCqokq7c1PyJfGF9LsCqxNUQr5SaRL/HMt+kH7ueE7EkwAkrASNUcfDAvRAmOBwP9GJXDOVfJ0VYIWdaMC+2MinsxDYN/hscnD7HQ3DHc43szvh5MIeGvbpgZCpwilVyhxNf8WXQ/t5diIuI5r8DUoI64GAl01dIvomheqne0I1XZyHq+dlPyf4vXCfDKoawKc7lWUVz3LbI4uOSbHFMl2D4Vj82SviVEuCTPMDBzc4UFvJLWCSCEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH v2 1/3] xen/arm: validate IRQs before descriptor lookup Date: Mon, 10 Aug 2026 21:38:45 +0300 Message-ID: <271952244ae71ade885b3619fe161ed4f47777fa.1786385827.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: WA2P291CA0003.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::7) To AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR03MB9746:EE_|GVXPR03MB11092:EE_ X-MS-Office365-Filtering-Correlation-Id: 79716599-33e7-4502-41eb-08def70ea94a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|23010399003|18002099003|22082099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: DTnUM2/yO4tjM4VCe3opWtzRa8++oAhrGjQfzYkLtdJjUPPqLBX90BF7HK7JUwdwZbmg53ENtQnt+r0fBKZWOn2SrLu33aEp8zNxz0hzgeUo4VBlUQz4t9ip8VGxTfZNU33wOp9SOlgpJlHIbpWUP0Q4iTucTim2d0hK4ZbOzexE5P7cOuTBI/UBKhFc9vR7AyNACVSDrT/0XPaPUVrCim+CkeRxETL+lfU0i1At8lMJTC7OPYJ8mNGC6muf7NkxIgVwmNu8nxU78af93OkOcXHGr4x2sQ5be/Y4Jn+6nCT15Y+pWNOuOIM3FN2XwRUDME8JfZMbL35nFr+OAMnSdHGvxka7kAhBBGKmz/0EClXD6iZnXJGn1cFogFwMEqRxX6NkMzQaFaU1fq6JGEtz+kiZupNQHCYuJtmZuWNUzSmcmIwiQs2FCh0JfXFYsBcP/JiQadRSIciADhLDU3kHemWJVXFFO/aZa1edAfT4+dA7ui0QbXmDCfNNCkDuFCH+8tA3viBcYcI1t7uGpM/JX/DtMzEGC9V2rw2kqkTd6Av02OM6sDBOt/N4F9OiQv7pbnhyfZ8HTouv6g7bgWCO1CCfSQNwn7krloCQMGsP8+wKSa/UfBZ56kjjjbFG/2TNmHRBIoUoTYHBHW6oe5W7S++jj4uyWQnMrPGspG1rMTQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB9746.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8TwRj4t0Dm316TSSixjbA2N+QImoV6fuL2ASZC2X79mr52JBUeIsygCCsLTk?= =?us-ascii?Q?j2epDIzrZivut/lnMXwjURk4TAyJshZOKi5fHokUfPMvoVdr5+KzLSdAw7ML?= =?us-ascii?Q?vNv5McFPJk/fFUc1x3bDU0kQUYrHKsp2LeJnmqE+Pqt9wzAxsTtPf8UO/j87?= =?us-ascii?Q?lp6L7cK2TnLyX34EuejsJnmC9YnHsYGulngsuRqMNn4z6ogYasHPKJwCCADM?= =?us-ascii?Q?S74bHXA/OCeexVYurTIGdtN65CKqWCdXhqYlG0mfmllJCRRTTWxquhHvQ8Sf?= =?us-ascii?Q?1Vsr0FdYVvJaBxXsaFh6E9hr9qLAiSF+Nw1S20HAzBevjRaCrbFSuh1Wc3Ps?= =?us-ascii?Q?pE49w0E0Dn9LlUwLWDWB2+ZDBvp+4hdmSf1HS2EXxkBDfchFEAnTH8FKw8zP?= =?us-ascii?Q?S/Xhu4FIZ6WfWnBdfJo0Ff71f0RnhevYj4z6AbXTJWS9o1vbnRem8B0HD4jv?= =?us-ascii?Q?6511hXNWoNMhwqYbYkBQ2lUK+R0dSLOat8eNzYfAom7Eo/K7B1BGWSOIiwZ0?= =?us-ascii?Q?8NHRPgyf6hOJlHMhZZRfqn1RDNxkhUuDE9lQ0NaBHZTHAPcUGCFqVAgdA9V2?= =?us-ascii?Q?mOHb7EXxUjYSnG+14o8eO3mNQYpjMCytBAi81vMl1MqRhXVi0FwO5RMcdK11?= =?us-ascii?Q?WVDOXmvsh6s+XJu3jYqeWVEfVxV/Hwd2ArRr1YbQ2D+uxBwZrXNXL8sIZdfr?= =?us-ascii?Q?+G8he6vuy2o+PHBbLYAnzkejK1I/31nno6df7GOdxquAxJgHWzE2NPoTDr82?= =?us-ascii?Q?UZFD/vOg3ha8LjT/MNfz1cuOFBOcKLExXp7s8PddpSJzcQ9kpE4UiE453I1x?= =?us-ascii?Q?XgVesgdVVG9iqvagS9xhofu7b7NxVJMLR8fihhPRzO3Ca94gtBMtWeEJF7Ws?= =?us-ascii?Q?GQfNfUuFTn4vk31yGcViRBu3mg0e3i7x20qfw/i4zxYsvaI85GwqIVPfm20z?= =?us-ascii?Q?cI+vRo5kG+i5Gw9tIWFGEkd4FBrb6Y9Qc8EZ63upfWhpezykNApG/uCQcOJI?= =?us-ascii?Q?PfPcUjxTCJPikQDcrEJ8M4mpP53e1zBAwJsuwVCWawZ/eq0rMVjJO8o4DaC4?= =?us-ascii?Q?isBx8vPM1RQxYcJIt2+yj1xgQR1V/F6yR2+mSDXjMVGJLWra+r8cGLX+67gH?= =?us-ascii?Q?x08c2ryYStJsH6SWp9TxHNX/nNKU4SkDk7E6CSGwY/jZGbTTUuTkSrtOguAu?= =?us-ascii?Q?40kUrPsMVgkTgVGRJRrfx9QVOnVt2ivimUL6nIKEFPDT4HQnuIh/VkPe/4DR?= =?us-ascii?Q?RnYzWqJn+DcVQeVa2QResrsKTQZK9FAWaWXxwQIgjZG7CyPbe5J4cWJHm4Lq?= =?us-ascii?Q?2gt5z/L7k/cUP2Ck1/w8Snw9+odWmlG7Iqo7lvqPj0el10GcAEIgh1/pJoF0?= =?us-ascii?Q?khxh+O+QzaNWj76g9Quzt3sZKs9/GYX3K0dG1dftlg4p56MfvMB3d0xAnbuX?= =?us-ascii?Q?TvDOhVhE33r9QfER6LSf6qkOwXdjdiJhBg0F3BN4PxAJO36PZZ5itznjR2xE?= =?us-ascii?Q?BymYBkYjnNiQ/6oiIKNjC7dQT865siQaUNWWEgKmRcKY2nK/RdiA2CZwjAJg?= =?us-ascii?Q?2ZyZ1oRp8niZ2T0oYuonzmaWAPOnKjMgZ2fnEWXj5ac55tzfqw2mianJ+79t?= =?us-ascii?Q?1GZf9a5I6FaW4sNOwHNuHNnA/YboPFybqLLGrKHEniQtvo08tkMvOVhnsRie?= =?us-ascii?Q?Zm521yO3L1FmmcVz6k1XwvRmh2j+UfWQHQU/VLnMg0N3uy+vDiCNH+3XnV7w?= =?us-ascii?Q?D1+f4dbmdw=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79716599-33e7-4502-41eb-08def70ea94a X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB9746.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 18:39:07.6512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pmxpi/7tZS1iZXG9ZIIbY5b8dD1xyie2gBhHlftMJYOGWGnj1ARdYFPeGvqXZxQqO1mbWlQvOAG+AxHor37qhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR03MB11092 X-purgate-ID: tlsNG-d25034/1786387149-00ACCA5B-B832265C/0/0 X-purgate-type: clean X-purgate-size: 3677 GICv3 eSPI support makes nr_irqs span the architectural INTID namespace through ESPI_MAX_INTID, but descriptor storage is sparse. local_irq_desc[] and irq_desc[] cover INTIDs below NR_IRQS, while espi_desc[] covers eSPIs. INTIDs 1024 through 4095 have no backing descriptors. Validation based only on nr_irqs accepts an INTID in this gap. __irq_to_desc() then indexes beyond irq_desc[], and callers may lock or update unrelated Xen memory. Reject INTIDs that the GIC reports as unimplemented in setup_irq() before looking up a descriptor. irq_set_spi_type() can run before the implemented GIC line counts are available, so validate descriptor-backed ranges there before looking up a descriptor. Call is_espi() unconditionally in __irq_to_desc() and provide an espi_to_desc() stub when eSPI support is disabled. This preserves the is_espi() debug check for eSPI-range INTIDs when support is disabled. Fixes: 98f7060b9ed5 ("xen/arm/irq: add handling for IRQs in the eSPI range") Signed-off-by: Mykola Kvach --- Changes in v2: - Validate descriptor-backed ranges in irq_set_spi_type(). - Validate implemented GIC lines in setup_irq(). - Preserve is_espi() validation with CONFIG_GICV3_ESPI disabled. --- xen/arch/arm/irq.c | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 73e58a5108..0f5d3496bf 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -23,6 +23,12 @@ const unsigned int nr_irqs = IS_ENABLED(CONFIG_GICV3_ESPI) ? (ESPI_MAX_INTID + 1) : NR_IRQS; +static bool irq_has_desc(unsigned int irq) +{ + return irq < NR_IRQS || + (IS_ENABLED(CONFIG_GICV3_ESPI) && is_espi(irq)); +} + static unsigned int local_irqs_type[NR_LOCAL_IRQS]; static DEFINE_SPINLOCK(local_irqs_type_lock); @@ -77,6 +83,12 @@ static int __init init_espi_data(void) } #else +static struct irq_desc *espi_to_desc(unsigned int irq) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + static int __init init_espi_data(void) { return 0; @@ -90,10 +102,8 @@ struct irq_desc *__irq_to_desc(unsigned int irq) if ( irq < NR_LOCAL_IRQS ) return &this_cpu(local_irq_desc)[irq]; -#ifdef CONFIG_GICV3_ESPI if ( is_espi(irq) ) return espi_to_desc(irq); -#endif return &irq_desc[irq-NR_LOCAL_IRQS]; } @@ -416,6 +426,9 @@ int setup_irq(unsigned int irq, unsigned int irqflags, struct irqaction *new) struct irq_desc *desc; bool disabled; + if ( !gic_is_valid_line(irq) ) + return -EINVAL; + desc = irq_to_desc(irq); spin_lock_irqsave(&desc->lock, flags); @@ -647,13 +660,19 @@ static bool irq_validate_new_type(unsigned int curr, unsigned int new) int irq_set_spi_type(unsigned int spi, unsigned int type) { unsigned long flags; - struct irq_desc *desc = irq_to_desc(spi); + struct irq_desc *desc; int ret = -EBUSY; - /* This function should not be used for other than SPIs */ - if ( spi < NR_LOCAL_IRQS ) + /* + * The implemented GIC line counts are not available when early + * callers configure IRQ types. Check descriptor storage here; setup_irq() + * validates the implemented line before the interrupt is used. + */ + if ( spi < NR_LOCAL_IRQS || !irq_has_desc(spi) ) return -EINVAL; + desc = irq_to_desc(spi); + spin_lock_irqsave(&desc->lock, flags); if ( !irq_validate_new_type(desc->arch.type, type) ) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:39:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 18:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387757.1628987 (Exim 4.92) (envelope-from ) id 1wtUtx-0003rI-TA; Mon, 10 Aug 2026 18:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387757.1628987; Mon, 10 Aug 2026 18:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUtx-0003rB-QC; Mon, 10 Aug 2026 18:39:09 +0000 Received: by outflank-mailman (input) for mailman id 1387757; Mon, 10 Aug 2026 18:39:08 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUtw-0003r5-68 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:39:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtUtv-009VLW-J2 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:39:07 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a1a9c-e002-0a2a0a5209dd-0a2a450ba360-38 for ; Mon, 10 Aug 2026 20:39:07 +0200 Received: from [52.101.70.125] (helo=AS8PR04CU009.outbound.protection.outlook.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a1acb-b7e8-0a2a450b0019-3465467d094f-3 for ; Mon, 10 Aug 2026 20:39:07 +0200 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) by GVXPR03MB11092.eurprd03.prod.outlook.com (2603:10a6:150:2a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 18:39:05 +0000 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7]) by AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 18:39:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jj06GD4Ya6mMdi1TTCLyxnC2ZcN8Dza/D87t2MSRCtMEqqaT/VXhdioR5GbpsF6yqpZ1A/SqipH6S+FP42VWKDCMfRzqAKzyZWP9RyLaKf48AZpPydhj9rmUI2OZxuwShqDZKqCHxx5ee9IVvnGFmsxO2DgNm6W/yWgDH1B2UNh/E3XETFOHZy/TXg43vJEoKKgRWXWSXywvdrrhFo/6K+6cSRfl4/qVYSGDd6Q8HOrSlSXbCIn+jOE4FLDEJQdUVgCa0DtoUNt475V3ZUs3guc1pEsgbv30TrXovNfKSdlksj4F2PyhL/e5W5/KcD2TVXEA0K3C48InX3yPdfOqpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ApfjuVvydupd2rUlQk2WyhjFCE9BsKkNyBdZC9YvoY8=; b=dXPFgJllcdkfgk+U9eu7g+ScQZvTWOTQ6R+2W3exXnFtnlrKLk9yIfncBYWBRCWZFUsibybGvJmdvayVkG6fAjw1ABGoTgSRNF44kseKpPBrQIqpCg+xYBmiWRqJC2yCLXjuhnODuHSoSrsaP3Oyz1PRrVMq1MECWkZiiIEgdoxXUfU1FgmnfuT7GALifqMrNxQiaPPgrGiWXBBxmchMapzWOk+dbP54Iuopa7h9Xy+U0lFBOks6uOoDvjYnMW5o4tAHn2uib+hWGi36DHFUEpLlH2J+uRDlvunlndrijAt/aMGxU2Ibx3Dhcg9BazYeHF6+0iiqu13oRiod6YO7gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ApfjuVvydupd2rUlQk2WyhjFCE9BsKkNyBdZC9YvoY8=; b=BwexvDA3nCJqyxCDH+K8vrNGkjfDdEqAiqNl1VQnW/p4fPNoduOhi9g10/oqRy1sNfVDxwcu/hOzm091PNyVWzU5koDpeLKqqtB1OMmuupUoxI6OPz0C50EobHg1UIE0E4CjX1js0Mzy4iQ7qck4baFoN4LP/fM6h9FSINARbZMKFzeNqv8u4kj9iysE1jaTfpW3xEbS6ObE8kZprbYQsmClHzJOpwAfXDqD+7xVsohRS9uPxOShoIGJgwL4uARpgnwkyynKXnpsdTl5A0NLaaOoqjwfg2YtzmP0cpknhIzUlwrqzVt1u91vWUoDtjbrhhmteFUxkwukK30tmscyjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jens Wiklander Subject: [PATCH v2 0/3] xen/arm: Fix eSPI IRQ handling Date: Mon, 10 Aug 2026 21:38:44 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: WA2P291CA0003.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::7) To AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR03MB9746:EE_|GVXPR03MB11092:EE_ X-MS-Office365-Filtering-Correlation-Id: 320c9fd1-d5b5-41a6-31b3-08def70ea796 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|23010399003|18002099003|11063799006|56012099006|6133799003|10067099003; X-Microsoft-Antispam-Message-Info: qKGKiW4ol7W3hk3YPSqDQOjW/jHbwjwSVHyzVgYrsH/mpyBr3OTZeU3/boPEc3RSBk975QUBXZ8pdL3szIrHs0RXvjmeov+i29u1wrT0NB0lSfvcwiIPYEWg5OkT8humvTEqI6ScZHFMTCTZm+sn4aXuwmXEtceKDN1mgy/+q9dBlAQ9EefXihNpCp40jTaCPbP9FAXBPgBdlT2K0eudnK0bbJiDtOvBlIGuCJ9vTca3LSzeZJNBjB9q+XUpBGe2rZPcdkeOPsjQsCP3z8zdC5jPyOdAONdIl+CSQmgsQYgmw1AGvOwxIuRw3pK4oQG0UckfUXtfIh1U2fuRMXsLOJsCgvR0R9XXoIsfmJTUOz6QmxkHz71pGNXQRg5nOjXOrWryclNI+ViBTHuh9+tv8C8wB2X0FMvfCSVsI0GG0Tnj46mTRrG0uAUNVBu5X+DqqgC4XV2Ze3mqUB2heb5l6gnqIciwDp9sRefp9QCinfp0WVSLVG4YN1tfy6Qy00rR3WJq0sjCXIKyAxgemGQLUlkkNWV933t2UQsyx5eL+8vyRaJCOPF2jaKezGihfwp0QK46xqtGRwOAlkbKXSgWH+h1yVgdzeQ+lN8zsJZraIY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB9746.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(23010399003)(18002099003)(11063799006)(56012099006)(6133799003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jpIRXTn8qK8h832UI4Doeo7kwPOQPwEKHYsVNTPwYxylw4ubIOviPElKni/0?= =?us-ascii?Q?B0lVB9PQr4gMhm3S2hsENLvee5Vos38rST5KZjoPROxu4DUxx6V7FCK8HyuY?= =?us-ascii?Q?g65qX9lNDgMLiYsOf6rBJ6u6Ml/5qGar3In7VMka6e+fkFQke+X07+qhge1f?= =?us-ascii?Q?HkirX8GzGeOEjIJaGtO3z4xc+iFMkd8HJAVWn/evaUJ5FrjuD3ionOwzZh5i?= =?us-ascii?Q?bU9kAAFaho95N2GS4mNeRVx8RlnIFMWjsraHHC4eso9wlEIJrBDcMOJgHY7P?= =?us-ascii?Q?VAKZWzGQUBeK1pTkiPquh3vYv0SGuM8VTL/lL12CI4y6/LfK5EJ+LkfNumYD?= =?us-ascii?Q?BLHMaUY4S2q+PtCwOeuu7JRoivydZhcYxtxi7SbYEe0aaogGtXAMIADwe8rR?= =?us-ascii?Q?lhS0CD39LFlixPG7KeIfjQyOOFtusINJ7ZJ9iq9IUbHE7LhRMM5JB3tlqwJL?= =?us-ascii?Q?KZbjEAT/Nztv2YRduLTg6G5oeFIE3gI5zey5RF+AcQLXKav+mBUFMLmYgXp4?= =?us-ascii?Q?0McrUZM9LPdBEVJ+v85tEf+3JRxFVxTxm4kBMdtjIvM+Tx2JBZjfHtiYTw7v?= =?us-ascii?Q?yqx9m2Li6sjy01e6uuk3aoY9dnsJ1EQSf1UfrUogQAGoo1+042a9jF+eEpk8?= =?us-ascii?Q?GxWGS+ZN7QNpebpABHHQJzHJgDGZI7Q+9ayhHPV1gvXwoCawCvP/7GvDzJ+X?= =?us-ascii?Q?smjzHdeIXvuIbjMjwjNGMg0Jg+OZAGYi7wk6wxNAw1BioNkvIyOFuhI0jNt1?= =?us-ascii?Q?DfNwLxHdO1gAmXC0TptKUyY5bXAdgRaqaAZoRKq7KHWTKZ9LutyCWUlFIWNE?= =?us-ascii?Q?STiM+XQhmPBaL6ygTwCgsq0aDrMIgT8ZvIFnXuDu3VaGtQGiI8dE3nCyyc7w?= =?us-ascii?Q?lsBI9MrufDcT8thFpQv+OY4niooKTe7IF7dFoRFRF0OJifm7I8ZSdpeik5VC?= =?us-ascii?Q?fGdRieitfO5rCv2a3eKrSlUT6vAig60Kj+KIOCQxYooGTJzqFPf/YJPG8M2U?= =?us-ascii?Q?kBN8dWb6ISkQO+xFrDXF8CS3W9RgjT5x4Hz1dUG3edKR3RJ+RI98qIirOAKg?= =?us-ascii?Q?H1KgCx/TwAXR60HOyfTlShvVJA/dPNNy/FLDXyc+c/wtDb5guEq41SN5GKt/?= =?us-ascii?Q?tIxxP/+5o5bs8cofNncDufbhuRJOI71q2OgwjXhvXyg9o0wRwM1LXhcNcvcw?= =?us-ascii?Q?14ovykgpiMhKNwAJLpOqgBMSPuDGKFVVcXR/EOO5fl3hIolmRWQPkXlm9kS7?= =?us-ascii?Q?IJ3wrFIOe2s2+6GST+7zIPxu1y2qKt29VzWIWFssO8IasQp/7jLP+VoKc5HV?= =?us-ascii?Q?99D1Htf0ixkmiPTbIt6rE4e+ZNRbCEsOLI7cyv9rMonl98wHXUdhier0r+Uf?= =?us-ascii?Q?c7wMFaIO40VhY2eCfQWCvVHwryO7mpPx0DvzDJJs5pFBzreuyeUBDDFDIEM+?= =?us-ascii?Q?lFyab8lMp/lAgol1d+sDUxM1RiJ3LDwEWg35eQc2RB3afGkZMHifktFhbSDA?= =?us-ascii?Q?OWtiavUVm9qb9MdSOk9rELNV3T9xFRuM2GFxRpi3RFzK4IunKYYUAdRtrzk9?= =?us-ascii?Q?h1brqKg9N1inCiFHoS6pPtGhTxsESruHQZzLFEg320jgrK0xH2DZSb1aA7dU?= =?us-ascii?Q?zCVCcB7GnHdyYyJ/Q+L2QHoxa3lI320ydWzWyBlki1+ST7SANZgY7B2gBk+P?= =?us-ascii?Q?3BXbzRbx8XAtuaFKMfCkbul9fpCgsM4eTVOH3acoxTNe4nL2eTa3V00wOH6d?= =?us-ascii?Q?OMwQUyP1Uw=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: 320c9fd1-d5b5-41a6-31b3-08def70ea796 X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB9746.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 18:39:04.9618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4mU9lD0hsQBYUO+WNhSqACEc/MVrbt1DKKhBWpmZEIMzbGRmkcASGvWO9aWeiVL97EAsZyCs86vsQPRoXWcicQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR03MB11092 X-purgate-ID: tlsNG-42698a/1786387147-AB6D29EA-AB4E72D4/0/0 X-purgate-type: clean X-purgate-size: 2349 This series fixes sparse eSPI INTID handling and checks errors returned by irq_set_type(). Xen has IRQ descriptors for INTIDs below NR_IRQS and for eSPIs starting at 4096. It has no descriptors for INTIDs 1024 through 4095. Patch 1 checks INTIDs in setup_irq() and irq_set_spi_type() before these functions look up a descriptor. irq_set_spi_type() checks descriptor ranges because the GIC line counts are not known yet. setup_irq() uses the line counts once they are available. Patch 2 fixes the vGIC allocation bitmap. Reserving an eSPI used a compact bitmap index, but freeing it used the raw virtual INTID. This could write past the bitmap and leave the eSPI reserved. Patch 3 is new in v2. It checks errors from irq_set_type() in the GTDT, MADT, SPCR, and FF-A paths. GTDT and MADT could keep a rejected timer or maintenance INTID and later use it in a direct descriptor lookup. This patch also fixes MISRA C Rule 17.7 violations. Tested with: - Arm64 debug builds with CONFIG_ACPI=y and CONFIG_FFA=y, both with and without CONFIG_GICV3_ESPI - FVP Device Tree boot with 64 eSPIs; Linux dom0 started - QEMU virt UEFI/ACPI boot to a dom0 initramfs shell; this covered the GTDT, GICv3 MADT, and PL011 SPCR paths Changes in v2: - Check descriptor ranges in irq_set_spi_type() and implemented GIC lines in setup_irq(). - Keep the is_espi() debug check when CONFIG_GICV3_ESPI is disabled. - Remove a redundant CONFIG_GICV3_ESPI guard from the vGIC code. - Add patch 3 to check irq_set_type() errors in the GTDT, MADT, SPCR, and FF-A paths. - Target master instead of the 4.22 release. v1: https://patchew.org/Xen/cover.1783671887.git.mykola._5Fkvach@epam.com/ Mykola Kvach (3): xen/arm: validate IRQs before descriptor lookup xen/arm: vgic: free eSPIs using the bitmap index xen/arm: handle irq_set_type() failures xen/arch/arm/gic-v2.c | 8 ++++++-- xen/arch/arm/gic-v3.c | 8 ++++++-- xen/arch/arm/irq.c | 29 ++++++++++++++++++++++++----- xen/arch/arm/tee/ffa_notif.c | 11 ++++++++++- xen/arch/arm/time.c | 18 ++++++++++++++---- xen/arch/arm/vgic.c | 25 ++++++++++++++----------- xen/drivers/char/ns16550.c | 5 ++++- xen/drivers/char/pl011.c | 4 +++- 8 files changed, 81 insertions(+), 27 deletions(-) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:39:15 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 18:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387759.1629005 (Exim 4.92) (envelope-from ) id 1wtUu1-0004HA-D6; Mon, 10 Aug 2026 18:39:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387759.1629005; Mon, 10 Aug 2026 18:39:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUu1-0004H1-AH; Mon, 10 Aug 2026 18:39:13 +0000 Received: by outflank-mailman (input) for mailman id 1387759; Mon, 10 Aug 2026 18:39:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUtz-00043z-Tb for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:39:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtUtz-001Qiz-9s for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:39:11 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a1a97-bab6-0a2a0a5309dd-0a2a4506e8ae-28 for ; Mon, 10 Aug 2026 20:39:11 +0200 Received: from [40.107.162.106] (helo=PA4PR04CU001.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a1ace-195a-0a2a45060019-286ba26ae5de-3 for ; Mon, 10 Aug 2026 20:39:11 +0200 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) by GVXPR03MB11092.eurprd03.prod.outlook.com (2603:10a6:150:2a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 18:39:09 +0000 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7]) by AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 18:39:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q5uBXhzZOluqHZr0P63zd2MnW5MM1HybjByZYGeEQdeVkyWY0vTsEjGbHm3nyJOBdXm5eGKZ4O9VptcC7UF50wGYPDvtDIywmSS2djXXY2/QUdu6XlGspGkE9Q9LxLMM+DCkQ1NnjZE7PzNITArbjH5Btp/U3ZRXNxcvwlVxpM63sLZ7ppSkrreQkmVhH0IJocjqXgIlEvgC6IBYk2NCymoMGGhSQzdqkc58D7IwN6S5cB9vwDtlLPmZSO2fNakfGf8bhC5DW0OgcboVoDPimEbNucdpcj3HkcOrOlnB7Xgp/jU5muGz8tYO1yxLTV7En8+MvgWHhAz1rSSgYkxocw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3oS5+tMpm/5iXbHipLKgLe69zKs89CKb5K72EOJFaZw=; b=m7QzPTf1vCaIA+54KwKVqE0+fOyBelUiQ0wdpRCjmREd3E662KF29u+zkjy2dR5OgYf54WCDOz/ytpdG8FUUkAbvXLsCRF5uXwMIQkjfcd7ZCyd2W++UnTqe9BYO8MEjg1sbmPYtf8aY5GSMjW6lXDbAvc+qBBMTg1+aAL7FOBhNe1nj8lLt7EeRXc+v4UW8ENkcAam5Y0HErWOjic5jGmL3Io/dfFId+2DP1bNh5tmUJd47/TUKYY8mm1AwyGQnpj0HIyeYyC2OW7n67hVffbBBVVr5MNPhg15QRRCERfQZxZI4th1JUdx9k1r0jxszBfyktpr7MBvT5SKlc8rhIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3oS5+tMpm/5iXbHipLKgLe69zKs89CKb5K72EOJFaZw=; b=DRg3NnZs4JflfK+CJPbmb3WoQP9Ce8g6/0xsgoEBm9CBUvc9dFcKzxqo2/ntLlZ0f1TvEoFkqAm1I8HDKKlGMHNjBt2QYbEHez6ns+oom0OnOm1lCr3lIpv2vzYNxX4tVLW4zQp+1Jh1FA/8gQDLPiwcdNQuyitxhFIEpGvZxw7zcaDglUt4aT13O6dMcr4Z9FSQOZGzi8ag/zRm5L/gg+wyEJMxxJJlexkrT9jdn6L68lN1LnEYWJxBL/DzT8w5QIYDCQSJqG3lY7NgPfSXCeUmH0ouNjsLKOYqQSgbTP1Lpdjm6BkjXZk9fXoBua+oeJaCPnuF8rM50lQCsJLlKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH v2 2/3] xen/arm: vgic: free eSPIs using the bitmap index Date: Mon, 10 Aug 2026 21:38:46 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: WA2P291CA0003.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::7) To AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR03MB9746:EE_|GVXPR03MB11092:EE_ X-MS-Office365-Filtering-Correlation-Id: 45e6ca56-31ff-4682-4be0-08def70eaa60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|23010399003|18002099003|22082099003|11063799006|56012099006|6133799003|10067099003; X-Microsoft-Antispam-Message-Info: ypElvmTH0i4qLpafa/XnfNhc3Usilr1pAn27RJImdMSJ8GMjgA+GWl7BCy+U3jK/Vp2eaZ4hcJn+a9Xm5Llr2tHjXLq1UpwzT5+78X6HFeAWN6WSUZfOWT/fosy9tL9QP56bPtynyQQxrrANYzckQsnGW0ZNbMUwn+2GQvExzM8B9WLVeoFCwxkpU6DXMEDpxerzuKNwwxNoZL75ltS9KaVyv8wMlhZd4i/bOIL4KdY9s8Zlk20ruKHCLYjcm96oxVGGsli2CjIOHukKkSVyW7GKFDxCuBbHB3KoXvlfirx0s30qtHLIX0+zzJsVzXyHUV5YRdgrc896Kjcl1eLEmajPAYu7GIjrMlkJeKGMd7U2yOt0qEuWHo4lwpI9okzHc6NTbnCOYz8+Z87Dl6JDbH8kvBAwAZIYYHX5dyiRlkiopMsp3j+Rzrdod+laQH3aFdgXoxyNN74Pzu9kjcAG1ktYjFzMzQFsWo+h26/dMhinvvB4DJQ+SDUHQOskSXWIcgvCffe88qUFI429ud7i7MF/6qyd1VVPCQLU3JvqeKOPEHZ7yOG6yJRxRMpiSazM18S8JeYcNxPabZeLKGTrueazyW6AGx76+tiq0uUCm714gbUIHqY9rd42TmT2NYufem6s1Rbcenw18PuCKi+9izi2Q/W637VF2nWonsk9U5w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB9746.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(6133799003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UBAFgskfUvGkIrThajlleE2H9fnWTdt1G/nKVeMim5h/G+ovpRyARQJddViC?= =?us-ascii?Q?W5cPeVjyBjx/vwOblKlgvk1yVP7wgWTlNBAK562xs5CtWczKBntafvPy0i+p?= =?us-ascii?Q?GWR9rGtyK5N+os3wB524WZXFz5OGgSK/DkF356fYdrKU3qrQY/S36PxjbNrc?= =?us-ascii?Q?yHKEAflp3nYZR0YIQBBvAw5u8+7qk4lB5Hs45K8neV68/kB9Xp7f22dgfkF5?= =?us-ascii?Q?E5ys3MtK8YrTcIqPexM3yT8qgGRZ4V5PNtzZpesjtAsP48yACA4mS5PYfUMF?= =?us-ascii?Q?ytvakTFXbtcuU8vYvGVAlARsoNBtDMRCl7f98kuxIyfB+xhJe6PcwUSSiv+e?= =?us-ascii?Q?zyjglgIDaQWFZ7OtcYTMAHCfIAcPRgkBTfALAVbGXH/t6CIgyVl24LVE3aIQ?= =?us-ascii?Q?pHPAyODG+jS2IFnwlOLvbkCoGGoX2a3qtSju+Gn6yR8foIj8d6SbpZQ0Valx?= =?us-ascii?Q?G0OF7d083jve7LB03rgtGYmmaeKRYuBGHXs+hE0k9b/FAsg/7CRIDrnDuF1G?= =?us-ascii?Q?gx5KIvxSnu2+DJTvQC/qXvp1NqESWhXQf9agJs94jBzC3ndX1X9t5RmFoGNZ?= =?us-ascii?Q?+IJOeoiTkV7n6W023ML39rXYhhoeVW4SYeAfS1fNJdcCoEcAXB+EfjIbeBnG?= =?us-ascii?Q?tqHaO+IjVaWE0Zkq31vLNW3n0WNO3Kd67QOQpgqS7FMvBKtzBC3cAoFhzptJ?= =?us-ascii?Q?p7IfOenkTxvvWfRRUI1D5y41iFH6Caak4Jzvq4Jq9yt5buaeFQQHbGKj0kMh?= =?us-ascii?Q?dbmmEqeSabgZOxr+G9Da802V9dg7IeTu/AsxnU/qWQ28Ny1FRov+l5AWNTg+?= =?us-ascii?Q?5tZmQGsOgHej9zeqOtx6MMdJYoJFqd1Mpp4bIEG96yPs+roxc9R18J++aCJV?= =?us-ascii?Q?Tt0GnEAkFesX78wkh0ucrXij+oTgwzn0x2pHYaZIYH35QBP4LU3VId65CqR4?= =?us-ascii?Q?Y9anxqBFrCe7PbrQ6CDtuXj7O/OoO3jI6elg8kDihgyLk+qrD7QLLWUogYvr?= =?us-ascii?Q?fQpWfn0DgN6txKfdhfKLHswEtls55gIF9dbNbEwpFE2teUVXD4pHRQPHn3+c?= =?us-ascii?Q?/Wa9sSLuV0qcP+FQku4DA3V/7SDhnxPIx8Qc28/AIVsqDfq7lqYCO2ptRGE4?= =?us-ascii?Q?7TbL75uIrgK8LdblPOgG/ZtIUsDXV5z6wFDYFcFwfS194KXKnd/kQB9VX2re?= =?us-ascii?Q?gsw0s3cuXWpwoLkTeBVNP2MHWIhYFgQS6LslvVrkJnBkfVc+4HREpHjwBUhq?= =?us-ascii?Q?cKSiHnbOBmf6EIxPDeMsZuR5zHLPbhGLVOg1v+HHCCxipVsuW8TdgYWp4N4P?= =?us-ascii?Q?z4O/75Tmoy59GX8frO9ksPYsm9uwaJRLSTbskzBS4padX//0vErTtYZ0DsqJ?= =?us-ascii?Q?Wur/+qTAhJHuJVD+d9YDHPxt7GehdHH4U+wdmCXymeIVOThyOBvgZBeZ5Bm7?= =?us-ascii?Q?60aK3WkP92kX0QzmM8U34CaPBaCnBSJbPQhXVU082oHs/8+trTTZFwkBzFmi?= =?us-ascii?Q?ZvemAX3L/GCM3bEF4dEvMS2oBgYLJQrGhsiSsD1E1VJ0VBp1vMc4MflIu/ie?= =?us-ascii?Q?EraCPM1XWNiniPbAIjQe9Fe/KeT9O0ADgXL3gs9Up1Qf/7wPtNopecH0Cf2T?= =?us-ascii?Q?rgdmHTlcpmpwvFogEJ4u3WtMHKt/SM84Cr+slCwCIwTGQMJRE1dPP2uE85jF?= =?us-ascii?Q?do8F58sK/O6HtmQ65s0fzSA7Sb/U4Cja+KQcdTDfNDXiX6/hya7OgOjHZeOf?= =?us-ascii?Q?tnMxoxk5AA=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45e6ca56-31ff-4682-4be0-08def70eaa60 X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB9746.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 18:39:09.4525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nh03eeohrhTeOWSVYDkCxDfTFFFsnccC668bwvh8UmxPXNC5bW+Wb9gROGFqxYC3X0yTku7PRiLo+4IJWuYALQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR03MB11092 X-purgate-ID: tlsNG-16d1c6/1786387151-F440377B-99CEB5B5/0/0 X-purgate-type: clean X-purgate-size: 2611 The allocated_irqs bitmap in the existing vGIC implementation stores eSPI allocation bits immediately after the regular vIRQ bits. vgic_reserve_virq() converts an eSPI INTID to this compressed bitmap index, but vgic_free_virq() used the raw INTID. Freeing INTID 4096 therefore clears bit 4096 instead of the first eSPI bit. This writes beyond allocated_irqs and leaves the intended eSPI bit set. Valid eSPIs reach this path during DOMCTL bind failure cleanup and unbind, and during vPL011 teardown. Add virq_to_idx(), the inverse of idx_to_virq(), and use it when reserving and freeing vIRQs. Validate a vIRQ before clearing its allocation bit. Fixes: bdde400c6e1b ("xen/arm: vgic: add resource management for extended SPIs") Signed-off-by: Mykola Kvach --- Changes in v2: - Call is_espi() without a configuration guard. --- xen/arch/arm/vgic.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index e5aca17dcb..c095866709 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -33,6 +33,14 @@ static inline unsigned int idx_to_virq(struct domain *d, unsigned int idx) return idx; } +static inline unsigned int virq_to_idx(struct domain *d, unsigned int virq) +{ + if ( is_espi(virq) ) + return espi_intid_to_idx(virq) + vgic_num_irqs(d); + + return virq; +} + bool vgic_is_valid_line(struct domain *d, unsigned int virq) { #ifdef CONFIG_GICV3_ESPI @@ -848,19 +856,11 @@ bool vgic_emulate(struct cpu_user_regs *regs, union hsr hsr) bool vgic_reserve_virq(struct domain *d, unsigned int virq) { - unsigned int idx = virq; - if ( !vgic_is_valid_line(d, virq) ) return false; - if ( is_espi(virq) ) - { - unsigned int num_regular_irqs = vgic_num_irqs(d); - - idx = espi_intid_to_idx(virq) + num_regular_irqs; - } - - return !test_and_set_bit(idx, d->arch.vgic.allocated_irqs); + return !test_and_set_bit(virq_to_idx(d, virq), + d->arch.vgic.allocated_irqs); } int vgic_allocate_virq(struct domain *d, bool spi) @@ -897,7 +897,10 @@ int vgic_allocate_virq(struct domain *d, bool spi) void vgic_free_virq(struct domain *d, unsigned int virq) { - clear_bit(virq, d->arch.vgic.allocated_irqs); + if ( !vgic_is_valid_line(d, virq) ) + return; + + clear_bit(virq_to_idx(d, virq), d->arch.vgic.allocated_irqs); } unsigned int vgic_max_vcpus(unsigned int domctl_vgic_version) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:39:19 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 18:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387760.1629014 (Exim 4.92) (envelope-from ) id 1wtUu7-0004ZL-JX; Mon, 10 Aug 2026 18:39:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387760.1629014; Mon, 10 Aug 2026 18:39:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUu7-0004ZE-GA; Mon, 10 Aug 2026 18:39:19 +0000 Received: by outflank-mailman (input) for mailman id 1387760; Mon, 10 Aug 2026 18:39:17 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtUu5-0004Wm-Ay for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:39:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtUu4-009VLW-Ne for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:39:16 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a1ab0-e002-0a2a0a5209dd-0a2a4504df76-26 for ; Mon, 10 Aug 2026 20:39:16 +0200 Received: from [52.101.84.111] (helo=DB3PR0202CU003.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a1ad4-b57f-0a2a45040019-3465546ff7a9-3 for ; Mon, 10 Aug 2026 20:39:16 +0200 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) by GVXPR03MB11092.eurprd03.prod.outlook.com (2603:10a6:150:2a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 18:39:12 +0000 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7]) by AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 18:39:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DkkjgM1zCRqu84KKXeQQrMnc5lhcYnlJ4p3z1131szpuOdKEYi6rkveNK+IlHfSA0hUky+5knXpPgqYVoR292E4YBpcyxyhnb2L8R4zfdvgh2oSKzkN/0XuQ/ir2A/uBXT1h3nDQAMvV0wtOMXAimHssGbQKUPjfMijHho50pYl5zIi7bdFlbRr+OdciNxTuyv4NQwla4FIC6adSJWBtK1gA7QO7ElhfAw6secHtQYMMNpQa+KBZYSQEgWQyFAxzkkt5sN8cza07JxyQ6HU7Iyr1X99fD5jYckPmo8j6d79RkjwOwwsjQj2vfGhRloNn538gdIzDaut6FAOsvPWKww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rDjLrGD/FUY/UDHLWYqh7U+MOkaV3PZOYHp110xkPAI=; b=BpJCzoyNePC0uVUWau9rDGPqsTamiKrVEz5GCFr7hj7irCF3sAc4M0DhGORRK2OElJP4h0LrPaicmLZq2GfFGtXpTO+dAFeQX955eZciAAufl6coL/oiYOA4wfNZmi3kuyQinJGi2D3eZcdoEtb77a/FbrsqjdgXVYtzIfEophgrVDIGk25axuwtCvKRAtGWb2XpToK41woC8ieq/5fl9vsPvUgWfJ4/5ehzrhwWqwYPGc1LRd5RJLo0G6kUxVHpmGp3lRtoUWewEoIPa0XIgtLWormcygeKXMN8gFRdtBqhFopCDyxc1uMWYjW9EctV00Bl/84kdX7FSSJ/v9Xlew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rDjLrGD/FUY/UDHLWYqh7U+MOkaV3PZOYHp110xkPAI=; b=HW+3Ug3RRUhFXjtQp14lc3aASZPPbFsXMhkdvPWZRphZL6sHg4aoSGmqFGz0ek5R4tFLXPcMQpjLfOUah8MBok88SMHaMtGPfVxxRSLdo0eNbXTCaeL7g8W3tdHOB2+4imR6kI+8pPZaVzbEZgJ0E22Hjm1lQAQHGkY+fky3kEAtJjOLIOcDwIQrzn3UrHu3E4hv9qa+SXpZipIBdP1Rf2fGOb+yIAQi0dIJErIMdIsCjBS/6y4xNc8whW1ZLv4n2meEaFS5nJVfT+/AvkKiOUN7LcdEutPt3uzPCEpWJ5h8D4CWvz6gVU4XYUlXiGeTjoNNbATrarIH8UTqW4S7Xw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jens Wiklander Subject: [PATCH v2 3/3] xen/arm: handle irq_set_type() failures Date: Mon, 10 Aug 2026 21:38:47 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: WA2P291CA0003.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::7) To AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR03MB9746:EE_|GVXPR03MB11092:EE_ X-MS-Office365-Filtering-Correlation-Id: 47e88541-b80d-49b4-e333-08def70eabd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|23010399003|18002099003|22082099003|11063799006|56012099006|6133799003|10067099003; X-Microsoft-Antispam-Message-Info: uJMqOoXTb+FbCoY2yiaYePu95xHg/G0UW74CG6WUc2aW7rJuAKw97DeCbap2Zp3GkQK0Wxey1v1o415gRRHs1vshQOSsZy7K1LzdFx8r6GKoV7dEBLDGtiiZEA1g4r3xqbEdcOsMzlB9H1fNdidXC6dnZswPJQWGwDF/pcHr4ISAs9RUuWAUVBXSvENa6i7TwggttRj+ET0sKsWqONhlb2xFR/rkwOj/1GDwvQK3Km6CLpn64SDgYcvbbJpe45SYs/o8K1csG7CEobeCDW/vtCoalZ6WUm8DW61D3G716MaJ4E77lAOzjUgTriG+PiIgn45zSjXWY1wva5fsN2G0XZzkJj3aA3L4GgCkc9C+JELagDRlw6N2r2cNERZSX0qYUrQpjSO8Qm/1EFb04yYeEC2LM3uywDHHX1PBpm6XO2U/1j1QKj+y4TRrYlzw6RK/7TGrv1a4C382BstfTyhl58gz8rglZDuA0hyLsySmT2/EPzCk6wcA2SzG9Fk7wlhUZ6iFmbEsOxYpXaBEG389IJRyyf7hU7McjCfZAY5H8ZsYz/ABil9/C9959vWWQGw34543oje5TxPXl8wXpnO1uCs5FBte+EL4vWDt6L2axi8Vn0SQFyIOxIUSPWxLolDblYqUonJ4vpB8yxmGr7CsxGbxh9VIzW9jOjctb6MPWLI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB9746.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(23010399003)(18002099003)(22082099003)(11063799006)(56012099006)(6133799003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l/FuCPR1KArHyj4uVex0HQRtYlHdgo5hmiefPb3gKIEPc2QS0QW+puYjsSkB?= =?us-ascii?Q?ZfAcwElNDPaW05kTb3TpVFWbFR8BAWGut/1UZPen6SuQPOy46W8ZPLbqLWFb?= =?us-ascii?Q?SncFTf6SdsxpcsqVliPIINfdCrIEMyY955wPdU/84y6U4ohwiNT7VFXQOU+1?= =?us-ascii?Q?sK9YS0KhxiBvoK4ROdet2u3PxyyrNitL9OEAJfVHffqTrI4GHYwPZfiHDJ6g?= =?us-ascii?Q?0aweKGxq988xOdbXWGRDF2ySQkLxavG1h9N7sxKygRW3vUU60OEWcp6M2o7C?= =?us-ascii?Q?JyYoWXb+iWUqj/l02if97He2c2zF7/qRcQphaW8fI/5DWCYXo8zV92OncaSy?= =?us-ascii?Q?qjLh40iwPbwOhPBuD6HtsEt/XL5CtjZ0ac54nstsUL1AsMSKwH5mg/lLwj8x?= =?us-ascii?Q?iJ9pUKgBgJdokHbtLV13CaRmJVzwxBuDAqiDULgNu/Rqel/mPwNKwNNv1VX5?= =?us-ascii?Q?zgw/4ACyZVEUF2JLE/TSVuShVFz3jpINMOJehVkM9OXLlxySjfWF5QtJb9y/?= =?us-ascii?Q?WCLx7tIAQbtSyR6aLugVqSejpq2t4pB9B12SsWfoQ4/WBtEnA+Ja4Y2qH+g9?= =?us-ascii?Q?uhvYdw7V6pGZYinGBq91Br2h5eXNQ30S43fNbwYxAAXYMsFB79oCuq5YxSYy?= =?us-ascii?Q?Mrux61rvSd82V1tdp+1CHkk2YroByItxBfU3bHGOkT8pLsuG2edmw31dxrzl?= =?us-ascii?Q?00Th7WwRcbFYsAUtt6YZsAJMzqiFegjj1Va/Rq5+htgc2RIheJIApwf9o7mI?= =?us-ascii?Q?S7laDTrgaDOLo3ZS/CTaSWJTchReAE8vhiJHmYFlR4GzHuKAIKgXywY4c1Tb?= =?us-ascii?Q?VgWTDxBLJNrhCSPqkOznEf6OAqlBC0qvdAWxKTZ0BBMSP+iGImbazhXgA4Gx?= =?us-ascii?Q?p5Zm7bkzPlERzdRf1qkruFb/RCYlTNGWRwqynSKKEKNRva802mvh3BtCHqRC?= =?us-ascii?Q?xId/nUhJeWXR5L8NDqQA7cWSaXZ4b1+d30C3byAHlu82+6l8RR2pVmp4TvSp?= =?us-ascii?Q?q9c9BXJFPi3GsZhsBlBlPZzd9i7ZHeJBE6DE75nGcMgRunXQW7EPak7cd09P?= =?us-ascii?Q?F/tZXdFzMuUiUHfCrARJbkTm0ugAkYdaSvZbmsQq5OLwOangndfavezcrN7v?= =?us-ascii?Q?mAzzaGH1ABD9wO52/nSkUhvddHWFK2jmouCU5+NCnSeNpInk49+R/g6A8rDN?= =?us-ascii?Q?KShV7qh2b93k+4D6PD78mT0LYsbxTeUaAZCb4D97rdRsVE5eplhGkQRJhm96?= =?us-ascii?Q?K6Tw61+pafnqLs9ubEh9t5ZcepqbGWOWs44VzzTyWkyIrwz2OAdxFbVFJnz8?= =?us-ascii?Q?ktNJPrCYR8kRV2zotFJbYqMN0nEsQEtXLdtA/rWg554EkuefUOMpnP6W9b9F?= =?us-ascii?Q?grxsb/788k7SGgKPmr6YDEf1HQdZyUDQRKIPp7u4cam63Vs9A0ASxQP9+dzQ?= =?us-ascii?Q?rdZCJGzaJyDDD41tHKBh/omb/hv0A3fVrX1lBXb65mVj5jEVgtEXbyYs/ilj?= =?us-ascii?Q?upsfXqfVUylqfhBBvjPqlF0yGNeL4FAQngiVZBYtNGGij8C9/oIsIYVgQPL7?= =?us-ascii?Q?ap/1O7royDgzg/K4aUO4KYHDtAlClhIlzwGG/TI+s2GKVouHp8FcbT1IA+YL?= =?us-ascii?Q?Setjv7t4pwTzzg44k/0nrDWNj7JMj95q9pf++fNMl4YpI/k0p0TcrYzaX3OT?= =?us-ascii?Q?TUpXase6qo3CYC/LipVPUYHCr+nvYpRjQyw9ikQoWYvKsZEG7UYhNPIVPq6F?= =?us-ascii?Q?tej3n00jrQ=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47e88541-b80d-49b4-e333-08def70eabd7 X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB9746.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 18:39:11.9409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cP677HKJHG0aKoTZVTXUorLx2TcQ5bgwgAIZKBZBF5KZeFUk8saS1KugqqeO/mvbcLZP89NaYokt5OgWHFNvQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR03MB11092 X-purgate-ID: tlsNG-ebf023/1786387156-502E4B50-C89FB731/0/0 X-purgate-type: clean X-purgate-size: 7395 Several Arm firmware initialization paths discard irq_set_type()'s return value, violating MISRA C Rule 17.7. If trigger configuration fails, initialization continues with an IRQ that was not configured as requested. Check the return value in the GTDT, MADT, SPCR, and FF-A paths. Store timer INTIDs only after successful trigger configuration, make GTDT parsing failure fatal, and stop UART or notification setup when trigger configuration fails. Signed-off-by: Mykola Kvach --- Changes in v2: - new patch. --- xen/arch/arm/gic-v2.c | 8 ++++++-- xen/arch/arm/gic-v3.c | 8 ++++++-- xen/arch/arm/tee/ffa_notif.c | 11 ++++++++++- xen/arch/arm/time.c | 18 ++++++++++++++---- xen/drivers/char/ns16550.c | 5 ++++- xen/drivers/char/pl011.c | 4 +++- 6 files changed, 43 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 43a379fdda..b8dcbb0bb4 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1157,6 +1157,7 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, const unsigned long end) { static int cpu_base_assigned = 0; + int rc; struct acpi_madt_generic_interrupt *processor = container_of(header, struct acpi_madt_generic_interrupt, header); @@ -1173,9 +1174,12 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, gicv2_info.maintenance_irq = processor->vgic_interrupt; if ( processor->flags & ACPI_MADT_VGIC_IRQ_MODE ) - irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); + rc = irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); else - irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); + rc = irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); + + if ( rc ) + return rc; cpu_base_assigned = 1; } diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index acdac22953..d92d0b9b3c 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1734,6 +1734,7 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, const unsigned long end) { static int cpu_base_assigned = 0; + int rc; struct acpi_madt_generic_interrupt *processor = container_of(header, struct acpi_madt_generic_interrupt, header); @@ -1748,9 +1749,12 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, gicv3_info.maintenance_irq = processor->vgic_interrupt; if ( processor->flags & ACPI_MADT_VGIC_IRQ_MODE ) - irq_set_type(gicv3_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); + rc = irq_set_type(gicv3_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); else - irq_set_type(gicv3_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); + rc = irq_set_type(gicv3_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); + + if ( rc ) + return rc; cpu_base_assigned = 1; } diff --git a/xen/arch/arm/tee/ffa_notif.c b/xen/arch/arm/tee/ffa_notif.c index 186e726412..d08d0a3366 100644 --- a/xen/arch/arm/tee/ffa_notif.c +++ b/xen/arch/arm/tee/ffa_notif.c @@ -407,7 +407,16 @@ void ffa_notif_init(void) irq = resp.a2; notif_sri_irq = irq; if ( irq >= NR_GIC_SGI ) - irq_set_type(irq, IRQ_TYPE_EDGE_RISING); + { + ret = irq_set_type(irq, IRQ_TYPE_EDGE_RISING); + if ( ret ) + { + printk(XENLOG_ERR + "ffa: irq_set_type irq %u failed: error %d\n", + irq, ret); + return; + } + } ret = request_irq(irq, 0, notif_irq_handler, "FF-A notif", NULL); if ( ret ) { diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index 6955b2788f..39b5eabe7c 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -60,20 +60,27 @@ static int __init arch_timer_acpi_init(struct acpi_table_header *header) { u32 irq_type; struct acpi_table_gtdt *gtdt; + int rc; gtdt = container_of(header, struct acpi_table_gtdt, header); /* Initialize all the generic timer IRQ variable from GTDT table */ irq_type = acpi_get_timer_irq_type(gtdt->non_secure_el1_flags); - irq_set_type(gtdt->non_secure_el1_interrupt, irq_type); + rc = irq_set_type(gtdt->non_secure_el1_interrupt, irq_type); + if ( rc ) + return rc; timer_irq[TIMER_PHYS_NONSECURE_PPI] = gtdt->non_secure_el1_interrupt; irq_type = acpi_get_timer_irq_type(gtdt->virtual_timer_flags); - irq_set_type(gtdt->virtual_timer_interrupt, irq_type); + rc = irq_set_type(gtdt->virtual_timer_interrupt, irq_type); + if ( rc ) + return rc; timer_irq[TIMER_VIRT_PPI] = gtdt->virtual_timer_interrupt; irq_type = acpi_get_timer_irq_type(gtdt->non_secure_el2_flags); - irq_set_type(gtdt->non_secure_el2_interrupt, irq_type); + rc = irq_set_type(gtdt->non_secure_el2_interrupt, irq_type); + if ( rc ) + return rc; timer_irq[TIMER_HYP_PPI] = gtdt->non_secure_el2_interrupt; return 0; @@ -81,7 +88,10 @@ static int __init arch_timer_acpi_init(struct acpi_table_header *header) static void __init preinit_acpi_xen_time(void) { - acpi_table_parse(ACPI_SIG_GTDT, arch_timer_acpi_init); + int rc = acpi_table_parse(ACPI_SIG_GTDT, arch_timer_acpi_init); + + if ( rc ) + panic("Timer: Failed to configure interrupts from GTDT: %d\n", rc); } #else static void __init preinit_acpi_xen_time(void) { } diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 120ac09d23..4bfdcfebd7 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1928,6 +1928,7 @@ static int __init ns16550_acpi_uart_init(const void *data) struct acpi_table_header *table; struct acpi_table_spcr *spcr; acpi_status status; + int rc; /* * Same as the DT part. * Only support one UART on ARM which happen to be ns16550_com[0]. @@ -1976,7 +1977,9 @@ static int __init ns16550_acpi_uart_init(const void *data) uart->reg_width = spcr->serial_port.access_width; /* The trigger/polarity information is not available in spcr. */ - irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); + rc = irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); + if ( rc ) + return rc; uart->irq = spcr->interrupt; uart->vuart.base_addr = uart->io_base; diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index a336241033..97c53c11e0 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -363,7 +363,9 @@ static int __init pl011_acpi_uart_init(const void *data) spcr->interface_type == ACPI_DBG2_SBSA_32); /* trigger/polarity information is not available in spcr */ - irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); + res = irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); + if ( res ) + return res; /* TODO - mmio32 proper handling (for now set to true) */ res = pl011_uart_init(spcr->interrupt, spcr->serial_port.address, -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 18:54:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 18:54:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387795.1629023 (Exim 4.92) (envelope-from ) id 1wtV8m-0008Lm-W6; Mon, 10 Aug 2026 18:54:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387795.1629023; Mon, 10 Aug 2026 18:54:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtV8m-0008Lf-Sp; Mon, 10 Aug 2026 18:54:28 +0000 Received: by outflank-mailman (input) for mailman id 1387795; Mon, 10 Aug 2026 18:54:28 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtV8j-0008Jz-QT for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 18:54:28 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtV8i-006mZJ-45; Mon, 10 Aug 2026 20:54:25 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a1e2f-2eae-0a2a0a5409dd-0a2a4504ce24-42 for ; Mon, 10 Aug 2026 20:54:22 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a1e5e-b57f-0a2a45040019-5a9b3222d564-3 for ; Mon, 10 Aug 2026 20:54:22 +0200 Received: from [2001:8b0:10b:5:9f69:702f:982f:3898] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtUc3-0000000HG3k-3AYW; Mon, 10 Aug 2026 18:20:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cwmsDUvt8rJ15tvz82X30tj2Exxw0lajDzdZAkLIrAo=; b=eB4pQRc/oCxq/k9xhP6fE1X/5+ cgCU26qjDrGKMsdjHFbFx8Y05WqwAnQ9IDdjtT/FFNkzLU1iFmsTDvykvNtHt5nivfyCDCuwbBGX5 ru3glCtl65dgFhVpwyB4+LB5CZ8DeCzMrmbnDfivx5Har0wm5brKX039nvd0M65AXty7HLA+wGelj njwFnoI1i3iqlb21T3XV7n6NkiZkE5eggnnUzaji7ktHivc2jgXp4ke3nl3GqkvSeQLivJRUDTtxy 0wwUmMFlbVPF3p5gBYCiSKJOeCn8wXbRTpgTfwYnuKtOr3GFGFQ96XSZaV9/DrWwUVK/EZVGKjfkx s7qeRcTA==; Message-ID: Subject: Re: [PATCH v7 17/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Mon, 10 Aug 2026 19:20:05 +0100 In-Reply-To: References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-18-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-7RnCnZ41sxGpJ6+i13Fq" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-ebf023/1786388062-583C0B50-F1049238/0/0 X-purgate-type: clean X-purgate-size: 10684 --=-7RnCnZ41sxGpJ6+i13Fq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2026-08-10 at 10:47 -0700, Sean Christopherson wrote: > =C2=A0 > > But when the vCPUs merely have a different TSC *offset*, that's not a > > problem. The offset is applied to that vCPU's kvmclock->tsc_timestamp > > field, and it all comes out in the wash. >=20 > It's not though?=C2=A0 The value stored in kvmclock->tsc_timestamp is per= -VM, not > per-vCPU, when using the master clock.=C2=A0 It's a little easier to see = once the > master clock TSC isn't shoved into host_tsc: >=20 > do { > seq =3D read_seqcount_begin(&ka->pvclock_sc); > use_master_clock =3D ka->use_master_clock; > if (!use_master_clock) > continue; >=20 > if (!kvm_get_time_and_clockread(&kernel_ns, &host_tsc)) { > use_master_clock =3D false; > continue; > } >=20 > master_tsc =3D ka->master_cycle_now; > master_ns =3D ka->master_kernel_ns; > } while (read_seqcount_retry(&ka->pvclock_sc, seq)); >=20 > ... >=20 > if (use_master_clock) { > hv_clock.tsc_timestamp =3D kvm_read_l1_tsc(v, master_tsc); > hv_clock.system_time =3D master_ns + v->kvm->arch.kvmclock_offset; > } else { > hv_clock.tsc_timestamp =3D tsc_timestamp; > hv_clock.system_time =3D kernel_ns + v->kvm->arch.kvmclock_offset; > } Meh. I shall have to build a better test case for that one. Thanks. > To allow different offsets, KVM would need to track a per-vCPU offset to = the > master clock and apply that in kvm_guest_time_update() (and maybe other p= laces?). > Which is doable, but it's not clear to me why we'd want to support that (= though > I haven't fully processed the back half ot his series, so it's very possi= ble I'm > missing something obvious). Because I want to reduce the number of cases where we have to fall back to non-masterclock mode. Especially the ones which are driven by *guests* rather than weird choices on the VMM's part. --=-7RnCnZ41sxGpJ6+i13Fq Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MTAxODIwMDVaMC8GCSqGSIb3DQEJBDEiBCDNNAvUs4bOWURrMm2gI30pevwjgws9 iGSh4bXQkoHAXzCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIANkNVVbaDFxCGWy2OB065QXS3lk9J2cw936gZgSo0+U/JcyPd+tiB sX4N+CaocB9IWyKVXVo5SuE3ayvUFqEURzF1YyJwLO0SNyDaxfZkAix6g70Mm3O3oXXuc1+h477p XQW1NokP1IfBDFPREuPsHblsJCuQQ6FXbYRWSo/FETBNQSlfFrLsvTWWGFtrc0YfuX0vVDCebGH3 7KFDcSx+xwEQ+ZefIPJUTKJ0BEHMd1JQwCbUSYXcIQ6rrzDa+X1OKgcalXfRlC+HXcqrTtEurfjn VDQMkL0+olbXA9aPBk11Y8EYZ+OMi8WHZLDOdXJmx6oQ0r326XVswAeNuQgZwJxagyA+7XaZ39c8 YrJQLhTGmUraPUOWZJzcWop0aGycS0bSZMq716yjU2Hl3AycP1omssaTWzWzN7NeOW4aI0hdRfEg Ow+R3Fgo6sWwDkZgSTM0RR7CzrI189q6GLpFPgylNcDUn9LmEputc8MmGB2I/nzsX/pDjQj4lxmS aA2ybYxgiRcYhFohjVKHB2i+581+g/U1BFP612t4qaHHqmDlJR/JvkS4uOrC6j89m5TfGyhgch0r VAgeu6HeDeIsGafcUi+QCpJNLMZDoeGuLDIf6VapDqxOz3wFPdnGsTOiu829Hc4uABxuEqINWXdb WaTyt81hdhO+LXuL6aNMz+4AAAAAAAA= --=-7RnCnZ41sxGpJ6+i13Fq-- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 19:42:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 19:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387809.1629032 (Exim 4.92) (envelope-from ) id 1wtVso-0007so-Bu; Mon, 10 Aug 2026 19:42:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387809.1629032; Mon, 10 Aug 2026 19:42:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtVso-0007sh-8z; Mon, 10 Aug 2026 19:42:02 +0000 Received: by outflank-mailman (input) for mailman id 1387809; Mon, 10 Aug 2026 19:42:01 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtVsn-0007sb-Jh for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 19:42:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtVsm-000bnd-EF for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 21:42:00 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a2982-8faa-0a2a0a5109dd-0a2a45049c04-6 for ; Mon, 10 Aug 2026 21:42:00 +0200 Received: from [52.101.70.87] (helo=AS8PR04CU009.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a2988-b57f-0a2a45040019-3465465768d9-3 for ; Mon, 10 Aug 2026 21:42:00 +0200 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) by AS8PR03MB6901.eurprd03.prod.outlook.com (2603:10a6:20b:29e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 19:41:55 +0000 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7]) by AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 19:41:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DyRoJ0slfhLhBnD/C01HVwB1Amckmscdtnld0bBqdZUPM4Jd/NOsk6Mx0/mDCe3OaYtxwzYVM4oZ9wK4sEInPdcqLNyv0Grt2ixgF52mCW2Kfcen1ZMXNLqStoIsCvC6vMhldIsu6OAqKnhXlpHHTqlFx+7KJ1Pg4N5/EPxyL65dTBnirMPFglCf6j0wWiTGCif1RAQgbjbL0sf+d2THxCSqkxPrflXOMv2Fyc6adR5NynZ60pYKn2yNKcNhmkvxscLXiRhnmYH2sHVB03wjatg5cif2IszxfA8tU5ghma57QonxSPeHOTOaNdhlhwlehYy2eIWLRDKBNjdTFcAJxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LP5CLyeqsdAsHC0O/sJbyotX1Vuz1Ex1qdpiNH22STg=; b=Y+YbO3f/VE15piHY6niaa4TTfTNdGvOInKLunk9Uj8mmkjYTIrub2o5U693SY/pLoj4S3pp9sIjlV48n1a/qP0WFLM7/OkA+YbSzvqk/4P/7I2ITkRZgZEA5wqF3FfM2Sd+Rlt78HJRHEwuV2HZhmMNMcKPnv+ftpeFTW7gxALEHGFhrgZc+AY+lZxBgSxqayZW9mOf0FCFrB8G7cp9hp61vARd6n6woNDNGkVg78UwcJ5oWtOQ/IDH0Zg+89I9tz6wQF5c1y70CVqNM0N8So7JCs/23LAWJUjFZVTBnv2kJXNM696a9mMflAta1hK1UU3YpkyqkYIfNCyPOCPWNRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LP5CLyeqsdAsHC0O/sJbyotX1Vuz1Ex1qdpiNH22STg=; b=Zj1FrnnlqpW+C51VCWKJqpdFY3PrLNsi6DFRur7EPRh8O9+F8nc8kj9GjzbyW2iiiTN9cUC61KdwZF6PAnp0uQLANuxKR9d1OCbUfsfWPbdBVCcaEsTDHp8CFIZ0brU4FLTL0pX9qbBQObH78U2mL6wIWIGEFSoJJ/Naj0ezp8w5UZF6vSSmJi6xcXFg41H/fTZE+CW+vAEH6D/HXxWKbJDHKrDher6Nq+zsufw6C5lmEUMnzLDX4iqc3Im9uGlyDAtiKvpJ1mpOcxSKISNMfFx35Eb0eO29Al5Ra2UEJGvhSLUCM2DNnjCOChmeDu4saaSJaeD5D5x3XPGfy0bOcQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH v2] xen/arm: propagate secondary GIC initialization failures Date: Mon, 10 Aug 2026 22:41:46 +0300 Message-ID: <58b886c992ea72210bb2f32afc392b458efe02f2.1786389451.git.mykola_kvach@epam.com> X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: WA0P291CA0016.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::28) To AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR03MB9746:EE_|AS8PR03MB6901:EE_ X-MS-Office365-Filtering-Correlation-Id: d2149e82-dcc5-4920-b7b8-08def7176ef9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|6133799003|56012099006|10067099003|11063799006|18002099003; X-Microsoft-Antispam-Message-Info: XDEoBbYfVDE92b4IKB+Y6ZvhzR5ZFgDwzgQ31TFj+4sP95qhZ02ngzxbGwgAhTMDdDYOw2liFHRlicM++P1xkFRcBIukMhsjiiOvBIGjX19RqA+bwnGEVHfRR21ksFFgPsRfCb0ton+1W6fIpNz4xZ90zIPe3NKs6YNaFTxNefddbL0mZZaLVxQRO/fOtcJxpjF6twTMEG9m7Zpg4oLOkyB8Lt70oFyoYIo9b7rEF0SCHMS1hpkE2igy9xmKnLmv+3HnsVQa6yfFEVIA+xTvKIeCr0/BipA0epgCx6NvfVpT+2jVgQZk5zt4v2bb4NvelL5MhrqBoHcoYnek/ol0Ja17vOEQe6CHQqq5WEm5WKUufp0U/bXBwe2q6NI/9hpJAB6qYomx1uHFnZaS/lawb8jSHooLdF7NKyNOVc0fRftW5meFaS6GY2ETRZt1GDmXX4WTN4AxrqTT9HWUDuKcCeH0SkMSFWZPS/+I3fD4vyi2n7Q8AKAUpEfIlW5gzM1Bq0YwXUgzd2y7xV4YUmnNzFM39tRFsU72USHZv5ZCDxC2F1jcIpK6rpo5u9yvcCEtndgkSCYhcYnhB3MeOrMPhEv2q4ty6hqe/jaty4GXjk4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB9746.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(6133799003)(56012099006)(10067099003)(11063799006)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S4/HplGdZu1sGamQb3PJAAuKXHwm7XuPrJb8miFEejizCZzZjpejMp4D2x8g?= =?us-ascii?Q?V9zgAx9tD+ZuoGSTNdepK4P/nyeQvrCoSW/beD/OuUd1Y5BzsJfoYfCd2Cgg?= =?us-ascii?Q?xbl+5vaE4SE2UmFZp4E6folsQnPWozQ4ZK3fx9eSbtbeHqEJW37j3k0ozTMQ?= =?us-ascii?Q?5851IIkKZciWeOAPG9Js6/rjTcs0s7xchX13dAyI+ZsMalbOVxtq2FHextdM?= =?us-ascii?Q?F3jmIdt3yaCSNJ3LrrrxSx7rcN4y41AsZYd7ErvVpA25e1ViknLHKHprGoQO?= =?us-ascii?Q?e39igN6uzPeF5UYE/0jUleCP1OOYByTB8hL2vKxMnspxJ339QjPiiZA3cZYZ?= =?us-ascii?Q?zbIPmBuB3KtF38KtAjVSHKtjm6C8r96OL/xL8DPvpTgFwxNP40yi0saXwIf/?= =?us-ascii?Q?KVdCFrRzYsRh9omp2O7mXNyk7GZWOY8HEj+q5k9yhuv1oPLAS6B+exVs4mw/?= =?us-ascii?Q?Pt0/Su9fkwIZbK3gtOOHWLvCvKQlS+VgpCU6pton1rDKwhvYm89lZWHz7O48?= =?us-ascii?Q?23EGf2jVepojj6R5gzgvXD+K0npkb/vkr+pgPp3T/zBqjSkCs6By6D2gHE2R?= =?us-ascii?Q?cdqDdqYtq97/fefuI9DAxjH46uG7VLXjov3uuUeVOCLHq359ityJNfU5GipC?= =?us-ascii?Q?AL0MknKs3Bbm0ot+hDhtU7F3ePXuzMXdKSwMzPGQ716MIq9iJVZjWQabscSP?= =?us-ascii?Q?uTiStnw8B4dpWgbAMOVZT16PPqBlvnvYvtVsc+CdQVRalB7LIRDWZpPX/rmo?= =?us-ascii?Q?uKXCPnELeKzYzVhJH/9WKrs8rCoqrPXdqoQSA3a+KYAGSohxTTjGr06IIiHZ?= =?us-ascii?Q?/l66EG0Kzz4mRBymZ6+dgyBihCx/aV1pRqWw4hy8066gtvoW6gw6Js8oGTDy?= =?us-ascii?Q?Ao/Ry39K2OZsCxAuTDulC4F/bbyLOx5Q+p766z8B4mPRgnQZM+TWEPPrUKRz?= =?us-ascii?Q?Yk6xvrjFfPpmZRxRGXlhVqsfBGceV5hO5kESlv7VgofADtypR5O2bH7SUTUC?= =?us-ascii?Q?ZO66wZueEFMA5T89tKBuSLcKBp41pMfDKQw2mWVS9ICG2lSiqiJ68ICmshng?= =?us-ascii?Q?8WIWK9BypMQp8qTPef4hTKVPJCzcfP4O/UGSMW39DQUfdc/6fHCTEGjZl+3Z?= =?us-ascii?Q?B/sYoPQ8DpLaQ98nHusUt7aM1ws/Jgfsp6HlFI4iqHmdjuvMH5vwdm2XH5hi?= =?us-ascii?Q?oc48QSNwisPKeEmsjDP8g0UMSkz1m4HAU0nZExP0g5CuzHMi2acWh9MU+9Zc?= =?us-ascii?Q?OsyuDumJPKoPtGik/uRZAGd8IIQXALRaAuRAJbKbmf0ecKuJn69vxKoExR89?= =?us-ascii?Q?dzMnlNlLKfg1ixaghzPvN+fhgLfm0TdTE+pIIzMuus09iHs97l+HbN9S6olu?= =?us-ascii?Q?0m97tRxpmQUFxE8la5beiVQTUi3BpSVc9gYKRuQbdD/2b3HTqT/eFOmzCmuH?= =?us-ascii?Q?GjZUOTlJYE8EubawQp1wiY0YcTnVM75zfUaLQp1QaqpaJO3q8brsndneNT3r?= =?us-ascii?Q?1xPgpp8Z5IqStbwyAgOrB0sgZ3+10pOUU3g3RQ4SbzPReRXt1GEK4ZDGuRN2?= =?us-ascii?Q?QyRnlun2bhC3fwUF3nVP3YxWhZvBV0MrwMKVEpMLV3IERcI0XzNXe3pebCpC?= =?us-ascii?Q?L/cfu9xAKKSF2KMtB2vX1WlEkVTpeHOa6olzbrxiQneTB1DpZFXpRp5vBkgV?= =?us-ascii?Q?FEDDpqaBqk8RQFeO1EURMdx72NXFczOktvDz7P/mq0llAsyCb4ZGIQxlIfBf?= =?us-ascii?Q?PC3eME5o9A=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2149e82-dcc5-4920-b7b8-08def7176ef9 X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB9746.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 19:41:55.4162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J3yhIAX6o/AGyXFQALfeUEiqxSQEQ6oCLWk/ScN11Di0zr1N2IY9I889xEi1UEYPTBlDBbTXXeOjWZ1qeB8HlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6901 X-purgate-ID: tlsNG-ebf023/1786390920-C24CBB50-6216521B/0/0 X-purgate-type: clean X-purgate-size: 3453 The GICv3 secondary_init() callback can fail while discovering or waking a Redistributor, enabling LPIs, or setting up an ITS collection. gic_init_secondary_cpu() currently discards that status. start_secondary() then marks the CPU online even though its per-CPU GIC interface may be unusable. Return the callback status through the common GIC layer. Have start_secondary() report the failure and stop the affected CPU before it updates system features or is added to cpu_online_map. Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3") Signed-off-by: Mykola Kvach --- Changes in v2: - Move secondary GIC initialization before updating system features. - Use smp_processor_id() in the failure message. - Target master instead of the 4.22 release. v1: https://patchew.org/Xen/9fd0d0eacf061cc2a32f440e3438c084fa9ca79c.1783678619.git.mykola._5Fkvach@epam.com/ --- xen/arch/arm/gic.c | 10 ++++++++-- xen/arch/arm/include/asm/gic.h | 2 +- xen/arch/arm/smpboot.c | 11 +++++++++-- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index ee75258fc3..078049e741 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -282,11 +282,17 @@ void smp_send_state_dump(unsigned int cpu) } /* Set up the per-CPU parts of the GIC for a secondary CPU */ -void gic_init_secondary_cpu(void) +int gic_init_secondary_cpu(void) { - gic_hw_ops->secondary_init(); + int rc = gic_hw_ops->secondary_init(); + + if ( rc ) + return rc; + /* Clear LR mask for secondary cpus */ clear_cpu_lr_mask(); + + return 0; } /* Shut down the per-CPU GIC interface */ diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h index ff22dea40d..ee2c26adb4 100644 --- a/xen/arch/arm/include/asm/gic.h +++ b/xen/arch/arm/include/asm/gic.h @@ -291,7 +291,7 @@ extern void gic_preinit(void); /* Bring up the interrupt controller, and report # cpus attached */ extern void gic_init(void); /* Bring up a secondary CPU's per-CPU GIC interface */ -extern void gic_init_secondary_cpu(void); +extern int gic_init_secondary_cpu(void); /* Take down a CPU's per-CPU GIC interface */ extern void gic_disable_cpu(void); /* setup the gic virtual interface for a guest */ diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index ba5fd2dd52..1806c47a08 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -319,6 +319,7 @@ smp_prepare_cpus(void) void asmlinkage noreturn start_secondary(void) { unsigned int cpuid = init_data.cpuid; + int rc; memset(get_cpu_info(), 0, sizeof (struct cpu_info)); @@ -366,6 +367,14 @@ void asmlinkage noreturn start_secondary(void) stop_cpu(); } + rc = gic_init_secondary_cpu(); + if ( rc ) + { + printk(XENLOG_ERR "CPU%u: Failed to initialize the GIC: %d\n", + smp_processor_id(), rc); + stop_cpu(); + } + /* * system features must be updated only if we do not stop the core or * we might disable features due to a non used core (for example when @@ -373,8 +382,6 @@ void asmlinkage noreturn start_secondary(void) */ update_system_features(¤t_cpu_data); - gic_init_secondary_cpu(); - set_current(idle_vcpu[cpuid]); /* Run local notifiers */ -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:03:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:03:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387819.1629040 (Exim 4.92) (envelope-from ) id 1wtWDF-0003Qt-Vm; Mon, 10 Aug 2026 20:03:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387819.1629040; Mon, 10 Aug 2026 20:03:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWDF-0003Qm-T9; Mon, 10 Aug 2026 20:03:09 +0000 Received: by outflank-mailman (input) for mailman id 1387819; Mon, 10 Aug 2026 20:03:08 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWDE-0003Qg-Ag for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:03:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtWDD-000dtK-7Q for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:03:07 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a2e67-2eae-0a2a0a5409dd-0a2a4506a89c-48 for ; Mon, 10 Aug 2026 22:03:07 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a2e79-195a-0a2a45060019-ac6904fe8b2a-3 for ; Mon, 10 Aug 2026 22:03:06 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1DD11600AD; Mon, 10 Aug 2026 20:03:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4920C1F000E9; Mon, 10 Aug 2026 20:03:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786392184; bh=TsswkiVvDPxgcSHZ6yjKKlKm7CgWPEsFg9F0slygfJ8=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=lhjkEgVxoW2Qd2naeLDMVfkx7Dnk7Bo7N9Zy1pRcrJi0+YG3uo7Tj2ZZJ5NuJzZEP xCxqQCv7kNqUGUsi7h7mj5ciZ0k6Zs3fVelCiadtWsI0lBJD8EUhFNnWRNwBSuy84b 05e2sNDMveWm8LJupQpJ90Vdvr5Yuxn+hqtnW4cV2xTtuz1uNzT6XS4IQHg6lRN37T vuVpJzF0G46LzxG20mh3+P1LcsUyDvOSrxepS8cOzN9sLGyGYNEHMQ9Bt3BJoijkc7 7+Q0Y/MVuabkrIaEi4N1EkOad2rSBSKgXZrzt829sDW0wJU69PFI8PTozn/gGCwep/ HUElcwCpOoq5A== Date: Mon, 10 Aug 2026 13:03:02 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 1/7] xen/console: do not use XENCONS_RING_IDX in console_init_ring() In-Reply-To: <20260728065049.1318143-2-dmukhin@ford.com> Message-ID: References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-2-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-16d1c6/1786392186-F520877B-78F43C6A/0/0 X-purgate-type: clean X-purgate-size: 1623 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > Replace XENCONS_RING_IDX with unsigned int for the console ring indices, > as the console ring is not a Xen console (XENCONS) ring. > > Suggested-by: Andrew Cooper > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini > --- > Changes since v7: > - new patch > --- > xen/drivers/char/console.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index ea4e3ff34178..37fdda93a4c1 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -463,7 +463,7 @@ static void cf_check conring_dump_keyhandler(unsigned char key) > void __init console_init_ring(void) > { > char *ring; > - XENCONS_RING_IDX done, size, n; > + unsigned int done, size, n; > unsigned int order, memflags; > unsigned long flags; > > @@ -484,8 +484,8 @@ void __init console_init_ring(void) > size = conringp - conringc; > for ( done = 0; done < size; done += n ) > { > - XENCONS_RING_IDX src = (conringc + done) & (conring_size - 1); > - XENCONS_RING_IDX dst = (conringc + done) & (opt_conring_size - 1); > + unsigned int src = (conringc + done) & (conring_size - 1); > + unsigned int dst = (conringc + done) & (opt_conring_size - 1); > > n = min(opt_conring_size - dst, conring_size - src); > n = min(size - done, n); > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:05:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:05:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387827.1629049 (Exim 4.92) (envelope-from ) id 1wtWFD-00042C-CY; Mon, 10 Aug 2026 20:05:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387827.1629049; Mon, 10 Aug 2026 20:05:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWFD-000425-9y; Mon, 10 Aug 2026 20:05:11 +0000 Received: by outflank-mailman (input) for mailman id 1387827; Mon, 10 Aug 2026 20:05:09 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWFB-00041v-GP for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:05:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtWFA-00FQ90-HW for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:05:08 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a2ef2-bab6-0a2a0a5309dd-0a2a4502e08a-6 for ; Mon, 10 Aug 2026 22:05:08 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a2ef2-6ca4-0a2a45020019-aceafc1fa41c-3 for ; Mon, 10 Aug 2026 22:05:08 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 2716C4359C; Mon, 10 Aug 2026 20:05:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59B371F000E9; Mon, 10 Aug 2026 20:05:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786392306; bh=gPnvIhkRdHJGclEh1u0eMnzRQFbglbdwmyBABLRGU7s=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=Ey8QtfK6dSAyGrkb0bImOKnm+SsjeqDG/E7sd+lC0Nq0xabrz/G7oxO+4SH7ZKqJZ b/aXjTNYHO2spAziyjTvCzqr6xKLnvO2XqAK7QxHwhQw8N0UfTxtJr9ud+/Hu4jDxy JZqU22qobir96gZDtFajaHmVgKLJRPkxNXbV+As7t+q9sCHM9/SKf3cIY8pbDUDoDB Z+H4/KC3AEN0HWebMl347Nmdw1vsJj2ufFqXvPcAscJTq+1mwGsEYedotXjqqaVlAN IH4as/xrLy/pg1W9+a6BZH0g8UKUxNW47pFGRIbOsy6PSZSCDOniC/7+M3XEhxrpGY iZNtJHONTj8HA== Date: Mon, 10 Aug 2026 13:05:03 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 2/7] xen/console: use 'unsigned int' in contring_{flush,puts}() In-Reply-To: <20260728065049.1318143-3-dmukhin@ford.com> Message-ID: References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-720697/1786392308-660A82AC-B355065F/0/0 X-purgate-type: clean X-purgate-size: 1348 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > contring_puts() and conring_flush() still use 'uint32_t' to access > indices. > > Switch to 'unsigned int' to as required by CODING_STYLE. > > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini > --- > Changes since v7: > - new patch > --- > xen/drivers/char/console.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index 37fdda93a4c1..40355c1d14d6 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -375,7 +375,7 @@ static void conring_puts(const char *str, size_t len) > long read_console_ring(struct xen_sysctl_readconsole *op) > { > XEN_GUEST_HANDLE_PARAM(char) str; > - uint32_t idx, len, max, sofar, c, p; > + unsigned int idx, len, max, sofar, c, p; > > str = guest_handle_cast(op->buffer, char), > max = op->count; > @@ -421,7 +421,7 @@ long read_console_ring(struct xen_sysctl_readconsole *op) > */ > static int conring_flush(unsigned int flags) > { > - uint32_t idx, len, sofar, c; > + unsigned int idx, len, sofar, c; > unsigned int order; > char *buf; > > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:19:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387836.1629059 (Exim 4.92) (envelope-from ) id 1wtWTF-0006AN-IV; Mon, 10 Aug 2026 20:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387836.1629059; Mon, 10 Aug 2026 20:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWTF-0006AG-Fo; Mon, 10 Aug 2026 20:19:41 +0000 Received: by outflank-mailman (input) for mailman id 1387836; Mon, 10 Aug 2026 20:19:39 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWTD-0006AA-Fi for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:19:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtWTC-009fhM-CK for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:19:38 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a325a-8faa-0a2a0a5109dd-0a2a4503bbc4-0 for ; Mon, 10 Aug 2026 22:19:38 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a3259-fae8-0a2a45030019-ac6904fe8354-3 for ; Mon, 10 Aug 2026 22:19:38 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 71016600AD; Mon, 10 Aug 2026 20:19:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8558F1F000E9; Mon, 10 Aug 2026 20:19:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786393176; bh=EwYj3j/RNOT5w84VixrvYZJ6FaxcWeo4bmm2TSRUaeY=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=oj19ParByyAD4WD3xnzZWFAzjhcSyUXXhqsbH5aMgKr/6XO4IkZjuYxYpiqfRbAw4 U5W6QncYdRiQ9RT4PatuhMKBtc2zyyeo/SLieBauiOUaH3mR2JAwN/94m6m8VjnWtN vTkzt3TbWiz+w0mkMomtVi7kiJfN1V45yEVOwT7SGiJxXzNDbk/+btm9nEhRp/42pN 9lMvdt0eeWA5OTaqv/n7p6ecUuH5mrO+M8vTyFJF31lVaZr8SpHSK2v1Nke2Uu5PtT Lq28kOnO5KwWr2v66tqrUOl2WwKq/bjltk54qEUvh7ylTie3t8Wv5f03wUqiYI2VYJ E1jZ9WtOY9N9Q== Date: Mon, 10 Aug 2026 13:19:32 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 3/7] xen/console: switch conring runtime allocation to xvmalloc In-Reply-To: <20260728065049.1318143-4-dmukhin@ford.com> Message-ID: <59a85064-35d9-c3f5-c056-6c05677fc27a@kernel.org> References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-4-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-33051d/1786393178-768FA4E9-58A5BD5C/0/0 X-purgate-type: clean X-purgate-size: 3554 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > The console ring only needs to be virtually contiguous; it does not need > a naturally aligned or physically contiguous allocation. Replace the > runtime xenheap allocation in console_init_ring() with an xvmalloc-backed > buffer. > > Also clamp the user-configured ring size to the supported range and emit > warning when the requested size is adjusted. > > Drop full stops in all diagnostic messages in console_init_ring() to align > code with the common code pattern. > > Suggested-by: Andrew Cooper > Signed-off-by: Denis Mukhin There is another alloc_xenheap_pages in the same file, in conring_flush. It would probably need to be changed as well. > --- > Changes since v7: > - Jan's feedback from > https://lore.kernel.org/xen-devel/0fefa50c-46aa-4ede-a8e2-8c2c619bc2ab@suse.com/ > --- > xen/drivers/char/console.c | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index 40355c1d14d6..09282a7a4f8e 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > > #ifdef CONFIG_X86 > #include > @@ -464,20 +465,30 @@ void __init console_init_ring(void) > { > char *ring; > unsigned int done, size, n; > - unsigned int order, memflags; > unsigned long flags; > > if ( !opt_conring_size ) > return; > > - order = get_order_from_bytes(max(opt_conring_size, conring_size)); > - memflags = MEMF_bits(crashinfo_maxaddr_bits); The original code had MEMF_bits(crashinfo_maxaddr_bits). crashinfo_maxaddr_bits is 64-bit by default but can be changed via command line options. Now, the memflags is going away and there is no way to bring it back because xvmalloc_array doesn't take memflags as a parameter. Andrew, Jan, is that OK? > - while ( (ring = alloc_xenheap_pages(order, memflags)) == NULL ) > + if ( opt_conring_size < GB(2) ) > { > - BUG_ON(order == 0); > - order--; > + unsigned int order = get_order_from_bytes(max(opt_conring_size, > + conring_size)); > + > + opt_conring_size = PAGE_SIZE << order; > + } > + else > + { > + printk(XENLOG_WARNING > + "Limiting user-configured console ring size to 2 GiB\n"); > + opt_conring_size = GB(2); > + } > + > + while ( (ring = xvmalloc_array(char, opt_conring_size)) == NULL ) It looks like that if opt_conring_size is zero, then xvmalloc_array would return ZERO_BLOCK_PTR which is != NULL. We need to have a different check here for that condition > + { > + BUG_ON(opt_conring_size == 0); > + opt_conring_size >>= 1; > } > - opt_conring_size = PAGE_SIZE << order; > > nrspin_lock_irqsave(&console_lock, flags); > > @@ -498,7 +509,7 @@ void __init console_init_ring(void) > conring_size = opt_conring_size; > nrspin_unlock_irqrestore(&console_lock, flags); > > - printk("Allocated console ring of %u KiB.\n", opt_conring_size >> 10); > + printk("Allocated console ring of %u KiB\n", opt_conring_size >> 10); > } > > /* > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:22:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387843.1629069 (Exim 4.92) (envelope-from ) id 1wtWVa-0007eA-V1; Mon, 10 Aug 2026 20:22:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387843.1629069; Mon, 10 Aug 2026 20:22:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWVa-0007e3-RB; Mon, 10 Aug 2026 20:22:06 +0000 Received: by outflank-mailman (input) for mailman id 1387843; Mon, 10 Aug 2026 20:22:06 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWVa-0007dv-8M for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:22:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtWVZ-00FSC8-Cp for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:22:05 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a32c4-e002-0a2a0a5209dd-0a2a450c8e64-36 for ; Mon, 10 Aug 2026 22:22:05 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a32eb-f479-0a2a450c0019-aceafc1febde-3 for ; Mon, 10 Aug 2026 22:22:04 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E5C3241525; Mon, 10 Aug 2026 20:22:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EFC51F000E9; Mon, 10 Aug 2026 20:22:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786393322; bh=TLEf/DOe2uG4L9xiUXANB+Tqddoo5pXA7QKWB02G6Tk=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=lZ0ldktqSfXjFLQ/ohcHyrfS4H5nKI6fWUiwzDUPXsKhQ7NNpEqwPpqwgfALRfTxU Q0KfYqidIN7+CNyn55JMHxI1AwOGWcXgL2xFoQfFHiCSEMTjGqKfFADjFXFUnHVXIb oYsYIOp+epcZABd06xYVUoJfxwpG7cIgutnZerqdVo081uUJJv1qbR9dWdsz31xnFo F/gCZBg5RaD9Zjr76j5B2PBQoDII324WUuJpNTkVTD2jyYUzISQkOpU14aCte68y1l KcblV5RXQqmaO5h355P8iMcSFWsqGMxOuEvV/51h1jc6LLrbThbo2tbaW0MoODD4NT ZAoTk+1BBahpg== Date: Mon, 10 Aug 2026 13:22:00 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 4/7] xen/serial: switch txbuf runtime allocation to xvmalloc In-Reply-To: <20260728065049.1318143-5-dmukhin@ford.com> Message-ID: References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-5-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-d25034/1786393325-768DDA5B-1F6D54E3/0/0 X-purgate-type: clean X-purgate-size: 1316 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > Switch 'txbuf' allocation to xvmalloc_array() since there is no > hard requirement to have buffer physically contiguous. > > Suggested-by: Jan Beulich > Signed-off-by: Denis Mukhin Reviewed-by: Stefano Stabellini > --- > Changes since v7: > - new patch > --- > xen/drivers/char/serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c > index e3c356408987..cf0abf1893e5 100644 > --- a/xen/drivers/char/serial.c > +++ b/xen/drivers/char/serial.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > > #include > > @@ -524,8 +525,7 @@ void __init serial_async_transmit(struct serial_port *port) > serial_txbufsz = PAGE_SIZE; > while ( serial_txbufsz & (serial_txbufsz - 1) ) > serial_txbufsz &= serial_txbufsz - 1; > - port->txbuf = alloc_xenheap_pages( > - get_order_from_bytes(serial_txbufsz), 0); > + port->txbuf = xvmalloc_array(char, serial_txbufsz); > } > > /* > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:25:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:25:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387851.1629078 (Exim 4.92) (envelope-from ) id 1wtWYU-0008BI-CZ; Mon, 10 Aug 2026 20:25:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387851.1629078; Mon, 10 Aug 2026 20:25:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWYU-0008BA-7x; Mon, 10 Aug 2026 20:25:06 +0000 Received: by outflank-mailman (input) for mailman id 1387851; Mon, 10 Aug 2026 20:25:05 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWYT-0008B2-Ef for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:25:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtWYS-008oBz-Nt for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:25:04 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a338b-e002-0a2a0a5209dd-0a2a450ab88a-48 for ; Mon, 10 Aug 2026 22:25:04 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a339f-f2d2-0a2a450a0019-ac6904fec464-3 for ; Mon, 10 Aug 2026 22:25:04 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 0C188600C8; Mon, 10 Aug 2026 20:25:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1170A1F00A3A; Mon, 10 Aug 2026 20:25:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786393502; bh=gxVI8+t6FDLO0exgPZ+hQfCrbo7kQS0z1o3LAYRyTyY=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=eHQOo6aIOJxHktTDbJpmx0VK457JDJz76LBHm3iQKr6i0JBDyWkHpuAKYDxPrTCoN wAqN8R04g1Ga2xQa/J32c8StfxaXt+eJSNqks1dbQrTtTd0Zci8kwoE8CJXspeZoOj 64hxbvpLdmWtz76CnrKq+2Ig7GA3m34sv+NMp4d1jk4Vx+BMv6v2j+hLKwSgL5IIyh 9uYmpnt7VKa0AMlvDeSYthA71IQiZfHQ6T7IQsOWtc352dYIMjuQtsyAfUuLfBlvlR c8inPZwgxYMsP+jwaUPdEzlykqoj9q0wYVaeJU3j29xL5MIA2sOB8RX11hDHRbe9ld lbwyjvXLEgIlA== Date: Mon, 10 Aug 2026 13:24:59 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 5/7] xen/console: use memcpy() in conring_puts() In-Reply-To: <20260728065049.1318143-6-dmukhin@ford.com> Message-ID: <8b114d89-e026-686c-167c-6ebe1006be4c@kernel.org> References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-6-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-4011c0/1786393504-5A9D9CFC-38BA3D9D/0/0 X-purgate-type: clean X-purgate-size: 1757 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > Make conring_puts() more efficient by using memcpy()'s, rather than > copying the ring a byte at a time. > > No functional change intended. > > Signed-off-by: Denis Mukhin > --- > Changes since v7: > - hardended len check in conring_puts() > --- > xen/drivers/char/console.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index 09282a7a4f8e..a1b8e5f5b507 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -361,12 +361,24 @@ static DECLARE_SOFTIRQ_TASKLET(conring_tasklet, conring_notify, NULL); > /* NB: Do not send conring VIRQs during panic. */ > static bool conring_no_notify; > > -static void conring_puts(const char *str, size_t len) > +static void conring_puts(const char *str, unsigned int len) > { > + unsigned int src = len; > + > + /* There are no callers with strings longer than PAGE_SIZE. */ > + BUG_ON(len > PAGE_SIZE); Should be an ASSERT > ASSERT(rspin_is_locked(&console_lock)); > > - while ( len-- ) > - conring[CONRING_IDX_MASK(conringp++)] = *str++; > + while ( src < len ) src is initialized to len, so this is a problem? > + { > + unsigned int dst = CONRING_IDX_MASK(conringp + src); > + unsigned int n = min(conring_size - dst, len - src); > + > + memcpy(&conring[dst], &str[src], n); > + src += n; > + } > + > + conringp += len; > > if ( conringp - conringc > conring_size ) > conringc = conringp - conring_size; > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:32:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387860.1629085 (Exim 4.92) (envelope-from ) id 1wtWfR-0001Zn-Vl; Mon, 10 Aug 2026 20:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387860.1629085; Mon, 10 Aug 2026 20:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWfR-0001Zg-TB; Mon, 10 Aug 2026 20:32:17 +0000 Received: by outflank-mailman (input) for mailman id 1387860; Mon, 10 Aug 2026 20:32:17 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWfR-0001Za-18 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:32:17 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtWfQ-001ci2-3G for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:32:16 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a3528-bab6-0a2a0a5309dd-0a2a450bed62-26 for ; Mon, 10 Aug 2026 22:32:16 +0200 Received: from [172.105.4.254] (helo=tor.source.kernel.org) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a354e-b7e8-0a2a450b0019-ac6904fe94a4-3 for ; Mon, 10 Aug 2026 22:32:15 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 44139600AD; Mon, 10 Aug 2026 20:32:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 482631F000E9; Mon, 10 Aug 2026 20:32:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786393934; bh=t0DaZoyzF9WrcIzxXm/INYFRzCeVt+f83Z3q3BoGFYg=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=WvyypVdQcDCtsCE08K71Ej8WxeS9X1uWhtyYCJigzO9zfP3vupT8oKt8IyDk9c4NR P9N7xMSRZSYISzyxaPIkOz4a6EdXXALcYWg5qGzNK8uQhliDFLQMngV25Z2jE/DXRZ X0cfQW6Qp5U+U5erjcSkhWEePOqI1FLpzvRVjJ7vRS4AmAaIq+wpdkIb5XNLS4amgo Dx8aMxrkJvbFtmuC5Vh5cu/0720Z5vQjKXW3oSzVppTbd7M/+wE7sLQj6uKYHMrNuP WmiK91Yd4J/6U3MhKA7au8wp9KUgQwdIYwr+olg5DlXYyzF828Nrzuj1WERF2gJX5a Bmr8r3qFaGXjA== Date: Mon, 10 Aug 2026 13:32:11 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 6/7] xen/serial: harden serial_tx_buffer checks In-Reply-To: <20260728065049.1318143-7-dmukhin@ford.com> Message-ID: <4b040e58-9020-a519-00cb-816ce2fddaa0@kernel.org> References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-7-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-42698a/1786393936-A92CC9EA-47C70C91/0/0 X-purgate-type: clean X-purgate-size: 1964 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > Ensure the user-defined value never crosses 2GB boundary and always > rounded to the next power of 2 to align logic with console driver > conring buffer management code. > > Signed-off-by: Denis Mukhin > --- > Changes since v7: > - addressed Jan's feedback: > https://lore.kernel.org/xen-devel/89029dbd-df1f-45d4-8a02-720cd6a42cab@suse.com/ > - kept only check for large buffer in serial_async_transmit() > and a doc update. > --- > docs/misc/xen-command-line.pandoc | 2 ++ > xen/drivers/char/serial.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > index 1c711fa98086..2be8772b329a 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -2396,6 +2396,8 @@ accidentally leaking secrets by releasing pages without proper sanitization. > > Set the serial transmit buffer size. > > +The value provided will be rounded down to the nearest power of 2. > + > ### serrors (ARM) > > `= diverse | panic` > > diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c > index cf0abf1893e5..ba1647309ab8 100644 > --- a/xen/drivers/char/serial.c > +++ b/xen/drivers/char/serial.c > @@ -523,6 +523,8 @@ void __init serial_async_transmit(struct serial_port *port) > return; > if ( serial_txbufsz < PAGE_SIZE ) > serial_txbufsz = PAGE_SIZE; > + if ( serial_txbufsz > GB(2) ) > + serial_txbufsz = CONFIG_SERIAL_TX_BUFSIZE; > while ( serial_txbufsz & (serial_txbufsz - 1) ) > serial_txbufsz &= serial_txbufsz - 1; My understanding of this loop is that, given that serial_txbufsz is unsigned int, it is already clamping it to 2GB max > port->txbuf = xvmalloc_array(char, serial_txbufsz); > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:42:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:42:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387867.1629094 (Exim 4.92) (envelope-from ) id 1wtWoz-0003SX-R5; Mon, 10 Aug 2026 20:42:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387867.1629094; Mon, 10 Aug 2026 20:42:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWoz-0003SQ-OR; Mon, 10 Aug 2026 20:42:09 +0000 Received: by outflank-mailman (input) for mailman id 1387867; Mon, 10 Aug 2026 20:42:08 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtWoy-0003SK-FX for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:42:08 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtWox-00FO3G-LH for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:42:07 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a3771-8faa-0a2a0a5109dd-0a2a4506ba70-24 for ; Mon, 10 Aug 2026 22:42:07 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a379e-195a-0a2a45060019-aceafc1fd302-3 for ; Mon, 10 Aug 2026 22:42:07 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 2F35143E3D; Mon, 10 Aug 2026 20:42:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7147A1F000E9; Mon, 10 Aug 2026 20:42:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786394524; bh=2pkvEhvOT48AM77G2DSwJ9QzA4kZ/PPRhW9xCuWWTpg=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=RUB+QzMp61DRoMlXy1x6ncyrpmfj9Ir1e5EwcbvCatjliNN1gTLerunPeV5aeKasj E5QwUzEHwfZPLBB1G9FqA2BTS6OogEcghhkTZDZ9sGbS281t1HGVfPVKmhtXDT4Gzt PUtZTxBliRY6mUn/GuPUO7YSnpjWR407eoYK0en5DVnGzbpa2tnXuf/iQUJPtdKu/J G+sRDg1tZquXPB+Z5RnRB3fch/5uZj2b8f0mWAT6HGMTrDkQH1RKiZMB+e2yKrNqZL E2pD2zGjf5OteNiMjlrmW1PI9EJBKTjQJ8f1TZVSl4Xv+g9VNDYaTmtyh76W/7ZIcB vyC2fwkhZ1YnQ== Date: Mon, 10 Aug 2026 13:42:01 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 7/7] xen/console: make console buffer size configurable In-Reply-To: <20260728065049.1318143-8-dmukhin@ford.com> Message-ID: <3db29635-6c45-8071-53d8-01737e1a7349@kernel.org> References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-8-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-16d1c6/1786394527-1EAC277B-66E0B5A8/0/0 X-purgate-type: clean X-purgate-size: 3767 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > Add new CONRING_SHIFT Kconfig parameter to specify the boot console > buffer size as a power of 2. > > The supported range is [14..27] -> [16KiB..128MiB]. > > Set default to 15 (32 KiB). > > Update the documentation for 'conring_size=' command line option. > > Resolves: https://gitlab.com/xen-project/xen/-/issues/185 > Signed-off-by: Denis Mukhin > --- > Changes since v7: > - n/a > --- > docs/misc/xen-command-line.pandoc | 8 ++++++-- > xen/drivers/char/Kconfig | 21 +++++++++++++++++++++ > xen/drivers/char/console.c | 6 +++--- > 3 files changed, 30 insertions(+), 5 deletions(-) > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > index 2be8772b329a..448c9bdb8254 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -425,10 +425,14 @@ The following are examples of correct specifications: > ### conring_size > > `= ` > > -> Default: `conring_size=16k` > - > Specify the size of the console ring buffer. > > +The default console ring buffer size is selected at build-time via > +`CONFIG_CONRING_SHIFT` setting. > + > +The run-time console ring buffer size is the maximum of the build-time value > +and the value specified by the `conring_size=` command-line option. > + > ### console > > `= List of [ vga | com1[H,L] | com2[H,L] | pv | dbgp | ehci | xhci | none ]` > > diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig > index 8e49a52c735b..a40a9929132b 100644 > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -95,6 +95,27 @@ config SERIAL_TX_BUFSIZE > > Default value is 32768 (32KiB). > > +config CONRING_SHIFT > + int "Console ring buffer size (power of 2)" > + range 14 27 anything above 20 would fail to build on arm > + default 15 this is OK but is double than the previous default and would be nice to keep a note about it in xen-command-line.pandoc > + help > + Select the boot console ring buffer size as a power of 2. > + > + The run-time console ring buffer is the maximum of the build-time > + value and the value specified by the `conring_size=` command-line > + option. > + > + If `conring_size=` is not specified on the command line, the run-time > + console ring buffer size is the maximum of this value and > + `num_present_cpus() << (9 + xenlog_lower_thresh)`. > + > + 27 => 128 MiB > + 26 => 64 MiB > + ... > + 15 => 32 KiB (default) > + 14 => 16 KiB > + > config XHCI > bool "XHCI DbC UART driver" > depends on X86 > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index a1b8e5f5b507..76367c1dd705 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -340,12 +340,12 @@ static void cf_check do_dec_thresh(unsigned char key, bool unused) > * ******************************************************** > */ > > -/* conring_size: allows a larger console ring than default (16kB). */ > +/* conring_size: override build-time CONFIG_CONRING_SHIFT setting. */ > static unsigned int __initdata opt_conring_size; > size_param("conring_size", opt_conring_size); > > -#define _CONRING_SIZE 16384 > -#define CONRING_IDX_MASK(i) ((i)&(conring_size-1)) > +#define _CONRING_SIZE (1U << CONFIG_CONRING_SHIFT) > +#define CONRING_IDX_MASK(i) ((i) & (conring_size - 1)) > static char __initdata _conring[_CONRING_SIZE]; > static char *__ro_after_init conring = _conring; > static unsigned int __ro_after_init conring_size = _CONRING_SIZE; > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 20:56:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 20:56:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387877.1629104 (Exim 4.92) (envelope-from ) id 1wtX2v-0005TC-1q; Mon, 10 Aug 2026 20:56:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387877.1629104; Mon, 10 Aug 2026 20:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtX2u-0005T5-VK; Mon, 10 Aug 2026 20:56:32 +0000 Received: by outflank-mailman (input) for mailman id 1387877; Mon, 10 Aug 2026 20:56:31 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3-zp6agYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 1wtX2t-0005Sz-Ne for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 20:56:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtX2r-00FPvO-Nv for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:56:29 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3-zp6agYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 6a7a3ac0-8faa-0a2a0a5109dd-0a2a4503986e-32 for ; Mon, 10 Aug 2026 22:56:29 +0200 Received: from [209.85.215.200] (helo=mail-pg1-f200.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3-zp6agYKCbQmYUhdWaiiafY.WigrYh-XYpYffcmnm.rYhjlidYWn.ila@flex--seanjc.bounces.google.com>) id 6a7a3afc-fae8-0a2a45030019-d155d7c8bd58-3 for ; Mon, 10 Aug 2026 22:56:29 +0200 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cab041eced3so3914743a12.1 for ; Mon, 10 Aug 2026 13:56:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786395388; x=1787000188; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=LCgbuv6Vd7zF2bZTNz0VWHu3WJNY8tSX432zegD8YdU=; b=u+UO2xODGCGgUrlf/Mr5d0z+0HcYJ0lJhHAi6HmU2+L+FqX2t/v5Sx/lVOeYoXrKiW 1H+Hy/MwZuEG7glfm8EzJw23z9TtABPeIoyuvR5D+qr5HJleaHMpFExpI5j55bxcEtfM TZGNhJb0UG+n63ir7dvKXwew5PninTo36AswGFXS1gjX3wA/vVYkhCg8rzZVeL1635nf ufEw5vOrbM7KXtRG+2qzWgjcYoBCuUWBZWEpVrCCTo4HmE1c/bOhllSDHogP89NONUWY 9aiVKiZIkzOQeRVUgx70/+pSBklp+H0+XBRPfRB/bEwOXPXhQ3b/WCsmD/XsHManELMe 7bEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786395388; x=1787000188; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LCgbuv6Vd7zF2bZTNz0VWHu3WJNY8tSX432zegD8YdU=; b=rICatsTJsTU0C2t2lQmeWvF/daPXwuRAOlfJtZeg5b1jSMYz4W+ZUg31uf6iyWfVmn gfC919tHnl6lmQbEI7bxEjbp3ntBPtNeMgPs2paa5ChOWenN2D6zjRioYT7hXlDfgjq8 j/lXXVhoP6/tFMBa+FLQXI0u/xoRLzc0Joq18yRPePV9k5wbFE8YUxPCkokjAoxyL0J/ UpITmmp0AhxOpYvWHN3qrQxRXzi0/OBkv5L+5Z4U5FAhJLi216tXEOa2HGg6hMKLuHhP WNlFN9dnRFBgo4WWwiFzFC6xZXJoeEwgdAZhpZsfPdN8wq+txp9gpy1KD1LG3z6LIZa6 dLFA== X-Forwarded-Encrypted: i=1; AHgh+Rpn75V9jjDQVWOgDSDZA1YZ1lmZXvVj1Z5wYtSqmQ4p4DJMsj4pM3WDGZwvHYdcv5KSXNbLQ72WCdk=@lists.xenproject.org X-Gm-Message-State: AOJu0YwAhg7vtRNfJYns70KO/McAoxNEi3zUzjwzAD29ovr8HvvqWOcA c8x2NxGP2AV9oVegzG3M4Po05bWeBxzFjAuRdoMcTkwKg6OBQu8obO+vKO+Y8ez7VmTB2PUx+aI 8Rz1UXA== X-Received: from pgmc19.prod.google.com ([2002:a63:1c53:0:b0:c98:2639:852e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:ad1:b0:848:4d1a:9556 with SMTP id d2e1a72fcca58-84f9c8f6a11mr4384666b3a.11.1786395387317; Mon, 10 Aug 2026 13:56:27 -0700 (PDT) Date: Mon, 10 Aug 2026 13:56:26 -0700 In-Reply-To: Mime-Version: 1.0 References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-18-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v7 17/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-33051d/1786395389-6CEDA4E9-3C117D72/0/0 X-purgate-type: clean X-purgate-size: 2288 On Mon, Aug 10, 2026, David Woodhouse wrote: > On Mon, 2026-08-10 at 10:47 -0700, Sean Christopherson wrote: > > =C2=A0 > > > But when the vCPUs merely have a different TSC *offset*, that's not a > > > problem. The offset is applied to that vCPU's kvmclock->tsc_timestamp > > > field, and it all comes out in the wash. > >=20 > > It's not though?=C2=A0 The value stored in kvmclock->tsc_timestamp is p= er-VM, not > > per-vCPU, when using the master clock.=C2=A0 It's a little easier to se= e once the > > master clock TSC isn't shoved into host_tsc: > >=20 > > do { > > seq =3D read_seqcount_begin(&ka->pvclock_sc); > > use_master_clock =3D ka->use_master_clock; > > if (!use_master_clock) > > continue; > >=20 > > if (!kvm_get_time_and_clockread(&kernel_ns, &host_tsc)) { > > use_master_clock =3D false; > > continue; > > } > >=20 > > master_tsc =3D ka->master_cycle_now; > > master_ns =3D ka->master_kernel_ns; > > } while (read_seqcount_retry(&ka->pvclock_sc, seq)); > >=20 > > ... > >=20 > > if (use_master_clock) { > > hv_clock.tsc_timestamp =3D kvm_read_l1_tsc(v, master_tsc); > > hv_clock.system_time =3D master_ns + v->kvm->arch.kvmclock_offset; > > } else { > > hv_clock.tsc_timestamp =3D tsc_timestamp; > > hv_clock.system_time =3D kernel_ns + v->kvm->arch.kvmclock_offset; > > } >=20 > Meh. I shall have to build a better test case for that one. Thanks. >=20 > > To allow different offsets, KVM would need to track a per-vCPU offset t= o the > > master clock and apply that in kvm_guest_time_update() (and maybe other= places?). > > Which is doable, but it's not clear to me why we'd want to support that= (though > > I haven't fully processed the back half ot his series, so it's very pos= sible I'm > > missing something obvious). >=20 > Because I want to reduce the number of cases where we have to fall back > to non-masterclock mode. Especially the ones which are driven by > *guests* rather than weird choices on the VMM's part. But why though? What is the harm to the host or guest? E.g. does it make = it more difficult to accurately migrate the VM? I'm not opposed to allowing master= -clock mode with diverging offsets, just trying to understand why it matters. From xen-devel-bounces@lists.xenproject.org Mon Aug 10 21:13:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 21:13:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387884.1629113 (Exim 4.92) (envelope-from ) id 1wtXJ3-0000Mg-B6; Mon, 10 Aug 2026 21:13:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387884.1629113; Mon, 10 Aug 2026 21:13:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXJ3-0000MZ-88; Mon, 10 Aug 2026 21:13:13 +0000 Received: by outflank-mailman (input) for mailman id 1387884; Mon, 10 Aug 2026 21:13:12 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXJ1-0000MT-Sp for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 21:13:12 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtXJ0-00FS0Z-A9 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 23:13:10 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a3ee6-2eae-0a2a0a5409dd-0a2a450ad456-0 for ; Mon, 10 Aug 2026 23:13:10 +0200 Received: from [40.107.162.140] (helo=PA4PR04CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a3ee5-f2d2-0a2a450a0019-286ba28cce99-3 for ; Mon, 10 Aug 2026 23:13:10 +0200 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) by PA1PR03MB11087.eurprd03.prod.outlook.com (2603:10a6:102:4fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 21:13:07 +0000 Received: from AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7]) by AS8PR03MB9746.eurprd03.prod.outlook.com ([fe80::cf11:309:1384:58f7%6]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 21:13:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=reVNKDrSwnSwMLwBl3fvobBW/65233a1wXrmuGy0+N1S5cX9VBIfemPENrAyrWU7/hWqOZF+QkQXKeESpWza76Raq1/6ZTAnM+SOuqsVysuSVmHe4yo9WQId7nivsYgxHJZzOjX8oSqJEVRsGWtsFrlqB9Lexh+LUfv3V5g8246bXYbjgeEXRn8gNRoR4dbdCxNbM4s6B1bzNT6zBP/Vq7kF4AzD5swUl45XAlJHsZTFFj1fxM5giZO/LT79o39XOk8hjP9T5/i8/JR2y/GXALSlk/p69c2INaUDGkA2mNsAuwddv+beGAH3+s+utqLzG81sdtfuL0NUCy6itCYMkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LzWm+MoDAj5aNhJ4WndKnYf0eWSbIGtd8eby1BHS21I=; b=WjSichy0/m2ciksaS5zMcC79Qq6/DnjN+It3xoFOte8i8H49mQNJMlNrbuXlzNPeibpgUSpxLNxq8qfoAzJtJypiJMFui3kNEC2ZH7cn7iXnN8208P9Pvi01jmasj77We5FohMtAAjxL8egaoI3za7MprbxorhcPP782CmkEOs+j1PPGJveS6TgMnxfEMJtZjbDRkkFTjCfw336y/wckrLmZYYs8hXNuTnJop6o0OZhC/y+Ir+cy5eGVYj+lQ26MEsukM1HqhzbVwlq6k6+uutoLyGofGzbHfeYpxrCBo03/NRSXQRtBUt2f09XZFvK2SqSrAsidwC8R4sUlrNiBkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzWm+MoDAj5aNhJ4WndKnYf0eWSbIGtd8eby1BHS21I=; b=uXKGhYajRPdJh6lzZTNhfqMxpDQKOGIQV32wZEfEAnkob9PFsOUhpmZq1Lrxo8FviMCC371gERvN9Sl+HvHW/X6D2reVm9raOLT5YaF/HP5yxr4FeSKT2uq4ToRJqRPsGRKFV6lJgyexXVRb+5E6PTX+JtYnjq3WVBIuGaJA6eYfIE3aS79GbBdr4q1V79asRscpKtsEVUwwuMIrQNmpU/s9av7DzZ7lx4d7qZ/pGmINhkwD/Jmo217ciUv9MdVeGEbo0BgF/qEtwoHTEp8ua+6vQJkbOV1DKBsVdiGLg2SHqizrI7fW6ygA+S+OqJbKyycUzYJQ4czHTx5Dq5uK4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; From: Mykola Kvach To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk Subject: [PATCH v2] xen/arm: derive GIC CPU interface ID fields from the vGIC Date: Tue, 11 Aug 2026 00:12:56 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: WA1PEPF00005B70.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d8::609) To AS8PR03MB9746.eurprd03.prod.outlook.com (2603:10a6:20b:61d::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR03MB9746:EE_|PA1PR03MB11087:EE_ X-MS-Office365-Filtering-Correlation-Id: 39ddbef3-ac06-4cbd-6d3a-08def7242c95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|376014|11063799006|10067099003|5023799004|56012099006|6133799003|18002099003; X-Microsoft-Antispam-Message-Info: AMF2SBunzSAL9fG9mIM3vy6oGsdXTEf9dAG4bVWUFKnVyYRH7B1GlZFK3Z7VZ5LGTERxtnvnLjJvf3WHXOHV0VY02829aCyHU3OSVaaSncD60nuxifRo5XtYHwe3Bv8fE85zfhFDd0kBxPxfCpctD0AUbZv4KS0Klg/RWL9mNfpSOarIfobxNfudrg9CVclt5RaeDqjBuIli77BL59R0vX8+qy/NNm6XCtfn5OdvBF4fmJ6RPYYwEuhwP9ywtKjX8JZxQ9dLoeholVoAAxZ3kARERM1wFRTUGI3B18Q0EdlHN6ql0oVXHZxWRiCEKchrle9S+0NlOtoHQDrt5ZtXLcD7//Gv/O2mRFgn3Yf0z5w7p560OZl7/mBgPqthG9UY9xmp49ONy8Hqd90FXLqoiaQ1CtrFqDwpKl8LNJQraMphIb+H4nHbOhFqybXciH/rM+SA00ozySI7hq7sn8SR0qB3XOLVFKvAB52Pf5HEz3Eyubgwf9Doyc08sFJOHAqZ86QVRfKLTXm4FO2O0tKHi6qBlOIis8nCyzIJzYK6zQVwY79R5AsEw6U9eUJg05GT5jSaq7Cyd8umvMFII0rp0zt3fv8a33Lfb53qXAp2A+Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR03MB9746.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(11063799006)(10067099003)(5023799004)(56012099006)(6133799003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vyebwNCxMJRZ9UMCSV7ZF0qA5Tga00bMVhakrl3xO574SVmkVLLJaDyxyCe6?= =?us-ascii?Q?ziKCpCMNWRG5yXJOmyyJ4svytKVn3gNzXCoX1IhEwYxDv65F1fY9rJy8pwxU?= =?us-ascii?Q?BEfdj8qN2nE6WTJS7L9IQzy+rwKG5vVE87o6CJW5tatk53s5JjWLTJ1K4TOS?= =?us-ascii?Q?oBeata5KNUsZ1teKcixRm8Z/F+u99+s+c8prjrgCJUZ1xiXbBFs3hEme8XUw?= =?us-ascii?Q?ejYi793Lv6aoYVSYnd6y6/0YHc8Fa9sLAyVl1Sj1rr4NouUCvPKkbtMq0RM1?= =?us-ascii?Q?CAbcAEGWfYniCb/qw1ARNCEAfiR9IKuSW6cm0Wby1gef3DqGhVi98ZeqAz7/?= =?us-ascii?Q?sSPtRichTo6Dz0ESjNYtHS05Fk+LUzGxh9m6ZUvZCeuzBCO/YZisyOZ/M+Cy?= =?us-ascii?Q?XQCPj0w9Sa7ZrYQOUaEFSsHhoUeE6Ek68kkF7ollzhoH3pRx1oAPy38Nmul1?= =?us-ascii?Q?QHq1lpV3x2lnuKoMQ+ANjcMtGlKO1wwm4g7qdruatnzvaHzkgZD8aBJMIzzT?= =?us-ascii?Q?v4ld4hlKeoe4W/owY2V7pPBRiT1oMptVWI0e83kBZcouTQketJCEZUneInY1?= =?us-ascii?Q?2SBq1eLpMxA6Ul+mpUKGQISGX9w79IxaOATClzRVS/sFmQpC2tfM8mSAjQkp?= =?us-ascii?Q?d/Uex7BRrPlBonF5QZH0sRWjGLjyvFzOhFmKFVHdkmyAYi2F/emnAkS7RE5g?= =?us-ascii?Q?vYOeUnleAazSXB3bam7hkUKIRGtvXRl06T298fnkB6h6y3zj8LnARpsRa/q9?= =?us-ascii?Q?KVariQc6OcJnvC4fm9Rf9DktAZsUBJhxeZ1ZitFcy4H67iOwETfkO7QAfB7B?= =?us-ascii?Q?VinJ6f2a9HkxEdS7TQUAS3x00GVUehUjdXauT5lOPTUaoBciG/k233vP/Chr?= =?us-ascii?Q?TOLz2dRVXQvVsKygMmD3O6xcK8xK/PJRHCFWoFTwn/owLwAidrvqzbh4fwOr?= =?us-ascii?Q?lifouFrkSul/q4NNbLcgJCo8qTYYU7axWH6lSjeGcy6jXKZMLbbGL8XNoEmS?= =?us-ascii?Q?MrkKXEPMPi2C6ydjt/05pQx+U7B3+xC4yR7mLo/fJBmIx+X5Y9Ik48fmEdSm?= =?us-ascii?Q?cXG748nLxXQkfQZTjiQiSt+LFgUaOFs6+q1qFlX2sSoe7jHlucw28y2d33bK?= =?us-ascii?Q?d2X/RiM3ZrZ0fxqzsWVtHpdBKSo0AqqS9+hKH2k9/tivD6GfEMWIbQz/Yvt2?= =?us-ascii?Q?FrX50WQK94BtITjO6a6g7zxNXXM2mooUZB0bcLZUC6TaZJZaCxXfgyrhhQdM?= =?us-ascii?Q?rkQRZOhjE+7693tWXMeR5olnXH39vHapKZhjTJQ+wS8LN5rIc5RCegoeSdbu?= =?us-ascii?Q?fr0cdUy/vAQVfTAYoobcLh7u89pGn5+l+wncavkK9N1Rk9tA4pStDOrr8x1B?= =?us-ascii?Q?8zNV5GVb29fOXyAVQ3GuSXoL2zYvslkz0zBwWfMCSU/5DqllOecsQWA5Guy4?= =?us-ascii?Q?fxJHmcNb84P/i3joX+p+wNswe4DdHoDdRTWXm+rBcs/g+8mgoG5R/6rBgN7v?= =?us-ascii?Q?vQhVvf4fZee8vEtE86ddsHhlnjKRvoxjct5AyyuyvWZ+yWdbgxEBKgoesbms?= =?us-ascii?Q?Mx1/WKG5xJoSjq+0mYN95VQYC/OoVdrTiDOJ0ra/werH6/4i1lEdpsaDbnPv?= =?us-ascii?Q?QE+2IAtrS+LYq8vRUasW0wOySYoRt83bA3xjw8zPi6K9JKkwfQzqKl4wjkr4?= =?us-ascii?Q?18wupMf0Kx8fBLK5I4bk77KmycpnMj7uZXyZl1NEKgKxx2z5e+WNfHw1Ijxv?= =?us-ascii?Q?NYI2RSE1yA=3D=3D?= X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39ddbef3-ac06-4cbd-6d3a-08def7242c95 X-MS-Exchange-CrossTenant-AuthSource: AS8PR03MB9746.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 21:13:07.3404 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cu7S+oKpRR980ev1+YmiMZR+NUBlJgvHfVTSvKn/i7L7/JMTaZY7pNIjJ/Pqu0ruugBVC05d929A4Wxwu4HG7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR03MB11087 X-purgate-ID: tlsNG-4011c0/1786396390-51CC3CFC-DF4A89C5/0/0 X-purgate-type: clean X-purgate-size: 6134 Xen exposes ID_AA64PFR0_EL1.GIC and ID_PFR1.GIC from domain_cpuinfo, which is initialized from the sanitized host CPU feature state. This does not necessarily match the virtual interrupt controller configured for a domain. A vGICv2 domain can therefore observe a nonzero GIC field when the host supports the GIC system register interface, even though Xen disables that interface for the domain. On a GICv4.1-capable host, a vGICv3 domain can observe encoding 0b0011, although Xen exposes only its vGICv3 model. Derive the fields from the domain's vGIC version instead. Expose 0b0000 for vGICv2 and 0b0001 for vGICv3. This covers ID_AA64PFR0_EL1 and the ID_PFR1_EL1 alias in AArch64 state, as well as ID_PFR1 accessed through CP15 in AArch32 state. Leave the alias unchanged when AArch32 is unavailable. Fixes: 07b9acea116e ("xen/arm: Add handler for ID registers on arm64") Fixes: 8f81064a07c6 ("xen/arm: Add handler for cp15 ID registers") Signed-off-by: Mykola Kvach --- Changes in v2: - Share the GIC ID field helpers between the AArch64 and AArch32 paths. - Parenthesize the individual ASSERT conditions. - Preserve ID_PFR1_EL1.GIC when AArch32 is unavailable. - Target master instead of the 4.22 release. v1: https://patchew.org/Xen/ba4f779d68c54efc80c4a566dca38ac2e6f9a073.1783675708.git.mykola._5Fkvach@epam.com/ --- xen/arch/arm/arm64/vsysreg.c | 18 +++++++++++++++++- xen/arch/arm/include/asm/vreg.h | 20 ++++++++++++++++++++ xen/arch/arm/vcpreg.c | 15 ++++++++++++++- 3 files changed, 51 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index d14258290f..a02ad951f9 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include @@ -304,7 +305,18 @@ void do_sysreg(struct cpu_user_regs *regs, * to identify the processor features */ GENERATE_TID3_INFO(ID_PFR0_EL1, pfr32, 0) - GENERATE_TID3_INFO(ID_PFR1_EL1, pfr32, 1) + case HSR_SYSREG_ID_PFR1_EL1: + { + register_t guest_reg_value = domain_cpuinfo.pfr32.bits[1]; + + if ( cpu_feature64_has_el0_32(&domain_cpuinfo) ) + guest_reg_value = id_reg_set_gic_field(guest_reg_value, + ID_PFR1_GIC_SHIFT, + v->domain); + + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, + guest_reg_value); + } GENERATE_TID3_INFO(ID_PFR2_EL1, pfr32, 2) GENERATE_TID3_INFO(ID_DFR0_EL1, dbg32, 0) GENERATE_TID3_INFO(ID_DFR1_EL1, dbg32, 1) @@ -343,6 +355,10 @@ void do_sysreg(struct cpu_user_regs *regs, guest_reg_value |= (sysval << ID_AA64PFR0_SVE_SHIFT) & mask; } + guest_reg_value = id_reg_set_gic_field(guest_reg_value, + ID_AA64PFR0_GIC_SHIFT, + v->domain); + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, guest_reg_value); } diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h index 387ce76e7e..24735aaea1 100644 --- a/xen/arch/arm/include/asm/vreg.h +++ b/xen/arch/arm/include/asm/vreg.h @@ -9,6 +9,26 @@ typedef bool (*vreg_reg64_fn_t)(struct cpu_user_regs *regs, uint64_t *r, typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, register_t *r, bool read); +#define ID_REG_GIC_WIDTH 4 + +static inline unsigned int vgic_id_gic_field(const struct domain *d) +{ + ASSERT((d->arch.vgic.version == GIC_V2) || + (d->arch.vgic.version == GIC_V3)); + + return d->arch.vgic.version == GIC_V3; +} + +static inline register_t id_reg_set_gic_field(register_t val, + unsigned int shift, + const struct domain *d) +{ + register_t mask = GENMASK(shift + ID_REG_GIC_WIDTH - 1, shift); + + return (val & ~mask) | + ((register_t)vgic_id_gic_field(d) << shift); +} + static inline bool vreg_emulate_cp32(struct cpu_user_regs *regs, union hsr hsr, vreg_reg_fn_t fn) { diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c index e7c484f2c1..d6f9326b71 100644 --- a/xen/arch/arm/vcpreg.c +++ b/xen/arch/arm/vcpreg.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -173,6 +174,8 @@ TVM_REG32(CONTEXTIDR, CONTEXTIDR_EL1) domain_cpuinfo.field.bits[offset]);\ } +#define ID_PFR1_GIC_SHIFT 28 + /* helper to define cases for all registers for one CRm value */ #define HSR_CPREG32_TID3_CASES(REG) case HSR_CPREG32(p15,0,c0,REG,0): \ case HSR_CPREG32(p15,0,c0,REG,1): \ @@ -321,7 +324,17 @@ void do_cp15_32(struct cpu_user_regs *regs, const union hsr hsr) * to identify the processor features */ GENERATE_TID3_INFO(ID_PFR0, pfr32, 0) - GENERATE_TID3_INFO(ID_PFR1, pfr32, 1) + case HSR_CPREG32(ID_PFR1): + { + register_t guest_reg_value = domain_cpuinfo.pfr32.bits[1]; + + guest_reg_value = id_reg_set_gic_field(guest_reg_value, + ID_PFR1_GIC_SHIFT, + v->domain); + + return handle_ro_read_val(regs, regidx, cp32.read, hsr, 1, + guest_reg_value); + } GENERATE_TID3_INFO(ID_PFR2, pfr32, 2) GENERATE_TID3_INFO(ID_DFR0, dbg32, 0) GENERATE_TID3_INFO(ID_DFR1, dbg32, 1) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 21:36:28 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 21:36:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387892.1629122 (Exim 4.92) (envelope-from ) id 1wtXfQ-0004el-3L; Mon, 10 Aug 2026 21:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387892.1629122; Mon, 10 Aug 2026 21:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXfQ-0004ee-03; Mon, 10 Aug 2026 21:36:20 +0000 Received: by outflank-mailman (input) for mailman id 1387892; Mon, 10 Aug 2026 21:36:19 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXfP-0004eY-Cl for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 21:36:19 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtXfO-009naE-7B for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 23:36:18 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a4452-2eae-0a2a0a5409dd-0a2a450ccc58-0 for ; Mon, 10 Aug 2026 23:36:18 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a4450-f479-0a2a450c0019-aceafc1fe26c-3 for ; Mon, 10 Aug 2026 23:36:17 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3438340110; Mon, 10 Aug 2026 21:36:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F2111F000E9; Mon, 10 Aug 2026 21:36:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:From:To:cc:Subject:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786397776; bh=Dxn4ZrksVwI2spn1hMaPK022GKaG2Go1NXbLkJDX6Lo=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=m8fDnUFYqTYIghoC6HAWYNXjg+hbRmOzAF4f7EVMLXCRAtOUxGyBCHKpah0594Nfl 7fe7/VE43EiJ6/r2WuB8a4+yGrG6h3o5E2CTjo7OFP/IfAw+w//ln/GI7uNitgovd+ H6ObFYNgB6fOM6IEW3ZmsIauFQRxKP8v1OQCjeHHfazfFaaKcQbhyIBJ7t4zNUr287 YGdq1nH2ssbE5nt3AJ5hRjDpGO8ZELAcgM1nxWrAiarqTHjX/B+erK0/vMyh3ifGS0 sCjN0o8FJxS68w7cAlZD9fz9TT4qvd7g5u3OVeEIaoBOL/wF3Nfbd2miZXgT/G1AFC kU0ObfLlt5q1w== Date: Mon, 10 Aug 2026 14:36:13 -0700 (PDT) From: Stefano Stabellini To: dmukhin@ford.com cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 5/7] xen/console: use memcpy() in conring_puts() In-Reply-To: <20260728065049.1318143-6-dmukhin@ford.com> Message-ID: References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-6-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-purgate-ID: tlsNG-d25034/1786397778-026DEA5B-B99070F0/0/0 X-purgate-type: clean X-purgate-size: 1732 On Mon, 27 Jul 2026, dmukhin@ford.com wrote: > From: Denis Mukhin > > Make conring_puts() more efficient by using memcpy()'s, rather than > copying the ring a byte at a time. > > No functional change intended. > > Signed-off-by: Denis Mukhin > --- > Changes since v7: > - hardended len check in conring_puts() > --- > xen/drivers/char/console.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index 09282a7a4f8e..a1b8e5f5b507 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -361,12 +361,24 @@ static DECLARE_SOFTIRQ_TASKLET(conring_tasklet, conring_notify, NULL); > /* NB: Do not send conring VIRQs during panic. */ > static bool conring_no_notify; > > -static void conring_puts(const char *str, size_t len) > +static void conring_puts(const char *str, unsigned int len) Here, I think it would be better to keep it size_t > { > + unsigned int src = len; > + > + /* There are no callers with strings longer than PAGE_SIZE. */ > + BUG_ON(len > PAGE_SIZE); > ASSERT(rspin_is_locked(&console_lock)); > > - while ( len-- ) > - conring[CONRING_IDX_MASK(conringp++)] = *str++; > + while ( src < len ) > + { > + unsigned int dst = CONRING_IDX_MASK(conringp + src); > + unsigned int n = min(conring_size - dst, len - src); > + > + memcpy(&conring[dst], &str[src], n); > + src += n; > + } > + > + conringp += len; > > if ( conringp - conringc > conring_size ) > conringc = conringp - conring_size; > -- > 2.54.0 > From xen-devel-bounces@lists.xenproject.org Mon Aug 10 21:37:22 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 21:37:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387899.1629131 (Exim 4.92) (envelope-from ) id 1wtXgQ-00058w-BP; Mon, 10 Aug 2026 21:37:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387899.1629131; Mon, 10 Aug 2026 21:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXgQ-00058o-87; Mon, 10 Aug 2026 21:37:22 +0000 Received: by outflank-mailman (input) for mailman id 1387899; Mon, 10 Aug 2026 21:37:21 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXgP-00058e-6U for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 21:37:21 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtXgO-000nkd-82 for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 23:37:20 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a4457-e002-0a2a0a5209dd-0a2a4509abb8-28 for ; Mon, 10 Aug 2026 23:37:20 +0200 Received: from [40.93.196.65] (helo=SA9PR02CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a448e-be1a-0a2a45090019-285dc4414e10-3 for ; Mon, 10 Aug 2026 23:37:19 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by SA2PR03MB5738.namprd03.prod.outlook.com (2603:10b6:806:fb::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 21:37:16 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.024; Mon, 10 Aug 2026 21:37:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mVJmranwl6HqirYdUYhbdGMocCTXc4aKKfXQRGV87CziVNI2JGI1eLPCgiqlyEG03uSSSp/jmlosQJOKShB8lxlsTxvqY0gskeDgIi4SsSFevsWRWFh1v78hKffKQvJcVnKqOURpBda57MJxThTY9dw5+swe7flZHiYclj7siXCATV8z54E57iDjIzTi+nBszPO+xqmpQJ99FgCv+kaVbZQpPK0BCvhHpG0O8pqSZ7jAtwlHWR288yuuj6M97S0suJSY6mUhjPIeWLyw2Soqvj7RxDo02JX1AmkriiowByIBono2DjUacxSidknQQBCOD5hreEU3/sxnT5xtkI7G/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OM+mAY+O7i3CfxnsDVu/HXx5p6iBiKJNSROZuaBQNjk=; b=JE+Yj6aJpa130kCjG4b1AS34Ys8X+lIxvf1zN+lad60pfPtDxxBdIiLBQcU3RyUMbWxAZzpjciK8QRzHE+99ypSUBdOTv7hJ6CrrkEz2FrgKnAohdKsiUTsukONP/MLVsDUowanDECtoZQnhl6sMlMIrXErzEalVaJwc6LkDLLprBxoCKBSmPVqvE6X3/sOJHusKHRKgOjNNTm2vj2qCsgQKfDya5ho+/ytxgUQZOA37BtQUo9kGBYd/y4haSRxZAwQaaijDVsr6j1sDXGrtImOoRW6mIHtV2UhH0CeyYiPqbsRdHWpLK49NgwTfu6GM0U45aMJyObKUumviiinM/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OM+mAY+O7i3CfxnsDVu/HXx5p6iBiKJNSROZuaBQNjk=; b=jNjJ5IHaHz474zBYVPmIXcUlOcpaYGQmN9Fjw4ZRCUhILCgQ/rbbs48C/TWbcZWPApHkQsks3nD3zhcKP27uNEV93mStaFg1eUZ8Kdh6S+52E7phvpZNlvZ35FgzYIrldTx4nXRpcwlpoSt44DoFgAFO7SKHOeotCogfZgdHRCk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <90f7a25f-4007-4f9e-b5d1-ab2b18ab59f9@citrix.com> Date: Mon, 10 Aug 2026 22:37:12 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Subject: Re: [PATCH v8 5/7] xen/console: use memcpy() in conring_puts() To: dmukhin@ford.com, xen-devel@lists.xenproject.org References: <20260728065049.1318143-1-dmukhin@ford.com> <20260728065049.1318143-6-dmukhin@ford.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20260728065049.1318143-6-dmukhin@ford.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0376.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::21) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|SA2PR03MB5738:EE_ X-MS-Office365-Filtering-Correlation-Id: dd3877b8-4628-4159-7d96-08def7278bf8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|23010399003|4143699003|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: kd7CSzMDEw80YukTjoN8IJ3hGCA/fU4rbv01f8V36Ku4JbNKfNvyGsDiA0JAfmdgq73vvpVdNIRjx+Z42x8LYrkGbh2lKgVcCvinUtKTLcVlM05EaivmEXXMystNk6dwqPg8FVRUykAw3ZezkOX74OtsYbYn4dnOW9GzLZ+NNuv7yxJCgpMxIW7ZpbF1ftFgz6Lq9+O9TdueIBY16Nzcsctj2K/XB4EPg4gcAoi6EnzpFvJH6Cnyl0eTG615H/tnEZMcL2W3talwXZAP+u+M/zoX1dg/iTCrPQGghM9akqUiRyInEXsfyDqHtmmVoLvnhC8CLrbFMZlSwkgtLpt7gdcrgG48dROe6I1di1wk/fAgizHDUOXMQsu9/A2dIaqmMUMFlqL0JAaHmjgDTZmpoBe/CVHtOjs8FKdsKR25oYpgt+wGt2TSno0DXIhJWcJo92h7KXmtt0Cdw7Zsg4mzdtD1vZsS976eJJNBMeFI1ThQdvtYJ01LIUAIFEKVkeRoAaCzbhzfk/D0i17L8xM8E9BEyQuQvg4Bd0CvVhs+GTM5B+//HkX7mOO3aoviuYo8OqFrtYm7/ppbzOZ0BNsmslFNP8oNXMruTra8YRUPl9Vjw+8EmYuvJvIxzM4QIWMQSB/ZPrTdtn6mtNln04WiDv3gwz1z+++XsQFENydjGHA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(23010399003)(4143699003)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjFEejZFb085NWs0dmtUMDZuNGpaTUFGQTFTZnRqaTJFTWJEOFdUNHErZnpr?= =?utf-8?B?cXprbFRjajJaZXlDUHhsVU43QnR6U0FsVEpsdDRBeW5uZ2tObzF1NVdIckVY?= =?utf-8?B?bDhtR04wVndZTzQyZjMyVEZ5b08wSUFObDhJaHpxNk1YeU1nZUE5TzVoM3Bt?= =?utf-8?B?ZkZKeVRSRHI5ZnJ4eWNWOWhPckpvOVo1SVZkRGJxR1FjOGhDcHA5bW9LdjBi?= =?utf-8?B?Mi9iTE4vbnZFZGM1V1BPckpBQjFJU3QvbWZab2JjRVhMeWd6L1I1N2dYbGxh?= =?utf-8?B?WDJQalpSU3NwNXV2T29aU2lDNisrSUpBSWwrV2d1RjB3OFhxZzM1ZGpvYWdL?= =?utf-8?B?WWExakFWSUVXb256cU1wNjZKalVDUzNxU216SW91anRodVZJNktQUzk1KzV2?= =?utf-8?B?WERFVC9ZSmMvQ3ZuRWd2K0IxM1hPSW94K2NPdW5QL29WSkVOSTZmSXpKZDZX?= =?utf-8?B?TitSSUF2RExNWHlZNHdRVXpKNU12ZCtOMi9WeTBhYmZTcUJMa3dRaU1TSHZl?= =?utf-8?B?S0lBQy83NUUvMlVBN2N0S2pZZGwwL253UmU5clBuTHVyRzFISklZL1oxV2Ur?= =?utf-8?B?NmVyeWlvVjMzaDRrbXRleUFDajROQW1iZmgvTFNJKy9XMWF4VDFQOGFXWERj?= =?utf-8?B?Q2lHOUZ6Nk5BR1prYTdIZjUySzJaTGNKWUJZMXdLUWNoTktCTW95Vzdrd1hn?= =?utf-8?B?Mld3YVRXdkltRDJkR1ZwdTlPL1dsc0todUN5MVdSRC9TTjJwTUxtSDNzM0o0?= =?utf-8?B?Z0MwZUR1TEs3SjE2R3JFa1VGbnV5QUNUVFZ0QVFPa1BubERUSlFaS2xuWnRJ?= =?utf-8?B?cE5WSktYdE1HSUphN3NSNndGRk9nT294QVJBK3ljazE5VUttcHZGc01rL1ZB?= =?utf-8?B?N2cwWW1UYThlOWxndE5KakRJVmhHcCs5cmVZL1ArNWtIQ2NLSDRlWjBIZFkv?= =?utf-8?B?c1dYV2NoWmg5WVVYREs5VE9ERTZaTkJlSzdCbVkzTWEyMVE5UmJTZ3VaR1NK?= =?utf-8?B?VkVUdDRlUStJNSt5ckRiZS81TWhwOUFNM0oyOGEyODEwRW1aTmxoQzU5eEx5?= =?utf-8?B?NkluazlWbXJUM08vZ016TEw2SmVoTS96bmRaNUtMVjZPZWZEL21SS3A1U0ZI?= =?utf-8?B?ai9maXhlWFRxMmJlSDQrM3czM1l2YWc0TmJoYXNzS2ZydFVYMmxQeGtMRkNZ?= =?utf-8?B?OURkdnRocWI2ZURBRmlXOHZ4dlFiT081cjhydmdoRSs0QUxLb0JDUktQeEdX?= =?utf-8?B?bVpyYWtpNEdlNXhzOEpCV3NVckZ5QSt2ZEE4dTI4SnFZKzdNTkVDcjdQOXIv?= =?utf-8?B?QlR5cmt1TElPZGZ0bC9UN1hMeEJ6bHBkQU4wZWoxWGw1WVlIZ1djYWUzbDhE?= =?utf-8?B?R2w4NllYL0tmajU2em1TY0hVWXR2VXduSHpqVElHb243MFBiVDNTcmRhY2hJ?= =?utf-8?B?UGw1VmtDV3ZmVURaYTZHanBMb21ySzdobE02Y3ZNdTBUYk1Oa1NrbzZoZW5I?= =?utf-8?B?aHRRK0pBS0JUWG4vTXQrUGFQeXpFZzFiSXNnSVZOOVZvTERWNThwZVNmaXJE?= =?utf-8?B?OGZ1KzdEOW9FRzVHWW1sTmlpcFNtR3lOZkJ1M2RDMWwzcjIyN1AwYnBCR2Vz?= =?utf-8?B?bHAwSitoK0cwZlIzVEJhNmVPVUlLZUk1SHlpYWN4SkV0aEdOZXlGQXUwdnlI?= =?utf-8?B?T3B3ektpTUhGTmZZa203YVlRRWFvSHRJSXZ5aDFMYnZPQmYrUjgwS01OcFZH?= =?utf-8?B?Y0haZXR2SmhzTk1ScW1JcXNtSWRQWFFIZ0l5aUdoN0xsc2pEZHpkSHBPYTRD?= =?utf-8?B?OTU3N1J4aC9aTC9DcnFwZk5RR3JXWjJKOWpZRHJieXNkb05pcFlqNHcvRWJ3?= =?utf-8?B?ZExjbUNyaXNURFVyKzNCQmlUa3BhakJSK1RCMThXeXQ4VVdveUJiOUlUeE1G?= =?utf-8?B?UGVIdElOcmZNU3I3UzJXRWRBWE1DWGk3UVhtVVg2dXdONitOczl4U0J3eDQ5?= =?utf-8?B?WTViUTgydjRVcFQ4QXBTVnJYU29pTU5vd3c4ZUxsc3BvUWJpdWpMR1RRek0w?= =?utf-8?B?K1NwR1VhWHFDQngxQldVekNNRXFqWTgxQU5xV3BqaHFaUzdielZyL1FCa3pw?= =?utf-8?B?YTRDMjg4aVRhNzBiQm1tTHJreXA3Q2crNXpSbUdJY3NKdm5Va1AwYVpYV0ha?= =?utf-8?B?bGpLL09ibjBTWExKMEt0YnNaQTVrN0Y4NXZGU2NCdGFFRWYxdXNTblJCTmtW?= =?utf-8?B?MVlHVW9oVVJ4UFZ0VTYvaHh3MkhrcVRPR1hobHVxTDJtZE03QmVLTjBvRytI?= =?utf-8?B?cmg4VnlhdVZ1TnJsU29QdzBBZkxYSjE5Q2N2ZjROamZHZnIyWVV4QT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd3877b8-4628-4159-7d96-08def7278bf8 X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 21:37:15.9238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cGczisF4xSrIY2ad4FWh3MSYe3yIgax6l/8AEN2gR9dy3QaHdIcdpnK/FjNSJ4FdD6USDjA/xBsl0c19eNfYZlZ36agqIqOoZEkAj5tAiL8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5738 X-purgate-ID: tlsNG-bad1c0/1786397840-3B8D1034-31B78E67/0/0 X-purgate-type: clean X-purgate-size: 1698 On 28/07/2026 7:50 am, dmukhin@ford.com wrote: > From: Denis Mukhin > > Make conring_puts() more efficient by using memcpy()'s, rather than > copying the ring a byte at a time. > > No functional change intended. > > Signed-off-by: Denis Mukhin > --- > Changes since v7: > - hardended len check in conring_puts() > --- > xen/drivers/char/console.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index 09282a7a4f8e..a1b8e5f5b507 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -361,12 +361,24 @@ static DECLARE_SOFTIRQ_TASKLET(conring_tasklet, conring_notify, NULL); > /* NB: Do not send conring VIRQs during panic. */ > static bool conring_no_notify; > > -static void conring_puts(const char *str, size_t len) > +static void conring_puts(const char *str, unsigned int len) size_t is the only correct type to be using here.  Anything else is buggy and a ... > { > + unsigned int src = len; > + > + /* There are no callers with strings longer than PAGE_SIZE. */ > + BUG_ON(len > PAGE_SIZE); ... bug waiting to happen.  Switching to ASSERT() ok either; it is fine to pass more than a page here, and all this does is screw over some future person who has a complicated debugging scenario. I have 0 remaining patients for the avoidance of size_t.  I will nack any further patches I see doing it, as well as any further advise I see given from anyone in the community. The rest of the patch is fine.  Please resubmit while keeping len as size_t. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 10 21:44:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 21:44:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387908.1629140 (Exim 4.92) (envelope-from ) id 1wtXnH-0007G8-3v; Mon, 10 Aug 2026 21:44:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387908.1629140; Mon, 10 Aug 2026 21:44:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXnH-0007G0-0f; Mon, 10 Aug 2026 21:44:27 +0000 Received: by outflank-mailman (input) for mailman id 1387908; Mon, 10 Aug 2026 21:44:25 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtXnC-0007F9-JT for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 21:44:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtXnB-000omS-PS; Mon, 10 Aug 2026 23:44:21 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a460b-bab6-0a2a0a5309dd-0a2a450bbd66-24 for ; Mon, 10 Aug 2026 23:44:21 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-42698a.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a4635-b7e8-0a2a450b0019-5a9b3222ebec-3 for ; Mon, 10 Aug 2026 23:44:21 +0200 Received: from [2001:8b0:10b:5:9f69:702f:982f:3898] (helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtXBe-00000002RcN-2aLb; Mon, 10 Aug 2026 21:05:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SijqBWl9ZkBNE7pHvkxqxYD5xyZpHt3QeS+w+ayHuQ0=; b=pSAchZm53udG9aJjudbXeJ1VD9 GqwPYq5yU6gefz5TZ2w+NIZZLRqzE/ScTJi6ljnSSGssP69X7Y+M73EdEKX/7Z9u1BFDTYkB0ghea Yy06tKCJPPtyRC0HCIKvP0dhWERDAFl0I5Se6QKtJJdKqTRiWuRceZB/dzVvoP5roQAyIO40II86z o8zhhKe5GqttVYVFixb2tcAsgdKydF+t6xfg96nzfu8X039L2Ly/gFhIvqAaEKbivWwgWj1bks1tR CchsqFNYIuO7ytcqnNMYtySbGfyjLE3eMyEHXFJDdSrKDY/EsQQqjSQOI1oTYWC/RxJUXJuZ49qb1 jYqnTj6A==; Message-ID: Subject: Re: [PATCH v7 17/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Mon, 10 Aug 2026 22:05:00 +0100 In-Reply-To: References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-18-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-zfkTkyTeIpo4gnwF+EUX" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-42698a/1786398261-A88C99EA-21C86278/0/0 X-purgate-type: clean X-purgate-size: 10180 --=-zfkTkyTeIpo4gnwF+EUX Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2026-08-10 at 13:56 -0700, Sean Christopherson wrote: > =C2=A0 > > > To allow different offsets, KVM would need to track a per-vCPU offset= to the > > > master clock and apply that in kvm_guest_time_update() (and maybe oth= er places?). > > > Which is doable, but it's not clear to me why we'd want to support th= at (though > > > I haven't fully processed the back half ot his series, so it's very p= ossible I'm > > > missing something obvious). > >=20 > > Because I want to reduce the number of cases where we have to fall back > > to non-masterclock mode. Especially the ones which are driven by > > *guests* rather than weird choices on the VMM's part. >=20 > But why though?=C2=A0 What is the harm to the host or guest?=C2=A0 E.g. d= oes it make it more > difficult to accurately migrate the VM?=C2=A0 I'm not opposed to allowing= master-clock > mode with diverging offsets, just trying to understand why it matters. Accurate migration without masterclock is hard, yes. The KVM_SET_CLOCK_GUEST thing relies on it (because the principle is that you get the *TSC* right, then the KVM clock is just a fixed mathematical function of that). That *shouldn't* be difficult with offsets between vCPUs. Just use the TSC of vCPU0 as the reference for KVM_SET_CLOCK_GUEST and let the others just have their offset from that. I'll take another look. --=-zfkTkyTeIpo4gnwF+EUX Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MTAyMTA1MDBaMC8GCSqGSIb3DQEJBDEiBCDGyzf28IxzNQVqwTLbkSt7wGH+znNi CL7cyxiJFkF6nTCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAcJAQV8lArprY4QdX4S70lB2o670kzRmGWlhhV0kL7APeLL1qd7JT rdLmUaZT5z6m4dn4ASLKJFRBXw8UiZm+Zex1C0He1lRPpv9WwketAuGy3ofwst/gRDpZX5T8LFdd SjlvSK3Ones17j8U8wwr0X9teLmUlD4Ylh/GONI457BRVvHKLnrHHMOGd3sX7MlpZL6f3MslXJqF 3rDLj10bi6+bsSyxWKlYOq2BIGNQYqfv+VxsWuJxE3a8f/f+MrJIO//qpOzyVbSgszSV/stoG7Ls O0maR34jfVAJfQ9OIiJTJ0oIgSPuVH6GIQtVvZQ8A5Lchkpq1gs0a8nVW8L95E6ajzNDJ+GBUyGy 5+k7QSoyvVhP8SdxWWnJt8p0hvP8yh2NofC8J8JsDcnP18XnQLue7cw1YNeQ0IPggsYe5A74DVl5 nWtaYMGOYleaSKECZgqPOsGW8+Qky2hDOl99U7AVr+rj5/T+m+mHRGl+2vie6MlMxkORl2UQsD4p i7ixHIhe2H9xW0OVUkRkKBJPS1NMdAHc75Vis9nGn0LNgUv3MbAE8V0rvODfmGt3ElABEN+Ry5Qd Ohzfu8zyzgquPXQ0IkUnI1xAaAJPmILp7MAFG9gvnnPs1CwbSTSuk8bMx82DzQMJBdx40OPFSXoH HoQrwlECdeP8DnxGaGcV018AAAAAAAA= --=-zfkTkyTeIpo4gnwF+EUX-- From xen-devel-bounces@lists.xenproject.org Mon Aug 10 22:10:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 22:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387915.1629149 (Exim 4.92) (envelope-from ) id 1wtYCc-0003Sq-3D; Mon, 10 Aug 2026 22:10:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387915.1629149; Mon, 10 Aug 2026 22:10:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtYCb-0003Sj-WB; Mon, 10 Aug 2026 22:10:37 +0000 Received: by outflank-mailman (input) for mailman id 1387915; Mon, 10 Aug 2026 22:10:36 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtYCZ-0003Sd-SN for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 22:10:36 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtYCX-00FY55-Ag for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 00:10:33 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a4c46-8faa-0a2a0a5109dd-0a2a450cba54-30 for ; Tue, 11 Aug 2026 00:10:33 +0200 Received: from [209.85.128.45] (helo=mail-wm1-f45.google.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a4c59-f479-0a2a450c0019-d155802ded66-3 for ; Tue, 11 Aug 2026 00:10:33 +0200 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-49553515a8bso37007495e9.1 for ; Mon, 10 Aug 2026 15:10:33 -0700 (PDT) Received: from localhost.localdomain (host-78-146-248-75.as13285.net. [78.146.248.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499740c1f61sm21254325e9.5.2026.08.10.15.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 15:10:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1786399833; x=1787004633; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qJ+Dl9EkivuGED/x2FDHLy1mHCFN96YYc5uGAZKzX8w=; b=lUkPremvwM9yA/+xQpUHTgLeo4DZKrLQc+fBtKekqLlAYxMijP+nKoSTfVpuP2HXfM Hkn6PWlTVgXgo6VNOYNoGH0hcXK+HdT+CYlTCSjLvm96FJV1if/5gR4aQjeJyvHbjgf6 bJ96eBvQbk90eKF0o2QnTdaYpBgpxya54pAI8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786399833; x=1787004633; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qJ+Dl9EkivuGED/x2FDHLy1mHCFN96YYc5uGAZKzX8w=; b=DQnzONG761Cwm/MR+Y8IU5v5n4bOLs34+LP3eAZoB8Vax7SlpNERPVJNHRXR1M2iyh CWuAvY2JA9iWCVrUCs/Ylp+QoKliRmevXAzmqbNwh4QbGyKXuPifchhujtjrVBV/VW57 B+StFb2xB4XZAgDv8lCaLj5QkWqZ7Xc3LR1qvko3CwZHZj+Yfqjm5nC2Iun9PRfuxqit ZToSBxzhtcGtJy36xspyRYX/xadD0D51BFvNfv1sgdHDx2zCahnVYQvhNw7M48mKnHnu h1iuo28PzRl9q/BVS3PkH3Zw8UVOO+mKnjJH+9Y0aSy4bcxHgqbp1/fFJ3sZRw9muWya 4B2Q== X-Gm-Message-State: AOJu0YyLIiN3A8/psvAFPe1iMjMeLImrxGXEPduur0O4eO+97Uzjwn76 Vt9njrFdlQ0u6Ji468N8XVFP8+6Pn2JJGRvcN3+AJ6LWg1hCTsZPzU/oDVFiUZgY5Ck+n1ZCW1A AU2DCuWQ= X-Gm-Gg: AR+sD10kTZWlDqr6YiOhpq+hcVHiOTHbtmU5VWTcxjFqt5uo5gF2E9FA+AX0Ozahow0 HxK0so9vlfl0bfREhBp6shTq51QLikdvTZZ6EHmjQ3NkrKDOHjxBil3hRu2VJeDVSL7N5Nhr/jx ANMYAG1JBTU59BICMld/8anNBEQqohRMF0Yn2HUAkQgAdLPJMDvVop18iIAV5/YduisD+iEGsal UvANT7pCNnRMSyULT01p4Pc1eJdRnlz5vpXKX6hS8OpdBDXnDjGGE0KwJxW2fqMbRkphmKwVvsO GTLLEXoG2qVjOCkJ5hZ2JgRfOd8IV4a0g1PYdFoEDmG56tbDxjeH5JxYzet6GeIrLMsFuo7cQs4 pc8xAEnwCTgpkzJ71s1kLnlN3+KyohK5MotXgHyNH+db/EJEAwKeNAOpmeoLQnWFxq1mGqXBieR Nq5Wx25EU45MjeFyw8p/5eNcO59puUyIrIxhvZtMmq7AeOdVeaeljUKzlXwto92NUu21CQfU5i7 mpYPDleFDNimvuDUk2gtyyOyY58ZpyWUgBK+aI= X-Received: by 2002:a05:600c:5795:b0:499:60bf:c6f7 with SMTP id 5b1f17b1804b1-49960bfc7c2mr274411375e9.13.1786399832450; Mon, 10 Aug 2026 15:10:32 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Teddy Astie Subject: [PATCH] x86/pagewalk: Read guest PTEs with ACCESS_ONCE() Date: Mon, 10 Aug 2026 23:10:29 +0100 Message-Id: <20260810221029.1520858-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d25034/1786399833-03ED2A5B-718938D6/0/0 X-purgate-type: clean X-purgate-size: 4719 This has been a plain C read for as far back as I can trace in history. Research into invented-loads has flagged it as a possible vulnerability. After careful analysis, it is believed to be a bug only, not a security vulnerability. The code fits the pattern for invented loads, and it is a risk. The analysis suggests that we can read one value out of the guest, operate on another, and that this could be an in-guest privliege escalation. Any entity in the guest able to modify the pagetables already has full privilege, so while Xen can potentially malfunction, the effects don't cross a privilege boundary. The analysis also suggests that this is worse for shadow guests because we may put the TOCTOU entry in the shadows, but this is inaccurate. What we put in the shadows is still translated under the P2M and refers to guest physical address space. Either way, harden the accesses. Link: https://github.com/xoreaxeaxeax/schrodingers-toctou/blob/main/observer-effect/audits/audit-xen-ptwalk-RELEASE-4.21.1.md#86-per-candidate-finding Fixes: 49f7c7364e0a ("Replace shadow pagetable code with shadow2.") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Teddy Astie I'm not really sure about the fixes tag. That's the oldest commit which bares any reseblence to the current code, and it was a bulk rewrite of the whole shadow pagetable code. Prior to that, it was all mixed up and it's not completely obvious what's (definiely) walking the guest pagetables as opposed to the shadows. Bloat-o-meter shows this clearly makes a code-gen difference in all cases: add/remove: 0/0 grow/shrink: 1/2 up/down: 16/-19 (-3) Function old new delta guest_walk_tables_2_levels 1688 1704 +16 guest_walk_tables_4_levels 3708 3703 -5 guest_walk_tables_3_levels 2233 2219 -14 To start with, l?e_read() looked to be the right helper, but they don't exist for guest pagetable types, leading to: arch/x86/mm/guest_walk.c: In function ‘guest_walk_tables_2_levels’: ./arch/x86/include/asm/page.h:135:36: error: incompatible types when assigning to type ‘guest_l2e_t’ from type ‘l2_pgentry_t’ 135 | #define l2e_from_intpte(intpte) ((l2_pgentry_t) { (intpte_t)(intpte) }) | ^ --- xen/arch/x86/mm/guest_walk.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c index f48c3ef75f48..df2ccaa67475 100644 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -129,7 +129,7 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, guest_l4_table_offset(va) * sizeof(gw->l4e); if ( !hvmemul_read_cache(v, l4gpa, &gw->l4e, sizeof(gw->l4e)) ) { - gw->l4e = l4p[guest_l4_table_offset(va)]; + gw->l4e = (guest_l4e_t){ ACCESS_ONCE(l4p[guest_l4_table_offset(va)].l4) }; hvmemul_write_cache(v, l4gpa, &gw->l4e, sizeof(gw->l4e)); } gflags = guest_l4e_get_flags(gw->l4e); @@ -164,7 +164,7 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, guest_l3_table_offset(va) * sizeof(gw->l3e); if ( !hvmemul_read_cache(v, l3gpa, &gw->l3e, sizeof(gw->l3e)) ) { - gw->l3e = l3p[guest_l3_table_offset(va)]; + gw->l3e = (guest_l3e_t){ ACCESS_ONCE(l3p[guest_l3_table_offset(va)].l3) }; hvmemul_write_cache(v, l3gpa, &gw->l3e, sizeof(gw->l3e)); } gflags = guest_l3e_get_flags(gw->l3e); @@ -264,7 +264,7 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, l2gpa += guest_l2_table_offset(va) * sizeof(gw->l2e); if ( !hvmemul_read_cache(v, l2gpa, &gw->l2e, sizeof(gw->l2e)) ) { - gw->l2e = l2p[guest_l2_table_offset(va)]; + gw->l2e = (guest_l2e_t){ ACCESS_ONCE(l2p[guest_l2_table_offset(va)].l2) }; hvmemul_write_cache(v, l2gpa, &gw->l2e, sizeof(gw->l2e)); } @@ -353,7 +353,7 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, guest_l1_table_offset(va) * sizeof(gw->l1e); if ( !hvmemul_read_cache(v, l1gpa, &gw->l1e, sizeof(gw->l1e)) ) { - gw->l1e = l1p[guest_l1_table_offset(va)]; + gw->l1e = (guest_l1e_t){ ACCESS_ONCE(l1p[guest_l1_table_offset(va)].l1) }; hvmemul_write_cache(v, l1gpa, &gw->l1e, sizeof(gw->l1e)); } base-commit: e888192d133eeec8a94275eaf4194117f198a7e2 -- 2.39.5 From xen-devel-bounces@lists.xenproject.org Mon Aug 10 23:05:38 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 10 Aug 2026 23:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387924.1629157 (Exim 4.92) (envelope-from ) id 1wtZ3b-0003Z2-Tv; Mon, 10 Aug 2026 23:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387924.1629157; Mon, 10 Aug 2026 23:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtZ3b-0003Yv-R0; Mon, 10 Aug 2026 23:05:23 +0000 Received: by outflank-mailman (input) for mailman id 1387924; Mon, 10 Aug 2026 23:05:22 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtZ3Z-0003Yp-Tv for xen-devel@lists.xenproject.org; Mon, 10 Aug 2026 23:05:22 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtZ3Y-000xbQ-9i for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 01:05:21 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a5904-bab6-0a2a0a5309dd-0a2a45098308-14 for ; Tue, 11 Aug 2026 01:05:19 +0200 Received: from [148.163.143.241] (helo=mx0b-00498f03.pphosted.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a592d-be1a-0a2a45090019-94a38ff16058-3 for ; Tue, 11 Aug 2026 01:05:18 +0200 Received: from pps.filterd (m0367129.ppops.net [127.0.0.1]) by mx0b-00498f03.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AMogSP1811607 for ; Mon, 10 Aug 2026 23:05:17 GMT Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013053.outbound.protection.outlook.com [40.93.196.53]) by mx0b-00498f03.pphosted.com (PPS) with ESMTPS id 4fymrs1yay-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Mon, 10 Aug 2026 23:05:16 +0000 (GMT) Received: from BY3PR10CA0028.namprd10.prod.outlook.com (2603:10b6:a03:255::33) by LV0PR16MB6940.namprd16.prod.outlook.com (2603:10b6:408:346::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Mon, 10 Aug 2026 23:05:14 +0000 Received: from SJ1PEPF000026C9.namprd04.prod.outlook.com (2603:10b6:a03:255:cafe::34) by BY3PR10CA0028.outlook.office365.com (2603:10b6:a03:255::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Mon, 10 Aug 2026 23:05:13 +0000 Received: from mx0a-00498f04.pphosted.com (205.220.161.53) by SJ1PEPF000026C9.mail.protection.outlook.com (10.167.244.106) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Mon, 10 Aug 2026 23:05:13 +0000 Received: from pps.filterd (m0426317.ppops.net [127.0.0.1]) by mx0a-00498f04.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AMoeMA1320374 for ; Mon, 10 Aug 2026 19:05:13 -0400 Received: from smtp-us.ser.proofpoint.com (pmta-usw.ser.proofpoint.com [50.112.124.217]) by mx0a-00498f04.pphosted.com (PPS) with ESMTPS id 4fxkhrj720-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 19:05:13 -0400 (EDT) Received: from localhost ([19.12.76.222]) by cmsmtp with ESMTPSA id tZ3Owq5eTl3RStZ3PwkwVQ; Mon, 10 Aug 2026 23:05:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=ppford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Content-Type:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=selector2-azureford-onmicrosoft-com header.d=azureford.onmicrosoft.com header.i="@azureford.onmicrosoft.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=ppserprodsaar header.d=saarlouis.ford.com header.i="@saarlouis.ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To"; dkim=pass header.s=ppfserpocford header.d=ford.com header.i="@ford.com" header.h="Cc:Content-Transfer-Encoding:Date:From:Message-ID:MIME-Version:Subject:To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=ppford; bh=jFi6vT+G3M9XgtperboMkEKVM iDctPqboFi4Th2huLY=; b=q/0vVYc1/lUCXIQ6B3VT55FKMnxmRA6/VqdvTCFR3 XhBfMF1NnIXGGkoMtKq0FmYWa0AQhFoU6A5m15oZznoOxlQxr2xYwA/cyb8xMun4 0kuoZFNErvWjSOB6SxGsWqtSEZCAFRixwebY58A1dNe8b8m/5FKGtmiqkSPS4X4T zFg9Pec5XpHn4F1JQeeYR62HebfKTtMsJwhwCtbHmEN6U/OMKapCjdh0CBAV7wSB GWWWY76GtW4jQMQPjzO0OcX9UecC6VGtexDsO+I1FtMjGv/PINzZGn43IV17XYvq A7raPYefrXH9vVpMS21Jc5CCEElOdXATapHiWH/E94hvw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CJK4LVYZXNE+jeu8AxTLPM9Eo8FBjGx4fWMU1eHw5lCtNk91o4ITC3KUnblqUKS4YUBlKsb7M10YARtl81K2l/Qejz5bItNc8PdUgjfL6nla/AzRSTNv52cf6SmtPu+HrHQVwxUA02cZeFkbue3AlrCIEFoetZfGaVlg2wS2CQhOpm87B7TnKmTIAYev47E6Lo2I5pvYEf38F5d2iFrJoVk+5DuXdcor8R+ZPaMlI+o8RL3bV5DqCigVLuoYCxqitfnBUXGpe7BtcTsjfRU3kcj48+v1ZPkb5ue90AGktgs/5syhLdqlAP4Txq1n6ag69o/c8xkOErhhZqwzkiVKhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFi6vT+G3M9XgtperboMkEKVMiDctPqboFi4Th2huLY=; b=BkgWCmS5dFtzg/LjBOO2JD1jugSc7hSG6QXRzxtt93ndIT7iPdvPjOEfAoauAbzNv56F+bko2r/zTPgR8ckgPrrVTifvwqjzFEijGr8ICVcz4E/Vug+gTJL6Q4BEjlmU/Zs9soEb9ll0sPuPwXsSCTcikK3/ydAWp+87s4M1f3JBWU/7x1BNb4M3qCEAS9/3Z3Xzxwqom2ZvHI4Cf3mFPndRzzEG08UWDFp1pJczKFSu2GpJeAD6AlyvKUjT6o5VlICbDC/FfPnDkvJ2ToddCjb0tKc6T0wdEcw81URzxTmCgwsowrejaEPU+EiBs5X1x9zweloBnLIUNHJjXaMNcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 205.220.161.53) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=ford.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com; dkim=pass (signature was verified) header.d=ford.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azureford.onmicrosoft.com; s=selector2-azureford-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jFi6vT+G3M9XgtperboMkEKVMiDctPqboFi4Th2huLY=; b=lrsHkh3U0YWXqvn4DQ4A+bGMALFlUpq3McldWt6SCiiUsjtOAG3AsPz0UK2NPwqWJoEF2/Xb/h2gatXlIn78bVuGKRCJ4n4HuVOockAw2mzB2I2RVjMIelAHH50/O5S9s/Y7K4wdR55soSc/t63V94xQWb9KdgezkZCxGId7JfM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 205.220.161.53) smtp.mailfrom=ford.com; dkim=pass (signature was verified) header.d=saarlouis.ford.com;dkim=pass (signature was verified) header.d=ford.com;dmarc=pass action=none header.from=ford.com; Received-SPF: Pass (protection.outlook.com: domain of ford.com designates 205.220.161.53 as permitted sender) receiver=protection.outlook.com; client-ip=205.220.161.53; helo=mx0a-00498f04.pphosted.com; pr=C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= saarlouis.ford.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to; s=ppserprodsaar; bh=jFi6vT+ G3M9XgtperboMkEKVMiDctPqboFi4Th2huLY=; b=V+VBQ6UIgCo4Uo7dkVS/hTS /d88oYYfv8xDkuT6GLYh1m55HjL41ln8MfojgQ4QpQGkUf6G2C2VOvwe9Ds8Xz8/ Rr8poB9gAL6aYl/k9ezHNYi4l4RnxKScFEpdpvFm2olXLJQhcv5gIwHeFWm/DgNz +XSVoG/WRKwas6FcKO+KOGNpbBlEcy5DsDIXugSnajD6G3dfYjnBe+zflc+HmIfc Vxi+pRdjOsm9yC+rfOFjN8ofPnQlQTfGvFRS6k/TlGVJe6m5k//2hEG803uLCFQq Ah5IEiiMYNeBIODAOllA4hc3fIGkA/MWUCACbVX2aKwKTLF9HGYEBHRpWdqzZcQ= = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ford.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=ppfserpocford; bh=jFi6vT+G3M9XgtperboMkEKVMiDctPq boFi4Th2huLY=; b=JVzRaU82vKkPHpeV2+yltrENi11ncrXwTdDTALt/fS2cmqx S1H2YL9kVHoLNa0HlMkNvPd+v4ssSrNDHe+8L4gYCqZnOJq+LMF8hs4bFNRigMXY rPAxhOM82TXl058+pTBqebCl42pqvT9Zbg8MJiTAhreKudF9WmokT1apUvDtXCQb vFer2XCCvDfDFAuMsblzlqu7kaRIa9gZn0ZzCeUjLyHm3CUDGlkdy+cM7n8OpsI6 ol2CL782HJ4qiXR5gNV754rV2i9Szh2fHPazrU9/xlUtm6/RGqbqIELMjXeZjkpb fZDiYwbkjgoWltnlkp34fqBY7cIk0QcUMQy/8dQ== X-Mailer: SER-76bead168636dc6ed1c9e51ce4dea80dbdd4163750742b614a4d871e565792b7 X-Cloudmark-MID: tZ3Owq5eTl3RStZ3PwkwVQ X-Proofpoint-CID: eb09f7eb-2dc2-34ab-a188-7b293c1db1fe From: dmukhin@ford.com To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger@xenproject.org, sstabellini@kernel.org, dmukhin@ford.com Subject: [PATCH v3] xen/common: add keyhandler to show Xen command line Date: Mon, 10 Aug 2026 16:04:01 -0700 Message-ID: <20260810230359.671587-3-dmukhin@ford.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PSER-M365-App: SER-APP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_06,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100196 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C9:EE_|LV0PR16MB6940:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: c6d0764d-b89f-4265-389f-08def733d5e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|23010399003|82310400026|13003099007|3023799007|11063799006|56012099006|10067099003|18002099003; X-Microsoft-Antispam-Message-Info: vuitvFHZhYrPGf1+gKNrSbzIShxVgKZna+mzKGQGYIcXHZs7TsB4zx5IxB4MScp8CvZms9AtwyRZZZfYgjBhrbsLZfPJ0DhFkF32nqxduB1spWlSzOo9QqV7x3bZpvNAmxH2s6xNMGJb6lfjHBHMZfYLpxzxCUsZum+3gFwiYHOS+OmVjrZt6jvDg6r15m83L3jCnf6G74llYLVih7JxRjfVY1YY1TNY8o5lYFnUswRchPBzNkTjT3p8WU0CFnGVdMLhPLn4RCD+NBfChasTnkaoNi2AeyMQ2+aPAg+UzdZ9V4c5PzWnGNA7EQaQ5mcTcTLepqYRue3geLZTG9D9eLuvoLua7dvHszsYTdl3wFxxRWzwZ2KcPC2lI7xwIVW/5eau2kpb6SDznVTViYzq2tOzl+8D2UVCuoJ+VcoEJeHX7rJrLl9gJasbsHynrV21sD5IPyivVN0cs6DWFeSDh5V1b0j04L1TGCsit9TxQi1Twv6Rtl3duBKIoE3WHiH0nVNj0dz7dqNGAGgrN1G3o8hvZ7mxG5APgEUMh393zsBs14nvV+Yl4J22Edb9XMzKFKNvlqD2+djNSCa6LyDfSYpTzB82PQRhVImTycMX/kyJdtXMipGVSX3eQ8zpZWW1/Mja4af5w8kNuzfES3D9dWdHa7+DmwqkD83gHx26oKh/B8JZAtnJWkIRl07LnGdEo7yy0TmE2CN7zr1zie/e8g== X-Forefront-Antispam-Report: CIP:205.220.161.53;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mx0a-00498f04.pphosted.com;PTR:mx0a-00498f04.pphosted.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(23010399003)(82310400026)(13003099007)(3023799007)(11063799006)(56012099006)(10067099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Xh2/dIp+cg1QUh7LAvgK/vF8c0wXH3uVnvhmsv6ZL4mYTU4cAALOefwqtoJT+v5UXGgpQx/3KSX8hp76+8T8oZEfrBcOev6e5XnK/N0BkV9m30HBQ6bBVAyHQIibfZvmRcHf5m1AaCwz1LQS1V8vJqqkauW8meEMG1pAYOEX1E/JdPLOcPf7HzlGnCZ57y12wa9nZONCMQxAm6/9f6ewNm7RPtjqJ/d4eNN3iq5At3NwZiiLeobiipsh8oP9gou8JOLbaD8mXd/786qOzSuhhipwcAzBOnZsggdRaS0/aX0t5k5tqIbGzHNPdGyfaXYyrvrapH+F8+63o1yLN8qX17E6cfnSbgBG9hVNcgVdSbdQf2sGhOff4E0W+alNuLaxA+Ui8ZXj5ofR2oRvjBH73IxXdGbyyhgI5fnj2iW9mBVnCxfDt6d9L7Nsb1ObXYyJ X-Exchange-RoutingPolicyChecked: JMfoK9UkcLjYp2xyCV+YTmMGvu3Up/iWDD+e/3aSnUbsFowLEiZmU6gtemLPVbD1QCE9Z7iHTyl83QZrScprSaatpKkyQnVde3gnT2Bi9oMGytUzGszN14iUnsXxsSrQ7dfOMCaWhlzzJRj5UkSBmtBgTI/+3DJMiyog1qEalbM5/4k6bjmUeWY4d3BavRPL+evw8OAnnhl2hkoaSvfZ80FcGlXZjV8KWEcAeDejsU3VGfUSIeW/2Cxm2Jr2gngTetoF2B6V59eRUSqOdhvDionxtudwWpbh1Lbb7XlQVvFDXYc5epMnZrw02hKFTdT61b7gBNoGaI6GKOikjOdyXA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZUIRppqxaCimA3oxTWYXsXczfbFaMpF4092OkTF6pDdZFVSAAL2ZSYpE3v6k7kdRxT+0bJwzx1rsPPDzPmz7z12ES89qAxelSBojfOXEWCRel54h4cKmCmt3uIWdmBHj6kjue1GEwQIrw0m/cCocItzInE2OsNenq5Vkqe5StjOk7E+6RgbZlcqF6wj4tqhuM0xo+3fK/3SUKmXBb7J6WLSJ+nG287bc4StN4xyiGIRV4qiO9zMY67rYkH9nwFXNSbqbZTLrRaDzh89afnUSFy9vsuAUyW6OMtDvMZIiFWoTI7GzY0jkyfV9KyPywBb9G5/gdURmobjd94BS3cbCsIFMU2Ypt08OZ/M7Yg49P60niqHUJdsuYsJp9zD6H1WVEmTb0A+1OnyLK9zYhK0tiCS8BLdFV7k2Kedvk4pzLbmsk6wsqxUn0iZYNvJR2KWWJCdUvm038DNGXJXsVgIM2lFb9znay+vHEvP564WH/Uc8tm0A5K+VZVIcD6gnYWoiyxbhrzmyiw/ouhq9x83G/w79WTs0i76E+bT5TJpboOx6IvCkpNu+soYfF0BIcZ6KcKcNXc0Z1UjwGit1g2yVGq8BM7/klyhLPKj5+lf8+sqqCH/JSoFFBfHqnL764yFoWOS/RitF7RFQpY/+feR3Nw== X-OriginatorOrg: ford.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2026 23:05:13.6425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6d0764d-b89f-4265-389f-08def733d5e2 X-MS-Exchange-CrossTenant-Id: c990bb7a-51f4-439b-bd36-9c07fb1041c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c990bb7a-51f4-439b-bd36-9c07fb1041c0;Ip=[205.220.161.53];Helo=[mx0a-00498f04.pphosted.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C9.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV0PR16MB6940 X-Authority-Analysis: v=2.4 cv=NtbhtcdJ c=1 sm=1 tr=0 ts=6a7a592c cx=c_pps a=5zjvB78PlnLPEzvzEo0MXg==:117 a=lOEMawUel/sSvQipkIvNbg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=Sv0fKeRqtYgA:10 a=3PXLN80vpJUA:10 a=6NUGLSImWEsA:10 a=w9pew1qAHqMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P_n1zlmtWsCQbjROFjcg:22 a=X3KReqg2EL6A36SYCKpz:22 a=VwQbUJbxAAAA:8 a=cbNQJ9GKAAAA:8 a=p0WdMEafAAAA:8 a=IgJ0wlFFhhnA7GDi3u4A:9 a=DqJYxgmhk6moR-_7_KoZ:22 X-Proofpoint-ORIG-GUID: cRh6SSY4zNNWz4sP3tox7hMakk_HzU5p X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDE5NiBTYWx0ZWRfX4bkUozXC1RCu EqKkQt18PKdj/Iwu1iVuwMcbsrKzGsW802GcxTvM4l8jKz1SNfEvvj9kvWjpv7e948qtjOjphdW rRbVvLzsJpNnNSqBFV2scu1w41sR55RdJV7rbN1W6E+bT96VYJ7t X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDE5NiBTYWx0ZWRfX3UvjMoyS0g6u 4Bl82loIoDqYwcGZgih2vFYmEsQ+HAOrUNKk0YCw6llVdsJOG7BsylcV8/6ya3EpewQfenYxY6e 6seyXINwnmPrg+OvmFLHGBUdELjiKAI6tUYlXOggpw151aIMJtv/5ggnts7uNqrh9SXDBdIrcyA EXCzGPvauYa+NgA+8zei8BTQ2UI7n46eDueBSwX67NTIRxyhO8soAzcnhYo31PPKgd9MWaHOoh1 WeBNJSxeDWBgfCbxbWXgmK7pFD1UFJcKUq/nI1W5d1xHJdlr/24CNcVde+MjNitS15AlxFkmaFd OeWqqjShLA9sGWJp12eElmU5Izlyo9YzraIY9E5dYcurcYiIUK9t9CoJvy1HRgyX33Jb+hOcPrh nW2vip5oHJjJ1Hl9sdydKvcgYl039bGLAKhVJ5e4iGr9ukRn88tg2PqL2FBYdE0ZjXkxSMUu/LZ JyDE2SHxyL8r1fTC0+g== X-Proofpoint-GUID: cRh6SSY4zNNWz4sP3tox7hMakk_HzU5p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_06,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100196 X-purgate-ID: tlsNG-bad1c0/1786403119-BECDF034-E28B115F/0/0 X-purgate-type: clean X-purgate-size: 1712 From: Denis Mukhin Currently there's no way to print Xen command line on the emergency console for debugging purposes when 'xl' is not unavailable. Add new keyhander 'X' to do command line printout. Signed-off-by: Denis Mukhin --- Changes since v2: - account for CONFIG_CMDLINE_OVERRIDE case - use IS_ENABLED() v2: https://lore.kernel.org/xen-devel/20260803070047.3097846-3-dmukhin@ford.com/ CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2748655201 --- xen/common/kernel.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index d1bef9ac2b2b..54a7ee6f68e5 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include @@ -505,6 +506,25 @@ static int __init cf_check param_init(void) __initcall(param_init); #endif +static void cf_check show_hypervisor_info(unsigned char key) +{ + printk("'%c' pressed -> showing hypervisor information\n", key); + + if ( IS_ENABLED(CONFIG_CMDLINE_OVERRIDE) ) + printk("Bootloader command line ignored (CONFIG_CMDLINE_OVERRIDE=y)\n"); + else + printk("Command line: %s\n", saved_cmdline); +} + +static int __init cf_check misc_init(void) +{ + register_keyhandler('X', show_hypervisor_info, + "show hypervisor information", 0); + + return 0; +} +__initcall(misc_init); + static long xenver_varbuf_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { struct xen_varbuf user_str; -- 2.54.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 02:36:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 02:36:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387940.1629167 (Exim 4.92) (envelope-from ) id 1wtcLd-0000Dl-2l; Tue, 11 Aug 2026 02:36:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387940.1629167; Tue, 11 Aug 2026 02:36:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtcLc-0000Dd-Tt; Tue, 11 Aug 2026 02:36:12 +0000 Received: by outflank-mailman (input) for mailman id 1387940; Tue, 11 Aug 2026 02:36:10 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtcLa-0000DX-ST for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 02:36:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtcLZ-007ag9-ID; Tue, 11 Aug 2026 04:36:09 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7a8a77-bab6-0a2a0a5309dd-0a2a4506c15a-20 for ; Tue, 11 Aug 2026 04:36:09 +0200 Received: from [74.104.188.4] (helo=mailhost.m5p.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7a8a97-195a-0a2a45060019-4a68bc04abf2-3 for ; Tue, 11 Aug 2026 04:36:08 +0200 Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.18.1/8.17.1) with ESMTPS id 67B2ZxfO029994 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 10 Aug 2026 22:36:04 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.18.1/8.15.2/Submit) id 67B2ZxqK029993; Mon, 10 Aug 2026 19:35:59 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; none Date: Mon, 10 Aug 2026 19:35:59 -0700 From: Elliott Mitchell To: Cody Zuschlag Cc: xen-devel@lists.xenproject.org Subject: Re: [ANNOUNCE] - Call for agenda items for August 6 Xen Community Call @ 15:00 UTC Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS, T_SPF_HELO_PERMERROR,T_SPF_PERMERROR autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on mattapan.m5p.com X-purgate-ID: tlsNG-16d1c6/1786415769-FDE0E77B-5E2881C8/0/0 X-purgate-type: clean X-purgate-size: 4863 On Tue, Aug 04, 2026 at 05:30:50PM +0200, Cody Zuschlag wrote: > *Preparation* > > 👉 Please take a few minutes to review and update the agenda before the > call: > > https://cryptpad.fr/pad/#/2/pad/edit/eqPXghB7GwT4OuySCjSQRyVD/ > > Feel free to: > - Add topics or project updates > - Suggest anything we can drop or defer > - Include links to patches, mailing list threads, or documentation where > helpful > > The agenda also includes the meeting link and a link to find your local > meeting time. > > > *Call Details* > Date: Thursday, 6 August 2026 > Time: 15:00 UTC (agenda starts at 15:05 UTC) > Join: https://meet.jit.si/XenProjectCommunityCall > > We'll open the room at 15:00 UTC and begin the agenda at 15:05 UTC to give > everyone a few minutes to join. Took me a bit of time to consider what had been said in order to come up with next responses. I didn't emphasize it during the community call, but the point was explicit in the most recent posted message: https://lore.kernel.org/xen-devel/ajr0gN9kmPkLQlGF@mattapan.m5p.com/T/ This was previously allowed by Xen/ARM. This turned into a bug when the Xen/ARM team decided to disallow multiple mappings of the shared information page. During approval the Xen/ARM team was explicitly asked to accept the task of updating outside projects to deal with fall-out. I don't recall the exact wording of the agreement, but this is certainly fall-out from that change. As such this IS an adjustment the Xen/ARM team agreed to aid. I've already generated a PoC, I had thought the Xen/ARM team would be better acquainted with whom to ask about getting a patch along those lines in. That seems a reasonable ask in light of the team having accepted the task. I don't know the Xen developers by voice. As such I don't know who mentioned 'firmware = "ovmf"' when I was trying to bring up Tianocore/EDK2 as bootloader. Now that I've checked by notes, whomever brought that up was quite unfamiliar with that I was trying to bring up. The 'firmware = "ovmf"' setting is part of HVM domain configuration. In this environment Tianocore/EDK2 is merely setting up some ACPI tables and then handling the task of finding and invoking the OS bootloader. Since all the hardware is emulated, Tianocore/EDK2-firmware isn't much different from what it normally does. I should also note this is fairly slow. Despite sharing the codebase, Tianocore/EDK2 as bootloader is very different from being HVM firmware. In particular the arm64 Tianocore/EDK2 configuration is "ArmVirtPkg/ArmVirtXen.dsc" and the build creates the file "XEN_EFI.fd". Once built the domain configuration is along the lines of: type = "pvh" name = "somename" kernel = "XEN_EFI.fd" memory = 256 vcpus = 2 vif = [ "somenet" ] disk = [ "somedisk" ] The result is a PVH domain with Tianocore/EDK2 functioning as a pure bootloader. In particular it is capable of searching for its preferred filesystem, then looking for an appropriate filename and then loading that using the UEFI protocol. The result is near-ideal. Of note I'm pretty sure Tianocore/EDK2-bootloader would happily load EFI-GRUB. More importantly though OS bootloaders which can handle UEFI work perfectly in this setup. I expect this to be superior for *BSD. There are two problems with Tianocore/EDK2-bootloader though. First, is the aforementioned unresolved bug. Second, this is only implemented for aarch64 (arm64). This is a problem for all the paravirtualized bootloaders. They're all single-architecture, despite the bootloader supporting multiple architectures. On that single-architecture they're quite good, but Xen really needs them on *all* their architectures. I didn't get the chance to finish my suggestion during the call, so here is what I wanted to suggest: I think the Xen Project really needs some effort aimed at the paravirtualized bootloaders. Mostly making them operable on all architectures they support. Paravirtualized GRUB is needed for ARM, RISC-V and PowerPC. I don't believe Tianocore/EDK2 supports PowerPC, but I would really hope for it to become available for RISC-V and x86. While U-Boot is difficult to deal with, it would be valuable as a second paravirtualized bootloader for PowerPC. Once those 3 were available on their applicable architecture it would be time to purge PyGRUB. While I imagine this will take a while I think it should be on the roadmap/panciled in for the future. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 07:06:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 07:06:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387957.1629176 (Exim 4.92) (envelope-from ) id 1wtgZ4-0003NO-7k; Tue, 11 Aug 2026 07:06:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387957.1629176; Tue, 11 Aug 2026 07:06:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtgZ4-0003NH-4s; Tue, 11 Aug 2026 07:06:22 +0000 Received: by outflank-mailman (input) for mailman id 1387957; Tue, 11 Aug 2026 07:06:20 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtgZ2-0003NB-8n for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 07:06:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtgZ1-00GoLI-LG for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 09:06:19 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7ac9ea-8faa-0a2a0a5109dd-0a2a4503ab66-8 for ; Tue, 11 Aug 2026 09:06:19 +0200 Received: from [52.101.85.7] (helo=BYAPR05CU005.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7ac9e9-fae8-0a2a45030019-346555072a89-3 for ; Tue, 11 Aug 2026 09:06:18 +0200 Received: from MW4PR03CA0314.namprd03.prod.outlook.com (2603:10b6:303:dd::19) by IA4PR12MB9788.namprd12.prod.outlook.com (2603:10b6:208:5d5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 07:06:13 +0000 Received: from MWH0EPF000C6195.namprd02.prod.outlook.com (2603:10b6:303:dd:cafe::7b) by MW4PR03CA0314.outlook.office365.com (2603:10b6:303:dd::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Tue, 11 Aug 2026 07:06:13 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by MWH0EPF000C6195.mail.protection.outlook.com (10.167.249.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 07:06:13 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 02:06:12 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 02:06:12 -0500 Received: from [10.252.145.116] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 11 Aug 2026 02:06:11 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kn/M62Z4hW5SAd84ScCcd2mugKjCR8r/W5s4p4k/MV3FwgqWbCezbcFj4ZohgUKKJWDu2yCSKa7xMoJqN2IlXgcTeqFPoM7mnfuO6iHt3FPJHaYYEdCxhe6R0FOX4RFAu4THGXS+NYHb3X0VRb1YkwHFIAmg3cFDB8ns0mYemUjXoA8/3McfzakOOChqXaCRRZ/0u7inKdfFb/To6qVc7/KnMki3IHhG+tuDizhJ7uoX+29sfILNeApSgWXeeLTJqwjuHdQUT5CQKmT9lwks1W7Y8CxaZEVhqXTShRP0sdLmCZv1hKCXqKHc2qAi4atYZhMHXp1wL8BR3ghfNHQbUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u7Z9+tFRgouVypaJqTuXKRlijZUwRSBavXXjWIWJZOY=; b=CzlPH4W5NqDYzZ5/o/N6RuqSIfRBjuhSdFtiyzOzBxcXMgH8mL3fu6BqP9WVG1JgNpq3LVMtdidZNEX6EmcqPRkJzNUl6u54U6W9PPwJqEmAwY+BEIMepk/YSUlj5m9m95CqQBQXWzIIsUJ8Z41jVCiA923vcyVoC35acFatY9eGFPCsEXCf7rSZImuORuHDyz+ZHf4v3J0G7cYI6vpEIZjYyN0417reFQ1FOeT5YPqrCHtM4qF7hNJx2gFPFOKqIL+6alfAga28tnY/vj/dff6YDcPFomEts4zRPu90i0Zm0FR5LyoNNMO1n60OFTzOm4Q91mZgFAypmQ1XziFH7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u7Z9+tFRgouVypaJqTuXKRlijZUwRSBavXXjWIWJZOY=; b=1cjzDSdlscDdBbNBkZ6fvCi9GSUpD5ti44X3VgJZUoEJoRTExsGcL6KAM/qjTEz5b59LURLQinz/SdTmWC5g3ktOlHQ5C+QamcUOBKRrml95ka9qzsaLjmbLbCYgMhRqc7C142gu1mtWnNGs7EBM5V0g1bpZWzRvQ1LhDNm8ij8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Message-ID: Date: Tue, 11 Aug 2026 09:06:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] xen/arm: propagate secondary GIC initialization failures To: Mykola Kvach , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" References: <58b886c992ea72210bb2f32afc392b458efe02f2.1786389451.git.mykola_kvach@epam.com> From: "Orzel, Michal" Content-Language: en-US In-Reply-To: <58b886c992ea72210bb2f32afc392b458efe02f2.1786389451.git.mykola_kvach@epam.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6195:EE_|IA4PR12MB9788:EE_ X-MS-Office365-Filtering-Correlation-Id: 6bfb14eb-5aac-4d45-8cec-08def777076d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|23010399003|1800799024|376014|18002099003|22082099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: uZTK9wqNnq830Nm3oNLMLg73PLtVOOTFezns9QsgDg+TP5OuB/eIKiXFlALSnKw+8I+TXHXwnHxXdDaaKfnxfQfCW28bi534x9a6zfDusFiPprFBKXMlOv76+QUnj07Qgk9R5YJy24MomIwUglBm4W5Oj8XJ2uY7finJkevAO4BKxALG07EUyVnALkwOTWcubn1PMk+Utm8Zm+equX6g0oXRVjN04r58Mtb5cZlWO3SgtL82qS7cYaXOyZMVKWNzJ5tTbf0krLLmFEybAUsofltVrrgDxe8judbCAGyBHxOBzyqDDUGftPx/VbpzqvRrCxJGipEmRz4XFa0MKc6A8IvTQka2YkKMXHARrGXsvNnr3oexQM4YhFLkbvNQImTbZMZ4QAEQtdOczIn92/gRXrPtxHt+6acIIl3auRut88EODlX7d3nilR7HgExbEQsR6jbXu+zQ+BG86l4iWxldIjgqWBDfVCUwULqEdyGQbJ/KdkYOiE4AsgrVxJI9TBlqQbhZs7KtbhXKkF88Pugk+x61ZOfgLk/astv/8HOrekPaa8voRAvYIoWKMJFx1aOja1q2LoLm7Jsl3MPxIoISAtdhXLP0jNHLuKRh7YM2ZcYrtfNgdhXqQoSxYiOEMXfYmMnnzqzRODP1h5aFdqtD0hebCLuYB5yqWraSfR5x3ZnhOWcOno01yWb6x0JmeLn2JV8E55xrDyvhF4DKLWSCyQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(23010399003)(1800799024)(376014)(18002099003)(22082099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lnwOEEVqIo1uo2pYae/lbgFiFl5km/m4YiIXPVUO6u2zEnaVpkondIxTF0MGjOd5JcygKA0PwfE4Wwkv9ZKULt6+TxAI7Sa3S8kJp/FUQPtZwgDD01ZUJ9X6UqRI6ZSXJfM0ZvQ0WPTzW7nk4D3UVjvqMEG6BHAR3qMzLZ8uH6yRCpmEnVX64O9mIi5n6S+6tjrenXZ8mW1c7sbxlP4DPJ932cbypY9AtxyV2cNzZAmQENnevoWIpA1ZjwAyDX9BSjUEqgyv9uVFEnDB+ednRCwRetoHmRsdTA4QEzkHn069sGHwe1AFSEMagS0Z8zgXK0LIORxyMRO1XjJh5OLDGuc0JT51tXFj4cfSUlZtMkhLZnNY7rO29ADjUR2nGTF9AI1NYQkcRFiHZYqdyoAap/rnUJ4reRNabnGQFB2QQa22BIeOAPVMJz4iAkaGfjNE X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 07:06:13.0212 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6bfb14eb-5aac-4d45-8cec-08def777076d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6195.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR12MB9788 X-purgate-ID: tlsNG-33051d/1786431979-6F8C54E9-DC663110/0/0 X-purgate-type: clean X-purgate-size: 738 On 10-Aug-26 21:41, Mykola Kvach wrote: > The GICv3 secondary_init() callback can fail while discovering or > waking a Redistributor, enabling LPIs, or setting up an ITS collection. > gic_init_secondary_cpu() currently discards that status. start_secondary() > then marks the CPU online even though its per-CPU GIC interface may be > unusable. > > Return the callback status through the common GIC layer. Have > start_secondary() report the failure and stop the affected CPU before it > updates system features or is added to cpu_online_map. > > Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3") > Signed-off-by: Mykola Kvach Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Tue Aug 11 07:48:25 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 07:48:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387979.1629191 (Exim 4.92) (envelope-from ) id 1wthDd-00012u-C4; Tue, 11 Aug 2026 07:48:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387979.1629191; Tue, 11 Aug 2026 07:48:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthDd-00012n-7q; Tue, 11 Aug 2026 07:48:17 +0000 Received: by outflank-mailman (input) for mailman id 1387979; Tue, 11 Aug 2026 07:48:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthDc-00012h-Az for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 07:48:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wthDb-00GI3u-0k; Tue, 11 Aug 2026 07:48:14 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wthDa-008A7l-1z; Tue, 11 Aug 2026 07:48:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=oXJmNSnU5V7rY/kwedMvqgDw8RAbb8RVEHCCWmM35dg=; b=CvBJMdBsShf/vPkbA7cJP2207t qm+6ImerU8RBj+fesqRwM9s0M+rjnlNTA+sLV+KiryUKauBTkYLdTw5IiOISYry8vFEOjwzS8mDJK vFhBD+Iil3Zgur+7MEq5Ufq5SL8Saaer32nOAFYtT+o6XhOTed8XxdYQRVRJPnRaKUt0=; Date: Tue, 11 Aug 2026 09:48:05 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: dmukhin@ford.com Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, sstabellini@kernel.org Subject: Re: [PATCH v4 2/2] xen/console: add compile-time rate-limiting controls Message-ID: References: <20260729072520.1556970-1-dmukhin@ford.com> <20260729072520.1556970-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Aug 10, 2026 at 10:56:15AM -0700, dmukhin@ford.com wrote: > On Mon, Aug 10, 2026 at 03:06:35PM +0200, Roger Pau Monné wrote: > > On Wed, Jul 29, 2026 at 12:25:20AM -0700, dmukhin@ford.com wrote: > > > From: Denis Mukhin > > > > > > Introduce CONFIG_PRINTK_RATELIMIT_MS and CONFIG_PRINTK_RATELIMIT_BURST > > > for configuring rate-limiting policy at the compile time. > > > > > > Use symbols for global rate-limiting initialization in the console driver. > > > > > > Signed-off-by: Denis Mukhin > > > --- > > > Changes since v3: > > > - added note on security support for non-standard configurations > > > - gated menu with EXPERT > > > > > > I kept both settings for now. > > > --- > > > xen/common/Kconfig | 36 ++++++++++++++++++++++++++++++++++++ > > > xen/drivers/char/console.c | 6 ++++-- > > > 2 files changed, 40 insertions(+), 2 deletions(-) > > > > > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > > > index da80fdba8469..749d3bfb08e0 100644 > > > --- a/xen/common/Kconfig > > > +++ b/xen/common/Kconfig > > > @@ -672,4 +672,40 @@ config PM_STATS > > > Enable collection of performance management statistics to aid in > > > analyzing and tuning power/performance characteristics of the system > > > > > > +menu "Console rate-limiting" > > > + visible if EXPERT > > > > No strong opinion, but there's a drivers/char/Kconfig which might be a > > more natural place for those option to live, and then there's no > > reason for the extra menu? > > I had the knob initially in drivers/char/Kconfig, but moved to > common/Kconfig to address Jan's feedback: > > https://lore.kernel.org/xen-devel/2eba7de1-a8e2-4c45-affb-8ecb91278707@suse.com/ OK, as I said, I don't have a strong opinion. I think we want to keep drivers/char/Kconfig for console driver specific options, but not generic console related parameters. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 07:51:58 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 07:51:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387986.1629199 (Exim 4.92) (envelope-from ) id 1wthH9-0002cB-Pz; Tue, 11 Aug 2026 07:51:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387986.1629199; Tue, 11 Aug 2026 07:51:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthH9-0002c4-Mq; Tue, 11 Aug 2026 07:51:55 +0000 Received: by outflank-mailman (input) for mailman id 1387986; Tue, 11 Aug 2026 07:51:53 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthH7-0002bw-Po for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 07:51:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wthH6-00ABx2-OW for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 09:51:52 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7ad48c-e002-0a2a0a5209dd-0a2a4507dee8-34 for ; Tue, 11 Aug 2026 09:51:52 +0200 Received: from [40.107.208.22] (helo=PH0PR06CU001.outbound.protection.outlook.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7ad496-b4ea-0a2a45070019-286bd016a725-3 for ; Tue, 11 Aug 2026 09:51:52 +0200 Received: from DS7PR05CA0064.namprd05.prod.outlook.com (2603:10b6:8:57::26) by DS7PR12MB9042.namprd12.prod.outlook.com (2603:10b6:8:ed::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 07:51:46 +0000 Received: from CY4PEPF0000E9DB.namprd05.prod.outlook.com (2603:10b6:8:57:cafe::89) by DS7PR05CA0064.outlook.office365.com (2603:10b6:8:57::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.12 via Frontend Transport; Tue, 11 Aug 2026 07:51:46 +0000 Received: from satlexmb08.amd.com (165.204.84.17) by CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 07:51:46 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 02:51:45 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 02:51:45 -0500 Received: from [10.252.145.116] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 11 Aug 2026 02:51:44 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hAGpHAicgx35TO2oCJekulLCgmf/wFMsEfVlioh0qmPkh+gy8ebIOv156gtxE9r8Qw6PygByrUet6TmaU8r/+dZ3s7kVEjLI7GLCfVwjbn16XGK87QsrmSVAa9xLWIQu0sa+MlHHh0gXhipvHeL3mqty1Ufvw1cuIOESiR6TlntR0xlaixuO3snAaS/PptnTsMxvYZUUl9vgn0LGzzgJPepatYvdqozPJKBFy18G/CeGkR9nhQf1t1tSKgAJGsS2xSs/Dyp5nEbZxMrH2S+V7qgReN92leKjOlL+Q1AgUP2wr56ShZyxBlJXog6J1GCnh38337vg8MoOedGlFQJNzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6KvQQPPl6ZqEavxPRXLTuVqBYEjVIkVXiIWArdy3D80=; b=vxGwvWmVLcJhR8+XDZWUAryNEpvs67JSfpjnCjWh4DNRRXs+kcGtgZULAofXgl9SqzQTTgb/je9+QWHUUBgJnRFZXT5BVByvncidBraIzOoGiqZsIK45A6n0dR0dYd0KbrVWQLCKMSfmMDWl/Ay/kf+7wujWBNjlRM09T0sm0I5bruYtGA9AySpaHPcerEc3TU0aQYBjv+EHFTuF2RVmkmrAjmuCLj0dfIvgv0r8/IEhdtrmqlkAQKm+yyvVOjfs7J4Rwy0ho3P9c6WpW0jESp6SUOYkGeaaoX7EJ/MC2nrP4BXYj7YLxC6ufB0deicRYR+9qPOks2L3Mlse5TojaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6KvQQPPl6ZqEavxPRXLTuVqBYEjVIkVXiIWArdy3D80=; b=eRYeanvpcLBJIafRtA0qwjh9CK5N3s/lEj90cWpflmtCI/GBgsMJ5mJY9J5SB7rpcdZLCUN4jsaDnqI0gEd1heaOI2Oy/y1dPImZl9DiaoWzBaR/U1+DwV8VRzQcbPU1Qbn0c0CfeF6thG3Nvlxd0MbCgMEb07Yf1/05P3AO0qo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Message-ID: <103a2e50-0391-4bad-b9e7-d00c36c76a54@amd.com> Date: Tue, 11 Aug 2026 09:51:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] xen/arm: derive GIC CPU interface ID fields from the vGIC To: Mykola Kvach , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" References: From: "Orzel, Michal" Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DB:EE_|DS7PR12MB9042:EE_ X-MS-Office365-Filtering-Correlation-Id: 738f86e0-adbc-487b-f280-08def77d64b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|23010399003|36860700016|22082099003|18002099003|5023799004|11063799006|56012099006|10067099003|6133799003; X-Microsoft-Antispam-Message-Info: mP+vpBqCkBJTfalQ8sZaDuLbemAnVXvf5UvtFMzblCl4tp43cylYiklOJnKlPTtR0s2eC2J02+bnUi0MyZnFpe+oWDkTZwEO5PYhyS6+5qLeJqG8Z7weiX1XymH4ngeXFJ2/IOQwgdGcgpRckhCGFIIjrqx2uPc/Ckl0ACIr2GRQ7EGE6LxCO3h6ZhtmZzGE6xHQ35EbTmjd3/EFlGNMJAELo3fonZSKiJ/Z5jpQXvqPe6T/H+Oc27JcIFpoQgFSZlUXFAe11COm+nVYvEXysTw1Zt7sG3C/TmUWLykhi9pA+BTDuRmRxX92wJsAnKQqNfzD1Yx5yJBZ9Nil2FiCNGyJRsVZtQ/U2MzgRl5hBRuXzxP29PoxOXnyaAra5UGr3u874OKA70BoW+DLXvPJncvJlgfSlzqyS/Xk/tfms91w00um0uO0PfwUqbJS9tSjeE8iEAm4jN5JpYtwL9js5fOCmksiX7KcMJ5QCf44Yf4NdtlITYH67MyDVQdEeFpqiS1GTCL3vKVixcWNvxxPgDom/J7G4NE9NWw4ybUBoblMnFiKMCkw7G0UyB8uOfcsOhYvuth3lcYaopt7CG9nMkH01YsbxpZf3mo638c+d7T5IS9Hu837uVHEPqH9fdrVb3hKfVNtpDB4Klv7zvpziw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(23010399003)(36860700016)(22082099003)(18002099003)(5023799004)(11063799006)(56012099006)(10067099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HZijFR9DwWWtItdqM+YSi7OVpkPvphzzFaDr7YR05aP1hjtr8ZDZkskxgw/w7asGmp6OVk2EhO4xJBUoOixi5ojg+rqkY2U/2oBnDpYfMHOEy3mYLg2JJR+k10t/RmEy8QdRBAMqPMvXFcEnKf9rDM1WOwa7SYshRbMCKXUvxrcza3bKkX1sqyYxnwHx4SBOWmaXClIRLSegZWKbLy3vr7GJtclp2EyZKT11vw8yoal9xeqDQprTVdGkDhbXokXhYGAQ6N5bHPX/OGi8tzFMDvroEvE39combWn4izX2+4Udu8VQA/WCuy7/RQyJ5m4Blyx322p6/0pohRFgnNOh+xkw2tB/3eAAaRws0RzDJ0TYulRxMjZD448uaAQo98asvj8/hnuSvyLruyvbOo/tTcoOEnwbZ+cjpINWnhVovMa0tTC63jkn5+ZFMTvPKhCT X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 07:51:46.5181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 738f86e0-adbc-487b-f280-08def77d64b9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9042 X-purgate-ID: tlsNG-ef75cf/1786434712-A46CAAE4-4D7E4F1F/0/0 X-purgate-type: clean X-purgate-size: 6851 On 10-Aug-26 23:12, Mykola Kvach wrote: > Xen exposes ID_AA64PFR0_EL1.GIC and ID_PFR1.GIC from domain_cpuinfo, > which is initialized from the sanitized host CPU feature state. This > does not necessarily match the virtual interrupt controller configured > for a domain. > > A vGICv2 domain can therefore observe a nonzero GIC field when the host > supports the GIC system register interface, even though Xen disables that > interface for the domain. On a GICv4.1-capable host, a vGICv3 domain can > observe encoding 0b0011, although Xen exposes only its vGICv3 model. > > Derive the fields from the domain's vGIC version instead. Expose 0b0000 > for vGICv2 and 0b0001 for vGICv3. This covers ID_AA64PFR0_EL1 and the > ID_PFR1_EL1 alias in AArch64 state, as well as ID_PFR1 accessed through > CP15 in AArch32 state. Leave the alias unchanged when AArch32 is > unavailable. > > Fixes: 07b9acea116e ("xen/arm: Add handler for ID registers on arm64") > Fixes: 8f81064a07c6 ("xen/arm: Add handler for cp15 ID registers") > Signed-off-by: Mykola Kvach > --- > Changes in v2: > - Share the GIC ID field helpers between the AArch64 and AArch32 paths. > - Parenthesize the individual ASSERT conditions. > - Preserve ID_PFR1_EL1.GIC when AArch32 is unavailable. > - Target master instead of the 4.22 release. > > v1: https://patchew.org/Xen/ba4f779d68c54efc80c4a566dca38ac2e6f9a073.1783675708.git.mykola._5Fkvach@epam.com/ > --- > xen/arch/arm/arm64/vsysreg.c | 18 +++++++++++++++++- > xen/arch/arm/include/asm/vreg.h | 20 ++++++++++++++++++++ > xen/arch/arm/vcpreg.c | 15 ++++++++++++++- > 3 files changed, 51 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c > index d14258290f..a02ad951f9 100644 > --- a/xen/arch/arm/arm64/vsysreg.c > +++ b/xen/arch/arm/arm64/vsysreg.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include Stale include? Nothing references gic.h here anymore. > #include > #include > #include > @@ -304,7 +305,18 @@ void do_sysreg(struct cpu_user_regs *regs, > * to identify the processor features > */ > GENERATE_TID3_INFO(ID_PFR0_EL1, pfr32, 0) > - GENERATE_TID3_INFO(ID_PFR1_EL1, pfr32, 1) > + case HSR_SYSREG_ID_PFR1_EL1: > + { > + register_t guest_reg_value = domain_cpuinfo.pfr32.bits[1]; > + > + if ( cpu_feature64_has_el0_32(&domain_cpuinfo) ) > + guest_reg_value = id_reg_set_gic_field(guest_reg_value, > + ID_PFR1_GIC_SHIFT, > + v->domain); > + > + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, > + guest_reg_value); > + } > GENERATE_TID3_INFO(ID_PFR2_EL1, pfr32, 2) > GENERATE_TID3_INFO(ID_DFR0_EL1, dbg32, 0) > GENERATE_TID3_INFO(ID_DFR1_EL1, dbg32, 1) > @@ -343,6 +355,10 @@ void do_sysreg(struct cpu_user_regs *regs, > guest_reg_value |= (sysval << ID_AA64PFR0_SVE_SHIFT) & mask; > } > > + guest_reg_value = id_reg_set_gic_field(guest_reg_value, > + ID_AA64PFR0_GIC_SHIFT, > + v->domain); > + > return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, > guest_reg_value); > } > diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h > index 387ce76e7e..24735aaea1 100644 > --- a/xen/arch/arm/include/asm/vreg.h > +++ b/xen/arch/arm/include/asm/vreg.h > @@ -9,6 +9,26 @@ typedef bool (*vreg_reg64_fn_t)(struct cpu_user_regs *regs, uint64_t *r, > typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, register_t *r, > bool read); > > +#define ID_REG_GIC_WIDTH 4 > + > +static inline unsigned int vgic_id_gic_field(const struct domain *d) > +{ > + ASSERT((d->arch.vgic.version == GIC_V2) || > + (d->arch.vgic.version == GIC_V3)); > + > + return d->arch.vgic.version == GIC_V3; > +} > + > +static inline register_t id_reg_set_gic_field(register_t val, > + unsigned int shift, > + const struct domain *d) These two are incorrectly indented (off by one to the right). > +{ > + register_t mask = GENMASK(shift + ID_REG_GIC_WIDTH - 1, shift); > + > + return (val & ~mask) | > + ((register_t)vgic_id_gic_field(d) << shift); Incorrect indentation: continuation line should be indented +1 > +} vreg.h does not include any header, so please add appropriate headers for objects you are adding. > + > static inline bool vreg_emulate_cp32(struct cpu_user_regs *regs, union hsr hsr, > vreg_reg_fn_t fn) > { > diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c > index e7c484f2c1..d6f9326b71 100644 > --- a/xen/arch/arm/vcpreg.c > +++ b/xen/arch/arm/vcpreg.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -173,6 +174,8 @@ TVM_REG32(CONTEXTIDR, CONTEXTIDR_EL1) > domain_cpuinfo.field.bits[offset]);\ > } > > +#define ID_PFR1_GIC_SHIFT 28 Move this to cpregs.h and remove one from arm64/sysregs.h to avoid duplicate entries. ~Michal > + > /* helper to define cases for all registers for one CRm value */ > #define HSR_CPREG32_TID3_CASES(REG) case HSR_CPREG32(p15,0,c0,REG,0): \ > case HSR_CPREG32(p15,0,c0,REG,1): \ > @@ -321,7 +324,17 @@ void do_cp15_32(struct cpu_user_regs *regs, const union hsr hsr) > * to identify the processor features > */ > GENERATE_TID3_INFO(ID_PFR0, pfr32, 0) > - GENERATE_TID3_INFO(ID_PFR1, pfr32, 1) > + case HSR_CPREG32(ID_PFR1): > + { > + register_t guest_reg_value = domain_cpuinfo.pfr32.bits[1]; > + > + guest_reg_value = id_reg_set_gic_field(guest_reg_value, > + ID_PFR1_GIC_SHIFT, > + v->domain); > + > + return handle_ro_read_val(regs, regidx, cp32.read, hsr, 1, > + guest_reg_value); > + } > GENERATE_TID3_INFO(ID_PFR2, pfr32, 2) > GENERATE_TID3_INFO(ID_DFR0, dbg32, 0) > GENERATE_TID3_INFO(ID_DFR1, dbg32, 1) From xen-devel-bounces@lists.xenproject.org Tue Aug 11 07:59:13 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 07:59:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1387995.1629208 (Exim 4.92) (envelope-from ) id 1wthO8-0003Rl-Iw; Tue, 11 Aug 2026 07:59:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1387995.1629208; Tue, 11 Aug 2026 07:59:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthO8-0003Re-GC; Tue, 11 Aug 2026 07:59:08 +0000 Received: by outflank-mailman (input) for mailman id 1387995; Tue, 11 Aug 2026 07:59:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthO7-0003RY-9X for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 07:59:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wthO7-00GIFN-02; Tue, 11 Aug 2026 07:59:06 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wthO6-008vX1-19; Tue, 11 Aug 2026 07:59:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=yuks5UgbK1jEMp3ty2xIMVbvZYC1PurOFUgY437blUg=; b=57TJr8BonQjCGJ6tMHHE0nz9jV rWubFn6Y4BQbVI5PtDj99wuJ+VvkngO0P/ku9qpU2yDKZHM5l8tdu5T+WP1PltI68z/qT6FT5dhIH KWTD5Ot/8WcO3l0dbFeF1PzFw6sFDM5bknltOyA66jM3ptQ2NLN+p9H1LwYSq+YWFyKk=; Date: Tue, 11 Aug 2026 09:58:56 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Teddy Astie Subject: Re: [PATCH] x86/pagewalk: Read guest PTEs with ACCESS_ONCE() Message-ID: References: <20260810221029.1520858-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260810221029.1520858-1-andrew.cooper3@citrix.com> On Mon, Aug 10, 2026 at 11:10:29PM +0100, Andrew Cooper wrote: > This has been a plain C read for as far back as I can trace in history. > > Research into invented-loads has flagged it as a possible vulnerability. > After careful analysis, it is believed to be a bug only, not a security > vulnerability. > > The code fits the pattern for invented loads, and it is a risk. > > The analysis suggests that we can read one value out of the guest, operate on > another, and that this could be an in-guest privliege escalation. Any entity > in the guest able to modify the pagetables already has full privilege, so > while Xen can potentially malfunction, the effects don't cross a privilege > boundary. > > The analysis also suggests that this is worse for shadow guests because we may > put the TOCTOU entry in the shadows, but this is inaccurate. What we put in > the shadows is still translated under the P2M and refers to guest physical > address space. > > Either way, harden the accesses. > > Link: https://github.com/xoreaxeaxeax/schrodingers-toctou/blob/main/observer-effect/audits/audit-xen-ptwalk-RELEASE-4.21.1.md#86-per-candidate-finding > Fixes: 49f7c7364e0a ("Replace shadow pagetable code with shadow2.") > Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Teddy Astie > > I'm not really sure about the fixes tag. That's the oldest commit which bares > any reseblence to the current code, and it was a bulk rewrite of the whole > shadow pagetable code. Prior to that, it was all mixed up and it's not > completely obvious what's (definiely) walking the guest pagetables as opposed > to the shadows. I'm fine with no Fixes tag if there's no clear introduction point, or if the introduction is simply that far away (ie: < 4.0) that it's no really relevant anymore. > Bloat-o-meter shows this clearly makes a code-gen difference in all cases: > > add/remove: 0/0 grow/shrink: 1/2 up/down: 16/-19 (-3) > Function old new delta > guest_walk_tables_2_levels 1688 1704 +16 > guest_walk_tables_4_levels 3708 3703 -5 > guest_walk_tables_3_levels 2233 2219 -14 > > To start with, l?e_read() looked to be the right helper, but they don't exist > for guest pagetable types, leading to: > > arch/x86/mm/guest_walk.c: In function ‘guest_walk_tables_2_levels’: > ./arch/x86/include/asm/page.h:135:36: error: incompatible types when assigning to type ‘guest_l2e_t’ from type ‘l2_pgentry_t’ > 135 | #define l2e_from_intpte(intpte) ((l2_pgentry_t) { (intpte_t)(intpte) }) > | ^ > --- > xen/arch/x86/mm/guest_walk.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c > index f48c3ef75f48..df2ccaa67475 100644 > --- a/xen/arch/x86/mm/guest_walk.c > +++ b/xen/arch/x86/mm/guest_walk.c > @@ -129,7 +129,7 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, > guest_l4_table_offset(va) * sizeof(gw->l4e); > if ( !hvmemul_read_cache(v, l4gpa, &gw->l4e, sizeof(gw->l4e)) ) > { > - gw->l4e = l4p[guest_l4_table_offset(va)]; > + gw->l4e = (guest_l4e_t){ ACCESS_ONCE(l4p[guest_l4_table_offset(va)].l4) }; I wouldn't mind if this was a macro or static inline function, maybe that would prevent new usages from forgetting to use ACCESS_ONCE(). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:05:31 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 08:05:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388011.1629217 (Exim 4.92) (envelope-from ) id 1wthUF-0005is-IB; Tue, 11 Aug 2026 08:05:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388011.1629217; Tue, 11 Aug 2026 08:05:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthUF-0005il-EZ; Tue, 11 Aug 2026 08:05:27 +0000 Received: by outflank-mailman (input) for mailman id 1388011; Tue, 11 Aug 2026 08:05:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthUE-0005id-En for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 08:05:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wthUA-00GItK-2a; Tue, 11 Aug 2026 08:05:22 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wthUA-009N1g-0Q; Tue, 11 Aug 2026 08:05:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=JmpUITwx9KWOwQTi/3Id4eMb0AxNSa+PJhHkXW2LIoo=; b=TUsH5AXAkGBW/N18xE4hFDjZ7B JU+Z9qpnm/GZGaKy3zW1EQXhC5ddyhrFEm07S43nNHu5fsHgzkT/nvD6AZviTI6rJW4Ypp0nITVHY X2KDo//rjf8yYyf825oKViZ2+e2qHHPJ6LAtsmMCEslzgD7pfbDKy5UYBLg8sq8Jonyo=; Date: Tue, 11 Aug 2026 10:05:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: dmukhin@ford.com Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, sstabellini@kernel.org Subject: Re: [PATCH v3] xen/common: add keyhandler to show Xen command line Message-ID: References: <20260810230359.671587-3-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260810230359.671587-3-dmukhin@ford.com> On Mon, Aug 10, 2026 at 04:04:01PM -0700, dmukhin@ford.com wrote: > From: Denis Mukhin > > Currently there's no way to print Xen command line on the emergency > console for debugging purposes when 'xl' is not unavailable. > > Add new keyhander 'X' to do command line printout. > > Signed-off-by: Denis Mukhin > --- > Changes since v2: > - account for CONFIG_CMDLINE_OVERRIDE case > - use IS_ENABLED() > > v2: https://lore.kernel.org/xen-devel/20260803070047.3097846-3-dmukhin@ford.com/ > CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2748655201 > --- > xen/common/kernel.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/xen/common/kernel.c b/xen/common/kernel.c > index d1bef9ac2b2b..54a7ee6f68e5 100644 > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -505,6 +506,25 @@ static int __init cf_check param_init(void) > __initcall(param_init); > #endif > > +static void cf_check show_hypervisor_info(unsigned char key) > +{ > + printk("'%c' pressed -> showing hypervisor information\n", key); > + > + if ( IS_ENABLED(CONFIG_CMDLINE_OVERRIDE) ) > + printk("Bootloader command line ignored (CONFIG_CMDLINE_OVERRIDE=y)\n"); Since we are there already, why not print the builtin command line using CONFIG_CMDLINE? > + else > + printk("Command line: %s\n", saved_cmdline); > +} > + > +static int __init cf_check misc_init(void) > +{ > + register_keyhandler('X', show_hypervisor_info, > + "show hypervisor information", 0); "show hypervisor information" seems too generic to me, almost all debug keys could be defined by this sentence TBH. I think this needs to be more specific, but I'm not sure what's the plan regarding this key. Is there an intention to print more stuff here, or just the command line? Knowing the full set of information to be printed might help come up with a better name. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:13:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 08:13:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388018.1629226 (Exim 4.92) (envelope-from ) id 1wthc9-0007Tv-8f; Tue, 11 Aug 2026 08:13:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388018.1629226; Tue, 11 Aug 2026 08:13:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthc9-0007To-5t; Tue, 11 Aug 2026 08:13:37 +0000 Received: by outflank-mailman (input) for mailman id 1388018; Tue, 11 Aug 2026 08:13:35 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthc6-0007Tf-UY for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 08:13:35 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wthc4-00H3UQ-Nv for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 10:13:32 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7ad9a1-8faa-0a2a0a5109dd-0a2a450a9cbe-48 for ; Tue, 11 Aug 2026 10:13:32 +0200 Received: from [185.255.28.35] (helo=prod-mta-13-02.swg-srv.net) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7ad9ab-f2d2-0a2a450a0019-b9ff1c2384ab-3 for ; Tue, 11 Aug 2026 10:13:31 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-02.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fefe239f8000c4f3.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 11 Aug 2026 08:13:28 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id 8F0EE812E3; Tue, 11 Aug 2026 10:13:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=aoB1eTjT2z4wVpGDNPvLeVwtALQ/pSrK3gx3t7yGMpA=; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references:feedback-id; b=OljU4eXRyYpojIIB6q47SGMzJfGOwMr+gXl8Kmx1R9e6n+Yi2K9kDubjI0wOPihqtaABybHmd hDMDblIpTRnKoFyFtKZ7e0kAswv+m/TC7AtqY5Cox18qKNmMj8AJNWdNg/Ez1ssr1PHDkQvpENR nvb48rOUAJZop/ENCSa8dZQB7e19BmUE2Tuwz5UogNUQO5Mj2jxvKBQeG0PAGl5ukg4IdXHXcGE 8Jpry8syDQVZ7e3xhVu9R4daq3h+rpJMk9AmWekiV1qAU2b3CDH28ZdZwzsr6xd0GJrrOaD5N0k /jpm9YjkJmXNIkqtJ2bdymakCdeTYAXuFVn612hGHNlQ== X-Zone-Loop: fb89ade2c7f7d53dcc4a6a88abc581905772adc757ec x-campaign-type: default x-transaction-id: 06423ebd-9e2c-4e67-b852-b3ec771235ee x-swg-uid: 01-68685a54-ecb5-401f-bcd4-2dc78b2f18b6 X-Mailer: Sweego Message-ID: <1786436008.8631fc262581453bbf619ec5b2062170.19fefe239f8000c4f3@vates.tech> x-swg-bid: 1786436008.8631fc262581453bbf619ec5b2062170.19fefe239f8000c4f3 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v1 02/17] xen/riscv: add basic VGEIN management for AIA guests From: Baptiste Le Duc To: Oleksii Kurochko Cc: Baptiste Le Duc , xen-devel@lists.xenproject.org, Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: <293a08d8-ff96-4726-b713-bc2d14973ca4@gmail.com> References: <1786368748.8631fc262581453bbf619ec5b2062170.19febdfed5f000e099@vates.tech> <293a08d8-ff96-4726-b713-bc2d14973ca4@gmail.com> Date: Tue, 11 Aug 2026 10:13:22 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786436007; l=3715; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=jGG0To3SQ8A2ektFXLw/w53WF2jrX05Bhc1JG2cnuP8=; b=i2l9TT7BNVWCKMxwxRhTjf0fbzGEXHJtsjLaTUQ+yP34nN06AR7wLE2jeXyjB+zNhLGK3zGUC vDXP4qlHbLsBWUAlnZP4TprWwXWHm8LQZVgchrXtQWHbHMv9gfmsb4F X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786436007777 X-purgate-ID: tlsNG-4011c0/1786436011-536D6CFC-E1FE3249/0/0 X-purgate-type: clean X-purgate-size: 3719 On 2026-08-10 17:04:43+02:00, Oleksii Kurochko wrote: > On 8/10/26 3:32 PM, Baptiste Le Duc wrote: > > >> It was decided to add support for IMSIC from the start instead of having APLIC > > > > Add a #include here instead of in aia.h. > > Sorry, but I’m a little confused here. doesn’t include > . > Yes it is, in xen.git/xen/arch/riscv/asm/aia.h, you added, in this patch #include Therefore, I think it could be included directly in the aia.c file as it is the only place where it is used. > > Could we call this function with a different cpu arg than the current > > one running? If yes, we would read hgeie of not the cpu we wanted. > > Considering that it touches the CSR_HGIEI register, it can only be > called on the currently running CPU. > > That’s why I suggested in one of my replies to Jan B. that I would drop > the argument altogether for this function. > > >> +{ > > > > > > Why `0` rather than smp_processor_id()? As described above vgein_init() reads CSR_HGEIE > > of the current hart but stores the result into per_cpu(vgein, cpu), so the two > > must agree. > > aia_init() is executed on boot cpu only so it uses 0 as Xen boot cpu is > always 0. But it won't be an issue anymore as I mentioned above an > argument of vgein_init() will be dropped anyway so it will be guaranteed > that a correct CPU is used. > > > What happens if v->processor change between vgein_assign() and > > vgein_release? Because it seems in such case the release will hit a > > different pCPU's bitmap: the original bit will leak and an unrelated > > CPU's bit will be cleared under another vCPU's feet. > > So, if v->processor changes between the calls to vgein_assign() and > vgein_release(), it means that migration has happened. If migration has > happened, then it is the responsibility of the migration code to > properly assign the new vgein and release the previous one. > > All other cases where vgein_release() is called are when the vCPU is > dying, so everything is okay there as migration cannot happen. > > > Potential index error, because above you did: > > > > vgein->owners = xvzalloc_array(struct vcpu*, vgein->geilen) > > > > so valid index are 0...(vgein->geilen-1). Adopt either > > one of those two options: > > 1. vgein->owners[vgein_id-1] = v > > 2. vgein->owners = xvzalloc_array(struct vcpu *, vgein->geilen+1) in > > vgein_init() > > > > I think `2` could be better to have vgein->owners replicated hgeie CSR but > > it would left the first entry read-only. > > I've found that too during prepare a reply to Jan B. so fixed it already > in v2. I've decided to go with what you suggested in 2. > > > VGEIN_DEBUG is not defined anywhere in the patch, please use > > gdprintk(XENLOG_DEBUG, ...) directly, or drop this branch. > > It is intentionally not defined. If a user needs additional VGEIN debug > information, they should define it themselves, as it can produce a > pretty large amount of logs due to, for example, the migration process, > where vgein_assign() and vgein_release() are used quite actively. > Oh I didn't know it was a common practice, thanks for this explanation. > > asm/aia.h needs neither nor as struct > > vgein_ctrl and the per-CPU variable both live in aia.c. Please drop them > > and add in aia.c > > Yes, it is redundant code that I missed removing. I’ve already noticed > it and removed it in v2. It's what I wanted to mean in the comment above about > Thanks. Happy to help :) > > ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:17:36 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 08:17:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388026.1629236 (Exim 4.92) (envelope-from ) id 1wthfy-00088p-PH; Tue, 11 Aug 2026 08:17:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388026.1629236; Tue, 11 Aug 2026 08:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthfy-00088i-Kn; Tue, 11 Aug 2026 08:17:34 +0000 Received: by outflank-mailman (input) for mailman id 1388026; Tue, 11 Aug 2026 08:17:33 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wthfx-00088c-89 for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 08:17:33 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wthfw-00Dd5e-8I for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 10:17:32 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7ada96-bab6-0a2a0a5309dd-0a2a4504a5ba-20 for ; Tue, 11 Aug 2026 10:17:32 +0200 Received: from [185.255.28.34] (helo=prod-mta-13-01.swg-srv.net) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7ada9b-b57f-0a2a45040019-b9ff1c229bd5-3 for ; Tue, 11 Aug 2026 10:17:32 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13-01.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19fefe5dbbc000c4f3.007 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 11 Aug 2026 08:17:26 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id CD19680B2A; Tue, 11 Aug 2026 10:17:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=VfuExQmoNgTZXE5+VBkz/9xRzW2zILQKGMuooSznwdY=; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references:feedback-id; b=HDgZ/eHyzIztICAkmrRPnX1tPLiK5fXEYrcG4aqurvYkP0nqTynam3YFbw/QJOq9kcXGpDA1t JSd74weaza3YiroHSqPREa+EX8RZtU2Jnc0S3p8/pzd5GFGHjMu7EaQUKyk6SWFjLN9dVn50DQt 4NHbuFn36XzTaTS0vco4wOoSAPUgUyGtPgUpedBTdTUAutRg/tRXvluQtPFC2beou8G0pjNJyUr rvuSbq221HWzeH099Daz0taU+EjSiqKkhs1PNOerc7Vr1cf88VQZicXgG9cmFLmHeEzAFqdwr/6 H/VPlZPVFkJZOIVfOsGAgTUvRp0ywgHUxmr7z2/1DVPA== X-Zone-Loop: 1d3495b58ea3199696d3fdff1748772b67e1d5f2a59a x-campaign-type: default x-transaction-id: 2d9719b5-0336-4957-a9f5-3199505dc255 x-swg-uid: 01-118367d2-c25f-4560-bff3-f1d9c775db70 X-Mailer: Sweego Message-ID: <1786436246.8631fc262581453bbf619ec5b2062170.19fefe5dbbc000c4f3@vates.tech> x-swg-bid: 1786436246.8631fc262581453bbf619ec5b2062170.19fefe5dbbc000c4f3 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v1 04/17] xen/riscv: introduce device-agnostic MMIO emulation dispatch From: Baptiste Le Duc To: Oleksii Kurochko Cc: Baptiste Le Duc , xen-devel@lists.xenproject.org, Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini In-Reply-To: <05283ea0-de82-4160-a3f9-5fc1292a20a5@gmail.com> References: <1786373377.8631fc262581453bbf619ec5b2062170.19fec268e07000e099@vates.tech> <05283ea0-de82-4160-a3f9-5fc1292a20a5@gmail.com> Date: Tue, 11 Aug 2026 10:17:20 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786436245; l=2419; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=WABT/iU4gh03Q3pGmRICfSFFfgjHolSslfi1RQTxhmE=; b=nvkbCvR/W6wmC1Tt9FGxWwIQidgRA3QCJVS2t0oXC2SHJkJLOT213HNl6R2TvWyFURqcbbBb8 2bAPhhTDeERDwuxlqYhFdP9PuIZA1+TzZau9bE7en4AlHQYexDUOYsI X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786436246032 X-purgate-ID: tlsNG-ebf023/1786436252-C12DCB50-7ACB3400/0/0 X-purgate-type: clean X-purgate-size: 2423 On 2026-08-10 17:36:56+02:00, Oleksii Kurochko wrote: > On 8/10/26 4:49 PM, Baptiste Le Duc wrote: > > >> diff --git a/xen/arch/riscv/include/asm/mmio.h b/xen/arch/riscv/include/asm/mmio.h > > > > According to coding style, it should be GPL-2.0-only. > > Could you please point me to the line in the coding style document where > this is mentioned? > > If you are referring to: > New files should start with a single-line SPDX comment to express the > license, e.g.: > > /* SPDX-License-Identifier: GPL-2.0-only */ > > See LICENSES/ for a list of licenses and SPDX tags currently used. > > Then my understanding is that /* SPDX-License-Identifier: GPL-2.0-only > */ is used only as an example, and I can choose any license from > LICENSES/. There, it is mentioned: > Valid-License-Identifier: LGPL-2.0-only > Valid-License-Identifier: LGPL-2.0-or-later > > I am pretty sure that I am free to choose any license that does not > conflict with the other licenses used in the project. > Oh ok I didn't know, thanks for these explanations. Could you let me know how do you choose one instead of the other in that case? Is there a rule from our company to follow somewhere? > >> +#ifndef RISCV_MMIO_H > > > > Nit: line too long (85) > > I will apply that. Actually I've already fixed that by putting the > comment above: > /* store: value to write; load: value read (set by handler) */ > register_t data; > > >> diff --git a/xen/arch/riscv/mmio.c b/xen/arch/riscv/mmio.c > > Should be GPL-2.0-only. > > Regarding license I've wrote a comment above so lets continue discussion > there. > > >> +/* > > Why have you included a copyright notice here, but not in the other > > files? > > So I just decided to do that for new files as I am not using corporate > e-mail. But why didn't you do it for all new files of this series? > > I don’t know if you can keep it, > > Good point, I have to ask then someone from our legal department... > > but I just wanted to point out > > > that there are other files where this type of copyright notice includes > > the year. > > Before, I used to include the year, but someone pointed out (or perhaps > I misunderstood) that there isn’t much point in including it and that it > is enough to have just (c) . > Okay thanks. > Thanks. > > ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:39:49 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 08:39:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388033.1629245 (Exim 4.92) (envelope-from ) id 1wti1N-0003FD-EF; Tue, 11 Aug 2026 08:39:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388033.1629245; Tue, 11 Aug 2026 08:39:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wti1N-0003F5-Ae; Tue, 11 Aug 2026 08:39:41 +0000 Received: by outflank-mailman (input) for mailman id 1388033; Tue, 11 Aug 2026 08:39:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wti1M-0003Ez-Gb for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 08:39:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1wti1L-00GJX5-1c; Tue, 11 Aug 2026 08:39:39 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wti1K-00BPuT-2n; Tue, 11 Aug 2026 08:39:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=rsDj8bg+McL8OBg03w8bUJh1MWTTZ9TNG3sSP2E9cq8=; b=cc3epIAt4zpTNHoKlWHsmMp36+ /eDUJPCMxN5ki0lGOK5yhGUQI2bTFGWQsEq3JtOGUTbe0hsYZfJKm745+3FlY8+SFCq+Ou8RIKQ2J P3izi/L74UVt0/EV/dcsWEBHv/DkJSzC6Q31haCmUSPwwJ3SUlkDU96kyaJDTP41dx38=; Date: Tue, 11 Aug 2026 10:39:31 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Elliott Mitchell Cc: Cody Zuschlag , xen-devel@lists.xenproject.org, anthony.perard@vates.tech Subject: Re: [ANNOUNCE] - Call for agenda items for August 6 Xen Community Call @ 15:00 UTC Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Aug 10, 2026 at 07:35:59PM -0700, Elliott Mitchell wrote: > On Tue, Aug 04, 2026 at 05:30:50PM +0200, Cody Zuschlag wrote: > > *Preparation* > > > > 👉 Please take a few minutes to review and update the agenda before the > > call: > > > > https://cryptpad.fr/pad/#/2/pad/edit/eqPXghB7GwT4OuySCjSQRyVD/ > > > > Feel free to: > > - Add topics or project updates > > - Suggest anything we can drop or defer > > - Include links to patches, mailing list threads, or documentation where > > helpful > > > > The agenda also includes the meeting link and a link to find your local > > meeting time. > > > > > > *Call Details* > > Date: Thursday, 6 August 2026 > > Time: 15:00 UTC (agenda starts at 15:05 UTC) > > Join: https://meet.jit.si/XenProjectCommunityCall > > > > We'll open the room at 15:00 UTC and begin the agenda at 15:05 UTC to give > > everyone a few minutes to join. > > > Took me a bit of time to consider what had been said in order to come up > with next responses. > > I didn't emphasize it during the community call, but the point was > explicit in the most recent posted message: > > https://lore.kernel.org/xen-devel/ajr0gN9kmPkLQlGF@mattapan.m5p.com/T/ > > This was previously allowed by Xen/ARM. This turned into a bug when the > Xen/ARM team decided to disallow multiple mappings of the shared > information page. During approval the Xen/ARM team was explicitly asked > to accept the task of updating outside projects to deal with fall-out. > > I don't recall the exact wording of the agreement, but this is certainly > fall-out from that change. As such this IS an adjustment the Xen/ARM > team agreed to aid. > > I've already generated a PoC, I had thought the Xen/ARM team would be > better acquainted with whom to ask about getting a patch along those > lines in. That seems a reasonable ask in light of the team having > accepted the task. > I don't know what you mean or imply with "accepted the task". It sounds a bit selfish to me that you refuse to finish the OVMF work. It's possible none of us likes the OVMF coding style more than you do, yet you seem to assume we have some kind of duty to pick this work and finish it. That's IMO an unacceptable burden to put on developers of an open source project. > > I don't know the Xen developers by voice. As such I don't know who > mentioned 'firmware = "ovmf"' when I was trying to bring up > Tianocore/EDK2 as bootloader. Now that I've checked by notes, whomever > brought that up was quite unfamiliar with that I was trying to bring up. > > The 'firmware = "ovmf"' setting is part of HVM domain configuration. In > this environment Tianocore/EDK2 is merely setting up some ACPI tables and > then handling the task of finding and invoking the OS bootloader. Since > all the hardware is emulated, Tianocore/EDK2-firmware isn't much > different from what it normally does. I should also note this is fairly > slow. > > Despite sharing the codebase, Tianocore/EDK2 as bootloader is very > different from being HVM firmware. In particular the arm64 > Tianocore/EDK2 configuration is "ArmVirtPkg/ArmVirtXen.dsc" and the build > creates the file "XEN_EFI.fd". Once built the domain configuration is > along the lines of: > > type = "pvh" > name = "somename" > kernel = "XEN_EFI.fd" > memory = 256 > vcpus = 2 > vif = [ "somenet" ] > disk = [ "somedisk" ] > > The result is a PVH domain with Tianocore/EDK2 functioning as a pure > bootloader. In particular it is capable of searching for its preferred > filesystem, then looking for an appropriate filename and then loading > that using the UEFI protocol. The result is near-ideal. > > Of note I'm pretty sure Tianocore/EDK2-bootloader would happily load > EFI-GRUB. More importantly though OS bootloaders which can handle UEFI > work perfectly in this setup. I expect this to be superior for *BSD. > > There are two problems with Tianocore/EDK2-bootloader though. First, is > the aforementioned unresolved bug. Second, this is only implemented for > aarch64 (arm64). Anthony has done the work for OVMF to work on x86 PVH domains, maybe he can provide more information about how to set it up and test. > This is a problem for all the paravirtualized bootloaders. They're all > single-architecture, despite the bootloader supporting multiple > architectures. On that single-architecture they're quite good, but Xen > really needs them on *all* their architectures. > > > I didn't get the chance to finish my suggestion during the call, so here > is what I wanted to suggest: > > I think the Xen Project really needs some effort aimed at the > paravirtualized bootloaders. Mostly making them operable on all > architectures they support. > > Paravirtualized GRUB is needed for ARM, RISC-V and PowerPC. > > I don't believe Tianocore/EDK2 supports PowerPC, but I would really hope > for it to become available for RISC-V and x86. > > While U-Boot is difficult to deal with, it would be valuable as a second > paravirtualized bootloader for PowerPC. > > Once those 3 were available on their applicable architecture it would be > time to purge PyGRUB. While I imagine this will take a while I think it > should be on the roadmap/panciled in for the future. In my opinion, it's naive to expect this plan to be realized without any developer effort behind it from your side. Leaving aside whether it's the right call from a technical prospective, I don't think it's fair to come to an Open Source community, drop a multi-project multi-architecture plan, and expect others to simply start crunching on it because "it's the right thing to do". Most of us already have very thigh deadlines and internal projects by our employers, and that's always going to take priority. And then with whatever little "free" time we have, we might have other goals and tasks that prefer to pursuit. In other words, I think if you want to see this making progress you either have to work on it yourself, or pay some developer(s) to do the work. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 08:52:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 08:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388042.1629253 (Exim 4.92) (envelope-from ) id 1wtiE1-0006FM-IZ; Tue, 11 Aug 2026 08:52:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388042.1629253; Tue, 11 Aug 2026 08:52:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtiE1-0006FF-Fn; Tue, 11 Aug 2026 08:52:45 +0000 Received: by outflank-mailman (input) for mailman id 1388042; Tue, 11 Aug 2026 08:52:44 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtiE0-0006F8-Bg for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 08:52:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtiDy-0069x2-8I for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 10:52:42 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7ae2c9-bab6-0a2a0a5309dd-0a2a4506a378-42 for ; Tue, 11 Aug 2026 10:52:41 +0200 Received: from [52.101.56.42] (helo=BN1PR04CU002.outbound.protection.outlook.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7ae2d8-195a-0a2a45060019-3465382a85d2-4 for ; Tue, 11 Aug 2026 10:52:41 +0200 Received: from BL1PR13CA0142.namprd13.prod.outlook.com (2603:10b6:208:2bb::27) by PH8PR12MB8432.namprd12.prod.outlook.com (2603:10b6:510:25b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 08:51:50 +0000 Received: from MN1PEPF0000F0E4.namprd04.prod.outlook.com (2603:10b6:208:2bb:cafe::66) by BL1PR13CA0142.outlook.office365.com (2603:10b6:208:2bb::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.12 via Frontend Transport; Tue, 11 Aug 2026 08:51:49 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by MN1PEPF0000F0E4.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 08:51:49 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 03:51:49 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 03:51:49 -0500 Received: from [10.252.145.116] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 11 Aug 2026 03:51:47 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nNBBgTGp1mcTONcPsH8fZGY0lZc28HdvKg8hQ9pk8FMObh3sUYei1sQfG+6Y5Mn9TgjecWnizJwokiYGs3lZRY1LH30k43BR5SxFmmCNQXfkSbKF4Fkva6v2AOfjd9o8gHzsT/VfFEkdJw8N0xEVcFKr1QuwMVwYFjMKyHS4K/yi6lge0ASPvdjbxjQ3F9WVC69BPdv4u7VuarTlx8JpCQQ2yPPFSk6+qSfS0MzSP9CFge8/Ad+zVW1/dPc3bR12ZSPZrIqr1aAMqwhGB3gNE3S7A8NKvw/X9Yj/uXkNxSuX2tA/Z9DpYyhY3SXKAuP9M4C8X+MsNxlkPKDhI/Qdvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ex96CI+X4Y5wRRjVWwfYGvAcs68jgARCp19WLcvYZsI=; b=T4ttE2cHsq2wcW3DZaEWf3xy1+MiBeYuUXIPu6L1oUXkmNYALt+3mLwMUrylPEVVktpxLfzsDlRVN4JR1qQkAC+fHChbb7XeJ8nmYWnNkH/B6K9WtjiK4Zyu8AbHLjxvBSWoH4cBgFRiNs5ZNnxbDsZ32RP65P7dXa1eQjEqToj2WsY609PuSpP2/z+xVpq/w1bbbeVfHqNHsXcq58Uiw8IRrEIwKZYV1rwPFicXxDndwWNG/4TB4Ne7QAdLYxzGh6RFFMqDqDQzhNRKLmDOKgml+hmBZyTt1DZdIICvlPq6OVMBOoqN79dKTH5/23UNSIKRclTxeaG7iYl4mNWjYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ex96CI+X4Y5wRRjVWwfYGvAcs68jgARCp19WLcvYZsI=; b=ejc10Io9S2dEo6jWOgQIAI4f/GLdn9wQLo3o2DiGG9vRip5qloWzigc86ykklBQJ4BIL+NjlQqVXqgJK1EpgKxkOTr+1E4uQXHVPKcoHRx4T73hNS1adufXUE0G8YimWJf07XVbjJ7DcuUh2FTwBg/3OYsX5E4aWMk7ncmTdiC0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Message-ID: <272a8622-47c2-4cbb-a98c-8242561cbdb8@amd.com> Date: Tue, 11 Aug 2026 10:51:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] xen/arm: validate IRQs before descriptor lookup To: Mykola Kvach , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" References: <271952244ae71ade885b3619fe161ed4f47777fa.1786385827.git.mykola_kvach@epam.com> From: "Orzel, Michal" Content-Language: en-US In-Reply-To: <271952244ae71ade885b3619fe161ed4f47777fa.1786385827.git.mykola_kvach@epam.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E4:EE_|PH8PR12MB8432:EE_ X-MS-Office365-Filtering-Correlation-Id: d3bff8db-055d-47a9-6ec2-08def785c860 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|376014|82310400026|23010399003|10067099003|4143699003|56012099006|11063799006|5023799004|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Tbba8HwoA0WfeC27HSxYENdPHKCYYIwh3Q7l9kRkKHTo4Tbd/Py8FEdc5lG20SKzXh6zMRPNDs+G1XiAIxZ3VzkiUnigjwLpXEDvzD0QHPebot6Wcma22V1RlHGU0bmPL05pNgW0hT4d8hJfAiAv6PqP0wRuh4WwGLaoqjtVV4dGA3yPoWDnxkavdp/FmXXevyF1Zw4YW95xdQMOSEI5bmDvkcYeWYt07pf/1PyRuA0nPxmtFHwVbl9lseNDwPLkG91vSqv+LcxuFieNmjIl+MMiW+WCCRr2rolJEA/QvwyBLtMw10FQskaFvsrOxZngEulkjQCsOvutEd5R7RXe0VZgHTj1gFCB1YxoxUPvupDZ3wRdjIE0qlTzs8aUNmdS9p+oeYnVxQSmdx25NRJ6M7l/dSYgfcJMjw6K2pGJKK7Mayb7fGFto7KR3zq9/Am0AFd0TV2UesSW59YTDoatGWOgu7GYtw0AIxeCJ0ac3R5PP65RsWFq37ng64QxRGG3hbkjvpzs2Cremh3BeQt+g6b7qdIb5m7Kha9GK6ydhZeTKjbH0+2po3wU1jaAc6pKClG/gb0379oPtNIu7ph1ps0y2lfZhHxMyEgrv+AMkWNsu7isXy6GNbAmuRLmefF03tKnN455yziJPloW9JVBTp8t+3eXxn5dAuGmy294FCcyFZ4HpO+7HKptkIYmc/ADGNN7h8OrpCV1FBcKxBp5vg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(23010399003)(10067099003)(4143699003)(56012099006)(11063799006)(5023799004)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JBlRjzLmERNHwd09iJQtWJbs8nk/lwIkGLyv4ozflVOL8aLxvvsXhuvir4ByH7AD+j9Ma5hstHzVkQOOt8qg2qUv4N0NB6OfC+4LcwAE04fV+4BtUmd1OGuowOSe0coFPjI8dkzXlLCrBbrTKGImLCduZJPtVxEBuMfGAbKyUpEX2b5wdcwb9pVnnPkxo8gbro9b2MurK6rr2PeovHRsynNxdOemzH3N8feVuvzLIUKl1U/LgpJixjlbzvrTR3POduKDyJqurjCXgpRT4tc6VoGxWLqDKcdE3RQaVkCSdvNREa/3mYomun1xV4MAmAoGjXpJfrVnXacFngwAt7Sks1/TEhIjIGXZH308C3G+05y2wT85vHw2BfiJEWp0TPLkt1ng9Ts87xr8LsqKpG3uTqeD+/guxBRCCCyP+T5tsptt/mbqi8ZHpoymvGJyVx+Y X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 08:51:49.7233 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3bff8db-055d-47a9-6ec2-08def785c860 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E4.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB8432 X-purgate-ID: tlsNG-16d1c6/1786438361-FD00977B-548B2A2C/0/0 X-purgate-type: clean X-purgate-size: 4762 On 10-Aug-26 20:38, Mykola Kvach wrote: > GICv3 eSPI support makes nr_irqs span the architectural INTID namespace > through ESPI_MAX_INTID, but descriptor storage is sparse. local_irq_desc[] > and irq_desc[] cover INTIDs below NR_IRQS, while espi_desc[] covers eSPIs. > INTIDs 1024 through 4095 have no backing descriptors. > > Validation based only on nr_irqs accepts an INTID in this gap. > __irq_to_desc() then indexes beyond irq_desc[], and callers may lock or > update unrelated Xen memory. > > Reject INTIDs that the GIC reports as unimplemented in setup_irq() before > looking up a descriptor. irq_set_spi_type() can run before the implemented > GIC line counts are available, so validate descriptor-backed ranges there > before looking up a descriptor. > > Call is_espi() unconditionally in __irq_to_desc() and provide an > espi_to_desc() stub when eSPI support is disabled. This preserves the > is_espi() debug check for eSPI-range INTIDs when support is disabled. > > Fixes: 98f7060b9ed5 ("xen/arm/irq: add handling for IRQs in the eSPI range") > Signed-off-by: Mykola Kvach > --- > Changes in v2: > - Validate descriptor-backed ranges in irq_set_spi_type(). > - Validate implemented GIC lines in setup_irq(). > - Preserve is_espi() validation with CONFIG_GICV3_ESPI disabled. > --- > xen/arch/arm/irq.c | 29 ++++++++++++++++++++++++----- > 1 file changed, 24 insertions(+), 5 deletions(-) > > diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c > index 73e58a5108..0f5d3496bf 100644 > --- a/xen/arch/arm/irq.c > +++ b/xen/arch/arm/irq.c > @@ -23,6 +23,12 @@ const unsigned int nr_irqs = IS_ENABLED(CONFIG_GICV3_ESPI) ? > (ESPI_MAX_INTID + 1) : > NR_IRQS; > > +static bool irq_has_desc(unsigned int irq) > +{ > + return irq < NR_IRQS || > + (IS_ENABLED(CONFIG_GICV3_ESPI) && is_espi(irq)); This IS_ENABLED reads redundant because is_espi() contains #ifdef CONFIG_GICV3_ESPI inside. AFAICT you added it here to prevent the !ESPI build from reaching ASSERT inside is_espi() when the irq is in ESPI range. I don't like the ASSERT inside is_espi(). I think it does not make much sense in a helper that should really just tell us whether the IRQ is in ESPI range or not. It should be up to the caller to decide what to do based on whether ESPI is compiled in or not. I think this cleanup would be best to be done first. If you don't want to do that, at least document this in the commit msg because others may be tempted to drop this IS_ENABLED. > +} > + > static unsigned int local_irqs_type[NR_LOCAL_IRQS]; > static DEFINE_SPINLOCK(local_irqs_type_lock); > > @@ -77,6 +83,12 @@ static int __init init_espi_data(void) > } > #else > > +static struct irq_desc *espi_to_desc(unsigned int irq) > +{ > + ASSERT_UNREACHABLE(); > + return NULL; > +} > + > static int __init init_espi_data(void) > { > return 0; > @@ -90,10 +102,8 @@ struct irq_desc *__irq_to_desc(unsigned int irq) > if ( irq < NR_LOCAL_IRQS ) > return &this_cpu(local_irq_desc)[irq]; > > -#ifdef CONFIG_GICV3_ESPI > if ( is_espi(irq) ) > return espi_to_desc(irq); > -#endif > > return &irq_desc[irq-NR_LOCAL_IRQS]; Nothing here covers 1024..4095. I think we should add at least: ASSERT(irq < NR_IRQS) like we discussed some time ago. > } > @@ -416,6 +426,9 @@ int setup_irq(unsigned int irq, unsigned int irqflags, struct irqaction *new) > struct irq_desc *desc; > bool disabled; > > + if ( !gic_is_valid_line(irq) ) > + return -EINVAL; > + > desc = irq_to_desc(irq); > > spin_lock_irqsave(&desc->lock, flags); > @@ -647,13 +660,19 @@ static bool irq_validate_new_type(unsigned int curr, unsigned int new) > int irq_set_spi_type(unsigned int spi, unsigned int type) > { > unsigned long flags; > - struct irq_desc *desc = irq_to_desc(spi); > + struct irq_desc *desc; > int ret = -EBUSY; > > - /* This function should not be used for other than SPIs */ This is an important line that you should keep. > - if ( spi < NR_LOCAL_IRQS ) > + /* > + * The implemented GIC line counts are not available when early > + * callers configure IRQ types. Check descriptor storage here; setup_irq() > + * validates the implemented line before the interrupt is used. > + */ > + if ( spi < NR_LOCAL_IRQS || !irq_has_desc(spi) ) > return -EINVAL; > > + desc = irq_to_desc(spi); > + > spin_lock_irqsave(&desc->lock, flags); > > if ( !irq_validate_new_type(desc->arch.type, type) ) ~Michal From xen-devel-bounces@lists.xenproject.org Tue Aug 11 09:22:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 09:22:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388052.1629262 (Exim 4.92) (envelope-from ) id 1wtig7-0002FK-Oo; Tue, 11 Aug 2026 09:21:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388052.1629262; Tue, 11 Aug 2026 09:21:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtig7-0002FB-M5; Tue, 11 Aug 2026 09:21:47 +0000 Received: by outflank-mailman (input) for mailman id 1388052; Tue, 11 Aug 2026 09:21:46 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtig6-0002F4-Ba for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 09:21:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtig5-006FrG-0I for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 11:21:45 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7ae99c-bab6-0a2a0a5309dd-0a2a4509c4bc-48 for ; Tue, 11 Aug 2026 11:21:44 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7ae9a8-be1a-0a2a45090019-b9ff1c12b6f9-3 for ; Tue, 11 Aug 2026 11:21:44 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19ff020b5cf000c4f3.006 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 11 Aug 2026 09:21:43 +0000 Received: from [192.168.1.46] (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: baptiste.le-duc) by mail2.vates.fr (Postfix) with ESMTPSA id A6098836B8; Tue, 11 Aug 2026 11:21:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=BsDOru5B/HOalntMeTera7gCiEHVoXXf0RUzISNa0hQ=; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references:feedback-id; b=p4ZTfclmQMN1CNnwb43L1fye72gokU+LmNGukYDH8eOe8IS0FHFU9By/CpNppc1gEsu1Qg9uN DOSl+mwEIFDfgLHvxgH3cM9L9Oy2UscnL7arsNtHTPKWJ6Gtbt8QbYMK9W5Se68sW87hV7mcDgH khRbYYHnc5+fgPzzjaueYKEg2YITCxSntW/8ZIlNbjtEx84520af/rrLpz52U0ygNZXJ7j9c5H+ 0/4cswQTTFwtFLvuG6nsr2Swboqr4c2Q05zWdEX70iugdr4qFGs/0WiCycuLtfPOunVep1jiHOJ 2Z33IMo4l1qpWXV4sdQYPGAkpvfjLUHPGWsemgXJ0t4w== X-Zone-Loop: 227c7d1a10f88bfa010aaddba4f1d9070cff629807f4 x-campaign-type: default x-transaction-id: 13ba7e45-6832-423a-80cb-23f843b7583c x-swg-uid: 01-314b3b3d-7f60-47e3-9ec5-06fad97b9657 X-Mailer: Sweego Message-ID: <1786440103.8631fc262581453bbf619ec5b2062170.19ff020b5cf000c4f3@vates.tech> x-swg-bid: 1786440103.8631fc262581453bbf619ec5b2062170.19ff020b5cf000c4f3 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v1 05/17] xen/riscv: implement virtual APLIC MMIO emulation From: Baptiste Le Duc To: Oleksii Kurochko Cc: Jan Beulich , Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org In-Reply-To: <4c62661a-f944-4806-824a-e74bcbaea3df@gmail.com> References: <5571644f1d3a4277dc95fe85099563a145d1d935.1784560663.git.oleksii.kurochko@gmail.com> <57793423-aadd-4786-90fd-2923925b766d@suse.com> <4c62661a-f944-4806-824a-e74bcbaea3df@gmail.com> Date: Tue, 11 Aug 2026 11:21:37 +0200 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786440102; l=10687; i=baptiste.le-duc@vates.tech; s=20260810; h=from:subject:message-id; bh=gOjMgTrY5afWsvGwKc48ZSHzxOd0PUqzW8ObetQiJ0Q=; b=pdma3NXfM4Gv4vvmHCu9so0Xn6DhD6yjAUScqDpL2Yfr/B2KRIQvlKvZRNsNNLg8xpJy+rqQP Otj8RljM2++A+xoxgKSueM4FF1Z/Hz4oRJRQgmhuxgkts2LSkQklwQ8 X-Developer-Key: i=baptiste.le-duc@vates.tech; a=ed25519; pk=N+BbdvMXRzrCuX/ieh4RWodiAKcLNvI+KjflcZ0oXCo= X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786440102868 X-purgate-ID: tlsNG-bad1c0/1786440104-3A4DB034-B032E409/0/0 X-purgate-type: clean X-purgate-size: 10689 On 2026-08-07 18:08:21+02:00, Oleksii Kurochko wrote: > On 8/6/26 4:28 PM, Jan Beulich wrote: > > > On 20.07.2026 18:02, Oleksii Kurochko wrote: > > > > For this tag to have any meaning, it should move ahead of the --- above; > > the explanations ... > > > > > > ... here rather explain the restriction on the R-b, not its odd placement. > > > > > > As this looks to be recurring - please get versioning of your series right. > > The series is supposedly v1, but here you give the impression of it being > > v3. If there really was an earlier v2 posting, why isn't the entire series > > here v3? > > It is v3 before before it was a part of another patch series connected > to dom0less config enablement. > > Would it be better to just write in "Change in v3" that it is moved from > another patch series + link to that patch series? Or it will be enough > just to drop "Changes in v2 and v1" and just start from v1? > > > PLease can you, before submitting, self-review your patches? I'm really > > getting tired of having to repeatedly point out basic style issues, like > > the overlong line here. > > Sorry for that, I will write an extra checker for such cases to not miss > them. > > > It extends to the other local variables here, but I'll use these two to > > try to make my point: I'm struggling to associate the names with the > > values they are set to. Likely "hxw" is an abbreviation of hart index > > width, but (a) what's the leading 'l' then and (b) why is there no 'g' > > in "hhxw"? By using hard to grasp names, you make it hard to actually > > understand the subsequent expressions, in particular ... > > The names it taken directly from AIA spec: > > The use of this value and fields HHXS (High Hart Index Shift), LHXS (Low > Hart Index Shift), HHXW (High Hart Index Width), and LHXW (Low Hart > Index Width) for determining target addresses for MSIs is described > later, in Section 4.9.1. > > The AIA specification interprets the machine-level hart index as a > combination of the **group index** (`g`) and the **hart index within the > group** (`h`), according to the following formulas: > > ``` > (1) g = (machine-level hart index >> LHXW) & (2^HHXW − 1) > (2) h = machine-level hart index & (2^LHXW − 1) > ``` > > (In our case, the machine-level hart index is equal to `mhartid`, i.e. > the hart index.) Therefore, if I understand correclty, if we take the Hart Index as defined in the AIA spec, we should have: Hart Index = (g << LHXW) | h Is it correct? > > For systems that use IMSIC groups, the IMSIC address layout is defined > by the following parameters: > > * `lhxw` (Low Hart Index Width, or *k*): the number of bits used for the > hart number within a group. > * `hhxw` (High Hart Index Width, or *j*): the number of bits used for > the group number. Is group number appelation equivalent to group index? I think with if what I wrote above is correct, the proper definition for `hhxw` and `hhxs` should be: * `hhxw` (High Hart Index Width, or *j*): the number of bits used for the `Hart Index` field within the physical address. > * `hhxs` (High Hart Index Shift): the bit offset of the combined > hart/group index field within the physical address. * `hhxs` (High Hart Index Shift): the bit offset of the `Hart Index` field within the physical address. > To extract the group index, we first shift the address by `hhxs` so that > the group index bits are aligned, and then apply a mask derived from > `hhxw` to isolate those bits. > > The hardware performs the same operation to extract the hart index from > the MSI address. However, in our case we already know which hart should > receive the interrupt (`hartid`), so there is no need to extract the > hart index from the base address. We only need to recover the group > index and combine it with `hartid` to construct the value expected by > the `target` register. Why don't we direclty extract the Hart Index as target directly needs it as explained in the 4.5.16.2 point of the AIA spec: target[31:18] = Hart Index target[17:12] = Guest Index target[10:0] = EEID It'd be easier as we just have to do shift from HHXS and apply HHXW. > > > ... these last two. As it stands, they may be easier to understand if > > you didn't have the local variables at all, despite them then getting > > textually longer. > > With the explanation above, do the variable names make sense? > > To be closer to AIA spec I think it would be better to rename > group_index to g and hart_id to h. Does it make sense to you? > > >> + > > > > Wouldn't this applying of a mask better be done in those callers which > > actually need it? It's not the least the asymmetry with ... > > Agree, that to be in sync, I will drop mask argument and apply it on > caller side. > > > ... this which I consider unhelpful. > > > > > > As to the comment - this indeed looks to be a field, but ... > > > > > > ... these look to be values of some other field which isn't described. Please > > may I (again) ask that definitions are their commentary at the very least not > > misguide readers? > > Thanks for pointing this out. You're right, the comment is misleading as > written. APLIC_SOURCECFG_D is a field, whereas the APLIC_SOURCECFG_SM_* > definitions are values for the source mode (SM) field, and the comment > doesn't make that distinction. > > I'll update the comments to describe the fields more accurately: > > #define APLIC_SOURCECFG_BASE 0x0004 > #define APLIC_SOURCECFG_LAST 0x0ffc > /* > * sourcecfg[] register fields: > * - bit 10 (D) selects the layout of the remaining bits; > * - D = 1: bits [9:0] hold the Child Index, i.e. the source is delegated > * to a child domain (unsupported by Xen); Just to know, what is a child domain? > * - D = 0: bits [2:0] hold the source mode SM (WARL). > */ > #define APLIC_SOURCECFG_D BIT(10, U) > /* SM field values (0x2 and 0x3 are reserved): */ > #define APLIC_SOURCECFG_SM_INACTIVE 0x0 > #define APLIC_SOURCECFG_SM_DETACH 0x1 > #define APLIC_SOURCECFG_SM_EDGE_RISE 0x4 > #define APLIC_SOURCECFG_SM_EDGE_FALL 0x5 > #define APLIC_SOURCECFG_SM_LEVEL_HIGH 0x6 > #define APLIC_SOURCECFG_SM_LEVEL_LOW 0x7 > > Does it look better? Probably there is not sense for two extra spaces > for APLIC_SOURCECFG_SM_*. I want to show by such identation that it is > values for SM field of APLIC_SOURCECFG. > > > And the xxx-es in here mean what exactly? Don't care? Some other, unrelated > > values? Yet something else? > > The `x` bits denote address bits that are constant across all IMSIC > interrupt files. They are not used to encode the group, HART, or guest > index; instead, they correspond to the fixed portion of the IMSIC > address determined by the platform's memory map. > > For example, consider the IMSIC DT binding: > > interrupt-controller@28000000 { > compatible = "qemu,imsics", "riscv,imsics"; > interrupts-extended = <&cpu1_intc 9>, > <&cpu2_intc 9>, > <&cpu3_intc 9>, > <&cpu4_intc 9>; > reg = <0x28000000 0x2000>, /* Group0 IMSICs */ > <0x29000000 0x2000>; /* Group1 IMSICs */ > interrupt-controller; > #interrupt-cells = <0>; > msi-controller; > #msi-cells = <0>; > riscv,num-ids = <127>; > riscv,group-index-bits = <1>; > riscv,group-index-shift = <24>; > }; > > > Here, `hart_index_bits = 2` (4 CPUs) and `guest_index_bits = 0`, so the > address layout becomes: > > 31 25 24 23 14 13 12 11 0 > +-------------+-+-------------+-----+-------------+ > | constant |G| constant |HART | zeros | > +-------------+-+-------------+-----+-------------+ > > > I can update the comment to say: > "x denotes bits that are constant across all interrupt file addresses." > > or, if you think it's clearer: "x denotes bits whose values are > platform-defined and common to all interrupt file addresses." > > Does it make sense any of suggested options? > > > Nit: Indentation. > > I will use the following indentation: > > ... (((irqn) < (d)->arch.vintc->nr_virqs) && \ > test_bit(irqn, (d)->arch.vintc->used_irqs)) > > > Is this really meant to stay? > > For debug purpose it could be useful, so I prefer to have it with > changing it to gprintk(XENLOG_DEBUG, ...) to understand which domain is > trying to access something wrong. > > > The U suffix is mainly (even if only slightly) obfuscating things, I think. > > Agree, I will drop U. > > > I don't quite understand the need for the cast. > > Functionally it isn't need but it documents that it is expected that > translation from unsinged long to uint32_t will happen. I will drop the > cast. > > > Why the cf_check (also for the store counterpart)? > > Missed to drop. Before vaplic_emulate_load() was used to initialize > vints_ops. It should be dropped here. > > > You have d as a local variable. > > > > > > Use domain_vcpu()? > > It will be better, thanks. > > > Instead of this goto, I think you simply want to move the label here. > > That'll also make the function more similar to its load counterpart. > > Good point. I am curious how fail label should be aligned: > > default: > fail: > gdprintk(XENLOG_WARNING, > "Unhandled APLIC write at offset %#x (value %#x)\n", > offset, > value); > > return rc; > } > > or default: > fail: > > ? > > > You have v passed in here, but you'd log current. If passing in v is > > necessary (i.e. here or elsewhere it may be other than current), then you > > need to either ASSERT(v == current) at the top of the funciton or otherwise > > handle v != current correctly. > > It makes sense. I will add ASSERT(v == current) here and for > vaplic_mmio_write(). > > > If all you care about is a boolean result, why not make the function return > > bool? > > Agree, bool will be enough for vaplic_emulate_load() and > vaplic_emulate_save(). > > Thanks! > > ~ Oleksii I will try to draw some schema to make the AIA spec more explicit. Maybe it could be part of this series, I don't know what is the xen policy about diagram and stuff like that. Do you know more about that? In order to not do a job with no needed at all. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 09:48:11 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 09:48:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388060.1629271 (Exim 4.92) (envelope-from ) id 1wtj5Z-0005OE-Ks; Tue, 11 Aug 2026 09:48:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388060.1629271; Tue, 11 Aug 2026 09:48:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtj5Z-0005O7-Ht; Tue, 11 Aug 2026 09:48:05 +0000 Received: by outflank-mailman (input) for mailman id 1388060; Tue, 11 Aug 2026 09:48:04 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtj5Y-0005Mt-4q for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 09:48:04 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtj5W-00AYhB-OC for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 11:48:03 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7aefb7-2eae-0a2a0a5409dd-0a2a4506b958-20 for ; Tue, 11 Aug 2026 11:48:01 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a7aefd0-195a-0a2a45060019-d98c6eacd35c-1 for ; Tue, 11 Aug 2026 11:48:01 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53CA01682; Tue, 11 Aug 2026 02:47:56 -0700 (PDT) Received: from localhost (a085714.arm.com [10.164.19.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8FC363F632; Tue, 11 Aug 2026 02:47:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786441680; bh=9BoMtxA4Y0P7/HlT09wIdHqLAsjiBcPF0bOK0SA6y88=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d6ccwcWanhV2NaMQGyN2LuxorwwpnGJX87UVp3OA/ioC8kalbAN29GEdYDjGMly4L +yi+Q/zEcN/N5K6/AZJJ9VjzIZc7OuAomjl/vPpcEdxNEFoRGn9LR525fZF+bpEreD Ak2C6/i9Np4uONZAT7JjQS//RpxwX0LWi0gAmmt8= Date: Tue, 11 Aug 2026 15:17:57 +0530 From: Anshuman Khandual To: "David Hildenbrand (Arm)" Cc: Muhammad Usama Anjum , Alexander Gordeev , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 1/9] mm: introduce hw_pte_t for PTE table storage Message-ID: References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-2-usama.anjum@arm.com> <3db8233c-3785-444e-b2eb-3e5fc5cb2f17-agordeev@linux.ibm.com> <4a42c498-58ca-46f4-819f-da14cfba154f-agordeev@linux.ibm.com> <52b5066c-64f6-40bb-9bce-365a18f24265@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-purgate-ID: tlsNG-16d1c6/1786441681-FD20877B-C043E738/0/0 X-purgate-type: clean X-purgate-size: 1266 On Mon, Aug 10, 2026 at 01:20:00PM +0200, David Hildenbrand (Arm) wrote: > On 8/10/26 12:09, Muhammad Usama Anjum wrote: > > On 09/08/2026 6:45 pm, Alexander Gordeev wrote: > >> On Fri, Aug 07, 2026 at 04:24:00PM +0100, Muhammad Usama Anjum wrote: > >>> Thank you for testing it out on s390. > >>> > >>> As __hw_pte_t isn't being used yet in this series, would s390 enablement > >>> patches add __hw_pte_t to this definition? > >> > >> I hope there is a better solution. As I noted m68k, powerpc and sparc > >> may also be affected, so I would suggest to look into those as well. > >> I would prefer s390 to use the generic one rather than circumvent a > >> compile error in a custom way. > > I've just checked all of these architectures by doing dirty conversion and > > reached to same conclusion that __hw_pte_t must be defined like: > > > > typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; > > > > I'lll add __hw_pte_t to this series. (Initially on last email I'd thought > > that the first user would add __hw_pte_t. But it seems sensible to add it > > now) > > Yes, do it as part of the introduction. Also a good idea to mention in the patch > description *why* that is required. Agreed. > > -- > Cheers, > > David From xen-devel-bounces@lists.xenproject.org Tue Aug 11 10:15:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 10:15:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388073.1629280 (Exim 4.92) (envelope-from ) id 1wtjVp-0001IG-P1; Tue, 11 Aug 2026 10:15:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388073.1629280; Tue, 11 Aug 2026 10:15:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtjVp-0001I9-ME; Tue, 11 Aug 2026 10:15:13 +0000 Received: by outflank-mailman (input) for mailman id 1388073; Tue, 11 Aug 2026 10:15:13 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtjVp-0001I3-A2 for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 10:15:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtjVo-00DyeO-A2 for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 12:15:12 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7af62f-8faa-0a2a0a5109dd-0a2a4508e2b4-0 for ; Tue, 11 Aug 2026 12:15:11 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a7af62e-f659-0a2a45080019-d98c6eacd970-1 for ; Tue, 11 Aug 2026 12:15:10 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BBBEA1682; Tue, 11 Aug 2026 03:15:05 -0700 (PDT) Received: from localhost (a085714.arm.com [10.164.19.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0350C3F86F; Tue, 11 Aug 2026 03:15:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786443309; bh=+szcqBCq9eZ2ua7vWX4x/+s1q8ODJlqcpxLyiJuSiwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+Vm46x3ghCefqeO2I1n6DA88n8dnPA9fKF0KOYZamwYwLaVm1b44z72dYIEIsYC0 p/UxibT9bkIS6vm2g/03/53REk/x6Bjd7ZTy6XlUazb0cSaz7+p0GyYbiNAyjJgZGx FyXK8Yk5Rfauuo195Y0NDG5YghHuk7t+gElvU4PU= Date: Tue, 11 Aug 2026 15:45:06 +0530 From: Anshuman Khandual To: Muhammad Usama Anjum Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 2/9] mm: make hw_pte_t visible to generic PTE interfaces Message-ID: <7xbai2nyu6nuyr6otqv556dnphpgwaqsmvwkqwoqwbh5nvj3ns@ddy5ezgvb7w3> References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-3-usama.anjum@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806083926.1807279-3-usama.anjum@arm.com> X-purgate-ID: tlsNG-c1860d/1786443311-CFED287B-77340A4B/0/0 X-purgate-type: clean X-purgate-size: 2355 On Thu, Aug 06, 2026 at 09:38:40AM +0100, Muhammad Usama Anjum wrote: > Later conversions use hw_pte_t in page-table checking, generic page-table > helpers, and vmalloc interfaces. Include linux/pgtable_types.h from the > headers that declare those interfaces before changing their types. > > For vmalloc.h, replace the direct asm/page.h include with > linux/pgtable_types.h. The latter includes asm/page.h, so pgprot_t remains > available. It also provides either the default alias or the opted-in > hw_pte_t wrapper. Stand-alone header file updates are not ideal. Why cannot these changes be folded in, where hw_pte_t gets used first time ever in the above mentioned places. > > Signed-off-by: Muhammad Usama Anjum > --- > Changes since RFC v1: > - Clarify that the header provides both generic hw_pte_t definitions. > --- > include/linux/page_table_check.h | 2 ++ > include/linux/pgtable.h | 1 + > include/linux/vmalloc.h | 2 +- > 3 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h > index 12268a32e8be1..12ee6d16ad339 100644 > --- a/include/linux/page_table_check.h > +++ b/include/linux/page_table_check.h > @@ -7,6 +7,8 @@ > #ifndef __LINUX_PAGE_TABLE_CHECK_H > #define __LINUX_PAGE_TABLE_CHECK_H > > +#include > + > #ifdef CONFIG_PAGE_TABLE_CHECK > #include > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 8c093c119e5a8..cf595608cc4c4 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -4,6 +4,7 @@ > > #include > #include > +#include > > #define PMD_ORDER (PMD_SHIFT - PAGE_SHIFT) > #define PUD_ORDER (PUD_SHIFT - PAGE_SHIFT) > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index aed121d729b01..b068e6ade4207 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -8,7 +8,7 @@ > #include > #include > #include > -#include /* pgprot_t */ > +#include /* pgprot_t, hw_pte_t */ > #include > #include > > -- > 2.47.3 > From xen-devel-bounces@lists.xenproject.org Tue Aug 11 10:58:32 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 10:58:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388092.1629289 (Exim 4.92) (envelope-from ) id 1wtkBT-0006uj-RN; Tue, 11 Aug 2026 10:58:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388092.1629289; Tue, 11 Aug 2026 10:58:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkBT-0006uc-Ob; Tue, 11 Aug 2026 10:58:15 +0000 Received: by outflank-mailman (input) for mailman id 1388092; Tue, 11 Aug 2026 10:58:15 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkBS-0006uW-VT for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 10:58:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtkBS-006XI1-0E for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 12:58:14 +0200 Received: from [10.42.69.11] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b0045-e002-0a2a0a5209dd-0a2a450b874c-2 for ; Tue, 11 Aug 2026 12:58:13 +0200 Received: from [217.140.110.172] (helo=foss.arm.com) by tlsNG-42698a.mxtls.expurgate.net with ESMTP (eXpurgate 4.57.1) (envelope-from ) id 6a7b0044-b7e8-0a2a450b0019-d98c6eacb6a2-1 for ; Tue, 11 Aug 2026 12:58:13 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44D0C1682; Tue, 11 Aug 2026 03:58:08 -0700 (PDT) Received: from localhost (a085714.arm.com [10.164.19.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 820043F86F; Tue, 11 Aug 2026 03:58:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=foss header.d=arm.com header.i="@arm.com" header.h="Date:From:To:Cc:Subject:References:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786445892; bh=E2Q5I65meboDct+4hfaKsQDzSd1S1/tsAKEVH3DzJwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tKGjJivwGyrqmHqJQhgHkKc1NYH5dpUS0DWnYV/mVHQACS1frf2TRd2UhTyMG8JvA Bw0BndUTcgOm1QZBl4JI/V5svJA1QNwOZVE/G2oL5rd2q44W5xc5apxl/s1/v2NISQ JQrQY7r9UAbIHixEwxX6nTsx2ykLpYcEoEZ681SE= Date: Tue, 11 Aug 2026 16:28:09 +0530 From: Anshuman Khandual To: Muhammad Usama Anjum Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 3/9] mm: name pointers to copied PTE values ptentp Message-ID: References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-4-usama.anjum@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806083926.1807279-4-usama.anjum@arm.com> X-purgate-ID: tlsNG-42698a/1786445893-1AEDE9EA-943E194E/0/0 X-purgate-type: clean X-purgate-size: 3571 Subject line is very confusing. Perhaps something like the following. mm: Rename pointers to copied PTE values as ptentp But even 'copied PTE values' is not very clear as well. On Thu, Aug 06, 2026 at 09:38:41AM +0100, Muhammad Usama Anjum wrote: > The hw_pte_t conversion must retain pte_t * for pointers to standalone PTE We need to explain what is `standalone PTE values` first. > values. Name the value parameters ptentp in the install_pte callback, > write_protect_page(), and guard_install_set_pte() so the later mechanical > conversion can distinguish them from pointers to PTE table storage. > > Some functions already use the ptentp name, including: > - madvise_folio_pte_batch() > - folio_pte_batch_flags() > No need to convert them. > > This is a naming-only change. Small nit - s/naming-only/rename The commit message needs rewrite clearly explaining the following details - What are standalone PTE values - How these are different from HW pgtable pointers - Change is just a rename for pointers into such 'standalone PTE' - These renamed 'ptentp' here would be used for skip or replaced during upcoming mechanical change via a script - No functional changes intended > > Signed-off-by: Muhammad Usama Anjum > --- > Changes since RFC v1: > - Update the description for the architecture opt-in conversion. > --- > include/linux/pagewalk.h | 2 +- > mm/ksm.c | 4 ++-- > mm/madvise.c | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h > index b41d7265c01bc..c34d826c5e4a2 100644 > --- a/include/linux/pagewalk.h > +++ b/include/linux/pagewalk.h > @@ -89,7 +89,7 @@ struct mm_walk_ops { > struct mm_walk *walk); > void (*post_vma)(struct mm_walk *walk); > int (*install_pte)(unsigned long addr, unsigned long next, > - pte_t *ptep, struct mm_walk *walk); > + pte_t *ptentp, struct mm_walk *walk); > enum page_walk_lock walk_lock; > }; > > diff --git a/mm/ksm.c b/mm/ksm.c > index ad05d7791307e..11d50518d02e9 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1292,7 +1292,7 @@ static u32 calc_checksum(struct page *page) > } > > static int write_protect_page(struct vm_area_struct *vma, struct folio *folio, > - pte_t *orig_pte) > + pte_t *ptentp) > { > struct mm_struct *mm = vma->vm_mm; > DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, 0, 0); > @@ -1371,7 +1371,7 @@ static int write_protect_page(struct vm_area_struct *vma, struct folio *folio, > > set_pte_at(mm, pvmw.address, pvmw.pte, entry); > } > - *orig_pte = entry; > + *ptentp = entry; > err = 0; > > out_unlock: > diff --git a/mm/madvise.c b/mm/madvise.c > index 07a21ca31bad4..c324cc991f841 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1101,12 +1101,12 @@ static int guard_install_pte_entry(pte_t *pte, unsigned long addr, > } > > static int guard_install_set_pte(unsigned long addr, unsigned long next, > - pte_t *ptep, struct mm_walk *walk) > + pte_t *ptentp, struct mm_walk *walk) > { > unsigned long *nr_pages = (unsigned long *)walk->private; > > /* Simply install a PTE marker, this causes segfault on access. */ > - *ptep = make_pte_marker(PTE_MARKER_GUARD); > + *ptentp = make_pte_marker(PTE_MARKER_GUARD); > (*nr_pages)++; > > return 0; > -- > 2.47.3 > How did we ensure that the above changes are comprehensive and nothing else got left in here ? From xen-devel-bounces@lists.xenproject.org Tue Aug 11 11:26:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 11:26:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388105.1629298 (Exim 4.92) (envelope-from ) id 1wtkcR-0003Jr-Us; Tue, 11 Aug 2026 11:26:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388105.1629298; Tue, 11 Aug 2026 11:26:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkcR-0003Jk-SA; Tue, 11 Aug 2026 11:26:07 +0000 Received: by outflank-mailman (input) for mailman id 1388105; Tue, 11 Aug 2026 11:26:06 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkcP-0003Je-Ps for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 11:26:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtkcO-002jSk-KT for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:26:04 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b06ad-bab6-0a2a0a5309dd-0a2a450a9df2-44 for ; Tue, 11 Aug 2026 13:26:03 +0200 Received: from [52.101.65.33] (helo=DU2PR03CU002.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b06ca-f2d2-0a2a450a0019-34654121ed66-3 for ; Tue, 11 Aug 2026 13:26:03 +0200 Received: from AS4P191CA0033.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:657::20) by AS2PR08MB8747.eurprd08.prod.outlook.com (2603:10a6:20b:55f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 11:25:57 +0000 Received: from AMS0EPF000001A9.eurprd05.prod.outlook.com (2603:10a6:20b:657:cafe::7a) by AS4P191CA0033.outlook.office365.com (2603:10a6:20b:657::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Tue, 11 Aug 2026 11:25:57 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS0EPF000001A9.mail.protection.outlook.com (10.167.16.149) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 11:25:57 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) by GV1PR08MB8033.eurprd08.prod.outlook.com (2603:10a6:150:9a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 11:25:13 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4]) by VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4%3]) with mapi id 15.21.0315.008; Tue, 11 Aug 2026 11:25:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=LR8XLs2K7Av+AN8MFbA38rp+OtYJPybhHowexY5/w4ouSFJJ7P/yP3vj7Cm2IeTMlZUj1pQ0O/2xjCMBBxbLjGLOU55YHqcINNoh6I/SyXT2Vo8NviLhu9ja9UKLZ/MUPzP2Kz1b2WXJPpwW1Fxm68JpYbJBXvmvh3sW1r9D4hLkQDayxSjkruAHPxmAnkffcN1lRWpMdfWrzDgEFtzrarXmMiFXblxTSucUPpQetKHzyHdwmnPeiPOsTpNg73awK3ttMZ8tT/0KkdliCas5KKrRIIfbM4WvDorehZIAmpcMl1cijjZcpJUC9+61eQBB5En17HO8PVWcxM2YYaNCcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Upa8H8lYci2AEeo5pg4WAAxc+FTB6t5I5dTvHmgOG8=; b=arhJojw6f6UGnxzfNGNedm3EQ31RL+LDDUtCFjgoxJgxH0RGYktGR8/+2qcqTfubb1JHgR8nHmVO9oOC4zjDWAJq81J1hXJ8TQRMZU/Xd+qMZVtX6Szi1NvtBpGif7CZRlZt06G5UJU3ijGMpdRGZRgKDjDJjDAV0achaWfQ8bXAMxQICwThYJ6+MhlbSbWpy5cT7ZXJ5iJz8Ql3kzozGUMZcYJbC09tm/1mI8nOia3fX5Ed/jQGw0p6HjBIJhV8g3q2fZIvxwKbDG0HTiroHKak2ZXnLMQ0iNBOJgkEXbBp42CIW9wEmUCx91ZFp/Y5npRVsUrr0W7dnu36MqtQ2A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Upa8H8lYci2AEeo5pg4WAAxc+FTB6t5I5dTvHmgOG8=; b=ZDqaLm7gWhUITSg3PvlCRuHDeaF0jtytI9AB0HVCOFjQL41efiVP1AEJKscTP+JFRYc3f4vwBxX6ZAv4Y4PTsCJUFq4gLgyuAFM1k5WCHt84HzI07ZD2DqdbEand2v5A73ThSJ6I32hkVU7sgGurUuuZJ0gjrk4FBCJjr8mRbic= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rfpSa1oKx33iClOdPa8JCMayv6kb2mS5cLSdASv8gqPN7G9jRNvNZr0BRV4nAn6sr7qPWueIE9ojHmSandXoWV6JVIpWCGw0mabIwDi3hHXaLXz/d09eY9YS/qmXGiad6Nx7LwvsP3kdsAo4tvgS/k3HhLmg2aGodcwlkU1qKK2+WtV5Z5feAlL1aVtakk4g/bMK/rfm4u6YKvP7XXcz9/i8d0vgwi39NfSQ1znyncgm9lObFdDx6hgSgY61WahCZgSNmpzHZZeo5EpCJhHGjpN3AhYm7QSKGEWktVwtPMb8mZ/r7AU9IqrFuiWeqKZGgdDb0JOBgfrWxcD4VVqDPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Upa8H8lYci2AEeo5pg4WAAxc+FTB6t5I5dTvHmgOG8=; b=wPp6P2gJ4yNQDU7fWUD1/g6d6JagwvLy15xCBXNctqNPVJNxT71iw0065K7P6c05Yufxg2vVpUuu1t5vH85kR7TRcPvqyfqE4PpXf6TAwLs89iK9hg0BqavgDwN8+AFGzg+osrO2SGItVo/uJYHvmGhmr1GRm5CljI++dqBRw+wB0W+Td9dzJ9gI8qkjy1cSs7hPwJtlQDELDD7lUnOQFut0LFcDCBf3Y/x99uqfZF2ujpT45Smb/nAIPnrxA1r7ex+SOUNkIqhY2cmz+HO2/YWS3qbYInruq9XQi0dBfnhbKn5vsoPQbFeEi7DmozIPRLvwFmokHwABpcYYEaWsiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Upa8H8lYci2AEeo5pg4WAAxc+FTB6t5I5dTvHmgOG8=; b=ZDqaLm7gWhUITSg3PvlCRuHDeaF0jtytI9AB0HVCOFjQL41efiVP1AEJKscTP+JFRYc3f4vwBxX6ZAv4Y4PTsCJUFq4gLgyuAFM1k5WCHt84HzI07ZD2DqdbEand2v5A73ThSJ6I32hkVU7sgGurUuuZJ0gjrk4FBCJjr8mRbic= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <85286df7-363a-4671-bce8-8157ae5c8f02@arm.com> Date: Tue, 11 Aug 2026 12:25:08 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 2/9] mm: make hw_pte_t visible to generic PTE interfaces To: Anshuman Khandual , David Hildenbrand References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-3-usama.anjum@arm.com> <7xbai2nyu6nuyr6otqv556dnphpgwaqsmvwkqwoqwbh5nvj3ns@ddy5ezgvb7w3> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: <7xbai2nyu6nuyr6otqv556dnphpgwaqsmvwkqwoqwbh5nvj3ns@ddy5ezgvb7w3> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::13) To VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3421:EE_|GV1PR08MB8033:EE_|AMS0EPF000001A9:EE_|AS2PR08MB8747:EE_ X-MS-Office365-Filtering-Correlation-Id: b28951d4-3669-499f-4352-08def79b5085 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|7416014|56012099006|10067099003|4143699003|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: S6S52yYdxtDtrbu3+R3LqA1hBff1nj/2rLzT9GQ0+Ov8ipkmk0O3mjgrS/DUQ1/AFHfZWm9IZqKqqBU43nupYPXdHctB4A1PEZb9VDmjzZVISz3QfTXgSdr/68htGFhRc/j48gtQ4l6+L4ZW1nZja24rc6nWlSCYCtCWwtrMSs9R7h+dNpcLi2YgHViFI9Py9PcceBHI2y1hbD3tgIm9e45D/TvCqL/DDHF12QMIcti8yIvgdyO09z7AYYF74iZeACzU7uBne+6EXxl5OTZFg6QDzYUP73s7GSAEpT8D0uC32vGvMHjG8m+SK/kgAzP+Nmx82vnMrK3xq8uA+VWijeEIKRH0QxmnSwYsuk1AtsGokPKiK6I6K7ncpwqGz621yibL1B1X/TtMxwipICwYVw/YV+fP2FF6t2BPeh9+LOL+/jJ5P4Q0nEQm8VGkWH7CqIW3RZfdDrfhmWwygRbb4FGuEulKGS0Zb9XSJgqJ/zyiqn5W4UNQbXYIOTge5Vv9t0ogYUJ+UEirnawh/Dtsl7J7crALwP6tP+AkARGX3R1W7ZcuiL99OIu2CO3DNYis4WRH+XIaGeh4GtZWlHcy/Q/iSOzNy8TKPbP6PMGBNW2rO6bfWb0+8p3gurQ1AfDE8vOseTc5WWE/ndAm09GMDOSotmNmMi7644PyBtk9BhE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3421.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(7416014)(56012099006)(10067099003)(4143699003)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: HcK3rNnbwnlUGSwsDidSABGG1HQSoO72TkmhaC28ctmrJg8jVmz1OTzbiHJyHscmR1RSZ/MVJf3UF+V1Dje2C1z7jQczHvpZZk9NqnA1pIaWUyQ0NJGWUP8OQZQ7BxNR+CvvvJU4JV3+pgE+pVX/LgqCg/GXYo9PNipkTyJMz9mRgXBJrvoOJFLveHRnnNj6ydDRiY+xZEs2n9JOMvPO5HLQY82ufTlmcOJ3FL9PskIALGq/04QKaGj1BuKnnTOeCwktvBeWr/VO5+ier2emXtvzMh/0Yd8zfkfTpnuAfv7qGuIggIUVnYNjisH2v/7Pxh+mGQifH9TryIJK1GhcFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8033 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A9.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eedea4c3-0f48-4936-b2b9-08def79b350b X-Microsoft-Antispam: BCL:0;ARA:13230040|14060799003|36860700016|35042699022|23010399003|1800799024|82310400026|7416014|376014|10067099003|56012099006|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 6KeX0Y8hlJ6T8DzdMW1+mLWuzvKwSvsLtVaM1FZSBYQFe2/wJ9AM2jY6ZKYld4Xl2hdLlFmzsPGUB5r4A4gd7B3BDO7zfp+pOAwufqbeXfYmrHSUmyqnHgYGKQTtPxLxVvlkmrZV6SHU2W4jdHN5JitLujQKDD98cTOrNXmnw2rMrGNzhPel/sMCrrxUOwcDyNJzMhjNvTihybUfZEVVS6KX6L7TIuHg6Hrt5ougauduq1FrBUL+6J76wEjtl/xKDnxve5EXBb7d1FXkUSfEgNgAHCwP0vZIRt40S4BHfeSviAlN4pxqH2tUK41SRVj5I7A6f+xUG9WT0yFTvXowhCvXxrlE3eD+2PiLSAOujzLikwzfHMtN9knYkKcDtMFMcq+/iqei+pN0DkXdGTnlV5+aILrwkI5aQvTaP5+NzPWrhEmc3B+TO+4dcPLY1VlERE1j70QDf71kHs4R3st0+eZpsjxeFEOV3sxJo8/V+bdpg8iT81OrvEvWHFyrFBPyta3aIdfh0/WyiKDrN2Lp0d8WTKmHlQFnlvDseOO3dPGPLGROGxMiC/xqCne8h2QWiQKpjdh3pJipAoo3nL0btv/sUspBv1jsoWkKSEk8X3xlhoLcq4AWhm3rWFtoTS3eh1ZCxS7IbIcbzCEVnAAXUrXMliI1AAoko08NSYK6d4Fj3BLijKjNKhwfbDVCGGcgRmz0pcNOwhIIpwUuMdFgsg== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(14060799003)(36860700016)(35042699022)(23010399003)(1800799024)(82310400026)(7416014)(376014)(10067099003)(56012099006)(11063799006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PpJWUGBI0WXngUjmkkmjZ8b9gVABqPlGGdB9in5/n5SVZR/asrpHB7LtoHfG4dL4AjWVyKTXpsEwcsX+jvKJYl51kZwclhNMX8lZECOJjm1ho6qMO3JWlgYLZbH1Fq9uRoCjmRSkf89Wu5QQgQiJQn7NgXUp1gxZDG+bm7d6kU7ubZhtxXLe55hhalbMJFecFRP3KRfX1w+j6xBke2NFN/V2E7odXBw/sjlfrNmeBofeAKv/j7gH42MDjAGWfA8EQwUOF8zhAC42fhaPcfmtjCYKn4wJElqHNc37lF105kHubkPzm7VB2ryGNn/JgYeP0MlcOcYG1Dn5KUpILs7lTmk+Xjb5U9iSSjI4JApKKGTiYPMVqrcCIQYYHQEHa09ZjxJEZjARr7DDEpsYzqGq0xo6ca/UhZFYZtmedtQ2phr8KIsEK0Kbi9zCAxauV+9Z X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 11:25:57.5424 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b28951d4-3669-499f-4352-08def79b5085 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A9.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8747 X-purgate-ID: tlsNG-4011c0/1786447563-583CCCFC-6A690844/0/0 X-purgate-type: clean X-purgate-size: 2742 On 11/08/2026 11:15 am, Anshuman Khandual wrote: > On Thu, Aug 06, 2026 at 09:38:40AM +0100, Muhammad Usama Anjum wrote: >> Later conversions use hw_pte_t in page-table checking, generic page-table >> helpers, and vmalloc interfaces. Include linux/pgtable_types.h from the >> headers that declare those interfaces before changing their types. >> >> For vmalloc.h, replace the direct asm/page.h include with >> linux/pgtable_types.h. The latter includes asm/page.h, so pgprot_t remains >> available. It also provides either the default alias or the opted-in >> hw_pte_t wrapper. > > Stand-alone header file updates are not ideal. Why cannot these changes be > folded in, where hw_pte_t gets used first time ever in the above mentioned > places. That's correct. This patch should be merged with the 3/9 patch. But that patch is already too much big as it was generated with the help of Coccinelle. So I kept it separate. Do you still think we should merge it as its a special case? > >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> Changes since RFC v1: >> - Clarify that the header provides both generic hw_pte_t definitions. >> --- >> include/linux/page_table_check.h | 2 ++ >> include/linux/pgtable.h | 1 + >> include/linux/vmalloc.h | 2 +- >> 3 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h >> index 12268a32e8be1..12ee6d16ad339 100644 >> --- a/include/linux/page_table_check.h >> +++ b/include/linux/page_table_check.h >> @@ -7,6 +7,8 @@ >> #ifndef __LINUX_PAGE_TABLE_CHECK_H >> #define __LINUX_PAGE_TABLE_CHECK_H >> >> +#include >> + >> #ifdef CONFIG_PAGE_TABLE_CHECK >> #include >> >> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h >> index 8c093c119e5a8..cf595608cc4c4 100644 >> --- a/include/linux/pgtable.h >> +++ b/include/linux/pgtable.h >> @@ -4,6 +4,7 @@ >> >> #include >> #include >> +#include >> >> #define PMD_ORDER (PMD_SHIFT - PAGE_SHIFT) >> #define PUD_ORDER (PUD_SHIFT - PAGE_SHIFT) >> diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h >> index aed121d729b01..b068e6ade4207 100644 >> --- a/include/linux/vmalloc.h >> +++ b/include/linux/vmalloc.h >> @@ -8,7 +8,7 @@ >> #include >> #include >> #include >> -#include /* pgprot_t */ >> +#include /* pgprot_t, hw_pte_t */ >> #include >> #include >> >> -- >> 2.47.3 >> -- Thanks, Usama From xen-devel-bounces@lists.xenproject.org Tue Aug 11 11:28:14 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 11:28:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388116.1629308 (Exim 4.92) (envelope-from ) id 1wtkeT-0003zK-DZ; Tue, 11 Aug 2026 11:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388116.1629308; Tue, 11 Aug 2026 11:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkeT-0003zD-9W; Tue, 11 Aug 2026 11:28:13 +0000 Received: by outflank-mailman (input) for mailman id 1388116; Tue, 11 Aug 2026 11:28:11 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkeR-0003z2-LU for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 11:28:11 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtkeR-002jyH-1j for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:28:11 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b072f-2eae-0a2a0a5409dd-0a2a450ab1f4-42 for ; Tue, 11 Aug 2026 13:28:10 +0200 Received: from [52.101.69.14] (helo=AM0PR83CU005.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b074a-f2d2-0a2a450a0019-3465450ead9e-3 for ; Tue, 11 Aug 2026 13:28:10 +0200 Received: from AM0PR10CA0002.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::12) by DBAPR08MB5591.eurprd08.prod.outlook.com (2603:10a6:10:1ae::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 11:28:02 +0000 Received: from AMS0EPF00000197.eurprd05.prod.outlook.com (2603:10a6:208:17c:cafe::1e) by AM0PR10CA0002.outlook.office365.com (2603:10a6:208:17c::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.25 via Frontend Transport; Tue, 11 Aug 2026 11:28:02 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS0EPF00000197.mail.protection.outlook.com (10.167.16.219) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 11:28:02 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) by AS8PR08MB7790.eurprd08.prod.outlook.com (2603:10a6:20b:527::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.11; Tue, 11 Aug 2026 11:27:27 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4]) by VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4%3]) with mapi id 15.21.0315.008; Tue, 11 Aug 2026 11:27:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=qoS21m4gqpl2A6mSYODK138AgZwscC6N6PBwKh0DY+U4/TY/d+9O22I+jnT6RZQ1qRmAbHotdmjz24h5HLuMHt2xruX853hADfuN6vM3ogka7+wik6xxKKcTFwHu7PtzYakC6Myv0tXrUbbdk1QdAOhE/6C3RCxk18Z5okURGuqvdXeUhwSCteSgY/PFWRSf/ibAUzhFYrFJFUzMdZYOsC5p7ihZV6k89/8jsGVt5koH2dtKgIS6T9ydUNiqRKgiv/tuhR+Wwz6RUfw8Tgf4hhzLqCY+dDo+bvZwodjNnzpyNCFt70WuLC6WYUXgkPGwTinVi6xnlV43aTLXM4CJzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jJvqjQtYhPn+5rlwiCulIyzL4lgkY2x9AtSglnQ/lYY=; b=QVqwLDL6dU8ENykUrSBX3azgWcaNBU6rqxz+4rZeM+oyBC8GK/x3lCMDcem5YrIRmulghNj6VZuwOTenlfLgwKxoRyvMvv4DcMLhMsYZysLvJ+bXVj/umUVRJ+GXV6RG9+cyZPlmF7smr3sIzUdtipk3EJEAjvh/cCSxy4yW9t6nm4GaD3LzSwVuTpWgTr6IqF2QCAn2ay0QSAMvb6hWnHsdsYwC49R0ozqycBMAzPrkyb8zntGg9EL26TKTJ0RoaOp3AOtfQ7ZObsG5F01dT/jSmt/ufiJ25S0XpCnqXiFUiPX8vCaGjUlPl9KLA7lmU4xdE8T137K9YLQWtx7kyw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jJvqjQtYhPn+5rlwiCulIyzL4lgkY2x9AtSglnQ/lYY=; b=ZUpGE89U93omH662/JXtCNc15E3velUKg/MY+8EtCB58awMrAJ55DvQpiyUbXmRWgGbeUbeaF1kB4Mf/vJIUzh9u5D1IYs0UbuSUkN9eR4mUz6yAUzJl+btZ4QsOeyW8mPHysbYosEhYL1r7OxUUxylALgW+wLqgDL+K2823ehs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TtAUGRcJ6AWlPqIQMLOFqdpWYxlTC4E2nUnOT3chDTEIsmQcnbc7C4Y2sSB+uTDKwOvo2ZRT6Em8+BPrJnX7eXUTotZQn8/QVz2bJayIE79ffJW5RQRmoE9taCWO1CRXKXSMtue7nY/k7SBTekqwHh499iyRUbYpsQOFjkQrA0ckSpbIO9s0kAJ7nZE0iUrOiqvUKvT1dA3BtLcz5cjBQsNYUdJq+D9dJ9nsXo7du0pJvj30fC46fGjK2Fb0oDCav9SQ6O8F+n4Ny5fHFBYw4zeGzzIlme6w72w8fxAFJJS2I8DsZiwUGAxrBHih8QF8wD9eb0Gf3vg1RbgJMx1eYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jJvqjQtYhPn+5rlwiCulIyzL4lgkY2x9AtSglnQ/lYY=; b=BUubzy05M5a0o/rrnDSXc2KdVNLdPVbJYF1vXwuI3/COJyE/qtHU44Dl3N54SOa/fu/35NVq+uVAGrPBVNXLVeUge3lOZz6SgrGkjDkjsf0CCohtaUm397MMHWHoKlzfgWUPT0NDVZ/OILkn8pomnIoZgwZ7XLrU1HMBt+mc3XClJEnNlKc2NFjlgVA2oaBTo1lN3Mup6A5NInGri1ekKwe78rvvGzamNFBrREnJ2nEKadoQ5NFB3sW9jYunsvp1SIMclM93siICuij+o1E10npQlj8GB80SeLV7W2OsvQivrs79f+K5bjWjAMnQrVdUTAr1zajM6lpYD7FbYq4NXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jJvqjQtYhPn+5rlwiCulIyzL4lgkY2x9AtSglnQ/lYY=; b=ZUpGE89U93omH662/JXtCNc15E3velUKg/MY+8EtCB58awMrAJ55DvQpiyUbXmRWgGbeUbeaF1kB4Mf/vJIUzh9u5D1IYs0UbuSUkN9eR4mUz6yAUzJl+btZ4QsOeyW8mPHysbYosEhYL1r7OxUUxylALgW+wLqgDL+K2823ehs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <00e4f324-18b1-4120-bdd0-2715cb8c8481@arm.com> Date: Tue, 11 Aug 2026 12:27:24 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 2/9] mm: make hw_pte_t visible to generic PTE interfaces To: Anshuman Khandual , David Hildenbrand References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-3-usama.anjum@arm.com> <7xbai2nyu6nuyr6otqv556dnphpgwaqsmvwkqwoqwbh5nvj3ns@ddy5ezgvb7w3> <85286df7-363a-4671-bce8-8157ae5c8f02@arm.com> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: <85286df7-363a-4671-bce8-8157ae5c8f02@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0528.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::10) To VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3421:EE_|AS8PR08MB7790:EE_|AMS0EPF00000197:EE_|DBAPR08MB5591:EE_ X-MS-Office365-Filtering-Correlation-Id: 844557b4-3d08-49e0-57de-08def79b9ace x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|23010399003|11063799006|56012099006|10067099003|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info-Original: MTpsf3IvsMf7LVKWeyhvKaEhr96cF7yvH7aAkJB0bN7Dz2cNvpHXLH1fyHZGxfSN239QNIaI0+Jcok45W8o6dR4xsKN68cgbWwRp1dzQPww8VsZXlkd40hV+KhrcssadBi6n0BtjeK57do7GEQf9oFzJbDCKBGKEr/aV+5jAIFyIZeHeh5kMOB9Qrjk9lo8ssRQA+eChm6iIsXGtD+CSOW4NioxM8SGHVL3AteUAnM8e4g774whpKM+LAnfDDjcLSX4MFF9hSkCzLPofT/OqYQzv+EwMtqda4QQ3+eunavGYKJYsOeegTMveEFkeBGvj6JTMm/hOKqolApr0MUGBdr41GqT/ssdVZNPKYsYEt9xqPyShcC5PyLIgKCnX0v/tTebELHCxdk51b5+2EAOWhVI77v4UDPfelMHZNmq21/aREZCxR9W6n0o5k4YLX5a3uijZLV6UVlfpJNgZ3QuTO2Bc6BphO3IM+ARnj71zys1h3r+Kd1pb9EbS1Jq989xaLY051Ts6i4KRA6aMFZo9LueNV/CeTUhnbiREzQtnXolfLW9GvmLGkm7fnud0MoPESxMefIj4l0ubl/7OWFxpNp2b3IZPQBAFKTvfGCVWSb5hVvqbhexADPkBEFLs81yOY+RJW4pds8/DrhzuSgfKHQo42UznNPz83AM+zvWSmgA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3421.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(23010399003)(11063799006)(56012099006)(10067099003)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: hdQ7nn26YN7Vq0hE6oTx+kKoU45kJvqrMn0abldXFwKud0iJoW85VnYLUJpGpJvIJxgBFh5raADG36uRwV2AaPoefUNSSsVWUW5Y0zg8xQjIC+gS+uPl8TNSAFyKERlMdMsUi0xE67L6J47pXwlISmSbpRVwkLFrYG++90jViVROoUAQ0CjGmPthS/NBEXTu9BnqGOFLyjUMftDMlwsgCQzUj+8ciRZetLxOt7/pjNpvjEIqP4rEUksxKtNuI3nmtRimaXmtBqx+3z5zVXMWLYpAPEr4PTzqyXYAU22s9MqBWyN4hojABhxaeNE2vm0Mc7y2GYdrTtg6FpMnYERIRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7790 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000197.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 18d48398-875e-496f-3753-08def79b8605 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|1800799024|14060799003|35042699022|36860700016|23010399003|22082099003|18002099003|11063799006|56012099006|4143699003|10067099003; X-Microsoft-Antispam-Message-Info: 2EUmajtFjD2DNOQiqDYJhx/duHHhmL0owb4dTyfZ9bsnUL0uoX2XHDDcNEc8ffXH0yXFMc54S3eDdd3FK7Rgvf4oSdqjiuUijkmLVLhvYqiCS6p8fA/HIzvhi6DErNoUOFkJy4QHGrQyelLZh56K5hTOBUnG1R5SLFbyT4aPXHyPwsw8wUBIP9Y9rXgptG6nI/+P7u4RJRImjY27HbdHVXIJgwWS6rL/yVVXlDfZuS4eh/6+ZD5HHB9ucDqX4VFdjRdQxF8HJxek3eSNARe4FG/qKSh70eBDyPnSouR7KyaGJMR/2iMOrQaTK7DsGNaNX9Rm2OyL+30OXWY/2qczX+GyRC5rN9DAiEQhB3Nwo4lOeinyDhdoGapUIK+wGhd2NmJ7dikDhU/t+9ZF/O0XmDzmqlpA16nEikeqk4T9qWAuMIphpCWAnKhVQ0lg0uDbNpFs7KJXbDVsHyPCmrHptMgrtBPYXWY7zodgjZzIcSCYwgXWfLiBRhg6tbathu7RR3dFRTSo4E0WFqB9nQYl46Pyb4ttMR/EQ3BkRR83ob34C+egtvZWEdiZtbTCwt5jBuwjLoWW2cFDMx6CMCdAgWQz9boCtXX+LZNxDTVtT2tu7m0Y3zuKxbu+sK5MaVwhDmgDFOgKIqWUBggriZgqwdFaqZsSSnIl4BQlXlIEigG9yMV6bK1RxorlpjUUuOJJMGm8LrT2Y7fiutRFecm12w== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(1800799024)(14060799003)(35042699022)(36860700016)(23010399003)(22082099003)(18002099003)(11063799006)(56012099006)(4143699003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WyhUxGQhEoSVrTLtM6KTQBdls8wJsW8gVWLkbWdx6cT7Xk/GYLPsBmlh93x9ztJFgtKrG41K/BR325MTqhuTQWTOaCrXraK0rMkVwnxR47oSdh9fsdqsKI+B3VpHMqo4o/Hv/BDlEsUXshXASkbsuTmzu1uD1bz0cGpBPcmOfP+Iid0iyfWDi72D4I7Ue+JJkSYEQYbepcZRsEhuGUIVVkfPWqPOga74+qtzICPnzDmuWc7QVcFVVVv0fZsfk7ZGiKMz8epspjJVn9Q/22nE55LUCy6f3tDgfOUCAEc3sw7T0cSYCJK554b7Cfd0iG/qiST8q0ESTYex1eiK8/ENww5D0y1dJNo92UpI+ykfXr+eBR4Azp5L80JDcstN4cax67P2PQm3jW1TJPF8UYWxA82cG2ywWMYG/z97+a9N57pgyA+k9Yizy3VGl1dJjFYh X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 11:28:02.1748 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 844557b4-3d08-49e0-57de-08def79b9ace X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000197.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5591 X-purgate-ID: tlsNG-4011c0/1786447690-50ECACFC-EC485AD4/0/0 X-purgate-type: clean X-purgate-size: 1210 On 11/08/2026 12:25 pm, Muhammad Usama Anjum wrote: > On 11/08/2026 11:15 am, Anshuman Khandual wrote: >> On Thu, Aug 06, 2026 at 09:38:40AM +0100, Muhammad Usama Anjum wrote: >>> Later conversions use hw_pte_t in page-table checking, generic page-table >>> helpers, and vmalloc interfaces. Include linux/pgtable_types.h from the >>> headers that declare those interfaces before changing their types. >>> >>> For vmalloc.h, replace the direct asm/page.h include with >>> linux/pgtable_types.h. The latter includes asm/page.h, so pgprot_t remains >>> available. It also provides either the default alias or the opted-in >>> hw_pte_t wrapper. >> >> Stand-alone header file updates are not ideal. Why cannot these changes be >> folded in, where hw_pte_t gets used first time ever in the above mentioned >> places. > That's correct. This patch should be merged with the 3/9 patch. But that patch > is already too much big as it was generated with the help of Coccinelle. So I > kept it separate. > > Do you still think we should merge it as its a special case? Sorry, I wanted to mention merging this patch and 4/9 patch (instead of 3/9 patch) in my previous email. Thanks, Usama From xen-devel-bounces@lists.xenproject.org Tue Aug 11 11:37:16 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 11:37:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388138.1629348 (Exim 4.92) (envelope-from ) id 1wtkn9-0005wR-GS; Tue, 11 Aug 2026 11:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388138.1629348; Tue, 11 Aug 2026 11:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkn9-0005wJ-D9; Tue, 11 Aug 2026 11:37:11 +0000 Received: by outflank-mailman (input) for mailman id 1388138; Tue, 11 Aug 2026 11:37:10 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkn8-0005wD-9p for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 11:37:10 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtkn7-002mMV-3y for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:37:09 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b094f-8faa-0a2a0a5109dd-0a2a4508d310-48 for ; Tue, 11 Aug 2026 13:37:09 +0200 Received: from [185.255.28.18] (helo=prod-mta-13.swg-srv.net) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b0964-f659-0a2a45080019-b9ff1c12b5c7-3 for ; Tue, 11 Aug 2026 13:37:08 +0200 Received: from mail2.vates.fr ([37.26.189.201] mail2.vates.fr) (Authenticated sender: 8631fc262581453bbf619ec5b2062170/smtp/7773de5a-2839-4720-82ee-e06722ae1d3e) by prod-mta-13.swg-srv.net (ZoneMTA - prod-mta-13) with ESMTPSA id 19ff09caa3e000c4f3.005 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 11 Aug 2026 11:37:06 +0000 Received: from l14 (areims-651-1-80-194.w90-18.abo.wanadoo.fr [90.18.187.194]) (Authenticated sender: anthony.perard) by mail2.vates.fr (Postfix) with ESMTPSA id 18AC5836DF; Tue, 11 Aug 2026 13:37:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; q=dns/txt; s=selector1; bh=HbKT3tjKmo2Wqu6bcz55wVTzl9OCGMakPKGimwVDDKU=; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references:feedback-id; b=rF/snwwMgKIg3PZvgsaKdHFLk475gdhoAK9OVwJoTzPGUhDNeliqWHpB01yK05cKD/dzS3Vff O2YN28Pmbr4Vb2NuVlZ2OzbKbzi46HhcB6tFFKEFW7ZawKPF0kCb2iVzAXKFLcKJcaIVyDDAh9l WZEqCZ/Em29zECPV6E03tiLKVVEtYFVEkFewto96FoycOulA9vkgToOvwpYSovThDlpNshSvHhY Ed1URNcXln4fGn+ptXg0Ve2Twhi7K+pVYaOa25cXZsuf4XsMKc04pqb8VeD2DvgA6Z24NlfvJQ4 hUSgN8PCrFQWltebIsVtD0YLrB8DOpRN7mYYYlmzI15g== X-Zone-Loop: 62c2916f754a8d01808af4afdaafaeb541c8b002e9f7 x-campaign-type: default x-transaction-id: 1dbb7dab-c6b9-4cab-88b0-efd3a2a28ecc x-swg-uid: 01-2d7a2f89-d12f-43ce-949f-fb2065a5d50d X-Mailer: Sweego Message-ID: <1786448226.8631fc262581453bbf619ec5b2062170.19ff09caa3e000c4f3@vates.tech> x-swg-bid: 1786448226.8631fc262581453bbf619ec5b2062170.19ff09caa3e000c4f3 Feedback-ID: default:8631fc262581453bbf619ec5b2062170:Sweego x-campaign-id: default x-client-id: 8631fc262581453bbf619ec5b2062170 X-Originating-IP: [37.26.189.201] Date: Tue, 11 Aug 2026 13:37:05 +0200 From: Anthony PERARD To: Frediano Ziglio Cc: xen-devel@lists.xenproject.org, Frediano Ziglio , Jan Beulich , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Teddy Astie , Juergen Gross Subject: Re: [PATCH v10 0/10] xenguest optimisations References: <20260810103018.54564-1-frediano.ziglio@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810103018.54564-1-frediano.ziglio@citrix.com> X-BM-Disclaimer: Yes Content-Type: multipart/alternative; boundary="-=Part.20dc.8a7aa5d03f4209ef.19ff09ca7b9.38730e8a748c5409=-" X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1786448226233 X-purgate-ID: tlsNG-c1860d/1786448228-CC57487B-073DFE6B/0/0 X-purgate-type: clean X-purgate-size: 1426 ---=Part.20dc.8a7aa5d03f4209ef.19ff09ca7b9.38730e8a748c5409=- Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2026 at 11:30:03AM +0100, Frediano Ziglio wrote: > Edwin T=C3=B6r=C3=B6k (3): > libs/call: cache up to 4 pages in hypercall bounce buffers > libs/guest: allocate various migration arrays just once > Frediano Ziglio (6): > libs/guest: move batch_pfns into a separate structure I've committed these first three patches=2E I've notice that `git am` will put the wrong author on your patch, it would use the gmail addr instead of the citrix one=2E Could you fix your config so that `git` does the right thing? I think it is just a matter of changing the config: git config sendemail=2Efrom 'Frediano Ziglio ' (with maybe --global or with an identity added to the config option if you use that)=2E This will tell git that the email is send from a different email address and it will format the patch appropriately=2E Otherwise, gmail just overwrite the "From:" without telling git=2E The original "From:" is still available in "X-Google-Original-From:" but it's not something git should care about=2E Cheers, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vate= s solutions web: https://vates=2Etech ---=Part.20dc.8a7aa5d03f4209ef.19ff09ca7b9.38730e8a748c5409=--- From xen-devel-bounces@lists.xenproject.org Tue Aug 11 11:49:47 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 11:49:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388150.1629357 (Exim 4.92) (envelope-from ) id 1wtkzE-00083o-Hu; Tue, 11 Aug 2026 11:49:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388150.1629357; Tue, 11 Aug 2026 11:49:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtkzE-00083h-Eo; Tue, 11 Aug 2026 11:49:40 +0000 Received: by outflank-mailman (input) for mailman id 1388150; Tue, 11 Aug 2026 11:49:39 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtkzD-00083b-Mr for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 11:49:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtkzD-006hMg-3L for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:49:39 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b0c3c-2eae-0a2a0a5409dd-0a2a4503aaf8-30 for ; Tue, 11 Aug 2026 13:49:39 +0200 Received: from [209.85.221.42] (helo=mail-wr1-f42.google.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b0c52-fae8-0a2a45030019-d155dd2ae1f1-3 for ; Tue, 11 Aug 2026 13:49:38 +0200 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47de0093c42so2150665f8f.3 for ; Tue, 11 Aug 2026 04:49:38 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4814a72cea1sm4368958f8f.37.2026.08.11.04.49.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 04:49:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786448978; x=1787053778; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2dE/foGziw/KGa1/idt3BoTG5ZRQ5Ek4O5T0IJYTeDw=; b=qPm9EsXkRCR9SkZeCr3MMnOUxXwO1zRomagA+jG5q1RRj/nsMslTVdcVoF40DK7Avn QoYz4J8DnnJ0xMAIJ/cF9zVgo2D8n78QKE7I7h9KjcApsBxrLMY+Qpp8hvyy+lhq07/t q7q+TOahNFbpVuOaf9B5TQB7YWhEaPbNrnQgMz80qHemahE6iXHyy09OCFoe/RBgca10 b/e9dDDgIctsMiAICnPY37SdDiaa0DQRS1C5HH1IznFriVPvMHu7kY4FC56U6jhixlYv n47hykl89adphadn3DpnAisSbXLWoRITNAO4TGB75y8uun0ImrMjwE4msQ3Q89s5DtSg SuMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786448978; x=1787053778; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2dE/foGziw/KGa1/idt3BoTG5ZRQ5Ek4O5T0IJYTeDw=; b=WmrrWok6+IkOQdiCO2fJ3oiI8TV6JaZ6uLdGDGxfU3gpE3cFEwltJ4bM8iK/8p6vJm fRk2nSNUx6/22LTcQJJZBTOG1xDVOW6LEWNJRPzSPKiPzuCmGoau7YJrx++XguFYKbSc B8JE1MehSRkPWnJcIkCifw9CrCvQWbNGgSsSZmHpUmOGN80587GCAeAW+iGAQjmaetCu LQo8NJNb0M/pIxteOziUXqMgIgjpW4aEv/LjpYvc7KugUSlI5BTTlxbubd/z+w6QT17r Irx7jTDmUyL9soIosbnAHU+AKNBcrVAJrt8iP4LVoUUBX8KjGT+6aox9AYdW4DeMwkw/ lYfA== X-Gm-Message-State: AOJu0YxtfrRRay+hcgGHbLGBmbB8A3aWqm27bJ4SCqJztrJ0y9XtXhVH muSmGUKCZajMDUGOtcHsjFtf8UggNkAKARs6L09RhbucYdcXHZ46njU9 X-Gm-Gg: AR+sD13WD2cmkRxrEJeiYkmMM37OdSacv8XpS2TyEMvtZNimWo6nvUcH27coiWSSg9O 0M5u5WGRB7+lUPoScmYlTgbDwclPGjtDS3lFeQxNP5Vz1+tnhn0zNcfWuCR7Sh70QJdPZ/2p63Q V0TKf2cb0+lQpZzLurWArfQhUotwiDdx6974nZbZbFrEkCxdwEpuEdZD/xr2Kutskp4Ldvwe+Ay Oo4EDTw0F8dTMiUR0b/UWMd5yrkpQLnx7uM0wmKUsrmvTm7eIwnQf+DlaTsR/N4gjr68hirM8mj 8rfYbfdu0l7QV07tMpvpCXNynbE+13BVHKbCrzVhbKTgblk3AFNy9b0GuGQmnIBZy5EteaD6Ac8 aPGtpougsx+8YYGXy7unJJ8AOj0eoQN7VdS1UVmMfiOh2jjpUQGJ8nTXh0aji7cXTzYCH351vAs ylWDNiFvbAqd57wKNm9Tnr2hqxmH1U485dg4BkLj72gp5tseyNQbk3QrwTyz76pNgTzuUjvNOzt aaprc6ytrtAwbXRghsOXj3Dhhj1Rtg7sKCA6o4CeYc= X-Received: by 2002:a5d:5c81:0:b0:47f:8480:4abd with SMTP id ffacd0b85a97d-4814aeec2aemr4394446f8f.29.1786448978236; Tue, 11 Aug 2026 04:49:38 -0700 (PDT) Message-ID: Date: Tue, 11 Aug 2026 13:49:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/17] xen/riscv: introduce device-agnostic MMIO emulation dispatch To: Baptiste Le Duc Cc: xen-devel@lists.xenproject.org, Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini References: <1786373377.8631fc262581453bbf619ec5b2062170.19fec268e07000e099@vates.tech> <05283ea0-de82-4160-a3f9-5fc1292a20a5@gmail.com> <1786436246.8631fc262581453bbf619ec5b2062170.19fefe5dbbc000c4f3@vates.tech> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <1786436246.8631fc262581453bbf619ec5b2062170.19fefe5dbbc000c4f3@vates.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-33051d/1786448979-766FB4E9-3F01239B/10/73395122804 X-purgate-type: spam X-purgate-size: 2375 On 8/11/26 10:17 AM, Baptiste Le Duc wrote: > On 2026-08-10 17:36:56+02:00, Oleksii Kurochko wrote: >> On 8/10/26 4:49 PM, Baptiste Le Duc wrote: >> >>>> diff --git a/xen/arch/riscv/include/asm/mmio.h b/xen/arch/riscv/include/asm/mmio.h >>> >>> According to coding style, it should be GPL-2.0-only. >> >> Could you please point me to the line in the coding style document where >> this is mentioned? >> >> If you are referring to: >> New files should start with a single-line SPDX comment to express the >> license, e.g.: >> >> /* SPDX-License-Identifier: GPL-2.0-only */ >> >> See LICENSES/ for a list of licenses and SPDX tags currently used. >> >> Then my understanding is that /* SPDX-License-Identifier: GPL-2.0-only >> */ is used only as an example, and I can choose any license from >> LICENSES/. There, it is mentioned: >> Valid-License-Identifier: LGPL-2.0-only >> Valid-License-Identifier: LGPL-2.0-or-later >> >> I am pretty sure that I am free to choose any license that does not >> conflict with the other licenses used in the project. >> > Oh ok I didn't know, thanks for these explanations. Could you let me > know how do you choose one instead of the other in that case? Is there a > rule from our company to follow somewhere? I don't know about any specific rule from our company. In different situations different licenses could/should be used. Specifically here I used GPL-2.0-or-later as this code partially is based on Arm code which uses this license so I just re-use it. >>>> +#ifndef RISCV_MMIO_H >>> >>> Nit: line too long (85) >> >> I will apply that. Actually I've already fixed that by putting the >> comment above: >> /* store: value to write; load: value read (set by handler) */ >> register_t data; >> >>>> diff --git a/xen/arch/riscv/mmio.c b/xen/arch/riscv/mmio.c >>> Should be GPL-2.0-only. >> >> Regarding license I've wrote a comment above so lets continue discussion >> there. >> >>>> +/* >>> Why have you included a copyright notice here, but not in the other >>> files? >> >> So I just decided to do that for new files as I am not using corporate >> e-mail. > But why didn't you do it for all new files of this series? If there are such cases then I just missed to add it. I will double check during preparation of v2. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 11 12:12:05 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 12:12:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388177.1629390 (Exim 4.92) (envelope-from ) id 1wtlKl-0004SL-LO; Tue, 11 Aug 2026 12:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388177.1629390; Tue, 11 Aug 2026 12:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtlKl-0004SE-Ig; Tue, 11 Aug 2026 12:11:55 +0000 Received: by outflank-mailman (input) for mailman id 1388177; Tue, 11 Aug 2026 12:11:53 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtlKj-0004QX-BH for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 12:11:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtlKi-00BxPI-Eh for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 14:11:52 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b117e-2eae-0a2a0a5409dd-0a2a450586ae-26 for ; Tue, 11 Aug 2026 14:11:52 +0200 Received: from [172.234.252.31] (helo=sea.source.kernel.org) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b1186-4cb1-0a2a45050019-aceafc1fb6d2-3 for ; Tue, 11 Aug 2026 14:11:52 +0200 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id AD2A843649; Tue, 11 Aug 2026 12:11:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E88261F000E9; Tue, 11 Aug 2026 12:11:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=k20260515 header.d=kernel.org header.i="@kernel.org" header.h="Date:Subject:To:Cc:References:From:In-Reply-To" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786450309; bh=/fTG1Cghw/RG7+KE3x88oxH8TI74VawrjBf3qjRRniY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=oMzFJcn9VOzkFaKMEx9vCYCdx1Pq7igNm3SDyOEjzrOpDudIApIUK8tbQWGyhMTA2 t05Mkqhok9RLYIMUol0cpCiu3QthaSWyzaAoYQ2iTd1AckujJZDZf2+JmOHRJ0KvP7 mcsYLS8a7sO8YaLXbyWEeOK99DFlaVD5L55J3MTekojG6h3FMWYgpjeoMH//X24lZs 5lfWAxjxOdrK+/s8jDuKs0rLQeM8RFflAxNY1JPwZF3i/yhkf94kLkVqbTR4mmJWjo hK2SQwlx7kI/9C/spjKPKM5IkvDG9SLQ6RAQ5o7kkbgcPTchuBQb5gh+4ZPvUgW8mp IkyibBYe3lp/w== Message-ID: Date: Tue, 11 Aug 2026 14:11:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/9] mm: convert PTE table entry to pte To: Muhammad Usama Anjum , Alexander Gordeev Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-7-usama.anjum@arm.com> <5c329236-7761-4e42-a549-b822e43b4358@arm.com> <2599c5b3-e8ac-4865-993b-d41e6f060d52-agordeev@linux.ibm.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-c201ff/1786450312-253192A1-2F56CCD4/0/0 X-purgate-type: clean X-purgate-size: 2594 On 8/10/26 13:06, Muhammad Usama Anjum wrote: > On 10/08/2026 7:44 am, Alexander Gordeev wrote: >> On Fri, Aug 07, 2026 at 05:26:04PM +0100, Muhammad Usama Anjum wrote: >>> Yes, this is particular line is for non MMU. In this case, CONIFG_ARCH_HAS_HW_PTE >>> would never be defined. Hence hw_pte_t is just pte_t and direct dereference is >>> allowed. I'd thought a lot about it; is better to leave direct dereference here >>> or use some helper. Then used __pte_from_hw() was already being used in generic >>> ptep_get(). >> >> But in case CONIFG_ARCH_HAS_HW_PTE=n __pte_from_hw() is still gets called. >> That looks inconsistent to me. Why not just call ptep_deref() (see below)? > > Agreed. Calling __pte_from_hw() directly exposes the representation > conversion at the call site. I will introduce ptep_deref() and use it > here. > >> >>> There are only two users of __pte_from_hw() at this time. >>> >>> ptep_get_sw() or ptep_get_deref() is better name here? >> >> ptep_deref() would be it. >> >> Do you agree to the suggested API requirements? > > Yes. hw_pte_t * identifies storage containing hardware-formatted PTEs, > regardless of whether it is attached. ptep_get() is used for attached > entries and may provide additional architecture-specific handling. > ptep_deref() is used for unattached entries and performs only the raw > storage-to-value conversion. > > For review, this patch would become: > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index bc0b9c65aa1d0..ce900d2652d91 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -1283,7 +1283,7 @@ static inline pte_t huge_ptep_clear_flush(struct vm_area_struct *vma, > #ifdef CONFIG_MMU > return ptep_get(ptep); > #else > - return *ptep; > + return ptep_deref(ptep); > #endif > } > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 1768421755a9c..08613593f3320 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -490,6 +490,13 @@ static inline int pudp_set_access_flags(struct vm_area_struct *vma, > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > #endif > > +#ifndef ptep_deref > +static inline pte_t ptep_deref(hw_pte_t *ptep) > +{ > + return __pte_from_hw(*ptep); > +} > +#endif > + > #ifndef ptep_get > static inline pte_t ptep_get(hw_pte_t *ptep) > { > I mean, how many such users do we expect? 1? :) Why have a helper for that then, that seems to encourage it's use, when really people should be using ptep_get() ? -- Cheers, David From xen-devel-bounces@lists.xenproject.org Tue Aug 11 13:01:48 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 13:01:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388195.1629407 (Exim 4.92) (envelope-from ) id 1wtm6w-0003A0-7K; Tue, 11 Aug 2026 13:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388195.1629407; Tue, 11 Aug 2026 13:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtm6w-00039t-4L; Tue, 11 Aug 2026 13:01:42 +0000 Received: by outflank-mailman (input) for mailman id 1388195; Tue, 11 Aug 2026 13:01:40 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtm6u-00039g-G7 for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:01:40 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtm6r-009LCC-Fz for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:01:38 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b1cec-2eae-0a2a0a5409dd-0a2a4509e918-18 for ; Tue, 11 Aug 2026 15:01:30 +0200 Received: from [52.101.193.24] (helo=CH1PR05CU001.outbound.protection.outlook.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b1d25-be1a-0a2a45090019-3465c11832eb-3 for ; Tue, 11 Aug 2026 15:01:27 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by SJ0PR03MB989491.namprd03.prod.outlook.com (2603:10b6:a03:407::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.12; Tue, 11 Aug 2026 13:01:22 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.024; Tue, 11 Aug 2026 13:01:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tukdJ7h+jvWFTWG/Rs5CNwcYyKka9m9B7ujc0Gjs6WqZpi+jAbWUT3kN4en1i8m/YLvvlgGVpebo/UvnwZGUJ4u2fIQD3EQk8BYZq2lEzFXQZy1l3WXC4NuWvDbdJQJAtdmnykrOba8Ql80EyQQh7ysnlsEvSrFAowTSITkSYZVihckPqk8t4Jv5O8tr2BXXMBMmuG8pT0KalQ3IzbOFXkGq2/OFDv2KhFZE2EL9vLRTTxiLpZn+VcU7QUCFCFrh1qVyFiIBY/TabVTqRBECTC/wDfhFNp26Y/HfD0scIZzdMqqGzlPB5oZcjQuNBG9IPr0Ts1XRljnO0kR08LaK/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZ+jG5N07na9TTaIn652mOqplbTmcBrD7nwVlzdekfM=; b=MQGN/QJeV7UGBQxCFA3PO5ry+h4x7Q08/eNs03VO3TgtA6G/5yAtIVepCD71/gGECHLRElHZQv8dXE9eewhgMXxxSK+KtumZHuunqwIdWwVz1WgeKTViMSyZJh8H8ikE1ja9+r4Uq3/u+k8QupuqIMnUNv4lL11HcwVl1ernoLv4xCdkgQ1RLjeRPh18AiMmBVl+PY5HPlK9uaJkaudnwIZjZtJUcD4LwQPXxgWwd5q8rTHK/eUwM19ouJ3bYlBZU1066xbuaK7ILKpdZyzVW6UZhOvsXdg/V1Hd5+T+uIQDacOcHrUgEVkkz3l/RH4e8UX+NgxCR5W8XdD4p0noXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZ+jG5N07na9TTaIn652mOqplbTmcBrD7nwVlzdekfM=; b=DZT6Z7wwZt2L2URLA4htGJKPxxMsqj759/mgzu6lkPZJvpMNIbaQaUWyK5RzaU1oSLnlzsfAPMWFGHyQjTcCDP7d7jKpNCi0+/i3vY2s3vdGTApIQ+U3aFHjOT/8hkJVKLbixGuB0WYh8daWIHDopKSc8SinKwgBwLRz3Ky8px0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7b2d0e8f-5c6c-4002-a123-d96c90030e54@citrix.com> Date: Tue, 11 Aug 2026 14:01:17 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Anthony PERARD , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Wiklander Subject: Re: [PATCH v2 3/3] xen/arm: handle irq_set_type() failures To: Mykola Kvach , xen-devel@lists.xenproject.org References: Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0018.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::14) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|SJ0PR03MB989491:EE_ X-MS-Office365-Filtering-Correlation-Id: 32266a46-e3ca-4b64-a19f-08def7a8a43d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|23010399003|18002099003|22082099003|6133799003|10067099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: uP40TFpYN+NtvjONtLsfW2by/sdA2/7fOrahfVWxjVqGLVwfMtqMIKhPAMlN8Nh/rXX+6PZMMWBTr8+MRXejj2tVWS/6xwkrPX4IVPR0wD7HTttYHihOQSl4NfINmBWVDUeZCyQkMzlMW98jcVxrXXG5XFAZ7GAD1/jQa4pwKeSnl2PkGjITQ4Y/hwAl6j+OtXCgw2rBHj8Ib5YYJEp1r9mDuleytlmOsRAk18DVZcoXJFhWSdiVzaXGRt8ysf964YlR3O8kT9G9KNNudd/FHzJHU7nS4eydesvaEZ3lDvDhKwj2dH5yNrez7jCk/+8NdqvmzxM2qs3NqLChu2U+NFbtTeEq/fS3unX/7ovoj4bdQyRy+ISkOAcwYGmb1Zkljldj86m9S7e/35VajXw6eJlwBO3HT9MkZvddM8GrsFA4DMK7oGk86JfSERrkaQpFr+L08efXtLPcWcyiaP78ySmJi/N7Sr33S2fWK+wynXtR601bCkOVziFWEAATvZMvMxEDsO8Cblhn8fWFD37sbKyTrvrhT/QkyDiALgo7pF6J3MzqPX84i77tCVoXFh9Kvl6+hqTKVUOdP05Lv/K7MJl5cIJYH1ibhe3p8hNLJ2KZxwOXZgrfwThINSEEURT7r13i22qI4zC31a2ETLNwa6D+Vionk/2rYufLThKKlU4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(23010399003)(18002099003)(22082099003)(6133799003)(10067099003)(4143699003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SG5FMkdPMEVrenRwRG9xdGdTdWt6aVp2N0hKeWVydDhjQzYyUWRBSUdVamVE?= =?utf-8?B?Yk5QVFl1NTRDNlBGZkNVRlFMK3llQmtsVlVnM0IwSStoVEJ6aGUzVVNkZ2hF?= =?utf-8?B?MHRReG1mU3oycS9BeG52WTRXcVVLUWl2Tk1WNFNNTE9OWGgzTFZDQytHcGhP?= =?utf-8?B?WDVGVW80Z2IzM3JIUytPaTNtQUtrY2VrcGljWlZ6WXJWVlZXWUVBRFdPczVF?= =?utf-8?B?YVpTNkdhZU1mM2lBR1lCYXRHR0U1Uk9KUGJqUEJoVEZld3JjaHI5UmVPNXpD?= =?utf-8?B?OWNJaW9wMW5EYnYxaWNEZ1IwU2NUalYxV2ZXTFF4VHhSaHhHL1RnMk5TVS9M?= =?utf-8?B?Tm43YlZhKzI0UHd4SW9HM3F0SWRLSjMzNzU5NGJ4YzhScUtUWXhHcEYzTnRu?= =?utf-8?B?WUdITGorR0NRVDVVRkJSR2VEMkdua0ttTjB1bDFOdUxnVE9FYzJiUTdQNjZv?= =?utf-8?B?OTJWQ2dLSnhlS1IwNWNjdDhIV2VOeGhHSUdnQ040NG9XUnRuTFdnQ0gzd0hZ?= =?utf-8?B?UFY3aUUrZDc4T21VVzlxM2NFREN1MWlobFRUM0pYM3JXUDlsaXlzNS9Jbldp?= =?utf-8?B?R2Z6TE4wR3ZpcTB2MUhiNkFUaWJsSU4vMEI4eEhRUVR4T3poMm9mek1DMW5h?= =?utf-8?B?dWllbWlkNlFCWlFsTUNDQ05XcS9vbDJtWlFPazBWUmFtZ2F0U2E2M21zVnY3?= =?utf-8?B?YlFQVWJscytxKzZMYkNmSVFKSGpIM1lGYzB5TElZQTl6MGpCSUVOeWk0UlpO?= =?utf-8?B?cTRSdFZNMjZVaUtqbm5acVhrREV6K2dBa0dINFNZdWJTWGxUamVwRDJQeWZR?= =?utf-8?B?L2ZFcGNOeGhscFBvanR5NUtjTUIrVmdnQk9MenI0YmtpT3YrelR4SU94ZmV2?= =?utf-8?B?QStSTWN4YkVHSmNTKzNpVExVS1FqamhMcUtRMkRZZ2FQQm9FQ09yUUxPc01n?= =?utf-8?B?TDZnR0t0N21xSUxrSU1sbnB4bTZ1VFVxUDg0TXdjaDJpdzlNOFRXdUpwaTk2?= =?utf-8?B?TzlPK3hPNHlqR2VrSDJCVWNTRTdNOWRBd1F2Z1o3SEoxQStjMGRaZndzVGJs?= =?utf-8?B?UlMrdjI5ck9BWEZoN1V3TTQ1bHorTjVjMlpOVXBVWjNnZDZZSnF3S0RjLzUv?= =?utf-8?B?cTV1NzVwalR2Uk4zNytPZDNaM0V2MG50Z1FUYUNWN2FhalJRd2lhdU9IaFE1?= =?utf-8?B?djEvMWpvNWIrVGhYWnNTTm9aMHRMRDhEYTlOSVNGZDJGTkx3SXhuUVhHYWxW?= =?utf-8?B?N1lVditzQjNUbkcxbTlRZ0hDMGdFcE52UVBxY2tFeGZveWlFejRxdGhoRkNP?= =?utf-8?B?ajVGYWM0VUpQTWRFWTgvYVhKMEwvSkZWRzZHNlh2OVhFSms3RTAyQThxOUxP?= =?utf-8?B?aTRrbm43ZjdRQnV5SndNWU9JRjcwRTV6ODN0T3A3dEFSM0ZGVk0reDU4cU9s?= =?utf-8?B?eWlYbklyUklWVGV6dUlZTlpEcjk3S2xUZFlud1U2cWY4T3NJc0MxeDQyUFZo?= =?utf-8?B?QkVkSXpScU9BbVQ0eldpeiszSjlSbEh2aHZIY0JLTzZGVjk0cVlRVElHR0Vv?= =?utf-8?B?dXU0MTVUSWhiSXBleGF0TU11cFNBcjZEcDc4UkpYVk1NZko3SGM3V1BZYUVy?= =?utf-8?B?NEt3VTMxaGlHSGJvdEE0TTB1c3JrRlRIWnN2TzR6M2JBNWEwZXhYL2U1czdK?= =?utf-8?B?dzl3SmVOellUQWlFYnd4bDM2OGs1cjdTTGFlOGxhbldYa2RFY0RUYytGVEV2?= =?utf-8?B?U29SWkViaW5uNDhEYzJKR0xqY1h4NXpjVnJXdHBrdktrbnF5UGpocGljZXpI?= =?utf-8?B?RldwdjJPV1did0tZRzdjOEJER3NzT0JtUkJ2VCtUWkhHU3VuU2pJS3BwWVVJ?= =?utf-8?B?eDhmSXpnRWlRa00vK3U3YVNmL0xEaHNyb2EwUGk0R1hJNXhyNkF0UnN2OER3?= =?utf-8?B?L3hFSVFndkV1aFB5eThUdGUrbUg1QWtrQjdjTVhheFZLYkVUWWZkeExyWC9F?= =?utf-8?B?STZ3bHc5dWJ0QnRlSEpQbXFjMnNpcW5BN1pmL25KdGU0OGRJeGVZTGd6dHFl?= =?utf-8?B?SWpWWHBkWWFkZTVkd3p2L0l5UXFlVFJZa0w4YzkxUGRtNVpyTDFoZ0ZnbzZq?= =?utf-8?B?eGZTZVpCd29hTUg0UE91WDUyODluWS83cS9jN2hnWkI4cUlPUzlGS0ZEMkdZ?= =?utf-8?B?SXpUbTFNbnI5Zjg1SCtibXlXRk1RRjZQZWhnc0xiQnJsRzZ4ZlVTY2doQWt0?= =?utf-8?B?aHJMOXdIa25aZWJrTEM5Znp5SmR6V0QvOUkxTWE5QWtyYjJITmVMM3loTWFr?= =?utf-8?B?TTZHVzhJR1FnQloxbXBJWFBnejRBZVNUMzhuMjdHbHB1bHdTMGhpcVJ0NjQ5?= =?utf-8?Q?X9SwcXxnqRg2XP2k=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32266a46-e3ca-4b64-a19f-08def7a8a43d X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:01:21.7526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K5ED69T5U97wCvbk8mDsugpolr53SiV1Iqs9GBlg6RWVX3oQY2lDWfTytUMQpr6eHI+TZc8lK9KRb8rrLc5Tpjh67zvb4fL3l/Rl4nQr2N4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB989491 X-purgate-ID: tlsNG-bad1c0/1786453287-BC2F4034-51456E6A/0/0 X-purgate-type: clean X-purgate-size: 2434 On 10/08/2026 7:38 pm, Mykola Kvach wrote: > Several Arm firmware initialization paths discard irq_set_type()'s return > value, violating MISRA C Rule 17.7. If trigger configuration fails, > initialization continues with an IRQ that was not configured as requested. > > Check the return value in the GTDT, MADT, SPCR, and FF-A paths. Store > timer INTIDs only after successful trigger configuration, make GTDT > parsing failure fatal, and stop UART or notification setup when trigger > configuration fails. > > Signed-off-by: Mykola Kvach > --- > Changes in v2: > - new patch. > --- > xen/arch/arm/gic-v2.c | 8 ++++++-- > xen/arch/arm/gic-v3.c | 8 ++++++-- > xen/arch/arm/tee/ffa_notif.c | 11 ++++++++++- > xen/arch/arm/time.c | 18 ++++++++++++++---- > xen/drivers/char/ns16550.c | 5 ++++- > xen/drivers/char/pl011.c | 4 +++- > 6 files changed, 43 insertions(+), 11 deletions(-) > > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > index 43a379fdda..b8dcbb0bb4 100644 > --- a/xen/arch/arm/gic-v2.c > +++ b/xen/arch/arm/gic-v2.c > @@ -1157,6 +1157,7 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, > const unsigned long end) > { > static int cpu_base_assigned = 0; > + int rc; > struct acpi_madt_generic_interrupt *processor = > container_of(header, struct acpi_madt_generic_interrupt, header); > > @@ -1173,9 +1174,12 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header, > gicv2_info.maintenance_irq = processor->vgic_interrupt; > > if ( processor->flags & ACPI_MADT_VGIC_IRQ_MODE ) > - irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); > + rc = irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_EDGE_BOTH); > else > - irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); > + rc = irq_set_type(gicv2_info.maintenance_irq, IRQ_TYPE_LEVEL_MASK); I know it was pre-existing, but this is an overly verbose way of writing: rc = irq_set_type(gicv2_info.maintenance_irq,           (processor->flags & ACPI_MADT_VGIC_IRQ_MODE)           ? IRQ_TYPE_EDGE_BOTH           : IRQ_TYPE_LEVEL_MASK); I expect the optimiser can transform behind the scenes, but it's better to make the C simpler for humans too. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 11 13:08:39 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 13:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388203.1629425 (Exim 4.92) (envelope-from ) id 1wtmDf-0004BI-79; Tue, 11 Aug 2026 13:08:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388203.1629425; Tue, 11 Aug 2026 13:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmDf-0004BB-3m; Tue, 11 Aug 2026 13:08:39 +0000 Received: by outflank-mailman (input) for mailman id 1388203; Tue, 11 Aug 2026 13:08:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmDd-0004AT-IR for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:08:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtmDb-00C6un-GR for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:08:35 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b1ebf-bab6-0a2a0a5309dd-0a2a4504d4c0-10 for ; Tue, 11 Aug 2026 15:08:34 +0200 Received: from [52.101.61.7] (helo=DM1PR04CU001.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b1ed0-b57f-0a2a45040019-34653d07ff69-3 for ; Tue, 11 Aug 2026 15:08:33 +0200 Received: from MW4PR04CA0200.namprd04.prod.outlook.com (2603:10b6:303:86::25) by CY8PR12MB8216.namprd12.prod.outlook.com (2603:10b6:930:78::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 13:08:24 +0000 Received: from BY1PEPF0001AE19.namprd04.prod.outlook.com (2603:10b6:303:86:cafe::19) by MW4PR04CA0200.outlook.office365.com (2603:10b6:303:86::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.11 via Frontend Transport; Tue, 11 Aug 2026 13:08:24 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BY1PEPF0001AE19.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 13:08:23 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 08:08:23 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 08:08:23 -0500 Received: from APPOL-18KY0J4.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 11 Aug 2026 08:08:21 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pjZTF9x1J7t22vx58dyf98E6h1QUv3O6Tdq4bQ5HtbViEjgWBzppyqZ9Vz/xZ0GyaH6PJ4z1eNkF/+sRC9Ptr4e/gVtQIrmvC+5YOrdMOJBLq/21V+bIHzfxBSjuoaqFvc/aKK6dJEkUtBFhEP20x9kifw7nNfQ8L+h658qdzOohlixN9fjW4NNptt96GTxivM8eFHqK28gju/HbajbZAGbLMlFTTQgzTKIFfEENsaBw1FJXe0wJ4a5iLiz20sv0UVPZbJR6TxJC430evlfUqBg9Hqrf8TbiQKCJJfhQ5BwzIsz0UBS/nfMJMngyMxexzJYJ1zPwFB0wYeqe/WQk1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uL5twoODR7h7tXvISrc2qyc1Omt/iP2tMqUXiS6AdPI=; b=Ta5d04Qe+VOXzp6ZdYfV83LJd/NdT9Zqu7L90sNr4S1wz6+saD+oM1b/Lk30LOP/FhhgLddeYq3vQ1mKKaNNOF6vSPwy6pCqx6ZMBBFLSMWlre135Fb21l0kqAuAzwykTKM5NY6T06Bykod7T4C1q6BMkbS4JuGsu7aLml2YAnzKjdO9SCaRU74cM4LsikqdC2ZQ9KL6g48dDmui92PvMRDS73xAnVwmNgYfl+EUAcGBTgx64hvgGOAzv9WcDBv95woUBEcZVqZyORmIeaHdawaizqIZs+ESJ5nSrLmmRlQL9EaqQCYVzgL1m0n4EWdKa3X1+3JYy6HbLxDOSmH9og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uL5twoODR7h7tXvISrc2qyc1Omt/iP2tMqUXiS6AdPI=; b=BcgWIkaItx4W380piZwuVhTnJnNbQsGRamc5CHvuWRFeSozWUlKVQFamLgsvQ9jJtAqtb4tqnqbPw0vGCB9qZx0VcprAF3MLXgvWnFtyxzSiUNhkTWpsn36FF3+1s3+5GQhCE3dCcRBOJy3rP4TLY/RL8LAEpzvMWq5wUYrHaco= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/2] xen/arm: drop unreachable EL0 check when emulating ACTLR Date: Tue, 11 Aug 2026 15:08:17 +0200 Message-ID: <20260811130818.123862-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811130818.123862-1-michal.orzel@amd.com> References: <20260811130818.123862-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE19:EE_|CY8PR12MB8216:EE_ X-MS-Office365-Filtering-Correlation-Id: 48d65d3f-6abd-4c34-73a3-08def7a99fe4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700016|23010399003|22082099003|18002099003|11063799006|56012099006|3023799007|6133799003|10067099003; X-Microsoft-Antispam-Message-Info: bxGwBHES/iI/G1HZkX+RSdBRLyswPdKzdPRxxAW5Io5B6m5SDAHCHURFOkk8R2C60hPsVwtnvcz76Cm1+j+h/eOyS1haEj1yrOtE7xQSrM/RKGG2sBAT/RRkzvXai6dE6xQGYtk/OKWXpnuc0iqQeTcommWdHSCQLZlClaoTVc/FgParuMtfDUKB4upe7KrA45VMehfi0pXRGLemX1dm3ke8nenR7H6tku0EBp1Leyl+uJSsgEREL7m7MDcR6GvweXaQ9MSD+66r/Qxsx7TG/ACeewLS1ft+xlYU1cIxH/5QIYOcFO+H5rXr/sMM0TV9BODxgxryYHnPw+N8F2Jt/QRCBtlWSy/X1ZeJNusic52AF4k98Brc5BI7EU6yj2k3M+VZwIf14lblW+XhpoFsMMiZvMIBefK4QSAbk9Ud9OFbN0Wjr/XBElRzf0zGun+hcVOQm2xh5WIHuGZ+i3DPVKBreAwhXduDeD0R1fr9TcFvwnmYXi2go68QmztigFDp8yO0t7KlRdO2xxfQxLkPCCN/L/OlUK4alJG0rlyt9+uaayPFDZiY2rQNi+u3hKk00BDppgUBjmDKO36XbBQex1kCPoW7m6nrsE+O1b/KoLQy2W2FnRFDbxWmkUKYZer6bAJnAA4b2NDHPzwMWTzYXR+ND1oZRZOWs8M/UcwPdKevV+rYxcQZVBGqTm7GGqbWKAN75S4S6LVVV9H6CZOgiw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700016)(23010399003)(22082099003)(18002099003)(11063799006)(56012099006)(3023799007)(6133799003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: indfLzljTVZSSWcQfsd/j5+GV0/Mfe/NYSnwZ38n65KOk5I5HIZPBCCesI3rwUNrFpMacuf1FYuDz+FmlD3KlpiSzIIKfe4vhlgIAFtnHN5je4w8fv96O36q9xXB4tnEV9B6UbFRjzhNylDVmyLtxN0SRuo7jk+GFBRKmjZiV+1dT8pmTMLDo0NgKFhwzQOLoIE8ksWfTW8NVq5UPKzt2Z1jEekP3/FmWrzymVp3tZejFchPo+4J/D6lQdE+tWZ6Mdm11y69N0kIOjN8qYangBEh/c2N//Vssm0pF3Z0mjkPJYqCqIAH65rb2w35UIAec7yoJZ/DGoaH5foHyJlWbGoCLRhkFVskhElKjm1gjcph7GqTJnaclUD8SS2b3PWn7Iwz+PC4GYuYk3SzRMpgqCBxNb9RLRuEb320fC4NtWZ/Nkb7HWh5qlh+CBZk4XXF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:08:23.6179 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48d65d3f-6abd-4c34-73a3-08def7a99fe4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE19.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8216 X-purgate-ID: tlsNG-ebf023/1786453714-520D5B50-70BBE54E/0/0 X-purgate-type: clean X-purgate-size: 2223 do_sysreg() and do_cp15_32() inject an undefined exception when the trapped access to ACTLR_EL1 (resp. ACTLR) originates from EL0. That branch cannot be taken. ACTLR_EL1 can be accessed by EL1 and above, and no enable makes them accessible at EL0. The only trap covering them, HCR_EL2.TACR (HCR.TAC on AArch32), applies to accesses from EL1 only. Refer Arm ARM (DDI 0487M.b) D1.4.5.6 "Prioritization of Synchronous exceptions": "attempting to execute an instruction that is defined to never be accessible at the current Exception level and Security state, regardless of any enables or traps" is priority 18, whereas an exception taken to EL2 as the result of a configuration control in HCR_EL2 is priority 24. The former wins, so an access from EL0 is UNDEFINED and the TACR trap is not taken. An EL0 access therefore never reaches EL2: it is taken to EL1, as Xen never sets HCR_EL2.TGE for guests, and it is reported with EC=0x00 (Unknown reason) rather than EC=0x18/0x03. Signed-off-by: Michal Orzel --- xen/arch/arm/arm64/vsysreg.c | 2 -- xen/arch/arm/vcpreg.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index a02ad951f9c1..a59848889659 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -95,8 +95,6 @@ void do_sysreg(struct cpu_user_regs *regs, * ARMv8 (DDI 0487A.d): D7.2.1 */ case HSR_SYSREG_ACTLR_EL1: - if ( regs_mode_is_user(regs) ) - return inject_undef_exception(regs); if ( hsr.sysreg.read ) set_user_reg(regs, regidx, v->arch.actlr); break; diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c index d6f9326b712c..749ce6d3a57c 100644 --- a/xen/arch/arm/vcpreg.c +++ b/xen/arch/arm/vcpreg.c @@ -219,8 +219,6 @@ void do_cp15_32(struct cpu_user_regs *regs, const union hsr hsr) * ARMv8 (DDI 0487A.d): G6.2.1 */ case HSR_CPREG32(ACTLR): - if ( regs_mode_is_user(regs) ) - return inject_undef_exception(regs); if ( cp32.read ) set_user_reg(regs, regidx, v->arch.actlr); break; -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 13:08:40 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 13:08:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388202.1629416 (Exim 4.92) (envelope-from ) id 1wtmDb-0003xu-T6; Tue, 11 Aug 2026 13:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388202.1629416; Tue, 11 Aug 2026 13:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmDb-0003xn-QV; Tue, 11 Aug 2026 13:08:35 +0000 Received: by outflank-mailman (input) for mailman id 1388202; Tue, 11 Aug 2026 13:08:35 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmDa-0003xg-Si for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:08:34 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtmDY-00BAgn-07 for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:08:32 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b1ec0-8faa-0a2a0a5109dd-0a2a45079a22-20 for ; Tue, 11 Aug 2026 15:08:30 +0200 Received: from [52.101.52.63] (helo=BL2PR02CU003.outbound.protection.outlook.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b1ecc-b4ea-0a2a45070019-3465343f60d9-3 for ; Tue, 11 Aug 2026 15:08:29 +0200 Received: from BY1P220CA0016.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::13) by BN7PPF8FCE094C0.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6d8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.21; Tue, 11 Aug 2026 13:08:24 +0000 Received: from BY1PEPF0001AE1A.namprd04.prod.outlook.com (2603:10b6:a03:5c3:cafe::2c) by BY1P220CA0016.outlook.office365.com (2603:10b6:a03:5c3::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.12 via Frontend Transport; Tue, 11 Aug 2026 13:08:22 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BY1PEPF0001AE1A.mail.protection.outlook.com (10.167.242.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 13:08:21 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 08:08:21 -0500 Received: from APPOL-18KY0J4.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 11 Aug 2026 08:08:20 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c5IuZPCMbt+iP+iOdd6Dvc1zLyHQ8WXZHqYdUxsrqaLgAh+1JVG1ElSTi+rBYNWcr7jQj2s4jOaBIqCVe8PDGb14UjXXy9Jo4MXoJCQR5YfrFFwVxGHqOUvL6spCSXg+8hMjbqA7JBeYhT2uZgohuKR/+EMM9834UjdaUsh6Pj3i6o/G40rWOHo5anB5PbbKY6Z2OGCM6RUNo1iHTkUu3IhSrmrxVcRnFk1L8vUpKzhigRxy5dGKihB/9/ILAi3OcHYs59dhglONzKhz/946Hcil8CnCSozv8Z9WllFZvK52/snzXF1Xb1z27V8MChWEhFcq1RuiJVsAZVYVSCc0kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XPXk2uXH4OcEznZV95T4XSLF5H38ut8UVpU/X0q01fY=; b=fD7X9M7hLkhHhTJ9UB076EOtYvR/bAR6xtgrLA9kpixwj7iJC9HstXPoSjZFiRDkAEOsfzF1vQQbRoZZynhoOdRF+qd/PIYnM5ZEbcDu4oM/jo8L4dU+mt+tyXvaY8wKQ8hB2vvTXf3mggTYLlmZt6S+jT0iTpbWIAoJjzOHhLHwkhs1gh1txa+MvfuGN19Im84Kb5A1ilouoMtStiUfhC1VjWLhUY/FqYVMkK29cDG6CmkZILeFpQ7jdVlCGKXUzGiV4YA0vnkDr3yE6sPXfyRU5fJHx5ooZwvy7mhFgq4SKfbHW9GACV59bGhQoLCuMlvnhAnQVwtijo/Le32AIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XPXk2uXH4OcEznZV95T4XSLF5H38ut8UVpU/X0q01fY=; b=IrKymI/Vl0b2Y7PXNwm1E3hsHyb/2hdIQeL/KXfy4B0hdwlwkQIoY1tGGYmAVbC4eoZk0l0ZZF+MTg0FLvfOkyjd54QEaHCn/TuUhpvaYC0ABKplOR4hJR27Y4lTHJz7W8+tBB3MKHkS8y75QNGlRTImkzo8fdh2Ji9GNctRWwE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/2] xen/arm: remove unreachable EL0 handling from register emulation Date: Tue, 11 Aug 2026 15:08:16 +0200 Message-ID: <20260811130818.123862-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE1A:EE_|BN7PPF8FCE094C0:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a1b67b9-1c5f-4880-e601-08def7a99ee9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|23010399003|1800799024|376014|56012099006|10067099003|11063799006|18002099003; X-Microsoft-Antispam-Message-Info: wP2d56Pkap7uAJ4aPDPZmu6dNk/u4ChH6mUeyojQBhIyrlvSo1GVjwl30xKQyyWjCwHOYeviOxUMOpBATo6AEixQMcLKmVqzOX+89wW4RkQDMPlIh3BI7Kf2fWgU6xeqLhoRDZ1BDLMo2QDrQrIuu8cqYsCrfHlbHhPy28NWnE5x74VP4OF3wZa7rd0/jVzQkzwM1SgJJrqPYQ7Sy8nVfrR2m+9yskQYlAgpj+KCe23mh/9CHRLGkBVGIw6lGBxRCUifGRmboYfgP/aoMDYWLBhQVGfi67auwlSrLvI8GUheSxrh+UguDRXUKIq9ewmSh7DW0v93h3CZSrYM40frcmRMg/zkBloc7Q2kRgoBFg9RQq/sBeEGRgG1Ev1mrJ3tlYvr/pD0LAsrsQuwtLJT3vL+CiS8ye3W908FqKa9ZK51DmN7VGMtL+d1wN/WPCV3wH9udqxZEYPoOFP90OwnRkut0TjRRnEsLHfh347i6qD3Nc6QWtxDZbdzS5OC2SMRI7IM8IuNQE2+CPJ9HkDhYlZqUUNY0k1iOL5ZGeF8wR56/g+LIQaOgTgnChzWRqLUa+7quIKYiNto1R3LrkbCDXPnidB+Lz33WCUrVy8xehz+U0lhpJ5XSQxAoUAifrpcgamj/HY1kBJMTdUf+kZBxl9OAcTxUmXzh7yOsIeiz3653mI8pS6DZeuJjGI37FGkwMQqxqPDOtDJhtfn/YaHpQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(23010399003)(1800799024)(376014)(56012099006)(10067099003)(11063799006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UpwgALeu9W5u0SdQfu0F4g0KyNDonNlBdGHahwqTsrqAvH8DAoigU0u+nXt6X6/WbBuSm/VUzCEtL9ezvCFv8iNRN/Y4/Zrz95KMJ7GWQGwININSrGvSRjEvhYYtHWJ6K+cD21heUBmPG4P8C1c3AoWa205CNRO9z1H5HjrW40urTYKsTSW28QE7jLs9cP6Itf1x9xhGJrs64vcHnS+FBaYQTC6UjlixNt8N1JVDyPC+J3ju9a5+qxRL7O1PZpc9Qi1ZZcX5tAUVxXXNsL44Fq74RzzDrZMEj8KXLbyVk9MYEmdLbcS/cZFqCjAxWaQEjQRLHnnus0IMJn1MSNTTL7Dyduj66e1RC81IZrVal4nrkbmDmfAFKvlIOaaNGbytnAzt2cLhNl2x8NLcoLjfi1PxdvSoDAbaXG7w/zfSvGD4gVdWtXJbp4F9x35nU+ZT X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:08:21.9155 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a1b67b9-1c5f-4880-e601-08def7a99ee9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE1A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PPF8FCE094C0 X-purgate-ID: tlsNG-ef75cf/1786453709-36CDFAE4-25BD2EF8/0/0 X-purgate-type: clean X-purgate-size: 344 Noticed while reviewing recent vsysreg patches. Michal Orzel (2): xen/arm: drop unreachable EL0 check when emulating ACTLR xen/arm: drop incorrect EL0 accessibility comments for PMINTEN{SET,CLR} xen/arch/arm/arm64/vsysreg.c | 6 ------ xen/arch/arm/vcpreg.c | 3 --- 2 files changed, 9 deletions(-) -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 13:08:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 13:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388204.1629434 (Exim 4.92) (envelope-from ) id 1wtmDj-0004S5-EK; Tue, 11 Aug 2026 13:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388204.1629434; Tue, 11 Aug 2026 13:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmDj-0004Rx-Ae; Tue, 11 Aug 2026 13:08:43 +0000 Received: by outflank-mailman (input) for mailman id 1388204; Tue, 11 Aug 2026 13:08:41 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmDh-0004PX-De for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:08:41 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtmDg-009MW2-Li for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:08:40 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b1eb3-e002-0a2a0a5209dd-0a2a45038ce0-38 for ; Tue, 11 Aug 2026 15:08:40 +0200 Received: from [52.101.43.24] (helo=SJ2PR03CU001.outbound.protection.outlook.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b1ed6-fae8-0a2a45030019-34652b1869b7-3 for ; Tue, 11 Aug 2026 15:08:39 +0200 Received: from MW4PR04CA0205.namprd04.prod.outlook.com (2603:10b6:303:86::30) by DS0PR12MB8072.namprd12.prod.outlook.com (2603:10b6:8:dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 13:08:27 +0000 Received: from BY1PEPF0001AE19.namprd04.prod.outlook.com (2603:10b6:303:86:cafe::3b) by MW4PR04CA0205.outlook.office365.com (2603:10b6:303:86::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.12 via Frontend Transport; Tue, 11 Aug 2026 13:08:25 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by BY1PEPF0001AE19.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 13:08:25 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 08:08:25 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 08:08:24 -0500 Received: from APPOL-18KY0J4.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 11 Aug 2026 08:08:23 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yy3IHdIRV6uSAY3yuBKGyRBwcGgOKMsVMJ1OUAgK7+YZ2virNNgMhkkEtbHLqxscGcOXxI/fZGrAAJuMXCUeIynXFLKK8idJQfsVKTTRkFnQwlCKSijTcqJGMH3CsFAsTF1PGVqpG1wiOngAiLIFRPNW/GWZN/EgfcqBr6BMi1aOf3pX18IK3cXV0ERNFkDwcAkHVrZrq33zH+Z7wmdOhiXc9lmWwjx2uji9GsNyf2qeULEjTr0JJQ/b9L0DcX9mif6c5ShdL8pG8ihazUmZNVAY88DuGJXU5VhaHpy/Xe4p1vRzZBU3cV75IwyL/Z3F4wJMF1GwqIsOKCZsVx4u3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t2SKxcmYWgXuUTR76GzBaCM/d/NBn5uY75sGmQkZr1g=; b=aZKp+Pgbg00aLn7VpRdehZuG2kU3AKAOJzAQTyo85U/nL5Yph5Ey6jdppCq4tsFeSiC5V89qGLtD8Yn3Y7UUeVnzudP+EAJYN1Enjb7OTCnO+nUtzkkzB/it4PnVvj6TDwYKWT44MV8JiqL+pFvN/mlqvVDbVtoQ74Xkl+rqr+QiuqcAEGN1U+N2F6FjCZS5OSy6SSwKtUXEIfbU5/ms8tdQmCmNB40cJj9O6DG34YafRp8Ez72eqdmhk83w3ZOtUyKOCxa4vfgFy1oMcKaU7jmF0SpR5+ij4JmeE0BO2umt7r0599wAx/fMi4yhIncUeQYwkh7htIKyGDIyOqQJgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t2SKxcmYWgXuUTR76GzBaCM/d/NBn5uY75sGmQkZr1g=; b=rK7XlvLHHmsCUEH4w0qsK8D2kBceaJvCdZ9DgHpVVsM/jpGn1RaTaIVpbD372POpTr8FYJ8sgcX89YDE5p1f2bQuPCgBnY2ntelctSD8onazd4feuUMCE7FcnTKF7CfSAsS5Lhdwf0iL7sUPmJOgZzer0jX9YucE3ivG04TpFf8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] xen/arm: drop incorrect EL0 accessibility comments for PMINTEN{SET,CLR} Date: Tue, 11 Aug 2026 15:08:18 +0200 Message-ID: <20260811130818.123862-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811130818.123862-1-michal.orzel@amd.com> References: <20260811130818.123862-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE19:EE_|DS0PR12MB8072:EE_ X-MS-Office365-Filtering-Correlation-Id: 58746e1b-f68b-4e02-711c-08def7a9a0e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|82310400026|36860700016|22082099003|18002099003|56012099006|10067099003|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: J2XZbPqGvmm0NBQVhW8WSto4Ng7tUUm0bKcNd8AX8RpfoiBzQa68Fgkr1XQhduV8Sq9tClJiDSl3uiatDT1vF4PhHwWWFNYlb4losAJWYe85SCUHqoPr7vvHFrNNKdIJwfHHbjranvuN5goV4j6axBhDBtropEhKUc4ofQbeyd3UxeFS0ORiQrwgUaqEujiB7FYPM/ynD1PNtsxklAGKTtVo95FpXSMIjcu8YSAYV0V/L1xyMnpy1GR+zYCUfd63p/2DXzuG1rMU0r2iSJX2nMJM8xKk159ntPACr667gHZQGzLKyGyIAg6CAimeoAiLCrDzJA0vwL79/OhBBnHAo/V0MpKzK0vmfKtT4dyu7rv4VohFgXiERGL5VZfhdlURrN0Ljfi+1h78bs+9MnmipStsuTeEa67Se4lUTlBR4QCuVGQA7RukKaAIvpOcjcpb7N6ZA9bmz0oy5ckWSiY13CAE44FXZ30K4gayn8zFGLz9B6EpQPQVXAijk0Tp1DE/RbVVMCZIXEGNDrH8TL6f05bwwh7PXL6+Qc/TXfkHz8LPNIO5aKeK8y5WqA17TX81jHO8movwdRKPz7eEkAd8UIvwkBkzw5mKsx5qeZCtYRbI/WlRWf/MBkfOWuCEL8eBH871kE2pwNPeNaSx5JmcOwSj/YLL9sJ4h3pLcdXbIaXpTOogXCEyzUkUis727SReoKblNX9KyUVVzkkEwvOrtQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(82310400026)(36860700016)(22082099003)(18002099003)(56012099006)(10067099003)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Hg783r01a0go50NxmbIleMxqijc28z0+ZRMoIuBQI8uIrcIHBo2bm4xxHVgYledrfL5Ffx55R5Nqm0M+b9mQSH8wJ9dru3K19Wd7Gu9Y9zzsyeHR97afWbahDfrAl+QkQfkMK0G+eMG1BSgOzX9b75ox1+bOUmjssKNUHhrvwQgYVWlx4K33/Z7jz7Gvkw4czX7ngVEdu4KH0B1liD+iumSXP1P5ZFEJBVJw2DOukIP4FyJcumSBQwQjFA7ARP1KJGwAD5R44e6R5Neg6IahB/aehdtJbh+R+XG4W0l/BFBSrYaCwEQEm/8EE6j5mpK/wz1GOgHI7TbAx4uBvd6Xuy/kwsqC6UKNqAaXDLb3/0en3cC31l/POUzUN3Vrb+7cRWNe3vkooSvqXCPJPPAZy+IH0AwJZSPVF+NvRJ/lO6VQNkSYDtSMfkj3NNGYDeki X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:08:25.2958 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58746e1b-f68b-4e02-711c-08def7a9a0e4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE19.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8072 X-purgate-ID: tlsNG-33051d/1786453720-6D4D74E9-0487D19E/0/0 X-purgate-type: clean X-purgate-size: 2068 The comments on the PMINTENSET/PMINTENCLR cases claim that an EL0 access may be trapped to EL2 when MDCR_EL2.TPM is set, and that such a case is handled. Both are inaccurate. PMINTENSET_EL1/PMINTENCLR_EL1 are accessible at EL1 and above only, with no enable making them accessible at EL0. Arm ARM (DDI 0487M.b) D1.4.5.6 "Prioritization of Synchronous exceptions" orders the two exceptions. An access that is never accessible at the current Exception level regardless of any enables or traps is priority 18, whereas an exception taken to EL2 as the result of a configuration control in MDCR_EL2 is priority 24. An EL0 access is therefore UNDEFINED and taken to EL1. Signed-off-by: Michal Orzel --- xen/arch/arm/arm64/vsysreg.c | 4 ---- xen/arch/arm/vcpreg.c | 1 - 2 files changed, 5 deletions(-) diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index a59848889659..2ada791f4ea7 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -228,10 +228,6 @@ void do_sysreg(struct cpu_user_regs *regs, */ case HSR_SYSREG_PMINTENSET_EL1: case HSR_SYSREG_PMINTENCLR_EL1: - /* - * Accessible from EL1 only, but if EL0 trap happens handle as - * undef. - */ return handle_raz_wi(regs, regidx, hsr.sysreg.read, hsr, 1); case HSR_SYSREG_PMUSERENR_EL0: /* RO at EL0. RAZ/WI at EL1 */ diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c index 749ce6d3a57c..b0f3c7759a04 100644 --- a/xen/arch/arm/vcpreg.c +++ b/xen/arch/arm/vcpreg.c @@ -295,7 +295,6 @@ void do_cp15_32(struct cpu_user_regs *regs, const union hsr hsr) return handle_raz_wi(regs, regidx, cp32.read, hsr, 1); case HSR_CPREG32(PMINTENSET): case HSR_CPREG32(PMINTENCLR): - /* EL1 only, however MDCR_EL2.TPM==1 means EL0 may trap here also. */ return handle_raz_wi(regs, regidx, cp32.read, hsr, 1); case HSR_CPREG32(PMCR): case HSR_CPREG32(PMCNTENSET): -- 2.43.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 11 13:38:56 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 13:38:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388233.1629443 (Exim 4.92) (envelope-from ) id 1wtmgh-0001OM-Jz; Tue, 11 Aug 2026 13:38:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388233.1629443; Tue, 11 Aug 2026 13:38:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmgh-0001OF-Gu; Tue, 11 Aug 2026 13:38:39 +0000 Received: by outflank-mailman (input) for mailman id 1388233; Tue, 11 Aug 2026 13:38:38 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmgg-0001O8-MH for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:38:38 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtmgg-000GUU-2t for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:38:38 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b25bf-e002-0a2a0a5209dd-0a2a450aa71a-34 for ; Tue, 11 Aug 2026 15:38:37 +0200 Received: from [40.93.194.20] (helo=SN4PR0501CU005.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b25d7-f2d2-0a2a450a0019-285dc214c408-3 for ; Tue, 11 Aug 2026 15:38:33 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by DM4PR03MB6858.namprd03.prod.outlook.com (2603:10b6:8:41::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.11; Tue, 11 Aug 2026 13:38:27 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.024; Tue, 11 Aug 2026 13:38:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e0CLk4J2stuWAhXOBoCfQwI/rrEwlLRX/PqHpH1CpXWVoaBs9JODVb4qKOR3ZRa2TR9RAepIWoT3vKcxhRWHvkAqXCLfmZj0QTBN9CcR/Ay+5gTtBdfKGFbYAXGEJLP433QhTQvz+igVnHOnRLCOynt20YkjQ0TuKCeMBwI2q1QeIM1h7ebgmS2iCXMd8i0afs8sB04IW+hH3d1KGmCMw/cYkunDJdExm9NsXSK0InaJuwEbge3f1QgjDVKBbYFEOxarRY28KaON8r+K/sz/bPkfANQw4iurwUITlxP74yLRzHYeaGwPYvyxDRYjWgDLA1UxmHlQdt2eAb9shm3m0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7QTRLCpkWoX+hi2L0lT2Qf+AYscjDWFwY6R/CRrBUIw=; b=Ey1xeMfWbv/jodqZhb9/BYWqE5w8laQPVFxbCTde6D0kjEesNn9zKKPTaCfZpfsofKKddO0BTYP9wHtO7SdszPkOVgwBaE7twaYOQykmp9GZmZKGi8ume9rRtyxDnrpsHPwa8slUIl3YhONnrj3tHRD3SOxjyE1e2cpvg+vEqshSY9jxLnUfeyAi558ERYgTNLwQhdrybHtYM97JfmCYSJRGPsOHKi03cqhUzPp9aBL4DkOVsHGdZZYNZm/U/1O+c0u/BU2M8xikbOTgI5KQjddF10iPrqUyhrXkaOZ9wZSbGTaR7YqobTQZxtjc4GgxIA+XoPhLDTRLLXJ7V8IIuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7QTRLCpkWoX+hi2L0lT2Qf+AYscjDWFwY6R/CRrBUIw=; b=rfiouETIAU7hlB7dsqM2EWo5eTM5xxCw0byw/st6RJ2Mvmc2j4ZMWToKMUqAcG/FfxPlQFUeAhVb6h/KUuoyxEmAIJ1v0usKNtkmcqe4q/R4Krd8MPbnNqmE+0u7/p3R4Y3XIS2zB2N5gc814A56s3hAA7ASWvwhyUJJi1eXTIU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5c920195-efc6-460d-b2b2-743911d7916d@citrix.com> Date: Tue, 11 Aug 2026 14:38:18 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Juergen Gross , Andrii Sultanov , Guillaume Thouvenin , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Oleksii Moisieiev , Timothy Pearson , Alistair Francis , Connor Davis , Oleksii Kurochko , Teddy Astie Subject: Re: [PATCH v3 2/6] ARM/sysctl: Expose the supported guest GIC modes in physinfo To: Julian Vetter , xen-devel@lists.xenproject.org References: <1784210820.8631fc262581453bbf619ec5b2062170.19f6b408bba000edb5@vates.tech> <20260716141138.88265-1-julian.vetter@vates.tech> <1784211104.8631fc262581453bbf619ec5b2062170.19f6b44e427000edb5@vates.tech> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <1784211104.8631fc262581453bbf619ec5b2062170.19f6b44e427000edb5@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0211.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::18) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|DM4PR03MB6858:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ab3a881-a964-4995-43b7-08def7add15c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|1800799024|366016|6133799003|56012099006|5023799004|4143699003|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: bzLXZtb0FC81lOASNTN3VYXmyM1hYbJwns37ooog+sCugtnl6+bGAQFnclBIw0B4zorVUB9nS1Sim0bhNr8N4qg/Rffygfd0uV5OM5FSKuogOtx0j61AVEsrn2CNTms8TwRq/bNIkuhebjkQW9fINmQevYXHUp4Mf51mnSTP+boCK17CYZssEOWFwGm9l2uO1iHwk6wrT0kZiZI+hDnfLA07UJ1uyKYNktQ3zQD1McIhtWE+xq/vGqpY09zncIKnmIk2kjmkYg4yF+laqbRUZzH77BizeR46AHn60rTQP3RtJE7dsdPizxS06aSYyvpCtdd3cfb0SkbsxkV4zjxfH/YWPoLVxMRCsxTyE5Gn2vacdjftYPC+GnL62rwqadh8WuGi5jMgwObJhu694jTTWA1gQu2xjZZckIUUTqki6KJRsy2EQkeaqXUHl8WFKBCBfxAQ3+XWYlxXZE0pcoFdc5XrMtgF0YPhi8n6f9OX7T3d7wYNU8lDyMm2oWeihLPs5BpjC0Yntnq/bCxBchrMJznj0mJhnQk84tEHrhiR35nSNPkT9FDumkwvOQUSA1+5O/MrDpRzNO16kvow4luetam5HKvLGUKAWiSVMRpdO0kywc6IHJpx72hAzL7aSQf8QQySWZYq0X5xVRxLca1Gt8QUIDlrKbVIhm7kj5UkfRQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(1800799024)(366016)(6133799003)(56012099006)(5023799004)(4143699003)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3EwYmJWQmdxenlMSFVzYjF6N3ZUVjl6U0t0UGtBRGJ4N0FDNnlIS3ZBa243?= =?utf-8?B?M3l5SVFhdUdabGh0QW96eU1jTWNRaGxTdlJMRzlMOFAyWHo2RUFST3BPOWlv?= =?utf-8?B?djIraEdXRTNxYW9XWnpmMEdsYzl5ZEtPcHI0eTBFazRpbzg4Sk1ZQTg2dlhT?= =?utf-8?B?cTFBYW9ocmNiTVk0enZObTBtYytLYTFKWGpoZE5rUmdqWkp2THorVlRmNHNE?= =?utf-8?B?RkZ4OHYyUXA3a0MvZkFSQkwyMVJLcjgzcHRpbzdzQ3laNkNVWHFmUlpoRFVC?= =?utf-8?B?dHVzWmdocERzTGZOZEFTaE0yNkNXanFUbzd0TUhneUZrZXMyaFBxdUdtYysw?= =?utf-8?B?blllM3JDbHg2M1VPVzNrNHBQZDMxUnduYWpQSzkweW9wOXRhYlo2SytoTUl0?= =?utf-8?B?dkNiemdOMGFhMm9LbnVDS2phV0FPTEpCTVZ2ajB3U1ZNc2RBa0FoTG5VM1E5?= =?utf-8?B?cGFaQzQrcjRPRzdKUzZaUXNIdDF2VXQvdE9wY05BQzF5UDhzQ1Q3emNtTnhI?= =?utf-8?B?YisrLzEwNVNxZmtVb2w1U1pIOFJ0aWdkakZOb1R2V2s3TlRiYllGNk1xTkJ2?= =?utf-8?B?dE1SMnNqblFzbGlreGx5RlQ1R1ZQRktjeTZKejgrMHBTelpwa05FaExHUUZj?= =?utf-8?B?V3d0bU1EcWsxQUZsSEtUNFRDS3BsdlVRVUZVKzdaOEZocXhHU0E4QWdaNEhR?= =?utf-8?B?RG1ubGQxT1huRVVqc1J4N2RWWjRKZ3NQNkJGeGFJbmJJMGhLTXl4cGZqRnpF?= =?utf-8?B?WGl6TlltNkNUbm9OQlRsajVha3lHclRyL09YWUFjWEJMS21tWitRdXdMUjFU?= =?utf-8?B?U0U3OEl2Z3dZbHYxNXlpNk1TdHlzWXA1RXNRT1NIRVNVTU1DVGpzN1U4Tm9B?= =?utf-8?B?R3pyNWJPRDJacm5OdHJZeGdvUUNNbk9mcmtzVWFOSkt6dTgzakZkbEVLZFhT?= =?utf-8?B?UzNHZkVNTU1qNUlOYVJaWm1jeDdLcGdSKzJTM3dTbHA1TnpOWmxwSFk2d1Ns?= =?utf-8?B?bGUxdE91T1JBb2dhWUJ3NGFPYzlYTUNYbDNWYjlpUVM5T0dBcG5TYUl0SlBq?= =?utf-8?B?UUg0OFdwek1oME56QmJQSGpsbnJCTm9uWmdKcm5YOFZpUXpuZXhLSkNrYkpP?= =?utf-8?B?OUx2YWk2ZzhKVjJIVHZuT25mWFdTTUJmYnFJQjBCQkZrRmxtZjMzQlJMZnNp?= =?utf-8?B?VWt6SnRubDhoUzZJRVhuMERRdmFZQWJ3RkZWaEZrS3NFVHJVaGVkbjdEckFV?= =?utf-8?B?WDBNaDIrTHA1c1hPcUJQWEpoMWJnSitIYm5VZXA3eWdjaHBqbzBqbnlSd0Iy?= =?utf-8?B?WkVuSHZXV25XTEZBYWZYZGVjUGdOeDBBYTAxcnRLVmh0ZG9sRGNaenZMbk53?= =?utf-8?B?KzFCRllsZ3VkNklxUTlDMWpsQU5XQ1BxdXpOUE5mdWQ0VDFSS2grSk9ISld4?= =?utf-8?B?Q29EQlYxQTUvVWVuVUNBWG5wUFJQSEF1bTdjV1VEVUEveTlhMHkzOWJGaEkr?= =?utf-8?B?bmVESzhPQkJBM3phMlZreUxiQ3NtVnpXZUlnVGFyMmJXWldyU1gxdjhnNzQr?= =?utf-8?B?U2lKSnNMS0NUblRJZmFLd1p2SmhSVCtCeVY3TU0zeGhXdkFTR21yWUVwVlFa?= =?utf-8?B?OTNvUWFLUVpydmZFdEtLRmljdUNEUDRBdkw4ckhrVnlMTHo0U0srZzZ2T1Nm?= =?utf-8?B?VlFhSnNZNTFFUHRVS2picjBYR2lQR1ZsclU5R254NVppalJ4VVVaUHhPa3lz?= =?utf-8?B?cjc3anVYdXR5ZGxwKys5RjhvMXZ4aDErRUxEQjRrbUdXZGR0WkZXZnA4SzVn?= =?utf-8?B?QlBvWGRoNTlrYW83NElvU3Z6ZUFLNnJ5eENnWE92N083UkxhQmVNQnIrdjk5?= =?utf-8?B?aXptbEhQdEdLeXhJNVFJMU05Z1ppVU4zRmN6Ti94VEZCc2VCVW1sb283Z1Zq?= =?utf-8?B?eUZFOGFPVWh3U1VuOGE4V0phc1hpVDZYT1ByQ1dtSFFqdGtwU2tKMHlrckZ0?= =?utf-8?B?WUxOWDdBR2plbDBENWZjT3k5UzZkdWVyZDU0UXZ4bDBubXRaTGM0NW5IUUhx?= =?utf-8?B?UGd5dlNpOHd1SHZTV2o0bTlmZHl0RzdKS1dWWGMvTVRSNldTMXhIUkxxWVY5?= =?utf-8?B?R1pQeUU3RmRiMUJnWU5SbHZHNTdKK2FuN0hHckxoYU8zTk9DWXhCdktTbTdR?= =?utf-8?B?bWY4OXBNWUtBM0FkNC8zRy9hNnVLK0lRTXowQklBYlBDa284aWpneHlpUGdW?= =?utf-8?B?bmFnZzM3WFhXaXA0elhGdWxZMDNNQnV2NkNxMkl4bXQ1UnRsdnNZY015MVRt?= =?utf-8?B?c0JjZlNmSStaWDFVMk1hL3dsOStVU01RQ0FXRmJrQUhRK25LWW5Hdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ab3a881-a964-4995-43b7-08def7add15c X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:38:26.2007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wOMQ7JLq+cB9ctRnJVpPMCzdXp2tYSHn3ly+DfNY2iTUDQB51AWqwJ8bjU3FjFiD/OZoWf0w3j1uWMuQT5Y2ekc0k3tGo6HFBsBu59Mzpg0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6858 X-purgate-ID: tlsNG-4011c0/1786455513-5A9D9CFC-375AD3C8/0/0 X-purgate-type: clean X-purgate-size: 2109 On 16/07/2026 3:11 pm, Julian Vetter wrote: > From: Andrew Cooper I supposed I should finish the commit message. "In preparation to simplify the domain creation logic surrounding GIC version." > Signed-off-by: Andrew Cooper > --- > Changes in v3: > - No changes > --- > xen/arch/arm/sysctl.c | 26 ++++++++++++++++++++++++++ > xen/include/public/sysctl.h | 2 ++ > 2 files changed, 28 insertions(+) > > diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c > index 32cab4feff..3b0edf4cec 100644 > --- a/xen/arch/arm/sysctl.c > +++ b/xen/arch/arm/sysctl.c > @@ -12,7 +12,10 @@ > #include > #include > #include > + > #include > +#include > + > #include > > void arch_do_physinfo(struct xen_sysctl_physinfo *pi) > @@ -21,6 +24,29 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) > > pi->arch_capabilities |= MASK_INSR(sve_encode_vl(get_sys_vl_len()), > XEN_SYSCTL_PHYSCAP_ARM_SVE_MASK); > + > + /* > + * The GIC version(s) we're happy creating guests with. Right now for > + * simplicity it is tied to the active hardware version, but this will > + * cease to be the case if/when the compatbility modes are enabled. > + */ > + switch ( gic_hw_version() ) > + { > + case GIC_V2: > + pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_ARM_GIC_V2; > + break; > + > + case GIC_V3: > + pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_ARM_GIC_V3; > + break; > + > + case GIC_INVALID: > + /* > + * Running a control domain without having the GIC sorted yet? > + * Something's broken, but there's nothing we can do about it here. > + */ printk_once(XENLOG_ERR "Unrecognised GIC version %d\n", gic_ver); We might not be able to do anything useful for the caller, but we can at least make sure the problem doesn't go unnoticed. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 11 13:43:23 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 13:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388242.1629453 (Exim 4.92) (envelope-from ) id 1wtmlG-0002xU-85; Tue, 11 Aug 2026 13:43:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388242.1629453; Tue, 11 Aug 2026 13:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmlG-0002xN-3N; Tue, 11 Aug 2026 13:43:22 +0000 Received: by outflank-mailman (input) for mailman id 1388242; Tue, 11 Aug 2026 13:43:20 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmlE-0002xH-LW for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:43:20 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtmlD-00EaN9-UL for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:43:19 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b26ef-e002-0a2a0a5209dd-0a2a450ae408-36 for ; Tue, 11 Aug 2026 15:43:19 +0200 Received: from [52.101.43.18] (helo=SJ2PR03CU001.outbound.protection.outlook.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b26f6-f2d2-0a2a450a0019-34652b12a380-3 for ; Tue, 11 Aug 2026 15:43:19 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by CO1PR03MB7817.namprd03.prod.outlook.com (2603:10b6:303:26f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 13:43:08 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.024; Tue, 11 Aug 2026 13:43:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gFnLaDSzHdiBahBBUdGKIrSPyvQRPy2K79WUDL72kH3vOHQ524xbgwxZH+BfaQB5FpjvGLOgTIGRkxX0yPQTu+REqkCIzP/lXw+11xZe9mbJn1rBunExM61BdEy2L6cjuisuCO3Dzj8EhbAd3Za9HEFjuoFWaus73wTg1Nr1GiD9L3Qz6Aeisgca2Z8k/RwHPpdvN/pKJiAjwBjVSWIPpDcG0Gm21G/AQEjwjYfb0D62a3KjegtM0Xvo3XHjmgYK5bZQ++iE2P59PqugPbuF1if1+zcb6hXeYzzfD/pjYaM7rJYwkHtv926cVUKc50kV8qLeTxfXHSHmElGEX7ddQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6HJleX/8qOcArZJBfZRiD8XBv61MP4y4fmJda5DMlk=; b=yBNaTPTeZ+peQdGu+OrvSYXCwB7CaJXdnHBQuIS8pP0i4BFD/yrEnKyfBotLueRhKiQWAEWi8T3ptITSS5s1Q5vxCJbC8H6scuJfatClkV7MakeV1Vg+ZoOAZZb+GPgTd/QcOH9cviWjxSm6nX2kE7r223YtL6zYcMgBzgLeC+6NdKF+r+UmiWvc3tcy//W/fY3KmVVBSelNzQ3KGdeFXvEYEWRCWmQVRKYv6zEpFD64ORPJq/cEIzAbAovY2bkMYcjZk7yFt4uUP4L90xh6mx+UwY+zHjMp4TG6r51ljtdDzJ1iBzD1Z1v1xHLNMQJff3W+ueQRmH+Qj0GDp8nEqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6HJleX/8qOcArZJBfZRiD8XBv61MP4y4fmJda5DMlk=; b=W33IEWJkhvqHmxJBhJ+aD0YZQb3IR2pDEMZCtVgHwFK0A9KpGe5c+czlaN4h43PjXMkX9S4gaZ8/8F0Fydhp7sXeqtAh+OWgly1ic30PDHTvvpbX0t3KfvF84eyzlbYrOy8Lg2ABoOxG85cKhd5XtpnxrZxFhHhbgo3Z1m/TSIU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 11 Aug 2026 14:43:03 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Juergen Gross , Andrii Sultanov , Guillaume Thouvenin , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Oleksii Moisieiev , Timothy Pearson , Alistair Francis , Connor Davis , Oleksii Kurochko , Teddy Astie Subject: Re: [PATCH v3 3/6] tools/arm: choose GIC version explicitly instead of relying on GIC_NATIVE To: Julian Vetter , xen-devel@lists.xenproject.org References: <1784210820.8631fc262581453bbf619ec5b2062170.19f6b408bba000edb5@vates.tech> <20260716141138.88265-1-julian.vetter@vates.tech> <1784211105.8631fc262581453bbf619ec5b2062170.19f6b44e5b6000edb5@vates.tech> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <1784211105.8631fc262581453bbf619ec5b2062170.19f6b44e5b6000edb5@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0676.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::14) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|CO1PR03MB7817:EE_ X-MS-Office365-Filtering-Correlation-Id: f0db2984-4836-46a8-1904-08def7ae7a0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|23010399003|6133799003|4143699003|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ozy4epcRdDZeMaXOPmbsfIv5/Y0y5kO81xhkjVDpFjQy+EwE45JE4QrWk6pnkALqmTGvmDtEXgu2KBsfWlC90AEFCyOiBydLMjcIbmUBaYM5a+8sH/AGAtGfyYX0EUfsbY4rv+3MjatBhB2al3NUd0GQTBhOTeAn8BtnGcZYsdQTHyKZ1MKSwIDebOehRyIJCi9gGaBuxa6eILueslfdDdlwlQdgb92D+V02CvYos2cNjmSVjFkmm7nU2erosrUNwcIPVfrgFbIP8nhunsw12/P++UGcFhH/H6yDwYz2rkUds7yFLhxQZSKOj2fQWyBOrlrAc2tMmjewZUrUtCsuC0E006brgbFKPGNUFl8PBYBB4CFtORUb3YimaK+ewdNWl70eQw2HMfFZ+20OrvhkPPqBzuRN+X89I+3+K3FBJuCQCXUgt6pa2qTTA2cfLagK5LBk4VwC9TfuZ5xEcQn2QomAh0VUJkPKHR8taiUfmlKSk9YxVsAbWv8NfBno0nnDVBaTGq5rWR/Nceb6SiTEjFXCUbDjd5KRb/kdvuDfxICw2D50FW/IrEveuT+nhzM6UeSQKszHttVw2TmRpiwi6HCrtLyl8jYQ52f+HSaMuxsrO0gTRTWEWv/KIygyeaab7yBfsDhLtCaTbyMO85RZ86LwxpRWjrNV82wxmwtdbhE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(23010399003)(6133799003)(4143699003)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUVrdVBGY0FjMHFVUHRXQTJBUHRzVzdWenpiOTA4MHhXenkwSGwrbHZMRldL?= =?utf-8?B?YnNDR2h0MEx1cFpHK0NxT2NjMHFMSlNpOVVJaHFCSEtqelFpYUFSdDdrbzZH?= =?utf-8?B?NkI5by95ZStzdUN2cXZuVDNUTXBrSVF6Q25xc1owdmw3a0lPUEJ0TXJuem5s?= =?utf-8?B?RkZtamdzenF1dzFDVEFaa1ZqYkc2dzhhb1k2R2Q5Wmp2NjRwY2F0aUZJR1Nu?= =?utf-8?B?YWVISjVGVDMydklpWVpnK2dQdnlRbU40N1h3cVZyUVhkQjNXekFMT1pheW5Y?= =?utf-8?B?OTZsQWRYaTZkU0ZxdDVjRmowQWwyMlhpWXBjNVQwUGpUaU1PdXhvZkd4Mlho?= =?utf-8?B?NkZwT2ZLU3Y0QWtMeFNTSW0rTER0d3FoSGFRQjcydGZrOElHRlppb2lPakF0?= =?utf-8?B?VzJOQUxXVWNiK3ZDeU1vZm9DMm9hN3F4aW1SMGR1LzY4Q0ZzNzFEWVBSbG96?= =?utf-8?B?UHRGOXlJeVhkdzNCNVY4bURaN1pWSGhMS2piLzRQMFZvT0dVME1QbERXM3Er?= =?utf-8?B?aFZEQm5WSXFXTEc4SVNrL3QvaDg4YmFHSEpsWFUzdWk3VEowWnlTUWFwdWFt?= =?utf-8?B?Z3RURVpLQTVFQWdIb1FHZlZPcDAvVjUxRFRhM3hBWDR1R0RML01mZG4zSlNl?= =?utf-8?B?bFNlejZ3aHlXOFJvZFlURGVuSHJwUU14VU1IMC85ZnB5U01FWlZFcTNsd0dU?= =?utf-8?B?Y1pFNkErbzQwbEFjb0JlWml2OTcxY2hWNjZybEVqSjlyZDhjcExkeW5obEJl?= =?utf-8?B?ZmhJeWhzRmx4NDd4UWsvMUhWT1AyOEh0cGxJdC9LUG9aUEZNSFl1UGJUZnc0?= =?utf-8?B?bEJySjZzemNjZVljSlZBVUdXckNTaHlxRFplTk5hWGlnZml5ZGFZdE5BbVFx?= =?utf-8?B?ekZEYmczUVNncWg2UWpOUVc0ZFhtTzZFRVY2N21PMFZzME14OHZINlFuS0FW?= =?utf-8?B?WnhLaEVBQTNFaGgxNWtZWGxWdm5jY1pmc1VSRk1vS2M4UGlPMkdubG1KeXpL?= =?utf-8?B?RURRSkU3S0JDTnVidFVFOFlaWSt2QWlYcllQbzVRZTRQOU5hdGRBRnJXQVkw?= =?utf-8?B?YW1XU0k5NTBzM3N2blhrT1d6RElBVE5aTDQyRWRPbElIb0NoWUxBa3JHcHNB?= =?utf-8?B?R080RzFGMk5rNlJtZG51K1QwVm0xSzZIR3ZjMHpuUWMrU1U1QzBJTXlnby9l?= =?utf-8?B?VHRJUERVc2ZENkNCYUJNemRjeW84SFgwYXR2dXVBSHZXeUtUeDd3UjJtcldU?= =?utf-8?B?azdRMFArT0hCUGFBaWFlN0hEc2hiWEc3L3NzR3UwUUNlSkRjbjNVb0FmSEty?= =?utf-8?B?aTdsQTR2OXN3N2RwSW1pemFaNGxxN01zanJSOVh2c3k1UStwWlBEdUJpRzdI?= =?utf-8?B?VHZQMmFCRHZNSS9pRTRib0xmYm5YTUxRSEQydXZ3Q2dqNDBPSzFYbWJvRG9R?= =?utf-8?B?cDNHaEFzOXhFL0ExSFRZUUdnckhWSFBNa3ZWdWtOcFp0MXZNelhTSWpUTmNN?= =?utf-8?B?bHNsRVdMTFM2NE12RUxrWHZlQUJscXE4VzRCTU42SGRYTFhUa2FLR0d2K1Qz?= =?utf-8?B?UUNna3d3MnV4dER6QStlNThzem1lb0xRSVNscGZBaW84QXJ1RS83QndwVkZm?= =?utf-8?B?V3JBV255V0JGRXAvNUk2TmEzUzV5aUF0WGk4ajQ1ckpYWWExOHJqQmJkK3hG?= =?utf-8?B?dTNHazdnK0dLdGk1Rytpb1p1OWpLU3Jpa3laZ1hzRVAwMmlQZmFtWUVRbWs0?= =?utf-8?B?QTNsUUF1RlN2aGhrVHkyZDdURXhrMHFOVXliMFYvNFBQQk5LNXllRVQ2empX?= =?utf-8?B?SXRZZEM0aU1pWDg3MTJMYnF5VHBSMmxONW9VUjUxaXVOei9ZS3dGb0JkTHNq?= =?utf-8?B?RVpkcEVNZUdieHdUeVlwUlJYdEJVNmxwUGtlRGNXZkFvY01hT1VnZ3NYMkVH?= =?utf-8?B?WHhyVDJ1UWxJcTNSOWtLejFORUhnbGNGd1F2djkrMGh6dmxZeldPSE5ORS9v?= =?utf-8?B?VWVVbFZsYWdWd29OQmg1OStXSVE1c1hsbzlENElmVHJRNFJHVTlBc2R2dE02?= =?utf-8?B?bmp0Zm5TK0xFc1dua2FYbkJxaGpRVEs5enZRNVBDUmIwRC9sbnhicHdxWkp6?= =?utf-8?B?RG1ROWROVTJiVitaQ3lmSWhZaHFPN25FRVQxeHZNWExYWmtMTEVWUExlOWFM?= =?utf-8?B?RjRNUi9NRDJjazhGUUJWT3lxZW9DeEhQd0EzcXh2QmtqcFExcThWZm5iN0lI?= =?utf-8?B?MXpJVEJ5OVZzTUJQVkNSTXZCNGNiU0FyQlBGeW1zd080MXdhUU1mWDZ2Wnk3?= =?utf-8?B?OUhseThxS0FJRVZmeFNJb0czNWU5TitGQUM3enUvWXpYN0ZVWlNGZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0db2984-4836-46a8-1904-08def7ae7a0e X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:43:08.2244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ruMlxaLIYkwopAsebD2mE0z3w8wmR1YV9Zv59HnJFp2VfFy16IcWbZxLTfVoPCuyvXKai1PiRxZ3Usn/8Vl+4jIaHYEp4eejJ2uUY2F9RV4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB7817 X-purgate-ID: tlsNG-4011c0/1786455799-50CCBCFC-D643FEAD/0/0 X-purgate-type: clean X-purgate-size: 1100 On 16/07/2026 3:11 pm, Julian Vetter wrote: > diff --git a/tools/include/xen-tools/arm-arch-capabilities.h b/tools/include/xen-tools/arm-arch-capabilities.h > index 4aa4c6c34a..6397df696b 100644 > --- a/tools/include/xen-tools/arm-arch-capabilities.h > +++ b/tools/include/xen-tools/arm-arch-capabilities.h > @@ -25,4 +26,19 @@ unsigned int arch_capabilities_arm_sve(unsigned int arch_capabilities) > #endif > } > > +/* > + * Generic test for any single-bit XEN_SYSCTL_PHYSCAP_ARM_* capability, e.g. > + * arch_capabilities_arm_has(caps, XEN_SYSCTL_PHYSCAP_ARM_GIC_V2). Multi-bit > + * fields (like the SVE vector length above) still need their own decoder. > + */ > +static inline > +bool arch_capabilities_arm_has(unsigned int arch_capabilities, > + unsigned int mask) > +{ > +#if defined(__arm__) || defined(__aarch64__) > + return !!(arch_capabilities & mask); > +#else > + return false; > +#endif You're missing a } here, and I don't see it anywhere else in the series. > + > #endif /* ARM_ARCH_CAPABILITIES_H */ ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 11 13:54:46 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 13:54:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388250.1629461 (Exim 4.92) (envelope-from ) id 1wtmwB-0004vI-4X; Tue, 11 Aug 2026 13:54:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388250.1629461; Tue, 11 Aug 2026 13:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmwB-0004vB-1G; Tue, 11 Aug 2026 13:54:39 +0000 Received: by outflank-mailman (input) for mailman id 1388250; Tue, 11 Aug 2026 13:54:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtmw9-0004v3-G0 for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 13:54:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtmw8-000Ibh-Sa for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:54:36 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b2998-e002-0a2a0a5209dd-0a2a4502a93c-16 for ; Tue, 11 Aug 2026 15:54:36 +0200 Received: from [40.107.200.15] (helo=CH5PR02CU005.outbound.protection.outlook.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b299b-6ca4-0a2a45020019-286bc80fb257-3 for ; Tue, 11 Aug 2026 15:54:36 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by MW4PR03MB6946.namprd03.prod.outlook.com (2603:10b6:303:1bd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.11; Tue, 11 Aug 2026 13:54:31 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.024; Tue, 11 Aug 2026 13:54:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zQ11vnaen8GxyLGB5rPZxcD3nqBNiHt9eG/R62XSpqSDBSHFph3znZuzaYZX4X+9znkCrvDpy3JSZIJvCuWNaTHg1DudsHXM3KPTyTB1id3pVsAW6WSEjCQ4NF3LuNCN0gCMk5U/KIXw8dX0cg1KE7EmgVYcwyyrYySkgXepdrLw8equ2UwaosQhOE9AtfAnSjxypua2pn+okES7ok0cRwZSz+tt/0wq1jVQb9gTFRryZqHFON7X+EI6YlmckIjtJgctsqY/XoBPtzSkO1bvsDi0r6bG2JlPyV/1uyD7WN6a9lSX656/tK2nkWr6FxDt2uN1dKDC+4VXWUXLQ9fSkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k0JfVm/dOYCTKg2ATdxxuHJlejduKIiRsz2PKD+ycuE=; b=IY7AjNZU5e2IWZThrZjBrJcYwia9YDIlRCh9yQ4KMZZwaUMayQxcXgZ5mHaEmSVDE70+Un6WasDlQ/tbhblzUpHguVSfvYmGfwA7tN66L4SfCpLpfgDUgqueZXevLbSnt/ZN5R9ZDarq5afTJxmLhGHsN0xMOeQAtHOulj98p1htclaJ++OFzYADBglso7zjheHlURAiADOQQgrNA8ngU5nto/BDx9hG/1WGt7N5N7Gy/3Iii34LkimTxV6RvznpgpWBjG6an5r4/33DiO3xxudtoCNflJWw/JW2E2xm6mIeG8/AcdtZPa8siZ9KC7SNRHuHSJuvO9K1QRi+VZgSSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k0JfVm/dOYCTKg2ATdxxuHJlejduKIiRsz2PKD+ycuE=; b=0eFDOuddafMykt2IHQjsUH9d8jzmikzP3G0Rbso0wQZboRJsNgX8yD0icyT+dGkzY3pX7H6Pi66j3Xv2jQCk48nzacijdWB8WYSyPTkKzKv1dDhoVMt/sVFof+RnZwE/Xx6qBK4DiFGz/Ct3yRjBXkjv62TDFAHUQZiCUnVqI/w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <9a3d991c-9b14-4614-8010-e2e03aabcc14@citrix.com> Date: Tue, 11 Aug 2026 14:54:24 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Juergen Gross , Andrii Sultanov , Guillaume Thouvenin , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Oleksii Moisieiev , Timothy Pearson , Alistair Francis , Connor Davis , Oleksii Kurochko , Teddy Astie Subject: Re: [PATCH v3 4/6] xen/arm: remove XEN_DOMCTL_CONFIG_GIC_NATIVE from the ABI To: Julian Vetter , xen-devel@lists.xenproject.org References: <1784210820.8631fc262581453bbf619ec5b2062170.19f6b408bba000edb5@vates.tech> <20260716141138.88265-1-julian.vetter@vates.tech> <1784211105.8631fc262581453bbf619ec5b2062170.19f6b44e7b5000edb5@vates.tech> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <1784211105.8631fc262581453bbf619ec5b2062170.19f6b44e7b5000edb5@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0013.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::18) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|MW4PR03MB6946:EE_ X-MS-Office365-Filtering-Correlation-Id: 25593791-7bfb-4a2c-b879-08def7b0109a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|1800799024|366016|6133799003|56012099006|5023799004|4143699003|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 123vpdbtqxe7ykzKhCH71k6BzwCTihkyLYBpuvKXID0wNRtW+bEzsBmgY6clswoFtE+3Ow6Ll9Vz06AfX1jmyLESmBKwowK+XIt4do3CtKuRlBojCFOat/VFRdWGt1FA1XtUEZeHLshPVMeQxkbcCCvNWKX+tgX73UYtUGg4vjDlOORN4QEXKuYNpbqc2ObGgJGOPRwCkLvouZ7y1AdH7YrZCx7ke1o03+YSbg4QRwJsRcc+IBXsj+rekRw17da480J6pAZsj3gwVz++b//GFEGJRrkeHBvyNR1E2GR/+l3GV4U2YN/vRYzwfKERDFJ6mN9kqtI1QcNMSI6s+IOp3c3XoNY7h0fWeP+hofHEUOL55wt6iWcxOnl1FgYzy4mzvAerwn/xUTgjLdWraUgZ6/eUn0ZdzuafXKqXVsKE878J6zKxJbN+/j9swfxixNV471xTdVRTQ/UJSb5Mt3hvvaR9EqcNrtrg4lDKXPp/twnI5D81r0vf+keyW0wbmdPfNnjdilsEab2CF6+2noh0x6hNmqrDkcF7B0rG013P/IC6pKU5nIfPBqE+TkiK8OUnaTdpWvVpCMhKBD+bbCDJxqA7BD69e3mul+5U/drNWsM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(1800799024)(366016)(6133799003)(56012099006)(5023799004)(4143699003)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWlwSTErc2dYK0poU0RRUXFYSGlSdHJFWDdacjI1Q3pqdDFnMGMxOGNvRDRM?= =?utf-8?B?TklxVXVXTzlkdEZ4cTRRT0ovVFM3T0FKSERNMFVQZTlKMzZjemVUbDVXM2tx?= =?utf-8?B?WWFJMUJSYU5zUU5zbHFMdVNtcnE3eERmUWF5cUMyWDQveUM3aFpZZVU3Q0hw?= =?utf-8?B?NExhZmpNZzUxK214NWVjWDNIYXdFaEQ3RjZjeGRRWXpvNkt4NEtwVnZlb2xt?= =?utf-8?B?b3BCYXF2eURqTnA4d0NSSnMvc0pwKzZMZDRjakhFb3RLT2FtQzNGakhPcFU5?= =?utf-8?B?MkZ0NEJtVUg4VmlKdEJCNFZYSmpEaG1kaW55SDU2MnF3YkpQS0VadFFZeVgw?= =?utf-8?B?MWZxejFrR0k0MjA3UkZLeGpBSkladXdDalNvWVNnbmovN2ZPUFloUUlZazNV?= =?utf-8?B?Um5MVW9JUFpkK21pVTkyNnlkTGJmNlNWN1ZrTXRsdWY3U0NwcmVocFA5Qit5?= =?utf-8?B?RWZVTWJnZHlZUXhnbUkvYVJWTUU2Q3pEVTBhNVRIenYyQlRZMjdsZG5nR1lN?= =?utf-8?B?RnRiWWdCa1RHdnhqNHZzSUJZY2tDMVQxVXNKVzk0a1dsSWpWNFpGYzhkUnc4?= =?utf-8?B?aTZzTGdjQ1NnYXFPU0J5ZmxFcSthMWxuYWJnY2dnOUxYQUJVOHQrU05yQjNy?= =?utf-8?B?d1k0eU1XVVUxdkVtVXFEeSszdDlQVXFYWkpoL2ZVODFBY0tmMGRoN2RSL2Z1?= =?utf-8?B?RTBnb0h0cFZVQ3BjZ0FZNTRIbTlpRWNmeEpucGFkQmxYdkY3Q3VpemwrdGFI?= =?utf-8?B?SEY4cCtrVmwwVnJ2OVZ5QTRWb2VkUGphR1o1TWFQZ0Y4UlhyUlNZTGlDT2xD?= =?utf-8?B?dWlUVURFTEh4dXBrcjU4UGVVRERxRHQraUtwa0VqWlFnUEsvMEd4UDNrazVj?= =?utf-8?B?SzdPMlR6OEdoUmVEVU9IaGhmZThESUw1eHV1N1I5c2Q4WlB5eXM0bUp3cE9X?= =?utf-8?B?SitJc295cDhQWW8rN0VvTmRjdnRBTzU5M3NVZW5Pekp4NDFxVkoySDZVL0FT?= =?utf-8?B?NXpGQ1g5WVVKR2hPbHNWcm0zOTZPbDJmQm5sdjVqKzFtTHhMaUcxZm9Gd2Jw?= =?utf-8?B?cElnTlNOc2dOU09UTnd2TlB1dUhvbFdhdFNRTm1oUzJzTVlPendwTjhaY1FE?= =?utf-8?B?dWxlZUczd0o3dHBuWENHR0tYU2ZwOFIvY3hZaDdmcnBwaDRzaWtrTzJqUENF?= =?utf-8?B?TEVRc0N5S0NFellZRW95aitRRVpySS9KM0hvVjhoanp3ajIrZkZVZW82a05y?= =?utf-8?B?TldySVdWZnpaU28yck1ScHhkSlJtOXBKZXVuWDcyWVpzbUswMGt5dTRzRmMw?= =?utf-8?B?WXM1dGF1TjJ1L0VYNGxNbmRmSFYvaHhvRHJIU1dOU0RrczZNY2VHZ3JuSTdr?= =?utf-8?B?VUJJOVBxVTEvWU5yVndwOGgyeDNvakZCMy96THdTbmhEVXFoaE9oUm9pMlpv?= =?utf-8?B?THBKMnppcU1UVlMwYUhkK2NSTWZ4dE92ZmVRRXZWUklGclJwSlMzS2JqNjRz?= =?utf-8?B?R2poTmhTQVVOejM4SmFkcDd1cVFSZGZZUVVyV0tzMnRLVXo3QlJyUkIzYzNy?= =?utf-8?B?UnlieEpWTS84TGZqSjBNOTgxRDhqNXFpdU9RZkl3SVJ6L1Y1VlhOM3hBWitl?= =?utf-8?B?N0FCSUVvY2JJa2RYY2t5WWZ4c2MrK3pCV0JvcUs3dlQxZXNLemx4Yzc5T1cx?= =?utf-8?B?VmJUdlMrcmdOZ2FhVE1Cb2ViZEUvbHI3RWNPWjBCV3lGZEQ4eVh3NVppVy85?= =?utf-8?B?Q3NoR0FjMXJ5M2hrYnlrWlJmRFhJWUdwVnJCRXZGb3VzY25vUlBmZlZ2UUUy?= =?utf-8?B?UTNldVZNN3Mzc1NKVGFaazRIRGtpMVRpTE1OL1oxQzc1YS9WY1pobXd3b1Rw?= =?utf-8?B?SEo5cGgwOVBVZGtvbjBZY3JzTnBsSkt2MU5MTnRYRTIyL291dDN4OENkMWM0?= =?utf-8?B?QXFQeWlBcjB4YWpTYWlzTmtIM0ZGTDh5dzJ3byszT21reUxLTnZLR1U1ZzBR?= =?utf-8?B?VWNISHJkU1EzaE92ZUlUZ1ZWeWVINW14RUpBU3JPdnZyRzVZTFo2eUtzTWV3?= =?utf-8?B?NE1qRk9CdXozVGtSOHhVZkhEK3BzOTV6QW1OandJTGtZcDI1MHJ5cWd1VlN2?= =?utf-8?B?MGJ1VkVwZC9WNDZMaTdLMmQwL0ZCNVNreHR1YktpTy85OWRjWDE0Tnp1WkZW?= =?utf-8?B?b1ppaG1uOUtscnlRaGIxV2g5NWlmR2YxRUk4dzE4aDhaOXRBRkpBY2s2ZU1C?= =?utf-8?B?OFpxc1VaRExlMXBrRjkzQitBMlB3NjZBNmFUdmFTT21nNFBNUTNONFNUTlI0?= =?utf-8?B?bVpDY2ViVnlaYjQxUUZlcGVPMmJjZWRaMVpiYmpRMWFDMkcyTWprZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25593791-7bfb-4a2c-b879-08def7b0109a X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:54:30.8472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: URj2g2in0RX15UaF7QxOoVT/4IGCYiPVGZ9xLWL7j4lK7qkYEjb3QV3FaJ6PEOFEf+WPsiZDEGzIQ9hn3wAy369072wgKDujIYVtvefDYG4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6946 X-purgate-ID: tlsNG-720697/1786456476-F30B02AC-3D9A5D78/0/0 X-purgate-type: clean X-purgate-size: 4762 On 16/07/2026 3:11 pm, Julian Vetter wrote: > Now that the toolstack always resolves a concrete GIC_V2 or GIC_V3 > before calling createdomain, nothing on the Xen side needs to resolve > GIC_NATIVE either: > > * A new gic_domctl_version() helper returns the XEN_DOMCTL_CONFIG_GIC_* > value matching the host's gic_hw_version(). > * arch_sanitise_domain_config() uses it to validate that the requested > version is compatible with the hardware, rather than resolving > GIC_NATIVE and writing the result back into config->arch.gic_version. > There's currently no support to run a guest on a GIC version other > than the host's, so this is just an equality check. > * create_dom0() and arch_parse_dom0less_node(), which both always want > a vGIC that exactly matches the hardware, use the same helper instead > of GIC_NATIVE. > > With nothing left resolving or relying on it, drop > XEN_DOMCTL_CONFIG_GIC_NATIVE from the public ABI. Every caller must now > request a concrete GIC_V2 or GIC_V3. > > This is an incompatible change for any toolstack still passing 0 > (formerly GIC_NATIVE) expecting Xen to auto-select a version, so bump > XEN_DOMCTL_INTERFACE_VERSION and add a CHANGELOG.md entry. This is an API change, not an ABI change, so you can leave the XEN_DOMCTL_INTERFACE_VERSION alone. > > Signed-off-by: Julian Vetter > --- > Changes in v3: > - Second half of previous patch 3, with only the changes to Xen > --- > CHANGELOG.md | 3 +++ > xen/arch/arm/dom0less-build.c | 3 ++- > xen/arch/arm/domain.c | 25 +++++++++---------------- > xen/arch/arm/domain_build.c | 3 ++- > xen/arch/arm/gic.c | 16 ++++++++++++++++ > xen/arch/arm/include/asm/gic.h | 6 ++++++ > xen/include/public/arch-arm.h | 1 - > xen/include/public/domctl.h | 4 ++-- > 8 files changed, 40 insertions(+), 21 deletions(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 356be88351..74f02e91db 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -13,6 +13,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > ### Added > > ### Removed > + - On Arm: > + - XEN_DOMCTL_CONFIG_GIC_NATIVE has been removed. Toolstacks must now > + explicitly request GIC_V2 or GIC_V3 when creating a domain. "Available GIC versions can be queried via XEN_SYSCTL_physinfo." > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index baa3a5d708..b396d5e615 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -609,23 +609,16 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) > return -EINVAL; > } > > - /* Fill in the native GIC version, passed back to the toolstack. */ > - if ( config->arch.gic_version == XEN_DOMCTL_CONFIG_GIC_NATIVE ) > + /* > + * The toolstack must pick a specific GIC version. Xen doesn't choose on > + * its behalf. It only checks the requested version matches what the > + * hardware actually has. There's currently no support to run a guest on a > + * GIC version other than the host's. This is path is used by Xen too, so "toolstack" isn't right.  Really, this only wants to be the final sentence.  Everything else is trivially clear from the following logic. > + */ > + if ( config->arch.gic_version != gic_domctl_version() ) > { > - switch ( gic_hw_version() ) > - { > - case GIC_V2: > - config->arch.gic_version = XEN_DOMCTL_CONFIG_GIC_V2; > - break; > - > - case GIC_V3: > - config->arch.gic_version = XEN_DOMCTL_CONFIG_GIC_V3; > - break; > - > - default: > - ASSERT_UNREACHABLE(); > - return -EINVAL; > - } > + dprintk(XENLOG_INFO, "Unsupported GIC version\n"); "Unsupported GIC version %d\n" When complaining that a value is wrong, state what it is.  That's far more useful than "something went wrong".  In particular, finding 0 in this error message means that some caller hasn't been updated to avoid passing NATIVE. > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index 7d6f87e8b2..6987f5bdf4 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -319,7 +319,6 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > * struct xen_arch_domainconfig's ABI is covered by > * XEN_DOMCTL_INTERFACE_VERSION. > */ > -#define XEN_DOMCTL_CONFIG_GIC_NATIVE 0 We tend leave bredcrumbs around when removing constants. /*      XEN_DOMCTL_CONFIG_GIC_NATIVE    1 - removed in Xen 4.23 */ ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 11 14:00:12 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 14:00:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388259.1629470 (Exim 4.92) (envelope-from ) id 1wtn1S-0006l8-QV; Tue, 11 Aug 2026 14:00:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388259.1629470; Tue, 11 Aug 2026 14:00:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtn1S-0006l0-Mg; Tue, 11 Aug 2026 14:00:06 +0000 Received: by outflank-mailman (input) for mailman id 1388259; Tue, 11 Aug 2026 14:00:05 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtn1R-0006Q7-3U for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 14:00:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtn1Q-003DyQ-0j for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 16:00:04 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b2ada-bab6-0a2a0a5309dd-0a2a4504eaec-26 for ; Tue, 11 Aug 2026 16:00:03 +0200 Received: from [40.107.208.23] (helo=PH0PR06CU001.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b2ae1-b57f-0a2a45040019-286bd0174e36-3 for ; Tue, 11 Aug 2026 16:00:03 +0200 Received: from CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) by DS0PR03MB8197.namprd03.prod.outlook.com (2603:10b6:8:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.11; Tue, 11 Aug 2026 13:59:59 +0000 Received: from CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37]) by CH8PR03MB8275.namprd03.prod.outlook.com ([fe80::a70d:dc32:bba8:ce37%7]) with mapi id 15.21.0292.024; Tue, 11 Aug 2026 13:59:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TYZvjBROyI+wII/17UrH9QnzVpyqctauJXG+dvj+CRLM4T4oSOFpc9w+MlMeweylgQGpOlRrXsOY2w+/S87p0TjlL+D+f0g8FSiL0yjlC9MQDlX8Q/fnoV6Ip/d0/mfmlUT19jSNrh2stjOH0sCRiglwe/wuzkRyMhOv+LmX4dAlcSkr3X3fJDSJm5gVDdI5uzy1wJ6g+6btj/tf9alS7O0sPgzHOq66jQSFv8KMae8ykx6zq97A5OtUU+8W/MWvozye8E40/DknmrYKG98sQJeh65bAEYKn0RP12Z5+ZlR3Ja/hql26JJyeaAe37mQixgQWJK30AgdTh4w8PkyCDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0K66Rlwl8cRN2U2VYrij4lVf/l9gfUC2MKBew1hXig=; b=yEi6945I3soIH/ExhEVGu00NmVPuqM8whlK9lrNspuXVAvyH6CuW1E7HBL46ieAmM0nPedF+2+icr/ssJHYowIOmtvsZUZOBxbMmHusRNJe+vGlCb7+UweefIDERnoOfZTT9sVXzDvbzszfz0nUgT6SA25r+7SqBXG9k3mUYE8wYmWKZTqWAGcUd/lyYwTVj6I5bMNHx8DNHTexxK31n1ugnRnJ1YXCWktvFSGr+FckXu5UDKw6BTHlHX6a5C6pJvH345v4mX+/ohKWa3mhSQI88J8H1plEdWsCZkicO61gxpp2pnMJ1pURBn4m7A0cBSUfW5ux5e/KdY8/V/sdY9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0K66Rlwl8cRN2U2VYrij4lVf/l9gfUC2MKBew1hXig=; b=YTKimTGGR9HCkMrPfdy08UuVFMEmFeqFECa+B70Lq6rEh5Mwdy8S9wbdbYQpA0MDM7UH/V4B/TPfTcKV74x1cULmJifmLnJBRQxPpYtperbAEKW2cOGFWANH9qVLc6R7bk0aWQmcbGub2354tnAjwArYVCGicYHUWJAGkyjRySo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5e314dea-42df-4a5e-b855-f5735760ee66@citrix.com> Date: Tue, 11 Aug 2026 14:59:50 +0100 User-Agent: Mozilla Thunderbird Cc: Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Juergen Gross , Andrii Sultanov , Guillaume Thouvenin , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Oleksii Moisieiev , Timothy Pearson , Alistair Francis , Connor Davis , Oleksii Kurochko , Teddy Astie Subject: Re: [PATCH v3 6/6] xen: make config argument const To: Julian Vetter , xen-devel@lists.xenproject.org References: <1784210820.8631fc262581453bbf619ec5b2062170.19f6b408bba000edb5@vates.tech> <20260716141138.88265-1-julian.vetter@vates.tech> <1784211106.8631fc262581453bbf619ec5b2062170.19f6b44eb46000edb5@vates.tech> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <1784211106.8631fc262581453bbf619ec5b2062170.19f6b44eb46000edb5@vates.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P265CA0025.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::6) To CH8PR03MB8275.namprd03.prod.outlook.com (2603:10b6:610:2b9::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH8PR03MB8275:EE_|DS0PR03MB8197:EE_ X-MS-Office365-Filtering-Correlation-Id: d034012d-d04d-4910-94b8-08def7b0d3cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|23010399003|366016|10067099003|56012099006|4143699003|11063799006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 8bdjZS87W5WBMZOGBGlCvg1eLt3xz1iAJNW6IwCYsUone5O6oHcOP/oh3n9rx3vFcddv/zSZ4nS+u9Tif5Y7yaBoQ5J+kBSswU3Q6H0pB557NjJfCRIQJsragoGtxwey4CBeFL1B1LI7iE/a0pFWTrBgrawdE8oLRsoxTgFsV++8lFLqJDva8nKO0ILEmMOzjuN8tL5PsAqhWs8GsFdBx7vtutz37v7ORrxN24hpEGorVsu3RYneiDPrA8sfq37dJ9/6gW6foRNpvvnUNPU/371MgF+BZy5K70rSUy5f5IJ0ve+eJfxPPEUxaDx0A7NYhkuMJOrV7YSrSH8lHW6flUzw2qvZQwHqgZrX02XajMCtqnuIvfq8BagIy0PqZh5Bctds8HQp4b113BopUNSC9HwW8kZj3BZEpjuV4HFMV2np+LPDzqrFGO9iGLTCjD4XwWG+9dwKBMiPWFTf15slYTpw8YLKwXmsxLuYqrrDx2okIddTcVhxTiKKgsFtJytcCVVrYzE5sfx227l+hmX3m7SICNu05uZFdhlJ1t4oNHPO12J7e48OWitKHU/edXyI95ZW+z5TPF945ankeMPcOPkQP1xgQvFTNX8+JAwrPaYwyf/4zn8BslfjQq3HZLwSMEezLmtGHBd6XlAHdRU+39Gj40lbfNey8Y7nCfCYiHU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH8PR03MB8275.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(23010399003)(366016)(10067099003)(56012099006)(4143699003)(11063799006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVQ4YjRnQVAydzBERVgrbXBxSS85a1BJNTdwS2xtQWxHcnRoOUNyK3R6WjFG?= =?utf-8?B?RG5QL0xHUWFuYi9kZ3U4OStFWkJud1lNWWpKVGNPQzN4Nk9BYkc3S2cxQVBM?= =?utf-8?B?RGMzSDNDQnNIb1ZlbVk0Rzd6b29DdUZySXYvdjZHU210Y0I4eE1wUjlFbTl4?= =?utf-8?B?aGNQTEg0TDhmeVJXeGZJMy9aNTQ0YlVGeGtjb0Y3ODRJcDc2VkhyM1FncTR6?= =?utf-8?B?azhlLzRsdmlQbkVXMi9NSHgvOUNoYndVcnBuN0VQcjhWV3NiT0JyQjBkMTU1?= =?utf-8?B?MmtpR0N2eVgzTWN2MGNUbzkrVjhQSktkTzFwNG1vTzRkOWk2RnYxRmphRHJo?= =?utf-8?B?M1JaYW9XYWFwdVZpdkJDMnQ3Q0JtcGVQT3c1TFdnS3NMMWhOUXp4bUkzWSsz?= =?utf-8?B?Y3lweFBJeEl0NnA1WkdzMm1SNm9JNGNGWFJKczBlRytCaU1Ha2hCZ1pjZTJv?= =?utf-8?B?dDYzWFFWNFVMcEoxaFh1YjhYMjB3UDMyUmVDcWFPWTdpKzhkYy9YenVHa2Q5?= =?utf-8?B?RHh4TzN1VHY0RHNrYXZCN2Y0ekV1UkJBTk1ackpJUjlXREJoN1AvQUxMbjFE?= =?utf-8?B?dml2MzhGM0ZOZUZ5SStWcnZhT1VTVUtINUFlNWJTY2hudnREb01ydG5OMFdP?= =?utf-8?B?WU12L2xSM040VzdrbVhmRFVIQnFCbTVINjFaYVFpdVJvOXdLa3F3NmhlVjA3?= =?utf-8?B?UDlnMkVYbDB3VHNvVDRMS0M3OFhrS0N3dWs3YXZlemIxbGJ1SnRjY2FTelZF?= =?utf-8?B?SGM3QjYyRDBwbkt6eFI4NFQ3c2gvdXJpMk5OUHd1bll2eU5Ybi9tS0g2TmVn?= =?utf-8?B?N2xtZldKOFpkcEZTaGtMRkhaVmNxU3ZrUmZYK3VFeVpXTDhuL09tZnhQYjF0?= =?utf-8?B?UWs5Sis3R2c5eGNqRyt4TGFiSjhLWDNQeG14NEpjVDVJS2t3ZTV1MitFN0FH?= =?utf-8?B?OFdQVFJKMGRhTTZtOGhvdXQyKzErVDBDUmJUUnUzSFNWVE9hZFNMWmd1U3pS?= =?utf-8?B?dVRDMGtFUmNvSkJGbXVBSklWQWFnSkRwdFVzbFpzcTZtck5GVkRhRUJxRWdv?= =?utf-8?B?TVdqWjRhMFB1OGFOUGY5MmszRFpyUi9CcTJZUXAvWkNheEdGcWE1L3cyMi9p?= =?utf-8?B?MHRuYjhzV0FmTGhQOGJNd2pMS1VWN0Erd01lbnJpb2dNTjdoYWJVT1RnVVFn?= =?utf-8?B?dXJ6em15SDFPamdJRURoL29XTEYrVU1HOVRvNXdVZy9SdXJEclpDUFdoenJl?= =?utf-8?B?YkJ5R3hxRXFuN01IUlRQTkJjK0ZLcndOdDYwRjVKZE9wYmg1a3hoWjMwUmlJ?= =?utf-8?B?TUNlQlp6ZnFVY0hEdW1EU0hndko0c2c3QlNOL0Q4emNSMzJPNU5vUlhoMUlQ?= =?utf-8?B?T0Rlam40UHhlbWI2T0tvWmdLUXlhMTZab0sxeFNiZmlzSVdwaHNKOCtqQlBh?= =?utf-8?B?Sks2VFQ0MFJ4cFUrYXNnSXdodnJLc2hicWZSM1JNRXZ4ZDJkMlcyNk1OSmt1?= =?utf-8?B?Q0JmQmRFdU4wQXR1VUNGTUpRdWFGMFVDZENTcS9SY0o0K25vTmVDUEFPclgw?= =?utf-8?B?SXY4alV3SDFud1NER0NPTHRPSXcwTWdvQThUdUxNQTEwbHlqdWY0TWppY2po?= =?utf-8?B?STF5R1MyS0dmbFFkR1V3TGloU2JtSTdBU2NrR2E1bytOdnJyTDVwYTNnQUV3?= =?utf-8?B?OW80Y3crQXBQVzlmTmU5TFNXLytIblJPT1YyRWd2YTVlNzM5Q0N6R2l5Z1lu?= =?utf-8?B?cmRFZEl1L0NGWUJMb2xkQzQ1T2ljTUR0NWFWOTVQSm1hRHFXTU0yWVdrclZI?= =?utf-8?B?WXZEaVdRelo5eVQ3VzhqU0VKU1ptaU5WWkxFV3ovY1NkRzFsSjdwejFncDZE?= =?utf-8?B?SHIwV2NRbGpNRGRkdUU5NzdFRTN4QkpXc3FBa2hjd2xkZUxLUWMydW5vWDFs?= =?utf-8?B?SjE1Y2RzOTBPdDluVWlHbUdlZGV0REtwV0dqRGVKdHR6QWxQUmI3NnN2U2lM?= =?utf-8?B?NXpHWW5CczAxMy9GYTlnZVJSZjJwWE1oekovK25ma21QcWtDeTFBclJIbmlt?= =?utf-8?B?M1ZBd3h2ZzB3K3dJVHArdEE0WUtZWnozV2tPc3h4c0tMMVpmWDE4MnFjbHNh?= =?utf-8?B?R1dzck5ndmplNkkzQno0SmRtMVBRSzMzWHZ5MTNCeGRjZ2h6d25sdDNOdk9m?= =?utf-8?B?T2diRlZoSGVWb2pVZEc1b3JZY1B4QTAxaGEwdDhrQ2xocm5sMCtQTDVJRVcw?= =?utf-8?B?RkN4ZS9UNDExUXB3U081N0paK0hLblBVdVhjS3dhZ0JmSUZjUmtmcnpXcmE2?= =?utf-8?B?UFBET05iYTBqeXYwWmpMZTk5bUk2THk5SlpZdktKSnR1SHFTT0NwZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d034012d-d04d-4910-94b8-08def7b0d3cb X-MS-Exchange-CrossTenant-AuthSource: CH8PR03MB8275.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:59:58.0736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uX5YRARdr9daLfABKDZZGZukgg2hy1ub/o8TnUDj3C4fDfaJJOk263QUOuk4a0a/STKE79xtB3buQWZ+zineQ9J74XiFn/oHtV4kREaalPY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR03MB8197 X-purgate-ID: tlsNG-ebf023/1786456803-C0AD8B50-D4C55635/0/0 X-purgate-type: clean X-purgate-size: 992 On 16/07/2026 3:11 pm, Julian Vetter wrote: > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index 011292e9f7..66ed7454ba 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -756,9 +756,11 @@ static inline void domain_update_node_affinity(struct domain *d) > > /* > * To be implemented by each architecture, sanity checking the configuration > - * and filling in any appropriate defaults. > + * requested by the toolstack. config is not modified: createdomain is > + * input-only, and the toolstack is expected to have already resolved any > + * defaults. > */ Again, "toostack" is wrong to say here.  I'd suggest finishing the sentence at "the configuration." ~Andrew > -int arch_sanitise_domain_config(struct xen_domctl_createdomain *config); > +int arch_sanitise_domain_config(const struct xen_domctl_createdomain *config); > > /* > * Create a domain: the configuration is only necessary for real domain From xen-devel-bounces@lists.xenproject.org Tue Aug 11 14:10:01 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 14:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388269.1629478 (Exim 4.92) (envelope-from ) id 1wtnAw-0007sz-LY; Tue, 11 Aug 2026 14:09:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388269.1629478; Tue, 11 Aug 2026 14:09:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtnAw-0007ss-IT; Tue, 11 Aug 2026 14:09:54 +0000 Received: by outflank-mailman (input) for mailman id 1388269; Tue, 11 Aug 2026 14:09:52 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtnAu-0007sm-Ax for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 14:09:52 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtnAt-00BM05-GM for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 16:09:51 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b2d15-2eae-0a2a0a5409dd-0a2a45048a64-48 for ; Tue, 11 Aug 2026 16:09:50 +0200 Received: from [52.101.70.22] (helo=AS8PR04CU009.outbound.protection.outlook.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b2d2d-b57f-0a2a45040019-346546164084-3 for ; Tue, 11 Aug 2026 16:09:50 +0200 Received: from AS9PR05CA0242.eurprd05.prod.outlook.com (2603:10a6:20b:493::26) by AS2PR08MB9713.eurprd08.prod.outlook.com (2603:10a6:20b:607::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 14:09:45 +0000 Received: from AMS1EPF00000094.eurprd05.prod.outlook.com (2603:10a6:20b:493:cafe::41) by AS9PR05CA0242.outlook.office365.com (2603:10a6:20b:493::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.292.26 via Frontend Transport; Tue, 11 Aug 2026 14:09:45 +0000 Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS1EPF00000094.mail.protection.outlook.com (10.167.242.91) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 14:09:44 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) by DB9PR08MB9730.eurprd08.prod.outlook.com (2603:10a6:10:462::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 14:09:11 +0000 Received: from VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4]) by VI1PR08MB3421.eurprd08.prod.outlook.com ([fe80::e079:6bd:fbe0:89b4%3]) with mapi id 15.21.0315.008; Tue, 11 Aug 2026 14:09:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=xcDPG0hVFOk0AUBj4C159DlzoaguQZmjigOLV2wlFCc1pdTt01jMQKGY/63LO/jOC85zG8fc5G4S/C6LkqRvQq8cGDjsCAp4G0jAx5M6heW70DQpUJHjiGaHTKnlqex+aOAtpgfSFkhVomSobgG26G6LQsP/rlLSbbT9biSftIQAxcHrOrhpc/0mz0VQw2WcUOSxlc7+nk02Fmg58AXbzUzfJrDdq58Wms8TkhdGIF914fbh+45YDgmPICpe3rEcmG8FNY3lmrlAVnxH+OvFs7B5Hh9XDmAxy7tKUofargAwaRLAuSv6YqFDrLtEJYGZ8P+hC53w/NpVCRzM9KBrRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=spajHA6ointRyLw86RivlHQVOLc0loAJEJ1TlU4g/dk=; b=g44y70zFwMxf1rENbj2VFHwbaRyRQgZzGayNR9x0/8MrFLFhqCzljt7pZsMD14Mjeoa2oQINEuzzHsUleIeFCipLAFcZZipBxMdPXY8RPqw+AEb9AiUeIQRyTI3n0Z0036JBosn0LDw/M4rlkL4dFiRVhD7ioWXRsIwQYR5qraJe5t4h49ArxxFG1BIvRemUHWrQBPcUDcd7mf8bDwzF1TTDxCo6+MssXldmesRH7X/ERmExRfyQywBYtlefGWdousS3j0NG7cUg2zL/ozv12GzgfvtaDWsfIlMMLX7AsX1VHSM6P6EnHRFJZiFzUrSylcGJcmY98ej2nd68mQrJMA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=spajHA6ointRyLw86RivlHQVOLc0loAJEJ1TlU4g/dk=; b=Of2zMK4AYCmnRWDmgZxXsjcqJPO31mxBQjUoXGVjTGfhVwp3SdIVVi7agOghu8iMGsMktBYOl3wqspqIPSdjK9UxF2eBDJ6bk6sX1c3OJggt0NuQA/Et5PtcevurQjrhzd+EKtrJjoGYBF7cOXsfD+VKGP1nFjdL2BwS8rzk/ik= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HAp0D8fED4BIknp3JzrYjuhx/SQCyUUgLhlHQqssIAq2N6Zbn1so7sXZlziVHIj7d6R6PvF8Ffjtzn5GtAwxsJVYpCiC48lY1FRKuvfiZSsIjOzx5m0rzsNPepoiaPYMUz1G50y3QAq/T9sRgB7BwN9w9N/5R6Z/dvPN6jj2BvCi5es97DYocaURGfL86kcHhZ1Slwc/nSlmXR/BKN/XnrkkkH8IwV9gNY0TdJ1pp7/fHWC6RH/vdaAWVJV5U07z0j2Ijxbtr1LpePU5MZb1DHhnujJir1mlbvttFdbM6COV0mAusxSw6xvcW/kyWYKjFzABD7KH14UKtT0642548w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=spajHA6ointRyLw86RivlHQVOLc0loAJEJ1TlU4g/dk=; b=iaBjCOaVhCrKf98DWl2iS/e0DsC7e2a2L3DMyqusEaofhJIZiVQsRraj6DPlUHWjukjnzf+AoDBXBd5Ox9PjTzzPv3+rGqnof+EKhq///cIsuJpOOu7gm5tcXvQs8wLkXbmtqZ/yG17mPwjxEksDitQGwZ3BuZrdYfyLesQWzPqWPhK7kueTmeaMsz7EK+6sUZMOSPcFkkNDWrBv25fa0YsWNMPqFyhGOArj1uD+rr+3ELIXOhc57Dz1C3xjDevg7ocWAmwbS63Ihia7vPkPc9ak4loMKc52jcciVQPoAiesWVhjMqiBGkrR2ZU76WKZ5dv12pZ7rzg4OvzuMYZSAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=spajHA6ointRyLw86RivlHQVOLc0loAJEJ1TlU4g/dk=; b=Of2zMK4AYCmnRWDmgZxXsjcqJPO31mxBQjUoXGVjTGfhVwp3SdIVVi7agOghu8iMGsMktBYOl3wqspqIPSdjK9UxF2eBDJ6bk6sX1c3OJggt0NuQA/Et5PtcevurQjrhzd+EKtrJjoGYBF7cOXsfD+VKGP1nFjdL2BwS8rzk/ik= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Tue, 11 Aug 2026 15:09:07 +0100 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , "James E.J. Bottomley" , Helge Deller , Juergen Gross , Stefano Stabellini , Muchun Song , Oscar Salvador , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Andrey Ryabinin , David Hildenbrand , Pasha Tatashin , Chris Li , Kairui Song , Uladzislau Rezki , Steven Rostedt , Masami Hiramatsu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , SJ Park , "Matthew Wilcox (Oracle)" , Jan Kara , Jason Gunthorpe , Leon Romanovsky , Miaohe Lin , Dennis Zhou , Tejun Heo , Christoph Lameter , Mike Rapoport , Johannes Weiner , ziy@nvidia.com, pfalcato@suse.de, agordeev@linux.ibm.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 3/9] mm: name pointers to copied PTE values ptentp To: Anshuman Khandual References: <20260806083926.1807279-1-usama.anjum@arm.com> <20260806083926.1807279-4-usama.anjum@arm.com> From: Muhammad Usama Anjum Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0197.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::22) To VI1PR08MB3421.eurprd08.prod.outlook.com (2603:10a6:803:80::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3421:EE_|DB9PR08MB9730:EE_|AMS1EPF00000094:EE_|AS2PR08MB9713:EE_ X-MS-Office365-Filtering-Correlation-Id: fff88c87-ef4e-46f1-d491-08def7b231fd x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|23010399003|376014|7416014|1800799024|6133799003|10067099003|4143699003|56012099006|5023799004|11063799006|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info-Original: X8qvVO1tGgOGc68Tj8e6uYIlEm61fj7Yc+rR2Ay/UJ31hxb3PHm/Vx9ayVx7BXhFCE26lvSj1FVRwdkt9qTwDUf03EfjHj5zTGh3lNmthZUPU0QqKoBPqNCZMmlIdwvntC0ETgEazcLBhiggaaU1oTVhVrF4zZNB+8zbzV+Jd4wX3kEhklK/JQF5PBzEsMQlnX/RA2nh2JKyOqzVqPIP0JRjHOvrNtwouMyn4EApYlEz54M5OIY1sJGVL2DhxYD3bw4zw1/+YIsp0Em0CEamCCEu6TYlPIaaPzdzbep4Q20xFGwIz/vtY0BuDXxxwaquypHlTctA+f8g9C3qAfi604tm9S5lbClK6rgQWc2C7gtm+k/RpQITOlu/8ySU8jRAuLryQLIaU07iwsnyadRcNDbGozKdXF53Sl5vfnr69T1lGLspteufAc2KPwXQegTPnGNpBa3XqVK3I0rj6mCz2fhoS5cgar40oNGDel28oFjLSHmTqLzlgfCXDa/SdbvfGw6kYd7pbX0X6Er0Yoa1pmDs1KkhBG+od3Lm2kLHvxMgPWvVu6+OGVUF/muODby0JcN0Z5kv6Rm9XFuwS+rujtHHfFG+S8WUrGIQGqc1z/gh7bAy38Lj79K19jGGQknUUaoEdzVxQEjI8Btl4hXMy1IFAn4QlZDRT18lnMFWkRU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3421.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(7416014)(1800799024)(6133799003)(10067099003)(4143699003)(56012099006)(5023799004)(11063799006)(18002099003)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: PoID+C9pr8SsNiZRZqrmEF20E8+VyYQrbmNS/atK0zw4H6xYhN8JDWaNyZcuAbKvDXx3md+N466b0729ETpNiHwGFoQQWHtr1wStuHk00WaD7R8uPTqjp9Pek556gM35mQe8FX1aL7Sp2zO09cPHEXYxt6UjkF20b/IyX2c8fU9p9FtV22m3Uikksqe9i+Rbf7inmIUq5CxSfVO/lt6nTQ/RZeCwOhVPzS6fqYMTUAmCwPYjztBlT9Knlw8LjChFicyl5+dVAtGMoyOikQxEQPeOpO5qwUVElOLqNbWdabbXkDPmBevoai7DCbgoVW7V/xraDV24EN08DFdilYcMzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9730 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF00000094.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 685e73f2-e898-46f2-3da0-08def7b21dbb X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|23010399003|82310400026|14060799003|36860700016|35042699022|22082099003|18002099003|3023799007|56012099006|10067099003|4143699003|11063799006|6133799003|5023799004; X-Microsoft-Antispam-Message-Info: QrDAuJ2AlDAgvei/zvkJkvfQWUZGGIE48wAeeS/YiIuKQGmvUJdnpoOGxcyZyGvL5v9YQDS11/dPPsMg2cg1TdIBKj/ZPGWerzgyXqYtwORlNDmgfnW1ufsTE6Dd8rVH5Y60KHRVB7gdGtwPo0QRPYxa+19gn2F9ZYAc7vEaMH7O/lMCMTdnVAeZpH3cffXgRvh0z4psptR+jLz5AOW2p95Mp7oEkWASyLHtxgupDKTGEedMTMvp//INjXGo2cWcA/e6GrBUxPqcX5kfCHlTW7LZJVVh7KoMepIb3kvntg0sZB7NL70Gfcia3025jrIEKnF4KqGPNa7L4Wq1HuGXv0mXVwxgNaXb4NK6wEqF20/zC2xOQ03ZEDkzIaO5E8EtDOmMHI3BTAJp19EjbxOnpsbjpZwiRMVYN8hTGfn+phsV7aF1B5A1fxxKzIWNT7TcyDZDNbDBy1fbQToFO5F+i4z/RQolLUS3Wn0ibbXuZ+MygZXiKYKpg6hE3qAiTq+5zd0g/bBOWtNab9jVgdTUMONzw2ZxDG0EgMOHwF0DiCsTueED+SeHwVgZU+GzrMz87g33N5tKbau+TbAQn2QXPF9MxQ6cHwA8s4U9bUxPnpTjQgHdHKTvFvU5aY7Ow1Ob1uTCPhu5ZMh43XcVPfVFoDWZh3bLL6721rPAVQi4Q0ZLIBz69rhhyWPreQ7jy1l9vvLbXjiKTroIq0PcnHoNqA== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(23010399003)(82310400026)(14060799003)(36860700016)(35042699022)(22082099003)(18002099003)(3023799007)(56012099006)(10067099003)(4143699003)(11063799006)(6133799003)(5023799004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vJDzeRb927ULnuNkJdCXMZlhivSk2C+D0uSOnJ7V3ytepBxLXm9FF/vHnPjZGBO8nF2u/+cRH8iKRjoTl1m5jFnoKyjflZUcWX7Uxbggm+eXM9hAPxwV4hQPwdlt4m0bJeyYkEMZjtJ+HCNEdOf49hoHllcfXObByHwyeCPEQEmfATo3YQAMseQqQ7nJkmgo6XalANWP4f+Hdn6/bPhbPvRs6gKRx7T3WlexdzGR2IR9A1t+EG24dcOLQcX1a9QiijX+f/ItEgCVcLa2WlN9xjjcH98InlLSbUc2rfQziuUojQeyl1c6FmjcOBGg5upE1sHsKJ1LCXjFA4h57R19kbwEWTeGr3YiuKif/ZnDswdLKZ+f+keUwx3sdcTyYKRVhOGkpjBK2wm3HgH+r5/JTrWf3YKzp7BzmT/1RjYxYw8ipU3vIF94I+n/8KtOtGbE X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 14:09:44.7531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fff88c87-ef4e-46f1-d491-08def7b231fd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000094.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9713 X-purgate-ID: tlsNG-ebf023/1786457390-C28C9B50-8B9D17CD/0/0 X-purgate-type: clean X-purgate-size: 4613 On 11/08/2026 11:58 am, Anshuman Khandual wrote: > Subject line is very confusing. Perhaps something like the following. > > mm: Rename pointers to copied PTE values as ptentp > > But even 'copied PTE values' is not very clear as well. Something like: mm: rename pointers to logical PTE values as ptentp or mm: rename pointers to software PTE values as ptentp > > On Thu, Aug 06, 2026 at 09:38:41AM +0100, Muhammad Usama Anjum wrote: >> The hw_pte_t conversion must retain pte_t * for pointers to standalone PTE > > We need to explain what is `standalone PTE values` first. > >> values. Name the value parameters ptentp in the install_pte callback, >> write_protect_page(), and guard_install_set_pte() so the later mechanical >> conversion can distinguish them from pointers to PTE table storage. >> >> Some functions already use the ptentp name, including: >> - madvise_folio_pte_batch() >> - folio_pte_batch_flags() >> No need to convert them. >> >> This is a naming-only change. > > Small nit - s/naming-only/rename I'll fix it. > > The commit message needs rewrite clearly explaining the following details > > - What are standalone PTE values Logical/software PTE is correct and better name here. > - How these are different from HW pgtable pointers > - Change is just a rename for pointers into such 'standalone PTE' > - These renamed 'ptentp' here would be used for skip or replaced during > upcoming mechanical change via a script > - No functional changes intended I'll update message in more elaborate way. > >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> Changes since RFC v1: >> - Update the description for the architecture opt-in conversion. >> --- >> include/linux/pagewalk.h | 2 +- >> mm/ksm.c | 4 ++-- >> mm/madvise.c | 4 ++-- >> 3 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h >> index b41d7265c01bc..c34d826c5e4a2 100644 >> --- a/include/linux/pagewalk.h >> +++ b/include/linux/pagewalk.h >> @@ -89,7 +89,7 @@ struct mm_walk_ops { >> struct mm_walk *walk); >> void (*post_vma)(struct mm_walk *walk); >> int (*install_pte)(unsigned long addr, unsigned long next, >> - pte_t *ptep, struct mm_walk *walk); >> + pte_t *ptentp, struct mm_walk *walk); >> enum page_walk_lock walk_lock; >> }; >> >> diff --git a/mm/ksm.c b/mm/ksm.c >> index ad05d7791307e..11d50518d02e9 100644 >> --- a/mm/ksm.c >> +++ b/mm/ksm.c >> @@ -1292,7 +1292,7 @@ static u32 calc_checksum(struct page *page) >> } >> >> static int write_protect_page(struct vm_area_struct *vma, struct folio *folio, >> - pte_t *orig_pte) >> + pte_t *ptentp) >> { >> struct mm_struct *mm = vma->vm_mm; >> DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, 0, 0); >> @@ -1371,7 +1371,7 @@ static int write_protect_page(struct vm_area_struct *vma, struct folio *folio, >> >> set_pte_at(mm, pvmw.address, pvmw.pte, entry); >> } >> - *orig_pte = entry; >> + *ptentp = entry; >> err = 0; >> >> out_unlock: >> diff --git a/mm/madvise.c b/mm/madvise.c >> index 07a21ca31bad4..c324cc991f841 100644 >> --- a/mm/madvise.c >> +++ b/mm/madvise.c >> @@ -1101,12 +1101,12 @@ static int guard_install_pte_entry(pte_t *pte, unsigned long addr, >> } >> >> static int guard_install_set_pte(unsigned long addr, unsigned long next, >> - pte_t *ptep, struct mm_walk *walk) >> + pte_t *ptentp, struct mm_walk *walk) >> { >> unsigned long *nr_pages = (unsigned long *)walk->private; >> >> /* Simply install a PTE marker, this causes segfault on access. */ >> - *ptep = make_pte_marker(PTE_MARKER_GUARD); >> + *ptentp = make_pte_marker(PTE_MARKER_GUARD); >> (*nr_pages)++; >> >> return 0; >> -- >> 2.47.3 >> > > How did we ensure that the above changes are comprehensive and nothing > else got left in here ? The order of patches and even the code was found out after adding hw_pte_t structure. Then everything was converted, until some pte_t pointers were left which didn't require conversion. If something is left, we'll get build errors when we build a converted architecture. So the branch mentioned in the cover letter when built, would produce build errors. (Those patches would be sent separately, after finalization of this series). Whenever I'm rebasing (on mm-new), I'm rerunning Coccinelle script to see if new code has arrived which requires conversion or renaming. -- Thanks, Usama From xen-devel-bounces@lists.xenproject.org Tue Aug 11 14:16:20 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 14:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388278.1629488 (Exim 4.92) (envelope-from ) id 1wtnH6-00016U-Dx; Tue, 11 Aug 2026 14:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388278.1629488; Tue, 11 Aug 2026 14:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtnH6-00016N-9r; Tue, 11 Aug 2026 14:16:16 +0000 Received: by outflank-mailman (input) for mailman id 1388278; Tue, 11 Aug 2026 14:16:15 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3qy57agYKCVAAws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 1wtnH5-00016H-9v for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 14:16:15 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtnH3-0048Bi-SL for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 16:16:13 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3qy57agYKCVAAws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 6a7b2ead-e002-0a2a0a5209dd-0a2a4502b0a4-0 for ; Tue, 11 Aug 2026 16:16:13 +0200 Received: from [209.85.215.198] (helo=mail-pg1-f198.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3qy57agYKCVAAws51uy66y3w.u64Fw5-vwDw330ABA.Fw57961wuB.69y@flex--seanjc.bounces.google.com>) id 6a7b2eac-6ca4-0a2a45020019-d155d7c6ecfb-3 for ; Tue, 11 Aug 2026 16:16:13 +0200 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cbedb8673ceso286302a12.0 for ; Tue, 11 Aug 2026 07:16:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786457772; x=1787062572; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0x2URhZVNyLUMnaCJcyZpjyHlUxRNnCvJLXmuoMKMjI=; b=mZf5aOBzHwiaCkZo7PLsa6xBUUgMwtBkmxz/pOw4wGgEJxJe93Y1zgff2SZy3GxpOT +MW3C+kJ9k0epU1EDBRzmpueDeW67RlvNYpIdq3OwKq6z1w97x/NWebU/0CTIG3Fco4u r0IdbgPF0XRkJM2I/tM3uGopEm32j7yrorccuhS4V5NjWPwYO4H4E9N/Hzodr6dFo6s6 nIGs1oIXuoa/1IZXe2aWNAKKoyvOs2Lh42pxMkvO7ou5tG/g4QMjK0QrDsICLFY7KnOq Av2H3qNIPw0LQXTM3GVigbx7amZgVmPrIeXoHrftgJDxrNJqIsC0R4GVBt7mCQ/NIqHu QXUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786457772; x=1787062572; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0x2URhZVNyLUMnaCJcyZpjyHlUxRNnCvJLXmuoMKMjI=; b=PhQa5OsrZlym/LgSbb5NSbocYBOXdSTKh8YbLecgHiOykOyA9EnlqIFl8NJ2HNup23 TMgzazTh6kOv2tP2/XY1ojULAlclIWGEYTaYwQu+R0GwN432yH1ZXUGvX5r6McdLJk4w iwK0ipuDEBom+3EIZMvqyILKKcInaYV4rCCBXYG2YLZGaioXdv7paeQQ7BbUX3yiyUyQ nWsoLd34HP5sj14Qo/Xp4xxe4Q719w883epc0fOgQQ5PQurSzlM9S1MRMd5f3AyWo+Lt BN0QmmADqhXtFuBXJ0cxgzwZFj8Q43ulKd6UEdgIYfGYYvr+LTzFzuGyh9MMLf1imOFL fkgw== X-Forwarded-Encrypted: i=1; AHgh+Roc5U+xcPaaE6xEVxWyYfR1WZ9SooJAPBYku0mADqE2sYVAWn4WKCmivAU7dBvw8X8E8fhg77s+/Q4=@lists.xenproject.org X-Gm-Message-State: AOJu0YwefaRWlJqXx+Of77dBHOb4JLfXYJDl0nl/90N2xBSz5+kuZjEY GS+t6qrieZ2/GcQDIOGaTL6yiayegt63aqw6SPN75sP0l9Sc9QRI3HJBoauz5Yoehdh9rxVDG9b QxZeLGQ== X-Received: from pfbkm16.prod.google.com ([2002:a05:6a00:3c50:b0:84a:310d:317a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:f8b:b0:84e:4d6:78fe with SMTP id d2e1a72fcca58-84fa86b672amr4014025b3a.3.1786457771384; Tue, 11 Aug 2026 07:16:11 -0700 (PDT) Date: Tue, 11 Aug 2026 07:16:10 -0700 In-Reply-To: Mime-Version: 1.0 References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-18-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v7 17/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1786457773-F38BC2AC-BCE1BB86/0/0 X-purgate-type: clean X-purgate-size: 1726 On Mon, Aug 10, 2026, David Woodhouse wrote: > On Mon, 2026-08-10 at 13:56 -0700, Sean Christopherson wrote: > > =C2=A0 > > > > To allow different offsets, KVM would need to track a per-vCPU offs= et to the > > > > master clock and apply that in kvm_guest_time_update() (and maybe o= ther places?). > > > > Which is doable, but it's not clear to me why we'd want to support = that (though > > > > I haven't fully processed the back half ot his series, so it's very= possible I'm > > > > missing something obvious). > > >=20 > > > Because I want to reduce the number of cases where we have to fall ba= ck > > > to non-masterclock mode. Especially the ones which are driven by > > > *guests* rather than weird choices on the VMM's part. > >=20 > > But why though?=C2=A0 What is the harm to the host or guest?=C2=A0 E.g.= does it make it more > > difficult to accurately migrate the VM?=C2=A0 I'm not opposed to allowi= ng master-clock > > mode with diverging offsets, just trying to understand why it matters. >=20 > Accurate migration without masterclock is hard, yes. The > KVM_SET_CLOCK_GUEST thing relies on it (because the principle is that > you get the *TSC* right, then the KVM clock is just a fixed > mathematical function of that). >=20 > That *shouldn't* be difficult with offsets between vCPUs. Just use the > TSC of vCPU0 as the reference for KVM_SET_CLOCK_GUEST and let the > others just have their offset from that. Yeah, my only (quite mild) concern is that we would introduce fragility by = adding yet another variable that needs to be accounted for, but AFAICT it's litera= lly just the tsc_timestamp in the shared data structure that consumes the per-v= CPU offset. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 14:33:51 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 14:33:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388291.1629497 (Exim 4.92) (envelope-from ) id 1wtnY1-0004IR-M3; Tue, 11 Aug 2026 14:33:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388291.1629497; Tue, 11 Aug 2026 14:33:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtnY1-0004IK-Ip; Tue, 11 Aug 2026 14:33:45 +0000 Received: by outflank-mailman (input) for mailman id 1388291; Tue, 11 Aug 2026 14:33:44 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from <3wzJ7agYKCXAgSObXQUccUZS.QcalSb-RSjSZZWghg.lSbdfcXSQh.cfU@flex--seanjc.bounces.google.com>) id 1wtnY0-0004IE-SA for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 14:33:44 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtnXz-00Ejsx-Ox for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 16:33:43 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from <3wzJ7agYKCXAgSObXQUccUZS.QcalSb-RSjSZZWghg.lSbdfcXSQh.cfU@flex--seanjc.bounces.google.com>) id 6a7b32b5-e002-0a2a0a5209dd-0a2a4502853a-46 for ; Tue, 11 Aug 2026 16:33:43 +0200 Received: from [209.85.215.199] (helo=mail-pg1-f199.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from <3wzJ7agYKCXAgSObXQUccUZS.QcalSb-RSjSZZWghg.lSbdfcXSQh.cfU@flex--seanjc.bounces.google.com>) id 6a7b32c4-6ca4-0a2a45020019-d155d7c7bc2b-3 for ; Tue, 11 Aug 2026 16:33:41 +0200 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c89704da8c7so4852181a12.0 for ; Tue, 11 Aug 2026 07:33:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=google.com header.i="@google.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version:In-Reply-To:Date" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786458820; x=1787063620; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=wHiT8wO1O96VMhGw9PY7w1Kf2WhC1UcbMKtaZdcKQc8=; b=jY9G/FmRYe3cHYCB/IkbdZM8Y7PU+hTNTdVoSYbq+WcQH9Gp+VmqTwPoqBwhJ/TvgO IAyejSoz1N5p/nLJ7eGYkeKXPkQGg4Oleg4rEdsVQu/ytJrA64PW5A2jNP9yfmB+bf+j vpim/AO++shRJzSHKy8r8iOqnXfcewnCjA5RW7kmpbY5jtZMr+SY8NUeYFnxXrSKNTLf aPrGhW2sGd7mBJhiXsdngoPkqgyzjDTdafGABLg7BEQGk8O0NaFnJy6jwvJgcc+GIJLc IjnjiT/VJDKW0SH9JtVZjNUVqw9LkPILJiRbzSkgdxzzV0LsaRE7R8IyEKzvNkb+A3Jz zIjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786458820; x=1787063620; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wHiT8wO1O96VMhGw9PY7w1Kf2WhC1UcbMKtaZdcKQc8=; b=HB4jTJPZ0mSNL49b6+xhz/hxK1pOVFMTyeR9W0j4HS5lWbKSzQbLMRcpIsQtTC+AGs xjwm3vQO5EoHHO3TDEGMxHRwRMpekdnElXu2kUGxKWrz7ApEnelAQDtqgr+dGNIB5WgV KJN3Z35JsYYfljzZXVPa+NGn5JbFoPeoTtqzJwTJ4AhLy3hRPcnKqjytzgp/n3G0t2DF HIfSrvg0iuStVgdbhaBNgKAheSTLzFlTZW/SNdt8vVjMBiy/BNaM6VwIAcTixPqjtkdo iF+0O0cDoFq+Yn0/rQWEmJmBF+0pvUo76XjovB9giPpTNMbRu9k7yY78aVZyiIbNh3aG RKIw== X-Forwarded-Encrypted: i=1; AHgh+RoSPVeb4z4vPEX2xtZhEFDfkeOqfOX3nxRBQ3qg9cGTUHbBdhfmw9YnDeOzsUMpDNIrVhjjdwI8GCU=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx/6byYGB5vau7St8Z66b9+ls5tOjFQh4vODA8bZn2i5LriYv3w bR3hJ4r0bBbaEHRQvAguSm6sTD2rCfqG06fStJyvEAN7A70EsR0PRKBUcY53dl20yeBTDVkbqnt UFVeh6w== X-Received: from pgmo14.prod.google.com ([2002:a63:5d4e:0:b0:cbe:7df7:35b0]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:9f10:b0:3bf:77d7:667d with SMTP id adf61e73a8af0-3cc2babdf84mr4904619637.28.1786458819619; Tue, 11 Aug 2026 07:33:39 -0700 (PDT) Date: Tue, 11 Aug 2026 07:33:39 -0700 In-Reply-To: Mime-Version: 1.0 References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-18-dwmw2@infradead.org> Message-ID: Subject: Re: [PATCH v7 17/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-purgate-ID: tlsNG-720697/1786458821-F06A72AC-419BA02C/0/0 X-purgate-type: clean X-purgate-size: 2735 On Tue, Aug 11, 2026, Sean Christopherson wrote: > On Mon, Aug 10, 2026, David Woodhouse wrote: > > On Mon, 2026-08-10 at 13:56 -0700, Sean Christopherson wrote: > > > =C2=A0 > > > > > To allow different offsets, KVM would need to track a per-vCPU of= fset to the > > > > > master clock and apply that in kvm_guest_time_update() (and maybe= other places?). > > > > > Which is doable, but it's not clear to me why we'd want to suppor= t that (though > > > > > I haven't fully processed the back half ot his series, so it's ve= ry possible I'm > > > > > missing something obvious). > > > >=20 > > > > Because I want to reduce the number of cases where we have to fall = back > > > > to non-masterclock mode. Especially the ones which are driven by > > > > *guests* rather than weird choices on the VMM's part. > > >=20 > > > But why though?=C2=A0 What is the harm to the host or guest?=C2=A0 E.= g. does it make it more > > > difficult to accurately migrate the VM?=C2=A0 I'm not opposed to allo= wing master-clock > > > mode with diverging offsets, just trying to understand why it matters= . > >=20 > > Accurate migration without masterclock is hard, yes. The > > KVM_SET_CLOCK_GUEST thing relies on it (because the principle is that > > you get the *TSC* right, then the KVM clock is just a fixed > > mathematical function of that). > >=20 > > That *shouldn't* be difficult with offsets between vCPUs. Just use the > > TSC of vCPU0 as the reference for KVM_SET_CLOCK_GUEST and let the > > others just have their offset from that. >=20 > Yeah, my only (quite mild) concern is that we would introduce fragility b= y adding > yet another variable that needs to be accounted for, but AFAICT it's lite= rally > just the tsc_timestamp in the shared data structure that consumes the per= -vCPU > offset. Actually, why are KVM_{G,S}ET_CLOCK_GUEST vCPU-scoped? Per the documentati= on, the API "Sets the KVM clock (for the whole VM) in terms of the vCPU TSC". = If the APIs are VM-scoped instead of vCPU-scoped, then KVM can simply save/res= tore what's in the per-VM masterclock state, no? That would also help address my concerns about sanity checking the TSC freq= uency against the kvmclock frequency, as the APIs are much more blatantly about s= aving and restoring masterclock state. For whatever reason, it feels more natura= l for me to say that KVM_SET_CLOCK_GUEST will fail if the target frequency doesn'= t (fuzzily?) match the frequency at which the masterclock is already configur= ed. Probably because use_master_clock directly gates that information? Whereas= the vCPU's frequency is independently configured but obviously influences maste= rclock mode. From xen-devel-bounces@lists.xenproject.org Tue Aug 11 14:36:08 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 14:36:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388297.1629505 (Exim 4.92) (envelope-from ) id 1wtnaI-0004pz-WD; Tue, 11 Aug 2026 14:36:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388297.1629505; Tue, 11 Aug 2026 14:36:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wtnaI-0004ps-Tb; Tue, 11 Aug 2026 14:36:06 +0000 Received: by outflank-mailman (input) for mailman id 1388297; Tue, 11 Aug 2026 14:36:06 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wtnaI-0004pm-3m for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 14:36:06 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wtnaH-00CMhI-GD for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 16:36:05 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b3355-bab6-0a2a0a5309dd-0a2a4501afb8-0 for ; Tue, 11 Aug 2026 16:36:05 +0200 Received: from [209.85.128.52] (helo=mail-wm1-f52.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b3355-5984-0a2a45010019-d1558034dd4e-3 for ; Tue, 11 Aug 2026 16:36:05 +0200 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49802c418b5so31019625e9.1 for ; Tue, 11 Aug 2026 07:36:05 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-144-234.play-internet.pl. [109.243.144.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49977e86b55sm78792885e9.4.2026.08.11.07.36.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 07:36:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Content-Language:References:Cc:To:Subject:From:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786458965; x=1787063765; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NweeeWU/d1SpjWCrPg1YLxWa7FbW0YsPsbukU44y9t4=; b=jkRO52vSpU58kPCjQ6Zk9quN9m7Q8TPgX/ucJRpXhwtT1qIFOH6Pi9SdCqSRJH27Iu Y2eD8LItGQYaExP3Rj1WtxubNrcaRIIadOH/C3JQhQWknJyjQlYG921K10/ked+sqVKb mWtMXpWp9VcGtN9wRjBfcMapNDujceLpHc+EGLADaID/lKH/7uvMEQOj8K+OIhCQOtz3 tZqm0l9xCBVRI4atU6hoskuTsQZ//xY+1FM/XSI9kXNYV/vQ6cpkXQ8lGNiEfckhKlBa dKqyS6euACRP88yja+ZsWw6OIpmS8o+OFHAsLQK0EDdUtRJ9wujatpq1FZLXl8Yn/3s/ H7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786458965; x=1787063765; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NweeeWU/d1SpjWCrPg1YLxWa7FbW0YsPsbukU44y9t4=; b=EVf2HOKv9Y+hyXENpxrnlEBWIxD6zCd8peffTfq1OJ0pf3ApVlLHBZI2UHHoKymAZQ ntMFAcWVvNIQpYd0sFYM3X1Xgvib/N/zdd0LBXuPx4IdLLCWr6Hby1/uGRPKQGEPzCzJ jajAZ/z8rXcNiQwly90VolrwgCm16aPPLCdT9TJLu0WFaDe/ksJujzZkMMImNWAZStH/ Huj4hpCDZChYQ1/bJVQcM1nJd8VGX4ldGXjwhEmRc7vlTfxhMKg4w4D2Kn1e9+95hsXD L8pJ1YdMEjd9xqbDKkcqBWQKbvSVkDHX8VHGGlp4lsDrYSmxfCtbr9wASDc2bOFhb0ls JC+g== X-Forwarded-Encrypted: i=1; AHgh+RqMH8eWwhnpjvAFlzW4iR0gFGOAWx/aSjNfBuSicXHxxqcnk/NzCfH+jte7rY7HHfN2fNMQNOhO+c0=@lists.xenproject.org X-Gm-Message-State: AOJu0Yx3DpRKePAzr6eg2se7qcRAE/+drYvDRTstXBmSaOrDt3FO8Fy7 XSle6IoMkvZkVAwgoNo9Ut2b34eV65d6WuQAf3qu0GeZHzz9eu66ENB4 X-Gm-Gg: AR+sD11M5YLSIu23KyAAdr7N+9mkuFosyiRVvZbQjyxsylKP1CYTayP99mrC4wEC+B8 gBTWHUWCU/sr+BDbMYc91IRL1kP1MOkMGPfex3NQ8bXTJ961fv3MKWzQr2ZpJMANPiFr1Uox6vA RwBfBp2KpZ0EH4eeCjsq1haitI6dYMtP97tcnSrYOqIfpuk4J2ZknaCDiyzUccGoNDBrDFgeXaM M0Rh6ZbKwVEQekvqCCybjh4ncj65aqqx9qE54NkkMYH6WhMHi7hqwUMGwaDQfE7PR72c2LP97u/ wNyOeVEnpcU6jwDwzPnGfeRNE4SHQ+4WIAPYBwtuJ8KUBs26RRWMfOsvkoL2/SxmrrLRt8CXf9M /0LMgBhBZWoCR2+NgftZJ1Bjb7aaKsyuL5rwSd0pisnrU5bZVnHi8wWG+tjHBk+5NJv3Kkq6aXs qdu9WfYZ/984WCPOat0OKw3hd4ViUNxOQiOXdXhr13B7s2MSH2LPA7WyuJZ969e2AlBY0xDJgZh WpX4/A/QTJoUSz2MOFCrZsU1aNzU8Q5mAl4US969cA= X-Received: by 2002:a05:600c:45d2:b0:493:a438:7f98 with SMTP id 5b1f17b1804b1-49978485532mr59518495e9.18.1786458964685; Tue, 11 Aug 2026 07:36:04 -0700 (PDT) Message-ID: <2187839d-fef8-4d51-8b98-8c0fb26a9569@gmail.com> Date: Tue, 11 Aug 2026 16:36:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Oleksii Kurochko Subject: Re: [PATCH v1 05/17] xen/riscv: implement virtual APLIC MMIO emulation To: Baptiste Le Duc Cc: Jan Beulich , Romain Caritey , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <5571644f1d3a4277dc95fe85099563a145d1d935.1784560663.git.oleksii.kurochko@gmail.com> <57793423-aadd-4786-90fd-2923925b766d@suse.com> <4c62661a-f944-4806-824a-e74bcbaea3df@gmail.com> <1786440103.8631fc262581453bbf619ec5b2062170.19ff020b5cf000c4f3@vates.tech> Content-Language: en-US In-Reply-To: <1786440103.8631fc262581453bbf619ec5b2062170.19ff020b5cf000c4f3@vates.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-d62444/1786458965-C475B757-96AE7052/10/73395122804 X-purgate-type: spam X-purgate-size: 7789 On 8/11/26 11:21 AM, Baptiste Le Duc wrote: > On 2026-08-07 18:08:21+02:00, Oleksii Kurochko wrote: >> On 8/6/26 4:28 PM, Jan Beulich wrote: >> >>> On 20.07.2026 18:02, Oleksii Kurochko wrote: >>> >>> For this tag to have any meaning, it should move ahead of the --- above; >>> the explanations ... >>> >>> >>> ... here rather explain the restriction on the R-b, not its odd placement. >>> >>> >>> As this looks to be recurring - please get versioning of your series right. >>> The series is supposedly v1, but here you give the impression of it being >>> v3. If there really was an earlier v2 posting, why isn't the entire series >>> here v3? >> >> It is v3 before before it was a part of another patch series connected >> to dom0less config enablement. >> >> Would it be better to just write in "Change in v3" that it is moved from >> another patch series + link to that patch series? Or it will be enough >> just to drop "Changes in v2 and v1" and just start from v1? >> >>> PLease can you, before submitting, self-review your patches? I'm really >>> getting tired of having to repeatedly point out basic style issues, like >>> the overlong line here. >> >> Sorry for that, I will write an extra checker for such cases to not miss >> them. >> >>> It extends to the other local variables here, but I'll use these two to >>> try to make my point: I'm struggling to associate the names with the >>> values they are set to. Likely "hxw" is an abbreviation of hart index >>> width, but (a) what's the leading 'l' then and (b) why is there no 'g' >>> in "hhxw"? By using hard to grasp names, you make it hard to actually >>> understand the subsequent expressions, in particular ... >> >> The names it taken directly from AIA spec: >> >> The use of this value and fields HHXS (High Hart Index Shift), LHXS (Low >> Hart Index Shift), HHXW (High Hart Index Width), and LHXW (Low Hart >> Index Width) for determining target addresses for MSIs is described >> later, in Section 4.9.1. >> >> The AIA specification interprets the machine-level hart index as a >> combination of the **group index** (`g`) and the **hart index within the >> group** (`h`), according to the following formulas: >> >> ``` >> (1) g = (machine-level hart index >> LHXW) & (2^HHXW − 1) >> (2) h = machine-level hart index & (2^LHXW − 1) >> ``` >> >> (In our case, the machine-level hart index is equal to `mhartid`, i.e. >> the hart index.) > Therefore, if I understand correclty, if we take the Hart Index as > defined in the AIA spec, we should have: > Hart Index = (g << LHXW) | h > Is it correct? Yes. But note that in the current version of aplic_hart_field(), hart_id is passed directly, so there is no need to extract h as described in the AIA specification. We only need to concatenate it with the group index that we have already extracted. This is partly because aplic_hart_field() uses only .base_addr, which does not contain hart_index. If we want to follow the AIA specification fully, using its terminology, the code should look something like: static unsigned long aplic_hart_field(unsigned int cpu) { const struct imsic_config *imsic = imsic_get_config(); const struct imsic_msi *msi = &imsic->msi[cpu]; unsigned int lhxs = imsic->guest_index_bits; unsigned int lhxw = imsic->hart_index_bits; unsigned int hhxw = imsic->group_index_bits; unsigned int hhxs = imsic->group_index_shift - APLIC_xMSICFGADDR_PPN_SHIFT * 2; /* * msi->base_addr is the base of the MMIO regset this CPU's interrupt * files live in, and one regset can cover several harts; msi->offset * selects this CPU's block inside it. The hart index bits are part of * that offset, so both indexes have to be derived from the full address. */ paddr_t target_addr = msi->base_addr + msi->offset; unsigned long tppn = target_addr >> APLIC_xMSICFGADDR_PPN_SHIFT; unsigned long group_index = (tppn >> APLIC_xMSICFGADDR_PPN_HHX_SHIFT(hhxs)) & APLIC_xMSICFGADDR_PPN_HHX_MASK(hhxw); unsigned long hart_index = (tppn >> APLIC_xMSICFGADDR_PPN_LHX_SHIFT(lhxs)) & APLIC_xMSICFGADDR_PPN_LHX_MASK(lhxw); return (group_index << lhxw) | hart_index; } (note that during writing that I found an issue, it should be really passed Xen cpu id, not hartid as msi[] is iterated through Xen cpu id so I've taken that into account when wrote an implementation mentioned above) Generally I think I am okay with both version of how to get hart_index (or pass it by an argument or extract it). >> >> For systems that use IMSIC groups, the IMSIC address layout is defined >> by the following parameters: >> >> * `lhxw` (Low Hart Index Width, or *k*): the number of bits used for the >> hart number within a group. >> * `hhxw` (High Hart Index Width, or *j*): the number of bits used for >> the group number. > Is group number appelation equivalent to group index? > > I think with if what I wrote above is correct, the proper definition for > `hhxw` and `hhxs` should be: > * `hhxw` (High Hart Index Width, or *j*): the number of bits used for > the `Hart Index` field within the physical address. >> * `hhxs` (High Hart Index Shift): the bit offset of the combined >> hart/group index field within the physical address. > * `hhxs` (High Hart Index Shift): the bit offset of the `Hart Index` > field within the physical address. >> To extract the group index, we first shift the address by `hhxs` so that >> the group index bits are aligned, and then apply a mask derived from >> `hhxw` to isolate those bits. >> >> The hardware performs the same operation to extract the hart index from >> the MSI address. However, in our case we already know which hart should >> receive the interrupt (`hartid`), so there is no need to extract the >> hart index from the base address. We only need to recover the group >> index and combine it with `hartid` to construct the value expected by >> the `target` register. > > Why don't we direclty extract the Hart Index as target directly needs it > as explained in the 4.5.16.2 point of the AIA spec: > target[31:18] = Hart Index > target[17:12] = Guest Index > target[10:0] = EEID > It'd be easier as we just have to do shift from HHXS and apply HHXW. From IMSIC's DT-binding description we have: XLEN-1 > (HART Index MSB) 12 0 | | | | ------------------------------------------------------------- |xxxxxx|Group Index|xxxxxxxxxxx|HART Index|Guest Index| 0 | ------------------------------------------------------------- If you see there is a set of "xxxxxx" between HART and Group Indexes that is the reason why we have to extract HART and Group Index separately as when h/w will work with target register it doesn't know about "xxxxx" at all so from h/w point of view target's register hart field looks like |Group Index|Hart Index|. In other words, h/w will do the following with TARGET's hart index field: group_idx = hart_idx >> lhxw; hart_idx &= APLIC_xMSICFGADDR_PPN_LHX_MASK(lhxw); and then embed group_idx and hart_idx into the structure above. Does it make sense? > > I will try to draw some schema to make the AIA spec more explicit. Maybe > it could be part of this series, I don't know what is the xen policy > about diagram and stuff like that. Do you know more about that? Unfortunately, no, I don't. > In order > to not do a job with no needed at all. > IMO, it is enough only AIA spec here to understand. At least, it is clear to me. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 11 15:05:43 2026 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 11 Aug 2026 15:05:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.1388307.1629516 (Exim 4.92) (envelope-from ) id 1wto2g-0000yK-5H; Tue, 11 Aug 2026 15:05:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1388307.1629516; Tue, 11 Aug 2026 15:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wto2g-0000yD-1k; Tue, 11 Aug 2026 15:05:26 +0000 Received: by outflank-mailman (input) for mailman id 1388307; Tue, 11 Aug 2026 15:05:25 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wto2c-0000y7-VI for xen-devel@lists.xenproject.org; Tue, 11 Aug 2026 15:05:25 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wto2b-000Vaj-R2; Tue, 11 Aug 2026 17:05:21 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a7b3a28-bab6-0a2a0a5309dd-0a2a45098544-18 for ; Tue, 11 Aug 2026 17:05:20 +0200 Received: from [90.155.50.34] (helo=casper.infradead.org) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a7b3a30-be1a-0a2a45090019-5a9b3222da72-3 for ; Tue, 11 Aug 2026 17:05:20 +0200 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=u09cd745991455d.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wto2P-00000000avv-0iNZ; Tue, 11 Aug 2026 15:05:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=casper.20170209 header.d=infradead.org header.i="@infradead.org" header.h="MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=C6rkUIL+dM1UFpFpZSm+dPCwsMFKdFomwHvt9iy8cEo=; b=oVq/9ftDEOCy0zT21RIRhInWyA xTR9PHbbOmnMF5nK1StXUz7O6WRpcslQPreuEUiQYa1xoJBjIMfSXBEn5zw7slp8C2icWp9oJcoUT 3S5wy5GI3r+1zGmQjWyCPh/EpD5Oz3ueAuyNDLD/bMrNuXDjK+exsf+WUkQNvMGO8ZjWJSvk9n6xo OYRlQ7sHKvNVlu5Vud/NojZJibnz1tL6iby4p0WvwWSSxjx+d4emimsCM57wG1R4cK3BU+xcQY0WZ CFWq4sB44UaATIUOZYxJk7m54tmLacdFSZ4aEUikXWc1CDYehcGC6QBoWNQ7Rw2yRPLcfzYf7/99C IVStKiMg==; Message-ID: Subject: Re: [PATCH v7 17/36] KVM: x86: Allow KVM master clock mode when TSCs are offset from each other From: David Woodhouse To: Sean Christopherson Cc: Paolo Bonzini , Jonathan Corbet , Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , Juergen Gross , Boris Ostrovsky , Paul Durrant , Jonathan Cameron , Sascha Bischoff , Marc Zyngier , Joey Gouly , Jack Allister , Dongli Zhang , joe.jin@oracle.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kselftest@vger.kernel.org Date: Tue, 11 Aug 2026 16:05:03 +0100 In-Reply-To: References: <20260728144954.355376-1-dwmw2@infradead.org> <20260728144954.355376-18-dwmw2@infradead.org> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-F6kD8Qx0GpTaOeFjxO+8" User-Agent: Evolution 3.60.3-0ubuntu1~ppa9~24.04 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-purgate-ID: tlsNG-bad1c0/1786460720-BC2F4034-CA10312C/0/0 X-purgate-type: clean X-purgate-size: 12481 --=-F6kD8Qx0GpTaOeFjxO+8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2026-08-11 at 07:33 -0700, Sean Christopherson wrote: >=20 > Actually, why are KVM_{G,S}ET_CLOCK_GUEST vCPU-scoped?=C2=A0 Per the docu= mentation, > the API "Sets the KVM clock (for the whole VM) in terms of the vCPU TSC".= =C2=A0 If > the APIs are VM-scoped instead of vCPU-scoped, then KVM can simply save/r= estore > what's in the per-VM masterclock state, no? They're vCPU-scoped because they need to be tied to a guest TSC (on live migration, neither ka->master_cycle_now nor ka->master_kernel_ns are useful =E2=80=94 those are the "per-VM masterclock state"). Theoretically, guest TSCs can be different on each vCPU (different offset, different *rate* even. Not that we allow KVM_[GS]ET_CLOCK_GUEST at different rates, I concede). So they operate in the context of a given vCPU, and *its* TSC. And I think I'm going to defend that 'theoretical they can be different', because I *would* like to eliminate the ways that a *guest* can force non-masterclock mode, and that does mean allowing the offset- TSC case. FWIW in my local tree I've just extended the pvclock_migration_test to test precisely the thing you were concerned about: three vCPUs with divergent TSC offsets, migrated by setting each vCPU's TSC and then invoking KVM_SET_CLOCK_GUEST once, through vCPU0. Masterclock stays active, TSC_STABLE_BIT is correctly clear, and all three vCPUs' pvclocks (and KVM_GET_CLOCK) agree to within a nanosecond afterwards. I'll include that in the next spin. > That would also help address my concerns about sanity checking the TSC fr= equency > against the kvmclock frequency, as the APIs are much more blatantly about= saving > and restoring masterclock state.=C2=A0 For whatever reason, it feels more= natural for > me to say that KVM_SET_CLOCK_GUEST will fail if the target frequency does= n't > (fuzzily?) match the frequency at which the masterclock is already config= ured. > Probably because use_master_clock directly gates that information?=C2=A0 = Whereas the > vCPU's frequency is independently configured but obviously influences mas= terclock > mode. I am perfectly happy to say that the *existing* check as I have coded it, is matching against the frequency at which the masterclock is configured. Because we can't *get* there if the guest is not in masterclock mode, and it can't be in masterclock mode unless all its vCPUs are running at the same rate, which *is* the master clock rate. :) I guess I could even concede to change the actual code rather than just the comment... (untested) Still needs the *offset* of the vCPU though. --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3595,15 +3595,15 @@ static int kvm_vcpu_ioctl_set_clock_guest(struct kv= m_vcpu *v, void __user *argp if (kvm_caps.has_tsc_control) curr_tsc_hz =3D kvm_scale_tsc(curr_tsc_hz, - v->arch.l1_tsc_scaling_ratio); + ka->master_tsc_scaling_ratio); /* * The mul/shift in the provided pvclock structure encode the guest * TSC frequency at which it was generated. Sanity-check that it is - * consistent with this vCPU's effective TSC frequency, allowing a - * discrepancy of 1 kHz either way since independently calibrated - * hosts will not measure precisely the same value even for the - * same nominal frequency. + * consistent with the frequency at which the masterclock is + * configured, allowing a discrepancy of 1 kHz either way since + * independently calibrated hosts will not measure precisely the + * same value even for the same nominal frequency. */ if (user_tsc_hz < curr_tsc_hz - 1000 || user_tsc_hz > curr_tsc_hz + 1000) { --=-F6kD8Qx0GpTaOeFjxO+8 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCE8Ew ggWvMIIEl6ADAgECAhANkOKMSmGXhF5eMl0rsRhvMA0GCSqGSIb3DQEBDAUAMGUxCzAJBgNVBAYT AlVTMRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxGTAXBgNVBAsTEHd3dy5kaWdpY2VydC5jb20xJDAi BgNVBAMTG0RpZ2lDZXJ0IEFzc3VyZWQgSUQgUm9vdCBHMjAeFw0yNDAzMTMwMDAwMDBaFw0zNDAz MTIyMzU5NTlaMGIxCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UE AxMxRGlnaUNlcnQgQXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTCCAiIw DQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAOfSIeC0vv1xPQ+dgSxbIIrkaru6skAWJYaGFzmv q4Kq+2wU2jxhcWlJg/JeP5jEkq/LM3pn5aaLao79j+XRmS7J1ZpJKUODJVoM4s9MQJhTMvo4qS5Z S64g6QR7Obkz3I1Lr3aWeSBmDDEyzue+NKtuWZ1Cxy3RdXo/w5HgRc3l2AercOM3Gt1XonTzEtTb Z/Hwc0Sn9Gz8RmGRK6Ka4hVDl8q/2l110KaV233Kh5etP0csXS8MIMdVRfRu3sc5hp13DG7lCKzK 72a2GEpI8Wpl26G6I1/LMzz/98T+FqjTqxsdquk7Cj7m2vKGLW1BorpQH7WFGPdJQXJe1hfbfiZA CcVdCtl4nAacFacmsiArZBfX7AQGL7isvHUwwYFEtcApyGW4p2Lt+t8nvU0CANA6BHOpOz1xOP8W mAESbUriIjyuTUf3fJ9oDNCurVqhASMJCDaWI3lYX/QAoiAzt6akqbbZxo2ujW7mGGqc0KxqE2cs h2T79v7pC8aUtHBfwNrTR19GnZVxE0eQ7ViIQhR6mpSaUQFA9sG+cmD2G8TnCgYsLa0q8De6F61a CBevQGHNzrbZ3JAMneveYg/Jy1XxQHDRcvrMfWKe0jjcWbdKYlaGVPm5V1ILwYz7Yv5ewo3NUrxI GJiywe9qPhuJSDZs7VehTuI0FxGIsgKzVjgbAgMBAAGjggFcMIIBWDASBgNVHRMBAf8ECDAGAQH/ AgEAMB0GA1UdDgQWBBT3m6JO05fF9DQPQw6Bhc6RkzKv+TAfBgNVHSMEGDAWgBTOw0q5mVXyuNtg v6l+vVa1lzan1jAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MHkGCCsGAQUFBwEBBG0wazAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuZGlnaWNlcnQuY29tMEMG CCsGAQUFBzAChjdodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkSURS b290RzIuY3J0MEUGA1UdHwQ+MDwwOqA4oDaGNGh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdp Q2VydEFzc3VyZWRJRFJvb3RHMi5jcmwwEQYDVR0gBAowCDAGBgRVHSAAMA0GCSqGSIb3DQEBDAUA A4IBAQA+b8Uw53sDspdZgukU+qzLyyHkcjlxGGhHlP+zrmDLKm1wEFvCRS2pili3Hy67i8N4N5NU vw5Rg6kv3lxb9S9Rktxk43k+tvm68pl7OxQE55ZjVY87P0lUPGwEqOOwLLyH02ZQcsfq5p5LrOH9 0JvmvZ1yy73HS+VpDAqOlytE0NSvTIRqFFkKQGQwfjvtql9YflujuNNvJztjBaHKYZsnNSg+J38o jYq4TP3pSg3UdVH0PncVjPQyqxC9xef5Xae92Kbkzol3x7Nel3A1bwAkalrDMspvTHvey6LfiBks FIqviTnoy7fgjaRAJgHS+RXx/cmuRd3rUAclSVVrYu8RMIIHAzCCBOugAwIBAgIQAzUotrsybJHx HTjKOIVdIDANBgkqhkiG9w0BAQsFADBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQs IEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQg MjAyNCBDQTEwHhcNMjYwNzE4MDAwMDAwWhcNMjgwMTA0MjM1OTU5WjAeMRwwGgYDVQQDDBNkd213 MkBpbmZyYWRlYWQub3JnMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEA2pYux73kdbYX sWF8f1u6DJP91qcqaZetsyfPkZk0B+MmXmAEv0kVes5n15V2mbDThOnpoPFly0UugQO9JYqLfrtD tKD5yL58fgrDB9Dw+LQikgrHafl6YSCds5AvUu/8hw2J6noKrcOLJpKlKn9Fl/4IB9Q3JIdLx5aa EtTqMalIPqHFOlgrJ7s+aua8xbB8YQ9ahqYBXWRJNv3P/2b1DYtdrz1oqZPE3CcB8Pc6Gf2a1Tcm 6TAgtEx7Cf1BFcrsrMz7TWHmGQITieNb2r9UYWSc2Gp+GtYFNJCgT0JJXKUBIauPMKBLteYrL8Fo ff/uY44dC/mDWjdCP/5x0qelPQjlBvWdHL5zvBTOj06rJ0m3HNI/hnIcDh0Qu2j9reb9rLVcdym6 bWmBM4uDEB8Zv9Ph0KTBFSy1IosyakuD1j1Os30EzjGfbi0EUXIvnOcYbTBAbM5UAzrxEHMhBvoX Pvnx+OyvjJmc9tWxTX6AcSz+m40esbT17URBeZS18afgieiikm5TynlUYP1LciR3hSgGVzvGXnKO 02VDFR5itGWdRKZ2W5wIShNfWfhSa0D0K5UdIDt5Qc7sjzwK1Yb1sY5Tu0uA5mhIS82q1ov83uxB sFkriNnhGv/M1NCDVLBiOMsHu73qUM+yKmgKLwF9Hfn9WI25glbAMI4S5r3hYzcCAwEAAaOCAfcw ggHzMB8GA1UdIwQYMBaAFPebok7Tl8X0NA9DDoGFzpGTMq/5MB0GA1UdDgQWBBRcYhqbcGzn1jrT JOZaB8O7qllDpzAwBgNVHREEKTAngRNkd213MkBpbmZyYWRlYWQub3JngRBkYXZpZEB3b29kaG91 LnNlMBQGA1UdIAQNMAswCQYHZ4EMAQUBAjAOBgNVHQ8BAf8EBAMCBeAwHQYDVR0lBBYwFAYIKwYB BQUHAwIGCCsGAQUFBwMEMIGpBgNVHR8EgaEwgZ4wTaBLoEmGR2h0dHA6Ly9jcmwzLmRpZ2ljZXJ0 LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsME2gS6BJ hkdodHRwOi8vY3JsNC5kaWdpY2VydC5jb20vRGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZT SEEzODQyMDI0Q0ExLmNybDCBjQYIKwYBBQUHAQEEgYAwfjAkBggrBgEFBQcwAYYYaHR0cDovL29j c3AuZGlnaWNlcnQuY29tMFYGCCsGAQUFBzAChkpodHRwOi8vY2FjZXJ0cy5kaWdpY2VydC5jb20v RGlnaUNlcnRBc3N1cmVkRzJTTUlNRVJTQTQwOTZTSEEzODQyMDI0Q0ExLmNydDANBgkqhkiG9w0B AQsFAAOCAgEAocabrh1cPd5s3vY5rnlBVQSTc7zs2ZWs67dAIltR+05WELrYClVzzUhMs/LOJPlr EUo45UDDomXq38DxFepaPd9+iNLjXfn33EX/IG44j04lU/oF/Rg9VeQILkYLbCZ/x9wOjNHZc4SN ydY7Dhvf/sT5aBz88u7D5+azZJ7Qf1U57wYseCH1Mt0nDrtr5y19IJ8D9xJJ33RFL6vfpHZBBAQ8 +3RqkKNxLoV2aFvQhxdhjNLDqTv3LjUIdicwPraN7JkxEu7CV2Lka7eRqJgkWL7SK0YmBjGpRafs +icP/ON5RCCKTTb6VlX8eTG2sJJfsFhvJNCCt6xexbWzWtIrfP7NvPBvwBB737AyEGBZkS5aNizT McURJGTv9UKvBh1LF/+tNhYtLvPCN7oecGzhCHht9jcwSkygTo3Y6YlK3QgOu+ncmiBbfeuwlLZ1 LxbYvG6hgNqXv7u6YyADbYajAQJXJ2OQen39pm3Q/AQSyLYG+B8lDglWsM8tYXPlEdrYJcksGK6F nqIX6Bumn43rBooLJdiZp4WmfWdL2pxe+LxRDjprmqu1WprixDxULSTOKJZoqTlugs6y3Bc+if+s gHnBBtz9WQ6MtPHkh7zONDAFIKcBmv8OqPQCx0F3Wv3OEybwMpXx0OsKgK8wLldaX1pXcMuyDgTL Sqs0AV0OHUgwggcDMIIE66ADAgECAhADNSi2uzJskfEdOMo4hV0gMA0GCSqGSIb3DQEBCwUAMGIx CzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5EaWdpQ2VydCwgSW5jLjE6MDgGA1UEAxMxRGlnaUNlcnQg QXNzdXJlZCBHMiBTTUlNRSBSU0E0MDk2IFNIQTM4NCAyMDI0IENBMTAeFw0yNjA3MTgwMDAwMDBa Fw0yODAxMDQyMzU5NTlaMB4xHDAaBgNVBAMME2R3bXcyQGluZnJhZGVhZC5vcmcwggIiMA0GCSqG SIb3DQEBAQUAA4ICDwAwggIKAoICAQDali7HveR1thexYXx/W7oMk/3Wpyppl62zJ8+RmTQH4yZe YAS/SRV6zmfXlXaZsNOE6emg8WXLRS6BA70liot+u0O0oPnIvnx+CsMH0PD4tCKSCsdp+XphIJ2z kC9S7/yHDYnqegqtw4smkqUqf0WX/ggH1Dckh0vHlpoS1OoxqUg+ocU6WCsnuz5q5rzFsHxhD1qG pgFdZEk2/c//ZvUNi12vPWipk8TcJwHw9zoZ/ZrVNybpMCC0THsJ/UEVyuyszPtNYeYZAhOJ41va v1RhZJzYan4a1gU0kKBPQklcpQEhq48woEu15isvwWh9/+5jjh0L+YNaN0I//nHSp6U9COUG9Z0c vnO8FM6PTqsnSbcc0j+GchwOHRC7aP2t5v2stVx3KbptaYEzi4MQHxm/0+HQpMEVLLUiizJqS4PW PU6zfQTOMZ9uLQRRci+c5xhtMEBszlQDOvEQcyEG+hc++fH47K+MmZz21bFNfoBxLP6bjR6xtPXt REF5lLXxp+CJ6KKSblPKeVRg/UtyJHeFKAZXO8Zeco7TZUMVHmK0ZZ1EpnZbnAhKE19Z+FJrQPQr lR0gO3lBzuyPPArVhvWxjlO7S4DmaEhLzarWi/ze7EGwWSuI2eEa/8zU0INUsGI4ywe7vepQz7Iq aAovAX0d+f1YjbmCVsAwjhLmveFjNwIDAQABo4IB9zCCAfMwHwYDVR0jBBgwFoAU95uiTtOXxfQ0 D0MOgYXOkZMyr/kwHQYDVR0OBBYEFFxiGptwbOfWOtMk5loHw7uqWUOnMDAGA1UdEQQpMCeBE2R3 bXcyQGluZnJhZGVhZC5vcmeBEGRhdmlkQHdvb2Rob3Uuc2UwFAYDVR0gBA0wCzAJBgdngQwBBQEC MA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwgakGA1UdHwSB oTCBnjBNoEugSYZHaHR0cDovL2NybDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0QXNzdXJlZEcyU01J TUVSU0E0MDk2U0hBMzg0MjAyNENBMS5jcmwwTaBLoEmGR2h0dHA6Ly9jcmw0LmRpZ2ljZXJ0LmNv bS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNBNDA5NlNIQTM4NDIwMjRDQTEuY3JsMIGNBggrBgEF BQcBAQSBgDB+MCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5jb20wVgYIKwYBBQUH MAKGSmh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydEFzc3VyZWRHMlNNSU1FUlNB NDA5NlNIQTM4NDIwMjRDQTEuY3J0MA0GCSqGSIb3DQEBCwUAA4ICAQChxpuuHVw93mze9jmueUFV BJNzvOzZlazrt0AiW1H7TlYQutgKVXPNSEyz8s4k+WsRSjjlQMOiZerfwPEV6lo9336I0uNd+ffc Rf8gbjiPTiVT+gX9GD1V5AguRgtsJn/H3A6M0dlzhI3J1jsOG9/+xPloHPzy7sPn5rNkntB/VTnv Bix4IfUy3ScOu2vnLX0gnwP3EknfdEUvq9+kdkEEBDz7dGqQo3EuhXZoW9CHF2GM0sOpO/cuNQh2 JzA+to3smTES7sJXYuRrt5GomCRYvtIrRiYGMalFp+z6Jw/843lEIIpNNvpWVfx5Mbawkl+wWG8k 0IK3rF7FtbNa0it8/s288G/AEHvfsDIQYFmRLlo2LNMxxREkZO/1Qq8GHUsX/602Fi0u88I3uh5w bOEIeG32NzBKTKBOjdjpiUrdCA676dyaIFt967CUtnUvFti8bqGA2pe/u7pjIANthqMBAlcnY5B6 ff2mbdD8BBLItgb4HyUOCVawzy1hc+UR2tglySwYroWeohfoG6afjesGigsl2JmnhaZ9Z0vanF74 vFEOOmuaq7VamuLEPFQtJM4olmipOW6CzrLcFz6J/6yAecEG3P1ZDoy08eSHvM40MAUgpwGa/w6o 9ALHQXda/c4TJvAylfHQ6wqArzAuV1pfWldwy7IOBMtKqzQBXQ4dSDGCBCAwggQcAgEBMHYwYjEL MAkGA1UEBhMCVVMxFzAVBgNVBAoTDkRpZ2lDZXJ0LCBJbmMuMTowOAYDVQQDEzFEaWdpQ2VydCBB c3N1cmVkIEcyIFNNSU1FIFJTQTQwOTYgU0hBMzg0IDIwMjQgQ0ExAhADNSi2uzJskfEdOMo4hV0g MA0GCWCGSAFlAwQCAQUAoIIBezAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yNjA4MTExNTA1MDNaMC8GCSqGSIb3DQEJBDEiBCDFbSyovApCNUfaxhwvqCaJrltHNSYe jCXlvMu4NV8iATCBhQYJKwYBBAGCNxAEMXgwdjBiMQswCQYDVQQGEwJVUzEXMBUGA1UEChMORGln aUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFzc3VyZWQgRzIgU01JTUUgUlNBNDA5NiBT SEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAwgYcGCyqGSIb3DQEJEAILMXigdjBiMQsw CQYDVQQGEwJVUzEXMBUGA1UEChMORGlnaUNlcnQsIEluYy4xOjA4BgNVBAMTMURpZ2lDZXJ0IEFz c3VyZWQgRzIgU01JTUUgUlNBNDA5NiBTSEEzODQgMjAyNCBDQTECEAM1KLa7MmyR8R04yjiFXSAw DQYJKoZIhvcNAQEBBQAEggIAYrlfhsRcAyFN06G/q2KrfKFrEZEHEpE1+LkSLuzFSfXqkKPU1M/g HxQYjzaV/xXqt2Bsua58UrT3eIVpE3hRx8JhO1sxyG+E1qWnZ6t6O+9CtHlljcaqQ2VjAoWMOWgH ZJy8nfX6Fjrf+mDwJImu5B9tWpJNrIyHw6OL9wOJTbDIY6tYBwHHLnSeYYdhz7CLeW6dI0B1Lcx8 LS+te0bQKqSl9JK44er9iNEmdBTD5DtjY5PhaNJLKN9Jkm9KZwnvsqQWisLg/2Y7Mf49BadI/QiE wQOZsdksfhfJop5ixidC1b8XGLHJXNMan1sbyUq0YpUUHqAvGfQXDpJD9sD4GJkW5v/Y/8I9Qqce UxBqhQJ+6fyfZx0bNvC8cUKQQpZIgNgqBrMwAsWRM8roga5kfd5RHKux11jmP5xspBO5KE9NpA2C D8EFh2kLF8IuqTDvUMnRq3dPBSjhAmmbdjy7zgf5zMx/jTcXSfrS/lClj5Qf0ccFAhzPgoimNEEk br/ofV+rlkJyv177z8AKi4Iqu8j3RrsoM1WTTrFAnmSod3z5YjodaFyYgLDbaqzPMxzbYI+Irz84 l3kdCmolUpt5y23AY19r72axX4WAmUo1ERCh+yt5d9FdSpUIiOV4OcCmpWMuFURA6so8VHXGXqnr h4FPTROPNaArNi9Wm/TpNrUAAAAAAAA= --=-F6kD8Qx0GpTaOeFjxO+8--