Re: [Minios-devel] [PATCH ARM v9 1/3] mini-os: fix compiling with debug=n

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-06-25 at 14:48 +0100, Thomas Leonard wrote:
> Without -fno-tree-loop-distribute-patterns, gcc -O3 recognises that our
> "memset" is doing a memset operation and tries to make it call the
> standard "memset", creating a loop.

Isn't this what -nostdlib and such like are for?

In any case if we are to go down this route I think we'd be better off
applying it only to lib/string.c or even better just to the memset
function, if there is a way to do that.

> 
> Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>
> ---
>  minios.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/minios.mk b/minios.mk
> index e042027..41023e9 100644
> --- a/minios.mk
> +++ b/minios.mk
> @@ -23,7 +23,7 @@ DEF_CFLAGS += -g
>  #DEF_CFLAGS += -DGNT_DEBUG
>  #DEF_CFLAGS += -DGNTMAP_DEBUG
>  else
> -DEF_CFLAGS += -O3
> +DEF_CFLAGS += -O3 $(call cc-option,$(CC),-fno-tree-loop-distribute-patterns,)
>  endif
>  
>  # Make the headers define our internal stuff



_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel