Re: [Minios-devel] [PATCH ARM v9 3/3] mini-os: arm: build system

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-02 at 02:21 +0200, Samuel Thibault wrote:
> Thomas Leonard, le Thu 25 Jun 2015 14:48:09 +0100, a Ãcrit :
> > Based on an initial patch by Karim Raslan.
> > 
> > This activates the ARM code added in the previous patches. On ARM,
> > Mini-OS will boot and display some output on the console. Tested with:
> > 
> > make XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- \
> >     CONFIG_TEST=y CONFIG_START_NETWORK=n CONFIG_BLKFRONT=n \
> >     CONFIG_NETFRONT=n CONFIG_FBFRONT=n CONFIG_KBDFRONT=n \
> >     CONFIG_CONSFRONT=n CONFIG_XC=n -j4
> > 
> > The memmove implementation is from FreeBSD's
> > contrib/ldns/compat/memmove.c (r246827).
> 
> Then it should have its own copyright header copied from there, not just
> refer to COPYING.  Apart from that it looks fine.

I remember discussing before but not conclusion: Is the 3c BSD license
used here OK? So I don't forget the answer again: The 3rd clause is the
"Neither the name of $NAME nor the names of its" one, which already
appears in one or two files, so other than a new $NAME there is no
difference to the licensing. If you could include something lie that
snippet next time either in the main commit message or in an
aide-memoire after the first "---" I'd appreciate it so I don't have to
engage my brain next time.

NB: The "3rd" clause is actually numbered "4." in those existing
instances, because the are code which was relicensed from the old 4
clause dropping what is clause 3 in that context. In case anyone repeats
my grep and things we've some 4 clause BSD in there.

Speaking of which: Would someone mind doing a sweep and updating COPYING
to actually reflect all the licenses? Currently it just has a 2cBSD from
Citrix and a warning about the GPL'd components...

Ian.


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel