Re: [Minios-devel] [PATCH ARM v9 2/3] mini-os: arm: interrupt controller

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-06-25 at 14:48 +0100, Thomas Leonard wrote:

This patch looks good to me, but this:

[...]
> +//FIXME Get event_irq from dt
> +#define EVENTS_IRQ 31
> +#define VIRTUALTIMER_IRQ 27

I think deserves a prominent comment in at least the commit message, if
not somewhere like the README, since it means that binaries built with
this mini-os are not guaranteed to be portable to other versions of Xen
on ARM. You know this but other potential users of this code might take
umbrage when they find this out the hard way.

Ian.


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel