Re: [Minios-devel] [Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sat, Mar 26, 2016 at 01:53:28PM -0700, Sarah Newman wrote:
> On 03/25/2016 11:33 AM, Samuel Thibault wrote:
> >> On Wed, Mar 23, 2016 at 02:26:51PM -0700, Sarah Newman wrote:
> >>> 7c8f3483 introduced a break within a loop in netfront.c such that
> >>> cons and nr_consumed were no longer always being incremented. The
> >>> offset at cons will be processed multiple times with the break in
> >>> place.
> >>>
> >>> Remove the break and re-add "some !=0" in the loop for HAVE_LIBC.
> > 
> > Mmm, right.
> > 
> > That ifdef makes things even more difficult to understand then. That
> > however makes me think: how about the attached patch, which actually
> > simplifies the rest.
> > 
> > Thanks!
> > Samuel
> > 
> 
> Does anything else need to happen for this patch to be used with xen master 
> and stable 4.6?
> 

I take it that you and Samuel have reached an agreement on how to
proceed?

Can either of you submit a proper final patch to xen-devel and
minios-devel and CC me please? I will see to its backport.

Note that we are near 4.7 freeze at the moment, so it might take some
time for me to get to it. But I don't think I will miss it because I
want the patch to be in for 4.7.

Wei.

> Thanks, Sarah

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel