Re: [Minios-devel] [PATCH 05/22] mini-os: add boot code for HVMlite support

[Juergen Gross <jgross@xxxxxxxx>]

On 23/08/16 22:51, Samuel Thibault wrote:
> Hello,
> 
> It looks good, there is just:
> 
> Juergen Gross, on Tue 23 Aug 2016 17:15:51 +0200, wrote:
>> +        .macro PTES prot, addr, incr, idx, end
> 
> Please document what prot, addr, incr, idx, end represent precisely.

Okay.

> 
>> +        .ifgt \end-\idx-32
>> +        PTES \prot, \addr, \incr, \idx, "(\idx+32)"
>> +        PTES \prot, "(\addr+32*\incr)", \incr, "(\idx+32)", \end
>> +        .else
>> +        PTE(\addr + \prot)
>> +        .if \end-\idx-1
>> +        PTES \prot, "(\addr+\incr)", \incr, "(\idx+1)", \end
>> +        .endif
>> +        .endif
>> +        .endm
> 
>> diff --git a/include/x86/desc.h b/include/x86/desc.h
>> new file mode 100644
>> index 0000000..d450557
>> --- /dev/null
>> +++ b/include/x86/desc.h
>> @@ -0,0 +1,366 @@
>> +/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
>> + *
>> + * (C) 2016 - Juergen Gross, SUSE Linux GmbH
> 
> Was this whole file imported from somewhere, or written from scratch?

It is a modified variant of a similar file in:

http://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen-test-framework.git

I'll add a comment telling so.


Juergen


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel