Re: [Minios-devel] [Xen-devel] [MINIOS PATCH v2] Include string.h before console.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.10.17 at 11:28, <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, Oct 05, 2017 at 03:22:33AM -0600, Jan Beulich wrote:
>> >>> On 04.10.17 at 15:51, <wei.liu2@xxxxxxxxxx> wrote:
>> > Starting from Xen commit af8d93564, it is required to include string.h
>> > before console.h.
>> 
>> But that's broken then - there shouldn't be such an effect for
>> anyone updating their public headers. IOW I think this needs
>> to be dealt with by further adjusting console.h, e.g. by
>> making the additions depend on a manifest symbol to be
>> defined.
> 
> This should work.
> 
> This isn't just console.h alone. Any header that uses
> DEFINE_XEN_FLEX_RING will potentially need a manifest symbol. We get
> away so far because the two other headers 9pfs.h and pvcalls.h are
> relatively new.

Right, and for new headers it is fine to establish prereq inclusion
requirements from the very beginning.

Jan


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel