Re: [Minios-devel] [PATCH 04/40] arm64: change physical_address_offset to paddr_t

[Julien Grall <julien.grall@xxxxxxx>]

On 03/11/17 14:22, Volodymyr Babchuk wrote:
> > +
> > +/* Add this to a virtual address to get the physical address */
> > +extern paddr_t physical_address_offset;
> >
> >   #define PAGE_SHIFT        12
> >   #define PAGE_SIZE        (1 << PAGE_SHIFT)
> > --
> > 2.7.4
> IIRC, like you used PAGE_SHIFT in patch 2. But you introduce it only
> in this patch.  I think you should move this change to the right
> place.
There are no '+' in front :). The define has been existing for quite a 
while in the tree.
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel