|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Minios-devel] [PATCH 32/40] arm: parse out the address/size for gicd/gicc
Hi, On 09/11/17 06:21, Huang Shijie wrote: On Wed, Nov 08, 2017 at 10:56:50AM +0000, Julien Grall wrote:On 08/11/17 09:22, Huang Shijie wrote:On Mon, Nov 06, 2017 at 05:48:35PM +0000, Julien Grall wrote:On 03/11/17 03:12, Huang Shijie wrote: have a function reading an arbitrary number of cells and return a 64-bit value. This function could be implemented with a loop for instance. Lastly, I would really prefer if we have a file containing FDT helpers rather than open-coding them in gic.ccould you please give the functions? I searched the FDT, and did not found the proper function for the parsing.I didn't say it was existing in the libfdt, but suggesting to create a new file in Mini-OS containing all the FDT helpers. You will need the same for GICv3 and other driver...okay, in this way, we do _not_ need FDT module at all. I will drop the FDT module in next version. It is not what I suggested. What I suggested is you import libfdt in a directory and in a separate file you provide FDT helpers specific to Mini-OS. They could be based on function from libfdt. There does not seem to have any sort of coding style in that file... It is rather annoying to read it because of that. Wei, Samuel, do you have a pointer to Mini-OS coding style?this is the kernel coding style.... I am quite amazed you spent time for that... Yes if you look closely you can find place which does not seem to follow the coding style of the rest of the file... Cheers, -- Julien Grall _______________________________________________ Minios-devel mailing list Minios-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |