Re: [Minios-devel] [PATCH 25/40] arm64: set the stack for the arm_start_thread

[Huang Shijie <shijie.huang@xxxxxxx>]

On Thu, Nov 09, 2017 at 11:08:52AM +0000, Julien Grall wrote:
Hi Julien,
> 
> By justification, I was expecting you to describe the layout of the Arm32
> stack and explain why you think this was not set...
> 
> Anyway, I had a look at it. On Arm32, sp and lr are read with:
> 
>       stmia   r0, {sp, lr}    @ Store current sp and ip to prev's struct 
> thread
> 
> As the comment says, the sp/lr is stored in struct thread. r0 actually
> points to &thread.sp. So it is not stored on the stack and can't see how you
> say this will go wrong.
I simulate it again, and found that you are right, we do not need this
patch.

Thanks
Huang Shijie

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel