Re: [Minios-devel] [PATCH RFC 00/16] Save/Restore Support for mini-OS PVH

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

About patch 15, it seems your terminal is set to see tabs as 4 spaces.
Where tabs are used, the mini-os source code assumes 8 spaces. Avoid
using tabs, just use spaces :)

And, avoid

for (list = dev_list; list->next != NULL; list = list->next);

better write

for (list = dev_list; list->next != NULL; list = list->next)
        ;

to make it explicit that the loop is empty.

Also, 

     *ip = malloc(strlen(ldev->ip) + 1);
     strncpy(*ip, ldev->ip, strlen(ldev->ip) + 1);

can be a mere *ip = strdup(ldev->ip), can't it?

Apart from that,

Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Samuel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel