Re: [Minios-devel] [UNIKRAFT PATCH 1/9] build: Adjust sed script to avoid treating arm64 as arm

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi,

thanks for the patch series. Simon can probably say more about the 
layout redesign, but browsing over your patch, I found this:
On 03/15/2018 04:39 AM, Wei Chen wrote:
> -                      -e 's/arm.*/arm/' \
> +                      -e 's/arm[^6^4].*/arm/' \
[and two more times below that]

I don't think this does the right thing. This matches any line that 
starts with arm, then does not have a single next character that is 
either a 4, a 6, or a ^, and then whatever comes after. So this line 
converts "arm3XYZ" to "arm", but not "arm4XYZ" or "arm^XYZ".
Instead you probably want to match anything that says "arm", followed by 
something, except if it contains the string arm64?
I think this should work instead:

-e '/arm64/! s/arm.*/arm/'

so, only apply the original line if it doesn't contain arm64.

Cheers,
Florian

--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel