Re: [Minios-devel] [PATCH v2 15/47] arm64: time.c: fix the wrong format for printk

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Huang Shijie, on jeu. 15 mars 2018 04:52:22 +0000, wrote:
> We will meet the compiler error for the current code:
>   --------------------------------------------------
>   time.c: In function ‘init_time’:
>   time.c:131:12: error: format ‘%llx’ expects argument of
>          type ‘long long unsigned int’, but argument 2 has
>        type ‘uint64_t {aka long unsigned int}’ [-Werror=format=]
>       printk("Virtual Count register is %llx, freq = %d Hz\n", 
> cntvct_at_init, counter_freq);
>                    ^
>   cc1: all warnings being treated as errors
>   --------------------------------------------------
> 
> This patch fixes the compiling error.
> 
> Signed-off-by: Huang Shijie <shijie.huang@xxxxxxx>

Perhaps rather use PRIx64 to keep it lowercase, but otherwise:

Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
>  arch/arm/time.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/time.c b/arch/arm/time.c
> index 84032fe..42b6848 100644
> --- a/arch/arm/time.c
> +++ b/arch/arm/time.c
> @@ -11,6 +11,7 @@
>  #include <mini-os/types.h>
>  #include <mini-os/time.h>
>  #include <mini-os/lib.h>
> +#include <inttypes.h>
>  
>  //#define VTIMER_DEBUG
>  #ifdef VTIMER_DEBUG
> @@ -134,7 +135,8 @@ void init_time(void)
>  
>      __asm__ __volatile__("mrc p15, 0, %0, c14, c0, 0":"=r"(counter_freq));
>      cntvct_at_init = read_virtual_count();
> -    printk("Virtual Count register is %llx, freq = %d Hz\n", cntvct_at_init, 
> counter_freq);
> +    printk("Virtual Count register is %"PRIX64", freq = %d Hz\n",
> +         cntvct_at_init, counter_freq);
>  }
>  
>  void fini_time(void)
> -- 
> 2.7.4
> 

-- 
Samuel
 jr> J'ai fait.
 Ne bougez pas, l'aide soignante va venir nettoyer.
 -+- FF in GNU - Le vieil homme et la merde -+-

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel