Re: [Minios-devel] [PATCH v3 05/43] arm: create a new header for the page macros

[Huang Shijie <shijie.huang@xxxxxxx>]

On Mon, Apr 16, 2018 at 04:44:14PM +0100, Julien Grall wrote:
> Hi,
> 
> On 16/04/18 07:31, Huang Shijie wrote:
> >Create a new header to store the page macros.
> >
> >This header will be used in the assembly code and C code.
> >
> >Signed-off-by: Huang Shijie <shijie.huang@xxxxxxx>
> >---
> >  include/arm/arch_limits.h | 2 +-
> >  include/arm/arch_mm.h     | 4 +---
> >  include/arm/page_def.h    | 8 ++++++++
> >  3 files changed, 10 insertions(+), 4 deletions(-)
> >  create mode 100644 include/arm/page_def.h
> >
> >diff --git a/include/arm/arch_limits.h b/include/arm/arch_limits.h
> >index bae99e1..23a491f 100644
> >--- a/include/arm/arch_limits.h
> >+++ b/include/arm/arch_limits.h
> >@@ -1,7 +1,7 @@
> >  #ifndef __ARCH_LIMITS_H__
> >  #define __ARCH_LIMITS_H__
> >-#include <mm.h>
> >+#include <page_def.h>
> >  #define __STACK_SIZE_PAGE_ORDER  2
> >  #define __STACK_SIZE (4 * PAGE_SIZE)
> >diff --git a/include/arm/arch_mm.h b/include/arm/arch_mm.h
> >index 98b86af..c89d1aa 100644
> >--- a/include/arm/arch_mm.h
> >+++ b/include/arm/arch_mm.h
> >@@ -8,9 +8,7 @@ extern int _boot_stack[];
> >  extern int _boot_stack_end[];
> >  extern uint32_t physical_address_offset;   /* Add this to a virtual 
> > address to get the physical address (wraps at 4GB) */
> >-#define PAGE_SHIFT        12
> >-#define PAGE_SIZE        (1 << PAGE_SHIFT)
> >-#define PAGE_MASK       (~(PAGE_SIZE-1))
> >+#include <page_def.h>
> >  #define DEF_PAGE_PROT     0
> >diff --git a/include/arm/page_def.h b/include/arm/page_def.h
> >new file mode 100644
> >index 0000000..354680c
> >--- /dev/null
> >+++ b/include/arm/page_def.h
> >@@ -0,0 +1,8 @@
> >+#ifndef _ARM_PAGE_DEF_H_
> >+#define _ARM_PAGE_DEF_H_
> >+
> >+#define PAGE_SHIFT        12
> >+#define PAGE_SIZE         (1 << PAGE_SHIFT)
> 
> Should there be any UL somewhere here? Otherwise the conversion might be
> wrong below.
Thanks a lot. I will add the UL in the next version.

Thanks
Huang Shijie

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel