Re: [Minios-devel] [PATCH v3 09/43] arm64: add the __PAGE_SIZE macro in header file

[Julien Grall <julien.grall@xxxxxxx>]

Hi Shijie,

On 16/04/18 07:31, Huang Shijie wrote:
> The __PAGE_SIZE is needed by the include/posix/limits.h.
>
> Signed-off-by: Huang Shijie <shijie.huang@xxxxxxx>
> ---
>   include/arm/arch_limits.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/arm/arch_limits.h b/include/arm/arch_limits.h
> index 23a491f..de047b0 100644
> --- a/include/arm/arch_limits.h
> +++ b/include/arm/arch_limits.h
> @@ -3,6 +3,8 @@
>   
>   #include <page_def.h>
>   
> +#define __PAGE_SIZE       (1UL << PAGE_SHIFT)
This looks a bit odd to me. __* is used to define the non-underscore 
version. Have a look at posix/limits.h.
This make me realize that page_def.h is introducing the non-underscore 
version. So I think page_def.h should be fixed. Most likely, you want to 
fold page_def.h in arch_limits.h because this is pointless to have a 
header just defining 3 macro and included only twice.
Cheers,

> +
>   #define __STACK_SIZE_PAGE_ORDER  2
>   #define __STACK_SIZE (4 * PAGE_SIZE)
>   
--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel