[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [PATCH v3 10/43] arm64: add exception support



Hi,

I forgot to mention...

On 16/04/2018 07:31, Huang Shijie wrote:
diff --git a/include/arm/traps.h b/include/arm/traps.h
index 704df22..b076f41 100644
--- a/include/arm/traps.h
+++ b/include/arm/traps.h
@@ -1,20 +1 @@
-#ifndef _TRAPS_H_
-#define _TRAPS_H_
-
-struct pt_regs {
-    unsigned long r0;
-    unsigned long r1;
-    unsigned long r2;
-    unsigned long r3;
-    unsigned long r4;
-    unsigned long r5;
-    unsigned long r6;
-    unsigned long r7;
-    unsigned long r8;
-    unsigned long r9;
-    unsigned long r10;
-    unsigned long r11;
-    unsigned long r12;
-};
-
-#endif
+#include <mini-os/arm64/traps.h>

... can this please be surround with an ifdef arm64 and throw an error if not defined?

So this will help to get when the arm32 port is added.

Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.