Re: [Minios-devel] [PATCH v3 11/43] arm64: dump the registers for do_bad_mode()/do_sync()

[Julien Grall <julien.grall@xxxxxxx>]

Hi Shijie,

On 19/04/18 11:14, Huang Shijie wrote:
> On Wed, Apr 18, 2018 at 09:06:13PM +0100, Julien Grall wrote:
> > Hi,
> >
> > On 16/04/2018 07:31, Huang Shijie wrote:
> > > This patch adds a new function dump_regs() which can dump the registers
> > > information.
> > >
> > > And the do_bad_mode()/do_sync() will use the function to dump the
> > > registers.
> > >
> > > This patch refers to Volodymyr Babchuk's patch:
> > Do you mean "based on" instead of "refers to"?
> Is there some different?..
IHMO, "based on" is more suitable because your patch is re-using the 
ideas of Volodymyr's patch. "refers to" is more when you want to link to 
a documentation or e-mail. For instance "Please refer to the Arm Arm 
section foo".
A native english speaker should probably be better to explain the 
difference.
> > >   void do_bad_mode(struct pt_regs *regs, int reason,
> > >                     unsigned long esr, unsigned long far)
> > >   {
> > > -    /* TO DO */
> > > +    printk(" Bad abort number : %d\n", reason);
> > What was the purpose of the variable "reason"? Is it because some trap don't
> > give a meaningful error syndrome?
> The "reason" makes it easy to know which trap is from, such IRQ/FIQ.
Hmmm somehow I thought you were dropping the line. My bad, I will avoid 
review patches late at night ;). sorry for the noise.
> I guess it may also can get the error information from the syndrome.
> but need more code to parse out..
Actually the error syndrome is not always valid (for instance in 
interrupt exception). So you would get some trouble.
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel