[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [PATCH v3 14/43] arm64: time.c: fix the wrong format for printk





On 24/04/18 10:16, Huang Shijie wrote:
On Mon, Apr 23, 2018 at 12:03:48PM +0100, Julien Grall wrote:
  #include <mini-os/types.h>
  #include <mini-os/time.h>
  #include <mini-os/lib.h>
+#include <inttypes.h>

Where does the include "inttypes.h" come from?
The PRIX64 is defined in that file.

This does not answer my question. That include does not belongs to the
mini-os repo. So where does "inttypes.h" will come from? I assume that it
I used the cscope(in vim) to locate the PRIX64, and it jumped to the inttypes.h.

will come from the cross-compiler but I remember MiniOS is been quite messy
with standard include.

Maybe We can use the PRIpaddr which is defined in "arch_mm.h".

No. PRIpaddr is related to a physical address. That type may change in the
future.
okay, I will add a define for PRIX64 in the minios header.

Please read my question. I didn't ask to add PRIx64 but wanted to confirm whether it is coming from the cross-compiler or anything else...

Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.