Re: [Minios-devel] [PATCH v3 21/43] arm64: define the CALLEE_SAVED_REGISTERS

[Huang Shijie <shijie.huang@xxxxxxx>]

On Mon, Apr 30, 2018 at 10:33:58AM +0100, Julien Grall wrote:
> 
> 
> On 27/04/18 10:39, Huang Shijie wrote:
> >On Wed, Apr 25, 2018 at 10:23:43PM +0100, Julien Grall wrote:
> >>
> >>
> >>On 25/04/2018 18:33, Julien Grall wrote:
> >>>Hi,
> >>
> >>Hi,
> >>
> >>>
> >>>On 16/04/18 07:32, Huang Shijie wrote:
> >>>>In the arm64, the callee-saved registers are x19 ~ x29.
> >>>
> >>>s/In the/On/.
> >>>
> >>>I think it would be good to mention where that convention comes from as
> >>>this is not very obvious for non-arm expert :). This convention is from
> >>>AAPCS64 [1].
> >okay, I will add this in the next version.
> >>
> >>Also, you want to explain why x19-x29. At first this is not obvious because
> >>the table call x29 "fp" and x19-x28 "callee-saved registers". It took me a
> >>bit to find in the spec the line saying "A subroutine invocation must
> >>preserve the contents of the registers r19-r29 and SP."
> >
> >okay, I add more information for x19 ~ x28?
> 
> I think a pointer to the doc should be enough here.
No problem.

Thanks
Huang Shijie

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel