Re: [Minios-devel] [PATCH v3 10/43] arm64: add exception support

[Huang Shijie <shijie.huang@xxxxxxx>]

On Mon, Apr 30, 2018 at 09:12:27AM +0100, Julien Grall wrote:
> 
> 
> On 28/04/2018 07:20, Huang Shijie wrote:
> >On Wed, Apr 18, 2018 at 06:48:24PM +0100, Julien Grall wrote:
> >>>+    save_registers 1
> >>>+    mov     x0, sp
> >>>+    mrs     x1, esr_el1;
> >>>+    mrs     x2, far_el1;
> >>
> >>Do you expect the mini-OS to always run with interrupt disabled in EL1? If
> >At the beginning, we can run with interrupt disabled in EL1.
> >It makes the code simple. :)
> 
> The question is more what do you expect to run in that exception context.
> Would it ever be possible that the C-Code will re-enable interrupt and then
> you get caught later on?
there is no code to re-enable interrupt in C-code.
I cannot find such code now.

> 
> I am not necessarily asking you to enable the interrupt here. But you surely
> assess the impact of keeping interrupt disabled. Are they going to be
> enabled still for the thread (they run in EL1)?

Do you suggest I should enable the interrupt in the save_registers?

Thanks
Huang Shijie

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel