Re: [Minios-devel] [UNIKRAFT PATCH v2 6/6] plat/xen: Add grant table support for Xen (x86_64)

[Julien Grall <julien.grall@xxxxxxx>]

Hi Costin,

On 28/06/18 13:38, Costin Lupu wrote:
> diff --git a/plat/xen/x86/gnttab.c b/plat/xen/x86/gnttab.c
> new file mode 100644
> index 0000000..add3444
> --- /dev/null
> +++ b/plat/xen/x86/gnttab.c
All the code below does not look x86 specific. Would not it be better to 
keep that in common xen code?
Also, just to confirm, you are only focusing on PV support? PVH/HVM will 
likely require more work (such as calling XENMEM_add_to_physmap with 
XENMAPSPACE_grant_table during setup).
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel