[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCHv4 03/43] arch: Reorganize arch folder to reflect the CPU family schema

On 09/07/18 08:40, Wei Chen wrote:
Hi Julien,

Hi Wei,

+CFLAGS-$(CONFIG_MARCH_A20NEON)    += -mcpu=cortex-a7 -mtune=cortex-a7 -
mfpu=vfpv4-d16 -mfpu=neon-vfpv4 -funsafe-math-optimizations
+CXXFLAGS-$(CONFIG_MARCH_A20NEON)  += -mcpu=cortex-a7 -mtune=cortex-a7 -
mfpu=vfpv4-d16 -mfpu=neon-vfpv4 -funsafe-math-optimizations
+CFLAGS-$(CONFIG_MARCH_CORTEXA7)   += -mcpu=cortex-a7 -mtune=cortex-a7
+CXXFLAGS-$(CONFIG_MARCH_CORTEXA7) += -mcpu=cortex-a7 -mtune=cortex-a
+$(eval $(call addlib,libarmmath))
diff --git a/arch/arm/divsi3.S b/arch/arm/arm/divsi3.S
similarity index 97%
rename from arch/arm/divsi3.S
rename to arch/arm/arm/divsi3.S

I understand that you reorganize the folder, and this should just be a
pure renaming. So why does the code is modified?

I was curious about this before. Because in this file, there are
space characters at the end of lines in these files.

It is usually better to have code movement and code cleanup in separate patches. I will let the maintainers decide what they prefer here.

However, can you at least please mention in the commit message?


Julien Grall

Minios-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.