Re: [Minios-devel] [UNIKRAFT PATCHv4 25/43] plat/kvm: Add interrupt handle APIs for arm64

[Julien Grall <julien.grall@xxxxxxx>]

On 09/07/18 10:53, Wei Chen wrote:
> Hi Julien,
Hi Wei,

> > -----Original Message-----
> > From: Julien Grall <julien.grall@xxxxxxx>
> > Sent: 2018年7月9日 4:56
> > To: Wei Chen <Wei.Chen@xxxxxxx>; minios-devel@xxxxxxxxxxxxxxxxxxxx;
> > simon.kuenzer@xxxxxxxxx
> > Cc: Kaly Xin <Kaly.Xin@xxxxxxx>; nd <nd@xxxxxxx>
> > Subject: Re: [Minios-devel] [UNIKRAFT PATCHv4 25/43] plat/kvm: Add interrupt
> > handle APIs for arm64
> >
> > Hi Wei,
> >
> > On 07/06/2018 10:03 AM, Wei Chen wrote:
> > > These APIs are necessary for Unikraft. We have provided local CPU
> > > interrupt functions already, so they can be wrapped in lcpu.c easily.
> > > But we haven't implemented GIC libraries, so the APIs in intctrl.c
> > > are TODO.
> > >
> > > Signed-off-by: Wei Chen <Wei.Chen@xxxxxxx>
> > > ---
> > >    plat/kvm/arm/intctrl.c | 24 ++++++++++++++
> > >    plat/kvm/arm/lcpu.c    | 75 ++++++++++++++++++++++++++++++++++++++++++
> > >    2 files changed, 99 insertions(+)
> > >    create mode 100644 plat/kvm/arm/intctrl.c
> > >    create mode 100644 plat/kvm/arm/lcpu.c
> > >
> > > diff --git a/plat/kvm/arm/intctrl.c b/plat/kvm/arm/intctrl.c
> > > new file mode 100644
> > > index 0000000..1039d7c
> > > --- /dev/null
> > > +++ b/plat/kvm/arm/intctrl.c
> > > @@ -0,0 +1,24 @@
> > > +/* SPDX-License-Identifier: ISC */
> > > +#include <stdint.h>
> > > +#include <arm/cpu.h>
> > > +#include <kvm/intctrl.h>
> > > +
> > > +void intctrl_init(void)
> > > +{
> > > +       // TO DO
> > > +}
> > > +
> > > +void intctrl_ack_irq(unsigned int irq)
> > > +{
> > > +       // TO DO
> > > +}
> > > +
> > > +void intctrl_mask_irq(unsigned int irq)
> > > +{
> > > +       // TO DO
> > > +}
> > > +
> > > +void intctrl_clear_irq(unsigned int irq)
> > > +{
> > > +       // TO DO
> > > +}
> >   From a quick grep in unikraft, I don't see any user of those helpers.
> > So why are they defined?
>
> Without these, we will get link error at final stage.
> You have to grep in Unikraft/staging branch
Thanks, when I cloned unikraft the default branch is master. It looks 
like it is quite different staging.
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel