Re: [Minios-devel] [UNIKRAFT PATCH] Fix paths in Makefile in helloworld example

[Wei Liu <wei.liu2@xxxxxxxxxx>]

Cc minios-devel

On Tue, Jul 10, 2018 at 12:08:11AM +0300, Costin Lupu wrote:
> Hey Wei,
> 
> There is a proposed directory structure/layout (honestly, I don't
> remember if and how it's documented) for an Unikraft (let's say)
> distribution. And that structure is best exemplified by the helloworld
> application Makefile. The structure would be something like this:
> 
> mydistro $ tree -L 2
> .
> ├── apps
> │   └── helloworld
> ├── libs
> │   ├── lwip
> │   └── newlib
> └── unikraft
>     ...
> 
> The Unikraft kernel/core is on the same level as the external libs and
> applications. So, for sure there should be more libs, grouped in a
> single directory. The same applies for the applications. Most probably
> this patch would get rejected.
> 

Oh, rejecting this patch is fine. I'm not sure I got everything right
anyway.

> Maybe the real issue here is some missing documentation? Or that the
> structure isn't clear enough?

I tried to follow
https://wiki.xenproject.org/wiki/Category:Unikraft_Users

but helloworld wouldn't build unless I made these changes.

The wiki page seemed to suggest a different layout than yours, i.e. apps
is under unikraft (source code) directory, because when you clone
unikraft.git the end result is a directory called unikraft. But now I
read it a second time it is more likely to describe what you said above.

Anyway, I think this patch should be dropped.

Wei.

> 
> My two cents,
> Costin
> 
> 
> On 07/09/2018 07:17 PM, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 6012528..24c8df3 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1,5 +1,5 @@
> > -UK_ROOT ?= $(PWD)/../../unikraft
> > -UK_LIBS ?= $(PWD)/../../libs
> > +UK_ROOT ?= $(PWD)/../..
> > +UK_LIBS ?= $(PWD)/../../lib
> >  LIBS :=
> >  
> >  all:
> > 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel