[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 1/2] arch/arm: Remove redundant space characters and blank line



Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 11.07.2018 11:16, Wei Chen wrote:
There are some space characters at the end of code lines and
one more blank line at the end of the source file. These spaces
are redundant, we remove them in this patch.

Signed-off-by: Wei Chen <Wei.Chen@xxxxxxx>
---
  arch/arm/divsi3.S  | 17 ++++++++---------
  arch/arm/ldivmod.S |  2 +-
  2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/arch/arm/divsi3.S b/arch/arm/divsi3.S
index fa92233..23edbf7 100644
--- a/arch/arm/divsi3.S
+++ b/arch/arm/divsi3.S
@@ -20,7 +20,7 @@
#define END(symbol) -/*
+/*
   * stack is aligned as there's a possibility of branching to L_overflow
   * which makes a C call
   */
@@ -55,9 +55,9 @@ ENTRY_NP(__aeabi_uidivmod)
  #endif
  ENTRY_NP(__udivsi3)
  .L_udivide:                           /* r0 = r0 / r1; r1 = r0 % r1 */
-       eor     r0, r1, r0
-       eor     r1, r0, r1
-       eor     r0, r1, r0
+       eor     r0, r1, r0
+       eor     r1, r0, r1
+       eor     r0, r1, r0
                                        /* r0 = r1 / r0; r1 = r1 % r0 */
        cmp     r0, #1
        bcc     .L_overflow
@@ -86,9 +86,9 @@ ENTRY_NP(__aeabi_idivmod)
  #endif
  ENTRY_NP(__divsi3)
  .L_divide:                            /* r0 = r0 / r1; r1 = r0 % r1 */
-       eor     r0, r1, r0
-       eor     r1, r0, r1
-       eor     r0, r1, r0
+       eor     r0, r1, r0
+       eor     r1, r0, r1
+       eor     r0, r1, r0
                                        /* r0 = r1 / r0; r1 = r1 % r0 */
        cmp     r0, #1
        bcc     .L_overflow
@@ -107,7 +107,7 @@ ENTRY_NP(__divsi3)
/*
         * If the highest bit of the dividend is set, we have to be
-        * careful when shifting the divisor. Test this.
+        * careful when shifting the divisor. Test this.
         */
        movs    r1,r1
        bpl     .L_old_code
@@ -401,4 +401,3 @@ ENTRY_NP(__divsi3)
  END(__aeabi_idiv)
  END(__aeabi_idivmod)
  END(__divsi3)
-
diff --git a/arch/arm/ldivmod.S b/arch/arm/ldivmod.S
index 3c3083b..180227c 100644
--- a/arch/arm/ldivmod.S
+++ b/arch/arm/ldivmod.S
@@ -34,7 +34,7 @@
/*
   * These calculate:
- * q = n / m
+ * q = n / m
   * With a remainer r.
   *
   * They take n in {r0, r1} and m in {r2, r3} then pass them into the


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.