Re: [Minios-devel] [UNIKRAFT PATCH v2] plat/kvm: Add VGA textmode console support.

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi,

On 07/21/2018 08:56 PM, Dafna Hirschfeld wrote:
>     This didn't build for me in my testing environment with "unknown
>     type name ‘size_t’" errors. You need to #include <stddef.h> here.
>     This might have been masked by other build options in your build
>     that implicitly included it somewhere down the line.
>
>
> I compile the code on top of the staging branch through the helloworld 
> repository, https://xenbits.xen.org/git-http/unikraft/apps/helloworld.git
> I also see that stdint.h includes stddef.h . I wonder why I am able to 
> compile and you aren't.
Aha, now I see the problem. It indeed builds with the unikraft-provided 
nolibc. However, it does not build with newlib, which I use in my 
testing environment, because newlib's stdint.h does not include 
stddef.h. Actually, now that I think about it, maybe stddef.h isn't even 
the best to include (as I suggested originally), but rather sys/types.h, 
because it's really all about the size_t, which is provided by 
sys/types.h, and stddef.h just includes that one plus a bunch of other 
things.
On a related not, now I wonder whether including stddef.h from stdint.h 
in nolibc is actually a bad idea, because it masks problems that occur 
once people use a real libc. For comparison, I went and checked how some 
other standard implementations do it, and indeed, neither glibc nor musl 
include stddef.h from stdint.h. Maybe we should remove that include in 
nolibc and fix the potentially resulting build errors for better 
compatibility?
Cheers,
FLorian


--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel