[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 4/4] lib/nolibc: adapt sscanf code for Unikraft

On 07/30/2018 01:50 PM, Yuri Volchkov wrote:
Florian Schmidt <florian@xxxxxxxxx> writes:

On 07/27/2018 05:29 PM, Yuri Volchkov wrote:
1) Use the right includes
2) (u_)quad_t => (u)int64_t
3) u_char => unsigned char
4) strto(u)q => strto(u)ll
5) bcopy => memmove
6) fix warnings generated by modern gcc (8.1.1)

That's the explicit casts to ccfntype and int that you added?
Is it a question regarding Nr 6? Then the answer is inline. Otherwise,
could you clarify it a bit, please?

Yes, it was about that.

diff --git a/lib/nolibc/stdio.c b/lib/nolibc/stdio.c
index 7e3d368..3a32907 100644
--- a/lib/nolibc/stdio.c
+++ b/lib/nolibc/stdio.c
@@ -289,6 +289,7 @@ reswitch:
                        goto handle_nosign;
                case 'X':
                        upper = 1;
+                       /* Fall through */
                case 'x':
                        base = 16;
                        goto handle_nosign;

That last bit is unrelated to the rest of the patch?
Oh.. That was me not careful enough. Will remove it. And this was
actually the number 6 ("fix warnings generated by modern gcc") from the
commit message, if you question was about that.

It probably would not hurt to send a separate patch (outside of this
series), since I already hit this thing.

Yeah, I think it makes sense, just as an separate patch.

Minios-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.