[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH] fix fall-through warning



I am going to update the commit subject in order to make it inline with our convention.

Thanks!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 30.07.2018 17:50, Yuri Volchkov wrote:
Newer gcc complains about a switch-case without "break" or
"Fall-through" comments

Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
---
  lib/nolibc/stdio.c        | 1 +
  lib/ukargparse/argparse.c | 4 ++--
  2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/nolibc/stdio.c b/lib/nolibc/stdio.c
index 7e3d368..3a32907 100644
--- a/lib/nolibc/stdio.c
+++ b/lib/nolibc/stdio.c
@@ -289,6 +289,7 @@ reswitch:
                        goto handle_nosign;
                case 'X':
                        upper = 1;
+                       /* Fall through */
                case 'x':
                        base = 16;
                        goto handle_nosign;
diff --git a/lib/ukargparse/argparse.c b/lib/ukargparse/argparse.c
index db1f728..20fd944 100644
--- a/lib/ukargparse/argparse.c
+++ b/lib/ukargparse/argparse.c
@@ -74,9 +74,9 @@ int uk_argnparse(char *argb, __sz maxlen, char *argv[], int 
maxcount)
                                break;
                        }
                        in_quote = argb[i];
-
-               /* any character */
+                       /* Fall through */
                default:
+                       /* any character */
                        if (prev_wspace) {
                                argv[argc++] = &argb[i];
                                prev_wspace = 0;


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.