[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Minios-devel] [UNIKRAFT PATCH] plat/kvm: Do not clear VGA console when at 0-position



This is a leftover from the original behavior where the screen was
cleared and written from the top again when it reached the bottom, which
was changed to the more common scrolling behavior in patch 1d864df. Not
only is this unnecessary now, but if we ever implement support for a
curses-like system where we can write to arbitrary locations on the
screen, this would produce a bug that clears the screen when it's not
supposed to.

Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
---
 plat/kvm/x86/vga_console.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/plat/kvm/x86/vga_console.c b/plat/kvm/x86/vga_console.c
index a1b5cf7..ff825e3 100644
--- a/plat/kvm/x86/vga_console.c
+++ b/plat/kvm/x86/vga_console.c
@@ -119,9 +119,6 @@ static void vga_newline(void)
 
 void _libkvmplat_vga_putc(char c)
 {
-       if (terminal_column == 0 && terminal_row == 0)
-               clear_terminal();
-
        switch (c) {
        case '\a':
                break; //ascii bel (0x07) - ignore
-- 
2.18.0


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.