Re: [Minios-devel] [UNIKRAFT PATCH v2 01/10] errptr.h: include errno.h

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Costin,

On 23.08.2018 12:59, Costin Lupu wrote:
> Given that definitions from errptr.h are using together
> with errno numbers, it would make sense to simply include
> errno.h in errptr.h.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   include/uk/errptr.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/uk/errptr.h b/include/uk/errptr.h
> index 5806f73..27aa7d8 100644
> --- a/include/uk/errptr.h
> +++ b/include/uk/errptr.h
> @@ -36,6 +36,7 @@
>   #ifndef __UK_ERRPTR_H__
>   #define __UK_ERRPTR_H__
>   
> +#include <errno.h>
>   #include <uk/arch/types.h>
>   
>   #ifndef MAXERRNO
hum, errptr is just a mechanism to return error codes on functions that 
only return pointers as data type. This header does itself not depend on 
errno, nothing is used from errno. The idea was that you can use this 
mechanism even with your own defined error codes. So, I would keep the 
inclusion of errno.h separate. Just include errno.h on your libraries 
API when these error codes are used there.
Cheers,

Simon

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel