[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v4 3/4] lib/*: Integrate existing lists of exported symbols



Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 08/24/2018 01:11 PM, Simon Kuenzer wrote:
From: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>

Use already existing `export.syms` files for exporting symbols.
This is basically done by renaming `export.syms` to the previously
introduced filename convention `exportsyms.uk`.
lib/fdt provides this file under the name `global.syms`. We rename
this one, too and remove the `objcopy` flags that the library
was defining in its `Makefile.uk`.

Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
  lib/fdt/Makefile.uk        |  3 ---
  lib/fdt/exportsyms.uk      | 62 ++++++++++++++++++++++++++++++++++++++++++++++
  lib/fdt/global.syms        | 62 ----------------------------------------------
  lib/ukbus/export.syms      |  5 ----
  lib/ukbus/exportsyms.uk    |  5 ++++
  lib/uklock/export.syms     |  2 --
  lib/uklock/exportsyms.uk   |  2 ++
  lib/ukmpi/export.syms      |  7 ------
  lib/ukmpi/exportsyms.uk    |  7 ++++++
  lib/ukswrand/export.syms   |  2 --
  lib/ukswrand/exportsyms.uk |  2 ++
  lib/vfscore/export.syms    |  7 ------
  lib/vfscore/exportsyms.uk  |  7 ++++++
  13 files changed, 85 insertions(+), 88 deletions(-)
  create mode 100644 lib/fdt/exportsyms.uk
  delete mode 100644 lib/fdt/global.syms
  delete mode 100644 lib/ukbus/export.syms
  create mode 100644 lib/ukbus/exportsyms.uk
  delete mode 100644 lib/uklock/export.syms
  create mode 100644 lib/uklock/exportsyms.uk
  delete mode 100644 lib/ukmpi/export.syms
  create mode 100644 lib/ukmpi/exportsyms.uk
  delete mode 100644 lib/ukswrand/export.syms
  create mode 100644 lib/ukswrand/exportsyms.uk
  delete mode 100644 lib/vfscore/export.syms
  create mode 100644 lib/vfscore/exportsyms.uk

diff --git a/lib/fdt/Makefile.uk b/lib/fdt/Makefile.uk
index 348e0f9..03251f6 100644
--- a/lib/fdt/Makefile.uk
+++ b/lib/fdt/Makefile.uk
@@ -14,6 +14,3 @@ LIBFDT_SRCS-y += $(LIBFDT_BASE)/fdt_rw.c
  LIBFDT_SRCS-y += $(LIBFDT_BASE)/fdt_strerror.c
  LIBFDT_SRCS-y += $(LIBFDT_BASE)/fdt_sw.c
  LIBFDT_SRCS-y += $(LIBFDT_BASE)/fdt_wip.c
-
-# Globalize only symbols defined in global.syms
-LIBFDT_OBJCFLAGS-y += --globalize-symbols=$(LIBFDT_BASE)/global.syms
diff --git a/lib/fdt/exportsyms.uk b/lib/fdt/exportsyms.uk
new file mode 100644
index 0000000..2fe4c32
--- /dev/null
+++ b/lib/fdt/exportsyms.uk
@@ -0,0 +1,62 @@
+fdt_next_node
+fdt_check_header
+fdt_move
+fdt_string
+fdt_num_mem_rsv
+fdt_get_mem_rsv
+fdt_subnode_offset_namelen
+fdt_subnode_offset
+fdt_path_offset_namelen
+fdt_path_offset
+fdt_get_name
+fdt_get_property_namelen
+fdt_get_property
+fdt_getprop_namelen
+fdt_getprop
+fdt_get_phandle
+fdt_get_alias_namelen
+fdt_get_alias
+fdt_get_path
+fdt_supernode_atdepth_offset
+fdt_node_depth
+fdt_parent_offset
+fdt_node_offset_by_prop_value
+fdt_node_offset_by_phandle
+fdt_node_check_compatible
+fdt_node_offset_by_compatible
+fdt_setprop_inplace
+fdt_nop_property
+fdt_nop_node
+fdt_create
+fdt_add_reservemap_entry
+fdt_finish_reservemap
+fdt_begin_node
+fdt_property
+fdt_end_node
+fdt_finish
+fdt_open_into
+fdt_pack
+fdt_add_mem_rsv
+fdt_del_mem_rsv
+fdt_set_name
+fdt_setprop
+fdt_delprop
+fdt_add_subnode_namelen
+fdt_add_subnode
+fdt_del_node
+fdt_strerror
+fdt_offset_ptr
+fdt_next_tag
+fdt_appendprop
+fdt_create_empty_tree
+fdt_first_property_offset
+fdt_get_property_by_offset
+fdt_getprop_by_offset
+fdt_next_property_offset
+fdt_first_subnode
+fdt_next_subnode
+fdt_address_cells
+fdt_size_cells
+fdt_stringlist_contains
+fdt_resize
+fdt_overlay_apply
diff --git a/lib/fdt/global.syms b/lib/fdt/global.syms
deleted file mode 100644
index 2fe4c32..0000000
--- a/lib/fdt/global.syms
+++ /dev/null
@@ -1,62 +0,0 @@
-fdt_next_node
-fdt_check_header
-fdt_move
-fdt_string
-fdt_num_mem_rsv
-fdt_get_mem_rsv
-fdt_subnode_offset_namelen
-fdt_subnode_offset
-fdt_path_offset_namelen
-fdt_path_offset
-fdt_get_name
-fdt_get_property_namelen
-fdt_get_property
-fdt_getprop_namelen
-fdt_getprop
-fdt_get_phandle
-fdt_get_alias_namelen
-fdt_get_alias
-fdt_get_path
-fdt_supernode_atdepth_offset
-fdt_node_depth
-fdt_parent_offset
-fdt_node_offset_by_prop_value
-fdt_node_offset_by_phandle
-fdt_node_check_compatible
-fdt_node_offset_by_compatible
-fdt_setprop_inplace
-fdt_nop_property
-fdt_nop_node
-fdt_create
-fdt_add_reservemap_entry
-fdt_finish_reservemap
-fdt_begin_node
-fdt_property
-fdt_end_node
-fdt_finish
-fdt_open_into
-fdt_pack
-fdt_add_mem_rsv
-fdt_del_mem_rsv
-fdt_set_name
-fdt_setprop
-fdt_delprop
-fdt_add_subnode_namelen
-fdt_add_subnode
-fdt_del_node
-fdt_strerror
-fdt_offset_ptr
-fdt_next_tag
-fdt_appendprop
-fdt_create_empty_tree
-fdt_first_property_offset
-fdt_get_property_by_offset
-fdt_getprop_by_offset
-fdt_next_property_offset
-fdt_first_subnode
-fdt_next_subnode
-fdt_address_cells
-fdt_size_cells
-fdt_stringlist_contains
-fdt_resize
-fdt_overlay_apply
diff --git a/lib/ukbus/export.syms b/lib/ukbus/export.syms
deleted file mode 100644
index db4476d..0000000
--- a/lib/ukbus/export.syms
+++ /dev/null
@@ -1,5 +0,0 @@
-uk_bus_count
-uk_bus_init
-uk_bus_probe
-_uk_bus_register
-_uk_bus_unregister
diff --git a/lib/ukbus/exportsyms.uk b/lib/ukbus/exportsyms.uk
new file mode 100644
index 0000000..db4476d
--- /dev/null
+++ b/lib/ukbus/exportsyms.uk
@@ -0,0 +1,5 @@
+uk_bus_count
+uk_bus_init
+uk_bus_probe
+_uk_bus_register
+_uk_bus_unregister
diff --git a/lib/uklock/export.syms b/lib/uklock/export.syms
deleted file mode 100644
index bbb4d12..0000000
--- a/lib/uklock/export.syms
+++ /dev/null
@@ -1,2 +0,0 @@
-uk_semaphore_init
-uk_mutex_init
diff --git a/lib/uklock/exportsyms.uk b/lib/uklock/exportsyms.uk
new file mode 100644
index 0000000..bbb4d12
--- /dev/null
+++ b/lib/uklock/exportsyms.uk
@@ -0,0 +1,2 @@
+uk_semaphore_init
+uk_mutex_init
diff --git a/lib/ukmpi/export.syms b/lib/ukmpi/export.syms
deleted file mode 100644
index 4c4c887..0000000
--- a/lib/ukmpi/export.syms
+++ /dev/null
@@ -1,7 +0,0 @@
-uk_mbox_create
-uk_mbox_free
-uk_mbox_post
-uk_mbox_post_try
-uk_mbox_post_to
-uk_mbox_recv_try
-uk_mbox_recv_to
diff --git a/lib/ukmpi/exportsyms.uk b/lib/ukmpi/exportsyms.uk
new file mode 100644
index 0000000..4c4c887
--- /dev/null
+++ b/lib/ukmpi/exportsyms.uk
@@ -0,0 +1,7 @@
+uk_mbox_create
+uk_mbox_free
+uk_mbox_post
+uk_mbox_post_try
+uk_mbox_post_to
+uk_mbox_recv_try
+uk_mbox_recv_to
diff --git a/lib/ukswrand/export.syms b/lib/ukswrand/export.syms
deleted file mode 100644
index 92f2be3..0000000
--- a/lib/ukswrand/export.syms
+++ /dev/null
@@ -1,2 +0,0 @@
-uk_swrand_init_r
-uk_swrand_randr_r
diff --git a/lib/ukswrand/exportsyms.uk b/lib/ukswrand/exportsyms.uk
new file mode 100644
index 0000000..92f2be3
--- /dev/null
+++ b/lib/ukswrand/exportsyms.uk
@@ -0,0 +1,2 @@
+uk_swrand_init_r
+uk_swrand_randr_r
diff --git a/lib/vfscore/export.syms b/lib/vfscore/export.syms
deleted file mode 100644
index 9e229a1..0000000
--- a/lib/vfscore/export.syms
+++ /dev/null
@@ -1,7 +0,0 @@
-vfscore_alloc_fd
-vfscore_put_fd
-vfscore_install_fd
-vfscore_get_file
-close
-write
-read
diff --git a/lib/vfscore/exportsyms.uk b/lib/vfscore/exportsyms.uk
new file mode 100644
index 0000000..9e229a1
--- /dev/null
+++ b/lib/vfscore/exportsyms.uk
@@ -0,0 +1,7 @@
+vfscore_alloc_fd
+vfscore_put_fd
+vfscore_install_fd
+vfscore_get_file
+close
+write
+read


--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.