Re: [Minios-devel] [UNIKRAFT PATCH v4 6/9] plat/linuxu: Add linuxu (ARM) interrupts support

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello,

Please find my comment inline:

On 08/20/2018 01:21 PM, Florian Schmidt wrote:
> From: Costin Lupu <costin.lupu@xxxxxxxxx>
>
> Changes:
> - ARM syscall numbers for SIGACTION and SIGPROCMASK
> - ARM asm restorer
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
> ---
>   plat/linuxu/include/linuxu/syscall-arm_32.h | 2 ++
>   plat/linuxu/irq.c                           | 6 ++++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/plat/linuxu/include/linuxu/syscall-arm_32.h 
> b/plat/linuxu/include/linuxu/syscall-arm_32.h
> index 10e0100..b393627 100644
> --- a/plat/linuxu/include/linuxu/syscall-arm_32.h
> +++ b/plat/linuxu/include/linuxu/syscall-arm_32.h
> @@ -46,6 +46,8 @@
>   #define __SC_MUNMAP    91
>   #define __SC_EXIT       1
>   #define __SC_IOCTL     54
> +#define __SC_RT_SIGPROCMASK   126
> +#define __SC_RT_SIGACTION     174
>   #define __SC_TIMER_CREATE     257
>   #define __SC_TIMER_SETTIME    258
>   #define __SC_TIMER_GETTIME    259
> diff --git a/plat/linuxu/irq.c b/plat/linuxu/irq.c
> index 8a9546c..21c97fd 100644
> --- a/plat/linuxu/irq.c
> +++ b/plat/linuxu/irq.c
> @@ -112,7 +112,13 @@ void ukplat_lcpu_irqs_handle_pending(void)
>   }
>   
>   void __restorer(void);
> +#if defined __X86_64__
>   asm("__restorer:mov $15,%rax\nsyscall");
> +#elif defined __ARM_32__

In the sigrestorer.S[1] in glibc implmentation sets up Call frame 
information in front of the restorer function. Should we also not do this?
> +asm("__restorer:mov r7, #0x77\nsvc 0x0");
> +#else
> +#error "Unsupported architecture"
> +#endif
>   
>   static void _irq_handle(int irq)
>   {

[1] 
https://code.woboq.org/userspace/glibc/sysdeps/unix/sysv/linux/arm/sigrestorer.S.html
Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel