[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v4 8/9] plat/linuxu: Add monotonic clock



Hi Sharan,

On 08/30/2018 01:22 PM, Sharan Santhanam wrote:
@@ -47,8 +48,18 @@ static timer_t timerid;
  __nsec ukplat_monotonic_clock(void)
  {
-    /* TODO */
-    return 0;


Why are we using the timespec from the libc here? In the patch 4 of this series we defined our uk platform internal data structure for the signals. I would suggest we define a single design principle and stick with it.
+    struct timespec tp;
+    __nsec ret;
+    int rc;
+
+    rc = sys_clock_gettime(CLOCK_MONOTONIC, &tp);

That's an oversight, thanks for catching this.

Cheers,
Florian

--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.