Re: [Minios-devel] [UNIKRAFT PATCH v5 1/9] lib/nolibc: Provide time defintions in header files

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Florian,

The patch looks fine.

On 08/31/2018 08:57 AM, Florian Schmidt wrote:
> Some already-defined types were not provided by some of our header
> files, when they should, according to POSIX.
>
> Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
> ---
>   lib/nolibc/include/sys/select.h | 5 +++++
>   lib/nolibc/include/sys/types.h  | 2 ++
>   2 files changed, 7 insertions(+)
>
> diff --git a/lib/nolibc/include/sys/select.h b/lib/nolibc/include/sys/select.h
> index e2bc70d..ecdc49a 100644
> --- a/lib/nolibc/include/sys/select.h
> +++ b/lib/nolibc/include/sys/select.h
> @@ -36,6 +36,11 @@
>   extern "C" {
>   #endif
>   
> +#define __NEED_time_t
> +#define __NEED_suseconds_t
> +#define __NEED_struct_timespec
> +#include <nolibc-internal/shareddefs.h>
> +
>   typedef unsigned long __fd_mask;
>   
>   /*
> diff --git a/lib/nolibc/include/sys/types.h b/lib/nolibc/include/sys/types.h
> index 9908855..942b533 100644
> --- a/lib/nolibc/include/sys/types.h
> +++ b/lib/nolibc/include/sys/types.h
> @@ -46,6 +46,8 @@ extern "C" {
>   #define __NEED_size_t
>   #define __NEED_ssize_t
>   #define __NEED_off_t
> +#define __NEED_time_t
> +#define __NEED_suseconds_t
>   #include <nolibc-internal/shareddefs.h>
>   
>   #ifdef __cplusplus

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel