[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v5 5/9] plat/linuxu: Add linuxu (ARM) interrupts support



Hello,

This patch looks fine.

I am fine with decision to revisit the "restorer function" to make sure debugging in signal handlers works.

On 08/31/2018 08:57 AM, Florian Schmidt wrote:
From: Costin Lupu <costin.lupu@xxxxxxxxx>

Changes:
- ARM syscall numbers for SIGACTION and SIGPROCMASK
- ARM asm restorer

Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
---
  plat/linuxu/include/linuxu/syscall-arm_32.h | 2 ++
  plat/linuxu/irq.c                           | 6 ++++++
  2 files changed, 8 insertions(+)

diff --git a/plat/linuxu/include/linuxu/syscall-arm_32.h 
b/plat/linuxu/include/linuxu/syscall-arm_32.h
index e28224d..3a6c29d 100644
--- a/plat/linuxu/include/linuxu/syscall-arm_32.h
+++ b/plat/linuxu/include/linuxu/syscall-arm_32.h
@@ -46,6 +46,8 @@
  #define __SC_MUNMAP    91
  #define __SC_EXIT       1
  #define __SC_IOCTL     54
+#define __SC_RT_SIGPROCMASK   126
+#define __SC_RT_SIGACTION     174
  #define __SC_PSELECT6 335
/* NOTE: from `man syscall`:
diff --git a/plat/linuxu/irq.c b/plat/linuxu/irq.c
index bc21d3f..e7435b3 100644
--- a/plat/linuxu/irq.c
+++ b/plat/linuxu/irq.c
@@ -112,7 +112,13 @@ void ukplat_lcpu_irqs_handle_pending(void)
  }
void __restorer(void);
+#if defined __X86_64__
  asm("__restorer:mov $15,%rax\nsyscall");
+#elif defined __ARM_32__
+asm("__restorer:mov r7, #0x77\nsvc 0x0");
+#else
+#error "Unsupported architecture"
+#endif
static void _irq_handle(int irq)
  {


Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.