[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v5 7/9] plat/linuxu: Build with memory.c from plat/common



Hello,

This patch looks fine.

On 08/31/2018 08:57 AM, Florian Schmidt wrote:
Patch 300c8309 introduced an API for setting the memory allocator. It
added memory.c to the KVM and Xen platform Makefiles, but not to the
linuxu one (which at that time didn't properly build). Now that the
compile errors are fixed, this missing addition leads to a linking error
when compiling for linux userspace. Adding the corresponding line fixes
that.

Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
---
  plat/linuxu/Makefile.uk | 1 +
  1 file changed, 1 insertion(+)

diff --git a/plat/linuxu/Makefile.uk b/plat/linuxu/Makefile.uk
index e34751e..b00540c 100644
--- a/plat/linuxu/Makefile.uk
+++ b/plat/linuxu/Makefile.uk
@@ -33,3 +33,4 @@ LIBLINUXUPLAT_SRCS-y              += 
$(LIBLINUXUPLAT_BASE)/lcpu.c
  LIBLINUXUPLAT_SRCS-y              += $(LIBLINUXUPLAT_BASE)/irq.c
  LIBLINUXUPLAT_SRCS-y              += $(LIBLINUXUPLAT_BASE)/time.c
  LIBLINUXUPLAT_SRCS-y              += $(UK_PLAT_COMMON_BASE)/lcpu.c|common
+LIBLINUXUPLAT_SRCS-y              += $(UK_PLAT_COMMON_BASE)/memory.c|common




Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.