Re: [Minios-devel] [UNIKRAFT PATCH v5 3/9] plat/linuxu: Add linuxu (x86_64) interrupts support

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Sharan,

On 08/31/2018 11:59 AM, Sharan Santhanam wrote:

> Shouldn't be uk_sigval instead of int?
> > +
> > +static inline int sys_sigaction(int signum, const struct uk_sigaction 
> > *action,
> > +        struct uk_sigaction *oldaction)
> > +{
> > +    return (int) syscall4(__SC_RT_SIGACTION,
> > +                  (long) signum,
> > +                  (long) action,
> > +                  (long) oldaction,
> > +                  sizeof(k_sigset_t));
> > +}
This looks ok to me. The syscall will only ever use the int anyway, so 
passing an int in here is ok. The caller of the function may of course 
use uk_sigaction, but would pass the signal number in.
> Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
>
> Thanks & Regards
> Sharan
--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel