[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v4 16/16] include/uk: rename linux_reg_op to __uk_bitops_reg_op



Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 09/06/2018 03:49 PM, Yuri Volchkov wrote:
Apparently this function is used only in bitmap implementation. The
fact that there is "linux" in it's name is a bit confusing. Lets
make sure the name suggests that it is used internally.

Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
---
  include/uk/bitmap.h | 10 +++++-----
  include/uk/bitops.h |  2 +-
  2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/uk/bitmap.h b/include/uk/bitmap.h
index 487ef5f..d6e360a 100644
--- a/include/uk/bitmap.h
+++ b/include/uk/bitmap.h
@@ -181,9 +181,9 @@ uk_bitmap_find_free_region(unsigned long *bitmap, int bits, 
int order)
        int end;
for (pos = 0; (end = pos + (1 << order)) <= bits; pos = end) {
-               if (!linux_reg_op(bitmap, pos, order, REG_OP_ISFREE))
+               if (!__uk_bitopts_reg_op(bitmap, pos, order, REG_OP_ISFREE))
                        continue;
-               linux_reg_op(bitmap, pos, order, REG_OP_ALLOC);
+               __uk_bitopts_reg_op(bitmap, pos, order, REG_OP_ALLOC);
                return pos;
        }
        return (-ENOMEM);
@@ -192,16 +192,16 @@ uk_bitmap_find_free_region(unsigned long *bitmap, int 
bits, int order)
  static inline int
  uk_bitmap_allocate_region(unsigned long *bitmap, int pos, int order)
  {
-       if (!linux_reg_op(bitmap, pos, order, REG_OP_ISFREE))
+       if (!__uk_bitopts_reg_op(bitmap, pos, order, REG_OP_ISFREE))
                return (-EBUSY);
-       linux_reg_op(bitmap, pos, order, REG_OP_ALLOC);
+       __uk_bitopts_reg_op(bitmap, pos, order, REG_OP_ALLOC);
        return 0;
  }
static inline void
  uk_bitmap_release_region(unsigned long *bitmap, int pos, int order)
  {
-       linux_reg_op(bitmap, pos, order, REG_OP_RELEASE);
+       __uk_bitopts_reg_op(bitmap, pos, order, REG_OP_RELEASE);
  }
static inline unsigned int
diff --git a/include/uk/bitops.h b/include/uk/bitops.h
index 6ed48fd..febe858 100644
--- a/include/uk/bitops.h
+++ b/include/uk/bitops.h
@@ -279,7 +279,7 @@ enum {
  };
static inline int
-linux_reg_op(unsigned long *bitmap, int pos, int order, int reg_op)
+__uk_bitopts_reg_op(unsigned long *bitmap, int pos, int order, int reg_op)
  {
        int nbits_reg;
        int index;


--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.