Re: [Minios-devel] [UNIKRAFT PATCHv5 19/46] plat: Add variables in Config.uk for early debug console

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey,

On 10.08.2018 09:08, Wei Chen wrote:
> Instead of hardcoding, we provide Kconfig variables for users
> to enable early debug console and UART base address of early
> debug console.
>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> ---
>   plat/kvm/Config.uk | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/plat/kvm/Config.uk b/plat/kvm/Config.uk
> index 4378c26..c07f39b 100644
> --- a/plat/kvm/Config.uk
> +++ b/plat/kvm/Config.uk
> @@ -16,7 +16,7 @@ menu "Console Options"
>   config KVM_KERNEL_SERIAL_CONSOLE
>           bool "Serial console for the kernel prints"
>           default y
> -        depends on (LIBUKDEBUG_PRINTK && ARCH_X86_64)
> +        depends on (LIBUKDEBUG_PRINTK && (ARCH_X86_64 || ARCH_ARM_64))
You should not depend this on the libukdebug option. Just provide 
ukplat_coutd() and ukplat_coutk() independent of libukdebug. It is a 
platform API requirement.
>           help
>             Choose serial console for the kernel printing
>   
> @@ -30,7 +30,7 @@ config KVM_KERNEL_VGA_CONSOLE
>   config KVM_DEBUG_SERIAL_CONSOLE
>           bool "Serial console for the debug prints"
>           default y
> -        depends on (LIBUKDEBUG_PRINTD && ARCH_X86_64)
> +        depends on (LIBUKDEBUG_PRINTD && (ARCH_X86_64 || ARCH_ARM_64))
>           help
>             Choose serial console for the debug printing
>   
> @@ -40,6 +40,13 @@ config KVM_DEBUG_VGA_CONSOLE
>           depends on (LIBUKDEBUG_PRINTD && ARCH_X86_64)
>           help
>             Choose VGA console for the debug printing
> +
> +config KVM_EARLY_DEBUG_PL011_UART
> +       hex "Early debug pl011 serial address"
> +       default 0x09000000
> +       depends on (KVM_DEBUG_SERIAL_CONSOLE && ARCH_ARM_64)
> +       help
> +               Pl011 serial address used by early debug console.
>   endmenu
>   
Hum, I think this option should not just be there for the debug console. 
ukplat_coutk() should also go there.
What about KVM_EARLY_PL011_UART_ADDR? and let it depend on ARCH_ARM_64 only


>   config KVM_PCI
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel