Re: [Minios-devel] [UNIKRAFT PATCHv5 13/46] uk/arch: Implement ukarch_ffsl for Arm64

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

On 07.09.2018 12:07, Julien Grall wrote:
> (+ Lars)
>
> On 09/06/2018 12:36 PM, Simon Kuenzer wrote:
> > Hey Julien,
> Hi Simon,
>
> > On 04.09.2018 21:43, Julien Grall wrote:
> > > On 09/04/2018 10:22 AM, Wei Chen (Arm Technology China) wrote:
> > > > > > + */
> > > > > > +/*
> > > > > > + * Copyright (c) 2009 Citrix Systems, Inc. All rights reserved.
> > > > > The copyright looks wrong. There was no Arm port in Mini-OS at that 
> > > > > time.
> > > > So, should I remove this copyrights?
> > > I would leave the confirmation to Simon. He may know why arm32 the 
> > > wrong copyright.
> > This is a good question.
> >
> > The ukarch_ffsl() function is derived from the __ffs() function from 
> > Mini-OS (defined in include/(arm|x86)/os.h). We ported them but 
> > noticed that the os.h files did not had any copyright header. For such 
> > files we took the Mini-OS project license as header. This explains the 
> > 2009.
> > According to the git log, Arm's os.h got actually introduced Aug 8, 
> > 2014 by Karim Allah Ahmed and Thomas Leonard. How would you go about 
> > it, Julien?
> I am not a lawyer here. I have CCed Lars to see if he has an opinion.
>
> My gut feeling is this should be:
>
> Copyright (c) 2014 Karim Allah
> Copyright (c) 2014 Thomas Leonard
Hum... you are probably right. The header is probably still the BSD one 
that we have there? I am also curious about Lars opinion.
> Cheers,
Thanks,

Simon

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel