Re: [Minios-devel] [UNIKRAFT PATCH v3 8/8] build: Remove recursive deletion flag from $(RM)

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Reviewed-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>

Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:

> Doing a recursive deletion transparently just by running $(RM) can be
> harmful. It is wiser to disable recursive deletion and delete only a
> single file. `properclean` is the only Make target that requires
> recursive deletion, so we are setting the `-r` flag there.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e133039..96be2db 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -410,7 +410,7 @@ OBJCOPY           := $(CONFIG_CROSS_COMPILE)objcopy
>  OBJDUMP              := $(CONFIG_CROSS_COMPILE)objdump
>  AR           := ar
>  MV           := mv -f
> -RM           := rm -rf
> +RM           := rm -f
>  CP           := cp -f
>  MKDIR                := mkdir
>  CAT          := cat
> @@ -540,7 +540,7 @@ endif
>  
>  .PHONY: distclean properclean
>  properclean:
> -     $(call verbose_cmd,RM,build/,$(RM) \
> +     $(call verbose_cmd,RM,build/,$(RM) -r \
>               $(BUILD_DIR))
>  
>  distclean: properclean
> -- 
> 2.7.4
>

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel