Re: [Minios-devel] [UNIKRAFT PATCHv6 05/37] plat: Add variables in Config.uk for early debug console

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 14.09.2018 09:56, Wei Chen wrote:
> Instead of hardcoding, we provide Kconfig variables for users
> to enable early debug console and UART base address of early
> debug console.
>
> As both ukplat_coutk and ukplat_coutd will use the PL011 UART
> to print messages. But I still want to make EARLY_PRINT_PL011_UART_ADDR
> depend on KVM_DEBUG_SERIAL_CONSOLE. Because I think before
> ukpalt_init_console, only ukplat_coutd is avaibale, if we call
> ukplat_coutk, we can't confirm it can be succeeded.
>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> ---
>   plat/Config.uk     | 7 +++++++
>   plat/kvm/Config.uk | 6 +++---
>   2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/plat/Config.uk b/plat/Config.uk
> index 7c07921..b776c45 100644
> --- a/plat/Config.uk
> +++ b/plat/Config.uk
> @@ -9,4 +9,11 @@ config UKPLAT_MEMRNAME
>         help
>                 Enable name field in memory region descriptors
>   
> +config EARLY_PRINT_PL011_UART_ADDR
> +       hex "Early debug console pl011 serial address"
> +       default 0x09000000
> +       depends on (KVM_DEBUG_SERIAL_CONSOLE && ARCH_ARM_64)
> +       help
> +               Pl011 serial address used by early debug console.
> +
>   endmenu
> diff --git a/plat/kvm/Config.uk b/plat/kvm/Config.uk
> index 4378c26..9f54a23 100644
> --- a/plat/kvm/Config.uk
> +++ b/plat/kvm/Config.uk
> @@ -16,21 +16,21 @@ menu "Console Options"
>   config KVM_KERNEL_SERIAL_CONSOLE
>           bool "Serial console for the kernel prints"
>           default y
> -        depends on (LIBUKDEBUG_PRINTK && ARCH_X86_64)
> +        depends on (ARCH_X86_64 || ARCH_ARM_64)
>           help
>             Choose serial console for the kernel printing
>   
>   config KVM_KERNEL_VGA_CONSOLE
>           bool "VGA console for the kernel prints"
>           default y
> -        depends on (LIBUKDEBUG_PRINTK && ARCH_X86_64)
> +        depends on  ARCH_X86_64
>           help
>             Choose VGA console for the kernel printing
>   
>   config KVM_DEBUG_SERIAL_CONSOLE
>           bool "Serial console for the debug prints"
>           default y
> -        depends on (LIBUKDEBUG_PRINTD && ARCH_X86_64)
> +        depends on (LIBUKDEBUG_PRINTD && (ARCH_X86_64 || ARCH_ARM_64))
>           help
>             Choose serial console for the debug printing
>   
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel