Re: [Minios-devel] [UNIKRAFT PATCH v4 01/11] lib/uknetdev: Library skeleton

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Simon,

This patch looks good.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>


On 10/10/2018 02:00 PM, Simon Kuenzer wrote:
> From: Razvan Cojocaru <razvan.cojocaru93@xxxxxxxxx>
>
> Add and register libuknetdev library skeleton.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> Signed-off-by: Razvan Cojocaru <razvan.cojocaru93@xxxxxxxxx>
> ---
>   lib/Config.uk            | 1 +
>   lib/Makefile.uk          | 1 +
>   lib/uknetdev/Config.uk   | 5 +++++
>   lib/uknetdev/Makefile.uk | 4 ++++
>   4 files changed, 11 insertions(+)
>   create mode 100644 lib/uknetdev/Config.uk
>   create mode 100644 lib/uknetdev/Makefile.uk
>
> diff --git a/lib/Config.uk b/lib/Config.uk
> index 481d7ab..5cd7585 100644
> --- a/lib/Config.uk
> +++ b/lib/Config.uk
> @@ -39,3 +39,4 @@ source "lib/ukmpi/Config.uk"
>   source "lib/ukswrand/Config.uk"
>   source "lib/ukbus/Config.uk"
>   source "lib/uksglist/Config.uk"
> +source "lib/uknetdev/Config.uk"
> diff --git a/lib/Makefile.uk b/lib/Makefile.uk
> index c7db848..4c2cc87 100644
> --- a/lib/Makefile.uk
> +++ b/lib/Makefile.uk
> @@ -20,3 +20,4 @@ $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uklock))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukmpi))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukbus))
>   $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uksglist))
> +$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uknetdev))
> diff --git a/lib/uknetdev/Config.uk b/lib/uknetdev/Config.uk
> new file mode 100644
> index 0000000..b5e11a9
> --- /dev/null
> +++ b/lib/uknetdev/Config.uk
> @@ -0,0 +1,5 @@
> +config LIBUKNETDEV
> +       bool "uknetdev: Network driver interface"
> +       default n
> +       select LIBNOLIBC if !HAVE_LIBC
> +       select LIBUKDEBUG
> diff --git a/lib/uknetdev/Makefile.uk b/lib/uknetdev/Makefile.uk
> new file mode 100644
> index 0000000..34f30be
> --- /dev/null
> +++ b/lib/uknetdev/Makefile.uk
> @@ -0,0 +1,4 @@
> +$(eval $(call addlib_s,libuknetdev,$(CONFIG_LIBUKNETDEV)))
> +
> +CINCLUDES-$(CONFIG_LIBUKNETDEV)                += -I$(LIBUKNETDEV_BASE)/include
> +CXXINCLUDES-$(CONFIG_LIBUKNETDEV)      += -I$(LIBUKNETDEV_BASE)/include
Thanks & Regards
Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel