[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT-PATCH 2/3] plat/xen/common: Move event channel functions in events.h

Hello Nicolas,

On 18/10/2018 12:40, radunicolau102@xxxxxxxxx wrote:
diff --git a/plat/xen/include/common/events.h b/plat/xen/include/common/events.h
index 971dff9..accddb8 100644
--- a/plat/xen/include/common/events.h
+++ b/plat/xen/include/common/events.h
@@ -47,6 +47,12 @@
  #include <xen/event_channel.h>
  #include <uk/arch/lcpu.h>
+ * TODO revisit: why cpu param?
+ * Taken from linux/drivers/xen/events/events_2l.c

Are you sure about this? In any case, I would be careful about mentioning Linux code in Unikraft as the two license (GPLv2 vs BSD) are not compatible.


Julien Grall

Minios-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.