Re: [Minios-devel] [UNIKRAFT PATCH v2 3/3] plat/xen/common/hypervisor: Delete unused code and comments

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Radu,

Please see my comments inline.

On 10/24/18 4:30 PM, radunicolau102@xxxxxxxxx wrote:
> From: Radu Nicolau <radunicolau102@xxxxxxxxx>
> 
> Delete unused code and deprecated comments
> 
> Signed-off-by: Radu Nicolau <radunicolau102@xxxxxxxxx>
> ---
>  plat/xen/hypervisor.c                |  4 ----
>  plat/xen/include/common/hypervisor.h | 20 --------------------
>  plat/xen/include/xen-x86/setup.h     |  1 -
>  3 files changed, 25 deletions(-)
> 
> diff --git a/plat/xen/hypervisor.c b/plat/xen/hypervisor.c
> index 09d5fa6..fcab7f9 100644
> --- a/plat/xen/hypervisor.c
> +++ b/plat/xen/hypervisor.c
> @@ -44,10 +44,6 @@
>  
>  int in_callback;
>  
> -#ifndef CONFIG_PARAVIRT
> -extern shared_info_t shared_info;
> -#endif /* !CONFIG_PARAVIRT */
> -
>  void do_hypervisor_callback(struct __regs *regs)
>  {
>       unsigned long l1, l2, l1i, l2i;
> diff --git a/plat/xen/include/common/hypervisor.h 
> b/plat/xen/include/common/hypervisor.h
> index 417498e..d131d6f 100644
> --- a/plat/xen/include/common/hypervisor.h
> +++ b/plat/xen/include/common/hypervisor.h
> @@ -48,30 +48,10 @@
>  #else
>  #error "Unsupported architecture"
>  #endif
> -#include <xen/hvm/hvm_op.h>
>  #include <uk/arch/lcpu.h>
>  #include <uk/plat/lcpu.h>
>  
> -#if 0 //TODO: cleanup
> -/*
> - * a placeholder for the start of day information passed up from the 
> hypervisor
> - */
> -union start_info_union {
> -     start_info_t start_info;
> -     char padding[512];
> -};
> -extern union start_info_union start_info_union;
> -#define start_info (start_info_union.start_info)
> -#else
> -int hvm_get_parameter(int idx, uint64_t *value);
> -int hvm_set_parameter(int idx, uint64_t value);
> -#endif
> -shared_info_t *map_shared_info(void *p);
> -
> -//TODO START from here on we have to cleanup/refactor/move stuff
> -/* hypervisor.c */
>  void do_hypervisor_callback(struct __regs *regs);
> -//TODO END
>  
>  extern int in_callback;
>  
> diff --git a/plat/xen/include/xen-x86/setup.h 
> b/plat/xen/include/xen-x86/setup.h
> index 6eaa4f1..7a57190 100644
> --- a/plat/xen/include/xen-x86/setup.h
> +++ b/plat/xen/include/xen-x86/setup.h
> @@ -46,7 +46,6 @@ extern unsigned int _libxenplat_mrd_num;
>  extern struct ukplat_memregion_desc _libxenplat_mrd[];
>  extern char _libxenplat_bootstack[];
>  
> -/* Note: HYPERVISOR_shared_info is defined in os.h */

I guess this change would make sense to be moved in the first patch of
the series, the one removing os.h .

>  extern start_info_t *HYPERVISOR_start_info;
>  
>  #endif /* __SETUP_H__ */
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel