[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/HELLOWORLD PATCH] main.c: Prefix application option with CONFIG_



Thanks for the fix, Cristi!

Reviewed by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 11/6/18 3:40 PM, Cristian Banu wrote:
> Flags generated by kconfig are prefixed with CONFIG_, thus
> APPHELLOWORLD_PRINTARGS will never be defined.
> 
> Signed-off-by: Cristian Banu <cristb@xxxxxxxxx>
> ---
>  main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/main.c b/main.c
> index 44dd1a7571a0..6afa19e96e57 100644
> --- a/main.c
> +++ b/main.c
> @@ -7,7 +7,7 @@ int main(int argc, char *argv[])
>  {
>       printf("Hello world!\n");
>  
> -#if APPHELLOWORLD_PRINTARGS
> +#if CONFIG_APPHELLOWORLD_PRINTARGS
>       int i;
>  
>       printf("Arguments: ");
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.