Re: [Minios-devel] [UNIKRAFT PATCH 4/8] lib/uksched: Introduce thread info

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Costin,

On 9/25/18 12:09 PM, Felipe Huici wrote:
> Hi,
>
>
> > Thread behaviors can be configured by using thread attributes. For
> > keeping this information, we introduce the thread info abstraction.
> > Schedulers should extend this abstraction when adding custom
> > configuration features.
> s/behaviors/behavior
> s/For keeping/To keep
>
> Perhaps add a sentence or two more to explain what “extend” means, e.g.,
> should a scheduler use thread_info_base_create or thread_info_base_init?
Yeah, I also read this and wasn't sure what exactly it means. What is an 
example where a scheduler should extend this? For example, the two 
attributes prio and timeslice that you introduced in the previous patch 
are set up so that they don't need to be kept in tib, but instead 
uk_thread_set_prio calls uk_sched_thread_set_prio, which calls the 
respective scheduler's implementation of what to do with prio and 
timeslice information.
Cheers,
Florian


--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel