[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Minios-devel] [UNIKRAFT PATCHv3 06/25] plat/common: Remove earlycloberr from SYSREG_READ32 for Arm64
Hello Wei Chen, This patch looks fine. Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx> Thanks & Regards Sharan On 12/13/18 10:15 AM, Wei Chen wrote: As the operand will not be written before the instruction has finished. So, we don't need the earlycloberr (&) in SYSREG_READ32. Signed-off-by: Wei Chen <wei.chen@xxxxxxx> --- plat/common/include/arm/arm64/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plat/common/include/arm/arm64/cpu.h b/plat/common/include/arm/arm64/cpu.h index 53fa577..9498a26 100644 --- a/plat/common/include/arm/arm64/cpu.h +++ b/plat/common/include/arm/arm64/cpu.h @@ -69,7 +69,7 @@ __IOREG_WRITE_ALL() #define SYSREG_READ(reg) \ ({ uint64_t val; \ __asm__ __volatile__("mrs %0, " __STRINGIFY(reg) \ - : "=&r" (val)); \ + : "=r" (val)); \ val; \ })@@ -80,7 +80,7 @@ __IOREG_WRITE_ALL()#define SYSREG_READ32(reg) \ ({ uint32_t val; \ __asm__ __volatile__("mrs %0, " __STRINGIFY(reg) \ - : "=&r" (val)); \ + : "=r" (val)); \ val; \ }) _______________________________________________ Minios-devel mailing list Minios-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/minios-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |