Re: [Minios-devel] [UNIKRAFT PATCHv3 09/25] plat/common: Add referred source code URL for cache operation

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Wei Chen,

Please find the comment inline.

Thanks & Regards
Sharan

On 12/13/18 10:15 AM, Wei Chen wrote:
> We'd better to mention where our code comes from, this helps to
> check whether code has been updated afterwards.
>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> ---
>   plat/common/arm/cache64.S | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/plat/common/arm/cache64.S b/plat/common/arm/cache64.S
> index bada417..6aff00d 100644
> --- a/plat/common/arm/cache64.S
> +++ b/plat/common/arm/cache64.S
> @@ -1,5 +1,8 @@
>   /* SPDX-License-Identifier: BSD-3-Clause */
>   /*
> + * This source code is based on:
> + * https://github.com/freebsd/freebsd/blob/master/sys/arm64/arm64/cpufunc_asm.S
> + *
It may be wise to include a git commit-id for reference.

>    * Authors: Wei Chen <wei.chen@xxxxxxx>
>    *
>    * Copyright (c) 2014 Robin Randhawa
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel